gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
   4         (fbsd_pspace_data_handle): Move lower.  Change type.
   5         (get_fbsd_pspace_data): Update.
   6         (fbsd_pspace_data_cleanup): Remove.
   7         (_initialize_fbsd_tdep): Update.
   8
   9 2019-05-08  Tom Tromey  <tom@tromey.com>
  10
  11         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  12         (get_ada_tasks_pspace_data): Update.
  13         (ada_tasks_pspace_data_cleanup): Remove.
  14         (_initialize_tasks): Update.
  15         (ada_tasks_inferior_data_handle): Change type.
  16         (get_ada_tasks_inferior_data): Update.
  17         (ada_tasks_inferior_data_cleanup): Remove.
  18         (struct ada_tasks_pspace_data): Add initializers.
  19
  20 2019-05-08  Tom Tromey  <tom@tromey.com>
  21
  22         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  23         * symfile-debug.c (debug_sym_get_probes): Change type.
  24         * stap-probe.c (handle_stap_probe):
  25         (stap_static_probe_ops::get_probes): Change type.
  26         * probe.h (class static_probe_ops) <get_probes>: Change type.
  27         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  28         (parse_probes_in_pspace): Update.
  29         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  30         Update.
  31         (any_static_probe_ops::get_probes): Change type.
  32         * elfread.c (elfread_data): New typedef.
  33         (probe_key): Change type.
  34         (elf_get_probes): Likewise.  Update.
  35         (probe_key_free): Remove.
  36         (_initialize_elfread): Update.
  37         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  38         Change type.
  39         (dtrace_process_dof_probe, dtrace_process_dof)
  40         (dtrace_static_probe_ops::get_probe): Change type.
  41
  42 2019-05-08  Tom Tromey  <tom@tromey.com>
  43
  44         * xcoffread.c (struct xcoff_symfile_info): Rename from
  45         coff_symfile_info.  Add initializers.
  46         (xcoff_objfile_data_key): Move lower.  Change type.
  47         (XCOFF_DATA): Rewrite.
  48         (xcoff_free_info): Remove.
  49         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  50         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  51         (xcoff_initial_scan): Update.
  52
  53 2019-05-08  Tom Tromey  <tom@tromey.com>
  54
  55         * solib-svr4.c (struct svr4_info): Add initializers and
  56         destructor.
  57         <probes_table>: Now an htab_up.
  58         (solib_svr4_pspace_data): Change type.
  59         (free_probes_table): Simplify.
  60         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  61         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  62         (probes_table_remove_objfile_probes, register_solib_event_probe)
  63         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  64         (_initialize_svr4_solib): Update.
  65
  66 2019-05-08  Tom Tromey  <tom@tromey.com>
  67
  68         * remote.c (remote_pspace_data): Change type.
  69         (remote_pspace_data_cleanup): Remove.
  70         (get_remote_exec_file, set_pspace_remote_exec_file)
  71         (_initialize_remote): Update.
  72
  73 2019-05-08  Tom Tromey  <tom@tromey.com>
  74
  75         * breakpoint.c (breakpoint_objfile_key): Change type.
  76         (get_breakpoint_objfile_data): Update.
  77         (free_breakpoint_objfile_data): Remove.
  78         (_initialize_breakpoint): Update.
  79
  80 2019-05-08  Tom Tromey  <tom@tromey.com>
  81
  82         * linux-tdep.c (struct linux_info): Add initializers.
  83         (linux_inferior_data): Move.  Change type.
  84         (invalidate_linux_cache_inf): Update.
  85         (linux_inferior_data_cleanup): Remove.
  86         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  87
  88 2019-05-08  Tom Tromey  <tom@tromey.com>
  89
  90         * auxv.c (auxv_inferior_data): Move.  Change type.
  91         (auxv_inferior_data_cleanup): Remove.
  92         (invalidate_auxv_cache_inf): Rewrite.
  93         (get_auxv_inferior_data, _initialize_auxv): Update.
  94
  95 2019-05-08  Tom Tromey  <tom@tromey.com>
  96
  97         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  98         (symfile_debug_objfile_data_key): Change type.
  99         (symfile_debug_installed, debug_qf_has_symbols)
 100         (debug_qf_find_last_source_symtab)
 101         (debug_qf_forget_cached_source_info)
 102         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 103         (debug_qf_print_stats, debug_qf_dump)
 104         (debug_qf_expand_symtabs_for_function)
 105         (debug_qf_expand_all_symtabs)
 106         (debug_qf_expand_symtabs_with_fullname)
 107         (debug_qf_map_matching_symbols)
 108         (debug_qf_expand_symtabs_matching)
 109         (debug_qf_find_pc_sect_compunit_symtab)
 110         (debug_qf_map_symbol_filenames)
 111         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 112         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 113         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 114         (debug_sym_read_linetable, debug_sym_relocate): Update.
 115         (symfile_debug_free_objfile): Remove.
 116         (install_symfile_debug_logging, _initialize_symfile_debug):
 117         Update.
 118
 119 2019-05-08  Tom Tromey  <tom@tromey.com>
 120
 121         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 122         allocate_on_obstack.
 123         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 124         (get_dwarf2_per_objfile): Update.
 125         (set_dwarf2_per_objfile): Remove.
 126         (dwarf2_has_info, dwarf2_get_section_info): Update.
 127         (dwarf2_free_objfile): Remove.
 128         (_initialize_dwarf2_read): Update.
 129
 130 2019-05-08  Tom Tromey  <tom@tromey.com>
 131
 132         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 133         initializers.
 134         <unsupported_script_warning_printed,
 135         script_not_found_warning_printed>: Now bool.
 136         (auto_load_pspace_data): Change type.
 137         (~auto_load_pspace_info): Rename from
 138         auto_load_pspace_data_cleanup.
 139         (get_auto_load_pspace_data, init_loaded_scripts_info)
 140         (clear_section_scripts, maybe_print_unsupported_script_warning)
 141         (maybe_print_script_not_found_warning, _initialize_auto_load):
 142         Update.
 143
 144 2019-05-08  Tom Tromey  <tom@tromey.com>
 145
 146         * objfiles.c (objfile_pspace_info): Add destructor and
 147         initializers.
 148         (objfiles_pspace_data): Change type.
 149         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 150         (get_objfile_pspace_data): Update.
 151         (objfiles_bfd_data): Change type.
 152         (get_objfile_bfd_data): Update.
 153         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 154
 155 2019-05-08  Tom Tromey  <tom@tromey.com>
 156
 157         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 158         Change type.
 159         (get_catch_syscall_inferior_data): Update.
 160         (catch_syscall_inferior_data_cleanup): Remove.
 161         (_initialize_break_catch_syscall): Update.
 162
 163 2019-05-08  Tom Tromey  <tom@tromey.com>
 164
 165         * inflow.c (struct terminal_info): Add destructor and
 166         initializers.
 167         (inflow_inferior_data): Change type.
 168         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 169         (get_inflow_inferior_data, inflow_inferior_exit)
 170         (swap_terminal_info, _initialize_inflow): Update.
 171
 172 2019-05-08  Tom Tromey  <tom@tromey.com>
 173
 174         * target-dcache.c (target_dcache_cleanup): Remove.
 175         (target_dcache_aspace_key): Change type.
 176         (target_dcache_init_p, target_dcache_invalidate)
 177         (target_dcache_get, target_dcache_get_or_init)
 178         (_initialize_target_dcache): Update.
 179         * dcache.h (struct dcache_deleter): New.
 180
 181 2019-05-08  Tom Tromey  <tom@tromey.com>
 182
 183         * symtab.c (struct symbol_cache): Add destructor and
 184         initializers.
 185         (symbol_cache_key): Move.  Change type.
 186         (make_symbol_cache, free_symbol_cache): Remove.
 187         (get_symbol_cache): Update.
 188         (symbol_cache_cleanup): Remove.
 189         (ALL_PSPACES, symbol_cache_flush)
 190         (maintenance_print_symbol_cache)
 191         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 192         Update.
 193
 194 2019-05-08  Tom Tromey  <tom@tromey.com>
 195
 196         * symtab.c (struct main_info): Add destructor and initializers.
 197         (main_progspace_key): Move.  Change type.
 198         (get_main_info): Update.
 199         (main_info_cleanup): Remove.
 200         (_initialize_symtab): Update.
 201
 202 2019-05-08  Tom Tromey  <tom@tromey.com>
 203
 204         * registry.h (DECLARE_REGISTRY): Define the _key class.
 205
 206 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * NEWS: Merge two 'New commands' sections.
 209
 210 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 211
 212         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 213         parameter and use Ada language definition instead.
 214         (ada_val_print_ptr): Remove unused language parameter.
 215         (ada_val_print_num): Remove language parameter and use Ada language
 216         definition instead.
 217         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 218         parameter.
 219         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 220         parameter and use Ada language definition instead.
 221         (ada_val_print_1): Update all ada_val_print_xxx calls.
 222         Remove language parameter.
 223         (ada_val_print): Update ada_val_print_1 call.
 224
 225 2019-05-08  Tom Tromey  <tromey@adacore.com>
 226
 227         * remote.c (remote_hw_watchpoint_limit)
 228         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 229         Now static.
 230
 231 2019-05-08  Tom Tromey  <tromey@adacore.com>
 232
 233         * maint.c (_initialize_maint_cmds): Move initialization code to
 234         remote.c.
 235         (watchdog, show_watchdog): Move to remote.c.
 236         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 237         "watchdog" static.
 238         (_initialize_remote): Move initialization code from maint.c.
 239         * defs.h (watchdog): Don't declare.
 240
 241 2019-05-08  Tom Tromey  <tromey@adacore.com>
 242
 243         * tui/tui-interp.c: Include main.h.
 244         * interps.c: Include main.h.
 245         * main.h (interpreter_p): Declare.
 246         * defs.h (interpreter_p): Don't declare.
 247
 248 2019-05-08  Tom Tromey  <tromey@adacore.com>
 249
 250         * dwarf2loc.c: Include dwarf2read.h.
 251         * defs.h (read_unsigned_leb128): Don't declare.
 252         * dwarf2read.h (read_unsigned_leb128): Declare.
 253
 254 2019-05-08  Tom Tromey  <tromey@adacore.com>
 255
 256         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 257         method.
 258
 259 2019-05-08  Tom Tromey  <tromey@adacore.com>
 260
 261         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 262         when no wrap column is set.
 263
 264 2019-05-08  Tom Tromey  <tromey@adacore.com>
 265
 266         * c-lang.c (c_get_string): Handle non-C-style arrays.
 267
 268 2019-05-08  Tom Tromey  <tromey@adacore.com>
 269
 270         * typeprint.c (print_offset_data::update): Print the bit offset,
 271         not the number of bits remaining.
 272
 273 2019-05-08  Tom Tromey  <tromey@adacore.com>
 274
 275         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 276         padding at end of comment.
 277
 278 2019-05-08  Tom Tromey  <tromey@adacore.com>
 279
 280         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 281         Compare main types.
 282
 283 2019-05-06  Tom Tromey  <tom@tromey.com>
 284
 285         * common/scoped_mmap.c: Include common-defs.h.
 286         * common/scoped_mmap.h: Don't include config.h.
 287
 288 2019-05-04  Tom Tromey  <tom@tromey.com>
 289
 290         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 291         (struct aarch64_call_info): Add initializers.
 292         <si>: Now a std::vector.
 293         (pass_on_stack, aarch64_push_dummy_call): Update.
 294
 295 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 296             Tom Tromey  <tom@tromey.com>
 297
 298         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 299         (ppc_threads): Now a std::vector.  Now static.
 300         (hwdebug_find_thread_points_by_tid)
 301         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 302         Update.
 303
 304 2019-05-04  Tom Tromey  <tom@tromey.com>
 305
 306         * arc-tdep.c (arc_tdesc_init): Return bool.
 307
 308 2019-05-04  Tom Tromey  <tom@tromey.com>
 309
 310         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 311         Use gdb_assert_not_reached.
 312
 313 2019-05-04  Tom Tromey  <tom@tromey.com>
 314
 315         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 316         "false".
 317
 318 2019-05-04  Tom Tromey  <tom@tromey.com>
 319
 320         * arc-tdep.c (arc_tdesc_init): Use bool.
 321
 322 2019-05-04  Tom Tromey  <tom@tromey.com>
 323
 324         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 325
 326 2019-05-04  Tom Tromey  <tom@tromey.com>
 327
 328         * cli/cli-cmds.c (valid_command_p): Return bool.
 329
 330 2019-05-04  Tom Tromey  <tom@tromey.com>
 331
 332         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 333         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 334
 335 2019-05-04  Raul Tambre  <raul@tambre.ee>
 336
 337         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 338         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 339         operator for comparison.
 340
 341 2019-05-04  Tom Tromey  <tom@tromey.com>
 342
 343         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 344         (lookup_partial_symbol, print_partial_symbols)
 345         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 346         (psymbol_compare): Update.
 347         (add_psymbol_to_bcache): Clear the entire psymbol.
 348         (maintenance_check_psymtabs): Update.
 349         * psympriv.h (struct partial_symbol): Don't derive from
 350         general_symbol_info.
 351         <obj_section, unrelocated_address, address,
 352         set_unrelocated_address>: Update.
 353         <ginfo>: New member.
 354         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 355         (debug_names::write_psymbols): Update.
 356
 357 2019-05-04  Tom de Vries  <tdevries@suse.de>
 358
 359         * contrib/cc-with-tweaks.sh: Support -n arg.
 360
 361 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 362
 363         * corelow.c (core_target::detach): Ensure frame cache and
 364         register caches are cleared.
 365         inferior.c (exit_inferior_1): Likewise.
 366
 367 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 368             Tom Tromey  <tom@tromey.com>
 369
 370         * dictionary.c (collate_pending_symbols_by_language): Remove
 371         "struct" from foreach.
 372         * symtab.c (lookup_global_symbol_from_objfile)
 373         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 374         foreach.
 375         * ser-tcp.c (net_open): Remove "struct" from foreach.
 376         * objfiles.c (objfile_relocate, objfile_rebase)
 377         (objfile_has_symbols): Remove "struct" from foreach.
 378         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 379         from foreach.
 380         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 381         foreach.
 382         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 383         "struct" from foreach.
 384         * ada-lang.c (create_excep_cond_exprs)
 385         (ada_exception_catchpoint_cond_string): Remove "struct" from
 386         foreach.
 387
 388 2019-05-03  Tom Tromey  <tromey@adacore.com>
 389
 390         * ada-exp.y (convert_char_literal): Check suffix of each
 391         enumerator.
 392
 393 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 394
 395         PR ada/21406:
 396         * ada-exp.y (yywrap): Don't define.
 397         * ada-lex.l (%option): Add noyywrap
 398         (yywrap): Remove.
 399
 400 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 401
 402         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 403         _WIN32_WINNT to the XP level, unless already defined to a higher
 404         level.
 405
 406         * unittests/parse-connection-spec-selftests.c:
 407         * ser-tcp.c:
 408         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 409         override.
 410
 411         * symfile.c (find_separate_debug_file): Remove colon from the
 412         drive spec of DOS/Windows file names of the target, so that the
 413         file name produced from DEBUGDIR and the target's directory will
 414         be valid on DOS/Windows systems.
 415
 416 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 417
 418         * rust-lang.c (val_print_struct): Handle printing structures
 419         containing strings.
 420
 421 2019-05-02  Tom Tromey  <tromey@adacore.com>
 422
 423         * valarith.c (_initialize_valarith): Remove.
 424
 425 2019-05-01  Tom Tromey  <tromey@adacore.com>
 426
 427         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 428         bitfields.
 429
 430 2019-05-01  Tom Tromey  <tromey@adacore.com>
 431
 432         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 433         for big-endian copies.
 434
 435 2019-04-30  Ali Tamur  <tamur@google.com>
 436         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 437         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 438         (read_3_bytes): New function.
 439
 440 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 441
 442         * windows-nat.c (main_thread_id): Delete.
 443         (handle_output_debug_string): Replace main_thread_id by
 444         current_event.dwThreadId.
 445         (fake_create_process): Likewise.
 446         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 447         Do not set main_thread_id.
 448         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 449         current_event.dwThreadId.
 450         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 451
 452 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 453
 454         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 455         Use current_event.dwThreadId instead of main_thread_id.
 456
 457 2019-04-30  Tom Tromey  <tromey@adacore.com>
 458
 459         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 460         (create_excep_cond_exprs): Iterate over program spaces.
 461         (ada_exception_catchpoint_cond_string): Examine all minimal
 462         symbols for exception types.
 463
 464 2019-04-30  Tom Tromey  <tromey@adacore.com>
 465
 466         PR c++/24470:
 467         * dwarf2read.c (process_structure_scope): Handle case where type
 468         has template parameters but no symbol was created.
 469
 470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 471             Chris January  <chris.january@arm.com>
 472
 473         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 474         qualifier.
 475         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 476
 477 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 478
 479         * f-typeprint.c (f_print_type): Update rules for printing
 480         whitespace.
 481         (f_type_print_varspec_suffix): Likewise.
 482
 483 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 484             Chris January  <chris.january@arm.com>
 485
 486         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 487         function arguments.
 488
 489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * f-lang.c (build_fortran_types): Change name of void type to
 492         lower case.
 493         * f-typeprint.c (f_type_print_base): Print the name of the void
 494         type, rather than a fixed string.
 495         * f-valprint.c (f_decorations): Use lower case void string.
 496
 497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 498             Chris January  <chris.january@arm.com>
 499
 500         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 501         types for Fortran.
 502
 503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 504             Chris January  <chris.january@arm.com>
 505             David Lecomber  <david.lecomber@arm.com>
 506
 507         * f-exp.y (BINOP_INTRINSIC): New token.
 508         (exp): New parser rule handling BINOP_INTRINSIC.
 509         (f77_keywords): Add new builtin procedures.
 510         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 511         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 512         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 513         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 514         (print_unop_subexp_f): New function.
 515         (print_binop_subexp_f): New function.
 516         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 517         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 518         (dump_subexp_body_f): Likewise.
 519         (operator_check_f): Likewise.
 520         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 521         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 522
 523 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 526         UNOP_KIND.
 527         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 528         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 529         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 530         (operator_length_f): New fuction.
 531         (print_subexp_f): New function.
 532         (op_name_f): New function.
 533         (dump_subexp_body_f): New function.
 534         (operator_check_f): New function.
 535         (exp_descriptor_f): Replace standard expression handling functions
 536         with new functions.
 537         * gdb/fortran-operator.def: New file.
 538         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 539         * gdb/std-operator.def: Remove UNOP_KIND.
 540
 541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * std-operator.def: Remove unbalanced, stray double quote
 544         character.
 545
 546 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 547             Chris January  <chris.january@arm.com>
 548             Daniel Everett  <daniel.everett@arm.com>
 549             Nick Forrington  <nick.forrington@arm.com>
 550             Richard Bunt  <richard.bunt@arm.com>
 551
 552         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 553         of depth when printing anonymous structs or unions.
 554         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 555         Don't print either the top-level value, or the children if the
 556         max-depth is exceeded.
 557         (ppscm_print_children): When printing the key of a map, allow one
 558         extra level of depth.
 559         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 560         print either the top-level value, or the children if the max-depth
 561         is exceeded.
 562         (print_children): When printing the key of a map, allow one extra
 563         level of depth.
 564         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 565         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 566         (user_print_options): Initialise max_depth field.
 567         (val_print_scalar_or_string_type_p): New function.
 568         (val_print): Check to see if the max depth has been reached.
 569         (val_print_check_max_depth): Define new function.
 570         (show_print_max_depth): New function.
 571         (_initialize_valprint): Add 'print max-depth' option.
 572         * valprint.h (struct value_print_options) <max_depth>: New field.
 573         (val_print_check_max_depth): Declare new function.
 574         * NEWS: Document new feature.
 575
 576 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * ada-lang.c (ada_language_defn): Initialise new field.
 579         * c-lang.c (c_is_string_type_p): New function.
 580         (c_language_defn): Initialise new field.
 581         (cplus_language_defn): Initialise new field.
 582         (asm_language_defn): Initialise new field.
 583         (minimal_language_defn): Initialise new field.
 584         * c-lang.h (c_is_string_type_p): Declare new function.
 585         * d-lang.c (d_language_defn): Initialise new field.
 586         * f-lang.c (f_is_string_type_p): New function.
 587         (f_language_defn): Initialise new field.
 588         * go-lang.c (go_is_string_type_p): New function.
 589         (go_language_defn): Initialise new field.
 590         * language.c (default_is_string_type_p): New function.
 591         (unknown_language_defn): Initialise new field.
 592         (auto_language_defn): Initialise new field.
 593         * language.h (struct language_defn) <la_is_string_type_p>: New
 594         member variable.
 595         (default_is_string_type_p): Declare new function.
 596         * m2-lang.c (m2_language_defn): Initialise new field.
 597         * objc-lang.c (objc_language_defn): Initialise new field.
 598         * opencl-lang.c (opencl_language_defn): Initialise new field.
 599         * p-lang.c (pascal_is_string_type_p): New function.
 600         (pascal_language_defn): Initialise new field.
 601         * rust-lang.c (rust_is_string_type_p): New function.
 602         (rust_language_defn): Initialise new field.
 603
 604 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 607         New field.
 608         * ada-lang.c (ada_language_defn): Initialise new field.
 609         * c-lang.c (c_language_defn): Likewise.
 610         (cplus_language_defn): Likewise.
 611         (asm_language_defn): Likewise.
 612         (minimal_language_defn): Likewise.
 613         * d-lang.c (d_language_defn): Likewise.
 614         * f-lang.c (f_language_defn): Likewise.
 615         * go-lang.c (go_language_defn): Likewise.
 616         * language.c (unknown_language_defn): Likewise.
 617         (auto_language_defn): Likewise.
 618         * m2-lang.c (m2_language_defn): Likewise.
 619         * objc-lang.c (objc_language_defn): Likewise.
 620         * opencl-lang.c (opencl_language_defn): Likewise.
 621         * p-lang.c (pascal_language_defn): Likewise.
 622         * rust-lang.c (rust_language_defn): Likewise.
 623
 624 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * ada-lang.c (ada_is_character_type): Change return type to bool.
 627         (ada_is_string_type): Likewise.
 628         * ada-lang.h (ada_is_character_type): Update declaration
 629         (ada_is_string_type): Likewise.
 630
 631 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 632
 633         Support style in 'frame|thread apply'
 634
 635         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 636         * record.c (record_start, record_stop): Update callers of
 637         execute_command_to_string with false.
 638         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 639         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 640         methods.
 641         (class string_file): New constructor with term_out parameter.
 642         Override methods term_out and can_emit_style_escape.  New member
 643         term_out.
 644         (class stdio_file): Override can_emit_style_escape.
 645         (class tee_file): Override term_out and can_emit_style_escape.
 646         * utils.h (can_emit_style_escape): Remove.
 647         * utils.c (can_emit_style_escape): Likewise.
 648         Update all callers of can_emit_style_escape (SOMESTREAM) to
 649         SOMESTREAM->can_emit_style_escape.
 650         * source-cache.c (source_cache::get_source_lines): Likewise.
 651         * stack.c (frame_apply_command_count): Call execute_command_to_string
 652         passing the term_out characteristic of the current gdb_stdout.
 653         * thread.c (thr_try_catch_cmd): Likewise.
 654         * top.c (execute_command_to_string): pass term_out parameter
 655         to construct the string_file for the command output.
 656         * ui-file.c (term_cli_styling): New function (most code moved
 657         from utils.c can_emit_style_escape).
 658         (string_file::string_file, string_file::can_emit_style_escape,
 659         stdio_file::can_emit_style_escape, tee_file::term_out,
 660         tee_file::can_emit_style_escape): New functions.
 661
 662 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * NEWS: Mention the new set|show may-call-functions.
 665         * infcall.c (may_call_functions_p): New variable.
 666         (show_may_call_functions_p): New function.
 667         (call_function_by_hand_dummy): Throws an error if not
 668         may-call-functions.
 669         (_initialize_infcall): Call add_setshow_boolean_cmd for
 670         may-call-functions.
 671
 672 2019-04-25  Keith Seitz  <keiths@redhat.com>
 673
 674         PR c++/24367
 675         * cp-support.c (inspect_type): Don't attempt substitutions
 676         of symbol with the same name.
 677
 678 2019-04-25  Tom Tromey  <tromey@adacore.com>
 679
 680         PR gdb/24475:
 681         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 682         static.
 683
 684 2019-04-25  Tom Tromey  <tromey@adacore.com>
 685
 686         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 687         rvalue reference.
 688         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 689         (gdb_xml_parser::parse): Use std::move.
 690         * python/python-internal.h (gdbpy_convert_exception): Take a const
 691         reference.
 692         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 693         std::move.
 694         * python/py-utils.c (gdbpy_convert_exception): Take a const
 695         reference.
 696         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 697         Use std::move.
 698         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 699         Use std::move.
 700         * mi/mi-main.c (mi_print_exception): Take a const reference.
 701         * main.c (handle_command_errors): Take a const reference.
 702         * linespec.c (parse_linespec): Use std::move.
 703         * infcall.c (run_inferior_call): Use std::move.
 704         (call_function_by_hand_dummy): Use std::move.
 705         * exec.c (try_open_exec_file): Use std::move.
 706         * exceptions.h (exception_print, exception_fprintf)
 707         (exception_print_same): Update.
 708         * exceptions.c (print_exception, exception_print)
 709         (exception_fprintf, exception_print_same): Change parameters to
 710         const reference.
 711         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 712         * common/new-op.c: Use std::move.
 713         * common/common-exceptions.h (struct gdb_exception): Add move
 714         constructor.
 715         (struct gdb_exception_error, struct gdb_exception_quit, struct
 716         gdb_quit_bad_alloc): Change constructor to move constructor.
 717         (throw_exception): Change parameter to rvalue reference.
 718         * common/common-exceptions.c (throw_exception): Take rvalue
 719         reference.
 720         * cli/cli-interp.c (safe_execute_command): Use std::move.
 721         * breakpoint.c (insert_bp_location, location_to_sals): Use
 722         std::move.
 723
 724 2019-04-25  Tom Tromey  <tromey@adacore.com>
 725
 726         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 727         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 728         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 729         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 730         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 731         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 732         guile/scm-value.c: Use unpack.
 733         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 734         gdbscm_gdb_exception.
 735         (gdbscm_throw_gdb_exception): Likewise.
 736         (struct gdbscm_gdb_exception): New.
 737         (unpack): New function.
 738         (gdbscm_wrap): Use unpack.
 739
 740 2019-04-25  Tom Tromey  <tromey@adacore.com>
 741
 742         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 743         (gdb_rl_callback_handler): Use std::move.
 744         * common/common-exceptions.h (struct gdb_exception): Add move
 745         assignment operator.
 746         (throw_exception_sjlj): Change "exception" to const reference.
 747         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 748         (throw_exception_sjlj): Change "exception" to const reference.
 749
 750 2019-04-25  Tom Tromey  <tromey@adacore.com>
 751
 752         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 753         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 754         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 755         Update.
 756         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 757         Update.
 758         * mi/mi-interp.c (mi_interp::exec): Update.
 759         * linespec.c (parse_linespec): Update.
 760         * infcall.c (run_inferior_call): Update.
 761         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 762         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 763         (gdbscm_lookup_global_symbol): Update.
 764         * guile/scm-param.c (gdbscm_parameter_value): Update.
 765         * guile/scm-frame.c (gdbscm_frame_read_register)
 766         (gdbscm_frame_read_var): Update.
 767         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 768         * exec.c (try_open_exec_file): Update.
 769         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 770         (gdb_rl_callback_handler): Update.
 771         * common/common-exceptions.h (exception_none): Don't declare.
 772         * common/common-exceptions.c (exception_none): Don't define.
 773         (struct catcher) <exception>: Update.
 774         * cli/cli-interp.c (safe_execute_command): Update.
 775         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 776
 777 2019-04-25  Ali Tamur  <tamur@google.com>
 778
 779         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 780         (read_attribute_value): Likewise.
 781         (dwarf2_read_addr_index): Update comment.
 782         (read_str_index): Add DW_FORM_strx.
 783         (dwarf2_string_attr): Likewise.
 784         (dwarf2_const_value_attr): Likewise.
 785         (dump_die_shallow): Likewise.
 786         (dwarf2_fetch_constant_bytes): Likewise.
 787         (skip_form_bytes): Likewise.
 788         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 789
 790 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 791
 792         PR corefiles/11608
 793         PR corefiles/18187
 794         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 795         OFFSET.  Verify if current mapping contains an ELF header.
 796         (linux_find_memory_regions_full): Adjust call to
 797         dump_mapping_p.
 798
 799 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 800             Kang Li <kanglictf@gmail.com>
 801
 802         PR gdb/21600
 803
 804         * dwarf2-frame.c (read_initial_length): Be consistent about using
 805         unsigned representation of length.
 806         (decode_frame_entry_1): Likewise.  Check for wraparound of
 807         end pointer as well as buffer overflow.
 808
 809 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 810
 811         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 812         "vq".
 813
 814 2019-04-24  Tom Tromey  <tromey@adacore.com>
 815
 816         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 817
 818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * s12z-tdep.c (s12z_unwind_pc): Delete.
 821         (s12z_unwind_sp): Delete.
 822         (s12z_gdbarch_init): Don't register deleted functions with
 823         gdbarch.
 824
 825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * rl78-tdep.c (rl78_unwind_sp): Delete.
 828         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 829
 830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 833         (xstormy16_unwind_pc): Delete.
 834         (xstormy16_dummy_id): Delete.
 835         (xstormy16_gdbarch_init): Don't register deleted functions with
 836         gdbarch.
 837
 838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * vax-tdep.c (vax_unwind_pc): Delete.
 841         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 842
 843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * v850-tdep.c (v850_unwind_sp): Delete.
 846         (v850_unwind_pc): Delete.
 847         (v850_dummy_id): Delete.
 848         (v850_gdbarch_init): Don't register deleted functions with
 849         gdbarch.
 850
 851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 854         (tilegx_unwind_pc): Delete.
 855         (tilegx_unwind_dummy_id): Delete.
 856         (tilegx_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 862         (tic6x_dummy_id): Delete.
 863         (tic6x_gdbarch_init): Don't register deleted functions with
 864         gdbarch.
 865
 866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * sparc-tdep.c (sparc_unwind_pc): Delete.
 869         (sparc32_gdbarch_init): Don't register deleted function with
 870         gdbarch.
 871
 872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * sh-tdep.c (sh_unwind_sp): Delete.
 875         (sh_unwind_pc): Delete.
 876         (sh_dummy_id): Delete.
 877         (sh_gdbarch_init): Don't register deleted functions with
 878         gdbarch.
 879
 880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * score-tdep.c (score_unwind_sp): Delete.
 883         (score_unwind_pc): Delete.
 884         (score_dummy_id): Delete.
 885         (score_gdbarch_init): Don't register deleted functions with
 886         gdbarch.
 887
 888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * rx-tdep.c (rx_unwind_pc): Delete.
 891         (rx_unwind_sp): Delete.
 892         (rx_dummy_id): Delete.
 893         (rx_gdbarch_init): Don't register deleted functions with
 894         gdbarch.  Update comment.
 895
 896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 899         (rs6000_dummy_id): Delete.
 900         (rs6000_gdbarch_init): Don't register deleted functions with
 901         gdbarch.
 902
 903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * or1k-tdep.c (or1k_dummy_id): Delete.
 906         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * nios2-tdep.c (nios2_dummy_id): Delete.
 911         (nios2_unwind_sp): Delete.
 912         (nios2_gdbarch_init): Don't register deleted functions with
 913         gdbarch.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * nds32-tdep.c (nds32_dummy_id): Delete.
 918         (nds32_unwind_pc): Delete.
 919         (nds32_unwind_sp): Delete.
 920         (nds32_gdbarch_init): Don't register deleted functions with
 921         gdbarch.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * msp430-tdep.c (msp430_unwind_pc): Delete.
 926         (msp430_unwind_sp): Delete.
 927         (msp430_dummy_id): Delete.
 928         (msp430_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * moxie-tdep.c (moxie_unwind_sp): Delete.
 934         (moxie_unwind_pc): Delete.
 935         (moxie_dummy_id): Delete.
 936         (moxie_gdbarch_init): Don't register deleted functions with
 937         gdbarch.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 942         (mn10300_unwind_pc): Delete.
 943         (mn10300_unwind_sp): Delete.
 944         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 945         mn10300_unwind_sp.
 946         (mn10300_frame_unwind_init): Don't register deleted functions with
 947         gdbarch.
 948
 949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * mep-tdep.c (mep_unwind_pc): Delete.
 952         (mep_unwind_sp): Delete.
 953         (mep_dummy_id): Delete.
 954         (mep_gdbarch_init): Don't register deleted functions with
 955         gdbarch.
 956
 957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 960         (m68hc11_unwind_sp): Delete.
 961         (m68hc11_gdbarch_init): Don't register deleted functions with
 962         gdbarch.
 963
 964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 965
 966         * m32r-tdep.c (m32r_unwind_sp): Delete.
 967         (m32r_unwind_pc): Delete.
 968         (m32r_dummy_id): Delete.
 969         (m32r_gdbarch_init): Don't register deleted functions with
 970         gdbarch.
 971
 972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * m32c-tdep.c (m32c_unwind_pc): Delete.
 975         (m32c_unwind_sp): Delete.
 976         (m32c_dummy_id): Delete.
 977         (m32c_gdbarch_init): Don't register deleted functions with
 978         gdbarch.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 983         (lm32_unwind_pc): Delete.
 984         (lm32_dummy_id): Delete.
 985         (lm32_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 991         (iq2000_unwind_pc): Delete.
 992         (iq2000_dummy_id): Delete.
 993         (iq2000_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * nds32-tdep.c (nds32_type_align): Delete.
 999         (nds32_push_dummy_call): Use type_align instead.
1000
1001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * arm-tdep.c (arm_type_align): Only handle vector override case.
1004         (arm_push_dummy_call): Use type_align.
1005         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1010         case.
1011         (pass_on_stack): Use type_align.
1012         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1013         function.
1014
1015 2019-04-23  Tom Tromey  <tromey@adacore.com>
1016
1017         * dwarf2read.c (line_header::file_name_at): Remove unused
1018         overload.
1019
1020 2019-04-23  Tom de Vries  <tdevries@suse.de>
1021
1022         PR gdb/24438
1023         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1024         invocation.
1025
1026
1027 2019-03-27  Ali Tamur  <tamur@google.com>
1028
1029         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1030         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1031         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1032         (dwarf_expr_context::get_addr_index): Likewise
1033         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1034         (symbol_needs_eval_context::get_addr_index): Likewise
1035         (disassemble_dwarf_expression): Add DW_OP_addrx
1036         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1037         (read_cutu_die_from_dwo): Update comment
1038         (skip_one_die): Add DW_FORM_addrx
1039         (read_attribute_value): Likewise
1040         (var_decode_location): Add DW_OP_addrx
1041         (dwarf2_const_value_attr): Add DW_FORM_addrx
1042         (dump_die_shallow): Likewise
1043         (dwarf2_fetch_constant_bytes): Likewise
1044         (decode_locdesc): Add DW_OP_addrx
1045         (skip_form_bytes): Add DW_FORM_addrx
1046
1047 2019-04-22  Ali Tamur  <tamur@google.com>
1048
1049         * MAINTAINERS (Write After Approval): Add self.
1050
1051 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1052
1053         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1054         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1055         (open_symbol_file_object): Likewise.
1056         (svr4_default_sos): Add info parameter.
1057         (svr4_read_so_list): Likewise.
1058         (svr4_current_sos_direct): Adjust functions calls to pass down
1059         info.
1060         (svr4_current_sos_1): Add info parameter.
1061         (svr4_current_sos): Call get_svr4_info, pass info down to
1062         svr4_current_sos_1.
1063         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1064         get_svr4_info.
1065         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1066         get_svr4_info.
1067         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1068         to get_svr4_info.
1069         (probes_table_remove_objfile_probes): Likewise.
1070         (register_solib_event_probe): Add info parameter.
1071         (solist_update_incremental): Pass info parameter down to
1072         svr4_read_so_list.
1073         (disable_probes_interface): Add info parameter.
1074         (svr4_handle_solib_event): Pass current_program_space to
1075         get_svr4_info.  Adjust disable_probes_interface cleanup.
1076         (svr4_create_probe_breakpoints): Add info parameter, pass it
1077         down to register_solib_event_probe.
1078         (svr4_create_solib_event_breakpoints): Add info parameter,
1079         pass it down to svr4_create_probe_breakpoints.
1080         (enable_break): Pass info down to
1081         svr4_create_solib_event_breakpoints.
1082         (svr4_solib_create_inferior_hook): Pass current_program_space to
1083         get_svr4_info.
1084         (svr4_clear_solib): Likewise.
1085
1086 2019-04-22  Pedro Alves  <palves@redhat.com>
1087
1088         * solib-svr4.c (svr4_free_objfile_observer): New.
1089         (probe_and_action::objfile): New field.
1090         (probes_table_htab_remove_objfile_probes)
1091         (probes_table_remove_objfile_probes): New functions.
1092         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1093         in the new probe_and_action.  Don't store the probe in 'lookup'.
1094         (svr4_create_probe_breakpoints): Pass objfile to
1095         register_solib_event_probe.
1096         (_initialize_svr4_solib): Register a free_objfile observer.
1097
1098 2019-04-19  Tom Tromey  <tom@tromey.com>
1099
1100         * common/queue.h: Remove.
1101
1102 2019-04-19  Tom Tromey  <tom@tromey.com>
1103
1104         * event-loop.c: Don't include "common/queue.h".
1105
1106 2019-04-19  Tom Tromey  <tom@tromey.com>
1107
1108         * remote.c (remote_target): Use delete.
1109         * remote-notif.h: Include <list>, not "common/queue.h".
1110         (notif_client_p): Remove typedef.
1111         (remote_notif_state): Add constructor, destructor, initializer.
1112         <notif_queue>: Now a std::list.
1113         (remote_notif_state_xfree): Don't declare.
1114         * remote-notif.c (remote_notif_process, handle_notification)
1115         (remote_notif_state_allocate): Update.
1116         (~remote_notif_state): Rename from remote_notif_state_xfree.
1117
1118 2019-04-19  Tom Tromey  <tom@tromey.com>
1119
1120         * symfile.c (reread_symbols): Update.
1121         * objfiles.c (objfile_register_static_link)
1122         (objfile_lookup_static_link): Update
1123         (~objfile) Don't delete static_links.
1124         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1125
1126 2019-04-19  Tom Tromey  <tom@tromey.com>
1127
1128         * type-stack.h (struct type_stack) <insert>: Constify string.
1129         * type-stack.c (type_stack::insert): Constify string.
1130         * gdbtypes.h (lookup_template_type): Update.
1131         (address_space_name_to_int): Update.
1132         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1133         const.
1134         (lookup_template_type): Make name const.
1135         * c-exp.y: Update rules.
1136         (lex_one_token, classify_name, classify_inner_name)
1137         (c_print_token): Update.
1138         * p-exp.y: Update rules.
1139         (yylex): Update.
1140         * f-exp.y: Update rules.
1141         (yylex): Update.
1142         * d-exp.y: Update rules.
1143         (lex_one_token, classify_name, classify_inner_name): Update.
1144         * parse.c (write_dollar_variable, copy_name): Return std::string.
1145         * parser-defs.h (copy_name): Change return type.
1146         * m2-exp.y: Update rules.
1147         (yylex): Update.
1148         * go-exp.y (lex_one_token): Update.
1149         Update rules.
1150         (classify_unsafe_function, classify_packaged_name)
1151         (classify_name, yylex): Update.
1152
1153 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1154
1155         * configure.ac: add --enable-source-highlight switch.
1156         * configure: Regenerate.
1157         * top.c (print_gdb_version): plumb --enable-source-highlight
1158         status to "show configuration".
1159
1160 2019-04-19  Tom Tromey  <tromey@adacore.com>
1161
1162         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1163         Check ADA_TYPE_P.
1164         (empty_record, ada_template_to_fixed_record_type_1)
1165         (template_to_static_fixed_type)
1166         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1167         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1168         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1169         macros.
1170
1171 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1172
1173         PR symtab/24423:
1174         * source.c (print_source_lines_base): Advance "iter" when a
1175         control character is seen.
1176
1177 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1178
1179         * inferior.h (struct infcall_suspend_state_deleter):
1180         Catch exception in destructor to avoid crash.
1181
1182 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1183
1184         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1185         close to the add_com "shell".
1186
1187 2019-04-18  Tom Tromey  <tromey@adacore.com>
1188
1189         * process-stratum-target.h (class process_stratum_target)
1190         <stratum>: Add "final".
1191
1192 2019-04-17  Tom Tromey  <tromey@adacore.com>
1193
1194         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1195         against nullptr before use.
1196
1197 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1198
1199         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1200
1201 2019-04-17  Jim Wilson  <jimw@sifive.com>
1202             Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1205         code read might fail, assume 4-byte breakpoint in that case.
1206
1207 2019-04-15  Leszek Swirski  <leszeks@google.com>
1208
1209         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1210         rather than a hand-rolled POD check when checking for forced MEMORY
1211         classification.
1212
1213 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1214
1215         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1216         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1217         function.
1218         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1219         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1220         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1221         declaration.
1222
1223 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1224
1225         * aarch64-linux-nat.c
1226         (aarch64_linux_nat_target::thread_architecture): Add override.
1227         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1228         each VQ.
1229
1230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1231
1232         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1233
1234 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1237         target types of size 96-bits, add some additional comments, and
1238         check that the builtin type we found was the correct size.
1239
1240 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1241
1242         * utils.c (prompt_for_continue): Don't restore the styling at the
1243         end, as applied_style has the wrong value.  This fixes styling in
1244         long lists of file names that are interrupted by the "Continue?"
1245         prompt.
1246
1247 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1250         * c-lang.c (c_language_defn): Likewise.
1251         (cplus_language_defn): Likewise.
1252         (asm_language_defn): Likewise.
1253         (minimal_language_defn): Likewise.
1254         * d-lang.c (d_language_defn): Likewise.
1255         * f-lang.c (f_language_defn): Likewise.
1256         * go-lang.c (go_language_defn): Likewise.
1257         * language.c (unknown_language_defn): Likewise.
1258         (auto_language_defn): Likewise.
1259         * language.h (struct language_defn): Remove la_magic field.
1260         (LANG_MAGIC): Delete.
1261         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1262         * objc-lang.c (objc_language_defn): Likewise.
1263         * opencl-lang.c (opencl_language_defn): Likewise.
1264         * p-lang.c (pascal_language_defn): Likewise.
1265         * rust-lang.c (rust_language_defn): Likewise.
1266
1267 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * riscv-tdep.c (riscv_type_align): New function.
1270         (riscv_type_alignment): Delete.
1271         (riscv_arg_location): Use 'type_align'.
1272         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1273
1274 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * gdbtypes.c (type_align): A struct with no non-static fields also
1277         has alignment of 1.
1278
1279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1282         component to 0.
1283         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1284         member.
1285         (riscv_struct_info::analyse): New implementation using new
1286         analyse_inner member function.
1287         (riscv_struct_info::field_offset): New member function.
1288         (riscv_struct_info::m_offsets): New member variable.
1289         (riscv_struct_info::analyse_inner): New private member function,
1290         takes the old implementation of riscv_struct_info::analyse but
1291         extended to track field offsets.
1292         (riscv_call_arg_struct): Update the struct folding special cases
1293         to handle cases where empty C++ structs, which are non-zero
1294         length, are found.
1295         (riscv_arg_location): Initialise the length of each location, a
1296         non-zero length now indicates the location is in use.
1297         (riscv_push_dummy_call): Allow for the first location having a
1298         non-zero offset when setting up arguments.
1299         (riscv_return_value): Likewise, but for return values.
1300
1301 2019-04-11  Tom Tromey  <tromey@adacore.com>
1302
1303         * utils.c (internal_vproblem): Make "msg" const.
1304
1305 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1308         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1309         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1310         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1311
1312 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1313
1314         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1315         function.
1316         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1317         of amd64_collect_native_gregset.
1318         (amd64_linux_nat_target::store_registers): Likewise.
1319
1320 2019-04-10  Tom Tromey  <tom@tromey.com>
1321
1322         * symtab.c (lookup_global_symbol_from_objfile)
1323         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1324         * objfiles.h (class separate_debug_iterator): New.
1325         (class separate_debug_range): New.
1326         (struct objfile) <separate_debug_objfiles>: New method.
1327         (objfile_separate_debug_iterate): Don't declare.
1328         * objfiles.c (separate_debug_iterator::operator++): Rename from
1329         objfile_separate_debug_iterate.
1330         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1331         iterator.
1332         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1333         iterator.
1334
1335 2019-04-10  Tom Tromey  <tom@tromey.com>
1336
1337         * symfile.c (reread_symbols): Remove old comment.
1338         * objfiles.c (free_all_objfiles): Fix a typo.
1339
1340 2019-04-10  Tom Tromey  <tom@tromey.com>
1341
1342         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1343         * minsyms.c (lookup_minimal_symbol): Use foreach.
1344         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1345         (lookup_minimal_symbol_solib_trampoline): Likewise.
1346         * symfile.c (reread_symbols): Use foreach.
1347
1348 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1349             Tom Tromey  <tromey@adacore.com>
1350
1351         PR rust/24414:
1352         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1353         (rust_lex_int_test): Change "value" to be LONGEST.
1354         (rust_lex_tests): Add test for long integer literal.
1355
1356 2019-04-09  Tom Tromey  <tromey@adacore.com>
1357
1358         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1359         to bool.
1360         (extended_remote_target::attach): Update.
1361         (remote_target::remote_notice_new_inferior): Update.
1362         (remote_target::add_current_inferior_and_thread): Update.
1363         * inferior.c (exit_inferior_1): Use "false".
1364         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1365
1366 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1367
1368         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1369         the "start" command.
1370
1371 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1372
1373         * python/py-inferior.c (infpy_thread_from_thread_handle):
1374         Adjust comments to reflect renaming of thread_from_thread_handle
1375         to thread_from_handle.  Adjust keywords.  Fix type error message.
1376         (inferior_object_methods): Add thread_from_handle.  Retain
1377         thread_from_thread_handle, but mark it as deprecated.
1378
1379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1380
1381         * gdbthread.h (find_thread_by_handle): Revise declaration.
1382         * thread.c (find_thread_by_handle): Likewise.  Adjust
1383         implementation too.
1384         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1385         support for buffer objects as handles.
1386
1387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1388
1389         * python/py-infthread.c (thpy_thread_handle): New function.
1390         (thread_object_methods): Register thpy_thread_handle.
1391
1392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1393
1394         * gdbthread.h (thread_to_thread_handle): Declare.
1395         * thread.c (gdbtypes.h): Include.
1396         (thread_to_thread_handle): New function.
1397
1398         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1399         (target_thread_info_to_thread_handle): Declare.
1400         * target.c (target_thread_info_to_thread_handle): New function.
1401         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1402         * target-delegates.c: Regenerate.
1403
1404         * linux-thread-db.c (class thread_db_target): Add method
1405         thread_info_to_thread_handle.
1406         (thread_db_target::thread_info_to_thread_handle): Define.
1407         * remote.c (class remote_target): Add new method
1408         thread_info_to_thread_handle.
1409         (remote_target::thread_info_to_thread_handle): Define.
1410
1411 2019-04-08  Pedro Alves  <palves@redhat.com>
1412
1413         * common/common-exceptions.c (throw_exception): Don't create
1414         named object to throw; throw directly.
1415         (throw_it): Likewise.  Don't initialize gdb_exception::message
1416         here, with new; pass FMT and AP to the ctor instead.
1417         * common/common-exceptions.h: Include <string>.
1418         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1419         const char *, va_list)): New ctor.  Use std::make_shared.
1420         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1421         errors)): Delete.
1422         (gdb_exception_error::gdb_exception_error(enum errors, const char
1423         *, va_list)): New.
1424         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1425         Add assertion.
1426         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1427         errors)): Delete.
1428         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1429         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1430         Add assertion.
1431
1432 2019-04-08  Tom Tromey  <tom@tromey.com>
1433
1434         * valops.c (value_rtti_indirect_type): Replace throw_exception
1435         with throw.
1436         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1437         with throw.
1438         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1439         throw.
1440         * target.c (target_translate_tls_address): Replace throw_exception
1441         with throw.
1442         * stack.c (frame_apply_command_count): Replace throw_exception
1443         with throw.
1444         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1445         throw.
1446         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1447         with throw.
1448         * rs6000-tdep.c (rs6000_frame_cache)
1449         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1450         * remote.c: Replace throw_exception with throw.
1451         * record-full.c (record_full_message, record_full_wait_1)
1452         (record_full_restore): Replace throw_exception with throw.
1453         * record-btrace.c:
1454         (get_thread_current_frame_id, record_btrace_start_replaying)
1455         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1456         (cmd_record_btrace_start): Replace throw_exception with throw.
1457         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1458         throw.
1459         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1460         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1461         * linespec.c:
1462         (find_linespec_symbols): Replace throw_exception with throw.
1463         * infrun.c (displaced_step_prepare, resume): Replace
1464         throw_exception with throw.
1465         * infcmd.c (post_create_inferior): Replace throw_exception with
1466         throw.
1467         * inf-loop.c (inferior_event_handler): Replace throw_exception
1468         with throw.
1469         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1470         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1471         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1472         (get_prev_frame_always, get_frame_pc_if_available)
1473         (get_frame_address_in_block_if_available, get_frame_language):
1474         Replace throw_exception with throw.
1475         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1476         throw_exception with throw.
1477         * eval.c (fetch_subexp_value, evaluate_var_value)
1478         (evaluate_funcall, evaluate_subexp_standard): Replace
1479         throw_exception with throw.
1480         * dwarf2loc.c (call_site_find_chain)
1481         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1482         Replace throw_exception with throw.
1483         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1484         with throw.
1485         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1486         throw.
1487         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1488         * completer.c (complete_line_internal): Replace throw_exception
1489         with throw.
1490         * compile/compile-object-run.c (compile_object_run): Replace
1491         throw_exception with throw.
1492         * cli/cli-script.c (process_next_line): Replace throw_exception
1493         with throw.
1494         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1495         (btrace_enable, btrace_maint_update_pt_packets): Replace
1496         throw_exception with throw.
1497         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1498         throw_exception with throw.
1499         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1500         throw_exception with throw.
1501         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1502         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1503         * aarch64-tdep.c (aarch64_make_prologue_cache)
1504         (aarch64_make_stub_cache): Replace throw_exception with throw.
1505
1506 2019-04-08  Tom Tromey  <tom@tromey.com>
1507
1508         * common/common-exceptions.c (throw_exception): Rename from
1509         throw_exception_cxx.  Remove old copy.  Make argument const.
1510         (throw_it): Create and throw exception objects directly.
1511         * common/common-exceptions.h (throw_exception): Make argument
1512         const.
1513         (struct gdb_exception_error): Add constructor.
1514         (struct gdb_exception_quit): Add constructor.
1515
1516 2019-04-08  Tom Tromey  <tom@tromey.com>
1517
1518         * common/common-exceptions.h (exception_rethrow): Don't declare.
1519         (TRY_SJLJ): Update comment.
1520         (TRY, CATCH, END_CATCH): Remove.
1521         * common/common-exceptions.c (exception_rethrow): Remove.
1522
1523 2019-04-08  Tom Tromey  <tom@tromey.com>
1524
1525         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1526         Remove.
1527         (gdb_exception_error): Rename from
1528         gdb_exception_RETURN_MASK_ERROR.
1529         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1530         (gdb_quit_bad_alloc): Update.
1531         * aarch64-tdep.c: Update.
1532         * ada-lang.c: Update.
1533         * ada-typeprint.c: Update.
1534         * ada-valprint.c: Update.
1535         * amd64-tdep.c: Update.
1536         * arch-utils.c: Update.
1537         * break-catch-throw.c: Update.
1538         * breakpoint.c: Update.
1539         * btrace.c: Update.
1540         * c-varobj.c: Update.
1541         * cli/cli-cmds.c: Update.
1542         * cli/cli-interp.c: Update.
1543         * cli/cli-script.c: Update.
1544         * common/common-exceptions.c: Update.
1545         * common/new-op.c: Update.
1546         * common/selftest.c: Update.
1547         * compile/compile-c-symbols.c: Update.
1548         * compile/compile-cplus-symbols.c: Update.
1549         * compile/compile-object-load.c: Update.
1550         * compile/compile-object-run.c: Update.
1551         * completer.c: Update.
1552         * corelow.c: Update.
1553         * cp-abi.c: Update.
1554         * cp-support.c: Update.
1555         * cp-valprint.c: Update.
1556         * darwin-nat.c: Update.
1557         * disasm-selftests.c: Update.
1558         * dtrace-probe.c: Update.
1559         * dwarf-index-cache.c: Update.
1560         * dwarf-index-write.c: Update.
1561         * dwarf2-frame-tailcall.c: Update.
1562         * dwarf2-frame.c: Update.
1563         * dwarf2loc.c: Update.
1564         * dwarf2read.c: Update.
1565         * eval.c: Update.
1566         * event-loop.c: Update.
1567         * event-top.c: Update.
1568         * exec.c: Update.
1569         * f-valprint.c: Update.
1570         * fbsd-tdep.c: Update.
1571         * frame-unwind.c: Update.
1572         * frame.c: Update.
1573         * gdbtypes.c: Update.
1574         * gnu-v3-abi.c: Update.
1575         * guile/guile-internal.h: Update.
1576         * guile/scm-block.c: Update.
1577         * guile/scm-breakpoint.c: Update.
1578         * guile/scm-cmd.c: Update.
1579         * guile/scm-disasm.c: Update.
1580         * guile/scm-frame.c: Update.
1581         * guile/scm-lazy-string.c: Update.
1582         * guile/scm-math.c: Update.
1583         * guile/scm-param.c: Update.
1584         * guile/scm-ports.c: Update.
1585         * guile/scm-pretty-print.c: Update.
1586         * guile/scm-symbol.c: Update.
1587         * guile/scm-symtab.c: Update.
1588         * guile/scm-type.c: Update.
1589         * guile/scm-value.c: Update.
1590         * i386-linux-tdep.c: Update.
1591         * i386-tdep.c: Update.
1592         * inf-loop.c: Update.
1593         * infcall.c: Update.
1594         * infcmd.c: Update.
1595         * infrun.c: Update.
1596         * jit.c: Update.
1597         * language.c: Update.
1598         * linespec.c: Update.
1599         * linux-fork.c: Update.
1600         * linux-nat.c: Update.
1601         * linux-tdep.c: Update.
1602         * linux-thread-db.c: Update.
1603         * main.c: Update.
1604         * mi/mi-cmd-break.c: Update.
1605         * mi/mi-cmd-stack.c: Update.
1606         * mi/mi-interp.c: Update.
1607         * mi/mi-main.c: Update.
1608         * objc-lang.c: Update.
1609         * p-valprint.c: Update.
1610         * parse.c: Update.
1611         * ppc-linux-tdep.c: Update.
1612         * printcmd.c: Update.
1613         * python/py-arch.c: Update.
1614         * python/py-breakpoint.c: Update.
1615         * python/py-cmd.c: Update.
1616         * python/py-finishbreakpoint.c: Update.
1617         * python/py-frame.c: Update.
1618         * python/py-framefilter.c: Update.
1619         * python/py-gdb-readline.c: Update.
1620         * python/py-inferior.c: Update.
1621         * python/py-infthread.c: Update.
1622         * python/py-lazy-string.c: Update.
1623         * python/py-linetable.c: Update.
1624         * python/py-objfile.c: Update.
1625         * python/py-param.c: Update.
1626         * python/py-prettyprint.c: Update.
1627         * python/py-progspace.c: Update.
1628         * python/py-record-btrace.c: Update.
1629         * python/py-record.c: Update.
1630         * python/py-symbol.c: Update.
1631         * python/py-type.c: Update.
1632         * python/py-unwind.c: Update.
1633         * python/py-utils.c: Update.
1634         * python/py-value.c: Update.
1635         * python/python.c: Update.
1636         * record-btrace.c: Update.
1637         * record-full.c: Update.
1638         * remote-fileio.c: Update.
1639         * remote.c: Update.
1640         * riscv-tdep.c: Update.
1641         * rs6000-aix-tdep.c: Update.
1642         * rs6000-tdep.c: Update.
1643         * rust-exp.y: Update.
1644         * rust-lang.c: Update.
1645         * s390-tdep.c: Update.
1646         * selftest-arch.c: Update.
1647         * solib-dsbt.c: Update.
1648         * solib-frv.c: Update.
1649         * solib-spu.c: Update.
1650         * solib-svr4.c: Update.
1651         * solib.c: Update.
1652         * sparc64-linux-tdep.c: Update.
1653         * stack.c: Update.
1654         * symfile-mem.c: Update.
1655         * symmisc.c: Update.
1656         * target.c: Update.
1657         * thread.c: Update.
1658         * top.c: Update.
1659         * tracefile-tfile.c: Update.
1660         * tui/tui.c: Update.
1661         * typeprint.c: Update.
1662         * unittests/cli-utils-selftests.c: Update.
1663         * unittests/parse-connection-spec-selftests.c: Update.
1664         * valops.c: Update.
1665         * valprint.c: Update.
1666         * value.c: Update.
1667         * varobj.c: Update.
1668         * windows-nat.c: Update.
1669         * x86-linux-nat.c: Update.
1670         * xml-support.c: Update.
1671
1672 2019-04-08  Tom Tromey  <tom@tromey.com>
1673
1674         * xml-support.c: Use C++ exception handling.
1675         * x86-linux-nat.c: Use C++ exception handling.
1676         * windows-nat.c: Use C++ exception handling.
1677         * varobj.c: Use C++ exception handling.
1678         * value.c: Use C++ exception handling.
1679         * valprint.c: Use C++ exception handling.
1680         * valops.c: Use C++ exception handling.
1681         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1682         handling.
1683         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1684         * typeprint.c: Use C++ exception handling.
1685         * tui/tui.c: Use C++ exception handling.
1686         * tracefile-tfile.c: Use C++ exception handling.
1687         * top.c: Use C++ exception handling.
1688         * thread.c: Use C++ exception handling.
1689         * target.c: Use C++ exception handling.
1690         * symmisc.c: Use C++ exception handling.
1691         * symfile-mem.c: Use C++ exception handling.
1692         * stack.c: Use C++ exception handling.
1693         * sparc64-linux-tdep.c: Use C++ exception handling.
1694         * solib.c: Use C++ exception handling.
1695         * solib-svr4.c: Use C++ exception handling.
1696         * solib-spu.c: Use C++ exception handling.
1697         * solib-frv.c: Use C++ exception handling.
1698         * solib-dsbt.c: Use C++ exception handling.
1699         * selftest-arch.c: Use C++ exception handling.
1700         * s390-tdep.c: Use C++ exception handling.
1701         * rust-lang.c: Use C++ exception handling.
1702         * rust-exp.y: Use C++ exception handling.
1703         * rs6000-tdep.c: Use C++ exception handling.
1704         * rs6000-aix-tdep.c: Use C++ exception handling.
1705         * riscv-tdep.c: Use C++ exception handling.
1706         * remote.c: Use C++ exception handling.
1707         * remote-fileio.c: Use C++ exception handling.
1708         * record-full.c: Use C++ exception handling.
1709         * record-btrace.c: Use C++ exception handling.
1710         * python/python.c: Use C++ exception handling.
1711         * python/py-value.c: Use C++ exception handling.
1712         * python/py-utils.c: Use C++ exception handling.
1713         * python/py-unwind.c: Use C++ exception handling.
1714         * python/py-type.c: Use C++ exception handling.
1715         * python/py-symbol.c: Use C++ exception handling.
1716         * python/py-record.c: Use C++ exception handling.
1717         * python/py-record-btrace.c: Use C++ exception handling.
1718         * python/py-progspace.c: Use C++ exception handling.
1719         * python/py-prettyprint.c: Use C++ exception handling.
1720         * python/py-param.c: Use C++ exception handling.
1721         * python/py-objfile.c: Use C++ exception handling.
1722         * python/py-linetable.c: Use C++ exception handling.
1723         * python/py-lazy-string.c: Use C++ exception handling.
1724         * python/py-infthread.c: Use C++ exception handling.
1725         * python/py-inferior.c: Use C++ exception handling.
1726         * python/py-gdb-readline.c: Use C++ exception handling.
1727         * python/py-framefilter.c: Use C++ exception handling.
1728         * python/py-frame.c: Use C++ exception handling.
1729         * python/py-finishbreakpoint.c: Use C++ exception handling.
1730         * python/py-cmd.c: Use C++ exception handling.
1731         * python/py-breakpoint.c: Use C++ exception handling.
1732         * python/py-arch.c: Use C++ exception handling.
1733         * printcmd.c: Use C++ exception handling.
1734         * ppc-linux-tdep.c: Use C++ exception handling.
1735         * parse.c: Use C++ exception handling.
1736         * p-valprint.c: Use C++ exception handling.
1737         * objc-lang.c: Use C++ exception handling.
1738         * mi/mi-main.c: Use C++ exception handling.
1739         * mi/mi-interp.c: Use C++ exception handling.
1740         * mi/mi-cmd-stack.c: Use C++ exception handling.
1741         * mi/mi-cmd-break.c: Use C++ exception handling.
1742         * main.c: Use C++ exception handling.
1743         * linux-thread-db.c: Use C++ exception handling.
1744         * linux-tdep.c: Use C++ exception handling.
1745         * linux-nat.c: Use C++ exception handling.
1746         * linux-fork.c: Use C++ exception handling.
1747         * linespec.c: Use C++ exception handling.
1748         * language.c: Use C++ exception handling.
1749         * jit.c: Use C++ exception handling.
1750         * infrun.c: Use C++ exception handling.
1751         * infcmd.c: Use C++ exception handling.
1752         * infcall.c: Use C++ exception handling.
1753         * inf-loop.c: Use C++ exception handling.
1754         * i386-tdep.c: Use C++ exception handling.
1755         * i386-linux-tdep.c: Use C++ exception handling.
1756         * guile/scm-value.c: Use C++ exception handling.
1757         * guile/scm-type.c: Use C++ exception handling.
1758         * guile/scm-symtab.c: Use C++ exception handling.
1759         * guile/scm-symbol.c: Use C++ exception handling.
1760         * guile/scm-pretty-print.c: Use C++ exception handling.
1761         * guile/scm-ports.c: Use C++ exception handling.
1762         * guile/scm-param.c: Use C++ exception handling.
1763         * guile/scm-math.c: Use C++ exception handling.
1764         * guile/scm-lazy-string.c: Use C++ exception handling.
1765         * guile/scm-frame.c: Use C++ exception handling.
1766         * guile/scm-disasm.c: Use C++ exception handling.
1767         * guile/scm-cmd.c: Use C++ exception handling.
1768         * guile/scm-breakpoint.c: Use C++ exception handling.
1769         * guile/scm-block.c: Use C++ exception handling.
1770         * guile/guile-internal.h: Use C++ exception handling.
1771         * gnu-v3-abi.c: Use C++ exception handling.
1772         * gdbtypes.c: Use C++ exception handling.
1773         * frame.c: Use C++ exception handling.
1774         * frame-unwind.c: Use C++ exception handling.
1775         * fbsd-tdep.c: Use C++ exception handling.
1776         * f-valprint.c: Use C++ exception handling.
1777         * exec.c: Use C++ exception handling.
1778         * event-top.c: Use C++ exception handling.
1779         * event-loop.c: Use C++ exception handling.
1780         * eval.c: Use C++ exception handling.
1781         * dwarf2read.c: Use C++ exception handling.
1782         * dwarf2loc.c: Use C++ exception handling.
1783         * dwarf2-frame.c: Use C++ exception handling.
1784         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1785         * dwarf-index-write.c: Use C++ exception handling.
1786         * dwarf-index-cache.c: Use C++ exception handling.
1787         * dtrace-probe.c: Use C++ exception handling.
1788         * disasm-selftests.c: Use C++ exception handling.
1789         * darwin-nat.c: Use C++ exception handling.
1790         * cp-valprint.c: Use C++ exception handling.
1791         * cp-support.c: Use C++ exception handling.
1792         * cp-abi.c: Use C++ exception handling.
1793         * corelow.c: Use C++ exception handling.
1794         * completer.c: Use C++ exception handling.
1795         * compile/compile-object-run.c: Use C++ exception handling.
1796         * compile/compile-object-load.c: Use C++ exception handling.
1797         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1798         * compile/compile-c-symbols.c: Use C++ exception handling.
1799         * common/selftest.c: Use C++ exception handling.
1800         * common/new-op.c: Use C++ exception handling.
1801         * cli/cli-script.c: Use C++ exception handling.
1802         * cli/cli-interp.c: Use C++ exception handling.
1803         * cli/cli-cmds.c: Use C++ exception handling.
1804         * c-varobj.c: Use C++ exception handling.
1805         * btrace.c: Use C++ exception handling.
1806         * breakpoint.c: Use C++ exception handling.
1807         * break-catch-throw.c: Use C++ exception handling.
1808         * arch-utils.c: Use C++ exception handling.
1809         * amd64-tdep.c: Use C++ exception handling.
1810         * ada-valprint.c: Use C++ exception handling.
1811         * ada-typeprint.c: Use C++ exception handling.
1812         * ada-lang.c: Use C++ exception handling.
1813         * aarch64-tdep.c: Use C++ exception handling.
1814
1815 2019-04-08  Tom Tromey  <tom@tromey.com>
1816
1817         * xml-support.c (gdb_xml_parser::parse): Update.
1818         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1819         * value.c (show_convenience): Update.
1820         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1821         (test_parse_flags_qcs): Update.
1822         * thread.c (thr_try_catch_cmd): Update.
1823         * target.c (target_translate_tls_address): Update.
1824         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1825         (info_frame_command_core, frame_apply_command_count): Update.
1826         * rust-exp.y (rust_lex_exception_test): Update.
1827         * riscv-tdep.c (riscv_print_one_register_info): Update.
1828         * remote.c (remote_target::enable_btrace): Update.
1829         * record-btrace.c (record_btrace_enable_warn): Update.
1830         * python/py-utils.c (gdbpy_convert_exception): Update.
1831         * printcmd.c (do_one_display, print_variable_and_value): Update.
1832         * mi/mi-main.c (mi_print_exception): Update.
1833         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1834         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1835         * linux-nat.c (linux_nat_target::attach): Update.
1836         * linux-fork.c (class scoped_switch_fork_info): Update.
1837         * infrun.c (displaced_step_prepare): Update.
1838         * infcall.c (call_function_by_hand_dummy): Update.
1839         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1840         * gnu-v3-abi.c (print_one_vtable): Update.
1841         * frame.c (get_prev_frame_always): Update.
1842         * f-valprint.c (info_common_command_for_block): Update.
1843         * exec.c (try_open_exec_file): Update.
1844         * exceptions.c (print_exception, exception_print)
1845         (exception_fprintf, exception_print_same): Update.
1846         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1847         * dwarf-index-cache.c (index_cache::store)
1848         (index_cache::lookup_gdb_index): Update.
1849         * darwin-nat.c (maybe_cache_shell): Update.
1850         * cp-valprint.c (cp_print_value_fields): Update.
1851         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1852         (gcc_cplus_symbol_address): Update.
1853         * compile/compile-c-symbols.c (gcc_convert_symbol)
1854         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1855         * common/selftest.c: Update.
1856         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1857         a std::string.
1858         (exception_try_scope_entry, exception_try_scope_exit): Don't
1859         declare.
1860         (struct exception_try_scope): Remove.
1861         (TRY): Don't use exception_try_scope.
1862         (struct gdb_exception): Add constructor, operator=.
1863         <what>: New method.
1864         (struct gdb_exception_RETURN_MASK_ALL)
1865         (struct gdb_exception_RETURN_MASK_ERROR)
1866         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1867         (struct gdb_quit_bad_alloc): Update.
1868         * common/common-exceptions.c (exception_none): Change
1869         initializer.
1870         (struct catcher) <state, exception>: Initialize inline.
1871         <prev>: Remove member.
1872         (current_catcher): Remove.
1873         (catchers): New global.
1874         (exceptions_state_mc_init): Simplify.
1875         (catcher_pop): Remove.
1876         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1877         (try_scope_depth, exception_try_scope_entry)
1878         (exception_try_scope_exit): Remove.
1879         (throw_exception_sjlj): Update.
1880         (exception_messages, exception_messages_size): Remove.
1881         (throw_it): Simplify.
1882         (gdb_exception_sliced_copy): Remove.
1883         (throw_exception_cxx): Update.
1884         * cli/cli-script.c (script_from_file): Update.
1885         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1886         Update.
1887         * ada-valprint.c (ada_val_print): Update.
1888         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1889         (create_excep_cond_exprs): Update.
1890
1891 2019-04-08  Tom Tromey  <tom@tromey.com>
1892
1893         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1894         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1895         (TRY, CATCH, END_CATCH): Remove some definitions.
1896         * common/common-exceptions.c: Don't use GDB_XCPT.
1897         (catcher_list_size): Remove.
1898         (throw_exception, throw_it): Simplify.
1899
1900 2019-04-05  Tom Tromey  <tom@tromey.com>
1901
1902         Revert the header-sorting patch.
1903         * ft32-tdep.c: Revert.
1904         * frv-tdep.c: Revert.
1905         * frv-linux-tdep.c: Revert.
1906         * frame.c: Revert.
1907         * frame-unwind.c: Revert.
1908         * frame-base.c: Revert.
1909         * fork-child.c: Revert.
1910         * findvar.c: Revert.
1911         * findcmd.c: Revert.
1912         * filesystem.c: Revert.
1913         * filename-seen-cache.h: Revert.
1914         * filename-seen-cache.c: Revert.
1915         * fbsd-tdep.c: Revert.
1916         * fbsd-nat.h: Revert.
1917         * fbsd-nat.c: Revert.
1918         * f-valprint.c: Revert.
1919         * f-typeprint.c: Revert.
1920         * f-lang.c: Revert.
1921         * extension.h: Revert.
1922         * extension.c: Revert.
1923         * extension-priv.h: Revert.
1924         * expprint.c: Revert.
1925         * exec.h: Revert.
1926         * exec.c: Revert.
1927         * exceptions.c: Revert.
1928         * event-top.c: Revert.
1929         * event-loop.c: Revert.
1930         * eval.c: Revert.
1931         * elfread.c: Revert.
1932         * dwarf2read.h: Revert.
1933         * dwarf2read.c: Revert.
1934         * dwarf2loc.c: Revert.
1935         * dwarf2expr.h: Revert.
1936         * dwarf2expr.c: Revert.
1937         * dwarf2-frame.c: Revert.
1938         * dwarf2-frame-tailcall.c: Revert.
1939         * dwarf-index-write.h: Revert.
1940         * dwarf-index-write.c: Revert.
1941         * dwarf-index-common.c: Revert.
1942         * dwarf-index-cache.h: Revert.
1943         * dwarf-index-cache.c: Revert.
1944         * dummy-frame.c: Revert.
1945         * dtrace-probe.c: Revert.
1946         * disasm.h: Revert.
1947         * disasm.c: Revert.
1948         * disasm-selftests.c: Revert.
1949         * dictionary.c: Revert.
1950         * dicos-tdep.c: Revert.
1951         * demangle.c: Revert.
1952         * dcache.h: Revert.
1953         * dcache.c: Revert.
1954         * darwin-nat.h: Revert.
1955         * darwin-nat.c: Revert.
1956         * darwin-nat-info.c: Revert.
1957         * d-valprint.c: Revert.
1958         * d-namespace.c: Revert.
1959         * d-lang.c: Revert.
1960         * ctf.c: Revert.
1961         * csky-tdep.c: Revert.
1962         * csky-linux-tdep.c: Revert.
1963         * cris-tdep.c: Revert.
1964         * cris-linux-tdep.c: Revert.
1965         * cp-valprint.c: Revert.
1966         * cp-support.c: Revert.
1967         * cp-namespace.c: Revert.
1968         * cp-abi.c: Revert.
1969         * corelow.c: Revert.
1970         * corefile.c: Revert.
1971         * continuations.c: Revert.
1972         * completer.h: Revert.
1973         * completer.c: Revert.
1974         * complaints.c: Revert.
1975         * coffread.c: Revert.
1976         * coff-pe-read.c: Revert.
1977         * cli-out.h: Revert.
1978         * cli-out.c: Revert.
1979         * charset.c: Revert.
1980         * c-varobj.c: Revert.
1981         * c-valprint.c: Revert.
1982         * c-typeprint.c: Revert.
1983         * c-lang.c: Revert.
1984         * buildsym.c: Revert.
1985         * buildsym-legacy.c: Revert.
1986         * build-id.h: Revert.
1987         * build-id.c: Revert.
1988         * btrace.c: Revert.
1989         * bsd-uthread.c: Revert.
1990         * breakpoint.h: Revert.
1991         * breakpoint.c: Revert.
1992         * break-catch-throw.c: Revert.
1993         * break-catch-syscall.c: Revert.
1994         * break-catch-sig.c: Revert.
1995         * blockframe.c: Revert.
1996         * block.c: Revert.
1997         * bfin-tdep.c: Revert.
1998         * bfin-linux-tdep.c: Revert.
1999         * bfd-target.c: Revert.
2000         * bcache.c: Revert.
2001         * ax-general.c: Revert.
2002         * ax-gdb.h: Revert.
2003         * ax-gdb.c: Revert.
2004         * avr-tdep.c: Revert.
2005         * auxv.c: Revert.
2006         * auto-load.c: Revert.
2007         * arm-wince-tdep.c: Revert.
2008         * arm-tdep.c: Revert.
2009         * arm-symbian-tdep.c: Revert.
2010         * arm-pikeos-tdep.c: Revert.
2011         * arm-obsd-tdep.c: Revert.
2012         * arm-nbsd-tdep.c: Revert.
2013         * arm-nbsd-nat.c: Revert.
2014         * arm-linux-tdep.c: Revert.
2015         * arm-linux-nat.c: Revert.
2016         * arm-fbsd-tdep.c: Revert.
2017         * arm-fbsd-nat.c: Revert.
2018         * arm-bsd-tdep.c: Revert.
2019         * arch-utils.c: Revert.
2020         * arc-tdep.c: Revert.
2021         * arc-newlib-tdep.c: Revert.
2022         * annotate.h: Revert.
2023         * annotate.c: Revert.
2024         * amd64-windows-tdep.c: Revert.
2025         * amd64-windows-nat.c: Revert.
2026         * amd64-tdep.c: Revert.
2027         * amd64-sol2-tdep.c: Revert.
2028         * amd64-obsd-tdep.c: Revert.
2029         * amd64-obsd-nat.c: Revert.
2030         * amd64-nbsd-tdep.c: Revert.
2031         * amd64-nbsd-nat.c: Revert.
2032         * amd64-nat.c: Revert.
2033         * amd64-linux-tdep.c: Revert.
2034         * amd64-linux-nat.c: Revert.
2035         * amd64-fbsd-tdep.c: Revert.
2036         * amd64-fbsd-nat.c: Revert.
2037         * amd64-dicos-tdep.c: Revert.
2038         * amd64-darwin-tdep.c: Revert.
2039         * amd64-bsd-nat.c: Revert.
2040         * alpha-tdep.c: Revert.
2041         * alpha-obsd-tdep.c: Revert.
2042         * alpha-nbsd-tdep.c: Revert.
2043         * alpha-mdebug-tdep.c: Revert.
2044         * alpha-linux-tdep.c: Revert.
2045         * alpha-linux-nat.c: Revert.
2046         * alpha-bsd-tdep.c: Revert.
2047         * alpha-bsd-nat.c: Revert.
2048         * aix-thread.c: Revert.
2049         * agent.c: Revert.
2050         * addrmap.c: Revert.
2051         * ada-varobj.c: Revert.
2052         * ada-valprint.c: Revert.
2053         * ada-typeprint.c: Revert.
2054         * ada-tasks.c: Revert.
2055         * ada-lang.c: Revert.
2056         * aarch64-tdep.c: Revert.
2057         * aarch64-ravenscar-thread.c: Revert.
2058         * aarch64-newlib-tdep.c: Revert.
2059         * aarch64-linux-tdep.c: Revert.
2060         * aarch64-linux-nat.c: Revert.
2061         * aarch64-fbsd-tdep.c: Revert.
2062         * aarch64-fbsd-nat.c: Revert.
2063         * aarch32-linux-nat.c: Revert.
2064
2065 2019-04-05  Tom Tromey  <tom@tromey.com>
2066
2067         * ft32-tdep.c: Sort headers.
2068         * frv-tdep.c: Sort headers.
2069         * frv-linux-tdep.c: Sort headers.
2070         * frame.c: Sort headers.
2071         * frame-unwind.c: Sort headers.
2072         * frame-base.c: Sort headers.
2073         * fork-child.c: Sort headers.
2074         * findvar.c: Sort headers.
2075         * findcmd.c: Sort headers.
2076         * filesystem.c: Sort headers.
2077         * filename-seen-cache.h: Sort headers.
2078         * filename-seen-cache.c: Sort headers.
2079         * fbsd-tdep.c: Sort headers.
2080         * fbsd-nat.h: Sort headers.
2081         * fbsd-nat.c: Sort headers.
2082         * f-valprint.c: Sort headers.
2083         * f-typeprint.c: Sort headers.
2084         * f-lang.c: Sort headers.
2085         * extension.h: Sort headers.
2086         * extension.c: Sort headers.
2087         * extension-priv.h: Sort headers.
2088         * expprint.c: Sort headers.
2089         * exec.h: Sort headers.
2090         * exec.c: Sort headers.
2091         * exceptions.c: Sort headers.
2092         * event-top.c: Sort headers.
2093         * event-loop.c: Sort headers.
2094         * eval.c: Sort headers.
2095         * elfread.c: Sort headers.
2096         * dwarf2read.h: Sort headers.
2097         * dwarf2read.c: Sort headers.
2098         * dwarf2loc.c: Sort headers.
2099         * dwarf2expr.h: Sort headers.
2100         * dwarf2expr.c: Sort headers.
2101         * dwarf2-frame.c: Sort headers.
2102         * dwarf2-frame-tailcall.c: Sort headers.
2103         * dwarf-index-write.h: Sort headers.
2104         * dwarf-index-write.c: Sort headers.
2105         * dwarf-index-common.c: Sort headers.
2106         * dwarf-index-cache.h: Sort headers.
2107         * dwarf-index-cache.c: Sort headers.
2108         * dummy-frame.c: Sort headers.
2109         * dtrace-probe.c: Sort headers.
2110         * disasm.h: Sort headers.
2111         * disasm.c: Sort headers.
2112         * disasm-selftests.c: Sort headers.
2113         * dictionary.c: Sort headers.
2114         * dicos-tdep.c: Sort headers.
2115         * demangle.c: Sort headers.
2116         * dcache.h: Sort headers.
2117         * dcache.c: Sort headers.
2118         * darwin-nat.h: Sort headers.
2119         * darwin-nat.c: Sort headers.
2120         * darwin-nat-info.c: Sort headers.
2121         * d-valprint.c: Sort headers.
2122         * d-namespace.c: Sort headers.
2123         * d-lang.c: Sort headers.
2124         * ctf.c: Sort headers.
2125         * csky-tdep.c: Sort headers.
2126         * csky-linux-tdep.c: Sort headers.
2127         * cris-tdep.c: Sort headers.
2128         * cris-linux-tdep.c: Sort headers.
2129         * cp-valprint.c: Sort headers.
2130         * cp-support.c: Sort headers.
2131         * cp-namespace.c: Sort headers.
2132         * cp-abi.c: Sort headers.
2133         * corelow.c: Sort headers.
2134         * corefile.c: Sort headers.
2135         * continuations.c: Sort headers.
2136         * completer.h: Sort headers.
2137         * completer.c: Sort headers.
2138         * complaints.c: Sort headers.
2139         * coffread.c: Sort headers.
2140         * coff-pe-read.c: Sort headers.
2141         * cli-out.h: Sort headers.
2142         * cli-out.c: Sort headers.
2143         * charset.c: Sort headers.
2144         * c-varobj.c: Sort headers.
2145         * c-valprint.c: Sort headers.
2146         * c-typeprint.c: Sort headers.
2147         * c-lang.c: Sort headers.
2148         * buildsym.c: Sort headers.
2149         * buildsym-legacy.c: Sort headers.
2150         * build-id.h: Sort headers.
2151         * build-id.c: Sort headers.
2152         * btrace.c: Sort headers.
2153         * bsd-uthread.c: Sort headers.
2154         * breakpoint.h: Sort headers.
2155         * breakpoint.c: Sort headers.
2156         * break-catch-throw.c: Sort headers.
2157         * break-catch-syscall.c: Sort headers.
2158         * break-catch-sig.c: Sort headers.
2159         * blockframe.c: Sort headers.
2160         * block.c: Sort headers.
2161         * bfin-tdep.c: Sort headers.
2162         * bfin-linux-tdep.c: Sort headers.
2163         * bfd-target.c: Sort headers.
2164         * bcache.c: Sort headers.
2165         * ax-general.c: Sort headers.
2166         * ax-gdb.h: Sort headers.
2167         * ax-gdb.c: Sort headers.
2168         * avr-tdep.c: Sort headers.
2169         * auxv.c: Sort headers.
2170         * auto-load.c: Sort headers.
2171         * arm-wince-tdep.c: Sort headers.
2172         * arm-tdep.c: Sort headers.
2173         * arm-symbian-tdep.c: Sort headers.
2174         * arm-pikeos-tdep.c: Sort headers.
2175         * arm-obsd-tdep.c: Sort headers.
2176         * arm-nbsd-tdep.c: Sort headers.
2177         * arm-nbsd-nat.c: Sort headers.
2178         * arm-linux-tdep.c: Sort headers.
2179         * arm-linux-nat.c: Sort headers.
2180         * arm-fbsd-tdep.c: Sort headers.
2181         * arm-fbsd-nat.c: Sort headers.
2182         * arm-bsd-tdep.c: Sort headers.
2183         * arch-utils.c: Sort headers.
2184         * arc-tdep.c: Sort headers.
2185         * arc-newlib-tdep.c: Sort headers.
2186         * annotate.h: Sort headers.
2187         * annotate.c: Sort headers.
2188         * amd64-windows-tdep.c: Sort headers.
2189         * amd64-windows-nat.c: Sort headers.
2190         * amd64-tdep.c: Sort headers.
2191         * amd64-sol2-tdep.c: Sort headers.
2192         * amd64-obsd-tdep.c: Sort headers.
2193         * amd64-obsd-nat.c: Sort headers.
2194         * amd64-nbsd-tdep.c: Sort headers.
2195         * amd64-nbsd-nat.c: Sort headers.
2196         * amd64-nat.c: Sort headers.
2197         * amd64-linux-tdep.c: Sort headers.
2198         * amd64-linux-nat.c: Sort headers.
2199         * amd64-fbsd-tdep.c: Sort headers.
2200         * amd64-fbsd-nat.c: Sort headers.
2201         * amd64-dicos-tdep.c: Sort headers.
2202         * amd64-darwin-tdep.c: Sort headers.
2203         * amd64-bsd-nat.c: Sort headers.
2204         * alpha-tdep.c: Sort headers.
2205         * alpha-obsd-tdep.c: Sort headers.
2206         * alpha-nbsd-tdep.c: Sort headers.
2207         * alpha-mdebug-tdep.c: Sort headers.
2208         * alpha-linux-tdep.c: Sort headers.
2209         * alpha-linux-nat.c: Sort headers.
2210         * alpha-bsd-tdep.c: Sort headers.
2211         * alpha-bsd-nat.c: Sort headers.
2212         * aix-thread.c: Sort headers.
2213         * agent.c: Sort headers.
2214         * addrmap.c: Sort headers.
2215         * ada-varobj.c: Sort headers.
2216         * ada-valprint.c: Sort headers.
2217         * ada-typeprint.c: Sort headers.
2218         * ada-tasks.c: Sort headers.
2219         * ada-lang.c: Sort headers.
2220         * aarch64-tdep.c: Sort headers.
2221         * aarch64-ravenscar-thread.c: Sort headers.
2222         * aarch64-newlib-tdep.c: Sort headers.
2223         * aarch64-linux-tdep.c: Sort headers.
2224         * aarch64-linux-nat.c: Sort headers.
2225         * aarch64-fbsd-tdep.c: Sort headers.
2226         * aarch64-fbsd-nat.c: Sort headers.
2227         * aarch32-linux-nat.c: Sort headers.
2228
2229 2019-04-04  Tom Tromey  <tom@tromey.com>
2230
2231         * varobj.c (varobj_create): Update.
2232         * rust-exp.y (struct rust_parser) <update_innermost_block,
2233         lookup_symbol>: New methods.
2234         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2235         Rename.
2236         (rust_parser::rust_lookup_type)
2237         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2238         * printcmd.c (display_command, do_one_display): Update.
2239         * parser-defs.h (struct parser_state) <parser_state>: Add
2240         "tracker" parameter.
2241         (block_tracker): New member.
2242         (class innermost_block_tracker) <innermost_block_tracker>: Add
2243         "types" parameter.
2244         <reset>: Remove method.
2245         (innermost_block): Don't declare.
2246         (null_post_parser): Update.
2247         * parse.c (innermost_block): Remove global.
2248         (write_dollar_variable): Update.
2249         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2250         Remove "tracker_types" parameter.
2251         (parse_expression): Add "tracker" parameter.
2252         (parse_expression_for_completion): Update.
2253         (null_post_parser): Add "tracker" parameter.
2254         * p-exp.y: Update rules.
2255         * m2-exp.y: Update rules.
2256         * language.h (struct language_defn) <la_post_parser>: Add
2257         "tracker" parameter.
2258         * go-exp.y: Update rules.
2259         * f-exp.y: Update rules.
2260         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2261         parameter.
2262         * d-exp.y: Update rules.
2263         * c-exp.y: Update rules.
2264         * breakpoint.c (set_breakpoint_condition): Create an
2265         innermost_block_tracker.
2266         (watch_command_1): Likewise.
2267         * ada-lang.c (resolve): Add "tracker" parameter.
2268         (resolve_subexp): Likewise.
2269         * ada-exp.y (write_var_from_sym): Update.
2270
2271 2019-04-04  Tom Tromey  <tom@tromey.com>
2272
2273         * type-stack.h: New file.
2274         * type-stack.c: New file.
2275         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2276         type-stack.h.
2277         (insert_into_type_stack, insert_type, push_type, push_type_int)
2278         (insert_type_address_space, pop_type, pop_type_int)
2279         (pop_typelist, pop_type_stack, append_type_stack)
2280         (push_type_stack, get_type_stack, push_typelist)
2281         (follow_type_instance_flags, follow_types): Don't declare.
2282         * parse.c (type_stack): Remove global.
2283         (parse_exp_in_context): Update.
2284         (insert_into_type_stack, insert_type, push_type, push_type_int)
2285         (insert_type_address_space, pop_type, pop_type_int)
2286         (pop_typelist, pop_type_stack, append_type_stack)
2287         (push_type_stack, get_type_stack, push_typelist)
2288         (follow_type_instance_flags, follow_types): Remove (moved to
2289         type-stack.c).
2290         * f-exp.y (type_stack): New global.
2291         Update rules.
2292         (push_kind_type, f_parse): Update.
2293         * d-exp.y (type_stack): New global.
2294         Update rules.
2295         (d_parse): Update.
2296         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2297         Update rules.
2298         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2299         (HFILES_NO_SRCDIR): Add type-stack.h.
2300
2301 2019-04-04  Tom Tromey  <tom@tromey.com>
2302
2303         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2304         (rust_parser::convert_ast_to_expression, rust_parse)
2305         (rust_lex_test_completion, rust_lex_tests): Update.
2306         * parser-defs.h (struct expr_completion_state): New.
2307         (struct parser_state) <parser_state>: Add completion parameter.
2308         <mark_struct_expression, mark_completion_tag>: New methods.
2309         <parse_completion, m_completion_state>: New members.
2310         (prefixify_expression, null_post_parser): Update.
2311         (mark_struct_expression, mark_completion_tag): Don't declare.
2312         * parse.c (parse_completion, expout_last_struct)
2313         (expout_tag_completion_type, expout_completion_name): Remove
2314         globals.
2315         (parser_state::mark_struct_expression)
2316         (parser_state::mark_completion_tag): Now methods.
2317         (prefixify_expression): Add last_struct parameter.
2318         (prefixify_subexp): Likewise.
2319         (parse_exp_1): Update.
2320         (parse_exp_in_context): Add cstate parameter.  Update.
2321         (parse_expression_for_completion): Create an
2322         expr_completion_state.
2323         (null_post_parser): Add "completion" parameter.
2324         * p-exp.y: Update rules.
2325         (yylex): Update.
2326         * language.h (struct language_defn) <la_post_parser>: Add
2327         "completing" parameter.
2328         * go-exp.y: Update rules.
2329         (lex_one_token): Update.
2330         * expression.h (parse_completion): Don't declare.
2331         * d-exp.y: Update rules.
2332         (lex_one_token): Update rules.
2333         * c-exp.y: Update rules.
2334         (lex_one_token): Update.
2335         * ada-lang.c (resolve): Add "parse_completion" parameter.
2336         (resolve_subexp): Likewise.
2337         (ada_resolve_function): Likewise.
2338
2339 2019-04-04  Tom Tromey  <tom@tromey.com>
2340
2341         * parser-defs.h (struct parser_state) <start_arglist,
2342         end_arglist>: New methods.
2343         <arglist_len, m_funcall_chain>: New members.
2344         (arglist_len, start_arglist, end_arglist): Don't declare.
2345         * parse.c (arglist_len, funcall_chain): Remove global.
2346         (start_arglist, end_arglist): Remove functions.
2347         (parse_exp_in_context): Update.
2348         * p-exp.y: Update rules.
2349         * m2-exp.y: Update rules.
2350         * go-exp.y: Update rules.
2351         * f-exp.y: Update rules.
2352         * d-exp.y: Update rules.
2353         * c-exp.y: Update rules.
2354
2355 2019-04-04  Tom Tromey  <tom@tromey.com>
2356
2357         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2358         lex_operator, push_back>: New methods.
2359         Update all rules.
2360         (rust_parser::lex_hex, lex_escape): Rename and update.
2361         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2362         (rust_parser::lex_operator): Rename and update.
2363         (rust_parser::lex_number, rustyylex, rustyyerror)
2364         (rust_lex_test_init, rust_lex_test_sequence)
2365         (rust_lex_test_push_back, rust_lex_tests): Update.
2366         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2367         parameter.
2368         <lexptr, prev_lexptr>: New members.
2369         (lexptr, prev_lexptr): Don't declare.
2370         * parse.c (lexptr, prev_lexptr): Remove globals.
2371         (parse_exp_in_context): Update.
2372         * p-exp.y (yylex, yyerror): Update.
2373         * m2-exp.y (parse_number, yylex, yyerror): Update.
2374         * go-exp.y (lex_one_token, yyerror): Update.
2375         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2376         * d-exp.y (lex_one_token, yyerror): Update.
2377         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2378         (lex_one_token, yyerror): Update.
2379         * ada-lex.l (YY_INPUT): Update.
2380         (rewind_to_char): Update.
2381         * ada-exp.y (yyerror): Update.
2382
2383 2019-04-04  Tom Tromey  <tom@tromey.com>
2384
2385         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2386         * parser-defs.h (struct parser_state) <parser_state>: Add new
2387         parameter.
2388         <comma_terminates>: New member.
2389         (comma_terminates): Don't declare global.
2390         * parse.c (comma_terminates): Remove global.
2391         (parse_exp_in_context): Update.
2392         * p-exp.y (yylex): Update.
2393         * m2-exp.y (yylex): Update.
2394         * go-exp.y (lex_one_token): Update.
2395         * f-exp.y (yylex): Update.
2396         * d-exp.y (lex_one_token): Update.
2397         * c-exp.y (lex_one_token): Update.
2398         * ada-lex.l: Update.
2399
2400 2019-04-04  Tom Tromey  <tom@tromey.com>
2401
2402         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2403         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2404         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2405         * parser-defs.h (paren_depth): Don't declare.
2406         * parse.c (paren_depth): Remove global.
2407         (parse_exp_in_context): Update.
2408         * p-exp.y (paren_depth): New global.
2409         (pascal_parse): Initialize it.
2410         * m2-exp.y (paren_depth): New global.
2411         (m2_parse): Initialize it.
2412         * go-exp.y (paren_depth): New global.
2413         (go_parse): Initialize it.
2414         * f-exp.y (paren_depth): New global.
2415         (f_parse): Initialize it.
2416         * d-exp.y (paren_depth): New global.
2417         (d_parse): Initialize it.
2418         * c-exp.y (paren_depth): New global.
2419         (c_parse): Initialize it.
2420         * ada-lex.l (paren_depth): New global.
2421         (lexer_init): Initialize it.
2422
2423 2019-04-04  Tom Tromey  <tom@tromey.com>
2424
2425         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2426         (rust_parser::convert_ast_to_type)
2427         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2428         * parser-defs.h (struct parser_state) <parser_state>: Add
2429         parameters.  Initialize new members.
2430         <expression_context_block, expression_context_pc>: New members.
2431         * parse.c (expression_context_block, expression_context_pc):
2432         Remove globals.
2433         (parse_exp_in_context): Update.
2434         * p-exp.y: Update all rules.
2435         (yylex): Update.
2436         * m2-exp.y: Update all rules.
2437         (yylex): Update.
2438         * go-exp.y (yylex): Update.
2439         * f-exp.y (yylex): Update.
2440         * d-exp.y: Update all rules.
2441         (yylex): Update.
2442         * c-exp.y: Update all rules.
2443         (lex_one_token, classify_name, yylex, c_parse): Update.
2444         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2445
2446 2019-04-04  Tom Tromey  <tom@tromey.com>
2447
2448         * gdbarch.h, gdbarch.c: Rebuild.
2449         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2450         * stap-probe.h:
2451         (struct stap_parse_info): Replace "parser_state" with
2452         "expr_builder".
2453         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2454         (parser_state): New class.
2455         * parse.c (expr_builder): Rename.
2456         (expr_builder::release): Rename.
2457         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2458         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2459         (write_exp_elt_longcst, write_exp_elt_floatcst)
2460         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2461         (write_exp_string_vector, write_exp_bitstring)
2462         (write_exp_msymbol, mark_struct_expression)
2463         (write_dollar_variable)
2464         (insert_type_address_space, increase_expout_size): Replace
2465         "parser_state" with "expr_builder".
2466         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2467         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2468         "parser_state" with "expr_builder".
2469
2470 2019-04-04  Tom Tromey  <tom@tromey.com>
2471
2472         * rust-exp.y: Replace "parse_language" with method call.
2473         * p-exp.y:
2474         (yylex): Replace "parse_language" with method call.
2475         * m2-exp.y:
2476         (yylex): Replace "parse_language" with method call.
2477         * go-exp.y (classify_name): Replace "parse_language" with method
2478         call.
2479         * f-exp.y (yylex): Replace "parse_language" with method call.
2480         * d-exp.y (lex_one_token): Replace "parse_language" with method
2481         call.
2482         * c-exp.y:
2483         (lex_one_token, classify_name, yylex): Replace "parse_language"
2484         with method call.
2485         * ada-exp.y (find_primitive_type, type_char)
2486         (type_system_address): Replace "parse_language" with method call.
2487
2488 2019-04-04  Tom Tromey  <tom@tromey.com>
2489
2490         * rust-exp.y: Replace "parse_gdbarch" with method call.
2491         * parse.c (write_dollar_variable, insert_type_address_space):
2492         Replace "parse_gdbarch" with method call.
2493         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2494         call.
2495         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2496         call.
2497         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2498         "parse_gdbarch" with method call.
2499         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2500         with method call.
2501         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2502         "parse_gdbarch" with method call.
2503         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2504         "parse_gdbarch" with method call.
2505         * c-exp.y (parse_type, parse_number, classify_name): Replace
2506         "parse_gdbarch" with method call.
2507         * ada-lex.l: Replace "parse_gdbarch" with method call.
2508         * ada-exp.y (parse_type, find_primitive_type, type_char)
2509         (type_system_address): Replace "parse_gdbarch" with method call.
2510
2511 2019-04-04  Tom Tromey  <tom@tromey.com>
2512
2513         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2514         * stap-probe.c (stap_parse_argument): Update.
2515         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2516         initial_size parameter.
2517         * rust-exp.y (rust_lex_tests): Update.
2518         * parse.c (parser_state): Update.
2519         (parse_exp_in_context): Update.
2520         * parser-defs.h (struct parser_state) <parser_state>: Remove
2521         "initial_size" parameter.
2522
2523 2019-04-04  Tom Tromey  <tom@tromey.com>
2524
2525         * parser-defs.h (increase_expout_size): Don't declare.
2526         * parse.c (increase_expout_size): Now static.
2527
2528 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2529
2530         * gnu-nat.c (gnu_nat_target::wait): Fix
2531         target_waitstatus_to_string call.
2532
2533 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * eval.c (evaluate_subexp_standard): Handle internal functions
2536         during Fortran function call handling.
2537
2538 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2539
2540         * NEWS: Mention new internal functions.
2541         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2542         (read_base_type): Use dwarf2_init_complex_target_type.
2543         * value.c (creal_internal_fn): New function.
2544         (cimag_internal_fn): New function.
2545         (_initialize_values): Register new internal functions.
2546
2547 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2548
2549         * infrun.c (stop_all_threads): If debug_infrun, always
2550         trace the wait status after wait_one, using
2551         target_waitstatus_to_string and target_pid_to_str.
2552         (handle_inferior_event): Replace various trace of
2553         wait status kind by a single trace.
2554         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2555         wait status kind image by target_waitstatus_to_string.
2556         * target/waitstatus.c (target_waitstatus_to_string): Fix
2557         obsolete comment.
2558
2559 2019-04-01  Tom Tromey  <tromey@adacore.com>
2560
2561         PR symtab/23331:
2562         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2563
2564 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2565             Pedro Alves  <palves@redhat.com>
2566
2567         * top.c (quit_force): Call 'finalize_values'.
2568         * value.c (finalize_values): New function.
2569         * value.h (finalize_values): Declare.
2570
2571 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2572
2573         * NEWS: Announce $_gdb_major and $_gdb_minor.
2574
2575         * top.c (init_gdb_version_vars): New function.
2576         (gdb_init): Call init_gdb_version_vars.
2577
2578 2019-03-29  Tom Tromey  <tromey@adacore.com>
2579
2580         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2581         help text.  Remove dead code.
2582
2583 2019-03-29  Keith Seitz  <keiths@redhat.com>
2584
2585         From Siddhesh Poyarekar:
2586         * f-lang.h (f77_get_upperbound): Return LONGEST.
2587         (f77_get_lowerbound): Likewise.
2588         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2589         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2590         print them.
2591         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2592         plongest to format print it.
2593         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2594         (f77_get_upperbound): Likewise.
2595         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2596         LOWER_BOUND to LONGEST.
2597         (f77_create_arrayprint_offset_tbl): Likewise.
2598
2599 2019-03-29  Keith Seitz  <keiths@redhat.com>
2600
2601         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2602         %s/pulongest for TYPE_LENGTH instead of %d in format
2603         strings.
2604         * ada-typerint.c (ada_print_type): Likewise.
2605         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2606         * compile/compile-c-support.c (generate_register_struct): Likewise.
2607         * gdbtypes.c (recursive_dump_type): Likewise.
2608         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2609         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2610         instead of %d in format strings.
2611         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2612         to std::min to ULONGEST.
2613         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2614         instead of %d in format strings.
2615         * tracepoint.c (info_scope_command): Likewise.
2616         * typeprint.c (print_offset_data::update)
2617         (print_offset_data::finish): Likewise.
2618         * xtensa-tdep.c (xtensa_store_return_value)
2619         (xtensa_push_dummy_call): Likewise.
2620
2621 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2622
2623         * windows-nat.c (display_selector): Fixed format specifications
2624         for 64-bit Cygwin.
2625
2626 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2627
2628         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2629
2630 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2631
2632         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2633         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2634         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2635         (nios2_linux_init_abi): Install it.
2636
2637 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2638
2639         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2640
2641 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2642
2643         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2644
2645 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2646             Tom Tromey  <tromey@adacore.com>
2647
2648         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2649
2650 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2651
2652         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2653         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2654         method to compute the bounds of range types. Also print "[evaluated]"
2655         if the bounds' values come from a dynamic evaluation.
2656
2657 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2660         whitespace when pretty printing is on.
2661
2662 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2663
2664         * ppc-linux-nat.c: Add include.
2665
2666 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2667
2668         * NEWS: Mention AArch64 Pointer Authentication.
2669
2670 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2671
2672         * arm-linux-nat.c: Add include.
2673
2674 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2675
2676         * source-cache.c (source_cache::get_source_lines): Re-read
2677         fullname after calling open_source_file.
2678
2679 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2680
2681         * NEWS: Mention TLS support for FreeBSD.
2682
2683 2019-03-25  Tom Tromey  <tromey@adacore.com>
2684
2685         * minsyms.c (BUNCH_SIZE): Update comment.
2686         (~minimal_symbol_reader): Remove old comment.
2687         (compact_minimal_symbols): Update comment.
2688         (minimal_symbol_reader::install): Remove old comment.  Update
2689         other comments.
2690
2691 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2692
2693         * s390-linux-nat.c: Add include.
2694
2695 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2696
2697         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2698         Call linux_get_hwcap.
2699         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2700         Likewise.
2701         (aarch64_linux_get_hwcap): Remove function.
2702         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2703         declaration.
2704         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2705         linux_get_hwcap.
2706         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2707         * linux-tdep.c (linux_get_hwcap): Add function.
2708         (linux_get_hwcap2): Likewise.
2709         * linux-tdep.h (linux_get_hwcap): Add declaration.
2710         (linux_get_hwcap2): Likewise.
2711         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2712         (ppc_linux_get_hwcap2): Likewise.
2713         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2714         linux_get_hwcap.
2715         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2716         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2717         (ppc_linux_nat_target::read_description): Likewise.
2718         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2719         * s390-linux-nat.c: Likewise.
2720         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2721
2722 2019-03-24  Tom Tromey  <tom@tromey.com>
2723
2724         * ada-lang.c (standard_lookup): Simplify initialization.
2725         (ada_lookup_symbol_nonlocal): Simplify return.
2726         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2727         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2728         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2729         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2730         initialization.
2731         * solib.c (solib_global_lookup): Simplify.
2732         * symtab.c (null_block_symbol): Remove.
2733         (symbol_cache_lookup): Simplify returns.
2734         (lookup_language_this): Simplify returns.
2735         (lookup_symbol_aux): Simplify return.
2736         (lookup_local_symbol): Simplify returns.
2737         (lookup_global_symbol_from_objfile): Simplify return.
2738         (lookup_symbol_in_objfile_symtabs)
2739         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2740         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2741         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2742         * cp-namespace.c (cp_lookup_bare_symbol)
2743         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2744         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2745         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2746         (cp_lookup_symbol_via_imports): Simplify initialization.
2747         (find_symbol_in_baseclass): Likewise.
2748         * symtab.h (null_block_symbol): Remove.
2749         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2750         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2751         (d_lookup_symbol_module): Likewise.
2752         (find_symbol_in_baseclass): Simplify initialization.
2753
2754 2019-03-24  Tom Tromey  <tom@tromey.com>
2755
2756         * expression.h: Don't include symtab.h.
2757         (struct block): Forward declare.
2758
2759 2019-03-24  Tom Tromey  <tom@tromey.com>
2760
2761         * c-exp.y (typebase): Remove casts.
2762         * gdbtypes.c (lookup_unsigned_typename, )
2763         (lookup_signed_typename): Remove cast.
2764         * eval.c (parse_to_comma_and_eval): Remove cast.
2765         * parse.c (write_dollar_variable): Remove cast.
2766         * block.h (struct block) <superblock>: Now const.
2767         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2768         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2769         (map_block): Make "block" const.
2770         * symfile.h (struct quick_symbol_functions)
2771         <map_matching_symbols>: Constify block argument to "callback".
2772         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2773         const.
2774         (find_pc_sect_compunit_symtab): Make "b" const.
2775         (find_symbol_at_address): Likewise.
2776         (search_symbols): Likewise.
2777         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2778         (dw2_debug_names_lookup_symbol): Likewise.
2779         (dw2_map_matching_symbols): Update.
2780         * p-valprint.c (pascal_val_print): Remove "block".
2781         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2782         (aux_add_nonlocal_symbols): Make "block" const.
2783         (resolve_subexp): Remove cast.
2784         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2785         const.
2786         (iterate_over_file_blocks): Likewise.
2787         * f-exp.y (%union) <bval>: Remove.
2788         * coffread.c (patch_opaque_types): Make "b" const.
2789         * spu-tdep.c (spu_catch_start): Make "block" const.
2790         * c-valprint.c (print_unpacked_pointer): Remove "block".
2791         * symmisc.c (dump_symtab_1): Make "b" const.
2792         (block_depth): Make "block" const.
2793         * d-exp.y (%union) <bval>: Remove.
2794         * cp-support.h (cp_lookup_rtti_type): Update.
2795         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2796         * psymtab.c (psym_lookup_symbol): Make "block" const.
2797         (maintenance_check_psymtabs): Make "b" const.
2798         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2799         (enumerate_locals, enumerate_args): Update.
2800         * python/py-symtab.c (stpy_global_block): Make "block" const.
2801         (stpy_static_block): Likewise.
2802         * inline-frame.c (block_starting_point_at): Make "new_block"
2803         const.
2804         * block.c (find_block_in_blockvector): Make return type const.
2805         (blockvector_for_pc_sect): Make "b" const.
2806         (find_block_in_blockvector): Make "b" const.
2807
2808 2019-03-23  Tom Tromey  <tom@tromey.com>
2809
2810         * varobj.c (varobj_create): Update.
2811         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2812         * printcmd.c (display_command, do_one_display): Don't reset
2813         innermost_block.
2814         * parser-defs.h (enum innermost_block_tracker_type): Move to
2815         expression.h.
2816         (innermost_block): Update comment.
2817         * parse.c (parse_exp_1): Add tracker_types parameter.
2818         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2819         tracker_types parameter.  Reset innermost_block.
2820         (parse_exp_in_context): Remove.
2821         (parse_expression_for_completion): Update.
2822         * objfiles.c (~objfile): Don't reset expression_context_block or
2823         innermost_block.
2824         * expression.h (enum innermost_block_tracker_type): Move from
2825         parser-defs.h.
2826         (parse_exp_1): Add tracker_types parameter.
2827         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2828         reset innermost_block.
2829
2830 2019-03-23  Tom Tromey  <tom@tromey.com>
2831
2832         * objfiles.h: Include bcache.h.
2833
2834 2019-03-23  Tom Tromey  <tom@tromey.com>
2835
2836         * linespec.c (get_current_search_block): Use
2837         scoped_restore_current_language.
2838         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2839
2840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2841             Jiong Wang  <jiong.wang@arm.com>
2842
2843         * aarch64-linux-tdep.c
2844         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2845         section.
2846         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2847
2848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2849             Jiong Wang  <jiong.wang@arm.com>
2850
2851         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2852         instructions.
2853         (aarch64_analyze_prologue_test): Add PACIASP test.
2854         (aarch64_prologue_prev_register): Unmask PC value.
2855
2856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2857             Jiong Wang  <jiong.wang@arm.com>
2858
2859         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2860         (aarch64_dwarf2_prev_register): Unmask PC value.
2861         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2862         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2863         DW_CFA_AARCH64_negate_ra_state.
2864         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2865
2866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2867             Jiong Wang  <jiong.wang@arm.com>
2868
2869         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2870         registers.
2871         (aarch64_pseudo_register_name): Likewise.
2872         (aarch64_pseudo_register_type): Likewise.
2873         (aarch64_pseudo_register_reggroup_p): Likewise.
2874         (aarch64_gdbarch_init): Add pauth registers.
2875         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2876         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2877         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2878         (struct gdbarch_tdep): Add regnum for ra_state.
2879
2880 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2881             Jiong Wang  <jiong.wang@arm.com>
2882
2883         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2884
2885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2886             Jiong Wang  <jiong.wang@arm.com>
2887
2888         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2889         function.
2890         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2891         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2892         (aarch64_gdbarch_init): Add puth registers.
2893         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2894         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2895         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2896
2897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2898             Jiong Wang  <jiong.wang@arm.com>
2899
2900         * aarch64-linux-nat.c
2901         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2902         * aarch64-linux-tdep.c
2903         (aarch64_linux_core_read_description): Likewise.
2904         (aarch64_linux_get_hwcap): New function.
2905         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2906         (aarch64_linux_get_hwcap): New declaration.
2907
2908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2909             Jiong Wang  <jiong.wang@arm.com>
2910
2911         * aarch64-linux-nat.c
2912         (aarch64_linux_nat_target::read_description): Add pauth param.
2913         * aarch64-linux-tdep.c
2914         (aarch64_linux_core_read_description): Likewise.
2915         * aarch64-tdep.c (struct target_desc): Add in pauth.
2916         (aarch64_read_description): Add pauth param.
2917         (aarch64_gdbarch_init): Likewise.
2918         * aarch64-tdep.h (aarch64_read_description): Likewise.
2919         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2920         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2921         * features/Makefile: Add new files.
2922         * features/aarch64-pauth.c: New file.
2923         * features/aarch64-pauth.xml: New file.
2924
2925 2019-03-20  Tom Tromey  <tromey@adacore.com>
2926
2927         * infrun.c (handle_inferior_event): Rename from
2928         handle_inferior_event_1.  Create a scoped_value_mark.
2929         (handle_inferior_event): Remove.
2930
2931 2019-03-19  Tom Tromey  <tromey@adacore.com>
2932
2933         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2934         * infrun.h (print_stop_event): Add "displays" parameter.
2935         * infrun.c (print_stop_event): Add "displays" parameter.
2936
2937 2019-03-19  Pedro Alves  <palves@redhat.com>
2938
2939         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2940         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2941         to -1.  Fix TABs vs spaces.
2942         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2943         * tui/tui-out.h (tui_ui_out) Add intro comments.
2944         <m_line, m_start_of_line>: In-class initialize, and add describing
2945         comment.
2946
2947 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2948
2949         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2950         variable names.
2951         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2952
2953 2019-03-18  Pedro Alves  <palves@redhat.com>
2954             Eli Zaretskii <eliz@gnu.org>
2955
2956         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2957         m_line and m_start_of_line.
2958
2959 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2960
2961         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2962         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2963         it returns a newline.  This fixes a regression in TU mode, whereby
2964         the next line is output on the same screen line as the user input.
2965
2966 2019-03-18  Tom Tromey  <tromey@adacore.com>
2967
2968         * minsyms.c (minimal_symbol_reader::install): Remove call to
2969         obstack_blank.
2970
2971 2019-03-18  Pedro Alves  <palves@redhat.com>
2972
2973         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2974         New globals.
2975         (apply_style): New, factored out from ...
2976         (apply_ansi_escape): ... this.  Handle reverse video mode.
2977         (tui_set_reverse_mode): New function.
2978         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2979         * tui/tui-winsource.c (tui_show_source_line): Use
2980         tui_set_reverse_mode instead of setting A_STANDOUT.
2981         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2982         New setter methods.
2983
2984 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2985
2986         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2987         Handle tabs.
2988
2989 2019-03-18  Tom Tromey  <tromey@adacore.com>
2990
2991         * ada-lang.c (empty_array): Add "high" parameter.
2992         (ada_evaluate_subexp): Update.
2993
2994 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2995
2996         * unittests/string_view-selftests.c: Define
2997         _initialize_string_view_selftests unconditionally.
2998
2999 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3000
3001         PR gdb/24350
3002         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3003
3004 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3005
3006         PR gdb/24351
3007         * windows-nat.c (display_selector): Fix format specifiers.
3008
3009 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3010
3011         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3012         tui_refill_source_window instead of tui_refresh_win, to update the
3013         current execution line.  This fixes redisplay of the current line
3014         when stepping through the code with "next" or "step".
3015
3016 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3017
3018         * source-cache.c (source_cache::get_source_lines): Call
3019         find_source_lines to initialize s->nlines.  This fixes vertical
3020         scrolling of TUI source window when the DOWN arrow is pressed.
3021
3022 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3023
3024         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3025         linux-thread-db.c (_initialize_thread_db): Likewise.
3026
3027 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3028
3029         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3030         wclrtoeol in tui_show_source_line".  This reverts changes made in
3031         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3032
3033 2019-03-15  Tom Tromey  <tom@tromey.com>
3034
3035         * symtab.h (struct minimal_symbol): Derive from
3036         general_symbol_info.
3037         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3038         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3039         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3040         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3041         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3042         (MSYMBOL_SEARCH_NAME): Update.
3043         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3044         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3045         * minsyms.c (minimal_symbol_reader::record_full): Update.
3046
3047 2019-03-15  Tom Tromey  <tom@tromey.com>
3048
3049         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3050
3051 2019-03-15  Tom Tromey  <tom@tromey.com>
3052
3053         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3054         unique_xmalloc_ptr.
3055         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3056         Update.
3057         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3058         (build_minimal_symbol_hash_tables)
3059         (minimal_symbol_reader::install): Update.
3060
3061 2019-03-15  Tom Tromey  <tom@tromey.com>
3062
3063         * symtab.c (create_demangled_names_hash): Update.
3064         (symbol_set_names): Update.
3065         * objfiles.h (struct objfile_per_bfd_storage)
3066         <demangled_names_hash>: Now an htab_up.
3067         * objfiles.c (objfile_per_bfd_storage): Simplify.
3068
3069 2019-03-15  Tom Tromey  <tom@tromey.com>
3070
3071         * objfiles.h (struct objfile_per_bfd_storage): Declare
3072         destructor.
3073         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3074         New.
3075         (get_objfile_bfd_data): Use new.  Don't initialize
3076         language_of_main.
3077         (free_objfile_per_bfd_storage): Remove.
3078         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3079
3080 2019-03-15  Tom Tromey  <tom@tromey.com>
3081
3082         * symfile.c (reread_symbols): Update.
3083         * objfiles.c (objfile::objfile): Update.
3084         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3085         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3086         comment.
3087         (minimal_symbol_reader::install): Update.
3088         (terminate_minimal_symbol_table): Remove.
3089         * jit.c (jit_object_close_impl): Update.
3090
3091 2019-03-15  Tom Tromey  <tom@tromey.com>
3092
3093         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3094         initializations.
3095
3096 2019-03-15  Tom Tromey  <tom@tromey.com>
3097
3098         * objfiles.h (struct objfile_per_bfd_storage)
3099         <demangled_hash_languages>: Now a bitset.
3100         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3101         (lookup_minimal_symbol): Update.
3102
3103 2019-03-15  Tom Tromey  <tom@tromey.com>
3104
3105         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3106         Don't return the symbol.
3107         * coffread.c (record_minimal_symbol): Use record_full.
3108
3109 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3110
3111         The MS-Windows port of ncurses fails to switch to a color pair if
3112         one or both of the colors are the implicit default colors.  This
3113         change records the default colors when TUI is initialized, and
3114         then specifies them explicitly when a color pair uses the default
3115         colors.  This allows color styling in TUI mode on MS-Windows.
3116
3117         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3118         ncurses_norm_attr.
3119         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3120         colors in ncurses_norm_attr.
3121         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3122         "none", replace it with the default color recorded in
3123         ncurses_norm_attr.
3124
3125 2019-03-14  Tom Tromey  <tromey@adacore.com>
3126
3127         * source-cache.h (class source_cache) <get_source_lines>: Return
3128         std::string.
3129         * source-cache.c (source_cache::extract_lines): Handle case where
3130         first_pos==npos.  Return std::string.
3131         (source_cache::get_source_lines): Update.
3132
3133 2019-03-14  Tom Tromey  <tromey@adacore.com>
3134
3135         * NEWS: Add item for "style sources" commands.
3136         * source-cache.c (source_cache::get_source_lines): Check
3137         source_styling.
3138         * cli/cli-style.c (source_styling): New global.
3139         (_initialize_cli_style): Add "style sources" commands.
3140         (show_style_sources): New function.
3141         * cli/cli-style.h (source_styling): Declare.
3142
3143 2019-03-14  Pedro Alves  <palves@redhat.com>
3144             Tom Tromey  <tromey@adacore.com>
3145
3146         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3147         * tui/tui-winsource.c (tui_refill_source_window): New function,
3148         from...
3149         (tui_horizontal_source_scroll): ... here.  Move some logic.
3150         * cli/cli-style.c (set_style_enabled): Notify new observable.
3151         * tui/tui-hooks.c (tui_redisplay_source): New function.
3152         (tui_attach_detach_observers): Attach or detach
3153         tui_redisplay_source.
3154         * observable.h (source_styling_changed): New observable.
3155         * observable.c: Define source_styling_changed observable.
3156
3157 2019-03-13  Tom Tromey  <tromey@adacore.com>
3158
3159         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3160         (i386_gnu_nat_target::store_registers): Update.
3161         * target-debug.h (target_debug_print_std_string): New macro.
3162         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3163         * windows-tdep.c (display_one_tib): Update.
3164         * tui/tui-stack.c (tui_make_status_line): Update.
3165         * top.c (print_inferior_quit_action): Update.
3166         * thread.c (thr_try_catch_cmd): Update.
3167         (add_thread_with_info): Update.
3168         (thread_target_id_str): Update.
3169         (thr_try_catch_cmd): Update.
3170         (thread_command): Update.
3171         (thread_find_command): Update.
3172         * record-btrace.c (record_btrace_target::info_record)
3173         (record_btrace_resume_thread, record_btrace_target::resume)
3174         (record_btrace_cancel_resume, record_btrace_step_thread)
3175         (record_btrace_target::wait, record_btrace_target::wait)
3176         (record_btrace_target::wait, record_btrace_target::stop): Update.
3177         * progspace.c (print_program_space): Update.
3178         * process-stratum-target.c
3179         (process_stratum_target::thread_address_space): Update.
3180         * linux-fork.c (linux_fork_mourn_inferior)
3181         (detach_checkpoint_command, info_checkpoints_command)
3182         (linux_fork_context): Update.
3183         (linux_fork_detach): Update.
3184         (class scoped_switch_fork_info): Update.
3185         (delete_checkpoint_command): Update.
3186         * infrun.c (follow_fork_inferior): Update.
3187         (follow_fork_inferior): Update.
3188         (proceed_after_vfork_done): Update.
3189         (handle_vfork_child_exec_or_exit): Update.
3190         (follow_exec): Update.
3191         (displaced_step_prepare_throw): Update.
3192         (displaced_step_restore): Update.
3193         (start_step_over): Update.
3194         (resume_1): Update.
3195         (clear_proceed_status_thread): Update.
3196         (proceed): Update.
3197         (print_target_wait_results): Update.
3198         (do_target_wait): Update.
3199         (context_switch): Update.
3200         (stop_all_threads): Update.
3201         (restart_threads): Update.
3202         (finish_step_over): Update.
3203         (handle_signal_stop): Update.
3204         (switch_back_to_stepped_thread): Update.
3205         (keep_going_pass_signal): Update.
3206         (print_exited_reason): Update.
3207         (normal_stop): Update.
3208         * inferior.c (inferior_pid_to_str): Change return type.
3209         (print_selected_inferior): Update.
3210         (add_inferior): Update.
3211         (detach_inferior): Update.
3212         * dummy-frame.c (fprint_dummy_frames): Update.
3213         * dcache.c (dcache_info_1): Update.
3214         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3215         (btrace_fetch, btrace_clear): Update.
3216         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3217         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3218         type.
3219         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3220         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3221         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3222         * gdbarch.c, gdbarch.h: Rebuild.
3223         * gdbarch.sh (core_pid_to_str): Change return type.
3224         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3225         return type.
3226         (windows_nat_target::pid_to_str): Change return type.
3227         (windows_delete_thread): Update.
3228         (windows_nat_target::attach): Update.
3229         (windows_nat_target::files_info): Update.
3230         * target-delegates.c: Rebuild.
3231         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3232         return type.
3233         (sol_thread_target::pid_to_str): Change return type.
3234         * remote.c (class remote_target) <pid_to_str>: Change return
3235         type.
3236         (remote_target::pid_to_str): Change return type.
3237         (extended_remote_target::attach, remote_target::remote_stop_ns)
3238         (remote_target::remote_notif_remove_queued_reply)
3239         (remote_target::push_stop_reply, remote_target::disable_btrace):
3240         Update.
3241         (extended_remote_target::attach): Update.
3242         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3243         type.
3244         (gdbsim_target::pid_to_str): Change return type.
3245         * ravenscar-thread.c (struct ravenscar_thread_target)
3246         <pid_to_str>: Change return type.
3247         (ravenscar_thread_target::pid_to_str): Change return type.
3248         * procfs.c (class procfs_target) <pid_to_str>: Change return
3249         type.
3250         (procfs_target::pid_to_str): Change return type.
3251         (procfs_target::attach): Update.
3252         (procfs_target::detach): Update.
3253         (procfs_target::fetch_registers): Update.
3254         (procfs_target::store_registers): Update.
3255         (procfs_target::wait): Update.
3256         (procfs_target::files_info): Update.
3257         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3258         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3259         return type.
3260         (nto_procfs_target::pid_to_str): Change return type.
3261         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3262         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3263         return type.
3264         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3265         (exit_lwp): Update.
3266         (attach_proc_task_lwp_callback, get_detach_signal)
3267         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3268         (linux_nat_target::resume, wait_lwp, stop_callback)
3269         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3270         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3271         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3272         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3273         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3274         type.
3275         (inf_ptrace_target::attach): Update.
3276         (inf_ptrace_target::files_info): Update.
3277         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3278         type.
3279         (go32_nat_target::pid_to_str): Change return type.
3280         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3281         (gnu_nat_target::wait): Update.
3282         (gnu_nat_target::wait): Update.
3283         (gnu_nat_target::resume): Update.
3284         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3285         (fbsd_nat_target::wait): Update.
3286         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3287         type.
3288         (darwin_nat_target::attach): Update.
3289         * corelow.c (class core_target) <pid_to_str>: Change return type.
3290         (core_target::pid_to_str): Change return type.
3291         * target.c (normal_pid_to_str): Change return type.
3292         (default_pid_to_str): Likewise.
3293         (target_pid_to_str): Change return type.
3294         (target_translate_tls_address): Update.
3295         (target_announce_detach): Update.
3296         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3297         return type.
3298         (bsd_uthread_target::pid_to_str): Change return type.
3299         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3300         type.
3301         (bsd_kvm_target::pid_to_str): Change return type.
3302         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3303         return type.
3304         (aix_thread_target::pid_to_str): Change return type.
3305         * target.h (struct target_ops) <pid_to_str>: Change return type.
3306         (target_pid_to_str, normal_pid_to_str): Likewise.
3307         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3308         type.
3309         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3310         type.
3311         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3312         return type.
3313         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3314         type.
3315         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3316         type.
3317         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3318         return type.
3319
3320 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3321
3322         * NEWS: Mention that the new default MI version is 3.  Mention
3323         changes to the output of commands and events that deal with
3324         multi-location breakpoints.
3325         * breakpoint.c: Include "mi/mi-out.h".
3326         (print_one_breakpoint): Change output syntax if using MI version
3327         >= 3.
3328         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3329         New.
3330         (mi_multi_location_breakpoint_output_fixed): New.
3331         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3332         (mi_cmd_fix_multi_location_breakpoint_output): New.
3333         (mi_multi_location_breakpoint_output_fixed): New.
3334         * mi/mi-cmds.c (mi_cmds): Register command
3335         -fix-multi-location-breakpoint-output.
3336         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3337         interpreter "mi".
3338
3339 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3340
3341         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3342         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3343         instantiate mi_ui_out based on interpreter name.
3344         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3345         * mi/mi-main.c (mi_load_progress): Likewise.
3346
3347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3348
3349         * NEWS: Combine separate "New targets" sections for 8.3.
3350
3351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3352
3353         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3354         (ppcfbsd_init_abi): Install gdbarch
3355         "fetch_tls_load_module_address" and "get_thread_local_address"
3356         methods.
3357
3358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3359
3360         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3361         (riscv_fbsd_init_abi): Install gdbarch
3362         "fetch_tls_load_module_address" and "get_thread_local_address"
3363         methods.
3364
3365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3366
3367         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3368         (i386fbsd_init_abi): Install gdbarch
3369         "fetch_tls_load_module_address" and "get_thread_local_address"
3370         methods.
3371
3372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3373
3374         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3375         (amd64fbsd_init_abi): Install gdbarch
3376         "fetch_tls_load_module_address" and "get_thread_local_address"
3377         methods.
3378
3379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3380
3381         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3382         (struct fbsd_pspace_data): New type.
3383         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3384         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3385         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3386         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3387         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3388
3389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3390
3391         * gdbtypes.c (lookup_struct_elt): New function.
3392         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3393         * gdbtypes.h (struct struct_elt): New type.
3394         (lookup_struct_elt): New prototype.
3395
3396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3397
3398         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3399         remove disabled code block.
3400
3401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3402
3403         * gdbarch.sh (get_thread_local_address): New method.
3404         * gdbarch.h, gdbarch.c: Regenerate.
3405         * target.c (target_translate_tls_address): Use
3406         gdbarch_get_thread_local_address if present instead of
3407         target::get_thread_local_address.
3408
3409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3410
3411         * target.h (target::get_thread_local_address): Update comment.
3412
3413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3414
3415         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3416         objfile->separate_debug_objfile_backlink if not NULL.
3417
3418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3419
3420         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3421         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3422         (amd64bsd_store_inferior_registers): Likewise.
3423         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3424         Enable segment base registers.
3425         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3426         PT_GETFSBASE and PT_GETGSBASE.
3427         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3428         PT_SETGSBASE.
3429         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3430         segment base registers.
3431         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3432
3433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3434
3435         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3436         Update calls to i386_target_description to add 'segments'
3437         parameter.
3438         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3439         add segment base registers.
3440         * arch/i386.c (i386_create_target_description): Add 'segments'
3441         parameter to enable segment base registers.
3442         * arch/i386.h (i386_create_target_description): Likewise.
3443         * features/i386/32bit-segments.xml: New file.
3444         * features/i386/32bit-segments.c: Generate.
3445         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3446         call to i386_target_description to add 'segments' parameter.
3447         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3448         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3449         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3450         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3451         if feature is present.
3452         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3453         Add 'segments' parameter to call to i386_target_description.
3454         (i386_target_description): Add 'segments' parameter to enable
3455         segment base registers.
3456         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3457         to call to i386_target_description.
3458         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3459         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3460         Define I386_NUM_REGS.
3461         (i386_target_description): Add 'segments' parameter to enable
3462         segment base registers.
3463
3464 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3465
3466         PR/24325
3467         * source-cache.c: #undef open and close, to avoid unresolved
3468         externals during linking.
3469
3470 2019-03-12  Tom Tromey  <tromey@adacore.com>
3471
3472         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3473         const.  Add initializers.
3474         (_initialize_remote): Don't initialize ptid globals.
3475
3476 2019-03-12  Pedro Alves  <palves@redhat.com>
3477
3478         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3479
3480 2019-03-12  Pedro Alves  <palves@redhat.com>
3481
3482         * cp-name-parser.y (main): Remove unused 'len' variable.
3483
3484 2019-03-12  Tom Tromey  <tromey@adacore.com>
3485
3486         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3487         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3488
3489 2019-03-12  Tom Tromey  <tromey@adacore.com>
3490
3491         * linux-nat.c (iterate_over_lwps): Update.
3492         (stop_callback): Remove parameter.
3493         (stop_wait_callback, detach_callback, resume_set_callback)
3494         (select_singlestep_lwp_callback, set_ignore_sigint)
3495         (status_callback, resumed_callback, resume_clear_callback)
3496         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3497         data parameter.
3498         (linux_nat_target::detach, linux_nat_target::resume)
3499         (linux_stop_and_wait_all_lwps, select_event_lwp)
3500         (linux_nat_filter_event, linux_nat_wait_1)
3501         (linux_nat_target::kill, linux_nat_target::stop)
3502         (linux_nat_target::stop): Update.
3503         (linux_nat_resume_callback): Change type.
3504         (resume_stopped_resumed_lwps, count_events_callback)
3505         (select_event_lwp_callback): Likewise.
3506         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3507         * arm-linux-nat.c (struct update_registers_data): Remove.
3508         (update_registers_callback): Change type.
3509         (arm_linux_insert_hw_breakpoint1): Update.
3510         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3511         parameter.
3512         (x86_linux_dr_set_addr): Update.
3513         (x86_linux_dr_set_control): Update.
3514         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3515         (iterate_over_lwps): Use gdb::function_view.
3516         * nat/aarch64-linux-hw-point.c (struct
3517         aarch64_dr_update_callback_param): Remove.
3518         (debug_reg_change_callback): Change type.
3519         (aarch64_notify_debug_reg_change): Update.
3520         * s390-linux-nat.c (s390_refresh_per_info): Update.
3521
3522 2019-03-11  Tom Tromey  <tromey@adacore.com>
3523
3524         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3525         redundant assignment to "this_cu".
3526
3527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3528
3529         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3530
3531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3532
3533         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3534         from...
3535         (rank_one_type): ... this.
3536
3537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3538
3539         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3540         from...
3541         (rank_one_type): ... this.
3542
3543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3544
3545         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3546         from...
3547         (rank_one_type): ... this.
3548
3549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3550
3551         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3552         from...
3553         (rank_one_type): ... this.
3554
3555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3556
3557         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3558         from...
3559         (rank_one_type): ... this.
3560
3561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3562
3563         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3564         from...
3565         (rank_one_type): ... this.
3566
3567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3568
3569         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3570         from...
3571         (rank_one_type): ... this.
3572
3573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3574
3575         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3576         from...
3577         (rank_one_type): ... this.
3578
3579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3580
3581         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3582         from...
3583         (rank_one_type): ... this.
3584
3585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3586
3587         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3588         from...
3589         (rank_one_type): ... this.
3590
3591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3592
3593         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3594         from...
3595         (rank_one_type): ... this.
3596
3597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3598
3599         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3600         from...
3601         (rank_one_type): ... this.
3602
3603 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3606         inferior-events' shows the example events.
3607
3608 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3609
3610         Support styling on native MS-Windows console
3611
3612         PR/24315
3613         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3614         on MS-Windows if $TERM is not defined.
3615
3616         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3617
3618         * posix-hdep.c (gdb_console_fputs):
3619         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3620         functions.
3621         * ui-file.h (gdb_console_fputs): Add prototype.
3622
3623         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3624         back to fputs only if the former returns zero.
3625
3626 2019-03-07  Tom Tromey  <tom@tromey.com>
3627
3628         * symmisc.c (print_symbol_bcache_statistics): Update.
3629         (print_objfile_statistics): Update.
3630         * symfile.c (allocate_symtab): Update.
3631         * stabsread.c: Don't include bcache.h.
3632         * psymtab.h (struct psymbol_bcache): Don't declare.
3633         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3634         (psymbol_bcache_init, psymbol_bcache_free)
3635         (psymbol_bcache_get_bcache): Don't declare.
3636         * psymtab.c (struct psymbol_bcache): Remove.
3637         (psymtab_storage::psymtab_storage): Update.
3638         (psymtab_storage::~psymtab_storage): Update.
3639         (psymbol_bcache_init, psymbol_bcache_free)
3640         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3641         (add_psymbol_to_bcache): Update.
3642         (allocate_psymtab): Update.
3643         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3644         macro_cache>: No longer pointers.
3645         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3646         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3647         * macrotab.c (macro_bcache): Update.
3648         * macroexp.c: Don't include bcache.h.
3649         * gdbtypes.c (check_types_worklist): Update.
3650         (types_deeply_equal): Remove TRY/CATCH.  Update.
3651         * elfread.c (elf_symtab_read): Update.
3652         * dwarf2read.c: Don't include bcache.h.
3653         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3654         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3655         (print_bcache_statistics, bcache_memory_used): Don't declare.
3656         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3657         methods.  Rename all data members.
3658         * bcache.c (struct bcache): Move to bcache.h.
3659         (bcache::expand_hash_table): Rename from expand_hash_table.
3660         (bcache): Remove.
3661         (bcache::insert): Rename from bcache_full.
3662         (bcache::compare): Rename from bcache_compare.
3663         (bcache_xmalloc): Remove.
3664         (bcache::~bcache): Rename from bcache_xfree.
3665         (bcache::print_statistics): Rename from print_bcache_statistics.
3666         (bcache::memory_used): Rename from bcache_memory_used.
3667
3668 2019-03-07  Pedro Alves  <palves@redhat.com>
3669
3670         * infrun.c (normal_stop): Also check for
3671         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3672
3673 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3674
3675         * f-lang.c (value_from_host_double): Moved to...
3676         * value.c (value_from_host_double): ...here.
3677         * value.h (value_from_host_double): Declare.
3678         * guile/scm-math.c (vlscm_convert_typed_number): Use
3679         value_from_host_double.
3680         (vlscm_convert_number): Likewise.
3681         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3682         * python/py-value.c (convert_value_from_python): Likewise.
3683
3684 2019-03-06  Tom Tromey  <tom@tromey.com>
3685
3686         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3687
3688 2019-03-06  Tom Tromey  <tom@tromey.com>
3689
3690         * utils.h (free_current_contents): Don't declare.
3691         * utils.c (free_current_contents): Remove.
3692
3693 2019-03-06  Tom Tromey  <tom@tromey.com>
3694
3695         * top.c (quit_force): Update.
3696         * main.c (captured_command_loop): Update.
3697         * common/new-op.c (operator new): Update.
3698         * common/common-exceptions.c (struct catcher)
3699         <save_cleanup_chain>: Remove member.
3700         (exceptions_state_mc_init): Update.
3701         (exception_try_scope_entry): Return nullptr.
3702         (exception_try_scope_exit, exception_rethrow)
3703         (throw_exception_sjlj, throw_exception_cxx): Update.
3704         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3705         (all_cleanups, do_cleanups, discard_cleanups)
3706         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3707         (restore_cleanups, restore_final_cleanups): Don't declare.
3708         (do_final_cleanups): Remove parameter.
3709         * common/cleanups.c (cleanup_chain, make_cleanup)
3710         (make_cleanup_dtor, all_cleanups, do_cleanups)
3711         (discard_my_cleanups, discard_cleanups)
3712         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3713         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3714         (null_cleanup): Remove.
3715         (do_final_cleanups): Remove parameter.
3716
3717 2019-03-06  Tom Tromey  <tom@tromey.com>
3718
3719         * remote.c (remote_target::remote_parse_stop_reply): Use
3720         unique_xmalloc_ptr.
3721
3722 2019-03-06  Tom Tromey  <tom@tromey.com>
3723
3724         * stabsread.c (struct stabs_field_info): Rename from field_info.
3725         <list, fnlist>: Add initializers.
3726         <obstack>: New member.
3727         (read_member_functions, read_struct_fields, read_baseclasses):
3728         Allocate on obstack.  Don't use cleanups.
3729         (read_one_struct_field, read_member_functions, read_struct_fields)
3730         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3731         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3732         (read_struct_type): Update.
3733
3734 2019-03-06  Tom Tromey  <tom@tromey.com>
3735
3736         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3737         * common/filestuff.h (make_cleanup_close): Don't declare.
3738         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3739         Remove.
3740
3741 2019-03-06  Tom Tromey  <tom@tromey.com>
3742
3743         * solib-aix.c: Use make_scope_exit.
3744
3745 2019-03-06  Tom Tromey  <tom@tromey.com>
3746
3747         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3748         Use make_scope_exit.
3749
3750 2019-03-06  Tom Tromey  <tom@tromey.com>
3751
3752         * solib-svr4.c (disable_probes_interface): Remove parameter.
3753         (svr4_handle_solib_event): Use make_scope_exit.
3754
3755 2019-03-06  Tom Tromey  <tom@tromey.com>
3756
3757         * remote.c (struct stop_reply_deleter): Remove.
3758         (stop_reply_up): Update.
3759         (struct stop_reply): Derive from notif_event.  Don't typedef.
3760         <regcache>: Now a std::vector.
3761         (stop_reply_xfree): Remove.
3762         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3763         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3764         (remote_target::discard_pending_stop_replies): Use delete.
3765         (remote_target::remote_parse_stop_reply): Update.
3766         (remote_target::process_stop_reply): Update.
3767         * remote-notif.h (struct notif_event): Add virtual destructor.
3768         Remove "dtr" member.
3769         (struct notif_client) <alloc_event>: Return a unique_ptr.
3770         (notif_event_xfree): Don't declare.
3771         (notif_event_up): New typedef.
3772         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3773         (notif_event_xfree, do_notif_event_xfree): Remove.
3774         (remote_notif_state_xfree): Update.
3775
3776 2019-03-06  Tom Tromey  <tom@tromey.com>
3777
3778         * infrun.c (displaced_step_clear_cleanup): Now a
3779         forward_scope_exit type.
3780         (displaced_step_prepare_throw): Update.
3781         (displaced_step_fixup): Update.
3782
3783 2019-03-06  Tom Tromey  <tom@tromey.com>
3784
3785         * inferior.h (class inferior): Update comment.
3786         * gdbthread.h (class thread_info): Update comment.
3787
3788 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3789             Tom Tromey  <tom@tromey.com>
3790
3791         * stabsread.h (struct stab_section_list): Remove.
3792         (coffstab_build_psymtabs): Update.
3793         * dbxread.c (symbuf_sections): Now a std::vector.
3794         (sect_idx): New global.
3795         (fill_symbuf): Update.
3796         (coffstab_build_psymtabs): Change type of stabsects parameter.
3797         Update.
3798         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3799         std::vector.
3800         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3801         (coff_locate_sections): Update.
3802         (coff_symfile_read): Remove cleanups.  Update.
3803         (init_stringtab): Add storage parameter.
3804         (free_stringtab, free_stringtab_cleanup): Remove.
3805         (init_lineno): Add storage parameter.
3806         (free_linetab, free_linetab_cleanup): Remove.
3807
3808 2019-03-06  Pedro Alves  <palves@redhat.com>
3809
3810         * linux-fork.c (fork_info::clobber_regs): Delete.
3811         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3812         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3813         comment.  Adjust.
3814         (scoped_switch_fork_info::scoped_switch_fork_info)
3815         (checkpoint_command, linux_fork_context): Adjust
3816         fork_save_infrun_state calls.
3817
3818 2019-03-06  Pedro Alves  <palves@redhat.com>
3819
3820         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3821         (inf_has_multiple_threads): Return 'bool' and rewrite using
3822         inferior_info::threads().
3823
3824 2019-03-06  Pedro Alves  <palves@redhat.com>
3825
3826         * linux-fork.c: Include <list>.
3827         (fork_list): Now a std::list instance.
3828         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3829         (forks_exist_p, find_last_fork): Adjust.
3830         (new_fork): Delete.
3831         (one_fork_p): New.
3832         (add_fork): Adjust.
3833         (free_fork): Delete, folded into fork_info::~fork_info().
3834         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3835         Adjust.
3836         (init_fork_list): Delete.
3837         (linux_fork_killall, linux_fork_mourn_inferior)
3838         (linux_fork_detach, info_checkpoints_command): Adjust.
3839         (_initialize_linux_fork): No longer call init_fork_list.
3840
3841 2019-03-06  Pedro Alves  <palves@redhat.com>
3842
3843         * linux-fork.c (new_fork): New, split out of ...
3844         (add_fork): ... this.  Return void.  Move "first fork" special
3845         case from here, to ...
3846         (checkpoint_command): ... here.
3847         * linux-linux.h (add_fork): Return void.
3848
3849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3852
3853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3854             Chris January  <chris.january@arm.com>
3855             David Lecomber  <david.lecomber@arm.com>
3856
3857         * f-exp.y: New token, UNOP_INTRINSIC.
3858         (exp): New pattern using UNOP_INTRINSIC token.
3859         (f77_keywords): Add 'abs' keyword.
3860         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3861         (value_from_host_double): New function.
3862         (evaluate_subexp_f): Support UNOP_ABS.
3863
3864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3867         types.
3868
3869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3872         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3873         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3874
3875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3878
3879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3880             Chris January  <chris.january@arm.com>
3881
3882         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3883         * f-exp.y: Define 'KIND' token.
3884         (exp): New pattern for KIND expressions.
3885         (ptype): Handle types with a kind extension.
3886         (direct_abs_decl): Extend to spot kind extensions.
3887         (f77_keywords): Add 'kind' to the list.
3888         (push_kind_type): New function.
3889         (convert_to_kind_type): New function.
3890         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3891         * parse.c (operator_length_standard): Likewise.
3892         * parser-defs.h (enum type_pieces): Add tp_kind.
3893         * std-operator.def: Add UNOP_KIND.
3894
3895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * f-exp.y (f_parse): Set yydebug.
3898
3899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * f-lang.c (evaluate_subexp_f): New function.
3902         (exp_descriptor_f): New global.
3903         (f_language_defn): Use exp_descriptor_f instead of
3904         exp_descriptor_standard.
3905
3906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * f-exp.y (struct token): Add comments.
3909         (dot_ops): Remove uppercase versions and the end marker.
3910         (f77_keywords): Likewise.
3911         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3912         entries in the dot_ops array are case insensitive, and use
3913         strncasecmp to compare strings.  Also some whitespace cleanup in
3914         this area.  Similar for the f77_keywords array, except entries in
3915         this list might be case sensitive.
3916
3917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * f-exp.y (struct f77_boolean_val): Add comments.
3920         (boolean_values): Remove uppercase versions, and end marker.
3921         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3922         and use strncasecmp to achieve case insensitivity.  Additionally,
3923         perform whitespace cleanup around this code.
3924
3925 2019-03-06  Tom Tromey  <tromey@adacore.com>
3926
3927         * remote-sim.c (gdbsim_target_open): Use result of
3928         gdb_argv::release.
3929
3930 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3931         Dirk Schubert  <dirk.schubert@arm.com>
3932         Chris January  <chris.january@arm.com>
3933
3934         * eval.c (evaluate_subexp_standard): Call Fortran argument
3935         wrapping logic.
3936         * f-lang.c (struct value): A value which can be passed into a
3937         Fortran function call.
3938         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3939         where appropriate.
3940         (struct type): Value ready for a Fortran function call.
3941         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3942         is needed.
3943         * f-lang.h (fortran_argument_convert): Declaration.
3944         (fortran_preserve_arg_pointer): Declaration.
3945         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3946
3947 2019-03-05  Tom Tromey  <tromey@adacore.com>
3948
3949         * python/py-prettyprint.c (print_string_repr): Remove #if.
3950         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3951
3952 2019-03-05  Tom Tromey  <tromey@adacore.com>
3953
3954         * target.c (the_dummy_target): Move later.  Change type to
3955         "dummy_target".
3956         (initialize_targets): Don't initialize the_dummy_target.
3957
3958 2019-03-05  Tom Tromey  <tromey@adacore.com>
3959
3960         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3961         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3962
3963 2019-03-05  Tom Tromey  <tromey@adacore.com>
3964
3965         * windows-nat.c (windows_nat_target::attach)
3966         (windows_nat_target::detach): Don't call gdb_flush.
3967         * valprint.c (generic_val_print, val_print, val_print_string):
3968         Don't call gdb_flush.
3969         * utils.c (defaulted_query): Don't call gdb_flush.
3970         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3971         * target.c (target_announce_detach): Don't call gdb_flush.
3972         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3973         * remote.c (extended_remote_target::attach): Don't call
3974         gdb_flush.
3975         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3976         * printcmd.c (do_examine): Don't call gdb_flush.
3977         (info_display_command): Don't call gdb_flush.
3978         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3979         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3980         * memattr.c (info_mem_command): Don't call gdb_flush.
3981         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3982         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3983         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3984         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3985         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3986         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3987         (gnu_nat_target::detach): Don't call gdb_flush.
3988         * f-valprint.c (f_val_print): Don't call gdb_flush.
3989         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3990         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3991         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3992         gdb_flush.
3993         * c-valprint.c (c_val_print): Don't call gdb_flush.
3994         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3995
3996 2019-03-05  Tom Tromey  <tromey@adacore.com>
3997
3998         * varobj.c (update_dynamic_varobj_children): Update.
3999         (install_default_visualizer): Use reset, not release.
4000         * value.c (set_internalvar): Update.
4001         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4002         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4003         ATTRIBUTE_UNUSED_RESULT.
4004
4005 2019-03-05  Tom Tromey  <tromey@adacore.com>
4006
4007         * remote.c (class scoped_remote_fd) <release>: Add
4008         ATTRIBUTE_UNUSED_RESULT.
4009
4010 2019-03-05  Tom Tromey  <tromey@adacore.com>
4011
4012         * macroexp.c (struct macro_buffer) <release>: Add
4013         ATTRIBUTE_UNUSED_RESULT.
4014
4015 2019-03-05  Tom Tromey  <tromey@adacore.com>
4016
4017         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4018         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4019         ATTRIBUTE_UNUSED_RESULT.
4020
4021 2019-03-05  Tom Tromey  <tromey@adacore.com>
4022
4023         * common/scoped_fd.h (class scoped_fd) <release>: Add
4024         ATTRIBUTE_UNUSED_RESULT.
4025
4026 2019-03-05  Tom Tromey  <tromey@adacore.com>
4027
4028         * parser-defs.h (struct parser_state) <release>: Add
4029         ATTRIBUTE_UNUSED_RESULT.
4030
4031 2019-03-05  Tom Tromey  <tromey@adacore.com>
4032
4033         * utils.h (class gdb_argv) <release>: Add
4034         ATTRIBUTE_UNUSED_RESULT.
4035         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4036
4037 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4038
4039         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4040         for-loop range, to avoid compiler warnings.
4041
4042         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4043         avoid compiler warnings about unused variables.
4044
4045         * NEWS: Mention end of support for native debugging on MS-Windows
4046         before XP.
4047
4048         PR gdb/24292
4049         * common/netstuff.c:
4050         * gdbserver/gdbreplay.c
4051         * gdbserver/remote-utils.c:
4052         * ser-tcp.c:
4053         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4054         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4055         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4056         'getaddrinfo' and 'freeaddrinfo' were not available before
4057         Windows XP, and mingw.org's MinGW headers by default define
4058         _WIN32_WINNT to 0x500.
4059
4060 2019-03-01  Gary Benson <gbenson@redhat.com>
4061
4062         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4063
4064 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4065             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4066
4067         PR gdb/8527
4068         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4069         set_sigint_trap, clear_sigint_trap.
4070
4071 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4072
4073         * target.c (target_detach): Clear the regcache and the
4074         frame cache.
4075
4076 2019-02-27  Pedro Alves  <palves@redhat.com>
4077
4078         * utils.c (set_screen_size): When we cap the height/width sizes,
4079         tweak the corresponding command variable to show "unlimited":
4080
4081 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4082             Pedro Alves  <palves@redhat.com>
4083
4084         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4085         before calling rl_set_screen_size.
4086
4087 2019-02-27  Tom Tromey  <tromey@adacore.com>
4088
4089         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4090         define.
4091         * python/py-value.c: Remove Python 2.4 workaround.
4092         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4093         workaround.
4094         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4095         Python 2.4 workaround.
4096         * python/python-internal.h: Remove Python 2.4 comment.
4097         (Py_ssize_t): Don't define.
4098         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4099         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4100         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4101         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4102         * python/python.c (do_start_initialization): Remove Python 2.4
4103         workaround.
4104         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4105         (print_children): Remove Python 2.4 workaround.
4106         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4107         workaround.
4108         (CHARBUFFERPROC_NAME): Remove.
4109         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4110         Python 2.4 workaround.
4111
4112 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4113
4114         * NEWS: Note minimum Python version.
4115
4116 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4117
4118         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4119         code from these functions.  Remove corresponding ifdefs.  Use
4120         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4121         Remove gotos and target of gotos.
4122         (infpy_search_memory): Likewise.
4123
4124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4125
4126         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4127         (hppa_gdbarch_init): Don't register deleted functions with
4128         gdbarch.
4129
4130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4133         (h8300_unwind_sp): Delete.
4134         (h8300_dummy_id): Delete.
4135         (h8300_gdbarch_init): Don't register deleted functions with
4136         gdbarch.
4137
4138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4141         (ft32_unwind_pc): Delete.
4142         (ft32_unwind_sp): Delete.
4143         (ft32_gdbarch_init): Don't register deleted functions with
4144         gdbarch.
4145
4146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4149         (frv_unwind_pc): Delete.
4150         (frv_unwind_sp): Delete.
4151         (frv_gdbarch_init): Don't register deleted functions with
4152         gdbarch.
4153
4154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4157         (riscv_unwind_pc): Delete.
4158         (riscv_unwind_sp): Delete.
4159         (riscv_gdbarch_init): Don't register deleted functions with
4160         gdbarch.
4161
4162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4165         (csky_unwind_pc): Delete.
4166         (csky_unwind_sp): Delete.
4167         (csky_gdbarch_init): Don't register deleted functions with
4168         gdbarch.
4169
4170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4171
4172         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4173         (cris_unwind_pc): Delete.
4174         (cris_unwind_sp): Delete.
4175         (cris_gdbarch_init): Don't register deleted functions with
4176         gdbarch.
4177
4178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4181         (bfin_unwind_pc): Delete.
4182         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4183
4184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4187         (arm_unwind_pc): Delete.
4188         (arm_unwind_sp): Delete.
4189         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4190
4191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4192
4193         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4194         (arc_unwind_pc): Delete.
4195         (arc_unwind_sp): Delete.
4196         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4197
4198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4201         (alpha_unwind_pc): Delete.
4202         (alpha_gdbarch_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4208         (aarch64_unwind_pc): Delete.
4209         (aarch64_unwind_sp): Delete.
4210         (aarch64_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * gdbtypes.c (type_align): Don't consider static members when
4216         computing structure alignment.
4217
4218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4221         return 0 for other types.
4222         * arch-utils.c (default_type_align): Always return 0.
4223         * gdbarch.h: Regenerate.
4224         * gdbarch.sh (type_align): Extend comment.
4225         * gdbtypes.c (type_align): Add additional comments, always call
4226         gdbarch_type_align before applying the default rules.
4227         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4228         generic code will then apply a suitable default.
4229         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4230         types, return 0 for other types.
4231
4232 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4233
4234         * NEWS: Create a new section for the next release branch.
4235         Rename the section of the current branch, now that it has
4236         been cut.
4237
4238 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4239
4240         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4241         * version.in: Bump version to 8.3.50.DATE-git.
4242
4243 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4244
4245         * aix-thread.c (ptid_cmp): Remove unused variable.
4246         (get_signaled_thread): Likewise.
4247         (store_regs_user_thread): Likewise.
4248         (store_regs_kernel_thread): Likewise.
4249         (fetch_regs_kernel_thread): Remove shadowed variable.
4250
4251 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * features/riscv/32bit-cpu.xml: Add register numbers.
4254         * features/riscv/32bit-fpu.c: Regenerate.
4255         * features/riscv/32bit-fpu.xml: Add register numbers.
4256         * features/riscv/64bit-cpu.xml: Add register numbers.
4257         * features/riscv/64bit-fpu.c: Regenerate.
4258         * features/riscv/64bit-fpu.xml: Add register numbers.
4259
4260 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4261
4262         * NEWS: Mention two argument form of gdb.Value constructor.
4263         * python/py-value.c (convert_buffer_and_type_to_value): New
4264         function.
4265         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4266         Add support for handling an optional second argument.  Call
4267         convert_buffer_and_type_to_value as appropriate.
4268         * python/python-internal.h (Py_buffer_deleter): New struct.
4269         (Py_buffer_up): New typedef.
4270
4271 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4272
4273         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4274         instead of releasing ownership.
4275
4276 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4277
4278         * dwarf2read.c (open_and_init_dwp_file): Call
4279         elf_numsections instead of bfd_count_sections to initialize
4280         dwp_file->num_sections.
4281
4282 2019-02-25  Tom Tromey  <tromey@adacore.com>
4283
4284         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4285
4286 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4287
4288         * gcore.in: Add '--readnever' option when invoking GDB.
4289
4290 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4291
4292         * MAINTAINERS: Update my email address.
4293
4294 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4295
4296         * build-id.c (build_id_to_debug_bfd_1): New function.
4297         (build_id_to_debug_bfd): Look for separate debug file in
4298         sysroot.
4299
4300 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * gdbarch.sh: Update the copyright year range that is placed into
4303         generated files.
4304
4305 2019-02-22  Keith Seitz  <keiths@redhat.com>
4306
4307         PR symtab/23853
4308         * linespec.c (create_sals_line_offset): Search for the default
4309         symtab's filename instead of its fullname.
4310
4311 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4312
4313         * NEWS: Update style defaults.
4314
4315 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4316
4317         * main.c (captured_main_1): Disable styling in batch mode.
4318
4319 2019-02-20  Tom Tromey  <tom@tromey.com>
4320
4321         * symtab.c (symtab_symbol_info): Fix typos.
4322
4323 2019-02-20  Tom Tromey  <tromey@adacore.com>
4324
4325         * findcmd.c (_initialize_mem_search): Use upper case for
4326         metasyntactic variables.
4327
4328 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4329
4330         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4331         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4332
4333 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4334
4335         * top.h (source_file_name): Change to std::string.
4336         * top.c (source_file_name): Likewise.
4337         (command_line_input): Adjust.
4338         * cli/cli-script.c (script_from_file): Adjust.
4339
4340 2019-02-19  Tom Tromey  <tromey@adacore.com>
4341
4342         * ravenscar-thread.c
4343         (ravenscar_thread_target::update_thread_list): Don't call
4344         ada_build_task_list.
4345         * ada-lang.h (ada_build_task_list): Don't declare.
4346         * ada-tasks.c (struct ada_tasks_inferior_data)
4347         <task_list_valid_p>: Now bool.
4348         (read_known_tasks, ada_task_list_changed)
4349         (ada_tasks_invalidate_inferior_data): Update.
4350         (read_known_tasks_array): Return bool.
4351         (read_known_tasks_list): Likewise.
4352         (read_known_tasks): Return void.
4353         (ada_build_task_list): Now static.
4354
4355 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4358         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4359
4360 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4361
4362         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4363         variant for ada_tasks_pspace_data_handle and
4364         ada_tasks_inferior_data_handle.
4365         (ada_tasks_pspace_data_cleanup): New function.
4366         (ada_tasks_inferior_data_cleanup): New function.
4367
4368 2019-02-17  Tom Tromey  <tom@tromey.com>
4369
4370         * macrotab.h (macro_source_fullname): Return a std::string.
4371         * macrotab.c (macro_include, check_for_redefinition)
4372         (macro_undef, macro_lookup_definition, foreach_macro)
4373         (foreach_macro_in_scope): Update.
4374         (macro_source_fullname): Return a std::string.
4375         * macrocmd.c (show_pp_source_pos): Update.
4376
4377 2019-02-17  Tom Tromey  <tom@tromey.com>
4378
4379         * macrocmd.c (show_pp_source_pos): Style the file names.
4380
4381 2019-02-17  Tom Tromey  <tom@tromey.com>
4382
4383         PR tui/24197:
4384         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4385
4386 2019-02-17  Tom Tromey  <tom@tromey.com>
4387
4388         * ada-lang.c (user_select_syms): Use filtered printing.
4389         * utils.c (wrap_style): New global.
4390         (desired_style): Remove.
4391         (emit_style_escape): Add stream parameter.
4392         (set_output_style, reset_terminal_style, prompt_for_continue):
4393         Update.
4394         (flush_wrap_buffer): Only flush gdb_stdout.
4395         (wrap_here): Set wrap_style.
4396         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4397         treat escape sequences as a character.  Change when wrap buffer is
4398         flushed.
4399         (fputs_styled): Do not set the output style when the default is
4400         requested.
4401         * ui-style.h (struct ui_file_style) <is_default>: New method.
4402         * source.c (print_source_lines_base): Emit escape sequences in one
4403         piece.
4404
4405 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4406
4407         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4408         integers and enumeration types.
4409
4410 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4411
4412         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4413         instead of lookup_symbol_in_language
4414         (do_exact_match): New function.
4415         (ada_get_symbol_name_matcher): Return do_exact_match when
4416         doing a verbatim match.
4417
4418 2019-02-15  Tom Tromey  <tromey@adacore.com>
4419
4420         * ravenscar-thread.c (ravenscar_thread_target::resume)
4421         (ravenscar_thread_target::wait): Special case wildcard requests.
4422
4423 2019-02-15  Tom Tromey  <tromey@adacore.com>
4424
4425         * ravenscar-thread.c (base_ptid): Remove.
4426         (struct ravenscar_thread_target) <close>: New method.
4427         <m_base_ptid>: New member.
4428         <update_inferior_ptid, active_task, task_is_currently_active,
4429         runtime_initialized>: Declare methods.
4430         <ravenscar_thread_target>: Add constructor.
4431         (ravenscar_thread_target::task_is_currently_active)
4432         (ravenscar_thread_target::update_inferior_ptid)
4433         (ravenscar_runtime_initialized): Rename.  Now methods.
4434         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4435         (ravenscar_thread_target::update_thread_list): Update.
4436         (ravenscar_thread_target::active_task): Now method.
4437         (ravenscar_thread_target::store_registers)
4438         (ravenscar_thread_target::prepare_to_store)
4439         (ravenscar_thread_target::prepare_to_store)
4440         (ravenscar_thread_target::mourn_inferior): Update.
4441         (ravenscar_inferior_created): Use "new" to create target.
4442         (ravenscar_thread_target::get_ada_task_ptid): Update.
4443         (_initialize_ravenscar): Don't initialize base_ptid.
4444         (ravenscar_ops): Remove global.
4445
4446 2019-02-15  Tom Tromey  <tromey@adacore.com>
4447
4448         * target.h (push_target): Declare new overload.
4449         * target.c (push_target): New overload, taking an rvalue reference.
4450         * remote.c (remote_target::open_1): Use push_target overload.
4451         * corelow.c (core_target_open): Use push_target overload.
4452
4453 2019-02-15  Tom Tromey  <tromey@adacore.com>
4454
4455         * ravenscar-thread.c (is_ravenscar_task)
4456         (ravenscar_task_is_currently_active): Return bool.
4457         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4458         (_initialize_ravenscar): Remove "(void)".
4459         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4460         Return bool.
4461
4462 2019-02-15  Tom Tromey  <tromey@adacore.com>
4463
4464         * ravenscar-thread.c (ravenscar_runtime_initializer)
4465         (has_ravenscar_runtime, get_running_thread_id)
4466         (ravenscar_thread_target::resume): Fix indentation.
4467
4468 2019-02-15  Tom Tromey  <tromey@adacore.com>
4469
4470         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4471         from ravenscar_arch_ops.
4472         (sparc_ravenscar_ops::fetch_registers)
4473         (sparc_ravenscar_ops::store_registers): Now methods.
4474         (sparc_ravenscar_prepare_to_store): Remove.
4475         (sparc_ravenscar_ops): Redefine.
4476         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4477         methods and destructor.  Remove members.
4478         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4479         (ravenscar_thread_target::store_registers)
4480         (ravenscar_thread_target::prepare_to_store): Update.
4481         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4482         Remove.
4483         (struct ppc_ravenscar_powerpc_ops): Derive from
4484         ravenscar_arch_ops.
4485         (ppc_ravenscar_powerpc_ops::fetch_registers)
4486         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4487         (ppc_ravenscar_powerpc_ops): Redefine.
4488         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4489         (ppc_ravenscar_e500_ops::fetch_registers)
4490         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4491         (ppc_ravenscar_e500_ops): Redefine.
4492         * aarch64-ravenscar-thread.c
4493         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4494         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4495         (aarch64_ravenscar_fetch_registers)
4496         (aarch64_ravenscar_store_registers): Now methods.
4497         (aarch64_ravenscar_ops): Redefine.
4498
4499 2019-02-15  Tom Tromey  <tromey@adacore.com>
4500
4501         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4502         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4503         (ravenscar_thread_target::stopped_by_watchpoint)
4504         (ravenscar_thread_target::stopped_data_address)
4505         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4506
4507 2019-02-15  Tom Tromey  <tromey@adacore.com>
4508
4509         * ravenscar-thread.c: Fix some typos.
4510
4511 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4512             Tom Tromey  <tromey@adacore.com>
4513
4514         * ada-lang.c (ada_exception_sal): Change addr_string to a
4515         std::string.
4516         (create_ada_exception_catchpoint): Update.
4517
4518 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4519             Tom Tromey  <tromey@adacore.com>
4520
4521         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4522         (bp_location_ops): Remove.
4523         (base_breakpoint_allocate_location): Update.
4524         (free_bp_location): Update.
4525         * ada-lang.c (class ada_catchpoint_location)
4526         <ada_catchpoint_location>: Remove ops parameter.
4527         (ada_catchpoint_location_dtor): Remove.
4528         (ada_catchpoint_location_ops): Remove.
4529         (allocate_location_exception): Update.
4530         * breakpoint.h (struct bp_location_ops): Remove.
4531         (class bp_location) <bp_location>: Remove bp_location_ops
4532         parameter.
4533         <~bp_location>: Add destructor.
4534         <ops>: Remove.
4535
4536 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4537             Pedro Alves  <palves@redhat.com>
4538
4539         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4540         'PATH_MAX'.
4541
4542 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4543             Samuel Thibault  <samuel.thibault@gnu.org>
4544             Thomas Schwinge  <thomas@codesourcery.com>
4545
4546         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4547         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4548
4549 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4550
4551         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4552         (check_empty): Use "const char *".
4553
4554         * gnu-nat.c (gnu_nat_target::detach): Instead of
4555         'detach_inferior (pid)' call
4556         'detach_inferior (find_inferior_pid (pid))'.
4557
4558         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4559         'nat/fork-inferior.o'.
4560         * gnu-nat.c: #include "nat/fork-inferior.h".
4561
4562         * gnu-nat.c (gnu_nat_target::detach): Instead of
4563         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4564         * gnu-nat.h: #include "inf-child.h".
4565         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4566         'i386_gnu_nat_target::fetch_registers'.
4567         (gnu_store_registers): Rename/move to
4568         'i386_gnu_nat_target::store_registers'.
4569
4570         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4571         * gnu-nat.h (mach_thread_info): New function.
4572         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4573
4574         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4575
4576 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4577
4578         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4579
4580 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4581
4582         * windows-nat.c (windows_add_thread): Add new parameter
4583         "main_thread_p" with default value set to false.  Update
4584         function documentation as well as all callers.
4585         (windows_delete_thread): Likewise.
4586         (fake_create_process): Update call to windows_add_thread.
4587         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4588         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4589         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4590         call to windows_delete_thread.
4591
4592 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4593
4594         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4595
4596 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4597
4598         * symfile.c (find_separate_debug_file): Use canonical path of
4599         sysroot with child_path instead of gdb_sysroot if it is valid.
4600
4601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4602
4603         * symfile.c (find_separate_debug_file): Use child_path to
4604         determine if an object file is under a sysroot.
4605
4606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4607
4608         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4609         unittests/child-path-selftests.c.
4610         * common/pathstuff.c (child_path): New function.
4611         * common/pathstuff.h (child_path): New prototype.
4612         * unittests/child-path-selftests.c: New file.
4613
4614 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4615
4616         * symfile.c (find_separate_debug_file): Look for separate debug
4617         files in debug directories under the sysroot.
4618
4619 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4620
4621         * symtab.h (struct minimal_symbol data_p): New const method.
4622         (struct minimal_symbol text_p): Likewise.
4623         * symtab.c (output_source_filename): Use file name style
4624         to print file name.
4625         (print_symbol_info): Likewise.
4626         (print_msymbol_info): Use address style to print addresses.
4627         Use function name style to print executable text symbols.
4628         (expand_symtab_containing_pc): Use data_p.
4629         (find_pc_sect_compunit_symtab): Likewise.
4630
4631 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4632
4633         * breakpoint.c (describe_other_breakpoints): Use address style
4634         to print addresses.
4635         (say_where): Likewise.
4636
4637 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4638
4639         * ada-typeprint.c (print_func_type): Print function name
4640         style to print function name.
4641         * c-typeprint.c (c_print_type_1): Likewise.
4642
4643 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4644
4645         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4646         for execve.
4647
4648 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649
4650         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4651         type_stack.
4652
4653 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4654
4655         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4656         TYPE_CODE_REF types.
4657
4658 2019-02-08  Jim Wilson  <jimw@sifive.com>
4659
4660         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4661         (riscv_linux_fregset): New.
4662         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4663
4664 2019-02-07  Tom Tromey  <tom@tromey.com>
4665
4666         * thread.c (thread_cancel_execution_command): Update.
4667         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4668         methods.
4669         (struct thread_fsm_ops): Remove.
4670         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4671         (thread_fsm_should_stop, thread_fsm_return_value)
4672         (thread_fsm_set_finished, thread_fsm_finished_p)
4673         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4674         Don't declare.
4675         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4676         * infrun.c (clear_proceed_status_thread)
4677         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4678         (print_stop_event): Update.
4679         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4680         Add constructor.
4681         (step_command_fsm_ops): Remove.
4682         (new_step_command_fsm): Remove.
4683         (step_1): Update.
4684         (step_command_fsm::should_stop): Rename from
4685         step_command_fsm_should_stop.
4686         (step_command_fsm::clean_up): Rename from
4687         step_command_fsm_clean_up.
4688         (step_command_fsm::do_async_reply_reason): Rename from
4689         step_command_fsm_async_reply_reason.
4690         (struct until_next_fsm): Inherit from thread_fsm.  Add
4691         constructor.
4692         (until_next_fsm_ops): Remove.
4693         (new_until_next_fsm): Remove.
4694         (until_next_fsm::should_stop): Rename from
4695         until_next_fsm_should_stop.
4696         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4697         (until_next_fsm::do_async_reply_reason): Rename from
4698         until_next_fsm_async_reply_reason.
4699         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4700         constructor.  Change type of breakpoint.
4701         (finish_command_fsm_ops): Remove.
4702         (new_finish_command_fsm): Remove.
4703         (finish_command_fsm::should_stop): Rename from
4704         finish_command_fsm_should_stop.
4705         (finish_command_fsm::clean_up): Rename from
4706         finish_command_fsm_clean_up.
4707         (finish_command_fsm::return_value): Rename from
4708         finish_command_fsm_return_value.
4709         (finish_command_fsm::do_async_reply_reason): Rename from
4710         finish_command_fsm_async_reply_reason.
4711         (finish_command): Update.
4712         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4713         Add constructor.
4714         (call_thread_fsm_ops): Remove.
4715         (call_thread_fsm::call_thread_fsm): Rename from
4716         new_call_thread_fsm.
4717         (call_thread_fsm::should_stop): Rename from
4718         call_thread_fsm_should_stop.
4719         (call_thread_fsm::should_notify_stop): Rename from
4720         call_thread_fsm_should_notify_stop.
4721         (run_inferior_call, call_function_by_hand_dummy): Update.
4722         * cli/cli-interp.c (should_print_stop_to_console): Update.
4723         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4724         Add constructor.  Change type of location_breakpoint,
4725         caller_breakpoint.
4726         (until_break_fsm_ops): Remove.
4727         (new_until_break_fsm): Remove.
4728         (until_break_fsm::should_stop): Rename from
4729         until_break_fsm_should_stop.
4730         (until_break_fsm::clean_up): Rename from
4731         until_break_fsm_clean_up.
4732         (until_break_fsm::do_async_reply_reason): Rename from
4733         until_break_fsm_async_reply_reason.
4734         (until_break_command): Update.
4735         * thread-fsm.c: Remove.
4736         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4737
4738 2019-02-07  Tom Tromey  <tom@tromey.com>
4739
4740         * yy-remap.h: Add include guard.
4741         * xtensa-tdep.h: Add include guard.
4742         * xcoffread.h: Rename include guard.
4743         * varobj-iter.h: Add include guard.
4744         * tui/tui.h: Rename include guard.
4745         * tui/tui-winsource.h: Rename include guard.
4746         * tui/tui-wingeneral.h: Rename include guard.
4747         * tui/tui-windata.h: Rename include guard.
4748         * tui/tui-win.h: Rename include guard.
4749         * tui/tui-stack.h: Rename include guard.
4750         * tui/tui-source.h: Rename include guard.
4751         * tui/tui-regs.h: Rename include guard.
4752         * tui/tui-out.h: Rename include guard.
4753         * tui/tui-layout.h: Rename include guard.
4754         * tui/tui-io.h: Rename include guard.
4755         * tui/tui-hooks.h: Rename include guard.
4756         * tui/tui-file.h: Rename include guard.
4757         * tui/tui-disasm.h: Rename include guard.
4758         * tui/tui-data.h: Rename include guard.
4759         * tui/tui-command.h: Rename include guard.
4760         * tic6x-tdep.h: Add include guard.
4761         * target/waitstatus.h: Rename include guard.
4762         * target/wait.h: Rename include guard.
4763         * target/target.h: Rename include guard.
4764         * target/resume.h: Rename include guard.
4765         * target-float.h: Rename include guard.
4766         * stabsread.h: Add include guard.
4767         * rs6000-tdep.h: Add include guard.
4768         * riscv-fbsd-tdep.h: Add include guard.
4769         * regformats/regdef.h: Rename include guard.
4770         * record.h: Rename include guard.
4771         * python/python.h: Rename include guard.
4772         * python/python-internal.h: Rename include guard.
4773         * python/py-stopevent.h: Rename include guard.
4774         * python/py-ref.h: Rename include guard.
4775         * python/py-record.h: Rename include guard.
4776         * python/py-record-full.h: Rename include guard.
4777         * python/py-record-btrace.h: Rename include guard.
4778         * python/py-instruction.h: Rename include guard.
4779         * python/py-events.h: Rename include guard.
4780         * python/py-event.h: Rename include guard.
4781         * procfs.h: Add include guard.
4782         * proc-utils.h: Add include guard.
4783         * p-lang.h: Add include guard.
4784         * or1k-tdep.h: Rename include guard.
4785         * observable.h: Rename include guard.
4786         * nto-tdep.h: Rename include guard.
4787         * nat/x86-linux.h: Rename include guard.
4788         * nat/x86-linux-dregs.h: Rename include guard.
4789         * nat/x86-gcc-cpuid.h: Add include guard.
4790         * nat/x86-dregs.h: Rename include guard.
4791         * nat/x86-cpuid.h: Rename include guard.
4792         * nat/ppc-linux.h: Rename include guard.
4793         * nat/mips-linux-watch.h: Rename include guard.
4794         * nat/linux-waitpid.h: Rename include guard.
4795         * nat/linux-ptrace.h: Rename include guard.
4796         * nat/linux-procfs.h: Rename include guard.
4797         * nat/linux-osdata.h: Rename include guard.
4798         * nat/linux-nat.h: Rename include guard.
4799         * nat/linux-namespaces.h: Rename include guard.
4800         * nat/linux-btrace.h: Rename include guard.
4801         * nat/glibc_thread_db.h: Rename include guard.
4802         * nat/gdb_thread_db.h: Rename include guard.
4803         * nat/gdb_ptrace.h: Rename include guard.
4804         * nat/fork-inferior.h: Rename include guard.
4805         * nat/amd64-linux-siginfo.h: Rename include guard.
4806         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4807         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4808         * nat/aarch64-linux.h: Rename include guard.
4809         * nat/aarch64-linux-hw-point.h: Rename include guard.
4810         * mn10300-tdep.h: Add include guard.
4811         * mips-linux-tdep.h: Add include guard.
4812         * mi/mi-parse.h: Rename include guard.
4813         * mi/mi-out.h: Rename include guard.
4814         * mi/mi-main.h: Rename include guard.
4815         * mi/mi-interp.h: Rename include guard.
4816         * mi/mi-getopt.h: Rename include guard.
4817         * mi/mi-console.h: Rename include guard.
4818         * mi/mi-common.h: Rename include guard.
4819         * mi/mi-cmds.h: Rename include guard.
4820         * mi/mi-cmd-break.h: Rename include guard.
4821         * m2-lang.h: Add include guard.
4822         * location.h: Rename include guard.
4823         * linux-record.h: Rename include guard.
4824         * linux-nat.h: Add include guard.
4825         * linux-fork.h: Add include guard.
4826         * i386-darwin-tdep.h: Rename include guard.
4827         * hppa-linux-offsets.h: Add include guard.
4828         * guile/guile.h: Rename include guard.
4829         * guile/guile-internal.h: Rename include guard.
4830         * gnu-nat.h: Rename include guard.
4831         * gdb-stabs.h: Rename include guard.
4832         * frv-tdep.h: Add include guard.
4833         * f-lang.h: Add include guard.
4834         * event-loop.h: Add include guard.
4835         * darwin-nat.h: Rename include guard.
4836         * cp-abi.h: Rename include guard.
4837         * config/sparc/nm-sol2.h: Rename include guard.
4838         * config/nm-nto.h: Rename include guard.
4839         * config/nm-linux.h: Add include guard.
4840         * config/i386/nm-i386gnu.h: Rename include guard.
4841         * config/djgpp/nl_types.h: Rename include guard.
4842         * config/djgpp/langinfo.h: Rename include guard.
4843         * compile/gcc-cp-plugin.h: Add include guard.
4844         * compile/gcc-c-plugin.h: Add include guard.
4845         * compile/compile.h: Rename include guard.
4846         * compile/compile-object-run.h: Rename include guard.
4847         * compile/compile-object-load.h: Rename include guard.
4848         * compile/compile-internal.h: Rename include guard.
4849         * compile/compile-cplus.h: Rename include guard.
4850         * compile/compile-c.h: Rename include guard.
4851         * common/xml-utils.h: Rename include guard.
4852         * common/x86-xstate.h: Rename include guard.
4853         * common/version.h: Rename include guard.
4854         * common/vec.h: Rename include guard.
4855         * common/tdesc.h: Rename include guard.
4856         * common/selftest.h: Rename include guard.
4857         * common/scoped_restore.h: Rename include guard.
4858         * common/scoped_mmap.h: Rename include guard.
4859         * common/scoped_fd.h: Rename include guard.
4860         * common/safe-iterator.h: Rename include guard.
4861         * common/run-time-clock.h: Rename include guard.
4862         * common/refcounted-object.h: Rename include guard.
4863         * common/queue.h: Rename include guard.
4864         * common/ptid.h: Rename include guard.
4865         * common/print-utils.h: Rename include guard.
4866         * common/preprocessor.h: Rename include guard.
4867         * common/pathstuff.h: Rename include guard.
4868         * common/observable.h: Rename include guard.
4869         * common/netstuff.h: Rename include guard.
4870         * common/job-control.h: Rename include guard.
4871         * common/host-defs.h: Rename include guard.
4872         * common/gdb_wait.h: Rename include guard.
4873         * common/gdb_vecs.h: Rename include guard.
4874         * common/gdb_unlinker.h: Rename include guard.
4875         * common/gdb_unique_ptr.h: Rename include guard.
4876         * common/gdb_tilde_expand.h: Rename include guard.
4877         * common/gdb_sys_time.h: Rename include guard.
4878         * common/gdb_string_view.h: Rename include guard.
4879         * common/gdb_splay_tree.h: Rename include guard.
4880         * common/gdb_setjmp.h: Rename include guard.
4881         * common/gdb_ref_ptr.h: Rename include guard.
4882         * common/gdb_optional.h: Rename include guard.
4883         * common/gdb_locale.h: Rename include guard.
4884         * common/gdb_assert.h: Rename include guard.
4885         * common/filtered-iterator.h: Rename include guard.
4886         * common/filestuff.h: Rename include guard.
4887         * common/fileio.h: Rename include guard.
4888         * common/environ.h: Rename include guard.
4889         * common/common-utils.h: Rename include guard.
4890         * common/common-types.h: Rename include guard.
4891         * common/common-regcache.h: Rename include guard.
4892         * common/common-inferior.h: Rename include guard.
4893         * common/common-gdbthread.h: Rename include guard.
4894         * common/common-exceptions.h: Rename include guard.
4895         * common/common-defs.h: Rename include guard.
4896         * common/common-debug.h: Rename include guard.
4897         * common/cleanups.h: Rename include guard.
4898         * common/buffer.h: Rename include guard.
4899         * common/btrace-common.h: Rename include guard.
4900         * common/break-common.h: Rename include guard.
4901         * cli/cli-utils.h: Rename include guard.
4902         * cli/cli-style.h: Rename include guard.
4903         * cli/cli-setshow.h: Rename include guard.
4904         * cli/cli-script.h: Rename include guard.
4905         * cli/cli-interp.h: Rename include guard.
4906         * cli/cli-decode.h: Rename include guard.
4907         * cli/cli-cmds.h: Rename include guard.
4908         * charset-list.h: Add include guard.
4909         * buildsym-legacy.h: Rename include guard.
4910         * bfin-tdep.h: Add include guard.
4911         * ax.h: Rename include guard.
4912         * arm-linux-tdep.h: Add include guard.
4913         * arm-fbsd-tdep.h: Add include guard.
4914         * arch/xtensa.h: Rename include guard.
4915         * arch/tic6x.h: Add include guard.
4916         * arch/i386.h: Add include guard.
4917         * arch/arm.h: Rename include guard.
4918         * arch/arm-linux.h: Rename include guard.
4919         * arch/arm-get-next-pcs.h: Rename include guard.
4920         * arch/amd64.h: Add include guard.
4921         * arch/aarch64-insn.h: Rename include guard.
4922         * arch-utils.h: Rename include guard.
4923         * annotate.h: Add include guard.
4924         * amd64-darwin-tdep.h: Rename include guard.
4925         * aarch64-linux-tdep.h: Add include guard.
4926         * aarch64-fbsd-tdep.h: Add include guard.
4927         * aarch32-linux-nat.h: Add include guard.
4928
4929 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4930
4931         * macrotab.c (macro_define_internal): New function that
4932         factorizes macro_define_object_internal and macro_define_function
4933         code.
4934         (macro_define_object_internal): Use macro_define_internal.
4935         (macro_define_function): Likewise.
4936
4937 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4938
4939         * macrocmd.c (extract_identifier): Return
4940         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4941         callers.
4942
4943 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4944
4945         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4946
4947 2019-02-05  Tom Tromey  <tom@tromey.com>
4948
4949         * target.c (target_stack::unpush): Move assertion earlier.
4950
4951 2019-01-30  Tom Tromey  <tom@tromey.com>
4952
4953         PR python/23615:
4954         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4955         (gdbpy_parse_and_eval): Likewise.
4956         * python/python-internal.h (gdbpy_allow_threads): New class.
4957
4958 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4959
4960         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4961         (aarch64_fbsd_fpregmap): Move earlier.
4962         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4963         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4964         instead of individual calls to trad_frame_set_reg_addr.
4965         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4966         earlier.
4967         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4968         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4969         instead of individual calls to trad_frame_set_reg_addr.
4970
4971 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4972
4973         * CONTRIBUTE: Replace contribution list with wiki link.
4974
4975 2019-01-25  Tom Tromey  <tom@tromey.com>
4976
4977         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4978
4979 2019-01-25  Tom Tromey  <tom@tromey.com>
4980
4981         * xtensa-linux-nat.c: Fix common/ includes.
4982         * xml-support.h: Fix common/ includes.
4983         * xml-support.c: Fix common/ includes.
4984         * x86-linux-nat.c: Fix common/ includes.
4985         * windows-nat.c: Fix common/ includes.
4986         * varobj.h: Fix common/ includes.
4987         * varobj.c: Fix common/ includes.
4988         * value.c: Fix common/ includes.
4989         * valops.c: Fix common/ includes.
4990         * utils.c: Fix common/ includes.
4991         * unittests/xml-utils-selftests.c: Fix common/ includes.
4992         * unittests/utils-selftests.c: Fix common/ includes.
4993         * unittests/unpack-selftests.c: Fix common/ includes.
4994         * unittests/tracepoint-selftests.c: Fix common/ includes.
4995         * unittests/style-selftests.c: Fix common/ includes.
4996         * unittests/string_view-selftests.c: Fix common/ includes.
4997         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4998         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4999         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5000         * unittests/rsp-low-selftests.c: Fix common/ includes.
5001         * unittests/parse-connection-spec-selftests.c: Fix common/
5002         includes.
5003         * unittests/optional-selftests.c: Fix common/ includes.
5004         * unittests/offset-type-selftests.c: Fix common/ includes.
5005         * unittests/observable-selftests.c: Fix common/ includes.
5006         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5007         * unittests/memrange-selftests.c: Fix common/ includes.
5008         * unittests/memory-map-selftests.c: Fix common/ includes.
5009         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5010         * unittests/function-view-selftests.c: Fix common/ includes.
5011         * unittests/environ-selftests.c: Fix common/ includes.
5012         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5013         * unittests/common-utils-selftests.c: Fix common/ includes.
5014         * unittests/cli-utils-selftests.c: Fix common/ includes.
5015         * unittests/array-view-selftests.c: Fix common/ includes.
5016         * ui-file.c: Fix common/ includes.
5017         * tui/tui-io.c: Fix common/ includes.
5018         * tracepoint.h: Fix common/ includes.
5019         * tracepoint.c: Fix common/ includes.
5020         * tracefile-tfile.c: Fix common/ includes.
5021         * top.h: Fix common/ includes.
5022         * top.c: Fix common/ includes.
5023         * thread.c: Fix common/ includes.
5024         * target/waitstatus.h: Fix common/ includes.
5025         * target/waitstatus.c: Fix common/ includes.
5026         * target.h: Fix common/ includes.
5027         * target.c: Fix common/ includes.
5028         * target-memory.c: Fix common/ includes.
5029         * target-descriptions.c: Fix common/ includes.
5030         * symtab.h: Fix common/ includes.
5031         * symfile.c: Fix common/ includes.
5032         * stap-probe.c: Fix common/ includes.
5033         * spu-linux-nat.c: Fix common/ includes.
5034         * sparc-nat.c: Fix common/ includes.
5035         * source.c: Fix common/ includes.
5036         * solib.c: Fix common/ includes.
5037         * solib-target.c: Fix common/ includes.
5038         * ser-unix.c: Fix common/ includes.
5039         * ser-tcp.c: Fix common/ includes.
5040         * ser-pipe.c: Fix common/ includes.
5041         * ser-base.c: Fix common/ includes.
5042         * selftest-arch.c: Fix common/ includes.
5043         * s12z-tdep.c: Fix common/ includes.
5044         * rust-exp.y: Fix common/ includes.
5045         * rs6000-aix-tdep.c: Fix common/ includes.
5046         * riscv-tdep.c: Fix common/ includes.
5047         * remote.c: Fix common/ includes.
5048         * remote-notif.h: Fix common/ includes.
5049         * remote-fileio.h: Fix common/ includes.
5050         * remote-fileio.c: Fix common/ includes.
5051         * regcache.h: Fix common/ includes.
5052         * regcache.c: Fix common/ includes.
5053         * record-btrace.c: Fix common/ includes.
5054         * python/python.c: Fix common/ includes.
5055         * python/py-type.c: Fix common/ includes.
5056         * python/py-inferior.c: Fix common/ includes.
5057         * progspace.h: Fix common/ includes.
5058         * producer.c: Fix common/ includes.
5059         * procfs.c: Fix common/ includes.
5060         * proc-api.c: Fix common/ includes.
5061         * printcmd.c: Fix common/ includes.
5062         * ppc-linux-nat.c: Fix common/ includes.
5063         * parser-defs.h: Fix common/ includes.
5064         * osdata.c: Fix common/ includes.
5065         * obsd-nat.c: Fix common/ includes.
5066         * nat/x86-linux.c: Fix common/ includes.
5067         * nat/x86-linux-dregs.c: Fix common/ includes.
5068         * nat/x86-dregs.h: Fix common/ includes.
5069         * nat/x86-dregs.c: Fix common/ includes.
5070         * nat/ppc-linux.c: Fix common/ includes.
5071         * nat/mips-linux-watch.h: Fix common/ includes.
5072         * nat/mips-linux-watch.c: Fix common/ includes.
5073         * nat/linux-waitpid.c: Fix common/ includes.
5074         * nat/linux-ptrace.h: Fix common/ includes.
5075         * nat/linux-ptrace.c: Fix common/ includes.
5076         * nat/linux-procfs.c: Fix common/ includes.
5077         * nat/linux-personality.c: Fix common/ includes.
5078         * nat/linux-osdata.c: Fix common/ includes.
5079         * nat/linux-namespaces.c: Fix common/ includes.
5080         * nat/linux-btrace.h: Fix common/ includes.
5081         * nat/linux-btrace.c: Fix common/ includes.
5082         * nat/fork-inferior.c: Fix common/ includes.
5083         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5084         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5085         * nat/aarch64-linux.c: Fix common/ includes.
5086         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5087         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5088         * namespace.h: Fix common/ includes.
5089         * mips-linux-tdep.c: Fix common/ includes.
5090         * minsyms.c: Fix common/ includes.
5091         * mi/mi-parse.h: Fix common/ includes.
5092         * mi/mi-main.c: Fix common/ includes.
5093         * mi/mi-cmd-env.c: Fix common/ includes.
5094         * memrange.h: Fix common/ includes.
5095         * memattr.c: Fix common/ includes.
5096         * maint.h: Fix common/ includes.
5097         * maint.c: Fix common/ includes.
5098         * main.c: Fix common/ includes.
5099         * machoread.c: Fix common/ includes.
5100         * location.c: Fix common/ includes.
5101         * linux-thread-db.c: Fix common/ includes.
5102         * linux-nat.c: Fix common/ includes.
5103         * linux-fork.c: Fix common/ includes.
5104         * inline-frame.c: Fix common/ includes.
5105         * infrun.c: Fix common/ includes.
5106         * inflow.c: Fix common/ includes.
5107         * inferior.h: Fix common/ includes.
5108         * inferior.c: Fix common/ includes.
5109         * infcmd.c: Fix common/ includes.
5110         * inf-ptrace.c: Fix common/ includes.
5111         * inf-child.c: Fix common/ includes.
5112         * ia64-linux-nat.c: Fix common/ includes.
5113         * i387-tdep.c: Fix common/ includes.
5114         * i386-tdep.c: Fix common/ includes.
5115         * i386-linux-tdep.c: Fix common/ includes.
5116         * i386-linux-nat.c: Fix common/ includes.
5117         * i386-go32-tdep.c: Fix common/ includes.
5118         * i386-fbsd-tdep.c: Fix common/ includes.
5119         * i386-fbsd-nat.c: Fix common/ includes.
5120         * guile/scm-type.c: Fix common/ includes.
5121         * guile/guile.c: Fix common/ includes.
5122         * go32-nat.c: Fix common/ includes.
5123         * gnu-nat.c: Fix common/ includes.
5124         * gdbthread.h: Fix common/ includes.
5125         * gdbarch-selftests.c: Fix common/ includes.
5126         * gdb_usleep.c: Fix common/ includes.
5127         * gdb_select.h: Fix common/ includes.
5128         * gdb_bfd.c: Fix common/ includes.
5129         * gcore.c: Fix common/ includes.
5130         * fork-child.c: Fix common/ includes.
5131         * findvar.c: Fix common/ includes.
5132         * fbsd-nat.c: Fix common/ includes.
5133         * event-top.c: Fix common/ includes.
5134         * event-loop.c: Fix common/ includes.
5135         * dwarf2read.c: Fix common/ includes.
5136         * dwarf2loc.c: Fix common/ includes.
5137         * dwarf2-frame.c: Fix common/ includes.
5138         * dwarf-index-cache.c: Fix common/ includes.
5139         * dtrace-probe.c: Fix common/ includes.
5140         * disasm-selftests.c: Fix common/ includes.
5141         * defs.h: Fix common/ includes.
5142         * csky-tdep.c: Fix common/ includes.
5143         * cp-valprint.c: Fix common/ includes.
5144         * cp-support.h: Fix common/ includes.
5145         * cp-support.c: Fix common/ includes.
5146         * corelow.c: Fix common/ includes.
5147         * completer.h: Fix common/ includes.
5148         * completer.c: Fix common/ includes.
5149         * compile/compile.c: Fix common/ includes.
5150         * compile/compile-loc2c.c: Fix common/ includes.
5151         * compile/compile-cplus-types.c: Fix common/ includes.
5152         * compile/compile-cplus-symbols.c: Fix common/ includes.
5153         * command.h: Fix common/ includes.
5154         * cli/cli-dump.c: Fix common/ includes.
5155         * cli/cli-cmds.c: Fix common/ includes.
5156         * charset.c: Fix common/ includes.
5157         * build-id.c: Fix common/ includes.
5158         * btrace.h: Fix common/ includes.
5159         * btrace.c: Fix common/ includes.
5160         * breakpoint.h: Fix common/ includes.
5161         * breakpoint.c: Fix common/ includes.
5162         * ax.h:
5163         (enum agent_op): Fix common/ includes.
5164         * ax-general.c (struct aop_map): Fix common/ includes.
5165         * ax-gdb.c: Fix common/ includes.
5166         * auxv.c: Fix common/ includes.
5167         * auto-load.c: Fix common/ includes.
5168         * arm-tdep.c: Fix common/ includes.
5169         * arch/riscv.c: Fix common/ includes.
5170         * arch/ppc-linux-common.c: Fix common/ includes.
5171         * arch/i386.c: Fix common/ includes.
5172         * arch/arm.c: Fix common/ includes.
5173         * arch/arm-linux.c: Fix common/ includes.
5174         * arch/arm-get-next-pcs.c: Fix common/ includes.
5175         * arch/amd64.c: Fix common/ includes.
5176         * arch/aarch64.c: Fix common/ includes.
5177         * arch/aarch64-insn.c: Fix common/ includes.
5178         * arch-utils.c: Fix common/ includes.
5179         * amd64-windows-tdep.c: Fix common/ includes.
5180         * amd64-tdep.c: Fix common/ includes.
5181         * amd64-sol2-tdep.c: Fix common/ includes.
5182         * amd64-obsd-tdep.c: Fix common/ includes.
5183         * amd64-nbsd-tdep.c: Fix common/ includes.
5184         * amd64-linux-tdep.c: Fix common/ includes.
5185         * amd64-linux-nat.c: Fix common/ includes.
5186         * amd64-fbsd-tdep.c: Fix common/ includes.
5187         * amd64-fbsd-nat.c: Fix common/ includes.
5188         * amd64-dicos-tdep.c: Fix common/ includes.
5189         * amd64-darwin-tdep.c: Fix common/ includes.
5190         * agent.c: Fix common/ includes.
5191         * ada-lang.h: Fix common/ includes.
5192         * ada-lang.c: Fix common/ includes.
5193         * aarch64-tdep.c: Fix common/ includes.
5194
5195 2019-01-25  Tom Tromey  <tom@tromey.com>
5196
5197         * common/create-version.sh: Use common/version.h.
5198
5199 2019-01-24  Pedro Alves  <palves@redhat.com>
5200
5201         * infrun.c (signal_stop, signal_print, signal_program)
5202         (signal_catch, signal_pass): Now arrays instead of pointers.
5203         (update_signals_program_target, do_target_resume)
5204         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5205         * linux-nat.c (linux_nat_target::pass_signals)
5206         (linux_nat_target::create_inferior, linux_nat_target::attach):
5207         Adjust.
5208         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5209         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5210         * procfs.c (procfs_target::pass_signals): Adjust.
5211         * record-full.c (record_full_target::resume): Adjust.
5212         * remote.c (remote_target::pass_signals)
5213         (remote_target::program_signals): Adjust.
5214         * target-debug.h (target_debug_print_signals): Now takes a
5215         gdb::array_view as parameter.  Adjust.
5216         * target.h (target_ops) <pass_signals, program_signals>: Replace
5217         pointer and length parameters with gdb::array_view.
5218         (target_pass_signals, target_program_signals): Likewise.
5219         * target-delegates.c: Regenerate.
5220
5221 2019-01-24  Pedro Alves  <palves@redhat.com>
5222
5223         * common/forward-scope-exit.h
5224         (forward_scope_exit::forward_scope_exit): Pass arguments to
5225         m_bind_function directly, instead of creating a std::bind and
5226         copying that.
5227
5228 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5229
5230         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5231         for static members.
5232         (pass_in_v_vfp_candidate): Likewise.
5233
5234 2019-01-23  Tom Tromey  <tom@tromey.com>
5235             Pedro Alves  <palves@redhat.com>
5236
5237         * regcache.c (class regcache_invalidator): Remove.
5238         (regcache::raw_write): Use make_scope_exit.
5239
5240 2019-01-23  Tom Tromey  <tom@tromey.com>
5241
5242         * ui-out.h (class ui_out_emit_type): Update comment.
5243
5244 2019-01-23  Tom Tromey  <tom@tromey.com>
5245
5246         * infrun.c (fetch_inferior_event): Update comment.
5247
5248 2019-01-23  Tom Tromey  <tom@tromey.com>
5249             Pedro Alves  <palves@redhat.com>
5250
5251         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5252         parameter.
5253         (fetch_inferior_event): Use SCOPE_EXIT.
5254
5255
5256 2019-01-23  Tom Tromey  <tom@tromey.com>
5257             Pedro Alves  <palves@redhat.com>
5258
5259         * infrun.c (disable_thread_events): Delete.
5260         (stop_all_threads): Use SCOPE_EXIT.
5261
5262 2019-01-23  Tom Tromey  <tom@tromey.com>
5263             Pedro Alves  <palves@redhat.com>
5264
5265         * symfile.c: Include forward-scope-exit.h.
5266         (clear_symtab_users_cleanup): Replace forward declaration with
5267         a FORWARD_SCOPE_EXIT.
5268         (syms_from_objfile_1): Use the forward_scope_exit and
5269         gdb::optional instead of cleanup_function.
5270         (reread_symbols): Use the forward_scope_exit instead of
5271         cleanup_function.
5272         (clear_symtab_users_cleanup): Remove function.
5273
5274 2019-01-23  Tom Tromey  <tom@tromey.com>
5275             Pedro Alves  <palves@redhat.com>
5276
5277         * linux-nat.c: Include scope-exit.h.
5278         (cleanup_target_stop): Remove.
5279         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5280         SCOPE_EXIT.
5281
5282 2019-01-23  Tom Tromey  <tom@tromey.com>
5283             Pedro Alves  <palves@redhat.com>
5284
5285         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5286         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5287
5288 2019-01-23  Tom Tromey  <tom@tromey.com>
5289             Andrew Burgess  <andrew.burgess@embecosm.com>
5290             Pedro Alves  <palves@redhat.com>
5291
5292         * infrun.c (fetch_inferior_event): Use scope_exit.
5293         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5294         * top.c (execute_command): Use scope_exit.
5295         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5296         * utils.c (do_bpstat_clear_actions_cleanup)
5297         (make_bpstat_clear_actions_cleanup): Remove.
5298
5299 2019-01-23  Tom Tromey  <tom@tromey.com>
5300             Pedro Alves  <palves@redhat.com>
5301
5302         * infrun.c: Include "common/scope-exit.h"
5303         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5304         (wait_for_inferior): Use SCOPE_EXIT.
5305         (fetch_inferior_event): Use scope_exit.
5306
5307 2019-01-23  Tom Tromey  <tom@tromey.com>
5308             Pedro Alves  <palves@redhat.com>
5309
5310         * breakpoint.c (create_breakpoint): Remove cleanup.
5311
5312 2019-01-23  Tom Tromey  <tom@tromey.com>
5313             Andrew Burgess  <andrew.burgess@embecosm.com>
5314             Pedro Alves  <palves@redhat.com>
5315
5316 2019-01-23  Pedro Alves  <palves@redhat.com>
5317
5318         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5319
5320 2019-01-23  Pedro Alves  <palves@redhat.com>
5321             Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         * gdbthread.h: Include "common/forward-scope-exit.h".
5324         (scoped_finish_thread_state): Redefine custom class in terms of
5325         forward_scope_exit.
5326
5327 2019-01-23  Pedro Alves  <palves@redhat.com>
5328             Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * common/forward-scope-exit.h: New file.
5331
5332 2019-01-23  Pedro Alves  <palves@redhat.com>
5333             Andrew Burgess  <andrew.burgess@embecosm.com>
5334             Tom Tromey  <tom@tromey.com>
5335
5336         * common/scope-exit.h: New file.
5337
5338 2019-01-23  Pedro Alves  <palves@redhat.com>
5339
5340         * common/preprocessor.h (ESC): Rename to ...
5341         (ESC_PARENS): ... this.
5342         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5343         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5344
5345 2019-01-23  Tom Tromey  <tom@tromey.com>
5346
5347         * language.h (class scoped_switch_to_sym_language_if_auto):
5348         Initialize m_lang in both cases.
5349
5350 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5351
5352         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5353         with XCNEW.
5354
5355 2019-01-22  Tom Tromey  <tom@tromey.com>
5356
5357         * corelow.c: Do not include sys/file.h.
5358
5359 2019-01-22  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-wingeneral.h: Include gdb_curses.h.
5362
5363 2019-01-22  Tom Tromey  <tom@tromey.com>
5364
5365         * source-cache.h (class source_cache) <get_source_lines,
5366         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5367
5368 2019-01-22  Tom Tromey  <tom@tromey.com>
5369
5370         * remote-fileio.h (struct remote_target): Declare.
5371
5372 2019-01-22  Tom Tromey  <tom@tromey.com>
5373
5374         * python/py-arch.c: Do not include py-ref.h.
5375         * python/py-bpevent.c: Do not include py-ref.h.
5376         * python/py-cmd.c: Do not include py-ref.h.
5377         * python/py-continueevent.c: Do not include py-ref.h.
5378         * python/py-event.h: Do not include py-ref.h.
5379         * python/py-evtregistry.c: Do not include py-ref.h.
5380         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5381         * python/py-frame.c: Do not include py-ref.h.
5382         * python/py-framefilter.c: Do not include py-ref.h.
5383         * python/py-function.c: Do not include py-ref.h.
5384         * python/py-infevents.c: Do not include py-ref.h.
5385         * python/py-linetable.c: Do not include py-ref.h.
5386         * python/py-objfile.c: Do not include py-ref.h.
5387         * python/py-param.c: Do not include py-ref.h.
5388         * python/py-prettyprint.c: Do not include py-ref.h.
5389         * python/py-progspace.c: Do not include py-ref.h.
5390         * python/py-symbol.c: Do not include py-ref.h.
5391         * python/py-symtab.c: Do not include py-ref.h.
5392         * python/py-type.c: Do not include py-ref.h.
5393         * python/py-unwind.c: Do not include py-ref.h.
5394         * python/py-utils.c: Do not include py-ref.h.
5395         * python/py-value.c: Do not include py-ref.h.
5396         * python/py-varobj.c: Do not include py-ref.h.
5397         * python/py-xmethods.c: Do not include py-ref.h.
5398         * python/python.c: Do not include py-ref.h.
5399         * varobj.c: Do not include py-ref.h.
5400
5401 2019-01-22  Tom Tromey  <tom@tromey.com>
5402
5403         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5404         keyword for bcache.
5405
5406 2019-01-22  Tom Tromey  <tom@tromey.com>
5407
5408         * compile/compile-cplus-types.c: Remove a comment by #include.
5409
5410 2019-01-22  Tom Tromey  <tom@tromey.com>
5411
5412         * compile/gcc-c-plugin.h: Include compile-internal.h.
5413
5414 2019-01-22  Tom Tromey  <tom@tromey.com>
5415
5416         * stabsread.c (EXTERN): Do not define.
5417         (symnum, next_symbol_text_func, processing_gcc_compilation)
5418         (within_function, global_sym_chain, global_stabs)
5419         (previous_stab_code, this_object_header_files)
5420         (n_this_object_header_files)
5421         (n_allocated_this_object_header_files): Define.
5422         * stabsread.h (EXTERN): Never define.  Use "extern".
5423
5424 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5425
5426         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5427         history_value.
5428
5429 2019-01-21  Tom Tromey  <tom@tromey.com>
5430
5431         * ui-out.c: Fix includes.
5432         * tui/tui-source.c: Fix includes.
5433         * target.c: Fix includes.
5434         * remote.c: Fix includes.
5435         * regcache.c: Fix includes.
5436         * python/py-block.c: Fix includes.
5437         * printcmd.c: Fix includes.
5438         * or1k-tdep.c: Fix includes.
5439         * mi/mi-main.c: Fix includes.
5440         * m32r-tdep.c: Fix includes.
5441         * csky-tdep.c: Fix includes.
5442         * compile/compile-cplus-types.c: Fix includes.
5443         * cli/cli-interp.c: Fix includes.
5444
5445 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5446
5447         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5448         for padding.
5449
5450 2019-01-16  Tom Tromey  <tom@tromey.com>
5451
5452         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5453         earlier.
5454         (struct objfile) <msymbols_range>: Move from top level.
5455         <msymbols>: New method.
5456         (class objfile_msymbols): Remove.
5457         * symtab.c (default_collect_symbol_completion_matches_break_on):
5458         Update.
5459         * symmisc.c (dump_msymbols): Update.
5460         * stabsread.c (scan_file_globals): Update.
5461         * objc-lang.c (info_selectors_command, info_classes_command)
5462         (find_methods): Update.
5463         * minsyms.c (find_solib_trampoline_target): Update.
5464         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5465         * coffread.c (coff_symfile_read): Update.
5466         * ada-lang.c (ada_lookup_simple_minsym)
5467         (ada_collect_symbol_completion_matches): Update.
5468
5469 2019-01-16  Tom Tromey  <tom@tromey.com>
5470
5471         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5472         type.  Remove no-argument constructor.
5473         <iterator::operator++>: Simplify.
5474         <begin>: Update.
5475         <end>: Use minimal_symbol_count.
5476
5477 2019-01-16  Tom Tromey  <tom@tromey.com>
5478
5479         * objfiles.h (struct objfile) <psymtabs>: New method.
5480         (class objfile_psymtabs): Remove.
5481         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5482         typedef.
5483         <range>: New method.
5484         (require_partial_symbols): Change return type.
5485         * psymtab.c (require_partial_symbols)
5486         (psym_expand_symtabs_matching): Update.
5487         * mdebugread.c (parse_partial_symbols): Update.
5488         * dbxread.c (dbx_end_psymtab): Update.
5489
5490 2019-01-15  Tom Tromey  <tom@tromey.com>
5491
5492         * symtab.c (lookup_objfile_from_block)
5493         (lookup_symbol_in_objfile_symtabs)
5494         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5495         (find_line_symtab, info_sources_command)
5496         (default_collect_symbol_completion_matches_break_on)
5497         (make_source_files_completion_list): Update.
5498         * symmisc.c (print_objfile_statistics, dump_objfile)
5499         (maintenance_print_symbols, maintenance_info_symtabs)
5500         (maintenance_check_symtabs, maintenance_info_line_tables):
5501         Update.
5502         * source.c (select_source_symtab)
5503         (forget_cached_source_info_for_objfile): Update.
5504         * objfiles.h (class objfile_compunits): Remove.
5505         (struct objfile) <compunits_range>: New typedef.
5506         (compunits): New method.
5507         * objfiles.c (objfile_relocate1): Update.
5508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5509         * maint.c (count_symtabs_and_blocks): Update.
5510         * linespec.c (iterate_over_all_matching_symtabs): Update.
5511         * cp-support.c (add_symbol_overload_list_qualified): Update.
5512         * coffread.c (coff_symtab_read): Update.
5513         * ada-lang.c (add_nonlocal_symbols)
5514         (ada_collect_symbol_completion_matches)
5515         (ada_add_global_exceptions): Update.
5516
5517 2019-01-15  Tom Tromey  <tom@tromey.com>
5518
5519         * progspace.h (program_space) <objfiles_safe_range>: New
5520         typedef.
5521         <objfiles_safe>: New method.
5522         * objfiles.h (class all_objfiles_safe): Remove.
5523         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5524         * jit.c (jit_inferior_exit_hook): Update.
5525
5526 2019-01-17  Tom Tromey  <tom@tromey.com>
5527
5528         * progspace.h (program_space) <objfiles_range>: New typedef.
5529         <objfiles>: New method.
5530         <objfiles_head>: Rename from objfiles.
5531         (object_files): Update.
5532         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5533         * guile/scm-pretty-print.c
5534         (ppscm_find_pretty_printer_from_objfiles): Update.
5535         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5536         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5537         Update.
5538         * python/py-progspace.c (pspy_get_objfiles): Update.
5539         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5540         Update.
5541         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5542         (objfpy_lookup_objfile_by_build_id): Update.
5543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5544         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5545         Update.
5546         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5547         (expand_symtab_containing_pc, lookup_objfile_from_block)
5548         (lookup_static_symbol, basic_lookup_transparent_type)
5549         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5550         (find_line_symtab, info_sources_command)
5551         (default_collect_symbol_completion_matches_break_on)
5552         (make_source_files_completion_list, find_main_name): Update.
5553         * symmisc.c (print_symbol_bcache_statistics)
5554         (print_objfile_statistics, maintenance_print_symbols)
5555         (maintenance_print_msymbols, maintenance_print_objfiles)
5556         (maintenance_info_symtabs, maintenance_check_symtabs)
5557         (maintenance_expand_symtabs, maintenance_info_line_tables):
5558         Update.
5559         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5560         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5561         (map_overlay_command, unmap_overlay_command)
5562         (simple_overlay_update, expand_symtabs_matching)
5563         (map_symbol_filenames): Update.
5564         * symfile-debug.c (set_debug_symfile): Update.
5565         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5566         Update.
5567         * source.c (select_source_symtab, forget_cached_source_info):
5568         Update.
5569         * solib.c (solib_read_symbols): Update.
5570         * solib-spu.c (append_ocl_sos): Update.
5571         * psymtab.c (maintenance_print_psymbols)
5572         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5573         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5574         * printcmd.c (info_symbol_command): Update.
5575         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5576         Update.
5577         * objfiles.h (class all_objfiles): Remove.
5578         * objfiles.c (have_partial_symbols, have_full_symbols)
5579         (have_minimal_symbols, qsort_cmp, update_section_map)
5580         (shared_objfile_contains_address_p)
5581         (default_iterate_over_objfiles_in_search_order): Update.
5582         * objc-lang.c (info_selectors_command, info_classes_command)
5583         (find_methods): Update.
5584         * minsyms.c (find_solib_trampoline_target): Update.
5585         * maint.c (maintenance_info_sections)
5586         (maintenance_translate_address, count_symtabs_and_blocks):
5587         Update.
5588         * main.c (captured_main_1): Update.
5589         * linux-thread-db.c (try_thread_db_load_from_pdir)
5590         (has_libpthread): Update.
5591         * linespec.c (iterate_over_all_matching_symtabs)
5592         (search_minsyms_for_name): Update.
5593         * jit.c (jit_find_objf_with_entry_addr): Update.
5594         * hppa-tdep.c (find_unwind_entry)
5595         (hppa_lookup_stub_minimal_symbol): Update.
5596         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5597         Update.
5598         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5599         (elf_gnu_ifunc_resolve_by_got): Update.
5600         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5601         * dwarf-index-write.c (save_gdb_index_command): Update.
5602         * cp-support.c (add_symbol_overload_list_qualified): Update.
5603         * breakpoint.c (create_overlay_event_breakpoint)
5604         (create_longjmp_master_breakpoint)
5605         (create_std_terminate_master_breakpoint)
5606         (create_exception_master_breakpoint): Update.
5607         * blockframe.c (find_pc_partial_function): Update.
5608         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5609         (ada_collect_symbol_completion_matches)
5610         (ada_add_global_exceptions): Update.
5611
5612 2019-01-17  Tom Tromey  <tom@tromey.com>
5613
5614         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5615         declare VEC.
5616         (solib_target_parse_libraries): Change return type.
5617         (library_list_start_segment, library_list_start_section)
5618         (library_list_end_library, library_list_start_library); Update.
5619         (solib_target_free_library_list): Remove.
5620         (solib_target_parse_libraries): Remove cleanup.  Change return
5621         type.
5622         (solib_target_current_sos): Update.
5623
5624 2019-01-17  Tom Tromey  <tromey@bapiya>
5625
5626         * valprint.c: Replace "the the" with "the".
5627         * symtab.c: Replace "the the" with "the".
5628         * solib.c: Replace "the the" with "the".
5629         * solib-dsbt.c: Replace "the the" with "the".
5630         * linespec.c: Replace "the the" with "the".
5631         * dwarf2loc.h: Replace "the the" with "the".
5632         * amd64-windows-tdep.c: Replace "the the" with "the".
5633         * aarch64-tdep.c: Replace "the the" with "the".
5634
5635 2019-01-16  Keith Seitz  <keiths@redhat.com>
5636
5637         PR gdb/23773
5638         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5639         <builder>: Rename to ..
5640         <m_builder>: ... this and make private.
5641         (dwarf2_cu::get_builder): New method.  Change all users of
5642         `builder' to use this method.
5643         (dwarf2_start_symtab): Move to ...
5644         (dwarf2_cu::start_symtab): ... here.  Update all callers
5645         (setup_type_unit_groups): Move to ...
5646         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5647         callers.
5648         (dwarf2_cu::reset_builder): New method.
5649         (process_full_compunit, process_full_type_unit): Use
5650         dwarf2_cu::reset_builder.
5651         (follow_die_offset): Record the ancestor CU if it is different
5652         from the followed DIE's CU.
5653         (follow_die_sig_1): Likewise.
5654
5655 2019-01-15  Tom Tromey  <tom@tromey.com>
5656
5657         * remote.c (class remote_state) <buf>: Now a char_vector.
5658         <buf_size>: Remove.
5659         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5660         parameter.
5661         (remote_target::getpkt_or_notif_sane_1)
5662         (remote_target::getpkt_sane)
5663         (remote_target::getpkt_or_notif_sane): Likewise.
5664         (class remote_target) <putpkt>: New overload.
5665         (remote_target::read_frame): Change type of "buf_p".  Remove
5666         sizeof_p parameter.
5667         (packet_ok): New overload.
5668         (packet_check_result): New overload.
5669         Update all uses.
5670
5671 2019-01-14  Tom Tromey  <tom@tromey.com>
5672
5673         * remote-notif.c (handle_notification, remote_notif_ack)
5674         (remote_notif_parse): Make "buf" const.
5675         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5676         const.
5677         (remote_notif_parse, remote_notif_ack, handle_notification):
5678         Likewise.
5679         * remote.c (remote_notif_stop_parse): Make "buf" const.
5680         (remote_target::remote_parse_stop_reply): Make "buf" const.
5681         (remote_notif_stop_ack): Make "buf" const.
5682
5683 2019-01-14  Tom Tromey  <tom@tromey.com>
5684
5685         * remote.c (remote_console_output): Make parameter const.
5686
5687 2019-01-14  Tom Tromey  <tom@tromey.com>
5688
5689         * target-debug.h (target_debug_print_signals): Constify.
5690         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5691         * procfs.c (procfs_target::pass_signals): Update.
5692         * linux-nat.c (linux_nat_target::pass_signals): Update.
5693         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5694         * target-delegates.c: Rebuild.
5695         * remote.c (remote_target::program_signals): Update.
5696         (remote_target::pass_signals): Update.
5697         * target.c (target_pass_signals): Constify argument.
5698         (target_program_signals): Likewise.
5699         * target.h (struct target_ops) <pass_signals, program_signals>:
5700         Constify argument.
5701         (target_pass_signals, target_program_signals): Constify argument.
5702
5703 2019-01-14  Tom Tromey  <tom@tromey.com>
5704
5705         PR tui/28819:
5706         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5707
5708 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5709
5710         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5711         field.
5712         * rs6000-tdep.c: Include reggroups.h.
5713         (IS_V_ALIAS_PSEUDOREG): Define.
5714         (rs6000_register_name): Return names for the "vX" aliases.
5715         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5716         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5717         aliases.  Call default_register_reggroup_p for all other
5718         pseudo-registers.
5719         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5720         New functions.
5721         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5722         Handle "vX" aliases.
5723         (v_alias_pseudo_register_collect): New function.
5724         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5725         (rs6000_gdbarch_init): Initialize "vX" aliases as
5726         pseudo-registers.  Restore registration of
5727         rs6000_pseudo_register_reggroup_p with
5728         set_tdesc_pseudo_register_reggroup_p.
5729
5730 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5731
5732         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5733         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5734         set_gdbarch_num_pseudo_regs.
5735
5736 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5737
5738         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5739         Remove arg prefixname, add do_set and do_show.
5740         Add member functions set_list and show_list.
5741         * cli/cli-style.c (class cli_style_option): Update accordingly.
5742         (style_set_list): Move to file scope.
5743         (style_show_list): Likewise.
5744         (set_style): Call help_list.
5745         (show_style): Call cmd_show_list.
5746         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5747         Update to use the new macro.
5748
5749 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5750
5751         * ada-lang.c (_initialize_ada_language): Expand the help text
5752         for the "catch exception" command.
5753
5754 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5755
5756         * symtab.c (matching_obj_sections): Initialize obj,
5757         declare it closer to its usage.
5758
5759 2019-01-10  Tom Tromey  <tom@tromey.com>
5760
5761         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5762         (basic_inf_threads_range): Remove.
5763         (inf_threads_range, inf_non_exited_threads_range)
5764         (safe_inf_threads_range): Use next_adapter.
5765
5766 2019-01-10  Keith Seitz  <keiths@redhat.com>
5767
5768         PR gdb/23712
5769         PR symtab/23010
5770         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5771         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5772
5773 2019-01-10  Keith Seitz  <keiths@redhat.com>
5774
5775         PR gdb/23712
5776         PR symtab/23010
5777         * dictionary.c (pending_to_vector): Remove.
5778         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5779         Remove _1 suffix, replacing functions of the same name.  Update
5780         all callers.
5781         (dict_create_hashed, dict_create_hashed_expandable)
5782         (dict_create_linear, dict_create_linear_expandable, dict_free)
5783         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5784         Make functions static.
5785
5786 2019-01-10  Keith Seitz  <keiths@redhat.com>
5787
5788         PR gdb/23712
5789         PR symtab/23010
5790         * dictionary.h (struct dictionary): Replace declaration with
5791         multidictionary.
5792         (dict_create_hashed, dict_create_hashed_expandable)
5793         (dict_create_linear, dict_create_linear_expandable)
5794         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5795         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5796         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5797         taking multidictionary argument.
5798         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5799         * block.h (struct block) <dict>: Change to multidictionary
5800         and rename `multidict'.
5801         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5802         symmisc.c: Update all dictionary references to multidictionary.
5803
5804 2019-01-10  Keith Seitz  <keiths@redhat.com>
5805
5806         PR gdb/23712
5807         PR symtab/23010
5808         * dictionary.c: Include unordered_map.
5809         (pending_to_vector): New function.
5810         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5811         Rewrite the non-"_1" functions to take vector instead
5812         of linked list.
5813         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5814         "new" _1 versions of the same name.
5815         (multidictionary): Define.
5816         (std::hash<enum language): New definition.
5817         (collate_pending_symbols_by_language, mdict_create_hashed)
5818         (mdict_create_hashed_expandable, mdict_create_linear)
5819         (mdict_create_linear_expandable, mdict_free)
5820         (find_language_dictionary, create_new_language_dictionary)
5821         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5822         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5823         (mdict_size, mdict_empty): New functions.
5824         * dictionary.h (mdict_iterator): Define.
5825
5826 2019-01-10  Pedro Alves  <palves@redhat.com>
5827
5828         * breakpoint.c (read_uploaded_action)
5829         (create_tracepoint_from_upload): Adjust to use
5830         gdb::unique_xmalloc_ptr.
5831         * ctf.c (ctf_write_uploaded_tp):
5832         (SET_ARRAY_FIELD): Use emplace_back.
5833         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5834         * tracefile-tfile.c (tfile_write_uploaded_tp):
5835         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5836         gdb::unique_xmalloc_ptr.
5837         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5838         at_string, cond_string, cmd_strings>: Replace char pointers
5839         with gdb::unique_xmalloc_ptr.
5840
5841 2019-01-10  Pedro Alves  <palves@redhat.com>
5842
5843         * solib-target.c (library_list_start_library): Don't xstrdup name.
5844
5845 2019-01-10  Pedro Alves  <palves@redhat.com>
5846
5847         * mdebugread.c (parse_partial_symbols): Use
5848         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5849
5850 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * linux-fork.c (scoped_switch_fork_info)
5853         <~scoped_switch_fork_info>: Fix incorrect variable name.
5854
5855 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * linux-fork.c (scoped_switch_fork_info)
5858         <scoped_switch_fork_info>: Make explicit.
5859         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5860
5861 2019-01-10  Tom Tromey  <tom@tromey.com>
5862
5863         * objfiles.h (objfile::reset_psymtabs): Update.
5864         * objfiles.c (objfile::objfile): Update.
5865         * psymtab.h (psymtab_storage::obstack): Update.
5866         (psymtab_storage::m_obstack): Use gdb::optional.
5867         (class psymtab_storage): Update comment.  Remove objfile
5868         parameter.
5869         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5870
5871 2019-01-10  Tom Tromey  <tom@tromey.com>
5872
5873         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5874         <free_psymtabs>: Now private.
5875         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5876         (allocate_psymtab): Use new method.
5877
5878 2019-01-10  Tom Tromey  <tom@tromey.com>
5879
5880         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5881         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5882         * mdebugread.c (parse_partial_symbols): Use
5883         allocate_dependencies.
5884         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5885         allocate_dependencies.
5886         (process_psymtab_comp_unit_reader)
5887         (build_type_psymtab_dependencies): Likewise.
5888         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5889
5890 2019-01-10  Tom Tromey  <tom@tromey.com>
5891
5892         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5893         PSYMBOL_SET_LANGUAGE.
5894         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5895
5896 2019-01-10  Tom Tromey  <tom@tromey.com>
5897
5898         * psymtab.h (psymtab_storage::obstack): New method.
5899         <m_obstack>: Rename from obstack; now private.
5900         * psymtab.c (psymtab_storage): Update.
5901         * dwarf2read.c (create_addrmap_from_index)
5902         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5903         Update.
5904
5905 2019-01-10  Tom Tromey  <tom@tromey.com>
5906
5907         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5908         * objfiles.h (objfile::reset_psymtabs): New method.
5909
5910 2019-01-10  Tom Tromey  <tom@tromey.com>
5911
5912         * symmisc.c (print_symbol_bcache_statistics): Update.
5913         (print_objfile_statistics): Update.
5914         * symfile.c (reread_symbols): Update.
5915         * psymtab.h (class psymtab_storage): New.
5916         * psymtab.c (psymtab_storage): New constructor.
5917         (~psymtab_storage): New destructor.
5918         (require_partial_symbols): Update.
5919         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5920         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5921         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5922         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5923         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5924         (start_psymtab_common, end_psymtab_common)
5925         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5926         (allocate_psymtab): Update.
5927         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5928         Update.
5929         (dump_psymtab_addrmap, maintenance_print_psymbols)
5930         (maintenance_check_psymtabs): Update.
5931         (class objfile_psymtabs): Move to objfiles.h.
5932         * psympriv.h (discard_psymtab): Now inline.
5933         (psymtab_discarder::psymtab_discarder): Update.
5934         (psymtab_discarder::~psymtab_discarder): Update.
5935         (ALL_OBJFILE_PSYMTABS): Rewrite.
5936         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5937         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5938         Remove fields.
5939         <partial_symtabs>: New field.
5940         (class objfile_psymtabs): Move from psymtab.h.  Update.
5941         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5942         psymbol_cache.
5943         (objfile::~objfile): Don't destroy psymbol_cache.
5944         * mdebugread.c (parse_partial_symbols): Update.
5945         * dwarf2read.c (create_addrmap_from_index)
5946         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5947         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5948         (add_partial_subprogram, dwarf2_ranges_read): Update.
5949         * dwarf-index-write.c (write_address_map)
5950         (write_one_signatured_type, recursively_write_psymbols)
5951         (class debug_names, class debug_names, write_psymtabs_to_index):
5952         Update.
5953
5954 2019-01-10  Tom Tromey  <tom@tromey.com>
5955
5956         * symtab.h (SYMBOL_SET_NAMES): Update.
5957         (symbol_set_names): Update.
5958         (MSYMBOL_SET_NAMES): Update.
5959         * symtab.c (symbol_set_names): Change argument to be an
5960         objfile_per_bfd_storage.
5961         * psymtab.c (add_psymbol_to_bcache): Update.
5962         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5963
5964 2019-01-10  Tom Tromey  <tom@tromey.com>
5965
5966         * symtab.c (create_demangled_names_hash): Change argument to be an
5967         objfile_per_bfd_storage.
5968         (symbol_set_names): Update.
5969
5970 2019-01-10  Tom Tromey  <tom@tromey.com>
5971
5972         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5973         init_psymbol_list.
5974         * psymtab.c (init_psymbol_list): Do nothing if already called.
5975         * psympriv.h (init_psymbol_list): Add comment.
5976         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5977         init_psymbol_list.
5978         * dbxread.c (dbx_symfile_read): Unconditionally call
5979         init_psymbol_list.
5980
5981 2019-01-10  Tom Tromey  <tom@tromey.com>
5982
5983         * xcoffread.c (scan_xcoff_symtab): Update.
5984         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5985         "where".
5986         * mdebugread.c (parse_partial_symbols)
5987         (handle_psymbol_enumerators): Update.
5988         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5989         * dbxread.c (read_dbx_symtab): Update.
5990         * psympriv.h (psymbol_placement): New enum.
5991         (add_psymbol_to_list): Update.
5992
5993 2019-01-10  Tom Tromey  <tom@tromey.com>
5994
5995         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5996         static_psymbols parameters.
5997         (scan_xcoff_symtab): Update.
5998         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5999         static_psymbols parameters.
6000         * psympriv.h (start_psymtab_common): Update.
6001         * mdebugread.c (parse_partial_symbols): Update.
6002         * dwarf2read.c (create_partial_symtab): Update.
6003         * dbxread.c (read_dbx_symtab): Update.
6004         (start_psymtab): Remove global_psymbols and static_psymbols
6005         parameters.
6006
6007 2019-01-10  Tom Tromey  <tom@tromey.com>
6008
6009         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6010         * psymtab.c (allocate_psymtab): Add comment.
6011         * psympriv.h (allocate_psymtab): Add comment.
6012         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6013         initializations.
6014         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6015
6016 2019-01-10  Tom Tromey  <tom@tromey.com>
6017
6018         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6019         Don't declare.
6020         * mipsread.c: Include mdebugread.h.
6021         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6022         Declare.
6023         * elfread.c: Include mdebugread.h.
6024
6025 2019-01-09  Tom Tromey  <tom@tromey.com>
6026
6027         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6028         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6029         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6030         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6031         (psym_lookup_symbol, psym_find_last_source_symtab)
6032         (psym_forget_cached_source_info, psym_print_stats)
6033         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6034         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6035         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6036         (psym_find_compunit_symtab_by_address)
6037         (maintenance_print_psymbols, maintenance_info_psymtabs)
6038         (maintenance_check_psymtabs): Use ranged for.
6039         * psymtab.h (class objfile_psymtabs): New.
6040         (require_partial_symbols): Return objfile_psymtabs.
6041         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6042
6043 2019-01-09  Tom Tromey  <tom@tromey.com>
6044
6045         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6046         (find_pc_mapped_section, list_overlays_command)
6047         (map_overlay_command, unmap_overlay_command)
6048         (simple_overlay_update): Use all_objfiles.
6049         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6050         * printcmd.c (info_symbol_command): Use all_objfiles.
6051         * objfiles.h (ALL_OBJSECTIONS): Remove.
6052         * maint.c (maintenance_translate_address): Use all_objfiles.
6053         * gcore.c (gcore_create_callback): Use all_objfiles.
6054         (objfile_find_memory_regions): Likewise.
6055
6056 2019-01-09  Tom Tromey  <tom@tromey.com>
6057
6058         * symtab.c (find_line_symtab, info_sources_command)
6059         (make_source_files_completion_list): Use objfile_compunits.
6060         * source.c (select_source_symtab): Use objfile_compunits.
6061         * objfiles.h (struct objfile): Update comment.
6062         (ALL_OBJFILES): Remove.
6063         (ALL_FILETABS): Remove.
6064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6065         objfile_compunits.
6066
6067 2019-01-09  Tom Tromey  <tom@tromey.com>
6068
6069         * symmisc.c (print_objfile_statistics, dump_objfile)
6070         (maintenance_print_symbols): Use compunit_filetabs.
6071         * source.c (forget_cached_source_info_for_objfile): Use
6072         compunit_filetabs.
6073         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6074         (ALL_FILETABS): Use compunit_filetabs.
6075         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6076         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6077
6078 2019-01-09  Tom Tromey  <tom@tromey.com>
6079
6080         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6081         (compunit_filetabs): New.
6082         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6083         compunit_filetabs.
6084         (info_sources_command, make_source_files_completion_list): Remove
6085         declaration.
6086         * symmisc.c (print_objfile_statistics, dump_objfile)
6087         (maintenance_print_symbols): Remove declaration.
6088         (maintenance_info_symtabs): Use compunit_filetabs.
6089         (maintenance_info_line_tables): Likewise.
6090         * source.c (select_source_symtab): Change local variable name.
6091         (forget_cached_source_info_for_objfile): Remove declaration.
6092         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6093         * objfiles.c (objfile_relocate1): Remove declaration.
6094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6095         declaration.
6096         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6097         * coffread.c (coff_symtab_read): Remove declaration.
6098         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6099         compunit_filetabs.
6100
6101 2019-01-09  Tom Tromey  <tom@tromey.com>
6102
6103         * symtab.c (lookup_objfile_from_block)
6104         (find_pc_sect_compunit_symtab, search_symbols)
6105         (default_collect_symbol_completion_matches_break_on): Use
6106         objfile_compunits.
6107         * objfiles.h (ALL_COMPUNITS): Remove.
6108         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6109         * cp-support.c (add_symbol_overload_list_qualified): Use
6110         objfile_compunits.
6111         * ada-lang.c (ada_collect_symbol_completion_matches)
6112         (ada_add_global_exceptions): Use objfile_compunits.
6113
6114 2019-01-09  Tom Tromey  <tom@tromey.com>
6115
6116         * source.c (select_source_symtab)
6117         (forget_cached_source_info_for_objfile): Remove declaration.
6118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6119         declaration.
6120         * maint.c (count_symtabs_and_blocks): Remove declaration.
6121         * cp-support.c (add_symbol_overload_list_qualified): Remove
6122         declaration.
6123         * coffread.c (coff_symtab_read): Remove declaration.
6124         * symtab.c (lookup_symbol_in_objfile_symtabs)
6125         (basic_lookup_transparent_type_1): Use objfile_compunits.
6126         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6127         (info_sources_command, search_symbols)
6128         (default_collect_symbol_completion_matches_break_on)
6129         (make_source_files_completion_list): Remove declaration.
6130         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6131         (ada_collect_symbol_completion_matches)
6132         (ada_add_global_exceptions): Remove declaration.
6133         * linespec.c (iterate_over_all_matching_symtabs): Use
6134         objfile_compunits.
6135         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6136         (class objfile_compunits): New.
6137         (ALL_COMPUNITS): Use objfile_compunits.
6138         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6139         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6140         objfile_compunits.
6141         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6142
6143 2019-01-09  Tom Tromey  <tom@tromey.com>
6144
6145         * symtab.c (search_symbols)
6146         (default_collect_symbol_completion_matches_break_on): Use
6147         objfile_msymbols.
6148         * ada-lang.c (ada_lookup_simple_minsym)
6149         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6150         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6151         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6152         objfile_msymbols.
6153         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6154         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6155         * objc-lang.c (find_methods): Use objfile_msymbols.
6156         (info_selectors_command, info_classes_command): Likewise.
6157         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6158         * objfiles.h (class objfile_msymbols): New.
6159         (ALL_OBJFILE_MSYMBOLS): Remove.
6160         (ALL_MSYMBOLS): Remove.
6161
6162 2019-01-09  Tom Tromey  <tom@tromey.com>
6163
6164         * common/next-iterator.h (next_adapter): Add Iterator template
6165         parameter.
6166         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6167         (class all_objfiles_safe): New.
6168         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6169         * objfiles.c (put_objfile_before): Update comment.
6170         (add_separate_debug_objfile): Likewise.
6171         (free_all_objfiles): Use all_objfiles_safe.
6172         (objfile_purge_solibs): Likewise.
6173
6174 2019-01-09  Tom Tromey  <tom@tromey.com>
6175
6176         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6177         (expand_symtab_containing_pc, lookup_static_symbol)
6178         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6179         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6180         all_objfiles.
6181         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6182         * breakpoint.c (create_overlay_event_breakpoint)
6183         (create_longjmp_master_breakpoint)
6184         (create_std_terminate_master_breakpoint)
6185         (create_exception_master_breakpoint): Use all_objfiles.
6186         * linux-thread-db.c (try_thread_db_load_from_pdir)
6187         (has_libpthread): Use all_objfiles.
6188         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6189         * linespec.c (iterate_over_all_matching_symtabs)
6190         (search_minsyms_for_name): Use all_objfiles.
6191         * maint.c (maintenance_info_sections): Use all_objfiles.
6192         * main.c (captured_main_1): Use all_objfiles.
6193         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6194         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6195         * guile/scm-pretty-print.c
6196         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6197         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6198         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6199         (maintenance_print_msymbols): Use all_objfiles.
6200         * source.c (select_source_symtab): Use all_objfiles.
6201         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6202         * symfile.c (remove_symbol_file_command)
6203         (expand_symtabs_matching, map_symbol_filenames): Use
6204         all_objfiles.
6205         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6206         all_objfiles.
6207         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6208         * objc-lang.c (find_methods): Use all_objfiles.
6209         * objfiles.c (have_partial_symbols, have_full_symbols)
6210         (have_minimal_symbols, qsort_cmp)
6211         (default_iterate_over_objfiles_in_search_order): Use
6212         all_objfiles.
6213         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6214         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6215         (maintenance_check_psymtabs): Use all_objfiles.
6216         (ALL_PSYMTABS): Remove.
6217         * compile/compile-object-run.c (do_module_cleanup): Use
6218         all_objfiles.
6219         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6220         * cp-support.c (add_symbol_overload_list_qualified): Use
6221         all_objfiles.
6222         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6223         Use all_objfiles.
6224         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6225         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6226         all_objfiles.
6227         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6228         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6229         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6230         Uses all_objfiles.
6231         * solib.c (solib_read_symbols): Use all_objfiles
6232
6233 2019-01-09  Tom Tromey  <tom@tromey.com>
6234
6235         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6236         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6237         all_objfiles.
6238         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6239         * symmisc.c (print_symbol_bcache_statistics)
6240         (print_objfile_statistics, maintenance_print_objfiles)
6241         (maintenance_info_symtabs, maintenance_check_symtabs)
6242         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6243         all_objfiles.
6244         * source.c (forget_cached_source_info): Use all_objfiles.
6245         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6246         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6247         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6248         * objfiles.c (update_section_map): Use all_objfiles.
6249         (shared_objfile_contains_address_p): Likewise.
6250         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6251         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6252
6253 2019-01-09  Tom Tromey  <tom@tromey.com>
6254
6255         * common/next-iterator.h: New file.
6256         * objfiles.h (class all_objfiles): New.
6257         (struct objfile_iterator): New.
6258
6259 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6260
6261         * NEWS: Move the description of the changed "frame", "select-frame",
6262          and "info frame" commands to the Changed commands section.
6263
6264 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6265
6266         * gdbtypes.c (check_stub_method_group): Remove handling of old
6267         mangling schemes.
6268         * linespec.c (find_methods): Likewise.
6269         * stabsread.c (read_member_functions): Likewise.
6270         * valops.c (search_struct_method): Likewise.
6271         (value_struct_elt_for_reference): Likewise.
6272         * NEWS: Mention this change.
6273
6274 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6277         print_source_lines.
6278         * source.c (print_source_lines_base): Update line number check.
6279         (print_source_lines): New function.
6280         (source_lines_range::source_lines_range): New function.
6281         * source.h (class source_lines_range): New class.
6282         (print_source_lines): New declaration.
6283
6284 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6287
6288 2019-01-08  Tom Tromey  <tom@tromey.com>
6289             Simon Marchi  <simon.marchi@ericsson.com>
6290
6291         PR gdb/24060
6292         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6293         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6294         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6295         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6296         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6297         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6298
6299 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * source.c (select_source_symtab): Move header comment to
6302         declaration in source.h.
6303         (forget_cached_source_info_for_objfile): Likewise.
6304         (forget_cached_source_info): Likewise.
6305         (identify_source_line): Likewise.
6306         * source.h (identify_source_line): Move declaration from symtab.h
6307         and add comment from source.c
6308         (print_source_lines): Likewise.
6309         (forget_cached_source_info_for_objfile): Likewise.
6310         (forget_cached_source_info): Likewise.
6311         (select_source_symtab): Likewise.
6312         (enum print_source_lines_flag): Move definition from symtab.h.
6313         * symtab.h (identify_source_line): Move declaration to source.h.
6314         (print_source_lines): Likewise.
6315         (forget_cached_source_info_for_objfile): Likewise.
6316         (forget_cached_source_info): Likewise.
6317         (select_source_symtab): Likewise.
6318         (enum print_source_lines_flag): Move definition to source.h.
6319         * tui/tui-hooks.c: Add 'source.h' include.
6320
6321 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * source.c (print_source_lines_base): Handle requests to print
6324         reverse line number sequences, and guard against empty lines
6325         string.
6326
6327 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * source.c (print_source_lines_base): Fix skip of '\r' if next
6330         character is '\n'.
6331
6332 2019-01-06  Tom Tromey  <tom@tromey.com>
6333
6334         * c-exp.y (struct c_parse_state) <macro_original_text,
6335         expansion_obstack>: New member.
6336         (macro_original_text, expansion_obstack): Remove globals.
6337         (scan_macro_expansion, scanning_macro_expansion)
6338         (finished_macro_expansion): Update.
6339         (scan_macro_cleanup): Remove.
6340         (yylex, c_parse): Update.
6341
6342 2019-01-06  Tom Tromey  <tom@tromey.com>
6343
6344         * c-exp.y (struct c_parse_state) <strings>: New member.
6345         (operator_stoken): Update.
6346
6347 2019-01-06  Tom Tromey  <tom@tromey.com>
6348
6349         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6350         (union type_stack_elt) <typelist_val>: Now a pointer to
6351         std::vector.
6352         (type_stack_cleanup): Don't declare.
6353         (push_typelist): Update.
6354         * parse.c (pop_typelist): Return a std::vector.
6355         (push_typelist): Take a std::vector.
6356         (follow_types): Update.  Do not free args.
6357         (type_stack_cleanup): Remove.
6358         * c-exp.y (struct c_parse_state): New.
6359         (cpstate): New global.
6360         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6361         (nonempty_typelist): Update.
6362         (func_mod): Create a new vector.
6363         (c_parse): Create a c_parse_state.
6364         (check_parameter_typelist): Do not delete params.
6365         (function_method): Update.  Do not delete type_list.
6366
6367 2019-01-06  Tom Tromey  <tom@tromey.com>
6368
6369         PR gdb/28155:
6370         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6371         check_typedef.
6372         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6373         (print_return_value): Likewise.
6374
6375 2019-01-05  Tom Tromey  <tom@tromey.com>
6376
6377         * contrib/cleanup_check.py: Remove.
6378         * contrib/gcc-with-excheck: Remove.
6379         * contrib/exsummary.py: Remove.
6380         * contrib/excheck.py: Remove.
6381
6382 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6383
6384         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6385         NULL. Initialize tpprev to NULL instead of assigning it
6386         to NULL on the next statement.
6387         * windows-nat.c (windows_delete_thread): Remove check for
6388         main_thread_id before printing thread exit notifications.
6389         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6390         Remove thread ID check against main_thread_id.
6391         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6392         windows_delete_thread.
6393         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6394
6395 2019-01-04  Tom Tromey  <tom@tromey.com>
6396
6397         * compile/compile.c (_initialize_compile): Use upper case for
6398         metasyntactic variables.
6399         * symmisc.c (_initialize_symmisc): Use upper case for
6400         metasyntactic variables.
6401         * psymtab.c (_initialize_psymtab): Use upper case for
6402         metasyntactic variables.
6403         * demangle.c (demangle_command): Use upper case for metasyntactic
6404         variables.
6405         (_initialize_demangler): Likewise.
6406         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6407         variables.
6408
6409 2019-01-03  Tom Tromey  <tom@tromey.com>
6410
6411         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6412
6413 2019-01-03  Tom Tromey  <tom@tromey.com>
6414
6415         * python/py-symtab.c (salpy_str): Update.
6416         (struct salpy_sal_object) <symtab>: Now a PyObject.
6417         (salpy_dealloc): Update.
6418         (del_objfile_sal): Use gdbpy_ref.
6419
6420 2019-01-03  Tom Tromey  <tom@tromey.com>
6421
6422         * python/py-type.c (convert_field): Use new_reference.  Return
6423         gdbpy_ref.
6424         (make_fielditem): Return gdbpy_ref.
6425         (typy_fields): Update.
6426         (typy_getitem): Update.
6427         (field_name): Return gdbpy_ref.  Use new_reference.
6428         (typy_iterator_iternext): Update.
6429
6430 2019-01-03  Tom Tromey  <tom@tromey.com>
6431
6432         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6433
6434 2019-01-03  Tom Tromey  <tom@tromey.com>
6435
6436         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6437         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6438         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6439         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6440         (pspy_set_type_printers): Likewise.
6441         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6442         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6443         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6444         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6445         (objfpy_set_type_printers): Likewise.
6446
6447 2019-01-03  Tom Tromey  <tom@tromey.com>
6448
6449         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6450         (gdbpy_print_stack): Use gdbpy_err_fetch.
6451         * python/python-internal.h (class gdbpy_err_fetch): New class.
6452         (class gdbpy_enter) <m_error_type, m_error_value,
6453         m_error_traceback>: Remove.
6454         <m_error>: New member.
6455         (gdbpy_exception_to_string): Don't declare.
6456         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6457         * python/py-value.c (convert_value_from_python): Use
6458         gdbpy_err_fetch.
6459         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6460         gdbpy_exception_to_string.
6461         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6462         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6463         gdbpy_err_fetch.
6464
6465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6466
6467         * linux-nat.c (delete_lwp_cleanup): Delete.
6468         (struct lwp_deleter): New struct.
6469         (lwp_info_up): New typedef.
6470         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6471         lwp_info_up.
6472
6473 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * linux-fork.c (class scoped_switch_fork_info): New class.
6476         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6477
6478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * valops.c (find_overload_match): Remove use of null_cleanup, and
6481         calls to do_cleanups.
6482
6483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * compile/compile-cplus-types.c
6486         (compile_cplus_instance::decl_name): Handle changes to
6487         cp_func_name.
6488         * cp-support.c (cp_func_name): Update header comment, update
6489         return type.
6490         * cp-support.h (cp_func_name): Update return type in declaration.
6491         * valops.c (find_overload_match): Move temp_func local to top
6492         level of function and change its type.  Use temp_func to hold and
6493         delete temporary string obtained from cp_func_name.
6494
6495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6496
6497         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6498         gdb::char_vector, remove cleanup, and update uses of `msg`.
6499
6500 2019-01-03  Jim Wilson  <jimw@sifive.com>
6501
6502         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6503
6504 2019-01-02  Tom Tromey  <tom@tromey.com>
6505
6506         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6507         (tdesc_parse_xml): Remove cleanups.
6508         * target-descriptions.h (make_cleanup_free_target_description):
6509         Don't declare.
6510         (target_desc_deleter): New struct.
6511         (target_desc_up): New typedef.
6512         * target-descriptions.c (target_desc_deleter::operator()): Rename
6513         from free_target_description.
6514         (make_cleanup_free_target_description): Remove.
6515
6516 2019-01-02  Tom Tromey  <tom@tromey.com>
6517
6518         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6519         constructor, destructor.
6520         (linespec_parser): Remove typedef.
6521         (~linespec_parser): Rename from linespec_parser_delete.
6522         (linespec_lex_to_end, linespec_complete_label)
6523         (linespec_complete): Update.
6524         (decode_line_full): Remove cleanups.
6525         (decode_line_1): Update.
6526
6527 2019-01-02  Tom Tromey  <tom@tromey.com>
6528
6529         * python/python-internal.h (inferior_to_inferior_object): Change
6530         return type.
6531         * python/py-exitedevent.c (create_exited_event_object): Update.
6532         * python/py-inferior.c (inferior_to_inferior_object): Return
6533         gdbpy_ref.
6534         (python_new_inferior, python_inferior_deleted)
6535         (thread_to_thread_object, delete_thread_object)
6536         (build_inferior_list, gdbpy_selected_inferior): Update.
6537         * python/py-infthread.c (create_thread_object): Update.  Also fail
6538         if inferior_to_inferior_object fails.
6539
6540 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6541
6542         * inferior.h (class inferior) <displaced_step_state>: New field.
6543         * infrun.h (struct displaced_step_state): Move here from
6544         infrun.c.  Initialize fields, add constructor.
6545         <inf>: Remove field.
6546         <reset>: New method.
6547         * infrun.c (struct displaced_step_inferior_state): Move to
6548         infrun.h.
6549         (displaced_step_inferior_states): Remove.
6550         (get_displaced_stepping_state): Adust.
6551         (displaced_step_in_progress_any_inferior): Adjust.
6552         (displaced_step_in_progress_thread): Adjust.
6553         (displaced_step_in_progress): Adjust.
6554         (add_displaced_stepping_state): Remove.
6555         (get_displaced_step_closure_by_addr): Adjust.
6556         (remove_displaced_stepping_state): Remove.
6557         (infrun_inferior_exit): Call displaced_step_state.reset.
6558         (use_displaced_stepping): Don't check for NULL.
6559         (displaced_step_prepare_throw): Call
6560         get_displaced_stepping_state.
6561         (displaced_step_fixup): Don't check for NULL.
6562         (prepare_for_detach): Don't check for NULL.
6563
6564 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6565
6566         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6567          in case of call that did not complete.
6568
6569 2019-01-02  Andrey Utkin  <autkin@undo.io>
6570
6571         * symfile.c (find_separate_debug_file): Fix search of debug files for
6572         remote debuggee.
6573
6574 2019-01-02  Tom Tromey  <tom@tromey.com>
6575
6576         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6577         indentation.
6578         * python/py-frame.c (frapy_older): Remove cast.
6579         (frapy_newer): Likewise.
6580         * python/py-breakpoint.c (local_setattro): Remove cast.
6581         * python/py-arch.c (archpy_name): Remove local variable.
6582         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6583
6584 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6585
6586         * unittests/basic_string_view/element_access/char/empty.cc:
6587         Fix year range in copyright header.
6588
6589 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6592         Delete.
6593         <operator==>: Update with for removed field.
6594         <hash>: Likewise.
6595         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6596         <isa_features>: ...this.
6597         <abi_features>: New field.
6598         (riscv_isa_flen): Update comment.
6599         (riscv_abi_xlen): New declaration.
6600         (riscv_abi_flen): New declaration.
6601         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6602         isa_features.
6603         (riscv_abi_xlen): New function.
6604         (riscv_isa_flen): Update to get answer from isa_features.
6605         (riscv_abi_flen): New function.
6606         (riscv_has_fp_abi): Update to get answer from abi_features.
6607         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6608         xlen and flen.
6609         (riscv_call_info) <xlen, flen>: Update comment.
6610         (riscv_call_arg_struct): Remove invalid assertions
6611         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6612         is removed.
6613         (riscv_gdbarch_init): Gather isa features and abi features
6614         separately, ensure both match on the gdbarch when reusing an old
6615         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6616         a target with 64-bit float hardware.
6617
6618 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6619
6620         * source.c (search_command_helper): Stop reverse search
6621         when line 1 has been searched.
6622
6623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6624
6625         * record-full.c (record_full_base_target::close): Rewrite
6626         record_full_core_buf_list free logic.
6627
6628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6629
6630         * break-catch-syscall.c (print_one_catch_syscall): xfree
6631         the last text.
6632
6633 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6634
6635         * top.c (print_gdb_version): Update Copyright year in version
6636         message.
6637
6638 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6639
6640         Update copyright year range in all GDB files.
6641
6642 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6643
6644         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6645
6646 For older changes see ChangeLog-2018.
6647 \f
6648 Local Variables:
6649 mode: change-log
6650 left-margin: 8
6651 fill-column: 74
6652 version-control: never
6653 coding: utf-8
6654 End:
6655