gdb/ChangeLog

   1 2019-10-02  Tom Tromey  <tromey@adacore.com>
   2
   3         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
   4         * ada-lang.c (lesseq_defined_than): Handle
   5         LOC_STATIC.
   6         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
   7         parameter.
   8         (dwarf2_has_info): Likewise.
   9         (new_symbol): Set maybe_copied on symbol when
  10         appropriate.
  11         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
  12         parameter.
  13         <can_copy>: New member.
  14         * elfread.c (record_minimal_symbol): Set maybe_copied
  15         on symbol when appropriate.
  16         (elf_symfile_read): Update call to dwarf2_has_info.
  17         * minsyms.c (lookup_minimal_symbol_linkage): New
  18         function.
  19         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
  20         * symtab.c (get_symbol_address, get_msymbol_address):
  21         New functions.
  22         * symtab.h (get_symbol_address, get_msymbol_address):
  23         Declare.
  24         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
  25         maybe_copied.
  26         (struct symbol, struct minimal_symbol) <maybe_copied>:
  27         New member.
  28
  29 2019-10-02  Tom Tromey  <tromey@adacore.com>
  30
  31         * source.c (struct current_source_location): New.
  32         (current_source_key): New global.
  33         (current_source_symtab, current_source_line)
  34         (current_source_pspace): Remove.
  35         (get_source_location): New function.
  36         (get_current_source_symtab_and_line)
  37         (set_default_source_symtab_and_line)
  38         (set_current_source_symtab_and_line)
  39         (clear_current_source_symtab_and_line, select_source_symtab)
  40         (info_source_command, print_source_lines_base)
  41         (info_line_command, search_command_helper, _initialize_source):
  42         Update.
  43
  44 2019-10-02  Tom Tromey  <tromey@adacore.com>
  45
  46         * source.c (select_source_symtab): Don't call
  47         decode_line_with_current_source.
  48
  49 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * symtab.c (lookup_global_symbol): Search global block.
  52
  53 2019-10-02  Tom Tromey  <tromey@adacore.com>
  54
  55         * coffread.c (process_coff_symbol): Update.
  56         * dwarf2read.c (var_decode_location, new_symbol): Update.
  57         * mdebugread.c (parse_symbol): Update.
  58         * objfiles.c (relocate_one_symbol): Update.
  59         * stabsread.c (define_symbol, fix_common_block)
  60         (scan_file_globals): Update.
  61         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
  62         (SET_SYMBOL_VALUE_ADDRESS): New macro.
  63         * xcoffread.c (process_xcoff_symbol): Update.
  64
  65 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
  66
  67         * MAINTAINERS: Update my email address.
  68
  69 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
  72         std::vector.
  73         (build_type_psymtabs_reader): Update for std::vector.
  74         (build_type_psymtab_dependencies): Likewise.
  75         * dwarf2read.h: Remove use of DEF_VEC_P.
  76         (typedef sig_type_ptr): Delete.
  77
  78 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * btrace.c (btrace_maint_clear): Update to handle change from VEC
  81         to std::vector.
  82         (btrace_maint_decode_pt): Likewise, and move allocation of the
  83         vector outside of the loop.
  84         (btrace_maint_update_packets): Update to handle change from VEC to
  85         std::vector.
  86         (btrace_maint_print_packets): Likewise.
  87         (maint_info_btrace_cmd): Likewise.
  88         * btrace.h: Remove use of DEF_VEC_O.
  89         (typedef btrace_pt_packet_s): Delete.
  90         (struct btrace_maint_info) <packets>: Change fromm VEC to
  91         std::vector.
  92         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
  93
  94 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
  97         make accesses into the vector constant references.
  98         (btrace_add_pc): Update for std::vector.
  99         (btrace_stitch_bts): Likewise.
 100         (parse_xml_btrace_block): Likewise.
 101         (btrace_maint_update_packets): Likewise.
 102         (btrace_maint_print_packets): Likewise.
 103         (maint_info_btrace_cmd): Likewise.
 104         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 105         std::vector.
 106         (btrace_data::empty): Likewise.
 107         (btrace_data_append): Likewise.
 108         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 109         (typedef btrace_block_s): Delete.
 110         (struct btrace_block): Add constructor.
 111         (struct btrace_data_bts) <blocks>: Change to std::vector.
 112         * nat/linux-btrace.c (perf_event_read_bts): Update for
 113         std::vector.
 114         (linux_read_bts): Likewise.
 115
 116 2019-10-01  Tom Tromey  <tom@tromey.com>
 117
 118         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 119
 120 2019-10-01  Tom Tromey  <tom@tromey.com>
 121
 122         * stack.c (print_frame, info_frame_command_core): Use
 123         styled_string.
 124         * linux-thread-db.c (try_thread_db_load_1)
 125         (try_thread_db_load_from_pdir_1): Use styled_string.
 126         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 127         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 128         (maybe_print_unsupported_script_warning)
 129         (maybe_print_script_not_found_warning): Use styled_string.
 130         * ada-lang.c (user_select_syms): Use styled_string.
 131
 132 2019-10-01  Tom Tromey  <tom@tromey.com>
 133
 134         * p-lang.c (pascal_printstr): Use metadata style.
 135         * value.c (show_convenience): Use metadata style.
 136         * valprint.c (valprint_check_validity, val_print_optimized_out)
 137         (val_print_not_saved, val_print_unavailable)
 138         (val_print_invalid_address, generic_val_print, val_print)
 139         (value_check_printable, val_print_array_elements): Use metadata
 140         style.
 141         * ui-out.h (class ui_out) <field_fmt>: New overload.
 142         <do_field_fmt>: Add style parameter.
 143         * ui-out.c (ui_out::field_fmt): New overload.
 144         * typeprint.c (type_print_unknown_return_type)
 145         (val_print_not_allocated, val_print_not_associated): Use metadata
 146         style.
 147         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 148         parameter.
 149         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 150         * tracepoint.c (tvariables_info_1): Use metadata style.
 151         * stack.c (print_frame_arg, print_frame_info, print_frame)
 152         (info_frame_command_core): Use metadata style.
 153         * skip.c (info_skip_command): Use metadata style.
 154         * rust-lang.c (rust_print_enum): Use metadata style.
 155         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 156         metadata style.
 157         * python/py-framefilter.c (py_print_single_arg): Use metadata
 158         style.
 159         * printcmd.c (do_one_display, print_variable_and_value): Use
 160         metadata style.
 161         * p-valprint.c (pascal_val_print)
 162         (pascal_object_print_value_fields): Use metadata style.
 163         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 164         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 165         parameter.
 166         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 167         * m2-valprint.c (m2_print_long_set): Use metadata style.
 168         * m2-typeprint.c (m2_print_type): Use metadata style.
 169         * infcmd.c (print_return_value_1): Use metadata style.
 170         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 171         * f-valprint.c (info_common_command_for_block): Use metadata
 172         style.
 173         * f-typeprint.c (f_type_print_base): Use metadata style.
 174         * expprint.c (print_subexp_standard): Use metadata style.
 175         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 176         * cli/cli-style.h (class cli_style_option): Add constructor.
 177         (metadata_style): Declare.
 178         * cli/cli-style.c (metadata_style): New global.
 179         (_initialize_cli_style): Register metadata style.
 180         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 181         parameter.
 182         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 183         * c-typeprint.c (c_type_print_base_struct_union)
 184         (c_type_print_base_1): Use metadata style.
 185         * breakpoint.c (watchpoint_value_print)
 186         (print_one_breakpoint_location): Use metadata style.
 187         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 188         style.
 189         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 190         style.
 191         * ada-valprint.c (val_print_packed_array_elements, printstr)
 192         (print_field_values, ada_val_print_ref, ada_val_print): Use
 193         metadata style.
 194         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 195         style.
 196         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 197         style.
 198         * ada-lang.c (user_select_syms): Use metadata style.
 199
 200 2019-10-01  Tom Tromey  <tom@tromey.com>
 201
 202         * cli/cli-cmds.c (pwd_command): Style output.
 203
 204 2019-10-01  Pedro Alves  <palves@redhat.com>
 205             Tom Tromey  <tom@tromey.com>
 206
 207         * symtab.c (print_symbol_info): Use %ps.
 208         (print_msymbol_info): Use %ps.
 209         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 210         * printcmd.c (print_variable_and_value): Use %ps.
 211         * macrocmd.c (show_pp_source_pos): Use %ps.
 212         * infrun.c (print_exited_reason): Use ui_out::message.
 213         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 214         (describe_other_breakpoints): Use ui_out::message and new
 215         formats.
 216         (say_where): Use new formats.
 217         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 218         and new formats.
 219
 220 2019-10-01  Pedro Alves  <palves@redhat.com>
 221             Tom Tromey  <tom@tromey.com>
 222
 223         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 224         (test_gdb_formats): New function.
 225         (run_tests): Call it.
 226         (test_format_specifier): Update.
 227         * utils.h (fputs_filtered): Update comment.
 228         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 229         (fputs_styled_unfiltered): Declare.
 230         * utils.c (fputs_styled_unfiltered): New function.
 231         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 232         (vfprintf_filtered): Update.
 233         (vfprintf_unfiltered, vprintf_filtered): Update.
 234         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 235         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 236         disallow_ui_out_field>: New constants.
 237         (enum class field_kind): New.
 238         (struct base_field_s, struct signed_field_s): New.
 239         (signed_field): New function.
 240         (struct string_field_s): New.
 241         (string_field): New function.
 242         (struct styled_string_s): New.
 243         (styled_string): New function.
 244         (class ui_out) <message>: Add comment.
 245         <vmessage, call_do_message>: New methods.
 246         <do_message>: Add style parameter.
 247         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 248         methods.
 249         (ui_out::message): Rewrite.
 250         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 251         parameter.
 252         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 253         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 254         gdb_extensions parameter.
 255         (class format_piece): Add parameter to constructor.
 256         (n_int_args): New field.
 257         * gdbsupport/format.c (format_pieces::format_pieces): Add
 258         gdb_extensions parameter.  Handle '*'.
 259         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 260         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 261         vfprintf_styled_no_gdbfmt.
 262         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 263         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 264         unfiltered output.
 265         * ui-style.h (struct ui_file_style) <ptr>: New method.
 266
 267 2019-10-01  Tom Tromey  <tom@tromey.com>
 268
 269         * unittests/format_pieces-selftests.c: Update.  Add final format.
 270         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 271         empty literal pieces.
 272
 273 2019-10-01  Tom Tromey  <tom@tromey.com>
 274
 275         * ui-out.h (enum class ui_out_style_kind): Remove.
 276         (class ui_out) <field_string, field_stsream, do_field_string>:
 277         Change type of "style".
 278         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 279         (ui_out::field_string): Update.
 280         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 281         of "style".
 282         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 283         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 284         * stack.c (print_frame_arg, print_frame_info, print_frame):
 285         Update.
 286         * source.c (print_source_lines_base): Update.
 287         * solib.c (info_sharedlibrary_command): Update.
 288         * skip.c (info_skip_command): Update.
 289         * record-btrace.c (btrace_call_history_src_line)
 290         (btrace_call_history): Update.
 291         * python/py-framefilter.c (py_print_frame): Update.
 292         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 293         "style".
 294         * mi/mi-out.c (mi_ui_out::do_table_header)
 295         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 296         (mi_ui_out::do_field_string): Update.
 297         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 298         Update.
 299         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 300         "style".
 301         * cli-out.c (cli_ui_out::do_table_header)
 302         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 303         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 304         (cli_ui_out::do_field_fmt): Update.
 305         * breakpoint.c (print_breakpoint_location): Update.
 306         (update_static_tracepoint): Update.
 307
 308 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 309
 310         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 311         conversion of gdb_datadir.
 312         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 313         remove not needed c_str ().
 314
 315 2019-09-30  Ali Tamur <tamur@google.com>
 316
 317         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 318         (dwarf2_string_attr): Likewise.
 319
 320 2019-09-30  Ali Tamur <tamur@google.com>
 321
 322         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 323         (process_full_type_unit): Likewise.
 324         (dump_die_shallow): Likewise.
 325         (cu_debug_loc_section): Likewise.
 326
 327 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 328
 329         * minsyms.c (compare_minimal_symbols): Rename to...
 330         (minimal_symbol_is_less_than): ...this, and adjust to STL
 331         conventions (return bool, take arguments as references)
 332         (minimal_symbol_reader::install): Call std::sort instead
 333         of qsort.
 334
 335 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 336
 337         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 338         hash and why.
 339         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 340         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 341
 342 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 343
 344         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 345         * psympriv.h (add_psymbol_to_list): Move comment here and update
 346         it.
 347
 348 2019-09-29  Tom de Vries  <tdevries@suse.de>
 349
 350         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 351         Use $tmpdir/$(basename "$output_file").dwz instead of
 352         "${output_file}.dwz".
 353
 354 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 355
 356         PR gdb/25045
 357         * hppa-linux-nat.c: Include gdbarch.h.
 358
 359 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 360
 361         * blockframe.c (find_pc_partial_function): Change return type to bool.
 362         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 363         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 364         (stub_gnu_ifunc_resolve_name): Likewise.
 365         * symtab.c (compare_filenames_for_search): Likewise.
 366         (compare_glob_filenames_for_search): Likewise.
 367         (matching_obj_sections): Likewise.
 368         (symbol_matches_domain): Likewise.
 369         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 370         (find_line_pc): Change return type to bool.
 371         (find_line_pc_range): Likewise.
 372         (producer_is_realview): Likewise.
 373         * symtab.h (symbol_matches_domain): Likewise.
 374         (find_pc_partial_function): Likewise.
 375         (find_pc_line_pc_range): Likewise.
 376         (in_gnu_ifunc_stub): Likewise.
 377         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 378         (find_line_pc): Likewise.
 379         (find_line_pc_range): Likewise.
 380         (matching_obj_sections): Likewise.
 381         (find_line_symtab): Change out parameter to bool.
 382         (producer_is_realview): Change return type to bool.
 383         (compare_filenames_for_search): Likewise.
 384         (compare_glob_filenames_for_search): Likewise.
 385
 386 2019-09-26  Tom Tromey  <tom@tromey.com>
 387
 388         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 389         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 390         * gdb_usleep.h: Remove.
 391         * gdb_usleep.c: Remove.
 392         * utils.c: Don't include gdb_usleep.h.
 393
 394 2019-09-26  Tom Tromey  <tromey@adacore.com>
 395
 396         * python/py-type.c (type_to_type_object): Call check_typedef
 397         for stub types.
 398
 399 2019-09-26  Tom Tromey  <tom@tromey.com>
 400
 401         * utils.h (initialize_utils): Don't declare.
 402         * top.c (gdb_init): Don't call initialize_utils.
 403         * utils.c (initialize_utils): Remove.  Move contents...
 404         (_initialize_utils): ... here.
 405
 406 2019-09-25  Tom Tromey  <tom@tromey.com>
 407
 408         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 409         * utils.h (make_hex_string): Don't declare.
 410         * utils.c (make_hex_string): Remove.
 411
 412 2019-09-24  Tom de Vries  <tdevries@suse.de>
 413
 414         PR gdb/23815
 415         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 416         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 417
 418 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 419
 420         * NEWS: Mention new simulator port for PRU.
 421
 422 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 423
 424         * ada-exp.y (write_object_remaining): Update.
 425         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 426         and eliminate the static buffer.
 427         (ada_decode_symbol): Update.
 428         (ada_la_decode): Update.
 429         (ada_sniff_from_mangled_name): Update.
 430         (is_valid_name_for_wild_match): Update.
 431         (ada_lookup_name_info::matches): Update and simplify.
 432         (name_matches_regex): Update.
 433         (ada_add_global_exceptions): Update.
 434         * ada-lang.h (ada_decode): Update signature.
 435         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 436         * dwarf-index-write.c (debug_names::insert): Update.
 437
 438 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 439
 440         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 441         formatting.
 442
 443 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 444
 445         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 446         Change "nonzero" to "true" in documentation.
 447
 448 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 451         (_initialize_darwin_solib): Don't set
 452         darwin_so_ops.lookup_lib_global_symbol.
 453         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 454         set_gdbarch_iterate_over_objfiles_in_search_order.
 455         (elf_lookup_lib_symbol): Rename to...
 456         (svr4_iterate_over_objfiles_in_search_order): this, and update
 457         to iterate semantics.
 458         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 459         * solib.c (solib_global_lookup): Remove.
 460         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 461         (solib_global_lookup): Remove.
 462         * symtab.c (lookup_global_or_static_symbol): Remove call to
 463         solib_global_lookup.
 464
 465 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 466
 467         * NEWS: Move entries about default MI version now being
 468         version 3, and about the GDB/MI fix for multi-location
 469         breakpoints to the "since GDB 8.3" section.
 470
 471 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 472
 473         GDB 8.3.1 released.
 474
 475 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 476
 477         * NEWS: Mention that Cell/B.E. debugging support was removed.
 478         * MAINTAINERS: Remove spu target.
 479
 480         * config/djgpp/fnchange.lst: Remove entries for removed files.
 481
 482         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 483         spu-multiarch.o, and spu-tdep.o.
 484         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 485         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 486         spu-multiarch.c, and spu-tdep.c.
 487         * spu-linux-nat.c: Remove file.
 488         * spu-multiarch.c: Remove file.
 489         * spu-tdep.c: Remove file.
 490         * spu-tdep.h: Remove file.
 491         * solib-spu.c: Remove file.
 492         * solib-spu.h: Remove file.
 493
 494         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 495         * configure.nat (spu-linux): Remove.
 496         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 497         solib-multiarch.o from gdb_target_obs.
 498         (spu*-*-*): Remove.
 499
 500         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 501         feature flag.
 502         (ppc_linux_no_features): Update.
 503         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 504         Cell/B.E. support.
 505         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 506         (tdesc_powerpc_cell64l): Likewise.
 507         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 508         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 509         Cell/B.E. support.
 510         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 511         Do not include "features/rs6000/powerpc-cell32l.c" or
 512         "features/rs6000/powerpc-cell64l.c".
 513         (ppc_linux_spu_section): Remove.
 514         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 515         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 516         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 517         (ppc_linux_spe_context_lookup): Remove.
 518         (ppc_linux_spe_context_inferior_created): Remove.
 519         (ppc_linux_spe_context_solib_loaded): Remove.
 520         (ppc_linux_spe_context_solib_unloaded): Remove.
 521         (ppc_linux_spe_context): Remove.
 522         (struct ppu2spu_cache): Remove.
 523         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 524         (struct ppu2spu_data): Remove.
 525         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 526         ppu2spu_unwind): Remove.
 527         (ppc_linux_init_abi): Remove Cell/B.E. support.
 528         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 529
 530         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 531         (rs6000/powerpc-cell64l-expedite): Likewise
 532         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 533         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 534         rs6000/powerpc-cell64l.xml.
 535         * features/rs6000/powerpc-cell32l.xml: Remove.
 536         * features/rs6000/powerpc-cell64l.xml: Likewise.
 537         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 538         * features/rs6000/powerpc-cell64l.c: Likewise.
 539         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 540         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 541         * regformats/reg-spu.dat: Remove.
 542
 543         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 544         * corelow.c (struct spuid_list): Remove.
 545         (add_to_spuid_list): Remove.
 546         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 547         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 548         (remote_protocol_features): Remove associated entries.
 549         (_initialize_remote): No longer initialize them.
 550         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 551         * linux-nat.c (SPUFS_MAGIC): Remove.
 552         (linux_proc_xfer_spu): Remove.
 553         (spu_enumerate_spu_ids): Remove.
 554         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 555         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 556         (linux_make_corefile_notes): No longer call it.
 557
 558         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 559         (cooked_write_test): Likewise.
 560
 561 2019-09-20  Tom Tromey  <tom@tromey.com>
 562
 563         * NEWS: Mention case-sensitivity of TUI commands.
 564         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 565         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 566         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 567
 568 2019-09-20  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-source.c (tui_source_window::set_contents): Use
 571         make_unique_xstrdup.
 572         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 573         make_unique_xstrdup.
 574
 575 2019-09-20  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-data.c: Remove separator comments.
 578         * tui/tui-layout.c: Remove separator comments.
 579         * tui/tui-win.c: Remove separator comments.
 580         * tui/tui-wingeneral.c: Remove separator comments.
 581
 582 2019-09-20  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui.h (strcat_to_buf): Don't declare.
 585         * tui/tui.c (strcat_to_buf): Remove.
 586
 587 2019-09-20  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 590         from "fullname".
 591         * tui/tui-source.c (tui_source_window::set_contents)
 592         (tui_source_window::location_matches_p)
 593         (tui_source_window::maybe_update): Update.
 594
 595 2019-09-20  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 598         Update.
 599         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 600         prefix.
 601         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 602         (tui_data_window::line_from_reg_element_no)
 603         (tui_data_window::first_reg_element_no_inline)
 604         (tui_data_window::show_registers)
 605         (tui_data_window::show_register_group)
 606         (tui_data_window::display_registers_from)
 607         (tui_data_window::display_registers_from_line)
 608         (tui_data_window::first_data_item_displayed)
 609         (tui_data_window::delete_data_content_windows)
 610         (tui_data_window::erase_data_content)
 611         (tui_data_window::do_scroll_vertical)
 612         (tui_data_window::refresh_window)
 613         (tui_data_window::check_register_values): Update.
 614
 615 2019-09-20  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 618         (struct tui_locator_window) <full_name, proc_name>: Now
 619         std::string.
 620         * tui/tui-stack.c (tui_locator_window::make_status_line)
 621         (tui_locator_window::set_locator_fullname)
 622         (tui_locator_window::set_locator_info): Update.
 623         * tui/tui-source.c (tui_source_window::set_contents)
 624         (tui_source_window::showing_source_p): Update.
 625
 626 2019-09-20  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 629         Don't call tui_locator_win_info_ptr.
 630
 631 2019-09-20  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 634
 635 2019-09-20  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 638         height for locator.
 639         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 640         * tui/tui-layout.c (show_source_disasm_command, show_data)
 641         (show_source_or_disasm_and_command): Use 1 as height for locator.
 642
 643 2019-09-20  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui.c (tui_enable): Update.
 646         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 647         Update.
 648         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 649         Update.
 650         * tui/tui-data.c (win_resized): Now bool.
 651         (tui_win_resized): Return bool.
 652         (tui_set_win_resized_to): Accept a bool.
 653
 654 2019-09-20  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 657         Change type of "refresh_values_only".
 658         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 659         type of "refresh_values_only".
 660
 661 2019-09-20  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 664         std::string.
 665         (tui_disassemble): Add "pos" parameter.
 666         (tui_disasm_window::set_contents): Simplify.
 667
 668 2019-09-20  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-winsource.h (struct tui_source_window_base)
 671         <show_source_content>: Now private.
 672         * tui/tui-winsource.c
 673         (tui_source_window_base::show_source_content): Don't handle empty
 674         content case.
 675
 676 2019-09-20  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-layout.c (show_source_disasm_command)
 679         (show_source_or_disasm_and_command): Don't call
 680         show_source_content.
 681
 682 2019-09-20  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 685         Declare.
 686         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 687         from tui_make_status_line.
 688         (tui_locator_window::rerender): Update.
 689
 690 2019-09-20  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 693         (tui_locator_window::rerender): Update.
 694
 695 2019-09-20  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.h (struct tui_source_window_base)
 698         <~tui_source_window_base>: Don't declare.
 699         <fullname>: Remove.
 700         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 701         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 702         member.
 703         * tui/tui-source.c (tui_source_window::set_contents): Update.
 704         (tui_source_window::location_matches_p)
 705         (tui_source_window::maybe_update): Update.
 706
 707 2019-09-20  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-winsource.h (~tui_source_element): Remove.
 710         (tui_source_element): Update.
 711         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 712         * tui/tui-winsource.c (tui_show_source_line): Update.
 713         * tui/tui-source.c (tui_source_window::set_contents): Update.
 714         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 715
 716 2019-09-20  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 719         declare.
 720         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 721         tui_clear_source_windows_detail.
 722         * tui/tui-winsource.h (struct tui_source_window_base)
 723         <clear_detail>: Don't declare.
 724         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 725         Remove.
 726         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 727
 728 2019-09-20  Tom Tromey  <tromey@adacore.com>
 729
 730         PR ada/24919:
 731         * block.c (contained_in): Fix final return value.
 732
 733 2019-09-20  Alan Modra  <amodra@gmail.com>
 734
 735         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 736         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 737         (read_indirect_string_from_dwz): Use bfd accessor.
 738         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 739         * machoread.c (macho_symfile_read_all_oso): Likewise.
 740         * solib.c (solib_bfd_open): Likewise.
 741
 742 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 743
 744         * eval.c: Move declaration of overload_resolution to...
 745         * value.h: ...here.
 746
 747 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 748
 749         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 750         * arm-linux-tdep.c: Likewise.
 751         * arm-nbsd-nat.c: Likewise.
 752         * arm-tdep.h: Declare arm_apcs_32.
 753         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 754
 755 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 756
 757         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 758         * dwarf2read.h: Declare dwarf_always_disassemble.
 759
 760 2019-09-19  Tom de Vries  <tdevries@suse.de>
 761
 762         PR gdb/25009
 763         * source-cache.c (source_cache::ensure): Catch exception thrown during
 764         construction of the highlighter.
 765
 766 2019-09-18  Alan Modra  <amodra@gmail.com>
 767
 768         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 769         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 770         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 771         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 772         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 773         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 774         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 775         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 776         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 777         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 778         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 779         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 780         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 781         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 782         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 783         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 784         * mi/mi-interp.c: Update throughout for bfd section macro and
 785         function changes.
 786         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 787         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 788
 789 2019-09-18  Tom Tromey  <tom@tromey.com>
 790
 791         * NEWS: Add entry.
 792         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 793         call rl_initialize.
 794         (tui_enable): Do not call rl_initialize.
 795
 796 2019-09-18  Christian Groessler  <chris@groessler.org>
 797
 798         * alpha-linux-nat.c: Include gdbarch.h.
 799
 800 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 801
 802         * ui-file.c: Include cli/cli-style.h.
 803         (term_cli_styling): Remove cli_styling declaration.
 804
 805 2019-09-18  Alan Modra  <amodra@gmail.com>
 806
 807         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 808         to bfd_asymbol_section.
 809
 810 2019-09-18  Alan Modra  <amodra@gmail.com>
 811
 812         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 813         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 814         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 815
 816 2019-09-18  Alan Modra  <amodra@gmail.com>
 817
 818         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 819         * spu-linux-nat.c (spu_bfd_open): Likewise.
 820
 821 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 822
 823         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 824         to bool to match definition in dwarf2read.c.
 825
 826 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 829         (print_signatures): Likewise.
 830         (trust_pad_over_xvs): Likewise.
 831         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 832         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 833         * arm-linux-nat.c (arm_apcs_32): Likewise.
 834         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 835         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 836         * arm-tdep.c (arm_debug): Likewise.
 837         (arm_apcs_32): Likewise.
 838         * auto-load.c (debug_auto_load): Likewise.
 839         (auto_load_gdb_scripts): Likewise.
 840         (global_auto_load): Likewise.
 841         (auto_load_local_gdbinit): Likewise.
 842         (auto_load_local_gdbinit_loaded): Likewise.
 843         * auto-load.h (global_auto_load): Likewise.
 844         (auto_load_local_gdbinit): Likewise.
 845         (auto_load_local_gdbinit_loaded): Likewise.
 846         * breakpoint.c (disconnected_dprintf): Likewise.
 847         (breakpoint_proceeded): Likewise.
 848         (automatic_hardware_breakpoints): Likewise.
 849         (always_inserted_mode): Likewise.
 850         (target_exact_watchpoints): Likewise.
 851         (_initialize_breakpoint): Update.
 852         * breakpoint.h (target_exact_watchpoints): Change to bool.
 853         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 854         * cli/cli-cmds.c (trace_commands): Likewise.
 855         * cli/cli-cmds.h (trace_commands): Likewise.
 856         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 857         to bool*.
 858         * cli/cli-logging.c (logging_overwrite): Change to bool.
 859         (logging_redirect): Likewise.
 860         (debug_redirect): Likewise.
 861         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 862         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 863         to bool.
 864         <boolean_option_def>: Update.
 865         (struct flag_option_def): Change default type of Context to bool
 866         from int.
 867         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 868         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 869         (get_setshow_command_value_string): Likewise.
 870         * cli/cli-style.c (cli_styling): Change to bool.
 871         (source_styling): Likewise.
 872         * cli/cli-style.h (source_styling): Likewise.
 873         (cli_styling): Likewise.
 874         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 875         to bool.
 876         * command.h (var_types): Update comment.
 877         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 878         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 879         bool.
 880         (debug_compile_cplus_scopes): Likewise.
 881         * compile/compile-internal.h (compile_debug): Likewise.
 882         * compile/compile.c (compile_debug): Likewise.
 883         (struct compile_options) <raw>: Likewise.
 884         * cp-support.c (catch_demangler_crashes): Likewise.
 885         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 886         (usr_cmd_cris_dwarf2_cfi): Likewise.
 887         * csky-tdep.c (csky_debug): Likewise.
 888         * darwin-nat.c (enable_mach_exceptions): Likewise.
 889         * dcache.c (dcache_enabled_p): Likewise.
 890         * defs.h (info_verbose): Likewise.
 891         * demangle.c (demangle): Likewise.
 892         (asm_demangle): Likewise.
 893         * dwarf-index-cache.c (debug_index_cache): Likewise.
 894         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 895         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 896         * dwarf2read.c (check_physname): Likewise.
 897         (use_deprecated_index_sections): Likewise.
 898         (dwarf_always_disassemble): Likewise.
 899         * eval.c (overload_resolution): Likewise.
 900         * event-top.c (set_editing_cmd_var): Likewise.
 901         (exec_done_display_p): Likewise.
 902         * event-top.h (set_editing_cmd_var): Likewise.
 903         (exec_done_display_p): Likewise.
 904         * exec.c (write_files): Likewise.
 905         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 906         (debug_fbsd_nat): Likewise.
 907         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 908         Likewise.
 909         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 910         <backtrace_past_entry> Likewise.
 911         * gdb-demangle.h (demangle): Likewise.
 912         (asm_demangle): Likewise.
 913         * gdb_bfd.c (bfd_sharing): Likewise.
 914         * gdbcore.h (write_files): Likewise.
 915         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 916         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 917         * gdbthread.h (print_thread_events): Likewise.
 918         * gdbtypes.c (opaque_type_resolution): Likewise.
 919         (strict_type_checking): Likewise.
 920         * gnu-nat.c (gnu_debug_flag): Likewise.
 921         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 922         * guile/scm-param.c (pascm_variable): Add boolval.
 923         (add_setshow_generic): Update.
 924         (pascm_param_value): Update.
 925         (pascm_set_param_value_x): Update.
 926         * hppa-tdep.c (hppa_debug): Change to bool..
 927         * infcall.c (may_call_functions_p): Likewise.
 928         (coerce_float_to_double_p): Likewise.
 929         (unwind_on_signal_p): Likewise.
 930         (unwind_on_terminating_exception_p): Likewise.
 931         * infcmd.c (startup_with_shell): Likewise.
 932         * inferior.c (print_inferior_events): Likewise.
 933         * inferior.h (startup_with_shell): Likewise.
 934         (print_inferior_events): Likewise.
 935         * infrun.c (step_stop_if_no_debug): Likewise.
 936         (detach_fork): Likewise.
 937         (debug_displaced): Likewise.
 938         (disable_randomization): Likewise.
 939         (non_stop): Likewise.
 940         (non_stop_1): Likewise.
 941         (observer_mode): Likewise.
 942         (observer_mode_1): Likewise.
 943         (set_observer_mode): Update.
 944         (sched_multi): Change to bool.
 945         * infrun.h (debug_displaced): Likewise.
 946         (sched_multi): Likewise.
 947         (step_stop_if_no_debug): Likewise.
 948         (non_stop): Likewise.
 949         (disable_randomization): Likewise.
 950         * linux-tdep.c (use_coredump_filter): Likewise.
 951         (dump_excluded_mappings): Likewise.
 952         * linux-thread-db.c (auto_load_thread_db): Likewise.
 953         (check_thread_db_on_load): Likewise.
 954         * main.c (captured_main_1): Update.
 955         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 956         xx2_opt, boolean_opt>: Change to bool.
 957         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 958         * maint.c (maintenance_profile_p): Likewise.
 959         (per_command_time): Likewise.
 960         (per_command_space): Likewise.
 961         (per_command_symtab): Likewise.
 962         * memattr.c (inaccessible_by_default): Likewise.
 963         * mi/mi-main.c (mi_async): Likewise.
 964         (mi_async_1): Likewise.
 965         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 966         * nat/fork-inferior.h (startup_with_shell): Likewise.
 967         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 968         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 969         * nios2-tdep.c (nios2_debug): Likewise.
 970         * or1k-tdep.c (or1k_debug): Likewise.
 971         * parse.c (parser_debug): Likewise.
 972         * parser-defs.h (parser_debug): Likewise.
 973         * printcmd.c (print_symbol_filename): Likewise.
 974         * proc-api.c (procfs_trace): Likewise.
 975         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 976         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 977         (set_parameter_value): Update.
 978         (add_setshow_generic): Update.
 979         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 980         to bool*.
 981         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 982         int*.
 983         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 984         * record-btrace.c (record_btrace_target::store_registers): Update.
 985         * record-full.c (record_full_memory_query): Change to bool.
 986         (record_full_stop_at_limit): Likewise.
 987         * record-full.h (record_full_memory_query): Likewise.
 988         * remote-notif.c (notif_debug): Likewise.
 989         * remote-notif.h (notif_debug): Likewise.
 990         * remote.c (use_range_stepping): Likewise.
 991         (interrupt_on_connect): Likewise.
 992         (remote_break): Likewise.
 993         * ser-tcp.c (tcp_auto_retry): Likewise.
 994         * ser-unix.c (serial_hwflow): Likewise.
 995         * skip.c (debug_skip): Likewise.
 996         * solib-aix.c (solib_aix_debug): Likewise.
 997         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 998         (spu_auto_flush_cache_p): Likewise.
 999         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1000         Likewise.
1001         (struct info_print_options) <quiet>: Likewise.
1002         * symfile-debug.c (debug_symfile): Likewise.
1003         * symfile.c (auto_solib_add): Likewise.
1004         (separate_debug_file_debug): Likewise.
1005         * symfile.h (auto_solib_add): Likewise.
1006         (separate_debug_file_debug): Likewise.
1007         * symtab.c (basenames_may_differ): Likewise.
1008         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1009         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1010         (struct info_types_options) <quiet>: Likewise.
1011         * symtab.h (demangle): Likewise.
1012         (basenames_may_differ): Likewise.
1013         * target-dcache.c (stack_cache_enabled_1): Likewise.
1014         (code_cache_enabled_1): Likewise.
1015         * target.c (trust_readonly): Likewise.
1016         (may_write_registers): Likewise.
1017         (may_write_memory): Likewise.
1018         (may_insert_breakpoints): Likewise.
1019         (may_insert_tracepoints): Likewise.
1020         (may_insert_fast_tracepoints): Likewise.
1021         (may_stop): Likewise.
1022         (auto_connect_native_target): Likewise.
1023         (target_stop_and_wait): Update.
1024         (target_async_permitted): Change to bool.
1025         (target_async_permitted_1): Likewise.
1026         (may_write_registers_1): Likewise.
1027         (may_write_memory_1): Likewise.
1028         (may_insert_breakpoints_1): Likewise.
1029         (may_insert_tracepoints_1): Likewise.
1030         (may_insert_fast_tracepoints_1): Likewise.
1031         (may_stop_1): Likewise.
1032         * target.h (target_async_permitted): Likewise.
1033         (may_write_registers): Likewise.
1034         (may_write_memory): Likewise.
1035         (may_insert_breakpoints): Likewise.
1036         (may_insert_tracepoints): Likewise.
1037         (may_insert_fast_tracepoints): Likewise.
1038         (may_stop): Likewise.
1039         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1040         (make_thread_apply_all_options_def_group): Change argument from int*
1041         to bool*.
1042         (thread_apply_all_command): Update.
1043         (print_thread_events): Change to bool.
1044         * top.c (confirm): Likewise.
1045         (command_editing_p): Likewise.
1046         (history_expansion_p): Likewise.
1047         (write_history_p): Likewise.
1048         (info_verbose): Likewise.
1049         * top.h (confirm): Likewise.
1050         (history_expansion_p): Likewise.
1051         * tracepoint.c (disconnected_tracing): Likewise.
1052         (circular_trace_buffer): Likewise.
1053         * typeprint.c (print_methods): Likewise.
1054         (print_typedefs): Likewise.
1055         * utils.c (debug_timestamp): Likewise.
1056         (sevenbit_strings): Likewise.
1057         (pagination_enabled): Likewise.
1058         * utils.h (sevenbit_strings): Likewise.
1059         (pagination_enabled): Likewise.
1060         * valops.c (overload_resolution): Likewise.
1061         * valprint.h (struct value_print_options) <prettyformat_arrays,
1062         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1063         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1064         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1065         Likewise.
1066         * windows-nat.c (new_console): Likewise.
1067         (cygwin_exceptions): Likewise.
1068         (new_group): Likewise.
1069         (debug_exec): Likewise.
1070         (debug_events): Likewise.
1071         (debug_memory): Likewise.
1072         (debug_exceptions): Likewise.
1073         (useshell): Likewise.
1074         * windows-tdep.c (maint_display_all_tib): Likewise.
1075         * xml-support.c (debug_xml): Likewise.
1076
1077 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1078
1079         * source.c (prepare_path_for_appending): New function.
1080         (openp): Make use of new function.
1081         (find_and_open_source): Search for the compilation directory and
1082         source file as a relative path beneath the directory search path.
1083
1084 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * source-cache.c (source_cache::get_line_charpos): Catch
1087         exceptions and return false, this matches the behaviour documented
1088         in the header file.
1089
1090 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1091
1092         * ada-tasks.c (info_task): Remove quoting of the task's name.
1093
1094 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1095
1096         * symfile.c (auto_solib_add): Replace comment with a reference
1097         to the header file.
1098
1099 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1100
1101         * NEWS: Mention that gdb can now be compiled with Python 3
1102         on Windows.
1103
1104 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * maint.c (maint_print_section_data::maint_print_section_data):
1107         Force use of 'float log10 (float)' by casting the argument to
1108         float.
1109
1110 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * maint.c: Add 'cmath' include.
1113         (struct maint_print_section_data): New structure.
1114         (print_section_index): New function.
1115         (print_bfd_section_info): Add header comment, small whitespace
1116         cleanup, and update to call new print_section_index function.
1117         (print_objfile_section_info): Likewise.
1118         (maint_obj_section_from_bfd_section): New function.
1119         (print_bfd_section_info_maybe_relocated): New function.
1120         (maintenance_info_sections): Add header comment, always use
1121         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1122
1123 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1126         inner scope, add check that the objfile has psymtabs before
1127         checking psymtabs_addrmap.
1128         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1129
1130 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1131
1132         * NEWS: Announce that Ada task names are now shown at more places,
1133         and between quotes (except in info task output).
1134         * gdb/ada-tasks.c (task_to_str): New function.
1135         (display_current_task_id): Call task_to_str.
1136         (task_command_1): Likewise.
1137         (print_ada_task_info): In non-mi mode, Properly align headers and data
1138         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1139
1140 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1141
1142         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1143         prstatus.pr_lwp.pr_info instead of making it up.
1144
1145 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1146
1147         * auto-load.c (auto_load_expand_dir_vars): Update.
1148         * defs.h (gdb_datadir): Change to std::string.
1149         (python_libdir): Likewise.
1150         (relocate_gdb_directory): Change return type to std::string.
1151         * guile/guile.c (gdbscm_data_directory): Update.
1152         (initialize_scheme_side): Update.
1153         * jit.c (jit_reader_dir): Change to std::string.
1154         (jit_reader_load_command): Update.
1155         * main.c (gdb_datadir): Change to std::string.
1156         (python_libdir): Likewise.
1157         (set_gdb_data_directory): Update.
1158         (relocate_path): Change to return std::string.
1159         (relocate_gdb_directory): Change to return std::string.
1160         (relocate_gdbinit_path_maybe_in_datadir): Update.
1161         (captured_main_1): Update.
1162         * python/python.c (do_start_initialization): Update.
1163         * top.c (show_gdb_datadir): Update.
1164         * xml-syscall.c (xml_init_syscalls_info): Update.
1165         (init_syscalls_info): Update.
1166
1167 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1168
1169         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1170         out of get_init_files.
1171         (get_init_files): Update.
1172
1173 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1174
1175         * main.c (get_init_files): Change to use std::string.
1176         (captured_main_1): Update.
1177         (print_gdb_help): Update.
1178
1179 2019-09-11  Ali Tamur  <tamur@google.com>
1180
1181         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1182         implementation.
1183
1184 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1185
1186         * dbxread.c (read_dbx_symtab): Update.
1187         * dwarf2read.c (load_partial_dies): Update.
1188         * mdebugread.c (parse_partial_symbols): Update.
1189         (handle_psymbol_enumerators): Update.
1190         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1191         * psymtab.c (add_psymbol_to_bcache): Likewise.
1192         (add_psymbol_to_list): Likewise.
1193         * symtab.c (symbol_set_names): Likewise.
1194         * symtab.h (symbol_set_names): Likewise.
1195         * xcoffread.c (scan_xcoff_symtab): Update.
1196
1197 2019-09-11  Tom Tromey  <tom@tromey.com>
1198
1199         * symfile-mem.c (symbol_file_add_from_memory): Use
1200         bfd_set_filename.
1201         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1202         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1203
1204 2019-09-10  Tom Tromey  <tromey@adacore.com>
1205
1206         * dwarf-index-write.c (write_psymbols): Extend error message.
1207         (debug_names::insert): Add Ada code.
1208         (debug_names::write_psymbols): Remove Ada check.
1209         (debug_names) <m_string_obstack>: New member.
1210         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1211         (gdb_index_symbol_name_matcher::matches): Remove.
1212         (mapped_index_base::find_name_components_bounds): Add "lang"
1213         parameter.
1214         (mapped_index_base::build_name_components): Also split names
1215         according to Ada syntax.
1216         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1217         type of "match_callback".
1218         (check_match, check_find_bounds_finds)
1219         (dw2_expand_symtabs_matching): Update.
1220         (dw2_debug_names_iterator): Add new constructor.
1221         (dw2_debug_names_map_matching_symbols): New function.
1222         (dw2_debug_names_expand_symtabs_matching): Update.
1223         (dwarf2_debug_names_functions): Use
1224         dw2_debug_names_map_matching_symbols.
1225
1226 2019-09-10  Tom Tromey  <tromey@adacore.com>
1227
1228         * dwarf2read.c (dw2_get_file_names_reader): Add the
1229         CU's file name to the results.
1230
1231 2019-09-10  Tom Tromey  <tromey@adacore.com>
1232
1233         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1234         map_matching_symbols.  Update.
1235         * dwarf2read.c (dw2_map_matching_symbols): Update.
1236         * psymtab.c (match_partial_symbol): Change type; update.
1237         (psym_map_matching_symbols): Likewise.
1238         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1239         type; update.
1240         * symfile.h (struct quick_symbol_functions)
1241         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1242         Remove "match".
1243
1244 2019-09-10  Tom Tromey  <tromey@adacore.com>
1245
1246         * psymtab.c (map_block): Remove.
1247         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1248         * symtab.c (iterate_over_symbols_terminated): New function.
1249         * symtab.c (iterate_over_symbols_terminated): Declare.
1250
1251 2019-09-10  Tom Tromey  <tromey@adacore.com>
1252
1253         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1254         * language.h (struct language_defn) <la_iterate_over_symbols>:
1255         Return bool.
1256         * symtab.c (iterate_over_symbols): Return bool.
1257         * symtab.h (iterate_over_symbols): Return bool.
1258
1259 2019-09-10  Tom Tromey  <tromey@adacore.com>
1260
1261         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1262         (add_nonlocal_symbols): Update.
1263         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1264         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1265         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1266         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1267         Change type of "callback".  Remove "data".
1268
1269
1270 2019-09-09  Ali Tamur  <tamur@google.com>
1271
1272         * dwarf2read.c (comp_unit_head): Update comment.
1273         (dwarf2_dwo_name): New function declaration.
1274         (dwarf_unit_type_name): New function declaration.
1275         (read_comp_unit_head): Add support for new compilation units,
1276         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1277         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1278         (currently named as "signature") in their header. Also clarify error
1279         messages.
1280         (lookup_dwo_id): New function. Returns the dwo id of the given
1281         compile unit.
1282         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1283         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1284         functions.
1285         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1286         (dwarf2_dwo_name): Get the dwo name if present.
1287         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1288         purposes.
1289
1290 2019-09-09  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1293
1294 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1295
1296         * python/python.c (do_start_initialization): Make progname_copy static,
1297         to avoid a leak report.
1298
1299 2019-09-08  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1302
1303 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1304
1305         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1306         Change type to gdb::optional<block_enum>.
1307         (dw2_symtab_iter_init): Change block_index parameter type
1308         to gdb::optional<block_enum>.
1309         (dw2_lookup_symbol): Change block_index parameter
1310         type to block_enum.c
1311         (dw2_debug_names_lookup_symbol): Likewise.
1312         * psymtab.c (psym_lookup_symbol): Likewise.
1313         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1314         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1315         Likewise.
1316
1317 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1318
1319         * defs.h (relocate_gdb_directory): Change int to bool in
1320         signature and rename flag to relocatable.
1321         * main.c (relocate_path): Likewise.
1322         (relocate_gdb_directory): Likewise.
1323
1324 2019-09-06  Alan Modra  <amodra@gmail.com>
1325
1326         * coffread.c (coff_symfile_read): Constify filename variable.
1327         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1328         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1329         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1330         * solib.c (reload_shared_libraries_1): Likewise.
1331         * symfile.c (reread_symbols): Likewise.
1332         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1333         * solib-darwin.c (darwin_bfd_open): Likewise.
1334         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1335
1336 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1339         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1340
1341 2019-09-03  Tom Tromey  <tromey@adacore.com>
1342
1343         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1344         types.
1345         (has_negatives): Unbias a range type bound.
1346         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1347         * gdbtypes.c (operator==): Handle new field.
1348         (create_range_type): Add "bias" parameter.
1349         (create_static_range_type, resolve_dynamic_range): Update.
1350         * gdbtypes.h (struct range_bounds) <bias>: New member.
1351         (create_range_type): Add bias parameter.
1352         * printcmd.c (print_scalar_formatted): Unbias range types.
1353         * value.c (unpack_long): Unbias range types.
1354         (pack_long): Bias range types.
1355
1356 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1357
1358         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1359         probe arguments.
1360
1361 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1362
1363         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1364         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1365         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1366         (compile_probe_arg): Likewise.
1367         * probe.h (get_argument_count): Likewise.
1368         * solib-svr4.c (solib_event_probe_action): Likewise.
1369         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1370
1371 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1372
1373         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1374         code to here...
1375         (svr4_create_solib_event_breakpoints): ...from here.
1376
1377 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1378
1379         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1380         suffix from warning message.
1381
1382 2019-08-30  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-winsource.h (struct tui_source_window_base)
1385         <refresh_all>: Don't declare.
1386         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1387         Remove.
1388         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1389         tui_show_locator_content.
1390         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1391         declare.
1392         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1393         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1394         declare.
1395
1396 2019-08-30  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1399
1400 2019-08-30  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1403         Remove unnecessary forward declarations.
1404
1405 2019-08-30  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1408         rerender.
1409         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1410         tui_show_locator_content.
1411
1412 2019-08-30  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1415         (tui_locator_window::rerender): Rewrite using body of previous
1416         tui_show_locator_content.
1417
1418 2019-08-30  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1421         set_locator_fullname>: New methods.
1422         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1423         Rename from tui_set_locator_fullname.
1424         (tui_locator_window::set_locator_info): Rename from
1425         tui_set_locator_info.  Return bool.
1426         (tui_update_locator_fullname, tui_show_frame_info): Update.
1427
1428 2019-08-30  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1431
1432 2019-08-30  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1435         call touchwin.
1436
1437 2019-08-30  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-wingeneral.c (box_win): Assume win_info and
1440         win_info->handle cannot be NULL.
1441
1442 2019-08-30  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1445         refresh_window>: Declare.
1446         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1447         resize.
1448         (tui_data_item_window::rerender): Rename from
1449         tui_display_register.
1450         (tui_data_item_window::refresh_window): New method.
1451         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1452         no-op.
1453
1454 2019-08-30  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1457         regs_column_count, current_group>: Move later.  Now private.
1458         <get_current_group>: New method.
1459         * tui/tui-regs.c (tui_reg_command): Update.
1460         * tui/tui-layout.c (tui_set_layout): Update.
1461
1462 2019-08-30  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1465         (tui_data_window::rerender): Don't call
1466         check_and_display_highlight_if_needed.
1467         (tui_data_window::refresh_all): Remove call to
1468         erase_data_content.
1469
1470 2019-08-30  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1473         (tui_data_window::display_registers_from)
1474         (tui_data_window::display_reg_element_at_line)
1475         (tui_data_window::display_registers_from_line): Remove checks of
1476         "empty".
1477
1478 2019-08-30  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1481         Don't declare.
1482         * tui/tui-regs.c (tui_data_window::show_registers): Call
1483         rerender.
1484         (tui_data_window::rerender): Rename from display_all_data.
1485         (tui_data_window::rerender): Remove old implementation.
1486
1487 2019-08-30  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1490         text.
1491         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1492
1493 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1494             Sergio Durigan Junior  <sergiodj@redhat.com>
1495
1496         PR win32/24284
1497         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1498
1499 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1502         when searching for types.
1503
1504 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * f-lang.c (f_language_defn): Use f_print_typedef.
1507         * f-lang.h (f_print_typedef): Declare.
1508         * f-typeprint.c (f_print_typedef): Define.
1509
1510 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1511
1512         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1513
1514 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * cli/cli-utils.c (info_print_options_defs): Delete.
1517         (make_info_print_options_def_group): Delete.
1518         (extract_info_print_options): Delete.
1519         (info_print_command_completer): Delete.
1520         (info_print_args_help): Add extra parameter, and optionally
1521         include text about -n flag.
1522         * cli/cli-utils.h (struct info_print_options): Delete.
1523         (extract_info_print_options): Delete declaration.
1524         (info_print_command_completer): Delete declaration.
1525         (info_print_args_help): Add extra parameter, extend header
1526         comment.
1527         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1528         search_symbols.
1529         * stack.c (struct info_print_options): New type.
1530         (info_print_options_defs): New file scoped variable.
1531         (make_info_print_options_def_group): New static function.
1532         (info_print_command_completer): New static function.
1533         (info_locals_command): Update to use new local functions.
1534         (info_args_command): Likewise.
1535         (_initialize_stack): Add extra parameter to calls to
1536         info_print_args_help.
1537         * symtab.c (search_symbols): Add extra parameter, use this to
1538         possibly excluse non-debug symbols.
1539         (symtab_symbol_info): Add extra parameter, which is passed on to
1540         search_symbols.
1541         (struct info_print_options): New type.
1542         (info_print_options_defs): New file scoped variable.
1543         (make_info_print_options_def_group): New static function.
1544         (info_print_command_completer): New static function.
1545         (info_variables_command): Update to use local functions, and pass
1546         extra parameter through to symtab_symbol_info.
1547         (info_functions_command): Likewise.
1548         (info_types_command): Pass additional argument through to
1549         symtab_symbol_info.
1550         (rbreak_command): Pass extra argument to search_symbols.
1551         (_initialize_symtab): Add extra arguments for calls to
1552         info_print_args_help, and update help text for 'info variables',
1553         'whereis', and 'info functions' commands.
1554         * symtab.h (search_symbols): Add extra argument to declaration.
1555         * NEWS: Mention new flags.
1556
1557 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1558
1559         * symtab.c (lookup_static_symbol): Call the new function (and move
1560         it down to be next to lookup_global_symbol).
1561         (struct global_sym_lookup_data): Add block_enum member and rename to...
1562         (struct global_or_static_sym_lookup_data): ...this.
1563         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1564         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1565         (lookup_symbol_global_or_static_iterator_cb): ...this.
1566         (lookup_global_or_static_symbol): New function.
1567         (lookup_global_symbol): Call new function.
1568
1569 2019-08-26  Tom de Vries  <tdevries@suse.de>
1570
1571         PR c++/24852
1572         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1573         when pc_probe.prob == NULL.
1574
1575 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1576
1577         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1578         variable symbol_linkage to symbol_linkage_.
1579
1580 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1581
1582         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1583         represent whether the symbol is static, dynamic, or we don't
1584         know.
1585
1586 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1587
1588         * gdb/rx-tdep.c (rx_register_names): New.
1589         (rx_register_name): Delete.
1590         (rx_psw_type): Delete.
1591         (rx_fpsw_type): Delete.
1592         (rx_register_type): Delete.
1593         (rx_gdbarch_init): Convert target-descriptions.
1594         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1595         * gdb/features/Makefile: Add rx.xml.
1596         * gdb/features/rx.xml: New.
1597         * gdb/features/rx.c: Generated.
1598         * gdb/NEWS: Mention target description support.
1599
1600 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1601
1602         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1603         *slot_ptr.
1604
1605 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1606
1607         * configure.ac: Don't check for 'dlfcn.h' (moved to
1608         gdbsupport/common.m4).
1609         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1610         'gdbsupport/'.
1611         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1612         * compile/compile-c-support.c: Include
1613         'gdbsupport/gdb-dlfcn.h'.
1614         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1615         * gdb-dlfcn.c: Move to...
1616         * gdbsupport/gdb-dlfcn.c: ... here.
1617         * gdb-dlfcn.h: Move to...
1618         * gdbsupport/gdb-dlfcn.h: ... here.
1619
1620 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1621
1622         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1623         the offset field signed.
1624
1625 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1626
1627         * python/lib/gdb/__init__.py (_execute_file): New function.
1628         * python/python.c (python_run_simple_file): Call gdb._execute_file
1629         on Windows.
1630
1631 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1634         all uses as this was never set to anything but a zero value.
1635
1636 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1637
1638         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1639
1640 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1641
1642         * tui/tui-data.h (tui_gen_win_info): Add an =default
1643         move constructor, required by some GCC versions.
1644
1645 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1646
1647         * go32-nat.c (go32_sysinfo): Add hygon_p.
1648
1649 2019-08-20  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1652         line_from_reg_element_no, first_reg_element_no_inline,
1653         display_all_data, delete_data_content_windows,
1654         erase_data_content>: Now private.
1655
1656 2019-08-20  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1659         (tui_unhighlight_win, tui_highlight_win)
1660         (tui_win_info::make_window): Update.
1661         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1662
1663 2019-08-20  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1666         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1667         (MAX_PID_WIDTH): Move to tui-stack.c.
1668         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1669         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1670         (MAX_PID_WIDTH): Move from tui-data.h.
1671
1672 2019-08-20  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1675         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1676         (box_win): Update.
1677         (tui_gen_win_info::make_window): Rename from tui_make_window.
1678         (tui_win_info::make_window): New method.
1679         (tui_gen_win_info::make_visible): Update.
1680         * tui/tui-source.c (tui_source_window::set_contents): Update.
1681         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1682         (tui_data_window::display_registers_from): Update.
1683         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1684         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1685         Declare.
1686         <can_box>: Remove.
1687         <title>: Remove.
1688         (struct tui_win_info) <make_window>: Declare.
1689         <can_box>: Now virtual.
1690         <title>: New member.
1691         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1692         * tui/tui-command.c (tui_cmd_window::resize): Update.
1693
1694 2019-08-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1697         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1698         (tui_data_window::check_register_values): Update.
1699
1700 2019-08-20  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-regs.h (struct tui_data_window): Use
1703         DISABLE_COPY_AND_ASSIGN.
1704         <regs_content>: Change type, removing unique_ptr.
1705         <tui_data_window>: Add move constructor.
1706         * tui/tui-regs.c (tui_data_window::show_registers)
1707         (tui_data_window::show_register_group)
1708         (tui_data_window::display_registers_from)
1709         (tui_data_window::display_registers_from)
1710         (tui_data_window::first_data_item_displayed)
1711         (tui_data_window::delete_data_content_windows)
1712         (tui_data_window::rerender, tui_data_window::refresh_window)
1713         (tui_data_window::check_register_values): Update.
1714
1715 2019-08-20  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1718         show_register_group>: Declare.
1719         (tui_show_register_group): Don't declare.
1720         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1721         tui_show_registers.
1722         (tui_data_window::show_register_group): Rename from
1723         tui_show_register_group.
1724         (tui_data_window::check_register_values, tui_reg_command):
1725         Update.
1726         * tui/tui-layout.c (tui_set_layout): Update.
1727
1728 2019-08-20  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1731         Declare.
1732         (tui_check_register_values): Don't declare.
1733         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1734         from tui_check_register_values.
1735         * tui/tui-hooks.c (tui_register_changed): Update.
1736
1737 2019-08-20  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-regs.c (tui_reg_layout): Move later.
1740         (tui_show_registers): Don't enable TUI mode or change layout.
1741
1742 2019-08-20  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-regs.h (struct tui_data_item_window)
1745         <~tui_data_item_window>: Remove.
1746         <content>: Now a unique_xmalloc_ptr.
1747         * tui/tui-regs.c (tui_register_format): Return a
1748         unique_xmalloc_ptr.
1749         (tui_get_register): Update.
1750         (~tui_data_item_window): Remove.
1751         (tui_data_window::display_registers_from, tui_display_register):
1752         Update.
1753         * tui/tui-io.h (tui_expand_tabs): Update.
1754         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1755         Remove "col" parameter.
1756
1757 2019-08-20  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1760         field.
1761         * tui/tui-regs.c (~tui_data_item_window): Update.
1762
1763 2019-08-20  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1766         earlier.
1767
1768 2019-08-20  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1771
1772 2019-08-20  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-source.h (struct tui_source_window): Update.
1775         * tui/tui-regs.c (tui_show_registers): Update.
1776         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1777         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1778         (NO_REGS_STRING): Remove defines.
1779
1780 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1781
1782         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1783         unnecessary thread walk if remote doesn't support the packet.
1784
1785 2019-08-19  Tom Tromey  <tromey@adacore.com>
1786
1787         * python/py-value.c (value_has_field): Fix indentation.
1788
1789 2019-08-19  Tom Tromey  <tromey@adacore.com>
1790
1791         * printcmd.c (do_one_display, info_display_command): Update.
1792         * block.h (contained_in): Return bool.  Add allow_nested
1793         parameter.
1794         * block.c (contained_in): Return bool.  Add allow_nested
1795         parameter.
1796
1797 2019-08-19  Tom Tromey  <tom@tromey.com>
1798
1799         * configure: Rebuild.
1800         * configure.ac: Disallow the combination of -static-libstdc++ and
1801         source highlight.
1802         * source-cache.c (get_language_name): Handle rust.
1803         (source_cache::get_source_lines): Ignore highlighting exceptions.
1804
1805 2019-08-16  Tom Tromey  <tom@tromey.com>
1806
1807         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1808         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1809         (struct tui_source_window_base) <make_visible, refresh_window,
1810         resize>: Remove methods.
1811         <execution_info>: Remove field.
1812         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1813         (tui_show_source_line, tui_source_window_base)
1814         (~tui_source_window_base): Update.
1815         (tui_source_window_base::resize)
1816         (tui_source_window_base::make_visible)
1817         (tui_source_window_base::refresh_window): Remove.
1818         (tui_source_window_base::update_exec_info): Update.
1819         * tui/tui-source.c (tui_source_window::set_contents): Update.
1820         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1821
1822 2019-08-16  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1825         deprecated_query_hook.
1826
1827 2019-08-16  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1830         (tui_update_source_windows_with_line): Update.
1831         * tui/tui-source.h (struct tui_source_window)
1832         <show_symtab_source>: Declare.
1833         (tui_show_symtab_source): Don't declare.
1834         * tui/tui-source.c (tui_show_symtab_source): Rename from
1835         tui_show_symtab_source.
1836
1837 2019-08-16  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-winsource.h (struct tui_source_window_base)
1840         <set_contents>: Declare.
1841         * tui/tui-winsource.c
1842         (tui_source_window_base::update_source_window_as_is): Update.
1843         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1844         Declare.
1845         (tui_set_source_content): Don't declare.
1846         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1847         tui_set_source_content.
1848         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1849         Declare.
1850         (tui_set_disassem_content): Don't declare.
1851         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1852         tui_set_disassem_content.
1853
1854 2019-08-16  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-winsource.h (struct tui_source_window_base)
1857         <update_breakpoint_info>: Declare.
1858         (tui_update_breakpoint_info): Don't declare.
1859         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1860         (tui_update_all_breakpoint_info): Update.
1861         (tui_source_window_base::update_breakpoint_info): Rename from
1862         tui_update_breakpoint_info.
1863         (tui_source_window_base::update_exec_info): Update.
1864
1865 2019-08-16  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.h (struct tui_source_window_base)
1868         <update_source_window>: Declare.
1869         (tui_update_source_window): Don't declare.
1870         * tui/tui-winsource.c
1871         (tui_source_window_base::update_source_window): Rename from
1872         tui_update_source_window.
1873         (tui_source_window_base::rerender): Update.
1874         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1875         * tui/tui-disasm.c (tui_show_disassem)
1876         (tui_show_disassem_and_update_source)
1877         (tui_disasm_window::maybe_update): Update.
1878
1879 2019-08-16  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-winsource.h (struct tui_source_window_base)
1882         <update_source_window_as_is>: Declare.
1883         (tui_update_source_window_as_is): Don't declare.
1884         * tui/tui-winsource.c (tui_update_source_window): Update
1885         (tui_source_window_base::update_source_window_as_is): Rename from
1886         tui_update_source_window_as_is.
1887         (tui_source_window_base::refill): Update.
1888         * tui/tui-source.c (tui_show_symtab_source): Update.
1889         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1890         Update.
1891
1892 2019-08-16  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-winsource.h (tui_update_source_window)
1895         (tui_update_source_window_as_is): Remove "noerror" parameter.
1896         * tui/tui-winsource.c (tui_update_source_window)
1897         (tui_update_source_window_as_is): Remove "noerror" parameter.
1898         (tui_update_source_windows_with_addr)
1899         (tui_update_source_windows_with_line)
1900         (tui_source_window_base::rerender)
1901         (tui_source_window_base::refill): Update.
1902         * tui/tui-source.h (tui_set_source_content)
1903         (tui_show_symtab_source): Remove "noerror" parameter.
1904         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1905         parameter.
1906         (tui_show_symtab_source): Likewise.
1907         (tui_source_window::maybe_update): Update.
1908         * tui/tui-disasm.c (tui_show_disassem)
1909         (tui_show_disassem_and_update_source)
1910         (tui_disasm_window::do_scroll_vertical)
1911         (tui_disasm_window::maybe_update): Update.
1912
1913 2019-08-16  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui.c (tui_is_window_visible): Update.
1916         * tui/tui-wingeneral.c (tui_make_window)
1917         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1918         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1919         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1920         (tui_set_win_height_command, parse_scrolling_args): Update.
1921         * tui/tui-source.c (tui_source_window::style_changed): Update.
1922         * tui/tui-regs.c (tui_show_registers)
1923         (tui_data_window::first_data_item_displayed)
1924         (tui_data_window::delete_data_content_windows)
1925         (tui_check_register_values, tui_reg_command): Update.
1926         * tui/tui-disasm.c (tui_show_disassem): Update.
1927         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1928         method.
1929         <is_visible>: Remove field.
1930         * tui/tui-data.c (tui_next_win, tui_prev_win)
1931         (tui_delete_invisible_windows): Update.
1932
1933 2019-08-16  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-winsource.h (struct tui_source_window_base)
1936         <m_has_locator>: Remove.
1937         * tui/tui-layout.c (show_source_disasm_command, show_data)
1938         (show_source_or_disasm_and_command): Update.
1939
1940 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1941
1942         * NEWS (Other MI changes): New subsection.
1943         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1944         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1945         * arch-utils.c (default_get_pc_address_flags): New function.
1946         * arch-utils.h (default_get_pc_address_flags): New declaration.
1947         * gdbarch.sh: Add get_pc_address_flags.
1948         * gdbarch.c: Regenerate.
1949         * gdbarch.h: Likewise.
1950         * stack.c (print_pc): New function.
1951         (print_frame_info) (print_frame): Call print_pc.
1952
1953 2019-08-16  Tom de Vries  <tdevries@suse.de>
1954
1955         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1956         print_objfile_section_info.
1957
1958 2019-08-15  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1961         calling update_cmdwin_start_line.
1962         * tui/tui-winsource.h (struct tui_source_window_base)
1963         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1964         <rerender>: Declare.
1965         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1966         Call rerender.
1967         (tui_source_window_base::set_new_height): Remove.
1968         (tui_source_window_base::rerender): Rename from
1969         do_make_visible_with_new_height.
1970         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1971         resize method.
1972         (tui_win_info::make_invisible_and_set_new_height)
1973         (tui_win_info::make_visible_with_new_height): Remove.
1974         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1975         Declare.
1976         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1977         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1978         do_make_visible_with_new_height>: Don't declare.
1979         <rerender>: Declare.
1980         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1981         set_new_height.
1982         (tui_data_window::do_make_visible_with_new_height): Remove.
1983         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1984         call tui_show_locator_content.
1985         (tui_gen_win_info::resize): Call rerender.
1986         (show_source_or_disasm_and_command): Don't call
1987         tui_show_locator_content.
1988         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1989         method.
1990         (struct tui_win_info) <rerender>: Declare.
1991         <set_new_height, make_invisible_and_set_new_height,
1992         make_visible_with_new_height>: Don't declare.
1993         * tui/tui-data.c (tui_win_list::rerender): New method.
1994         * tui/tui-command.h (struct tui_cmd_window)
1995         <do_make_visible_with_new_height>: Don't declare.
1996         * tui/tui-command.c
1997         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1998
1999 2019-08-15  Tom Tromey  <tromey@adacore.com>
2000
2001         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2002         * ada-lang.c (ada_enum_name): Likewise.
2003
2004 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2005
2006         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2007         leading underscore.
2008         (GdbOutputErrorFile): Likewise.
2009         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2010         accordingly.
2011         (execute_unwinders): Rename to have a leading underscore.
2012         (auto_load_packages): Likewise.
2013         (global scope): Adjust call to auto_load_packages accordingly.
2014         (GdbSetPythonDirectory): Likewise.
2015         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2016         instead of execute_unwinders.
2017
2018 2019-08-15  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2021         (show_data): Don't change window visibility.
2022         (tui_gen_win_info::resize): Remove special case for command
2023         window.  Use wresize, when available.
2024         (show_source_or_disasm_and_command): Don't change window
2025         visibility.
2026         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2027         <make_visible>: New method.
2028         * tui/tui-command.c (tui_cmd_window::resize): New method.
2029
2030 2019-08-15  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2033         (struct tui_source_windows): New.
2034         * tui/tui-winsource.c (tui_display_main): Update.
2035         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2036         (new_height_ok, parse_scrolling_args): Update.
2037         * tui/tui-layout.c (show_layout, show_data): Update.
2038         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2039         (tui_add_to_source_windows): Don't declare.
2040         * tui/tui-data.c (source_windows, tui_source_windows)
2041         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2042
2043 2019-08-15  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2046         Rename from reset.
2047         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2048         * tui/tui-layout.c (show_source_disasm_command, show_data):
2049         Update.
2050         (tui_gen_win_info::resize): Rename.
2051         (show_source_or_disasm_and_command): Update.
2052         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2053         reset.
2054
2055 2019-08-15  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2058         * tui/tui-interp.c (tui_interp::init): Don't call
2059         tui_initialize_static_data.
2060         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2061
2062 2019-08-15  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2065         examine tui_win_list.
2066
2067 2019-08-15  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2070         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2071         tui_clear_source_content.
2072         (tui_clear_source_content): Remove.
2073         (tui_source_window_base::do_erase_source_content): Hoist call to
2074         content.clear().
2075         * tui/tui-stack.c (tui_show_frame_info): Don't call
2076         tui_clear_source_content.
2077
2078 2019-08-15  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-winsource.h (struct tui_source_window_base)
2081         <do_erase_source_content>: New method.
2082         <erase_source_content>: New method.
2083         (tui_erase_source_content): Don't declare.
2084         * tui/tui-winsource.c (tui_clear_source_content): Update.
2085         (tui_source_window_base::do_erase_source_content): Rename from
2086         tui_erase_source_content.
2087         (tui_source_window_base::show_source_content): Update.
2088         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2089         * tui/tui-source.h (struct tui_source_window)
2090         <erase_source_content>: New method.
2091         * tui/tui-disasm.h (struct tui_disasm_window)
2092         <erase_source_content>: New method.
2093
2094 2019-08-15  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2097         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2098         constructor.
2099         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2100         * tui/tui-source.c (tui_set_source_content): Update.
2101         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2102
2103 2019-08-15  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2106         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2107         tui-source.c.
2108         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2109         Declare.
2110         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2111         method.
2112         (tui_source_window::maybe_update): Update.
2113
2114 2019-08-15  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2117         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2118         tui-disasm.c.
2119         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2120         Declare.
2121         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2122         method.
2123         (tui_disasm_window::maybe_update): Update.
2124
2125 2019-08-15  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-winsource.h (struct tui_source_window_base)
2128         <maybe_update>: Declare.
2129         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2130         method.
2131         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2132         Declare.
2133         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2134         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2135         Declare.
2136         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2137
2138 2019-08-15  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2141
2142 2019-08-15  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-wingeneral.c: Include tui-stack.h.
2145         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2146         (struct tui_locator_window): Move from tui-data.h.
2147         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2148         (tui_initialize_static_data): Move from tui-data.c.
2149         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2150         (struct tui_locator_window): Move to tui-stack.c.
2151         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2152         (tui_initialize_static_data): Move to tui-stack.c.
2153
2154 2019-08-15  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-layout.c (show_source_disasm_command)
2157         (show_source_or_disasm_and_command): Use make_visible method, not
2158         tui_make_window.
2159         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2160         Remove.
2161
2162 2019-08-15  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-wingeneral.h (tui_make_window): Update.
2165         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2166         parameter.
2167         (tui_gen_win_info::make_visible): Update.
2168         * tui/tui-regs.c (tui_data_window::display_registers_from):
2169         Update.
2170         * tui/tui-layout.c (show_source_disasm_command)
2171         (show_source_or_disasm_and_command): Update.
2172         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2173         (enum tui_box): Remove.
2174         (struct tui_win_info) <can_box>: New method.
2175         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2176         method.
2177
2178 2019-08-15  Tom de Vries  <tdevries@suse.de>
2179
2180         * linux-nat-trad.c: Include gdbarch.h.
2181
2182 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2183
2184         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2185         register sizes.
2186
2187 2019-08-14  Tom Tromey  <tromey@adacore.com>
2188
2189         * darwin-nat.c: Include gdbarch.h.
2190         * darwin-nat-info.c: Include gdbarch.h.
2191
2192 2019-08-13  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2195         Remove.
2196         * tui/tui-data.c (tui_initialize_static_data): Update.
2197
2198 2019-08-13  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-winsource.h (struct tui_exec_info_window)
2201         <~tui_exec_info_window, maybe_allocate_content, get_content,
2202         m_content>: Remove.
2203         (struct tui_source_window_base) <set_exec_info_content,
2204         show_exec_info_content>: Don't declare.
2205         * tui/tui-winsource.c
2206         (tui_exec_info_window::maybe_allocate_content): Remove.
2207         (tui_source_window_base::update_exec_info): Rename from
2208         set_exec_info_content.
2209         (tui_source_window_base::show_exec_info_content)
2210         (tui_source_window_base::update_exec_info): Remove.
2211
2212 2019-08-13  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2215         declare.
2216         * tui/tui-winsource.c (tui_update_source_window_as_is)
2217         (tui_update_source_windows_with_addr, tui_erase_source_content):
2218         Update.
2219         (tui_clear_exec_info_content): Remove.
2220
2221 2019-08-13  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2224         declare.
2225         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2226         call tui_erase_exec_info_content.
2227         (tui_clear_exec_info_content): Rename from
2228         tui_erase_exec_info_content.
2229         (tui_clear_exec_info_content): Delete.
2230
2231 2019-08-13  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-winsource.h (struct tui_source_window_base)
2234         <show_exec_info_content>: Declare.
2235         (tui_show_exec_info_content): Don't declare.
2236         * tui/tui-winsource.c
2237         (tui_source_window_base::show_exec_info_content): Rename from
2238         tui_show_exec_info_content.
2239         (tui_source_window_base::update_exec_info): Update.
2240
2241 2019-08-13  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2244         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2245         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2246         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2247         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2248         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2249         ... here.
2250
2251 2019-08-13  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-winsource.h (struct tui_source_window_base)
2254         <update_exec_info>: Declare.
2255         (tui_update_exec_info): Don't declare.
2256         * tui/tui-winsource.c (tui_update_source_window_as_is)
2257         (tui_source_window_base::refresh_all)
2258         (tui_update_all_breakpoint_info): Update.
2259         (tui_source_window_base::update_exec_info): Rename from
2260         tui_update_exec_info.
2261         * tui/tui-stack.c (tui_show_frame_info): Update.
2262
2263 2019-08-13  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.h (struct tui_source_window_base)
2266         <set_exec_info_content>: Declare.
2267         (tui_set_exec_info_content): Don't declare.
2268         * tui/tui-winsource.c
2269         (tui_source_window_base::set_exec_info_content): Rename from
2270         tui_set_exec_info_content.
2271         (tui_update_exec_info): Update.
2272
2273 2019-08-13  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-winsource.h (struct tui_source_window_base)
2276         <show_source_content>: Declare.
2277         (tui_show_source_content): Don't declare.
2278         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2279         (tui_source_window_base::show_source_content): Rename from
2280         tui_show_source_content.
2281         (tui_source_window_base::refresh_all): Update.
2282         * tui/tui-layout.c (show_source_disasm_command)
2283         (show_source_or_disasm_and_command): Update.
2284
2285 2019-08-13  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-winsource.c (tui_erase_source_content)
2288         (tui_show_source_content, tui_source_window_base::refresh_all):
2289         Update.
2290         * tui/tui-wingeneral.h
2291         (tui_check_and_display_highlight_if_needed): Don't declare.
2292         * tui/tui-wingeneral.c
2293         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2294         check_and_display_highlight_if_needed.
2295         * tui/tui-win.c (tui_rehighlight_all)
2296         (tui_win_info::make_visible_with_new_height): Update.
2297         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2298         (tui_data_window::erase_data_content)
2299         (tui_data_window::display_all_data): Update.
2300         * tui/tui-data.h (struct tui_win_info)
2301         <check_and_display_highlight_if_needed>: Declare.
2302
2303 2019-08-13  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-win.c (tui_resize_all): Call
2306         tui_delete_invisible_windows.
2307         * tui/tui-layout.c (show_layout): Call
2308         tui_delete_invisible_windows.
2309         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2310         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2311
2312 2019-08-13  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2315         tui_add_win_to_layout.
2316
2317 2019-08-13  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2320         * tui/tui-layout.c (tui_default_win_height): Now static.
2321
2322 2019-08-13  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2325         single switch.
2326         (show_source_disasm_command, show_source_or_disasm_and_command):
2327         Don't check current layout.
2328
2329 2019-08-13  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-wingeneral.c (make_all_visible): Remove.
2332         (tui_make_all_invisible): Simplify.
2333         * tui/tui-layout.c (tui_make_all_invisible): Move from
2334         tui-wingeneral.c; simplify.
2335         (show_layout): Hoist call to tui_make_all_invisible.
2336         (show_data): Don't call tui_make_all_invisible.
2337
2338 2019-08-13  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2341         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2342
2343 2019-08-13  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2346         tui-data.c.
2347         (show_source_disasm_command, show_data)
2348         (show_source_or_disasm_and_command): Don't use
2349         tui_set_current_layout_to.
2350         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2351         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2352         tui-layout.c.
2353         (tui_set_current_layout_to): Remove.
2354
2355 2019-08-13  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-layout.c (tui_set_layout): Update.
2358         * tui/tui-data.h (struct tui_layout_def): Remove.
2359         (tui_layout_def): Don't declare.
2360         * tui/tui-data.c (layout_def): Remove.
2361         (tui_layout_def): Remove.
2362
2363 2019-08-13  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.h (struct tui_source_window_base)
2366         <clear_detail>: No longer "override".
2367         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2368         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2369         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2370         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2371         Remove.
2372         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2373
2374 2019-08-13  Tom Tromey  <tromey@adacore.com>
2375
2376         * tracepoint.c: Don't include readline.h or history.h.
2377
2378 2019-08-12  Tom Tromey  <tom@tromey.com>
2379
2380         * configure: Rebuild.
2381         * configure.ac: Check for readline 7.
2382         * NEWS: Mention readline 7 requirement.
2383         * README: Update.
2384
2385 2019-08-12  Tom Tromey  <tom@tromey.com>
2386
2387         * mingw-hdep.c (gdb_select): Remove readline hack.
2388
2389 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2390
2391         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2392         when the function fails.
2393
2394 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2395
2396         * s390-tdep.c (s390_type_align): New function.
2397         (s390_gdbarch_init): Set it as type_align gdbarch method.
2398
2399 2019-08-09  Tom de Vries  <tdevries@suse.de>
2400
2401         PR gdb/24591
2402         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2403         pc_low with relocation offset.
2404
2405 2019-08-07  Tom Tromey  <tromey@adacore.com>
2406
2407         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2408         (print_frame_args): Update.
2409         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2410         Update.
2411         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2412         * frame.h (struct frame_arg): Add initializers.
2413         <error>: Now a unique_xmalloc_ptr.
2414
2415 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2416
2417         * NEWS: Expand the Pointer Authentication entry.
2418         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2419         (aarch64_frame_unmask_lr): ... to this.
2420         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2421         Call aarch64_frame_unmask_lr.
2422         * frame.c (struct frame_info): Add "masked" variable.
2423         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2424         (fprint_frame): Check for masked pc.
2425         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2426         declarations.
2427         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2428         * stack.c (print_frame): Check for masked pc.
2429
2430 2019-08-06  Tom Tromey  <tom@tromey.com>
2431
2432         * stabsread.c (patch_block_stabs, read_one_struct_field)
2433         (read_enum_type): Use obstack_strndup.
2434         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2435         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2436         * dwarf2read.c (guess_full_die_structure_name)
2437         (anonymous_struct_prefix): Use obstack_strndup.
2438         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2439         * c-exp.y (yylex): Use obstack_strndup.
2440         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2441         (write_var_or_type): Use obstack_strndup.
2442
2443 2019-08-06  Tom Tromey  <tom@tromey.com>
2444
2445         * symfile.c (reread_symbols): Use obstack_strdup.
2446         * stabsread.c (read_type): Use obstack_strdup.
2447         * gdb_obstack.h (obstack_strdup): New overload.
2448         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2449         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2450         (dwarf2_canonicalize_name): Use obstack_strdup.
2451         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2452         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2453         Use obstack_strdup.
2454
2455 2019-08-06  Tom Tromey  <tom@tromey.com>
2456
2457         * gdb_obstack.h (obstack_strdup): Define.
2458         * gdb_obstack.c (obstack_strdup): Don't define.
2459
2460 2019-08-06  Tom Tromey  <tom@tromey.com>
2461
2462         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2463         obstack_strdup.
2464         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2465         obstack_strdup.
2466         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2467         * stabsread.c (common_block_start): Use obstack_strdup.
2468         * objfiles.c (set_objfile_main_name, objfile): Use
2469         obstack_strdup.
2470         * namespace.c (add_using_directive): Use obstack_strdup.
2471         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2472         * jit.c (finalize_symtab): Use obstack_strdup.
2473         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2474         (guess_partial_die_structure_name, partial_die_info::fixup)
2475         (dwarf2_name): Use obstack_strdup.
2476         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2477         obstack_strdup.
2478         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2479         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2480         obstack_strdup.
2481         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2482
2483 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2484
2485         * unittests/help-doc-selftests.c: New file.
2486         * Makefile.in: Add the new file.
2487
2488 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2489
2490         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2491         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2492         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2493         the trailing '.' is not output, and the first character is uppercased.
2494         (print_help_for_command): Update call to print_doc_line.
2495         (print_doc_of_command): Likewise.
2496         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2497         * cli/cli-option.c (append_indented_doc): Do not append newline.
2498         (build_help_option): Append newline after first appended_indented_doc
2499         only if a second call is done.
2500         (build_help): Append 2 new lines before each option, except the first
2501         one.
2502         * compile/compile.c (_initialize_compile): Add new lines after
2503         %OPTIONS%, when not at the end of the help.
2504         Change help doc or code
2505         producing the help doc to respect the invariants.
2506         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2507         Also removed the new line after 'Options:', as all other commands
2508         do not put an empty line between 'Options:' and the first option.
2509         * printcmd.c (_initialize_printcmd): Likewise.
2510         * stack.c (_initialize_stack): Likewise.
2511         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2512         incorrectly telling COMMAND is optional.
2513         * ada-lang.c (_initialize_ada_language): Change help doc or code
2514         producing the help doc to respect the invariants.
2515         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2516         * breakpoint.c (_initialize_breakpoint): Likewise.
2517         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2518         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2519         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2520         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2521         _initialize_cli_style): Likewise.
2522         * corelow.c (core_target_info): Likewise.
2523         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2524         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2525         * filesystem.c (_initialize_filesystem): Likewise.
2526         * frame.c (_initialize_frame): Likewise.
2527         * gnu-nat.c (add_task_commands): Likewise.
2528         * infcall.c (_initialize_infcall): Likewise.
2529         * infcmd.c (_initialize_infcmd): Likewise.
2530         * interps.c (_initialize_interpreter): Likewise.
2531         * language.c (_initialize_language): Likewise.
2532         * linux-fork.c (_initialize_linux_fork): Likewise.
2533         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2534         * maint.c (_initialize_maint_cmds): Likewise.
2535         * memattr.c (_initialize_mem): Likewise.
2536         * printcmd.c (_initialize_printcmd): Likewise.
2537         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2538         _RegEx): Likewise.
2539         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2540         * record-btrace.c (_initialize_record_btrace): Likewise.
2541         * record-full.c (_initialize_record_full): Likewise.
2542         * record.c (_initialize_record): Likewise.
2543         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2544         * regcache.c (_initialize_regcache): Likewise.
2545         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2546         _initialize_remote): Likewise.
2547         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2548         * serial.c (_initialize_serial): Likewise.
2549         * skip.c (_initialize_step_skip): Likewise.
2550         * source.c (_initialize_source): Likewise.
2551         * stack.c (_initialize_stack): Likewise.
2552         * symfile.c (_initialize_symfile): Likewise.
2553         * symtab.c (_initialize_symtab): Likewise.
2554         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2555         * top.c (init_main): Likewise.
2556         * tracefile-tfile.c (tfile_target_info): Likewise.
2557         * tracepoint.c (_initialize_tracepoint): Likewise.
2558         * tui/tui-win.c (_initialize_tui_win): Likewise.
2559         * utils.c (add_internal_problem_command): Likewise.
2560         * valprint.c (value_print_option_defs): Likewise.
2561
2562 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2563
2564         PR build/24886
2565         * configure.ac: Drop enable-libmcheck support.
2566         * configure, config.in: Rebuild.
2567         * libmcheck.m4: Remove.
2568         * acinclude.m4: Don't include it.
2569         * Makefile.in: Don't distribute it.
2570         * top.c (print_gdb_configuration): Don't mention it.
2571
2572 2019-08-06  Tom Tromey  <tom@tromey.com>
2573
2574         * utils.c (set_output_style): Sometimes pass stream to
2575         emit_style_escape.
2576         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2577         * record-btrace.c (btrace_insn_history): Update.
2578         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2579         method.
2580         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2581         Update initializers.
2582         <m_uiout>: New field.
2583         <m_di>: Move lower.
2584         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2585         Remove "uiout" parameter.
2586         (dump_insns): Update.
2587         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2588         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2589
2590 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2591
2592         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2593         (error_in_psymtab_expansion): Likewise.
2594         (lookup_symbol_via_quick_fns): Likewise.
2595         (basic_lookup_transparent_type_quick): Likewise.
2596         (basic_lookup_transparent_type_1): Likewise.
2597
2598 2019-08-06  Tom Tromey  <tromey@adacore.com>
2599
2600         * source.c (last_source_error): Now bool.
2601         (print_source_lines_base): Make "noprint" bool.  Only open
2602         source file when last_source_visited changes.
2603
2604 2019-08-06  Tom Tromey  <tromey@adacore.com>
2605
2606         * annotate.c (annotate_source_line): Use g_source_cache.
2607         * source-cache.c (source_cache::get_plain_source_lines): Change
2608         parameters.  Populate m_offset_cache.
2609         (source_cache::ensure): New method.
2610         (source_cache::get_line_charpos): New method.
2611         (extract_lines): Move lower.  Change parameters.
2612         (source_cache::get_source_lines): Move lower.
2613         * source-cache.h (class source_cache): Update comment.
2614         <get_line_charpos>: New method.
2615         <get_source_lines>: Update comment.
2616         <clear>: Clear m_offset_cache.
2617         <get_plain_source_lines>: Change parameters.
2618         <ensure>: New method
2619         <m_offset_cache>: New member.
2620         * source.c (forget_cached_source_info_for_objfile): Update.
2621         (info_source_command): Use g_source_cache.
2622         (find_source_lines, open_source_file_with_line_charpos): Remove.
2623         (print_source_lines_base, search_command_helper): Use g_source_cache.
2624         * source.h (open_source_file_with_line_charpos): Don't declare.
2625         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2626         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2627         Use g_source_cache.
2628
2629 2019-08-06  Tom Tromey  <tromey@adacore.com>
2630
2631         * source-cache.c (source_cache::get_plain_source_lines):
2632         Remove "first_line" and "last_line" parameters.
2633         (source_cache::get_source_lines): Cache plain text.
2634         * source-cache.h (class source_cache)
2635         <get_plain_source_lines>: Update.
2636
2637 2019-08-06  Tom Tromey  <tromey@adacore.com>
2638
2639         * source-cache.c (extract_lines): No longer a method.
2640         Changed type of parameter.  Include final newline.
2641         (selftests::extract_lines_test): New function.
2642         (_initialize_source_cache): Likewise.
2643         * source-cache.h (class source_cache)
2644         <extract_lines>: Don't declare.
2645
2646 2019-08-06  Tom Tromey  <tromey@adacore.com>
2647
2648         * breakpoint.c (init_breakpoint_sal): Update.
2649         (breakpoint): Update.
2650         * breakpoint.h (struct breakpoint) <filter>: Now a
2651         unique_xmalloc_ptr.
2652
2653 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2654
2655         * NEWS: Mention dictionary access on blocks.
2656         * python/py-block.c (blpy_getitem): New function.
2657         (block_object_as_mapping): New struct.
2658         (block_object_type): Use new struct for tp_as_mapping field.
2659
2660 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2661
2662         * objfiles.h (objfile): Add a comment describing partial symbols.
2663
2664 2019-08-05  Tom Tromey  <tromey@adacore.com>
2665
2666         * compile/compile.c (_initialize_compile): Use _(), not N_().
2667         * thread.c (_initialize_thread): Use _(), not N_().
2668         * stack.c (_initialize_stack): Use _(), not N_().
2669         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2670
2671 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2672
2673         * dwarf2read.c (struct dw2_symtab_iterator):
2674         <want_specific_block>: Remove.
2675         <block_index>: Change type to gdb::optional.
2676         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2677         change type of BLOCK_INDEX parameter to gdb::optional.
2678         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2679         (dw2_lookup_symbol): Don't pass argument for
2680         WANT_SPECIFIC_BLOCK.
2681         (dw2_expand_symtabs_for_function): Don't pass argument for
2682         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2683         (class dw2_debug_names_iterator)
2684         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2685         parameter, change BLOCK_INDEX type to gdb::optional.
2686         <m_want_specific_block>: Remove.
2687         <m_block_index>: Change type to gdb::optional.
2688         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2689         gdb::optional.  Re-write in function of gdb::optional.
2690         (dw2_debug_names_lookup_symbol): Don't pass argument for
2691         WANT_SPECIFIC_BLOCK.
2692         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2693         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2694         BLOCK_INDEX.
2695
2696 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2697
2698         * NEWS: Mention changes to "info sources" command.
2699
2700 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2701
2702         * symtab.c (filename_partial_match_opts): New struct type.
2703         (struct output_source_filename_data): New members
2704         regexp, c_regexp, partial_match.
2705         (output_source_filename): Use new members to decide to print file.
2706         (info_sources_option_defs): New variable.
2707         (make_info_sources_options_def_group, print_info_sources_header,
2708         info_sources_command_completer):
2709         New functions.
2710         (info_sources_command): Read new optional arguments.
2711         (_initialize_symtab): Update info sources help.
2712
2713 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2714
2715         * ada-lang.c (exception_support_info_v0): Renamed from...
2716         (default_exception_support_info): ... this.  Create new
2717         definition for v1.
2718         (ada_has_this_exception_support): Look up catch_handlers_sym.
2719         (ada_exception_support_info_sniffer): Try v0 after default.
2720
2721 2019-08-01  Tom Tromey  <tromey@adacore.com>
2722
2723         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2724         gdbarch.h.
2725
2726 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * s12z-tdep.c: Fix include path for s12z-opc.h.
2729
2730 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2731
2732         * NEWS: Require GNU make 3.82.
2733
2734 2019-07-16  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2737         declare.
2738
2739 2019-07-30  Tom Tromey  <tromey@adacore.com>
2740
2741         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2742
2743 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2744
2745         * printcmd.c (print_address_symbolic): Print negative offsets.
2746         (build_address_symbolic): Force signed arithmetic when computing
2747         offset.
2748
2749 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2750
2751         PR/24474: Add a function to lookup static variables.
2752         * NEWS: Mention this new function.
2753         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2754         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2755         * python/python.c (python_GdbMethods): Add new function.
2756
2757 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2758
2759         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2760         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2761         (objfpy_lookup_static_symbol): New function.
2762         (objfile_object_methods): Add new functions.
2763
2764 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2765
2766         * NEWS: Mention 'set|show print frame-info'.  Mention new
2767         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2768         backtrace argument.  Mention that python frame filtering code
2769         is now consistent with what 'backtrace' command prints.
2770
2771 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2772
2773         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2774         comments.
2775         (print_frame_info_auto, print_frame_info_source_line,
2776         print_frame_info_location, print_frame_info_source_and_location,
2777         print_frame_info_location_and_address, print_frame_info_short_location):
2778         New declarations.
2779         (struct frame_print_options): New member print_frame_info.
2780         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2781         * stack.h (get_user_print_what_frame_info): New declaration.
2782         (frame_show_address): New declaration.
2783         * stack.c (print_frame_arguments_choices): New value 'presence'.
2784         (print_frame_info_auto, print_frame_info_source_line,
2785         print_frame_info_location, print_frame_info_source_and_location,
2786         print_frame_info_location_and_address, print_frame_info_short_location,
2787         print_frame_info_choices, print_frame_info_print_what): New definitions.
2788         (print_frame_args): Only print dots for args if print frame-arguments
2789         is 'presence'.
2790         (frame_print_option_defs): New element for "frame-info".
2791         (get_user_print_what_frame_info): New function.
2792         (frame_show_address): Make non static.  Move comment to stack.h.
2793         (print_frame_info_to_print_what): New function.
2794         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2795         to decide what to print.
2796         (backtrace_command_1): Handle the new print_frame_arguments_presence
2797         value.
2798         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2799         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2800         (py_print_frame): In non-mi mode, use LOCATION as default for
2801         print_what, similarly to frame information printed directly by
2802         backtrace command. Handle frame-info user option in non MI mode.
2803
2804 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2805
2806         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2807         Add case for debugging 32-bit target on 64-bit host.  Revise
2808         comment.
2809
2810 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2811
2812         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2813         instead of find_function_entry_range_from_pc.
2814
2815 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2816
2817         * stack.c (find_frame_funname): Remove code which preferred
2818         minsym over symtab sym in "certain pathological cases".
2819
2820         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2821         parameter.  Change type of "do_demangle" to bool.
2822         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2823         Pass suitable "prefer_sym_over_minsym" flag to
2824         build_address_symbolic().  Don't output "+" for negative offsets.
2825         * printcmd.c (print_address_symbolic): Update invocation of
2826         build_address_symbolic to include a "prefer_sym_over_minsym"
2827         flag.
2828         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2829         Restrict cases in which use of minimal symbol is preferred to that
2830         of a found symbol.  Update comments.
2831
2832         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2833         for entry pc when entry pc is out of range for that FDE.
2834
2835 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2836
2837         PR gdb/24839:
2838         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2839         type.
2840
2841 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2842
2843         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2844         this function's Python signature.
2845
2846
2847 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2848
2849         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2850         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2851         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2852         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2853         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2854
2855
2856 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2857
2858         * h8300-tdep.c (h8300_register_name_common): New.
2859         h8300_register_name): Use h8300_register_name_common.
2860         (h8300s_register_name): Likewise.
2861         (h8300sx_register_name): Likewise.
2862         (h8300h_register_nam): New.
2863         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2864
2865
2866 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2867
2868         * arm-tdep.c (arm_skip_cmse_entry): New function.
2869         (arm_is_sgstubs_section): New function.
2870         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2871
2872 2019-07-22  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2875         Don't self-assign.
2876
2877 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2880         type_print.
2881
2882 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2883
2884         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2885         so that GDB doesn't match any msymbols when searching in the
2886         TYPES_DOMAIN.
2887         (print_symbol_info): Print using typedef_print or type_print based
2888         on the type of the symbol.  Add updated FIXME comment moved from...
2889         (_initialize_symtab): ... move and update FIXME comment to above.
2890
2891 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * NEWS: Mention adding -q option to "info types".
2894         * symtab.c (struct info_types_options): New struct.
2895         (info_types_options_defs): New variable.
2896         (make_info_types_options_def_group): New function.
2897         (info_types_command): Use gdb::option framework to parse options.
2898         (info_types_command_completer): New function.
2899         (_initialize_symtab): Extend the help text on "info types" and
2900         register command completer.
2901
2902 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2903
2904         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2905         (lookup_symbol_in_objfile): Change int to block_enum and add a
2906         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2907
2908 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2909
2910         * MAINTAINERS (Write After Approval): Add self.
2911
2912 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2915         instruction to the dummy code region.
2916
2917 2019-07-19  Tom Tromey  <tromey@adacore.com>
2918
2919         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2920         (ARGSUSED, PARAMS, __func__): Remove rules.
2921
2922 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2923
2924         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2925         * features/arm/arm-with-iwmmxt.c: Remove.
2926         * features/arm/arm-with-iwmmxt.xml: Remove.
2927         * features/arm/arm-with-m-fpa-layout.c: Remove.
2928         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2929         * features/arm/arm-with-m-vfp-d16.c: Remove.
2930         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2931         * features/arm/arm-with-m.c: Remove.
2932         * features/arm/arm-with-m.xml: Remove.
2933         * features/arm/arm-with-neon.c: Remove.
2934         * features/arm/arm-with-neon.xml: Remove.
2935         * features/arm/arm-with-vfpv2.c: Remove.
2936         * features/arm/arm-with-vfpv2.xml: Remove.
2937         * features/arm/arm-with-vfpv3.c: Remove.
2938         * features/arm/arm-with-vfpv3.xml: Remove.
2939
2940 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2941
2942         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2943
2944 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2945
2946         * arch/aarch32.c (aarch32_create_target_description): Create
2947         target descriptions using features.
2948         * arch/arm.c (arm_create_target_description)
2949         (arm_create_mprofile_target_description): Likewise.
2950         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2951
2952 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2953
2954         * Makefile.in: Add new files.
2955         * aarch32-tdep.c: New file.
2956         * aarch32-tdep.h: New file.
2957         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2958         Call aarch32_read_description.
2959         * arch/aarch32.c: New file.
2960         * arch/aarch32.h: New file.
2961         * arch/arm.c (arm_create_target_description)
2962         (arm_create_mprofile_target_description): New function.
2963         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2964         (arm_create_target_description)
2965         (arm_create_mprofile_target_description): New declaration.
2966         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2967         read_description functions.
2968         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2969         Likewise.
2970         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2971         * arm-tdep.c (tdesc_arm_list): New variable.
2972         (arm_register_g_packet_guesses): Call create description functions.
2973         (arm_read_description) (arm_read_mprofile_description): New
2974         function.
2975         * arm-tdep.h (arm_read_description)
2976         (arm_read_mprofile_description): Add declaration.
2977         * configure.tgt: Add new files.
2978
2979 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2980
2981         * top.c (new_ui_command): Open specified terminal just once.
2982
2983 2019-07-18  Tom Tromey  <tromey@adacore.com>
2984
2985         * symtab.c (main_name): Constify return type.
2986         * symfile.c (set_initial_language): Update.
2987         * symtab.h (main_name): Constify return type.
2988
2989 2019-07-17  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-winsource.c (tui_update_source_window)
2992         (tui_update_source_window_as_is)
2993         (tui_update_source_windows_with_line): Remove return.
2994         * tui/tui-disasm.c (tui_show_disassem)
2995         (tui_show_disassem_and_update_source): Remove return.
2996         * tui/tui.c (tui_reset): Remove return.
2997         * tui/tui-wingeneral.c
2998         (tui_check_and_display_highlight_if_needed): Remove return.
2999
3000 2019-07-17  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-winsource.h (struct tui_exec_info_window)
3007         (struct tui_source_window_base): Move from tui-data.h.
3008         * tui/tui-winsource.c: Move many method definitions from
3009         elsewhere.  Remove "structuring" comments.
3010         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3011         (tui_source_window_base::refresh_window): Move to
3012         tui-winsource.c.
3013         * tui/tui-win.c (tui_source_window_base::refresh_all)
3014         (tui_source_window_base::update_tab_width)
3015         (tui_source_window_base::set_new_height)
3016         (tui_source_window_base::do_make_visible_with_new_height): Move to
3017         tui-winsource.c.
3018         * tui/tui-source.h: Update.
3019         * tui/tui-source.c (tui_source_window_base::reset): Move to
3020         tui-winsource.c.
3021         * tui/tui-disasm.h: Update.
3022         * tui/tui-data.h (struct tui_exec_info_window): Move to
3023         tui-winsource.h.
3024         (struct tui_source_window_base): Likewise.
3025         * tui/tui-data.c (tui_source_window_base::clear_detail)
3026         (tui_source_window_base, ~tui_source_window_base): Move to
3027         tui-winsource.c.
3028
3029 2019-07-17  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-win.c (tui_resize_all)
3032         (tui_source_window_base::update_tab_width)
3033         (tui_adjust_win_heights): Update.
3034         (tui_win_info::make_invisible_and_set_new_height): Rename from
3035         make_invisible_and_set_new_height.
3036         * tui/tui-data.h (struct tui_win_info)
3037         <make_invisible_and_set_new_height>: New method.
3038
3039 2019-07-17  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui.c: Update.
3042         * tui/tui-source.h (struct tui_source_window): Move from
3043         tui-data.h.
3044         * tui/tui-layout.c: Update.
3045         * tui/tui-disasm.c: Update.
3046         * tui/tui-data.h (struct tui_source_window): Move to
3047         tui-source.h.
3048
3049 2019-07-17  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3052         tui-data.h.
3053         * tui/tui-data.h (struct tui_disasm_window): Move to
3054         tui-disasm.h.
3055
3056 2019-07-17  Tom Tromey  <tom@tromey.com>
3057
3058         * tui/tui-regs.h (struct tui_data_item_window): Move from
3059         tui-data.h.
3060         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3061         * tui/tui-data.h (struct tui_data_item_window): Move to
3062         tui-regs.h.
3063         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3064
3065 2019-07-17  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui.c: Update.
3068         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3069         (tui_cmd_window::max_height): Move to tui-command.c.
3070         * tui/tui-layout.c: Update.
3071         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3072         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3073         tui-command.c.
3074         * tui/tui-command.h (struct tui_cmd_window): Move from
3075         tui-data.h.
3076         * tui/tui-command.c: Remove "structuring" comments.
3077         (tui_cmd_window::clear_detail)
3078         (tui_cmd_window::do_make_visible_with_new_height)
3079         (tui_cmd_window::max_height): Move from elsewhere.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3084         Now static.
3085         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3086         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3087
3088 2019-07-17  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui.c: Update.
3091         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3092         tui-regs.c.
3093         * tui/tui-windata.h: Remove file.
3094         * tui/tui-windata.c: Remove file.
3095         * tui/tui-win.c (tui_data_window::set_new_height)
3096         (tui_data_window::do_make_visible_with_new_height): Move to
3097         tui-regs.c.
3098         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3099         * tui/tui-regs.c: Remove "structuring" comments.
3100         (tui_data_window::first_data_item_displayed)
3101         (tui_data_window::delete_data_content_windows)
3102         (tui_data_window::erase_data_content)
3103         (tui_data_window::display_all_data)
3104         (tui_data_window::refresh_all)
3105         (tui_data_window::do_scroll_vertical)
3106         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3107         (tui_data_window::do_make_visible_with_new_height)
3108         (tui_data_window::refresh_window): Move from elsewhere.
3109         (_initialize_tui_regs): Move to end of file.
3110         * tui/tui-layout.c: Update.
3111         * tui/tui-hooks.c: Update.
3112         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3113         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3114         tui-regs.c.
3115         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3116
3117 2019-07-17  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3120         seen.
3121
3122 2019-07-17  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-win.c (tui_source_window_base::set_new_height)
3125         (tui_source_window_base::do_make_visible_with_new_height): Use
3126         m_has_locator field directly.
3127         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3128         method.
3129         (struct tui_source_window_base) <has_locator>: Likewise.
3130
3131 2019-07-17  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3134         Don't declare.
3135         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3136         Remove.
3137         * tui/tui-win.c (tui_source_window_base::set_new_height)
3138         (tui_source_window_base::set_new_height)
3139         (make_invisible_and_set_new_height)
3140         (tui_source_window_base::do_make_visible_with_new_height)
3141         (tui_source_window_base::do_make_visible_with_new_height):
3142         Update.
3143         * tui/tui-layout.c (show_source_disasm_command, show_data)
3144         (show_source_or_disasm_and_command): Update.
3145         * tui/tui-layout.c (show_layout): Update.
3146
3147 2019-07-17  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-layout.c (make_data_window): Remove.
3150         (show_data): Unify creation and re-initialization cases.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-layout.c (make_source_window, make_disasm_window):
3155         Remove.
3156         (show_data): Unify creation and re-initialization cases.
3157
3158 2019-07-17  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-layout.c (make_command_window): Remove.
3161         (show_source_disasm_command, show_source_or_disasm_and_command):
3162         Unify creation and re-initialization cases.
3163
3164 2019-07-17  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3167         creation and re-initialization cases.
3168
3169 2019-07-17  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-regs.c (tui_get_register): Return void.
3172
3173 2019-07-17  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3176         Simplify.
3177
3178 2019-07-17  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3181         resetting.
3182
3183 2019-07-17  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3186         * tui/tui-regs.c (tui_reg_layout): New function.
3187         (tui_show_registers, tui_reg_command): Use it.
3188         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3189         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3190         parameters.
3191         (tui_layout_command): Remove.
3192
3193 2019-07-17  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-layout.h (tui/tui-layout): Return void.
3196         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3197
3198 2019-07-17  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-layout.c (show_source_disasm_command, show_data):
3201         Update.
3202         (reset_locator): Remove.
3203         (show_source_or_disasm_and_command): Update.
3204
3205 2019-07-17  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-source.c (tui_source_window_base::reset): Remove
3208         win_type parameter.
3209         * tui/tui-layout.c (make_command_window, make_source_window)
3210         (make_disasm_window, make_data_window)
3211         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3212         (reset_locator, show_source_or_disasm_and_command): Update.
3213         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3214         win_type parameter.
3215         (struct tui_source_window_base) <reset>: Likewise.
3216
3217 2019-07-17  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-layout.c (show_source_disasm_command): Use
3220         reset_locator.
3221         (reset_locator): New function.
3222         (init_and_make_win): Remove.
3223         (show_source_or_disasm_and_command): Use reset_locator.
3224
3225 2019-07-17  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3228         condition.
3229         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3230         Remove condition.
3231         * tui/tui-source.c (tui_source_window_base::reset): New method.
3232         * tui/tui-layout.c (make_command_window): Don't call
3233         init_and_make_win.
3234         (make_source_window, make_disasm_window): Don't call
3235         make_source_or_disasm_window.
3236         (make_data_window): Don't call init_and_make_win.  Change calling
3237         convention.
3238         (show_source_disasm_command, show_data): Simplify.
3239         (make_source_or_disasm_window): Remove.
3240         (show_source_or_disasm_and_command): Simplify.
3241         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3242         (struct tui_source_window_base) <reset>: Likewise.
3243         <execution_info>: Remove initializer.
3244         * tui/tui-data.c (tui_source_window_base): Initialize
3245         execution_info.
3246
3247 2019-07-17  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3250         variable.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui.c (tui_rl_other_window): Update.
3255         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3256         superclass method first.  Always iterate over regs_content.
3257         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3258         method.
3259         * tui/tui-win.c (tui_set_focus_command): Update.
3260
3261 2019-07-17  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-win.c (tui_set_focus_command): Rename from
3264         tui_set_focus.  Call tui_enable.
3265         (tui_set_focus_command): Remove.
3266
3267 2019-07-17  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3270         refresh_window.
3271         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3272         touchwin.
3273         (tui_data_window::refresh_window): Call refresh_window on data
3274         items.  Always call superclass refresh_window.
3275         (tui_win_info::refresh): Remove.
3276         (tui_source_window_base::refresh_window): Update.
3277         (tui_refresh_all): Update.
3278         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3279         refresh_window.
3280         (show_source_or_disasm_and_command): Likewise.
3281         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3282         (struct tui_source_window_base) <refresh>: Likewise.
3283
3284 2019-07-17  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-winsource.c (tui_clear_source_content)
3287         (tui_show_source_content): Update.
3288         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3289         whether content is empty.
3290         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3291         Remove.
3292
3293 2019-07-17  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3296         window's contents.
3297         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3298         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3299
3300 2019-07-17  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3303         (struct tui_data_item_window): Update.
3304
3305 2019-07-17  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3308         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3309         defines.
3310
3311 2019-07-17  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-winsource.h (tui_erase_source_content)
3314         (tui_clear_source_content): Remove "display_prompt" parameter.
3315         * tui/tui-winsource.c (tui_update_source_window_as_is)
3316         (tui_update_source_windows_with_addr): Update.
3317         (tui_clear_source_content): Remove "display_prompt" parameter.
3318         (tui_erase_source_content): Likewise.  Simplify.
3319         (tui_show_source_content): Update.
3320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3321         * tui/tui-stack.c (tui_show_frame_info): Update.
3322         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3323         Remove defines.
3324
3325 2019-07-17  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3328         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3329         parameter.
3330         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3331         parameter.
3332
3333 2019-07-17  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.c (tui_clear_source_content)
3336         (tui_show_source_content, tui_show_exec_info_content)
3337         (tui_clear_exec_info_content): Update.
3338         * tui/tui-stack.c (tui_show_locator_content): Update.
3339         (tui_show_frame_info): Update.
3340         * tui/tui-source.h (tui_source_window): Don't declare.
3341         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3342         from tui_source_is_displayed.
3343         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3344         Remove field.
3345         (struct tui_source_window_base) <content_in_use>: New field.  Now
3346         bool.
3347         (struct tui_source_window) <showing_source_p>: New method.
3348         (TUI_SRC_WIN): Change cast.
3349         * tui/tui-data.c (tui_initialize_static_data): Update.
3350
3351 2019-07-17  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3354         location_matches_p.
3355         * tui/tui-source.c (tui_source_window::location_matches_p): New
3356         method.
3357         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3358         method.
3359         * tui/tui-data.h (struct tui_source_window_base)
3360         <location_matches_p>: New method.
3361         (struct tui_source_window, struct tui_disasm_window)
3362         <location_matches_p>: Likewise.
3363
3364 2019-07-17  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-win.c (tui_set_win_height_command): Rename from
3367         tui_set_win_height.
3368         (tui_set_win_height_command): Remove.
3369
3370 2019-07-17  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-source.c (tui_source_window): New constructor.  Add
3373         observer.
3374         (~tui_source_window): New destructor.
3375         (tui_source_window::style_changed): New method.
3376         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3377         (tui_attach_detach_observers): Update.
3378         * tui/tui-data.h (struct tui_source_window): Make constructor not
3379         inline.  Add destructor.
3380         (struct tui_source_window) <style_changed>: New method.
3381         <m_observable>: New member.
3382
3383 2019-07-17  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3386         * tui/tui-win.c (tui_resize_all): Fix typo.
3387
3388 2019-07-17  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3391         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3392         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3393         * tui/tui-win.c (window_name_completer): Use foreach.
3394         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3395         (update_tab_width): Likewise.
3396         * tui/tui-layout.c (show_layout): Update.
3397         * tui/tui-data.h (class tui_window_iterator): New.
3398         (struct all_tui_windows): New.
3399         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3400
3401 2019-07-17  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3404         parameter.  Don't reference globals.
3405         (tui_reg_command): Update.
3406
3407 2019-07-17  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-regs.c (tui_show_registers): Simplify.
3410
3411 2019-07-17  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-regs.c (tui_show_registers): Update.
3414         (tui_show_register_group): Add win_info parameter.
3415
3416 2019-07-17  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3419         Rename from tui_display_reg_element_at_line.
3420         (tui_data_window::display_registers_from_line): Update.
3421         * tui/tui-data.h (struct tui_data_window)
3422         <display_reg_element_at_line>: New method.
3423
3424 2019-07-17  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-regs.h (tui_display_registers_from)
3427         (tui_display_registers_from_line): Don't declare.
3428         * tui/tui-windata.c (tui_data_window::display_all_data)
3429         (tui_data_window::refresh_all)
3430         (tui_data_window::do_scroll_vertical): Update.
3431         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3432         from tui_display_registers_from.
3433         (tui_display_reg_element_at_line): Update.
3434         (tui_data_window::display_registers_from_line): Rename from
3435         tui_display_registers_from_line.
3436         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3437         display_registers_from_line>: New methods.
3438
3439 2019-07-17  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3442         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3443         from tui_erase_data_content.
3444         (tui_data_window::display_all_data)
3445         (tui_data_window::refresh_all)
3446         (tui_data_window::do_scroll_vertical): Update.
3447         * tui/tui-regs.c (tui_show_registers): Update.
3448         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3449         New method.
3450
3451 2019-07-17  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3454         declare.
3455         * tui/tui-windata.c
3456         (tui_data_window::delete_data_content_windows): Rename from
3457         tui_delete_data_content_windows.
3458         (tui_data_window::display_all_data)
3459         (tui_data_window::do_scroll_vertical): Update.
3460         * tui/tui-data.h (struct tui_data_window)
3461         <delete_data_content_windows>: New method.
3462
3463 2019-07-17  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3466         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3467
3468 2019-07-17  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3471         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3472         from tui_display_all_data.
3473         * tui/tui-win.c
3474         (tui_data_window::do_make_visible_with_new_height): Update.
3475         * tui/tui-regs.c (tui_show_registers): Update.
3476         * tui/tui-layout.c (tui_set_layout): Update.
3477         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3478         method.
3479
3480 2019-07-17  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3483         * tui/tui-windata.c (tui_display_data_from): Remove.
3484         (tui_data_window::refresh_all): Update.
3485
3486 2019-07-17  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3489         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3490         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3491         tui_display_registers_from_line.
3492         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3493         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3494         "force_display" parameter.
3495
3496 2019-07-17  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3499         declare.
3500         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3501         Rename from tui_first_reg_element_no_inline.
3502         (tui_display_reg_element_at_line)
3503         (tui_display_registers_from_line): Update.
3504         * tui/tui-data.h (struct tui_data_window)
3505         <first_reg_element_no_inline>: New method.
3506
3507 2019-07-17  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-windata.c (tui_display_data_from)
3510         (tui_data_window::do_scroll_vertical): Update.
3511         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3512         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3513         Rename from tui_line_from_reg_element_no.
3514         (tui_display_registers_from_line): Update.
3515         * tui/tui-data.h (struct tui_data_window)
3516         <line_from_reg_element_no>: New method.
3517
3518 2019-07-17  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3521         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3522         tui_last_regs_line_no.
3523         (tui_display_reg_element_at_line)
3524         (tui_display_registers_from_line): Update.
3525         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3526         method.
3527
3528 2019-07-17  Tom Tromey  <tom@tromey.com>
3529
3530         PR tui/24722:
3531         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3532         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3533         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3534         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3535         (tui_update_breakpoint_info): Likewise.
3536         * tui/tui-hooks.c (tui_event_create_breakpoint)
3537         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3538         Update.
3539
3540 2019-07-17  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3543
3544 2019-07-17  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-winsource.c (tui_update_source_window_as_is)
3547         (tui_update_source_windows_with_addr): Update.
3548         * tui/tui-source.h (tui_set_source_content)
3549         (tui_show_symtab_source): Add "win_info" parameter.
3550         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3551         parameter.
3552         (tui_show_symtab_source): Likewise.
3553
3554 2019-07-17  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-wingeneral.c
3557         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3558
3559 2019-07-17  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3562         (struct tui_cmd_window) <can_scroll>: New method.
3563         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3564         method.
3565
3566 2019-07-17  Tom Tromey  <tromey@adacore.com>
3567
3568         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3569         do_field_signed>: Rename.  Change type of "value".
3570         * ui-out.c (ui_out::field_signed): Rename from field_int.
3571         Change type of "value".
3572         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3573         type of "value".
3574         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3575         do_field_int.  Change type of "value".
3576         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3577         do_field_int.  Change type of "value".
3578         * tracepoint.c (trace_status_mi, tfind_1)
3579         (print_one_static_tracepoint_marker): Update.
3580         * thread.c (print_thread_info_1, print_selected_thread_frame):
3581         Update.
3582         * stack.c (print_frame, print_frame_info): Update.
3583         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3584         Update.
3585         * source.c (print_source_lines_base): Update.
3586         * skip.c (info_skip_command): Update.
3587         * record-btrace.c (btrace_ui_out_decode_error)
3588         (btrace_call_history_src_line): Update.
3589         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3590         Update.
3591         * progspace.c (print_program_space): Update.
3592         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3593         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3594         do_field_int.  Change type of "value".
3595         * mi/mi-out.c (mi_ui_out::do_table_begin)
3596         (mi_ui_out::do_table_header): Update.
3597         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3598         type of "value".
3599         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3600         (mi_cmd_data_list_changed_registers, output_register)
3601         (mi_cmd_data_read_memory, mi_load_progress)
3602         (mi_cmd_trace_frame_collected): Update.
3603         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3604         Update.
3605         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3606         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3607         (mi_cmd_var_list_children, varobj_update_one): Update.
3608         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3609         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3610         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3611         * inferior.c (print_inferior): Update.
3612         * gdb_bfd.c (print_one_bfd): Update.
3613         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3614         Update.
3615         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3616         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3617         do_field_int.  Change type of "value".
3618         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3619         do_field_int.  Change type of "value".
3620         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3621         (print_one_breakpoint_location, print_it_catch_fork)
3622         (print_one_catch_fork, print_it_catch_vfork)
3623         (print_one_catch_vfork, print_it_catch_solib)
3624         (print_it_catch_exec, print_it_ranged_breakpoint)
3625         (print_mention_watchpoint, print_mention_masked_watchpoint)
3626         (bkpt_print_it, update_static_tracepoint): Update.
3627         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3628         * break-catch-syscall.c (print_it_catch_syscall): Update.
3629         * ada-tasks.c (print_ada_task_info): Update.
3630         * ada-lang.c (print_it_exception, print_mention_exception):
3631         Update.
3632
3633 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         PR breakpoints/24541
3636         * gdbarch.c: Regenerate.
3637         * gdbarch.h: Regenerate.
3638         * gdbarch.sh: Adjust return type and parameter types for
3639         'stap_adjust_register'.
3640         (i386_stap_adjust_register): Adjust signature and return new
3641         register name.
3642         * stap-probe.c (stap_parse_register_operand): Adjust use of
3643         'gdbarch_stap_adjust_register'.
3644
3645 2019-07-17  Tom Tromey  <tromey@adacore.com>
3646
3647         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3648         declare VEC.
3649         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3650         std::vector.
3651         (struct s390_process_info): Add initializers.
3652         (s390_add_process): Use new.
3653         (s390_linux_nat_target::low_forget_process): Use delete.
3654         (s390_linux_nat_target::low_new_fork)
3655         (s390_linux_nat_target::stopped_by_watchpoint)
3656         (s390_linux_nat_target::low_prepare_to_resume)
3657         (s390_linux_nat_target::insert_watchpoint)
3658         (s390_linux_nat_target::insert_hw_breakpoint)
3659         (s390_linux_nat_target::remove_watchpoint)
3660         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3661
3662 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3663
3664         * aarch64-fbsd-nat.c: Include regcache.h.
3665         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3666         argument.
3667         (aarch64_fbsd_nat_target::fetch_registers)
3668         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3669         variable.
3670         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3671
3672 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3673
3674         * fbsd-nat.c: Include gdbarch.h.
3675
3676 2019-07-15  Tom Tromey  <tromey@adacore.com>
3677
3678         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3679
3680 2019-07-15  Tom Tromey  <tromey@adacore.com>
3681
3682         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3683         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3684         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3685         * cli-out.c (cli_ui_out::do_field_int): New method.
3686         * ui-out.c (ui_out::field_unsigned): New method.
3687         * symfile.c (generic_load): Use field_unsigned.
3688         (print_transfer_performance): Likewise.
3689         * record-btrace.c (ui_out_field_uint): Remove.
3690         (btrace_call_history_insn_range, btrace_call_history): Use
3691         field_unsigned.
3692         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3693         field_unsigned.
3694         * ui-out.h (class ui_out) <field_unsigned>: New method.
3695         <do_field_unsigned>: Likewise.
3696
3697 2019-07-15  Tom Tromey  <tromey@adacore.com>
3698
3699         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3700         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3701         * target.c (flash_erase_command): Use field_string.
3702         * infrun.c (print_signal_received_reason): Use field_string.
3703         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3704         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3705         field_string.
3706         * ada-tasks.c (print_ada_task_info): Use field_string.
3707
3708 2019-07-15  Tom Tromey  <tromey@adacore.com>
3709
3710         * target.c (flash_erase_command): Use field_core_addr.
3711         * symfile.c (generic_load): Use field_core_addr.
3712         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3713         Use field_core_addr.
3714         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3715         field_core_addr.
3716
3717 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3720         value if its desired type is smaller than a CORE_ADDR and signed.
3721
3722 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3725         of changes to field names, and use new is_reference field to
3726         decide if a property is a reference or not.
3727         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3728         field.
3729         (struct dwarf2_property_baton): Update header comment, rename
3730         'referenced_type' to 'property_type' and update comments.
3731         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3732         default property type, store in property baton, update to take
3733         accound of renamed field.
3734         (read_func_scope): Update call to attr_to_dynamic_prop.
3735         (read_array_type): Likewise.
3736         (dwarf2_per_cu_addr_sized_int_type): New function.
3737         (read_subrange_index_type): Move type finding code to
3738         dwarf2_per_cu_addr_sized_int_type.
3739         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3740         (dwarf2_per_cu_addr_type): New function.
3741         (set_die_type): Update calls to attr_to_dynamic_prop.
3742
3743 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3744
3745         * dwarf2read.c (read_subrange_index_type): New function.
3746         (read_subrange_type): Move code into new function and call it.
3747         * gdbtypes.c (create_range_type): Add some asserts.
3748
3749 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3752         update return statements.
3753         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3754         declaration, and update comment to match.
3755         * gdbtypes.c (resolve_dynamic_array): Update call to
3756         dwarf2_evaluate_property to match new return type.
3757
3758 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * valarith.c (value_subscripted_rvalue): Change lowerbound
3761         parameter type from int to LONGEST.
3762         * value.h (value_subscripted_rvalue): Likewise in declaration.
3763
3764 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * cli/cli-utils.c (info_print_command_completer): New function.
3767         * cli/cli-utils.h: Add 'completer.h' include, and forward
3768         declaration for 'struct cmd_list_element'.
3769         (info_print_command_completer): Declare.
3770         * stack.c (_initialize_stack): Add completer for 'info locals' and
3771         'info args'.
3772         * symtab.c (_initialize_symtab): Add completer for 'info
3773         variables' and 'info functions'.
3774         * NEWS: Mention completion for additional info commands.
3775
3776 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * cli/cli-utils.c (extract_info_print_args): Delete.
3779         (extract_arg_maybe_quoted): Delete.
3780         (info_print_options_defs): New variable.
3781         (make_info_print_options_def_group): New function.
3782         (extract_info_print_options): Define new function.
3783         * cli/cli-utils.h (extract_info_print_args): Delete.
3784         (struct info_print_options): New structure.
3785         (extract_info_print_options): Declare new function.
3786         * stack.c (info_locals_command): Update to use new
3787         extract_info_print_options, also add a header comment.
3788         (info_args_command): Likewise.
3789         * symtab.c (info_variables_command): Likewise.
3790         (info_functions_command): Likewise.
3791
3792 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3795         to extract string arguments.
3796         * common/common-utils.c (extract_string_maybe_quoted): New function.
3797         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3798
3799 2019-07-11  Tom Tromey  <tromey@adacore.com>
3800
3801         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3802         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3803         * top.h (gdbinit): Don't declare.
3804         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3805         into...
3806         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3807         * top.c (gdb_init): Don't call init_cli_cmds.
3808         (gdbinit): Remove.
3809         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3810
3811 2019-07-11  Tom Tromey  <tromey@adacore.com>
3812
3813         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3814         after it has been moved.
3815
3816 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3817
3818         * valops.c (value_must_coerce_to_target): Change return type to
3819         bool.
3820         * value.h (value_must_coerce_to_target): Likewise.
3821
3822 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3823
3824         * breakpoint.c (is_hardware_watchpoint): Remove
3825         forward-declaration.
3826         (is_masked_watchpoint): Change return type to bool.
3827         (is_tracepoint): Likewise.
3828         (is_breakpoint): Likewise.
3829         (is_hardware_watchpoint): Likewise.
3830         (is_watchpoint): Likewise.
3831         (is_no_memory_software_watchpoint): Likewise.
3832         (is_catchpoint): Likewise.
3833         (breakpoint_1): Make FILTER parameter's return type bool.
3834         is_masked_watchpoint): Change return type to bool.
3835         (save_breakpoints): Make FILTER parameter's return type bool.
3836         * breakpoint.h (is_breakpoint): Change return type to bool.
3837         (is_watchpoint): Likewise.
3838         (is_catchpoint): Likewise.
3839         (is_tracepoint): Likewise.
3840
3841 2019-07-10  Tom Tromey  <tom@tromey.com>
3842
3843         * defs.h: Don't include gdbarch.h.
3844         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3845         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3846         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3847         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3848         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3849         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3850         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3851         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3852         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3853         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3854         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3855         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3856         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3857         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3858         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3859         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3860         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3861         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3862         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3863         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3864         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3865         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3866         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3867         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3868         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3869         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3870         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3871
3872 2019-07-10  Tom Tromey  <tromey@adacore.com>
3873
3874         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3875         * breakpoint.c (init_ada_exception_breakpoint): Register as
3876         bp_catchpoint.
3877         (print_one_breakpoint_location, print_one_breakpoint): Use
3878         is_ada_exception_catchpoint.
3879         * ada-lang.c (class ada_catchpoint_location): Pass
3880         bp_loc_software_breakpoint to bp_location constructor.
3881         (is_ada_exception_catchpoint): New function.
3882
3883 2019-07-10  Tom Tromey  <tromey@adacore.com>
3884
3885         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3886         VEC.
3887         (struct arm_exidx_entry): New method operator<.
3888         (struct arm_exidx_data) <section_maps>: Change type.
3889         (arm_exidx_data_free): Remove.
3890         (arm_exidx_data_key): Change type.  Move lower.
3891         (arm_exidx_new_objfile): Update.
3892         (arm_compare_exidx_entries): Remove.
3893         (arm_find_exidx_entry, _initialize_arm_tdep)
3894
3895 2019-07-10  Tom Tromey  <tromey@adacore.com>
3896
3897         * solib-spu.c (ocl_program_data_key): Change type.
3898         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3899         Update.
3900
3901 2019-07-10  Tom Tromey  <tromey@adacore.com>
3902
3903         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3904         (struct solib_aix_inferior_data) <library_list>: Change type.
3905         (solib_aix_inferior_data_handle): Change type.
3906         (get_solib_aix_inferior_data): Update.
3907         (solib_aix_free_library_list): Remove.
3908         (library_list_start_library): Update.
3909         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3910         return type.
3911         (solib_aix_get_library_list)
3912         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3913         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3914
3915 2019-07-10  Tom Tromey  <tromey@adacore.com>
3916
3917         * solib-dsbt.c (struct dsbt_info): Add initializers.
3918         (solib_dsbt_pspace_data): Change type.
3919         (dsbt_pspace_data_cleanup): Remove.
3920         (get_dsbt_info, _initialize_dsbt_solib): Update.
3921
3922 2019-07-10  Tom Tromey  <tromey@adacore.com>
3923
3924         * spu-tdep.c (spu_overlay_data): Change type.
3925         (spu_get_overlay_table, spu_overlay_new_objfile)
3926         (_initialize_spu_tdep): Update.
3927
3928 2019-07-10  Tom Tromey  <tromey@adacore.com>
3929
3930         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3931         destructor.
3932         (dbx_objfile_data_key): Change type and declare later.
3933         (DBX_SYMFILE_INFO): Rewrite.
3934         * dbxread.c (dbx_objfile_data_key): Change type.
3935         (dbx_symfile_init): Update.
3936         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3937         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3938         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3939
3940 2019-07-10  Tom Tromey  <tromey@adacore.com>
3941
3942         * jit.c (jit_program_space_key): Change type.  Move lower.
3943         (get_jit_program_space_data): Update.
3944         (jit_program_space_data_cleanup): Remove.
3945         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3946         Update.
3947         (struct jit_program_space_data): Add initializers.
3948
3949 2019-07-10  Tom Tromey  <tromey@adacore.com>
3950
3951         * solib-darwin.c (struct darwin_info): Add initializers.
3952         (solib_darwin_pspace_data): Change type.
3953         (darwin_pspace_data_cleanup): Remove.
3954         (get_darwin_info, _initialize_darwin_solib): Update.
3955
3956 2019-07-10  Tom Tromey  <tromey@adacore.com>
3957
3958         * remote-sim.c (struct sim_inferior_data): Add initializers,
3959         constructor, and destructor.
3960         (sim_inferior_data_key): Change type.  Move lower.
3961         (check_for_duplicate_sim_descriptor): Update.
3962         (get_sim_inferior_data): Use new.  Update.
3963         (~sim_inferior_data_cleanup): Rename from
3964         sim_inferior_data_cleanup.  Simplify.
3965         (gdbsim_close_inferior, simulator_command)
3966         (sim_command_completer, _initialize_remote_sim): Update.
3967         (next_pid, INITIAL_PID): Move earlier.
3968
3969 2019-07-10  Tom Tromey  <tromey@adacore.com>
3970
3971         * python/python-internal.h (create_thread_object): Return
3972         gdbpy_ref.
3973         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3974         * python/py-inferior.c (struct threadlist_entry): Add
3975         constructor.
3976         <thread_obj>: Now a gdbpy_ref.
3977         (thread_to_thread_object): Update.
3978         (add_thread_object): Use new.
3979         (delete_thread_object): Use delete.
3980         (infpy_threads): Update.
3981         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3982         GIL.
3983
3984 2019-07-10  Tom Tromey  <tromey@adacore.com>
3985
3986         * valops.c (value_cast): Specialize error message for Ada.
3987
3988 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3989
3990         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3991
3992 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3993
3994         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3995         bpstat_should_step): Return bool, adjust comments.
3996         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3997         bpstat_should_step): Likewise.
3998
3999 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * features/Makefile: Use feature target descriptions for Arm.
4002         * features/arm/arm-core.c: Generate new file.
4003         * features/arm/arm-fpa.c: Likewise.
4004         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4005         * features/arm/arm-m-profile.c: Likewise.
4006         * features/arm/arm-vfpv2.c: Likewise.
4007         * features/arm/arm-vfpv3.c: Likewise.
4008         * features/arm/xscale-iwmmxt.c: Likewise.
4009         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4010
4011 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4012
4013         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4014         ptrace earlier.
4015
4016 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4017
4018         * features/aarch64-pauth.c: Regenerate.
4019
4020 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4021
4022         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4023         bool.
4024         (bpstat_what): Use false instead of 0.
4025
4026 2019-07-09  Pedro Alves  <palves@redhat.com>
4027
4028         * break-catch-throw.c (is_exception_catchpoint): New.
4029         * breakpoint.c (print_one_breakpoint_location): New parameter
4030         'raw_loc'.  Handle it.  Use
4031         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4032         looking at the breakpoint's type.
4033         (print_one_breakpoint): If handling "maint info breakpoints", also
4034         print locations of exception catchpoints.
4035         * breakpoint.h (is_exception_catchpoint): Declare.
4036
4037 2019-07-09  Pedro Alves  <palves@redhat.com>
4038
4039         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4040         "addr" field.
4041         (allocate_location_exception_catchpoint): New.
4042         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4043         (initialize_throw_catchpoint_ops): Install
4044         allocate_location_exception_catchpoint as allocate_location
4045         method.
4046         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4047         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4048         bp_loc_other.
4049         (breakpoint_address_is_meaningful): Delete.
4050         (bl_address_is_meaningful): New.
4051         (breakpoint_locations_match): Adjust comment.
4052         (bp_location_from_bp_type): New, factored out of...
4053         (bp_location::bp_location(breakpoint *)): ... this.
4054         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4055         factored out of...
4056         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4057         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4058         breakpoint_address_is_meaningful.
4059         (bp_locations_compare): Adjust comment.
4060         (update_global_location_list): Use bl_address_is_meaningful
4061         instead of breakpoint_address_is_meaningful.
4062         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4063         explicit.
4064         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4065         * python/py-breakpoint.c (bppy_get_location): No longer check
4066         whether location is null.
4067
4068 2019-07-09  Pedro Alves  <palves@redhat.com>
4069
4070         PR c++/15468
4071         * breakpoint.c (print_one_breakpoint_location): Remove
4072         single-location assert.
4073
4074 2019-07-09  Tom Tromey  <tom@tromey.com>
4075
4076         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4077         * configure: Rebuild.
4078         * configure.ac: Change common to gdbsupport.
4079         * gdbsupport: Rename from common.
4080         * acinclude.m4: Change common to gdbsupport.
4081         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4082         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4083         gdbsupport.
4084         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4085         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4086         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4087         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4088         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4089         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4090         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4091         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4092         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4093         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4094         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4095         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4096         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4097         coff-pe-read.c, command.h, compile/compile-c-support.c,
4098         compile/compile-c.h, compile/compile-cplus-symbols.c,
4099         compile/compile-cplus-types.c, compile/compile-cplus.h,
4100         compile/compile-loc2c.c, compile/compile.c, completer.c,
4101         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4102         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4103         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4104         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4105         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4106         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4107         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4108         features/aarch64-core.c, features/aarch64-fpu.c,
4109         features/aarch64-pauth.c, features/aarch64-sve.c,
4110         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4111         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4112         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4113         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4114         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4115         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4116         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4117         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4118         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4119         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4120         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4121         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4122         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4123         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4124         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4125         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4126         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4127         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4128         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4129         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4130         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4131         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4132         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4133         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4134         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4135         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4136         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4137         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4138         minsyms.c, mips-linux-tdep.c, namespace.h,
4139         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4140         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4141         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4142         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4143         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4144         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4145         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4146         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4147         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4148         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4149         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4150         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4151         procfs.c, producer.c, progspace.h, psymtab.h,
4152         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4153         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4154         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4155         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4156         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4157         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4158         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4159         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4160         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4161         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4162         target-memory.c, target.c, target.h, target/waitstatus.c,
4163         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4164         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4165         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4166         unittests/array-view-selftests.c,
4167         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4168         unittests/common-utils-selftests.c,
4169         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4170         unittests/format_pieces-selftests.c,
4171         unittests/function-view-selftests.c,
4172         unittests/lookup_name_info-selftests.c,
4173         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4174         unittests/mkdir-recursive-selftests.c,
4175         unittests/observable-selftests.c,
4176         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4177         unittests/parse-connection-spec-selftests.c,
4178         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4179         unittests/scoped_fd-selftests.c,
4180         unittests/scoped_mmap-selftests.c,
4181         unittests/scoped_restore-selftests.c,
4182         unittests/string_view-selftests.c, unittests/style-selftests.c,
4183         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4184         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4185         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4186         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4187         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4188         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4189
4190 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4193         bool value.
4194         (decode_digits_ordinary): Set explicit_line field in sal.
4195         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4196         symtab_and_line that was set on an explicit line number in
4197         assembler code.  Do always update the recorded symtab and line if
4198         we do skip the prologue.
4199
4200 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * breakpoint.c (set_breakpoint_location_function): Remove
4203         explicit_loc parameter.
4204         (momentary_breakpoint_from_master): Update call to
4205         set_breakpoint_location_function.
4206         (add_location_to_breakpoint): Likewise.
4207
4208 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4211         required features based on default bfd type when no specific bfd
4212         is present.
4213
4214 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4215
4216         * NEWS: Mention that GDB printf and eval commands can now print
4217         C-style and Ada-style convenience var strings without
4218         calling the inferior.
4219         * printcmd.c (printf_c_string): Locally print GDB internal var
4220         instead of transiting via the inferior.
4221         (printf_wide_c_string): Likewise.
4222
4223 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4224
4225         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4226
4227 2019-07-04  Tom Tromey  <tom@tromey.com>
4228
4229         PR tui/24724:
4230         * tui/tui-winsource.c (tui_clear_source_content): Update.
4231         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4232         (tui_update_breakpoint_info): Update.
4233         (tui_set_exec_info_content): Update.
4234         * tui/tui-source.c (tui_set_source_content_nil): Update.
4235         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4236         has_break.
4237         * tui/tui-data.h (enum tui_bp_flag): New.
4238         (tui_bp_flags): New enum flags type.
4239         (struct tui_source_element) <break_mode>: Change type.  Rename
4240         from has_break.
4241         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4242         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4243         constants.
4244         * tui/tui-winsource.h: Fix comment.
4245
4246 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4247
4248         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4249         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4250         (store_fpregs_to_thread)
4251         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4252         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4253         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4254         (IWMMXT_REGS_SIZE): Add define.
4255         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4256         (fetch_vfp_regs, store_vfp_regs)
4257         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4258         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4259
4260 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4263         defines.
4264         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4265         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4266         (ARM_INT_REGISTER_SIZE): ...to this.
4267         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4268         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4269         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4270         (arm_linux_collect_gregset, supply_nwfpe_register)
4271         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4272         defines.
4273         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4274         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4275         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4276         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4277         (arm_return_in_memory, arm_store_return_value)
4278         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4279         (arm_record_ld_st_multiple): Likewise.
4280         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4281         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4282
4283 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4284
4285         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4286         AARCH64_DISPLACED_MODIFIED_INSNS.
4287         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4288         (aarch64_displaced_step_copy_insn): Likewise.
4289         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4290         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4291         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4292         ARM_DISPLACED_MODIFIED_INSNS.
4293         * arm-tdep.c (arm_gdbarch_init): Likewise.
4294         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4295         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4296         (struct arm_displaced_step_closure): Use
4297         ARM_DISPLACED_MODIFIED_INSNS.
4298
4299 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4300
4301         * features/Makefile: Remove unused xml files.
4302         * features/aarch64.xml: Remove.
4303         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4304         * features/i386/amd64-avx-avx512.xml: Remove.
4305         * features/i386/amd64-avx-linux.xml: Remove.
4306         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4307         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4308         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4309         * features/i386/amd64-avx-mpx.xml: Remove.
4310         * features/i386/amd64-avx.xml: Remove.
4311         * features/i386/amd64-linux.xml: Remove.
4312         * features/i386/amd64-mpx-linux.xml: Remove.
4313         * features/i386/amd64-mpx.xml: Remove.
4314         * features/i386/amd64.xml: Remove.
4315         * features/i386/i386-avx-avx512-linux.xml: Remove.
4316         * features/i386/i386-avx-avx512.xml: Remove.
4317         * features/i386/i386-avx-linux.xml: Remove.
4318         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4319         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4320         * features/i386/i386-avx-mpx-linux.xml: Remove.
4321         * features/i386/i386-avx-mpx.xml: Remove.
4322         * features/i386/i386-avx.xml: Remove.
4323         * features/i386/i386-linux.xml: Remove.
4324         * features/i386/i386-mmx-linux.xml: Remove.
4325         * features/i386/i386-mmx.xml: Remove.
4326         * features/i386/i386-mpx-linux.xml: Remove.
4327         * features/i386/i386-mpx.xml: Remove.
4328         * features/i386/i386.xml: Remove.
4329         * features/i386/x32-avx-avx512-linux.xml: Remove.
4330         * features/i386/x32-avx-linux.xml: Remove.
4331         * features/i386/x32-linux.xml: Remove.
4332
4333 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4334
4335         * regformats/aarch64.dat: Remove.
4336         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4337         * regformats/i386/amd64-avx-linux.dat: Remove.
4338         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4339         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4340         * regformats/i386/amd64-linux.dat: Remove.
4341         * regformats/i386/amd64-mpx-linux.dat: Remove.
4342         * regformats/i386/amd64.dat: Remove.
4343         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4344         * regformats/i386/i386-avx-linux.dat: Remove.
4345         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4346         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4347         * regformats/i386/i386-linux.dat: Remove.
4348         * regformats/i386/i386-mmx-linux.dat: Remove.
4349         * regformats/i386/i386-mpx-linux.dat: Remove.
4350         * regformats/i386/i386.dat: Remove.
4351         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4352         * regformats/i386/x32-avx-linux.dat: Remove.
4353         * regformats/i386/x32-linux.dat: Remove.
4354
4355 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * aarch64-tdep.c: Remove xml self tests.
4358         * amd64-linux-tdep.c: Likewise.
4359         * amd64-tdep.c: Likewise.
4360         * i386-linux-tdep.c: Likewise.
4361         * i386-tdep.c: Likewise.
4362
4363 2019-07-03  Pedro Alves  <palves@redhat.com>
4364
4365         PR cli/24732
4366         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4367         (pipe_cmd_option_defs): New.
4368         (make_pipe_cmd_options_def_group): New.
4369         (pipe_command): Use gdb::option::process_options.
4370         (pipe_command_completer): New function.
4371         (_initialize_cli_cmds): Install completer for "pipe" command.
4372
4373 2019-07-03  Pedro Alves  <palves@redhat.com>
4374
4375         * cli/cli-option.c (union option_value) <string>: New field.
4376         (struct option_def_and_value): Add ctor, move ctor, dtor and
4377         use DISABLE_COPY_AND_ASSIGN.
4378         (option_def_and_value::clear_value): New.
4379         (parse_option, save_option_value_in_ctx, get_val_type_str)
4380         (add_setshow_cmds_for_options): Handle var_string.
4381         * cli-option.h (union option_def::var_address) <string>: New
4382         field.
4383         (struct string_option_def): New.
4384         * maint-test-options.c (struct test_options_opts): Add default
4385         ctor and use DISABLE_COPY_AND_ASSIGN.
4386         <string_opt>: New field.
4387         (test_options_opts::~test_options_opts): New.
4388         (test_options_opts::dump): Also dump "-string".
4389         (test_options_option_defs): Install "string.
4390
4391 2019-07-03  Pedro Alves  <palves@redhat.com>
4392
4393         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4394         option_value with a null enumeration.
4395         (complete_options): Save the option values in the context.
4396         (save_option_value_in_ctx): New, factored out from ...
4397         (process_options): ... here.
4398         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4399         of the function.
4400         * maint-test-options.c (test_options_opts::dump): New, factored
4401         out from ...
4402         (maintenance_test_options_command_mode): ... here.
4403         (maintenance_test_options_command_completion_result): Delete.
4404         (maintenance_test_options_command_completion_text): Update
4405         comment.
4406         (maintenance_show_test_options_completion_result): Change
4407         prototype.  Just print
4408         maintenance_test_options_command_completion_text.
4409         (save_completion_result): New.
4410         (maintenance_test_options_completer_mode): Pass options context to
4411         complete_options, and then save a dump.
4412         (_initialize_maint_test_options): Use add_cmd to install "maint
4413         show test-options-completion-result".
4414
4415 2019-07-03  Pedro Alves  <palves@redhat.com>
4416
4417         * NEWS (New commands): Mention "with" and "maint with".
4418         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4419         (with_command, with_command_completer): New.
4420         (pipe_command): Adjust to new repeat_previous
4421         interface.
4422         (_initialize_cli_cmds): Install the "with" command and its "w"
4423         alias.
4424         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4425         declarations.
4426         * cli/cli-setshow.c (parse_cli_var_uinteger)
4427         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4428         argument strings for all var_types.
4429         (get_setshow_command_value_string): New, factored out from ...
4430         (do_show_command): ... this.
4431         * cli/cli-setshow.h: Include <string>.
4432         (get_setshow_command_value_string): Declare.
4433         * command.h (repeat_previous): Now returns const char *.  Adjust
4434         comment.
4435         * maint.c: Include "cli/cli-cmds.h".
4436         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4437         (_initialize_maint_cmds): Register the "maintenance with" command.
4438         * top.c (repeat_previous): Move bits from pipe_command here:
4439         Return the saved command line, if any; error out if there's no
4440         command to relaunch.
4441
4442 2019-07-03  Pedro Alves  <palves@redhat.com>
4443
4444         * NEWS (New commands): Mention "maint set/show test-settings"
4445         instead of "maint test-settings".
4446         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4447         (maintenance_test_settings_set_list): Rename to ...
4448         (maintenance_set_test_settings_list): ... this.
4449         (maintenance_test_settings_show_list): Rename to  ...
4450         (maintenance_show_test_settings_list): ... this.
4451         (maintenance_test_settings_cmd): Delete.
4452         (maintenance_test_settings_set_cmd): ...
4453         (maintenance_set_test_settings_cmd): ... this.
4454         (maintenance_test_settings_show_cmd): ...
4455         (maintenance_show_test_settings_cmd): ... this.
4456         (maintenance_test_settings_show_value_cmd):
4457         (maintenance_show_test_settings_value_cmd): ... this.
4458         (_initialize_maint_test_settings): No longer install the "maint
4459         test-settings" prefix command.  Rename "maint test-settings set"
4460         to "maint set test-settings", and "maint test-settings show" to
4461         "maint show test-settings".  Adjust all subcommands.
4462
4463 2019-07-03  Pedro Alves  <palves@redhat.com>
4464
4465         * maint-test-settings.c: Fix file's intro comment.  Replace all
4466         references to "test-options" with references to "test-settings",
4467         in comments.
4468
4469 2019-07-03  Pedro Alves  <palves@redhat.com>
4470
4471         * maint-test-settings.c (maintenance_test_settings_xxx)
4472         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4473         New.
4474         (maintenance_test_settings_enums): Use them.
4475         (maintenance_test_settings_enum): Default to
4476         maintenance_test_settings_xxx.
4477         (_initialize_maint_test_settings): Initialize
4478         MAINTENANCE_TEST_SETTINGS_FILENAME.
4479
4480 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4481
4482         * breakpoint.h (remove_breakpoints_inf): Change return type to
4483         void, move function documentation here.
4484         * breakpoint.c (remove_breakpoints_inf): Change return type to
4485         void, move function documentation to header.
4486
4487 2019-07-02  Pedro Alves  <palves@redhat.com>
4488
4489         * NEWS (Completion improvements): Mention "info threads".
4490         * thread.c (struct info_threads_opts, info_threads_option_defs)
4491         (make_info_threads_options_def_group): New.
4492         (info_threads_command): Use gdb::option::process_options.
4493         (info_threads_command_completer): New.
4494         (_initialize_thread): Use gdb::option::build_help to build the
4495         help text for "info threads".
4496
4497 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4498
4499         * defs.h (generic_load): Move from here...
4500         * symfile.h (generic_load): ... to here.  Rename name parameter
4501         to args.
4502         * symfile.c (generic_load): Add comment.
4503
4504 2019-07-01  Tom Tromey  <tromey@adacore.com>
4505
4506         * dwarf2read.c
4507         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4508         declaration of without_params.  Fix formatting.
4509
4510 2019-07-01  Tom Tromey  <tromey@adacore.com>
4511
4512         * ada-exp.y (find_primitive_type): Update.
4513         * ada-lang.h (ada_lookup_symbol): Update.
4514         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4515         parameter.
4516         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4517
4518 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4519
4520         PR breakpoints/24541
4521         * gdbarch.c: Regenerate.
4522         * gdbarch.h: Regenerate.
4523         * gdbarch.sh: Add 'stap_adjust_register'.
4524         * i386-tdep.c: Include '<unordered_set>'.
4525         (i386_stap_adjust_register): New function.
4526         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4527         * stap-probe.c (stap_parse_register_operand): Call
4528         'gdbarch_stap_adjust_register'.
4529
4530 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4531
4532         PR python/24742
4533         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4534         * python/python.c (do_start_initialization): Use 'xmalloc'
4535         instead of 'PyMem_Malloc'.
4536
4537 2019-06-28  Tom Tromey  <tromey@adacore.com>
4538
4539         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4540         for Ada.
4541
4542 2019-06-27  Tom Tromey  <tromey@adacore.com>
4543
4544         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4545         objfile_key.
4546         (arm_find_mapping_symbol, arm_record_special_symbol)
4547         (_initialize_arm_tdep): Update.
4548         (arm_objfile_data_free): Remove.
4549
4550 2019-06-27  Tom Tromey  <tromey@adacore.com>
4551
4552         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4553         to cp_print_static_field.
4554
4555 2019-06-26  Tom Tromey  <tromey@adacore.com>
4556
4557         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4558         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4559         declare.
4560
4561 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4562
4563         * features/aarch64-core.c (create_feature_aarch64_core):
4564         Regenerate.
4565         * features/aarch64-core.xml: Add cpsr flags.
4566
4567 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4568
4569         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4570         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4571
4572 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4573
4574         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4575         field.
4576         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4577         use.
4578         (arm_record_special_symbol): Don't insert new symbol in sorted
4579         position, push it at the end.
4580
4581 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4582
4583         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4584         (arm_mapping_symbol_s): Remove.
4585         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4586         (arm_mapping_symbol_vec): New typedef.
4587         (struct arm_per_objfile): Add constructor.
4588         <section_maps>: Change type to
4589         std::unique_ptr<arm_mapping_symbol_vec[]>.
4590         (arm_compare_mapping_symbols): Remove.
4591         (arm_find_mapping_symbol): Adjust to section_maps type change.
4592         (arm_objfile_data_free): Call delete on arm_per_objfile.
4593         (arm_record_special_symbol): Adjust to section_maps type change.
4594         Allocate arm_per_objfile with new.
4595
4596 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4597
4598         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4599         with the command prefix.
4600
4601 2019-06-25  Tom Tromey  <tom@tromey.com>
4602
4603         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4604         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4605
4606 2019-06-25  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4609         type.
4610         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4611         protected.
4612
4613 2019-06-25  Tom Tromey  <tom@tromey.com>
4614
4615         * tui/tui-winsource.c
4616         (tui_source_window_base::set_is_exec_point_at): Add check against
4617         LOA_ADDRESS.
4618
4619 2019-06-25  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-source.c (tui_set_source_content): Don't check before
4622         xfree.
4623         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4624
4625 2019-06-25  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-winsource.h (tui_update_source_window_as_is)
4628         (tui_alloc_source_buffer, tui_line_is_displayed)
4629         (tui_addr_is_displayed): Change type of win_info.
4630         * tui/tui-winsource.c (tui_update_source_window_as_is)
4631         (tui_clear_source_content, tui_show_source_line)
4632         (tui_show_source_content, tui_source_window_base::refill)
4633         (tui_source_window_base::set_is_exec_point_at)
4634         (tui_source_window_base::set_is_exec_point_at)
4635         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4636         (tui_alloc_source_buffer, tui_line_is_displayed)
4637         (tui_addr_is_displayed): Change type of win_info.  Update.
4638         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4639         (tui_source_window_base::do_make_visible_with_new_height):
4640         Update.
4641         * tui/tui-source.c (tui_set_source_content)
4642         (tui_set_source_content_nil)
4643         (tui_source_window::do_scroll_vertical): Update.
4644         * tui/tui-layout.c (show_layout): Update.
4645         * tui/tui-disasm.c (tui_set_disassem_content)
4646         (tui_disasm_window::do_scroll_vertical): Update.
4647         * tui/tui-data.h (tui_win_content): Remove.
4648         (struct tui_gen_win_info) <content, content_size>: Remove.
4649         (struct tui_source_element): Add initializers and destructor.
4650         (union tui_which_element, struct tui_win_element): Remove.
4651         (struct tui_source_window_base) <content>: New field.
4652         (struct tui_data_window): Remove destructor.
4653         (tui_alloc_content, tui_free_win_content)
4654         (tui_free_all_source_wins_content): Don't declare.
4655         * tui/tui-data.c (tui_initialize_static_data): Update.
4656         (init_content_element, tui_alloc_content): Remove.
4657         (~tui_gen_win_info): Update.
4658         (~tui_data_window, tui_free_all_source_wins_content)
4659         (tui_free_win_content, free_content, free_content_elements):
4660         Remove.
4661
4662 2019-06-25  Tom Tromey  <tom@tromey.com>
4663
4664         * tui/tui-winsource.h (tui_clear_source_content)
4665         (tui_erase_source_content, tui_show_source_content): Change type
4666         of win_info.
4667         * tui/tui-winsource.c (tui_clear_source_content)
4668         (tui_erase_source_content, tui_show_source_content): Change type
4669         of win_info.
4670         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4671         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4672         win_info.
4673         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4674         win_info.
4675         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4676
4677 2019-06-25  Tom Tromey  <tom@tromey.com>
4678
4679         * tui/tui-winsource.c (tui_clear_source_content)
4680         (tui_source_window_base::set_is_exec_point_at): Update.
4681         * tui/tui-source.c (tui_set_source_content_nil): Update.
4682         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4683         a bool.
4684         * tui/tui-data.c (init_content_element): Update.
4685
4686 2019-06-25  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4689         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4690         * tui/tui-layout.c (init_and_make_win): Update.
4691         * tui/tui.h (enum tui_win_type): Update.
4692         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4693         tui_win_is_auxillary.
4694         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4695         tui_win_is_auxillary.
4696
4697 2019-06-25  Tom Tromey  <tom@tromey.com>
4698
4699         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4700         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4701         (tui_delete_data_content_windows, tui_display_all_data)
4702         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4703         Update.
4704         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4705         * tui/tui-regs.c (tui_last_regs_line_no)
4706         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4707         (tui_show_registers): Update.
4708         (tui_show_register_group): Return void.  Update.
4709         (tui_display_registers_from, tui_display_reg_element_at_line)
4710         (tui_display_registers_from_line, tui_check_register_values):
4711         Update.
4712         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4713         member.
4714         (struct tui_data_window) <regs_content>: Now a std::vector.
4715         <regs_content_count>: Remove.
4716         (tui_add_content_elements, tui_free_data_content): Don't declare.
4717         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4718         (init_content_element): Remove DATA_WIN case.  Add assert.
4719         (tui_add_content_elements): Remove.
4720         (tui_data_window): Update.
4721         (tui_free_data_content): Remove.
4722         (free_content_elements): Remove DATA_WIN case.
4723
4724 2019-06-25  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-data.c (tui_data_item_window): Update.
4727         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4728         * tui/tui-windata.c (tui_display_all_data)
4729         (tui_display_data_from_line): Update.
4730         (tui_check_data_values): Remove.
4731         * tui/tui-regs.c (tui_show_register_group)
4732         (tui_display_reg_element_at_line): Update.
4733         * tui/tui-hooks.c (tui_register_changed)
4734         (tui_refresh_frame_and_register_information): Call
4735         tui_check_register_values.
4736         * tui/tui-data.h (struct tui_data_window) <data_content,
4737         data_content_count, data_type>: Remove.
4738         (enum tui_data_type): Remove.
4739
4740         * tui/tui-data.c (tui_data_window::clear_detail)
4741         (~tui_data_window): Update.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4746         declare.
4747         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4748         Rename from tui_first_data_item_displayed.  Update.
4749         (tui_data_window::refresh_all)
4750         (tui_data_window::do_scroll_vertical): Update.
4751         * tui/tui-data.h (struct tui_data_window)
4752         <first_data_item_displayed>: Declare new method.
4753
4754 2019-06-25  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4757         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4758         contents...
4759         (tui_initialize_static_data): ...here.
4760
4761 2019-06-25  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4764         (tui_display_registers_from, tui_check_register_values): Update.
4765         (tui_display_register): Remove win_info parameter; update.
4766         (tui_get_register): Change type of parameters.
4767         * tui/tui-data.h (struct tui_data_element): Remove.
4768         (union tui_which_element) <data>: Remove.
4769         <data_window>: Change type.
4770         (struct tui_data_item_window): New.
4771         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4772         case.  Add assert.
4773         (~tui_data_item_window): New destructor.
4774         (free_content_elements): Remove DATA_ITEM_WIN case.
4775
4776 2019-06-25  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4779         Remove.
4780
4781 2019-06-25  Tom Tromey  <tom@tromey.com>
4782
4783         * tui/tui-data.h (struct tui_command_element): Remove.
4784         (union tui_which_element) <command>: Remove.
4785         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4786         assert.
4787         (free_content_elements): Remove CMD_WIN case.
4788
4789 2019-06-25  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-layout.c (tui_set_layout): Update.
4792         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4793         * tui/tui-data.c (layout_def): Update.
4794
4795 2019-06-25  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4798         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4799         (tui_source_window_base::set_new_height): Update.
4800         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4801         Update.
4802         (tui_set_locator_fullname, tui_set_locator_info)
4803         (tui_show_frame_info): Update.
4804         * tui/tui-source.c (tui_set_source_content)
4805         (tui_source_is_displayed): Update.
4806         * tui/tui-layout.c (show_source_disasm_command, show_data)
4807         (show_source_or_disasm_and_command): Update.
4808         * tui/tui-disasm.c (tui_set_disassem_content)
4809         (tui_get_begin_asm_address): Update.
4810         * tui/tui-data.h (struct tui_locator_element): Remove.
4811         (union tui_which_element) <locator>: Remove.
4812         (struct tui_locator_window): New.
4813         (tui_locator_win_info_ptr): Change return type.
4814         * tui/tui-data.c (_locator): Change type.
4815         (tui_locator_win_info_ptr): Change return type.
4816         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4817         (tui_alloc_content): Add assert.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.c
4822         (tui_exec_info_window::maybe_allocate_content): New method.
4823         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4824         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4825         (make_source_or_disasm_window): Add cast.
4826         * tui/tui-data.h (union tui_which_element) <simple_string>:
4827         Remove.
4828         (struct tui_source_info): New.
4829         (struct tui_source_window_base) <execution_info>: Change type.
4830         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4831         case, and add assert.
4832         (tui_alloc_content): Add assert.
4833
4834 2019-06-25  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4837         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4838         * tui/tui-data.c (tui_alloc_win_info): Remove.
4839
4840 2019-06-25  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4843         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4844         can_highlight.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4849         make_visible_with_new_height method.
4850         (tui_win_info::make_visible_with_new_height): New method.
4851         (tui_source_window_base::do_make_visible_with_new_height)
4852         (tui_data_window::do_make_visible_with_new_height)
4853         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4854         (make_visible_with_new_height): Remove.
4855         (tui_resize_all, tui_adjust_win_heights): Use
4856         make_visible_with_new_height method.
4857         * tui/tui-data.h (struct tui_win_info)
4858         <do_make_visible_with_new_height, make_visible_with_new_height>:
4859         New methods.
4860         (struct tui_source_window_base, struct tui_data_window)
4861         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4862         methods.
4863
4864 2019-06-25  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4867         method.
4868         (update_tab_width): Call update_tab_width method.
4869         * tui/tui-data.h (struct tui_win_info)
4870         (struct tui_source_window_base) <update_tab_width>: New methods.
4871
4872 2019-06-25  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4875         parameter.
4876         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4877         parameter.
4878         (tui_gen_win_info::make_visible): Update.
4879         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4880         parameter.
4881         * tui/tui-data.h (enum tui_box): New enum.
4882         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4883
4884 2019-06-25  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4887         init_and_make_win for EXEC_INFO_WIN.
4888         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4889         longer inline.
4890         (struct tui_win_info) <~tui_win_info>: Inline.
4891         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4892         Don't declare.
4893         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4894         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4895         Remove.
4896         (tui_initialize_static_data): Update.
4897         (~tui_gen_win_info): Handle more cleanup here.
4898         (~tui_source_window_base): Delete "execution_info".
4899         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4900
4901 2019-06-25  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui-layout.c (make_command_window): Don't set
4904         can_highlight.
4905         (show_source_disasm_command): Call the reset method.
4906         (show_data): Don't set can_highlight.  Call the reset method.
4907         (tui_gen_win_info::reset): Rename from init_gen_win_info
4908         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4909         (show_source_or_disasm_and_command): Call the reset method.
4910         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4911         (struct tui_cmd_window): Set can_highlight.
4912
4913 2019-06-25  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4916         from make_visible.
4917         (tui_make_visible, tui_make_invisible): Rewrite.
4918         (tui_win_info::make_visible): Remove.
4919         (tui_source_window_base::make_visible): Update.
4920         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4921         method.  Moved from...
4922         (struct tui_win_info) <make_visible>: ...here.
4923
4924 2019-06-25  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-winsource.c
4927         (tui_source_window_base::do_scroll_horizontal): Remove direction
4928         parameter.
4929         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4930         direction parameter.
4931         * tui/tui-win.c (tui_win_info::forward_scroll)
4932         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4933         (tui_win_info::right_scroll): Update.
4934         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4935         direction parameter.
4936         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4937         direction parameter.
4938         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4939         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4940         Remove direction parameter.
4941         (struct tui_source_window_base, struct tui_source_window)
4942         (struct tui_disasm_window, struct tui_data_window)
4943         (struct tui_cmd_window): Update.
4944
4945 2019-06-25  Tom Tromey  <tom@tromey.com>
4946
4947         * tui/tui-winsource.h (tui_set_exec_info_content)
4948         (tui_show_exec_info_content, tui_erase_exec_info_content)
4949         (tui_clear_exec_info_content, tui_update_exec_info): Change
4950         argument to tui_source_window_base.
4951         * tui/tui-winsource.c (tui_set_exec_info_content)
4952         (tui_show_exec_info_content, tui_erase_exec_info_content)
4953         (tui_clear_exec_info_content, tui_update_exec_info): Change
4954         argument to tui_source_window_base.
4955
4956 2019-06-25  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4959         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4960
4961 2019-06-25  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4964         check.
4965
4966 2019-06-25  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4969         type to void.
4970         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4971         type to void.
4972         * tui/tui-source.c (tui_set_source_content): Update.
4973         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4974
4975 2019-06-25  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-win.c (window_name_completer, tui_set_focus)
4978         (tui_all_windows_info): Use name method.
4979         * tui/tui-data.h (struct tui_gen_win_info)
4980         (struct tui_source_window, struct tui_disasm_window)
4981         (struct tui_data_window, struct tui_cmd_window) <name>: New
4982         method.
4983         (tui_win_name): Don't declare.
4984         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4985         (tui_win_name): Remove.
4986
4987 2019-06-25  Tom Tromey  <tom@tromey.com>
4988
4989         * tui/tui-winsource.h (tui_update_source_window)
4990         (tui_update_source_window_as_is): Change parameter type.
4991         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4992         to be a tui_source_window_base.
4993         (tui_update_source_window_as_is): Likewise.
4994         * tui/tui-win.c (make_visible_with_new_height): Update.
4995
4996 2019-06-25  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-winsource.c (tui_erase_source_content)
4999         (tui_show_source_content, tui_show_exec_info_content)
5000         (tui_erase_exec_info_content): Use refresh_window method.
5001         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5002         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5003         from tui_refresh_win.
5004         (tui_data_window::refresh_window): New method.
5005         (tui_win_info::refresh, tui_source_window_base::refresh)
5006         (tui_refresh_all): Use refresh_window method.
5007         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5008         method.
5009         * tui/tui-regs.c (tui_display_register): Call refresh_window
5010         method.
5011         * tui/tui-layout.c (show_source_disasm_command)
5012         (show_source_or_disasm_and_command): Call refresh_window method.
5013         * tui/tui-data.h (struct tui_gen_win_info)
5014         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5015         New method.
5016
5017 2019-06-25  Tom Tromey  <tom@tromey.com>
5018
5019         * tui/tui.c (tui_rl_other_window, tui_enable)
5020         (tui_is_window_visible, tui_get_command_dimension): Update.
5021         * tui/tui-winsource.c (tui_update_source_window_as_is)
5022         (tui_clear_source_content, tui_erase_source_content)
5023         (tui_show_source_line, tui_source_window_base::refill)
5024         (tui_source_window_base::do_scroll_horizontal)
5025         (tui_source_window_base::set_is_exec_point_at)
5026         (tui_update_breakpoint_info, tui_set_exec_info_content)
5027         (tui_alloc_source_buffer, tui_line_is_displayed)
5028         (tui_addr_is_displayed): Update.
5029         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5030         (tui_check_and_display_highlight_if_needed)
5031         (tui_win_info::make_visible, tui_win_info::refresh)
5032         (tui_refresh_all): Update.
5033         * tui/tui-windata.c (tui_first_data_item_displayed)
5034         (tui_delete_data_content_windows, tui_erase_data_content)
5035         (tui_display_all_data, tui_data_window::refresh_all)
5036         (tui_check_data_values): Update.
5037         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5038         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5039         (tui_win_info::backward_scroll, tui_refresh_all_win)
5040         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5041         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5042         (tui_source_window_base::set_new_height)
5043         (tui_data_window::set_new_height)
5044         (make_invisible_and_set_new_height)
5045         (make_visible_with_new_height, new_height_ok)
5046         (parse_scrolling_args): Update.
5047         * tui/tui-stack.c (tui_show_frame_info): Update.
5048         * tui/tui-source.c (tui_set_source_content)
5049         (tui_set_source_content_nil, tui_source_is_displayed)
5050         (tui_source_window::do_scroll_vertical): Update.
5051         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5052         (tui_display_registers_from, tui_display_reg_element_at_line)
5053         (tui_check_register_values, tui_reg_command): Update.
5054         * tui/tui-layout.c (tui_default_win_height)
5055         (show_source_disasm_command, show_data, init_and_make_win)
5056         (show_source_or_disasm_and_command): Update.
5057         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5058         (tui_redisplay_readline, tui_mld_flush)
5059         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5060         (tui_getc): Update.
5061         * tui/tui-disasm.c (tui_set_disassem_content)
5062         (tui_disasm_window::do_scroll_vertical): Update.
5063         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5064         Now virtual.
5065         (struct tui_win_info): Derive from tui_gen_win_info.
5066         <~tui_win_info>: Mark as override.
5067         <generic>: Remove member.
5068         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5069         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5070         (~tui_data_window, ~tui_win_info)
5071         (tui_free_all_source_wins_content): Update.
5072         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5073
5074 2019-06-25  Tom Tromey  <tom@tromey.com>
5075
5076         * tui/tui-layout.c (init_and_make_win): Use new.
5077         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5078         destructor, initializers.
5079         (tui_alloc_generic_win_info): Don't declare.
5080         * tui/tui-data.c (_locator): Add argument to constructor.
5081         (source_win, disasm_win): New globals.
5082         (exec_info): Remove.
5083         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5084         Update.
5085         (tui_alloc_generic_win_info): Remove.
5086         (init_content_element): Use new.
5087         (tui_win_info::tui_win_info): Update.
5088         (free_content_elements) <case DATA_WIN>: Use delete.
5089
5090 2019-06-25  Tom Tromey  <tom@tromey.com>
5091
5092         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5093         * tui/tui-windata.c (tui_first_data_item_displayed)
5094         (tui_delete_data_content_windows): Update.
5095         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5096         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5097         (tui_display_registers_from, tui_check_register_values): Update.
5098         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5099         pointer.
5100         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5101         window.
5102         (tui_free_data_content): Update.
5103         (free_content_elements) <case DATA_WIN>: Free the window.
5104
5105 2019-06-25  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5108         Update.
5109         * tui/tui-layout.c (make_command_window)
5110         (show_source_disasm_command, show_data, init_and_make_win)
5111         (show_source_or_disasm_and_command): Update.
5112         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5113         method.
5114         <can_highight, is_highlighted>: Now bool.
5115         (tui_set_win_highlight): Don't declare.
5116         * tui/tui-data.c (tui_set_win_highlight): Remove.
5117
5118 2019-06-25  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-wingeneral.c (make_visible): Remove check of window
5121         type.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-win.c (tui_win_info::max_height)
5126         (tui_cmd_window::max_height): New methods.
5127         (new_height_ok): Call max_height.
5128         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5129         <max_height>: New method.
5130
5131 2019-06-25  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-win.c (tui_source_window_base::set_new_height)
5134         (tui_data_window::set_new_height): New methods.
5135         (make_invisible_and_set_new_height): Call set_new_height method.
5136         * tui/tui-data.h (struct tui_win_info)
5137         (struct tui_source_window_base, struct tui_data_window)
5138         <set_new_height>: New method.
5139
5140 2019-06-25  Tom Tromey  <tom@tromey.com>
5141
5142         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5143         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5144         tui_refresh_data_win.
5145         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5146         method.
5147         (tui_refresh_all_win): Call the refresh_all method.
5148         (tui_set_focus): Likewise.
5149         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5150         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5151         Likewise.
5152
5153 2019-06-25  Tom Tromey  <tom@tromey.com>
5154
5155         * tui/tui-winsource.h (tui_refill_source_window)
5156         (tui_set_is_exec_point_at): Don't declare.
5157         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5158         (tui_source_window_base::refill): Rename from
5159         tui_refill_source_window.
5160         (tui_source_window_base::do_scroll_horizontal): Update.
5161         (tui_source_window_base::set_is_exec_point_at): Rename from
5162         tui_set_is_exec_point_at.
5163         (tui_update_all_breakpoint_info): Update.
5164         * tui/tui-stack.c (tui_show_frame_info): Update.
5165         * tui/tui-layout.c (show_data): Add cast.
5166         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5167         * tui/tui-data.h (struct tui_source_window_base) <refill,
5168         set_is_exec_point_at>: New methods.
5169         (tui_source_windows, tui_add_to_source_windows): Update types.
5170         (tui_add_to_source_windows): Remove redundant declaration.
5171         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5172         (tui_source_windows): Change return type.
5173         (tui_clear_source_windows_detail): Update.
5174         (tui_add_to_source_windows): Change type of parameter.
5175         (tui_free_all_source_wins_content): Update.
5176
5177 2019-06-25  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-wingeneral.c (tui_win_info::refresh)
5180         (tui_source_window_base::refresh): New methods.
5181         (tui_refresh_all): Call the refresh method.
5182         * tui/tui-data.h (struct tui_win_info)
5183         (struct tui_source_window_base) <refresh>: New method.
5184
5185 2019-06-25  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui.h (tui_is_window_visible): Return bool.
5188         * tui/tui.c (tui_is_window_visible): Return bool.
5189         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5190         (tui_make_visible, tui_make_invisible)
5191         (tui_win_info::make_visible)
5192         (tui_source_window_base::make_visible, make_all_visible)
5193         (tui_make_all_visible, tui_make_all_invisible): Update.
5194         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5195         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5196         bool.
5197         (struct tui_win_info, struct tui_source_window_base)
5198         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5199         * tui/tui-data.c (tui_init_generic_part): Update.
5200
5201 2019-06-25  Tom Tromey  <tom@tromey.com>
5202
5203         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5204         (tui_source_window_base::make_visible): New methods.
5205         (make_all_visible): Make method call.
5206         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5207         (struct tui_source_window_base, struct tui_cmd_window): Override
5208         make_visible.
5209         (tui_win_is_source_type): Don't declare.
5210         * tui/tui-data.c (tui_win_is_source_type): Remove.
5211
5212 2019-06-25  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5215         NULL check.
5216
5217 2019-06-25  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5220         Inline constructor.  Add initializers for members.
5221         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5222         constructors; now inline in class.
5223
5224 2019-06-25  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-regs.c (tui_show_registers): Update.
5227         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5228         bool.
5229         * tui/tui-data.c (tui_data_window::clear_detail)
5230         (tui_data_window): Update.
5231
5232 2019-06-25  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-windata.c (tui_display_all_data)
5235         (tui_display_data_from_line, tui_display_data_from)
5236         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5237         Update.
5238         * tui/tui-regs.c (tui_last_regs_line_no)
5239         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5240         (tui_show_registers, tui_show_register_group)
5241         (tui_display_registers_from, tui_display_reg_element_at_line)
5242         (tui_display_registers_from_line, tui_check_register_values)
5243         (tui_reg_next, tui_reg_prev): Update.
5244         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5245         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5246         tui_data_window.
5247         (struct tui_win_info) <detail>: Remove.  Add new fields from
5248         tui_data_info.
5249         (TUI_DATA_WIN): Add cast.
5250         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5251         (~tui_data_window): Simplify.
5252
5253 2019-06-25  Tom Tromey  <tom@tromey.com>
5254
5255         * tui/tui-layout.c (show_source_disasm_command)
5256         (show_source_or_disasm_and_command): Update.
5257         * tui/tui-io.c (update_cmdwin_start_line)
5258         (tui_redisplay_readline): Update.
5259         * tui/tui-data.h (struct tui_command_info): Remove.
5260         (struct tui_win_info) <detail>: Remove command_info member.
5261         (struct tui_data_window) <start_line>: New member, from
5262         tui_command_info.
5263         (TUI_CMD_WIN): Add casts.
5264
5265 2019-06-25  Tom Tromey  <tom@tromey.com>
5266
5267         * tui/tui-winsource.c (tui_update_source_window)
5268         (tui_refill_source_window)
5269         (tui_source_window_base::do_scroll_horizontal)
5270         (tui_update_breakpoint_info, tui_set_exec_info_content)
5271         (tui_show_exec_info_content, tui_erase_exec_info_content)
5272         (tui_clear_exec_info_content): Update.
5273         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5274         Update.
5275         * tui/tui-win.c (make_invisible_and_set_new_height)
5276         (make_visible_with_new_height): Update.
5277         * tui/tui-source.c (tui_set_source_content)
5278         (tui_show_symtab_source): Update.
5279         * tui/tui-layout.c (extract_display_start_addr)
5280         (show_source_disasm_command, show_data)
5281         (make_source_or_disasm_window)
5282         (show_source_or_disasm_and_command): Update.
5283         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5284         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5285         "gdbarch".
5286         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5287         to tui_source_window_base.
5288         (struct tui_win_info) <detail>: Remove source_info member.
5289         (struct tui_source_window_base) <has_locator>: Inline.
5290         Move contents from tui_source_info; rename has_locator member to
5291         m_has_locator.
5292         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5293         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5294         header file.
5295         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5296         Simplify.
5297         (tui_free_all_source_wins_content): Cast to
5298         tui_source_window_base.
5299
5300 2019-06-25  Tom Tromey  <tom@tromey.com>
5301
5302         * tui/tui-win.c (make_invisible_and_set_new_height)
5303         (make_visible_with_new_height): Call has_locator method.
5304         * tui/tui-layout.c (show_source_disasm_command, show_data)
5305         (show_source_or_disasm_and_command): Update for bool change.
5306         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5307         (tui_win_info) <has_locator>: New method.
5308         (struct tui_source_window_base) <has_locator>: New method.
5309         (tui_win_has_locator): Don't declare.
5310         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5311         from tui_win_has_locator.
5312         (tui_source_window_base): Use false, not FALSE.
5313
5314 2019-06-25  Tom Tromey  <tom@tromey.com>
5315
5316         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5317         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5318         clear_detail method directly.
5319         (tui_clear_win_detail): Remove.
5320
5321 2019-06-25  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5324         "this", not TUI_DISASM_WIN.
5325
5326 2019-06-25  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5329         declare.
5330         * tui/tui-winsource.c
5331         (tui_source_window_base::do_scroll_horizontal): Rename from
5332         tui_horizontal_source_scroll.
5333         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5334         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5335         from tui_vertical_data_scroll.
5336         * tui/tui-win.h (tui_scroll): Don't declare.
5337         * tui/tui-win.c (tui_win_info::forward_scroll)
5338         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5339         (tui_win_info::right_scroll): Rename and update.
5340         (tui_scroll_forward_command, tui_scroll_backward_command)
5341         (tui_scroll_left_command, tui_scroll_right_command): Update.
5342         (tui_scroll): Remove.
5343         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5344         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5345         from tui_vertical_source_scroll.
5346         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5347         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5348         from tui_vertical_disassem_scroll.
5349         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5350         do_scroll_horizontal>: New methods.
5351         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5352         Likewise.
5353         (struct tui_source_window_base): Add do_scroll_horizontal.
5354         (struct tui_source_window, struct tui_disasm_window): Add
5355         do_scroll_vertical.
5356         (struct tui_data_window, struct tui_cmd_window): Add
5357         do_scroll_horizontal and do_scroll_vertical.
5358         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5359
5360 2019-06-25  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-data.h (struct tui_source_window_base): New struct.
5363         (struct tui_source_window): Derive from tui_source_window_base.
5364         (struct tui_disasm_window): New struct.
5365         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5366         from tui_source_window::clear_detail.
5367         (tui_source_window_base): Rename from tui_source_window.
5368         (~tui_source_window_base): Rename from ~tui_source_window.
5369         (tui_alloc_win_info): Create a tui_disasm_window.
5370
5371 2019-06-25  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-data.h (struct tui_source_window)
5374         (struct tui_data_window): Declare destructors.
5375         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5376         destructors.
5377         (tui_win_info): Simplify.
5378
5379 2019-06-25  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui-winsource.c (tui_display_main)
5382         (tui_update_source_windows_with_addr)
5383         (tui_update_all_breakpoint_info): Update.
5384         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5385         (new_height_ok, parse_scrolling_args): Update.
5386         * tui/tui-stack.c (tui_show_frame_info): Update.
5387         * tui/tui-data.h (struct tui_list): Remove.
5388         (tui_source_windows): Return a reference to a std::vector.
5389         * tui/tui-data.c (source_windows): Now a std::vector.
5390         (tui_source_windows): Change return type.
5391         (tui_clear_source_windows): Rewrite.
5392         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5393         (tui_free_all_source_wins_content): Rewrite.
5394
5395 2019-06-25  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5398         (struct tui_data_window, struct tui_cmd_window): Declare
5399         clear_detail method.
5400         * tui/tui-data.c (tui_source_window::clear_detail)
5401         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5402         methods.
5403         (tui_clear_win_detail): Simplify.
5404
5405 2019-06-25  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-layout.c (make_source_window, make_disasm_window)
5408         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5409         Return the new window.
5410         (show_source_disasm_command, show_data)
5411         (show_source_or_disasm_and_command): Update.
5412
5413 2019-06-25  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5416         parameter.  Return the new window.
5417         (show_source_disasm_command): Update and remove NULL check.
5418         (show_source_or_disasm_and_command): Update.
5419
5420 2019-06-25  Tom Tromey  <tom@tromey.com>
5421
5422         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5423
5424 2019-06-25  Tom Tromey  <tom@tromey.com>
5425
5426         * tui/tui-data.h (struct tui_win_info): Make constructor
5427         protected.  Make destructor virtual.  Add initializers.
5428         (tui_source_window, tui_data_window, tui_cmd_window): New
5429         classes.
5430         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5431         constructor.  Add "type" parameter.
5432         (tui_source_window, tui_data_window, tui_cmd_window): New
5433         constructors.
5434         (tui_alloc_win_info): Instantiate the appropriate subclass.
5435
5436 2019-06-25  Tom Tromey  <tom@tromey.com>
5437
5438         * tui/tui-win.c (tui_resize_all): Use delete.
5439         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5440         destructor.
5441         (tui_free_window): Don't declare.
5442         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5443         Update.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-data.h (struct tui_win_info): Add constructor.
5448         * tui/tui-data.c (tui_alloc_win_info): Use new.
5449         (tui_free_window): Use delete.
5450
5451 2019-06-22  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5454         declare.
5455         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5456
5457 2019-06-22  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5460         declare.
5461         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5462
5463 2019-06-22  Tom de Vries  <tdevries@suse.de>
5464
5465         * dwarf2read.c (create_addrmap_from_aranges)
5466         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5467         instead of '%zu'.
5468
5469 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5470
5471         * dwarf2read.h (dwarf2_section_info_def): Remove.
5472         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5473         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5474         std::vector<dwarf2_section_info>.
5475         (struct dwo_file) <~dwo_file>: Remove.
5476         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5477         types field.
5478         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5479         (dwarf2_read_debug_names): Likewise.
5480         (create_debug_types_hash_table): Change parameter type to
5481         array_view, adjust code accordingly.
5482         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5483         (partial_die_info::fixup): Likewise.
5484         (determine_prefix): Likewise.
5485         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5486
5487 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5488
5489         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5490         gdb_bfd_ref_ptr.
5491         <~dwo_file>: Remove call to gdb_bfd_unref.
5492         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5493         gdb_bfd_ref_ptr::get.
5494
5495 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5496
5497         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5498         type to htab_up.
5499         * dwarf2read.c (struct dwo_file): Initialize fields.
5500         <~dwo_file>: New.
5501         (free_dwo_file): Remove, move content to ~dwo_file.
5502         (struct dwo_file_deleter): Remove.
5503         (dwo_file_up>: Remove custom deleter.
5504         (free_dwo_files): Remove.
5505         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5506         dwo_files.
5507         (process_skeletonless_type_units): Call unique_ptr::get.
5508         (allocate_dwo_file_hash_table): Add deleter to created hash
5509         table.  Change return type to htab_up.
5510         (lookup_dwo_file_slot): Don't memset dwo_file, call
5511         unique_ptr::get.
5512         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5513         (create_dwo_unit_in_dwp_v2): Likewise.
5514         (open_and_init_dwo_file): Likewise.
5515         (free_dwo_file_from_slot): Remove.
5516
5517 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5518
5519         * dwarf2read.h (struct dwarf2_section_info) <readin,
5520         is_virtual>: Change type to bool.
5521         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5522         true instead of 1.
5523
5524 2019-06-19  Tom Tromey  <tom@tromey.com>
5525
5526         * tui/tui-data.h (tui_init_content_element): Don't declare.
5527
5528 2019-06-19  Tom Tromey  <tom@tromey.com>
5529
5530         * tui/tui-data.h (tui_init_win_info): Don't declare.
5531
5532 2019-06-19  Tom de Vries  <tdevries@suse.de>
5533
5534         * dwarf2read.h (abstract_to_concrete): Change type to
5535         std::unordered_map<sect_offset, std::vector<sect_offset>,
5536         gdb::hash_enum<sect_offset>>.
5537
5538 2019-06-19  Tom Tromey  <tromey@adacore.com>
5539
5540         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5541         EVAL_AVOID_SIDE_EFFECTS specially.
5542
5543 2019-06-19  Tom Tromey  <tromey@adacore.com>
5544
5545         * source-cache.c (highlighter): New global.
5546         (source_cache::get_source_lines): Create a highlighter on demand.
5547
5548 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * defs.h (deprecated_interactive_hook): Delete declaration.
5551         * interps.c (clear_interpreter_hooks): Remove use of
5552         deprecated_interactive_hook.
5553         * top.c (deprecated_interactive_hook): Delete definition.
5554         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5555
5556 2019-06-18  Tom de Vries  <tdevries@suse.de>
5557
5558         PR gdb/24515
5559         * dwarf2read.h (abstract_to_concrete): Change type from
5560         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5561         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5562         * dwarf2read.c (read_variable): Update.
5563         (dwarf2_fetch_die_loc_sect_off): Update.
5564
5565 2019-06-17  Tom de Vries  <tdevries@suse.de>
5566
5567         PR gdb/24617
5568         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5569         accessing parent[parent_len - 1].
5570
5571 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5572
5573         PR gdb/24364
5574         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5575         call dtrace_process_dof with NULL dof.
5576
5577 2019-06-16  Tom de Vries  <tdevries@suse.de>
5578
5579         PR gdb/24445
5580         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5581
5582 2019-06-16  Tom Tromey  <tom@tromey.com>
5583
5584         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5585         (make_all_visible): Use address of member.
5586
5587 2019-06-16  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5590         (tui_free_window, free_content, free_content_elements): Remove
5591         unnecessary cast.
5592         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5593         cast.
5594         * tui/tui-regs.c (tui_show_register_group)
5595         (tui_display_registers_from, tui_display_reg_element_at_line):
5596         Remove unnecessary cast.
5597
5598 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * linux-nat.c (normal_mask): Delete.
5601         (_initialize_linux_nat): Don't initialise normal_mask.
5602
5603 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5604
5605         PR gdb/24445
5606         * dwarf-index-write.h (write_psymtabs_to_index): Add
5607         dwz_basename parameter.
5608         * dwarf-index-write.c (write_gdbindex): Move file writing to
5609         write_gdbindex_1.  Change return type void.
5610         (assert_file_size): Move up, remove filename parameter.
5611         (write_gdbindex_1): New function.
5612         (write_debug_names): Change return type to void, call
5613         assert_file_size.
5614         (struct index_wip_file): New struct.
5615         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5616         file logic to index_wip_file.  Write index for dwz file if
5617         needed.
5618         (save_gdb_index_command): Pass basename of dwz file, if present.
5619         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5620         build-id of dwz file, if present.
5621         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5622         (dwarf2_get_dwz_file): Likewise.
5623         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5624         (dwarf2_get_dwz_file): Likewise.
5625
5626 2019-06-16  Tom Tromey  <tom@tromey.com>
5627
5628         * coffread.c (process_coff_symbol): Use xstrdup.
5629         * value.c (create_internalvar): Use xstrdup.
5630
5631 2019-06-16  Tom Tromey  <tom@tromey.com>
5632
5633         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5634         * breakpoint.c (stopin_command, stopat_command)
5635         (until_break_command, decode_location_default): Remove unnecessary
5636         cast.
5637         * utils.c (subset_compare): Remove unnecessary cast.
5638         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5639         cast.
5640         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5641         cast.
5642         * infcmd.c (path_command): Remove unnecessary cast.
5643         * coffread.c (decode_type): Remove unnecessary cast.
5644         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5645         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5646         * tui/tui-stack.c (tui_show_locator_content)
5647         (tui_show_frame_info): Remove unnecessary cast.
5648         * tui/tui-win.c (tui_scroll_forward_command)
5649         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5650         (parse_scrolling_args): Remove unnecessary cast.
5651         * tui/tui-data.c (init_win_info, tui_del_window)
5652         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5653         (free_content_elements): Remove unnecessary cast.
5654         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5655         unnecessary cast.
5656         * tui/tui-source.c (tui_set_source_content)
5657         (tui_vertical_source_scroll): Remove unnecessary cast.
5658         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5659         cast.
5660         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5661         * tui/tui-regs.c (tui_display_registers_from)
5662         (tui_display_register): Remove unnecessary cast.
5663         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5664         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5665         (make_visible): Remove unnecessary cast.
5666         * tui/tui-winsource.c (tui_erase_source_content)
5667         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5668         unnecessary cast.
5669         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5670         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5671         * stabsread.c (read_type, read_array_type, read_range_type):
5672         Remove unnecessary cast.
5673         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5674         (parse_symbol, parse_type, upgrade_type, parse_external)
5675         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5676         unnecessary cast.
5677         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5678
5679 2019-06-16  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-data.c (tui_alloc_generic_win_info)
5682         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5683         checks.
5684
5685 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5686             Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * f-typeprint.c (f_print_type): Don't return early for not
5689         associated or not allocated types.
5690         (f_type_print_varspec_suffix): Add print_rank parameter and print
5691         ranks of array types in case they dangling.
5692         (f_type_print_base): Add print_rank parameter.
5693
5694 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * NEWS: Mention new MI commands.
5697         * break-catch-throw.c (enum exception_event_kind): Move to
5698         breakpoint.h.
5699         (print_mention_exception_catchpoint): Output text as a single
5700         message.
5701         (catch_exception_command_1): Rename to...
5702         (catch_exception_event): ...this, make non-static, update header
5703         command, and change some parameter types.
5704         (catch_catch_command): Update for changes to
5705         catch_exception_command_1.
5706         (catch_throw_command): Likewise.
5707         (catch_rethrow_command): Likewise.
5708         * breakpoint.c (enum exception_event_kind): Delete.
5709         * breakpoint.h (enum exception_event_kind): Moved here from
5710         break-catch-throw.c.
5711         (catch_exception_event): Declare.
5712         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5713         (mi_cmd_catch_throw): New function.
5714         (mi_cmd_catch_rethrow): New function.
5715         (mi_cmd_catch_catch): New function.
5716         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5717         'catch-catch' entries.
5718         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5719         (mi_cmd_catch_rethrow): Declare.
5720         (mi_cmd_catch_catch): Declare.
5721
5722 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * annotate.c (annotate_source_line): Change return type to void,
5725         update implementation to match.
5726         * annotate.h (annotate_source_line): Change return type to void,
5727         update header comment.
5728         * stack.c (print_frame_info): Don't change what frame information
5729         is printed based on whether annotations are on or not.
5730
5731 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5734         (annotate_source): Make static.
5735         (annotate_source_line): Moved from source.c and renamed from
5736         identify_source_line.  Update the return type.
5737         * annotate.h (annotate_source): Delete declaration.
5738         (annotate_source_line): Declaration moved from source.h, and
5739         renamed from identify_source_line.  Return type updated.
5740         * source.c (identify_source_line): Moved to annotate.c and renamed
5741         to annotate_source_line.
5742         (info_line_command): Remove check of annotation_level.
5743         * source.h (identify_source_line): Move declaration to annotate.h
5744         and rename to annotate_source_line.
5745         * stack.c: Add 'annotate.h' include.
5746         (print_frame_info): Remove check of annotation_level before
5747         calling annotate_source_line.
5748
5749 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5750
5751         * source-cache.c (source_cache::get_plain_source_lines): Use
5752         open_source_file_with_line_charpos instead of just
5753         open_source_file, remove call to find_source_lines.
5754         (source_cache::get_source_lines): Likewise.
5755         * source.c (find_source_lines): Make static.
5756         (get_filename_and_charpos): Renamed into...
5757         (open_source_file_with_line_charpos): ..this along with changes to
5758         return a scoped_fd, and some other minor clean ups.
5759         (identify_source_line): Use open_source_file_with_line_charpos.
5760         (search_command_helper): Use open_source_file_with_line_charpos
5761         instead of just open_source_file, remove call to
5762         find_source_lines.
5763         * source.h (open_source_file_with_line_charpos): Declare new
5764         function.
5765         (find_source_lines): Delete declaration.
5766
5767 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * source.c (get_filename_and_charpos): Remove fullname
5770         parameter.
5771         (identify_source_line): Update call to get_filename_and_charpos.
5772
5773 2019-06-14  Tom Tromey  <tromey@adacore.com>
5774
5775         PR gdb/24502:
5776         * ui-style.h (skip_ansi_escape): Update comment.
5777         * ui-file.h (class no_terminal_escape_file): New class.
5778         * ui-file.c (no_terminal_escape_file::write)
5779         (no_terminal_escape_file::puts): New methods.
5780         * cli/cli-logging.c (handle_redirections): Use
5781         no_terminal_escape_file.
5782
5783 2019-06-14  Tom Tromey  <tromey@adacore.com>
5784
5785         * NEWS: Move convenience variable news above Python news.
5786
5787 2019-06-14  Tom Tromey  <tom@tromey.com>
5788
5789         * gnulib: Move directory to top-level.
5790         * configure.ac: Don't configure gnulib.
5791         * configure: Rebuild.
5792         * common/common-defs.h: Use new path to gnulib.
5793         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5794         (GNULIB_H): Remove.
5795         (INCGNU): Look in new gnulib location.
5796         (HFILES_NO_SRCDIR): Remove gnulib files.
5797         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5798         (generated_files): Remove GNULIB_H.
5799         ($(LIBGNU), all-lib): Remove targets.
5800         (distclean): Don't mention GNULIB_BUILDDIR.
5801         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5802
5803 2019-06-14  Tom Tromey  <tromey@adacore.com>
5804
5805         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5806         Warn if symbol file does not provide any symbols.
5807
5808 2019-06-14  Tom Tromey  <tromey@adacore.com>
5809
5810         * source.c (find_and_open_source): Respect basenames_may_differ.
5811
5812 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * annotate.c (annotate_breakpoints_invalid): Make use of
5815         scoped_restore_terminal_state.
5816         (annotate_frames_invalid): Likewise.
5817
5818 2019-06-14  Tom Tromey  <tromey@adacore.com>
5819
5820         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5821         allow assignment to an internalvar.
5822
5823 2019-06-14  Tom Tromey  <tromey@adacore.com>
5824
5825         * ada-lex.l: Allow "_" in attribute names.
5826
5827 2019-06-14  Tom Tromey  <tromey@adacore.com>
5828
5829         PR gdb/24653:
5830         * regcache.c (registers_changed): Don't call alloca.
5831         * top.c (execute_command): Don't call alloca.
5832
5833 2019-06-13  Pedro Alves  <palves@redhat.com>
5834
5835         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5836         'expression'.  When parsing an expression, error out if there's
5837         junk after "unlimited".
5838         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5839         (do_set_command): Adjust calls to is_unlimited_literal.
5840
5841 2019-06-13  Pedro Alves  <palves@redhat.com>
5842
5843         * compile/compile.c (make_compile_options_def_group): Add braces
5844         around array_view initializer.
5845         * thread.c (make_thread_apply_all_options_def_group)
5846         (make_thread_apply_all_options_def_group): Likewise.
5847
5848 2019-06-13  Pedro Alves  <palves@redhat.com>
5849
5850         * NEWS (New commands): Mention "maint test-options
5851         require-delimiter", "maint test-options unknown-is-error", "maint
5852         test-options unknown-is-operand" and "maint show
5853         test-options-completion-result".
5854         (New command options, command completion): New section.
5855         (Completion improvements): New section.
5856         Mention that you can abbreviate "unlimited".
5857
5858 2019-06-13  Pedro Alves  <palves@redhat.com>
5859
5860         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5861         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5862         * unittests/cli-utils-selftests.c (test_parse_flags)
5863         (test_parse_flags_qcs): Delete.
5864         (test_cli_utils): Don't call deleted functions.
5865
5866 2019-06-13  Pedro Alves  <palves@redhat.com>
5867
5868         * thread.c: Include "cli/cli-option.h".
5869         (tp_array_compar_ascending): Global.
5870         (tp_array_compar): Delete function.
5871         (tp_array_compar_ascending, tp_array_compar_descending): New
5872         functions.
5873         (ascending_option_def, qcs_flag_option_def)
5874         (thr_qcs_flags_option_defs)
5875         (make_thread_apply_all_options_def_group)
5876         (make_thread_apply_options_def_group): New.
5877         (thread_apply_all_command): Use gdb::option::process_options.
5878         (thread_apply_command_completer)
5879         (thread_apply_all_command_completer): New.
5880         (thread_apply_command): Use gdb::option::process_options.
5881         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5882         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5883         to generate help text of "thread apply".  Adjust "taas"'s help.
5884         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5885         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5886
5887 2019-06-13  Pedro Alves  <palves@redhat.com>
5888
5889         * thread.c (thread_apply_command): Check for invalid TID with
5890         isdigit instead of !isalpha.
5891
5892 2019-06-13  Pedro Alves  <palves@redhat.com>
5893
5894         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5895         (validate_flags_qcs): New.
5896         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5897         (validate_flags_qcs): Declare.
5898         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5899         (make_frame_apply_options_def_group): New.
5900         (frame_apply_command_count): Process options with
5901         gdb::option::process_options.
5902         (frame_apply_completer): New.
5903         (frame_apply_level_completer, frame_apply_all_completer)
5904         (frame_apply_completer): New.
5905         (_initialize_stack): Update help of "frame apply", "frame apply
5906         level", "frame apply all" and "faas" to mention supported options
5907         and install command completers.
5908         * stack.h (frame_apply_all_completer): Declare.
5909         * thread.c: Include "stack.h".
5910         (tfaas_command): Add "--".
5911         (_initialize_thread): Update help "tfaas" to mention supported
5912         options and install command completer.
5913
5914 2019-06-13  Pedro Alves  <palves@redhat.com>
5915
5916         * completer.c (complete_nested_command_line): New.
5917         (gdb_completion_word_break_characters_throw): Add assertion.
5918         * completer.h (complete_nested_command_line): Declare.
5919
5920 2019-06-13  Pedro Alves  <palves@redhat.com>
5921
5922         * stack.c (parse_backtrace_qualifiers): New.
5923         (backtrace_command): Use it.
5924         (backtrace_command_completer): Complete on qualifiers.
5925
5926 2019-06-13  Pedro Alves  <palves@redhat.com>
5927
5928         * frame.c: Include "cli/cli-option.h.
5929         (user_set_backtrace_options): New.
5930         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5931         Delete.
5932         (get_prev_frame): Adjust.
5933         (boolean_option_def, uinteger_option_def)
5934         (set_backtrace_option_defs): New.
5935         (_initialize_frame): Adjust and use
5936         gdb::option::add_setshow_cmds_for_options to install "set
5937         backtrace past-main" and "set backtrace past-entry".
5938         * frame.h: Include "cli/cli-option.h".
5939         (struct frame_print_options): Forward declare.
5940         (print_frame_arguments_all, print_frame_arguments_scalars)
5941         (print_frame_arguments_none): Declare.
5942         (print_entry_values): Delete declaration.
5943         (struct frame_print_options, user_frame_print_options): New.
5944         (struct set_backtrace_options): New.
5945         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5946         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5947         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5948         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5949         (list_args_or_locals): Add frame_print_options parameter.
5950         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5951         * python/py-framefilter.c (enumerate_args): Pass down
5952         USER_FRAME_PRINT_OPTIONS.
5953         * stack.c: Include "cli/cli-option.h".
5954         (print_frame_arguments_all, print_frame_arguments_scalars)
5955         (print_frame_arguments_none): Declare.
5956         (print_raw_frame_arguments, print_entry_values): Delete.
5957         (user_frame_print_options): New.
5958         (boolean_option_def, enum_option_def, frame_print_option_defs):
5959         New.
5960         (struct backtrace_cmd_options): New.
5961         (bt_flag_option_def): New.
5962         (backtrace_command_option_defs): New.
5963         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5964         (print_frame_arg, read_frame_arg, print_frame_args)
5965         (print_frame_info, print_frame): Add frame_print_options parameter
5966         and use it.
5967         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5968         (backtrace_command_1): Add frame_print_options and
5969         backtrace_cmd_options parameters and use them.
5970         (make_backtrace_options_def_group): New.
5971         (backtrace_command): Process command options with
5972         gdb::option::process_options.
5973         (backtrace_command_completer): New.
5974         (_initialize_stack): Extend "backtrace"'s help to mention
5975         supported options.  Install completer for "backtrace".
5976         Install some settings commands with add_setshow_cmds_for_options.
5977
5978 2019-06-13  Pedro Alves  <palves@redhat.com>
5979
5980         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5981         and that "set/show print raw frame-arguments" are now deprecated.
5982
5983         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5984         command.
5985         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5986         * stack.c (_initialize_stack): Install "set/show print
5987         raw-frame-arguments", and deprecate "set/show print raw
5988         frame-arguments".
5989         * valprint.c (_initialize_valprint): Deprecate "set/show print
5990         raw".
5991
5992 2019-06-13  Pedro Alves  <palves@redhat.com>
5993
5994         * compile/compile.c (struct compile_options): New.
5995         (compile_flag_option_def, compile_command_option_defs)
5996         (make_compile_options_def_group): New.
5997         (compile_file_command): Handle options with
5998         gdb::option::process_options.
5999         (compile_file_command_completer): New function.
6000         (compile_code_command): Handle options with
6001         gdb::option::process_options.
6002         (compile_code_command_completer): New function.
6003         (_initialize_compiler): Install completers for "compile code" and
6004         "compile file".  Mention available options in "compile code" and
6005         "compile code"'s help.
6006         * completer.c (advance_to_completion_word): New, factored out from
6007         ...
6008         (advance_to_expression_complete_word_point): ... this.
6009         (advance_to_filename_complete_word_point): New.
6010         * completer.h (advance_to_filename_complete_word_point): New
6011         declaration.
6012
6013 2019-06-13  Pedro Alves  <palves@redhat.com>
6014
6015         * compile/compile.c: Include "cli/cli-option.h".
6016         (compile_print_value): Scope data pointer is now a
6017         value_print_options pointer; adjust.
6018         (compile_print_command): Process options.  Scope data pointer is
6019         now a value_print_options pointer; adjust.
6020         (_initialize_compile): Update "compile print"'s help to include
6021         supported options.  Install a completer for "compile print".
6022         * cp-valprint.c (show_vtblprint, show_objectprint)
6023         (show_static_field_print): Delete.
6024         (_initialize_cp_valprint): Don't install "set print
6025         static-members", "set print vtbl", "set print object" here.
6026         * printcmd.c: Include "cli/cli-option.h" and
6027         "common/gdb_optional.h".
6028         (print_command_parse_format): Rework to fill in a
6029         value_print_options instead of a format_data.
6030         (print_value): Change parameter type from format_data pointer to
6031         value_print_options reference.  Adjust.
6032         (print_command_1): Process options.  Adjust to pass down a
6033         value_print_options.
6034         (print_command_completer): New.
6035         (_initialize_printcmd): Install print_command_completer as
6036         handle_brkchars completer for the "print" command.  Update
6037         "print"'s help to include supported options.
6038         * valprint.c: Include "cli/cli-option.h".
6039         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6040         here from cp-valprint.c.
6041         (boolean_option_def, uinteger_option_def)
6042         (value_print_option_defs, make_value_print_options_def_group):
6043         New.  Use gdb::option::add_setshow_cmds_for_options to install
6044         "set print elements", "set print null-stop", "set print repeats",
6045         "set print pretty", "set print union", "set print array", "set
6046         print address", "set print symbol", "set print array-indexes".
6047         * valprint.h: Include <string> and "cli/cli-option.h".
6048         (make_value_print_options_def_group): Declare.
6049         (print_value): Change parameter type from format_data pointer to
6050         value_print_options reference.
6051         (print_command_completer): Declare.
6052
6053 2019-06-13  Pedro Alves  <palves@redhat.com>
6054
6055         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6056         (COMMON_SFILES): Add maint-test-settings.c.
6057         * cli/cli-decode.c (boolean_enums): New global, factored out from
6058         ...
6059         (add_setshow_boolean_cmd): ... here.
6060         * cli/cli-decode.h (boolean_enums): Declare.
6061         * cli/cli-option.c: New file.
6062         * cli/cli-option.h: New file.
6063         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6064         factored out from ...
6065         (parse_cli_boolean_value(const char *)): ... this.
6066         (is_unlimited_literal): Change parameter type to pointer to
6067         pointer.  Adjust and advance ARG pointer.
6068         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6069         (parse_cli_var_enum): New, factored out from ...
6070         (do_set_command): ... this.  Adjust.
6071         * cli/cli-setshow.h (parse_cli_boolean_value)
6072         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6073         (parse_cli_var_enum): Declare.
6074         * cli/cli-utils.c: Include "cli/cli-option.h".
6075         (get_ulongest): New.
6076         * cli/cli-utils.h (get_ulongest): Declare.
6077         (check_for_argument): New overloads.
6078         * maint-test-options.c: New file.
6079
6080 2019-06-13  Pedro Alves  <palves@redhat.com>
6081
6082         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6083         parse a range if "-" is at the end of the string.
6084
6085 2019-06-13  Pedro Alves  <palves@redhat.com>
6086
6087         * cli/cli-setshow.c (parse_auto_binary_operation)
6088         (parse_cli_boolean_value): Don't allow "o".
6089
6090 2019-06-13  Pedro Alves  <palves@redhat.com>
6091
6092         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6093         * NEWS: Mention maint test-settings KIND.
6094         * maint-test-settings.c: New file.
6095
6096 2019-06-13  Pedro Alves  <palves@redhat.com>
6097
6098         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6099         completer.
6100         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6101         "set" completers.
6102
6103 2019-06-13  Pedro Alves  <palves@redhat.com>
6104
6105         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6106         after item.
6107
6108 2019-06-13  Pedro Alves  <palves@redhat.com>
6109
6110         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6111
6112 2019-06-13  Pedro Alves <palves@redhat.com>
6113
6114         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6115         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6116         call.
6117         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6118         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6119         calls.
6120         (check_for_argument): Skip spaces after argument.
6121
6122 2019-06-13  Pedro Alves  <palves@redhat.com>
6123
6124         * thread.c (thread_apply_command): Adjust TID parsing.
6125         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6126         detected before end of string.
6127         (tid_is_in_list): Error out if LIST is invalid.
6128
6129 2019-06-13  Pedro Alves  <palves@redhat.com>
6130
6131         * completer.c (complete_line_internal_1): Rewind completion word
6132         point.
6133         (completion_tracker::advance_custom_word_point_by): Change
6134         parameter type to int.
6135         * completer.h (completion_tracker::advance_custom_word_point_by):
6136         Likewise.
6137
6138 2019-06-13  Pedro Alves  <palves@redhat.com>
6139
6140         * completer.c (advance_to_completion_word): Handle delimiters.
6141
6142 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6143
6144         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6145
6146 2019-06-11  Tom Tromey  <tom@tromey.com>
6147
6148         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6149         (xmalloc_failed): Move to alloc.c.
6150         * alloc.c: New file.
6151         * Makefile.in (COMMON_SFILES): Add alloc.c.
6152
6153 2019-06-11  Tom Tromey  <tom@tromey.com>
6154
6155         * nat/linux-waitpid.c: Don't include server.h.
6156         (linux_debug): Remove.
6157         (my_waitpid): Update.
6158
6159 2019-06-11  Tom Tromey  <tromey@adacore.com>
6160
6161         * infcall.c (_initialize_infcall): Remove trailing newline from
6162         help.
6163         * user-regs.c (_initialize_user_regs): Remove trailing newline
6164         from help.
6165         * typeprint.c (_initialize_typeprint): Remove trailing newline
6166         from help.
6167         * reverse.c (_initialize_reverse): Remove trailing newlines from
6168         help.
6169         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6170         from help.
6171         * language.c (add_set_language_command): Remove trailing newline
6172         from help.
6173         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6174         help.
6175         * disasm.c (_initialize_disasm): Remove trailing newline from
6176         help.
6177         * top.c (init_main): Remove trailing newline from help.
6178         * interps.c (_initialize_interpreter): Remove trailing newline
6179         from help.
6180         * btrace.c (_initialize_btrace): Remove trailing newlines from
6181         help.
6182         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6183         from help.
6184         * python/python.c (_initialize_python): Remove trailing newline
6185         from help.
6186         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6187         help.
6188         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6189         from help.  Reformat some text.
6190         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6191         from help.
6192         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6193         newline from help.
6194
6195 2019-06-11  Tom Tromey  <tromey@adacore.com>
6196
6197         * darwin-nat.c (darwin_decode_exception_message)
6198         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6199
6200 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * valops.c (value_slice): Check for not allocated or not
6203         associated values.
6204
6205 2019-06-10  Tom de Vries  <tdevries@suse.de>
6206
6207         PR gdb/24618
6208         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6209         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6210         invalid.
6211
6212 2019-06-10  Tom de Vries  <tdevries@suse.de>
6213
6214         PR gdb/24611
6215         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6216         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6217
6218 2019-06-10  Tom de Vries  <tdevries@suse.de>
6219
6220         PR symtab/24545
6221         * symtab.c (struct demangled_name_entry): Add language field.
6222         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6223         static minimal symbol".  Set and use language field.
6224
6225 2019-06-10  Tom Tromey  <tromey@adacore.com>
6226
6227         * ada-lang.c (_initialize_ada_language): Update help text.
6228
6229 2019-06-10  Tom Tromey  <tromey@adacore.com>
6230
6231         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6232         with a newline.
6233         * guile/guile.c (handle_boot_error): Don't end warning with a
6234         newline.
6235         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6236         warning with a newline.
6237         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6238         newline.
6239         (s12z_frame_cache): Likewise.
6240         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6241         a newline.
6242         * solib-svr4.c (disable_probes_interface): Don't end warning with
6243         a newline.
6244         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6245         newline.
6246         * python/python.c (do_finish_initialization): Don't end warning
6247         with a newline.
6248
6249 2019-06-10  Tom Tromey  <tom@tromey.com>
6250
6251         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6252         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6253         gdbpy_enter.
6254
6255 2019-06-10  Tom Tromey  <tromey@adacore.com>
6256
6257         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6258         data.
6259         (elf_new_init): Don't call stabsread_new_init.
6260         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6261         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6262         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6263
6264 2019-06-10  Tom de Vries  <tdevries@suse.de>
6265
6266         PR symtab/16264
6267         PR symtab/24517
6268         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6269
6270 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6271
6272         * source.c (find_and_open_source): Also rewrite relative file
6273         names.
6274
6275 2019-04-26  Amos Bird  <amosbird@gmail.com>
6276
6277         * annotate.c (annotate_thread_exited): Add "thread-exited"
6278         annotation.
6279
6280 2019-06-06  Tom Tromey  <tromey@adacore.com>
6281
6282         * maint.h (class scoped_command_stats): Use
6283         DISABLE_COPY_AND_ASSIGN.
6284         <print_time>: New method.
6285         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6286         print_time.
6287         (scoped_command_stats::print_time): New method.
6288
6289 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6292         instructions of lengths 6 or 8 bytes.
6293
6294 2019-06-04  Pedro Alves  <palves@redhat.com>
6295
6296         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6297
6298         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6299         * breakpoint.c (condition_completer): Likewise.
6300         * cli/cli-dump.c (scan_expression): Likewise.
6301         * common/filestuff.c (mkdir_recursive): Likewise.
6302         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6303         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6304         (gdb_abspath): Likewise.
6305         * compile/compile-cplus-types.c
6306         (compile_cplus_instance::decl_name): Likewise.
6307         * completer.c (complete_explicit_location):
6308         (signal_completer, reg_or_group_completer_1): Likewise.
6309         * cp-support.c (cp_remove_params_if_any): Likewise.
6310         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6311         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6312         * infcmd.c (strip_bg_char): Likewise.
6313         * linespec.c (copy_token_string): Likewise.
6314         * mi/mi-main.c (output_cores): Likewise.
6315         * psymtab.c (psymtab_search_name):
6316         * symfile.c (test_set_ext_lang_command): Likewise.
6317         * target.c (target_fileio_read_stralloc): Likewise.
6318         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6319         * value.c (complete_internalvar): Likewise.
6320
6321 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6322
6323         Add objfile property to gdb.Type.
6324         * NEWS: Mention Python API addition.
6325         * python/py-type.c (typy_get_objfile): New method.
6326
6327 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6328
6329         * NEWS: Mention the new set|show style [title|highlight].
6330         Mention changes to "show style", "help" and "apropos".
6331
6332 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6333
6334         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6335         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6336         instead of print_help_for_command.
6337         (print_doc_of_command): New function.
6338         (help_list): Add 'apropos -v word' suggestion.
6339         (print_help_for_command): Style the command name using title style.
6340         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6341         (_initialize_cli_cmds): Describe -v in apropos_command help.
6342
6343 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6344
6345         * cli/cli-style.h (cli_style_option): Add name in constructor,
6346         add m_name class member, add constructor with intensity,
6347         add name class function.
6348         (cli_style_option::add_setshow_commands): Remove name argument.
6349         (highlight_style, title_style): New styles.
6350         * cli/cli-style.c (do_show): New function that shows a style
6351         characteristic styling the style name with itself.
6352         (set_style_name): New function.
6353         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6354         Update all callers according to the changes in cli/cli-style.h.
6355         * utils.h (fputs_highlighted): New function.
6356         * utils.c (fputs_highlighted): Likewise.
6357
6358 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6359
6360         * NEWS: Mention new pipe command and new convenience variables.
6361
6362 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6363
6364         * cli/cli-cmds.c (pipe_command): New function.
6365         (_initialize_cli_cmds): Call add_com for pipe_command.
6366         Define | as an alias for pipe.
6367         (exit_status_set_internal_vars): New function.
6368         (shell_escape): Call exit_status_set_internal_vars.
6369         cli/cli-decode.c (find_command_name_length): Recognize | as
6370         a single character command.
6371
6372 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6373
6374         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6375         top.c (execute_command_to_ui_file): New function, mostly a copy
6376         of execute_command_to_string.
6377         (execute_command_to_string): Implement by calling
6378         execute_command_to_ui_file.
6379
6380 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6381
6382         * top.h (saved_command_line): Remove declaration.
6383         * top.c (previous_saved_command_line, previous_repeat_arguments):
6384         New variables.
6385         (saved_command_line): Make static, define together with other
6386         'repeat variables'.
6387         (dont_repeat): Clear repeat_arguments.
6388         (repeat_previous, get_saved_command_line, save_command_line):
6389         New functions.
6390         (gdb_init): Initialize saved_command_line
6391         and previous_saved_command_line.
6392         * main.c (captured_main_1): Remove saved_command_line initialization.
6393         * event-top.c (handle_line_of_input): Update to use
6394         the new 'repeat' related functions instead of direct access to
6395         saved_command_line.
6396         * command.h (repeat_previous, get_saved_command_line,
6397         save_command_line): New declarations.
6398         (dont_repeat): Add comment.
6399
6400 2019-05-30  Tom Tromey  <tromey@adacore.com>
6401
6402         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6403         Fix comment.
6404         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6405
6406 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6407
6408         PR cli/24587
6409         * completer.c (complete): Initialize variable word.
6410
6411 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6412
6413         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6414         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6415         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6416         'body' is NULL to the outter 'if', protecting the '!is_define'
6417         situation as well.
6418
6419 2019-05-29  Tom Tromey  <tromey@adacore.com>
6420
6421         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6422         (dwarf_unknown): New function.
6423         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6424         (dwarf_type_encoding_name): Use dwarf_unknown.
6425
6426 2019-05-29  Tom Tromey  <tromey@adacore.com>
6427
6428         PR c++/20020:
6429         * cp-valprint.c (cp_print_value_fields): Call
6430         cp_print_static_field inside "try".
6431
6432 2019-05-29  Tom Tromey  <tromey@adacore.com>
6433
6434         * inflow.c (struct terminal_info): Add default operator=.
6435         * configure: Rebuild.
6436         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6437         -Wdeprecated-copy-dtor, -Wredundant-move.
6438
6439 2019-05-29  Tom Tromey  <tromey@adacore.com>
6440
6441         * NEWS: Add entry.
6442         * infcmd.c (print_return_value_1): Handle finish_print
6443         option.
6444         (show_print_finish): New function.
6445         (_initialize_infcmd): Add "set/show print finish" commands.
6446         * valprint.c (user_print_options): Initialize new member.
6447         * valprint.h (struct value_print_options) <finish_print>: New
6448         member.
6449
6450 2019-05-28  Tom Tromey  <tromey@adacore.com>
6451
6452         * ada-lang.c (ada_remove_Xbn_suffix)
6453         (find_old_style_renaming_symbol)
6454         (parse_old_style_renaming): Remove.
6455         (ada_find_renaming_symbol): Don't call
6456         find_old_style_renaming_symbol.
6457         (ada_is_renaming_symbol): Rename from
6458         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6459         bool.  Now static.
6460         (ada_read_var_value): Update and simplify.
6461         * ada-exp.y (write_var_or_type): Remove old code.
6462
6463 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6464
6465         * event-top.c: Remove include comment.
6466         * inflow.c (class scoped_ignore_sigttou): Move from here...
6467         * inflow.h (class scoped_ignore_sigttou): ...to here.
6468         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6469         * top.c:  Remove include comment.
6470
6471 2019-05-27  Tom Tromey  <tom@tromey.com>
6472
6473         * NEWS: Fix typo.
6474
6475 2019-05-22  Tom Tromey  <tromey@adacore.com>
6476
6477         * target.c (target_follow_exec): Constify parameter.
6478         * target-delegates.c: Rebuild.
6479         * remote.c (remote_target::follow_exec): Constify parameter.
6480         * infrun.c (follow_exec): Constify parameter.
6481         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6482         (target_follow_exec): Likewise.
6483
6484 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6487         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6488
6489 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6490
6491         * NEWS: Add debugredirect and testsuite sections.
6492
6493 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6494
6495         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6496         target descriptions using exclusively floating point register name
6497         aliases.
6498
6499 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         PR gdb/18644:
6502         * f-lang.c (build_fortran_types): Handle the case where
6503         gdbarch_floatformat_for_type returns a nullptr.
6504
6505 2019-05-21  Tom de Vries  <tdevries@suse.de>
6506
6507         PR cli/24587
6508         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6509
6510 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         PR gdb/18644:
6513         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6514         16-byte floats.
6515         * i386-tdep.c (i386_floatformat_for_type): Use
6516         floatformats_ia64_quad for the 16-byte floating point component
6517         within a fortran 32-byte complex number.
6518
6519 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6522         delete default constructor.
6523         (find_partial_die): Update to return const struct.
6524         (partial_die_parent_scope): Move variable declaration into scope
6525         of its use and change its type to auto.
6526         (guess_partial_die_structure_name): Likewise.
6527         (partial_die_info::fixup): Likewise.
6528
6529 2019-05-17  Tom Tromey  <tromey@adacore.com>
6530
6531         * source.c (find_and_open_source): Remove cast.
6532
6533 2019-05-17  Tom Tromey  <tromey@adacore.com>
6534
6535         * annotate.c (annotate_source): Make "filename" const.
6536         * annotate.h (annotate_source): Use const.
6537
6538 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6539
6540         * disasm.c (set_disassembler_options): Send errors to stderr.
6541
6542 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6543
6544         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6545         (cli_interp_base::set_logging): Check debug_redirect.
6546         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6547         * cli/cli-logging.c (debug_redirect): Add static variable.
6548         (pop_output_files): Add default param.
6549         (handle_redirections): Print debug setting.
6550         (show_logging_command): Likewise.
6551         (_initialize_cli_logging): Add debugredirect command.
6552         * interps.c (current_interp_set_logging): Add debug_redirect
6553         parameter.
6554         * interps.h (set_logging): Add debug_redirect parameter.
6555         (current_interp_set_logging): Likewise.
6556         * mi/mi-common.h: Likewise.
6557         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6558
6559 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6560             Tom Tromey  <tromey@adacore.com>
6561
6562         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6563         directly.
6564         * cli/cli-interp.h (make_logging_output): Remove declaration.
6565         * cli/cli-logging.c (make_logging_output): Remove function.
6566         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6567         directly.
6568         * ui-file.c (tee_file::tee_file): Remove bools.
6569         (tee_file::~tee_file): Remove deletes.
6570         * ui-file.h (tee_file): Remove bools.
6571
6572 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6573
6574         * mi/mi-cmds.h (mi_cmd_complete): New function.
6575         * mi/mi-main.c (mi_cmd_complete): Likewise.
6576         * mi/mi-cmds.c: Define new MI command -complete.
6577         * NEWS: Mention new -complete command.
6578
6579 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6580
6581         * completer.h (complete): New function.
6582         * completer.c (complete): Likewise.
6583         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6584         function defined in completer.h.
6585
6586 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6587
6588         * MAINTAINERS (Write After Approval): Add myself.
6589
6590 2019-05-17  Tom de Vries  <tdevries@suse.de>
6591
6592         PR gdb/24094
6593         * dwarf2read.c (struct cu_partial_die_info): New struct.
6594         (find_partial_die): Return cu_partial_die_info.
6595         (partial_die_parent_scope, guess_partial_die_structure_name)
6596         (partial_die_info::fixup): Handle new return type of find_partial_die.
6597
6598 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6599
6600         PR breakpoints/24541
6601         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6602         "std::string", simplifying the algorithm.
6603
6604 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6605
6606         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6607         (stap_static_probe_ops::get_probes): Likewise.
6608
6609 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6610
6611         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6612         '-')" and "else if".
6613         (stap_parse_single_operand): Join checks for
6614         "gdbarch_stap_parse_special_token_p" and
6615         "gdbarch_stap_parse_special_token" in the same "if" statement.
6616         Invert check when verifying for operation on register
6617         displacement.
6618
6619 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6620
6621         * stap-probe.c (stap_get_opcode): Update comment.
6622         (stap_get_expected_argument_type): Likewise.
6623         (handle_stap_probe): Likewise.
6624
6625 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6626
6627         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6628         return type to 'bool'.  Adjust comment.  Use 'bool' when
6629         appropriate.
6630         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6631         * stap-probe.c (stap_parse_argument_1): Likewise.
6632         (stap_is_operator): Likewise.
6633         (stap_is_generic_prefix): Likewise.
6634         (stap_is_register_prefix): Likewise.
6635         (stap_is_register_indirection_prefix): Likewise.
6636         (stap_is_integer_prefix): Likewise.
6637         (stap_generic_check_suffix): Likewise.
6638         (stap_check_integer_suffix): Likewise.
6639         (stap_check_register_suffix): Likewise.
6640         (stap_check_register_indirection_suffix): Likewise.
6641         (stap_parse_register_operand): Likewise.
6642         (stap_parse_single_operand): Likewise.
6643         (stap_parse_argument_1): Likewise.
6644         (stap_probe::get_argument_count): Likewise.
6645         (stap_is_operator): Likewise.
6646
6647 2019-05-16  Tom Tromey  <tromey@adacore.com>
6648
6649         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6650         keyword to foreach.
6651
6652 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6653
6654         * linux-thread-db.c (try_thread_db_load_1): Change return type
6655         to bool.
6656         (try_thread_db_load): Likewise.
6657         (try_thread_db_load_from_pdir_1): Likewise.
6658         (try_thread_db_load_from_pdir): Likewise.
6659         (try_thread_db_load_from_sdir): Likewise.
6660         (try_thread_db_load_from_dir): Likewise.
6661         (thread_db_load_search): Likewise.
6662         (has_libpthread): Likewise.
6663         (thread_db_load): Likewise.
6664
6665 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6666
6667         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6668         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6669         NULL, and complain/return if that's the case.
6670
6671 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6672
6673         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6674         (advance, posn, abstract_read_memory): New functions.
6675         [struct mem_read_abstraction]: New struct.
6676         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6677
6678 2019-05-14  Tom Tromey  <tromey@adacore.com>
6679
6680         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6681         value is not lval_memory.
6682
6683 2019-05-14  Tom Tromey  <tromey@adacore.com>
6684
6685         * solib.c (info_sharedlibrary_command): Style the file name.
6686
6687 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6688
6689         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6690         (aarch64_vnv_type): Likewise.
6691         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6692         * common/tdesc.c: Likewise.
6693         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6694         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6695         * features/aarch64-fpu.xml: Add ieee half view.
6696         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6697         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6698         * gdbtypes.h (struct builtin_type): Likewise.
6699         (struct objfile_type): Likewise.
6700
6701 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6702
6703         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6704         typo.
6705         * location.h (string_to_event_location): Likewise.
6706
6707 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6708
6709         GDB 8.3 released.
6710
6711 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6712
6713         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6714         New variable declaration.
6715         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6716         New variable.
6717         (print_one_breakpoint): Use ui_out::test_flags and new global
6718         variable to compute use_fixed_output.
6719         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6720         Remove.
6721         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6722         (mi_multi_location_breakpoint_output_fixed): Remove.
6723         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6724         new variable.
6725         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6726         fix_multi_location_breakpoint_output flag if version >= 3.
6727         * ui-out.h (enum ui_out_flag)
6728         <fix_multi_location_breakpoint_output>: New enumerator.
6729
6730 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6731
6732         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6733
6734 2019-05-10  Tom Tromey  <tromey@adacore.com>
6735
6736         * ada-lang.c (catch_ada_completer): New function.
6737         (_initialize_ada_language): Use it.
6738
6739 2019-05-10  Tom Tromey  <tromey@adacore.com>
6740
6741         * thread.c (print_thread_info): Make "requested_threads" const.
6742         * gdbthread.h (print_thread_info): Make "requested_threads"
6743         const.
6744         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6745         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6746
6747 2019-05-08  Tom Tromey  <tom@tromey.com>
6748
6749         * gdbtypes.c (objfile_type_data): Change type.
6750         (objfile_type, _initialize_gdbtypes): Update.
6751
6752 2019-05-08  Tom Tromey  <tom@tromey.com>
6753
6754         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6755         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6756         (_initialize_dwarf2_frame): Update.
6757
6758 2019-05-08  Tom Tromey  <tom@tromey.com>
6759
6760         * objc-lang.c (objc_objfile_data): Change type.
6761         (find_methods): Update.
6762         (_initialize_objc_lang): Remove.
6763
6764 2019-05-08  Tom Tromey  <tom@tromey.com>
6765
6766         * stabsread.c (rs6000_builtin_type_data): Change type.
6767         (rs6000_builtin_type, _initialize_stabsread): Update.
6768
6769 2019-05-08  Tom Tromey  <tom@tromey.com>
6770
6771         * mips-tdep.c (mips_pdr_data): Remove.
6772         (_initialize_mips_tdep): Update.
6773
6774 2019-05-08  Tom Tromey  <tom@tromey.com>
6775
6776         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6777         (hppa_init_objfile_priv_data, read_unwind_info)
6778         (find_unwind_entry, _initialize_hppa_tdep): Update.
6779
6780 2019-05-08  Tom Tromey  <tom@tromey.com>
6781
6782         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6783         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6784         on obstack.
6785         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6786
6787 2019-05-08  Tom Tromey  <tom@tromey.com>
6788
6789         * mdebugread.c (basic_type_data): Change type.
6790         (basic_type, _initialize_mdebugread): Update.
6791
6792 2019-05-08  Tom Tromey  <tom@tromey.com>
6793
6794         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6795
6796 2019-05-08  Tom Tromey  <tom@tromey.com>
6797
6798         * nto-tdep.c (nto_inferior_data_reg): Change type.
6799         (nto_inferior_data): Update.
6800         (nto_inferior_data_cleanup, nto_new_inferior_data)
6801         (_initialize_nto_tdep): Remove.
6802         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6803
6804 2019-05-08  Tom Tromey  <tom@tromey.com>
6805
6806         * ada-lang.c (struct ada_inferior_data): Add initializers.
6807         (ada_inferior_data): Change type.
6808         (ada_inferior_data_cleanup): Remove.
6809         (get_ada_inferior_data, ada_inferior_exit)
6810         (struct ada_pspace_data): Add initializers, destructor.
6811         (ada_pspace_data_handle): Change type.
6812         (get_ada_pspace_data): Update.
6813         (ada_pspace_data_cleanup): Remove.
6814
6815 2019-05-08  Tom Tromey  <tom@tromey.com>
6816
6817         * coffread.c (struct coff_symfile_info): Add initializers.
6818         (coff_objfile_data_key): Move lower.  Change type.
6819         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6820         Update.
6821         (coff_free_info): Remove.
6822
6823 2019-05-08  Tom Tromey  <tom@tromey.com>
6824
6825         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6826         (fbsd_pspace_data_handle): Move lower.  Change type.
6827         (get_fbsd_pspace_data): Update.
6828         (fbsd_pspace_data_cleanup): Remove.
6829         (_initialize_fbsd_tdep): Update.
6830
6831 2019-05-08  Tom Tromey  <tom@tromey.com>
6832
6833         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6834         (get_ada_tasks_pspace_data): Update.
6835         (ada_tasks_pspace_data_cleanup): Remove.
6836         (_initialize_tasks): Update.
6837         (ada_tasks_inferior_data_handle): Change type.
6838         (get_ada_tasks_inferior_data): Update.
6839         (ada_tasks_inferior_data_cleanup): Remove.
6840         (struct ada_tasks_pspace_data): Add initializers.
6841
6842 2019-05-08  Tom Tromey  <tom@tromey.com>
6843
6844         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6845         * symfile-debug.c (debug_sym_get_probes): Change type.
6846         * stap-probe.c (handle_stap_probe):
6847         (stap_static_probe_ops::get_probes): Change type.
6848         * probe.h (class static_probe_ops) <get_probes>: Change type.
6849         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6850         (parse_probes_in_pspace): Update.
6851         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6852         Update.
6853         (any_static_probe_ops::get_probes): Change type.
6854         * elfread.c (elfread_data): New typedef.
6855         (probe_key): Change type.
6856         (elf_get_probes): Likewise.  Update.
6857         (probe_key_free): Remove.
6858         (_initialize_elfread): Update.
6859         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6860         Change type.
6861         (dtrace_process_dof_probe, dtrace_process_dof)
6862         (dtrace_static_probe_ops::get_probe): Change type.
6863
6864 2019-05-08  Tom Tromey  <tom@tromey.com>
6865
6866         * xcoffread.c (struct xcoff_symfile_info): Rename from
6867         coff_symfile_info.  Add initializers.
6868         (xcoff_objfile_data_key): Move lower.  Change type.
6869         (XCOFF_DATA): Rewrite.
6870         (xcoff_free_info): Remove.
6871         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6872         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6873         (xcoff_initial_scan): Update.
6874
6875 2019-05-08  Tom Tromey  <tom@tromey.com>
6876
6877         * solib-svr4.c (struct svr4_info): Add initializers and
6878         destructor.
6879         <probes_table>: Now an htab_up.
6880         (solib_svr4_pspace_data): Change type.
6881         (free_probes_table): Simplify.
6882         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6883         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6884         (probes_table_remove_objfile_probes, register_solib_event_probe)
6885         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6886         (_initialize_svr4_solib): Update.
6887
6888 2019-05-08  Tom Tromey  <tom@tromey.com>
6889
6890         * remote.c (remote_pspace_data): Change type.
6891         (remote_pspace_data_cleanup): Remove.
6892         (get_remote_exec_file, set_pspace_remote_exec_file)
6893         (_initialize_remote): Update.
6894
6895 2019-05-08  Tom Tromey  <tom@tromey.com>
6896
6897         * breakpoint.c (breakpoint_objfile_key): Change type.
6898         (get_breakpoint_objfile_data): Update.
6899         (free_breakpoint_objfile_data): Remove.
6900         (_initialize_breakpoint): Update.
6901
6902 2019-05-08  Tom Tromey  <tom@tromey.com>
6903
6904         * linux-tdep.c (struct linux_info): Add initializers.
6905         (linux_inferior_data): Move.  Change type.
6906         (invalidate_linux_cache_inf): Update.
6907         (linux_inferior_data_cleanup): Remove.
6908         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6909
6910 2019-05-08  Tom Tromey  <tom@tromey.com>
6911
6912         * auxv.c (auxv_inferior_data): Move.  Change type.
6913         (auxv_inferior_data_cleanup): Remove.
6914         (invalidate_auxv_cache_inf): Rewrite.
6915         (get_auxv_inferior_data, _initialize_auxv): Update.
6916
6917 2019-05-08  Tom Tromey  <tom@tromey.com>
6918
6919         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6920         (symfile_debug_objfile_data_key): Change type.
6921         (symfile_debug_installed, debug_qf_has_symbols)
6922         (debug_qf_find_last_source_symtab)
6923         (debug_qf_forget_cached_source_info)
6924         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6925         (debug_qf_print_stats, debug_qf_dump)
6926         (debug_qf_expand_symtabs_for_function)
6927         (debug_qf_expand_all_symtabs)
6928         (debug_qf_expand_symtabs_with_fullname)
6929         (debug_qf_map_matching_symbols)
6930         (debug_qf_expand_symtabs_matching)
6931         (debug_qf_find_pc_sect_compunit_symtab)
6932         (debug_qf_map_symbol_filenames)
6933         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6934         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6935         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6936         (debug_sym_read_linetable, debug_sym_relocate): Update.
6937         (symfile_debug_free_objfile): Remove.
6938         (install_symfile_debug_logging, _initialize_symfile_debug):
6939         Update.
6940
6941 2019-05-08  Tom Tromey  <tom@tromey.com>
6942
6943         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6944         allocate_on_obstack.
6945         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6946         (get_dwarf2_per_objfile): Update.
6947         (set_dwarf2_per_objfile): Remove.
6948         (dwarf2_has_info, dwarf2_get_section_info): Update.
6949         (dwarf2_free_objfile): Remove.
6950         (_initialize_dwarf2_read): Update.
6951
6952 2019-05-08  Tom Tromey  <tom@tromey.com>
6953
6954         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6955         initializers.
6956         <unsupported_script_warning_printed,
6957         script_not_found_warning_printed>: Now bool.
6958         (auto_load_pspace_data): Change type.
6959         (~auto_load_pspace_info): Rename from
6960         auto_load_pspace_data_cleanup.
6961         (get_auto_load_pspace_data, init_loaded_scripts_info)
6962         (clear_section_scripts, maybe_print_unsupported_script_warning)
6963         (maybe_print_script_not_found_warning, _initialize_auto_load):
6964         Update.
6965
6966 2019-05-08  Tom Tromey  <tom@tromey.com>
6967
6968         * objfiles.c (objfile_pspace_info): Add destructor and
6969         initializers.
6970         (objfiles_pspace_data): Change type.
6971         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6972         (get_objfile_pspace_data): Update.
6973         (objfiles_bfd_data): Change type.
6974         (get_objfile_bfd_data): Update.
6975         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6976
6977 2019-05-08  Tom Tromey  <tom@tromey.com>
6978
6979         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6980         Change type.
6981         (get_catch_syscall_inferior_data): Update.
6982         (catch_syscall_inferior_data_cleanup): Remove.
6983         (_initialize_break_catch_syscall): Update.
6984
6985 2019-05-08  Tom Tromey  <tom@tromey.com>
6986
6987         * inflow.c (struct terminal_info): Add destructor and
6988         initializers.
6989         (inflow_inferior_data): Change type.
6990         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6991         (get_inflow_inferior_data, inflow_inferior_exit)
6992         (swap_terminal_info, _initialize_inflow): Update.
6993
6994 2019-05-08  Tom Tromey  <tom@tromey.com>
6995
6996         * target-dcache.c (target_dcache_cleanup): Remove.
6997         (target_dcache_aspace_key): Change type.
6998         (target_dcache_init_p, target_dcache_invalidate)
6999         (target_dcache_get, target_dcache_get_or_init)
7000         (_initialize_target_dcache): Update.
7001         * dcache.h (struct dcache_deleter): New.
7002
7003 2019-05-08  Tom Tromey  <tom@tromey.com>
7004
7005         * symtab.c (struct symbol_cache): Add destructor and
7006         initializers.
7007         (symbol_cache_key): Move.  Change type.
7008         (make_symbol_cache, free_symbol_cache): Remove.
7009         (get_symbol_cache): Update.
7010         (symbol_cache_cleanup): Remove.
7011         (ALL_PSPACES, symbol_cache_flush)
7012         (maintenance_print_symbol_cache)
7013         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7014         Update.
7015
7016 2019-05-08  Tom Tromey  <tom@tromey.com>
7017
7018         * symtab.c (struct main_info): Add destructor and initializers.
7019         (main_progspace_key): Move.  Change type.
7020         (get_main_info): Update.
7021         (main_info_cleanup): Remove.
7022         (_initialize_symtab): Update.
7023
7024 2019-05-08  Tom Tromey  <tom@tromey.com>
7025
7026         * registry.h (DECLARE_REGISTRY): Define the _key class.
7027
7028 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * NEWS: Merge two 'New commands' sections.
7031
7032 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7033
7034         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7035         parameter and use Ada language definition instead.
7036         (ada_val_print_ptr): Remove unused language parameter.
7037         (ada_val_print_num): Remove language parameter and use Ada language
7038         definition instead.
7039         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7040         parameter.
7041         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7042         parameter and use Ada language definition instead.
7043         (ada_val_print_1): Update all ada_val_print_xxx calls.
7044         Remove language parameter.
7045         (ada_val_print): Update ada_val_print_1 call.
7046
7047 2019-05-08  Tom Tromey  <tromey@adacore.com>
7048
7049         * remote.c (remote_hw_watchpoint_limit)
7050         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7051         Now static.
7052
7053 2019-05-08  Tom Tromey  <tromey@adacore.com>
7054
7055         * maint.c (_initialize_maint_cmds): Move initialization code to
7056         remote.c.
7057         (watchdog, show_watchdog): Move to remote.c.
7058         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7059         "watchdog" static.
7060         (_initialize_remote): Move initialization code from maint.c.
7061         * defs.h (watchdog): Don't declare.
7062
7063 2019-05-08  Tom Tromey  <tromey@adacore.com>
7064
7065         * tui/tui-interp.c: Include main.h.
7066         * interps.c: Include main.h.
7067         * main.h (interpreter_p): Declare.
7068         * defs.h (interpreter_p): Don't declare.
7069
7070 2019-05-08  Tom Tromey  <tromey@adacore.com>
7071
7072         * dwarf2loc.c: Include dwarf2read.h.
7073         * defs.h (read_unsigned_leb128): Don't declare.
7074         * dwarf2read.h (read_unsigned_leb128): Declare.
7075
7076 2019-05-08  Tom Tromey  <tromey@adacore.com>
7077
7078         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7079         method.
7080
7081 2019-05-08  Tom Tromey  <tromey@adacore.com>
7082
7083         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7084         when no wrap column is set.
7085
7086 2019-05-08  Tom Tromey  <tromey@adacore.com>
7087
7088         * c-lang.c (c_get_string): Handle non-C-style arrays.
7089
7090 2019-05-08  Tom Tromey  <tromey@adacore.com>
7091
7092         * typeprint.c (print_offset_data::update): Print the bit offset,
7093         not the number of bits remaining.
7094
7095 2019-05-08  Tom Tromey  <tromey@adacore.com>
7096
7097         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7098         padding at end of comment.
7099
7100 2019-05-08  Tom Tromey  <tromey@adacore.com>
7101
7102         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7103         Compare main types.
7104
7105 2019-05-06  Tom Tromey  <tom@tromey.com>
7106
7107         * common/scoped_mmap.c: Include common-defs.h.
7108         * common/scoped_mmap.h: Don't include config.h.
7109
7110 2019-05-04  Tom Tromey  <tom@tromey.com>
7111
7112         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7113         (struct aarch64_call_info): Add initializers.
7114         <si>: Now a std::vector.
7115         (pass_on_stack, aarch64_push_dummy_call): Update.
7116
7117 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7118             Tom Tromey  <tom@tromey.com>
7119
7120         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7121         (ppc_threads): Now a std::vector.  Now static.
7122         (hwdebug_find_thread_points_by_tid)
7123         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7124         Update.
7125
7126 2019-05-04  Tom Tromey  <tom@tromey.com>
7127
7128         * arc-tdep.c (arc_tdesc_init): Return bool.
7129
7130 2019-05-04  Tom Tromey  <tom@tromey.com>
7131
7132         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7133         Use gdb_assert_not_reached.
7134
7135 2019-05-04  Tom Tromey  <tom@tromey.com>
7136
7137         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7138         "false".
7139
7140 2019-05-04  Tom Tromey  <tom@tromey.com>
7141
7142         * arc-tdep.c (arc_tdesc_init): Use bool.
7143
7144 2019-05-04  Tom Tromey  <tom@tromey.com>
7145
7146         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7147
7148 2019-05-04  Tom Tromey  <tom@tromey.com>
7149
7150         * cli/cli-cmds.c (valid_command_p): Return bool.
7151
7152 2019-05-04  Tom Tromey  <tom@tromey.com>
7153
7154         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7155         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7156
7157 2019-05-04  Raul Tambre  <raul@tambre.ee>
7158
7159         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7160         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7161         operator for comparison.
7162
7163 2019-05-04  Tom Tromey  <tom@tromey.com>
7164
7165         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7166         (lookup_partial_symbol, print_partial_symbols)
7167         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7168         (psymbol_compare): Update.
7169         (add_psymbol_to_bcache): Clear the entire psymbol.
7170         (maintenance_check_psymtabs): Update.
7171         * psympriv.h (struct partial_symbol): Don't derive from
7172         general_symbol_info.
7173         <obj_section, unrelocated_address, address,
7174         set_unrelocated_address>: Update.
7175         <ginfo>: New member.
7176         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7177         (debug_names::write_psymbols): Update.
7178
7179 2019-05-04  Tom de Vries  <tdevries@suse.de>
7180
7181         * contrib/cc-with-tweaks.sh: Support -n arg.
7182
7183 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7184
7185         * corelow.c (core_target::detach): Ensure frame cache and
7186         register caches are cleared.
7187         inferior.c (exit_inferior_1): Likewise.
7188
7189 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7190             Tom Tromey  <tom@tromey.com>
7191
7192         * dictionary.c (collate_pending_symbols_by_language): Remove
7193         "struct" from foreach.
7194         * symtab.c (lookup_global_symbol_from_objfile)
7195         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7196         foreach.
7197         * ser-tcp.c (net_open): Remove "struct" from foreach.
7198         * objfiles.c (objfile_relocate, objfile_rebase)
7199         (objfile_has_symbols): Remove "struct" from foreach.
7200         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7201         from foreach.
7202         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7203         foreach.
7204         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7205         "struct" from foreach.
7206         * ada-lang.c (create_excep_cond_exprs)
7207         (ada_exception_catchpoint_cond_string): Remove "struct" from
7208         foreach.
7209
7210 2019-05-03  Tom Tromey  <tromey@adacore.com>
7211
7212         * ada-exp.y (convert_char_literal): Check suffix of each
7213         enumerator.
7214
7215 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7216
7217         PR ada/21406:
7218         * ada-exp.y (yywrap): Don't define.
7219         * ada-lex.l (%option): Add noyywrap
7220         (yywrap): Remove.
7221
7222 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7223
7224         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7225         _WIN32_WINNT to the XP level, unless already defined to a higher
7226         level.
7227
7228         * unittests/parse-connection-spec-selftests.c:
7229         * ser-tcp.c:
7230         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7231         override.
7232
7233         * symfile.c (find_separate_debug_file): Remove colon from the
7234         drive spec of DOS/Windows file names of the target, so that the
7235         file name produced from DEBUGDIR and the target's directory will
7236         be valid on DOS/Windows systems.
7237
7238 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * rust-lang.c (val_print_struct): Handle printing structures
7241         containing strings.
7242
7243 2019-05-02  Tom Tromey  <tromey@adacore.com>
7244
7245         * valarith.c (_initialize_valarith): Remove.
7246
7247 2019-05-01  Tom Tromey  <tromey@adacore.com>
7248
7249         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7250         bitfields.
7251
7252 2019-05-01  Tom Tromey  <tromey@adacore.com>
7253
7254         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7255         for big-endian copies.
7256
7257 2019-04-30  Ali Tamur  <tamur@google.com>
7258         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7259         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7260         (read_3_bytes): New function.
7261
7262 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7263
7264         * windows-nat.c (main_thread_id): Delete.
7265         (handle_output_debug_string): Replace main_thread_id by
7266         current_event.dwThreadId.
7267         (fake_create_process): Likewise.
7268         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7269         Do not set main_thread_id.
7270         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7271         current_event.dwThreadId.
7272         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7273
7274 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7275
7276         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7277         Use current_event.dwThreadId instead of main_thread_id.
7278
7279 2019-04-30  Tom Tromey  <tromey@adacore.com>
7280
7281         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7282         (create_excep_cond_exprs): Iterate over program spaces.
7283         (ada_exception_catchpoint_cond_string): Examine all minimal
7284         symbols for exception types.
7285
7286 2019-04-30  Tom Tromey  <tromey@adacore.com>
7287
7288         PR c++/24470:
7289         * dwarf2read.c (process_structure_scope): Handle case where type
7290         has template parameters but no symbol was created.
7291
7292 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7293             Chris January  <chris.january@arm.com>
7294
7295         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7296         qualifier.
7297         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7298
7299 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * f-typeprint.c (f_print_type): Update rules for printing
7302         whitespace.
7303         (f_type_print_varspec_suffix): Likewise.
7304
7305 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7306             Chris January  <chris.january@arm.com>
7307
7308         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7309         function arguments.
7310
7311 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * f-lang.c (build_fortran_types): Change name of void type to
7314         lower case.
7315         * f-typeprint.c (f_type_print_base): Print the name of the void
7316         type, rather than a fixed string.
7317         * f-valprint.c (f_decorations): Use lower case void string.
7318
7319 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7320             Chris January  <chris.january@arm.com>
7321
7322         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7323         types for Fortran.
7324
7325 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7326             Chris January  <chris.january@arm.com>
7327             David Lecomber  <david.lecomber@arm.com>
7328
7329         * f-exp.y (BINOP_INTRINSIC): New token.
7330         (exp): New parser rule handling BINOP_INTRINSIC.
7331         (f77_keywords): Add new builtin procedures.
7332         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7333         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7334         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7335         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7336         (print_unop_subexp_f): New function.
7337         (print_binop_subexp_f): New function.
7338         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7339         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7340         (dump_subexp_body_f): Likewise.
7341         (operator_check_f): Likewise.
7342         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7343         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7344
7345 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7346
7347         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7348         UNOP_KIND.
7349         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7350         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7351         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7352         (operator_length_f): New fuction.
7353         (print_subexp_f): New function.
7354         (op_name_f): New function.
7355         (dump_subexp_body_f): New function.
7356         (operator_check_f): New function.
7357         (exp_descriptor_f): Replace standard expression handling functions
7358         with new functions.
7359         * gdb/fortran-operator.def: New file.
7360         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7361         * gdb/std-operator.def: Remove UNOP_KIND.
7362
7363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * std-operator.def: Remove unbalanced, stray double quote
7366         character.
7367
7368 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7369             Chris January  <chris.january@arm.com>
7370             Daniel Everett  <daniel.everett@arm.com>
7371             Nick Forrington  <nick.forrington@arm.com>
7372             Richard Bunt  <richard.bunt@arm.com>
7373
7374         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7375         of depth when printing anonymous structs or unions.
7376         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7377         Don't print either the top-level value, or the children if the
7378         max-depth is exceeded.
7379         (ppscm_print_children): When printing the key of a map, allow one
7380         extra level of depth.
7381         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7382         print either the top-level value, or the children if the max-depth
7383         is exceeded.
7384         (print_children): When printing the key of a map, allow one extra
7385         level of depth.
7386         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7387         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7388         (user_print_options): Initialise max_depth field.
7389         (val_print_scalar_or_string_type_p): New function.
7390         (val_print): Check to see if the max depth has been reached.
7391         (val_print_check_max_depth): Define new function.
7392         (show_print_max_depth): New function.
7393         (_initialize_valprint): Add 'print max-depth' option.
7394         * valprint.h (struct value_print_options) <max_depth>: New field.
7395         (val_print_check_max_depth): Declare new function.
7396         * NEWS: Document new feature.
7397
7398 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * ada-lang.c (ada_language_defn): Initialise new field.
7401         * c-lang.c (c_is_string_type_p): New function.
7402         (c_language_defn): Initialise new field.
7403         (cplus_language_defn): Initialise new field.
7404         (asm_language_defn): Initialise new field.
7405         (minimal_language_defn): Initialise new field.
7406         * c-lang.h (c_is_string_type_p): Declare new function.
7407         * d-lang.c (d_language_defn): Initialise new field.
7408         * f-lang.c (f_is_string_type_p): New function.
7409         (f_language_defn): Initialise new field.
7410         * go-lang.c (go_is_string_type_p): New function.
7411         (go_language_defn): Initialise new field.
7412         * language.c (default_is_string_type_p): New function.
7413         (unknown_language_defn): Initialise new field.
7414         (auto_language_defn): Initialise new field.
7415         * language.h (struct language_defn) <la_is_string_type_p>: New
7416         member variable.
7417         (default_is_string_type_p): Declare new function.
7418         * m2-lang.c (m2_language_defn): Initialise new field.
7419         * objc-lang.c (objc_language_defn): Initialise new field.
7420         * opencl-lang.c (opencl_language_defn): Initialise new field.
7421         * p-lang.c (pascal_is_string_type_p): New function.
7422         (pascal_language_defn): Initialise new field.
7423         * rust-lang.c (rust_is_string_type_p): New function.
7424         (rust_language_defn): Initialise new field.
7425
7426 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7427
7428         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7429         New field.
7430         * ada-lang.c (ada_language_defn): Initialise new field.
7431         * c-lang.c (c_language_defn): Likewise.
7432         (cplus_language_defn): Likewise.
7433         (asm_language_defn): Likewise.
7434         (minimal_language_defn): Likewise.
7435         * d-lang.c (d_language_defn): Likewise.
7436         * f-lang.c (f_language_defn): Likewise.
7437         * go-lang.c (go_language_defn): Likewise.
7438         * language.c (unknown_language_defn): Likewise.
7439         (auto_language_defn): Likewise.
7440         * m2-lang.c (m2_language_defn): Likewise.
7441         * objc-lang.c (objc_language_defn): Likewise.
7442         * opencl-lang.c (opencl_language_defn): Likewise.
7443         * p-lang.c (pascal_language_defn): Likewise.
7444         * rust-lang.c (rust_language_defn): Likewise.
7445
7446 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * ada-lang.c (ada_is_character_type): Change return type to bool.
7449         (ada_is_string_type): Likewise.
7450         * ada-lang.h (ada_is_character_type): Update declaration
7451         (ada_is_string_type): Likewise.
7452
7453 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7454
7455         Support style in 'frame|thread apply'
7456
7457         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7458         * record.c (record_start, record_stop): Update callers of
7459         execute_command_to_string with false.
7460         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7461         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7462         methods.
7463         (class string_file): New constructor with term_out parameter.
7464         Override methods term_out and can_emit_style_escape.  New member
7465         term_out.
7466         (class stdio_file): Override can_emit_style_escape.
7467         (class tee_file): Override term_out and can_emit_style_escape.
7468         * utils.h (can_emit_style_escape): Remove.
7469         * utils.c (can_emit_style_escape): Likewise.
7470         Update all callers of can_emit_style_escape (SOMESTREAM) to
7471         SOMESTREAM->can_emit_style_escape.
7472         * source-cache.c (source_cache::get_source_lines): Likewise.
7473         * stack.c (frame_apply_command_count): Call execute_command_to_string
7474         passing the term_out characteristic of the current gdb_stdout.
7475         * thread.c (thr_try_catch_cmd): Likewise.
7476         * top.c (execute_command_to_string): pass term_out parameter
7477         to construct the string_file for the command output.
7478         * ui-file.c (term_cli_styling): New function (most code moved
7479         from utils.c can_emit_style_escape).
7480         (string_file::string_file, string_file::can_emit_style_escape,
7481         stdio_file::can_emit_style_escape, tee_file::term_out,
7482         tee_file::can_emit_style_escape): New functions.
7483
7484 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7485
7486         * NEWS: Mention the new set|show may-call-functions.
7487         * infcall.c (may_call_functions_p): New variable.
7488         (show_may_call_functions_p): New function.
7489         (call_function_by_hand_dummy): Throws an error if not
7490         may-call-functions.
7491         (_initialize_infcall): Call add_setshow_boolean_cmd for
7492         may-call-functions.
7493
7494 2019-04-25  Keith Seitz  <keiths@redhat.com>
7495
7496         PR c++/24367
7497         * cp-support.c (inspect_type): Don't attempt substitutions
7498         of symbol with the same name.
7499
7500 2019-04-25  Tom Tromey  <tromey@adacore.com>
7501
7502         PR gdb/24475:
7503         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7504         static.
7505
7506 2019-04-25  Tom Tromey  <tromey@adacore.com>
7507
7508         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7509         rvalue reference.
7510         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7511         (gdb_xml_parser::parse): Use std::move.
7512         * python/python-internal.h (gdbpy_convert_exception): Take a const
7513         reference.
7514         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7515         std::move.
7516         * python/py-utils.c (gdbpy_convert_exception): Take a const
7517         reference.
7518         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7519         Use std::move.
7520         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7521         Use std::move.
7522         * mi/mi-main.c (mi_print_exception): Take a const reference.
7523         * main.c (handle_command_errors): Take a const reference.
7524         * linespec.c (parse_linespec): Use std::move.
7525         * infcall.c (run_inferior_call): Use std::move.
7526         (call_function_by_hand_dummy): Use std::move.
7527         * exec.c (try_open_exec_file): Use std::move.
7528         * exceptions.h (exception_print, exception_fprintf)
7529         (exception_print_same): Update.
7530         * exceptions.c (print_exception, exception_print)
7531         (exception_fprintf, exception_print_same): Change parameters to
7532         const reference.
7533         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7534         * common/new-op.c: Use std::move.
7535         * common/common-exceptions.h (struct gdb_exception): Add move
7536         constructor.
7537         (struct gdb_exception_error, struct gdb_exception_quit, struct
7538         gdb_quit_bad_alloc): Change constructor to move constructor.
7539         (throw_exception): Change parameter to rvalue reference.
7540         * common/common-exceptions.c (throw_exception): Take rvalue
7541         reference.
7542         * cli/cli-interp.c (safe_execute_command): Use std::move.
7543         * breakpoint.c (insert_bp_location, location_to_sals): Use
7544         std::move.
7545
7546 2019-04-25  Tom Tromey  <tromey@adacore.com>
7547
7548         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7549         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7550         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7551         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7552         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7553         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7554         guile/scm-value.c: Use unpack.
7555         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7556         gdbscm_gdb_exception.
7557         (gdbscm_throw_gdb_exception): Likewise.
7558         (struct gdbscm_gdb_exception): New.
7559         (unpack): New function.
7560         (gdbscm_wrap): Use unpack.
7561
7562 2019-04-25  Tom Tromey  <tromey@adacore.com>
7563
7564         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7565         (gdb_rl_callback_handler): Use std::move.
7566         * common/common-exceptions.h (struct gdb_exception): Add move
7567         assignment operator.
7568         (throw_exception_sjlj): Change "exception" to const reference.
7569         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7570         (throw_exception_sjlj): Change "exception" to const reference.
7571
7572 2019-04-25  Tom Tromey  <tromey@adacore.com>
7573
7574         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7575         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7576         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7577         Update.
7578         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7579         Update.
7580         * mi/mi-interp.c (mi_interp::exec): Update.
7581         * linespec.c (parse_linespec): Update.
7582         * infcall.c (run_inferior_call): Update.
7583         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7584         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7585         (gdbscm_lookup_global_symbol): Update.
7586         * guile/scm-param.c (gdbscm_parameter_value): Update.
7587         * guile/scm-frame.c (gdbscm_frame_read_register)
7588         (gdbscm_frame_read_var): Update.
7589         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7590         * exec.c (try_open_exec_file): Update.
7591         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7592         (gdb_rl_callback_handler): Update.
7593         * common/common-exceptions.h (exception_none): Don't declare.
7594         * common/common-exceptions.c (exception_none): Don't define.
7595         (struct catcher) <exception>: Update.
7596         * cli/cli-interp.c (safe_execute_command): Update.
7597         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7598
7599 2019-04-25  Ali Tamur  <tamur@google.com>
7600
7601         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7602         (read_attribute_value): Likewise.
7603         (dwarf2_read_addr_index): Update comment.
7604         (read_str_index): Add DW_FORM_strx.
7605         (dwarf2_string_attr): Likewise.
7606         (dwarf2_const_value_attr): Likewise.
7607         (dump_die_shallow): Likewise.
7608         (dwarf2_fetch_constant_bytes): Likewise.
7609         (skip_form_bytes): Likewise.
7610         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7611
7612 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7613
7614         PR corefiles/11608
7615         PR corefiles/18187
7616         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7617         OFFSET.  Verify if current mapping contains an ELF header.
7618         (linux_find_memory_regions_full): Adjust call to
7619         dump_mapping_p.
7620
7621 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7622             Kang Li <kanglictf@gmail.com>
7623
7624         PR gdb/21600
7625
7626         * dwarf2-frame.c (read_initial_length): Be consistent about using
7627         unsigned representation of length.
7628         (decode_frame_entry_1): Likewise.  Check for wraparound of
7629         end pointer as well as buffer overflow.
7630
7631 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7632
7633         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7634         "vq".
7635
7636 2019-04-24  Tom Tromey  <tromey@adacore.com>
7637
7638         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7639
7640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * s12z-tdep.c (s12z_unwind_pc): Delete.
7643         (s12z_unwind_sp): Delete.
7644         (s12z_gdbarch_init): Don't register deleted functions with
7645         gdbarch.
7646
7647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * rl78-tdep.c (rl78_unwind_sp): Delete.
7650         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7651
7652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7655         (xstormy16_unwind_pc): Delete.
7656         (xstormy16_dummy_id): Delete.
7657         (xstormy16_gdbarch_init): Don't register deleted functions with
7658         gdbarch.
7659
7660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * vax-tdep.c (vax_unwind_pc): Delete.
7663         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7664
7665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7666
7667         * v850-tdep.c (v850_unwind_sp): Delete.
7668         (v850_unwind_pc): Delete.
7669         (v850_dummy_id): Delete.
7670         (v850_gdbarch_init): Don't register deleted functions with
7671         gdbarch.
7672
7673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7674
7675         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7676         (tilegx_unwind_pc): Delete.
7677         (tilegx_unwind_dummy_id): Delete.
7678         (tilegx_gdbarch_init): Don't register deleted functions with
7679         gdbarch.
7680
7681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7682
7683         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7684         (tic6x_dummy_id): Delete.
7685         (tic6x_gdbarch_init): Don't register deleted functions with
7686         gdbarch.
7687
7688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7689
7690         * sparc-tdep.c (sparc_unwind_pc): Delete.
7691         (sparc32_gdbarch_init): Don't register deleted function with
7692         gdbarch.
7693
7694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * sh-tdep.c (sh_unwind_sp): Delete.
7697         (sh_unwind_pc): Delete.
7698         (sh_dummy_id): Delete.
7699         (sh_gdbarch_init): Don't register deleted functions with
7700         gdbarch.
7701
7702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * score-tdep.c (score_unwind_sp): Delete.
7705         (score_unwind_pc): Delete.
7706         (score_dummy_id): Delete.
7707         (score_gdbarch_init): Don't register deleted functions with
7708         gdbarch.
7709
7710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7711
7712         * rx-tdep.c (rx_unwind_pc): Delete.
7713         (rx_unwind_sp): Delete.
7714         (rx_dummy_id): Delete.
7715         (rx_gdbarch_init): Don't register deleted functions with
7716         gdbarch.  Update comment.
7717
7718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7721         (rs6000_dummy_id): Delete.
7722         (rs6000_gdbarch_init): Don't register deleted functions with
7723         gdbarch.
7724
7725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * or1k-tdep.c (or1k_dummy_id): Delete.
7728         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7729
7730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * nios2-tdep.c (nios2_dummy_id): Delete.
7733         (nios2_unwind_sp): Delete.
7734         (nios2_gdbarch_init): Don't register deleted functions with
7735         gdbarch.
7736
7737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * nds32-tdep.c (nds32_dummy_id): Delete.
7740         (nds32_unwind_pc): Delete.
7741         (nds32_unwind_sp): Delete.
7742         (nds32_gdbarch_init): Don't register deleted functions with
7743         gdbarch.
7744
7745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * msp430-tdep.c (msp430_unwind_pc): Delete.
7748         (msp430_unwind_sp): Delete.
7749         (msp430_dummy_id): Delete.
7750         (msp430_gdbarch_init): Don't register deleted functions with
7751         gdbarch.
7752
7753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * moxie-tdep.c (moxie_unwind_sp): Delete.
7756         (moxie_unwind_pc): Delete.
7757         (moxie_dummy_id): Delete.
7758         (moxie_gdbarch_init): Don't register deleted functions with
7759         gdbarch.
7760
7761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7764         (mn10300_unwind_pc): Delete.
7765         (mn10300_unwind_sp): Delete.
7766         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7767         mn10300_unwind_sp.
7768         (mn10300_frame_unwind_init): Don't register deleted functions with
7769         gdbarch.
7770
7771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * mep-tdep.c (mep_unwind_pc): Delete.
7774         (mep_unwind_sp): Delete.
7775         (mep_dummy_id): Delete.
7776         (mep_gdbarch_init): Don't register deleted functions with
7777         gdbarch.
7778
7779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7782         (m68hc11_unwind_sp): Delete.
7783         (m68hc11_gdbarch_init): Don't register deleted functions with
7784         gdbarch.
7785
7786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7787
7788         * m32r-tdep.c (m32r_unwind_sp): Delete.
7789         (m32r_unwind_pc): Delete.
7790         (m32r_dummy_id): Delete.
7791         (m32r_gdbarch_init): Don't register deleted functions with
7792         gdbarch.
7793
7794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * m32c-tdep.c (m32c_unwind_pc): Delete.
7797         (m32c_unwind_sp): Delete.
7798         (m32c_dummy_id): Delete.
7799         (m32c_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7805         (lm32_unwind_pc): Delete.
7806         (lm32_dummy_id): Delete.
7807         (lm32_gdbarch_init): Don't register deleted functions with
7808         gdbarch.
7809
7810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7813         (iq2000_unwind_pc): Delete.
7814         (iq2000_dummy_id): Delete.
7815         (iq2000_gdbarch_init): Don't register deleted functions with
7816         gdbarch.
7817
7818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * nds32-tdep.c (nds32_type_align): Delete.
7821         (nds32_push_dummy_call): Use type_align instead.
7822
7823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * arm-tdep.c (arm_type_align): Only handle vector override case.
7826         (arm_push_dummy_call): Use type_align.
7827         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7828
7829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7832         case.
7833         (pass_on_stack): Use type_align.
7834         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7835         function.
7836
7837 2019-04-23  Tom Tromey  <tromey@adacore.com>
7838
7839         * dwarf2read.c (line_header::file_name_at): Remove unused
7840         overload.
7841
7842 2019-04-23  Tom de Vries  <tdevries@suse.de>
7843
7844         PR gdb/24438
7845         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7846         invocation.
7847
7848
7849 2019-03-27  Ali Tamur  <tamur@google.com>
7850
7851         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7852         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7853         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7854         (dwarf_expr_context::get_addr_index): Likewise
7855         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7856         (symbol_needs_eval_context::get_addr_index): Likewise
7857         (disassemble_dwarf_expression): Add DW_OP_addrx
7858         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7859         (read_cutu_die_from_dwo): Update comment
7860         (skip_one_die): Add DW_FORM_addrx
7861         (read_attribute_value): Likewise
7862         (var_decode_location): Add DW_OP_addrx
7863         (dwarf2_const_value_attr): Add DW_FORM_addrx
7864         (dump_die_shallow): Likewise
7865         (dwarf2_fetch_constant_bytes): Likewise
7866         (decode_locdesc): Add DW_OP_addrx
7867         (skip_form_bytes): Add DW_FORM_addrx
7868
7869 2019-04-22  Ali Tamur  <tamur@google.com>
7870
7871         * MAINTAINERS (Write After Approval): Add self.
7872
7873 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7874
7875         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7876         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7877         (open_symbol_file_object): Likewise.
7878         (svr4_default_sos): Add info parameter.
7879         (svr4_read_so_list): Likewise.
7880         (svr4_current_sos_direct): Adjust functions calls to pass down
7881         info.
7882         (svr4_current_sos_1): Add info parameter.
7883         (svr4_current_sos): Call get_svr4_info, pass info down to
7884         svr4_current_sos_1.
7885         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7886         get_svr4_info.
7887         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7888         get_svr4_info.
7889         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7890         to get_svr4_info.
7891         (probes_table_remove_objfile_probes): Likewise.
7892         (register_solib_event_probe): Add info parameter.
7893         (solist_update_incremental): Pass info parameter down to
7894         svr4_read_so_list.
7895         (disable_probes_interface): Add info parameter.
7896         (svr4_handle_solib_event): Pass current_program_space to
7897         get_svr4_info.  Adjust disable_probes_interface cleanup.
7898         (svr4_create_probe_breakpoints): Add info parameter, pass it
7899         down to register_solib_event_probe.
7900         (svr4_create_solib_event_breakpoints): Add info parameter,
7901         pass it down to svr4_create_probe_breakpoints.
7902         (enable_break): Pass info down to
7903         svr4_create_solib_event_breakpoints.
7904         (svr4_solib_create_inferior_hook): Pass current_program_space to
7905         get_svr4_info.
7906         (svr4_clear_solib): Likewise.
7907
7908 2019-04-22  Pedro Alves  <palves@redhat.com>
7909
7910         * solib-svr4.c (svr4_free_objfile_observer): New.
7911         (probe_and_action::objfile): New field.
7912         (probes_table_htab_remove_objfile_probes)
7913         (probes_table_remove_objfile_probes): New functions.
7914         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7915         in the new probe_and_action.  Don't store the probe in 'lookup'.
7916         (svr4_create_probe_breakpoints): Pass objfile to
7917         register_solib_event_probe.
7918         (_initialize_svr4_solib): Register a free_objfile observer.
7919
7920 2019-04-19  Tom Tromey  <tom@tromey.com>
7921
7922         * common/queue.h: Remove.
7923
7924 2019-04-19  Tom Tromey  <tom@tromey.com>
7925
7926         * event-loop.c: Don't include "common/queue.h".
7927
7928 2019-04-19  Tom Tromey  <tom@tromey.com>
7929
7930         * remote.c (remote_target): Use delete.
7931         * remote-notif.h: Include <list>, not "common/queue.h".
7932         (notif_client_p): Remove typedef.
7933         (remote_notif_state): Add constructor, destructor, initializer.
7934         <notif_queue>: Now a std::list.
7935         (remote_notif_state_xfree): Don't declare.
7936         * remote-notif.c (remote_notif_process, handle_notification)
7937         (remote_notif_state_allocate): Update.
7938         (~remote_notif_state): Rename from remote_notif_state_xfree.
7939
7940 2019-04-19  Tom Tromey  <tom@tromey.com>
7941
7942         * symfile.c (reread_symbols): Update.
7943         * objfiles.c (objfile_register_static_link)
7944         (objfile_lookup_static_link): Update
7945         (~objfile) Don't delete static_links.
7946         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7947
7948 2019-04-19  Tom Tromey  <tom@tromey.com>
7949
7950         * type-stack.h (struct type_stack) <insert>: Constify string.
7951         * type-stack.c (type_stack::insert): Constify string.
7952         * gdbtypes.h (lookup_template_type): Update.
7953         (address_space_name_to_int): Update.
7954         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7955         const.
7956         (lookup_template_type): Make name const.
7957         * c-exp.y: Update rules.
7958         (lex_one_token, classify_name, classify_inner_name)
7959         (c_print_token): Update.
7960         * p-exp.y: Update rules.
7961         (yylex): Update.
7962         * f-exp.y: Update rules.
7963         (yylex): Update.
7964         * d-exp.y: Update rules.
7965         (lex_one_token, classify_name, classify_inner_name): Update.
7966         * parse.c (write_dollar_variable, copy_name): Return std::string.
7967         * parser-defs.h (copy_name): Change return type.
7968         * m2-exp.y: Update rules.
7969         (yylex): Update.
7970         * go-exp.y (lex_one_token): Update.
7971         Update rules.
7972         (classify_unsafe_function, classify_packaged_name)
7973         (classify_name, yylex): Update.
7974
7975 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7976
7977         * configure.ac: add --enable-source-highlight switch.
7978         * configure: Regenerate.
7979         * top.c (print_gdb_version): plumb --enable-source-highlight
7980         status to "show configuration".
7981
7982 2019-04-19  Tom Tromey  <tromey@adacore.com>
7983
7984         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7985         Check ADA_TYPE_P.
7986         (empty_record, ada_template_to_fixed_record_type_1)
7987         (template_to_static_fixed_type)
7988         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7989         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7990         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7991         macros.
7992
7993 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7994
7995         PR symtab/24423:
7996         * source.c (print_source_lines_base): Advance "iter" when a
7997         control character is seen.
7998
7999 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8000
8001         * inferior.h (struct infcall_suspend_state_deleter):
8002         Catch exception in destructor to avoid crash.
8003
8004 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8005
8006         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8007         close to the add_com "shell".
8008
8009 2019-04-18  Tom Tromey  <tromey@adacore.com>
8010
8011         * process-stratum-target.h (class process_stratum_target)
8012         <stratum>: Add "final".
8013
8014 2019-04-17  Tom Tromey  <tromey@adacore.com>
8015
8016         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8017         against nullptr before use.
8018
8019 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8020
8021         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8022
8023 2019-04-17  Jim Wilson  <jimw@sifive.com>
8024             Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8027         code read might fail, assume 4-byte breakpoint in that case.
8028
8029 2019-04-15  Leszek Swirski  <leszeks@google.com>
8030
8031         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8032         rather than a hand-rolled POD check when checking for forced MEMORY
8033         classification.
8034
8035 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8036
8037         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8038         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8039         function.
8040         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8041         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8042         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8043         declaration.
8044
8045 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8046
8047         * aarch64-linux-nat.c
8048         (aarch64_linux_nat_target::thread_architecture): Add override.
8049         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8050         each VQ.
8051
8052 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8053
8054         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8055
8056 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8059         target types of size 96-bits, add some additional comments, and
8060         check that the builtin type we found was the correct size.
8061
8062 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8063
8064         * utils.c (prompt_for_continue): Don't restore the styling at the
8065         end, as applied_style has the wrong value.  This fixes styling in
8066         long lists of file names that are interrupted by the "Continue?"
8067         prompt.
8068
8069 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8070
8071         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8072         * c-lang.c (c_language_defn): Likewise.
8073         (cplus_language_defn): Likewise.
8074         (asm_language_defn): Likewise.
8075         (minimal_language_defn): Likewise.
8076         * d-lang.c (d_language_defn): Likewise.
8077         * f-lang.c (f_language_defn): Likewise.
8078         * go-lang.c (go_language_defn): Likewise.
8079         * language.c (unknown_language_defn): Likewise.
8080         (auto_language_defn): Likewise.
8081         * language.h (struct language_defn): Remove la_magic field.
8082         (LANG_MAGIC): Delete.
8083         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8084         * objc-lang.c (objc_language_defn): Likewise.
8085         * opencl-lang.c (opencl_language_defn): Likewise.
8086         * p-lang.c (pascal_language_defn): Likewise.
8087         * rust-lang.c (rust_language_defn): Likewise.
8088
8089 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8090
8091         * riscv-tdep.c (riscv_type_align): New function.
8092         (riscv_type_alignment): Delete.
8093         (riscv_arg_location): Use 'type_align'.
8094         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8095
8096 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * gdbtypes.c (type_align): A struct with no non-static fields also
8099         has alignment of 1.
8100
8101 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8104         component to 0.
8105         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8106         member.
8107         (riscv_struct_info::analyse): New implementation using new
8108         analyse_inner member function.
8109         (riscv_struct_info::field_offset): New member function.
8110         (riscv_struct_info::m_offsets): New member variable.
8111         (riscv_struct_info::analyse_inner): New private member function,
8112         takes the old implementation of riscv_struct_info::analyse but
8113         extended to track field offsets.
8114         (riscv_call_arg_struct): Update the struct folding special cases
8115         to handle cases where empty C++ structs, which are non-zero
8116         length, are found.
8117         (riscv_arg_location): Initialise the length of each location, a
8118         non-zero length now indicates the location is in use.
8119         (riscv_push_dummy_call): Allow for the first location having a
8120         non-zero offset when setting up arguments.
8121         (riscv_return_value): Likewise, but for return values.
8122
8123 2019-04-11  Tom Tromey  <tromey@adacore.com>
8124
8125         * utils.c (internal_vproblem): Make "msg" const.
8126
8127 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8128
8129         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8130         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8131         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8132         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8133
8134 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8135
8136         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8137         function.
8138         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8139         of amd64_collect_native_gregset.
8140         (amd64_linux_nat_target::store_registers): Likewise.
8141
8142 2019-04-10  Tom Tromey  <tom@tromey.com>
8143
8144         * symtab.c (lookup_global_symbol_from_objfile)
8145         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8146         * objfiles.h (class separate_debug_iterator): New.
8147         (class separate_debug_range): New.
8148         (struct objfile) <separate_debug_objfiles>: New method.
8149         (objfile_separate_debug_iterate): Don't declare.
8150         * objfiles.c (separate_debug_iterator::operator++): Rename from
8151         objfile_separate_debug_iterate.
8152         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8153         iterator.
8154         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8155         iterator.
8156
8157 2019-04-10  Tom Tromey  <tom@tromey.com>
8158
8159         * symfile.c (reread_symbols): Remove old comment.
8160         * objfiles.c (free_all_objfiles): Fix a typo.
8161
8162 2019-04-10  Tom Tromey  <tom@tromey.com>
8163
8164         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8165         * minsyms.c (lookup_minimal_symbol): Use foreach.
8166         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8167         (lookup_minimal_symbol_solib_trampoline): Likewise.
8168         * symfile.c (reread_symbols): Use foreach.
8169
8170 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8171             Tom Tromey  <tromey@adacore.com>
8172
8173         PR rust/24414:
8174         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8175         (rust_lex_int_test): Change "value" to be LONGEST.
8176         (rust_lex_tests): Add test for long integer literal.
8177
8178 2019-04-09  Tom Tromey  <tromey@adacore.com>
8179
8180         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8181         to bool.
8182         (extended_remote_target::attach): Update.
8183         (remote_target::remote_notice_new_inferior): Update.
8184         (remote_target::add_current_inferior_and_thread): Update.
8185         * inferior.c (exit_inferior_1): Use "false".
8186         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8187
8188 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8189
8190         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8191         the "start" command.
8192
8193 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8194
8195         * python/py-inferior.c (infpy_thread_from_thread_handle):
8196         Adjust comments to reflect renaming of thread_from_thread_handle
8197         to thread_from_handle.  Adjust keywords.  Fix type error message.
8198         (inferior_object_methods): Add thread_from_handle.  Retain
8199         thread_from_thread_handle, but mark it as deprecated.
8200
8201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8202
8203         * gdbthread.h (find_thread_by_handle): Revise declaration.
8204         * thread.c (find_thread_by_handle): Likewise.  Adjust
8205         implementation too.
8206         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8207         support for buffer objects as handles.
8208
8209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8210
8211         * python/py-infthread.c (thpy_thread_handle): New function.
8212         (thread_object_methods): Register thpy_thread_handle.
8213
8214 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8215
8216         * gdbthread.h (thread_to_thread_handle): Declare.
8217         * thread.c (gdbtypes.h): Include.
8218         (thread_to_thread_handle): New function.
8219
8220         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8221         (target_thread_info_to_thread_handle): Declare.
8222         * target.c (target_thread_info_to_thread_handle): New function.
8223         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8224         * target-delegates.c: Regenerate.
8225
8226         * linux-thread-db.c (class thread_db_target): Add method
8227         thread_info_to_thread_handle.
8228         (thread_db_target::thread_info_to_thread_handle): Define.
8229         * remote.c (class remote_target): Add new method
8230         thread_info_to_thread_handle.
8231         (remote_target::thread_info_to_thread_handle): Define.
8232
8233 2019-04-08  Pedro Alves  <palves@redhat.com>
8234
8235         * common/common-exceptions.c (throw_exception): Don't create
8236         named object to throw; throw directly.
8237         (throw_it): Likewise.  Don't initialize gdb_exception::message
8238         here, with new; pass FMT and AP to the ctor instead.
8239         * common/common-exceptions.h: Include <string>.
8240         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8241         const char *, va_list)): New ctor.  Use std::make_shared.
8242         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8243         errors)): Delete.
8244         (gdb_exception_error::gdb_exception_error(enum errors, const char
8245         *, va_list)): New.
8246         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8247         Add assertion.
8248         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8249         errors)): Delete.
8250         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8251         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8252         Add assertion.
8253
8254 2019-04-08  Tom Tromey  <tom@tromey.com>
8255
8256         * valops.c (value_rtti_indirect_type): Replace throw_exception
8257         with throw.
8258         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8259         with throw.
8260         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8261         throw.
8262         * target.c (target_translate_tls_address): Replace throw_exception
8263         with throw.
8264         * stack.c (frame_apply_command_count): Replace throw_exception
8265         with throw.
8266         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8267         throw.
8268         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8269         with throw.
8270         * rs6000-tdep.c (rs6000_frame_cache)
8271         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8272         * remote.c: Replace throw_exception with throw.
8273         * record-full.c (record_full_message, record_full_wait_1)
8274         (record_full_restore): Replace throw_exception with throw.
8275         * record-btrace.c:
8276         (get_thread_current_frame_id, record_btrace_start_replaying)
8277         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8278         (cmd_record_btrace_start): Replace throw_exception with throw.
8279         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8280         throw.
8281         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8282         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8283         * linespec.c:
8284         (find_linespec_symbols): Replace throw_exception with throw.
8285         * infrun.c (displaced_step_prepare, resume): Replace
8286         throw_exception with throw.
8287         * infcmd.c (post_create_inferior): Replace throw_exception with
8288         throw.
8289         * inf-loop.c (inferior_event_handler): Replace throw_exception
8290         with throw.
8291         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8292         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8293         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8294         (get_prev_frame_always, get_frame_pc_if_available)
8295         (get_frame_address_in_block_if_available, get_frame_language):
8296         Replace throw_exception with throw.
8297         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8298         throw_exception with throw.
8299         * eval.c (fetch_subexp_value, evaluate_var_value)
8300         (evaluate_funcall, evaluate_subexp_standard): Replace
8301         throw_exception with throw.
8302         * dwarf2loc.c (call_site_find_chain)
8303         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8304         Replace throw_exception with throw.
8305         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8306         with throw.
8307         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8308         throw.
8309         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8310         * completer.c (complete_line_internal): Replace throw_exception
8311         with throw.
8312         * compile/compile-object-run.c (compile_object_run): Replace
8313         throw_exception with throw.
8314         * cli/cli-script.c (process_next_line): Replace throw_exception
8315         with throw.
8316         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8317         (btrace_enable, btrace_maint_update_pt_packets): Replace
8318         throw_exception with throw.
8319         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8320         throw_exception with throw.
8321         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8322         throw_exception with throw.
8323         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8324         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8325         * aarch64-tdep.c (aarch64_make_prologue_cache)
8326         (aarch64_make_stub_cache): Replace throw_exception with throw.
8327
8328 2019-04-08  Tom Tromey  <tom@tromey.com>
8329
8330         * common/common-exceptions.c (throw_exception): Rename from
8331         throw_exception_cxx.  Remove old copy.  Make argument const.
8332         (throw_it): Create and throw exception objects directly.
8333         * common/common-exceptions.h (throw_exception): Make argument
8334         const.
8335         (struct gdb_exception_error): Add constructor.
8336         (struct gdb_exception_quit): Add constructor.
8337
8338 2019-04-08  Tom Tromey  <tom@tromey.com>
8339
8340         * common/common-exceptions.h (exception_rethrow): Don't declare.
8341         (TRY_SJLJ): Update comment.
8342         (TRY, CATCH, END_CATCH): Remove.
8343         * common/common-exceptions.c (exception_rethrow): Remove.
8344
8345 2019-04-08  Tom Tromey  <tom@tromey.com>
8346
8347         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8348         Remove.
8349         (gdb_exception_error): Rename from
8350         gdb_exception_RETURN_MASK_ERROR.
8351         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8352         (gdb_quit_bad_alloc): Update.
8353         * aarch64-tdep.c: Update.
8354         * ada-lang.c: Update.
8355         * ada-typeprint.c: Update.
8356         * ada-valprint.c: Update.
8357         * amd64-tdep.c: Update.
8358         * arch-utils.c: Update.
8359         * break-catch-throw.c: Update.
8360         * breakpoint.c: Update.
8361         * btrace.c: Update.
8362         * c-varobj.c: Update.
8363         * cli/cli-cmds.c: Update.
8364         * cli/cli-interp.c: Update.
8365         * cli/cli-script.c: Update.
8366         * common/common-exceptions.c: Update.
8367         * common/new-op.c: Update.
8368         * common/selftest.c: Update.
8369         * compile/compile-c-symbols.c: Update.
8370         * compile/compile-cplus-symbols.c: Update.
8371         * compile/compile-object-load.c: Update.
8372         * compile/compile-object-run.c: Update.
8373         * completer.c: Update.
8374         * corelow.c: Update.
8375         * cp-abi.c: Update.
8376         * cp-support.c: Update.
8377         * cp-valprint.c: Update.
8378         * darwin-nat.c: Update.
8379         * disasm-selftests.c: Update.
8380         * dtrace-probe.c: Update.
8381         * dwarf-index-cache.c: Update.
8382         * dwarf-index-write.c: Update.
8383         * dwarf2-frame-tailcall.c: Update.
8384         * dwarf2-frame.c: Update.
8385         * dwarf2loc.c: Update.
8386         * dwarf2read.c: Update.
8387         * eval.c: Update.
8388         * event-loop.c: Update.
8389         * event-top.c: Update.
8390         * exec.c: Update.
8391         * f-valprint.c: Update.
8392         * fbsd-tdep.c: Update.
8393         * frame-unwind.c: Update.
8394         * frame.c: Update.
8395         * gdbtypes.c: Update.
8396         * gnu-v3-abi.c: Update.
8397         * guile/guile-internal.h: Update.
8398         * guile/scm-block.c: Update.
8399         * guile/scm-breakpoint.c: Update.
8400         * guile/scm-cmd.c: Update.
8401         * guile/scm-disasm.c: Update.
8402         * guile/scm-frame.c: Update.
8403         * guile/scm-lazy-string.c: Update.
8404         * guile/scm-math.c: Update.
8405         * guile/scm-param.c: Update.
8406         * guile/scm-ports.c: Update.
8407         * guile/scm-pretty-print.c: Update.
8408         * guile/scm-symbol.c: Update.
8409         * guile/scm-symtab.c: Update.
8410         * guile/scm-type.c: Update.
8411         * guile/scm-value.c: Update.
8412         * i386-linux-tdep.c: Update.
8413         * i386-tdep.c: Update.
8414         * inf-loop.c: Update.
8415         * infcall.c: Update.
8416         * infcmd.c: Update.
8417         * infrun.c: Update.
8418         * jit.c: Update.
8419         * language.c: Update.
8420         * linespec.c: Update.
8421         * linux-fork.c: Update.
8422         * linux-nat.c: Update.
8423         * linux-tdep.c: Update.
8424         * linux-thread-db.c: Update.
8425         * main.c: Update.
8426         * mi/mi-cmd-break.c: Update.
8427         * mi/mi-cmd-stack.c: Update.
8428         * mi/mi-interp.c: Update.
8429         * mi/mi-main.c: Update.
8430         * objc-lang.c: Update.
8431         * p-valprint.c: Update.
8432         * parse.c: Update.
8433         * ppc-linux-tdep.c: Update.
8434         * printcmd.c: Update.
8435         * python/py-arch.c: Update.
8436         * python/py-breakpoint.c: Update.
8437         * python/py-cmd.c: Update.
8438         * python/py-finishbreakpoint.c: Update.
8439         * python/py-frame.c: Update.
8440         * python/py-framefilter.c: Update.
8441         * python/py-gdb-readline.c: Update.
8442         * python/py-inferior.c: Update.
8443         * python/py-infthread.c: Update.
8444         * python/py-lazy-string.c: Update.
8445         * python/py-linetable.c: Update.
8446         * python/py-objfile.c: Update.
8447         * python/py-param.c: Update.
8448         * python/py-prettyprint.c: Update.
8449         * python/py-progspace.c: Update.
8450         * python/py-record-btrace.c: Update.
8451         * python/py-record.c: Update.
8452         * python/py-symbol.c: Update.
8453         * python/py-type.c: Update.
8454         * python/py-unwind.c: Update.
8455         * python/py-utils.c: Update.
8456         * python/py-value.c: Update.
8457         * python/python.c: Update.
8458         * record-btrace.c: Update.
8459         * record-full.c: Update.
8460         * remote-fileio.c: Update.
8461         * remote.c: Update.
8462         * riscv-tdep.c: Update.
8463         * rs6000-aix-tdep.c: Update.
8464         * rs6000-tdep.c: Update.
8465         * rust-exp.y: Update.
8466         * rust-lang.c: Update.
8467         * s390-tdep.c: Update.
8468         * selftest-arch.c: Update.
8469         * solib-dsbt.c: Update.
8470         * solib-frv.c: Update.
8471         * solib-spu.c: Update.
8472         * solib-svr4.c: Update.
8473         * solib.c: Update.
8474         * sparc64-linux-tdep.c: Update.
8475         * stack.c: Update.
8476         * symfile-mem.c: Update.
8477         * symmisc.c: Update.
8478         * target.c: Update.
8479         * thread.c: Update.
8480         * top.c: Update.
8481         * tracefile-tfile.c: Update.
8482         * tui/tui.c: Update.
8483         * typeprint.c: Update.
8484         * unittests/cli-utils-selftests.c: Update.
8485         * unittests/parse-connection-spec-selftests.c: Update.
8486         * valops.c: Update.
8487         * valprint.c: Update.
8488         * value.c: Update.
8489         * varobj.c: Update.
8490         * windows-nat.c: Update.
8491         * x86-linux-nat.c: Update.
8492         * xml-support.c: Update.
8493
8494 2019-04-08  Tom Tromey  <tom@tromey.com>
8495
8496         * xml-support.c: Use C++ exception handling.
8497         * x86-linux-nat.c: Use C++ exception handling.
8498         * windows-nat.c: Use C++ exception handling.
8499         * varobj.c: Use C++ exception handling.
8500         * value.c: Use C++ exception handling.
8501         * valprint.c: Use C++ exception handling.
8502         * valops.c: Use C++ exception handling.
8503         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8504         handling.
8505         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8506         * typeprint.c: Use C++ exception handling.
8507         * tui/tui.c: Use C++ exception handling.
8508         * tracefile-tfile.c: Use C++ exception handling.
8509         * top.c: Use C++ exception handling.
8510         * thread.c: Use C++ exception handling.
8511         * target.c: Use C++ exception handling.
8512         * symmisc.c: Use C++ exception handling.
8513         * symfile-mem.c: Use C++ exception handling.
8514         * stack.c: Use C++ exception handling.
8515         * sparc64-linux-tdep.c: Use C++ exception handling.
8516         * solib.c: Use C++ exception handling.
8517         * solib-svr4.c: Use C++ exception handling.
8518         * solib-spu.c: Use C++ exception handling.
8519         * solib-frv.c: Use C++ exception handling.
8520         * solib-dsbt.c: Use C++ exception handling.
8521         * selftest-arch.c: Use C++ exception handling.
8522         * s390-tdep.c: Use C++ exception handling.
8523         * rust-lang.c: Use C++ exception handling.
8524         * rust-exp.y: Use C++ exception handling.
8525         * rs6000-tdep.c: Use C++ exception handling.
8526         * rs6000-aix-tdep.c: Use C++ exception handling.
8527         * riscv-tdep.c: Use C++ exception handling.
8528         * remote.c: Use C++ exception handling.
8529         * remote-fileio.c: Use C++ exception handling.
8530         * record-full.c: Use C++ exception handling.
8531         * record-btrace.c: Use C++ exception handling.
8532         * python/python.c: Use C++ exception handling.
8533         * python/py-value.c: Use C++ exception handling.
8534         * python/py-utils.c: Use C++ exception handling.
8535         * python/py-unwind.c: Use C++ exception handling.
8536         * python/py-type.c: Use C++ exception handling.
8537         * python/py-symbol.c: Use C++ exception handling.
8538         * python/py-record.c: Use C++ exception handling.
8539         * python/py-record-btrace.c: Use C++ exception handling.
8540         * python/py-progspace.c: Use C++ exception handling.
8541         * python/py-prettyprint.c: Use C++ exception handling.
8542         * python/py-param.c: Use C++ exception handling.
8543         * python/py-objfile.c: Use C++ exception handling.
8544         * python/py-linetable.c: Use C++ exception handling.
8545         * python/py-lazy-string.c: Use C++ exception handling.
8546         * python/py-infthread.c: Use C++ exception handling.
8547         * python/py-inferior.c: Use C++ exception handling.
8548         * python/py-gdb-readline.c: Use C++ exception handling.
8549         * python/py-framefilter.c: Use C++ exception handling.
8550         * python/py-frame.c: Use C++ exception handling.
8551         * python/py-finishbreakpoint.c: Use C++ exception handling.
8552         * python/py-cmd.c: Use C++ exception handling.
8553         * python/py-breakpoint.c: Use C++ exception handling.
8554         * python/py-arch.c: Use C++ exception handling.
8555         * printcmd.c: Use C++ exception handling.
8556         * ppc-linux-tdep.c: Use C++ exception handling.
8557         * parse.c: Use C++ exception handling.
8558         * p-valprint.c: Use C++ exception handling.
8559         * objc-lang.c: Use C++ exception handling.
8560         * mi/mi-main.c: Use C++ exception handling.
8561         * mi/mi-interp.c: Use C++ exception handling.
8562         * mi/mi-cmd-stack.c: Use C++ exception handling.
8563         * mi/mi-cmd-break.c: Use C++ exception handling.
8564         * main.c: Use C++ exception handling.
8565         * linux-thread-db.c: Use C++ exception handling.
8566         * linux-tdep.c: Use C++ exception handling.
8567         * linux-nat.c: Use C++ exception handling.
8568         * linux-fork.c: Use C++ exception handling.
8569         * linespec.c: Use C++ exception handling.
8570         * language.c: Use C++ exception handling.
8571         * jit.c: Use C++ exception handling.
8572         * infrun.c: Use C++ exception handling.
8573         * infcmd.c: Use C++ exception handling.
8574         * infcall.c: Use C++ exception handling.
8575         * inf-loop.c: Use C++ exception handling.
8576         * i386-tdep.c: Use C++ exception handling.
8577         * i386-linux-tdep.c: Use C++ exception handling.
8578         * guile/scm-value.c: Use C++ exception handling.
8579         * guile/scm-type.c: Use C++ exception handling.
8580         * guile/scm-symtab.c: Use C++ exception handling.
8581         * guile/scm-symbol.c: Use C++ exception handling.
8582         * guile/scm-pretty-print.c: Use C++ exception handling.
8583         * guile/scm-ports.c: Use C++ exception handling.
8584         * guile/scm-param.c: Use C++ exception handling.
8585         * guile/scm-math.c: Use C++ exception handling.
8586         * guile/scm-lazy-string.c: Use C++ exception handling.
8587         * guile/scm-frame.c: Use C++ exception handling.
8588         * guile/scm-disasm.c: Use C++ exception handling.
8589         * guile/scm-cmd.c: Use C++ exception handling.
8590         * guile/scm-breakpoint.c: Use C++ exception handling.
8591         * guile/scm-block.c: Use C++ exception handling.
8592         * guile/guile-internal.h: Use C++ exception handling.
8593         * gnu-v3-abi.c: Use C++ exception handling.
8594         * gdbtypes.c: Use C++ exception handling.
8595         * frame.c: Use C++ exception handling.
8596         * frame-unwind.c: Use C++ exception handling.
8597         * fbsd-tdep.c: Use C++ exception handling.
8598         * f-valprint.c: Use C++ exception handling.
8599         * exec.c: Use C++ exception handling.
8600         * event-top.c: Use C++ exception handling.
8601         * event-loop.c: Use C++ exception handling.
8602         * eval.c: Use C++ exception handling.
8603         * dwarf2read.c: Use C++ exception handling.
8604         * dwarf2loc.c: Use C++ exception handling.
8605         * dwarf2-frame.c: Use C++ exception handling.
8606         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8607         * dwarf-index-write.c: Use C++ exception handling.
8608         * dwarf-index-cache.c: Use C++ exception handling.
8609         * dtrace-probe.c: Use C++ exception handling.
8610         * disasm-selftests.c: Use C++ exception handling.
8611         * darwin-nat.c: Use C++ exception handling.
8612         * cp-valprint.c: Use C++ exception handling.
8613         * cp-support.c: Use C++ exception handling.
8614         * cp-abi.c: Use C++ exception handling.
8615         * corelow.c: Use C++ exception handling.
8616         * completer.c: Use C++ exception handling.
8617         * compile/compile-object-run.c: Use C++ exception handling.
8618         * compile/compile-object-load.c: Use C++ exception handling.
8619         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8620         * compile/compile-c-symbols.c: Use C++ exception handling.
8621         * common/selftest.c: Use C++ exception handling.
8622         * common/new-op.c: Use C++ exception handling.
8623         * cli/cli-script.c: Use C++ exception handling.
8624         * cli/cli-interp.c: Use C++ exception handling.
8625         * cli/cli-cmds.c: Use C++ exception handling.
8626         * c-varobj.c: Use C++ exception handling.
8627         * btrace.c: Use C++ exception handling.
8628         * breakpoint.c: Use C++ exception handling.
8629         * break-catch-throw.c: Use C++ exception handling.
8630         * arch-utils.c: Use C++ exception handling.
8631         * amd64-tdep.c: Use C++ exception handling.
8632         * ada-valprint.c: Use C++ exception handling.
8633         * ada-typeprint.c: Use C++ exception handling.
8634         * ada-lang.c: Use C++ exception handling.
8635         * aarch64-tdep.c: Use C++ exception handling.
8636
8637 2019-04-08  Tom Tromey  <tom@tromey.com>
8638
8639         * xml-support.c (gdb_xml_parser::parse): Update.
8640         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8641         * value.c (show_convenience): Update.
8642         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8643         (test_parse_flags_qcs): Update.
8644         * thread.c (thr_try_catch_cmd): Update.
8645         * target.c (target_translate_tls_address): Update.
8646         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8647         (info_frame_command_core, frame_apply_command_count): Update.
8648         * rust-exp.y (rust_lex_exception_test): Update.
8649         * riscv-tdep.c (riscv_print_one_register_info): Update.
8650         * remote.c (remote_target::enable_btrace): Update.
8651         * record-btrace.c (record_btrace_enable_warn): Update.
8652         * python/py-utils.c (gdbpy_convert_exception): Update.
8653         * printcmd.c (do_one_display, print_variable_and_value): Update.
8654         * mi/mi-main.c (mi_print_exception): Update.
8655         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8656         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8657         * linux-nat.c (linux_nat_target::attach): Update.
8658         * linux-fork.c (class scoped_switch_fork_info): Update.
8659         * infrun.c (displaced_step_prepare): Update.
8660         * infcall.c (call_function_by_hand_dummy): Update.
8661         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8662         * gnu-v3-abi.c (print_one_vtable): Update.
8663         * frame.c (get_prev_frame_always): Update.
8664         * f-valprint.c (info_common_command_for_block): Update.
8665         * exec.c (try_open_exec_file): Update.
8666         * exceptions.c (print_exception, exception_print)
8667         (exception_fprintf, exception_print_same): Update.
8668         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8669         * dwarf-index-cache.c (index_cache::store)
8670         (index_cache::lookup_gdb_index): Update.
8671         * darwin-nat.c (maybe_cache_shell): Update.
8672         * cp-valprint.c (cp_print_value_fields): Update.
8673         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8674         (gcc_cplus_symbol_address): Update.
8675         * compile/compile-c-symbols.c (gcc_convert_symbol)
8676         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8677         * common/selftest.c: Update.
8678         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8679         a std::string.
8680         (exception_try_scope_entry, exception_try_scope_exit): Don't
8681         declare.
8682         (struct exception_try_scope): Remove.
8683         (TRY): Don't use exception_try_scope.
8684         (struct gdb_exception): Add constructor, operator=.
8685         <what>: New method.
8686         (struct gdb_exception_RETURN_MASK_ALL)
8687         (struct gdb_exception_RETURN_MASK_ERROR)
8688         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8689         (struct gdb_quit_bad_alloc): Update.
8690         * common/common-exceptions.c (exception_none): Change
8691         initializer.
8692         (struct catcher) <state, exception>: Initialize inline.
8693         <prev>: Remove member.
8694         (current_catcher): Remove.
8695         (catchers): New global.
8696         (exceptions_state_mc_init): Simplify.
8697         (catcher_pop): Remove.
8698         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8699         (try_scope_depth, exception_try_scope_entry)
8700         (exception_try_scope_exit): Remove.
8701         (throw_exception_sjlj): Update.
8702         (exception_messages, exception_messages_size): Remove.
8703         (throw_it): Simplify.
8704         (gdb_exception_sliced_copy): Remove.
8705         (throw_exception_cxx): Update.
8706         * cli/cli-script.c (script_from_file): Update.
8707         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8708         Update.
8709         * ada-valprint.c (ada_val_print): Update.
8710         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8711         (create_excep_cond_exprs): Update.
8712
8713 2019-04-08  Tom Tromey  <tom@tromey.com>
8714
8715         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8716         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8717         (TRY, CATCH, END_CATCH): Remove some definitions.
8718         * common/common-exceptions.c: Don't use GDB_XCPT.
8719         (catcher_list_size): Remove.
8720         (throw_exception, throw_it): Simplify.
8721
8722 2019-04-05  Tom Tromey  <tom@tromey.com>
8723
8724         Revert the header-sorting patch.
8725         * ft32-tdep.c: Revert.
8726         * frv-tdep.c: Revert.
8727         * frv-linux-tdep.c: Revert.
8728         * frame.c: Revert.
8729         * frame-unwind.c: Revert.
8730         * frame-base.c: Revert.
8731         * fork-child.c: Revert.
8732         * findvar.c: Revert.
8733         * findcmd.c: Revert.
8734         * filesystem.c: Revert.
8735         * filename-seen-cache.h: Revert.
8736         * filename-seen-cache.c: Revert.
8737         * fbsd-tdep.c: Revert.
8738         * fbsd-nat.h: Revert.
8739         * fbsd-nat.c: Revert.
8740         * f-valprint.c: Revert.
8741         * f-typeprint.c: Revert.
8742         * f-lang.c: Revert.
8743         * extension.h: Revert.
8744         * extension.c: Revert.
8745         * extension-priv.h: Revert.
8746         * expprint.c: Revert.
8747         * exec.h: Revert.
8748         * exec.c: Revert.
8749         * exceptions.c: Revert.
8750         * event-top.c: Revert.
8751         * event-loop.c: Revert.
8752         * eval.c: Revert.
8753         * elfread.c: Revert.
8754         * dwarf2read.h: Revert.
8755         * dwarf2read.c: Revert.
8756         * dwarf2loc.c: Revert.
8757         * dwarf2expr.h: Revert.
8758         * dwarf2expr.c: Revert.
8759         * dwarf2-frame.c: Revert.
8760         * dwarf2-frame-tailcall.c: Revert.
8761         * dwarf-index-write.h: Revert.
8762         * dwarf-index-write.c: Revert.
8763         * dwarf-index-common.c: Revert.
8764         * dwarf-index-cache.h: Revert.
8765         * dwarf-index-cache.c: Revert.
8766         * dummy-frame.c: Revert.
8767         * dtrace-probe.c: Revert.
8768         * disasm.h: Revert.
8769         * disasm.c: Revert.
8770         * disasm-selftests.c: Revert.
8771         * dictionary.c: Revert.
8772         * dicos-tdep.c: Revert.
8773         * demangle.c: Revert.
8774         * dcache.h: Revert.
8775         * dcache.c: Revert.
8776         * darwin-nat.h: Revert.
8777         * darwin-nat.c: Revert.
8778         * darwin-nat-info.c: Revert.
8779         * d-valprint.c: Revert.
8780         * d-namespace.c: Revert.
8781         * d-lang.c: Revert.
8782         * ctf.c: Revert.
8783         * csky-tdep.c: Revert.
8784         * csky-linux-tdep.c: Revert.
8785         * cris-tdep.c: Revert.
8786         * cris-linux-tdep.c: Revert.
8787         * cp-valprint.c: Revert.
8788         * cp-support.c: Revert.
8789         * cp-namespace.c: Revert.
8790         * cp-abi.c: Revert.
8791         * corelow.c: Revert.
8792         * corefile.c: Revert.
8793         * continuations.c: Revert.
8794         * completer.h: Revert.
8795         * completer.c: Revert.
8796         * complaints.c: Revert.
8797         * coffread.c: Revert.
8798         * coff-pe-read.c: Revert.
8799         * cli-out.h: Revert.
8800         * cli-out.c: Revert.
8801         * charset.c: Revert.
8802         * c-varobj.c: Revert.
8803         * c-valprint.c: Revert.
8804         * c-typeprint.c: Revert.
8805         * c-lang.c: Revert.
8806         * buildsym.c: Revert.
8807         * buildsym-legacy.c: Revert.
8808         * build-id.h: Revert.
8809         * build-id.c: Revert.
8810         * btrace.c: Revert.
8811         * bsd-uthread.c: Revert.
8812         * breakpoint.h: Revert.
8813         * breakpoint.c: Revert.
8814         * break-catch-throw.c: Revert.
8815         * break-catch-syscall.c: Revert.
8816         * break-catch-sig.c: Revert.
8817         * blockframe.c: Revert.
8818         * block.c: Revert.
8819         * bfin-tdep.c: Revert.
8820         * bfin-linux-tdep.c: Revert.
8821         * bfd-target.c: Revert.
8822         * bcache.c: Revert.
8823         * ax-general.c: Revert.
8824         * ax-gdb.h: Revert.
8825         * ax-gdb.c: Revert.
8826         * avr-tdep.c: Revert.
8827         * auxv.c: Revert.
8828         * auto-load.c: Revert.
8829         * arm-wince-tdep.c: Revert.
8830         * arm-tdep.c: Revert.
8831         * arm-symbian-tdep.c: Revert.
8832         * arm-pikeos-tdep.c: Revert.
8833         * arm-obsd-tdep.c: Revert.
8834         * arm-nbsd-tdep.c: Revert.
8835         * arm-nbsd-nat.c: Revert.
8836         * arm-linux-tdep.c: Revert.
8837         * arm-linux-nat.c: Revert.
8838         * arm-fbsd-tdep.c: Revert.
8839         * arm-fbsd-nat.c: Revert.
8840         * arm-bsd-tdep.c: Revert.
8841         * arch-utils.c: Revert.
8842         * arc-tdep.c: Revert.
8843         * arc-newlib-tdep.c: Revert.
8844         * annotate.h: Revert.
8845         * annotate.c: Revert.
8846         * amd64-windows-tdep.c: Revert.
8847         * amd64-windows-nat.c: Revert.
8848         * amd64-tdep.c: Revert.
8849         * amd64-sol2-tdep.c: Revert.
8850         * amd64-obsd-tdep.c: Revert.
8851         * amd64-obsd-nat.c: Revert.
8852         * amd64-nbsd-tdep.c: Revert.
8853         * amd64-nbsd-nat.c: Revert.
8854         * amd64-nat.c: Revert.
8855         * amd64-linux-tdep.c: Revert.
8856         * amd64-linux-nat.c: Revert.
8857         * amd64-fbsd-tdep.c: Revert.
8858         * amd64-fbsd-nat.c: Revert.
8859         * amd64-dicos-tdep.c: Revert.
8860         * amd64-darwin-tdep.c: Revert.
8861         * amd64-bsd-nat.c: Revert.
8862         * alpha-tdep.c: Revert.
8863         * alpha-obsd-tdep.c: Revert.
8864         * alpha-nbsd-tdep.c: Revert.
8865         * alpha-mdebug-tdep.c: Revert.
8866         * alpha-linux-tdep.c: Revert.
8867         * alpha-linux-nat.c: Revert.
8868         * alpha-bsd-tdep.c: Revert.
8869         * alpha-bsd-nat.c: Revert.
8870         * aix-thread.c: Revert.
8871         * agent.c: Revert.
8872         * addrmap.c: Revert.
8873         * ada-varobj.c: Revert.
8874         * ada-valprint.c: Revert.
8875         * ada-typeprint.c: Revert.
8876         * ada-tasks.c: Revert.
8877         * ada-lang.c: Revert.
8878         * aarch64-tdep.c: Revert.
8879         * aarch64-ravenscar-thread.c: Revert.
8880         * aarch64-newlib-tdep.c: Revert.
8881         * aarch64-linux-tdep.c: Revert.
8882         * aarch64-linux-nat.c: Revert.
8883         * aarch64-fbsd-tdep.c: Revert.
8884         * aarch64-fbsd-nat.c: Revert.
8885         * aarch32-linux-nat.c: Revert.
8886
8887 2019-04-05  Tom Tromey  <tom@tromey.com>
8888
8889         * ft32-tdep.c: Sort headers.
8890         * frv-tdep.c: Sort headers.
8891         * frv-linux-tdep.c: Sort headers.
8892         * frame.c: Sort headers.
8893         * frame-unwind.c: Sort headers.
8894         * frame-base.c: Sort headers.
8895         * fork-child.c: Sort headers.
8896         * findvar.c: Sort headers.
8897         * findcmd.c: Sort headers.
8898         * filesystem.c: Sort headers.
8899         * filename-seen-cache.h: Sort headers.
8900         * filename-seen-cache.c: Sort headers.
8901         * fbsd-tdep.c: Sort headers.
8902         * fbsd-nat.h: Sort headers.
8903         * fbsd-nat.c: Sort headers.
8904         * f-valprint.c: Sort headers.
8905         * f-typeprint.c: Sort headers.
8906         * f-lang.c: Sort headers.
8907         * extension.h: Sort headers.
8908         * extension.c: Sort headers.
8909         * extension-priv.h: Sort headers.
8910         * expprint.c: Sort headers.
8911         * exec.h: Sort headers.
8912         * exec.c: Sort headers.
8913         * exceptions.c: Sort headers.
8914         * event-top.c: Sort headers.
8915         * event-loop.c: Sort headers.
8916         * eval.c: Sort headers.
8917         * elfread.c: Sort headers.
8918         * dwarf2read.h: Sort headers.
8919         * dwarf2read.c: Sort headers.
8920         * dwarf2loc.c: Sort headers.
8921         * dwarf2expr.h: Sort headers.
8922         * dwarf2expr.c: Sort headers.
8923         * dwarf2-frame.c: Sort headers.
8924         * dwarf2-frame-tailcall.c: Sort headers.
8925         * dwarf-index-write.h: Sort headers.
8926         * dwarf-index-write.c: Sort headers.
8927         * dwarf-index-common.c: Sort headers.
8928         * dwarf-index-cache.h: Sort headers.
8929         * dwarf-index-cache.c: Sort headers.
8930         * dummy-frame.c: Sort headers.
8931         * dtrace-probe.c: Sort headers.
8932         * disasm.h: Sort headers.
8933         * disasm.c: Sort headers.
8934         * disasm-selftests.c: Sort headers.
8935         * dictionary.c: Sort headers.
8936         * dicos-tdep.c: Sort headers.
8937         * demangle.c: Sort headers.
8938         * dcache.h: Sort headers.
8939         * dcache.c: Sort headers.
8940         * darwin-nat.h: Sort headers.
8941         * darwin-nat.c: Sort headers.
8942         * darwin-nat-info.c: Sort headers.
8943         * d-valprint.c: Sort headers.
8944         * d-namespace.c: Sort headers.
8945         * d-lang.c: Sort headers.
8946         * ctf.c: Sort headers.
8947         * csky-tdep.c: Sort headers.
8948         * csky-linux-tdep.c: Sort headers.
8949         * cris-tdep.c: Sort headers.
8950         * cris-linux-tdep.c: Sort headers.
8951         * cp-valprint.c: Sort headers.
8952         * cp-support.c: Sort headers.
8953         * cp-namespace.c: Sort headers.
8954         * cp-abi.c: Sort headers.
8955         * corelow.c: Sort headers.
8956         * corefile.c: Sort headers.
8957         * continuations.c: Sort headers.
8958         * completer.h: Sort headers.
8959         * completer.c: Sort headers.
8960         * complaints.c: Sort headers.
8961         * coffread.c: Sort headers.
8962         * coff-pe-read.c: Sort headers.
8963         * cli-out.h: Sort headers.
8964         * cli-out.c: Sort headers.
8965         * charset.c: Sort headers.
8966         * c-varobj.c: Sort headers.
8967         * c-valprint.c: Sort headers.
8968         * c-typeprint.c: Sort headers.
8969         * c-lang.c: Sort headers.
8970         * buildsym.c: Sort headers.
8971         * buildsym-legacy.c: Sort headers.
8972         * build-id.h: Sort headers.
8973         * build-id.c: Sort headers.
8974         * btrace.c: Sort headers.
8975         * bsd-uthread.c: Sort headers.
8976         * breakpoint.h: Sort headers.
8977         * breakpoint.c: Sort headers.
8978         * break-catch-throw.c: Sort headers.
8979         * break-catch-syscall.c: Sort headers.
8980         * break-catch-sig.c: Sort headers.
8981         * blockframe.c: Sort headers.
8982         * block.c: Sort headers.
8983         * bfin-tdep.c: Sort headers.
8984         * bfin-linux-tdep.c: Sort headers.
8985         * bfd-target.c: Sort headers.
8986         * bcache.c: Sort headers.
8987         * ax-general.c: Sort headers.
8988         * ax-gdb.h: Sort headers.
8989         * ax-gdb.c: Sort headers.
8990         * avr-tdep.c: Sort headers.
8991         * auxv.c: Sort headers.
8992         * auto-load.c: Sort headers.
8993         * arm-wince-tdep.c: Sort headers.
8994         * arm-tdep.c: Sort headers.
8995         * arm-symbian-tdep.c: Sort headers.
8996         * arm-pikeos-tdep.c: Sort headers.
8997         * arm-obsd-tdep.c: Sort headers.
8998         * arm-nbsd-tdep.c: Sort headers.
8999         * arm-nbsd-nat.c: Sort headers.
9000         * arm-linux-tdep.c: Sort headers.
9001         * arm-linux-nat.c: Sort headers.
9002         * arm-fbsd-tdep.c: Sort headers.
9003         * arm-fbsd-nat.c: Sort headers.
9004         * arm-bsd-tdep.c: Sort headers.
9005         * arch-utils.c: Sort headers.
9006         * arc-tdep.c: Sort headers.
9007         * arc-newlib-tdep.c: Sort headers.
9008         * annotate.h: Sort headers.
9009         * annotate.c: Sort headers.
9010         * amd64-windows-tdep.c: Sort headers.
9011         * amd64-windows-nat.c: Sort headers.
9012         * amd64-tdep.c: Sort headers.
9013         * amd64-sol2-tdep.c: Sort headers.
9014         * amd64-obsd-tdep.c: Sort headers.
9015         * amd64-obsd-nat.c: Sort headers.
9016         * amd64-nbsd-tdep.c: Sort headers.
9017         * amd64-nbsd-nat.c: Sort headers.
9018         * amd64-nat.c: Sort headers.
9019         * amd64-linux-tdep.c: Sort headers.
9020         * amd64-linux-nat.c: Sort headers.
9021         * amd64-fbsd-tdep.c: Sort headers.
9022         * amd64-fbsd-nat.c: Sort headers.
9023         * amd64-dicos-tdep.c: Sort headers.
9024         * amd64-darwin-tdep.c: Sort headers.
9025         * amd64-bsd-nat.c: Sort headers.
9026         * alpha-tdep.c: Sort headers.
9027         * alpha-obsd-tdep.c: Sort headers.
9028         * alpha-nbsd-tdep.c: Sort headers.
9029         * alpha-mdebug-tdep.c: Sort headers.
9030         * alpha-linux-tdep.c: Sort headers.
9031         * alpha-linux-nat.c: Sort headers.
9032         * alpha-bsd-tdep.c: Sort headers.
9033         * alpha-bsd-nat.c: Sort headers.
9034         * aix-thread.c: Sort headers.
9035         * agent.c: Sort headers.
9036         * addrmap.c: Sort headers.
9037         * ada-varobj.c: Sort headers.
9038         * ada-valprint.c: Sort headers.
9039         * ada-typeprint.c: Sort headers.
9040         * ada-tasks.c: Sort headers.
9041         * ada-lang.c: Sort headers.
9042         * aarch64-tdep.c: Sort headers.
9043         * aarch64-ravenscar-thread.c: Sort headers.
9044         * aarch64-newlib-tdep.c: Sort headers.
9045         * aarch64-linux-tdep.c: Sort headers.
9046         * aarch64-linux-nat.c: Sort headers.
9047         * aarch64-fbsd-tdep.c: Sort headers.
9048         * aarch64-fbsd-nat.c: Sort headers.
9049         * aarch32-linux-nat.c: Sort headers.
9050
9051 2019-04-04  Tom Tromey  <tom@tromey.com>
9052
9053         * varobj.c (varobj_create): Update.
9054         * rust-exp.y (struct rust_parser) <update_innermost_block,
9055         lookup_symbol>: New methods.
9056         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9057         Rename.
9058         (rust_parser::rust_lookup_type)
9059         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9060         * printcmd.c (display_command, do_one_display): Update.
9061         * parser-defs.h (struct parser_state) <parser_state>: Add
9062         "tracker" parameter.
9063         (block_tracker): New member.
9064         (class innermost_block_tracker) <innermost_block_tracker>: Add
9065         "types" parameter.
9066         <reset>: Remove method.
9067         (innermost_block): Don't declare.
9068         (null_post_parser): Update.
9069         * parse.c (innermost_block): Remove global.
9070         (write_dollar_variable): Update.
9071         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9072         Remove "tracker_types" parameter.
9073         (parse_expression): Add "tracker" parameter.
9074         (parse_expression_for_completion): Update.
9075         (null_post_parser): Add "tracker" parameter.
9076         * p-exp.y: Update rules.
9077         * m2-exp.y: Update rules.
9078         * language.h (struct language_defn) <la_post_parser>: Add
9079         "tracker" parameter.
9080         * go-exp.y: Update rules.
9081         * f-exp.y: Update rules.
9082         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9083         parameter.
9084         * d-exp.y: Update rules.
9085         * c-exp.y: Update rules.
9086         * breakpoint.c (set_breakpoint_condition): Create an
9087         innermost_block_tracker.
9088         (watch_command_1): Likewise.
9089         * ada-lang.c (resolve): Add "tracker" parameter.
9090         (resolve_subexp): Likewise.
9091         * ada-exp.y (write_var_from_sym): Update.
9092
9093 2019-04-04  Tom Tromey  <tom@tromey.com>
9094
9095         * type-stack.h: New file.
9096         * type-stack.c: New file.
9097         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9098         type-stack.h.
9099         (insert_into_type_stack, insert_type, push_type, push_type_int)
9100         (insert_type_address_space, pop_type, pop_type_int)
9101         (pop_typelist, pop_type_stack, append_type_stack)
9102         (push_type_stack, get_type_stack, push_typelist)
9103         (follow_type_instance_flags, follow_types): Don't declare.
9104         * parse.c (type_stack): Remove global.
9105         (parse_exp_in_context): Update.
9106         (insert_into_type_stack, insert_type, push_type, push_type_int)
9107         (insert_type_address_space, pop_type, pop_type_int)
9108         (pop_typelist, pop_type_stack, append_type_stack)
9109         (push_type_stack, get_type_stack, push_typelist)
9110         (follow_type_instance_flags, follow_types): Remove (moved to
9111         type-stack.c).
9112         * f-exp.y (type_stack): New global.
9113         Update rules.
9114         (push_kind_type, f_parse): Update.
9115         * d-exp.y (type_stack): New global.
9116         Update rules.
9117         (d_parse): Update.
9118         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9119         Update rules.
9120         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9121         (HFILES_NO_SRCDIR): Add type-stack.h.
9122
9123 2019-04-04  Tom Tromey  <tom@tromey.com>
9124
9125         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9126         (rust_parser::convert_ast_to_expression, rust_parse)
9127         (rust_lex_test_completion, rust_lex_tests): Update.
9128         * parser-defs.h (struct expr_completion_state): New.
9129         (struct parser_state) <parser_state>: Add completion parameter.
9130         <mark_struct_expression, mark_completion_tag>: New methods.
9131         <parse_completion, m_completion_state>: New members.
9132         (prefixify_expression, null_post_parser): Update.
9133         (mark_struct_expression, mark_completion_tag): Don't declare.
9134         * parse.c (parse_completion, expout_last_struct)
9135         (expout_tag_completion_type, expout_completion_name): Remove
9136         globals.
9137         (parser_state::mark_struct_expression)
9138         (parser_state::mark_completion_tag): Now methods.
9139         (prefixify_expression): Add last_struct parameter.
9140         (prefixify_subexp): Likewise.
9141         (parse_exp_1): Update.
9142         (parse_exp_in_context): Add cstate parameter.  Update.
9143         (parse_expression_for_completion): Create an
9144         expr_completion_state.
9145         (null_post_parser): Add "completion" parameter.
9146         * p-exp.y: Update rules.
9147         (yylex): Update.
9148         * language.h (struct language_defn) <la_post_parser>: Add
9149         "completing" parameter.
9150         * go-exp.y: Update rules.
9151         (lex_one_token): Update.
9152         * expression.h (parse_completion): Don't declare.
9153         * d-exp.y: Update rules.
9154         (lex_one_token): Update rules.
9155         * c-exp.y: Update rules.
9156         (lex_one_token): Update.
9157         * ada-lang.c (resolve): Add "parse_completion" parameter.
9158         (resolve_subexp): Likewise.
9159         (ada_resolve_function): Likewise.
9160
9161 2019-04-04  Tom Tromey  <tom@tromey.com>
9162
9163         * parser-defs.h (struct parser_state) <start_arglist,
9164         end_arglist>: New methods.
9165         <arglist_len, m_funcall_chain>: New members.
9166         (arglist_len, start_arglist, end_arglist): Don't declare.
9167         * parse.c (arglist_len, funcall_chain): Remove global.
9168         (start_arglist, end_arglist): Remove functions.
9169         (parse_exp_in_context): Update.
9170         * p-exp.y: Update rules.
9171         * m2-exp.y: Update rules.
9172         * go-exp.y: Update rules.
9173         * f-exp.y: Update rules.
9174         * d-exp.y: Update rules.
9175         * c-exp.y: Update rules.
9176
9177 2019-04-04  Tom Tromey  <tom@tromey.com>
9178
9179         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9180         lex_operator, push_back>: New methods.
9181         Update all rules.
9182         (rust_parser::lex_hex, lex_escape): Rename and update.
9183         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9184         (rust_parser::lex_operator): Rename and update.
9185         (rust_parser::lex_number, rustyylex, rustyyerror)
9186         (rust_lex_test_init, rust_lex_test_sequence)
9187         (rust_lex_test_push_back, rust_lex_tests): Update.
9188         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9189         parameter.
9190         <lexptr, prev_lexptr>: New members.
9191         (lexptr, prev_lexptr): Don't declare.
9192         * parse.c (lexptr, prev_lexptr): Remove globals.
9193         (parse_exp_in_context): Update.
9194         * p-exp.y (yylex, yyerror): Update.
9195         * m2-exp.y (parse_number, yylex, yyerror): Update.
9196         * go-exp.y (lex_one_token, yyerror): Update.
9197         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9198         * d-exp.y (lex_one_token, yyerror): Update.
9199         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9200         (lex_one_token, yyerror): Update.
9201         * ada-lex.l (YY_INPUT): Update.
9202         (rewind_to_char): Update.
9203         * ada-exp.y (yyerror): Update.
9204
9205 2019-04-04  Tom Tromey  <tom@tromey.com>
9206
9207         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9208         * parser-defs.h (struct parser_state) <parser_state>: Add new
9209         parameter.
9210         <comma_terminates>: New member.
9211         (comma_terminates): Don't declare global.
9212         * parse.c (comma_terminates): Remove global.
9213         (parse_exp_in_context): Update.
9214         * p-exp.y (yylex): Update.
9215         * m2-exp.y (yylex): Update.
9216         * go-exp.y (lex_one_token): Update.
9217         * f-exp.y (yylex): Update.
9218         * d-exp.y (lex_one_token): Update.
9219         * c-exp.y (lex_one_token): Update.
9220         * ada-lex.l: Update.
9221
9222 2019-04-04  Tom Tromey  <tom@tromey.com>
9223
9224         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9225         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9226         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9227         * parser-defs.h (paren_depth): Don't declare.
9228         * parse.c (paren_depth): Remove global.
9229         (parse_exp_in_context): Update.
9230         * p-exp.y (paren_depth): New global.
9231         (pascal_parse): Initialize it.
9232         * m2-exp.y (paren_depth): New global.
9233         (m2_parse): Initialize it.
9234         * go-exp.y (paren_depth): New global.
9235         (go_parse): Initialize it.
9236         * f-exp.y (paren_depth): New global.
9237         (f_parse): Initialize it.
9238         * d-exp.y (paren_depth): New global.
9239         (d_parse): Initialize it.
9240         * c-exp.y (paren_depth): New global.
9241         (c_parse): Initialize it.
9242         * ada-lex.l (paren_depth): New global.
9243         (lexer_init): Initialize it.
9244
9245 2019-04-04  Tom Tromey  <tom@tromey.com>
9246
9247         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9248         (rust_parser::convert_ast_to_type)
9249         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9250         * parser-defs.h (struct parser_state) <parser_state>: Add
9251         parameters.  Initialize new members.
9252         <expression_context_block, expression_context_pc>: New members.
9253         * parse.c (expression_context_block, expression_context_pc):
9254         Remove globals.
9255         (parse_exp_in_context): Update.
9256         * p-exp.y: Update all rules.
9257         (yylex): Update.
9258         * m2-exp.y: Update all rules.
9259         (yylex): Update.
9260         * go-exp.y (yylex): Update.
9261         * f-exp.y (yylex): Update.
9262         * d-exp.y: Update all rules.
9263         (yylex): Update.
9264         * c-exp.y: Update all rules.
9265         (lex_one_token, classify_name, yylex, c_parse): Update.
9266         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9267
9268 2019-04-04  Tom Tromey  <tom@tromey.com>
9269
9270         * gdbarch.h, gdbarch.c: Rebuild.
9271         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9272         * stap-probe.h:
9273         (struct stap_parse_info): Replace "parser_state" with
9274         "expr_builder".
9275         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9276         (parser_state): New class.
9277         * parse.c (expr_builder): Rename.
9278         (expr_builder::release): Rename.
9279         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9280         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9281         (write_exp_elt_longcst, write_exp_elt_floatcst)
9282         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9283         (write_exp_string_vector, write_exp_bitstring)
9284         (write_exp_msymbol, mark_struct_expression)
9285         (write_dollar_variable)
9286         (insert_type_address_space, increase_expout_size): Replace
9287         "parser_state" with "expr_builder".
9288         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9289         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9290         "parser_state" with "expr_builder".
9291
9292 2019-04-04  Tom Tromey  <tom@tromey.com>
9293
9294         * rust-exp.y: Replace "parse_language" with method call.
9295         * p-exp.y:
9296         (yylex): Replace "parse_language" with method call.
9297         * m2-exp.y:
9298         (yylex): Replace "parse_language" with method call.
9299         * go-exp.y (classify_name): Replace "parse_language" with method
9300         call.
9301         * f-exp.y (yylex): Replace "parse_language" with method call.
9302         * d-exp.y (lex_one_token): Replace "parse_language" with method
9303         call.
9304         * c-exp.y:
9305         (lex_one_token, classify_name, yylex): Replace "parse_language"
9306         with method call.
9307         * ada-exp.y (find_primitive_type, type_char)
9308         (type_system_address): Replace "parse_language" with method call.
9309
9310 2019-04-04  Tom Tromey  <tom@tromey.com>
9311
9312         * rust-exp.y: Replace "parse_gdbarch" with method call.
9313         * parse.c (write_dollar_variable, insert_type_address_space):
9314         Replace "parse_gdbarch" with method call.
9315         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9316         call.
9317         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9318         call.
9319         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9320         "parse_gdbarch" with method call.
9321         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9322         with method call.
9323         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9324         "parse_gdbarch" with method call.
9325         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9326         "parse_gdbarch" with method call.
9327         * c-exp.y (parse_type, parse_number, classify_name): Replace
9328         "parse_gdbarch" with method call.
9329         * ada-lex.l: Replace "parse_gdbarch" with method call.
9330         * ada-exp.y (parse_type, find_primitive_type, type_char)
9331         (type_system_address): Replace "parse_gdbarch" with method call.
9332
9333 2019-04-04  Tom Tromey  <tom@tromey.com>
9334
9335         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9336         * stap-probe.c (stap_parse_argument): Update.
9337         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9338         initial_size parameter.
9339         * rust-exp.y (rust_lex_tests): Update.
9340         * parse.c (parser_state): Update.
9341         (parse_exp_in_context): Update.
9342         * parser-defs.h (struct parser_state) <parser_state>: Remove
9343         "initial_size" parameter.
9344
9345 2019-04-04  Tom Tromey  <tom@tromey.com>
9346
9347         * parser-defs.h (increase_expout_size): Don't declare.
9348         * parse.c (increase_expout_size): Now static.
9349
9350 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9351
9352         * gnu-nat.c (gnu_nat_target::wait): Fix
9353         target_waitstatus_to_string call.
9354
9355 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * eval.c (evaluate_subexp_standard): Handle internal functions
9358         during Fortran function call handling.
9359
9360 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * NEWS: Mention new internal functions.
9363         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9364         (read_base_type): Use dwarf2_init_complex_target_type.
9365         * value.c (creal_internal_fn): New function.
9366         (cimag_internal_fn): New function.
9367         (_initialize_values): Register new internal functions.
9368
9369 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9370
9371         * infrun.c (stop_all_threads): If debug_infrun, always
9372         trace the wait status after wait_one, using
9373         target_waitstatus_to_string and target_pid_to_str.
9374         (handle_inferior_event): Replace various trace of
9375         wait status kind by a single trace.
9376         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9377         wait status kind image by target_waitstatus_to_string.
9378         * target/waitstatus.c (target_waitstatus_to_string): Fix
9379         obsolete comment.
9380
9381 2019-04-01  Tom Tromey  <tromey@adacore.com>
9382
9383         PR symtab/23331:
9384         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9385
9386 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9387             Pedro Alves  <palves@redhat.com>
9388
9389         * top.c (quit_force): Call 'finalize_values'.
9390         * value.c (finalize_values): New function.
9391         * value.h (finalize_values): Declare.
9392
9393 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9394
9395         * NEWS: Announce $_gdb_major and $_gdb_minor.
9396
9397         * top.c (init_gdb_version_vars): New function.
9398         (gdb_init): Call init_gdb_version_vars.
9399
9400 2019-03-29  Tom Tromey  <tromey@adacore.com>
9401
9402         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9403         help text.  Remove dead code.
9404
9405 2019-03-29  Keith Seitz  <keiths@redhat.com>
9406
9407         From Siddhesh Poyarekar:
9408         * f-lang.h (f77_get_upperbound): Return LONGEST.
9409         (f77_get_lowerbound): Likewise.
9410         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9411         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9412         print them.
9413         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9414         plongest to format print it.
9415         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9416         (f77_get_upperbound): Likewise.
9417         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9418         LOWER_BOUND to LONGEST.
9419         (f77_create_arrayprint_offset_tbl): Likewise.
9420
9421 2019-03-29  Keith Seitz  <keiths@redhat.com>
9422
9423         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9424         %s/pulongest for TYPE_LENGTH instead of %d in format
9425         strings.
9426         * ada-typerint.c (ada_print_type): Likewise.
9427         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9428         * compile/compile-c-support.c (generate_register_struct): Likewise.
9429         * gdbtypes.c (recursive_dump_type): Likewise.
9430         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9431         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9432         instead of %d in format strings.
9433         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9434         to std::min to ULONGEST.
9435         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9436         instead of %d in format strings.
9437         * tracepoint.c (info_scope_command): Likewise.
9438         * typeprint.c (print_offset_data::update)
9439         (print_offset_data::finish): Likewise.
9440         * xtensa-tdep.c (xtensa_store_return_value)
9441         (xtensa_push_dummy_call): Likewise.
9442
9443 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9444
9445         * windows-nat.c (display_selector): Fixed format specifications
9446         for 64-bit Cygwin.
9447
9448 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9449
9450         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9451
9452 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9453
9454         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9455         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9456         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9457         (nios2_linux_init_abi): Install it.
9458
9459 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9460
9461         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9462
9463 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9464
9465         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9466
9467 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9468             Tom Tromey  <tromey@adacore.com>
9469
9470         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9471
9472 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9473
9474         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9475         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9476         method to compute the bounds of range types. Also print "[evaluated]"
9477         if the bounds' values come from a dynamic evaluation.
9478
9479 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9482         whitespace when pretty printing is on.
9483
9484 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9485
9486         * ppc-linux-nat.c: Add include.
9487
9488 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9489
9490         * NEWS: Mention AArch64 Pointer Authentication.
9491
9492 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9493
9494         * arm-linux-nat.c: Add include.
9495
9496 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9497
9498         * source-cache.c (source_cache::get_source_lines): Re-read
9499         fullname after calling open_source_file.
9500
9501 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9502
9503         * NEWS: Mention TLS support for FreeBSD.
9504
9505 2019-03-25  Tom Tromey  <tromey@adacore.com>
9506
9507         * minsyms.c (BUNCH_SIZE): Update comment.
9508         (~minimal_symbol_reader): Remove old comment.
9509         (compact_minimal_symbols): Update comment.
9510         (minimal_symbol_reader::install): Remove old comment.  Update
9511         other comments.
9512
9513 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9514
9515         * s390-linux-nat.c: Add include.
9516
9517 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9518
9519         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9520         Call linux_get_hwcap.
9521         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9522         Likewise.
9523         (aarch64_linux_get_hwcap): Remove function.
9524         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9525         declaration.
9526         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9527         linux_get_hwcap.
9528         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9529         * linux-tdep.c (linux_get_hwcap): Add function.
9530         (linux_get_hwcap2): Likewise.
9531         * linux-tdep.h (linux_get_hwcap): Add declaration.
9532         (linux_get_hwcap2): Likewise.
9533         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9534         (ppc_linux_get_hwcap2): Likewise.
9535         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9536         linux_get_hwcap.
9537         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9538         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9539         (ppc_linux_nat_target::read_description): Likewise.
9540         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9541         * s390-linux-nat.c: Likewise.
9542         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9543
9544 2019-03-24  Tom Tromey  <tom@tromey.com>
9545
9546         * ada-lang.c (standard_lookup): Simplify initialization.
9547         (ada_lookup_symbol_nonlocal): Simplify return.
9548         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9549         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9550         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9551         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9552         initialization.
9553         * solib.c (solib_global_lookup): Simplify.
9554         * symtab.c (null_block_symbol): Remove.
9555         (symbol_cache_lookup): Simplify returns.
9556         (lookup_language_this): Simplify returns.
9557         (lookup_symbol_aux): Simplify return.
9558         (lookup_local_symbol): Simplify returns.
9559         (lookup_global_symbol_from_objfile): Simplify return.
9560         (lookup_symbol_in_objfile_symtabs)
9561         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9562         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9563         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9564         * cp-namespace.c (cp_lookup_bare_symbol)
9565         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9566         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9567         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9568         (cp_lookup_symbol_via_imports): Simplify initialization.
9569         (find_symbol_in_baseclass): Likewise.
9570         * symtab.h (null_block_symbol): Remove.
9571         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9572         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9573         (d_lookup_symbol_module): Likewise.
9574         (find_symbol_in_baseclass): Simplify initialization.
9575
9576 2019-03-24  Tom Tromey  <tom@tromey.com>
9577
9578         * expression.h: Don't include symtab.h.
9579         (struct block): Forward declare.
9580
9581 2019-03-24  Tom Tromey  <tom@tromey.com>
9582
9583         * c-exp.y (typebase): Remove casts.
9584         * gdbtypes.c (lookup_unsigned_typename, )
9585         (lookup_signed_typename): Remove cast.
9586         * eval.c (parse_to_comma_and_eval): Remove cast.
9587         * parse.c (write_dollar_variable): Remove cast.
9588         * block.h (struct block) <superblock>: Now const.
9589         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9590         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9591         (map_block): Make "block" const.
9592         * symfile.h (struct quick_symbol_functions)
9593         <map_matching_symbols>: Constify block argument to "callback".
9594         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9595         const.
9596         (find_pc_sect_compunit_symtab): Make "b" const.
9597         (find_symbol_at_address): Likewise.
9598         (search_symbols): Likewise.
9599         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9600         (dw2_debug_names_lookup_symbol): Likewise.
9601         (dw2_map_matching_symbols): Update.
9602         * p-valprint.c (pascal_val_print): Remove "block".
9603         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9604         (aux_add_nonlocal_symbols): Make "block" const.
9605         (resolve_subexp): Remove cast.
9606         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9607         const.
9608         (iterate_over_file_blocks): Likewise.
9609         * f-exp.y (%union) <bval>: Remove.
9610         * coffread.c (patch_opaque_types): Make "b" const.
9611         * spu-tdep.c (spu_catch_start): Make "block" const.
9612         * c-valprint.c (print_unpacked_pointer): Remove "block".
9613         * symmisc.c (dump_symtab_1): Make "b" const.
9614         (block_depth): Make "block" const.
9615         * d-exp.y (%union) <bval>: Remove.
9616         * cp-support.h (cp_lookup_rtti_type): Update.
9617         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9618         * psymtab.c (psym_lookup_symbol): Make "block" const.
9619         (maintenance_check_psymtabs): Make "b" const.
9620         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9621         (enumerate_locals, enumerate_args): Update.
9622         * python/py-symtab.c (stpy_global_block): Make "block" const.
9623         (stpy_static_block): Likewise.
9624         * inline-frame.c (block_starting_point_at): Make "new_block"
9625         const.
9626         * block.c (find_block_in_blockvector): Make return type const.
9627         (blockvector_for_pc_sect): Make "b" const.
9628         (find_block_in_blockvector): Make "b" const.
9629
9630 2019-03-23  Tom Tromey  <tom@tromey.com>
9631
9632         * varobj.c (varobj_create): Update.
9633         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9634         * printcmd.c (display_command, do_one_display): Don't reset
9635         innermost_block.
9636         * parser-defs.h (enum innermost_block_tracker_type): Move to
9637         expression.h.
9638         (innermost_block): Update comment.
9639         * parse.c (parse_exp_1): Add tracker_types parameter.
9640         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9641         tracker_types parameter.  Reset innermost_block.
9642         (parse_exp_in_context): Remove.
9643         (parse_expression_for_completion): Update.
9644         * objfiles.c (~objfile): Don't reset expression_context_block or
9645         innermost_block.
9646         * expression.h (enum innermost_block_tracker_type): Move from
9647         parser-defs.h.
9648         (parse_exp_1): Add tracker_types parameter.
9649         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9650         reset innermost_block.
9651
9652 2019-03-23  Tom Tromey  <tom@tromey.com>
9653
9654         * objfiles.h: Include bcache.h.
9655
9656 2019-03-23  Tom Tromey  <tom@tromey.com>
9657
9658         * linespec.c (get_current_search_block): Use
9659         scoped_restore_current_language.
9660         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9661
9662 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9663             Jiong Wang  <jiong.wang@arm.com>
9664
9665         * aarch64-linux-tdep.c
9666         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9667         section.
9668         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9669
9670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9671             Jiong Wang  <jiong.wang@arm.com>
9672
9673         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9674         instructions.
9675         (aarch64_analyze_prologue_test): Add PACIASP test.
9676         (aarch64_prologue_prev_register): Unmask PC value.
9677
9678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9679             Jiong Wang  <jiong.wang@arm.com>
9680
9681         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9682         (aarch64_dwarf2_prev_register): Unmask PC value.
9683         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9684         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9685         DW_CFA_AARCH64_negate_ra_state.
9686         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9687
9688 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9689             Jiong Wang  <jiong.wang@arm.com>
9690
9691         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9692         registers.
9693         (aarch64_pseudo_register_name): Likewise.
9694         (aarch64_pseudo_register_type): Likewise.
9695         (aarch64_pseudo_register_reggroup_p): Likewise.
9696         (aarch64_gdbarch_init): Add pauth registers.
9697         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9698         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9699         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9700         (struct gdbarch_tdep): Add regnum for ra_state.
9701
9702 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9703             Jiong Wang  <jiong.wang@arm.com>
9704
9705         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9706
9707 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9708             Jiong Wang  <jiong.wang@arm.com>
9709
9710         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9711         function.
9712         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9713         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9714         (aarch64_gdbarch_init): Add puth registers.
9715         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9716         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9717         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9718
9719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9720             Jiong Wang  <jiong.wang@arm.com>
9721
9722         * aarch64-linux-nat.c
9723         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9724         * aarch64-linux-tdep.c
9725         (aarch64_linux_core_read_description): Likewise.
9726         (aarch64_linux_get_hwcap): New function.
9727         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9728         (aarch64_linux_get_hwcap): New declaration.
9729
9730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9731             Jiong Wang  <jiong.wang@arm.com>
9732
9733         * aarch64-linux-nat.c
9734         (aarch64_linux_nat_target::read_description): Add pauth param.
9735         * aarch64-linux-tdep.c
9736         (aarch64_linux_core_read_description): Likewise.
9737         * aarch64-tdep.c (struct target_desc): Add in pauth.
9738         (aarch64_read_description): Add pauth param.
9739         (aarch64_gdbarch_init): Likewise.
9740         * aarch64-tdep.h (aarch64_read_description): Likewise.
9741         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9742         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9743         * features/Makefile: Add new files.
9744         * features/aarch64-pauth.c: New file.
9745         * features/aarch64-pauth.xml: New file.
9746
9747 2019-03-20  Tom Tromey  <tromey@adacore.com>
9748
9749         * infrun.c (handle_inferior_event): Rename from
9750         handle_inferior_event_1.  Create a scoped_value_mark.
9751         (handle_inferior_event): Remove.
9752
9753 2019-03-19  Tom Tromey  <tromey@adacore.com>
9754
9755         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9756         * infrun.h (print_stop_event): Add "displays" parameter.
9757         * infrun.c (print_stop_event): Add "displays" parameter.
9758
9759 2019-03-19  Pedro Alves  <palves@redhat.com>
9760
9761         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9762         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9763         to -1.  Fix TABs vs spaces.
9764         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9765         * tui/tui-out.h (tui_ui_out) Add intro comments.
9766         <m_line, m_start_of_line>: In-class initialize, and add describing
9767         comment.
9768
9769 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9770
9771         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9772         variable names.
9773         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9774
9775 2019-03-18  Pedro Alves  <palves@redhat.com>
9776             Eli Zaretskii <eliz@gnu.org>
9777
9778         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9779         m_line and m_start_of_line.
9780
9781 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9782
9783         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9784         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9785         it returns a newline.  This fixes a regression in TU mode, whereby
9786         the next line is output on the same screen line as the user input.
9787
9788 2019-03-18  Tom Tromey  <tromey@adacore.com>
9789
9790         * minsyms.c (minimal_symbol_reader::install): Remove call to
9791         obstack_blank.
9792
9793 2019-03-18  Pedro Alves  <palves@redhat.com>
9794
9795         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9796         New globals.
9797         (apply_style): New, factored out from ...
9798         (apply_ansi_escape): ... this.  Handle reverse video mode.
9799         (tui_set_reverse_mode): New function.
9800         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9801         * tui/tui-winsource.c (tui_show_source_line): Use
9802         tui_set_reverse_mode instead of setting A_STANDOUT.
9803         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9804         New setter methods.
9805
9806 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9807
9808         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9809         Handle tabs.
9810
9811 2019-03-18  Tom Tromey  <tromey@adacore.com>
9812
9813         * ada-lang.c (empty_array): Add "high" parameter.
9814         (ada_evaluate_subexp): Update.
9815
9816 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9817
9818         * unittests/string_view-selftests.c: Define
9819         _initialize_string_view_selftests unconditionally.
9820
9821 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9822
9823         PR gdb/24350
9824         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9825
9826 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9827
9828         PR gdb/24351
9829         * windows-nat.c (display_selector): Fix format specifiers.
9830
9831 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9832
9833         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9834         tui_refill_source_window instead of tui_refresh_win, to update the
9835         current execution line.  This fixes redisplay of the current line
9836         when stepping through the code with "next" or "step".
9837
9838 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9839
9840         * source-cache.c (source_cache::get_source_lines): Call
9841         find_source_lines to initialize s->nlines.  This fixes vertical
9842         scrolling of TUI source window when the DOWN arrow is pressed.
9843
9844 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9845
9846         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9847         linux-thread-db.c (_initialize_thread_db): Likewise.
9848
9849 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9850
9851         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9852         wclrtoeol in tui_show_source_line".  This reverts changes made in
9853         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9854
9855 2019-03-15  Tom Tromey  <tom@tromey.com>
9856
9857         * symtab.h (struct minimal_symbol): Derive from
9858         general_symbol_info.
9859         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9860         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9861         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9862         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9863         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9864         (MSYMBOL_SEARCH_NAME): Update.
9865         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9866         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9867         * minsyms.c (minimal_symbol_reader::record_full): Update.
9868
9869 2019-03-15  Tom Tromey  <tom@tromey.com>
9870
9871         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9872
9873 2019-03-15  Tom Tromey  <tom@tromey.com>
9874
9875         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9876         unique_xmalloc_ptr.
9877         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9878         Update.
9879         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9880         (build_minimal_symbol_hash_tables)
9881         (minimal_symbol_reader::install): Update.
9882
9883 2019-03-15  Tom Tromey  <tom@tromey.com>
9884
9885         * symtab.c (create_demangled_names_hash): Update.
9886         (symbol_set_names): Update.
9887         * objfiles.h (struct objfile_per_bfd_storage)
9888         <demangled_names_hash>: Now an htab_up.
9889         * objfiles.c (objfile_per_bfd_storage): Simplify.
9890
9891 2019-03-15  Tom Tromey  <tom@tromey.com>
9892
9893         * objfiles.h (struct objfile_per_bfd_storage): Declare
9894         destructor.
9895         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9896         New.
9897         (get_objfile_bfd_data): Use new.  Don't initialize
9898         language_of_main.
9899         (free_objfile_per_bfd_storage): Remove.
9900         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9901
9902 2019-03-15  Tom Tromey  <tom@tromey.com>
9903
9904         * symfile.c (reread_symbols): Update.
9905         * objfiles.c (objfile::objfile): Update.
9906         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9907         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9908         comment.
9909         (minimal_symbol_reader::install): Update.
9910         (terminate_minimal_symbol_table): Remove.
9911         * jit.c (jit_object_close_impl): Update.
9912
9913 2019-03-15  Tom Tromey  <tom@tromey.com>
9914
9915         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9916         initializations.
9917
9918 2019-03-15  Tom Tromey  <tom@tromey.com>
9919
9920         * objfiles.h (struct objfile_per_bfd_storage)
9921         <demangled_hash_languages>: Now a bitset.
9922         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9923         (lookup_minimal_symbol): Update.
9924
9925 2019-03-15  Tom Tromey  <tom@tromey.com>
9926
9927         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9928         Don't return the symbol.
9929         * coffread.c (record_minimal_symbol): Use record_full.
9930
9931 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9932
9933         The MS-Windows port of ncurses fails to switch to a color pair if
9934         one or both of the colors are the implicit default colors.  This
9935         change records the default colors when TUI is initialized, and
9936         then specifies them explicitly when a color pair uses the default
9937         colors.  This allows color styling in TUI mode on MS-Windows.
9938
9939         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9940         ncurses_norm_attr.
9941         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9942         colors in ncurses_norm_attr.
9943         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9944         "none", replace it with the default color recorded in
9945         ncurses_norm_attr.
9946
9947 2019-03-14  Tom Tromey  <tromey@adacore.com>
9948
9949         * source-cache.h (class source_cache) <get_source_lines>: Return
9950         std::string.
9951         * source-cache.c (source_cache::extract_lines): Handle case where
9952         first_pos==npos.  Return std::string.
9953         (source_cache::get_source_lines): Update.
9954
9955 2019-03-14  Tom Tromey  <tromey@adacore.com>
9956
9957         * NEWS: Add item for "style sources" commands.
9958         * source-cache.c (source_cache::get_source_lines): Check
9959         source_styling.
9960         * cli/cli-style.c (source_styling): New global.
9961         (_initialize_cli_style): Add "style sources" commands.
9962         (show_style_sources): New function.
9963         * cli/cli-style.h (source_styling): Declare.
9964
9965 2019-03-14  Pedro Alves  <palves@redhat.com>
9966             Tom Tromey  <tromey@adacore.com>
9967
9968         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9969         * tui/tui-winsource.c (tui_refill_source_window): New function,
9970         from...
9971         (tui_horizontal_source_scroll): ... here.  Move some logic.
9972         * cli/cli-style.c (set_style_enabled): Notify new observable.
9973         * tui/tui-hooks.c (tui_redisplay_source): New function.
9974         (tui_attach_detach_observers): Attach or detach
9975         tui_redisplay_source.
9976         * observable.h (source_styling_changed): New observable.
9977         * observable.c: Define source_styling_changed observable.
9978
9979 2019-03-13  Tom Tromey  <tromey@adacore.com>
9980
9981         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9982         (i386_gnu_nat_target::store_registers): Update.
9983         * target-debug.h (target_debug_print_std_string): New macro.
9984         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9985         * windows-tdep.c (display_one_tib): Update.
9986         * tui/tui-stack.c (tui_make_status_line): Update.
9987         * top.c (print_inferior_quit_action): Update.
9988         * thread.c (thr_try_catch_cmd): Update.
9989         (add_thread_with_info): Update.
9990         (thread_target_id_str): Update.
9991         (thr_try_catch_cmd): Update.
9992         (thread_command): Update.
9993         (thread_find_command): Update.
9994         * record-btrace.c (record_btrace_target::info_record)
9995         (record_btrace_resume_thread, record_btrace_target::resume)
9996         (record_btrace_cancel_resume, record_btrace_step_thread)
9997         (record_btrace_target::wait, record_btrace_target::wait)
9998         (record_btrace_target::wait, record_btrace_target::stop): Update.
9999         * progspace.c (print_program_space): Update.
10000         * process-stratum-target.c
10001         (process_stratum_target::thread_address_space): Update.
10002         * linux-fork.c (linux_fork_mourn_inferior)
10003         (detach_checkpoint_command, info_checkpoints_command)
10004         (linux_fork_context): Update.
10005         (linux_fork_detach): Update.
10006         (class scoped_switch_fork_info): Update.
10007         (delete_checkpoint_command): Update.
10008         * infrun.c (follow_fork_inferior): Update.
10009         (follow_fork_inferior): Update.
10010         (proceed_after_vfork_done): Update.
10011         (handle_vfork_child_exec_or_exit): Update.
10012         (follow_exec): Update.
10013         (displaced_step_prepare_throw): Update.
10014         (displaced_step_restore): Update.
10015         (start_step_over): Update.
10016         (resume_1): Update.
10017         (clear_proceed_status_thread): Update.
10018         (proceed): Update.
10019         (print_target_wait_results): Update.
10020         (do_target_wait): Update.
10021         (context_switch): Update.
10022         (stop_all_threads): Update.
10023         (restart_threads): Update.
10024         (finish_step_over): Update.
10025         (handle_signal_stop): Update.
10026         (switch_back_to_stepped_thread): Update.
10027         (keep_going_pass_signal): Update.
10028         (print_exited_reason): Update.
10029         (normal_stop): Update.
10030         * inferior.c (inferior_pid_to_str): Change return type.
10031         (print_selected_inferior): Update.
10032         (add_inferior): Update.
10033         (detach_inferior): Update.
10034         * dummy-frame.c (fprint_dummy_frames): Update.
10035         * dcache.c (dcache_info_1): Update.
10036         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10037         (btrace_fetch, btrace_clear): Update.
10038         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10039         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10040         type.
10041         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10042         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10043         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10044         * gdbarch.c, gdbarch.h: Rebuild.
10045         * gdbarch.sh (core_pid_to_str): Change return type.
10046         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10047         return type.
10048         (windows_nat_target::pid_to_str): Change return type.
10049         (windows_delete_thread): Update.
10050         (windows_nat_target::attach): Update.
10051         (windows_nat_target::files_info): Update.
10052         * target-delegates.c: Rebuild.
10053         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10054         return type.
10055         (sol_thread_target::pid_to_str): Change return type.
10056         * remote.c (class remote_target) <pid_to_str>: Change return
10057         type.
10058         (remote_target::pid_to_str): Change return type.
10059         (extended_remote_target::attach, remote_target::remote_stop_ns)
10060         (remote_target::remote_notif_remove_queued_reply)
10061         (remote_target::push_stop_reply, remote_target::disable_btrace):
10062         Update.
10063         (extended_remote_target::attach): Update.
10064         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10065         type.
10066         (gdbsim_target::pid_to_str): Change return type.
10067         * ravenscar-thread.c (struct ravenscar_thread_target)
10068         <pid_to_str>: Change return type.
10069         (ravenscar_thread_target::pid_to_str): Change return type.
10070         * procfs.c (class procfs_target) <pid_to_str>: Change return
10071         type.
10072         (procfs_target::pid_to_str): Change return type.
10073         (procfs_target::attach): Update.
10074         (procfs_target::detach): Update.
10075         (procfs_target::fetch_registers): Update.
10076         (procfs_target::store_registers): Update.
10077         (procfs_target::wait): Update.
10078         (procfs_target::files_info): Update.
10079         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10080         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10081         return type.
10082         (nto_procfs_target::pid_to_str): Change return type.
10083         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10084         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10085         return type.
10086         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10087         (exit_lwp): Update.
10088         (attach_proc_task_lwp_callback, get_detach_signal)
10089         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10090         (linux_nat_target::resume, wait_lwp, stop_callback)
10091         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10092         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10093         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10094         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10095         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10096         type.
10097         (inf_ptrace_target::attach): Update.
10098         (inf_ptrace_target::files_info): Update.
10099         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10100         type.
10101         (go32_nat_target::pid_to_str): Change return type.
10102         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10103         (gnu_nat_target::wait): Update.
10104         (gnu_nat_target::wait): Update.
10105         (gnu_nat_target::resume): Update.
10106         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10107         (fbsd_nat_target::wait): Update.
10108         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10109         type.
10110         (darwin_nat_target::attach): Update.
10111         * corelow.c (class core_target) <pid_to_str>: Change return type.
10112         (core_target::pid_to_str): Change return type.
10113         * target.c (normal_pid_to_str): Change return type.
10114         (default_pid_to_str): Likewise.
10115         (target_pid_to_str): Change return type.
10116         (target_translate_tls_address): Update.
10117         (target_announce_detach): Update.
10118         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10119         return type.
10120         (bsd_uthread_target::pid_to_str): Change return type.
10121         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10122         type.
10123         (bsd_kvm_target::pid_to_str): Change return type.
10124         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10125         return type.
10126         (aix_thread_target::pid_to_str): Change return type.
10127         * target.h (struct target_ops) <pid_to_str>: Change return type.
10128         (target_pid_to_str, normal_pid_to_str): Likewise.
10129         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10130         type.
10131         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10132         type.
10133         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10134         return type.
10135         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10136         type.
10137         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10138         type.
10139         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10140         return type.
10141
10142 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10143
10144         * NEWS: Mention that the new default MI version is 3.  Mention
10145         changes to the output of commands and events that deal with
10146         multi-location breakpoints.
10147         * breakpoint.c: Include "mi/mi-out.h".
10148         (print_one_breakpoint): Change output syntax if using MI version
10149         >= 3.
10150         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10151         New.
10152         (mi_multi_location_breakpoint_output_fixed): New.
10153         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10154         (mi_cmd_fix_multi_location_breakpoint_output): New.
10155         (mi_multi_location_breakpoint_output_fixed): New.
10156         * mi/mi-cmds.c (mi_cmds): Register command
10157         -fix-multi-location-breakpoint-output.
10158         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10159         interpreter "mi".
10160
10161 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10162
10163         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10164         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10165         instantiate mi_ui_out based on interpreter name.
10166         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10167         * mi/mi-main.c (mi_load_progress): Likewise.
10168
10169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10170
10171         * NEWS: Combine separate "New targets" sections for 8.3.
10172
10173 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10174
10175         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10176         (ppcfbsd_init_abi): Install gdbarch
10177         "fetch_tls_load_module_address" and "get_thread_local_address"
10178         methods.
10179
10180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10181
10182         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10183         (riscv_fbsd_init_abi): Install gdbarch
10184         "fetch_tls_load_module_address" and "get_thread_local_address"
10185         methods.
10186
10187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10188
10189         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10190         (i386fbsd_init_abi): Install gdbarch
10191         "fetch_tls_load_module_address" and "get_thread_local_address"
10192         methods.
10193
10194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10195
10196         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10197         (amd64fbsd_init_abi): Install gdbarch
10198         "fetch_tls_load_module_address" and "get_thread_local_address"
10199         methods.
10200
10201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10202
10203         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10204         (struct fbsd_pspace_data): New type.
10205         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10206         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10207         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10208         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10209         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10210
10211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10212
10213         * gdbtypes.c (lookup_struct_elt): New function.
10214         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10215         * gdbtypes.h (struct struct_elt): New type.
10216         (lookup_struct_elt): New prototype.
10217
10218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10219
10220         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10221         remove disabled code block.
10222
10223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10224
10225         * gdbarch.sh (get_thread_local_address): New method.
10226         * gdbarch.h, gdbarch.c: Regenerate.
10227         * target.c (target_translate_tls_address): Use
10228         gdbarch_get_thread_local_address if present instead of
10229         target::get_thread_local_address.
10230
10231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10232
10233         * target.h (target::get_thread_local_address): Update comment.
10234
10235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10236
10237         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10238         objfile->separate_debug_objfile_backlink if not NULL.
10239
10240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10241
10242         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10243         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10244         (amd64bsd_store_inferior_registers): Likewise.
10245         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10246         Enable segment base registers.
10247         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10248         PT_GETFSBASE and PT_GETGSBASE.
10249         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10250         PT_SETGSBASE.
10251         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10252         segment base registers.
10253         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10254
10255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10256
10257         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10258         Update calls to i386_target_description to add 'segments'
10259         parameter.
10260         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10261         add segment base registers.
10262         * arch/i386.c (i386_create_target_description): Add 'segments'
10263         parameter to enable segment base registers.
10264         * arch/i386.h (i386_create_target_description): Likewise.
10265         * features/i386/32bit-segments.xml: New file.
10266         * features/i386/32bit-segments.c: Generate.
10267         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10268         call to i386_target_description to add 'segments' parameter.
10269         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10270         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10271         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10272         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10273         if feature is present.
10274         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10275         Add 'segments' parameter to call to i386_target_description.
10276         (i386_target_description): Add 'segments' parameter to enable
10277         segment base registers.
10278         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10279         to call to i386_target_description.
10280         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10281         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10282         Define I386_NUM_REGS.
10283         (i386_target_description): Add 'segments' parameter to enable
10284         segment base registers.
10285
10286 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10287
10288         PR/24325
10289         * source-cache.c: #undef open and close, to avoid unresolved
10290         externals during linking.
10291
10292 2019-03-12  Tom Tromey  <tromey@adacore.com>
10293
10294         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10295         const.  Add initializers.
10296         (_initialize_remote): Don't initialize ptid globals.
10297
10298 2019-03-12  Pedro Alves  <palves@redhat.com>
10299
10300         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10301
10302 2019-03-12  Pedro Alves  <palves@redhat.com>
10303
10304         * cp-name-parser.y (main): Remove unused 'len' variable.
10305
10306 2019-03-12  Tom Tromey  <tromey@adacore.com>
10307
10308         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10309         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10310
10311 2019-03-12  Tom Tromey  <tromey@adacore.com>
10312
10313         * linux-nat.c (iterate_over_lwps): Update.
10314         (stop_callback): Remove parameter.
10315         (stop_wait_callback, detach_callback, resume_set_callback)
10316         (select_singlestep_lwp_callback, set_ignore_sigint)
10317         (status_callback, resumed_callback, resume_clear_callback)
10318         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10319         data parameter.
10320         (linux_nat_target::detach, linux_nat_target::resume)
10321         (linux_stop_and_wait_all_lwps, select_event_lwp)
10322         (linux_nat_filter_event, linux_nat_wait_1)
10323         (linux_nat_target::kill, linux_nat_target::stop)
10324         (linux_nat_target::stop): Update.
10325         (linux_nat_resume_callback): Change type.
10326         (resume_stopped_resumed_lwps, count_events_callback)
10327         (select_event_lwp_callback): Likewise.
10328         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10329         * arm-linux-nat.c (struct update_registers_data): Remove.
10330         (update_registers_callback): Change type.
10331         (arm_linux_insert_hw_breakpoint1): Update.
10332         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10333         parameter.
10334         (x86_linux_dr_set_addr): Update.
10335         (x86_linux_dr_set_control): Update.
10336         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10337         (iterate_over_lwps): Use gdb::function_view.
10338         * nat/aarch64-linux-hw-point.c (struct
10339         aarch64_dr_update_callback_param): Remove.
10340         (debug_reg_change_callback): Change type.
10341         (aarch64_notify_debug_reg_change): Update.
10342         * s390-linux-nat.c (s390_refresh_per_info): Update.
10343
10344 2019-03-11  Tom Tromey  <tromey@adacore.com>
10345
10346         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10347         redundant assignment to "this_cu".
10348
10349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10350
10351         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10352
10353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10354
10355         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10356         from...
10357         (rank_one_type): ... this.
10358
10359 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10360
10361         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10362         from...
10363         (rank_one_type): ... this.
10364
10365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10366
10367         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10368         from...
10369         (rank_one_type): ... this.
10370
10371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10372
10373         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10374         from...
10375         (rank_one_type): ... this.
10376
10377 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10378
10379         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10380         from...
10381         (rank_one_type): ... this.
10382
10383 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10384
10385         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10386         from...
10387         (rank_one_type): ... this.
10388
10389 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10390
10391         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10392         from...
10393         (rank_one_type): ... this.
10394
10395 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10396
10397         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10398         from...
10399         (rank_one_type): ... this.
10400
10401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10402
10403         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10404         from...
10405         (rank_one_type): ... this.
10406
10407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10408
10409         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10410         from...
10411         (rank_one_type): ... this.
10412
10413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10414
10415         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10416         from...
10417         (rank_one_type): ... this.
10418
10419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10420
10421         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10422         from...
10423         (rank_one_type): ... this.
10424
10425 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10426
10427         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10428         inferior-events' shows the example events.
10429
10430 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10431
10432         Support styling on native MS-Windows console
10433
10434         PR/24315
10435         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10436         on MS-Windows if $TERM is not defined.
10437
10438         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10439
10440         * posix-hdep.c (gdb_console_fputs):
10441         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10442         functions.
10443         * ui-file.h (gdb_console_fputs): Add prototype.
10444
10445         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10446         back to fputs only if the former returns zero.
10447
10448 2019-03-07  Tom Tromey  <tom@tromey.com>
10449
10450         * symmisc.c (print_symbol_bcache_statistics): Update.
10451         (print_objfile_statistics): Update.
10452         * symfile.c (allocate_symtab): Update.
10453         * stabsread.c: Don't include bcache.h.
10454         * psymtab.h (struct psymbol_bcache): Don't declare.
10455         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10456         (psymbol_bcache_init, psymbol_bcache_free)
10457         (psymbol_bcache_get_bcache): Don't declare.
10458         * psymtab.c (struct psymbol_bcache): Remove.
10459         (psymtab_storage::psymtab_storage): Update.
10460         (psymtab_storage::~psymtab_storage): Update.
10461         (psymbol_bcache_init, psymbol_bcache_free)
10462         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10463         (add_psymbol_to_bcache): Update.
10464         (allocate_psymtab): Update.
10465         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10466         macro_cache>: No longer pointers.
10467         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10468         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10469         * macrotab.c (macro_bcache): Update.
10470         * macroexp.c: Don't include bcache.h.
10471         * gdbtypes.c (check_types_worklist): Update.
10472         (types_deeply_equal): Remove TRY/CATCH.  Update.
10473         * elfread.c (elf_symtab_read): Update.
10474         * dwarf2read.c: Don't include bcache.h.
10475         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10476         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10477         (print_bcache_statistics, bcache_memory_used): Don't declare.
10478         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10479         methods.  Rename all data members.
10480         * bcache.c (struct bcache): Move to bcache.h.
10481         (bcache::expand_hash_table): Rename from expand_hash_table.
10482         (bcache): Remove.
10483         (bcache::insert): Rename from bcache_full.
10484         (bcache::compare): Rename from bcache_compare.
10485         (bcache_xmalloc): Remove.
10486         (bcache::~bcache): Rename from bcache_xfree.
10487         (bcache::print_statistics): Rename from print_bcache_statistics.
10488         (bcache::memory_used): Rename from bcache_memory_used.
10489
10490 2019-03-07  Pedro Alves  <palves@redhat.com>
10491
10492         * infrun.c (normal_stop): Also check for
10493         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10494
10495 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10496
10497         * f-lang.c (value_from_host_double): Moved to...
10498         * value.c (value_from_host_double): ...here.
10499         * value.h (value_from_host_double): Declare.
10500         * guile/scm-math.c (vlscm_convert_typed_number): Use
10501         value_from_host_double.
10502         (vlscm_convert_number): Likewise.
10503         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10504         * python/py-value.c (convert_value_from_python): Likewise.
10505
10506 2019-03-06  Tom Tromey  <tom@tromey.com>
10507
10508         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10509
10510 2019-03-06  Tom Tromey  <tom@tromey.com>
10511
10512         * utils.h (free_current_contents): Don't declare.
10513         * utils.c (free_current_contents): Remove.
10514
10515 2019-03-06  Tom Tromey  <tom@tromey.com>
10516
10517         * top.c (quit_force): Update.
10518         * main.c (captured_command_loop): Update.
10519         * common/new-op.c (operator new): Update.
10520         * common/common-exceptions.c (struct catcher)
10521         <save_cleanup_chain>: Remove member.
10522         (exceptions_state_mc_init): Update.
10523         (exception_try_scope_entry): Return nullptr.
10524         (exception_try_scope_exit, exception_rethrow)
10525         (throw_exception_sjlj, throw_exception_cxx): Update.
10526         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10527         (all_cleanups, do_cleanups, discard_cleanups)
10528         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10529         (restore_cleanups, restore_final_cleanups): Don't declare.
10530         (do_final_cleanups): Remove parameter.
10531         * common/cleanups.c (cleanup_chain, make_cleanup)
10532         (make_cleanup_dtor, all_cleanups, do_cleanups)
10533         (discard_my_cleanups, discard_cleanups)
10534         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10535         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10536         (null_cleanup): Remove.
10537         (do_final_cleanups): Remove parameter.
10538
10539 2019-03-06  Tom Tromey  <tom@tromey.com>
10540
10541         * remote.c (remote_target::remote_parse_stop_reply): Use
10542         unique_xmalloc_ptr.
10543
10544 2019-03-06  Tom Tromey  <tom@tromey.com>
10545
10546         * stabsread.c (struct stabs_field_info): Rename from field_info.
10547         <list, fnlist>: Add initializers.
10548         <obstack>: New member.
10549         (read_member_functions, read_struct_fields, read_baseclasses):
10550         Allocate on obstack.  Don't use cleanups.
10551         (read_one_struct_field, read_member_functions, read_struct_fields)
10552         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10553         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10554         (read_struct_type): Update.
10555
10556 2019-03-06  Tom Tromey  <tom@tromey.com>
10557
10558         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10559         * common/filestuff.h (make_cleanup_close): Don't declare.
10560         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10561         Remove.
10562
10563 2019-03-06  Tom Tromey  <tom@tromey.com>
10564
10565         * solib-aix.c: Use make_scope_exit.
10566
10567 2019-03-06  Tom Tromey  <tom@tromey.com>
10568
10569         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10570         Use make_scope_exit.
10571
10572 2019-03-06  Tom Tromey  <tom@tromey.com>
10573
10574         * solib-svr4.c (disable_probes_interface): Remove parameter.
10575         (svr4_handle_solib_event): Use make_scope_exit.
10576
10577 2019-03-06  Tom Tromey  <tom@tromey.com>
10578
10579         * remote.c (struct stop_reply_deleter): Remove.
10580         (stop_reply_up): Update.
10581         (struct stop_reply): Derive from notif_event.  Don't typedef.
10582         <regcache>: Now a std::vector.
10583         (stop_reply_xfree): Remove.
10584         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10585         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10586         (remote_target::discard_pending_stop_replies): Use delete.
10587         (remote_target::remote_parse_stop_reply): Update.
10588         (remote_target::process_stop_reply): Update.
10589         * remote-notif.h (struct notif_event): Add virtual destructor.
10590         Remove "dtr" member.
10591         (struct notif_client) <alloc_event>: Return a unique_ptr.
10592         (notif_event_xfree): Don't declare.
10593         (notif_event_up): New typedef.
10594         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10595         (notif_event_xfree, do_notif_event_xfree): Remove.
10596         (remote_notif_state_xfree): Update.
10597
10598 2019-03-06  Tom Tromey  <tom@tromey.com>
10599
10600         * infrun.c (displaced_step_clear_cleanup): Now a
10601         forward_scope_exit type.
10602         (displaced_step_prepare_throw): Update.
10603         (displaced_step_fixup): Update.
10604
10605 2019-03-06  Tom Tromey  <tom@tromey.com>
10606
10607         * inferior.h (class inferior): Update comment.
10608         * gdbthread.h (class thread_info): Update comment.
10609
10610 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10611             Tom Tromey  <tom@tromey.com>
10612
10613         * stabsread.h (struct stab_section_list): Remove.
10614         (coffstab_build_psymtabs): Update.
10615         * dbxread.c (symbuf_sections): Now a std::vector.
10616         (sect_idx): New global.
10617         (fill_symbuf): Update.
10618         (coffstab_build_psymtabs): Change type of stabsects parameter.
10619         Update.
10620         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10621         std::vector.
10622         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10623         (coff_locate_sections): Update.
10624         (coff_symfile_read): Remove cleanups.  Update.
10625         (init_stringtab): Add storage parameter.
10626         (free_stringtab, free_stringtab_cleanup): Remove.
10627         (init_lineno): Add storage parameter.
10628         (free_linetab, free_linetab_cleanup): Remove.
10629
10630 2019-03-06  Pedro Alves  <palves@redhat.com>
10631
10632         * linux-fork.c (fork_info::clobber_regs): Delete.
10633         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10634         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10635         comment.  Adjust.
10636         (scoped_switch_fork_info::scoped_switch_fork_info)
10637         (checkpoint_command, linux_fork_context): Adjust
10638         fork_save_infrun_state calls.
10639
10640 2019-03-06  Pedro Alves  <palves@redhat.com>
10641
10642         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10643         (inf_has_multiple_threads): Return 'bool' and rewrite using
10644         inferior_info::threads().
10645
10646 2019-03-06  Pedro Alves  <palves@redhat.com>
10647
10648         * linux-fork.c: Include <list>.
10649         (fork_list): Now a std::list instance.
10650         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10651         (forks_exist_p, find_last_fork): Adjust.
10652         (new_fork): Delete.
10653         (one_fork_p): New.
10654         (add_fork): Adjust.
10655         (free_fork): Delete, folded into fork_info::~fork_info().
10656         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10657         Adjust.
10658         (init_fork_list): Delete.
10659         (linux_fork_killall, linux_fork_mourn_inferior)
10660         (linux_fork_detach, info_checkpoints_command): Adjust.
10661         (_initialize_linux_fork): No longer call init_fork_list.
10662
10663 2019-03-06  Pedro Alves  <palves@redhat.com>
10664
10665         * linux-fork.c (new_fork): New, split out of ...
10666         (add_fork): ... this.  Return void.  Move "first fork" special
10667         case from here, to ...
10668         (checkpoint_command): ... here.
10669         * linux-linux.h (add_fork): Return void.
10670
10671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10672
10673         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10674
10675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10676             Chris January  <chris.january@arm.com>
10677             David Lecomber  <david.lecomber@arm.com>
10678
10679         * f-exp.y: New token, UNOP_INTRINSIC.
10680         (exp): New pattern using UNOP_INTRINSIC token.
10681         (f77_keywords): Add 'abs' keyword.
10682         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10683         (value_from_host_double): New function.
10684         (evaluate_subexp_f): Support UNOP_ABS.
10685
10686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10687
10688         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10689         types.
10690
10691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10692
10693         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10694         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10695         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10696
10697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10698
10699         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10700
10701 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10702             Chris January  <chris.january@arm.com>
10703
10704         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10705         * f-exp.y: Define 'KIND' token.
10706         (exp): New pattern for KIND expressions.
10707         (ptype): Handle types with a kind extension.
10708         (direct_abs_decl): Extend to spot kind extensions.
10709         (f77_keywords): Add 'kind' to the list.
10710         (push_kind_type): New function.
10711         (convert_to_kind_type): New function.
10712         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10713         * parse.c (operator_length_standard): Likewise.
10714         * parser-defs.h (enum type_pieces): Add tp_kind.
10715         * std-operator.def: Add UNOP_KIND.
10716
10717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10718
10719         * f-exp.y (f_parse): Set yydebug.
10720
10721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10722
10723         * f-lang.c (evaluate_subexp_f): New function.
10724         (exp_descriptor_f): New global.
10725         (f_language_defn): Use exp_descriptor_f instead of
10726         exp_descriptor_standard.
10727
10728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10729
10730         * f-exp.y (struct token): Add comments.
10731         (dot_ops): Remove uppercase versions and the end marker.
10732         (f77_keywords): Likewise.
10733         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10734         entries in the dot_ops array are case insensitive, and use
10735         strncasecmp to compare strings.  Also some whitespace cleanup in
10736         this area.  Similar for the f77_keywords array, except entries in
10737         this list might be case sensitive.
10738
10739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10740
10741         * f-exp.y (struct f77_boolean_val): Add comments.
10742         (boolean_values): Remove uppercase versions, and end marker.
10743         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10744         and use strncasecmp to achieve case insensitivity.  Additionally,
10745         perform whitespace cleanup around this code.
10746
10747 2019-03-06  Tom Tromey  <tromey@adacore.com>
10748
10749         * remote-sim.c (gdbsim_target_open): Use result of
10750         gdb_argv::release.
10751
10752 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10753         Dirk Schubert  <dirk.schubert@arm.com>
10754         Chris January  <chris.january@arm.com>
10755
10756         * eval.c (evaluate_subexp_standard): Call Fortran argument
10757         wrapping logic.
10758         * f-lang.c (struct value): A value which can be passed into a
10759         Fortran function call.
10760         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10761         where appropriate.
10762         (struct type): Value ready for a Fortran function call.
10763         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10764         is needed.
10765         * f-lang.h (fortran_argument_convert): Declaration.
10766         (fortran_preserve_arg_pointer): Declaration.
10767         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10768
10769 2019-03-05  Tom Tromey  <tromey@adacore.com>
10770
10771         * python/py-prettyprint.c (print_string_repr): Remove #if.
10772         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10773
10774 2019-03-05  Tom Tromey  <tromey@adacore.com>
10775
10776         * target.c (the_dummy_target): Move later.  Change type to
10777         "dummy_target".
10778         (initialize_targets): Don't initialize the_dummy_target.
10779
10780 2019-03-05  Tom Tromey  <tromey@adacore.com>
10781
10782         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10783         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10784
10785 2019-03-05  Tom Tromey  <tromey@adacore.com>
10786
10787         * windows-nat.c (windows_nat_target::attach)
10788         (windows_nat_target::detach): Don't call gdb_flush.
10789         * valprint.c (generic_val_print, val_print, val_print_string):
10790         Don't call gdb_flush.
10791         * utils.c (defaulted_query): Don't call gdb_flush.
10792         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10793         * target.c (target_announce_detach): Don't call gdb_flush.
10794         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10795         * remote.c (extended_remote_target::attach): Don't call
10796         gdb_flush.
10797         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10798         * printcmd.c (do_examine): Don't call gdb_flush.
10799         (info_display_command): Don't call gdb_flush.
10800         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10801         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10802         * memattr.c (info_mem_command): Don't call gdb_flush.
10803         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10804         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10805         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10806         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10807         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10808         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10809         (gnu_nat_target::detach): Don't call gdb_flush.
10810         * f-valprint.c (f_val_print): Don't call gdb_flush.
10811         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10812         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10813         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10814         gdb_flush.
10815         * c-valprint.c (c_val_print): Don't call gdb_flush.
10816         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10817
10818 2019-03-05  Tom Tromey  <tromey@adacore.com>
10819
10820         * varobj.c (update_dynamic_varobj_children): Update.
10821         (install_default_visualizer): Use reset, not release.
10822         * value.c (set_internalvar): Update.
10823         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10824         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10825         ATTRIBUTE_UNUSED_RESULT.
10826
10827 2019-03-05  Tom Tromey  <tromey@adacore.com>
10828
10829         * remote.c (class scoped_remote_fd) <release>: Add
10830         ATTRIBUTE_UNUSED_RESULT.
10831
10832 2019-03-05  Tom Tromey  <tromey@adacore.com>
10833
10834         * macroexp.c (struct macro_buffer) <release>: Add
10835         ATTRIBUTE_UNUSED_RESULT.
10836
10837 2019-03-05  Tom Tromey  <tromey@adacore.com>
10838
10839         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10840         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10841         ATTRIBUTE_UNUSED_RESULT.
10842
10843 2019-03-05  Tom Tromey  <tromey@adacore.com>
10844
10845         * common/scoped_fd.h (class scoped_fd) <release>: Add
10846         ATTRIBUTE_UNUSED_RESULT.
10847
10848 2019-03-05  Tom Tromey  <tromey@adacore.com>
10849
10850         * parser-defs.h (struct parser_state) <release>: Add
10851         ATTRIBUTE_UNUSED_RESULT.
10852
10853 2019-03-05  Tom Tromey  <tromey@adacore.com>
10854
10855         * utils.h (class gdb_argv) <release>: Add
10856         ATTRIBUTE_UNUSED_RESULT.
10857         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10858
10859 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10860
10861         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10862         for-loop range, to avoid compiler warnings.
10863
10864         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10865         avoid compiler warnings about unused variables.
10866
10867         * NEWS: Mention end of support for native debugging on MS-Windows
10868         before XP.
10869
10870         PR gdb/24292
10871         * common/netstuff.c:
10872         * gdbserver/gdbreplay.c
10873         * gdbserver/remote-utils.c:
10874         * ser-tcp.c:
10875         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10876         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10877         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10878         'getaddrinfo' and 'freeaddrinfo' were not available before
10879         Windows XP, and mingw.org's MinGW headers by default define
10880         _WIN32_WINNT to 0x500.
10881
10882 2019-03-01  Gary Benson <gbenson@redhat.com>
10883
10884         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10885
10886 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10887             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10888
10889         PR gdb/8527
10890         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10891         set_sigint_trap, clear_sigint_trap.
10892
10893 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10894
10895         * target.c (target_detach): Clear the regcache and the
10896         frame cache.
10897
10898 2019-02-27  Pedro Alves  <palves@redhat.com>
10899
10900         * utils.c (set_screen_size): When we cap the height/width sizes,
10901         tweak the corresponding command variable to show "unlimited":
10902
10903 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10904             Pedro Alves  <palves@redhat.com>
10905
10906         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10907         before calling rl_set_screen_size.
10908
10909 2019-02-27  Tom Tromey  <tromey@adacore.com>
10910
10911         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10912         define.
10913         * python/py-value.c: Remove Python 2.4 workaround.
10914         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10915         workaround.
10916         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10917         Python 2.4 workaround.
10918         * python/python-internal.h: Remove Python 2.4 comment.
10919         (Py_ssize_t): Don't define.
10920         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10921         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10922         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10923         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10924         * python/python.c (do_start_initialization): Remove Python 2.4
10925         workaround.
10926         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10927         (print_children): Remove Python 2.4 workaround.
10928         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10929         workaround.
10930         (CHARBUFFERPROC_NAME): Remove.
10931         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10932         Python 2.4 workaround.
10933
10934 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10935
10936         * NEWS: Note minimum Python version.
10937
10938 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10939
10940         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10941         code from these functions.  Remove corresponding ifdefs.  Use
10942         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10943         Remove gotos and target of gotos.
10944         (infpy_search_memory): Likewise.
10945
10946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10947
10948         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10949         (hppa_gdbarch_init): Don't register deleted functions with
10950         gdbarch.
10951
10952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10953
10954         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10955         (h8300_unwind_sp): Delete.
10956         (h8300_dummy_id): Delete.
10957         (h8300_gdbarch_init): Don't register deleted functions with
10958         gdbarch.
10959
10960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10961
10962         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10963         (ft32_unwind_pc): Delete.
10964         (ft32_unwind_sp): Delete.
10965         (ft32_gdbarch_init): Don't register deleted functions with
10966         gdbarch.
10967
10968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10969
10970         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10971         (frv_unwind_pc): Delete.
10972         (frv_unwind_sp): Delete.
10973         (frv_gdbarch_init): Don't register deleted functions with
10974         gdbarch.
10975
10976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10977
10978         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10979         (riscv_unwind_pc): Delete.
10980         (riscv_unwind_sp): Delete.
10981         (riscv_gdbarch_init): Don't register deleted functions with
10982         gdbarch.
10983
10984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10985
10986         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10987         (csky_unwind_pc): Delete.
10988         (csky_unwind_sp): Delete.
10989         (csky_gdbarch_init): Don't register deleted functions with
10990         gdbarch.
10991
10992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10993
10994         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10995         (cris_unwind_pc): Delete.
10996         (cris_unwind_sp): Delete.
10997         (cris_gdbarch_init): Don't register deleted functions with
10998         gdbarch.
10999
11000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11001
11002         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11003         (bfin_unwind_pc): Delete.
11004         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11005
11006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11007
11008         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11009         (arm_unwind_pc): Delete.
11010         (arm_unwind_sp): Delete.
11011         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11012
11013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11014
11015         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11016         (arc_unwind_pc): Delete.
11017         (arc_unwind_sp): Delete.
11018         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11019
11020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11021
11022         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11023         (alpha_unwind_pc): Delete.
11024         (alpha_gdbarch_init): Don't register deleted functions with
11025         gdbarch.
11026
11027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11028
11029         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11030         (aarch64_unwind_pc): Delete.
11031         (aarch64_unwind_sp): Delete.
11032         (aarch64_gdbarch_init): Don't register deleted functions with
11033         gdbarch.
11034
11035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11036
11037         * gdbtypes.c (type_align): Don't consider static members when
11038         computing structure alignment.
11039
11040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11043         return 0 for other types.
11044         * arch-utils.c (default_type_align): Always return 0.
11045         * gdbarch.h: Regenerate.
11046         * gdbarch.sh (type_align): Extend comment.
11047         * gdbtypes.c (type_align): Add additional comments, always call
11048         gdbarch_type_align before applying the default rules.
11049         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11050         generic code will then apply a suitable default.
11051         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11052         types, return 0 for other types.
11053
11054 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11055
11056         * NEWS: Create a new section for the next release branch.
11057         Rename the section of the current branch, now that it has
11058         been cut.
11059
11060 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11061
11062         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11063         * version.in: Bump version to 8.3.50.DATE-git.
11064
11065 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11066
11067         * aix-thread.c (ptid_cmp): Remove unused variable.
11068         (get_signaled_thread): Likewise.
11069         (store_regs_user_thread): Likewise.
11070         (store_regs_kernel_thread): Likewise.
11071         (fetch_regs_kernel_thread): Remove shadowed variable.
11072
11073 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * features/riscv/32bit-cpu.xml: Add register numbers.
11076         * features/riscv/32bit-fpu.c: Regenerate.
11077         * features/riscv/32bit-fpu.xml: Add register numbers.
11078         * features/riscv/64bit-cpu.xml: Add register numbers.
11079         * features/riscv/64bit-fpu.c: Regenerate.
11080         * features/riscv/64bit-fpu.xml: Add register numbers.
11081
11082 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11083
11084         * NEWS: Mention two argument form of gdb.Value constructor.
11085         * python/py-value.c (convert_buffer_and_type_to_value): New
11086         function.
11087         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11088         Add support for handling an optional second argument.  Call
11089         convert_buffer_and_type_to_value as appropriate.
11090         * python/python-internal.h (Py_buffer_deleter): New struct.
11091         (Py_buffer_up): New typedef.
11092
11093 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11094
11095         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11096         instead of releasing ownership.
11097
11098 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11099
11100         * dwarf2read.c (open_and_init_dwp_file): Call
11101         elf_numsections instead of bfd_count_sections to initialize
11102         dwp_file->num_sections.
11103
11104 2019-02-25  Tom Tromey  <tromey@adacore.com>
11105
11106         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11107
11108 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11109
11110         * gcore.in: Add '--readnever' option when invoking GDB.
11111
11112 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11113
11114         * MAINTAINERS: Update my email address.
11115
11116 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11117
11118         * build-id.c (build_id_to_debug_bfd_1): New function.
11119         (build_id_to_debug_bfd): Look for separate debug file in
11120         sysroot.
11121
11122 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * gdbarch.sh: Update the copyright year range that is placed into
11125         generated files.
11126
11127 2019-02-22  Keith Seitz  <keiths@redhat.com>
11128
11129         PR symtab/23853
11130         * linespec.c (create_sals_line_offset): Search for the default
11131         symtab's filename instead of its fullname.
11132
11133 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11134
11135         * NEWS: Update style defaults.
11136
11137 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11138
11139         * main.c (captured_main_1): Disable styling in batch mode.
11140
11141 2019-02-20  Tom Tromey  <tom@tromey.com>
11142
11143         * symtab.c (symtab_symbol_info): Fix typos.
11144
11145 2019-02-20  Tom Tromey  <tromey@adacore.com>
11146
11147         * findcmd.c (_initialize_mem_search): Use upper case for
11148         metasyntactic variables.
11149
11150 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11151
11152         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11153         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11154
11155 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11156
11157         * top.h (source_file_name): Change to std::string.
11158         * top.c (source_file_name): Likewise.
11159         (command_line_input): Adjust.
11160         * cli/cli-script.c (script_from_file): Adjust.
11161
11162 2019-02-19  Tom Tromey  <tromey@adacore.com>
11163
11164         * ravenscar-thread.c
11165         (ravenscar_thread_target::update_thread_list): Don't call
11166         ada_build_task_list.
11167         * ada-lang.h (ada_build_task_list): Don't declare.
11168         * ada-tasks.c (struct ada_tasks_inferior_data)
11169         <task_list_valid_p>: Now bool.
11170         (read_known_tasks, ada_task_list_changed)
11171         (ada_tasks_invalidate_inferior_data): Update.
11172         (read_known_tasks_array): Return bool.
11173         (read_known_tasks_list): Likewise.
11174         (read_known_tasks): Return void.
11175         (ada_build_task_list): Now static.
11176
11177 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11178
11179         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11180         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11181
11182 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11183
11184         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11185         variant for ada_tasks_pspace_data_handle and
11186         ada_tasks_inferior_data_handle.
11187         (ada_tasks_pspace_data_cleanup): New function.
11188         (ada_tasks_inferior_data_cleanup): New function.
11189
11190 2019-02-17  Tom Tromey  <tom@tromey.com>
11191
11192         * macrotab.h (macro_source_fullname): Return a std::string.
11193         * macrotab.c (macro_include, check_for_redefinition)
11194         (macro_undef, macro_lookup_definition, foreach_macro)
11195         (foreach_macro_in_scope): Update.
11196         (macro_source_fullname): Return a std::string.
11197         * macrocmd.c (show_pp_source_pos): Update.
11198
11199 2019-02-17  Tom Tromey  <tom@tromey.com>
11200
11201         * macrocmd.c (show_pp_source_pos): Style the file names.
11202
11203 2019-02-17  Tom Tromey  <tom@tromey.com>
11204
11205         PR tui/24197:
11206         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11207
11208 2019-02-17  Tom Tromey  <tom@tromey.com>
11209
11210         * ada-lang.c (user_select_syms): Use filtered printing.
11211         * utils.c (wrap_style): New global.
11212         (desired_style): Remove.
11213         (emit_style_escape): Add stream parameter.
11214         (set_output_style, reset_terminal_style, prompt_for_continue):
11215         Update.
11216         (flush_wrap_buffer): Only flush gdb_stdout.
11217         (wrap_here): Set wrap_style.
11218         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11219         treat escape sequences as a character.  Change when wrap buffer is
11220         flushed.
11221         (fputs_styled): Do not set the output style when the default is
11222         requested.
11223         * ui-style.h (struct ui_file_style) <is_default>: New method.
11224         * source.c (print_source_lines_base): Emit escape sequences in one
11225         piece.
11226
11227 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11228
11229         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11230         integers and enumeration types.
11231
11232 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11233
11234         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11235         instead of lookup_symbol_in_language
11236         (do_exact_match): New function.
11237         (ada_get_symbol_name_matcher): Return do_exact_match when
11238         doing a verbatim match.
11239
11240 2019-02-15  Tom Tromey  <tromey@adacore.com>
11241
11242         * ravenscar-thread.c (ravenscar_thread_target::resume)
11243         (ravenscar_thread_target::wait): Special case wildcard requests.
11244
11245 2019-02-15  Tom Tromey  <tromey@adacore.com>
11246
11247         * ravenscar-thread.c (base_ptid): Remove.
11248         (struct ravenscar_thread_target) <close>: New method.
11249         <m_base_ptid>: New member.
11250         <update_inferior_ptid, active_task, task_is_currently_active,
11251         runtime_initialized>: Declare methods.
11252         <ravenscar_thread_target>: Add constructor.
11253         (ravenscar_thread_target::task_is_currently_active)
11254         (ravenscar_thread_target::update_inferior_ptid)
11255         (ravenscar_runtime_initialized): Rename.  Now methods.
11256         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11257         (ravenscar_thread_target::update_thread_list): Update.
11258         (ravenscar_thread_target::active_task): Now method.
11259         (ravenscar_thread_target::store_registers)
11260         (ravenscar_thread_target::prepare_to_store)
11261         (ravenscar_thread_target::prepare_to_store)
11262         (ravenscar_thread_target::mourn_inferior): Update.
11263         (ravenscar_inferior_created): Use "new" to create target.
11264         (ravenscar_thread_target::get_ada_task_ptid): Update.
11265         (_initialize_ravenscar): Don't initialize base_ptid.
11266         (ravenscar_ops): Remove global.
11267
11268 2019-02-15  Tom Tromey  <tromey@adacore.com>
11269
11270         * target.h (push_target): Declare new overload.
11271         * target.c (push_target): New overload, taking an rvalue reference.
11272         * remote.c (remote_target::open_1): Use push_target overload.
11273         * corelow.c (core_target_open): Use push_target overload.
11274
11275 2019-02-15  Tom Tromey  <tromey@adacore.com>
11276
11277         * ravenscar-thread.c (is_ravenscar_task)
11278         (ravenscar_task_is_currently_active): Return bool.
11279         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11280         (_initialize_ravenscar): Remove "(void)".
11281         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11282         Return bool.
11283
11284 2019-02-15  Tom Tromey  <tromey@adacore.com>
11285
11286         * ravenscar-thread.c (ravenscar_runtime_initializer)
11287         (has_ravenscar_runtime, get_running_thread_id)
11288         (ravenscar_thread_target::resume): Fix indentation.
11289
11290 2019-02-15  Tom Tromey  <tromey@adacore.com>
11291
11292         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11293         from ravenscar_arch_ops.
11294         (sparc_ravenscar_ops::fetch_registers)
11295         (sparc_ravenscar_ops::store_registers): Now methods.
11296         (sparc_ravenscar_prepare_to_store): Remove.
11297         (sparc_ravenscar_ops): Redefine.
11298         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11299         methods and destructor.  Remove members.
11300         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11301         (ravenscar_thread_target::store_registers)
11302         (ravenscar_thread_target::prepare_to_store): Update.
11303         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11304         Remove.
11305         (struct ppc_ravenscar_powerpc_ops): Derive from
11306         ravenscar_arch_ops.
11307         (ppc_ravenscar_powerpc_ops::fetch_registers)
11308         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11309         (ppc_ravenscar_powerpc_ops): Redefine.
11310         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11311         (ppc_ravenscar_e500_ops::fetch_registers)
11312         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11313         (ppc_ravenscar_e500_ops): Redefine.
11314         * aarch64-ravenscar-thread.c
11315         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11316         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11317         (aarch64_ravenscar_fetch_registers)
11318         (aarch64_ravenscar_store_registers): Now methods.
11319         (aarch64_ravenscar_ops): Redefine.
11320
11321 2019-02-15  Tom Tromey  <tromey@adacore.com>
11322
11323         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11324         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11325         (ravenscar_thread_target::stopped_by_watchpoint)
11326         (ravenscar_thread_target::stopped_data_address)
11327         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11328
11329 2019-02-15  Tom Tromey  <tromey@adacore.com>
11330
11331         * ravenscar-thread.c: Fix some typos.
11332
11333 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11334             Tom Tromey  <tromey@adacore.com>
11335
11336         * ada-lang.c (ada_exception_sal): Change addr_string to a
11337         std::string.
11338         (create_ada_exception_catchpoint): Update.
11339
11340 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11341             Tom Tromey  <tromey@adacore.com>
11342
11343         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11344         (bp_location_ops): Remove.
11345         (base_breakpoint_allocate_location): Update.
11346         (free_bp_location): Update.
11347         * ada-lang.c (class ada_catchpoint_location)
11348         <ada_catchpoint_location>: Remove ops parameter.
11349         (ada_catchpoint_location_dtor): Remove.
11350         (ada_catchpoint_location_ops): Remove.
11351         (allocate_location_exception): Update.
11352         * breakpoint.h (struct bp_location_ops): Remove.
11353         (class bp_location) <bp_location>: Remove bp_location_ops
11354         parameter.
11355         <~bp_location>: Add destructor.
11356         <ops>: Remove.
11357
11358 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11359             Pedro Alves  <palves@redhat.com>
11360
11361         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11362         'PATH_MAX'.
11363
11364 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11365             Samuel Thibault  <samuel.thibault@gnu.org>
11366             Thomas Schwinge  <thomas@codesourcery.com>
11367
11368         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11369         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11370
11371 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11372
11373         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11374         (check_empty): Use "const char *".
11375
11376         * gnu-nat.c (gnu_nat_target::detach): Instead of
11377         'detach_inferior (pid)' call
11378         'detach_inferior (find_inferior_pid (pid))'.
11379
11380         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11381         'nat/fork-inferior.o'.
11382         * gnu-nat.c: #include "nat/fork-inferior.h".
11383
11384         * gnu-nat.c (gnu_nat_target::detach): Instead of
11385         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11386         * gnu-nat.h: #include "inf-child.h".
11387         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11388         'i386_gnu_nat_target::fetch_registers'.
11389         (gnu_store_registers): Rename/move to
11390         'i386_gnu_nat_target::store_registers'.
11391
11392         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11393         * gnu-nat.h (mach_thread_info): New function.
11394         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11395
11396         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11397
11398 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11399
11400         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11401
11402 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11403
11404         * windows-nat.c (windows_add_thread): Add new parameter
11405         "main_thread_p" with default value set to false.  Update
11406         function documentation as well as all callers.
11407         (windows_delete_thread): Likewise.
11408         (fake_create_process): Update call to windows_add_thread.
11409         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11410         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11411         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11412         call to windows_delete_thread.
11413
11414 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11415
11416         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11417
11418 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11419
11420         * symfile.c (find_separate_debug_file): Use canonical path of
11421         sysroot with child_path instead of gdb_sysroot if it is valid.
11422
11423 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11424
11425         * symfile.c (find_separate_debug_file): Use child_path to
11426         determine if an object file is under a sysroot.
11427
11428 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11429
11430         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11431         unittests/child-path-selftests.c.
11432         * common/pathstuff.c (child_path): New function.
11433         * common/pathstuff.h (child_path): New prototype.
11434         * unittests/child-path-selftests.c: New file.
11435
11436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11437
11438         * symfile.c (find_separate_debug_file): Look for separate debug
11439         files in debug directories under the sysroot.
11440
11441 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11442
11443         * symtab.h (struct minimal_symbol data_p): New const method.
11444         (struct minimal_symbol text_p): Likewise.
11445         * symtab.c (output_source_filename): Use file name style
11446         to print file name.
11447         (print_symbol_info): Likewise.
11448         (print_msymbol_info): Use address style to print addresses.
11449         Use function name style to print executable text symbols.
11450         (expand_symtab_containing_pc): Use data_p.
11451         (find_pc_sect_compunit_symtab): Likewise.
11452
11453 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11454
11455         * breakpoint.c (describe_other_breakpoints): Use address style
11456         to print addresses.
11457         (say_where): Likewise.
11458
11459 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11460
11461         * ada-typeprint.c (print_func_type): Print function name
11462         style to print function name.
11463         * c-typeprint.c (c_print_type_1): Likewise.
11464
11465 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11466
11467         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11468         for execve.
11469
11470 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11471
11472         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11473         type_stack.
11474
11475 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11476
11477         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11478         TYPE_CODE_REF types.
11479
11480 2019-02-08  Jim Wilson  <jimw@sifive.com>
11481
11482         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11483         (riscv_linux_fregset): New.
11484         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11485
11486 2019-02-07  Tom Tromey  <tom@tromey.com>
11487
11488         * thread.c (thread_cancel_execution_command): Update.
11489         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11490         methods.
11491         (struct thread_fsm_ops): Remove.
11492         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11493         (thread_fsm_should_stop, thread_fsm_return_value)
11494         (thread_fsm_set_finished, thread_fsm_finished_p)
11495         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11496         Don't declare.
11497         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11498         * infrun.c (clear_proceed_status_thread)
11499         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11500         (print_stop_event): Update.
11501         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11502         Add constructor.
11503         (step_command_fsm_ops): Remove.
11504         (new_step_command_fsm): Remove.
11505         (step_1): Update.
11506         (step_command_fsm::should_stop): Rename from
11507         step_command_fsm_should_stop.
11508         (step_command_fsm::clean_up): Rename from
11509         step_command_fsm_clean_up.
11510         (step_command_fsm::do_async_reply_reason): Rename from
11511         step_command_fsm_async_reply_reason.
11512         (struct until_next_fsm): Inherit from thread_fsm.  Add
11513         constructor.
11514         (until_next_fsm_ops): Remove.
11515         (new_until_next_fsm): Remove.
11516         (until_next_fsm::should_stop): Rename from
11517         until_next_fsm_should_stop.
11518         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11519         (until_next_fsm::do_async_reply_reason): Rename from
11520         until_next_fsm_async_reply_reason.
11521         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11522         constructor.  Change type of breakpoint.
11523         (finish_command_fsm_ops): Remove.
11524         (new_finish_command_fsm): Remove.
11525         (finish_command_fsm::should_stop): Rename from
11526         finish_command_fsm_should_stop.
11527         (finish_command_fsm::clean_up): Rename from
11528         finish_command_fsm_clean_up.
11529         (finish_command_fsm::return_value): Rename from
11530         finish_command_fsm_return_value.
11531         (finish_command_fsm::do_async_reply_reason): Rename from
11532         finish_command_fsm_async_reply_reason.
11533         (finish_command): Update.
11534         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11535         Add constructor.
11536         (call_thread_fsm_ops): Remove.
11537         (call_thread_fsm::call_thread_fsm): Rename from
11538         new_call_thread_fsm.
11539         (call_thread_fsm::should_stop): Rename from
11540         call_thread_fsm_should_stop.
11541         (call_thread_fsm::should_notify_stop): Rename from
11542         call_thread_fsm_should_notify_stop.
11543         (run_inferior_call, call_function_by_hand_dummy): Update.
11544         * cli/cli-interp.c (should_print_stop_to_console): Update.
11545         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11546         Add constructor.  Change type of location_breakpoint,
11547         caller_breakpoint.
11548         (until_break_fsm_ops): Remove.
11549         (new_until_break_fsm): Remove.
11550         (until_break_fsm::should_stop): Rename from
11551         until_break_fsm_should_stop.
11552         (until_break_fsm::clean_up): Rename from
11553         until_break_fsm_clean_up.
11554         (until_break_fsm::do_async_reply_reason): Rename from
11555         until_break_fsm_async_reply_reason.
11556         (until_break_command): Update.
11557         * thread-fsm.c: Remove.
11558         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11559
11560 2019-02-07  Tom Tromey  <tom@tromey.com>
11561
11562         * yy-remap.h: Add include guard.
11563         * xtensa-tdep.h: Add include guard.
11564         * xcoffread.h: Rename include guard.
11565         * varobj-iter.h: Add include guard.
11566         * tui/tui.h: Rename include guard.
11567         * tui/tui-winsource.h: Rename include guard.
11568         * tui/tui-wingeneral.h: Rename include guard.
11569         * tui/tui-windata.h: Rename include guard.
11570         * tui/tui-win.h: Rename include guard.
11571         * tui/tui-stack.h: Rename include guard.
11572         * tui/tui-source.h: Rename include guard.
11573         * tui/tui-regs.h: Rename include guard.
11574         * tui/tui-out.h: Rename include guard.
11575         * tui/tui-layout.h: Rename include guard.
11576         * tui/tui-io.h: Rename include guard.
11577         * tui/tui-hooks.h: Rename include guard.
11578         * tui/tui-file.h: Rename include guard.
11579         * tui/tui-disasm.h: Rename include guard.
11580         * tui/tui-data.h: Rename include guard.
11581         * tui/tui-command.h: Rename include guard.
11582         * tic6x-tdep.h: Add include guard.
11583         * target/waitstatus.h: Rename include guard.
11584         * target/wait.h: Rename include guard.
11585         * target/target.h: Rename include guard.
11586         * target/resume.h: Rename include guard.
11587         * target-float.h: Rename include guard.
11588         * stabsread.h: Add include guard.
11589         * rs6000-tdep.h: Add include guard.
11590         * riscv-fbsd-tdep.h: Add include guard.
11591         * regformats/regdef.h: Rename include guard.
11592         * record.h: Rename include guard.
11593         * python/python.h: Rename include guard.
11594         * python/python-internal.h: Rename include guard.
11595         * python/py-stopevent.h: Rename include guard.
11596         * python/py-ref.h: Rename include guard.
11597         * python/py-record.h: Rename include guard.
11598         * python/py-record-full.h: Rename include guard.
11599         * python/py-record-btrace.h: Rename include guard.
11600         * python/py-instruction.h: Rename include guard.
11601         * python/py-events.h: Rename include guard.
11602         * python/py-event.h: Rename include guard.
11603         * procfs.h: Add include guard.
11604         * proc-utils.h: Add include guard.
11605         * p-lang.h: Add include guard.
11606         * or1k-tdep.h: Rename include guard.
11607         * observable.h: Rename include guard.
11608         * nto-tdep.h: Rename include guard.
11609         * nat/x86-linux.h: Rename include guard.
11610         * nat/x86-linux-dregs.h: Rename include guard.
11611         * nat/x86-gcc-cpuid.h: Add include guard.
11612         * nat/x86-dregs.h: Rename include guard.
11613         * nat/x86-cpuid.h: Rename include guard.
11614         * nat/ppc-linux.h: Rename include guard.
11615         * nat/mips-linux-watch.h: Rename include guard.
11616         * nat/linux-waitpid.h: Rename include guard.
11617         * nat/linux-ptrace.h: Rename include guard.
11618         * nat/linux-procfs.h: Rename include guard.
11619         * nat/linux-osdata.h: Rename include guard.
11620         * nat/linux-nat.h: Rename include guard.
11621         * nat/linux-namespaces.h: Rename include guard.
11622         * nat/linux-btrace.h: Rename include guard.
11623         * nat/glibc_thread_db.h: Rename include guard.
11624         * nat/gdb_thread_db.h: Rename include guard.
11625         * nat/gdb_ptrace.h: Rename include guard.
11626         * nat/fork-inferior.h: Rename include guard.
11627         * nat/amd64-linux-siginfo.h: Rename include guard.
11628         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11629         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11630         * nat/aarch64-linux.h: Rename include guard.
11631         * nat/aarch64-linux-hw-point.h: Rename include guard.
11632         * mn10300-tdep.h: Add include guard.
11633         * mips-linux-tdep.h: Add include guard.
11634         * mi/mi-parse.h: Rename include guard.
11635         * mi/mi-out.h: Rename include guard.
11636         * mi/mi-main.h: Rename include guard.
11637         * mi/mi-interp.h: Rename include guard.
11638         * mi/mi-getopt.h: Rename include guard.
11639         * mi/mi-console.h: Rename include guard.
11640         * mi/mi-common.h: Rename include guard.
11641         * mi/mi-cmds.h: Rename include guard.
11642         * mi/mi-cmd-break.h: Rename include guard.
11643         * m2-lang.h: Add include guard.
11644         * location.h: Rename include guard.
11645         * linux-record.h: Rename include guard.
11646         * linux-nat.h: Add include guard.
11647         * linux-fork.h: Add include guard.
11648         * i386-darwin-tdep.h: Rename include guard.
11649         * hppa-linux-offsets.h: Add include guard.
11650         * guile/guile.h: Rename include guard.
11651         * guile/guile-internal.h: Rename include guard.
11652         * gnu-nat.h: Rename include guard.
11653         * gdb-stabs.h: Rename include guard.
11654         * frv-tdep.h: Add include guard.
11655         * f-lang.h: Add include guard.
11656         * event-loop.h: Add include guard.
11657         * darwin-nat.h: Rename include guard.
11658         * cp-abi.h: Rename include guard.
11659         * config/sparc/nm-sol2.h: Rename include guard.
11660         * config/nm-nto.h: Rename include guard.
11661         * config/nm-linux.h: Add include guard.
11662         * config/i386/nm-i386gnu.h: Rename include guard.
11663         * config/djgpp/nl_types.h: Rename include guard.
11664         * config/djgpp/langinfo.h: Rename include guard.
11665         * compile/gcc-cp-plugin.h: Add include guard.
11666         * compile/gcc-c-plugin.h: Add include guard.
11667         * compile/compile.h: Rename include guard.
11668         * compile/compile-object-run.h: Rename include guard.
11669         * compile/compile-object-load.h: Rename include guard.
11670         * compile/compile-internal.h: Rename include guard.
11671         * compile/compile-cplus.h: Rename include guard.
11672         * compile/compile-c.h: Rename include guard.
11673         * common/xml-utils.h: Rename include guard.
11674         * common/x86-xstate.h: Rename include guard.
11675         * common/version.h: Rename include guard.
11676         * common/vec.h: Rename include guard.
11677         * common/tdesc.h: Rename include guard.
11678         * common/selftest.h: Rename include guard.
11679         * common/scoped_restore.h: Rename include guard.
11680         * common/scoped_mmap.h: Rename include guard.
11681         * common/scoped_fd.h: Rename include guard.
11682         * common/safe-iterator.h: Rename include guard.
11683         * common/run-time-clock.h: Rename include guard.
11684         * common/refcounted-object.h: Rename include guard.
11685         * common/queue.h: Rename include guard.
11686         * common/ptid.h: Rename include guard.
11687         * common/print-utils.h: Rename include guard.
11688         * common/preprocessor.h: Rename include guard.
11689         * common/pathstuff.h: Rename include guard.
11690         * common/observable.h: Rename include guard.
11691         * common/netstuff.h: Rename include guard.
11692         * common/job-control.h: Rename include guard.
11693         * common/host-defs.h: Rename include guard.
11694         * common/gdb_wait.h: Rename include guard.
11695         * common/gdb_vecs.h: Rename include guard.
11696         * common/gdb_unlinker.h: Rename include guard.
11697         * common/gdb_unique_ptr.h: Rename include guard.
11698         * common/gdb_tilde_expand.h: Rename include guard.
11699         * common/gdb_sys_time.h: Rename include guard.
11700         * common/gdb_string_view.h: Rename include guard.
11701         * common/gdb_splay_tree.h: Rename include guard.
11702         * common/gdb_setjmp.h: Rename include guard.
11703         * common/gdb_ref_ptr.h: Rename include guard.
11704         * common/gdb_optional.h: Rename include guard.
11705         * common/gdb_locale.h: Rename include guard.
11706         * common/gdb_assert.h: Rename include guard.
11707         * common/filtered-iterator.h: Rename include guard.
11708         * common/filestuff.h: Rename include guard.
11709         * common/fileio.h: Rename include guard.
11710         * common/environ.h: Rename include guard.
11711         * common/common-utils.h: Rename include guard.
11712         * common/common-types.h: Rename include guard.
11713         * common/common-regcache.h: Rename include guard.
11714         * common/common-inferior.h: Rename include guard.
11715         * common/common-gdbthread.h: Rename include guard.
11716         * common/common-exceptions.h: Rename include guard.
11717         * common/common-defs.h: Rename include guard.
11718         * common/common-debug.h: Rename include guard.
11719         * common/cleanups.h: Rename include guard.
11720         * common/buffer.h: Rename include guard.
11721         * common/btrace-common.h: Rename include guard.
11722         * common/break-common.h: Rename include guard.
11723         * cli/cli-utils.h: Rename include guard.
11724         * cli/cli-style.h: Rename include guard.
11725         * cli/cli-setshow.h: Rename include guard.
11726         * cli/cli-script.h: Rename include guard.
11727         * cli/cli-interp.h: Rename include guard.
11728         * cli/cli-decode.h: Rename include guard.
11729         * cli/cli-cmds.h: Rename include guard.
11730         * charset-list.h: Add include guard.
11731         * buildsym-legacy.h: Rename include guard.
11732         * bfin-tdep.h: Add include guard.
11733         * ax.h: Rename include guard.
11734         * arm-linux-tdep.h: Add include guard.
11735         * arm-fbsd-tdep.h: Add include guard.
11736         * arch/xtensa.h: Rename include guard.
11737         * arch/tic6x.h: Add include guard.
11738         * arch/i386.h: Add include guard.
11739         * arch/arm.h: Rename include guard.
11740         * arch/arm-linux.h: Rename include guard.
11741         * arch/arm-get-next-pcs.h: Rename include guard.
11742         * arch/amd64.h: Add include guard.
11743         * arch/aarch64-insn.h: Rename include guard.
11744         * arch-utils.h: Rename include guard.
11745         * annotate.h: Add include guard.
11746         * amd64-darwin-tdep.h: Rename include guard.
11747         * aarch64-linux-tdep.h: Add include guard.
11748         * aarch64-fbsd-tdep.h: Add include guard.
11749         * aarch32-linux-nat.h: Add include guard.
11750
11751 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11752
11753         * macrotab.c (macro_define_internal): New function that
11754         factorizes macro_define_object_internal and macro_define_function
11755         code.
11756         (macro_define_object_internal): Use macro_define_internal.
11757         (macro_define_function): Likewise.
11758
11759 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11760
11761         * macrocmd.c (extract_identifier): Return
11762         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11763         callers.
11764
11765 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11766
11767         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11768
11769 2019-02-05  Tom Tromey  <tom@tromey.com>
11770
11771         * target.c (target_stack::unpush): Move assertion earlier.
11772
11773 2019-01-30  Tom Tromey  <tom@tromey.com>
11774
11775         PR python/23615:
11776         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11777         (gdbpy_parse_and_eval): Likewise.
11778         * python/python-internal.h (gdbpy_allow_threads): New class.
11779
11780 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11781
11782         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11783         (aarch64_fbsd_fpregmap): Move earlier.
11784         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11785         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11786         instead of individual calls to trad_frame_set_reg_addr.
11787         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11788         earlier.
11789         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11790         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11791         instead of individual calls to trad_frame_set_reg_addr.
11792
11793 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11794
11795         * CONTRIBUTE: Replace contribution list with wiki link.
11796
11797 2019-01-25  Tom Tromey  <tom@tromey.com>
11798
11799         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11800
11801 2019-01-25  Tom Tromey  <tom@tromey.com>
11802
11803         * xtensa-linux-nat.c: Fix common/ includes.
11804         * xml-support.h: Fix common/ includes.
11805         * xml-support.c: Fix common/ includes.
11806         * x86-linux-nat.c: Fix common/ includes.
11807         * windows-nat.c: Fix common/ includes.
11808         * varobj.h: Fix common/ includes.
11809         * varobj.c: Fix common/ includes.
11810         * value.c: Fix common/ includes.
11811         * valops.c: Fix common/ includes.
11812         * utils.c: Fix common/ includes.
11813         * unittests/xml-utils-selftests.c: Fix common/ includes.
11814         * unittests/utils-selftests.c: Fix common/ includes.
11815         * unittests/unpack-selftests.c: Fix common/ includes.
11816         * unittests/tracepoint-selftests.c: Fix common/ includes.
11817         * unittests/style-selftests.c: Fix common/ includes.
11818         * unittests/string_view-selftests.c: Fix common/ includes.
11819         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11820         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11821         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11822         * unittests/rsp-low-selftests.c: Fix common/ includes.
11823         * unittests/parse-connection-spec-selftests.c: Fix common/
11824         includes.
11825         * unittests/optional-selftests.c: Fix common/ includes.
11826         * unittests/offset-type-selftests.c: Fix common/ includes.
11827         * unittests/observable-selftests.c: Fix common/ includes.
11828         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11829         * unittests/memrange-selftests.c: Fix common/ includes.
11830         * unittests/memory-map-selftests.c: Fix common/ includes.
11831         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11832         * unittests/function-view-selftests.c: Fix common/ includes.
11833         * unittests/environ-selftests.c: Fix common/ includes.
11834         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11835         * unittests/common-utils-selftests.c: Fix common/ includes.
11836         * unittests/cli-utils-selftests.c: Fix common/ includes.
11837         * unittests/array-view-selftests.c: Fix common/ includes.
11838         * ui-file.c: Fix common/ includes.
11839         * tui/tui-io.c: Fix common/ includes.
11840         * tracepoint.h: Fix common/ includes.
11841         * tracepoint.c: Fix common/ includes.
11842         * tracefile-tfile.c: Fix common/ includes.
11843         * top.h: Fix common/ includes.
11844         * top.c: Fix common/ includes.
11845         * thread.c: Fix common/ includes.
11846         * target/waitstatus.h: Fix common/ includes.
11847         * target/waitstatus.c: Fix common/ includes.
11848         * target.h: Fix common/ includes.
11849         * target.c: Fix common/ includes.
11850         * target-memory.c: Fix common/ includes.
11851         * target-descriptions.c: Fix common/ includes.
11852         * symtab.h: Fix common/ includes.
11853         * symfile.c: Fix common/ includes.
11854         * stap-probe.c: Fix common/ includes.
11855         * spu-linux-nat.c: Fix common/ includes.
11856         * sparc-nat.c: Fix common/ includes.
11857         * source.c: Fix common/ includes.
11858         * solib.c: Fix common/ includes.
11859         * solib-target.c: Fix common/ includes.
11860         * ser-unix.c: Fix common/ includes.
11861         * ser-tcp.c: Fix common/ includes.
11862         * ser-pipe.c: Fix common/ includes.
11863         * ser-base.c: Fix common/ includes.
11864         * selftest-arch.c: Fix common/ includes.
11865         * s12z-tdep.c: Fix common/ includes.
11866         * rust-exp.y: Fix common/ includes.
11867         * rs6000-aix-tdep.c: Fix common/ includes.
11868         * riscv-tdep.c: Fix common/ includes.
11869         * remote.c: Fix common/ includes.
11870         * remote-notif.h: Fix common/ includes.
11871         * remote-fileio.h: Fix common/ includes.
11872         * remote-fileio.c: Fix common/ includes.
11873         * regcache.h: Fix common/ includes.
11874         * regcache.c: Fix common/ includes.
11875         * record-btrace.c: Fix common/ includes.
11876         * python/python.c: Fix common/ includes.
11877         * python/py-type.c: Fix common/ includes.
11878         * python/py-inferior.c: Fix common/ includes.
11879         * progspace.h: Fix common/ includes.
11880         * producer.c: Fix common/ includes.
11881         * procfs.c: Fix common/ includes.
11882         * proc-api.c: Fix common/ includes.
11883         * printcmd.c: Fix common/ includes.
11884         * ppc-linux-nat.c: Fix common/ includes.
11885         * parser-defs.h: Fix common/ includes.
11886         * osdata.c: Fix common/ includes.
11887         * obsd-nat.c: Fix common/ includes.
11888         * nat/x86-linux.c: Fix common/ includes.
11889         * nat/x86-linux-dregs.c: Fix common/ includes.
11890         * nat/x86-dregs.h: Fix common/ includes.
11891         * nat/x86-dregs.c: Fix common/ includes.
11892         * nat/ppc-linux.c: Fix common/ includes.
11893         * nat/mips-linux-watch.h: Fix common/ includes.
11894         * nat/mips-linux-watch.c: Fix common/ includes.
11895         * nat/linux-waitpid.c: Fix common/ includes.
11896         * nat/linux-ptrace.h: Fix common/ includes.
11897         * nat/linux-ptrace.c: Fix common/ includes.
11898         * nat/linux-procfs.c: Fix common/ includes.
11899         * nat/linux-personality.c: Fix common/ includes.
11900         * nat/linux-osdata.c: Fix common/ includes.
11901         * nat/linux-namespaces.c: Fix common/ includes.
11902         * nat/linux-btrace.h: Fix common/ includes.
11903         * nat/linux-btrace.c: Fix common/ includes.
11904         * nat/fork-inferior.c: Fix common/ includes.
11905         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11906         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11907         * nat/aarch64-linux.c: Fix common/ includes.
11908         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11909         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11910         * namespace.h: Fix common/ includes.
11911         * mips-linux-tdep.c: Fix common/ includes.
11912         * minsyms.c: Fix common/ includes.
11913         * mi/mi-parse.h: Fix common/ includes.
11914         * mi/mi-main.c: Fix common/ includes.
11915         * mi/mi-cmd-env.c: Fix common/ includes.
11916         * memrange.h: Fix common/ includes.
11917         * memattr.c: Fix common/ includes.
11918         * maint.h: Fix common/ includes.
11919         * maint.c: Fix common/ includes.
11920         * main.c: Fix common/ includes.
11921         * machoread.c: Fix common/ includes.
11922         * location.c: Fix common/ includes.
11923         * linux-thread-db.c: Fix common/ includes.
11924         * linux-nat.c: Fix common/ includes.
11925         * linux-fork.c: Fix common/ includes.
11926         * inline-frame.c: Fix common/ includes.
11927         * infrun.c: Fix common/ includes.
11928         * inflow.c: Fix common/ includes.
11929         * inferior.h: Fix common/ includes.
11930         * inferior.c: Fix common/ includes.
11931         * infcmd.c: Fix common/ includes.
11932         * inf-ptrace.c: Fix common/ includes.
11933         * inf-child.c: Fix common/ includes.
11934         * ia64-linux-nat.c: Fix common/ includes.
11935         * i387-tdep.c: Fix common/ includes.
11936         * i386-tdep.c: Fix common/ includes.
11937         * i386-linux-tdep.c: Fix common/ includes.
11938         * i386-linux-nat.c: Fix common/ includes.
11939         * i386-go32-tdep.c: Fix common/ includes.
11940         * i386-fbsd-tdep.c: Fix common/ includes.
11941         * i386-fbsd-nat.c: Fix common/ includes.
11942         * guile/scm-type.c: Fix common/ includes.
11943         * guile/guile.c: Fix common/ includes.
11944         * go32-nat.c: Fix common/ includes.
11945         * gnu-nat.c: Fix common/ includes.
11946         * gdbthread.h: Fix common/ includes.
11947         * gdbarch-selftests.c: Fix common/ includes.
11948         * gdb_usleep.c: Fix common/ includes.
11949         * gdb_select.h: Fix common/ includes.
11950         * gdb_bfd.c: Fix common/ includes.
11951         * gcore.c: Fix common/ includes.
11952         * fork-child.c: Fix common/ includes.
11953         * findvar.c: Fix common/ includes.
11954         * fbsd-nat.c: Fix common/ includes.
11955         * event-top.c: Fix common/ includes.
11956         * event-loop.c: Fix common/ includes.
11957         * dwarf2read.c: Fix common/ includes.
11958         * dwarf2loc.c: Fix common/ includes.
11959         * dwarf2-frame.c: Fix common/ includes.
11960         * dwarf-index-cache.c: Fix common/ includes.
11961         * dtrace-probe.c: Fix common/ includes.
11962         * disasm-selftests.c: Fix common/ includes.
11963         * defs.h: Fix common/ includes.
11964         * csky-tdep.c: Fix common/ includes.
11965         * cp-valprint.c: Fix common/ includes.
11966         * cp-support.h: Fix common/ includes.
11967         * cp-support.c: Fix common/ includes.
11968         * corelow.c: Fix common/ includes.
11969         * completer.h: Fix common/ includes.
11970         * completer.c: Fix common/ includes.
11971         * compile/compile.c: Fix common/ includes.
11972         * compile/compile-loc2c.c: Fix common/ includes.
11973         * compile/compile-cplus-types.c: Fix common/ includes.
11974         * compile/compile-cplus-symbols.c: Fix common/ includes.
11975         * command.h: Fix common/ includes.
11976         * cli/cli-dump.c: Fix common/ includes.
11977         * cli/cli-cmds.c: Fix common/ includes.
11978         * charset.c: Fix common/ includes.
11979         * build-id.c: Fix common/ includes.
11980         * btrace.h: Fix common/ includes.
11981         * btrace.c: Fix common/ includes.
11982         * breakpoint.h: Fix common/ includes.
11983         * breakpoint.c: Fix common/ includes.
11984         * ax.h:
11985         (enum agent_op): Fix common/ includes.
11986         * ax-general.c (struct aop_map): Fix common/ includes.
11987         * ax-gdb.c: Fix common/ includes.
11988         * auxv.c: Fix common/ includes.
11989         * auto-load.c: Fix common/ includes.
11990         * arm-tdep.c: Fix common/ includes.
11991         * arch/riscv.c: Fix common/ includes.
11992         * arch/ppc-linux-common.c: Fix common/ includes.
11993         * arch/i386.c: Fix common/ includes.
11994         * arch/arm.c: Fix common/ includes.
11995         * arch/arm-linux.c: Fix common/ includes.
11996         * arch/arm-get-next-pcs.c: Fix common/ includes.
11997         * arch/amd64.c: Fix common/ includes.
11998         * arch/aarch64.c: Fix common/ includes.
11999         * arch/aarch64-insn.c: Fix common/ includes.
12000         * arch-utils.c: Fix common/ includes.
12001         * amd64-windows-tdep.c: Fix common/ includes.
12002         * amd64-tdep.c: Fix common/ includes.
12003         * amd64-sol2-tdep.c: Fix common/ includes.
12004         * amd64-obsd-tdep.c: Fix common/ includes.
12005         * amd64-nbsd-tdep.c: Fix common/ includes.
12006         * amd64-linux-tdep.c: Fix common/ includes.
12007         * amd64-linux-nat.c: Fix common/ includes.
12008         * amd64-fbsd-tdep.c: Fix common/ includes.
12009         * amd64-fbsd-nat.c: Fix common/ includes.
12010         * amd64-dicos-tdep.c: Fix common/ includes.
12011         * amd64-darwin-tdep.c: Fix common/ includes.
12012         * agent.c: Fix common/ includes.
12013         * ada-lang.h: Fix common/ includes.
12014         * ada-lang.c: Fix common/ includes.
12015         * aarch64-tdep.c: Fix common/ includes.
12016
12017 2019-01-25  Tom Tromey  <tom@tromey.com>
12018
12019         * common/create-version.sh: Use common/version.h.
12020
12021 2019-01-24  Pedro Alves  <palves@redhat.com>
12022
12023         * infrun.c (signal_stop, signal_print, signal_program)
12024         (signal_catch, signal_pass): Now arrays instead of pointers.
12025         (update_signals_program_target, do_target_resume)
12026         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12027         * linux-nat.c (linux_nat_target::pass_signals)
12028         (linux_nat_target::create_inferior, linux_nat_target::attach):
12029         Adjust.
12030         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12031         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12032         * procfs.c (procfs_target::pass_signals): Adjust.
12033         * record-full.c (record_full_target::resume): Adjust.
12034         * remote.c (remote_target::pass_signals)
12035         (remote_target::program_signals): Adjust.
12036         * target-debug.h (target_debug_print_signals): Now takes a
12037         gdb::array_view as parameter.  Adjust.
12038         * target.h (target_ops) <pass_signals, program_signals>: Replace
12039         pointer and length parameters with gdb::array_view.
12040         (target_pass_signals, target_program_signals): Likewise.
12041         * target-delegates.c: Regenerate.
12042
12043 2019-01-24  Pedro Alves  <palves@redhat.com>
12044
12045         * common/forward-scope-exit.h
12046         (forward_scope_exit::forward_scope_exit): Pass arguments to
12047         m_bind_function directly, instead of creating a std::bind and
12048         copying that.
12049
12050 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12051
12052         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12053         for static members.
12054         (pass_in_v_vfp_candidate): Likewise.
12055
12056 2019-01-23  Tom Tromey  <tom@tromey.com>
12057             Pedro Alves  <palves@redhat.com>
12058
12059         * regcache.c (class regcache_invalidator): Remove.
12060         (regcache::raw_write): Use make_scope_exit.
12061
12062 2019-01-23  Tom Tromey  <tom@tromey.com>
12063
12064         * ui-out.h (class ui_out_emit_type): Update comment.
12065
12066 2019-01-23  Tom Tromey  <tom@tromey.com>
12067
12068         * infrun.c (fetch_inferior_event): Update comment.
12069
12070 2019-01-23  Tom Tromey  <tom@tromey.com>
12071             Pedro Alves  <palves@redhat.com>
12072
12073         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12074         parameter.
12075         (fetch_inferior_event): Use SCOPE_EXIT.
12076
12077
12078 2019-01-23  Tom Tromey  <tom@tromey.com>
12079             Pedro Alves  <palves@redhat.com>
12080
12081         * infrun.c (disable_thread_events): Delete.
12082         (stop_all_threads): Use SCOPE_EXIT.
12083
12084 2019-01-23  Tom Tromey  <tom@tromey.com>
12085             Pedro Alves  <palves@redhat.com>
12086
12087         * symfile.c: Include forward-scope-exit.h.
12088         (clear_symtab_users_cleanup): Replace forward declaration with
12089         a FORWARD_SCOPE_EXIT.
12090         (syms_from_objfile_1): Use the forward_scope_exit and
12091         gdb::optional instead of cleanup_function.
12092         (reread_symbols): Use the forward_scope_exit instead of
12093         cleanup_function.
12094         (clear_symtab_users_cleanup): Remove function.
12095
12096 2019-01-23  Tom Tromey  <tom@tromey.com>
12097             Pedro Alves  <palves@redhat.com>
12098
12099         * linux-nat.c: Include scope-exit.h.
12100         (cleanup_target_stop): Remove.
12101         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12102         SCOPE_EXIT.
12103
12104 2019-01-23  Tom Tromey  <tom@tromey.com>
12105             Pedro Alves  <palves@redhat.com>
12106
12107         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12108         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12109
12110 2019-01-23  Tom Tromey  <tom@tromey.com>
12111             Andrew Burgess  <andrew.burgess@embecosm.com>
12112             Pedro Alves  <palves@redhat.com>
12113
12114         * infrun.c (fetch_inferior_event): Use scope_exit.
12115         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12116         * top.c (execute_command): Use scope_exit.
12117         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12118         * utils.c (do_bpstat_clear_actions_cleanup)
12119         (make_bpstat_clear_actions_cleanup): Remove.
12120
12121 2019-01-23  Tom Tromey  <tom@tromey.com>
12122             Pedro Alves  <palves@redhat.com>
12123
12124         * infrun.c: Include "common/scope-exit.h"
12125         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12126         (wait_for_inferior): Use SCOPE_EXIT.
12127         (fetch_inferior_event): Use scope_exit.
12128
12129 2019-01-23  Tom Tromey  <tom@tromey.com>
12130             Pedro Alves  <palves@redhat.com>
12131
12132         * breakpoint.c (create_breakpoint): Remove cleanup.
12133
12134 2019-01-23  Tom Tromey  <tom@tromey.com>
12135             Andrew Burgess  <andrew.burgess@embecosm.com>
12136             Pedro Alves  <palves@redhat.com>
12137
12138 2019-01-23  Pedro Alves  <palves@redhat.com>
12139
12140         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12141
12142 2019-01-23  Pedro Alves  <palves@redhat.com>
12143             Andrew Burgess  <andrew.burgess@embecosm.com>
12144
12145         * gdbthread.h: Include "common/forward-scope-exit.h".
12146         (scoped_finish_thread_state): Redefine custom class in terms of
12147         forward_scope_exit.
12148
12149 2019-01-23  Pedro Alves  <palves@redhat.com>
12150             Andrew Burgess  <andrew.burgess@embecosm.com>
12151
12152         * common/forward-scope-exit.h: New file.
12153
12154 2019-01-23  Pedro Alves  <palves@redhat.com>
12155             Andrew Burgess  <andrew.burgess@embecosm.com>
12156             Tom Tromey  <tom@tromey.com>
12157
12158         * common/scope-exit.h: New file.
12159
12160 2019-01-23  Pedro Alves  <palves@redhat.com>
12161
12162         * common/preprocessor.h (ESC): Rename to ...
12163         (ESC_PARENS): ... this.
12164         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12165         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12166
12167 2019-01-23  Tom Tromey  <tom@tromey.com>
12168
12169         * language.h (class scoped_switch_to_sym_language_if_auto):
12170         Initialize m_lang in both cases.
12171
12172 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12173
12174         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12175         with XCNEW.
12176
12177 2019-01-22  Tom Tromey  <tom@tromey.com>
12178
12179         * corelow.c: Do not include sys/file.h.
12180
12181 2019-01-22  Tom Tromey  <tom@tromey.com>
12182
12183         * tui/tui-wingeneral.h: Include gdb_curses.h.
12184
12185 2019-01-22  Tom Tromey  <tom@tromey.com>
12186
12187         * source-cache.h (class source_cache) <get_source_lines,
12188         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12189
12190 2019-01-22  Tom Tromey  <tom@tromey.com>
12191
12192         * remote-fileio.h (struct remote_target): Declare.
12193
12194 2019-01-22  Tom Tromey  <tom@tromey.com>
12195
12196         * python/py-arch.c: Do not include py-ref.h.
12197         * python/py-bpevent.c: Do not include py-ref.h.
12198         * python/py-cmd.c: Do not include py-ref.h.
12199         * python/py-continueevent.c: Do not include py-ref.h.
12200         * python/py-event.h: Do not include py-ref.h.
12201         * python/py-evtregistry.c: Do not include py-ref.h.
12202         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12203         * python/py-frame.c: Do not include py-ref.h.
12204         * python/py-framefilter.c: Do not include py-ref.h.
12205         * python/py-function.c: Do not include py-ref.h.
12206         * python/py-infevents.c: Do not include py-ref.h.
12207         * python/py-linetable.c: Do not include py-ref.h.
12208         * python/py-objfile.c: Do not include py-ref.h.
12209         * python/py-param.c: Do not include py-ref.h.
12210         * python/py-prettyprint.c: Do not include py-ref.h.
12211         * python/py-progspace.c: Do not include py-ref.h.
12212         * python/py-symbol.c: Do not include py-ref.h.
12213         * python/py-symtab.c: Do not include py-ref.h.
12214         * python/py-type.c: Do not include py-ref.h.
12215         * python/py-unwind.c: Do not include py-ref.h.
12216         * python/py-utils.c: Do not include py-ref.h.
12217         * python/py-value.c: Do not include py-ref.h.
12218         * python/py-varobj.c: Do not include py-ref.h.
12219         * python/py-xmethods.c: Do not include py-ref.h.
12220         * python/python.c: Do not include py-ref.h.
12221         * varobj.c: Do not include py-ref.h.
12222
12223 2019-01-22  Tom Tromey  <tom@tromey.com>
12224
12225         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12226         keyword for bcache.
12227
12228 2019-01-22  Tom Tromey  <tom@tromey.com>
12229
12230         * compile/compile-cplus-types.c: Remove a comment by #include.
12231
12232 2019-01-22  Tom Tromey  <tom@tromey.com>
12233
12234         * compile/gcc-c-plugin.h: Include compile-internal.h.
12235
12236 2019-01-22  Tom Tromey  <tom@tromey.com>
12237
12238         * stabsread.c (EXTERN): Do not define.
12239         (symnum, next_symbol_text_func, processing_gcc_compilation)
12240         (within_function, global_sym_chain, global_stabs)
12241         (previous_stab_code, this_object_header_files)
12242         (n_this_object_header_files)
12243         (n_allocated_this_object_header_files): Define.
12244         * stabsread.h (EXTERN): Never define.  Use "extern".
12245
12246 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12247
12248         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12249         history_value.
12250
12251 2019-01-21  Tom Tromey  <tom@tromey.com>
12252
12253         * ui-out.c: Fix includes.
12254         * tui/tui-source.c: Fix includes.
12255         * target.c: Fix includes.
12256         * remote.c: Fix includes.
12257         * regcache.c: Fix includes.
12258         * python/py-block.c: Fix includes.
12259         * printcmd.c: Fix includes.
12260         * or1k-tdep.c: Fix includes.
12261         * mi/mi-main.c: Fix includes.
12262         * m32r-tdep.c: Fix includes.
12263         * csky-tdep.c: Fix includes.
12264         * compile/compile-cplus-types.c: Fix includes.
12265         * cli/cli-interp.c: Fix includes.
12266
12267 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12268
12269         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12270         for padding.
12271
12272 2019-01-16  Tom Tromey  <tom@tromey.com>
12273
12274         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12275         earlier.
12276         (struct objfile) <msymbols_range>: Move from top level.
12277         <msymbols>: New method.
12278         (class objfile_msymbols): Remove.
12279         * symtab.c (default_collect_symbol_completion_matches_break_on):
12280         Update.
12281         * symmisc.c (dump_msymbols): Update.
12282         * stabsread.c (scan_file_globals): Update.
12283         * objc-lang.c (info_selectors_command, info_classes_command)
12284         (find_methods): Update.
12285         * minsyms.c (find_solib_trampoline_target): Update.
12286         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12287         * coffread.c (coff_symfile_read): Update.
12288         * ada-lang.c (ada_lookup_simple_minsym)
12289         (ada_collect_symbol_completion_matches): Update.
12290
12291 2019-01-16  Tom Tromey  <tom@tromey.com>
12292
12293         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12294         type.  Remove no-argument constructor.
12295         <iterator::operator++>: Simplify.
12296         <begin>: Update.
12297         <end>: Use minimal_symbol_count.
12298
12299 2019-01-16  Tom Tromey  <tom@tromey.com>
12300
12301         * objfiles.h (struct objfile) <psymtabs>: New method.
12302         (class objfile_psymtabs): Remove.
12303         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12304         typedef.
12305         <range>: New method.
12306         (require_partial_symbols): Change return type.
12307         * psymtab.c (require_partial_symbols)
12308         (psym_expand_symtabs_matching): Update.
12309         * mdebugread.c (parse_partial_symbols): Update.
12310         * dbxread.c (dbx_end_psymtab): Update.
12311
12312 2019-01-15  Tom Tromey  <tom@tromey.com>
12313
12314         * symtab.c (lookup_objfile_from_block)
12315         (lookup_symbol_in_objfile_symtabs)
12316         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12317         (find_line_symtab, info_sources_command)
12318         (default_collect_symbol_completion_matches_break_on)
12319         (make_source_files_completion_list): Update.
12320         * symmisc.c (print_objfile_statistics, dump_objfile)
12321         (maintenance_print_symbols, maintenance_info_symtabs)
12322         (maintenance_check_symtabs, maintenance_info_line_tables):
12323         Update.
12324         * source.c (select_source_symtab)
12325         (forget_cached_source_info_for_objfile): Update.
12326         * objfiles.h (class objfile_compunits): Remove.
12327         (struct objfile) <compunits_range>: New typedef.
12328         (compunits): New method.
12329         * objfiles.c (objfile_relocate1): Update.
12330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12331         * maint.c (count_symtabs_and_blocks): Update.
12332         * linespec.c (iterate_over_all_matching_symtabs): Update.
12333         * cp-support.c (add_symbol_overload_list_qualified): Update.
12334         * coffread.c (coff_symtab_read): Update.
12335         * ada-lang.c (add_nonlocal_symbols)
12336         (ada_collect_symbol_completion_matches)
12337         (ada_add_global_exceptions): Update.
12338
12339 2019-01-15  Tom Tromey  <tom@tromey.com>
12340
12341         * progspace.h (program_space) <objfiles_safe_range>: New
12342         typedef.
12343         <objfiles_safe>: New method.
12344         * objfiles.h (class all_objfiles_safe): Remove.
12345         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12346         * jit.c (jit_inferior_exit_hook): Update.
12347
12348 2019-01-17  Tom Tromey  <tom@tromey.com>
12349
12350         * progspace.h (program_space) <objfiles_range>: New typedef.
12351         <objfiles>: New method.
12352         <objfiles_head>: Rename from objfiles.
12353         (object_files): Update.
12354         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12355         * guile/scm-pretty-print.c
12356         (ppscm_find_pretty_printer_from_objfiles): Update.
12357         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12358         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12359         Update.
12360         * python/py-progspace.c (pspy_get_objfiles): Update.
12361         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12362         Update.
12363         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12364         (objfpy_lookup_objfile_by_build_id): Update.
12365         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12366         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12367         Update.
12368         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12369         (expand_symtab_containing_pc, lookup_objfile_from_block)
12370         (lookup_static_symbol, basic_lookup_transparent_type)
12371         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12372         (find_line_symtab, info_sources_command)
12373         (default_collect_symbol_completion_matches_break_on)
12374         (make_source_files_completion_list, find_main_name): Update.
12375         * symmisc.c (print_symbol_bcache_statistics)
12376         (print_objfile_statistics, maintenance_print_symbols)
12377         (maintenance_print_msymbols, maintenance_print_objfiles)
12378         (maintenance_info_symtabs, maintenance_check_symtabs)
12379         (maintenance_expand_symtabs, maintenance_info_line_tables):
12380         Update.
12381         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12382         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12383         (map_overlay_command, unmap_overlay_command)
12384         (simple_overlay_update, expand_symtabs_matching)
12385         (map_symbol_filenames): Update.
12386         * symfile-debug.c (set_debug_symfile): Update.
12387         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12388         Update.
12389         * source.c (select_source_symtab, forget_cached_source_info):
12390         Update.
12391         * solib.c (solib_read_symbols): Update.
12392         * solib-spu.c (append_ocl_sos): Update.
12393         * psymtab.c (maintenance_print_psymbols)
12394         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12395         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12396         * printcmd.c (info_symbol_command): Update.
12397         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12398         Update.
12399         * objfiles.h (class all_objfiles): Remove.
12400         * objfiles.c (have_partial_symbols, have_full_symbols)
12401         (have_minimal_symbols, qsort_cmp, update_section_map)
12402         (shared_objfile_contains_address_p)
12403         (default_iterate_over_objfiles_in_search_order): Update.
12404         * objc-lang.c (info_selectors_command, info_classes_command)
12405         (find_methods): Update.
12406         * minsyms.c (find_solib_trampoline_target): Update.
12407         * maint.c (maintenance_info_sections)
12408         (maintenance_translate_address, count_symtabs_and_blocks):
12409         Update.
12410         * main.c (captured_main_1): Update.
12411         * linux-thread-db.c (try_thread_db_load_from_pdir)
12412         (has_libpthread): Update.
12413         * linespec.c (iterate_over_all_matching_symtabs)
12414         (search_minsyms_for_name): Update.
12415         * jit.c (jit_find_objf_with_entry_addr): Update.
12416         * hppa-tdep.c (find_unwind_entry)
12417         (hppa_lookup_stub_minimal_symbol): Update.
12418         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12419         Update.
12420         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12421         (elf_gnu_ifunc_resolve_by_got): Update.
12422         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12423         * dwarf-index-write.c (save_gdb_index_command): Update.
12424         * cp-support.c (add_symbol_overload_list_qualified): Update.
12425         * breakpoint.c (create_overlay_event_breakpoint)
12426         (create_longjmp_master_breakpoint)
12427         (create_std_terminate_master_breakpoint)
12428         (create_exception_master_breakpoint): Update.
12429         * blockframe.c (find_pc_partial_function): Update.
12430         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12431         (ada_collect_symbol_completion_matches)
12432         (ada_add_global_exceptions): Update.
12433
12434 2019-01-17  Tom Tromey  <tom@tromey.com>
12435
12436         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12437         declare VEC.
12438         (solib_target_parse_libraries): Change return type.
12439         (library_list_start_segment, library_list_start_section)
12440         (library_list_end_library, library_list_start_library); Update.
12441         (solib_target_free_library_list): Remove.
12442         (solib_target_parse_libraries): Remove cleanup.  Change return
12443         type.
12444         (solib_target_current_sos): Update.
12445
12446 2019-01-17  Tom Tromey  <tromey@bapiya>
12447
12448         * valprint.c: Replace "the the" with "the".
12449         * symtab.c: Replace "the the" with "the".
12450         * solib.c: Replace "the the" with "the".
12451         * solib-dsbt.c: Replace "the the" with "the".
12452         * linespec.c: Replace "the the" with "the".
12453         * dwarf2loc.h: Replace "the the" with "the".
12454         * amd64-windows-tdep.c: Replace "the the" with "the".
12455         * aarch64-tdep.c: Replace "the the" with "the".
12456
12457 2019-01-16  Keith Seitz  <keiths@redhat.com>
12458
12459         PR gdb/23773
12460         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12461         <builder>: Rename to ..
12462         <m_builder>: ... this and make private.
12463         (dwarf2_cu::get_builder): New method.  Change all users of
12464         `builder' to use this method.
12465         (dwarf2_start_symtab): Move to ...
12466         (dwarf2_cu::start_symtab): ... here.  Update all callers
12467         (setup_type_unit_groups): Move to ...
12468         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12469         callers.
12470         (dwarf2_cu::reset_builder): New method.
12471         (process_full_compunit, process_full_type_unit): Use
12472         dwarf2_cu::reset_builder.
12473         (follow_die_offset): Record the ancestor CU if it is different
12474         from the followed DIE's CU.
12475         (follow_die_sig_1): Likewise.
12476
12477 2019-01-15  Tom Tromey  <tom@tromey.com>
12478
12479         * remote.c (class remote_state) <buf>: Now a char_vector.
12480         <buf_size>: Remove.
12481         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12482         parameter.
12483         (remote_target::getpkt_or_notif_sane_1)
12484         (remote_target::getpkt_sane)
12485         (remote_target::getpkt_or_notif_sane): Likewise.
12486         (class remote_target) <putpkt>: New overload.
12487         (remote_target::read_frame): Change type of "buf_p".  Remove
12488         sizeof_p parameter.
12489         (packet_ok): New overload.
12490         (packet_check_result): New overload.
12491         Update all uses.
12492
12493 2019-01-14  Tom Tromey  <tom@tromey.com>
12494
12495         * remote-notif.c (handle_notification, remote_notif_ack)
12496         (remote_notif_parse): Make "buf" const.
12497         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12498         const.
12499         (remote_notif_parse, remote_notif_ack, handle_notification):
12500         Likewise.
12501         * remote.c (remote_notif_stop_parse): Make "buf" const.
12502         (remote_target::remote_parse_stop_reply): Make "buf" const.
12503         (remote_notif_stop_ack): Make "buf" const.
12504
12505 2019-01-14  Tom Tromey  <tom@tromey.com>
12506
12507         * remote.c (remote_console_output): Make parameter const.
12508
12509 2019-01-14  Tom Tromey  <tom@tromey.com>
12510
12511         * target-debug.h (target_debug_print_signals): Constify.
12512         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12513         * procfs.c (procfs_target::pass_signals): Update.
12514         * linux-nat.c (linux_nat_target::pass_signals): Update.
12515         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12516         * target-delegates.c: Rebuild.
12517         * remote.c (remote_target::program_signals): Update.
12518         (remote_target::pass_signals): Update.
12519         * target.c (target_pass_signals): Constify argument.
12520         (target_program_signals): Likewise.
12521         * target.h (struct target_ops) <pass_signals, program_signals>:
12522         Constify argument.
12523         (target_pass_signals, target_program_signals): Constify argument.
12524
12525 2019-01-14  Tom Tromey  <tom@tromey.com>
12526
12527         PR tui/28819:
12528         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12529
12530 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12531
12532         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12533         field.
12534         * rs6000-tdep.c: Include reggroups.h.
12535         (IS_V_ALIAS_PSEUDOREG): Define.
12536         (rs6000_register_name): Return names for the "vX" aliases.
12537         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12538         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12539         aliases.  Call default_register_reggroup_p for all other
12540         pseudo-registers.
12541         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12542         New functions.
12543         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12544         Handle "vX" aliases.
12545         (v_alias_pseudo_register_collect): New function.
12546         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12547         (rs6000_gdbarch_init): Initialize "vX" aliases as
12548         pseudo-registers.  Restore registration of
12549         rs6000_pseudo_register_reggroup_p with
12550         set_tdesc_pseudo_register_reggroup_p.
12551
12552 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12553
12554         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12555         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12556         set_gdbarch_num_pseudo_regs.
12557
12558 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12559
12560         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12561         Remove arg prefixname, add do_set and do_show.
12562         Add member functions set_list and show_list.
12563         * cli/cli-style.c (class cli_style_option): Update accordingly.
12564         (style_set_list): Move to file scope.
12565         (style_show_list): Likewise.
12566         (set_style): Call help_list.
12567         (show_style): Call cmd_show_list.
12568         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12569         Update to use the new macro.
12570
12571 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12572
12573         * ada-lang.c (_initialize_ada_language): Expand the help text
12574         for the "catch exception" command.
12575
12576 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12577
12578         * symtab.c (matching_obj_sections): Initialize obj,
12579         declare it closer to its usage.
12580
12581 2019-01-10  Tom Tromey  <tom@tromey.com>
12582
12583         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12584         (basic_inf_threads_range): Remove.
12585         (inf_threads_range, inf_non_exited_threads_range)
12586         (safe_inf_threads_range): Use next_adapter.
12587
12588 2019-01-10  Keith Seitz  <keiths@redhat.com>
12589
12590         PR gdb/23712
12591         PR symtab/23010
12592         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12593         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12594
12595 2019-01-10  Keith Seitz  <keiths@redhat.com>
12596
12597         PR gdb/23712
12598         PR symtab/23010
12599         * dictionary.c (pending_to_vector): Remove.
12600         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12601         Remove _1 suffix, replacing functions of the same name.  Update
12602         all callers.
12603         (dict_create_hashed, dict_create_hashed_expandable)
12604         (dict_create_linear, dict_create_linear_expandable, dict_free)
12605         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12606         Make functions static.
12607
12608 2019-01-10  Keith Seitz  <keiths@redhat.com>
12609
12610         PR gdb/23712
12611         PR symtab/23010
12612         * dictionary.h (struct dictionary): Replace declaration with
12613         multidictionary.
12614         (dict_create_hashed, dict_create_hashed_expandable)
12615         (dict_create_linear, dict_create_linear_expandable)
12616         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12617         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12618         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12619         taking multidictionary argument.
12620         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12621         * block.h (struct block) <dict>: Change to multidictionary
12622         and rename `multidict'.
12623         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12624         symmisc.c: Update all dictionary references to multidictionary.
12625
12626 2019-01-10  Keith Seitz  <keiths@redhat.com>
12627
12628         PR gdb/23712
12629         PR symtab/23010
12630         * dictionary.c: Include unordered_map.
12631         (pending_to_vector): New function.
12632         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12633         Rewrite the non-"_1" functions to take vector instead
12634         of linked list.
12635         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12636         "new" _1 versions of the same name.
12637         (multidictionary): Define.
12638         (std::hash<enum language): New definition.
12639         (collate_pending_symbols_by_language, mdict_create_hashed)
12640         (mdict_create_hashed_expandable, mdict_create_linear)
12641         (mdict_create_linear_expandable, mdict_free)
12642         (find_language_dictionary, create_new_language_dictionary)
12643         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12644         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12645         (mdict_size, mdict_empty): New functions.
12646         * dictionary.h (mdict_iterator): Define.
12647
12648 2019-01-10  Pedro Alves  <palves@redhat.com>
12649
12650         * breakpoint.c (read_uploaded_action)
12651         (create_tracepoint_from_upload): Adjust to use
12652         gdb::unique_xmalloc_ptr.
12653         * ctf.c (ctf_write_uploaded_tp):
12654         (SET_ARRAY_FIELD): Use emplace_back.
12655         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12656         * tracefile-tfile.c (tfile_write_uploaded_tp):
12657         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12658         gdb::unique_xmalloc_ptr.
12659         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12660         at_string, cond_string, cmd_strings>: Replace char pointers
12661         with gdb::unique_xmalloc_ptr.
12662
12663 2019-01-10  Pedro Alves  <palves@redhat.com>
12664
12665         * solib-target.c (library_list_start_library): Don't xstrdup name.
12666
12667 2019-01-10  Pedro Alves  <palves@redhat.com>
12668
12669         * mdebugread.c (parse_partial_symbols): Use
12670         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12671
12672 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12673
12674         * linux-fork.c (scoped_switch_fork_info)
12675         <~scoped_switch_fork_info>: Fix incorrect variable name.
12676
12677 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12678
12679         * linux-fork.c (scoped_switch_fork_info)
12680         <scoped_switch_fork_info>: Make explicit.
12681         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12682
12683 2019-01-10  Tom Tromey  <tom@tromey.com>
12684
12685         * objfiles.h (objfile::reset_psymtabs): Update.
12686         * objfiles.c (objfile::objfile): Update.
12687         * psymtab.h (psymtab_storage::obstack): Update.
12688         (psymtab_storage::m_obstack): Use gdb::optional.
12689         (class psymtab_storage): Update comment.  Remove objfile
12690         parameter.
12691         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12692
12693 2019-01-10  Tom Tromey  <tom@tromey.com>
12694
12695         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12696         <free_psymtabs>: Now private.
12697         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12698         (allocate_psymtab): Use new method.
12699
12700 2019-01-10  Tom Tromey  <tom@tromey.com>
12701
12702         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12703         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12704         * mdebugread.c (parse_partial_symbols): Use
12705         allocate_dependencies.
12706         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12707         allocate_dependencies.
12708         (process_psymtab_comp_unit_reader)
12709         (build_type_psymtab_dependencies): Likewise.
12710         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12711
12712 2019-01-10  Tom Tromey  <tom@tromey.com>
12713
12714         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12715         PSYMBOL_SET_LANGUAGE.
12716         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12717
12718 2019-01-10  Tom Tromey  <tom@tromey.com>
12719
12720         * psymtab.h (psymtab_storage::obstack): New method.
12721         <m_obstack>: Rename from obstack; now private.
12722         * psymtab.c (psymtab_storage): Update.
12723         * dwarf2read.c (create_addrmap_from_index)
12724         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12725         Update.
12726
12727 2019-01-10  Tom Tromey  <tom@tromey.com>
12728
12729         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12730         * objfiles.h (objfile::reset_psymtabs): New method.
12731
12732 2019-01-10  Tom Tromey  <tom@tromey.com>
12733
12734         * symmisc.c (print_symbol_bcache_statistics): Update.
12735         (print_objfile_statistics): Update.
12736         * symfile.c (reread_symbols): Update.
12737         * psymtab.h (class psymtab_storage): New.
12738         * psymtab.c (psymtab_storage): New constructor.
12739         (~psymtab_storage): New destructor.
12740         (require_partial_symbols): Update.
12741         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12742         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12743         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12744         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12745         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12746         (start_psymtab_common, end_psymtab_common)
12747         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12748         (allocate_psymtab): Update.
12749         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12750         Update.
12751         (dump_psymtab_addrmap, maintenance_print_psymbols)
12752         (maintenance_check_psymtabs): Update.
12753         (class objfile_psymtabs): Move to objfiles.h.
12754         * psympriv.h (discard_psymtab): Now inline.
12755         (psymtab_discarder::psymtab_discarder): Update.
12756         (psymtab_discarder::~psymtab_discarder): Update.
12757         (ALL_OBJFILE_PSYMTABS): Rewrite.
12758         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12759         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12760         Remove fields.
12761         <partial_symtabs>: New field.
12762         (class objfile_psymtabs): Move from psymtab.h.  Update.
12763         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12764         psymbol_cache.
12765         (objfile::~objfile): Don't destroy psymbol_cache.
12766         * mdebugread.c (parse_partial_symbols): Update.
12767         * dwarf2read.c (create_addrmap_from_index)
12768         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12769         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12770         (add_partial_subprogram, dwarf2_ranges_read): Update.
12771         * dwarf-index-write.c (write_address_map)
12772         (write_one_signatured_type, recursively_write_psymbols)
12773         (class debug_names, class debug_names, write_psymtabs_to_index):
12774         Update.
12775
12776 2019-01-10  Tom Tromey  <tom@tromey.com>
12777
12778         * symtab.h (SYMBOL_SET_NAMES): Update.
12779         (symbol_set_names): Update.
12780         (MSYMBOL_SET_NAMES): Update.
12781         * symtab.c (symbol_set_names): Change argument to be an
12782         objfile_per_bfd_storage.
12783         * psymtab.c (add_psymbol_to_bcache): Update.
12784         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12785
12786 2019-01-10  Tom Tromey  <tom@tromey.com>
12787
12788         * symtab.c (create_demangled_names_hash): Change argument to be an
12789         objfile_per_bfd_storage.
12790         (symbol_set_names): Update.
12791
12792 2019-01-10  Tom Tromey  <tom@tromey.com>
12793
12794         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12795         init_psymbol_list.
12796         * psymtab.c (init_psymbol_list): Do nothing if already called.
12797         * psympriv.h (init_psymbol_list): Add comment.
12798         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12799         init_psymbol_list.
12800         * dbxread.c (dbx_symfile_read): Unconditionally call
12801         init_psymbol_list.
12802
12803 2019-01-10  Tom Tromey  <tom@tromey.com>
12804
12805         * xcoffread.c (scan_xcoff_symtab): Update.
12806         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12807         "where".
12808         * mdebugread.c (parse_partial_symbols)
12809         (handle_psymbol_enumerators): Update.
12810         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12811         * dbxread.c (read_dbx_symtab): Update.
12812         * psympriv.h (psymbol_placement): New enum.
12813         (add_psymbol_to_list): Update.
12814
12815 2019-01-10  Tom Tromey  <tom@tromey.com>
12816
12817         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12818         static_psymbols parameters.
12819         (scan_xcoff_symtab): Update.
12820         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12821         static_psymbols parameters.
12822         * psympriv.h (start_psymtab_common): Update.
12823         * mdebugread.c (parse_partial_symbols): Update.
12824         * dwarf2read.c (create_partial_symtab): Update.
12825         * dbxread.c (read_dbx_symtab): Update.
12826         (start_psymtab): Remove global_psymbols and static_psymbols
12827         parameters.
12828
12829 2019-01-10  Tom Tromey  <tom@tromey.com>
12830
12831         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12832         * psymtab.c (allocate_psymtab): Add comment.
12833         * psympriv.h (allocate_psymtab): Add comment.
12834         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12835         initializations.
12836         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12837
12838 2019-01-10  Tom Tromey  <tom@tromey.com>
12839
12840         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12841         Don't declare.
12842         * mipsread.c: Include mdebugread.h.
12843         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12844         Declare.
12845         * elfread.c: Include mdebugread.h.
12846
12847 2019-01-09  Tom Tromey  <tom@tromey.com>
12848
12849         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12850         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12851         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12852         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12853         (psym_lookup_symbol, psym_find_last_source_symtab)
12854         (psym_forget_cached_source_info, psym_print_stats)
12855         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12856         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12857         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12858         (psym_find_compunit_symtab_by_address)
12859         (maintenance_print_psymbols, maintenance_info_psymtabs)
12860         (maintenance_check_psymtabs): Use ranged for.
12861         * psymtab.h (class objfile_psymtabs): New.
12862         (require_partial_symbols): Return objfile_psymtabs.
12863         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12864
12865 2019-01-09  Tom Tromey  <tom@tromey.com>
12866
12867         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12868         (find_pc_mapped_section, list_overlays_command)
12869         (map_overlay_command, unmap_overlay_command)
12870         (simple_overlay_update): Use all_objfiles.
12871         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12872         * printcmd.c (info_symbol_command): Use all_objfiles.
12873         * objfiles.h (ALL_OBJSECTIONS): Remove.
12874         * maint.c (maintenance_translate_address): Use all_objfiles.
12875         * gcore.c (gcore_create_callback): Use all_objfiles.
12876         (objfile_find_memory_regions): Likewise.
12877
12878 2019-01-09  Tom Tromey  <tom@tromey.com>
12879
12880         * symtab.c (find_line_symtab, info_sources_command)
12881         (make_source_files_completion_list): Use objfile_compunits.
12882         * source.c (select_source_symtab): Use objfile_compunits.
12883         * objfiles.h (struct objfile): Update comment.
12884         (ALL_OBJFILES): Remove.
12885         (ALL_FILETABS): Remove.
12886         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12887         objfile_compunits.
12888
12889 2019-01-09  Tom Tromey  <tom@tromey.com>
12890
12891         * symmisc.c (print_objfile_statistics, dump_objfile)
12892         (maintenance_print_symbols): Use compunit_filetabs.
12893         * source.c (forget_cached_source_info_for_objfile): Use
12894         compunit_filetabs.
12895         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12896         (ALL_FILETABS): Use compunit_filetabs.
12897         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12898         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12899
12900 2019-01-09  Tom Tromey  <tom@tromey.com>
12901
12902         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12903         (compunit_filetabs): New.
12904         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12905         compunit_filetabs.
12906         (info_sources_command, make_source_files_completion_list): Remove
12907         declaration.
12908         * symmisc.c (print_objfile_statistics, dump_objfile)
12909         (maintenance_print_symbols): Remove declaration.
12910         (maintenance_info_symtabs): Use compunit_filetabs.
12911         (maintenance_info_line_tables): Likewise.
12912         * source.c (select_source_symtab): Change local variable name.
12913         (forget_cached_source_info_for_objfile): Remove declaration.
12914         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12915         * objfiles.c (objfile_relocate1): Remove declaration.
12916         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12917         declaration.
12918         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12919         * coffread.c (coff_symtab_read): Remove declaration.
12920         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12921         compunit_filetabs.
12922
12923 2019-01-09  Tom Tromey  <tom@tromey.com>
12924
12925         * symtab.c (lookup_objfile_from_block)
12926         (find_pc_sect_compunit_symtab, search_symbols)
12927         (default_collect_symbol_completion_matches_break_on): Use
12928         objfile_compunits.
12929         * objfiles.h (ALL_COMPUNITS): Remove.
12930         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12931         * cp-support.c (add_symbol_overload_list_qualified): Use
12932         objfile_compunits.
12933         * ada-lang.c (ada_collect_symbol_completion_matches)
12934         (ada_add_global_exceptions): Use objfile_compunits.
12935
12936 2019-01-09  Tom Tromey  <tom@tromey.com>
12937
12938         * source.c (select_source_symtab)
12939         (forget_cached_source_info_for_objfile): Remove declaration.
12940         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12941         declaration.
12942         * maint.c (count_symtabs_and_blocks): Remove declaration.
12943         * cp-support.c (add_symbol_overload_list_qualified): Remove
12944         declaration.
12945         * coffread.c (coff_symtab_read): Remove declaration.
12946         * symtab.c (lookup_symbol_in_objfile_symtabs)
12947         (basic_lookup_transparent_type_1): Use objfile_compunits.
12948         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12949         (info_sources_command, search_symbols)
12950         (default_collect_symbol_completion_matches_break_on)
12951         (make_source_files_completion_list): Remove declaration.
12952         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12953         (ada_collect_symbol_completion_matches)
12954         (ada_add_global_exceptions): Remove declaration.
12955         * linespec.c (iterate_over_all_matching_symtabs): Use
12956         objfile_compunits.
12957         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12958         (class objfile_compunits): New.
12959         (ALL_COMPUNITS): Use objfile_compunits.
12960         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12961         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12962         objfile_compunits.
12963         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12964
12965 2019-01-09  Tom Tromey  <tom@tromey.com>
12966
12967         * symtab.c (search_symbols)
12968         (default_collect_symbol_completion_matches_break_on): Use
12969         objfile_msymbols.
12970         * ada-lang.c (ada_lookup_simple_minsym)
12971         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12972         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12973         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12974         objfile_msymbols.
12975         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12976         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12977         * objc-lang.c (find_methods): Use objfile_msymbols.
12978         (info_selectors_command, info_classes_command): Likewise.
12979         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12980         * objfiles.h (class objfile_msymbols): New.
12981         (ALL_OBJFILE_MSYMBOLS): Remove.
12982         (ALL_MSYMBOLS): Remove.
12983
12984 2019-01-09  Tom Tromey  <tom@tromey.com>
12985
12986         * common/next-iterator.h (next_adapter): Add Iterator template
12987         parameter.
12988         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12989         (class all_objfiles_safe): New.
12990         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12991         * objfiles.c (put_objfile_before): Update comment.
12992         (add_separate_debug_objfile): Likewise.
12993         (free_all_objfiles): Use all_objfiles_safe.
12994         (objfile_purge_solibs): Likewise.
12995
12996 2019-01-09  Tom Tromey  <tom@tromey.com>
12997
12998         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12999         (expand_symtab_containing_pc, lookup_static_symbol)
13000         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13001         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13002         all_objfiles.
13003         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13004         * breakpoint.c (create_overlay_event_breakpoint)
13005         (create_longjmp_master_breakpoint)
13006         (create_std_terminate_master_breakpoint)
13007         (create_exception_master_breakpoint): Use all_objfiles.
13008         * linux-thread-db.c (try_thread_db_load_from_pdir)
13009         (has_libpthread): Use all_objfiles.
13010         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13011         * linespec.c (iterate_over_all_matching_symtabs)
13012         (search_minsyms_for_name): Use all_objfiles.
13013         * maint.c (maintenance_info_sections): Use all_objfiles.
13014         * main.c (captured_main_1): Use all_objfiles.
13015         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13016         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13017         * guile/scm-pretty-print.c
13018         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13019         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13020         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13021         (maintenance_print_msymbols): Use all_objfiles.
13022         * source.c (select_source_symtab): Use all_objfiles.
13023         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13024         * symfile.c (remove_symbol_file_command)
13025         (expand_symtabs_matching, map_symbol_filenames): Use
13026         all_objfiles.
13027         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13028         all_objfiles.
13029         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13030         * objc-lang.c (find_methods): Use all_objfiles.
13031         * objfiles.c (have_partial_symbols, have_full_symbols)
13032         (have_minimal_symbols, qsort_cmp)
13033         (default_iterate_over_objfiles_in_search_order): Use
13034         all_objfiles.
13035         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13036         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13037         (maintenance_check_psymtabs): Use all_objfiles.
13038         (ALL_PSYMTABS): Remove.
13039         * compile/compile-object-run.c (do_module_cleanup): Use
13040         all_objfiles.
13041         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13042         * cp-support.c (add_symbol_overload_list_qualified): Use
13043         all_objfiles.
13044         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13045         Use all_objfiles.
13046         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13047         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13048         all_objfiles.
13049         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13050         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13051         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13052         Uses all_objfiles.
13053         * solib.c (solib_read_symbols): Use all_objfiles
13054
13055 2019-01-09  Tom Tromey  <tom@tromey.com>
13056
13057         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13058         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13059         all_objfiles.
13060         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13061         * symmisc.c (print_symbol_bcache_statistics)
13062         (print_objfile_statistics, maintenance_print_objfiles)
13063         (maintenance_info_symtabs, maintenance_check_symtabs)
13064         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13065         all_objfiles.
13066         * source.c (forget_cached_source_info): Use all_objfiles.
13067         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13068         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13069         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13070         * objfiles.c (update_section_map): Use all_objfiles.
13071         (shared_objfile_contains_address_p): Likewise.
13072         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13073         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13074
13075 2019-01-09  Tom Tromey  <tom@tromey.com>
13076
13077         * common/next-iterator.h: New file.
13078         * objfiles.h (class all_objfiles): New.
13079         (struct objfile_iterator): New.
13080
13081 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13082
13083         * NEWS: Move the description of the changed "frame", "select-frame",
13084          and "info frame" commands to the Changed commands section.
13085
13086 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13087
13088         * gdbtypes.c (check_stub_method_group): Remove handling of old
13089         mangling schemes.
13090         * linespec.c (find_methods): Likewise.
13091         * stabsread.c (read_member_functions): Likewise.
13092         * valops.c (search_struct_method): Likewise.
13093         (value_struct_elt_for_reference): Likewise.
13094         * NEWS: Mention this change.
13095
13096 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13097
13098         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13099         print_source_lines.
13100         * source.c (print_source_lines_base): Update line number check.
13101         (print_source_lines): New function.
13102         (source_lines_range::source_lines_range): New function.
13103         * source.h (class source_lines_range): New class.
13104         (print_source_lines): New declaration.
13105
13106 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13107
13108         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13109
13110 2019-01-08  Tom Tromey  <tom@tromey.com>
13111             Simon Marchi  <simon.marchi@ericsson.com>
13112
13113         PR gdb/24060
13114         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13115         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13116         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13117         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13118         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13119         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13120
13121 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13122
13123         * source.c (select_source_symtab): Move header comment to
13124         declaration in source.h.
13125         (forget_cached_source_info_for_objfile): Likewise.
13126         (forget_cached_source_info): Likewise.
13127         (identify_source_line): Likewise.
13128         * source.h (identify_source_line): Move declaration from symtab.h
13129         and add comment from source.c
13130         (print_source_lines): Likewise.
13131         (forget_cached_source_info_for_objfile): Likewise.
13132         (forget_cached_source_info): Likewise.
13133         (select_source_symtab): Likewise.
13134         (enum print_source_lines_flag): Move definition from symtab.h.
13135         * symtab.h (identify_source_line): Move declaration to source.h.
13136         (print_source_lines): Likewise.
13137         (forget_cached_source_info_for_objfile): Likewise.
13138         (forget_cached_source_info): Likewise.
13139         (select_source_symtab): Likewise.
13140         (enum print_source_lines_flag): Move definition to source.h.
13141         * tui/tui-hooks.c: Add 'source.h' include.
13142
13143 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13144
13145         * source.c (print_source_lines_base): Handle requests to print
13146         reverse line number sequences, and guard against empty lines
13147         string.
13148
13149 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13150
13151         * source.c (print_source_lines_base): Fix skip of '\r' if next
13152         character is '\n'.
13153
13154 2019-01-06  Tom Tromey  <tom@tromey.com>
13155
13156         * c-exp.y (struct c_parse_state) <macro_original_text,
13157         expansion_obstack>: New member.
13158         (macro_original_text, expansion_obstack): Remove globals.
13159         (scan_macro_expansion, scanning_macro_expansion)
13160         (finished_macro_expansion): Update.
13161         (scan_macro_cleanup): Remove.
13162         (yylex, c_parse): Update.
13163
13164 2019-01-06  Tom Tromey  <tom@tromey.com>
13165
13166         * c-exp.y (struct c_parse_state) <strings>: New member.
13167         (operator_stoken): Update.
13168
13169 2019-01-06  Tom Tromey  <tom@tromey.com>
13170
13171         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13172         (union type_stack_elt) <typelist_val>: Now a pointer to
13173         std::vector.
13174         (type_stack_cleanup): Don't declare.
13175         (push_typelist): Update.
13176         * parse.c (pop_typelist): Return a std::vector.
13177         (push_typelist): Take a std::vector.
13178         (follow_types): Update.  Do not free args.
13179         (type_stack_cleanup): Remove.
13180         * c-exp.y (struct c_parse_state): New.
13181         (cpstate): New global.
13182         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13183         (nonempty_typelist): Update.
13184         (func_mod): Create a new vector.
13185         (c_parse): Create a c_parse_state.
13186         (check_parameter_typelist): Do not delete params.
13187         (function_method): Update.  Do not delete type_list.
13188
13189 2019-01-06  Tom Tromey  <tom@tromey.com>
13190
13191         PR gdb/28155:
13192         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13193         check_typedef.
13194         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13195         (print_return_value): Likewise.
13196
13197 2019-01-05  Tom Tromey  <tom@tromey.com>
13198
13199         * contrib/cleanup_check.py: Remove.
13200         * contrib/gcc-with-excheck: Remove.
13201         * contrib/exsummary.py: Remove.
13202         * contrib/excheck.py: Remove.
13203
13204 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13205
13206         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13207         NULL. Initialize tpprev to NULL instead of assigning it
13208         to NULL on the next statement.
13209         * windows-nat.c (windows_delete_thread): Remove check for
13210         main_thread_id before printing thread exit notifications.
13211         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13212         Remove thread ID check against main_thread_id.
13213         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13214         windows_delete_thread.
13215         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13216
13217 2019-01-04  Tom Tromey  <tom@tromey.com>
13218
13219         * compile/compile.c (_initialize_compile): Use upper case for
13220         metasyntactic variables.
13221         * symmisc.c (_initialize_symmisc): Use upper case for
13222         metasyntactic variables.
13223         * psymtab.c (_initialize_psymtab): Use upper case for
13224         metasyntactic variables.
13225         * demangle.c (demangle_command): Use upper case for metasyntactic
13226         variables.
13227         (_initialize_demangler): Likewise.
13228         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13229         variables.
13230
13231 2019-01-03  Tom Tromey  <tom@tromey.com>
13232
13233         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13234
13235 2019-01-03  Tom Tromey  <tom@tromey.com>
13236
13237         * python/py-symtab.c (salpy_str): Update.
13238         (struct salpy_sal_object) <symtab>: Now a PyObject.
13239         (salpy_dealloc): Update.
13240         (del_objfile_sal): Use gdbpy_ref.
13241
13242 2019-01-03  Tom Tromey  <tom@tromey.com>
13243
13244         * python/py-type.c (convert_field): Use new_reference.  Return
13245         gdbpy_ref.
13246         (make_fielditem): Return gdbpy_ref.
13247         (typy_fields): Update.
13248         (typy_getitem): Update.
13249         (field_name): Return gdbpy_ref.  Use new_reference.
13250         (typy_iterator_iternext): Update.
13251
13252 2019-01-03  Tom Tromey  <tom@tromey.com>
13253
13254         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13255
13256 2019-01-03  Tom Tromey  <tom@tromey.com>
13257
13258         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13259         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13260         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13261         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13262         (pspy_set_type_printers): Likewise.
13263         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13264         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13265         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13266         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13267         (objfpy_set_type_printers): Likewise.
13268
13269 2019-01-03  Tom Tromey  <tom@tromey.com>
13270
13271         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13272         (gdbpy_print_stack): Use gdbpy_err_fetch.
13273         * python/python-internal.h (class gdbpy_err_fetch): New class.
13274         (class gdbpy_enter) <m_error_type, m_error_value,
13275         m_error_traceback>: Remove.
13276         <m_error>: New member.
13277         (gdbpy_exception_to_string): Don't declare.
13278         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13279         * python/py-value.c (convert_value_from_python): Use
13280         gdbpy_err_fetch.
13281         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13282         gdbpy_exception_to_string.
13283         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13284         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13285         gdbpy_err_fetch.
13286
13287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13288
13289         * linux-nat.c (delete_lwp_cleanup): Delete.
13290         (struct lwp_deleter): New struct.
13291         (lwp_info_up): New typedef.
13292         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13293         lwp_info_up.
13294
13295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13296
13297         * linux-fork.c (class scoped_switch_fork_info): New class.
13298         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13299
13300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13301
13302         * valops.c (find_overload_match): Remove use of null_cleanup, and
13303         calls to do_cleanups.
13304
13305 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13306
13307         * compile/compile-cplus-types.c
13308         (compile_cplus_instance::decl_name): Handle changes to
13309         cp_func_name.
13310         * cp-support.c (cp_func_name): Update header comment, update
13311         return type.
13312         * cp-support.h (cp_func_name): Update return type in declaration.
13313         * valops.c (find_overload_match): Move temp_func local to top
13314         level of function and change its type.  Use temp_func to hold and
13315         delete temporary string obtained from cp_func_name.
13316
13317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13318
13319         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13320         gdb::char_vector, remove cleanup, and update uses of `msg`.
13321
13322 2019-01-03  Jim Wilson  <jimw@sifive.com>
13323
13324         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13325
13326 2019-01-02  Tom Tromey  <tom@tromey.com>
13327
13328         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13329         (tdesc_parse_xml): Remove cleanups.
13330         * target-descriptions.h (make_cleanup_free_target_description):
13331         Don't declare.
13332         (target_desc_deleter): New struct.
13333         (target_desc_up): New typedef.
13334         * target-descriptions.c (target_desc_deleter::operator()): Rename
13335         from free_target_description.
13336         (make_cleanup_free_target_description): Remove.
13337
13338 2019-01-02  Tom Tromey  <tom@tromey.com>
13339
13340         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13341         constructor, destructor.
13342         (linespec_parser): Remove typedef.
13343         (~linespec_parser): Rename from linespec_parser_delete.
13344         (linespec_lex_to_end, linespec_complete_label)
13345         (linespec_complete): Update.
13346         (decode_line_full): Remove cleanups.
13347         (decode_line_1): Update.
13348
13349 2019-01-02  Tom Tromey  <tom@tromey.com>
13350
13351         * python/python-internal.h (inferior_to_inferior_object): Change
13352         return type.
13353         * python/py-exitedevent.c (create_exited_event_object): Update.
13354         * python/py-inferior.c (inferior_to_inferior_object): Return
13355         gdbpy_ref.
13356         (python_new_inferior, python_inferior_deleted)
13357         (thread_to_thread_object, delete_thread_object)
13358         (build_inferior_list, gdbpy_selected_inferior): Update.
13359         * python/py-infthread.c (create_thread_object): Update.  Also fail
13360         if inferior_to_inferior_object fails.
13361
13362 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13363
13364         * inferior.h (class inferior) <displaced_step_state>: New field.
13365         * infrun.h (struct displaced_step_state): Move here from
13366         infrun.c.  Initialize fields, add constructor.
13367         <inf>: Remove field.
13368         <reset>: New method.
13369         * infrun.c (struct displaced_step_inferior_state): Move to
13370         infrun.h.
13371         (displaced_step_inferior_states): Remove.
13372         (get_displaced_stepping_state): Adust.
13373         (displaced_step_in_progress_any_inferior): Adjust.
13374         (displaced_step_in_progress_thread): Adjust.
13375         (displaced_step_in_progress): Adjust.
13376         (add_displaced_stepping_state): Remove.
13377         (get_displaced_step_closure_by_addr): Adjust.
13378         (remove_displaced_stepping_state): Remove.
13379         (infrun_inferior_exit): Call displaced_step_state.reset.
13380         (use_displaced_stepping): Don't check for NULL.
13381         (displaced_step_prepare_throw): Call
13382         get_displaced_stepping_state.
13383         (displaced_step_fixup): Don't check for NULL.
13384         (prepare_for_detach): Don't check for NULL.
13385
13386 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13387
13388         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13389          in case of call that did not complete.
13390
13391 2019-01-02  Andrey Utkin  <autkin@undo.io>
13392
13393         * symfile.c (find_separate_debug_file): Fix search of debug files for
13394         remote debuggee.
13395
13396 2019-01-02  Tom Tromey  <tom@tromey.com>
13397
13398         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13399         indentation.
13400         * python/py-frame.c (frapy_older): Remove cast.
13401         (frapy_newer): Likewise.
13402         * python/py-breakpoint.c (local_setattro): Remove cast.
13403         * python/py-arch.c (archpy_name): Remove local variable.
13404         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13405
13406 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13407
13408         * unittests/basic_string_view/element_access/char/empty.cc:
13409         Fix year range in copyright header.
13410
13411 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13412
13413         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13414         Delete.
13415         <operator==>: Update with for removed field.
13416         <hash>: Likewise.
13417         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13418         <isa_features>: ...this.
13419         <abi_features>: New field.
13420         (riscv_isa_flen): Update comment.
13421         (riscv_abi_xlen): New declaration.
13422         (riscv_abi_flen): New declaration.
13423         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13424         isa_features.
13425         (riscv_abi_xlen): New function.
13426         (riscv_isa_flen): Update to get answer from isa_features.
13427         (riscv_abi_flen): New function.
13428         (riscv_has_fp_abi): Update to get answer from abi_features.
13429         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13430         xlen and flen.
13431         (riscv_call_info) <xlen, flen>: Update comment.
13432         (riscv_call_arg_struct): Remove invalid assertions
13433         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13434         is removed.
13435         (riscv_gdbarch_init): Gather isa features and abi features
13436         separately, ensure both match on the gdbarch when reusing an old
13437         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13438         a target with 64-bit float hardware.
13439
13440 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13441
13442         * source.c (search_command_helper): Stop reverse search
13443         when line 1 has been searched.
13444
13445 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13446
13447         * record-full.c (record_full_base_target::close): Rewrite
13448         record_full_core_buf_list free logic.
13449
13450 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13451
13452         * break-catch-syscall.c (print_one_catch_syscall): xfree
13453         the last text.
13454
13455 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13456
13457         * top.c (print_gdb_version): Update Copyright year in version
13458         message.
13459
13460 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13461
13462         Update copyright year range in all GDB files.
13463
13464 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13465
13466         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13467
13468 For older changes see ChangeLog-2018.
13469 \f
13470 Local Variables:
13471 mode: change-log
13472 left-margin: 8
13473 fill-column: 74
13474 version-control: never
13475 coding: utf-8
13476 End:
13477