gdb/ChangeLog

   1 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
   4         and $_gdb_maint_setting_str.
   5
   6 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * cli/cli-cmds.c (setting_cmd, value_from_setting)
   9         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  10         (str_value_from_setting, gdb_setting_str_internal_fn)
  11         (gdb_maint_setting_str_internal_fn): New functions.
  12         (_initialize_cli_cmds): Define the new convenience functions.
  13         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  14         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  15
  16 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  17
  18         * agent.c (set_can_use_agent): When the setting is turned on,
  19         look up agent symbols if we don't have them yet.
  20         (agent_new_objfile): Don't look up agent symbols when the agent
  21         setting is off.
  22
  23 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  24
  25         * config.in: Regenerate.
  26
  27 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  28
  29         * configure: Regenerate.
  30         * configure.ac: Check for strerror_r.
  31         * gdbsupport/common-utils.h (safe_strerror): Change return value
  32         to const char * and document that this function is now threadsafe.
  33         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  34         thread_local and call strerror_r, if available.
  35         * utils.c (perror_string): Update.
  36         (print_sys_errmsg): Update.
  37
  38 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  39
  40         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  41         objfile_key.
  42         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  43         objfile to fetch per-bfd data.
  44         (arm_find_exidx_entry): Likewise.
  45
  46 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  47
  48         * gdbsupport/agent.c (debug_agent): Change type to bool.
  49         (use_agent): Likewise.
  50         (all_agent_symbols_look_up): Likewise.
  51         (agent_loaded_p): Change return value to bool.
  52         (agent_look_up_symbols): Update.
  53         (agent_capability_check): Change return value to bool.
  54         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  55         (debug_agent): Change type to bool.
  56         (use_agent): Likewise.
  57         (agent_capability_check): Change return value to bool.
  58
  59 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  60
  61         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  62         (build_minimal_symbol_hash_tables): Code to clear the table moved
  63         to clear_minimal_symbol_hash_tables.
  64         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
  65         when needed.
  66
  67 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  68
  69         * infcmd.c: Remove includes.
  70         * infrun.c: Remove includes.
  71
  72 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  75         (grow_vect): Remove declaration.
  76         (ada_type_of_array): Remove declaration.
  77         (ada_update_initial_language): Remove declaration.
  78         (ada_fold_name): Remove declaration.
  79         (ada_fill_in_ada_prototype): Remove declaration.
  80         (user_select_syms): Remove declaration.
  81         (get_selections): Remove declaration.
  82         (ada_tag_type): Remove declaration.
  83         (ada_value_tag): Remove declaration.
  84         (ada_is_others_clause): Remove declaration.
  85         (ada_in_variant): Remove declaration.
  86         (ada_value_struct_elt): Remove declaration.
  87         (ada_attribute_name): Remove declaration.
  88         (ada_system_address_type): Remove declaration.
  89         * ada-lang.c (ada_watch_location_expression): Make static.
  90         (GROW_VECT): Move here from ada-lang.h.
  91         (grow_vect): Make static.
  92         (ada_update_initial_language): Make static.
  93         (ada_fold_name): Make static.
  94         (ada_type_of_array): Make static.
  95         (encoded_ordered_before): Move up.
  96         (sort_choices): Move up.
  97         (print_signatures): Move up.
  98         (ada_print_symbol_signature): Move up.
  99         (get_selections): Move up and make static.
 100         (user_select_syms): Move up and make static.
 101         (ada_value_struct_elt): Move up and make static.
 102         (ada_tag_type): Make static.
 103         (ada_value_tag): Make static.
 104         (ada_is_others_clause): Make static.
 105         (ada_in_variant): Make static.
 106         (ada_attribute_name): Make static.
 107
 108 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 109
 110         * ada-lang.c: Remove includes.
 111         * ada-typeprint.c: Remove includes.
 112         * ada-valprint.c: Remove includes.
 113
 114 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 115
 116         * addrmap.c: Add static assertions of type size, moved from
 117         _initialize_addrmap.
 118         (_initialize_addrmap): Remove.
 119
 120 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * coffread.c (record_minimal_symbol): Update.
 123         (process_coff_symbol): Update.
 124         * dbxread.c (read_dbx_symtab): Update.
 125         * dwarf2read.c (add_partial_symbol): Update.
 126         (fixup_go_packaging): Update.
 127         (load_partial_dies): Update.
 128         (new_symbol): Update.
 129         * elfread.c (record_minimal_symbol): Change signature to use
 130         gdb::string_view instead of name+len.
 131         (elf_symtab_read): Update.
 132         (elf_rel_plt_read): Update.
 133         * mdebugread.c (parse_partial_symbols): Update.
 134         (handle_psymbol_enumerators): Update.
 135         (new_symbol): Update.
 136         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 137         to use gdb::string_view instead of name+len.
 138         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 139         * psympriv.h (add_psymbol_to_list): Likewise.
 140         * psymtab.c (add_psymbol_to_bcache): Likewise.
 141         (add_psymbol_to_list): Likewise.
 142         * stabsread.c (define_symbol): Update.
 143         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 144         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 145         (symbol_set_names): Likewise.
 146         * xcoffread.c (scan_xcoff_symtab): Update.
 147
 148 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * symtab.h (symbol_set_names): Document that copy_name must be
 151         set to true for non-nullterminated strings.
 152         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 153         linkage_name if the entry was not found and we need to demangle.
 154
 155 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 156
 157         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 158         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 159         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 160         * gdbsupport/gdb_binary_search.h: New file.
 161
 162 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 163
 164         * NEWS: Mention new --with-system-gdbinit-dir option.
 165         * config.in: Regenerate.
 166         * configure: Regenerate.
 167         * configure.ac: Add new option --with-system-gdbinit-dir.
 168         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 169         for a ".gdb" suffix.
 170         * main.c (get_init_files): Change system_gdbinit argument to
 171         a vector and return the files in SYSTEM_GDBINIT_DIR in
 172         addition to SYSTEM_GDBINIT.
 173         (captured_main_1): Update.
 174         (print_gdb_help): Update.
 175         * top.c (print_gdb_configuration): Also print the value of
 176         SYSTEM_GDBINIT_DIR.
 177
 178 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 179
 180         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 181         that takes gdb::string_view arguments.
 182
 183 2019-10-26  Tom de Vries  <tdevries@suse.de>
 184
 185         * aarch64-linux-tdep.c: Fix typos in comments.
 186         * aarch64-tdep.c: Same.
 187         * ada-lang.c: Same.
 188         * amd64-nat.c: Same.
 189         * arc-tdep.c: Same.
 190         * arch/aarch64-insn.c: Same.
 191         * block.c: Same.
 192         * breakpoint.h: Same.
 193         * btrace.h: Same.
 194         * c-varobj.c: Same.
 195         * cli/cli-decode.c: Same.
 196         * cli/cli-script.c: Same.
 197         * cli/cli-utils.h: Same.
 198         * coff-pe-read.c: Same.
 199         * coffread.c: Same.
 200         * compile/compile-cplus-symbols.c: Same.
 201         * compile/compile-object-run.c: Same.
 202         * completer.c: Same.
 203         * corelow.c: Same.
 204         * cp-support.c: Same.
 205         * demangle.c: Same.
 206         * dwarf-index-write.c: Same.
 207         * dwarf2-frame.c: Same.
 208         * dwarf2-frame.h: Same.
 209         * eval.c: Same.
 210         * frame-base.h: Same.
 211         * frame.h: Same.
 212         * gdbcmd.h: Same.
 213         * gdbtypes.h: Same.
 214         * gnu-nat.c: Same.
 215         * guile/scm-objfile.c: Same.
 216         * i386-tdep.c: Same.
 217         * i386-tdep.h: Same.
 218         * infcall.c: Same.
 219         * infcall.h: Same.
 220         * linux-nat.c: Same.
 221         * m68k-tdep.c: Same.
 222         * macroexp.c: Same.
 223         * memattr.c: Same.
 224         * mi/mi-cmd-disas.c: Same.
 225         * mi/mi-getopt.h: Same.
 226         * mi/mi-main.c: Same.
 227         * minsyms.c: Same.
 228         * nat/aarch64-sve-linux-sigcontext.h: Same.
 229         * objfiles.h: Same.
 230         * ppc-linux-nat.c: Same.
 231         * ppc-linux-tdep.c: Same.
 232         * ppc-tdep.h: Same.
 233         * progspace.h: Same.
 234         * prologue-value.h: Same.
 235         * python/py-evtregistry.c: Same.
 236         * python/py-instruction.h: Same.
 237         * record-btrace.c: Same.
 238         * record-full.c: Same.
 239         * remote.c: Same.
 240         * rs6000-tdep.c: Same.
 241         * ser-tcp.c: Same.
 242         * sol-thread.c: Same.
 243         * sparc-sol2-tdep.c: Same.
 244         * sparc64-tdep.c: Same.
 245         * stabsread.c: Same.
 246         * symfile.c: Same.
 247         * symtab.h: Same.
 248         * target.c: Same.
 249         * tracepoint.c: Same.
 250         * tui/tui-data.h: Same.
 251         * tui/tui-io.c: Same.
 252         * tui/tui-win.c: Same.
 253         * tui/tui.c: Same.
 254         * unittests/rsp-low-selftests.c: Same.
 255         * user-regs.h: Same.
 256         * utils.c: Same.
 257         * utils.h: Same.
 258         * valarith.c: Same.
 259         * valops.c: Same.
 260         * valprint.c: Same.
 261         * valprint.h: Same.
 262         * value.c: Same.
 263         * value.h: Same.
 264         * varobj.c: Same.
 265         * x86-nat.h: Same.
 266         * xtensa-tdep.c: Same.
 267
 268 2019-10-25  Ali Tamur <tamur@google.com>
 269
 270         * charset.c (find_charset_names): Reflect API change.
 271
 272 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 273
 274         * symtab.c (struct demangled_name_entry): Change demangled name
 275         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 276         part of the struct anymore.
 277         (symbol_set_names): No longer obstack allocate + copy the demangled
 278         name, just store the allocated name from bfd.
 279
 280 2019-10-25  Tom Tromey  <tromey@adacore.com>
 281
 282         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 283         (bsearch_cie_cmp, add_cie): Remove.
 284         (find_cie): Reimplement.
 285         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 286         (dwarf2_build_frame_info): Update.
 287
 288 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 289
 290         PR gdb/25126
 291         * symfile.c (reread_symbols): Call forget_cached_source_info to
 292         clear the stale source cache.
 293
 294 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 295
 296         * configure: Regenerate.
 297         * configure.ac: Remove code that sets python_has_threads.
 298
 299 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * config.in: Regenerate.
 302         * configure: Regenerate.
 303         * configure.ac: Remove the code that uses sed to get the python
 304         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 305
 306 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 309         error paths.
 310
 311 2019-10-23  Tom Tromey  <tom@tromey.com>
 312
 313         * arc-tdep.c: Remove ".." from include.
 314         * frv-tdep.c: Remove ".." from include.
 315         * lm32-tdep.c: Remove ".." from include.
 316         * microblaze-tdep.c: Remove ".." from include.
 317         * or1k-tdep.h: Remove ".." from include.
 318         * s12z-tdep.c: Remove ".." from include.
 319         * Makefile.in (OPCODES_CFLAGS): Add comment.
 320         (TOP_CFLAGS): New variable.
 321         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 322
 323 2019-10-23  Tom Tromey  <tom@tromey.com>
 324
 325         * Makefile.in (READLINE_DIR): Update.
 326
 327 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 328
 329         * infcall.c (call_function_by_hand_dummy): Fix the function
 330         comment.  And extract out a code section into...
 331         (reserve_stack_space): ...this new function.
 332
 333 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 334
 335         * infcall.c (value_arg_coerce): Remove an unused parameter.
 336         (call_function_by_hand_dummy): Update the call to
 337         'value_arg_coerce'.
 338
 339 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 340
 341         * infcall.c (call_function_by_hand_dummy): Refactor.
 342
 343 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 344
 345         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 346
 347 2019-10-23  Tom Tromey  <tom@tromey.com>
 348
 349         * configure: Rebuild.
 350         * configure.ac: Don't check for sigprocmask.
 351         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 352
 353 2019-10-23  Tom Tromey  <tom@tromey.com>
 354
 355         * configure: Rebuild.
 356         * acinclude.m4: Use m4_include, not sinclude.
 357
 358 2019-10-23  Tom de Vries  <tdevries@suse.de>
 359
 360         PR breakpoints/24687
 361         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 362
 363 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 364
 365         * symtab.c (struct demangled_name_entry) <language>: Change from
 366         bitfield to regular variable.
 367
 368 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 369
 370         * symtab.c (struct demangled_name_entry): Add a constructor.
 371         (free_demangled_name_entry): New function to call the destructor
 372         for demangled_name_entry.
 373         (create_demangled_names_hash): Pass free_demangled_name_entry to
 374         htab_create_alloc.
 375         (symbol_set_names): Call placement new for demangled_name_entry.
 376         * utils.c: No longer include xxhash.h here, now that fast_hash
 377         is inlined in the header.
 378         * utils.h: Instead, include it here.
 379
 380 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 381
 382         * Makefile.in: Link with libxxhash.
 383         * config.in: Regenerate.
 384         * configure: Regenerate.
 385         * configure.ac: Search for libxxhash.
 386         * utils.c (fast_hash): Use xxhash if present.
 387
 388 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * utils.h (fast_hash): New function.
 391         * symtab.c (hash_demangled_name_entry): Call new function
 392         fast_hash.
 393
 394 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 395
 396         * symtab.c (struct demangled_name_entry): Change type of mangled
 397         to gdb::string_view. Also adds a constructor that takes the
 398         mangled name.
 399         (hash_demangled_name_entry): Update.
 400         (eq_demangled_name_entry): Update.
 401         (free_demangled_name_entry): New function to call the destructor
 402         now that this is not a POD anymore.
 403         (create_demangled_names_hash): Pass free_demangled_name_entry to
 404         htab_create_alloc.
 405         (symbol_set_names): Update.
 406
 407 2019-10-21  Ali Tamur  <tamu@google.com>
 408
 409         * dwarf2read.c (dir_index): Change type.
 410         (file_name_index): Likewise.
 411         (line_header::include_dir_at): Change comment and implementation on
 412         whether it is DWARF 5.
 413         (line_header::is_valid_file_index): New function.
 414         (line_header::file_name_at): Change comment and implementation on
 415         whether it is DWARF 5.
 416         (line_header::file_names): Change to private field renamed as
 417         m_file_names and introduce a new accessor method.
 418         (line_header::file_names_size): New method.
 419         (line_header::include_dirs): Change to private field and rename as
 420         m_include_dirs.
 421         (dw2_get_file_names_reader): Define local var at a smaller scope and
 422         reflect API change.
 423         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 424         (process_structure_scope): Likewise.
 425         (line_header::add_include_dir): Change message and reflect renaming.
 426         (line_header::add_file_name): Likewise.
 427         (read_formatted_entries): Handle DW_FORM_data16.
 428         (dwarf_decode_line_header): Fix line header length calculation.
 429         (psymtab_include_file_name): Change comment and API.
 430         (lnp_state_machine::m_file): Update comment and reflect type change.
 431         (lnp_state_machine::record_line): Reflect type change.
 432         (dwarf_decode_lines): Reflect API change.
 433         (file_file_name): Likewise.
 434         (file_full_name): Likewise.
 435
 436 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 439
 440 2019-10-21  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 443
 444 2019-10-21  Tom Tromey  <tom@tromey.com>
 445
 446         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 447         NM_H.   Use AC_CONFIG_LINKS.
 448         * configure: Rebuild.
 449         * Makefile.in (NM_H): New variable.
 450         (generated_files): Add NM_H.  Remove gcore.
 451         (nm.h, stamp-nmh): New targets.
 452
 453 2019-10-20  Tom Tromey  <tom@tromey.com>
 454
 455         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 456         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 457         obsolete comment.
 458         (put_objfile_before): Now static.
 459
 460 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 461
 462         * gdbsupport/common-utils.h (startswith): Change return type to
 463         bool.
 464
 465 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 466
 467         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 468         * breakpoint.c (bp_locations_compare): Rename to...
 469         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 470         (update_global_location_list): Use std::sort instead of qsort.
 471         * buildsym.c (compare_line_numbers): Rename to...
 472         (lte_is_less_than): ...this, and change to std::sort semantics.
 473         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 474         instead of qsort.
 475         * disasm.c (compare_lines): Rename to...
 476         (line_is_less_than): ...this, and change to std::sort semantics.
 477         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 478         of qsort.
 479         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 480         (fde_is_less_than): ...this, and change to std::sort semantics.
 481         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 482         * mdebugread.c (compare_blocks):
 483         (block_is_less_than): ...this, and change to std::sort semantics.
 484         (sort_blocks): Call std::sort instead of qsort.
 485         * objfiles.c (qsort_cmp): Rename to...
 486         (sort_cmp): ...this, and change to std::sort semantics.
 487         (update_section_map): Call std::sort instead of qsort.
 488         * remote.c (compare_pnums): Remove.
 489         (map_regcache_remote_table): Call std::sort instead of qsort.
 490         * utils.c (compare_positive_ints): Remove.
 491         * utils.h (compare_positive_ints): Remove.
 492         * xcoffread.c (compare_lte): Remove.
 493         (arrange_linetable): Call std::sort instead of qsort.
 494
 495 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 496
 497         * symfile.c (init_entry_point_info): Fix typo.
 498         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 499
 500 2019-10-18  Tom de Vries  <tdevries@suse.de>
 501
 502         * aarch64-tdep.c: Fix typos in comments.
 503         * ada-lang.c: Same.
 504         * ada-tasks.c: Same.
 505         * alpha-tdep.c: Same.
 506         * alpha-tdep.h: Same.
 507         * amd64-nat.c: Same.
 508         * amd64-windows-tdep.c: Same.
 509         * arc-tdep.c: Same.
 510         * arc-tdep.h: Same.
 511         * arch-utils.c: Same.
 512         * arm-nbsd-tdep.c: Same.
 513         * arm-tdep.c: Same.
 514         * ax-gdb.c: Same.
 515         * blockframe.c: Same.
 516         * btrace.c: Same.
 517         * c-varobj.c: Same.
 518         * coff-pe-read.c: Same.
 519         * coffread.c: Same.
 520         * cris-tdep.c: Same.
 521         * darwin-nat.c: Same.
 522         * dbxread.c: Same.
 523         * dcache.c: Same.
 524         * disasm.c: Same.
 525         * dtrace-probe.c: Same.
 526         * dwarf-index-write.c: Same.
 527         * dwarf2-frame-tailcall.c: Same.
 528         * dwarf2-frame.c: Same.
 529         * dwarf2read.c: Same.
 530         * eval.c: Same.
 531         * exceptions.c: Same.
 532         * fbsd-tdep.c: Same.
 533         * findvar.c: Same.
 534         * frame.c: Same.
 535         * frv-tdep.c: Same.
 536         * gnu-v3-abi.c: Same.
 537         * go32-nat.c: Same.
 538         * h8300-tdep.c: Same.
 539         * hppa-tdep.c: Same.
 540         * i386-linux-tdep.c: Same.
 541         * i386-tdep.c: Same.
 542         * ia64-libunwind-tdep.c: Same.
 543         * ia64-tdep.c: Same.
 544         * infcmd.c: Same.
 545         * infrun.c: Same.
 546         * linespec.c: Same.
 547         * linux-nat.c: Same.
 548         * linux-thread-db.c: Same.
 549         * machoread.c: Same.
 550         * mdebugread.c: Same.
 551         * mep-tdep.c: Same.
 552         * mn10300-tdep.c: Same.
 553         * namespace.c: Same.
 554         * objfiles.c: Same.
 555         * opencl-lang.c: Same.
 556         * or1k-tdep.c: Same.
 557         * osabi.c: Same.
 558         * ppc-linux-nat.c: Same.
 559         * ppc-linux-tdep.c: Same.
 560         * ppc-sysv-tdep.c: Same.
 561         * printcmd.c: Same.
 562         * procfs.c: Same.
 563         * record-btrace.c: Same.
 564         * record-full.c: Same.
 565         * remote-fileio.c: Same.
 566         * remote.c: Same.
 567         * rs6000-tdep.c: Same.
 568         * s12z-tdep.c: Same.
 569         * score-tdep.c: Same.
 570         * ser-base.c: Same.
 571         * ser-go32.c: Same.
 572         * skip.c: Same.
 573         * sol-thread.c: Same.
 574         * solib-svr4.c: Same.
 575         * solib.c: Same.
 576         * source.c: Same.
 577         * sparc-nat.c: Same.
 578         * sparc-sol2-tdep.c: Same.
 579         * sparc-tdep.c: Same.
 580         * sparc64-tdep.c: Same.
 581         * stabsread.c: Same.
 582         * stack.c: Same.
 583         * symfile.c: Same.
 584         * symtab.c: Same.
 585         * target-descriptions.c: Same.
 586         * target-float.c: Same.
 587         * thread.c: Same.
 588         * utils.c: Same.
 589         * valops.c: Same.
 590         * valprint.c: Same.
 591         * value.c: Same.
 592         * varobj.c: Same.
 593         * windows-nat.c: Same.
 594         * xcoffread.c: Same.
 595         * xstormy16-tdep.c: Same.
 596         * xtensa-tdep.c: Same.
 597
 598 2019-10-17  Tom Tromey  <tromey@adacore.com>
 599
 600         * configure: Rebuild.
 601         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 602         in AC_CONFIG_FILES invocation.
 603         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 604         new-style config.status invocation.
 605
 606 2019-10-17  Tom de Vries  <tdevries@suse.de>
 607
 608         * arm-nbsd-nat.c: Fix typos in comments.
 609         * arm-tdep.c: Same.
 610         * darwin-nat-info.c: Same.
 611         * dwarf2read.c: Same.
 612         * elfread.c: Same.
 613         * event-top.c: Same.
 614         * findvar.c: Same.
 615         * gdbtypes.c: Same.
 616         * hppa-tdep.c: Same.
 617         * i386-tdep.c: Same.
 618         * jit.c: Same.
 619         * main.c: Same.
 620         * mdebugread.c: Same.
 621         * moxie-tdep.c: Same.
 622         * nto-procfs.c: Same.
 623         * osabi.c: Same.
 624         * ppc-linux-tdep.c: Same.
 625         * remote.c: Same.
 626         * riscv-tdep.c: Same.
 627         * s390-tdep.c: Same.
 628         * sh-tdep.c: Same.
 629         * sparc-linux-tdep.c: Same.
 630         * sparc-nat.c: Same.
 631         * stack.c: Same.
 632         * target-descriptions.c: Same.
 633         * top.c: Same.
 634         * varobj.c: Same.
 635
 636 2019-10-16  Tom Tromey  <tom@tromey.com>
 637
 638         * objfiles.h (struct objfile) <original_name>: Now const.
 639
 640 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 641
 642         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 643         pass on to sigsetjmp's second argument.
 644         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 645
 646 2019-10-16  Keith Seitz  <keiths@redhat.com>
 647
 648         PR gdb/23567
 649         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 650         sections whose size is greater than the file size.
 651
 652 2019-10-16  Jim Wilson  <jimw@sifive.com>
 653
 654         * riscv-tdep.c (riscv_gcc_target_options): New.
 655         (riscv_gnu_triplet_regexp): New.
 656         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 657         set_gdbarch_gnu_triplet_regexp.
 658
 659 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 660
 661         * Makefile.in: Add xml-builtin.h.
 662         * features/feature_to_c.sh: Add an include for xml-builtin.h
 663         to ensure that the compiler checks that the types match.
 664         * xml-builtin.h: New file.
 665         * xml-support.c (fetch_xml_builtin): Add missing const.
 666         * xml-support.h: Remove declaration of xml_builtins.
 667
 668 2019-10-16  Tom de Vries  <tdevries@suse.de>
 669
 670         PR tdep/25096
 671         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 672         (amd64_classify_aggregate): ... here.
 673         (amd64_classify_aggregate_field): Handled fiels of nested structs
 674         recursively.
 675
 676 2019-10-16  Tom de Vries  <tdevries@suse.de>
 677
 678         PR tdep/24104
 679         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 680         that handles 'theclass'.
 681
 682 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * linespec.c (decode_digits_ordinary): Update comment.
 685         * make-target-delegates: No longer need to handle VEC case.
 686         * memrange.c (normalize_mem_ranges): Update comment.
 687         * namespace.c (add_using_directive): Update comment.
 688         * objc-lang.c (uniquify_strings): Update comment.
 689         * ppc-linux-nat.c (struct thread_points): Update comment.
 690         * probe.h (find_probes_in_objfile): Update comment.
 691         * target.h (enum flash_preserve_mode): Update comment.
 692         * varobj.c (varobj_restrict_range): Update comment.
 693         * varobj.h (varobj_list_children): Update comment.
 694
 695 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * Makefile.in: Remove references to vec.h and vec.c.
 698         * aarch64-tdep.c: No longer include vec.h.
 699         * ada-lang.c: Likewise.
 700         * ada-lang.h: Likewise.
 701         * arm-tdep.c: Likewise.
 702         * ax.h: Likewise.
 703         * breakpoint.h: Likewise.
 704         * charset.c: Likewise.
 705         * cp-support.h: Likewise.
 706         * dtrace-probe.c: Likewise.
 707         * dwarf2read.c: Likewise.
 708         * extension.h: Likewise.
 709         * gdb_bfd.c: Likewise.
 710         * gdbsupport/gdb_vecs.h: Likewise.
 711         * gdbsupport/vec.c: Remove.
 712         * gdbsupport/vec.h: Remove.
 713         * gdbthread.h: Likewise.
 714         * guile/scm-type.c: Likewise.
 715         * inline-frame.c: Likewise.
 716         * machoread.c: Likewise.
 717         * memattr.c: Likewise.
 718         * memrange.h: Likewise.
 719         * namespace.h: Likewise.
 720         * nat/linux-btrace.h: Likewise.
 721         * osdata.c: Likewise.
 722         * parser-defs.h: Likewise.
 723         * progspace.h: Likewise.
 724         * python/py-type.c: Likewise.
 725         * record-btrace.c: Likewise.
 726         * rust-exp.y: Likewise.
 727         * solib-target.c: Likewise.
 728         * stap-probe.c: Likewise.
 729         * target-descriptions.c: Likewise.
 730         * target-memory.c: Likewise.
 731         * target.h: Likewise.
 732         * varobj.c: Likewise.
 733         * varobj.h: Likewise.
 734         * xml-support.h: Likewise.
 735
 736 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 739         Update for new std::vector based implementation.
 740         (process_psymtab_comp_unit_reader): Likewise.
 741         (scan_partial_symbols): Likewise.
 742         (recursively_compute_inclusions): Likewise.
 743         (compute_compunit_symtab_includes): Likewise.
 744         (process_imported_unit_die): Likewise.
 745         (queue_and_load_dwo_tu): Likewise.
 746         (follow_die_sig_1): Likewise.
 747         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 748         (typedef dwarf2_per_cu_ptr): Remove.
 749         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 750         function.
 751         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 752         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 753         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 754         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 755         std::vector.
 756
 757 2019-10-15  Tom Tromey  <tromey@adacore.com>
 758
 759         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 760         TID.
 761
 762 2019-10-15  Tom Tromey  <tromey@adacore.com>
 763
 764         * windows-nat.c (windows_nat_target::fetch_registers)
 765         (windows_nat_target::store_registers): Rename "pid" to "tid".
 766
 767 2019-10-15  Tom Tromey  <tromey@adacore.com>
 768
 769         * gdbarch.h, gdbarch.c: Rebuild.
 770         * gdbarch.sh (gcc_target_options): Change return type to
 771         std::string.
 772         * compile/compile.c (get_args): Update.
 773         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 774         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 775         std::string.
 776         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 777         std::string.
 778         * arch-utils.c (default_gcc_target_options): Return std::string.
 779         * arch-utils.h (default_gcc_target_options): Return std::string.
 780         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 781
 782 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 783
 784         * breakpoint.c (breakpoint_chain): Make static.
 785         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 786         of accessing breakpoint_chain.
 787
 788 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 789
 790         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 791         to a gdb::function_view and return value to bool.
 792         * breakpoint.h (iterate_over_breakpoints): Likewise.
 793         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 794         (pop_dummy_frame): Update.
 795         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 796         (gdbscm_breakpoints): Update.
 797         * python/py-breakpoint.c (build_bp_list): Update.
 798         (gdbpy_breakpoints): Update.
 799         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 800         Update.
 801         (bpfinishpy_handle_stop): Update.
 802         (bpfinishpy_handle_exit): Update.
 803         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 804         (svr4_update_solib_event_breakpoints): Update.
 805
 806 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 807
 808         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 809         when unwrapping single-field structs.
 810
 811 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 812
 813         * dwarf2read.c: Remove includes.
 814
 815 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 816
 817         * ui-out.c (ui_out::call_do_message): Silence
 818         -Wformat-nonliteral warning.
 819
 820 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 821
 822         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 823         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 824         include: readline/tilde.h.
 825
 826 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * remote.c (remote_target::get_trace_status): Remove declaration of
 829         trace_regblock_size.
 830
 831 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 832
 833         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 834         (show_user): Remove declaration of cmdlist.
 835         * cli/cli-cmds.h (max_user_call_depth): Declare.
 836         * cli/cli-script.c (execute_user_command): Remove declaration
 837         of max_user_call_depth.
 838
 839 2019-10-11  Jim Wilson  <jimw@sifive.com>
 840
 841         * gdbsupport/print-utils.h (pulongest): Fix comment.
 842         (plongest): Likewise.
 843         (phex): Add missing comment, mention leading zeros.
 844         (phex_nz): Add mention of no leading zeros to comment.
 845
 846         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 847         plongest instead of unsigned long long cast.
 848
 849 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 852         for external_editor_command and gdbtk_test.
 853
 854 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 857         * varobj.c (varobjdebug): Move comment to...
 858         * varobj.h (varobjdebug): ...here, and declare.
 859
 860 2019-10-09  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 863         erase_data_content.
 864
 865 2019-10-09  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 868         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 869         * tui/tui-command.c (tui_cmd_window::resize)
 870         (tui_refresh_cmd_win): Update.
 871         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 872         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 873         * tui/tui-data.c (~tui_gen_win_info): Remove.
 874         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 875         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 876         (tui_redisplay_readline, tui_mld_flush)
 877         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 878         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 879         (tui_data_window::erase_data_content)
 880         (tui_data_item_window::rerender)
 881         (tui_data_item_window::refresh_window): Update.
 882         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 883         (box_win, tui_gen_win_info::make_window)
 884         (tui_gen_win_info::make_visible): Update.
 885         (tui_delete_win): Remove.
 886         * tui/tui-winsource.c
 887         (tui_source_window_base::do_erase_source_content): Update.
 888         (tui_show_source_line, tui_source_window_base::update_tab_width)
 889         (tui_source_window_base::update_exec_info): Update.
 890         * tui/tui-data.h (struct curses_deleter): New.
 891         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 892         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 893
 894 2019-10-09  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 897
 898 2019-10-09  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 901         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 902
 903 2019-10-09  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 906         window height directly.
 907         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 908         declare.
 909         * tui/tui-layout.c (tui_default_win_height): Remove.
 910         (tui_default_win_viewport_height): Remove.
 911
 912 2019-10-09  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui.h: Remove comments.
 915
 916 2019-10-09  Tom de Vries  <tdevries@suse.de>
 917
 918         * python/lib/gdb/printer/bound_registers.py: Use
 919         '^builtin_type_bound128' as regexp argument for
 920         add_builtin_pretty_printer.
 921
 922 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 923
 924         * guile/guile.c (guile_extension_script_ops): Remove forward
 925         declaration and mark as static.
 926         (guile_script_ops): Likewise.
 927         (extension_language_guile): Move further down in the file so
 928         it can reference the definitions for guile_{extension_,}script_ops.
 929
 930 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 931
 932         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 933         except SORTL, DFLTCC, and KDSA.
 934
 935 2019-10-08  Tom Tromey  <tromey@adacore.com>
 936
 937         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 938         (struct safe_symbol_file_add_args): Remove.
 939
 940 2019-10-08  Tom Tromey  <tromey@adacore.com>
 941
 942         * windows-nat.c: Don't include buildsym-legacy.h.
 943
 944 2019-10-08  Tom Tromey  <tromey@adacore.com>
 945
 946         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 947
 948 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 949
 950         * gdbtypes.c (overload_debug): Move comment to header.
 951         * gdbtypes.h (overload_debug): Declare.
 952         * valops.c: Remove declaration of overload_debug, instead
 953         include gdbtypes.h.
 954
 955 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 956
 957         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 958         through _().
 959         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 960         move comment...
 961         * language.h (lang_frame_mismatch_warn): ... here. Also add
 962         declaration.
 963         * top.c (lang_frame_mismatch_warn): Remove declaration.
 964         (check_frame_language_change): Pass lang_frame_mismatch_warn
 965         through _().
 966
 967 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 968
 969         * c-lang.h (vtbl_ptr_name): Declare.
 970         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 971         it from the header.
 972         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 973
 974 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 975
 976         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 977         gdb_static_assert.
 978
 979 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 980
 981         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 982         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 983         * ctfread.c: New file.
 984         * ctfread.h: New file.
 985         * elfread.c: Include ctfread.h.
 986         (struct elfinfo text_p): New member ctfsect.
 987         (elf_locate_sections): Mark CTF section.
 988         (elf_symfile_read): Call elfctf_build_psymtabs.
 989         * Makefile.in (LIBCTF): Add.
 990         (CLIBS): Use it.
 991         (CDEPS): Likewise.
 992         (DIST): Add ctfread.c.
 993
 994 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * ctfread.c (struct nextfield): Renamed to ...
 997         (struct ctf_nextfield): ... this.
 998         (struct field_info): Renamed to ...
 999         (strut ctf_field_info): ... this.
1000         (attach_fields_to_type): Update for renamed structures.
1001         (ctf_add_member_cb): Likewise.
1002         (ctf_add_enum_member_cb): Likewise.
1003         (process_struct_members): Likewise.
1004         (process_enum_type): Likewise.
1005
1006 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1007
1008         * tracectf.h: Rename, was ctf.h.
1009         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1010         * tracefile.c: Likewise.
1011         * tracepoint.c: Remove unused include ctf.h.
1012         * mi/mi-main.c: Likewise.
1013         * Makefile.in Replace ctf.c with tracectf.c.
1014
1015 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1016
1017         * version.in: Change version number to "9.0.50.DATE-git".
1018
1019 2019-10-03  Tom Tromey  <tom@tromey.com>
1020
1021         PR rust/24976:
1022         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1023
1024 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1027         cp_search_name_hash.
1028         * NEWS: Add entry about nested function support.
1029
1030 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1031             Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1034         for nested static variables when searchin VAR_DOMAIN.
1035         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1036         global scope, update comment.
1037         (add_partial_subprogram): Call add_partial_subprogram recursively
1038         for nested subroutines when processinng Fortran.
1039         (load_partial_dies): Process the child entities of a subprogram
1040         when processing Fortran.
1041         (partial_die_parent_scope): Handle building scope
1042         for Fortran nested functions.
1043         (process_die): Record that nested functions have a scope.
1044         (new_symbol): Always record Fortran subprograms on the global
1045         symbol list.
1046         (determine_prefix): How to build the prefix for Fortran
1047         subprograms.
1048
1049 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1052         have just sent the thread a SIGSTOP and are waiting for it to
1053         arrive.
1054
1055 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * btrace.c (btrace_add_pc): Remove whitespace before the template
1058         parameter in 'std::vector <...>'.
1059         (parse_xml_btrace_block): Likewise.
1060         (btrace_maint_decode_pt): Likewise.
1061         (btrace_maint_update_packets): Likewise.
1062         (btrace_maint_print_packets): Likewise.
1063         * btrace.h (struct btrace_maint_info): Likewise.
1064         * dwarf2read.c (struct type_unit_group): Likewise.
1065         (build_type_psymtabs_reader): Likewise.
1066         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1067         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1068         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1069
1070 2019-10-03  Tom de Vries  <tdevries@suse.de>
1071
1072         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1073         the first line of the help text for set/show style metadata.
1074
1075 2019-10-02  Tom Tromey  <tromey@adacore.com>
1076
1077         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1078         * gdbsupport/common-inferior.c: New file.
1079         * infcmd.c (startup_with_shell): Don't define.
1080         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1081         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1082         * inferior.h (startup_with_shell): Don't declare.
1083
1084 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1085
1086         * gdbsupport/gdb_assert.h: Include errors.h.
1087         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1088
1089 2019-10-02  Tom Tromey  <tromey@adacore.com>
1090
1091         * NEWS: Add $_ada_exception entry.
1092         * ada-lang.c (struct ada_catchpoint): Add constructor.
1093         <m_kind>: New member.
1094         (allocate_location_exception, re_set_exception): Remove
1095         "ex" parameter.
1096         (should_stop_exception): Compute $_ada_exception.
1097         (check_status_exception, print_it_exception)
1098         (print_one_exception, print_mention_exception): Remove
1099         "ex" parameter.
1100         (allocate_location_catch_exception, re_set_catch_exception)
1101         (check_status_exception, print_it_catch_exception)
1102         (print_one_catch_exception, print_mention_catch_exception)
1103         (print_recreate_catch_exception)
1104         (allocate_location_catch_exception_unhandled)
1105         (re_set_catch_exception_unhandled)
1106         (check_status_exception, print_it_catch_exception_unhandled)
1107         (print_one_catch_exception_unhandled)
1108         (print_mention_catch_exception_unhandled)
1109         (print_recreate_catch_exception_unhandled)
1110         (allocate_location_catch_assert, re_set_catch_assert)
1111         (check_status_assert, print_it_catch_assert)
1112         (print_one_catch_assert, print_mention_catch_assert)
1113         (print_recreate_catch_assert)
1114         (allocate_location_catch_handlers, re_set_catch_handlers)
1115         (check_status_handlers, print_it_catch_handlers)
1116         (print_one_catch_handlers, print_mention_catch_handlers)
1117         (print_recreate_catch_handlers): Remove.
1118         (create_ada_exception_catchpoint): Update.
1119         (initialize_ada_catchpoint_ops): Update.
1120
1121 2019-10-02  Tom Tromey  <tromey@adacore.com>
1122
1123         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1124         (create_excep_cond_exprs): Simplify exception string computation.
1125         (ada_exception_catchpoint_cond_string): Likewise.
1126
1127 2019-10-02  Tom Tromey  <tromey@adacore.com>
1128
1129         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1130         * ada-lang.c (lesseq_defined_than): Handle
1131         LOC_STATIC.
1132         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1133         parameter.
1134         (dwarf2_has_info): Likewise.
1135         (new_symbol): Set maybe_copied on symbol when
1136         appropriate.
1137         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1138         parameter.
1139         <can_copy>: New member.
1140         * elfread.c (record_minimal_symbol): Set maybe_copied
1141         on symbol when appropriate.
1142         (elf_symfile_read): Update call to dwarf2_has_info.
1143         * minsyms.c (lookup_minimal_symbol_linkage): New
1144         function.
1145         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1146         * symtab.c (get_symbol_address, get_msymbol_address):
1147         New functions.
1148         * symtab.h (get_symbol_address, get_msymbol_address):
1149         Declare.
1150         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1151         maybe_copied.
1152         (struct symbol, struct minimal_symbol) <maybe_copied>:
1153         New member.
1154
1155 2019-10-02  Tom Tromey  <tromey@adacore.com>
1156
1157         * source.c (struct current_source_location): New.
1158         (current_source_key): New global.
1159         (current_source_symtab, current_source_line)
1160         (current_source_pspace): Remove.
1161         (get_source_location): New function.
1162         (get_current_source_symtab_and_line)
1163         (set_default_source_symtab_and_line)
1164         (set_current_source_symtab_and_line)
1165         (clear_current_source_symtab_and_line, select_source_symtab)
1166         (info_source_command, print_source_lines_base)
1167         (info_line_command, search_command_helper, _initialize_source):
1168         Update.
1169
1170 2019-10-02  Tom Tromey  <tromey@adacore.com>
1171
1172         * source.c (select_source_symtab): Don't call
1173         decode_line_with_current_source.
1174
1175 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * symtab.c (lookup_global_symbol): Search global block.
1178
1179 2019-10-02  Tom Tromey  <tromey@adacore.com>
1180
1181         * coffread.c (process_coff_symbol): Update.
1182         * dwarf2read.c (var_decode_location, new_symbol): Update.
1183         * mdebugread.c (parse_symbol): Update.
1184         * objfiles.c (relocate_one_symbol): Update.
1185         * stabsread.c (define_symbol, fix_common_block)
1186         (scan_file_globals): Update.
1187         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1188         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1189         * xcoffread.c (process_xcoff_symbol): Update.
1190
1191 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1192
1193         * MAINTAINERS: Update my email address.
1194
1195 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1198         std::vector.
1199         (build_type_psymtabs_reader): Update for std::vector.
1200         (build_type_psymtab_dependencies): Likewise.
1201         * dwarf2read.h: Remove use of DEF_VEC_P.
1202         (typedef sig_type_ptr): Delete.
1203
1204 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1207         to std::vector.
1208         (btrace_maint_decode_pt): Likewise, and move allocation of the
1209         vector outside of the loop.
1210         (btrace_maint_update_packets): Update to handle change from VEC to
1211         std::vector.
1212         (btrace_maint_print_packets): Likewise.
1213         (maint_info_btrace_cmd): Likewise.
1214         * btrace.h: Remove use of DEF_VEC_O.
1215         (typedef btrace_pt_packet_s): Delete.
1216         (struct btrace_maint_info) <packets>: Change fromm VEC to
1217         std::vector.
1218         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1219
1220 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1223         make accesses into the vector constant references.
1224         (btrace_add_pc): Update for std::vector.
1225         (btrace_stitch_bts): Likewise.
1226         (parse_xml_btrace_block): Likewise.
1227         (btrace_maint_update_packets): Likewise.
1228         (btrace_maint_print_packets): Likewise.
1229         (maint_info_btrace_cmd): Likewise.
1230         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1231         std::vector.
1232         (btrace_data::empty): Likewise.
1233         (btrace_data_append): Likewise.
1234         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1235         (typedef btrace_block_s): Delete.
1236         (struct btrace_block): Add constructor.
1237         (struct btrace_data_bts) <blocks>: Change to std::vector.
1238         * nat/linux-btrace.c (perf_event_read_bts): Update for
1239         std::vector.
1240         (linux_read_bts): Likewise.
1241
1242 2019-10-01  Tom Tromey  <tom@tromey.com>
1243
1244         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1245
1246 2019-10-01  Tom Tromey  <tom@tromey.com>
1247
1248         * stack.c (print_frame, info_frame_command_core): Use
1249         styled_string.
1250         * linux-thread-db.c (try_thread_db_load_1)
1251         (try_thread_db_load_from_pdir_1): Use styled_string.
1252         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1253         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1254         (maybe_print_unsupported_script_warning)
1255         (maybe_print_script_not_found_warning): Use styled_string.
1256         * ada-lang.c (user_select_syms): Use styled_string.
1257
1258 2019-10-01  Tom Tromey  <tom@tromey.com>
1259
1260         * p-lang.c (pascal_printstr): Use metadata style.
1261         * value.c (show_convenience): Use metadata style.
1262         * valprint.c (valprint_check_validity, val_print_optimized_out)
1263         (val_print_not_saved, val_print_unavailable)
1264         (val_print_invalid_address, generic_val_print, val_print)
1265         (value_check_printable, val_print_array_elements): Use metadata
1266         style.
1267         * ui-out.h (class ui_out) <field_fmt>: New overload.
1268         <do_field_fmt>: Add style parameter.
1269         * ui-out.c (ui_out::field_fmt): New overload.
1270         * typeprint.c (type_print_unknown_return_type)
1271         (val_print_not_allocated, val_print_not_associated): Use metadata
1272         style.
1273         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1274         parameter.
1275         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1276         * tracepoint.c (tvariables_info_1): Use metadata style.
1277         * stack.c (print_frame_arg, print_frame_info, print_frame)
1278         (info_frame_command_core): Use metadata style.
1279         * skip.c (info_skip_command): Use metadata style.
1280         * rust-lang.c (rust_print_enum): Use metadata style.
1281         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1282         metadata style.
1283         * python/py-framefilter.c (py_print_single_arg): Use metadata
1284         style.
1285         * printcmd.c (do_one_display, print_variable_and_value): Use
1286         metadata style.
1287         * p-valprint.c (pascal_val_print)
1288         (pascal_object_print_value_fields): Use metadata style.
1289         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1290         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1291         parameter.
1292         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1293         * m2-valprint.c (m2_print_long_set): Use metadata style.
1294         * m2-typeprint.c (m2_print_type): Use metadata style.
1295         * infcmd.c (print_return_value_1): Use metadata style.
1296         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1297         * f-valprint.c (info_common_command_for_block): Use metadata
1298         style.
1299         * f-typeprint.c (f_type_print_base): Use metadata style.
1300         * expprint.c (print_subexp_standard): Use metadata style.
1301         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1302         * cli/cli-style.h (class cli_style_option): Add constructor.
1303         (metadata_style): Declare.
1304         * cli/cli-style.c (metadata_style): New global.
1305         (_initialize_cli_style): Register metadata style.
1306         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1307         parameter.
1308         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1309         * c-typeprint.c (c_type_print_base_struct_union)
1310         (c_type_print_base_1): Use metadata style.
1311         * breakpoint.c (watchpoint_value_print)
1312         (print_one_breakpoint_location): Use metadata style.
1313         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1314         style.
1315         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1316         style.
1317         * ada-valprint.c (val_print_packed_array_elements, printstr)
1318         (print_field_values, ada_val_print_ref, ada_val_print): Use
1319         metadata style.
1320         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1321         style.
1322         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1323         style.
1324         * ada-lang.c (user_select_syms): Use metadata style.
1325
1326 2019-10-01  Tom Tromey  <tom@tromey.com>
1327
1328         * cli/cli-cmds.c (pwd_command): Style output.
1329
1330 2019-10-01  Pedro Alves  <palves@redhat.com>
1331             Tom Tromey  <tom@tromey.com>
1332
1333         * symtab.c (print_symbol_info): Use %ps.
1334         (print_msymbol_info): Use %ps.
1335         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1336         * printcmd.c (print_variable_and_value): Use %ps.
1337         * macrocmd.c (show_pp_source_pos): Use %ps.
1338         * infrun.c (print_exited_reason): Use ui_out::message.
1339         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1340         (describe_other_breakpoints): Use ui_out::message and new
1341         formats.
1342         (say_where): Use new formats.
1343         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1344         and new formats.
1345
1346 2019-10-01  Pedro Alves  <palves@redhat.com>
1347             Tom Tromey  <tom@tromey.com>
1348
1349         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1350         (test_gdb_formats): New function.
1351         (run_tests): Call it.
1352         (test_format_specifier): Update.
1353         * utils.h (fputs_filtered): Update comment.
1354         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1355         (fputs_styled_unfiltered): Declare.
1356         * utils.c (fputs_styled_unfiltered): New function.
1357         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1358         (vfprintf_filtered): Update.
1359         (vfprintf_unfiltered, vprintf_filtered): Update.
1360         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1361         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1362         disallow_ui_out_field>: New constants.
1363         (enum class field_kind): New.
1364         (struct base_field_s, struct signed_field_s): New.
1365         (signed_field): New function.
1366         (struct string_field_s): New.
1367         (string_field): New function.
1368         (struct styled_string_s): New.
1369         (styled_string): New function.
1370         (class ui_out) <message>: Add comment.
1371         <vmessage, call_do_message>: New methods.
1372         <do_message>: Add style parameter.
1373         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1374         methods.
1375         (ui_out::message): Rewrite.
1376         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1377         parameter.
1378         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1379         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1380         gdb_extensions parameter.
1381         (class format_piece): Add parameter to constructor.
1382         (n_int_args): New field.
1383         * gdbsupport/format.c (format_pieces::format_pieces): Add
1384         gdb_extensions parameter.  Handle '*'.
1385         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1386         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1387         vfprintf_styled_no_gdbfmt.
1388         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1389         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1390         unfiltered output.
1391         * ui-style.h (struct ui_file_style) <ptr>: New method.
1392
1393 2019-10-01  Tom Tromey  <tom@tromey.com>
1394
1395         * unittests/format_pieces-selftests.c: Update.  Add final format.
1396         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1397         empty literal pieces.
1398
1399 2019-10-01  Tom Tromey  <tom@tromey.com>
1400
1401         * ui-out.h (enum class ui_out_style_kind): Remove.
1402         (class ui_out) <field_string, field_stsream, do_field_string>:
1403         Change type of "style".
1404         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1405         (ui_out::field_string): Update.
1406         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1407         of "style".
1408         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1409         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1410         * stack.c (print_frame_arg, print_frame_info, print_frame):
1411         Update.
1412         * source.c (print_source_lines_base): Update.
1413         * solib.c (info_sharedlibrary_command): Update.
1414         * skip.c (info_skip_command): Update.
1415         * record-btrace.c (btrace_call_history_src_line)
1416         (btrace_call_history): Update.
1417         * python/py-framefilter.c (py_print_frame): Update.
1418         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1419         "style".
1420         * mi/mi-out.c (mi_ui_out::do_table_header)
1421         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1422         (mi_ui_out::do_field_string): Update.
1423         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1424         Update.
1425         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1426         "style".
1427         * cli-out.c (cli_ui_out::do_table_header)
1428         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1429         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1430         (cli_ui_out::do_field_fmt): Update.
1431         * breakpoint.c (print_breakpoint_location): Update.
1432         (update_static_tracepoint): Update.
1433
1434 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1435
1436         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1437         conversion of gdb_datadir.
1438         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1439         remove not needed c_str ().
1440
1441 2019-09-30  Ali Tamur <tamur@google.com>
1442
1443         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1444         (dwarf2_string_attr): Likewise.
1445
1446 2019-09-30  Ali Tamur <tamur@google.com>
1447
1448         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1449         (process_full_type_unit): Likewise.
1450         (dump_die_shallow): Likewise.
1451         (cu_debug_loc_section): Likewise.
1452
1453 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1454
1455         * minsyms.c (compare_minimal_symbols): Rename to...
1456         (minimal_symbol_is_less_than): ...this, and adjust to STL
1457         conventions (return bool, take arguments as references)
1458         (minimal_symbol_reader::install): Call std::sort instead
1459         of qsort.
1460
1461 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1462
1463         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1464         hash and why.
1465         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1466         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1467
1468 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1469
1470         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1471         * psympriv.h (add_psymbol_to_list): Move comment here and update
1472         it.
1473
1474 2019-09-29  Tom de Vries  <tdevries@suse.de>
1475
1476         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1477         Use $tmpdir/$(basename "$output_file").dwz instead of
1478         "${output_file}.dwz".
1479
1480 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1481
1482         PR gdb/25045
1483         * hppa-linux-nat.c: Include gdbarch.h.
1484
1485 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1486
1487         * blockframe.c (find_pc_partial_function): Change return type to bool.
1488         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1489         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1490         (stub_gnu_ifunc_resolve_name): Likewise.
1491         * symtab.c (compare_filenames_for_search): Likewise.
1492         (compare_glob_filenames_for_search): Likewise.
1493         (matching_obj_sections): Likewise.
1494         (symbol_matches_domain): Likewise.
1495         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1496         (find_line_pc): Change return type to bool.
1497         (find_line_pc_range): Likewise.
1498         (producer_is_realview): Likewise.
1499         * symtab.h (symbol_matches_domain): Likewise.
1500         (find_pc_partial_function): Likewise.
1501         (find_pc_line_pc_range): Likewise.
1502         (in_gnu_ifunc_stub): Likewise.
1503         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1504         (find_line_pc): Likewise.
1505         (find_line_pc_range): Likewise.
1506         (matching_obj_sections): Likewise.
1507         (find_line_symtab): Change out parameter to bool.
1508         (producer_is_realview): Change return type to bool.
1509         (compare_filenames_for_search): Likewise.
1510         (compare_glob_filenames_for_search): Likewise.
1511
1512 2019-09-26  Tom Tromey  <tom@tromey.com>
1513
1514         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1515         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1516         * gdb_usleep.h: Remove.
1517         * gdb_usleep.c: Remove.
1518         * utils.c: Don't include gdb_usleep.h.
1519
1520 2019-09-26  Tom Tromey  <tromey@adacore.com>
1521
1522         * python/py-type.c (type_to_type_object): Call check_typedef
1523         for stub types.
1524
1525 2019-09-26  Tom Tromey  <tom@tromey.com>
1526
1527         * utils.h (initialize_utils): Don't declare.
1528         * top.c (gdb_init): Don't call initialize_utils.
1529         * utils.c (initialize_utils): Remove.  Move contents...
1530         (_initialize_utils): ... here.
1531
1532 2019-09-25  Tom Tromey  <tom@tromey.com>
1533
1534         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1535         * utils.h (make_hex_string): Don't declare.
1536         * utils.c (make_hex_string): Remove.
1537
1538 2019-09-24  Tom de Vries  <tdevries@suse.de>
1539
1540         PR gdb/23815
1541         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1542         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1543
1544 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1545
1546         * NEWS: Mention new simulator port for PRU.
1547
1548 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * ada-exp.y (write_object_remaining): Update.
1551         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1552         and eliminate the static buffer.
1553         (ada_decode_symbol): Update.
1554         (ada_la_decode): Update.
1555         (ada_sniff_from_mangled_name): Update.
1556         (is_valid_name_for_wild_match): Update.
1557         (ada_lookup_name_info::matches): Update and simplify.
1558         (name_matches_regex): Update.
1559         (ada_add_global_exceptions): Update.
1560         * ada-lang.h (ada_decode): Update signature.
1561         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1562         * dwarf-index-write.c (debug_names::insert): Update.
1563
1564 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1565
1566         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1567         formatting.
1568
1569 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1570
1571         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1572         Change "nonzero" to "true" in documentation.
1573
1574 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1575
1576         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1577         (_initialize_darwin_solib): Don't set
1578         darwin_so_ops.lookup_lib_global_symbol.
1579         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1580         set_gdbarch_iterate_over_objfiles_in_search_order.
1581         (elf_lookup_lib_symbol): Rename to...
1582         (svr4_iterate_over_objfiles_in_search_order): this, and update
1583         to iterate semantics.
1584         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1585         * solib.c (solib_global_lookup): Remove.
1586         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1587         (solib_global_lookup): Remove.
1588         * symtab.c (lookup_global_or_static_symbol): Remove call to
1589         solib_global_lookup.
1590
1591 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1592
1593         * NEWS: Move entries about default MI version now being
1594         version 3, and about the GDB/MI fix for multi-location
1595         breakpoints to the "since GDB 8.3" section.
1596
1597 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1598
1599         GDB 8.3.1 released.
1600
1601 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1602
1603         * NEWS: Mention that Cell/B.E. debugging support was removed.
1604         * MAINTAINERS: Remove spu target.
1605
1606         * config/djgpp/fnchange.lst: Remove entries for removed files.
1607
1608         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1609         spu-multiarch.o, and spu-tdep.o.
1610         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1611         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1612         spu-multiarch.c, and spu-tdep.c.
1613         * spu-linux-nat.c: Remove file.
1614         * spu-multiarch.c: Remove file.
1615         * spu-tdep.c: Remove file.
1616         * spu-tdep.h: Remove file.
1617         * solib-spu.c: Remove file.
1618         * solib-spu.h: Remove file.
1619
1620         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1621         * configure.nat (spu-linux): Remove.
1622         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1623         solib-multiarch.o from gdb_target_obs.
1624         (spu*-*-*): Remove.
1625
1626         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1627         feature flag.
1628         (ppc_linux_no_features): Update.
1629         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1630         Cell/B.E. support.
1631         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1632         (tdesc_powerpc_cell64l): Likewise.
1633         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1634         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1635         Cell/B.E. support.
1636         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1637         Do not include "features/rs6000/powerpc-cell32l.c" or
1638         "features/rs6000/powerpc-cell64l.c".
1639         (ppc_linux_spu_section): Remove.
1640         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1641         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1642         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1643         (ppc_linux_spe_context_lookup): Remove.
1644         (ppc_linux_spe_context_inferior_created): Remove.
1645         (ppc_linux_spe_context_solib_loaded): Remove.
1646         (ppc_linux_spe_context_solib_unloaded): Remove.
1647         (ppc_linux_spe_context): Remove.
1648         (struct ppu2spu_cache): Remove.
1649         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1650         (struct ppu2spu_data): Remove.
1651         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1652         ppu2spu_unwind): Remove.
1653         (ppc_linux_init_abi): Remove Cell/B.E. support.
1654         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1655
1656         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1657         (rs6000/powerpc-cell64l-expedite): Likewise
1658         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1659         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1660         rs6000/powerpc-cell64l.xml.
1661         * features/rs6000/powerpc-cell32l.xml: Remove.
1662         * features/rs6000/powerpc-cell64l.xml: Likewise.
1663         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1664         * features/rs6000/powerpc-cell64l.c: Likewise.
1665         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1666         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1667         * regformats/reg-spu.dat: Remove.
1668
1669         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1670         * corelow.c (struct spuid_list): Remove.
1671         (add_to_spuid_list): Remove.
1672         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1673         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1674         (remote_protocol_features): Remove associated entries.
1675         (_initialize_remote): No longer initialize them.
1676         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1677         * linux-nat.c (SPUFS_MAGIC): Remove.
1678         (linux_proc_xfer_spu): Remove.
1679         (spu_enumerate_spu_ids): Remove.
1680         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1681         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1682         (linux_make_corefile_notes): No longer call it.
1683
1684         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1685         (cooked_write_test): Likewise.
1686
1687 2019-09-20  Tom Tromey  <tom@tromey.com>
1688
1689         * NEWS: Mention case-sensitivity of TUI commands.
1690         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1691         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1692         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1693
1694 2019-09-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-source.c (tui_source_window::set_contents): Use
1697         make_unique_xstrdup.
1698         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1699         make_unique_xstrdup.
1700
1701 2019-09-20  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-data.c: Remove separator comments.
1704         * tui/tui-layout.c: Remove separator comments.
1705         * tui/tui-win.c: Remove separator comments.
1706         * tui/tui-wingeneral.c: Remove separator comments.
1707
1708 2019-09-20  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui.h (strcat_to_buf): Don't declare.
1711         * tui/tui.c (strcat_to_buf): Remove.
1712
1713 2019-09-20  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1716         from "fullname".
1717         * tui/tui-source.c (tui_source_window::set_contents)
1718         (tui_source_window::location_matches_p)
1719         (tui_source_window::maybe_update): Update.
1720
1721 2019-09-20  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1724         Update.
1725         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1726         prefix.
1727         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1728         (tui_data_window::line_from_reg_element_no)
1729         (tui_data_window::first_reg_element_no_inline)
1730         (tui_data_window::show_registers)
1731         (tui_data_window::show_register_group)
1732         (tui_data_window::display_registers_from)
1733         (tui_data_window::display_registers_from_line)
1734         (tui_data_window::first_data_item_displayed)
1735         (tui_data_window::delete_data_content_windows)
1736         (tui_data_window::erase_data_content)
1737         (tui_data_window::do_scroll_vertical)
1738         (tui_data_window::refresh_window)
1739         (tui_data_window::check_register_values): Update.
1740
1741 2019-09-20  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1744         (struct tui_locator_window) <full_name, proc_name>: Now
1745         std::string.
1746         * tui/tui-stack.c (tui_locator_window::make_status_line)
1747         (tui_locator_window::set_locator_fullname)
1748         (tui_locator_window::set_locator_info): Update.
1749         * tui/tui-source.c (tui_source_window::set_contents)
1750         (tui_source_window::showing_source_p): Update.
1751
1752 2019-09-20  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1755         Don't call tui_locator_win_info_ptr.
1756
1757 2019-09-20  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1760
1761 2019-09-20  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1764         height for locator.
1765         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1766         * tui/tui-layout.c (show_source_disasm_command, show_data)
1767         (show_source_or_disasm_and_command): Use 1 as height for locator.
1768
1769 2019-09-20  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui.c (tui_enable): Update.
1772         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1773         Update.
1774         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1775         Update.
1776         * tui/tui-data.c (win_resized): Now bool.
1777         (tui_win_resized): Return bool.
1778         (tui_set_win_resized_to): Accept a bool.
1779
1780 2019-09-20  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1783         Change type of "refresh_values_only".
1784         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1785         type of "refresh_values_only".
1786
1787 2019-09-20  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1790         std::string.
1791         (tui_disassemble): Add "pos" parameter.
1792         (tui_disasm_window::set_contents): Simplify.
1793
1794 2019-09-20  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.h (struct tui_source_window_base)
1797         <show_source_content>: Now private.
1798         * tui/tui-winsource.c
1799         (tui_source_window_base::show_source_content): Don't handle empty
1800         content case.
1801
1802 2019-09-20  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-layout.c (show_source_disasm_command)
1805         (show_source_or_disasm_and_command): Don't call
1806         show_source_content.
1807
1808 2019-09-20  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1811         Declare.
1812         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1813         from tui_make_status_line.
1814         (tui_locator_window::rerender): Update.
1815
1816 2019-09-20  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1819         (tui_locator_window::rerender): Update.
1820
1821 2019-09-20  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.h (struct tui_source_window_base)
1824         <~tui_source_window_base>: Don't declare.
1825         <fullname>: Remove.
1826         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1827         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1828         member.
1829         * tui/tui-source.c (tui_source_window::set_contents): Update.
1830         (tui_source_window::location_matches_p)
1831         (tui_source_window::maybe_update): Update.
1832
1833 2019-09-20  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-winsource.h (~tui_source_element): Remove.
1836         (tui_source_element): Update.
1837         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1838         * tui/tui-winsource.c (tui_show_source_line): Update.
1839         * tui/tui-source.c (tui_source_window::set_contents): Update.
1840         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1841
1842 2019-09-20  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1845         declare.
1846         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1847         tui_clear_source_windows_detail.
1848         * tui/tui-winsource.h (struct tui_source_window_base)
1849         <clear_detail>: Don't declare.
1850         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1851         Remove.
1852         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1853
1854 2019-09-20  Tom Tromey  <tromey@adacore.com>
1855
1856         PR ada/24919:
1857         * block.c (contained_in): Fix final return value.
1858
1859 2019-09-20  Alan Modra  <amodra@gmail.com>
1860
1861         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1862         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1863         (read_indirect_string_from_dwz): Use bfd accessor.
1864         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1865         * machoread.c (macho_symfile_read_all_oso): Likewise.
1866         * solib.c (solib_bfd_open): Likewise.
1867
1868 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1869
1870         * eval.c: Move declaration of overload_resolution to...
1871         * value.h: ...here.
1872
1873 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1874
1875         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1876         * arm-linux-tdep.c: Likewise.
1877         * arm-nbsd-nat.c: Likewise.
1878         * arm-tdep.h: Declare arm_apcs_32.
1879         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1880
1881 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1882
1883         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1884         * dwarf2read.h: Declare dwarf_always_disassemble.
1885
1886 2019-09-19  Tom de Vries  <tdevries@suse.de>
1887
1888         PR gdb/25009
1889         * source-cache.c (source_cache::ensure): Catch exception thrown during
1890         construction of the highlighter.
1891
1892 2019-09-18  Alan Modra  <amodra@gmail.com>
1893
1894         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1895         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1896         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1897         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1898         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1899         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1900         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1901         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1902         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1903         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1904         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1905         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1906         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1907         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1908         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1909         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1910         * mi/mi-interp.c: Update throughout for bfd section macro and
1911         function changes.
1912         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1913         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1914
1915 2019-09-18  Tom Tromey  <tom@tromey.com>
1916
1917         * NEWS: Add entry.
1918         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1919         call rl_initialize.
1920         (tui_enable): Do not call rl_initialize.
1921
1922 2019-09-18  Christian Groessler  <chris@groessler.org>
1923
1924         * alpha-linux-nat.c: Include gdbarch.h.
1925
1926 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1927
1928         * ui-file.c: Include cli/cli-style.h.
1929         (term_cli_styling): Remove cli_styling declaration.
1930
1931 2019-09-18  Alan Modra  <amodra@gmail.com>
1932
1933         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1934         to bfd_asymbol_section.
1935
1936 2019-09-18  Alan Modra  <amodra@gmail.com>
1937
1938         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1939         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1940         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1941
1942 2019-09-18  Alan Modra  <amodra@gmail.com>
1943
1944         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1945         * spu-linux-nat.c (spu_bfd_open): Likewise.
1946
1947 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1948
1949         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1950         to bool to match definition in dwarf2read.c.
1951
1952 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1953
1954         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1955         (print_signatures): Likewise.
1956         (trust_pad_over_xvs): Likewise.
1957         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1958         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1959         * arm-linux-nat.c (arm_apcs_32): Likewise.
1960         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1961         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1962         * arm-tdep.c (arm_debug): Likewise.
1963         (arm_apcs_32): Likewise.
1964         * auto-load.c (debug_auto_load): Likewise.
1965         (auto_load_gdb_scripts): Likewise.
1966         (global_auto_load): Likewise.
1967         (auto_load_local_gdbinit): Likewise.
1968         (auto_load_local_gdbinit_loaded): Likewise.
1969         * auto-load.h (global_auto_load): Likewise.
1970         (auto_load_local_gdbinit): Likewise.
1971         (auto_load_local_gdbinit_loaded): Likewise.
1972         * breakpoint.c (disconnected_dprintf): Likewise.
1973         (breakpoint_proceeded): Likewise.
1974         (automatic_hardware_breakpoints): Likewise.
1975         (always_inserted_mode): Likewise.
1976         (target_exact_watchpoints): Likewise.
1977         (_initialize_breakpoint): Update.
1978         * breakpoint.h (target_exact_watchpoints): Change to bool.
1979         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1980         * cli/cli-cmds.c (trace_commands): Likewise.
1981         * cli/cli-cmds.h (trace_commands): Likewise.
1982         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1983         to bool*.
1984         * cli/cli-logging.c (logging_overwrite): Change to bool.
1985         (logging_redirect): Likewise.
1986         (debug_redirect): Likewise.
1987         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1988         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1989         to bool.
1990         <boolean_option_def>: Update.
1991         (struct flag_option_def): Change default type of Context to bool
1992         from int.
1993         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1994         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1995         (get_setshow_command_value_string): Likewise.
1996         * cli/cli-style.c (cli_styling): Change to bool.
1997         (source_styling): Likewise.
1998         * cli/cli-style.h (source_styling): Likewise.
1999         (cli_styling): Likewise.
2000         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2001         to bool.
2002         * command.h (var_types): Update comment.
2003         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2004         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2005         bool.
2006         (debug_compile_cplus_scopes): Likewise.
2007         * compile/compile-internal.h (compile_debug): Likewise.
2008         * compile/compile.c (compile_debug): Likewise.
2009         (struct compile_options) <raw>: Likewise.
2010         * cp-support.c (catch_demangler_crashes): Likewise.
2011         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2012         (usr_cmd_cris_dwarf2_cfi): Likewise.
2013         * csky-tdep.c (csky_debug): Likewise.
2014         * darwin-nat.c (enable_mach_exceptions): Likewise.
2015         * dcache.c (dcache_enabled_p): Likewise.
2016         * defs.h (info_verbose): Likewise.
2017         * demangle.c (demangle): Likewise.
2018         (asm_demangle): Likewise.
2019         * dwarf-index-cache.c (debug_index_cache): Likewise.
2020         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2021         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2022         * dwarf2read.c (check_physname): Likewise.
2023         (use_deprecated_index_sections): Likewise.
2024         (dwarf_always_disassemble): Likewise.
2025         * eval.c (overload_resolution): Likewise.
2026         * event-top.c (set_editing_cmd_var): Likewise.
2027         (exec_done_display_p): Likewise.
2028         * event-top.h (set_editing_cmd_var): Likewise.
2029         (exec_done_display_p): Likewise.
2030         * exec.c (write_files): Likewise.
2031         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2032         (debug_fbsd_nat): Likewise.
2033         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2034         Likewise.
2035         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2036         <backtrace_past_entry> Likewise.
2037         * gdb-demangle.h (demangle): Likewise.
2038         (asm_demangle): Likewise.
2039         * gdb_bfd.c (bfd_sharing): Likewise.
2040         * gdbcore.h (write_files): Likewise.
2041         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2042         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2043         * gdbthread.h (print_thread_events): Likewise.
2044         * gdbtypes.c (opaque_type_resolution): Likewise.
2045         (strict_type_checking): Likewise.
2046         * gnu-nat.c (gnu_debug_flag): Likewise.
2047         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2048         * guile/scm-param.c (pascm_variable): Add boolval.
2049         (add_setshow_generic): Update.
2050         (pascm_param_value): Update.
2051         (pascm_set_param_value_x): Update.
2052         * hppa-tdep.c (hppa_debug): Change to bool..
2053         * infcall.c (may_call_functions_p): Likewise.
2054         (coerce_float_to_double_p): Likewise.
2055         (unwind_on_signal_p): Likewise.
2056         (unwind_on_terminating_exception_p): Likewise.
2057         * infcmd.c (startup_with_shell): Likewise.
2058         * inferior.c (print_inferior_events): Likewise.
2059         * inferior.h (startup_with_shell): Likewise.
2060         (print_inferior_events): Likewise.
2061         * infrun.c (step_stop_if_no_debug): Likewise.
2062         (detach_fork): Likewise.
2063         (debug_displaced): Likewise.
2064         (disable_randomization): Likewise.
2065         (non_stop): Likewise.
2066         (non_stop_1): Likewise.
2067         (observer_mode): Likewise.
2068         (observer_mode_1): Likewise.
2069         (set_observer_mode): Update.
2070         (sched_multi): Change to bool.
2071         * infrun.h (debug_displaced): Likewise.
2072         (sched_multi): Likewise.
2073         (step_stop_if_no_debug): Likewise.
2074         (non_stop): Likewise.
2075         (disable_randomization): Likewise.
2076         * linux-tdep.c (use_coredump_filter): Likewise.
2077         (dump_excluded_mappings): Likewise.
2078         * linux-thread-db.c (auto_load_thread_db): Likewise.
2079         (check_thread_db_on_load): Likewise.
2080         * main.c (captured_main_1): Update.
2081         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2082         xx2_opt, boolean_opt>: Change to bool.
2083         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2084         * maint.c (maintenance_profile_p): Likewise.
2085         (per_command_time): Likewise.
2086         (per_command_space): Likewise.
2087         (per_command_symtab): Likewise.
2088         * memattr.c (inaccessible_by_default): Likewise.
2089         * mi/mi-main.c (mi_async): Likewise.
2090         (mi_async_1): Likewise.
2091         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2092         * nat/fork-inferior.h (startup_with_shell): Likewise.
2093         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2094         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2095         * nios2-tdep.c (nios2_debug): Likewise.
2096         * or1k-tdep.c (or1k_debug): Likewise.
2097         * parse.c (parser_debug): Likewise.
2098         * parser-defs.h (parser_debug): Likewise.
2099         * printcmd.c (print_symbol_filename): Likewise.
2100         * proc-api.c (procfs_trace): Likewise.
2101         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2102         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2103         (set_parameter_value): Update.
2104         (add_setshow_generic): Update.
2105         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2106         to bool*.
2107         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2108         int*.
2109         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2110         * record-btrace.c (record_btrace_target::store_registers): Update.
2111         * record-full.c (record_full_memory_query): Change to bool.
2112         (record_full_stop_at_limit): Likewise.
2113         * record-full.h (record_full_memory_query): Likewise.
2114         * remote-notif.c (notif_debug): Likewise.
2115         * remote-notif.h (notif_debug): Likewise.
2116         * remote.c (use_range_stepping): Likewise.
2117         (interrupt_on_connect): Likewise.
2118         (remote_break): Likewise.
2119         * ser-tcp.c (tcp_auto_retry): Likewise.
2120         * ser-unix.c (serial_hwflow): Likewise.
2121         * skip.c (debug_skip): Likewise.
2122         * solib-aix.c (solib_aix_debug): Likewise.
2123         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2124         (spu_auto_flush_cache_p): Likewise.
2125         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2126         Likewise.
2127         (struct info_print_options) <quiet>: Likewise.
2128         * symfile-debug.c (debug_symfile): Likewise.
2129         * symfile.c (auto_solib_add): Likewise.
2130         (separate_debug_file_debug): Likewise.
2131         * symfile.h (auto_solib_add): Likewise.
2132         (separate_debug_file_debug): Likewise.
2133         * symtab.c (basenames_may_differ): Likewise.
2134         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2135         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2136         (struct info_types_options) <quiet>: Likewise.
2137         * symtab.h (demangle): Likewise.
2138         (basenames_may_differ): Likewise.
2139         * target-dcache.c (stack_cache_enabled_1): Likewise.
2140         (code_cache_enabled_1): Likewise.
2141         * target.c (trust_readonly): Likewise.
2142         (may_write_registers): Likewise.
2143         (may_write_memory): Likewise.
2144         (may_insert_breakpoints): Likewise.
2145         (may_insert_tracepoints): Likewise.
2146         (may_insert_fast_tracepoints): Likewise.
2147         (may_stop): Likewise.
2148         (auto_connect_native_target): Likewise.
2149         (target_stop_and_wait): Update.
2150         (target_async_permitted): Change to bool.
2151         (target_async_permitted_1): Likewise.
2152         (may_write_registers_1): Likewise.
2153         (may_write_memory_1): Likewise.
2154         (may_insert_breakpoints_1): Likewise.
2155         (may_insert_tracepoints_1): Likewise.
2156         (may_insert_fast_tracepoints_1): Likewise.
2157         (may_stop_1): Likewise.
2158         * target.h (target_async_permitted): Likewise.
2159         (may_write_registers): Likewise.
2160         (may_write_memory): Likewise.
2161         (may_insert_breakpoints): Likewise.
2162         (may_insert_tracepoints): Likewise.
2163         (may_insert_fast_tracepoints): Likewise.
2164         (may_stop): Likewise.
2165         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2166         (make_thread_apply_all_options_def_group): Change argument from int*
2167         to bool*.
2168         (thread_apply_all_command): Update.
2169         (print_thread_events): Change to bool.
2170         * top.c (confirm): Likewise.
2171         (command_editing_p): Likewise.
2172         (history_expansion_p): Likewise.
2173         (write_history_p): Likewise.
2174         (info_verbose): Likewise.
2175         * top.h (confirm): Likewise.
2176         (history_expansion_p): Likewise.
2177         * tracepoint.c (disconnected_tracing): Likewise.
2178         (circular_trace_buffer): Likewise.
2179         * typeprint.c (print_methods): Likewise.
2180         (print_typedefs): Likewise.
2181         * utils.c (debug_timestamp): Likewise.
2182         (sevenbit_strings): Likewise.
2183         (pagination_enabled): Likewise.
2184         * utils.h (sevenbit_strings): Likewise.
2185         (pagination_enabled): Likewise.
2186         * valops.c (overload_resolution): Likewise.
2187         * valprint.h (struct value_print_options) <prettyformat_arrays,
2188         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2189         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2190         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2191         Likewise.
2192         * windows-nat.c (new_console): Likewise.
2193         (cygwin_exceptions): Likewise.
2194         (new_group): Likewise.
2195         (debug_exec): Likewise.
2196         (debug_events): Likewise.
2197         (debug_memory): Likewise.
2198         (debug_exceptions): Likewise.
2199         (useshell): Likewise.
2200         * windows-tdep.c (maint_display_all_tib): Likewise.
2201         * xml-support.c (debug_xml): Likewise.
2202
2203 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2204
2205         * source.c (prepare_path_for_appending): New function.
2206         (openp): Make use of new function.
2207         (find_and_open_source): Search for the compilation directory and
2208         source file as a relative path beneath the directory search path.
2209
2210 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * source-cache.c (source_cache::get_line_charpos): Catch
2213         exceptions and return false, this matches the behaviour documented
2214         in the header file.
2215
2216 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2217
2218         * ada-tasks.c (info_task): Remove quoting of the task's name.
2219
2220 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2221
2222         * symfile.c (auto_solib_add): Replace comment with a reference
2223         to the header file.
2224
2225 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2226
2227         * NEWS: Mention that gdb can now be compiled with Python 3
2228         on Windows.
2229
2230 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * maint.c (maint_print_section_data::maint_print_section_data):
2233         Force use of 'float log10 (float)' by casting the argument to
2234         float.
2235
2236 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * maint.c: Add 'cmath' include.
2239         (struct maint_print_section_data): New structure.
2240         (print_section_index): New function.
2241         (print_bfd_section_info): Add header comment, small whitespace
2242         cleanup, and update to call new print_section_index function.
2243         (print_objfile_section_info): Likewise.
2244         (maint_obj_section_from_bfd_section): New function.
2245         (print_bfd_section_info_maybe_relocated): New function.
2246         (maintenance_info_sections): Add header comment, always use
2247         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2248
2249 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2252         inner scope, add check that the objfile has psymtabs before
2253         checking psymtabs_addrmap.
2254         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2255
2256 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2257
2258         * NEWS: Announce that Ada task names are now shown at more places,
2259         and between quotes (except in info task output).
2260         * gdb/ada-tasks.c (task_to_str): New function.
2261         (display_current_task_id): Call task_to_str.
2262         (task_command_1): Likewise.
2263         (print_ada_task_info): In non-mi mode, Properly align headers and data
2264         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2265
2266 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2267
2268         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2269         prstatus.pr_lwp.pr_info instead of making it up.
2270
2271 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2272
2273         * auto-load.c (auto_load_expand_dir_vars): Update.
2274         * defs.h (gdb_datadir): Change to std::string.
2275         (python_libdir): Likewise.
2276         (relocate_gdb_directory): Change return type to std::string.
2277         * guile/guile.c (gdbscm_data_directory): Update.
2278         (initialize_scheme_side): Update.
2279         * jit.c (jit_reader_dir): Change to std::string.
2280         (jit_reader_load_command): Update.
2281         * main.c (gdb_datadir): Change to std::string.
2282         (python_libdir): Likewise.
2283         (set_gdb_data_directory): Update.
2284         (relocate_path): Change to return std::string.
2285         (relocate_gdb_directory): Change to return std::string.
2286         (relocate_gdbinit_path_maybe_in_datadir): Update.
2287         (captured_main_1): Update.
2288         * python/python.c (do_start_initialization): Update.
2289         * top.c (show_gdb_datadir): Update.
2290         * xml-syscall.c (xml_init_syscalls_info): Update.
2291         (init_syscalls_info): Update.
2292
2293 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2294
2295         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2296         out of get_init_files.
2297         (get_init_files): Update.
2298
2299 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2300
2301         * main.c (get_init_files): Change to use std::string.
2302         (captured_main_1): Update.
2303         (print_gdb_help): Update.
2304
2305 2019-09-11  Ali Tamur  <tamur@google.com>
2306
2307         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2308         implementation.
2309
2310 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2311
2312         * dbxread.c (read_dbx_symtab): Update.
2313         * dwarf2read.c (load_partial_dies): Update.
2314         * mdebugread.c (parse_partial_symbols): Update.
2315         (handle_psymbol_enumerators): Update.
2316         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2317         * psymtab.c (add_psymbol_to_bcache): Likewise.
2318         (add_psymbol_to_list): Likewise.
2319         * symtab.c (symbol_set_names): Likewise.
2320         * symtab.h (symbol_set_names): Likewise.
2321         * xcoffread.c (scan_xcoff_symtab): Update.
2322
2323 2019-09-11  Tom Tromey  <tom@tromey.com>
2324
2325         * symfile-mem.c (symbol_file_add_from_memory): Use
2326         bfd_set_filename.
2327         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2328         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2329
2330 2019-09-10  Tom Tromey  <tromey@adacore.com>
2331
2332         * dwarf-index-write.c (write_psymbols): Extend error message.
2333         (debug_names::insert): Add Ada code.
2334         (debug_names::write_psymbols): Remove Ada check.
2335         (debug_names) <m_string_obstack>: New member.
2336         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2337         (gdb_index_symbol_name_matcher::matches): Remove.
2338         (mapped_index_base::find_name_components_bounds): Add "lang"
2339         parameter.
2340         (mapped_index_base::build_name_components): Also split names
2341         according to Ada syntax.
2342         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2343         type of "match_callback".
2344         (check_match, check_find_bounds_finds)
2345         (dw2_expand_symtabs_matching): Update.
2346         (dw2_debug_names_iterator): Add new constructor.
2347         (dw2_debug_names_map_matching_symbols): New function.
2348         (dw2_debug_names_expand_symtabs_matching): Update.
2349         (dwarf2_debug_names_functions): Use
2350         dw2_debug_names_map_matching_symbols.
2351
2352 2019-09-10  Tom Tromey  <tromey@adacore.com>
2353
2354         * dwarf2read.c (dw2_get_file_names_reader): Add the
2355         CU's file name to the results.
2356
2357 2019-09-10  Tom Tromey  <tromey@adacore.com>
2358
2359         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2360         map_matching_symbols.  Update.
2361         * dwarf2read.c (dw2_map_matching_symbols): Update.
2362         * psymtab.c (match_partial_symbol): Change type; update.
2363         (psym_map_matching_symbols): Likewise.
2364         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2365         type; update.
2366         * symfile.h (struct quick_symbol_functions)
2367         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2368         Remove "match".
2369
2370 2019-09-10  Tom Tromey  <tromey@adacore.com>
2371
2372         * psymtab.c (map_block): Remove.
2373         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2374         * symtab.c (iterate_over_symbols_terminated): New function.
2375         * symtab.c (iterate_over_symbols_terminated): Declare.
2376
2377 2019-09-10  Tom Tromey  <tromey@adacore.com>
2378
2379         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2380         * language.h (struct language_defn) <la_iterate_over_symbols>:
2381         Return bool.
2382         * symtab.c (iterate_over_symbols): Return bool.
2383         * symtab.h (iterate_over_symbols): Return bool.
2384
2385 2019-09-10  Tom Tromey  <tromey@adacore.com>
2386
2387         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2388         (add_nonlocal_symbols): Update.
2389         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2390         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2391         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2392         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2393         Change type of "callback".  Remove "data".
2394
2395
2396 2019-09-09  Ali Tamur  <tamur@google.com>
2397
2398         * dwarf2read.c (comp_unit_head): Update comment.
2399         (dwarf2_dwo_name): New function declaration.
2400         (dwarf_unit_type_name): New function declaration.
2401         (read_comp_unit_head): Add support for new compilation units,
2402         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2403         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2404         (currently named as "signature") in their header. Also clarify error
2405         messages.
2406         (lookup_dwo_id): New function. Returns the dwo id of the given
2407         compile unit.
2408         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2409         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2410         functions.
2411         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2412         (dwarf2_dwo_name): Get the dwo name if present.
2413         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2414         purposes.
2415
2416 2019-09-09  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2419
2420 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2421
2422         * python/python.c (do_start_initialization): Make progname_copy static,
2423         to avoid a leak report.
2424
2425 2019-09-08  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2428
2429 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2430
2431         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2432         Change type to gdb::optional<block_enum>.
2433         (dw2_symtab_iter_init): Change block_index parameter type
2434         to gdb::optional<block_enum>.
2435         (dw2_lookup_symbol): Change block_index parameter
2436         type to block_enum.c
2437         (dw2_debug_names_lookup_symbol): Likewise.
2438         * psymtab.c (psym_lookup_symbol): Likewise.
2439         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2440         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2441         Likewise.
2442
2443 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2444
2445         * defs.h (relocate_gdb_directory): Change int to bool in
2446         signature and rename flag to relocatable.
2447         * main.c (relocate_path): Likewise.
2448         (relocate_gdb_directory): Likewise.
2449
2450 2019-09-06  Alan Modra  <amodra@gmail.com>
2451
2452         * coffread.c (coff_symfile_read): Constify filename variable.
2453         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2454         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2455         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2456         * solib.c (reload_shared_libraries_1): Likewise.
2457         * symfile.c (reread_symbols): Likewise.
2458         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2459         * solib-darwin.c (darwin_bfd_open): Likewise.
2460         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2461
2462 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2465         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2466
2467 2019-09-03  Tom Tromey  <tromey@adacore.com>
2468
2469         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2470         types.
2471         (has_negatives): Unbias a range type bound.
2472         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2473         * gdbtypes.c (operator==): Handle new field.
2474         (create_range_type): Add "bias" parameter.
2475         (create_static_range_type, resolve_dynamic_range): Update.
2476         * gdbtypes.h (struct range_bounds) <bias>: New member.
2477         (create_range_type): Add bias parameter.
2478         * printcmd.c (print_scalar_formatted): Unbias range types.
2479         * value.c (unpack_long): Unbias range types.
2480         (pack_long): Bias range types.
2481
2482 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2483
2484         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2485         probe arguments.
2486
2487 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2488
2489         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2490         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2491         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2492         (compile_probe_arg): Likewise.
2493         * probe.h (get_argument_count): Likewise.
2494         * solib-svr4.c (solib_event_probe_action): Likewise.
2495         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2496
2497 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2498
2499         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2500         code to here...
2501         (svr4_create_solib_event_breakpoints): ...from here.
2502
2503 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2504
2505         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2506         suffix from warning message.
2507
2508 2019-08-30  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-winsource.h (struct tui_source_window_base)
2511         <refresh_all>: Don't declare.
2512         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2513         Remove.
2514         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2515         tui_show_locator_content.
2516         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2517         declare.
2518         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2519         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2520         declare.
2521
2522 2019-08-30  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2525
2526 2019-08-30  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2529         Remove unnecessary forward declarations.
2530
2531 2019-08-30  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2534         rerender.
2535         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2536         tui_show_locator_content.
2537
2538 2019-08-30  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2541         (tui_locator_window::rerender): Rewrite using body of previous
2542         tui_show_locator_content.
2543
2544 2019-08-30  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2547         set_locator_fullname>: New methods.
2548         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2549         Rename from tui_set_locator_fullname.
2550         (tui_locator_window::set_locator_info): Rename from
2551         tui_set_locator_info.  Return bool.
2552         (tui_update_locator_fullname, tui_show_frame_info): Update.
2553
2554 2019-08-30  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2557
2558 2019-08-30  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2561         call touchwin.
2562
2563 2019-08-30  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-wingeneral.c (box_win): Assume win_info and
2566         win_info->handle cannot be NULL.
2567
2568 2019-08-30  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2571         refresh_window>: Declare.
2572         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2573         resize.
2574         (tui_data_item_window::rerender): Rename from
2575         tui_display_register.
2576         (tui_data_item_window::refresh_window): New method.
2577         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2578         no-op.
2579
2580 2019-08-30  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2583         regs_column_count, current_group>: Move later.  Now private.
2584         <get_current_group>: New method.
2585         * tui/tui-regs.c (tui_reg_command): Update.
2586         * tui/tui-layout.c (tui_set_layout): Update.
2587
2588 2019-08-30  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2591         (tui_data_window::rerender): Don't call
2592         check_and_display_highlight_if_needed.
2593         (tui_data_window::refresh_all): Remove call to
2594         erase_data_content.
2595
2596 2019-08-30  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2599         (tui_data_window::display_registers_from)
2600         (tui_data_window::display_reg_element_at_line)
2601         (tui_data_window::display_registers_from_line): Remove checks of
2602         "empty".
2603
2604 2019-08-30  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2607         Don't declare.
2608         * tui/tui-regs.c (tui_data_window::show_registers): Call
2609         rerender.
2610         (tui_data_window::rerender): Rename from display_all_data.
2611         (tui_data_window::rerender): Remove old implementation.
2612
2613 2019-08-30  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2616         text.
2617         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2618
2619 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2620             Sergio Durigan Junior  <sergiodj@redhat.com>
2621
2622         PR win32/24284
2623         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2624
2625 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2628         when searching for types.
2629
2630 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * f-lang.c (f_language_defn): Use f_print_typedef.
2633         * f-lang.h (f_print_typedef): Declare.
2634         * f-typeprint.c (f_print_typedef): Define.
2635
2636 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2637
2638         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2639
2640 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * cli/cli-utils.c (info_print_options_defs): Delete.
2643         (make_info_print_options_def_group): Delete.
2644         (extract_info_print_options): Delete.
2645         (info_print_command_completer): Delete.
2646         (info_print_args_help): Add extra parameter, and optionally
2647         include text about -n flag.
2648         * cli/cli-utils.h (struct info_print_options): Delete.
2649         (extract_info_print_options): Delete declaration.
2650         (info_print_command_completer): Delete declaration.
2651         (info_print_args_help): Add extra parameter, extend header
2652         comment.
2653         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2654         search_symbols.
2655         * stack.c (struct info_print_options): New type.
2656         (info_print_options_defs): New file scoped variable.
2657         (make_info_print_options_def_group): New static function.
2658         (info_print_command_completer): New static function.
2659         (info_locals_command): Update to use new local functions.
2660         (info_args_command): Likewise.
2661         (_initialize_stack): Add extra parameter to calls to
2662         info_print_args_help.
2663         * symtab.c (search_symbols): Add extra parameter, use this to
2664         possibly excluse non-debug symbols.
2665         (symtab_symbol_info): Add extra parameter, which is passed on to
2666         search_symbols.
2667         (struct info_print_options): New type.
2668         (info_print_options_defs): New file scoped variable.
2669         (make_info_print_options_def_group): New static function.
2670         (info_print_command_completer): New static function.
2671         (info_variables_command): Update to use local functions, and pass
2672         extra parameter through to symtab_symbol_info.
2673         (info_functions_command): Likewise.
2674         (info_types_command): Pass additional argument through to
2675         symtab_symbol_info.
2676         (rbreak_command): Pass extra argument to search_symbols.
2677         (_initialize_symtab): Add extra arguments for calls to
2678         info_print_args_help, and update help text for 'info variables',
2679         'whereis', and 'info functions' commands.
2680         * symtab.h (search_symbols): Add extra argument to declaration.
2681         * NEWS: Mention new flags.
2682
2683 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2684
2685         * symtab.c (lookup_static_symbol): Call the new function (and move
2686         it down to be next to lookup_global_symbol).
2687         (struct global_sym_lookup_data): Add block_enum member and rename to...
2688         (struct global_or_static_sym_lookup_data): ...this.
2689         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2690         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2691         (lookup_symbol_global_or_static_iterator_cb): ...this.
2692         (lookup_global_or_static_symbol): New function.
2693         (lookup_global_symbol): Call new function.
2694
2695 2019-08-26  Tom de Vries  <tdevries@suse.de>
2696
2697         PR c++/24852
2698         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2699         when pc_probe.prob == NULL.
2700
2701 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2702
2703         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2704         variable symbol_linkage to symbol_linkage_.
2705
2706 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2707
2708         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2709         represent whether the symbol is static, dynamic, or we don't
2710         know.
2711
2712 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2713
2714         * gdb/rx-tdep.c (rx_register_names): New.
2715         (rx_register_name): Delete.
2716         (rx_psw_type): Delete.
2717         (rx_fpsw_type): Delete.
2718         (rx_register_type): Delete.
2719         (rx_gdbarch_init): Convert target-descriptions.
2720         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2721         * gdb/features/Makefile: Add rx.xml.
2722         * gdb/features/rx.xml: New.
2723         * gdb/features/rx.c: Generated.
2724         * gdb/NEWS: Mention target description support.
2725
2726 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2729         *slot_ptr.
2730
2731 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2732
2733         * configure.ac: Don't check for 'dlfcn.h' (moved to
2734         gdbsupport/common.m4).
2735         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2736         'gdbsupport/'.
2737         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2738         * compile/compile-c-support.c: Include
2739         'gdbsupport/gdb-dlfcn.h'.
2740         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2741         * gdb-dlfcn.c: Move to...
2742         * gdbsupport/gdb-dlfcn.c: ... here.
2743         * gdb-dlfcn.h: Move to...
2744         * gdbsupport/gdb-dlfcn.h: ... here.
2745
2746 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2747
2748         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2749         the offset field signed.
2750
2751 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2752
2753         * python/lib/gdb/__init__.py (_execute_file): New function.
2754         * python/python.c (python_run_simple_file): Call gdb._execute_file
2755         on Windows.
2756
2757 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2760         all uses as this was never set to anything but a zero value.
2761
2762 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2763
2764         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2765
2766 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2767
2768         * tui/tui-data.h (tui_gen_win_info): Add an =default
2769         move constructor, required by some GCC versions.
2770
2771 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2772
2773         * go32-nat.c (go32_sysinfo): Add hygon_p.
2774
2775 2019-08-20  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2778         line_from_reg_element_no, first_reg_element_no_inline,
2779         display_all_data, delete_data_content_windows,
2780         erase_data_content>: Now private.
2781
2782 2019-08-20  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2785         (tui_unhighlight_win, tui_highlight_win)
2786         (tui_win_info::make_window): Update.
2787         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2788
2789 2019-08-20  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2792         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2793         (MAX_PID_WIDTH): Move to tui-stack.c.
2794         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2795         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2796         (MAX_PID_WIDTH): Move from tui-data.h.
2797
2798 2019-08-20  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2801         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2802         (box_win): Update.
2803         (tui_gen_win_info::make_window): Rename from tui_make_window.
2804         (tui_win_info::make_window): New method.
2805         (tui_gen_win_info::make_visible): Update.
2806         * tui/tui-source.c (tui_source_window::set_contents): Update.
2807         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2808         (tui_data_window::display_registers_from): Update.
2809         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2810         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2811         Declare.
2812         <can_box>: Remove.
2813         <title>: Remove.
2814         (struct tui_win_info) <make_window>: Declare.
2815         <can_box>: Now virtual.
2816         <title>: New member.
2817         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2818         * tui/tui-command.c (tui_cmd_window::resize): Update.
2819
2820 2019-08-20  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2823         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2824         (tui_data_window::check_register_values): Update.
2825
2826 2019-08-20  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-regs.h (struct tui_data_window): Use
2829         DISABLE_COPY_AND_ASSIGN.
2830         <regs_content>: Change type, removing unique_ptr.
2831         <tui_data_window>: Add move constructor.
2832         * tui/tui-regs.c (tui_data_window::show_registers)
2833         (tui_data_window::show_register_group)
2834         (tui_data_window::display_registers_from)
2835         (tui_data_window::display_registers_from)
2836         (tui_data_window::first_data_item_displayed)
2837         (tui_data_window::delete_data_content_windows)
2838         (tui_data_window::rerender, tui_data_window::refresh_window)
2839         (tui_data_window::check_register_values): Update.
2840
2841 2019-08-20  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2844         show_register_group>: Declare.
2845         (tui_show_register_group): Don't declare.
2846         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2847         tui_show_registers.
2848         (tui_data_window::show_register_group): Rename from
2849         tui_show_register_group.
2850         (tui_data_window::check_register_values, tui_reg_command):
2851         Update.
2852         * tui/tui-layout.c (tui_set_layout): Update.
2853
2854 2019-08-20  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2857         Declare.
2858         (tui_check_register_values): Don't declare.
2859         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2860         from tui_check_register_values.
2861         * tui/tui-hooks.c (tui_register_changed): Update.
2862
2863 2019-08-20  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-regs.c (tui_reg_layout): Move later.
2866         (tui_show_registers): Don't enable TUI mode or change layout.
2867
2868 2019-08-20  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-regs.h (struct tui_data_item_window)
2871         <~tui_data_item_window>: Remove.
2872         <content>: Now a unique_xmalloc_ptr.
2873         * tui/tui-regs.c (tui_register_format): Return a
2874         unique_xmalloc_ptr.
2875         (tui_get_register): Update.
2876         (~tui_data_item_window): Remove.
2877         (tui_data_window::display_registers_from, tui_display_register):
2878         Update.
2879         * tui/tui-io.h (tui_expand_tabs): Update.
2880         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2881         Remove "col" parameter.
2882
2883 2019-08-20  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2886         field.
2887         * tui/tui-regs.c (~tui_data_item_window): Update.
2888
2889 2019-08-20  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2892         earlier.
2893
2894 2019-08-20  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2897
2898 2019-08-20  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-source.h (struct tui_source_window): Update.
2901         * tui/tui-regs.c (tui_show_registers): Update.
2902         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2903         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2904         (NO_REGS_STRING): Remove defines.
2905
2906 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2907
2908         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2909         unnecessary thread walk if remote doesn't support the packet.
2910
2911 2019-08-19  Tom Tromey  <tromey@adacore.com>
2912
2913         * python/py-value.c (value_has_field): Fix indentation.
2914
2915 2019-08-19  Tom Tromey  <tromey@adacore.com>
2916
2917         * printcmd.c (do_one_display, info_display_command): Update.
2918         * block.h (contained_in): Return bool.  Add allow_nested
2919         parameter.
2920         * block.c (contained_in): Return bool.  Add allow_nested
2921         parameter.
2922
2923 2019-08-19  Tom Tromey  <tom@tromey.com>
2924
2925         * configure: Rebuild.
2926         * configure.ac: Disallow the combination of -static-libstdc++ and
2927         source highlight.
2928         * source-cache.c (get_language_name): Handle rust.
2929         (source_cache::get_source_lines): Ignore highlighting exceptions.
2930
2931 2019-08-16  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2934         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2935         (struct tui_source_window_base) <make_visible, refresh_window,
2936         resize>: Remove methods.
2937         <execution_info>: Remove field.
2938         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2939         (tui_show_source_line, tui_source_window_base)
2940         (~tui_source_window_base): Update.
2941         (tui_source_window_base::resize)
2942         (tui_source_window_base::make_visible)
2943         (tui_source_window_base::refresh_window): Remove.
2944         (tui_source_window_base::update_exec_info): Update.
2945         * tui/tui-source.c (tui_source_window::set_contents): Update.
2946         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2947
2948 2019-08-16  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2951         deprecated_query_hook.
2952
2953 2019-08-16  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2956         (tui_update_source_windows_with_line): Update.
2957         * tui/tui-source.h (struct tui_source_window)
2958         <show_symtab_source>: Declare.
2959         (tui_show_symtab_source): Don't declare.
2960         * tui/tui-source.c (tui_show_symtab_source): Rename from
2961         tui_show_symtab_source.
2962
2963 2019-08-16  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.h (struct tui_source_window_base)
2966         <set_contents>: Declare.
2967         * tui/tui-winsource.c
2968         (tui_source_window_base::update_source_window_as_is): Update.
2969         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2970         Declare.
2971         (tui_set_source_content): Don't declare.
2972         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2973         tui_set_source_content.
2974         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2975         Declare.
2976         (tui_set_disassem_content): Don't declare.
2977         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2978         tui_set_disassem_content.
2979
2980 2019-08-16  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-winsource.h (struct tui_source_window_base)
2983         <update_breakpoint_info>: Declare.
2984         (tui_update_breakpoint_info): Don't declare.
2985         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2986         (tui_update_all_breakpoint_info): Update.
2987         (tui_source_window_base::update_breakpoint_info): Rename from
2988         tui_update_breakpoint_info.
2989         (tui_source_window_base::update_exec_info): Update.
2990
2991 2019-08-16  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-winsource.h (struct tui_source_window_base)
2994         <update_source_window>: Declare.
2995         (tui_update_source_window): Don't declare.
2996         * tui/tui-winsource.c
2997         (tui_source_window_base::update_source_window): Rename from
2998         tui_update_source_window.
2999         (tui_source_window_base::rerender): Update.
3000         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3001         * tui/tui-disasm.c (tui_show_disassem)
3002         (tui_show_disassem_and_update_source)
3003         (tui_disasm_window::maybe_update): Update.
3004
3005 2019-08-16  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-winsource.h (struct tui_source_window_base)
3008         <update_source_window_as_is>: Declare.
3009         (tui_update_source_window_as_is): Don't declare.
3010         * tui/tui-winsource.c (tui_update_source_window): Update
3011         (tui_source_window_base::update_source_window_as_is): Rename from
3012         tui_update_source_window_as_is.
3013         (tui_source_window_base::refill): Update.
3014         * tui/tui-source.c (tui_show_symtab_source): Update.
3015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3016         Update.
3017
3018 2019-08-16  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-winsource.h (tui_update_source_window)
3021         (tui_update_source_window_as_is): Remove "noerror" parameter.
3022         * tui/tui-winsource.c (tui_update_source_window)
3023         (tui_update_source_window_as_is): Remove "noerror" parameter.
3024         (tui_update_source_windows_with_addr)
3025         (tui_update_source_windows_with_line)
3026         (tui_source_window_base::rerender)
3027         (tui_source_window_base::refill): Update.
3028         * tui/tui-source.h (tui_set_source_content)
3029         (tui_show_symtab_source): Remove "noerror" parameter.
3030         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3031         parameter.
3032         (tui_show_symtab_source): Likewise.
3033         (tui_source_window::maybe_update): Update.
3034         * tui/tui-disasm.c (tui_show_disassem)
3035         (tui_show_disassem_and_update_source)
3036         (tui_disasm_window::do_scroll_vertical)
3037         (tui_disasm_window::maybe_update): Update.
3038
3039 2019-08-16  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui.c (tui_is_window_visible): Update.
3042         * tui/tui-wingeneral.c (tui_make_window)
3043         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3044         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3045         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3046         (tui_set_win_height_command, parse_scrolling_args): Update.
3047         * tui/tui-source.c (tui_source_window::style_changed): Update.
3048         * tui/tui-regs.c (tui_show_registers)
3049         (tui_data_window::first_data_item_displayed)
3050         (tui_data_window::delete_data_content_windows)
3051         (tui_check_register_values, tui_reg_command): Update.
3052         * tui/tui-disasm.c (tui_show_disassem): Update.
3053         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3054         method.
3055         <is_visible>: Remove field.
3056         * tui/tui-data.c (tui_next_win, tui_prev_win)
3057         (tui_delete_invisible_windows): Update.
3058
3059 2019-08-16  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.h (struct tui_source_window_base)
3062         <m_has_locator>: Remove.
3063         * tui/tui-layout.c (show_source_disasm_command, show_data)
3064         (show_source_or_disasm_and_command): Update.
3065
3066 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3067
3068         * NEWS (Other MI changes): New subsection.
3069         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3070         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3071         * arch-utils.c (default_get_pc_address_flags): New function.
3072         * arch-utils.h (default_get_pc_address_flags): New declaration.
3073         * gdbarch.sh: Add get_pc_address_flags.
3074         * gdbarch.c: Regenerate.
3075         * gdbarch.h: Likewise.
3076         * stack.c (print_pc): New function.
3077         (print_frame_info) (print_frame): Call print_pc.
3078
3079 2019-08-16  Tom de Vries  <tdevries@suse.de>
3080
3081         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3082         print_objfile_section_info.
3083
3084 2019-08-15  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3087         calling update_cmdwin_start_line.
3088         * tui/tui-winsource.h (struct tui_source_window_base)
3089         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3090         <rerender>: Declare.
3091         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3092         Call rerender.
3093         (tui_source_window_base::set_new_height): Remove.
3094         (tui_source_window_base::rerender): Rename from
3095         do_make_visible_with_new_height.
3096         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3097         resize method.
3098         (tui_win_info::make_invisible_and_set_new_height)
3099         (tui_win_info::make_visible_with_new_height): Remove.
3100         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3101         Declare.
3102         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3103         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3104         do_make_visible_with_new_height>: Don't declare.
3105         <rerender>: Declare.
3106         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3107         set_new_height.
3108         (tui_data_window::do_make_visible_with_new_height): Remove.
3109         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3110         call tui_show_locator_content.
3111         (tui_gen_win_info::resize): Call rerender.
3112         (show_source_or_disasm_and_command): Don't call
3113         tui_show_locator_content.
3114         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3115         method.
3116         (struct tui_win_info) <rerender>: Declare.
3117         <set_new_height, make_invisible_and_set_new_height,
3118         make_visible_with_new_height>: Don't declare.
3119         * tui/tui-data.c (tui_win_list::rerender): New method.
3120         * tui/tui-command.h (struct tui_cmd_window)
3121         <do_make_visible_with_new_height>: Don't declare.
3122         * tui/tui-command.c
3123         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3124
3125 2019-08-15  Tom Tromey  <tromey@adacore.com>
3126
3127         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3128         * ada-lang.c (ada_enum_name): Likewise.
3129
3130 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3131
3132         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3133         leading underscore.
3134         (GdbOutputErrorFile): Likewise.
3135         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3136         accordingly.
3137         (execute_unwinders): Rename to have a leading underscore.
3138         (auto_load_packages): Likewise.
3139         (global scope): Adjust call to auto_load_packages accordingly.
3140         (GdbSetPythonDirectory): Likewise.
3141         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3142         instead of execute_unwinders.
3143
3144 2019-08-15  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3147         (show_data): Don't change window visibility.
3148         (tui_gen_win_info::resize): Remove special case for command
3149         window.  Use wresize, when available.
3150         (show_source_or_disasm_and_command): Don't change window
3151         visibility.
3152         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3153         <make_visible>: New method.
3154         * tui/tui-command.c (tui_cmd_window::resize): New method.
3155
3156 2019-08-15  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3159         (struct tui_source_windows): New.
3160         * tui/tui-winsource.c (tui_display_main): Update.
3161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3162         (new_height_ok, parse_scrolling_args): Update.
3163         * tui/tui-layout.c (show_layout, show_data): Update.
3164         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3165         (tui_add_to_source_windows): Don't declare.
3166         * tui/tui-data.c (source_windows, tui_source_windows)
3167         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3168
3169 2019-08-15  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3172         Rename from reset.
3173         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3174         * tui/tui-layout.c (show_source_disasm_command, show_data):
3175         Update.
3176         (tui_gen_win_info::resize): Rename.
3177         (show_source_or_disasm_and_command): Update.
3178         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3179         reset.
3180
3181 2019-08-15  Tom Tromey  <tom@tromey.com>
3182
3183         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3184         * tui/tui-interp.c (tui_interp::init): Don't call
3185         tui_initialize_static_data.
3186         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3187
3188 2019-08-15  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3191         examine tui_win_list.
3192
3193 2019-08-15  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3196         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3197         tui_clear_source_content.
3198         (tui_clear_source_content): Remove.
3199         (tui_source_window_base::do_erase_source_content): Hoist call to
3200         content.clear().
3201         * tui/tui-stack.c (tui_show_frame_info): Don't call
3202         tui_clear_source_content.
3203
3204 2019-08-15  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-winsource.h (struct tui_source_window_base)
3207         <do_erase_source_content>: New method.
3208         <erase_source_content>: New method.
3209         (tui_erase_source_content): Don't declare.
3210         * tui/tui-winsource.c (tui_clear_source_content): Update.
3211         (tui_source_window_base::do_erase_source_content): Rename from
3212         tui_erase_source_content.
3213         (tui_source_window_base::show_source_content): Update.
3214         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3215         * tui/tui-source.h (struct tui_source_window)
3216         <erase_source_content>: New method.
3217         * tui/tui-disasm.h (struct tui_disasm_window)
3218         <erase_source_content>: New method.
3219
3220 2019-08-15  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3223         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3224         constructor.
3225         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3226         * tui/tui-source.c (tui_set_source_content): Update.
3227         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3228
3229 2019-08-15  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3232         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3233         tui-source.c.
3234         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3235         Declare.
3236         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3237         method.
3238         (tui_source_window::maybe_update): Update.
3239
3240 2019-08-15  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3243         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3244         tui-disasm.c.
3245         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3246         Declare.
3247         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3248         method.
3249         (tui_disasm_window::maybe_update): Update.
3250
3251 2019-08-15  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-winsource.h (struct tui_source_window_base)
3254         <maybe_update>: Declare.
3255         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3256         method.
3257         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3258         Declare.
3259         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3260         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3261         Declare.
3262         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3263
3264 2019-08-15  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3267
3268 2019-08-15  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-wingeneral.c: Include tui-stack.h.
3271         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3272         (struct tui_locator_window): Move from tui-data.h.
3273         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3274         (tui_initialize_static_data): Move from tui-data.c.
3275         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3276         (struct tui_locator_window): Move to tui-stack.c.
3277         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3278         (tui_initialize_static_data): Move to tui-stack.c.
3279
3280 2019-08-15  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-layout.c (show_source_disasm_command)
3283         (show_source_or_disasm_and_command): Use make_visible method, not
3284         tui_make_window.
3285         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3286         Remove.
3287
3288 2019-08-15  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-wingeneral.h (tui_make_window): Update.
3291         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3292         parameter.
3293         (tui_gen_win_info::make_visible): Update.
3294         * tui/tui-regs.c (tui_data_window::display_registers_from):
3295         Update.
3296         * tui/tui-layout.c (show_source_disasm_command)
3297         (show_source_or_disasm_and_command): Update.
3298         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3299         (enum tui_box): Remove.
3300         (struct tui_win_info) <can_box>: New method.
3301         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3302         method.
3303
3304 2019-08-15  Tom de Vries  <tdevries@suse.de>
3305
3306         * linux-nat-trad.c: Include gdbarch.h.
3307
3308 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3309
3310         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3311         register sizes.
3312
3313 2019-08-14  Tom Tromey  <tromey@adacore.com>
3314
3315         * darwin-nat.c: Include gdbarch.h.
3316         * darwin-nat-info.c: Include gdbarch.h.
3317
3318 2019-08-13  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3321         Remove.
3322         * tui/tui-data.c (tui_initialize_static_data): Update.
3323
3324 2019-08-13  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-winsource.h (struct tui_exec_info_window)
3327         <~tui_exec_info_window, maybe_allocate_content, get_content,
3328         m_content>: Remove.
3329         (struct tui_source_window_base) <set_exec_info_content,
3330         show_exec_info_content>: Don't declare.
3331         * tui/tui-winsource.c
3332         (tui_exec_info_window::maybe_allocate_content): Remove.
3333         (tui_source_window_base::update_exec_info): Rename from
3334         set_exec_info_content.
3335         (tui_source_window_base::show_exec_info_content)
3336         (tui_source_window_base::update_exec_info): Remove.
3337
3338 2019-08-13  Tom Tromey  <tom@tromey.com>
3339
3340         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3341         declare.
3342         * tui/tui-winsource.c (tui_update_source_window_as_is)
3343         (tui_update_source_windows_with_addr, tui_erase_source_content):
3344         Update.
3345         (tui_clear_exec_info_content): Remove.
3346
3347 2019-08-13  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3350         declare.
3351         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3352         call tui_erase_exec_info_content.
3353         (tui_clear_exec_info_content): Rename from
3354         tui_erase_exec_info_content.
3355         (tui_clear_exec_info_content): Delete.
3356
3357 2019-08-13  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.h (struct tui_source_window_base)
3360         <show_exec_info_content>: Declare.
3361         (tui_show_exec_info_content): Don't declare.
3362         * tui/tui-winsource.c
3363         (tui_source_window_base::show_exec_info_content): Rename from
3364         tui_show_exec_info_content.
3365         (tui_source_window_base::update_exec_info): Update.
3366
3367 2019-08-13  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3370         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3371         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3372         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3373         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3374         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3375         ... here.
3376
3377 2019-08-13  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-winsource.h (struct tui_source_window_base)
3380         <update_exec_info>: Declare.
3381         (tui_update_exec_info): Don't declare.
3382         * tui/tui-winsource.c (tui_update_source_window_as_is)
3383         (tui_source_window_base::refresh_all)
3384         (tui_update_all_breakpoint_info): Update.
3385         (tui_source_window_base::update_exec_info): Rename from
3386         tui_update_exec_info.
3387         * tui/tui-stack.c (tui_show_frame_info): Update.
3388
3389 2019-08-13  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.h (struct tui_source_window_base)
3392         <set_exec_info_content>: Declare.
3393         (tui_set_exec_info_content): Don't declare.
3394         * tui/tui-winsource.c
3395         (tui_source_window_base::set_exec_info_content): Rename from
3396         tui_set_exec_info_content.
3397         (tui_update_exec_info): Update.
3398
3399 2019-08-13  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-winsource.h (struct tui_source_window_base)
3402         <show_source_content>: Declare.
3403         (tui_show_source_content): Don't declare.
3404         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3405         (tui_source_window_base::show_source_content): Rename from
3406         tui_show_source_content.
3407         (tui_source_window_base::refresh_all): Update.
3408         * tui/tui-layout.c (show_source_disasm_command)
3409         (show_source_or_disasm_and_command): Update.
3410
3411 2019-08-13  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-winsource.c (tui_erase_source_content)
3414         (tui_show_source_content, tui_source_window_base::refresh_all):
3415         Update.
3416         * tui/tui-wingeneral.h
3417         (tui_check_and_display_highlight_if_needed): Don't declare.
3418         * tui/tui-wingeneral.c
3419         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3420         check_and_display_highlight_if_needed.
3421         * tui/tui-win.c (tui_rehighlight_all)
3422         (tui_win_info::make_visible_with_new_height): Update.
3423         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3424         (tui_data_window::erase_data_content)
3425         (tui_data_window::display_all_data): Update.
3426         * tui/tui-data.h (struct tui_win_info)
3427         <check_and_display_highlight_if_needed>: Declare.
3428
3429 2019-08-13  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-win.c (tui_resize_all): Call
3432         tui_delete_invisible_windows.
3433         * tui/tui-layout.c (show_layout): Call
3434         tui_delete_invisible_windows.
3435         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3436         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3437
3438 2019-08-13  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3441         tui_add_win_to_layout.
3442
3443 2019-08-13  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3446         * tui/tui-layout.c (tui_default_win_height): Now static.
3447
3448 2019-08-13  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3451         single switch.
3452         (show_source_disasm_command, show_source_or_disasm_and_command):
3453         Don't check current layout.
3454
3455 2019-08-13  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-wingeneral.c (make_all_visible): Remove.
3458         (tui_make_all_invisible): Simplify.
3459         * tui/tui-layout.c (tui_make_all_invisible): Move from
3460         tui-wingeneral.c; simplify.
3461         (show_layout): Hoist call to tui_make_all_invisible.
3462         (show_data): Don't call tui_make_all_invisible.
3463
3464 2019-08-13  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3467         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3468
3469 2019-08-13  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3472         tui-data.c.
3473         (show_source_disasm_command, show_data)
3474         (show_source_or_disasm_and_command): Don't use
3475         tui_set_current_layout_to.
3476         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3477         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3478         tui-layout.c.
3479         (tui_set_current_layout_to): Remove.
3480
3481 2019-08-13  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-layout.c (tui_set_layout): Update.
3484         * tui/tui-data.h (struct tui_layout_def): Remove.
3485         (tui_layout_def): Don't declare.
3486         * tui/tui-data.c (layout_def): Remove.
3487         (tui_layout_def): Remove.
3488
3489 2019-08-13  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-winsource.h (struct tui_source_window_base)
3492         <clear_detail>: No longer "override".
3493         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3494         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3495         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3496         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3497         Remove.
3498         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3499
3500 2019-08-13  Tom Tromey  <tromey@adacore.com>
3501
3502         * tracepoint.c: Don't include readline.h or history.h.
3503
3504 2019-08-12  Tom Tromey  <tom@tromey.com>
3505
3506         * configure: Rebuild.
3507         * configure.ac: Check for readline 7.
3508         * NEWS: Mention readline 7 requirement.
3509         * README: Update.
3510
3511 2019-08-12  Tom Tromey  <tom@tromey.com>
3512
3513         * mingw-hdep.c (gdb_select): Remove readline hack.
3514
3515 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3516
3517         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3518         when the function fails.
3519
3520 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3521
3522         * s390-tdep.c (s390_type_align): New function.
3523         (s390_gdbarch_init): Set it as type_align gdbarch method.
3524
3525 2019-08-09  Tom de Vries  <tdevries@suse.de>
3526
3527         PR gdb/24591
3528         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3529         pc_low with relocation offset.
3530
3531 2019-08-07  Tom Tromey  <tromey@adacore.com>
3532
3533         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3534         (print_frame_args): Update.
3535         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3536         Update.
3537         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3538         * frame.h (struct frame_arg): Add initializers.
3539         <error>: Now a unique_xmalloc_ptr.
3540
3541 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3542
3543         * NEWS: Expand the Pointer Authentication entry.
3544         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3545         (aarch64_frame_unmask_lr): ... to this.
3546         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3547         Call aarch64_frame_unmask_lr.
3548         * frame.c (struct frame_info): Add "masked" variable.
3549         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3550         (fprint_frame): Check for masked pc.
3551         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3552         declarations.
3553         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3554         * stack.c (print_frame): Check for masked pc.
3555
3556 2019-08-06  Tom Tromey  <tom@tromey.com>
3557
3558         * stabsread.c (patch_block_stabs, read_one_struct_field)
3559         (read_enum_type): Use obstack_strndup.
3560         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3561         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3562         * dwarf2read.c (guess_full_die_structure_name)
3563         (anonymous_struct_prefix): Use obstack_strndup.
3564         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3565         * c-exp.y (yylex): Use obstack_strndup.
3566         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3567         (write_var_or_type): Use obstack_strndup.
3568
3569 2019-08-06  Tom Tromey  <tom@tromey.com>
3570
3571         * symfile.c (reread_symbols): Use obstack_strdup.
3572         * stabsread.c (read_type): Use obstack_strdup.
3573         * gdb_obstack.h (obstack_strdup): New overload.
3574         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3575         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3576         (dwarf2_canonicalize_name): Use obstack_strdup.
3577         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3578         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3579         Use obstack_strdup.
3580
3581 2019-08-06  Tom Tromey  <tom@tromey.com>
3582
3583         * gdb_obstack.h (obstack_strdup): Define.
3584         * gdb_obstack.c (obstack_strdup): Don't define.
3585
3586 2019-08-06  Tom Tromey  <tom@tromey.com>
3587
3588         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3589         obstack_strdup.
3590         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3591         obstack_strdup.
3592         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3593         * stabsread.c (common_block_start): Use obstack_strdup.
3594         * objfiles.c (set_objfile_main_name, objfile): Use
3595         obstack_strdup.
3596         * namespace.c (add_using_directive): Use obstack_strdup.
3597         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3598         * jit.c (finalize_symtab): Use obstack_strdup.
3599         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3600         (guess_partial_die_structure_name, partial_die_info::fixup)
3601         (dwarf2_name): Use obstack_strdup.
3602         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3603         obstack_strdup.
3604         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3605         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3606         obstack_strdup.
3607         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3608
3609 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3610
3611         * unittests/help-doc-selftests.c: New file.
3612         * Makefile.in: Add the new file.
3613
3614 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3615
3616         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3617         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3618         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3619         the trailing '.' is not output, and the first character is uppercased.
3620         (print_help_for_command): Update call to print_doc_line.
3621         (print_doc_of_command): Likewise.
3622         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3623         * cli/cli-option.c (append_indented_doc): Do not append newline.
3624         (build_help_option): Append newline after first appended_indented_doc
3625         only if a second call is done.
3626         (build_help): Append 2 new lines before each option, except the first
3627         one.
3628         * compile/compile.c (_initialize_compile): Add new lines after
3629         %OPTIONS%, when not at the end of the help.
3630         Change help doc or code
3631         producing the help doc to respect the invariants.
3632         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3633         Also removed the new line after 'Options:', as all other commands
3634         do not put an empty line between 'Options:' and the first option.
3635         * printcmd.c (_initialize_printcmd): Likewise.
3636         * stack.c (_initialize_stack): Likewise.
3637         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3638         incorrectly telling COMMAND is optional.
3639         * ada-lang.c (_initialize_ada_language): Change help doc or code
3640         producing the help doc to respect the invariants.
3641         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3642         * breakpoint.c (_initialize_breakpoint): Likewise.
3643         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3644         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3645         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3646         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3647         _initialize_cli_style): Likewise.
3648         * corelow.c (core_target_info): Likewise.
3649         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3650         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3651         * filesystem.c (_initialize_filesystem): Likewise.
3652         * frame.c (_initialize_frame): Likewise.
3653         * gnu-nat.c (add_task_commands): Likewise.
3654         * infcall.c (_initialize_infcall): Likewise.
3655         * infcmd.c (_initialize_infcmd): Likewise.
3656         * interps.c (_initialize_interpreter): Likewise.
3657         * language.c (_initialize_language): Likewise.
3658         * linux-fork.c (_initialize_linux_fork): Likewise.
3659         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3660         * maint.c (_initialize_maint_cmds): Likewise.
3661         * memattr.c (_initialize_mem): Likewise.
3662         * printcmd.c (_initialize_printcmd): Likewise.
3663         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3664         _RegEx): Likewise.
3665         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3666         * record-btrace.c (_initialize_record_btrace): Likewise.
3667         * record-full.c (_initialize_record_full): Likewise.
3668         * record.c (_initialize_record): Likewise.
3669         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3670         * regcache.c (_initialize_regcache): Likewise.
3671         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3672         _initialize_remote): Likewise.
3673         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3674         * serial.c (_initialize_serial): Likewise.
3675         * skip.c (_initialize_step_skip): Likewise.
3676         * source.c (_initialize_source): Likewise.
3677         * stack.c (_initialize_stack): Likewise.
3678         * symfile.c (_initialize_symfile): Likewise.
3679         * symtab.c (_initialize_symtab): Likewise.
3680         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3681         * top.c (init_main): Likewise.
3682         * tracefile-tfile.c (tfile_target_info): Likewise.
3683         * tracepoint.c (_initialize_tracepoint): Likewise.
3684         * tui/tui-win.c (_initialize_tui_win): Likewise.
3685         * utils.c (add_internal_problem_command): Likewise.
3686         * valprint.c (value_print_option_defs): Likewise.
3687
3688 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3689
3690         PR build/24886
3691         * configure.ac: Drop enable-libmcheck support.
3692         * configure, config.in: Rebuild.
3693         * libmcheck.m4: Remove.
3694         * acinclude.m4: Don't include it.
3695         * Makefile.in: Don't distribute it.
3696         * top.c (print_gdb_configuration): Don't mention it.
3697
3698 2019-08-06  Tom Tromey  <tom@tromey.com>
3699
3700         * utils.c (set_output_style): Sometimes pass stream to
3701         emit_style_escape.
3702         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3703         * record-btrace.c (btrace_insn_history): Update.
3704         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3705         method.
3706         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3707         Update initializers.
3708         <m_uiout>: New field.
3709         <m_di>: Move lower.
3710         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3711         Remove "uiout" parameter.
3712         (dump_insns): Update.
3713         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3714         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3715
3716 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3717
3718         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3719         (error_in_psymtab_expansion): Likewise.
3720         (lookup_symbol_via_quick_fns): Likewise.
3721         (basic_lookup_transparent_type_quick): Likewise.
3722         (basic_lookup_transparent_type_1): Likewise.
3723
3724 2019-08-06  Tom Tromey  <tromey@adacore.com>
3725
3726         * source.c (last_source_error): Now bool.
3727         (print_source_lines_base): Make "noprint" bool.  Only open
3728         source file when last_source_visited changes.
3729
3730 2019-08-06  Tom Tromey  <tromey@adacore.com>
3731
3732         * annotate.c (annotate_source_line): Use g_source_cache.
3733         * source-cache.c (source_cache::get_plain_source_lines): Change
3734         parameters.  Populate m_offset_cache.
3735         (source_cache::ensure): New method.
3736         (source_cache::get_line_charpos): New method.
3737         (extract_lines): Move lower.  Change parameters.
3738         (source_cache::get_source_lines): Move lower.
3739         * source-cache.h (class source_cache): Update comment.
3740         <get_line_charpos>: New method.
3741         <get_source_lines>: Update comment.
3742         <clear>: Clear m_offset_cache.
3743         <get_plain_source_lines>: Change parameters.
3744         <ensure>: New method
3745         <m_offset_cache>: New member.
3746         * source.c (forget_cached_source_info_for_objfile): Update.
3747         (info_source_command): Use g_source_cache.
3748         (find_source_lines, open_source_file_with_line_charpos): Remove.
3749         (print_source_lines_base, search_command_helper): Use g_source_cache.
3750         * source.h (open_source_file_with_line_charpos): Don't declare.
3751         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3752         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3753         Use g_source_cache.
3754
3755 2019-08-06  Tom Tromey  <tromey@adacore.com>
3756
3757         * source-cache.c (source_cache::get_plain_source_lines):
3758         Remove "first_line" and "last_line" parameters.
3759         (source_cache::get_source_lines): Cache plain text.
3760         * source-cache.h (class source_cache)
3761         <get_plain_source_lines>: Update.
3762
3763 2019-08-06  Tom Tromey  <tromey@adacore.com>
3764
3765         * source-cache.c (extract_lines): No longer a method.
3766         Changed type of parameter.  Include final newline.
3767         (selftests::extract_lines_test): New function.
3768         (_initialize_source_cache): Likewise.
3769         * source-cache.h (class source_cache)
3770         <extract_lines>: Don't declare.
3771
3772 2019-08-06  Tom Tromey  <tromey@adacore.com>
3773
3774         * breakpoint.c (init_breakpoint_sal): Update.
3775         (breakpoint): Update.
3776         * breakpoint.h (struct breakpoint) <filter>: Now a
3777         unique_xmalloc_ptr.
3778
3779 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3780
3781         * NEWS: Mention dictionary access on blocks.
3782         * python/py-block.c (blpy_getitem): New function.
3783         (block_object_as_mapping): New struct.
3784         (block_object_type): Use new struct for tp_as_mapping field.
3785
3786 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3787
3788         * objfiles.h (objfile): Add a comment describing partial symbols.
3789
3790 2019-08-05  Tom Tromey  <tromey@adacore.com>
3791
3792         * compile/compile.c (_initialize_compile): Use _(), not N_().
3793         * thread.c (_initialize_thread): Use _(), not N_().
3794         * stack.c (_initialize_stack): Use _(), not N_().
3795         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3796
3797 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3798
3799         * dwarf2read.c (struct dw2_symtab_iterator):
3800         <want_specific_block>: Remove.
3801         <block_index>: Change type to gdb::optional.
3802         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3803         change type of BLOCK_INDEX parameter to gdb::optional.
3804         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3805         (dw2_lookup_symbol): Don't pass argument for
3806         WANT_SPECIFIC_BLOCK.
3807         (dw2_expand_symtabs_for_function): Don't pass argument for
3808         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3809         (class dw2_debug_names_iterator)
3810         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3811         parameter, change BLOCK_INDEX type to gdb::optional.
3812         <m_want_specific_block>: Remove.
3813         <m_block_index>: Change type to gdb::optional.
3814         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3815         gdb::optional.  Re-write in function of gdb::optional.
3816         (dw2_debug_names_lookup_symbol): Don't pass argument for
3817         WANT_SPECIFIC_BLOCK.
3818         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3819         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3820         BLOCK_INDEX.
3821
3822 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3823
3824         * NEWS: Mention changes to "info sources" command.
3825
3826 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3827
3828         * symtab.c (filename_partial_match_opts): New struct type.
3829         (struct output_source_filename_data): New members
3830         regexp, c_regexp, partial_match.
3831         (output_source_filename): Use new members to decide to print file.
3832         (info_sources_option_defs): New variable.
3833         (make_info_sources_options_def_group, print_info_sources_header,
3834         info_sources_command_completer):
3835         New functions.
3836         (info_sources_command): Read new optional arguments.
3837         (_initialize_symtab): Update info sources help.
3838
3839 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3840
3841         * ada-lang.c (exception_support_info_v0): Renamed from...
3842         (default_exception_support_info): ... this.  Create new
3843         definition for v1.
3844         (ada_has_this_exception_support): Look up catch_handlers_sym.
3845         (ada_exception_support_info_sniffer): Try v0 after default.
3846
3847 2019-08-01  Tom Tromey  <tromey@adacore.com>
3848
3849         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3850         gdbarch.h.
3851
3852 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3853
3854         * s12z-tdep.c: Fix include path for s12z-opc.h.
3855
3856 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3857
3858         * NEWS: Require GNU make 3.82.
3859
3860 2019-07-16  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3863         declare.
3864
3865 2019-07-30  Tom Tromey  <tromey@adacore.com>
3866
3867         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3868
3869 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3870
3871         * printcmd.c (print_address_symbolic): Print negative offsets.
3872         (build_address_symbolic): Force signed arithmetic when computing
3873         offset.
3874
3875 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3876
3877         PR/24474: Add a function to lookup static variables.
3878         * NEWS: Mention this new function.
3879         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3880         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3881         * python/python.c (python_GdbMethods): Add new function.
3882
3883 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3884
3885         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3886         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3887         (objfpy_lookup_static_symbol): New function.
3888         (objfile_object_methods): Add new functions.
3889
3890 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891
3892         * NEWS: Mention 'set|show print frame-info'.  Mention new
3893         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3894         backtrace argument.  Mention that python frame filtering code
3895         is now consistent with what 'backtrace' command prints.
3896
3897 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3898
3899         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3900         comments.
3901         (print_frame_info_auto, print_frame_info_source_line,
3902         print_frame_info_location, print_frame_info_source_and_location,
3903         print_frame_info_location_and_address, print_frame_info_short_location):
3904         New declarations.
3905         (struct frame_print_options): New member print_frame_info.
3906         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3907         * stack.h (get_user_print_what_frame_info): New declaration.
3908         (frame_show_address): New declaration.
3909         * stack.c (print_frame_arguments_choices): New value 'presence'.
3910         (print_frame_info_auto, print_frame_info_source_line,
3911         print_frame_info_location, print_frame_info_source_and_location,
3912         print_frame_info_location_and_address, print_frame_info_short_location,
3913         print_frame_info_choices, print_frame_info_print_what): New definitions.
3914         (print_frame_args): Only print dots for args if print frame-arguments
3915         is 'presence'.
3916         (frame_print_option_defs): New element for "frame-info".
3917         (get_user_print_what_frame_info): New function.
3918         (frame_show_address): Make non static.  Move comment to stack.h.
3919         (print_frame_info_to_print_what): New function.
3920         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3921         to decide what to print.
3922         (backtrace_command_1): Handle the new print_frame_arguments_presence
3923         value.
3924         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3925         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3926         (py_print_frame): In non-mi mode, use LOCATION as default for
3927         print_what, similarly to frame information printed directly by
3928         backtrace command. Handle frame-info user option in non MI mode.
3929
3930 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3931
3932         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3933         Add case for debugging 32-bit target on 64-bit host.  Revise
3934         comment.
3935
3936 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3937
3938         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3939         instead of find_function_entry_range_from_pc.
3940
3941 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3942
3943         * stack.c (find_frame_funname): Remove code which preferred
3944         minsym over symtab sym in "certain pathological cases".
3945
3946         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3947         parameter.  Change type of "do_demangle" to bool.
3948         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3949         Pass suitable "prefer_sym_over_minsym" flag to
3950         build_address_symbolic().  Don't output "+" for negative offsets.
3951         * printcmd.c (print_address_symbolic): Update invocation of
3952         build_address_symbolic to include a "prefer_sym_over_minsym"
3953         flag.
3954         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3955         Restrict cases in which use of minimal symbol is preferred to that
3956         of a found symbol.  Update comments.
3957
3958         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3959         for entry pc when entry pc is out of range for that FDE.
3960
3961 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3962
3963         PR gdb/24839:
3964         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3965         type.
3966
3967 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3968
3969         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3970         this function's Python signature.
3971
3972
3973 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3974
3975         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3976         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3977         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3978         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3979         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3980
3981
3982 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3983
3984         * h8300-tdep.c (h8300_register_name_common): New.
3985         h8300_register_name): Use h8300_register_name_common.
3986         (h8300s_register_name): Likewise.
3987         (h8300sx_register_name): Likewise.
3988         (h8300h_register_nam): New.
3989         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3990
3991
3992 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3993
3994         * arm-tdep.c (arm_skip_cmse_entry): New function.
3995         (arm_is_sgstubs_section): New function.
3996         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3997
3998 2019-07-22  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4001         Don't self-assign.
4002
4003 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4006         type_print.
4007
4008 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4011         so that GDB doesn't match any msymbols when searching in the
4012         TYPES_DOMAIN.
4013         (print_symbol_info): Print using typedef_print or type_print based
4014         on the type of the symbol.  Add updated FIXME comment moved from...
4015         (_initialize_symtab): ... move and update FIXME comment to above.
4016
4017 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * NEWS: Mention adding -q option to "info types".
4020         * symtab.c (struct info_types_options): New struct.
4021         (info_types_options_defs): New variable.
4022         (make_info_types_options_def_group): New function.
4023         (info_types_command): Use gdb::option framework to parse options.
4024         (info_types_command_completer): New function.
4025         (_initialize_symtab): Extend the help text on "info types" and
4026         register command completer.
4027
4028 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4029
4030         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4031         (lookup_symbol_in_objfile): Change int to block_enum and add a
4032         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4033
4034 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4035
4036         * MAINTAINERS (Write After Approval): Add self.
4037
4038 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4041         instruction to the dummy code region.
4042
4043 2019-07-19  Tom Tromey  <tromey@adacore.com>
4044
4045         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4046         (ARGSUSED, PARAMS, __func__): Remove rules.
4047
4048 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4049
4050         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4051         * features/arm/arm-with-iwmmxt.c: Remove.
4052         * features/arm/arm-with-iwmmxt.xml: Remove.
4053         * features/arm/arm-with-m-fpa-layout.c: Remove.
4054         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4055         * features/arm/arm-with-m-vfp-d16.c: Remove.
4056         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4057         * features/arm/arm-with-m.c: Remove.
4058         * features/arm/arm-with-m.xml: Remove.
4059         * features/arm/arm-with-neon.c: Remove.
4060         * features/arm/arm-with-neon.xml: Remove.
4061         * features/arm/arm-with-vfpv2.c: Remove.
4062         * features/arm/arm-with-vfpv2.xml: Remove.
4063         * features/arm/arm-with-vfpv3.c: Remove.
4064         * features/arm/arm-with-vfpv3.xml: Remove.
4065
4066 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4067
4068         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4069
4070 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4071
4072         * arch/aarch32.c (aarch32_create_target_description): Create
4073         target descriptions using features.
4074         * arch/arm.c (arm_create_target_description)
4075         (arm_create_mprofile_target_description): Likewise.
4076         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4077
4078 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4079
4080         * Makefile.in: Add new files.
4081         * aarch32-tdep.c: New file.
4082         * aarch32-tdep.h: New file.
4083         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4084         Call aarch32_read_description.
4085         * arch/aarch32.c: New file.
4086         * arch/aarch32.h: New file.
4087         * arch/arm.c (arm_create_target_description)
4088         (arm_create_mprofile_target_description): New function.
4089         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4090         (arm_create_target_description)
4091         (arm_create_mprofile_target_description): New declaration.
4092         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4093         read_description functions.
4094         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4095         Likewise.
4096         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4097         * arm-tdep.c (tdesc_arm_list): New variable.
4098         (arm_register_g_packet_guesses): Call create description functions.
4099         (arm_read_description) (arm_read_mprofile_description): New
4100         function.
4101         * arm-tdep.h (arm_read_description)
4102         (arm_read_mprofile_description): Add declaration.
4103         * configure.tgt: Add new files.
4104
4105 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4106
4107         * top.c (new_ui_command): Open specified terminal just once.
4108
4109 2019-07-18  Tom Tromey  <tromey@adacore.com>
4110
4111         * symtab.c (main_name): Constify return type.
4112         * symfile.c (set_initial_language): Update.
4113         * symtab.h (main_name): Constify return type.
4114
4115 2019-07-17  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-winsource.c (tui_update_source_window)
4118         (tui_update_source_window_as_is)
4119         (tui_update_source_windows_with_line): Remove return.
4120         * tui/tui-disasm.c (tui_show_disassem)
4121         (tui_show_disassem_and_update_source): Remove return.
4122         * tui/tui.c (tui_reset): Remove return.
4123         * tui/tui-wingeneral.c
4124         (tui_check_and_display_highlight_if_needed): Remove return.
4125
4126 2019-07-17  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4129
4130 2019-07-17  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-winsource.h (struct tui_exec_info_window)
4133         (struct tui_source_window_base): Move from tui-data.h.
4134         * tui/tui-winsource.c: Move many method definitions from
4135         elsewhere.  Remove "structuring" comments.
4136         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4137         (tui_source_window_base::refresh_window): Move to
4138         tui-winsource.c.
4139         * tui/tui-win.c (tui_source_window_base::refresh_all)
4140         (tui_source_window_base::update_tab_width)
4141         (tui_source_window_base::set_new_height)
4142         (tui_source_window_base::do_make_visible_with_new_height): Move to
4143         tui-winsource.c.
4144         * tui/tui-source.h: Update.
4145         * tui/tui-source.c (tui_source_window_base::reset): Move to
4146         tui-winsource.c.
4147         * tui/tui-disasm.h: Update.
4148         * tui/tui-data.h (struct tui_exec_info_window): Move to
4149         tui-winsource.h.
4150         (struct tui_source_window_base): Likewise.
4151         * tui/tui-data.c (tui_source_window_base::clear_detail)
4152         (tui_source_window_base, ~tui_source_window_base): Move to
4153         tui-winsource.c.
4154
4155 2019-07-17  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-win.c (tui_resize_all)
4158         (tui_source_window_base::update_tab_width)
4159         (tui_adjust_win_heights): Update.
4160         (tui_win_info::make_invisible_and_set_new_height): Rename from
4161         make_invisible_and_set_new_height.
4162         * tui/tui-data.h (struct tui_win_info)
4163         <make_invisible_and_set_new_height>: New method.
4164
4165 2019-07-17  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui.c: Update.
4168         * tui/tui-source.h (struct tui_source_window): Move from
4169         tui-data.h.
4170         * tui/tui-layout.c: Update.
4171         * tui/tui-disasm.c: Update.
4172         * tui/tui-data.h (struct tui_source_window): Move to
4173         tui-source.h.
4174
4175 2019-07-17  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4178         tui-data.h.
4179         * tui/tui-data.h (struct tui_disasm_window): Move to
4180         tui-disasm.h.
4181
4182 2019-07-17  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-regs.h (struct tui_data_item_window): Move from
4185         tui-data.h.
4186         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4187         * tui/tui-data.h (struct tui_data_item_window): Move to
4188         tui-regs.h.
4189         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4190
4191 2019-07-17  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui.c: Update.
4194         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4195         (tui_cmd_window::max_height): Move to tui-command.c.
4196         * tui/tui-layout.c: Update.
4197         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4198         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4199         tui-command.c.
4200         * tui/tui-command.h (struct tui_cmd_window): Move from
4201         tui-data.h.
4202         * tui/tui-command.c: Remove "structuring" comments.
4203         (tui_cmd_window::clear_detail)
4204         (tui_cmd_window::do_make_visible_with_new_height)
4205         (tui_cmd_window::max_height): Move from elsewhere.
4206
4207 2019-07-17  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4210         Now static.
4211         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4212         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4213
4214 2019-07-17  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui.c: Update.
4217         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4218         tui-regs.c.
4219         * tui/tui-windata.h: Remove file.
4220         * tui/tui-windata.c: Remove file.
4221         * tui/tui-win.c (tui_data_window::set_new_height)
4222         (tui_data_window::do_make_visible_with_new_height): Move to
4223         tui-regs.c.
4224         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4225         * tui/tui-regs.c: Remove "structuring" comments.
4226         (tui_data_window::first_data_item_displayed)
4227         (tui_data_window::delete_data_content_windows)
4228         (tui_data_window::erase_data_content)
4229         (tui_data_window::display_all_data)
4230         (tui_data_window::refresh_all)
4231         (tui_data_window::do_scroll_vertical)
4232         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4233         (tui_data_window::do_make_visible_with_new_height)
4234         (tui_data_window::refresh_window): Move from elsewhere.
4235         (_initialize_tui_regs): Move to end of file.
4236         * tui/tui-layout.c: Update.
4237         * tui/tui-hooks.c: Update.
4238         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4239         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4240         tui-regs.c.
4241         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4242
4243 2019-07-17  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4246         seen.
4247
4248 2019-07-17  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-win.c (tui_source_window_base::set_new_height)
4251         (tui_source_window_base::do_make_visible_with_new_height): Use
4252         m_has_locator field directly.
4253         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4254         method.
4255         (struct tui_source_window_base) <has_locator>: Likewise.
4256
4257 2019-07-17  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4260         Don't declare.
4261         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4262         Remove.
4263         * tui/tui-win.c (tui_source_window_base::set_new_height)
4264         (tui_source_window_base::set_new_height)
4265         (make_invisible_and_set_new_height)
4266         (tui_source_window_base::do_make_visible_with_new_height)
4267         (tui_source_window_base::do_make_visible_with_new_height):
4268         Update.
4269         * tui/tui-layout.c (show_source_disasm_command, show_data)
4270         (show_source_or_disasm_and_command): Update.
4271         * tui/tui-layout.c (show_layout): Update.
4272
4273 2019-07-17  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-layout.c (make_data_window): Remove.
4276         (show_data): Unify creation and re-initialization cases.
4277
4278 2019-07-17  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-layout.c (make_source_window, make_disasm_window):
4281         Remove.
4282         (show_data): Unify creation and re-initialization cases.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-layout.c (make_command_window): Remove.
4287         (show_source_disasm_command, show_source_or_disasm_and_command):
4288         Unify creation and re-initialization cases.
4289
4290 2019-07-17  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4293         creation and re-initialization cases.
4294
4295 2019-07-17  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-regs.c (tui_get_register): Return void.
4298
4299 2019-07-17  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4302         Simplify.
4303
4304 2019-07-17  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4307         resetting.
4308
4309 2019-07-17  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4312         * tui/tui-regs.c (tui_reg_layout): New function.
4313         (tui_show_registers, tui_reg_command): Use it.
4314         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4315         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4316         parameters.
4317         (tui_layout_command): Remove.
4318
4319 2019-07-17  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-layout.h (tui/tui-layout): Return void.
4322         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4323
4324 2019-07-17  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-layout.c (show_source_disasm_command, show_data):
4327         Update.
4328         (reset_locator): Remove.
4329         (show_source_or_disasm_and_command): Update.
4330
4331 2019-07-17  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-source.c (tui_source_window_base::reset): Remove
4334         win_type parameter.
4335         * tui/tui-layout.c (make_command_window, make_source_window)
4336         (make_disasm_window, make_data_window)
4337         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4338         (reset_locator, show_source_or_disasm_and_command): Update.
4339         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4340         win_type parameter.
4341         (struct tui_source_window_base) <reset>: Likewise.
4342
4343 2019-07-17  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui-layout.c (show_source_disasm_command): Use
4346         reset_locator.
4347         (reset_locator): New function.
4348         (init_and_make_win): Remove.
4349         (show_source_or_disasm_and_command): Use reset_locator.
4350
4351 2019-07-17  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4354         condition.
4355         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4356         Remove condition.
4357         * tui/tui-source.c (tui_source_window_base::reset): New method.
4358         * tui/tui-layout.c (make_command_window): Don't call
4359         init_and_make_win.
4360         (make_source_window, make_disasm_window): Don't call
4361         make_source_or_disasm_window.
4362         (make_data_window): Don't call init_and_make_win.  Change calling
4363         convention.
4364         (show_source_disasm_command, show_data): Simplify.
4365         (make_source_or_disasm_window): Remove.
4366         (show_source_or_disasm_and_command): Simplify.
4367         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4368         (struct tui_source_window_base) <reset>: Likewise.
4369         <execution_info>: Remove initializer.
4370         * tui/tui-data.c (tui_source_window_base): Initialize
4371         execution_info.
4372
4373 2019-07-17  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4376         variable.
4377
4378 2019-07-17  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui.c (tui_rl_other_window): Update.
4381         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4382         superclass method first.  Always iterate over regs_content.
4383         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4384         method.
4385         * tui/tui-win.c (tui_set_focus_command): Update.
4386
4387 2019-07-17  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-win.c (tui_set_focus_command): Rename from
4390         tui_set_focus.  Call tui_enable.
4391         (tui_set_focus_command): Remove.
4392
4393 2019-07-17  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4396         refresh_window.
4397         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4398         touchwin.
4399         (tui_data_window::refresh_window): Call refresh_window on data
4400         items.  Always call superclass refresh_window.
4401         (tui_win_info::refresh): Remove.
4402         (tui_source_window_base::refresh_window): Update.
4403         (tui_refresh_all): Update.
4404         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4405         refresh_window.
4406         (show_source_or_disasm_and_command): Likewise.
4407         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4408         (struct tui_source_window_base) <refresh>: Likewise.
4409
4410 2019-07-17  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-winsource.c (tui_clear_source_content)
4413         (tui_show_source_content): Update.
4414         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4415         whether content is empty.
4416         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4417         Remove.
4418
4419 2019-07-17  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4422         window's contents.
4423         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4424         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4425
4426 2019-07-17  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4429         (struct tui_data_item_window): Update.
4430
4431 2019-07-17  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4434         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4435         defines.
4436
4437 2019-07-17  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-winsource.h (tui_erase_source_content)
4440         (tui_clear_source_content): Remove "display_prompt" parameter.
4441         * tui/tui-winsource.c (tui_update_source_window_as_is)
4442         (tui_update_source_windows_with_addr): Update.
4443         (tui_clear_source_content): Remove "display_prompt" parameter.
4444         (tui_erase_source_content): Likewise.  Simplify.
4445         (tui_show_source_content): Update.
4446         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4447         * tui/tui-stack.c (tui_show_frame_info): Update.
4448         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4449         Remove defines.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4454         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4455         parameter.
4456         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4457         parameter.
4458
4459 2019-07-17  Tom Tromey  <tom@tromey.com>
4460
4461         * tui/tui-winsource.c (tui_clear_source_content)
4462         (tui_show_source_content, tui_show_exec_info_content)
4463         (tui_clear_exec_info_content): Update.
4464         * tui/tui-stack.c (tui_show_locator_content): Update.
4465         (tui_show_frame_info): Update.
4466         * tui/tui-source.h (tui_source_window): Don't declare.
4467         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4468         from tui_source_is_displayed.
4469         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4470         Remove field.
4471         (struct tui_source_window_base) <content_in_use>: New field.  Now
4472         bool.
4473         (struct tui_source_window) <showing_source_p>: New method.
4474         (TUI_SRC_WIN): Change cast.
4475         * tui/tui-data.c (tui_initialize_static_data): Update.
4476
4477 2019-07-17  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4480         location_matches_p.
4481         * tui/tui-source.c (tui_source_window::location_matches_p): New
4482         method.
4483         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4484         method.
4485         * tui/tui-data.h (struct tui_source_window_base)
4486         <location_matches_p>: New method.
4487         (struct tui_source_window, struct tui_disasm_window)
4488         <location_matches_p>: Likewise.
4489
4490 2019-07-17  Tom Tromey  <tom@tromey.com>
4491
4492         * tui/tui-win.c (tui_set_win_height_command): Rename from
4493         tui_set_win_height.
4494         (tui_set_win_height_command): Remove.
4495
4496 2019-07-17  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-source.c (tui_source_window): New constructor.  Add
4499         observer.
4500         (~tui_source_window): New destructor.
4501         (tui_source_window::style_changed): New method.
4502         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4503         (tui_attach_detach_observers): Update.
4504         * tui/tui-data.h (struct tui_source_window): Make constructor not
4505         inline.  Add destructor.
4506         (struct tui_source_window) <style_changed>: New method.
4507         <m_observable>: New member.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4512         * tui/tui-win.c (tui_resize_all): Fix typo.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4517         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4518         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4519         * tui/tui-win.c (window_name_completer): Use foreach.
4520         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4521         (update_tab_width): Likewise.
4522         * tui/tui-layout.c (show_layout): Update.
4523         * tui/tui-data.h (class tui_window_iterator): New.
4524         (struct all_tui_windows): New.
4525         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4526
4527 2019-07-17  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4530         parameter.  Don't reference globals.
4531         (tui_reg_command): Update.
4532
4533 2019-07-17  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-regs.c (tui_show_registers): Simplify.
4536
4537 2019-07-17  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-regs.c (tui_show_registers): Update.
4540         (tui_show_register_group): Add win_info parameter.
4541
4542 2019-07-17  Tom Tromey  <tom@tromey.com>
4543
4544         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4545         Rename from tui_display_reg_element_at_line.
4546         (tui_data_window::display_registers_from_line): Update.
4547         * tui/tui-data.h (struct tui_data_window)
4548         <display_reg_element_at_line>: New method.
4549
4550 2019-07-17  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-regs.h (tui_display_registers_from)
4553         (tui_display_registers_from_line): Don't declare.
4554         * tui/tui-windata.c (tui_data_window::display_all_data)
4555         (tui_data_window::refresh_all)
4556         (tui_data_window::do_scroll_vertical): Update.
4557         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4558         from tui_display_registers_from.
4559         (tui_display_reg_element_at_line): Update.
4560         (tui_data_window::display_registers_from_line): Rename from
4561         tui_display_registers_from_line.
4562         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4563         display_registers_from_line>: New methods.
4564
4565 2019-07-17  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4568         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4569         from tui_erase_data_content.
4570         (tui_data_window::display_all_data)
4571         (tui_data_window::refresh_all)
4572         (tui_data_window::do_scroll_vertical): Update.
4573         * tui/tui-regs.c (tui_show_registers): Update.
4574         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4575         New method.
4576
4577 2019-07-17  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4580         declare.
4581         * tui/tui-windata.c
4582         (tui_data_window::delete_data_content_windows): Rename from
4583         tui_delete_data_content_windows.
4584         (tui_data_window::display_all_data)
4585         (tui_data_window::do_scroll_vertical): Update.
4586         * tui/tui-data.h (struct tui_data_window)
4587         <delete_data_content_windows>: New method.
4588
4589 2019-07-17  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4592         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4593
4594 2019-07-17  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4597         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4598         from tui_display_all_data.
4599         * tui/tui-win.c
4600         (tui_data_window::do_make_visible_with_new_height): Update.
4601         * tui/tui-regs.c (tui_show_registers): Update.
4602         * tui/tui-layout.c (tui_set_layout): Update.
4603         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4604         method.
4605
4606 2019-07-17  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4609         * tui/tui-windata.c (tui_display_data_from): Remove.
4610         (tui_data_window::refresh_all): Update.
4611
4612 2019-07-17  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4615         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4616         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4617         tui_display_registers_from_line.
4618         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4619         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4620         "force_display" parameter.
4621
4622 2019-07-17  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4625         declare.
4626         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4627         Rename from tui_first_reg_element_no_inline.
4628         (tui_display_reg_element_at_line)
4629         (tui_display_registers_from_line): Update.
4630         * tui/tui-data.h (struct tui_data_window)
4631         <first_reg_element_no_inline>: New method.
4632
4633 2019-07-17  Tom Tromey  <tom@tromey.com>
4634
4635         * tui/tui-windata.c (tui_display_data_from)
4636         (tui_data_window::do_scroll_vertical): Update.
4637         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4638         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4639         Rename from tui_line_from_reg_element_no.
4640         (tui_display_registers_from_line): Update.
4641         * tui/tui-data.h (struct tui_data_window)
4642         <line_from_reg_element_no>: New method.
4643
4644 2019-07-17  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4647         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4648         tui_last_regs_line_no.
4649         (tui_display_reg_element_at_line)
4650         (tui_display_registers_from_line): Update.
4651         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4652         method.
4653
4654 2019-07-17  Tom Tromey  <tom@tromey.com>
4655
4656         PR tui/24722:
4657         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4658         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4659         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4660         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4661         (tui_update_breakpoint_info): Likewise.
4662         * tui/tui-hooks.c (tui_event_create_breakpoint)
4663         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4664         Update.
4665
4666 2019-07-17  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-winsource.c (tui_update_source_window_as_is)
4673         (tui_update_source_windows_with_addr): Update.
4674         * tui/tui-source.h (tui_set_source_content)
4675         (tui_show_symtab_source): Add "win_info" parameter.
4676         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4677         parameter.
4678         (tui_show_symtab_source): Likewise.
4679
4680 2019-07-17  Tom Tromey  <tom@tromey.com>
4681
4682         * tui/tui-wingeneral.c
4683         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4684
4685 2019-07-17  Tom Tromey  <tom@tromey.com>
4686
4687         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4688         (struct tui_cmd_window) <can_scroll>: New method.
4689         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4690         method.
4691
4692 2019-07-17  Tom Tromey  <tromey@adacore.com>
4693
4694         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4695         do_field_signed>: Rename.  Change type of "value".
4696         * ui-out.c (ui_out::field_signed): Rename from field_int.
4697         Change type of "value".
4698         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4699         type of "value".
4700         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4701         do_field_int.  Change type of "value".
4702         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4703         do_field_int.  Change type of "value".
4704         * tracepoint.c (trace_status_mi, tfind_1)
4705         (print_one_static_tracepoint_marker): Update.
4706         * thread.c (print_thread_info_1, print_selected_thread_frame):
4707         Update.
4708         * stack.c (print_frame, print_frame_info): Update.
4709         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4710         Update.
4711         * source.c (print_source_lines_base): Update.
4712         * skip.c (info_skip_command): Update.
4713         * record-btrace.c (btrace_ui_out_decode_error)
4714         (btrace_call_history_src_line): Update.
4715         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4716         Update.
4717         * progspace.c (print_program_space): Update.
4718         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4719         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4720         do_field_int.  Change type of "value".
4721         * mi/mi-out.c (mi_ui_out::do_table_begin)
4722         (mi_ui_out::do_table_header): Update.
4723         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4724         type of "value".
4725         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4726         (mi_cmd_data_list_changed_registers, output_register)
4727         (mi_cmd_data_read_memory, mi_load_progress)
4728         (mi_cmd_trace_frame_collected): Update.
4729         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4730         Update.
4731         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4732         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4733         (mi_cmd_var_list_children, varobj_update_one): Update.
4734         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4735         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4737         * inferior.c (print_inferior): Update.
4738         * gdb_bfd.c (print_one_bfd): Update.
4739         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4740         Update.
4741         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4742         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4743         do_field_int.  Change type of "value".
4744         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4745         do_field_int.  Change type of "value".
4746         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4747         (print_one_breakpoint_location, print_it_catch_fork)
4748         (print_one_catch_fork, print_it_catch_vfork)
4749         (print_one_catch_vfork, print_it_catch_solib)
4750         (print_it_catch_exec, print_it_ranged_breakpoint)
4751         (print_mention_watchpoint, print_mention_masked_watchpoint)
4752         (bkpt_print_it, update_static_tracepoint): Update.
4753         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4754         * break-catch-syscall.c (print_it_catch_syscall): Update.
4755         * ada-tasks.c (print_ada_task_info): Update.
4756         * ada-lang.c (print_it_exception, print_mention_exception):
4757         Update.
4758
4759 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         PR breakpoints/24541
4762         * gdbarch.c: Regenerate.
4763         * gdbarch.h: Regenerate.
4764         * gdbarch.sh: Adjust return type and parameter types for
4765         'stap_adjust_register'.
4766         (i386_stap_adjust_register): Adjust signature and return new
4767         register name.
4768         * stap-probe.c (stap_parse_register_operand): Adjust use of
4769         'gdbarch_stap_adjust_register'.
4770
4771 2019-07-17  Tom Tromey  <tromey@adacore.com>
4772
4773         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4774         declare VEC.
4775         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4776         std::vector.
4777         (struct s390_process_info): Add initializers.
4778         (s390_add_process): Use new.
4779         (s390_linux_nat_target::low_forget_process): Use delete.
4780         (s390_linux_nat_target::low_new_fork)
4781         (s390_linux_nat_target::stopped_by_watchpoint)
4782         (s390_linux_nat_target::low_prepare_to_resume)
4783         (s390_linux_nat_target::insert_watchpoint)
4784         (s390_linux_nat_target::insert_hw_breakpoint)
4785         (s390_linux_nat_target::remove_watchpoint)
4786         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4787
4788 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4789
4790         * aarch64-fbsd-nat.c: Include regcache.h.
4791         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4792         argument.
4793         (aarch64_fbsd_nat_target::fetch_registers)
4794         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4795         variable.
4796         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4797
4798 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4799
4800         * fbsd-nat.c: Include gdbarch.h.
4801
4802 2019-07-15  Tom Tromey  <tromey@adacore.com>
4803
4804         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4805
4806 2019-07-15  Tom Tromey  <tromey@adacore.com>
4807
4808         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4809         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4810         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4811         * cli-out.c (cli_ui_out::do_field_int): New method.
4812         * ui-out.c (ui_out::field_unsigned): New method.
4813         * symfile.c (generic_load): Use field_unsigned.
4814         (print_transfer_performance): Likewise.
4815         * record-btrace.c (ui_out_field_uint): Remove.
4816         (btrace_call_history_insn_range, btrace_call_history): Use
4817         field_unsigned.
4818         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4819         field_unsigned.
4820         * ui-out.h (class ui_out) <field_unsigned>: New method.
4821         <do_field_unsigned>: Likewise.
4822
4823 2019-07-15  Tom Tromey  <tromey@adacore.com>
4824
4825         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4826         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4827         * target.c (flash_erase_command): Use field_string.
4828         * infrun.c (print_signal_received_reason): Use field_string.
4829         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4830         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4831         field_string.
4832         * ada-tasks.c (print_ada_task_info): Use field_string.
4833
4834 2019-07-15  Tom Tromey  <tromey@adacore.com>
4835
4836         * target.c (flash_erase_command): Use field_core_addr.
4837         * symfile.c (generic_load): Use field_core_addr.
4838         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4839         Use field_core_addr.
4840         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4841         field_core_addr.
4842
4843 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4846         value if its desired type is smaller than a CORE_ADDR and signed.
4847
4848 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4851         of changes to field names, and use new is_reference field to
4852         decide if a property is a reference or not.
4853         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4854         field.
4855         (struct dwarf2_property_baton): Update header comment, rename
4856         'referenced_type' to 'property_type' and update comments.
4857         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4858         default property type, store in property baton, update to take
4859         accound of renamed field.
4860         (read_func_scope): Update call to attr_to_dynamic_prop.
4861         (read_array_type): Likewise.
4862         (dwarf2_per_cu_addr_sized_int_type): New function.
4863         (read_subrange_index_type): Move type finding code to
4864         dwarf2_per_cu_addr_sized_int_type.
4865         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4866         (dwarf2_per_cu_addr_type): New function.
4867         (set_die_type): Update calls to attr_to_dynamic_prop.
4868
4869 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * dwarf2read.c (read_subrange_index_type): New function.
4872         (read_subrange_type): Move code into new function and call it.
4873         * gdbtypes.c (create_range_type): Add some asserts.
4874
4875 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4878         update return statements.
4879         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4880         declaration, and update comment to match.
4881         * gdbtypes.c (resolve_dynamic_array): Update call to
4882         dwarf2_evaluate_property to match new return type.
4883
4884 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * valarith.c (value_subscripted_rvalue): Change lowerbound
4887         parameter type from int to LONGEST.
4888         * value.h (value_subscripted_rvalue): Likewise in declaration.
4889
4890 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * cli/cli-utils.c (info_print_command_completer): New function.
4893         * cli/cli-utils.h: Add 'completer.h' include, and forward
4894         declaration for 'struct cmd_list_element'.
4895         (info_print_command_completer): Declare.
4896         * stack.c (_initialize_stack): Add completer for 'info locals' and
4897         'info args'.
4898         * symtab.c (_initialize_symtab): Add completer for 'info
4899         variables' and 'info functions'.
4900         * NEWS: Mention completion for additional info commands.
4901
4902 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * cli/cli-utils.c (extract_info_print_args): Delete.
4905         (extract_arg_maybe_quoted): Delete.
4906         (info_print_options_defs): New variable.
4907         (make_info_print_options_def_group): New function.
4908         (extract_info_print_options): Define new function.
4909         * cli/cli-utils.h (extract_info_print_args): Delete.
4910         (struct info_print_options): New structure.
4911         (extract_info_print_options): Declare new function.
4912         * stack.c (info_locals_command): Update to use new
4913         extract_info_print_options, also add a header comment.
4914         (info_args_command): Likewise.
4915         * symtab.c (info_variables_command): Likewise.
4916         (info_functions_command): Likewise.
4917
4918 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4921         to extract string arguments.
4922         * common/common-utils.c (extract_string_maybe_quoted): New function.
4923         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4924
4925 2019-07-11  Tom Tromey  <tromey@adacore.com>
4926
4927         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4928         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4929         * top.h (gdbinit): Don't declare.
4930         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4931         into...
4932         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4933         * top.c (gdb_init): Don't call init_cli_cmds.
4934         (gdbinit): Remove.
4935         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4936
4937 2019-07-11  Tom Tromey  <tromey@adacore.com>
4938
4939         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4940         after it has been moved.
4941
4942 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4943
4944         * valops.c (value_must_coerce_to_target): Change return type to
4945         bool.
4946         * value.h (value_must_coerce_to_target): Likewise.
4947
4948 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4949
4950         * breakpoint.c (is_hardware_watchpoint): Remove
4951         forward-declaration.
4952         (is_masked_watchpoint): Change return type to bool.
4953         (is_tracepoint): Likewise.
4954         (is_breakpoint): Likewise.
4955         (is_hardware_watchpoint): Likewise.
4956         (is_watchpoint): Likewise.
4957         (is_no_memory_software_watchpoint): Likewise.
4958         (is_catchpoint): Likewise.
4959         (breakpoint_1): Make FILTER parameter's return type bool.
4960         is_masked_watchpoint): Change return type to bool.
4961         (save_breakpoints): Make FILTER parameter's return type bool.
4962         * breakpoint.h (is_breakpoint): Change return type to bool.
4963         (is_watchpoint): Likewise.
4964         (is_catchpoint): Likewise.
4965         (is_tracepoint): Likewise.
4966
4967 2019-07-10  Tom Tromey  <tom@tromey.com>
4968
4969         * defs.h: Don't include gdbarch.h.
4970         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4971         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4972         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4973         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4974         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4975         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4976         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4977         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4978         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4979         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4980         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4981         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4982         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4983         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4984         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4985         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4986         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4987         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4988         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4989         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4990         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4991         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4992         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4993         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4994         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4995         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4996         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4997
4998 2019-07-10  Tom Tromey  <tromey@adacore.com>
4999
5000         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5001         * breakpoint.c (init_ada_exception_breakpoint): Register as
5002         bp_catchpoint.
5003         (print_one_breakpoint_location, print_one_breakpoint): Use
5004         is_ada_exception_catchpoint.
5005         * ada-lang.c (class ada_catchpoint_location): Pass
5006         bp_loc_software_breakpoint to bp_location constructor.
5007         (is_ada_exception_catchpoint): New function.
5008
5009 2019-07-10  Tom Tromey  <tromey@adacore.com>
5010
5011         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5012         VEC.
5013         (struct arm_exidx_entry): New method operator<.
5014         (struct arm_exidx_data) <section_maps>: Change type.
5015         (arm_exidx_data_free): Remove.
5016         (arm_exidx_data_key): Change type.  Move lower.
5017         (arm_exidx_new_objfile): Update.
5018         (arm_compare_exidx_entries): Remove.
5019         (arm_find_exidx_entry, _initialize_arm_tdep)
5020
5021 2019-07-10  Tom Tromey  <tromey@adacore.com>
5022
5023         * solib-spu.c (ocl_program_data_key): Change type.
5024         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5025         Update.
5026
5027 2019-07-10  Tom Tromey  <tromey@adacore.com>
5028
5029         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5030         (struct solib_aix_inferior_data) <library_list>: Change type.
5031         (solib_aix_inferior_data_handle): Change type.
5032         (get_solib_aix_inferior_data): Update.
5033         (solib_aix_free_library_list): Remove.
5034         (library_list_start_library): Update.
5035         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5036         return type.
5037         (solib_aix_get_library_list)
5038         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5039         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5040
5041 2019-07-10  Tom Tromey  <tromey@adacore.com>
5042
5043         * solib-dsbt.c (struct dsbt_info): Add initializers.
5044         (solib_dsbt_pspace_data): Change type.
5045         (dsbt_pspace_data_cleanup): Remove.
5046         (get_dsbt_info, _initialize_dsbt_solib): Update.
5047
5048 2019-07-10  Tom Tromey  <tromey@adacore.com>
5049
5050         * spu-tdep.c (spu_overlay_data): Change type.
5051         (spu_get_overlay_table, spu_overlay_new_objfile)
5052         (_initialize_spu_tdep): Update.
5053
5054 2019-07-10  Tom Tromey  <tromey@adacore.com>
5055
5056         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5057         destructor.
5058         (dbx_objfile_data_key): Change type and declare later.
5059         (DBX_SYMFILE_INFO): Rewrite.
5060         * dbxread.c (dbx_objfile_data_key): Change type.
5061         (dbx_symfile_init): Update.
5062         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5063         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5064         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5065
5066 2019-07-10  Tom Tromey  <tromey@adacore.com>
5067
5068         * jit.c (jit_program_space_key): Change type.  Move lower.
5069         (get_jit_program_space_data): Update.
5070         (jit_program_space_data_cleanup): Remove.
5071         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5072         Update.
5073         (struct jit_program_space_data): Add initializers.
5074
5075 2019-07-10  Tom Tromey  <tromey@adacore.com>
5076
5077         * solib-darwin.c (struct darwin_info): Add initializers.
5078         (solib_darwin_pspace_data): Change type.
5079         (darwin_pspace_data_cleanup): Remove.
5080         (get_darwin_info, _initialize_darwin_solib): Update.
5081
5082 2019-07-10  Tom Tromey  <tromey@adacore.com>
5083
5084         * remote-sim.c (struct sim_inferior_data): Add initializers,
5085         constructor, and destructor.
5086         (sim_inferior_data_key): Change type.  Move lower.
5087         (check_for_duplicate_sim_descriptor): Update.
5088         (get_sim_inferior_data): Use new.  Update.
5089         (~sim_inferior_data_cleanup): Rename from
5090         sim_inferior_data_cleanup.  Simplify.
5091         (gdbsim_close_inferior, simulator_command)
5092         (sim_command_completer, _initialize_remote_sim): Update.
5093         (next_pid, INITIAL_PID): Move earlier.
5094
5095 2019-07-10  Tom Tromey  <tromey@adacore.com>
5096
5097         * python/python-internal.h (create_thread_object): Return
5098         gdbpy_ref.
5099         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5100         * python/py-inferior.c (struct threadlist_entry): Add
5101         constructor.
5102         <thread_obj>: Now a gdbpy_ref.
5103         (thread_to_thread_object): Update.
5104         (add_thread_object): Use new.
5105         (delete_thread_object): Use delete.
5106         (infpy_threads): Update.
5107         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5108         GIL.
5109
5110 2019-07-10  Tom Tromey  <tromey@adacore.com>
5111
5112         * valops.c (value_cast): Specialize error message for Ada.
5113
5114 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5115
5116         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5117
5118 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5119
5120         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5121         bpstat_should_step): Return bool, adjust comments.
5122         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5123         bpstat_should_step): Likewise.
5124
5125 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5126
5127         * features/Makefile: Use feature target descriptions for Arm.
5128         * features/arm/arm-core.c: Generate new file.
5129         * features/arm/arm-fpa.c: Likewise.
5130         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5131         * features/arm/arm-m-profile.c: Likewise.
5132         * features/arm/arm-vfpv2.c: Likewise.
5133         * features/arm/arm-vfpv3.c: Likewise.
5134         * features/arm/xscale-iwmmxt.c: Likewise.
5135         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5136
5137 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5138
5139         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5140         ptrace earlier.
5141
5142 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5143
5144         * features/aarch64-pauth.c: Regenerate.
5145
5146 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5147
5148         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5149         bool.
5150         (bpstat_what): Use false instead of 0.
5151
5152 2019-07-09  Pedro Alves  <palves@redhat.com>
5153
5154         * break-catch-throw.c (is_exception_catchpoint): New.
5155         * breakpoint.c (print_one_breakpoint_location): New parameter
5156         'raw_loc'.  Handle it.  Use
5157         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5158         looking at the breakpoint's type.
5159         (print_one_breakpoint): If handling "maint info breakpoints", also
5160         print locations of exception catchpoints.
5161         * breakpoint.h (is_exception_catchpoint): Declare.
5162
5163 2019-07-09  Pedro Alves  <palves@redhat.com>
5164
5165         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5166         "addr" field.
5167         (allocate_location_exception_catchpoint): New.
5168         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5169         (initialize_throw_catchpoint_ops): Install
5170         allocate_location_exception_catchpoint as allocate_location
5171         method.
5172         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5173         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5174         bp_loc_other.
5175         (breakpoint_address_is_meaningful): Delete.
5176         (bl_address_is_meaningful): New.
5177         (breakpoint_locations_match): Adjust comment.
5178         (bp_location_from_bp_type): New, factored out of...
5179         (bp_location::bp_location(breakpoint *)): ... this.
5180         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5181         factored out of...
5182         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5183         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5184         breakpoint_address_is_meaningful.
5185         (bp_locations_compare): Adjust comment.
5186         (update_global_location_list): Use bl_address_is_meaningful
5187         instead of breakpoint_address_is_meaningful.
5188         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5189         explicit.
5190         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5191         * python/py-breakpoint.c (bppy_get_location): No longer check
5192         whether location is null.
5193
5194 2019-07-09  Pedro Alves  <palves@redhat.com>
5195
5196         PR c++/15468
5197         * breakpoint.c (print_one_breakpoint_location): Remove
5198         single-location assert.
5199
5200 2019-07-09  Tom Tromey  <tom@tromey.com>
5201
5202         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5203         * configure: Rebuild.
5204         * configure.ac: Change common to gdbsupport.
5205         * gdbsupport: Rename from common.
5206         * acinclude.m4: Change common to gdbsupport.
5207         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5208         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5209         gdbsupport.
5210         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5211         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5212         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5213         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5214         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5215         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5216         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5217         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5218         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5219         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5220         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5221         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5222         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5223         coff-pe-read.c, command.h, compile/compile-c-support.c,
5224         compile/compile-c.h, compile/compile-cplus-symbols.c,
5225         compile/compile-cplus-types.c, compile/compile-cplus.h,
5226         compile/compile-loc2c.c, compile/compile.c, completer.c,
5227         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5228         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5229         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5230         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5231         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5232         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5233         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5234         features/aarch64-core.c, features/aarch64-fpu.c,
5235         features/aarch64-pauth.c, features/aarch64-sve.c,
5236         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5237         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5238         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5239         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5240         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5241         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5242         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5243         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5244         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5245         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5246         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5247         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5248         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5249         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5250         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5251         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5252         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5253         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5254         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5255         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5256         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5257         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5258         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5259         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5260         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5261         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5262         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5263         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5264         minsyms.c, mips-linux-tdep.c, namespace.h,
5265         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5266         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5267         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5268         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5269         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5270         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5271         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5272         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5273         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5274         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5275         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5276         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5277         procfs.c, producer.c, progspace.h, psymtab.h,
5278         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5279         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5280         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5281         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5282         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5283         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5284         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5285         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5286         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5287         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5288         target-memory.c, target.c, target.h, target/waitstatus.c,
5289         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5290         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5291         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5292         unittests/array-view-selftests.c,
5293         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5294         unittests/common-utils-selftests.c,
5295         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5296         unittests/format_pieces-selftests.c,
5297         unittests/function-view-selftests.c,
5298         unittests/lookup_name_info-selftests.c,
5299         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5300         unittests/mkdir-recursive-selftests.c,
5301         unittests/observable-selftests.c,
5302         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5303         unittests/parse-connection-spec-selftests.c,
5304         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5305         unittests/scoped_fd-selftests.c,
5306         unittests/scoped_mmap-selftests.c,
5307         unittests/scoped_restore-selftests.c,
5308         unittests/string_view-selftests.c, unittests/style-selftests.c,
5309         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5310         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5311         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5312         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5313         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5314         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5315
5316 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5319         bool value.
5320         (decode_digits_ordinary): Set explicit_line field in sal.
5321         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5322         symtab_and_line that was set on an explicit line number in
5323         assembler code.  Do always update the recorded symtab and line if
5324         we do skip the prologue.
5325
5326 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * breakpoint.c (set_breakpoint_location_function): Remove
5329         explicit_loc parameter.
5330         (momentary_breakpoint_from_master): Update call to
5331         set_breakpoint_location_function.
5332         (add_location_to_breakpoint): Likewise.
5333
5334 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5337         required features based on default bfd type when no specific bfd
5338         is present.
5339
5340 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5341
5342         * NEWS: Mention that GDB printf and eval commands can now print
5343         C-style and Ada-style convenience var strings without
5344         calling the inferior.
5345         * printcmd.c (printf_c_string): Locally print GDB internal var
5346         instead of transiting via the inferior.
5347         (printf_wide_c_string): Likewise.
5348
5349 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5350
5351         PR breakpoints/25011
5352         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5353
5354 2019-07-04  Tom Tromey  <tom@tromey.com>
5355
5356         PR tui/24724:
5357         * tui/tui-winsource.c (tui_clear_source_content): Update.
5358         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5359         (tui_update_breakpoint_info): Update.
5360         (tui_set_exec_info_content): Update.
5361         * tui/tui-source.c (tui_set_source_content_nil): Update.
5362         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5363         has_break.
5364         * tui/tui-data.h (enum tui_bp_flag): New.
5365         (tui_bp_flags): New enum flags type.
5366         (struct tui_source_element) <break_mode>: Change type.  Rename
5367         from has_break.
5368         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5369         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5370         constants.
5371         * tui/tui-winsource.h: Fix comment.
5372
5373 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5374
5375         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5376         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5377         (store_fpregs_to_thread)
5378         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5379         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5380         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5381         (IWMMXT_REGS_SIZE): Add define.
5382         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5383         (fetch_vfp_regs, store_vfp_regs)
5384         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5385         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5386
5387 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5388
5389         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5390         defines.
5391         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5392         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5393         (ARM_INT_REGISTER_SIZE): ...to this.
5394         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5395         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5396         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5397         (arm_linux_collect_gregset, supply_nwfpe_register)
5398         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5399         defines.
5400         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5401         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5402         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5403         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5404         (arm_return_in_memory, arm_store_return_value)
5405         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5406         (arm_record_ld_st_multiple): Likewise.
5407         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5408         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5409
5410 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5411
5412         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5413         AARCH64_DISPLACED_MODIFIED_INSNS.
5414         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5415         (aarch64_displaced_step_copy_insn): Likewise.
5416         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5417         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5418         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5419         ARM_DISPLACED_MODIFIED_INSNS.
5420         * arm-tdep.c (arm_gdbarch_init): Likewise.
5421         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5422         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5423         (struct arm_displaced_step_closure): Use
5424         ARM_DISPLACED_MODIFIED_INSNS.
5425
5426 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5427
5428         * features/Makefile: Remove unused xml files.
5429         * features/aarch64.xml: Remove.
5430         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5431         * features/i386/amd64-avx-avx512.xml: Remove.
5432         * features/i386/amd64-avx-linux.xml: Remove.
5433         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5434         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5435         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5436         * features/i386/amd64-avx-mpx.xml: Remove.
5437         * features/i386/amd64-avx.xml: Remove.
5438         * features/i386/amd64-linux.xml: Remove.
5439         * features/i386/amd64-mpx-linux.xml: Remove.
5440         * features/i386/amd64-mpx.xml: Remove.
5441         * features/i386/amd64.xml: Remove.
5442         * features/i386/i386-avx-avx512-linux.xml: Remove.
5443         * features/i386/i386-avx-avx512.xml: Remove.
5444         * features/i386/i386-avx-linux.xml: Remove.
5445         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5446         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5447         * features/i386/i386-avx-mpx-linux.xml: Remove.
5448         * features/i386/i386-avx-mpx.xml: Remove.
5449         * features/i386/i386-avx.xml: Remove.
5450         * features/i386/i386-linux.xml: Remove.
5451         * features/i386/i386-mmx-linux.xml: Remove.
5452         * features/i386/i386-mmx.xml: Remove.
5453         * features/i386/i386-mpx-linux.xml: Remove.
5454         * features/i386/i386-mpx.xml: Remove.
5455         * features/i386/i386.xml: Remove.
5456         * features/i386/x32-avx-avx512-linux.xml: Remove.
5457         * features/i386/x32-avx-linux.xml: Remove.
5458         * features/i386/x32-linux.xml: Remove.
5459
5460 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5461
5462         * regformats/aarch64.dat: Remove.
5463         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5464         * regformats/i386/amd64-avx-linux.dat: Remove.
5465         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5466         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5467         * regformats/i386/amd64-linux.dat: Remove.
5468         * regformats/i386/amd64-mpx-linux.dat: Remove.
5469         * regformats/i386/amd64.dat: Remove.
5470         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5471         * regformats/i386/i386-avx-linux.dat: Remove.
5472         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5473         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5474         * regformats/i386/i386-linux.dat: Remove.
5475         * regformats/i386/i386-mmx-linux.dat: Remove.
5476         * regformats/i386/i386-mpx-linux.dat: Remove.
5477         * regformats/i386/i386.dat: Remove.
5478         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5479         * regformats/i386/x32-avx-linux.dat: Remove.
5480         * regformats/i386/x32-linux.dat: Remove.
5481
5482 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5483
5484         * aarch64-tdep.c: Remove xml self tests.
5485         * amd64-linux-tdep.c: Likewise.
5486         * amd64-tdep.c: Likewise.
5487         * i386-linux-tdep.c: Likewise.
5488         * i386-tdep.c: Likewise.
5489
5490 2019-07-03  Pedro Alves  <palves@redhat.com>
5491
5492         PR cli/24732
5493         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5494         (pipe_cmd_option_defs): New.
5495         (make_pipe_cmd_options_def_group): New.
5496         (pipe_command): Use gdb::option::process_options.
5497         (pipe_command_completer): New function.
5498         (_initialize_cli_cmds): Install completer for "pipe" command.
5499
5500 2019-07-03  Pedro Alves  <palves@redhat.com>
5501
5502         * cli/cli-option.c (union option_value) <string>: New field.
5503         (struct option_def_and_value): Add ctor, move ctor, dtor and
5504         use DISABLE_COPY_AND_ASSIGN.
5505         (option_def_and_value::clear_value): New.
5506         (parse_option, save_option_value_in_ctx, get_val_type_str)
5507         (add_setshow_cmds_for_options): Handle var_string.
5508         * cli-option.h (union option_def::var_address) <string>: New
5509         field.
5510         (struct string_option_def): New.
5511         * maint-test-options.c (struct test_options_opts): Add default
5512         ctor and use DISABLE_COPY_AND_ASSIGN.
5513         <string_opt>: New field.
5514         (test_options_opts::~test_options_opts): New.
5515         (test_options_opts::dump): Also dump "-string".
5516         (test_options_option_defs): Install "string.
5517
5518 2019-07-03  Pedro Alves  <palves@redhat.com>
5519
5520         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5521         option_value with a null enumeration.
5522         (complete_options): Save the option values in the context.
5523         (save_option_value_in_ctx): New, factored out from ...
5524         (process_options): ... here.
5525         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5526         of the function.
5527         * maint-test-options.c (test_options_opts::dump): New, factored
5528         out from ...
5529         (maintenance_test_options_command_mode): ... here.
5530         (maintenance_test_options_command_completion_result): Delete.
5531         (maintenance_test_options_command_completion_text): Update
5532         comment.
5533         (maintenance_show_test_options_completion_result): Change
5534         prototype.  Just print
5535         maintenance_test_options_command_completion_text.
5536         (save_completion_result): New.
5537         (maintenance_test_options_completer_mode): Pass options context to
5538         complete_options, and then save a dump.
5539         (_initialize_maint_test_options): Use add_cmd to install "maint
5540         show test-options-completion-result".
5541
5542 2019-07-03  Pedro Alves  <palves@redhat.com>
5543
5544         * NEWS (New commands): Mention "with" and "maint with".
5545         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5546         (with_command, with_command_completer): New.
5547         (pipe_command): Adjust to new repeat_previous
5548         interface.
5549         (_initialize_cli_cmds): Install the "with" command and its "w"
5550         alias.
5551         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5552         declarations.
5553         * cli/cli-setshow.c (parse_cli_var_uinteger)
5554         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5555         argument strings for all var_types.
5556         (get_setshow_command_value_string): New, factored out from ...
5557         (do_show_command): ... this.
5558         * cli/cli-setshow.h: Include <string>.
5559         (get_setshow_command_value_string): Declare.
5560         * command.h (repeat_previous): Now returns const char *.  Adjust
5561         comment.
5562         * maint.c: Include "cli/cli-cmds.h".
5563         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5564         (_initialize_maint_cmds): Register the "maintenance with" command.
5565         * top.c (repeat_previous): Move bits from pipe_command here:
5566         Return the saved command line, if any; error out if there's no
5567         command to relaunch.
5568
5569 2019-07-03  Pedro Alves  <palves@redhat.com>
5570
5571         * NEWS (New commands): Mention "maint set/show test-settings"
5572         instead of "maint test-settings".
5573         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5574         (maintenance_test_settings_set_list): Rename to ...
5575         (maintenance_set_test_settings_list): ... this.
5576         (maintenance_test_settings_show_list): Rename to  ...
5577         (maintenance_show_test_settings_list): ... this.
5578         (maintenance_test_settings_cmd): Delete.
5579         (maintenance_test_settings_set_cmd): ...
5580         (maintenance_set_test_settings_cmd): ... this.
5581         (maintenance_test_settings_show_cmd): ...
5582         (maintenance_show_test_settings_cmd): ... this.
5583         (maintenance_test_settings_show_value_cmd):
5584         (maintenance_show_test_settings_value_cmd): ... this.
5585         (_initialize_maint_test_settings): No longer install the "maint
5586         test-settings" prefix command.  Rename "maint test-settings set"
5587         to "maint set test-settings", and "maint test-settings show" to
5588         "maint show test-settings".  Adjust all subcommands.
5589
5590 2019-07-03  Pedro Alves  <palves@redhat.com>
5591
5592         * maint-test-settings.c: Fix file's intro comment.  Replace all
5593         references to "test-options" with references to "test-settings",
5594         in comments.
5595
5596 2019-07-03  Pedro Alves  <palves@redhat.com>
5597
5598         * maint-test-settings.c (maintenance_test_settings_xxx)
5599         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5600         New.
5601         (maintenance_test_settings_enums): Use them.
5602         (maintenance_test_settings_enum): Default to
5603         maintenance_test_settings_xxx.
5604         (_initialize_maint_test_settings): Initialize
5605         MAINTENANCE_TEST_SETTINGS_FILENAME.
5606
5607 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5608
5609         * breakpoint.h (remove_breakpoints_inf): Change return type to
5610         void, move function documentation here.
5611         * breakpoint.c (remove_breakpoints_inf): Change return type to
5612         void, move function documentation to header.
5613
5614 2019-07-02  Pedro Alves  <palves@redhat.com>
5615
5616         * NEWS (Completion improvements): Mention "info threads".
5617         * thread.c (struct info_threads_opts, info_threads_option_defs)
5618         (make_info_threads_options_def_group): New.
5619         (info_threads_command): Use gdb::option::process_options.
5620         (info_threads_command_completer): New.
5621         (_initialize_thread): Use gdb::option::build_help to build the
5622         help text for "info threads".
5623
5624 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5625
5626         * defs.h (generic_load): Move from here...
5627         * symfile.h (generic_load): ... to here.  Rename name parameter
5628         to args.
5629         * symfile.c (generic_load): Add comment.
5630
5631 2019-07-01  Tom Tromey  <tromey@adacore.com>
5632
5633         * dwarf2read.c
5634         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5635         declaration of without_params.  Fix formatting.
5636
5637 2019-07-01  Tom Tromey  <tromey@adacore.com>
5638
5639         * ada-exp.y (find_primitive_type): Update.
5640         * ada-lang.h (ada_lookup_symbol): Update.
5641         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5642         parameter.
5643         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5644
5645 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5646
5647         PR breakpoints/24541
5648         * gdbarch.c: Regenerate.
5649         * gdbarch.h: Regenerate.
5650         * gdbarch.sh: Add 'stap_adjust_register'.
5651         * i386-tdep.c: Include '<unordered_set>'.
5652         (i386_stap_adjust_register): New function.
5653         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5654         * stap-probe.c (stap_parse_register_operand): Call
5655         'gdbarch_stap_adjust_register'.
5656
5657 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5658
5659         PR python/24742
5660         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5661         * python/python.c (do_start_initialization): Use 'xmalloc'
5662         instead of 'PyMem_Malloc'.
5663
5664 2019-06-28  Tom Tromey  <tromey@adacore.com>
5665
5666         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5667         for Ada.
5668
5669 2019-06-27  Tom Tromey  <tromey@adacore.com>
5670
5671         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5672         objfile_key.
5673         (arm_find_mapping_symbol, arm_record_special_symbol)
5674         (_initialize_arm_tdep): Update.
5675         (arm_objfile_data_free): Remove.
5676
5677 2019-06-27  Tom Tromey  <tromey@adacore.com>
5678
5679         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5680         to cp_print_static_field.
5681
5682 2019-06-26  Tom Tromey  <tromey@adacore.com>
5683
5684         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5685         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5686         declare.
5687
5688 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5689
5690         * features/aarch64-core.c (create_feature_aarch64_core):
5691         Regenerate.
5692         * features/aarch64-core.xml: Add cpsr flags.
5693
5694 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5695
5696         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5697         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5698
5699 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5700
5701         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5702         field.
5703         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5704         use.
5705         (arm_record_special_symbol): Don't insert new symbol in sorted
5706         position, push it at the end.
5707
5708 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5709
5710         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5711         (arm_mapping_symbol_s): Remove.
5712         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5713         (arm_mapping_symbol_vec): New typedef.
5714         (struct arm_per_objfile): Add constructor.
5715         <section_maps>: Change type to
5716         std::unique_ptr<arm_mapping_symbol_vec[]>.
5717         (arm_compare_mapping_symbols): Remove.
5718         (arm_find_mapping_symbol): Adjust to section_maps type change.
5719         (arm_objfile_data_free): Call delete on arm_per_objfile.
5720         (arm_record_special_symbol): Adjust to section_maps type change.
5721         Allocate arm_per_objfile with new.
5722
5723 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5724
5725         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5726         with the command prefix.
5727
5728 2019-06-25  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5731         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5732
5733 2019-06-25  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5736         type.
5737         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5738         protected.
5739
5740 2019-06-25  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-winsource.c
5743         (tui_source_window_base::set_is_exec_point_at): Add check against
5744         LOA_ADDRESS.
5745
5746 2019-06-25  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-source.c (tui_set_source_content): Don't check before
5749         xfree.
5750         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5751
5752 2019-06-25  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (tui_update_source_window_as_is)
5755         (tui_alloc_source_buffer, tui_line_is_displayed)
5756         (tui_addr_is_displayed): Change type of win_info.
5757         * tui/tui-winsource.c (tui_update_source_window_as_is)
5758         (tui_clear_source_content, tui_show_source_line)
5759         (tui_show_source_content, tui_source_window_base::refill)
5760         (tui_source_window_base::set_is_exec_point_at)
5761         (tui_source_window_base::set_is_exec_point_at)
5762         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5763         (tui_alloc_source_buffer, tui_line_is_displayed)
5764         (tui_addr_is_displayed): Change type of win_info.  Update.
5765         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5766         (tui_source_window_base::do_make_visible_with_new_height):
5767         Update.
5768         * tui/tui-source.c (tui_set_source_content)
5769         (tui_set_source_content_nil)
5770         (tui_source_window::do_scroll_vertical): Update.
5771         * tui/tui-layout.c (show_layout): Update.
5772         * tui/tui-disasm.c (tui_set_disassem_content)
5773         (tui_disasm_window::do_scroll_vertical): Update.
5774         * tui/tui-data.h (tui_win_content): Remove.
5775         (struct tui_gen_win_info) <content, content_size>: Remove.
5776         (struct tui_source_element): Add initializers and destructor.
5777         (union tui_which_element, struct tui_win_element): Remove.
5778         (struct tui_source_window_base) <content>: New field.
5779         (struct tui_data_window): Remove destructor.
5780         (tui_alloc_content, tui_free_win_content)
5781         (tui_free_all_source_wins_content): Don't declare.
5782         * tui/tui-data.c (tui_initialize_static_data): Update.
5783         (init_content_element, tui_alloc_content): Remove.
5784         (~tui_gen_win_info): Update.
5785         (~tui_data_window, tui_free_all_source_wins_content)
5786         (tui_free_win_content, free_content, free_content_elements):
5787         Remove.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-winsource.h (tui_clear_source_content)
5792         (tui_erase_source_content, tui_show_source_content): Change type
5793         of win_info.
5794         * tui/tui-winsource.c (tui_clear_source_content)
5795         (tui_erase_source_content, tui_show_source_content): Change type
5796         of win_info.
5797         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5798         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5799         win_info.
5800         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5801         win_info.
5802         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5803
5804 2019-06-25  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-winsource.c (tui_clear_source_content)
5807         (tui_source_window_base::set_is_exec_point_at): Update.
5808         * tui/tui-source.c (tui_set_source_content_nil): Update.
5809         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5810         a bool.
5811         * tui/tui-data.c (init_content_element): Update.
5812
5813 2019-06-25  Tom Tromey  <tom@tromey.com>
5814
5815         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5816         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5817         * tui/tui-layout.c (init_and_make_win): Update.
5818         * tui/tui.h (enum tui_win_type): Update.
5819         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5820         tui_win_is_auxillary.
5821         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5822         tui_win_is_auxillary.
5823
5824 2019-06-25  Tom Tromey  <tom@tromey.com>
5825
5826         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5827         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5828         (tui_delete_data_content_windows, tui_display_all_data)
5829         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5830         Update.
5831         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5832         * tui/tui-regs.c (tui_last_regs_line_no)
5833         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5834         (tui_show_registers): Update.
5835         (tui_show_register_group): Return void.  Update.
5836         (tui_display_registers_from, tui_display_reg_element_at_line)
5837         (tui_display_registers_from_line, tui_check_register_values):
5838         Update.
5839         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5840         member.
5841         (struct tui_data_window) <regs_content>: Now a std::vector.
5842         <regs_content_count>: Remove.
5843         (tui_add_content_elements, tui_free_data_content): Don't declare.
5844         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5845         (init_content_element): Remove DATA_WIN case.  Add assert.
5846         (tui_add_content_elements): Remove.
5847         (tui_data_window): Update.
5848         (tui_free_data_content): Remove.
5849         (free_content_elements): Remove DATA_WIN case.
5850
5851 2019-06-25  Tom Tromey  <tom@tromey.com>
5852
5853         * tui/tui-data.c (tui_data_item_window): Update.
5854         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5855         * tui/tui-windata.c (tui_display_all_data)
5856         (tui_display_data_from_line): Update.
5857         (tui_check_data_values): Remove.
5858         * tui/tui-regs.c (tui_show_register_group)
5859         (tui_display_reg_element_at_line): Update.
5860         * tui/tui-hooks.c (tui_register_changed)
5861         (tui_refresh_frame_and_register_information): Call
5862         tui_check_register_values.
5863         * tui/tui-data.h (struct tui_data_window) <data_content,
5864         data_content_count, data_type>: Remove.
5865         (enum tui_data_type): Remove.
5866
5867         * tui/tui-data.c (tui_data_window::clear_detail)
5868         (~tui_data_window): Update.
5869
5870 2019-06-25  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5873         declare.
5874         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5875         Rename from tui_first_data_item_displayed.  Update.
5876         (tui_data_window::refresh_all)
5877         (tui_data_window::do_scroll_vertical): Update.
5878         * tui/tui-data.h (struct tui_data_window)
5879         <first_data_item_displayed>: Declare new method.
5880
5881 2019-06-25  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5884         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5885         contents...
5886         (tui_initialize_static_data): ...here.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5891         (tui_display_registers_from, tui_check_register_values): Update.
5892         (tui_display_register): Remove win_info parameter; update.
5893         (tui_get_register): Change type of parameters.
5894         * tui/tui-data.h (struct tui_data_element): Remove.
5895         (union tui_which_element) <data>: Remove.
5896         <data_window>: Change type.
5897         (struct tui_data_item_window): New.
5898         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5899         case.  Add assert.
5900         (~tui_data_item_window): New destructor.
5901         (free_content_elements): Remove DATA_ITEM_WIN case.
5902
5903 2019-06-25  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5906         Remove.
5907
5908 2019-06-25  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-data.h (struct tui_command_element): Remove.
5911         (union tui_which_element) <command>: Remove.
5912         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5913         assert.
5914         (free_content_elements): Remove CMD_WIN case.
5915
5916 2019-06-25  Tom Tromey  <tom@tromey.com>
5917
5918         * tui/tui-layout.c (tui_set_layout): Update.
5919         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5920         * tui/tui-data.c (layout_def): Update.
5921
5922 2019-06-25  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5925         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5926         (tui_source_window_base::set_new_height): Update.
5927         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5928         Update.
5929         (tui_set_locator_fullname, tui_set_locator_info)
5930         (tui_show_frame_info): Update.
5931         * tui/tui-source.c (tui_set_source_content)
5932         (tui_source_is_displayed): Update.
5933         * tui/tui-layout.c (show_source_disasm_command, show_data)
5934         (show_source_or_disasm_and_command): Update.
5935         * tui/tui-disasm.c (tui_set_disassem_content)
5936         (tui_get_begin_asm_address): Update.
5937         * tui/tui-data.h (struct tui_locator_element): Remove.
5938         (union tui_which_element) <locator>: Remove.
5939         (struct tui_locator_window): New.
5940         (tui_locator_win_info_ptr): Change return type.
5941         * tui/tui-data.c (_locator): Change type.
5942         (tui_locator_win_info_ptr): Change return type.
5943         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5944         (tui_alloc_content): Add assert.
5945
5946 2019-06-25  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-winsource.c
5949         (tui_exec_info_window::maybe_allocate_content): New method.
5950         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5951         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5952         (make_source_or_disasm_window): Add cast.
5953         * tui/tui-data.h (union tui_which_element) <simple_string>:
5954         Remove.
5955         (struct tui_source_info): New.
5956         (struct tui_source_window_base) <execution_info>: Change type.
5957         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5958         case, and add assert.
5959         (tui_alloc_content): Add assert.
5960
5961 2019-06-25  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5964         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5965         * tui/tui-data.c (tui_alloc_win_info): Remove.
5966
5967 2019-06-25  Tom Tromey  <tom@tromey.com>
5968
5969         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5970         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5971         can_highlight.
5972
5973 2019-06-25  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5976         make_visible_with_new_height method.
5977         (tui_win_info::make_visible_with_new_height): New method.
5978         (tui_source_window_base::do_make_visible_with_new_height)
5979         (tui_data_window::do_make_visible_with_new_height)
5980         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5981         (make_visible_with_new_height): Remove.
5982         (tui_resize_all, tui_adjust_win_heights): Use
5983         make_visible_with_new_height method.
5984         * tui/tui-data.h (struct tui_win_info)
5985         <do_make_visible_with_new_height, make_visible_with_new_height>:
5986         New methods.
5987         (struct tui_source_window_base, struct tui_data_window)
5988         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5989         methods.
5990
5991 2019-06-25  Tom Tromey  <tom@tromey.com>
5992
5993         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5994         method.
5995         (update_tab_width): Call update_tab_width method.
5996         * tui/tui-data.h (struct tui_win_info)
5997         (struct tui_source_window_base) <update_tab_width>: New methods.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6002         parameter.
6003         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6004         parameter.
6005         (tui_gen_win_info::make_visible): Update.
6006         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6007         parameter.
6008         * tui/tui-data.h (enum tui_box): New enum.
6009         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6010
6011 2019-06-25  Tom Tromey  <tom@tromey.com>
6012
6013         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6014         init_and_make_win for EXEC_INFO_WIN.
6015         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6016         longer inline.
6017         (struct tui_win_info) <~tui_win_info>: Inline.
6018         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6019         Don't declare.
6020         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6021         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6022         Remove.
6023         (tui_initialize_static_data): Update.
6024         (~tui_gen_win_info): Handle more cleanup here.
6025         (~tui_source_window_base): Delete "execution_info".
6026         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6027
6028 2019-06-25  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-layout.c (make_command_window): Don't set
6031         can_highlight.
6032         (show_source_disasm_command): Call the reset method.
6033         (show_data): Don't set can_highlight.  Call the reset method.
6034         (tui_gen_win_info::reset): Rename from init_gen_win_info
6035         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6036         (show_source_or_disasm_and_command): Call the reset method.
6037         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6038         (struct tui_cmd_window): Set can_highlight.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6043         from make_visible.
6044         (tui_make_visible, tui_make_invisible): Rewrite.
6045         (tui_win_info::make_visible): Remove.
6046         (tui_source_window_base::make_visible): Update.
6047         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6048         method.  Moved from...
6049         (struct tui_win_info) <make_visible>: ...here.
6050
6051 2019-06-25  Tom Tromey  <tom@tromey.com>
6052
6053         * tui/tui-winsource.c
6054         (tui_source_window_base::do_scroll_horizontal): Remove direction
6055         parameter.
6056         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6057         direction parameter.
6058         * tui/tui-win.c (tui_win_info::forward_scroll)
6059         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6060         (tui_win_info::right_scroll): Update.
6061         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6062         direction parameter.
6063         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6064         direction parameter.
6065         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6066         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6067         Remove direction parameter.
6068         (struct tui_source_window_base, struct tui_source_window)
6069         (struct tui_disasm_window, struct tui_data_window)
6070         (struct tui_cmd_window): Update.
6071
6072 2019-06-25  Tom Tromey  <tom@tromey.com>
6073
6074         * tui/tui-winsource.h (tui_set_exec_info_content)
6075         (tui_show_exec_info_content, tui_erase_exec_info_content)
6076         (tui_clear_exec_info_content, tui_update_exec_info): Change
6077         argument to tui_source_window_base.
6078         * tui/tui-winsource.c (tui_set_exec_info_content)
6079         (tui_show_exec_info_content, tui_erase_exec_info_content)
6080         (tui_clear_exec_info_content, tui_update_exec_info): Change
6081         argument to tui_source_window_base.
6082
6083 2019-06-25  Tom Tromey  <tom@tromey.com>
6084
6085         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6086         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6091         check.
6092
6093 2019-06-25  Tom Tromey  <tom@tromey.com>
6094
6095         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6096         type to void.
6097         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6098         type to void.
6099         * tui/tui-source.c (tui_set_source_content): Update.
6100         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6101
6102 2019-06-25  Tom Tromey  <tom@tromey.com>
6103
6104         * tui/tui-win.c (window_name_completer, tui_set_focus)
6105         (tui_all_windows_info): Use name method.
6106         * tui/tui-data.h (struct tui_gen_win_info)
6107         (struct tui_source_window, struct tui_disasm_window)
6108         (struct tui_data_window, struct tui_cmd_window) <name>: New
6109         method.
6110         (tui_win_name): Don't declare.
6111         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6112         (tui_win_name): Remove.
6113
6114 2019-06-25  Tom Tromey  <tom@tromey.com>
6115
6116         * tui/tui-winsource.h (tui_update_source_window)
6117         (tui_update_source_window_as_is): Change parameter type.
6118         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6119         to be a tui_source_window_base.
6120         (tui_update_source_window_as_is): Likewise.
6121         * tui/tui-win.c (make_visible_with_new_height): Update.
6122
6123 2019-06-25  Tom Tromey  <tom@tromey.com>
6124
6125         * tui/tui-winsource.c (tui_erase_source_content)
6126         (tui_show_source_content, tui_show_exec_info_content)
6127         (tui_erase_exec_info_content): Use refresh_window method.
6128         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6129         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6130         from tui_refresh_win.
6131         (tui_data_window::refresh_window): New method.
6132         (tui_win_info::refresh, tui_source_window_base::refresh)
6133         (tui_refresh_all): Use refresh_window method.
6134         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6135         method.
6136         * tui/tui-regs.c (tui_display_register): Call refresh_window
6137         method.
6138         * tui/tui-layout.c (show_source_disasm_command)
6139         (show_source_or_disasm_and_command): Call refresh_window method.
6140         * tui/tui-data.h (struct tui_gen_win_info)
6141         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6142         New method.
6143
6144 2019-06-25  Tom Tromey  <tom@tromey.com>
6145
6146         * tui/tui.c (tui_rl_other_window, tui_enable)
6147         (tui_is_window_visible, tui_get_command_dimension): Update.
6148         * tui/tui-winsource.c (tui_update_source_window_as_is)
6149         (tui_clear_source_content, tui_erase_source_content)
6150         (tui_show_source_line, tui_source_window_base::refill)
6151         (tui_source_window_base::do_scroll_horizontal)
6152         (tui_source_window_base::set_is_exec_point_at)
6153         (tui_update_breakpoint_info, tui_set_exec_info_content)
6154         (tui_alloc_source_buffer, tui_line_is_displayed)
6155         (tui_addr_is_displayed): Update.
6156         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6157         (tui_check_and_display_highlight_if_needed)
6158         (tui_win_info::make_visible, tui_win_info::refresh)
6159         (tui_refresh_all): Update.
6160         * tui/tui-windata.c (tui_first_data_item_displayed)
6161         (tui_delete_data_content_windows, tui_erase_data_content)
6162         (tui_display_all_data, tui_data_window::refresh_all)
6163         (tui_check_data_values): Update.
6164         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6165         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6166         (tui_win_info::backward_scroll, tui_refresh_all_win)
6167         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6168         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6169         (tui_source_window_base::set_new_height)
6170         (tui_data_window::set_new_height)
6171         (make_invisible_and_set_new_height)
6172         (make_visible_with_new_height, new_height_ok)
6173         (parse_scrolling_args): Update.
6174         * tui/tui-stack.c (tui_show_frame_info): Update.
6175         * tui/tui-source.c (tui_set_source_content)
6176         (tui_set_source_content_nil, tui_source_is_displayed)
6177         (tui_source_window::do_scroll_vertical): Update.
6178         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6179         (tui_display_registers_from, tui_display_reg_element_at_line)
6180         (tui_check_register_values, tui_reg_command): Update.
6181         * tui/tui-layout.c (tui_default_win_height)
6182         (show_source_disasm_command, show_data, init_and_make_win)
6183         (show_source_or_disasm_and_command): Update.
6184         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6185         (tui_redisplay_readline, tui_mld_flush)
6186         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6187         (tui_getc): Update.
6188         * tui/tui-disasm.c (tui_set_disassem_content)
6189         (tui_disasm_window::do_scroll_vertical): Update.
6190         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6191         Now virtual.
6192         (struct tui_win_info): Derive from tui_gen_win_info.
6193         <~tui_win_info>: Mark as override.
6194         <generic>: Remove member.
6195         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6196         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6197         (~tui_data_window, ~tui_win_info)
6198         (tui_free_all_source_wins_content): Update.
6199         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-layout.c (init_and_make_win): Use new.
6204         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6205         destructor, initializers.
6206         (tui_alloc_generic_win_info): Don't declare.
6207         * tui/tui-data.c (_locator): Add argument to constructor.
6208         (source_win, disasm_win): New globals.
6209         (exec_info): Remove.
6210         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6211         Update.
6212         (tui_alloc_generic_win_info): Remove.
6213         (init_content_element): Use new.
6214         (tui_win_info::tui_win_info): Update.
6215         (free_content_elements) <case DATA_WIN>: Use delete.
6216
6217 2019-06-25  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6220         * tui/tui-windata.c (tui_first_data_item_displayed)
6221         (tui_delete_data_content_windows): Update.
6222         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6223         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6224         (tui_display_registers_from, tui_check_register_values): Update.
6225         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6226         pointer.
6227         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6228         window.
6229         (tui_free_data_content): Update.
6230         (free_content_elements) <case DATA_WIN>: Free the window.
6231
6232 2019-06-25  Tom Tromey  <tom@tromey.com>
6233
6234         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6235         Update.
6236         * tui/tui-layout.c (make_command_window)
6237         (show_source_disasm_command, show_data, init_and_make_win)
6238         (show_source_or_disasm_and_command): Update.
6239         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6240         method.
6241         <can_highight, is_highlighted>: Now bool.
6242         (tui_set_win_highlight): Don't declare.
6243         * tui/tui-data.c (tui_set_win_highlight): Remove.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-wingeneral.c (make_visible): Remove check of window
6248         type.
6249
6250 2019-06-25  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-win.c (tui_win_info::max_height)
6253         (tui_cmd_window::max_height): New methods.
6254         (new_height_ok): Call max_height.
6255         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6256         <max_height>: New method.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-win.c (tui_source_window_base::set_new_height)
6261         (tui_data_window::set_new_height): New methods.
6262         (make_invisible_and_set_new_height): Call set_new_height method.
6263         * tui/tui-data.h (struct tui_win_info)
6264         (struct tui_source_window_base, struct tui_data_window)
6265         <set_new_height>: New method.
6266
6267 2019-06-25  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6270         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6271         tui_refresh_data_win.
6272         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6273         method.
6274         (tui_refresh_all_win): Call the refresh_all method.
6275         (tui_set_focus): Likewise.
6276         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6277         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6278         Likewise.
6279
6280 2019-06-25  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-winsource.h (tui_refill_source_window)
6283         (tui_set_is_exec_point_at): Don't declare.
6284         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6285         (tui_source_window_base::refill): Rename from
6286         tui_refill_source_window.
6287         (tui_source_window_base::do_scroll_horizontal): Update.
6288         (tui_source_window_base::set_is_exec_point_at): Rename from
6289         tui_set_is_exec_point_at.
6290         (tui_update_all_breakpoint_info): Update.
6291         * tui/tui-stack.c (tui_show_frame_info): Update.
6292         * tui/tui-layout.c (show_data): Add cast.
6293         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6294         * tui/tui-data.h (struct tui_source_window_base) <refill,
6295         set_is_exec_point_at>: New methods.
6296         (tui_source_windows, tui_add_to_source_windows): Update types.
6297         (tui_add_to_source_windows): Remove redundant declaration.
6298         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6299         (tui_source_windows): Change return type.
6300         (tui_clear_source_windows_detail): Update.
6301         (tui_add_to_source_windows): Change type of parameter.
6302         (tui_free_all_source_wins_content): Update.
6303
6304 2019-06-25  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-wingeneral.c (tui_win_info::refresh)
6307         (tui_source_window_base::refresh): New methods.
6308         (tui_refresh_all): Call the refresh method.
6309         * tui/tui-data.h (struct tui_win_info)
6310         (struct tui_source_window_base) <refresh>: New method.
6311
6312 2019-06-25  Tom Tromey  <tom@tromey.com>
6313
6314         * tui/tui.h (tui_is_window_visible): Return bool.
6315         * tui/tui.c (tui_is_window_visible): Return bool.
6316         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6317         (tui_make_visible, tui_make_invisible)
6318         (tui_win_info::make_visible)
6319         (tui_source_window_base::make_visible, make_all_visible)
6320         (tui_make_all_visible, tui_make_all_invisible): Update.
6321         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6322         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6323         bool.
6324         (struct tui_win_info, struct tui_source_window_base)
6325         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6326         * tui/tui-data.c (tui_init_generic_part): Update.
6327
6328 2019-06-25  Tom Tromey  <tom@tromey.com>
6329
6330         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6331         (tui_source_window_base::make_visible): New methods.
6332         (make_all_visible): Make method call.
6333         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6334         (struct tui_source_window_base, struct tui_cmd_window): Override
6335         make_visible.
6336         (tui_win_is_source_type): Don't declare.
6337         * tui/tui-data.c (tui_win_is_source_type): Remove.
6338
6339 2019-06-25  Tom Tromey  <tom@tromey.com>
6340
6341         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6342         NULL check.
6343
6344 2019-06-25  Tom Tromey  <tom@tromey.com>
6345
6346         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6347         Inline constructor.  Add initializers for members.
6348         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6349         constructors; now inline in class.
6350
6351 2019-06-25  Tom Tromey  <tom@tromey.com>
6352
6353         * tui/tui-regs.c (tui_show_registers): Update.
6354         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6355         bool.
6356         * tui/tui-data.c (tui_data_window::clear_detail)
6357         (tui_data_window): Update.
6358
6359 2019-06-25  Tom Tromey  <tom@tromey.com>
6360
6361         * tui/tui-windata.c (tui_display_all_data)
6362         (tui_display_data_from_line, tui_display_data_from)
6363         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6364         Update.
6365         * tui/tui-regs.c (tui_last_regs_line_no)
6366         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6367         (tui_show_registers, tui_show_register_group)
6368         (tui_display_registers_from, tui_display_reg_element_at_line)
6369         (tui_display_registers_from_line, tui_check_register_values)
6370         (tui_reg_next, tui_reg_prev): Update.
6371         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6372         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6373         tui_data_window.
6374         (struct tui_win_info) <detail>: Remove.  Add new fields from
6375         tui_data_info.
6376         (TUI_DATA_WIN): Add cast.
6377         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6378         (~tui_data_window): Simplify.
6379
6380 2019-06-25  Tom Tromey  <tom@tromey.com>
6381
6382         * tui/tui-layout.c (show_source_disasm_command)
6383         (show_source_or_disasm_and_command): Update.
6384         * tui/tui-io.c (update_cmdwin_start_line)
6385         (tui_redisplay_readline): Update.
6386         * tui/tui-data.h (struct tui_command_info): Remove.
6387         (struct tui_win_info) <detail>: Remove command_info member.
6388         (struct tui_data_window) <start_line>: New member, from
6389         tui_command_info.
6390         (TUI_CMD_WIN): Add casts.
6391
6392 2019-06-25  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-winsource.c (tui_update_source_window)
6395         (tui_refill_source_window)
6396         (tui_source_window_base::do_scroll_horizontal)
6397         (tui_update_breakpoint_info, tui_set_exec_info_content)
6398         (tui_show_exec_info_content, tui_erase_exec_info_content)
6399         (tui_clear_exec_info_content): Update.
6400         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6401         Update.
6402         * tui/tui-win.c (make_invisible_and_set_new_height)
6403         (make_visible_with_new_height): Update.
6404         * tui/tui-source.c (tui_set_source_content)
6405         (tui_show_symtab_source): Update.
6406         * tui/tui-layout.c (extract_display_start_addr)
6407         (show_source_disasm_command, show_data)
6408         (make_source_or_disasm_window)
6409         (show_source_or_disasm_and_command): Update.
6410         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6411         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6412         "gdbarch".
6413         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6414         to tui_source_window_base.
6415         (struct tui_win_info) <detail>: Remove source_info member.
6416         (struct tui_source_window_base) <has_locator>: Inline.
6417         Move contents from tui_source_info; rename has_locator member to
6418         m_has_locator.
6419         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6420         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6421         header file.
6422         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6423         Simplify.
6424         (tui_free_all_source_wins_content): Cast to
6425         tui_source_window_base.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-win.c (make_invisible_and_set_new_height)
6430         (make_visible_with_new_height): Call has_locator method.
6431         * tui/tui-layout.c (show_source_disasm_command, show_data)
6432         (show_source_or_disasm_and_command): Update for bool change.
6433         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6434         (tui_win_info) <has_locator>: New method.
6435         (struct tui_source_window_base) <has_locator>: New method.
6436         (tui_win_has_locator): Don't declare.
6437         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6438         from tui_win_has_locator.
6439         (tui_source_window_base): Use false, not FALSE.
6440
6441 2019-06-25  Tom Tromey  <tom@tromey.com>
6442
6443         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6444         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6445         clear_detail method directly.
6446         (tui_clear_win_detail): Remove.
6447
6448 2019-06-25  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6451         "this", not TUI_DISASM_WIN.
6452
6453 2019-06-25  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6456         declare.
6457         * tui/tui-winsource.c
6458         (tui_source_window_base::do_scroll_horizontal): Rename from
6459         tui_horizontal_source_scroll.
6460         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6461         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6462         from tui_vertical_data_scroll.
6463         * tui/tui-win.h (tui_scroll): Don't declare.
6464         * tui/tui-win.c (tui_win_info::forward_scroll)
6465         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6466         (tui_win_info::right_scroll): Rename and update.
6467         (tui_scroll_forward_command, tui_scroll_backward_command)
6468         (tui_scroll_left_command, tui_scroll_right_command): Update.
6469         (tui_scroll): Remove.
6470         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6471         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6472         from tui_vertical_source_scroll.
6473         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6474         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6475         from tui_vertical_disassem_scroll.
6476         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6477         do_scroll_horizontal>: New methods.
6478         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6479         Likewise.
6480         (struct tui_source_window_base): Add do_scroll_horizontal.
6481         (struct tui_source_window, struct tui_disasm_window): Add
6482         do_scroll_vertical.
6483         (struct tui_data_window, struct tui_cmd_window): Add
6484         do_scroll_horizontal and do_scroll_vertical.
6485         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6486
6487 2019-06-25  Tom Tromey  <tom@tromey.com>
6488
6489         * tui/tui-data.h (struct tui_source_window_base): New struct.
6490         (struct tui_source_window): Derive from tui_source_window_base.
6491         (struct tui_disasm_window): New struct.
6492         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6493         from tui_source_window::clear_detail.
6494         (tui_source_window_base): Rename from tui_source_window.
6495         (~tui_source_window_base): Rename from ~tui_source_window.
6496         (tui_alloc_win_info): Create a tui_disasm_window.
6497
6498 2019-06-25  Tom Tromey  <tom@tromey.com>
6499
6500         * tui/tui-data.h (struct tui_source_window)
6501         (struct tui_data_window): Declare destructors.
6502         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6503         destructors.
6504         (tui_win_info): Simplify.
6505
6506 2019-06-25  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui-winsource.c (tui_display_main)
6509         (tui_update_source_windows_with_addr)
6510         (tui_update_all_breakpoint_info): Update.
6511         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6512         (new_height_ok, parse_scrolling_args): Update.
6513         * tui/tui-stack.c (tui_show_frame_info): Update.
6514         * tui/tui-data.h (struct tui_list): Remove.
6515         (tui_source_windows): Return a reference to a std::vector.
6516         * tui/tui-data.c (source_windows): Now a std::vector.
6517         (tui_source_windows): Change return type.
6518         (tui_clear_source_windows): Rewrite.
6519         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6520         (tui_free_all_source_wins_content): Rewrite.
6521
6522 2019-06-25  Tom Tromey  <tom@tromey.com>
6523
6524         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6525         (struct tui_data_window, struct tui_cmd_window): Declare
6526         clear_detail method.
6527         * tui/tui-data.c (tui_source_window::clear_detail)
6528         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6529         methods.
6530         (tui_clear_win_detail): Simplify.
6531
6532 2019-06-25  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-layout.c (make_source_window, make_disasm_window)
6535         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6536         Return the new window.
6537         (show_source_disasm_command, show_data)
6538         (show_source_or_disasm_and_command): Update.
6539
6540 2019-06-25  Tom Tromey  <tom@tromey.com>
6541
6542         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6543         parameter.  Return the new window.
6544         (show_source_disasm_command): Update and remove NULL check.
6545         (show_source_or_disasm_and_command): Update.
6546
6547 2019-06-25  Tom Tromey  <tom@tromey.com>
6548
6549         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6550
6551 2019-06-25  Tom Tromey  <tom@tromey.com>
6552
6553         * tui/tui-data.h (struct tui_win_info): Make constructor
6554         protected.  Make destructor virtual.  Add initializers.
6555         (tui_source_window, tui_data_window, tui_cmd_window): New
6556         classes.
6557         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6558         constructor.  Add "type" parameter.
6559         (tui_source_window, tui_data_window, tui_cmd_window): New
6560         constructors.
6561         (tui_alloc_win_info): Instantiate the appropriate subclass.
6562
6563 2019-06-25  Tom Tromey  <tom@tromey.com>
6564
6565         * tui/tui-win.c (tui_resize_all): Use delete.
6566         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6567         destructor.
6568         (tui_free_window): Don't declare.
6569         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6570         Update.
6571
6572 2019-06-25  Tom Tromey  <tom@tromey.com>
6573
6574         * tui/tui-data.h (struct tui_win_info): Add constructor.
6575         * tui/tui-data.c (tui_alloc_win_info): Use new.
6576         (tui_free_window): Use delete.
6577
6578 2019-06-22  Tom Tromey  <tom@tromey.com>
6579
6580         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6581         declare.
6582         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6583
6584 2019-06-22  Tom Tromey  <tom@tromey.com>
6585
6586         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6587         declare.
6588         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6589
6590 2019-06-22  Tom de Vries  <tdevries@suse.de>
6591
6592         * dwarf2read.c (create_addrmap_from_aranges)
6593         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6594         instead of '%zu'.
6595
6596 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6597
6598         * dwarf2read.h (dwarf2_section_info_def): Remove.
6599         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6600         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6601         std::vector<dwarf2_section_info>.
6602         (struct dwo_file) <~dwo_file>: Remove.
6603         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6604         types field.
6605         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6606         (dwarf2_read_debug_names): Likewise.
6607         (create_debug_types_hash_table): Change parameter type to
6608         array_view, adjust code accordingly.
6609         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6610         (partial_die_info::fixup): Likewise.
6611         (determine_prefix): Likewise.
6612         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6613
6614 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6615
6616         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6617         gdb_bfd_ref_ptr.
6618         <~dwo_file>: Remove call to gdb_bfd_unref.
6619         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6620         gdb_bfd_ref_ptr::get.
6621
6622 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6623
6624         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6625         type to htab_up.
6626         * dwarf2read.c (struct dwo_file): Initialize fields.
6627         <~dwo_file>: New.
6628         (free_dwo_file): Remove, move content to ~dwo_file.
6629         (struct dwo_file_deleter): Remove.
6630         (dwo_file_up>: Remove custom deleter.
6631         (free_dwo_files): Remove.
6632         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6633         dwo_files.
6634         (process_skeletonless_type_units): Call unique_ptr::get.
6635         (allocate_dwo_file_hash_table): Add deleter to created hash
6636         table.  Change return type to htab_up.
6637         (lookup_dwo_file_slot): Don't memset dwo_file, call
6638         unique_ptr::get.
6639         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6640         (create_dwo_unit_in_dwp_v2): Likewise.
6641         (open_and_init_dwo_file): Likewise.
6642         (free_dwo_file_from_slot): Remove.
6643
6644 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6645
6646         * dwarf2read.h (struct dwarf2_section_info) <readin,
6647         is_virtual>: Change type to bool.
6648         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6649         true instead of 1.
6650
6651 2019-06-19  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-data.h (tui_init_content_element): Don't declare.
6654
6655 2019-06-19  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-data.h (tui_init_win_info): Don't declare.
6658
6659 2019-06-19  Tom de Vries  <tdevries@suse.de>
6660
6661         * dwarf2read.h (abstract_to_concrete): Change type to
6662         std::unordered_map<sect_offset, std::vector<sect_offset>,
6663         gdb::hash_enum<sect_offset>>.
6664
6665 2019-06-19  Tom Tromey  <tromey@adacore.com>
6666
6667         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6668         EVAL_AVOID_SIDE_EFFECTS specially.
6669
6670 2019-06-19  Tom Tromey  <tromey@adacore.com>
6671
6672         * source-cache.c (highlighter): New global.
6673         (source_cache::get_source_lines): Create a highlighter on demand.
6674
6675 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6676
6677         * defs.h (deprecated_interactive_hook): Delete declaration.
6678         * interps.c (clear_interpreter_hooks): Remove use of
6679         deprecated_interactive_hook.
6680         * top.c (deprecated_interactive_hook): Delete definition.
6681         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6682
6683 2019-06-18  Tom de Vries  <tdevries@suse.de>
6684
6685         PR gdb/24515
6686         * dwarf2read.h (abstract_to_concrete): Change type from
6687         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6688         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6689         * dwarf2read.c (read_variable): Update.
6690         (dwarf2_fetch_die_loc_sect_off): Update.
6691
6692 2019-06-17  Tom de Vries  <tdevries@suse.de>
6693
6694         PR gdb/24617
6695         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6696         accessing parent[parent_len - 1].
6697
6698 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6699
6700         PR gdb/24364
6701         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6702         call dtrace_process_dof with NULL dof.
6703
6704 2019-06-16  Tom de Vries  <tdevries@suse.de>
6705
6706         PR gdb/24445
6707         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6708
6709 2019-06-16  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6712         (make_all_visible): Use address of member.
6713
6714 2019-06-16  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6717         (tui_free_window, free_content, free_content_elements): Remove
6718         unnecessary cast.
6719         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6720         cast.
6721         * tui/tui-regs.c (tui_show_register_group)
6722         (tui_display_registers_from, tui_display_reg_element_at_line):
6723         Remove unnecessary cast.
6724
6725 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6726
6727         * linux-nat.c (normal_mask): Delete.
6728         (_initialize_linux_nat): Don't initialise normal_mask.
6729
6730 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6731
6732         PR gdb/24445
6733         * dwarf-index-write.h (write_psymtabs_to_index): Add
6734         dwz_basename parameter.
6735         * dwarf-index-write.c (write_gdbindex): Move file writing to
6736         write_gdbindex_1.  Change return type void.
6737         (assert_file_size): Move up, remove filename parameter.
6738         (write_gdbindex_1): New function.
6739         (write_debug_names): Change return type to void, call
6740         assert_file_size.
6741         (struct index_wip_file): New struct.
6742         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6743         file logic to index_wip_file.  Write index for dwz file if
6744         needed.
6745         (save_gdb_index_command): Pass basename of dwz file, if present.
6746         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6747         build-id of dwz file, if present.
6748         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6749         (dwarf2_get_dwz_file): Likewise.
6750         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6751         (dwarf2_get_dwz_file): Likewise.
6752
6753 2019-06-16  Tom Tromey  <tom@tromey.com>
6754
6755         * coffread.c (process_coff_symbol): Use xstrdup.
6756         * value.c (create_internalvar): Use xstrdup.
6757
6758 2019-06-16  Tom Tromey  <tom@tromey.com>
6759
6760         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6761         * breakpoint.c (stopin_command, stopat_command)
6762         (until_break_command, decode_location_default): Remove unnecessary
6763         cast.
6764         * utils.c (subset_compare): Remove unnecessary cast.
6765         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6766         cast.
6767         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6768         cast.
6769         * infcmd.c (path_command): Remove unnecessary cast.
6770         * coffread.c (decode_type): Remove unnecessary cast.
6771         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6772         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6773         * tui/tui-stack.c (tui_show_locator_content)
6774         (tui_show_frame_info): Remove unnecessary cast.
6775         * tui/tui-win.c (tui_scroll_forward_command)
6776         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6777         (parse_scrolling_args): Remove unnecessary cast.
6778         * tui/tui-data.c (init_win_info, tui_del_window)
6779         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6780         (free_content_elements): Remove unnecessary cast.
6781         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6782         unnecessary cast.
6783         * tui/tui-source.c (tui_set_source_content)
6784         (tui_vertical_source_scroll): Remove unnecessary cast.
6785         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6786         cast.
6787         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6788         * tui/tui-regs.c (tui_display_registers_from)
6789         (tui_display_register): Remove unnecessary cast.
6790         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6791         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6792         (make_visible): Remove unnecessary cast.
6793         * tui/tui-winsource.c (tui_erase_source_content)
6794         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6795         unnecessary cast.
6796         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6797         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6798         * stabsread.c (read_type, read_array_type, read_range_type):
6799         Remove unnecessary cast.
6800         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6801         (parse_symbol, parse_type, upgrade_type, parse_external)
6802         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6803         unnecessary cast.
6804         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6805
6806 2019-06-16  Tom Tromey  <tom@tromey.com>
6807
6808         * tui/tui-data.c (tui_alloc_generic_win_info)
6809         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6810         checks.
6811
6812 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6813             Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * f-typeprint.c (f_print_type): Don't return early for not
6816         associated or not allocated types.
6817         (f_type_print_varspec_suffix): Add print_rank parameter and print
6818         ranks of array types in case they dangling.
6819         (f_type_print_base): Add print_rank parameter.
6820
6821 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * NEWS: Mention new MI commands.
6824         * break-catch-throw.c (enum exception_event_kind): Move to
6825         breakpoint.h.
6826         (print_mention_exception_catchpoint): Output text as a single
6827         message.
6828         (catch_exception_command_1): Rename to...
6829         (catch_exception_event): ...this, make non-static, update header
6830         command, and change some parameter types.
6831         (catch_catch_command): Update for changes to
6832         catch_exception_command_1.
6833         (catch_throw_command): Likewise.
6834         (catch_rethrow_command): Likewise.
6835         * breakpoint.c (enum exception_event_kind): Delete.
6836         * breakpoint.h (enum exception_event_kind): Moved here from
6837         break-catch-throw.c.
6838         (catch_exception_event): Declare.
6839         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6840         (mi_cmd_catch_throw): New function.
6841         (mi_cmd_catch_rethrow): New function.
6842         (mi_cmd_catch_catch): New function.
6843         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6844         'catch-catch' entries.
6845         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6846         (mi_cmd_catch_rethrow): Declare.
6847         (mi_cmd_catch_catch): Declare.
6848
6849 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6850
6851         * annotate.c (annotate_source_line): Change return type to void,
6852         update implementation to match.
6853         * annotate.h (annotate_source_line): Change return type to void,
6854         update header comment.
6855         * stack.c (print_frame_info): Don't change what frame information
6856         is printed based on whether annotations are on or not.
6857
6858 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6859
6860         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6861         (annotate_source): Make static.
6862         (annotate_source_line): Moved from source.c and renamed from
6863         identify_source_line.  Update the return type.
6864         * annotate.h (annotate_source): Delete declaration.
6865         (annotate_source_line): Declaration moved from source.h, and
6866         renamed from identify_source_line.  Return type updated.
6867         * source.c (identify_source_line): Moved to annotate.c and renamed
6868         to annotate_source_line.
6869         (info_line_command): Remove check of annotation_level.
6870         * source.h (identify_source_line): Move declaration to annotate.h
6871         and rename to annotate_source_line.
6872         * stack.c: Add 'annotate.h' include.
6873         (print_frame_info): Remove check of annotation_level before
6874         calling annotate_source_line.
6875
6876 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6877
6878         * source-cache.c (source_cache::get_plain_source_lines): Use
6879         open_source_file_with_line_charpos instead of just
6880         open_source_file, remove call to find_source_lines.
6881         (source_cache::get_source_lines): Likewise.
6882         * source.c (find_source_lines): Make static.
6883         (get_filename_and_charpos): Renamed into...
6884         (open_source_file_with_line_charpos): ..this along with changes to
6885         return a scoped_fd, and some other minor clean ups.
6886         (identify_source_line): Use open_source_file_with_line_charpos.
6887         (search_command_helper): Use open_source_file_with_line_charpos
6888         instead of just open_source_file, remove call to
6889         find_source_lines.
6890         * source.h (open_source_file_with_line_charpos): Declare new
6891         function.
6892         (find_source_lines): Delete declaration.
6893
6894 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * source.c (get_filename_and_charpos): Remove fullname
6897         parameter.
6898         (identify_source_line): Update call to get_filename_and_charpos.
6899
6900 2019-06-14  Tom Tromey  <tromey@adacore.com>
6901
6902         PR gdb/24502:
6903         * ui-style.h (skip_ansi_escape): Update comment.
6904         * ui-file.h (class no_terminal_escape_file): New class.
6905         * ui-file.c (no_terminal_escape_file::write)
6906         (no_terminal_escape_file::puts): New methods.
6907         * cli/cli-logging.c (handle_redirections): Use
6908         no_terminal_escape_file.
6909
6910 2019-06-14  Tom Tromey  <tromey@adacore.com>
6911
6912         * NEWS: Move convenience variable news above Python news.
6913
6914 2019-06-14  Tom Tromey  <tom@tromey.com>
6915
6916         * gnulib: Move directory to top-level.
6917         * configure.ac: Don't configure gnulib.
6918         * configure: Rebuild.
6919         * common/common-defs.h: Use new path to gnulib.
6920         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6921         (GNULIB_H): Remove.
6922         (INCGNU): Look in new gnulib location.
6923         (HFILES_NO_SRCDIR): Remove gnulib files.
6924         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6925         (generated_files): Remove GNULIB_H.
6926         ($(LIBGNU), all-lib): Remove targets.
6927         (distclean): Don't mention GNULIB_BUILDDIR.
6928         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6929
6930 2019-06-14  Tom Tromey  <tromey@adacore.com>
6931
6932         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6933         Warn if symbol file does not provide any symbols.
6934
6935 2019-06-14  Tom Tromey  <tromey@adacore.com>
6936
6937         * source.c (find_and_open_source): Respect basenames_may_differ.
6938
6939 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6940
6941         * annotate.c (annotate_breakpoints_invalid): Make use of
6942         scoped_restore_terminal_state.
6943         (annotate_frames_invalid): Likewise.
6944
6945 2019-06-14  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6948         allow assignment to an internalvar.
6949
6950 2019-06-14  Tom Tromey  <tromey@adacore.com>
6951
6952         * ada-lex.l: Allow "_" in attribute names.
6953
6954 2019-06-14  Tom Tromey  <tromey@adacore.com>
6955
6956         PR gdb/24653:
6957         * regcache.c (registers_changed): Don't call alloca.
6958         * top.c (execute_command): Don't call alloca.
6959
6960 2019-06-13  Pedro Alves  <palves@redhat.com>
6961
6962         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6963         'expression'.  When parsing an expression, error out if there's
6964         junk after "unlimited".
6965         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6966         (do_set_command): Adjust calls to is_unlimited_literal.
6967
6968 2019-06-13  Pedro Alves  <palves@redhat.com>
6969
6970         * compile/compile.c (make_compile_options_def_group): Add braces
6971         around array_view initializer.
6972         * thread.c (make_thread_apply_all_options_def_group)
6973         (make_thread_apply_all_options_def_group): Likewise.
6974
6975 2019-06-13  Pedro Alves  <palves@redhat.com>
6976
6977         * NEWS (New commands): Mention "maint test-options
6978         require-delimiter", "maint test-options unknown-is-error", "maint
6979         test-options unknown-is-operand" and "maint show
6980         test-options-completion-result".
6981         (New command options, command completion): New section.
6982         (Completion improvements): New section.
6983         Mention that you can abbreviate "unlimited".
6984
6985 2019-06-13  Pedro Alves  <palves@redhat.com>
6986
6987         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6988         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6989         * unittests/cli-utils-selftests.c (test_parse_flags)
6990         (test_parse_flags_qcs): Delete.
6991         (test_cli_utils): Don't call deleted functions.
6992
6993 2019-06-13  Pedro Alves  <palves@redhat.com>
6994
6995         * thread.c: Include "cli/cli-option.h".
6996         (tp_array_compar_ascending): Global.
6997         (tp_array_compar): Delete function.
6998         (tp_array_compar_ascending, tp_array_compar_descending): New
6999         functions.
7000         (ascending_option_def, qcs_flag_option_def)
7001         (thr_qcs_flags_option_defs)
7002         (make_thread_apply_all_options_def_group)
7003         (make_thread_apply_options_def_group): New.
7004         (thread_apply_all_command): Use gdb::option::process_options.
7005         (thread_apply_command_completer)
7006         (thread_apply_all_command_completer): New.
7007         (thread_apply_command): Use gdb::option::process_options.
7008         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7009         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7010         to generate help text of "thread apply".  Adjust "taas"'s help.
7011         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7012         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7013
7014 2019-06-13  Pedro Alves  <palves@redhat.com>
7015
7016         * thread.c (thread_apply_command): Check for invalid TID with
7017         isdigit instead of !isalpha.
7018
7019 2019-06-13  Pedro Alves  <palves@redhat.com>
7020
7021         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7022         (validate_flags_qcs): New.
7023         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7024         (validate_flags_qcs): Declare.
7025         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7026         (make_frame_apply_options_def_group): New.
7027         (frame_apply_command_count): Process options with
7028         gdb::option::process_options.
7029         (frame_apply_completer): New.
7030         (frame_apply_level_completer, frame_apply_all_completer)
7031         (frame_apply_completer): New.
7032         (_initialize_stack): Update help of "frame apply", "frame apply
7033         level", "frame apply all" and "faas" to mention supported options
7034         and install command completers.
7035         * stack.h (frame_apply_all_completer): Declare.
7036         * thread.c: Include "stack.h".
7037         (tfaas_command): Add "--".
7038         (_initialize_thread): Update help "tfaas" to mention supported
7039         options and install command completer.
7040
7041 2019-06-13  Pedro Alves  <palves@redhat.com>
7042
7043         * completer.c (complete_nested_command_line): New.
7044         (gdb_completion_word_break_characters_throw): Add assertion.
7045         * completer.h (complete_nested_command_line): Declare.
7046
7047 2019-06-13  Pedro Alves  <palves@redhat.com>
7048
7049         * stack.c (parse_backtrace_qualifiers): New.
7050         (backtrace_command): Use it.
7051         (backtrace_command_completer): Complete on qualifiers.
7052
7053 2019-06-13  Pedro Alves  <palves@redhat.com>
7054
7055         * frame.c: Include "cli/cli-option.h.
7056         (user_set_backtrace_options): New.
7057         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7058         Delete.
7059         (get_prev_frame): Adjust.
7060         (boolean_option_def, uinteger_option_def)
7061         (set_backtrace_option_defs): New.
7062         (_initialize_frame): Adjust and use
7063         gdb::option::add_setshow_cmds_for_options to install "set
7064         backtrace past-main" and "set backtrace past-entry".
7065         * frame.h: Include "cli/cli-option.h".
7066         (struct frame_print_options): Forward declare.
7067         (print_frame_arguments_all, print_frame_arguments_scalars)
7068         (print_frame_arguments_none): Declare.
7069         (print_entry_values): Delete declaration.
7070         (struct frame_print_options, user_frame_print_options): New.
7071         (struct set_backtrace_options): New.
7072         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7073         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7074         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7075         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7076         (list_args_or_locals): Add frame_print_options parameter.
7077         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7078         * python/py-framefilter.c (enumerate_args): Pass down
7079         USER_FRAME_PRINT_OPTIONS.
7080         * stack.c: Include "cli/cli-option.h".
7081         (print_frame_arguments_all, print_frame_arguments_scalars)
7082         (print_frame_arguments_none): Declare.
7083         (print_raw_frame_arguments, print_entry_values): Delete.
7084         (user_frame_print_options): New.
7085         (boolean_option_def, enum_option_def, frame_print_option_defs):
7086         New.
7087         (struct backtrace_cmd_options): New.
7088         (bt_flag_option_def): New.
7089         (backtrace_command_option_defs): New.
7090         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7091         (print_frame_arg, read_frame_arg, print_frame_args)
7092         (print_frame_info, print_frame): Add frame_print_options parameter
7093         and use it.
7094         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7095         (backtrace_command_1): Add frame_print_options and
7096         backtrace_cmd_options parameters and use them.
7097         (make_backtrace_options_def_group): New.
7098         (backtrace_command): Process command options with
7099         gdb::option::process_options.
7100         (backtrace_command_completer): New.
7101         (_initialize_stack): Extend "backtrace"'s help to mention
7102         supported options.  Install completer for "backtrace".
7103         Install some settings commands with add_setshow_cmds_for_options.
7104
7105 2019-06-13  Pedro Alves  <palves@redhat.com>
7106
7107         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7108         and that "set/show print raw frame-arguments" are now deprecated.
7109
7110         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7111         command.
7112         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7113         * stack.c (_initialize_stack): Install "set/show print
7114         raw-frame-arguments", and deprecate "set/show print raw
7115         frame-arguments".
7116         * valprint.c (_initialize_valprint): Deprecate "set/show print
7117         raw".
7118
7119 2019-06-13  Pedro Alves  <palves@redhat.com>
7120
7121         * compile/compile.c (struct compile_options): New.
7122         (compile_flag_option_def, compile_command_option_defs)
7123         (make_compile_options_def_group): New.
7124         (compile_file_command): Handle options with
7125         gdb::option::process_options.
7126         (compile_file_command_completer): New function.
7127         (compile_code_command): Handle options with
7128         gdb::option::process_options.
7129         (compile_code_command_completer): New function.
7130         (_initialize_compiler): Install completers for "compile code" and
7131         "compile file".  Mention available options in "compile code" and
7132         "compile code"'s help.
7133         * completer.c (advance_to_completion_word): New, factored out from
7134         ...
7135         (advance_to_expression_complete_word_point): ... this.
7136         (advance_to_filename_complete_word_point): New.
7137         * completer.h (advance_to_filename_complete_word_point): New
7138         declaration.
7139
7140 2019-06-13  Pedro Alves  <palves@redhat.com>
7141
7142         * compile/compile.c: Include "cli/cli-option.h".
7143         (compile_print_value): Scope data pointer is now a
7144         value_print_options pointer; adjust.
7145         (compile_print_command): Process options.  Scope data pointer is
7146         now a value_print_options pointer; adjust.
7147         (_initialize_compile): Update "compile print"'s help to include
7148         supported options.  Install a completer for "compile print".
7149         * cp-valprint.c (show_vtblprint, show_objectprint)
7150         (show_static_field_print): Delete.
7151         (_initialize_cp_valprint): Don't install "set print
7152         static-members", "set print vtbl", "set print object" here.
7153         * printcmd.c: Include "cli/cli-option.h" and
7154         "common/gdb_optional.h".
7155         (print_command_parse_format): Rework to fill in a
7156         value_print_options instead of a format_data.
7157         (print_value): Change parameter type from format_data pointer to
7158         value_print_options reference.  Adjust.
7159         (print_command_1): Process options.  Adjust to pass down a
7160         value_print_options.
7161         (print_command_completer): New.
7162         (_initialize_printcmd): Install print_command_completer as
7163         handle_brkchars completer for the "print" command.  Update
7164         "print"'s help to include supported options.
7165         * valprint.c: Include "cli/cli-option.h".
7166         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7167         here from cp-valprint.c.
7168         (boolean_option_def, uinteger_option_def)
7169         (value_print_option_defs, make_value_print_options_def_group):
7170         New.  Use gdb::option::add_setshow_cmds_for_options to install
7171         "set print elements", "set print null-stop", "set print repeats",
7172         "set print pretty", "set print union", "set print array", "set
7173         print address", "set print symbol", "set print array-indexes".
7174         * valprint.h: Include <string> and "cli/cli-option.h".
7175         (make_value_print_options_def_group): Declare.
7176         (print_value): Change parameter type from format_data pointer to
7177         value_print_options reference.
7178         (print_command_completer): Declare.
7179
7180 2019-06-13  Pedro Alves  <palves@redhat.com>
7181
7182         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7183         (COMMON_SFILES): Add maint-test-settings.c.
7184         * cli/cli-decode.c (boolean_enums): New global, factored out from
7185         ...
7186         (add_setshow_boolean_cmd): ... here.
7187         * cli/cli-decode.h (boolean_enums): Declare.
7188         * cli/cli-option.c: New file.
7189         * cli/cli-option.h: New file.
7190         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7191         factored out from ...
7192         (parse_cli_boolean_value(const char *)): ... this.
7193         (is_unlimited_literal): Change parameter type to pointer to
7194         pointer.  Adjust and advance ARG pointer.
7195         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7196         (parse_cli_var_enum): New, factored out from ...
7197         (do_set_command): ... this.  Adjust.
7198         * cli/cli-setshow.h (parse_cli_boolean_value)
7199         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7200         (parse_cli_var_enum): Declare.
7201         * cli/cli-utils.c: Include "cli/cli-option.h".
7202         (get_ulongest): New.
7203         * cli/cli-utils.h (get_ulongest): Declare.
7204         (check_for_argument): New overloads.
7205         * maint-test-options.c: New file.
7206
7207 2019-06-13  Pedro Alves  <palves@redhat.com>
7208
7209         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7210         parse a range if "-" is at the end of the string.
7211
7212 2019-06-13  Pedro Alves  <palves@redhat.com>
7213
7214         * cli/cli-setshow.c (parse_auto_binary_operation)
7215         (parse_cli_boolean_value): Don't allow "o".
7216
7217 2019-06-13  Pedro Alves  <palves@redhat.com>
7218
7219         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7220         * NEWS: Mention maint test-settings KIND.
7221         * maint-test-settings.c: New file.
7222
7223 2019-06-13  Pedro Alves  <palves@redhat.com>
7224
7225         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7226         completer.
7227         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7228         "set" completers.
7229
7230 2019-06-13  Pedro Alves  <palves@redhat.com>
7231
7232         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7233         after item.
7234
7235 2019-06-13  Pedro Alves  <palves@redhat.com>
7236
7237         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7238
7239 2019-06-13  Pedro Alves <palves@redhat.com>
7240
7241         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7242         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7243         call.
7244         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7245         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7246         calls.
7247         (check_for_argument): Skip spaces after argument.
7248
7249 2019-06-13  Pedro Alves  <palves@redhat.com>
7250
7251         * thread.c (thread_apply_command): Adjust TID parsing.
7252         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7253         detected before end of string.
7254         (tid_is_in_list): Error out if LIST is invalid.
7255
7256 2019-06-13  Pedro Alves  <palves@redhat.com>
7257
7258         * completer.c (complete_line_internal_1): Rewind completion word
7259         point.
7260         (completion_tracker::advance_custom_word_point_by): Change
7261         parameter type to int.
7262         * completer.h (completion_tracker::advance_custom_word_point_by):
7263         Likewise.
7264
7265 2019-06-13  Pedro Alves  <palves@redhat.com>
7266
7267         * completer.c (advance_to_completion_word): Handle delimiters.
7268
7269 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7270
7271         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7272
7273 2019-06-11  Tom Tromey  <tom@tromey.com>
7274
7275         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7276         (xmalloc_failed): Move to alloc.c.
7277         * alloc.c: New file.
7278         * Makefile.in (COMMON_SFILES): Add alloc.c.
7279
7280 2019-06-11  Tom Tromey  <tom@tromey.com>
7281
7282         * nat/linux-waitpid.c: Don't include server.h.
7283         (linux_debug): Remove.
7284         (my_waitpid): Update.
7285
7286 2019-06-11  Tom Tromey  <tromey@adacore.com>
7287
7288         * infcall.c (_initialize_infcall): Remove trailing newline from
7289         help.
7290         * user-regs.c (_initialize_user_regs): Remove trailing newline
7291         from help.
7292         * typeprint.c (_initialize_typeprint): Remove trailing newline
7293         from help.
7294         * reverse.c (_initialize_reverse): Remove trailing newlines from
7295         help.
7296         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7297         from help.
7298         * language.c (add_set_language_command): Remove trailing newline
7299         from help.
7300         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7301         help.
7302         * disasm.c (_initialize_disasm): Remove trailing newline from
7303         help.
7304         * top.c (init_main): Remove trailing newline from help.
7305         * interps.c (_initialize_interpreter): Remove trailing newline
7306         from help.
7307         * btrace.c (_initialize_btrace): Remove trailing newlines from
7308         help.
7309         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7310         from help.
7311         * python/python.c (_initialize_python): Remove trailing newline
7312         from help.
7313         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7314         help.
7315         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7316         from help.  Reformat some text.
7317         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7318         from help.
7319         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7320         newline from help.
7321
7322 2019-06-11  Tom Tromey  <tromey@adacore.com>
7323
7324         * darwin-nat.c (darwin_decode_exception_message)
7325         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7326
7327 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * valops.c (value_slice): Check for not allocated or not
7330         associated values.
7331
7332 2019-06-10  Tom de Vries  <tdevries@suse.de>
7333
7334         PR gdb/24618
7335         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7336         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7337         invalid.
7338
7339 2019-06-10  Tom de Vries  <tdevries@suse.de>
7340
7341         PR gdb/24611
7342         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7343         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7344
7345 2019-06-10  Tom de Vries  <tdevries@suse.de>
7346
7347         PR symtab/24545
7348         * symtab.c (struct demangled_name_entry): Add language field.
7349         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7350         static minimal symbol".  Set and use language field.
7351
7352 2019-06-10  Tom Tromey  <tromey@adacore.com>
7353
7354         * ada-lang.c (_initialize_ada_language): Update help text.
7355
7356 2019-06-10  Tom Tromey  <tromey@adacore.com>
7357
7358         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7359         with a newline.
7360         * guile/guile.c (handle_boot_error): Don't end warning with a
7361         newline.
7362         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7363         warning with a newline.
7364         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7365         newline.
7366         (s12z_frame_cache): Likewise.
7367         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7368         a newline.
7369         * solib-svr4.c (disable_probes_interface): Don't end warning with
7370         a newline.
7371         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7372         newline.
7373         * python/python.c (do_finish_initialization): Don't end warning
7374         with a newline.
7375
7376 2019-06-10  Tom Tromey  <tom@tromey.com>
7377
7378         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7379         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7380         gdbpy_enter.
7381
7382 2019-06-10  Tom Tromey  <tromey@adacore.com>
7383
7384         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7385         data.
7386         (elf_new_init): Don't call stabsread_new_init.
7387         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7388         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7389         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7390
7391 2019-06-10  Tom de Vries  <tdevries@suse.de>
7392
7393         PR symtab/16264
7394         PR symtab/24517
7395         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7396
7397 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7398
7399         * source.c (find_and_open_source): Also rewrite relative file
7400         names.
7401
7402 2019-04-26  Amos Bird  <amosbird@gmail.com>
7403
7404         * annotate.c (annotate_thread_exited): Add "thread-exited"
7405         annotation.
7406
7407 2019-06-06  Tom Tromey  <tromey@adacore.com>
7408
7409         * maint.h (class scoped_command_stats): Use
7410         DISABLE_COPY_AND_ASSIGN.
7411         <print_time>: New method.
7412         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7413         print_time.
7414         (scoped_command_stats::print_time): New method.
7415
7416 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7417
7418         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7419         instructions of lengths 6 or 8 bytes.
7420
7421 2019-06-04  Pedro Alves  <palves@redhat.com>
7422
7423         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7424
7425         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7426         * breakpoint.c (condition_completer): Likewise.
7427         * cli/cli-dump.c (scan_expression): Likewise.
7428         * common/filestuff.c (mkdir_recursive): Likewise.
7429         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7430         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7431         (gdb_abspath): Likewise.
7432         * compile/compile-cplus-types.c
7433         (compile_cplus_instance::decl_name): Likewise.
7434         * completer.c (complete_explicit_location):
7435         (signal_completer, reg_or_group_completer_1): Likewise.
7436         * cp-support.c (cp_remove_params_if_any): Likewise.
7437         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7438         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7439         * infcmd.c (strip_bg_char): Likewise.
7440         * linespec.c (copy_token_string): Likewise.
7441         * mi/mi-main.c (output_cores): Likewise.
7442         * psymtab.c (psymtab_search_name):
7443         * symfile.c (test_set_ext_lang_command): Likewise.
7444         * target.c (target_fileio_read_stralloc): Likewise.
7445         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7446         * value.c (complete_internalvar): Likewise.
7447
7448 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7449
7450         Add objfile property to gdb.Type.
7451         * NEWS: Mention Python API addition.
7452         * python/py-type.c (typy_get_objfile): New method.
7453
7454 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7455
7456         * NEWS: Mention the new set|show style [title|highlight].
7457         Mention changes to "show style", "help" and "apropos".
7458
7459 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7460
7461         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7462         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7463         instead of print_help_for_command.
7464         (print_doc_of_command): New function.
7465         (help_list): Add 'apropos -v word' suggestion.
7466         (print_help_for_command): Style the command name using title style.
7467         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7468         (_initialize_cli_cmds): Describe -v in apropos_command help.
7469
7470 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7471
7472         * cli/cli-style.h (cli_style_option): Add name in constructor,
7473         add m_name class member, add constructor with intensity,
7474         add name class function.
7475         (cli_style_option::add_setshow_commands): Remove name argument.
7476         (highlight_style, title_style): New styles.
7477         * cli/cli-style.c (do_show): New function that shows a style
7478         characteristic styling the style name with itself.
7479         (set_style_name): New function.
7480         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7481         Update all callers according to the changes in cli/cli-style.h.
7482         * utils.h (fputs_highlighted): New function.
7483         * utils.c (fputs_highlighted): Likewise.
7484
7485 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * NEWS: Mention new pipe command and new convenience variables.
7488
7489 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7490
7491         * cli/cli-cmds.c (pipe_command): New function.
7492         (_initialize_cli_cmds): Call add_com for pipe_command.
7493         Define | as an alias for pipe.
7494         (exit_status_set_internal_vars): New function.
7495         (shell_escape): Call exit_status_set_internal_vars.
7496         cli/cli-decode.c (find_command_name_length): Recognize | as
7497         a single character command.
7498
7499 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7500
7501         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7502         top.c (execute_command_to_ui_file): New function, mostly a copy
7503         of execute_command_to_string.
7504         (execute_command_to_string): Implement by calling
7505         execute_command_to_ui_file.
7506
7507 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7508
7509         * top.h (saved_command_line): Remove declaration.
7510         * top.c (previous_saved_command_line, previous_repeat_arguments):
7511         New variables.
7512         (saved_command_line): Make static, define together with other
7513         'repeat variables'.
7514         (dont_repeat): Clear repeat_arguments.
7515         (repeat_previous, get_saved_command_line, save_command_line):
7516         New functions.
7517         (gdb_init): Initialize saved_command_line
7518         and previous_saved_command_line.
7519         * main.c (captured_main_1): Remove saved_command_line initialization.
7520         * event-top.c (handle_line_of_input): Update to use
7521         the new 'repeat' related functions instead of direct access to
7522         saved_command_line.
7523         * command.h (repeat_previous, get_saved_command_line,
7524         save_command_line): New declarations.
7525         (dont_repeat): Add comment.
7526
7527 2019-05-30  Tom Tromey  <tromey@adacore.com>
7528
7529         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7530         Fix comment.
7531         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7532
7533 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7534
7535         PR cli/24587
7536         * completer.c (complete): Initialize variable word.
7537
7538 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7539
7540         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7541         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7542         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7543         'body' is NULL to the outter 'if', protecting the '!is_define'
7544         situation as well.
7545
7546 2019-05-29  Tom Tromey  <tromey@adacore.com>
7547
7548         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7549         (dwarf_unknown): New function.
7550         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7551         (dwarf_type_encoding_name): Use dwarf_unknown.
7552
7553 2019-05-29  Tom Tromey  <tromey@adacore.com>
7554
7555         PR c++/20020:
7556         * cp-valprint.c (cp_print_value_fields): Call
7557         cp_print_static_field inside "try".
7558
7559 2019-05-29  Tom Tromey  <tromey@adacore.com>
7560
7561         * inflow.c (struct terminal_info): Add default operator=.
7562         * configure: Rebuild.
7563         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7564         -Wdeprecated-copy-dtor, -Wredundant-move.
7565
7566 2019-05-29  Tom Tromey  <tromey@adacore.com>
7567
7568         * NEWS: Add entry.
7569         * infcmd.c (print_return_value_1): Handle finish_print
7570         option.
7571         (show_print_finish): New function.
7572         (_initialize_infcmd): Add "set/show print finish" commands.
7573         * valprint.c (user_print_options): Initialize new member.
7574         * valprint.h (struct value_print_options) <finish_print>: New
7575         member.
7576
7577 2019-05-28  Tom Tromey  <tromey@adacore.com>
7578
7579         * ada-lang.c (ada_remove_Xbn_suffix)
7580         (find_old_style_renaming_symbol)
7581         (parse_old_style_renaming): Remove.
7582         (ada_find_renaming_symbol): Don't call
7583         find_old_style_renaming_symbol.
7584         (ada_is_renaming_symbol): Rename from
7585         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7586         bool.  Now static.
7587         (ada_read_var_value): Update and simplify.
7588         * ada-exp.y (write_var_or_type): Remove old code.
7589
7590 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7591
7592         PR gdb/25010
7593         * event-top.c: Remove include comment.
7594         * inflow.c (class scoped_ignore_sigttou): Move from here...
7595         * inflow.h (class scoped_ignore_sigttou): ...to here.
7596         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7597         * top.c:  Remove include comment.
7598
7599 2019-05-27  Tom Tromey  <tom@tromey.com>
7600
7601         * NEWS: Fix typo.
7602
7603 2019-05-22  Tom Tromey  <tromey@adacore.com>
7604
7605         * target.c (target_follow_exec): Constify parameter.
7606         * target-delegates.c: Rebuild.
7607         * remote.c (remote_target::follow_exec): Constify parameter.
7608         * infrun.c (follow_exec): Constify parameter.
7609         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7610         (target_follow_exec): Likewise.
7611
7612 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7613
7614         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7615         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7616
7617 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7618
7619         * NEWS: Add debugredirect and testsuite sections.
7620
7621 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7622
7623         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7624         target descriptions using exclusively floating point register name
7625         aliases.
7626
7627 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         PR gdb/18644:
7630         * f-lang.c (build_fortran_types): Handle the case where
7631         gdbarch_floatformat_for_type returns a nullptr.
7632
7633 2019-05-21  Tom de Vries  <tdevries@suse.de>
7634
7635         PR cli/24587
7636         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7637
7638 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7639
7640         PR gdb/18644:
7641         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7642         16-byte floats.
7643         * i386-tdep.c (i386_floatformat_for_type): Use
7644         floatformats_ia64_quad for the 16-byte floating point component
7645         within a fortran 32-byte complex number.
7646
7647 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7650         delete default constructor.
7651         (find_partial_die): Update to return const struct.
7652         (partial_die_parent_scope): Move variable declaration into scope
7653         of its use and change its type to auto.
7654         (guess_partial_die_structure_name): Likewise.
7655         (partial_die_info::fixup): Likewise.
7656
7657 2019-05-17  Tom Tromey  <tromey@adacore.com>
7658
7659         * source.c (find_and_open_source): Remove cast.
7660
7661 2019-05-17  Tom Tromey  <tromey@adacore.com>
7662
7663         * annotate.c (annotate_source): Make "filename" const.
7664         * annotate.h (annotate_source): Use const.
7665
7666 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * disasm.c (set_disassembler_options): Send errors to stderr.
7669
7670 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7671
7672         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7673         (cli_interp_base::set_logging): Check debug_redirect.
7674         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7675         * cli/cli-logging.c (debug_redirect): Add static variable.
7676         (pop_output_files): Add default param.
7677         (handle_redirections): Print debug setting.
7678         (show_logging_command): Likewise.
7679         (_initialize_cli_logging): Add debugredirect command.
7680         * interps.c (current_interp_set_logging): Add debug_redirect
7681         parameter.
7682         * interps.h (set_logging): Add debug_redirect parameter.
7683         (current_interp_set_logging): Likewise.
7684         * mi/mi-common.h: Likewise.
7685         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7686
7687 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7688             Tom Tromey  <tromey@adacore.com>
7689
7690         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7691         directly.
7692         * cli/cli-interp.h (make_logging_output): Remove declaration.
7693         * cli/cli-logging.c (make_logging_output): Remove function.
7694         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7695         directly.
7696         * ui-file.c (tee_file::tee_file): Remove bools.
7697         (tee_file::~tee_file): Remove deletes.
7698         * ui-file.h (tee_file): Remove bools.
7699
7700 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7701
7702         * mi/mi-cmds.h (mi_cmd_complete): New function.
7703         * mi/mi-main.c (mi_cmd_complete): Likewise.
7704         * mi/mi-cmds.c: Define new MI command -complete.
7705         * NEWS: Mention new -complete command.
7706
7707 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7708
7709         * completer.h (complete): New function.
7710         * completer.c (complete): Likewise.
7711         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7712         function defined in completer.h.
7713
7714 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7715
7716         * MAINTAINERS (Write After Approval): Add myself.
7717
7718 2019-05-17  Tom de Vries  <tdevries@suse.de>
7719
7720         PR gdb/24094
7721         * dwarf2read.c (struct cu_partial_die_info): New struct.
7722         (find_partial_die): Return cu_partial_die_info.
7723         (partial_die_parent_scope, guess_partial_die_structure_name)
7724         (partial_die_info::fixup): Handle new return type of find_partial_die.
7725
7726 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7727
7728         PR breakpoints/24541
7729         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7730         "std::string", simplifying the algorithm.
7731
7732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7733
7734         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7735         (stap_static_probe_ops::get_probes): Likewise.
7736
7737 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7738
7739         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7740         '-')" and "else if".
7741         (stap_parse_single_operand): Join checks for
7742         "gdbarch_stap_parse_special_token_p" and
7743         "gdbarch_stap_parse_special_token" in the same "if" statement.
7744         Invert check when verifying for operation on register
7745         displacement.
7746
7747 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7748
7749         * stap-probe.c (stap_get_opcode): Update comment.
7750         (stap_get_expected_argument_type): Likewise.
7751         (handle_stap_probe): Likewise.
7752
7753 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7754
7755         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7756         return type to 'bool'.  Adjust comment.  Use 'bool' when
7757         appropriate.
7758         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7759         * stap-probe.c (stap_parse_argument_1): Likewise.
7760         (stap_is_operator): Likewise.
7761         (stap_is_generic_prefix): Likewise.
7762         (stap_is_register_prefix): Likewise.
7763         (stap_is_register_indirection_prefix): Likewise.
7764         (stap_is_integer_prefix): Likewise.
7765         (stap_generic_check_suffix): Likewise.
7766         (stap_check_integer_suffix): Likewise.
7767         (stap_check_register_suffix): Likewise.
7768         (stap_check_register_indirection_suffix): Likewise.
7769         (stap_parse_register_operand): Likewise.
7770         (stap_parse_single_operand): Likewise.
7771         (stap_parse_argument_1): Likewise.
7772         (stap_probe::get_argument_count): Likewise.
7773         (stap_is_operator): Likewise.
7774
7775 2019-05-16  Tom Tromey  <tromey@adacore.com>
7776
7777         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7778         keyword to foreach.
7779
7780 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7781
7782         * linux-thread-db.c (try_thread_db_load_1): Change return type
7783         to bool.
7784         (try_thread_db_load): Likewise.
7785         (try_thread_db_load_from_pdir_1): Likewise.
7786         (try_thread_db_load_from_pdir): Likewise.
7787         (try_thread_db_load_from_sdir): Likewise.
7788         (try_thread_db_load_from_dir): Likewise.
7789         (thread_db_load_search): Likewise.
7790         (has_libpthread): Likewise.
7791         (thread_db_load): Likewise.
7792
7793 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7794
7795         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7796         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7797         NULL, and complain/return if that's the case.
7798
7799 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7800
7801         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7802         (advance, posn, abstract_read_memory): New functions.
7803         [struct mem_read_abstraction]: New struct.
7804         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7805
7806 2019-05-14  Tom Tromey  <tromey@adacore.com>
7807
7808         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7809         value is not lval_memory.
7810
7811 2019-05-14  Tom Tromey  <tromey@adacore.com>
7812
7813         * solib.c (info_sharedlibrary_command): Style the file name.
7814
7815 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7816
7817         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7818         (aarch64_vnv_type): Likewise.
7819         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7820         * common/tdesc.c: Likewise.
7821         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7822         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7823         * features/aarch64-fpu.xml: Add ieee half view.
7824         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7825         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7826         * gdbtypes.h (struct builtin_type): Likewise.
7827         (struct objfile_type): Likewise.
7828
7829 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7830
7831         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7832         typo.
7833         * location.h (string_to_event_location): Likewise.
7834
7835 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7836
7837         GDB 8.3 released.
7838
7839 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7840
7841         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7842         New variable declaration.
7843         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7844         New variable.
7845         (print_one_breakpoint): Use ui_out::test_flags and new global
7846         variable to compute use_fixed_output.
7847         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7848         Remove.
7849         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7850         (mi_multi_location_breakpoint_output_fixed): Remove.
7851         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7852         new variable.
7853         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7854         fix_multi_location_breakpoint_output flag if version >= 3.
7855         * ui-out.h (enum ui_out_flag)
7856         <fix_multi_location_breakpoint_output>: New enumerator.
7857
7858 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7859
7860         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7861
7862 2019-05-10  Tom Tromey  <tromey@adacore.com>
7863
7864         * ada-lang.c (catch_ada_completer): New function.
7865         (_initialize_ada_language): Use it.
7866
7867 2019-05-10  Tom Tromey  <tromey@adacore.com>
7868
7869         * thread.c (print_thread_info): Make "requested_threads" const.
7870         * gdbthread.h (print_thread_info): Make "requested_threads"
7871         const.
7872         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7873         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7874
7875 2019-05-08  Tom Tromey  <tom@tromey.com>
7876
7877         * gdbtypes.c (objfile_type_data): Change type.
7878         (objfile_type, _initialize_gdbtypes): Update.
7879
7880 2019-05-08  Tom Tromey  <tom@tromey.com>
7881
7882         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7883         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7884         (_initialize_dwarf2_frame): Update.
7885
7886 2019-05-08  Tom Tromey  <tom@tromey.com>
7887
7888         * objc-lang.c (objc_objfile_data): Change type.
7889         (find_methods): Update.
7890         (_initialize_objc_lang): Remove.
7891
7892 2019-05-08  Tom Tromey  <tom@tromey.com>
7893
7894         * stabsread.c (rs6000_builtin_type_data): Change type.
7895         (rs6000_builtin_type, _initialize_stabsread): Update.
7896
7897 2019-05-08  Tom Tromey  <tom@tromey.com>
7898
7899         * mips-tdep.c (mips_pdr_data): Remove.
7900         (_initialize_mips_tdep): Update.
7901
7902 2019-05-08  Tom Tromey  <tom@tromey.com>
7903
7904         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7905         (hppa_init_objfile_priv_data, read_unwind_info)
7906         (find_unwind_entry, _initialize_hppa_tdep): Update.
7907
7908 2019-05-08  Tom Tromey  <tom@tromey.com>
7909
7910         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7911         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7912         on obstack.
7913         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7914
7915 2019-05-08  Tom Tromey  <tom@tromey.com>
7916
7917         * mdebugread.c (basic_type_data): Change type.
7918         (basic_type, _initialize_mdebugread): Update.
7919
7920 2019-05-08  Tom Tromey  <tom@tromey.com>
7921
7922         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7923
7924 2019-05-08  Tom Tromey  <tom@tromey.com>
7925
7926         * nto-tdep.c (nto_inferior_data_reg): Change type.
7927         (nto_inferior_data): Update.
7928         (nto_inferior_data_cleanup, nto_new_inferior_data)
7929         (_initialize_nto_tdep): Remove.
7930         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7931
7932 2019-05-08  Tom Tromey  <tom@tromey.com>
7933
7934         * ada-lang.c (struct ada_inferior_data): Add initializers.
7935         (ada_inferior_data): Change type.
7936         (ada_inferior_data_cleanup): Remove.
7937         (get_ada_inferior_data, ada_inferior_exit)
7938         (struct ada_pspace_data): Add initializers, destructor.
7939         (ada_pspace_data_handle): Change type.
7940         (get_ada_pspace_data): Update.
7941         (ada_pspace_data_cleanup): Remove.
7942
7943 2019-05-08  Tom Tromey  <tom@tromey.com>
7944
7945         * coffread.c (struct coff_symfile_info): Add initializers.
7946         (coff_objfile_data_key): Move lower.  Change type.
7947         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7948         Update.
7949         (coff_free_info): Remove.
7950
7951 2019-05-08  Tom Tromey  <tom@tromey.com>
7952
7953         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7954         (fbsd_pspace_data_handle): Move lower.  Change type.
7955         (get_fbsd_pspace_data): Update.
7956         (fbsd_pspace_data_cleanup): Remove.
7957         (_initialize_fbsd_tdep): Update.
7958
7959 2019-05-08  Tom Tromey  <tom@tromey.com>
7960
7961         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7962         (get_ada_tasks_pspace_data): Update.
7963         (ada_tasks_pspace_data_cleanup): Remove.
7964         (_initialize_tasks): Update.
7965         (ada_tasks_inferior_data_handle): Change type.
7966         (get_ada_tasks_inferior_data): Update.
7967         (ada_tasks_inferior_data_cleanup): Remove.
7968         (struct ada_tasks_pspace_data): Add initializers.
7969
7970 2019-05-08  Tom Tromey  <tom@tromey.com>
7971
7972         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7973         * symfile-debug.c (debug_sym_get_probes): Change type.
7974         * stap-probe.c (handle_stap_probe):
7975         (stap_static_probe_ops::get_probes): Change type.
7976         * probe.h (class static_probe_ops) <get_probes>: Change type.
7977         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7978         (parse_probes_in_pspace): Update.
7979         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7980         Update.
7981         (any_static_probe_ops::get_probes): Change type.
7982         * elfread.c (elfread_data): New typedef.
7983         (probe_key): Change type.
7984         (elf_get_probes): Likewise.  Update.
7985         (probe_key_free): Remove.
7986         (_initialize_elfread): Update.
7987         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7988         Change type.
7989         (dtrace_process_dof_probe, dtrace_process_dof)
7990         (dtrace_static_probe_ops::get_probe): Change type.
7991
7992 2019-05-08  Tom Tromey  <tom@tromey.com>
7993
7994         * xcoffread.c (struct xcoff_symfile_info): Rename from
7995         coff_symfile_info.  Add initializers.
7996         (xcoff_objfile_data_key): Move lower.  Change type.
7997         (XCOFF_DATA): Rewrite.
7998         (xcoff_free_info): Remove.
7999         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8000         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8001         (xcoff_initial_scan): Update.
8002
8003 2019-05-08  Tom Tromey  <tom@tromey.com>
8004
8005         * solib-svr4.c (struct svr4_info): Add initializers and
8006         destructor.
8007         <probes_table>: Now an htab_up.
8008         (solib_svr4_pspace_data): Change type.
8009         (free_probes_table): Simplify.
8010         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8011         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8012         (probes_table_remove_objfile_probes, register_solib_event_probe)
8013         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8014         (_initialize_svr4_solib): Update.
8015
8016 2019-05-08  Tom Tromey  <tom@tromey.com>
8017
8018         * remote.c (remote_pspace_data): Change type.
8019         (remote_pspace_data_cleanup): Remove.
8020         (get_remote_exec_file, set_pspace_remote_exec_file)
8021         (_initialize_remote): Update.
8022
8023 2019-05-08  Tom Tromey  <tom@tromey.com>
8024
8025         * breakpoint.c (breakpoint_objfile_key): Change type.
8026         (get_breakpoint_objfile_data): Update.
8027         (free_breakpoint_objfile_data): Remove.
8028         (_initialize_breakpoint): Update.
8029
8030 2019-05-08  Tom Tromey  <tom@tromey.com>
8031
8032         * linux-tdep.c (struct linux_info): Add initializers.
8033         (linux_inferior_data): Move.  Change type.
8034         (invalidate_linux_cache_inf): Update.
8035         (linux_inferior_data_cleanup): Remove.
8036         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8037
8038 2019-05-08  Tom Tromey  <tom@tromey.com>
8039
8040         * auxv.c (auxv_inferior_data): Move.  Change type.
8041         (auxv_inferior_data_cleanup): Remove.
8042         (invalidate_auxv_cache_inf): Rewrite.
8043         (get_auxv_inferior_data, _initialize_auxv): Update.
8044
8045 2019-05-08  Tom Tromey  <tom@tromey.com>
8046
8047         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8048         (symfile_debug_objfile_data_key): Change type.
8049         (symfile_debug_installed, debug_qf_has_symbols)
8050         (debug_qf_find_last_source_symtab)
8051         (debug_qf_forget_cached_source_info)
8052         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8053         (debug_qf_print_stats, debug_qf_dump)
8054         (debug_qf_expand_symtabs_for_function)
8055         (debug_qf_expand_all_symtabs)
8056         (debug_qf_expand_symtabs_with_fullname)
8057         (debug_qf_map_matching_symbols)
8058         (debug_qf_expand_symtabs_matching)
8059         (debug_qf_find_pc_sect_compunit_symtab)
8060         (debug_qf_map_symbol_filenames)
8061         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8062         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8063         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8064         (debug_sym_read_linetable, debug_sym_relocate): Update.
8065         (symfile_debug_free_objfile): Remove.
8066         (install_symfile_debug_logging, _initialize_symfile_debug):
8067         Update.
8068
8069 2019-05-08  Tom Tromey  <tom@tromey.com>
8070
8071         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8072         allocate_on_obstack.
8073         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8074         (get_dwarf2_per_objfile): Update.
8075         (set_dwarf2_per_objfile): Remove.
8076         (dwarf2_has_info, dwarf2_get_section_info): Update.
8077         (dwarf2_free_objfile): Remove.
8078         (_initialize_dwarf2_read): Update.
8079
8080 2019-05-08  Tom Tromey  <tom@tromey.com>
8081
8082         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8083         initializers.
8084         <unsupported_script_warning_printed,
8085         script_not_found_warning_printed>: Now bool.
8086         (auto_load_pspace_data): Change type.
8087         (~auto_load_pspace_info): Rename from
8088         auto_load_pspace_data_cleanup.
8089         (get_auto_load_pspace_data, init_loaded_scripts_info)
8090         (clear_section_scripts, maybe_print_unsupported_script_warning)
8091         (maybe_print_script_not_found_warning, _initialize_auto_load):
8092         Update.
8093
8094 2019-05-08  Tom Tromey  <tom@tromey.com>
8095
8096         * objfiles.c (objfile_pspace_info): Add destructor and
8097         initializers.
8098         (objfiles_pspace_data): Change type.
8099         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8100         (get_objfile_pspace_data): Update.
8101         (objfiles_bfd_data): Change type.
8102         (get_objfile_bfd_data): Update.
8103         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8108         Change type.
8109         (get_catch_syscall_inferior_data): Update.
8110         (catch_syscall_inferior_data_cleanup): Remove.
8111         (_initialize_break_catch_syscall): Update.
8112
8113 2019-05-08  Tom Tromey  <tom@tromey.com>
8114
8115         * inflow.c (struct terminal_info): Add destructor and
8116         initializers.
8117         (inflow_inferior_data): Change type.
8118         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8119         (get_inflow_inferior_data, inflow_inferior_exit)
8120         (swap_terminal_info, _initialize_inflow): Update.
8121
8122 2019-05-08  Tom Tromey  <tom@tromey.com>
8123
8124         * target-dcache.c (target_dcache_cleanup): Remove.
8125         (target_dcache_aspace_key): Change type.
8126         (target_dcache_init_p, target_dcache_invalidate)
8127         (target_dcache_get, target_dcache_get_or_init)
8128         (_initialize_target_dcache): Update.
8129         * dcache.h (struct dcache_deleter): New.
8130
8131 2019-05-08  Tom Tromey  <tom@tromey.com>
8132
8133         * symtab.c (struct symbol_cache): Add destructor and
8134         initializers.
8135         (symbol_cache_key): Move.  Change type.
8136         (make_symbol_cache, free_symbol_cache): Remove.
8137         (get_symbol_cache): Update.
8138         (symbol_cache_cleanup): Remove.
8139         (ALL_PSPACES, symbol_cache_flush)
8140         (maintenance_print_symbol_cache)
8141         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8142         Update.
8143
8144 2019-05-08  Tom Tromey  <tom@tromey.com>
8145
8146         * symtab.c (struct main_info): Add destructor and initializers.
8147         (main_progspace_key): Move.  Change type.
8148         (get_main_info): Update.
8149         (main_info_cleanup): Remove.
8150         (_initialize_symtab): Update.
8151
8152 2019-05-08  Tom Tromey  <tom@tromey.com>
8153
8154         * registry.h (DECLARE_REGISTRY): Define the _key class.
8155
8156 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * NEWS: Merge two 'New commands' sections.
8159
8160 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8161
8162         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8163         parameter and use Ada language definition instead.
8164         (ada_val_print_ptr): Remove unused language parameter.
8165         (ada_val_print_num): Remove language parameter and use Ada language
8166         definition instead.
8167         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8168         parameter.
8169         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8170         parameter and use Ada language definition instead.
8171         (ada_val_print_1): Update all ada_val_print_xxx calls.
8172         Remove language parameter.
8173         (ada_val_print): Update ada_val_print_1 call.
8174
8175 2019-05-08  Tom Tromey  <tromey@adacore.com>
8176
8177         * remote.c (remote_hw_watchpoint_limit)
8178         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8179         Now static.
8180
8181 2019-05-08  Tom Tromey  <tromey@adacore.com>
8182
8183         * maint.c (_initialize_maint_cmds): Move initialization code to
8184         remote.c.
8185         (watchdog, show_watchdog): Move to remote.c.
8186         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8187         "watchdog" static.
8188         (_initialize_remote): Move initialization code from maint.c.
8189         * defs.h (watchdog): Don't declare.
8190
8191 2019-05-08  Tom Tromey  <tromey@adacore.com>
8192
8193         * tui/tui-interp.c: Include main.h.
8194         * interps.c: Include main.h.
8195         * main.h (interpreter_p): Declare.
8196         * defs.h (interpreter_p): Don't declare.
8197
8198 2019-05-08  Tom Tromey  <tromey@adacore.com>
8199
8200         * dwarf2loc.c: Include dwarf2read.h.
8201         * defs.h (read_unsigned_leb128): Don't declare.
8202         * dwarf2read.h (read_unsigned_leb128): Declare.
8203
8204 2019-05-08  Tom Tromey  <tromey@adacore.com>
8205
8206         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8207         method.
8208
8209 2019-05-08  Tom Tromey  <tromey@adacore.com>
8210
8211         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8212         when no wrap column is set.
8213
8214 2019-05-08  Tom Tromey  <tromey@adacore.com>
8215
8216         * c-lang.c (c_get_string): Handle non-C-style arrays.
8217
8218 2019-05-08  Tom Tromey  <tromey@adacore.com>
8219
8220         * typeprint.c (print_offset_data::update): Print the bit offset,
8221         not the number of bits remaining.
8222
8223 2019-05-08  Tom Tromey  <tromey@adacore.com>
8224
8225         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8226         padding at end of comment.
8227
8228 2019-05-08  Tom Tromey  <tromey@adacore.com>
8229
8230         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8231         Compare main types.
8232
8233 2019-05-06  Tom Tromey  <tom@tromey.com>
8234
8235         * common/scoped_mmap.c: Include common-defs.h.
8236         * common/scoped_mmap.h: Don't include config.h.
8237
8238 2019-05-04  Tom Tromey  <tom@tromey.com>
8239
8240         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8241         (struct aarch64_call_info): Add initializers.
8242         <si>: Now a std::vector.
8243         (pass_on_stack, aarch64_push_dummy_call): Update.
8244
8245 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8246             Tom Tromey  <tom@tromey.com>
8247
8248         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8249         (ppc_threads): Now a std::vector.  Now static.
8250         (hwdebug_find_thread_points_by_tid)
8251         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8252         Update.
8253
8254 2019-05-04  Tom Tromey  <tom@tromey.com>
8255
8256         * arc-tdep.c (arc_tdesc_init): Return bool.
8257
8258 2019-05-04  Tom Tromey  <tom@tromey.com>
8259
8260         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8261         Use gdb_assert_not_reached.
8262
8263 2019-05-04  Tom Tromey  <tom@tromey.com>
8264
8265         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8266         "false".
8267
8268 2019-05-04  Tom Tromey  <tom@tromey.com>
8269
8270         * arc-tdep.c (arc_tdesc_init): Use bool.
8271
8272 2019-05-04  Tom Tromey  <tom@tromey.com>
8273
8274         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8275
8276 2019-05-04  Tom Tromey  <tom@tromey.com>
8277
8278         * cli/cli-cmds.c (valid_command_p): Return bool.
8279
8280 2019-05-04  Tom Tromey  <tom@tromey.com>
8281
8282         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8283         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8284
8285 2019-05-04  Raul Tambre  <raul@tambre.ee>
8286
8287         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8288         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8289         operator for comparison.
8290
8291 2019-05-04  Tom Tromey  <tom@tromey.com>
8292
8293         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8294         (lookup_partial_symbol, print_partial_symbols)
8295         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8296         (psymbol_compare): Update.
8297         (add_psymbol_to_bcache): Clear the entire psymbol.
8298         (maintenance_check_psymtabs): Update.
8299         * psympriv.h (struct partial_symbol): Don't derive from
8300         general_symbol_info.
8301         <obj_section, unrelocated_address, address,
8302         set_unrelocated_address>: Update.
8303         <ginfo>: New member.
8304         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8305         (debug_names::write_psymbols): Update.
8306
8307 2019-05-04  Tom de Vries  <tdevries@suse.de>
8308
8309         * contrib/cc-with-tweaks.sh: Support -n arg.
8310
8311 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8312
8313         * corelow.c (core_target::detach): Ensure frame cache and
8314         register caches are cleared.
8315         inferior.c (exit_inferior_1): Likewise.
8316
8317 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8318             Tom Tromey  <tom@tromey.com>
8319
8320         * dictionary.c (collate_pending_symbols_by_language): Remove
8321         "struct" from foreach.
8322         * symtab.c (lookup_global_symbol_from_objfile)
8323         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8324         foreach.
8325         * ser-tcp.c (net_open): Remove "struct" from foreach.
8326         * objfiles.c (objfile_relocate, objfile_rebase)
8327         (objfile_has_symbols): Remove "struct" from foreach.
8328         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8329         from foreach.
8330         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8331         foreach.
8332         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8333         "struct" from foreach.
8334         * ada-lang.c (create_excep_cond_exprs)
8335         (ada_exception_catchpoint_cond_string): Remove "struct" from
8336         foreach.
8337
8338 2019-05-03  Tom Tromey  <tromey@adacore.com>
8339
8340         * ada-exp.y (convert_char_literal): Check suffix of each
8341         enumerator.
8342
8343 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8344
8345         PR ada/21406:
8346         * ada-exp.y (yywrap): Don't define.
8347         * ada-lex.l (%option): Add noyywrap
8348         (yywrap): Remove.
8349
8350 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8351
8352         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8353         _WIN32_WINNT to the XP level, unless already defined to a higher
8354         level.
8355
8356         * unittests/parse-connection-spec-selftests.c:
8357         * ser-tcp.c:
8358         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8359         override.
8360
8361         * symfile.c (find_separate_debug_file): Remove colon from the
8362         drive spec of DOS/Windows file names of the target, so that the
8363         file name produced from DEBUGDIR and the target's directory will
8364         be valid on DOS/Windows systems.
8365
8366 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8367
8368         * rust-lang.c (val_print_struct): Handle printing structures
8369         containing strings.
8370
8371 2019-05-02  Tom Tromey  <tromey@adacore.com>
8372
8373         * valarith.c (_initialize_valarith): Remove.
8374
8375 2019-05-01  Tom Tromey  <tromey@adacore.com>
8376
8377         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8378         bitfields.
8379
8380 2019-05-01  Tom Tromey  <tromey@adacore.com>
8381
8382         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8383         for big-endian copies.
8384
8385 2019-04-30  Ali Tamur  <tamur@google.com>
8386         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8387         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8388         (read_3_bytes): New function.
8389
8390 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8391
8392         * windows-nat.c (main_thread_id): Delete.
8393         (handle_output_debug_string): Replace main_thread_id by
8394         current_event.dwThreadId.
8395         (fake_create_process): Likewise.
8396         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8397         Do not set main_thread_id.
8398         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8399         current_event.dwThreadId.
8400         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8401
8402 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8403
8404         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8405         Use current_event.dwThreadId instead of main_thread_id.
8406
8407 2019-04-30  Tom Tromey  <tromey@adacore.com>
8408
8409         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8410         (create_excep_cond_exprs): Iterate over program spaces.
8411         (ada_exception_catchpoint_cond_string): Examine all minimal
8412         symbols for exception types.
8413
8414 2019-04-30  Tom Tromey  <tromey@adacore.com>
8415
8416         PR c++/24470:
8417         * dwarf2read.c (process_structure_scope): Handle case where type
8418         has template parameters but no symbol was created.
8419
8420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8421             Chris January  <chris.january@arm.com>
8422
8423         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8424         qualifier.
8425         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8426
8427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8428
8429         * f-typeprint.c (f_print_type): Update rules for printing
8430         whitespace.
8431         (f_type_print_varspec_suffix): Likewise.
8432
8433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8434             Chris January  <chris.january@arm.com>
8435
8436         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8437         function arguments.
8438
8439 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8440
8441         * f-lang.c (build_fortran_types): Change name of void type to
8442         lower case.
8443         * f-typeprint.c (f_type_print_base): Print the name of the void
8444         type, rather than a fixed string.
8445         * f-valprint.c (f_decorations): Use lower case void string.
8446
8447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8448             Chris January  <chris.january@arm.com>
8449
8450         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8451         types for Fortran.
8452
8453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8454             Chris January  <chris.january@arm.com>
8455             David Lecomber  <david.lecomber@arm.com>
8456
8457         * f-exp.y (BINOP_INTRINSIC): New token.
8458         (exp): New parser rule handling BINOP_INTRINSIC.
8459         (f77_keywords): Add new builtin procedures.
8460         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8461         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8462         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8463         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8464         (print_unop_subexp_f): New function.
8465         (print_binop_subexp_f): New function.
8466         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8467         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8468         (dump_subexp_body_f): Likewise.
8469         (operator_check_f): Likewise.
8470         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8471         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8472
8473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8474
8475         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8476         UNOP_KIND.
8477         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8478         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8479         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8480         (operator_length_f): New fuction.
8481         (print_subexp_f): New function.
8482         (op_name_f): New function.
8483         (dump_subexp_body_f): New function.
8484         (operator_check_f): New function.
8485         (exp_descriptor_f): Replace standard expression handling functions
8486         with new functions.
8487         * gdb/fortran-operator.def: New file.
8488         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8489         * gdb/std-operator.def: Remove UNOP_KIND.
8490
8491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8492
8493         * std-operator.def: Remove unbalanced, stray double quote
8494         character.
8495
8496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8497             Chris January  <chris.january@arm.com>
8498             Daniel Everett  <daniel.everett@arm.com>
8499             Nick Forrington  <nick.forrington@arm.com>
8500             Richard Bunt  <richard.bunt@arm.com>
8501
8502         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8503         of depth when printing anonymous structs or unions.
8504         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8505         Don't print either the top-level value, or the children if the
8506         max-depth is exceeded.
8507         (ppscm_print_children): When printing the key of a map, allow one
8508         extra level of depth.
8509         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8510         print either the top-level value, or the children if the max-depth
8511         is exceeded.
8512         (print_children): When printing the key of a map, allow one extra
8513         level of depth.
8514         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8515         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8516         (user_print_options): Initialise max_depth field.
8517         (val_print_scalar_or_string_type_p): New function.
8518         (val_print): Check to see if the max depth has been reached.
8519         (val_print_check_max_depth): Define new function.
8520         (show_print_max_depth): New function.
8521         (_initialize_valprint): Add 'print max-depth' option.
8522         * valprint.h (struct value_print_options) <max_depth>: New field.
8523         (val_print_check_max_depth): Declare new function.
8524         * NEWS: Document new feature.
8525
8526 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8527
8528         * ada-lang.c (ada_language_defn): Initialise new field.
8529         * c-lang.c (c_is_string_type_p): New function.
8530         (c_language_defn): Initialise new field.
8531         (cplus_language_defn): Initialise new field.
8532         (asm_language_defn): Initialise new field.
8533         (minimal_language_defn): Initialise new field.
8534         * c-lang.h (c_is_string_type_p): Declare new function.
8535         * d-lang.c (d_language_defn): Initialise new field.
8536         * f-lang.c (f_is_string_type_p): New function.
8537         (f_language_defn): Initialise new field.
8538         * go-lang.c (go_is_string_type_p): New function.
8539         (go_language_defn): Initialise new field.
8540         * language.c (default_is_string_type_p): New function.
8541         (unknown_language_defn): Initialise new field.
8542         (auto_language_defn): Initialise new field.
8543         * language.h (struct language_defn) <la_is_string_type_p>: New
8544         member variable.
8545         (default_is_string_type_p): Declare new function.
8546         * m2-lang.c (m2_language_defn): Initialise new field.
8547         * objc-lang.c (objc_language_defn): Initialise new field.
8548         * opencl-lang.c (opencl_language_defn): Initialise new field.
8549         * p-lang.c (pascal_is_string_type_p): New function.
8550         (pascal_language_defn): Initialise new field.
8551         * rust-lang.c (rust_is_string_type_p): New function.
8552         (rust_language_defn): Initialise new field.
8553
8554 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8555
8556         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8557         New field.
8558         * ada-lang.c (ada_language_defn): Initialise new field.
8559         * c-lang.c (c_language_defn): Likewise.
8560         (cplus_language_defn): Likewise.
8561         (asm_language_defn): Likewise.
8562         (minimal_language_defn): Likewise.
8563         * d-lang.c (d_language_defn): Likewise.
8564         * f-lang.c (f_language_defn): Likewise.
8565         * go-lang.c (go_language_defn): Likewise.
8566         * language.c (unknown_language_defn): Likewise.
8567         (auto_language_defn): Likewise.
8568         * m2-lang.c (m2_language_defn): Likewise.
8569         * objc-lang.c (objc_language_defn): Likewise.
8570         * opencl-lang.c (opencl_language_defn): Likewise.
8571         * p-lang.c (pascal_language_defn): Likewise.
8572         * rust-lang.c (rust_language_defn): Likewise.
8573
8574 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * ada-lang.c (ada_is_character_type): Change return type to bool.
8577         (ada_is_string_type): Likewise.
8578         * ada-lang.h (ada_is_character_type): Update declaration
8579         (ada_is_string_type): Likewise.
8580
8581 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8582
8583         Support style in 'frame|thread apply'
8584
8585         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8586         * record.c (record_start, record_stop): Update callers of
8587         execute_command_to_string with false.
8588         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8589         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8590         methods.
8591         (class string_file): New constructor with term_out parameter.
8592         Override methods term_out and can_emit_style_escape.  New member
8593         term_out.
8594         (class stdio_file): Override can_emit_style_escape.
8595         (class tee_file): Override term_out and can_emit_style_escape.
8596         * utils.h (can_emit_style_escape): Remove.
8597         * utils.c (can_emit_style_escape): Likewise.
8598         Update all callers of can_emit_style_escape (SOMESTREAM) to
8599         SOMESTREAM->can_emit_style_escape.
8600         * source-cache.c (source_cache::get_source_lines): Likewise.
8601         * stack.c (frame_apply_command_count): Call execute_command_to_string
8602         passing the term_out characteristic of the current gdb_stdout.
8603         * thread.c (thr_try_catch_cmd): Likewise.
8604         * top.c (execute_command_to_string): pass term_out parameter
8605         to construct the string_file for the command output.
8606         * ui-file.c (term_cli_styling): New function (most code moved
8607         from utils.c can_emit_style_escape).
8608         (string_file::string_file, string_file::can_emit_style_escape,
8609         stdio_file::can_emit_style_escape, tee_file::term_out,
8610         tee_file::can_emit_style_escape): New functions.
8611
8612 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8613
8614         * NEWS: Mention the new set|show may-call-functions.
8615         * infcall.c (may_call_functions_p): New variable.
8616         (show_may_call_functions_p): New function.
8617         (call_function_by_hand_dummy): Throws an error if not
8618         may-call-functions.
8619         (_initialize_infcall): Call add_setshow_boolean_cmd for
8620         may-call-functions.
8621
8622 2019-04-25  Keith Seitz  <keiths@redhat.com>
8623
8624         PR c++/24367
8625         * cp-support.c (inspect_type): Don't attempt substitutions
8626         of symbol with the same name.
8627
8628 2019-04-25  Tom Tromey  <tromey@adacore.com>
8629
8630         PR gdb/24475:
8631         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8632         static.
8633
8634 2019-04-25  Tom Tromey  <tromey@adacore.com>
8635
8636         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8637         rvalue reference.
8638         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8639         (gdb_xml_parser::parse): Use std::move.
8640         * python/python-internal.h (gdbpy_convert_exception): Take a const
8641         reference.
8642         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8643         std::move.
8644         * python/py-utils.c (gdbpy_convert_exception): Take a const
8645         reference.
8646         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8647         Use std::move.
8648         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8649         Use std::move.
8650         * mi/mi-main.c (mi_print_exception): Take a const reference.
8651         * main.c (handle_command_errors): Take a const reference.
8652         * linespec.c (parse_linespec): Use std::move.
8653         * infcall.c (run_inferior_call): Use std::move.
8654         (call_function_by_hand_dummy): Use std::move.
8655         * exec.c (try_open_exec_file): Use std::move.
8656         * exceptions.h (exception_print, exception_fprintf)
8657         (exception_print_same): Update.
8658         * exceptions.c (print_exception, exception_print)
8659         (exception_fprintf, exception_print_same): Change parameters to
8660         const reference.
8661         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8662         * common/new-op.c: Use std::move.
8663         * common/common-exceptions.h (struct gdb_exception): Add move
8664         constructor.
8665         (struct gdb_exception_error, struct gdb_exception_quit, struct
8666         gdb_quit_bad_alloc): Change constructor to move constructor.
8667         (throw_exception): Change parameter to rvalue reference.
8668         * common/common-exceptions.c (throw_exception): Take rvalue
8669         reference.
8670         * cli/cli-interp.c (safe_execute_command): Use std::move.
8671         * breakpoint.c (insert_bp_location, location_to_sals): Use
8672         std::move.
8673
8674 2019-04-25  Tom Tromey  <tromey@adacore.com>
8675
8676         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8677         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8678         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8679         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8680         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8681         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8682         guile/scm-value.c: Use unpack.
8683         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8684         gdbscm_gdb_exception.
8685         (gdbscm_throw_gdb_exception): Likewise.
8686         (struct gdbscm_gdb_exception): New.
8687         (unpack): New function.
8688         (gdbscm_wrap): Use unpack.
8689
8690 2019-04-25  Tom Tromey  <tromey@adacore.com>
8691
8692         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8693         (gdb_rl_callback_handler): Use std::move.
8694         * common/common-exceptions.h (struct gdb_exception): Add move
8695         assignment operator.
8696         (throw_exception_sjlj): Change "exception" to const reference.
8697         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8698         (throw_exception_sjlj): Change "exception" to const reference.
8699
8700 2019-04-25  Tom Tromey  <tromey@adacore.com>
8701
8702         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8703         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8704         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8705         Update.
8706         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8707         Update.
8708         * mi/mi-interp.c (mi_interp::exec): Update.
8709         * linespec.c (parse_linespec): Update.
8710         * infcall.c (run_inferior_call): Update.
8711         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8712         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8713         (gdbscm_lookup_global_symbol): Update.
8714         * guile/scm-param.c (gdbscm_parameter_value): Update.
8715         * guile/scm-frame.c (gdbscm_frame_read_register)
8716         (gdbscm_frame_read_var): Update.
8717         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8718         * exec.c (try_open_exec_file): Update.
8719         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8720         (gdb_rl_callback_handler): Update.
8721         * common/common-exceptions.h (exception_none): Don't declare.
8722         * common/common-exceptions.c (exception_none): Don't define.
8723         (struct catcher) <exception>: Update.
8724         * cli/cli-interp.c (safe_execute_command): Update.
8725         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8726
8727 2019-04-25  Ali Tamur  <tamur@google.com>
8728
8729         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8730         (read_attribute_value): Likewise.
8731         (dwarf2_read_addr_index): Update comment.
8732         (read_str_index): Add DW_FORM_strx.
8733         (dwarf2_string_attr): Likewise.
8734         (dwarf2_const_value_attr): Likewise.
8735         (dump_die_shallow): Likewise.
8736         (dwarf2_fetch_constant_bytes): Likewise.
8737         (skip_form_bytes): Likewise.
8738         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8739
8740 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8741
8742         PR corefiles/11608
8743         PR corefiles/18187
8744         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8745         OFFSET.  Verify if current mapping contains an ELF header.
8746         (linux_find_memory_regions_full): Adjust call to
8747         dump_mapping_p.
8748
8749 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8750             Kang Li <kanglictf@gmail.com>
8751
8752         PR gdb/21600
8753
8754         * dwarf2-frame.c (read_initial_length): Be consistent about using
8755         unsigned representation of length.
8756         (decode_frame_entry_1): Likewise.  Check for wraparound of
8757         end pointer as well as buffer overflow.
8758
8759 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8760
8761         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8762         "vq".
8763
8764 2019-04-24  Tom Tromey  <tromey@adacore.com>
8765
8766         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8767
8768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8769
8770         * s12z-tdep.c (s12z_unwind_pc): Delete.
8771         (s12z_unwind_sp): Delete.
8772         (s12z_gdbarch_init): Don't register deleted functions with
8773         gdbarch.
8774
8775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * rl78-tdep.c (rl78_unwind_sp): Delete.
8778         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8779
8780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8783         (xstormy16_unwind_pc): Delete.
8784         (xstormy16_dummy_id): Delete.
8785         (xstormy16_gdbarch_init): Don't register deleted functions with
8786         gdbarch.
8787
8788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * vax-tdep.c (vax_unwind_pc): Delete.
8791         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8792
8793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8794
8795         * v850-tdep.c (v850_unwind_sp): Delete.
8796         (v850_unwind_pc): Delete.
8797         (v850_dummy_id): Delete.
8798         (v850_gdbarch_init): Don't register deleted functions with
8799         gdbarch.
8800
8801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8802
8803         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8804         (tilegx_unwind_pc): Delete.
8805         (tilegx_unwind_dummy_id): Delete.
8806         (tilegx_gdbarch_init): Don't register deleted functions with
8807         gdbarch.
8808
8809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8810
8811         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8812         (tic6x_dummy_id): Delete.
8813         (tic6x_gdbarch_init): Don't register deleted functions with
8814         gdbarch.
8815
8816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8817
8818         * sparc-tdep.c (sparc_unwind_pc): Delete.
8819         (sparc32_gdbarch_init): Don't register deleted function with
8820         gdbarch.
8821
8822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * sh-tdep.c (sh_unwind_sp): Delete.
8825         (sh_unwind_pc): Delete.
8826         (sh_dummy_id): Delete.
8827         (sh_gdbarch_init): Don't register deleted functions with
8828         gdbarch.
8829
8830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * score-tdep.c (score_unwind_sp): Delete.
8833         (score_unwind_pc): Delete.
8834         (score_dummy_id): Delete.
8835         (score_gdbarch_init): Don't register deleted functions with
8836         gdbarch.
8837
8838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * rx-tdep.c (rx_unwind_pc): Delete.
8841         (rx_unwind_sp): Delete.
8842         (rx_dummy_id): Delete.
8843         (rx_gdbarch_init): Don't register deleted functions with
8844         gdbarch.  Update comment.
8845
8846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8849         (rs6000_dummy_id): Delete.
8850         (rs6000_gdbarch_init): Don't register deleted functions with
8851         gdbarch.
8852
8853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * or1k-tdep.c (or1k_dummy_id): Delete.
8856         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8857
8858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * nios2-tdep.c (nios2_dummy_id): Delete.
8861         (nios2_unwind_sp): Delete.
8862         (nios2_gdbarch_init): Don't register deleted functions with
8863         gdbarch.
8864
8865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * nds32-tdep.c (nds32_dummy_id): Delete.
8868         (nds32_unwind_pc): Delete.
8869         (nds32_unwind_sp): Delete.
8870         (nds32_gdbarch_init): Don't register deleted functions with
8871         gdbarch.
8872
8873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * msp430-tdep.c (msp430_unwind_pc): Delete.
8876         (msp430_unwind_sp): Delete.
8877         (msp430_dummy_id): Delete.
8878         (msp430_gdbarch_init): Don't register deleted functions with
8879         gdbarch.
8880
8881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * moxie-tdep.c (moxie_unwind_sp): Delete.
8884         (moxie_unwind_pc): Delete.
8885         (moxie_dummy_id): Delete.
8886         (moxie_gdbarch_init): Don't register deleted functions with
8887         gdbarch.
8888
8889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8892         (mn10300_unwind_pc): Delete.
8893         (mn10300_unwind_sp): Delete.
8894         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8895         mn10300_unwind_sp.
8896         (mn10300_frame_unwind_init): Don't register deleted functions with
8897         gdbarch.
8898
8899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * mep-tdep.c (mep_unwind_pc): Delete.
8902         (mep_unwind_sp): Delete.
8903         (mep_dummy_id): Delete.
8904         (mep_gdbarch_init): Don't register deleted functions with
8905         gdbarch.
8906
8907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8910         (m68hc11_unwind_sp): Delete.
8911         (m68hc11_gdbarch_init): Don't register deleted functions with
8912         gdbarch.
8913
8914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * m32r-tdep.c (m32r_unwind_sp): Delete.
8917         (m32r_unwind_pc): Delete.
8918         (m32r_dummy_id): Delete.
8919         (m32r_gdbarch_init): Don't register deleted functions with
8920         gdbarch.
8921
8922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * m32c-tdep.c (m32c_unwind_pc): Delete.
8925         (m32c_unwind_sp): Delete.
8926         (m32c_dummy_id): Delete.
8927         (m32c_gdbarch_init): Don't register deleted functions with
8928         gdbarch.
8929
8930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8931
8932         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8933         (lm32_unwind_pc): Delete.
8934         (lm32_dummy_id): Delete.
8935         (lm32_gdbarch_init): Don't register deleted functions with
8936         gdbarch.
8937
8938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8941         (iq2000_unwind_pc): Delete.
8942         (iq2000_dummy_id): Delete.
8943         (iq2000_gdbarch_init): Don't register deleted functions with
8944         gdbarch.
8945
8946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8947
8948         * nds32-tdep.c (nds32_type_align): Delete.
8949         (nds32_push_dummy_call): Use type_align instead.
8950
8951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * arm-tdep.c (arm_type_align): Only handle vector override case.
8954         (arm_push_dummy_call): Use type_align.
8955         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8956
8957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8958
8959         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8960         case.
8961         (pass_on_stack): Use type_align.
8962         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8963         function.
8964
8965 2019-04-23  Tom Tromey  <tromey@adacore.com>
8966
8967         * dwarf2read.c (line_header::file_name_at): Remove unused
8968         overload.
8969
8970 2019-04-23  Tom de Vries  <tdevries@suse.de>
8971
8972         PR gdb/24438
8973         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8974         invocation.
8975
8976
8977 2019-03-27  Ali Tamur  <tamur@google.com>
8978
8979         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8980         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8981         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8982         (dwarf_expr_context::get_addr_index): Likewise
8983         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8984         (symbol_needs_eval_context::get_addr_index): Likewise
8985         (disassemble_dwarf_expression): Add DW_OP_addrx
8986         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8987         (read_cutu_die_from_dwo): Update comment
8988         (skip_one_die): Add DW_FORM_addrx
8989         (read_attribute_value): Likewise
8990         (var_decode_location): Add DW_OP_addrx
8991         (dwarf2_const_value_attr): Add DW_FORM_addrx
8992         (dump_die_shallow): Likewise
8993         (dwarf2_fetch_constant_bytes): Likewise
8994         (decode_locdesc): Add DW_OP_addrx
8995         (skip_form_bytes): Add DW_FORM_addrx
8996
8997 2019-04-22  Ali Tamur  <tamur@google.com>
8998
8999         * MAINTAINERS (Write After Approval): Add self.
9000
9001 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9004         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9005         (open_symbol_file_object): Likewise.
9006         (svr4_default_sos): Add info parameter.
9007         (svr4_read_so_list): Likewise.
9008         (svr4_current_sos_direct): Adjust functions calls to pass down
9009         info.
9010         (svr4_current_sos_1): Add info parameter.
9011         (svr4_current_sos): Call get_svr4_info, pass info down to
9012         svr4_current_sos_1.
9013         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9014         get_svr4_info.
9015         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9016         get_svr4_info.
9017         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9018         to get_svr4_info.
9019         (probes_table_remove_objfile_probes): Likewise.
9020         (register_solib_event_probe): Add info parameter.
9021         (solist_update_incremental): Pass info parameter down to
9022         svr4_read_so_list.
9023         (disable_probes_interface): Add info parameter.
9024         (svr4_handle_solib_event): Pass current_program_space to
9025         get_svr4_info.  Adjust disable_probes_interface cleanup.
9026         (svr4_create_probe_breakpoints): Add info parameter, pass it
9027         down to register_solib_event_probe.
9028         (svr4_create_solib_event_breakpoints): Add info parameter,
9029         pass it down to svr4_create_probe_breakpoints.
9030         (enable_break): Pass info down to
9031         svr4_create_solib_event_breakpoints.
9032         (svr4_solib_create_inferior_hook): Pass current_program_space to
9033         get_svr4_info.
9034         (svr4_clear_solib): Likewise.
9035
9036 2019-04-22  Pedro Alves  <palves@redhat.com>
9037
9038         * solib-svr4.c (svr4_free_objfile_observer): New.
9039         (probe_and_action::objfile): New field.
9040         (probes_table_htab_remove_objfile_probes)
9041         (probes_table_remove_objfile_probes): New functions.
9042         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9043         in the new probe_and_action.  Don't store the probe in 'lookup'.
9044         (svr4_create_probe_breakpoints): Pass objfile to
9045         register_solib_event_probe.
9046         (_initialize_svr4_solib): Register a free_objfile observer.
9047
9048 2019-04-19  Tom Tromey  <tom@tromey.com>
9049
9050         * common/queue.h: Remove.
9051
9052 2019-04-19  Tom Tromey  <tom@tromey.com>
9053
9054         * event-loop.c: Don't include "common/queue.h".
9055
9056 2019-04-19  Tom Tromey  <tom@tromey.com>
9057
9058         * remote.c (remote_target): Use delete.
9059         * remote-notif.h: Include <list>, not "common/queue.h".
9060         (notif_client_p): Remove typedef.
9061         (remote_notif_state): Add constructor, destructor, initializer.
9062         <notif_queue>: Now a std::list.
9063         (remote_notif_state_xfree): Don't declare.
9064         * remote-notif.c (remote_notif_process, handle_notification)
9065         (remote_notif_state_allocate): Update.
9066         (~remote_notif_state): Rename from remote_notif_state_xfree.
9067
9068 2019-04-19  Tom Tromey  <tom@tromey.com>
9069
9070         * symfile.c (reread_symbols): Update.
9071         * objfiles.c (objfile_register_static_link)
9072         (objfile_lookup_static_link): Update
9073         (~objfile) Don't delete static_links.
9074         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9075
9076 2019-04-19  Tom Tromey  <tom@tromey.com>
9077
9078         * type-stack.h (struct type_stack) <insert>: Constify string.
9079         * type-stack.c (type_stack::insert): Constify string.
9080         * gdbtypes.h (lookup_template_type): Update.
9081         (address_space_name_to_int): Update.
9082         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9083         const.
9084         (lookup_template_type): Make name const.
9085         * c-exp.y: Update rules.
9086         (lex_one_token, classify_name, classify_inner_name)
9087         (c_print_token): Update.
9088         * p-exp.y: Update rules.
9089         (yylex): Update.
9090         * f-exp.y: Update rules.
9091         (yylex): Update.
9092         * d-exp.y: Update rules.
9093         (lex_one_token, classify_name, classify_inner_name): Update.
9094         * parse.c (write_dollar_variable, copy_name): Return std::string.
9095         * parser-defs.h (copy_name): Change return type.
9096         * m2-exp.y: Update rules.
9097         (yylex): Update.
9098         * go-exp.y (lex_one_token): Update.
9099         Update rules.
9100         (classify_unsafe_function, classify_packaged_name)
9101         (classify_name, yylex): Update.
9102
9103 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9104
9105         * configure.ac: add --enable-source-highlight switch.
9106         * configure: Regenerate.
9107         * top.c (print_gdb_version): plumb --enable-source-highlight
9108         status to "show configuration".
9109
9110 2019-04-19  Tom Tromey  <tromey@adacore.com>
9111
9112         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9113         Check ADA_TYPE_P.
9114         (empty_record, ada_template_to_fixed_record_type_1)
9115         (template_to_static_fixed_type)
9116         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9117         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9118         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9119         macros.
9120
9121 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9122
9123         PR symtab/24423:
9124         * source.c (print_source_lines_base): Advance "iter" when a
9125         control character is seen.
9126
9127 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9128
9129         * inferior.h (struct infcall_suspend_state_deleter):
9130         Catch exception in destructor to avoid crash.
9131
9132 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9133
9134         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9135         close to the add_com "shell".
9136
9137 2019-04-18  Tom Tromey  <tromey@adacore.com>
9138
9139         * process-stratum-target.h (class process_stratum_target)
9140         <stratum>: Add "final".
9141
9142 2019-04-17  Tom Tromey  <tromey@adacore.com>
9143
9144         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9145         against nullptr before use.
9146
9147 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9148
9149         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9150
9151 2019-04-17  Jim Wilson  <jimw@sifive.com>
9152             Andrew Burgess  <andrew.burgess@embecosm.com>
9153
9154         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9155         code read might fail, assume 4-byte breakpoint in that case.
9156
9157 2019-04-15  Leszek Swirski  <leszeks@google.com>
9158
9159         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9160         rather than a hand-rolled POD check when checking for forced MEMORY
9161         classification.
9162
9163 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9164
9165         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9166         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9167         function.
9168         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9169         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9170         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9171         declaration.
9172
9173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9174
9175         * aarch64-linux-nat.c
9176         (aarch64_linux_nat_target::thread_architecture): Add override.
9177         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9178         each VQ.
9179
9180 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9181
9182         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9183
9184 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9187         target types of size 96-bits, add some additional comments, and
9188         check that the builtin type we found was the correct size.
9189
9190 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9191
9192         * utils.c (prompt_for_continue): Don't restore the styling at the
9193         end, as applied_style has the wrong value.  This fixes styling in
9194         long lists of file names that are interrupted by the "Continue?"
9195         prompt.
9196
9197 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9198
9199         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9200         * c-lang.c (c_language_defn): Likewise.
9201         (cplus_language_defn): Likewise.
9202         (asm_language_defn): Likewise.
9203         (minimal_language_defn): Likewise.
9204         * d-lang.c (d_language_defn): Likewise.
9205         * f-lang.c (f_language_defn): Likewise.
9206         * go-lang.c (go_language_defn): Likewise.
9207         * language.c (unknown_language_defn): Likewise.
9208         (auto_language_defn): Likewise.
9209         * language.h (struct language_defn): Remove la_magic field.
9210         (LANG_MAGIC): Delete.
9211         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9212         * objc-lang.c (objc_language_defn): Likewise.
9213         * opencl-lang.c (opencl_language_defn): Likewise.
9214         * p-lang.c (pascal_language_defn): Likewise.
9215         * rust-lang.c (rust_language_defn): Likewise.
9216
9217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * riscv-tdep.c (riscv_type_align): New function.
9220         (riscv_type_alignment): Delete.
9221         (riscv_arg_location): Use 'type_align'.
9222         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9223
9224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * gdbtypes.c (type_align): A struct with no non-static fields also
9227         has alignment of 1.
9228
9229 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9230
9231         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9232         component to 0.
9233         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9234         member.
9235         (riscv_struct_info::analyse): New implementation using new
9236         analyse_inner member function.
9237         (riscv_struct_info::field_offset): New member function.
9238         (riscv_struct_info::m_offsets): New member variable.
9239         (riscv_struct_info::analyse_inner): New private member function,
9240         takes the old implementation of riscv_struct_info::analyse but
9241         extended to track field offsets.
9242         (riscv_call_arg_struct): Update the struct folding special cases
9243         to handle cases where empty C++ structs, which are non-zero
9244         length, are found.
9245         (riscv_arg_location): Initialise the length of each location, a
9246         non-zero length now indicates the location is in use.
9247         (riscv_push_dummy_call): Allow for the first location having a
9248         non-zero offset when setting up arguments.
9249         (riscv_return_value): Likewise, but for return values.
9250
9251 2019-04-11  Tom Tromey  <tromey@adacore.com>
9252
9253         * utils.c (internal_vproblem): Make "msg" const.
9254
9255 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9256
9257         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9258         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9259         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9260         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9261
9262 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9263
9264         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9265         function.
9266         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9267         of amd64_collect_native_gregset.
9268         (amd64_linux_nat_target::store_registers): Likewise.
9269
9270 2019-04-10  Tom Tromey  <tom@tromey.com>
9271
9272         * symtab.c (lookup_global_symbol_from_objfile)
9273         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9274         * objfiles.h (class separate_debug_iterator): New.
9275         (class separate_debug_range): New.
9276         (struct objfile) <separate_debug_objfiles>: New method.
9277         (objfile_separate_debug_iterate): Don't declare.
9278         * objfiles.c (separate_debug_iterator::operator++): Rename from
9279         objfile_separate_debug_iterate.
9280         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9281         iterator.
9282         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9283         iterator.
9284
9285 2019-04-10  Tom Tromey  <tom@tromey.com>
9286
9287         * symfile.c (reread_symbols): Remove old comment.
9288         * objfiles.c (free_all_objfiles): Fix a typo.
9289
9290 2019-04-10  Tom Tromey  <tom@tromey.com>
9291
9292         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9293         * minsyms.c (lookup_minimal_symbol): Use foreach.
9294         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9295         (lookup_minimal_symbol_solib_trampoline): Likewise.
9296         * symfile.c (reread_symbols): Use foreach.
9297
9298 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9299             Tom Tromey  <tromey@adacore.com>
9300
9301         PR rust/24414:
9302         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9303         (rust_lex_int_test): Change "value" to be LONGEST.
9304         (rust_lex_tests): Add test for long integer literal.
9305
9306 2019-04-09  Tom Tromey  <tromey@adacore.com>
9307
9308         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9309         to bool.
9310         (extended_remote_target::attach): Update.
9311         (remote_target::remote_notice_new_inferior): Update.
9312         (remote_target::add_current_inferior_and_thread): Update.
9313         * inferior.c (exit_inferior_1): Use "false".
9314         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9315
9316 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9317
9318         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9319         the "start" command.
9320
9321 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9322
9323         * python/py-inferior.c (infpy_thread_from_thread_handle):
9324         Adjust comments to reflect renaming of thread_from_thread_handle
9325         to thread_from_handle.  Adjust keywords.  Fix type error message.
9326         (inferior_object_methods): Add thread_from_handle.  Retain
9327         thread_from_thread_handle, but mark it as deprecated.
9328
9329 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9330
9331         * gdbthread.h (find_thread_by_handle): Revise declaration.
9332         * thread.c (find_thread_by_handle): Likewise.  Adjust
9333         implementation too.
9334         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9335         support for buffer objects as handles.
9336
9337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9338
9339         * python/py-infthread.c (thpy_thread_handle): New function.
9340         (thread_object_methods): Register thpy_thread_handle.
9341
9342 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9343
9344         * gdbthread.h (thread_to_thread_handle): Declare.
9345         * thread.c (gdbtypes.h): Include.
9346         (thread_to_thread_handle): New function.
9347
9348         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9349         (target_thread_info_to_thread_handle): Declare.
9350         * target.c (target_thread_info_to_thread_handle): New function.
9351         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9352         * target-delegates.c: Regenerate.
9353
9354         * linux-thread-db.c (class thread_db_target): Add method
9355         thread_info_to_thread_handle.
9356         (thread_db_target::thread_info_to_thread_handle): Define.
9357         * remote.c (class remote_target): Add new method
9358         thread_info_to_thread_handle.
9359         (remote_target::thread_info_to_thread_handle): Define.
9360
9361 2019-04-08  Pedro Alves  <palves@redhat.com>
9362
9363         * common/common-exceptions.c (throw_exception): Don't create
9364         named object to throw; throw directly.
9365         (throw_it): Likewise.  Don't initialize gdb_exception::message
9366         here, with new; pass FMT and AP to the ctor instead.
9367         * common/common-exceptions.h: Include <string>.
9368         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9369         const char *, va_list)): New ctor.  Use std::make_shared.
9370         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9371         errors)): Delete.
9372         (gdb_exception_error::gdb_exception_error(enum errors, const char
9373         *, va_list)): New.
9374         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9375         Add assertion.
9376         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9377         errors)): Delete.
9378         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9379         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9380         Add assertion.
9381
9382 2019-04-08  Tom Tromey  <tom@tromey.com>
9383
9384         * valops.c (value_rtti_indirect_type): Replace throw_exception
9385         with throw.
9386         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9387         with throw.
9388         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9389         throw.
9390         * target.c (target_translate_tls_address): Replace throw_exception
9391         with throw.
9392         * stack.c (frame_apply_command_count): Replace throw_exception
9393         with throw.
9394         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9395         throw.
9396         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9397         with throw.
9398         * rs6000-tdep.c (rs6000_frame_cache)
9399         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9400         * remote.c: Replace throw_exception with throw.
9401         * record-full.c (record_full_message, record_full_wait_1)
9402         (record_full_restore): Replace throw_exception with throw.
9403         * record-btrace.c:
9404         (get_thread_current_frame_id, record_btrace_start_replaying)
9405         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9406         (cmd_record_btrace_start): Replace throw_exception with throw.
9407         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9408         throw.
9409         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9410         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9411         * linespec.c:
9412         (find_linespec_symbols): Replace throw_exception with throw.
9413         * infrun.c (displaced_step_prepare, resume): Replace
9414         throw_exception with throw.
9415         * infcmd.c (post_create_inferior): Replace throw_exception with
9416         throw.
9417         * inf-loop.c (inferior_event_handler): Replace throw_exception
9418         with throw.
9419         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9420         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9421         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9422         (get_prev_frame_always, get_frame_pc_if_available)
9423         (get_frame_address_in_block_if_available, get_frame_language):
9424         Replace throw_exception with throw.
9425         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9426         throw_exception with throw.
9427         * eval.c (fetch_subexp_value, evaluate_var_value)
9428         (evaluate_funcall, evaluate_subexp_standard): Replace
9429         throw_exception with throw.
9430         * dwarf2loc.c (call_site_find_chain)
9431         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9432         Replace throw_exception with throw.
9433         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9434         with throw.
9435         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9436         throw.
9437         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9438         * completer.c (complete_line_internal): Replace throw_exception
9439         with throw.
9440         * compile/compile-object-run.c (compile_object_run): Replace
9441         throw_exception with throw.
9442         * cli/cli-script.c (process_next_line): Replace throw_exception
9443         with throw.
9444         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9445         (btrace_enable, btrace_maint_update_pt_packets): Replace
9446         throw_exception with throw.
9447         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9448         throw_exception with throw.
9449         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9450         throw_exception with throw.
9451         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9452         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9453         * aarch64-tdep.c (aarch64_make_prologue_cache)
9454         (aarch64_make_stub_cache): Replace throw_exception with throw.
9455
9456 2019-04-08  Tom Tromey  <tom@tromey.com>
9457
9458         * common/common-exceptions.c (throw_exception): Rename from
9459         throw_exception_cxx.  Remove old copy.  Make argument const.
9460         (throw_it): Create and throw exception objects directly.
9461         * common/common-exceptions.h (throw_exception): Make argument
9462         const.
9463         (struct gdb_exception_error): Add constructor.
9464         (struct gdb_exception_quit): Add constructor.
9465
9466 2019-04-08  Tom Tromey  <tom@tromey.com>
9467
9468         * common/common-exceptions.h (exception_rethrow): Don't declare.
9469         (TRY_SJLJ): Update comment.
9470         (TRY, CATCH, END_CATCH): Remove.
9471         * common/common-exceptions.c (exception_rethrow): Remove.
9472
9473 2019-04-08  Tom Tromey  <tom@tromey.com>
9474
9475         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9476         Remove.
9477         (gdb_exception_error): Rename from
9478         gdb_exception_RETURN_MASK_ERROR.
9479         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9480         (gdb_quit_bad_alloc): Update.
9481         * aarch64-tdep.c: Update.
9482         * ada-lang.c: Update.
9483         * ada-typeprint.c: Update.
9484         * ada-valprint.c: Update.
9485         * amd64-tdep.c: Update.
9486         * arch-utils.c: Update.
9487         * break-catch-throw.c: Update.
9488         * breakpoint.c: Update.
9489         * btrace.c: Update.
9490         * c-varobj.c: Update.
9491         * cli/cli-cmds.c: Update.
9492         * cli/cli-interp.c: Update.
9493         * cli/cli-script.c: Update.
9494         * common/common-exceptions.c: Update.
9495         * common/new-op.c: Update.
9496         * common/selftest.c: Update.
9497         * compile/compile-c-symbols.c: Update.
9498         * compile/compile-cplus-symbols.c: Update.
9499         * compile/compile-object-load.c: Update.
9500         * compile/compile-object-run.c: Update.
9501         * completer.c: Update.
9502         * corelow.c: Update.
9503         * cp-abi.c: Update.
9504         * cp-support.c: Update.
9505         * cp-valprint.c: Update.
9506         * darwin-nat.c: Update.
9507         * disasm-selftests.c: Update.
9508         * dtrace-probe.c: Update.
9509         * dwarf-index-cache.c: Update.
9510         * dwarf-index-write.c: Update.
9511         * dwarf2-frame-tailcall.c: Update.
9512         * dwarf2-frame.c: Update.
9513         * dwarf2loc.c: Update.
9514         * dwarf2read.c: Update.
9515         * eval.c: Update.
9516         * event-loop.c: Update.
9517         * event-top.c: Update.
9518         * exec.c: Update.
9519         * f-valprint.c: Update.
9520         * fbsd-tdep.c: Update.
9521         * frame-unwind.c: Update.
9522         * frame.c: Update.
9523         * gdbtypes.c: Update.
9524         * gnu-v3-abi.c: Update.
9525         * guile/guile-internal.h: Update.
9526         * guile/scm-block.c: Update.
9527         * guile/scm-breakpoint.c: Update.
9528         * guile/scm-cmd.c: Update.
9529         * guile/scm-disasm.c: Update.
9530         * guile/scm-frame.c: Update.
9531         * guile/scm-lazy-string.c: Update.
9532         * guile/scm-math.c: Update.
9533         * guile/scm-param.c: Update.
9534         * guile/scm-ports.c: Update.
9535         * guile/scm-pretty-print.c: Update.
9536         * guile/scm-symbol.c: Update.
9537         * guile/scm-symtab.c: Update.
9538         * guile/scm-type.c: Update.
9539         * guile/scm-value.c: Update.
9540         * i386-linux-tdep.c: Update.
9541         * i386-tdep.c: Update.
9542         * inf-loop.c: Update.
9543         * infcall.c: Update.
9544         * infcmd.c: Update.
9545         * infrun.c: Update.
9546         * jit.c: Update.
9547         * language.c: Update.
9548         * linespec.c: Update.
9549         * linux-fork.c: Update.
9550         * linux-nat.c: Update.
9551         * linux-tdep.c: Update.
9552         * linux-thread-db.c: Update.
9553         * main.c: Update.
9554         * mi/mi-cmd-break.c: Update.
9555         * mi/mi-cmd-stack.c: Update.
9556         * mi/mi-interp.c: Update.
9557         * mi/mi-main.c: Update.
9558         * objc-lang.c: Update.
9559         * p-valprint.c: Update.
9560         * parse.c: Update.
9561         * ppc-linux-tdep.c: Update.
9562         * printcmd.c: Update.
9563         * python/py-arch.c: Update.
9564         * python/py-breakpoint.c: Update.
9565         * python/py-cmd.c: Update.
9566         * python/py-finishbreakpoint.c: Update.
9567         * python/py-frame.c: Update.
9568         * python/py-framefilter.c: Update.
9569         * python/py-gdb-readline.c: Update.
9570         * python/py-inferior.c: Update.
9571         * python/py-infthread.c: Update.
9572         * python/py-lazy-string.c: Update.
9573         * python/py-linetable.c: Update.
9574         * python/py-objfile.c: Update.
9575         * python/py-param.c: Update.
9576         * python/py-prettyprint.c: Update.
9577         * python/py-progspace.c: Update.
9578         * python/py-record-btrace.c: Update.
9579         * python/py-record.c: Update.
9580         * python/py-symbol.c: Update.
9581         * python/py-type.c: Update.
9582         * python/py-unwind.c: Update.
9583         * python/py-utils.c: Update.
9584         * python/py-value.c: Update.
9585         * python/python.c: Update.
9586         * record-btrace.c: Update.
9587         * record-full.c: Update.
9588         * remote-fileio.c: Update.
9589         * remote.c: Update.
9590         * riscv-tdep.c: Update.
9591         * rs6000-aix-tdep.c: Update.
9592         * rs6000-tdep.c: Update.
9593         * rust-exp.y: Update.
9594         * rust-lang.c: Update.
9595         * s390-tdep.c: Update.
9596         * selftest-arch.c: Update.
9597         * solib-dsbt.c: Update.
9598         * solib-frv.c: Update.
9599         * solib-spu.c: Update.
9600         * solib-svr4.c: Update.
9601         * solib.c: Update.
9602         * sparc64-linux-tdep.c: Update.
9603         * stack.c: Update.
9604         * symfile-mem.c: Update.
9605         * symmisc.c: Update.
9606         * target.c: Update.
9607         * thread.c: Update.
9608         * top.c: Update.
9609         * tracefile-tfile.c: Update.
9610         * tui/tui.c: Update.
9611         * typeprint.c: Update.
9612         * unittests/cli-utils-selftests.c: Update.
9613         * unittests/parse-connection-spec-selftests.c: Update.
9614         * valops.c: Update.
9615         * valprint.c: Update.
9616         * value.c: Update.
9617         * varobj.c: Update.
9618         * windows-nat.c: Update.
9619         * x86-linux-nat.c: Update.
9620         * xml-support.c: Update.
9621
9622 2019-04-08  Tom Tromey  <tom@tromey.com>
9623
9624         * xml-support.c: Use C++ exception handling.
9625         * x86-linux-nat.c: Use C++ exception handling.
9626         * windows-nat.c: Use C++ exception handling.
9627         * varobj.c: Use C++ exception handling.
9628         * value.c: Use C++ exception handling.
9629         * valprint.c: Use C++ exception handling.
9630         * valops.c: Use C++ exception handling.
9631         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9632         handling.
9633         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9634         * typeprint.c: Use C++ exception handling.
9635         * tui/tui.c: Use C++ exception handling.
9636         * tracefile-tfile.c: Use C++ exception handling.
9637         * top.c: Use C++ exception handling.
9638         * thread.c: Use C++ exception handling.
9639         * target.c: Use C++ exception handling.
9640         * symmisc.c: Use C++ exception handling.
9641         * symfile-mem.c: Use C++ exception handling.
9642         * stack.c: Use C++ exception handling.
9643         * sparc64-linux-tdep.c: Use C++ exception handling.
9644         * solib.c: Use C++ exception handling.
9645         * solib-svr4.c: Use C++ exception handling.
9646         * solib-spu.c: Use C++ exception handling.
9647         * solib-frv.c: Use C++ exception handling.
9648         * solib-dsbt.c: Use C++ exception handling.
9649         * selftest-arch.c: Use C++ exception handling.
9650         * s390-tdep.c: Use C++ exception handling.
9651         * rust-lang.c: Use C++ exception handling.
9652         * rust-exp.y: Use C++ exception handling.
9653         * rs6000-tdep.c: Use C++ exception handling.
9654         * rs6000-aix-tdep.c: Use C++ exception handling.
9655         * riscv-tdep.c: Use C++ exception handling.
9656         * remote.c: Use C++ exception handling.
9657         * remote-fileio.c: Use C++ exception handling.
9658         * record-full.c: Use C++ exception handling.
9659         * record-btrace.c: Use C++ exception handling.
9660         * python/python.c: Use C++ exception handling.
9661         * python/py-value.c: Use C++ exception handling.
9662         * python/py-utils.c: Use C++ exception handling.
9663         * python/py-unwind.c: Use C++ exception handling.
9664         * python/py-type.c: Use C++ exception handling.
9665         * python/py-symbol.c: Use C++ exception handling.
9666         * python/py-record.c: Use C++ exception handling.
9667         * python/py-record-btrace.c: Use C++ exception handling.
9668         * python/py-progspace.c: Use C++ exception handling.
9669         * python/py-prettyprint.c: Use C++ exception handling.
9670         * python/py-param.c: Use C++ exception handling.
9671         * python/py-objfile.c: Use C++ exception handling.
9672         * python/py-linetable.c: Use C++ exception handling.
9673         * python/py-lazy-string.c: Use C++ exception handling.
9674         * python/py-infthread.c: Use C++ exception handling.
9675         * python/py-inferior.c: Use C++ exception handling.
9676         * python/py-gdb-readline.c: Use C++ exception handling.
9677         * python/py-framefilter.c: Use C++ exception handling.
9678         * python/py-frame.c: Use C++ exception handling.
9679         * python/py-finishbreakpoint.c: Use C++ exception handling.
9680         * python/py-cmd.c: Use C++ exception handling.
9681         * python/py-breakpoint.c: Use C++ exception handling.
9682         * python/py-arch.c: Use C++ exception handling.
9683         * printcmd.c: Use C++ exception handling.
9684         * ppc-linux-tdep.c: Use C++ exception handling.
9685         * parse.c: Use C++ exception handling.
9686         * p-valprint.c: Use C++ exception handling.
9687         * objc-lang.c: Use C++ exception handling.
9688         * mi/mi-main.c: Use C++ exception handling.
9689         * mi/mi-interp.c: Use C++ exception handling.
9690         * mi/mi-cmd-stack.c: Use C++ exception handling.
9691         * mi/mi-cmd-break.c: Use C++ exception handling.
9692         * main.c: Use C++ exception handling.
9693         * linux-thread-db.c: Use C++ exception handling.
9694         * linux-tdep.c: Use C++ exception handling.
9695         * linux-nat.c: Use C++ exception handling.
9696         * linux-fork.c: Use C++ exception handling.
9697         * linespec.c: Use C++ exception handling.
9698         * language.c: Use C++ exception handling.
9699         * jit.c: Use C++ exception handling.
9700         * infrun.c: Use C++ exception handling.
9701         * infcmd.c: Use C++ exception handling.
9702         * infcall.c: Use C++ exception handling.
9703         * inf-loop.c: Use C++ exception handling.
9704         * i386-tdep.c: Use C++ exception handling.
9705         * i386-linux-tdep.c: Use C++ exception handling.
9706         * guile/scm-value.c: Use C++ exception handling.
9707         * guile/scm-type.c: Use C++ exception handling.
9708         * guile/scm-symtab.c: Use C++ exception handling.
9709         * guile/scm-symbol.c: Use C++ exception handling.
9710         * guile/scm-pretty-print.c: Use C++ exception handling.
9711         * guile/scm-ports.c: Use C++ exception handling.
9712         * guile/scm-param.c: Use C++ exception handling.
9713         * guile/scm-math.c: Use C++ exception handling.
9714         * guile/scm-lazy-string.c: Use C++ exception handling.
9715         * guile/scm-frame.c: Use C++ exception handling.
9716         * guile/scm-disasm.c: Use C++ exception handling.
9717         * guile/scm-cmd.c: Use C++ exception handling.
9718         * guile/scm-breakpoint.c: Use C++ exception handling.
9719         * guile/scm-block.c: Use C++ exception handling.
9720         * guile/guile-internal.h: Use C++ exception handling.
9721         * gnu-v3-abi.c: Use C++ exception handling.
9722         * gdbtypes.c: Use C++ exception handling.
9723         * frame.c: Use C++ exception handling.
9724         * frame-unwind.c: Use C++ exception handling.
9725         * fbsd-tdep.c: Use C++ exception handling.
9726         * f-valprint.c: Use C++ exception handling.
9727         * exec.c: Use C++ exception handling.
9728         * event-top.c: Use C++ exception handling.
9729         * event-loop.c: Use C++ exception handling.
9730         * eval.c: Use C++ exception handling.
9731         * dwarf2read.c: Use C++ exception handling.
9732         * dwarf2loc.c: Use C++ exception handling.
9733         * dwarf2-frame.c: Use C++ exception handling.
9734         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9735         * dwarf-index-write.c: Use C++ exception handling.
9736         * dwarf-index-cache.c: Use C++ exception handling.
9737         * dtrace-probe.c: Use C++ exception handling.
9738         * disasm-selftests.c: Use C++ exception handling.
9739         * darwin-nat.c: Use C++ exception handling.
9740         * cp-valprint.c: Use C++ exception handling.
9741         * cp-support.c: Use C++ exception handling.
9742         * cp-abi.c: Use C++ exception handling.
9743         * corelow.c: Use C++ exception handling.
9744         * completer.c: Use C++ exception handling.
9745         * compile/compile-object-run.c: Use C++ exception handling.
9746         * compile/compile-object-load.c: Use C++ exception handling.
9747         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9748         * compile/compile-c-symbols.c: Use C++ exception handling.
9749         * common/selftest.c: Use C++ exception handling.
9750         * common/new-op.c: Use C++ exception handling.
9751         * cli/cli-script.c: Use C++ exception handling.
9752         * cli/cli-interp.c: Use C++ exception handling.
9753         * cli/cli-cmds.c: Use C++ exception handling.
9754         * c-varobj.c: Use C++ exception handling.
9755         * btrace.c: Use C++ exception handling.
9756         * breakpoint.c: Use C++ exception handling.
9757         * break-catch-throw.c: Use C++ exception handling.
9758         * arch-utils.c: Use C++ exception handling.
9759         * amd64-tdep.c: Use C++ exception handling.
9760         * ada-valprint.c: Use C++ exception handling.
9761         * ada-typeprint.c: Use C++ exception handling.
9762         * ada-lang.c: Use C++ exception handling.
9763         * aarch64-tdep.c: Use C++ exception handling.
9764
9765 2019-04-08  Tom Tromey  <tom@tromey.com>
9766
9767         * xml-support.c (gdb_xml_parser::parse): Update.
9768         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9769         * value.c (show_convenience): Update.
9770         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9771         (test_parse_flags_qcs): Update.
9772         * thread.c (thr_try_catch_cmd): Update.
9773         * target.c (target_translate_tls_address): Update.
9774         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9775         (info_frame_command_core, frame_apply_command_count): Update.
9776         * rust-exp.y (rust_lex_exception_test): Update.
9777         * riscv-tdep.c (riscv_print_one_register_info): Update.
9778         * remote.c (remote_target::enable_btrace): Update.
9779         * record-btrace.c (record_btrace_enable_warn): Update.
9780         * python/py-utils.c (gdbpy_convert_exception): Update.
9781         * printcmd.c (do_one_display, print_variable_and_value): Update.
9782         * mi/mi-main.c (mi_print_exception): Update.
9783         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9784         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9785         * linux-nat.c (linux_nat_target::attach): Update.
9786         * linux-fork.c (class scoped_switch_fork_info): Update.
9787         * infrun.c (displaced_step_prepare): Update.
9788         * infcall.c (call_function_by_hand_dummy): Update.
9789         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9790         * gnu-v3-abi.c (print_one_vtable): Update.
9791         * frame.c (get_prev_frame_always): Update.
9792         * f-valprint.c (info_common_command_for_block): Update.
9793         * exec.c (try_open_exec_file): Update.
9794         * exceptions.c (print_exception, exception_print)
9795         (exception_fprintf, exception_print_same): Update.
9796         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9797         * dwarf-index-cache.c (index_cache::store)
9798         (index_cache::lookup_gdb_index): Update.
9799         * darwin-nat.c (maybe_cache_shell): Update.
9800         * cp-valprint.c (cp_print_value_fields): Update.
9801         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9802         (gcc_cplus_symbol_address): Update.
9803         * compile/compile-c-symbols.c (gcc_convert_symbol)
9804         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9805         * common/selftest.c: Update.
9806         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9807         a std::string.
9808         (exception_try_scope_entry, exception_try_scope_exit): Don't
9809         declare.
9810         (struct exception_try_scope): Remove.
9811         (TRY): Don't use exception_try_scope.
9812         (struct gdb_exception): Add constructor, operator=.
9813         <what>: New method.
9814         (struct gdb_exception_RETURN_MASK_ALL)
9815         (struct gdb_exception_RETURN_MASK_ERROR)
9816         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9817         (struct gdb_quit_bad_alloc): Update.
9818         * common/common-exceptions.c (exception_none): Change
9819         initializer.
9820         (struct catcher) <state, exception>: Initialize inline.
9821         <prev>: Remove member.
9822         (current_catcher): Remove.
9823         (catchers): New global.
9824         (exceptions_state_mc_init): Simplify.
9825         (catcher_pop): Remove.
9826         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9827         (try_scope_depth, exception_try_scope_entry)
9828         (exception_try_scope_exit): Remove.
9829         (throw_exception_sjlj): Update.
9830         (exception_messages, exception_messages_size): Remove.
9831         (throw_it): Simplify.
9832         (gdb_exception_sliced_copy): Remove.
9833         (throw_exception_cxx): Update.
9834         * cli/cli-script.c (script_from_file): Update.
9835         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9836         Update.
9837         * ada-valprint.c (ada_val_print): Update.
9838         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9839         (create_excep_cond_exprs): Update.
9840
9841 2019-04-08  Tom Tromey  <tom@tromey.com>
9842
9843         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9844         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9845         (TRY, CATCH, END_CATCH): Remove some definitions.
9846         * common/common-exceptions.c: Don't use GDB_XCPT.
9847         (catcher_list_size): Remove.
9848         (throw_exception, throw_it): Simplify.
9849
9850 2019-04-05  Tom Tromey  <tom@tromey.com>
9851
9852         Revert the header-sorting patch.
9853         * ft32-tdep.c: Revert.
9854         * frv-tdep.c: Revert.
9855         * frv-linux-tdep.c: Revert.
9856         * frame.c: Revert.
9857         * frame-unwind.c: Revert.
9858         * frame-base.c: Revert.
9859         * fork-child.c: Revert.
9860         * findvar.c: Revert.
9861         * findcmd.c: Revert.
9862         * filesystem.c: Revert.
9863         * filename-seen-cache.h: Revert.
9864         * filename-seen-cache.c: Revert.
9865         * fbsd-tdep.c: Revert.
9866         * fbsd-nat.h: Revert.
9867         * fbsd-nat.c: Revert.
9868         * f-valprint.c: Revert.
9869         * f-typeprint.c: Revert.
9870         * f-lang.c: Revert.
9871         * extension.h: Revert.
9872         * extension.c: Revert.
9873         * extension-priv.h: Revert.
9874         * expprint.c: Revert.
9875         * exec.h: Revert.
9876         * exec.c: Revert.
9877         * exceptions.c: Revert.
9878         * event-top.c: Revert.
9879         * event-loop.c: Revert.
9880         * eval.c: Revert.
9881         * elfread.c: Revert.
9882         * dwarf2read.h: Revert.
9883         * dwarf2read.c: Revert.
9884         * dwarf2loc.c: Revert.
9885         * dwarf2expr.h: Revert.
9886         * dwarf2expr.c: Revert.
9887         * dwarf2-frame.c: Revert.
9888         * dwarf2-frame-tailcall.c: Revert.
9889         * dwarf-index-write.h: Revert.
9890         * dwarf-index-write.c: Revert.
9891         * dwarf-index-common.c: Revert.
9892         * dwarf-index-cache.h: Revert.
9893         * dwarf-index-cache.c: Revert.
9894         * dummy-frame.c: Revert.
9895         * dtrace-probe.c: Revert.
9896         * disasm.h: Revert.
9897         * disasm.c: Revert.
9898         * disasm-selftests.c: Revert.
9899         * dictionary.c: Revert.
9900         * dicos-tdep.c: Revert.
9901         * demangle.c: Revert.
9902         * dcache.h: Revert.
9903         * dcache.c: Revert.
9904         * darwin-nat.h: Revert.
9905         * darwin-nat.c: Revert.
9906         * darwin-nat-info.c: Revert.
9907         * d-valprint.c: Revert.
9908         * d-namespace.c: Revert.
9909         * d-lang.c: Revert.
9910         * ctf.c: Revert.
9911         * csky-tdep.c: Revert.
9912         * csky-linux-tdep.c: Revert.
9913         * cris-tdep.c: Revert.
9914         * cris-linux-tdep.c: Revert.
9915         * cp-valprint.c: Revert.
9916         * cp-support.c: Revert.
9917         * cp-namespace.c: Revert.
9918         * cp-abi.c: Revert.
9919         * corelow.c: Revert.
9920         * corefile.c: Revert.
9921         * continuations.c: Revert.
9922         * completer.h: Revert.
9923         * completer.c: Revert.
9924         * complaints.c: Revert.
9925         * coffread.c: Revert.
9926         * coff-pe-read.c: Revert.
9927         * cli-out.h: Revert.
9928         * cli-out.c: Revert.
9929         * charset.c: Revert.
9930         * c-varobj.c: Revert.
9931         * c-valprint.c: Revert.
9932         * c-typeprint.c: Revert.
9933         * c-lang.c: Revert.
9934         * buildsym.c: Revert.
9935         * buildsym-legacy.c: Revert.
9936         * build-id.h: Revert.
9937         * build-id.c: Revert.
9938         * btrace.c: Revert.
9939         * bsd-uthread.c: Revert.
9940         * breakpoint.h: Revert.
9941         * breakpoint.c: Revert.
9942         * break-catch-throw.c: Revert.
9943         * break-catch-syscall.c: Revert.
9944         * break-catch-sig.c: Revert.
9945         * blockframe.c: Revert.
9946         * block.c: Revert.
9947         * bfin-tdep.c: Revert.
9948         * bfin-linux-tdep.c: Revert.
9949         * bfd-target.c: Revert.
9950         * bcache.c: Revert.
9951         * ax-general.c: Revert.
9952         * ax-gdb.h: Revert.
9953         * ax-gdb.c: Revert.
9954         * avr-tdep.c: Revert.
9955         * auxv.c: Revert.
9956         * auto-load.c: Revert.
9957         * arm-wince-tdep.c: Revert.
9958         * arm-tdep.c: Revert.
9959         * arm-symbian-tdep.c: Revert.
9960         * arm-pikeos-tdep.c: Revert.
9961         * arm-obsd-tdep.c: Revert.
9962         * arm-nbsd-tdep.c: Revert.
9963         * arm-nbsd-nat.c: Revert.
9964         * arm-linux-tdep.c: Revert.
9965         * arm-linux-nat.c: Revert.
9966         * arm-fbsd-tdep.c: Revert.
9967         * arm-fbsd-nat.c: Revert.
9968         * arm-bsd-tdep.c: Revert.
9969         * arch-utils.c: Revert.
9970         * arc-tdep.c: Revert.
9971         * arc-newlib-tdep.c: Revert.
9972         * annotate.h: Revert.
9973         * annotate.c: Revert.
9974         * amd64-windows-tdep.c: Revert.
9975         * amd64-windows-nat.c: Revert.
9976         * amd64-tdep.c: Revert.
9977         * amd64-sol2-tdep.c: Revert.
9978         * amd64-obsd-tdep.c: Revert.
9979         * amd64-obsd-nat.c: Revert.
9980         * amd64-nbsd-tdep.c: Revert.
9981         * amd64-nbsd-nat.c: Revert.
9982         * amd64-nat.c: Revert.
9983         * amd64-linux-tdep.c: Revert.
9984         * amd64-linux-nat.c: Revert.
9985         * amd64-fbsd-tdep.c: Revert.
9986         * amd64-fbsd-nat.c: Revert.
9987         * amd64-dicos-tdep.c: Revert.
9988         * amd64-darwin-tdep.c: Revert.
9989         * amd64-bsd-nat.c: Revert.
9990         * alpha-tdep.c: Revert.
9991         * alpha-obsd-tdep.c: Revert.
9992         * alpha-nbsd-tdep.c: Revert.
9993         * alpha-mdebug-tdep.c: Revert.
9994         * alpha-linux-tdep.c: Revert.
9995         * alpha-linux-nat.c: Revert.
9996         * alpha-bsd-tdep.c: Revert.
9997         * alpha-bsd-nat.c: Revert.
9998         * aix-thread.c: Revert.
9999         * agent.c: Revert.
10000         * addrmap.c: Revert.
10001         * ada-varobj.c: Revert.
10002         * ada-valprint.c: Revert.
10003         * ada-typeprint.c: Revert.
10004         * ada-tasks.c: Revert.
10005         * ada-lang.c: Revert.
10006         * aarch64-tdep.c: Revert.
10007         * aarch64-ravenscar-thread.c: Revert.
10008         * aarch64-newlib-tdep.c: Revert.
10009         * aarch64-linux-tdep.c: Revert.
10010         * aarch64-linux-nat.c: Revert.
10011         * aarch64-fbsd-tdep.c: Revert.
10012         * aarch64-fbsd-nat.c: Revert.
10013         * aarch32-linux-nat.c: Revert.
10014
10015 2019-04-05  Tom Tromey  <tom@tromey.com>
10016
10017         * ft32-tdep.c: Sort headers.
10018         * frv-tdep.c: Sort headers.
10019         * frv-linux-tdep.c: Sort headers.
10020         * frame.c: Sort headers.
10021         * frame-unwind.c: Sort headers.
10022         * frame-base.c: Sort headers.
10023         * fork-child.c: Sort headers.
10024         * findvar.c: Sort headers.
10025         * findcmd.c: Sort headers.
10026         * filesystem.c: Sort headers.
10027         * filename-seen-cache.h: Sort headers.
10028         * filename-seen-cache.c: Sort headers.
10029         * fbsd-tdep.c: Sort headers.
10030         * fbsd-nat.h: Sort headers.
10031         * fbsd-nat.c: Sort headers.
10032         * f-valprint.c: Sort headers.
10033         * f-typeprint.c: Sort headers.
10034         * f-lang.c: Sort headers.
10035         * extension.h: Sort headers.
10036         * extension.c: Sort headers.
10037         * extension-priv.h: Sort headers.
10038         * expprint.c: Sort headers.
10039         * exec.h: Sort headers.
10040         * exec.c: Sort headers.
10041         * exceptions.c: Sort headers.
10042         * event-top.c: Sort headers.
10043         * event-loop.c: Sort headers.
10044         * eval.c: Sort headers.
10045         * elfread.c: Sort headers.
10046         * dwarf2read.h: Sort headers.
10047         * dwarf2read.c: Sort headers.
10048         * dwarf2loc.c: Sort headers.
10049         * dwarf2expr.h: Sort headers.
10050         * dwarf2expr.c: Sort headers.
10051         * dwarf2-frame.c: Sort headers.
10052         * dwarf2-frame-tailcall.c: Sort headers.
10053         * dwarf-index-write.h: Sort headers.
10054         * dwarf-index-write.c: Sort headers.
10055         * dwarf-index-common.c: Sort headers.
10056         * dwarf-index-cache.h: Sort headers.
10057         * dwarf-index-cache.c: Sort headers.
10058         * dummy-frame.c: Sort headers.
10059         * dtrace-probe.c: Sort headers.
10060         * disasm.h: Sort headers.
10061         * disasm.c: Sort headers.
10062         * disasm-selftests.c: Sort headers.
10063         * dictionary.c: Sort headers.
10064         * dicos-tdep.c: Sort headers.
10065         * demangle.c: Sort headers.
10066         * dcache.h: Sort headers.
10067         * dcache.c: Sort headers.
10068         * darwin-nat.h: Sort headers.
10069         * darwin-nat.c: Sort headers.
10070         * darwin-nat-info.c: Sort headers.
10071         * d-valprint.c: Sort headers.
10072         * d-namespace.c: Sort headers.
10073         * d-lang.c: Sort headers.
10074         * ctf.c: Sort headers.
10075         * csky-tdep.c: Sort headers.
10076         * csky-linux-tdep.c: Sort headers.
10077         * cris-tdep.c: Sort headers.
10078         * cris-linux-tdep.c: Sort headers.
10079         * cp-valprint.c: Sort headers.
10080         * cp-support.c: Sort headers.
10081         * cp-namespace.c: Sort headers.
10082         * cp-abi.c: Sort headers.
10083         * corelow.c: Sort headers.
10084         * corefile.c: Sort headers.
10085         * continuations.c: Sort headers.
10086         * completer.h: Sort headers.
10087         * completer.c: Sort headers.
10088         * complaints.c: Sort headers.
10089         * coffread.c: Sort headers.
10090         * coff-pe-read.c: Sort headers.
10091         * cli-out.h: Sort headers.
10092         * cli-out.c: Sort headers.
10093         * charset.c: Sort headers.
10094         * c-varobj.c: Sort headers.
10095         * c-valprint.c: Sort headers.
10096         * c-typeprint.c: Sort headers.
10097         * c-lang.c: Sort headers.
10098         * buildsym.c: Sort headers.
10099         * buildsym-legacy.c: Sort headers.
10100         * build-id.h: Sort headers.
10101         * build-id.c: Sort headers.
10102         * btrace.c: Sort headers.
10103         * bsd-uthread.c: Sort headers.
10104         * breakpoint.h: Sort headers.
10105         * breakpoint.c: Sort headers.
10106         * break-catch-throw.c: Sort headers.
10107         * break-catch-syscall.c: Sort headers.
10108         * break-catch-sig.c: Sort headers.
10109         * blockframe.c: Sort headers.
10110         * block.c: Sort headers.
10111         * bfin-tdep.c: Sort headers.
10112         * bfin-linux-tdep.c: Sort headers.
10113         * bfd-target.c: Sort headers.
10114         * bcache.c: Sort headers.
10115         * ax-general.c: Sort headers.
10116         * ax-gdb.h: Sort headers.
10117         * ax-gdb.c: Sort headers.
10118         * avr-tdep.c: Sort headers.
10119         * auxv.c: Sort headers.
10120         * auto-load.c: Sort headers.
10121         * arm-wince-tdep.c: Sort headers.
10122         * arm-tdep.c: Sort headers.
10123         * arm-symbian-tdep.c: Sort headers.
10124         * arm-pikeos-tdep.c: Sort headers.
10125         * arm-obsd-tdep.c: Sort headers.
10126         * arm-nbsd-tdep.c: Sort headers.
10127         * arm-nbsd-nat.c: Sort headers.
10128         * arm-linux-tdep.c: Sort headers.
10129         * arm-linux-nat.c: Sort headers.
10130         * arm-fbsd-tdep.c: Sort headers.
10131         * arm-fbsd-nat.c: Sort headers.
10132         * arm-bsd-tdep.c: Sort headers.
10133         * arch-utils.c: Sort headers.
10134         * arc-tdep.c: Sort headers.
10135         * arc-newlib-tdep.c: Sort headers.
10136         * annotate.h: Sort headers.
10137         * annotate.c: Sort headers.
10138         * amd64-windows-tdep.c: Sort headers.
10139         * amd64-windows-nat.c: Sort headers.
10140         * amd64-tdep.c: Sort headers.
10141         * amd64-sol2-tdep.c: Sort headers.
10142         * amd64-obsd-tdep.c: Sort headers.
10143         * amd64-obsd-nat.c: Sort headers.
10144         * amd64-nbsd-tdep.c: Sort headers.
10145         * amd64-nbsd-nat.c: Sort headers.
10146         * amd64-nat.c: Sort headers.
10147         * amd64-linux-tdep.c: Sort headers.
10148         * amd64-linux-nat.c: Sort headers.
10149         * amd64-fbsd-tdep.c: Sort headers.
10150         * amd64-fbsd-nat.c: Sort headers.
10151         * amd64-dicos-tdep.c: Sort headers.
10152         * amd64-darwin-tdep.c: Sort headers.
10153         * amd64-bsd-nat.c: Sort headers.
10154         * alpha-tdep.c: Sort headers.
10155         * alpha-obsd-tdep.c: Sort headers.
10156         * alpha-nbsd-tdep.c: Sort headers.
10157         * alpha-mdebug-tdep.c: Sort headers.
10158         * alpha-linux-tdep.c: Sort headers.
10159         * alpha-linux-nat.c: Sort headers.
10160         * alpha-bsd-tdep.c: Sort headers.
10161         * alpha-bsd-nat.c: Sort headers.
10162         * aix-thread.c: Sort headers.
10163         * agent.c: Sort headers.
10164         * addrmap.c: Sort headers.
10165         * ada-varobj.c: Sort headers.
10166         * ada-valprint.c: Sort headers.
10167         * ada-typeprint.c: Sort headers.
10168         * ada-tasks.c: Sort headers.
10169         * ada-lang.c: Sort headers.
10170         * aarch64-tdep.c: Sort headers.
10171         * aarch64-ravenscar-thread.c: Sort headers.
10172         * aarch64-newlib-tdep.c: Sort headers.
10173         * aarch64-linux-tdep.c: Sort headers.
10174         * aarch64-linux-nat.c: Sort headers.
10175         * aarch64-fbsd-tdep.c: Sort headers.
10176         * aarch64-fbsd-nat.c: Sort headers.
10177         * aarch32-linux-nat.c: Sort headers.
10178
10179 2019-04-04  Tom Tromey  <tom@tromey.com>
10180
10181         * varobj.c (varobj_create): Update.
10182         * rust-exp.y (struct rust_parser) <update_innermost_block,
10183         lookup_symbol>: New methods.
10184         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10185         Rename.
10186         (rust_parser::rust_lookup_type)
10187         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10188         * printcmd.c (display_command, do_one_display): Update.
10189         * parser-defs.h (struct parser_state) <parser_state>: Add
10190         "tracker" parameter.
10191         (block_tracker): New member.
10192         (class innermost_block_tracker) <innermost_block_tracker>: Add
10193         "types" parameter.
10194         <reset>: Remove method.
10195         (innermost_block): Don't declare.
10196         (null_post_parser): Update.
10197         * parse.c (innermost_block): Remove global.
10198         (write_dollar_variable): Update.
10199         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10200         Remove "tracker_types" parameter.
10201         (parse_expression): Add "tracker" parameter.
10202         (parse_expression_for_completion): Update.
10203         (null_post_parser): Add "tracker" parameter.
10204         * p-exp.y: Update rules.
10205         * m2-exp.y: Update rules.
10206         * language.h (struct language_defn) <la_post_parser>: Add
10207         "tracker" parameter.
10208         * go-exp.y: Update rules.
10209         * f-exp.y: Update rules.
10210         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10211         parameter.
10212         * d-exp.y: Update rules.
10213         * c-exp.y: Update rules.
10214         * breakpoint.c (set_breakpoint_condition): Create an
10215         innermost_block_tracker.
10216         (watch_command_1): Likewise.
10217         * ada-lang.c (resolve): Add "tracker" parameter.
10218         (resolve_subexp): Likewise.
10219         * ada-exp.y (write_var_from_sym): Update.
10220
10221 2019-04-04  Tom Tromey  <tom@tromey.com>
10222
10223         * type-stack.h: New file.
10224         * type-stack.c: New file.
10225         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10226         type-stack.h.
10227         (insert_into_type_stack, insert_type, push_type, push_type_int)
10228         (insert_type_address_space, pop_type, pop_type_int)
10229         (pop_typelist, pop_type_stack, append_type_stack)
10230         (push_type_stack, get_type_stack, push_typelist)
10231         (follow_type_instance_flags, follow_types): Don't declare.
10232         * parse.c (type_stack): Remove global.
10233         (parse_exp_in_context): Update.
10234         (insert_into_type_stack, insert_type, push_type, push_type_int)
10235         (insert_type_address_space, pop_type, pop_type_int)
10236         (pop_typelist, pop_type_stack, append_type_stack)
10237         (push_type_stack, get_type_stack, push_typelist)
10238         (follow_type_instance_flags, follow_types): Remove (moved to
10239         type-stack.c).
10240         * f-exp.y (type_stack): New global.
10241         Update rules.
10242         (push_kind_type, f_parse): Update.
10243         * d-exp.y (type_stack): New global.
10244         Update rules.
10245         (d_parse): Update.
10246         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10247         Update rules.
10248         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10249         (HFILES_NO_SRCDIR): Add type-stack.h.
10250
10251 2019-04-04  Tom Tromey  <tom@tromey.com>
10252
10253         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10254         (rust_parser::convert_ast_to_expression, rust_parse)
10255         (rust_lex_test_completion, rust_lex_tests): Update.
10256         * parser-defs.h (struct expr_completion_state): New.
10257         (struct parser_state) <parser_state>: Add completion parameter.
10258         <mark_struct_expression, mark_completion_tag>: New methods.
10259         <parse_completion, m_completion_state>: New members.
10260         (prefixify_expression, null_post_parser): Update.
10261         (mark_struct_expression, mark_completion_tag): Don't declare.
10262         * parse.c (parse_completion, expout_last_struct)
10263         (expout_tag_completion_type, expout_completion_name): Remove
10264         globals.
10265         (parser_state::mark_struct_expression)
10266         (parser_state::mark_completion_tag): Now methods.
10267         (prefixify_expression): Add last_struct parameter.
10268         (prefixify_subexp): Likewise.
10269         (parse_exp_1): Update.
10270         (parse_exp_in_context): Add cstate parameter.  Update.
10271         (parse_expression_for_completion): Create an
10272         expr_completion_state.
10273         (null_post_parser): Add "completion" parameter.
10274         * p-exp.y: Update rules.
10275         (yylex): Update.
10276         * language.h (struct language_defn) <la_post_parser>: Add
10277         "completing" parameter.
10278         * go-exp.y: Update rules.
10279         (lex_one_token): Update.
10280         * expression.h (parse_completion): Don't declare.
10281         * d-exp.y: Update rules.
10282         (lex_one_token): Update rules.
10283         * c-exp.y: Update rules.
10284         (lex_one_token): Update.
10285         * ada-lang.c (resolve): Add "parse_completion" parameter.
10286         (resolve_subexp): Likewise.
10287         (ada_resolve_function): Likewise.
10288
10289 2019-04-04  Tom Tromey  <tom@tromey.com>
10290
10291         * parser-defs.h (struct parser_state) <start_arglist,
10292         end_arglist>: New methods.
10293         <arglist_len, m_funcall_chain>: New members.
10294         (arglist_len, start_arglist, end_arglist): Don't declare.
10295         * parse.c (arglist_len, funcall_chain): Remove global.
10296         (start_arglist, end_arglist): Remove functions.
10297         (parse_exp_in_context): Update.
10298         * p-exp.y: Update rules.
10299         * m2-exp.y: Update rules.
10300         * go-exp.y: Update rules.
10301         * f-exp.y: Update rules.
10302         * d-exp.y: Update rules.
10303         * c-exp.y: Update rules.
10304
10305 2019-04-04  Tom Tromey  <tom@tromey.com>
10306
10307         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10308         lex_operator, push_back>: New methods.
10309         Update all rules.
10310         (rust_parser::lex_hex, lex_escape): Rename and update.
10311         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10312         (rust_parser::lex_operator): Rename and update.
10313         (rust_parser::lex_number, rustyylex, rustyyerror)
10314         (rust_lex_test_init, rust_lex_test_sequence)
10315         (rust_lex_test_push_back, rust_lex_tests): Update.
10316         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10317         parameter.
10318         <lexptr, prev_lexptr>: New members.
10319         (lexptr, prev_lexptr): Don't declare.
10320         * parse.c (lexptr, prev_lexptr): Remove globals.
10321         (parse_exp_in_context): Update.
10322         * p-exp.y (yylex, yyerror): Update.
10323         * m2-exp.y (parse_number, yylex, yyerror): Update.
10324         * go-exp.y (lex_one_token, yyerror): Update.
10325         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10326         * d-exp.y (lex_one_token, yyerror): Update.
10327         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10328         (lex_one_token, yyerror): Update.
10329         * ada-lex.l (YY_INPUT): Update.
10330         (rewind_to_char): Update.
10331         * ada-exp.y (yyerror): Update.
10332
10333 2019-04-04  Tom Tromey  <tom@tromey.com>
10334
10335         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10336         * parser-defs.h (struct parser_state) <parser_state>: Add new
10337         parameter.
10338         <comma_terminates>: New member.
10339         (comma_terminates): Don't declare global.
10340         * parse.c (comma_terminates): Remove global.
10341         (parse_exp_in_context): Update.
10342         * p-exp.y (yylex): Update.
10343         * m2-exp.y (yylex): Update.
10344         * go-exp.y (lex_one_token): Update.
10345         * f-exp.y (yylex): Update.
10346         * d-exp.y (lex_one_token): Update.
10347         * c-exp.y (lex_one_token): Update.
10348         * ada-lex.l: Update.
10349
10350 2019-04-04  Tom Tromey  <tom@tromey.com>
10351
10352         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10353         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10354         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10355         * parser-defs.h (paren_depth): Don't declare.
10356         * parse.c (paren_depth): Remove global.
10357         (parse_exp_in_context): Update.
10358         * p-exp.y (paren_depth): New global.
10359         (pascal_parse): Initialize it.
10360         * m2-exp.y (paren_depth): New global.
10361         (m2_parse): Initialize it.
10362         * go-exp.y (paren_depth): New global.
10363         (go_parse): Initialize it.
10364         * f-exp.y (paren_depth): New global.
10365         (f_parse): Initialize it.
10366         * d-exp.y (paren_depth): New global.
10367         (d_parse): Initialize it.
10368         * c-exp.y (paren_depth): New global.
10369         (c_parse): Initialize it.
10370         * ada-lex.l (paren_depth): New global.
10371         (lexer_init): Initialize it.
10372
10373 2019-04-04  Tom Tromey  <tom@tromey.com>
10374
10375         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10376         (rust_parser::convert_ast_to_type)
10377         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10378         * parser-defs.h (struct parser_state) <parser_state>: Add
10379         parameters.  Initialize new members.
10380         <expression_context_block, expression_context_pc>: New members.
10381         * parse.c (expression_context_block, expression_context_pc):
10382         Remove globals.
10383         (parse_exp_in_context): Update.
10384         * p-exp.y: Update all rules.
10385         (yylex): Update.
10386         * m2-exp.y: Update all rules.
10387         (yylex): Update.
10388         * go-exp.y (yylex): Update.
10389         * f-exp.y (yylex): Update.
10390         * d-exp.y: Update all rules.
10391         (yylex): Update.
10392         * c-exp.y: Update all rules.
10393         (lex_one_token, classify_name, yylex, c_parse): Update.
10394         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10395
10396 2019-04-04  Tom Tromey  <tom@tromey.com>
10397
10398         * gdbarch.h, gdbarch.c: Rebuild.
10399         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10400         * stap-probe.h:
10401         (struct stap_parse_info): Replace "parser_state" with
10402         "expr_builder".
10403         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10404         (parser_state): New class.
10405         * parse.c (expr_builder): Rename.
10406         (expr_builder::release): Rename.
10407         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10408         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10409         (write_exp_elt_longcst, write_exp_elt_floatcst)
10410         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10411         (write_exp_string_vector, write_exp_bitstring)
10412         (write_exp_msymbol, mark_struct_expression)
10413         (write_dollar_variable)
10414         (insert_type_address_space, increase_expout_size): Replace
10415         "parser_state" with "expr_builder".
10416         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10417         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10418         "parser_state" with "expr_builder".
10419
10420 2019-04-04  Tom Tromey  <tom@tromey.com>
10421
10422         * rust-exp.y: Replace "parse_language" with method call.
10423         * p-exp.y:
10424         (yylex): Replace "parse_language" with method call.
10425         * m2-exp.y:
10426         (yylex): Replace "parse_language" with method call.
10427         * go-exp.y (classify_name): Replace "parse_language" with method
10428         call.
10429         * f-exp.y (yylex): Replace "parse_language" with method call.
10430         * d-exp.y (lex_one_token): Replace "parse_language" with method
10431         call.
10432         * c-exp.y:
10433         (lex_one_token, classify_name, yylex): Replace "parse_language"
10434         with method call.
10435         * ada-exp.y (find_primitive_type, type_char)
10436         (type_system_address): Replace "parse_language" with method call.
10437
10438 2019-04-04  Tom Tromey  <tom@tromey.com>
10439
10440         * rust-exp.y: Replace "parse_gdbarch" with method call.
10441         * parse.c (write_dollar_variable, insert_type_address_space):
10442         Replace "parse_gdbarch" with method call.
10443         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10444         call.
10445         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10446         call.
10447         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10448         "parse_gdbarch" with method call.
10449         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10450         with method call.
10451         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10452         "parse_gdbarch" with method call.
10453         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10454         "parse_gdbarch" with method call.
10455         * c-exp.y (parse_type, parse_number, classify_name): Replace
10456         "parse_gdbarch" with method call.
10457         * ada-lex.l: Replace "parse_gdbarch" with method call.
10458         * ada-exp.y (parse_type, find_primitive_type, type_char)
10459         (type_system_address): Replace "parse_gdbarch" with method call.
10460
10461 2019-04-04  Tom Tromey  <tom@tromey.com>
10462
10463         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10464         * stap-probe.c (stap_parse_argument): Update.
10465         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10466         initial_size parameter.
10467         * rust-exp.y (rust_lex_tests): Update.
10468         * parse.c (parser_state): Update.
10469         (parse_exp_in_context): Update.
10470         * parser-defs.h (struct parser_state) <parser_state>: Remove
10471         "initial_size" parameter.
10472
10473 2019-04-04  Tom Tromey  <tom@tromey.com>
10474
10475         * parser-defs.h (increase_expout_size): Don't declare.
10476         * parse.c (increase_expout_size): Now static.
10477
10478 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10479
10480         * gnu-nat.c (gnu_nat_target::wait): Fix
10481         target_waitstatus_to_string call.
10482
10483 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * eval.c (evaluate_subexp_standard): Handle internal functions
10486         during Fortran function call handling.
10487
10488 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10489
10490         * NEWS: Mention new internal functions.
10491         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10492         (read_base_type): Use dwarf2_init_complex_target_type.
10493         * value.c (creal_internal_fn): New function.
10494         (cimag_internal_fn): New function.
10495         (_initialize_values): Register new internal functions.
10496
10497 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10498
10499         * infrun.c (stop_all_threads): If debug_infrun, always
10500         trace the wait status after wait_one, using
10501         target_waitstatus_to_string and target_pid_to_str.
10502         (handle_inferior_event): Replace various trace of
10503         wait status kind by a single trace.
10504         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10505         wait status kind image by target_waitstatus_to_string.
10506         * target/waitstatus.c (target_waitstatus_to_string): Fix
10507         obsolete comment.
10508
10509 2019-04-01  Tom Tromey  <tromey@adacore.com>
10510
10511         PR symtab/23331:
10512         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10513
10514 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10515             Pedro Alves  <palves@redhat.com>
10516
10517         * top.c (quit_force): Call 'finalize_values'.
10518         * value.c (finalize_values): New function.
10519         * value.h (finalize_values): Declare.
10520
10521 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10522
10523         * NEWS: Announce $_gdb_major and $_gdb_minor.
10524
10525         * top.c (init_gdb_version_vars): New function.
10526         (gdb_init): Call init_gdb_version_vars.
10527
10528 2019-03-29  Tom Tromey  <tromey@adacore.com>
10529
10530         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10531         help text.  Remove dead code.
10532
10533 2019-03-29  Keith Seitz  <keiths@redhat.com>
10534
10535         From Siddhesh Poyarekar:
10536         * f-lang.h (f77_get_upperbound): Return LONGEST.
10537         (f77_get_lowerbound): Likewise.
10538         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10539         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10540         print them.
10541         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10542         plongest to format print it.
10543         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10544         (f77_get_upperbound): Likewise.
10545         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10546         LOWER_BOUND to LONGEST.
10547         (f77_create_arrayprint_offset_tbl): Likewise.
10548
10549 2019-03-29  Keith Seitz  <keiths@redhat.com>
10550
10551         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10552         %s/pulongest for TYPE_LENGTH instead of %d in format
10553         strings.
10554         * ada-typerint.c (ada_print_type): Likewise.
10555         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10556         * compile/compile-c-support.c (generate_register_struct): Likewise.
10557         * gdbtypes.c (recursive_dump_type): Likewise.
10558         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10559         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10560         instead of %d in format strings.
10561         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10562         to std::min to ULONGEST.
10563         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10564         instead of %d in format strings.
10565         * tracepoint.c (info_scope_command): Likewise.
10566         * typeprint.c (print_offset_data::update)
10567         (print_offset_data::finish): Likewise.
10568         * xtensa-tdep.c (xtensa_store_return_value)
10569         (xtensa_push_dummy_call): Likewise.
10570
10571 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10572
10573         * windows-nat.c (display_selector): Fixed format specifications
10574         for 64-bit Cygwin.
10575
10576 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10577
10578         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10579
10580 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10581
10582         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10583         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10584         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10585         (nios2_linux_init_abi): Install it.
10586
10587 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10588
10589         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10590
10591 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10592
10593         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10594
10595 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10596             Tom Tromey  <tromey@adacore.com>
10597
10598         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10599
10600 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10601
10602         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10603         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10604         method to compute the bounds of range types. Also print "[evaluated]"
10605         if the bounds' values come from a dynamic evaluation.
10606
10607 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10608
10609         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10610         whitespace when pretty printing is on.
10611
10612 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10613
10614         * ppc-linux-nat.c: Add include.
10615
10616 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10617
10618         * NEWS: Mention AArch64 Pointer Authentication.
10619
10620 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10621
10622         * arm-linux-nat.c: Add include.
10623
10624 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10625
10626         * source-cache.c (source_cache::get_source_lines): Re-read
10627         fullname after calling open_source_file.
10628
10629 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10630
10631         * NEWS: Mention TLS support for FreeBSD.
10632
10633 2019-03-25  Tom Tromey  <tromey@adacore.com>
10634
10635         * minsyms.c (BUNCH_SIZE): Update comment.
10636         (~minimal_symbol_reader): Remove old comment.
10637         (compact_minimal_symbols): Update comment.
10638         (minimal_symbol_reader::install): Remove old comment.  Update
10639         other comments.
10640
10641 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10642
10643         * s390-linux-nat.c: Add include.
10644
10645 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10646
10647         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10648         Call linux_get_hwcap.
10649         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10650         Likewise.
10651         (aarch64_linux_get_hwcap): Remove function.
10652         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10653         declaration.
10654         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10655         linux_get_hwcap.
10656         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10657         * linux-tdep.c (linux_get_hwcap): Add function.
10658         (linux_get_hwcap2): Likewise.
10659         * linux-tdep.h (linux_get_hwcap): Add declaration.
10660         (linux_get_hwcap2): Likewise.
10661         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10662         (ppc_linux_get_hwcap2): Likewise.
10663         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10664         linux_get_hwcap.
10665         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10666         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10667         (ppc_linux_nat_target::read_description): Likewise.
10668         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10669         * s390-linux-nat.c: Likewise.
10670         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10671
10672 2019-03-24  Tom Tromey  <tom@tromey.com>
10673
10674         * ada-lang.c (standard_lookup): Simplify initialization.
10675         (ada_lookup_symbol_nonlocal): Simplify return.
10676         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10677         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10678         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10679         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10680         initialization.
10681         * solib.c (solib_global_lookup): Simplify.
10682         * symtab.c (null_block_symbol): Remove.
10683         (symbol_cache_lookup): Simplify returns.
10684         (lookup_language_this): Simplify returns.
10685         (lookup_symbol_aux): Simplify return.
10686         (lookup_local_symbol): Simplify returns.
10687         (lookup_global_symbol_from_objfile): Simplify return.
10688         (lookup_symbol_in_objfile_symtabs)
10689         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10690         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10691         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10692         * cp-namespace.c (cp_lookup_bare_symbol)
10693         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10694         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10695         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10696         (cp_lookup_symbol_via_imports): Simplify initialization.
10697         (find_symbol_in_baseclass): Likewise.
10698         * symtab.h (null_block_symbol): Remove.
10699         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10700         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10701         (d_lookup_symbol_module): Likewise.
10702         (find_symbol_in_baseclass): Simplify initialization.
10703
10704 2019-03-24  Tom Tromey  <tom@tromey.com>
10705
10706         * expression.h: Don't include symtab.h.
10707         (struct block): Forward declare.
10708
10709 2019-03-24  Tom Tromey  <tom@tromey.com>
10710
10711         * c-exp.y (typebase): Remove casts.
10712         * gdbtypes.c (lookup_unsigned_typename, )
10713         (lookup_signed_typename): Remove cast.
10714         * eval.c (parse_to_comma_and_eval): Remove cast.
10715         * parse.c (write_dollar_variable): Remove cast.
10716         * block.h (struct block) <superblock>: Now const.
10717         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10718         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10719         (map_block): Make "block" const.
10720         * symfile.h (struct quick_symbol_functions)
10721         <map_matching_symbols>: Constify block argument to "callback".
10722         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10723         const.
10724         (find_pc_sect_compunit_symtab): Make "b" const.
10725         (find_symbol_at_address): Likewise.
10726         (search_symbols): Likewise.
10727         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10728         (dw2_debug_names_lookup_symbol): Likewise.
10729         (dw2_map_matching_symbols): Update.
10730         * p-valprint.c (pascal_val_print): Remove "block".
10731         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10732         (aux_add_nonlocal_symbols): Make "block" const.
10733         (resolve_subexp): Remove cast.
10734         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10735         const.
10736         (iterate_over_file_blocks): Likewise.
10737         * f-exp.y (%union) <bval>: Remove.
10738         * coffread.c (patch_opaque_types): Make "b" const.
10739         * spu-tdep.c (spu_catch_start): Make "block" const.
10740         * c-valprint.c (print_unpacked_pointer): Remove "block".
10741         * symmisc.c (dump_symtab_1): Make "b" const.
10742         (block_depth): Make "block" const.
10743         * d-exp.y (%union) <bval>: Remove.
10744         * cp-support.h (cp_lookup_rtti_type): Update.
10745         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10746         * psymtab.c (psym_lookup_symbol): Make "block" const.
10747         (maintenance_check_psymtabs): Make "b" const.
10748         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10749         (enumerate_locals, enumerate_args): Update.
10750         * python/py-symtab.c (stpy_global_block): Make "block" const.
10751         (stpy_static_block): Likewise.
10752         * inline-frame.c (block_starting_point_at): Make "new_block"
10753         const.
10754         * block.c (find_block_in_blockvector): Make return type const.
10755         (blockvector_for_pc_sect): Make "b" const.
10756         (find_block_in_blockvector): Make "b" const.
10757
10758 2019-03-23  Tom Tromey  <tom@tromey.com>
10759
10760         * varobj.c (varobj_create): Update.
10761         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10762         * printcmd.c (display_command, do_one_display): Don't reset
10763         innermost_block.
10764         * parser-defs.h (enum innermost_block_tracker_type): Move to
10765         expression.h.
10766         (innermost_block): Update comment.
10767         * parse.c (parse_exp_1): Add tracker_types parameter.
10768         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10769         tracker_types parameter.  Reset innermost_block.
10770         (parse_exp_in_context): Remove.
10771         (parse_expression_for_completion): Update.
10772         * objfiles.c (~objfile): Don't reset expression_context_block or
10773         innermost_block.
10774         * expression.h (enum innermost_block_tracker_type): Move from
10775         parser-defs.h.
10776         (parse_exp_1): Add tracker_types parameter.
10777         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10778         reset innermost_block.
10779
10780 2019-03-23  Tom Tromey  <tom@tromey.com>
10781
10782         * objfiles.h: Include bcache.h.
10783
10784 2019-03-23  Tom Tromey  <tom@tromey.com>
10785
10786         * linespec.c (get_current_search_block): Use
10787         scoped_restore_current_language.
10788         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10789
10790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10791             Jiong Wang  <jiong.wang@arm.com>
10792
10793         * aarch64-linux-tdep.c
10794         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10795         section.
10796         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10797
10798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10799             Jiong Wang  <jiong.wang@arm.com>
10800
10801         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10802         instructions.
10803         (aarch64_analyze_prologue_test): Add PACIASP test.
10804         (aarch64_prologue_prev_register): Unmask PC value.
10805
10806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10807             Jiong Wang  <jiong.wang@arm.com>
10808
10809         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10810         (aarch64_dwarf2_prev_register): Unmask PC value.
10811         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10812         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10813         DW_CFA_AARCH64_negate_ra_state.
10814         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10815
10816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10817             Jiong Wang  <jiong.wang@arm.com>
10818
10819         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10820         registers.
10821         (aarch64_pseudo_register_name): Likewise.
10822         (aarch64_pseudo_register_type): Likewise.
10823         (aarch64_pseudo_register_reggroup_p): Likewise.
10824         (aarch64_gdbarch_init): Add pauth registers.
10825         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10826         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10827         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10828         (struct gdbarch_tdep): Add regnum for ra_state.
10829
10830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10831             Jiong Wang  <jiong.wang@arm.com>
10832
10833         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10834
10835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10836             Jiong Wang  <jiong.wang@arm.com>
10837
10838         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10839         function.
10840         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10841         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10842         (aarch64_gdbarch_init): Add puth registers.
10843         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10844         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10845         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10846
10847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10848             Jiong Wang  <jiong.wang@arm.com>
10849
10850         * aarch64-linux-nat.c
10851         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10852         * aarch64-linux-tdep.c
10853         (aarch64_linux_core_read_description): Likewise.
10854         (aarch64_linux_get_hwcap): New function.
10855         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10856         (aarch64_linux_get_hwcap): New declaration.
10857
10858 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10859             Jiong Wang  <jiong.wang@arm.com>
10860
10861         * aarch64-linux-nat.c
10862         (aarch64_linux_nat_target::read_description): Add pauth param.
10863         * aarch64-linux-tdep.c
10864         (aarch64_linux_core_read_description): Likewise.
10865         * aarch64-tdep.c (struct target_desc): Add in pauth.
10866         (aarch64_read_description): Add pauth param.
10867         (aarch64_gdbarch_init): Likewise.
10868         * aarch64-tdep.h (aarch64_read_description): Likewise.
10869         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10870         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10871         * features/Makefile: Add new files.
10872         * features/aarch64-pauth.c: New file.
10873         * features/aarch64-pauth.xml: New file.
10874
10875 2019-03-20  Tom Tromey  <tromey@adacore.com>
10876
10877         * infrun.c (handle_inferior_event): Rename from
10878         handle_inferior_event_1.  Create a scoped_value_mark.
10879         (handle_inferior_event): Remove.
10880
10881 2019-03-19  Tom Tromey  <tromey@adacore.com>
10882
10883         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10884         * infrun.h (print_stop_event): Add "displays" parameter.
10885         * infrun.c (print_stop_event): Add "displays" parameter.
10886
10887 2019-03-19  Pedro Alves  <palves@redhat.com>
10888
10889         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10890         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10891         to -1.  Fix TABs vs spaces.
10892         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10893         * tui/tui-out.h (tui_ui_out) Add intro comments.
10894         <m_line, m_start_of_line>: In-class initialize, and add describing
10895         comment.
10896
10897 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10898
10899         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10900         variable names.
10901         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10902
10903 2019-03-18  Pedro Alves  <palves@redhat.com>
10904             Eli Zaretskii <eliz@gnu.org>
10905
10906         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10907         m_line and m_start_of_line.
10908
10909 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10910
10911         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10912         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10913         it returns a newline.  This fixes a regression in TU mode, whereby
10914         the next line is output on the same screen line as the user input.
10915
10916 2019-03-18  Tom Tromey  <tromey@adacore.com>
10917
10918         * minsyms.c (minimal_symbol_reader::install): Remove call to
10919         obstack_blank.
10920
10921 2019-03-18  Pedro Alves  <palves@redhat.com>
10922
10923         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10924         New globals.
10925         (apply_style): New, factored out from ...
10926         (apply_ansi_escape): ... this.  Handle reverse video mode.
10927         (tui_set_reverse_mode): New function.
10928         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10929         * tui/tui-winsource.c (tui_show_source_line): Use
10930         tui_set_reverse_mode instead of setting A_STANDOUT.
10931         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10932         New setter methods.
10933
10934 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10935
10936         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10937         Handle tabs.
10938
10939 2019-03-18  Tom Tromey  <tromey@adacore.com>
10940
10941         * ada-lang.c (empty_array): Add "high" parameter.
10942         (ada_evaluate_subexp): Update.
10943
10944 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10945
10946         * unittests/string_view-selftests.c: Define
10947         _initialize_string_view_selftests unconditionally.
10948
10949 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10950
10951         PR gdb/24350
10952         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10953
10954 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10955
10956         PR gdb/24351
10957         * windows-nat.c (display_selector): Fix format specifiers.
10958
10959 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10960
10961         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10962         tui_refill_source_window instead of tui_refresh_win, to update the
10963         current execution line.  This fixes redisplay of the current line
10964         when stepping through the code with "next" or "step".
10965
10966 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10967
10968         * source-cache.c (source_cache::get_source_lines): Call
10969         find_source_lines to initialize s->nlines.  This fixes vertical
10970         scrolling of TUI source window when the DOWN arrow is pressed.
10971
10972 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10973
10974         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10975         linux-thread-db.c (_initialize_thread_db): Likewise.
10976
10977 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10978
10979         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10980         wclrtoeol in tui_show_source_line".  This reverts changes made in
10981         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10982
10983 2019-03-15  Tom Tromey  <tom@tromey.com>
10984
10985         * symtab.h (struct minimal_symbol): Derive from
10986         general_symbol_info.
10987         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10988         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10989         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10990         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10991         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10992         (MSYMBOL_SEARCH_NAME): Update.
10993         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10994         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10995         * minsyms.c (minimal_symbol_reader::record_full): Update.
10996
10997 2019-03-15  Tom Tromey  <tom@tromey.com>
10998
10999         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11000
11001 2019-03-15  Tom Tromey  <tom@tromey.com>
11002
11003         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11004         unique_xmalloc_ptr.
11005         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11006         Update.
11007         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11008         (build_minimal_symbol_hash_tables)
11009         (minimal_symbol_reader::install): Update.
11010
11011 2019-03-15  Tom Tromey  <tom@tromey.com>
11012
11013         * symtab.c (create_demangled_names_hash): Update.
11014         (symbol_set_names): Update.
11015         * objfiles.h (struct objfile_per_bfd_storage)
11016         <demangled_names_hash>: Now an htab_up.
11017         * objfiles.c (objfile_per_bfd_storage): Simplify.
11018
11019 2019-03-15  Tom Tromey  <tom@tromey.com>
11020
11021         * objfiles.h (struct objfile_per_bfd_storage): Declare
11022         destructor.
11023         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11024         New.
11025         (get_objfile_bfd_data): Use new.  Don't initialize
11026         language_of_main.
11027         (free_objfile_per_bfd_storage): Remove.
11028         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11029
11030 2019-03-15  Tom Tromey  <tom@tromey.com>
11031
11032         * symfile.c (reread_symbols): Update.
11033         * objfiles.c (objfile::objfile): Update.
11034         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11035         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11036         comment.
11037         (minimal_symbol_reader::install): Update.
11038         (terminate_minimal_symbol_table): Remove.
11039         * jit.c (jit_object_close_impl): Update.
11040
11041 2019-03-15  Tom Tromey  <tom@tromey.com>
11042
11043         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11044         initializations.
11045
11046 2019-03-15  Tom Tromey  <tom@tromey.com>
11047
11048         * objfiles.h (struct objfile_per_bfd_storage)
11049         <demangled_hash_languages>: Now a bitset.
11050         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11051         (lookup_minimal_symbol): Update.
11052
11053 2019-03-15  Tom Tromey  <tom@tromey.com>
11054
11055         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11056         Don't return the symbol.
11057         * coffread.c (record_minimal_symbol): Use record_full.
11058
11059 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11060
11061         The MS-Windows port of ncurses fails to switch to a color pair if
11062         one or both of the colors are the implicit default colors.  This
11063         change records the default colors when TUI is initialized, and
11064         then specifies them explicitly when a color pair uses the default
11065         colors.  This allows color styling in TUI mode on MS-Windows.
11066
11067         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11068         ncurses_norm_attr.
11069         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11070         colors in ncurses_norm_attr.
11071         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11072         "none", replace it with the default color recorded in
11073         ncurses_norm_attr.
11074
11075 2019-03-14  Tom Tromey  <tromey@adacore.com>
11076
11077         * source-cache.h (class source_cache) <get_source_lines>: Return
11078         std::string.
11079         * source-cache.c (source_cache::extract_lines): Handle case where
11080         first_pos==npos.  Return std::string.
11081         (source_cache::get_source_lines): Update.
11082
11083 2019-03-14  Tom Tromey  <tromey@adacore.com>
11084
11085         * NEWS: Add item for "style sources" commands.
11086         * source-cache.c (source_cache::get_source_lines): Check
11087         source_styling.
11088         * cli/cli-style.c (source_styling): New global.
11089         (_initialize_cli_style): Add "style sources" commands.
11090         (show_style_sources): New function.
11091         * cli/cli-style.h (source_styling): Declare.
11092
11093 2019-03-14  Pedro Alves  <palves@redhat.com>
11094             Tom Tromey  <tromey@adacore.com>
11095
11096         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11097         * tui/tui-winsource.c (tui_refill_source_window): New function,
11098         from...
11099         (tui_horizontal_source_scroll): ... here.  Move some logic.
11100         * cli/cli-style.c (set_style_enabled): Notify new observable.
11101         * tui/tui-hooks.c (tui_redisplay_source): New function.
11102         (tui_attach_detach_observers): Attach or detach
11103         tui_redisplay_source.
11104         * observable.h (source_styling_changed): New observable.
11105         * observable.c: Define source_styling_changed observable.
11106
11107 2019-03-13  Tom Tromey  <tromey@adacore.com>
11108
11109         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11110         (i386_gnu_nat_target::store_registers): Update.
11111         * target-debug.h (target_debug_print_std_string): New macro.
11112         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11113         * windows-tdep.c (display_one_tib): Update.
11114         * tui/tui-stack.c (tui_make_status_line): Update.
11115         * top.c (print_inferior_quit_action): Update.
11116         * thread.c (thr_try_catch_cmd): Update.
11117         (add_thread_with_info): Update.
11118         (thread_target_id_str): Update.
11119         (thr_try_catch_cmd): Update.
11120         (thread_command): Update.
11121         (thread_find_command): Update.
11122         * record-btrace.c (record_btrace_target::info_record)
11123         (record_btrace_resume_thread, record_btrace_target::resume)
11124         (record_btrace_cancel_resume, record_btrace_step_thread)
11125         (record_btrace_target::wait, record_btrace_target::wait)
11126         (record_btrace_target::wait, record_btrace_target::stop): Update.
11127         * progspace.c (print_program_space): Update.
11128         * process-stratum-target.c
11129         (process_stratum_target::thread_address_space): Update.
11130         * linux-fork.c (linux_fork_mourn_inferior)
11131         (detach_checkpoint_command, info_checkpoints_command)
11132         (linux_fork_context): Update.
11133         (linux_fork_detach): Update.
11134         (class scoped_switch_fork_info): Update.
11135         (delete_checkpoint_command): Update.
11136         * infrun.c (follow_fork_inferior): Update.
11137         (follow_fork_inferior): Update.
11138         (proceed_after_vfork_done): Update.
11139         (handle_vfork_child_exec_or_exit): Update.
11140         (follow_exec): Update.
11141         (displaced_step_prepare_throw): Update.
11142         (displaced_step_restore): Update.
11143         (start_step_over): Update.
11144         (resume_1): Update.
11145         (clear_proceed_status_thread): Update.
11146         (proceed): Update.
11147         (print_target_wait_results): Update.
11148         (do_target_wait): Update.
11149         (context_switch): Update.
11150         (stop_all_threads): Update.
11151         (restart_threads): Update.
11152         (finish_step_over): Update.
11153         (handle_signal_stop): Update.
11154         (switch_back_to_stepped_thread): Update.
11155         (keep_going_pass_signal): Update.
11156         (print_exited_reason): Update.
11157         (normal_stop): Update.
11158         * inferior.c (inferior_pid_to_str): Change return type.
11159         (print_selected_inferior): Update.
11160         (add_inferior): Update.
11161         (detach_inferior): Update.
11162         * dummy-frame.c (fprint_dummy_frames): Update.
11163         * dcache.c (dcache_info_1): Update.
11164         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11165         (btrace_fetch, btrace_clear): Update.
11166         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11167         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11168         type.
11169         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11170         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11171         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11172         * gdbarch.c, gdbarch.h: Rebuild.
11173         * gdbarch.sh (core_pid_to_str): Change return type.
11174         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11175         return type.
11176         (windows_nat_target::pid_to_str): Change return type.
11177         (windows_delete_thread): Update.
11178         (windows_nat_target::attach): Update.
11179         (windows_nat_target::files_info): Update.
11180         * target-delegates.c: Rebuild.
11181         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11182         return type.
11183         (sol_thread_target::pid_to_str): Change return type.
11184         * remote.c (class remote_target) <pid_to_str>: Change return
11185         type.
11186         (remote_target::pid_to_str): Change return type.
11187         (extended_remote_target::attach, remote_target::remote_stop_ns)
11188         (remote_target::remote_notif_remove_queued_reply)
11189         (remote_target::push_stop_reply, remote_target::disable_btrace):
11190         Update.
11191         (extended_remote_target::attach): Update.
11192         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11193         type.
11194         (gdbsim_target::pid_to_str): Change return type.
11195         * ravenscar-thread.c (struct ravenscar_thread_target)
11196         <pid_to_str>: Change return type.
11197         (ravenscar_thread_target::pid_to_str): Change return type.
11198         * procfs.c (class procfs_target) <pid_to_str>: Change return
11199         type.
11200         (procfs_target::pid_to_str): Change return type.
11201         (procfs_target::attach): Update.
11202         (procfs_target::detach): Update.
11203         (procfs_target::fetch_registers): Update.
11204         (procfs_target::store_registers): Update.
11205         (procfs_target::wait): Update.
11206         (procfs_target::files_info): Update.
11207         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11208         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11209         return type.
11210         (nto_procfs_target::pid_to_str): Change return type.
11211         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11212         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11213         return type.
11214         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11215         (exit_lwp): Update.
11216         (attach_proc_task_lwp_callback, get_detach_signal)
11217         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11218         (linux_nat_target::resume, wait_lwp, stop_callback)
11219         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11220         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11221         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11222         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11223         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11224         type.
11225         (inf_ptrace_target::attach): Update.
11226         (inf_ptrace_target::files_info): Update.
11227         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11228         type.
11229         (go32_nat_target::pid_to_str): Change return type.
11230         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11231         (gnu_nat_target::wait): Update.
11232         (gnu_nat_target::wait): Update.
11233         (gnu_nat_target::resume): Update.
11234         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11235         (fbsd_nat_target::wait): Update.
11236         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11237         type.
11238         (darwin_nat_target::attach): Update.
11239         * corelow.c (class core_target) <pid_to_str>: Change return type.
11240         (core_target::pid_to_str): Change return type.
11241         * target.c (normal_pid_to_str): Change return type.
11242         (default_pid_to_str): Likewise.
11243         (target_pid_to_str): Change return type.
11244         (target_translate_tls_address): Update.
11245         (target_announce_detach): Update.
11246         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11247         return type.
11248         (bsd_uthread_target::pid_to_str): Change return type.
11249         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11250         type.
11251         (bsd_kvm_target::pid_to_str): Change return type.
11252         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11253         return type.
11254         (aix_thread_target::pid_to_str): Change return type.
11255         * target.h (struct target_ops) <pid_to_str>: Change return type.
11256         (target_pid_to_str, normal_pid_to_str): Likewise.
11257         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11258         type.
11259         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11260         type.
11261         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11262         return type.
11263         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11264         type.
11265         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11266         type.
11267         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11268         return type.
11269
11270 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11271
11272         * NEWS: Mention that the new default MI version is 3.  Mention
11273         changes to the output of commands and events that deal with
11274         multi-location breakpoints.
11275         * breakpoint.c: Include "mi/mi-out.h".
11276         (print_one_breakpoint): Change output syntax if using MI version
11277         >= 3.
11278         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11279         New.
11280         (mi_multi_location_breakpoint_output_fixed): New.
11281         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11282         (mi_cmd_fix_multi_location_breakpoint_output): New.
11283         (mi_multi_location_breakpoint_output_fixed): New.
11284         * mi/mi-cmds.c (mi_cmds): Register command
11285         -fix-multi-location-breakpoint-output.
11286         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11287         interpreter "mi".
11288
11289 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11290
11291         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11292         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11293         instantiate mi_ui_out based on interpreter name.
11294         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11295         * mi/mi-main.c (mi_load_progress): Likewise.
11296
11297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11298
11299         * NEWS: Combine separate "New targets" sections for 8.3.
11300
11301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11302
11303         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11304         (ppcfbsd_init_abi): Install gdbarch
11305         "fetch_tls_load_module_address" and "get_thread_local_address"
11306         methods.
11307
11308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11309
11310         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11311         (riscv_fbsd_init_abi): Install gdbarch
11312         "fetch_tls_load_module_address" and "get_thread_local_address"
11313         methods.
11314
11315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11316
11317         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11318         (i386fbsd_init_abi): Install gdbarch
11319         "fetch_tls_load_module_address" and "get_thread_local_address"
11320         methods.
11321
11322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11323
11324         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11325         (amd64fbsd_init_abi): Install gdbarch
11326         "fetch_tls_load_module_address" and "get_thread_local_address"
11327         methods.
11328
11329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11330
11331         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11332         (struct fbsd_pspace_data): New type.
11333         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11334         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11335         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11336         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11337         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11338
11339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11340
11341         * gdbtypes.c (lookup_struct_elt): New function.
11342         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11343         * gdbtypes.h (struct struct_elt): New type.
11344         (lookup_struct_elt): New prototype.
11345
11346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11347
11348         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11349         remove disabled code block.
11350
11351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11352
11353         * gdbarch.sh (get_thread_local_address): New method.
11354         * gdbarch.h, gdbarch.c: Regenerate.
11355         * target.c (target_translate_tls_address): Use
11356         gdbarch_get_thread_local_address if present instead of
11357         target::get_thread_local_address.
11358
11359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11360
11361         * target.h (target::get_thread_local_address): Update comment.
11362
11363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11364
11365         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11366         objfile->separate_debug_objfile_backlink if not NULL.
11367
11368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11369
11370         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11371         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11372         (amd64bsd_store_inferior_registers): Likewise.
11373         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11374         Enable segment base registers.
11375         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11376         PT_GETFSBASE and PT_GETGSBASE.
11377         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11378         PT_SETGSBASE.
11379         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11380         segment base registers.
11381         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11382
11383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11384
11385         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11386         Update calls to i386_target_description to add 'segments'
11387         parameter.
11388         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11389         add segment base registers.
11390         * arch/i386.c (i386_create_target_description): Add 'segments'
11391         parameter to enable segment base registers.
11392         * arch/i386.h (i386_create_target_description): Likewise.
11393         * features/i386/32bit-segments.xml: New file.
11394         * features/i386/32bit-segments.c: Generate.
11395         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11396         call to i386_target_description to add 'segments' parameter.
11397         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11398         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11399         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11400         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11401         if feature is present.
11402         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11403         Add 'segments' parameter to call to i386_target_description.
11404         (i386_target_description): Add 'segments' parameter to enable
11405         segment base registers.
11406         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11407         to call to i386_target_description.
11408         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11409         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11410         Define I386_NUM_REGS.
11411         (i386_target_description): Add 'segments' parameter to enable
11412         segment base registers.
11413
11414 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11415
11416         PR/24325
11417         * source-cache.c: #undef open and close, to avoid unresolved
11418         externals during linking.
11419
11420 2019-03-12  Tom Tromey  <tromey@adacore.com>
11421
11422         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11423         const.  Add initializers.
11424         (_initialize_remote): Don't initialize ptid globals.
11425
11426 2019-03-12  Pedro Alves  <palves@redhat.com>
11427
11428         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11429
11430 2019-03-12  Pedro Alves  <palves@redhat.com>
11431
11432         * cp-name-parser.y (main): Remove unused 'len' variable.
11433
11434 2019-03-12  Tom Tromey  <tromey@adacore.com>
11435
11436         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11437         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11438
11439 2019-03-12  Tom Tromey  <tromey@adacore.com>
11440
11441         * linux-nat.c (iterate_over_lwps): Update.
11442         (stop_callback): Remove parameter.
11443         (stop_wait_callback, detach_callback, resume_set_callback)
11444         (select_singlestep_lwp_callback, set_ignore_sigint)
11445         (status_callback, resumed_callback, resume_clear_callback)
11446         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11447         data parameter.
11448         (linux_nat_target::detach, linux_nat_target::resume)
11449         (linux_stop_and_wait_all_lwps, select_event_lwp)
11450         (linux_nat_filter_event, linux_nat_wait_1)
11451         (linux_nat_target::kill, linux_nat_target::stop)
11452         (linux_nat_target::stop): Update.
11453         (linux_nat_resume_callback): Change type.
11454         (resume_stopped_resumed_lwps, count_events_callback)
11455         (select_event_lwp_callback): Likewise.
11456         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11457         * arm-linux-nat.c (struct update_registers_data): Remove.
11458         (update_registers_callback): Change type.
11459         (arm_linux_insert_hw_breakpoint1): Update.
11460         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11461         parameter.
11462         (x86_linux_dr_set_addr): Update.
11463         (x86_linux_dr_set_control): Update.
11464         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11465         (iterate_over_lwps): Use gdb::function_view.
11466         * nat/aarch64-linux-hw-point.c (struct
11467         aarch64_dr_update_callback_param): Remove.
11468         (debug_reg_change_callback): Change type.
11469         (aarch64_notify_debug_reg_change): Update.
11470         * s390-linux-nat.c (s390_refresh_per_info): Update.
11471
11472 2019-03-11  Tom Tromey  <tromey@adacore.com>
11473
11474         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11475         redundant assignment to "this_cu".
11476
11477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11478
11479         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11480
11481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11482
11483         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11484         from...
11485         (rank_one_type): ... this.
11486
11487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11488
11489         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11490         from...
11491         (rank_one_type): ... this.
11492
11493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11494
11495         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11496         from...
11497         (rank_one_type): ... this.
11498
11499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11500
11501         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11502         from...
11503         (rank_one_type): ... this.
11504
11505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11506
11507         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11508         from...
11509         (rank_one_type): ... this.
11510
11511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11512
11513         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11514         from...
11515         (rank_one_type): ... this.
11516
11517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11518
11519         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11520         from...
11521         (rank_one_type): ... this.
11522
11523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11524
11525         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11526         from...
11527         (rank_one_type): ... this.
11528
11529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11530
11531         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11532         from...
11533         (rank_one_type): ... this.
11534
11535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11536
11537         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11538         from...
11539         (rank_one_type): ... this.
11540
11541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11542
11543         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11544         from...
11545         (rank_one_type): ... this.
11546
11547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11548
11549         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11550         from...
11551         (rank_one_type): ... this.
11552
11553 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11554
11555         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11556         inferior-events' shows the example events.
11557
11558 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11559
11560         Support styling on native MS-Windows console
11561
11562         PR/24315
11563         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11564         on MS-Windows if $TERM is not defined.
11565
11566         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11567
11568         * posix-hdep.c (gdb_console_fputs):
11569         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11570         functions.
11571         * ui-file.h (gdb_console_fputs): Add prototype.
11572
11573         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11574         back to fputs only if the former returns zero.
11575
11576 2019-03-07  Tom Tromey  <tom@tromey.com>
11577
11578         * symmisc.c (print_symbol_bcache_statistics): Update.
11579         (print_objfile_statistics): Update.
11580         * symfile.c (allocate_symtab): Update.
11581         * stabsread.c: Don't include bcache.h.
11582         * psymtab.h (struct psymbol_bcache): Don't declare.
11583         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11584         (psymbol_bcache_init, psymbol_bcache_free)
11585         (psymbol_bcache_get_bcache): Don't declare.
11586         * psymtab.c (struct psymbol_bcache): Remove.
11587         (psymtab_storage::psymtab_storage): Update.
11588         (psymtab_storage::~psymtab_storage): Update.
11589         (psymbol_bcache_init, psymbol_bcache_free)
11590         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11591         (add_psymbol_to_bcache): Update.
11592         (allocate_psymtab): Update.
11593         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11594         macro_cache>: No longer pointers.
11595         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11596         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11597         * macrotab.c (macro_bcache): Update.
11598         * macroexp.c: Don't include bcache.h.
11599         * gdbtypes.c (check_types_worklist): Update.
11600         (types_deeply_equal): Remove TRY/CATCH.  Update.
11601         * elfread.c (elf_symtab_read): Update.
11602         * dwarf2read.c: Don't include bcache.h.
11603         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11604         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11605         (print_bcache_statistics, bcache_memory_used): Don't declare.
11606         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11607         methods.  Rename all data members.
11608         * bcache.c (struct bcache): Move to bcache.h.
11609         (bcache::expand_hash_table): Rename from expand_hash_table.
11610         (bcache): Remove.
11611         (bcache::insert): Rename from bcache_full.
11612         (bcache::compare): Rename from bcache_compare.
11613         (bcache_xmalloc): Remove.
11614         (bcache::~bcache): Rename from bcache_xfree.
11615         (bcache::print_statistics): Rename from print_bcache_statistics.
11616         (bcache::memory_used): Rename from bcache_memory_used.
11617
11618 2019-03-07  Pedro Alves  <palves@redhat.com>
11619
11620         * infrun.c (normal_stop): Also check for
11621         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11622
11623 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11624
11625         * f-lang.c (value_from_host_double): Moved to...
11626         * value.c (value_from_host_double): ...here.
11627         * value.h (value_from_host_double): Declare.
11628         * guile/scm-math.c (vlscm_convert_typed_number): Use
11629         value_from_host_double.
11630         (vlscm_convert_number): Likewise.
11631         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11632         * python/py-value.c (convert_value_from_python): Likewise.
11633
11634 2019-03-06  Tom Tromey  <tom@tromey.com>
11635
11636         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11637
11638 2019-03-06  Tom Tromey  <tom@tromey.com>
11639
11640         * utils.h (free_current_contents): Don't declare.
11641         * utils.c (free_current_contents): Remove.
11642
11643 2019-03-06  Tom Tromey  <tom@tromey.com>
11644
11645         * top.c (quit_force): Update.
11646         * main.c (captured_command_loop): Update.
11647         * common/new-op.c (operator new): Update.
11648         * common/common-exceptions.c (struct catcher)
11649         <save_cleanup_chain>: Remove member.
11650         (exceptions_state_mc_init): Update.
11651         (exception_try_scope_entry): Return nullptr.
11652         (exception_try_scope_exit, exception_rethrow)
11653         (throw_exception_sjlj, throw_exception_cxx): Update.
11654         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11655         (all_cleanups, do_cleanups, discard_cleanups)
11656         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11657         (restore_cleanups, restore_final_cleanups): Don't declare.
11658         (do_final_cleanups): Remove parameter.
11659         * common/cleanups.c (cleanup_chain, make_cleanup)
11660         (make_cleanup_dtor, all_cleanups, do_cleanups)
11661         (discard_my_cleanups, discard_cleanups)
11662         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11663         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11664         (null_cleanup): Remove.
11665         (do_final_cleanups): Remove parameter.
11666
11667 2019-03-06  Tom Tromey  <tom@tromey.com>
11668
11669         * remote.c (remote_target::remote_parse_stop_reply): Use
11670         unique_xmalloc_ptr.
11671
11672 2019-03-06  Tom Tromey  <tom@tromey.com>
11673
11674         * stabsread.c (struct stabs_field_info): Rename from field_info.
11675         <list, fnlist>: Add initializers.
11676         <obstack>: New member.
11677         (read_member_functions, read_struct_fields, read_baseclasses):
11678         Allocate on obstack.  Don't use cleanups.
11679         (read_one_struct_field, read_member_functions, read_struct_fields)
11680         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11681         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11682         (read_struct_type): Update.
11683
11684 2019-03-06  Tom Tromey  <tom@tromey.com>
11685
11686         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11687         * common/filestuff.h (make_cleanup_close): Don't declare.
11688         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11689         Remove.
11690
11691 2019-03-06  Tom Tromey  <tom@tromey.com>
11692
11693         * solib-aix.c: Use make_scope_exit.
11694
11695 2019-03-06  Tom Tromey  <tom@tromey.com>
11696
11697         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11698         Use make_scope_exit.
11699
11700 2019-03-06  Tom Tromey  <tom@tromey.com>
11701
11702         * solib-svr4.c (disable_probes_interface): Remove parameter.
11703         (svr4_handle_solib_event): Use make_scope_exit.
11704
11705 2019-03-06  Tom Tromey  <tom@tromey.com>
11706
11707         * remote.c (struct stop_reply_deleter): Remove.
11708         (stop_reply_up): Update.
11709         (struct stop_reply): Derive from notif_event.  Don't typedef.
11710         <regcache>: Now a std::vector.
11711         (stop_reply_xfree): Remove.
11712         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11713         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11714         (remote_target::discard_pending_stop_replies): Use delete.
11715         (remote_target::remote_parse_stop_reply): Update.
11716         (remote_target::process_stop_reply): Update.
11717         * remote-notif.h (struct notif_event): Add virtual destructor.
11718         Remove "dtr" member.
11719         (struct notif_client) <alloc_event>: Return a unique_ptr.
11720         (notif_event_xfree): Don't declare.
11721         (notif_event_up): New typedef.
11722         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11723         (notif_event_xfree, do_notif_event_xfree): Remove.
11724         (remote_notif_state_xfree): Update.
11725
11726 2019-03-06  Tom Tromey  <tom@tromey.com>
11727
11728         * infrun.c (displaced_step_clear_cleanup): Now a
11729         forward_scope_exit type.
11730         (displaced_step_prepare_throw): Update.
11731         (displaced_step_fixup): Update.
11732
11733 2019-03-06  Tom Tromey  <tom@tromey.com>
11734
11735         * inferior.h (class inferior): Update comment.
11736         * gdbthread.h (class thread_info): Update comment.
11737
11738 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11739             Tom Tromey  <tom@tromey.com>
11740
11741         * stabsread.h (struct stab_section_list): Remove.
11742         (coffstab_build_psymtabs): Update.
11743         * dbxread.c (symbuf_sections): Now a std::vector.
11744         (sect_idx): New global.
11745         (fill_symbuf): Update.
11746         (coffstab_build_psymtabs): Change type of stabsects parameter.
11747         Update.
11748         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11749         std::vector.
11750         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11751         (coff_locate_sections): Update.
11752         (coff_symfile_read): Remove cleanups.  Update.
11753         (init_stringtab): Add storage parameter.
11754         (free_stringtab, free_stringtab_cleanup): Remove.
11755         (init_lineno): Add storage parameter.
11756         (free_linetab, free_linetab_cleanup): Remove.
11757
11758 2019-03-06  Pedro Alves  <palves@redhat.com>
11759
11760         * linux-fork.c (fork_info::clobber_regs): Delete.
11761         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11762         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11763         comment.  Adjust.
11764         (scoped_switch_fork_info::scoped_switch_fork_info)
11765         (checkpoint_command, linux_fork_context): Adjust
11766         fork_save_infrun_state calls.
11767
11768 2019-03-06  Pedro Alves  <palves@redhat.com>
11769
11770         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11771         (inf_has_multiple_threads): Return 'bool' and rewrite using
11772         inferior_info::threads().
11773
11774 2019-03-06  Pedro Alves  <palves@redhat.com>
11775
11776         * linux-fork.c: Include <list>.
11777         (fork_list): Now a std::list instance.
11778         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11779         (forks_exist_p, find_last_fork): Adjust.
11780         (new_fork): Delete.
11781         (one_fork_p): New.
11782         (add_fork): Adjust.
11783         (free_fork): Delete, folded into fork_info::~fork_info().
11784         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11785         Adjust.
11786         (init_fork_list): Delete.
11787         (linux_fork_killall, linux_fork_mourn_inferior)
11788         (linux_fork_detach, info_checkpoints_command): Adjust.
11789         (_initialize_linux_fork): No longer call init_fork_list.
11790
11791 2019-03-06  Pedro Alves  <palves@redhat.com>
11792
11793         * linux-fork.c (new_fork): New, split out of ...
11794         (add_fork): ... this.  Return void.  Move "first fork" special
11795         case from here, to ...
11796         (checkpoint_command): ... here.
11797         * linux-linux.h (add_fork): Return void.
11798
11799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11800
11801         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11802
11803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11804             Chris January  <chris.january@arm.com>
11805             David Lecomber  <david.lecomber@arm.com>
11806
11807         * f-exp.y: New token, UNOP_INTRINSIC.
11808         (exp): New pattern using UNOP_INTRINSIC token.
11809         (f77_keywords): Add 'abs' keyword.
11810         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11811         (value_from_host_double): New function.
11812         (evaluate_subexp_f): Support UNOP_ABS.
11813
11814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11815
11816         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11817         types.
11818
11819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11820
11821         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11822         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11823         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11824
11825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11828
11829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11830             Chris January  <chris.january@arm.com>
11831
11832         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11833         * f-exp.y: Define 'KIND' token.
11834         (exp): New pattern for KIND expressions.
11835         (ptype): Handle types with a kind extension.
11836         (direct_abs_decl): Extend to spot kind extensions.
11837         (f77_keywords): Add 'kind' to the list.
11838         (push_kind_type): New function.
11839         (convert_to_kind_type): New function.
11840         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11841         * parse.c (operator_length_standard): Likewise.
11842         * parser-defs.h (enum type_pieces): Add tp_kind.
11843         * std-operator.def: Add UNOP_KIND.
11844
11845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11846
11847         * f-exp.y (f_parse): Set yydebug.
11848
11849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11850
11851         * f-lang.c (evaluate_subexp_f): New function.
11852         (exp_descriptor_f): New global.
11853         (f_language_defn): Use exp_descriptor_f instead of
11854         exp_descriptor_standard.
11855
11856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11857
11858         * f-exp.y (struct token): Add comments.
11859         (dot_ops): Remove uppercase versions and the end marker.
11860         (f77_keywords): Likewise.
11861         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11862         entries in the dot_ops array are case insensitive, and use
11863         strncasecmp to compare strings.  Also some whitespace cleanup in
11864         this area.  Similar for the f77_keywords array, except entries in
11865         this list might be case sensitive.
11866
11867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11868
11869         * f-exp.y (struct f77_boolean_val): Add comments.
11870         (boolean_values): Remove uppercase versions, and end marker.
11871         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11872         and use strncasecmp to achieve case insensitivity.  Additionally,
11873         perform whitespace cleanup around this code.
11874
11875 2019-03-06  Tom Tromey  <tromey@adacore.com>
11876
11877         * remote-sim.c (gdbsim_target_open): Use result of
11878         gdb_argv::release.
11879
11880 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11881         Dirk Schubert  <dirk.schubert@arm.com>
11882         Chris January  <chris.january@arm.com>
11883
11884         * eval.c (evaluate_subexp_standard): Call Fortran argument
11885         wrapping logic.
11886         * f-lang.c (struct value): A value which can be passed into a
11887         Fortran function call.
11888         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11889         where appropriate.
11890         (struct type): Value ready for a Fortran function call.
11891         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11892         is needed.
11893         * f-lang.h (fortran_argument_convert): Declaration.
11894         (fortran_preserve_arg_pointer): Declaration.
11895         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11896
11897 2019-03-05  Tom Tromey  <tromey@adacore.com>
11898
11899         * python/py-prettyprint.c (print_string_repr): Remove #if.
11900         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11901
11902 2019-03-05  Tom Tromey  <tromey@adacore.com>
11903
11904         * target.c (the_dummy_target): Move later.  Change type to
11905         "dummy_target".
11906         (initialize_targets): Don't initialize the_dummy_target.
11907
11908 2019-03-05  Tom Tromey  <tromey@adacore.com>
11909
11910         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11911         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11912
11913 2019-03-05  Tom Tromey  <tromey@adacore.com>
11914
11915         * windows-nat.c (windows_nat_target::attach)
11916         (windows_nat_target::detach): Don't call gdb_flush.
11917         * valprint.c (generic_val_print, val_print, val_print_string):
11918         Don't call gdb_flush.
11919         * utils.c (defaulted_query): Don't call gdb_flush.
11920         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11921         * target.c (target_announce_detach): Don't call gdb_flush.
11922         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11923         * remote.c (extended_remote_target::attach): Don't call
11924         gdb_flush.
11925         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11926         * printcmd.c (do_examine): Don't call gdb_flush.
11927         (info_display_command): Don't call gdb_flush.
11928         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11929         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11930         * memattr.c (info_mem_command): Don't call gdb_flush.
11931         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11932         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11933         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11934         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11935         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11936         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11937         (gnu_nat_target::detach): Don't call gdb_flush.
11938         * f-valprint.c (f_val_print): Don't call gdb_flush.
11939         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11940         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11941         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11942         gdb_flush.
11943         * c-valprint.c (c_val_print): Don't call gdb_flush.
11944         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11945
11946 2019-03-05  Tom Tromey  <tromey@adacore.com>
11947
11948         * varobj.c (update_dynamic_varobj_children): Update.
11949         (install_default_visualizer): Use reset, not release.
11950         * value.c (set_internalvar): Update.
11951         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11952         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11953         ATTRIBUTE_UNUSED_RESULT.
11954
11955 2019-03-05  Tom Tromey  <tromey@adacore.com>
11956
11957         * remote.c (class scoped_remote_fd) <release>: Add
11958         ATTRIBUTE_UNUSED_RESULT.
11959
11960 2019-03-05  Tom Tromey  <tromey@adacore.com>
11961
11962         * macroexp.c (struct macro_buffer) <release>: Add
11963         ATTRIBUTE_UNUSED_RESULT.
11964
11965 2019-03-05  Tom Tromey  <tromey@adacore.com>
11966
11967         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11968         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11969         ATTRIBUTE_UNUSED_RESULT.
11970
11971 2019-03-05  Tom Tromey  <tromey@adacore.com>
11972
11973         * common/scoped_fd.h (class scoped_fd) <release>: Add
11974         ATTRIBUTE_UNUSED_RESULT.
11975
11976 2019-03-05  Tom Tromey  <tromey@adacore.com>
11977
11978         * parser-defs.h (struct parser_state) <release>: Add
11979         ATTRIBUTE_UNUSED_RESULT.
11980
11981 2019-03-05  Tom Tromey  <tromey@adacore.com>
11982
11983         * utils.h (class gdb_argv) <release>: Add
11984         ATTRIBUTE_UNUSED_RESULT.
11985         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11986
11987 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11988
11989         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11990         for-loop range, to avoid compiler warnings.
11991
11992         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11993         avoid compiler warnings about unused variables.
11994
11995         * NEWS: Mention end of support for native debugging on MS-Windows
11996         before XP.
11997
11998         PR gdb/24292
11999         * common/netstuff.c:
12000         * gdbserver/gdbreplay.c
12001         * gdbserver/remote-utils.c:
12002         * ser-tcp.c:
12003         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12004         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12005         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12006         'getaddrinfo' and 'freeaddrinfo' were not available before
12007         Windows XP, and mingw.org's MinGW headers by default define
12008         _WIN32_WINNT to 0x500.
12009
12010 2019-03-01  Gary Benson <gbenson@redhat.com>
12011
12012         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12013
12014 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12015             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12016
12017         PR gdb/8527
12018         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12019         set_sigint_trap, clear_sigint_trap.
12020
12021 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12022
12023         * target.c (target_detach): Clear the regcache and the
12024         frame cache.
12025
12026 2019-02-27  Pedro Alves  <palves@redhat.com>
12027
12028         * utils.c (set_screen_size): When we cap the height/width sizes,
12029         tweak the corresponding command variable to show "unlimited":
12030
12031 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12032             Pedro Alves  <palves@redhat.com>
12033
12034         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12035         before calling rl_set_screen_size.
12036
12037 2019-02-27  Tom Tromey  <tromey@adacore.com>
12038
12039         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12040         define.
12041         * python/py-value.c: Remove Python 2.4 workaround.
12042         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12043         workaround.
12044         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12045         Python 2.4 workaround.
12046         * python/python-internal.h: Remove Python 2.4 comment.
12047         (Py_ssize_t): Don't define.
12048         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12049         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12050         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12051         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12052         * python/python.c (do_start_initialization): Remove Python 2.4
12053         workaround.
12054         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12055         (print_children): Remove Python 2.4 workaround.
12056         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12057         workaround.
12058         (CHARBUFFERPROC_NAME): Remove.
12059         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12060         Python 2.4 workaround.
12061
12062 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12063
12064         * NEWS: Note minimum Python version.
12065
12066 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12067
12068         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12069         code from these functions.  Remove corresponding ifdefs.  Use
12070         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12071         Remove gotos and target of gotos.
12072         (infpy_search_memory): Likewise.
12073
12074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12075
12076         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12077         (hppa_gdbarch_init): Don't register deleted functions with
12078         gdbarch.
12079
12080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12081
12082         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12083         (h8300_unwind_sp): Delete.
12084         (h8300_dummy_id): Delete.
12085         (h8300_gdbarch_init): Don't register deleted functions with
12086         gdbarch.
12087
12088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12089
12090         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12091         (ft32_unwind_pc): Delete.
12092         (ft32_unwind_sp): Delete.
12093         (ft32_gdbarch_init): Don't register deleted functions with
12094         gdbarch.
12095
12096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12097
12098         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12099         (frv_unwind_pc): Delete.
12100         (frv_unwind_sp): Delete.
12101         (frv_gdbarch_init): Don't register deleted functions with
12102         gdbarch.
12103
12104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12105
12106         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12107         (riscv_unwind_pc): Delete.
12108         (riscv_unwind_sp): Delete.
12109         (riscv_gdbarch_init): Don't register deleted functions with
12110         gdbarch.
12111
12112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12113
12114         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12115         (csky_unwind_pc): Delete.
12116         (csky_unwind_sp): Delete.
12117         (csky_gdbarch_init): Don't register deleted functions with
12118         gdbarch.
12119
12120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12121
12122         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12123         (cris_unwind_pc): Delete.
12124         (cris_unwind_sp): Delete.
12125         (cris_gdbarch_init): Don't register deleted functions with
12126         gdbarch.
12127
12128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12129
12130         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12131         (bfin_unwind_pc): Delete.
12132         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12133
12134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12135
12136         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12137         (arm_unwind_pc): Delete.
12138         (arm_unwind_sp): Delete.
12139         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12140
12141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12142
12143         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12144         (arc_unwind_pc): Delete.
12145         (arc_unwind_sp): Delete.
12146         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12147
12148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12149
12150         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12151         (alpha_unwind_pc): Delete.
12152         (alpha_gdbarch_init): Don't register deleted functions with
12153         gdbarch.
12154
12155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12156
12157         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12158         (aarch64_unwind_pc): Delete.
12159         (aarch64_unwind_sp): Delete.
12160         (aarch64_gdbarch_init): Don't register deleted functions with
12161         gdbarch.
12162
12163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12164
12165         * gdbtypes.c (type_align): Don't consider static members when
12166         computing structure alignment.
12167
12168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12169
12170         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12171         return 0 for other types.
12172         * arch-utils.c (default_type_align): Always return 0.
12173         * gdbarch.h: Regenerate.
12174         * gdbarch.sh (type_align): Extend comment.
12175         * gdbtypes.c (type_align): Add additional comments, always call
12176         gdbarch_type_align before applying the default rules.
12177         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12178         generic code will then apply a suitable default.
12179         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12180         types, return 0 for other types.
12181
12182 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12183
12184         * NEWS: Create a new section for the next release branch.
12185         Rename the section of the current branch, now that it has
12186         been cut.
12187
12188 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12189
12190         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12191         * version.in: Bump version to 8.3.50.DATE-git.
12192
12193 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12194
12195         * aix-thread.c (ptid_cmp): Remove unused variable.
12196         (get_signaled_thread): Likewise.
12197         (store_regs_user_thread): Likewise.
12198         (store_regs_kernel_thread): Likewise.
12199         (fetch_regs_kernel_thread): Remove shadowed variable.
12200
12201 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12202
12203         * features/riscv/32bit-cpu.xml: Add register numbers.
12204         * features/riscv/32bit-fpu.c: Regenerate.
12205         * features/riscv/32bit-fpu.xml: Add register numbers.
12206         * features/riscv/64bit-cpu.xml: Add register numbers.
12207         * features/riscv/64bit-fpu.c: Regenerate.
12208         * features/riscv/64bit-fpu.xml: Add register numbers.
12209
12210 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12211
12212         * NEWS: Mention two argument form of gdb.Value constructor.
12213         * python/py-value.c (convert_buffer_and_type_to_value): New
12214         function.
12215         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12216         Add support for handling an optional second argument.  Call
12217         convert_buffer_and_type_to_value as appropriate.
12218         * python/python-internal.h (Py_buffer_deleter): New struct.
12219         (Py_buffer_up): New typedef.
12220
12221 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12222
12223         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12224         instead of releasing ownership.
12225
12226 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12227
12228         * dwarf2read.c (open_and_init_dwp_file): Call
12229         elf_numsections instead of bfd_count_sections to initialize
12230         dwp_file->num_sections.
12231
12232 2019-02-25  Tom Tromey  <tromey@adacore.com>
12233
12234         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12235
12236 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12237
12238         * gcore.in: Add '--readnever' option when invoking GDB.
12239
12240 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12241
12242         * MAINTAINERS: Update my email address.
12243
12244 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12245
12246         * build-id.c (build_id_to_debug_bfd_1): New function.
12247         (build_id_to_debug_bfd): Look for separate debug file in
12248         sysroot.
12249
12250 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12251
12252         * gdbarch.sh: Update the copyright year range that is placed into
12253         generated files.
12254
12255 2019-02-22  Keith Seitz  <keiths@redhat.com>
12256
12257         PR symtab/23853
12258         * linespec.c (create_sals_line_offset): Search for the default
12259         symtab's filename instead of its fullname.
12260
12261 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12262
12263         * NEWS: Update style defaults.
12264
12265 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12266
12267         * main.c (captured_main_1): Disable styling in batch mode.
12268
12269 2019-02-20  Tom Tromey  <tom@tromey.com>
12270
12271         * symtab.c (symtab_symbol_info): Fix typos.
12272
12273 2019-02-20  Tom Tromey  <tromey@adacore.com>
12274
12275         * findcmd.c (_initialize_mem_search): Use upper case for
12276         metasyntactic variables.
12277
12278 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12279
12280         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12281         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12282
12283 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12284
12285         * top.h (source_file_name): Change to std::string.
12286         * top.c (source_file_name): Likewise.
12287         (command_line_input): Adjust.
12288         * cli/cli-script.c (script_from_file): Adjust.
12289
12290 2019-02-19  Tom Tromey  <tromey@adacore.com>
12291
12292         * ravenscar-thread.c
12293         (ravenscar_thread_target::update_thread_list): Don't call
12294         ada_build_task_list.
12295         * ada-lang.h (ada_build_task_list): Don't declare.
12296         * ada-tasks.c (struct ada_tasks_inferior_data)
12297         <task_list_valid_p>: Now bool.
12298         (read_known_tasks, ada_task_list_changed)
12299         (ada_tasks_invalidate_inferior_data): Update.
12300         (read_known_tasks_array): Return bool.
12301         (read_known_tasks_list): Likewise.
12302         (read_known_tasks): Return void.
12303         (ada_build_task_list): Now static.
12304
12305 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12306
12307         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12308         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12309
12310 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12311
12312         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12313         variant for ada_tasks_pspace_data_handle and
12314         ada_tasks_inferior_data_handle.
12315         (ada_tasks_pspace_data_cleanup): New function.
12316         (ada_tasks_inferior_data_cleanup): New function.
12317
12318 2019-02-17  Tom Tromey  <tom@tromey.com>
12319
12320         * macrotab.h (macro_source_fullname): Return a std::string.
12321         * macrotab.c (macro_include, check_for_redefinition)
12322         (macro_undef, macro_lookup_definition, foreach_macro)
12323         (foreach_macro_in_scope): Update.
12324         (macro_source_fullname): Return a std::string.
12325         * macrocmd.c (show_pp_source_pos): Update.
12326
12327 2019-02-17  Tom Tromey  <tom@tromey.com>
12328
12329         * macrocmd.c (show_pp_source_pos): Style the file names.
12330
12331 2019-02-17  Tom Tromey  <tom@tromey.com>
12332
12333         PR tui/24197:
12334         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12335
12336 2019-02-17  Tom Tromey  <tom@tromey.com>
12337
12338         * ada-lang.c (user_select_syms): Use filtered printing.
12339         * utils.c (wrap_style): New global.
12340         (desired_style): Remove.
12341         (emit_style_escape): Add stream parameter.
12342         (set_output_style, reset_terminal_style, prompt_for_continue):
12343         Update.
12344         (flush_wrap_buffer): Only flush gdb_stdout.
12345         (wrap_here): Set wrap_style.
12346         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12347         treat escape sequences as a character.  Change when wrap buffer is
12348         flushed.
12349         (fputs_styled): Do not set the output style when the default is
12350         requested.
12351         * ui-style.h (struct ui_file_style) <is_default>: New method.
12352         * source.c (print_source_lines_base): Emit escape sequences in one
12353         piece.
12354
12355 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12356
12357         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12358         integers and enumeration types.
12359
12360 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12361
12362         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12363         instead of lookup_symbol_in_language
12364         (do_exact_match): New function.
12365         (ada_get_symbol_name_matcher): Return do_exact_match when
12366         doing a verbatim match.
12367
12368 2019-02-15  Tom Tromey  <tromey@adacore.com>
12369
12370         * ravenscar-thread.c (ravenscar_thread_target::resume)
12371         (ravenscar_thread_target::wait): Special case wildcard requests.
12372
12373 2019-02-15  Tom Tromey  <tromey@adacore.com>
12374
12375         * ravenscar-thread.c (base_ptid): Remove.
12376         (struct ravenscar_thread_target) <close>: New method.
12377         <m_base_ptid>: New member.
12378         <update_inferior_ptid, active_task, task_is_currently_active,
12379         runtime_initialized>: Declare methods.
12380         <ravenscar_thread_target>: Add constructor.
12381         (ravenscar_thread_target::task_is_currently_active)
12382         (ravenscar_thread_target::update_inferior_ptid)
12383         (ravenscar_runtime_initialized): Rename.  Now methods.
12384         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12385         (ravenscar_thread_target::update_thread_list): Update.
12386         (ravenscar_thread_target::active_task): Now method.
12387         (ravenscar_thread_target::store_registers)
12388         (ravenscar_thread_target::prepare_to_store)
12389         (ravenscar_thread_target::prepare_to_store)
12390         (ravenscar_thread_target::mourn_inferior): Update.
12391         (ravenscar_inferior_created): Use "new" to create target.
12392         (ravenscar_thread_target::get_ada_task_ptid): Update.
12393         (_initialize_ravenscar): Don't initialize base_ptid.
12394         (ravenscar_ops): Remove global.
12395
12396 2019-02-15  Tom Tromey  <tromey@adacore.com>
12397
12398         * target.h (push_target): Declare new overload.
12399         * target.c (push_target): New overload, taking an rvalue reference.
12400         * remote.c (remote_target::open_1): Use push_target overload.
12401         * corelow.c (core_target_open): Use push_target overload.
12402
12403 2019-02-15  Tom Tromey  <tromey@adacore.com>
12404
12405         * ravenscar-thread.c (is_ravenscar_task)
12406         (ravenscar_task_is_currently_active): Return bool.
12407         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12408         (_initialize_ravenscar): Remove "(void)".
12409         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12410         Return bool.
12411
12412 2019-02-15  Tom Tromey  <tromey@adacore.com>
12413
12414         * ravenscar-thread.c (ravenscar_runtime_initializer)
12415         (has_ravenscar_runtime, get_running_thread_id)
12416         (ravenscar_thread_target::resume): Fix indentation.
12417
12418 2019-02-15  Tom Tromey  <tromey@adacore.com>
12419
12420         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12421         from ravenscar_arch_ops.
12422         (sparc_ravenscar_ops::fetch_registers)
12423         (sparc_ravenscar_ops::store_registers): Now methods.
12424         (sparc_ravenscar_prepare_to_store): Remove.
12425         (sparc_ravenscar_ops): Redefine.
12426         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12427         methods and destructor.  Remove members.
12428         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12429         (ravenscar_thread_target::store_registers)
12430         (ravenscar_thread_target::prepare_to_store): Update.
12431         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12432         Remove.
12433         (struct ppc_ravenscar_powerpc_ops): Derive from
12434         ravenscar_arch_ops.
12435         (ppc_ravenscar_powerpc_ops::fetch_registers)
12436         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12437         (ppc_ravenscar_powerpc_ops): Redefine.
12438         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12439         (ppc_ravenscar_e500_ops::fetch_registers)
12440         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12441         (ppc_ravenscar_e500_ops): Redefine.
12442         * aarch64-ravenscar-thread.c
12443         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12444         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12445         (aarch64_ravenscar_fetch_registers)
12446         (aarch64_ravenscar_store_registers): Now methods.
12447         (aarch64_ravenscar_ops): Redefine.
12448
12449 2019-02-15  Tom Tromey  <tromey@adacore.com>
12450
12451         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12452         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12453         (ravenscar_thread_target::stopped_by_watchpoint)
12454         (ravenscar_thread_target::stopped_data_address)
12455         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12456
12457 2019-02-15  Tom Tromey  <tromey@adacore.com>
12458
12459         * ravenscar-thread.c: Fix some typos.
12460
12461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12462             Tom Tromey  <tromey@adacore.com>
12463
12464         * ada-lang.c (ada_exception_sal): Change addr_string to a
12465         std::string.
12466         (create_ada_exception_catchpoint): Update.
12467
12468 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12469             Tom Tromey  <tromey@adacore.com>
12470
12471         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12472         (bp_location_ops): Remove.
12473         (base_breakpoint_allocate_location): Update.
12474         (free_bp_location): Update.
12475         * ada-lang.c (class ada_catchpoint_location)
12476         <ada_catchpoint_location>: Remove ops parameter.
12477         (ada_catchpoint_location_dtor): Remove.
12478         (ada_catchpoint_location_ops): Remove.
12479         (allocate_location_exception): Update.
12480         * breakpoint.h (struct bp_location_ops): Remove.
12481         (class bp_location) <bp_location>: Remove bp_location_ops
12482         parameter.
12483         <~bp_location>: Add destructor.
12484         <ops>: Remove.
12485
12486 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12487             Pedro Alves  <palves@redhat.com>
12488
12489         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12490         'PATH_MAX'.
12491
12492 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12493             Samuel Thibault  <samuel.thibault@gnu.org>
12494             Thomas Schwinge  <thomas@codesourcery.com>
12495
12496         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12497         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12498
12499 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12500
12501         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12502         (check_empty): Use "const char *".
12503
12504         * gnu-nat.c (gnu_nat_target::detach): Instead of
12505         'detach_inferior (pid)' call
12506         'detach_inferior (find_inferior_pid (pid))'.
12507
12508         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12509         'nat/fork-inferior.o'.
12510         * gnu-nat.c: #include "nat/fork-inferior.h".
12511
12512         * gnu-nat.c (gnu_nat_target::detach): Instead of
12513         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12514         * gnu-nat.h: #include "inf-child.h".
12515         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12516         'i386_gnu_nat_target::fetch_registers'.
12517         (gnu_store_registers): Rename/move to
12518         'i386_gnu_nat_target::store_registers'.
12519
12520         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12521         * gnu-nat.h (mach_thread_info): New function.
12522         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12523
12524         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12525
12526 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12527
12528         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12529
12530 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12531
12532         * windows-nat.c (windows_add_thread): Add new parameter
12533         "main_thread_p" with default value set to false.  Update
12534         function documentation as well as all callers.
12535         (windows_delete_thread): Likewise.
12536         (fake_create_process): Update call to windows_add_thread.
12537         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12538         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12539         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12540         call to windows_delete_thread.
12541
12542 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12543
12544         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12545
12546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12547
12548         * symfile.c (find_separate_debug_file): Use canonical path of
12549         sysroot with child_path instead of gdb_sysroot if it is valid.
12550
12551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12552
12553         * symfile.c (find_separate_debug_file): Use child_path to
12554         determine if an object file is under a sysroot.
12555
12556 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12557
12558         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12559         unittests/child-path-selftests.c.
12560         * common/pathstuff.c (child_path): New function.
12561         * common/pathstuff.h (child_path): New prototype.
12562         * unittests/child-path-selftests.c: New file.
12563
12564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12565
12566         * symfile.c (find_separate_debug_file): Look for separate debug
12567         files in debug directories under the sysroot.
12568
12569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12570
12571         * symtab.h (struct minimal_symbol data_p): New const method.
12572         (struct minimal_symbol text_p): Likewise.
12573         * symtab.c (output_source_filename): Use file name style
12574         to print file name.
12575         (print_symbol_info): Likewise.
12576         (print_msymbol_info): Use address style to print addresses.
12577         Use function name style to print executable text symbols.
12578         (expand_symtab_containing_pc): Use data_p.
12579         (find_pc_sect_compunit_symtab): Likewise.
12580
12581 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12582
12583         * breakpoint.c (describe_other_breakpoints): Use address style
12584         to print addresses.
12585         (say_where): Likewise.
12586
12587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12588
12589         * ada-typeprint.c (print_func_type): Print function name
12590         style to print function name.
12591         * c-typeprint.c (c_print_type_1): Likewise.
12592
12593 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12594
12595         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12596         for execve.
12597
12598 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12599
12600         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12601         type_stack.
12602
12603 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12604
12605         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12606         TYPE_CODE_REF types.
12607
12608 2019-02-08  Jim Wilson  <jimw@sifive.com>
12609
12610         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12611         (riscv_linux_fregset): New.
12612         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12613
12614 2019-02-07  Tom Tromey  <tom@tromey.com>
12615
12616         * thread.c (thread_cancel_execution_command): Update.
12617         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12618         methods.
12619         (struct thread_fsm_ops): Remove.
12620         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12621         (thread_fsm_should_stop, thread_fsm_return_value)
12622         (thread_fsm_set_finished, thread_fsm_finished_p)
12623         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12624         Don't declare.
12625         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12626         * infrun.c (clear_proceed_status_thread)
12627         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12628         (print_stop_event): Update.
12629         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12630         Add constructor.
12631         (step_command_fsm_ops): Remove.
12632         (new_step_command_fsm): Remove.
12633         (step_1): Update.
12634         (step_command_fsm::should_stop): Rename from
12635         step_command_fsm_should_stop.
12636         (step_command_fsm::clean_up): Rename from
12637         step_command_fsm_clean_up.
12638         (step_command_fsm::do_async_reply_reason): Rename from
12639         step_command_fsm_async_reply_reason.
12640         (struct until_next_fsm): Inherit from thread_fsm.  Add
12641         constructor.
12642         (until_next_fsm_ops): Remove.
12643         (new_until_next_fsm): Remove.
12644         (until_next_fsm::should_stop): Rename from
12645         until_next_fsm_should_stop.
12646         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12647         (until_next_fsm::do_async_reply_reason): Rename from
12648         until_next_fsm_async_reply_reason.
12649         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12650         constructor.  Change type of breakpoint.
12651         (finish_command_fsm_ops): Remove.
12652         (new_finish_command_fsm): Remove.
12653         (finish_command_fsm::should_stop): Rename from
12654         finish_command_fsm_should_stop.
12655         (finish_command_fsm::clean_up): Rename from
12656         finish_command_fsm_clean_up.
12657         (finish_command_fsm::return_value): Rename from
12658         finish_command_fsm_return_value.
12659         (finish_command_fsm::do_async_reply_reason): Rename from
12660         finish_command_fsm_async_reply_reason.
12661         (finish_command): Update.
12662         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12663         Add constructor.
12664         (call_thread_fsm_ops): Remove.
12665         (call_thread_fsm::call_thread_fsm): Rename from
12666         new_call_thread_fsm.
12667         (call_thread_fsm::should_stop): Rename from
12668         call_thread_fsm_should_stop.
12669         (call_thread_fsm::should_notify_stop): Rename from
12670         call_thread_fsm_should_notify_stop.
12671         (run_inferior_call, call_function_by_hand_dummy): Update.
12672         * cli/cli-interp.c (should_print_stop_to_console): Update.
12673         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12674         Add constructor.  Change type of location_breakpoint,
12675         caller_breakpoint.
12676         (until_break_fsm_ops): Remove.
12677         (new_until_break_fsm): Remove.
12678         (until_break_fsm::should_stop): Rename from
12679         until_break_fsm_should_stop.
12680         (until_break_fsm::clean_up): Rename from
12681         until_break_fsm_clean_up.
12682         (until_break_fsm::do_async_reply_reason): Rename from
12683         until_break_fsm_async_reply_reason.
12684         (until_break_command): Update.
12685         * thread-fsm.c: Remove.
12686         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12687
12688 2019-02-07  Tom Tromey  <tom@tromey.com>
12689
12690         * yy-remap.h: Add include guard.
12691         * xtensa-tdep.h: Add include guard.
12692         * xcoffread.h: Rename include guard.
12693         * varobj-iter.h: Add include guard.
12694         * tui/tui.h: Rename include guard.
12695         * tui/tui-winsource.h: Rename include guard.
12696         * tui/tui-wingeneral.h: Rename include guard.
12697         * tui/tui-windata.h: Rename include guard.
12698         * tui/tui-win.h: Rename include guard.
12699         * tui/tui-stack.h: Rename include guard.
12700         * tui/tui-source.h: Rename include guard.
12701         * tui/tui-regs.h: Rename include guard.
12702         * tui/tui-out.h: Rename include guard.
12703         * tui/tui-layout.h: Rename include guard.
12704         * tui/tui-io.h: Rename include guard.
12705         * tui/tui-hooks.h: Rename include guard.
12706         * tui/tui-file.h: Rename include guard.
12707         * tui/tui-disasm.h: Rename include guard.
12708         * tui/tui-data.h: Rename include guard.
12709         * tui/tui-command.h: Rename include guard.
12710         * tic6x-tdep.h: Add include guard.
12711         * target/waitstatus.h: Rename include guard.
12712         * target/wait.h: Rename include guard.
12713         * target/target.h: Rename include guard.
12714         * target/resume.h: Rename include guard.
12715         * target-float.h: Rename include guard.
12716         * stabsread.h: Add include guard.
12717         * rs6000-tdep.h: Add include guard.
12718         * riscv-fbsd-tdep.h: Add include guard.
12719         * regformats/regdef.h: Rename include guard.
12720         * record.h: Rename include guard.
12721         * python/python.h: Rename include guard.
12722         * python/python-internal.h: Rename include guard.
12723         * python/py-stopevent.h: Rename include guard.
12724         * python/py-ref.h: Rename include guard.
12725         * python/py-record.h: Rename include guard.
12726         * python/py-record-full.h: Rename include guard.
12727         * python/py-record-btrace.h: Rename include guard.
12728         * python/py-instruction.h: Rename include guard.
12729         * python/py-events.h: Rename include guard.
12730         * python/py-event.h: Rename include guard.
12731         * procfs.h: Add include guard.
12732         * proc-utils.h: Add include guard.
12733         * p-lang.h: Add include guard.
12734         * or1k-tdep.h: Rename include guard.
12735         * observable.h: Rename include guard.
12736         * nto-tdep.h: Rename include guard.
12737         * nat/x86-linux.h: Rename include guard.
12738         * nat/x86-linux-dregs.h: Rename include guard.
12739         * nat/x86-gcc-cpuid.h: Add include guard.
12740         * nat/x86-dregs.h: Rename include guard.
12741         * nat/x86-cpuid.h: Rename include guard.
12742         * nat/ppc-linux.h: Rename include guard.
12743         * nat/mips-linux-watch.h: Rename include guard.
12744         * nat/linux-waitpid.h: Rename include guard.
12745         * nat/linux-ptrace.h: Rename include guard.
12746         * nat/linux-procfs.h: Rename include guard.
12747         * nat/linux-osdata.h: Rename include guard.
12748         * nat/linux-nat.h: Rename include guard.
12749         * nat/linux-namespaces.h: Rename include guard.
12750         * nat/linux-btrace.h: Rename include guard.
12751         * nat/glibc_thread_db.h: Rename include guard.
12752         * nat/gdb_thread_db.h: Rename include guard.
12753         * nat/gdb_ptrace.h: Rename include guard.
12754         * nat/fork-inferior.h: Rename include guard.
12755         * nat/amd64-linux-siginfo.h: Rename include guard.
12756         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12757         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12758         * nat/aarch64-linux.h: Rename include guard.
12759         * nat/aarch64-linux-hw-point.h: Rename include guard.
12760         * mn10300-tdep.h: Add include guard.
12761         * mips-linux-tdep.h: Add include guard.
12762         * mi/mi-parse.h: Rename include guard.
12763         * mi/mi-out.h: Rename include guard.
12764         * mi/mi-main.h: Rename include guard.
12765         * mi/mi-interp.h: Rename include guard.
12766         * mi/mi-getopt.h: Rename include guard.
12767         * mi/mi-console.h: Rename include guard.
12768         * mi/mi-common.h: Rename include guard.
12769         * mi/mi-cmds.h: Rename include guard.
12770         * mi/mi-cmd-break.h: Rename include guard.
12771         * m2-lang.h: Add include guard.
12772         * location.h: Rename include guard.
12773         * linux-record.h: Rename include guard.
12774         * linux-nat.h: Add include guard.
12775         * linux-fork.h: Add include guard.
12776         * i386-darwin-tdep.h: Rename include guard.
12777         * hppa-linux-offsets.h: Add include guard.
12778         * guile/guile.h: Rename include guard.
12779         * guile/guile-internal.h: Rename include guard.
12780         * gnu-nat.h: Rename include guard.
12781         * gdb-stabs.h: Rename include guard.
12782         * frv-tdep.h: Add include guard.
12783         * f-lang.h: Add include guard.
12784         * event-loop.h: Add include guard.
12785         * darwin-nat.h: Rename include guard.
12786         * cp-abi.h: Rename include guard.
12787         * config/sparc/nm-sol2.h: Rename include guard.
12788         * config/nm-nto.h: Rename include guard.
12789         * config/nm-linux.h: Add include guard.
12790         * config/i386/nm-i386gnu.h: Rename include guard.
12791         * config/djgpp/nl_types.h: Rename include guard.
12792         * config/djgpp/langinfo.h: Rename include guard.
12793         * compile/gcc-cp-plugin.h: Add include guard.
12794         * compile/gcc-c-plugin.h: Add include guard.
12795         * compile/compile.h: Rename include guard.
12796         * compile/compile-object-run.h: Rename include guard.
12797         * compile/compile-object-load.h: Rename include guard.
12798         * compile/compile-internal.h: Rename include guard.
12799         * compile/compile-cplus.h: Rename include guard.
12800         * compile/compile-c.h: Rename include guard.
12801         * common/xml-utils.h: Rename include guard.
12802         * common/x86-xstate.h: Rename include guard.
12803         * common/version.h: Rename include guard.
12804         * common/vec.h: Rename include guard.
12805         * common/tdesc.h: Rename include guard.
12806         * common/selftest.h: Rename include guard.
12807         * common/scoped_restore.h: Rename include guard.
12808         * common/scoped_mmap.h: Rename include guard.
12809         * common/scoped_fd.h: Rename include guard.
12810         * common/safe-iterator.h: Rename include guard.
12811         * common/run-time-clock.h: Rename include guard.
12812         * common/refcounted-object.h: Rename include guard.
12813         * common/queue.h: Rename include guard.
12814         * common/ptid.h: Rename include guard.
12815         * common/print-utils.h: Rename include guard.
12816         * common/preprocessor.h: Rename include guard.
12817         * common/pathstuff.h: Rename include guard.
12818         * common/observable.h: Rename include guard.
12819         * common/netstuff.h: Rename include guard.
12820         * common/job-control.h: Rename include guard.
12821         * common/host-defs.h: Rename include guard.
12822         * common/gdb_wait.h: Rename include guard.
12823         * common/gdb_vecs.h: Rename include guard.
12824         * common/gdb_unlinker.h: Rename include guard.
12825         * common/gdb_unique_ptr.h: Rename include guard.
12826         * common/gdb_tilde_expand.h: Rename include guard.
12827         * common/gdb_sys_time.h: Rename include guard.
12828         * common/gdb_string_view.h: Rename include guard.
12829         * common/gdb_splay_tree.h: Rename include guard.
12830         * common/gdb_setjmp.h: Rename include guard.
12831         * common/gdb_ref_ptr.h: Rename include guard.
12832         * common/gdb_optional.h: Rename include guard.
12833         * common/gdb_locale.h: Rename include guard.
12834         * common/gdb_assert.h: Rename include guard.
12835         * common/filtered-iterator.h: Rename include guard.
12836         * common/filestuff.h: Rename include guard.
12837         * common/fileio.h: Rename include guard.
12838         * common/environ.h: Rename include guard.
12839         * common/common-utils.h: Rename include guard.
12840         * common/common-types.h: Rename include guard.
12841         * common/common-regcache.h: Rename include guard.
12842         * common/common-inferior.h: Rename include guard.
12843         * common/common-gdbthread.h: Rename include guard.
12844         * common/common-exceptions.h: Rename include guard.
12845         * common/common-defs.h: Rename include guard.
12846         * common/common-debug.h: Rename include guard.
12847         * common/cleanups.h: Rename include guard.
12848         * common/buffer.h: Rename include guard.
12849         * common/btrace-common.h: Rename include guard.
12850         * common/break-common.h: Rename include guard.
12851         * cli/cli-utils.h: Rename include guard.
12852         * cli/cli-style.h: Rename include guard.
12853         * cli/cli-setshow.h: Rename include guard.
12854         * cli/cli-script.h: Rename include guard.
12855         * cli/cli-interp.h: Rename include guard.
12856         * cli/cli-decode.h: Rename include guard.
12857         * cli/cli-cmds.h: Rename include guard.
12858         * charset-list.h: Add include guard.
12859         * buildsym-legacy.h: Rename include guard.
12860         * bfin-tdep.h: Add include guard.
12861         * ax.h: Rename include guard.
12862         * arm-linux-tdep.h: Add include guard.
12863         * arm-fbsd-tdep.h: Add include guard.
12864         * arch/xtensa.h: Rename include guard.
12865         * arch/tic6x.h: Add include guard.
12866         * arch/i386.h: Add include guard.
12867         * arch/arm.h: Rename include guard.
12868         * arch/arm-linux.h: Rename include guard.
12869         * arch/arm-get-next-pcs.h: Rename include guard.
12870         * arch/amd64.h: Add include guard.
12871         * arch/aarch64-insn.h: Rename include guard.
12872         * arch-utils.h: Rename include guard.
12873         * annotate.h: Add include guard.
12874         * amd64-darwin-tdep.h: Rename include guard.
12875         * aarch64-linux-tdep.h: Add include guard.
12876         * aarch64-fbsd-tdep.h: Add include guard.
12877         * aarch32-linux-nat.h: Add include guard.
12878
12879 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12880
12881         * macrotab.c (macro_define_internal): New function that
12882         factorizes macro_define_object_internal and macro_define_function
12883         code.
12884         (macro_define_object_internal): Use macro_define_internal.
12885         (macro_define_function): Likewise.
12886
12887 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12888
12889         * macrocmd.c (extract_identifier): Return
12890         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12891         callers.
12892
12893 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12894
12895         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12896
12897 2019-02-05  Tom Tromey  <tom@tromey.com>
12898
12899         * target.c (target_stack::unpush): Move assertion earlier.
12900
12901 2019-01-30  Tom Tromey  <tom@tromey.com>
12902
12903         PR python/23615:
12904         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12905         (gdbpy_parse_and_eval): Likewise.
12906         * python/python-internal.h (gdbpy_allow_threads): New class.
12907
12908 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12909
12910         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12911         (aarch64_fbsd_fpregmap): Move earlier.
12912         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12913         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12914         instead of individual calls to trad_frame_set_reg_addr.
12915         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12916         earlier.
12917         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12918         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12919         instead of individual calls to trad_frame_set_reg_addr.
12920
12921 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12922
12923         * CONTRIBUTE: Replace contribution list with wiki link.
12924
12925 2019-01-25  Tom Tromey  <tom@tromey.com>
12926
12927         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12928
12929 2019-01-25  Tom Tromey  <tom@tromey.com>
12930
12931         * xtensa-linux-nat.c: Fix common/ includes.
12932         * xml-support.h: Fix common/ includes.
12933         * xml-support.c: Fix common/ includes.
12934         * x86-linux-nat.c: Fix common/ includes.
12935         * windows-nat.c: Fix common/ includes.
12936         * varobj.h: Fix common/ includes.
12937         * varobj.c: Fix common/ includes.
12938         * value.c: Fix common/ includes.
12939         * valops.c: Fix common/ includes.
12940         * utils.c: Fix common/ includes.
12941         * unittests/xml-utils-selftests.c: Fix common/ includes.
12942         * unittests/utils-selftests.c: Fix common/ includes.
12943         * unittests/unpack-selftests.c: Fix common/ includes.
12944         * unittests/tracepoint-selftests.c: Fix common/ includes.
12945         * unittests/style-selftests.c: Fix common/ includes.
12946         * unittests/string_view-selftests.c: Fix common/ includes.
12947         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12948         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12949         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12950         * unittests/rsp-low-selftests.c: Fix common/ includes.
12951         * unittests/parse-connection-spec-selftests.c: Fix common/
12952         includes.
12953         * unittests/optional-selftests.c: Fix common/ includes.
12954         * unittests/offset-type-selftests.c: Fix common/ includes.
12955         * unittests/observable-selftests.c: Fix common/ includes.
12956         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12957         * unittests/memrange-selftests.c: Fix common/ includes.
12958         * unittests/memory-map-selftests.c: Fix common/ includes.
12959         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12960         * unittests/function-view-selftests.c: Fix common/ includes.
12961         * unittests/environ-selftests.c: Fix common/ includes.
12962         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12963         * unittests/common-utils-selftests.c: Fix common/ includes.
12964         * unittests/cli-utils-selftests.c: Fix common/ includes.
12965         * unittests/array-view-selftests.c: Fix common/ includes.
12966         * ui-file.c: Fix common/ includes.
12967         * tui/tui-io.c: Fix common/ includes.
12968         * tracepoint.h: Fix common/ includes.
12969         * tracepoint.c: Fix common/ includes.
12970         * tracefile-tfile.c: Fix common/ includes.
12971         * top.h: Fix common/ includes.
12972         * top.c: Fix common/ includes.
12973         * thread.c: Fix common/ includes.
12974         * target/waitstatus.h: Fix common/ includes.
12975         * target/waitstatus.c: Fix common/ includes.
12976         * target.h: Fix common/ includes.
12977         * target.c: Fix common/ includes.
12978         * target-memory.c: Fix common/ includes.
12979         * target-descriptions.c: Fix common/ includes.
12980         * symtab.h: Fix common/ includes.
12981         * symfile.c: Fix common/ includes.
12982         * stap-probe.c: Fix common/ includes.
12983         * spu-linux-nat.c: Fix common/ includes.
12984         * sparc-nat.c: Fix common/ includes.
12985         * source.c: Fix common/ includes.
12986         * solib.c: Fix common/ includes.
12987         * solib-target.c: Fix common/ includes.
12988         * ser-unix.c: Fix common/ includes.
12989         * ser-tcp.c: Fix common/ includes.
12990         * ser-pipe.c: Fix common/ includes.
12991         * ser-base.c: Fix common/ includes.
12992         * selftest-arch.c: Fix common/ includes.
12993         * s12z-tdep.c: Fix common/ includes.
12994         * rust-exp.y: Fix common/ includes.
12995         * rs6000-aix-tdep.c: Fix common/ includes.
12996         * riscv-tdep.c: Fix common/ includes.
12997         * remote.c: Fix common/ includes.
12998         * remote-notif.h: Fix common/ includes.
12999         * remote-fileio.h: Fix common/ includes.
13000         * remote-fileio.c: Fix common/ includes.
13001         * regcache.h: Fix common/ includes.
13002         * regcache.c: Fix common/ includes.
13003         * record-btrace.c: Fix common/ includes.
13004         * python/python.c: Fix common/ includes.
13005         * python/py-type.c: Fix common/ includes.
13006         * python/py-inferior.c: Fix common/ includes.
13007         * progspace.h: Fix common/ includes.
13008         * producer.c: Fix common/ includes.
13009         * procfs.c: Fix common/ includes.
13010         * proc-api.c: Fix common/ includes.
13011         * printcmd.c: Fix common/ includes.
13012         * ppc-linux-nat.c: Fix common/ includes.
13013         * parser-defs.h: Fix common/ includes.
13014         * osdata.c: Fix common/ includes.
13015         * obsd-nat.c: Fix common/ includes.
13016         * nat/x86-linux.c: Fix common/ includes.
13017         * nat/x86-linux-dregs.c: Fix common/ includes.
13018         * nat/x86-dregs.h: Fix common/ includes.
13019         * nat/x86-dregs.c: Fix common/ includes.
13020         * nat/ppc-linux.c: Fix common/ includes.
13021         * nat/mips-linux-watch.h: Fix common/ includes.
13022         * nat/mips-linux-watch.c: Fix common/ includes.
13023         * nat/linux-waitpid.c: Fix common/ includes.
13024         * nat/linux-ptrace.h: Fix common/ includes.
13025         * nat/linux-ptrace.c: Fix common/ includes.
13026         * nat/linux-procfs.c: Fix common/ includes.
13027         * nat/linux-personality.c: Fix common/ includes.
13028         * nat/linux-osdata.c: Fix common/ includes.
13029         * nat/linux-namespaces.c: Fix common/ includes.
13030         * nat/linux-btrace.h: Fix common/ includes.
13031         * nat/linux-btrace.c: Fix common/ includes.
13032         * nat/fork-inferior.c: Fix common/ includes.
13033         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13034         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13035         * nat/aarch64-linux.c: Fix common/ includes.
13036         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13037         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13038         * namespace.h: Fix common/ includes.
13039         * mips-linux-tdep.c: Fix common/ includes.
13040         * minsyms.c: Fix common/ includes.
13041         * mi/mi-parse.h: Fix common/ includes.
13042         * mi/mi-main.c: Fix common/ includes.
13043         * mi/mi-cmd-env.c: Fix common/ includes.
13044         * memrange.h: Fix common/ includes.
13045         * memattr.c: Fix common/ includes.
13046         * maint.h: Fix common/ includes.
13047         * maint.c: Fix common/ includes.
13048         * main.c: Fix common/ includes.
13049         * machoread.c: Fix common/ includes.
13050         * location.c: Fix common/ includes.
13051         * linux-thread-db.c: Fix common/ includes.
13052         * linux-nat.c: Fix common/ includes.
13053         * linux-fork.c: Fix common/ includes.
13054         * inline-frame.c: Fix common/ includes.
13055         * infrun.c: Fix common/ includes.
13056         * inflow.c: Fix common/ includes.
13057         * inferior.h: Fix common/ includes.
13058         * inferior.c: Fix common/ includes.
13059         * infcmd.c: Fix common/ includes.
13060         * inf-ptrace.c: Fix common/ includes.
13061         * inf-child.c: Fix common/ includes.
13062         * ia64-linux-nat.c: Fix common/ includes.
13063         * i387-tdep.c: Fix common/ includes.
13064         * i386-tdep.c: Fix common/ includes.
13065         * i386-linux-tdep.c: Fix common/ includes.
13066         * i386-linux-nat.c: Fix common/ includes.
13067         * i386-go32-tdep.c: Fix common/ includes.
13068         * i386-fbsd-tdep.c: Fix common/ includes.
13069         * i386-fbsd-nat.c: Fix common/ includes.
13070         * guile/scm-type.c: Fix common/ includes.
13071         * guile/guile.c: Fix common/ includes.
13072         * go32-nat.c: Fix common/ includes.
13073         * gnu-nat.c: Fix common/ includes.
13074         * gdbthread.h: Fix common/ includes.
13075         * gdbarch-selftests.c: Fix common/ includes.
13076         * gdb_usleep.c: Fix common/ includes.
13077         * gdb_select.h: Fix common/ includes.
13078         * gdb_bfd.c: Fix common/ includes.
13079         * gcore.c: Fix common/ includes.
13080         * fork-child.c: Fix common/ includes.
13081         * findvar.c: Fix common/ includes.
13082         * fbsd-nat.c: Fix common/ includes.
13083         * event-top.c: Fix common/ includes.
13084         * event-loop.c: Fix common/ includes.
13085         * dwarf2read.c: Fix common/ includes.
13086         * dwarf2loc.c: Fix common/ includes.
13087         * dwarf2-frame.c: Fix common/ includes.
13088         * dwarf-index-cache.c: Fix common/ includes.
13089         * dtrace-probe.c: Fix common/ includes.
13090         * disasm-selftests.c: Fix common/ includes.
13091         * defs.h: Fix common/ includes.
13092         * csky-tdep.c: Fix common/ includes.
13093         * cp-valprint.c: Fix common/ includes.
13094         * cp-support.h: Fix common/ includes.
13095         * cp-support.c: Fix common/ includes.
13096         * corelow.c: Fix common/ includes.
13097         * completer.h: Fix common/ includes.
13098         * completer.c: Fix common/ includes.
13099         * compile/compile.c: Fix common/ includes.
13100         * compile/compile-loc2c.c: Fix common/ includes.
13101         * compile/compile-cplus-types.c: Fix common/ includes.
13102         * compile/compile-cplus-symbols.c: Fix common/ includes.
13103         * command.h: Fix common/ includes.
13104         * cli/cli-dump.c: Fix common/ includes.
13105         * cli/cli-cmds.c: Fix common/ includes.
13106         * charset.c: Fix common/ includes.
13107         * build-id.c: Fix common/ includes.
13108         * btrace.h: Fix common/ includes.
13109         * btrace.c: Fix common/ includes.
13110         * breakpoint.h: Fix common/ includes.
13111         * breakpoint.c: Fix common/ includes.
13112         * ax.h:
13113         (enum agent_op): Fix common/ includes.
13114         * ax-general.c (struct aop_map): Fix common/ includes.
13115         * ax-gdb.c: Fix common/ includes.
13116         * auxv.c: Fix common/ includes.
13117         * auto-load.c: Fix common/ includes.
13118         * arm-tdep.c: Fix common/ includes.
13119         * arch/riscv.c: Fix common/ includes.
13120         * arch/ppc-linux-common.c: Fix common/ includes.
13121         * arch/i386.c: Fix common/ includes.
13122         * arch/arm.c: Fix common/ includes.
13123         * arch/arm-linux.c: Fix common/ includes.
13124         * arch/arm-get-next-pcs.c: Fix common/ includes.
13125         * arch/amd64.c: Fix common/ includes.
13126         * arch/aarch64.c: Fix common/ includes.
13127         * arch/aarch64-insn.c: Fix common/ includes.
13128         * arch-utils.c: Fix common/ includes.
13129         * amd64-windows-tdep.c: Fix common/ includes.
13130         * amd64-tdep.c: Fix common/ includes.
13131         * amd64-sol2-tdep.c: Fix common/ includes.
13132         * amd64-obsd-tdep.c: Fix common/ includes.
13133         * amd64-nbsd-tdep.c: Fix common/ includes.
13134         * amd64-linux-tdep.c: Fix common/ includes.
13135         * amd64-linux-nat.c: Fix common/ includes.
13136         * amd64-fbsd-tdep.c: Fix common/ includes.
13137         * amd64-fbsd-nat.c: Fix common/ includes.
13138         * amd64-dicos-tdep.c: Fix common/ includes.
13139         * amd64-darwin-tdep.c: Fix common/ includes.
13140         * agent.c: Fix common/ includes.
13141         * ada-lang.h: Fix common/ includes.
13142         * ada-lang.c: Fix common/ includes.
13143         * aarch64-tdep.c: Fix common/ includes.
13144
13145 2019-01-25  Tom Tromey  <tom@tromey.com>
13146
13147         * common/create-version.sh: Use common/version.h.
13148
13149 2019-01-24  Pedro Alves  <palves@redhat.com>
13150
13151         * infrun.c (signal_stop, signal_print, signal_program)
13152         (signal_catch, signal_pass): Now arrays instead of pointers.
13153         (update_signals_program_target, do_target_resume)
13154         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13155         * linux-nat.c (linux_nat_target::pass_signals)
13156         (linux_nat_target::create_inferior, linux_nat_target::attach):
13157         Adjust.
13158         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13159         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13160         * procfs.c (procfs_target::pass_signals): Adjust.
13161         * record-full.c (record_full_target::resume): Adjust.
13162         * remote.c (remote_target::pass_signals)
13163         (remote_target::program_signals): Adjust.
13164         * target-debug.h (target_debug_print_signals): Now takes a
13165         gdb::array_view as parameter.  Adjust.
13166         * target.h (target_ops) <pass_signals, program_signals>: Replace
13167         pointer and length parameters with gdb::array_view.
13168         (target_pass_signals, target_program_signals): Likewise.
13169         * target-delegates.c: Regenerate.
13170
13171 2019-01-24  Pedro Alves  <palves@redhat.com>
13172
13173         * common/forward-scope-exit.h
13174         (forward_scope_exit::forward_scope_exit): Pass arguments to
13175         m_bind_function directly, instead of creating a std::bind and
13176         copying that.
13177
13178 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13179
13180         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13181         for static members.
13182         (pass_in_v_vfp_candidate): Likewise.
13183
13184 2019-01-23  Tom Tromey  <tom@tromey.com>
13185             Pedro Alves  <palves@redhat.com>
13186
13187         * regcache.c (class regcache_invalidator): Remove.
13188         (regcache::raw_write): Use make_scope_exit.
13189
13190 2019-01-23  Tom Tromey  <tom@tromey.com>
13191
13192         * ui-out.h (class ui_out_emit_type): Update comment.
13193
13194 2019-01-23  Tom Tromey  <tom@tromey.com>
13195
13196         * infrun.c (fetch_inferior_event): Update comment.
13197
13198 2019-01-23  Tom Tromey  <tom@tromey.com>
13199             Pedro Alves  <palves@redhat.com>
13200
13201         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13202         parameter.
13203         (fetch_inferior_event): Use SCOPE_EXIT.
13204
13205
13206 2019-01-23  Tom Tromey  <tom@tromey.com>
13207             Pedro Alves  <palves@redhat.com>
13208
13209         * infrun.c (disable_thread_events): Delete.
13210         (stop_all_threads): Use SCOPE_EXIT.
13211
13212 2019-01-23  Tom Tromey  <tom@tromey.com>
13213             Pedro Alves  <palves@redhat.com>
13214
13215         * symfile.c: Include forward-scope-exit.h.
13216         (clear_symtab_users_cleanup): Replace forward declaration with
13217         a FORWARD_SCOPE_EXIT.
13218         (syms_from_objfile_1): Use the forward_scope_exit and
13219         gdb::optional instead of cleanup_function.
13220         (reread_symbols): Use the forward_scope_exit instead of
13221         cleanup_function.
13222         (clear_symtab_users_cleanup): Remove function.
13223
13224 2019-01-23  Tom Tromey  <tom@tromey.com>
13225             Pedro Alves  <palves@redhat.com>
13226
13227         * linux-nat.c: Include scope-exit.h.
13228         (cleanup_target_stop): Remove.
13229         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13230         SCOPE_EXIT.
13231
13232 2019-01-23  Tom Tromey  <tom@tromey.com>
13233             Pedro Alves  <palves@redhat.com>
13234
13235         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13236         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13237
13238 2019-01-23  Tom Tromey  <tom@tromey.com>
13239             Andrew Burgess  <andrew.burgess@embecosm.com>
13240             Pedro Alves  <palves@redhat.com>
13241
13242         * infrun.c (fetch_inferior_event): Use scope_exit.
13243         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13244         * top.c (execute_command): Use scope_exit.
13245         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13246         * utils.c (do_bpstat_clear_actions_cleanup)
13247         (make_bpstat_clear_actions_cleanup): Remove.
13248
13249 2019-01-23  Tom Tromey  <tom@tromey.com>
13250             Pedro Alves  <palves@redhat.com>
13251
13252         * infrun.c: Include "common/scope-exit.h"
13253         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13254         (wait_for_inferior): Use SCOPE_EXIT.
13255         (fetch_inferior_event): Use scope_exit.
13256
13257 2019-01-23  Tom Tromey  <tom@tromey.com>
13258             Pedro Alves  <palves@redhat.com>
13259
13260         * breakpoint.c (create_breakpoint): Remove cleanup.
13261
13262 2019-01-23  Tom Tromey  <tom@tromey.com>
13263             Andrew Burgess  <andrew.burgess@embecosm.com>
13264             Pedro Alves  <palves@redhat.com>
13265
13266 2019-01-23  Pedro Alves  <palves@redhat.com>
13267
13268         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13269
13270 2019-01-23  Pedro Alves  <palves@redhat.com>
13271             Andrew Burgess  <andrew.burgess@embecosm.com>
13272
13273         * gdbthread.h: Include "common/forward-scope-exit.h".
13274         (scoped_finish_thread_state): Redefine custom class in terms of
13275         forward_scope_exit.
13276
13277 2019-01-23  Pedro Alves  <palves@redhat.com>
13278             Andrew Burgess  <andrew.burgess@embecosm.com>
13279
13280         * common/forward-scope-exit.h: New file.
13281
13282 2019-01-23  Pedro Alves  <palves@redhat.com>
13283             Andrew Burgess  <andrew.burgess@embecosm.com>
13284             Tom Tromey  <tom@tromey.com>
13285
13286         * common/scope-exit.h: New file.
13287
13288 2019-01-23  Pedro Alves  <palves@redhat.com>
13289
13290         * common/preprocessor.h (ESC): Rename to ...
13291         (ESC_PARENS): ... this.
13292         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13293         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13294
13295 2019-01-23  Tom Tromey  <tom@tromey.com>
13296
13297         * language.h (class scoped_switch_to_sym_language_if_auto):
13298         Initialize m_lang in both cases.
13299
13300 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13301
13302         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13303         with XCNEW.
13304
13305 2019-01-22  Tom Tromey  <tom@tromey.com>
13306
13307         * corelow.c: Do not include sys/file.h.
13308
13309 2019-01-22  Tom Tromey  <tom@tromey.com>
13310
13311         * tui/tui-wingeneral.h: Include gdb_curses.h.
13312
13313 2019-01-22  Tom Tromey  <tom@tromey.com>
13314
13315         * source-cache.h (class source_cache) <get_source_lines,
13316         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13317
13318 2019-01-22  Tom Tromey  <tom@tromey.com>
13319
13320         * remote-fileio.h (struct remote_target): Declare.
13321
13322 2019-01-22  Tom Tromey  <tom@tromey.com>
13323
13324         * python/py-arch.c: Do not include py-ref.h.
13325         * python/py-bpevent.c: Do not include py-ref.h.
13326         * python/py-cmd.c: Do not include py-ref.h.
13327         * python/py-continueevent.c: Do not include py-ref.h.
13328         * python/py-event.h: Do not include py-ref.h.
13329         * python/py-evtregistry.c: Do not include py-ref.h.
13330         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13331         * python/py-frame.c: Do not include py-ref.h.
13332         * python/py-framefilter.c: Do not include py-ref.h.
13333         * python/py-function.c: Do not include py-ref.h.
13334         * python/py-infevents.c: Do not include py-ref.h.
13335         * python/py-linetable.c: Do not include py-ref.h.
13336         * python/py-objfile.c: Do not include py-ref.h.
13337         * python/py-param.c: Do not include py-ref.h.
13338         * python/py-prettyprint.c: Do not include py-ref.h.
13339         * python/py-progspace.c: Do not include py-ref.h.
13340         * python/py-symbol.c: Do not include py-ref.h.
13341         * python/py-symtab.c: Do not include py-ref.h.
13342         * python/py-type.c: Do not include py-ref.h.
13343         * python/py-unwind.c: Do not include py-ref.h.
13344         * python/py-utils.c: Do not include py-ref.h.
13345         * python/py-value.c: Do not include py-ref.h.
13346         * python/py-varobj.c: Do not include py-ref.h.
13347         * python/py-xmethods.c: Do not include py-ref.h.
13348         * python/python.c: Do not include py-ref.h.
13349         * varobj.c: Do not include py-ref.h.
13350
13351 2019-01-22  Tom Tromey  <tom@tromey.com>
13352
13353         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13354         keyword for bcache.
13355
13356 2019-01-22  Tom Tromey  <tom@tromey.com>
13357
13358         * compile/compile-cplus-types.c: Remove a comment by #include.
13359
13360 2019-01-22  Tom Tromey  <tom@tromey.com>
13361
13362         * compile/gcc-c-plugin.h: Include compile-internal.h.
13363
13364 2019-01-22  Tom Tromey  <tom@tromey.com>
13365
13366         * stabsread.c (EXTERN): Do not define.
13367         (symnum, next_symbol_text_func, processing_gcc_compilation)
13368         (within_function, global_sym_chain, global_stabs)
13369         (previous_stab_code, this_object_header_files)
13370         (n_this_object_header_files)
13371         (n_allocated_this_object_header_files): Define.
13372         * stabsread.h (EXTERN): Never define.  Use "extern".
13373
13374 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13375
13376         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13377         history_value.
13378
13379 2019-01-21  Tom Tromey  <tom@tromey.com>
13380
13381         * ui-out.c: Fix includes.
13382         * tui/tui-source.c: Fix includes.
13383         * target.c: Fix includes.
13384         * remote.c: Fix includes.
13385         * regcache.c: Fix includes.
13386         * python/py-block.c: Fix includes.
13387         * printcmd.c: Fix includes.
13388         * or1k-tdep.c: Fix includes.
13389         * mi/mi-main.c: Fix includes.
13390         * m32r-tdep.c: Fix includes.
13391         * csky-tdep.c: Fix includes.
13392         * compile/compile-cplus-types.c: Fix includes.
13393         * cli/cli-interp.c: Fix includes.
13394
13395 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13396
13397         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13398         for padding.
13399
13400 2019-01-16  Tom Tromey  <tom@tromey.com>
13401
13402         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13403         earlier.
13404         (struct objfile) <msymbols_range>: Move from top level.
13405         <msymbols>: New method.
13406         (class objfile_msymbols): Remove.
13407         * symtab.c (default_collect_symbol_completion_matches_break_on):
13408         Update.
13409         * symmisc.c (dump_msymbols): Update.
13410         * stabsread.c (scan_file_globals): Update.
13411         * objc-lang.c (info_selectors_command, info_classes_command)
13412         (find_methods): Update.
13413         * minsyms.c (find_solib_trampoline_target): Update.
13414         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13415         * coffread.c (coff_symfile_read): Update.
13416         * ada-lang.c (ada_lookup_simple_minsym)
13417         (ada_collect_symbol_completion_matches): Update.
13418
13419 2019-01-16  Tom Tromey  <tom@tromey.com>
13420
13421         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13422         type.  Remove no-argument constructor.
13423         <iterator::operator++>: Simplify.
13424         <begin>: Update.
13425         <end>: Use minimal_symbol_count.
13426
13427 2019-01-16  Tom Tromey  <tom@tromey.com>
13428
13429         * objfiles.h (struct objfile) <psymtabs>: New method.
13430         (class objfile_psymtabs): Remove.
13431         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13432         typedef.
13433         <range>: New method.
13434         (require_partial_symbols): Change return type.
13435         * psymtab.c (require_partial_symbols)
13436         (psym_expand_symtabs_matching): Update.
13437         * mdebugread.c (parse_partial_symbols): Update.
13438         * dbxread.c (dbx_end_psymtab): Update.
13439
13440 2019-01-15  Tom Tromey  <tom@tromey.com>
13441
13442         * symtab.c (lookup_objfile_from_block)
13443         (lookup_symbol_in_objfile_symtabs)
13444         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13445         (find_line_symtab, info_sources_command)
13446         (default_collect_symbol_completion_matches_break_on)
13447         (make_source_files_completion_list): Update.
13448         * symmisc.c (print_objfile_statistics, dump_objfile)
13449         (maintenance_print_symbols, maintenance_info_symtabs)
13450         (maintenance_check_symtabs, maintenance_info_line_tables):
13451         Update.
13452         * source.c (select_source_symtab)
13453         (forget_cached_source_info_for_objfile): Update.
13454         * objfiles.h (class objfile_compunits): Remove.
13455         (struct objfile) <compunits_range>: New typedef.
13456         (compunits): New method.
13457         * objfiles.c (objfile_relocate1): Update.
13458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13459         * maint.c (count_symtabs_and_blocks): Update.
13460         * linespec.c (iterate_over_all_matching_symtabs): Update.
13461         * cp-support.c (add_symbol_overload_list_qualified): Update.
13462         * coffread.c (coff_symtab_read): Update.
13463         * ada-lang.c (add_nonlocal_symbols)
13464         (ada_collect_symbol_completion_matches)
13465         (ada_add_global_exceptions): Update.
13466
13467 2019-01-15  Tom Tromey  <tom@tromey.com>
13468
13469         * progspace.h (program_space) <objfiles_safe_range>: New
13470         typedef.
13471         <objfiles_safe>: New method.
13472         * objfiles.h (class all_objfiles_safe): Remove.
13473         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13474         * jit.c (jit_inferior_exit_hook): Update.
13475
13476 2019-01-17  Tom Tromey  <tom@tromey.com>
13477
13478         * progspace.h (program_space) <objfiles_range>: New typedef.
13479         <objfiles>: New method.
13480         <objfiles_head>: Rename from objfiles.
13481         (object_files): Update.
13482         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13483         * guile/scm-pretty-print.c
13484         (ppscm_find_pretty_printer_from_objfiles): Update.
13485         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13486         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13487         Update.
13488         * python/py-progspace.c (pspy_get_objfiles): Update.
13489         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13490         Update.
13491         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13492         (objfpy_lookup_objfile_by_build_id): Update.
13493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13494         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13495         Update.
13496         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13497         (expand_symtab_containing_pc, lookup_objfile_from_block)
13498         (lookup_static_symbol, basic_lookup_transparent_type)
13499         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13500         (find_line_symtab, info_sources_command)
13501         (default_collect_symbol_completion_matches_break_on)
13502         (make_source_files_completion_list, find_main_name): Update.
13503         * symmisc.c (print_symbol_bcache_statistics)
13504         (print_objfile_statistics, maintenance_print_symbols)
13505         (maintenance_print_msymbols, maintenance_print_objfiles)
13506         (maintenance_info_symtabs, maintenance_check_symtabs)
13507         (maintenance_expand_symtabs, maintenance_info_line_tables):
13508         Update.
13509         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13510         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13511         (map_overlay_command, unmap_overlay_command)
13512         (simple_overlay_update, expand_symtabs_matching)
13513         (map_symbol_filenames): Update.
13514         * symfile-debug.c (set_debug_symfile): Update.
13515         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13516         Update.
13517         * source.c (select_source_symtab, forget_cached_source_info):
13518         Update.
13519         * solib.c (solib_read_symbols): Update.
13520         * solib-spu.c (append_ocl_sos): Update.
13521         * psymtab.c (maintenance_print_psymbols)
13522         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13523         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13524         * printcmd.c (info_symbol_command): Update.
13525         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13526         Update.
13527         * objfiles.h (class all_objfiles): Remove.
13528         * objfiles.c (have_partial_symbols, have_full_symbols)
13529         (have_minimal_symbols, qsort_cmp, update_section_map)
13530         (shared_objfile_contains_address_p)
13531         (default_iterate_over_objfiles_in_search_order): Update.
13532         * objc-lang.c (info_selectors_command, info_classes_command)
13533         (find_methods): Update.
13534         * minsyms.c (find_solib_trampoline_target): Update.
13535         * maint.c (maintenance_info_sections)
13536         (maintenance_translate_address, count_symtabs_and_blocks):
13537         Update.
13538         * main.c (captured_main_1): Update.
13539         * linux-thread-db.c (try_thread_db_load_from_pdir)
13540         (has_libpthread): Update.
13541         * linespec.c (iterate_over_all_matching_symtabs)
13542         (search_minsyms_for_name): Update.
13543         * jit.c (jit_find_objf_with_entry_addr): Update.
13544         * hppa-tdep.c (find_unwind_entry)
13545         (hppa_lookup_stub_minimal_symbol): Update.
13546         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13547         Update.
13548         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13549         (elf_gnu_ifunc_resolve_by_got): Update.
13550         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13551         * dwarf-index-write.c (save_gdb_index_command): Update.
13552         * cp-support.c (add_symbol_overload_list_qualified): Update.
13553         * breakpoint.c (create_overlay_event_breakpoint)
13554         (create_longjmp_master_breakpoint)
13555         (create_std_terminate_master_breakpoint)
13556         (create_exception_master_breakpoint): Update.
13557         * blockframe.c (find_pc_partial_function): Update.
13558         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13559         (ada_collect_symbol_completion_matches)
13560         (ada_add_global_exceptions): Update.
13561
13562 2019-01-17  Tom Tromey  <tom@tromey.com>
13563
13564         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13565         declare VEC.
13566         (solib_target_parse_libraries): Change return type.
13567         (library_list_start_segment, library_list_start_section)
13568         (library_list_end_library, library_list_start_library); Update.
13569         (solib_target_free_library_list): Remove.
13570         (solib_target_parse_libraries): Remove cleanup.  Change return
13571         type.
13572         (solib_target_current_sos): Update.
13573
13574 2019-01-17  Tom Tromey  <tromey@bapiya>
13575
13576         * valprint.c: Replace "the the" with "the".
13577         * symtab.c: Replace "the the" with "the".
13578         * solib.c: Replace "the the" with "the".
13579         * solib-dsbt.c: Replace "the the" with "the".
13580         * linespec.c: Replace "the the" with "the".
13581         * dwarf2loc.h: Replace "the the" with "the".
13582         * amd64-windows-tdep.c: Replace "the the" with "the".
13583         * aarch64-tdep.c: Replace "the the" with "the".
13584
13585 2019-01-16  Keith Seitz  <keiths@redhat.com>
13586
13587         PR gdb/23773
13588         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13589         <builder>: Rename to ..
13590         <m_builder>: ... this and make private.
13591         (dwarf2_cu::get_builder): New method.  Change all users of
13592         `builder' to use this method.
13593         (dwarf2_start_symtab): Move to ...
13594         (dwarf2_cu::start_symtab): ... here.  Update all callers
13595         (setup_type_unit_groups): Move to ...
13596         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13597         callers.
13598         (dwarf2_cu::reset_builder): New method.
13599         (process_full_compunit, process_full_type_unit): Use
13600         dwarf2_cu::reset_builder.
13601         (follow_die_offset): Record the ancestor CU if it is different
13602         from the followed DIE's CU.
13603         (follow_die_sig_1): Likewise.
13604
13605 2019-01-15  Tom Tromey  <tom@tromey.com>
13606
13607         * remote.c (class remote_state) <buf>: Now a char_vector.
13608         <buf_size>: Remove.
13609         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13610         parameter.
13611         (remote_target::getpkt_or_notif_sane_1)
13612         (remote_target::getpkt_sane)
13613         (remote_target::getpkt_or_notif_sane): Likewise.
13614         (class remote_target) <putpkt>: New overload.
13615         (remote_target::read_frame): Change type of "buf_p".  Remove
13616         sizeof_p parameter.
13617         (packet_ok): New overload.
13618         (packet_check_result): New overload.
13619         Update all uses.
13620
13621 2019-01-14  Tom Tromey  <tom@tromey.com>
13622
13623         * remote-notif.c (handle_notification, remote_notif_ack)
13624         (remote_notif_parse): Make "buf" const.
13625         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13626         const.
13627         (remote_notif_parse, remote_notif_ack, handle_notification):
13628         Likewise.
13629         * remote.c (remote_notif_stop_parse): Make "buf" const.
13630         (remote_target::remote_parse_stop_reply): Make "buf" const.
13631         (remote_notif_stop_ack): Make "buf" const.
13632
13633 2019-01-14  Tom Tromey  <tom@tromey.com>
13634
13635         * remote.c (remote_console_output): Make parameter const.
13636
13637 2019-01-14  Tom Tromey  <tom@tromey.com>
13638
13639         * target-debug.h (target_debug_print_signals): Constify.
13640         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13641         * procfs.c (procfs_target::pass_signals): Update.
13642         * linux-nat.c (linux_nat_target::pass_signals): Update.
13643         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13644         * target-delegates.c: Rebuild.
13645         * remote.c (remote_target::program_signals): Update.
13646         (remote_target::pass_signals): Update.
13647         * target.c (target_pass_signals): Constify argument.
13648         (target_program_signals): Likewise.
13649         * target.h (struct target_ops) <pass_signals, program_signals>:
13650         Constify argument.
13651         (target_pass_signals, target_program_signals): Constify argument.
13652
13653 2019-01-14  Tom Tromey  <tom@tromey.com>
13654
13655         PR tui/28819:
13656         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13657
13658 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13659
13660         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13661         field.
13662         * rs6000-tdep.c: Include reggroups.h.
13663         (IS_V_ALIAS_PSEUDOREG): Define.
13664         (rs6000_register_name): Return names for the "vX" aliases.
13665         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13666         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13667         aliases.  Call default_register_reggroup_p for all other
13668         pseudo-registers.
13669         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13670         New functions.
13671         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13672         Handle "vX" aliases.
13673         (v_alias_pseudo_register_collect): New function.
13674         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13675         (rs6000_gdbarch_init): Initialize "vX" aliases as
13676         pseudo-registers.  Restore registration of
13677         rs6000_pseudo_register_reggroup_p with
13678         set_tdesc_pseudo_register_reggroup_p.
13679
13680 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13681
13682         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13683         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13684         set_gdbarch_num_pseudo_regs.
13685
13686 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13687
13688         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13689         Remove arg prefixname, add do_set and do_show.
13690         Add member functions set_list and show_list.
13691         * cli/cli-style.c (class cli_style_option): Update accordingly.
13692         (style_set_list): Move to file scope.
13693         (style_show_list): Likewise.
13694         (set_style): Call help_list.
13695         (show_style): Call cmd_show_list.
13696         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13697         Update to use the new macro.
13698
13699 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13700
13701         * ada-lang.c (_initialize_ada_language): Expand the help text
13702         for the "catch exception" command.
13703
13704 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13705
13706         * symtab.c (matching_obj_sections): Initialize obj,
13707         declare it closer to its usage.
13708
13709 2019-01-10  Tom Tromey  <tom@tromey.com>
13710
13711         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13712         (basic_inf_threads_range): Remove.
13713         (inf_threads_range, inf_non_exited_threads_range)
13714         (safe_inf_threads_range): Use next_adapter.
13715
13716 2019-01-10  Keith Seitz  <keiths@redhat.com>
13717
13718         PR gdb/23712
13719         PR symtab/23010
13720         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13721         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13722
13723 2019-01-10  Keith Seitz  <keiths@redhat.com>
13724
13725         PR gdb/23712
13726         PR symtab/23010
13727         * dictionary.c (pending_to_vector): Remove.
13728         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13729         Remove _1 suffix, replacing functions of the same name.  Update
13730         all callers.
13731         (dict_create_hashed, dict_create_hashed_expandable)
13732         (dict_create_linear, dict_create_linear_expandable, dict_free)
13733         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13734         Make functions static.
13735
13736 2019-01-10  Keith Seitz  <keiths@redhat.com>
13737
13738         PR gdb/23712
13739         PR symtab/23010
13740         * dictionary.h (struct dictionary): Replace declaration with
13741         multidictionary.
13742         (dict_create_hashed, dict_create_hashed_expandable)
13743         (dict_create_linear, dict_create_linear_expandable)
13744         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13745         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13746         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13747         taking multidictionary argument.
13748         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13749         * block.h (struct block) <dict>: Change to multidictionary
13750         and rename `multidict'.
13751         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13752         symmisc.c: Update all dictionary references to multidictionary.
13753
13754 2019-01-10  Keith Seitz  <keiths@redhat.com>
13755
13756         PR gdb/23712
13757         PR symtab/23010
13758         * dictionary.c: Include unordered_map.
13759         (pending_to_vector): New function.
13760         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13761         Rewrite the non-"_1" functions to take vector instead
13762         of linked list.
13763         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13764         "new" _1 versions of the same name.
13765         (multidictionary): Define.
13766         (std::hash<enum language): New definition.
13767         (collate_pending_symbols_by_language, mdict_create_hashed)
13768         (mdict_create_hashed_expandable, mdict_create_linear)
13769         (mdict_create_linear_expandable, mdict_free)
13770         (find_language_dictionary, create_new_language_dictionary)
13771         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13772         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13773         (mdict_size, mdict_empty): New functions.
13774         * dictionary.h (mdict_iterator): Define.
13775
13776 2019-01-10  Pedro Alves  <palves@redhat.com>
13777
13778         * breakpoint.c (read_uploaded_action)
13779         (create_tracepoint_from_upload): Adjust to use
13780         gdb::unique_xmalloc_ptr.
13781         * ctf.c (ctf_write_uploaded_tp):
13782         (SET_ARRAY_FIELD): Use emplace_back.
13783         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13784         * tracefile-tfile.c (tfile_write_uploaded_tp):
13785         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13786         gdb::unique_xmalloc_ptr.
13787         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13788         at_string, cond_string, cmd_strings>: Replace char pointers
13789         with gdb::unique_xmalloc_ptr.
13790
13791 2019-01-10  Pedro Alves  <palves@redhat.com>
13792
13793         * solib-target.c (library_list_start_library): Don't xstrdup name.
13794
13795 2019-01-10  Pedro Alves  <palves@redhat.com>
13796
13797         * mdebugread.c (parse_partial_symbols): Use
13798         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13799
13800 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13801
13802         * linux-fork.c (scoped_switch_fork_info)
13803         <~scoped_switch_fork_info>: Fix incorrect variable name.
13804
13805 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13806
13807         * linux-fork.c (scoped_switch_fork_info)
13808         <scoped_switch_fork_info>: Make explicit.
13809         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13810
13811 2019-01-10  Tom Tromey  <tom@tromey.com>
13812
13813         * objfiles.h (objfile::reset_psymtabs): Update.
13814         * objfiles.c (objfile::objfile): Update.
13815         * psymtab.h (psymtab_storage::obstack): Update.
13816         (psymtab_storage::m_obstack): Use gdb::optional.
13817         (class psymtab_storage): Update comment.  Remove objfile
13818         parameter.
13819         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13820
13821 2019-01-10  Tom Tromey  <tom@tromey.com>
13822
13823         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13824         <free_psymtabs>: Now private.
13825         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13826         (allocate_psymtab): Use new method.
13827
13828 2019-01-10  Tom Tromey  <tom@tromey.com>
13829
13830         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13831         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13832         * mdebugread.c (parse_partial_symbols): Use
13833         allocate_dependencies.
13834         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13835         allocate_dependencies.
13836         (process_psymtab_comp_unit_reader)
13837         (build_type_psymtab_dependencies): Likewise.
13838         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13839
13840 2019-01-10  Tom Tromey  <tom@tromey.com>
13841
13842         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13843         PSYMBOL_SET_LANGUAGE.
13844         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13845
13846 2019-01-10  Tom Tromey  <tom@tromey.com>
13847
13848         * psymtab.h (psymtab_storage::obstack): New method.
13849         <m_obstack>: Rename from obstack; now private.
13850         * psymtab.c (psymtab_storage): Update.
13851         * dwarf2read.c (create_addrmap_from_index)
13852         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13853         Update.
13854
13855 2019-01-10  Tom Tromey  <tom@tromey.com>
13856
13857         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13858         * objfiles.h (objfile::reset_psymtabs): New method.
13859
13860 2019-01-10  Tom Tromey  <tom@tromey.com>
13861
13862         * symmisc.c (print_symbol_bcache_statistics): Update.
13863         (print_objfile_statistics): Update.
13864         * symfile.c (reread_symbols): Update.
13865         * psymtab.h (class psymtab_storage): New.
13866         * psymtab.c (psymtab_storage): New constructor.
13867         (~psymtab_storage): New destructor.
13868         (require_partial_symbols): Update.
13869         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13870         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13871         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13872         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13873         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13874         (start_psymtab_common, end_psymtab_common)
13875         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13876         (allocate_psymtab): Update.
13877         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13878         Update.
13879         (dump_psymtab_addrmap, maintenance_print_psymbols)
13880         (maintenance_check_psymtabs): Update.
13881         (class objfile_psymtabs): Move to objfiles.h.
13882         * psympriv.h (discard_psymtab): Now inline.
13883         (psymtab_discarder::psymtab_discarder): Update.
13884         (psymtab_discarder::~psymtab_discarder): Update.
13885         (ALL_OBJFILE_PSYMTABS): Rewrite.
13886         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13887         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13888         Remove fields.
13889         <partial_symtabs>: New field.
13890         (class objfile_psymtabs): Move from psymtab.h.  Update.
13891         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13892         psymbol_cache.
13893         (objfile::~objfile): Don't destroy psymbol_cache.
13894         * mdebugread.c (parse_partial_symbols): Update.
13895         * dwarf2read.c (create_addrmap_from_index)
13896         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13897         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13898         (add_partial_subprogram, dwarf2_ranges_read): Update.
13899         * dwarf-index-write.c (write_address_map)
13900         (write_one_signatured_type, recursively_write_psymbols)
13901         (class debug_names, class debug_names, write_psymtabs_to_index):
13902         Update.
13903
13904 2019-01-10  Tom Tromey  <tom@tromey.com>
13905
13906         * symtab.h (SYMBOL_SET_NAMES): Update.
13907         (symbol_set_names): Update.
13908         (MSYMBOL_SET_NAMES): Update.
13909         * symtab.c (symbol_set_names): Change argument to be an
13910         objfile_per_bfd_storage.
13911         * psymtab.c (add_psymbol_to_bcache): Update.
13912         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13913
13914 2019-01-10  Tom Tromey  <tom@tromey.com>
13915
13916         * symtab.c (create_demangled_names_hash): Change argument to be an
13917         objfile_per_bfd_storage.
13918         (symbol_set_names): Update.
13919
13920 2019-01-10  Tom Tromey  <tom@tromey.com>
13921
13922         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13923         init_psymbol_list.
13924         * psymtab.c (init_psymbol_list): Do nothing if already called.
13925         * psympriv.h (init_psymbol_list): Add comment.
13926         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13927         init_psymbol_list.
13928         * dbxread.c (dbx_symfile_read): Unconditionally call
13929         init_psymbol_list.
13930
13931 2019-01-10  Tom Tromey  <tom@tromey.com>
13932
13933         * xcoffread.c (scan_xcoff_symtab): Update.
13934         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13935         "where".
13936         * mdebugread.c (parse_partial_symbols)
13937         (handle_psymbol_enumerators): Update.
13938         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13939         * dbxread.c (read_dbx_symtab): Update.
13940         * psympriv.h (psymbol_placement): New enum.
13941         (add_psymbol_to_list): Update.
13942
13943 2019-01-10  Tom Tromey  <tom@tromey.com>
13944
13945         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13946         static_psymbols parameters.
13947         (scan_xcoff_symtab): Update.
13948         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13949         static_psymbols parameters.
13950         * psympriv.h (start_psymtab_common): Update.
13951         * mdebugread.c (parse_partial_symbols): Update.
13952         * dwarf2read.c (create_partial_symtab): Update.
13953         * dbxread.c (read_dbx_symtab): Update.
13954         (start_psymtab): Remove global_psymbols and static_psymbols
13955         parameters.
13956
13957 2019-01-10  Tom Tromey  <tom@tromey.com>
13958
13959         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13960         * psymtab.c (allocate_psymtab): Add comment.
13961         * psympriv.h (allocate_psymtab): Add comment.
13962         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13963         initializations.
13964         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13965
13966 2019-01-10  Tom Tromey  <tom@tromey.com>
13967
13968         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13969         Don't declare.
13970         * mipsread.c: Include mdebugread.h.
13971         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13972         Declare.
13973         * elfread.c: Include mdebugread.h.
13974
13975 2019-01-09  Tom Tromey  <tom@tromey.com>
13976
13977         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13978         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13979         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13980         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13981         (psym_lookup_symbol, psym_find_last_source_symtab)
13982         (psym_forget_cached_source_info, psym_print_stats)
13983         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13984         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13985         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13986         (psym_find_compunit_symtab_by_address)
13987         (maintenance_print_psymbols, maintenance_info_psymtabs)
13988         (maintenance_check_psymtabs): Use ranged for.
13989         * psymtab.h (class objfile_psymtabs): New.
13990         (require_partial_symbols): Return objfile_psymtabs.
13991         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13992
13993 2019-01-09  Tom Tromey  <tom@tromey.com>
13994
13995         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13996         (find_pc_mapped_section, list_overlays_command)
13997         (map_overlay_command, unmap_overlay_command)
13998         (simple_overlay_update): Use all_objfiles.
13999         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14000         * printcmd.c (info_symbol_command): Use all_objfiles.
14001         * objfiles.h (ALL_OBJSECTIONS): Remove.
14002         * maint.c (maintenance_translate_address): Use all_objfiles.
14003         * gcore.c (gcore_create_callback): Use all_objfiles.
14004         (objfile_find_memory_regions): Likewise.
14005
14006 2019-01-09  Tom Tromey  <tom@tromey.com>
14007
14008         * symtab.c (find_line_symtab, info_sources_command)
14009         (make_source_files_completion_list): Use objfile_compunits.
14010         * source.c (select_source_symtab): Use objfile_compunits.
14011         * objfiles.h (struct objfile): Update comment.
14012         (ALL_OBJFILES): Remove.
14013         (ALL_FILETABS): Remove.
14014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14015         objfile_compunits.
14016
14017 2019-01-09  Tom Tromey  <tom@tromey.com>
14018
14019         * symmisc.c (print_objfile_statistics, dump_objfile)
14020         (maintenance_print_symbols): Use compunit_filetabs.
14021         * source.c (forget_cached_source_info_for_objfile): Use
14022         compunit_filetabs.
14023         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14024         (ALL_FILETABS): Use compunit_filetabs.
14025         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14026         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14027
14028 2019-01-09  Tom Tromey  <tom@tromey.com>
14029
14030         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14031         (compunit_filetabs): New.
14032         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14033         compunit_filetabs.
14034         (info_sources_command, make_source_files_completion_list): Remove
14035         declaration.
14036         * symmisc.c (print_objfile_statistics, dump_objfile)
14037         (maintenance_print_symbols): Remove declaration.
14038         (maintenance_info_symtabs): Use compunit_filetabs.
14039         (maintenance_info_line_tables): Likewise.
14040         * source.c (select_source_symtab): Change local variable name.
14041         (forget_cached_source_info_for_objfile): Remove declaration.
14042         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14043         * objfiles.c (objfile_relocate1): Remove declaration.
14044         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14045         declaration.
14046         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14047         * coffread.c (coff_symtab_read): Remove declaration.
14048         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14049         compunit_filetabs.
14050
14051 2019-01-09  Tom Tromey  <tom@tromey.com>
14052
14053         * symtab.c (lookup_objfile_from_block)
14054         (find_pc_sect_compunit_symtab, search_symbols)
14055         (default_collect_symbol_completion_matches_break_on): Use
14056         objfile_compunits.
14057         * objfiles.h (ALL_COMPUNITS): Remove.
14058         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14059         * cp-support.c (add_symbol_overload_list_qualified): Use
14060         objfile_compunits.
14061         * ada-lang.c (ada_collect_symbol_completion_matches)
14062         (ada_add_global_exceptions): Use objfile_compunits.
14063
14064 2019-01-09  Tom Tromey  <tom@tromey.com>
14065
14066         * source.c (select_source_symtab)
14067         (forget_cached_source_info_for_objfile): Remove declaration.
14068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14069         declaration.
14070         * maint.c (count_symtabs_and_blocks): Remove declaration.
14071         * cp-support.c (add_symbol_overload_list_qualified): Remove
14072         declaration.
14073         * coffread.c (coff_symtab_read): Remove declaration.
14074         * symtab.c (lookup_symbol_in_objfile_symtabs)
14075         (basic_lookup_transparent_type_1): Use objfile_compunits.
14076         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14077         (info_sources_command, search_symbols)
14078         (default_collect_symbol_completion_matches_break_on)
14079         (make_source_files_completion_list): Remove declaration.
14080         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14081         (ada_collect_symbol_completion_matches)
14082         (ada_add_global_exceptions): Remove declaration.
14083         * linespec.c (iterate_over_all_matching_symtabs): Use
14084         objfile_compunits.
14085         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14086         (class objfile_compunits): New.
14087         (ALL_COMPUNITS): Use objfile_compunits.
14088         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14089         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14090         objfile_compunits.
14091         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14092
14093 2019-01-09  Tom Tromey  <tom@tromey.com>
14094
14095         * symtab.c (search_symbols)
14096         (default_collect_symbol_completion_matches_break_on): Use
14097         objfile_msymbols.
14098         * ada-lang.c (ada_lookup_simple_minsym)
14099         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14100         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14101         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14102         objfile_msymbols.
14103         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14104         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14105         * objc-lang.c (find_methods): Use objfile_msymbols.
14106         (info_selectors_command, info_classes_command): Likewise.
14107         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14108         * objfiles.h (class objfile_msymbols): New.
14109         (ALL_OBJFILE_MSYMBOLS): Remove.
14110         (ALL_MSYMBOLS): Remove.
14111
14112 2019-01-09  Tom Tromey  <tom@tromey.com>
14113
14114         * common/next-iterator.h (next_adapter): Add Iterator template
14115         parameter.
14116         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14117         (class all_objfiles_safe): New.
14118         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14119         * objfiles.c (put_objfile_before): Update comment.
14120         (add_separate_debug_objfile): Likewise.
14121         (free_all_objfiles): Use all_objfiles_safe.
14122         (objfile_purge_solibs): Likewise.
14123
14124 2019-01-09  Tom Tromey  <tom@tromey.com>
14125
14126         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14127         (expand_symtab_containing_pc, lookup_static_symbol)
14128         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14129         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14130         all_objfiles.
14131         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14132         * breakpoint.c (create_overlay_event_breakpoint)
14133         (create_longjmp_master_breakpoint)
14134         (create_std_terminate_master_breakpoint)
14135         (create_exception_master_breakpoint): Use all_objfiles.
14136         * linux-thread-db.c (try_thread_db_load_from_pdir)
14137         (has_libpthread): Use all_objfiles.
14138         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14139         * linespec.c (iterate_over_all_matching_symtabs)
14140         (search_minsyms_for_name): Use all_objfiles.
14141         * maint.c (maintenance_info_sections): Use all_objfiles.
14142         * main.c (captured_main_1): Use all_objfiles.
14143         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14144         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14145         * guile/scm-pretty-print.c
14146         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14147         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14148         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14149         (maintenance_print_msymbols): Use all_objfiles.
14150         * source.c (select_source_symtab): Use all_objfiles.
14151         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14152         * symfile.c (remove_symbol_file_command)
14153         (expand_symtabs_matching, map_symbol_filenames): Use
14154         all_objfiles.
14155         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14156         all_objfiles.
14157         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14158         * objc-lang.c (find_methods): Use all_objfiles.
14159         * objfiles.c (have_partial_symbols, have_full_symbols)
14160         (have_minimal_symbols, qsort_cmp)
14161         (default_iterate_over_objfiles_in_search_order): Use
14162         all_objfiles.
14163         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14164         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14165         (maintenance_check_psymtabs): Use all_objfiles.
14166         (ALL_PSYMTABS): Remove.
14167         * compile/compile-object-run.c (do_module_cleanup): Use
14168         all_objfiles.
14169         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14170         * cp-support.c (add_symbol_overload_list_qualified): Use
14171         all_objfiles.
14172         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14173         Use all_objfiles.
14174         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14175         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14176         all_objfiles.
14177         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14178         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14179         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14180         Uses all_objfiles.
14181         * solib.c (solib_read_symbols): Use all_objfiles
14182
14183 2019-01-09  Tom Tromey  <tom@tromey.com>
14184
14185         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14186         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14187         all_objfiles.
14188         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14189         * symmisc.c (print_symbol_bcache_statistics)
14190         (print_objfile_statistics, maintenance_print_objfiles)
14191         (maintenance_info_symtabs, maintenance_check_symtabs)
14192         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14193         all_objfiles.
14194         * source.c (forget_cached_source_info): Use all_objfiles.
14195         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14196         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14197         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14198         * objfiles.c (update_section_map): Use all_objfiles.
14199         (shared_objfile_contains_address_p): Likewise.
14200         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14201         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14202
14203 2019-01-09  Tom Tromey  <tom@tromey.com>
14204
14205         * common/next-iterator.h: New file.
14206         * objfiles.h (class all_objfiles): New.
14207         (struct objfile_iterator): New.
14208
14209 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14210
14211         * NEWS: Move the description of the changed "frame", "select-frame",
14212          and "info frame" commands to the Changed commands section.
14213
14214 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14215
14216         * gdbtypes.c (check_stub_method_group): Remove handling of old
14217         mangling schemes.
14218         * linespec.c (find_methods): Likewise.
14219         * stabsread.c (read_member_functions): Likewise.
14220         * valops.c (search_struct_method): Likewise.
14221         (value_struct_elt_for_reference): Likewise.
14222         * NEWS: Mention this change.
14223
14224 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14225
14226         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14227         print_source_lines.
14228         * source.c (print_source_lines_base): Update line number check.
14229         (print_source_lines): New function.
14230         (source_lines_range::source_lines_range): New function.
14231         * source.h (class source_lines_range): New class.
14232         (print_source_lines): New declaration.
14233
14234 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14235
14236         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14237
14238 2019-01-08  Tom Tromey  <tom@tromey.com>
14239             Simon Marchi  <simon.marchi@ericsson.com>
14240
14241         PR gdb/24060
14242         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14243         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14244         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14245         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14246         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14247         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14248
14249 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14250
14251         * source.c (select_source_symtab): Move header comment to
14252         declaration in source.h.
14253         (forget_cached_source_info_for_objfile): Likewise.
14254         (forget_cached_source_info): Likewise.
14255         (identify_source_line): Likewise.
14256         * source.h (identify_source_line): Move declaration from symtab.h
14257         and add comment from source.c
14258         (print_source_lines): Likewise.
14259         (forget_cached_source_info_for_objfile): Likewise.
14260         (forget_cached_source_info): Likewise.
14261         (select_source_symtab): Likewise.
14262         (enum print_source_lines_flag): Move definition from symtab.h.
14263         * symtab.h (identify_source_line): Move declaration to source.h.
14264         (print_source_lines): Likewise.
14265         (forget_cached_source_info_for_objfile): Likewise.
14266         (forget_cached_source_info): Likewise.
14267         (select_source_symtab): Likewise.
14268         (enum print_source_lines_flag): Move definition to source.h.
14269         * tui/tui-hooks.c: Add 'source.h' include.
14270
14271 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14272
14273         * source.c (print_source_lines_base): Handle requests to print
14274         reverse line number sequences, and guard against empty lines
14275         string.
14276
14277 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14278
14279         * source.c (print_source_lines_base): Fix skip of '\r' if next
14280         character is '\n'.
14281
14282 2019-01-06  Tom Tromey  <tom@tromey.com>
14283
14284         * c-exp.y (struct c_parse_state) <macro_original_text,
14285         expansion_obstack>: New member.
14286         (macro_original_text, expansion_obstack): Remove globals.
14287         (scan_macro_expansion, scanning_macro_expansion)
14288         (finished_macro_expansion): Update.
14289         (scan_macro_cleanup): Remove.
14290         (yylex, c_parse): Update.
14291
14292 2019-01-06  Tom Tromey  <tom@tromey.com>
14293
14294         * c-exp.y (struct c_parse_state) <strings>: New member.
14295         (operator_stoken): Update.
14296
14297 2019-01-06  Tom Tromey  <tom@tromey.com>
14298
14299         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14300         (union type_stack_elt) <typelist_val>: Now a pointer to
14301         std::vector.
14302         (type_stack_cleanup): Don't declare.
14303         (push_typelist): Update.
14304         * parse.c (pop_typelist): Return a std::vector.
14305         (push_typelist): Take a std::vector.
14306         (follow_types): Update.  Do not free args.
14307         (type_stack_cleanup): Remove.
14308         * c-exp.y (struct c_parse_state): New.
14309         (cpstate): New global.
14310         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14311         (nonempty_typelist): Update.
14312         (func_mod): Create a new vector.
14313         (c_parse): Create a c_parse_state.
14314         (check_parameter_typelist): Do not delete params.
14315         (function_method): Update.  Do not delete type_list.
14316
14317 2019-01-06  Tom Tromey  <tom@tromey.com>
14318
14319         PR gdb/28155:
14320         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14321         check_typedef.
14322         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14323         (print_return_value): Likewise.
14324
14325 2019-01-05  Tom Tromey  <tom@tromey.com>
14326
14327         * contrib/cleanup_check.py: Remove.
14328         * contrib/gcc-with-excheck: Remove.
14329         * contrib/exsummary.py: Remove.
14330         * contrib/excheck.py: Remove.
14331
14332 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14333
14334         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14335         NULL. Initialize tpprev to NULL instead of assigning it
14336         to NULL on the next statement.
14337         * windows-nat.c (windows_delete_thread): Remove check for
14338         main_thread_id before printing thread exit notifications.
14339         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14340         Remove thread ID check against main_thread_id.
14341         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14342         windows_delete_thread.
14343         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14344
14345 2019-01-04  Tom Tromey  <tom@tromey.com>
14346
14347         * compile/compile.c (_initialize_compile): Use upper case for
14348         metasyntactic variables.
14349         * symmisc.c (_initialize_symmisc): Use upper case for
14350         metasyntactic variables.
14351         * psymtab.c (_initialize_psymtab): Use upper case for
14352         metasyntactic variables.
14353         * demangle.c (demangle_command): Use upper case for metasyntactic
14354         variables.
14355         (_initialize_demangler): Likewise.
14356         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14357         variables.
14358
14359 2019-01-03  Tom Tromey  <tom@tromey.com>
14360
14361         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14362
14363 2019-01-03  Tom Tromey  <tom@tromey.com>
14364
14365         * python/py-symtab.c (salpy_str): Update.
14366         (struct salpy_sal_object) <symtab>: Now a PyObject.
14367         (salpy_dealloc): Update.
14368         (del_objfile_sal): Use gdbpy_ref.
14369
14370 2019-01-03  Tom Tromey  <tom@tromey.com>
14371
14372         * python/py-type.c (convert_field): Use new_reference.  Return
14373         gdbpy_ref.
14374         (make_fielditem): Return gdbpy_ref.
14375         (typy_fields): Update.
14376         (typy_getitem): Update.
14377         (field_name): Return gdbpy_ref.  Use new_reference.
14378         (typy_iterator_iternext): Update.
14379
14380 2019-01-03  Tom Tromey  <tom@tromey.com>
14381
14382         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14383
14384 2019-01-03  Tom Tromey  <tom@tromey.com>
14385
14386         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14387         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14388         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14389         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14390         (pspy_set_type_printers): Likewise.
14391         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14392         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14393         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14394         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14395         (objfpy_set_type_printers): Likewise.
14396
14397 2019-01-03  Tom Tromey  <tom@tromey.com>
14398
14399         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14400         (gdbpy_print_stack): Use gdbpy_err_fetch.
14401         * python/python-internal.h (class gdbpy_err_fetch): New class.
14402         (class gdbpy_enter) <m_error_type, m_error_value,
14403         m_error_traceback>: Remove.
14404         <m_error>: New member.
14405         (gdbpy_exception_to_string): Don't declare.
14406         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14407         * python/py-value.c (convert_value_from_python): Use
14408         gdbpy_err_fetch.
14409         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14410         gdbpy_exception_to_string.
14411         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14412         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14413         gdbpy_err_fetch.
14414
14415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14416
14417         * linux-nat.c (delete_lwp_cleanup): Delete.
14418         (struct lwp_deleter): New struct.
14419         (lwp_info_up): New typedef.
14420         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14421         lwp_info_up.
14422
14423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14424
14425         * linux-fork.c (class scoped_switch_fork_info): New class.
14426         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14427
14428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14429
14430         * valops.c (find_overload_match): Remove use of null_cleanup, and
14431         calls to do_cleanups.
14432
14433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14434
14435         * compile/compile-cplus-types.c
14436         (compile_cplus_instance::decl_name): Handle changes to
14437         cp_func_name.
14438         * cp-support.c (cp_func_name): Update header comment, update
14439         return type.
14440         * cp-support.h (cp_func_name): Update return type in declaration.
14441         * valops.c (find_overload_match): Move temp_func local to top
14442         level of function and change its type.  Use temp_func to hold and
14443         delete temporary string obtained from cp_func_name.
14444
14445 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14446
14447         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14448         gdb::char_vector, remove cleanup, and update uses of `msg`.
14449
14450 2019-01-03  Jim Wilson  <jimw@sifive.com>
14451
14452         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14453
14454 2019-01-02  Tom Tromey  <tom@tromey.com>
14455
14456         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14457         (tdesc_parse_xml): Remove cleanups.
14458         * target-descriptions.h (make_cleanup_free_target_description):
14459         Don't declare.
14460         (target_desc_deleter): New struct.
14461         (target_desc_up): New typedef.
14462         * target-descriptions.c (target_desc_deleter::operator()): Rename
14463         from free_target_description.
14464         (make_cleanup_free_target_description): Remove.
14465
14466 2019-01-02  Tom Tromey  <tom@tromey.com>
14467
14468         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14469         constructor, destructor.
14470         (linespec_parser): Remove typedef.
14471         (~linespec_parser): Rename from linespec_parser_delete.
14472         (linespec_lex_to_end, linespec_complete_label)
14473         (linespec_complete): Update.
14474         (decode_line_full): Remove cleanups.
14475         (decode_line_1): Update.
14476
14477 2019-01-02  Tom Tromey  <tom@tromey.com>
14478
14479         * python/python-internal.h (inferior_to_inferior_object): Change
14480         return type.
14481         * python/py-exitedevent.c (create_exited_event_object): Update.
14482         * python/py-inferior.c (inferior_to_inferior_object): Return
14483         gdbpy_ref.
14484         (python_new_inferior, python_inferior_deleted)
14485         (thread_to_thread_object, delete_thread_object)
14486         (build_inferior_list, gdbpy_selected_inferior): Update.
14487         * python/py-infthread.c (create_thread_object): Update.  Also fail
14488         if inferior_to_inferior_object fails.
14489
14490 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14491
14492         * inferior.h (class inferior) <displaced_step_state>: New field.
14493         * infrun.h (struct displaced_step_state): Move here from
14494         infrun.c.  Initialize fields, add constructor.
14495         <inf>: Remove field.
14496         <reset>: New method.
14497         * infrun.c (struct displaced_step_inferior_state): Move to
14498         infrun.h.
14499         (displaced_step_inferior_states): Remove.
14500         (get_displaced_stepping_state): Adust.
14501         (displaced_step_in_progress_any_inferior): Adjust.
14502         (displaced_step_in_progress_thread): Adjust.
14503         (displaced_step_in_progress): Adjust.
14504         (add_displaced_stepping_state): Remove.
14505         (get_displaced_step_closure_by_addr): Adjust.
14506         (remove_displaced_stepping_state): Remove.
14507         (infrun_inferior_exit): Call displaced_step_state.reset.
14508         (use_displaced_stepping): Don't check for NULL.
14509         (displaced_step_prepare_throw): Call
14510         get_displaced_stepping_state.
14511         (displaced_step_fixup): Don't check for NULL.
14512         (prepare_for_detach): Don't check for NULL.
14513
14514 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14515
14516         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14517          in case of call that did not complete.
14518
14519 2019-01-02  Andrey Utkin  <autkin@undo.io>
14520
14521         * symfile.c (find_separate_debug_file): Fix search of debug files for
14522         remote debuggee.
14523
14524 2019-01-02  Tom Tromey  <tom@tromey.com>
14525
14526         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14527         indentation.
14528         * python/py-frame.c (frapy_older): Remove cast.
14529         (frapy_newer): Likewise.
14530         * python/py-breakpoint.c (local_setattro): Remove cast.
14531         * python/py-arch.c (archpy_name): Remove local variable.
14532         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14533
14534 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14535
14536         * unittests/basic_string_view/element_access/char/empty.cc:
14537         Fix year range in copyright header.
14538
14539 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14540
14541         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14542         Delete.
14543         <operator==>: Update with for removed field.
14544         <hash>: Likewise.
14545         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14546         <isa_features>: ...this.
14547         <abi_features>: New field.
14548         (riscv_isa_flen): Update comment.
14549         (riscv_abi_xlen): New declaration.
14550         (riscv_abi_flen): New declaration.
14551         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14552         isa_features.
14553         (riscv_abi_xlen): New function.
14554         (riscv_isa_flen): Update to get answer from isa_features.
14555         (riscv_abi_flen): New function.
14556         (riscv_has_fp_abi): Update to get answer from abi_features.
14557         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14558         xlen and flen.
14559         (riscv_call_info) <xlen, flen>: Update comment.
14560         (riscv_call_arg_struct): Remove invalid assertions
14561         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14562         is removed.
14563         (riscv_gdbarch_init): Gather isa features and abi features
14564         separately, ensure both match on the gdbarch when reusing an old
14565         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14566         a target with 64-bit float hardware.
14567
14568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14569
14570         * source.c (search_command_helper): Stop reverse search
14571         when line 1 has been searched.
14572
14573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14574
14575         * record-full.c (record_full_base_target::close): Rewrite
14576         record_full_core_buf_list free logic.
14577
14578 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14579
14580         * break-catch-syscall.c (print_one_catch_syscall): xfree
14581         the last text.
14582
14583 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14584
14585         * top.c (print_gdb_version): Update Copyright year in version
14586         message.
14587
14588 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14589
14590         Update copyright year range in all GDB files.
14591
14592 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14593
14594         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14595
14596 For older changes see ChangeLog-2018.
14597 \f
14598 Local Variables:
14599 mode: change-log
14600 left-margin: 8
14601 fill-column: 74
14602 version-control: never
14603 coding: utf-8
14604 End:
14605