gdb/ChangeLog

   1 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * NEWS: Announce $_gdb_major and $_gdb_minor.
   4
   5         * top.c (init_gdb_version_vars): New function.
   6         (gdb_init): Call init_gdb_version_vars.
   7
   8 2019-03-29  Tom Tromey  <tromey@adacore.com>
   9
  10         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  11         help text.  Remove dead code.
  12
  13 2019-03-29  Keith Seitz  <keiths@redhat.com>
  14
  15         From Siddhesh Poyarekar:
  16         * f-lang.h (f77_get_upperbound): Return LONGEST.
  17         (f77_get_lowerbound): Likewise.
  18         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  19         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  20         print them.
  21         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  22         plongest to format print it.
  23         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  24         (f77_get_upperbound): Likewise.
  25         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  26         LOWER_BOUND to LONGEST.
  27         (f77_create_arrayprint_offset_tbl): Likewise.
  28
  29 2019-03-29  Keith Seitz  <keiths@redhat.com>
  30
  31         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  32         %s/pulongest for TYPE_LENGTH instead of %d in format
  33         strings.
  34         * ada-typerint.c (ada_print_type): Likewise.
  35         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  36         * compile/compile-c-support.c (generate_register_struct): Likewise.
  37         * gdbtypes.c (recursive_dump_type): Likewise.
  38         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  39         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  40         instead of %d in format strings.
  41         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  42         to std::min to ULONGEST.
  43         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  44         instead of %d in format strings.
  45         * tracepoint.c (info_scope_command): Likewise.
  46         * typeprint.c (print_offset_data::update)
  47         (print_offset_data::finish): Likewise.
  48         * xtensa-tdep.c (xtensa_store_return_value)
  49         (xtensa_push_dummy_call): Likewise.
  50
  51 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  52
  53         * windows-nat.c (display_selector): Fixed format specifications
  54         for 64-bit Cygwin.
  55
  56 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  57
  58         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  59
  60 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  61
  62         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  63         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  64         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  65         (nios2_linux_init_abi): Install it.
  66
  67 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  68
  69         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  70
  71 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  72
  73         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  74
  75 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  76             Tom Tromey  <tromey@adacore.com>
  77
  78         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  79
  80 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  81
  82         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  83         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  84         method to compute the bounds of range types. Also print "[evaluated]"
  85         if the bounds' values come from a dynamic evaluation.
  86
  87 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  90         whitespace when pretty printing is on.
  91
  92 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  93
  94         * ppc-linux-nat.c: Add include.
  95
  96 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  97
  98         * NEWS: Mention AArch64 Pointer Authentication.
  99
 100 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 101
 102         * arm-linux-nat.c: Add include.
 103
 104 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 105
 106         * source-cache.c (source_cache::get_source_lines): Re-read
 107         fullname after calling open_source_file.
 108
 109 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 110
 111         * NEWS: Mention TLS support for FreeBSD.
 112
 113 2019-03-25  Tom Tromey  <tromey@adacore.com>
 114
 115         * minsyms.c (BUNCH_SIZE): Update comment.
 116         (~minimal_symbol_reader): Remove old comment.
 117         (compact_minimal_symbols): Update comment.
 118         (minimal_symbol_reader::install): Remove old comment.  Update
 119         other comments.
 120
 121 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 122
 123         * s390-linux-nat.c: Add include.
 124
 125 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 126
 127         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 128         Call linux_get_hwcap.
 129         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 130         Likewise.
 131         (aarch64_linux_get_hwcap): Remove function.
 132         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 133         declaration.
 134         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 135         linux_get_hwcap.
 136         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 137         * linux-tdep.c (linux_get_hwcap): Add function.
 138         (linux_get_hwcap2): Likewise.
 139         * linux-tdep.h (linux_get_hwcap): Add declaration.
 140         (linux_get_hwcap2): Likewise.
 141         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 142         (ppc_linux_get_hwcap2): Likewise.
 143         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 144         linux_get_hwcap.
 145         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 146         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 147         (ppc_linux_nat_target::read_description): Likewise.
 148         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 149         * s390-linux-nat.c: Likewise.
 150         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 151
 152 2019-03-24  Tom Tromey  <tom@tromey.com>
 153
 154         * ada-lang.c (standard_lookup): Simplify initialization.
 155         (ada_lookup_symbol_nonlocal): Simplify return.
 156         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 157         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 158         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 159         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 160         initialization.
 161         * solib.c (solib_global_lookup): Simplify.
 162         * symtab.c (null_block_symbol): Remove.
 163         (symbol_cache_lookup): Simplify returns.
 164         (lookup_language_this): Simplify returns.
 165         (lookup_symbol_aux): Simplify return.
 166         (lookup_local_symbol): Simplify returns.
 167         (lookup_global_symbol_from_objfile): Simplify return.
 168         (lookup_symbol_in_objfile_symtabs)
 169         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 170         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 171         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 172         * cp-namespace.c (cp_lookup_bare_symbol)
 173         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 174         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 175         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 176         (cp_lookup_symbol_via_imports): Simplify initialization.
 177         (find_symbol_in_baseclass): Likewise.
 178         * symtab.h (null_block_symbol): Remove.
 179         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 180         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 181         (d_lookup_symbol_module): Likewise.
 182         (find_symbol_in_baseclass): Simplify initialization.
 183
 184 2019-03-24  Tom Tromey  <tom@tromey.com>
 185
 186         * expression.h: Don't include symtab.h.
 187         (struct block): Forward declare.
 188
 189 2019-03-24  Tom Tromey  <tom@tromey.com>
 190
 191         * c-exp.y (typebase): Remove casts.
 192         * gdbtypes.c (lookup_unsigned_typename, )
 193         (lookup_signed_typename): Remove cast.
 194         * eval.c (parse_to_comma_and_eval): Remove cast.
 195         * parse.c (write_dollar_variable): Remove cast.
 196         * block.h (struct block) <superblock>: Now const.
 197         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 198         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 199         (map_block): Make "block" const.
 200         * symfile.h (struct quick_symbol_functions)
 201         <map_matching_symbols>: Constify block argument to "callback".
 202         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 203         const.
 204         (find_pc_sect_compunit_symtab): Make "b" const.
 205         (find_symbol_at_address): Likewise.
 206         (search_symbols): Likewise.
 207         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 208         (dw2_debug_names_lookup_symbol): Likewise.
 209         (dw2_map_matching_symbols): Update.
 210         * p-valprint.c (pascal_val_print): Remove "block".
 211         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 212         (aux_add_nonlocal_symbols): Make "block" const.
 213         (resolve_subexp): Remove cast.
 214         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 215         const.
 216         (iterate_over_file_blocks): Likewise.
 217         * f-exp.y (%union) <bval>: Remove.
 218         * coffread.c (patch_opaque_types): Make "b" const.
 219         * spu-tdep.c (spu_catch_start): Make "block" const.
 220         * c-valprint.c (print_unpacked_pointer): Remove "block".
 221         * symmisc.c (dump_symtab_1): Make "b" const.
 222         (block_depth): Make "block" const.
 223         * d-exp.y (%union) <bval>: Remove.
 224         * cp-support.h (cp_lookup_rtti_type): Update.
 225         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 226         * psymtab.c (psym_lookup_symbol): Make "block" const.
 227         (maintenance_check_psymtabs): Make "b" const.
 228         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 229         (enumerate_locals, enumerate_args): Update.
 230         * python/py-symtab.c (stpy_global_block): Make "block" const.
 231         (stpy_static_block): Likewise.
 232         * inline-frame.c (block_starting_point_at): Make "new_block"
 233         const.
 234         * block.c (find_block_in_blockvector): Make return type const.
 235         (blockvector_for_pc_sect): Make "b" const.
 236         (find_block_in_blockvector): Make "b" const.
 237
 238 2019-03-23  Tom Tromey  <tom@tromey.com>
 239
 240         * varobj.c (varobj_create): Update.
 241         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 242         * printcmd.c (display_command, do_one_display): Don't reset
 243         innermost_block.
 244         * parser-defs.h (enum innermost_block_tracker_type): Move to
 245         expression.h.
 246         (innermost_block): Update comment.
 247         * parse.c (parse_exp_1): Add tracker_types parameter.
 248         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 249         tracker_types parameter.  Reset innermost_block.
 250         (parse_exp_in_context): Remove.
 251         (parse_expression_for_completion): Update.
 252         * objfiles.c (~objfile): Don't reset expression_context_block or
 253         innermost_block.
 254         * expression.h (enum innermost_block_tracker_type): Move from
 255         parser-defs.h.
 256         (parse_exp_1): Add tracker_types parameter.
 257         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 258         reset innermost_block.
 259
 260 2019-03-23  Tom Tromey  <tom@tromey.com>
 261
 262         * objfiles.h: Include bcache.h.
 263
 264 2019-03-23  Tom Tromey  <tom@tromey.com>
 265
 266         * linespec.c (get_current_search_block): Use
 267         scoped_restore_current_language.
 268         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 269
 270 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 271             Jiong Wang  <jiong.wang@arm.com>
 272
 273         * aarch64-linux-tdep.c
 274         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 275         section.
 276         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 277
 278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 279             Jiong Wang  <jiong.wang@arm.com>
 280
 281         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 282         instructions.
 283         (aarch64_analyze_prologue_test): Add PACIASP test.
 284         (aarch64_prologue_prev_register): Unmask PC value.
 285
 286 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 287             Jiong Wang  <jiong.wang@arm.com>
 288
 289         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 290         (aarch64_dwarf2_prev_register): Unmask PC value.
 291         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 292         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 293         DW_CFA_AARCH64_negate_ra_state.
 294         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 295
 296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 297             Jiong Wang  <jiong.wang@arm.com>
 298
 299         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 300         registers.
 301         (aarch64_pseudo_register_name): Likewise.
 302         (aarch64_pseudo_register_type): Likewise.
 303         (aarch64_pseudo_register_reggroup_p): Likewise.
 304         (aarch64_gdbarch_init): Add pauth registers.
 305         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 306         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 307         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 308         (struct gdbarch_tdep): Add regnum for ra_state.
 309
 310 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 311             Jiong Wang  <jiong.wang@arm.com>
 312
 313         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 314
 315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 316             Jiong Wang  <jiong.wang@arm.com>
 317
 318         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 319         function.
 320         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 321         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 322         (aarch64_gdbarch_init): Add puth registers.
 323         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 324         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 325         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 326
 327 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 328             Jiong Wang  <jiong.wang@arm.com>
 329
 330         * aarch64-linux-nat.c
 331         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 332         * aarch64-linux-tdep.c
 333         (aarch64_linux_core_read_description): Likewise.
 334         (aarch64_linux_get_hwcap): New function.
 335         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 336         (aarch64_linux_get_hwcap): New declaration.
 337
 338 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 339             Jiong Wang  <jiong.wang@arm.com>
 340
 341         * aarch64-linux-nat.c
 342         (aarch64_linux_nat_target::read_description): Add pauth param.
 343         * aarch64-linux-tdep.c
 344         (aarch64_linux_core_read_description): Likewise.
 345         * aarch64-tdep.c (struct target_desc): Add in pauth.
 346         (aarch64_read_description): Add pauth param.
 347         (aarch64_gdbarch_init): Likewise.
 348         * aarch64-tdep.h (aarch64_read_description): Likewise.
 349         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 350         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 351         * features/Makefile: Add new files.
 352         * features/aarch64-pauth.c: New file.
 353         * features/aarch64-pauth.xml: New file.
 354
 355 2019-03-20  Tom Tromey  <tromey@adacore.com>
 356
 357         * infrun.c (handle_inferior_event): Rename from
 358         handle_inferior_event_1.  Create a scoped_value_mark.
 359         (handle_inferior_event): Remove.
 360
 361 2019-03-19  Tom Tromey  <tromey@adacore.com>
 362
 363         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 364         * infrun.h (print_stop_event): Add "displays" parameter.
 365         * infrun.c (print_stop_event): Add "displays" parameter.
 366
 367 2019-03-19  Pedro Alves  <palves@redhat.com>
 368
 369         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 370         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 371         to -1.  Fix TABs vs spaces.
 372         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 373         * tui/tui-out.h (tui_ui_out) Add intro comments.
 374         <m_line, m_start_of_line>: In-class initialize, and add describing
 375         comment.
 376
 377 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 378
 379         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 380         variable names.
 381         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 382
 383 2019-03-18  Pedro Alves  <palves@redhat.com>
 384             Eli Zaretskii <eliz@gnu.org>
 385
 386         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 387         m_line and m_start_of_line.
 388
 389 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 390
 391         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 392         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 393         it returns a newline.  This fixes a regression in TU mode, whereby
 394         the next line is output on the same screen line as the user input.
 395
 396 2019-03-18  Tom Tromey  <tromey@adacore.com>
 397
 398         * minsyms.c (minimal_symbol_reader::install): Remove call to
 399         obstack_blank.
 400
 401 2019-03-18  Pedro Alves  <palves@redhat.com>
 402
 403         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 404         New globals.
 405         (apply_style): New, factored out from ...
 406         (apply_ansi_escape): ... this.  Handle reverse video mode.
 407         (tui_set_reverse_mode): New function.
 408         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 409         * tui/tui-winsource.c (tui_show_source_line): Use
 410         tui_set_reverse_mode instead of setting A_STANDOUT.
 411         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 412         New setter methods.
 413
 414 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 415
 416         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 417         Handle tabs.
 418
 419 2019-03-18  Tom Tromey  <tromey@adacore.com>
 420
 421         * ada-lang.c (empty_array): Add "high" parameter.
 422         (ada_evaluate_subexp): Update.
 423
 424 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 425
 426         * unittests/string_view-selftests.c: Define
 427         _initialize_string_view_selftests unconditionally.
 428
 429 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 430
 431         PR gdb/24350
 432         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 433
 434 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 435
 436         PR gdb/24351
 437         * windows-nat.c (display_selector): Fix format specifiers.
 438
 439 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 440
 441         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 442         tui_refill_source_window instead of tui_refresh_win, to update the
 443         current execution line.  This fixes redisplay of the current line
 444         when stepping through the code with "next" or "step".
 445
 446 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 447
 448         * source-cache.c (source_cache::get_source_lines): Call
 449         find_source_lines to initialize s->nlines.  This fixes vertical
 450         scrolling of TUI source window when the DOWN arrow is pressed.
 451
 452 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 453
 454         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 455         linux-thread-db.c (_initialize_thread_db): Likewise.
 456
 457 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 458
 459         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 460         wclrtoeol in tui_show_source_line".  This reverts changes made in
 461         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 462
 463 2019-03-15  Tom Tromey  <tom@tromey.com>
 464
 465         * symtab.h (struct minimal_symbol): Derive from
 466         general_symbol_info.
 467         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 468         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 469         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 470         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 471         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 472         (MSYMBOL_SEARCH_NAME): Update.
 473         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 474         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 475         * minsyms.c (minimal_symbol_reader::record_full): Update.
 476
 477 2019-03-15  Tom Tromey  <tom@tromey.com>
 478
 479         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 480
 481 2019-03-15  Tom Tromey  <tom@tromey.com>
 482
 483         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 484         unique_xmalloc_ptr.
 485         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 486         Update.
 487         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 488         (build_minimal_symbol_hash_tables)
 489         (minimal_symbol_reader::install): Update.
 490
 491 2019-03-15  Tom Tromey  <tom@tromey.com>
 492
 493         * symtab.c (create_demangled_names_hash): Update.
 494         (symbol_set_names): Update.
 495         * objfiles.h (struct objfile_per_bfd_storage)
 496         <demangled_names_hash>: Now an htab_up.
 497         * objfiles.c (objfile_per_bfd_storage): Simplify.
 498
 499 2019-03-15  Tom Tromey  <tom@tromey.com>
 500
 501         * objfiles.h (struct objfile_per_bfd_storage): Declare
 502         destructor.
 503         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 504         New.
 505         (get_objfile_bfd_data): Use new.  Don't initialize
 506         language_of_main.
 507         (free_objfile_per_bfd_storage): Remove.
 508         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 509
 510 2019-03-15  Tom Tromey  <tom@tromey.com>
 511
 512         * symfile.c (reread_symbols): Update.
 513         * objfiles.c (objfile::objfile): Update.
 514         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 515         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 516         comment.
 517         (minimal_symbol_reader::install): Update.
 518         (terminate_minimal_symbol_table): Remove.
 519         * jit.c (jit_object_close_impl): Update.
 520
 521 2019-03-15  Tom Tromey  <tom@tromey.com>
 522
 523         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 524         initializations.
 525
 526 2019-03-15  Tom Tromey  <tom@tromey.com>
 527
 528         * objfiles.h (struct objfile_per_bfd_storage)
 529         <demangled_hash_languages>: Now a bitset.
 530         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 531         (lookup_minimal_symbol): Update.
 532
 533 2019-03-15  Tom Tromey  <tom@tromey.com>
 534
 535         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 536         Don't return the symbol.
 537         * coffread.c (record_minimal_symbol): Use record_full.
 538
 539 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 540
 541         The MS-Windows port of ncurses fails to switch to a color pair if
 542         one or both of the colors are the implicit default colors.  This
 543         change records the default colors when TUI is initialized, and
 544         then specifies them explicitly when a color pair uses the default
 545         colors.  This allows color styling in TUI mode on MS-Windows.
 546
 547         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 548         ncurses_norm_attr.
 549         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 550         colors in ncurses_norm_attr.
 551         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 552         "none", replace it with the default color recorded in
 553         ncurses_norm_attr.
 554
 555 2019-03-14  Tom Tromey  <tromey@adacore.com>
 556
 557         * source-cache.h (class source_cache) <get_source_lines>: Return
 558         std::string.
 559         * source-cache.c (source_cache::extract_lines): Handle case where
 560         first_pos==npos.  Return std::string.
 561         (source_cache::get_source_lines): Update.
 562
 563 2019-03-14  Tom Tromey  <tromey@adacore.com>
 564
 565         * NEWS: Add item for "style sources" commands.
 566         * source-cache.c (source_cache::get_source_lines): Check
 567         source_styling.
 568         * cli/cli-style.c (source_styling): New global.
 569         (_initialize_cli_style): Add "style sources" commands.
 570         (show_style_sources): New function.
 571         * cli/cli-style.h (source_styling): Declare.
 572
 573 2019-03-14  Pedro Alves  <palves@redhat.com>
 574             Tom Tromey  <tromey@adacore.com>
 575
 576         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 577         * tui/tui-winsource.c (tui_refill_source_window): New function,
 578         from...
 579         (tui_horizontal_source_scroll): ... here.  Move some logic.
 580         * cli/cli-style.c (set_style_enabled): Notify new observable.
 581         * tui/tui-hooks.c (tui_redisplay_source): New function.
 582         (tui_attach_detach_observers): Attach or detach
 583         tui_redisplay_source.
 584         * observable.h (source_styling_changed): New observable.
 585         * observable.c: Define source_styling_changed observable.
 586
 587 2019-03-13  Tom Tromey  <tromey@adacore.com>
 588
 589         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 590         (i386_gnu_nat_target::store_registers): Update.
 591         * target-debug.h (target_debug_print_std_string): New macro.
 592         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 593         * windows-tdep.c (display_one_tib): Update.
 594         * tui/tui-stack.c (tui_make_status_line): Update.
 595         * top.c (print_inferior_quit_action): Update.
 596         * thread.c (thr_try_catch_cmd): Update.
 597         (add_thread_with_info): Update.
 598         (thread_target_id_str): Update.
 599         (thr_try_catch_cmd): Update.
 600         (thread_command): Update.
 601         (thread_find_command): Update.
 602         * record-btrace.c (record_btrace_target::info_record)
 603         (record_btrace_resume_thread, record_btrace_target::resume)
 604         (record_btrace_cancel_resume, record_btrace_step_thread)
 605         (record_btrace_target::wait, record_btrace_target::wait)
 606         (record_btrace_target::wait, record_btrace_target::stop): Update.
 607         * progspace.c (print_program_space): Update.
 608         * process-stratum-target.c
 609         (process_stratum_target::thread_address_space): Update.
 610         * linux-fork.c (linux_fork_mourn_inferior)
 611         (detach_checkpoint_command, info_checkpoints_command)
 612         (linux_fork_context): Update.
 613         (linux_fork_detach): Update.
 614         (class scoped_switch_fork_info): Update.
 615         (delete_checkpoint_command): Update.
 616         * infrun.c (follow_fork_inferior): Update.
 617         (follow_fork_inferior): Update.
 618         (proceed_after_vfork_done): Update.
 619         (handle_vfork_child_exec_or_exit): Update.
 620         (follow_exec): Update.
 621         (displaced_step_prepare_throw): Update.
 622         (displaced_step_restore): Update.
 623         (start_step_over): Update.
 624         (resume_1): Update.
 625         (clear_proceed_status_thread): Update.
 626         (proceed): Update.
 627         (print_target_wait_results): Update.
 628         (do_target_wait): Update.
 629         (context_switch): Update.
 630         (stop_all_threads): Update.
 631         (restart_threads): Update.
 632         (finish_step_over): Update.
 633         (handle_signal_stop): Update.
 634         (switch_back_to_stepped_thread): Update.
 635         (keep_going_pass_signal): Update.
 636         (print_exited_reason): Update.
 637         (normal_stop): Update.
 638         * inferior.c (inferior_pid_to_str): Change return type.
 639         (print_selected_inferior): Update.
 640         (add_inferior): Update.
 641         (detach_inferior): Update.
 642         * dummy-frame.c (fprint_dummy_frames): Update.
 643         * dcache.c (dcache_info_1): Update.
 644         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 645         (btrace_fetch, btrace_clear): Update.
 646         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 647         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 648         type.
 649         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 650         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 651         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 652         * gdbarch.c, gdbarch.h: Rebuild.
 653         * gdbarch.sh (core_pid_to_str): Change return type.
 654         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 655         return type.
 656         (windows_nat_target::pid_to_str): Change return type.
 657         (windows_delete_thread): Update.
 658         (windows_nat_target::attach): Update.
 659         (windows_nat_target::files_info): Update.
 660         * target-delegates.c: Rebuild.
 661         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 662         return type.
 663         (sol_thread_target::pid_to_str): Change return type.
 664         * remote.c (class remote_target) <pid_to_str>: Change return
 665         type.
 666         (remote_target::pid_to_str): Change return type.
 667         (extended_remote_target::attach, remote_target::remote_stop_ns)
 668         (remote_target::remote_notif_remove_queued_reply)
 669         (remote_target::push_stop_reply, remote_target::disable_btrace):
 670         Update.
 671         (extended_remote_target::attach): Update.
 672         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 673         type.
 674         (gdbsim_target::pid_to_str): Change return type.
 675         * ravenscar-thread.c (struct ravenscar_thread_target)
 676         <pid_to_str>: Change return type.
 677         (ravenscar_thread_target::pid_to_str): Change return type.
 678         * procfs.c (class procfs_target) <pid_to_str>: Change return
 679         type.
 680         (procfs_target::pid_to_str): Change return type.
 681         (procfs_target::attach): Update.
 682         (procfs_target::detach): Update.
 683         (procfs_target::fetch_registers): Update.
 684         (procfs_target::store_registers): Update.
 685         (procfs_target::wait): Update.
 686         (procfs_target::files_info): Update.
 687         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 688         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 689         return type.
 690         (nto_procfs_target::pid_to_str): Change return type.
 691         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 692         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 693         return type.
 694         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 695         (exit_lwp): Update.
 696         (attach_proc_task_lwp_callback, get_detach_signal)
 697         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 698         (linux_nat_target::resume, wait_lwp, stop_callback)
 699         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 700         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 701         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 702         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 703         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 704         type.
 705         (inf_ptrace_target::attach): Update.
 706         (inf_ptrace_target::files_info): Update.
 707         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 708         type.
 709         (go32_nat_target::pid_to_str): Change return type.
 710         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 711         (gnu_nat_target::wait): Update.
 712         (gnu_nat_target::wait): Update.
 713         (gnu_nat_target::resume): Update.
 714         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 715         (fbsd_nat_target::wait): Update.
 716         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 717         type.
 718         (darwin_nat_target::attach): Update.
 719         * corelow.c (class core_target) <pid_to_str>: Change return type.
 720         (core_target::pid_to_str): Change return type.
 721         * target.c (normal_pid_to_str): Change return type.
 722         (default_pid_to_str): Likewise.
 723         (target_pid_to_str): Change return type.
 724         (target_translate_tls_address): Update.
 725         (target_announce_detach): Update.
 726         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 727         return type.
 728         (bsd_uthread_target::pid_to_str): Change return type.
 729         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 730         type.
 731         (bsd_kvm_target::pid_to_str): Change return type.
 732         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 733         return type.
 734         (aix_thread_target::pid_to_str): Change return type.
 735         * target.h (struct target_ops) <pid_to_str>: Change return type.
 736         (target_pid_to_str, normal_pid_to_str): Likewise.
 737         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 738         type.
 739         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 740         type.
 741         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 742         return type.
 743         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 744         type.
 745         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 746         type.
 747         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 748         return type.
 749
 750 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 751
 752         * NEWS: Mention that the new default MI version is 3.  Mention
 753         changes to the output of commands and events that deal with
 754         multi-location breakpoints.
 755         * breakpoint.c: Include "mi/mi-out.h".
 756         (print_one_breakpoint): Change output syntax if using MI version
 757         >= 3.
 758         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 759         New.
 760         (mi_multi_location_breakpoint_output_fixed): New.
 761         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 762         (mi_cmd_fix_multi_location_breakpoint_output): New.
 763         (mi_multi_location_breakpoint_output_fixed): New.
 764         * mi/mi-cmds.c (mi_cmds): Register command
 765         -fix-multi-location-breakpoint-output.
 766         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 767         interpreter "mi".
 768
 769 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 770
 771         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 772         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 773         instantiate mi_ui_out based on interpreter name.
 774         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 775         * mi/mi-main.c (mi_load_progress): Likewise.
 776
 777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 778
 779         * NEWS: Combine separate "New targets" sections for 8.3.
 780
 781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 782
 783         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 784         (ppcfbsd_init_abi): Install gdbarch
 785         "fetch_tls_load_module_address" and "get_thread_local_address"
 786         methods.
 787
 788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 789
 790         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 791         (riscv_fbsd_init_abi): Install gdbarch
 792         "fetch_tls_load_module_address" and "get_thread_local_address"
 793         methods.
 794
 795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 796
 797         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 798         (i386fbsd_init_abi): Install gdbarch
 799         "fetch_tls_load_module_address" and "get_thread_local_address"
 800         methods.
 801
 802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 803
 804         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 805         (amd64fbsd_init_abi): Install gdbarch
 806         "fetch_tls_load_module_address" and "get_thread_local_address"
 807         methods.
 808
 809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 810
 811         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 812         (struct fbsd_pspace_data): New type.
 813         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 814         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 815         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 816         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 817         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 818
 819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 820
 821         * gdbtypes.c (lookup_struct_elt): New function.
 822         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 823         * gdbtypes.h (struct struct_elt): New type.
 824         (lookup_struct_elt): New prototype.
 825
 826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 827
 828         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 829         remove disabled code block.
 830
 831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 832
 833         * gdbarch.sh (get_thread_local_address): New method.
 834         * gdbarch.h, gdbarch.c: Regenerate.
 835         * target.c (target_translate_tls_address): Use
 836         gdbarch_get_thread_local_address if present instead of
 837         target::get_thread_local_address.
 838
 839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 840
 841         * target.h (target::get_thread_local_address): Update comment.
 842
 843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 846         objfile->separate_debug_objfile_backlink if not NULL.
 847
 848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 849
 850         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 851         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 852         (amd64bsd_store_inferior_registers): Likewise.
 853         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 854         Enable segment base registers.
 855         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 856         PT_GETFSBASE and PT_GETGSBASE.
 857         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 858         PT_SETGSBASE.
 859         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 860         segment base registers.
 861         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 862
 863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 864
 865         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 866         Update calls to i386_target_description to add 'segments'
 867         parameter.
 868         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 869         add segment base registers.
 870         * arch/i386.c (i386_create_target_description): Add 'segments'
 871         parameter to enable segment base registers.
 872         * arch/i386.h (i386_create_target_description): Likewise.
 873         * features/i386/32bit-segments.xml: New file.
 874         * features/i386/32bit-segments.c: Generate.
 875         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 876         call to i386_target_description to add 'segments' parameter.
 877         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 878         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 879         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 880         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 881         if feature is present.
 882         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 883         Add 'segments' parameter to call to i386_target_description.
 884         (i386_target_description): Add 'segments' parameter to enable
 885         segment base registers.
 886         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 887         to call to i386_target_description.
 888         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 889         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 890         Define I386_NUM_REGS.
 891         (i386_target_description): Add 'segments' parameter to enable
 892         segment base registers.
 893
 894 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 895
 896         PR/24325
 897         * source-cache.c: #undef open and close, to avoid unresolved
 898         externals during linking.
 899
 900 2019-03-12  Tom Tromey  <tromey@adacore.com>
 901
 902         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 903         const.  Add initializers.
 904         (_initialize_remote): Don't initialize ptid globals.
 905
 906 2019-03-12  Pedro Alves  <palves@redhat.com>
 907
 908         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 909
 910 2019-03-12  Pedro Alves  <palves@redhat.com>
 911
 912         * cp-name-parser.y (main): Remove unused 'len' variable.
 913
 914 2019-03-12  Tom Tromey  <tromey@adacore.com>
 915
 916         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 917         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 918
 919 2019-03-12  Tom Tromey  <tromey@adacore.com>
 920
 921         * linux-nat.c (iterate_over_lwps): Update.
 922         (stop_callback): Remove parameter.
 923         (stop_wait_callback, detach_callback, resume_set_callback)
 924         (select_singlestep_lwp_callback, set_ignore_sigint)
 925         (status_callback, resumed_callback, resume_clear_callback)
 926         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 927         data parameter.
 928         (linux_nat_target::detach, linux_nat_target::resume)
 929         (linux_stop_and_wait_all_lwps, select_event_lwp)
 930         (linux_nat_filter_event, linux_nat_wait_1)
 931         (linux_nat_target::kill, linux_nat_target::stop)
 932         (linux_nat_target::stop): Update.
 933         (linux_nat_resume_callback): Change type.
 934         (resume_stopped_resumed_lwps, count_events_callback)
 935         (select_event_lwp_callback): Likewise.
 936         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 937         * arm-linux-nat.c (struct update_registers_data): Remove.
 938         (update_registers_callback): Change type.
 939         (arm_linux_insert_hw_breakpoint1): Update.
 940         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 941         parameter.
 942         (x86_linux_dr_set_addr): Update.
 943         (x86_linux_dr_set_control): Update.
 944         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 945         (iterate_over_lwps): Use gdb::function_view.
 946         * nat/aarch64-linux-hw-point.c (struct
 947         aarch64_dr_update_callback_param): Remove.
 948         (debug_reg_change_callback): Change type.
 949         (aarch64_notify_debug_reg_change): Update.
 950         * s390-linux-nat.c (s390_refresh_per_info): Update.
 951
 952 2019-03-11  Tom Tromey  <tromey@adacore.com>
 953
 954         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 955         redundant assignment to "this_cu".
 956
 957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 960
 961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 962
 963         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 964         from...
 965         (rank_one_type): ... this.
 966
 967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 970         from...
 971         (rank_one_type): ... this.
 972
 973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 974
 975         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 976         from...
 977         (rank_one_type): ... this.
 978
 979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 982         from...
 983         (rank_one_type): ... this.
 984
 985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 986
 987         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 988         from...
 989         (rank_one_type): ... this.
 990
 991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 992
 993         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 994         from...
 995         (rank_one_type): ... this.
 996
 997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 998
 999         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1000         from...
1001         (rank_one_type): ... this.
1002
1003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1006         from...
1007         (rank_one_type): ... this.
1008
1009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1012         from...
1013         (rank_one_type): ... this.
1014
1015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1018         from...
1019         (rank_one_type): ... this.
1020
1021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1024         from...
1025         (rank_one_type): ... this.
1026
1027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1028
1029         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1030         from...
1031         (rank_one_type): ... this.
1032
1033 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1034
1035         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1036         inferior-events' shows the example events.
1037
1038 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1039
1040         Support styling on native MS-Windows console
1041
1042         PR/24315
1043         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1044         on MS-Windows if $TERM is not defined.
1045
1046         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1047
1048         * posix-hdep.c (gdb_console_fputs):
1049         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1050         functions.
1051         * ui-file.h (gdb_console_fputs): Add prototype.
1052
1053         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1054         back to fputs only if the former returns zero.
1055
1056 2019-03-07  Tom Tromey  <tom@tromey.com>
1057
1058         * symmisc.c (print_symbol_bcache_statistics): Update.
1059         (print_objfile_statistics): Update.
1060         * symfile.c (allocate_symtab): Update.
1061         * stabsread.c: Don't include bcache.h.
1062         * psymtab.h (struct psymbol_bcache): Don't declare.
1063         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1064         (psymbol_bcache_init, psymbol_bcache_free)
1065         (psymbol_bcache_get_bcache): Don't declare.
1066         * psymtab.c (struct psymbol_bcache): Remove.
1067         (psymtab_storage::psymtab_storage): Update.
1068         (psymtab_storage::~psymtab_storage): Update.
1069         (psymbol_bcache_init, psymbol_bcache_free)
1070         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1071         (add_psymbol_to_bcache): Update.
1072         (allocate_psymtab): Update.
1073         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1074         macro_cache>: No longer pointers.
1075         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1076         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1077         * macrotab.c (macro_bcache): Update.
1078         * macroexp.c: Don't include bcache.h.
1079         * gdbtypes.c (check_types_worklist): Update.
1080         (types_deeply_equal): Remove TRY/CATCH.  Update.
1081         * elfread.c (elf_symtab_read): Update.
1082         * dwarf2read.c: Don't include bcache.h.
1083         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1084         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1085         (print_bcache_statistics, bcache_memory_used): Don't declare.
1086         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1087         methods.  Rename all data members.
1088         * bcache.c (struct bcache): Move to bcache.h.
1089         (bcache::expand_hash_table): Rename from expand_hash_table.
1090         (bcache): Remove.
1091         (bcache::insert): Rename from bcache_full.
1092         (bcache::compare): Rename from bcache_compare.
1093         (bcache_xmalloc): Remove.
1094         (bcache::~bcache): Rename from bcache_xfree.
1095         (bcache::print_statistics): Rename from print_bcache_statistics.
1096         (bcache::memory_used): Rename from bcache_memory_used.
1097
1098 2019-03-07  Pedro Alves  <palves@redhat.com>
1099
1100         * infrun.c (normal_stop): Also check for
1101         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1102
1103 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * f-lang.c (value_from_host_double): Moved to...
1106         * value.c (value_from_host_double): ...here.
1107         * value.h (value_from_host_double): Declare.
1108         * guile/scm-math.c (vlscm_convert_typed_number): Use
1109         value_from_host_double.
1110         (vlscm_convert_number): Likewise.
1111         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1112         * python/py-value.c (convert_value_from_python): Likewise.
1113
1114 2019-03-06  Tom Tromey  <tom@tromey.com>
1115
1116         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1117
1118 2019-03-06  Tom Tromey  <tom@tromey.com>
1119
1120         * utils.h (free_current_contents): Don't declare.
1121         * utils.c (free_current_contents): Remove.
1122
1123 2019-03-06  Tom Tromey  <tom@tromey.com>
1124
1125         * top.c (quit_force): Update.
1126         * main.c (captured_command_loop): Update.
1127         * common/new-op.c (operator new): Update.
1128         * common/common-exceptions.c (struct catcher)
1129         <save_cleanup_chain>: Remove member.
1130         (exceptions_state_mc_init): Update.
1131         (exception_try_scope_entry): Return nullptr.
1132         (exception_try_scope_exit, exception_rethrow)
1133         (throw_exception_sjlj, throw_exception_cxx): Update.
1134         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1135         (all_cleanups, do_cleanups, discard_cleanups)
1136         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1137         (restore_cleanups, restore_final_cleanups): Don't declare.
1138         (do_final_cleanups): Remove parameter.
1139         * common/cleanups.c (cleanup_chain, make_cleanup)
1140         (make_cleanup_dtor, all_cleanups, do_cleanups)
1141         (discard_my_cleanups, discard_cleanups)
1142         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1143         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1144         (null_cleanup): Remove.
1145         (do_final_cleanups): Remove parameter.
1146
1147 2019-03-06  Tom Tromey  <tom@tromey.com>
1148
1149         * remote.c (remote_target::remote_parse_stop_reply): Use
1150         unique_xmalloc_ptr.
1151
1152 2019-03-06  Tom Tromey  <tom@tromey.com>
1153
1154         * stabsread.c (struct stabs_field_info): Rename from field_info.
1155         <list, fnlist>: Add initializers.
1156         <obstack>: New member.
1157         (read_member_functions, read_struct_fields, read_baseclasses):
1158         Allocate on obstack.  Don't use cleanups.
1159         (read_one_struct_field, read_member_functions, read_struct_fields)
1160         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1161         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1162         (read_struct_type): Update.
1163
1164 2019-03-06  Tom Tromey  <tom@tromey.com>
1165
1166         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1167         * common/filestuff.h (make_cleanup_close): Don't declare.
1168         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1169         Remove.
1170
1171 2019-03-06  Tom Tromey  <tom@tromey.com>
1172
1173         * solib-aix.c: Use make_scope_exit.
1174
1175 2019-03-06  Tom Tromey  <tom@tromey.com>
1176
1177         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1178         Use make_scope_exit.
1179
1180 2019-03-06  Tom Tromey  <tom@tromey.com>
1181
1182         * solib-svr4.c (disable_probes_interface): Remove parameter.
1183         (svr4_handle_solib_event): Use make_scope_exit.
1184
1185 2019-03-06  Tom Tromey  <tom@tromey.com>
1186
1187         * remote.c (struct stop_reply_deleter): Remove.
1188         (stop_reply_up): Update.
1189         (struct stop_reply): Derive from notif_event.  Don't typedef.
1190         <regcache>: Now a std::vector.
1191         (stop_reply_xfree): Remove.
1192         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1193         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1194         (remote_target::discard_pending_stop_replies): Use delete.
1195         (remote_target::remote_parse_stop_reply): Update.
1196         (remote_target::process_stop_reply): Update.
1197         * remote-notif.h (struct notif_event): Add virtual destructor.
1198         Remove "dtr" member.
1199         (struct notif_client) <alloc_event>: Return a unique_ptr.
1200         (notif_event_xfree): Don't declare.
1201         (notif_event_up): New typedef.
1202         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1203         (notif_event_xfree, do_notif_event_xfree): Remove.
1204         (remote_notif_state_xfree): Update.
1205
1206 2019-03-06  Tom Tromey  <tom@tromey.com>
1207
1208         * infrun.c (displaced_step_clear_cleanup): Now a
1209         forward_scope_exit type.
1210         (displaced_step_prepare_throw): Update.
1211         (displaced_step_fixup): Update.
1212
1213 2019-03-06  Tom Tromey  <tom@tromey.com>
1214
1215         * inferior.h (class inferior): Update comment.
1216         * gdbthread.h (class thread_info): Update comment.
1217
1218 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1219             Tom Tromey  <tom@tromey.com>
1220
1221         * stabsread.h (struct stab_section_list): Remove.
1222         (coffstab_build_psymtabs): Update.
1223         * dbxread.c (symbuf_sections): Now a std::vector.
1224         (sect_idx): New global.
1225         (fill_symbuf): Update.
1226         (coffstab_build_psymtabs): Change type of stabsects parameter.
1227         Update.
1228         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1229         std::vector.
1230         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1231         (coff_locate_sections): Update.
1232         (coff_symfile_read): Remove cleanups.  Update.
1233         (init_stringtab): Add storage parameter.
1234         (free_stringtab, free_stringtab_cleanup): Remove.
1235         (init_lineno): Add storage parameter.
1236         (free_linetab, free_linetab_cleanup): Remove.
1237
1238 2019-03-06  Pedro Alves  <palves@redhat.com>
1239
1240         * linux-fork.c (fork_info::clobber_regs): Delete.
1241         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1242         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1243         comment.  Adjust.
1244         (scoped_switch_fork_info::scoped_switch_fork_info)
1245         (checkpoint_command, linux_fork_context): Adjust
1246         fork_save_infrun_state calls.
1247
1248 2019-03-06  Pedro Alves  <palves@redhat.com>
1249
1250         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1251         (inf_has_multiple_threads): Return 'bool' and rewrite using
1252         inferior_info::threads().
1253
1254 2019-03-06  Pedro Alves  <palves@redhat.com>
1255
1256         * linux-fork.c: Include <list>.
1257         (fork_list): Now a std::list instance.
1258         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1259         (forks_exist_p, find_last_fork): Adjust.
1260         (new_fork): Delete.
1261         (one_fork_p): New.
1262         (add_fork): Adjust.
1263         (free_fork): Delete, folded into fork_info::~fork_info().
1264         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1265         Adjust.
1266         (init_fork_list): Delete.
1267         (linux_fork_killall, linux_fork_mourn_inferior)
1268         (linux_fork_detach, info_checkpoints_command): Adjust.
1269         (_initialize_linux_fork): No longer call init_fork_list.
1270
1271 2019-03-06  Pedro Alves  <palves@redhat.com>
1272
1273         * linux-fork.c (new_fork): New, split out of ...
1274         (add_fork): ... this.  Return void.  Move "first fork" special
1275         case from here, to ...
1276         (checkpoint_command): ... here.
1277         * linux-linux.h (add_fork): Return void.
1278
1279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1282
1283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1284             Chris January  <chris.january@arm.com>
1285             David Lecomber  <david.lecomber@arm.com>
1286
1287         * f-exp.y: New token, UNOP_INTRINSIC.
1288         (exp): New pattern using UNOP_INTRINSIC token.
1289         (f77_keywords): Add 'abs' keyword.
1290         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1291         (value_from_host_double): New function.
1292         (evaluate_subexp_f): Support UNOP_ABS.
1293
1294 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1297         types.
1298
1299 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1302         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1303         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1304
1305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1308
1309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1310             Chris January  <chris.january@arm.com>
1311
1312         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1313         * f-exp.y: Define 'KIND' token.
1314         (exp): New pattern for KIND expressions.
1315         (ptype): Handle types with a kind extension.
1316         (direct_abs_decl): Extend to spot kind extensions.
1317         (f77_keywords): Add 'kind' to the list.
1318         (push_kind_type): New function.
1319         (convert_to_kind_type): New function.
1320         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1321         * parse.c (operator_length_standard): Likewise.
1322         * parser-defs.h (enum type_pieces): Add tp_kind.
1323         * std-operator.def: Add UNOP_KIND.
1324
1325 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1326
1327         * f-exp.y (f_parse): Set yydebug.
1328
1329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * f-lang.c (evaluate_subexp_f): New function.
1332         (exp_descriptor_f): New global.
1333         (f_language_defn): Use exp_descriptor_f instead of
1334         exp_descriptor_standard.
1335
1336 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * f-exp.y (struct token): Add comments.
1339         (dot_ops): Remove uppercase versions and the end marker.
1340         (f77_keywords): Likewise.
1341         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1342         entries in the dot_ops array are case insensitive, and use
1343         strncasecmp to compare strings.  Also some whitespace cleanup in
1344         this area.  Similar for the f77_keywords array, except entries in
1345         this list might be case sensitive.
1346
1347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * f-exp.y (struct f77_boolean_val): Add comments.
1350         (boolean_values): Remove uppercase versions, and end marker.
1351         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1352         and use strncasecmp to achieve case insensitivity.  Additionally,
1353         perform whitespace cleanup around this code.
1354
1355 2019-03-06  Tom Tromey  <tromey@adacore.com>
1356
1357         * remote-sim.c (gdbsim_target_open): Use result of
1358         gdb_argv::release.
1359
1360 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1361         Dirk Schubert  <dirk.schubert@arm.com>
1362         Chris January  <chris.january@arm.com>
1363
1364         * eval.c (evaluate_subexp_standard): Call Fortran argument
1365         wrapping logic.
1366         * f-lang.c (struct value): A value which can be passed into a
1367         Fortran function call.
1368         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1369         where appropriate.
1370         (struct type): Value ready for a Fortran function call.
1371         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1372         is needed.
1373         * f-lang.h (fortran_argument_convert): Declaration.
1374         (fortran_preserve_arg_pointer): Declaration.
1375         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1376
1377 2019-03-05  Tom Tromey  <tromey@adacore.com>
1378
1379         * python/py-prettyprint.c (print_string_repr): Remove #if.
1380         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1381
1382 2019-03-05  Tom Tromey  <tromey@adacore.com>
1383
1384         * target.c (the_dummy_target): Move later.  Change type to
1385         "dummy_target".
1386         (initialize_targets): Don't initialize the_dummy_target.
1387
1388 2019-03-05  Tom Tromey  <tromey@adacore.com>
1389
1390         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1391         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1392
1393 2019-03-05  Tom Tromey  <tromey@adacore.com>
1394
1395         * windows-nat.c (windows_nat_target::attach)
1396         (windows_nat_target::detach): Don't call gdb_flush.
1397         * valprint.c (generic_val_print, val_print, val_print_string):
1398         Don't call gdb_flush.
1399         * utils.c (defaulted_query): Don't call gdb_flush.
1400         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1401         * target.c (target_announce_detach): Don't call gdb_flush.
1402         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1403         * remote.c (extended_remote_target::attach): Don't call
1404         gdb_flush.
1405         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1406         * printcmd.c (do_examine): Don't call gdb_flush.
1407         (info_display_command): Don't call gdb_flush.
1408         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1409         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1410         * memattr.c (info_mem_command): Don't call gdb_flush.
1411         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1412         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1413         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1414         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1415         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1416         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1417         (gnu_nat_target::detach): Don't call gdb_flush.
1418         * f-valprint.c (f_val_print): Don't call gdb_flush.
1419         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1420         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1421         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1422         gdb_flush.
1423         * c-valprint.c (c_val_print): Don't call gdb_flush.
1424         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1425
1426 2019-03-05  Tom Tromey  <tromey@adacore.com>
1427
1428         * varobj.c (update_dynamic_varobj_children): Update.
1429         (install_default_visualizer): Use reset, not release.
1430         * value.c (set_internalvar): Update.
1431         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1432         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1433         ATTRIBUTE_UNUSED_RESULT.
1434
1435 2019-03-05  Tom Tromey  <tromey@adacore.com>
1436
1437         * remote.c (class scoped_remote_fd) <release>: Add
1438         ATTRIBUTE_UNUSED_RESULT.
1439
1440 2019-03-05  Tom Tromey  <tromey@adacore.com>
1441
1442         * macroexp.c (struct macro_buffer) <release>: Add
1443         ATTRIBUTE_UNUSED_RESULT.
1444
1445 2019-03-05  Tom Tromey  <tromey@adacore.com>
1446
1447         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1448         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1449         ATTRIBUTE_UNUSED_RESULT.
1450
1451 2019-03-05  Tom Tromey  <tromey@adacore.com>
1452
1453         * common/scoped_fd.h (class scoped_fd) <release>: Add
1454         ATTRIBUTE_UNUSED_RESULT.
1455
1456 2019-03-05  Tom Tromey  <tromey@adacore.com>
1457
1458         * parser-defs.h (struct parser_state) <release>: Add
1459         ATTRIBUTE_UNUSED_RESULT.
1460
1461 2019-03-05  Tom Tromey  <tromey@adacore.com>
1462
1463         * utils.h (class gdb_argv) <release>: Add
1464         ATTRIBUTE_UNUSED_RESULT.
1465         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1466
1467 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1468
1469         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1470         for-loop range, to avoid compiler warnings.
1471
1472         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1473         avoid compiler warnings about unused variables.
1474
1475         * NEWS: Mention end of support for native debugging on MS-Windows
1476         before XP.
1477
1478         PR gdb/24292
1479         * common/netstuff.c:
1480         * gdbserver/gdbreplay.c
1481         * gdbserver/remote-utils.c:
1482         * ser-tcp.c:
1483         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1484         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1485         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1486         'getaddrinfo' and 'freeaddrinfo' were not available before
1487         Windows XP, and mingw.org's MinGW headers by default define
1488         _WIN32_WINNT to 0x500.
1489
1490 2019-03-01  Gary Benson <gbenson@redhat.com>
1491
1492         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1493
1494 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1495             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1496
1497         PR gdb/8527
1498         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1499         set_sigint_trap, clear_sigint_trap.
1500
1501 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1502
1503         * target.c (target_detach): Clear the regcache and the
1504         frame cache.
1505
1506 2019-02-27  Pedro Alves  <palves@redhat.com>
1507
1508         * utils.c (set_screen_size): When we cap the height/width sizes,
1509         tweak the corresponding command variable to show "unlimited":
1510
1511 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1512             Pedro Alves  <palves@redhat.com>
1513
1514         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1515         before calling rl_set_screen_size.
1516
1517 2019-02-27  Tom Tromey  <tromey@adacore.com>
1518
1519         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1520         define.
1521         * python/py-value.c: Remove Python 2.4 workaround.
1522         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1523         workaround.
1524         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1525         Python 2.4 workaround.
1526         * python/python-internal.h: Remove Python 2.4 comment.
1527         (Py_ssize_t): Don't define.
1528         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1529         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1530         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1531         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1532         * python/python.c (do_start_initialization): Remove Python 2.4
1533         workaround.
1534         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1535         (print_children): Remove Python 2.4 workaround.
1536         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1537         workaround.
1538         (CHARBUFFERPROC_NAME): Remove.
1539         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1540         Python 2.4 workaround.
1541
1542 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1543
1544         * NEWS: Note minimum Python version.
1545
1546 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1547
1548         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1549         code from these functions.  Remove corresponding ifdefs.  Use
1550         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1551         Remove gotos and target of gotos.
1552         (infpy_search_memory): Likewise.
1553
1554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1557         (hppa_gdbarch_init): Don't register deleted functions with
1558         gdbarch.
1559
1560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1563         (h8300_unwind_sp): Delete.
1564         (h8300_dummy_id): Delete.
1565         (h8300_gdbarch_init): Don't register deleted functions with
1566         gdbarch.
1567
1568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1571         (ft32_unwind_pc): Delete.
1572         (ft32_unwind_sp): Delete.
1573         (ft32_gdbarch_init): Don't register deleted functions with
1574         gdbarch.
1575
1576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1579         (frv_unwind_pc): Delete.
1580         (frv_unwind_sp): Delete.
1581         (frv_gdbarch_init): Don't register deleted functions with
1582         gdbarch.
1583
1584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1587         (riscv_unwind_pc): Delete.
1588         (riscv_unwind_sp): Delete.
1589         (riscv_gdbarch_init): Don't register deleted functions with
1590         gdbarch.
1591
1592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1595         (csky_unwind_pc): Delete.
1596         (csky_unwind_sp): Delete.
1597         (csky_gdbarch_init): Don't register deleted functions with
1598         gdbarch.
1599
1600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1603         (cris_unwind_pc): Delete.
1604         (cris_unwind_sp): Delete.
1605         (cris_gdbarch_init): Don't register deleted functions with
1606         gdbarch.
1607
1608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1611         (bfin_unwind_pc): Delete.
1612         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1613
1614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1617         (arm_unwind_pc): Delete.
1618         (arm_unwind_sp): Delete.
1619         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1620
1621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1624         (arc_unwind_pc): Delete.
1625         (arc_unwind_sp): Delete.
1626         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1627
1628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1631         (alpha_unwind_pc): Delete.
1632         (alpha_gdbarch_init): Don't register deleted functions with
1633         gdbarch.
1634
1635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1638         (aarch64_unwind_pc): Delete.
1639         (aarch64_unwind_sp): Delete.
1640         (aarch64_gdbarch_init): Don't register deleted functions with
1641         gdbarch.
1642
1643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * gdbtypes.c (type_align): Don't consider static members when
1646         computing structure alignment.
1647
1648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1651         return 0 for other types.
1652         * arch-utils.c (default_type_align): Always return 0.
1653         * gdbarch.h: Regenerate.
1654         * gdbarch.sh (type_align): Extend comment.
1655         * gdbtypes.c (type_align): Add additional comments, always call
1656         gdbarch_type_align before applying the default rules.
1657         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1658         generic code will then apply a suitable default.
1659         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1660         types, return 0 for other types.
1661
1662 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1663
1664         * NEWS: Create a new section for the next release branch.
1665         Rename the section of the current branch, now that it has
1666         been cut.
1667
1668 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1669
1670         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1671         * version.in: Bump version to 8.3.50.DATE-git.
1672
1673 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1674
1675         * aix-thread.c (ptid_cmp): Remove unused variable.
1676         (get_signaled_thread): Likewise.
1677         (store_regs_user_thread): Likewise.
1678         (store_regs_kernel_thread): Likewise.
1679         (fetch_regs_kernel_thread): Remove shadowed variable.
1680
1681 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * features/riscv/32bit-cpu.xml: Add register numbers.
1684         * features/riscv/32bit-fpu.c: Regenerate.
1685         * features/riscv/32bit-fpu.xml: Add register numbers.
1686         * features/riscv/64bit-cpu.xml: Add register numbers.
1687         * features/riscv/64bit-fpu.c: Regenerate.
1688         * features/riscv/64bit-fpu.xml: Add register numbers.
1689
1690 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1691
1692         * NEWS: Mention two argument form of gdb.Value constructor.
1693         * python/py-value.c (convert_buffer_and_type_to_value): New
1694         function.
1695         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1696         Add support for handling an optional second argument.  Call
1697         convert_buffer_and_type_to_value as appropriate.
1698         * python/python-internal.h (Py_buffer_deleter): New struct.
1699         (Py_buffer_up): New typedef.
1700
1701 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1702
1703         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1704         instead of releasing ownership.
1705
1706 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1707
1708         * dwarf2read.c (open_and_init_dwp_file): Call
1709         elf_numsections instead of bfd_count_sections to initialize
1710         dwp_file->num_sections.
1711
1712 2019-02-25  Tom Tromey  <tromey@adacore.com>
1713
1714         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1715
1716 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1717
1718         * gcore.in: Add '--readnever' option when invoking GDB.
1719
1720 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1721
1722         * MAINTAINERS: Update my email address.
1723
1724 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1725
1726         * build-id.c (build_id_to_debug_bfd_1): New function.
1727         (build_id_to_debug_bfd): Look for separate debug file in
1728         sysroot.
1729
1730 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1731
1732         * gdbarch.sh: Update the copyright year range that is placed into
1733         generated files.
1734
1735 2019-02-22  Keith Seitz  <keiths@redhat.com>
1736
1737         PR symtab/23853
1738         * linespec.c (create_sals_line_offset): Search for the default
1739         symtab's filename instead of its fullname.
1740
1741 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1742
1743         * NEWS: Update style defaults.
1744
1745 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1746
1747         * main.c (captured_main_1): Disable styling in batch mode.
1748
1749 2019-02-20  Tom Tromey  <tom@tromey.com>
1750
1751         * symtab.c (symtab_symbol_info): Fix typos.
1752
1753 2019-02-20  Tom Tromey  <tromey@adacore.com>
1754
1755         * findcmd.c (_initialize_mem_search): Use upper case for
1756         metasyntactic variables.
1757
1758 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1759
1760         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1761         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1762
1763 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1764
1765         * top.h (source_file_name): Change to std::string.
1766         * top.c (source_file_name): Likewise.
1767         (command_line_input): Adjust.
1768         * cli/cli-script.c (script_from_file): Adjust.
1769
1770 2019-02-19  Tom Tromey  <tromey@adacore.com>
1771
1772         * ravenscar-thread.c
1773         (ravenscar_thread_target::update_thread_list): Don't call
1774         ada_build_task_list.
1775         * ada-lang.h (ada_build_task_list): Don't declare.
1776         * ada-tasks.c (struct ada_tasks_inferior_data)
1777         <task_list_valid_p>: Now bool.
1778         (read_known_tasks, ada_task_list_changed)
1779         (ada_tasks_invalidate_inferior_data): Update.
1780         (read_known_tasks_array): Return bool.
1781         (read_known_tasks_list): Likewise.
1782         (read_known_tasks): Return void.
1783         (ada_build_task_list): Now static.
1784
1785 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1788         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1789
1790 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1791
1792         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1793         variant for ada_tasks_pspace_data_handle and
1794         ada_tasks_inferior_data_handle.
1795         (ada_tasks_pspace_data_cleanup): New function.
1796         (ada_tasks_inferior_data_cleanup): New function.
1797
1798 2019-02-17  Tom Tromey  <tom@tromey.com>
1799
1800         * macrotab.h (macro_source_fullname): Return a std::string.
1801         * macrotab.c (macro_include, check_for_redefinition)
1802         (macro_undef, macro_lookup_definition, foreach_macro)
1803         (foreach_macro_in_scope): Update.
1804         (macro_source_fullname): Return a std::string.
1805         * macrocmd.c (show_pp_source_pos): Update.
1806
1807 2019-02-17  Tom Tromey  <tom@tromey.com>
1808
1809         * macrocmd.c (show_pp_source_pos): Style the file names.
1810
1811 2019-02-17  Tom Tromey  <tom@tromey.com>
1812
1813         PR tui/24197:
1814         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1815
1816 2019-02-17  Tom Tromey  <tom@tromey.com>
1817
1818         * ada-lang.c (user_select_syms): Use filtered printing.
1819         * utils.c (wrap_style): New global.
1820         (desired_style): Remove.
1821         (emit_style_escape): Add stream parameter.
1822         (set_output_style, reset_terminal_style, prompt_for_continue):
1823         Update.
1824         (flush_wrap_buffer): Only flush gdb_stdout.
1825         (wrap_here): Set wrap_style.
1826         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1827         treat escape sequences as a character.  Change when wrap buffer is
1828         flushed.
1829         (fputs_styled): Do not set the output style when the default is
1830         requested.
1831         * ui-style.h (struct ui_file_style) <is_default>: New method.
1832         * source.c (print_source_lines_base): Emit escape sequences in one
1833         piece.
1834
1835 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1836
1837         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1838         integers and enumeration types.
1839
1840 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1841
1842         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1843         instead of lookup_symbol_in_language
1844         (do_exact_match): New function.
1845         (ada_get_symbol_name_matcher): Return do_exact_match when
1846         doing a verbatim match.
1847
1848 2019-02-15  Tom Tromey  <tromey@adacore.com>
1849
1850         * ravenscar-thread.c (ravenscar_thread_target::resume)
1851         (ravenscar_thread_target::wait): Special case wildcard requests.
1852
1853 2019-02-15  Tom Tromey  <tromey@adacore.com>
1854
1855         * ravenscar-thread.c (base_ptid): Remove.
1856         (struct ravenscar_thread_target) <close>: New method.
1857         <m_base_ptid>: New member.
1858         <update_inferior_ptid, active_task, task_is_currently_active,
1859         runtime_initialized>: Declare methods.
1860         <ravenscar_thread_target>: Add constructor.
1861         (ravenscar_thread_target::task_is_currently_active)
1862         (ravenscar_thread_target::update_inferior_ptid)
1863         (ravenscar_runtime_initialized): Rename.  Now methods.
1864         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1865         (ravenscar_thread_target::update_thread_list): Update.
1866         (ravenscar_thread_target::active_task): Now method.
1867         (ravenscar_thread_target::store_registers)
1868         (ravenscar_thread_target::prepare_to_store)
1869         (ravenscar_thread_target::prepare_to_store)
1870         (ravenscar_thread_target::mourn_inferior): Update.
1871         (ravenscar_inferior_created): Use "new" to create target.
1872         (ravenscar_thread_target::get_ada_task_ptid): Update.
1873         (_initialize_ravenscar): Don't initialize base_ptid.
1874         (ravenscar_ops): Remove global.
1875
1876 2019-02-15  Tom Tromey  <tromey@adacore.com>
1877
1878         * target.h (push_target): Declare new overload.
1879         * target.c (push_target): New overload, taking an rvalue reference.
1880         * remote.c (remote_target::open_1): Use push_target overload.
1881         * corelow.c (core_target_open): Use push_target overload.
1882
1883 2019-02-15  Tom Tromey  <tromey@adacore.com>
1884
1885         * ravenscar-thread.c (is_ravenscar_task)
1886         (ravenscar_task_is_currently_active): Return bool.
1887         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1888         (_initialize_ravenscar): Remove "(void)".
1889         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1890         Return bool.
1891
1892 2019-02-15  Tom Tromey  <tromey@adacore.com>
1893
1894         * ravenscar-thread.c (ravenscar_runtime_initializer)
1895         (has_ravenscar_runtime, get_running_thread_id)
1896         (ravenscar_thread_target::resume): Fix indentation.
1897
1898 2019-02-15  Tom Tromey  <tromey@adacore.com>
1899
1900         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1901         from ravenscar_arch_ops.
1902         (sparc_ravenscar_ops::fetch_registers)
1903         (sparc_ravenscar_ops::store_registers): Now methods.
1904         (sparc_ravenscar_prepare_to_store): Remove.
1905         (sparc_ravenscar_ops): Redefine.
1906         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1907         methods and destructor.  Remove members.
1908         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1909         (ravenscar_thread_target::store_registers)
1910         (ravenscar_thread_target::prepare_to_store): Update.
1911         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1912         Remove.
1913         (struct ppc_ravenscar_powerpc_ops): Derive from
1914         ravenscar_arch_ops.
1915         (ppc_ravenscar_powerpc_ops::fetch_registers)
1916         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1917         (ppc_ravenscar_powerpc_ops): Redefine.
1918         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1919         (ppc_ravenscar_e500_ops::fetch_registers)
1920         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1921         (ppc_ravenscar_e500_ops): Redefine.
1922         * aarch64-ravenscar-thread.c
1923         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1924         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1925         (aarch64_ravenscar_fetch_registers)
1926         (aarch64_ravenscar_store_registers): Now methods.
1927         (aarch64_ravenscar_ops): Redefine.
1928
1929 2019-02-15  Tom Tromey  <tromey@adacore.com>
1930
1931         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1932         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1933         (ravenscar_thread_target::stopped_by_watchpoint)
1934         (ravenscar_thread_target::stopped_data_address)
1935         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1936
1937 2019-02-15  Tom Tromey  <tromey@adacore.com>
1938
1939         * ravenscar-thread.c: Fix some typos.
1940
1941 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942             Tom Tromey  <tromey@adacore.com>
1943
1944         * ada-lang.c (ada_exception_sal): Change addr_string to a
1945         std::string.
1946         (create_ada_exception_catchpoint): Update.
1947
1948 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1949             Tom Tromey  <tromey@adacore.com>
1950
1951         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1952         (bp_location_ops): Remove.
1953         (base_breakpoint_allocate_location): Update.
1954         (free_bp_location): Update.
1955         * ada-lang.c (class ada_catchpoint_location)
1956         <ada_catchpoint_location>: Remove ops parameter.
1957         (ada_catchpoint_location_dtor): Remove.
1958         (ada_catchpoint_location_ops): Remove.
1959         (allocate_location_exception): Update.
1960         * breakpoint.h (struct bp_location_ops): Remove.
1961         (class bp_location) <bp_location>: Remove bp_location_ops
1962         parameter.
1963         <~bp_location>: Add destructor.
1964         <ops>: Remove.
1965
1966 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1967             Pedro Alves  <palves@redhat.com>
1968
1969         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1970         'PATH_MAX'.
1971
1972 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1973             Samuel Thibault  <samuel.thibault@gnu.org>
1974             Thomas Schwinge  <thomas@codesourcery.com>
1975
1976         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1977         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1978
1979 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1980
1981         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1982         (check_empty): Use "const char *".
1983
1984         * gnu-nat.c (gnu_nat_target::detach): Instead of
1985         'detach_inferior (pid)' call
1986         'detach_inferior (find_inferior_pid (pid))'.
1987
1988         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1989         'nat/fork-inferior.o'.
1990         * gnu-nat.c: #include "nat/fork-inferior.h".
1991
1992         * gnu-nat.c (gnu_nat_target::detach): Instead of
1993         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1994         * gnu-nat.h: #include "inf-child.h".
1995         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1996         'i386_gnu_nat_target::fetch_registers'.
1997         (gnu_store_registers): Rename/move to
1998         'i386_gnu_nat_target::store_registers'.
1999
2000         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2001         * gnu-nat.h (mach_thread_info): New function.
2002         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2003
2004         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2005
2006 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2007
2008         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2009
2010 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2011
2012         * windows-nat.c (windows_add_thread): Add new parameter
2013         "main_thread_p" with default value set to false.  Update
2014         function documentation as well as all callers.
2015         (windows_delete_thread): Likewise.
2016         (fake_create_process): Update call to windows_add_thread.
2017         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2018         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2019         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2020         call to windows_delete_thread.
2021
2022 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2023
2024         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2025
2026 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2027
2028         * symfile.c (find_separate_debug_file): Use canonical path of
2029         sysroot with child_path instead of gdb_sysroot if it is valid.
2030
2031 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2032
2033         * symfile.c (find_separate_debug_file): Use child_path to
2034         determine if an object file is under a sysroot.
2035
2036 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2037
2038         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2039         unittests/child-path-selftests.c.
2040         * common/pathstuff.c (child_path): New function.
2041         * common/pathstuff.h (child_path): New prototype.
2042         * unittests/child-path-selftests.c: New file.
2043
2044 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2045
2046         * symfile.c (find_separate_debug_file): Look for separate debug
2047         files in debug directories under the sysroot.
2048
2049 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2050
2051         * symtab.h (struct minimal_symbol data_p): New const method.
2052         (struct minimal_symbol text_p): Likewise.
2053         * symtab.c (output_source_filename): Use file name style
2054         to print file name.
2055         (print_symbol_info): Likewise.
2056         (print_msymbol_info): Use address style to print addresses.
2057         Use function name style to print executable text symbols.
2058         (expand_symtab_containing_pc): Use data_p.
2059         (find_pc_sect_compunit_symtab): Likewise.
2060
2061 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2062
2063         * breakpoint.c (describe_other_breakpoints): Use address style
2064         to print addresses.
2065         (say_where): Likewise.
2066
2067 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2068
2069         * ada-typeprint.c (print_func_type): Print function name
2070         style to print function name.
2071         * c-typeprint.c (c_print_type_1): Likewise.
2072
2073 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2074
2075         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2076         for execve.
2077
2078 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2081         type_stack.
2082
2083 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2084
2085         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2086         TYPE_CODE_REF types.
2087
2088 2019-02-08  Jim Wilson  <jimw@sifive.com>
2089
2090         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2091         (riscv_linux_fregset): New.
2092         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2093
2094 2019-02-07  Tom Tromey  <tom@tromey.com>
2095
2096         * thread.c (thread_cancel_execution_command): Update.
2097         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2098         methods.
2099         (struct thread_fsm_ops): Remove.
2100         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2101         (thread_fsm_should_stop, thread_fsm_return_value)
2102         (thread_fsm_set_finished, thread_fsm_finished_p)
2103         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2104         Don't declare.
2105         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2106         * infrun.c (clear_proceed_status_thread)
2107         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2108         (print_stop_event): Update.
2109         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2110         Add constructor.
2111         (step_command_fsm_ops): Remove.
2112         (new_step_command_fsm): Remove.
2113         (step_1): Update.
2114         (step_command_fsm::should_stop): Rename from
2115         step_command_fsm_should_stop.
2116         (step_command_fsm::clean_up): Rename from
2117         step_command_fsm_clean_up.
2118         (step_command_fsm::do_async_reply_reason): Rename from
2119         step_command_fsm_async_reply_reason.
2120         (struct until_next_fsm): Inherit from thread_fsm.  Add
2121         constructor.
2122         (until_next_fsm_ops): Remove.
2123         (new_until_next_fsm): Remove.
2124         (until_next_fsm::should_stop): Rename from
2125         until_next_fsm_should_stop.
2126         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2127         (until_next_fsm::do_async_reply_reason): Rename from
2128         until_next_fsm_async_reply_reason.
2129         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2130         constructor.  Change type of breakpoint.
2131         (finish_command_fsm_ops): Remove.
2132         (new_finish_command_fsm): Remove.
2133         (finish_command_fsm::should_stop): Rename from
2134         finish_command_fsm_should_stop.
2135         (finish_command_fsm::clean_up): Rename from
2136         finish_command_fsm_clean_up.
2137         (finish_command_fsm::return_value): Rename from
2138         finish_command_fsm_return_value.
2139         (finish_command_fsm::do_async_reply_reason): Rename from
2140         finish_command_fsm_async_reply_reason.
2141         (finish_command): Update.
2142         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2143         Add constructor.
2144         (call_thread_fsm_ops): Remove.
2145         (call_thread_fsm::call_thread_fsm): Rename from
2146         new_call_thread_fsm.
2147         (call_thread_fsm::should_stop): Rename from
2148         call_thread_fsm_should_stop.
2149         (call_thread_fsm::should_notify_stop): Rename from
2150         call_thread_fsm_should_notify_stop.
2151         (run_inferior_call, call_function_by_hand_dummy): Update.
2152         * cli/cli-interp.c (should_print_stop_to_console): Update.
2153         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2154         Add constructor.  Change type of location_breakpoint,
2155         caller_breakpoint.
2156         (until_break_fsm_ops): Remove.
2157         (new_until_break_fsm): Remove.
2158         (until_break_fsm::should_stop): Rename from
2159         until_break_fsm_should_stop.
2160         (until_break_fsm::clean_up): Rename from
2161         until_break_fsm_clean_up.
2162         (until_break_fsm::do_async_reply_reason): Rename from
2163         until_break_fsm_async_reply_reason.
2164         (until_break_command): Update.
2165         * thread-fsm.c: Remove.
2166         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2167
2168 2019-02-07  Tom Tromey  <tom@tromey.com>
2169
2170         * yy-remap.h: Add include guard.
2171         * xtensa-tdep.h: Add include guard.
2172         * xcoffread.h: Rename include guard.
2173         * varobj-iter.h: Add include guard.
2174         * tui/tui.h: Rename include guard.
2175         * tui/tui-winsource.h: Rename include guard.
2176         * tui/tui-wingeneral.h: Rename include guard.
2177         * tui/tui-windata.h: Rename include guard.
2178         * tui/tui-win.h: Rename include guard.
2179         * tui/tui-stack.h: Rename include guard.
2180         * tui/tui-source.h: Rename include guard.
2181         * tui/tui-regs.h: Rename include guard.
2182         * tui/tui-out.h: Rename include guard.
2183         * tui/tui-layout.h: Rename include guard.
2184         * tui/tui-io.h: Rename include guard.
2185         * tui/tui-hooks.h: Rename include guard.
2186         * tui/tui-file.h: Rename include guard.
2187         * tui/tui-disasm.h: Rename include guard.
2188         * tui/tui-data.h: Rename include guard.
2189         * tui/tui-command.h: Rename include guard.
2190         * tic6x-tdep.h: Add include guard.
2191         * target/waitstatus.h: Rename include guard.
2192         * target/wait.h: Rename include guard.
2193         * target/target.h: Rename include guard.
2194         * target/resume.h: Rename include guard.
2195         * target-float.h: Rename include guard.
2196         * stabsread.h: Add include guard.
2197         * rs6000-tdep.h: Add include guard.
2198         * riscv-fbsd-tdep.h: Add include guard.
2199         * regformats/regdef.h: Rename include guard.
2200         * record.h: Rename include guard.
2201         * python/python.h: Rename include guard.
2202         * python/python-internal.h: Rename include guard.
2203         * python/py-stopevent.h: Rename include guard.
2204         * python/py-ref.h: Rename include guard.
2205         * python/py-record.h: Rename include guard.
2206         * python/py-record-full.h: Rename include guard.
2207         * python/py-record-btrace.h: Rename include guard.
2208         * python/py-instruction.h: Rename include guard.
2209         * python/py-events.h: Rename include guard.
2210         * python/py-event.h: Rename include guard.
2211         * procfs.h: Add include guard.
2212         * proc-utils.h: Add include guard.
2213         * p-lang.h: Add include guard.
2214         * or1k-tdep.h: Rename include guard.
2215         * observable.h: Rename include guard.
2216         * nto-tdep.h: Rename include guard.
2217         * nat/x86-linux.h: Rename include guard.
2218         * nat/x86-linux-dregs.h: Rename include guard.
2219         * nat/x86-gcc-cpuid.h: Add include guard.
2220         * nat/x86-dregs.h: Rename include guard.
2221         * nat/x86-cpuid.h: Rename include guard.
2222         * nat/ppc-linux.h: Rename include guard.
2223         * nat/mips-linux-watch.h: Rename include guard.
2224         * nat/linux-waitpid.h: Rename include guard.
2225         * nat/linux-ptrace.h: Rename include guard.
2226         * nat/linux-procfs.h: Rename include guard.
2227         * nat/linux-osdata.h: Rename include guard.
2228         * nat/linux-nat.h: Rename include guard.
2229         * nat/linux-namespaces.h: Rename include guard.
2230         * nat/linux-btrace.h: Rename include guard.
2231         * nat/glibc_thread_db.h: Rename include guard.
2232         * nat/gdb_thread_db.h: Rename include guard.
2233         * nat/gdb_ptrace.h: Rename include guard.
2234         * nat/fork-inferior.h: Rename include guard.
2235         * nat/amd64-linux-siginfo.h: Rename include guard.
2236         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2237         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2238         * nat/aarch64-linux.h: Rename include guard.
2239         * nat/aarch64-linux-hw-point.h: Rename include guard.
2240         * mn10300-tdep.h: Add include guard.
2241         * mips-linux-tdep.h: Add include guard.
2242         * mi/mi-parse.h: Rename include guard.
2243         * mi/mi-out.h: Rename include guard.
2244         * mi/mi-main.h: Rename include guard.
2245         * mi/mi-interp.h: Rename include guard.
2246         * mi/mi-getopt.h: Rename include guard.
2247         * mi/mi-console.h: Rename include guard.
2248         * mi/mi-common.h: Rename include guard.
2249         * mi/mi-cmds.h: Rename include guard.
2250         * mi/mi-cmd-break.h: Rename include guard.
2251         * m2-lang.h: Add include guard.
2252         * location.h: Rename include guard.
2253         * linux-record.h: Rename include guard.
2254         * linux-nat.h: Add include guard.
2255         * linux-fork.h: Add include guard.
2256         * i386-darwin-tdep.h: Rename include guard.
2257         * hppa-linux-offsets.h: Add include guard.
2258         * guile/guile.h: Rename include guard.
2259         * guile/guile-internal.h: Rename include guard.
2260         * gnu-nat.h: Rename include guard.
2261         * gdb-stabs.h: Rename include guard.
2262         * frv-tdep.h: Add include guard.
2263         * f-lang.h: Add include guard.
2264         * event-loop.h: Add include guard.
2265         * darwin-nat.h: Rename include guard.
2266         * cp-abi.h: Rename include guard.
2267         * config/sparc/nm-sol2.h: Rename include guard.
2268         * config/nm-nto.h: Rename include guard.
2269         * config/nm-linux.h: Add include guard.
2270         * config/i386/nm-i386gnu.h: Rename include guard.
2271         * config/djgpp/nl_types.h: Rename include guard.
2272         * config/djgpp/langinfo.h: Rename include guard.
2273         * compile/gcc-cp-plugin.h: Add include guard.
2274         * compile/gcc-c-plugin.h: Add include guard.
2275         * compile/compile.h: Rename include guard.
2276         * compile/compile-object-run.h: Rename include guard.
2277         * compile/compile-object-load.h: Rename include guard.
2278         * compile/compile-internal.h: Rename include guard.
2279         * compile/compile-cplus.h: Rename include guard.
2280         * compile/compile-c.h: Rename include guard.
2281         * common/xml-utils.h: Rename include guard.
2282         * common/x86-xstate.h: Rename include guard.
2283         * common/version.h: Rename include guard.
2284         * common/vec.h: Rename include guard.
2285         * common/tdesc.h: Rename include guard.
2286         * common/selftest.h: Rename include guard.
2287         * common/scoped_restore.h: Rename include guard.
2288         * common/scoped_mmap.h: Rename include guard.
2289         * common/scoped_fd.h: Rename include guard.
2290         * common/safe-iterator.h: Rename include guard.
2291         * common/run-time-clock.h: Rename include guard.
2292         * common/refcounted-object.h: Rename include guard.
2293         * common/queue.h: Rename include guard.
2294         * common/ptid.h: Rename include guard.
2295         * common/print-utils.h: Rename include guard.
2296         * common/preprocessor.h: Rename include guard.
2297         * common/pathstuff.h: Rename include guard.
2298         * common/observable.h: Rename include guard.
2299         * common/netstuff.h: Rename include guard.
2300         * common/job-control.h: Rename include guard.
2301         * common/host-defs.h: Rename include guard.
2302         * common/gdb_wait.h: Rename include guard.
2303         * common/gdb_vecs.h: Rename include guard.
2304         * common/gdb_unlinker.h: Rename include guard.
2305         * common/gdb_unique_ptr.h: Rename include guard.
2306         * common/gdb_tilde_expand.h: Rename include guard.
2307         * common/gdb_sys_time.h: Rename include guard.
2308         * common/gdb_string_view.h: Rename include guard.
2309         * common/gdb_splay_tree.h: Rename include guard.
2310         * common/gdb_setjmp.h: Rename include guard.
2311         * common/gdb_ref_ptr.h: Rename include guard.
2312         * common/gdb_optional.h: Rename include guard.
2313         * common/gdb_locale.h: Rename include guard.
2314         * common/gdb_assert.h: Rename include guard.
2315         * common/filtered-iterator.h: Rename include guard.
2316         * common/filestuff.h: Rename include guard.
2317         * common/fileio.h: Rename include guard.
2318         * common/environ.h: Rename include guard.
2319         * common/common-utils.h: Rename include guard.
2320         * common/common-types.h: Rename include guard.
2321         * common/common-regcache.h: Rename include guard.
2322         * common/common-inferior.h: Rename include guard.
2323         * common/common-gdbthread.h: Rename include guard.
2324         * common/common-exceptions.h: Rename include guard.
2325         * common/common-defs.h: Rename include guard.
2326         * common/common-debug.h: Rename include guard.
2327         * common/cleanups.h: Rename include guard.
2328         * common/buffer.h: Rename include guard.
2329         * common/btrace-common.h: Rename include guard.
2330         * common/break-common.h: Rename include guard.
2331         * cli/cli-utils.h: Rename include guard.
2332         * cli/cli-style.h: Rename include guard.
2333         * cli/cli-setshow.h: Rename include guard.
2334         * cli/cli-script.h: Rename include guard.
2335         * cli/cli-interp.h: Rename include guard.
2336         * cli/cli-decode.h: Rename include guard.
2337         * cli/cli-cmds.h: Rename include guard.
2338         * charset-list.h: Add include guard.
2339         * buildsym-legacy.h: Rename include guard.
2340         * bfin-tdep.h: Add include guard.
2341         * ax.h: Rename include guard.
2342         * arm-linux-tdep.h: Add include guard.
2343         * arm-fbsd-tdep.h: Add include guard.
2344         * arch/xtensa.h: Rename include guard.
2345         * arch/tic6x.h: Add include guard.
2346         * arch/i386.h: Add include guard.
2347         * arch/arm.h: Rename include guard.
2348         * arch/arm-linux.h: Rename include guard.
2349         * arch/arm-get-next-pcs.h: Rename include guard.
2350         * arch/amd64.h: Add include guard.
2351         * arch/aarch64-insn.h: Rename include guard.
2352         * arch-utils.h: Rename include guard.
2353         * annotate.h: Add include guard.
2354         * amd64-darwin-tdep.h: Rename include guard.
2355         * aarch64-linux-tdep.h: Add include guard.
2356         * aarch64-fbsd-tdep.h: Add include guard.
2357         * aarch32-linux-nat.h: Add include guard.
2358
2359 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * macrotab.c (macro_define_internal): New function that
2362         factorizes macro_define_object_internal and macro_define_function
2363         code.
2364         (macro_define_object_internal): Use macro_define_internal.
2365         (macro_define_function): Likewise.
2366
2367 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2368
2369         * macrocmd.c (extract_identifier): Return
2370         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2371         callers.
2372
2373 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2374
2375         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2376
2377 2019-02-05  Tom Tromey  <tom@tromey.com>
2378
2379         * target.c (target_stack::unpush): Move assertion earlier.
2380
2381 2019-01-30  Tom Tromey  <tom@tromey.com>
2382
2383         PR python/23615:
2384         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2385         (gdbpy_parse_and_eval): Likewise.
2386         * python/python-internal.h (gdbpy_allow_threads): New class.
2387
2388 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2389
2390         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2391         (aarch64_fbsd_fpregmap): Move earlier.
2392         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2393         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2394         instead of individual calls to trad_frame_set_reg_addr.
2395         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2396         earlier.
2397         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2398         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2399         instead of individual calls to trad_frame_set_reg_addr.
2400
2401 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2402
2403         * CONTRIBUTE: Replace contribution list with wiki link.
2404
2405 2019-01-25  Tom Tromey  <tom@tromey.com>
2406
2407         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2408
2409 2019-01-25  Tom Tromey  <tom@tromey.com>
2410
2411         * xtensa-linux-nat.c: Fix common/ includes.
2412         * xml-support.h: Fix common/ includes.
2413         * xml-support.c: Fix common/ includes.
2414         * x86-linux-nat.c: Fix common/ includes.
2415         * windows-nat.c: Fix common/ includes.
2416         * varobj.h: Fix common/ includes.
2417         * varobj.c: Fix common/ includes.
2418         * value.c: Fix common/ includes.
2419         * valops.c: Fix common/ includes.
2420         * utils.c: Fix common/ includes.
2421         * unittests/xml-utils-selftests.c: Fix common/ includes.
2422         * unittests/utils-selftests.c: Fix common/ includes.
2423         * unittests/unpack-selftests.c: Fix common/ includes.
2424         * unittests/tracepoint-selftests.c: Fix common/ includes.
2425         * unittests/style-selftests.c: Fix common/ includes.
2426         * unittests/string_view-selftests.c: Fix common/ includes.
2427         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2428         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2429         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2430         * unittests/rsp-low-selftests.c: Fix common/ includes.
2431         * unittests/parse-connection-spec-selftests.c: Fix common/
2432         includes.
2433         * unittests/optional-selftests.c: Fix common/ includes.
2434         * unittests/offset-type-selftests.c: Fix common/ includes.
2435         * unittests/observable-selftests.c: Fix common/ includes.
2436         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2437         * unittests/memrange-selftests.c: Fix common/ includes.
2438         * unittests/memory-map-selftests.c: Fix common/ includes.
2439         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2440         * unittests/function-view-selftests.c: Fix common/ includes.
2441         * unittests/environ-selftests.c: Fix common/ includes.
2442         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2443         * unittests/common-utils-selftests.c: Fix common/ includes.
2444         * unittests/cli-utils-selftests.c: Fix common/ includes.
2445         * unittests/array-view-selftests.c: Fix common/ includes.
2446         * ui-file.c: Fix common/ includes.
2447         * tui/tui-io.c: Fix common/ includes.
2448         * tracepoint.h: Fix common/ includes.
2449         * tracepoint.c: Fix common/ includes.
2450         * tracefile-tfile.c: Fix common/ includes.
2451         * top.h: Fix common/ includes.
2452         * top.c: Fix common/ includes.
2453         * thread.c: Fix common/ includes.
2454         * target/waitstatus.h: Fix common/ includes.
2455         * target/waitstatus.c: Fix common/ includes.
2456         * target.h: Fix common/ includes.
2457         * target.c: Fix common/ includes.
2458         * target-memory.c: Fix common/ includes.
2459         * target-descriptions.c: Fix common/ includes.
2460         * symtab.h: Fix common/ includes.
2461         * symfile.c: Fix common/ includes.
2462         * stap-probe.c: Fix common/ includes.
2463         * spu-linux-nat.c: Fix common/ includes.
2464         * sparc-nat.c: Fix common/ includes.
2465         * source.c: Fix common/ includes.
2466         * solib.c: Fix common/ includes.
2467         * solib-target.c: Fix common/ includes.
2468         * ser-unix.c: Fix common/ includes.
2469         * ser-tcp.c: Fix common/ includes.
2470         * ser-pipe.c: Fix common/ includes.
2471         * ser-base.c: Fix common/ includes.
2472         * selftest-arch.c: Fix common/ includes.
2473         * s12z-tdep.c: Fix common/ includes.
2474         * rust-exp.y: Fix common/ includes.
2475         * rs6000-aix-tdep.c: Fix common/ includes.
2476         * riscv-tdep.c: Fix common/ includes.
2477         * remote.c: Fix common/ includes.
2478         * remote-notif.h: Fix common/ includes.
2479         * remote-fileio.h: Fix common/ includes.
2480         * remote-fileio.c: Fix common/ includes.
2481         * regcache.h: Fix common/ includes.
2482         * regcache.c: Fix common/ includes.
2483         * record-btrace.c: Fix common/ includes.
2484         * python/python.c: Fix common/ includes.
2485         * python/py-type.c: Fix common/ includes.
2486         * python/py-inferior.c: Fix common/ includes.
2487         * progspace.h: Fix common/ includes.
2488         * producer.c: Fix common/ includes.
2489         * procfs.c: Fix common/ includes.
2490         * proc-api.c: Fix common/ includes.
2491         * printcmd.c: Fix common/ includes.
2492         * ppc-linux-nat.c: Fix common/ includes.
2493         * parser-defs.h: Fix common/ includes.
2494         * osdata.c: Fix common/ includes.
2495         * obsd-nat.c: Fix common/ includes.
2496         * nat/x86-linux.c: Fix common/ includes.
2497         * nat/x86-linux-dregs.c: Fix common/ includes.
2498         * nat/x86-dregs.h: Fix common/ includes.
2499         * nat/x86-dregs.c: Fix common/ includes.
2500         * nat/ppc-linux.c: Fix common/ includes.
2501         * nat/mips-linux-watch.h: Fix common/ includes.
2502         * nat/mips-linux-watch.c: Fix common/ includes.
2503         * nat/linux-waitpid.c: Fix common/ includes.
2504         * nat/linux-ptrace.h: Fix common/ includes.
2505         * nat/linux-ptrace.c: Fix common/ includes.
2506         * nat/linux-procfs.c: Fix common/ includes.
2507         * nat/linux-personality.c: Fix common/ includes.
2508         * nat/linux-osdata.c: Fix common/ includes.
2509         * nat/linux-namespaces.c: Fix common/ includes.
2510         * nat/linux-btrace.h: Fix common/ includes.
2511         * nat/linux-btrace.c: Fix common/ includes.
2512         * nat/fork-inferior.c: Fix common/ includes.
2513         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2514         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2515         * nat/aarch64-linux.c: Fix common/ includes.
2516         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2517         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2518         * namespace.h: Fix common/ includes.
2519         * mips-linux-tdep.c: Fix common/ includes.
2520         * minsyms.c: Fix common/ includes.
2521         * mi/mi-parse.h: Fix common/ includes.
2522         * mi/mi-main.c: Fix common/ includes.
2523         * mi/mi-cmd-env.c: Fix common/ includes.
2524         * memrange.h: Fix common/ includes.
2525         * memattr.c: Fix common/ includes.
2526         * maint.h: Fix common/ includes.
2527         * maint.c: Fix common/ includes.
2528         * main.c: Fix common/ includes.
2529         * machoread.c: Fix common/ includes.
2530         * location.c: Fix common/ includes.
2531         * linux-thread-db.c: Fix common/ includes.
2532         * linux-nat.c: Fix common/ includes.
2533         * linux-fork.c: Fix common/ includes.
2534         * inline-frame.c: Fix common/ includes.
2535         * infrun.c: Fix common/ includes.
2536         * inflow.c: Fix common/ includes.
2537         * inferior.h: Fix common/ includes.
2538         * inferior.c: Fix common/ includes.
2539         * infcmd.c: Fix common/ includes.
2540         * inf-ptrace.c: Fix common/ includes.
2541         * inf-child.c: Fix common/ includes.
2542         * ia64-linux-nat.c: Fix common/ includes.
2543         * i387-tdep.c: Fix common/ includes.
2544         * i386-tdep.c: Fix common/ includes.
2545         * i386-linux-tdep.c: Fix common/ includes.
2546         * i386-linux-nat.c: Fix common/ includes.
2547         * i386-go32-tdep.c: Fix common/ includes.
2548         * i386-fbsd-tdep.c: Fix common/ includes.
2549         * i386-fbsd-nat.c: Fix common/ includes.
2550         * guile/scm-type.c: Fix common/ includes.
2551         * guile/guile.c: Fix common/ includes.
2552         * go32-nat.c: Fix common/ includes.
2553         * gnu-nat.c: Fix common/ includes.
2554         * gdbthread.h: Fix common/ includes.
2555         * gdbarch-selftests.c: Fix common/ includes.
2556         * gdb_usleep.c: Fix common/ includes.
2557         * gdb_select.h: Fix common/ includes.
2558         * gdb_bfd.c: Fix common/ includes.
2559         * gcore.c: Fix common/ includes.
2560         * fork-child.c: Fix common/ includes.
2561         * findvar.c: Fix common/ includes.
2562         * fbsd-nat.c: Fix common/ includes.
2563         * event-top.c: Fix common/ includes.
2564         * event-loop.c: Fix common/ includes.
2565         * dwarf2read.c: Fix common/ includes.
2566         * dwarf2loc.c: Fix common/ includes.
2567         * dwarf2-frame.c: Fix common/ includes.
2568         * dwarf-index-cache.c: Fix common/ includes.
2569         * dtrace-probe.c: Fix common/ includes.
2570         * disasm-selftests.c: Fix common/ includes.
2571         * defs.h: Fix common/ includes.
2572         * csky-tdep.c: Fix common/ includes.
2573         * cp-valprint.c: Fix common/ includes.
2574         * cp-support.h: Fix common/ includes.
2575         * cp-support.c: Fix common/ includes.
2576         * corelow.c: Fix common/ includes.
2577         * completer.h: Fix common/ includes.
2578         * completer.c: Fix common/ includes.
2579         * compile/compile.c: Fix common/ includes.
2580         * compile/compile-loc2c.c: Fix common/ includes.
2581         * compile/compile-cplus-types.c: Fix common/ includes.
2582         * compile/compile-cplus-symbols.c: Fix common/ includes.
2583         * command.h: Fix common/ includes.
2584         * cli/cli-dump.c: Fix common/ includes.
2585         * cli/cli-cmds.c: Fix common/ includes.
2586         * charset.c: Fix common/ includes.
2587         * build-id.c: Fix common/ includes.
2588         * btrace.h: Fix common/ includes.
2589         * btrace.c: Fix common/ includes.
2590         * breakpoint.h: Fix common/ includes.
2591         * breakpoint.c: Fix common/ includes.
2592         * ax.h:
2593         (enum agent_op): Fix common/ includes.
2594         * ax-general.c (struct aop_map): Fix common/ includes.
2595         * ax-gdb.c: Fix common/ includes.
2596         * auxv.c: Fix common/ includes.
2597         * auto-load.c: Fix common/ includes.
2598         * arm-tdep.c: Fix common/ includes.
2599         * arch/riscv.c: Fix common/ includes.
2600         * arch/ppc-linux-common.c: Fix common/ includes.
2601         * arch/i386.c: Fix common/ includes.
2602         * arch/arm.c: Fix common/ includes.
2603         * arch/arm-linux.c: Fix common/ includes.
2604         * arch/arm-get-next-pcs.c: Fix common/ includes.
2605         * arch/amd64.c: Fix common/ includes.
2606         * arch/aarch64.c: Fix common/ includes.
2607         * arch/aarch64-insn.c: Fix common/ includes.
2608         * arch-utils.c: Fix common/ includes.
2609         * amd64-windows-tdep.c: Fix common/ includes.
2610         * amd64-tdep.c: Fix common/ includes.
2611         * amd64-sol2-tdep.c: Fix common/ includes.
2612         * amd64-obsd-tdep.c: Fix common/ includes.
2613         * amd64-nbsd-tdep.c: Fix common/ includes.
2614         * amd64-linux-tdep.c: Fix common/ includes.
2615         * amd64-linux-nat.c: Fix common/ includes.
2616         * amd64-fbsd-tdep.c: Fix common/ includes.
2617         * amd64-fbsd-nat.c: Fix common/ includes.
2618         * amd64-dicos-tdep.c: Fix common/ includes.
2619         * amd64-darwin-tdep.c: Fix common/ includes.
2620         * agent.c: Fix common/ includes.
2621         * ada-lang.h: Fix common/ includes.
2622         * ada-lang.c: Fix common/ includes.
2623         * aarch64-tdep.c: Fix common/ includes.
2624
2625 2019-01-25  Tom Tromey  <tom@tromey.com>
2626
2627         * common/create-version.sh: Use common/version.h.
2628
2629 2019-01-24  Pedro Alves  <palves@redhat.com>
2630
2631         * infrun.c (signal_stop, signal_print, signal_program)
2632         (signal_catch, signal_pass): Now arrays instead of pointers.
2633         (update_signals_program_target, do_target_resume)
2634         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2635         * linux-nat.c (linux_nat_target::pass_signals)
2636         (linux_nat_target::create_inferior, linux_nat_target::attach):
2637         Adjust.
2638         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2639         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2640         * procfs.c (procfs_target::pass_signals): Adjust.
2641         * record-full.c (record_full_target::resume): Adjust.
2642         * remote.c (remote_target::pass_signals)
2643         (remote_target::program_signals): Adjust.
2644         * target-debug.h (target_debug_print_signals): Now takes a
2645         gdb::array_view as parameter.  Adjust.
2646         * target.h (target_ops) <pass_signals, program_signals>: Replace
2647         pointer and length parameters with gdb::array_view.
2648         (target_pass_signals, target_program_signals): Likewise.
2649         * target-delegates.c: Regenerate.
2650
2651 2019-01-24  Pedro Alves  <palves@redhat.com>
2652
2653         * common/forward-scope-exit.h
2654         (forward_scope_exit::forward_scope_exit): Pass arguments to
2655         m_bind_function directly, instead of creating a std::bind and
2656         copying that.
2657
2658 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2659
2660         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2661         for static members.
2662         (pass_in_v_vfp_candidate): Likewise.
2663
2664 2019-01-23  Tom Tromey  <tom@tromey.com>
2665             Pedro Alves  <palves@redhat.com>
2666
2667         * regcache.c (class regcache_invalidator): Remove.
2668         (regcache::raw_write): Use make_scope_exit.
2669
2670 2019-01-23  Tom Tromey  <tom@tromey.com>
2671
2672         * ui-out.h (class ui_out_emit_type): Update comment.
2673
2674 2019-01-23  Tom Tromey  <tom@tromey.com>
2675
2676         * infrun.c (fetch_inferior_event): Update comment.
2677
2678 2019-01-23  Tom Tromey  <tom@tromey.com>
2679             Pedro Alves  <palves@redhat.com>
2680
2681         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2682         parameter.
2683         (fetch_inferior_event): Use SCOPE_EXIT.
2684
2685
2686 2019-01-23  Tom Tromey  <tom@tromey.com>
2687             Pedro Alves  <palves@redhat.com>
2688
2689         * infrun.c (disable_thread_events): Delete.
2690         (stop_all_threads): Use SCOPE_EXIT.
2691
2692 2019-01-23  Tom Tromey  <tom@tromey.com>
2693             Pedro Alves  <palves@redhat.com>
2694
2695         * symfile.c: Include forward-scope-exit.h.
2696         (clear_symtab_users_cleanup): Replace forward declaration with
2697         a FORWARD_SCOPE_EXIT.
2698         (syms_from_objfile_1): Use the forward_scope_exit and
2699         gdb::optional instead of cleanup_function.
2700         (reread_symbols): Use the forward_scope_exit instead of
2701         cleanup_function.
2702         (clear_symtab_users_cleanup): Remove function.
2703
2704 2019-01-23  Tom Tromey  <tom@tromey.com>
2705             Pedro Alves  <palves@redhat.com>
2706
2707         * linux-nat.c: Include scope-exit.h.
2708         (cleanup_target_stop): Remove.
2709         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2710         SCOPE_EXIT.
2711
2712 2019-01-23  Tom Tromey  <tom@tromey.com>
2713             Pedro Alves  <palves@redhat.com>
2714
2715         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2716         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2717
2718 2019-01-23  Tom Tromey  <tom@tromey.com>
2719             Andrew Burgess  <andrew.burgess@embecosm.com>
2720             Pedro Alves  <palves@redhat.com>
2721
2722         * infrun.c (fetch_inferior_event): Use scope_exit.
2723         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2724         * top.c (execute_command): Use scope_exit.
2725         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2726         * utils.c (do_bpstat_clear_actions_cleanup)
2727         (make_bpstat_clear_actions_cleanup): Remove.
2728
2729 2019-01-23  Tom Tromey  <tom@tromey.com>
2730             Pedro Alves  <palves@redhat.com>
2731
2732         * infrun.c: Include "common/scope-exit.h"
2733         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2734         (wait_for_inferior): Use SCOPE_EXIT.
2735         (fetch_inferior_event): Use scope_exit.
2736
2737 2019-01-23  Tom Tromey  <tom@tromey.com>
2738             Pedro Alves  <palves@redhat.com>
2739
2740         * breakpoint.c (create_breakpoint): Remove cleanup.
2741
2742 2019-01-23  Tom Tromey  <tom@tromey.com>
2743             Andrew Burgess  <andrew.burgess@embecosm.com>
2744             Pedro Alves  <palves@redhat.com>
2745
2746 2019-01-23  Pedro Alves  <palves@redhat.com>
2747
2748         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2749
2750 2019-01-23  Pedro Alves  <palves@redhat.com>
2751             Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * gdbthread.h: Include "common/forward-scope-exit.h".
2754         (scoped_finish_thread_state): Redefine custom class in terms of
2755         forward_scope_exit.
2756
2757 2019-01-23  Pedro Alves  <palves@redhat.com>
2758             Andrew Burgess  <andrew.burgess@embecosm.com>
2759
2760         * common/forward-scope-exit.h: New file.
2761
2762 2019-01-23  Pedro Alves  <palves@redhat.com>
2763             Andrew Burgess  <andrew.burgess@embecosm.com>
2764             Tom Tromey  <tom@tromey.com>
2765
2766         * common/scope-exit.h: New file.
2767
2768 2019-01-23  Pedro Alves  <palves@redhat.com>
2769
2770         * common/preprocessor.h (ESC): Rename to ...
2771         (ESC_PARENS): ... this.
2772         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2773         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2774
2775 2019-01-23  Tom Tromey  <tom@tromey.com>
2776
2777         * language.h (class scoped_switch_to_sym_language_if_auto):
2778         Initialize m_lang in both cases.
2779
2780 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2781
2782         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2783         with XCNEW.
2784
2785 2019-01-22  Tom Tromey  <tom@tromey.com>
2786
2787         * corelow.c: Do not include sys/file.h.
2788
2789 2019-01-22  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-wingeneral.h: Include gdb_curses.h.
2792
2793 2019-01-22  Tom Tromey  <tom@tromey.com>
2794
2795         * source-cache.h (class source_cache) <get_source_lines,
2796         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2797
2798 2019-01-22  Tom Tromey  <tom@tromey.com>
2799
2800         * remote-fileio.h (struct remote_target): Declare.
2801
2802 2019-01-22  Tom Tromey  <tom@tromey.com>
2803
2804         * python/py-arch.c: Do not include py-ref.h.
2805         * python/py-bpevent.c: Do not include py-ref.h.
2806         * python/py-cmd.c: Do not include py-ref.h.
2807         * python/py-continueevent.c: Do not include py-ref.h.
2808         * python/py-event.h: Do not include py-ref.h.
2809         * python/py-evtregistry.c: Do not include py-ref.h.
2810         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2811         * python/py-frame.c: Do not include py-ref.h.
2812         * python/py-framefilter.c: Do not include py-ref.h.
2813         * python/py-function.c: Do not include py-ref.h.
2814         * python/py-infevents.c: Do not include py-ref.h.
2815         * python/py-linetable.c: Do not include py-ref.h.
2816         * python/py-objfile.c: Do not include py-ref.h.
2817         * python/py-param.c: Do not include py-ref.h.
2818         * python/py-prettyprint.c: Do not include py-ref.h.
2819         * python/py-progspace.c: Do not include py-ref.h.
2820         * python/py-symbol.c: Do not include py-ref.h.
2821         * python/py-symtab.c: Do not include py-ref.h.
2822         * python/py-type.c: Do not include py-ref.h.
2823         * python/py-unwind.c: Do not include py-ref.h.
2824         * python/py-utils.c: Do not include py-ref.h.
2825         * python/py-value.c: Do not include py-ref.h.
2826         * python/py-varobj.c: Do not include py-ref.h.
2827         * python/py-xmethods.c: Do not include py-ref.h.
2828         * python/python.c: Do not include py-ref.h.
2829         * varobj.c: Do not include py-ref.h.
2830
2831 2019-01-22  Tom Tromey  <tom@tromey.com>
2832
2833         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2834         keyword for bcache.
2835
2836 2019-01-22  Tom Tromey  <tom@tromey.com>
2837
2838         * compile/compile-cplus-types.c: Remove a comment by #include.
2839
2840 2019-01-22  Tom Tromey  <tom@tromey.com>
2841
2842         * compile/gcc-c-plugin.h: Include compile-internal.h.
2843
2844 2019-01-22  Tom Tromey  <tom@tromey.com>
2845
2846         * stabsread.c (EXTERN): Do not define.
2847         (symnum, next_symbol_text_func, processing_gcc_compilation)
2848         (within_function, global_sym_chain, global_stabs)
2849         (previous_stab_code, this_object_header_files)
2850         (n_this_object_header_files)
2851         (n_allocated_this_object_header_files): Define.
2852         * stabsread.h (EXTERN): Never define.  Use "extern".
2853
2854 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2855
2856         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2857         history_value.
2858
2859 2019-01-21  Tom Tromey  <tom@tromey.com>
2860
2861         * ui-out.c: Fix includes.
2862         * tui/tui-source.c: Fix includes.
2863         * target.c: Fix includes.
2864         * remote.c: Fix includes.
2865         * regcache.c: Fix includes.
2866         * python/py-block.c: Fix includes.
2867         * printcmd.c: Fix includes.
2868         * or1k-tdep.c: Fix includes.
2869         * mi/mi-main.c: Fix includes.
2870         * m32r-tdep.c: Fix includes.
2871         * csky-tdep.c: Fix includes.
2872         * compile/compile-cplus-types.c: Fix includes.
2873         * cli/cli-interp.c: Fix includes.
2874
2875 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2876
2877         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2878         for padding.
2879
2880 2019-01-16  Tom Tromey  <tom@tromey.com>
2881
2882         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2883         earlier.
2884         (struct objfile) <msymbols_range>: Move from top level.
2885         <msymbols>: New method.
2886         (class objfile_msymbols): Remove.
2887         * symtab.c (default_collect_symbol_completion_matches_break_on):
2888         Update.
2889         * symmisc.c (dump_msymbols): Update.
2890         * stabsread.c (scan_file_globals): Update.
2891         * objc-lang.c (info_selectors_command, info_classes_command)
2892         (find_methods): Update.
2893         * minsyms.c (find_solib_trampoline_target): Update.
2894         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2895         * coffread.c (coff_symfile_read): Update.
2896         * ada-lang.c (ada_lookup_simple_minsym)
2897         (ada_collect_symbol_completion_matches): Update.
2898
2899 2019-01-16  Tom Tromey  <tom@tromey.com>
2900
2901         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2902         type.  Remove no-argument constructor.
2903         <iterator::operator++>: Simplify.
2904         <begin>: Update.
2905         <end>: Use minimal_symbol_count.
2906
2907 2019-01-16  Tom Tromey  <tom@tromey.com>
2908
2909         * objfiles.h (struct objfile) <psymtabs>: New method.
2910         (class objfile_psymtabs): Remove.
2911         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2912         typedef.
2913         <range>: New method.
2914         (require_partial_symbols): Change return type.
2915         * psymtab.c (require_partial_symbols)
2916         (psym_expand_symtabs_matching): Update.
2917         * mdebugread.c (parse_partial_symbols): Update.
2918         * dbxread.c (dbx_end_psymtab): Update.
2919
2920 2019-01-15  Tom Tromey  <tom@tromey.com>
2921
2922         * symtab.c (lookup_objfile_from_block)
2923         (lookup_symbol_in_objfile_symtabs)
2924         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2925         (find_line_symtab, info_sources_command)
2926         (default_collect_symbol_completion_matches_break_on)
2927         (make_source_files_completion_list): Update.
2928         * symmisc.c (print_objfile_statistics, dump_objfile)
2929         (maintenance_print_symbols, maintenance_info_symtabs)
2930         (maintenance_check_symtabs, maintenance_info_line_tables):
2931         Update.
2932         * source.c (select_source_symtab)
2933         (forget_cached_source_info_for_objfile): Update.
2934         * objfiles.h (class objfile_compunits): Remove.
2935         (struct objfile) <compunits_range>: New typedef.
2936         (compunits): New method.
2937         * objfiles.c (objfile_relocate1): Update.
2938         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2939         * maint.c (count_symtabs_and_blocks): Update.
2940         * linespec.c (iterate_over_all_matching_symtabs): Update.
2941         * cp-support.c (add_symbol_overload_list_qualified): Update.
2942         * coffread.c (coff_symtab_read): Update.
2943         * ada-lang.c (add_nonlocal_symbols)
2944         (ada_collect_symbol_completion_matches)
2945         (ada_add_global_exceptions): Update.
2946
2947 2019-01-15  Tom Tromey  <tom@tromey.com>
2948
2949         * progspace.h (program_space) <objfiles_safe_range>: New
2950         typedef.
2951         <objfiles_safe>: New method.
2952         * objfiles.h (class all_objfiles_safe): Remove.
2953         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2954         * jit.c (jit_inferior_exit_hook): Update.
2955
2956 2019-01-17  Tom Tromey  <tom@tromey.com>
2957
2958         * progspace.h (program_space) <objfiles_range>: New typedef.
2959         <objfiles>: New method.
2960         <objfiles_head>: Rename from objfiles.
2961         (object_files): Update.
2962         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2963         * guile/scm-pretty-print.c
2964         (ppscm_find_pretty_printer_from_objfiles): Update.
2965         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2966         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2967         Update.
2968         * python/py-progspace.c (pspy_get_objfiles): Update.
2969         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2970         Update.
2971         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2972         (objfpy_lookup_objfile_by_build_id): Update.
2973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2974         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2975         Update.
2976         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2977         (expand_symtab_containing_pc, lookup_objfile_from_block)
2978         (lookup_static_symbol, basic_lookup_transparent_type)
2979         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2980         (find_line_symtab, info_sources_command)
2981         (default_collect_symbol_completion_matches_break_on)
2982         (make_source_files_completion_list, find_main_name): Update.
2983         * symmisc.c (print_symbol_bcache_statistics)
2984         (print_objfile_statistics, maintenance_print_symbols)
2985         (maintenance_print_msymbols, maintenance_print_objfiles)
2986         (maintenance_info_symtabs, maintenance_check_symtabs)
2987         (maintenance_expand_symtabs, maintenance_info_line_tables):
2988         Update.
2989         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2990         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2991         (map_overlay_command, unmap_overlay_command)
2992         (simple_overlay_update, expand_symtabs_matching)
2993         (map_symbol_filenames): Update.
2994         * symfile-debug.c (set_debug_symfile): Update.
2995         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2996         Update.
2997         * source.c (select_source_symtab, forget_cached_source_info):
2998         Update.
2999         * solib.c (solib_read_symbols): Update.
3000         * solib-spu.c (append_ocl_sos): Update.
3001         * psymtab.c (maintenance_print_psymbols)
3002         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3003         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3004         * printcmd.c (info_symbol_command): Update.
3005         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3006         Update.
3007         * objfiles.h (class all_objfiles): Remove.
3008         * objfiles.c (have_partial_symbols, have_full_symbols)
3009         (have_minimal_symbols, qsort_cmp, update_section_map)
3010         (shared_objfile_contains_address_p)
3011         (default_iterate_over_objfiles_in_search_order): Update.
3012         * objc-lang.c (info_selectors_command, info_classes_command)
3013         (find_methods): Update.
3014         * minsyms.c (find_solib_trampoline_target): Update.
3015         * maint.c (maintenance_info_sections)
3016         (maintenance_translate_address, count_symtabs_and_blocks):
3017         Update.
3018         * main.c (captured_main_1): Update.
3019         * linux-thread-db.c (try_thread_db_load_from_pdir)
3020         (has_libpthread): Update.
3021         * linespec.c (iterate_over_all_matching_symtabs)
3022         (search_minsyms_for_name): Update.
3023         * jit.c (jit_find_objf_with_entry_addr): Update.
3024         * hppa-tdep.c (find_unwind_entry)
3025         (hppa_lookup_stub_minimal_symbol): Update.
3026         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3027         Update.
3028         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3029         (elf_gnu_ifunc_resolve_by_got): Update.
3030         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3031         * dwarf-index-write.c (save_gdb_index_command): Update.
3032         * cp-support.c (add_symbol_overload_list_qualified): Update.
3033         * breakpoint.c (create_overlay_event_breakpoint)
3034         (create_longjmp_master_breakpoint)
3035         (create_std_terminate_master_breakpoint)
3036         (create_exception_master_breakpoint): Update.
3037         * blockframe.c (find_pc_partial_function): Update.
3038         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3039         (ada_collect_symbol_completion_matches)
3040         (ada_add_global_exceptions): Update.
3041
3042 2019-01-17  Tom Tromey  <tom@tromey.com>
3043
3044         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3045         declare VEC.
3046         (solib_target_parse_libraries): Change return type.
3047         (library_list_start_segment, library_list_start_section)
3048         (library_list_end_library, library_list_start_library); Update.
3049         (solib_target_free_library_list): Remove.
3050         (solib_target_parse_libraries): Remove cleanup.  Change return
3051         type.
3052         (solib_target_current_sos): Update.
3053
3054 2019-01-17  Tom Tromey  <tromey@bapiya>
3055
3056         * valprint.c: Replace "the the" with "the".
3057         * symtab.c: Replace "the the" with "the".
3058         * solib.c: Replace "the the" with "the".
3059         * solib-dsbt.c: Replace "the the" with "the".
3060         * linespec.c: Replace "the the" with "the".
3061         * dwarf2loc.h: Replace "the the" with "the".
3062         * amd64-windows-tdep.c: Replace "the the" with "the".
3063         * aarch64-tdep.c: Replace "the the" with "the".
3064
3065 2019-01-16  Keith Seitz  <keiths@redhat.com>
3066
3067         PR gdb/23773
3068         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3069         <builder>: Rename to ..
3070         <m_builder>: ... this and make private.
3071         (dwarf2_cu::get_builder): New method.  Change all users of
3072         `builder' to use this method.
3073         (dwarf2_start_symtab): Move to ...
3074         (dwarf2_cu::start_symtab): ... here.  Update all callers
3075         (setup_type_unit_groups): Move to ...
3076         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3077         callers.
3078         (dwarf2_cu::reset_builder): New method.
3079         (process_full_compunit, process_full_type_unit): Use
3080         dwarf2_cu::reset_builder.
3081         (follow_die_offset): Record the ancestor CU if it is different
3082         from the followed DIE's CU.
3083         (follow_die_sig_1): Likewise.
3084
3085 2019-01-15  Tom Tromey  <tom@tromey.com>
3086
3087         * remote.c (class remote_state) <buf>: Now a char_vector.
3088         <buf_size>: Remove.
3089         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3090         parameter.
3091         (remote_target::getpkt_or_notif_sane_1)
3092         (remote_target::getpkt_sane)
3093         (remote_target::getpkt_or_notif_sane): Likewise.
3094         (class remote_target) <putpkt>: New overload.
3095         (remote_target::read_frame): Change type of "buf_p".  Remove
3096         sizeof_p parameter.
3097         (packet_ok): New overload.
3098         (packet_check_result): New overload.
3099         Update all uses.
3100
3101 2019-01-14  Tom Tromey  <tom@tromey.com>
3102
3103         * remote-notif.c (handle_notification, remote_notif_ack)
3104         (remote_notif_parse): Make "buf" const.
3105         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3106         const.
3107         (remote_notif_parse, remote_notif_ack, handle_notification):
3108         Likewise.
3109         * remote.c (remote_notif_stop_parse): Make "buf" const.
3110         (remote_target::remote_parse_stop_reply): Make "buf" const.
3111         (remote_notif_stop_ack): Make "buf" const.
3112
3113 2019-01-14  Tom Tromey  <tom@tromey.com>
3114
3115         * remote.c (remote_console_output): Make parameter const.
3116
3117 2019-01-14  Tom Tromey  <tom@tromey.com>
3118
3119         * target-debug.h (target_debug_print_signals): Constify.
3120         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3121         * procfs.c (procfs_target::pass_signals): Update.
3122         * linux-nat.c (linux_nat_target::pass_signals): Update.
3123         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3124         * target-delegates.c: Rebuild.
3125         * remote.c (remote_target::program_signals): Update.
3126         (remote_target::pass_signals): Update.
3127         * target.c (target_pass_signals): Constify argument.
3128         (target_program_signals): Likewise.
3129         * target.h (struct target_ops) <pass_signals, program_signals>:
3130         Constify argument.
3131         (target_pass_signals, target_program_signals): Constify argument.
3132
3133 2019-01-14  Tom Tromey  <tom@tromey.com>
3134
3135         PR tui/28819:
3136         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3137
3138 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3139
3140         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3141         field.
3142         * rs6000-tdep.c: Include reggroups.h.
3143         (IS_V_ALIAS_PSEUDOREG): Define.
3144         (rs6000_register_name): Return names for the "vX" aliases.
3145         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3146         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3147         aliases.  Call default_register_reggroup_p for all other
3148         pseudo-registers.
3149         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3150         New functions.
3151         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3152         Handle "vX" aliases.
3153         (v_alias_pseudo_register_collect): New function.
3154         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3155         (rs6000_gdbarch_init): Initialize "vX" aliases as
3156         pseudo-registers.  Restore registration of
3157         rs6000_pseudo_register_reggroup_p with
3158         set_tdesc_pseudo_register_reggroup_p.
3159
3160 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3161
3162         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3163         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3164         set_gdbarch_num_pseudo_regs.
3165
3166 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3167
3168         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3169         Remove arg prefixname, add do_set and do_show.
3170         Add member functions set_list and show_list.
3171         * cli/cli-style.c (class cli_style_option): Update accordingly.
3172         (style_set_list): Move to file scope.
3173         (style_show_list): Likewise.
3174         (set_style): Call help_list.
3175         (show_style): Call cmd_show_list.
3176         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3177         Update to use the new macro.
3178
3179 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3180
3181         * ada-lang.c (_initialize_ada_language): Expand the help text
3182         for the "catch exception" command.
3183
3184 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3185
3186         * symtab.c (matching_obj_sections): Initialize obj,
3187         declare it closer to its usage.
3188
3189 2019-01-10  Tom Tromey  <tom@tromey.com>
3190
3191         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3192         (basic_inf_threads_range): Remove.
3193         (inf_threads_range, inf_non_exited_threads_range)
3194         (safe_inf_threads_range): Use next_adapter.
3195
3196 2019-01-10  Keith Seitz  <keiths@redhat.com>
3197
3198         PR gdb/23712
3199         PR symtab/23010
3200         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3201         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3202
3203 2019-01-10  Keith Seitz  <keiths@redhat.com>
3204
3205         PR gdb/23712
3206         PR symtab/23010
3207         * dictionary.c (pending_to_vector): Remove.
3208         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3209         Remove _1 suffix, replacing functions of the same name.  Update
3210         all callers.
3211         (dict_create_hashed, dict_create_hashed_expandable)
3212         (dict_create_linear, dict_create_linear_expandable, dict_free)
3213         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3214         Make functions static.
3215
3216 2019-01-10  Keith Seitz  <keiths@redhat.com>
3217
3218         PR gdb/23712
3219         PR symtab/23010
3220         * dictionary.h (struct dictionary): Replace declaration with
3221         multidictionary.
3222         (dict_create_hashed, dict_create_hashed_expandable)
3223         (dict_create_linear, dict_create_linear_expandable)
3224         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3225         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3226         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3227         taking multidictionary argument.
3228         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3229         * block.h (struct block) <dict>: Change to multidictionary
3230         and rename `multidict'.
3231         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3232         symmisc.c: Update all dictionary references to multidictionary.
3233
3234 2019-01-10  Keith Seitz  <keiths@redhat.com>
3235
3236         PR gdb/23712
3237         PR symtab/23010
3238         * dictionary.c: Include unordered_map.
3239         (pending_to_vector): New function.
3240         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3241         Rewrite the non-"_1" functions to take vector instead
3242         of linked list.
3243         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3244         "new" _1 versions of the same name.
3245         (multidictionary): Define.
3246         (std::hash<enum language): New definition.
3247         (collate_pending_symbols_by_language, mdict_create_hashed)
3248         (mdict_create_hashed_expandable, mdict_create_linear)
3249         (mdict_create_linear_expandable, mdict_free)
3250         (find_language_dictionary, create_new_language_dictionary)
3251         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3252         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3253         (mdict_size, mdict_empty): New functions.
3254         * dictionary.h (mdict_iterator): Define.
3255
3256 2019-01-10  Pedro Alves  <palves@redhat.com>
3257
3258         * breakpoint.c (read_uploaded_action)
3259         (create_tracepoint_from_upload): Adjust to use
3260         gdb::unique_xmalloc_ptr.
3261         * ctf.c (ctf_write_uploaded_tp):
3262         (SET_ARRAY_FIELD): Use emplace_back.
3263         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3264         * tracefile-tfile.c (tfile_write_uploaded_tp):
3265         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3266         gdb::unique_xmalloc_ptr.
3267         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3268         at_string, cond_string, cmd_strings>: Replace char pointers
3269         with gdb::unique_xmalloc_ptr.
3270
3271 2019-01-10  Pedro Alves  <palves@redhat.com>
3272
3273         * solib-target.c (library_list_start_library): Don't xstrdup name.
3274
3275 2019-01-10  Pedro Alves  <palves@redhat.com>
3276
3277         * mdebugread.c (parse_partial_symbols): Use
3278         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3279
3280 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * linux-fork.c (scoped_switch_fork_info)
3283         <~scoped_switch_fork_info>: Fix incorrect variable name.
3284
3285 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3286
3287         * linux-fork.c (scoped_switch_fork_info)
3288         <scoped_switch_fork_info>: Make explicit.
3289         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3290
3291 2019-01-10  Tom Tromey  <tom@tromey.com>
3292
3293         * objfiles.h (objfile::reset_psymtabs): Update.
3294         * objfiles.c (objfile::objfile): Update.
3295         * psymtab.h (psymtab_storage::obstack): Update.
3296         (psymtab_storage::m_obstack): Use gdb::optional.
3297         (class psymtab_storage): Update comment.  Remove objfile
3298         parameter.
3299         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3300
3301 2019-01-10  Tom Tromey  <tom@tromey.com>
3302
3303         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3304         <free_psymtabs>: Now private.
3305         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3306         (allocate_psymtab): Use new method.
3307
3308 2019-01-10  Tom Tromey  <tom@tromey.com>
3309
3310         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3311         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3312         * mdebugread.c (parse_partial_symbols): Use
3313         allocate_dependencies.
3314         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3315         allocate_dependencies.
3316         (process_psymtab_comp_unit_reader)
3317         (build_type_psymtab_dependencies): Likewise.
3318         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3319
3320 2019-01-10  Tom Tromey  <tom@tromey.com>
3321
3322         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3323         PSYMBOL_SET_LANGUAGE.
3324         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3325
3326 2019-01-10  Tom Tromey  <tom@tromey.com>
3327
3328         * psymtab.h (psymtab_storage::obstack): New method.
3329         <m_obstack>: Rename from obstack; now private.
3330         * psymtab.c (psymtab_storage): Update.
3331         * dwarf2read.c (create_addrmap_from_index)
3332         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3333         Update.
3334
3335 2019-01-10  Tom Tromey  <tom@tromey.com>
3336
3337         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3338         * objfiles.h (objfile::reset_psymtabs): New method.
3339
3340 2019-01-10  Tom Tromey  <tom@tromey.com>
3341
3342         * symmisc.c (print_symbol_bcache_statistics): Update.
3343         (print_objfile_statistics): Update.
3344         * symfile.c (reread_symbols): Update.
3345         * psymtab.h (class psymtab_storage): New.
3346         * psymtab.c (psymtab_storage): New constructor.
3347         (~psymtab_storage): New destructor.
3348         (require_partial_symbols): Update.
3349         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3350         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3351         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3352         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3353         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3354         (start_psymtab_common, end_psymtab_common)
3355         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3356         (allocate_psymtab): Update.
3357         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3358         Update.
3359         (dump_psymtab_addrmap, maintenance_print_psymbols)
3360         (maintenance_check_psymtabs): Update.
3361         (class objfile_psymtabs): Move to objfiles.h.
3362         * psympriv.h (discard_psymtab): Now inline.
3363         (psymtab_discarder::psymtab_discarder): Update.
3364         (psymtab_discarder::~psymtab_discarder): Update.
3365         (ALL_OBJFILE_PSYMTABS): Rewrite.
3366         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3367         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3368         Remove fields.
3369         <partial_symtabs>: New field.
3370         (class objfile_psymtabs): Move from psymtab.h.  Update.
3371         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3372         psymbol_cache.
3373         (objfile::~objfile): Don't destroy psymbol_cache.
3374         * mdebugread.c (parse_partial_symbols): Update.
3375         * dwarf2read.c (create_addrmap_from_index)
3376         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3377         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3378         (add_partial_subprogram, dwarf2_ranges_read): Update.
3379         * dwarf-index-write.c (write_address_map)
3380         (write_one_signatured_type, recursively_write_psymbols)
3381         (class debug_names, class debug_names, write_psymtabs_to_index):
3382         Update.
3383
3384 2019-01-10  Tom Tromey  <tom@tromey.com>
3385
3386         * symtab.h (SYMBOL_SET_NAMES): Update.
3387         (symbol_set_names): Update.
3388         (MSYMBOL_SET_NAMES): Update.
3389         * symtab.c (symbol_set_names): Change argument to be an
3390         objfile_per_bfd_storage.
3391         * psymtab.c (add_psymbol_to_bcache): Update.
3392         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3393
3394 2019-01-10  Tom Tromey  <tom@tromey.com>
3395
3396         * symtab.c (create_demangled_names_hash): Change argument to be an
3397         objfile_per_bfd_storage.
3398         (symbol_set_names): Update.
3399
3400 2019-01-10  Tom Tromey  <tom@tromey.com>
3401
3402         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3403         init_psymbol_list.
3404         * psymtab.c (init_psymbol_list): Do nothing if already called.
3405         * psympriv.h (init_psymbol_list): Add comment.
3406         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3407         init_psymbol_list.
3408         * dbxread.c (dbx_symfile_read): Unconditionally call
3409         init_psymbol_list.
3410
3411 2019-01-10  Tom Tromey  <tom@tromey.com>
3412
3413         * xcoffread.c (scan_xcoff_symtab): Update.
3414         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3415         "where".
3416         * mdebugread.c (parse_partial_symbols)
3417         (handle_psymbol_enumerators): Update.
3418         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3419         * dbxread.c (read_dbx_symtab): Update.
3420         * psympriv.h (psymbol_placement): New enum.
3421         (add_psymbol_to_list): Update.
3422
3423 2019-01-10  Tom Tromey  <tom@tromey.com>
3424
3425         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3426         static_psymbols parameters.
3427         (scan_xcoff_symtab): Update.
3428         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3429         static_psymbols parameters.
3430         * psympriv.h (start_psymtab_common): Update.
3431         * mdebugread.c (parse_partial_symbols): Update.
3432         * dwarf2read.c (create_partial_symtab): Update.
3433         * dbxread.c (read_dbx_symtab): Update.
3434         (start_psymtab): Remove global_psymbols and static_psymbols
3435         parameters.
3436
3437 2019-01-10  Tom Tromey  <tom@tromey.com>
3438
3439         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3440         * psymtab.c (allocate_psymtab): Add comment.
3441         * psympriv.h (allocate_psymtab): Add comment.
3442         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3443         initializations.
3444         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3445
3446 2019-01-10  Tom Tromey  <tom@tromey.com>
3447
3448         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3449         Don't declare.
3450         * mipsread.c: Include mdebugread.h.
3451         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3452         Declare.
3453         * elfread.c: Include mdebugread.h.
3454
3455 2019-01-09  Tom Tromey  <tom@tromey.com>
3456
3457         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3458         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3459         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3460         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3461         (psym_lookup_symbol, psym_find_last_source_symtab)
3462         (psym_forget_cached_source_info, psym_print_stats)
3463         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3464         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3465         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3466         (psym_find_compunit_symtab_by_address)
3467         (maintenance_print_psymbols, maintenance_info_psymtabs)
3468         (maintenance_check_psymtabs): Use ranged for.
3469         * psymtab.h (class objfile_psymtabs): New.
3470         (require_partial_symbols): Return objfile_psymtabs.
3471         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3472
3473 2019-01-09  Tom Tromey  <tom@tromey.com>
3474
3475         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3476         (find_pc_mapped_section, list_overlays_command)
3477         (map_overlay_command, unmap_overlay_command)
3478         (simple_overlay_update): Use all_objfiles.
3479         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3480         * printcmd.c (info_symbol_command): Use all_objfiles.
3481         * objfiles.h (ALL_OBJSECTIONS): Remove.
3482         * maint.c (maintenance_translate_address): Use all_objfiles.
3483         * gcore.c (gcore_create_callback): Use all_objfiles.
3484         (objfile_find_memory_regions): Likewise.
3485
3486 2019-01-09  Tom Tromey  <tom@tromey.com>
3487
3488         * symtab.c (find_line_symtab, info_sources_command)
3489         (make_source_files_completion_list): Use objfile_compunits.
3490         * source.c (select_source_symtab): Use objfile_compunits.
3491         * objfiles.h (struct objfile): Update comment.
3492         (ALL_OBJFILES): Remove.
3493         (ALL_FILETABS): Remove.
3494         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3495         objfile_compunits.
3496
3497 2019-01-09  Tom Tromey  <tom@tromey.com>
3498
3499         * symmisc.c (print_objfile_statistics, dump_objfile)
3500         (maintenance_print_symbols): Use compunit_filetabs.
3501         * source.c (forget_cached_source_info_for_objfile): Use
3502         compunit_filetabs.
3503         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3504         (ALL_FILETABS): Use compunit_filetabs.
3505         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3506         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3507
3508 2019-01-09  Tom Tromey  <tom@tromey.com>
3509
3510         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3511         (compunit_filetabs): New.
3512         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3513         compunit_filetabs.
3514         (info_sources_command, make_source_files_completion_list): Remove
3515         declaration.
3516         * symmisc.c (print_objfile_statistics, dump_objfile)
3517         (maintenance_print_symbols): Remove declaration.
3518         (maintenance_info_symtabs): Use compunit_filetabs.
3519         (maintenance_info_line_tables): Likewise.
3520         * source.c (select_source_symtab): Change local variable name.
3521         (forget_cached_source_info_for_objfile): Remove declaration.
3522         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3523         * objfiles.c (objfile_relocate1): Remove declaration.
3524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3525         declaration.
3526         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3527         * coffread.c (coff_symtab_read): Remove declaration.
3528         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3529         compunit_filetabs.
3530
3531 2019-01-09  Tom Tromey  <tom@tromey.com>
3532
3533         * symtab.c (lookup_objfile_from_block)
3534         (find_pc_sect_compunit_symtab, search_symbols)
3535         (default_collect_symbol_completion_matches_break_on): Use
3536         objfile_compunits.
3537         * objfiles.h (ALL_COMPUNITS): Remove.
3538         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3539         * cp-support.c (add_symbol_overload_list_qualified): Use
3540         objfile_compunits.
3541         * ada-lang.c (ada_collect_symbol_completion_matches)
3542         (ada_add_global_exceptions): Use objfile_compunits.
3543
3544 2019-01-09  Tom Tromey  <tom@tromey.com>
3545
3546         * source.c (select_source_symtab)
3547         (forget_cached_source_info_for_objfile): Remove declaration.
3548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3549         declaration.
3550         * maint.c (count_symtabs_and_blocks): Remove declaration.
3551         * cp-support.c (add_symbol_overload_list_qualified): Remove
3552         declaration.
3553         * coffread.c (coff_symtab_read): Remove declaration.
3554         * symtab.c (lookup_symbol_in_objfile_symtabs)
3555         (basic_lookup_transparent_type_1): Use objfile_compunits.
3556         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3557         (info_sources_command, search_symbols)
3558         (default_collect_symbol_completion_matches_break_on)
3559         (make_source_files_completion_list): Remove declaration.
3560         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3561         (ada_collect_symbol_completion_matches)
3562         (ada_add_global_exceptions): Remove declaration.
3563         * linespec.c (iterate_over_all_matching_symtabs): Use
3564         objfile_compunits.
3565         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3566         (class objfile_compunits): New.
3567         (ALL_COMPUNITS): Use objfile_compunits.
3568         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3569         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3570         objfile_compunits.
3571         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3572
3573 2019-01-09  Tom Tromey  <tom@tromey.com>
3574
3575         * symtab.c (search_symbols)
3576         (default_collect_symbol_completion_matches_break_on): Use
3577         objfile_msymbols.
3578         * ada-lang.c (ada_lookup_simple_minsym)
3579         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3580         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3581         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3582         objfile_msymbols.
3583         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3584         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3585         * objc-lang.c (find_methods): Use objfile_msymbols.
3586         (info_selectors_command, info_classes_command): Likewise.
3587         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3588         * objfiles.h (class objfile_msymbols): New.
3589         (ALL_OBJFILE_MSYMBOLS): Remove.
3590         (ALL_MSYMBOLS): Remove.
3591
3592 2019-01-09  Tom Tromey  <tom@tromey.com>
3593
3594         * common/next-iterator.h (next_adapter): Add Iterator template
3595         parameter.
3596         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3597         (class all_objfiles_safe): New.
3598         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3599         * objfiles.c (put_objfile_before): Update comment.
3600         (add_separate_debug_objfile): Likewise.
3601         (free_all_objfiles): Use all_objfiles_safe.
3602         (objfile_purge_solibs): Likewise.
3603
3604 2019-01-09  Tom Tromey  <tom@tromey.com>
3605
3606         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3607         (expand_symtab_containing_pc, lookup_static_symbol)
3608         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3609         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3610         all_objfiles.
3611         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3612         * breakpoint.c (create_overlay_event_breakpoint)
3613         (create_longjmp_master_breakpoint)
3614         (create_std_terminate_master_breakpoint)
3615         (create_exception_master_breakpoint): Use all_objfiles.
3616         * linux-thread-db.c (try_thread_db_load_from_pdir)
3617         (has_libpthread): Use all_objfiles.
3618         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3619         * linespec.c (iterate_over_all_matching_symtabs)
3620         (search_minsyms_for_name): Use all_objfiles.
3621         * maint.c (maintenance_info_sections): Use all_objfiles.
3622         * main.c (captured_main_1): Use all_objfiles.
3623         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3624         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3625         * guile/scm-pretty-print.c
3626         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3627         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3628         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3629         (maintenance_print_msymbols): Use all_objfiles.
3630         * source.c (select_source_symtab): Use all_objfiles.
3631         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3632         * symfile.c (remove_symbol_file_command)
3633         (expand_symtabs_matching, map_symbol_filenames): Use
3634         all_objfiles.
3635         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3636         all_objfiles.
3637         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3638         * objc-lang.c (find_methods): Use all_objfiles.
3639         * objfiles.c (have_partial_symbols, have_full_symbols)
3640         (have_minimal_symbols, qsort_cmp)
3641         (default_iterate_over_objfiles_in_search_order): Use
3642         all_objfiles.
3643         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3644         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3645         (maintenance_check_psymtabs): Use all_objfiles.
3646         (ALL_PSYMTABS): Remove.
3647         * compile/compile-object-run.c (do_module_cleanup): Use
3648         all_objfiles.
3649         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3650         * cp-support.c (add_symbol_overload_list_qualified): Use
3651         all_objfiles.
3652         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3653         Use all_objfiles.
3654         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3655         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3656         all_objfiles.
3657         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3658         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3659         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3660         Uses all_objfiles.
3661         * solib.c (solib_read_symbols): Use all_objfiles
3662
3663 2019-01-09  Tom Tromey  <tom@tromey.com>
3664
3665         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3666         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3667         all_objfiles.
3668         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3669         * symmisc.c (print_symbol_bcache_statistics)
3670         (print_objfile_statistics, maintenance_print_objfiles)
3671         (maintenance_info_symtabs, maintenance_check_symtabs)
3672         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3673         all_objfiles.
3674         * source.c (forget_cached_source_info): Use all_objfiles.
3675         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3676         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3677         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3678         * objfiles.c (update_section_map): Use all_objfiles.
3679         (shared_objfile_contains_address_p): Likewise.
3680         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3681         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3682
3683 2019-01-09  Tom Tromey  <tom@tromey.com>
3684
3685         * common/next-iterator.h: New file.
3686         * objfiles.h (class all_objfiles): New.
3687         (struct objfile_iterator): New.
3688
3689 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3690
3691         * NEWS: Move the description of the changed "frame", "select-frame",
3692          and "info frame" commands to the Changed commands section.
3693
3694 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3695
3696         * gdbtypes.c (check_stub_method_group): Remove handling of old
3697         mangling schemes.
3698         * linespec.c (find_methods): Likewise.
3699         * stabsread.c (read_member_functions): Likewise.
3700         * valops.c (search_struct_method): Likewise.
3701         (value_struct_elt_for_reference): Likewise.
3702         * NEWS: Mention this change.
3703
3704 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3707         print_source_lines.
3708         * source.c (print_source_lines_base): Update line number check.
3709         (print_source_lines): New function.
3710         (source_lines_range::source_lines_range): New function.
3711         * source.h (class source_lines_range): New class.
3712         (print_source_lines): New declaration.
3713
3714 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3715
3716         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3717
3718 2019-01-08  Tom Tromey  <tom@tromey.com>
3719             Simon Marchi  <simon.marchi@ericsson.com>
3720
3721         PR gdb/24060
3722         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3723         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3724         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3725         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3726         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3727         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3728
3729 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * source.c (select_source_symtab): Move header comment to
3732         declaration in source.h.
3733         (forget_cached_source_info_for_objfile): Likewise.
3734         (forget_cached_source_info): Likewise.
3735         (identify_source_line): Likewise.
3736         * source.h (identify_source_line): Move declaration from symtab.h
3737         and add comment from source.c
3738         (print_source_lines): Likewise.
3739         (forget_cached_source_info_for_objfile): Likewise.
3740         (forget_cached_source_info): Likewise.
3741         (select_source_symtab): Likewise.
3742         (enum print_source_lines_flag): Move definition from symtab.h.
3743         * symtab.h (identify_source_line): Move declaration to source.h.
3744         (print_source_lines): Likewise.
3745         (forget_cached_source_info_for_objfile): Likewise.
3746         (forget_cached_source_info): Likewise.
3747         (select_source_symtab): Likewise.
3748         (enum print_source_lines_flag): Move definition to source.h.
3749         * tui/tui-hooks.c: Add 'source.h' include.
3750
3751 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * source.c (print_source_lines_base): Handle requests to print
3754         reverse line number sequences, and guard against empty lines
3755         string.
3756
3757 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * source.c (print_source_lines_base): Fix skip of '\r' if next
3760         character is '\n'.
3761
3762 2019-01-06  Tom Tromey  <tom@tromey.com>
3763
3764         * c-exp.y (struct c_parse_state) <macro_original_text,
3765         expansion_obstack>: New member.
3766         (macro_original_text, expansion_obstack): Remove globals.
3767         (scan_macro_expansion, scanning_macro_expansion)
3768         (finished_macro_expansion): Update.
3769         (scan_macro_cleanup): Remove.
3770         (yylex, c_parse): Update.
3771
3772 2019-01-06  Tom Tromey  <tom@tromey.com>
3773
3774         * c-exp.y (struct c_parse_state) <strings>: New member.
3775         (operator_stoken): Update.
3776
3777 2019-01-06  Tom Tromey  <tom@tromey.com>
3778
3779         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3780         (union type_stack_elt) <typelist_val>: Now a pointer to
3781         std::vector.
3782         (type_stack_cleanup): Don't declare.
3783         (push_typelist): Update.
3784         * parse.c (pop_typelist): Return a std::vector.
3785         (push_typelist): Take a std::vector.
3786         (follow_types): Update.  Do not free args.
3787         (type_stack_cleanup): Remove.
3788         * c-exp.y (struct c_parse_state): New.
3789         (cpstate): New global.
3790         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3791         (nonempty_typelist): Update.
3792         (func_mod): Create a new vector.
3793         (c_parse): Create a c_parse_state.
3794         (check_parameter_typelist): Do not delete params.
3795         (function_method): Update.  Do not delete type_list.
3796
3797 2019-01-06  Tom Tromey  <tom@tromey.com>
3798
3799         PR gdb/28155:
3800         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3801         check_typedef.
3802         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3803         (print_return_value): Likewise.
3804
3805 2019-01-05  Tom Tromey  <tom@tromey.com>
3806
3807         * contrib/cleanup_check.py: Remove.
3808         * contrib/gcc-with-excheck: Remove.
3809         * contrib/exsummary.py: Remove.
3810         * contrib/excheck.py: Remove.
3811
3812 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3813
3814         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3815         NULL. Initialize tpprev to NULL instead of assigning it
3816         to NULL on the next statement.
3817         * windows-nat.c (windows_delete_thread): Remove check for
3818         main_thread_id before printing thread exit notifications.
3819         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3820         Remove thread ID check against main_thread_id.
3821         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3822         windows_delete_thread.
3823         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3824
3825 2019-01-04  Tom Tromey  <tom@tromey.com>
3826
3827         * compile/compile.c (_initialize_compile): Use upper case for
3828         metasyntactic variables.
3829         * symmisc.c (_initialize_symmisc): Use upper case for
3830         metasyntactic variables.
3831         * psymtab.c (_initialize_psymtab): Use upper case for
3832         metasyntactic variables.
3833         * demangle.c (demangle_command): Use upper case for metasyntactic
3834         variables.
3835         (_initialize_demangler): Likewise.
3836         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3837         variables.
3838
3839 2019-01-03  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3842
3843 2019-01-03  Tom Tromey  <tom@tromey.com>
3844
3845         * python/py-symtab.c (salpy_str): Update.
3846         (struct salpy_sal_object) <symtab>: Now a PyObject.
3847         (salpy_dealloc): Update.
3848         (del_objfile_sal): Use gdbpy_ref.
3849
3850 2019-01-03  Tom Tromey  <tom@tromey.com>
3851
3852         * python/py-type.c (convert_field): Use new_reference.  Return
3853         gdbpy_ref.
3854         (make_fielditem): Return gdbpy_ref.
3855         (typy_fields): Update.
3856         (typy_getitem): Update.
3857         (field_name): Return gdbpy_ref.  Use new_reference.
3858         (typy_iterator_iternext): Update.
3859
3860 2019-01-03  Tom Tromey  <tom@tromey.com>
3861
3862         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3863
3864 2019-01-03  Tom Tromey  <tom@tromey.com>
3865
3866         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3867         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3868         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3869         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3870         (pspy_set_type_printers): Likewise.
3871         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3872         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3873         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3874         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3875         (objfpy_set_type_printers): Likewise.
3876
3877 2019-01-03  Tom Tromey  <tom@tromey.com>
3878
3879         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3880         (gdbpy_print_stack): Use gdbpy_err_fetch.
3881         * python/python-internal.h (class gdbpy_err_fetch): New class.
3882         (class gdbpy_enter) <m_error_type, m_error_value,
3883         m_error_traceback>: Remove.
3884         <m_error>: New member.
3885         (gdbpy_exception_to_string): Don't declare.
3886         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3887         * python/py-value.c (convert_value_from_python): Use
3888         gdbpy_err_fetch.
3889         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3890         gdbpy_exception_to_string.
3891         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3892         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3893         gdbpy_err_fetch.
3894
3895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * linux-nat.c (delete_lwp_cleanup): Delete.
3898         (struct lwp_deleter): New struct.
3899         (lwp_info_up): New typedef.
3900         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3901         lwp_info_up.
3902
3903 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * linux-fork.c (class scoped_switch_fork_info): New class.
3906         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3907
3908 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3909
3910         * valops.c (find_overload_match): Remove use of null_cleanup, and
3911         calls to do_cleanups.
3912
3913 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * compile/compile-cplus-types.c
3916         (compile_cplus_instance::decl_name): Handle changes to
3917         cp_func_name.
3918         * cp-support.c (cp_func_name): Update header comment, update
3919         return type.
3920         * cp-support.h (cp_func_name): Update return type in declaration.
3921         * valops.c (find_overload_match): Move temp_func local to top
3922         level of function and change its type.  Use temp_func to hold and
3923         delete temporary string obtained from cp_func_name.
3924
3925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3928         gdb::char_vector, remove cleanup, and update uses of `msg`.
3929
3930 2019-01-03  Jim Wilson  <jimw@sifive.com>
3931
3932         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3933
3934 2019-01-02  Tom Tromey  <tom@tromey.com>
3935
3936         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3937         (tdesc_parse_xml): Remove cleanups.
3938         * target-descriptions.h (make_cleanup_free_target_description):
3939         Don't declare.
3940         (target_desc_deleter): New struct.
3941         (target_desc_up): New typedef.
3942         * target-descriptions.c (target_desc_deleter::operator()): Rename
3943         from free_target_description.
3944         (make_cleanup_free_target_description): Remove.
3945
3946 2019-01-02  Tom Tromey  <tom@tromey.com>
3947
3948         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3949         constructor, destructor.
3950         (linespec_parser): Remove typedef.
3951         (~linespec_parser): Rename from linespec_parser_delete.
3952         (linespec_lex_to_end, linespec_complete_label)
3953         (linespec_complete): Update.
3954         (decode_line_full): Remove cleanups.
3955         (decode_line_1): Update.
3956
3957 2019-01-02  Tom Tromey  <tom@tromey.com>
3958
3959         * python/python-internal.h (inferior_to_inferior_object): Change
3960         return type.
3961         * python/py-exitedevent.c (create_exited_event_object): Update.
3962         * python/py-inferior.c (inferior_to_inferior_object): Return
3963         gdbpy_ref.
3964         (python_new_inferior, python_inferior_deleted)
3965         (thread_to_thread_object, delete_thread_object)
3966         (build_inferior_list, gdbpy_selected_inferior): Update.
3967         * python/py-infthread.c (create_thread_object): Update.  Also fail
3968         if inferior_to_inferior_object fails.
3969
3970 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3971
3972         * inferior.h (class inferior) <displaced_step_state>: New field.
3973         * infrun.h (struct displaced_step_state): Move here from
3974         infrun.c.  Initialize fields, add constructor.
3975         <inf>: Remove field.
3976         <reset>: New method.
3977         * infrun.c (struct displaced_step_inferior_state): Move to
3978         infrun.h.
3979         (displaced_step_inferior_states): Remove.
3980         (get_displaced_stepping_state): Adust.
3981         (displaced_step_in_progress_any_inferior): Adjust.
3982         (displaced_step_in_progress_thread): Adjust.
3983         (displaced_step_in_progress): Adjust.
3984         (add_displaced_stepping_state): Remove.
3985         (get_displaced_step_closure_by_addr): Adjust.
3986         (remove_displaced_stepping_state): Remove.
3987         (infrun_inferior_exit): Call displaced_step_state.reset.
3988         (use_displaced_stepping): Don't check for NULL.
3989         (displaced_step_prepare_throw): Call
3990         get_displaced_stepping_state.
3991         (displaced_step_fixup): Don't check for NULL.
3992         (prepare_for_detach): Don't check for NULL.
3993
3994 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3995
3996         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3997          in case of call that did not complete.
3998
3999 2019-01-02  Andrey Utkin  <autkin@undo.io>
4000
4001         * symfile.c (find_separate_debug_file): Fix search of debug files for
4002         remote debuggee.
4003
4004 2019-01-02  Tom Tromey  <tom@tromey.com>
4005
4006         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4007         indentation.
4008         * python/py-frame.c (frapy_older): Remove cast.
4009         (frapy_newer): Likewise.
4010         * python/py-breakpoint.c (local_setattro): Remove cast.
4011         * python/py-arch.c (archpy_name): Remove local variable.
4012         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4013
4014 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4015
4016         * unittests/basic_string_view/element_access/char/empty.cc:
4017         Fix year range in copyright header.
4018
4019 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4022         Delete.
4023         <operator==>: Update with for removed field.
4024         <hash>: Likewise.
4025         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4026         <isa_features>: ...this.
4027         <abi_features>: New field.
4028         (riscv_isa_flen): Update comment.
4029         (riscv_abi_xlen): New declaration.
4030         (riscv_abi_flen): New declaration.
4031         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4032         isa_features.
4033         (riscv_abi_xlen): New function.
4034         (riscv_isa_flen): Update to get answer from isa_features.
4035         (riscv_abi_flen): New function.
4036         (riscv_has_fp_abi): Update to get answer from abi_features.
4037         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4038         xlen and flen.
4039         (riscv_call_info) <xlen, flen>: Update comment.
4040         (riscv_call_arg_struct): Remove invalid assertions
4041         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4042         is removed.
4043         (riscv_gdbarch_init): Gather isa features and abi features
4044         separately, ensure both match on the gdbarch when reusing an old
4045         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4046         a target with 64-bit float hardware.
4047
4048 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4049
4050         * source.c (search_command_helper): Stop reverse search
4051         when line 1 has been searched.
4052
4053 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4054
4055         * record-full.c (record_full_base_target::close): Rewrite
4056         record_full_core_buf_list free logic.
4057
4058 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4059
4060         * break-catch-syscall.c (print_one_catch_syscall): xfree
4061         the last text.
4062
4063 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4064
4065         * top.c (print_gdb_version): Update Copyright year in version
4066         message.
4067
4068 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4069
4070         Update copyright year range in all GDB files.
4071
4072 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4073
4074         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4075
4076 For older changes see ChangeLog-2018.
4077 \f
4078 Local Variables:
4079 mode: change-log
4080 left-margin: 8
4081 fill-column: 74
4082 version-control: never
4083 coding: utf-8
4084 End:
4085