gdb/ChangeLog

   1 2019-10-21  Ali Tamur  <tamu@google.com>
   2
   3         * dwarf2read.c (dir_index): Change type.
   4         (file_name_index): Likewise.
   5         (line_header::include_dir_at): Change comment and implementation on
   6         whether it is DWARF 5.
   7         (line_header::is_valid_file_index): New function.
   8         (line_header::file_name_at): Change comment and implementation on
   9         whether it is DWARF 5.
  10         (line_header::file_names): Change to private field renamed as
  11         m_file_names and introduce a new accessor method.
  12         (line_header::file_names_size): New method.
  13         (line_header::include_dirs): Change to private field and rename as
  14         m_include_dirs.
  15         (dw2_get_file_names_reader): Define local var at a smaller scope and
  16         reflect API change.
  17         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
  18         (process_structure_scope): Likewise.
  19         (line_header::add_include_dir): Change message and reflect renaming.
  20         (line_header::add_file_name): Likewise.
  21         (read_formatted_entries): Handle DW_FORM_data16.
  22         (dwarf_decode_line_header): Fix line header length calculation.
  23         (psymtab_include_file_name): Change comment and API.
  24         (lnp_state_machine::m_file): Update comment and reflect type change.
  25         (lnp_state_machine::record_line): Reflect type change.
  26         (dwarf_decode_lines): Reflect API change.
  27         (file_file_name): Likewise.
  28         (file_full_name): Likewise.
  29
  30 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  31
  32         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
  33
  34 2019-10-21  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
  37
  38 2019-10-21  Tom Tromey  <tom@tromey.com>
  39
  40         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
  41         NM_H.   Use AC_CONFIG_LINKS.
  42         * configure: Rebuild.
  43         * Makefile.in (NM_H): New variable.
  44         (generated_files): Add NM_H.  Remove gcore.
  45         (nm.h, stamp-nmh): New targets.
  46
  47 2019-10-20  Tom Tromey  <tom@tromey.com>
  48
  49         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
  50         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
  51         obsolete comment.
  52         (put_objfile_before): Now static.
  53
  54 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
  55
  56         * gdbsupport/common-utils.h (startswith): Change return type to
  57         bool.
  58
  59 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
  60
  61         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
  62         * breakpoint.c (bp_locations_compare): Rename to...
  63         (bp_location_is_less_than): ...this, and change to std::sort semantics.
  64         (update_global_location_list): Use std::sort instead of qsort.
  65         * buildsym.c (compare_line_numbers): Rename to...
  66         (lte_is_less_than): ...this, and change to std::sort semantics.
  67         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
  68         instead of qsort.
  69         * disasm.c (compare_lines): Rename to...
  70         (line_is_less_than): ...this, and change to std::sort semantics.
  71         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
  72         of qsort.
  73         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
  74         (fde_is_less_than): ...this, and change to std::sort semantics.
  75         (dwarf2_build_frame_info): Call std::sort instead of qsort.
  76         * mdebugread.c (compare_blocks):
  77         (block_is_less_than): ...this, and change to std::sort semantics.
  78         (sort_blocks): Call std::sort instead of qsort.
  79         * objfiles.c (qsort_cmp): Rename to...
  80         (sort_cmp): ...this, and change to std::sort semantics.
  81         (update_section_map): Call std::sort instead of qsort.
  82         * remote.c (compare_pnums): Remove.
  83         (map_regcache_remote_table): Call std::sort instead of qsort.
  84         * utils.c (compare_positive_ints): Remove.
  85         * utils.h (compare_positive_ints): Remove.
  86         * xcoffread.c (compare_lte): Remove.
  87         (arrange_linetable): Call std::sort instead of qsort.
  88
  89 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
  90
  91         * symfile.c (init_entry_point_info): Fix typo.
  92         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
  93
  94 2019-10-18  Tom de Vries  <tdevries@suse.de>
  95
  96         * aarch64-tdep.c: Fix typos in comments.
  97         * ada-lang.c: Same.
  98         * ada-tasks.c: Same.
  99         * alpha-tdep.c: Same.
 100         * alpha-tdep.h: Same.
 101         * amd64-nat.c: Same.
 102         * amd64-windows-tdep.c: Same.
 103         * arc-tdep.c: Same.
 104         * arc-tdep.h: Same.
 105         * arch-utils.c: Same.
 106         * arm-nbsd-tdep.c: Same.
 107         * arm-tdep.c: Same.
 108         * ax-gdb.c: Same.
 109         * blockframe.c: Same.
 110         * btrace.c: Same.
 111         * c-varobj.c: Same.
 112         * coff-pe-read.c: Same.
 113         * coffread.c: Same.
 114         * cris-tdep.c: Same.
 115         * darwin-nat.c: Same.
 116         * dbxread.c: Same.
 117         * dcache.c: Same.
 118         * disasm.c: Same.
 119         * dtrace-probe.c: Same.
 120         * dwarf-index-write.c: Same.
 121         * dwarf2-frame-tailcall.c: Same.
 122         * dwarf2-frame.c: Same.
 123         * dwarf2read.c: Same.
 124         * eval.c: Same.
 125         * exceptions.c: Same.
 126         * fbsd-tdep.c: Same.
 127         * findvar.c: Same.
 128         * frame.c: Same.
 129         * frv-tdep.c: Same.
 130         * gnu-v3-abi.c: Same.
 131         * go32-nat.c: Same.
 132         * h8300-tdep.c: Same.
 133         * hppa-tdep.c: Same.
 134         * i386-linux-tdep.c: Same.
 135         * i386-tdep.c: Same.
 136         * ia64-libunwind-tdep.c: Same.
 137         * ia64-tdep.c: Same.
 138         * infcmd.c: Same.
 139         * infrun.c: Same.
 140         * linespec.c: Same.
 141         * linux-nat.c: Same.
 142         * linux-thread-db.c: Same.
 143         * machoread.c: Same.
 144         * mdebugread.c: Same.
 145         * mep-tdep.c: Same.
 146         * mn10300-tdep.c: Same.
 147         * namespace.c: Same.
 148         * objfiles.c: Same.
 149         * opencl-lang.c: Same.
 150         * or1k-tdep.c: Same.
 151         * osabi.c: Same.
 152         * ppc-linux-nat.c: Same.
 153         * ppc-linux-tdep.c: Same.
 154         * ppc-sysv-tdep.c: Same.
 155         * printcmd.c: Same.
 156         * procfs.c: Same.
 157         * record-btrace.c: Same.
 158         * record-full.c: Same.
 159         * remote-fileio.c: Same.
 160         * remote.c: Same.
 161         * rs6000-tdep.c: Same.
 162         * s12z-tdep.c: Same.
 163         * score-tdep.c: Same.
 164         * ser-base.c: Same.
 165         * ser-go32.c: Same.
 166         * skip.c: Same.
 167         * sol-thread.c: Same.
 168         * solib-svr4.c: Same.
 169         * solib.c: Same.
 170         * source.c: Same.
 171         * sparc-nat.c: Same.
 172         * sparc-sol2-tdep.c: Same.
 173         * sparc-tdep.c: Same.
 174         * sparc64-tdep.c: Same.
 175         * stabsread.c: Same.
 176         * stack.c: Same.
 177         * symfile.c: Same.
 178         * symtab.c: Same.
 179         * target-descriptions.c: Same.
 180         * target-float.c: Same.
 181         * thread.c: Same.
 182         * utils.c: Same.
 183         * valops.c: Same.
 184         * valprint.c: Same.
 185         * value.c: Same.
 186         * varobj.c: Same.
 187         * windows-nat.c: Same.
 188         * xcoffread.c: Same.
 189         * xstormy16-tdep.c: Same.
 190         * xtensa-tdep.c: Same.
 191
 192 2019-10-17  Tom Tromey  <tromey@adacore.com>
 193
 194         * configure: Rebuild.
 195         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 196         in AC_CONFIG_FILES invocation.
 197         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 198         new-style config.status invocation.
 199
 200 2019-10-17  Tom de Vries  <tdevries@suse.de>
 201
 202         * arm-nbsd-nat.c: Fix typos in comments.
 203         * arm-tdep.c: Same.
 204         * darwin-nat-info.c: Same.
 205         * dwarf2read.c: Same.
 206         * elfread.c: Same.
 207         * event-top.c: Same.
 208         * findvar.c: Same.
 209         * gdbtypes.c: Same.
 210         * hppa-tdep.c: Same.
 211         * i386-tdep.c: Same.
 212         * jit.c: Same.
 213         * main.c: Same.
 214         * mdebugread.c: Same.
 215         * moxie-tdep.c: Same.
 216         * nto-procfs.c: Same.
 217         * osabi.c: Same.
 218         * ppc-linux-tdep.c: Same.
 219         * remote.c: Same.
 220         * riscv-tdep.c: Same.
 221         * s390-tdep.c: Same.
 222         * sh-tdep.c: Same.
 223         * sparc-linux-tdep.c: Same.
 224         * sparc-nat.c: Same.
 225         * stack.c: Same.
 226         * target-descriptions.c: Same.
 227         * top.c: Same.
 228         * varobj.c: Same.
 229
 230 2019-10-16  Tom Tromey  <tom@tromey.com>
 231
 232         * objfiles.h (struct objfile) <original_name>: Now const.
 233
 234 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 235
 236         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 237         pass on to sigsetjmp's second argument.
 238         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 239
 240 2019-10-16  Keith Seitz  <keiths@redhat.com>
 241
 242         PR gdb/23567
 243         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 244         sections whose size is greater than the file size.
 245
 246 2019-10-16  Jim Wilson  <jimw@sifive.com>
 247
 248         * riscv-tdep.c (riscv_gcc_target_options): New.
 249         (riscv_gnu_triplet_regexp): New.
 250         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 251         set_gdbarch_gnu_triplet_regexp.
 252
 253 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 254
 255         * Makefile.in: Add xml-builtin.h.
 256         * features/feature_to_c.sh: Add an include for xml-builtin.h
 257         to ensure that the compiler checks that the types match.
 258         * xml-builtin.h: New file.
 259         * xml-support.c (fetch_xml_builtin): Add missing const.
 260         * xml-support.h: Remove declaration of xml_builtins.
 261
 262 2019-10-16  Tom de Vries  <tdevries@suse.de>
 263
 264         PR tdep/25096
 265         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 266         (amd64_classify_aggregate): ... here.
 267         (amd64_classify_aggregate_field): Handled fiels of nested structs
 268         recursively.
 269
 270 2019-10-16  Tom de Vries  <tdevries@suse.de>
 271
 272         PR tdep/24104
 273         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 274         that handles 'theclass'.
 275
 276 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * linespec.c (decode_digits_ordinary): Update comment.
 279         * make-target-delegates: No longer need to handle VEC case.
 280         * memrange.c (normalize_mem_ranges): Update comment.
 281         * namespace.c (add_using_directive): Update comment.
 282         * objc-lang.c (uniquify_strings): Update comment.
 283         * ppc-linux-nat.c (struct thread_points): Update comment.
 284         * probe.h (find_probes_in_objfile): Update comment.
 285         * target.h (enum flash_preserve_mode): Update comment.
 286         * varobj.c (varobj_restrict_range): Update comment.
 287         * varobj.h (varobj_list_children): Update comment.
 288
 289 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * Makefile.in: Remove references to vec.h and vec.c.
 292         * aarch64-tdep.c: No longer include vec.h.
 293         * ada-lang.c: Likewise.
 294         * ada-lang.h: Likewise.
 295         * arm-tdep.c: Likewise.
 296         * ax.h: Likewise.
 297         * breakpoint.h: Likewise.
 298         * charset.c: Likewise.
 299         * cp-support.h: Likewise.
 300         * dtrace-probe.c: Likewise.
 301         * dwarf2read.c: Likewise.
 302         * extension.h: Likewise.
 303         * gdb_bfd.c: Likewise.
 304         * gdbsupport/gdb_vecs.h: Likewise.
 305         * gdbsupport/vec.c: Remove.
 306         * gdbsupport/vec.h: Remove.
 307         * gdbthread.h: Likewise.
 308         * guile/scm-type.c: Likewise.
 309         * inline-frame.c: Likewise.
 310         * machoread.c: Likewise.
 311         * memattr.c: Likewise.
 312         * memrange.h: Likewise.
 313         * namespace.h: Likewise.
 314         * nat/linux-btrace.h: Likewise.
 315         * osdata.c: Likewise.
 316         * parser-defs.h: Likewise.
 317         * progspace.h: Likewise.
 318         * python/py-type.c: Likewise.
 319         * record-btrace.c: Likewise.
 320         * rust-exp.y: Likewise.
 321         * solib-target.c: Likewise.
 322         * stap-probe.c: Likewise.
 323         * target-descriptions.c: Likewise.
 324         * target-memory.c: Likewise.
 325         * target.h: Likewise.
 326         * varobj.c: Likewise.
 327         * varobj.h: Likewise.
 328         * xml-support.h: Likewise.
 329
 330 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 333         Update for new std::vector based implementation.
 334         (process_psymtab_comp_unit_reader): Likewise.
 335         (scan_partial_symbols): Likewise.
 336         (recursively_compute_inclusions): Likewise.
 337         (compute_compunit_symtab_includes): Likewise.
 338         (process_imported_unit_die): Likewise.
 339         (queue_and_load_dwo_tu): Likewise.
 340         (follow_die_sig_1): Likewise.
 341         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 342         (typedef dwarf2_per_cu_ptr): Remove.
 343         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 344         function.
 345         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 346         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 347         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 348         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 349         std::vector.
 350
 351 2019-10-15  Tom Tromey  <tromey@adacore.com>
 352
 353         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 354         TID.
 355
 356 2019-10-15  Tom Tromey  <tromey@adacore.com>
 357
 358         * windows-nat.c (windows_nat_target::fetch_registers)
 359         (windows_nat_target::store_registers): Rename "pid" to "tid".
 360
 361 2019-10-15  Tom Tromey  <tromey@adacore.com>
 362
 363         * gdbarch.h, gdbarch.c: Rebuild.
 364         * gdbarch.sh (gcc_target_options): Change return type to
 365         std::string.
 366         * compile/compile.c (get_args): Update.
 367         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 368         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 369         std::string.
 370         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 371         std::string.
 372         * arch-utils.c (default_gcc_target_options): Return std::string.
 373         * arch-utils.h (default_gcc_target_options): Return std::string.
 374         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 375
 376 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 377
 378         * breakpoint.c (breakpoint_chain): Make static.
 379         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 380         of accessing breakpoint_chain.
 381
 382 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 385         to a gdb::function_view and return value to bool.
 386         * breakpoint.h (iterate_over_breakpoints): Likewise.
 387         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 388         (pop_dummy_frame): Update.
 389         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 390         (gdbscm_breakpoints): Update.
 391         * python/py-breakpoint.c (build_bp_list): Update.
 392         (gdbpy_breakpoints): Update.
 393         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 394         Update.
 395         (bpfinishpy_handle_stop): Update.
 396         (bpfinishpy_handle_exit): Update.
 397         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 398         (svr4_update_solib_event_breakpoints): Update.
 399
 400 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 401
 402         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 403         when unwrapping single-field structs.
 404
 405 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 406
 407         * dwarf2read.c: Remove includes.
 408
 409 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 410
 411         * ui-out.c (ui_out::call_do_message): Silence
 412         -Wformat-nonliteral warning.
 413
 414 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 415
 416         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 417         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 418         include: readline/tilde.h.
 419
 420 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 421
 422         * remote.c (remote_target::get_trace_status): Remove declaration of
 423         trace_regblock_size.
 424
 425 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 426
 427         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 428         (show_user): Remove declaration of cmdlist.
 429         * cli/cli-cmds.h (max_user_call_depth): Declare.
 430         * cli/cli-script.c (execute_user_command): Remove declaration
 431         of max_user_call_depth.
 432
 433 2019-10-11  Jim Wilson  <jimw@sifive.com>
 434
 435         * gdbsupport/print-utils.h (pulongest): Fix comment.
 436         (plongest): Likewise.
 437         (phex): Add missing comment, mention leading zeros.
 438         (phex_nz): Add mention of no leading zeros to comment.
 439
 440         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 441         plongest instead of unsigned long long cast.
 442
 443 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 444
 445         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 446         for external_editor_command and gdbtk_test.
 447
 448 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 451         * varobj.c (varobjdebug): Move comment to...
 452         * varobj.h (varobjdebug): ...here, and declare.
 453
 454 2019-10-09  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 457         erase_data_content.
 458
 459 2019-10-09  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 462         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 463         * tui/tui-command.c (tui_cmd_window::resize)
 464         (tui_refresh_cmd_win): Update.
 465         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 466         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 467         * tui/tui-data.c (~tui_gen_win_info): Remove.
 468         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 469         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 470         (tui_redisplay_readline, tui_mld_flush)
 471         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 472         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 473         (tui_data_window::erase_data_content)
 474         (tui_data_item_window::rerender)
 475         (tui_data_item_window::refresh_window): Update.
 476         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 477         (box_win, tui_gen_win_info::make_window)
 478         (tui_gen_win_info::make_visible): Update.
 479         (tui_delete_win): Remove.
 480         * tui/tui-winsource.c
 481         (tui_source_window_base::do_erase_source_content): Update.
 482         (tui_show_source_line, tui_source_window_base::update_tab_width)
 483         (tui_source_window_base::update_exec_info): Update.
 484         * tui/tui-data.h (struct curses_deleter): New.
 485         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 486         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 487
 488 2019-10-09  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 491
 492 2019-10-09  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 495         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 496
 497 2019-10-09  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 500         window height directly.
 501         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 502         declare.
 503         * tui/tui-layout.c (tui_default_win_height): Remove.
 504         (tui_default_win_viewport_height): Remove.
 505
 506 2019-10-09  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui.h: Remove comments.
 509
 510 2019-10-09  Tom de Vries  <tdevries@suse.de>
 511
 512         * python/lib/gdb/printer/bound_registers.py: Use
 513         '^builtin_type_bound128' as regexp argument for
 514         add_builtin_pretty_printer.
 515
 516 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 517
 518         * guile/guile.c (guile_extension_script_ops): Remove forward
 519         declaration and mark as static.
 520         (guile_script_ops): Likewise.
 521         (extension_language_guile): Move further down in the file so
 522         it can reference the definitions for guile_{extension_,}script_ops.
 523
 524 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 525
 526         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 527         except SORTL, DFLTCC, and KDSA.
 528
 529 2019-10-08  Tom Tromey  <tromey@adacore.com>
 530
 531         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 532         (struct safe_symbol_file_add_args): Remove.
 533
 534 2019-10-08  Tom Tromey  <tromey@adacore.com>
 535
 536         * windows-nat.c: Don't include buildsym-legacy.h.
 537
 538 2019-10-08  Tom Tromey  <tromey@adacore.com>
 539
 540         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 541
 542 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 543
 544         * gdbtypes.c (overload_debug): Move comment to header.
 545         * gdbtypes.h (overload_debug): Declare.
 546         * valops.c: Remove declaration of overload_debug, instead
 547         include gdbtypes.h.
 548
 549 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 550
 551         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 552         through _().
 553         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 554         move comment...
 555         * language.h (lang_frame_mismatch_warn): ... here. Also add
 556         declaration.
 557         * top.c (lang_frame_mismatch_warn): Remove declaration.
 558         (check_frame_language_change): Pass lang_frame_mismatch_warn
 559         through _().
 560
 561 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 562
 563         * c-lang.h (vtbl_ptr_name): Declare.
 564         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 565         it from the header.
 566         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 567
 568 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 569
 570         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 571         gdb_static_assert.
 572
 573 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 574
 575         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 576         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 577         * ctfread.c: New file.
 578         * ctfread.h: New file.
 579         * elfread.c: Include ctfread.h.
 580         (struct elfinfo text_p): New member ctfsect.
 581         (elf_locate_sections): Mark CTF section.
 582         (elf_symfile_read): Call elfctf_build_psymtabs.
 583         * Makefile.in (LIBCTF): Add.
 584         (CLIBS): Use it.
 585         (CDEPS): Likewise.
 586         (DIST): Add ctfread.c.
 587
 588 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * ctfread.c (struct nextfield): Renamed to ...
 591         (struct ctf_nextfield): ... this.
 592         (struct field_info): Renamed to ...
 593         (strut ctf_field_info): ... this.
 594         (attach_fields_to_type): Update for renamed structures.
 595         (ctf_add_member_cb): Likewise.
 596         (ctf_add_enum_member_cb): Likewise.
 597         (process_struct_members): Likewise.
 598         (process_enum_type): Likewise.
 599
 600 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 601
 602         * tracectf.h: Rename, was ctf.h.
 603         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 604         * tracefile.c: Likewise.
 605         * tracepoint.c: Remove unused include ctf.h.
 606         * mi/mi-main.c: Likewise.
 607         * Makefile.in Replace ctf.c with tracectf.c.
 608
 609 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 610
 611         * version.in: Change version number to "9.0.50.DATE-git".
 612
 613 2019-10-03  Tom Tromey  <tom@tromey.com>
 614
 615         PR rust/24976:
 616         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 617
 618 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 619
 620         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 621         cp_search_name_hash.
 622         * NEWS: Add entry about nested function support.
 623
 624 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 625             Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 628         for nested static variables when searchin VAR_DOMAIN.
 629         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 630         global scope, update comment.
 631         (add_partial_subprogram): Call add_partial_subprogram recursively
 632         for nested subroutines when processinng Fortran.
 633         (load_partial_dies): Process the child entities of a subprogram
 634         when processing Fortran.
 635         (partial_die_parent_scope): Handle building scope
 636         for Fortran nested functions.
 637         (process_die): Record that nested functions have a scope.
 638         (new_symbol): Always record Fortran subprograms on the global
 639         symbol list.
 640         (determine_prefix): How to build the prefix for Fortran
 641         subprograms.
 642
 643 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 646         have just sent the thread a SIGSTOP and are waiting for it to
 647         arrive.
 648
 649 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 650
 651         * btrace.c (btrace_add_pc): Remove whitespace before the template
 652         parameter in 'std::vector <...>'.
 653         (parse_xml_btrace_block): Likewise.
 654         (btrace_maint_decode_pt): Likewise.
 655         (btrace_maint_update_packets): Likewise.
 656         (btrace_maint_print_packets): Likewise.
 657         * btrace.h (struct btrace_maint_info): Likewise.
 658         * dwarf2read.c (struct type_unit_group): Likewise.
 659         (build_type_psymtabs_reader): Likewise.
 660         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 661         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 662         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 663
 664 2019-10-03  Tom de Vries  <tdevries@suse.de>
 665
 666         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 667         the first line of the help text for set/show style metadata.
 668
 669 2019-10-02  Tom Tromey  <tromey@adacore.com>
 670
 671         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 672         * gdbsupport/common-inferior.c: New file.
 673         * infcmd.c (startup_with_shell): Don't define.
 674         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 675         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 676         * inferior.h (startup_with_shell): Don't declare.
 677
 678 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 679
 680         * gdbsupport/gdb_assert.h: Include errors.h.
 681         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 682
 683 2019-10-02  Tom Tromey  <tromey@adacore.com>
 684
 685         * NEWS: Add $_ada_exception entry.
 686         * ada-lang.c (struct ada_catchpoint): Add constructor.
 687         <m_kind>: New member.
 688         (allocate_location_exception, re_set_exception): Remove
 689         "ex" parameter.
 690         (should_stop_exception): Compute $_ada_exception.
 691         (check_status_exception, print_it_exception)
 692         (print_one_exception, print_mention_exception): Remove
 693         "ex" parameter.
 694         (allocate_location_catch_exception, re_set_catch_exception)
 695         (check_status_exception, print_it_catch_exception)
 696         (print_one_catch_exception, print_mention_catch_exception)
 697         (print_recreate_catch_exception)
 698         (allocate_location_catch_exception_unhandled)
 699         (re_set_catch_exception_unhandled)
 700         (check_status_exception, print_it_catch_exception_unhandled)
 701         (print_one_catch_exception_unhandled)
 702         (print_mention_catch_exception_unhandled)
 703         (print_recreate_catch_exception_unhandled)
 704         (allocate_location_catch_assert, re_set_catch_assert)
 705         (check_status_assert, print_it_catch_assert)
 706         (print_one_catch_assert, print_mention_catch_assert)
 707         (print_recreate_catch_assert)
 708         (allocate_location_catch_handlers, re_set_catch_handlers)
 709         (check_status_handlers, print_it_catch_handlers)
 710         (print_one_catch_handlers, print_mention_catch_handlers)
 711         (print_recreate_catch_handlers): Remove.
 712         (create_ada_exception_catchpoint): Update.
 713         (initialize_ada_catchpoint_ops): Update.
 714
 715 2019-10-02  Tom Tromey  <tromey@adacore.com>
 716
 717         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 718         (create_excep_cond_exprs): Simplify exception string computation.
 719         (ada_exception_catchpoint_cond_string): Likewise.
 720
 721 2019-10-02  Tom Tromey  <tromey@adacore.com>
 722
 723         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 724         * ada-lang.c (lesseq_defined_than): Handle
 725         LOC_STATIC.
 726         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 727         parameter.
 728         (dwarf2_has_info): Likewise.
 729         (new_symbol): Set maybe_copied on symbol when
 730         appropriate.
 731         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 732         parameter.
 733         <can_copy>: New member.
 734         * elfread.c (record_minimal_symbol): Set maybe_copied
 735         on symbol when appropriate.
 736         (elf_symfile_read): Update call to dwarf2_has_info.
 737         * minsyms.c (lookup_minimal_symbol_linkage): New
 738         function.
 739         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 740         * symtab.c (get_symbol_address, get_msymbol_address):
 741         New functions.
 742         * symtab.h (get_symbol_address, get_msymbol_address):
 743         Declare.
 744         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 745         maybe_copied.
 746         (struct symbol, struct minimal_symbol) <maybe_copied>:
 747         New member.
 748
 749 2019-10-02  Tom Tromey  <tromey@adacore.com>
 750
 751         * source.c (struct current_source_location): New.
 752         (current_source_key): New global.
 753         (current_source_symtab, current_source_line)
 754         (current_source_pspace): Remove.
 755         (get_source_location): New function.
 756         (get_current_source_symtab_and_line)
 757         (set_default_source_symtab_and_line)
 758         (set_current_source_symtab_and_line)
 759         (clear_current_source_symtab_and_line, select_source_symtab)
 760         (info_source_command, print_source_lines_base)
 761         (info_line_command, search_command_helper, _initialize_source):
 762         Update.
 763
 764 2019-10-02  Tom Tromey  <tromey@adacore.com>
 765
 766         * source.c (select_source_symtab): Don't call
 767         decode_line_with_current_source.
 768
 769 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * symtab.c (lookup_global_symbol): Search global block.
 772
 773 2019-10-02  Tom Tromey  <tromey@adacore.com>
 774
 775         * coffread.c (process_coff_symbol): Update.
 776         * dwarf2read.c (var_decode_location, new_symbol): Update.
 777         * mdebugread.c (parse_symbol): Update.
 778         * objfiles.c (relocate_one_symbol): Update.
 779         * stabsread.c (define_symbol, fix_common_block)
 780         (scan_file_globals): Update.
 781         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 782         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 783         * xcoffread.c (process_xcoff_symbol): Update.
 784
 785 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 786
 787         * MAINTAINERS: Update my email address.
 788
 789 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 792         std::vector.
 793         (build_type_psymtabs_reader): Update for std::vector.
 794         (build_type_psymtab_dependencies): Likewise.
 795         * dwarf2read.h: Remove use of DEF_VEC_P.
 796         (typedef sig_type_ptr): Delete.
 797
 798 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 801         to std::vector.
 802         (btrace_maint_decode_pt): Likewise, and move allocation of the
 803         vector outside of the loop.
 804         (btrace_maint_update_packets): Update to handle change from VEC to
 805         std::vector.
 806         (btrace_maint_print_packets): Likewise.
 807         (maint_info_btrace_cmd): Likewise.
 808         * btrace.h: Remove use of DEF_VEC_O.
 809         (typedef btrace_pt_packet_s): Delete.
 810         (struct btrace_maint_info) <packets>: Change fromm VEC to
 811         std::vector.
 812         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 813
 814 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 815
 816         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 817         make accesses into the vector constant references.
 818         (btrace_add_pc): Update for std::vector.
 819         (btrace_stitch_bts): Likewise.
 820         (parse_xml_btrace_block): Likewise.
 821         (btrace_maint_update_packets): Likewise.
 822         (btrace_maint_print_packets): Likewise.
 823         (maint_info_btrace_cmd): Likewise.
 824         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 825         std::vector.
 826         (btrace_data::empty): Likewise.
 827         (btrace_data_append): Likewise.
 828         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 829         (typedef btrace_block_s): Delete.
 830         (struct btrace_block): Add constructor.
 831         (struct btrace_data_bts) <blocks>: Change to std::vector.
 832         * nat/linux-btrace.c (perf_event_read_bts): Update for
 833         std::vector.
 834         (linux_read_bts): Likewise.
 835
 836 2019-10-01  Tom Tromey  <tom@tromey.com>
 837
 838         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 839
 840 2019-10-01  Tom Tromey  <tom@tromey.com>
 841
 842         * stack.c (print_frame, info_frame_command_core): Use
 843         styled_string.
 844         * linux-thread-db.c (try_thread_db_load_1)
 845         (try_thread_db_load_from_pdir_1): Use styled_string.
 846         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 847         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 848         (maybe_print_unsupported_script_warning)
 849         (maybe_print_script_not_found_warning): Use styled_string.
 850         * ada-lang.c (user_select_syms): Use styled_string.
 851
 852 2019-10-01  Tom Tromey  <tom@tromey.com>
 853
 854         * p-lang.c (pascal_printstr): Use metadata style.
 855         * value.c (show_convenience): Use metadata style.
 856         * valprint.c (valprint_check_validity, val_print_optimized_out)
 857         (val_print_not_saved, val_print_unavailable)
 858         (val_print_invalid_address, generic_val_print, val_print)
 859         (value_check_printable, val_print_array_elements): Use metadata
 860         style.
 861         * ui-out.h (class ui_out) <field_fmt>: New overload.
 862         <do_field_fmt>: Add style parameter.
 863         * ui-out.c (ui_out::field_fmt): New overload.
 864         * typeprint.c (type_print_unknown_return_type)
 865         (val_print_not_allocated, val_print_not_associated): Use metadata
 866         style.
 867         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 868         parameter.
 869         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 870         * tracepoint.c (tvariables_info_1): Use metadata style.
 871         * stack.c (print_frame_arg, print_frame_info, print_frame)
 872         (info_frame_command_core): Use metadata style.
 873         * skip.c (info_skip_command): Use metadata style.
 874         * rust-lang.c (rust_print_enum): Use metadata style.
 875         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 876         metadata style.
 877         * python/py-framefilter.c (py_print_single_arg): Use metadata
 878         style.
 879         * printcmd.c (do_one_display, print_variable_and_value): Use
 880         metadata style.
 881         * p-valprint.c (pascal_val_print)
 882         (pascal_object_print_value_fields): Use metadata style.
 883         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 884         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 885         parameter.
 886         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 887         * m2-valprint.c (m2_print_long_set): Use metadata style.
 888         * m2-typeprint.c (m2_print_type): Use metadata style.
 889         * infcmd.c (print_return_value_1): Use metadata style.
 890         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 891         * f-valprint.c (info_common_command_for_block): Use metadata
 892         style.
 893         * f-typeprint.c (f_type_print_base): Use metadata style.
 894         * expprint.c (print_subexp_standard): Use metadata style.
 895         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 896         * cli/cli-style.h (class cli_style_option): Add constructor.
 897         (metadata_style): Declare.
 898         * cli/cli-style.c (metadata_style): New global.
 899         (_initialize_cli_style): Register metadata style.
 900         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 901         parameter.
 902         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 903         * c-typeprint.c (c_type_print_base_struct_union)
 904         (c_type_print_base_1): Use metadata style.
 905         * breakpoint.c (watchpoint_value_print)
 906         (print_one_breakpoint_location): Use metadata style.
 907         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 908         style.
 909         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 910         style.
 911         * ada-valprint.c (val_print_packed_array_elements, printstr)
 912         (print_field_values, ada_val_print_ref, ada_val_print): Use
 913         metadata style.
 914         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 915         style.
 916         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 917         style.
 918         * ada-lang.c (user_select_syms): Use metadata style.
 919
 920 2019-10-01  Tom Tromey  <tom@tromey.com>
 921
 922         * cli/cli-cmds.c (pwd_command): Style output.
 923
 924 2019-10-01  Pedro Alves  <palves@redhat.com>
 925             Tom Tromey  <tom@tromey.com>
 926
 927         * symtab.c (print_symbol_info): Use %ps.
 928         (print_msymbol_info): Use %ps.
 929         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 930         * printcmd.c (print_variable_and_value): Use %ps.
 931         * macrocmd.c (show_pp_source_pos): Use %ps.
 932         * infrun.c (print_exited_reason): Use ui_out::message.
 933         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 934         (describe_other_breakpoints): Use ui_out::message and new
 935         formats.
 936         (say_where): Use new formats.
 937         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 938         and new formats.
 939
 940 2019-10-01  Pedro Alves  <palves@redhat.com>
 941             Tom Tromey  <tom@tromey.com>
 942
 943         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 944         (test_gdb_formats): New function.
 945         (run_tests): Call it.
 946         (test_format_specifier): Update.
 947         * utils.h (fputs_filtered): Update comment.
 948         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 949         (fputs_styled_unfiltered): Declare.
 950         * utils.c (fputs_styled_unfiltered): New function.
 951         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 952         (vfprintf_filtered): Update.
 953         (vfprintf_unfiltered, vprintf_filtered): Update.
 954         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 955         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 956         disallow_ui_out_field>: New constants.
 957         (enum class field_kind): New.
 958         (struct base_field_s, struct signed_field_s): New.
 959         (signed_field): New function.
 960         (struct string_field_s): New.
 961         (string_field): New function.
 962         (struct styled_string_s): New.
 963         (styled_string): New function.
 964         (class ui_out) <message>: Add comment.
 965         <vmessage, call_do_message>: New methods.
 966         <do_message>: Add style parameter.
 967         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 968         methods.
 969         (ui_out::message): Rewrite.
 970         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 971         parameter.
 972         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 973         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 974         gdb_extensions parameter.
 975         (class format_piece): Add parameter to constructor.
 976         (n_int_args): New field.
 977         * gdbsupport/format.c (format_pieces::format_pieces): Add
 978         gdb_extensions parameter.  Handle '*'.
 979         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 980         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 981         vfprintf_styled_no_gdbfmt.
 982         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 983         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 984         unfiltered output.
 985         * ui-style.h (struct ui_file_style) <ptr>: New method.
 986
 987 2019-10-01  Tom Tromey  <tom@tromey.com>
 988
 989         * unittests/format_pieces-selftests.c: Update.  Add final format.
 990         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 991         empty literal pieces.
 992
 993 2019-10-01  Tom Tromey  <tom@tromey.com>
 994
 995         * ui-out.h (enum class ui_out_style_kind): Remove.
 996         (class ui_out) <field_string, field_stsream, do_field_string>:
 997         Change type of "style".
 998         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 999         (ui_out::field_string): Update.
1000         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1001         of "style".
1002         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1003         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1004         * stack.c (print_frame_arg, print_frame_info, print_frame):
1005         Update.
1006         * source.c (print_source_lines_base): Update.
1007         * solib.c (info_sharedlibrary_command): Update.
1008         * skip.c (info_skip_command): Update.
1009         * record-btrace.c (btrace_call_history_src_line)
1010         (btrace_call_history): Update.
1011         * python/py-framefilter.c (py_print_frame): Update.
1012         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1013         "style".
1014         * mi/mi-out.c (mi_ui_out::do_table_header)
1015         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1016         (mi_ui_out::do_field_string): Update.
1017         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1018         Update.
1019         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1020         "style".
1021         * cli-out.c (cli_ui_out::do_table_header)
1022         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1023         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1024         (cli_ui_out::do_field_fmt): Update.
1025         * breakpoint.c (print_breakpoint_location): Update.
1026         (update_static_tracepoint): Update.
1027
1028 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1029
1030         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1031         conversion of gdb_datadir.
1032         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1033         remove not needed c_str ().
1034
1035 2019-09-30  Ali Tamur <tamur@google.com>
1036
1037         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1038         (dwarf2_string_attr): Likewise.
1039
1040 2019-09-30  Ali Tamur <tamur@google.com>
1041
1042         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1043         (process_full_type_unit): Likewise.
1044         (dump_die_shallow): Likewise.
1045         (cu_debug_loc_section): Likewise.
1046
1047 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1048
1049         * minsyms.c (compare_minimal_symbols): Rename to...
1050         (minimal_symbol_is_less_than): ...this, and adjust to STL
1051         conventions (return bool, take arguments as references)
1052         (minimal_symbol_reader::install): Call std::sort instead
1053         of qsort.
1054
1055 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1056
1057         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1058         hash and why.
1059         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1060         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1061
1062 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1063
1064         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1065         * psympriv.h (add_psymbol_to_list): Move comment here and update
1066         it.
1067
1068 2019-09-29  Tom de Vries  <tdevries@suse.de>
1069
1070         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1071         Use $tmpdir/$(basename "$output_file").dwz instead of
1072         "${output_file}.dwz".
1073
1074 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1075
1076         PR gdb/25045
1077         * hppa-linux-nat.c: Include gdbarch.h.
1078
1079 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1080
1081         * blockframe.c (find_pc_partial_function): Change return type to bool.
1082         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1083         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1084         (stub_gnu_ifunc_resolve_name): Likewise.
1085         * symtab.c (compare_filenames_for_search): Likewise.
1086         (compare_glob_filenames_for_search): Likewise.
1087         (matching_obj_sections): Likewise.
1088         (symbol_matches_domain): Likewise.
1089         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1090         (find_line_pc): Change return type to bool.
1091         (find_line_pc_range): Likewise.
1092         (producer_is_realview): Likewise.
1093         * symtab.h (symbol_matches_domain): Likewise.
1094         (find_pc_partial_function): Likewise.
1095         (find_pc_line_pc_range): Likewise.
1096         (in_gnu_ifunc_stub): Likewise.
1097         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1098         (find_line_pc): Likewise.
1099         (find_line_pc_range): Likewise.
1100         (matching_obj_sections): Likewise.
1101         (find_line_symtab): Change out parameter to bool.
1102         (producer_is_realview): Change return type to bool.
1103         (compare_filenames_for_search): Likewise.
1104         (compare_glob_filenames_for_search): Likewise.
1105
1106 2019-09-26  Tom Tromey  <tom@tromey.com>
1107
1108         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1109         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1110         * gdb_usleep.h: Remove.
1111         * gdb_usleep.c: Remove.
1112         * utils.c: Don't include gdb_usleep.h.
1113
1114 2019-09-26  Tom Tromey  <tromey@adacore.com>
1115
1116         * python/py-type.c (type_to_type_object): Call check_typedef
1117         for stub types.
1118
1119 2019-09-26  Tom Tromey  <tom@tromey.com>
1120
1121         * utils.h (initialize_utils): Don't declare.
1122         * top.c (gdb_init): Don't call initialize_utils.
1123         * utils.c (initialize_utils): Remove.  Move contents...
1124         (_initialize_utils): ... here.
1125
1126 2019-09-25  Tom Tromey  <tom@tromey.com>
1127
1128         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1129         * utils.h (make_hex_string): Don't declare.
1130         * utils.c (make_hex_string): Remove.
1131
1132 2019-09-24  Tom de Vries  <tdevries@suse.de>
1133
1134         PR gdb/23815
1135         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1136         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1137
1138 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1139
1140         * NEWS: Mention new simulator port for PRU.
1141
1142 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1143
1144         * ada-exp.y (write_object_remaining): Update.
1145         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1146         and eliminate the static buffer.
1147         (ada_decode_symbol): Update.
1148         (ada_la_decode): Update.
1149         (ada_sniff_from_mangled_name): Update.
1150         (is_valid_name_for_wild_match): Update.
1151         (ada_lookup_name_info::matches): Update and simplify.
1152         (name_matches_regex): Update.
1153         (ada_add_global_exceptions): Update.
1154         * ada-lang.h (ada_decode): Update signature.
1155         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1156         * dwarf-index-write.c (debug_names::insert): Update.
1157
1158 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1159
1160         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1161         formatting.
1162
1163 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1164
1165         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1166         Change "nonzero" to "true" in documentation.
1167
1168 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1171         (_initialize_darwin_solib): Don't set
1172         darwin_so_ops.lookup_lib_global_symbol.
1173         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1174         set_gdbarch_iterate_over_objfiles_in_search_order.
1175         (elf_lookup_lib_symbol): Rename to...
1176         (svr4_iterate_over_objfiles_in_search_order): this, and update
1177         to iterate semantics.
1178         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1179         * solib.c (solib_global_lookup): Remove.
1180         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1181         (solib_global_lookup): Remove.
1182         * symtab.c (lookup_global_or_static_symbol): Remove call to
1183         solib_global_lookup.
1184
1185 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1186
1187         * NEWS: Move entries about default MI version now being
1188         version 3, and about the GDB/MI fix for multi-location
1189         breakpoints to the "since GDB 8.3" section.
1190
1191 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1192
1193         GDB 8.3.1 released.
1194
1195 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1196
1197         * NEWS: Mention that Cell/B.E. debugging support was removed.
1198         * MAINTAINERS: Remove spu target.
1199
1200         * config/djgpp/fnchange.lst: Remove entries for removed files.
1201
1202         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1203         spu-multiarch.o, and spu-tdep.o.
1204         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1205         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1206         spu-multiarch.c, and spu-tdep.c.
1207         * spu-linux-nat.c: Remove file.
1208         * spu-multiarch.c: Remove file.
1209         * spu-tdep.c: Remove file.
1210         * spu-tdep.h: Remove file.
1211         * solib-spu.c: Remove file.
1212         * solib-spu.h: Remove file.
1213
1214         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1215         * configure.nat (spu-linux): Remove.
1216         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1217         solib-multiarch.o from gdb_target_obs.
1218         (spu*-*-*): Remove.
1219
1220         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1221         feature flag.
1222         (ppc_linux_no_features): Update.
1223         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1224         Cell/B.E. support.
1225         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1226         (tdesc_powerpc_cell64l): Likewise.
1227         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1228         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1229         Cell/B.E. support.
1230         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1231         Do not include "features/rs6000/powerpc-cell32l.c" or
1232         "features/rs6000/powerpc-cell64l.c".
1233         (ppc_linux_spu_section): Remove.
1234         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1235         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1236         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1237         (ppc_linux_spe_context_lookup): Remove.
1238         (ppc_linux_spe_context_inferior_created): Remove.
1239         (ppc_linux_spe_context_solib_loaded): Remove.
1240         (ppc_linux_spe_context_solib_unloaded): Remove.
1241         (ppc_linux_spe_context): Remove.
1242         (struct ppu2spu_cache): Remove.
1243         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1244         (struct ppu2spu_data): Remove.
1245         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1246         ppu2spu_unwind): Remove.
1247         (ppc_linux_init_abi): Remove Cell/B.E. support.
1248         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1249
1250         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1251         (rs6000/powerpc-cell64l-expedite): Likewise
1252         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1253         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1254         rs6000/powerpc-cell64l.xml.
1255         * features/rs6000/powerpc-cell32l.xml: Remove.
1256         * features/rs6000/powerpc-cell64l.xml: Likewise.
1257         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1258         * features/rs6000/powerpc-cell64l.c: Likewise.
1259         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1260         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1261         * regformats/reg-spu.dat: Remove.
1262
1263         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1264         * corelow.c (struct spuid_list): Remove.
1265         (add_to_spuid_list): Remove.
1266         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1267         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1268         (remote_protocol_features): Remove associated entries.
1269         (_initialize_remote): No longer initialize them.
1270         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1271         * linux-nat.c (SPUFS_MAGIC): Remove.
1272         (linux_proc_xfer_spu): Remove.
1273         (spu_enumerate_spu_ids): Remove.
1274         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1275         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1276         (linux_make_corefile_notes): No longer call it.
1277
1278         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1279         (cooked_write_test): Likewise.
1280
1281 2019-09-20  Tom Tromey  <tom@tromey.com>
1282
1283         * NEWS: Mention case-sensitivity of TUI commands.
1284         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1285         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1286         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1287
1288 2019-09-20  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-source.c (tui_source_window::set_contents): Use
1291         make_unique_xstrdup.
1292         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1293         make_unique_xstrdup.
1294
1295 2019-09-20  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-data.c: Remove separator comments.
1298         * tui/tui-layout.c: Remove separator comments.
1299         * tui/tui-win.c: Remove separator comments.
1300         * tui/tui-wingeneral.c: Remove separator comments.
1301
1302 2019-09-20  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui.h (strcat_to_buf): Don't declare.
1305         * tui/tui.c (strcat_to_buf): Remove.
1306
1307 2019-09-20  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1310         from "fullname".
1311         * tui/tui-source.c (tui_source_window::set_contents)
1312         (tui_source_window::location_matches_p)
1313         (tui_source_window::maybe_update): Update.
1314
1315 2019-09-20  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1318         Update.
1319         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1320         prefix.
1321         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1322         (tui_data_window::line_from_reg_element_no)
1323         (tui_data_window::first_reg_element_no_inline)
1324         (tui_data_window::show_registers)
1325         (tui_data_window::show_register_group)
1326         (tui_data_window::display_registers_from)
1327         (tui_data_window::display_registers_from_line)
1328         (tui_data_window::first_data_item_displayed)
1329         (tui_data_window::delete_data_content_windows)
1330         (tui_data_window::erase_data_content)
1331         (tui_data_window::do_scroll_vertical)
1332         (tui_data_window::refresh_window)
1333         (tui_data_window::check_register_values): Update.
1334
1335 2019-09-20  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1338         (struct tui_locator_window) <full_name, proc_name>: Now
1339         std::string.
1340         * tui/tui-stack.c (tui_locator_window::make_status_line)
1341         (tui_locator_window::set_locator_fullname)
1342         (tui_locator_window::set_locator_info): Update.
1343         * tui/tui-source.c (tui_source_window::set_contents)
1344         (tui_source_window::showing_source_p): Update.
1345
1346 2019-09-20  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1349         Don't call tui_locator_win_info_ptr.
1350
1351 2019-09-20  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1354
1355 2019-09-20  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1358         height for locator.
1359         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1360         * tui/tui-layout.c (show_source_disasm_command, show_data)
1361         (show_source_or_disasm_and_command): Use 1 as height for locator.
1362
1363 2019-09-20  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui.c (tui_enable): Update.
1366         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1367         Update.
1368         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1369         Update.
1370         * tui/tui-data.c (win_resized): Now bool.
1371         (tui_win_resized): Return bool.
1372         (tui_set_win_resized_to): Accept a bool.
1373
1374 2019-09-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1377         Change type of "refresh_values_only".
1378         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1379         type of "refresh_values_only".
1380
1381 2019-09-20  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1384         std::string.
1385         (tui_disassemble): Add "pos" parameter.
1386         (tui_disasm_window::set_contents): Simplify.
1387
1388 2019-09-20  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-winsource.h (struct tui_source_window_base)
1391         <show_source_content>: Now private.
1392         * tui/tui-winsource.c
1393         (tui_source_window_base::show_source_content): Don't handle empty
1394         content case.
1395
1396 2019-09-20  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-layout.c (show_source_disasm_command)
1399         (show_source_or_disasm_and_command): Don't call
1400         show_source_content.
1401
1402 2019-09-20  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1405         Declare.
1406         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1407         from tui_make_status_line.
1408         (tui_locator_window::rerender): Update.
1409
1410 2019-09-20  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1413         (tui_locator_window::rerender): Update.
1414
1415 2019-09-20  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-winsource.h (struct tui_source_window_base)
1418         <~tui_source_window_base>: Don't declare.
1419         <fullname>: Remove.
1420         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1421         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1422         member.
1423         * tui/tui-source.c (tui_source_window::set_contents): Update.
1424         (tui_source_window::location_matches_p)
1425         (tui_source_window::maybe_update): Update.
1426
1427 2019-09-20  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-winsource.h (~tui_source_element): Remove.
1430         (tui_source_element): Update.
1431         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1432         * tui/tui-winsource.c (tui_show_source_line): Update.
1433         * tui/tui-source.c (tui_source_window::set_contents): Update.
1434         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1435
1436 2019-09-20  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1439         declare.
1440         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1441         tui_clear_source_windows_detail.
1442         * tui/tui-winsource.h (struct tui_source_window_base)
1443         <clear_detail>: Don't declare.
1444         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1445         Remove.
1446         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1447
1448 2019-09-20  Tom Tromey  <tromey@adacore.com>
1449
1450         PR ada/24919:
1451         * block.c (contained_in): Fix final return value.
1452
1453 2019-09-20  Alan Modra  <amodra@gmail.com>
1454
1455         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1456         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1457         (read_indirect_string_from_dwz): Use bfd accessor.
1458         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1459         * machoread.c (macho_symfile_read_all_oso): Likewise.
1460         * solib.c (solib_bfd_open): Likewise.
1461
1462 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1463
1464         * eval.c: Move declaration of overload_resolution to...
1465         * value.h: ...here.
1466
1467 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1468
1469         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1470         * arm-linux-tdep.c: Likewise.
1471         * arm-nbsd-nat.c: Likewise.
1472         * arm-tdep.h: Declare arm_apcs_32.
1473         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1474
1475 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1476
1477         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1478         * dwarf2read.h: Declare dwarf_always_disassemble.
1479
1480 2019-09-19  Tom de Vries  <tdevries@suse.de>
1481
1482         PR gdb/25009
1483         * source-cache.c (source_cache::ensure): Catch exception thrown during
1484         construction of the highlighter.
1485
1486 2019-09-18  Alan Modra  <amodra@gmail.com>
1487
1488         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1489         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1490         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1491         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1492         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1493         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1494         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1495         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1496         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1497         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1498         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1499         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1500         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1501         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1502         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1503         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1504         * mi/mi-interp.c: Update throughout for bfd section macro and
1505         function changes.
1506         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1507         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1508
1509 2019-09-18  Tom Tromey  <tom@tromey.com>
1510
1511         * NEWS: Add entry.
1512         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1513         call rl_initialize.
1514         (tui_enable): Do not call rl_initialize.
1515
1516 2019-09-18  Christian Groessler  <chris@groessler.org>
1517
1518         * alpha-linux-nat.c: Include gdbarch.h.
1519
1520 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1521
1522         * ui-file.c: Include cli/cli-style.h.
1523         (term_cli_styling): Remove cli_styling declaration.
1524
1525 2019-09-18  Alan Modra  <amodra@gmail.com>
1526
1527         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1528         to bfd_asymbol_section.
1529
1530 2019-09-18  Alan Modra  <amodra@gmail.com>
1531
1532         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1533         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1534         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1535
1536 2019-09-18  Alan Modra  <amodra@gmail.com>
1537
1538         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1539         * spu-linux-nat.c (spu_bfd_open): Likewise.
1540
1541 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1542
1543         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1544         to bool to match definition in dwarf2read.c.
1545
1546 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1547
1548         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1549         (print_signatures): Likewise.
1550         (trust_pad_over_xvs): Likewise.
1551         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1552         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1553         * arm-linux-nat.c (arm_apcs_32): Likewise.
1554         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1555         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1556         * arm-tdep.c (arm_debug): Likewise.
1557         (arm_apcs_32): Likewise.
1558         * auto-load.c (debug_auto_load): Likewise.
1559         (auto_load_gdb_scripts): Likewise.
1560         (global_auto_load): Likewise.
1561         (auto_load_local_gdbinit): Likewise.
1562         (auto_load_local_gdbinit_loaded): Likewise.
1563         * auto-load.h (global_auto_load): Likewise.
1564         (auto_load_local_gdbinit): Likewise.
1565         (auto_load_local_gdbinit_loaded): Likewise.
1566         * breakpoint.c (disconnected_dprintf): Likewise.
1567         (breakpoint_proceeded): Likewise.
1568         (automatic_hardware_breakpoints): Likewise.
1569         (always_inserted_mode): Likewise.
1570         (target_exact_watchpoints): Likewise.
1571         (_initialize_breakpoint): Update.
1572         * breakpoint.h (target_exact_watchpoints): Change to bool.
1573         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1574         * cli/cli-cmds.c (trace_commands): Likewise.
1575         * cli/cli-cmds.h (trace_commands): Likewise.
1576         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1577         to bool*.
1578         * cli/cli-logging.c (logging_overwrite): Change to bool.
1579         (logging_redirect): Likewise.
1580         (debug_redirect): Likewise.
1581         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1582         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1583         to bool.
1584         <boolean_option_def>: Update.
1585         (struct flag_option_def): Change default type of Context to bool
1586         from int.
1587         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1588         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1589         (get_setshow_command_value_string): Likewise.
1590         * cli/cli-style.c (cli_styling): Change to bool.
1591         (source_styling): Likewise.
1592         * cli/cli-style.h (source_styling): Likewise.
1593         (cli_styling): Likewise.
1594         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1595         to bool.
1596         * command.h (var_types): Update comment.
1597         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1598         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1599         bool.
1600         (debug_compile_cplus_scopes): Likewise.
1601         * compile/compile-internal.h (compile_debug): Likewise.
1602         * compile/compile.c (compile_debug): Likewise.
1603         (struct compile_options) <raw>: Likewise.
1604         * cp-support.c (catch_demangler_crashes): Likewise.
1605         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1606         (usr_cmd_cris_dwarf2_cfi): Likewise.
1607         * csky-tdep.c (csky_debug): Likewise.
1608         * darwin-nat.c (enable_mach_exceptions): Likewise.
1609         * dcache.c (dcache_enabled_p): Likewise.
1610         * defs.h (info_verbose): Likewise.
1611         * demangle.c (demangle): Likewise.
1612         (asm_demangle): Likewise.
1613         * dwarf-index-cache.c (debug_index_cache): Likewise.
1614         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1615         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1616         * dwarf2read.c (check_physname): Likewise.
1617         (use_deprecated_index_sections): Likewise.
1618         (dwarf_always_disassemble): Likewise.
1619         * eval.c (overload_resolution): Likewise.
1620         * event-top.c (set_editing_cmd_var): Likewise.
1621         (exec_done_display_p): Likewise.
1622         * event-top.h (set_editing_cmd_var): Likewise.
1623         (exec_done_display_p): Likewise.
1624         * exec.c (write_files): Likewise.
1625         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1626         (debug_fbsd_nat): Likewise.
1627         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1628         Likewise.
1629         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1630         <backtrace_past_entry> Likewise.
1631         * gdb-demangle.h (demangle): Likewise.
1632         (asm_demangle): Likewise.
1633         * gdb_bfd.c (bfd_sharing): Likewise.
1634         * gdbcore.h (write_files): Likewise.
1635         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1636         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1637         * gdbthread.h (print_thread_events): Likewise.
1638         * gdbtypes.c (opaque_type_resolution): Likewise.
1639         (strict_type_checking): Likewise.
1640         * gnu-nat.c (gnu_debug_flag): Likewise.
1641         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1642         * guile/scm-param.c (pascm_variable): Add boolval.
1643         (add_setshow_generic): Update.
1644         (pascm_param_value): Update.
1645         (pascm_set_param_value_x): Update.
1646         * hppa-tdep.c (hppa_debug): Change to bool..
1647         * infcall.c (may_call_functions_p): Likewise.
1648         (coerce_float_to_double_p): Likewise.
1649         (unwind_on_signal_p): Likewise.
1650         (unwind_on_terminating_exception_p): Likewise.
1651         * infcmd.c (startup_with_shell): Likewise.
1652         * inferior.c (print_inferior_events): Likewise.
1653         * inferior.h (startup_with_shell): Likewise.
1654         (print_inferior_events): Likewise.
1655         * infrun.c (step_stop_if_no_debug): Likewise.
1656         (detach_fork): Likewise.
1657         (debug_displaced): Likewise.
1658         (disable_randomization): Likewise.
1659         (non_stop): Likewise.
1660         (non_stop_1): Likewise.
1661         (observer_mode): Likewise.
1662         (observer_mode_1): Likewise.
1663         (set_observer_mode): Update.
1664         (sched_multi): Change to bool.
1665         * infrun.h (debug_displaced): Likewise.
1666         (sched_multi): Likewise.
1667         (step_stop_if_no_debug): Likewise.
1668         (non_stop): Likewise.
1669         (disable_randomization): Likewise.
1670         * linux-tdep.c (use_coredump_filter): Likewise.
1671         (dump_excluded_mappings): Likewise.
1672         * linux-thread-db.c (auto_load_thread_db): Likewise.
1673         (check_thread_db_on_load): Likewise.
1674         * main.c (captured_main_1): Update.
1675         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1676         xx2_opt, boolean_opt>: Change to bool.
1677         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1678         * maint.c (maintenance_profile_p): Likewise.
1679         (per_command_time): Likewise.
1680         (per_command_space): Likewise.
1681         (per_command_symtab): Likewise.
1682         * memattr.c (inaccessible_by_default): Likewise.
1683         * mi/mi-main.c (mi_async): Likewise.
1684         (mi_async_1): Likewise.
1685         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1686         * nat/fork-inferior.h (startup_with_shell): Likewise.
1687         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1688         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1689         * nios2-tdep.c (nios2_debug): Likewise.
1690         * or1k-tdep.c (or1k_debug): Likewise.
1691         * parse.c (parser_debug): Likewise.
1692         * parser-defs.h (parser_debug): Likewise.
1693         * printcmd.c (print_symbol_filename): Likewise.
1694         * proc-api.c (procfs_trace): Likewise.
1695         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1696         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1697         (set_parameter_value): Update.
1698         (add_setshow_generic): Update.
1699         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1700         to bool*.
1701         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1702         int*.
1703         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1704         * record-btrace.c (record_btrace_target::store_registers): Update.
1705         * record-full.c (record_full_memory_query): Change to bool.
1706         (record_full_stop_at_limit): Likewise.
1707         * record-full.h (record_full_memory_query): Likewise.
1708         * remote-notif.c (notif_debug): Likewise.
1709         * remote-notif.h (notif_debug): Likewise.
1710         * remote.c (use_range_stepping): Likewise.
1711         (interrupt_on_connect): Likewise.
1712         (remote_break): Likewise.
1713         * ser-tcp.c (tcp_auto_retry): Likewise.
1714         * ser-unix.c (serial_hwflow): Likewise.
1715         * skip.c (debug_skip): Likewise.
1716         * solib-aix.c (solib_aix_debug): Likewise.
1717         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1718         (spu_auto_flush_cache_p): Likewise.
1719         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1720         Likewise.
1721         (struct info_print_options) <quiet>: Likewise.
1722         * symfile-debug.c (debug_symfile): Likewise.
1723         * symfile.c (auto_solib_add): Likewise.
1724         (separate_debug_file_debug): Likewise.
1725         * symfile.h (auto_solib_add): Likewise.
1726         (separate_debug_file_debug): Likewise.
1727         * symtab.c (basenames_may_differ): Likewise.
1728         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1729         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1730         (struct info_types_options) <quiet>: Likewise.
1731         * symtab.h (demangle): Likewise.
1732         (basenames_may_differ): Likewise.
1733         * target-dcache.c (stack_cache_enabled_1): Likewise.
1734         (code_cache_enabled_1): Likewise.
1735         * target.c (trust_readonly): Likewise.
1736         (may_write_registers): Likewise.
1737         (may_write_memory): Likewise.
1738         (may_insert_breakpoints): Likewise.
1739         (may_insert_tracepoints): Likewise.
1740         (may_insert_fast_tracepoints): Likewise.
1741         (may_stop): Likewise.
1742         (auto_connect_native_target): Likewise.
1743         (target_stop_and_wait): Update.
1744         (target_async_permitted): Change to bool.
1745         (target_async_permitted_1): Likewise.
1746         (may_write_registers_1): Likewise.
1747         (may_write_memory_1): Likewise.
1748         (may_insert_breakpoints_1): Likewise.
1749         (may_insert_tracepoints_1): Likewise.
1750         (may_insert_fast_tracepoints_1): Likewise.
1751         (may_stop_1): Likewise.
1752         * target.h (target_async_permitted): Likewise.
1753         (may_write_registers): Likewise.
1754         (may_write_memory): Likewise.
1755         (may_insert_breakpoints): Likewise.
1756         (may_insert_tracepoints): Likewise.
1757         (may_insert_fast_tracepoints): Likewise.
1758         (may_stop): Likewise.
1759         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1760         (make_thread_apply_all_options_def_group): Change argument from int*
1761         to bool*.
1762         (thread_apply_all_command): Update.
1763         (print_thread_events): Change to bool.
1764         * top.c (confirm): Likewise.
1765         (command_editing_p): Likewise.
1766         (history_expansion_p): Likewise.
1767         (write_history_p): Likewise.
1768         (info_verbose): Likewise.
1769         * top.h (confirm): Likewise.
1770         (history_expansion_p): Likewise.
1771         * tracepoint.c (disconnected_tracing): Likewise.
1772         (circular_trace_buffer): Likewise.
1773         * typeprint.c (print_methods): Likewise.
1774         (print_typedefs): Likewise.
1775         * utils.c (debug_timestamp): Likewise.
1776         (sevenbit_strings): Likewise.
1777         (pagination_enabled): Likewise.
1778         * utils.h (sevenbit_strings): Likewise.
1779         (pagination_enabled): Likewise.
1780         * valops.c (overload_resolution): Likewise.
1781         * valprint.h (struct value_print_options) <prettyformat_arrays,
1782         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1783         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1784         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1785         Likewise.
1786         * windows-nat.c (new_console): Likewise.
1787         (cygwin_exceptions): Likewise.
1788         (new_group): Likewise.
1789         (debug_exec): Likewise.
1790         (debug_events): Likewise.
1791         (debug_memory): Likewise.
1792         (debug_exceptions): Likewise.
1793         (useshell): Likewise.
1794         * windows-tdep.c (maint_display_all_tib): Likewise.
1795         * xml-support.c (debug_xml): Likewise.
1796
1797 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1798
1799         * source.c (prepare_path_for_appending): New function.
1800         (openp): Make use of new function.
1801         (find_and_open_source): Search for the compilation directory and
1802         source file as a relative path beneath the directory search path.
1803
1804 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * source-cache.c (source_cache::get_line_charpos): Catch
1807         exceptions and return false, this matches the behaviour documented
1808         in the header file.
1809
1810 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1811
1812         * ada-tasks.c (info_task): Remove quoting of the task's name.
1813
1814 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1815
1816         * symfile.c (auto_solib_add): Replace comment with a reference
1817         to the header file.
1818
1819 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1820
1821         * NEWS: Mention that gdb can now be compiled with Python 3
1822         on Windows.
1823
1824 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * maint.c (maint_print_section_data::maint_print_section_data):
1827         Force use of 'float log10 (float)' by casting the argument to
1828         float.
1829
1830 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * maint.c: Add 'cmath' include.
1833         (struct maint_print_section_data): New structure.
1834         (print_section_index): New function.
1835         (print_bfd_section_info): Add header comment, small whitespace
1836         cleanup, and update to call new print_section_index function.
1837         (print_objfile_section_info): Likewise.
1838         (maint_obj_section_from_bfd_section): New function.
1839         (print_bfd_section_info_maybe_relocated): New function.
1840         (maintenance_info_sections): Add header comment, always use
1841         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1842
1843 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1846         inner scope, add check that the objfile has psymtabs before
1847         checking psymtabs_addrmap.
1848         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1849
1850 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * NEWS: Announce that Ada task names are now shown at more places,
1853         and between quotes (except in info task output).
1854         * gdb/ada-tasks.c (task_to_str): New function.
1855         (display_current_task_id): Call task_to_str.
1856         (task_command_1): Likewise.
1857         (print_ada_task_info): In non-mi mode, Properly align headers and data
1858         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1859
1860 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1861
1862         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1863         prstatus.pr_lwp.pr_info instead of making it up.
1864
1865 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1866
1867         * auto-load.c (auto_load_expand_dir_vars): Update.
1868         * defs.h (gdb_datadir): Change to std::string.
1869         (python_libdir): Likewise.
1870         (relocate_gdb_directory): Change return type to std::string.
1871         * guile/guile.c (gdbscm_data_directory): Update.
1872         (initialize_scheme_side): Update.
1873         * jit.c (jit_reader_dir): Change to std::string.
1874         (jit_reader_load_command): Update.
1875         * main.c (gdb_datadir): Change to std::string.
1876         (python_libdir): Likewise.
1877         (set_gdb_data_directory): Update.
1878         (relocate_path): Change to return std::string.
1879         (relocate_gdb_directory): Change to return std::string.
1880         (relocate_gdbinit_path_maybe_in_datadir): Update.
1881         (captured_main_1): Update.
1882         * python/python.c (do_start_initialization): Update.
1883         * top.c (show_gdb_datadir): Update.
1884         * xml-syscall.c (xml_init_syscalls_info): Update.
1885         (init_syscalls_info): Update.
1886
1887 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1888
1889         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1890         out of get_init_files.
1891         (get_init_files): Update.
1892
1893 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1894
1895         * main.c (get_init_files): Change to use std::string.
1896         (captured_main_1): Update.
1897         (print_gdb_help): Update.
1898
1899 2019-09-11  Ali Tamur  <tamur@google.com>
1900
1901         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1902         implementation.
1903
1904 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1905
1906         * dbxread.c (read_dbx_symtab): Update.
1907         * dwarf2read.c (load_partial_dies): Update.
1908         * mdebugread.c (parse_partial_symbols): Update.
1909         (handle_psymbol_enumerators): Update.
1910         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1911         * psymtab.c (add_psymbol_to_bcache): Likewise.
1912         (add_psymbol_to_list): Likewise.
1913         * symtab.c (symbol_set_names): Likewise.
1914         * symtab.h (symbol_set_names): Likewise.
1915         * xcoffread.c (scan_xcoff_symtab): Update.
1916
1917 2019-09-11  Tom Tromey  <tom@tromey.com>
1918
1919         * symfile-mem.c (symbol_file_add_from_memory): Use
1920         bfd_set_filename.
1921         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1922         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1923
1924 2019-09-10  Tom Tromey  <tromey@adacore.com>
1925
1926         * dwarf-index-write.c (write_psymbols): Extend error message.
1927         (debug_names::insert): Add Ada code.
1928         (debug_names::write_psymbols): Remove Ada check.
1929         (debug_names) <m_string_obstack>: New member.
1930         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1931         (gdb_index_symbol_name_matcher::matches): Remove.
1932         (mapped_index_base::find_name_components_bounds): Add "lang"
1933         parameter.
1934         (mapped_index_base::build_name_components): Also split names
1935         according to Ada syntax.
1936         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1937         type of "match_callback".
1938         (check_match, check_find_bounds_finds)
1939         (dw2_expand_symtabs_matching): Update.
1940         (dw2_debug_names_iterator): Add new constructor.
1941         (dw2_debug_names_map_matching_symbols): New function.
1942         (dw2_debug_names_expand_symtabs_matching): Update.
1943         (dwarf2_debug_names_functions): Use
1944         dw2_debug_names_map_matching_symbols.
1945
1946 2019-09-10  Tom Tromey  <tromey@adacore.com>
1947
1948         * dwarf2read.c (dw2_get_file_names_reader): Add the
1949         CU's file name to the results.
1950
1951 2019-09-10  Tom Tromey  <tromey@adacore.com>
1952
1953         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1954         map_matching_symbols.  Update.
1955         * dwarf2read.c (dw2_map_matching_symbols): Update.
1956         * psymtab.c (match_partial_symbol): Change type; update.
1957         (psym_map_matching_symbols): Likewise.
1958         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1959         type; update.
1960         * symfile.h (struct quick_symbol_functions)
1961         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1962         Remove "match".
1963
1964 2019-09-10  Tom Tromey  <tromey@adacore.com>
1965
1966         * psymtab.c (map_block): Remove.
1967         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1968         * symtab.c (iterate_over_symbols_terminated): New function.
1969         * symtab.c (iterate_over_symbols_terminated): Declare.
1970
1971 2019-09-10  Tom Tromey  <tromey@adacore.com>
1972
1973         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1974         * language.h (struct language_defn) <la_iterate_over_symbols>:
1975         Return bool.
1976         * symtab.c (iterate_over_symbols): Return bool.
1977         * symtab.h (iterate_over_symbols): Return bool.
1978
1979 2019-09-10  Tom Tromey  <tromey@adacore.com>
1980
1981         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1982         (add_nonlocal_symbols): Update.
1983         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1984         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1985         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1986         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1987         Change type of "callback".  Remove "data".
1988
1989
1990 2019-09-09  Ali Tamur  <tamur@google.com>
1991
1992         * dwarf2read.c (comp_unit_head): Update comment.
1993         (dwarf2_dwo_name): New function declaration.
1994         (dwarf_unit_type_name): New function declaration.
1995         (read_comp_unit_head): Add support for new compilation units,
1996         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1997         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1998         (currently named as "signature") in their header. Also clarify error
1999         messages.
2000         (lookup_dwo_id): New function. Returns the dwo id of the given
2001         compile unit.
2002         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2003         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2004         functions.
2005         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2006         (dwarf2_dwo_name): Get the dwo name if present.
2007         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2008         purposes.
2009
2010 2019-09-09  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2013
2014 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2015
2016         * python/python.c (do_start_initialization): Make progname_copy static,
2017         to avoid a leak report.
2018
2019 2019-09-08  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2022
2023 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2024
2025         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2026         Change type to gdb::optional<block_enum>.
2027         (dw2_symtab_iter_init): Change block_index parameter type
2028         to gdb::optional<block_enum>.
2029         (dw2_lookup_symbol): Change block_index parameter
2030         type to block_enum.c
2031         (dw2_debug_names_lookup_symbol): Likewise.
2032         * psymtab.c (psym_lookup_symbol): Likewise.
2033         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2034         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2035         Likewise.
2036
2037 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2038
2039         * defs.h (relocate_gdb_directory): Change int to bool in
2040         signature and rename flag to relocatable.
2041         * main.c (relocate_path): Likewise.
2042         (relocate_gdb_directory): Likewise.
2043
2044 2019-09-06  Alan Modra  <amodra@gmail.com>
2045
2046         * coffread.c (coff_symfile_read): Constify filename variable.
2047         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2048         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2049         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2050         * solib.c (reload_shared_libraries_1): Likewise.
2051         * symfile.c (reread_symbols): Likewise.
2052         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2053         * solib-darwin.c (darwin_bfd_open): Likewise.
2054         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2055
2056 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2059         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2060
2061 2019-09-03  Tom Tromey  <tromey@adacore.com>
2062
2063         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2064         types.
2065         (has_negatives): Unbias a range type bound.
2066         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2067         * gdbtypes.c (operator==): Handle new field.
2068         (create_range_type): Add "bias" parameter.
2069         (create_static_range_type, resolve_dynamic_range): Update.
2070         * gdbtypes.h (struct range_bounds) <bias>: New member.
2071         (create_range_type): Add bias parameter.
2072         * printcmd.c (print_scalar_formatted): Unbias range types.
2073         * value.c (unpack_long): Unbias range types.
2074         (pack_long): Bias range types.
2075
2076 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2077
2078         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2079         probe arguments.
2080
2081 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2082
2083         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2084         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2085         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2086         (compile_probe_arg): Likewise.
2087         * probe.h (get_argument_count): Likewise.
2088         * solib-svr4.c (solib_event_probe_action): Likewise.
2089         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2090
2091 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2092
2093         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2094         code to here...
2095         (svr4_create_solib_event_breakpoints): ...from here.
2096
2097 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2098
2099         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2100         suffix from warning message.
2101
2102 2019-08-30  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-winsource.h (struct tui_source_window_base)
2105         <refresh_all>: Don't declare.
2106         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2107         Remove.
2108         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2109         tui_show_locator_content.
2110         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2111         declare.
2112         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2113         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2114         declare.
2115
2116 2019-08-30  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2119
2120 2019-08-30  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2123         Remove unnecessary forward declarations.
2124
2125 2019-08-30  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2128         rerender.
2129         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2130         tui_show_locator_content.
2131
2132 2019-08-30  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2135         (tui_locator_window::rerender): Rewrite using body of previous
2136         tui_show_locator_content.
2137
2138 2019-08-30  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2141         set_locator_fullname>: New methods.
2142         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2143         Rename from tui_set_locator_fullname.
2144         (tui_locator_window::set_locator_info): Rename from
2145         tui_set_locator_info.  Return bool.
2146         (tui_update_locator_fullname, tui_show_frame_info): Update.
2147
2148 2019-08-30  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2151
2152 2019-08-30  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2155         call touchwin.
2156
2157 2019-08-30  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-wingeneral.c (box_win): Assume win_info and
2160         win_info->handle cannot be NULL.
2161
2162 2019-08-30  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2165         refresh_window>: Declare.
2166         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2167         resize.
2168         (tui_data_item_window::rerender): Rename from
2169         tui_display_register.
2170         (tui_data_item_window::refresh_window): New method.
2171         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2172         no-op.
2173
2174 2019-08-30  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2177         regs_column_count, current_group>: Move later.  Now private.
2178         <get_current_group>: New method.
2179         * tui/tui-regs.c (tui_reg_command): Update.
2180         * tui/tui-layout.c (tui_set_layout): Update.
2181
2182 2019-08-30  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2185         (tui_data_window::rerender): Don't call
2186         check_and_display_highlight_if_needed.
2187         (tui_data_window::refresh_all): Remove call to
2188         erase_data_content.
2189
2190 2019-08-30  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2193         (tui_data_window::display_registers_from)
2194         (tui_data_window::display_reg_element_at_line)
2195         (tui_data_window::display_registers_from_line): Remove checks of
2196         "empty".
2197
2198 2019-08-30  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2201         Don't declare.
2202         * tui/tui-regs.c (tui_data_window::show_registers): Call
2203         rerender.
2204         (tui_data_window::rerender): Rename from display_all_data.
2205         (tui_data_window::rerender): Remove old implementation.
2206
2207 2019-08-30  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2210         text.
2211         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2212
2213 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2214             Sergio Durigan Junior  <sergiodj@redhat.com>
2215
2216         PR win32/24284
2217         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2218
2219 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2222         when searching for types.
2223
2224 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * f-lang.c (f_language_defn): Use f_print_typedef.
2227         * f-lang.h (f_print_typedef): Declare.
2228         * f-typeprint.c (f_print_typedef): Define.
2229
2230 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2231
2232         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2233
2234 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2235
2236         * cli/cli-utils.c (info_print_options_defs): Delete.
2237         (make_info_print_options_def_group): Delete.
2238         (extract_info_print_options): Delete.
2239         (info_print_command_completer): Delete.
2240         (info_print_args_help): Add extra parameter, and optionally
2241         include text about -n flag.
2242         * cli/cli-utils.h (struct info_print_options): Delete.
2243         (extract_info_print_options): Delete declaration.
2244         (info_print_command_completer): Delete declaration.
2245         (info_print_args_help): Add extra parameter, extend header
2246         comment.
2247         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2248         search_symbols.
2249         * stack.c (struct info_print_options): New type.
2250         (info_print_options_defs): New file scoped variable.
2251         (make_info_print_options_def_group): New static function.
2252         (info_print_command_completer): New static function.
2253         (info_locals_command): Update to use new local functions.
2254         (info_args_command): Likewise.
2255         (_initialize_stack): Add extra parameter to calls to
2256         info_print_args_help.
2257         * symtab.c (search_symbols): Add extra parameter, use this to
2258         possibly excluse non-debug symbols.
2259         (symtab_symbol_info): Add extra parameter, which is passed on to
2260         search_symbols.
2261         (struct info_print_options): New type.
2262         (info_print_options_defs): New file scoped variable.
2263         (make_info_print_options_def_group): New static function.
2264         (info_print_command_completer): New static function.
2265         (info_variables_command): Update to use local functions, and pass
2266         extra parameter through to symtab_symbol_info.
2267         (info_functions_command): Likewise.
2268         (info_types_command): Pass additional argument through to
2269         symtab_symbol_info.
2270         (rbreak_command): Pass extra argument to search_symbols.
2271         (_initialize_symtab): Add extra arguments for calls to
2272         info_print_args_help, and update help text for 'info variables',
2273         'whereis', and 'info functions' commands.
2274         * symtab.h (search_symbols): Add extra argument to declaration.
2275         * NEWS: Mention new flags.
2276
2277 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2278
2279         * symtab.c (lookup_static_symbol): Call the new function (and move
2280         it down to be next to lookup_global_symbol).
2281         (struct global_sym_lookup_data): Add block_enum member and rename to...
2282         (struct global_or_static_sym_lookup_data): ...this.
2283         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2284         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2285         (lookup_symbol_global_or_static_iterator_cb): ...this.
2286         (lookup_global_or_static_symbol): New function.
2287         (lookup_global_symbol): Call new function.
2288
2289 2019-08-26  Tom de Vries  <tdevries@suse.de>
2290
2291         PR c++/24852
2292         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2293         when pc_probe.prob == NULL.
2294
2295 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2296
2297         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2298         variable symbol_linkage to symbol_linkage_.
2299
2300 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2301
2302         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2303         represent whether the symbol is static, dynamic, or we don't
2304         know.
2305
2306 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2307
2308         * gdb/rx-tdep.c (rx_register_names): New.
2309         (rx_register_name): Delete.
2310         (rx_psw_type): Delete.
2311         (rx_fpsw_type): Delete.
2312         (rx_register_type): Delete.
2313         (rx_gdbarch_init): Convert target-descriptions.
2314         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2315         * gdb/features/Makefile: Add rx.xml.
2316         * gdb/features/rx.xml: New.
2317         * gdb/features/rx.c: Generated.
2318         * gdb/NEWS: Mention target description support.
2319
2320 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2323         *slot_ptr.
2324
2325 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2326
2327         * configure.ac: Don't check for 'dlfcn.h' (moved to
2328         gdbsupport/common.m4).
2329         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2330         'gdbsupport/'.
2331         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2332         * compile/compile-c-support.c: Include
2333         'gdbsupport/gdb-dlfcn.h'.
2334         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2335         * gdb-dlfcn.c: Move to...
2336         * gdbsupport/gdb-dlfcn.c: ... here.
2337         * gdb-dlfcn.h: Move to...
2338         * gdbsupport/gdb-dlfcn.h: ... here.
2339
2340 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2341
2342         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2343         the offset field signed.
2344
2345 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2346
2347         * python/lib/gdb/__init__.py (_execute_file): New function.
2348         * python/python.c (python_run_simple_file): Call gdb._execute_file
2349         on Windows.
2350
2351 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2354         all uses as this was never set to anything but a zero value.
2355
2356 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2357
2358         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2359
2360 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2361
2362         * tui/tui-data.h (tui_gen_win_info): Add an =default
2363         move constructor, required by some GCC versions.
2364
2365 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2366
2367         * go32-nat.c (go32_sysinfo): Add hygon_p.
2368
2369 2019-08-20  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2372         line_from_reg_element_no, first_reg_element_no_inline,
2373         display_all_data, delete_data_content_windows,
2374         erase_data_content>: Now private.
2375
2376 2019-08-20  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2379         (tui_unhighlight_win, tui_highlight_win)
2380         (tui_win_info::make_window): Update.
2381         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2382
2383 2019-08-20  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2386         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2387         (MAX_PID_WIDTH): Move to tui-stack.c.
2388         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2389         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2390         (MAX_PID_WIDTH): Move from tui-data.h.
2391
2392 2019-08-20  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2395         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2396         (box_win): Update.
2397         (tui_gen_win_info::make_window): Rename from tui_make_window.
2398         (tui_win_info::make_window): New method.
2399         (tui_gen_win_info::make_visible): Update.
2400         * tui/tui-source.c (tui_source_window::set_contents): Update.
2401         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2402         (tui_data_window::display_registers_from): Update.
2403         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2404         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2405         Declare.
2406         <can_box>: Remove.
2407         <title>: Remove.
2408         (struct tui_win_info) <make_window>: Declare.
2409         <can_box>: Now virtual.
2410         <title>: New member.
2411         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2412         * tui/tui-command.c (tui_cmd_window::resize): Update.
2413
2414 2019-08-20  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2417         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2418         (tui_data_window::check_register_values): Update.
2419
2420 2019-08-20  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-regs.h (struct tui_data_window): Use
2423         DISABLE_COPY_AND_ASSIGN.
2424         <regs_content>: Change type, removing unique_ptr.
2425         <tui_data_window>: Add move constructor.
2426         * tui/tui-regs.c (tui_data_window::show_registers)
2427         (tui_data_window::show_register_group)
2428         (tui_data_window::display_registers_from)
2429         (tui_data_window::display_registers_from)
2430         (tui_data_window::first_data_item_displayed)
2431         (tui_data_window::delete_data_content_windows)
2432         (tui_data_window::rerender, tui_data_window::refresh_window)
2433         (tui_data_window::check_register_values): Update.
2434
2435 2019-08-20  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2438         show_register_group>: Declare.
2439         (tui_show_register_group): Don't declare.
2440         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2441         tui_show_registers.
2442         (tui_data_window::show_register_group): Rename from
2443         tui_show_register_group.
2444         (tui_data_window::check_register_values, tui_reg_command):
2445         Update.
2446         * tui/tui-layout.c (tui_set_layout): Update.
2447
2448 2019-08-20  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2451         Declare.
2452         (tui_check_register_values): Don't declare.
2453         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2454         from tui_check_register_values.
2455         * tui/tui-hooks.c (tui_register_changed): Update.
2456
2457 2019-08-20  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-regs.c (tui_reg_layout): Move later.
2460         (tui_show_registers): Don't enable TUI mode or change layout.
2461
2462 2019-08-20  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-regs.h (struct tui_data_item_window)
2465         <~tui_data_item_window>: Remove.
2466         <content>: Now a unique_xmalloc_ptr.
2467         * tui/tui-regs.c (tui_register_format): Return a
2468         unique_xmalloc_ptr.
2469         (tui_get_register): Update.
2470         (~tui_data_item_window): Remove.
2471         (tui_data_window::display_registers_from, tui_display_register):
2472         Update.
2473         * tui/tui-io.h (tui_expand_tabs): Update.
2474         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2475         Remove "col" parameter.
2476
2477 2019-08-20  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2480         field.
2481         * tui/tui-regs.c (~tui_data_item_window): Update.
2482
2483 2019-08-20  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2486         earlier.
2487
2488 2019-08-20  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2491
2492 2019-08-20  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-source.h (struct tui_source_window): Update.
2495         * tui/tui-regs.c (tui_show_registers): Update.
2496         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2497         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2498         (NO_REGS_STRING): Remove defines.
2499
2500 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2501
2502         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2503         unnecessary thread walk if remote doesn't support the packet.
2504
2505 2019-08-19  Tom Tromey  <tromey@adacore.com>
2506
2507         * python/py-value.c (value_has_field): Fix indentation.
2508
2509 2019-08-19  Tom Tromey  <tromey@adacore.com>
2510
2511         * printcmd.c (do_one_display, info_display_command): Update.
2512         * block.h (contained_in): Return bool.  Add allow_nested
2513         parameter.
2514         * block.c (contained_in): Return bool.  Add allow_nested
2515         parameter.
2516
2517 2019-08-19  Tom Tromey  <tom@tromey.com>
2518
2519         * configure: Rebuild.
2520         * configure.ac: Disallow the combination of -static-libstdc++ and
2521         source highlight.
2522         * source-cache.c (get_language_name): Handle rust.
2523         (source_cache::get_source_lines): Ignore highlighting exceptions.
2524
2525 2019-08-16  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2528         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2529         (struct tui_source_window_base) <make_visible, refresh_window,
2530         resize>: Remove methods.
2531         <execution_info>: Remove field.
2532         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2533         (tui_show_source_line, tui_source_window_base)
2534         (~tui_source_window_base): Update.
2535         (tui_source_window_base::resize)
2536         (tui_source_window_base::make_visible)
2537         (tui_source_window_base::refresh_window): Remove.
2538         (tui_source_window_base::update_exec_info): Update.
2539         * tui/tui-source.c (tui_source_window::set_contents): Update.
2540         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2541
2542 2019-08-16  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2545         deprecated_query_hook.
2546
2547 2019-08-16  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2550         (tui_update_source_windows_with_line): Update.
2551         * tui/tui-source.h (struct tui_source_window)
2552         <show_symtab_source>: Declare.
2553         (tui_show_symtab_source): Don't declare.
2554         * tui/tui-source.c (tui_show_symtab_source): Rename from
2555         tui_show_symtab_source.
2556
2557 2019-08-16  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-winsource.h (struct tui_source_window_base)
2560         <set_contents>: Declare.
2561         * tui/tui-winsource.c
2562         (tui_source_window_base::update_source_window_as_is): Update.
2563         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2564         Declare.
2565         (tui_set_source_content): Don't declare.
2566         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2567         tui_set_source_content.
2568         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2569         Declare.
2570         (tui_set_disassem_content): Don't declare.
2571         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2572         tui_set_disassem_content.
2573
2574 2019-08-16  Tom Tromey  <tom@tromey.com>
2575
2576         * tui/tui-winsource.h (struct tui_source_window_base)
2577         <update_breakpoint_info>: Declare.
2578         (tui_update_breakpoint_info): Don't declare.
2579         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2580         (tui_update_all_breakpoint_info): Update.
2581         (tui_source_window_base::update_breakpoint_info): Rename from
2582         tui_update_breakpoint_info.
2583         (tui_source_window_base::update_exec_info): Update.
2584
2585 2019-08-16  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-winsource.h (struct tui_source_window_base)
2588         <update_source_window>: Declare.
2589         (tui_update_source_window): Don't declare.
2590         * tui/tui-winsource.c
2591         (tui_source_window_base::update_source_window): Rename from
2592         tui_update_source_window.
2593         (tui_source_window_base::rerender): Update.
2594         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2595         * tui/tui-disasm.c (tui_show_disassem)
2596         (tui_show_disassem_and_update_source)
2597         (tui_disasm_window::maybe_update): Update.
2598
2599 2019-08-16  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-winsource.h (struct tui_source_window_base)
2602         <update_source_window_as_is>: Declare.
2603         (tui_update_source_window_as_is): Don't declare.
2604         * tui/tui-winsource.c (tui_update_source_window): Update
2605         (tui_source_window_base::update_source_window_as_is): Rename from
2606         tui_update_source_window_as_is.
2607         (tui_source_window_base::refill): Update.
2608         * tui/tui-source.c (tui_show_symtab_source): Update.
2609         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2610         Update.
2611
2612 2019-08-16  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-winsource.h (tui_update_source_window)
2615         (tui_update_source_window_as_is): Remove "noerror" parameter.
2616         * tui/tui-winsource.c (tui_update_source_window)
2617         (tui_update_source_window_as_is): Remove "noerror" parameter.
2618         (tui_update_source_windows_with_addr)
2619         (tui_update_source_windows_with_line)
2620         (tui_source_window_base::rerender)
2621         (tui_source_window_base::refill): Update.
2622         * tui/tui-source.h (tui_set_source_content)
2623         (tui_show_symtab_source): Remove "noerror" parameter.
2624         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2625         parameter.
2626         (tui_show_symtab_source): Likewise.
2627         (tui_source_window::maybe_update): Update.
2628         * tui/tui-disasm.c (tui_show_disassem)
2629         (tui_show_disassem_and_update_source)
2630         (tui_disasm_window::do_scroll_vertical)
2631         (tui_disasm_window::maybe_update): Update.
2632
2633 2019-08-16  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui.c (tui_is_window_visible): Update.
2636         * tui/tui-wingeneral.c (tui_make_window)
2637         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2638         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2639         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2640         (tui_set_win_height_command, parse_scrolling_args): Update.
2641         * tui/tui-source.c (tui_source_window::style_changed): Update.
2642         * tui/tui-regs.c (tui_show_registers)
2643         (tui_data_window::first_data_item_displayed)
2644         (tui_data_window::delete_data_content_windows)
2645         (tui_check_register_values, tui_reg_command): Update.
2646         * tui/tui-disasm.c (tui_show_disassem): Update.
2647         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2648         method.
2649         <is_visible>: Remove field.
2650         * tui/tui-data.c (tui_next_win, tui_prev_win)
2651         (tui_delete_invisible_windows): Update.
2652
2653 2019-08-16  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-winsource.h (struct tui_source_window_base)
2656         <m_has_locator>: Remove.
2657         * tui/tui-layout.c (show_source_disasm_command, show_data)
2658         (show_source_or_disasm_and_command): Update.
2659
2660 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * NEWS (Other MI changes): New subsection.
2663         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2664         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2665         * arch-utils.c (default_get_pc_address_flags): New function.
2666         * arch-utils.h (default_get_pc_address_flags): New declaration.
2667         * gdbarch.sh: Add get_pc_address_flags.
2668         * gdbarch.c: Regenerate.
2669         * gdbarch.h: Likewise.
2670         * stack.c (print_pc): New function.
2671         (print_frame_info) (print_frame): Call print_pc.
2672
2673 2019-08-16  Tom de Vries  <tdevries@suse.de>
2674
2675         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2676         print_objfile_section_info.
2677
2678 2019-08-15  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2681         calling update_cmdwin_start_line.
2682         * tui/tui-winsource.h (struct tui_source_window_base)
2683         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2684         <rerender>: Declare.
2685         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2686         Call rerender.
2687         (tui_source_window_base::set_new_height): Remove.
2688         (tui_source_window_base::rerender): Rename from
2689         do_make_visible_with_new_height.
2690         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2691         resize method.
2692         (tui_win_info::make_invisible_and_set_new_height)
2693         (tui_win_info::make_visible_with_new_height): Remove.
2694         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2695         Declare.
2696         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2697         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2698         do_make_visible_with_new_height>: Don't declare.
2699         <rerender>: Declare.
2700         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2701         set_new_height.
2702         (tui_data_window::do_make_visible_with_new_height): Remove.
2703         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2704         call tui_show_locator_content.
2705         (tui_gen_win_info::resize): Call rerender.
2706         (show_source_or_disasm_and_command): Don't call
2707         tui_show_locator_content.
2708         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2709         method.
2710         (struct tui_win_info) <rerender>: Declare.
2711         <set_new_height, make_invisible_and_set_new_height,
2712         make_visible_with_new_height>: Don't declare.
2713         * tui/tui-data.c (tui_win_list::rerender): New method.
2714         * tui/tui-command.h (struct tui_cmd_window)
2715         <do_make_visible_with_new_height>: Don't declare.
2716         * tui/tui-command.c
2717         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2718
2719 2019-08-15  Tom Tromey  <tromey@adacore.com>
2720
2721         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2722         * ada-lang.c (ada_enum_name): Likewise.
2723
2724 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2725
2726         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2727         leading underscore.
2728         (GdbOutputErrorFile): Likewise.
2729         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2730         accordingly.
2731         (execute_unwinders): Rename to have a leading underscore.
2732         (auto_load_packages): Likewise.
2733         (global scope): Adjust call to auto_load_packages accordingly.
2734         (GdbSetPythonDirectory): Likewise.
2735         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2736         instead of execute_unwinders.
2737
2738 2019-08-15  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2741         (show_data): Don't change window visibility.
2742         (tui_gen_win_info::resize): Remove special case for command
2743         window.  Use wresize, when available.
2744         (show_source_or_disasm_and_command): Don't change window
2745         visibility.
2746         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2747         <make_visible>: New method.
2748         * tui/tui-command.c (tui_cmd_window::resize): New method.
2749
2750 2019-08-15  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2753         (struct tui_source_windows): New.
2754         * tui/tui-winsource.c (tui_display_main): Update.
2755         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2756         (new_height_ok, parse_scrolling_args): Update.
2757         * tui/tui-layout.c (show_layout, show_data): Update.
2758         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2759         (tui_add_to_source_windows): Don't declare.
2760         * tui/tui-data.c (source_windows, tui_source_windows)
2761         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2762
2763 2019-08-15  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2766         Rename from reset.
2767         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2768         * tui/tui-layout.c (show_source_disasm_command, show_data):
2769         Update.
2770         (tui_gen_win_info::resize): Rename.
2771         (show_source_or_disasm_and_command): Update.
2772         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2773         reset.
2774
2775 2019-08-15  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2778         * tui/tui-interp.c (tui_interp::init): Don't call
2779         tui_initialize_static_data.
2780         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2781
2782 2019-08-15  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2785         examine tui_win_list.
2786
2787 2019-08-15  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2790         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2791         tui_clear_source_content.
2792         (tui_clear_source_content): Remove.
2793         (tui_source_window_base::do_erase_source_content): Hoist call to
2794         content.clear().
2795         * tui/tui-stack.c (tui_show_frame_info): Don't call
2796         tui_clear_source_content.
2797
2798 2019-08-15  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-winsource.h (struct tui_source_window_base)
2801         <do_erase_source_content>: New method.
2802         <erase_source_content>: New method.
2803         (tui_erase_source_content): Don't declare.
2804         * tui/tui-winsource.c (tui_clear_source_content): Update.
2805         (tui_source_window_base::do_erase_source_content): Rename from
2806         tui_erase_source_content.
2807         (tui_source_window_base::show_source_content): Update.
2808         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2809         * tui/tui-source.h (struct tui_source_window)
2810         <erase_source_content>: New method.
2811         * tui/tui-disasm.h (struct tui_disasm_window)
2812         <erase_source_content>: New method.
2813
2814 2019-08-15  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2817         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2818         constructor.
2819         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2820         * tui/tui-source.c (tui_set_source_content): Update.
2821         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2822
2823 2019-08-15  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2826         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2827         tui-source.c.
2828         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2829         Declare.
2830         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2831         method.
2832         (tui_source_window::maybe_update): Update.
2833
2834 2019-08-15  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2837         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2838         tui-disasm.c.
2839         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2840         Declare.
2841         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2842         method.
2843         (tui_disasm_window::maybe_update): Update.
2844
2845 2019-08-15  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-winsource.h (struct tui_source_window_base)
2848         <maybe_update>: Declare.
2849         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2850         method.
2851         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2852         Declare.
2853         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2854         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2855         Declare.
2856         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2857
2858 2019-08-15  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2861
2862 2019-08-15  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-wingeneral.c: Include tui-stack.h.
2865         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2866         (struct tui_locator_window): Move from tui-data.h.
2867         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2868         (tui_initialize_static_data): Move from tui-data.c.
2869         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2870         (struct tui_locator_window): Move to tui-stack.c.
2871         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2872         (tui_initialize_static_data): Move to tui-stack.c.
2873
2874 2019-08-15  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-layout.c (show_source_disasm_command)
2877         (show_source_or_disasm_and_command): Use make_visible method, not
2878         tui_make_window.
2879         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2880         Remove.
2881
2882 2019-08-15  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-wingeneral.h (tui_make_window): Update.
2885         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2886         parameter.
2887         (tui_gen_win_info::make_visible): Update.
2888         * tui/tui-regs.c (tui_data_window::display_registers_from):
2889         Update.
2890         * tui/tui-layout.c (show_source_disasm_command)
2891         (show_source_or_disasm_and_command): Update.
2892         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2893         (enum tui_box): Remove.
2894         (struct tui_win_info) <can_box>: New method.
2895         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2896         method.
2897
2898 2019-08-15  Tom de Vries  <tdevries@suse.de>
2899
2900         * linux-nat-trad.c: Include gdbarch.h.
2901
2902 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2905         register sizes.
2906
2907 2019-08-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * darwin-nat.c: Include gdbarch.h.
2910         * darwin-nat-info.c: Include gdbarch.h.
2911
2912 2019-08-13  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2915         Remove.
2916         * tui/tui-data.c (tui_initialize_static_data): Update.
2917
2918 2019-08-13  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-winsource.h (struct tui_exec_info_window)
2921         <~tui_exec_info_window, maybe_allocate_content, get_content,
2922         m_content>: Remove.
2923         (struct tui_source_window_base) <set_exec_info_content,
2924         show_exec_info_content>: Don't declare.
2925         * tui/tui-winsource.c
2926         (tui_exec_info_window::maybe_allocate_content): Remove.
2927         (tui_source_window_base::update_exec_info): Rename from
2928         set_exec_info_content.
2929         (tui_source_window_base::show_exec_info_content)
2930         (tui_source_window_base::update_exec_info): Remove.
2931
2932 2019-08-13  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2935         declare.
2936         * tui/tui-winsource.c (tui_update_source_window_as_is)
2937         (tui_update_source_windows_with_addr, tui_erase_source_content):
2938         Update.
2939         (tui_clear_exec_info_content): Remove.
2940
2941 2019-08-13  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2944         declare.
2945         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2946         call tui_erase_exec_info_content.
2947         (tui_clear_exec_info_content): Rename from
2948         tui_erase_exec_info_content.
2949         (tui_clear_exec_info_content): Delete.
2950
2951 2019-08-13  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-winsource.h (struct tui_source_window_base)
2954         <show_exec_info_content>: Declare.
2955         (tui_show_exec_info_content): Don't declare.
2956         * tui/tui-winsource.c
2957         (tui_source_window_base::show_exec_info_content): Rename from
2958         tui_show_exec_info_content.
2959         (tui_source_window_base::update_exec_info): Update.
2960
2961 2019-08-13  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2964         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2965         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2966         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2967         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2968         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2969         ... here.
2970
2971 2019-08-13  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-winsource.h (struct tui_source_window_base)
2974         <update_exec_info>: Declare.
2975         (tui_update_exec_info): Don't declare.
2976         * tui/tui-winsource.c (tui_update_source_window_as_is)
2977         (tui_source_window_base::refresh_all)
2978         (tui_update_all_breakpoint_info): Update.
2979         (tui_source_window_base::update_exec_info): Rename from
2980         tui_update_exec_info.
2981         * tui/tui-stack.c (tui_show_frame_info): Update.
2982
2983 2019-08-13  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-winsource.h (struct tui_source_window_base)
2986         <set_exec_info_content>: Declare.
2987         (tui_set_exec_info_content): Don't declare.
2988         * tui/tui-winsource.c
2989         (tui_source_window_base::set_exec_info_content): Rename from
2990         tui_set_exec_info_content.
2991         (tui_update_exec_info): Update.
2992
2993 2019-08-13  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-winsource.h (struct tui_source_window_base)
2996         <show_source_content>: Declare.
2997         (tui_show_source_content): Don't declare.
2998         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2999         (tui_source_window_base::show_source_content): Rename from
3000         tui_show_source_content.
3001         (tui_source_window_base::refresh_all): Update.
3002         * tui/tui-layout.c (show_source_disasm_command)
3003         (show_source_or_disasm_and_command): Update.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-winsource.c (tui_erase_source_content)
3008         (tui_show_source_content, tui_source_window_base::refresh_all):
3009         Update.
3010         * tui/tui-wingeneral.h
3011         (tui_check_and_display_highlight_if_needed): Don't declare.
3012         * tui/tui-wingeneral.c
3013         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3014         check_and_display_highlight_if_needed.
3015         * tui/tui-win.c (tui_rehighlight_all)
3016         (tui_win_info::make_visible_with_new_height): Update.
3017         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3018         (tui_data_window::erase_data_content)
3019         (tui_data_window::display_all_data): Update.
3020         * tui/tui-data.h (struct tui_win_info)
3021         <check_and_display_highlight_if_needed>: Declare.
3022
3023 2019-08-13  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-win.c (tui_resize_all): Call
3026         tui_delete_invisible_windows.
3027         * tui/tui-layout.c (show_layout): Call
3028         tui_delete_invisible_windows.
3029         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3030         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3031
3032 2019-08-13  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3035         tui_add_win_to_layout.
3036
3037 2019-08-13  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3040         * tui/tui-layout.c (tui_default_win_height): Now static.
3041
3042 2019-08-13  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3045         single switch.
3046         (show_source_disasm_command, show_source_or_disasm_and_command):
3047         Don't check current layout.
3048
3049 2019-08-13  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-wingeneral.c (make_all_visible): Remove.
3052         (tui_make_all_invisible): Simplify.
3053         * tui/tui-layout.c (tui_make_all_invisible): Move from
3054         tui-wingeneral.c; simplify.
3055         (show_layout): Hoist call to tui_make_all_invisible.
3056         (show_data): Don't call tui_make_all_invisible.
3057
3058 2019-08-13  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3061         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3062
3063 2019-08-13  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3066         tui-data.c.
3067         (show_source_disasm_command, show_data)
3068         (show_source_or_disasm_and_command): Don't use
3069         tui_set_current_layout_to.
3070         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3071         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3072         tui-layout.c.
3073         (tui_set_current_layout_to): Remove.
3074
3075 2019-08-13  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-layout.c (tui_set_layout): Update.
3078         * tui/tui-data.h (struct tui_layout_def): Remove.
3079         (tui_layout_def): Don't declare.
3080         * tui/tui-data.c (layout_def): Remove.
3081         (tui_layout_def): Remove.
3082
3083 2019-08-13  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-winsource.h (struct tui_source_window_base)
3086         <clear_detail>: No longer "override".
3087         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3088         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3089         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3090         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3091         Remove.
3092         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3093
3094 2019-08-13  Tom Tromey  <tromey@adacore.com>
3095
3096         * tracepoint.c: Don't include readline.h or history.h.
3097
3098 2019-08-12  Tom Tromey  <tom@tromey.com>
3099
3100         * configure: Rebuild.
3101         * configure.ac: Check for readline 7.
3102         * NEWS: Mention readline 7 requirement.
3103         * README: Update.
3104
3105 2019-08-12  Tom Tromey  <tom@tromey.com>
3106
3107         * mingw-hdep.c (gdb_select): Remove readline hack.
3108
3109 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3110
3111         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3112         when the function fails.
3113
3114 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3115
3116         * s390-tdep.c (s390_type_align): New function.
3117         (s390_gdbarch_init): Set it as type_align gdbarch method.
3118
3119 2019-08-09  Tom de Vries  <tdevries@suse.de>
3120
3121         PR gdb/24591
3122         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3123         pc_low with relocation offset.
3124
3125 2019-08-07  Tom Tromey  <tromey@adacore.com>
3126
3127         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3128         (print_frame_args): Update.
3129         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3130         Update.
3131         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3132         * frame.h (struct frame_arg): Add initializers.
3133         <error>: Now a unique_xmalloc_ptr.
3134
3135 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3136
3137         * NEWS: Expand the Pointer Authentication entry.
3138         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3139         (aarch64_frame_unmask_lr): ... to this.
3140         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3141         Call aarch64_frame_unmask_lr.
3142         * frame.c (struct frame_info): Add "masked" variable.
3143         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3144         (fprint_frame): Check for masked pc.
3145         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3146         declarations.
3147         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3148         * stack.c (print_frame): Check for masked pc.
3149
3150 2019-08-06  Tom Tromey  <tom@tromey.com>
3151
3152         * stabsread.c (patch_block_stabs, read_one_struct_field)
3153         (read_enum_type): Use obstack_strndup.
3154         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3155         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3156         * dwarf2read.c (guess_full_die_structure_name)
3157         (anonymous_struct_prefix): Use obstack_strndup.
3158         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3159         * c-exp.y (yylex): Use obstack_strndup.
3160         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3161         (write_var_or_type): Use obstack_strndup.
3162
3163 2019-08-06  Tom Tromey  <tom@tromey.com>
3164
3165         * symfile.c (reread_symbols): Use obstack_strdup.
3166         * stabsread.c (read_type): Use obstack_strdup.
3167         * gdb_obstack.h (obstack_strdup): New overload.
3168         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3169         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3170         (dwarf2_canonicalize_name): Use obstack_strdup.
3171         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3172         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3173         Use obstack_strdup.
3174
3175 2019-08-06  Tom Tromey  <tom@tromey.com>
3176
3177         * gdb_obstack.h (obstack_strdup): Define.
3178         * gdb_obstack.c (obstack_strdup): Don't define.
3179
3180 2019-08-06  Tom Tromey  <tom@tromey.com>
3181
3182         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3183         obstack_strdup.
3184         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3185         obstack_strdup.
3186         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3187         * stabsread.c (common_block_start): Use obstack_strdup.
3188         * objfiles.c (set_objfile_main_name, objfile): Use
3189         obstack_strdup.
3190         * namespace.c (add_using_directive): Use obstack_strdup.
3191         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3192         * jit.c (finalize_symtab): Use obstack_strdup.
3193         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3194         (guess_partial_die_structure_name, partial_die_info::fixup)
3195         (dwarf2_name): Use obstack_strdup.
3196         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3197         obstack_strdup.
3198         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3199         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3200         obstack_strdup.
3201         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3202
3203 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3204
3205         * unittests/help-doc-selftests.c: New file.
3206         * Makefile.in: Add the new file.
3207
3208 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3209
3210         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3211         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3212         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3213         the trailing '.' is not output, and the first character is uppercased.
3214         (print_help_for_command): Update call to print_doc_line.
3215         (print_doc_of_command): Likewise.
3216         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3217         * cli/cli-option.c (append_indented_doc): Do not append newline.
3218         (build_help_option): Append newline after first appended_indented_doc
3219         only if a second call is done.
3220         (build_help): Append 2 new lines before each option, except the first
3221         one.
3222         * compile/compile.c (_initialize_compile): Add new lines after
3223         %OPTIONS%, when not at the end of the help.
3224         Change help doc or code
3225         producing the help doc to respect the invariants.
3226         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3227         Also removed the new line after 'Options:', as all other commands
3228         do not put an empty line between 'Options:' and the first option.
3229         * printcmd.c (_initialize_printcmd): Likewise.
3230         * stack.c (_initialize_stack): Likewise.
3231         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3232         incorrectly telling COMMAND is optional.
3233         * ada-lang.c (_initialize_ada_language): Change help doc or code
3234         producing the help doc to respect the invariants.
3235         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3236         * breakpoint.c (_initialize_breakpoint): Likewise.
3237         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3238         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3239         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3240         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3241         _initialize_cli_style): Likewise.
3242         * corelow.c (core_target_info): Likewise.
3243         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3244         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3245         * filesystem.c (_initialize_filesystem): Likewise.
3246         * frame.c (_initialize_frame): Likewise.
3247         * gnu-nat.c (add_task_commands): Likewise.
3248         * infcall.c (_initialize_infcall): Likewise.
3249         * infcmd.c (_initialize_infcmd): Likewise.
3250         * interps.c (_initialize_interpreter): Likewise.
3251         * language.c (_initialize_language): Likewise.
3252         * linux-fork.c (_initialize_linux_fork): Likewise.
3253         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3254         * maint.c (_initialize_maint_cmds): Likewise.
3255         * memattr.c (_initialize_mem): Likewise.
3256         * printcmd.c (_initialize_printcmd): Likewise.
3257         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3258         _RegEx): Likewise.
3259         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3260         * record-btrace.c (_initialize_record_btrace): Likewise.
3261         * record-full.c (_initialize_record_full): Likewise.
3262         * record.c (_initialize_record): Likewise.
3263         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3264         * regcache.c (_initialize_regcache): Likewise.
3265         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3266         _initialize_remote): Likewise.
3267         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3268         * serial.c (_initialize_serial): Likewise.
3269         * skip.c (_initialize_step_skip): Likewise.
3270         * source.c (_initialize_source): Likewise.
3271         * stack.c (_initialize_stack): Likewise.
3272         * symfile.c (_initialize_symfile): Likewise.
3273         * symtab.c (_initialize_symtab): Likewise.
3274         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3275         * top.c (init_main): Likewise.
3276         * tracefile-tfile.c (tfile_target_info): Likewise.
3277         * tracepoint.c (_initialize_tracepoint): Likewise.
3278         * tui/tui-win.c (_initialize_tui_win): Likewise.
3279         * utils.c (add_internal_problem_command): Likewise.
3280         * valprint.c (value_print_option_defs): Likewise.
3281
3282 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3283
3284         PR build/24886
3285         * configure.ac: Drop enable-libmcheck support.
3286         * configure, config.in: Rebuild.
3287         * libmcheck.m4: Remove.
3288         * acinclude.m4: Don't include it.
3289         * Makefile.in: Don't distribute it.
3290         * top.c (print_gdb_configuration): Don't mention it.
3291
3292 2019-08-06  Tom Tromey  <tom@tromey.com>
3293
3294         * utils.c (set_output_style): Sometimes pass stream to
3295         emit_style_escape.
3296         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3297         * record-btrace.c (btrace_insn_history): Update.
3298         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3299         method.
3300         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3301         Update initializers.
3302         <m_uiout>: New field.
3303         <m_di>: Move lower.
3304         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3305         Remove "uiout" parameter.
3306         (dump_insns): Update.
3307         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3308         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3309
3310 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3311
3312         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3313         (error_in_psymtab_expansion): Likewise.
3314         (lookup_symbol_via_quick_fns): Likewise.
3315         (basic_lookup_transparent_type_quick): Likewise.
3316         (basic_lookup_transparent_type_1): Likewise.
3317
3318 2019-08-06  Tom Tromey  <tromey@adacore.com>
3319
3320         * source.c (last_source_error): Now bool.
3321         (print_source_lines_base): Make "noprint" bool.  Only open
3322         source file when last_source_visited changes.
3323
3324 2019-08-06  Tom Tromey  <tromey@adacore.com>
3325
3326         * annotate.c (annotate_source_line): Use g_source_cache.
3327         * source-cache.c (source_cache::get_plain_source_lines): Change
3328         parameters.  Populate m_offset_cache.
3329         (source_cache::ensure): New method.
3330         (source_cache::get_line_charpos): New method.
3331         (extract_lines): Move lower.  Change parameters.
3332         (source_cache::get_source_lines): Move lower.
3333         * source-cache.h (class source_cache): Update comment.
3334         <get_line_charpos>: New method.
3335         <get_source_lines>: Update comment.
3336         <clear>: Clear m_offset_cache.
3337         <get_plain_source_lines>: Change parameters.
3338         <ensure>: New method
3339         <m_offset_cache>: New member.
3340         * source.c (forget_cached_source_info_for_objfile): Update.
3341         (info_source_command): Use g_source_cache.
3342         (find_source_lines, open_source_file_with_line_charpos): Remove.
3343         (print_source_lines_base, search_command_helper): Use g_source_cache.
3344         * source.h (open_source_file_with_line_charpos): Don't declare.
3345         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3346         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3347         Use g_source_cache.
3348
3349 2019-08-06  Tom Tromey  <tromey@adacore.com>
3350
3351         * source-cache.c (source_cache::get_plain_source_lines):
3352         Remove "first_line" and "last_line" parameters.
3353         (source_cache::get_source_lines): Cache plain text.
3354         * source-cache.h (class source_cache)
3355         <get_plain_source_lines>: Update.
3356
3357 2019-08-06  Tom Tromey  <tromey@adacore.com>
3358
3359         * source-cache.c (extract_lines): No longer a method.
3360         Changed type of parameter.  Include final newline.
3361         (selftests::extract_lines_test): New function.
3362         (_initialize_source_cache): Likewise.
3363         * source-cache.h (class source_cache)
3364         <extract_lines>: Don't declare.
3365
3366 2019-08-06  Tom Tromey  <tromey@adacore.com>
3367
3368         * breakpoint.c (init_breakpoint_sal): Update.
3369         (breakpoint): Update.
3370         * breakpoint.h (struct breakpoint) <filter>: Now a
3371         unique_xmalloc_ptr.
3372
3373 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3374
3375         * NEWS: Mention dictionary access on blocks.
3376         * python/py-block.c (blpy_getitem): New function.
3377         (block_object_as_mapping): New struct.
3378         (block_object_type): Use new struct for tp_as_mapping field.
3379
3380 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3381
3382         * objfiles.h (objfile): Add a comment describing partial symbols.
3383
3384 2019-08-05  Tom Tromey  <tromey@adacore.com>
3385
3386         * compile/compile.c (_initialize_compile): Use _(), not N_().
3387         * thread.c (_initialize_thread): Use _(), not N_().
3388         * stack.c (_initialize_stack): Use _(), not N_().
3389         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3390
3391 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3392
3393         * dwarf2read.c (struct dw2_symtab_iterator):
3394         <want_specific_block>: Remove.
3395         <block_index>: Change type to gdb::optional.
3396         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3397         change type of BLOCK_INDEX parameter to gdb::optional.
3398         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3399         (dw2_lookup_symbol): Don't pass argument for
3400         WANT_SPECIFIC_BLOCK.
3401         (dw2_expand_symtabs_for_function): Don't pass argument for
3402         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3403         (class dw2_debug_names_iterator)
3404         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3405         parameter, change BLOCK_INDEX type to gdb::optional.
3406         <m_want_specific_block>: Remove.
3407         <m_block_index>: Change type to gdb::optional.
3408         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3409         gdb::optional.  Re-write in function of gdb::optional.
3410         (dw2_debug_names_lookup_symbol): Don't pass argument for
3411         WANT_SPECIFIC_BLOCK.
3412         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3413         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3414         BLOCK_INDEX.
3415
3416 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3417
3418         * NEWS: Mention changes to "info sources" command.
3419
3420 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3421
3422         * symtab.c (filename_partial_match_opts): New struct type.
3423         (struct output_source_filename_data): New members
3424         regexp, c_regexp, partial_match.
3425         (output_source_filename): Use new members to decide to print file.
3426         (info_sources_option_defs): New variable.
3427         (make_info_sources_options_def_group, print_info_sources_header,
3428         info_sources_command_completer):
3429         New functions.
3430         (info_sources_command): Read new optional arguments.
3431         (_initialize_symtab): Update info sources help.
3432
3433 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3434
3435         * ada-lang.c (exception_support_info_v0): Renamed from...
3436         (default_exception_support_info): ... this.  Create new
3437         definition for v1.
3438         (ada_has_this_exception_support): Look up catch_handlers_sym.
3439         (ada_exception_support_info_sniffer): Try v0 after default.
3440
3441 2019-08-01  Tom Tromey  <tromey@adacore.com>
3442
3443         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3444         gdbarch.h.
3445
3446 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3447
3448         * s12z-tdep.c: Fix include path for s12z-opc.h.
3449
3450 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3451
3452         * NEWS: Require GNU make 3.82.
3453
3454 2019-07-16  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3457         declare.
3458
3459 2019-07-30  Tom Tromey  <tromey@adacore.com>
3460
3461         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3462
3463 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3464
3465         * printcmd.c (print_address_symbolic): Print negative offsets.
3466         (build_address_symbolic): Force signed arithmetic when computing
3467         offset.
3468
3469 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3470
3471         PR/24474: Add a function to lookup static variables.
3472         * NEWS: Mention this new function.
3473         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3474         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3475         * python/python.c (python_GdbMethods): Add new function.
3476
3477 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3478
3479         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3480         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3481         (objfpy_lookup_static_symbol): New function.
3482         (objfile_object_methods): Add new functions.
3483
3484 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3485
3486         * NEWS: Mention 'set|show print frame-info'.  Mention new
3487         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3488         backtrace argument.  Mention that python frame filtering code
3489         is now consistent with what 'backtrace' command prints.
3490
3491 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3492
3493         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3494         comments.
3495         (print_frame_info_auto, print_frame_info_source_line,
3496         print_frame_info_location, print_frame_info_source_and_location,
3497         print_frame_info_location_and_address, print_frame_info_short_location):
3498         New declarations.
3499         (struct frame_print_options): New member print_frame_info.
3500         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3501         * stack.h (get_user_print_what_frame_info): New declaration.
3502         (frame_show_address): New declaration.
3503         * stack.c (print_frame_arguments_choices): New value 'presence'.
3504         (print_frame_info_auto, print_frame_info_source_line,
3505         print_frame_info_location, print_frame_info_source_and_location,
3506         print_frame_info_location_and_address, print_frame_info_short_location,
3507         print_frame_info_choices, print_frame_info_print_what): New definitions.
3508         (print_frame_args): Only print dots for args if print frame-arguments
3509         is 'presence'.
3510         (frame_print_option_defs): New element for "frame-info".
3511         (get_user_print_what_frame_info): New function.
3512         (frame_show_address): Make non static.  Move comment to stack.h.
3513         (print_frame_info_to_print_what): New function.
3514         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3515         to decide what to print.
3516         (backtrace_command_1): Handle the new print_frame_arguments_presence
3517         value.
3518         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3519         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3520         (py_print_frame): In non-mi mode, use LOCATION as default for
3521         print_what, similarly to frame information printed directly by
3522         backtrace command. Handle frame-info user option in non MI mode.
3523
3524 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3525
3526         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3527         Add case for debugging 32-bit target on 64-bit host.  Revise
3528         comment.
3529
3530 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3531
3532         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3533         instead of find_function_entry_range_from_pc.
3534
3535 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3536
3537         * stack.c (find_frame_funname): Remove code which preferred
3538         minsym over symtab sym in "certain pathological cases".
3539
3540         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3541         parameter.  Change type of "do_demangle" to bool.
3542         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3543         Pass suitable "prefer_sym_over_minsym" flag to
3544         build_address_symbolic().  Don't output "+" for negative offsets.
3545         * printcmd.c (print_address_symbolic): Update invocation of
3546         build_address_symbolic to include a "prefer_sym_over_minsym"
3547         flag.
3548         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3549         Restrict cases in which use of minimal symbol is preferred to that
3550         of a found symbol.  Update comments.
3551
3552         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3553         for entry pc when entry pc is out of range for that FDE.
3554
3555 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3556
3557         PR gdb/24839:
3558         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3559         type.
3560
3561 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3562
3563         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3564         this function's Python signature.
3565
3566
3567 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3568
3569         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3570         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3571         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3572         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3573         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3574
3575
3576 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3577
3578         * h8300-tdep.c (h8300_register_name_common): New.
3579         h8300_register_name): Use h8300_register_name_common.
3580         (h8300s_register_name): Likewise.
3581         (h8300sx_register_name): Likewise.
3582         (h8300h_register_nam): New.
3583         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3584
3585
3586 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3587
3588         * arm-tdep.c (arm_skip_cmse_entry): New function.
3589         (arm_is_sgstubs_section): New function.
3590         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3591
3592 2019-07-22  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3595         Don't self-assign.
3596
3597 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3598
3599         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3600         type_print.
3601
3602 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3605         so that GDB doesn't match any msymbols when searching in the
3606         TYPES_DOMAIN.
3607         (print_symbol_info): Print using typedef_print or type_print based
3608         on the type of the symbol.  Add updated FIXME comment moved from...
3609         (_initialize_symtab): ... move and update FIXME comment to above.
3610
3611 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3612
3613         * NEWS: Mention adding -q option to "info types".
3614         * symtab.c (struct info_types_options): New struct.
3615         (info_types_options_defs): New variable.
3616         (make_info_types_options_def_group): New function.
3617         (info_types_command): Use gdb::option framework to parse options.
3618         (info_types_command_completer): New function.
3619         (_initialize_symtab): Extend the help text on "info types" and
3620         register command completer.
3621
3622 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3623
3624         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3625         (lookup_symbol_in_objfile): Change int to block_enum and add a
3626         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3627
3628 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3629
3630         * MAINTAINERS (Write After Approval): Add self.
3631
3632 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3635         instruction to the dummy code region.
3636
3637 2019-07-19  Tom Tromey  <tromey@adacore.com>
3638
3639         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3640         (ARGSUSED, PARAMS, __func__): Remove rules.
3641
3642 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3643
3644         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3645         * features/arm/arm-with-iwmmxt.c: Remove.
3646         * features/arm/arm-with-iwmmxt.xml: Remove.
3647         * features/arm/arm-with-m-fpa-layout.c: Remove.
3648         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3649         * features/arm/arm-with-m-vfp-d16.c: Remove.
3650         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3651         * features/arm/arm-with-m.c: Remove.
3652         * features/arm/arm-with-m.xml: Remove.
3653         * features/arm/arm-with-neon.c: Remove.
3654         * features/arm/arm-with-neon.xml: Remove.
3655         * features/arm/arm-with-vfpv2.c: Remove.
3656         * features/arm/arm-with-vfpv2.xml: Remove.
3657         * features/arm/arm-with-vfpv3.c: Remove.
3658         * features/arm/arm-with-vfpv3.xml: Remove.
3659
3660 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3661
3662         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3663
3664 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3665
3666         * arch/aarch32.c (aarch32_create_target_description): Create
3667         target descriptions using features.
3668         * arch/arm.c (arm_create_target_description)
3669         (arm_create_mprofile_target_description): Likewise.
3670         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3671
3672 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * Makefile.in: Add new files.
3675         * aarch32-tdep.c: New file.
3676         * aarch32-tdep.h: New file.
3677         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3678         Call aarch32_read_description.
3679         * arch/aarch32.c: New file.
3680         * arch/aarch32.h: New file.
3681         * arch/arm.c (arm_create_target_description)
3682         (arm_create_mprofile_target_description): New function.
3683         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3684         (arm_create_target_description)
3685         (arm_create_mprofile_target_description): New declaration.
3686         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3687         read_description functions.
3688         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3689         Likewise.
3690         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3691         * arm-tdep.c (tdesc_arm_list): New variable.
3692         (arm_register_g_packet_guesses): Call create description functions.
3693         (arm_read_description) (arm_read_mprofile_description): New
3694         function.
3695         * arm-tdep.h (arm_read_description)
3696         (arm_read_mprofile_description): Add declaration.
3697         * configure.tgt: Add new files.
3698
3699 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3700
3701         * top.c (new_ui_command): Open specified terminal just once.
3702
3703 2019-07-18  Tom Tromey  <tromey@adacore.com>
3704
3705         * symtab.c (main_name): Constify return type.
3706         * symfile.c (set_initial_language): Update.
3707         * symtab.h (main_name): Constify return type.
3708
3709 2019-07-17  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-winsource.c (tui_update_source_window)
3712         (tui_update_source_window_as_is)
3713         (tui_update_source_windows_with_line): Remove return.
3714         * tui/tui-disasm.c (tui_show_disassem)
3715         (tui_show_disassem_and_update_source): Remove return.
3716         * tui/tui.c (tui_reset): Remove return.
3717         * tui/tui-wingeneral.c
3718         (tui_check_and_display_highlight_if_needed): Remove return.
3719
3720 2019-07-17  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3723
3724 2019-07-17  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-winsource.h (struct tui_exec_info_window)
3727         (struct tui_source_window_base): Move from tui-data.h.
3728         * tui/tui-winsource.c: Move many method definitions from
3729         elsewhere.  Remove "structuring" comments.
3730         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3731         (tui_source_window_base::refresh_window): Move to
3732         tui-winsource.c.
3733         * tui/tui-win.c (tui_source_window_base::refresh_all)
3734         (tui_source_window_base::update_tab_width)
3735         (tui_source_window_base::set_new_height)
3736         (tui_source_window_base::do_make_visible_with_new_height): Move to
3737         tui-winsource.c.
3738         * tui/tui-source.h: Update.
3739         * tui/tui-source.c (tui_source_window_base::reset): Move to
3740         tui-winsource.c.
3741         * tui/tui-disasm.h: Update.
3742         * tui/tui-data.h (struct tui_exec_info_window): Move to
3743         tui-winsource.h.
3744         (struct tui_source_window_base): Likewise.
3745         * tui/tui-data.c (tui_source_window_base::clear_detail)
3746         (tui_source_window_base, ~tui_source_window_base): Move to
3747         tui-winsource.c.
3748
3749 2019-07-17  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-win.c (tui_resize_all)
3752         (tui_source_window_base::update_tab_width)
3753         (tui_adjust_win_heights): Update.
3754         (tui_win_info::make_invisible_and_set_new_height): Rename from
3755         make_invisible_and_set_new_height.
3756         * tui/tui-data.h (struct tui_win_info)
3757         <make_invisible_and_set_new_height>: New method.
3758
3759 2019-07-17  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui.c: Update.
3762         * tui/tui-source.h (struct tui_source_window): Move from
3763         tui-data.h.
3764         * tui/tui-layout.c: Update.
3765         * tui/tui-disasm.c: Update.
3766         * tui/tui-data.h (struct tui_source_window): Move to
3767         tui-source.h.
3768
3769 2019-07-17  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3772         tui-data.h.
3773         * tui/tui-data.h (struct tui_disasm_window): Move to
3774         tui-disasm.h.
3775
3776 2019-07-17  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-regs.h (struct tui_data_item_window): Move from
3779         tui-data.h.
3780         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3781         * tui/tui-data.h (struct tui_data_item_window): Move to
3782         tui-regs.h.
3783         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3784
3785 2019-07-17  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui.c: Update.
3788         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3789         (tui_cmd_window::max_height): Move to tui-command.c.
3790         * tui/tui-layout.c: Update.
3791         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3792         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3793         tui-command.c.
3794         * tui/tui-command.h (struct tui_cmd_window): Move from
3795         tui-data.h.
3796         * tui/tui-command.c: Remove "structuring" comments.
3797         (tui_cmd_window::clear_detail)
3798         (tui_cmd_window::do_make_visible_with_new_height)
3799         (tui_cmd_window::max_height): Move from elsewhere.
3800
3801 2019-07-17  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3804         Now static.
3805         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3806         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3807
3808 2019-07-17  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui.c: Update.
3811         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3812         tui-regs.c.
3813         * tui/tui-windata.h: Remove file.
3814         * tui/tui-windata.c: Remove file.
3815         * tui/tui-win.c (tui_data_window::set_new_height)
3816         (tui_data_window::do_make_visible_with_new_height): Move to
3817         tui-regs.c.
3818         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3819         * tui/tui-regs.c: Remove "structuring" comments.
3820         (tui_data_window::first_data_item_displayed)
3821         (tui_data_window::delete_data_content_windows)
3822         (tui_data_window::erase_data_content)
3823         (tui_data_window::display_all_data)
3824         (tui_data_window::refresh_all)
3825         (tui_data_window::do_scroll_vertical)
3826         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3827         (tui_data_window::do_make_visible_with_new_height)
3828         (tui_data_window::refresh_window): Move from elsewhere.
3829         (_initialize_tui_regs): Move to end of file.
3830         * tui/tui-layout.c: Update.
3831         * tui/tui-hooks.c: Update.
3832         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3833         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3834         tui-regs.c.
3835         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3836
3837 2019-07-17  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3840         seen.
3841
3842 2019-07-17  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-win.c (tui_source_window_base::set_new_height)
3845         (tui_source_window_base::do_make_visible_with_new_height): Use
3846         m_has_locator field directly.
3847         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3848         method.
3849         (struct tui_source_window_base) <has_locator>: Likewise.
3850
3851 2019-07-17  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3854         Don't declare.
3855         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3856         Remove.
3857         * tui/tui-win.c (tui_source_window_base::set_new_height)
3858         (tui_source_window_base::set_new_height)
3859         (make_invisible_and_set_new_height)
3860         (tui_source_window_base::do_make_visible_with_new_height)
3861         (tui_source_window_base::do_make_visible_with_new_height):
3862         Update.
3863         * tui/tui-layout.c (show_source_disasm_command, show_data)
3864         (show_source_or_disasm_and_command): Update.
3865         * tui/tui-layout.c (show_layout): Update.
3866
3867 2019-07-17  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-layout.c (make_data_window): Remove.
3870         (show_data): Unify creation and re-initialization cases.
3871
3872 2019-07-17  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-layout.c (make_source_window, make_disasm_window):
3875         Remove.
3876         (show_data): Unify creation and re-initialization cases.
3877
3878 2019-07-17  Tom Tromey  <tom@tromey.com>
3879
3880         * tui/tui-layout.c (make_command_window): Remove.
3881         (show_source_disasm_command, show_source_or_disasm_and_command):
3882         Unify creation and re-initialization cases.
3883
3884 2019-07-17  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3887         creation and re-initialization cases.
3888
3889 2019-07-17  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-regs.c (tui_get_register): Return void.
3892
3893 2019-07-17  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3896         Simplify.
3897
3898 2019-07-17  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3901         resetting.
3902
3903 2019-07-17  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3906         * tui/tui-regs.c (tui_reg_layout): New function.
3907         (tui_show_registers, tui_reg_command): Use it.
3908         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3909         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3910         parameters.
3911         (tui_layout_command): Remove.
3912
3913 2019-07-17  Tom Tromey  <tom@tromey.com>
3914
3915         * tui/tui-layout.h (tui/tui-layout): Return void.
3916         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3917
3918 2019-07-17  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-layout.c (show_source_disasm_command, show_data):
3921         Update.
3922         (reset_locator): Remove.
3923         (show_source_or_disasm_and_command): Update.
3924
3925 2019-07-17  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-source.c (tui_source_window_base::reset): Remove
3928         win_type parameter.
3929         * tui/tui-layout.c (make_command_window, make_source_window)
3930         (make_disasm_window, make_data_window)
3931         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3932         (reset_locator, show_source_or_disasm_and_command): Update.
3933         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3934         win_type parameter.
3935         (struct tui_source_window_base) <reset>: Likewise.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-layout.c (show_source_disasm_command): Use
3940         reset_locator.
3941         (reset_locator): New function.
3942         (init_and_make_win): Remove.
3943         (show_source_or_disasm_and_command): Use reset_locator.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3948         condition.
3949         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3950         Remove condition.
3951         * tui/tui-source.c (tui_source_window_base::reset): New method.
3952         * tui/tui-layout.c (make_command_window): Don't call
3953         init_and_make_win.
3954         (make_source_window, make_disasm_window): Don't call
3955         make_source_or_disasm_window.
3956         (make_data_window): Don't call init_and_make_win.  Change calling
3957         convention.
3958         (show_source_disasm_command, show_data): Simplify.
3959         (make_source_or_disasm_window): Remove.
3960         (show_source_or_disasm_and_command): Simplify.
3961         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3962         (struct tui_source_window_base) <reset>: Likewise.
3963         <execution_info>: Remove initializer.
3964         * tui/tui-data.c (tui_source_window_base): Initialize
3965         execution_info.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3970         variable.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui.c (tui_rl_other_window): Update.
3975         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3976         superclass method first.  Always iterate over regs_content.
3977         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3978         method.
3979         * tui/tui-win.c (tui_set_focus_command): Update.
3980
3981 2019-07-17  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-win.c (tui_set_focus_command): Rename from
3984         tui_set_focus.  Call tui_enable.
3985         (tui_set_focus_command): Remove.
3986
3987 2019-07-17  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3990         refresh_window.
3991         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3992         touchwin.
3993         (tui_data_window::refresh_window): Call refresh_window on data
3994         items.  Always call superclass refresh_window.
3995         (tui_win_info::refresh): Remove.
3996         (tui_source_window_base::refresh_window): Update.
3997         (tui_refresh_all): Update.
3998         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3999         refresh_window.
4000         (show_source_or_disasm_and_command): Likewise.
4001         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4002         (struct tui_source_window_base) <refresh>: Likewise.
4003
4004 2019-07-17  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui-winsource.c (tui_clear_source_content)
4007         (tui_show_source_content): Update.
4008         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4009         whether content is empty.
4010         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4011         Remove.
4012
4013 2019-07-17  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4016         window's contents.
4017         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4018         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4019
4020 2019-07-17  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4023         (struct tui_data_item_window): Update.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4028         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4029         defines.
4030
4031 2019-07-17  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-winsource.h (tui_erase_source_content)
4034         (tui_clear_source_content): Remove "display_prompt" parameter.
4035         * tui/tui-winsource.c (tui_update_source_window_as_is)
4036         (tui_update_source_windows_with_addr): Update.
4037         (tui_clear_source_content): Remove "display_prompt" parameter.
4038         (tui_erase_source_content): Likewise.  Simplify.
4039         (tui_show_source_content): Update.
4040         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4041         * tui/tui-stack.c (tui_show_frame_info): Update.
4042         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4043         Remove defines.
4044
4045 2019-07-17  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4048         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4049         parameter.
4050         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4051         parameter.
4052
4053 2019-07-17  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-winsource.c (tui_clear_source_content)
4056         (tui_show_source_content, tui_show_exec_info_content)
4057         (tui_clear_exec_info_content): Update.
4058         * tui/tui-stack.c (tui_show_locator_content): Update.
4059         (tui_show_frame_info): Update.
4060         * tui/tui-source.h (tui_source_window): Don't declare.
4061         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4062         from tui_source_is_displayed.
4063         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4064         Remove field.
4065         (struct tui_source_window_base) <content_in_use>: New field.  Now
4066         bool.
4067         (struct tui_source_window) <showing_source_p>: New method.
4068         (TUI_SRC_WIN): Change cast.
4069         * tui/tui-data.c (tui_initialize_static_data): Update.
4070
4071 2019-07-17  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4074         location_matches_p.
4075         * tui/tui-source.c (tui_source_window::location_matches_p): New
4076         method.
4077         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4078         method.
4079         * tui/tui-data.h (struct tui_source_window_base)
4080         <location_matches_p>: New method.
4081         (struct tui_source_window, struct tui_disasm_window)
4082         <location_matches_p>: Likewise.
4083
4084 2019-07-17  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-win.c (tui_set_win_height_command): Rename from
4087         tui_set_win_height.
4088         (tui_set_win_height_command): Remove.
4089
4090 2019-07-17  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-source.c (tui_source_window): New constructor.  Add
4093         observer.
4094         (~tui_source_window): New destructor.
4095         (tui_source_window::style_changed): New method.
4096         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4097         (tui_attach_detach_observers): Update.
4098         * tui/tui-data.h (struct tui_source_window): Make constructor not
4099         inline.  Add destructor.
4100         (struct tui_source_window) <style_changed>: New method.
4101         <m_observable>: New member.
4102
4103 2019-07-17  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4106         * tui/tui-win.c (tui_resize_all): Fix typo.
4107
4108 2019-07-17  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4111         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4112         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4113         * tui/tui-win.c (window_name_completer): Use foreach.
4114         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4115         (update_tab_width): Likewise.
4116         * tui/tui-layout.c (show_layout): Update.
4117         * tui/tui-data.h (class tui_window_iterator): New.
4118         (struct all_tui_windows): New.
4119         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4120
4121 2019-07-17  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4124         parameter.  Don't reference globals.
4125         (tui_reg_command): Update.
4126
4127 2019-07-17  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui-regs.c (tui_show_registers): Simplify.
4130
4131 2019-07-17  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-regs.c (tui_show_registers): Update.
4134         (tui_show_register_group): Add win_info parameter.
4135
4136 2019-07-17  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4139         Rename from tui_display_reg_element_at_line.
4140         (tui_data_window::display_registers_from_line): Update.
4141         * tui/tui-data.h (struct tui_data_window)
4142         <display_reg_element_at_line>: New method.
4143
4144 2019-07-17  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-regs.h (tui_display_registers_from)
4147         (tui_display_registers_from_line): Don't declare.
4148         * tui/tui-windata.c (tui_data_window::display_all_data)
4149         (tui_data_window::refresh_all)
4150         (tui_data_window::do_scroll_vertical): Update.
4151         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4152         from tui_display_registers_from.
4153         (tui_display_reg_element_at_line): Update.
4154         (tui_data_window::display_registers_from_line): Rename from
4155         tui_display_registers_from_line.
4156         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4157         display_registers_from_line>: New methods.
4158
4159 2019-07-17  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4162         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4163         from tui_erase_data_content.
4164         (tui_data_window::display_all_data)
4165         (tui_data_window::refresh_all)
4166         (tui_data_window::do_scroll_vertical): Update.
4167         * tui/tui-regs.c (tui_show_registers): Update.
4168         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4169         New method.
4170
4171 2019-07-17  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4174         declare.
4175         * tui/tui-windata.c
4176         (tui_data_window::delete_data_content_windows): Rename from
4177         tui_delete_data_content_windows.
4178         (tui_data_window::display_all_data)
4179         (tui_data_window::do_scroll_vertical): Update.
4180         * tui/tui-data.h (struct tui_data_window)
4181         <delete_data_content_windows>: New method.
4182
4183 2019-07-17  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4186         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4187
4188 2019-07-17  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4191         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4192         from tui_display_all_data.
4193         * tui/tui-win.c
4194         (tui_data_window::do_make_visible_with_new_height): Update.
4195         * tui/tui-regs.c (tui_show_registers): Update.
4196         * tui/tui-layout.c (tui_set_layout): Update.
4197         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4198         method.
4199
4200 2019-07-17  Tom Tromey  <tom@tromey.com>
4201
4202         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4203         * tui/tui-windata.c (tui_display_data_from): Remove.
4204         (tui_data_window::refresh_all): Update.
4205
4206 2019-07-17  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4209         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4210         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4211         tui_display_registers_from_line.
4212         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4213         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4214         "force_display" parameter.
4215
4216 2019-07-17  Tom Tromey  <tom@tromey.com>
4217
4218         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4219         declare.
4220         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4221         Rename from tui_first_reg_element_no_inline.
4222         (tui_display_reg_element_at_line)
4223         (tui_display_registers_from_line): Update.
4224         * tui/tui-data.h (struct tui_data_window)
4225         <first_reg_element_no_inline>: New method.
4226
4227 2019-07-17  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-windata.c (tui_display_data_from)
4230         (tui_data_window::do_scroll_vertical): Update.
4231         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4232         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4233         Rename from tui_line_from_reg_element_no.
4234         (tui_display_registers_from_line): Update.
4235         * tui/tui-data.h (struct tui_data_window)
4236         <line_from_reg_element_no>: New method.
4237
4238 2019-07-17  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4241         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4242         tui_last_regs_line_no.
4243         (tui_display_reg_element_at_line)
4244         (tui_display_registers_from_line): Update.
4245         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4246         method.
4247
4248 2019-07-17  Tom Tromey  <tom@tromey.com>
4249
4250         PR tui/24722:
4251         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4252         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4253         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4254         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4255         (tui_update_breakpoint_info): Likewise.
4256         * tui/tui-hooks.c (tui_event_create_breakpoint)
4257         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4258         Update.
4259
4260 2019-07-17  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4263
4264 2019-07-17  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-winsource.c (tui_update_source_window_as_is)
4267         (tui_update_source_windows_with_addr): Update.
4268         * tui/tui-source.h (tui_set_source_content)
4269         (tui_show_symtab_source): Add "win_info" parameter.
4270         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4271         parameter.
4272         (tui_show_symtab_source): Likewise.
4273
4274 2019-07-17  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-wingeneral.c
4277         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4278
4279 2019-07-17  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4282         (struct tui_cmd_window) <can_scroll>: New method.
4283         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4284         method.
4285
4286 2019-07-17  Tom Tromey  <tromey@adacore.com>
4287
4288         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4289         do_field_signed>: Rename.  Change type of "value".
4290         * ui-out.c (ui_out::field_signed): Rename from field_int.
4291         Change type of "value".
4292         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4293         type of "value".
4294         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4295         do_field_int.  Change type of "value".
4296         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4297         do_field_int.  Change type of "value".
4298         * tracepoint.c (trace_status_mi, tfind_1)
4299         (print_one_static_tracepoint_marker): Update.
4300         * thread.c (print_thread_info_1, print_selected_thread_frame):
4301         Update.
4302         * stack.c (print_frame, print_frame_info): Update.
4303         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4304         Update.
4305         * source.c (print_source_lines_base): Update.
4306         * skip.c (info_skip_command): Update.
4307         * record-btrace.c (btrace_ui_out_decode_error)
4308         (btrace_call_history_src_line): Update.
4309         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4310         Update.
4311         * progspace.c (print_program_space): Update.
4312         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4313         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4314         do_field_int.  Change type of "value".
4315         * mi/mi-out.c (mi_ui_out::do_table_begin)
4316         (mi_ui_out::do_table_header): Update.
4317         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4318         type of "value".
4319         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4320         (mi_cmd_data_list_changed_registers, output_register)
4321         (mi_cmd_data_read_memory, mi_load_progress)
4322         (mi_cmd_trace_frame_collected): Update.
4323         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4324         Update.
4325         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4326         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4327         (mi_cmd_var_list_children, varobj_update_one): Update.
4328         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4329         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4330         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4331         * inferior.c (print_inferior): Update.
4332         * gdb_bfd.c (print_one_bfd): Update.
4333         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4334         Update.
4335         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4336         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4337         do_field_int.  Change type of "value".
4338         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4339         do_field_int.  Change type of "value".
4340         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4341         (print_one_breakpoint_location, print_it_catch_fork)
4342         (print_one_catch_fork, print_it_catch_vfork)
4343         (print_one_catch_vfork, print_it_catch_solib)
4344         (print_it_catch_exec, print_it_ranged_breakpoint)
4345         (print_mention_watchpoint, print_mention_masked_watchpoint)
4346         (bkpt_print_it, update_static_tracepoint): Update.
4347         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4348         * break-catch-syscall.c (print_it_catch_syscall): Update.
4349         * ada-tasks.c (print_ada_task_info): Update.
4350         * ada-lang.c (print_it_exception, print_mention_exception):
4351         Update.
4352
4353 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4354
4355         PR breakpoints/24541
4356         * gdbarch.c: Regenerate.
4357         * gdbarch.h: Regenerate.
4358         * gdbarch.sh: Adjust return type and parameter types for
4359         'stap_adjust_register'.
4360         (i386_stap_adjust_register): Adjust signature and return new
4361         register name.
4362         * stap-probe.c (stap_parse_register_operand): Adjust use of
4363         'gdbarch_stap_adjust_register'.
4364
4365 2019-07-17  Tom Tromey  <tromey@adacore.com>
4366
4367         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4368         declare VEC.
4369         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4370         std::vector.
4371         (struct s390_process_info): Add initializers.
4372         (s390_add_process): Use new.
4373         (s390_linux_nat_target::low_forget_process): Use delete.
4374         (s390_linux_nat_target::low_new_fork)
4375         (s390_linux_nat_target::stopped_by_watchpoint)
4376         (s390_linux_nat_target::low_prepare_to_resume)
4377         (s390_linux_nat_target::insert_watchpoint)
4378         (s390_linux_nat_target::insert_hw_breakpoint)
4379         (s390_linux_nat_target::remove_watchpoint)
4380         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4381
4382 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4383
4384         * aarch64-fbsd-nat.c: Include regcache.h.
4385         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4386         argument.
4387         (aarch64_fbsd_nat_target::fetch_registers)
4388         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4389         variable.
4390         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4391
4392 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4393
4394         * fbsd-nat.c: Include gdbarch.h.
4395
4396 2019-07-15  Tom Tromey  <tromey@adacore.com>
4397
4398         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4399
4400 2019-07-15  Tom Tromey  <tromey@adacore.com>
4401
4402         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4403         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4404         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4405         * cli-out.c (cli_ui_out::do_field_int): New method.
4406         * ui-out.c (ui_out::field_unsigned): New method.
4407         * symfile.c (generic_load): Use field_unsigned.
4408         (print_transfer_performance): Likewise.
4409         * record-btrace.c (ui_out_field_uint): Remove.
4410         (btrace_call_history_insn_range, btrace_call_history): Use
4411         field_unsigned.
4412         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4413         field_unsigned.
4414         * ui-out.h (class ui_out) <field_unsigned>: New method.
4415         <do_field_unsigned>: Likewise.
4416
4417 2019-07-15  Tom Tromey  <tromey@adacore.com>
4418
4419         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4420         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4421         * target.c (flash_erase_command): Use field_string.
4422         * infrun.c (print_signal_received_reason): Use field_string.
4423         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4424         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4425         field_string.
4426         * ada-tasks.c (print_ada_task_info): Use field_string.
4427
4428 2019-07-15  Tom Tromey  <tromey@adacore.com>
4429
4430         * target.c (flash_erase_command): Use field_core_addr.
4431         * symfile.c (generic_load): Use field_core_addr.
4432         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4433         Use field_core_addr.
4434         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4435         field_core_addr.
4436
4437 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4440         value if its desired type is smaller than a CORE_ADDR and signed.
4441
4442 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4445         of changes to field names, and use new is_reference field to
4446         decide if a property is a reference or not.
4447         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4448         field.
4449         (struct dwarf2_property_baton): Update header comment, rename
4450         'referenced_type' to 'property_type' and update comments.
4451         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4452         default property type, store in property baton, update to take
4453         accound of renamed field.
4454         (read_func_scope): Update call to attr_to_dynamic_prop.
4455         (read_array_type): Likewise.
4456         (dwarf2_per_cu_addr_sized_int_type): New function.
4457         (read_subrange_index_type): Move type finding code to
4458         dwarf2_per_cu_addr_sized_int_type.
4459         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4460         (dwarf2_per_cu_addr_type): New function.
4461         (set_die_type): Update calls to attr_to_dynamic_prop.
4462
4463 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * dwarf2read.c (read_subrange_index_type): New function.
4466         (read_subrange_type): Move code into new function and call it.
4467         * gdbtypes.c (create_range_type): Add some asserts.
4468
4469 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4472         update return statements.
4473         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4474         declaration, and update comment to match.
4475         * gdbtypes.c (resolve_dynamic_array): Update call to
4476         dwarf2_evaluate_property to match new return type.
4477
4478 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * valarith.c (value_subscripted_rvalue): Change lowerbound
4481         parameter type from int to LONGEST.
4482         * value.h (value_subscripted_rvalue): Likewise in declaration.
4483
4484 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * cli/cli-utils.c (info_print_command_completer): New function.
4487         * cli/cli-utils.h: Add 'completer.h' include, and forward
4488         declaration for 'struct cmd_list_element'.
4489         (info_print_command_completer): Declare.
4490         * stack.c (_initialize_stack): Add completer for 'info locals' and
4491         'info args'.
4492         * symtab.c (_initialize_symtab): Add completer for 'info
4493         variables' and 'info functions'.
4494         * NEWS: Mention completion for additional info commands.
4495
4496 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * cli/cli-utils.c (extract_info_print_args): Delete.
4499         (extract_arg_maybe_quoted): Delete.
4500         (info_print_options_defs): New variable.
4501         (make_info_print_options_def_group): New function.
4502         (extract_info_print_options): Define new function.
4503         * cli/cli-utils.h (extract_info_print_args): Delete.
4504         (struct info_print_options): New structure.
4505         (extract_info_print_options): Declare new function.
4506         * stack.c (info_locals_command): Update to use new
4507         extract_info_print_options, also add a header comment.
4508         (info_args_command): Likewise.
4509         * symtab.c (info_variables_command): Likewise.
4510         (info_functions_command): Likewise.
4511
4512 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4515         to extract string arguments.
4516         * common/common-utils.c (extract_string_maybe_quoted): New function.
4517         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4518
4519 2019-07-11  Tom Tromey  <tromey@adacore.com>
4520
4521         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4522         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4523         * top.h (gdbinit): Don't declare.
4524         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4525         into...
4526         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4527         * top.c (gdb_init): Don't call init_cli_cmds.
4528         (gdbinit): Remove.
4529         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4530
4531 2019-07-11  Tom Tromey  <tromey@adacore.com>
4532
4533         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4534         after it has been moved.
4535
4536 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4537
4538         * valops.c (value_must_coerce_to_target): Change return type to
4539         bool.
4540         * value.h (value_must_coerce_to_target): Likewise.
4541
4542 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4543
4544         * breakpoint.c (is_hardware_watchpoint): Remove
4545         forward-declaration.
4546         (is_masked_watchpoint): Change return type to bool.
4547         (is_tracepoint): Likewise.
4548         (is_breakpoint): Likewise.
4549         (is_hardware_watchpoint): Likewise.
4550         (is_watchpoint): Likewise.
4551         (is_no_memory_software_watchpoint): Likewise.
4552         (is_catchpoint): Likewise.
4553         (breakpoint_1): Make FILTER parameter's return type bool.
4554         is_masked_watchpoint): Change return type to bool.
4555         (save_breakpoints): Make FILTER parameter's return type bool.
4556         * breakpoint.h (is_breakpoint): Change return type to bool.
4557         (is_watchpoint): Likewise.
4558         (is_catchpoint): Likewise.
4559         (is_tracepoint): Likewise.
4560
4561 2019-07-10  Tom Tromey  <tom@tromey.com>
4562
4563         * defs.h: Don't include gdbarch.h.
4564         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4565         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4566         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4567         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4568         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4569         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4570         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4571         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4572         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4573         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4574         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4575         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4576         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4577         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4578         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4579         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4580         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4581         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4582         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4583         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4584         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4585         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4586         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4587         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4588         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4589         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4590         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4591
4592 2019-07-10  Tom Tromey  <tromey@adacore.com>
4593
4594         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4595         * breakpoint.c (init_ada_exception_breakpoint): Register as
4596         bp_catchpoint.
4597         (print_one_breakpoint_location, print_one_breakpoint): Use
4598         is_ada_exception_catchpoint.
4599         * ada-lang.c (class ada_catchpoint_location): Pass
4600         bp_loc_software_breakpoint to bp_location constructor.
4601         (is_ada_exception_catchpoint): New function.
4602
4603 2019-07-10  Tom Tromey  <tromey@adacore.com>
4604
4605         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4606         VEC.
4607         (struct arm_exidx_entry): New method operator<.
4608         (struct arm_exidx_data) <section_maps>: Change type.
4609         (arm_exidx_data_free): Remove.
4610         (arm_exidx_data_key): Change type.  Move lower.
4611         (arm_exidx_new_objfile): Update.
4612         (arm_compare_exidx_entries): Remove.
4613         (arm_find_exidx_entry, _initialize_arm_tdep)
4614
4615 2019-07-10  Tom Tromey  <tromey@adacore.com>
4616
4617         * solib-spu.c (ocl_program_data_key): Change type.
4618         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4619         Update.
4620
4621 2019-07-10  Tom Tromey  <tromey@adacore.com>
4622
4623         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4624         (struct solib_aix_inferior_data) <library_list>: Change type.
4625         (solib_aix_inferior_data_handle): Change type.
4626         (get_solib_aix_inferior_data): Update.
4627         (solib_aix_free_library_list): Remove.
4628         (library_list_start_library): Update.
4629         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4630         return type.
4631         (solib_aix_get_library_list)
4632         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4633         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4634
4635 2019-07-10  Tom Tromey  <tromey@adacore.com>
4636
4637         * solib-dsbt.c (struct dsbt_info): Add initializers.
4638         (solib_dsbt_pspace_data): Change type.
4639         (dsbt_pspace_data_cleanup): Remove.
4640         (get_dsbt_info, _initialize_dsbt_solib): Update.
4641
4642 2019-07-10  Tom Tromey  <tromey@adacore.com>
4643
4644         * spu-tdep.c (spu_overlay_data): Change type.
4645         (spu_get_overlay_table, spu_overlay_new_objfile)
4646         (_initialize_spu_tdep): Update.
4647
4648 2019-07-10  Tom Tromey  <tromey@adacore.com>
4649
4650         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4651         destructor.
4652         (dbx_objfile_data_key): Change type and declare later.
4653         (DBX_SYMFILE_INFO): Rewrite.
4654         * dbxread.c (dbx_objfile_data_key): Change type.
4655         (dbx_symfile_init): Update.
4656         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4657         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4658         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4659
4660 2019-07-10  Tom Tromey  <tromey@adacore.com>
4661
4662         * jit.c (jit_program_space_key): Change type.  Move lower.
4663         (get_jit_program_space_data): Update.
4664         (jit_program_space_data_cleanup): Remove.
4665         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4666         Update.
4667         (struct jit_program_space_data): Add initializers.
4668
4669 2019-07-10  Tom Tromey  <tromey@adacore.com>
4670
4671         * solib-darwin.c (struct darwin_info): Add initializers.
4672         (solib_darwin_pspace_data): Change type.
4673         (darwin_pspace_data_cleanup): Remove.
4674         (get_darwin_info, _initialize_darwin_solib): Update.
4675
4676 2019-07-10  Tom Tromey  <tromey@adacore.com>
4677
4678         * remote-sim.c (struct sim_inferior_data): Add initializers,
4679         constructor, and destructor.
4680         (sim_inferior_data_key): Change type.  Move lower.
4681         (check_for_duplicate_sim_descriptor): Update.
4682         (get_sim_inferior_data): Use new.  Update.
4683         (~sim_inferior_data_cleanup): Rename from
4684         sim_inferior_data_cleanup.  Simplify.
4685         (gdbsim_close_inferior, simulator_command)
4686         (sim_command_completer, _initialize_remote_sim): Update.
4687         (next_pid, INITIAL_PID): Move earlier.
4688
4689 2019-07-10  Tom Tromey  <tromey@adacore.com>
4690
4691         * python/python-internal.h (create_thread_object): Return
4692         gdbpy_ref.
4693         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4694         * python/py-inferior.c (struct threadlist_entry): Add
4695         constructor.
4696         <thread_obj>: Now a gdbpy_ref.
4697         (thread_to_thread_object): Update.
4698         (add_thread_object): Use new.
4699         (delete_thread_object): Use delete.
4700         (infpy_threads): Update.
4701         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4702         GIL.
4703
4704 2019-07-10  Tom Tromey  <tromey@adacore.com>
4705
4706         * valops.c (value_cast): Specialize error message for Ada.
4707
4708 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4709
4710         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4711
4712 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4713
4714         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4715         bpstat_should_step): Return bool, adjust comments.
4716         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4717         bpstat_should_step): Likewise.
4718
4719 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4720
4721         * features/Makefile: Use feature target descriptions for Arm.
4722         * features/arm/arm-core.c: Generate new file.
4723         * features/arm/arm-fpa.c: Likewise.
4724         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4725         * features/arm/arm-m-profile.c: Likewise.
4726         * features/arm/arm-vfpv2.c: Likewise.
4727         * features/arm/arm-vfpv3.c: Likewise.
4728         * features/arm/xscale-iwmmxt.c: Likewise.
4729         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4730
4731 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4732
4733         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4734         ptrace earlier.
4735
4736 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4737
4738         * features/aarch64-pauth.c: Regenerate.
4739
4740 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4741
4742         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4743         bool.
4744         (bpstat_what): Use false instead of 0.
4745
4746 2019-07-09  Pedro Alves  <palves@redhat.com>
4747
4748         * break-catch-throw.c (is_exception_catchpoint): New.
4749         * breakpoint.c (print_one_breakpoint_location): New parameter
4750         'raw_loc'.  Handle it.  Use
4751         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4752         looking at the breakpoint's type.
4753         (print_one_breakpoint): If handling "maint info breakpoints", also
4754         print locations of exception catchpoints.
4755         * breakpoint.h (is_exception_catchpoint): Declare.
4756
4757 2019-07-09  Pedro Alves  <palves@redhat.com>
4758
4759         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4760         "addr" field.
4761         (allocate_location_exception_catchpoint): New.
4762         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4763         (initialize_throw_catchpoint_ops): Install
4764         allocate_location_exception_catchpoint as allocate_location
4765         method.
4766         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4767         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4768         bp_loc_other.
4769         (breakpoint_address_is_meaningful): Delete.
4770         (bl_address_is_meaningful): New.
4771         (breakpoint_locations_match): Adjust comment.
4772         (bp_location_from_bp_type): New, factored out of...
4773         (bp_location::bp_location(breakpoint *)): ... this.
4774         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4775         factored out of...
4776         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4777         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4778         breakpoint_address_is_meaningful.
4779         (bp_locations_compare): Adjust comment.
4780         (update_global_location_list): Use bl_address_is_meaningful
4781         instead of breakpoint_address_is_meaningful.
4782         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4783         explicit.
4784         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4785         * python/py-breakpoint.c (bppy_get_location): No longer check
4786         whether location is null.
4787
4788 2019-07-09  Pedro Alves  <palves@redhat.com>
4789
4790         PR c++/15468
4791         * breakpoint.c (print_one_breakpoint_location): Remove
4792         single-location assert.
4793
4794 2019-07-09  Tom Tromey  <tom@tromey.com>
4795
4796         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4797         * configure: Rebuild.
4798         * configure.ac: Change common to gdbsupport.
4799         * gdbsupport: Rename from common.
4800         * acinclude.m4: Change common to gdbsupport.
4801         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4802         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4803         gdbsupport.
4804         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4805         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4806         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4807         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4808         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4809         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4810         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4811         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4812         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4813         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4814         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4815         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4816         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4817         coff-pe-read.c, command.h, compile/compile-c-support.c,
4818         compile/compile-c.h, compile/compile-cplus-symbols.c,
4819         compile/compile-cplus-types.c, compile/compile-cplus.h,
4820         compile/compile-loc2c.c, compile/compile.c, completer.c,
4821         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4822         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4823         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4824         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4825         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4826         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4827         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4828         features/aarch64-core.c, features/aarch64-fpu.c,
4829         features/aarch64-pauth.c, features/aarch64-sve.c,
4830         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4831         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4832         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4833         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4834         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4835         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4836         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4837         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4838         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4839         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4840         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4841         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4842         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4843         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4844         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4845         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4846         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4847         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4848         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4849         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4850         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4851         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4852         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4853         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4854         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4855         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4856         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4857         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4858         minsyms.c, mips-linux-tdep.c, namespace.h,
4859         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4860         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4861         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4862         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4863         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4864         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4865         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4866         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4867         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4868         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4869         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4870         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4871         procfs.c, producer.c, progspace.h, psymtab.h,
4872         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4873         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4874         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4875         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4876         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4877         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4878         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4879         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4880         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4881         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4882         target-memory.c, target.c, target.h, target/waitstatus.c,
4883         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4884         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4885         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4886         unittests/array-view-selftests.c,
4887         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4888         unittests/common-utils-selftests.c,
4889         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4890         unittests/format_pieces-selftests.c,
4891         unittests/function-view-selftests.c,
4892         unittests/lookup_name_info-selftests.c,
4893         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4894         unittests/mkdir-recursive-selftests.c,
4895         unittests/observable-selftests.c,
4896         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4897         unittests/parse-connection-spec-selftests.c,
4898         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4899         unittests/scoped_fd-selftests.c,
4900         unittests/scoped_mmap-selftests.c,
4901         unittests/scoped_restore-selftests.c,
4902         unittests/string_view-selftests.c, unittests/style-selftests.c,
4903         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4904         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4905         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4906         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4907         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4908         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4909
4910 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4913         bool value.
4914         (decode_digits_ordinary): Set explicit_line field in sal.
4915         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4916         symtab_and_line that was set on an explicit line number in
4917         assembler code.  Do always update the recorded symtab and line if
4918         we do skip the prologue.
4919
4920 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * breakpoint.c (set_breakpoint_location_function): Remove
4923         explicit_loc parameter.
4924         (momentary_breakpoint_from_master): Update call to
4925         set_breakpoint_location_function.
4926         (add_location_to_breakpoint): Likewise.
4927
4928 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4931         required features based on default bfd type when no specific bfd
4932         is present.
4933
4934 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4935
4936         * NEWS: Mention that GDB printf and eval commands can now print
4937         C-style and Ada-style convenience var strings without
4938         calling the inferior.
4939         * printcmd.c (printf_c_string): Locally print GDB internal var
4940         instead of transiting via the inferior.
4941         (printf_wide_c_string): Likewise.
4942
4943 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4944
4945         PR breakpoints/25011
4946         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4947
4948 2019-07-04  Tom Tromey  <tom@tromey.com>
4949
4950         PR tui/24724:
4951         * tui/tui-winsource.c (tui_clear_source_content): Update.
4952         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4953         (tui_update_breakpoint_info): Update.
4954         (tui_set_exec_info_content): Update.
4955         * tui/tui-source.c (tui_set_source_content_nil): Update.
4956         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4957         has_break.
4958         * tui/tui-data.h (enum tui_bp_flag): New.
4959         (tui_bp_flags): New enum flags type.
4960         (struct tui_source_element) <break_mode>: Change type.  Rename
4961         from has_break.
4962         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4963         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4964         constants.
4965         * tui/tui-winsource.h: Fix comment.
4966
4967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4968
4969         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4970         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4971         (store_fpregs_to_thread)
4972         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4973         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4974         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4975         (IWMMXT_REGS_SIZE): Add define.
4976         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4977         (fetch_vfp_regs, store_vfp_regs)
4978         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4979         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4980
4981 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4982
4983         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4984         defines.
4985         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4986         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4987         (ARM_INT_REGISTER_SIZE): ...to this.
4988         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4989         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4990         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4991         (arm_linux_collect_gregset, supply_nwfpe_register)
4992         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4993         defines.
4994         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4995         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4996         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4997         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4998         (arm_return_in_memory, arm_store_return_value)
4999         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5000         (arm_record_ld_st_multiple): Likewise.
5001         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5002         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5003
5004 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5005
5006         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5007         AARCH64_DISPLACED_MODIFIED_INSNS.
5008         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5009         (aarch64_displaced_step_copy_insn): Likewise.
5010         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5011         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5012         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5013         ARM_DISPLACED_MODIFIED_INSNS.
5014         * arm-tdep.c (arm_gdbarch_init): Likewise.
5015         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5016         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5017         (struct arm_displaced_step_closure): Use
5018         ARM_DISPLACED_MODIFIED_INSNS.
5019
5020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5021
5022         * features/Makefile: Remove unused xml files.
5023         * features/aarch64.xml: Remove.
5024         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5025         * features/i386/amd64-avx-avx512.xml: Remove.
5026         * features/i386/amd64-avx-linux.xml: Remove.
5027         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5028         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5029         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5030         * features/i386/amd64-avx-mpx.xml: Remove.
5031         * features/i386/amd64-avx.xml: Remove.
5032         * features/i386/amd64-linux.xml: Remove.
5033         * features/i386/amd64-mpx-linux.xml: Remove.
5034         * features/i386/amd64-mpx.xml: Remove.
5035         * features/i386/amd64.xml: Remove.
5036         * features/i386/i386-avx-avx512-linux.xml: Remove.
5037         * features/i386/i386-avx-avx512.xml: Remove.
5038         * features/i386/i386-avx-linux.xml: Remove.
5039         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5040         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5041         * features/i386/i386-avx-mpx-linux.xml: Remove.
5042         * features/i386/i386-avx-mpx.xml: Remove.
5043         * features/i386/i386-avx.xml: Remove.
5044         * features/i386/i386-linux.xml: Remove.
5045         * features/i386/i386-mmx-linux.xml: Remove.
5046         * features/i386/i386-mmx.xml: Remove.
5047         * features/i386/i386-mpx-linux.xml: Remove.
5048         * features/i386/i386-mpx.xml: Remove.
5049         * features/i386/i386.xml: Remove.
5050         * features/i386/x32-avx-avx512-linux.xml: Remove.
5051         * features/i386/x32-avx-linux.xml: Remove.
5052         * features/i386/x32-linux.xml: Remove.
5053
5054 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5055
5056         * regformats/aarch64.dat: Remove.
5057         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5058         * regformats/i386/amd64-avx-linux.dat: Remove.
5059         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5060         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5061         * regformats/i386/amd64-linux.dat: Remove.
5062         * regformats/i386/amd64-mpx-linux.dat: Remove.
5063         * regformats/i386/amd64.dat: Remove.
5064         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5065         * regformats/i386/i386-avx-linux.dat: Remove.
5066         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5067         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5068         * regformats/i386/i386-linux.dat: Remove.
5069         * regformats/i386/i386-mmx-linux.dat: Remove.
5070         * regformats/i386/i386-mpx-linux.dat: Remove.
5071         * regformats/i386/i386.dat: Remove.
5072         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5073         * regformats/i386/x32-avx-linux.dat: Remove.
5074         * regformats/i386/x32-linux.dat: Remove.
5075
5076 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5077
5078         * aarch64-tdep.c: Remove xml self tests.
5079         * amd64-linux-tdep.c: Likewise.
5080         * amd64-tdep.c: Likewise.
5081         * i386-linux-tdep.c: Likewise.
5082         * i386-tdep.c: Likewise.
5083
5084 2019-07-03  Pedro Alves  <palves@redhat.com>
5085
5086         PR cli/24732
5087         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5088         (pipe_cmd_option_defs): New.
5089         (make_pipe_cmd_options_def_group): New.
5090         (pipe_command): Use gdb::option::process_options.
5091         (pipe_command_completer): New function.
5092         (_initialize_cli_cmds): Install completer for "pipe" command.
5093
5094 2019-07-03  Pedro Alves  <palves@redhat.com>
5095
5096         * cli/cli-option.c (union option_value) <string>: New field.
5097         (struct option_def_and_value): Add ctor, move ctor, dtor and
5098         use DISABLE_COPY_AND_ASSIGN.
5099         (option_def_and_value::clear_value): New.
5100         (parse_option, save_option_value_in_ctx, get_val_type_str)
5101         (add_setshow_cmds_for_options): Handle var_string.
5102         * cli-option.h (union option_def::var_address) <string>: New
5103         field.
5104         (struct string_option_def): New.
5105         * maint-test-options.c (struct test_options_opts): Add default
5106         ctor and use DISABLE_COPY_AND_ASSIGN.
5107         <string_opt>: New field.
5108         (test_options_opts::~test_options_opts): New.
5109         (test_options_opts::dump): Also dump "-string".
5110         (test_options_option_defs): Install "string.
5111
5112 2019-07-03  Pedro Alves  <palves@redhat.com>
5113
5114         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5115         option_value with a null enumeration.
5116         (complete_options): Save the option values in the context.
5117         (save_option_value_in_ctx): New, factored out from ...
5118         (process_options): ... here.
5119         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5120         of the function.
5121         * maint-test-options.c (test_options_opts::dump): New, factored
5122         out from ...
5123         (maintenance_test_options_command_mode): ... here.
5124         (maintenance_test_options_command_completion_result): Delete.
5125         (maintenance_test_options_command_completion_text): Update
5126         comment.
5127         (maintenance_show_test_options_completion_result): Change
5128         prototype.  Just print
5129         maintenance_test_options_command_completion_text.
5130         (save_completion_result): New.
5131         (maintenance_test_options_completer_mode): Pass options context to
5132         complete_options, and then save a dump.
5133         (_initialize_maint_test_options): Use add_cmd to install "maint
5134         show test-options-completion-result".
5135
5136 2019-07-03  Pedro Alves  <palves@redhat.com>
5137
5138         * NEWS (New commands): Mention "with" and "maint with".
5139         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5140         (with_command, with_command_completer): New.
5141         (pipe_command): Adjust to new repeat_previous
5142         interface.
5143         (_initialize_cli_cmds): Install the "with" command and its "w"
5144         alias.
5145         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5146         declarations.
5147         * cli/cli-setshow.c (parse_cli_var_uinteger)
5148         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5149         argument strings for all var_types.
5150         (get_setshow_command_value_string): New, factored out from ...
5151         (do_show_command): ... this.
5152         * cli/cli-setshow.h: Include <string>.
5153         (get_setshow_command_value_string): Declare.
5154         * command.h (repeat_previous): Now returns const char *.  Adjust
5155         comment.
5156         * maint.c: Include "cli/cli-cmds.h".
5157         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5158         (_initialize_maint_cmds): Register the "maintenance with" command.
5159         * top.c (repeat_previous): Move bits from pipe_command here:
5160         Return the saved command line, if any; error out if there's no
5161         command to relaunch.
5162
5163 2019-07-03  Pedro Alves  <palves@redhat.com>
5164
5165         * NEWS (New commands): Mention "maint set/show test-settings"
5166         instead of "maint test-settings".
5167         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5168         (maintenance_test_settings_set_list): Rename to ...
5169         (maintenance_set_test_settings_list): ... this.
5170         (maintenance_test_settings_show_list): Rename to  ...
5171         (maintenance_show_test_settings_list): ... this.
5172         (maintenance_test_settings_cmd): Delete.
5173         (maintenance_test_settings_set_cmd): ...
5174         (maintenance_set_test_settings_cmd): ... this.
5175         (maintenance_test_settings_show_cmd): ...
5176         (maintenance_show_test_settings_cmd): ... this.
5177         (maintenance_test_settings_show_value_cmd):
5178         (maintenance_show_test_settings_value_cmd): ... this.
5179         (_initialize_maint_test_settings): No longer install the "maint
5180         test-settings" prefix command.  Rename "maint test-settings set"
5181         to "maint set test-settings", and "maint test-settings show" to
5182         "maint show test-settings".  Adjust all subcommands.
5183
5184 2019-07-03  Pedro Alves  <palves@redhat.com>
5185
5186         * maint-test-settings.c: Fix file's intro comment.  Replace all
5187         references to "test-options" with references to "test-settings",
5188         in comments.
5189
5190 2019-07-03  Pedro Alves  <palves@redhat.com>
5191
5192         * maint-test-settings.c (maintenance_test_settings_xxx)
5193         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5194         New.
5195         (maintenance_test_settings_enums): Use them.
5196         (maintenance_test_settings_enum): Default to
5197         maintenance_test_settings_xxx.
5198         (_initialize_maint_test_settings): Initialize
5199         MAINTENANCE_TEST_SETTINGS_FILENAME.
5200
5201 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5202
5203         * breakpoint.h (remove_breakpoints_inf): Change return type to
5204         void, move function documentation here.
5205         * breakpoint.c (remove_breakpoints_inf): Change return type to
5206         void, move function documentation to header.
5207
5208 2019-07-02  Pedro Alves  <palves@redhat.com>
5209
5210         * NEWS (Completion improvements): Mention "info threads".
5211         * thread.c (struct info_threads_opts, info_threads_option_defs)
5212         (make_info_threads_options_def_group): New.
5213         (info_threads_command): Use gdb::option::process_options.
5214         (info_threads_command_completer): New.
5215         (_initialize_thread): Use gdb::option::build_help to build the
5216         help text for "info threads".
5217
5218 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5219
5220         * defs.h (generic_load): Move from here...
5221         * symfile.h (generic_load): ... to here.  Rename name parameter
5222         to args.
5223         * symfile.c (generic_load): Add comment.
5224
5225 2019-07-01  Tom Tromey  <tromey@adacore.com>
5226
5227         * dwarf2read.c
5228         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5229         declaration of without_params.  Fix formatting.
5230
5231 2019-07-01  Tom Tromey  <tromey@adacore.com>
5232
5233         * ada-exp.y (find_primitive_type): Update.
5234         * ada-lang.h (ada_lookup_symbol): Update.
5235         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5236         parameter.
5237         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5238
5239 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5240
5241         PR breakpoints/24541
5242         * gdbarch.c: Regenerate.
5243         * gdbarch.h: Regenerate.
5244         * gdbarch.sh: Add 'stap_adjust_register'.
5245         * i386-tdep.c: Include '<unordered_set>'.
5246         (i386_stap_adjust_register): New function.
5247         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5248         * stap-probe.c (stap_parse_register_operand): Call
5249         'gdbarch_stap_adjust_register'.
5250
5251 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5252
5253         PR python/24742
5254         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5255         * python/python.c (do_start_initialization): Use 'xmalloc'
5256         instead of 'PyMem_Malloc'.
5257
5258 2019-06-28  Tom Tromey  <tromey@adacore.com>
5259
5260         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5261         for Ada.
5262
5263 2019-06-27  Tom Tromey  <tromey@adacore.com>
5264
5265         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5266         objfile_key.
5267         (arm_find_mapping_symbol, arm_record_special_symbol)
5268         (_initialize_arm_tdep): Update.
5269         (arm_objfile_data_free): Remove.
5270
5271 2019-06-27  Tom Tromey  <tromey@adacore.com>
5272
5273         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5274         to cp_print_static_field.
5275
5276 2019-06-26  Tom Tromey  <tromey@adacore.com>
5277
5278         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5279         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5280         declare.
5281
5282 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5283
5284         * features/aarch64-core.c (create_feature_aarch64_core):
5285         Regenerate.
5286         * features/aarch64-core.xml: Add cpsr flags.
5287
5288 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5289
5290         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5291         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5292
5293 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5294
5295         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5296         field.
5297         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5298         use.
5299         (arm_record_special_symbol): Don't insert new symbol in sorted
5300         position, push it at the end.
5301
5302 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5303
5304         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5305         (arm_mapping_symbol_s): Remove.
5306         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5307         (arm_mapping_symbol_vec): New typedef.
5308         (struct arm_per_objfile): Add constructor.
5309         <section_maps>: Change type to
5310         std::unique_ptr<arm_mapping_symbol_vec[]>.
5311         (arm_compare_mapping_symbols): Remove.
5312         (arm_find_mapping_symbol): Adjust to section_maps type change.
5313         (arm_objfile_data_free): Call delete on arm_per_objfile.
5314         (arm_record_special_symbol): Adjust to section_maps type change.
5315         Allocate arm_per_objfile with new.
5316
5317 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5318
5319         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5320         with the command prefix.
5321
5322 2019-06-25  Tom Tromey  <tom@tromey.com>
5323
5324         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5325         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5326
5327 2019-06-25  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5330         type.
5331         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5332         protected.
5333
5334 2019-06-25  Tom Tromey  <tom@tromey.com>
5335
5336         * tui/tui-winsource.c
5337         (tui_source_window_base::set_is_exec_point_at): Add check against
5338         LOA_ADDRESS.
5339
5340 2019-06-25  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-source.c (tui_set_source_content): Don't check before
5343         xfree.
5344         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-winsource.h (tui_update_source_window_as_is)
5349         (tui_alloc_source_buffer, tui_line_is_displayed)
5350         (tui_addr_is_displayed): Change type of win_info.
5351         * tui/tui-winsource.c (tui_update_source_window_as_is)
5352         (tui_clear_source_content, tui_show_source_line)
5353         (tui_show_source_content, tui_source_window_base::refill)
5354         (tui_source_window_base::set_is_exec_point_at)
5355         (tui_source_window_base::set_is_exec_point_at)
5356         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5357         (tui_alloc_source_buffer, tui_line_is_displayed)
5358         (tui_addr_is_displayed): Change type of win_info.  Update.
5359         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5360         (tui_source_window_base::do_make_visible_with_new_height):
5361         Update.
5362         * tui/tui-source.c (tui_set_source_content)
5363         (tui_set_source_content_nil)
5364         (tui_source_window::do_scroll_vertical): Update.
5365         * tui/tui-layout.c (show_layout): Update.
5366         * tui/tui-disasm.c (tui_set_disassem_content)
5367         (tui_disasm_window::do_scroll_vertical): Update.
5368         * tui/tui-data.h (tui_win_content): Remove.
5369         (struct tui_gen_win_info) <content, content_size>: Remove.
5370         (struct tui_source_element): Add initializers and destructor.
5371         (union tui_which_element, struct tui_win_element): Remove.
5372         (struct tui_source_window_base) <content>: New field.
5373         (struct tui_data_window): Remove destructor.
5374         (tui_alloc_content, tui_free_win_content)
5375         (tui_free_all_source_wins_content): Don't declare.
5376         * tui/tui-data.c (tui_initialize_static_data): Update.
5377         (init_content_element, tui_alloc_content): Remove.
5378         (~tui_gen_win_info): Update.
5379         (~tui_data_window, tui_free_all_source_wins_content)
5380         (tui_free_win_content, free_content, free_content_elements):
5381         Remove.
5382
5383 2019-06-25  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-winsource.h (tui_clear_source_content)
5386         (tui_erase_source_content, tui_show_source_content): Change type
5387         of win_info.
5388         * tui/tui-winsource.c (tui_clear_source_content)
5389         (tui_erase_source_content, tui_show_source_content): Change type
5390         of win_info.
5391         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5392         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5393         win_info.
5394         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5395         win_info.
5396         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5397
5398 2019-06-25  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-winsource.c (tui_clear_source_content)
5401         (tui_source_window_base::set_is_exec_point_at): Update.
5402         * tui/tui-source.c (tui_set_source_content_nil): Update.
5403         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5404         a bool.
5405         * tui/tui-data.c (init_content_element): Update.
5406
5407 2019-06-25  Tom Tromey  <tom@tromey.com>
5408
5409         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5410         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5411         * tui/tui-layout.c (init_and_make_win): Update.
5412         * tui/tui.h (enum tui_win_type): Update.
5413         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5414         tui_win_is_auxillary.
5415         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5416         tui_win_is_auxillary.
5417
5418 2019-06-25  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5421         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5422         (tui_delete_data_content_windows, tui_display_all_data)
5423         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5424         Update.
5425         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5426         * tui/tui-regs.c (tui_last_regs_line_no)
5427         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5428         (tui_show_registers): Update.
5429         (tui_show_register_group): Return void.  Update.
5430         (tui_display_registers_from, tui_display_reg_element_at_line)
5431         (tui_display_registers_from_line, tui_check_register_values):
5432         Update.
5433         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5434         member.
5435         (struct tui_data_window) <regs_content>: Now a std::vector.
5436         <regs_content_count>: Remove.
5437         (tui_add_content_elements, tui_free_data_content): Don't declare.
5438         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5439         (init_content_element): Remove DATA_WIN case.  Add assert.
5440         (tui_add_content_elements): Remove.
5441         (tui_data_window): Update.
5442         (tui_free_data_content): Remove.
5443         (free_content_elements): Remove DATA_WIN case.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-data.c (tui_data_item_window): Update.
5448         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5449         * tui/tui-windata.c (tui_display_all_data)
5450         (tui_display_data_from_line): Update.
5451         (tui_check_data_values): Remove.
5452         * tui/tui-regs.c (tui_show_register_group)
5453         (tui_display_reg_element_at_line): Update.
5454         * tui/tui-hooks.c (tui_register_changed)
5455         (tui_refresh_frame_and_register_information): Call
5456         tui_check_register_values.
5457         * tui/tui-data.h (struct tui_data_window) <data_content,
5458         data_content_count, data_type>: Remove.
5459         (enum tui_data_type): Remove.
5460
5461         * tui/tui-data.c (tui_data_window::clear_detail)
5462         (~tui_data_window): Update.
5463
5464 2019-06-25  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5467         declare.
5468         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5469         Rename from tui_first_data_item_displayed.  Update.
5470         (tui_data_window::refresh_all)
5471         (tui_data_window::do_scroll_vertical): Update.
5472         * tui/tui-data.h (struct tui_data_window)
5473         <first_data_item_displayed>: Declare new method.
5474
5475 2019-06-25  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5478         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5479         contents...
5480         (tui_initialize_static_data): ...here.
5481
5482 2019-06-25  Tom Tromey  <tom@tromey.com>
5483
5484         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5485         (tui_display_registers_from, tui_check_register_values): Update.
5486         (tui_display_register): Remove win_info parameter; update.
5487         (tui_get_register): Change type of parameters.
5488         * tui/tui-data.h (struct tui_data_element): Remove.
5489         (union tui_which_element) <data>: Remove.
5490         <data_window>: Change type.
5491         (struct tui_data_item_window): New.
5492         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5493         case.  Add assert.
5494         (~tui_data_item_window): New destructor.
5495         (free_content_elements): Remove DATA_ITEM_WIN case.
5496
5497 2019-06-25  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5500         Remove.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-data.h (struct tui_command_element): Remove.
5505         (union tui_which_element) <command>: Remove.
5506         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5507         assert.
5508         (free_content_elements): Remove CMD_WIN case.
5509
5510 2019-06-25  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-layout.c (tui_set_layout): Update.
5513         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5514         * tui/tui-data.c (layout_def): Update.
5515
5516 2019-06-25  Tom Tromey  <tom@tromey.com>
5517
5518         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5519         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5520         (tui_source_window_base::set_new_height): Update.
5521         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5522         Update.
5523         (tui_set_locator_fullname, tui_set_locator_info)
5524         (tui_show_frame_info): Update.
5525         * tui/tui-source.c (tui_set_source_content)
5526         (tui_source_is_displayed): Update.
5527         * tui/tui-layout.c (show_source_disasm_command, show_data)
5528         (show_source_or_disasm_and_command): Update.
5529         * tui/tui-disasm.c (tui_set_disassem_content)
5530         (tui_get_begin_asm_address): Update.
5531         * tui/tui-data.h (struct tui_locator_element): Remove.
5532         (union tui_which_element) <locator>: Remove.
5533         (struct tui_locator_window): New.
5534         (tui_locator_win_info_ptr): Change return type.
5535         * tui/tui-data.c (_locator): Change type.
5536         (tui_locator_win_info_ptr): Change return type.
5537         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5538         (tui_alloc_content): Add assert.
5539
5540 2019-06-25  Tom Tromey  <tom@tromey.com>
5541
5542         * tui/tui-winsource.c
5543         (tui_exec_info_window::maybe_allocate_content): New method.
5544         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5545         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5546         (make_source_or_disasm_window): Add cast.
5547         * tui/tui-data.h (union tui_which_element) <simple_string>:
5548         Remove.
5549         (struct tui_source_info): New.
5550         (struct tui_source_window_base) <execution_info>: Change type.
5551         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5552         case, and add assert.
5553         (tui_alloc_content): Add assert.
5554
5555 2019-06-25  Tom Tromey  <tom@tromey.com>
5556
5557         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5558         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5559         * tui/tui-data.c (tui_alloc_win_info): Remove.
5560
5561 2019-06-25  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5564         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5565         can_highlight.
5566
5567 2019-06-25  Tom Tromey  <tom@tromey.com>
5568
5569         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5570         make_visible_with_new_height method.
5571         (tui_win_info::make_visible_with_new_height): New method.
5572         (tui_source_window_base::do_make_visible_with_new_height)
5573         (tui_data_window::do_make_visible_with_new_height)
5574         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5575         (make_visible_with_new_height): Remove.
5576         (tui_resize_all, tui_adjust_win_heights): Use
5577         make_visible_with_new_height method.
5578         * tui/tui-data.h (struct tui_win_info)
5579         <do_make_visible_with_new_height, make_visible_with_new_height>:
5580         New methods.
5581         (struct tui_source_window_base, struct tui_data_window)
5582         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5583         methods.
5584
5585 2019-06-25  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5588         method.
5589         (update_tab_width): Call update_tab_width method.
5590         * tui/tui-data.h (struct tui_win_info)
5591         (struct tui_source_window_base) <update_tab_width>: New methods.
5592
5593 2019-06-25  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5596         parameter.
5597         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5598         parameter.
5599         (tui_gen_win_info::make_visible): Update.
5600         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5601         parameter.
5602         * tui/tui-data.h (enum tui_box): New enum.
5603         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5608         init_and_make_win for EXEC_INFO_WIN.
5609         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5610         longer inline.
5611         (struct tui_win_info) <~tui_win_info>: Inline.
5612         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5613         Don't declare.
5614         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5615         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5616         Remove.
5617         (tui_initialize_static_data): Update.
5618         (~tui_gen_win_info): Handle more cleanup here.
5619         (~tui_source_window_base): Delete "execution_info".
5620         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5621
5622 2019-06-25  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-layout.c (make_command_window): Don't set
5625         can_highlight.
5626         (show_source_disasm_command): Call the reset method.
5627         (show_data): Don't set can_highlight.  Call the reset method.
5628         (tui_gen_win_info::reset): Rename from init_gen_win_info
5629         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5630         (show_source_or_disasm_and_command): Call the reset method.
5631         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5632         (struct tui_cmd_window): Set can_highlight.
5633
5634 2019-06-25  Tom Tromey  <tom@tromey.com>
5635
5636         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5637         from make_visible.
5638         (tui_make_visible, tui_make_invisible): Rewrite.
5639         (tui_win_info::make_visible): Remove.
5640         (tui_source_window_base::make_visible): Update.
5641         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5642         method.  Moved from...
5643         (struct tui_win_info) <make_visible>: ...here.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-winsource.c
5648         (tui_source_window_base::do_scroll_horizontal): Remove direction
5649         parameter.
5650         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5651         direction parameter.
5652         * tui/tui-win.c (tui_win_info::forward_scroll)
5653         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5654         (tui_win_info::right_scroll): Update.
5655         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5656         direction parameter.
5657         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5658         direction parameter.
5659         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5660         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5661         Remove direction parameter.
5662         (struct tui_source_window_base, struct tui_source_window)
5663         (struct tui_disasm_window, struct tui_data_window)
5664         (struct tui_cmd_window): Update.
5665
5666 2019-06-25  Tom Tromey  <tom@tromey.com>
5667
5668         * tui/tui-winsource.h (tui_set_exec_info_content)
5669         (tui_show_exec_info_content, tui_erase_exec_info_content)
5670         (tui_clear_exec_info_content, tui_update_exec_info): Change
5671         argument to tui_source_window_base.
5672         * tui/tui-winsource.c (tui_set_exec_info_content)
5673         (tui_show_exec_info_content, tui_erase_exec_info_content)
5674         (tui_clear_exec_info_content, tui_update_exec_info): Change
5675         argument to tui_source_window_base.
5676
5677 2019-06-25  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5680         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5681
5682 2019-06-25  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5685         check.
5686
5687 2019-06-25  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5690         type to void.
5691         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5692         type to void.
5693         * tui/tui-source.c (tui_set_source_content): Update.
5694         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5695
5696 2019-06-25  Tom Tromey  <tom@tromey.com>
5697
5698         * tui/tui-win.c (window_name_completer, tui_set_focus)
5699         (tui_all_windows_info): Use name method.
5700         * tui/tui-data.h (struct tui_gen_win_info)
5701         (struct tui_source_window, struct tui_disasm_window)
5702         (struct tui_data_window, struct tui_cmd_window) <name>: New
5703         method.
5704         (tui_win_name): Don't declare.
5705         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5706         (tui_win_name): Remove.
5707
5708 2019-06-25  Tom Tromey  <tom@tromey.com>
5709
5710         * tui/tui-winsource.h (tui_update_source_window)
5711         (tui_update_source_window_as_is): Change parameter type.
5712         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5713         to be a tui_source_window_base.
5714         (tui_update_source_window_as_is): Likewise.
5715         * tui/tui-win.c (make_visible_with_new_height): Update.
5716
5717 2019-06-25  Tom Tromey  <tom@tromey.com>
5718
5719         * tui/tui-winsource.c (tui_erase_source_content)
5720         (tui_show_source_content, tui_show_exec_info_content)
5721         (tui_erase_exec_info_content): Use refresh_window method.
5722         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5723         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5724         from tui_refresh_win.
5725         (tui_data_window::refresh_window): New method.
5726         (tui_win_info::refresh, tui_source_window_base::refresh)
5727         (tui_refresh_all): Use refresh_window method.
5728         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5729         method.
5730         * tui/tui-regs.c (tui_display_register): Call refresh_window
5731         method.
5732         * tui/tui-layout.c (show_source_disasm_command)
5733         (show_source_or_disasm_and_command): Call refresh_window method.
5734         * tui/tui-data.h (struct tui_gen_win_info)
5735         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5736         New method.
5737
5738 2019-06-25  Tom Tromey  <tom@tromey.com>
5739
5740         * tui/tui.c (tui_rl_other_window, tui_enable)
5741         (tui_is_window_visible, tui_get_command_dimension): Update.
5742         * tui/tui-winsource.c (tui_update_source_window_as_is)
5743         (tui_clear_source_content, tui_erase_source_content)
5744         (tui_show_source_line, tui_source_window_base::refill)
5745         (tui_source_window_base::do_scroll_horizontal)
5746         (tui_source_window_base::set_is_exec_point_at)
5747         (tui_update_breakpoint_info, tui_set_exec_info_content)
5748         (tui_alloc_source_buffer, tui_line_is_displayed)
5749         (tui_addr_is_displayed): Update.
5750         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5751         (tui_check_and_display_highlight_if_needed)
5752         (tui_win_info::make_visible, tui_win_info::refresh)
5753         (tui_refresh_all): Update.
5754         * tui/tui-windata.c (tui_first_data_item_displayed)
5755         (tui_delete_data_content_windows, tui_erase_data_content)
5756         (tui_display_all_data, tui_data_window::refresh_all)
5757         (tui_check_data_values): Update.
5758         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5759         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5760         (tui_win_info::backward_scroll, tui_refresh_all_win)
5761         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5762         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5763         (tui_source_window_base::set_new_height)
5764         (tui_data_window::set_new_height)
5765         (make_invisible_and_set_new_height)
5766         (make_visible_with_new_height, new_height_ok)
5767         (parse_scrolling_args): Update.
5768         * tui/tui-stack.c (tui_show_frame_info): Update.
5769         * tui/tui-source.c (tui_set_source_content)
5770         (tui_set_source_content_nil, tui_source_is_displayed)
5771         (tui_source_window::do_scroll_vertical): Update.
5772         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5773         (tui_display_registers_from, tui_display_reg_element_at_line)
5774         (tui_check_register_values, tui_reg_command): Update.
5775         * tui/tui-layout.c (tui_default_win_height)
5776         (show_source_disasm_command, show_data, init_and_make_win)
5777         (show_source_or_disasm_and_command): Update.
5778         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5779         (tui_redisplay_readline, tui_mld_flush)
5780         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5781         (tui_getc): Update.
5782         * tui/tui-disasm.c (tui_set_disassem_content)
5783         (tui_disasm_window::do_scroll_vertical): Update.
5784         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5785         Now virtual.
5786         (struct tui_win_info): Derive from tui_gen_win_info.
5787         <~tui_win_info>: Mark as override.
5788         <generic>: Remove member.
5789         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5790         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5791         (~tui_data_window, ~tui_win_info)
5792         (tui_free_all_source_wins_content): Update.
5793         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-layout.c (init_and_make_win): Use new.
5798         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5799         destructor, initializers.
5800         (tui_alloc_generic_win_info): Don't declare.
5801         * tui/tui-data.c (_locator): Add argument to constructor.
5802         (source_win, disasm_win): New globals.
5803         (exec_info): Remove.
5804         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5805         Update.
5806         (tui_alloc_generic_win_info): Remove.
5807         (init_content_element): Use new.
5808         (tui_win_info::tui_win_info): Update.
5809         (free_content_elements) <case DATA_WIN>: Use delete.
5810
5811 2019-06-25  Tom Tromey  <tom@tromey.com>
5812
5813         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5814         * tui/tui-windata.c (tui_first_data_item_displayed)
5815         (tui_delete_data_content_windows): Update.
5816         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5817         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5818         (tui_display_registers_from, tui_check_register_values): Update.
5819         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5820         pointer.
5821         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5822         window.
5823         (tui_free_data_content): Update.
5824         (free_content_elements) <case DATA_WIN>: Free the window.
5825
5826 2019-06-25  Tom Tromey  <tom@tromey.com>
5827
5828         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5829         Update.
5830         * tui/tui-layout.c (make_command_window)
5831         (show_source_disasm_command, show_data, init_and_make_win)
5832         (show_source_or_disasm_and_command): Update.
5833         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5834         method.
5835         <can_highight, is_highlighted>: Now bool.
5836         (tui_set_win_highlight): Don't declare.
5837         * tui/tui-data.c (tui_set_win_highlight): Remove.
5838
5839 2019-06-25  Tom Tromey  <tom@tromey.com>
5840
5841         * tui/tui-wingeneral.c (make_visible): Remove check of window
5842         type.
5843
5844 2019-06-25  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-win.c (tui_win_info::max_height)
5847         (tui_cmd_window::max_height): New methods.
5848         (new_height_ok): Call max_height.
5849         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5850         <max_height>: New method.
5851
5852 2019-06-25  Tom Tromey  <tom@tromey.com>
5853
5854         * tui/tui-win.c (tui_source_window_base::set_new_height)
5855         (tui_data_window::set_new_height): New methods.
5856         (make_invisible_and_set_new_height): Call set_new_height method.
5857         * tui/tui-data.h (struct tui_win_info)
5858         (struct tui_source_window_base, struct tui_data_window)
5859         <set_new_height>: New method.
5860
5861 2019-06-25  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5864         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5865         tui_refresh_data_win.
5866         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5867         method.
5868         (tui_refresh_all_win): Call the refresh_all method.
5869         (tui_set_focus): Likewise.
5870         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5871         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5872         Likewise.
5873
5874 2019-06-25  Tom Tromey  <tom@tromey.com>
5875
5876         * tui/tui-winsource.h (tui_refill_source_window)
5877         (tui_set_is_exec_point_at): Don't declare.
5878         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5879         (tui_source_window_base::refill): Rename from
5880         tui_refill_source_window.
5881         (tui_source_window_base::do_scroll_horizontal): Update.
5882         (tui_source_window_base::set_is_exec_point_at): Rename from
5883         tui_set_is_exec_point_at.
5884         (tui_update_all_breakpoint_info): Update.
5885         * tui/tui-stack.c (tui_show_frame_info): Update.
5886         * tui/tui-layout.c (show_data): Add cast.
5887         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5888         * tui/tui-data.h (struct tui_source_window_base) <refill,
5889         set_is_exec_point_at>: New methods.
5890         (tui_source_windows, tui_add_to_source_windows): Update types.
5891         (tui_add_to_source_windows): Remove redundant declaration.
5892         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5893         (tui_source_windows): Change return type.
5894         (tui_clear_source_windows_detail): Update.
5895         (tui_add_to_source_windows): Change type of parameter.
5896         (tui_free_all_source_wins_content): Update.
5897
5898 2019-06-25  Tom Tromey  <tom@tromey.com>
5899
5900         * tui/tui-wingeneral.c (tui_win_info::refresh)
5901         (tui_source_window_base::refresh): New methods.
5902         (tui_refresh_all): Call the refresh method.
5903         * tui/tui-data.h (struct tui_win_info)
5904         (struct tui_source_window_base) <refresh>: New method.
5905
5906 2019-06-25  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui.h (tui_is_window_visible): Return bool.
5909         * tui/tui.c (tui_is_window_visible): Return bool.
5910         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5911         (tui_make_visible, tui_make_invisible)
5912         (tui_win_info::make_visible)
5913         (tui_source_window_base::make_visible, make_all_visible)
5914         (tui_make_all_visible, tui_make_all_invisible): Update.
5915         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5916         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5917         bool.
5918         (struct tui_win_info, struct tui_source_window_base)
5919         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5920         * tui/tui-data.c (tui_init_generic_part): Update.
5921
5922 2019-06-25  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5925         (tui_source_window_base::make_visible): New methods.
5926         (make_all_visible): Make method call.
5927         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5928         (struct tui_source_window_base, struct tui_cmd_window): Override
5929         make_visible.
5930         (tui_win_is_source_type): Don't declare.
5931         * tui/tui-data.c (tui_win_is_source_type): Remove.
5932
5933 2019-06-25  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5936         NULL check.
5937
5938 2019-06-25  Tom Tromey  <tom@tromey.com>
5939
5940         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5941         Inline constructor.  Add initializers for members.
5942         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5943         constructors; now inline in class.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-regs.c (tui_show_registers): Update.
5948         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5949         bool.
5950         * tui/tui-data.c (tui_data_window::clear_detail)
5951         (tui_data_window): Update.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-windata.c (tui_display_all_data)
5956         (tui_display_data_from_line, tui_display_data_from)
5957         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5958         Update.
5959         * tui/tui-regs.c (tui_last_regs_line_no)
5960         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5961         (tui_show_registers, tui_show_register_group)
5962         (tui_display_registers_from, tui_display_reg_element_at_line)
5963         (tui_display_registers_from_line, tui_check_register_values)
5964         (tui_reg_next, tui_reg_prev): Update.
5965         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5966         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5967         tui_data_window.
5968         (struct tui_win_info) <detail>: Remove.  Add new fields from
5969         tui_data_info.
5970         (TUI_DATA_WIN): Add cast.
5971         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5972         (~tui_data_window): Simplify.
5973
5974 2019-06-25  Tom Tromey  <tom@tromey.com>
5975
5976         * tui/tui-layout.c (show_source_disasm_command)
5977         (show_source_or_disasm_and_command): Update.
5978         * tui/tui-io.c (update_cmdwin_start_line)
5979         (tui_redisplay_readline): Update.
5980         * tui/tui-data.h (struct tui_command_info): Remove.
5981         (struct tui_win_info) <detail>: Remove command_info member.
5982         (struct tui_data_window) <start_line>: New member, from
5983         tui_command_info.
5984         (TUI_CMD_WIN): Add casts.
5985
5986 2019-06-25  Tom Tromey  <tom@tromey.com>
5987
5988         * tui/tui-winsource.c (tui_update_source_window)
5989         (tui_refill_source_window)
5990         (tui_source_window_base::do_scroll_horizontal)
5991         (tui_update_breakpoint_info, tui_set_exec_info_content)
5992         (tui_show_exec_info_content, tui_erase_exec_info_content)
5993         (tui_clear_exec_info_content): Update.
5994         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5995         Update.
5996         * tui/tui-win.c (make_invisible_and_set_new_height)
5997         (make_visible_with_new_height): Update.
5998         * tui/tui-source.c (tui_set_source_content)
5999         (tui_show_symtab_source): Update.
6000         * tui/tui-layout.c (extract_display_start_addr)
6001         (show_source_disasm_command, show_data)
6002         (make_source_or_disasm_window)
6003         (show_source_or_disasm_and_command): Update.
6004         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6005         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6006         "gdbarch".
6007         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6008         to tui_source_window_base.
6009         (struct tui_win_info) <detail>: Remove source_info member.
6010         (struct tui_source_window_base) <has_locator>: Inline.
6011         Move contents from tui_source_info; rename has_locator member to
6012         m_has_locator.
6013         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6014         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6015         header file.
6016         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6017         Simplify.
6018         (tui_free_all_source_wins_content): Cast to
6019         tui_source_window_base.
6020
6021 2019-06-25  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-win.c (make_invisible_and_set_new_height)
6024         (make_visible_with_new_height): Call has_locator method.
6025         * tui/tui-layout.c (show_source_disasm_command, show_data)
6026         (show_source_or_disasm_and_command): Update for bool change.
6027         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6028         (tui_win_info) <has_locator>: New method.
6029         (struct tui_source_window_base) <has_locator>: New method.
6030         (tui_win_has_locator): Don't declare.
6031         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6032         from tui_win_has_locator.
6033         (tui_source_window_base): Use false, not FALSE.
6034
6035 2019-06-25  Tom Tromey  <tom@tromey.com>
6036
6037         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6038         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6039         clear_detail method directly.
6040         (tui_clear_win_detail): Remove.
6041
6042 2019-06-25  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6045         "this", not TUI_DISASM_WIN.
6046
6047 2019-06-25  Tom Tromey  <tom@tromey.com>
6048
6049         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6050         declare.
6051         * tui/tui-winsource.c
6052         (tui_source_window_base::do_scroll_horizontal): Rename from
6053         tui_horizontal_source_scroll.
6054         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6055         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6056         from tui_vertical_data_scroll.
6057         * tui/tui-win.h (tui_scroll): Don't declare.
6058         * tui/tui-win.c (tui_win_info::forward_scroll)
6059         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6060         (tui_win_info::right_scroll): Rename and update.
6061         (tui_scroll_forward_command, tui_scroll_backward_command)
6062         (tui_scroll_left_command, tui_scroll_right_command): Update.
6063         (tui_scroll): Remove.
6064         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6065         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6066         from tui_vertical_source_scroll.
6067         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6068         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6069         from tui_vertical_disassem_scroll.
6070         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6071         do_scroll_horizontal>: New methods.
6072         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6073         Likewise.
6074         (struct tui_source_window_base): Add do_scroll_horizontal.
6075         (struct tui_source_window, struct tui_disasm_window): Add
6076         do_scroll_vertical.
6077         (struct tui_data_window, struct tui_cmd_window): Add
6078         do_scroll_horizontal and do_scroll_vertical.
6079         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6080
6081 2019-06-25  Tom Tromey  <tom@tromey.com>
6082
6083         * tui/tui-data.h (struct tui_source_window_base): New struct.
6084         (struct tui_source_window): Derive from tui_source_window_base.
6085         (struct tui_disasm_window): New struct.
6086         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6087         from tui_source_window::clear_detail.
6088         (tui_source_window_base): Rename from tui_source_window.
6089         (~tui_source_window_base): Rename from ~tui_source_window.
6090         (tui_alloc_win_info): Create a tui_disasm_window.
6091
6092 2019-06-25  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-data.h (struct tui_source_window)
6095         (struct tui_data_window): Declare destructors.
6096         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6097         destructors.
6098         (tui_win_info): Simplify.
6099
6100 2019-06-25  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-winsource.c (tui_display_main)
6103         (tui_update_source_windows_with_addr)
6104         (tui_update_all_breakpoint_info): Update.
6105         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6106         (new_height_ok, parse_scrolling_args): Update.
6107         * tui/tui-stack.c (tui_show_frame_info): Update.
6108         * tui/tui-data.h (struct tui_list): Remove.
6109         (tui_source_windows): Return a reference to a std::vector.
6110         * tui/tui-data.c (source_windows): Now a std::vector.
6111         (tui_source_windows): Change return type.
6112         (tui_clear_source_windows): Rewrite.
6113         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6114         (tui_free_all_source_wins_content): Rewrite.
6115
6116 2019-06-25  Tom Tromey  <tom@tromey.com>
6117
6118         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6119         (struct tui_data_window, struct tui_cmd_window): Declare
6120         clear_detail method.
6121         * tui/tui-data.c (tui_source_window::clear_detail)
6122         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6123         methods.
6124         (tui_clear_win_detail): Simplify.
6125
6126 2019-06-25  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-layout.c (make_source_window, make_disasm_window)
6129         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6130         Return the new window.
6131         (show_source_disasm_command, show_data)
6132         (show_source_or_disasm_and_command): Update.
6133
6134 2019-06-25  Tom Tromey  <tom@tromey.com>
6135
6136         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6137         parameter.  Return the new window.
6138         (show_source_disasm_command): Update and remove NULL check.
6139         (show_source_or_disasm_and_command): Update.
6140
6141 2019-06-25  Tom Tromey  <tom@tromey.com>
6142
6143         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6144
6145 2019-06-25  Tom Tromey  <tom@tromey.com>
6146
6147         * tui/tui-data.h (struct tui_win_info): Make constructor
6148         protected.  Make destructor virtual.  Add initializers.
6149         (tui_source_window, tui_data_window, tui_cmd_window): New
6150         classes.
6151         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6152         constructor.  Add "type" parameter.
6153         (tui_source_window, tui_data_window, tui_cmd_window): New
6154         constructors.
6155         (tui_alloc_win_info): Instantiate the appropriate subclass.
6156
6157 2019-06-25  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-win.c (tui_resize_all): Use delete.
6160         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6161         destructor.
6162         (tui_free_window): Don't declare.
6163         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6164         Update.
6165
6166 2019-06-25  Tom Tromey  <tom@tromey.com>
6167
6168         * tui/tui-data.h (struct tui_win_info): Add constructor.
6169         * tui/tui-data.c (tui_alloc_win_info): Use new.
6170         (tui_free_window): Use delete.
6171
6172 2019-06-22  Tom Tromey  <tom@tromey.com>
6173
6174         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6175         declare.
6176         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6177
6178 2019-06-22  Tom Tromey  <tom@tromey.com>
6179
6180         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6181         declare.
6182         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6183
6184 2019-06-22  Tom de Vries  <tdevries@suse.de>
6185
6186         * dwarf2read.c (create_addrmap_from_aranges)
6187         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6188         instead of '%zu'.
6189
6190 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6191
6192         * dwarf2read.h (dwarf2_section_info_def): Remove.
6193         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6194         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6195         std::vector<dwarf2_section_info>.
6196         (struct dwo_file) <~dwo_file>: Remove.
6197         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6198         types field.
6199         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6200         (dwarf2_read_debug_names): Likewise.
6201         (create_debug_types_hash_table): Change parameter type to
6202         array_view, adjust code accordingly.
6203         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6204         (partial_die_info::fixup): Likewise.
6205         (determine_prefix): Likewise.
6206         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6207
6208 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6209
6210         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6211         gdb_bfd_ref_ptr.
6212         <~dwo_file>: Remove call to gdb_bfd_unref.
6213         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6214         gdb_bfd_ref_ptr::get.
6215
6216 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6217
6218         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6219         type to htab_up.
6220         * dwarf2read.c (struct dwo_file): Initialize fields.
6221         <~dwo_file>: New.
6222         (free_dwo_file): Remove, move content to ~dwo_file.
6223         (struct dwo_file_deleter): Remove.
6224         (dwo_file_up>: Remove custom deleter.
6225         (free_dwo_files): Remove.
6226         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6227         dwo_files.
6228         (process_skeletonless_type_units): Call unique_ptr::get.
6229         (allocate_dwo_file_hash_table): Add deleter to created hash
6230         table.  Change return type to htab_up.
6231         (lookup_dwo_file_slot): Don't memset dwo_file, call
6232         unique_ptr::get.
6233         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6234         (create_dwo_unit_in_dwp_v2): Likewise.
6235         (open_and_init_dwo_file): Likewise.
6236         (free_dwo_file_from_slot): Remove.
6237
6238 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6239
6240         * dwarf2read.h (struct dwarf2_section_info) <readin,
6241         is_virtual>: Change type to bool.
6242         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6243         true instead of 1.
6244
6245 2019-06-19  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-data.h (tui_init_content_element): Don't declare.
6248
6249 2019-06-19  Tom Tromey  <tom@tromey.com>
6250
6251         * tui/tui-data.h (tui_init_win_info): Don't declare.
6252
6253 2019-06-19  Tom de Vries  <tdevries@suse.de>
6254
6255         * dwarf2read.h (abstract_to_concrete): Change type to
6256         std::unordered_map<sect_offset, std::vector<sect_offset>,
6257         gdb::hash_enum<sect_offset>>.
6258
6259 2019-06-19  Tom Tromey  <tromey@adacore.com>
6260
6261         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6262         EVAL_AVOID_SIDE_EFFECTS specially.
6263
6264 2019-06-19  Tom Tromey  <tromey@adacore.com>
6265
6266         * source-cache.c (highlighter): New global.
6267         (source_cache::get_source_lines): Create a highlighter on demand.
6268
6269 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * defs.h (deprecated_interactive_hook): Delete declaration.
6272         * interps.c (clear_interpreter_hooks): Remove use of
6273         deprecated_interactive_hook.
6274         * top.c (deprecated_interactive_hook): Delete definition.
6275         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6276
6277 2019-06-18  Tom de Vries  <tdevries@suse.de>
6278
6279         PR gdb/24515
6280         * dwarf2read.h (abstract_to_concrete): Change type from
6281         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6282         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6283         * dwarf2read.c (read_variable): Update.
6284         (dwarf2_fetch_die_loc_sect_off): Update.
6285
6286 2019-06-17  Tom de Vries  <tdevries@suse.de>
6287
6288         PR gdb/24617
6289         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6290         accessing parent[parent_len - 1].
6291
6292 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6293
6294         PR gdb/24364
6295         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6296         call dtrace_process_dof with NULL dof.
6297
6298 2019-06-16  Tom de Vries  <tdevries@suse.de>
6299
6300         PR gdb/24445
6301         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6302
6303 2019-06-16  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6306         (make_all_visible): Use address of member.
6307
6308 2019-06-16  Tom Tromey  <tom@tromey.com>
6309
6310         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6311         (tui_free_window, free_content, free_content_elements): Remove
6312         unnecessary cast.
6313         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6314         cast.
6315         * tui/tui-regs.c (tui_show_register_group)
6316         (tui_display_registers_from, tui_display_reg_element_at_line):
6317         Remove unnecessary cast.
6318
6319 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * linux-nat.c (normal_mask): Delete.
6322         (_initialize_linux_nat): Don't initialise normal_mask.
6323
6324 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6325
6326         PR gdb/24445
6327         * dwarf-index-write.h (write_psymtabs_to_index): Add
6328         dwz_basename parameter.
6329         * dwarf-index-write.c (write_gdbindex): Move file writing to
6330         write_gdbindex_1.  Change return type void.
6331         (assert_file_size): Move up, remove filename parameter.
6332         (write_gdbindex_1): New function.
6333         (write_debug_names): Change return type to void, call
6334         assert_file_size.
6335         (struct index_wip_file): New struct.
6336         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6337         file logic to index_wip_file.  Write index for dwz file if
6338         needed.
6339         (save_gdb_index_command): Pass basename of dwz file, if present.
6340         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6341         build-id of dwz file, if present.
6342         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6343         (dwarf2_get_dwz_file): Likewise.
6344         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6345         (dwarf2_get_dwz_file): Likewise.
6346
6347 2019-06-16  Tom Tromey  <tom@tromey.com>
6348
6349         * coffread.c (process_coff_symbol): Use xstrdup.
6350         * value.c (create_internalvar): Use xstrdup.
6351
6352 2019-06-16  Tom Tromey  <tom@tromey.com>
6353
6354         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6355         * breakpoint.c (stopin_command, stopat_command)
6356         (until_break_command, decode_location_default): Remove unnecessary
6357         cast.
6358         * utils.c (subset_compare): Remove unnecessary cast.
6359         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6360         cast.
6361         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6362         cast.
6363         * infcmd.c (path_command): Remove unnecessary cast.
6364         * coffread.c (decode_type): Remove unnecessary cast.
6365         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6366         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6367         * tui/tui-stack.c (tui_show_locator_content)
6368         (tui_show_frame_info): Remove unnecessary cast.
6369         * tui/tui-win.c (tui_scroll_forward_command)
6370         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6371         (parse_scrolling_args): Remove unnecessary cast.
6372         * tui/tui-data.c (init_win_info, tui_del_window)
6373         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6374         (free_content_elements): Remove unnecessary cast.
6375         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6376         unnecessary cast.
6377         * tui/tui-source.c (tui_set_source_content)
6378         (tui_vertical_source_scroll): Remove unnecessary cast.
6379         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6380         cast.
6381         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6382         * tui/tui-regs.c (tui_display_registers_from)
6383         (tui_display_register): Remove unnecessary cast.
6384         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6385         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6386         (make_visible): Remove unnecessary cast.
6387         * tui/tui-winsource.c (tui_erase_source_content)
6388         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6389         unnecessary cast.
6390         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6391         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6392         * stabsread.c (read_type, read_array_type, read_range_type):
6393         Remove unnecessary cast.
6394         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6395         (parse_symbol, parse_type, upgrade_type, parse_external)
6396         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6397         unnecessary cast.
6398         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6399
6400 2019-06-16  Tom Tromey  <tom@tromey.com>
6401
6402         * tui/tui-data.c (tui_alloc_generic_win_info)
6403         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6404         checks.
6405
6406 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6407             Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * f-typeprint.c (f_print_type): Don't return early for not
6410         associated or not allocated types.
6411         (f_type_print_varspec_suffix): Add print_rank parameter and print
6412         ranks of array types in case they dangling.
6413         (f_type_print_base): Add print_rank parameter.
6414
6415 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * NEWS: Mention new MI commands.
6418         * break-catch-throw.c (enum exception_event_kind): Move to
6419         breakpoint.h.
6420         (print_mention_exception_catchpoint): Output text as a single
6421         message.
6422         (catch_exception_command_1): Rename to...
6423         (catch_exception_event): ...this, make non-static, update header
6424         command, and change some parameter types.
6425         (catch_catch_command): Update for changes to
6426         catch_exception_command_1.
6427         (catch_throw_command): Likewise.
6428         (catch_rethrow_command): Likewise.
6429         * breakpoint.c (enum exception_event_kind): Delete.
6430         * breakpoint.h (enum exception_event_kind): Moved here from
6431         break-catch-throw.c.
6432         (catch_exception_event): Declare.
6433         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6434         (mi_cmd_catch_throw): New function.
6435         (mi_cmd_catch_rethrow): New function.
6436         (mi_cmd_catch_catch): New function.
6437         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6438         'catch-catch' entries.
6439         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6440         (mi_cmd_catch_rethrow): Declare.
6441         (mi_cmd_catch_catch): Declare.
6442
6443 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * annotate.c (annotate_source_line): Change return type to void,
6446         update implementation to match.
6447         * annotate.h (annotate_source_line): Change return type to void,
6448         update header comment.
6449         * stack.c (print_frame_info): Don't change what frame information
6450         is printed based on whether annotations are on or not.
6451
6452 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6453
6454         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6455         (annotate_source): Make static.
6456         (annotate_source_line): Moved from source.c and renamed from
6457         identify_source_line.  Update the return type.
6458         * annotate.h (annotate_source): Delete declaration.
6459         (annotate_source_line): Declaration moved from source.h, and
6460         renamed from identify_source_line.  Return type updated.
6461         * source.c (identify_source_line): Moved to annotate.c and renamed
6462         to annotate_source_line.
6463         (info_line_command): Remove check of annotation_level.
6464         * source.h (identify_source_line): Move declaration to annotate.h
6465         and rename to annotate_source_line.
6466         * stack.c: Add 'annotate.h' include.
6467         (print_frame_info): Remove check of annotation_level before
6468         calling annotate_source_line.
6469
6470 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6471
6472         * source-cache.c (source_cache::get_plain_source_lines): Use
6473         open_source_file_with_line_charpos instead of just
6474         open_source_file, remove call to find_source_lines.
6475         (source_cache::get_source_lines): Likewise.
6476         * source.c (find_source_lines): Make static.
6477         (get_filename_and_charpos): Renamed into...
6478         (open_source_file_with_line_charpos): ..this along with changes to
6479         return a scoped_fd, and some other minor clean ups.
6480         (identify_source_line): Use open_source_file_with_line_charpos.
6481         (search_command_helper): Use open_source_file_with_line_charpos
6482         instead of just open_source_file, remove call to
6483         find_source_lines.
6484         * source.h (open_source_file_with_line_charpos): Declare new
6485         function.
6486         (find_source_lines): Delete declaration.
6487
6488 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * source.c (get_filename_and_charpos): Remove fullname
6491         parameter.
6492         (identify_source_line): Update call to get_filename_and_charpos.
6493
6494 2019-06-14  Tom Tromey  <tromey@adacore.com>
6495
6496         PR gdb/24502:
6497         * ui-style.h (skip_ansi_escape): Update comment.
6498         * ui-file.h (class no_terminal_escape_file): New class.
6499         * ui-file.c (no_terminal_escape_file::write)
6500         (no_terminal_escape_file::puts): New methods.
6501         * cli/cli-logging.c (handle_redirections): Use
6502         no_terminal_escape_file.
6503
6504 2019-06-14  Tom Tromey  <tromey@adacore.com>
6505
6506         * NEWS: Move convenience variable news above Python news.
6507
6508 2019-06-14  Tom Tromey  <tom@tromey.com>
6509
6510         * gnulib: Move directory to top-level.
6511         * configure.ac: Don't configure gnulib.
6512         * configure: Rebuild.
6513         * common/common-defs.h: Use new path to gnulib.
6514         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6515         (GNULIB_H): Remove.
6516         (INCGNU): Look in new gnulib location.
6517         (HFILES_NO_SRCDIR): Remove gnulib files.
6518         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6519         (generated_files): Remove GNULIB_H.
6520         ($(LIBGNU), all-lib): Remove targets.
6521         (distclean): Don't mention GNULIB_BUILDDIR.
6522         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6523
6524 2019-06-14  Tom Tromey  <tromey@adacore.com>
6525
6526         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6527         Warn if symbol file does not provide any symbols.
6528
6529 2019-06-14  Tom Tromey  <tromey@adacore.com>
6530
6531         * source.c (find_and_open_source): Respect basenames_may_differ.
6532
6533 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * annotate.c (annotate_breakpoints_invalid): Make use of
6536         scoped_restore_terminal_state.
6537         (annotate_frames_invalid): Likewise.
6538
6539 2019-06-14  Tom Tromey  <tromey@adacore.com>
6540
6541         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6542         allow assignment to an internalvar.
6543
6544 2019-06-14  Tom Tromey  <tromey@adacore.com>
6545
6546         * ada-lex.l: Allow "_" in attribute names.
6547
6548 2019-06-14  Tom Tromey  <tromey@adacore.com>
6549
6550         PR gdb/24653:
6551         * regcache.c (registers_changed): Don't call alloca.
6552         * top.c (execute_command): Don't call alloca.
6553
6554 2019-06-13  Pedro Alves  <palves@redhat.com>
6555
6556         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6557         'expression'.  When parsing an expression, error out if there's
6558         junk after "unlimited".
6559         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6560         (do_set_command): Adjust calls to is_unlimited_literal.
6561
6562 2019-06-13  Pedro Alves  <palves@redhat.com>
6563
6564         * compile/compile.c (make_compile_options_def_group): Add braces
6565         around array_view initializer.
6566         * thread.c (make_thread_apply_all_options_def_group)
6567         (make_thread_apply_all_options_def_group): Likewise.
6568
6569 2019-06-13  Pedro Alves  <palves@redhat.com>
6570
6571         * NEWS (New commands): Mention "maint test-options
6572         require-delimiter", "maint test-options unknown-is-error", "maint
6573         test-options unknown-is-operand" and "maint show
6574         test-options-completion-result".
6575         (New command options, command completion): New section.
6576         (Completion improvements): New section.
6577         Mention that you can abbreviate "unlimited".
6578
6579 2019-06-13  Pedro Alves  <palves@redhat.com>
6580
6581         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6582         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6583         * unittests/cli-utils-selftests.c (test_parse_flags)
6584         (test_parse_flags_qcs): Delete.
6585         (test_cli_utils): Don't call deleted functions.
6586
6587 2019-06-13  Pedro Alves  <palves@redhat.com>
6588
6589         * thread.c: Include "cli/cli-option.h".
6590         (tp_array_compar_ascending): Global.
6591         (tp_array_compar): Delete function.
6592         (tp_array_compar_ascending, tp_array_compar_descending): New
6593         functions.
6594         (ascending_option_def, qcs_flag_option_def)
6595         (thr_qcs_flags_option_defs)
6596         (make_thread_apply_all_options_def_group)
6597         (make_thread_apply_options_def_group): New.
6598         (thread_apply_all_command): Use gdb::option::process_options.
6599         (thread_apply_command_completer)
6600         (thread_apply_all_command_completer): New.
6601         (thread_apply_command): Use gdb::option::process_options.
6602         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6603         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6604         to generate help text of "thread apply".  Adjust "taas"'s help.
6605         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6606         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6607
6608 2019-06-13  Pedro Alves  <palves@redhat.com>
6609
6610         * thread.c (thread_apply_command): Check for invalid TID with
6611         isdigit instead of !isalpha.
6612
6613 2019-06-13  Pedro Alves  <palves@redhat.com>
6614
6615         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6616         (validate_flags_qcs): New.
6617         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6618         (validate_flags_qcs): Declare.
6619         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6620         (make_frame_apply_options_def_group): New.
6621         (frame_apply_command_count): Process options with
6622         gdb::option::process_options.
6623         (frame_apply_completer): New.
6624         (frame_apply_level_completer, frame_apply_all_completer)
6625         (frame_apply_completer): New.
6626         (_initialize_stack): Update help of "frame apply", "frame apply
6627         level", "frame apply all" and "faas" to mention supported options
6628         and install command completers.
6629         * stack.h (frame_apply_all_completer): Declare.
6630         * thread.c: Include "stack.h".
6631         (tfaas_command): Add "--".
6632         (_initialize_thread): Update help "tfaas" to mention supported
6633         options and install command completer.
6634
6635 2019-06-13  Pedro Alves  <palves@redhat.com>
6636
6637         * completer.c (complete_nested_command_line): New.
6638         (gdb_completion_word_break_characters_throw): Add assertion.
6639         * completer.h (complete_nested_command_line): Declare.
6640
6641 2019-06-13  Pedro Alves  <palves@redhat.com>
6642
6643         * stack.c (parse_backtrace_qualifiers): New.
6644         (backtrace_command): Use it.
6645         (backtrace_command_completer): Complete on qualifiers.
6646
6647 2019-06-13  Pedro Alves  <palves@redhat.com>
6648
6649         * frame.c: Include "cli/cli-option.h.
6650         (user_set_backtrace_options): New.
6651         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6652         Delete.
6653         (get_prev_frame): Adjust.
6654         (boolean_option_def, uinteger_option_def)
6655         (set_backtrace_option_defs): New.
6656         (_initialize_frame): Adjust and use
6657         gdb::option::add_setshow_cmds_for_options to install "set
6658         backtrace past-main" and "set backtrace past-entry".
6659         * frame.h: Include "cli/cli-option.h".
6660         (struct frame_print_options): Forward declare.
6661         (print_frame_arguments_all, print_frame_arguments_scalars)
6662         (print_frame_arguments_none): Declare.
6663         (print_entry_values): Delete declaration.
6664         (struct frame_print_options, user_frame_print_options): New.
6665         (struct set_backtrace_options): New.
6666         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6667         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6668         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6669         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6670         (list_args_or_locals): Add frame_print_options parameter.
6671         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6672         * python/py-framefilter.c (enumerate_args): Pass down
6673         USER_FRAME_PRINT_OPTIONS.
6674         * stack.c: Include "cli/cli-option.h".
6675         (print_frame_arguments_all, print_frame_arguments_scalars)
6676         (print_frame_arguments_none): Declare.
6677         (print_raw_frame_arguments, print_entry_values): Delete.
6678         (user_frame_print_options): New.
6679         (boolean_option_def, enum_option_def, frame_print_option_defs):
6680         New.
6681         (struct backtrace_cmd_options): New.
6682         (bt_flag_option_def): New.
6683         (backtrace_command_option_defs): New.
6684         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6685         (print_frame_arg, read_frame_arg, print_frame_args)
6686         (print_frame_info, print_frame): Add frame_print_options parameter
6687         and use it.
6688         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6689         (backtrace_command_1): Add frame_print_options and
6690         backtrace_cmd_options parameters and use them.
6691         (make_backtrace_options_def_group): New.
6692         (backtrace_command): Process command options with
6693         gdb::option::process_options.
6694         (backtrace_command_completer): New.
6695         (_initialize_stack): Extend "backtrace"'s help to mention
6696         supported options.  Install completer for "backtrace".
6697         Install some settings commands with add_setshow_cmds_for_options.
6698
6699 2019-06-13  Pedro Alves  <palves@redhat.com>
6700
6701         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6702         and that "set/show print raw frame-arguments" are now deprecated.
6703
6704         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6705         command.
6706         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6707         * stack.c (_initialize_stack): Install "set/show print
6708         raw-frame-arguments", and deprecate "set/show print raw
6709         frame-arguments".
6710         * valprint.c (_initialize_valprint): Deprecate "set/show print
6711         raw".
6712
6713 2019-06-13  Pedro Alves  <palves@redhat.com>
6714
6715         * compile/compile.c (struct compile_options): New.
6716         (compile_flag_option_def, compile_command_option_defs)
6717         (make_compile_options_def_group): New.
6718         (compile_file_command): Handle options with
6719         gdb::option::process_options.
6720         (compile_file_command_completer): New function.
6721         (compile_code_command): Handle options with
6722         gdb::option::process_options.
6723         (compile_code_command_completer): New function.
6724         (_initialize_compiler): Install completers for "compile code" and
6725         "compile file".  Mention available options in "compile code" and
6726         "compile code"'s help.
6727         * completer.c (advance_to_completion_word): New, factored out from
6728         ...
6729         (advance_to_expression_complete_word_point): ... this.
6730         (advance_to_filename_complete_word_point): New.
6731         * completer.h (advance_to_filename_complete_word_point): New
6732         declaration.
6733
6734 2019-06-13  Pedro Alves  <palves@redhat.com>
6735
6736         * compile/compile.c: Include "cli/cli-option.h".
6737         (compile_print_value): Scope data pointer is now a
6738         value_print_options pointer; adjust.
6739         (compile_print_command): Process options.  Scope data pointer is
6740         now a value_print_options pointer; adjust.
6741         (_initialize_compile): Update "compile print"'s help to include
6742         supported options.  Install a completer for "compile print".
6743         * cp-valprint.c (show_vtblprint, show_objectprint)
6744         (show_static_field_print): Delete.
6745         (_initialize_cp_valprint): Don't install "set print
6746         static-members", "set print vtbl", "set print object" here.
6747         * printcmd.c: Include "cli/cli-option.h" and
6748         "common/gdb_optional.h".
6749         (print_command_parse_format): Rework to fill in a
6750         value_print_options instead of a format_data.
6751         (print_value): Change parameter type from format_data pointer to
6752         value_print_options reference.  Adjust.
6753         (print_command_1): Process options.  Adjust to pass down a
6754         value_print_options.
6755         (print_command_completer): New.
6756         (_initialize_printcmd): Install print_command_completer as
6757         handle_brkchars completer for the "print" command.  Update
6758         "print"'s help to include supported options.
6759         * valprint.c: Include "cli/cli-option.h".
6760         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6761         here from cp-valprint.c.
6762         (boolean_option_def, uinteger_option_def)
6763         (value_print_option_defs, make_value_print_options_def_group):
6764         New.  Use gdb::option::add_setshow_cmds_for_options to install
6765         "set print elements", "set print null-stop", "set print repeats",
6766         "set print pretty", "set print union", "set print array", "set
6767         print address", "set print symbol", "set print array-indexes".
6768         * valprint.h: Include <string> and "cli/cli-option.h".
6769         (make_value_print_options_def_group): Declare.
6770         (print_value): Change parameter type from format_data pointer to
6771         value_print_options reference.
6772         (print_command_completer): Declare.
6773
6774 2019-06-13  Pedro Alves  <palves@redhat.com>
6775
6776         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6777         (COMMON_SFILES): Add maint-test-settings.c.
6778         * cli/cli-decode.c (boolean_enums): New global, factored out from
6779         ...
6780         (add_setshow_boolean_cmd): ... here.
6781         * cli/cli-decode.h (boolean_enums): Declare.
6782         * cli/cli-option.c: New file.
6783         * cli/cli-option.h: New file.
6784         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6785         factored out from ...
6786         (parse_cli_boolean_value(const char *)): ... this.
6787         (is_unlimited_literal): Change parameter type to pointer to
6788         pointer.  Adjust and advance ARG pointer.
6789         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6790         (parse_cli_var_enum): New, factored out from ...
6791         (do_set_command): ... this.  Adjust.
6792         * cli/cli-setshow.h (parse_cli_boolean_value)
6793         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6794         (parse_cli_var_enum): Declare.
6795         * cli/cli-utils.c: Include "cli/cli-option.h".
6796         (get_ulongest): New.
6797         * cli/cli-utils.h (get_ulongest): Declare.
6798         (check_for_argument): New overloads.
6799         * maint-test-options.c: New file.
6800
6801 2019-06-13  Pedro Alves  <palves@redhat.com>
6802
6803         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6804         parse a range if "-" is at the end of the string.
6805
6806 2019-06-13  Pedro Alves  <palves@redhat.com>
6807
6808         * cli/cli-setshow.c (parse_auto_binary_operation)
6809         (parse_cli_boolean_value): Don't allow "o".
6810
6811 2019-06-13  Pedro Alves  <palves@redhat.com>
6812
6813         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6814         * NEWS: Mention maint test-settings KIND.
6815         * maint-test-settings.c: New file.
6816
6817 2019-06-13  Pedro Alves  <palves@redhat.com>
6818
6819         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6820         completer.
6821         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6822         "set" completers.
6823
6824 2019-06-13  Pedro Alves  <palves@redhat.com>
6825
6826         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6827         after item.
6828
6829 2019-06-13  Pedro Alves  <palves@redhat.com>
6830
6831         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6832
6833 2019-06-13  Pedro Alves <palves@redhat.com>
6834
6835         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6836         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6837         call.
6838         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6839         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6840         calls.
6841         (check_for_argument): Skip spaces after argument.
6842
6843 2019-06-13  Pedro Alves  <palves@redhat.com>
6844
6845         * thread.c (thread_apply_command): Adjust TID parsing.
6846         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6847         detected before end of string.
6848         (tid_is_in_list): Error out if LIST is invalid.
6849
6850 2019-06-13  Pedro Alves  <palves@redhat.com>
6851
6852         * completer.c (complete_line_internal_1): Rewind completion word
6853         point.
6854         (completion_tracker::advance_custom_word_point_by): Change
6855         parameter type to int.
6856         * completer.h (completion_tracker::advance_custom_word_point_by):
6857         Likewise.
6858
6859 2019-06-13  Pedro Alves  <palves@redhat.com>
6860
6861         * completer.c (advance_to_completion_word): Handle delimiters.
6862
6863 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6864
6865         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6866
6867 2019-06-11  Tom Tromey  <tom@tromey.com>
6868
6869         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6870         (xmalloc_failed): Move to alloc.c.
6871         * alloc.c: New file.
6872         * Makefile.in (COMMON_SFILES): Add alloc.c.
6873
6874 2019-06-11  Tom Tromey  <tom@tromey.com>
6875
6876         * nat/linux-waitpid.c: Don't include server.h.
6877         (linux_debug): Remove.
6878         (my_waitpid): Update.
6879
6880 2019-06-11  Tom Tromey  <tromey@adacore.com>
6881
6882         * infcall.c (_initialize_infcall): Remove trailing newline from
6883         help.
6884         * user-regs.c (_initialize_user_regs): Remove trailing newline
6885         from help.
6886         * typeprint.c (_initialize_typeprint): Remove trailing newline
6887         from help.
6888         * reverse.c (_initialize_reverse): Remove trailing newlines from
6889         help.
6890         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6891         from help.
6892         * language.c (add_set_language_command): Remove trailing newline
6893         from help.
6894         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6895         help.
6896         * disasm.c (_initialize_disasm): Remove trailing newline from
6897         help.
6898         * top.c (init_main): Remove trailing newline from help.
6899         * interps.c (_initialize_interpreter): Remove trailing newline
6900         from help.
6901         * btrace.c (_initialize_btrace): Remove trailing newlines from
6902         help.
6903         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6904         from help.
6905         * python/python.c (_initialize_python): Remove trailing newline
6906         from help.
6907         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6908         help.
6909         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6910         from help.  Reformat some text.
6911         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6912         from help.
6913         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6914         newline from help.
6915
6916 2019-06-11  Tom Tromey  <tromey@adacore.com>
6917
6918         * darwin-nat.c (darwin_decode_exception_message)
6919         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6920
6921 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6922
6923         * valops.c (value_slice): Check for not allocated or not
6924         associated values.
6925
6926 2019-06-10  Tom de Vries  <tdevries@suse.de>
6927
6928         PR gdb/24618
6929         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6930         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6931         invalid.
6932
6933 2019-06-10  Tom de Vries  <tdevries@suse.de>
6934
6935         PR gdb/24611
6936         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6937         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6938
6939 2019-06-10  Tom de Vries  <tdevries@suse.de>
6940
6941         PR symtab/24545
6942         * symtab.c (struct demangled_name_entry): Add language field.
6943         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6944         static minimal symbol".  Set and use language field.
6945
6946 2019-06-10  Tom Tromey  <tromey@adacore.com>
6947
6948         * ada-lang.c (_initialize_ada_language): Update help text.
6949
6950 2019-06-10  Tom Tromey  <tromey@adacore.com>
6951
6952         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6953         with a newline.
6954         * guile/guile.c (handle_boot_error): Don't end warning with a
6955         newline.
6956         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6957         warning with a newline.
6958         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6959         newline.
6960         (s12z_frame_cache): Likewise.
6961         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6962         a newline.
6963         * solib-svr4.c (disable_probes_interface): Don't end warning with
6964         a newline.
6965         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6966         newline.
6967         * python/python.c (do_finish_initialization): Don't end warning
6968         with a newline.
6969
6970 2019-06-10  Tom Tromey  <tom@tromey.com>
6971
6972         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6973         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6974         gdbpy_enter.
6975
6976 2019-06-10  Tom Tromey  <tromey@adacore.com>
6977
6978         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6979         data.
6980         (elf_new_init): Don't call stabsread_new_init.
6981         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6982         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6983         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6984
6985 2019-06-10  Tom de Vries  <tdevries@suse.de>
6986
6987         PR symtab/16264
6988         PR symtab/24517
6989         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6990
6991 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6992
6993         * source.c (find_and_open_source): Also rewrite relative file
6994         names.
6995
6996 2019-04-26  Amos Bird  <amosbird@gmail.com>
6997
6998         * annotate.c (annotate_thread_exited): Add "thread-exited"
6999         annotation.
7000
7001 2019-06-06  Tom Tromey  <tromey@adacore.com>
7002
7003         * maint.h (class scoped_command_stats): Use
7004         DISABLE_COPY_AND_ASSIGN.
7005         <print_time>: New method.
7006         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7007         print_time.
7008         (scoped_command_stats::print_time): New method.
7009
7010 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7011
7012         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7013         instructions of lengths 6 or 8 bytes.
7014
7015 2019-06-04  Pedro Alves  <palves@redhat.com>
7016
7017         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7018
7019         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7020         * breakpoint.c (condition_completer): Likewise.
7021         * cli/cli-dump.c (scan_expression): Likewise.
7022         * common/filestuff.c (mkdir_recursive): Likewise.
7023         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7024         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7025         (gdb_abspath): Likewise.
7026         * compile/compile-cplus-types.c
7027         (compile_cplus_instance::decl_name): Likewise.
7028         * completer.c (complete_explicit_location):
7029         (signal_completer, reg_or_group_completer_1): Likewise.
7030         * cp-support.c (cp_remove_params_if_any): Likewise.
7031         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7032         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7033         * infcmd.c (strip_bg_char): Likewise.
7034         * linespec.c (copy_token_string): Likewise.
7035         * mi/mi-main.c (output_cores): Likewise.
7036         * psymtab.c (psymtab_search_name):
7037         * symfile.c (test_set_ext_lang_command): Likewise.
7038         * target.c (target_fileio_read_stralloc): Likewise.
7039         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7040         * value.c (complete_internalvar): Likewise.
7041
7042 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7043
7044         Add objfile property to gdb.Type.
7045         * NEWS: Mention Python API addition.
7046         * python/py-type.c (typy_get_objfile): New method.
7047
7048 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7049
7050         * NEWS: Mention the new set|show style [title|highlight].
7051         Mention changes to "show style", "help" and "apropos".
7052
7053 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7054
7055         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7056         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7057         instead of print_help_for_command.
7058         (print_doc_of_command): New function.
7059         (help_list): Add 'apropos -v word' suggestion.
7060         (print_help_for_command): Style the command name using title style.
7061         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7062         (_initialize_cli_cmds): Describe -v in apropos_command help.
7063
7064 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7065
7066         * cli/cli-style.h (cli_style_option): Add name in constructor,
7067         add m_name class member, add constructor with intensity,
7068         add name class function.
7069         (cli_style_option::add_setshow_commands): Remove name argument.
7070         (highlight_style, title_style): New styles.
7071         * cli/cli-style.c (do_show): New function that shows a style
7072         characteristic styling the style name with itself.
7073         (set_style_name): New function.
7074         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7075         Update all callers according to the changes in cli/cli-style.h.
7076         * utils.h (fputs_highlighted): New function.
7077         * utils.c (fputs_highlighted): Likewise.
7078
7079 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7080
7081         * NEWS: Mention new pipe command and new convenience variables.
7082
7083 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7084
7085         * cli/cli-cmds.c (pipe_command): New function.
7086         (_initialize_cli_cmds): Call add_com for pipe_command.
7087         Define | as an alias for pipe.
7088         (exit_status_set_internal_vars): New function.
7089         (shell_escape): Call exit_status_set_internal_vars.
7090         cli/cli-decode.c (find_command_name_length): Recognize | as
7091         a single character command.
7092
7093 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7094
7095         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7096         top.c (execute_command_to_ui_file): New function, mostly a copy
7097         of execute_command_to_string.
7098         (execute_command_to_string): Implement by calling
7099         execute_command_to_ui_file.
7100
7101 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7102
7103         * top.h (saved_command_line): Remove declaration.
7104         * top.c (previous_saved_command_line, previous_repeat_arguments):
7105         New variables.
7106         (saved_command_line): Make static, define together with other
7107         'repeat variables'.
7108         (dont_repeat): Clear repeat_arguments.
7109         (repeat_previous, get_saved_command_line, save_command_line):
7110         New functions.
7111         (gdb_init): Initialize saved_command_line
7112         and previous_saved_command_line.
7113         * main.c (captured_main_1): Remove saved_command_line initialization.
7114         * event-top.c (handle_line_of_input): Update to use
7115         the new 'repeat' related functions instead of direct access to
7116         saved_command_line.
7117         * command.h (repeat_previous, get_saved_command_line,
7118         save_command_line): New declarations.
7119         (dont_repeat): Add comment.
7120
7121 2019-05-30  Tom Tromey  <tromey@adacore.com>
7122
7123         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7124         Fix comment.
7125         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7126
7127 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7128
7129         PR cli/24587
7130         * completer.c (complete): Initialize variable word.
7131
7132 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7133
7134         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7135         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7136         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7137         'body' is NULL to the outter 'if', protecting the '!is_define'
7138         situation as well.
7139
7140 2019-05-29  Tom Tromey  <tromey@adacore.com>
7141
7142         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7143         (dwarf_unknown): New function.
7144         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7145         (dwarf_type_encoding_name): Use dwarf_unknown.
7146
7147 2019-05-29  Tom Tromey  <tromey@adacore.com>
7148
7149         PR c++/20020:
7150         * cp-valprint.c (cp_print_value_fields): Call
7151         cp_print_static_field inside "try".
7152
7153 2019-05-29  Tom Tromey  <tromey@adacore.com>
7154
7155         * inflow.c (struct terminal_info): Add default operator=.
7156         * configure: Rebuild.
7157         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7158         -Wdeprecated-copy-dtor, -Wredundant-move.
7159
7160 2019-05-29  Tom Tromey  <tromey@adacore.com>
7161
7162         * NEWS: Add entry.
7163         * infcmd.c (print_return_value_1): Handle finish_print
7164         option.
7165         (show_print_finish): New function.
7166         (_initialize_infcmd): Add "set/show print finish" commands.
7167         * valprint.c (user_print_options): Initialize new member.
7168         * valprint.h (struct value_print_options) <finish_print>: New
7169         member.
7170
7171 2019-05-28  Tom Tromey  <tromey@adacore.com>
7172
7173         * ada-lang.c (ada_remove_Xbn_suffix)
7174         (find_old_style_renaming_symbol)
7175         (parse_old_style_renaming): Remove.
7176         (ada_find_renaming_symbol): Don't call
7177         find_old_style_renaming_symbol.
7178         (ada_is_renaming_symbol): Rename from
7179         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7180         bool.  Now static.
7181         (ada_read_var_value): Update and simplify.
7182         * ada-exp.y (write_var_or_type): Remove old code.
7183
7184 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7185
7186         PR gdb/25010
7187         * event-top.c: Remove include comment.
7188         * inflow.c (class scoped_ignore_sigttou): Move from here...
7189         * inflow.h (class scoped_ignore_sigttou): ...to here.
7190         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7191         * top.c:  Remove include comment.
7192
7193 2019-05-27  Tom Tromey  <tom@tromey.com>
7194
7195         * NEWS: Fix typo.
7196
7197 2019-05-22  Tom Tromey  <tromey@adacore.com>
7198
7199         * target.c (target_follow_exec): Constify parameter.
7200         * target-delegates.c: Rebuild.
7201         * remote.c (remote_target::follow_exec): Constify parameter.
7202         * infrun.c (follow_exec): Constify parameter.
7203         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7204         (target_follow_exec): Likewise.
7205
7206 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7207
7208         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7209         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7210
7211 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7212
7213         * NEWS: Add debugredirect and testsuite sections.
7214
7215 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7216
7217         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7218         target descriptions using exclusively floating point register name
7219         aliases.
7220
7221 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         PR gdb/18644:
7224         * f-lang.c (build_fortran_types): Handle the case where
7225         gdbarch_floatformat_for_type returns a nullptr.
7226
7227 2019-05-21  Tom de Vries  <tdevries@suse.de>
7228
7229         PR cli/24587
7230         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7231
7232 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         PR gdb/18644:
7235         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7236         16-byte floats.
7237         * i386-tdep.c (i386_floatformat_for_type): Use
7238         floatformats_ia64_quad for the 16-byte floating point component
7239         within a fortran 32-byte complex number.
7240
7241 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7242
7243         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7244         delete default constructor.
7245         (find_partial_die): Update to return const struct.
7246         (partial_die_parent_scope): Move variable declaration into scope
7247         of its use and change its type to auto.
7248         (guess_partial_die_structure_name): Likewise.
7249         (partial_die_info::fixup): Likewise.
7250
7251 2019-05-17  Tom Tromey  <tromey@adacore.com>
7252
7253         * source.c (find_and_open_source): Remove cast.
7254
7255 2019-05-17  Tom Tromey  <tromey@adacore.com>
7256
7257         * annotate.c (annotate_source): Make "filename" const.
7258         * annotate.h (annotate_source): Use const.
7259
7260 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7261
7262         * disasm.c (set_disassembler_options): Send errors to stderr.
7263
7264 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7265
7266         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7267         (cli_interp_base::set_logging): Check debug_redirect.
7268         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7269         * cli/cli-logging.c (debug_redirect): Add static variable.
7270         (pop_output_files): Add default param.
7271         (handle_redirections): Print debug setting.
7272         (show_logging_command): Likewise.
7273         (_initialize_cli_logging): Add debugredirect command.
7274         * interps.c (current_interp_set_logging): Add debug_redirect
7275         parameter.
7276         * interps.h (set_logging): Add debug_redirect parameter.
7277         (current_interp_set_logging): Likewise.
7278         * mi/mi-common.h: Likewise.
7279         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7280
7281 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7282             Tom Tromey  <tromey@adacore.com>
7283
7284         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7285         directly.
7286         * cli/cli-interp.h (make_logging_output): Remove declaration.
7287         * cli/cli-logging.c (make_logging_output): Remove function.
7288         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7289         directly.
7290         * ui-file.c (tee_file::tee_file): Remove bools.
7291         (tee_file::~tee_file): Remove deletes.
7292         * ui-file.h (tee_file): Remove bools.
7293
7294 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7295
7296         * mi/mi-cmds.h (mi_cmd_complete): New function.
7297         * mi/mi-main.c (mi_cmd_complete): Likewise.
7298         * mi/mi-cmds.c: Define new MI command -complete.
7299         * NEWS: Mention new -complete command.
7300
7301 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7302
7303         * completer.h (complete): New function.
7304         * completer.c (complete): Likewise.
7305         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7306         function defined in completer.h.
7307
7308 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7309
7310         * MAINTAINERS (Write After Approval): Add myself.
7311
7312 2019-05-17  Tom de Vries  <tdevries@suse.de>
7313
7314         PR gdb/24094
7315         * dwarf2read.c (struct cu_partial_die_info): New struct.
7316         (find_partial_die): Return cu_partial_die_info.
7317         (partial_die_parent_scope, guess_partial_die_structure_name)
7318         (partial_die_info::fixup): Handle new return type of find_partial_die.
7319
7320 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7321
7322         PR breakpoints/24541
7323         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7324         "std::string", simplifying the algorithm.
7325
7326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7327
7328         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7329         (stap_static_probe_ops::get_probes): Likewise.
7330
7331 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7332
7333         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7334         '-')" and "else if".
7335         (stap_parse_single_operand): Join checks for
7336         "gdbarch_stap_parse_special_token_p" and
7337         "gdbarch_stap_parse_special_token" in the same "if" statement.
7338         Invert check when verifying for operation on register
7339         displacement.
7340
7341 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7342
7343         * stap-probe.c (stap_get_opcode): Update comment.
7344         (stap_get_expected_argument_type): Likewise.
7345         (handle_stap_probe): Likewise.
7346
7347 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7348
7349         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7350         return type to 'bool'.  Adjust comment.  Use 'bool' when
7351         appropriate.
7352         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7353         * stap-probe.c (stap_parse_argument_1): Likewise.
7354         (stap_is_operator): Likewise.
7355         (stap_is_generic_prefix): Likewise.
7356         (stap_is_register_prefix): Likewise.
7357         (stap_is_register_indirection_prefix): Likewise.
7358         (stap_is_integer_prefix): Likewise.
7359         (stap_generic_check_suffix): Likewise.
7360         (stap_check_integer_suffix): Likewise.
7361         (stap_check_register_suffix): Likewise.
7362         (stap_check_register_indirection_suffix): Likewise.
7363         (stap_parse_register_operand): Likewise.
7364         (stap_parse_single_operand): Likewise.
7365         (stap_parse_argument_1): Likewise.
7366         (stap_probe::get_argument_count): Likewise.
7367         (stap_is_operator): Likewise.
7368
7369 2019-05-16  Tom Tromey  <tromey@adacore.com>
7370
7371         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7372         keyword to foreach.
7373
7374 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7375
7376         * linux-thread-db.c (try_thread_db_load_1): Change return type
7377         to bool.
7378         (try_thread_db_load): Likewise.
7379         (try_thread_db_load_from_pdir_1): Likewise.
7380         (try_thread_db_load_from_pdir): Likewise.
7381         (try_thread_db_load_from_sdir): Likewise.
7382         (try_thread_db_load_from_dir): Likewise.
7383         (thread_db_load_search): Likewise.
7384         (has_libpthread): Likewise.
7385         (thread_db_load): Likewise.
7386
7387 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7388
7389         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7390         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7391         NULL, and complain/return if that's the case.
7392
7393 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7394
7395         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7396         (advance, posn, abstract_read_memory): New functions.
7397         [struct mem_read_abstraction]: New struct.
7398         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7399
7400 2019-05-14  Tom Tromey  <tromey@adacore.com>
7401
7402         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7403         value is not lval_memory.
7404
7405 2019-05-14  Tom Tromey  <tromey@adacore.com>
7406
7407         * solib.c (info_sharedlibrary_command): Style the file name.
7408
7409 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7410
7411         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7412         (aarch64_vnv_type): Likewise.
7413         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7414         * common/tdesc.c: Likewise.
7415         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7416         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7417         * features/aarch64-fpu.xml: Add ieee half view.
7418         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7419         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7420         * gdbtypes.h (struct builtin_type): Likewise.
7421         (struct objfile_type): Likewise.
7422
7423 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7424
7425         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7426         typo.
7427         * location.h (string_to_event_location): Likewise.
7428
7429 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7430
7431         GDB 8.3 released.
7432
7433 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7434
7435         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7436         New variable declaration.
7437         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7438         New variable.
7439         (print_one_breakpoint): Use ui_out::test_flags and new global
7440         variable to compute use_fixed_output.
7441         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7442         Remove.
7443         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7444         (mi_multi_location_breakpoint_output_fixed): Remove.
7445         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7446         new variable.
7447         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7448         fix_multi_location_breakpoint_output flag if version >= 3.
7449         * ui-out.h (enum ui_out_flag)
7450         <fix_multi_location_breakpoint_output>: New enumerator.
7451
7452 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7453
7454         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7455
7456 2019-05-10  Tom Tromey  <tromey@adacore.com>
7457
7458         * ada-lang.c (catch_ada_completer): New function.
7459         (_initialize_ada_language): Use it.
7460
7461 2019-05-10  Tom Tromey  <tromey@adacore.com>
7462
7463         * thread.c (print_thread_info): Make "requested_threads" const.
7464         * gdbthread.h (print_thread_info): Make "requested_threads"
7465         const.
7466         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7467         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7468
7469 2019-05-08  Tom Tromey  <tom@tromey.com>
7470
7471         * gdbtypes.c (objfile_type_data): Change type.
7472         (objfile_type, _initialize_gdbtypes): Update.
7473
7474 2019-05-08  Tom Tromey  <tom@tromey.com>
7475
7476         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7477         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7478         (_initialize_dwarf2_frame): Update.
7479
7480 2019-05-08  Tom Tromey  <tom@tromey.com>
7481
7482         * objc-lang.c (objc_objfile_data): Change type.
7483         (find_methods): Update.
7484         (_initialize_objc_lang): Remove.
7485
7486 2019-05-08  Tom Tromey  <tom@tromey.com>
7487
7488         * stabsread.c (rs6000_builtin_type_data): Change type.
7489         (rs6000_builtin_type, _initialize_stabsread): Update.
7490
7491 2019-05-08  Tom Tromey  <tom@tromey.com>
7492
7493         * mips-tdep.c (mips_pdr_data): Remove.
7494         (_initialize_mips_tdep): Update.
7495
7496 2019-05-08  Tom Tromey  <tom@tromey.com>
7497
7498         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7499         (hppa_init_objfile_priv_data, read_unwind_info)
7500         (find_unwind_entry, _initialize_hppa_tdep): Update.
7501
7502 2019-05-08  Tom Tromey  <tom@tromey.com>
7503
7504         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7505         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7506         on obstack.
7507         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7508
7509 2019-05-08  Tom Tromey  <tom@tromey.com>
7510
7511         * mdebugread.c (basic_type_data): Change type.
7512         (basic_type, _initialize_mdebugread): Update.
7513
7514 2019-05-08  Tom Tromey  <tom@tromey.com>
7515
7516         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7517
7518 2019-05-08  Tom Tromey  <tom@tromey.com>
7519
7520         * nto-tdep.c (nto_inferior_data_reg): Change type.
7521         (nto_inferior_data): Update.
7522         (nto_inferior_data_cleanup, nto_new_inferior_data)
7523         (_initialize_nto_tdep): Remove.
7524         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7525
7526 2019-05-08  Tom Tromey  <tom@tromey.com>
7527
7528         * ada-lang.c (struct ada_inferior_data): Add initializers.
7529         (ada_inferior_data): Change type.
7530         (ada_inferior_data_cleanup): Remove.
7531         (get_ada_inferior_data, ada_inferior_exit)
7532         (struct ada_pspace_data): Add initializers, destructor.
7533         (ada_pspace_data_handle): Change type.
7534         (get_ada_pspace_data): Update.
7535         (ada_pspace_data_cleanup): Remove.
7536
7537 2019-05-08  Tom Tromey  <tom@tromey.com>
7538
7539         * coffread.c (struct coff_symfile_info): Add initializers.
7540         (coff_objfile_data_key): Move lower.  Change type.
7541         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7542         Update.
7543         (coff_free_info): Remove.
7544
7545 2019-05-08  Tom Tromey  <tom@tromey.com>
7546
7547         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7548         (fbsd_pspace_data_handle): Move lower.  Change type.
7549         (get_fbsd_pspace_data): Update.
7550         (fbsd_pspace_data_cleanup): Remove.
7551         (_initialize_fbsd_tdep): Update.
7552
7553 2019-05-08  Tom Tromey  <tom@tromey.com>
7554
7555         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7556         (get_ada_tasks_pspace_data): Update.
7557         (ada_tasks_pspace_data_cleanup): Remove.
7558         (_initialize_tasks): Update.
7559         (ada_tasks_inferior_data_handle): Change type.
7560         (get_ada_tasks_inferior_data): Update.
7561         (ada_tasks_inferior_data_cleanup): Remove.
7562         (struct ada_tasks_pspace_data): Add initializers.
7563
7564 2019-05-08  Tom Tromey  <tom@tromey.com>
7565
7566         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7567         * symfile-debug.c (debug_sym_get_probes): Change type.
7568         * stap-probe.c (handle_stap_probe):
7569         (stap_static_probe_ops::get_probes): Change type.
7570         * probe.h (class static_probe_ops) <get_probes>: Change type.
7571         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7572         (parse_probes_in_pspace): Update.
7573         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7574         Update.
7575         (any_static_probe_ops::get_probes): Change type.
7576         * elfread.c (elfread_data): New typedef.
7577         (probe_key): Change type.
7578         (elf_get_probes): Likewise.  Update.
7579         (probe_key_free): Remove.
7580         (_initialize_elfread): Update.
7581         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7582         Change type.
7583         (dtrace_process_dof_probe, dtrace_process_dof)
7584         (dtrace_static_probe_ops::get_probe): Change type.
7585
7586 2019-05-08  Tom Tromey  <tom@tromey.com>
7587
7588         * xcoffread.c (struct xcoff_symfile_info): Rename from
7589         coff_symfile_info.  Add initializers.
7590         (xcoff_objfile_data_key): Move lower.  Change type.
7591         (XCOFF_DATA): Rewrite.
7592         (xcoff_free_info): Remove.
7593         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7594         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7595         (xcoff_initial_scan): Update.
7596
7597 2019-05-08  Tom Tromey  <tom@tromey.com>
7598
7599         * solib-svr4.c (struct svr4_info): Add initializers and
7600         destructor.
7601         <probes_table>: Now an htab_up.
7602         (solib_svr4_pspace_data): Change type.
7603         (free_probes_table): Simplify.
7604         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7605         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7606         (probes_table_remove_objfile_probes, register_solib_event_probe)
7607         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7608         (_initialize_svr4_solib): Update.
7609
7610 2019-05-08  Tom Tromey  <tom@tromey.com>
7611
7612         * remote.c (remote_pspace_data): Change type.
7613         (remote_pspace_data_cleanup): Remove.
7614         (get_remote_exec_file, set_pspace_remote_exec_file)
7615         (_initialize_remote): Update.
7616
7617 2019-05-08  Tom Tromey  <tom@tromey.com>
7618
7619         * breakpoint.c (breakpoint_objfile_key): Change type.
7620         (get_breakpoint_objfile_data): Update.
7621         (free_breakpoint_objfile_data): Remove.
7622         (_initialize_breakpoint): Update.
7623
7624 2019-05-08  Tom Tromey  <tom@tromey.com>
7625
7626         * linux-tdep.c (struct linux_info): Add initializers.
7627         (linux_inferior_data): Move.  Change type.
7628         (invalidate_linux_cache_inf): Update.
7629         (linux_inferior_data_cleanup): Remove.
7630         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7631
7632 2019-05-08  Tom Tromey  <tom@tromey.com>
7633
7634         * auxv.c (auxv_inferior_data): Move.  Change type.
7635         (auxv_inferior_data_cleanup): Remove.
7636         (invalidate_auxv_cache_inf): Rewrite.
7637         (get_auxv_inferior_data, _initialize_auxv): Update.
7638
7639 2019-05-08  Tom Tromey  <tom@tromey.com>
7640
7641         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7642         (symfile_debug_objfile_data_key): Change type.
7643         (symfile_debug_installed, debug_qf_has_symbols)
7644         (debug_qf_find_last_source_symtab)
7645         (debug_qf_forget_cached_source_info)
7646         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7647         (debug_qf_print_stats, debug_qf_dump)
7648         (debug_qf_expand_symtabs_for_function)
7649         (debug_qf_expand_all_symtabs)
7650         (debug_qf_expand_symtabs_with_fullname)
7651         (debug_qf_map_matching_symbols)
7652         (debug_qf_expand_symtabs_matching)
7653         (debug_qf_find_pc_sect_compunit_symtab)
7654         (debug_qf_map_symbol_filenames)
7655         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7656         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7657         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7658         (debug_sym_read_linetable, debug_sym_relocate): Update.
7659         (symfile_debug_free_objfile): Remove.
7660         (install_symfile_debug_logging, _initialize_symfile_debug):
7661         Update.
7662
7663 2019-05-08  Tom Tromey  <tom@tromey.com>
7664
7665         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7666         allocate_on_obstack.
7667         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7668         (get_dwarf2_per_objfile): Update.
7669         (set_dwarf2_per_objfile): Remove.
7670         (dwarf2_has_info, dwarf2_get_section_info): Update.
7671         (dwarf2_free_objfile): Remove.
7672         (_initialize_dwarf2_read): Update.
7673
7674 2019-05-08  Tom Tromey  <tom@tromey.com>
7675
7676         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7677         initializers.
7678         <unsupported_script_warning_printed,
7679         script_not_found_warning_printed>: Now bool.
7680         (auto_load_pspace_data): Change type.
7681         (~auto_load_pspace_info): Rename from
7682         auto_load_pspace_data_cleanup.
7683         (get_auto_load_pspace_data, init_loaded_scripts_info)
7684         (clear_section_scripts, maybe_print_unsupported_script_warning)
7685         (maybe_print_script_not_found_warning, _initialize_auto_load):
7686         Update.
7687
7688 2019-05-08  Tom Tromey  <tom@tromey.com>
7689
7690         * objfiles.c (objfile_pspace_info): Add destructor and
7691         initializers.
7692         (objfiles_pspace_data): Change type.
7693         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7694         (get_objfile_pspace_data): Update.
7695         (objfiles_bfd_data): Change type.
7696         (get_objfile_bfd_data): Update.
7697         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7698
7699 2019-05-08  Tom Tromey  <tom@tromey.com>
7700
7701         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7702         Change type.
7703         (get_catch_syscall_inferior_data): Update.
7704         (catch_syscall_inferior_data_cleanup): Remove.
7705         (_initialize_break_catch_syscall): Update.
7706
7707 2019-05-08  Tom Tromey  <tom@tromey.com>
7708
7709         * inflow.c (struct terminal_info): Add destructor and
7710         initializers.
7711         (inflow_inferior_data): Change type.
7712         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7713         (get_inflow_inferior_data, inflow_inferior_exit)
7714         (swap_terminal_info, _initialize_inflow): Update.
7715
7716 2019-05-08  Tom Tromey  <tom@tromey.com>
7717
7718         * target-dcache.c (target_dcache_cleanup): Remove.
7719         (target_dcache_aspace_key): Change type.
7720         (target_dcache_init_p, target_dcache_invalidate)
7721         (target_dcache_get, target_dcache_get_or_init)
7722         (_initialize_target_dcache): Update.
7723         * dcache.h (struct dcache_deleter): New.
7724
7725 2019-05-08  Tom Tromey  <tom@tromey.com>
7726
7727         * symtab.c (struct symbol_cache): Add destructor and
7728         initializers.
7729         (symbol_cache_key): Move.  Change type.
7730         (make_symbol_cache, free_symbol_cache): Remove.
7731         (get_symbol_cache): Update.
7732         (symbol_cache_cleanup): Remove.
7733         (ALL_PSPACES, symbol_cache_flush)
7734         (maintenance_print_symbol_cache)
7735         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7736         Update.
7737
7738 2019-05-08  Tom Tromey  <tom@tromey.com>
7739
7740         * symtab.c (struct main_info): Add destructor and initializers.
7741         (main_progspace_key): Move.  Change type.
7742         (get_main_info): Update.
7743         (main_info_cleanup): Remove.
7744         (_initialize_symtab): Update.
7745
7746 2019-05-08  Tom Tromey  <tom@tromey.com>
7747
7748         * registry.h (DECLARE_REGISTRY): Define the _key class.
7749
7750 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * NEWS: Merge two 'New commands' sections.
7753
7754 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7755
7756         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7757         parameter and use Ada language definition instead.
7758         (ada_val_print_ptr): Remove unused language parameter.
7759         (ada_val_print_num): Remove language parameter and use Ada language
7760         definition instead.
7761         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7762         parameter.
7763         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7764         parameter and use Ada language definition instead.
7765         (ada_val_print_1): Update all ada_val_print_xxx calls.
7766         Remove language parameter.
7767         (ada_val_print): Update ada_val_print_1 call.
7768
7769 2019-05-08  Tom Tromey  <tromey@adacore.com>
7770
7771         * remote.c (remote_hw_watchpoint_limit)
7772         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7773         Now static.
7774
7775 2019-05-08  Tom Tromey  <tromey@adacore.com>
7776
7777         * maint.c (_initialize_maint_cmds): Move initialization code to
7778         remote.c.
7779         (watchdog, show_watchdog): Move to remote.c.
7780         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7781         "watchdog" static.
7782         (_initialize_remote): Move initialization code from maint.c.
7783         * defs.h (watchdog): Don't declare.
7784
7785 2019-05-08  Tom Tromey  <tromey@adacore.com>
7786
7787         * tui/tui-interp.c: Include main.h.
7788         * interps.c: Include main.h.
7789         * main.h (interpreter_p): Declare.
7790         * defs.h (interpreter_p): Don't declare.
7791
7792 2019-05-08  Tom Tromey  <tromey@adacore.com>
7793
7794         * dwarf2loc.c: Include dwarf2read.h.
7795         * defs.h (read_unsigned_leb128): Don't declare.
7796         * dwarf2read.h (read_unsigned_leb128): Declare.
7797
7798 2019-05-08  Tom Tromey  <tromey@adacore.com>
7799
7800         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7801         method.
7802
7803 2019-05-08  Tom Tromey  <tromey@adacore.com>
7804
7805         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7806         when no wrap column is set.
7807
7808 2019-05-08  Tom Tromey  <tromey@adacore.com>
7809
7810         * c-lang.c (c_get_string): Handle non-C-style arrays.
7811
7812 2019-05-08  Tom Tromey  <tromey@adacore.com>
7813
7814         * typeprint.c (print_offset_data::update): Print the bit offset,
7815         not the number of bits remaining.
7816
7817 2019-05-08  Tom Tromey  <tromey@adacore.com>
7818
7819         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7820         padding at end of comment.
7821
7822 2019-05-08  Tom Tromey  <tromey@adacore.com>
7823
7824         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7825         Compare main types.
7826
7827 2019-05-06  Tom Tromey  <tom@tromey.com>
7828
7829         * common/scoped_mmap.c: Include common-defs.h.
7830         * common/scoped_mmap.h: Don't include config.h.
7831
7832 2019-05-04  Tom Tromey  <tom@tromey.com>
7833
7834         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7835         (struct aarch64_call_info): Add initializers.
7836         <si>: Now a std::vector.
7837         (pass_on_stack, aarch64_push_dummy_call): Update.
7838
7839 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7840             Tom Tromey  <tom@tromey.com>
7841
7842         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7843         (ppc_threads): Now a std::vector.  Now static.
7844         (hwdebug_find_thread_points_by_tid)
7845         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7846         Update.
7847
7848 2019-05-04  Tom Tromey  <tom@tromey.com>
7849
7850         * arc-tdep.c (arc_tdesc_init): Return bool.
7851
7852 2019-05-04  Tom Tromey  <tom@tromey.com>
7853
7854         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7855         Use gdb_assert_not_reached.
7856
7857 2019-05-04  Tom Tromey  <tom@tromey.com>
7858
7859         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7860         "false".
7861
7862 2019-05-04  Tom Tromey  <tom@tromey.com>
7863
7864         * arc-tdep.c (arc_tdesc_init): Use bool.
7865
7866 2019-05-04  Tom Tromey  <tom@tromey.com>
7867
7868         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7869
7870 2019-05-04  Tom Tromey  <tom@tromey.com>
7871
7872         * cli/cli-cmds.c (valid_command_p): Return bool.
7873
7874 2019-05-04  Tom Tromey  <tom@tromey.com>
7875
7876         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7877         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7878
7879 2019-05-04  Raul Tambre  <raul@tambre.ee>
7880
7881         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7882         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7883         operator for comparison.
7884
7885 2019-05-04  Tom Tromey  <tom@tromey.com>
7886
7887         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7888         (lookup_partial_symbol, print_partial_symbols)
7889         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7890         (psymbol_compare): Update.
7891         (add_psymbol_to_bcache): Clear the entire psymbol.
7892         (maintenance_check_psymtabs): Update.
7893         * psympriv.h (struct partial_symbol): Don't derive from
7894         general_symbol_info.
7895         <obj_section, unrelocated_address, address,
7896         set_unrelocated_address>: Update.
7897         <ginfo>: New member.
7898         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7899         (debug_names::write_psymbols): Update.
7900
7901 2019-05-04  Tom de Vries  <tdevries@suse.de>
7902
7903         * contrib/cc-with-tweaks.sh: Support -n arg.
7904
7905 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7906
7907         * corelow.c (core_target::detach): Ensure frame cache and
7908         register caches are cleared.
7909         inferior.c (exit_inferior_1): Likewise.
7910
7911 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7912             Tom Tromey  <tom@tromey.com>
7913
7914         * dictionary.c (collate_pending_symbols_by_language): Remove
7915         "struct" from foreach.
7916         * symtab.c (lookup_global_symbol_from_objfile)
7917         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7918         foreach.
7919         * ser-tcp.c (net_open): Remove "struct" from foreach.
7920         * objfiles.c (objfile_relocate, objfile_rebase)
7921         (objfile_has_symbols): Remove "struct" from foreach.
7922         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7923         from foreach.
7924         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7925         foreach.
7926         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7927         "struct" from foreach.
7928         * ada-lang.c (create_excep_cond_exprs)
7929         (ada_exception_catchpoint_cond_string): Remove "struct" from
7930         foreach.
7931
7932 2019-05-03  Tom Tromey  <tromey@adacore.com>
7933
7934         * ada-exp.y (convert_char_literal): Check suffix of each
7935         enumerator.
7936
7937 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7938
7939         PR ada/21406:
7940         * ada-exp.y (yywrap): Don't define.
7941         * ada-lex.l (%option): Add noyywrap
7942         (yywrap): Remove.
7943
7944 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7945
7946         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7947         _WIN32_WINNT to the XP level, unless already defined to a higher
7948         level.
7949
7950         * unittests/parse-connection-spec-selftests.c:
7951         * ser-tcp.c:
7952         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7953         override.
7954
7955         * symfile.c (find_separate_debug_file): Remove colon from the
7956         drive spec of DOS/Windows file names of the target, so that the
7957         file name produced from DEBUGDIR and the target's directory will
7958         be valid on DOS/Windows systems.
7959
7960 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * rust-lang.c (val_print_struct): Handle printing structures
7963         containing strings.
7964
7965 2019-05-02  Tom Tromey  <tromey@adacore.com>
7966
7967         * valarith.c (_initialize_valarith): Remove.
7968
7969 2019-05-01  Tom Tromey  <tromey@adacore.com>
7970
7971         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7972         bitfields.
7973
7974 2019-05-01  Tom Tromey  <tromey@adacore.com>
7975
7976         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7977         for big-endian copies.
7978
7979 2019-04-30  Ali Tamur  <tamur@google.com>
7980         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7981         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7982         (read_3_bytes): New function.
7983
7984 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7985
7986         * windows-nat.c (main_thread_id): Delete.
7987         (handle_output_debug_string): Replace main_thread_id by
7988         current_event.dwThreadId.
7989         (fake_create_process): Likewise.
7990         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7991         Do not set main_thread_id.
7992         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7993         current_event.dwThreadId.
7994         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7995
7996 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7997
7998         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7999         Use current_event.dwThreadId instead of main_thread_id.
8000
8001 2019-04-30  Tom Tromey  <tromey@adacore.com>
8002
8003         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8004         (create_excep_cond_exprs): Iterate over program spaces.
8005         (ada_exception_catchpoint_cond_string): Examine all minimal
8006         symbols for exception types.
8007
8008 2019-04-30  Tom Tromey  <tromey@adacore.com>
8009
8010         PR c++/24470:
8011         * dwarf2read.c (process_structure_scope): Handle case where type
8012         has template parameters but no symbol was created.
8013
8014 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8015             Chris January  <chris.january@arm.com>
8016
8017         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8018         qualifier.
8019         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8020
8021 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8022
8023         * f-typeprint.c (f_print_type): Update rules for printing
8024         whitespace.
8025         (f_type_print_varspec_suffix): Likewise.
8026
8027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8028             Chris January  <chris.january@arm.com>
8029
8030         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8031         function arguments.
8032
8033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * f-lang.c (build_fortran_types): Change name of void type to
8036         lower case.
8037         * f-typeprint.c (f_type_print_base): Print the name of the void
8038         type, rather than a fixed string.
8039         * f-valprint.c (f_decorations): Use lower case void string.
8040
8041 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8042             Chris January  <chris.january@arm.com>
8043
8044         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8045         types for Fortran.
8046
8047 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8048             Chris January  <chris.january@arm.com>
8049             David Lecomber  <david.lecomber@arm.com>
8050
8051         * f-exp.y (BINOP_INTRINSIC): New token.
8052         (exp): New parser rule handling BINOP_INTRINSIC.
8053         (f77_keywords): Add new builtin procedures.
8054         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8055         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8056         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8057         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8058         (print_unop_subexp_f): New function.
8059         (print_binop_subexp_f): New function.
8060         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8061         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8062         (dump_subexp_body_f): Likewise.
8063         (operator_check_f): Likewise.
8064         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8065         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8066
8067 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8068
8069         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8070         UNOP_KIND.
8071         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8072         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8073         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8074         (operator_length_f): New fuction.
8075         (print_subexp_f): New function.
8076         (op_name_f): New function.
8077         (dump_subexp_body_f): New function.
8078         (operator_check_f): New function.
8079         (exp_descriptor_f): Replace standard expression handling functions
8080         with new functions.
8081         * gdb/fortran-operator.def: New file.
8082         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8083         * gdb/std-operator.def: Remove UNOP_KIND.
8084
8085 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8086
8087         * std-operator.def: Remove unbalanced, stray double quote
8088         character.
8089
8090 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8091             Chris January  <chris.january@arm.com>
8092             Daniel Everett  <daniel.everett@arm.com>
8093             Nick Forrington  <nick.forrington@arm.com>
8094             Richard Bunt  <richard.bunt@arm.com>
8095
8096         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8097         of depth when printing anonymous structs or unions.
8098         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8099         Don't print either the top-level value, or the children if the
8100         max-depth is exceeded.
8101         (ppscm_print_children): When printing the key of a map, allow one
8102         extra level of depth.
8103         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8104         print either the top-level value, or the children if the max-depth
8105         is exceeded.
8106         (print_children): When printing the key of a map, allow one extra
8107         level of depth.
8108         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8109         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8110         (user_print_options): Initialise max_depth field.
8111         (val_print_scalar_or_string_type_p): New function.
8112         (val_print): Check to see if the max depth has been reached.
8113         (val_print_check_max_depth): Define new function.
8114         (show_print_max_depth): New function.
8115         (_initialize_valprint): Add 'print max-depth' option.
8116         * valprint.h (struct value_print_options) <max_depth>: New field.
8117         (val_print_check_max_depth): Declare new function.
8118         * NEWS: Document new feature.
8119
8120 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8121
8122         * ada-lang.c (ada_language_defn): Initialise new field.
8123         * c-lang.c (c_is_string_type_p): New function.
8124         (c_language_defn): Initialise new field.
8125         (cplus_language_defn): Initialise new field.
8126         (asm_language_defn): Initialise new field.
8127         (minimal_language_defn): Initialise new field.
8128         * c-lang.h (c_is_string_type_p): Declare new function.
8129         * d-lang.c (d_language_defn): Initialise new field.
8130         * f-lang.c (f_is_string_type_p): New function.
8131         (f_language_defn): Initialise new field.
8132         * go-lang.c (go_is_string_type_p): New function.
8133         (go_language_defn): Initialise new field.
8134         * language.c (default_is_string_type_p): New function.
8135         (unknown_language_defn): Initialise new field.
8136         (auto_language_defn): Initialise new field.
8137         * language.h (struct language_defn) <la_is_string_type_p>: New
8138         member variable.
8139         (default_is_string_type_p): Declare new function.
8140         * m2-lang.c (m2_language_defn): Initialise new field.
8141         * objc-lang.c (objc_language_defn): Initialise new field.
8142         * opencl-lang.c (opencl_language_defn): Initialise new field.
8143         * p-lang.c (pascal_is_string_type_p): New function.
8144         (pascal_language_defn): Initialise new field.
8145         * rust-lang.c (rust_is_string_type_p): New function.
8146         (rust_language_defn): Initialise new field.
8147
8148 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8149
8150         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8151         New field.
8152         * ada-lang.c (ada_language_defn): Initialise new field.
8153         * c-lang.c (c_language_defn): Likewise.
8154         (cplus_language_defn): Likewise.
8155         (asm_language_defn): Likewise.
8156         (minimal_language_defn): Likewise.
8157         * d-lang.c (d_language_defn): Likewise.
8158         * f-lang.c (f_language_defn): Likewise.
8159         * go-lang.c (go_language_defn): Likewise.
8160         * language.c (unknown_language_defn): Likewise.
8161         (auto_language_defn): Likewise.
8162         * m2-lang.c (m2_language_defn): Likewise.
8163         * objc-lang.c (objc_language_defn): Likewise.
8164         * opencl-lang.c (opencl_language_defn): Likewise.
8165         * p-lang.c (pascal_language_defn): Likewise.
8166         * rust-lang.c (rust_language_defn): Likewise.
8167
8168 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * ada-lang.c (ada_is_character_type): Change return type to bool.
8171         (ada_is_string_type): Likewise.
8172         * ada-lang.h (ada_is_character_type): Update declaration
8173         (ada_is_string_type): Likewise.
8174
8175 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8176
8177         Support style in 'frame|thread apply'
8178
8179         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8180         * record.c (record_start, record_stop): Update callers of
8181         execute_command_to_string with false.
8182         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8183         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8184         methods.
8185         (class string_file): New constructor with term_out parameter.
8186         Override methods term_out and can_emit_style_escape.  New member
8187         term_out.
8188         (class stdio_file): Override can_emit_style_escape.
8189         (class tee_file): Override term_out and can_emit_style_escape.
8190         * utils.h (can_emit_style_escape): Remove.
8191         * utils.c (can_emit_style_escape): Likewise.
8192         Update all callers of can_emit_style_escape (SOMESTREAM) to
8193         SOMESTREAM->can_emit_style_escape.
8194         * source-cache.c (source_cache::get_source_lines): Likewise.
8195         * stack.c (frame_apply_command_count): Call execute_command_to_string
8196         passing the term_out characteristic of the current gdb_stdout.
8197         * thread.c (thr_try_catch_cmd): Likewise.
8198         * top.c (execute_command_to_string): pass term_out parameter
8199         to construct the string_file for the command output.
8200         * ui-file.c (term_cli_styling): New function (most code moved
8201         from utils.c can_emit_style_escape).
8202         (string_file::string_file, string_file::can_emit_style_escape,
8203         stdio_file::can_emit_style_escape, tee_file::term_out,
8204         tee_file::can_emit_style_escape): New functions.
8205
8206 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8207
8208         * NEWS: Mention the new set|show may-call-functions.
8209         * infcall.c (may_call_functions_p): New variable.
8210         (show_may_call_functions_p): New function.
8211         (call_function_by_hand_dummy): Throws an error if not
8212         may-call-functions.
8213         (_initialize_infcall): Call add_setshow_boolean_cmd for
8214         may-call-functions.
8215
8216 2019-04-25  Keith Seitz  <keiths@redhat.com>
8217
8218         PR c++/24367
8219         * cp-support.c (inspect_type): Don't attempt substitutions
8220         of symbol with the same name.
8221
8222 2019-04-25  Tom Tromey  <tromey@adacore.com>
8223
8224         PR gdb/24475:
8225         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8226         static.
8227
8228 2019-04-25  Tom Tromey  <tromey@adacore.com>
8229
8230         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8231         rvalue reference.
8232         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8233         (gdb_xml_parser::parse): Use std::move.
8234         * python/python-internal.h (gdbpy_convert_exception): Take a const
8235         reference.
8236         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8237         std::move.
8238         * python/py-utils.c (gdbpy_convert_exception): Take a const
8239         reference.
8240         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8241         Use std::move.
8242         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8243         Use std::move.
8244         * mi/mi-main.c (mi_print_exception): Take a const reference.
8245         * main.c (handle_command_errors): Take a const reference.
8246         * linespec.c (parse_linespec): Use std::move.
8247         * infcall.c (run_inferior_call): Use std::move.
8248         (call_function_by_hand_dummy): Use std::move.
8249         * exec.c (try_open_exec_file): Use std::move.
8250         * exceptions.h (exception_print, exception_fprintf)
8251         (exception_print_same): Update.
8252         * exceptions.c (print_exception, exception_print)
8253         (exception_fprintf, exception_print_same): Change parameters to
8254         const reference.
8255         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8256         * common/new-op.c: Use std::move.
8257         * common/common-exceptions.h (struct gdb_exception): Add move
8258         constructor.
8259         (struct gdb_exception_error, struct gdb_exception_quit, struct
8260         gdb_quit_bad_alloc): Change constructor to move constructor.
8261         (throw_exception): Change parameter to rvalue reference.
8262         * common/common-exceptions.c (throw_exception): Take rvalue
8263         reference.
8264         * cli/cli-interp.c (safe_execute_command): Use std::move.
8265         * breakpoint.c (insert_bp_location, location_to_sals): Use
8266         std::move.
8267
8268 2019-04-25  Tom Tromey  <tromey@adacore.com>
8269
8270         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8271         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8272         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8273         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8274         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8275         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8276         guile/scm-value.c: Use unpack.
8277         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8278         gdbscm_gdb_exception.
8279         (gdbscm_throw_gdb_exception): Likewise.
8280         (struct gdbscm_gdb_exception): New.
8281         (unpack): New function.
8282         (gdbscm_wrap): Use unpack.
8283
8284 2019-04-25  Tom Tromey  <tromey@adacore.com>
8285
8286         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8287         (gdb_rl_callback_handler): Use std::move.
8288         * common/common-exceptions.h (struct gdb_exception): Add move
8289         assignment operator.
8290         (throw_exception_sjlj): Change "exception" to const reference.
8291         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8292         (throw_exception_sjlj): Change "exception" to const reference.
8293
8294 2019-04-25  Tom Tromey  <tromey@adacore.com>
8295
8296         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8297         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8298         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8299         Update.
8300         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8301         Update.
8302         * mi/mi-interp.c (mi_interp::exec): Update.
8303         * linespec.c (parse_linespec): Update.
8304         * infcall.c (run_inferior_call): Update.
8305         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8306         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8307         (gdbscm_lookup_global_symbol): Update.
8308         * guile/scm-param.c (gdbscm_parameter_value): Update.
8309         * guile/scm-frame.c (gdbscm_frame_read_register)
8310         (gdbscm_frame_read_var): Update.
8311         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8312         * exec.c (try_open_exec_file): Update.
8313         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8314         (gdb_rl_callback_handler): Update.
8315         * common/common-exceptions.h (exception_none): Don't declare.
8316         * common/common-exceptions.c (exception_none): Don't define.
8317         (struct catcher) <exception>: Update.
8318         * cli/cli-interp.c (safe_execute_command): Update.
8319         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8320
8321 2019-04-25  Ali Tamur  <tamur@google.com>
8322
8323         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8324         (read_attribute_value): Likewise.
8325         (dwarf2_read_addr_index): Update comment.
8326         (read_str_index): Add DW_FORM_strx.
8327         (dwarf2_string_attr): Likewise.
8328         (dwarf2_const_value_attr): Likewise.
8329         (dump_die_shallow): Likewise.
8330         (dwarf2_fetch_constant_bytes): Likewise.
8331         (skip_form_bytes): Likewise.
8332         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8333
8334 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8335
8336         PR corefiles/11608
8337         PR corefiles/18187
8338         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8339         OFFSET.  Verify if current mapping contains an ELF header.
8340         (linux_find_memory_regions_full): Adjust call to
8341         dump_mapping_p.
8342
8343 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8344             Kang Li <kanglictf@gmail.com>
8345
8346         PR gdb/21600
8347
8348         * dwarf2-frame.c (read_initial_length): Be consistent about using
8349         unsigned representation of length.
8350         (decode_frame_entry_1): Likewise.  Check for wraparound of
8351         end pointer as well as buffer overflow.
8352
8353 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8354
8355         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8356         "vq".
8357
8358 2019-04-24  Tom Tromey  <tromey@adacore.com>
8359
8360         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8361
8362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8363
8364         * s12z-tdep.c (s12z_unwind_pc): Delete.
8365         (s12z_unwind_sp): Delete.
8366         (s12z_gdbarch_init): Don't register deleted functions with
8367         gdbarch.
8368
8369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * rl78-tdep.c (rl78_unwind_sp): Delete.
8372         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8373
8374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8377         (xstormy16_unwind_pc): Delete.
8378         (xstormy16_dummy_id): Delete.
8379         (xstormy16_gdbarch_init): Don't register deleted functions with
8380         gdbarch.
8381
8382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8383
8384         * vax-tdep.c (vax_unwind_pc): Delete.
8385         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8386
8387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8388
8389         * v850-tdep.c (v850_unwind_sp): Delete.
8390         (v850_unwind_pc): Delete.
8391         (v850_dummy_id): Delete.
8392         (v850_gdbarch_init): Don't register deleted functions with
8393         gdbarch.
8394
8395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8396
8397         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8398         (tilegx_unwind_pc): Delete.
8399         (tilegx_unwind_dummy_id): Delete.
8400         (tilegx_gdbarch_init): Don't register deleted functions with
8401         gdbarch.
8402
8403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8404
8405         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8406         (tic6x_dummy_id): Delete.
8407         (tic6x_gdbarch_init): Don't register deleted functions with
8408         gdbarch.
8409
8410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * sparc-tdep.c (sparc_unwind_pc): Delete.
8413         (sparc32_gdbarch_init): Don't register deleted function with
8414         gdbarch.
8415
8416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * sh-tdep.c (sh_unwind_sp): Delete.
8419         (sh_unwind_pc): Delete.
8420         (sh_dummy_id): Delete.
8421         (sh_gdbarch_init): Don't register deleted functions with
8422         gdbarch.
8423
8424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8425
8426         * score-tdep.c (score_unwind_sp): Delete.
8427         (score_unwind_pc): Delete.
8428         (score_dummy_id): Delete.
8429         (score_gdbarch_init): Don't register deleted functions with
8430         gdbarch.
8431
8432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8433
8434         * rx-tdep.c (rx_unwind_pc): Delete.
8435         (rx_unwind_sp): Delete.
8436         (rx_dummy_id): Delete.
8437         (rx_gdbarch_init): Don't register deleted functions with
8438         gdbarch.  Update comment.
8439
8440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8441
8442         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8443         (rs6000_dummy_id): Delete.
8444         (rs6000_gdbarch_init): Don't register deleted functions with
8445         gdbarch.
8446
8447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8448
8449         * or1k-tdep.c (or1k_dummy_id): Delete.
8450         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8451
8452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8453
8454         * nios2-tdep.c (nios2_dummy_id): Delete.
8455         (nios2_unwind_sp): Delete.
8456         (nios2_gdbarch_init): Don't register deleted functions with
8457         gdbarch.
8458
8459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8460
8461         * nds32-tdep.c (nds32_dummy_id): Delete.
8462         (nds32_unwind_pc): Delete.
8463         (nds32_unwind_sp): Delete.
8464         (nds32_gdbarch_init): Don't register deleted functions with
8465         gdbarch.
8466
8467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8468
8469         * msp430-tdep.c (msp430_unwind_pc): Delete.
8470         (msp430_unwind_sp): Delete.
8471         (msp430_dummy_id): Delete.
8472         (msp430_gdbarch_init): Don't register deleted functions with
8473         gdbarch.
8474
8475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8476
8477         * moxie-tdep.c (moxie_unwind_sp): Delete.
8478         (moxie_unwind_pc): Delete.
8479         (moxie_dummy_id): Delete.
8480         (moxie_gdbarch_init): Don't register deleted functions with
8481         gdbarch.
8482
8483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8486         (mn10300_unwind_pc): Delete.
8487         (mn10300_unwind_sp): Delete.
8488         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8489         mn10300_unwind_sp.
8490         (mn10300_frame_unwind_init): Don't register deleted functions with
8491         gdbarch.
8492
8493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * mep-tdep.c (mep_unwind_pc): Delete.
8496         (mep_unwind_sp): Delete.
8497         (mep_dummy_id): Delete.
8498         (mep_gdbarch_init): Don't register deleted functions with
8499         gdbarch.
8500
8501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8502
8503         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8504         (m68hc11_unwind_sp): Delete.
8505         (m68hc11_gdbarch_init): Don't register deleted functions with
8506         gdbarch.
8507
8508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * m32r-tdep.c (m32r_unwind_sp): Delete.
8511         (m32r_unwind_pc): Delete.
8512         (m32r_dummy_id): Delete.
8513         (m32r_gdbarch_init): Don't register deleted functions with
8514         gdbarch.
8515
8516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * m32c-tdep.c (m32c_unwind_pc): Delete.
8519         (m32c_unwind_sp): Delete.
8520         (m32c_dummy_id): Delete.
8521         (m32c_gdbarch_init): Don't register deleted functions with
8522         gdbarch.
8523
8524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8527         (lm32_unwind_pc): Delete.
8528         (lm32_dummy_id): Delete.
8529         (lm32_gdbarch_init): Don't register deleted functions with
8530         gdbarch.
8531
8532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8535         (iq2000_unwind_pc): Delete.
8536         (iq2000_dummy_id): Delete.
8537         (iq2000_gdbarch_init): Don't register deleted functions with
8538         gdbarch.
8539
8540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * nds32-tdep.c (nds32_type_align): Delete.
8543         (nds32_push_dummy_call): Use type_align instead.
8544
8545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * arm-tdep.c (arm_type_align): Only handle vector override case.
8548         (arm_push_dummy_call): Use type_align.
8549         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8550
8551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8552
8553         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8554         case.
8555         (pass_on_stack): Use type_align.
8556         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8557         function.
8558
8559 2019-04-23  Tom Tromey  <tromey@adacore.com>
8560
8561         * dwarf2read.c (line_header::file_name_at): Remove unused
8562         overload.
8563
8564 2019-04-23  Tom de Vries  <tdevries@suse.de>
8565
8566         PR gdb/24438
8567         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8568         invocation.
8569
8570
8571 2019-03-27  Ali Tamur  <tamur@google.com>
8572
8573         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8574         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8575         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8576         (dwarf_expr_context::get_addr_index): Likewise
8577         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8578         (symbol_needs_eval_context::get_addr_index): Likewise
8579         (disassemble_dwarf_expression): Add DW_OP_addrx
8580         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8581         (read_cutu_die_from_dwo): Update comment
8582         (skip_one_die): Add DW_FORM_addrx
8583         (read_attribute_value): Likewise
8584         (var_decode_location): Add DW_OP_addrx
8585         (dwarf2_const_value_attr): Add DW_FORM_addrx
8586         (dump_die_shallow): Likewise
8587         (dwarf2_fetch_constant_bytes): Likewise
8588         (decode_locdesc): Add DW_OP_addrx
8589         (skip_form_bytes): Add DW_FORM_addrx
8590
8591 2019-04-22  Ali Tamur  <tamur@google.com>
8592
8593         * MAINTAINERS (Write After Approval): Add self.
8594
8595 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8596
8597         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8598         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8599         (open_symbol_file_object): Likewise.
8600         (svr4_default_sos): Add info parameter.
8601         (svr4_read_so_list): Likewise.
8602         (svr4_current_sos_direct): Adjust functions calls to pass down
8603         info.
8604         (svr4_current_sos_1): Add info parameter.
8605         (svr4_current_sos): Call get_svr4_info, pass info down to
8606         svr4_current_sos_1.
8607         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8608         get_svr4_info.
8609         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8610         get_svr4_info.
8611         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8612         to get_svr4_info.
8613         (probes_table_remove_objfile_probes): Likewise.
8614         (register_solib_event_probe): Add info parameter.
8615         (solist_update_incremental): Pass info parameter down to
8616         svr4_read_so_list.
8617         (disable_probes_interface): Add info parameter.
8618         (svr4_handle_solib_event): Pass current_program_space to
8619         get_svr4_info.  Adjust disable_probes_interface cleanup.
8620         (svr4_create_probe_breakpoints): Add info parameter, pass it
8621         down to register_solib_event_probe.
8622         (svr4_create_solib_event_breakpoints): Add info parameter,
8623         pass it down to svr4_create_probe_breakpoints.
8624         (enable_break): Pass info down to
8625         svr4_create_solib_event_breakpoints.
8626         (svr4_solib_create_inferior_hook): Pass current_program_space to
8627         get_svr4_info.
8628         (svr4_clear_solib): Likewise.
8629
8630 2019-04-22  Pedro Alves  <palves@redhat.com>
8631
8632         * solib-svr4.c (svr4_free_objfile_observer): New.
8633         (probe_and_action::objfile): New field.
8634         (probes_table_htab_remove_objfile_probes)
8635         (probes_table_remove_objfile_probes): New functions.
8636         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8637         in the new probe_and_action.  Don't store the probe in 'lookup'.
8638         (svr4_create_probe_breakpoints): Pass objfile to
8639         register_solib_event_probe.
8640         (_initialize_svr4_solib): Register a free_objfile observer.
8641
8642 2019-04-19  Tom Tromey  <tom@tromey.com>
8643
8644         * common/queue.h: Remove.
8645
8646 2019-04-19  Tom Tromey  <tom@tromey.com>
8647
8648         * event-loop.c: Don't include "common/queue.h".
8649
8650 2019-04-19  Tom Tromey  <tom@tromey.com>
8651
8652         * remote.c (remote_target): Use delete.
8653         * remote-notif.h: Include <list>, not "common/queue.h".
8654         (notif_client_p): Remove typedef.
8655         (remote_notif_state): Add constructor, destructor, initializer.
8656         <notif_queue>: Now a std::list.
8657         (remote_notif_state_xfree): Don't declare.
8658         * remote-notif.c (remote_notif_process, handle_notification)
8659         (remote_notif_state_allocate): Update.
8660         (~remote_notif_state): Rename from remote_notif_state_xfree.
8661
8662 2019-04-19  Tom Tromey  <tom@tromey.com>
8663
8664         * symfile.c (reread_symbols): Update.
8665         * objfiles.c (objfile_register_static_link)
8666         (objfile_lookup_static_link): Update
8667         (~objfile) Don't delete static_links.
8668         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8669
8670 2019-04-19  Tom Tromey  <tom@tromey.com>
8671
8672         * type-stack.h (struct type_stack) <insert>: Constify string.
8673         * type-stack.c (type_stack::insert): Constify string.
8674         * gdbtypes.h (lookup_template_type): Update.
8675         (address_space_name_to_int): Update.
8676         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8677         const.
8678         (lookup_template_type): Make name const.
8679         * c-exp.y: Update rules.
8680         (lex_one_token, classify_name, classify_inner_name)
8681         (c_print_token): Update.
8682         * p-exp.y: Update rules.
8683         (yylex): Update.
8684         * f-exp.y: Update rules.
8685         (yylex): Update.
8686         * d-exp.y: Update rules.
8687         (lex_one_token, classify_name, classify_inner_name): Update.
8688         * parse.c (write_dollar_variable, copy_name): Return std::string.
8689         * parser-defs.h (copy_name): Change return type.
8690         * m2-exp.y: Update rules.
8691         (yylex): Update.
8692         * go-exp.y (lex_one_token): Update.
8693         Update rules.
8694         (classify_unsafe_function, classify_packaged_name)
8695         (classify_name, yylex): Update.
8696
8697 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8698
8699         * configure.ac: add --enable-source-highlight switch.
8700         * configure: Regenerate.
8701         * top.c (print_gdb_version): plumb --enable-source-highlight
8702         status to "show configuration".
8703
8704 2019-04-19  Tom Tromey  <tromey@adacore.com>
8705
8706         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8707         Check ADA_TYPE_P.
8708         (empty_record, ada_template_to_fixed_record_type_1)
8709         (template_to_static_fixed_type)
8710         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8711         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8712         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8713         macros.
8714
8715 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8716
8717         PR symtab/24423:
8718         * source.c (print_source_lines_base): Advance "iter" when a
8719         control character is seen.
8720
8721 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8722
8723         * inferior.h (struct infcall_suspend_state_deleter):
8724         Catch exception in destructor to avoid crash.
8725
8726 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8727
8728         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8729         close to the add_com "shell".
8730
8731 2019-04-18  Tom Tromey  <tromey@adacore.com>
8732
8733         * process-stratum-target.h (class process_stratum_target)
8734         <stratum>: Add "final".
8735
8736 2019-04-17  Tom Tromey  <tromey@adacore.com>
8737
8738         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8739         against nullptr before use.
8740
8741 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8742
8743         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8744
8745 2019-04-17  Jim Wilson  <jimw@sifive.com>
8746             Andrew Burgess  <andrew.burgess@embecosm.com>
8747
8748         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8749         code read might fail, assume 4-byte breakpoint in that case.
8750
8751 2019-04-15  Leszek Swirski  <leszeks@google.com>
8752
8753         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8754         rather than a hand-rolled POD check when checking for forced MEMORY
8755         classification.
8756
8757 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8758
8759         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8760         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8761         function.
8762         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8763         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8764         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8765         declaration.
8766
8767 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8768
8769         * aarch64-linux-nat.c
8770         (aarch64_linux_nat_target::thread_architecture): Add override.
8771         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8772         each VQ.
8773
8774 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8775
8776         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8777
8778 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8779
8780         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8781         target types of size 96-bits, add some additional comments, and
8782         check that the builtin type we found was the correct size.
8783
8784 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8785
8786         * utils.c (prompt_for_continue): Don't restore the styling at the
8787         end, as applied_style has the wrong value.  This fixes styling in
8788         long lists of file names that are interrupted by the "Continue?"
8789         prompt.
8790
8791 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8792
8793         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8794         * c-lang.c (c_language_defn): Likewise.
8795         (cplus_language_defn): Likewise.
8796         (asm_language_defn): Likewise.
8797         (minimal_language_defn): Likewise.
8798         * d-lang.c (d_language_defn): Likewise.
8799         * f-lang.c (f_language_defn): Likewise.
8800         * go-lang.c (go_language_defn): Likewise.
8801         * language.c (unknown_language_defn): Likewise.
8802         (auto_language_defn): Likewise.
8803         * language.h (struct language_defn): Remove la_magic field.
8804         (LANG_MAGIC): Delete.
8805         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8806         * objc-lang.c (objc_language_defn): Likewise.
8807         * opencl-lang.c (opencl_language_defn): Likewise.
8808         * p-lang.c (pascal_language_defn): Likewise.
8809         * rust-lang.c (rust_language_defn): Likewise.
8810
8811 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8812
8813         * riscv-tdep.c (riscv_type_align): New function.
8814         (riscv_type_alignment): Delete.
8815         (riscv_arg_location): Use 'type_align'.
8816         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8817
8818 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * gdbtypes.c (type_align): A struct with no non-static fields also
8821         has alignment of 1.
8822
8823 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8826         component to 0.
8827         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8828         member.
8829         (riscv_struct_info::analyse): New implementation using new
8830         analyse_inner member function.
8831         (riscv_struct_info::field_offset): New member function.
8832         (riscv_struct_info::m_offsets): New member variable.
8833         (riscv_struct_info::analyse_inner): New private member function,
8834         takes the old implementation of riscv_struct_info::analyse but
8835         extended to track field offsets.
8836         (riscv_call_arg_struct): Update the struct folding special cases
8837         to handle cases where empty C++ structs, which are non-zero
8838         length, are found.
8839         (riscv_arg_location): Initialise the length of each location, a
8840         non-zero length now indicates the location is in use.
8841         (riscv_push_dummy_call): Allow for the first location having a
8842         non-zero offset when setting up arguments.
8843         (riscv_return_value): Likewise, but for return values.
8844
8845 2019-04-11  Tom Tromey  <tromey@adacore.com>
8846
8847         * utils.c (internal_vproblem): Make "msg" const.
8848
8849 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8850
8851         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8852         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8853         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8854         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8855
8856 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8857
8858         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8859         function.
8860         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8861         of amd64_collect_native_gregset.
8862         (amd64_linux_nat_target::store_registers): Likewise.
8863
8864 2019-04-10  Tom Tromey  <tom@tromey.com>
8865
8866         * symtab.c (lookup_global_symbol_from_objfile)
8867         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8868         * objfiles.h (class separate_debug_iterator): New.
8869         (class separate_debug_range): New.
8870         (struct objfile) <separate_debug_objfiles>: New method.
8871         (objfile_separate_debug_iterate): Don't declare.
8872         * objfiles.c (separate_debug_iterator::operator++): Rename from
8873         objfile_separate_debug_iterate.
8874         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8875         iterator.
8876         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8877         iterator.
8878
8879 2019-04-10  Tom Tromey  <tom@tromey.com>
8880
8881         * symfile.c (reread_symbols): Remove old comment.
8882         * objfiles.c (free_all_objfiles): Fix a typo.
8883
8884 2019-04-10  Tom Tromey  <tom@tromey.com>
8885
8886         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8887         * minsyms.c (lookup_minimal_symbol): Use foreach.
8888         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8889         (lookup_minimal_symbol_solib_trampoline): Likewise.
8890         * symfile.c (reread_symbols): Use foreach.
8891
8892 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8893             Tom Tromey  <tromey@adacore.com>
8894
8895         PR rust/24414:
8896         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8897         (rust_lex_int_test): Change "value" to be LONGEST.
8898         (rust_lex_tests): Add test for long integer literal.
8899
8900 2019-04-09  Tom Tromey  <tromey@adacore.com>
8901
8902         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8903         to bool.
8904         (extended_remote_target::attach): Update.
8905         (remote_target::remote_notice_new_inferior): Update.
8906         (remote_target::add_current_inferior_and_thread): Update.
8907         * inferior.c (exit_inferior_1): Use "false".
8908         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8909
8910 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8911
8912         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8913         the "start" command.
8914
8915 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8916
8917         * python/py-inferior.c (infpy_thread_from_thread_handle):
8918         Adjust comments to reflect renaming of thread_from_thread_handle
8919         to thread_from_handle.  Adjust keywords.  Fix type error message.
8920         (inferior_object_methods): Add thread_from_handle.  Retain
8921         thread_from_thread_handle, but mark it as deprecated.
8922
8923 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8924
8925         * gdbthread.h (find_thread_by_handle): Revise declaration.
8926         * thread.c (find_thread_by_handle): Likewise.  Adjust
8927         implementation too.
8928         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8929         support for buffer objects as handles.
8930
8931 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8932
8933         * python/py-infthread.c (thpy_thread_handle): New function.
8934         (thread_object_methods): Register thpy_thread_handle.
8935
8936 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8937
8938         * gdbthread.h (thread_to_thread_handle): Declare.
8939         * thread.c (gdbtypes.h): Include.
8940         (thread_to_thread_handle): New function.
8941
8942         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8943         (target_thread_info_to_thread_handle): Declare.
8944         * target.c (target_thread_info_to_thread_handle): New function.
8945         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8946         * target-delegates.c: Regenerate.
8947
8948         * linux-thread-db.c (class thread_db_target): Add method
8949         thread_info_to_thread_handle.
8950         (thread_db_target::thread_info_to_thread_handle): Define.
8951         * remote.c (class remote_target): Add new method
8952         thread_info_to_thread_handle.
8953         (remote_target::thread_info_to_thread_handle): Define.
8954
8955 2019-04-08  Pedro Alves  <palves@redhat.com>
8956
8957         * common/common-exceptions.c (throw_exception): Don't create
8958         named object to throw; throw directly.
8959         (throw_it): Likewise.  Don't initialize gdb_exception::message
8960         here, with new; pass FMT and AP to the ctor instead.
8961         * common/common-exceptions.h: Include <string>.
8962         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8963         const char *, va_list)): New ctor.  Use std::make_shared.
8964         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8965         errors)): Delete.
8966         (gdb_exception_error::gdb_exception_error(enum errors, const char
8967         *, va_list)): New.
8968         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8969         Add assertion.
8970         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8971         errors)): Delete.
8972         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8973         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8974         Add assertion.
8975
8976 2019-04-08  Tom Tromey  <tom@tromey.com>
8977
8978         * valops.c (value_rtti_indirect_type): Replace throw_exception
8979         with throw.
8980         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8981         with throw.
8982         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8983         throw.
8984         * target.c (target_translate_tls_address): Replace throw_exception
8985         with throw.
8986         * stack.c (frame_apply_command_count): Replace throw_exception
8987         with throw.
8988         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8989         throw.
8990         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8991         with throw.
8992         * rs6000-tdep.c (rs6000_frame_cache)
8993         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8994         * remote.c: Replace throw_exception with throw.
8995         * record-full.c (record_full_message, record_full_wait_1)
8996         (record_full_restore): Replace throw_exception with throw.
8997         * record-btrace.c:
8998         (get_thread_current_frame_id, record_btrace_start_replaying)
8999         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9000         (cmd_record_btrace_start): Replace throw_exception with throw.
9001         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9002         throw.
9003         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9004         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9005         * linespec.c:
9006         (find_linespec_symbols): Replace throw_exception with throw.
9007         * infrun.c (displaced_step_prepare, resume): Replace
9008         throw_exception with throw.
9009         * infcmd.c (post_create_inferior): Replace throw_exception with
9010         throw.
9011         * inf-loop.c (inferior_event_handler): Replace throw_exception
9012         with throw.
9013         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9014         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9015         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9016         (get_prev_frame_always, get_frame_pc_if_available)
9017         (get_frame_address_in_block_if_available, get_frame_language):
9018         Replace throw_exception with throw.
9019         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9020         throw_exception with throw.
9021         * eval.c (fetch_subexp_value, evaluate_var_value)
9022         (evaluate_funcall, evaluate_subexp_standard): Replace
9023         throw_exception with throw.
9024         * dwarf2loc.c (call_site_find_chain)
9025         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9026         Replace throw_exception with throw.
9027         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9028         with throw.
9029         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9030         throw.
9031         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9032         * completer.c (complete_line_internal): Replace throw_exception
9033         with throw.
9034         * compile/compile-object-run.c (compile_object_run): Replace
9035         throw_exception with throw.
9036         * cli/cli-script.c (process_next_line): Replace throw_exception
9037         with throw.
9038         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9039         (btrace_enable, btrace_maint_update_pt_packets): Replace
9040         throw_exception with throw.
9041         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9042         throw_exception with throw.
9043         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9044         throw_exception with throw.
9045         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9046         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9047         * aarch64-tdep.c (aarch64_make_prologue_cache)
9048         (aarch64_make_stub_cache): Replace throw_exception with throw.
9049
9050 2019-04-08  Tom Tromey  <tom@tromey.com>
9051
9052         * common/common-exceptions.c (throw_exception): Rename from
9053         throw_exception_cxx.  Remove old copy.  Make argument const.
9054         (throw_it): Create and throw exception objects directly.
9055         * common/common-exceptions.h (throw_exception): Make argument
9056         const.
9057         (struct gdb_exception_error): Add constructor.
9058         (struct gdb_exception_quit): Add constructor.
9059
9060 2019-04-08  Tom Tromey  <tom@tromey.com>
9061
9062         * common/common-exceptions.h (exception_rethrow): Don't declare.
9063         (TRY_SJLJ): Update comment.
9064         (TRY, CATCH, END_CATCH): Remove.
9065         * common/common-exceptions.c (exception_rethrow): Remove.
9066
9067 2019-04-08  Tom Tromey  <tom@tromey.com>
9068
9069         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9070         Remove.
9071         (gdb_exception_error): Rename from
9072         gdb_exception_RETURN_MASK_ERROR.
9073         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9074         (gdb_quit_bad_alloc): Update.
9075         * aarch64-tdep.c: Update.
9076         * ada-lang.c: Update.
9077         * ada-typeprint.c: Update.
9078         * ada-valprint.c: Update.
9079         * amd64-tdep.c: Update.
9080         * arch-utils.c: Update.
9081         * break-catch-throw.c: Update.
9082         * breakpoint.c: Update.
9083         * btrace.c: Update.
9084         * c-varobj.c: Update.
9085         * cli/cli-cmds.c: Update.
9086         * cli/cli-interp.c: Update.
9087         * cli/cli-script.c: Update.
9088         * common/common-exceptions.c: Update.
9089         * common/new-op.c: Update.
9090         * common/selftest.c: Update.
9091         * compile/compile-c-symbols.c: Update.
9092         * compile/compile-cplus-symbols.c: Update.
9093         * compile/compile-object-load.c: Update.
9094         * compile/compile-object-run.c: Update.
9095         * completer.c: Update.
9096         * corelow.c: Update.
9097         * cp-abi.c: Update.
9098         * cp-support.c: Update.
9099         * cp-valprint.c: Update.
9100         * darwin-nat.c: Update.
9101         * disasm-selftests.c: Update.
9102         * dtrace-probe.c: Update.
9103         * dwarf-index-cache.c: Update.
9104         * dwarf-index-write.c: Update.
9105         * dwarf2-frame-tailcall.c: Update.
9106         * dwarf2-frame.c: Update.
9107         * dwarf2loc.c: Update.
9108         * dwarf2read.c: Update.
9109         * eval.c: Update.
9110         * event-loop.c: Update.
9111         * event-top.c: Update.
9112         * exec.c: Update.
9113         * f-valprint.c: Update.
9114         * fbsd-tdep.c: Update.
9115         * frame-unwind.c: Update.
9116         * frame.c: Update.
9117         * gdbtypes.c: Update.
9118         * gnu-v3-abi.c: Update.
9119         * guile/guile-internal.h: Update.
9120         * guile/scm-block.c: Update.
9121         * guile/scm-breakpoint.c: Update.
9122         * guile/scm-cmd.c: Update.
9123         * guile/scm-disasm.c: Update.
9124         * guile/scm-frame.c: Update.
9125         * guile/scm-lazy-string.c: Update.
9126         * guile/scm-math.c: Update.
9127         * guile/scm-param.c: Update.
9128         * guile/scm-ports.c: Update.
9129         * guile/scm-pretty-print.c: Update.
9130         * guile/scm-symbol.c: Update.
9131         * guile/scm-symtab.c: Update.
9132         * guile/scm-type.c: Update.
9133         * guile/scm-value.c: Update.
9134         * i386-linux-tdep.c: Update.
9135         * i386-tdep.c: Update.
9136         * inf-loop.c: Update.
9137         * infcall.c: Update.
9138         * infcmd.c: Update.
9139         * infrun.c: Update.
9140         * jit.c: Update.
9141         * language.c: Update.
9142         * linespec.c: Update.
9143         * linux-fork.c: Update.
9144         * linux-nat.c: Update.
9145         * linux-tdep.c: Update.
9146         * linux-thread-db.c: Update.
9147         * main.c: Update.
9148         * mi/mi-cmd-break.c: Update.
9149         * mi/mi-cmd-stack.c: Update.
9150         * mi/mi-interp.c: Update.
9151         * mi/mi-main.c: Update.
9152         * objc-lang.c: Update.
9153         * p-valprint.c: Update.
9154         * parse.c: Update.
9155         * ppc-linux-tdep.c: Update.
9156         * printcmd.c: Update.
9157         * python/py-arch.c: Update.
9158         * python/py-breakpoint.c: Update.
9159         * python/py-cmd.c: Update.
9160         * python/py-finishbreakpoint.c: Update.
9161         * python/py-frame.c: Update.
9162         * python/py-framefilter.c: Update.
9163         * python/py-gdb-readline.c: Update.
9164         * python/py-inferior.c: Update.
9165         * python/py-infthread.c: Update.
9166         * python/py-lazy-string.c: Update.
9167         * python/py-linetable.c: Update.
9168         * python/py-objfile.c: Update.
9169         * python/py-param.c: Update.
9170         * python/py-prettyprint.c: Update.
9171         * python/py-progspace.c: Update.
9172         * python/py-record-btrace.c: Update.
9173         * python/py-record.c: Update.
9174         * python/py-symbol.c: Update.
9175         * python/py-type.c: Update.
9176         * python/py-unwind.c: Update.
9177         * python/py-utils.c: Update.
9178         * python/py-value.c: Update.
9179         * python/python.c: Update.
9180         * record-btrace.c: Update.
9181         * record-full.c: Update.
9182         * remote-fileio.c: Update.
9183         * remote.c: Update.
9184         * riscv-tdep.c: Update.
9185         * rs6000-aix-tdep.c: Update.
9186         * rs6000-tdep.c: Update.
9187         * rust-exp.y: Update.
9188         * rust-lang.c: Update.
9189         * s390-tdep.c: Update.
9190         * selftest-arch.c: Update.
9191         * solib-dsbt.c: Update.
9192         * solib-frv.c: Update.
9193         * solib-spu.c: Update.
9194         * solib-svr4.c: Update.
9195         * solib.c: Update.
9196         * sparc64-linux-tdep.c: Update.
9197         * stack.c: Update.
9198         * symfile-mem.c: Update.
9199         * symmisc.c: Update.
9200         * target.c: Update.
9201         * thread.c: Update.
9202         * top.c: Update.
9203         * tracefile-tfile.c: Update.
9204         * tui/tui.c: Update.
9205         * typeprint.c: Update.
9206         * unittests/cli-utils-selftests.c: Update.
9207         * unittests/parse-connection-spec-selftests.c: Update.
9208         * valops.c: Update.
9209         * valprint.c: Update.
9210         * value.c: Update.
9211         * varobj.c: Update.
9212         * windows-nat.c: Update.
9213         * x86-linux-nat.c: Update.
9214         * xml-support.c: Update.
9215
9216 2019-04-08  Tom Tromey  <tom@tromey.com>
9217
9218         * xml-support.c: Use C++ exception handling.
9219         * x86-linux-nat.c: Use C++ exception handling.
9220         * windows-nat.c: Use C++ exception handling.
9221         * varobj.c: Use C++ exception handling.
9222         * value.c: Use C++ exception handling.
9223         * valprint.c: Use C++ exception handling.
9224         * valops.c: Use C++ exception handling.
9225         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9226         handling.
9227         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9228         * typeprint.c: Use C++ exception handling.
9229         * tui/tui.c: Use C++ exception handling.
9230         * tracefile-tfile.c: Use C++ exception handling.
9231         * top.c: Use C++ exception handling.
9232         * thread.c: Use C++ exception handling.
9233         * target.c: Use C++ exception handling.
9234         * symmisc.c: Use C++ exception handling.
9235         * symfile-mem.c: Use C++ exception handling.
9236         * stack.c: Use C++ exception handling.
9237         * sparc64-linux-tdep.c: Use C++ exception handling.
9238         * solib.c: Use C++ exception handling.
9239         * solib-svr4.c: Use C++ exception handling.
9240         * solib-spu.c: Use C++ exception handling.
9241         * solib-frv.c: Use C++ exception handling.
9242         * solib-dsbt.c: Use C++ exception handling.
9243         * selftest-arch.c: Use C++ exception handling.
9244         * s390-tdep.c: Use C++ exception handling.
9245         * rust-lang.c: Use C++ exception handling.
9246         * rust-exp.y: Use C++ exception handling.
9247         * rs6000-tdep.c: Use C++ exception handling.
9248         * rs6000-aix-tdep.c: Use C++ exception handling.
9249         * riscv-tdep.c: Use C++ exception handling.
9250         * remote.c: Use C++ exception handling.
9251         * remote-fileio.c: Use C++ exception handling.
9252         * record-full.c: Use C++ exception handling.
9253         * record-btrace.c: Use C++ exception handling.
9254         * python/python.c: Use C++ exception handling.
9255         * python/py-value.c: Use C++ exception handling.
9256         * python/py-utils.c: Use C++ exception handling.
9257         * python/py-unwind.c: Use C++ exception handling.
9258         * python/py-type.c: Use C++ exception handling.
9259         * python/py-symbol.c: Use C++ exception handling.
9260         * python/py-record.c: Use C++ exception handling.
9261         * python/py-record-btrace.c: Use C++ exception handling.
9262         * python/py-progspace.c: Use C++ exception handling.
9263         * python/py-prettyprint.c: Use C++ exception handling.
9264         * python/py-param.c: Use C++ exception handling.
9265         * python/py-objfile.c: Use C++ exception handling.
9266         * python/py-linetable.c: Use C++ exception handling.
9267         * python/py-lazy-string.c: Use C++ exception handling.
9268         * python/py-infthread.c: Use C++ exception handling.
9269         * python/py-inferior.c: Use C++ exception handling.
9270         * python/py-gdb-readline.c: Use C++ exception handling.
9271         * python/py-framefilter.c: Use C++ exception handling.
9272         * python/py-frame.c: Use C++ exception handling.
9273         * python/py-finishbreakpoint.c: Use C++ exception handling.
9274         * python/py-cmd.c: Use C++ exception handling.
9275         * python/py-breakpoint.c: Use C++ exception handling.
9276         * python/py-arch.c: Use C++ exception handling.
9277         * printcmd.c: Use C++ exception handling.
9278         * ppc-linux-tdep.c: Use C++ exception handling.
9279         * parse.c: Use C++ exception handling.
9280         * p-valprint.c: Use C++ exception handling.
9281         * objc-lang.c: Use C++ exception handling.
9282         * mi/mi-main.c: Use C++ exception handling.
9283         * mi/mi-interp.c: Use C++ exception handling.
9284         * mi/mi-cmd-stack.c: Use C++ exception handling.
9285         * mi/mi-cmd-break.c: Use C++ exception handling.
9286         * main.c: Use C++ exception handling.
9287         * linux-thread-db.c: Use C++ exception handling.
9288         * linux-tdep.c: Use C++ exception handling.
9289         * linux-nat.c: Use C++ exception handling.
9290         * linux-fork.c: Use C++ exception handling.
9291         * linespec.c: Use C++ exception handling.
9292         * language.c: Use C++ exception handling.
9293         * jit.c: Use C++ exception handling.
9294         * infrun.c: Use C++ exception handling.
9295         * infcmd.c: Use C++ exception handling.
9296         * infcall.c: Use C++ exception handling.
9297         * inf-loop.c: Use C++ exception handling.
9298         * i386-tdep.c: Use C++ exception handling.
9299         * i386-linux-tdep.c: Use C++ exception handling.
9300         * guile/scm-value.c: Use C++ exception handling.
9301         * guile/scm-type.c: Use C++ exception handling.
9302         * guile/scm-symtab.c: Use C++ exception handling.
9303         * guile/scm-symbol.c: Use C++ exception handling.
9304         * guile/scm-pretty-print.c: Use C++ exception handling.
9305         * guile/scm-ports.c: Use C++ exception handling.
9306         * guile/scm-param.c: Use C++ exception handling.
9307         * guile/scm-math.c: Use C++ exception handling.
9308         * guile/scm-lazy-string.c: Use C++ exception handling.
9309         * guile/scm-frame.c: Use C++ exception handling.
9310         * guile/scm-disasm.c: Use C++ exception handling.
9311         * guile/scm-cmd.c: Use C++ exception handling.
9312         * guile/scm-breakpoint.c: Use C++ exception handling.
9313         * guile/scm-block.c: Use C++ exception handling.
9314         * guile/guile-internal.h: Use C++ exception handling.
9315         * gnu-v3-abi.c: Use C++ exception handling.
9316         * gdbtypes.c: Use C++ exception handling.
9317         * frame.c: Use C++ exception handling.
9318         * frame-unwind.c: Use C++ exception handling.
9319         * fbsd-tdep.c: Use C++ exception handling.
9320         * f-valprint.c: Use C++ exception handling.
9321         * exec.c: Use C++ exception handling.
9322         * event-top.c: Use C++ exception handling.
9323         * event-loop.c: Use C++ exception handling.
9324         * eval.c: Use C++ exception handling.
9325         * dwarf2read.c: Use C++ exception handling.
9326         * dwarf2loc.c: Use C++ exception handling.
9327         * dwarf2-frame.c: Use C++ exception handling.
9328         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9329         * dwarf-index-write.c: Use C++ exception handling.
9330         * dwarf-index-cache.c: Use C++ exception handling.
9331         * dtrace-probe.c: Use C++ exception handling.
9332         * disasm-selftests.c: Use C++ exception handling.
9333         * darwin-nat.c: Use C++ exception handling.
9334         * cp-valprint.c: Use C++ exception handling.
9335         * cp-support.c: Use C++ exception handling.
9336         * cp-abi.c: Use C++ exception handling.
9337         * corelow.c: Use C++ exception handling.
9338         * completer.c: Use C++ exception handling.
9339         * compile/compile-object-run.c: Use C++ exception handling.
9340         * compile/compile-object-load.c: Use C++ exception handling.
9341         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9342         * compile/compile-c-symbols.c: Use C++ exception handling.
9343         * common/selftest.c: Use C++ exception handling.
9344         * common/new-op.c: Use C++ exception handling.
9345         * cli/cli-script.c: Use C++ exception handling.
9346         * cli/cli-interp.c: Use C++ exception handling.
9347         * cli/cli-cmds.c: Use C++ exception handling.
9348         * c-varobj.c: Use C++ exception handling.
9349         * btrace.c: Use C++ exception handling.
9350         * breakpoint.c: Use C++ exception handling.
9351         * break-catch-throw.c: Use C++ exception handling.
9352         * arch-utils.c: Use C++ exception handling.
9353         * amd64-tdep.c: Use C++ exception handling.
9354         * ada-valprint.c: Use C++ exception handling.
9355         * ada-typeprint.c: Use C++ exception handling.
9356         * ada-lang.c: Use C++ exception handling.
9357         * aarch64-tdep.c: Use C++ exception handling.
9358
9359 2019-04-08  Tom Tromey  <tom@tromey.com>
9360
9361         * xml-support.c (gdb_xml_parser::parse): Update.
9362         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9363         * value.c (show_convenience): Update.
9364         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9365         (test_parse_flags_qcs): Update.
9366         * thread.c (thr_try_catch_cmd): Update.
9367         * target.c (target_translate_tls_address): Update.
9368         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9369         (info_frame_command_core, frame_apply_command_count): Update.
9370         * rust-exp.y (rust_lex_exception_test): Update.
9371         * riscv-tdep.c (riscv_print_one_register_info): Update.
9372         * remote.c (remote_target::enable_btrace): Update.
9373         * record-btrace.c (record_btrace_enable_warn): Update.
9374         * python/py-utils.c (gdbpy_convert_exception): Update.
9375         * printcmd.c (do_one_display, print_variable_and_value): Update.
9376         * mi/mi-main.c (mi_print_exception): Update.
9377         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9378         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9379         * linux-nat.c (linux_nat_target::attach): Update.
9380         * linux-fork.c (class scoped_switch_fork_info): Update.
9381         * infrun.c (displaced_step_prepare): Update.
9382         * infcall.c (call_function_by_hand_dummy): Update.
9383         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9384         * gnu-v3-abi.c (print_one_vtable): Update.
9385         * frame.c (get_prev_frame_always): Update.
9386         * f-valprint.c (info_common_command_for_block): Update.
9387         * exec.c (try_open_exec_file): Update.
9388         * exceptions.c (print_exception, exception_print)
9389         (exception_fprintf, exception_print_same): Update.
9390         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9391         * dwarf-index-cache.c (index_cache::store)
9392         (index_cache::lookup_gdb_index): Update.
9393         * darwin-nat.c (maybe_cache_shell): Update.
9394         * cp-valprint.c (cp_print_value_fields): Update.
9395         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9396         (gcc_cplus_symbol_address): Update.
9397         * compile/compile-c-symbols.c (gcc_convert_symbol)
9398         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9399         * common/selftest.c: Update.
9400         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9401         a std::string.
9402         (exception_try_scope_entry, exception_try_scope_exit): Don't
9403         declare.
9404         (struct exception_try_scope): Remove.
9405         (TRY): Don't use exception_try_scope.
9406         (struct gdb_exception): Add constructor, operator=.
9407         <what>: New method.
9408         (struct gdb_exception_RETURN_MASK_ALL)
9409         (struct gdb_exception_RETURN_MASK_ERROR)
9410         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9411         (struct gdb_quit_bad_alloc): Update.
9412         * common/common-exceptions.c (exception_none): Change
9413         initializer.
9414         (struct catcher) <state, exception>: Initialize inline.
9415         <prev>: Remove member.
9416         (current_catcher): Remove.
9417         (catchers): New global.
9418         (exceptions_state_mc_init): Simplify.
9419         (catcher_pop): Remove.
9420         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9421         (try_scope_depth, exception_try_scope_entry)
9422         (exception_try_scope_exit): Remove.
9423         (throw_exception_sjlj): Update.
9424         (exception_messages, exception_messages_size): Remove.
9425         (throw_it): Simplify.
9426         (gdb_exception_sliced_copy): Remove.
9427         (throw_exception_cxx): Update.
9428         * cli/cli-script.c (script_from_file): Update.
9429         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9430         Update.
9431         * ada-valprint.c (ada_val_print): Update.
9432         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9433         (create_excep_cond_exprs): Update.
9434
9435 2019-04-08  Tom Tromey  <tom@tromey.com>
9436
9437         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9438         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9439         (TRY, CATCH, END_CATCH): Remove some definitions.
9440         * common/common-exceptions.c: Don't use GDB_XCPT.
9441         (catcher_list_size): Remove.
9442         (throw_exception, throw_it): Simplify.
9443
9444 2019-04-05  Tom Tromey  <tom@tromey.com>
9445
9446         Revert the header-sorting patch.
9447         * ft32-tdep.c: Revert.
9448         * frv-tdep.c: Revert.
9449         * frv-linux-tdep.c: Revert.
9450         * frame.c: Revert.
9451         * frame-unwind.c: Revert.
9452         * frame-base.c: Revert.
9453         * fork-child.c: Revert.
9454         * findvar.c: Revert.
9455         * findcmd.c: Revert.
9456         * filesystem.c: Revert.
9457         * filename-seen-cache.h: Revert.
9458         * filename-seen-cache.c: Revert.
9459         * fbsd-tdep.c: Revert.
9460         * fbsd-nat.h: Revert.
9461         * fbsd-nat.c: Revert.
9462         * f-valprint.c: Revert.
9463         * f-typeprint.c: Revert.
9464         * f-lang.c: Revert.
9465         * extension.h: Revert.
9466         * extension.c: Revert.
9467         * extension-priv.h: Revert.
9468         * expprint.c: Revert.
9469         * exec.h: Revert.
9470         * exec.c: Revert.
9471         * exceptions.c: Revert.
9472         * event-top.c: Revert.
9473         * event-loop.c: Revert.
9474         * eval.c: Revert.
9475         * elfread.c: Revert.
9476         * dwarf2read.h: Revert.
9477         * dwarf2read.c: Revert.
9478         * dwarf2loc.c: Revert.
9479         * dwarf2expr.h: Revert.
9480         * dwarf2expr.c: Revert.
9481         * dwarf2-frame.c: Revert.
9482         * dwarf2-frame-tailcall.c: Revert.
9483         * dwarf-index-write.h: Revert.
9484         * dwarf-index-write.c: Revert.
9485         * dwarf-index-common.c: Revert.
9486         * dwarf-index-cache.h: Revert.
9487         * dwarf-index-cache.c: Revert.
9488         * dummy-frame.c: Revert.
9489         * dtrace-probe.c: Revert.
9490         * disasm.h: Revert.
9491         * disasm.c: Revert.
9492         * disasm-selftests.c: Revert.
9493         * dictionary.c: Revert.
9494         * dicos-tdep.c: Revert.
9495         * demangle.c: Revert.
9496         * dcache.h: Revert.
9497         * dcache.c: Revert.
9498         * darwin-nat.h: Revert.
9499         * darwin-nat.c: Revert.
9500         * darwin-nat-info.c: Revert.
9501         * d-valprint.c: Revert.
9502         * d-namespace.c: Revert.
9503         * d-lang.c: Revert.
9504         * ctf.c: Revert.
9505         * csky-tdep.c: Revert.
9506         * csky-linux-tdep.c: Revert.
9507         * cris-tdep.c: Revert.
9508         * cris-linux-tdep.c: Revert.
9509         * cp-valprint.c: Revert.
9510         * cp-support.c: Revert.
9511         * cp-namespace.c: Revert.
9512         * cp-abi.c: Revert.
9513         * corelow.c: Revert.
9514         * corefile.c: Revert.
9515         * continuations.c: Revert.
9516         * completer.h: Revert.
9517         * completer.c: Revert.
9518         * complaints.c: Revert.
9519         * coffread.c: Revert.
9520         * coff-pe-read.c: Revert.
9521         * cli-out.h: Revert.
9522         * cli-out.c: Revert.
9523         * charset.c: Revert.
9524         * c-varobj.c: Revert.
9525         * c-valprint.c: Revert.
9526         * c-typeprint.c: Revert.
9527         * c-lang.c: Revert.
9528         * buildsym.c: Revert.
9529         * buildsym-legacy.c: Revert.
9530         * build-id.h: Revert.
9531         * build-id.c: Revert.
9532         * btrace.c: Revert.
9533         * bsd-uthread.c: Revert.
9534         * breakpoint.h: Revert.
9535         * breakpoint.c: Revert.
9536         * break-catch-throw.c: Revert.
9537         * break-catch-syscall.c: Revert.
9538         * break-catch-sig.c: Revert.
9539         * blockframe.c: Revert.
9540         * block.c: Revert.
9541         * bfin-tdep.c: Revert.
9542         * bfin-linux-tdep.c: Revert.
9543         * bfd-target.c: Revert.
9544         * bcache.c: Revert.
9545         * ax-general.c: Revert.
9546         * ax-gdb.h: Revert.
9547         * ax-gdb.c: Revert.
9548         * avr-tdep.c: Revert.
9549         * auxv.c: Revert.
9550         * auto-load.c: Revert.
9551         * arm-wince-tdep.c: Revert.
9552         * arm-tdep.c: Revert.
9553         * arm-symbian-tdep.c: Revert.
9554         * arm-pikeos-tdep.c: Revert.
9555         * arm-obsd-tdep.c: Revert.
9556         * arm-nbsd-tdep.c: Revert.
9557         * arm-nbsd-nat.c: Revert.
9558         * arm-linux-tdep.c: Revert.
9559         * arm-linux-nat.c: Revert.
9560         * arm-fbsd-tdep.c: Revert.
9561         * arm-fbsd-nat.c: Revert.
9562         * arm-bsd-tdep.c: Revert.
9563         * arch-utils.c: Revert.
9564         * arc-tdep.c: Revert.
9565         * arc-newlib-tdep.c: Revert.
9566         * annotate.h: Revert.
9567         * annotate.c: Revert.
9568         * amd64-windows-tdep.c: Revert.
9569         * amd64-windows-nat.c: Revert.
9570         * amd64-tdep.c: Revert.
9571         * amd64-sol2-tdep.c: Revert.
9572         * amd64-obsd-tdep.c: Revert.
9573         * amd64-obsd-nat.c: Revert.
9574         * amd64-nbsd-tdep.c: Revert.
9575         * amd64-nbsd-nat.c: Revert.
9576         * amd64-nat.c: Revert.
9577         * amd64-linux-tdep.c: Revert.
9578         * amd64-linux-nat.c: Revert.
9579         * amd64-fbsd-tdep.c: Revert.
9580         * amd64-fbsd-nat.c: Revert.
9581         * amd64-dicos-tdep.c: Revert.
9582         * amd64-darwin-tdep.c: Revert.
9583         * amd64-bsd-nat.c: Revert.
9584         * alpha-tdep.c: Revert.
9585         * alpha-obsd-tdep.c: Revert.
9586         * alpha-nbsd-tdep.c: Revert.
9587         * alpha-mdebug-tdep.c: Revert.
9588         * alpha-linux-tdep.c: Revert.
9589         * alpha-linux-nat.c: Revert.
9590         * alpha-bsd-tdep.c: Revert.
9591         * alpha-bsd-nat.c: Revert.
9592         * aix-thread.c: Revert.
9593         * agent.c: Revert.
9594         * addrmap.c: Revert.
9595         * ada-varobj.c: Revert.
9596         * ada-valprint.c: Revert.
9597         * ada-typeprint.c: Revert.
9598         * ada-tasks.c: Revert.
9599         * ada-lang.c: Revert.
9600         * aarch64-tdep.c: Revert.
9601         * aarch64-ravenscar-thread.c: Revert.
9602         * aarch64-newlib-tdep.c: Revert.
9603         * aarch64-linux-tdep.c: Revert.
9604         * aarch64-linux-nat.c: Revert.
9605         * aarch64-fbsd-tdep.c: Revert.
9606         * aarch64-fbsd-nat.c: Revert.
9607         * aarch32-linux-nat.c: Revert.
9608
9609 2019-04-05  Tom Tromey  <tom@tromey.com>
9610
9611         * ft32-tdep.c: Sort headers.
9612         * frv-tdep.c: Sort headers.
9613         * frv-linux-tdep.c: Sort headers.
9614         * frame.c: Sort headers.
9615         * frame-unwind.c: Sort headers.
9616         * frame-base.c: Sort headers.
9617         * fork-child.c: Sort headers.
9618         * findvar.c: Sort headers.
9619         * findcmd.c: Sort headers.
9620         * filesystem.c: Sort headers.
9621         * filename-seen-cache.h: Sort headers.
9622         * filename-seen-cache.c: Sort headers.
9623         * fbsd-tdep.c: Sort headers.
9624         * fbsd-nat.h: Sort headers.
9625         * fbsd-nat.c: Sort headers.
9626         * f-valprint.c: Sort headers.
9627         * f-typeprint.c: Sort headers.
9628         * f-lang.c: Sort headers.
9629         * extension.h: Sort headers.
9630         * extension.c: Sort headers.
9631         * extension-priv.h: Sort headers.
9632         * expprint.c: Sort headers.
9633         * exec.h: Sort headers.
9634         * exec.c: Sort headers.
9635         * exceptions.c: Sort headers.
9636         * event-top.c: Sort headers.
9637         * event-loop.c: Sort headers.
9638         * eval.c: Sort headers.
9639         * elfread.c: Sort headers.
9640         * dwarf2read.h: Sort headers.
9641         * dwarf2read.c: Sort headers.
9642         * dwarf2loc.c: Sort headers.
9643         * dwarf2expr.h: Sort headers.
9644         * dwarf2expr.c: Sort headers.
9645         * dwarf2-frame.c: Sort headers.
9646         * dwarf2-frame-tailcall.c: Sort headers.
9647         * dwarf-index-write.h: Sort headers.
9648         * dwarf-index-write.c: Sort headers.
9649         * dwarf-index-common.c: Sort headers.
9650         * dwarf-index-cache.h: Sort headers.
9651         * dwarf-index-cache.c: Sort headers.
9652         * dummy-frame.c: Sort headers.
9653         * dtrace-probe.c: Sort headers.
9654         * disasm.h: Sort headers.
9655         * disasm.c: Sort headers.
9656         * disasm-selftests.c: Sort headers.
9657         * dictionary.c: Sort headers.
9658         * dicos-tdep.c: Sort headers.
9659         * demangle.c: Sort headers.
9660         * dcache.h: Sort headers.
9661         * dcache.c: Sort headers.
9662         * darwin-nat.h: Sort headers.
9663         * darwin-nat.c: Sort headers.
9664         * darwin-nat-info.c: Sort headers.
9665         * d-valprint.c: Sort headers.
9666         * d-namespace.c: Sort headers.
9667         * d-lang.c: Sort headers.
9668         * ctf.c: Sort headers.
9669         * csky-tdep.c: Sort headers.
9670         * csky-linux-tdep.c: Sort headers.
9671         * cris-tdep.c: Sort headers.
9672         * cris-linux-tdep.c: Sort headers.
9673         * cp-valprint.c: Sort headers.
9674         * cp-support.c: Sort headers.
9675         * cp-namespace.c: Sort headers.
9676         * cp-abi.c: Sort headers.
9677         * corelow.c: Sort headers.
9678         * corefile.c: Sort headers.
9679         * continuations.c: Sort headers.
9680         * completer.h: Sort headers.
9681         * completer.c: Sort headers.
9682         * complaints.c: Sort headers.
9683         * coffread.c: Sort headers.
9684         * coff-pe-read.c: Sort headers.
9685         * cli-out.h: Sort headers.
9686         * cli-out.c: Sort headers.
9687         * charset.c: Sort headers.
9688         * c-varobj.c: Sort headers.
9689         * c-valprint.c: Sort headers.
9690         * c-typeprint.c: Sort headers.
9691         * c-lang.c: Sort headers.
9692         * buildsym.c: Sort headers.
9693         * buildsym-legacy.c: Sort headers.
9694         * build-id.h: Sort headers.
9695         * build-id.c: Sort headers.
9696         * btrace.c: Sort headers.
9697         * bsd-uthread.c: Sort headers.
9698         * breakpoint.h: Sort headers.
9699         * breakpoint.c: Sort headers.
9700         * break-catch-throw.c: Sort headers.
9701         * break-catch-syscall.c: Sort headers.
9702         * break-catch-sig.c: Sort headers.
9703         * blockframe.c: Sort headers.
9704         * block.c: Sort headers.
9705         * bfin-tdep.c: Sort headers.
9706         * bfin-linux-tdep.c: Sort headers.
9707         * bfd-target.c: Sort headers.
9708         * bcache.c: Sort headers.
9709         * ax-general.c: Sort headers.
9710         * ax-gdb.h: Sort headers.
9711         * ax-gdb.c: Sort headers.
9712         * avr-tdep.c: Sort headers.
9713         * auxv.c: Sort headers.
9714         * auto-load.c: Sort headers.
9715         * arm-wince-tdep.c: Sort headers.
9716         * arm-tdep.c: Sort headers.
9717         * arm-symbian-tdep.c: Sort headers.
9718         * arm-pikeos-tdep.c: Sort headers.
9719         * arm-obsd-tdep.c: Sort headers.
9720         * arm-nbsd-tdep.c: Sort headers.
9721         * arm-nbsd-nat.c: Sort headers.
9722         * arm-linux-tdep.c: Sort headers.
9723         * arm-linux-nat.c: Sort headers.
9724         * arm-fbsd-tdep.c: Sort headers.
9725         * arm-fbsd-nat.c: Sort headers.
9726         * arm-bsd-tdep.c: Sort headers.
9727         * arch-utils.c: Sort headers.
9728         * arc-tdep.c: Sort headers.
9729         * arc-newlib-tdep.c: Sort headers.
9730         * annotate.h: Sort headers.
9731         * annotate.c: Sort headers.
9732         * amd64-windows-tdep.c: Sort headers.
9733         * amd64-windows-nat.c: Sort headers.
9734         * amd64-tdep.c: Sort headers.
9735         * amd64-sol2-tdep.c: Sort headers.
9736         * amd64-obsd-tdep.c: Sort headers.
9737         * amd64-obsd-nat.c: Sort headers.
9738         * amd64-nbsd-tdep.c: Sort headers.
9739         * amd64-nbsd-nat.c: Sort headers.
9740         * amd64-nat.c: Sort headers.
9741         * amd64-linux-tdep.c: Sort headers.
9742         * amd64-linux-nat.c: Sort headers.
9743         * amd64-fbsd-tdep.c: Sort headers.
9744         * amd64-fbsd-nat.c: Sort headers.
9745         * amd64-dicos-tdep.c: Sort headers.
9746         * amd64-darwin-tdep.c: Sort headers.
9747         * amd64-bsd-nat.c: Sort headers.
9748         * alpha-tdep.c: Sort headers.
9749         * alpha-obsd-tdep.c: Sort headers.
9750         * alpha-nbsd-tdep.c: Sort headers.
9751         * alpha-mdebug-tdep.c: Sort headers.
9752         * alpha-linux-tdep.c: Sort headers.
9753         * alpha-linux-nat.c: Sort headers.
9754         * alpha-bsd-tdep.c: Sort headers.
9755         * alpha-bsd-nat.c: Sort headers.
9756         * aix-thread.c: Sort headers.
9757         * agent.c: Sort headers.
9758         * addrmap.c: Sort headers.
9759         * ada-varobj.c: Sort headers.
9760         * ada-valprint.c: Sort headers.
9761         * ada-typeprint.c: Sort headers.
9762         * ada-tasks.c: Sort headers.
9763         * ada-lang.c: Sort headers.
9764         * aarch64-tdep.c: Sort headers.
9765         * aarch64-ravenscar-thread.c: Sort headers.
9766         * aarch64-newlib-tdep.c: Sort headers.
9767         * aarch64-linux-tdep.c: Sort headers.
9768         * aarch64-linux-nat.c: Sort headers.
9769         * aarch64-fbsd-tdep.c: Sort headers.
9770         * aarch64-fbsd-nat.c: Sort headers.
9771         * aarch32-linux-nat.c: Sort headers.
9772
9773 2019-04-04  Tom Tromey  <tom@tromey.com>
9774
9775         * varobj.c (varobj_create): Update.
9776         * rust-exp.y (struct rust_parser) <update_innermost_block,
9777         lookup_symbol>: New methods.
9778         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9779         Rename.
9780         (rust_parser::rust_lookup_type)
9781         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9782         * printcmd.c (display_command, do_one_display): Update.
9783         * parser-defs.h (struct parser_state) <parser_state>: Add
9784         "tracker" parameter.
9785         (block_tracker): New member.
9786         (class innermost_block_tracker) <innermost_block_tracker>: Add
9787         "types" parameter.
9788         <reset>: Remove method.
9789         (innermost_block): Don't declare.
9790         (null_post_parser): Update.
9791         * parse.c (innermost_block): Remove global.
9792         (write_dollar_variable): Update.
9793         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9794         Remove "tracker_types" parameter.
9795         (parse_expression): Add "tracker" parameter.
9796         (parse_expression_for_completion): Update.
9797         (null_post_parser): Add "tracker" parameter.
9798         * p-exp.y: Update rules.
9799         * m2-exp.y: Update rules.
9800         * language.h (struct language_defn) <la_post_parser>: Add
9801         "tracker" parameter.
9802         * go-exp.y: Update rules.
9803         * f-exp.y: Update rules.
9804         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9805         parameter.
9806         * d-exp.y: Update rules.
9807         * c-exp.y: Update rules.
9808         * breakpoint.c (set_breakpoint_condition): Create an
9809         innermost_block_tracker.
9810         (watch_command_1): Likewise.
9811         * ada-lang.c (resolve): Add "tracker" parameter.
9812         (resolve_subexp): Likewise.
9813         * ada-exp.y (write_var_from_sym): Update.
9814
9815 2019-04-04  Tom Tromey  <tom@tromey.com>
9816
9817         * type-stack.h: New file.
9818         * type-stack.c: New file.
9819         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9820         type-stack.h.
9821         (insert_into_type_stack, insert_type, push_type, push_type_int)
9822         (insert_type_address_space, pop_type, pop_type_int)
9823         (pop_typelist, pop_type_stack, append_type_stack)
9824         (push_type_stack, get_type_stack, push_typelist)
9825         (follow_type_instance_flags, follow_types): Don't declare.
9826         * parse.c (type_stack): Remove global.
9827         (parse_exp_in_context): Update.
9828         (insert_into_type_stack, insert_type, push_type, push_type_int)
9829         (insert_type_address_space, pop_type, pop_type_int)
9830         (pop_typelist, pop_type_stack, append_type_stack)
9831         (push_type_stack, get_type_stack, push_typelist)
9832         (follow_type_instance_flags, follow_types): Remove (moved to
9833         type-stack.c).
9834         * f-exp.y (type_stack): New global.
9835         Update rules.
9836         (push_kind_type, f_parse): Update.
9837         * d-exp.y (type_stack): New global.
9838         Update rules.
9839         (d_parse): Update.
9840         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9841         Update rules.
9842         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9843         (HFILES_NO_SRCDIR): Add type-stack.h.
9844
9845 2019-04-04  Tom Tromey  <tom@tromey.com>
9846
9847         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9848         (rust_parser::convert_ast_to_expression, rust_parse)
9849         (rust_lex_test_completion, rust_lex_tests): Update.
9850         * parser-defs.h (struct expr_completion_state): New.
9851         (struct parser_state) <parser_state>: Add completion parameter.
9852         <mark_struct_expression, mark_completion_tag>: New methods.
9853         <parse_completion, m_completion_state>: New members.
9854         (prefixify_expression, null_post_parser): Update.
9855         (mark_struct_expression, mark_completion_tag): Don't declare.
9856         * parse.c (parse_completion, expout_last_struct)
9857         (expout_tag_completion_type, expout_completion_name): Remove
9858         globals.
9859         (parser_state::mark_struct_expression)
9860         (parser_state::mark_completion_tag): Now methods.
9861         (prefixify_expression): Add last_struct parameter.
9862         (prefixify_subexp): Likewise.
9863         (parse_exp_1): Update.
9864         (parse_exp_in_context): Add cstate parameter.  Update.
9865         (parse_expression_for_completion): Create an
9866         expr_completion_state.
9867         (null_post_parser): Add "completion" parameter.
9868         * p-exp.y: Update rules.
9869         (yylex): Update.
9870         * language.h (struct language_defn) <la_post_parser>: Add
9871         "completing" parameter.
9872         * go-exp.y: Update rules.
9873         (lex_one_token): Update.
9874         * expression.h (parse_completion): Don't declare.
9875         * d-exp.y: Update rules.
9876         (lex_one_token): Update rules.
9877         * c-exp.y: Update rules.
9878         (lex_one_token): Update.
9879         * ada-lang.c (resolve): Add "parse_completion" parameter.
9880         (resolve_subexp): Likewise.
9881         (ada_resolve_function): Likewise.
9882
9883 2019-04-04  Tom Tromey  <tom@tromey.com>
9884
9885         * parser-defs.h (struct parser_state) <start_arglist,
9886         end_arglist>: New methods.
9887         <arglist_len, m_funcall_chain>: New members.
9888         (arglist_len, start_arglist, end_arglist): Don't declare.
9889         * parse.c (arglist_len, funcall_chain): Remove global.
9890         (start_arglist, end_arglist): Remove functions.
9891         (parse_exp_in_context): Update.
9892         * p-exp.y: Update rules.
9893         * m2-exp.y: Update rules.
9894         * go-exp.y: Update rules.
9895         * f-exp.y: Update rules.
9896         * d-exp.y: Update rules.
9897         * c-exp.y: Update rules.
9898
9899 2019-04-04  Tom Tromey  <tom@tromey.com>
9900
9901         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9902         lex_operator, push_back>: New methods.
9903         Update all rules.
9904         (rust_parser::lex_hex, lex_escape): Rename and update.
9905         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9906         (rust_parser::lex_operator): Rename and update.
9907         (rust_parser::lex_number, rustyylex, rustyyerror)
9908         (rust_lex_test_init, rust_lex_test_sequence)
9909         (rust_lex_test_push_back, rust_lex_tests): Update.
9910         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9911         parameter.
9912         <lexptr, prev_lexptr>: New members.
9913         (lexptr, prev_lexptr): Don't declare.
9914         * parse.c (lexptr, prev_lexptr): Remove globals.
9915         (parse_exp_in_context): Update.
9916         * p-exp.y (yylex, yyerror): Update.
9917         * m2-exp.y (parse_number, yylex, yyerror): Update.
9918         * go-exp.y (lex_one_token, yyerror): Update.
9919         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9920         * d-exp.y (lex_one_token, yyerror): Update.
9921         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9922         (lex_one_token, yyerror): Update.
9923         * ada-lex.l (YY_INPUT): Update.
9924         (rewind_to_char): Update.
9925         * ada-exp.y (yyerror): Update.
9926
9927 2019-04-04  Tom Tromey  <tom@tromey.com>
9928
9929         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9930         * parser-defs.h (struct parser_state) <parser_state>: Add new
9931         parameter.
9932         <comma_terminates>: New member.
9933         (comma_terminates): Don't declare global.
9934         * parse.c (comma_terminates): Remove global.
9935         (parse_exp_in_context): Update.
9936         * p-exp.y (yylex): Update.
9937         * m2-exp.y (yylex): Update.
9938         * go-exp.y (lex_one_token): Update.
9939         * f-exp.y (yylex): Update.
9940         * d-exp.y (lex_one_token): Update.
9941         * c-exp.y (lex_one_token): Update.
9942         * ada-lex.l: Update.
9943
9944 2019-04-04  Tom Tromey  <tom@tromey.com>
9945
9946         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9947         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9948         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9949         * parser-defs.h (paren_depth): Don't declare.
9950         * parse.c (paren_depth): Remove global.
9951         (parse_exp_in_context): Update.
9952         * p-exp.y (paren_depth): New global.
9953         (pascal_parse): Initialize it.
9954         * m2-exp.y (paren_depth): New global.
9955         (m2_parse): Initialize it.
9956         * go-exp.y (paren_depth): New global.
9957         (go_parse): Initialize it.
9958         * f-exp.y (paren_depth): New global.
9959         (f_parse): Initialize it.
9960         * d-exp.y (paren_depth): New global.
9961         (d_parse): Initialize it.
9962         * c-exp.y (paren_depth): New global.
9963         (c_parse): Initialize it.
9964         * ada-lex.l (paren_depth): New global.
9965         (lexer_init): Initialize it.
9966
9967 2019-04-04  Tom Tromey  <tom@tromey.com>
9968
9969         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9970         (rust_parser::convert_ast_to_type)
9971         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9972         * parser-defs.h (struct parser_state) <parser_state>: Add
9973         parameters.  Initialize new members.
9974         <expression_context_block, expression_context_pc>: New members.
9975         * parse.c (expression_context_block, expression_context_pc):
9976         Remove globals.
9977         (parse_exp_in_context): Update.
9978         * p-exp.y: Update all rules.
9979         (yylex): Update.
9980         * m2-exp.y: Update all rules.
9981         (yylex): Update.
9982         * go-exp.y (yylex): Update.
9983         * f-exp.y (yylex): Update.
9984         * d-exp.y: Update all rules.
9985         (yylex): Update.
9986         * c-exp.y: Update all rules.
9987         (lex_one_token, classify_name, yylex, c_parse): Update.
9988         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9989
9990 2019-04-04  Tom Tromey  <tom@tromey.com>
9991
9992         * gdbarch.h, gdbarch.c: Rebuild.
9993         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9994         * stap-probe.h:
9995         (struct stap_parse_info): Replace "parser_state" with
9996         "expr_builder".
9997         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9998         (parser_state): New class.
9999         * parse.c (expr_builder): Rename.
10000         (expr_builder::release): Rename.
10001         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10002         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10003         (write_exp_elt_longcst, write_exp_elt_floatcst)
10004         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10005         (write_exp_string_vector, write_exp_bitstring)
10006         (write_exp_msymbol, mark_struct_expression)
10007         (write_dollar_variable)
10008         (insert_type_address_space, increase_expout_size): Replace
10009         "parser_state" with "expr_builder".
10010         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10011         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10012         "parser_state" with "expr_builder".
10013
10014 2019-04-04  Tom Tromey  <tom@tromey.com>
10015
10016         * rust-exp.y: Replace "parse_language" with method call.
10017         * p-exp.y:
10018         (yylex): Replace "parse_language" with method call.
10019         * m2-exp.y:
10020         (yylex): Replace "parse_language" with method call.
10021         * go-exp.y (classify_name): Replace "parse_language" with method
10022         call.
10023         * f-exp.y (yylex): Replace "parse_language" with method call.
10024         * d-exp.y (lex_one_token): Replace "parse_language" with method
10025         call.
10026         * c-exp.y:
10027         (lex_one_token, classify_name, yylex): Replace "parse_language"
10028         with method call.
10029         * ada-exp.y (find_primitive_type, type_char)
10030         (type_system_address): Replace "parse_language" with method call.
10031
10032 2019-04-04  Tom Tromey  <tom@tromey.com>
10033
10034         * rust-exp.y: Replace "parse_gdbarch" with method call.
10035         * parse.c (write_dollar_variable, insert_type_address_space):
10036         Replace "parse_gdbarch" with method call.
10037         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10038         call.
10039         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10040         call.
10041         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10042         "parse_gdbarch" with method call.
10043         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10044         with method call.
10045         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10046         "parse_gdbarch" with method call.
10047         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10048         "parse_gdbarch" with method call.
10049         * c-exp.y (parse_type, parse_number, classify_name): Replace
10050         "parse_gdbarch" with method call.
10051         * ada-lex.l: Replace "parse_gdbarch" with method call.
10052         * ada-exp.y (parse_type, find_primitive_type, type_char)
10053         (type_system_address): Replace "parse_gdbarch" with method call.
10054
10055 2019-04-04  Tom Tromey  <tom@tromey.com>
10056
10057         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10058         * stap-probe.c (stap_parse_argument): Update.
10059         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10060         initial_size parameter.
10061         * rust-exp.y (rust_lex_tests): Update.
10062         * parse.c (parser_state): Update.
10063         (parse_exp_in_context): Update.
10064         * parser-defs.h (struct parser_state) <parser_state>: Remove
10065         "initial_size" parameter.
10066
10067 2019-04-04  Tom Tromey  <tom@tromey.com>
10068
10069         * parser-defs.h (increase_expout_size): Don't declare.
10070         * parse.c (increase_expout_size): Now static.
10071
10072 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10073
10074         * gnu-nat.c (gnu_nat_target::wait): Fix
10075         target_waitstatus_to_string call.
10076
10077 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10078
10079         * eval.c (evaluate_subexp_standard): Handle internal functions
10080         during Fortran function call handling.
10081
10082 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10083
10084         * NEWS: Mention new internal functions.
10085         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10086         (read_base_type): Use dwarf2_init_complex_target_type.
10087         * value.c (creal_internal_fn): New function.
10088         (cimag_internal_fn): New function.
10089         (_initialize_values): Register new internal functions.
10090
10091 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10092
10093         * infrun.c (stop_all_threads): If debug_infrun, always
10094         trace the wait status after wait_one, using
10095         target_waitstatus_to_string and target_pid_to_str.
10096         (handle_inferior_event): Replace various trace of
10097         wait status kind by a single trace.
10098         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10099         wait status kind image by target_waitstatus_to_string.
10100         * target/waitstatus.c (target_waitstatus_to_string): Fix
10101         obsolete comment.
10102
10103 2019-04-01  Tom Tromey  <tromey@adacore.com>
10104
10105         PR symtab/23331:
10106         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10107
10108 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10109             Pedro Alves  <palves@redhat.com>
10110
10111         * top.c (quit_force): Call 'finalize_values'.
10112         * value.c (finalize_values): New function.
10113         * value.h (finalize_values): Declare.
10114
10115 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10116
10117         * NEWS: Announce $_gdb_major and $_gdb_minor.
10118
10119         * top.c (init_gdb_version_vars): New function.
10120         (gdb_init): Call init_gdb_version_vars.
10121
10122 2019-03-29  Tom Tromey  <tromey@adacore.com>
10123
10124         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10125         help text.  Remove dead code.
10126
10127 2019-03-29  Keith Seitz  <keiths@redhat.com>
10128
10129         From Siddhesh Poyarekar:
10130         * f-lang.h (f77_get_upperbound): Return LONGEST.
10131         (f77_get_lowerbound): Likewise.
10132         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10133         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10134         print them.
10135         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10136         plongest to format print it.
10137         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10138         (f77_get_upperbound): Likewise.
10139         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10140         LOWER_BOUND to LONGEST.
10141         (f77_create_arrayprint_offset_tbl): Likewise.
10142
10143 2019-03-29  Keith Seitz  <keiths@redhat.com>
10144
10145         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10146         %s/pulongest for TYPE_LENGTH instead of %d in format
10147         strings.
10148         * ada-typerint.c (ada_print_type): Likewise.
10149         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10150         * compile/compile-c-support.c (generate_register_struct): Likewise.
10151         * gdbtypes.c (recursive_dump_type): Likewise.
10152         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10153         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10154         instead of %d in format strings.
10155         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10156         to std::min to ULONGEST.
10157         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10158         instead of %d in format strings.
10159         * tracepoint.c (info_scope_command): Likewise.
10160         * typeprint.c (print_offset_data::update)
10161         (print_offset_data::finish): Likewise.
10162         * xtensa-tdep.c (xtensa_store_return_value)
10163         (xtensa_push_dummy_call): Likewise.
10164
10165 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10166
10167         * windows-nat.c (display_selector): Fixed format specifications
10168         for 64-bit Cygwin.
10169
10170 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10171
10172         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10173
10174 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10175
10176         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10177         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10178         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10179         (nios2_linux_init_abi): Install it.
10180
10181 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10182
10183         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10184
10185 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10186
10187         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10188
10189 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10190             Tom Tromey  <tromey@adacore.com>
10191
10192         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10193
10194 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10195
10196         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10197         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10198         method to compute the bounds of range types. Also print "[evaluated]"
10199         if the bounds' values come from a dynamic evaluation.
10200
10201 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10202
10203         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10204         whitespace when pretty printing is on.
10205
10206 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10207
10208         * ppc-linux-nat.c: Add include.
10209
10210 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10211
10212         * NEWS: Mention AArch64 Pointer Authentication.
10213
10214 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10215
10216         * arm-linux-nat.c: Add include.
10217
10218 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10219
10220         * source-cache.c (source_cache::get_source_lines): Re-read
10221         fullname after calling open_source_file.
10222
10223 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10224
10225         * NEWS: Mention TLS support for FreeBSD.
10226
10227 2019-03-25  Tom Tromey  <tromey@adacore.com>
10228
10229         * minsyms.c (BUNCH_SIZE): Update comment.
10230         (~minimal_symbol_reader): Remove old comment.
10231         (compact_minimal_symbols): Update comment.
10232         (minimal_symbol_reader::install): Remove old comment.  Update
10233         other comments.
10234
10235 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10236
10237         * s390-linux-nat.c: Add include.
10238
10239 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10240
10241         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10242         Call linux_get_hwcap.
10243         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10244         Likewise.
10245         (aarch64_linux_get_hwcap): Remove function.
10246         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10247         declaration.
10248         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10249         linux_get_hwcap.
10250         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10251         * linux-tdep.c (linux_get_hwcap): Add function.
10252         (linux_get_hwcap2): Likewise.
10253         * linux-tdep.h (linux_get_hwcap): Add declaration.
10254         (linux_get_hwcap2): Likewise.
10255         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10256         (ppc_linux_get_hwcap2): Likewise.
10257         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10258         linux_get_hwcap.
10259         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10260         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10261         (ppc_linux_nat_target::read_description): Likewise.
10262         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10263         * s390-linux-nat.c: Likewise.
10264         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10265
10266 2019-03-24  Tom Tromey  <tom@tromey.com>
10267
10268         * ada-lang.c (standard_lookup): Simplify initialization.
10269         (ada_lookup_symbol_nonlocal): Simplify return.
10270         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10271         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10272         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10273         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10274         initialization.
10275         * solib.c (solib_global_lookup): Simplify.
10276         * symtab.c (null_block_symbol): Remove.
10277         (symbol_cache_lookup): Simplify returns.
10278         (lookup_language_this): Simplify returns.
10279         (lookup_symbol_aux): Simplify return.
10280         (lookup_local_symbol): Simplify returns.
10281         (lookup_global_symbol_from_objfile): Simplify return.
10282         (lookup_symbol_in_objfile_symtabs)
10283         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10284         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10285         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10286         * cp-namespace.c (cp_lookup_bare_symbol)
10287         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10288         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10289         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10290         (cp_lookup_symbol_via_imports): Simplify initialization.
10291         (find_symbol_in_baseclass): Likewise.
10292         * symtab.h (null_block_symbol): Remove.
10293         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10294         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10295         (d_lookup_symbol_module): Likewise.
10296         (find_symbol_in_baseclass): Simplify initialization.
10297
10298 2019-03-24  Tom Tromey  <tom@tromey.com>
10299
10300         * expression.h: Don't include symtab.h.
10301         (struct block): Forward declare.
10302
10303 2019-03-24  Tom Tromey  <tom@tromey.com>
10304
10305         * c-exp.y (typebase): Remove casts.
10306         * gdbtypes.c (lookup_unsigned_typename, )
10307         (lookup_signed_typename): Remove cast.
10308         * eval.c (parse_to_comma_and_eval): Remove cast.
10309         * parse.c (write_dollar_variable): Remove cast.
10310         * block.h (struct block) <superblock>: Now const.
10311         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10312         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10313         (map_block): Make "block" const.
10314         * symfile.h (struct quick_symbol_functions)
10315         <map_matching_symbols>: Constify block argument to "callback".
10316         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10317         const.
10318         (find_pc_sect_compunit_symtab): Make "b" const.
10319         (find_symbol_at_address): Likewise.
10320         (search_symbols): Likewise.
10321         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10322         (dw2_debug_names_lookup_symbol): Likewise.
10323         (dw2_map_matching_symbols): Update.
10324         * p-valprint.c (pascal_val_print): Remove "block".
10325         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10326         (aux_add_nonlocal_symbols): Make "block" const.
10327         (resolve_subexp): Remove cast.
10328         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10329         const.
10330         (iterate_over_file_blocks): Likewise.
10331         * f-exp.y (%union) <bval>: Remove.
10332         * coffread.c (patch_opaque_types): Make "b" const.
10333         * spu-tdep.c (spu_catch_start): Make "block" const.
10334         * c-valprint.c (print_unpacked_pointer): Remove "block".
10335         * symmisc.c (dump_symtab_1): Make "b" const.
10336         (block_depth): Make "block" const.
10337         * d-exp.y (%union) <bval>: Remove.
10338         * cp-support.h (cp_lookup_rtti_type): Update.
10339         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10340         * psymtab.c (psym_lookup_symbol): Make "block" const.
10341         (maintenance_check_psymtabs): Make "b" const.
10342         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10343         (enumerate_locals, enumerate_args): Update.
10344         * python/py-symtab.c (stpy_global_block): Make "block" const.
10345         (stpy_static_block): Likewise.
10346         * inline-frame.c (block_starting_point_at): Make "new_block"
10347         const.
10348         * block.c (find_block_in_blockvector): Make return type const.
10349         (blockvector_for_pc_sect): Make "b" const.
10350         (find_block_in_blockvector): Make "b" const.
10351
10352 2019-03-23  Tom Tromey  <tom@tromey.com>
10353
10354         * varobj.c (varobj_create): Update.
10355         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10356         * printcmd.c (display_command, do_one_display): Don't reset
10357         innermost_block.
10358         * parser-defs.h (enum innermost_block_tracker_type): Move to
10359         expression.h.
10360         (innermost_block): Update comment.
10361         * parse.c (parse_exp_1): Add tracker_types parameter.
10362         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10363         tracker_types parameter.  Reset innermost_block.
10364         (parse_exp_in_context): Remove.
10365         (parse_expression_for_completion): Update.
10366         * objfiles.c (~objfile): Don't reset expression_context_block or
10367         innermost_block.
10368         * expression.h (enum innermost_block_tracker_type): Move from
10369         parser-defs.h.
10370         (parse_exp_1): Add tracker_types parameter.
10371         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10372         reset innermost_block.
10373
10374 2019-03-23  Tom Tromey  <tom@tromey.com>
10375
10376         * objfiles.h: Include bcache.h.
10377
10378 2019-03-23  Tom Tromey  <tom@tromey.com>
10379
10380         * linespec.c (get_current_search_block): Use
10381         scoped_restore_current_language.
10382         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10383
10384 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10385             Jiong Wang  <jiong.wang@arm.com>
10386
10387         * aarch64-linux-tdep.c
10388         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10389         section.
10390         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10391
10392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10393             Jiong Wang  <jiong.wang@arm.com>
10394
10395         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10396         instructions.
10397         (aarch64_analyze_prologue_test): Add PACIASP test.
10398         (aarch64_prologue_prev_register): Unmask PC value.
10399
10400 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10401             Jiong Wang  <jiong.wang@arm.com>
10402
10403         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10404         (aarch64_dwarf2_prev_register): Unmask PC value.
10405         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10406         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10407         DW_CFA_AARCH64_negate_ra_state.
10408         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10409
10410 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10411             Jiong Wang  <jiong.wang@arm.com>
10412
10413         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10414         registers.
10415         (aarch64_pseudo_register_name): Likewise.
10416         (aarch64_pseudo_register_type): Likewise.
10417         (aarch64_pseudo_register_reggroup_p): Likewise.
10418         (aarch64_gdbarch_init): Add pauth registers.
10419         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10420         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10421         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10422         (struct gdbarch_tdep): Add regnum for ra_state.
10423
10424 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10425             Jiong Wang  <jiong.wang@arm.com>
10426
10427         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10428
10429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10430             Jiong Wang  <jiong.wang@arm.com>
10431
10432         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10433         function.
10434         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10435         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10436         (aarch64_gdbarch_init): Add puth registers.
10437         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10438         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10439         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10440
10441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10442             Jiong Wang  <jiong.wang@arm.com>
10443
10444         * aarch64-linux-nat.c
10445         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10446         * aarch64-linux-tdep.c
10447         (aarch64_linux_core_read_description): Likewise.
10448         (aarch64_linux_get_hwcap): New function.
10449         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10450         (aarch64_linux_get_hwcap): New declaration.
10451
10452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10453             Jiong Wang  <jiong.wang@arm.com>
10454
10455         * aarch64-linux-nat.c
10456         (aarch64_linux_nat_target::read_description): Add pauth param.
10457         * aarch64-linux-tdep.c
10458         (aarch64_linux_core_read_description): Likewise.
10459         * aarch64-tdep.c (struct target_desc): Add in pauth.
10460         (aarch64_read_description): Add pauth param.
10461         (aarch64_gdbarch_init): Likewise.
10462         * aarch64-tdep.h (aarch64_read_description): Likewise.
10463         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10464         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10465         * features/Makefile: Add new files.
10466         * features/aarch64-pauth.c: New file.
10467         * features/aarch64-pauth.xml: New file.
10468
10469 2019-03-20  Tom Tromey  <tromey@adacore.com>
10470
10471         * infrun.c (handle_inferior_event): Rename from
10472         handle_inferior_event_1.  Create a scoped_value_mark.
10473         (handle_inferior_event): Remove.
10474
10475 2019-03-19  Tom Tromey  <tromey@adacore.com>
10476
10477         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10478         * infrun.h (print_stop_event): Add "displays" parameter.
10479         * infrun.c (print_stop_event): Add "displays" parameter.
10480
10481 2019-03-19  Pedro Alves  <palves@redhat.com>
10482
10483         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10484         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10485         to -1.  Fix TABs vs spaces.
10486         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10487         * tui/tui-out.h (tui_ui_out) Add intro comments.
10488         <m_line, m_start_of_line>: In-class initialize, and add describing
10489         comment.
10490
10491 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10492
10493         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10494         variable names.
10495         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10496
10497 2019-03-18  Pedro Alves  <palves@redhat.com>
10498             Eli Zaretskii <eliz@gnu.org>
10499
10500         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10501         m_line and m_start_of_line.
10502
10503 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10504
10505         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10506         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10507         it returns a newline.  This fixes a regression in TU mode, whereby
10508         the next line is output on the same screen line as the user input.
10509
10510 2019-03-18  Tom Tromey  <tromey@adacore.com>
10511
10512         * minsyms.c (minimal_symbol_reader::install): Remove call to
10513         obstack_blank.
10514
10515 2019-03-18  Pedro Alves  <palves@redhat.com>
10516
10517         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10518         New globals.
10519         (apply_style): New, factored out from ...
10520         (apply_ansi_escape): ... this.  Handle reverse video mode.
10521         (tui_set_reverse_mode): New function.
10522         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10523         * tui/tui-winsource.c (tui_show_source_line): Use
10524         tui_set_reverse_mode instead of setting A_STANDOUT.
10525         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10526         New setter methods.
10527
10528 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10529
10530         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10531         Handle tabs.
10532
10533 2019-03-18  Tom Tromey  <tromey@adacore.com>
10534
10535         * ada-lang.c (empty_array): Add "high" parameter.
10536         (ada_evaluate_subexp): Update.
10537
10538 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10539
10540         * unittests/string_view-selftests.c: Define
10541         _initialize_string_view_selftests unconditionally.
10542
10543 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10544
10545         PR gdb/24350
10546         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10547
10548 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10549
10550         PR gdb/24351
10551         * windows-nat.c (display_selector): Fix format specifiers.
10552
10553 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10554
10555         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10556         tui_refill_source_window instead of tui_refresh_win, to update the
10557         current execution line.  This fixes redisplay of the current line
10558         when stepping through the code with "next" or "step".
10559
10560 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10561
10562         * source-cache.c (source_cache::get_source_lines): Call
10563         find_source_lines to initialize s->nlines.  This fixes vertical
10564         scrolling of TUI source window when the DOWN arrow is pressed.
10565
10566 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10567
10568         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10569         linux-thread-db.c (_initialize_thread_db): Likewise.
10570
10571 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10572
10573         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10574         wclrtoeol in tui_show_source_line".  This reverts changes made in
10575         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10576
10577 2019-03-15  Tom Tromey  <tom@tromey.com>
10578
10579         * symtab.h (struct minimal_symbol): Derive from
10580         general_symbol_info.
10581         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10582         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10583         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10584         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10585         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10586         (MSYMBOL_SEARCH_NAME): Update.
10587         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10588         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10589         * minsyms.c (minimal_symbol_reader::record_full): Update.
10590
10591 2019-03-15  Tom Tromey  <tom@tromey.com>
10592
10593         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10594
10595 2019-03-15  Tom Tromey  <tom@tromey.com>
10596
10597         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10598         unique_xmalloc_ptr.
10599         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10600         Update.
10601         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10602         (build_minimal_symbol_hash_tables)
10603         (minimal_symbol_reader::install): Update.
10604
10605 2019-03-15  Tom Tromey  <tom@tromey.com>
10606
10607         * symtab.c (create_demangled_names_hash): Update.
10608         (symbol_set_names): Update.
10609         * objfiles.h (struct objfile_per_bfd_storage)
10610         <demangled_names_hash>: Now an htab_up.
10611         * objfiles.c (objfile_per_bfd_storage): Simplify.
10612
10613 2019-03-15  Tom Tromey  <tom@tromey.com>
10614
10615         * objfiles.h (struct objfile_per_bfd_storage): Declare
10616         destructor.
10617         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10618         New.
10619         (get_objfile_bfd_data): Use new.  Don't initialize
10620         language_of_main.
10621         (free_objfile_per_bfd_storage): Remove.
10622         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10623
10624 2019-03-15  Tom Tromey  <tom@tromey.com>
10625
10626         * symfile.c (reread_symbols): Update.
10627         * objfiles.c (objfile::objfile): Update.
10628         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10629         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10630         comment.
10631         (minimal_symbol_reader::install): Update.
10632         (terminate_minimal_symbol_table): Remove.
10633         * jit.c (jit_object_close_impl): Update.
10634
10635 2019-03-15  Tom Tromey  <tom@tromey.com>
10636
10637         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10638         initializations.
10639
10640 2019-03-15  Tom Tromey  <tom@tromey.com>
10641
10642         * objfiles.h (struct objfile_per_bfd_storage)
10643         <demangled_hash_languages>: Now a bitset.
10644         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10645         (lookup_minimal_symbol): Update.
10646
10647 2019-03-15  Tom Tromey  <tom@tromey.com>
10648
10649         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10650         Don't return the symbol.
10651         * coffread.c (record_minimal_symbol): Use record_full.
10652
10653 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10654
10655         The MS-Windows port of ncurses fails to switch to a color pair if
10656         one or both of the colors are the implicit default colors.  This
10657         change records the default colors when TUI is initialized, and
10658         then specifies them explicitly when a color pair uses the default
10659         colors.  This allows color styling in TUI mode on MS-Windows.
10660
10661         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10662         ncurses_norm_attr.
10663         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10664         colors in ncurses_norm_attr.
10665         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10666         "none", replace it with the default color recorded in
10667         ncurses_norm_attr.
10668
10669 2019-03-14  Tom Tromey  <tromey@adacore.com>
10670
10671         * source-cache.h (class source_cache) <get_source_lines>: Return
10672         std::string.
10673         * source-cache.c (source_cache::extract_lines): Handle case where
10674         first_pos==npos.  Return std::string.
10675         (source_cache::get_source_lines): Update.
10676
10677 2019-03-14  Tom Tromey  <tromey@adacore.com>
10678
10679         * NEWS: Add item for "style sources" commands.
10680         * source-cache.c (source_cache::get_source_lines): Check
10681         source_styling.
10682         * cli/cli-style.c (source_styling): New global.
10683         (_initialize_cli_style): Add "style sources" commands.
10684         (show_style_sources): New function.
10685         * cli/cli-style.h (source_styling): Declare.
10686
10687 2019-03-14  Pedro Alves  <palves@redhat.com>
10688             Tom Tromey  <tromey@adacore.com>
10689
10690         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10691         * tui/tui-winsource.c (tui_refill_source_window): New function,
10692         from...
10693         (tui_horizontal_source_scroll): ... here.  Move some logic.
10694         * cli/cli-style.c (set_style_enabled): Notify new observable.
10695         * tui/tui-hooks.c (tui_redisplay_source): New function.
10696         (tui_attach_detach_observers): Attach or detach
10697         tui_redisplay_source.
10698         * observable.h (source_styling_changed): New observable.
10699         * observable.c: Define source_styling_changed observable.
10700
10701 2019-03-13  Tom Tromey  <tromey@adacore.com>
10702
10703         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10704         (i386_gnu_nat_target::store_registers): Update.
10705         * target-debug.h (target_debug_print_std_string): New macro.
10706         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10707         * windows-tdep.c (display_one_tib): Update.
10708         * tui/tui-stack.c (tui_make_status_line): Update.
10709         * top.c (print_inferior_quit_action): Update.
10710         * thread.c (thr_try_catch_cmd): Update.
10711         (add_thread_with_info): Update.
10712         (thread_target_id_str): Update.
10713         (thr_try_catch_cmd): Update.
10714         (thread_command): Update.
10715         (thread_find_command): Update.
10716         * record-btrace.c (record_btrace_target::info_record)
10717         (record_btrace_resume_thread, record_btrace_target::resume)
10718         (record_btrace_cancel_resume, record_btrace_step_thread)
10719         (record_btrace_target::wait, record_btrace_target::wait)
10720         (record_btrace_target::wait, record_btrace_target::stop): Update.
10721         * progspace.c (print_program_space): Update.
10722         * process-stratum-target.c
10723         (process_stratum_target::thread_address_space): Update.
10724         * linux-fork.c (linux_fork_mourn_inferior)
10725         (detach_checkpoint_command, info_checkpoints_command)
10726         (linux_fork_context): Update.
10727         (linux_fork_detach): Update.
10728         (class scoped_switch_fork_info): Update.
10729         (delete_checkpoint_command): Update.
10730         * infrun.c (follow_fork_inferior): Update.
10731         (follow_fork_inferior): Update.
10732         (proceed_after_vfork_done): Update.
10733         (handle_vfork_child_exec_or_exit): Update.
10734         (follow_exec): Update.
10735         (displaced_step_prepare_throw): Update.
10736         (displaced_step_restore): Update.
10737         (start_step_over): Update.
10738         (resume_1): Update.
10739         (clear_proceed_status_thread): Update.
10740         (proceed): Update.
10741         (print_target_wait_results): Update.
10742         (do_target_wait): Update.
10743         (context_switch): Update.
10744         (stop_all_threads): Update.
10745         (restart_threads): Update.
10746         (finish_step_over): Update.
10747         (handle_signal_stop): Update.
10748         (switch_back_to_stepped_thread): Update.
10749         (keep_going_pass_signal): Update.
10750         (print_exited_reason): Update.
10751         (normal_stop): Update.
10752         * inferior.c (inferior_pid_to_str): Change return type.
10753         (print_selected_inferior): Update.
10754         (add_inferior): Update.
10755         (detach_inferior): Update.
10756         * dummy-frame.c (fprint_dummy_frames): Update.
10757         * dcache.c (dcache_info_1): Update.
10758         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10759         (btrace_fetch, btrace_clear): Update.
10760         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10761         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10762         type.
10763         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10764         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10765         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10766         * gdbarch.c, gdbarch.h: Rebuild.
10767         * gdbarch.sh (core_pid_to_str): Change return type.
10768         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10769         return type.
10770         (windows_nat_target::pid_to_str): Change return type.
10771         (windows_delete_thread): Update.
10772         (windows_nat_target::attach): Update.
10773         (windows_nat_target::files_info): Update.
10774         * target-delegates.c: Rebuild.
10775         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10776         return type.
10777         (sol_thread_target::pid_to_str): Change return type.
10778         * remote.c (class remote_target) <pid_to_str>: Change return
10779         type.
10780         (remote_target::pid_to_str): Change return type.
10781         (extended_remote_target::attach, remote_target::remote_stop_ns)
10782         (remote_target::remote_notif_remove_queued_reply)
10783         (remote_target::push_stop_reply, remote_target::disable_btrace):
10784         Update.
10785         (extended_remote_target::attach): Update.
10786         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10787         type.
10788         (gdbsim_target::pid_to_str): Change return type.
10789         * ravenscar-thread.c (struct ravenscar_thread_target)
10790         <pid_to_str>: Change return type.
10791         (ravenscar_thread_target::pid_to_str): Change return type.
10792         * procfs.c (class procfs_target) <pid_to_str>: Change return
10793         type.
10794         (procfs_target::pid_to_str): Change return type.
10795         (procfs_target::attach): Update.
10796         (procfs_target::detach): Update.
10797         (procfs_target::fetch_registers): Update.
10798         (procfs_target::store_registers): Update.
10799         (procfs_target::wait): Update.
10800         (procfs_target::files_info): Update.
10801         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10802         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10803         return type.
10804         (nto_procfs_target::pid_to_str): Change return type.
10805         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10806         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10807         return type.
10808         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10809         (exit_lwp): Update.
10810         (attach_proc_task_lwp_callback, get_detach_signal)
10811         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10812         (linux_nat_target::resume, wait_lwp, stop_callback)
10813         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10814         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10815         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10816         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10817         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10818         type.
10819         (inf_ptrace_target::attach): Update.
10820         (inf_ptrace_target::files_info): Update.
10821         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10822         type.
10823         (go32_nat_target::pid_to_str): Change return type.
10824         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10825         (gnu_nat_target::wait): Update.
10826         (gnu_nat_target::wait): Update.
10827         (gnu_nat_target::resume): Update.
10828         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10829         (fbsd_nat_target::wait): Update.
10830         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10831         type.
10832         (darwin_nat_target::attach): Update.
10833         * corelow.c (class core_target) <pid_to_str>: Change return type.
10834         (core_target::pid_to_str): Change return type.
10835         * target.c (normal_pid_to_str): Change return type.
10836         (default_pid_to_str): Likewise.
10837         (target_pid_to_str): Change return type.
10838         (target_translate_tls_address): Update.
10839         (target_announce_detach): Update.
10840         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10841         return type.
10842         (bsd_uthread_target::pid_to_str): Change return type.
10843         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10844         type.
10845         (bsd_kvm_target::pid_to_str): Change return type.
10846         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10847         return type.
10848         (aix_thread_target::pid_to_str): Change return type.
10849         * target.h (struct target_ops) <pid_to_str>: Change return type.
10850         (target_pid_to_str, normal_pid_to_str): Likewise.
10851         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10852         type.
10853         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10854         type.
10855         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10856         return type.
10857         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10858         type.
10859         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10860         type.
10861         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10862         return type.
10863
10864 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10865
10866         * NEWS: Mention that the new default MI version is 3.  Mention
10867         changes to the output of commands and events that deal with
10868         multi-location breakpoints.
10869         * breakpoint.c: Include "mi/mi-out.h".
10870         (print_one_breakpoint): Change output syntax if using MI version
10871         >= 3.
10872         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10873         New.
10874         (mi_multi_location_breakpoint_output_fixed): New.
10875         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10876         (mi_cmd_fix_multi_location_breakpoint_output): New.
10877         (mi_multi_location_breakpoint_output_fixed): New.
10878         * mi/mi-cmds.c (mi_cmds): Register command
10879         -fix-multi-location-breakpoint-output.
10880         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10881         interpreter "mi".
10882
10883 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10884
10885         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10886         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10887         instantiate mi_ui_out based on interpreter name.
10888         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10889         * mi/mi-main.c (mi_load_progress): Likewise.
10890
10891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10892
10893         * NEWS: Combine separate "New targets" sections for 8.3.
10894
10895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10896
10897         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10898         (ppcfbsd_init_abi): Install gdbarch
10899         "fetch_tls_load_module_address" and "get_thread_local_address"
10900         methods.
10901
10902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10903
10904         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10905         (riscv_fbsd_init_abi): Install gdbarch
10906         "fetch_tls_load_module_address" and "get_thread_local_address"
10907         methods.
10908
10909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10910
10911         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10912         (i386fbsd_init_abi): Install gdbarch
10913         "fetch_tls_load_module_address" and "get_thread_local_address"
10914         methods.
10915
10916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10917
10918         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10919         (amd64fbsd_init_abi): Install gdbarch
10920         "fetch_tls_load_module_address" and "get_thread_local_address"
10921         methods.
10922
10923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10924
10925         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10926         (struct fbsd_pspace_data): New type.
10927         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10928         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10929         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10930         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10931         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10932
10933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10934
10935         * gdbtypes.c (lookup_struct_elt): New function.
10936         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10937         * gdbtypes.h (struct struct_elt): New type.
10938         (lookup_struct_elt): New prototype.
10939
10940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10941
10942         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10943         remove disabled code block.
10944
10945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10946
10947         * gdbarch.sh (get_thread_local_address): New method.
10948         * gdbarch.h, gdbarch.c: Regenerate.
10949         * target.c (target_translate_tls_address): Use
10950         gdbarch_get_thread_local_address if present instead of
10951         target::get_thread_local_address.
10952
10953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10954
10955         * target.h (target::get_thread_local_address): Update comment.
10956
10957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10958
10959         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10960         objfile->separate_debug_objfile_backlink if not NULL.
10961
10962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10963
10964         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10965         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10966         (amd64bsd_store_inferior_registers): Likewise.
10967         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10968         Enable segment base registers.
10969         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10970         PT_GETFSBASE and PT_GETGSBASE.
10971         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10972         PT_SETGSBASE.
10973         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10974         segment base registers.
10975         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10976
10977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10978
10979         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10980         Update calls to i386_target_description to add 'segments'
10981         parameter.
10982         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10983         add segment base registers.
10984         * arch/i386.c (i386_create_target_description): Add 'segments'
10985         parameter to enable segment base registers.
10986         * arch/i386.h (i386_create_target_description): Likewise.
10987         * features/i386/32bit-segments.xml: New file.
10988         * features/i386/32bit-segments.c: Generate.
10989         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10990         call to i386_target_description to add 'segments' parameter.
10991         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10992         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10993         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10994         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10995         if feature is present.
10996         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10997         Add 'segments' parameter to call to i386_target_description.
10998         (i386_target_description): Add 'segments' parameter to enable
10999         segment base registers.
11000         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11001         to call to i386_target_description.
11002         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11003         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11004         Define I386_NUM_REGS.
11005         (i386_target_description): Add 'segments' parameter to enable
11006         segment base registers.
11007
11008 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11009
11010         PR/24325
11011         * source-cache.c: #undef open and close, to avoid unresolved
11012         externals during linking.
11013
11014 2019-03-12  Tom Tromey  <tromey@adacore.com>
11015
11016         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11017         const.  Add initializers.
11018         (_initialize_remote): Don't initialize ptid globals.
11019
11020 2019-03-12  Pedro Alves  <palves@redhat.com>
11021
11022         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11023
11024 2019-03-12  Pedro Alves  <palves@redhat.com>
11025
11026         * cp-name-parser.y (main): Remove unused 'len' variable.
11027
11028 2019-03-12  Tom Tromey  <tromey@adacore.com>
11029
11030         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11031         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11032
11033 2019-03-12  Tom Tromey  <tromey@adacore.com>
11034
11035         * linux-nat.c (iterate_over_lwps): Update.
11036         (stop_callback): Remove parameter.
11037         (stop_wait_callback, detach_callback, resume_set_callback)
11038         (select_singlestep_lwp_callback, set_ignore_sigint)
11039         (status_callback, resumed_callback, resume_clear_callback)
11040         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11041         data parameter.
11042         (linux_nat_target::detach, linux_nat_target::resume)
11043         (linux_stop_and_wait_all_lwps, select_event_lwp)
11044         (linux_nat_filter_event, linux_nat_wait_1)
11045         (linux_nat_target::kill, linux_nat_target::stop)
11046         (linux_nat_target::stop): Update.
11047         (linux_nat_resume_callback): Change type.
11048         (resume_stopped_resumed_lwps, count_events_callback)
11049         (select_event_lwp_callback): Likewise.
11050         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11051         * arm-linux-nat.c (struct update_registers_data): Remove.
11052         (update_registers_callback): Change type.
11053         (arm_linux_insert_hw_breakpoint1): Update.
11054         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11055         parameter.
11056         (x86_linux_dr_set_addr): Update.
11057         (x86_linux_dr_set_control): Update.
11058         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11059         (iterate_over_lwps): Use gdb::function_view.
11060         * nat/aarch64-linux-hw-point.c (struct
11061         aarch64_dr_update_callback_param): Remove.
11062         (debug_reg_change_callback): Change type.
11063         (aarch64_notify_debug_reg_change): Update.
11064         * s390-linux-nat.c (s390_refresh_per_info): Update.
11065
11066 2019-03-11  Tom Tromey  <tromey@adacore.com>
11067
11068         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11069         redundant assignment to "this_cu".
11070
11071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11072
11073         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11074
11075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11076
11077         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11078         from...
11079         (rank_one_type): ... this.
11080
11081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11082
11083         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11084         from...
11085         (rank_one_type): ... this.
11086
11087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11088
11089         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11090         from...
11091         (rank_one_type): ... this.
11092
11093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11094
11095         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11096         from...
11097         (rank_one_type): ... this.
11098
11099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11100
11101         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11102         from...
11103         (rank_one_type): ... this.
11104
11105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11106
11107         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11108         from...
11109         (rank_one_type): ... this.
11110
11111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11112
11113         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11114         from...
11115         (rank_one_type): ... this.
11116
11117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11118
11119         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11120         from...
11121         (rank_one_type): ... this.
11122
11123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11124
11125         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11126         from...
11127         (rank_one_type): ... this.
11128
11129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11130
11131         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11132         from...
11133         (rank_one_type): ... this.
11134
11135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11136
11137         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11138         from...
11139         (rank_one_type): ... this.
11140
11141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11142
11143         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11144         from...
11145         (rank_one_type): ... this.
11146
11147 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11148
11149         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11150         inferior-events' shows the example events.
11151
11152 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11153
11154         Support styling on native MS-Windows console
11155
11156         PR/24315
11157         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11158         on MS-Windows if $TERM is not defined.
11159
11160         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11161
11162         * posix-hdep.c (gdb_console_fputs):
11163         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11164         functions.
11165         * ui-file.h (gdb_console_fputs): Add prototype.
11166
11167         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11168         back to fputs only if the former returns zero.
11169
11170 2019-03-07  Tom Tromey  <tom@tromey.com>
11171
11172         * symmisc.c (print_symbol_bcache_statistics): Update.
11173         (print_objfile_statistics): Update.
11174         * symfile.c (allocate_symtab): Update.
11175         * stabsread.c: Don't include bcache.h.
11176         * psymtab.h (struct psymbol_bcache): Don't declare.
11177         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11178         (psymbol_bcache_init, psymbol_bcache_free)
11179         (psymbol_bcache_get_bcache): Don't declare.
11180         * psymtab.c (struct psymbol_bcache): Remove.
11181         (psymtab_storage::psymtab_storage): Update.
11182         (psymtab_storage::~psymtab_storage): Update.
11183         (psymbol_bcache_init, psymbol_bcache_free)
11184         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11185         (add_psymbol_to_bcache): Update.
11186         (allocate_psymtab): Update.
11187         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11188         macro_cache>: No longer pointers.
11189         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11190         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11191         * macrotab.c (macro_bcache): Update.
11192         * macroexp.c: Don't include bcache.h.
11193         * gdbtypes.c (check_types_worklist): Update.
11194         (types_deeply_equal): Remove TRY/CATCH.  Update.
11195         * elfread.c (elf_symtab_read): Update.
11196         * dwarf2read.c: Don't include bcache.h.
11197         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11198         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11199         (print_bcache_statistics, bcache_memory_used): Don't declare.
11200         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11201         methods.  Rename all data members.
11202         * bcache.c (struct bcache): Move to bcache.h.
11203         (bcache::expand_hash_table): Rename from expand_hash_table.
11204         (bcache): Remove.
11205         (bcache::insert): Rename from bcache_full.
11206         (bcache::compare): Rename from bcache_compare.
11207         (bcache_xmalloc): Remove.
11208         (bcache::~bcache): Rename from bcache_xfree.
11209         (bcache::print_statistics): Rename from print_bcache_statistics.
11210         (bcache::memory_used): Rename from bcache_memory_used.
11211
11212 2019-03-07  Pedro Alves  <palves@redhat.com>
11213
11214         * infrun.c (normal_stop): Also check for
11215         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11216
11217 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11218
11219         * f-lang.c (value_from_host_double): Moved to...
11220         * value.c (value_from_host_double): ...here.
11221         * value.h (value_from_host_double): Declare.
11222         * guile/scm-math.c (vlscm_convert_typed_number): Use
11223         value_from_host_double.
11224         (vlscm_convert_number): Likewise.
11225         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11226         * python/py-value.c (convert_value_from_python): Likewise.
11227
11228 2019-03-06  Tom Tromey  <tom@tromey.com>
11229
11230         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11231
11232 2019-03-06  Tom Tromey  <tom@tromey.com>
11233
11234         * utils.h (free_current_contents): Don't declare.
11235         * utils.c (free_current_contents): Remove.
11236
11237 2019-03-06  Tom Tromey  <tom@tromey.com>
11238
11239         * top.c (quit_force): Update.
11240         * main.c (captured_command_loop): Update.
11241         * common/new-op.c (operator new): Update.
11242         * common/common-exceptions.c (struct catcher)
11243         <save_cleanup_chain>: Remove member.
11244         (exceptions_state_mc_init): Update.
11245         (exception_try_scope_entry): Return nullptr.
11246         (exception_try_scope_exit, exception_rethrow)
11247         (throw_exception_sjlj, throw_exception_cxx): Update.
11248         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11249         (all_cleanups, do_cleanups, discard_cleanups)
11250         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11251         (restore_cleanups, restore_final_cleanups): Don't declare.
11252         (do_final_cleanups): Remove parameter.
11253         * common/cleanups.c (cleanup_chain, make_cleanup)
11254         (make_cleanup_dtor, all_cleanups, do_cleanups)
11255         (discard_my_cleanups, discard_cleanups)
11256         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11257         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11258         (null_cleanup): Remove.
11259         (do_final_cleanups): Remove parameter.
11260
11261 2019-03-06  Tom Tromey  <tom@tromey.com>
11262
11263         * remote.c (remote_target::remote_parse_stop_reply): Use
11264         unique_xmalloc_ptr.
11265
11266 2019-03-06  Tom Tromey  <tom@tromey.com>
11267
11268         * stabsread.c (struct stabs_field_info): Rename from field_info.
11269         <list, fnlist>: Add initializers.
11270         <obstack>: New member.
11271         (read_member_functions, read_struct_fields, read_baseclasses):
11272         Allocate on obstack.  Don't use cleanups.
11273         (read_one_struct_field, read_member_functions, read_struct_fields)
11274         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11275         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11276         (read_struct_type): Update.
11277
11278 2019-03-06  Tom Tromey  <tom@tromey.com>
11279
11280         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11281         * common/filestuff.h (make_cleanup_close): Don't declare.
11282         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11283         Remove.
11284
11285 2019-03-06  Tom Tromey  <tom@tromey.com>
11286
11287         * solib-aix.c: Use make_scope_exit.
11288
11289 2019-03-06  Tom Tromey  <tom@tromey.com>
11290
11291         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11292         Use make_scope_exit.
11293
11294 2019-03-06  Tom Tromey  <tom@tromey.com>
11295
11296         * solib-svr4.c (disable_probes_interface): Remove parameter.
11297         (svr4_handle_solib_event): Use make_scope_exit.
11298
11299 2019-03-06  Tom Tromey  <tom@tromey.com>
11300
11301         * remote.c (struct stop_reply_deleter): Remove.
11302         (stop_reply_up): Update.
11303         (struct stop_reply): Derive from notif_event.  Don't typedef.
11304         <regcache>: Now a std::vector.
11305         (stop_reply_xfree): Remove.
11306         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11307         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11308         (remote_target::discard_pending_stop_replies): Use delete.
11309         (remote_target::remote_parse_stop_reply): Update.
11310         (remote_target::process_stop_reply): Update.
11311         * remote-notif.h (struct notif_event): Add virtual destructor.
11312         Remove "dtr" member.
11313         (struct notif_client) <alloc_event>: Return a unique_ptr.
11314         (notif_event_xfree): Don't declare.
11315         (notif_event_up): New typedef.
11316         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11317         (notif_event_xfree, do_notif_event_xfree): Remove.
11318         (remote_notif_state_xfree): Update.
11319
11320 2019-03-06  Tom Tromey  <tom@tromey.com>
11321
11322         * infrun.c (displaced_step_clear_cleanup): Now a
11323         forward_scope_exit type.
11324         (displaced_step_prepare_throw): Update.
11325         (displaced_step_fixup): Update.
11326
11327 2019-03-06  Tom Tromey  <tom@tromey.com>
11328
11329         * inferior.h (class inferior): Update comment.
11330         * gdbthread.h (class thread_info): Update comment.
11331
11332 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11333             Tom Tromey  <tom@tromey.com>
11334
11335         * stabsread.h (struct stab_section_list): Remove.
11336         (coffstab_build_psymtabs): Update.
11337         * dbxread.c (symbuf_sections): Now a std::vector.
11338         (sect_idx): New global.
11339         (fill_symbuf): Update.
11340         (coffstab_build_psymtabs): Change type of stabsects parameter.
11341         Update.
11342         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11343         std::vector.
11344         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11345         (coff_locate_sections): Update.
11346         (coff_symfile_read): Remove cleanups.  Update.
11347         (init_stringtab): Add storage parameter.
11348         (free_stringtab, free_stringtab_cleanup): Remove.
11349         (init_lineno): Add storage parameter.
11350         (free_linetab, free_linetab_cleanup): Remove.
11351
11352 2019-03-06  Pedro Alves  <palves@redhat.com>
11353
11354         * linux-fork.c (fork_info::clobber_regs): Delete.
11355         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11356         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11357         comment.  Adjust.
11358         (scoped_switch_fork_info::scoped_switch_fork_info)
11359         (checkpoint_command, linux_fork_context): Adjust
11360         fork_save_infrun_state calls.
11361
11362 2019-03-06  Pedro Alves  <palves@redhat.com>
11363
11364         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11365         (inf_has_multiple_threads): Return 'bool' and rewrite using
11366         inferior_info::threads().
11367
11368 2019-03-06  Pedro Alves  <palves@redhat.com>
11369
11370         * linux-fork.c: Include <list>.
11371         (fork_list): Now a std::list instance.
11372         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11373         (forks_exist_p, find_last_fork): Adjust.
11374         (new_fork): Delete.
11375         (one_fork_p): New.
11376         (add_fork): Adjust.
11377         (free_fork): Delete, folded into fork_info::~fork_info().
11378         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11379         Adjust.
11380         (init_fork_list): Delete.
11381         (linux_fork_killall, linux_fork_mourn_inferior)
11382         (linux_fork_detach, info_checkpoints_command): Adjust.
11383         (_initialize_linux_fork): No longer call init_fork_list.
11384
11385 2019-03-06  Pedro Alves  <palves@redhat.com>
11386
11387         * linux-fork.c (new_fork): New, split out of ...
11388         (add_fork): ... this.  Return void.  Move "first fork" special
11389         case from here, to ...
11390         (checkpoint_command): ... here.
11391         * linux-linux.h (add_fork): Return void.
11392
11393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11394
11395         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11396
11397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11398             Chris January  <chris.january@arm.com>
11399             David Lecomber  <david.lecomber@arm.com>
11400
11401         * f-exp.y: New token, UNOP_INTRINSIC.
11402         (exp): New pattern using UNOP_INTRINSIC token.
11403         (f77_keywords): Add 'abs' keyword.
11404         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11405         (value_from_host_double): New function.
11406         (evaluate_subexp_f): Support UNOP_ABS.
11407
11408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11409
11410         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11411         types.
11412
11413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11416         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11417         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11418
11419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11420
11421         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11422
11423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11424             Chris January  <chris.january@arm.com>
11425
11426         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11427         * f-exp.y: Define 'KIND' token.
11428         (exp): New pattern for KIND expressions.
11429         (ptype): Handle types with a kind extension.
11430         (direct_abs_decl): Extend to spot kind extensions.
11431         (f77_keywords): Add 'kind' to the list.
11432         (push_kind_type): New function.
11433         (convert_to_kind_type): New function.
11434         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11435         * parse.c (operator_length_standard): Likewise.
11436         * parser-defs.h (enum type_pieces): Add tp_kind.
11437         * std-operator.def: Add UNOP_KIND.
11438
11439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11440
11441         * f-exp.y (f_parse): Set yydebug.
11442
11443 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11444
11445         * f-lang.c (evaluate_subexp_f): New function.
11446         (exp_descriptor_f): New global.
11447         (f_language_defn): Use exp_descriptor_f instead of
11448         exp_descriptor_standard.
11449
11450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11451
11452         * f-exp.y (struct token): Add comments.
11453         (dot_ops): Remove uppercase versions and the end marker.
11454         (f77_keywords): Likewise.
11455         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11456         entries in the dot_ops array are case insensitive, and use
11457         strncasecmp to compare strings.  Also some whitespace cleanup in
11458         this area.  Similar for the f77_keywords array, except entries in
11459         this list might be case sensitive.
11460
11461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11462
11463         * f-exp.y (struct f77_boolean_val): Add comments.
11464         (boolean_values): Remove uppercase versions, and end marker.
11465         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11466         and use strncasecmp to achieve case insensitivity.  Additionally,
11467         perform whitespace cleanup around this code.
11468
11469 2019-03-06  Tom Tromey  <tromey@adacore.com>
11470
11471         * remote-sim.c (gdbsim_target_open): Use result of
11472         gdb_argv::release.
11473
11474 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11475         Dirk Schubert  <dirk.schubert@arm.com>
11476         Chris January  <chris.january@arm.com>
11477
11478         * eval.c (evaluate_subexp_standard): Call Fortran argument
11479         wrapping logic.
11480         * f-lang.c (struct value): A value which can be passed into a
11481         Fortran function call.
11482         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11483         where appropriate.
11484         (struct type): Value ready for a Fortran function call.
11485         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11486         is needed.
11487         * f-lang.h (fortran_argument_convert): Declaration.
11488         (fortran_preserve_arg_pointer): Declaration.
11489         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11490
11491 2019-03-05  Tom Tromey  <tromey@adacore.com>
11492
11493         * python/py-prettyprint.c (print_string_repr): Remove #if.
11494         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11495
11496 2019-03-05  Tom Tromey  <tromey@adacore.com>
11497
11498         * target.c (the_dummy_target): Move later.  Change type to
11499         "dummy_target".
11500         (initialize_targets): Don't initialize the_dummy_target.
11501
11502 2019-03-05  Tom Tromey  <tromey@adacore.com>
11503
11504         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11505         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11506
11507 2019-03-05  Tom Tromey  <tromey@adacore.com>
11508
11509         * windows-nat.c (windows_nat_target::attach)
11510         (windows_nat_target::detach): Don't call gdb_flush.
11511         * valprint.c (generic_val_print, val_print, val_print_string):
11512         Don't call gdb_flush.
11513         * utils.c (defaulted_query): Don't call gdb_flush.
11514         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11515         * target.c (target_announce_detach): Don't call gdb_flush.
11516         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11517         * remote.c (extended_remote_target::attach): Don't call
11518         gdb_flush.
11519         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11520         * printcmd.c (do_examine): Don't call gdb_flush.
11521         (info_display_command): Don't call gdb_flush.
11522         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11523         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11524         * memattr.c (info_mem_command): Don't call gdb_flush.
11525         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11526         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11527         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11528         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11529         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11530         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11531         (gnu_nat_target::detach): Don't call gdb_flush.
11532         * f-valprint.c (f_val_print): Don't call gdb_flush.
11533         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11534         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11535         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11536         gdb_flush.
11537         * c-valprint.c (c_val_print): Don't call gdb_flush.
11538         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11539
11540 2019-03-05  Tom Tromey  <tromey@adacore.com>
11541
11542         * varobj.c (update_dynamic_varobj_children): Update.
11543         (install_default_visualizer): Use reset, not release.
11544         * value.c (set_internalvar): Update.
11545         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11546         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11547         ATTRIBUTE_UNUSED_RESULT.
11548
11549 2019-03-05  Tom Tromey  <tromey@adacore.com>
11550
11551         * remote.c (class scoped_remote_fd) <release>: Add
11552         ATTRIBUTE_UNUSED_RESULT.
11553
11554 2019-03-05  Tom Tromey  <tromey@adacore.com>
11555
11556         * macroexp.c (struct macro_buffer) <release>: Add
11557         ATTRIBUTE_UNUSED_RESULT.
11558
11559 2019-03-05  Tom Tromey  <tromey@adacore.com>
11560
11561         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11562         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11563         ATTRIBUTE_UNUSED_RESULT.
11564
11565 2019-03-05  Tom Tromey  <tromey@adacore.com>
11566
11567         * common/scoped_fd.h (class scoped_fd) <release>: Add
11568         ATTRIBUTE_UNUSED_RESULT.
11569
11570 2019-03-05  Tom Tromey  <tromey@adacore.com>
11571
11572         * parser-defs.h (struct parser_state) <release>: Add
11573         ATTRIBUTE_UNUSED_RESULT.
11574
11575 2019-03-05  Tom Tromey  <tromey@adacore.com>
11576
11577         * utils.h (class gdb_argv) <release>: Add
11578         ATTRIBUTE_UNUSED_RESULT.
11579         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11580
11581 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11582
11583         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11584         for-loop range, to avoid compiler warnings.
11585
11586         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11587         avoid compiler warnings about unused variables.
11588
11589         * NEWS: Mention end of support for native debugging on MS-Windows
11590         before XP.
11591
11592         PR gdb/24292
11593         * common/netstuff.c:
11594         * gdbserver/gdbreplay.c
11595         * gdbserver/remote-utils.c:
11596         * ser-tcp.c:
11597         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11598         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11599         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11600         'getaddrinfo' and 'freeaddrinfo' were not available before
11601         Windows XP, and mingw.org's MinGW headers by default define
11602         _WIN32_WINNT to 0x500.
11603
11604 2019-03-01  Gary Benson <gbenson@redhat.com>
11605
11606         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11607
11608 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11609             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11610
11611         PR gdb/8527
11612         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11613         set_sigint_trap, clear_sigint_trap.
11614
11615 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11616
11617         * target.c (target_detach): Clear the regcache and the
11618         frame cache.
11619
11620 2019-02-27  Pedro Alves  <palves@redhat.com>
11621
11622         * utils.c (set_screen_size): When we cap the height/width sizes,
11623         tweak the corresponding command variable to show "unlimited":
11624
11625 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11626             Pedro Alves  <palves@redhat.com>
11627
11628         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11629         before calling rl_set_screen_size.
11630
11631 2019-02-27  Tom Tromey  <tromey@adacore.com>
11632
11633         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11634         define.
11635         * python/py-value.c: Remove Python 2.4 workaround.
11636         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11637         workaround.
11638         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11639         Python 2.4 workaround.
11640         * python/python-internal.h: Remove Python 2.4 comment.
11641         (Py_ssize_t): Don't define.
11642         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11643         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11644         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11645         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11646         * python/python.c (do_start_initialization): Remove Python 2.4
11647         workaround.
11648         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11649         (print_children): Remove Python 2.4 workaround.
11650         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11651         workaround.
11652         (CHARBUFFERPROC_NAME): Remove.
11653         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11654         Python 2.4 workaround.
11655
11656 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11657
11658         * NEWS: Note minimum Python version.
11659
11660 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11661
11662         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11663         code from these functions.  Remove corresponding ifdefs.  Use
11664         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11665         Remove gotos and target of gotos.
11666         (infpy_search_memory): Likewise.
11667
11668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11669
11670         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11671         (hppa_gdbarch_init): Don't register deleted functions with
11672         gdbarch.
11673
11674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11675
11676         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11677         (h8300_unwind_sp): Delete.
11678         (h8300_dummy_id): Delete.
11679         (h8300_gdbarch_init): Don't register deleted functions with
11680         gdbarch.
11681
11682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11683
11684         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11685         (ft32_unwind_pc): Delete.
11686         (ft32_unwind_sp): Delete.
11687         (ft32_gdbarch_init): Don't register deleted functions with
11688         gdbarch.
11689
11690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11691
11692         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11693         (frv_unwind_pc): Delete.
11694         (frv_unwind_sp): Delete.
11695         (frv_gdbarch_init): Don't register deleted functions with
11696         gdbarch.
11697
11698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11699
11700         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11701         (riscv_unwind_pc): Delete.
11702         (riscv_unwind_sp): Delete.
11703         (riscv_gdbarch_init): Don't register deleted functions with
11704         gdbarch.
11705
11706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11707
11708         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11709         (csky_unwind_pc): Delete.
11710         (csky_unwind_sp): Delete.
11711         (csky_gdbarch_init): Don't register deleted functions with
11712         gdbarch.
11713
11714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11715
11716         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11717         (cris_unwind_pc): Delete.
11718         (cris_unwind_sp): Delete.
11719         (cris_gdbarch_init): Don't register deleted functions with
11720         gdbarch.
11721
11722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11723
11724         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11725         (bfin_unwind_pc): Delete.
11726         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11727
11728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11729
11730         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11731         (arm_unwind_pc): Delete.
11732         (arm_unwind_sp): Delete.
11733         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11734
11735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11736
11737         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11738         (arc_unwind_pc): Delete.
11739         (arc_unwind_sp): Delete.
11740         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11741
11742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11743
11744         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11745         (alpha_unwind_pc): Delete.
11746         (alpha_gdbarch_init): Don't register deleted functions with
11747         gdbarch.
11748
11749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11750
11751         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11752         (aarch64_unwind_pc): Delete.
11753         (aarch64_unwind_sp): Delete.
11754         (aarch64_gdbarch_init): Don't register deleted functions with
11755         gdbarch.
11756
11757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11758
11759         * gdbtypes.c (type_align): Don't consider static members when
11760         computing structure alignment.
11761
11762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11763
11764         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11765         return 0 for other types.
11766         * arch-utils.c (default_type_align): Always return 0.
11767         * gdbarch.h: Regenerate.
11768         * gdbarch.sh (type_align): Extend comment.
11769         * gdbtypes.c (type_align): Add additional comments, always call
11770         gdbarch_type_align before applying the default rules.
11771         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11772         generic code will then apply a suitable default.
11773         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11774         types, return 0 for other types.
11775
11776 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11777
11778         * NEWS: Create a new section for the next release branch.
11779         Rename the section of the current branch, now that it has
11780         been cut.
11781
11782 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11783
11784         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11785         * version.in: Bump version to 8.3.50.DATE-git.
11786
11787 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11788
11789         * aix-thread.c (ptid_cmp): Remove unused variable.
11790         (get_signaled_thread): Likewise.
11791         (store_regs_user_thread): Likewise.
11792         (store_regs_kernel_thread): Likewise.
11793         (fetch_regs_kernel_thread): Remove shadowed variable.
11794
11795 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11796
11797         * features/riscv/32bit-cpu.xml: Add register numbers.
11798         * features/riscv/32bit-fpu.c: Regenerate.
11799         * features/riscv/32bit-fpu.xml: Add register numbers.
11800         * features/riscv/64bit-cpu.xml: Add register numbers.
11801         * features/riscv/64bit-fpu.c: Regenerate.
11802         * features/riscv/64bit-fpu.xml: Add register numbers.
11803
11804 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11805
11806         * NEWS: Mention two argument form of gdb.Value constructor.
11807         * python/py-value.c (convert_buffer_and_type_to_value): New
11808         function.
11809         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11810         Add support for handling an optional second argument.  Call
11811         convert_buffer_and_type_to_value as appropriate.
11812         * python/python-internal.h (Py_buffer_deleter): New struct.
11813         (Py_buffer_up): New typedef.
11814
11815 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11816
11817         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11818         instead of releasing ownership.
11819
11820 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11821
11822         * dwarf2read.c (open_and_init_dwp_file): Call
11823         elf_numsections instead of bfd_count_sections to initialize
11824         dwp_file->num_sections.
11825
11826 2019-02-25  Tom Tromey  <tromey@adacore.com>
11827
11828         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11829
11830 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11831
11832         * gcore.in: Add '--readnever' option when invoking GDB.
11833
11834 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11835
11836         * MAINTAINERS: Update my email address.
11837
11838 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11839
11840         * build-id.c (build_id_to_debug_bfd_1): New function.
11841         (build_id_to_debug_bfd): Look for separate debug file in
11842         sysroot.
11843
11844 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11845
11846         * gdbarch.sh: Update the copyright year range that is placed into
11847         generated files.
11848
11849 2019-02-22  Keith Seitz  <keiths@redhat.com>
11850
11851         PR symtab/23853
11852         * linespec.c (create_sals_line_offset): Search for the default
11853         symtab's filename instead of its fullname.
11854
11855 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11856
11857         * NEWS: Update style defaults.
11858
11859 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11860
11861         * main.c (captured_main_1): Disable styling in batch mode.
11862
11863 2019-02-20  Tom Tromey  <tom@tromey.com>
11864
11865         * symtab.c (symtab_symbol_info): Fix typos.
11866
11867 2019-02-20  Tom Tromey  <tromey@adacore.com>
11868
11869         * findcmd.c (_initialize_mem_search): Use upper case for
11870         metasyntactic variables.
11871
11872 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11873
11874         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11875         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11876
11877 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11878
11879         * top.h (source_file_name): Change to std::string.
11880         * top.c (source_file_name): Likewise.
11881         (command_line_input): Adjust.
11882         * cli/cli-script.c (script_from_file): Adjust.
11883
11884 2019-02-19  Tom Tromey  <tromey@adacore.com>
11885
11886         * ravenscar-thread.c
11887         (ravenscar_thread_target::update_thread_list): Don't call
11888         ada_build_task_list.
11889         * ada-lang.h (ada_build_task_list): Don't declare.
11890         * ada-tasks.c (struct ada_tasks_inferior_data)
11891         <task_list_valid_p>: Now bool.
11892         (read_known_tasks, ada_task_list_changed)
11893         (ada_tasks_invalidate_inferior_data): Update.
11894         (read_known_tasks_array): Return bool.
11895         (read_known_tasks_list): Likewise.
11896         (read_known_tasks): Return void.
11897         (ada_build_task_list): Now static.
11898
11899 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11900
11901         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11902         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11903
11904 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11905
11906         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11907         variant for ada_tasks_pspace_data_handle and
11908         ada_tasks_inferior_data_handle.
11909         (ada_tasks_pspace_data_cleanup): New function.
11910         (ada_tasks_inferior_data_cleanup): New function.
11911
11912 2019-02-17  Tom Tromey  <tom@tromey.com>
11913
11914         * macrotab.h (macro_source_fullname): Return a std::string.
11915         * macrotab.c (macro_include, check_for_redefinition)
11916         (macro_undef, macro_lookup_definition, foreach_macro)
11917         (foreach_macro_in_scope): Update.
11918         (macro_source_fullname): Return a std::string.
11919         * macrocmd.c (show_pp_source_pos): Update.
11920
11921 2019-02-17  Tom Tromey  <tom@tromey.com>
11922
11923         * macrocmd.c (show_pp_source_pos): Style the file names.
11924
11925 2019-02-17  Tom Tromey  <tom@tromey.com>
11926
11927         PR tui/24197:
11928         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11929
11930 2019-02-17  Tom Tromey  <tom@tromey.com>
11931
11932         * ada-lang.c (user_select_syms): Use filtered printing.
11933         * utils.c (wrap_style): New global.
11934         (desired_style): Remove.
11935         (emit_style_escape): Add stream parameter.
11936         (set_output_style, reset_terminal_style, prompt_for_continue):
11937         Update.
11938         (flush_wrap_buffer): Only flush gdb_stdout.
11939         (wrap_here): Set wrap_style.
11940         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11941         treat escape sequences as a character.  Change when wrap buffer is
11942         flushed.
11943         (fputs_styled): Do not set the output style when the default is
11944         requested.
11945         * ui-style.h (struct ui_file_style) <is_default>: New method.
11946         * source.c (print_source_lines_base): Emit escape sequences in one
11947         piece.
11948
11949 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11950
11951         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11952         integers and enumeration types.
11953
11954 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11955
11956         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11957         instead of lookup_symbol_in_language
11958         (do_exact_match): New function.
11959         (ada_get_symbol_name_matcher): Return do_exact_match when
11960         doing a verbatim match.
11961
11962 2019-02-15  Tom Tromey  <tromey@adacore.com>
11963
11964         * ravenscar-thread.c (ravenscar_thread_target::resume)
11965         (ravenscar_thread_target::wait): Special case wildcard requests.
11966
11967 2019-02-15  Tom Tromey  <tromey@adacore.com>
11968
11969         * ravenscar-thread.c (base_ptid): Remove.
11970         (struct ravenscar_thread_target) <close>: New method.
11971         <m_base_ptid>: New member.
11972         <update_inferior_ptid, active_task, task_is_currently_active,
11973         runtime_initialized>: Declare methods.
11974         <ravenscar_thread_target>: Add constructor.
11975         (ravenscar_thread_target::task_is_currently_active)
11976         (ravenscar_thread_target::update_inferior_ptid)
11977         (ravenscar_runtime_initialized): Rename.  Now methods.
11978         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11979         (ravenscar_thread_target::update_thread_list): Update.
11980         (ravenscar_thread_target::active_task): Now method.
11981         (ravenscar_thread_target::store_registers)
11982         (ravenscar_thread_target::prepare_to_store)
11983         (ravenscar_thread_target::prepare_to_store)
11984         (ravenscar_thread_target::mourn_inferior): Update.
11985         (ravenscar_inferior_created): Use "new" to create target.
11986         (ravenscar_thread_target::get_ada_task_ptid): Update.
11987         (_initialize_ravenscar): Don't initialize base_ptid.
11988         (ravenscar_ops): Remove global.
11989
11990 2019-02-15  Tom Tromey  <tromey@adacore.com>
11991
11992         * target.h (push_target): Declare new overload.
11993         * target.c (push_target): New overload, taking an rvalue reference.
11994         * remote.c (remote_target::open_1): Use push_target overload.
11995         * corelow.c (core_target_open): Use push_target overload.
11996
11997 2019-02-15  Tom Tromey  <tromey@adacore.com>
11998
11999         * ravenscar-thread.c (is_ravenscar_task)
12000         (ravenscar_task_is_currently_active): Return bool.
12001         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12002         (_initialize_ravenscar): Remove "(void)".
12003         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12004         Return bool.
12005
12006 2019-02-15  Tom Tromey  <tromey@adacore.com>
12007
12008         * ravenscar-thread.c (ravenscar_runtime_initializer)
12009         (has_ravenscar_runtime, get_running_thread_id)
12010         (ravenscar_thread_target::resume): Fix indentation.
12011
12012 2019-02-15  Tom Tromey  <tromey@adacore.com>
12013
12014         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12015         from ravenscar_arch_ops.
12016         (sparc_ravenscar_ops::fetch_registers)
12017         (sparc_ravenscar_ops::store_registers): Now methods.
12018         (sparc_ravenscar_prepare_to_store): Remove.
12019         (sparc_ravenscar_ops): Redefine.
12020         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12021         methods and destructor.  Remove members.
12022         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12023         (ravenscar_thread_target::store_registers)
12024         (ravenscar_thread_target::prepare_to_store): Update.
12025         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12026         Remove.
12027         (struct ppc_ravenscar_powerpc_ops): Derive from
12028         ravenscar_arch_ops.
12029         (ppc_ravenscar_powerpc_ops::fetch_registers)
12030         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12031         (ppc_ravenscar_powerpc_ops): Redefine.
12032         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12033         (ppc_ravenscar_e500_ops::fetch_registers)
12034         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12035         (ppc_ravenscar_e500_ops): Redefine.
12036         * aarch64-ravenscar-thread.c
12037         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12038         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12039         (aarch64_ravenscar_fetch_registers)
12040         (aarch64_ravenscar_store_registers): Now methods.
12041         (aarch64_ravenscar_ops): Redefine.
12042
12043 2019-02-15  Tom Tromey  <tromey@adacore.com>
12044
12045         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12046         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12047         (ravenscar_thread_target::stopped_by_watchpoint)
12048         (ravenscar_thread_target::stopped_data_address)
12049         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12050
12051 2019-02-15  Tom Tromey  <tromey@adacore.com>
12052
12053         * ravenscar-thread.c: Fix some typos.
12054
12055 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12056             Tom Tromey  <tromey@adacore.com>
12057
12058         * ada-lang.c (ada_exception_sal): Change addr_string to a
12059         std::string.
12060         (create_ada_exception_catchpoint): Update.
12061
12062 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12063             Tom Tromey  <tromey@adacore.com>
12064
12065         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12066         (bp_location_ops): Remove.
12067         (base_breakpoint_allocate_location): Update.
12068         (free_bp_location): Update.
12069         * ada-lang.c (class ada_catchpoint_location)
12070         <ada_catchpoint_location>: Remove ops parameter.
12071         (ada_catchpoint_location_dtor): Remove.
12072         (ada_catchpoint_location_ops): Remove.
12073         (allocate_location_exception): Update.
12074         * breakpoint.h (struct bp_location_ops): Remove.
12075         (class bp_location) <bp_location>: Remove bp_location_ops
12076         parameter.
12077         <~bp_location>: Add destructor.
12078         <ops>: Remove.
12079
12080 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12081             Pedro Alves  <palves@redhat.com>
12082
12083         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12084         'PATH_MAX'.
12085
12086 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12087             Samuel Thibault  <samuel.thibault@gnu.org>
12088             Thomas Schwinge  <thomas@codesourcery.com>
12089
12090         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12091         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12092
12093 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12094
12095         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12096         (check_empty): Use "const char *".
12097
12098         * gnu-nat.c (gnu_nat_target::detach): Instead of
12099         'detach_inferior (pid)' call
12100         'detach_inferior (find_inferior_pid (pid))'.
12101
12102         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12103         'nat/fork-inferior.o'.
12104         * gnu-nat.c: #include "nat/fork-inferior.h".
12105
12106         * gnu-nat.c (gnu_nat_target::detach): Instead of
12107         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12108         * gnu-nat.h: #include "inf-child.h".
12109         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12110         'i386_gnu_nat_target::fetch_registers'.
12111         (gnu_store_registers): Rename/move to
12112         'i386_gnu_nat_target::store_registers'.
12113
12114         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12115         * gnu-nat.h (mach_thread_info): New function.
12116         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12117
12118         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12119
12120 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12121
12122         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12123
12124 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12125
12126         * windows-nat.c (windows_add_thread): Add new parameter
12127         "main_thread_p" with default value set to false.  Update
12128         function documentation as well as all callers.
12129         (windows_delete_thread): Likewise.
12130         (fake_create_process): Update call to windows_add_thread.
12131         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12132         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12133         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12134         call to windows_delete_thread.
12135
12136 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12137
12138         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12139
12140 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12141
12142         * symfile.c (find_separate_debug_file): Use canonical path of
12143         sysroot with child_path instead of gdb_sysroot if it is valid.
12144
12145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12146
12147         * symfile.c (find_separate_debug_file): Use child_path to
12148         determine if an object file is under a sysroot.
12149
12150 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12151
12152         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12153         unittests/child-path-selftests.c.
12154         * common/pathstuff.c (child_path): New function.
12155         * common/pathstuff.h (child_path): New prototype.
12156         * unittests/child-path-selftests.c: New file.
12157
12158 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12159
12160         * symfile.c (find_separate_debug_file): Look for separate debug
12161         files in debug directories under the sysroot.
12162
12163 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12164
12165         * symtab.h (struct minimal_symbol data_p): New const method.
12166         (struct minimal_symbol text_p): Likewise.
12167         * symtab.c (output_source_filename): Use file name style
12168         to print file name.
12169         (print_symbol_info): Likewise.
12170         (print_msymbol_info): Use address style to print addresses.
12171         Use function name style to print executable text symbols.
12172         (expand_symtab_containing_pc): Use data_p.
12173         (find_pc_sect_compunit_symtab): Likewise.
12174
12175 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12176
12177         * breakpoint.c (describe_other_breakpoints): Use address style
12178         to print addresses.
12179         (say_where): Likewise.
12180
12181 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12182
12183         * ada-typeprint.c (print_func_type): Print function name
12184         style to print function name.
12185         * c-typeprint.c (c_print_type_1): Likewise.
12186
12187 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12188
12189         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12190         for execve.
12191
12192 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12193
12194         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12195         type_stack.
12196
12197 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12198
12199         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12200         TYPE_CODE_REF types.
12201
12202 2019-02-08  Jim Wilson  <jimw@sifive.com>
12203
12204         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12205         (riscv_linux_fregset): New.
12206         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12207
12208 2019-02-07  Tom Tromey  <tom@tromey.com>
12209
12210         * thread.c (thread_cancel_execution_command): Update.
12211         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12212         methods.
12213         (struct thread_fsm_ops): Remove.
12214         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12215         (thread_fsm_should_stop, thread_fsm_return_value)
12216         (thread_fsm_set_finished, thread_fsm_finished_p)
12217         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12218         Don't declare.
12219         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12220         * infrun.c (clear_proceed_status_thread)
12221         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12222         (print_stop_event): Update.
12223         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12224         Add constructor.
12225         (step_command_fsm_ops): Remove.
12226         (new_step_command_fsm): Remove.
12227         (step_1): Update.
12228         (step_command_fsm::should_stop): Rename from
12229         step_command_fsm_should_stop.
12230         (step_command_fsm::clean_up): Rename from
12231         step_command_fsm_clean_up.
12232         (step_command_fsm::do_async_reply_reason): Rename from
12233         step_command_fsm_async_reply_reason.
12234         (struct until_next_fsm): Inherit from thread_fsm.  Add
12235         constructor.
12236         (until_next_fsm_ops): Remove.
12237         (new_until_next_fsm): Remove.
12238         (until_next_fsm::should_stop): Rename from
12239         until_next_fsm_should_stop.
12240         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12241         (until_next_fsm::do_async_reply_reason): Rename from
12242         until_next_fsm_async_reply_reason.
12243         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12244         constructor.  Change type of breakpoint.
12245         (finish_command_fsm_ops): Remove.
12246         (new_finish_command_fsm): Remove.
12247         (finish_command_fsm::should_stop): Rename from
12248         finish_command_fsm_should_stop.
12249         (finish_command_fsm::clean_up): Rename from
12250         finish_command_fsm_clean_up.
12251         (finish_command_fsm::return_value): Rename from
12252         finish_command_fsm_return_value.
12253         (finish_command_fsm::do_async_reply_reason): Rename from
12254         finish_command_fsm_async_reply_reason.
12255         (finish_command): Update.
12256         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12257         Add constructor.
12258         (call_thread_fsm_ops): Remove.
12259         (call_thread_fsm::call_thread_fsm): Rename from
12260         new_call_thread_fsm.
12261         (call_thread_fsm::should_stop): Rename from
12262         call_thread_fsm_should_stop.
12263         (call_thread_fsm::should_notify_stop): Rename from
12264         call_thread_fsm_should_notify_stop.
12265         (run_inferior_call, call_function_by_hand_dummy): Update.
12266         * cli/cli-interp.c (should_print_stop_to_console): Update.
12267         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12268         Add constructor.  Change type of location_breakpoint,
12269         caller_breakpoint.
12270         (until_break_fsm_ops): Remove.
12271         (new_until_break_fsm): Remove.
12272         (until_break_fsm::should_stop): Rename from
12273         until_break_fsm_should_stop.
12274         (until_break_fsm::clean_up): Rename from
12275         until_break_fsm_clean_up.
12276         (until_break_fsm::do_async_reply_reason): Rename from
12277         until_break_fsm_async_reply_reason.
12278         (until_break_command): Update.
12279         * thread-fsm.c: Remove.
12280         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12281
12282 2019-02-07  Tom Tromey  <tom@tromey.com>
12283
12284         * yy-remap.h: Add include guard.
12285         * xtensa-tdep.h: Add include guard.
12286         * xcoffread.h: Rename include guard.
12287         * varobj-iter.h: Add include guard.
12288         * tui/tui.h: Rename include guard.
12289         * tui/tui-winsource.h: Rename include guard.
12290         * tui/tui-wingeneral.h: Rename include guard.
12291         * tui/tui-windata.h: Rename include guard.
12292         * tui/tui-win.h: Rename include guard.
12293         * tui/tui-stack.h: Rename include guard.
12294         * tui/tui-source.h: Rename include guard.
12295         * tui/tui-regs.h: Rename include guard.
12296         * tui/tui-out.h: Rename include guard.
12297         * tui/tui-layout.h: Rename include guard.
12298         * tui/tui-io.h: Rename include guard.
12299         * tui/tui-hooks.h: Rename include guard.
12300         * tui/tui-file.h: Rename include guard.
12301         * tui/tui-disasm.h: Rename include guard.
12302         * tui/tui-data.h: Rename include guard.
12303         * tui/tui-command.h: Rename include guard.
12304         * tic6x-tdep.h: Add include guard.
12305         * target/waitstatus.h: Rename include guard.
12306         * target/wait.h: Rename include guard.
12307         * target/target.h: Rename include guard.
12308         * target/resume.h: Rename include guard.
12309         * target-float.h: Rename include guard.
12310         * stabsread.h: Add include guard.
12311         * rs6000-tdep.h: Add include guard.
12312         * riscv-fbsd-tdep.h: Add include guard.
12313         * regformats/regdef.h: Rename include guard.
12314         * record.h: Rename include guard.
12315         * python/python.h: Rename include guard.
12316         * python/python-internal.h: Rename include guard.
12317         * python/py-stopevent.h: Rename include guard.
12318         * python/py-ref.h: Rename include guard.
12319         * python/py-record.h: Rename include guard.
12320         * python/py-record-full.h: Rename include guard.
12321         * python/py-record-btrace.h: Rename include guard.
12322         * python/py-instruction.h: Rename include guard.
12323         * python/py-events.h: Rename include guard.
12324         * python/py-event.h: Rename include guard.
12325         * procfs.h: Add include guard.
12326         * proc-utils.h: Add include guard.
12327         * p-lang.h: Add include guard.
12328         * or1k-tdep.h: Rename include guard.
12329         * observable.h: Rename include guard.
12330         * nto-tdep.h: Rename include guard.
12331         * nat/x86-linux.h: Rename include guard.
12332         * nat/x86-linux-dregs.h: Rename include guard.
12333         * nat/x86-gcc-cpuid.h: Add include guard.
12334         * nat/x86-dregs.h: Rename include guard.
12335         * nat/x86-cpuid.h: Rename include guard.
12336         * nat/ppc-linux.h: Rename include guard.
12337         * nat/mips-linux-watch.h: Rename include guard.
12338         * nat/linux-waitpid.h: Rename include guard.
12339         * nat/linux-ptrace.h: Rename include guard.
12340         * nat/linux-procfs.h: Rename include guard.
12341         * nat/linux-osdata.h: Rename include guard.
12342         * nat/linux-nat.h: Rename include guard.
12343         * nat/linux-namespaces.h: Rename include guard.
12344         * nat/linux-btrace.h: Rename include guard.
12345         * nat/glibc_thread_db.h: Rename include guard.
12346         * nat/gdb_thread_db.h: Rename include guard.
12347         * nat/gdb_ptrace.h: Rename include guard.
12348         * nat/fork-inferior.h: Rename include guard.
12349         * nat/amd64-linux-siginfo.h: Rename include guard.
12350         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12351         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12352         * nat/aarch64-linux.h: Rename include guard.
12353         * nat/aarch64-linux-hw-point.h: Rename include guard.
12354         * mn10300-tdep.h: Add include guard.
12355         * mips-linux-tdep.h: Add include guard.
12356         * mi/mi-parse.h: Rename include guard.
12357         * mi/mi-out.h: Rename include guard.
12358         * mi/mi-main.h: Rename include guard.
12359         * mi/mi-interp.h: Rename include guard.
12360         * mi/mi-getopt.h: Rename include guard.
12361         * mi/mi-console.h: Rename include guard.
12362         * mi/mi-common.h: Rename include guard.
12363         * mi/mi-cmds.h: Rename include guard.
12364         * mi/mi-cmd-break.h: Rename include guard.
12365         * m2-lang.h: Add include guard.
12366         * location.h: Rename include guard.
12367         * linux-record.h: Rename include guard.
12368         * linux-nat.h: Add include guard.
12369         * linux-fork.h: Add include guard.
12370         * i386-darwin-tdep.h: Rename include guard.
12371         * hppa-linux-offsets.h: Add include guard.
12372         * guile/guile.h: Rename include guard.
12373         * guile/guile-internal.h: Rename include guard.
12374         * gnu-nat.h: Rename include guard.
12375         * gdb-stabs.h: Rename include guard.
12376         * frv-tdep.h: Add include guard.
12377         * f-lang.h: Add include guard.
12378         * event-loop.h: Add include guard.
12379         * darwin-nat.h: Rename include guard.
12380         * cp-abi.h: Rename include guard.
12381         * config/sparc/nm-sol2.h: Rename include guard.
12382         * config/nm-nto.h: Rename include guard.
12383         * config/nm-linux.h: Add include guard.
12384         * config/i386/nm-i386gnu.h: Rename include guard.
12385         * config/djgpp/nl_types.h: Rename include guard.
12386         * config/djgpp/langinfo.h: Rename include guard.
12387         * compile/gcc-cp-plugin.h: Add include guard.
12388         * compile/gcc-c-plugin.h: Add include guard.
12389         * compile/compile.h: Rename include guard.
12390         * compile/compile-object-run.h: Rename include guard.
12391         * compile/compile-object-load.h: Rename include guard.
12392         * compile/compile-internal.h: Rename include guard.
12393         * compile/compile-cplus.h: Rename include guard.
12394         * compile/compile-c.h: Rename include guard.
12395         * common/xml-utils.h: Rename include guard.
12396         * common/x86-xstate.h: Rename include guard.
12397         * common/version.h: Rename include guard.
12398         * common/vec.h: Rename include guard.
12399         * common/tdesc.h: Rename include guard.
12400         * common/selftest.h: Rename include guard.
12401         * common/scoped_restore.h: Rename include guard.
12402         * common/scoped_mmap.h: Rename include guard.
12403         * common/scoped_fd.h: Rename include guard.
12404         * common/safe-iterator.h: Rename include guard.
12405         * common/run-time-clock.h: Rename include guard.
12406         * common/refcounted-object.h: Rename include guard.
12407         * common/queue.h: Rename include guard.
12408         * common/ptid.h: Rename include guard.
12409         * common/print-utils.h: Rename include guard.
12410         * common/preprocessor.h: Rename include guard.
12411         * common/pathstuff.h: Rename include guard.
12412         * common/observable.h: Rename include guard.
12413         * common/netstuff.h: Rename include guard.
12414         * common/job-control.h: Rename include guard.
12415         * common/host-defs.h: Rename include guard.
12416         * common/gdb_wait.h: Rename include guard.
12417         * common/gdb_vecs.h: Rename include guard.
12418         * common/gdb_unlinker.h: Rename include guard.
12419         * common/gdb_unique_ptr.h: Rename include guard.
12420         * common/gdb_tilde_expand.h: Rename include guard.
12421         * common/gdb_sys_time.h: Rename include guard.
12422         * common/gdb_string_view.h: Rename include guard.
12423         * common/gdb_splay_tree.h: Rename include guard.
12424         * common/gdb_setjmp.h: Rename include guard.
12425         * common/gdb_ref_ptr.h: Rename include guard.
12426         * common/gdb_optional.h: Rename include guard.
12427         * common/gdb_locale.h: Rename include guard.
12428         * common/gdb_assert.h: Rename include guard.
12429         * common/filtered-iterator.h: Rename include guard.
12430         * common/filestuff.h: Rename include guard.
12431         * common/fileio.h: Rename include guard.
12432         * common/environ.h: Rename include guard.
12433         * common/common-utils.h: Rename include guard.
12434         * common/common-types.h: Rename include guard.
12435         * common/common-regcache.h: Rename include guard.
12436         * common/common-inferior.h: Rename include guard.
12437         * common/common-gdbthread.h: Rename include guard.
12438         * common/common-exceptions.h: Rename include guard.
12439         * common/common-defs.h: Rename include guard.
12440         * common/common-debug.h: Rename include guard.
12441         * common/cleanups.h: Rename include guard.
12442         * common/buffer.h: Rename include guard.
12443         * common/btrace-common.h: Rename include guard.
12444         * common/break-common.h: Rename include guard.
12445         * cli/cli-utils.h: Rename include guard.
12446         * cli/cli-style.h: Rename include guard.
12447         * cli/cli-setshow.h: Rename include guard.
12448         * cli/cli-script.h: Rename include guard.
12449         * cli/cli-interp.h: Rename include guard.
12450         * cli/cli-decode.h: Rename include guard.
12451         * cli/cli-cmds.h: Rename include guard.
12452         * charset-list.h: Add include guard.
12453         * buildsym-legacy.h: Rename include guard.
12454         * bfin-tdep.h: Add include guard.
12455         * ax.h: Rename include guard.
12456         * arm-linux-tdep.h: Add include guard.
12457         * arm-fbsd-tdep.h: Add include guard.
12458         * arch/xtensa.h: Rename include guard.
12459         * arch/tic6x.h: Add include guard.
12460         * arch/i386.h: Add include guard.
12461         * arch/arm.h: Rename include guard.
12462         * arch/arm-linux.h: Rename include guard.
12463         * arch/arm-get-next-pcs.h: Rename include guard.
12464         * arch/amd64.h: Add include guard.
12465         * arch/aarch64-insn.h: Rename include guard.
12466         * arch-utils.h: Rename include guard.
12467         * annotate.h: Add include guard.
12468         * amd64-darwin-tdep.h: Rename include guard.
12469         * aarch64-linux-tdep.h: Add include guard.
12470         * aarch64-fbsd-tdep.h: Add include guard.
12471         * aarch32-linux-nat.h: Add include guard.
12472
12473 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12474
12475         * macrotab.c (macro_define_internal): New function that
12476         factorizes macro_define_object_internal and macro_define_function
12477         code.
12478         (macro_define_object_internal): Use macro_define_internal.
12479         (macro_define_function): Likewise.
12480
12481 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12482
12483         * macrocmd.c (extract_identifier): Return
12484         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12485         callers.
12486
12487 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12488
12489         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12490
12491 2019-02-05  Tom Tromey  <tom@tromey.com>
12492
12493         * target.c (target_stack::unpush): Move assertion earlier.
12494
12495 2019-01-30  Tom Tromey  <tom@tromey.com>
12496
12497         PR python/23615:
12498         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12499         (gdbpy_parse_and_eval): Likewise.
12500         * python/python-internal.h (gdbpy_allow_threads): New class.
12501
12502 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12503
12504         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12505         (aarch64_fbsd_fpregmap): Move earlier.
12506         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12507         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12508         instead of individual calls to trad_frame_set_reg_addr.
12509         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12510         earlier.
12511         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12512         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12513         instead of individual calls to trad_frame_set_reg_addr.
12514
12515 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12516
12517         * CONTRIBUTE: Replace contribution list with wiki link.
12518
12519 2019-01-25  Tom Tromey  <tom@tromey.com>
12520
12521         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12522
12523 2019-01-25  Tom Tromey  <tom@tromey.com>
12524
12525         * xtensa-linux-nat.c: Fix common/ includes.
12526         * xml-support.h: Fix common/ includes.
12527         * xml-support.c: Fix common/ includes.
12528         * x86-linux-nat.c: Fix common/ includes.
12529         * windows-nat.c: Fix common/ includes.
12530         * varobj.h: Fix common/ includes.
12531         * varobj.c: Fix common/ includes.
12532         * value.c: Fix common/ includes.
12533         * valops.c: Fix common/ includes.
12534         * utils.c: Fix common/ includes.
12535         * unittests/xml-utils-selftests.c: Fix common/ includes.
12536         * unittests/utils-selftests.c: Fix common/ includes.
12537         * unittests/unpack-selftests.c: Fix common/ includes.
12538         * unittests/tracepoint-selftests.c: Fix common/ includes.
12539         * unittests/style-selftests.c: Fix common/ includes.
12540         * unittests/string_view-selftests.c: Fix common/ includes.
12541         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12542         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12543         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12544         * unittests/rsp-low-selftests.c: Fix common/ includes.
12545         * unittests/parse-connection-spec-selftests.c: Fix common/
12546         includes.
12547         * unittests/optional-selftests.c: Fix common/ includes.
12548         * unittests/offset-type-selftests.c: Fix common/ includes.
12549         * unittests/observable-selftests.c: Fix common/ includes.
12550         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12551         * unittests/memrange-selftests.c: Fix common/ includes.
12552         * unittests/memory-map-selftests.c: Fix common/ includes.
12553         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12554         * unittests/function-view-selftests.c: Fix common/ includes.
12555         * unittests/environ-selftests.c: Fix common/ includes.
12556         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12557         * unittests/common-utils-selftests.c: Fix common/ includes.
12558         * unittests/cli-utils-selftests.c: Fix common/ includes.
12559         * unittests/array-view-selftests.c: Fix common/ includes.
12560         * ui-file.c: Fix common/ includes.
12561         * tui/tui-io.c: Fix common/ includes.
12562         * tracepoint.h: Fix common/ includes.
12563         * tracepoint.c: Fix common/ includes.
12564         * tracefile-tfile.c: Fix common/ includes.
12565         * top.h: Fix common/ includes.
12566         * top.c: Fix common/ includes.
12567         * thread.c: Fix common/ includes.
12568         * target/waitstatus.h: Fix common/ includes.
12569         * target/waitstatus.c: Fix common/ includes.
12570         * target.h: Fix common/ includes.
12571         * target.c: Fix common/ includes.
12572         * target-memory.c: Fix common/ includes.
12573         * target-descriptions.c: Fix common/ includes.
12574         * symtab.h: Fix common/ includes.
12575         * symfile.c: Fix common/ includes.
12576         * stap-probe.c: Fix common/ includes.
12577         * spu-linux-nat.c: Fix common/ includes.
12578         * sparc-nat.c: Fix common/ includes.
12579         * source.c: Fix common/ includes.
12580         * solib.c: Fix common/ includes.
12581         * solib-target.c: Fix common/ includes.
12582         * ser-unix.c: Fix common/ includes.
12583         * ser-tcp.c: Fix common/ includes.
12584         * ser-pipe.c: Fix common/ includes.
12585         * ser-base.c: Fix common/ includes.
12586         * selftest-arch.c: Fix common/ includes.
12587         * s12z-tdep.c: Fix common/ includes.
12588         * rust-exp.y: Fix common/ includes.
12589         * rs6000-aix-tdep.c: Fix common/ includes.
12590         * riscv-tdep.c: Fix common/ includes.
12591         * remote.c: Fix common/ includes.
12592         * remote-notif.h: Fix common/ includes.
12593         * remote-fileio.h: Fix common/ includes.
12594         * remote-fileio.c: Fix common/ includes.
12595         * regcache.h: Fix common/ includes.
12596         * regcache.c: Fix common/ includes.
12597         * record-btrace.c: Fix common/ includes.
12598         * python/python.c: Fix common/ includes.
12599         * python/py-type.c: Fix common/ includes.
12600         * python/py-inferior.c: Fix common/ includes.
12601         * progspace.h: Fix common/ includes.
12602         * producer.c: Fix common/ includes.
12603         * procfs.c: Fix common/ includes.
12604         * proc-api.c: Fix common/ includes.
12605         * printcmd.c: Fix common/ includes.
12606         * ppc-linux-nat.c: Fix common/ includes.
12607         * parser-defs.h: Fix common/ includes.
12608         * osdata.c: Fix common/ includes.
12609         * obsd-nat.c: Fix common/ includes.
12610         * nat/x86-linux.c: Fix common/ includes.
12611         * nat/x86-linux-dregs.c: Fix common/ includes.
12612         * nat/x86-dregs.h: Fix common/ includes.
12613         * nat/x86-dregs.c: Fix common/ includes.
12614         * nat/ppc-linux.c: Fix common/ includes.
12615         * nat/mips-linux-watch.h: Fix common/ includes.
12616         * nat/mips-linux-watch.c: Fix common/ includes.
12617         * nat/linux-waitpid.c: Fix common/ includes.
12618         * nat/linux-ptrace.h: Fix common/ includes.
12619         * nat/linux-ptrace.c: Fix common/ includes.
12620         * nat/linux-procfs.c: Fix common/ includes.
12621         * nat/linux-personality.c: Fix common/ includes.
12622         * nat/linux-osdata.c: Fix common/ includes.
12623         * nat/linux-namespaces.c: Fix common/ includes.
12624         * nat/linux-btrace.h: Fix common/ includes.
12625         * nat/linux-btrace.c: Fix common/ includes.
12626         * nat/fork-inferior.c: Fix common/ includes.
12627         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12628         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12629         * nat/aarch64-linux.c: Fix common/ includes.
12630         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12631         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12632         * namespace.h: Fix common/ includes.
12633         * mips-linux-tdep.c: Fix common/ includes.
12634         * minsyms.c: Fix common/ includes.
12635         * mi/mi-parse.h: Fix common/ includes.
12636         * mi/mi-main.c: Fix common/ includes.
12637         * mi/mi-cmd-env.c: Fix common/ includes.
12638         * memrange.h: Fix common/ includes.
12639         * memattr.c: Fix common/ includes.
12640         * maint.h: Fix common/ includes.
12641         * maint.c: Fix common/ includes.
12642         * main.c: Fix common/ includes.
12643         * machoread.c: Fix common/ includes.
12644         * location.c: Fix common/ includes.
12645         * linux-thread-db.c: Fix common/ includes.
12646         * linux-nat.c: Fix common/ includes.
12647         * linux-fork.c: Fix common/ includes.
12648         * inline-frame.c: Fix common/ includes.
12649         * infrun.c: Fix common/ includes.
12650         * inflow.c: Fix common/ includes.
12651         * inferior.h: Fix common/ includes.
12652         * inferior.c: Fix common/ includes.
12653         * infcmd.c: Fix common/ includes.
12654         * inf-ptrace.c: Fix common/ includes.
12655         * inf-child.c: Fix common/ includes.
12656         * ia64-linux-nat.c: Fix common/ includes.
12657         * i387-tdep.c: Fix common/ includes.
12658         * i386-tdep.c: Fix common/ includes.
12659         * i386-linux-tdep.c: Fix common/ includes.
12660         * i386-linux-nat.c: Fix common/ includes.
12661         * i386-go32-tdep.c: Fix common/ includes.
12662         * i386-fbsd-tdep.c: Fix common/ includes.
12663         * i386-fbsd-nat.c: Fix common/ includes.
12664         * guile/scm-type.c: Fix common/ includes.
12665         * guile/guile.c: Fix common/ includes.
12666         * go32-nat.c: Fix common/ includes.
12667         * gnu-nat.c: Fix common/ includes.
12668         * gdbthread.h: Fix common/ includes.
12669         * gdbarch-selftests.c: Fix common/ includes.
12670         * gdb_usleep.c: Fix common/ includes.
12671         * gdb_select.h: Fix common/ includes.
12672         * gdb_bfd.c: Fix common/ includes.
12673         * gcore.c: Fix common/ includes.
12674         * fork-child.c: Fix common/ includes.
12675         * findvar.c: Fix common/ includes.
12676         * fbsd-nat.c: Fix common/ includes.
12677         * event-top.c: Fix common/ includes.
12678         * event-loop.c: Fix common/ includes.
12679         * dwarf2read.c: Fix common/ includes.
12680         * dwarf2loc.c: Fix common/ includes.
12681         * dwarf2-frame.c: Fix common/ includes.
12682         * dwarf-index-cache.c: Fix common/ includes.
12683         * dtrace-probe.c: Fix common/ includes.
12684         * disasm-selftests.c: Fix common/ includes.
12685         * defs.h: Fix common/ includes.
12686         * csky-tdep.c: Fix common/ includes.
12687         * cp-valprint.c: Fix common/ includes.
12688         * cp-support.h: Fix common/ includes.
12689         * cp-support.c: Fix common/ includes.
12690         * corelow.c: Fix common/ includes.
12691         * completer.h: Fix common/ includes.
12692         * completer.c: Fix common/ includes.
12693         * compile/compile.c: Fix common/ includes.
12694         * compile/compile-loc2c.c: Fix common/ includes.
12695         * compile/compile-cplus-types.c: Fix common/ includes.
12696         * compile/compile-cplus-symbols.c: Fix common/ includes.
12697         * command.h: Fix common/ includes.
12698         * cli/cli-dump.c: Fix common/ includes.
12699         * cli/cli-cmds.c: Fix common/ includes.
12700         * charset.c: Fix common/ includes.
12701         * build-id.c: Fix common/ includes.
12702         * btrace.h: Fix common/ includes.
12703         * btrace.c: Fix common/ includes.
12704         * breakpoint.h: Fix common/ includes.
12705         * breakpoint.c: Fix common/ includes.
12706         * ax.h:
12707         (enum agent_op): Fix common/ includes.
12708         * ax-general.c (struct aop_map): Fix common/ includes.
12709         * ax-gdb.c: Fix common/ includes.
12710         * auxv.c: Fix common/ includes.
12711         * auto-load.c: Fix common/ includes.
12712         * arm-tdep.c: Fix common/ includes.
12713         * arch/riscv.c: Fix common/ includes.
12714         * arch/ppc-linux-common.c: Fix common/ includes.
12715         * arch/i386.c: Fix common/ includes.
12716         * arch/arm.c: Fix common/ includes.
12717         * arch/arm-linux.c: Fix common/ includes.
12718         * arch/arm-get-next-pcs.c: Fix common/ includes.
12719         * arch/amd64.c: Fix common/ includes.
12720         * arch/aarch64.c: Fix common/ includes.
12721         * arch/aarch64-insn.c: Fix common/ includes.
12722         * arch-utils.c: Fix common/ includes.
12723         * amd64-windows-tdep.c: Fix common/ includes.
12724         * amd64-tdep.c: Fix common/ includes.
12725         * amd64-sol2-tdep.c: Fix common/ includes.
12726         * amd64-obsd-tdep.c: Fix common/ includes.
12727         * amd64-nbsd-tdep.c: Fix common/ includes.
12728         * amd64-linux-tdep.c: Fix common/ includes.
12729         * amd64-linux-nat.c: Fix common/ includes.
12730         * amd64-fbsd-tdep.c: Fix common/ includes.
12731         * amd64-fbsd-nat.c: Fix common/ includes.
12732         * amd64-dicos-tdep.c: Fix common/ includes.
12733         * amd64-darwin-tdep.c: Fix common/ includes.
12734         * agent.c: Fix common/ includes.
12735         * ada-lang.h: Fix common/ includes.
12736         * ada-lang.c: Fix common/ includes.
12737         * aarch64-tdep.c: Fix common/ includes.
12738
12739 2019-01-25  Tom Tromey  <tom@tromey.com>
12740
12741         * common/create-version.sh: Use common/version.h.
12742
12743 2019-01-24  Pedro Alves  <palves@redhat.com>
12744
12745         * infrun.c (signal_stop, signal_print, signal_program)
12746         (signal_catch, signal_pass): Now arrays instead of pointers.
12747         (update_signals_program_target, do_target_resume)
12748         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12749         * linux-nat.c (linux_nat_target::pass_signals)
12750         (linux_nat_target::create_inferior, linux_nat_target::attach):
12751         Adjust.
12752         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12753         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12754         * procfs.c (procfs_target::pass_signals): Adjust.
12755         * record-full.c (record_full_target::resume): Adjust.
12756         * remote.c (remote_target::pass_signals)
12757         (remote_target::program_signals): Adjust.
12758         * target-debug.h (target_debug_print_signals): Now takes a
12759         gdb::array_view as parameter.  Adjust.
12760         * target.h (target_ops) <pass_signals, program_signals>: Replace
12761         pointer and length parameters with gdb::array_view.
12762         (target_pass_signals, target_program_signals): Likewise.
12763         * target-delegates.c: Regenerate.
12764
12765 2019-01-24  Pedro Alves  <palves@redhat.com>
12766
12767         * common/forward-scope-exit.h
12768         (forward_scope_exit::forward_scope_exit): Pass arguments to
12769         m_bind_function directly, instead of creating a std::bind and
12770         copying that.
12771
12772 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12773
12774         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12775         for static members.
12776         (pass_in_v_vfp_candidate): Likewise.
12777
12778 2019-01-23  Tom Tromey  <tom@tromey.com>
12779             Pedro Alves  <palves@redhat.com>
12780
12781         * regcache.c (class regcache_invalidator): Remove.
12782         (regcache::raw_write): Use make_scope_exit.
12783
12784 2019-01-23  Tom Tromey  <tom@tromey.com>
12785
12786         * ui-out.h (class ui_out_emit_type): Update comment.
12787
12788 2019-01-23  Tom Tromey  <tom@tromey.com>
12789
12790         * infrun.c (fetch_inferior_event): Update comment.
12791
12792 2019-01-23  Tom Tromey  <tom@tromey.com>
12793             Pedro Alves  <palves@redhat.com>
12794
12795         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12796         parameter.
12797         (fetch_inferior_event): Use SCOPE_EXIT.
12798
12799
12800 2019-01-23  Tom Tromey  <tom@tromey.com>
12801             Pedro Alves  <palves@redhat.com>
12802
12803         * infrun.c (disable_thread_events): Delete.
12804         (stop_all_threads): Use SCOPE_EXIT.
12805
12806 2019-01-23  Tom Tromey  <tom@tromey.com>
12807             Pedro Alves  <palves@redhat.com>
12808
12809         * symfile.c: Include forward-scope-exit.h.
12810         (clear_symtab_users_cleanup): Replace forward declaration with
12811         a FORWARD_SCOPE_EXIT.
12812         (syms_from_objfile_1): Use the forward_scope_exit and
12813         gdb::optional instead of cleanup_function.
12814         (reread_symbols): Use the forward_scope_exit instead of
12815         cleanup_function.
12816         (clear_symtab_users_cleanup): Remove function.
12817
12818 2019-01-23  Tom Tromey  <tom@tromey.com>
12819             Pedro Alves  <palves@redhat.com>
12820
12821         * linux-nat.c: Include scope-exit.h.
12822         (cleanup_target_stop): Remove.
12823         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12824         SCOPE_EXIT.
12825
12826 2019-01-23  Tom Tromey  <tom@tromey.com>
12827             Pedro Alves  <palves@redhat.com>
12828
12829         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12830         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12831
12832 2019-01-23  Tom Tromey  <tom@tromey.com>
12833             Andrew Burgess  <andrew.burgess@embecosm.com>
12834             Pedro Alves  <palves@redhat.com>
12835
12836         * infrun.c (fetch_inferior_event): Use scope_exit.
12837         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12838         * top.c (execute_command): Use scope_exit.
12839         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12840         * utils.c (do_bpstat_clear_actions_cleanup)
12841         (make_bpstat_clear_actions_cleanup): Remove.
12842
12843 2019-01-23  Tom Tromey  <tom@tromey.com>
12844             Pedro Alves  <palves@redhat.com>
12845
12846         * infrun.c: Include "common/scope-exit.h"
12847         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12848         (wait_for_inferior): Use SCOPE_EXIT.
12849         (fetch_inferior_event): Use scope_exit.
12850
12851 2019-01-23  Tom Tromey  <tom@tromey.com>
12852             Pedro Alves  <palves@redhat.com>
12853
12854         * breakpoint.c (create_breakpoint): Remove cleanup.
12855
12856 2019-01-23  Tom Tromey  <tom@tromey.com>
12857             Andrew Burgess  <andrew.burgess@embecosm.com>
12858             Pedro Alves  <palves@redhat.com>
12859
12860 2019-01-23  Pedro Alves  <palves@redhat.com>
12861
12862         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12863
12864 2019-01-23  Pedro Alves  <palves@redhat.com>
12865             Andrew Burgess  <andrew.burgess@embecosm.com>
12866
12867         * gdbthread.h: Include "common/forward-scope-exit.h".
12868         (scoped_finish_thread_state): Redefine custom class in terms of
12869         forward_scope_exit.
12870
12871 2019-01-23  Pedro Alves  <palves@redhat.com>
12872             Andrew Burgess  <andrew.burgess@embecosm.com>
12873
12874         * common/forward-scope-exit.h: New file.
12875
12876 2019-01-23  Pedro Alves  <palves@redhat.com>
12877             Andrew Burgess  <andrew.burgess@embecosm.com>
12878             Tom Tromey  <tom@tromey.com>
12879
12880         * common/scope-exit.h: New file.
12881
12882 2019-01-23  Pedro Alves  <palves@redhat.com>
12883
12884         * common/preprocessor.h (ESC): Rename to ...
12885         (ESC_PARENS): ... this.
12886         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12887         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12888
12889 2019-01-23  Tom Tromey  <tom@tromey.com>
12890
12891         * language.h (class scoped_switch_to_sym_language_if_auto):
12892         Initialize m_lang in both cases.
12893
12894 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12895
12896         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12897         with XCNEW.
12898
12899 2019-01-22  Tom Tromey  <tom@tromey.com>
12900
12901         * corelow.c: Do not include sys/file.h.
12902
12903 2019-01-22  Tom Tromey  <tom@tromey.com>
12904
12905         * tui/tui-wingeneral.h: Include gdb_curses.h.
12906
12907 2019-01-22  Tom Tromey  <tom@tromey.com>
12908
12909         * source-cache.h (class source_cache) <get_source_lines,
12910         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12911
12912 2019-01-22  Tom Tromey  <tom@tromey.com>
12913
12914         * remote-fileio.h (struct remote_target): Declare.
12915
12916 2019-01-22  Tom Tromey  <tom@tromey.com>
12917
12918         * python/py-arch.c: Do not include py-ref.h.
12919         * python/py-bpevent.c: Do not include py-ref.h.
12920         * python/py-cmd.c: Do not include py-ref.h.
12921         * python/py-continueevent.c: Do not include py-ref.h.
12922         * python/py-event.h: Do not include py-ref.h.
12923         * python/py-evtregistry.c: Do not include py-ref.h.
12924         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12925         * python/py-frame.c: Do not include py-ref.h.
12926         * python/py-framefilter.c: Do not include py-ref.h.
12927         * python/py-function.c: Do not include py-ref.h.
12928         * python/py-infevents.c: Do not include py-ref.h.
12929         * python/py-linetable.c: Do not include py-ref.h.
12930         * python/py-objfile.c: Do not include py-ref.h.
12931         * python/py-param.c: Do not include py-ref.h.
12932         * python/py-prettyprint.c: Do not include py-ref.h.
12933         * python/py-progspace.c: Do not include py-ref.h.
12934         * python/py-symbol.c: Do not include py-ref.h.
12935         * python/py-symtab.c: Do not include py-ref.h.
12936         * python/py-type.c: Do not include py-ref.h.
12937         * python/py-unwind.c: Do not include py-ref.h.
12938         * python/py-utils.c: Do not include py-ref.h.
12939         * python/py-value.c: Do not include py-ref.h.
12940         * python/py-varobj.c: Do not include py-ref.h.
12941         * python/py-xmethods.c: Do not include py-ref.h.
12942         * python/python.c: Do not include py-ref.h.
12943         * varobj.c: Do not include py-ref.h.
12944
12945 2019-01-22  Tom Tromey  <tom@tromey.com>
12946
12947         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12948         keyword for bcache.
12949
12950 2019-01-22  Tom Tromey  <tom@tromey.com>
12951
12952         * compile/compile-cplus-types.c: Remove a comment by #include.
12953
12954 2019-01-22  Tom Tromey  <tom@tromey.com>
12955
12956         * compile/gcc-c-plugin.h: Include compile-internal.h.
12957
12958 2019-01-22  Tom Tromey  <tom@tromey.com>
12959
12960         * stabsread.c (EXTERN): Do not define.
12961         (symnum, next_symbol_text_func, processing_gcc_compilation)
12962         (within_function, global_sym_chain, global_stabs)
12963         (previous_stab_code, this_object_header_files)
12964         (n_this_object_header_files)
12965         (n_allocated_this_object_header_files): Define.
12966         * stabsread.h (EXTERN): Never define.  Use "extern".
12967
12968 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12969
12970         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12971         history_value.
12972
12973 2019-01-21  Tom Tromey  <tom@tromey.com>
12974
12975         * ui-out.c: Fix includes.
12976         * tui/tui-source.c: Fix includes.
12977         * target.c: Fix includes.
12978         * remote.c: Fix includes.
12979         * regcache.c: Fix includes.
12980         * python/py-block.c: Fix includes.
12981         * printcmd.c: Fix includes.
12982         * or1k-tdep.c: Fix includes.
12983         * mi/mi-main.c: Fix includes.
12984         * m32r-tdep.c: Fix includes.
12985         * csky-tdep.c: Fix includes.
12986         * compile/compile-cplus-types.c: Fix includes.
12987         * cli/cli-interp.c: Fix includes.
12988
12989 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12990
12991         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12992         for padding.
12993
12994 2019-01-16  Tom Tromey  <tom@tromey.com>
12995
12996         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12997         earlier.
12998         (struct objfile) <msymbols_range>: Move from top level.
12999         <msymbols>: New method.
13000         (class objfile_msymbols): Remove.
13001         * symtab.c (default_collect_symbol_completion_matches_break_on):
13002         Update.
13003         * symmisc.c (dump_msymbols): Update.
13004         * stabsread.c (scan_file_globals): Update.
13005         * objc-lang.c (info_selectors_command, info_classes_command)
13006         (find_methods): Update.
13007         * minsyms.c (find_solib_trampoline_target): Update.
13008         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13009         * coffread.c (coff_symfile_read): Update.
13010         * ada-lang.c (ada_lookup_simple_minsym)
13011         (ada_collect_symbol_completion_matches): Update.
13012
13013 2019-01-16  Tom Tromey  <tom@tromey.com>
13014
13015         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13016         type.  Remove no-argument constructor.
13017         <iterator::operator++>: Simplify.
13018         <begin>: Update.
13019         <end>: Use minimal_symbol_count.
13020
13021 2019-01-16  Tom Tromey  <tom@tromey.com>
13022
13023         * objfiles.h (struct objfile) <psymtabs>: New method.
13024         (class objfile_psymtabs): Remove.
13025         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13026         typedef.
13027         <range>: New method.
13028         (require_partial_symbols): Change return type.
13029         * psymtab.c (require_partial_symbols)
13030         (psym_expand_symtabs_matching): Update.
13031         * mdebugread.c (parse_partial_symbols): Update.
13032         * dbxread.c (dbx_end_psymtab): Update.
13033
13034 2019-01-15  Tom Tromey  <tom@tromey.com>
13035
13036         * symtab.c (lookup_objfile_from_block)
13037         (lookup_symbol_in_objfile_symtabs)
13038         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13039         (find_line_symtab, info_sources_command)
13040         (default_collect_symbol_completion_matches_break_on)
13041         (make_source_files_completion_list): Update.
13042         * symmisc.c (print_objfile_statistics, dump_objfile)
13043         (maintenance_print_symbols, maintenance_info_symtabs)
13044         (maintenance_check_symtabs, maintenance_info_line_tables):
13045         Update.
13046         * source.c (select_source_symtab)
13047         (forget_cached_source_info_for_objfile): Update.
13048         * objfiles.h (class objfile_compunits): Remove.
13049         (struct objfile) <compunits_range>: New typedef.
13050         (compunits): New method.
13051         * objfiles.c (objfile_relocate1): Update.
13052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13053         * maint.c (count_symtabs_and_blocks): Update.
13054         * linespec.c (iterate_over_all_matching_symtabs): Update.
13055         * cp-support.c (add_symbol_overload_list_qualified): Update.
13056         * coffread.c (coff_symtab_read): Update.
13057         * ada-lang.c (add_nonlocal_symbols)
13058         (ada_collect_symbol_completion_matches)
13059         (ada_add_global_exceptions): Update.
13060
13061 2019-01-15  Tom Tromey  <tom@tromey.com>
13062
13063         * progspace.h (program_space) <objfiles_safe_range>: New
13064         typedef.
13065         <objfiles_safe>: New method.
13066         * objfiles.h (class all_objfiles_safe): Remove.
13067         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13068         * jit.c (jit_inferior_exit_hook): Update.
13069
13070 2019-01-17  Tom Tromey  <tom@tromey.com>
13071
13072         * progspace.h (program_space) <objfiles_range>: New typedef.
13073         <objfiles>: New method.
13074         <objfiles_head>: Rename from objfiles.
13075         (object_files): Update.
13076         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13077         * guile/scm-pretty-print.c
13078         (ppscm_find_pretty_printer_from_objfiles): Update.
13079         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13080         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13081         Update.
13082         * python/py-progspace.c (pspy_get_objfiles): Update.
13083         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13084         Update.
13085         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13086         (objfpy_lookup_objfile_by_build_id): Update.
13087         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13088         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13089         Update.
13090         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13091         (expand_symtab_containing_pc, lookup_objfile_from_block)
13092         (lookup_static_symbol, basic_lookup_transparent_type)
13093         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13094         (find_line_symtab, info_sources_command)
13095         (default_collect_symbol_completion_matches_break_on)
13096         (make_source_files_completion_list, find_main_name): Update.
13097         * symmisc.c (print_symbol_bcache_statistics)
13098         (print_objfile_statistics, maintenance_print_symbols)
13099         (maintenance_print_msymbols, maintenance_print_objfiles)
13100         (maintenance_info_symtabs, maintenance_check_symtabs)
13101         (maintenance_expand_symtabs, maintenance_info_line_tables):
13102         Update.
13103         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13104         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13105         (map_overlay_command, unmap_overlay_command)
13106         (simple_overlay_update, expand_symtabs_matching)
13107         (map_symbol_filenames): Update.
13108         * symfile-debug.c (set_debug_symfile): Update.
13109         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13110         Update.
13111         * source.c (select_source_symtab, forget_cached_source_info):
13112         Update.
13113         * solib.c (solib_read_symbols): Update.
13114         * solib-spu.c (append_ocl_sos): Update.
13115         * psymtab.c (maintenance_print_psymbols)
13116         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13117         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13118         * printcmd.c (info_symbol_command): Update.
13119         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13120         Update.
13121         * objfiles.h (class all_objfiles): Remove.
13122         * objfiles.c (have_partial_symbols, have_full_symbols)
13123         (have_minimal_symbols, qsort_cmp, update_section_map)
13124         (shared_objfile_contains_address_p)
13125         (default_iterate_over_objfiles_in_search_order): Update.
13126         * objc-lang.c (info_selectors_command, info_classes_command)
13127         (find_methods): Update.
13128         * minsyms.c (find_solib_trampoline_target): Update.
13129         * maint.c (maintenance_info_sections)
13130         (maintenance_translate_address, count_symtabs_and_blocks):
13131         Update.
13132         * main.c (captured_main_1): Update.
13133         * linux-thread-db.c (try_thread_db_load_from_pdir)
13134         (has_libpthread): Update.
13135         * linespec.c (iterate_over_all_matching_symtabs)
13136         (search_minsyms_for_name): Update.
13137         * jit.c (jit_find_objf_with_entry_addr): Update.
13138         * hppa-tdep.c (find_unwind_entry)
13139         (hppa_lookup_stub_minimal_symbol): Update.
13140         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13141         Update.
13142         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13143         (elf_gnu_ifunc_resolve_by_got): Update.
13144         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13145         * dwarf-index-write.c (save_gdb_index_command): Update.
13146         * cp-support.c (add_symbol_overload_list_qualified): Update.
13147         * breakpoint.c (create_overlay_event_breakpoint)
13148         (create_longjmp_master_breakpoint)
13149         (create_std_terminate_master_breakpoint)
13150         (create_exception_master_breakpoint): Update.
13151         * blockframe.c (find_pc_partial_function): Update.
13152         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13153         (ada_collect_symbol_completion_matches)
13154         (ada_add_global_exceptions): Update.
13155
13156 2019-01-17  Tom Tromey  <tom@tromey.com>
13157
13158         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13159         declare VEC.
13160         (solib_target_parse_libraries): Change return type.
13161         (library_list_start_segment, library_list_start_section)
13162         (library_list_end_library, library_list_start_library); Update.
13163         (solib_target_free_library_list): Remove.
13164         (solib_target_parse_libraries): Remove cleanup.  Change return
13165         type.
13166         (solib_target_current_sos): Update.
13167
13168 2019-01-17  Tom Tromey  <tromey@bapiya>
13169
13170         * valprint.c: Replace "the the" with "the".
13171         * symtab.c: Replace "the the" with "the".
13172         * solib.c: Replace "the the" with "the".
13173         * solib-dsbt.c: Replace "the the" with "the".
13174         * linespec.c: Replace "the the" with "the".
13175         * dwarf2loc.h: Replace "the the" with "the".
13176         * amd64-windows-tdep.c: Replace "the the" with "the".
13177         * aarch64-tdep.c: Replace "the the" with "the".
13178
13179 2019-01-16  Keith Seitz  <keiths@redhat.com>
13180
13181         PR gdb/23773
13182         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13183         <builder>: Rename to ..
13184         <m_builder>: ... this and make private.
13185         (dwarf2_cu::get_builder): New method.  Change all users of
13186         `builder' to use this method.
13187         (dwarf2_start_symtab): Move to ...
13188         (dwarf2_cu::start_symtab): ... here.  Update all callers
13189         (setup_type_unit_groups): Move to ...
13190         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13191         callers.
13192         (dwarf2_cu::reset_builder): New method.
13193         (process_full_compunit, process_full_type_unit): Use
13194         dwarf2_cu::reset_builder.
13195         (follow_die_offset): Record the ancestor CU if it is different
13196         from the followed DIE's CU.
13197         (follow_die_sig_1): Likewise.
13198
13199 2019-01-15  Tom Tromey  <tom@tromey.com>
13200
13201         * remote.c (class remote_state) <buf>: Now a char_vector.
13202         <buf_size>: Remove.
13203         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13204         parameter.
13205         (remote_target::getpkt_or_notif_sane_1)
13206         (remote_target::getpkt_sane)
13207         (remote_target::getpkt_or_notif_sane): Likewise.
13208         (class remote_target) <putpkt>: New overload.
13209         (remote_target::read_frame): Change type of "buf_p".  Remove
13210         sizeof_p parameter.
13211         (packet_ok): New overload.
13212         (packet_check_result): New overload.
13213         Update all uses.
13214
13215 2019-01-14  Tom Tromey  <tom@tromey.com>
13216
13217         * remote-notif.c (handle_notification, remote_notif_ack)
13218         (remote_notif_parse): Make "buf" const.
13219         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13220         const.
13221         (remote_notif_parse, remote_notif_ack, handle_notification):
13222         Likewise.
13223         * remote.c (remote_notif_stop_parse): Make "buf" const.
13224         (remote_target::remote_parse_stop_reply): Make "buf" const.
13225         (remote_notif_stop_ack): Make "buf" const.
13226
13227 2019-01-14  Tom Tromey  <tom@tromey.com>
13228
13229         * remote.c (remote_console_output): Make parameter const.
13230
13231 2019-01-14  Tom Tromey  <tom@tromey.com>
13232
13233         * target-debug.h (target_debug_print_signals): Constify.
13234         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13235         * procfs.c (procfs_target::pass_signals): Update.
13236         * linux-nat.c (linux_nat_target::pass_signals): Update.
13237         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13238         * target-delegates.c: Rebuild.
13239         * remote.c (remote_target::program_signals): Update.
13240         (remote_target::pass_signals): Update.
13241         * target.c (target_pass_signals): Constify argument.
13242         (target_program_signals): Likewise.
13243         * target.h (struct target_ops) <pass_signals, program_signals>:
13244         Constify argument.
13245         (target_pass_signals, target_program_signals): Constify argument.
13246
13247 2019-01-14  Tom Tromey  <tom@tromey.com>
13248
13249         PR tui/28819:
13250         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13251
13252 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13253
13254         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13255         field.
13256         * rs6000-tdep.c: Include reggroups.h.
13257         (IS_V_ALIAS_PSEUDOREG): Define.
13258         (rs6000_register_name): Return names for the "vX" aliases.
13259         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13260         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13261         aliases.  Call default_register_reggroup_p for all other
13262         pseudo-registers.
13263         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13264         New functions.
13265         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13266         Handle "vX" aliases.
13267         (v_alias_pseudo_register_collect): New function.
13268         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13269         (rs6000_gdbarch_init): Initialize "vX" aliases as
13270         pseudo-registers.  Restore registration of
13271         rs6000_pseudo_register_reggroup_p with
13272         set_tdesc_pseudo_register_reggroup_p.
13273
13274 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13275
13276         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13277         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13278         set_gdbarch_num_pseudo_regs.
13279
13280 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13281
13282         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13283         Remove arg prefixname, add do_set and do_show.
13284         Add member functions set_list and show_list.
13285         * cli/cli-style.c (class cli_style_option): Update accordingly.
13286         (style_set_list): Move to file scope.
13287         (style_show_list): Likewise.
13288         (set_style): Call help_list.
13289         (show_style): Call cmd_show_list.
13290         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13291         Update to use the new macro.
13292
13293 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13294
13295         * ada-lang.c (_initialize_ada_language): Expand the help text
13296         for the "catch exception" command.
13297
13298 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13299
13300         * symtab.c (matching_obj_sections): Initialize obj,
13301         declare it closer to its usage.
13302
13303 2019-01-10  Tom Tromey  <tom@tromey.com>
13304
13305         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13306         (basic_inf_threads_range): Remove.
13307         (inf_threads_range, inf_non_exited_threads_range)
13308         (safe_inf_threads_range): Use next_adapter.
13309
13310 2019-01-10  Keith Seitz  <keiths@redhat.com>
13311
13312         PR gdb/23712
13313         PR symtab/23010
13314         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13315         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13316
13317 2019-01-10  Keith Seitz  <keiths@redhat.com>
13318
13319         PR gdb/23712
13320         PR symtab/23010
13321         * dictionary.c (pending_to_vector): Remove.
13322         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13323         Remove _1 suffix, replacing functions of the same name.  Update
13324         all callers.
13325         (dict_create_hashed, dict_create_hashed_expandable)
13326         (dict_create_linear, dict_create_linear_expandable, dict_free)
13327         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13328         Make functions static.
13329
13330 2019-01-10  Keith Seitz  <keiths@redhat.com>
13331
13332         PR gdb/23712
13333         PR symtab/23010
13334         * dictionary.h (struct dictionary): Replace declaration with
13335         multidictionary.
13336         (dict_create_hashed, dict_create_hashed_expandable)
13337         (dict_create_linear, dict_create_linear_expandable)
13338         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13339         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13340         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13341         taking multidictionary argument.
13342         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13343         * block.h (struct block) <dict>: Change to multidictionary
13344         and rename `multidict'.
13345         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13346         symmisc.c: Update all dictionary references to multidictionary.
13347
13348 2019-01-10  Keith Seitz  <keiths@redhat.com>
13349
13350         PR gdb/23712
13351         PR symtab/23010
13352         * dictionary.c: Include unordered_map.
13353         (pending_to_vector): New function.
13354         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13355         Rewrite the non-"_1" functions to take vector instead
13356         of linked list.
13357         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13358         "new" _1 versions of the same name.
13359         (multidictionary): Define.
13360         (std::hash<enum language): New definition.
13361         (collate_pending_symbols_by_language, mdict_create_hashed)
13362         (mdict_create_hashed_expandable, mdict_create_linear)
13363         (mdict_create_linear_expandable, mdict_free)
13364         (find_language_dictionary, create_new_language_dictionary)
13365         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13366         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13367         (mdict_size, mdict_empty): New functions.
13368         * dictionary.h (mdict_iterator): Define.
13369
13370 2019-01-10  Pedro Alves  <palves@redhat.com>
13371
13372         * breakpoint.c (read_uploaded_action)
13373         (create_tracepoint_from_upload): Adjust to use
13374         gdb::unique_xmalloc_ptr.
13375         * ctf.c (ctf_write_uploaded_tp):
13376         (SET_ARRAY_FIELD): Use emplace_back.
13377         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13378         * tracefile-tfile.c (tfile_write_uploaded_tp):
13379         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13380         gdb::unique_xmalloc_ptr.
13381         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13382         at_string, cond_string, cmd_strings>: Replace char pointers
13383         with gdb::unique_xmalloc_ptr.
13384
13385 2019-01-10  Pedro Alves  <palves@redhat.com>
13386
13387         * solib-target.c (library_list_start_library): Don't xstrdup name.
13388
13389 2019-01-10  Pedro Alves  <palves@redhat.com>
13390
13391         * mdebugread.c (parse_partial_symbols): Use
13392         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13393
13394 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13395
13396         * linux-fork.c (scoped_switch_fork_info)
13397         <~scoped_switch_fork_info>: Fix incorrect variable name.
13398
13399 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13400
13401         * linux-fork.c (scoped_switch_fork_info)
13402         <scoped_switch_fork_info>: Make explicit.
13403         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13404
13405 2019-01-10  Tom Tromey  <tom@tromey.com>
13406
13407         * objfiles.h (objfile::reset_psymtabs): Update.
13408         * objfiles.c (objfile::objfile): Update.
13409         * psymtab.h (psymtab_storage::obstack): Update.
13410         (psymtab_storage::m_obstack): Use gdb::optional.
13411         (class psymtab_storage): Update comment.  Remove objfile
13412         parameter.
13413         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13414
13415 2019-01-10  Tom Tromey  <tom@tromey.com>
13416
13417         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13418         <free_psymtabs>: Now private.
13419         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13420         (allocate_psymtab): Use new method.
13421
13422 2019-01-10  Tom Tromey  <tom@tromey.com>
13423
13424         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13425         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13426         * mdebugread.c (parse_partial_symbols): Use
13427         allocate_dependencies.
13428         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13429         allocate_dependencies.
13430         (process_psymtab_comp_unit_reader)
13431         (build_type_psymtab_dependencies): Likewise.
13432         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13433
13434 2019-01-10  Tom Tromey  <tom@tromey.com>
13435
13436         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13437         PSYMBOL_SET_LANGUAGE.
13438         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13439
13440 2019-01-10  Tom Tromey  <tom@tromey.com>
13441
13442         * psymtab.h (psymtab_storage::obstack): New method.
13443         <m_obstack>: Rename from obstack; now private.
13444         * psymtab.c (psymtab_storage): Update.
13445         * dwarf2read.c (create_addrmap_from_index)
13446         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13447         Update.
13448
13449 2019-01-10  Tom Tromey  <tom@tromey.com>
13450
13451         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13452         * objfiles.h (objfile::reset_psymtabs): New method.
13453
13454 2019-01-10  Tom Tromey  <tom@tromey.com>
13455
13456         * symmisc.c (print_symbol_bcache_statistics): Update.
13457         (print_objfile_statistics): Update.
13458         * symfile.c (reread_symbols): Update.
13459         * psymtab.h (class psymtab_storage): New.
13460         * psymtab.c (psymtab_storage): New constructor.
13461         (~psymtab_storage): New destructor.
13462         (require_partial_symbols): Update.
13463         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13464         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13465         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13466         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13467         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13468         (start_psymtab_common, end_psymtab_common)
13469         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13470         (allocate_psymtab): Update.
13471         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13472         Update.
13473         (dump_psymtab_addrmap, maintenance_print_psymbols)
13474         (maintenance_check_psymtabs): Update.
13475         (class objfile_psymtabs): Move to objfiles.h.
13476         * psympriv.h (discard_psymtab): Now inline.
13477         (psymtab_discarder::psymtab_discarder): Update.
13478         (psymtab_discarder::~psymtab_discarder): Update.
13479         (ALL_OBJFILE_PSYMTABS): Rewrite.
13480         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13481         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13482         Remove fields.
13483         <partial_symtabs>: New field.
13484         (class objfile_psymtabs): Move from psymtab.h.  Update.
13485         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13486         psymbol_cache.
13487         (objfile::~objfile): Don't destroy psymbol_cache.
13488         * mdebugread.c (parse_partial_symbols): Update.
13489         * dwarf2read.c (create_addrmap_from_index)
13490         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13491         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13492         (add_partial_subprogram, dwarf2_ranges_read): Update.
13493         * dwarf-index-write.c (write_address_map)
13494         (write_one_signatured_type, recursively_write_psymbols)
13495         (class debug_names, class debug_names, write_psymtabs_to_index):
13496         Update.
13497
13498 2019-01-10  Tom Tromey  <tom@tromey.com>
13499
13500         * symtab.h (SYMBOL_SET_NAMES): Update.
13501         (symbol_set_names): Update.
13502         (MSYMBOL_SET_NAMES): Update.
13503         * symtab.c (symbol_set_names): Change argument to be an
13504         objfile_per_bfd_storage.
13505         * psymtab.c (add_psymbol_to_bcache): Update.
13506         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13507
13508 2019-01-10  Tom Tromey  <tom@tromey.com>
13509
13510         * symtab.c (create_demangled_names_hash): Change argument to be an
13511         objfile_per_bfd_storage.
13512         (symbol_set_names): Update.
13513
13514 2019-01-10  Tom Tromey  <tom@tromey.com>
13515
13516         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13517         init_psymbol_list.
13518         * psymtab.c (init_psymbol_list): Do nothing if already called.
13519         * psympriv.h (init_psymbol_list): Add comment.
13520         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13521         init_psymbol_list.
13522         * dbxread.c (dbx_symfile_read): Unconditionally call
13523         init_psymbol_list.
13524
13525 2019-01-10  Tom Tromey  <tom@tromey.com>
13526
13527         * xcoffread.c (scan_xcoff_symtab): Update.
13528         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13529         "where".
13530         * mdebugread.c (parse_partial_symbols)
13531         (handle_psymbol_enumerators): Update.
13532         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13533         * dbxread.c (read_dbx_symtab): Update.
13534         * psympriv.h (psymbol_placement): New enum.
13535         (add_psymbol_to_list): Update.
13536
13537 2019-01-10  Tom Tromey  <tom@tromey.com>
13538
13539         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13540         static_psymbols parameters.
13541         (scan_xcoff_symtab): Update.
13542         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13543         static_psymbols parameters.
13544         * psympriv.h (start_psymtab_common): Update.
13545         * mdebugread.c (parse_partial_symbols): Update.
13546         * dwarf2read.c (create_partial_symtab): Update.
13547         * dbxread.c (read_dbx_symtab): Update.
13548         (start_psymtab): Remove global_psymbols and static_psymbols
13549         parameters.
13550
13551 2019-01-10  Tom Tromey  <tom@tromey.com>
13552
13553         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13554         * psymtab.c (allocate_psymtab): Add comment.
13555         * psympriv.h (allocate_psymtab): Add comment.
13556         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13557         initializations.
13558         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13559
13560 2019-01-10  Tom Tromey  <tom@tromey.com>
13561
13562         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13563         Don't declare.
13564         * mipsread.c: Include mdebugread.h.
13565         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13566         Declare.
13567         * elfread.c: Include mdebugread.h.
13568
13569 2019-01-09  Tom Tromey  <tom@tromey.com>
13570
13571         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13572         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13573         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13574         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13575         (psym_lookup_symbol, psym_find_last_source_symtab)
13576         (psym_forget_cached_source_info, psym_print_stats)
13577         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13578         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13579         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13580         (psym_find_compunit_symtab_by_address)
13581         (maintenance_print_psymbols, maintenance_info_psymtabs)
13582         (maintenance_check_psymtabs): Use ranged for.
13583         * psymtab.h (class objfile_psymtabs): New.
13584         (require_partial_symbols): Return objfile_psymtabs.
13585         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13586
13587 2019-01-09  Tom Tromey  <tom@tromey.com>
13588
13589         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13590         (find_pc_mapped_section, list_overlays_command)
13591         (map_overlay_command, unmap_overlay_command)
13592         (simple_overlay_update): Use all_objfiles.
13593         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13594         * printcmd.c (info_symbol_command): Use all_objfiles.
13595         * objfiles.h (ALL_OBJSECTIONS): Remove.
13596         * maint.c (maintenance_translate_address): Use all_objfiles.
13597         * gcore.c (gcore_create_callback): Use all_objfiles.
13598         (objfile_find_memory_regions): Likewise.
13599
13600 2019-01-09  Tom Tromey  <tom@tromey.com>
13601
13602         * symtab.c (find_line_symtab, info_sources_command)
13603         (make_source_files_completion_list): Use objfile_compunits.
13604         * source.c (select_source_symtab): Use objfile_compunits.
13605         * objfiles.h (struct objfile): Update comment.
13606         (ALL_OBJFILES): Remove.
13607         (ALL_FILETABS): Remove.
13608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13609         objfile_compunits.
13610
13611 2019-01-09  Tom Tromey  <tom@tromey.com>
13612
13613         * symmisc.c (print_objfile_statistics, dump_objfile)
13614         (maintenance_print_symbols): Use compunit_filetabs.
13615         * source.c (forget_cached_source_info_for_objfile): Use
13616         compunit_filetabs.
13617         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13618         (ALL_FILETABS): Use compunit_filetabs.
13619         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13620         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13621
13622 2019-01-09  Tom Tromey  <tom@tromey.com>
13623
13624         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13625         (compunit_filetabs): New.
13626         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13627         compunit_filetabs.
13628         (info_sources_command, make_source_files_completion_list): Remove
13629         declaration.
13630         * symmisc.c (print_objfile_statistics, dump_objfile)
13631         (maintenance_print_symbols): Remove declaration.
13632         (maintenance_info_symtabs): Use compunit_filetabs.
13633         (maintenance_info_line_tables): Likewise.
13634         * source.c (select_source_symtab): Change local variable name.
13635         (forget_cached_source_info_for_objfile): Remove declaration.
13636         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13637         * objfiles.c (objfile_relocate1): Remove declaration.
13638         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13639         declaration.
13640         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13641         * coffread.c (coff_symtab_read): Remove declaration.
13642         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13643         compunit_filetabs.
13644
13645 2019-01-09  Tom Tromey  <tom@tromey.com>
13646
13647         * symtab.c (lookup_objfile_from_block)
13648         (find_pc_sect_compunit_symtab, search_symbols)
13649         (default_collect_symbol_completion_matches_break_on): Use
13650         objfile_compunits.
13651         * objfiles.h (ALL_COMPUNITS): Remove.
13652         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13653         * cp-support.c (add_symbol_overload_list_qualified): Use
13654         objfile_compunits.
13655         * ada-lang.c (ada_collect_symbol_completion_matches)
13656         (ada_add_global_exceptions): Use objfile_compunits.
13657
13658 2019-01-09  Tom Tromey  <tom@tromey.com>
13659
13660         * source.c (select_source_symtab)
13661         (forget_cached_source_info_for_objfile): Remove declaration.
13662         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13663         declaration.
13664         * maint.c (count_symtabs_and_blocks): Remove declaration.
13665         * cp-support.c (add_symbol_overload_list_qualified): Remove
13666         declaration.
13667         * coffread.c (coff_symtab_read): Remove declaration.
13668         * symtab.c (lookup_symbol_in_objfile_symtabs)
13669         (basic_lookup_transparent_type_1): Use objfile_compunits.
13670         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13671         (info_sources_command, search_symbols)
13672         (default_collect_symbol_completion_matches_break_on)
13673         (make_source_files_completion_list): Remove declaration.
13674         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13675         (ada_collect_symbol_completion_matches)
13676         (ada_add_global_exceptions): Remove declaration.
13677         * linespec.c (iterate_over_all_matching_symtabs): Use
13678         objfile_compunits.
13679         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13680         (class objfile_compunits): New.
13681         (ALL_COMPUNITS): Use objfile_compunits.
13682         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13683         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13684         objfile_compunits.
13685         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13686
13687 2019-01-09  Tom Tromey  <tom@tromey.com>
13688
13689         * symtab.c (search_symbols)
13690         (default_collect_symbol_completion_matches_break_on): Use
13691         objfile_msymbols.
13692         * ada-lang.c (ada_lookup_simple_minsym)
13693         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13694         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13695         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13696         objfile_msymbols.
13697         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13698         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13699         * objc-lang.c (find_methods): Use objfile_msymbols.
13700         (info_selectors_command, info_classes_command): Likewise.
13701         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13702         * objfiles.h (class objfile_msymbols): New.
13703         (ALL_OBJFILE_MSYMBOLS): Remove.
13704         (ALL_MSYMBOLS): Remove.
13705
13706 2019-01-09  Tom Tromey  <tom@tromey.com>
13707
13708         * common/next-iterator.h (next_adapter): Add Iterator template
13709         parameter.
13710         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13711         (class all_objfiles_safe): New.
13712         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13713         * objfiles.c (put_objfile_before): Update comment.
13714         (add_separate_debug_objfile): Likewise.
13715         (free_all_objfiles): Use all_objfiles_safe.
13716         (objfile_purge_solibs): Likewise.
13717
13718 2019-01-09  Tom Tromey  <tom@tromey.com>
13719
13720         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13721         (expand_symtab_containing_pc, lookup_static_symbol)
13722         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13723         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13724         all_objfiles.
13725         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13726         * breakpoint.c (create_overlay_event_breakpoint)
13727         (create_longjmp_master_breakpoint)
13728         (create_std_terminate_master_breakpoint)
13729         (create_exception_master_breakpoint): Use all_objfiles.
13730         * linux-thread-db.c (try_thread_db_load_from_pdir)
13731         (has_libpthread): Use all_objfiles.
13732         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13733         * linespec.c (iterate_over_all_matching_symtabs)
13734         (search_minsyms_for_name): Use all_objfiles.
13735         * maint.c (maintenance_info_sections): Use all_objfiles.
13736         * main.c (captured_main_1): Use all_objfiles.
13737         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13738         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13739         * guile/scm-pretty-print.c
13740         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13741         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13742         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13743         (maintenance_print_msymbols): Use all_objfiles.
13744         * source.c (select_source_symtab): Use all_objfiles.
13745         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13746         * symfile.c (remove_symbol_file_command)
13747         (expand_symtabs_matching, map_symbol_filenames): Use
13748         all_objfiles.
13749         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13750         all_objfiles.
13751         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13752         * objc-lang.c (find_methods): Use all_objfiles.
13753         * objfiles.c (have_partial_symbols, have_full_symbols)
13754         (have_minimal_symbols, qsort_cmp)
13755         (default_iterate_over_objfiles_in_search_order): Use
13756         all_objfiles.
13757         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13758         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13759         (maintenance_check_psymtabs): Use all_objfiles.
13760         (ALL_PSYMTABS): Remove.
13761         * compile/compile-object-run.c (do_module_cleanup): Use
13762         all_objfiles.
13763         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13764         * cp-support.c (add_symbol_overload_list_qualified): Use
13765         all_objfiles.
13766         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13767         Use all_objfiles.
13768         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13769         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13770         all_objfiles.
13771         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13772         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13773         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13774         Uses all_objfiles.
13775         * solib.c (solib_read_symbols): Use all_objfiles
13776
13777 2019-01-09  Tom Tromey  <tom@tromey.com>
13778
13779         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13780         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13781         all_objfiles.
13782         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13783         * symmisc.c (print_symbol_bcache_statistics)
13784         (print_objfile_statistics, maintenance_print_objfiles)
13785         (maintenance_info_symtabs, maintenance_check_symtabs)
13786         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13787         all_objfiles.
13788         * source.c (forget_cached_source_info): Use all_objfiles.
13789         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13790         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13791         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13792         * objfiles.c (update_section_map): Use all_objfiles.
13793         (shared_objfile_contains_address_p): Likewise.
13794         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13795         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13796
13797 2019-01-09  Tom Tromey  <tom@tromey.com>
13798
13799         * common/next-iterator.h: New file.
13800         * objfiles.h (class all_objfiles): New.
13801         (struct objfile_iterator): New.
13802
13803 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13804
13805         * NEWS: Move the description of the changed "frame", "select-frame",
13806          and "info frame" commands to the Changed commands section.
13807
13808 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13809
13810         * gdbtypes.c (check_stub_method_group): Remove handling of old
13811         mangling schemes.
13812         * linespec.c (find_methods): Likewise.
13813         * stabsread.c (read_member_functions): Likewise.
13814         * valops.c (search_struct_method): Likewise.
13815         (value_struct_elt_for_reference): Likewise.
13816         * NEWS: Mention this change.
13817
13818 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13819
13820         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13821         print_source_lines.
13822         * source.c (print_source_lines_base): Update line number check.
13823         (print_source_lines): New function.
13824         (source_lines_range::source_lines_range): New function.
13825         * source.h (class source_lines_range): New class.
13826         (print_source_lines): New declaration.
13827
13828 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13829
13830         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13831
13832 2019-01-08  Tom Tromey  <tom@tromey.com>
13833             Simon Marchi  <simon.marchi@ericsson.com>
13834
13835         PR gdb/24060
13836         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13837         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13838         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13839         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13840         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13841         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13842
13843 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13844
13845         * source.c (select_source_symtab): Move header comment to
13846         declaration in source.h.
13847         (forget_cached_source_info_for_objfile): Likewise.
13848         (forget_cached_source_info): Likewise.
13849         (identify_source_line): Likewise.
13850         * source.h (identify_source_line): Move declaration from symtab.h
13851         and add comment from source.c
13852         (print_source_lines): Likewise.
13853         (forget_cached_source_info_for_objfile): Likewise.
13854         (forget_cached_source_info): Likewise.
13855         (select_source_symtab): Likewise.
13856         (enum print_source_lines_flag): Move definition from symtab.h.
13857         * symtab.h (identify_source_line): Move declaration to source.h.
13858         (print_source_lines): Likewise.
13859         (forget_cached_source_info_for_objfile): Likewise.
13860         (forget_cached_source_info): Likewise.
13861         (select_source_symtab): Likewise.
13862         (enum print_source_lines_flag): Move definition to source.h.
13863         * tui/tui-hooks.c: Add 'source.h' include.
13864
13865 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13866
13867         * source.c (print_source_lines_base): Handle requests to print
13868         reverse line number sequences, and guard against empty lines
13869         string.
13870
13871 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13872
13873         * source.c (print_source_lines_base): Fix skip of '\r' if next
13874         character is '\n'.
13875
13876 2019-01-06  Tom Tromey  <tom@tromey.com>
13877
13878         * c-exp.y (struct c_parse_state) <macro_original_text,
13879         expansion_obstack>: New member.
13880         (macro_original_text, expansion_obstack): Remove globals.
13881         (scan_macro_expansion, scanning_macro_expansion)
13882         (finished_macro_expansion): Update.
13883         (scan_macro_cleanup): Remove.
13884         (yylex, c_parse): Update.
13885
13886 2019-01-06  Tom Tromey  <tom@tromey.com>
13887
13888         * c-exp.y (struct c_parse_state) <strings>: New member.
13889         (operator_stoken): Update.
13890
13891 2019-01-06  Tom Tromey  <tom@tromey.com>
13892
13893         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13894         (union type_stack_elt) <typelist_val>: Now a pointer to
13895         std::vector.
13896         (type_stack_cleanup): Don't declare.
13897         (push_typelist): Update.
13898         * parse.c (pop_typelist): Return a std::vector.
13899         (push_typelist): Take a std::vector.
13900         (follow_types): Update.  Do not free args.
13901         (type_stack_cleanup): Remove.
13902         * c-exp.y (struct c_parse_state): New.
13903         (cpstate): New global.
13904         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13905         (nonempty_typelist): Update.
13906         (func_mod): Create a new vector.
13907         (c_parse): Create a c_parse_state.
13908         (check_parameter_typelist): Do not delete params.
13909         (function_method): Update.  Do not delete type_list.
13910
13911 2019-01-06  Tom Tromey  <tom@tromey.com>
13912
13913         PR gdb/28155:
13914         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13915         check_typedef.
13916         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13917         (print_return_value): Likewise.
13918
13919 2019-01-05  Tom Tromey  <tom@tromey.com>
13920
13921         * contrib/cleanup_check.py: Remove.
13922         * contrib/gcc-with-excheck: Remove.
13923         * contrib/exsummary.py: Remove.
13924         * contrib/excheck.py: Remove.
13925
13926 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13927
13928         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13929         NULL. Initialize tpprev to NULL instead of assigning it
13930         to NULL on the next statement.
13931         * windows-nat.c (windows_delete_thread): Remove check for
13932         main_thread_id before printing thread exit notifications.
13933         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13934         Remove thread ID check against main_thread_id.
13935         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13936         windows_delete_thread.
13937         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13938
13939 2019-01-04  Tom Tromey  <tom@tromey.com>
13940
13941         * compile/compile.c (_initialize_compile): Use upper case for
13942         metasyntactic variables.
13943         * symmisc.c (_initialize_symmisc): Use upper case for
13944         metasyntactic variables.
13945         * psymtab.c (_initialize_psymtab): Use upper case for
13946         metasyntactic variables.
13947         * demangle.c (demangle_command): Use upper case for metasyntactic
13948         variables.
13949         (_initialize_demangler): Likewise.
13950         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13951         variables.
13952
13953 2019-01-03  Tom Tromey  <tom@tromey.com>
13954
13955         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13956
13957 2019-01-03  Tom Tromey  <tom@tromey.com>
13958
13959         * python/py-symtab.c (salpy_str): Update.
13960         (struct salpy_sal_object) <symtab>: Now a PyObject.
13961         (salpy_dealloc): Update.
13962         (del_objfile_sal): Use gdbpy_ref.
13963
13964 2019-01-03  Tom Tromey  <tom@tromey.com>
13965
13966         * python/py-type.c (convert_field): Use new_reference.  Return
13967         gdbpy_ref.
13968         (make_fielditem): Return gdbpy_ref.
13969         (typy_fields): Update.
13970         (typy_getitem): Update.
13971         (field_name): Return gdbpy_ref.  Use new_reference.
13972         (typy_iterator_iternext): Update.
13973
13974 2019-01-03  Tom Tromey  <tom@tromey.com>
13975
13976         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13977
13978 2019-01-03  Tom Tromey  <tom@tromey.com>
13979
13980         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13981         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13982         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13983         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13984         (pspy_set_type_printers): Likewise.
13985         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13986         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13987         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13988         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13989         (objfpy_set_type_printers): Likewise.
13990
13991 2019-01-03  Tom Tromey  <tom@tromey.com>
13992
13993         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13994         (gdbpy_print_stack): Use gdbpy_err_fetch.
13995         * python/python-internal.h (class gdbpy_err_fetch): New class.
13996         (class gdbpy_enter) <m_error_type, m_error_value,
13997         m_error_traceback>: Remove.
13998         <m_error>: New member.
13999         (gdbpy_exception_to_string): Don't declare.
14000         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14001         * python/py-value.c (convert_value_from_python): Use
14002         gdbpy_err_fetch.
14003         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14004         gdbpy_exception_to_string.
14005         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14006         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14007         gdbpy_err_fetch.
14008
14009 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14010
14011         * linux-nat.c (delete_lwp_cleanup): Delete.
14012         (struct lwp_deleter): New struct.
14013         (lwp_info_up): New typedef.
14014         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14015         lwp_info_up.
14016
14017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14018
14019         * linux-fork.c (class scoped_switch_fork_info): New class.
14020         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14021
14022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14023
14024         * valops.c (find_overload_match): Remove use of null_cleanup, and
14025         calls to do_cleanups.
14026
14027 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14028
14029         * compile/compile-cplus-types.c
14030         (compile_cplus_instance::decl_name): Handle changes to
14031         cp_func_name.
14032         * cp-support.c (cp_func_name): Update header comment, update
14033         return type.
14034         * cp-support.h (cp_func_name): Update return type in declaration.
14035         * valops.c (find_overload_match): Move temp_func local to top
14036         level of function and change its type.  Use temp_func to hold and
14037         delete temporary string obtained from cp_func_name.
14038
14039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14040
14041         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14042         gdb::char_vector, remove cleanup, and update uses of `msg`.
14043
14044 2019-01-03  Jim Wilson  <jimw@sifive.com>
14045
14046         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14047
14048 2019-01-02  Tom Tromey  <tom@tromey.com>
14049
14050         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14051         (tdesc_parse_xml): Remove cleanups.
14052         * target-descriptions.h (make_cleanup_free_target_description):
14053         Don't declare.
14054         (target_desc_deleter): New struct.
14055         (target_desc_up): New typedef.
14056         * target-descriptions.c (target_desc_deleter::operator()): Rename
14057         from free_target_description.
14058         (make_cleanup_free_target_description): Remove.
14059
14060 2019-01-02  Tom Tromey  <tom@tromey.com>
14061
14062         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14063         constructor, destructor.
14064         (linespec_parser): Remove typedef.
14065         (~linespec_parser): Rename from linespec_parser_delete.
14066         (linespec_lex_to_end, linespec_complete_label)
14067         (linespec_complete): Update.
14068         (decode_line_full): Remove cleanups.
14069         (decode_line_1): Update.
14070
14071 2019-01-02  Tom Tromey  <tom@tromey.com>
14072
14073         * python/python-internal.h (inferior_to_inferior_object): Change
14074         return type.
14075         * python/py-exitedevent.c (create_exited_event_object): Update.
14076         * python/py-inferior.c (inferior_to_inferior_object): Return
14077         gdbpy_ref.
14078         (python_new_inferior, python_inferior_deleted)
14079         (thread_to_thread_object, delete_thread_object)
14080         (build_inferior_list, gdbpy_selected_inferior): Update.
14081         * python/py-infthread.c (create_thread_object): Update.  Also fail
14082         if inferior_to_inferior_object fails.
14083
14084 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14085
14086         * inferior.h (class inferior) <displaced_step_state>: New field.
14087         * infrun.h (struct displaced_step_state): Move here from
14088         infrun.c.  Initialize fields, add constructor.
14089         <inf>: Remove field.
14090         <reset>: New method.
14091         * infrun.c (struct displaced_step_inferior_state): Move to
14092         infrun.h.
14093         (displaced_step_inferior_states): Remove.
14094         (get_displaced_stepping_state): Adust.
14095         (displaced_step_in_progress_any_inferior): Adjust.
14096         (displaced_step_in_progress_thread): Adjust.
14097         (displaced_step_in_progress): Adjust.
14098         (add_displaced_stepping_state): Remove.
14099         (get_displaced_step_closure_by_addr): Adjust.
14100         (remove_displaced_stepping_state): Remove.
14101         (infrun_inferior_exit): Call displaced_step_state.reset.
14102         (use_displaced_stepping): Don't check for NULL.
14103         (displaced_step_prepare_throw): Call
14104         get_displaced_stepping_state.
14105         (displaced_step_fixup): Don't check for NULL.
14106         (prepare_for_detach): Don't check for NULL.
14107
14108 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14109
14110         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14111          in case of call that did not complete.
14112
14113 2019-01-02  Andrey Utkin  <autkin@undo.io>
14114
14115         * symfile.c (find_separate_debug_file): Fix search of debug files for
14116         remote debuggee.
14117
14118 2019-01-02  Tom Tromey  <tom@tromey.com>
14119
14120         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14121         indentation.
14122         * python/py-frame.c (frapy_older): Remove cast.
14123         (frapy_newer): Likewise.
14124         * python/py-breakpoint.c (local_setattro): Remove cast.
14125         * python/py-arch.c (archpy_name): Remove local variable.
14126         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14127
14128 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14129
14130         * unittests/basic_string_view/element_access/char/empty.cc:
14131         Fix year range in copyright header.
14132
14133 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14134
14135         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14136         Delete.
14137         <operator==>: Update with for removed field.
14138         <hash>: Likewise.
14139         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14140         <isa_features>: ...this.
14141         <abi_features>: New field.
14142         (riscv_isa_flen): Update comment.
14143         (riscv_abi_xlen): New declaration.
14144         (riscv_abi_flen): New declaration.
14145         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14146         isa_features.
14147         (riscv_abi_xlen): New function.
14148         (riscv_isa_flen): Update to get answer from isa_features.
14149         (riscv_abi_flen): New function.
14150         (riscv_has_fp_abi): Update to get answer from abi_features.
14151         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14152         xlen and flen.
14153         (riscv_call_info) <xlen, flen>: Update comment.
14154         (riscv_call_arg_struct): Remove invalid assertions
14155         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14156         is removed.
14157         (riscv_gdbarch_init): Gather isa features and abi features
14158         separately, ensure both match on the gdbarch when reusing an old
14159         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14160         a target with 64-bit float hardware.
14161
14162 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14163
14164         * source.c (search_command_helper): Stop reverse search
14165         when line 1 has been searched.
14166
14167 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14168
14169         * record-full.c (record_full_base_target::close): Rewrite
14170         record_full_core_buf_list free logic.
14171
14172 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14173
14174         * break-catch-syscall.c (print_one_catch_syscall): xfree
14175         the last text.
14176
14177 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14178
14179         * top.c (print_gdb_version): Update Copyright year in version
14180         message.
14181
14182 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14183
14184         Update copyright year range in all GDB files.
14185
14186 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14187
14188         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14189
14190 For older changes see ChangeLog-2018.
14191 \f
14192 Local Variables:
14193 mode: change-log
14194 left-margin: 8
14195 fill-column: 74
14196 version-control: never
14197 coding: utf-8
14198 End:
14199