gdb/ChangeLog

   1 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
   2
   3         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
   4         target descriptions using exclusively floating point register name
   5         aliases.
   6
   7 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         PR gdb/18644:
  10         * f-lang.c (build_fortran_types): Handle the case where
  11         gdbarch_floatformat_for_type returns a nullptr.
  12
  13 2019-05-21  Tom de Vries  <tdevries@suse.de>
  14
  15         PR cli/24587
  16         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  17
  18 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         PR gdb/18644:
  21         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  22         16-byte floats.
  23         * i386-tdep.c (i386_floatformat_for_type): Use
  24         floatformats_ia64_quad for the 16-byte floating point component
  25         within a fortran 32-byte complex number.
  26
  27 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  30         delete default constructor.
  31         (find_partial_die): Update to return const struct.
  32         (partial_die_parent_scope): Move variable declaration into scope
  33         of its use and change its type to auto.
  34         (guess_partial_die_structure_name): Likewise.
  35         (partial_die_info::fixup): Likewise.
  36
  37 2019-05-17  Tom Tromey  <tromey@adacore.com>
  38
  39         * source.c (find_and_open_source): Remove cast.
  40
  41 2019-05-17  Tom Tromey  <tromey@adacore.com>
  42
  43         * annotate.c (annotate_source): Make "filename" const.
  44         * annotate.h (annotate_source): Use const.
  45
  46 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * disasm.c (set_disassembler_options): Send errors to stderr.
  49
  50 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  53         (cli_interp_base::set_logging): Check debug_redirect.
  54         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  55         * cli/cli-logging.c (debug_redirect): Add static variable.
  56         (pop_output_files): Add default param.
  57         (handle_redirections): Print debug setting.
  58         (show_logging_command): Likewise.
  59         (_initialize_cli_logging): Add debugredirect command.
  60         * interps.c (current_interp_set_logging): Add debug_redirect
  61         parameter.
  62         * interps.h (set_logging): Add debug_redirect parameter.
  63         (current_interp_set_logging): Likewise.
  64         * mi/mi-common.h: Likewise.
  65         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  66
  67 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  68             Tom Tromey  <tromey@adacore.com>
  69
  70         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  71         directly.
  72         * cli/cli-interp.h (make_logging_output): Remove declaration.
  73         * cli/cli-logging.c (make_logging_output): Remove function.
  74         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  75         directly.
  76         * ui-file.c (tee_file::tee_file): Remove bools.
  77         (tee_file::~tee_file): Remove deletes.
  78         * ui-file.h (tee_file): Remove bools.
  79
  80 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  81
  82         * mi/mi-cmds.h (mi_cmd_complete): New function.
  83         * mi/mi-main.c (mi_cmd_complete): Likewise.
  84         * mi/mi-cmds.c: Define new MI command -complete.
  85         * NEWS: Mention new -complete command.
  86
  87 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  88
  89         * completer.h (complete): New function.
  90         * completer.c (complete): Likewise.
  91         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  92         function defined in completer.h.
  93
  94 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  95
  96        * MAINTAINERS (Write After Approval): Add myself.
  97
  98 2019-05-17  Tom de Vries  <tdevries@suse.de>
  99
 100         PR gdb/24094
 101         * dwarf2read.c (struct cu_partial_die_info): New struct.
 102         (find_partial_die): Return cu_partial_die_info.
 103         (partial_die_parent_scope, guess_partial_die_structure_name)
 104         (partial_die_info::fixup): Handle new return type of find_partial_die.
 105
 106 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 107
 108         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 109         "std::string", simplifying the algorithm.
 110
 111 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 112
 113         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 114         (stap_static_probe_ops::get_probes): Likewise.
 115
 116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 117
 118         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 119         '-')" and "else if".
 120         (stap_parse_single_operand): Join checks for
 121         "gdbarch_stap_parse_special_token_p" and
 122         "gdbarch_stap_parse_special_token" in the same "if" statement.
 123         Invert check when verifying for operation on register
 124         displacement.
 125
 126 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 127
 128         * stap-probe.c (stap_get_opcode): Update comment.
 129         (stap_get_expected_argument_type): Likewise.
 130         (handle_stap_probe): Likewise.
 131
 132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 133
 134         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 135         return type to 'bool'.  Adjust comment.  Use 'bool' when
 136         appropriate.
 137         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 138         * stap-probe.c (stap_parse_argument_1): Likewise.
 139         (stap_is_operator): Likewise.
 140         (stap_is_generic_prefix): Likewise.
 141         (stap_is_register_prefix): Likewise.
 142         (stap_is_register_indirection_prefix): Likewise.
 143         (stap_is_integer_prefix): Likewise.
 144         (stap_generic_check_suffix): Likewise.
 145         (stap_check_integer_suffix): Likewise.
 146         (stap_check_register_suffix): Likewise.
 147         (stap_check_register_indirection_suffix): Likewise.
 148         (stap_parse_register_operand): Likewise.
 149         (stap_parse_single_operand): Likewise.
 150         (stap_parse_argument_1): Likewise.
 151         (stap_probe::get_argument_count): Likewise.
 152         (stap_is_operator): Likewise.
 153
 154 2019-05-16  Tom Tromey  <tromey@adacore.com>
 155
 156         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 157         keyword to foreach.
 158
 159 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 160
 161         * linux-thread-db.c (try_thread_db_load_1): Change return type
 162         to bool.
 163         (try_thread_db_load): Likewise.
 164         (try_thread_db_load_from_pdir_1): Likewise.
 165         (try_thread_db_load_from_pdir): Likewise.
 166         (try_thread_db_load_from_sdir): Likewise.
 167         (try_thread_db_load_from_dir): Likewise.
 168         (thread_db_load_search): Likewise.
 169         (has_libpthread): Likewise.
 170         (thread_db_load): Likewise.
 171
 172 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 173
 174         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 175         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 176         NULL, and complain/return if that's the case.
 177
 178 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 179
 180         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 181         (advance, posn, abstract_read_memory): New functions.
 182         [struct mem_read_abstraction]: New struct.
 183         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 184
 185 2019-05-14  Tom Tromey  <tromey@adacore.com>
 186
 187         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 188         value is not lval_memory.
 189
 190 2019-05-14  Tom Tromey  <tromey@adacore.com>
 191
 192         * solib.c (info_sharedlibrary_command): Style the file name.
 193
 194 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 195
 196         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 197         (aarch64_vnv_type): Likewise.
 198         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 199         * common/tdesc.c: Likewise.
 200         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 201         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 202         * features/aarch64-fpu.xml: Add ieee half view.
 203         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 204         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 205         * gdbtypes.h (struct builtin_type): Likewise.
 206         (struct objfile_type): Likewise.
 207
 208 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 209
 210         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 211         typo.
 212         * location.h (string_to_event_location): Likewise.
 213
 214 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 215
 216         GDB 8.3 released.
 217
 218 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 219
 220         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 221         New variable declaration.
 222         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 223         New variable.
 224         (print_one_breakpoint): Use ui_out::test_flags and new global
 225         variable to compute use_fixed_output.
 226         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 227         Remove.
 228         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 229         (mi_multi_location_breakpoint_output_fixed): Remove.
 230         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 231         new variable.
 232         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 233         fix_multi_location_breakpoint_output flag if version >= 3.
 234         * ui-out.h (enum ui_out_flag)
 235         <fix_multi_location_breakpoint_output>: New enumerator.
 236
 237 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 238
 239         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 240
 241 2019-05-10  Tom Tromey  <tromey@adacore.com>
 242
 243         * ada-lang.c (catch_ada_completer): New function.
 244         (_initialize_ada_language): Use it.
 245
 246 2019-05-10  Tom Tromey  <tromey@adacore.com>
 247
 248         * thread.c (print_thread_info): Make "requested_threads" const.
 249         * gdbthread.h (print_thread_info): Make "requested_threads"
 250         const.
 251         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 252         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 253
 254 2019-05-08  Tom Tromey  <tom@tromey.com>
 255
 256         * gdbtypes.c (objfile_type_data): Change type.
 257         (objfile_type, _initialize_gdbtypes): Update.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 262         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 263         (_initialize_dwarf2_frame): Update.
 264
 265 2019-05-08  Tom Tromey  <tom@tromey.com>
 266
 267         * objc-lang.c (objc_objfile_data): Change type.
 268         (find_methods): Update.
 269         (_initialize_objc_lang): Remove.
 270
 271 2019-05-08  Tom Tromey  <tom@tromey.com>
 272
 273         * stabsread.c (rs6000_builtin_type_data): Change type.
 274         (rs6000_builtin_type, _initialize_stabsread): Update.
 275
 276 2019-05-08  Tom Tromey  <tom@tromey.com>
 277
 278         * mips-tdep.c (mips_pdr_data): Remove.
 279         (_initialize_mips_tdep): Update.
 280
 281 2019-05-08  Tom Tromey  <tom@tromey.com>
 282
 283         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 284         (hppa_init_objfile_priv_data, read_unwind_info)
 285         (find_unwind_entry, _initialize_hppa_tdep): Update.
 286
 287 2019-05-08  Tom Tromey  <tom@tromey.com>
 288
 289         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 290         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 291         on obstack.
 292         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 293
 294 2019-05-08  Tom Tromey  <tom@tromey.com>
 295
 296         * mdebugread.c (basic_type_data): Change type.
 297         (basic_type, _initialize_mdebugread): Update.
 298
 299 2019-05-08  Tom Tromey  <tom@tromey.com>
 300
 301         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 302
 303 2019-05-08  Tom Tromey  <tom@tromey.com>
 304
 305         * nto-tdep.c (nto_inferior_data_reg): Change type.
 306         (nto_inferior_data): Update.
 307         (nto_inferior_data_cleanup, nto_new_inferior_data)
 308         (_initialize_nto_tdep): Remove.
 309         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 310
 311 2019-05-08  Tom Tromey  <tom@tromey.com>
 312
 313         * ada-lang.c (struct ada_inferior_data): Add initializers.
 314         (ada_inferior_data): Change type.
 315         (ada_inferior_data_cleanup): Remove.
 316         (get_ada_inferior_data, ada_inferior_exit)
 317         (struct ada_pspace_data): Add initializers, destructor.
 318         (ada_pspace_data_handle): Change type.
 319         (get_ada_pspace_data): Update.
 320         (ada_pspace_data_cleanup): Remove.
 321
 322 2019-05-08  Tom Tromey  <tom@tromey.com>
 323
 324         * coffread.c (struct coff_symfile_info): Add initializers.
 325         (coff_objfile_data_key): Move lower.  Change type.
 326         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 327         Update.
 328         (coff_free_info): Remove.
 329
 330 2019-05-08  Tom Tromey  <tom@tromey.com>
 331
 332         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 333         (fbsd_pspace_data_handle): Move lower.  Change type.
 334         (get_fbsd_pspace_data): Update.
 335         (fbsd_pspace_data_cleanup): Remove.
 336         (_initialize_fbsd_tdep): Update.
 337
 338 2019-05-08  Tom Tromey  <tom@tromey.com>
 339
 340         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 341         (get_ada_tasks_pspace_data): Update.
 342         (ada_tasks_pspace_data_cleanup): Remove.
 343         (_initialize_tasks): Update.
 344         (ada_tasks_inferior_data_handle): Change type.
 345         (get_ada_tasks_inferior_data): Update.
 346         (ada_tasks_inferior_data_cleanup): Remove.
 347         (struct ada_tasks_pspace_data): Add initializers.
 348
 349 2019-05-08  Tom Tromey  <tom@tromey.com>
 350
 351         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 352         * symfile-debug.c (debug_sym_get_probes): Change type.
 353         * stap-probe.c (handle_stap_probe):
 354         (stap_static_probe_ops::get_probes): Change type.
 355         * probe.h (class static_probe_ops) <get_probes>: Change type.
 356         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 357         (parse_probes_in_pspace): Update.
 358         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 359         Update.
 360         (any_static_probe_ops::get_probes): Change type.
 361         * elfread.c (elfread_data): New typedef.
 362         (probe_key): Change type.
 363         (elf_get_probes): Likewise.  Update.
 364         (probe_key_free): Remove.
 365         (_initialize_elfread): Update.
 366         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 367         Change type.
 368         (dtrace_process_dof_probe, dtrace_process_dof)
 369         (dtrace_static_probe_ops::get_probe): Change type.
 370
 371 2019-05-08  Tom Tromey  <tom@tromey.com>
 372
 373         * xcoffread.c (struct xcoff_symfile_info): Rename from
 374         coff_symfile_info.  Add initializers.
 375         (xcoff_objfile_data_key): Move lower.  Change type.
 376         (XCOFF_DATA): Rewrite.
 377         (xcoff_free_info): Remove.
 378         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 379         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 380         (xcoff_initial_scan): Update.
 381
 382 2019-05-08  Tom Tromey  <tom@tromey.com>
 383
 384         * solib-svr4.c (struct svr4_info): Add initializers and
 385         destructor.
 386         <probes_table>: Now an htab_up.
 387         (solib_svr4_pspace_data): Change type.
 388         (free_probes_table): Simplify.
 389         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 390         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 391         (probes_table_remove_objfile_probes, register_solib_event_probe)
 392         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 393         (_initialize_svr4_solib): Update.
 394
 395 2019-05-08  Tom Tromey  <tom@tromey.com>
 396
 397         * remote.c (remote_pspace_data): Change type.
 398         (remote_pspace_data_cleanup): Remove.
 399         (get_remote_exec_file, set_pspace_remote_exec_file)
 400         (_initialize_remote): Update.
 401
 402 2019-05-08  Tom Tromey  <tom@tromey.com>
 403
 404         * breakpoint.c (breakpoint_objfile_key): Change type.
 405         (get_breakpoint_objfile_data): Update.
 406         (free_breakpoint_objfile_data): Remove.
 407         (_initialize_breakpoint): Update.
 408
 409 2019-05-08  Tom Tromey  <tom@tromey.com>
 410
 411         * linux-tdep.c (struct linux_info): Add initializers.
 412         (linux_inferior_data): Move.  Change type.
 413         (invalidate_linux_cache_inf): Update.
 414         (linux_inferior_data_cleanup): Remove.
 415         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 416
 417 2019-05-08  Tom Tromey  <tom@tromey.com>
 418
 419         * auxv.c (auxv_inferior_data): Move.  Change type.
 420         (auxv_inferior_data_cleanup): Remove.
 421         (invalidate_auxv_cache_inf): Rewrite.
 422         (get_auxv_inferior_data, _initialize_auxv): Update.
 423
 424 2019-05-08  Tom Tromey  <tom@tromey.com>
 425
 426         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 427         (symfile_debug_objfile_data_key): Change type.
 428         (symfile_debug_installed, debug_qf_has_symbols)
 429         (debug_qf_find_last_source_symtab)
 430         (debug_qf_forget_cached_source_info)
 431         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 432         (debug_qf_print_stats, debug_qf_dump)
 433         (debug_qf_expand_symtabs_for_function)
 434         (debug_qf_expand_all_symtabs)
 435         (debug_qf_expand_symtabs_with_fullname)
 436         (debug_qf_map_matching_symbols)
 437         (debug_qf_expand_symtabs_matching)
 438         (debug_qf_find_pc_sect_compunit_symtab)
 439         (debug_qf_map_symbol_filenames)
 440         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 441         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 442         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 443         (debug_sym_read_linetable, debug_sym_relocate): Update.
 444         (symfile_debug_free_objfile): Remove.
 445         (install_symfile_debug_logging, _initialize_symfile_debug):
 446         Update.
 447
 448 2019-05-08  Tom Tromey  <tom@tromey.com>
 449
 450         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 451         allocate_on_obstack.
 452         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 453         (get_dwarf2_per_objfile): Update.
 454         (set_dwarf2_per_objfile): Remove.
 455         (dwarf2_has_info, dwarf2_get_section_info): Update.
 456         (dwarf2_free_objfile): Remove.
 457         (_initialize_dwarf2_read): Update.
 458
 459 2019-05-08  Tom Tromey  <tom@tromey.com>
 460
 461         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 462         initializers.
 463         <unsupported_script_warning_printed,
 464         script_not_found_warning_printed>: Now bool.
 465         (auto_load_pspace_data): Change type.
 466         (~auto_load_pspace_info): Rename from
 467         auto_load_pspace_data_cleanup.
 468         (get_auto_load_pspace_data, init_loaded_scripts_info)
 469         (clear_section_scripts, maybe_print_unsupported_script_warning)
 470         (maybe_print_script_not_found_warning, _initialize_auto_load):
 471         Update.
 472
 473 2019-05-08  Tom Tromey  <tom@tromey.com>
 474
 475         * objfiles.c (objfile_pspace_info): Add destructor and
 476         initializers.
 477         (objfiles_pspace_data): Change type.
 478         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 479         (get_objfile_pspace_data): Update.
 480         (objfiles_bfd_data): Change type.
 481         (get_objfile_bfd_data): Update.
 482         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 487         Change type.
 488         (get_catch_syscall_inferior_data): Update.
 489         (catch_syscall_inferior_data_cleanup): Remove.
 490         (_initialize_break_catch_syscall): Update.
 491
 492 2019-05-08  Tom Tromey  <tom@tromey.com>
 493
 494         * inflow.c (struct terminal_info): Add destructor and
 495         initializers.
 496         (inflow_inferior_data): Change type.
 497         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 498         (get_inflow_inferior_data, inflow_inferior_exit)
 499         (swap_terminal_info, _initialize_inflow): Update.
 500
 501 2019-05-08  Tom Tromey  <tom@tromey.com>
 502
 503         * target-dcache.c (target_dcache_cleanup): Remove.
 504         (target_dcache_aspace_key): Change type.
 505         (target_dcache_init_p, target_dcache_invalidate)
 506         (target_dcache_get, target_dcache_get_or_init)
 507         (_initialize_target_dcache): Update.
 508         * dcache.h (struct dcache_deleter): New.
 509
 510 2019-05-08  Tom Tromey  <tom@tromey.com>
 511
 512         * symtab.c (struct symbol_cache): Add destructor and
 513         initializers.
 514         (symbol_cache_key): Move.  Change type.
 515         (make_symbol_cache, free_symbol_cache): Remove.
 516         (get_symbol_cache): Update.
 517         (symbol_cache_cleanup): Remove.
 518         (ALL_PSPACES, symbol_cache_flush)
 519         (maintenance_print_symbol_cache)
 520         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 521         Update.
 522
 523 2019-05-08  Tom Tromey  <tom@tromey.com>
 524
 525         * symtab.c (struct main_info): Add destructor and initializers.
 526         (main_progspace_key): Move.  Change type.
 527         (get_main_info): Update.
 528         (main_info_cleanup): Remove.
 529         (_initialize_symtab): Update.
 530
 531 2019-05-08  Tom Tromey  <tom@tromey.com>
 532
 533         * registry.h (DECLARE_REGISTRY): Define the _key class.
 534
 535 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 536
 537         * NEWS: Merge two 'New commands' sections.
 538
 539 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 540
 541         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 542         parameter and use Ada language definition instead.
 543         (ada_val_print_ptr): Remove unused language parameter.
 544         (ada_val_print_num): Remove language parameter and use Ada language
 545         definition instead.
 546         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 547         parameter.
 548         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 549         parameter and use Ada language definition instead.
 550         (ada_val_print_1): Update all ada_val_print_xxx calls.
 551         Remove language parameter.
 552         (ada_val_print): Update ada_val_print_1 call.
 553
 554 2019-05-08  Tom Tromey  <tromey@adacore.com>
 555
 556         * remote.c (remote_hw_watchpoint_limit)
 557         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 558         Now static.
 559
 560 2019-05-08  Tom Tromey  <tromey@adacore.com>
 561
 562         * maint.c (_initialize_maint_cmds): Move initialization code to
 563         remote.c.
 564         (watchdog, show_watchdog): Move to remote.c.
 565         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 566         "watchdog" static.
 567         (_initialize_remote): Move initialization code from maint.c.
 568         * defs.h (watchdog): Don't declare.
 569
 570 2019-05-08  Tom Tromey  <tromey@adacore.com>
 571
 572         * tui/tui-interp.c: Include main.h.
 573         * interps.c: Include main.h.
 574         * main.h (interpreter_p): Declare.
 575         * defs.h (interpreter_p): Don't declare.
 576
 577 2019-05-08  Tom Tromey  <tromey@adacore.com>
 578
 579         * dwarf2loc.c: Include dwarf2read.h.
 580         * defs.h (read_unsigned_leb128): Don't declare.
 581         * dwarf2read.h (read_unsigned_leb128): Declare.
 582
 583 2019-05-08  Tom Tromey  <tromey@adacore.com>
 584
 585         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 586         method.
 587
 588 2019-05-08  Tom Tromey  <tromey@adacore.com>
 589
 590         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 591         when no wrap column is set.
 592
 593 2019-05-08  Tom Tromey  <tromey@adacore.com>
 594
 595         * c-lang.c (c_get_string): Handle non-C-style arrays.
 596
 597 2019-05-08  Tom Tromey  <tromey@adacore.com>
 598
 599         * typeprint.c (print_offset_data::update): Print the bit offset,
 600         not the number of bits remaining.
 601
 602 2019-05-08  Tom Tromey  <tromey@adacore.com>
 603
 604         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 605         padding at end of comment.
 606
 607 2019-05-08  Tom Tromey  <tromey@adacore.com>
 608
 609         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 610         Compare main types.
 611
 612 2019-05-06  Tom Tromey  <tom@tromey.com>
 613
 614         * common/scoped_mmap.c: Include common-defs.h.
 615         * common/scoped_mmap.h: Don't include config.h.
 616
 617 2019-05-04  Tom Tromey  <tom@tromey.com>
 618
 619         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 620         (struct aarch64_call_info): Add initializers.
 621         <si>: Now a std::vector.
 622         (pass_on_stack, aarch64_push_dummy_call): Update.
 623
 624 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 625             Tom Tromey  <tom@tromey.com>
 626
 627         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 628         (ppc_threads): Now a std::vector.  Now static.
 629         (hwdebug_find_thread_points_by_tid)
 630         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 631         Update.
 632
 633 2019-05-04  Tom Tromey  <tom@tromey.com>
 634
 635         * arc-tdep.c (arc_tdesc_init): Return bool.
 636
 637 2019-05-04  Tom Tromey  <tom@tromey.com>
 638
 639         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 640         Use gdb_assert_not_reached.
 641
 642 2019-05-04  Tom Tromey  <tom@tromey.com>
 643
 644         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 645         "false".
 646
 647 2019-05-04  Tom Tromey  <tom@tromey.com>
 648
 649         * arc-tdep.c (arc_tdesc_init): Use bool.
 650
 651 2019-05-04  Tom Tromey  <tom@tromey.com>
 652
 653         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 654
 655 2019-05-04  Tom Tromey  <tom@tromey.com>
 656
 657         * cli/cli-cmds.c (valid_command_p): Return bool.
 658
 659 2019-05-04  Tom Tromey  <tom@tromey.com>
 660
 661         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 662         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 663
 664 2019-05-04  Raul Tambre  <raul@tambre.ee>
 665
 666         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 667         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 668         operator for comparison.
 669
 670 2019-05-04  Tom Tromey  <tom@tromey.com>
 671
 672         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 673         (lookup_partial_symbol, print_partial_symbols)
 674         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 675         (psymbol_compare): Update.
 676         (add_psymbol_to_bcache): Clear the entire psymbol.
 677         (maintenance_check_psymtabs): Update.
 678         * psympriv.h (struct partial_symbol): Don't derive from
 679         general_symbol_info.
 680         <obj_section, unrelocated_address, address,
 681         set_unrelocated_address>: Update.
 682         <ginfo>: New member.
 683         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 684         (debug_names::write_psymbols): Update.
 685
 686 2019-05-04  Tom de Vries  <tdevries@suse.de>
 687
 688         * contrib/cc-with-tweaks.sh: Support -n arg.
 689
 690 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 691
 692         * corelow.c (core_target::detach): Ensure frame cache and
 693         register caches are cleared.
 694         inferior.c (exit_inferior_1): Likewise.
 695
 696 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 697             Tom Tromey  <tom@tromey.com>
 698
 699         * dictionary.c (collate_pending_symbols_by_language): Remove
 700         "struct" from foreach.
 701         * symtab.c (lookup_global_symbol_from_objfile)
 702         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 703         foreach.
 704         * ser-tcp.c (net_open): Remove "struct" from foreach.
 705         * objfiles.c (objfile_relocate, objfile_rebase)
 706         (objfile_has_symbols): Remove "struct" from foreach.
 707         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 708         from foreach.
 709         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 710         foreach.
 711         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 712         "struct" from foreach.
 713         * ada-lang.c (create_excep_cond_exprs)
 714         (ada_exception_catchpoint_cond_string): Remove "struct" from
 715         foreach.
 716
 717 2019-05-03  Tom Tromey  <tromey@adacore.com>
 718
 719         * ada-exp.y (convert_char_literal): Check suffix of each
 720         enumerator.
 721
 722 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 723
 724         PR ada/21406:
 725         * ada-exp.y (yywrap): Don't define.
 726         * ada-lex.l (%option): Add noyywrap
 727         (yywrap): Remove.
 728
 729 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 730
 731         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 732         _WIN32_WINNT to the XP level, unless already defined to a higher
 733         level.
 734
 735         * unittests/parse-connection-spec-selftests.c:
 736         * ser-tcp.c:
 737         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 738         override.
 739
 740         * symfile.c (find_separate_debug_file): Remove colon from the
 741         drive spec of DOS/Windows file names of the target, so that the
 742         file name produced from DEBUGDIR and the target's directory will
 743         be valid on DOS/Windows systems.
 744
 745 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * rust-lang.c (val_print_struct): Handle printing structures
 748         containing strings.
 749
 750 2019-05-02  Tom Tromey  <tromey@adacore.com>
 751
 752         * valarith.c (_initialize_valarith): Remove.
 753
 754 2019-05-01  Tom Tromey  <tromey@adacore.com>
 755
 756         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 757         bitfields.
 758
 759 2019-05-01  Tom Tromey  <tromey@adacore.com>
 760
 761         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 762         for big-endian copies.
 763
 764 2019-04-30  Ali Tamur  <tamur@google.com>
 765         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 766         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 767         (read_3_bytes): New function.
 768
 769 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 770
 771         * windows-nat.c (main_thread_id): Delete.
 772         (handle_output_debug_string): Replace main_thread_id by
 773         current_event.dwThreadId.
 774         (fake_create_process): Likewise.
 775         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 776         Do not set main_thread_id.
 777         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 778         current_event.dwThreadId.
 779         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 780
 781 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 782
 783         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 784         Use current_event.dwThreadId instead of main_thread_id.
 785
 786 2019-04-30  Tom Tromey  <tromey@adacore.com>
 787
 788         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 789         (create_excep_cond_exprs): Iterate over program spaces.
 790         (ada_exception_catchpoint_cond_string): Examine all minimal
 791         symbols for exception types.
 792
 793 2019-04-30  Tom Tromey  <tromey@adacore.com>
 794
 795         PR c++/24470:
 796         * dwarf2read.c (process_structure_scope): Handle case where type
 797         has template parameters but no symbol was created.
 798
 799 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 800             Chris January  <chris.january@arm.com>
 801
 802         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 803         qualifier.
 804         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 805
 806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * f-typeprint.c (f_print_type): Update rules for printing
 809         whitespace.
 810         (f_type_print_varspec_suffix): Likewise.
 811
 812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 813             Chris January  <chris.january@arm.com>
 814
 815         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 816         function arguments.
 817
 818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * f-lang.c (build_fortran_types): Change name of void type to
 821         lower case.
 822         * f-typeprint.c (f_type_print_base): Print the name of the void
 823         type, rather than a fixed string.
 824         * f-valprint.c (f_decorations): Use lower case void string.
 825
 826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 827             Chris January  <chris.january@arm.com>
 828
 829         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 830         types for Fortran.
 831
 832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 833             Chris January  <chris.january@arm.com>
 834             David Lecomber  <david.lecomber@arm.com>
 835
 836         * f-exp.y (BINOP_INTRINSIC): New token.
 837         (exp): New parser rule handling BINOP_INTRINSIC.
 838         (f77_keywords): Add new builtin procedures.
 839         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 840         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 841         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 842         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 843         (print_unop_subexp_f): New function.
 844         (print_binop_subexp_f): New function.
 845         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 846         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 847         (dump_subexp_body_f): Likewise.
 848         (operator_check_f): Likewise.
 849         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 850         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 851
 852 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 855         UNOP_KIND.
 856         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 857         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 858         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 859         (operator_length_f): New fuction.
 860         (print_subexp_f): New function.
 861         (op_name_f): New function.
 862         (dump_subexp_body_f): New function.
 863         (operator_check_f): New function.
 864         (exp_descriptor_f): Replace standard expression handling functions
 865         with new functions.
 866         * gdb/fortran-operator.def: New file.
 867         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 868         * gdb/std-operator.def: Remove UNOP_KIND.
 869
 870 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * std-operator.def: Remove unbalanced, stray double quote
 873         character.
 874
 875 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 876             Chris January  <chris.january@arm.com>
 877             Daniel Everett  <daniel.everett@arm.com>
 878             Nick Forrington  <nick.forrington@arm.com>
 879             Richard Bunt  <richard.bunt@arm.com>
 880
 881         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 882         of depth when printing anonymous structs or unions.
 883         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 884         Don't print either the top-level value, or the children if the
 885         max-depth is exceeded.
 886         (ppscm_print_children): When printing the key of a map, allow one
 887         extra level of depth.
 888         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 889         print either the top-level value, or the children if the max-depth
 890         is exceeded.
 891         (print_children): When printing the key of a map, allow one extra
 892         level of depth.
 893         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 894         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 895         (user_print_options): Initialise max_depth field.
 896         (val_print_scalar_or_string_type_p): New function.
 897         (val_print): Check to see if the max depth has been reached.
 898         (val_print_check_max_depth): Define new function.
 899         (show_print_max_depth): New function.
 900         (_initialize_valprint): Add 'print max-depth' option.
 901         * valprint.h (struct value_print_options) <max_depth>: New field.
 902         (val_print_check_max_depth): Declare new function.
 903         * NEWS: Document new feature.
 904
 905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * ada-lang.c (ada_language_defn): Initialise new field.
 908         * c-lang.c (c_is_string_type_p): New function.
 909         (c_language_defn): Initialise new field.
 910         (cplus_language_defn): Initialise new field.
 911         (asm_language_defn): Initialise new field.
 912         (minimal_language_defn): Initialise new field.
 913         * c-lang.h (c_is_string_type_p): Declare new function.
 914         * d-lang.c (d_language_defn): Initialise new field.
 915         * f-lang.c (f_is_string_type_p): New function.
 916         (f_language_defn): Initialise new field.
 917         * go-lang.c (go_is_string_type_p): New function.
 918         (go_language_defn): Initialise new field.
 919         * language.c (default_is_string_type_p): New function.
 920         (unknown_language_defn): Initialise new field.
 921         (auto_language_defn): Initialise new field.
 922         * language.h (struct language_defn) <la_is_string_type_p>: New
 923         member variable.
 924         (default_is_string_type_p): Declare new function.
 925         * m2-lang.c (m2_language_defn): Initialise new field.
 926         * objc-lang.c (objc_language_defn): Initialise new field.
 927         * opencl-lang.c (opencl_language_defn): Initialise new field.
 928         * p-lang.c (pascal_is_string_type_p): New function.
 929         (pascal_language_defn): Initialise new field.
 930         * rust-lang.c (rust_is_string_type_p): New function.
 931         (rust_language_defn): Initialise new field.
 932
 933 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 936         New field.
 937         * ada-lang.c (ada_language_defn): Initialise new field.
 938         * c-lang.c (c_language_defn): Likewise.
 939         (cplus_language_defn): Likewise.
 940         (asm_language_defn): Likewise.
 941         (minimal_language_defn): Likewise.
 942         * d-lang.c (d_language_defn): Likewise.
 943         * f-lang.c (f_language_defn): Likewise.
 944         * go-lang.c (go_language_defn): Likewise.
 945         * language.c (unknown_language_defn): Likewise.
 946         (auto_language_defn): Likewise.
 947         * m2-lang.c (m2_language_defn): Likewise.
 948         * objc-lang.c (objc_language_defn): Likewise.
 949         * opencl-lang.c (opencl_language_defn): Likewise.
 950         * p-lang.c (pascal_language_defn): Likewise.
 951         * rust-lang.c (rust_language_defn): Likewise.
 952
 953 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * ada-lang.c (ada_is_character_type): Change return type to bool.
 956         (ada_is_string_type): Likewise.
 957         * ada-lang.h (ada_is_character_type): Update declaration
 958         (ada_is_string_type): Likewise.
 959
 960 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 961
 962         Support style in 'frame|thread apply'
 963
 964         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 965         * record.c (record_start, record_stop): Update callers of
 966         execute_command_to_string with false.
 967         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 968         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 969         methods.
 970         (class string_file): New constructor with term_out parameter.
 971         Override methods term_out and can_emit_style_escape.  New member
 972         term_out.
 973         (class stdio_file): Override can_emit_style_escape.
 974         (class tee_file): Override term_out and can_emit_style_escape.
 975         * utils.h (can_emit_style_escape): Remove.
 976         * utils.c (can_emit_style_escape): Likewise.
 977         Update all callers of can_emit_style_escape (SOMESTREAM) to
 978         SOMESTREAM->can_emit_style_escape.
 979         * source-cache.c (source_cache::get_source_lines): Likewise.
 980         * stack.c (frame_apply_command_count): Call execute_command_to_string
 981         passing the term_out characteristic of the current gdb_stdout.
 982         * thread.c (thr_try_catch_cmd): Likewise.
 983         * top.c (execute_command_to_string): pass term_out parameter
 984         to construct the string_file for the command output.
 985         * ui-file.c (term_cli_styling): New function (most code moved
 986         from utils.c can_emit_style_escape).
 987         (string_file::string_file, string_file::can_emit_style_escape,
 988         stdio_file::can_emit_style_escape, tee_file::term_out,
 989         tee_file::can_emit_style_escape): New functions.
 990
 991 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 992
 993         * NEWS: Mention the new set|show may-call-functions.
 994         * infcall.c (may_call_functions_p): New variable.
 995         (show_may_call_functions_p): New function.
 996         (call_function_by_hand_dummy): Throws an error if not
 997         may-call-functions.
 998         (_initialize_infcall): Call add_setshow_boolean_cmd for
 999         may-call-functions.
1000
1001 2019-04-25  Keith Seitz  <keiths@redhat.com>
1002
1003         PR c++/24367
1004         * cp-support.c (inspect_type): Don't attempt substitutions
1005         of symbol with the same name.
1006
1007 2019-04-25  Tom Tromey  <tromey@adacore.com>
1008
1009         PR gdb/24475:
1010         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1011         static.
1012
1013 2019-04-25  Tom Tromey  <tromey@adacore.com>
1014
1015         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1016         rvalue reference.
1017         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1018         (gdb_xml_parser::parse): Use std::move.
1019         * python/python-internal.h (gdbpy_convert_exception): Take a const
1020         reference.
1021         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1022         std::move.
1023         * python/py-utils.c (gdbpy_convert_exception): Take a const
1024         reference.
1025         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1026         Use std::move.
1027         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1028         Use std::move.
1029         * mi/mi-main.c (mi_print_exception): Take a const reference.
1030         * main.c (handle_command_errors): Take a const reference.
1031         * linespec.c (parse_linespec): Use std::move.
1032         * infcall.c (run_inferior_call): Use std::move.
1033         (call_function_by_hand_dummy): Use std::move.
1034         * exec.c (try_open_exec_file): Use std::move.
1035         * exceptions.h (exception_print, exception_fprintf)
1036         (exception_print_same): Update.
1037         * exceptions.c (print_exception, exception_print)
1038         (exception_fprintf, exception_print_same): Change parameters to
1039         const reference.
1040         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1041         * common/new-op.c: Use std::move.
1042         * common/common-exceptions.h (struct gdb_exception): Add move
1043         constructor.
1044         (struct gdb_exception_error, struct gdb_exception_quit, struct
1045         gdb_quit_bad_alloc): Change constructor to move constructor.
1046         (throw_exception): Change parameter to rvalue reference.
1047         * common/common-exceptions.c (throw_exception): Take rvalue
1048         reference.
1049         * cli/cli-interp.c (safe_execute_command): Use std::move.
1050         * breakpoint.c (insert_bp_location, location_to_sals): Use
1051         std::move.
1052
1053 2019-04-25  Tom Tromey  <tromey@adacore.com>
1054
1055         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1056         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1057         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1058         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1059         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1060         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1061         guile/scm-value.c: Use unpack.
1062         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1063         gdbscm_gdb_exception.
1064         (gdbscm_throw_gdb_exception): Likewise.
1065         (struct gdbscm_gdb_exception): New.
1066         (unpack): New function.
1067         (gdbscm_wrap): Use unpack.
1068
1069 2019-04-25  Tom Tromey  <tromey@adacore.com>
1070
1071         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1072         (gdb_rl_callback_handler): Use std::move.
1073         * common/common-exceptions.h (struct gdb_exception): Add move
1074         assignment operator.
1075         (throw_exception_sjlj): Change "exception" to const reference.
1076         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1077         (throw_exception_sjlj): Change "exception" to const reference.
1078
1079 2019-04-25  Tom Tromey  <tromey@adacore.com>
1080
1081         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1082         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1083         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1084         Update.
1085         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1086         Update.
1087         * mi/mi-interp.c (mi_interp::exec): Update.
1088         * linespec.c (parse_linespec): Update.
1089         * infcall.c (run_inferior_call): Update.
1090         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1091         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1092         (gdbscm_lookup_global_symbol): Update.
1093         * guile/scm-param.c (gdbscm_parameter_value): Update.
1094         * guile/scm-frame.c (gdbscm_frame_read_register)
1095         (gdbscm_frame_read_var): Update.
1096         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1097         * exec.c (try_open_exec_file): Update.
1098         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1099         (gdb_rl_callback_handler): Update.
1100         * common/common-exceptions.h (exception_none): Don't declare.
1101         * common/common-exceptions.c (exception_none): Don't define.
1102         (struct catcher) <exception>: Update.
1103         * cli/cli-interp.c (safe_execute_command): Update.
1104         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1105
1106 2019-04-25  Ali Tamur  <tamur@google.com>
1107
1108         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1109         (read_attribute_value): Likewise.
1110         (dwarf2_read_addr_index): Update comment.
1111         (read_str_index): Add DW_FORM_strx.
1112         (dwarf2_string_attr): Likewise.
1113         (dwarf2_const_value_attr): Likewise.
1114         (dump_die_shallow): Likewise.
1115         (dwarf2_fetch_constant_bytes): Likewise.
1116         (skip_form_bytes): Likewise.
1117         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1118
1119 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1120
1121         PR corefiles/11608
1122         PR corefiles/18187
1123         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1124         OFFSET.  Verify if current mapping contains an ELF header.
1125         (linux_find_memory_regions_full): Adjust call to
1126         dump_mapping_p.
1127
1128 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1129             Kang Li <kanglictf@gmail.com>
1130
1131         PR gdb/21600
1132
1133         * dwarf2-frame.c (read_initial_length): Be consistent about using
1134         unsigned representation of length.
1135         (decode_frame_entry_1): Likewise.  Check for wraparound of
1136         end pointer as well as buffer overflow.
1137
1138 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1139
1140         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1141         "vq".
1142
1143 2019-04-24  Tom Tromey  <tromey@adacore.com>
1144
1145         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1146
1147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * s12z-tdep.c (s12z_unwind_pc): Delete.
1150         (s12z_unwind_sp): Delete.
1151         (s12z_gdbarch_init): Don't register deleted functions with
1152         gdbarch.
1153
1154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * rl78-tdep.c (rl78_unwind_sp): Delete.
1157         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1158
1159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1162         (xstormy16_unwind_pc): Delete.
1163         (xstormy16_dummy_id): Delete.
1164         (xstormy16_gdbarch_init): Don't register deleted functions with
1165         gdbarch.
1166
1167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * vax-tdep.c (vax_unwind_pc): Delete.
1170         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1171
1172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * v850-tdep.c (v850_unwind_sp): Delete.
1175         (v850_unwind_pc): Delete.
1176         (v850_dummy_id): Delete.
1177         (v850_gdbarch_init): Don't register deleted functions with
1178         gdbarch.
1179
1180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1183         (tilegx_unwind_pc): Delete.
1184         (tilegx_unwind_dummy_id): Delete.
1185         (tilegx_gdbarch_init): Don't register deleted functions with
1186         gdbarch.
1187
1188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1191         (tic6x_dummy_id): Delete.
1192         (tic6x_gdbarch_init): Don't register deleted functions with
1193         gdbarch.
1194
1195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * sparc-tdep.c (sparc_unwind_pc): Delete.
1198         (sparc32_gdbarch_init): Don't register deleted function with
1199         gdbarch.
1200
1201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * sh-tdep.c (sh_unwind_sp): Delete.
1204         (sh_unwind_pc): Delete.
1205         (sh_dummy_id): Delete.
1206         (sh_gdbarch_init): Don't register deleted functions with
1207         gdbarch.
1208
1209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1210
1211         * score-tdep.c (score_unwind_sp): Delete.
1212         (score_unwind_pc): Delete.
1213         (score_dummy_id): Delete.
1214         (score_gdbarch_init): Don't register deleted functions with
1215         gdbarch.
1216
1217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * rx-tdep.c (rx_unwind_pc): Delete.
1220         (rx_unwind_sp): Delete.
1221         (rx_dummy_id): Delete.
1222         (rx_gdbarch_init): Don't register deleted functions with
1223         gdbarch.  Update comment.
1224
1225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1228         (rs6000_dummy_id): Delete.
1229         (rs6000_gdbarch_init): Don't register deleted functions with
1230         gdbarch.
1231
1232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * or1k-tdep.c (or1k_dummy_id): Delete.
1235         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1236
1237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1238
1239         * nios2-tdep.c (nios2_dummy_id): Delete.
1240         (nios2_unwind_sp): Delete.
1241         (nios2_gdbarch_init): Don't register deleted functions with
1242         gdbarch.
1243
1244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * nds32-tdep.c (nds32_dummy_id): Delete.
1247         (nds32_unwind_pc): Delete.
1248         (nds32_unwind_sp): Delete.
1249         (nds32_gdbarch_init): Don't register deleted functions with
1250         gdbarch.
1251
1252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * msp430-tdep.c (msp430_unwind_pc): Delete.
1255         (msp430_unwind_sp): Delete.
1256         (msp430_dummy_id): Delete.
1257         (msp430_gdbarch_init): Don't register deleted functions with
1258         gdbarch.
1259
1260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * moxie-tdep.c (moxie_unwind_sp): Delete.
1263         (moxie_unwind_pc): Delete.
1264         (moxie_dummy_id): Delete.
1265         (moxie_gdbarch_init): Don't register deleted functions with
1266         gdbarch.
1267
1268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1271         (mn10300_unwind_pc): Delete.
1272         (mn10300_unwind_sp): Delete.
1273         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1274         mn10300_unwind_sp.
1275         (mn10300_frame_unwind_init): Don't register deleted functions with
1276         gdbarch.
1277
1278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * mep-tdep.c (mep_unwind_pc): Delete.
1281         (mep_unwind_sp): Delete.
1282         (mep_dummy_id): Delete.
1283         (mep_gdbarch_init): Don't register deleted functions with
1284         gdbarch.
1285
1286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1289         (m68hc11_unwind_sp): Delete.
1290         (m68hc11_gdbarch_init): Don't register deleted functions with
1291         gdbarch.
1292
1293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * m32r-tdep.c (m32r_unwind_sp): Delete.
1296         (m32r_unwind_pc): Delete.
1297         (m32r_dummy_id): Delete.
1298         (m32r_gdbarch_init): Don't register deleted functions with
1299         gdbarch.
1300
1301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * m32c-tdep.c (m32c_unwind_pc): Delete.
1304         (m32c_unwind_sp): Delete.
1305         (m32c_dummy_id): Delete.
1306         (m32c_gdbarch_init): Don't register deleted functions with
1307         gdbarch.
1308
1309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1312         (lm32_unwind_pc): Delete.
1313         (lm32_dummy_id): Delete.
1314         (lm32_gdbarch_init): Don't register deleted functions with
1315         gdbarch.
1316
1317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1320         (iq2000_unwind_pc): Delete.
1321         (iq2000_dummy_id): Delete.
1322         (iq2000_gdbarch_init): Don't register deleted functions with
1323         gdbarch.
1324
1325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1326
1327         * nds32-tdep.c (nds32_type_align): Delete.
1328         (nds32_push_dummy_call): Use type_align instead.
1329
1330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * arm-tdep.c (arm_type_align): Only handle vector override case.
1333         (arm_push_dummy_call): Use type_align.
1334         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1335
1336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1339         case.
1340         (pass_on_stack): Use type_align.
1341         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1342         function.
1343
1344 2019-04-23  Tom Tromey  <tromey@adacore.com>
1345
1346         * dwarf2read.c (line_header::file_name_at): Remove unused
1347         overload.
1348
1349 2019-04-23  Tom de Vries  <tdevries@suse.de>
1350
1351         PR gdb/24438
1352         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1353         invocation.
1354
1355
1356 2019-03-27  Ali Tamur  <tamur@google.com>
1357
1358         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1359         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1360         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1361         (dwarf_expr_context::get_addr_index): Likewise
1362         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1363         (symbol_needs_eval_context::get_addr_index): Likewise
1364         (disassemble_dwarf_expression): Add DW_OP_addrx
1365         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1366         (read_cutu_die_from_dwo): Update comment
1367         (skip_one_die): Add DW_FORM_addrx
1368         (read_attribute_value): Likewise
1369         (var_decode_location): Add DW_OP_addrx
1370         (dwarf2_const_value_attr): Add DW_FORM_addrx
1371         (dump_die_shallow): Likewise
1372         (dwarf2_fetch_constant_bytes): Likewise
1373         (decode_locdesc): Add DW_OP_addrx
1374         (skip_form_bytes): Add DW_FORM_addrx
1375
1376 2019-04-22  Ali Tamur  <tamur@google.com>
1377
1378         * MAINTAINERS (Write After Approval): Add self.
1379
1380 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1381
1382         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1383         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1384         (open_symbol_file_object): Likewise.
1385         (svr4_default_sos): Add info parameter.
1386         (svr4_read_so_list): Likewise.
1387         (svr4_current_sos_direct): Adjust functions calls to pass down
1388         info.
1389         (svr4_current_sos_1): Add info parameter.
1390         (svr4_current_sos): Call get_svr4_info, pass info down to
1391         svr4_current_sos_1.
1392         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1393         get_svr4_info.
1394         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1395         get_svr4_info.
1396         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1397         to get_svr4_info.
1398         (probes_table_remove_objfile_probes): Likewise.
1399         (register_solib_event_probe): Add info parameter.
1400         (solist_update_incremental): Pass info parameter down to
1401         svr4_read_so_list.
1402         (disable_probes_interface): Add info parameter.
1403         (svr4_handle_solib_event): Pass current_program_space to
1404         get_svr4_info.  Adjust disable_probes_interface cleanup.
1405         (svr4_create_probe_breakpoints): Add info parameter, pass it
1406         down to register_solib_event_probe.
1407         (svr4_create_solib_event_breakpoints): Add info parameter,
1408         pass it down to svr4_create_probe_breakpoints.
1409         (enable_break): Pass info down to
1410         svr4_create_solib_event_breakpoints.
1411         (svr4_solib_create_inferior_hook): Pass current_program_space to
1412         get_svr4_info.
1413         (svr4_clear_solib): Likewise.
1414
1415 2019-04-22  Pedro Alves  <palves@redhat.com>
1416
1417         * solib-svr4.c (svr4_free_objfile_observer): New.
1418         (probe_and_action::objfile): New field.
1419         (probes_table_htab_remove_objfile_probes)
1420         (probes_table_remove_objfile_probes): New functions.
1421         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1422         in the new probe_and_action.  Don't store the probe in 'lookup'.
1423         (svr4_create_probe_breakpoints): Pass objfile to
1424         register_solib_event_probe.
1425         (_initialize_svr4_solib): Register a free_objfile observer.
1426
1427 2019-04-19  Tom Tromey  <tom@tromey.com>
1428
1429         * common/queue.h: Remove.
1430
1431 2019-04-19  Tom Tromey  <tom@tromey.com>
1432
1433         * event-loop.c: Don't include "common/queue.h".
1434
1435 2019-04-19  Tom Tromey  <tom@tromey.com>
1436
1437         * remote.c (remote_target): Use delete.
1438         * remote-notif.h: Include <list>, not "common/queue.h".
1439         (notif_client_p): Remove typedef.
1440         (remote_notif_state): Add constructor, destructor, initializer.
1441         <notif_queue>: Now a std::list.
1442         (remote_notif_state_xfree): Don't declare.
1443         * remote-notif.c (remote_notif_process, handle_notification)
1444         (remote_notif_state_allocate): Update.
1445         (~remote_notif_state): Rename from remote_notif_state_xfree.
1446
1447 2019-04-19  Tom Tromey  <tom@tromey.com>
1448
1449         * symfile.c (reread_symbols): Update.
1450         * objfiles.c (objfile_register_static_link)
1451         (objfile_lookup_static_link): Update
1452         (~objfile) Don't delete static_links.
1453         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1454
1455 2019-04-19  Tom Tromey  <tom@tromey.com>
1456
1457         * type-stack.h (struct type_stack) <insert>: Constify string.
1458         * type-stack.c (type_stack::insert): Constify string.
1459         * gdbtypes.h (lookup_template_type): Update.
1460         (address_space_name_to_int): Update.
1461         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1462         const.
1463         (lookup_template_type): Make name const.
1464         * c-exp.y: Update rules.
1465         (lex_one_token, classify_name, classify_inner_name)
1466         (c_print_token): Update.
1467         * p-exp.y: Update rules.
1468         (yylex): Update.
1469         * f-exp.y: Update rules.
1470         (yylex): Update.
1471         * d-exp.y: Update rules.
1472         (lex_one_token, classify_name, classify_inner_name): Update.
1473         * parse.c (write_dollar_variable, copy_name): Return std::string.
1474         * parser-defs.h (copy_name): Change return type.
1475         * m2-exp.y: Update rules.
1476         (yylex): Update.
1477         * go-exp.y (lex_one_token): Update.
1478         Update rules.
1479         (classify_unsafe_function, classify_packaged_name)
1480         (classify_name, yylex): Update.
1481
1482 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1483
1484         * configure.ac: add --enable-source-highlight switch.
1485         * configure: Regenerate.
1486         * top.c (print_gdb_version): plumb --enable-source-highlight
1487         status to "show configuration".
1488
1489 2019-04-19  Tom Tromey  <tromey@adacore.com>
1490
1491         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1492         Check ADA_TYPE_P.
1493         (empty_record, ada_template_to_fixed_record_type_1)
1494         (template_to_static_fixed_type)
1495         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1496         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1497         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1498         macros.
1499
1500 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1501
1502         PR symtab/24423:
1503         * source.c (print_source_lines_base): Advance "iter" when a
1504         control character is seen.
1505
1506 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1507
1508         * inferior.h (struct infcall_suspend_state_deleter):
1509         Catch exception in destructor to avoid crash.
1510
1511 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1512
1513         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1514         close to the add_com "shell".
1515
1516 2019-04-18  Tom Tromey  <tromey@adacore.com>
1517
1518         * process-stratum-target.h (class process_stratum_target)
1519         <stratum>: Add "final".
1520
1521 2019-04-17  Tom Tromey  <tromey@adacore.com>
1522
1523         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1524         against nullptr before use.
1525
1526 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1529
1530 2019-04-17  Jim Wilson  <jimw@sifive.com>
1531             Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1534         code read might fail, assume 4-byte breakpoint in that case.
1535
1536 2019-04-15  Leszek Swirski  <leszeks@google.com>
1537
1538         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1539         rather than a hand-rolled POD check when checking for forced MEMORY
1540         classification.
1541
1542 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1543
1544         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1545         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1546         function.
1547         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1548         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1549         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1550         declaration.
1551
1552 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * aarch64-linux-nat.c
1555         (aarch64_linux_nat_target::thread_architecture): Add override.
1556         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1557         each VQ.
1558
1559 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1560
1561         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1562
1563 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1566         target types of size 96-bits, add some additional comments, and
1567         check that the builtin type we found was the correct size.
1568
1569 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1570
1571         * utils.c (prompt_for_continue): Don't restore the styling at the
1572         end, as applied_style has the wrong value.  This fixes styling in
1573         long lists of file names that are interrupted by the "Continue?"
1574         prompt.
1575
1576 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1579         * c-lang.c (c_language_defn): Likewise.
1580         (cplus_language_defn): Likewise.
1581         (asm_language_defn): Likewise.
1582         (minimal_language_defn): Likewise.
1583         * d-lang.c (d_language_defn): Likewise.
1584         * f-lang.c (f_language_defn): Likewise.
1585         * go-lang.c (go_language_defn): Likewise.
1586         * language.c (unknown_language_defn): Likewise.
1587         (auto_language_defn): Likewise.
1588         * language.h (struct language_defn): Remove la_magic field.
1589         (LANG_MAGIC): Delete.
1590         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1591         * objc-lang.c (objc_language_defn): Likewise.
1592         * opencl-lang.c (opencl_language_defn): Likewise.
1593         * p-lang.c (pascal_language_defn): Likewise.
1594         * rust-lang.c (rust_language_defn): Likewise.
1595
1596 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * riscv-tdep.c (riscv_type_align): New function.
1599         (riscv_type_alignment): Delete.
1600         (riscv_arg_location): Use 'type_align'.
1601         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1602
1603 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1604
1605         * gdbtypes.c (type_align): A struct with no non-static fields also
1606         has alignment of 1.
1607
1608 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1611         component to 0.
1612         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1613         member.
1614         (riscv_struct_info::analyse): New implementation using new
1615         analyse_inner member function.
1616         (riscv_struct_info::field_offset): New member function.
1617         (riscv_struct_info::m_offsets): New member variable.
1618         (riscv_struct_info::analyse_inner): New private member function,
1619         takes the old implementation of riscv_struct_info::analyse but
1620         extended to track field offsets.
1621         (riscv_call_arg_struct): Update the struct folding special cases
1622         to handle cases where empty C++ structs, which are non-zero
1623         length, are found.
1624         (riscv_arg_location): Initialise the length of each location, a
1625         non-zero length now indicates the location is in use.
1626         (riscv_push_dummy_call): Allow for the first location having a
1627         non-zero offset when setting up arguments.
1628         (riscv_return_value): Likewise, but for return values.
1629
1630 2019-04-11  Tom Tromey  <tromey@adacore.com>
1631
1632         * utils.c (internal_vproblem): Make "msg" const.
1633
1634 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1635
1636         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1637         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1638         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1639         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1640
1641 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1642
1643         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1644         function.
1645         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1646         of amd64_collect_native_gregset.
1647         (amd64_linux_nat_target::store_registers): Likewise.
1648
1649 2019-04-10  Tom Tromey  <tom@tromey.com>
1650
1651         * symtab.c (lookup_global_symbol_from_objfile)
1652         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1653         * objfiles.h (class separate_debug_iterator): New.
1654         (class separate_debug_range): New.
1655         (struct objfile) <separate_debug_objfiles>: New method.
1656         (objfile_separate_debug_iterate): Don't declare.
1657         * objfiles.c (separate_debug_iterator::operator++): Rename from
1658         objfile_separate_debug_iterate.
1659         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1660         iterator.
1661         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1662         iterator.
1663
1664 2019-04-10  Tom Tromey  <tom@tromey.com>
1665
1666         * symfile.c (reread_symbols): Remove old comment.
1667         * objfiles.c (free_all_objfiles): Fix a typo.
1668
1669 2019-04-10  Tom Tromey  <tom@tromey.com>
1670
1671         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1672         * minsyms.c (lookup_minimal_symbol): Use foreach.
1673         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1674         (lookup_minimal_symbol_solib_trampoline): Likewise.
1675         * symfile.c (reread_symbols): Use foreach.
1676
1677 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1678             Tom Tromey  <tromey@adacore.com>
1679
1680         PR rust/24414:
1681         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1682         (rust_lex_int_test): Change "value" to be LONGEST.
1683         (rust_lex_tests): Add test for long integer literal.
1684
1685 2019-04-09  Tom Tromey  <tromey@adacore.com>
1686
1687         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1688         to bool.
1689         (extended_remote_target::attach): Update.
1690         (remote_target::remote_notice_new_inferior): Update.
1691         (remote_target::add_current_inferior_and_thread): Update.
1692         * inferior.c (exit_inferior_1): Use "false".
1693         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1694
1695 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1696
1697         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1698         the "start" command.
1699
1700 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1701
1702         * python/py-inferior.c (infpy_thread_from_thread_handle):
1703         Adjust comments to reflect renaming of thread_from_thread_handle
1704         to thread_from_handle.  Adjust keywords.  Fix type error message.
1705         (inferior_object_methods): Add thread_from_handle.  Retain
1706         thread_from_thread_handle, but mark it as deprecated.
1707
1708 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1709
1710         * gdbthread.h (find_thread_by_handle): Revise declaration.
1711         * thread.c (find_thread_by_handle): Likewise.  Adjust
1712         implementation too.
1713         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1714         support for buffer objects as handles.
1715
1716 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1717
1718         * python/py-infthread.c (thpy_thread_handle): New function.
1719         (thread_object_methods): Register thpy_thread_handle.
1720
1721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1722
1723         * gdbthread.h (thread_to_thread_handle): Declare.
1724         * thread.c (gdbtypes.h): Include.
1725         (thread_to_thread_handle): New function.
1726
1727         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1728         (target_thread_info_to_thread_handle): Declare.
1729         * target.c (target_thread_info_to_thread_handle): New function.
1730         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1731         * target-delegates.c: Regenerate.
1732
1733         * linux-thread-db.c (class thread_db_target): Add method
1734         thread_info_to_thread_handle.
1735         (thread_db_target::thread_info_to_thread_handle): Define.
1736         * remote.c (class remote_target): Add new method
1737         thread_info_to_thread_handle.
1738         (remote_target::thread_info_to_thread_handle): Define.
1739
1740 2019-04-08  Pedro Alves  <palves@redhat.com>
1741
1742         * common/common-exceptions.c (throw_exception): Don't create
1743         named object to throw; throw directly.
1744         (throw_it): Likewise.  Don't initialize gdb_exception::message
1745         here, with new; pass FMT and AP to the ctor instead.
1746         * common/common-exceptions.h: Include <string>.
1747         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1748         const char *, va_list)): New ctor.  Use std::make_shared.
1749         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1750         errors)): Delete.
1751         (gdb_exception_error::gdb_exception_error(enum errors, const char
1752         *, va_list)): New.
1753         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1754         Add assertion.
1755         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1756         errors)): Delete.
1757         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1758         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1759         Add assertion.
1760
1761 2019-04-08  Tom Tromey  <tom@tromey.com>
1762
1763         * valops.c (value_rtti_indirect_type): Replace throw_exception
1764         with throw.
1765         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1766         with throw.
1767         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1768         throw.
1769         * target.c (target_translate_tls_address): Replace throw_exception
1770         with throw.
1771         * stack.c (frame_apply_command_count): Replace throw_exception
1772         with throw.
1773         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1774         throw.
1775         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1776         with throw.
1777         * rs6000-tdep.c (rs6000_frame_cache)
1778         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1779         * remote.c: Replace throw_exception with throw.
1780         * record-full.c (record_full_message, record_full_wait_1)
1781         (record_full_restore): Replace throw_exception with throw.
1782         * record-btrace.c:
1783         (get_thread_current_frame_id, record_btrace_start_replaying)
1784         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1785         (cmd_record_btrace_start): Replace throw_exception with throw.
1786         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1787         throw.
1788         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1789         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1790         * linespec.c:
1791         (find_linespec_symbols): Replace throw_exception with throw.
1792         * infrun.c (displaced_step_prepare, resume): Replace
1793         throw_exception with throw.
1794         * infcmd.c (post_create_inferior): Replace throw_exception with
1795         throw.
1796         * inf-loop.c (inferior_event_handler): Replace throw_exception
1797         with throw.
1798         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1799         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1800         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1801         (get_prev_frame_always, get_frame_pc_if_available)
1802         (get_frame_address_in_block_if_available, get_frame_language):
1803         Replace throw_exception with throw.
1804         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1805         throw_exception with throw.
1806         * eval.c (fetch_subexp_value, evaluate_var_value)
1807         (evaluate_funcall, evaluate_subexp_standard): Replace
1808         throw_exception with throw.
1809         * dwarf2loc.c (call_site_find_chain)
1810         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1811         Replace throw_exception with throw.
1812         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1813         with throw.
1814         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1815         throw.
1816         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1817         * completer.c (complete_line_internal): Replace throw_exception
1818         with throw.
1819         * compile/compile-object-run.c (compile_object_run): Replace
1820         throw_exception with throw.
1821         * cli/cli-script.c (process_next_line): Replace throw_exception
1822         with throw.
1823         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1824         (btrace_enable, btrace_maint_update_pt_packets): Replace
1825         throw_exception with throw.
1826         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1827         throw_exception with throw.
1828         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1829         throw_exception with throw.
1830         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1831         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1832         * aarch64-tdep.c (aarch64_make_prologue_cache)
1833         (aarch64_make_stub_cache): Replace throw_exception with throw.
1834
1835 2019-04-08  Tom Tromey  <tom@tromey.com>
1836
1837         * common/common-exceptions.c (throw_exception): Rename from
1838         throw_exception_cxx.  Remove old copy.  Make argument const.
1839         (throw_it): Create and throw exception objects directly.
1840         * common/common-exceptions.h (throw_exception): Make argument
1841         const.
1842         (struct gdb_exception_error): Add constructor.
1843         (struct gdb_exception_quit): Add constructor.
1844
1845 2019-04-08  Tom Tromey  <tom@tromey.com>
1846
1847         * common/common-exceptions.h (exception_rethrow): Don't declare.
1848         (TRY_SJLJ): Update comment.
1849         (TRY, CATCH, END_CATCH): Remove.
1850         * common/common-exceptions.c (exception_rethrow): Remove.
1851
1852 2019-04-08  Tom Tromey  <tom@tromey.com>
1853
1854         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1855         Remove.
1856         (gdb_exception_error): Rename from
1857         gdb_exception_RETURN_MASK_ERROR.
1858         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1859         (gdb_quit_bad_alloc): Update.
1860         * aarch64-tdep.c: Update.
1861         * ada-lang.c: Update.
1862         * ada-typeprint.c: Update.
1863         * ada-valprint.c: Update.
1864         * amd64-tdep.c: Update.
1865         * arch-utils.c: Update.
1866         * break-catch-throw.c: Update.
1867         * breakpoint.c: Update.
1868         * btrace.c: Update.
1869         * c-varobj.c: Update.
1870         * cli/cli-cmds.c: Update.
1871         * cli/cli-interp.c: Update.
1872         * cli/cli-script.c: Update.
1873         * common/common-exceptions.c: Update.
1874         * common/new-op.c: Update.
1875         * common/selftest.c: Update.
1876         * compile/compile-c-symbols.c: Update.
1877         * compile/compile-cplus-symbols.c: Update.
1878         * compile/compile-object-load.c: Update.
1879         * compile/compile-object-run.c: Update.
1880         * completer.c: Update.
1881         * corelow.c: Update.
1882         * cp-abi.c: Update.
1883         * cp-support.c: Update.
1884         * cp-valprint.c: Update.
1885         * darwin-nat.c: Update.
1886         * disasm-selftests.c: Update.
1887         * dtrace-probe.c: Update.
1888         * dwarf-index-cache.c: Update.
1889         * dwarf-index-write.c: Update.
1890         * dwarf2-frame-tailcall.c: Update.
1891         * dwarf2-frame.c: Update.
1892         * dwarf2loc.c: Update.
1893         * dwarf2read.c: Update.
1894         * eval.c: Update.
1895         * event-loop.c: Update.
1896         * event-top.c: Update.
1897         * exec.c: Update.
1898         * f-valprint.c: Update.
1899         * fbsd-tdep.c: Update.
1900         * frame-unwind.c: Update.
1901         * frame.c: Update.
1902         * gdbtypes.c: Update.
1903         * gnu-v3-abi.c: Update.
1904         * guile/guile-internal.h: Update.
1905         * guile/scm-block.c: Update.
1906         * guile/scm-breakpoint.c: Update.
1907         * guile/scm-cmd.c: Update.
1908         * guile/scm-disasm.c: Update.
1909         * guile/scm-frame.c: Update.
1910         * guile/scm-lazy-string.c: Update.
1911         * guile/scm-math.c: Update.
1912         * guile/scm-param.c: Update.
1913         * guile/scm-ports.c: Update.
1914         * guile/scm-pretty-print.c: Update.
1915         * guile/scm-symbol.c: Update.
1916         * guile/scm-symtab.c: Update.
1917         * guile/scm-type.c: Update.
1918         * guile/scm-value.c: Update.
1919         * i386-linux-tdep.c: Update.
1920         * i386-tdep.c: Update.
1921         * inf-loop.c: Update.
1922         * infcall.c: Update.
1923         * infcmd.c: Update.
1924         * infrun.c: Update.
1925         * jit.c: Update.
1926         * language.c: Update.
1927         * linespec.c: Update.
1928         * linux-fork.c: Update.
1929         * linux-nat.c: Update.
1930         * linux-tdep.c: Update.
1931         * linux-thread-db.c: Update.
1932         * main.c: Update.
1933         * mi/mi-cmd-break.c: Update.
1934         * mi/mi-cmd-stack.c: Update.
1935         * mi/mi-interp.c: Update.
1936         * mi/mi-main.c: Update.
1937         * objc-lang.c: Update.
1938         * p-valprint.c: Update.
1939         * parse.c: Update.
1940         * ppc-linux-tdep.c: Update.
1941         * printcmd.c: Update.
1942         * python/py-arch.c: Update.
1943         * python/py-breakpoint.c: Update.
1944         * python/py-cmd.c: Update.
1945         * python/py-finishbreakpoint.c: Update.
1946         * python/py-frame.c: Update.
1947         * python/py-framefilter.c: Update.
1948         * python/py-gdb-readline.c: Update.
1949         * python/py-inferior.c: Update.
1950         * python/py-infthread.c: Update.
1951         * python/py-lazy-string.c: Update.
1952         * python/py-linetable.c: Update.
1953         * python/py-objfile.c: Update.
1954         * python/py-param.c: Update.
1955         * python/py-prettyprint.c: Update.
1956         * python/py-progspace.c: Update.
1957         * python/py-record-btrace.c: Update.
1958         * python/py-record.c: Update.
1959         * python/py-symbol.c: Update.
1960         * python/py-type.c: Update.
1961         * python/py-unwind.c: Update.
1962         * python/py-utils.c: Update.
1963         * python/py-value.c: Update.
1964         * python/python.c: Update.
1965         * record-btrace.c: Update.
1966         * record-full.c: Update.
1967         * remote-fileio.c: Update.
1968         * remote.c: Update.
1969         * riscv-tdep.c: Update.
1970         * rs6000-aix-tdep.c: Update.
1971         * rs6000-tdep.c: Update.
1972         * rust-exp.y: Update.
1973         * rust-lang.c: Update.
1974         * s390-tdep.c: Update.
1975         * selftest-arch.c: Update.
1976         * solib-dsbt.c: Update.
1977         * solib-frv.c: Update.
1978         * solib-spu.c: Update.
1979         * solib-svr4.c: Update.
1980         * solib.c: Update.
1981         * sparc64-linux-tdep.c: Update.
1982         * stack.c: Update.
1983         * symfile-mem.c: Update.
1984         * symmisc.c: Update.
1985         * target.c: Update.
1986         * thread.c: Update.
1987         * top.c: Update.
1988         * tracefile-tfile.c: Update.
1989         * tui/tui.c: Update.
1990         * typeprint.c: Update.
1991         * unittests/cli-utils-selftests.c: Update.
1992         * unittests/parse-connection-spec-selftests.c: Update.
1993         * valops.c: Update.
1994         * valprint.c: Update.
1995         * value.c: Update.
1996         * varobj.c: Update.
1997         * windows-nat.c: Update.
1998         * x86-linux-nat.c: Update.
1999         * xml-support.c: Update.
2000
2001 2019-04-08  Tom Tromey  <tom@tromey.com>
2002
2003         * xml-support.c: Use C++ exception handling.
2004         * x86-linux-nat.c: Use C++ exception handling.
2005         * windows-nat.c: Use C++ exception handling.
2006         * varobj.c: Use C++ exception handling.
2007         * value.c: Use C++ exception handling.
2008         * valprint.c: Use C++ exception handling.
2009         * valops.c: Use C++ exception handling.
2010         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2011         handling.
2012         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2013         * typeprint.c: Use C++ exception handling.
2014         * tui/tui.c: Use C++ exception handling.
2015         * tracefile-tfile.c: Use C++ exception handling.
2016         * top.c: Use C++ exception handling.
2017         * thread.c: Use C++ exception handling.
2018         * target.c: Use C++ exception handling.
2019         * symmisc.c: Use C++ exception handling.
2020         * symfile-mem.c: Use C++ exception handling.
2021         * stack.c: Use C++ exception handling.
2022         * sparc64-linux-tdep.c: Use C++ exception handling.
2023         * solib.c: Use C++ exception handling.
2024         * solib-svr4.c: Use C++ exception handling.
2025         * solib-spu.c: Use C++ exception handling.
2026         * solib-frv.c: Use C++ exception handling.
2027         * solib-dsbt.c: Use C++ exception handling.
2028         * selftest-arch.c: Use C++ exception handling.
2029         * s390-tdep.c: Use C++ exception handling.
2030         * rust-lang.c: Use C++ exception handling.
2031         * rust-exp.y: Use C++ exception handling.
2032         * rs6000-tdep.c: Use C++ exception handling.
2033         * rs6000-aix-tdep.c: Use C++ exception handling.
2034         * riscv-tdep.c: Use C++ exception handling.
2035         * remote.c: Use C++ exception handling.
2036         * remote-fileio.c: Use C++ exception handling.
2037         * record-full.c: Use C++ exception handling.
2038         * record-btrace.c: Use C++ exception handling.
2039         * python/python.c: Use C++ exception handling.
2040         * python/py-value.c: Use C++ exception handling.
2041         * python/py-utils.c: Use C++ exception handling.
2042         * python/py-unwind.c: Use C++ exception handling.
2043         * python/py-type.c: Use C++ exception handling.
2044         * python/py-symbol.c: Use C++ exception handling.
2045         * python/py-record.c: Use C++ exception handling.
2046         * python/py-record-btrace.c: Use C++ exception handling.
2047         * python/py-progspace.c: Use C++ exception handling.
2048         * python/py-prettyprint.c: Use C++ exception handling.
2049         * python/py-param.c: Use C++ exception handling.
2050         * python/py-objfile.c: Use C++ exception handling.
2051         * python/py-linetable.c: Use C++ exception handling.
2052         * python/py-lazy-string.c: Use C++ exception handling.
2053         * python/py-infthread.c: Use C++ exception handling.
2054         * python/py-inferior.c: Use C++ exception handling.
2055         * python/py-gdb-readline.c: Use C++ exception handling.
2056         * python/py-framefilter.c: Use C++ exception handling.
2057         * python/py-frame.c: Use C++ exception handling.
2058         * python/py-finishbreakpoint.c: Use C++ exception handling.
2059         * python/py-cmd.c: Use C++ exception handling.
2060         * python/py-breakpoint.c: Use C++ exception handling.
2061         * python/py-arch.c: Use C++ exception handling.
2062         * printcmd.c: Use C++ exception handling.
2063         * ppc-linux-tdep.c: Use C++ exception handling.
2064         * parse.c: Use C++ exception handling.
2065         * p-valprint.c: Use C++ exception handling.
2066         * objc-lang.c: Use C++ exception handling.
2067         * mi/mi-main.c: Use C++ exception handling.
2068         * mi/mi-interp.c: Use C++ exception handling.
2069         * mi/mi-cmd-stack.c: Use C++ exception handling.
2070         * mi/mi-cmd-break.c: Use C++ exception handling.
2071         * main.c: Use C++ exception handling.
2072         * linux-thread-db.c: Use C++ exception handling.
2073         * linux-tdep.c: Use C++ exception handling.
2074         * linux-nat.c: Use C++ exception handling.
2075         * linux-fork.c: Use C++ exception handling.
2076         * linespec.c: Use C++ exception handling.
2077         * language.c: Use C++ exception handling.
2078         * jit.c: Use C++ exception handling.
2079         * infrun.c: Use C++ exception handling.
2080         * infcmd.c: Use C++ exception handling.
2081         * infcall.c: Use C++ exception handling.
2082         * inf-loop.c: Use C++ exception handling.
2083         * i386-tdep.c: Use C++ exception handling.
2084         * i386-linux-tdep.c: Use C++ exception handling.
2085         * guile/scm-value.c: Use C++ exception handling.
2086         * guile/scm-type.c: Use C++ exception handling.
2087         * guile/scm-symtab.c: Use C++ exception handling.
2088         * guile/scm-symbol.c: Use C++ exception handling.
2089         * guile/scm-pretty-print.c: Use C++ exception handling.
2090         * guile/scm-ports.c: Use C++ exception handling.
2091         * guile/scm-param.c: Use C++ exception handling.
2092         * guile/scm-math.c: Use C++ exception handling.
2093         * guile/scm-lazy-string.c: Use C++ exception handling.
2094         * guile/scm-frame.c: Use C++ exception handling.
2095         * guile/scm-disasm.c: Use C++ exception handling.
2096         * guile/scm-cmd.c: Use C++ exception handling.
2097         * guile/scm-breakpoint.c: Use C++ exception handling.
2098         * guile/scm-block.c: Use C++ exception handling.
2099         * guile/guile-internal.h: Use C++ exception handling.
2100         * gnu-v3-abi.c: Use C++ exception handling.
2101         * gdbtypes.c: Use C++ exception handling.
2102         * frame.c: Use C++ exception handling.
2103         * frame-unwind.c: Use C++ exception handling.
2104         * fbsd-tdep.c: Use C++ exception handling.
2105         * f-valprint.c: Use C++ exception handling.
2106         * exec.c: Use C++ exception handling.
2107         * event-top.c: Use C++ exception handling.
2108         * event-loop.c: Use C++ exception handling.
2109         * eval.c: Use C++ exception handling.
2110         * dwarf2read.c: Use C++ exception handling.
2111         * dwarf2loc.c: Use C++ exception handling.
2112         * dwarf2-frame.c: Use C++ exception handling.
2113         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2114         * dwarf-index-write.c: Use C++ exception handling.
2115         * dwarf-index-cache.c: Use C++ exception handling.
2116         * dtrace-probe.c: Use C++ exception handling.
2117         * disasm-selftests.c: Use C++ exception handling.
2118         * darwin-nat.c: Use C++ exception handling.
2119         * cp-valprint.c: Use C++ exception handling.
2120         * cp-support.c: Use C++ exception handling.
2121         * cp-abi.c: Use C++ exception handling.
2122         * corelow.c: Use C++ exception handling.
2123         * completer.c: Use C++ exception handling.
2124         * compile/compile-object-run.c: Use C++ exception handling.
2125         * compile/compile-object-load.c: Use C++ exception handling.
2126         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2127         * compile/compile-c-symbols.c: Use C++ exception handling.
2128         * common/selftest.c: Use C++ exception handling.
2129         * common/new-op.c: Use C++ exception handling.
2130         * cli/cli-script.c: Use C++ exception handling.
2131         * cli/cli-interp.c: Use C++ exception handling.
2132         * cli/cli-cmds.c: Use C++ exception handling.
2133         * c-varobj.c: Use C++ exception handling.
2134         * btrace.c: Use C++ exception handling.
2135         * breakpoint.c: Use C++ exception handling.
2136         * break-catch-throw.c: Use C++ exception handling.
2137         * arch-utils.c: Use C++ exception handling.
2138         * amd64-tdep.c: Use C++ exception handling.
2139         * ada-valprint.c: Use C++ exception handling.
2140         * ada-typeprint.c: Use C++ exception handling.
2141         * ada-lang.c: Use C++ exception handling.
2142         * aarch64-tdep.c: Use C++ exception handling.
2143
2144 2019-04-08  Tom Tromey  <tom@tromey.com>
2145
2146         * xml-support.c (gdb_xml_parser::parse): Update.
2147         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2148         * value.c (show_convenience): Update.
2149         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2150         (test_parse_flags_qcs): Update.
2151         * thread.c (thr_try_catch_cmd): Update.
2152         * target.c (target_translate_tls_address): Update.
2153         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2154         (info_frame_command_core, frame_apply_command_count): Update.
2155         * rust-exp.y (rust_lex_exception_test): Update.
2156         * riscv-tdep.c (riscv_print_one_register_info): Update.
2157         * remote.c (remote_target::enable_btrace): Update.
2158         * record-btrace.c (record_btrace_enable_warn): Update.
2159         * python/py-utils.c (gdbpy_convert_exception): Update.
2160         * printcmd.c (do_one_display, print_variable_and_value): Update.
2161         * mi/mi-main.c (mi_print_exception): Update.
2162         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2163         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2164         * linux-nat.c (linux_nat_target::attach): Update.
2165         * linux-fork.c (class scoped_switch_fork_info): Update.
2166         * infrun.c (displaced_step_prepare): Update.
2167         * infcall.c (call_function_by_hand_dummy): Update.
2168         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2169         * gnu-v3-abi.c (print_one_vtable): Update.
2170         * frame.c (get_prev_frame_always): Update.
2171         * f-valprint.c (info_common_command_for_block): Update.
2172         * exec.c (try_open_exec_file): Update.
2173         * exceptions.c (print_exception, exception_print)
2174         (exception_fprintf, exception_print_same): Update.
2175         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2176         * dwarf-index-cache.c (index_cache::store)
2177         (index_cache::lookup_gdb_index): Update.
2178         * darwin-nat.c (maybe_cache_shell): Update.
2179         * cp-valprint.c (cp_print_value_fields): Update.
2180         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2181         (gcc_cplus_symbol_address): Update.
2182         * compile/compile-c-symbols.c (gcc_convert_symbol)
2183         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2184         * common/selftest.c: Update.
2185         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2186         a std::string.
2187         (exception_try_scope_entry, exception_try_scope_exit): Don't
2188         declare.
2189         (struct exception_try_scope): Remove.
2190         (TRY): Don't use exception_try_scope.
2191         (struct gdb_exception): Add constructor, operator=.
2192         <what>: New method.
2193         (struct gdb_exception_RETURN_MASK_ALL)
2194         (struct gdb_exception_RETURN_MASK_ERROR)
2195         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2196         (struct gdb_quit_bad_alloc): Update.
2197         * common/common-exceptions.c (exception_none): Change
2198         initializer.
2199         (struct catcher) <state, exception>: Initialize inline.
2200         <prev>: Remove member.
2201         (current_catcher): Remove.
2202         (catchers): New global.
2203         (exceptions_state_mc_init): Simplify.
2204         (catcher_pop): Remove.
2205         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2206         (try_scope_depth, exception_try_scope_entry)
2207         (exception_try_scope_exit): Remove.
2208         (throw_exception_sjlj): Update.
2209         (exception_messages, exception_messages_size): Remove.
2210         (throw_it): Simplify.
2211         (gdb_exception_sliced_copy): Remove.
2212         (throw_exception_cxx): Update.
2213         * cli/cli-script.c (script_from_file): Update.
2214         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2215         Update.
2216         * ada-valprint.c (ada_val_print): Update.
2217         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2218         (create_excep_cond_exprs): Update.
2219
2220 2019-04-08  Tom Tromey  <tom@tromey.com>
2221
2222         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2223         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2224         (TRY, CATCH, END_CATCH): Remove some definitions.
2225         * common/common-exceptions.c: Don't use GDB_XCPT.
2226         (catcher_list_size): Remove.
2227         (throw_exception, throw_it): Simplify.
2228
2229 2019-04-05  Tom Tromey  <tom@tromey.com>
2230
2231         Revert the header-sorting patch.
2232         * ft32-tdep.c: Revert.
2233         * frv-tdep.c: Revert.
2234         * frv-linux-tdep.c: Revert.
2235         * frame.c: Revert.
2236         * frame-unwind.c: Revert.
2237         * frame-base.c: Revert.
2238         * fork-child.c: Revert.
2239         * findvar.c: Revert.
2240         * findcmd.c: Revert.
2241         * filesystem.c: Revert.
2242         * filename-seen-cache.h: Revert.
2243         * filename-seen-cache.c: Revert.
2244         * fbsd-tdep.c: Revert.
2245         * fbsd-nat.h: Revert.
2246         * fbsd-nat.c: Revert.
2247         * f-valprint.c: Revert.
2248         * f-typeprint.c: Revert.
2249         * f-lang.c: Revert.
2250         * extension.h: Revert.
2251         * extension.c: Revert.
2252         * extension-priv.h: Revert.
2253         * expprint.c: Revert.
2254         * exec.h: Revert.
2255         * exec.c: Revert.
2256         * exceptions.c: Revert.
2257         * event-top.c: Revert.
2258         * event-loop.c: Revert.
2259         * eval.c: Revert.
2260         * elfread.c: Revert.
2261         * dwarf2read.h: Revert.
2262         * dwarf2read.c: Revert.
2263         * dwarf2loc.c: Revert.
2264         * dwarf2expr.h: Revert.
2265         * dwarf2expr.c: Revert.
2266         * dwarf2-frame.c: Revert.
2267         * dwarf2-frame-tailcall.c: Revert.
2268         * dwarf-index-write.h: Revert.
2269         * dwarf-index-write.c: Revert.
2270         * dwarf-index-common.c: Revert.
2271         * dwarf-index-cache.h: Revert.
2272         * dwarf-index-cache.c: Revert.
2273         * dummy-frame.c: Revert.
2274         * dtrace-probe.c: Revert.
2275         * disasm.h: Revert.
2276         * disasm.c: Revert.
2277         * disasm-selftests.c: Revert.
2278         * dictionary.c: Revert.
2279         * dicos-tdep.c: Revert.
2280         * demangle.c: Revert.
2281         * dcache.h: Revert.
2282         * dcache.c: Revert.
2283         * darwin-nat.h: Revert.
2284         * darwin-nat.c: Revert.
2285         * darwin-nat-info.c: Revert.
2286         * d-valprint.c: Revert.
2287         * d-namespace.c: Revert.
2288         * d-lang.c: Revert.
2289         * ctf.c: Revert.
2290         * csky-tdep.c: Revert.
2291         * csky-linux-tdep.c: Revert.
2292         * cris-tdep.c: Revert.
2293         * cris-linux-tdep.c: Revert.
2294         * cp-valprint.c: Revert.
2295         * cp-support.c: Revert.
2296         * cp-namespace.c: Revert.
2297         * cp-abi.c: Revert.
2298         * corelow.c: Revert.
2299         * corefile.c: Revert.
2300         * continuations.c: Revert.
2301         * completer.h: Revert.
2302         * completer.c: Revert.
2303         * complaints.c: Revert.
2304         * coffread.c: Revert.
2305         * coff-pe-read.c: Revert.
2306         * cli-out.h: Revert.
2307         * cli-out.c: Revert.
2308         * charset.c: Revert.
2309         * c-varobj.c: Revert.
2310         * c-valprint.c: Revert.
2311         * c-typeprint.c: Revert.
2312         * c-lang.c: Revert.
2313         * buildsym.c: Revert.
2314         * buildsym-legacy.c: Revert.
2315         * build-id.h: Revert.
2316         * build-id.c: Revert.
2317         * btrace.c: Revert.
2318         * bsd-uthread.c: Revert.
2319         * breakpoint.h: Revert.
2320         * breakpoint.c: Revert.
2321         * break-catch-throw.c: Revert.
2322         * break-catch-syscall.c: Revert.
2323         * break-catch-sig.c: Revert.
2324         * blockframe.c: Revert.
2325         * block.c: Revert.
2326         * bfin-tdep.c: Revert.
2327         * bfin-linux-tdep.c: Revert.
2328         * bfd-target.c: Revert.
2329         * bcache.c: Revert.
2330         * ax-general.c: Revert.
2331         * ax-gdb.h: Revert.
2332         * ax-gdb.c: Revert.
2333         * avr-tdep.c: Revert.
2334         * auxv.c: Revert.
2335         * auto-load.c: Revert.
2336         * arm-wince-tdep.c: Revert.
2337         * arm-tdep.c: Revert.
2338         * arm-symbian-tdep.c: Revert.
2339         * arm-pikeos-tdep.c: Revert.
2340         * arm-obsd-tdep.c: Revert.
2341         * arm-nbsd-tdep.c: Revert.
2342         * arm-nbsd-nat.c: Revert.
2343         * arm-linux-tdep.c: Revert.
2344         * arm-linux-nat.c: Revert.
2345         * arm-fbsd-tdep.c: Revert.
2346         * arm-fbsd-nat.c: Revert.
2347         * arm-bsd-tdep.c: Revert.
2348         * arch-utils.c: Revert.
2349         * arc-tdep.c: Revert.
2350         * arc-newlib-tdep.c: Revert.
2351         * annotate.h: Revert.
2352         * annotate.c: Revert.
2353         * amd64-windows-tdep.c: Revert.
2354         * amd64-windows-nat.c: Revert.
2355         * amd64-tdep.c: Revert.
2356         * amd64-sol2-tdep.c: Revert.
2357         * amd64-obsd-tdep.c: Revert.
2358         * amd64-obsd-nat.c: Revert.
2359         * amd64-nbsd-tdep.c: Revert.
2360         * amd64-nbsd-nat.c: Revert.
2361         * amd64-nat.c: Revert.
2362         * amd64-linux-tdep.c: Revert.
2363         * amd64-linux-nat.c: Revert.
2364         * amd64-fbsd-tdep.c: Revert.
2365         * amd64-fbsd-nat.c: Revert.
2366         * amd64-dicos-tdep.c: Revert.
2367         * amd64-darwin-tdep.c: Revert.
2368         * amd64-bsd-nat.c: Revert.
2369         * alpha-tdep.c: Revert.
2370         * alpha-obsd-tdep.c: Revert.
2371         * alpha-nbsd-tdep.c: Revert.
2372         * alpha-mdebug-tdep.c: Revert.
2373         * alpha-linux-tdep.c: Revert.
2374         * alpha-linux-nat.c: Revert.
2375         * alpha-bsd-tdep.c: Revert.
2376         * alpha-bsd-nat.c: Revert.
2377         * aix-thread.c: Revert.
2378         * agent.c: Revert.
2379         * addrmap.c: Revert.
2380         * ada-varobj.c: Revert.
2381         * ada-valprint.c: Revert.
2382         * ada-typeprint.c: Revert.
2383         * ada-tasks.c: Revert.
2384         * ada-lang.c: Revert.
2385         * aarch64-tdep.c: Revert.
2386         * aarch64-ravenscar-thread.c: Revert.
2387         * aarch64-newlib-tdep.c: Revert.
2388         * aarch64-linux-tdep.c: Revert.
2389         * aarch64-linux-nat.c: Revert.
2390         * aarch64-fbsd-tdep.c: Revert.
2391         * aarch64-fbsd-nat.c: Revert.
2392         * aarch32-linux-nat.c: Revert.
2393
2394 2019-04-05  Tom Tromey  <tom@tromey.com>
2395
2396         * ft32-tdep.c: Sort headers.
2397         * frv-tdep.c: Sort headers.
2398         * frv-linux-tdep.c: Sort headers.
2399         * frame.c: Sort headers.
2400         * frame-unwind.c: Sort headers.
2401         * frame-base.c: Sort headers.
2402         * fork-child.c: Sort headers.
2403         * findvar.c: Sort headers.
2404         * findcmd.c: Sort headers.
2405         * filesystem.c: Sort headers.
2406         * filename-seen-cache.h: Sort headers.
2407         * filename-seen-cache.c: Sort headers.
2408         * fbsd-tdep.c: Sort headers.
2409         * fbsd-nat.h: Sort headers.
2410         * fbsd-nat.c: Sort headers.
2411         * f-valprint.c: Sort headers.
2412         * f-typeprint.c: Sort headers.
2413         * f-lang.c: Sort headers.
2414         * extension.h: Sort headers.
2415         * extension.c: Sort headers.
2416         * extension-priv.h: Sort headers.
2417         * expprint.c: Sort headers.
2418         * exec.h: Sort headers.
2419         * exec.c: Sort headers.
2420         * exceptions.c: Sort headers.
2421         * event-top.c: Sort headers.
2422         * event-loop.c: Sort headers.
2423         * eval.c: Sort headers.
2424         * elfread.c: Sort headers.
2425         * dwarf2read.h: Sort headers.
2426         * dwarf2read.c: Sort headers.
2427         * dwarf2loc.c: Sort headers.
2428         * dwarf2expr.h: Sort headers.
2429         * dwarf2expr.c: Sort headers.
2430         * dwarf2-frame.c: Sort headers.
2431         * dwarf2-frame-tailcall.c: Sort headers.
2432         * dwarf-index-write.h: Sort headers.
2433         * dwarf-index-write.c: Sort headers.
2434         * dwarf-index-common.c: Sort headers.
2435         * dwarf-index-cache.h: Sort headers.
2436         * dwarf-index-cache.c: Sort headers.
2437         * dummy-frame.c: Sort headers.
2438         * dtrace-probe.c: Sort headers.
2439         * disasm.h: Sort headers.
2440         * disasm.c: Sort headers.
2441         * disasm-selftests.c: Sort headers.
2442         * dictionary.c: Sort headers.
2443         * dicos-tdep.c: Sort headers.
2444         * demangle.c: Sort headers.
2445         * dcache.h: Sort headers.
2446         * dcache.c: Sort headers.
2447         * darwin-nat.h: Sort headers.
2448         * darwin-nat.c: Sort headers.
2449         * darwin-nat-info.c: Sort headers.
2450         * d-valprint.c: Sort headers.
2451         * d-namespace.c: Sort headers.
2452         * d-lang.c: Sort headers.
2453         * ctf.c: Sort headers.
2454         * csky-tdep.c: Sort headers.
2455         * csky-linux-tdep.c: Sort headers.
2456         * cris-tdep.c: Sort headers.
2457         * cris-linux-tdep.c: Sort headers.
2458         * cp-valprint.c: Sort headers.
2459         * cp-support.c: Sort headers.
2460         * cp-namespace.c: Sort headers.
2461         * cp-abi.c: Sort headers.
2462         * corelow.c: Sort headers.
2463         * corefile.c: Sort headers.
2464         * continuations.c: Sort headers.
2465         * completer.h: Sort headers.
2466         * completer.c: Sort headers.
2467         * complaints.c: Sort headers.
2468         * coffread.c: Sort headers.
2469         * coff-pe-read.c: Sort headers.
2470         * cli-out.h: Sort headers.
2471         * cli-out.c: Sort headers.
2472         * charset.c: Sort headers.
2473         * c-varobj.c: Sort headers.
2474         * c-valprint.c: Sort headers.
2475         * c-typeprint.c: Sort headers.
2476         * c-lang.c: Sort headers.
2477         * buildsym.c: Sort headers.
2478         * buildsym-legacy.c: Sort headers.
2479         * build-id.h: Sort headers.
2480         * build-id.c: Sort headers.
2481         * btrace.c: Sort headers.
2482         * bsd-uthread.c: Sort headers.
2483         * breakpoint.h: Sort headers.
2484         * breakpoint.c: Sort headers.
2485         * break-catch-throw.c: Sort headers.
2486         * break-catch-syscall.c: Sort headers.
2487         * break-catch-sig.c: Sort headers.
2488         * blockframe.c: Sort headers.
2489         * block.c: Sort headers.
2490         * bfin-tdep.c: Sort headers.
2491         * bfin-linux-tdep.c: Sort headers.
2492         * bfd-target.c: Sort headers.
2493         * bcache.c: Sort headers.
2494         * ax-general.c: Sort headers.
2495         * ax-gdb.h: Sort headers.
2496         * ax-gdb.c: Sort headers.
2497         * avr-tdep.c: Sort headers.
2498         * auxv.c: Sort headers.
2499         * auto-load.c: Sort headers.
2500         * arm-wince-tdep.c: Sort headers.
2501         * arm-tdep.c: Sort headers.
2502         * arm-symbian-tdep.c: Sort headers.
2503         * arm-pikeos-tdep.c: Sort headers.
2504         * arm-obsd-tdep.c: Sort headers.
2505         * arm-nbsd-tdep.c: Sort headers.
2506         * arm-nbsd-nat.c: Sort headers.
2507         * arm-linux-tdep.c: Sort headers.
2508         * arm-linux-nat.c: Sort headers.
2509         * arm-fbsd-tdep.c: Sort headers.
2510         * arm-fbsd-nat.c: Sort headers.
2511         * arm-bsd-tdep.c: Sort headers.
2512         * arch-utils.c: Sort headers.
2513         * arc-tdep.c: Sort headers.
2514         * arc-newlib-tdep.c: Sort headers.
2515         * annotate.h: Sort headers.
2516         * annotate.c: Sort headers.
2517         * amd64-windows-tdep.c: Sort headers.
2518         * amd64-windows-nat.c: Sort headers.
2519         * amd64-tdep.c: Sort headers.
2520         * amd64-sol2-tdep.c: Sort headers.
2521         * amd64-obsd-tdep.c: Sort headers.
2522         * amd64-obsd-nat.c: Sort headers.
2523         * amd64-nbsd-tdep.c: Sort headers.
2524         * amd64-nbsd-nat.c: Sort headers.
2525         * amd64-nat.c: Sort headers.
2526         * amd64-linux-tdep.c: Sort headers.
2527         * amd64-linux-nat.c: Sort headers.
2528         * amd64-fbsd-tdep.c: Sort headers.
2529         * amd64-fbsd-nat.c: Sort headers.
2530         * amd64-dicos-tdep.c: Sort headers.
2531         * amd64-darwin-tdep.c: Sort headers.
2532         * amd64-bsd-nat.c: Sort headers.
2533         * alpha-tdep.c: Sort headers.
2534         * alpha-obsd-tdep.c: Sort headers.
2535         * alpha-nbsd-tdep.c: Sort headers.
2536         * alpha-mdebug-tdep.c: Sort headers.
2537         * alpha-linux-tdep.c: Sort headers.
2538         * alpha-linux-nat.c: Sort headers.
2539         * alpha-bsd-tdep.c: Sort headers.
2540         * alpha-bsd-nat.c: Sort headers.
2541         * aix-thread.c: Sort headers.
2542         * agent.c: Sort headers.
2543         * addrmap.c: Sort headers.
2544         * ada-varobj.c: Sort headers.
2545         * ada-valprint.c: Sort headers.
2546         * ada-typeprint.c: Sort headers.
2547         * ada-tasks.c: Sort headers.
2548         * ada-lang.c: Sort headers.
2549         * aarch64-tdep.c: Sort headers.
2550         * aarch64-ravenscar-thread.c: Sort headers.
2551         * aarch64-newlib-tdep.c: Sort headers.
2552         * aarch64-linux-tdep.c: Sort headers.
2553         * aarch64-linux-nat.c: Sort headers.
2554         * aarch64-fbsd-tdep.c: Sort headers.
2555         * aarch64-fbsd-nat.c: Sort headers.
2556         * aarch32-linux-nat.c: Sort headers.
2557
2558 2019-04-04  Tom Tromey  <tom@tromey.com>
2559
2560         * varobj.c (varobj_create): Update.
2561         * rust-exp.y (struct rust_parser) <update_innermost_block,
2562         lookup_symbol>: New methods.
2563         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2564         Rename.
2565         (rust_parser::rust_lookup_type)
2566         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2567         * printcmd.c (display_command, do_one_display): Update.
2568         * parser-defs.h (struct parser_state) <parser_state>: Add
2569         "tracker" parameter.
2570         (block_tracker): New member.
2571         (class innermost_block_tracker) <innermost_block_tracker>: Add
2572         "types" parameter.
2573         <reset>: Remove method.
2574         (innermost_block): Don't declare.
2575         (null_post_parser): Update.
2576         * parse.c (innermost_block): Remove global.
2577         (write_dollar_variable): Update.
2578         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2579         Remove "tracker_types" parameter.
2580         (parse_expression): Add "tracker" parameter.
2581         (parse_expression_for_completion): Update.
2582         (null_post_parser): Add "tracker" parameter.
2583         * p-exp.y: Update rules.
2584         * m2-exp.y: Update rules.
2585         * language.h (struct language_defn) <la_post_parser>: Add
2586         "tracker" parameter.
2587         * go-exp.y: Update rules.
2588         * f-exp.y: Update rules.
2589         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2590         parameter.
2591         * d-exp.y: Update rules.
2592         * c-exp.y: Update rules.
2593         * breakpoint.c (set_breakpoint_condition): Create an
2594         innermost_block_tracker.
2595         (watch_command_1): Likewise.
2596         * ada-lang.c (resolve): Add "tracker" parameter.
2597         (resolve_subexp): Likewise.
2598         * ada-exp.y (write_var_from_sym): Update.
2599
2600 2019-04-04  Tom Tromey  <tom@tromey.com>
2601
2602         * type-stack.h: New file.
2603         * type-stack.c: New file.
2604         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2605         type-stack.h.
2606         (insert_into_type_stack, insert_type, push_type, push_type_int)
2607         (insert_type_address_space, pop_type, pop_type_int)
2608         (pop_typelist, pop_type_stack, append_type_stack)
2609         (push_type_stack, get_type_stack, push_typelist)
2610         (follow_type_instance_flags, follow_types): Don't declare.
2611         * parse.c (type_stack): Remove global.
2612         (parse_exp_in_context): Update.
2613         (insert_into_type_stack, insert_type, push_type, push_type_int)
2614         (insert_type_address_space, pop_type, pop_type_int)
2615         (pop_typelist, pop_type_stack, append_type_stack)
2616         (push_type_stack, get_type_stack, push_typelist)
2617         (follow_type_instance_flags, follow_types): Remove (moved to
2618         type-stack.c).
2619         * f-exp.y (type_stack): New global.
2620         Update rules.
2621         (push_kind_type, f_parse): Update.
2622         * d-exp.y (type_stack): New global.
2623         Update rules.
2624         (d_parse): Update.
2625         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2626         Update rules.
2627         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2628         (HFILES_NO_SRCDIR): Add type-stack.h.
2629
2630 2019-04-04  Tom Tromey  <tom@tromey.com>
2631
2632         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2633         (rust_parser::convert_ast_to_expression, rust_parse)
2634         (rust_lex_test_completion, rust_lex_tests): Update.
2635         * parser-defs.h (struct expr_completion_state): New.
2636         (struct parser_state) <parser_state>: Add completion parameter.
2637         <mark_struct_expression, mark_completion_tag>: New methods.
2638         <parse_completion, m_completion_state>: New members.
2639         (prefixify_expression, null_post_parser): Update.
2640         (mark_struct_expression, mark_completion_tag): Don't declare.
2641         * parse.c (parse_completion, expout_last_struct)
2642         (expout_tag_completion_type, expout_completion_name): Remove
2643         globals.
2644         (parser_state::mark_struct_expression)
2645         (parser_state::mark_completion_tag): Now methods.
2646         (prefixify_expression): Add last_struct parameter.
2647         (prefixify_subexp): Likewise.
2648         (parse_exp_1): Update.
2649         (parse_exp_in_context): Add cstate parameter.  Update.
2650         (parse_expression_for_completion): Create an
2651         expr_completion_state.
2652         (null_post_parser): Add "completion" parameter.
2653         * p-exp.y: Update rules.
2654         (yylex): Update.
2655         * language.h (struct language_defn) <la_post_parser>: Add
2656         "completing" parameter.
2657         * go-exp.y: Update rules.
2658         (lex_one_token): Update.
2659         * expression.h (parse_completion): Don't declare.
2660         * d-exp.y: Update rules.
2661         (lex_one_token): Update rules.
2662         * c-exp.y: Update rules.
2663         (lex_one_token): Update.
2664         * ada-lang.c (resolve): Add "parse_completion" parameter.
2665         (resolve_subexp): Likewise.
2666         (ada_resolve_function): Likewise.
2667
2668 2019-04-04  Tom Tromey  <tom@tromey.com>
2669
2670         * parser-defs.h (struct parser_state) <start_arglist,
2671         end_arglist>: New methods.
2672         <arglist_len, m_funcall_chain>: New members.
2673         (arglist_len, start_arglist, end_arglist): Don't declare.
2674         * parse.c (arglist_len, funcall_chain): Remove global.
2675         (start_arglist, end_arglist): Remove functions.
2676         (parse_exp_in_context): Update.
2677         * p-exp.y: Update rules.
2678         * m2-exp.y: Update rules.
2679         * go-exp.y: Update rules.
2680         * f-exp.y: Update rules.
2681         * d-exp.y: Update rules.
2682         * c-exp.y: Update rules.
2683
2684 2019-04-04  Tom Tromey  <tom@tromey.com>
2685
2686         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2687         lex_operator, push_back>: New methods.
2688         Update all rules.
2689         (rust_parser::lex_hex, lex_escape): Rename and update.
2690         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2691         (rust_parser::lex_operator): Rename and update.
2692         (rust_parser::lex_number, rustyylex, rustyyerror)
2693         (rust_lex_test_init, rust_lex_test_sequence)
2694         (rust_lex_test_push_back, rust_lex_tests): Update.
2695         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2696         parameter.
2697         <lexptr, prev_lexptr>: New members.
2698         (lexptr, prev_lexptr): Don't declare.
2699         * parse.c (lexptr, prev_lexptr): Remove globals.
2700         (parse_exp_in_context): Update.
2701         * p-exp.y (yylex, yyerror): Update.
2702         * m2-exp.y (parse_number, yylex, yyerror): Update.
2703         * go-exp.y (lex_one_token, yyerror): Update.
2704         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2705         * d-exp.y (lex_one_token, yyerror): Update.
2706         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2707         (lex_one_token, yyerror): Update.
2708         * ada-lex.l (YY_INPUT): Update.
2709         (rewind_to_char): Update.
2710         * ada-exp.y (yyerror): Update.
2711
2712 2019-04-04  Tom Tromey  <tom@tromey.com>
2713
2714         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2715         * parser-defs.h (struct parser_state) <parser_state>: Add new
2716         parameter.
2717         <comma_terminates>: New member.
2718         (comma_terminates): Don't declare global.
2719         * parse.c (comma_terminates): Remove global.
2720         (parse_exp_in_context): Update.
2721         * p-exp.y (yylex): Update.
2722         * m2-exp.y (yylex): Update.
2723         * go-exp.y (lex_one_token): Update.
2724         * f-exp.y (yylex): Update.
2725         * d-exp.y (lex_one_token): Update.
2726         * c-exp.y (lex_one_token): Update.
2727         * ada-lex.l: Update.
2728
2729 2019-04-04  Tom Tromey  <tom@tromey.com>
2730
2731         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2732         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2733         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2734         * parser-defs.h (paren_depth): Don't declare.
2735         * parse.c (paren_depth): Remove global.
2736         (parse_exp_in_context): Update.
2737         * p-exp.y (paren_depth): New global.
2738         (pascal_parse): Initialize it.
2739         * m2-exp.y (paren_depth): New global.
2740         (m2_parse): Initialize it.
2741         * go-exp.y (paren_depth): New global.
2742         (go_parse): Initialize it.
2743         * f-exp.y (paren_depth): New global.
2744         (f_parse): Initialize it.
2745         * d-exp.y (paren_depth): New global.
2746         (d_parse): Initialize it.
2747         * c-exp.y (paren_depth): New global.
2748         (c_parse): Initialize it.
2749         * ada-lex.l (paren_depth): New global.
2750         (lexer_init): Initialize it.
2751
2752 2019-04-04  Tom Tromey  <tom@tromey.com>
2753
2754         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2755         (rust_parser::convert_ast_to_type)
2756         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2757         * parser-defs.h (struct parser_state) <parser_state>: Add
2758         parameters.  Initialize new members.
2759         <expression_context_block, expression_context_pc>: New members.
2760         * parse.c (expression_context_block, expression_context_pc):
2761         Remove globals.
2762         (parse_exp_in_context): Update.
2763         * p-exp.y: Update all rules.
2764         (yylex): Update.
2765         * m2-exp.y: Update all rules.
2766         (yylex): Update.
2767         * go-exp.y (yylex): Update.
2768         * f-exp.y (yylex): Update.
2769         * d-exp.y: Update all rules.
2770         (yylex): Update.
2771         * c-exp.y: Update all rules.
2772         (lex_one_token, classify_name, yylex, c_parse): Update.
2773         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2774
2775 2019-04-04  Tom Tromey  <tom@tromey.com>
2776
2777         * gdbarch.h, gdbarch.c: Rebuild.
2778         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2779         * stap-probe.h:
2780         (struct stap_parse_info): Replace "parser_state" with
2781         "expr_builder".
2782         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2783         (parser_state): New class.
2784         * parse.c (expr_builder): Rename.
2785         (expr_builder::release): Rename.
2786         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2787         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2788         (write_exp_elt_longcst, write_exp_elt_floatcst)
2789         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2790         (write_exp_string_vector, write_exp_bitstring)
2791         (write_exp_msymbol, mark_struct_expression)
2792         (write_dollar_variable)
2793         (insert_type_address_space, increase_expout_size): Replace
2794         "parser_state" with "expr_builder".
2795         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2796         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2797         "parser_state" with "expr_builder".
2798
2799 2019-04-04  Tom Tromey  <tom@tromey.com>
2800
2801         * rust-exp.y: Replace "parse_language" with method call.
2802         * p-exp.y:
2803         (yylex): Replace "parse_language" with method call.
2804         * m2-exp.y:
2805         (yylex): Replace "parse_language" with method call.
2806         * go-exp.y (classify_name): Replace "parse_language" with method
2807         call.
2808         * f-exp.y (yylex): Replace "parse_language" with method call.
2809         * d-exp.y (lex_one_token): Replace "parse_language" with method
2810         call.
2811         * c-exp.y:
2812         (lex_one_token, classify_name, yylex): Replace "parse_language"
2813         with method call.
2814         * ada-exp.y (find_primitive_type, type_char)
2815         (type_system_address): Replace "parse_language" with method call.
2816
2817 2019-04-04  Tom Tromey  <tom@tromey.com>
2818
2819         * rust-exp.y: Replace "parse_gdbarch" with method call.
2820         * parse.c (write_dollar_variable, insert_type_address_space):
2821         Replace "parse_gdbarch" with method call.
2822         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2823         call.
2824         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2825         call.
2826         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2827         "parse_gdbarch" with method call.
2828         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2829         with method call.
2830         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2831         "parse_gdbarch" with method call.
2832         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2833         "parse_gdbarch" with method call.
2834         * c-exp.y (parse_type, parse_number, classify_name): Replace
2835         "parse_gdbarch" with method call.
2836         * ada-lex.l: Replace "parse_gdbarch" with method call.
2837         * ada-exp.y (parse_type, find_primitive_type, type_char)
2838         (type_system_address): Replace "parse_gdbarch" with method call.
2839
2840 2019-04-04  Tom Tromey  <tom@tromey.com>
2841
2842         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2843         * stap-probe.c (stap_parse_argument): Update.
2844         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2845         initial_size parameter.
2846         * rust-exp.y (rust_lex_tests): Update.
2847         * parse.c (parser_state): Update.
2848         (parse_exp_in_context): Update.
2849         * parser-defs.h (struct parser_state) <parser_state>: Remove
2850         "initial_size" parameter.
2851
2852 2019-04-04  Tom Tromey  <tom@tromey.com>
2853
2854         * parser-defs.h (increase_expout_size): Don't declare.
2855         * parse.c (increase_expout_size): Now static.
2856
2857 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2858
2859         * gnu-nat.c (gnu_nat_target::wait): Fix
2860         target_waitstatus_to_string call.
2861
2862 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * eval.c (evaluate_subexp_standard): Handle internal functions
2865         during Fortran function call handling.
2866
2867 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2868
2869         * NEWS: Mention new internal functions.
2870         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2871         (read_base_type): Use dwarf2_init_complex_target_type.
2872         * value.c (creal_internal_fn): New function.
2873         (cimag_internal_fn): New function.
2874         (_initialize_values): Register new internal functions.
2875
2876 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2877
2878         * infrun.c (stop_all_threads): If debug_infrun, always
2879         trace the wait status after wait_one, using
2880         target_waitstatus_to_string and target_pid_to_str.
2881         (handle_inferior_event): Replace various trace of
2882         wait status kind by a single trace.
2883         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2884         wait status kind image by target_waitstatus_to_string.
2885         * target/waitstatus.c (target_waitstatus_to_string): Fix
2886         obsolete comment.
2887
2888 2019-04-01  Tom Tromey  <tromey@adacore.com>
2889
2890         PR symtab/23331:
2891         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2892
2893 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2894             Pedro Alves  <palves@redhat.com>
2895
2896         * top.c (quit_force): Call 'finalize_values'.
2897         * value.c (finalize_values): New function.
2898         * value.h (finalize_values): Declare.
2899
2900 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2901
2902         * NEWS: Announce $_gdb_major and $_gdb_minor.
2903
2904         * top.c (init_gdb_version_vars): New function.
2905         (gdb_init): Call init_gdb_version_vars.
2906
2907 2019-03-29  Tom Tromey  <tromey@adacore.com>
2908
2909         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2910         help text.  Remove dead code.
2911
2912 2019-03-29  Keith Seitz  <keiths@redhat.com>
2913
2914         From Siddhesh Poyarekar:
2915         * f-lang.h (f77_get_upperbound): Return LONGEST.
2916         (f77_get_lowerbound): Likewise.
2917         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2918         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2919         print them.
2920         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2921         plongest to format print it.
2922         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2923         (f77_get_upperbound): Likewise.
2924         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2925         LOWER_BOUND to LONGEST.
2926         (f77_create_arrayprint_offset_tbl): Likewise.
2927
2928 2019-03-29  Keith Seitz  <keiths@redhat.com>
2929
2930         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2931         %s/pulongest for TYPE_LENGTH instead of %d in format
2932         strings.
2933         * ada-typerint.c (ada_print_type): Likewise.
2934         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2935         * compile/compile-c-support.c (generate_register_struct): Likewise.
2936         * gdbtypes.c (recursive_dump_type): Likewise.
2937         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2938         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2939         instead of %d in format strings.
2940         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2941         to std::min to ULONGEST.
2942         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2943         instead of %d in format strings.
2944         * tracepoint.c (info_scope_command): Likewise.
2945         * typeprint.c (print_offset_data::update)
2946         (print_offset_data::finish): Likewise.
2947         * xtensa-tdep.c (xtensa_store_return_value)
2948         (xtensa_push_dummy_call): Likewise.
2949
2950 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2951
2952         * windows-nat.c (display_selector): Fixed format specifications
2953         for 64-bit Cygwin.
2954
2955 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2956
2957         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2958
2959 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2960
2961         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2962         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2963         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2964         (nios2_linux_init_abi): Install it.
2965
2966 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2967
2968         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2969
2970 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2971
2972         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2973
2974 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975             Tom Tromey  <tromey@adacore.com>
2976
2977         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2978
2979 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2980
2981         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2982         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2983         method to compute the bounds of range types. Also print "[evaluated]"
2984         if the bounds' values come from a dynamic evaluation.
2985
2986 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2987
2988         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2989         whitespace when pretty printing is on.
2990
2991 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2992
2993         * ppc-linux-nat.c: Add include.
2994
2995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2996
2997         * NEWS: Mention AArch64 Pointer Authentication.
2998
2999 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3000
3001         * arm-linux-nat.c: Add include.
3002
3003 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3004
3005         * source-cache.c (source_cache::get_source_lines): Re-read
3006         fullname after calling open_source_file.
3007
3008 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3009
3010         * NEWS: Mention TLS support for FreeBSD.
3011
3012 2019-03-25  Tom Tromey  <tromey@adacore.com>
3013
3014         * minsyms.c (BUNCH_SIZE): Update comment.
3015         (~minimal_symbol_reader): Remove old comment.
3016         (compact_minimal_symbols): Update comment.
3017         (minimal_symbol_reader::install): Remove old comment.  Update
3018         other comments.
3019
3020 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3021
3022         * s390-linux-nat.c: Add include.
3023
3024 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3025
3026         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3027         Call linux_get_hwcap.
3028         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3029         Likewise.
3030         (aarch64_linux_get_hwcap): Remove function.
3031         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3032         declaration.
3033         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3034         linux_get_hwcap.
3035         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3036         * linux-tdep.c (linux_get_hwcap): Add function.
3037         (linux_get_hwcap2): Likewise.
3038         * linux-tdep.h (linux_get_hwcap): Add declaration.
3039         (linux_get_hwcap2): Likewise.
3040         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3041         (ppc_linux_get_hwcap2): Likewise.
3042         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3043         linux_get_hwcap.
3044         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3045         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3046         (ppc_linux_nat_target::read_description): Likewise.
3047         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3048         * s390-linux-nat.c: Likewise.
3049         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3050
3051 2019-03-24  Tom Tromey  <tom@tromey.com>
3052
3053         * ada-lang.c (standard_lookup): Simplify initialization.
3054         (ada_lookup_symbol_nonlocal): Simplify return.
3055         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3056         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3057         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3058         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3059         initialization.
3060         * solib.c (solib_global_lookup): Simplify.
3061         * symtab.c (null_block_symbol): Remove.
3062         (symbol_cache_lookup): Simplify returns.
3063         (lookup_language_this): Simplify returns.
3064         (lookup_symbol_aux): Simplify return.
3065         (lookup_local_symbol): Simplify returns.
3066         (lookup_global_symbol_from_objfile): Simplify return.
3067         (lookup_symbol_in_objfile_symtabs)
3068         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3069         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3070         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3071         * cp-namespace.c (cp_lookup_bare_symbol)
3072         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3073         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3074         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3075         (cp_lookup_symbol_via_imports): Simplify initialization.
3076         (find_symbol_in_baseclass): Likewise.
3077         * symtab.h (null_block_symbol): Remove.
3078         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3079         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3080         (d_lookup_symbol_module): Likewise.
3081         (find_symbol_in_baseclass): Simplify initialization.
3082
3083 2019-03-24  Tom Tromey  <tom@tromey.com>
3084
3085         * expression.h: Don't include symtab.h.
3086         (struct block): Forward declare.
3087
3088 2019-03-24  Tom Tromey  <tom@tromey.com>
3089
3090         * c-exp.y (typebase): Remove casts.
3091         * gdbtypes.c (lookup_unsigned_typename, )
3092         (lookup_signed_typename): Remove cast.
3093         * eval.c (parse_to_comma_and_eval): Remove cast.
3094         * parse.c (write_dollar_variable): Remove cast.
3095         * block.h (struct block) <superblock>: Now const.
3096         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3097         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3098         (map_block): Make "block" const.
3099         * symfile.h (struct quick_symbol_functions)
3100         <map_matching_symbols>: Constify block argument to "callback".
3101         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3102         const.
3103         (find_pc_sect_compunit_symtab): Make "b" const.
3104         (find_symbol_at_address): Likewise.
3105         (search_symbols): Likewise.
3106         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3107         (dw2_debug_names_lookup_symbol): Likewise.
3108         (dw2_map_matching_symbols): Update.
3109         * p-valprint.c (pascal_val_print): Remove "block".
3110         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3111         (aux_add_nonlocal_symbols): Make "block" const.
3112         (resolve_subexp): Remove cast.
3113         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3114         const.
3115         (iterate_over_file_blocks): Likewise.
3116         * f-exp.y (%union) <bval>: Remove.
3117         * coffread.c (patch_opaque_types): Make "b" const.
3118         * spu-tdep.c (spu_catch_start): Make "block" const.
3119         * c-valprint.c (print_unpacked_pointer): Remove "block".
3120         * symmisc.c (dump_symtab_1): Make "b" const.
3121         (block_depth): Make "block" const.
3122         * d-exp.y (%union) <bval>: Remove.
3123         * cp-support.h (cp_lookup_rtti_type): Update.
3124         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3125         * psymtab.c (psym_lookup_symbol): Make "block" const.
3126         (maintenance_check_psymtabs): Make "b" const.
3127         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3128         (enumerate_locals, enumerate_args): Update.
3129         * python/py-symtab.c (stpy_global_block): Make "block" const.
3130         (stpy_static_block): Likewise.
3131         * inline-frame.c (block_starting_point_at): Make "new_block"
3132         const.
3133         * block.c (find_block_in_blockvector): Make return type const.
3134         (blockvector_for_pc_sect): Make "b" const.
3135         (find_block_in_blockvector): Make "b" const.
3136
3137 2019-03-23  Tom Tromey  <tom@tromey.com>
3138
3139         * varobj.c (varobj_create): Update.
3140         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3141         * printcmd.c (display_command, do_one_display): Don't reset
3142         innermost_block.
3143         * parser-defs.h (enum innermost_block_tracker_type): Move to
3144         expression.h.
3145         (innermost_block): Update comment.
3146         * parse.c (parse_exp_1): Add tracker_types parameter.
3147         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3148         tracker_types parameter.  Reset innermost_block.
3149         (parse_exp_in_context): Remove.
3150         (parse_expression_for_completion): Update.
3151         * objfiles.c (~objfile): Don't reset expression_context_block or
3152         innermost_block.
3153         * expression.h (enum innermost_block_tracker_type): Move from
3154         parser-defs.h.
3155         (parse_exp_1): Add tracker_types parameter.
3156         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3157         reset innermost_block.
3158
3159 2019-03-23  Tom Tromey  <tom@tromey.com>
3160
3161         * objfiles.h: Include bcache.h.
3162
3163 2019-03-23  Tom Tromey  <tom@tromey.com>
3164
3165         * linespec.c (get_current_search_block): Use
3166         scoped_restore_current_language.
3167         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3168
3169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3170             Jiong Wang  <jiong.wang@arm.com>
3171
3172         * aarch64-linux-tdep.c
3173         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3174         section.
3175         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3176
3177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3178             Jiong Wang  <jiong.wang@arm.com>
3179
3180         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3181         instructions.
3182         (aarch64_analyze_prologue_test): Add PACIASP test.
3183         (aarch64_prologue_prev_register): Unmask PC value.
3184
3185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3186             Jiong Wang  <jiong.wang@arm.com>
3187
3188         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3189         (aarch64_dwarf2_prev_register): Unmask PC value.
3190         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3191         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3192         DW_CFA_AARCH64_negate_ra_state.
3193         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3194
3195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3196             Jiong Wang  <jiong.wang@arm.com>
3197
3198         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3199         registers.
3200         (aarch64_pseudo_register_name): Likewise.
3201         (aarch64_pseudo_register_type): Likewise.
3202         (aarch64_pseudo_register_reggroup_p): Likewise.
3203         (aarch64_gdbarch_init): Add pauth registers.
3204         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3205         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3206         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3207         (struct gdbarch_tdep): Add regnum for ra_state.
3208
3209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3210             Jiong Wang  <jiong.wang@arm.com>
3211
3212         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3213
3214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3215             Jiong Wang  <jiong.wang@arm.com>
3216
3217         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3218         function.
3219         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3220         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3221         (aarch64_gdbarch_init): Add puth registers.
3222         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3223         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3224         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3225
3226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3227             Jiong Wang  <jiong.wang@arm.com>
3228
3229         * aarch64-linux-nat.c
3230         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3231         * aarch64-linux-tdep.c
3232         (aarch64_linux_core_read_description): Likewise.
3233         (aarch64_linux_get_hwcap): New function.
3234         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3235         (aarch64_linux_get_hwcap): New declaration.
3236
3237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3238             Jiong Wang  <jiong.wang@arm.com>
3239
3240         * aarch64-linux-nat.c
3241         (aarch64_linux_nat_target::read_description): Add pauth param.
3242         * aarch64-linux-tdep.c
3243         (aarch64_linux_core_read_description): Likewise.
3244         * aarch64-tdep.c (struct target_desc): Add in pauth.
3245         (aarch64_read_description): Add pauth param.
3246         (aarch64_gdbarch_init): Likewise.
3247         * aarch64-tdep.h (aarch64_read_description): Likewise.
3248         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3249         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3250         * features/Makefile: Add new files.
3251         * features/aarch64-pauth.c: New file.
3252         * features/aarch64-pauth.xml: New file.
3253
3254 2019-03-20  Tom Tromey  <tromey@adacore.com>
3255
3256         * infrun.c (handle_inferior_event): Rename from
3257         handle_inferior_event_1.  Create a scoped_value_mark.
3258         (handle_inferior_event): Remove.
3259
3260 2019-03-19  Tom Tromey  <tromey@adacore.com>
3261
3262         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3263         * infrun.h (print_stop_event): Add "displays" parameter.
3264         * infrun.c (print_stop_event): Add "displays" parameter.
3265
3266 2019-03-19  Pedro Alves  <palves@redhat.com>
3267
3268         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3269         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3270         to -1.  Fix TABs vs spaces.
3271         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3272         * tui/tui-out.h (tui_ui_out) Add intro comments.
3273         <m_line, m_start_of_line>: In-class initialize, and add describing
3274         comment.
3275
3276 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3277
3278         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3279         variable names.
3280         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3281
3282 2019-03-18  Pedro Alves  <palves@redhat.com>
3283             Eli Zaretskii <eliz@gnu.org>
3284
3285         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3286         m_line and m_start_of_line.
3287
3288 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3289
3290         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3291         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3292         it returns a newline.  This fixes a regression in TU mode, whereby
3293         the next line is output on the same screen line as the user input.
3294
3295 2019-03-18  Tom Tromey  <tromey@adacore.com>
3296
3297         * minsyms.c (minimal_symbol_reader::install): Remove call to
3298         obstack_blank.
3299
3300 2019-03-18  Pedro Alves  <palves@redhat.com>
3301
3302         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3303         New globals.
3304         (apply_style): New, factored out from ...
3305         (apply_ansi_escape): ... this.  Handle reverse video mode.
3306         (tui_set_reverse_mode): New function.
3307         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3308         * tui/tui-winsource.c (tui_show_source_line): Use
3309         tui_set_reverse_mode instead of setting A_STANDOUT.
3310         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3311         New setter methods.
3312
3313 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3314
3315         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3316         Handle tabs.
3317
3318 2019-03-18  Tom Tromey  <tromey@adacore.com>
3319
3320         * ada-lang.c (empty_array): Add "high" parameter.
3321         (ada_evaluate_subexp): Update.
3322
3323 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3324
3325         * unittests/string_view-selftests.c: Define
3326         _initialize_string_view_selftests unconditionally.
3327
3328 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3329
3330         PR gdb/24350
3331         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3332
3333 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3334
3335         PR gdb/24351
3336         * windows-nat.c (display_selector): Fix format specifiers.
3337
3338 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3339
3340         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3341         tui_refill_source_window instead of tui_refresh_win, to update the
3342         current execution line.  This fixes redisplay of the current line
3343         when stepping through the code with "next" or "step".
3344
3345 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3346
3347         * source-cache.c (source_cache::get_source_lines): Call
3348         find_source_lines to initialize s->nlines.  This fixes vertical
3349         scrolling of TUI source window when the DOWN arrow is pressed.
3350
3351 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3352
3353         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3354         linux-thread-db.c (_initialize_thread_db): Likewise.
3355
3356 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3357
3358         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3359         wclrtoeol in tui_show_source_line".  This reverts changes made in
3360         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3361
3362 2019-03-15  Tom Tromey  <tom@tromey.com>
3363
3364         * symtab.h (struct minimal_symbol): Derive from
3365         general_symbol_info.
3366         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3367         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3368         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3369         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3370         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3371         (MSYMBOL_SEARCH_NAME): Update.
3372         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3373         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3374         * minsyms.c (minimal_symbol_reader::record_full): Update.
3375
3376 2019-03-15  Tom Tromey  <tom@tromey.com>
3377
3378         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3379
3380 2019-03-15  Tom Tromey  <tom@tromey.com>
3381
3382         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3383         unique_xmalloc_ptr.
3384         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3385         Update.
3386         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3387         (build_minimal_symbol_hash_tables)
3388         (minimal_symbol_reader::install): Update.
3389
3390 2019-03-15  Tom Tromey  <tom@tromey.com>
3391
3392         * symtab.c (create_demangled_names_hash): Update.
3393         (symbol_set_names): Update.
3394         * objfiles.h (struct objfile_per_bfd_storage)
3395         <demangled_names_hash>: Now an htab_up.
3396         * objfiles.c (objfile_per_bfd_storage): Simplify.
3397
3398 2019-03-15  Tom Tromey  <tom@tromey.com>
3399
3400         * objfiles.h (struct objfile_per_bfd_storage): Declare
3401         destructor.
3402         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3403         New.
3404         (get_objfile_bfd_data): Use new.  Don't initialize
3405         language_of_main.
3406         (free_objfile_per_bfd_storage): Remove.
3407         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3408
3409 2019-03-15  Tom Tromey  <tom@tromey.com>
3410
3411         * symfile.c (reread_symbols): Update.
3412         * objfiles.c (objfile::objfile): Update.
3413         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3414         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3415         comment.
3416         (minimal_symbol_reader::install): Update.
3417         (terminate_minimal_symbol_table): Remove.
3418         * jit.c (jit_object_close_impl): Update.
3419
3420 2019-03-15  Tom Tromey  <tom@tromey.com>
3421
3422         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3423         initializations.
3424
3425 2019-03-15  Tom Tromey  <tom@tromey.com>
3426
3427         * objfiles.h (struct objfile_per_bfd_storage)
3428         <demangled_hash_languages>: Now a bitset.
3429         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3430         (lookup_minimal_symbol): Update.
3431
3432 2019-03-15  Tom Tromey  <tom@tromey.com>
3433
3434         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3435         Don't return the symbol.
3436         * coffread.c (record_minimal_symbol): Use record_full.
3437
3438 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3439
3440         The MS-Windows port of ncurses fails to switch to a color pair if
3441         one or both of the colors are the implicit default colors.  This
3442         change records the default colors when TUI is initialized, and
3443         then specifies them explicitly when a color pair uses the default
3444         colors.  This allows color styling in TUI mode on MS-Windows.
3445
3446         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3447         ncurses_norm_attr.
3448         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3449         colors in ncurses_norm_attr.
3450         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3451         "none", replace it with the default color recorded in
3452         ncurses_norm_attr.
3453
3454 2019-03-14  Tom Tromey  <tromey@adacore.com>
3455
3456         * source-cache.h (class source_cache) <get_source_lines>: Return
3457         std::string.
3458         * source-cache.c (source_cache::extract_lines): Handle case where
3459         first_pos==npos.  Return std::string.
3460         (source_cache::get_source_lines): Update.
3461
3462 2019-03-14  Tom Tromey  <tromey@adacore.com>
3463
3464         * NEWS: Add item for "style sources" commands.
3465         * source-cache.c (source_cache::get_source_lines): Check
3466         source_styling.
3467         * cli/cli-style.c (source_styling): New global.
3468         (_initialize_cli_style): Add "style sources" commands.
3469         (show_style_sources): New function.
3470         * cli/cli-style.h (source_styling): Declare.
3471
3472 2019-03-14  Pedro Alves  <palves@redhat.com>
3473             Tom Tromey  <tromey@adacore.com>
3474
3475         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3476         * tui/tui-winsource.c (tui_refill_source_window): New function,
3477         from...
3478         (tui_horizontal_source_scroll): ... here.  Move some logic.
3479         * cli/cli-style.c (set_style_enabled): Notify new observable.
3480         * tui/tui-hooks.c (tui_redisplay_source): New function.
3481         (tui_attach_detach_observers): Attach or detach
3482         tui_redisplay_source.
3483         * observable.h (source_styling_changed): New observable.
3484         * observable.c: Define source_styling_changed observable.
3485
3486 2019-03-13  Tom Tromey  <tromey@adacore.com>
3487
3488         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3489         (i386_gnu_nat_target::store_registers): Update.
3490         * target-debug.h (target_debug_print_std_string): New macro.
3491         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3492         * windows-tdep.c (display_one_tib): Update.
3493         * tui/tui-stack.c (tui_make_status_line): Update.
3494         * top.c (print_inferior_quit_action): Update.
3495         * thread.c (thr_try_catch_cmd): Update.
3496         (add_thread_with_info): Update.
3497         (thread_target_id_str): Update.
3498         (thr_try_catch_cmd): Update.
3499         (thread_command): Update.
3500         (thread_find_command): Update.
3501         * record-btrace.c (record_btrace_target::info_record)
3502         (record_btrace_resume_thread, record_btrace_target::resume)
3503         (record_btrace_cancel_resume, record_btrace_step_thread)
3504         (record_btrace_target::wait, record_btrace_target::wait)
3505         (record_btrace_target::wait, record_btrace_target::stop): Update.
3506         * progspace.c (print_program_space): Update.
3507         * process-stratum-target.c
3508         (process_stratum_target::thread_address_space): Update.
3509         * linux-fork.c (linux_fork_mourn_inferior)
3510         (detach_checkpoint_command, info_checkpoints_command)
3511         (linux_fork_context): Update.
3512         (linux_fork_detach): Update.
3513         (class scoped_switch_fork_info): Update.
3514         (delete_checkpoint_command): Update.
3515         * infrun.c (follow_fork_inferior): Update.
3516         (follow_fork_inferior): Update.
3517         (proceed_after_vfork_done): Update.
3518         (handle_vfork_child_exec_or_exit): Update.
3519         (follow_exec): Update.
3520         (displaced_step_prepare_throw): Update.
3521         (displaced_step_restore): Update.
3522         (start_step_over): Update.
3523         (resume_1): Update.
3524         (clear_proceed_status_thread): Update.
3525         (proceed): Update.
3526         (print_target_wait_results): Update.
3527         (do_target_wait): Update.
3528         (context_switch): Update.
3529         (stop_all_threads): Update.
3530         (restart_threads): Update.
3531         (finish_step_over): Update.
3532         (handle_signal_stop): Update.
3533         (switch_back_to_stepped_thread): Update.
3534         (keep_going_pass_signal): Update.
3535         (print_exited_reason): Update.
3536         (normal_stop): Update.
3537         * inferior.c (inferior_pid_to_str): Change return type.
3538         (print_selected_inferior): Update.
3539         (add_inferior): Update.
3540         (detach_inferior): Update.
3541         * dummy-frame.c (fprint_dummy_frames): Update.
3542         * dcache.c (dcache_info_1): Update.
3543         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3544         (btrace_fetch, btrace_clear): Update.
3545         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3546         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3547         type.
3548         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3549         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3550         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3551         * gdbarch.c, gdbarch.h: Rebuild.
3552         * gdbarch.sh (core_pid_to_str): Change return type.
3553         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3554         return type.
3555         (windows_nat_target::pid_to_str): Change return type.
3556         (windows_delete_thread): Update.
3557         (windows_nat_target::attach): Update.
3558         (windows_nat_target::files_info): Update.
3559         * target-delegates.c: Rebuild.
3560         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3561         return type.
3562         (sol_thread_target::pid_to_str): Change return type.
3563         * remote.c (class remote_target) <pid_to_str>: Change return
3564         type.
3565         (remote_target::pid_to_str): Change return type.
3566         (extended_remote_target::attach, remote_target::remote_stop_ns)
3567         (remote_target::remote_notif_remove_queued_reply)
3568         (remote_target::push_stop_reply, remote_target::disable_btrace):
3569         Update.
3570         (extended_remote_target::attach): Update.
3571         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3572         type.
3573         (gdbsim_target::pid_to_str): Change return type.
3574         * ravenscar-thread.c (struct ravenscar_thread_target)
3575         <pid_to_str>: Change return type.
3576         (ravenscar_thread_target::pid_to_str): Change return type.
3577         * procfs.c (class procfs_target) <pid_to_str>: Change return
3578         type.
3579         (procfs_target::pid_to_str): Change return type.
3580         (procfs_target::attach): Update.
3581         (procfs_target::detach): Update.
3582         (procfs_target::fetch_registers): Update.
3583         (procfs_target::store_registers): Update.
3584         (procfs_target::wait): Update.
3585         (procfs_target::files_info): Update.
3586         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3587         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3588         return type.
3589         (nto_procfs_target::pid_to_str): Change return type.
3590         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3591         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3592         return type.
3593         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3594         (exit_lwp): Update.
3595         (attach_proc_task_lwp_callback, get_detach_signal)
3596         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3597         (linux_nat_target::resume, wait_lwp, stop_callback)
3598         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3599         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3600         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3601         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3602         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3603         type.
3604         (inf_ptrace_target::attach): Update.
3605         (inf_ptrace_target::files_info): Update.
3606         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3607         type.
3608         (go32_nat_target::pid_to_str): Change return type.
3609         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3610         (gnu_nat_target::wait): Update.
3611         (gnu_nat_target::wait): Update.
3612         (gnu_nat_target::resume): Update.
3613         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3614         (fbsd_nat_target::wait): Update.
3615         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3616         type.
3617         (darwin_nat_target::attach): Update.
3618         * corelow.c (class core_target) <pid_to_str>: Change return type.
3619         (core_target::pid_to_str): Change return type.
3620         * target.c (normal_pid_to_str): Change return type.
3621         (default_pid_to_str): Likewise.
3622         (target_pid_to_str): Change return type.
3623         (target_translate_tls_address): Update.
3624         (target_announce_detach): Update.
3625         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3626         return type.
3627         (bsd_uthread_target::pid_to_str): Change return type.
3628         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3629         type.
3630         (bsd_kvm_target::pid_to_str): Change return type.
3631         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3632         return type.
3633         (aix_thread_target::pid_to_str): Change return type.
3634         * target.h (struct target_ops) <pid_to_str>: Change return type.
3635         (target_pid_to_str, normal_pid_to_str): Likewise.
3636         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3637         type.
3638         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3639         type.
3640         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3641         return type.
3642         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3643         type.
3644         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3645         type.
3646         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3647         return type.
3648
3649 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3650
3651         * NEWS: Mention that the new default MI version is 3.  Mention
3652         changes to the output of commands and events that deal with
3653         multi-location breakpoints.
3654         * breakpoint.c: Include "mi/mi-out.h".
3655         (print_one_breakpoint): Change output syntax if using MI version
3656         >= 3.
3657         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3658         New.
3659         (mi_multi_location_breakpoint_output_fixed): New.
3660         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3661         (mi_cmd_fix_multi_location_breakpoint_output): New.
3662         (mi_multi_location_breakpoint_output_fixed): New.
3663         * mi/mi-cmds.c (mi_cmds): Register command
3664         -fix-multi-location-breakpoint-output.
3665         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3666         interpreter "mi".
3667
3668 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3669
3670         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3671         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3672         instantiate mi_ui_out based on interpreter name.
3673         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3674         * mi/mi-main.c (mi_load_progress): Likewise.
3675
3676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3677
3678         * NEWS: Combine separate "New targets" sections for 8.3.
3679
3680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3681
3682         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3683         (ppcfbsd_init_abi): Install gdbarch
3684         "fetch_tls_load_module_address" and "get_thread_local_address"
3685         methods.
3686
3687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3688
3689         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3690         (riscv_fbsd_init_abi): Install gdbarch
3691         "fetch_tls_load_module_address" and "get_thread_local_address"
3692         methods.
3693
3694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3695
3696         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3697         (i386fbsd_init_abi): Install gdbarch
3698         "fetch_tls_load_module_address" and "get_thread_local_address"
3699         methods.
3700
3701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3702
3703         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3704         (amd64fbsd_init_abi): Install gdbarch
3705         "fetch_tls_load_module_address" and "get_thread_local_address"
3706         methods.
3707
3708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3709
3710         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3711         (struct fbsd_pspace_data): New type.
3712         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3713         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3714         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3715         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3716         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3717
3718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3719
3720         * gdbtypes.c (lookup_struct_elt): New function.
3721         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3722         * gdbtypes.h (struct struct_elt): New type.
3723         (lookup_struct_elt): New prototype.
3724
3725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3726
3727         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3728         remove disabled code block.
3729
3730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3731
3732         * gdbarch.sh (get_thread_local_address): New method.
3733         * gdbarch.h, gdbarch.c: Regenerate.
3734         * target.c (target_translate_tls_address): Use
3735         gdbarch_get_thread_local_address if present instead of
3736         target::get_thread_local_address.
3737
3738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3739
3740         * target.h (target::get_thread_local_address): Update comment.
3741
3742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3743
3744         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3745         objfile->separate_debug_objfile_backlink if not NULL.
3746
3747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3748
3749         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3750         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3751         (amd64bsd_store_inferior_registers): Likewise.
3752         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3753         Enable segment base registers.
3754         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3755         PT_GETFSBASE and PT_GETGSBASE.
3756         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3757         PT_SETGSBASE.
3758         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3759         segment base registers.
3760         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3761
3762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3765         Update calls to i386_target_description to add 'segments'
3766         parameter.
3767         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3768         add segment base registers.
3769         * arch/i386.c (i386_create_target_description): Add 'segments'
3770         parameter to enable segment base registers.
3771         * arch/i386.h (i386_create_target_description): Likewise.
3772         * features/i386/32bit-segments.xml: New file.
3773         * features/i386/32bit-segments.c: Generate.
3774         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3775         call to i386_target_description to add 'segments' parameter.
3776         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3777         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3778         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3779         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3780         if feature is present.
3781         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3782         Add 'segments' parameter to call to i386_target_description.
3783         (i386_target_description): Add 'segments' parameter to enable
3784         segment base registers.
3785         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3786         to call to i386_target_description.
3787         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3788         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3789         Define I386_NUM_REGS.
3790         (i386_target_description): Add 'segments' parameter to enable
3791         segment base registers.
3792
3793 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3794
3795         PR/24325
3796         * source-cache.c: #undef open and close, to avoid unresolved
3797         externals during linking.
3798
3799 2019-03-12  Tom Tromey  <tromey@adacore.com>
3800
3801         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3802         const.  Add initializers.
3803         (_initialize_remote): Don't initialize ptid globals.
3804
3805 2019-03-12  Pedro Alves  <palves@redhat.com>
3806
3807         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3808
3809 2019-03-12  Pedro Alves  <palves@redhat.com>
3810
3811         * cp-name-parser.y (main): Remove unused 'len' variable.
3812
3813 2019-03-12  Tom Tromey  <tromey@adacore.com>
3814
3815         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3816         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3817
3818 2019-03-12  Tom Tromey  <tromey@adacore.com>
3819
3820         * linux-nat.c (iterate_over_lwps): Update.
3821         (stop_callback): Remove parameter.
3822         (stop_wait_callback, detach_callback, resume_set_callback)
3823         (select_singlestep_lwp_callback, set_ignore_sigint)
3824         (status_callback, resumed_callback, resume_clear_callback)
3825         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3826         data parameter.
3827         (linux_nat_target::detach, linux_nat_target::resume)
3828         (linux_stop_and_wait_all_lwps, select_event_lwp)
3829         (linux_nat_filter_event, linux_nat_wait_1)
3830         (linux_nat_target::kill, linux_nat_target::stop)
3831         (linux_nat_target::stop): Update.
3832         (linux_nat_resume_callback): Change type.
3833         (resume_stopped_resumed_lwps, count_events_callback)
3834         (select_event_lwp_callback): Likewise.
3835         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3836         * arm-linux-nat.c (struct update_registers_data): Remove.
3837         (update_registers_callback): Change type.
3838         (arm_linux_insert_hw_breakpoint1): Update.
3839         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3840         parameter.
3841         (x86_linux_dr_set_addr): Update.
3842         (x86_linux_dr_set_control): Update.
3843         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3844         (iterate_over_lwps): Use gdb::function_view.
3845         * nat/aarch64-linux-hw-point.c (struct
3846         aarch64_dr_update_callback_param): Remove.
3847         (debug_reg_change_callback): Change type.
3848         (aarch64_notify_debug_reg_change): Update.
3849         * s390-linux-nat.c (s390_refresh_per_info): Update.
3850
3851 2019-03-11  Tom Tromey  <tromey@adacore.com>
3852
3853         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3854         redundant assignment to "this_cu".
3855
3856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3857
3858         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3859
3860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3863         from...
3864         (rank_one_type): ... this.
3865
3866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3867
3868         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3869         from...
3870         (rank_one_type): ... this.
3871
3872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3873
3874         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3875         from...
3876         (rank_one_type): ... this.
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3881         from...
3882         (rank_one_type): ... this.
3883
3884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3887         from...
3888         (rank_one_type): ... this.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3897
3898         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3899         from...
3900         (rank_one_type): ... this.
3901
3902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3903
3904         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3905         from...
3906         (rank_one_type): ... this.
3907
3908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3909
3910         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3911         from...
3912         (rank_one_type): ... this.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3921
3922         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3923         from...
3924         (rank_one_type): ... this.
3925
3926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3929         from...
3930         (rank_one_type): ... this.
3931
3932 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3933
3934         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3935         inferior-events' shows the example events.
3936
3937 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3938
3939         Support styling on native MS-Windows console
3940
3941         PR/24315
3942         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3943         on MS-Windows if $TERM is not defined.
3944
3945         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3946
3947         * posix-hdep.c (gdb_console_fputs):
3948         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3949         functions.
3950         * ui-file.h (gdb_console_fputs): Add prototype.
3951
3952         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3953         back to fputs only if the former returns zero.
3954
3955 2019-03-07  Tom Tromey  <tom@tromey.com>
3956
3957         * symmisc.c (print_symbol_bcache_statistics): Update.
3958         (print_objfile_statistics): Update.
3959         * symfile.c (allocate_symtab): Update.
3960         * stabsread.c: Don't include bcache.h.
3961         * psymtab.h (struct psymbol_bcache): Don't declare.
3962         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3963         (psymbol_bcache_init, psymbol_bcache_free)
3964         (psymbol_bcache_get_bcache): Don't declare.
3965         * psymtab.c (struct psymbol_bcache): Remove.
3966         (psymtab_storage::psymtab_storage): Update.
3967         (psymtab_storage::~psymtab_storage): Update.
3968         (psymbol_bcache_init, psymbol_bcache_free)
3969         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3970         (add_psymbol_to_bcache): Update.
3971         (allocate_psymtab): Update.
3972         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3973         macro_cache>: No longer pointers.
3974         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3975         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3976         * macrotab.c (macro_bcache): Update.
3977         * macroexp.c: Don't include bcache.h.
3978         * gdbtypes.c (check_types_worklist): Update.
3979         (types_deeply_equal): Remove TRY/CATCH.  Update.
3980         * elfread.c (elf_symtab_read): Update.
3981         * dwarf2read.c: Don't include bcache.h.
3982         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3983         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3984         (print_bcache_statistics, bcache_memory_used): Don't declare.
3985         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3986         methods.  Rename all data members.
3987         * bcache.c (struct bcache): Move to bcache.h.
3988         (bcache::expand_hash_table): Rename from expand_hash_table.
3989         (bcache): Remove.
3990         (bcache::insert): Rename from bcache_full.
3991         (bcache::compare): Rename from bcache_compare.
3992         (bcache_xmalloc): Remove.
3993         (bcache::~bcache): Rename from bcache_xfree.
3994         (bcache::print_statistics): Rename from print_bcache_statistics.
3995         (bcache::memory_used): Rename from bcache_memory_used.
3996
3997 2019-03-07  Pedro Alves  <palves@redhat.com>
3998
3999         * infrun.c (normal_stop): Also check for
4000         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4001
4002 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * f-lang.c (value_from_host_double): Moved to...
4005         * value.c (value_from_host_double): ...here.
4006         * value.h (value_from_host_double): Declare.
4007         * guile/scm-math.c (vlscm_convert_typed_number): Use
4008         value_from_host_double.
4009         (vlscm_convert_number): Likewise.
4010         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4011         * python/py-value.c (convert_value_from_python): Likewise.
4012
4013 2019-03-06  Tom Tromey  <tom@tromey.com>
4014
4015         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4016
4017 2019-03-06  Tom Tromey  <tom@tromey.com>
4018
4019         * utils.h (free_current_contents): Don't declare.
4020         * utils.c (free_current_contents): Remove.
4021
4022 2019-03-06  Tom Tromey  <tom@tromey.com>
4023
4024         * top.c (quit_force): Update.
4025         * main.c (captured_command_loop): Update.
4026         * common/new-op.c (operator new): Update.
4027         * common/common-exceptions.c (struct catcher)
4028         <save_cleanup_chain>: Remove member.
4029         (exceptions_state_mc_init): Update.
4030         (exception_try_scope_entry): Return nullptr.
4031         (exception_try_scope_exit, exception_rethrow)
4032         (throw_exception_sjlj, throw_exception_cxx): Update.
4033         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4034         (all_cleanups, do_cleanups, discard_cleanups)
4035         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4036         (restore_cleanups, restore_final_cleanups): Don't declare.
4037         (do_final_cleanups): Remove parameter.
4038         * common/cleanups.c (cleanup_chain, make_cleanup)
4039         (make_cleanup_dtor, all_cleanups, do_cleanups)
4040         (discard_my_cleanups, discard_cleanups)
4041         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4042         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4043         (null_cleanup): Remove.
4044         (do_final_cleanups): Remove parameter.
4045
4046 2019-03-06  Tom Tromey  <tom@tromey.com>
4047
4048         * remote.c (remote_target::remote_parse_stop_reply): Use
4049         unique_xmalloc_ptr.
4050
4051 2019-03-06  Tom Tromey  <tom@tromey.com>
4052
4053         * stabsread.c (struct stabs_field_info): Rename from field_info.
4054         <list, fnlist>: Add initializers.
4055         <obstack>: New member.
4056         (read_member_functions, read_struct_fields, read_baseclasses):
4057         Allocate on obstack.  Don't use cleanups.
4058         (read_one_struct_field, read_member_functions, read_struct_fields)
4059         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4060         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4061         (read_struct_type): Update.
4062
4063 2019-03-06  Tom Tromey  <tom@tromey.com>
4064
4065         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4066         * common/filestuff.h (make_cleanup_close): Don't declare.
4067         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4068         Remove.
4069
4070 2019-03-06  Tom Tromey  <tom@tromey.com>
4071
4072         * solib-aix.c: Use make_scope_exit.
4073
4074 2019-03-06  Tom Tromey  <tom@tromey.com>
4075
4076         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4077         Use make_scope_exit.
4078
4079 2019-03-06  Tom Tromey  <tom@tromey.com>
4080
4081         * solib-svr4.c (disable_probes_interface): Remove parameter.
4082         (svr4_handle_solib_event): Use make_scope_exit.
4083
4084 2019-03-06  Tom Tromey  <tom@tromey.com>
4085
4086         * remote.c (struct stop_reply_deleter): Remove.
4087         (stop_reply_up): Update.
4088         (struct stop_reply): Derive from notif_event.  Don't typedef.
4089         <regcache>: Now a std::vector.
4090         (stop_reply_xfree): Remove.
4091         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4092         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4093         (remote_target::discard_pending_stop_replies): Use delete.
4094         (remote_target::remote_parse_stop_reply): Update.
4095         (remote_target::process_stop_reply): Update.
4096         * remote-notif.h (struct notif_event): Add virtual destructor.
4097         Remove "dtr" member.
4098         (struct notif_client) <alloc_event>: Return a unique_ptr.
4099         (notif_event_xfree): Don't declare.
4100         (notif_event_up): New typedef.
4101         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4102         (notif_event_xfree, do_notif_event_xfree): Remove.
4103         (remote_notif_state_xfree): Update.
4104
4105 2019-03-06  Tom Tromey  <tom@tromey.com>
4106
4107         * infrun.c (displaced_step_clear_cleanup): Now a
4108         forward_scope_exit type.
4109         (displaced_step_prepare_throw): Update.
4110         (displaced_step_fixup): Update.
4111
4112 2019-03-06  Tom Tromey  <tom@tromey.com>
4113
4114         * inferior.h (class inferior): Update comment.
4115         * gdbthread.h (class thread_info): Update comment.
4116
4117 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4118             Tom Tromey  <tom@tromey.com>
4119
4120         * stabsread.h (struct stab_section_list): Remove.
4121         (coffstab_build_psymtabs): Update.
4122         * dbxread.c (symbuf_sections): Now a std::vector.
4123         (sect_idx): New global.
4124         (fill_symbuf): Update.
4125         (coffstab_build_psymtabs): Change type of stabsects parameter.
4126         Update.
4127         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4128         std::vector.
4129         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4130         (coff_locate_sections): Update.
4131         (coff_symfile_read): Remove cleanups.  Update.
4132         (init_stringtab): Add storage parameter.
4133         (free_stringtab, free_stringtab_cleanup): Remove.
4134         (init_lineno): Add storage parameter.
4135         (free_linetab, free_linetab_cleanup): Remove.
4136
4137 2019-03-06  Pedro Alves  <palves@redhat.com>
4138
4139         * linux-fork.c (fork_info::clobber_regs): Delete.
4140         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4141         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4142         comment.  Adjust.
4143         (scoped_switch_fork_info::scoped_switch_fork_info)
4144         (checkpoint_command, linux_fork_context): Adjust
4145         fork_save_infrun_state calls.
4146
4147 2019-03-06  Pedro Alves  <palves@redhat.com>
4148
4149         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4150         (inf_has_multiple_threads): Return 'bool' and rewrite using
4151         inferior_info::threads().
4152
4153 2019-03-06  Pedro Alves  <palves@redhat.com>
4154
4155         * linux-fork.c: Include <list>.
4156         (fork_list): Now a std::list instance.
4157         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4158         (forks_exist_p, find_last_fork): Adjust.
4159         (new_fork): Delete.
4160         (one_fork_p): New.
4161         (add_fork): Adjust.
4162         (free_fork): Delete, folded into fork_info::~fork_info().
4163         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4164         Adjust.
4165         (init_fork_list): Delete.
4166         (linux_fork_killall, linux_fork_mourn_inferior)
4167         (linux_fork_detach, info_checkpoints_command): Adjust.
4168         (_initialize_linux_fork): No longer call init_fork_list.
4169
4170 2019-03-06  Pedro Alves  <palves@redhat.com>
4171
4172         * linux-fork.c (new_fork): New, split out of ...
4173         (add_fork): ... this.  Return void.  Move "first fork" special
4174         case from here, to ...
4175         (checkpoint_command): ... here.
4176         * linux-linux.h (add_fork): Return void.
4177
4178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4181
4182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4183             Chris January  <chris.january@arm.com>
4184             David Lecomber  <david.lecomber@arm.com>
4185
4186         * f-exp.y: New token, UNOP_INTRINSIC.
4187         (exp): New pattern using UNOP_INTRINSIC token.
4188         (f77_keywords): Add 'abs' keyword.
4189         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4190         (value_from_host_double): New function.
4191         (evaluate_subexp_f): Support UNOP_ABS.
4192
4193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4196         types.
4197
4198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4201         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4202         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4203
4204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4205
4206         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4207
4208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4209             Chris January  <chris.january@arm.com>
4210
4211         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4212         * f-exp.y: Define 'KIND' token.
4213         (exp): New pattern for KIND expressions.
4214         (ptype): Handle types with a kind extension.
4215         (direct_abs_decl): Extend to spot kind extensions.
4216         (f77_keywords): Add 'kind' to the list.
4217         (push_kind_type): New function.
4218         (convert_to_kind_type): New function.
4219         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4220         * parse.c (operator_length_standard): Likewise.
4221         * parser-defs.h (enum type_pieces): Add tp_kind.
4222         * std-operator.def: Add UNOP_KIND.
4223
4224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * f-exp.y (f_parse): Set yydebug.
4227
4228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * f-lang.c (evaluate_subexp_f): New function.
4231         (exp_descriptor_f): New global.
4232         (f_language_defn): Use exp_descriptor_f instead of
4233         exp_descriptor_standard.
4234
4235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * f-exp.y (struct token): Add comments.
4238         (dot_ops): Remove uppercase versions and the end marker.
4239         (f77_keywords): Likewise.
4240         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4241         entries in the dot_ops array are case insensitive, and use
4242         strncasecmp to compare strings.  Also some whitespace cleanup in
4243         this area.  Similar for the f77_keywords array, except entries in
4244         this list might be case sensitive.
4245
4246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * f-exp.y (struct f77_boolean_val): Add comments.
4249         (boolean_values): Remove uppercase versions, and end marker.
4250         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4251         and use strncasecmp to achieve case insensitivity.  Additionally,
4252         perform whitespace cleanup around this code.
4253
4254 2019-03-06  Tom Tromey  <tromey@adacore.com>
4255
4256         * remote-sim.c (gdbsim_target_open): Use result of
4257         gdb_argv::release.
4258
4259 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4260         Dirk Schubert  <dirk.schubert@arm.com>
4261         Chris January  <chris.january@arm.com>
4262
4263         * eval.c (evaluate_subexp_standard): Call Fortran argument
4264         wrapping logic.
4265         * f-lang.c (struct value): A value which can be passed into a
4266         Fortran function call.
4267         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4268         where appropriate.
4269         (struct type): Value ready for a Fortran function call.
4270         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4271         is needed.
4272         * f-lang.h (fortran_argument_convert): Declaration.
4273         (fortran_preserve_arg_pointer): Declaration.
4274         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4275
4276 2019-03-05  Tom Tromey  <tromey@adacore.com>
4277
4278         * python/py-prettyprint.c (print_string_repr): Remove #if.
4279         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4280
4281 2019-03-05  Tom Tromey  <tromey@adacore.com>
4282
4283         * target.c (the_dummy_target): Move later.  Change type to
4284         "dummy_target".
4285         (initialize_targets): Don't initialize the_dummy_target.
4286
4287 2019-03-05  Tom Tromey  <tromey@adacore.com>
4288
4289         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4290         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4291
4292 2019-03-05  Tom Tromey  <tromey@adacore.com>
4293
4294         * windows-nat.c (windows_nat_target::attach)
4295         (windows_nat_target::detach): Don't call gdb_flush.
4296         * valprint.c (generic_val_print, val_print, val_print_string):
4297         Don't call gdb_flush.
4298         * utils.c (defaulted_query): Don't call gdb_flush.
4299         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4300         * target.c (target_announce_detach): Don't call gdb_flush.
4301         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4302         * remote.c (extended_remote_target::attach): Don't call
4303         gdb_flush.
4304         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4305         * printcmd.c (do_examine): Don't call gdb_flush.
4306         (info_display_command): Don't call gdb_flush.
4307         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4308         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4309         * memattr.c (info_mem_command): Don't call gdb_flush.
4310         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4311         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4312         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4313         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4314         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4315         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4316         (gnu_nat_target::detach): Don't call gdb_flush.
4317         * f-valprint.c (f_val_print): Don't call gdb_flush.
4318         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4319         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4320         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4321         gdb_flush.
4322         * c-valprint.c (c_val_print): Don't call gdb_flush.
4323         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4324
4325 2019-03-05  Tom Tromey  <tromey@adacore.com>
4326
4327         * varobj.c (update_dynamic_varobj_children): Update.
4328         (install_default_visualizer): Use reset, not release.
4329         * value.c (set_internalvar): Update.
4330         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4331         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4332         ATTRIBUTE_UNUSED_RESULT.
4333
4334 2019-03-05  Tom Tromey  <tromey@adacore.com>
4335
4336         * remote.c (class scoped_remote_fd) <release>: Add
4337         ATTRIBUTE_UNUSED_RESULT.
4338
4339 2019-03-05  Tom Tromey  <tromey@adacore.com>
4340
4341         * macroexp.c (struct macro_buffer) <release>: Add
4342         ATTRIBUTE_UNUSED_RESULT.
4343
4344 2019-03-05  Tom Tromey  <tromey@adacore.com>
4345
4346         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4347         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4348         ATTRIBUTE_UNUSED_RESULT.
4349
4350 2019-03-05  Tom Tromey  <tromey@adacore.com>
4351
4352         * common/scoped_fd.h (class scoped_fd) <release>: Add
4353         ATTRIBUTE_UNUSED_RESULT.
4354
4355 2019-03-05  Tom Tromey  <tromey@adacore.com>
4356
4357         * parser-defs.h (struct parser_state) <release>: Add
4358         ATTRIBUTE_UNUSED_RESULT.
4359
4360 2019-03-05  Tom Tromey  <tromey@adacore.com>
4361
4362         * utils.h (class gdb_argv) <release>: Add
4363         ATTRIBUTE_UNUSED_RESULT.
4364         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4365
4366 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4367
4368         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4369         for-loop range, to avoid compiler warnings.
4370
4371         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4372         avoid compiler warnings about unused variables.
4373
4374         * NEWS: Mention end of support for native debugging on MS-Windows
4375         before XP.
4376
4377         PR gdb/24292
4378         * common/netstuff.c:
4379         * gdbserver/gdbreplay.c
4380         * gdbserver/remote-utils.c:
4381         * ser-tcp.c:
4382         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4383         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4384         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4385         'getaddrinfo' and 'freeaddrinfo' were not available before
4386         Windows XP, and mingw.org's MinGW headers by default define
4387         _WIN32_WINNT to 0x500.
4388
4389 2019-03-01  Gary Benson <gbenson@redhat.com>
4390
4391         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4392
4393 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4394             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4395
4396         PR gdb/8527
4397         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4398         set_sigint_trap, clear_sigint_trap.
4399
4400 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4401
4402         * target.c (target_detach): Clear the regcache and the
4403         frame cache.
4404
4405 2019-02-27  Pedro Alves  <palves@redhat.com>
4406
4407         * utils.c (set_screen_size): When we cap the height/width sizes,
4408         tweak the corresponding command variable to show "unlimited":
4409
4410 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4411             Pedro Alves  <palves@redhat.com>
4412
4413         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4414         before calling rl_set_screen_size.
4415
4416 2019-02-27  Tom Tromey  <tromey@adacore.com>
4417
4418         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4419         define.
4420         * python/py-value.c: Remove Python 2.4 workaround.
4421         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4422         workaround.
4423         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4424         Python 2.4 workaround.
4425         * python/python-internal.h: Remove Python 2.4 comment.
4426         (Py_ssize_t): Don't define.
4427         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4428         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4429         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4430         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4431         * python/python.c (do_start_initialization): Remove Python 2.4
4432         workaround.
4433         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4434         (print_children): Remove Python 2.4 workaround.
4435         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4436         workaround.
4437         (CHARBUFFERPROC_NAME): Remove.
4438         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4439         Python 2.4 workaround.
4440
4441 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4442
4443         * NEWS: Note minimum Python version.
4444
4445 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4446
4447         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4448         code from these functions.  Remove corresponding ifdefs.  Use
4449         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4450         Remove gotos and target of gotos.
4451         (infpy_search_memory): Likewise.
4452
4453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4456         (hppa_gdbarch_init): Don't register deleted functions with
4457         gdbarch.
4458
4459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4462         (h8300_unwind_sp): Delete.
4463         (h8300_dummy_id): Delete.
4464         (h8300_gdbarch_init): Don't register deleted functions with
4465         gdbarch.
4466
4467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4470         (ft32_unwind_pc): Delete.
4471         (ft32_unwind_sp): Delete.
4472         (ft32_gdbarch_init): Don't register deleted functions with
4473         gdbarch.
4474
4475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4476
4477         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4478         (frv_unwind_pc): Delete.
4479         (frv_unwind_sp): Delete.
4480         (frv_gdbarch_init): Don't register deleted functions with
4481         gdbarch.
4482
4483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4486         (riscv_unwind_pc): Delete.
4487         (riscv_unwind_sp): Delete.
4488         (riscv_gdbarch_init): Don't register deleted functions with
4489         gdbarch.
4490
4491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4494         (csky_unwind_pc): Delete.
4495         (csky_unwind_sp): Delete.
4496         (csky_gdbarch_init): Don't register deleted functions with
4497         gdbarch.
4498
4499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4502         (cris_unwind_pc): Delete.
4503         (cris_unwind_sp): Delete.
4504         (cris_gdbarch_init): Don't register deleted functions with
4505         gdbarch.
4506
4507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4510         (bfin_unwind_pc): Delete.
4511         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4512
4513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4516         (arm_unwind_pc): Delete.
4517         (arm_unwind_sp): Delete.
4518         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4519
4520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4523         (arc_unwind_pc): Delete.
4524         (arc_unwind_sp): Delete.
4525         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4526
4527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4530         (alpha_unwind_pc): Delete.
4531         (alpha_gdbarch_init): Don't register deleted functions with
4532         gdbarch.
4533
4534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4537         (aarch64_unwind_pc): Delete.
4538         (aarch64_unwind_sp): Delete.
4539         (aarch64_gdbarch_init): Don't register deleted functions with
4540         gdbarch.
4541
4542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * gdbtypes.c (type_align): Don't consider static members when
4545         computing structure alignment.
4546
4547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4550         return 0 for other types.
4551         * arch-utils.c (default_type_align): Always return 0.
4552         * gdbarch.h: Regenerate.
4553         * gdbarch.sh (type_align): Extend comment.
4554         * gdbtypes.c (type_align): Add additional comments, always call
4555         gdbarch_type_align before applying the default rules.
4556         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4557         generic code will then apply a suitable default.
4558         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4559         types, return 0 for other types.
4560
4561 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4562
4563         * NEWS: Create a new section for the next release branch.
4564         Rename the section of the current branch, now that it has
4565         been cut.
4566
4567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4568
4569         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4570         * version.in: Bump version to 8.3.50.DATE-git.
4571
4572 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4573
4574         * aix-thread.c (ptid_cmp): Remove unused variable.
4575         (get_signaled_thread): Likewise.
4576         (store_regs_user_thread): Likewise.
4577         (store_regs_kernel_thread): Likewise.
4578         (fetch_regs_kernel_thread): Remove shadowed variable.
4579
4580 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * features/riscv/32bit-cpu.xml: Add register numbers.
4583         * features/riscv/32bit-fpu.c: Regenerate.
4584         * features/riscv/32bit-fpu.xml: Add register numbers.
4585         * features/riscv/64bit-cpu.xml: Add register numbers.
4586         * features/riscv/64bit-fpu.c: Regenerate.
4587         * features/riscv/64bit-fpu.xml: Add register numbers.
4588
4589 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4590
4591         * NEWS: Mention two argument form of gdb.Value constructor.
4592         * python/py-value.c (convert_buffer_and_type_to_value): New
4593         function.
4594         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4595         Add support for handling an optional second argument.  Call
4596         convert_buffer_and_type_to_value as appropriate.
4597         * python/python-internal.h (Py_buffer_deleter): New struct.
4598         (Py_buffer_up): New typedef.
4599
4600 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4601
4602         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4603         instead of releasing ownership.
4604
4605 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4606
4607         * dwarf2read.c (open_and_init_dwp_file): Call
4608         elf_numsections instead of bfd_count_sections to initialize
4609         dwp_file->num_sections.
4610
4611 2019-02-25  Tom Tromey  <tromey@adacore.com>
4612
4613         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4614
4615 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4616
4617         * gcore.in: Add '--readnever' option when invoking GDB.
4618
4619 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4620
4621         * MAINTAINERS: Update my email address.
4622
4623 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4624
4625         * build-id.c (build_id_to_debug_bfd_1): New function.
4626         (build_id_to_debug_bfd): Look for separate debug file in
4627         sysroot.
4628
4629 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * gdbarch.sh: Update the copyright year range that is placed into
4632         generated files.
4633
4634 2019-02-22  Keith Seitz  <keiths@redhat.com>
4635
4636         PR symtab/23853
4637         * linespec.c (create_sals_line_offset): Search for the default
4638         symtab's filename instead of its fullname.
4639
4640 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4641
4642         * NEWS: Update style defaults.
4643
4644 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4645
4646         * main.c (captured_main_1): Disable styling in batch mode.
4647
4648 2019-02-20  Tom Tromey  <tom@tromey.com>
4649
4650         * symtab.c (symtab_symbol_info): Fix typos.
4651
4652 2019-02-20  Tom Tromey  <tromey@adacore.com>
4653
4654         * findcmd.c (_initialize_mem_search): Use upper case for
4655         metasyntactic variables.
4656
4657 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4658
4659         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4660         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4661
4662 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4663
4664         * top.h (source_file_name): Change to std::string.
4665         * top.c (source_file_name): Likewise.
4666         (command_line_input): Adjust.
4667         * cli/cli-script.c (script_from_file): Adjust.
4668
4669 2019-02-19  Tom Tromey  <tromey@adacore.com>
4670
4671         * ravenscar-thread.c
4672         (ravenscar_thread_target::update_thread_list): Don't call
4673         ada_build_task_list.
4674         * ada-lang.h (ada_build_task_list): Don't declare.
4675         * ada-tasks.c (struct ada_tasks_inferior_data)
4676         <task_list_valid_p>: Now bool.
4677         (read_known_tasks, ada_task_list_changed)
4678         (ada_tasks_invalidate_inferior_data): Update.
4679         (read_known_tasks_array): Return bool.
4680         (read_known_tasks_list): Likewise.
4681         (read_known_tasks): Return void.
4682         (ada_build_task_list): Now static.
4683
4684 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4687         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4688
4689 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4690
4691         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4692         variant for ada_tasks_pspace_data_handle and
4693         ada_tasks_inferior_data_handle.
4694         (ada_tasks_pspace_data_cleanup): New function.
4695         (ada_tasks_inferior_data_cleanup): New function.
4696
4697 2019-02-17  Tom Tromey  <tom@tromey.com>
4698
4699         * macrotab.h (macro_source_fullname): Return a std::string.
4700         * macrotab.c (macro_include, check_for_redefinition)
4701         (macro_undef, macro_lookup_definition, foreach_macro)
4702         (foreach_macro_in_scope): Update.
4703         (macro_source_fullname): Return a std::string.
4704         * macrocmd.c (show_pp_source_pos): Update.
4705
4706 2019-02-17  Tom Tromey  <tom@tromey.com>
4707
4708         * macrocmd.c (show_pp_source_pos): Style the file names.
4709
4710 2019-02-17  Tom Tromey  <tom@tromey.com>
4711
4712         PR tui/24197:
4713         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4714
4715 2019-02-17  Tom Tromey  <tom@tromey.com>
4716
4717         * ada-lang.c (user_select_syms): Use filtered printing.
4718         * utils.c (wrap_style): New global.
4719         (desired_style): Remove.
4720         (emit_style_escape): Add stream parameter.
4721         (set_output_style, reset_terminal_style, prompt_for_continue):
4722         Update.
4723         (flush_wrap_buffer): Only flush gdb_stdout.
4724         (wrap_here): Set wrap_style.
4725         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4726         treat escape sequences as a character.  Change when wrap buffer is
4727         flushed.
4728         (fputs_styled): Do not set the output style when the default is
4729         requested.
4730         * ui-style.h (struct ui_file_style) <is_default>: New method.
4731         * source.c (print_source_lines_base): Emit escape sequences in one
4732         piece.
4733
4734 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4735
4736         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4737         integers and enumeration types.
4738
4739 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4740
4741         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4742         instead of lookup_symbol_in_language
4743         (do_exact_match): New function.
4744         (ada_get_symbol_name_matcher): Return do_exact_match when
4745         doing a verbatim match.
4746
4747 2019-02-15  Tom Tromey  <tromey@adacore.com>
4748
4749         * ravenscar-thread.c (ravenscar_thread_target::resume)
4750         (ravenscar_thread_target::wait): Special case wildcard requests.
4751
4752 2019-02-15  Tom Tromey  <tromey@adacore.com>
4753
4754         * ravenscar-thread.c (base_ptid): Remove.
4755         (struct ravenscar_thread_target) <close>: New method.
4756         <m_base_ptid>: New member.
4757         <update_inferior_ptid, active_task, task_is_currently_active,
4758         runtime_initialized>: Declare methods.
4759         <ravenscar_thread_target>: Add constructor.
4760         (ravenscar_thread_target::task_is_currently_active)
4761         (ravenscar_thread_target::update_inferior_ptid)
4762         (ravenscar_runtime_initialized): Rename.  Now methods.
4763         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4764         (ravenscar_thread_target::update_thread_list): Update.
4765         (ravenscar_thread_target::active_task): Now method.
4766         (ravenscar_thread_target::store_registers)
4767         (ravenscar_thread_target::prepare_to_store)
4768         (ravenscar_thread_target::prepare_to_store)
4769         (ravenscar_thread_target::mourn_inferior): Update.
4770         (ravenscar_inferior_created): Use "new" to create target.
4771         (ravenscar_thread_target::get_ada_task_ptid): Update.
4772         (_initialize_ravenscar): Don't initialize base_ptid.
4773         (ravenscar_ops): Remove global.
4774
4775 2019-02-15  Tom Tromey  <tromey@adacore.com>
4776
4777         * target.h (push_target): Declare new overload.
4778         * target.c (push_target): New overload, taking an rvalue reference.
4779         * remote.c (remote_target::open_1): Use push_target overload.
4780         * corelow.c (core_target_open): Use push_target overload.
4781
4782 2019-02-15  Tom Tromey  <tromey@adacore.com>
4783
4784         * ravenscar-thread.c (is_ravenscar_task)
4785         (ravenscar_task_is_currently_active): Return bool.
4786         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4787         (_initialize_ravenscar): Remove "(void)".
4788         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4789         Return bool.
4790
4791 2019-02-15  Tom Tromey  <tromey@adacore.com>
4792
4793         * ravenscar-thread.c (ravenscar_runtime_initializer)
4794         (has_ravenscar_runtime, get_running_thread_id)
4795         (ravenscar_thread_target::resume): Fix indentation.
4796
4797 2019-02-15  Tom Tromey  <tromey@adacore.com>
4798
4799         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4800         from ravenscar_arch_ops.
4801         (sparc_ravenscar_ops::fetch_registers)
4802         (sparc_ravenscar_ops::store_registers): Now methods.
4803         (sparc_ravenscar_prepare_to_store): Remove.
4804         (sparc_ravenscar_ops): Redefine.
4805         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4806         methods and destructor.  Remove members.
4807         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4808         (ravenscar_thread_target::store_registers)
4809         (ravenscar_thread_target::prepare_to_store): Update.
4810         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4811         Remove.
4812         (struct ppc_ravenscar_powerpc_ops): Derive from
4813         ravenscar_arch_ops.
4814         (ppc_ravenscar_powerpc_ops::fetch_registers)
4815         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4816         (ppc_ravenscar_powerpc_ops): Redefine.
4817         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4818         (ppc_ravenscar_e500_ops::fetch_registers)
4819         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4820         (ppc_ravenscar_e500_ops): Redefine.
4821         * aarch64-ravenscar-thread.c
4822         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4823         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4824         (aarch64_ravenscar_fetch_registers)
4825         (aarch64_ravenscar_store_registers): Now methods.
4826         (aarch64_ravenscar_ops): Redefine.
4827
4828 2019-02-15  Tom Tromey  <tromey@adacore.com>
4829
4830         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4831         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4832         (ravenscar_thread_target::stopped_by_watchpoint)
4833         (ravenscar_thread_target::stopped_data_address)
4834         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4835
4836 2019-02-15  Tom Tromey  <tromey@adacore.com>
4837
4838         * ravenscar-thread.c: Fix some typos.
4839
4840 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841             Tom Tromey  <tromey@adacore.com>
4842
4843         * ada-lang.c (ada_exception_sal): Change addr_string to a
4844         std::string.
4845         (create_ada_exception_catchpoint): Update.
4846
4847 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4848             Tom Tromey  <tromey@adacore.com>
4849
4850         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4851         (bp_location_ops): Remove.
4852         (base_breakpoint_allocate_location): Update.
4853         (free_bp_location): Update.
4854         * ada-lang.c (class ada_catchpoint_location)
4855         <ada_catchpoint_location>: Remove ops parameter.
4856         (ada_catchpoint_location_dtor): Remove.
4857         (ada_catchpoint_location_ops): Remove.
4858         (allocate_location_exception): Update.
4859         * breakpoint.h (struct bp_location_ops): Remove.
4860         (class bp_location) <bp_location>: Remove bp_location_ops
4861         parameter.
4862         <~bp_location>: Add destructor.
4863         <ops>: Remove.
4864
4865 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4866             Pedro Alves  <palves@redhat.com>
4867
4868         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4869         'PATH_MAX'.
4870
4871 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4872             Samuel Thibault  <samuel.thibault@gnu.org>
4873             Thomas Schwinge  <thomas@codesourcery.com>
4874
4875         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4876         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4877
4878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4879
4880         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4881         (check_empty): Use "const char *".
4882
4883         * gnu-nat.c (gnu_nat_target::detach): Instead of
4884         'detach_inferior (pid)' call
4885         'detach_inferior (find_inferior_pid (pid))'.
4886
4887         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4888         'nat/fork-inferior.o'.
4889         * gnu-nat.c: #include "nat/fork-inferior.h".
4890
4891         * gnu-nat.c (gnu_nat_target::detach): Instead of
4892         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4893         * gnu-nat.h: #include "inf-child.h".
4894         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4895         'i386_gnu_nat_target::fetch_registers'.
4896         (gnu_store_registers): Rename/move to
4897         'i386_gnu_nat_target::store_registers'.
4898
4899         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4900         * gnu-nat.h (mach_thread_info): New function.
4901         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4902
4903         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4904
4905 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4906
4907         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4908
4909 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4910
4911         * windows-nat.c (windows_add_thread): Add new parameter
4912         "main_thread_p" with default value set to false.  Update
4913         function documentation as well as all callers.
4914         (windows_delete_thread): Likewise.
4915         (fake_create_process): Update call to windows_add_thread.
4916         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4917         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4918         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4919         call to windows_delete_thread.
4920
4921 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4922
4923         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4924
4925 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4926
4927         * symfile.c (find_separate_debug_file): Use canonical path of
4928         sysroot with child_path instead of gdb_sysroot if it is valid.
4929
4930 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4931
4932         * symfile.c (find_separate_debug_file): Use child_path to
4933         determine if an object file is under a sysroot.
4934
4935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4936
4937         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4938         unittests/child-path-selftests.c.
4939         * common/pathstuff.c (child_path): New function.
4940         * common/pathstuff.h (child_path): New prototype.
4941         * unittests/child-path-selftests.c: New file.
4942
4943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4944
4945         * symfile.c (find_separate_debug_file): Look for separate debug
4946         files in debug directories under the sysroot.
4947
4948 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * symtab.h (struct minimal_symbol data_p): New const method.
4951         (struct minimal_symbol text_p): Likewise.
4952         * symtab.c (output_source_filename): Use file name style
4953         to print file name.
4954         (print_symbol_info): Likewise.
4955         (print_msymbol_info): Use address style to print addresses.
4956         Use function name style to print executable text symbols.
4957         (expand_symtab_containing_pc): Use data_p.
4958         (find_pc_sect_compunit_symtab): Likewise.
4959
4960 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961
4962         * breakpoint.c (describe_other_breakpoints): Use address style
4963         to print addresses.
4964         (say_where): Likewise.
4965
4966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4967
4968         * ada-typeprint.c (print_func_type): Print function name
4969         style to print function name.
4970         * c-typeprint.c (c_print_type_1): Likewise.
4971
4972 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4973
4974         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4975         for execve.
4976
4977 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4978
4979         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4980         type_stack.
4981
4982 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4983
4984         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4985         TYPE_CODE_REF types.
4986
4987 2019-02-08  Jim Wilson  <jimw@sifive.com>
4988
4989         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4990         (riscv_linux_fregset): New.
4991         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4992
4993 2019-02-07  Tom Tromey  <tom@tromey.com>
4994
4995         * thread.c (thread_cancel_execution_command): Update.
4996         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4997         methods.
4998         (struct thread_fsm_ops): Remove.
4999         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5000         (thread_fsm_should_stop, thread_fsm_return_value)
5001         (thread_fsm_set_finished, thread_fsm_finished_p)
5002         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5003         Don't declare.
5004         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5005         * infrun.c (clear_proceed_status_thread)
5006         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5007         (print_stop_event): Update.
5008         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5009         Add constructor.
5010         (step_command_fsm_ops): Remove.
5011         (new_step_command_fsm): Remove.
5012         (step_1): Update.
5013         (step_command_fsm::should_stop): Rename from
5014         step_command_fsm_should_stop.
5015         (step_command_fsm::clean_up): Rename from
5016         step_command_fsm_clean_up.
5017         (step_command_fsm::do_async_reply_reason): Rename from
5018         step_command_fsm_async_reply_reason.
5019         (struct until_next_fsm): Inherit from thread_fsm.  Add
5020         constructor.
5021         (until_next_fsm_ops): Remove.
5022         (new_until_next_fsm): Remove.
5023         (until_next_fsm::should_stop): Rename from
5024         until_next_fsm_should_stop.
5025         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5026         (until_next_fsm::do_async_reply_reason): Rename from
5027         until_next_fsm_async_reply_reason.
5028         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5029         constructor.  Change type of breakpoint.
5030         (finish_command_fsm_ops): Remove.
5031         (new_finish_command_fsm): Remove.
5032         (finish_command_fsm::should_stop): Rename from
5033         finish_command_fsm_should_stop.
5034         (finish_command_fsm::clean_up): Rename from
5035         finish_command_fsm_clean_up.
5036         (finish_command_fsm::return_value): Rename from
5037         finish_command_fsm_return_value.
5038         (finish_command_fsm::do_async_reply_reason): Rename from
5039         finish_command_fsm_async_reply_reason.
5040         (finish_command): Update.
5041         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5042         Add constructor.
5043         (call_thread_fsm_ops): Remove.
5044         (call_thread_fsm::call_thread_fsm): Rename from
5045         new_call_thread_fsm.
5046         (call_thread_fsm::should_stop): Rename from
5047         call_thread_fsm_should_stop.
5048         (call_thread_fsm::should_notify_stop): Rename from
5049         call_thread_fsm_should_notify_stop.
5050         (run_inferior_call, call_function_by_hand_dummy): Update.
5051         * cli/cli-interp.c (should_print_stop_to_console): Update.
5052         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5053         Add constructor.  Change type of location_breakpoint,
5054         caller_breakpoint.
5055         (until_break_fsm_ops): Remove.
5056         (new_until_break_fsm): Remove.
5057         (until_break_fsm::should_stop): Rename from
5058         until_break_fsm_should_stop.
5059         (until_break_fsm::clean_up): Rename from
5060         until_break_fsm_clean_up.
5061         (until_break_fsm::do_async_reply_reason): Rename from
5062         until_break_fsm_async_reply_reason.
5063         (until_break_command): Update.
5064         * thread-fsm.c: Remove.
5065         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5066
5067 2019-02-07  Tom Tromey  <tom@tromey.com>
5068
5069         * yy-remap.h: Add include guard.
5070         * xtensa-tdep.h: Add include guard.
5071         * xcoffread.h: Rename include guard.
5072         * varobj-iter.h: Add include guard.
5073         * tui/tui.h: Rename include guard.
5074         * tui/tui-winsource.h: Rename include guard.
5075         * tui/tui-wingeneral.h: Rename include guard.
5076         * tui/tui-windata.h: Rename include guard.
5077         * tui/tui-win.h: Rename include guard.
5078         * tui/tui-stack.h: Rename include guard.
5079         * tui/tui-source.h: Rename include guard.
5080         * tui/tui-regs.h: Rename include guard.
5081         * tui/tui-out.h: Rename include guard.
5082         * tui/tui-layout.h: Rename include guard.
5083         * tui/tui-io.h: Rename include guard.
5084         * tui/tui-hooks.h: Rename include guard.
5085         * tui/tui-file.h: Rename include guard.
5086         * tui/tui-disasm.h: Rename include guard.
5087         * tui/tui-data.h: Rename include guard.
5088         * tui/tui-command.h: Rename include guard.
5089         * tic6x-tdep.h: Add include guard.
5090         * target/waitstatus.h: Rename include guard.
5091         * target/wait.h: Rename include guard.
5092         * target/target.h: Rename include guard.
5093         * target/resume.h: Rename include guard.
5094         * target-float.h: Rename include guard.
5095         * stabsread.h: Add include guard.
5096         * rs6000-tdep.h: Add include guard.
5097         * riscv-fbsd-tdep.h: Add include guard.
5098         * regformats/regdef.h: Rename include guard.
5099         * record.h: Rename include guard.
5100         * python/python.h: Rename include guard.
5101         * python/python-internal.h: Rename include guard.
5102         * python/py-stopevent.h: Rename include guard.
5103         * python/py-ref.h: Rename include guard.
5104         * python/py-record.h: Rename include guard.
5105         * python/py-record-full.h: Rename include guard.
5106         * python/py-record-btrace.h: Rename include guard.
5107         * python/py-instruction.h: Rename include guard.
5108         * python/py-events.h: Rename include guard.
5109         * python/py-event.h: Rename include guard.
5110         * procfs.h: Add include guard.
5111         * proc-utils.h: Add include guard.
5112         * p-lang.h: Add include guard.
5113         * or1k-tdep.h: Rename include guard.
5114         * observable.h: Rename include guard.
5115         * nto-tdep.h: Rename include guard.
5116         * nat/x86-linux.h: Rename include guard.
5117         * nat/x86-linux-dregs.h: Rename include guard.
5118         * nat/x86-gcc-cpuid.h: Add include guard.
5119         * nat/x86-dregs.h: Rename include guard.
5120         * nat/x86-cpuid.h: Rename include guard.
5121         * nat/ppc-linux.h: Rename include guard.
5122         * nat/mips-linux-watch.h: Rename include guard.
5123         * nat/linux-waitpid.h: Rename include guard.
5124         * nat/linux-ptrace.h: Rename include guard.
5125         * nat/linux-procfs.h: Rename include guard.
5126         * nat/linux-osdata.h: Rename include guard.
5127         * nat/linux-nat.h: Rename include guard.
5128         * nat/linux-namespaces.h: Rename include guard.
5129         * nat/linux-btrace.h: Rename include guard.
5130         * nat/glibc_thread_db.h: Rename include guard.
5131         * nat/gdb_thread_db.h: Rename include guard.
5132         * nat/gdb_ptrace.h: Rename include guard.
5133         * nat/fork-inferior.h: Rename include guard.
5134         * nat/amd64-linux-siginfo.h: Rename include guard.
5135         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5136         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5137         * nat/aarch64-linux.h: Rename include guard.
5138         * nat/aarch64-linux-hw-point.h: Rename include guard.
5139         * mn10300-tdep.h: Add include guard.
5140         * mips-linux-tdep.h: Add include guard.
5141         * mi/mi-parse.h: Rename include guard.
5142         * mi/mi-out.h: Rename include guard.
5143         * mi/mi-main.h: Rename include guard.
5144         * mi/mi-interp.h: Rename include guard.
5145         * mi/mi-getopt.h: Rename include guard.
5146         * mi/mi-console.h: Rename include guard.
5147         * mi/mi-common.h: Rename include guard.
5148         * mi/mi-cmds.h: Rename include guard.
5149         * mi/mi-cmd-break.h: Rename include guard.
5150         * m2-lang.h: Add include guard.
5151         * location.h: Rename include guard.
5152         * linux-record.h: Rename include guard.
5153         * linux-nat.h: Add include guard.
5154         * linux-fork.h: Add include guard.
5155         * i386-darwin-tdep.h: Rename include guard.
5156         * hppa-linux-offsets.h: Add include guard.
5157         * guile/guile.h: Rename include guard.
5158         * guile/guile-internal.h: Rename include guard.
5159         * gnu-nat.h: Rename include guard.
5160         * gdb-stabs.h: Rename include guard.
5161         * frv-tdep.h: Add include guard.
5162         * f-lang.h: Add include guard.
5163         * event-loop.h: Add include guard.
5164         * darwin-nat.h: Rename include guard.
5165         * cp-abi.h: Rename include guard.
5166         * config/sparc/nm-sol2.h: Rename include guard.
5167         * config/nm-nto.h: Rename include guard.
5168         * config/nm-linux.h: Add include guard.
5169         * config/i386/nm-i386gnu.h: Rename include guard.
5170         * config/djgpp/nl_types.h: Rename include guard.
5171         * config/djgpp/langinfo.h: Rename include guard.
5172         * compile/gcc-cp-plugin.h: Add include guard.
5173         * compile/gcc-c-plugin.h: Add include guard.
5174         * compile/compile.h: Rename include guard.
5175         * compile/compile-object-run.h: Rename include guard.
5176         * compile/compile-object-load.h: Rename include guard.
5177         * compile/compile-internal.h: Rename include guard.
5178         * compile/compile-cplus.h: Rename include guard.
5179         * compile/compile-c.h: Rename include guard.
5180         * common/xml-utils.h: Rename include guard.
5181         * common/x86-xstate.h: Rename include guard.
5182         * common/version.h: Rename include guard.
5183         * common/vec.h: Rename include guard.
5184         * common/tdesc.h: Rename include guard.
5185         * common/selftest.h: Rename include guard.
5186         * common/scoped_restore.h: Rename include guard.
5187         * common/scoped_mmap.h: Rename include guard.
5188         * common/scoped_fd.h: Rename include guard.
5189         * common/safe-iterator.h: Rename include guard.
5190         * common/run-time-clock.h: Rename include guard.
5191         * common/refcounted-object.h: Rename include guard.
5192         * common/queue.h: Rename include guard.
5193         * common/ptid.h: Rename include guard.
5194         * common/print-utils.h: Rename include guard.
5195         * common/preprocessor.h: Rename include guard.
5196         * common/pathstuff.h: Rename include guard.
5197         * common/observable.h: Rename include guard.
5198         * common/netstuff.h: Rename include guard.
5199         * common/job-control.h: Rename include guard.
5200         * common/host-defs.h: Rename include guard.
5201         * common/gdb_wait.h: Rename include guard.
5202         * common/gdb_vecs.h: Rename include guard.
5203         * common/gdb_unlinker.h: Rename include guard.
5204         * common/gdb_unique_ptr.h: Rename include guard.
5205         * common/gdb_tilde_expand.h: Rename include guard.
5206         * common/gdb_sys_time.h: Rename include guard.
5207         * common/gdb_string_view.h: Rename include guard.
5208         * common/gdb_splay_tree.h: Rename include guard.
5209         * common/gdb_setjmp.h: Rename include guard.
5210         * common/gdb_ref_ptr.h: Rename include guard.
5211         * common/gdb_optional.h: Rename include guard.
5212         * common/gdb_locale.h: Rename include guard.
5213         * common/gdb_assert.h: Rename include guard.
5214         * common/filtered-iterator.h: Rename include guard.
5215         * common/filestuff.h: Rename include guard.
5216         * common/fileio.h: Rename include guard.
5217         * common/environ.h: Rename include guard.
5218         * common/common-utils.h: Rename include guard.
5219         * common/common-types.h: Rename include guard.
5220         * common/common-regcache.h: Rename include guard.
5221         * common/common-inferior.h: Rename include guard.
5222         * common/common-gdbthread.h: Rename include guard.
5223         * common/common-exceptions.h: Rename include guard.
5224         * common/common-defs.h: Rename include guard.
5225         * common/common-debug.h: Rename include guard.
5226         * common/cleanups.h: Rename include guard.
5227         * common/buffer.h: Rename include guard.
5228         * common/btrace-common.h: Rename include guard.
5229         * common/break-common.h: Rename include guard.
5230         * cli/cli-utils.h: Rename include guard.
5231         * cli/cli-style.h: Rename include guard.
5232         * cli/cli-setshow.h: Rename include guard.
5233         * cli/cli-script.h: Rename include guard.
5234         * cli/cli-interp.h: Rename include guard.
5235         * cli/cli-decode.h: Rename include guard.
5236         * cli/cli-cmds.h: Rename include guard.
5237         * charset-list.h: Add include guard.
5238         * buildsym-legacy.h: Rename include guard.
5239         * bfin-tdep.h: Add include guard.
5240         * ax.h: Rename include guard.
5241         * arm-linux-tdep.h: Add include guard.
5242         * arm-fbsd-tdep.h: Add include guard.
5243         * arch/xtensa.h: Rename include guard.
5244         * arch/tic6x.h: Add include guard.
5245         * arch/i386.h: Add include guard.
5246         * arch/arm.h: Rename include guard.
5247         * arch/arm-linux.h: Rename include guard.
5248         * arch/arm-get-next-pcs.h: Rename include guard.
5249         * arch/amd64.h: Add include guard.
5250         * arch/aarch64-insn.h: Rename include guard.
5251         * arch-utils.h: Rename include guard.
5252         * annotate.h: Add include guard.
5253         * amd64-darwin-tdep.h: Rename include guard.
5254         * aarch64-linux-tdep.h: Add include guard.
5255         * aarch64-fbsd-tdep.h: Add include guard.
5256         * aarch32-linux-nat.h: Add include guard.
5257
5258 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5259
5260         * macrotab.c (macro_define_internal): New function that
5261         factorizes macro_define_object_internal and macro_define_function
5262         code.
5263         (macro_define_object_internal): Use macro_define_internal.
5264         (macro_define_function): Likewise.
5265
5266 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5267
5268         * macrocmd.c (extract_identifier): Return
5269         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5270         callers.
5271
5272 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5273
5274         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5275
5276 2019-02-05  Tom Tromey  <tom@tromey.com>
5277
5278         * target.c (target_stack::unpush): Move assertion earlier.
5279
5280 2019-01-30  Tom Tromey  <tom@tromey.com>
5281
5282         PR python/23615:
5283         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5284         (gdbpy_parse_and_eval): Likewise.
5285         * python/python-internal.h (gdbpy_allow_threads): New class.
5286
5287 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5288
5289         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5290         (aarch64_fbsd_fpregmap): Move earlier.
5291         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5292         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5293         instead of individual calls to trad_frame_set_reg_addr.
5294         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5295         earlier.
5296         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5297         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5298         instead of individual calls to trad_frame_set_reg_addr.
5299
5300 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5301
5302         * CONTRIBUTE: Replace contribution list with wiki link.
5303
5304 2019-01-25  Tom Tromey  <tom@tromey.com>
5305
5306         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5307
5308 2019-01-25  Tom Tromey  <tom@tromey.com>
5309
5310         * xtensa-linux-nat.c: Fix common/ includes.
5311         * xml-support.h: Fix common/ includes.
5312         * xml-support.c: Fix common/ includes.
5313         * x86-linux-nat.c: Fix common/ includes.
5314         * windows-nat.c: Fix common/ includes.
5315         * varobj.h: Fix common/ includes.
5316         * varobj.c: Fix common/ includes.
5317         * value.c: Fix common/ includes.
5318         * valops.c: Fix common/ includes.
5319         * utils.c: Fix common/ includes.
5320         * unittests/xml-utils-selftests.c: Fix common/ includes.
5321         * unittests/utils-selftests.c: Fix common/ includes.
5322         * unittests/unpack-selftests.c: Fix common/ includes.
5323         * unittests/tracepoint-selftests.c: Fix common/ includes.
5324         * unittests/style-selftests.c: Fix common/ includes.
5325         * unittests/string_view-selftests.c: Fix common/ includes.
5326         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5327         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5328         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5329         * unittests/rsp-low-selftests.c: Fix common/ includes.
5330         * unittests/parse-connection-spec-selftests.c: Fix common/
5331         includes.
5332         * unittests/optional-selftests.c: Fix common/ includes.
5333         * unittests/offset-type-selftests.c: Fix common/ includes.
5334         * unittests/observable-selftests.c: Fix common/ includes.
5335         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5336         * unittests/memrange-selftests.c: Fix common/ includes.
5337         * unittests/memory-map-selftests.c: Fix common/ includes.
5338         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5339         * unittests/function-view-selftests.c: Fix common/ includes.
5340         * unittests/environ-selftests.c: Fix common/ includes.
5341         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5342         * unittests/common-utils-selftests.c: Fix common/ includes.
5343         * unittests/cli-utils-selftests.c: Fix common/ includes.
5344         * unittests/array-view-selftests.c: Fix common/ includes.
5345         * ui-file.c: Fix common/ includes.
5346         * tui/tui-io.c: Fix common/ includes.
5347         * tracepoint.h: Fix common/ includes.
5348         * tracepoint.c: Fix common/ includes.
5349         * tracefile-tfile.c: Fix common/ includes.
5350         * top.h: Fix common/ includes.
5351         * top.c: Fix common/ includes.
5352         * thread.c: Fix common/ includes.
5353         * target/waitstatus.h: Fix common/ includes.
5354         * target/waitstatus.c: Fix common/ includes.
5355         * target.h: Fix common/ includes.
5356         * target.c: Fix common/ includes.
5357         * target-memory.c: Fix common/ includes.
5358         * target-descriptions.c: Fix common/ includes.
5359         * symtab.h: Fix common/ includes.
5360         * symfile.c: Fix common/ includes.
5361         * stap-probe.c: Fix common/ includes.
5362         * spu-linux-nat.c: Fix common/ includes.
5363         * sparc-nat.c: Fix common/ includes.
5364         * source.c: Fix common/ includes.
5365         * solib.c: Fix common/ includes.
5366         * solib-target.c: Fix common/ includes.
5367         * ser-unix.c: Fix common/ includes.
5368         * ser-tcp.c: Fix common/ includes.
5369         * ser-pipe.c: Fix common/ includes.
5370         * ser-base.c: Fix common/ includes.
5371         * selftest-arch.c: Fix common/ includes.
5372         * s12z-tdep.c: Fix common/ includes.
5373         * rust-exp.y: Fix common/ includes.
5374         * rs6000-aix-tdep.c: Fix common/ includes.
5375         * riscv-tdep.c: Fix common/ includes.
5376         * remote.c: Fix common/ includes.
5377         * remote-notif.h: Fix common/ includes.
5378         * remote-fileio.h: Fix common/ includes.
5379         * remote-fileio.c: Fix common/ includes.
5380         * regcache.h: Fix common/ includes.
5381         * regcache.c: Fix common/ includes.
5382         * record-btrace.c: Fix common/ includes.
5383         * python/python.c: Fix common/ includes.
5384         * python/py-type.c: Fix common/ includes.
5385         * python/py-inferior.c: Fix common/ includes.
5386         * progspace.h: Fix common/ includes.
5387         * producer.c: Fix common/ includes.
5388         * procfs.c: Fix common/ includes.
5389         * proc-api.c: Fix common/ includes.
5390         * printcmd.c: Fix common/ includes.
5391         * ppc-linux-nat.c: Fix common/ includes.
5392         * parser-defs.h: Fix common/ includes.
5393         * osdata.c: Fix common/ includes.
5394         * obsd-nat.c: Fix common/ includes.
5395         * nat/x86-linux.c: Fix common/ includes.
5396         * nat/x86-linux-dregs.c: Fix common/ includes.
5397         * nat/x86-dregs.h: Fix common/ includes.
5398         * nat/x86-dregs.c: Fix common/ includes.
5399         * nat/ppc-linux.c: Fix common/ includes.
5400         * nat/mips-linux-watch.h: Fix common/ includes.
5401         * nat/mips-linux-watch.c: Fix common/ includes.
5402         * nat/linux-waitpid.c: Fix common/ includes.
5403         * nat/linux-ptrace.h: Fix common/ includes.
5404         * nat/linux-ptrace.c: Fix common/ includes.
5405         * nat/linux-procfs.c: Fix common/ includes.
5406         * nat/linux-personality.c: Fix common/ includes.
5407         * nat/linux-osdata.c: Fix common/ includes.
5408         * nat/linux-namespaces.c: Fix common/ includes.
5409         * nat/linux-btrace.h: Fix common/ includes.
5410         * nat/linux-btrace.c: Fix common/ includes.
5411         * nat/fork-inferior.c: Fix common/ includes.
5412         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5413         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5414         * nat/aarch64-linux.c: Fix common/ includes.
5415         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5416         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5417         * namespace.h: Fix common/ includes.
5418         * mips-linux-tdep.c: Fix common/ includes.
5419         * minsyms.c: Fix common/ includes.
5420         * mi/mi-parse.h: Fix common/ includes.
5421         * mi/mi-main.c: Fix common/ includes.
5422         * mi/mi-cmd-env.c: Fix common/ includes.
5423         * memrange.h: Fix common/ includes.
5424         * memattr.c: Fix common/ includes.
5425         * maint.h: Fix common/ includes.
5426         * maint.c: Fix common/ includes.
5427         * main.c: Fix common/ includes.
5428         * machoread.c: Fix common/ includes.
5429         * location.c: Fix common/ includes.
5430         * linux-thread-db.c: Fix common/ includes.
5431         * linux-nat.c: Fix common/ includes.
5432         * linux-fork.c: Fix common/ includes.
5433         * inline-frame.c: Fix common/ includes.
5434         * infrun.c: Fix common/ includes.
5435         * inflow.c: Fix common/ includes.
5436         * inferior.h: Fix common/ includes.
5437         * inferior.c: Fix common/ includes.
5438         * infcmd.c: Fix common/ includes.
5439         * inf-ptrace.c: Fix common/ includes.
5440         * inf-child.c: Fix common/ includes.
5441         * ia64-linux-nat.c: Fix common/ includes.
5442         * i387-tdep.c: Fix common/ includes.
5443         * i386-tdep.c: Fix common/ includes.
5444         * i386-linux-tdep.c: Fix common/ includes.
5445         * i386-linux-nat.c: Fix common/ includes.
5446         * i386-go32-tdep.c: Fix common/ includes.
5447         * i386-fbsd-tdep.c: Fix common/ includes.
5448         * i386-fbsd-nat.c: Fix common/ includes.
5449         * guile/scm-type.c: Fix common/ includes.
5450         * guile/guile.c: Fix common/ includes.
5451         * go32-nat.c: Fix common/ includes.
5452         * gnu-nat.c: Fix common/ includes.
5453         * gdbthread.h: Fix common/ includes.
5454         * gdbarch-selftests.c: Fix common/ includes.
5455         * gdb_usleep.c: Fix common/ includes.
5456         * gdb_select.h: Fix common/ includes.
5457         * gdb_bfd.c: Fix common/ includes.
5458         * gcore.c: Fix common/ includes.
5459         * fork-child.c: Fix common/ includes.
5460         * findvar.c: Fix common/ includes.
5461         * fbsd-nat.c: Fix common/ includes.
5462         * event-top.c: Fix common/ includes.
5463         * event-loop.c: Fix common/ includes.
5464         * dwarf2read.c: Fix common/ includes.
5465         * dwarf2loc.c: Fix common/ includes.
5466         * dwarf2-frame.c: Fix common/ includes.
5467         * dwarf-index-cache.c: Fix common/ includes.
5468         * dtrace-probe.c: Fix common/ includes.
5469         * disasm-selftests.c: Fix common/ includes.
5470         * defs.h: Fix common/ includes.
5471         * csky-tdep.c: Fix common/ includes.
5472         * cp-valprint.c: Fix common/ includes.
5473         * cp-support.h: Fix common/ includes.
5474         * cp-support.c: Fix common/ includes.
5475         * corelow.c: Fix common/ includes.
5476         * completer.h: Fix common/ includes.
5477         * completer.c: Fix common/ includes.
5478         * compile/compile.c: Fix common/ includes.
5479         * compile/compile-loc2c.c: Fix common/ includes.
5480         * compile/compile-cplus-types.c: Fix common/ includes.
5481         * compile/compile-cplus-symbols.c: Fix common/ includes.
5482         * command.h: Fix common/ includes.
5483         * cli/cli-dump.c: Fix common/ includes.
5484         * cli/cli-cmds.c: Fix common/ includes.
5485         * charset.c: Fix common/ includes.
5486         * build-id.c: Fix common/ includes.
5487         * btrace.h: Fix common/ includes.
5488         * btrace.c: Fix common/ includes.
5489         * breakpoint.h: Fix common/ includes.
5490         * breakpoint.c: Fix common/ includes.
5491         * ax.h:
5492         (enum agent_op): Fix common/ includes.
5493         * ax-general.c (struct aop_map): Fix common/ includes.
5494         * ax-gdb.c: Fix common/ includes.
5495         * auxv.c: Fix common/ includes.
5496         * auto-load.c: Fix common/ includes.
5497         * arm-tdep.c: Fix common/ includes.
5498         * arch/riscv.c: Fix common/ includes.
5499         * arch/ppc-linux-common.c: Fix common/ includes.
5500         * arch/i386.c: Fix common/ includes.
5501         * arch/arm.c: Fix common/ includes.
5502         * arch/arm-linux.c: Fix common/ includes.
5503         * arch/arm-get-next-pcs.c: Fix common/ includes.
5504         * arch/amd64.c: Fix common/ includes.
5505         * arch/aarch64.c: Fix common/ includes.
5506         * arch/aarch64-insn.c: Fix common/ includes.
5507         * arch-utils.c: Fix common/ includes.
5508         * amd64-windows-tdep.c: Fix common/ includes.
5509         * amd64-tdep.c: Fix common/ includes.
5510         * amd64-sol2-tdep.c: Fix common/ includes.
5511         * amd64-obsd-tdep.c: Fix common/ includes.
5512         * amd64-nbsd-tdep.c: Fix common/ includes.
5513         * amd64-linux-tdep.c: Fix common/ includes.
5514         * amd64-linux-nat.c: Fix common/ includes.
5515         * amd64-fbsd-tdep.c: Fix common/ includes.
5516         * amd64-fbsd-nat.c: Fix common/ includes.
5517         * amd64-dicos-tdep.c: Fix common/ includes.
5518         * amd64-darwin-tdep.c: Fix common/ includes.
5519         * agent.c: Fix common/ includes.
5520         * ada-lang.h: Fix common/ includes.
5521         * ada-lang.c: Fix common/ includes.
5522         * aarch64-tdep.c: Fix common/ includes.
5523
5524 2019-01-25  Tom Tromey  <tom@tromey.com>
5525
5526         * common/create-version.sh: Use common/version.h.
5527
5528 2019-01-24  Pedro Alves  <palves@redhat.com>
5529
5530         * infrun.c (signal_stop, signal_print, signal_program)
5531         (signal_catch, signal_pass): Now arrays instead of pointers.
5532         (update_signals_program_target, do_target_resume)
5533         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5534         * linux-nat.c (linux_nat_target::pass_signals)
5535         (linux_nat_target::create_inferior, linux_nat_target::attach):
5536         Adjust.
5537         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5538         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5539         * procfs.c (procfs_target::pass_signals): Adjust.
5540         * record-full.c (record_full_target::resume): Adjust.
5541         * remote.c (remote_target::pass_signals)
5542         (remote_target::program_signals): Adjust.
5543         * target-debug.h (target_debug_print_signals): Now takes a
5544         gdb::array_view as parameter.  Adjust.
5545         * target.h (target_ops) <pass_signals, program_signals>: Replace
5546         pointer and length parameters with gdb::array_view.
5547         (target_pass_signals, target_program_signals): Likewise.
5548         * target-delegates.c: Regenerate.
5549
5550 2019-01-24  Pedro Alves  <palves@redhat.com>
5551
5552         * common/forward-scope-exit.h
5553         (forward_scope_exit::forward_scope_exit): Pass arguments to
5554         m_bind_function directly, instead of creating a std::bind and
5555         copying that.
5556
5557 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5558
5559         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5560         for static members.
5561         (pass_in_v_vfp_candidate): Likewise.
5562
5563 2019-01-23  Tom Tromey  <tom@tromey.com>
5564             Pedro Alves  <palves@redhat.com>
5565
5566         * regcache.c (class regcache_invalidator): Remove.
5567         (regcache::raw_write): Use make_scope_exit.
5568
5569 2019-01-23  Tom Tromey  <tom@tromey.com>
5570
5571         * ui-out.h (class ui_out_emit_type): Update comment.
5572
5573 2019-01-23  Tom Tromey  <tom@tromey.com>
5574
5575         * infrun.c (fetch_inferior_event): Update comment.
5576
5577 2019-01-23  Tom Tromey  <tom@tromey.com>
5578             Pedro Alves  <palves@redhat.com>
5579
5580         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5581         parameter.
5582         (fetch_inferior_event): Use SCOPE_EXIT.
5583
5584
5585 2019-01-23  Tom Tromey  <tom@tromey.com>
5586             Pedro Alves  <palves@redhat.com>
5587
5588         * infrun.c (disable_thread_events): Delete.
5589         (stop_all_threads): Use SCOPE_EXIT.
5590
5591 2019-01-23  Tom Tromey  <tom@tromey.com>
5592             Pedro Alves  <palves@redhat.com>
5593
5594         * symfile.c: Include forward-scope-exit.h.
5595         (clear_symtab_users_cleanup): Replace forward declaration with
5596         a FORWARD_SCOPE_EXIT.
5597         (syms_from_objfile_1): Use the forward_scope_exit and
5598         gdb::optional instead of cleanup_function.
5599         (reread_symbols): Use the forward_scope_exit instead of
5600         cleanup_function.
5601         (clear_symtab_users_cleanup): Remove function.
5602
5603 2019-01-23  Tom Tromey  <tom@tromey.com>
5604             Pedro Alves  <palves@redhat.com>
5605
5606         * linux-nat.c: Include scope-exit.h.
5607         (cleanup_target_stop): Remove.
5608         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5609         SCOPE_EXIT.
5610
5611 2019-01-23  Tom Tromey  <tom@tromey.com>
5612             Pedro Alves  <palves@redhat.com>
5613
5614         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5615         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5616
5617 2019-01-23  Tom Tromey  <tom@tromey.com>
5618             Andrew Burgess  <andrew.burgess@embecosm.com>
5619             Pedro Alves  <palves@redhat.com>
5620
5621         * infrun.c (fetch_inferior_event): Use scope_exit.
5622         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5623         * top.c (execute_command): Use scope_exit.
5624         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5625         * utils.c (do_bpstat_clear_actions_cleanup)
5626         (make_bpstat_clear_actions_cleanup): Remove.
5627
5628 2019-01-23  Tom Tromey  <tom@tromey.com>
5629             Pedro Alves  <palves@redhat.com>
5630
5631         * infrun.c: Include "common/scope-exit.h"
5632         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5633         (wait_for_inferior): Use SCOPE_EXIT.
5634         (fetch_inferior_event): Use scope_exit.
5635
5636 2019-01-23  Tom Tromey  <tom@tromey.com>
5637             Pedro Alves  <palves@redhat.com>
5638
5639         * breakpoint.c (create_breakpoint): Remove cleanup.
5640
5641 2019-01-23  Tom Tromey  <tom@tromey.com>
5642             Andrew Burgess  <andrew.burgess@embecosm.com>
5643             Pedro Alves  <palves@redhat.com>
5644
5645 2019-01-23  Pedro Alves  <palves@redhat.com>
5646
5647         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5648
5649 2019-01-23  Pedro Alves  <palves@redhat.com>
5650             Andrew Burgess  <andrew.burgess@embecosm.com>
5651
5652         * gdbthread.h: Include "common/forward-scope-exit.h".
5653         (scoped_finish_thread_state): Redefine custom class in terms of
5654         forward_scope_exit.
5655
5656 2019-01-23  Pedro Alves  <palves@redhat.com>
5657             Andrew Burgess  <andrew.burgess@embecosm.com>
5658
5659         * common/forward-scope-exit.h: New file.
5660
5661 2019-01-23  Pedro Alves  <palves@redhat.com>
5662             Andrew Burgess  <andrew.burgess@embecosm.com>
5663             Tom Tromey  <tom@tromey.com>
5664
5665         * common/scope-exit.h: New file.
5666
5667 2019-01-23  Pedro Alves  <palves@redhat.com>
5668
5669         * common/preprocessor.h (ESC): Rename to ...
5670         (ESC_PARENS): ... this.
5671         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5672         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5673
5674 2019-01-23  Tom Tromey  <tom@tromey.com>
5675
5676         * language.h (class scoped_switch_to_sym_language_if_auto):
5677         Initialize m_lang in both cases.
5678
5679 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5680
5681         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5682         with XCNEW.
5683
5684 2019-01-22  Tom Tromey  <tom@tromey.com>
5685
5686         * corelow.c: Do not include sys/file.h.
5687
5688 2019-01-22  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-wingeneral.h: Include gdb_curses.h.
5691
5692 2019-01-22  Tom Tromey  <tom@tromey.com>
5693
5694         * source-cache.h (class source_cache) <get_source_lines,
5695         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5696
5697 2019-01-22  Tom Tromey  <tom@tromey.com>
5698
5699         * remote-fileio.h (struct remote_target): Declare.
5700
5701 2019-01-22  Tom Tromey  <tom@tromey.com>
5702
5703         * python/py-arch.c: Do not include py-ref.h.
5704         * python/py-bpevent.c: Do not include py-ref.h.
5705         * python/py-cmd.c: Do not include py-ref.h.
5706         * python/py-continueevent.c: Do not include py-ref.h.
5707         * python/py-event.h: Do not include py-ref.h.
5708         * python/py-evtregistry.c: Do not include py-ref.h.
5709         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5710         * python/py-frame.c: Do not include py-ref.h.
5711         * python/py-framefilter.c: Do not include py-ref.h.
5712         * python/py-function.c: Do not include py-ref.h.
5713         * python/py-infevents.c: Do not include py-ref.h.
5714         * python/py-linetable.c: Do not include py-ref.h.
5715         * python/py-objfile.c: Do not include py-ref.h.
5716         * python/py-param.c: Do not include py-ref.h.
5717         * python/py-prettyprint.c: Do not include py-ref.h.
5718         * python/py-progspace.c: Do not include py-ref.h.
5719         * python/py-symbol.c: Do not include py-ref.h.
5720         * python/py-symtab.c: Do not include py-ref.h.
5721         * python/py-type.c: Do not include py-ref.h.
5722         * python/py-unwind.c: Do not include py-ref.h.
5723         * python/py-utils.c: Do not include py-ref.h.
5724         * python/py-value.c: Do not include py-ref.h.
5725         * python/py-varobj.c: Do not include py-ref.h.
5726         * python/py-xmethods.c: Do not include py-ref.h.
5727         * python/python.c: Do not include py-ref.h.
5728         * varobj.c: Do not include py-ref.h.
5729
5730 2019-01-22  Tom Tromey  <tom@tromey.com>
5731
5732         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5733         keyword for bcache.
5734
5735 2019-01-22  Tom Tromey  <tom@tromey.com>
5736
5737         * compile/compile-cplus-types.c: Remove a comment by #include.
5738
5739 2019-01-22  Tom Tromey  <tom@tromey.com>
5740
5741         * compile/gcc-c-plugin.h: Include compile-internal.h.
5742
5743 2019-01-22  Tom Tromey  <tom@tromey.com>
5744
5745         * stabsread.c (EXTERN): Do not define.
5746         (symnum, next_symbol_text_func, processing_gcc_compilation)
5747         (within_function, global_sym_chain, global_stabs)
5748         (previous_stab_code, this_object_header_files)
5749         (n_this_object_header_files)
5750         (n_allocated_this_object_header_files): Define.
5751         * stabsread.h (EXTERN): Never define.  Use "extern".
5752
5753 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754
5755         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5756         history_value.
5757
5758 2019-01-21  Tom Tromey  <tom@tromey.com>
5759
5760         * ui-out.c: Fix includes.
5761         * tui/tui-source.c: Fix includes.
5762         * target.c: Fix includes.
5763         * remote.c: Fix includes.
5764         * regcache.c: Fix includes.
5765         * python/py-block.c: Fix includes.
5766         * printcmd.c: Fix includes.
5767         * or1k-tdep.c: Fix includes.
5768         * mi/mi-main.c: Fix includes.
5769         * m32r-tdep.c: Fix includes.
5770         * csky-tdep.c: Fix includes.
5771         * compile/compile-cplus-types.c: Fix includes.
5772         * cli/cli-interp.c: Fix includes.
5773
5774 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5775
5776         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5777         for padding.
5778
5779 2019-01-16  Tom Tromey  <tom@tromey.com>
5780
5781         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5782         earlier.
5783         (struct objfile) <msymbols_range>: Move from top level.
5784         <msymbols>: New method.
5785         (class objfile_msymbols): Remove.
5786         * symtab.c (default_collect_symbol_completion_matches_break_on):
5787         Update.
5788         * symmisc.c (dump_msymbols): Update.
5789         * stabsread.c (scan_file_globals): Update.
5790         * objc-lang.c (info_selectors_command, info_classes_command)
5791         (find_methods): Update.
5792         * minsyms.c (find_solib_trampoline_target): Update.
5793         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5794         * coffread.c (coff_symfile_read): Update.
5795         * ada-lang.c (ada_lookup_simple_minsym)
5796         (ada_collect_symbol_completion_matches): Update.
5797
5798 2019-01-16  Tom Tromey  <tom@tromey.com>
5799
5800         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5801         type.  Remove no-argument constructor.
5802         <iterator::operator++>: Simplify.
5803         <begin>: Update.
5804         <end>: Use minimal_symbol_count.
5805
5806 2019-01-16  Tom Tromey  <tom@tromey.com>
5807
5808         * objfiles.h (struct objfile) <psymtabs>: New method.
5809         (class objfile_psymtabs): Remove.
5810         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5811         typedef.
5812         <range>: New method.
5813         (require_partial_symbols): Change return type.
5814         * psymtab.c (require_partial_symbols)
5815         (psym_expand_symtabs_matching): Update.
5816         * mdebugread.c (parse_partial_symbols): Update.
5817         * dbxread.c (dbx_end_psymtab): Update.
5818
5819 2019-01-15  Tom Tromey  <tom@tromey.com>
5820
5821         * symtab.c (lookup_objfile_from_block)
5822         (lookup_symbol_in_objfile_symtabs)
5823         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5824         (find_line_symtab, info_sources_command)
5825         (default_collect_symbol_completion_matches_break_on)
5826         (make_source_files_completion_list): Update.
5827         * symmisc.c (print_objfile_statistics, dump_objfile)
5828         (maintenance_print_symbols, maintenance_info_symtabs)
5829         (maintenance_check_symtabs, maintenance_info_line_tables):
5830         Update.
5831         * source.c (select_source_symtab)
5832         (forget_cached_source_info_for_objfile): Update.
5833         * objfiles.h (class objfile_compunits): Remove.
5834         (struct objfile) <compunits_range>: New typedef.
5835         (compunits): New method.
5836         * objfiles.c (objfile_relocate1): Update.
5837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5838         * maint.c (count_symtabs_and_blocks): Update.
5839         * linespec.c (iterate_over_all_matching_symtabs): Update.
5840         * cp-support.c (add_symbol_overload_list_qualified): Update.
5841         * coffread.c (coff_symtab_read): Update.
5842         * ada-lang.c (add_nonlocal_symbols)
5843         (ada_collect_symbol_completion_matches)
5844         (ada_add_global_exceptions): Update.
5845
5846 2019-01-15  Tom Tromey  <tom@tromey.com>
5847
5848         * progspace.h (program_space) <objfiles_safe_range>: New
5849         typedef.
5850         <objfiles_safe>: New method.
5851         * objfiles.h (class all_objfiles_safe): Remove.
5852         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5853         * jit.c (jit_inferior_exit_hook): Update.
5854
5855 2019-01-17  Tom Tromey  <tom@tromey.com>
5856
5857         * progspace.h (program_space) <objfiles_range>: New typedef.
5858         <objfiles>: New method.
5859         <objfiles_head>: Rename from objfiles.
5860         (object_files): Update.
5861         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5862         * guile/scm-pretty-print.c
5863         (ppscm_find_pretty_printer_from_objfiles): Update.
5864         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5865         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5866         Update.
5867         * python/py-progspace.c (pspy_get_objfiles): Update.
5868         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5869         Update.
5870         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5871         (objfpy_lookup_objfile_by_build_id): Update.
5872         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5873         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5874         Update.
5875         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5876         (expand_symtab_containing_pc, lookup_objfile_from_block)
5877         (lookup_static_symbol, basic_lookup_transparent_type)
5878         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5879         (find_line_symtab, info_sources_command)
5880         (default_collect_symbol_completion_matches_break_on)
5881         (make_source_files_completion_list, find_main_name): Update.
5882         * symmisc.c (print_symbol_bcache_statistics)
5883         (print_objfile_statistics, maintenance_print_symbols)
5884         (maintenance_print_msymbols, maintenance_print_objfiles)
5885         (maintenance_info_symtabs, maintenance_check_symtabs)
5886         (maintenance_expand_symtabs, maintenance_info_line_tables):
5887         Update.
5888         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5889         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5890         (map_overlay_command, unmap_overlay_command)
5891         (simple_overlay_update, expand_symtabs_matching)
5892         (map_symbol_filenames): Update.
5893         * symfile-debug.c (set_debug_symfile): Update.
5894         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5895         Update.
5896         * source.c (select_source_symtab, forget_cached_source_info):
5897         Update.
5898         * solib.c (solib_read_symbols): Update.
5899         * solib-spu.c (append_ocl_sos): Update.
5900         * psymtab.c (maintenance_print_psymbols)
5901         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5902         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5903         * printcmd.c (info_symbol_command): Update.
5904         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5905         Update.
5906         * objfiles.h (class all_objfiles): Remove.
5907         * objfiles.c (have_partial_symbols, have_full_symbols)
5908         (have_minimal_symbols, qsort_cmp, update_section_map)
5909         (shared_objfile_contains_address_p)
5910         (default_iterate_over_objfiles_in_search_order): Update.
5911         * objc-lang.c (info_selectors_command, info_classes_command)
5912         (find_methods): Update.
5913         * minsyms.c (find_solib_trampoline_target): Update.
5914         * maint.c (maintenance_info_sections)
5915         (maintenance_translate_address, count_symtabs_and_blocks):
5916         Update.
5917         * main.c (captured_main_1): Update.
5918         * linux-thread-db.c (try_thread_db_load_from_pdir)
5919         (has_libpthread): Update.
5920         * linespec.c (iterate_over_all_matching_symtabs)
5921         (search_minsyms_for_name): Update.
5922         * jit.c (jit_find_objf_with_entry_addr): Update.
5923         * hppa-tdep.c (find_unwind_entry)
5924         (hppa_lookup_stub_minimal_symbol): Update.
5925         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5926         Update.
5927         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5928         (elf_gnu_ifunc_resolve_by_got): Update.
5929         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5930         * dwarf-index-write.c (save_gdb_index_command): Update.
5931         * cp-support.c (add_symbol_overload_list_qualified): Update.
5932         * breakpoint.c (create_overlay_event_breakpoint)
5933         (create_longjmp_master_breakpoint)
5934         (create_std_terminate_master_breakpoint)
5935         (create_exception_master_breakpoint): Update.
5936         * blockframe.c (find_pc_partial_function): Update.
5937         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5938         (ada_collect_symbol_completion_matches)
5939         (ada_add_global_exceptions): Update.
5940
5941 2019-01-17  Tom Tromey  <tom@tromey.com>
5942
5943         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5944         declare VEC.
5945         (solib_target_parse_libraries): Change return type.
5946         (library_list_start_segment, library_list_start_section)
5947         (library_list_end_library, library_list_start_library); Update.
5948         (solib_target_free_library_list): Remove.
5949         (solib_target_parse_libraries): Remove cleanup.  Change return
5950         type.
5951         (solib_target_current_sos): Update.
5952
5953 2019-01-17  Tom Tromey  <tromey@bapiya>
5954
5955         * valprint.c: Replace "the the" with "the".
5956         * symtab.c: Replace "the the" with "the".
5957         * solib.c: Replace "the the" with "the".
5958         * solib-dsbt.c: Replace "the the" with "the".
5959         * linespec.c: Replace "the the" with "the".
5960         * dwarf2loc.h: Replace "the the" with "the".
5961         * amd64-windows-tdep.c: Replace "the the" with "the".
5962         * aarch64-tdep.c: Replace "the the" with "the".
5963
5964 2019-01-16  Keith Seitz  <keiths@redhat.com>
5965
5966         PR gdb/23773
5967         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5968         <builder>: Rename to ..
5969         <m_builder>: ... this and make private.
5970         (dwarf2_cu::get_builder): New method.  Change all users of
5971         `builder' to use this method.
5972         (dwarf2_start_symtab): Move to ...
5973         (dwarf2_cu::start_symtab): ... here.  Update all callers
5974         (setup_type_unit_groups): Move to ...
5975         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5976         callers.
5977         (dwarf2_cu::reset_builder): New method.
5978         (process_full_compunit, process_full_type_unit): Use
5979         dwarf2_cu::reset_builder.
5980         (follow_die_offset): Record the ancestor CU if it is different
5981         from the followed DIE's CU.
5982         (follow_die_sig_1): Likewise.
5983
5984 2019-01-15  Tom Tromey  <tom@tromey.com>
5985
5986         * remote.c (class remote_state) <buf>: Now a char_vector.
5987         <buf_size>: Remove.
5988         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5989         parameter.
5990         (remote_target::getpkt_or_notif_sane_1)
5991         (remote_target::getpkt_sane)
5992         (remote_target::getpkt_or_notif_sane): Likewise.
5993         (class remote_target) <putpkt>: New overload.
5994         (remote_target::read_frame): Change type of "buf_p".  Remove
5995         sizeof_p parameter.
5996         (packet_ok): New overload.
5997         (packet_check_result): New overload.
5998         Update all uses.
5999
6000 2019-01-14  Tom Tromey  <tom@tromey.com>
6001
6002         * remote-notif.c (handle_notification, remote_notif_ack)
6003         (remote_notif_parse): Make "buf" const.
6004         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6005         const.
6006         (remote_notif_parse, remote_notif_ack, handle_notification):
6007         Likewise.
6008         * remote.c (remote_notif_stop_parse): Make "buf" const.
6009         (remote_target::remote_parse_stop_reply): Make "buf" const.
6010         (remote_notif_stop_ack): Make "buf" const.
6011
6012 2019-01-14  Tom Tromey  <tom@tromey.com>
6013
6014         * remote.c (remote_console_output): Make parameter const.
6015
6016 2019-01-14  Tom Tromey  <tom@tromey.com>
6017
6018         * target-debug.h (target_debug_print_signals): Constify.
6019         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6020         * procfs.c (procfs_target::pass_signals): Update.
6021         * linux-nat.c (linux_nat_target::pass_signals): Update.
6022         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6023         * target-delegates.c: Rebuild.
6024         * remote.c (remote_target::program_signals): Update.
6025         (remote_target::pass_signals): Update.
6026         * target.c (target_pass_signals): Constify argument.
6027         (target_program_signals): Likewise.
6028         * target.h (struct target_ops) <pass_signals, program_signals>:
6029         Constify argument.
6030         (target_pass_signals, target_program_signals): Constify argument.
6031
6032 2019-01-14  Tom Tromey  <tom@tromey.com>
6033
6034         PR tui/28819:
6035         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6036
6037 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6038
6039         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6040         field.
6041         * rs6000-tdep.c: Include reggroups.h.
6042         (IS_V_ALIAS_PSEUDOREG): Define.
6043         (rs6000_register_name): Return names for the "vX" aliases.
6044         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6045         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6046         aliases.  Call default_register_reggroup_p for all other
6047         pseudo-registers.
6048         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6049         New functions.
6050         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6051         Handle "vX" aliases.
6052         (v_alias_pseudo_register_collect): New function.
6053         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6054         (rs6000_gdbarch_init): Initialize "vX" aliases as
6055         pseudo-registers.  Restore registration of
6056         rs6000_pseudo_register_reggroup_p with
6057         set_tdesc_pseudo_register_reggroup_p.
6058
6059 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6060
6061         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6062         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6063         set_gdbarch_num_pseudo_regs.
6064
6065 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6066
6067         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6068         Remove arg prefixname, add do_set and do_show.
6069         Add member functions set_list and show_list.
6070         * cli/cli-style.c (class cli_style_option): Update accordingly.
6071         (style_set_list): Move to file scope.
6072         (style_show_list): Likewise.
6073         (set_style): Call help_list.
6074         (show_style): Call cmd_show_list.
6075         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6076         Update to use the new macro.
6077
6078 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6079
6080         * ada-lang.c (_initialize_ada_language): Expand the help text
6081         for the "catch exception" command.
6082
6083 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6084
6085         * symtab.c (matching_obj_sections): Initialize obj,
6086         declare it closer to its usage.
6087
6088 2019-01-10  Tom Tromey  <tom@tromey.com>
6089
6090         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6091         (basic_inf_threads_range): Remove.
6092         (inf_threads_range, inf_non_exited_threads_range)
6093         (safe_inf_threads_range): Use next_adapter.
6094
6095 2019-01-10  Keith Seitz  <keiths@redhat.com>
6096
6097         PR gdb/23712
6098         PR symtab/23010
6099         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6100         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6101
6102 2019-01-10  Keith Seitz  <keiths@redhat.com>
6103
6104         PR gdb/23712
6105         PR symtab/23010
6106         * dictionary.c (pending_to_vector): Remove.
6107         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6108         Remove _1 suffix, replacing functions of the same name.  Update
6109         all callers.
6110         (dict_create_hashed, dict_create_hashed_expandable)
6111         (dict_create_linear, dict_create_linear_expandable, dict_free)
6112         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6113         Make functions static.
6114
6115 2019-01-10  Keith Seitz  <keiths@redhat.com>
6116
6117         PR gdb/23712
6118         PR symtab/23010
6119         * dictionary.h (struct dictionary): Replace declaration with
6120         multidictionary.
6121         (dict_create_hashed, dict_create_hashed_expandable)
6122         (dict_create_linear, dict_create_linear_expandable)
6123         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6124         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6125         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6126         taking multidictionary argument.
6127         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6128         * block.h (struct block) <dict>: Change to multidictionary
6129         and rename `multidict'.
6130         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6131         symmisc.c: Update all dictionary references to multidictionary.
6132
6133 2019-01-10  Keith Seitz  <keiths@redhat.com>
6134
6135         PR gdb/23712
6136         PR symtab/23010
6137         * dictionary.c: Include unordered_map.
6138         (pending_to_vector): New function.
6139         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6140         Rewrite the non-"_1" functions to take vector instead
6141         of linked list.
6142         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6143         "new" _1 versions of the same name.
6144         (multidictionary): Define.
6145         (std::hash<enum language): New definition.
6146         (collate_pending_symbols_by_language, mdict_create_hashed)
6147         (mdict_create_hashed_expandable, mdict_create_linear)
6148         (mdict_create_linear_expandable, mdict_free)
6149         (find_language_dictionary, create_new_language_dictionary)
6150         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6151         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6152         (mdict_size, mdict_empty): New functions.
6153         * dictionary.h (mdict_iterator): Define.
6154
6155 2019-01-10  Pedro Alves  <palves@redhat.com>
6156
6157         * breakpoint.c (read_uploaded_action)
6158         (create_tracepoint_from_upload): Adjust to use
6159         gdb::unique_xmalloc_ptr.
6160         * ctf.c (ctf_write_uploaded_tp):
6161         (SET_ARRAY_FIELD): Use emplace_back.
6162         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6163         * tracefile-tfile.c (tfile_write_uploaded_tp):
6164         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6165         gdb::unique_xmalloc_ptr.
6166         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6167         at_string, cond_string, cmd_strings>: Replace char pointers
6168         with gdb::unique_xmalloc_ptr.
6169
6170 2019-01-10  Pedro Alves  <palves@redhat.com>
6171
6172         * solib-target.c (library_list_start_library): Don't xstrdup name.
6173
6174 2019-01-10  Pedro Alves  <palves@redhat.com>
6175
6176         * mdebugread.c (parse_partial_symbols): Use
6177         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6178
6179 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * linux-fork.c (scoped_switch_fork_info)
6182         <~scoped_switch_fork_info>: Fix incorrect variable name.
6183
6184 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * linux-fork.c (scoped_switch_fork_info)
6187         <scoped_switch_fork_info>: Make explicit.
6188         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6189
6190 2019-01-10  Tom Tromey  <tom@tromey.com>
6191
6192         * objfiles.h (objfile::reset_psymtabs): Update.
6193         * objfiles.c (objfile::objfile): Update.
6194         * psymtab.h (psymtab_storage::obstack): Update.
6195         (psymtab_storage::m_obstack): Use gdb::optional.
6196         (class psymtab_storage): Update comment.  Remove objfile
6197         parameter.
6198         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6199
6200 2019-01-10  Tom Tromey  <tom@tromey.com>
6201
6202         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6203         <free_psymtabs>: Now private.
6204         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6205         (allocate_psymtab): Use new method.
6206
6207 2019-01-10  Tom Tromey  <tom@tromey.com>
6208
6209         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6210         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6211         * mdebugread.c (parse_partial_symbols): Use
6212         allocate_dependencies.
6213         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6214         allocate_dependencies.
6215         (process_psymtab_comp_unit_reader)
6216         (build_type_psymtab_dependencies): Likewise.
6217         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6218
6219 2019-01-10  Tom Tromey  <tom@tromey.com>
6220
6221         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6222         PSYMBOL_SET_LANGUAGE.
6223         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6224
6225 2019-01-10  Tom Tromey  <tom@tromey.com>
6226
6227         * psymtab.h (psymtab_storage::obstack): New method.
6228         <m_obstack>: Rename from obstack; now private.
6229         * psymtab.c (psymtab_storage): Update.
6230         * dwarf2read.c (create_addrmap_from_index)
6231         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6232         Update.
6233
6234 2019-01-10  Tom Tromey  <tom@tromey.com>
6235
6236         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6237         * objfiles.h (objfile::reset_psymtabs): New method.
6238
6239 2019-01-10  Tom Tromey  <tom@tromey.com>
6240
6241         * symmisc.c (print_symbol_bcache_statistics): Update.
6242         (print_objfile_statistics): Update.
6243         * symfile.c (reread_symbols): Update.
6244         * psymtab.h (class psymtab_storage): New.
6245         * psymtab.c (psymtab_storage): New constructor.
6246         (~psymtab_storage): New destructor.
6247         (require_partial_symbols): Update.
6248         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6249         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6250         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6251         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6252         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6253         (start_psymtab_common, end_psymtab_common)
6254         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6255         (allocate_psymtab): Update.
6256         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6257         Update.
6258         (dump_psymtab_addrmap, maintenance_print_psymbols)
6259         (maintenance_check_psymtabs): Update.
6260         (class objfile_psymtabs): Move to objfiles.h.
6261         * psympriv.h (discard_psymtab): Now inline.
6262         (psymtab_discarder::psymtab_discarder): Update.
6263         (psymtab_discarder::~psymtab_discarder): Update.
6264         (ALL_OBJFILE_PSYMTABS): Rewrite.
6265         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6266         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6267         Remove fields.
6268         <partial_symtabs>: New field.
6269         (class objfile_psymtabs): Move from psymtab.h.  Update.
6270         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6271         psymbol_cache.
6272         (objfile::~objfile): Don't destroy psymbol_cache.
6273         * mdebugread.c (parse_partial_symbols): Update.
6274         * dwarf2read.c (create_addrmap_from_index)
6275         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6276         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6277         (add_partial_subprogram, dwarf2_ranges_read): Update.
6278         * dwarf-index-write.c (write_address_map)
6279         (write_one_signatured_type, recursively_write_psymbols)
6280         (class debug_names, class debug_names, write_psymtabs_to_index):
6281         Update.
6282
6283 2019-01-10  Tom Tromey  <tom@tromey.com>
6284
6285         * symtab.h (SYMBOL_SET_NAMES): Update.
6286         (symbol_set_names): Update.
6287         (MSYMBOL_SET_NAMES): Update.
6288         * symtab.c (symbol_set_names): Change argument to be an
6289         objfile_per_bfd_storage.
6290         * psymtab.c (add_psymbol_to_bcache): Update.
6291         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6292
6293 2019-01-10  Tom Tromey  <tom@tromey.com>
6294
6295         * symtab.c (create_demangled_names_hash): Change argument to be an
6296         objfile_per_bfd_storage.
6297         (symbol_set_names): Update.
6298
6299 2019-01-10  Tom Tromey  <tom@tromey.com>
6300
6301         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6302         init_psymbol_list.
6303         * psymtab.c (init_psymbol_list): Do nothing if already called.
6304         * psympriv.h (init_psymbol_list): Add comment.
6305         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6306         init_psymbol_list.
6307         * dbxread.c (dbx_symfile_read): Unconditionally call
6308         init_psymbol_list.
6309
6310 2019-01-10  Tom Tromey  <tom@tromey.com>
6311
6312         * xcoffread.c (scan_xcoff_symtab): Update.
6313         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6314         "where".
6315         * mdebugread.c (parse_partial_symbols)
6316         (handle_psymbol_enumerators): Update.
6317         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6318         * dbxread.c (read_dbx_symtab): Update.
6319         * psympriv.h (psymbol_placement): New enum.
6320         (add_psymbol_to_list): Update.
6321
6322 2019-01-10  Tom Tromey  <tom@tromey.com>
6323
6324         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6325         static_psymbols parameters.
6326         (scan_xcoff_symtab): Update.
6327         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6328         static_psymbols parameters.
6329         * psympriv.h (start_psymtab_common): Update.
6330         * mdebugread.c (parse_partial_symbols): Update.
6331         * dwarf2read.c (create_partial_symtab): Update.
6332         * dbxread.c (read_dbx_symtab): Update.
6333         (start_psymtab): Remove global_psymbols and static_psymbols
6334         parameters.
6335
6336 2019-01-10  Tom Tromey  <tom@tromey.com>
6337
6338         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6339         * psymtab.c (allocate_psymtab): Add comment.
6340         * psympriv.h (allocate_psymtab): Add comment.
6341         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6342         initializations.
6343         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6344
6345 2019-01-10  Tom Tromey  <tom@tromey.com>
6346
6347         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6348         Don't declare.
6349         * mipsread.c: Include mdebugread.h.
6350         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6351         Declare.
6352         * elfread.c: Include mdebugread.h.
6353
6354 2019-01-09  Tom Tromey  <tom@tromey.com>
6355
6356         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6357         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6358         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6359         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6360         (psym_lookup_symbol, psym_find_last_source_symtab)
6361         (psym_forget_cached_source_info, psym_print_stats)
6362         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6363         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6364         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6365         (psym_find_compunit_symtab_by_address)
6366         (maintenance_print_psymbols, maintenance_info_psymtabs)
6367         (maintenance_check_psymtabs): Use ranged for.
6368         * psymtab.h (class objfile_psymtabs): New.
6369         (require_partial_symbols): Return objfile_psymtabs.
6370         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6371
6372 2019-01-09  Tom Tromey  <tom@tromey.com>
6373
6374         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6375         (find_pc_mapped_section, list_overlays_command)
6376         (map_overlay_command, unmap_overlay_command)
6377         (simple_overlay_update): Use all_objfiles.
6378         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6379         * printcmd.c (info_symbol_command): Use all_objfiles.
6380         * objfiles.h (ALL_OBJSECTIONS): Remove.
6381         * maint.c (maintenance_translate_address): Use all_objfiles.
6382         * gcore.c (gcore_create_callback): Use all_objfiles.
6383         (objfile_find_memory_regions): Likewise.
6384
6385 2019-01-09  Tom Tromey  <tom@tromey.com>
6386
6387         * symtab.c (find_line_symtab, info_sources_command)
6388         (make_source_files_completion_list): Use objfile_compunits.
6389         * source.c (select_source_symtab): Use objfile_compunits.
6390         * objfiles.h (struct objfile): Update comment.
6391         (ALL_OBJFILES): Remove.
6392         (ALL_FILETABS): Remove.
6393         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6394         objfile_compunits.
6395
6396 2019-01-09  Tom Tromey  <tom@tromey.com>
6397
6398         * symmisc.c (print_objfile_statistics, dump_objfile)
6399         (maintenance_print_symbols): Use compunit_filetabs.
6400         * source.c (forget_cached_source_info_for_objfile): Use
6401         compunit_filetabs.
6402         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6403         (ALL_FILETABS): Use compunit_filetabs.
6404         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6405         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6406
6407 2019-01-09  Tom Tromey  <tom@tromey.com>
6408
6409         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6410         (compunit_filetabs): New.
6411         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6412         compunit_filetabs.
6413         (info_sources_command, make_source_files_completion_list): Remove
6414         declaration.
6415         * symmisc.c (print_objfile_statistics, dump_objfile)
6416         (maintenance_print_symbols): Remove declaration.
6417         (maintenance_info_symtabs): Use compunit_filetabs.
6418         (maintenance_info_line_tables): Likewise.
6419         * source.c (select_source_symtab): Change local variable name.
6420         (forget_cached_source_info_for_objfile): Remove declaration.
6421         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6422         * objfiles.c (objfile_relocate1): Remove declaration.
6423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6424         declaration.
6425         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6426         * coffread.c (coff_symtab_read): Remove declaration.
6427         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6428         compunit_filetabs.
6429
6430 2019-01-09  Tom Tromey  <tom@tromey.com>
6431
6432         * symtab.c (lookup_objfile_from_block)
6433         (find_pc_sect_compunit_symtab, search_symbols)
6434         (default_collect_symbol_completion_matches_break_on): Use
6435         objfile_compunits.
6436         * objfiles.h (ALL_COMPUNITS): Remove.
6437         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6438         * cp-support.c (add_symbol_overload_list_qualified): Use
6439         objfile_compunits.
6440         * ada-lang.c (ada_collect_symbol_completion_matches)
6441         (ada_add_global_exceptions): Use objfile_compunits.
6442
6443 2019-01-09  Tom Tromey  <tom@tromey.com>
6444
6445         * source.c (select_source_symtab)
6446         (forget_cached_source_info_for_objfile): Remove declaration.
6447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6448         declaration.
6449         * maint.c (count_symtabs_and_blocks): Remove declaration.
6450         * cp-support.c (add_symbol_overload_list_qualified): Remove
6451         declaration.
6452         * coffread.c (coff_symtab_read): Remove declaration.
6453         * symtab.c (lookup_symbol_in_objfile_symtabs)
6454         (basic_lookup_transparent_type_1): Use objfile_compunits.
6455         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6456         (info_sources_command, search_symbols)
6457         (default_collect_symbol_completion_matches_break_on)
6458         (make_source_files_completion_list): Remove declaration.
6459         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6460         (ada_collect_symbol_completion_matches)
6461         (ada_add_global_exceptions): Remove declaration.
6462         * linespec.c (iterate_over_all_matching_symtabs): Use
6463         objfile_compunits.
6464         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6465         (class objfile_compunits): New.
6466         (ALL_COMPUNITS): Use objfile_compunits.
6467         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6468         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6469         objfile_compunits.
6470         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6471
6472 2019-01-09  Tom Tromey  <tom@tromey.com>
6473
6474         * symtab.c (search_symbols)
6475         (default_collect_symbol_completion_matches_break_on): Use
6476         objfile_msymbols.
6477         * ada-lang.c (ada_lookup_simple_minsym)
6478         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6479         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6480         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6481         objfile_msymbols.
6482         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6483         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6484         * objc-lang.c (find_methods): Use objfile_msymbols.
6485         (info_selectors_command, info_classes_command): Likewise.
6486         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6487         * objfiles.h (class objfile_msymbols): New.
6488         (ALL_OBJFILE_MSYMBOLS): Remove.
6489         (ALL_MSYMBOLS): Remove.
6490
6491 2019-01-09  Tom Tromey  <tom@tromey.com>
6492
6493         * common/next-iterator.h (next_adapter): Add Iterator template
6494         parameter.
6495         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6496         (class all_objfiles_safe): New.
6497         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6498         * objfiles.c (put_objfile_before): Update comment.
6499         (add_separate_debug_objfile): Likewise.
6500         (free_all_objfiles): Use all_objfiles_safe.
6501         (objfile_purge_solibs): Likewise.
6502
6503 2019-01-09  Tom Tromey  <tom@tromey.com>
6504
6505         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6506         (expand_symtab_containing_pc, lookup_static_symbol)
6507         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6508         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6509         all_objfiles.
6510         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6511         * breakpoint.c (create_overlay_event_breakpoint)
6512         (create_longjmp_master_breakpoint)
6513         (create_std_terminate_master_breakpoint)
6514         (create_exception_master_breakpoint): Use all_objfiles.
6515         * linux-thread-db.c (try_thread_db_load_from_pdir)
6516         (has_libpthread): Use all_objfiles.
6517         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6518         * linespec.c (iterate_over_all_matching_symtabs)
6519         (search_minsyms_for_name): Use all_objfiles.
6520         * maint.c (maintenance_info_sections): Use all_objfiles.
6521         * main.c (captured_main_1): Use all_objfiles.
6522         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6523         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6524         * guile/scm-pretty-print.c
6525         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6526         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6527         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6528         (maintenance_print_msymbols): Use all_objfiles.
6529         * source.c (select_source_symtab): Use all_objfiles.
6530         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6531         * symfile.c (remove_symbol_file_command)
6532         (expand_symtabs_matching, map_symbol_filenames): Use
6533         all_objfiles.
6534         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6535         all_objfiles.
6536         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6537         * objc-lang.c (find_methods): Use all_objfiles.
6538         * objfiles.c (have_partial_symbols, have_full_symbols)
6539         (have_minimal_symbols, qsort_cmp)
6540         (default_iterate_over_objfiles_in_search_order): Use
6541         all_objfiles.
6542         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6543         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6544         (maintenance_check_psymtabs): Use all_objfiles.
6545         (ALL_PSYMTABS): Remove.
6546         * compile/compile-object-run.c (do_module_cleanup): Use
6547         all_objfiles.
6548         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6549         * cp-support.c (add_symbol_overload_list_qualified): Use
6550         all_objfiles.
6551         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6552         Use all_objfiles.
6553         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6554         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6555         all_objfiles.
6556         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6557         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6558         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6559         Uses all_objfiles.
6560         * solib.c (solib_read_symbols): Use all_objfiles
6561
6562 2019-01-09  Tom Tromey  <tom@tromey.com>
6563
6564         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6566         all_objfiles.
6567         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6568         * symmisc.c (print_symbol_bcache_statistics)
6569         (print_objfile_statistics, maintenance_print_objfiles)
6570         (maintenance_info_symtabs, maintenance_check_symtabs)
6571         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6572         all_objfiles.
6573         * source.c (forget_cached_source_info): Use all_objfiles.
6574         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6575         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6576         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6577         * objfiles.c (update_section_map): Use all_objfiles.
6578         (shared_objfile_contains_address_p): Likewise.
6579         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6580         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6581
6582 2019-01-09  Tom Tromey  <tom@tromey.com>
6583
6584         * common/next-iterator.h: New file.
6585         * objfiles.h (class all_objfiles): New.
6586         (struct objfile_iterator): New.
6587
6588 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6589
6590         * NEWS: Move the description of the changed "frame", "select-frame",
6591          and "info frame" commands to the Changed commands section.
6592
6593 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6594
6595         * gdbtypes.c (check_stub_method_group): Remove handling of old
6596         mangling schemes.
6597         * linespec.c (find_methods): Likewise.
6598         * stabsread.c (read_member_functions): Likewise.
6599         * valops.c (search_struct_method): Likewise.
6600         (value_struct_elt_for_reference): Likewise.
6601         * NEWS: Mention this change.
6602
6603 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6604
6605         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6606         print_source_lines.
6607         * source.c (print_source_lines_base): Update line number check.
6608         (print_source_lines): New function.
6609         (source_lines_range::source_lines_range): New function.
6610         * source.h (class source_lines_range): New class.
6611         (print_source_lines): New declaration.
6612
6613 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6614
6615         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6616
6617 2019-01-08  Tom Tromey  <tom@tromey.com>
6618             Simon Marchi  <simon.marchi@ericsson.com>
6619
6620         PR gdb/24060
6621         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6622         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6623         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6624         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6625         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6626         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6627
6628 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6629
6630         * source.c (select_source_symtab): Move header comment to
6631         declaration in source.h.
6632         (forget_cached_source_info_for_objfile): Likewise.
6633         (forget_cached_source_info): Likewise.
6634         (identify_source_line): Likewise.
6635         * source.h (identify_source_line): Move declaration from symtab.h
6636         and add comment from source.c
6637         (print_source_lines): Likewise.
6638         (forget_cached_source_info_for_objfile): Likewise.
6639         (forget_cached_source_info): Likewise.
6640         (select_source_symtab): Likewise.
6641         (enum print_source_lines_flag): Move definition from symtab.h.
6642         * symtab.h (identify_source_line): Move declaration to source.h.
6643         (print_source_lines): Likewise.
6644         (forget_cached_source_info_for_objfile): Likewise.
6645         (forget_cached_source_info): Likewise.
6646         (select_source_symtab): Likewise.
6647         (enum print_source_lines_flag): Move definition to source.h.
6648         * tui/tui-hooks.c: Add 'source.h' include.
6649
6650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * source.c (print_source_lines_base): Handle requests to print
6653         reverse line number sequences, and guard against empty lines
6654         string.
6655
6656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6657
6658         * source.c (print_source_lines_base): Fix skip of '\r' if next
6659         character is '\n'.
6660
6661 2019-01-06  Tom Tromey  <tom@tromey.com>
6662
6663         * c-exp.y (struct c_parse_state) <macro_original_text,
6664         expansion_obstack>: New member.
6665         (macro_original_text, expansion_obstack): Remove globals.
6666         (scan_macro_expansion, scanning_macro_expansion)
6667         (finished_macro_expansion): Update.
6668         (scan_macro_cleanup): Remove.
6669         (yylex, c_parse): Update.
6670
6671 2019-01-06  Tom Tromey  <tom@tromey.com>
6672
6673         * c-exp.y (struct c_parse_state) <strings>: New member.
6674         (operator_stoken): Update.
6675
6676 2019-01-06  Tom Tromey  <tom@tromey.com>
6677
6678         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6679         (union type_stack_elt) <typelist_val>: Now a pointer to
6680         std::vector.
6681         (type_stack_cleanup): Don't declare.
6682         (push_typelist): Update.
6683         * parse.c (pop_typelist): Return a std::vector.
6684         (push_typelist): Take a std::vector.
6685         (follow_types): Update.  Do not free args.
6686         (type_stack_cleanup): Remove.
6687         * c-exp.y (struct c_parse_state): New.
6688         (cpstate): New global.
6689         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6690         (nonempty_typelist): Update.
6691         (func_mod): Create a new vector.
6692         (c_parse): Create a c_parse_state.
6693         (check_parameter_typelist): Do not delete params.
6694         (function_method): Update.  Do not delete type_list.
6695
6696 2019-01-06  Tom Tromey  <tom@tromey.com>
6697
6698         PR gdb/28155:
6699         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6700         check_typedef.
6701         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6702         (print_return_value): Likewise.
6703
6704 2019-01-05  Tom Tromey  <tom@tromey.com>
6705
6706         * contrib/cleanup_check.py: Remove.
6707         * contrib/gcc-with-excheck: Remove.
6708         * contrib/exsummary.py: Remove.
6709         * contrib/excheck.py: Remove.
6710
6711 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6712
6713         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6714         NULL. Initialize tpprev to NULL instead of assigning it
6715         to NULL on the next statement.
6716         * windows-nat.c (windows_delete_thread): Remove check for
6717         main_thread_id before printing thread exit notifications.
6718         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6719         Remove thread ID check against main_thread_id.
6720         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6721         windows_delete_thread.
6722         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6723
6724 2019-01-04  Tom Tromey  <tom@tromey.com>
6725
6726         * compile/compile.c (_initialize_compile): Use upper case for
6727         metasyntactic variables.
6728         * symmisc.c (_initialize_symmisc): Use upper case for
6729         metasyntactic variables.
6730         * psymtab.c (_initialize_psymtab): Use upper case for
6731         metasyntactic variables.
6732         * demangle.c (demangle_command): Use upper case for metasyntactic
6733         variables.
6734         (_initialize_demangler): Likewise.
6735         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6736         variables.
6737
6738 2019-01-03  Tom Tromey  <tom@tromey.com>
6739
6740         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6741
6742 2019-01-03  Tom Tromey  <tom@tromey.com>
6743
6744         * python/py-symtab.c (salpy_str): Update.
6745         (struct salpy_sal_object) <symtab>: Now a PyObject.
6746         (salpy_dealloc): Update.
6747         (del_objfile_sal): Use gdbpy_ref.
6748
6749 2019-01-03  Tom Tromey  <tom@tromey.com>
6750
6751         * python/py-type.c (convert_field): Use new_reference.  Return
6752         gdbpy_ref.
6753         (make_fielditem): Return gdbpy_ref.
6754         (typy_fields): Update.
6755         (typy_getitem): Update.
6756         (field_name): Return gdbpy_ref.  Use new_reference.
6757         (typy_iterator_iternext): Update.
6758
6759 2019-01-03  Tom Tromey  <tom@tromey.com>
6760
6761         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6762
6763 2019-01-03  Tom Tromey  <tom@tromey.com>
6764
6765         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6766         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6767         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6768         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6769         (pspy_set_type_printers): Likewise.
6770         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6771         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6772         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6773         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6774         (objfpy_set_type_printers): Likewise.
6775
6776 2019-01-03  Tom Tromey  <tom@tromey.com>
6777
6778         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6779         (gdbpy_print_stack): Use gdbpy_err_fetch.
6780         * python/python-internal.h (class gdbpy_err_fetch): New class.
6781         (class gdbpy_enter) <m_error_type, m_error_value,
6782         m_error_traceback>: Remove.
6783         <m_error>: New member.
6784         (gdbpy_exception_to_string): Don't declare.
6785         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6786         * python/py-value.c (convert_value_from_python): Use
6787         gdbpy_err_fetch.
6788         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6789         gdbpy_exception_to_string.
6790         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6791         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6792         gdbpy_err_fetch.
6793
6794 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6795
6796         * linux-nat.c (delete_lwp_cleanup): Delete.
6797         (struct lwp_deleter): New struct.
6798         (lwp_info_up): New typedef.
6799         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6800         lwp_info_up.
6801
6802 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * linux-fork.c (class scoped_switch_fork_info): New class.
6805         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6806
6807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6808
6809         * valops.c (find_overload_match): Remove use of null_cleanup, and
6810         calls to do_cleanups.
6811
6812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * compile/compile-cplus-types.c
6815         (compile_cplus_instance::decl_name): Handle changes to
6816         cp_func_name.
6817         * cp-support.c (cp_func_name): Update header comment, update
6818         return type.
6819         * cp-support.h (cp_func_name): Update return type in declaration.
6820         * valops.c (find_overload_match): Move temp_func local to top
6821         level of function and change its type.  Use temp_func to hold and
6822         delete temporary string obtained from cp_func_name.
6823
6824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6827         gdb::char_vector, remove cleanup, and update uses of `msg`.
6828
6829 2019-01-03  Jim Wilson  <jimw@sifive.com>
6830
6831         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6832
6833 2019-01-02  Tom Tromey  <tom@tromey.com>
6834
6835         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6836         (tdesc_parse_xml): Remove cleanups.
6837         * target-descriptions.h (make_cleanup_free_target_description):
6838         Don't declare.
6839         (target_desc_deleter): New struct.
6840         (target_desc_up): New typedef.
6841         * target-descriptions.c (target_desc_deleter::operator()): Rename
6842         from free_target_description.
6843         (make_cleanup_free_target_description): Remove.
6844
6845 2019-01-02  Tom Tromey  <tom@tromey.com>
6846
6847         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6848         constructor, destructor.
6849         (linespec_parser): Remove typedef.
6850         (~linespec_parser): Rename from linespec_parser_delete.
6851         (linespec_lex_to_end, linespec_complete_label)
6852         (linespec_complete): Update.
6853         (decode_line_full): Remove cleanups.
6854         (decode_line_1): Update.
6855
6856 2019-01-02  Tom Tromey  <tom@tromey.com>
6857
6858         * python/python-internal.h (inferior_to_inferior_object): Change
6859         return type.
6860         * python/py-exitedevent.c (create_exited_event_object): Update.
6861         * python/py-inferior.c (inferior_to_inferior_object): Return
6862         gdbpy_ref.
6863         (python_new_inferior, python_inferior_deleted)
6864         (thread_to_thread_object, delete_thread_object)
6865         (build_inferior_list, gdbpy_selected_inferior): Update.
6866         * python/py-infthread.c (create_thread_object): Update.  Also fail
6867         if inferior_to_inferior_object fails.
6868
6869 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6870
6871         * inferior.h (class inferior) <displaced_step_state>: New field.
6872         * infrun.h (struct displaced_step_state): Move here from
6873         infrun.c.  Initialize fields, add constructor.
6874         <inf>: Remove field.
6875         <reset>: New method.
6876         * infrun.c (struct displaced_step_inferior_state): Move to
6877         infrun.h.
6878         (displaced_step_inferior_states): Remove.
6879         (get_displaced_stepping_state): Adust.
6880         (displaced_step_in_progress_any_inferior): Adjust.
6881         (displaced_step_in_progress_thread): Adjust.
6882         (displaced_step_in_progress): Adjust.
6883         (add_displaced_stepping_state): Remove.
6884         (get_displaced_step_closure_by_addr): Adjust.
6885         (remove_displaced_stepping_state): Remove.
6886         (infrun_inferior_exit): Call displaced_step_state.reset.
6887         (use_displaced_stepping): Don't check for NULL.
6888         (displaced_step_prepare_throw): Call
6889         get_displaced_stepping_state.
6890         (displaced_step_fixup): Don't check for NULL.
6891         (prepare_for_detach): Don't check for NULL.
6892
6893 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6894
6895         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6896          in case of call that did not complete.
6897
6898 2019-01-02  Andrey Utkin  <autkin@undo.io>
6899
6900         * symfile.c (find_separate_debug_file): Fix search of debug files for
6901         remote debuggee.
6902
6903 2019-01-02  Tom Tromey  <tom@tromey.com>
6904
6905         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6906         indentation.
6907         * python/py-frame.c (frapy_older): Remove cast.
6908         (frapy_newer): Likewise.
6909         * python/py-breakpoint.c (local_setattro): Remove cast.
6910         * python/py-arch.c (archpy_name): Remove local variable.
6911         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6912
6913 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6914
6915         * unittests/basic_string_view/element_access/char/empty.cc:
6916         Fix year range in copyright header.
6917
6918 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6919
6920         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6921         Delete.
6922         <operator==>: Update with for removed field.
6923         <hash>: Likewise.
6924         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6925         <isa_features>: ...this.
6926         <abi_features>: New field.
6927         (riscv_isa_flen): Update comment.
6928         (riscv_abi_xlen): New declaration.
6929         (riscv_abi_flen): New declaration.
6930         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6931         isa_features.
6932         (riscv_abi_xlen): New function.
6933         (riscv_isa_flen): Update to get answer from isa_features.
6934         (riscv_abi_flen): New function.
6935         (riscv_has_fp_abi): Update to get answer from abi_features.
6936         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6937         xlen and flen.
6938         (riscv_call_info) <xlen, flen>: Update comment.
6939         (riscv_call_arg_struct): Remove invalid assertions
6940         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6941         is removed.
6942         (riscv_gdbarch_init): Gather isa features and abi features
6943         separately, ensure both match on the gdbarch when reusing an old
6944         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6945         a target with 64-bit float hardware.
6946
6947 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6948
6949         * source.c (search_command_helper): Stop reverse search
6950         when line 1 has been searched.
6951
6952 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6953
6954         * record-full.c (record_full_base_target::close): Rewrite
6955         record_full_core_buf_list free logic.
6956
6957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6958
6959         * break-catch-syscall.c (print_one_catch_syscall): xfree
6960         the last text.
6961
6962 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6963
6964         * top.c (print_gdb_version): Update Copyright year in version
6965         message.
6966
6967 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6968
6969         Update copyright year range in all GDB files.
6970
6971 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6972
6973         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6974
6975 For older changes see ChangeLog-2018.
6976 \f
6977 Local Variables:
6978 mode: change-log
6979 left-margin: 8
6980 fill-column: 74
6981 version-control: never
6982 coding: utf-8
6983 End:
6984