gdb/ChangeLog

   1 2019-10-02  Tom Tromey  <tromey@adacore.com>
   2
   3         * coffread.c (process_coff_symbol): Update.
   4         * dwarf2read.c (var_decode_location, new_symbol): Update.
   5         * mdebugread.c (parse_symbol): Update.
   6         * objfiles.c (relocate_one_symbol): Update.
   7         * stabsread.c (define_symbol, fix_common_block)
   8         (scan_file_globals): Update.
   9         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
  10         (SET_SYMBOL_VALUE_ADDRESS): New macro.
  11         * xcoffread.c (process_xcoff_symbol): Update.
  12
  13 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
  14
  15         * MAINTAINERS: Update my email address.
  16
  17 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
  20         std::vector.
  21         (build_type_psymtabs_reader): Update for std::vector.
  22         (build_type_psymtab_dependencies): Likewise.
  23         * dwarf2read.h: Remove use of DEF_VEC_P.
  24         (typedef sig_type_ptr): Delete.
  25
  26 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * btrace.c (btrace_maint_clear): Update to handle change from VEC
  29         to std::vector.
  30         (btrace_maint_decode_pt): Likewise, and move allocation of the
  31         vector outside of the loop.
  32         (btrace_maint_update_packets): Update to handle change from VEC to
  33         std::vector.
  34         (btrace_maint_print_packets): Likewise.
  35         (maint_info_btrace_cmd): Likewise.
  36         * btrace.h: Remove use of DEF_VEC_O.
  37         (typedef btrace_pt_packet_s): Delete.
  38         (struct btrace_maint_info) <packets>: Change fromm VEC to
  39         std::vector.
  40         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
  41
  42 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
  45         make accesses into the vector constant references.
  46         (btrace_add_pc): Update for std::vector.
  47         (btrace_stitch_bts): Likewise.
  48         (parse_xml_btrace_block): Likewise.
  49         (btrace_maint_update_packets): Likewise.
  50         (btrace_maint_print_packets): Likewise.
  51         (maint_info_btrace_cmd): Likewise.
  52         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
  53         std::vector.
  54         (btrace_data::empty): Likewise.
  55         (btrace_data_append): Likewise.
  56         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
  57         (typedef btrace_block_s): Delete.
  58         (struct btrace_block): Add constructor.
  59         (struct btrace_data_bts) <blocks>: Change to std::vector.
  60         * nat/linux-btrace.c (perf_event_read_bts): Update for
  61         std::vector.
  62         (linux_read_bts): Likewise.
  63
  64 2019-10-01  Tom Tromey  <tom@tromey.com>
  65
  66         * cli/cli-logging.c (show_logging_filename): Use styled_string.
  67
  68 2019-10-01  Tom Tromey  <tom@tromey.com>
  69
  70         * stack.c (print_frame, info_frame_command_core): Use
  71         styled_string.
  72         * linux-thread-db.c (try_thread_db_load_1)
  73         (try_thread_db_load_from_pdir_1): Use styled_string.
  74         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  75         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  76         (maybe_print_unsupported_script_warning)
  77         (maybe_print_script_not_found_warning): Use styled_string.
  78         * ada-lang.c (user_select_syms): Use styled_string.
  79
  80 2019-10-01  Tom Tromey  <tom@tromey.com>
  81
  82         * p-lang.c (pascal_printstr): Use metadata style.
  83         * value.c (show_convenience): Use metadata style.
  84         * valprint.c (valprint_check_validity, val_print_optimized_out)
  85         (val_print_not_saved, val_print_unavailable)
  86         (val_print_invalid_address, generic_val_print, val_print)
  87         (value_check_printable, val_print_array_elements): Use metadata
  88         style.
  89         * ui-out.h (class ui_out) <field_fmt>: New overload.
  90         <do_field_fmt>: Add style parameter.
  91         * ui-out.c (ui_out::field_fmt): New overload.
  92         * typeprint.c (type_print_unknown_return_type)
  93         (val_print_not_allocated, val_print_not_associated): Use metadata
  94         style.
  95         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
  96         parameter.
  97         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
  98         * tracepoint.c (tvariables_info_1): Use metadata style.
  99         * stack.c (print_frame_arg, print_frame_info, print_frame)
 100         (info_frame_command_core): Use metadata style.
 101         * skip.c (info_skip_command): Use metadata style.
 102         * rust-lang.c (rust_print_enum): Use metadata style.
 103         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 104         metadata style.
 105         * python/py-framefilter.c (py_print_single_arg): Use metadata
 106         style.
 107         * printcmd.c (do_one_display, print_variable_and_value): Use
 108         metadata style.
 109         * p-valprint.c (pascal_val_print)
 110         (pascal_object_print_value_fields): Use metadata style.
 111         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 112         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 113         parameter.
 114         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 115         * m2-valprint.c (m2_print_long_set): Use metadata style.
 116         * m2-typeprint.c (m2_print_type): Use metadata style.
 117         * infcmd.c (print_return_value_1): Use metadata style.
 118         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 119         * f-valprint.c (info_common_command_for_block): Use metadata
 120         style.
 121         * f-typeprint.c (f_type_print_base): Use metadata style.
 122         * expprint.c (print_subexp_standard): Use metadata style.
 123         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 124         * cli/cli-style.h (class cli_style_option): Add constructor.
 125         (metadata_style): Declare.
 126         * cli/cli-style.c (metadata_style): New global.
 127         (_initialize_cli_style): Register metadata style.
 128         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 129         parameter.
 130         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 131         * c-typeprint.c (c_type_print_base_struct_union)
 132         (c_type_print_base_1): Use metadata style.
 133         * breakpoint.c (watchpoint_value_print)
 134         (print_one_breakpoint_location): Use metadata style.
 135         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 136         style.
 137         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 138         style.
 139         * ada-valprint.c (val_print_packed_array_elements, printstr)
 140         (print_field_values, ada_val_print_ref, ada_val_print): Use
 141         metadata style.
 142         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 143         style.
 144         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 145         style.
 146         * ada-lang.c (user_select_syms): Use metadata style.
 147
 148 2019-10-01  Tom Tromey  <tom@tromey.com>
 149
 150         * cli/cli-cmds.c (pwd_command): Style output.
 151
 152 2019-10-01  Pedro Alves  <palves@redhat.com>
 153             Tom Tromey  <tom@tromey.com>
 154
 155         * symtab.c (print_symbol_info): Use %ps.
 156         (print_msymbol_info): Use %ps.
 157         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 158         * printcmd.c (print_variable_and_value): Use %ps.
 159         * macrocmd.c (show_pp_source_pos): Use %ps.
 160         * infrun.c (print_exited_reason): Use ui_out::message.
 161         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 162         (describe_other_breakpoints): Use ui_out::message and new
 163         formats.
 164         (say_where): Use new formats.
 165         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 166         and new formats.
 167
 168 2019-10-01  Pedro Alves  <palves@redhat.com>
 169             Tom Tromey  <tom@tromey.com>
 170
 171         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 172         (test_gdb_formats): New function.
 173         (run_tests): Call it.
 174         (test_format_specifier): Update.
 175         * utils.h (fputs_filtered): Update comment.
 176         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 177         (fputs_styled_unfiltered): Declare.
 178         * utils.c (fputs_styled_unfiltered): New function.
 179         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 180         (vfprintf_filtered): Update.
 181         (vfprintf_unfiltered, vprintf_filtered): Update.
 182         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 183         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 184         disallow_ui_out_field>: New constants.
 185         (enum class field_kind): New.
 186         (struct base_field_s, struct signed_field_s): New.
 187         (signed_field): New function.
 188         (struct string_field_s): New.
 189         (string_field): New function.
 190         (struct styled_string_s): New.
 191         (styled_string): New function.
 192         (class ui_out) <message>: Add comment.
 193         <vmessage, call_do_message>: New methods.
 194         <do_message>: Add style parameter.
 195         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 196         methods.
 197         (ui_out::message): Rewrite.
 198         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 199         parameter.
 200         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 201         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 202         gdb_extensions parameter.
 203         (class format_piece): Add parameter to constructor.
 204         (n_int_args): New field.
 205         * gdbsupport/format.c (format_pieces::format_pieces): Add
 206         gdb_extensions parameter.  Handle '*'.
 207         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 208         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 209         vfprintf_styled_no_gdbfmt.
 210         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 211         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 212         unfiltered output.
 213         * ui-style.h (struct ui_file_style) <ptr>: New method.
 214
 215 2019-10-01  Tom Tromey  <tom@tromey.com>
 216
 217         * unittests/format_pieces-selftests.c: Update.  Add final format.
 218         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 219         empty literal pieces.
 220
 221 2019-10-01  Tom Tromey  <tom@tromey.com>
 222
 223         * ui-out.h (enum class ui_out_style_kind): Remove.
 224         (class ui_out) <field_string, field_stsream, do_field_string>:
 225         Change type of "style".
 226         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 227         (ui_out::field_string): Update.
 228         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 229         of "style".
 230         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 231         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 232         * stack.c (print_frame_arg, print_frame_info, print_frame):
 233         Update.
 234         * source.c (print_source_lines_base): Update.
 235         * solib.c (info_sharedlibrary_command): Update.
 236         * skip.c (info_skip_command): Update.
 237         * record-btrace.c (btrace_call_history_src_line)
 238         (btrace_call_history): Update.
 239         * python/py-framefilter.c (py_print_frame): Update.
 240         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 241         "style".
 242         * mi/mi-out.c (mi_ui_out::do_table_header)
 243         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 244         (mi_ui_out::do_field_string): Update.
 245         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 246         Update.
 247         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 248         "style".
 249         * cli-out.c (cli_ui_out::do_table_header)
 250         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 251         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 252         (cli_ui_out::do_field_fmt): Update.
 253         * breakpoint.c (print_breakpoint_location): Update.
 254         (update_static_tracepoint): Update.
 255
 256 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 257
 258         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 259         conversion of gdb_datadir.
 260         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 261         remove not needed c_str ().
 262
 263 2019-09-30  Ali Tamur <tamur@google.com>
 264
 265         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 266         (dwarf2_string_attr): Likewise.
 267
 268 2019-09-30  Ali Tamur <tamur@google.com>
 269
 270         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 271         (process_full_type_unit): Likewise.
 272         (dump_die_shallow): Likewise.
 273         (cu_debug_loc_section): Likewise.
 274
 275 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 276
 277         * minsyms.c (compare_minimal_symbols): Rename to...
 278         (minimal_symbol_is_less_than): ...this, and adjust to STL
 279         conventions (return bool, take arguments as references)
 280         (minimal_symbol_reader::install): Call std::sort instead
 281         of qsort.
 282
 283 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 284
 285         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 286         hash and why.
 287         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 288         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 289
 290 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 291
 292         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 293         * psympriv.h (add_psymbol_to_list): Move comment here and update
 294         it.
 295
 296 2019-09-29  Tom de Vries  <tdevries@suse.de>
 297
 298         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 299         Use $tmpdir/$(basename "$output_file").dwz instead of
 300         "${output_file}.dwz".
 301
 302 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 303
 304         PR gdb/25045
 305         * hppa-linux-nat.c: Include gdbarch.h.
 306
 307 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * blockframe.c (find_pc_partial_function): Change return type to bool.
 310         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 311         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 312         (stub_gnu_ifunc_resolve_name): Likewise.
 313         * symtab.c (compare_filenames_for_search): Likewise.
 314         (compare_glob_filenames_for_search): Likewise.
 315         (matching_obj_sections): Likewise.
 316         (symbol_matches_domain): Likewise.
 317         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 318         (find_line_pc): Change return type to bool.
 319         (find_line_pc_range): Likewise.
 320         (producer_is_realview): Likewise.
 321         * symtab.h (symbol_matches_domain): Likewise.
 322         (find_pc_partial_function): Likewise.
 323         (find_pc_line_pc_range): Likewise.
 324         (in_gnu_ifunc_stub): Likewise.
 325         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 326         (find_line_pc): Likewise.
 327         (find_line_pc_range): Likewise.
 328         (matching_obj_sections): Likewise.
 329         (find_line_symtab): Change out parameter to bool.
 330         (producer_is_realview): Change return type to bool.
 331         (compare_filenames_for_search): Likewise.
 332         (compare_glob_filenames_for_search): Likewise.
 333
 334 2019-09-26  Tom Tromey  <tom@tromey.com>
 335
 336         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 337         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 338         * gdb_usleep.h: Remove.
 339         * gdb_usleep.c: Remove.
 340         * utils.c: Don't include gdb_usleep.h.
 341
 342 2019-09-26  Tom Tromey  <tromey@adacore.com>
 343
 344         * python/py-type.c (type_to_type_object): Call check_typedef
 345         for stub types.
 346
 347 2019-09-26  Tom Tromey  <tom@tromey.com>
 348
 349         * utils.h (initialize_utils): Don't declare.
 350         * top.c (gdb_init): Don't call initialize_utils.
 351         * utils.c (initialize_utils): Remove.  Move contents...
 352         (_initialize_utils): ... here.
 353
 354 2019-09-25  Tom Tromey  <tom@tromey.com>
 355
 356         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 357         * utils.h (make_hex_string): Don't declare.
 358         * utils.c (make_hex_string): Remove.
 359
 360 2019-09-24  Tom de Vries  <tdevries@suse.de>
 361
 362         PR gdb/23815
 363         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 364         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 365
 366 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 367
 368         * NEWS: Mention new simulator port for PRU.
 369
 370 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 371
 372         * ada-exp.y (write_object_remaining): Update.
 373         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 374         and eliminate the static buffer.
 375         (ada_decode_symbol): Update.
 376         (ada_la_decode): Update.
 377         (ada_sniff_from_mangled_name): Update.
 378         (is_valid_name_for_wild_match): Update.
 379         (ada_lookup_name_info::matches): Update and simplify.
 380         (name_matches_regex): Update.
 381         (ada_add_global_exceptions): Update.
 382         * ada-lang.h (ada_decode): Update signature.
 383         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 384         * dwarf-index-write.c (debug_names::insert): Update.
 385
 386 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 387
 388         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 389         formatting.
 390
 391 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 392
 393         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 394         Change "nonzero" to "true" in documentation.
 395
 396 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 397
 398         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 399         (_initialize_darwin_solib): Don't set
 400         darwin_so_ops.lookup_lib_global_symbol.
 401         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 402         set_gdbarch_iterate_over_objfiles_in_search_order.
 403         (elf_lookup_lib_symbol): Rename to...
 404         (svr4_iterate_over_objfiles_in_search_order): this, and update
 405         to iterate semantics.
 406         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 407         * solib.c (solib_global_lookup): Remove.
 408         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 409         (solib_global_lookup): Remove.
 410         * symtab.c (lookup_global_or_static_symbol): Remove call to
 411         solib_global_lookup.
 412
 413 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 414
 415         * NEWS: Move entries about default MI version now being
 416         version 3, and about the GDB/MI fix for multi-location
 417         breakpoints to the "since GDB 8.3" section.
 418
 419 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 420
 421         GDB 8.3.1 released.
 422
 423 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 424
 425         * NEWS: Mention that Cell/B.E. debugging support was removed.
 426         * MAINTAINERS: Remove spu target.
 427
 428         * config/djgpp/fnchange.lst: Remove entries for removed files.
 429
 430         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 431         spu-multiarch.o, and spu-tdep.o.
 432         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 433         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 434         spu-multiarch.c, and spu-tdep.c.
 435         * spu-linux-nat.c: Remove file.
 436         * spu-multiarch.c: Remove file.
 437         * spu-tdep.c: Remove file.
 438         * spu-tdep.h: Remove file.
 439         * solib-spu.c: Remove file.
 440         * solib-spu.h: Remove file.
 441
 442         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 443         * configure.nat (spu-linux): Remove.
 444         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 445         solib-multiarch.o from gdb_target_obs.
 446         (spu*-*-*): Remove.
 447
 448         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 449         feature flag.
 450         (ppc_linux_no_features): Update.
 451         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 452         Cell/B.E. support.
 453         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 454         (tdesc_powerpc_cell64l): Likewise.
 455         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 456         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 457         Cell/B.E. support.
 458         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 459         Do not include "features/rs6000/powerpc-cell32l.c" or
 460         "features/rs6000/powerpc-cell64l.c".
 461         (ppc_linux_spu_section): Remove.
 462         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 463         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 464         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 465         (ppc_linux_spe_context_lookup): Remove.
 466         (ppc_linux_spe_context_inferior_created): Remove.
 467         (ppc_linux_spe_context_solib_loaded): Remove.
 468         (ppc_linux_spe_context_solib_unloaded): Remove.
 469         (ppc_linux_spe_context): Remove.
 470         (struct ppu2spu_cache): Remove.
 471         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 472         (struct ppu2spu_data): Remove.
 473         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 474         ppu2spu_unwind): Remove.
 475         (ppc_linux_init_abi): Remove Cell/B.E. support.
 476         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 477
 478         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 479         (rs6000/powerpc-cell64l-expedite): Likewise
 480         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 481         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 482         rs6000/powerpc-cell64l.xml.
 483         * features/rs6000/powerpc-cell32l.xml: Remove.
 484         * features/rs6000/powerpc-cell64l.xml: Likewise.
 485         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 486         * features/rs6000/powerpc-cell64l.c: Likewise.
 487         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 488         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 489         * regformats/reg-spu.dat: Remove.
 490
 491         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 492         * corelow.c (struct spuid_list): Remove.
 493         (add_to_spuid_list): Remove.
 494         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 495         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 496         (remote_protocol_features): Remove associated entries.
 497         (_initialize_remote): No longer initialize them.
 498         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 499         * linux-nat.c (SPUFS_MAGIC): Remove.
 500         (linux_proc_xfer_spu): Remove.
 501         (spu_enumerate_spu_ids): Remove.
 502         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 503         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 504         (linux_make_corefile_notes): No longer call it.
 505
 506         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 507         (cooked_write_test): Likewise.
 508
 509 2019-09-20  Tom Tromey  <tom@tromey.com>
 510
 511         * NEWS: Mention case-sensitivity of TUI commands.
 512         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 513         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 514         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 515
 516 2019-09-20  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-source.c (tui_source_window::set_contents): Use
 519         make_unique_xstrdup.
 520         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 521         make_unique_xstrdup.
 522
 523 2019-09-20  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-data.c: Remove separator comments.
 526         * tui/tui-layout.c: Remove separator comments.
 527         * tui/tui-win.c: Remove separator comments.
 528         * tui/tui-wingeneral.c: Remove separator comments.
 529
 530 2019-09-20  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui.h (strcat_to_buf): Don't declare.
 533         * tui/tui.c (strcat_to_buf): Remove.
 534
 535 2019-09-20  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 538         from "fullname".
 539         * tui/tui-source.c (tui_source_window::set_contents)
 540         (tui_source_window::location_matches_p)
 541         (tui_source_window::maybe_update): Update.
 542
 543 2019-09-20  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 546         Update.
 547         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 548         prefix.
 549         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 550         (tui_data_window::line_from_reg_element_no)
 551         (tui_data_window::first_reg_element_no_inline)
 552         (tui_data_window::show_registers)
 553         (tui_data_window::show_register_group)
 554         (tui_data_window::display_registers_from)
 555         (tui_data_window::display_registers_from_line)
 556         (tui_data_window::first_data_item_displayed)
 557         (tui_data_window::delete_data_content_windows)
 558         (tui_data_window::erase_data_content)
 559         (tui_data_window::do_scroll_vertical)
 560         (tui_data_window::refresh_window)
 561         (tui_data_window::check_register_values): Update.
 562
 563 2019-09-20  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 566         (struct tui_locator_window) <full_name, proc_name>: Now
 567         std::string.
 568         * tui/tui-stack.c (tui_locator_window::make_status_line)
 569         (tui_locator_window::set_locator_fullname)
 570         (tui_locator_window::set_locator_info): Update.
 571         * tui/tui-source.c (tui_source_window::set_contents)
 572         (tui_source_window::showing_source_p): Update.
 573
 574 2019-09-20  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 577         Don't call tui_locator_win_info_ptr.
 578
 579 2019-09-20  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 582
 583 2019-09-20  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 586         height for locator.
 587         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 588         * tui/tui-layout.c (show_source_disasm_command, show_data)
 589         (show_source_or_disasm_and_command): Use 1 as height for locator.
 590
 591 2019-09-20  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui.c (tui_enable): Update.
 594         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 595         Update.
 596         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 597         Update.
 598         * tui/tui-data.c (win_resized): Now bool.
 599         (tui_win_resized): Return bool.
 600         (tui_set_win_resized_to): Accept a bool.
 601
 602 2019-09-20  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 605         Change type of "refresh_values_only".
 606         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 607         type of "refresh_values_only".
 608
 609 2019-09-20  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 612         std::string.
 613         (tui_disassemble): Add "pos" parameter.
 614         (tui_disasm_window::set_contents): Simplify.
 615
 616 2019-09-20  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-winsource.h (struct tui_source_window_base)
 619         <show_source_content>: Now private.
 620         * tui/tui-winsource.c
 621         (tui_source_window_base::show_source_content): Don't handle empty
 622         content case.
 623
 624 2019-09-20  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-layout.c (show_source_disasm_command)
 627         (show_source_or_disasm_and_command): Don't call
 628         show_source_content.
 629
 630 2019-09-20  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 633         Declare.
 634         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 635         from tui_make_status_line.
 636         (tui_locator_window::rerender): Update.
 637
 638 2019-09-20  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 641         (tui_locator_window::rerender): Update.
 642
 643 2019-09-20  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-winsource.h (struct tui_source_window_base)
 646         <~tui_source_window_base>: Don't declare.
 647         <fullname>: Remove.
 648         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 649         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 650         member.
 651         * tui/tui-source.c (tui_source_window::set_contents): Update.
 652         (tui_source_window::location_matches_p)
 653         (tui_source_window::maybe_update): Update.
 654
 655 2019-09-20  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-winsource.h (~tui_source_element): Remove.
 658         (tui_source_element): Update.
 659         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 660         * tui/tui-winsource.c (tui_show_source_line): Update.
 661         * tui/tui-source.c (tui_source_window::set_contents): Update.
 662         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 663
 664 2019-09-20  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 667         declare.
 668         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 669         tui_clear_source_windows_detail.
 670         * tui/tui-winsource.h (struct tui_source_window_base)
 671         <clear_detail>: Don't declare.
 672         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 673         Remove.
 674         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 675
 676 2019-09-20  Tom Tromey  <tromey@adacore.com>
 677
 678         PR ada/24919:
 679         * block.c (contained_in): Fix final return value.
 680
 681 2019-09-20  Alan Modra  <amodra@gmail.com>
 682
 683         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 684         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 685         (read_indirect_string_from_dwz): Use bfd accessor.
 686         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 687         * machoread.c (macho_symfile_read_all_oso): Likewise.
 688         * solib.c (solib_bfd_open): Likewise.
 689
 690 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 691
 692         * eval.c: Move declaration of overload_resolution to...
 693         * value.h: ...here.
 694
 695 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 696
 697         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 698         * arm-linux-tdep.c: Likewise.
 699         * arm-nbsd-nat.c: Likewise.
 700         * arm-tdep.h: Declare arm_apcs_32.
 701         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 702
 703 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 706         * dwarf2read.h: Declare dwarf_always_disassemble.
 707
 708 2019-09-19  Tom de Vries  <tdevries@suse.de>
 709
 710         PR gdb/25009
 711         * source-cache.c (source_cache::ensure): Catch exception thrown during
 712         construction of the highlighter.
 713
 714 2019-09-18  Alan Modra  <amodra@gmail.com>
 715
 716         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 717         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 718         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 719         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 720         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 721         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 722         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 723         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 724         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 725         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 726         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 727         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 728         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 729         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 730         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 731         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 732         * mi/mi-interp.c: Update throughout for bfd section macro and
 733         function changes.
 734         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 735         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 736
 737 2019-09-18  Tom Tromey  <tom@tromey.com>
 738
 739         * NEWS: Add entry.
 740         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 741         call rl_initialize.
 742         (tui_enable): Do not call rl_initialize.
 743
 744 2019-09-18  Christian Groessler  <chris@groessler.org>
 745
 746         * alpha-linux-nat.c: Include gdbarch.h.
 747
 748 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 749
 750         * ui-file.c: Include cli/cli-style.h.
 751         (term_cli_styling): Remove cli_styling declaration.
 752
 753 2019-09-18  Alan Modra  <amodra@gmail.com>
 754
 755         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 756         to bfd_asymbol_section.
 757
 758 2019-09-18  Alan Modra  <amodra@gmail.com>
 759
 760         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 761         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 762         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 763
 764 2019-09-18  Alan Modra  <amodra@gmail.com>
 765
 766         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 767         * spu-linux-nat.c (spu_bfd_open): Likewise.
 768
 769 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 772         to bool to match definition in dwarf2read.c.
 773
 774 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 775
 776         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 777         (print_signatures): Likewise.
 778         (trust_pad_over_xvs): Likewise.
 779         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 780         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 781         * arm-linux-nat.c (arm_apcs_32): Likewise.
 782         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 783         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 784         * arm-tdep.c (arm_debug): Likewise.
 785         (arm_apcs_32): Likewise.
 786         * auto-load.c (debug_auto_load): Likewise.
 787         (auto_load_gdb_scripts): Likewise.
 788         (global_auto_load): Likewise.
 789         (auto_load_local_gdbinit): Likewise.
 790         (auto_load_local_gdbinit_loaded): Likewise.
 791         * auto-load.h (global_auto_load): Likewise.
 792         (auto_load_local_gdbinit): Likewise.
 793         (auto_load_local_gdbinit_loaded): Likewise.
 794         * breakpoint.c (disconnected_dprintf): Likewise.
 795         (breakpoint_proceeded): Likewise.
 796         (automatic_hardware_breakpoints): Likewise.
 797         (always_inserted_mode): Likewise.
 798         (target_exact_watchpoints): Likewise.
 799         (_initialize_breakpoint): Update.
 800         * breakpoint.h (target_exact_watchpoints): Change to bool.
 801         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 802         * cli/cli-cmds.c (trace_commands): Likewise.
 803         * cli/cli-cmds.h (trace_commands): Likewise.
 804         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 805         to bool*.
 806         * cli/cli-logging.c (logging_overwrite): Change to bool.
 807         (logging_redirect): Likewise.
 808         (debug_redirect): Likewise.
 809         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 810         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 811         to bool.
 812         <boolean_option_def>: Update.
 813         (struct flag_option_def): Change default type of Context to bool
 814         from int.
 815         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 816         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 817         (get_setshow_command_value_string): Likewise.
 818         * cli/cli-style.c (cli_styling): Change to bool.
 819         (source_styling): Likewise.
 820         * cli/cli-style.h (source_styling): Likewise.
 821         (cli_styling): Likewise.
 822         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 823         to bool.
 824         * command.h (var_types): Update comment.
 825         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 826         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 827         bool.
 828         (debug_compile_cplus_scopes): Likewise.
 829         * compile/compile-internal.h (compile_debug): Likewise.
 830         * compile/compile.c (compile_debug): Likewise.
 831         (struct compile_options) <raw>: Likewise.
 832         * cp-support.c (catch_demangler_crashes): Likewise.
 833         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 834         (usr_cmd_cris_dwarf2_cfi): Likewise.
 835         * csky-tdep.c (csky_debug): Likewise.
 836         * darwin-nat.c (enable_mach_exceptions): Likewise.
 837         * dcache.c (dcache_enabled_p): Likewise.
 838         * defs.h (info_verbose): Likewise.
 839         * demangle.c (demangle): Likewise.
 840         (asm_demangle): Likewise.
 841         * dwarf-index-cache.c (debug_index_cache): Likewise.
 842         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 843         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 844         * dwarf2read.c (check_physname): Likewise.
 845         (use_deprecated_index_sections): Likewise.
 846         (dwarf_always_disassemble): Likewise.
 847         * eval.c (overload_resolution): Likewise.
 848         * event-top.c (set_editing_cmd_var): Likewise.
 849         (exec_done_display_p): Likewise.
 850         * event-top.h (set_editing_cmd_var): Likewise.
 851         (exec_done_display_p): Likewise.
 852         * exec.c (write_files): Likewise.
 853         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 854         (debug_fbsd_nat): Likewise.
 855         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 856         Likewise.
 857         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 858         <backtrace_past_entry> Likewise.
 859         * gdb-demangle.h (demangle): Likewise.
 860         (asm_demangle): Likewise.
 861         * gdb_bfd.c (bfd_sharing): Likewise.
 862         * gdbcore.h (write_files): Likewise.
 863         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 864         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 865         * gdbthread.h (print_thread_events): Likewise.
 866         * gdbtypes.c (opaque_type_resolution): Likewise.
 867         (strict_type_checking): Likewise.
 868         * gnu-nat.c (gnu_debug_flag): Likewise.
 869         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 870         * guile/scm-param.c (pascm_variable): Add boolval.
 871         (add_setshow_generic): Update.
 872         (pascm_param_value): Update.
 873         (pascm_set_param_value_x): Update.
 874         * hppa-tdep.c (hppa_debug): Change to bool..
 875         * infcall.c (may_call_functions_p): Likewise.
 876         (coerce_float_to_double_p): Likewise.
 877         (unwind_on_signal_p): Likewise.
 878         (unwind_on_terminating_exception_p): Likewise.
 879         * infcmd.c (startup_with_shell): Likewise.
 880         * inferior.c (print_inferior_events): Likewise.
 881         * inferior.h (startup_with_shell): Likewise.
 882         (print_inferior_events): Likewise.
 883         * infrun.c (step_stop_if_no_debug): Likewise.
 884         (detach_fork): Likewise.
 885         (debug_displaced): Likewise.
 886         (disable_randomization): Likewise.
 887         (non_stop): Likewise.
 888         (non_stop_1): Likewise.
 889         (observer_mode): Likewise.
 890         (observer_mode_1): Likewise.
 891         (set_observer_mode): Update.
 892         (sched_multi): Change to bool.
 893         * infrun.h (debug_displaced): Likewise.
 894         (sched_multi): Likewise.
 895         (step_stop_if_no_debug): Likewise.
 896         (non_stop): Likewise.
 897         (disable_randomization): Likewise.
 898         * linux-tdep.c (use_coredump_filter): Likewise.
 899         (dump_excluded_mappings): Likewise.
 900         * linux-thread-db.c (auto_load_thread_db): Likewise.
 901         (check_thread_db_on_load): Likewise.
 902         * main.c (captured_main_1): Update.
 903         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 904         xx2_opt, boolean_opt>: Change to bool.
 905         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 906         * maint.c (maintenance_profile_p): Likewise.
 907         (per_command_time): Likewise.
 908         (per_command_space): Likewise.
 909         (per_command_symtab): Likewise.
 910         * memattr.c (inaccessible_by_default): Likewise.
 911         * mi/mi-main.c (mi_async): Likewise.
 912         (mi_async_1): Likewise.
 913         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 914         * nat/fork-inferior.h (startup_with_shell): Likewise.
 915         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 916         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 917         * nios2-tdep.c (nios2_debug): Likewise.
 918         * or1k-tdep.c (or1k_debug): Likewise.
 919         * parse.c (parser_debug): Likewise.
 920         * parser-defs.h (parser_debug): Likewise.
 921         * printcmd.c (print_symbol_filename): Likewise.
 922         * proc-api.c (procfs_trace): Likewise.
 923         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 924         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 925         (set_parameter_value): Update.
 926         (add_setshow_generic): Update.
 927         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 928         to bool*.
 929         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 930         int*.
 931         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 932         * record-btrace.c (record_btrace_target::store_registers): Update.
 933         * record-full.c (record_full_memory_query): Change to bool.
 934         (record_full_stop_at_limit): Likewise.
 935         * record-full.h (record_full_memory_query): Likewise.
 936         * remote-notif.c (notif_debug): Likewise.
 937         * remote-notif.h (notif_debug): Likewise.
 938         * remote.c (use_range_stepping): Likewise.
 939         (interrupt_on_connect): Likewise.
 940         (remote_break): Likewise.
 941         * ser-tcp.c (tcp_auto_retry): Likewise.
 942         * ser-unix.c (serial_hwflow): Likewise.
 943         * skip.c (debug_skip): Likewise.
 944         * solib-aix.c (solib_aix_debug): Likewise.
 945         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 946         (spu_auto_flush_cache_p): Likewise.
 947         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 948         Likewise.
 949         (struct info_print_options) <quiet>: Likewise.
 950         * symfile-debug.c (debug_symfile): Likewise.
 951         * symfile.c (auto_solib_add): Likewise.
 952         (separate_debug_file_debug): Likewise.
 953         * symfile.h (auto_solib_add): Likewise.
 954         (separate_debug_file_debug): Likewise.
 955         * symtab.c (basenames_may_differ): Likewise.
 956         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 957         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 958         (struct info_types_options) <quiet>: Likewise.
 959         * symtab.h (demangle): Likewise.
 960         (basenames_may_differ): Likewise.
 961         * target-dcache.c (stack_cache_enabled_1): Likewise.
 962         (code_cache_enabled_1): Likewise.
 963         * target.c (trust_readonly): Likewise.
 964         (may_write_registers): Likewise.
 965         (may_write_memory): Likewise.
 966         (may_insert_breakpoints): Likewise.
 967         (may_insert_tracepoints): Likewise.
 968         (may_insert_fast_tracepoints): Likewise.
 969         (may_stop): Likewise.
 970         (auto_connect_native_target): Likewise.
 971         (target_stop_and_wait): Update.
 972         (target_async_permitted): Change to bool.
 973         (target_async_permitted_1): Likewise.
 974         (may_write_registers_1): Likewise.
 975         (may_write_memory_1): Likewise.
 976         (may_insert_breakpoints_1): Likewise.
 977         (may_insert_tracepoints_1): Likewise.
 978         (may_insert_fast_tracepoints_1): Likewise.
 979         (may_stop_1): Likewise.
 980         * target.h (target_async_permitted): Likewise.
 981         (may_write_registers): Likewise.
 982         (may_write_memory): Likewise.
 983         (may_insert_breakpoints): Likewise.
 984         (may_insert_tracepoints): Likewise.
 985         (may_insert_fast_tracepoints): Likewise.
 986         (may_stop): Likewise.
 987         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 988         (make_thread_apply_all_options_def_group): Change argument from int*
 989         to bool*.
 990         (thread_apply_all_command): Update.
 991         (print_thread_events): Change to bool.
 992         * top.c (confirm): Likewise.
 993         (command_editing_p): Likewise.
 994         (history_expansion_p): Likewise.
 995         (write_history_p): Likewise.
 996         (info_verbose): Likewise.
 997         * top.h (confirm): Likewise.
 998         (history_expansion_p): Likewise.
 999         * tracepoint.c (disconnected_tracing): Likewise.
1000         (circular_trace_buffer): Likewise.
1001         * typeprint.c (print_methods): Likewise.
1002         (print_typedefs): Likewise.
1003         * utils.c (debug_timestamp): Likewise.
1004         (sevenbit_strings): Likewise.
1005         (pagination_enabled): Likewise.
1006         * utils.h (sevenbit_strings): Likewise.
1007         (pagination_enabled): Likewise.
1008         * valops.c (overload_resolution): Likewise.
1009         * valprint.h (struct value_print_options) <prettyformat_arrays,
1010         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1011         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1012         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1013         Likewise.
1014         * windows-nat.c (new_console): Likewise.
1015         (cygwin_exceptions): Likewise.
1016         (new_group): Likewise.
1017         (debug_exec): Likewise.
1018         (debug_events): Likewise.
1019         (debug_memory): Likewise.
1020         (debug_exceptions): Likewise.
1021         (useshell): Likewise.
1022         * windows-tdep.c (maint_display_all_tib): Likewise.
1023         * xml-support.c (debug_xml): Likewise.
1024
1025 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1026
1027         * source.c (prepare_path_for_appending): New function.
1028         (openp): Make use of new function.
1029         (find_and_open_source): Search for the compilation directory and
1030         source file as a relative path beneath the directory search path.
1031
1032 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * source-cache.c (source_cache::get_line_charpos): Catch
1035         exceptions and return false, this matches the behaviour documented
1036         in the header file.
1037
1038 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1039
1040         * ada-tasks.c (info_task): Remove quoting of the task's name.
1041
1042 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1043
1044         * symfile.c (auto_solib_add): Replace comment with a reference
1045         to the header file.
1046
1047 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1048
1049         * NEWS: Mention that gdb can now be compiled with Python 3
1050         on Windows.
1051
1052 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * maint.c (maint_print_section_data::maint_print_section_data):
1055         Force use of 'float log10 (float)' by casting the argument to
1056         float.
1057
1058 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1059
1060         * maint.c: Add 'cmath' include.
1061         (struct maint_print_section_data): New structure.
1062         (print_section_index): New function.
1063         (print_bfd_section_info): Add header comment, small whitespace
1064         cleanup, and update to call new print_section_index function.
1065         (print_objfile_section_info): Likewise.
1066         (maint_obj_section_from_bfd_section): New function.
1067         (print_bfd_section_info_maybe_relocated): New function.
1068         (maintenance_info_sections): Add header comment, always use
1069         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1070
1071 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1072
1073         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1074         inner scope, add check that the objfile has psymtabs before
1075         checking psymtabs_addrmap.
1076         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1077
1078 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1079
1080         * NEWS: Announce that Ada task names are now shown at more places,
1081         and between quotes (except in info task output).
1082         * gdb/ada-tasks.c (task_to_str): New function.
1083         (display_current_task_id): Call task_to_str.
1084         (task_command_1): Likewise.
1085         (print_ada_task_info): In non-mi mode, Properly align headers and data
1086         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1087
1088 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1089
1090         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1091         prstatus.pr_lwp.pr_info instead of making it up.
1092
1093 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1094
1095         * auto-load.c (auto_load_expand_dir_vars): Update.
1096         * defs.h (gdb_datadir): Change to std::string.
1097         (python_libdir): Likewise.
1098         (relocate_gdb_directory): Change return type to std::string.
1099         * guile/guile.c (gdbscm_data_directory): Update.
1100         (initialize_scheme_side): Update.
1101         * jit.c (jit_reader_dir): Change to std::string.
1102         (jit_reader_load_command): Update.
1103         * main.c (gdb_datadir): Change to std::string.
1104         (python_libdir): Likewise.
1105         (set_gdb_data_directory): Update.
1106         (relocate_path): Change to return std::string.
1107         (relocate_gdb_directory): Change to return std::string.
1108         (relocate_gdbinit_path_maybe_in_datadir): Update.
1109         (captured_main_1): Update.
1110         * python/python.c (do_start_initialization): Update.
1111         * top.c (show_gdb_datadir): Update.
1112         * xml-syscall.c (xml_init_syscalls_info): Update.
1113         (init_syscalls_info): Update.
1114
1115 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1116
1117         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1118         out of get_init_files.
1119         (get_init_files): Update.
1120
1121 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1122
1123         * main.c (get_init_files): Change to use std::string.
1124         (captured_main_1): Update.
1125         (print_gdb_help): Update.
1126
1127 2019-09-11  Ali Tamur  <tamur@google.com>
1128
1129         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1130         implementation.
1131
1132 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1133
1134         * dbxread.c (read_dbx_symtab): Update.
1135         * dwarf2read.c (load_partial_dies): Update.
1136         * mdebugread.c (parse_partial_symbols): Update.
1137         (handle_psymbol_enumerators): Update.
1138         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1139         * psymtab.c (add_psymbol_to_bcache): Likewise.
1140         (add_psymbol_to_list): Likewise.
1141         * symtab.c (symbol_set_names): Likewise.
1142         * symtab.h (symbol_set_names): Likewise.
1143         * xcoffread.c (scan_xcoff_symtab): Update.
1144
1145 2019-09-11  Tom Tromey  <tom@tromey.com>
1146
1147         * symfile-mem.c (symbol_file_add_from_memory): Use
1148         bfd_set_filename.
1149         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1150         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1151
1152 2019-09-10  Tom Tromey  <tromey@adacore.com>
1153
1154         * dwarf-index-write.c (write_psymbols): Extend error message.
1155         (debug_names::insert): Add Ada code.
1156         (debug_names::write_psymbols): Remove Ada check.
1157         (debug_names) <m_string_obstack>: New member.
1158         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1159         (gdb_index_symbol_name_matcher::matches): Remove.
1160         (mapped_index_base::find_name_components_bounds): Add "lang"
1161         parameter.
1162         (mapped_index_base::build_name_components): Also split names
1163         according to Ada syntax.
1164         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1165         type of "match_callback".
1166         (check_match, check_find_bounds_finds)
1167         (dw2_expand_symtabs_matching): Update.
1168         (dw2_debug_names_iterator): Add new constructor.
1169         (dw2_debug_names_map_matching_symbols): New function.
1170         (dw2_debug_names_expand_symtabs_matching): Update.
1171         (dwarf2_debug_names_functions): Use
1172         dw2_debug_names_map_matching_symbols.
1173
1174 2019-09-10  Tom Tromey  <tromey@adacore.com>
1175
1176         * dwarf2read.c (dw2_get_file_names_reader): Add the
1177         CU's file name to the results.
1178
1179 2019-09-10  Tom Tromey  <tromey@adacore.com>
1180
1181         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1182         map_matching_symbols.  Update.
1183         * dwarf2read.c (dw2_map_matching_symbols): Update.
1184         * psymtab.c (match_partial_symbol): Change type; update.
1185         (psym_map_matching_symbols): Likewise.
1186         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1187         type; update.
1188         * symfile.h (struct quick_symbol_functions)
1189         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1190         Remove "match".
1191
1192 2019-09-10  Tom Tromey  <tromey@adacore.com>
1193
1194         * psymtab.c (map_block): Remove.
1195         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1196         * symtab.c (iterate_over_symbols_terminated): New function.
1197         * symtab.c (iterate_over_symbols_terminated): Declare.
1198
1199 2019-09-10  Tom Tromey  <tromey@adacore.com>
1200
1201         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1202         * language.h (struct language_defn) <la_iterate_over_symbols>:
1203         Return bool.
1204         * symtab.c (iterate_over_symbols): Return bool.
1205         * symtab.h (iterate_over_symbols): Return bool.
1206
1207 2019-09-10  Tom Tromey  <tromey@adacore.com>
1208
1209         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1210         (add_nonlocal_symbols): Update.
1211         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1212         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1213         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1214         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1215         Change type of "callback".  Remove "data".
1216
1217
1218 2019-09-09  Ali Tamur  <tamur@google.com>
1219
1220         * dwarf2read.c (comp_unit_head): Update comment.
1221         (dwarf2_dwo_name): New function declaration.
1222         (dwarf_unit_type_name): New function declaration.
1223         (read_comp_unit_head): Add support for new compilation units,
1224         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1225         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1226         (currently named as "signature") in their header. Also clarify error
1227         messages.
1228         (lookup_dwo_id): New function. Returns the dwo id of the given
1229         compile unit.
1230         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1231         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1232         functions.
1233         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1234         (dwarf2_dwo_name): Get the dwo name if present.
1235         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1236         purposes.
1237
1238 2019-09-09  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1241
1242 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * python/python.c (do_start_initialization): Make progname_copy static,
1245         to avoid a leak report.
1246
1247 2019-09-08  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1250
1251 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1252
1253         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1254         Change type to gdb::optional<block_enum>.
1255         (dw2_symtab_iter_init): Change block_index parameter type
1256         to gdb::optional<block_enum>.
1257         (dw2_lookup_symbol): Change block_index parameter
1258         type to block_enum.c
1259         (dw2_debug_names_lookup_symbol): Likewise.
1260         * psymtab.c (psym_lookup_symbol): Likewise.
1261         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1262         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1263         Likewise.
1264
1265 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * defs.h (relocate_gdb_directory): Change int to bool in
1268         signature and rename flag to relocatable.
1269         * main.c (relocate_path): Likewise.
1270         (relocate_gdb_directory): Likewise.
1271
1272 2019-09-06  Alan Modra  <amodra@gmail.com>
1273
1274         * coffread.c (coff_symfile_read): Constify filename variable.
1275         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1276         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1277         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1278         * solib.c (reload_shared_libraries_1): Likewise.
1279         * symfile.c (reread_symbols): Likewise.
1280         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1281         * solib-darwin.c (darwin_bfd_open): Likewise.
1282         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1283
1284 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1287         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1288
1289 2019-09-03  Tom Tromey  <tromey@adacore.com>
1290
1291         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1292         types.
1293         (has_negatives): Unbias a range type bound.
1294         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1295         * gdbtypes.c (operator==): Handle new field.
1296         (create_range_type): Add "bias" parameter.
1297         (create_static_range_type, resolve_dynamic_range): Update.
1298         * gdbtypes.h (struct range_bounds) <bias>: New member.
1299         (create_range_type): Add bias parameter.
1300         * printcmd.c (print_scalar_formatted): Unbias range types.
1301         * value.c (unpack_long): Unbias range types.
1302         (pack_long): Bias range types.
1303
1304 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1305
1306         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1307         probe arguments.
1308
1309 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1312         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1313         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1314         (compile_probe_arg): Likewise.
1315         * probe.h (get_argument_count): Likewise.
1316         * solib-svr4.c (solib_event_probe_action): Likewise.
1317         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1318
1319 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1320
1321         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1322         code to here...
1323         (svr4_create_solib_event_breakpoints): ...from here.
1324
1325 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1326
1327         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1328         suffix from warning message.
1329
1330 2019-08-30  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.h (struct tui_source_window_base)
1333         <refresh_all>: Don't declare.
1334         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1335         Remove.
1336         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1337         tui_show_locator_content.
1338         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1339         declare.
1340         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1341         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1342         declare.
1343
1344 2019-08-30  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1347
1348 2019-08-30  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1351         Remove unnecessary forward declarations.
1352
1353 2019-08-30  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1356         rerender.
1357         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1358         tui_show_locator_content.
1359
1360 2019-08-30  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1363         (tui_locator_window::rerender): Rewrite using body of previous
1364         tui_show_locator_content.
1365
1366 2019-08-30  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1369         set_locator_fullname>: New methods.
1370         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1371         Rename from tui_set_locator_fullname.
1372         (tui_locator_window::set_locator_info): Rename from
1373         tui_set_locator_info.  Return bool.
1374         (tui_update_locator_fullname, tui_show_frame_info): Update.
1375
1376 2019-08-30  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1379
1380 2019-08-30  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1383         call touchwin.
1384
1385 2019-08-30  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-wingeneral.c (box_win): Assume win_info and
1388         win_info->handle cannot be NULL.
1389
1390 2019-08-30  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1393         refresh_window>: Declare.
1394         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1395         resize.
1396         (tui_data_item_window::rerender): Rename from
1397         tui_display_register.
1398         (tui_data_item_window::refresh_window): New method.
1399         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1400         no-op.
1401
1402 2019-08-30  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1405         regs_column_count, current_group>: Move later.  Now private.
1406         <get_current_group>: New method.
1407         * tui/tui-regs.c (tui_reg_command): Update.
1408         * tui/tui-layout.c (tui_set_layout): Update.
1409
1410 2019-08-30  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1413         (tui_data_window::rerender): Don't call
1414         check_and_display_highlight_if_needed.
1415         (tui_data_window::refresh_all): Remove call to
1416         erase_data_content.
1417
1418 2019-08-30  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1421         (tui_data_window::display_registers_from)
1422         (tui_data_window::display_reg_element_at_line)
1423         (tui_data_window::display_registers_from_line): Remove checks of
1424         "empty".
1425
1426 2019-08-30  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1429         Don't declare.
1430         * tui/tui-regs.c (tui_data_window::show_registers): Call
1431         rerender.
1432         (tui_data_window::rerender): Rename from display_all_data.
1433         (tui_data_window::rerender): Remove old implementation.
1434
1435 2019-08-30  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1438         text.
1439         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1440
1441 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1442             Sergio Durigan Junior  <sergiodj@redhat.com>
1443
1444         PR win32/24284
1445         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1446
1447 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1450         when searching for types.
1451
1452 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * f-lang.c (f_language_defn): Use f_print_typedef.
1455         * f-lang.h (f_print_typedef): Declare.
1456         * f-typeprint.c (f_print_typedef): Define.
1457
1458 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1459
1460         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1461
1462 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1463
1464         * cli/cli-utils.c (info_print_options_defs): Delete.
1465         (make_info_print_options_def_group): Delete.
1466         (extract_info_print_options): Delete.
1467         (info_print_command_completer): Delete.
1468         (info_print_args_help): Add extra parameter, and optionally
1469         include text about -n flag.
1470         * cli/cli-utils.h (struct info_print_options): Delete.
1471         (extract_info_print_options): Delete declaration.
1472         (info_print_command_completer): Delete declaration.
1473         (info_print_args_help): Add extra parameter, extend header
1474         comment.
1475         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1476         search_symbols.
1477         * stack.c (struct info_print_options): New type.
1478         (info_print_options_defs): New file scoped variable.
1479         (make_info_print_options_def_group): New static function.
1480         (info_print_command_completer): New static function.
1481         (info_locals_command): Update to use new local functions.
1482         (info_args_command): Likewise.
1483         (_initialize_stack): Add extra parameter to calls to
1484         info_print_args_help.
1485         * symtab.c (search_symbols): Add extra parameter, use this to
1486         possibly excluse non-debug symbols.
1487         (symtab_symbol_info): Add extra parameter, which is passed on to
1488         search_symbols.
1489         (struct info_print_options): New type.
1490         (info_print_options_defs): New file scoped variable.
1491         (make_info_print_options_def_group): New static function.
1492         (info_print_command_completer): New static function.
1493         (info_variables_command): Update to use local functions, and pass
1494         extra parameter through to symtab_symbol_info.
1495         (info_functions_command): Likewise.
1496         (info_types_command): Pass additional argument through to
1497         symtab_symbol_info.
1498         (rbreak_command): Pass extra argument to search_symbols.
1499         (_initialize_symtab): Add extra arguments for calls to
1500         info_print_args_help, and update help text for 'info variables',
1501         'whereis', and 'info functions' commands.
1502         * symtab.h (search_symbols): Add extra argument to declaration.
1503         * NEWS: Mention new flags.
1504
1505 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1506
1507         * symtab.c (lookup_static_symbol): Call the new function (and move
1508         it down to be next to lookup_global_symbol).
1509         (struct global_sym_lookup_data): Add block_enum member and rename to...
1510         (struct global_or_static_sym_lookup_data): ...this.
1511         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1512         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1513         (lookup_symbol_global_or_static_iterator_cb): ...this.
1514         (lookup_global_or_static_symbol): New function.
1515         (lookup_global_symbol): Call new function.
1516
1517 2019-08-26  Tom de Vries  <tdevries@suse.de>
1518
1519         PR c++/24852
1520         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1521         when pc_probe.prob == NULL.
1522
1523 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1524
1525         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1526         variable symbol_linkage to symbol_linkage_.
1527
1528 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1529
1530         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1531         represent whether the symbol is static, dynamic, or we don't
1532         know.
1533
1534 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1535
1536         * gdb/rx-tdep.c (rx_register_names): New.
1537         (rx_register_name): Delete.
1538         (rx_psw_type): Delete.
1539         (rx_fpsw_type): Delete.
1540         (rx_register_type): Delete.
1541         (rx_gdbarch_init): Convert target-descriptions.
1542         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1543         * gdb/features/Makefile: Add rx.xml.
1544         * gdb/features/rx.xml: New.
1545         * gdb/features/rx.c: Generated.
1546         * gdb/NEWS: Mention target description support.
1547
1548 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1551         *slot_ptr.
1552
1553 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1554
1555         * configure.ac: Don't check for 'dlfcn.h' (moved to
1556         gdbsupport/common.m4).
1557         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1558         'gdbsupport/'.
1559         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1560         * compile/compile-c-support.c: Include
1561         'gdbsupport/gdb-dlfcn.h'.
1562         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1563         * gdb-dlfcn.c: Move to...
1564         * gdbsupport/gdb-dlfcn.c: ... here.
1565         * gdb-dlfcn.h: Move to...
1566         * gdbsupport/gdb-dlfcn.h: ... here.
1567
1568 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1569
1570         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1571         the offset field signed.
1572
1573 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1574
1575         * python/lib/gdb/__init__.py (_execute_file): New function.
1576         * python/python.c (python_run_simple_file): Call gdb._execute_file
1577         on Windows.
1578
1579 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1582         all uses as this was never set to anything but a zero value.
1583
1584 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1585
1586         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1587
1588 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1589
1590         * tui/tui-data.h (tui_gen_win_info): Add an =default
1591         move constructor, required by some GCC versions.
1592
1593 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1594
1595         * go32-nat.c (go32_sysinfo): Add hygon_p.
1596
1597 2019-08-20  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1600         line_from_reg_element_no, first_reg_element_no_inline,
1601         display_all_data, delete_data_content_windows,
1602         erase_data_content>: Now private.
1603
1604 2019-08-20  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1607         (tui_unhighlight_win, tui_highlight_win)
1608         (tui_win_info::make_window): Update.
1609         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1610
1611 2019-08-20  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1614         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1615         (MAX_PID_WIDTH): Move to tui-stack.c.
1616         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1617         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1618         (MAX_PID_WIDTH): Move from tui-data.h.
1619
1620 2019-08-20  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1623         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1624         (box_win): Update.
1625         (tui_gen_win_info::make_window): Rename from tui_make_window.
1626         (tui_win_info::make_window): New method.
1627         (tui_gen_win_info::make_visible): Update.
1628         * tui/tui-source.c (tui_source_window::set_contents): Update.
1629         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1630         (tui_data_window::display_registers_from): Update.
1631         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1632         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1633         Declare.
1634         <can_box>: Remove.
1635         <title>: Remove.
1636         (struct tui_win_info) <make_window>: Declare.
1637         <can_box>: Now virtual.
1638         <title>: New member.
1639         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1640         * tui/tui-command.c (tui_cmd_window::resize): Update.
1641
1642 2019-08-20  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1645         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1646         (tui_data_window::check_register_values): Update.
1647
1648 2019-08-20  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-regs.h (struct tui_data_window): Use
1651         DISABLE_COPY_AND_ASSIGN.
1652         <regs_content>: Change type, removing unique_ptr.
1653         <tui_data_window>: Add move constructor.
1654         * tui/tui-regs.c (tui_data_window::show_registers)
1655         (tui_data_window::show_register_group)
1656         (tui_data_window::display_registers_from)
1657         (tui_data_window::display_registers_from)
1658         (tui_data_window::first_data_item_displayed)
1659         (tui_data_window::delete_data_content_windows)
1660         (tui_data_window::rerender, tui_data_window::refresh_window)
1661         (tui_data_window::check_register_values): Update.
1662
1663 2019-08-20  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1666         show_register_group>: Declare.
1667         (tui_show_register_group): Don't declare.
1668         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1669         tui_show_registers.
1670         (tui_data_window::show_register_group): Rename from
1671         tui_show_register_group.
1672         (tui_data_window::check_register_values, tui_reg_command):
1673         Update.
1674         * tui/tui-layout.c (tui_set_layout): Update.
1675
1676 2019-08-20  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1679         Declare.
1680         (tui_check_register_values): Don't declare.
1681         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1682         from tui_check_register_values.
1683         * tui/tui-hooks.c (tui_register_changed): Update.
1684
1685 2019-08-20  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-regs.c (tui_reg_layout): Move later.
1688         (tui_show_registers): Don't enable TUI mode or change layout.
1689
1690 2019-08-20  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-regs.h (struct tui_data_item_window)
1693         <~tui_data_item_window>: Remove.
1694         <content>: Now a unique_xmalloc_ptr.
1695         * tui/tui-regs.c (tui_register_format): Return a
1696         unique_xmalloc_ptr.
1697         (tui_get_register): Update.
1698         (~tui_data_item_window): Remove.
1699         (tui_data_window::display_registers_from, tui_display_register):
1700         Update.
1701         * tui/tui-io.h (tui_expand_tabs): Update.
1702         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1703         Remove "col" parameter.
1704
1705 2019-08-20  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1708         field.
1709         * tui/tui-regs.c (~tui_data_item_window): Update.
1710
1711 2019-08-20  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1714         earlier.
1715
1716 2019-08-20  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1719
1720 2019-08-20  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-source.h (struct tui_source_window): Update.
1723         * tui/tui-regs.c (tui_show_registers): Update.
1724         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1725         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1726         (NO_REGS_STRING): Remove defines.
1727
1728 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1729
1730         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1731         unnecessary thread walk if remote doesn't support the packet.
1732
1733 2019-08-19  Tom Tromey  <tromey@adacore.com>
1734
1735         * python/py-value.c (value_has_field): Fix indentation.
1736
1737 2019-08-19  Tom Tromey  <tromey@adacore.com>
1738
1739         * printcmd.c (do_one_display, info_display_command): Update.
1740         * block.h (contained_in): Return bool.  Add allow_nested
1741         parameter.
1742         * block.c (contained_in): Return bool.  Add allow_nested
1743         parameter.
1744
1745 2019-08-19  Tom Tromey  <tom@tromey.com>
1746
1747         * configure: Rebuild.
1748         * configure.ac: Disallow the combination of -static-libstdc++ and
1749         source highlight.
1750         * source-cache.c (get_language_name): Handle rust.
1751         (source_cache::get_source_lines): Ignore highlighting exceptions.
1752
1753 2019-08-16  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1756         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1757         (struct tui_source_window_base) <make_visible, refresh_window,
1758         resize>: Remove methods.
1759         <execution_info>: Remove field.
1760         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1761         (tui_show_source_line, tui_source_window_base)
1762         (~tui_source_window_base): Update.
1763         (tui_source_window_base::resize)
1764         (tui_source_window_base::make_visible)
1765         (tui_source_window_base::refresh_window): Remove.
1766         (tui_source_window_base::update_exec_info): Update.
1767         * tui/tui-source.c (tui_source_window::set_contents): Update.
1768         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1769
1770 2019-08-16  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1773         deprecated_query_hook.
1774
1775 2019-08-16  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1778         (tui_update_source_windows_with_line): Update.
1779         * tui/tui-source.h (struct tui_source_window)
1780         <show_symtab_source>: Declare.
1781         (tui_show_symtab_source): Don't declare.
1782         * tui/tui-source.c (tui_show_symtab_source): Rename from
1783         tui_show_symtab_source.
1784
1785 2019-08-16  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-winsource.h (struct tui_source_window_base)
1788         <set_contents>: Declare.
1789         * tui/tui-winsource.c
1790         (tui_source_window_base::update_source_window_as_is): Update.
1791         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1792         Declare.
1793         (tui_set_source_content): Don't declare.
1794         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1795         tui_set_source_content.
1796         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1797         Declare.
1798         (tui_set_disassem_content): Don't declare.
1799         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1800         tui_set_disassem_content.
1801
1802 2019-08-16  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-winsource.h (struct tui_source_window_base)
1805         <update_breakpoint_info>: Declare.
1806         (tui_update_breakpoint_info): Don't declare.
1807         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1808         (tui_update_all_breakpoint_info): Update.
1809         (tui_source_window_base::update_breakpoint_info): Rename from
1810         tui_update_breakpoint_info.
1811         (tui_source_window_base::update_exec_info): Update.
1812
1813 2019-08-16  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-winsource.h (struct tui_source_window_base)
1816         <update_source_window>: Declare.
1817         (tui_update_source_window): Don't declare.
1818         * tui/tui-winsource.c
1819         (tui_source_window_base::update_source_window): Rename from
1820         tui_update_source_window.
1821         (tui_source_window_base::rerender): Update.
1822         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1823         * tui/tui-disasm.c (tui_show_disassem)
1824         (tui_show_disassem_and_update_source)
1825         (tui_disasm_window::maybe_update): Update.
1826
1827 2019-08-16  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-winsource.h (struct tui_source_window_base)
1830         <update_source_window_as_is>: Declare.
1831         (tui_update_source_window_as_is): Don't declare.
1832         * tui/tui-winsource.c (tui_update_source_window): Update
1833         (tui_source_window_base::update_source_window_as_is): Rename from
1834         tui_update_source_window_as_is.
1835         (tui_source_window_base::refill): Update.
1836         * tui/tui-source.c (tui_show_symtab_source): Update.
1837         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1838         Update.
1839
1840 2019-08-16  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.h (tui_update_source_window)
1843         (tui_update_source_window_as_is): Remove "noerror" parameter.
1844         * tui/tui-winsource.c (tui_update_source_window)
1845         (tui_update_source_window_as_is): Remove "noerror" parameter.
1846         (tui_update_source_windows_with_addr)
1847         (tui_update_source_windows_with_line)
1848         (tui_source_window_base::rerender)
1849         (tui_source_window_base::refill): Update.
1850         * tui/tui-source.h (tui_set_source_content)
1851         (tui_show_symtab_source): Remove "noerror" parameter.
1852         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1853         parameter.
1854         (tui_show_symtab_source): Likewise.
1855         (tui_source_window::maybe_update): Update.
1856         * tui/tui-disasm.c (tui_show_disassem)
1857         (tui_show_disassem_and_update_source)
1858         (tui_disasm_window::do_scroll_vertical)
1859         (tui_disasm_window::maybe_update): Update.
1860
1861 2019-08-16  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui.c (tui_is_window_visible): Update.
1864         * tui/tui-wingeneral.c (tui_make_window)
1865         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1866         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1867         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1868         (tui_set_win_height_command, parse_scrolling_args): Update.
1869         * tui/tui-source.c (tui_source_window::style_changed): Update.
1870         * tui/tui-regs.c (tui_show_registers)
1871         (tui_data_window::first_data_item_displayed)
1872         (tui_data_window::delete_data_content_windows)
1873         (tui_check_register_values, tui_reg_command): Update.
1874         * tui/tui-disasm.c (tui_show_disassem): Update.
1875         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1876         method.
1877         <is_visible>: Remove field.
1878         * tui/tui-data.c (tui_next_win, tui_prev_win)
1879         (tui_delete_invisible_windows): Update.
1880
1881 2019-08-16  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-winsource.h (struct tui_source_window_base)
1884         <m_has_locator>: Remove.
1885         * tui/tui-layout.c (show_source_disasm_command, show_data)
1886         (show_source_or_disasm_and_command): Update.
1887
1888 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1889
1890         * NEWS (Other MI changes): New subsection.
1891         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1892         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1893         * arch-utils.c (default_get_pc_address_flags): New function.
1894         * arch-utils.h (default_get_pc_address_flags): New declaration.
1895         * gdbarch.sh: Add get_pc_address_flags.
1896         * gdbarch.c: Regenerate.
1897         * gdbarch.h: Likewise.
1898         * stack.c (print_pc): New function.
1899         (print_frame_info) (print_frame): Call print_pc.
1900
1901 2019-08-16  Tom de Vries  <tdevries@suse.de>
1902
1903         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1904         print_objfile_section_info.
1905
1906 2019-08-15  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1909         calling update_cmdwin_start_line.
1910         * tui/tui-winsource.h (struct tui_source_window_base)
1911         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1912         <rerender>: Declare.
1913         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1914         Call rerender.
1915         (tui_source_window_base::set_new_height): Remove.
1916         (tui_source_window_base::rerender): Rename from
1917         do_make_visible_with_new_height.
1918         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1919         resize method.
1920         (tui_win_info::make_invisible_and_set_new_height)
1921         (tui_win_info::make_visible_with_new_height): Remove.
1922         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1923         Declare.
1924         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1925         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1926         do_make_visible_with_new_height>: Don't declare.
1927         <rerender>: Declare.
1928         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1929         set_new_height.
1930         (tui_data_window::do_make_visible_with_new_height): Remove.
1931         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1932         call tui_show_locator_content.
1933         (tui_gen_win_info::resize): Call rerender.
1934         (show_source_or_disasm_and_command): Don't call
1935         tui_show_locator_content.
1936         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1937         method.
1938         (struct tui_win_info) <rerender>: Declare.
1939         <set_new_height, make_invisible_and_set_new_height,
1940         make_visible_with_new_height>: Don't declare.
1941         * tui/tui-data.c (tui_win_list::rerender): New method.
1942         * tui/tui-command.h (struct tui_cmd_window)
1943         <do_make_visible_with_new_height>: Don't declare.
1944         * tui/tui-command.c
1945         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1946
1947 2019-08-15  Tom Tromey  <tromey@adacore.com>
1948
1949         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1950         * ada-lang.c (ada_enum_name): Likewise.
1951
1952 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1953
1954         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1955         leading underscore.
1956         (GdbOutputErrorFile): Likewise.
1957         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1958         accordingly.
1959         (execute_unwinders): Rename to have a leading underscore.
1960         (auto_load_packages): Likewise.
1961         (global scope): Adjust call to auto_load_packages accordingly.
1962         (GdbSetPythonDirectory): Likewise.
1963         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1964         instead of execute_unwinders.
1965
1966 2019-08-15  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1969         (show_data): Don't change window visibility.
1970         (tui_gen_win_info::resize): Remove special case for command
1971         window.  Use wresize, when available.
1972         (show_source_or_disasm_and_command): Don't change window
1973         visibility.
1974         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1975         <make_visible>: New method.
1976         * tui/tui-command.c (tui_cmd_window::resize): New method.
1977
1978 2019-08-15  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1981         (struct tui_source_windows): New.
1982         * tui/tui-winsource.c (tui_display_main): Update.
1983         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1984         (new_height_ok, parse_scrolling_args): Update.
1985         * tui/tui-layout.c (show_layout, show_data): Update.
1986         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1987         (tui_add_to_source_windows): Don't declare.
1988         * tui/tui-data.c (source_windows, tui_source_windows)
1989         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1990
1991 2019-08-15  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1994         Rename from reset.
1995         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1996         * tui/tui-layout.c (show_source_disasm_command, show_data):
1997         Update.
1998         (tui_gen_win_info::resize): Rename.
1999         (show_source_or_disasm_and_command): Update.
2000         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2001         reset.
2002
2003 2019-08-15  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2006         * tui/tui-interp.c (tui_interp::init): Don't call
2007         tui_initialize_static_data.
2008         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2009
2010 2019-08-15  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2013         examine tui_win_list.
2014
2015 2019-08-15  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2018         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2019         tui_clear_source_content.
2020         (tui_clear_source_content): Remove.
2021         (tui_source_window_base::do_erase_source_content): Hoist call to
2022         content.clear().
2023         * tui/tui-stack.c (tui_show_frame_info): Don't call
2024         tui_clear_source_content.
2025
2026 2019-08-15  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-winsource.h (struct tui_source_window_base)
2029         <do_erase_source_content>: New method.
2030         <erase_source_content>: New method.
2031         (tui_erase_source_content): Don't declare.
2032         * tui/tui-winsource.c (tui_clear_source_content): Update.
2033         (tui_source_window_base::do_erase_source_content): Rename from
2034         tui_erase_source_content.
2035         (tui_source_window_base::show_source_content): Update.
2036         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2037         * tui/tui-source.h (struct tui_source_window)
2038         <erase_source_content>: New method.
2039         * tui/tui-disasm.h (struct tui_disasm_window)
2040         <erase_source_content>: New method.
2041
2042 2019-08-15  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2045         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2046         constructor.
2047         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2048         * tui/tui-source.c (tui_set_source_content): Update.
2049         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2050
2051 2019-08-15  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2054         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2055         tui-source.c.
2056         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2057         Declare.
2058         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2059         method.
2060         (tui_source_window::maybe_update): Update.
2061
2062 2019-08-15  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2065         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2066         tui-disasm.c.
2067         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2068         Declare.
2069         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2070         method.
2071         (tui_disasm_window::maybe_update): Update.
2072
2073 2019-08-15  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-winsource.h (struct tui_source_window_base)
2076         <maybe_update>: Declare.
2077         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2078         method.
2079         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2080         Declare.
2081         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2082         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2083         Declare.
2084         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2085
2086 2019-08-15  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2089
2090 2019-08-15  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-wingeneral.c: Include tui-stack.h.
2093         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2094         (struct tui_locator_window): Move from tui-data.h.
2095         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2096         (tui_initialize_static_data): Move from tui-data.c.
2097         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2098         (struct tui_locator_window): Move to tui-stack.c.
2099         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2100         (tui_initialize_static_data): Move to tui-stack.c.
2101
2102 2019-08-15  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-layout.c (show_source_disasm_command)
2105         (show_source_or_disasm_and_command): Use make_visible method, not
2106         tui_make_window.
2107         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2108         Remove.
2109
2110 2019-08-15  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-wingeneral.h (tui_make_window): Update.
2113         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2114         parameter.
2115         (tui_gen_win_info::make_visible): Update.
2116         * tui/tui-regs.c (tui_data_window::display_registers_from):
2117         Update.
2118         * tui/tui-layout.c (show_source_disasm_command)
2119         (show_source_or_disasm_and_command): Update.
2120         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2121         (enum tui_box): Remove.
2122         (struct tui_win_info) <can_box>: New method.
2123         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2124         method.
2125
2126 2019-08-15  Tom de Vries  <tdevries@suse.de>
2127
2128         * linux-nat-trad.c: Include gdbarch.h.
2129
2130 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2131
2132         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2133         register sizes.
2134
2135 2019-08-14  Tom Tromey  <tromey@adacore.com>
2136
2137         * darwin-nat.c: Include gdbarch.h.
2138         * darwin-nat-info.c: Include gdbarch.h.
2139
2140 2019-08-13  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2143         Remove.
2144         * tui/tui-data.c (tui_initialize_static_data): Update.
2145
2146 2019-08-13  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-winsource.h (struct tui_exec_info_window)
2149         <~tui_exec_info_window, maybe_allocate_content, get_content,
2150         m_content>: Remove.
2151         (struct tui_source_window_base) <set_exec_info_content,
2152         show_exec_info_content>: Don't declare.
2153         * tui/tui-winsource.c
2154         (tui_exec_info_window::maybe_allocate_content): Remove.
2155         (tui_source_window_base::update_exec_info): Rename from
2156         set_exec_info_content.
2157         (tui_source_window_base::show_exec_info_content)
2158         (tui_source_window_base::update_exec_info): Remove.
2159
2160 2019-08-13  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2163         declare.
2164         * tui/tui-winsource.c (tui_update_source_window_as_is)
2165         (tui_update_source_windows_with_addr, tui_erase_source_content):
2166         Update.
2167         (tui_clear_exec_info_content): Remove.
2168
2169 2019-08-13  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2172         declare.
2173         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2174         call tui_erase_exec_info_content.
2175         (tui_clear_exec_info_content): Rename from
2176         tui_erase_exec_info_content.
2177         (tui_clear_exec_info_content): Delete.
2178
2179 2019-08-13  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.h (struct tui_source_window_base)
2182         <show_exec_info_content>: Declare.
2183         (tui_show_exec_info_content): Don't declare.
2184         * tui/tui-winsource.c
2185         (tui_source_window_base::show_exec_info_content): Rename from
2186         tui_show_exec_info_content.
2187         (tui_source_window_base::update_exec_info): Update.
2188
2189 2019-08-13  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2192         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2193         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2194         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2195         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2196         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2197         ... here.
2198
2199 2019-08-13  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-winsource.h (struct tui_source_window_base)
2202         <update_exec_info>: Declare.
2203         (tui_update_exec_info): Don't declare.
2204         * tui/tui-winsource.c (tui_update_source_window_as_is)
2205         (tui_source_window_base::refresh_all)
2206         (tui_update_all_breakpoint_info): Update.
2207         (tui_source_window_base::update_exec_info): Rename from
2208         tui_update_exec_info.
2209         * tui/tui-stack.c (tui_show_frame_info): Update.
2210
2211 2019-08-13  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-winsource.h (struct tui_source_window_base)
2214         <set_exec_info_content>: Declare.
2215         (tui_set_exec_info_content): Don't declare.
2216         * tui/tui-winsource.c
2217         (tui_source_window_base::set_exec_info_content): Rename from
2218         tui_set_exec_info_content.
2219         (tui_update_exec_info): Update.
2220
2221 2019-08-13  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-winsource.h (struct tui_source_window_base)
2224         <show_source_content>: Declare.
2225         (tui_show_source_content): Don't declare.
2226         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2227         (tui_source_window_base::show_source_content): Rename from
2228         tui_show_source_content.
2229         (tui_source_window_base::refresh_all): Update.
2230         * tui/tui-layout.c (show_source_disasm_command)
2231         (show_source_or_disasm_and_command): Update.
2232
2233 2019-08-13  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-winsource.c (tui_erase_source_content)
2236         (tui_show_source_content, tui_source_window_base::refresh_all):
2237         Update.
2238         * tui/tui-wingeneral.h
2239         (tui_check_and_display_highlight_if_needed): Don't declare.
2240         * tui/tui-wingeneral.c
2241         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2242         check_and_display_highlight_if_needed.
2243         * tui/tui-win.c (tui_rehighlight_all)
2244         (tui_win_info::make_visible_with_new_height): Update.
2245         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2246         (tui_data_window::erase_data_content)
2247         (tui_data_window::display_all_data): Update.
2248         * tui/tui-data.h (struct tui_win_info)
2249         <check_and_display_highlight_if_needed>: Declare.
2250
2251 2019-08-13  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-win.c (tui_resize_all): Call
2254         tui_delete_invisible_windows.
2255         * tui/tui-layout.c (show_layout): Call
2256         tui_delete_invisible_windows.
2257         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2258         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2259
2260 2019-08-13  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2263         tui_add_win_to_layout.
2264
2265 2019-08-13  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2268         * tui/tui-layout.c (tui_default_win_height): Now static.
2269
2270 2019-08-13  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2273         single switch.
2274         (show_source_disasm_command, show_source_or_disasm_and_command):
2275         Don't check current layout.
2276
2277 2019-08-13  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-wingeneral.c (make_all_visible): Remove.
2280         (tui_make_all_invisible): Simplify.
2281         * tui/tui-layout.c (tui_make_all_invisible): Move from
2282         tui-wingeneral.c; simplify.
2283         (show_layout): Hoist call to tui_make_all_invisible.
2284         (show_data): Don't call tui_make_all_invisible.
2285
2286 2019-08-13  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2289         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2290
2291 2019-08-13  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2294         tui-data.c.
2295         (show_source_disasm_command, show_data)
2296         (show_source_or_disasm_and_command): Don't use
2297         tui_set_current_layout_to.
2298         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2299         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2300         tui-layout.c.
2301         (tui_set_current_layout_to): Remove.
2302
2303 2019-08-13  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-layout.c (tui_set_layout): Update.
2306         * tui/tui-data.h (struct tui_layout_def): Remove.
2307         (tui_layout_def): Don't declare.
2308         * tui/tui-data.c (layout_def): Remove.
2309         (tui_layout_def): Remove.
2310
2311 2019-08-13  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-winsource.h (struct tui_source_window_base)
2314         <clear_detail>: No longer "override".
2315         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2316         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2317         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2318         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2319         Remove.
2320         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2321
2322 2019-08-13  Tom Tromey  <tromey@adacore.com>
2323
2324         * tracepoint.c: Don't include readline.h or history.h.
2325
2326 2019-08-12  Tom Tromey  <tom@tromey.com>
2327
2328         * configure: Rebuild.
2329         * configure.ac: Check for readline 7.
2330         * NEWS: Mention readline 7 requirement.
2331         * README: Update.
2332
2333 2019-08-12  Tom Tromey  <tom@tromey.com>
2334
2335         * mingw-hdep.c (gdb_select): Remove readline hack.
2336
2337 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2338
2339         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2340         when the function fails.
2341
2342 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2343
2344         * s390-tdep.c (s390_type_align): New function.
2345         (s390_gdbarch_init): Set it as type_align gdbarch method.
2346
2347 2019-08-09  Tom de Vries  <tdevries@suse.de>
2348
2349         PR gdb/24591
2350         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2351         pc_low with relocation offset.
2352
2353 2019-08-07  Tom Tromey  <tromey@adacore.com>
2354
2355         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2356         (print_frame_args): Update.
2357         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2358         Update.
2359         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2360         * frame.h (struct frame_arg): Add initializers.
2361         <error>: Now a unique_xmalloc_ptr.
2362
2363 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2364
2365         * NEWS: Expand the Pointer Authentication entry.
2366         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2367         (aarch64_frame_unmask_lr): ... to this.
2368         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2369         Call aarch64_frame_unmask_lr.
2370         * frame.c (struct frame_info): Add "masked" variable.
2371         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2372         (fprint_frame): Check for masked pc.
2373         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2374         declarations.
2375         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2376         * stack.c (print_frame): Check for masked pc.
2377
2378 2019-08-06  Tom Tromey  <tom@tromey.com>
2379
2380         * stabsread.c (patch_block_stabs, read_one_struct_field)
2381         (read_enum_type): Use obstack_strndup.
2382         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2383         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2384         * dwarf2read.c (guess_full_die_structure_name)
2385         (anonymous_struct_prefix): Use obstack_strndup.
2386         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2387         * c-exp.y (yylex): Use obstack_strndup.
2388         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2389         (write_var_or_type): Use obstack_strndup.
2390
2391 2019-08-06  Tom Tromey  <tom@tromey.com>
2392
2393         * symfile.c (reread_symbols): Use obstack_strdup.
2394         * stabsread.c (read_type): Use obstack_strdup.
2395         * gdb_obstack.h (obstack_strdup): New overload.
2396         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2397         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2398         (dwarf2_canonicalize_name): Use obstack_strdup.
2399         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2400         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2401         Use obstack_strdup.
2402
2403 2019-08-06  Tom Tromey  <tom@tromey.com>
2404
2405         * gdb_obstack.h (obstack_strdup): Define.
2406         * gdb_obstack.c (obstack_strdup): Don't define.
2407
2408 2019-08-06  Tom Tromey  <tom@tromey.com>
2409
2410         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2411         obstack_strdup.
2412         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2413         obstack_strdup.
2414         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2415         * stabsread.c (common_block_start): Use obstack_strdup.
2416         * objfiles.c (set_objfile_main_name, objfile): Use
2417         obstack_strdup.
2418         * namespace.c (add_using_directive): Use obstack_strdup.
2419         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2420         * jit.c (finalize_symtab): Use obstack_strdup.
2421         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2422         (guess_partial_die_structure_name, partial_die_info::fixup)
2423         (dwarf2_name): Use obstack_strdup.
2424         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2425         obstack_strdup.
2426         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2427         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2428         obstack_strdup.
2429         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2430
2431 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2432
2433         * unittests/help-doc-selftests.c: New file.
2434         * Makefile.in: Add the new file.
2435
2436 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2437
2438         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2439         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2440         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2441         the trailing '.' is not output, and the first character is uppercased.
2442         (print_help_for_command): Update call to print_doc_line.
2443         (print_doc_of_command): Likewise.
2444         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2445         * cli/cli-option.c (append_indented_doc): Do not append newline.
2446         (build_help_option): Append newline after first appended_indented_doc
2447         only if a second call is done.
2448         (build_help): Append 2 new lines before each option, except the first
2449         one.
2450         * compile/compile.c (_initialize_compile): Add new lines after
2451         %OPTIONS%, when not at the end of the help.
2452         Change help doc or code
2453         producing the help doc to respect the invariants.
2454         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2455         Also removed the new line after 'Options:', as all other commands
2456         do not put an empty line between 'Options:' and the first option.
2457         * printcmd.c (_initialize_printcmd): Likewise.
2458         * stack.c (_initialize_stack): Likewise.
2459         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2460         incorrectly telling COMMAND is optional.
2461         * ada-lang.c (_initialize_ada_language): Change help doc or code
2462         producing the help doc to respect the invariants.
2463         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2464         * breakpoint.c (_initialize_breakpoint): Likewise.
2465         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2466         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2467         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2468         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2469         _initialize_cli_style): Likewise.
2470         * corelow.c (core_target_info): Likewise.
2471         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2472         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2473         * filesystem.c (_initialize_filesystem): Likewise.
2474         * frame.c (_initialize_frame): Likewise.
2475         * gnu-nat.c (add_task_commands): Likewise.
2476         * infcall.c (_initialize_infcall): Likewise.
2477         * infcmd.c (_initialize_infcmd): Likewise.
2478         * interps.c (_initialize_interpreter): Likewise.
2479         * language.c (_initialize_language): Likewise.
2480         * linux-fork.c (_initialize_linux_fork): Likewise.
2481         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2482         * maint.c (_initialize_maint_cmds): Likewise.
2483         * memattr.c (_initialize_mem): Likewise.
2484         * printcmd.c (_initialize_printcmd): Likewise.
2485         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2486         _RegEx): Likewise.
2487         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2488         * record-btrace.c (_initialize_record_btrace): Likewise.
2489         * record-full.c (_initialize_record_full): Likewise.
2490         * record.c (_initialize_record): Likewise.
2491         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2492         * regcache.c (_initialize_regcache): Likewise.
2493         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2494         _initialize_remote): Likewise.
2495         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2496         * serial.c (_initialize_serial): Likewise.
2497         * skip.c (_initialize_step_skip): Likewise.
2498         * source.c (_initialize_source): Likewise.
2499         * stack.c (_initialize_stack): Likewise.
2500         * symfile.c (_initialize_symfile): Likewise.
2501         * symtab.c (_initialize_symtab): Likewise.
2502         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2503         * top.c (init_main): Likewise.
2504         * tracefile-tfile.c (tfile_target_info): Likewise.
2505         * tracepoint.c (_initialize_tracepoint): Likewise.
2506         * tui/tui-win.c (_initialize_tui_win): Likewise.
2507         * utils.c (add_internal_problem_command): Likewise.
2508         * valprint.c (value_print_option_defs): Likewise.
2509
2510 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2511
2512         PR build/24886
2513         * configure.ac: Drop enable-libmcheck support.
2514         * configure, config.in: Rebuild.
2515         * libmcheck.m4: Remove.
2516         * acinclude.m4: Don't include it.
2517         * Makefile.in: Don't distribute it.
2518         * top.c (print_gdb_configuration): Don't mention it.
2519
2520 2019-08-06  Tom Tromey  <tom@tromey.com>
2521
2522         * utils.c (set_output_style): Sometimes pass stream to
2523         emit_style_escape.
2524         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2525         * record-btrace.c (btrace_insn_history): Update.
2526         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2527         method.
2528         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2529         Update initializers.
2530         <m_uiout>: New field.
2531         <m_di>: Move lower.
2532         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2533         Remove "uiout" parameter.
2534         (dump_insns): Update.
2535         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2536         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2537
2538 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2539
2540         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2541         (error_in_psymtab_expansion): Likewise.
2542         (lookup_symbol_via_quick_fns): Likewise.
2543         (basic_lookup_transparent_type_quick): Likewise.
2544         (basic_lookup_transparent_type_1): Likewise.
2545
2546 2019-08-06  Tom Tromey  <tromey@adacore.com>
2547
2548         * source.c (last_source_error): Now bool.
2549         (print_source_lines_base): Make "noprint" bool.  Only open
2550         source file when last_source_visited changes.
2551
2552 2019-08-06  Tom Tromey  <tromey@adacore.com>
2553
2554         * annotate.c (annotate_source_line): Use g_source_cache.
2555         * source-cache.c (source_cache::get_plain_source_lines): Change
2556         parameters.  Populate m_offset_cache.
2557         (source_cache::ensure): New method.
2558         (source_cache::get_line_charpos): New method.
2559         (extract_lines): Move lower.  Change parameters.
2560         (source_cache::get_source_lines): Move lower.
2561         * source-cache.h (class source_cache): Update comment.
2562         <get_line_charpos>: New method.
2563         <get_source_lines>: Update comment.
2564         <clear>: Clear m_offset_cache.
2565         <get_plain_source_lines>: Change parameters.
2566         <ensure>: New method
2567         <m_offset_cache>: New member.
2568         * source.c (forget_cached_source_info_for_objfile): Update.
2569         (info_source_command): Use g_source_cache.
2570         (find_source_lines, open_source_file_with_line_charpos): Remove.
2571         (print_source_lines_base, search_command_helper): Use g_source_cache.
2572         * source.h (open_source_file_with_line_charpos): Don't declare.
2573         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2574         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2575         Use g_source_cache.
2576
2577 2019-08-06  Tom Tromey  <tromey@adacore.com>
2578
2579         * source-cache.c (source_cache::get_plain_source_lines):
2580         Remove "first_line" and "last_line" parameters.
2581         (source_cache::get_source_lines): Cache plain text.
2582         * source-cache.h (class source_cache)
2583         <get_plain_source_lines>: Update.
2584
2585 2019-08-06  Tom Tromey  <tromey@adacore.com>
2586
2587         * source-cache.c (extract_lines): No longer a method.
2588         Changed type of parameter.  Include final newline.
2589         (selftests::extract_lines_test): New function.
2590         (_initialize_source_cache): Likewise.
2591         * source-cache.h (class source_cache)
2592         <extract_lines>: Don't declare.
2593
2594 2019-08-06  Tom Tromey  <tromey@adacore.com>
2595
2596         * breakpoint.c (init_breakpoint_sal): Update.
2597         (breakpoint): Update.
2598         * breakpoint.h (struct breakpoint) <filter>: Now a
2599         unique_xmalloc_ptr.
2600
2601 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2602
2603         * NEWS: Mention dictionary access on blocks.
2604         * python/py-block.c (blpy_getitem): New function.
2605         (block_object_as_mapping): New struct.
2606         (block_object_type): Use new struct for tp_as_mapping field.
2607
2608 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2609
2610         * objfiles.h (objfile): Add a comment describing partial symbols.
2611
2612 2019-08-05  Tom Tromey  <tromey@adacore.com>
2613
2614         * compile/compile.c (_initialize_compile): Use _(), not N_().
2615         * thread.c (_initialize_thread): Use _(), not N_().
2616         * stack.c (_initialize_stack): Use _(), not N_().
2617         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2618
2619 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2620
2621         * dwarf2read.c (struct dw2_symtab_iterator):
2622         <want_specific_block>: Remove.
2623         <block_index>: Change type to gdb::optional.
2624         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2625         change type of BLOCK_INDEX parameter to gdb::optional.
2626         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2627         (dw2_lookup_symbol): Don't pass argument for
2628         WANT_SPECIFIC_BLOCK.
2629         (dw2_expand_symtabs_for_function): Don't pass argument for
2630         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2631         (class dw2_debug_names_iterator)
2632         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2633         parameter, change BLOCK_INDEX type to gdb::optional.
2634         <m_want_specific_block>: Remove.
2635         <m_block_index>: Change type to gdb::optional.
2636         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2637         gdb::optional.  Re-write in function of gdb::optional.
2638         (dw2_debug_names_lookup_symbol): Don't pass argument for
2639         WANT_SPECIFIC_BLOCK.
2640         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2641         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2642         BLOCK_INDEX.
2643
2644 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2645
2646         * NEWS: Mention changes to "info sources" command.
2647
2648 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2649
2650         * symtab.c (filename_partial_match_opts): New struct type.
2651         (struct output_source_filename_data): New members
2652         regexp, c_regexp, partial_match.
2653         (output_source_filename): Use new members to decide to print file.
2654         (info_sources_option_defs): New variable.
2655         (make_info_sources_options_def_group, print_info_sources_header,
2656         info_sources_command_completer):
2657         New functions.
2658         (info_sources_command): Read new optional arguments.
2659         (_initialize_symtab): Update info sources help.
2660
2661 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2662
2663         * ada-lang.c (exception_support_info_v0): Renamed from...
2664         (default_exception_support_info): ... this.  Create new
2665         definition for v1.
2666         (ada_has_this_exception_support): Look up catch_handlers_sym.
2667         (ada_exception_support_info_sniffer): Try v0 after default.
2668
2669 2019-08-01  Tom Tromey  <tromey@adacore.com>
2670
2671         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2672         gdbarch.h.
2673
2674 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2675
2676         * s12z-tdep.c: Fix include path for s12z-opc.h.
2677
2678 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2679
2680         * NEWS: Require GNU make 3.82.
2681
2682 2019-07-16  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2685         declare.
2686
2687 2019-07-30  Tom Tromey  <tromey@adacore.com>
2688
2689         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2690
2691 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2692
2693         * printcmd.c (print_address_symbolic): Print negative offsets.
2694         (build_address_symbolic): Force signed arithmetic when computing
2695         offset.
2696
2697 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2698
2699         PR/24474: Add a function to lookup static variables.
2700         * NEWS: Mention this new function.
2701         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2702         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2703         * python/python.c (python_GdbMethods): Add new function.
2704
2705 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2706
2707         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2708         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2709         (objfpy_lookup_static_symbol): New function.
2710         (objfile_object_methods): Add new functions.
2711
2712 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2713
2714         * NEWS: Mention 'set|show print frame-info'.  Mention new
2715         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2716         backtrace argument.  Mention that python frame filtering code
2717         is now consistent with what 'backtrace' command prints.
2718
2719 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2720
2721         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2722         comments.
2723         (print_frame_info_auto, print_frame_info_source_line,
2724         print_frame_info_location, print_frame_info_source_and_location,
2725         print_frame_info_location_and_address, print_frame_info_short_location):
2726         New declarations.
2727         (struct frame_print_options): New member print_frame_info.
2728         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2729         * stack.h (get_user_print_what_frame_info): New declaration.
2730         (frame_show_address): New declaration.
2731         * stack.c (print_frame_arguments_choices): New value 'presence'.
2732         (print_frame_info_auto, print_frame_info_source_line,
2733         print_frame_info_location, print_frame_info_source_and_location,
2734         print_frame_info_location_and_address, print_frame_info_short_location,
2735         print_frame_info_choices, print_frame_info_print_what): New definitions.
2736         (print_frame_args): Only print dots for args if print frame-arguments
2737         is 'presence'.
2738         (frame_print_option_defs): New element for "frame-info".
2739         (get_user_print_what_frame_info): New function.
2740         (frame_show_address): Make non static.  Move comment to stack.h.
2741         (print_frame_info_to_print_what): New function.
2742         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2743         to decide what to print.
2744         (backtrace_command_1): Handle the new print_frame_arguments_presence
2745         value.
2746         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2747         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2748         (py_print_frame): In non-mi mode, use LOCATION as default for
2749         print_what, similarly to frame information printed directly by
2750         backtrace command. Handle frame-info user option in non MI mode.
2751
2752 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2753
2754         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2755         Add case for debugging 32-bit target on 64-bit host.  Revise
2756         comment.
2757
2758 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2759
2760         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2761         instead of find_function_entry_range_from_pc.
2762
2763 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2764
2765         * stack.c (find_frame_funname): Remove code which preferred
2766         minsym over symtab sym in "certain pathological cases".
2767
2768         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2769         parameter.  Change type of "do_demangle" to bool.
2770         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2771         Pass suitable "prefer_sym_over_minsym" flag to
2772         build_address_symbolic().  Don't output "+" for negative offsets.
2773         * printcmd.c (print_address_symbolic): Update invocation of
2774         build_address_symbolic to include a "prefer_sym_over_minsym"
2775         flag.
2776         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2777         Restrict cases in which use of minimal symbol is preferred to that
2778         of a found symbol.  Update comments.
2779
2780         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2781         for entry pc when entry pc is out of range for that FDE.
2782
2783 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2784
2785         PR gdb/24839:
2786         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2787         type.
2788
2789 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2790
2791         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2792         this function's Python signature.
2793
2794
2795 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2798         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2799         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2800         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2801         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2802
2803
2804 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2805
2806         * h8300-tdep.c (h8300_register_name_common): New.
2807         h8300_register_name): Use h8300_register_name_common.
2808         (h8300s_register_name): Likewise.
2809         (h8300sx_register_name): Likewise.
2810         (h8300h_register_nam): New.
2811         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2812
2813
2814 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2815
2816         * arm-tdep.c (arm_skip_cmse_entry): New function.
2817         (arm_is_sgstubs_section): New function.
2818         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2819
2820 2019-07-22  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2823         Don't self-assign.
2824
2825 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2826
2827         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2828         type_print.
2829
2830 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2833         so that GDB doesn't match any msymbols when searching in the
2834         TYPES_DOMAIN.
2835         (print_symbol_info): Print using typedef_print or type_print based
2836         on the type of the symbol.  Add updated FIXME comment moved from...
2837         (_initialize_symtab): ... move and update FIXME comment to above.
2838
2839 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * NEWS: Mention adding -q option to "info types".
2842         * symtab.c (struct info_types_options): New struct.
2843         (info_types_options_defs): New variable.
2844         (make_info_types_options_def_group): New function.
2845         (info_types_command): Use gdb::option framework to parse options.
2846         (info_types_command_completer): New function.
2847         (_initialize_symtab): Extend the help text on "info types" and
2848         register command completer.
2849
2850 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2851
2852         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2853         (lookup_symbol_in_objfile): Change int to block_enum and add a
2854         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2855
2856 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2857
2858         * MAINTAINERS (Write After Approval): Add self.
2859
2860 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2863         instruction to the dummy code region.
2864
2865 2019-07-19  Tom Tromey  <tromey@adacore.com>
2866
2867         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2868         (ARGSUSED, PARAMS, __func__): Remove rules.
2869
2870 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2871
2872         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2873         * features/arm/arm-with-iwmmxt.c: Remove.
2874         * features/arm/arm-with-iwmmxt.xml: Remove.
2875         * features/arm/arm-with-m-fpa-layout.c: Remove.
2876         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2877         * features/arm/arm-with-m-vfp-d16.c: Remove.
2878         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2879         * features/arm/arm-with-m.c: Remove.
2880         * features/arm/arm-with-m.xml: Remove.
2881         * features/arm/arm-with-neon.c: Remove.
2882         * features/arm/arm-with-neon.xml: Remove.
2883         * features/arm/arm-with-vfpv2.c: Remove.
2884         * features/arm/arm-with-vfpv2.xml: Remove.
2885         * features/arm/arm-with-vfpv3.c: Remove.
2886         * features/arm/arm-with-vfpv3.xml: Remove.
2887
2888 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2891
2892 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2893
2894         * arch/aarch32.c (aarch32_create_target_description): Create
2895         target descriptions using features.
2896         * arch/arm.c (arm_create_target_description)
2897         (arm_create_mprofile_target_description): Likewise.
2898         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2899
2900 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2901
2902         * Makefile.in: Add new files.
2903         * aarch32-tdep.c: New file.
2904         * aarch32-tdep.h: New file.
2905         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2906         Call aarch32_read_description.
2907         * arch/aarch32.c: New file.
2908         * arch/aarch32.h: New file.
2909         * arch/arm.c (arm_create_target_description)
2910         (arm_create_mprofile_target_description): New function.
2911         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2912         (arm_create_target_description)
2913         (arm_create_mprofile_target_description): New declaration.
2914         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2915         read_description functions.
2916         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2917         Likewise.
2918         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2919         * arm-tdep.c (tdesc_arm_list): New variable.
2920         (arm_register_g_packet_guesses): Call create description functions.
2921         (arm_read_description) (arm_read_mprofile_description): New
2922         function.
2923         * arm-tdep.h (arm_read_description)
2924         (arm_read_mprofile_description): Add declaration.
2925         * configure.tgt: Add new files.
2926
2927 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2928
2929         * top.c (new_ui_command): Open specified terminal just once.
2930
2931 2019-07-18  Tom Tromey  <tromey@adacore.com>
2932
2933         * symtab.c (main_name): Constify return type.
2934         * symfile.c (set_initial_language): Update.
2935         * symtab.h (main_name): Constify return type.
2936
2937 2019-07-17  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.c (tui_update_source_window)
2940         (tui_update_source_window_as_is)
2941         (tui_update_source_windows_with_line): Remove return.
2942         * tui/tui-disasm.c (tui_show_disassem)
2943         (tui_show_disassem_and_update_source): Remove return.
2944         * tui/tui.c (tui_reset): Remove return.
2945         * tui/tui-wingeneral.c
2946         (tui_check_and_display_highlight_if_needed): Remove return.
2947
2948 2019-07-17  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2951
2952 2019-07-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-winsource.h (struct tui_exec_info_window)
2955         (struct tui_source_window_base): Move from tui-data.h.
2956         * tui/tui-winsource.c: Move many method definitions from
2957         elsewhere.  Remove "structuring" comments.
2958         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2959         (tui_source_window_base::refresh_window): Move to
2960         tui-winsource.c.
2961         * tui/tui-win.c (tui_source_window_base::refresh_all)
2962         (tui_source_window_base::update_tab_width)
2963         (tui_source_window_base::set_new_height)
2964         (tui_source_window_base::do_make_visible_with_new_height): Move to
2965         tui-winsource.c.
2966         * tui/tui-source.h: Update.
2967         * tui/tui-source.c (tui_source_window_base::reset): Move to
2968         tui-winsource.c.
2969         * tui/tui-disasm.h: Update.
2970         * tui/tui-data.h (struct tui_exec_info_window): Move to
2971         tui-winsource.h.
2972         (struct tui_source_window_base): Likewise.
2973         * tui/tui-data.c (tui_source_window_base::clear_detail)
2974         (tui_source_window_base, ~tui_source_window_base): Move to
2975         tui-winsource.c.
2976
2977 2019-07-17  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-win.c (tui_resize_all)
2980         (tui_source_window_base::update_tab_width)
2981         (tui_adjust_win_heights): Update.
2982         (tui_win_info::make_invisible_and_set_new_height): Rename from
2983         make_invisible_and_set_new_height.
2984         * tui/tui-data.h (struct tui_win_info)
2985         <make_invisible_and_set_new_height>: New method.
2986
2987 2019-07-17  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui.c: Update.
2990         * tui/tui-source.h (struct tui_source_window): Move from
2991         tui-data.h.
2992         * tui/tui-layout.c: Update.
2993         * tui/tui-disasm.c: Update.
2994         * tui/tui-data.h (struct tui_source_window): Move to
2995         tui-source.h.
2996
2997 2019-07-17  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3000         tui-data.h.
3001         * tui/tui-data.h (struct tui_disasm_window): Move to
3002         tui-disasm.h.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-regs.h (struct tui_data_item_window): Move from
3007         tui-data.h.
3008         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3009         * tui/tui-data.h (struct tui_data_item_window): Move to
3010         tui-regs.h.
3011         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3012
3013 2019-07-17  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui.c: Update.
3016         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3017         (tui_cmd_window::max_height): Move to tui-command.c.
3018         * tui/tui-layout.c: Update.
3019         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3020         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3021         tui-command.c.
3022         * tui/tui-command.h (struct tui_cmd_window): Move from
3023         tui-data.h.
3024         * tui/tui-command.c: Remove "structuring" comments.
3025         (tui_cmd_window::clear_detail)
3026         (tui_cmd_window::do_make_visible_with_new_height)
3027         (tui_cmd_window::max_height): Move from elsewhere.
3028
3029 2019-07-17  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3032         Now static.
3033         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3034         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3035
3036 2019-07-17  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui.c: Update.
3039         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3040         tui-regs.c.
3041         * tui/tui-windata.h: Remove file.
3042         * tui/tui-windata.c: Remove file.
3043         * tui/tui-win.c (tui_data_window::set_new_height)
3044         (tui_data_window::do_make_visible_with_new_height): Move to
3045         tui-regs.c.
3046         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3047         * tui/tui-regs.c: Remove "structuring" comments.
3048         (tui_data_window::first_data_item_displayed)
3049         (tui_data_window::delete_data_content_windows)
3050         (tui_data_window::erase_data_content)
3051         (tui_data_window::display_all_data)
3052         (tui_data_window::refresh_all)
3053         (tui_data_window::do_scroll_vertical)
3054         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3055         (tui_data_window::do_make_visible_with_new_height)
3056         (tui_data_window::refresh_window): Move from elsewhere.
3057         (_initialize_tui_regs): Move to end of file.
3058         * tui/tui-layout.c: Update.
3059         * tui/tui-hooks.c: Update.
3060         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3061         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3062         tui-regs.c.
3063         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3064
3065 2019-07-17  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3068         seen.
3069
3070 2019-07-17  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-win.c (tui_source_window_base::set_new_height)
3073         (tui_source_window_base::do_make_visible_with_new_height): Use
3074         m_has_locator field directly.
3075         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3076         method.
3077         (struct tui_source_window_base) <has_locator>: Likewise.
3078
3079 2019-07-17  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3082         Don't declare.
3083         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3084         Remove.
3085         * tui/tui-win.c (tui_source_window_base::set_new_height)
3086         (tui_source_window_base::set_new_height)
3087         (make_invisible_and_set_new_height)
3088         (tui_source_window_base::do_make_visible_with_new_height)
3089         (tui_source_window_base::do_make_visible_with_new_height):
3090         Update.
3091         * tui/tui-layout.c (show_source_disasm_command, show_data)
3092         (show_source_or_disasm_and_command): Update.
3093         * tui/tui-layout.c (show_layout): Update.
3094
3095 2019-07-17  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-layout.c (make_data_window): Remove.
3098         (show_data): Unify creation and re-initialization cases.
3099
3100 2019-07-17  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-layout.c (make_source_window, make_disasm_window):
3103         Remove.
3104         (show_data): Unify creation and re-initialization cases.
3105
3106 2019-07-17  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-layout.c (make_command_window): Remove.
3109         (show_source_disasm_command, show_source_or_disasm_and_command):
3110         Unify creation and re-initialization cases.
3111
3112 2019-07-17  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3115         creation and re-initialization cases.
3116
3117 2019-07-17  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-regs.c (tui_get_register): Return void.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3124         Simplify.
3125
3126 2019-07-17  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3129         resetting.
3130
3131 2019-07-17  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3134         * tui/tui-regs.c (tui_reg_layout): New function.
3135         (tui_show_registers, tui_reg_command): Use it.
3136         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3137         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3138         parameters.
3139         (tui_layout_command): Remove.
3140
3141 2019-07-17  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-layout.h (tui/tui-layout): Return void.
3144         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3145
3146 2019-07-17  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-layout.c (show_source_disasm_command, show_data):
3149         Update.
3150         (reset_locator): Remove.
3151         (show_source_or_disasm_and_command): Update.
3152
3153 2019-07-17  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-source.c (tui_source_window_base::reset): Remove
3156         win_type parameter.
3157         * tui/tui-layout.c (make_command_window, make_source_window)
3158         (make_disasm_window, make_data_window)
3159         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3160         (reset_locator, show_source_or_disasm_and_command): Update.
3161         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3162         win_type parameter.
3163         (struct tui_source_window_base) <reset>: Likewise.
3164
3165 2019-07-17  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-layout.c (show_source_disasm_command): Use
3168         reset_locator.
3169         (reset_locator): New function.
3170         (init_and_make_win): Remove.
3171         (show_source_or_disasm_and_command): Use reset_locator.
3172
3173 2019-07-17  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3176         condition.
3177         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3178         Remove condition.
3179         * tui/tui-source.c (tui_source_window_base::reset): New method.
3180         * tui/tui-layout.c (make_command_window): Don't call
3181         init_and_make_win.
3182         (make_source_window, make_disasm_window): Don't call
3183         make_source_or_disasm_window.
3184         (make_data_window): Don't call init_and_make_win.  Change calling
3185         convention.
3186         (show_source_disasm_command, show_data): Simplify.
3187         (make_source_or_disasm_window): Remove.
3188         (show_source_or_disasm_and_command): Simplify.
3189         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3190         (struct tui_source_window_base) <reset>: Likewise.
3191         <execution_info>: Remove initializer.
3192         * tui/tui-data.c (tui_source_window_base): Initialize
3193         execution_info.
3194
3195 2019-07-17  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3198         variable.
3199
3200 2019-07-17  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui.c (tui_rl_other_window): Update.
3203         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3204         superclass method first.  Always iterate over regs_content.
3205         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3206         method.
3207         * tui/tui-win.c (tui_set_focus_command): Update.
3208
3209 2019-07-17  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-win.c (tui_set_focus_command): Rename from
3212         tui_set_focus.  Call tui_enable.
3213         (tui_set_focus_command): Remove.
3214
3215 2019-07-17  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3218         refresh_window.
3219         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3220         touchwin.
3221         (tui_data_window::refresh_window): Call refresh_window on data
3222         items.  Always call superclass refresh_window.
3223         (tui_win_info::refresh): Remove.
3224         (tui_source_window_base::refresh_window): Update.
3225         (tui_refresh_all): Update.
3226         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3227         refresh_window.
3228         (show_source_or_disasm_and_command): Likewise.
3229         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3230         (struct tui_source_window_base) <refresh>: Likewise.
3231
3232 2019-07-17  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-winsource.c (tui_clear_source_content)
3235         (tui_show_source_content): Update.
3236         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3237         whether content is empty.
3238         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3239         Remove.
3240
3241 2019-07-17  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3244         window's contents.
3245         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3246         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3247
3248 2019-07-17  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3251         (struct tui_data_item_window): Update.
3252
3253 2019-07-17  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3256         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3257         defines.
3258
3259 2019-07-17  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-winsource.h (tui_erase_source_content)
3262         (tui_clear_source_content): Remove "display_prompt" parameter.
3263         * tui/tui-winsource.c (tui_update_source_window_as_is)
3264         (tui_update_source_windows_with_addr): Update.
3265         (tui_clear_source_content): Remove "display_prompt" parameter.
3266         (tui_erase_source_content): Likewise.  Simplify.
3267         (tui_show_source_content): Update.
3268         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3269         * tui/tui-stack.c (tui_show_frame_info): Update.
3270         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3271         Remove defines.
3272
3273 2019-07-17  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3276         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3277         parameter.
3278         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3279         parameter.
3280
3281 2019-07-17  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-winsource.c (tui_clear_source_content)
3284         (tui_show_source_content, tui_show_exec_info_content)
3285         (tui_clear_exec_info_content): Update.
3286         * tui/tui-stack.c (tui_show_locator_content): Update.
3287         (tui_show_frame_info): Update.
3288         * tui/tui-source.h (tui_source_window): Don't declare.
3289         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3290         from tui_source_is_displayed.
3291         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3292         Remove field.
3293         (struct tui_source_window_base) <content_in_use>: New field.  Now
3294         bool.
3295         (struct tui_source_window) <showing_source_p>: New method.
3296         (TUI_SRC_WIN): Change cast.
3297         * tui/tui-data.c (tui_initialize_static_data): Update.
3298
3299 2019-07-17  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3302         location_matches_p.
3303         * tui/tui-source.c (tui_source_window::location_matches_p): New
3304         method.
3305         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3306         method.
3307         * tui/tui-data.h (struct tui_source_window_base)
3308         <location_matches_p>: New method.
3309         (struct tui_source_window, struct tui_disasm_window)
3310         <location_matches_p>: Likewise.
3311
3312 2019-07-17  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-win.c (tui_set_win_height_command): Rename from
3315         tui_set_win_height.
3316         (tui_set_win_height_command): Remove.
3317
3318 2019-07-17  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-source.c (tui_source_window): New constructor.  Add
3321         observer.
3322         (~tui_source_window): New destructor.
3323         (tui_source_window::style_changed): New method.
3324         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3325         (tui_attach_detach_observers): Update.
3326         * tui/tui-data.h (struct tui_source_window): Make constructor not
3327         inline.  Add destructor.
3328         (struct tui_source_window) <style_changed>: New method.
3329         <m_observable>: New member.
3330
3331 2019-07-17  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3334         * tui/tui-win.c (tui_resize_all): Fix typo.
3335
3336 2019-07-17  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3339         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3340         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3341         * tui/tui-win.c (window_name_completer): Use foreach.
3342         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3343         (update_tab_width): Likewise.
3344         * tui/tui-layout.c (show_layout): Update.
3345         * tui/tui-data.h (class tui_window_iterator): New.
3346         (struct all_tui_windows): New.
3347         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3348
3349 2019-07-17  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3352         parameter.  Don't reference globals.
3353         (tui_reg_command): Update.
3354
3355 2019-07-17  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-regs.c (tui_show_registers): Simplify.
3358
3359 2019-07-17  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-regs.c (tui_show_registers): Update.
3362         (tui_show_register_group): Add win_info parameter.
3363
3364 2019-07-17  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3367         Rename from tui_display_reg_element_at_line.
3368         (tui_data_window::display_registers_from_line): Update.
3369         * tui/tui-data.h (struct tui_data_window)
3370         <display_reg_element_at_line>: New method.
3371
3372 2019-07-17  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-regs.h (tui_display_registers_from)
3375         (tui_display_registers_from_line): Don't declare.
3376         * tui/tui-windata.c (tui_data_window::display_all_data)
3377         (tui_data_window::refresh_all)
3378         (tui_data_window::do_scroll_vertical): Update.
3379         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3380         from tui_display_registers_from.
3381         (tui_display_reg_element_at_line): Update.
3382         (tui_data_window::display_registers_from_line): Rename from
3383         tui_display_registers_from_line.
3384         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3385         display_registers_from_line>: New methods.
3386
3387 2019-07-17  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3390         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3391         from tui_erase_data_content.
3392         (tui_data_window::display_all_data)
3393         (tui_data_window::refresh_all)
3394         (tui_data_window::do_scroll_vertical): Update.
3395         * tui/tui-regs.c (tui_show_registers): Update.
3396         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3397         New method.
3398
3399 2019-07-17  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3402         declare.
3403         * tui/tui-windata.c
3404         (tui_data_window::delete_data_content_windows): Rename from
3405         tui_delete_data_content_windows.
3406         (tui_data_window::display_all_data)
3407         (tui_data_window::do_scroll_vertical): Update.
3408         * tui/tui-data.h (struct tui_data_window)
3409         <delete_data_content_windows>: New method.
3410
3411 2019-07-17  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3414         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3415
3416 2019-07-17  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3419         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3420         from tui_display_all_data.
3421         * tui/tui-win.c
3422         (tui_data_window::do_make_visible_with_new_height): Update.
3423         * tui/tui-regs.c (tui_show_registers): Update.
3424         * tui/tui-layout.c (tui_set_layout): Update.
3425         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3426         method.
3427
3428 2019-07-17  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3431         * tui/tui-windata.c (tui_display_data_from): Remove.
3432         (tui_data_window::refresh_all): Update.
3433
3434 2019-07-17  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3437         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3438         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3439         tui_display_registers_from_line.
3440         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3441         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3442         "force_display" parameter.
3443
3444 2019-07-17  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3447         declare.
3448         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3449         Rename from tui_first_reg_element_no_inline.
3450         (tui_display_reg_element_at_line)
3451         (tui_display_registers_from_line): Update.
3452         * tui/tui-data.h (struct tui_data_window)
3453         <first_reg_element_no_inline>: New method.
3454
3455 2019-07-17  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-windata.c (tui_display_data_from)
3458         (tui_data_window::do_scroll_vertical): Update.
3459         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3460         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3461         Rename from tui_line_from_reg_element_no.
3462         (tui_display_registers_from_line): Update.
3463         * tui/tui-data.h (struct tui_data_window)
3464         <line_from_reg_element_no>: New method.
3465
3466 2019-07-17  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3469         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3470         tui_last_regs_line_no.
3471         (tui_display_reg_element_at_line)
3472         (tui_display_registers_from_line): Update.
3473         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3474         method.
3475
3476 2019-07-17  Tom Tromey  <tom@tromey.com>
3477
3478         PR tui/24722:
3479         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3480         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3481         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3482         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3483         (tui_update_breakpoint_info): Likewise.
3484         * tui/tui-hooks.c (tui_event_create_breakpoint)
3485         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3486         Update.
3487
3488 2019-07-17  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3491
3492 2019-07-17  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-winsource.c (tui_update_source_window_as_is)
3495         (tui_update_source_windows_with_addr): Update.
3496         * tui/tui-source.h (tui_set_source_content)
3497         (tui_show_symtab_source): Add "win_info" parameter.
3498         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3499         parameter.
3500         (tui_show_symtab_source): Likewise.
3501
3502 2019-07-17  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-wingeneral.c
3505         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3506
3507 2019-07-17  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3510         (struct tui_cmd_window) <can_scroll>: New method.
3511         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3512         method.
3513
3514 2019-07-17  Tom Tromey  <tromey@adacore.com>
3515
3516         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3517         do_field_signed>: Rename.  Change type of "value".
3518         * ui-out.c (ui_out::field_signed): Rename from field_int.
3519         Change type of "value".
3520         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3521         type of "value".
3522         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3523         do_field_int.  Change type of "value".
3524         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3525         do_field_int.  Change type of "value".
3526         * tracepoint.c (trace_status_mi, tfind_1)
3527         (print_one_static_tracepoint_marker): Update.
3528         * thread.c (print_thread_info_1, print_selected_thread_frame):
3529         Update.
3530         * stack.c (print_frame, print_frame_info): Update.
3531         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3532         Update.
3533         * source.c (print_source_lines_base): Update.
3534         * skip.c (info_skip_command): Update.
3535         * record-btrace.c (btrace_ui_out_decode_error)
3536         (btrace_call_history_src_line): Update.
3537         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3538         Update.
3539         * progspace.c (print_program_space): Update.
3540         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3541         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3542         do_field_int.  Change type of "value".
3543         * mi/mi-out.c (mi_ui_out::do_table_begin)
3544         (mi_ui_out::do_table_header): Update.
3545         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3546         type of "value".
3547         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3548         (mi_cmd_data_list_changed_registers, output_register)
3549         (mi_cmd_data_read_memory, mi_load_progress)
3550         (mi_cmd_trace_frame_collected): Update.
3551         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3552         Update.
3553         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3554         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3555         (mi_cmd_var_list_children, varobj_update_one): Update.
3556         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3557         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3559         * inferior.c (print_inferior): Update.
3560         * gdb_bfd.c (print_one_bfd): Update.
3561         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3562         Update.
3563         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3564         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3565         do_field_int.  Change type of "value".
3566         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3567         do_field_int.  Change type of "value".
3568         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3569         (print_one_breakpoint_location, print_it_catch_fork)
3570         (print_one_catch_fork, print_it_catch_vfork)
3571         (print_one_catch_vfork, print_it_catch_solib)
3572         (print_it_catch_exec, print_it_ranged_breakpoint)
3573         (print_mention_watchpoint, print_mention_masked_watchpoint)
3574         (bkpt_print_it, update_static_tracepoint): Update.
3575         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3576         * break-catch-syscall.c (print_it_catch_syscall): Update.
3577         * ada-tasks.c (print_ada_task_info): Update.
3578         * ada-lang.c (print_it_exception, print_mention_exception):
3579         Update.
3580
3581 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         PR breakpoints/24541
3584         * gdbarch.c: Regenerate.
3585         * gdbarch.h: Regenerate.
3586         * gdbarch.sh: Adjust return type and parameter types for
3587         'stap_adjust_register'.
3588         (i386_stap_adjust_register): Adjust signature and return new
3589         register name.
3590         * stap-probe.c (stap_parse_register_operand): Adjust use of
3591         'gdbarch_stap_adjust_register'.
3592
3593 2019-07-17  Tom Tromey  <tromey@adacore.com>
3594
3595         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3596         declare VEC.
3597         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3598         std::vector.
3599         (struct s390_process_info): Add initializers.
3600         (s390_add_process): Use new.
3601         (s390_linux_nat_target::low_forget_process): Use delete.
3602         (s390_linux_nat_target::low_new_fork)
3603         (s390_linux_nat_target::stopped_by_watchpoint)
3604         (s390_linux_nat_target::low_prepare_to_resume)
3605         (s390_linux_nat_target::insert_watchpoint)
3606         (s390_linux_nat_target::insert_hw_breakpoint)
3607         (s390_linux_nat_target::remove_watchpoint)
3608         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3609
3610 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3611
3612         * aarch64-fbsd-nat.c: Include regcache.h.
3613         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3614         argument.
3615         (aarch64_fbsd_nat_target::fetch_registers)
3616         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3617         variable.
3618         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3619
3620 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3621
3622         * fbsd-nat.c: Include gdbarch.h.
3623
3624 2019-07-15  Tom Tromey  <tromey@adacore.com>
3625
3626         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3627
3628 2019-07-15  Tom Tromey  <tromey@adacore.com>
3629
3630         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3631         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3632         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3633         * cli-out.c (cli_ui_out::do_field_int): New method.
3634         * ui-out.c (ui_out::field_unsigned): New method.
3635         * symfile.c (generic_load): Use field_unsigned.
3636         (print_transfer_performance): Likewise.
3637         * record-btrace.c (ui_out_field_uint): Remove.
3638         (btrace_call_history_insn_range, btrace_call_history): Use
3639         field_unsigned.
3640         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3641         field_unsigned.
3642         * ui-out.h (class ui_out) <field_unsigned>: New method.
3643         <do_field_unsigned>: Likewise.
3644
3645 2019-07-15  Tom Tromey  <tromey@adacore.com>
3646
3647         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3648         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3649         * target.c (flash_erase_command): Use field_string.
3650         * infrun.c (print_signal_received_reason): Use field_string.
3651         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3652         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3653         field_string.
3654         * ada-tasks.c (print_ada_task_info): Use field_string.
3655
3656 2019-07-15  Tom Tromey  <tromey@adacore.com>
3657
3658         * target.c (flash_erase_command): Use field_core_addr.
3659         * symfile.c (generic_load): Use field_core_addr.
3660         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3661         Use field_core_addr.
3662         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3663         field_core_addr.
3664
3665 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3668         value if its desired type is smaller than a CORE_ADDR and signed.
3669
3670 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3673         of changes to field names, and use new is_reference field to
3674         decide if a property is a reference or not.
3675         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3676         field.
3677         (struct dwarf2_property_baton): Update header comment, rename
3678         'referenced_type' to 'property_type' and update comments.
3679         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3680         default property type, store in property baton, update to take
3681         accound of renamed field.
3682         (read_func_scope): Update call to attr_to_dynamic_prop.
3683         (read_array_type): Likewise.
3684         (dwarf2_per_cu_addr_sized_int_type): New function.
3685         (read_subrange_index_type): Move type finding code to
3686         dwarf2_per_cu_addr_sized_int_type.
3687         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3688         (dwarf2_per_cu_addr_type): New function.
3689         (set_die_type): Update calls to attr_to_dynamic_prop.
3690
3691 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * dwarf2read.c (read_subrange_index_type): New function.
3694         (read_subrange_type): Move code into new function and call it.
3695         * gdbtypes.c (create_range_type): Add some asserts.
3696
3697 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3700         update return statements.
3701         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3702         declaration, and update comment to match.
3703         * gdbtypes.c (resolve_dynamic_array): Update call to
3704         dwarf2_evaluate_property to match new return type.
3705
3706 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * valarith.c (value_subscripted_rvalue): Change lowerbound
3709         parameter type from int to LONGEST.
3710         * value.h (value_subscripted_rvalue): Likewise in declaration.
3711
3712 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * cli/cli-utils.c (info_print_command_completer): New function.
3715         * cli/cli-utils.h: Add 'completer.h' include, and forward
3716         declaration for 'struct cmd_list_element'.
3717         (info_print_command_completer): Declare.
3718         * stack.c (_initialize_stack): Add completer for 'info locals' and
3719         'info args'.
3720         * symtab.c (_initialize_symtab): Add completer for 'info
3721         variables' and 'info functions'.
3722         * NEWS: Mention completion for additional info commands.
3723
3724 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * cli/cli-utils.c (extract_info_print_args): Delete.
3727         (extract_arg_maybe_quoted): Delete.
3728         (info_print_options_defs): New variable.
3729         (make_info_print_options_def_group): New function.
3730         (extract_info_print_options): Define new function.
3731         * cli/cli-utils.h (extract_info_print_args): Delete.
3732         (struct info_print_options): New structure.
3733         (extract_info_print_options): Declare new function.
3734         * stack.c (info_locals_command): Update to use new
3735         extract_info_print_options, also add a header comment.
3736         (info_args_command): Likewise.
3737         * symtab.c (info_variables_command): Likewise.
3738         (info_functions_command): Likewise.
3739
3740 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3743         to extract string arguments.
3744         * common/common-utils.c (extract_string_maybe_quoted): New function.
3745         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3746
3747 2019-07-11  Tom Tromey  <tromey@adacore.com>
3748
3749         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3750         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3751         * top.h (gdbinit): Don't declare.
3752         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3753         into...
3754         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3755         * top.c (gdb_init): Don't call init_cli_cmds.
3756         (gdbinit): Remove.
3757         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3758
3759 2019-07-11  Tom Tromey  <tromey@adacore.com>
3760
3761         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3762         after it has been moved.
3763
3764 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3765
3766         * valops.c (value_must_coerce_to_target): Change return type to
3767         bool.
3768         * value.h (value_must_coerce_to_target): Likewise.
3769
3770 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3771
3772         * breakpoint.c (is_hardware_watchpoint): Remove
3773         forward-declaration.
3774         (is_masked_watchpoint): Change return type to bool.
3775         (is_tracepoint): Likewise.
3776         (is_breakpoint): Likewise.
3777         (is_hardware_watchpoint): Likewise.
3778         (is_watchpoint): Likewise.
3779         (is_no_memory_software_watchpoint): Likewise.
3780         (is_catchpoint): Likewise.
3781         (breakpoint_1): Make FILTER parameter's return type bool.
3782         is_masked_watchpoint): Change return type to bool.
3783         (save_breakpoints): Make FILTER parameter's return type bool.
3784         * breakpoint.h (is_breakpoint): Change return type to bool.
3785         (is_watchpoint): Likewise.
3786         (is_catchpoint): Likewise.
3787         (is_tracepoint): Likewise.
3788
3789 2019-07-10  Tom Tromey  <tom@tromey.com>
3790
3791         * defs.h: Don't include gdbarch.h.
3792         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3793         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3794         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3795         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3796         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3797         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3798         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3799         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3800         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3801         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3802         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3803         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3804         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3805         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3806         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3807         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3808         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3809         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3810         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3811         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3812         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3813         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3814         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3815         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3816         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3817         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3818         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3819
3820 2019-07-10  Tom Tromey  <tromey@adacore.com>
3821
3822         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3823         * breakpoint.c (init_ada_exception_breakpoint): Register as
3824         bp_catchpoint.
3825         (print_one_breakpoint_location, print_one_breakpoint): Use
3826         is_ada_exception_catchpoint.
3827         * ada-lang.c (class ada_catchpoint_location): Pass
3828         bp_loc_software_breakpoint to bp_location constructor.
3829         (is_ada_exception_catchpoint): New function.
3830
3831 2019-07-10  Tom Tromey  <tromey@adacore.com>
3832
3833         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3834         VEC.
3835         (struct arm_exidx_entry): New method operator<.
3836         (struct arm_exidx_data) <section_maps>: Change type.
3837         (arm_exidx_data_free): Remove.
3838         (arm_exidx_data_key): Change type.  Move lower.
3839         (arm_exidx_new_objfile): Update.
3840         (arm_compare_exidx_entries): Remove.
3841         (arm_find_exidx_entry, _initialize_arm_tdep)
3842
3843 2019-07-10  Tom Tromey  <tromey@adacore.com>
3844
3845         * solib-spu.c (ocl_program_data_key): Change type.
3846         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3847         Update.
3848
3849 2019-07-10  Tom Tromey  <tromey@adacore.com>
3850
3851         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3852         (struct solib_aix_inferior_data) <library_list>: Change type.
3853         (solib_aix_inferior_data_handle): Change type.
3854         (get_solib_aix_inferior_data): Update.
3855         (solib_aix_free_library_list): Remove.
3856         (library_list_start_library): Update.
3857         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3858         return type.
3859         (solib_aix_get_library_list)
3860         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3861         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3862
3863 2019-07-10  Tom Tromey  <tromey@adacore.com>
3864
3865         * solib-dsbt.c (struct dsbt_info): Add initializers.
3866         (solib_dsbt_pspace_data): Change type.
3867         (dsbt_pspace_data_cleanup): Remove.
3868         (get_dsbt_info, _initialize_dsbt_solib): Update.
3869
3870 2019-07-10  Tom Tromey  <tromey@adacore.com>
3871
3872         * spu-tdep.c (spu_overlay_data): Change type.
3873         (spu_get_overlay_table, spu_overlay_new_objfile)
3874         (_initialize_spu_tdep): Update.
3875
3876 2019-07-10  Tom Tromey  <tromey@adacore.com>
3877
3878         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3879         destructor.
3880         (dbx_objfile_data_key): Change type and declare later.
3881         (DBX_SYMFILE_INFO): Rewrite.
3882         * dbxread.c (dbx_objfile_data_key): Change type.
3883         (dbx_symfile_init): Update.
3884         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3885         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3886         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3887
3888 2019-07-10  Tom Tromey  <tromey@adacore.com>
3889
3890         * jit.c (jit_program_space_key): Change type.  Move lower.
3891         (get_jit_program_space_data): Update.
3892         (jit_program_space_data_cleanup): Remove.
3893         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3894         Update.
3895         (struct jit_program_space_data): Add initializers.
3896
3897 2019-07-10  Tom Tromey  <tromey@adacore.com>
3898
3899         * solib-darwin.c (struct darwin_info): Add initializers.
3900         (solib_darwin_pspace_data): Change type.
3901         (darwin_pspace_data_cleanup): Remove.
3902         (get_darwin_info, _initialize_darwin_solib): Update.
3903
3904 2019-07-10  Tom Tromey  <tromey@adacore.com>
3905
3906         * remote-sim.c (struct sim_inferior_data): Add initializers,
3907         constructor, and destructor.
3908         (sim_inferior_data_key): Change type.  Move lower.
3909         (check_for_duplicate_sim_descriptor): Update.
3910         (get_sim_inferior_data): Use new.  Update.
3911         (~sim_inferior_data_cleanup): Rename from
3912         sim_inferior_data_cleanup.  Simplify.
3913         (gdbsim_close_inferior, simulator_command)
3914         (sim_command_completer, _initialize_remote_sim): Update.
3915         (next_pid, INITIAL_PID): Move earlier.
3916
3917 2019-07-10  Tom Tromey  <tromey@adacore.com>
3918
3919         * python/python-internal.h (create_thread_object): Return
3920         gdbpy_ref.
3921         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3922         * python/py-inferior.c (struct threadlist_entry): Add
3923         constructor.
3924         <thread_obj>: Now a gdbpy_ref.
3925         (thread_to_thread_object): Update.
3926         (add_thread_object): Use new.
3927         (delete_thread_object): Use delete.
3928         (infpy_threads): Update.
3929         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3930         GIL.
3931
3932 2019-07-10  Tom Tromey  <tromey@adacore.com>
3933
3934         * valops.c (value_cast): Specialize error message for Ada.
3935
3936 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3937
3938         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3939
3940 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3941
3942         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3943         bpstat_should_step): Return bool, adjust comments.
3944         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3945         bpstat_should_step): Likewise.
3946
3947 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3948
3949         * features/Makefile: Use feature target descriptions for Arm.
3950         * features/arm/arm-core.c: Generate new file.
3951         * features/arm/arm-fpa.c: Likewise.
3952         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3953         * features/arm/arm-m-profile.c: Likewise.
3954         * features/arm/arm-vfpv2.c: Likewise.
3955         * features/arm/arm-vfpv3.c: Likewise.
3956         * features/arm/xscale-iwmmxt.c: Likewise.
3957         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3958
3959 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3960
3961         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3962         ptrace earlier.
3963
3964 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * features/aarch64-pauth.c: Regenerate.
3967
3968 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3969
3970         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3971         bool.
3972         (bpstat_what): Use false instead of 0.
3973
3974 2019-07-09  Pedro Alves  <palves@redhat.com>
3975
3976         * break-catch-throw.c (is_exception_catchpoint): New.
3977         * breakpoint.c (print_one_breakpoint_location): New parameter
3978         'raw_loc'.  Handle it.  Use
3979         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3980         looking at the breakpoint's type.
3981         (print_one_breakpoint): If handling "maint info breakpoints", also
3982         print locations of exception catchpoints.
3983         * breakpoint.h (is_exception_catchpoint): Declare.
3984
3985 2019-07-09  Pedro Alves  <palves@redhat.com>
3986
3987         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3988         "addr" field.
3989         (allocate_location_exception_catchpoint): New.
3990         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3991         (initialize_throw_catchpoint_ops): Install
3992         allocate_location_exception_catchpoint as allocate_location
3993         method.
3994         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3995         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3996         bp_loc_other.
3997         (breakpoint_address_is_meaningful): Delete.
3998         (bl_address_is_meaningful): New.
3999         (breakpoint_locations_match): Adjust comment.
4000         (bp_location_from_bp_type): New, factored out of...
4001         (bp_location::bp_location(breakpoint *)): ... this.
4002         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4003         factored out of...
4004         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4005         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4006         breakpoint_address_is_meaningful.
4007         (bp_locations_compare): Adjust comment.
4008         (update_global_location_list): Use bl_address_is_meaningful
4009         instead of breakpoint_address_is_meaningful.
4010         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4011         explicit.
4012         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4013         * python/py-breakpoint.c (bppy_get_location): No longer check
4014         whether location is null.
4015
4016 2019-07-09  Pedro Alves  <palves@redhat.com>
4017
4018         PR c++/15468
4019         * breakpoint.c (print_one_breakpoint_location): Remove
4020         single-location assert.
4021
4022 2019-07-09  Tom Tromey  <tom@tromey.com>
4023
4024         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4025         * configure: Rebuild.
4026         * configure.ac: Change common to gdbsupport.
4027         * gdbsupport: Rename from common.
4028         * acinclude.m4: Change common to gdbsupport.
4029         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4030         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4031         gdbsupport.
4032         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4033         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4034         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4035         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4036         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4037         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4038         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4039         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4040         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4041         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4042         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4043         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4044         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4045         coff-pe-read.c, command.h, compile/compile-c-support.c,
4046         compile/compile-c.h, compile/compile-cplus-symbols.c,
4047         compile/compile-cplus-types.c, compile/compile-cplus.h,
4048         compile/compile-loc2c.c, compile/compile.c, completer.c,
4049         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4050         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4051         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4052         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4053         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4054         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4055         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4056         features/aarch64-core.c, features/aarch64-fpu.c,
4057         features/aarch64-pauth.c, features/aarch64-sve.c,
4058         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4059         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4060         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4061         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4062         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4063         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4064         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4065         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4066         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4067         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4068         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4069         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4070         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4071         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4072         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4073         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4074         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4075         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4076         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4077         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4078         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4079         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4080         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4081         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4082         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4083         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4084         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4085         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4086         minsyms.c, mips-linux-tdep.c, namespace.h,
4087         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4088         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4089         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4090         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4091         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4092         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4093         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4094         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4095         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4096         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4097         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4098         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4099         procfs.c, producer.c, progspace.h, psymtab.h,
4100         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4101         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4102         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4103         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4104         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4105         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4106         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4107         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4108         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4109         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4110         target-memory.c, target.c, target.h, target/waitstatus.c,
4111         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4112         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4113         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4114         unittests/array-view-selftests.c,
4115         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4116         unittests/common-utils-selftests.c,
4117         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4118         unittests/format_pieces-selftests.c,
4119         unittests/function-view-selftests.c,
4120         unittests/lookup_name_info-selftests.c,
4121         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4122         unittests/mkdir-recursive-selftests.c,
4123         unittests/observable-selftests.c,
4124         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4125         unittests/parse-connection-spec-selftests.c,
4126         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4127         unittests/scoped_fd-selftests.c,
4128         unittests/scoped_mmap-selftests.c,
4129         unittests/scoped_restore-selftests.c,
4130         unittests/string_view-selftests.c, unittests/style-selftests.c,
4131         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4132         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4133         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4134         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4135         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4136         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4137
4138 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4141         bool value.
4142         (decode_digits_ordinary): Set explicit_line field in sal.
4143         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4144         symtab_and_line that was set on an explicit line number in
4145         assembler code.  Do always update the recorded symtab and line if
4146         we do skip the prologue.
4147
4148 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * breakpoint.c (set_breakpoint_location_function): Remove
4151         explicit_loc parameter.
4152         (momentary_breakpoint_from_master): Update call to
4153         set_breakpoint_location_function.
4154         (add_location_to_breakpoint): Likewise.
4155
4156 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4159         required features based on default bfd type when no specific bfd
4160         is present.
4161
4162 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4163
4164         * NEWS: Mention that GDB printf and eval commands can now print
4165         C-style and Ada-style convenience var strings without
4166         calling the inferior.
4167         * printcmd.c (printf_c_string): Locally print GDB internal var
4168         instead of transiting via the inferior.
4169         (printf_wide_c_string): Likewise.
4170
4171 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4172
4173         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4174
4175 2019-07-04  Tom Tromey  <tom@tromey.com>
4176
4177         PR tui/24724:
4178         * tui/tui-winsource.c (tui_clear_source_content): Update.
4179         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4180         (tui_update_breakpoint_info): Update.
4181         (tui_set_exec_info_content): Update.
4182         * tui/tui-source.c (tui_set_source_content_nil): Update.
4183         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4184         has_break.
4185         * tui/tui-data.h (enum tui_bp_flag): New.
4186         (tui_bp_flags): New enum flags type.
4187         (struct tui_source_element) <break_mode>: Change type.  Rename
4188         from has_break.
4189         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4190         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4191         constants.
4192         * tui/tui-winsource.h: Fix comment.
4193
4194 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4195
4196         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4197         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4198         (store_fpregs_to_thread)
4199         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4200         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4201         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4202         (IWMMXT_REGS_SIZE): Add define.
4203         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4204         (fetch_vfp_regs, store_vfp_regs)
4205         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4206         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4207
4208 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4209
4210         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4211         defines.
4212         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4213         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4214         (ARM_INT_REGISTER_SIZE): ...to this.
4215         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4216         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4217         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4218         (arm_linux_collect_gregset, supply_nwfpe_register)
4219         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4220         defines.
4221         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4222         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4223         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4224         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4225         (arm_return_in_memory, arm_store_return_value)
4226         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4227         (arm_record_ld_st_multiple): Likewise.
4228         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4229         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4230
4231 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4232
4233         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4234         AARCH64_DISPLACED_MODIFIED_INSNS.
4235         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4236         (aarch64_displaced_step_copy_insn): Likewise.
4237         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4238         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4239         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4240         ARM_DISPLACED_MODIFIED_INSNS.
4241         * arm-tdep.c (arm_gdbarch_init): Likewise.
4242         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4243         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4244         (struct arm_displaced_step_closure): Use
4245         ARM_DISPLACED_MODIFIED_INSNS.
4246
4247 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4248
4249         * features/Makefile: Remove unused xml files.
4250         * features/aarch64.xml: Remove.
4251         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4252         * features/i386/amd64-avx-avx512.xml: Remove.
4253         * features/i386/amd64-avx-linux.xml: Remove.
4254         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4255         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4256         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4257         * features/i386/amd64-avx-mpx.xml: Remove.
4258         * features/i386/amd64-avx.xml: Remove.
4259         * features/i386/amd64-linux.xml: Remove.
4260         * features/i386/amd64-mpx-linux.xml: Remove.
4261         * features/i386/amd64-mpx.xml: Remove.
4262         * features/i386/amd64.xml: Remove.
4263         * features/i386/i386-avx-avx512-linux.xml: Remove.
4264         * features/i386/i386-avx-avx512.xml: Remove.
4265         * features/i386/i386-avx-linux.xml: Remove.
4266         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4267         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4268         * features/i386/i386-avx-mpx-linux.xml: Remove.
4269         * features/i386/i386-avx-mpx.xml: Remove.
4270         * features/i386/i386-avx.xml: Remove.
4271         * features/i386/i386-linux.xml: Remove.
4272         * features/i386/i386-mmx-linux.xml: Remove.
4273         * features/i386/i386-mmx.xml: Remove.
4274         * features/i386/i386-mpx-linux.xml: Remove.
4275         * features/i386/i386-mpx.xml: Remove.
4276         * features/i386/i386.xml: Remove.
4277         * features/i386/x32-avx-avx512-linux.xml: Remove.
4278         * features/i386/x32-avx-linux.xml: Remove.
4279         * features/i386/x32-linux.xml: Remove.
4280
4281 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4282
4283         * regformats/aarch64.dat: Remove.
4284         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4285         * regformats/i386/amd64-avx-linux.dat: Remove.
4286         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4287         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4288         * regformats/i386/amd64-linux.dat: Remove.
4289         * regformats/i386/amd64-mpx-linux.dat: Remove.
4290         * regformats/i386/amd64.dat: Remove.
4291         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4292         * regformats/i386/i386-avx-linux.dat: Remove.
4293         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4294         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4295         * regformats/i386/i386-linux.dat: Remove.
4296         * regformats/i386/i386-mmx-linux.dat: Remove.
4297         * regformats/i386/i386-mpx-linux.dat: Remove.
4298         * regformats/i386/i386.dat: Remove.
4299         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4300         * regformats/i386/x32-avx-linux.dat: Remove.
4301         * regformats/i386/x32-linux.dat: Remove.
4302
4303 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * aarch64-tdep.c: Remove xml self tests.
4306         * amd64-linux-tdep.c: Likewise.
4307         * amd64-tdep.c: Likewise.
4308         * i386-linux-tdep.c: Likewise.
4309         * i386-tdep.c: Likewise.
4310
4311 2019-07-03  Pedro Alves  <palves@redhat.com>
4312
4313         PR cli/24732
4314         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4315         (pipe_cmd_option_defs): New.
4316         (make_pipe_cmd_options_def_group): New.
4317         (pipe_command): Use gdb::option::process_options.
4318         (pipe_command_completer): New function.
4319         (_initialize_cli_cmds): Install completer for "pipe" command.
4320
4321 2019-07-03  Pedro Alves  <palves@redhat.com>
4322
4323         * cli/cli-option.c (union option_value) <string>: New field.
4324         (struct option_def_and_value): Add ctor, move ctor, dtor and
4325         use DISABLE_COPY_AND_ASSIGN.
4326         (option_def_and_value::clear_value): New.
4327         (parse_option, save_option_value_in_ctx, get_val_type_str)
4328         (add_setshow_cmds_for_options): Handle var_string.
4329         * cli-option.h (union option_def::var_address) <string>: New
4330         field.
4331         (struct string_option_def): New.
4332         * maint-test-options.c (struct test_options_opts): Add default
4333         ctor and use DISABLE_COPY_AND_ASSIGN.
4334         <string_opt>: New field.
4335         (test_options_opts::~test_options_opts): New.
4336         (test_options_opts::dump): Also dump "-string".
4337         (test_options_option_defs): Install "string.
4338
4339 2019-07-03  Pedro Alves  <palves@redhat.com>
4340
4341         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4342         option_value with a null enumeration.
4343         (complete_options): Save the option values in the context.
4344         (save_option_value_in_ctx): New, factored out from ...
4345         (process_options): ... here.
4346         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4347         of the function.
4348         * maint-test-options.c (test_options_opts::dump): New, factored
4349         out from ...
4350         (maintenance_test_options_command_mode): ... here.
4351         (maintenance_test_options_command_completion_result): Delete.
4352         (maintenance_test_options_command_completion_text): Update
4353         comment.
4354         (maintenance_show_test_options_completion_result): Change
4355         prototype.  Just print
4356         maintenance_test_options_command_completion_text.
4357         (save_completion_result): New.
4358         (maintenance_test_options_completer_mode): Pass options context to
4359         complete_options, and then save a dump.
4360         (_initialize_maint_test_options): Use add_cmd to install "maint
4361         show test-options-completion-result".
4362
4363 2019-07-03  Pedro Alves  <palves@redhat.com>
4364
4365         * NEWS (New commands): Mention "with" and "maint with".
4366         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4367         (with_command, with_command_completer): New.
4368         (pipe_command): Adjust to new repeat_previous
4369         interface.
4370         (_initialize_cli_cmds): Install the "with" command and its "w"
4371         alias.
4372         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4373         declarations.
4374         * cli/cli-setshow.c (parse_cli_var_uinteger)
4375         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4376         argument strings for all var_types.
4377         (get_setshow_command_value_string): New, factored out from ...
4378         (do_show_command): ... this.
4379         * cli/cli-setshow.h: Include <string>.
4380         (get_setshow_command_value_string): Declare.
4381         * command.h (repeat_previous): Now returns const char *.  Adjust
4382         comment.
4383         * maint.c: Include "cli/cli-cmds.h".
4384         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4385         (_initialize_maint_cmds): Register the "maintenance with" command.
4386         * top.c (repeat_previous): Move bits from pipe_command here:
4387         Return the saved command line, if any; error out if there's no
4388         command to relaunch.
4389
4390 2019-07-03  Pedro Alves  <palves@redhat.com>
4391
4392         * NEWS (New commands): Mention "maint set/show test-settings"
4393         instead of "maint test-settings".
4394         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4395         (maintenance_test_settings_set_list): Rename to ...
4396         (maintenance_set_test_settings_list): ... this.
4397         (maintenance_test_settings_show_list): Rename to  ...
4398         (maintenance_show_test_settings_list): ... this.
4399         (maintenance_test_settings_cmd): Delete.
4400         (maintenance_test_settings_set_cmd): ...
4401         (maintenance_set_test_settings_cmd): ... this.
4402         (maintenance_test_settings_show_cmd): ...
4403         (maintenance_show_test_settings_cmd): ... this.
4404         (maintenance_test_settings_show_value_cmd):
4405         (maintenance_show_test_settings_value_cmd): ... this.
4406         (_initialize_maint_test_settings): No longer install the "maint
4407         test-settings" prefix command.  Rename "maint test-settings set"
4408         to "maint set test-settings", and "maint test-settings show" to
4409         "maint show test-settings".  Adjust all subcommands.
4410
4411 2019-07-03  Pedro Alves  <palves@redhat.com>
4412
4413         * maint-test-settings.c: Fix file's intro comment.  Replace all
4414         references to "test-options" with references to "test-settings",
4415         in comments.
4416
4417 2019-07-03  Pedro Alves  <palves@redhat.com>
4418
4419         * maint-test-settings.c (maintenance_test_settings_xxx)
4420         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4421         New.
4422         (maintenance_test_settings_enums): Use them.
4423         (maintenance_test_settings_enum): Default to
4424         maintenance_test_settings_xxx.
4425         (_initialize_maint_test_settings): Initialize
4426         MAINTENANCE_TEST_SETTINGS_FILENAME.
4427
4428 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4429
4430         * breakpoint.h (remove_breakpoints_inf): Change return type to
4431         void, move function documentation here.
4432         * breakpoint.c (remove_breakpoints_inf): Change return type to
4433         void, move function documentation to header.
4434
4435 2019-07-02  Pedro Alves  <palves@redhat.com>
4436
4437         * NEWS (Completion improvements): Mention "info threads".
4438         * thread.c (struct info_threads_opts, info_threads_option_defs)
4439         (make_info_threads_options_def_group): New.
4440         (info_threads_command): Use gdb::option::process_options.
4441         (info_threads_command_completer): New.
4442         (_initialize_thread): Use gdb::option::build_help to build the
4443         help text for "info threads".
4444
4445 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4446
4447         * defs.h (generic_load): Move from here...
4448         * symfile.h (generic_load): ... to here.  Rename name parameter
4449         to args.
4450         * symfile.c (generic_load): Add comment.
4451
4452 2019-07-01  Tom Tromey  <tromey@adacore.com>
4453
4454         * dwarf2read.c
4455         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4456         declaration of without_params.  Fix formatting.
4457
4458 2019-07-01  Tom Tromey  <tromey@adacore.com>
4459
4460         * ada-exp.y (find_primitive_type): Update.
4461         * ada-lang.h (ada_lookup_symbol): Update.
4462         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4463         parameter.
4464         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4465
4466 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4467
4468         PR breakpoints/24541
4469         * gdbarch.c: Regenerate.
4470         * gdbarch.h: Regenerate.
4471         * gdbarch.sh: Add 'stap_adjust_register'.
4472         * i386-tdep.c: Include '<unordered_set>'.
4473         (i386_stap_adjust_register): New function.
4474         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4475         * stap-probe.c (stap_parse_register_operand): Call
4476         'gdbarch_stap_adjust_register'.
4477
4478 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4479
4480         PR python/24742
4481         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4482         * python/python.c (do_start_initialization): Use 'xmalloc'
4483         instead of 'PyMem_Malloc'.
4484
4485 2019-06-28  Tom Tromey  <tromey@adacore.com>
4486
4487         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4488         for Ada.
4489
4490 2019-06-27  Tom Tromey  <tromey@adacore.com>
4491
4492         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4493         objfile_key.
4494         (arm_find_mapping_symbol, arm_record_special_symbol)
4495         (_initialize_arm_tdep): Update.
4496         (arm_objfile_data_free): Remove.
4497
4498 2019-06-27  Tom Tromey  <tromey@adacore.com>
4499
4500         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4501         to cp_print_static_field.
4502
4503 2019-06-26  Tom Tromey  <tromey@adacore.com>
4504
4505         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4506         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4507         declare.
4508
4509 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4510
4511         * features/aarch64-core.c (create_feature_aarch64_core):
4512         Regenerate.
4513         * features/aarch64-core.xml: Add cpsr flags.
4514
4515 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4516
4517         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4518         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4519
4520 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4521
4522         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4523         field.
4524         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4525         use.
4526         (arm_record_special_symbol): Don't insert new symbol in sorted
4527         position, push it at the end.
4528
4529 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4530
4531         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4532         (arm_mapping_symbol_s): Remove.
4533         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4534         (arm_mapping_symbol_vec): New typedef.
4535         (struct arm_per_objfile): Add constructor.
4536         <section_maps>: Change type to
4537         std::unique_ptr<arm_mapping_symbol_vec[]>.
4538         (arm_compare_mapping_symbols): Remove.
4539         (arm_find_mapping_symbol): Adjust to section_maps type change.
4540         (arm_objfile_data_free): Call delete on arm_per_objfile.
4541         (arm_record_special_symbol): Adjust to section_maps type change.
4542         Allocate arm_per_objfile with new.
4543
4544 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4547         with the command prefix.
4548
4549 2019-06-25  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4552         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4557         type.
4558         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4559         protected.
4560
4561 2019-06-25  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-winsource.c
4564         (tui_source_window_base::set_is_exec_point_at): Add check against
4565         LOA_ADDRESS.
4566
4567 2019-06-25  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-source.c (tui_set_source_content): Don't check before
4570         xfree.
4571         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4572
4573 2019-06-25  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui-winsource.h (tui_update_source_window_as_is)
4576         (tui_alloc_source_buffer, tui_line_is_displayed)
4577         (tui_addr_is_displayed): Change type of win_info.
4578         * tui/tui-winsource.c (tui_update_source_window_as_is)
4579         (tui_clear_source_content, tui_show_source_line)
4580         (tui_show_source_content, tui_source_window_base::refill)
4581         (tui_source_window_base::set_is_exec_point_at)
4582         (tui_source_window_base::set_is_exec_point_at)
4583         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4584         (tui_alloc_source_buffer, tui_line_is_displayed)
4585         (tui_addr_is_displayed): Change type of win_info.  Update.
4586         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4587         (tui_source_window_base::do_make_visible_with_new_height):
4588         Update.
4589         * tui/tui-source.c (tui_set_source_content)
4590         (tui_set_source_content_nil)
4591         (tui_source_window::do_scroll_vertical): Update.
4592         * tui/tui-layout.c (show_layout): Update.
4593         * tui/tui-disasm.c (tui_set_disassem_content)
4594         (tui_disasm_window::do_scroll_vertical): Update.
4595         * tui/tui-data.h (tui_win_content): Remove.
4596         (struct tui_gen_win_info) <content, content_size>: Remove.
4597         (struct tui_source_element): Add initializers and destructor.
4598         (union tui_which_element, struct tui_win_element): Remove.
4599         (struct tui_source_window_base) <content>: New field.
4600         (struct tui_data_window): Remove destructor.
4601         (tui_alloc_content, tui_free_win_content)
4602         (tui_free_all_source_wins_content): Don't declare.
4603         * tui/tui-data.c (tui_initialize_static_data): Update.
4604         (init_content_element, tui_alloc_content): Remove.
4605         (~tui_gen_win_info): Update.
4606         (~tui_data_window, tui_free_all_source_wins_content)
4607         (tui_free_win_content, free_content, free_content_elements):
4608         Remove.
4609
4610 2019-06-25  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-winsource.h (tui_clear_source_content)
4613         (tui_erase_source_content, tui_show_source_content): Change type
4614         of win_info.
4615         * tui/tui-winsource.c (tui_clear_source_content)
4616         (tui_erase_source_content, tui_show_source_content): Change type
4617         of win_info.
4618         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4619         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4620         win_info.
4621         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4622         win_info.
4623         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4624
4625 2019-06-25  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-winsource.c (tui_clear_source_content)
4628         (tui_source_window_base::set_is_exec_point_at): Update.
4629         * tui/tui-source.c (tui_set_source_content_nil): Update.
4630         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4631         a bool.
4632         * tui/tui-data.c (init_content_element): Update.
4633
4634 2019-06-25  Tom Tromey  <tom@tromey.com>
4635
4636         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4637         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4638         * tui/tui-layout.c (init_and_make_win): Update.
4639         * tui/tui.h (enum tui_win_type): Update.
4640         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4641         tui_win_is_auxillary.
4642         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4643         tui_win_is_auxillary.
4644
4645 2019-06-25  Tom Tromey  <tom@tromey.com>
4646
4647         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4648         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4649         (tui_delete_data_content_windows, tui_display_all_data)
4650         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4651         Update.
4652         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4653         * tui/tui-regs.c (tui_last_regs_line_no)
4654         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4655         (tui_show_registers): Update.
4656         (tui_show_register_group): Return void.  Update.
4657         (tui_display_registers_from, tui_display_reg_element_at_line)
4658         (tui_display_registers_from_line, tui_check_register_values):
4659         Update.
4660         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4661         member.
4662         (struct tui_data_window) <regs_content>: Now a std::vector.
4663         <regs_content_count>: Remove.
4664         (tui_add_content_elements, tui_free_data_content): Don't declare.
4665         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4666         (init_content_element): Remove DATA_WIN case.  Add assert.
4667         (tui_add_content_elements): Remove.
4668         (tui_data_window): Update.
4669         (tui_free_data_content): Remove.
4670         (free_content_elements): Remove DATA_WIN case.
4671
4672 2019-06-25  Tom Tromey  <tom@tromey.com>
4673
4674         * tui/tui-data.c (tui_data_item_window): Update.
4675         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4676         * tui/tui-windata.c (tui_display_all_data)
4677         (tui_display_data_from_line): Update.
4678         (tui_check_data_values): Remove.
4679         * tui/tui-regs.c (tui_show_register_group)
4680         (tui_display_reg_element_at_line): Update.
4681         * tui/tui-hooks.c (tui_register_changed)
4682         (tui_refresh_frame_and_register_information): Call
4683         tui_check_register_values.
4684         * tui/tui-data.h (struct tui_data_window) <data_content,
4685         data_content_count, data_type>: Remove.
4686         (enum tui_data_type): Remove.
4687
4688         * tui/tui-data.c (tui_data_window::clear_detail)
4689         (~tui_data_window): Update.
4690
4691 2019-06-25  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4694         declare.
4695         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4696         Rename from tui_first_data_item_displayed.  Update.
4697         (tui_data_window::refresh_all)
4698         (tui_data_window::do_scroll_vertical): Update.
4699         * tui/tui-data.h (struct tui_data_window)
4700         <first_data_item_displayed>: Declare new method.
4701
4702 2019-06-25  Tom Tromey  <tom@tromey.com>
4703
4704         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4705         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4706         contents...
4707         (tui_initialize_static_data): ...here.
4708
4709 2019-06-25  Tom Tromey  <tom@tromey.com>
4710
4711         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4712         (tui_display_registers_from, tui_check_register_values): Update.
4713         (tui_display_register): Remove win_info parameter; update.
4714         (tui_get_register): Change type of parameters.
4715         * tui/tui-data.h (struct tui_data_element): Remove.
4716         (union tui_which_element) <data>: Remove.
4717         <data_window>: Change type.
4718         (struct tui_data_item_window): New.
4719         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4720         case.  Add assert.
4721         (~tui_data_item_window): New destructor.
4722         (free_content_elements): Remove DATA_ITEM_WIN case.
4723
4724 2019-06-25  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4727         Remove.
4728
4729 2019-06-25  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-data.h (struct tui_command_element): Remove.
4732         (union tui_which_element) <command>: Remove.
4733         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4734         assert.
4735         (free_content_elements): Remove CMD_WIN case.
4736
4737 2019-06-25  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-layout.c (tui_set_layout): Update.
4740         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4741         * tui/tui-data.c (layout_def): Update.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4746         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4747         (tui_source_window_base::set_new_height): Update.
4748         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4749         Update.
4750         (tui_set_locator_fullname, tui_set_locator_info)
4751         (tui_show_frame_info): Update.
4752         * tui/tui-source.c (tui_set_source_content)
4753         (tui_source_is_displayed): Update.
4754         * tui/tui-layout.c (show_source_disasm_command, show_data)
4755         (show_source_or_disasm_and_command): Update.
4756         * tui/tui-disasm.c (tui_set_disassem_content)
4757         (tui_get_begin_asm_address): Update.
4758         * tui/tui-data.h (struct tui_locator_element): Remove.
4759         (union tui_which_element) <locator>: Remove.
4760         (struct tui_locator_window): New.
4761         (tui_locator_win_info_ptr): Change return type.
4762         * tui/tui-data.c (_locator): Change type.
4763         (tui_locator_win_info_ptr): Change return type.
4764         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4765         (tui_alloc_content): Add assert.
4766
4767 2019-06-25  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-winsource.c
4770         (tui_exec_info_window::maybe_allocate_content): New method.
4771         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4772         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4773         (make_source_or_disasm_window): Add cast.
4774         * tui/tui-data.h (union tui_which_element) <simple_string>:
4775         Remove.
4776         (struct tui_source_info): New.
4777         (struct tui_source_window_base) <execution_info>: Change type.
4778         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4779         case, and add assert.
4780         (tui_alloc_content): Add assert.
4781
4782 2019-06-25  Tom Tromey  <tom@tromey.com>
4783
4784         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4785         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4786         * tui/tui-data.c (tui_alloc_win_info): Remove.
4787
4788 2019-06-25  Tom Tromey  <tom@tromey.com>
4789
4790         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4791         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4792         can_highlight.
4793
4794 2019-06-25  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4797         make_visible_with_new_height method.
4798         (tui_win_info::make_visible_with_new_height): New method.
4799         (tui_source_window_base::do_make_visible_with_new_height)
4800         (tui_data_window::do_make_visible_with_new_height)
4801         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4802         (make_visible_with_new_height): Remove.
4803         (tui_resize_all, tui_adjust_win_heights): Use
4804         make_visible_with_new_height method.
4805         * tui/tui-data.h (struct tui_win_info)
4806         <do_make_visible_with_new_height, make_visible_with_new_height>:
4807         New methods.
4808         (struct tui_source_window_base, struct tui_data_window)
4809         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4810         methods.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4815         method.
4816         (update_tab_width): Call update_tab_width method.
4817         * tui/tui-data.h (struct tui_win_info)
4818         (struct tui_source_window_base) <update_tab_width>: New methods.
4819
4820 2019-06-25  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4823         parameter.
4824         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4825         parameter.
4826         (tui_gen_win_info::make_visible): Update.
4827         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4828         parameter.
4829         * tui/tui-data.h (enum tui_box): New enum.
4830         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4831
4832 2019-06-25  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4835         init_and_make_win for EXEC_INFO_WIN.
4836         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4837         longer inline.
4838         (struct tui_win_info) <~tui_win_info>: Inline.
4839         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4840         Don't declare.
4841         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4842         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4843         Remove.
4844         (tui_initialize_static_data): Update.
4845         (~tui_gen_win_info): Handle more cleanup here.
4846         (~tui_source_window_base): Delete "execution_info".
4847         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4848
4849 2019-06-25  Tom Tromey  <tom@tromey.com>
4850
4851         * tui/tui-layout.c (make_command_window): Don't set
4852         can_highlight.
4853         (show_source_disasm_command): Call the reset method.
4854         (show_data): Don't set can_highlight.  Call the reset method.
4855         (tui_gen_win_info::reset): Rename from init_gen_win_info
4856         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4857         (show_source_or_disasm_and_command): Call the reset method.
4858         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4859         (struct tui_cmd_window): Set can_highlight.
4860
4861 2019-06-25  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4864         from make_visible.
4865         (tui_make_visible, tui_make_invisible): Rewrite.
4866         (tui_win_info::make_visible): Remove.
4867         (tui_source_window_base::make_visible): Update.
4868         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4869         method.  Moved from...
4870         (struct tui_win_info) <make_visible>: ...here.
4871
4872 2019-06-25  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-winsource.c
4875         (tui_source_window_base::do_scroll_horizontal): Remove direction
4876         parameter.
4877         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4878         direction parameter.
4879         * tui/tui-win.c (tui_win_info::forward_scroll)
4880         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4881         (tui_win_info::right_scroll): Update.
4882         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4883         direction parameter.
4884         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4885         direction parameter.
4886         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4887         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4888         Remove direction parameter.
4889         (struct tui_source_window_base, struct tui_source_window)
4890         (struct tui_disasm_window, struct tui_data_window)
4891         (struct tui_cmd_window): Update.
4892
4893 2019-06-25  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-winsource.h (tui_set_exec_info_content)
4896         (tui_show_exec_info_content, tui_erase_exec_info_content)
4897         (tui_clear_exec_info_content, tui_update_exec_info): Change
4898         argument to tui_source_window_base.
4899         * tui/tui-winsource.c (tui_set_exec_info_content)
4900         (tui_show_exec_info_content, tui_erase_exec_info_content)
4901         (tui_clear_exec_info_content, tui_update_exec_info): Change
4902         argument to tui_source_window_base.
4903
4904 2019-06-25  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4907         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4908
4909 2019-06-25  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4912         check.
4913
4914 2019-06-25  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4917         type to void.
4918         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4919         type to void.
4920         * tui/tui-source.c (tui_set_source_content): Update.
4921         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4922
4923 2019-06-25  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-win.c (window_name_completer, tui_set_focus)
4926         (tui_all_windows_info): Use name method.
4927         * tui/tui-data.h (struct tui_gen_win_info)
4928         (struct tui_source_window, struct tui_disasm_window)
4929         (struct tui_data_window, struct tui_cmd_window) <name>: New
4930         method.
4931         (tui_win_name): Don't declare.
4932         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4933         (tui_win_name): Remove.
4934
4935 2019-06-25  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-winsource.h (tui_update_source_window)
4938         (tui_update_source_window_as_is): Change parameter type.
4939         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4940         to be a tui_source_window_base.
4941         (tui_update_source_window_as_is): Likewise.
4942         * tui/tui-win.c (make_visible_with_new_height): Update.
4943
4944 2019-06-25  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-winsource.c (tui_erase_source_content)
4947         (tui_show_source_content, tui_show_exec_info_content)
4948         (tui_erase_exec_info_content): Use refresh_window method.
4949         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4950         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4951         from tui_refresh_win.
4952         (tui_data_window::refresh_window): New method.
4953         (tui_win_info::refresh, tui_source_window_base::refresh)
4954         (tui_refresh_all): Use refresh_window method.
4955         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4956         method.
4957         * tui/tui-regs.c (tui_display_register): Call refresh_window
4958         method.
4959         * tui/tui-layout.c (show_source_disasm_command)
4960         (show_source_or_disasm_and_command): Call refresh_window method.
4961         * tui/tui-data.h (struct tui_gen_win_info)
4962         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4963         New method.
4964
4965 2019-06-25  Tom Tromey  <tom@tromey.com>
4966
4967         * tui/tui.c (tui_rl_other_window, tui_enable)
4968         (tui_is_window_visible, tui_get_command_dimension): Update.
4969         * tui/tui-winsource.c (tui_update_source_window_as_is)
4970         (tui_clear_source_content, tui_erase_source_content)
4971         (tui_show_source_line, tui_source_window_base::refill)
4972         (tui_source_window_base::do_scroll_horizontal)
4973         (tui_source_window_base::set_is_exec_point_at)
4974         (tui_update_breakpoint_info, tui_set_exec_info_content)
4975         (tui_alloc_source_buffer, tui_line_is_displayed)
4976         (tui_addr_is_displayed): Update.
4977         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4978         (tui_check_and_display_highlight_if_needed)
4979         (tui_win_info::make_visible, tui_win_info::refresh)
4980         (tui_refresh_all): Update.
4981         * tui/tui-windata.c (tui_first_data_item_displayed)
4982         (tui_delete_data_content_windows, tui_erase_data_content)
4983         (tui_display_all_data, tui_data_window::refresh_all)
4984         (tui_check_data_values): Update.
4985         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4986         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4987         (tui_win_info::backward_scroll, tui_refresh_all_win)
4988         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4989         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4990         (tui_source_window_base::set_new_height)
4991         (tui_data_window::set_new_height)
4992         (make_invisible_and_set_new_height)
4993         (make_visible_with_new_height, new_height_ok)
4994         (parse_scrolling_args): Update.
4995         * tui/tui-stack.c (tui_show_frame_info): Update.
4996         * tui/tui-source.c (tui_set_source_content)
4997         (tui_set_source_content_nil, tui_source_is_displayed)
4998         (tui_source_window::do_scroll_vertical): Update.
4999         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5000         (tui_display_registers_from, tui_display_reg_element_at_line)
5001         (tui_check_register_values, tui_reg_command): Update.
5002         * tui/tui-layout.c (tui_default_win_height)
5003         (show_source_disasm_command, show_data, init_and_make_win)
5004         (show_source_or_disasm_and_command): Update.
5005         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5006         (tui_redisplay_readline, tui_mld_flush)
5007         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5008         (tui_getc): Update.
5009         * tui/tui-disasm.c (tui_set_disassem_content)
5010         (tui_disasm_window::do_scroll_vertical): Update.
5011         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5012         Now virtual.
5013         (struct tui_win_info): Derive from tui_gen_win_info.
5014         <~tui_win_info>: Mark as override.
5015         <generic>: Remove member.
5016         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5017         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5018         (~tui_data_window, ~tui_win_info)
5019         (tui_free_all_source_wins_content): Update.
5020         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5021
5022 2019-06-25  Tom Tromey  <tom@tromey.com>
5023
5024         * tui/tui-layout.c (init_and_make_win): Use new.
5025         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5026         destructor, initializers.
5027         (tui_alloc_generic_win_info): Don't declare.
5028         * tui/tui-data.c (_locator): Add argument to constructor.
5029         (source_win, disasm_win): New globals.
5030         (exec_info): Remove.
5031         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5032         Update.
5033         (tui_alloc_generic_win_info): Remove.
5034         (init_content_element): Use new.
5035         (tui_win_info::tui_win_info): Update.
5036         (free_content_elements) <case DATA_WIN>: Use delete.
5037
5038 2019-06-25  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5041         * tui/tui-windata.c (tui_first_data_item_displayed)
5042         (tui_delete_data_content_windows): Update.
5043         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5044         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5045         (tui_display_registers_from, tui_check_register_values): Update.
5046         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5047         pointer.
5048         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5049         window.
5050         (tui_free_data_content): Update.
5051         (free_content_elements) <case DATA_WIN>: Free the window.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5056         Update.
5057         * tui/tui-layout.c (make_command_window)
5058         (show_source_disasm_command, show_data, init_and_make_win)
5059         (show_source_or_disasm_and_command): Update.
5060         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5061         method.
5062         <can_highight, is_highlighted>: Now bool.
5063         (tui_set_win_highlight): Don't declare.
5064         * tui/tui-data.c (tui_set_win_highlight): Remove.
5065
5066 2019-06-25  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-wingeneral.c (make_visible): Remove check of window
5069         type.
5070
5071 2019-06-25  Tom Tromey  <tom@tromey.com>
5072
5073         * tui/tui-win.c (tui_win_info::max_height)
5074         (tui_cmd_window::max_height): New methods.
5075         (new_height_ok): Call max_height.
5076         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5077         <max_height>: New method.
5078
5079 2019-06-25  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-win.c (tui_source_window_base::set_new_height)
5082         (tui_data_window::set_new_height): New methods.
5083         (make_invisible_and_set_new_height): Call set_new_height method.
5084         * tui/tui-data.h (struct tui_win_info)
5085         (struct tui_source_window_base, struct tui_data_window)
5086         <set_new_height>: New method.
5087
5088 2019-06-25  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5091         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5092         tui_refresh_data_win.
5093         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5094         method.
5095         (tui_refresh_all_win): Call the refresh_all method.
5096         (tui_set_focus): Likewise.
5097         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5098         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5099         Likewise.
5100
5101 2019-06-25  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-winsource.h (tui_refill_source_window)
5104         (tui_set_is_exec_point_at): Don't declare.
5105         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5106         (tui_source_window_base::refill): Rename from
5107         tui_refill_source_window.
5108         (tui_source_window_base::do_scroll_horizontal): Update.
5109         (tui_source_window_base::set_is_exec_point_at): Rename from
5110         tui_set_is_exec_point_at.
5111         (tui_update_all_breakpoint_info): Update.
5112         * tui/tui-stack.c (tui_show_frame_info): Update.
5113         * tui/tui-layout.c (show_data): Add cast.
5114         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5115         * tui/tui-data.h (struct tui_source_window_base) <refill,
5116         set_is_exec_point_at>: New methods.
5117         (tui_source_windows, tui_add_to_source_windows): Update types.
5118         (tui_add_to_source_windows): Remove redundant declaration.
5119         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5120         (tui_source_windows): Change return type.
5121         (tui_clear_source_windows_detail): Update.
5122         (tui_add_to_source_windows): Change type of parameter.
5123         (tui_free_all_source_wins_content): Update.
5124
5125 2019-06-25  Tom Tromey  <tom@tromey.com>
5126
5127         * tui/tui-wingeneral.c (tui_win_info::refresh)
5128         (tui_source_window_base::refresh): New methods.
5129         (tui_refresh_all): Call the refresh method.
5130         * tui/tui-data.h (struct tui_win_info)
5131         (struct tui_source_window_base) <refresh>: New method.
5132
5133 2019-06-25  Tom Tromey  <tom@tromey.com>
5134
5135         * tui/tui.h (tui_is_window_visible): Return bool.
5136         * tui/tui.c (tui_is_window_visible): Return bool.
5137         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5138         (tui_make_visible, tui_make_invisible)
5139         (tui_win_info::make_visible)
5140         (tui_source_window_base::make_visible, make_all_visible)
5141         (tui_make_all_visible, tui_make_all_invisible): Update.
5142         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5143         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5144         bool.
5145         (struct tui_win_info, struct tui_source_window_base)
5146         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5147         * tui/tui-data.c (tui_init_generic_part): Update.
5148
5149 2019-06-25  Tom Tromey  <tom@tromey.com>
5150
5151         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5152         (tui_source_window_base::make_visible): New methods.
5153         (make_all_visible): Make method call.
5154         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5155         (struct tui_source_window_base, struct tui_cmd_window): Override
5156         make_visible.
5157         (tui_win_is_source_type): Don't declare.
5158         * tui/tui-data.c (tui_win_is_source_type): Remove.
5159
5160 2019-06-25  Tom Tromey  <tom@tromey.com>
5161
5162         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5163         NULL check.
5164
5165 2019-06-25  Tom Tromey  <tom@tromey.com>
5166
5167         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5168         Inline constructor.  Add initializers for members.
5169         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5170         constructors; now inline in class.
5171
5172 2019-06-25  Tom Tromey  <tom@tromey.com>
5173
5174         * tui/tui-regs.c (tui_show_registers): Update.
5175         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5176         bool.
5177         * tui/tui-data.c (tui_data_window::clear_detail)
5178         (tui_data_window): Update.
5179
5180 2019-06-25  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-windata.c (tui_display_all_data)
5183         (tui_display_data_from_line, tui_display_data_from)
5184         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5185         Update.
5186         * tui/tui-regs.c (tui_last_regs_line_no)
5187         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5188         (tui_show_registers, tui_show_register_group)
5189         (tui_display_registers_from, tui_display_reg_element_at_line)
5190         (tui_display_registers_from_line, tui_check_register_values)
5191         (tui_reg_next, tui_reg_prev): Update.
5192         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5193         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5194         tui_data_window.
5195         (struct tui_win_info) <detail>: Remove.  Add new fields from
5196         tui_data_info.
5197         (TUI_DATA_WIN): Add cast.
5198         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5199         (~tui_data_window): Simplify.
5200
5201 2019-06-25  Tom Tromey  <tom@tromey.com>
5202
5203         * tui/tui-layout.c (show_source_disasm_command)
5204         (show_source_or_disasm_and_command): Update.
5205         * tui/tui-io.c (update_cmdwin_start_line)
5206         (tui_redisplay_readline): Update.
5207         * tui/tui-data.h (struct tui_command_info): Remove.
5208         (struct tui_win_info) <detail>: Remove command_info member.
5209         (struct tui_data_window) <start_line>: New member, from
5210         tui_command_info.
5211         (TUI_CMD_WIN): Add casts.
5212
5213 2019-06-25  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-winsource.c (tui_update_source_window)
5216         (tui_refill_source_window)
5217         (tui_source_window_base::do_scroll_horizontal)
5218         (tui_update_breakpoint_info, tui_set_exec_info_content)
5219         (tui_show_exec_info_content, tui_erase_exec_info_content)
5220         (tui_clear_exec_info_content): Update.
5221         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5222         Update.
5223         * tui/tui-win.c (make_invisible_and_set_new_height)
5224         (make_visible_with_new_height): Update.
5225         * tui/tui-source.c (tui_set_source_content)
5226         (tui_show_symtab_source): Update.
5227         * tui/tui-layout.c (extract_display_start_addr)
5228         (show_source_disasm_command, show_data)
5229         (make_source_or_disasm_window)
5230         (show_source_or_disasm_and_command): Update.
5231         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5232         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5233         "gdbarch".
5234         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5235         to tui_source_window_base.
5236         (struct tui_win_info) <detail>: Remove source_info member.
5237         (struct tui_source_window_base) <has_locator>: Inline.
5238         Move contents from tui_source_info; rename has_locator member to
5239         m_has_locator.
5240         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5241         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5242         header file.
5243         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5244         Simplify.
5245         (tui_free_all_source_wins_content): Cast to
5246         tui_source_window_base.
5247
5248 2019-06-25  Tom Tromey  <tom@tromey.com>
5249
5250         * tui/tui-win.c (make_invisible_and_set_new_height)
5251         (make_visible_with_new_height): Call has_locator method.
5252         * tui/tui-layout.c (show_source_disasm_command, show_data)
5253         (show_source_or_disasm_and_command): Update for bool change.
5254         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5255         (tui_win_info) <has_locator>: New method.
5256         (struct tui_source_window_base) <has_locator>: New method.
5257         (tui_win_has_locator): Don't declare.
5258         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5259         from tui_win_has_locator.
5260         (tui_source_window_base): Use false, not FALSE.
5261
5262 2019-06-25  Tom Tromey  <tom@tromey.com>
5263
5264         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5265         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5266         clear_detail method directly.
5267         (tui_clear_win_detail): Remove.
5268
5269 2019-06-25  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5272         "this", not TUI_DISASM_WIN.
5273
5274 2019-06-25  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5277         declare.
5278         * tui/tui-winsource.c
5279         (tui_source_window_base::do_scroll_horizontal): Rename from
5280         tui_horizontal_source_scroll.
5281         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5282         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5283         from tui_vertical_data_scroll.
5284         * tui/tui-win.h (tui_scroll): Don't declare.
5285         * tui/tui-win.c (tui_win_info::forward_scroll)
5286         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5287         (tui_win_info::right_scroll): Rename and update.
5288         (tui_scroll_forward_command, tui_scroll_backward_command)
5289         (tui_scroll_left_command, tui_scroll_right_command): Update.
5290         (tui_scroll): Remove.
5291         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5292         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5293         from tui_vertical_source_scroll.
5294         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5295         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5296         from tui_vertical_disassem_scroll.
5297         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5298         do_scroll_horizontal>: New methods.
5299         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5300         Likewise.
5301         (struct tui_source_window_base): Add do_scroll_horizontal.
5302         (struct tui_source_window, struct tui_disasm_window): Add
5303         do_scroll_vertical.
5304         (struct tui_data_window, struct tui_cmd_window): Add
5305         do_scroll_horizontal and do_scroll_vertical.
5306         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5307
5308 2019-06-25  Tom Tromey  <tom@tromey.com>
5309
5310         * tui/tui-data.h (struct tui_source_window_base): New struct.
5311         (struct tui_source_window): Derive from tui_source_window_base.
5312         (struct tui_disasm_window): New struct.
5313         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5314         from tui_source_window::clear_detail.
5315         (tui_source_window_base): Rename from tui_source_window.
5316         (~tui_source_window_base): Rename from ~tui_source_window.
5317         (tui_alloc_win_info): Create a tui_disasm_window.
5318
5319 2019-06-25  Tom Tromey  <tom@tromey.com>
5320
5321         * tui/tui-data.h (struct tui_source_window)
5322         (struct tui_data_window): Declare destructors.
5323         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5324         destructors.
5325         (tui_win_info): Simplify.
5326
5327 2019-06-25  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-winsource.c (tui_display_main)
5330         (tui_update_source_windows_with_addr)
5331         (tui_update_all_breakpoint_info): Update.
5332         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5333         (new_height_ok, parse_scrolling_args): Update.
5334         * tui/tui-stack.c (tui_show_frame_info): Update.
5335         * tui/tui-data.h (struct tui_list): Remove.
5336         (tui_source_windows): Return a reference to a std::vector.
5337         * tui/tui-data.c (source_windows): Now a std::vector.
5338         (tui_source_windows): Change return type.
5339         (tui_clear_source_windows): Rewrite.
5340         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5341         (tui_free_all_source_wins_content): Rewrite.
5342
5343 2019-06-25  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5346         (struct tui_data_window, struct tui_cmd_window): Declare
5347         clear_detail method.
5348         * tui/tui-data.c (tui_source_window::clear_detail)
5349         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5350         methods.
5351         (tui_clear_win_detail): Simplify.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-layout.c (make_source_window, make_disasm_window)
5356         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5357         Return the new window.
5358         (show_source_disasm_command, show_data)
5359         (show_source_or_disasm_and_command): Update.
5360
5361 2019-06-25  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5364         parameter.  Return the new window.
5365         (show_source_disasm_command): Update and remove NULL check.
5366         (show_source_or_disasm_and_command): Update.
5367
5368 2019-06-25  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5371
5372 2019-06-25  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-data.h (struct tui_win_info): Make constructor
5375         protected.  Make destructor virtual.  Add initializers.
5376         (tui_source_window, tui_data_window, tui_cmd_window): New
5377         classes.
5378         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5379         constructor.  Add "type" parameter.
5380         (tui_source_window, tui_data_window, tui_cmd_window): New
5381         constructors.
5382         (tui_alloc_win_info): Instantiate the appropriate subclass.
5383
5384 2019-06-25  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-win.c (tui_resize_all): Use delete.
5387         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5388         destructor.
5389         (tui_free_window): Don't declare.
5390         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5391         Update.
5392
5393 2019-06-25  Tom Tromey  <tom@tromey.com>
5394
5395         * tui/tui-data.h (struct tui_win_info): Add constructor.
5396         * tui/tui-data.c (tui_alloc_win_info): Use new.
5397         (tui_free_window): Use delete.
5398
5399 2019-06-22  Tom Tromey  <tom@tromey.com>
5400
5401         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5402         declare.
5403         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5404
5405 2019-06-22  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5408         declare.
5409         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5410
5411 2019-06-22  Tom de Vries  <tdevries@suse.de>
5412
5413         * dwarf2read.c (create_addrmap_from_aranges)
5414         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5415         instead of '%zu'.
5416
5417 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5418
5419         * dwarf2read.h (dwarf2_section_info_def): Remove.
5420         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5421         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5422         std::vector<dwarf2_section_info>.
5423         (struct dwo_file) <~dwo_file>: Remove.
5424         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5425         types field.
5426         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5427         (dwarf2_read_debug_names): Likewise.
5428         (create_debug_types_hash_table): Change parameter type to
5429         array_view, adjust code accordingly.
5430         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5431         (partial_die_info::fixup): Likewise.
5432         (determine_prefix): Likewise.
5433         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5434
5435 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5436
5437         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5438         gdb_bfd_ref_ptr.
5439         <~dwo_file>: Remove call to gdb_bfd_unref.
5440         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5441         gdb_bfd_ref_ptr::get.
5442
5443 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5444
5445         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5446         type to htab_up.
5447         * dwarf2read.c (struct dwo_file): Initialize fields.
5448         <~dwo_file>: New.
5449         (free_dwo_file): Remove, move content to ~dwo_file.
5450         (struct dwo_file_deleter): Remove.
5451         (dwo_file_up>: Remove custom deleter.
5452         (free_dwo_files): Remove.
5453         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5454         dwo_files.
5455         (process_skeletonless_type_units): Call unique_ptr::get.
5456         (allocate_dwo_file_hash_table): Add deleter to created hash
5457         table.  Change return type to htab_up.
5458         (lookup_dwo_file_slot): Don't memset dwo_file, call
5459         unique_ptr::get.
5460         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5461         (create_dwo_unit_in_dwp_v2): Likewise.
5462         (open_and_init_dwo_file): Likewise.
5463         (free_dwo_file_from_slot): Remove.
5464
5465 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5466
5467         * dwarf2read.h (struct dwarf2_section_info) <readin,
5468         is_virtual>: Change type to bool.
5469         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5470         true instead of 1.
5471
5472 2019-06-19  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-data.h (tui_init_content_element): Don't declare.
5475
5476 2019-06-19  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-data.h (tui_init_win_info): Don't declare.
5479
5480 2019-06-19  Tom de Vries  <tdevries@suse.de>
5481
5482         * dwarf2read.h (abstract_to_concrete): Change type to
5483         std::unordered_map<sect_offset, std::vector<sect_offset>,
5484         gdb::hash_enum<sect_offset>>.
5485
5486 2019-06-19  Tom Tromey  <tromey@adacore.com>
5487
5488         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5489         EVAL_AVOID_SIDE_EFFECTS specially.
5490
5491 2019-06-19  Tom Tromey  <tromey@adacore.com>
5492
5493         * source-cache.c (highlighter): New global.
5494         (source_cache::get_source_lines): Create a highlighter on demand.
5495
5496 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * defs.h (deprecated_interactive_hook): Delete declaration.
5499         * interps.c (clear_interpreter_hooks): Remove use of
5500         deprecated_interactive_hook.
5501         * top.c (deprecated_interactive_hook): Delete definition.
5502         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5503
5504 2019-06-18  Tom de Vries  <tdevries@suse.de>
5505
5506         PR gdb/24515
5507         * dwarf2read.h (abstract_to_concrete): Change type from
5508         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5509         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5510         * dwarf2read.c (read_variable): Update.
5511         (dwarf2_fetch_die_loc_sect_off): Update.
5512
5513 2019-06-17  Tom de Vries  <tdevries@suse.de>
5514
5515         PR gdb/24617
5516         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5517         accessing parent[parent_len - 1].
5518
5519 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5520
5521         PR gdb/24364
5522         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5523         call dtrace_process_dof with NULL dof.
5524
5525 2019-06-16  Tom de Vries  <tdevries@suse.de>
5526
5527         PR gdb/24445
5528         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5529
5530 2019-06-16  Tom Tromey  <tom@tromey.com>
5531
5532         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5533         (make_all_visible): Use address of member.
5534
5535 2019-06-16  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5538         (tui_free_window, free_content, free_content_elements): Remove
5539         unnecessary cast.
5540         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5541         cast.
5542         * tui/tui-regs.c (tui_show_register_group)
5543         (tui_display_registers_from, tui_display_reg_element_at_line):
5544         Remove unnecessary cast.
5545
5546 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * linux-nat.c (normal_mask): Delete.
5549         (_initialize_linux_nat): Don't initialise normal_mask.
5550
5551 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5552
5553         PR gdb/24445
5554         * dwarf-index-write.h (write_psymtabs_to_index): Add
5555         dwz_basename parameter.
5556         * dwarf-index-write.c (write_gdbindex): Move file writing to
5557         write_gdbindex_1.  Change return type void.
5558         (assert_file_size): Move up, remove filename parameter.
5559         (write_gdbindex_1): New function.
5560         (write_debug_names): Change return type to void, call
5561         assert_file_size.
5562         (struct index_wip_file): New struct.
5563         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5564         file logic to index_wip_file.  Write index for dwz file if
5565         needed.
5566         (save_gdb_index_command): Pass basename of dwz file, if present.
5567         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5568         build-id of dwz file, if present.
5569         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5570         (dwarf2_get_dwz_file): Likewise.
5571         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5572         (dwarf2_get_dwz_file): Likewise.
5573
5574 2019-06-16  Tom Tromey  <tom@tromey.com>
5575
5576         * coffread.c (process_coff_symbol): Use xstrdup.
5577         * value.c (create_internalvar): Use xstrdup.
5578
5579 2019-06-16  Tom Tromey  <tom@tromey.com>
5580
5581         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5582         * breakpoint.c (stopin_command, stopat_command)
5583         (until_break_command, decode_location_default): Remove unnecessary
5584         cast.
5585         * utils.c (subset_compare): Remove unnecessary cast.
5586         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5587         cast.
5588         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5589         cast.
5590         * infcmd.c (path_command): Remove unnecessary cast.
5591         * coffread.c (decode_type): Remove unnecessary cast.
5592         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5593         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5594         * tui/tui-stack.c (tui_show_locator_content)
5595         (tui_show_frame_info): Remove unnecessary cast.
5596         * tui/tui-win.c (tui_scroll_forward_command)
5597         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5598         (parse_scrolling_args): Remove unnecessary cast.
5599         * tui/tui-data.c (init_win_info, tui_del_window)
5600         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5601         (free_content_elements): Remove unnecessary cast.
5602         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5603         unnecessary cast.
5604         * tui/tui-source.c (tui_set_source_content)
5605         (tui_vertical_source_scroll): Remove unnecessary cast.
5606         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5607         cast.
5608         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5609         * tui/tui-regs.c (tui_display_registers_from)
5610         (tui_display_register): Remove unnecessary cast.
5611         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5612         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5613         (make_visible): Remove unnecessary cast.
5614         * tui/tui-winsource.c (tui_erase_source_content)
5615         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5616         unnecessary cast.
5617         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5618         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5619         * stabsread.c (read_type, read_array_type, read_range_type):
5620         Remove unnecessary cast.
5621         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5622         (parse_symbol, parse_type, upgrade_type, parse_external)
5623         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5624         unnecessary cast.
5625         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5626
5627 2019-06-16  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-data.c (tui_alloc_generic_win_info)
5630         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5631         checks.
5632
5633 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5634             Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * f-typeprint.c (f_print_type): Don't return early for not
5637         associated or not allocated types.
5638         (f_type_print_varspec_suffix): Add print_rank parameter and print
5639         ranks of array types in case they dangling.
5640         (f_type_print_base): Add print_rank parameter.
5641
5642 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5643
5644         * NEWS: Mention new MI commands.
5645         * break-catch-throw.c (enum exception_event_kind): Move to
5646         breakpoint.h.
5647         (print_mention_exception_catchpoint): Output text as a single
5648         message.
5649         (catch_exception_command_1): Rename to...
5650         (catch_exception_event): ...this, make non-static, update header
5651         command, and change some parameter types.
5652         (catch_catch_command): Update for changes to
5653         catch_exception_command_1.
5654         (catch_throw_command): Likewise.
5655         (catch_rethrow_command): Likewise.
5656         * breakpoint.c (enum exception_event_kind): Delete.
5657         * breakpoint.h (enum exception_event_kind): Moved here from
5658         break-catch-throw.c.
5659         (catch_exception_event): Declare.
5660         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5661         (mi_cmd_catch_throw): New function.
5662         (mi_cmd_catch_rethrow): New function.
5663         (mi_cmd_catch_catch): New function.
5664         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5665         'catch-catch' entries.
5666         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5667         (mi_cmd_catch_rethrow): Declare.
5668         (mi_cmd_catch_catch): Declare.
5669
5670 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5671
5672         * annotate.c (annotate_source_line): Change return type to void,
5673         update implementation to match.
5674         * annotate.h (annotate_source_line): Change return type to void,
5675         update header comment.
5676         * stack.c (print_frame_info): Don't change what frame information
5677         is printed based on whether annotations are on or not.
5678
5679 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5680
5681         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5682         (annotate_source): Make static.
5683         (annotate_source_line): Moved from source.c and renamed from
5684         identify_source_line.  Update the return type.
5685         * annotate.h (annotate_source): Delete declaration.
5686         (annotate_source_line): Declaration moved from source.h, and
5687         renamed from identify_source_line.  Return type updated.
5688         * source.c (identify_source_line): Moved to annotate.c and renamed
5689         to annotate_source_line.
5690         (info_line_command): Remove check of annotation_level.
5691         * source.h (identify_source_line): Move declaration to annotate.h
5692         and rename to annotate_source_line.
5693         * stack.c: Add 'annotate.h' include.
5694         (print_frame_info): Remove check of annotation_level before
5695         calling annotate_source_line.
5696
5697 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5698
5699         * source-cache.c (source_cache::get_plain_source_lines): Use
5700         open_source_file_with_line_charpos instead of just
5701         open_source_file, remove call to find_source_lines.
5702         (source_cache::get_source_lines): Likewise.
5703         * source.c (find_source_lines): Make static.
5704         (get_filename_and_charpos): Renamed into...
5705         (open_source_file_with_line_charpos): ..this along with changes to
5706         return a scoped_fd, and some other minor clean ups.
5707         (identify_source_line): Use open_source_file_with_line_charpos.
5708         (search_command_helper): Use open_source_file_with_line_charpos
5709         instead of just open_source_file, remove call to
5710         find_source_lines.
5711         * source.h (open_source_file_with_line_charpos): Declare new
5712         function.
5713         (find_source_lines): Delete declaration.
5714
5715 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * source.c (get_filename_and_charpos): Remove fullname
5718         parameter.
5719         (identify_source_line): Update call to get_filename_and_charpos.
5720
5721 2019-06-14  Tom Tromey  <tromey@adacore.com>
5722
5723         PR gdb/24502:
5724         * ui-style.h (skip_ansi_escape): Update comment.
5725         * ui-file.h (class no_terminal_escape_file): New class.
5726         * ui-file.c (no_terminal_escape_file::write)
5727         (no_terminal_escape_file::puts): New methods.
5728         * cli/cli-logging.c (handle_redirections): Use
5729         no_terminal_escape_file.
5730
5731 2019-06-14  Tom Tromey  <tromey@adacore.com>
5732
5733         * NEWS: Move convenience variable news above Python news.
5734
5735 2019-06-14  Tom Tromey  <tom@tromey.com>
5736
5737         * gnulib: Move directory to top-level.
5738         * configure.ac: Don't configure gnulib.
5739         * configure: Rebuild.
5740         * common/common-defs.h: Use new path to gnulib.
5741         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5742         (GNULIB_H): Remove.
5743         (INCGNU): Look in new gnulib location.
5744         (HFILES_NO_SRCDIR): Remove gnulib files.
5745         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5746         (generated_files): Remove GNULIB_H.
5747         ($(LIBGNU), all-lib): Remove targets.
5748         (distclean): Don't mention GNULIB_BUILDDIR.
5749         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5750
5751 2019-06-14  Tom Tromey  <tromey@adacore.com>
5752
5753         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5754         Warn if symbol file does not provide any symbols.
5755
5756 2019-06-14  Tom Tromey  <tromey@adacore.com>
5757
5758         * source.c (find_and_open_source): Respect basenames_may_differ.
5759
5760 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * annotate.c (annotate_breakpoints_invalid): Make use of
5763         scoped_restore_terminal_state.
5764         (annotate_frames_invalid): Likewise.
5765
5766 2019-06-14  Tom Tromey  <tromey@adacore.com>
5767
5768         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5769         allow assignment to an internalvar.
5770
5771 2019-06-14  Tom Tromey  <tromey@adacore.com>
5772
5773         * ada-lex.l: Allow "_" in attribute names.
5774
5775 2019-06-14  Tom Tromey  <tromey@adacore.com>
5776
5777         PR gdb/24653:
5778         * regcache.c (registers_changed): Don't call alloca.
5779         * top.c (execute_command): Don't call alloca.
5780
5781 2019-06-13  Pedro Alves  <palves@redhat.com>
5782
5783         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5784         'expression'.  When parsing an expression, error out if there's
5785         junk after "unlimited".
5786         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5787         (do_set_command): Adjust calls to is_unlimited_literal.
5788
5789 2019-06-13  Pedro Alves  <palves@redhat.com>
5790
5791         * compile/compile.c (make_compile_options_def_group): Add braces
5792         around array_view initializer.
5793         * thread.c (make_thread_apply_all_options_def_group)
5794         (make_thread_apply_all_options_def_group): Likewise.
5795
5796 2019-06-13  Pedro Alves  <palves@redhat.com>
5797
5798         * NEWS (New commands): Mention "maint test-options
5799         require-delimiter", "maint test-options unknown-is-error", "maint
5800         test-options unknown-is-operand" and "maint show
5801         test-options-completion-result".
5802         (New command options, command completion): New section.
5803         (Completion improvements): New section.
5804         Mention that you can abbreviate "unlimited".
5805
5806 2019-06-13  Pedro Alves  <palves@redhat.com>
5807
5808         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5809         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5810         * unittests/cli-utils-selftests.c (test_parse_flags)
5811         (test_parse_flags_qcs): Delete.
5812         (test_cli_utils): Don't call deleted functions.
5813
5814 2019-06-13  Pedro Alves  <palves@redhat.com>
5815
5816         * thread.c: Include "cli/cli-option.h".
5817         (tp_array_compar_ascending): Global.
5818         (tp_array_compar): Delete function.
5819         (tp_array_compar_ascending, tp_array_compar_descending): New
5820         functions.
5821         (ascending_option_def, qcs_flag_option_def)
5822         (thr_qcs_flags_option_defs)
5823         (make_thread_apply_all_options_def_group)
5824         (make_thread_apply_options_def_group): New.
5825         (thread_apply_all_command): Use gdb::option::process_options.
5826         (thread_apply_command_completer)
5827         (thread_apply_all_command_completer): New.
5828         (thread_apply_command): Use gdb::option::process_options.
5829         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5830         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5831         to generate help text of "thread apply".  Adjust "taas"'s help.
5832         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5833         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5834
5835 2019-06-13  Pedro Alves  <palves@redhat.com>
5836
5837         * thread.c (thread_apply_command): Check for invalid TID with
5838         isdigit instead of !isalpha.
5839
5840 2019-06-13  Pedro Alves  <palves@redhat.com>
5841
5842         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5843         (validate_flags_qcs): New.
5844         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5845         (validate_flags_qcs): Declare.
5846         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5847         (make_frame_apply_options_def_group): New.
5848         (frame_apply_command_count): Process options with
5849         gdb::option::process_options.
5850         (frame_apply_completer): New.
5851         (frame_apply_level_completer, frame_apply_all_completer)
5852         (frame_apply_completer): New.
5853         (_initialize_stack): Update help of "frame apply", "frame apply
5854         level", "frame apply all" and "faas" to mention supported options
5855         and install command completers.
5856         * stack.h (frame_apply_all_completer): Declare.
5857         * thread.c: Include "stack.h".
5858         (tfaas_command): Add "--".
5859         (_initialize_thread): Update help "tfaas" to mention supported
5860         options and install command completer.
5861
5862 2019-06-13  Pedro Alves  <palves@redhat.com>
5863
5864         * completer.c (complete_nested_command_line): New.
5865         (gdb_completion_word_break_characters_throw): Add assertion.
5866         * completer.h (complete_nested_command_line): Declare.
5867
5868 2019-06-13  Pedro Alves  <palves@redhat.com>
5869
5870         * stack.c (parse_backtrace_qualifiers): New.
5871         (backtrace_command): Use it.
5872         (backtrace_command_completer): Complete on qualifiers.
5873
5874 2019-06-13  Pedro Alves  <palves@redhat.com>
5875
5876         * frame.c: Include "cli/cli-option.h.
5877         (user_set_backtrace_options): New.
5878         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5879         Delete.
5880         (get_prev_frame): Adjust.
5881         (boolean_option_def, uinteger_option_def)
5882         (set_backtrace_option_defs): New.
5883         (_initialize_frame): Adjust and use
5884         gdb::option::add_setshow_cmds_for_options to install "set
5885         backtrace past-main" and "set backtrace past-entry".
5886         * frame.h: Include "cli/cli-option.h".
5887         (struct frame_print_options): Forward declare.
5888         (print_frame_arguments_all, print_frame_arguments_scalars)
5889         (print_frame_arguments_none): Declare.
5890         (print_entry_values): Delete declaration.
5891         (struct frame_print_options, user_frame_print_options): New.
5892         (struct set_backtrace_options): New.
5893         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5894         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5895         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5896         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5897         (list_args_or_locals): Add frame_print_options parameter.
5898         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5899         * python/py-framefilter.c (enumerate_args): Pass down
5900         USER_FRAME_PRINT_OPTIONS.
5901         * stack.c: Include "cli/cli-option.h".
5902         (print_frame_arguments_all, print_frame_arguments_scalars)
5903         (print_frame_arguments_none): Declare.
5904         (print_raw_frame_arguments, print_entry_values): Delete.
5905         (user_frame_print_options): New.
5906         (boolean_option_def, enum_option_def, frame_print_option_defs):
5907         New.
5908         (struct backtrace_cmd_options): New.
5909         (bt_flag_option_def): New.
5910         (backtrace_command_option_defs): New.
5911         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5912         (print_frame_arg, read_frame_arg, print_frame_args)
5913         (print_frame_info, print_frame): Add frame_print_options parameter
5914         and use it.
5915         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5916         (backtrace_command_1): Add frame_print_options and
5917         backtrace_cmd_options parameters and use them.
5918         (make_backtrace_options_def_group): New.
5919         (backtrace_command): Process command options with
5920         gdb::option::process_options.
5921         (backtrace_command_completer): New.
5922         (_initialize_stack): Extend "backtrace"'s help to mention
5923         supported options.  Install completer for "backtrace".
5924         Install some settings commands with add_setshow_cmds_for_options.
5925
5926 2019-06-13  Pedro Alves  <palves@redhat.com>
5927
5928         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5929         and that "set/show print raw frame-arguments" are now deprecated.
5930
5931         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5932         command.
5933         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5934         * stack.c (_initialize_stack): Install "set/show print
5935         raw-frame-arguments", and deprecate "set/show print raw
5936         frame-arguments".
5937         * valprint.c (_initialize_valprint): Deprecate "set/show print
5938         raw".
5939
5940 2019-06-13  Pedro Alves  <palves@redhat.com>
5941
5942         * compile/compile.c (struct compile_options): New.
5943         (compile_flag_option_def, compile_command_option_defs)
5944         (make_compile_options_def_group): New.
5945         (compile_file_command): Handle options with
5946         gdb::option::process_options.
5947         (compile_file_command_completer): New function.
5948         (compile_code_command): Handle options with
5949         gdb::option::process_options.
5950         (compile_code_command_completer): New function.
5951         (_initialize_compiler): Install completers for "compile code" and
5952         "compile file".  Mention available options in "compile code" and
5953         "compile code"'s help.
5954         * completer.c (advance_to_completion_word): New, factored out from
5955         ...
5956         (advance_to_expression_complete_word_point): ... this.
5957         (advance_to_filename_complete_word_point): New.
5958         * completer.h (advance_to_filename_complete_word_point): New
5959         declaration.
5960
5961 2019-06-13  Pedro Alves  <palves@redhat.com>
5962
5963         * compile/compile.c: Include "cli/cli-option.h".
5964         (compile_print_value): Scope data pointer is now a
5965         value_print_options pointer; adjust.
5966         (compile_print_command): Process options.  Scope data pointer is
5967         now a value_print_options pointer; adjust.
5968         (_initialize_compile): Update "compile print"'s help to include
5969         supported options.  Install a completer for "compile print".
5970         * cp-valprint.c (show_vtblprint, show_objectprint)
5971         (show_static_field_print): Delete.
5972         (_initialize_cp_valprint): Don't install "set print
5973         static-members", "set print vtbl", "set print object" here.
5974         * printcmd.c: Include "cli/cli-option.h" and
5975         "common/gdb_optional.h".
5976         (print_command_parse_format): Rework to fill in a
5977         value_print_options instead of a format_data.
5978         (print_value): Change parameter type from format_data pointer to
5979         value_print_options reference.  Adjust.
5980         (print_command_1): Process options.  Adjust to pass down a
5981         value_print_options.
5982         (print_command_completer): New.
5983         (_initialize_printcmd): Install print_command_completer as
5984         handle_brkchars completer for the "print" command.  Update
5985         "print"'s help to include supported options.
5986         * valprint.c: Include "cli/cli-option.h".
5987         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5988         here from cp-valprint.c.
5989         (boolean_option_def, uinteger_option_def)
5990         (value_print_option_defs, make_value_print_options_def_group):
5991         New.  Use gdb::option::add_setshow_cmds_for_options to install
5992         "set print elements", "set print null-stop", "set print repeats",
5993         "set print pretty", "set print union", "set print array", "set
5994         print address", "set print symbol", "set print array-indexes".
5995         * valprint.h: Include <string> and "cli/cli-option.h".
5996         (make_value_print_options_def_group): Declare.
5997         (print_value): Change parameter type from format_data pointer to
5998         value_print_options reference.
5999         (print_command_completer): Declare.
6000
6001 2019-06-13  Pedro Alves  <palves@redhat.com>
6002
6003         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6004         (COMMON_SFILES): Add maint-test-settings.c.
6005         * cli/cli-decode.c (boolean_enums): New global, factored out from
6006         ...
6007         (add_setshow_boolean_cmd): ... here.
6008         * cli/cli-decode.h (boolean_enums): Declare.
6009         * cli/cli-option.c: New file.
6010         * cli/cli-option.h: New file.
6011         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6012         factored out from ...
6013         (parse_cli_boolean_value(const char *)): ... this.
6014         (is_unlimited_literal): Change parameter type to pointer to
6015         pointer.  Adjust and advance ARG pointer.
6016         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6017         (parse_cli_var_enum): New, factored out from ...
6018         (do_set_command): ... this.  Adjust.
6019         * cli/cli-setshow.h (parse_cli_boolean_value)
6020         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6021         (parse_cli_var_enum): Declare.
6022         * cli/cli-utils.c: Include "cli/cli-option.h".
6023         (get_ulongest): New.
6024         * cli/cli-utils.h (get_ulongest): Declare.
6025         (check_for_argument): New overloads.
6026         * maint-test-options.c: New file.
6027
6028 2019-06-13  Pedro Alves  <palves@redhat.com>
6029
6030         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6031         parse a range if "-" is at the end of the string.
6032
6033 2019-06-13  Pedro Alves  <palves@redhat.com>
6034
6035         * cli/cli-setshow.c (parse_auto_binary_operation)
6036         (parse_cli_boolean_value): Don't allow "o".
6037
6038 2019-06-13  Pedro Alves  <palves@redhat.com>
6039
6040         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6041         * NEWS: Mention maint test-settings KIND.
6042         * maint-test-settings.c: New file.
6043
6044 2019-06-13  Pedro Alves  <palves@redhat.com>
6045
6046         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6047         completer.
6048         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6049         "set" completers.
6050
6051 2019-06-13  Pedro Alves  <palves@redhat.com>
6052
6053         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6054         after item.
6055
6056 2019-06-13  Pedro Alves  <palves@redhat.com>
6057
6058         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6059
6060 2019-06-13  Pedro Alves <palves@redhat.com>
6061
6062         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6063         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6064         call.
6065         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6066         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6067         calls.
6068         (check_for_argument): Skip spaces after argument.
6069
6070 2019-06-13  Pedro Alves  <palves@redhat.com>
6071
6072         * thread.c (thread_apply_command): Adjust TID parsing.
6073         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6074         detected before end of string.
6075         (tid_is_in_list): Error out if LIST is invalid.
6076
6077 2019-06-13  Pedro Alves  <palves@redhat.com>
6078
6079         * completer.c (complete_line_internal_1): Rewind completion word
6080         point.
6081         (completion_tracker::advance_custom_word_point_by): Change
6082         parameter type to int.
6083         * completer.h (completion_tracker::advance_custom_word_point_by):
6084         Likewise.
6085
6086 2019-06-13  Pedro Alves  <palves@redhat.com>
6087
6088         * completer.c (advance_to_completion_word): Handle delimiters.
6089
6090 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6091
6092         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6093
6094 2019-06-11  Tom Tromey  <tom@tromey.com>
6095
6096         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6097         (xmalloc_failed): Move to alloc.c.
6098         * alloc.c: New file.
6099         * Makefile.in (COMMON_SFILES): Add alloc.c.
6100
6101 2019-06-11  Tom Tromey  <tom@tromey.com>
6102
6103         * nat/linux-waitpid.c: Don't include server.h.
6104         (linux_debug): Remove.
6105         (my_waitpid): Update.
6106
6107 2019-06-11  Tom Tromey  <tromey@adacore.com>
6108
6109         * infcall.c (_initialize_infcall): Remove trailing newline from
6110         help.
6111         * user-regs.c (_initialize_user_regs): Remove trailing newline
6112         from help.
6113         * typeprint.c (_initialize_typeprint): Remove trailing newline
6114         from help.
6115         * reverse.c (_initialize_reverse): Remove trailing newlines from
6116         help.
6117         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6118         from help.
6119         * language.c (add_set_language_command): Remove trailing newline
6120         from help.
6121         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6122         help.
6123         * disasm.c (_initialize_disasm): Remove trailing newline from
6124         help.
6125         * top.c (init_main): Remove trailing newline from help.
6126         * interps.c (_initialize_interpreter): Remove trailing newline
6127         from help.
6128         * btrace.c (_initialize_btrace): Remove trailing newlines from
6129         help.
6130         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6131         from help.
6132         * python/python.c (_initialize_python): Remove trailing newline
6133         from help.
6134         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6135         help.
6136         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6137         from help.  Reformat some text.
6138         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6139         from help.
6140         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6141         newline from help.
6142
6143 2019-06-11  Tom Tromey  <tromey@adacore.com>
6144
6145         * darwin-nat.c (darwin_decode_exception_message)
6146         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6147
6148 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * valops.c (value_slice): Check for not allocated or not
6151         associated values.
6152
6153 2019-06-10  Tom de Vries  <tdevries@suse.de>
6154
6155         PR gdb/24618
6156         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6157         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6158         invalid.
6159
6160 2019-06-10  Tom de Vries  <tdevries@suse.de>
6161
6162         PR gdb/24611
6163         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6164         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6165
6166 2019-06-10  Tom de Vries  <tdevries@suse.de>
6167
6168         PR symtab/24545
6169         * symtab.c (struct demangled_name_entry): Add language field.
6170         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6171         static minimal symbol".  Set and use language field.
6172
6173 2019-06-10  Tom Tromey  <tromey@adacore.com>
6174
6175         * ada-lang.c (_initialize_ada_language): Update help text.
6176
6177 2019-06-10  Tom Tromey  <tromey@adacore.com>
6178
6179         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6180         with a newline.
6181         * guile/guile.c (handle_boot_error): Don't end warning with a
6182         newline.
6183         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6184         warning with a newline.
6185         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6186         newline.
6187         (s12z_frame_cache): Likewise.
6188         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6189         a newline.
6190         * solib-svr4.c (disable_probes_interface): Don't end warning with
6191         a newline.
6192         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6193         newline.
6194         * python/python.c (do_finish_initialization): Don't end warning
6195         with a newline.
6196
6197 2019-06-10  Tom Tromey  <tom@tromey.com>
6198
6199         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6200         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6201         gdbpy_enter.
6202
6203 2019-06-10  Tom Tromey  <tromey@adacore.com>
6204
6205         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6206         data.
6207         (elf_new_init): Don't call stabsread_new_init.
6208         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6209         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6210         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6211
6212 2019-06-10  Tom de Vries  <tdevries@suse.de>
6213
6214         PR symtab/16264
6215         PR symtab/24517
6216         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6217
6218 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6219
6220         * source.c (find_and_open_source): Also rewrite relative file
6221         names.
6222
6223 2019-04-26  Amos Bird  <amosbird@gmail.com>
6224
6225         * annotate.c (annotate_thread_exited): Add "thread-exited"
6226         annotation.
6227
6228 2019-06-06  Tom Tromey  <tromey@adacore.com>
6229
6230         * maint.h (class scoped_command_stats): Use
6231         DISABLE_COPY_AND_ASSIGN.
6232         <print_time>: New method.
6233         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6234         print_time.
6235         (scoped_command_stats::print_time): New method.
6236
6237 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6240         instructions of lengths 6 or 8 bytes.
6241
6242 2019-06-04  Pedro Alves  <palves@redhat.com>
6243
6244         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6245
6246         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6247         * breakpoint.c (condition_completer): Likewise.
6248         * cli/cli-dump.c (scan_expression): Likewise.
6249         * common/filestuff.c (mkdir_recursive): Likewise.
6250         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6251         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6252         (gdb_abspath): Likewise.
6253         * compile/compile-cplus-types.c
6254         (compile_cplus_instance::decl_name): Likewise.
6255         * completer.c (complete_explicit_location):
6256         (signal_completer, reg_or_group_completer_1): Likewise.
6257         * cp-support.c (cp_remove_params_if_any): Likewise.
6258         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6259         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6260         * infcmd.c (strip_bg_char): Likewise.
6261         * linespec.c (copy_token_string): Likewise.
6262         * mi/mi-main.c (output_cores): Likewise.
6263         * psymtab.c (psymtab_search_name):
6264         * symfile.c (test_set_ext_lang_command): Likewise.
6265         * target.c (target_fileio_read_stralloc): Likewise.
6266         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6267         * value.c (complete_internalvar): Likewise.
6268
6269 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6270
6271         Add objfile property to gdb.Type.
6272         * NEWS: Mention Python API addition.
6273         * python/py-type.c (typy_get_objfile): New method.
6274
6275 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6276
6277         * NEWS: Mention the new set|show style [title|highlight].
6278         Mention changes to "show style", "help" and "apropos".
6279
6280 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6281
6282         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6283         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6284         instead of print_help_for_command.
6285         (print_doc_of_command): New function.
6286         (help_list): Add 'apropos -v word' suggestion.
6287         (print_help_for_command): Style the command name using title style.
6288         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6289         (_initialize_cli_cmds): Describe -v in apropos_command help.
6290
6291 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6292
6293         * cli/cli-style.h (cli_style_option): Add name in constructor,
6294         add m_name class member, add constructor with intensity,
6295         add name class function.
6296         (cli_style_option::add_setshow_commands): Remove name argument.
6297         (highlight_style, title_style): New styles.
6298         * cli/cli-style.c (do_show): New function that shows a style
6299         characteristic styling the style name with itself.
6300         (set_style_name): New function.
6301         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6302         Update all callers according to the changes in cli/cli-style.h.
6303         * utils.h (fputs_highlighted): New function.
6304         * utils.c (fputs_highlighted): Likewise.
6305
6306 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6307
6308         * NEWS: Mention new pipe command and new convenience variables.
6309
6310 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6311
6312         * cli/cli-cmds.c (pipe_command): New function.
6313         (_initialize_cli_cmds): Call add_com for pipe_command.
6314         Define | as an alias for pipe.
6315         (exit_status_set_internal_vars): New function.
6316         (shell_escape): Call exit_status_set_internal_vars.
6317         cli/cli-decode.c (find_command_name_length): Recognize | as
6318         a single character command.
6319
6320 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321
6322         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6323         top.c (execute_command_to_ui_file): New function, mostly a copy
6324         of execute_command_to_string.
6325         (execute_command_to_string): Implement by calling
6326         execute_command_to_ui_file.
6327
6328 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6329
6330         * top.h (saved_command_line): Remove declaration.
6331         * top.c (previous_saved_command_line, previous_repeat_arguments):
6332         New variables.
6333         (saved_command_line): Make static, define together with other
6334         'repeat variables'.
6335         (dont_repeat): Clear repeat_arguments.
6336         (repeat_previous, get_saved_command_line, save_command_line):
6337         New functions.
6338         (gdb_init): Initialize saved_command_line
6339         and previous_saved_command_line.
6340         * main.c (captured_main_1): Remove saved_command_line initialization.
6341         * event-top.c (handle_line_of_input): Update to use
6342         the new 'repeat' related functions instead of direct access to
6343         saved_command_line.
6344         * command.h (repeat_previous, get_saved_command_line,
6345         save_command_line): New declarations.
6346         (dont_repeat): Add comment.
6347
6348 2019-05-30  Tom Tromey  <tromey@adacore.com>
6349
6350         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6351         Fix comment.
6352         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6353
6354 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6355
6356         PR cli/24587
6357         * completer.c (complete): Initialize variable word.
6358
6359 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6360
6361         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6362         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6363         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6364         'body' is NULL to the outter 'if', protecting the '!is_define'
6365         situation as well.
6366
6367 2019-05-29  Tom Tromey  <tromey@adacore.com>
6368
6369         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6370         (dwarf_unknown): New function.
6371         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6372         (dwarf_type_encoding_name): Use dwarf_unknown.
6373
6374 2019-05-29  Tom Tromey  <tromey@adacore.com>
6375
6376         PR c++/20020:
6377         * cp-valprint.c (cp_print_value_fields): Call
6378         cp_print_static_field inside "try".
6379
6380 2019-05-29  Tom Tromey  <tromey@adacore.com>
6381
6382         * inflow.c (struct terminal_info): Add default operator=.
6383         * configure: Rebuild.
6384         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6385         -Wdeprecated-copy-dtor, -Wredundant-move.
6386
6387 2019-05-29  Tom Tromey  <tromey@adacore.com>
6388
6389         * NEWS: Add entry.
6390         * infcmd.c (print_return_value_1): Handle finish_print
6391         option.
6392         (show_print_finish): New function.
6393         (_initialize_infcmd): Add "set/show print finish" commands.
6394         * valprint.c (user_print_options): Initialize new member.
6395         * valprint.h (struct value_print_options) <finish_print>: New
6396         member.
6397
6398 2019-05-28  Tom Tromey  <tromey@adacore.com>
6399
6400         * ada-lang.c (ada_remove_Xbn_suffix)
6401         (find_old_style_renaming_symbol)
6402         (parse_old_style_renaming): Remove.
6403         (ada_find_renaming_symbol): Don't call
6404         find_old_style_renaming_symbol.
6405         (ada_is_renaming_symbol): Rename from
6406         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6407         bool.  Now static.
6408         (ada_read_var_value): Update and simplify.
6409         * ada-exp.y (write_var_or_type): Remove old code.
6410
6411 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6412
6413         * event-top.c: Remove include comment.
6414         * inflow.c (class scoped_ignore_sigttou): Move from here...
6415         * inflow.h (class scoped_ignore_sigttou): ...to here.
6416         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6417         * top.c:  Remove include comment.
6418
6419 2019-05-27  Tom Tromey  <tom@tromey.com>
6420
6421         * NEWS: Fix typo.
6422
6423 2019-05-22  Tom Tromey  <tromey@adacore.com>
6424
6425         * target.c (target_follow_exec): Constify parameter.
6426         * target-delegates.c: Rebuild.
6427         * remote.c (remote_target::follow_exec): Constify parameter.
6428         * infrun.c (follow_exec): Constify parameter.
6429         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6430         (target_follow_exec): Likewise.
6431
6432 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6433
6434         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6435         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6436
6437 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6438
6439         * NEWS: Add debugredirect and testsuite sections.
6440
6441 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6442
6443         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6444         target descriptions using exclusively floating point register name
6445         aliases.
6446
6447 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         PR gdb/18644:
6450         * f-lang.c (build_fortran_types): Handle the case where
6451         gdbarch_floatformat_for_type returns a nullptr.
6452
6453 2019-05-21  Tom de Vries  <tdevries@suse.de>
6454
6455         PR cli/24587
6456         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6457
6458 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         PR gdb/18644:
6461         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6462         16-byte floats.
6463         * i386-tdep.c (i386_floatformat_for_type): Use
6464         floatformats_ia64_quad for the 16-byte floating point component
6465         within a fortran 32-byte complex number.
6466
6467 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6470         delete default constructor.
6471         (find_partial_die): Update to return const struct.
6472         (partial_die_parent_scope): Move variable declaration into scope
6473         of its use and change its type to auto.
6474         (guess_partial_die_structure_name): Likewise.
6475         (partial_die_info::fixup): Likewise.
6476
6477 2019-05-17  Tom Tromey  <tromey@adacore.com>
6478
6479         * source.c (find_and_open_source): Remove cast.
6480
6481 2019-05-17  Tom Tromey  <tromey@adacore.com>
6482
6483         * annotate.c (annotate_source): Make "filename" const.
6484         * annotate.h (annotate_source): Use const.
6485
6486 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6487
6488         * disasm.c (set_disassembler_options): Send errors to stderr.
6489
6490 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6491
6492         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6493         (cli_interp_base::set_logging): Check debug_redirect.
6494         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6495         * cli/cli-logging.c (debug_redirect): Add static variable.
6496         (pop_output_files): Add default param.
6497         (handle_redirections): Print debug setting.
6498         (show_logging_command): Likewise.
6499         (_initialize_cli_logging): Add debugredirect command.
6500         * interps.c (current_interp_set_logging): Add debug_redirect
6501         parameter.
6502         * interps.h (set_logging): Add debug_redirect parameter.
6503         (current_interp_set_logging): Likewise.
6504         * mi/mi-common.h: Likewise.
6505         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6506
6507 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6508             Tom Tromey  <tromey@adacore.com>
6509
6510         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6511         directly.
6512         * cli/cli-interp.h (make_logging_output): Remove declaration.
6513         * cli/cli-logging.c (make_logging_output): Remove function.
6514         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6515         directly.
6516         * ui-file.c (tee_file::tee_file): Remove bools.
6517         (tee_file::~tee_file): Remove deletes.
6518         * ui-file.h (tee_file): Remove bools.
6519
6520 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6521
6522         * mi/mi-cmds.h (mi_cmd_complete): New function.
6523         * mi/mi-main.c (mi_cmd_complete): Likewise.
6524         * mi/mi-cmds.c: Define new MI command -complete.
6525         * NEWS: Mention new -complete command.
6526
6527 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6528
6529         * completer.h (complete): New function.
6530         * completer.c (complete): Likewise.
6531         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6532         function defined in completer.h.
6533
6534 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6535
6536         * MAINTAINERS (Write After Approval): Add myself.
6537
6538 2019-05-17  Tom de Vries  <tdevries@suse.de>
6539
6540         PR gdb/24094
6541         * dwarf2read.c (struct cu_partial_die_info): New struct.
6542         (find_partial_die): Return cu_partial_die_info.
6543         (partial_die_parent_scope, guess_partial_die_structure_name)
6544         (partial_die_info::fixup): Handle new return type of find_partial_die.
6545
6546 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6547
6548         PR breakpoints/24541
6549         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6550         "std::string", simplifying the algorithm.
6551
6552 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6553
6554         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6555         (stap_static_probe_ops::get_probes): Likewise.
6556
6557 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6558
6559         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6560         '-')" and "else if".
6561         (stap_parse_single_operand): Join checks for
6562         "gdbarch_stap_parse_special_token_p" and
6563         "gdbarch_stap_parse_special_token" in the same "if" statement.
6564         Invert check when verifying for operation on register
6565         displacement.
6566
6567 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6568
6569         * stap-probe.c (stap_get_opcode): Update comment.
6570         (stap_get_expected_argument_type): Likewise.
6571         (handle_stap_probe): Likewise.
6572
6573 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6574
6575         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6576         return type to 'bool'.  Adjust comment.  Use 'bool' when
6577         appropriate.
6578         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6579         * stap-probe.c (stap_parse_argument_1): Likewise.
6580         (stap_is_operator): Likewise.
6581         (stap_is_generic_prefix): Likewise.
6582         (stap_is_register_prefix): Likewise.
6583         (stap_is_register_indirection_prefix): Likewise.
6584         (stap_is_integer_prefix): Likewise.
6585         (stap_generic_check_suffix): Likewise.
6586         (stap_check_integer_suffix): Likewise.
6587         (stap_check_register_suffix): Likewise.
6588         (stap_check_register_indirection_suffix): Likewise.
6589         (stap_parse_register_operand): Likewise.
6590         (stap_parse_single_operand): Likewise.
6591         (stap_parse_argument_1): Likewise.
6592         (stap_probe::get_argument_count): Likewise.
6593         (stap_is_operator): Likewise.
6594
6595 2019-05-16  Tom Tromey  <tromey@adacore.com>
6596
6597         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6598         keyword to foreach.
6599
6600 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6601
6602         * linux-thread-db.c (try_thread_db_load_1): Change return type
6603         to bool.
6604         (try_thread_db_load): Likewise.
6605         (try_thread_db_load_from_pdir_1): Likewise.
6606         (try_thread_db_load_from_pdir): Likewise.
6607         (try_thread_db_load_from_sdir): Likewise.
6608         (try_thread_db_load_from_dir): Likewise.
6609         (thread_db_load_search): Likewise.
6610         (has_libpthread): Likewise.
6611         (thread_db_load): Likewise.
6612
6613 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6614
6615         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6616         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6617         NULL, and complain/return if that's the case.
6618
6619 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6620
6621         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6622         (advance, posn, abstract_read_memory): New functions.
6623         [struct mem_read_abstraction]: New struct.
6624         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6625
6626 2019-05-14  Tom Tromey  <tromey@adacore.com>
6627
6628         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6629         value is not lval_memory.
6630
6631 2019-05-14  Tom Tromey  <tromey@adacore.com>
6632
6633         * solib.c (info_sharedlibrary_command): Style the file name.
6634
6635 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6636
6637         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6638         (aarch64_vnv_type): Likewise.
6639         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6640         * common/tdesc.c: Likewise.
6641         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6642         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6643         * features/aarch64-fpu.xml: Add ieee half view.
6644         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6645         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6646         * gdbtypes.h (struct builtin_type): Likewise.
6647         (struct objfile_type): Likewise.
6648
6649 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6650
6651         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6652         typo.
6653         * location.h (string_to_event_location): Likewise.
6654
6655 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6656
6657         GDB 8.3 released.
6658
6659 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6660
6661         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6662         New variable declaration.
6663         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6664         New variable.
6665         (print_one_breakpoint): Use ui_out::test_flags and new global
6666         variable to compute use_fixed_output.
6667         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6668         Remove.
6669         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6670         (mi_multi_location_breakpoint_output_fixed): Remove.
6671         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6672         new variable.
6673         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6674         fix_multi_location_breakpoint_output flag if version >= 3.
6675         * ui-out.h (enum ui_out_flag)
6676         <fix_multi_location_breakpoint_output>: New enumerator.
6677
6678 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6679
6680         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6681
6682 2019-05-10  Tom Tromey  <tromey@adacore.com>
6683
6684         * ada-lang.c (catch_ada_completer): New function.
6685         (_initialize_ada_language): Use it.
6686
6687 2019-05-10  Tom Tromey  <tromey@adacore.com>
6688
6689         * thread.c (print_thread_info): Make "requested_threads" const.
6690         * gdbthread.h (print_thread_info): Make "requested_threads"
6691         const.
6692         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6693         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6694
6695 2019-05-08  Tom Tromey  <tom@tromey.com>
6696
6697         * gdbtypes.c (objfile_type_data): Change type.
6698         (objfile_type, _initialize_gdbtypes): Update.
6699
6700 2019-05-08  Tom Tromey  <tom@tromey.com>
6701
6702         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6703         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6704         (_initialize_dwarf2_frame): Update.
6705
6706 2019-05-08  Tom Tromey  <tom@tromey.com>
6707
6708         * objc-lang.c (objc_objfile_data): Change type.
6709         (find_methods): Update.
6710         (_initialize_objc_lang): Remove.
6711
6712 2019-05-08  Tom Tromey  <tom@tromey.com>
6713
6714         * stabsread.c (rs6000_builtin_type_data): Change type.
6715         (rs6000_builtin_type, _initialize_stabsread): Update.
6716
6717 2019-05-08  Tom Tromey  <tom@tromey.com>
6718
6719         * mips-tdep.c (mips_pdr_data): Remove.
6720         (_initialize_mips_tdep): Update.
6721
6722 2019-05-08  Tom Tromey  <tom@tromey.com>
6723
6724         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6725         (hppa_init_objfile_priv_data, read_unwind_info)
6726         (find_unwind_entry, _initialize_hppa_tdep): Update.
6727
6728 2019-05-08  Tom Tromey  <tom@tromey.com>
6729
6730         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6731         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6732         on obstack.
6733         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6734
6735 2019-05-08  Tom Tromey  <tom@tromey.com>
6736
6737         * mdebugread.c (basic_type_data): Change type.
6738         (basic_type, _initialize_mdebugread): Update.
6739
6740 2019-05-08  Tom Tromey  <tom@tromey.com>
6741
6742         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6743
6744 2019-05-08  Tom Tromey  <tom@tromey.com>
6745
6746         * nto-tdep.c (nto_inferior_data_reg): Change type.
6747         (nto_inferior_data): Update.
6748         (nto_inferior_data_cleanup, nto_new_inferior_data)
6749         (_initialize_nto_tdep): Remove.
6750         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6751
6752 2019-05-08  Tom Tromey  <tom@tromey.com>
6753
6754         * ada-lang.c (struct ada_inferior_data): Add initializers.
6755         (ada_inferior_data): Change type.
6756         (ada_inferior_data_cleanup): Remove.
6757         (get_ada_inferior_data, ada_inferior_exit)
6758         (struct ada_pspace_data): Add initializers, destructor.
6759         (ada_pspace_data_handle): Change type.
6760         (get_ada_pspace_data): Update.
6761         (ada_pspace_data_cleanup): Remove.
6762
6763 2019-05-08  Tom Tromey  <tom@tromey.com>
6764
6765         * coffread.c (struct coff_symfile_info): Add initializers.
6766         (coff_objfile_data_key): Move lower.  Change type.
6767         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6768         Update.
6769         (coff_free_info): Remove.
6770
6771 2019-05-08  Tom Tromey  <tom@tromey.com>
6772
6773         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6774         (fbsd_pspace_data_handle): Move lower.  Change type.
6775         (get_fbsd_pspace_data): Update.
6776         (fbsd_pspace_data_cleanup): Remove.
6777         (_initialize_fbsd_tdep): Update.
6778
6779 2019-05-08  Tom Tromey  <tom@tromey.com>
6780
6781         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6782         (get_ada_tasks_pspace_data): Update.
6783         (ada_tasks_pspace_data_cleanup): Remove.
6784         (_initialize_tasks): Update.
6785         (ada_tasks_inferior_data_handle): Change type.
6786         (get_ada_tasks_inferior_data): Update.
6787         (ada_tasks_inferior_data_cleanup): Remove.
6788         (struct ada_tasks_pspace_data): Add initializers.
6789
6790 2019-05-08  Tom Tromey  <tom@tromey.com>
6791
6792         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6793         * symfile-debug.c (debug_sym_get_probes): Change type.
6794         * stap-probe.c (handle_stap_probe):
6795         (stap_static_probe_ops::get_probes): Change type.
6796         * probe.h (class static_probe_ops) <get_probes>: Change type.
6797         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6798         (parse_probes_in_pspace): Update.
6799         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6800         Update.
6801         (any_static_probe_ops::get_probes): Change type.
6802         * elfread.c (elfread_data): New typedef.
6803         (probe_key): Change type.
6804         (elf_get_probes): Likewise.  Update.
6805         (probe_key_free): Remove.
6806         (_initialize_elfread): Update.
6807         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6808         Change type.
6809         (dtrace_process_dof_probe, dtrace_process_dof)
6810         (dtrace_static_probe_ops::get_probe): Change type.
6811
6812 2019-05-08  Tom Tromey  <tom@tromey.com>
6813
6814         * xcoffread.c (struct xcoff_symfile_info): Rename from
6815         coff_symfile_info.  Add initializers.
6816         (xcoff_objfile_data_key): Move lower.  Change type.
6817         (XCOFF_DATA): Rewrite.
6818         (xcoff_free_info): Remove.
6819         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6820         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6821         (xcoff_initial_scan): Update.
6822
6823 2019-05-08  Tom Tromey  <tom@tromey.com>
6824
6825         * solib-svr4.c (struct svr4_info): Add initializers and
6826         destructor.
6827         <probes_table>: Now an htab_up.
6828         (solib_svr4_pspace_data): Change type.
6829         (free_probes_table): Simplify.
6830         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6831         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6832         (probes_table_remove_objfile_probes, register_solib_event_probe)
6833         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6834         (_initialize_svr4_solib): Update.
6835
6836 2019-05-08  Tom Tromey  <tom@tromey.com>
6837
6838         * remote.c (remote_pspace_data): Change type.
6839         (remote_pspace_data_cleanup): Remove.
6840         (get_remote_exec_file, set_pspace_remote_exec_file)
6841         (_initialize_remote): Update.
6842
6843 2019-05-08  Tom Tromey  <tom@tromey.com>
6844
6845         * breakpoint.c (breakpoint_objfile_key): Change type.
6846         (get_breakpoint_objfile_data): Update.
6847         (free_breakpoint_objfile_data): Remove.
6848         (_initialize_breakpoint): Update.
6849
6850 2019-05-08  Tom Tromey  <tom@tromey.com>
6851
6852         * linux-tdep.c (struct linux_info): Add initializers.
6853         (linux_inferior_data): Move.  Change type.
6854         (invalidate_linux_cache_inf): Update.
6855         (linux_inferior_data_cleanup): Remove.
6856         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6857
6858 2019-05-08  Tom Tromey  <tom@tromey.com>
6859
6860         * auxv.c (auxv_inferior_data): Move.  Change type.
6861         (auxv_inferior_data_cleanup): Remove.
6862         (invalidate_auxv_cache_inf): Rewrite.
6863         (get_auxv_inferior_data, _initialize_auxv): Update.
6864
6865 2019-05-08  Tom Tromey  <tom@tromey.com>
6866
6867         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6868         (symfile_debug_objfile_data_key): Change type.
6869         (symfile_debug_installed, debug_qf_has_symbols)
6870         (debug_qf_find_last_source_symtab)
6871         (debug_qf_forget_cached_source_info)
6872         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6873         (debug_qf_print_stats, debug_qf_dump)
6874         (debug_qf_expand_symtabs_for_function)
6875         (debug_qf_expand_all_symtabs)
6876         (debug_qf_expand_symtabs_with_fullname)
6877         (debug_qf_map_matching_symbols)
6878         (debug_qf_expand_symtabs_matching)
6879         (debug_qf_find_pc_sect_compunit_symtab)
6880         (debug_qf_map_symbol_filenames)
6881         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6882         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6883         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6884         (debug_sym_read_linetable, debug_sym_relocate): Update.
6885         (symfile_debug_free_objfile): Remove.
6886         (install_symfile_debug_logging, _initialize_symfile_debug):
6887         Update.
6888
6889 2019-05-08  Tom Tromey  <tom@tromey.com>
6890
6891         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6892         allocate_on_obstack.
6893         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6894         (get_dwarf2_per_objfile): Update.
6895         (set_dwarf2_per_objfile): Remove.
6896         (dwarf2_has_info, dwarf2_get_section_info): Update.
6897         (dwarf2_free_objfile): Remove.
6898         (_initialize_dwarf2_read): Update.
6899
6900 2019-05-08  Tom Tromey  <tom@tromey.com>
6901
6902         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6903         initializers.
6904         <unsupported_script_warning_printed,
6905         script_not_found_warning_printed>: Now bool.
6906         (auto_load_pspace_data): Change type.
6907         (~auto_load_pspace_info): Rename from
6908         auto_load_pspace_data_cleanup.
6909         (get_auto_load_pspace_data, init_loaded_scripts_info)
6910         (clear_section_scripts, maybe_print_unsupported_script_warning)
6911         (maybe_print_script_not_found_warning, _initialize_auto_load):
6912         Update.
6913
6914 2019-05-08  Tom Tromey  <tom@tromey.com>
6915
6916         * objfiles.c (objfile_pspace_info): Add destructor and
6917         initializers.
6918         (objfiles_pspace_data): Change type.
6919         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6920         (get_objfile_pspace_data): Update.
6921         (objfiles_bfd_data): Change type.
6922         (get_objfile_bfd_data): Update.
6923         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6924
6925 2019-05-08  Tom Tromey  <tom@tromey.com>
6926
6927         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6928         Change type.
6929         (get_catch_syscall_inferior_data): Update.
6930         (catch_syscall_inferior_data_cleanup): Remove.
6931         (_initialize_break_catch_syscall): Update.
6932
6933 2019-05-08  Tom Tromey  <tom@tromey.com>
6934
6935         * inflow.c (struct terminal_info): Add destructor and
6936         initializers.
6937         (inflow_inferior_data): Change type.
6938         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6939         (get_inflow_inferior_data, inflow_inferior_exit)
6940         (swap_terminal_info, _initialize_inflow): Update.
6941
6942 2019-05-08  Tom Tromey  <tom@tromey.com>
6943
6944         * target-dcache.c (target_dcache_cleanup): Remove.
6945         (target_dcache_aspace_key): Change type.
6946         (target_dcache_init_p, target_dcache_invalidate)
6947         (target_dcache_get, target_dcache_get_or_init)
6948         (_initialize_target_dcache): Update.
6949         * dcache.h (struct dcache_deleter): New.
6950
6951 2019-05-08  Tom Tromey  <tom@tromey.com>
6952
6953         * symtab.c (struct symbol_cache): Add destructor and
6954         initializers.
6955         (symbol_cache_key): Move.  Change type.
6956         (make_symbol_cache, free_symbol_cache): Remove.
6957         (get_symbol_cache): Update.
6958         (symbol_cache_cleanup): Remove.
6959         (ALL_PSPACES, symbol_cache_flush)
6960         (maintenance_print_symbol_cache)
6961         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6962         Update.
6963
6964 2019-05-08  Tom Tromey  <tom@tromey.com>
6965
6966         * symtab.c (struct main_info): Add destructor and initializers.
6967         (main_progspace_key): Move.  Change type.
6968         (get_main_info): Update.
6969         (main_info_cleanup): Remove.
6970         (_initialize_symtab): Update.
6971
6972 2019-05-08  Tom Tromey  <tom@tromey.com>
6973
6974         * registry.h (DECLARE_REGISTRY): Define the _key class.
6975
6976 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * NEWS: Merge two 'New commands' sections.
6979
6980 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6981
6982         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6983         parameter and use Ada language definition instead.
6984         (ada_val_print_ptr): Remove unused language parameter.
6985         (ada_val_print_num): Remove language parameter and use Ada language
6986         definition instead.
6987         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6988         parameter.
6989         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6990         parameter and use Ada language definition instead.
6991         (ada_val_print_1): Update all ada_val_print_xxx calls.
6992         Remove language parameter.
6993         (ada_val_print): Update ada_val_print_1 call.
6994
6995 2019-05-08  Tom Tromey  <tromey@adacore.com>
6996
6997         * remote.c (remote_hw_watchpoint_limit)
6998         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6999         Now static.
7000
7001 2019-05-08  Tom Tromey  <tromey@adacore.com>
7002
7003         * maint.c (_initialize_maint_cmds): Move initialization code to
7004         remote.c.
7005         (watchdog, show_watchdog): Move to remote.c.
7006         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7007         "watchdog" static.
7008         (_initialize_remote): Move initialization code from maint.c.
7009         * defs.h (watchdog): Don't declare.
7010
7011 2019-05-08  Tom Tromey  <tromey@adacore.com>
7012
7013         * tui/tui-interp.c: Include main.h.
7014         * interps.c: Include main.h.
7015         * main.h (interpreter_p): Declare.
7016         * defs.h (interpreter_p): Don't declare.
7017
7018 2019-05-08  Tom Tromey  <tromey@adacore.com>
7019
7020         * dwarf2loc.c: Include dwarf2read.h.
7021         * defs.h (read_unsigned_leb128): Don't declare.
7022         * dwarf2read.h (read_unsigned_leb128): Declare.
7023
7024 2019-05-08  Tom Tromey  <tromey@adacore.com>
7025
7026         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7027         method.
7028
7029 2019-05-08  Tom Tromey  <tromey@adacore.com>
7030
7031         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7032         when no wrap column is set.
7033
7034 2019-05-08  Tom Tromey  <tromey@adacore.com>
7035
7036         * c-lang.c (c_get_string): Handle non-C-style arrays.
7037
7038 2019-05-08  Tom Tromey  <tromey@adacore.com>
7039
7040         * typeprint.c (print_offset_data::update): Print the bit offset,
7041         not the number of bits remaining.
7042
7043 2019-05-08  Tom Tromey  <tromey@adacore.com>
7044
7045         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7046         padding at end of comment.
7047
7048 2019-05-08  Tom Tromey  <tromey@adacore.com>
7049
7050         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7051         Compare main types.
7052
7053 2019-05-06  Tom Tromey  <tom@tromey.com>
7054
7055         * common/scoped_mmap.c: Include common-defs.h.
7056         * common/scoped_mmap.h: Don't include config.h.
7057
7058 2019-05-04  Tom Tromey  <tom@tromey.com>
7059
7060         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7061         (struct aarch64_call_info): Add initializers.
7062         <si>: Now a std::vector.
7063         (pass_on_stack, aarch64_push_dummy_call): Update.
7064
7065 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7066             Tom Tromey  <tom@tromey.com>
7067
7068         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7069         (ppc_threads): Now a std::vector.  Now static.
7070         (hwdebug_find_thread_points_by_tid)
7071         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7072         Update.
7073
7074 2019-05-04  Tom Tromey  <tom@tromey.com>
7075
7076         * arc-tdep.c (arc_tdesc_init): Return bool.
7077
7078 2019-05-04  Tom Tromey  <tom@tromey.com>
7079
7080         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7081         Use gdb_assert_not_reached.
7082
7083 2019-05-04  Tom Tromey  <tom@tromey.com>
7084
7085         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7086         "false".
7087
7088 2019-05-04  Tom Tromey  <tom@tromey.com>
7089
7090         * arc-tdep.c (arc_tdesc_init): Use bool.
7091
7092 2019-05-04  Tom Tromey  <tom@tromey.com>
7093
7094         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7095
7096 2019-05-04  Tom Tromey  <tom@tromey.com>
7097
7098         * cli/cli-cmds.c (valid_command_p): Return bool.
7099
7100 2019-05-04  Tom Tromey  <tom@tromey.com>
7101
7102         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7103         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7104
7105 2019-05-04  Raul Tambre  <raul@tambre.ee>
7106
7107         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7108         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7109         operator for comparison.
7110
7111 2019-05-04  Tom Tromey  <tom@tromey.com>
7112
7113         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7114         (lookup_partial_symbol, print_partial_symbols)
7115         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7116         (psymbol_compare): Update.
7117         (add_psymbol_to_bcache): Clear the entire psymbol.
7118         (maintenance_check_psymtabs): Update.
7119         * psympriv.h (struct partial_symbol): Don't derive from
7120         general_symbol_info.
7121         <obj_section, unrelocated_address, address,
7122         set_unrelocated_address>: Update.
7123         <ginfo>: New member.
7124         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7125         (debug_names::write_psymbols): Update.
7126
7127 2019-05-04  Tom de Vries  <tdevries@suse.de>
7128
7129         * contrib/cc-with-tweaks.sh: Support -n arg.
7130
7131 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7132
7133         * corelow.c (core_target::detach): Ensure frame cache and
7134         register caches are cleared.
7135         inferior.c (exit_inferior_1): Likewise.
7136
7137 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7138             Tom Tromey  <tom@tromey.com>
7139
7140         * dictionary.c (collate_pending_symbols_by_language): Remove
7141         "struct" from foreach.
7142         * symtab.c (lookup_global_symbol_from_objfile)
7143         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7144         foreach.
7145         * ser-tcp.c (net_open): Remove "struct" from foreach.
7146         * objfiles.c (objfile_relocate, objfile_rebase)
7147         (objfile_has_symbols): Remove "struct" from foreach.
7148         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7149         from foreach.
7150         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7151         foreach.
7152         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7153         "struct" from foreach.
7154         * ada-lang.c (create_excep_cond_exprs)
7155         (ada_exception_catchpoint_cond_string): Remove "struct" from
7156         foreach.
7157
7158 2019-05-03  Tom Tromey  <tromey@adacore.com>
7159
7160         * ada-exp.y (convert_char_literal): Check suffix of each
7161         enumerator.
7162
7163 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7164
7165         PR ada/21406:
7166         * ada-exp.y (yywrap): Don't define.
7167         * ada-lex.l (%option): Add noyywrap
7168         (yywrap): Remove.
7169
7170 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7171
7172         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7173         _WIN32_WINNT to the XP level, unless already defined to a higher
7174         level.
7175
7176         * unittests/parse-connection-spec-selftests.c:
7177         * ser-tcp.c:
7178         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7179         override.
7180
7181         * symfile.c (find_separate_debug_file): Remove colon from the
7182         drive spec of DOS/Windows file names of the target, so that the
7183         file name produced from DEBUGDIR and the target's directory will
7184         be valid on DOS/Windows systems.
7185
7186 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7187
7188         * rust-lang.c (val_print_struct): Handle printing structures
7189         containing strings.
7190
7191 2019-05-02  Tom Tromey  <tromey@adacore.com>
7192
7193         * valarith.c (_initialize_valarith): Remove.
7194
7195 2019-05-01  Tom Tromey  <tromey@adacore.com>
7196
7197         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7198         bitfields.
7199
7200 2019-05-01  Tom Tromey  <tromey@adacore.com>
7201
7202         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7203         for big-endian copies.
7204
7205 2019-04-30  Ali Tamur  <tamur@google.com>
7206         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7207         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7208         (read_3_bytes): New function.
7209
7210 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7211
7212         * windows-nat.c (main_thread_id): Delete.
7213         (handle_output_debug_string): Replace main_thread_id by
7214         current_event.dwThreadId.
7215         (fake_create_process): Likewise.
7216         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7217         Do not set main_thread_id.
7218         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7219         current_event.dwThreadId.
7220         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7221
7222 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7223
7224         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7225         Use current_event.dwThreadId instead of main_thread_id.
7226
7227 2019-04-30  Tom Tromey  <tromey@adacore.com>
7228
7229         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7230         (create_excep_cond_exprs): Iterate over program spaces.
7231         (ada_exception_catchpoint_cond_string): Examine all minimal
7232         symbols for exception types.
7233
7234 2019-04-30  Tom Tromey  <tromey@adacore.com>
7235
7236         PR c++/24470:
7237         * dwarf2read.c (process_structure_scope): Handle case where type
7238         has template parameters but no symbol was created.
7239
7240 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7241             Chris January  <chris.january@arm.com>
7242
7243         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7244         qualifier.
7245         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7246
7247 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * f-typeprint.c (f_print_type): Update rules for printing
7250         whitespace.
7251         (f_type_print_varspec_suffix): Likewise.
7252
7253 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7254             Chris January  <chris.january@arm.com>
7255
7256         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7257         function arguments.
7258
7259 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * f-lang.c (build_fortran_types): Change name of void type to
7262         lower case.
7263         * f-typeprint.c (f_type_print_base): Print the name of the void
7264         type, rather than a fixed string.
7265         * f-valprint.c (f_decorations): Use lower case void string.
7266
7267 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7268             Chris January  <chris.january@arm.com>
7269
7270         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7271         types for Fortran.
7272
7273 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7274             Chris January  <chris.january@arm.com>
7275             David Lecomber  <david.lecomber@arm.com>
7276
7277         * f-exp.y (BINOP_INTRINSIC): New token.
7278         (exp): New parser rule handling BINOP_INTRINSIC.
7279         (f77_keywords): Add new builtin procedures.
7280         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7281         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7282         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7283         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7284         (print_unop_subexp_f): New function.
7285         (print_binop_subexp_f): New function.
7286         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7287         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7288         (dump_subexp_body_f): Likewise.
7289         (operator_check_f): Likewise.
7290         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7291         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7292
7293 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7296         UNOP_KIND.
7297         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7298         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7299         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7300         (operator_length_f): New fuction.
7301         (print_subexp_f): New function.
7302         (op_name_f): New function.
7303         (dump_subexp_body_f): New function.
7304         (operator_check_f): New function.
7305         (exp_descriptor_f): Replace standard expression handling functions
7306         with new functions.
7307         * gdb/fortran-operator.def: New file.
7308         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7309         * gdb/std-operator.def: Remove UNOP_KIND.
7310
7311 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * std-operator.def: Remove unbalanced, stray double quote
7314         character.
7315
7316 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7317             Chris January  <chris.january@arm.com>
7318             Daniel Everett  <daniel.everett@arm.com>
7319             Nick Forrington  <nick.forrington@arm.com>
7320             Richard Bunt  <richard.bunt@arm.com>
7321
7322         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7323         of depth when printing anonymous structs or unions.
7324         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7325         Don't print either the top-level value, or the children if the
7326         max-depth is exceeded.
7327         (ppscm_print_children): When printing the key of a map, allow one
7328         extra level of depth.
7329         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7330         print either the top-level value, or the children if the max-depth
7331         is exceeded.
7332         (print_children): When printing the key of a map, allow one extra
7333         level of depth.
7334         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7335         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7336         (user_print_options): Initialise max_depth field.
7337         (val_print_scalar_or_string_type_p): New function.
7338         (val_print): Check to see if the max depth has been reached.
7339         (val_print_check_max_depth): Define new function.
7340         (show_print_max_depth): New function.
7341         (_initialize_valprint): Add 'print max-depth' option.
7342         * valprint.h (struct value_print_options) <max_depth>: New field.
7343         (val_print_check_max_depth): Declare new function.
7344         * NEWS: Document new feature.
7345
7346 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7347
7348         * ada-lang.c (ada_language_defn): Initialise new field.
7349         * c-lang.c (c_is_string_type_p): New function.
7350         (c_language_defn): Initialise new field.
7351         (cplus_language_defn): Initialise new field.
7352         (asm_language_defn): Initialise new field.
7353         (minimal_language_defn): Initialise new field.
7354         * c-lang.h (c_is_string_type_p): Declare new function.
7355         * d-lang.c (d_language_defn): Initialise new field.
7356         * f-lang.c (f_is_string_type_p): New function.
7357         (f_language_defn): Initialise new field.
7358         * go-lang.c (go_is_string_type_p): New function.
7359         (go_language_defn): Initialise new field.
7360         * language.c (default_is_string_type_p): New function.
7361         (unknown_language_defn): Initialise new field.
7362         (auto_language_defn): Initialise new field.
7363         * language.h (struct language_defn) <la_is_string_type_p>: New
7364         member variable.
7365         (default_is_string_type_p): Declare new function.
7366         * m2-lang.c (m2_language_defn): Initialise new field.
7367         * objc-lang.c (objc_language_defn): Initialise new field.
7368         * opencl-lang.c (opencl_language_defn): Initialise new field.
7369         * p-lang.c (pascal_is_string_type_p): New function.
7370         (pascal_language_defn): Initialise new field.
7371         * rust-lang.c (rust_is_string_type_p): New function.
7372         (rust_language_defn): Initialise new field.
7373
7374 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7377         New field.
7378         * ada-lang.c (ada_language_defn): Initialise new field.
7379         * c-lang.c (c_language_defn): Likewise.
7380         (cplus_language_defn): Likewise.
7381         (asm_language_defn): Likewise.
7382         (minimal_language_defn): Likewise.
7383         * d-lang.c (d_language_defn): Likewise.
7384         * f-lang.c (f_language_defn): Likewise.
7385         * go-lang.c (go_language_defn): Likewise.
7386         * language.c (unknown_language_defn): Likewise.
7387         (auto_language_defn): Likewise.
7388         * m2-lang.c (m2_language_defn): Likewise.
7389         * objc-lang.c (objc_language_defn): Likewise.
7390         * opencl-lang.c (opencl_language_defn): Likewise.
7391         * p-lang.c (pascal_language_defn): Likewise.
7392         * rust-lang.c (rust_language_defn): Likewise.
7393
7394 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7395
7396         * ada-lang.c (ada_is_character_type): Change return type to bool.
7397         (ada_is_string_type): Likewise.
7398         * ada-lang.h (ada_is_character_type): Update declaration
7399         (ada_is_string_type): Likewise.
7400
7401 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7402
7403         Support style in 'frame|thread apply'
7404
7405         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7406         * record.c (record_start, record_stop): Update callers of
7407         execute_command_to_string with false.
7408         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7409         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7410         methods.
7411         (class string_file): New constructor with term_out parameter.
7412         Override methods term_out and can_emit_style_escape.  New member
7413         term_out.
7414         (class stdio_file): Override can_emit_style_escape.
7415         (class tee_file): Override term_out and can_emit_style_escape.
7416         * utils.h (can_emit_style_escape): Remove.
7417         * utils.c (can_emit_style_escape): Likewise.
7418         Update all callers of can_emit_style_escape (SOMESTREAM) to
7419         SOMESTREAM->can_emit_style_escape.
7420         * source-cache.c (source_cache::get_source_lines): Likewise.
7421         * stack.c (frame_apply_command_count): Call execute_command_to_string
7422         passing the term_out characteristic of the current gdb_stdout.
7423         * thread.c (thr_try_catch_cmd): Likewise.
7424         * top.c (execute_command_to_string): pass term_out parameter
7425         to construct the string_file for the command output.
7426         * ui-file.c (term_cli_styling): New function (most code moved
7427         from utils.c can_emit_style_escape).
7428         (string_file::string_file, string_file::can_emit_style_escape,
7429         stdio_file::can_emit_style_escape, tee_file::term_out,
7430         tee_file::can_emit_style_escape): New functions.
7431
7432 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7433
7434         * NEWS: Mention the new set|show may-call-functions.
7435         * infcall.c (may_call_functions_p): New variable.
7436         (show_may_call_functions_p): New function.
7437         (call_function_by_hand_dummy): Throws an error if not
7438         may-call-functions.
7439         (_initialize_infcall): Call add_setshow_boolean_cmd for
7440         may-call-functions.
7441
7442 2019-04-25  Keith Seitz  <keiths@redhat.com>
7443
7444         PR c++/24367
7445         * cp-support.c (inspect_type): Don't attempt substitutions
7446         of symbol with the same name.
7447
7448 2019-04-25  Tom Tromey  <tromey@adacore.com>
7449
7450         PR gdb/24475:
7451         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7452         static.
7453
7454 2019-04-25  Tom Tromey  <tromey@adacore.com>
7455
7456         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7457         rvalue reference.
7458         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7459         (gdb_xml_parser::parse): Use std::move.
7460         * python/python-internal.h (gdbpy_convert_exception): Take a const
7461         reference.
7462         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7463         std::move.
7464         * python/py-utils.c (gdbpy_convert_exception): Take a const
7465         reference.
7466         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7467         Use std::move.
7468         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7469         Use std::move.
7470         * mi/mi-main.c (mi_print_exception): Take a const reference.
7471         * main.c (handle_command_errors): Take a const reference.
7472         * linespec.c (parse_linespec): Use std::move.
7473         * infcall.c (run_inferior_call): Use std::move.
7474         (call_function_by_hand_dummy): Use std::move.
7475         * exec.c (try_open_exec_file): Use std::move.
7476         * exceptions.h (exception_print, exception_fprintf)
7477         (exception_print_same): Update.
7478         * exceptions.c (print_exception, exception_print)
7479         (exception_fprintf, exception_print_same): Change parameters to
7480         const reference.
7481         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7482         * common/new-op.c: Use std::move.
7483         * common/common-exceptions.h (struct gdb_exception): Add move
7484         constructor.
7485         (struct gdb_exception_error, struct gdb_exception_quit, struct
7486         gdb_quit_bad_alloc): Change constructor to move constructor.
7487         (throw_exception): Change parameter to rvalue reference.
7488         * common/common-exceptions.c (throw_exception): Take rvalue
7489         reference.
7490         * cli/cli-interp.c (safe_execute_command): Use std::move.
7491         * breakpoint.c (insert_bp_location, location_to_sals): Use
7492         std::move.
7493
7494 2019-04-25  Tom Tromey  <tromey@adacore.com>
7495
7496         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7497         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7498         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7499         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7500         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7501         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7502         guile/scm-value.c: Use unpack.
7503         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7504         gdbscm_gdb_exception.
7505         (gdbscm_throw_gdb_exception): Likewise.
7506         (struct gdbscm_gdb_exception): New.
7507         (unpack): New function.
7508         (gdbscm_wrap): Use unpack.
7509
7510 2019-04-25  Tom Tromey  <tromey@adacore.com>
7511
7512         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7513         (gdb_rl_callback_handler): Use std::move.
7514         * common/common-exceptions.h (struct gdb_exception): Add move
7515         assignment operator.
7516         (throw_exception_sjlj): Change "exception" to const reference.
7517         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7518         (throw_exception_sjlj): Change "exception" to const reference.
7519
7520 2019-04-25  Tom Tromey  <tromey@adacore.com>
7521
7522         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7523         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7524         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7525         Update.
7526         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7527         Update.
7528         * mi/mi-interp.c (mi_interp::exec): Update.
7529         * linespec.c (parse_linespec): Update.
7530         * infcall.c (run_inferior_call): Update.
7531         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7532         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7533         (gdbscm_lookup_global_symbol): Update.
7534         * guile/scm-param.c (gdbscm_parameter_value): Update.
7535         * guile/scm-frame.c (gdbscm_frame_read_register)
7536         (gdbscm_frame_read_var): Update.
7537         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7538         * exec.c (try_open_exec_file): Update.
7539         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7540         (gdb_rl_callback_handler): Update.
7541         * common/common-exceptions.h (exception_none): Don't declare.
7542         * common/common-exceptions.c (exception_none): Don't define.
7543         (struct catcher) <exception>: Update.
7544         * cli/cli-interp.c (safe_execute_command): Update.
7545         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7546
7547 2019-04-25  Ali Tamur  <tamur@google.com>
7548
7549         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7550         (read_attribute_value): Likewise.
7551         (dwarf2_read_addr_index): Update comment.
7552         (read_str_index): Add DW_FORM_strx.
7553         (dwarf2_string_attr): Likewise.
7554         (dwarf2_const_value_attr): Likewise.
7555         (dump_die_shallow): Likewise.
7556         (dwarf2_fetch_constant_bytes): Likewise.
7557         (skip_form_bytes): Likewise.
7558         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7559
7560 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7561
7562         PR corefiles/11608
7563         PR corefiles/18187
7564         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7565         OFFSET.  Verify if current mapping contains an ELF header.
7566         (linux_find_memory_regions_full): Adjust call to
7567         dump_mapping_p.
7568
7569 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7570             Kang Li <kanglictf@gmail.com>
7571
7572         PR gdb/21600
7573
7574         * dwarf2-frame.c (read_initial_length): Be consistent about using
7575         unsigned representation of length.
7576         (decode_frame_entry_1): Likewise.  Check for wraparound of
7577         end pointer as well as buffer overflow.
7578
7579 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7580
7581         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7582         "vq".
7583
7584 2019-04-24  Tom Tromey  <tromey@adacore.com>
7585
7586         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7587
7588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * s12z-tdep.c (s12z_unwind_pc): Delete.
7591         (s12z_unwind_sp): Delete.
7592         (s12z_gdbarch_init): Don't register deleted functions with
7593         gdbarch.
7594
7595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * rl78-tdep.c (rl78_unwind_sp): Delete.
7598         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7599
7600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7603         (xstormy16_unwind_pc): Delete.
7604         (xstormy16_dummy_id): Delete.
7605         (xstormy16_gdbarch_init): Don't register deleted functions with
7606         gdbarch.
7607
7608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7609
7610         * vax-tdep.c (vax_unwind_pc): Delete.
7611         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7612
7613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * v850-tdep.c (v850_unwind_sp): Delete.
7616         (v850_unwind_pc): Delete.
7617         (v850_dummy_id): Delete.
7618         (v850_gdbarch_init): Don't register deleted functions with
7619         gdbarch.
7620
7621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7622
7623         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7624         (tilegx_unwind_pc): Delete.
7625         (tilegx_unwind_dummy_id): Delete.
7626         (tilegx_gdbarch_init): Don't register deleted functions with
7627         gdbarch.
7628
7629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7630
7631         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7632         (tic6x_dummy_id): Delete.
7633         (tic6x_gdbarch_init): Don't register deleted functions with
7634         gdbarch.
7635
7636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7637
7638         * sparc-tdep.c (sparc_unwind_pc): Delete.
7639         (sparc32_gdbarch_init): Don't register deleted function with
7640         gdbarch.
7641
7642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * sh-tdep.c (sh_unwind_sp): Delete.
7645         (sh_unwind_pc): Delete.
7646         (sh_dummy_id): Delete.
7647         (sh_gdbarch_init): Don't register deleted functions with
7648         gdbarch.
7649
7650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7651
7652         * score-tdep.c (score_unwind_sp): Delete.
7653         (score_unwind_pc): Delete.
7654         (score_dummy_id): Delete.
7655         (score_gdbarch_init): Don't register deleted functions with
7656         gdbarch.
7657
7658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7659
7660         * rx-tdep.c (rx_unwind_pc): Delete.
7661         (rx_unwind_sp): Delete.
7662         (rx_dummy_id): Delete.
7663         (rx_gdbarch_init): Don't register deleted functions with
7664         gdbarch.  Update comment.
7665
7666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7667
7668         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7669         (rs6000_dummy_id): Delete.
7670         (rs6000_gdbarch_init): Don't register deleted functions with
7671         gdbarch.
7672
7673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7674
7675         * or1k-tdep.c (or1k_dummy_id): Delete.
7676         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7677
7678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7679
7680         * nios2-tdep.c (nios2_dummy_id): Delete.
7681         (nios2_unwind_sp): Delete.
7682         (nios2_gdbarch_init): Don't register deleted functions with
7683         gdbarch.
7684
7685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * nds32-tdep.c (nds32_dummy_id): Delete.
7688         (nds32_unwind_pc): Delete.
7689         (nds32_unwind_sp): Delete.
7690         (nds32_gdbarch_init): Don't register deleted functions with
7691         gdbarch.
7692
7693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7694
7695         * msp430-tdep.c (msp430_unwind_pc): Delete.
7696         (msp430_unwind_sp): Delete.
7697         (msp430_dummy_id): Delete.
7698         (msp430_gdbarch_init): Don't register deleted functions with
7699         gdbarch.
7700
7701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * moxie-tdep.c (moxie_unwind_sp): Delete.
7704         (moxie_unwind_pc): Delete.
7705         (moxie_dummy_id): Delete.
7706         (moxie_gdbarch_init): Don't register deleted functions with
7707         gdbarch.
7708
7709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7712         (mn10300_unwind_pc): Delete.
7713         (mn10300_unwind_sp): Delete.
7714         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7715         mn10300_unwind_sp.
7716         (mn10300_frame_unwind_init): Don't register deleted functions with
7717         gdbarch.
7718
7719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * mep-tdep.c (mep_unwind_pc): Delete.
7722         (mep_unwind_sp): Delete.
7723         (mep_dummy_id): Delete.
7724         (mep_gdbarch_init): Don't register deleted functions with
7725         gdbarch.
7726
7727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7730         (m68hc11_unwind_sp): Delete.
7731         (m68hc11_gdbarch_init): Don't register deleted functions with
7732         gdbarch.
7733
7734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7735
7736         * m32r-tdep.c (m32r_unwind_sp): Delete.
7737         (m32r_unwind_pc): Delete.
7738         (m32r_dummy_id): Delete.
7739         (m32r_gdbarch_init): Don't register deleted functions with
7740         gdbarch.
7741
7742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * m32c-tdep.c (m32c_unwind_pc): Delete.
7745         (m32c_unwind_sp): Delete.
7746         (m32c_dummy_id): Delete.
7747         (m32c_gdbarch_init): Don't register deleted functions with
7748         gdbarch.
7749
7750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7753         (lm32_unwind_pc): Delete.
7754         (lm32_dummy_id): Delete.
7755         (lm32_gdbarch_init): Don't register deleted functions with
7756         gdbarch.
7757
7758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7759
7760         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7761         (iq2000_unwind_pc): Delete.
7762         (iq2000_dummy_id): Delete.
7763         (iq2000_gdbarch_init): Don't register deleted functions with
7764         gdbarch.
7765
7766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7767
7768         * nds32-tdep.c (nds32_type_align): Delete.
7769         (nds32_push_dummy_call): Use type_align instead.
7770
7771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * arm-tdep.c (arm_type_align): Only handle vector override case.
7774         (arm_push_dummy_call): Use type_align.
7775         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7776
7777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7780         case.
7781         (pass_on_stack): Use type_align.
7782         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7783         function.
7784
7785 2019-04-23  Tom Tromey  <tromey@adacore.com>
7786
7787         * dwarf2read.c (line_header::file_name_at): Remove unused
7788         overload.
7789
7790 2019-04-23  Tom de Vries  <tdevries@suse.de>
7791
7792         PR gdb/24438
7793         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7794         invocation.
7795
7796
7797 2019-03-27  Ali Tamur  <tamur@google.com>
7798
7799         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7800         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7801         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7802         (dwarf_expr_context::get_addr_index): Likewise
7803         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7804         (symbol_needs_eval_context::get_addr_index): Likewise
7805         (disassemble_dwarf_expression): Add DW_OP_addrx
7806         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7807         (read_cutu_die_from_dwo): Update comment
7808         (skip_one_die): Add DW_FORM_addrx
7809         (read_attribute_value): Likewise
7810         (var_decode_location): Add DW_OP_addrx
7811         (dwarf2_const_value_attr): Add DW_FORM_addrx
7812         (dump_die_shallow): Likewise
7813         (dwarf2_fetch_constant_bytes): Likewise
7814         (decode_locdesc): Add DW_OP_addrx
7815         (skip_form_bytes): Add DW_FORM_addrx
7816
7817 2019-04-22  Ali Tamur  <tamur@google.com>
7818
7819         * MAINTAINERS (Write After Approval): Add self.
7820
7821 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7822
7823         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7824         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7825         (open_symbol_file_object): Likewise.
7826         (svr4_default_sos): Add info parameter.
7827         (svr4_read_so_list): Likewise.
7828         (svr4_current_sos_direct): Adjust functions calls to pass down
7829         info.
7830         (svr4_current_sos_1): Add info parameter.
7831         (svr4_current_sos): Call get_svr4_info, pass info down to
7832         svr4_current_sos_1.
7833         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7834         get_svr4_info.
7835         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7836         get_svr4_info.
7837         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7838         to get_svr4_info.
7839         (probes_table_remove_objfile_probes): Likewise.
7840         (register_solib_event_probe): Add info parameter.
7841         (solist_update_incremental): Pass info parameter down to
7842         svr4_read_so_list.
7843         (disable_probes_interface): Add info parameter.
7844         (svr4_handle_solib_event): Pass current_program_space to
7845         get_svr4_info.  Adjust disable_probes_interface cleanup.
7846         (svr4_create_probe_breakpoints): Add info parameter, pass it
7847         down to register_solib_event_probe.
7848         (svr4_create_solib_event_breakpoints): Add info parameter,
7849         pass it down to svr4_create_probe_breakpoints.
7850         (enable_break): Pass info down to
7851         svr4_create_solib_event_breakpoints.
7852         (svr4_solib_create_inferior_hook): Pass current_program_space to
7853         get_svr4_info.
7854         (svr4_clear_solib): Likewise.
7855
7856 2019-04-22  Pedro Alves  <palves@redhat.com>
7857
7858         * solib-svr4.c (svr4_free_objfile_observer): New.
7859         (probe_and_action::objfile): New field.
7860         (probes_table_htab_remove_objfile_probes)
7861         (probes_table_remove_objfile_probes): New functions.
7862         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7863         in the new probe_and_action.  Don't store the probe in 'lookup'.
7864         (svr4_create_probe_breakpoints): Pass objfile to
7865         register_solib_event_probe.
7866         (_initialize_svr4_solib): Register a free_objfile observer.
7867
7868 2019-04-19  Tom Tromey  <tom@tromey.com>
7869
7870         * common/queue.h: Remove.
7871
7872 2019-04-19  Tom Tromey  <tom@tromey.com>
7873
7874         * event-loop.c: Don't include "common/queue.h".
7875
7876 2019-04-19  Tom Tromey  <tom@tromey.com>
7877
7878         * remote.c (remote_target): Use delete.
7879         * remote-notif.h: Include <list>, not "common/queue.h".
7880         (notif_client_p): Remove typedef.
7881         (remote_notif_state): Add constructor, destructor, initializer.
7882         <notif_queue>: Now a std::list.
7883         (remote_notif_state_xfree): Don't declare.
7884         * remote-notif.c (remote_notif_process, handle_notification)
7885         (remote_notif_state_allocate): Update.
7886         (~remote_notif_state): Rename from remote_notif_state_xfree.
7887
7888 2019-04-19  Tom Tromey  <tom@tromey.com>
7889
7890         * symfile.c (reread_symbols): Update.
7891         * objfiles.c (objfile_register_static_link)
7892         (objfile_lookup_static_link): Update
7893         (~objfile) Don't delete static_links.
7894         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7895
7896 2019-04-19  Tom Tromey  <tom@tromey.com>
7897
7898         * type-stack.h (struct type_stack) <insert>: Constify string.
7899         * type-stack.c (type_stack::insert): Constify string.
7900         * gdbtypes.h (lookup_template_type): Update.
7901         (address_space_name_to_int): Update.
7902         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7903         const.
7904         (lookup_template_type): Make name const.
7905         * c-exp.y: Update rules.
7906         (lex_one_token, classify_name, classify_inner_name)
7907         (c_print_token): Update.
7908         * p-exp.y: Update rules.
7909         (yylex): Update.
7910         * f-exp.y: Update rules.
7911         (yylex): Update.
7912         * d-exp.y: Update rules.
7913         (lex_one_token, classify_name, classify_inner_name): Update.
7914         * parse.c (write_dollar_variable, copy_name): Return std::string.
7915         * parser-defs.h (copy_name): Change return type.
7916         * m2-exp.y: Update rules.
7917         (yylex): Update.
7918         * go-exp.y (lex_one_token): Update.
7919         Update rules.
7920         (classify_unsafe_function, classify_packaged_name)
7921         (classify_name, yylex): Update.
7922
7923 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7924
7925         * configure.ac: add --enable-source-highlight switch.
7926         * configure: Regenerate.
7927         * top.c (print_gdb_version): plumb --enable-source-highlight
7928         status to "show configuration".
7929
7930 2019-04-19  Tom Tromey  <tromey@adacore.com>
7931
7932         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7933         Check ADA_TYPE_P.
7934         (empty_record, ada_template_to_fixed_record_type_1)
7935         (template_to_static_fixed_type)
7936         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7937         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7938         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7939         macros.
7940
7941 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7942
7943         PR symtab/24423:
7944         * source.c (print_source_lines_base): Advance "iter" when a
7945         control character is seen.
7946
7947 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7948
7949         * inferior.h (struct infcall_suspend_state_deleter):
7950         Catch exception in destructor to avoid crash.
7951
7952 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7953
7954         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7955         close to the add_com "shell".
7956
7957 2019-04-18  Tom Tromey  <tromey@adacore.com>
7958
7959         * process-stratum-target.h (class process_stratum_target)
7960         <stratum>: Add "final".
7961
7962 2019-04-17  Tom Tromey  <tromey@adacore.com>
7963
7964         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7965         against nullptr before use.
7966
7967 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7968
7969         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7970
7971 2019-04-17  Jim Wilson  <jimw@sifive.com>
7972             Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7975         code read might fail, assume 4-byte breakpoint in that case.
7976
7977 2019-04-15  Leszek Swirski  <leszeks@google.com>
7978
7979         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7980         rather than a hand-rolled POD check when checking for forced MEMORY
7981         classification.
7982
7983 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7984
7985         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7986         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7987         function.
7988         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7989         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7990         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7991         declaration.
7992
7993 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7994
7995         * aarch64-linux-nat.c
7996         (aarch64_linux_nat_target::thread_architecture): Add override.
7997         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7998         each VQ.
7999
8000 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8001
8002         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8003
8004 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8007         target types of size 96-bits, add some additional comments, and
8008         check that the builtin type we found was the correct size.
8009
8010 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8011
8012         * utils.c (prompt_for_continue): Don't restore the styling at the
8013         end, as applied_style has the wrong value.  This fixes styling in
8014         long lists of file names that are interrupted by the "Continue?"
8015         prompt.
8016
8017 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8020         * c-lang.c (c_language_defn): Likewise.
8021         (cplus_language_defn): Likewise.
8022         (asm_language_defn): Likewise.
8023         (minimal_language_defn): Likewise.
8024         * d-lang.c (d_language_defn): Likewise.
8025         * f-lang.c (f_language_defn): Likewise.
8026         * go-lang.c (go_language_defn): Likewise.
8027         * language.c (unknown_language_defn): Likewise.
8028         (auto_language_defn): Likewise.
8029         * language.h (struct language_defn): Remove la_magic field.
8030         (LANG_MAGIC): Delete.
8031         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8032         * objc-lang.c (objc_language_defn): Likewise.
8033         * opencl-lang.c (opencl_language_defn): Likewise.
8034         * p-lang.c (pascal_language_defn): Likewise.
8035         * rust-lang.c (rust_language_defn): Likewise.
8036
8037 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * riscv-tdep.c (riscv_type_align): New function.
8040         (riscv_type_alignment): Delete.
8041         (riscv_arg_location): Use 'type_align'.
8042         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8043
8044 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * gdbtypes.c (type_align): A struct with no non-static fields also
8047         has alignment of 1.
8048
8049 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8050
8051         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8052         component to 0.
8053         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8054         member.
8055         (riscv_struct_info::analyse): New implementation using new
8056         analyse_inner member function.
8057         (riscv_struct_info::field_offset): New member function.
8058         (riscv_struct_info::m_offsets): New member variable.
8059         (riscv_struct_info::analyse_inner): New private member function,
8060         takes the old implementation of riscv_struct_info::analyse but
8061         extended to track field offsets.
8062         (riscv_call_arg_struct): Update the struct folding special cases
8063         to handle cases where empty C++ structs, which are non-zero
8064         length, are found.
8065         (riscv_arg_location): Initialise the length of each location, a
8066         non-zero length now indicates the location is in use.
8067         (riscv_push_dummy_call): Allow for the first location having a
8068         non-zero offset when setting up arguments.
8069         (riscv_return_value): Likewise, but for return values.
8070
8071 2019-04-11  Tom Tromey  <tromey@adacore.com>
8072
8073         * utils.c (internal_vproblem): Make "msg" const.
8074
8075 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8076
8077         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8078         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8079         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8080         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8081
8082 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8083
8084         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8085         function.
8086         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8087         of amd64_collect_native_gregset.
8088         (amd64_linux_nat_target::store_registers): Likewise.
8089
8090 2019-04-10  Tom Tromey  <tom@tromey.com>
8091
8092         * symtab.c (lookup_global_symbol_from_objfile)
8093         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8094         * objfiles.h (class separate_debug_iterator): New.
8095         (class separate_debug_range): New.
8096         (struct objfile) <separate_debug_objfiles>: New method.
8097         (objfile_separate_debug_iterate): Don't declare.
8098         * objfiles.c (separate_debug_iterator::operator++): Rename from
8099         objfile_separate_debug_iterate.
8100         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8101         iterator.
8102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8103         iterator.
8104
8105 2019-04-10  Tom Tromey  <tom@tromey.com>
8106
8107         * symfile.c (reread_symbols): Remove old comment.
8108         * objfiles.c (free_all_objfiles): Fix a typo.
8109
8110 2019-04-10  Tom Tromey  <tom@tromey.com>
8111
8112         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8113         * minsyms.c (lookup_minimal_symbol): Use foreach.
8114         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8115         (lookup_minimal_symbol_solib_trampoline): Likewise.
8116         * symfile.c (reread_symbols): Use foreach.
8117
8118 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8119             Tom Tromey  <tromey@adacore.com>
8120
8121         PR rust/24414:
8122         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8123         (rust_lex_int_test): Change "value" to be LONGEST.
8124         (rust_lex_tests): Add test for long integer literal.
8125
8126 2019-04-09  Tom Tromey  <tromey@adacore.com>
8127
8128         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8129         to bool.
8130         (extended_remote_target::attach): Update.
8131         (remote_target::remote_notice_new_inferior): Update.
8132         (remote_target::add_current_inferior_and_thread): Update.
8133         * inferior.c (exit_inferior_1): Use "false".
8134         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8135
8136 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8137
8138         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8139         the "start" command.
8140
8141 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8142
8143         * python/py-inferior.c (infpy_thread_from_thread_handle):
8144         Adjust comments to reflect renaming of thread_from_thread_handle
8145         to thread_from_handle.  Adjust keywords.  Fix type error message.
8146         (inferior_object_methods): Add thread_from_handle.  Retain
8147         thread_from_thread_handle, but mark it as deprecated.
8148
8149 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8150
8151         * gdbthread.h (find_thread_by_handle): Revise declaration.
8152         * thread.c (find_thread_by_handle): Likewise.  Adjust
8153         implementation too.
8154         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8155         support for buffer objects as handles.
8156
8157 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8158
8159         * python/py-infthread.c (thpy_thread_handle): New function.
8160         (thread_object_methods): Register thpy_thread_handle.
8161
8162 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8163
8164         * gdbthread.h (thread_to_thread_handle): Declare.
8165         * thread.c (gdbtypes.h): Include.
8166         (thread_to_thread_handle): New function.
8167
8168         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8169         (target_thread_info_to_thread_handle): Declare.
8170         * target.c (target_thread_info_to_thread_handle): New function.
8171         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8172         * target-delegates.c: Regenerate.
8173
8174         * linux-thread-db.c (class thread_db_target): Add method
8175         thread_info_to_thread_handle.
8176         (thread_db_target::thread_info_to_thread_handle): Define.
8177         * remote.c (class remote_target): Add new method
8178         thread_info_to_thread_handle.
8179         (remote_target::thread_info_to_thread_handle): Define.
8180
8181 2019-04-08  Pedro Alves  <palves@redhat.com>
8182
8183         * common/common-exceptions.c (throw_exception): Don't create
8184         named object to throw; throw directly.
8185         (throw_it): Likewise.  Don't initialize gdb_exception::message
8186         here, with new; pass FMT and AP to the ctor instead.
8187         * common/common-exceptions.h: Include <string>.
8188         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8189         const char *, va_list)): New ctor.  Use std::make_shared.
8190         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8191         errors)): Delete.
8192         (gdb_exception_error::gdb_exception_error(enum errors, const char
8193         *, va_list)): New.
8194         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8195         Add assertion.
8196         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8197         errors)): Delete.
8198         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8199         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8200         Add assertion.
8201
8202 2019-04-08  Tom Tromey  <tom@tromey.com>
8203
8204         * valops.c (value_rtti_indirect_type): Replace throw_exception
8205         with throw.
8206         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8207         with throw.
8208         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8209         throw.
8210         * target.c (target_translate_tls_address): Replace throw_exception
8211         with throw.
8212         * stack.c (frame_apply_command_count): Replace throw_exception
8213         with throw.
8214         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8215         throw.
8216         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8217         with throw.
8218         * rs6000-tdep.c (rs6000_frame_cache)
8219         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8220         * remote.c: Replace throw_exception with throw.
8221         * record-full.c (record_full_message, record_full_wait_1)
8222         (record_full_restore): Replace throw_exception with throw.
8223         * record-btrace.c:
8224         (get_thread_current_frame_id, record_btrace_start_replaying)
8225         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8226         (cmd_record_btrace_start): Replace throw_exception with throw.
8227         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8228         throw.
8229         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8230         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8231         * linespec.c:
8232         (find_linespec_symbols): Replace throw_exception with throw.
8233         * infrun.c (displaced_step_prepare, resume): Replace
8234         throw_exception with throw.
8235         * infcmd.c (post_create_inferior): Replace throw_exception with
8236         throw.
8237         * inf-loop.c (inferior_event_handler): Replace throw_exception
8238         with throw.
8239         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8240         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8241         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8242         (get_prev_frame_always, get_frame_pc_if_available)
8243         (get_frame_address_in_block_if_available, get_frame_language):
8244         Replace throw_exception with throw.
8245         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8246         throw_exception with throw.
8247         * eval.c (fetch_subexp_value, evaluate_var_value)
8248         (evaluate_funcall, evaluate_subexp_standard): Replace
8249         throw_exception with throw.
8250         * dwarf2loc.c (call_site_find_chain)
8251         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8252         Replace throw_exception with throw.
8253         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8254         with throw.
8255         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8256         throw.
8257         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8258         * completer.c (complete_line_internal): Replace throw_exception
8259         with throw.
8260         * compile/compile-object-run.c (compile_object_run): Replace
8261         throw_exception with throw.
8262         * cli/cli-script.c (process_next_line): Replace throw_exception
8263         with throw.
8264         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8265         (btrace_enable, btrace_maint_update_pt_packets): Replace
8266         throw_exception with throw.
8267         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8268         throw_exception with throw.
8269         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8270         throw_exception with throw.
8271         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8272         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8273         * aarch64-tdep.c (aarch64_make_prologue_cache)
8274         (aarch64_make_stub_cache): Replace throw_exception with throw.
8275
8276 2019-04-08  Tom Tromey  <tom@tromey.com>
8277
8278         * common/common-exceptions.c (throw_exception): Rename from
8279         throw_exception_cxx.  Remove old copy.  Make argument const.
8280         (throw_it): Create and throw exception objects directly.
8281         * common/common-exceptions.h (throw_exception): Make argument
8282         const.
8283         (struct gdb_exception_error): Add constructor.
8284         (struct gdb_exception_quit): Add constructor.
8285
8286 2019-04-08  Tom Tromey  <tom@tromey.com>
8287
8288         * common/common-exceptions.h (exception_rethrow): Don't declare.
8289         (TRY_SJLJ): Update comment.
8290         (TRY, CATCH, END_CATCH): Remove.
8291         * common/common-exceptions.c (exception_rethrow): Remove.
8292
8293 2019-04-08  Tom Tromey  <tom@tromey.com>
8294
8295         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8296         Remove.
8297         (gdb_exception_error): Rename from
8298         gdb_exception_RETURN_MASK_ERROR.
8299         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8300         (gdb_quit_bad_alloc): Update.
8301         * aarch64-tdep.c: Update.
8302         * ada-lang.c: Update.
8303         * ada-typeprint.c: Update.
8304         * ada-valprint.c: Update.
8305         * amd64-tdep.c: Update.
8306         * arch-utils.c: Update.
8307         * break-catch-throw.c: Update.
8308         * breakpoint.c: Update.
8309         * btrace.c: Update.
8310         * c-varobj.c: Update.
8311         * cli/cli-cmds.c: Update.
8312         * cli/cli-interp.c: Update.
8313         * cli/cli-script.c: Update.
8314         * common/common-exceptions.c: Update.
8315         * common/new-op.c: Update.
8316         * common/selftest.c: Update.
8317         * compile/compile-c-symbols.c: Update.
8318         * compile/compile-cplus-symbols.c: Update.
8319         * compile/compile-object-load.c: Update.
8320         * compile/compile-object-run.c: Update.
8321         * completer.c: Update.
8322         * corelow.c: Update.
8323         * cp-abi.c: Update.
8324         * cp-support.c: Update.
8325         * cp-valprint.c: Update.
8326         * darwin-nat.c: Update.
8327         * disasm-selftests.c: Update.
8328         * dtrace-probe.c: Update.
8329         * dwarf-index-cache.c: Update.
8330         * dwarf-index-write.c: Update.
8331         * dwarf2-frame-tailcall.c: Update.
8332         * dwarf2-frame.c: Update.
8333         * dwarf2loc.c: Update.
8334         * dwarf2read.c: Update.
8335         * eval.c: Update.
8336         * event-loop.c: Update.
8337         * event-top.c: Update.
8338         * exec.c: Update.
8339         * f-valprint.c: Update.
8340         * fbsd-tdep.c: Update.
8341         * frame-unwind.c: Update.
8342         * frame.c: Update.
8343         * gdbtypes.c: Update.
8344         * gnu-v3-abi.c: Update.
8345         * guile/guile-internal.h: Update.
8346         * guile/scm-block.c: Update.
8347         * guile/scm-breakpoint.c: Update.
8348         * guile/scm-cmd.c: Update.
8349         * guile/scm-disasm.c: Update.
8350         * guile/scm-frame.c: Update.
8351         * guile/scm-lazy-string.c: Update.
8352         * guile/scm-math.c: Update.
8353         * guile/scm-param.c: Update.
8354         * guile/scm-ports.c: Update.
8355         * guile/scm-pretty-print.c: Update.
8356         * guile/scm-symbol.c: Update.
8357         * guile/scm-symtab.c: Update.
8358         * guile/scm-type.c: Update.
8359         * guile/scm-value.c: Update.
8360         * i386-linux-tdep.c: Update.
8361         * i386-tdep.c: Update.
8362         * inf-loop.c: Update.
8363         * infcall.c: Update.
8364         * infcmd.c: Update.
8365         * infrun.c: Update.
8366         * jit.c: Update.
8367         * language.c: Update.
8368         * linespec.c: Update.
8369         * linux-fork.c: Update.
8370         * linux-nat.c: Update.
8371         * linux-tdep.c: Update.
8372         * linux-thread-db.c: Update.
8373         * main.c: Update.
8374         * mi/mi-cmd-break.c: Update.
8375         * mi/mi-cmd-stack.c: Update.
8376         * mi/mi-interp.c: Update.
8377         * mi/mi-main.c: Update.
8378         * objc-lang.c: Update.
8379         * p-valprint.c: Update.
8380         * parse.c: Update.
8381         * ppc-linux-tdep.c: Update.
8382         * printcmd.c: Update.
8383         * python/py-arch.c: Update.
8384         * python/py-breakpoint.c: Update.
8385         * python/py-cmd.c: Update.
8386         * python/py-finishbreakpoint.c: Update.
8387         * python/py-frame.c: Update.
8388         * python/py-framefilter.c: Update.
8389         * python/py-gdb-readline.c: Update.
8390         * python/py-inferior.c: Update.
8391         * python/py-infthread.c: Update.
8392         * python/py-lazy-string.c: Update.
8393         * python/py-linetable.c: Update.
8394         * python/py-objfile.c: Update.
8395         * python/py-param.c: Update.
8396         * python/py-prettyprint.c: Update.
8397         * python/py-progspace.c: Update.
8398         * python/py-record-btrace.c: Update.
8399         * python/py-record.c: Update.
8400         * python/py-symbol.c: Update.
8401         * python/py-type.c: Update.
8402         * python/py-unwind.c: Update.
8403         * python/py-utils.c: Update.
8404         * python/py-value.c: Update.
8405         * python/python.c: Update.
8406         * record-btrace.c: Update.
8407         * record-full.c: Update.
8408         * remote-fileio.c: Update.
8409         * remote.c: Update.
8410         * riscv-tdep.c: Update.
8411         * rs6000-aix-tdep.c: Update.
8412         * rs6000-tdep.c: Update.
8413         * rust-exp.y: Update.
8414         * rust-lang.c: Update.
8415         * s390-tdep.c: Update.
8416         * selftest-arch.c: Update.
8417         * solib-dsbt.c: Update.
8418         * solib-frv.c: Update.
8419         * solib-spu.c: Update.
8420         * solib-svr4.c: Update.
8421         * solib.c: Update.
8422         * sparc64-linux-tdep.c: Update.
8423         * stack.c: Update.
8424         * symfile-mem.c: Update.
8425         * symmisc.c: Update.
8426         * target.c: Update.
8427         * thread.c: Update.
8428         * top.c: Update.
8429         * tracefile-tfile.c: Update.
8430         * tui/tui.c: Update.
8431         * typeprint.c: Update.
8432         * unittests/cli-utils-selftests.c: Update.
8433         * unittests/parse-connection-spec-selftests.c: Update.
8434         * valops.c: Update.
8435         * valprint.c: Update.
8436         * value.c: Update.
8437         * varobj.c: Update.
8438         * windows-nat.c: Update.
8439         * x86-linux-nat.c: Update.
8440         * xml-support.c: Update.
8441
8442 2019-04-08  Tom Tromey  <tom@tromey.com>
8443
8444         * xml-support.c: Use C++ exception handling.
8445         * x86-linux-nat.c: Use C++ exception handling.
8446         * windows-nat.c: Use C++ exception handling.
8447         * varobj.c: Use C++ exception handling.
8448         * value.c: Use C++ exception handling.
8449         * valprint.c: Use C++ exception handling.
8450         * valops.c: Use C++ exception handling.
8451         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8452         handling.
8453         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8454         * typeprint.c: Use C++ exception handling.
8455         * tui/tui.c: Use C++ exception handling.
8456         * tracefile-tfile.c: Use C++ exception handling.
8457         * top.c: Use C++ exception handling.
8458         * thread.c: Use C++ exception handling.
8459         * target.c: Use C++ exception handling.
8460         * symmisc.c: Use C++ exception handling.
8461         * symfile-mem.c: Use C++ exception handling.
8462         * stack.c: Use C++ exception handling.
8463         * sparc64-linux-tdep.c: Use C++ exception handling.
8464         * solib.c: Use C++ exception handling.
8465         * solib-svr4.c: Use C++ exception handling.
8466         * solib-spu.c: Use C++ exception handling.
8467         * solib-frv.c: Use C++ exception handling.
8468         * solib-dsbt.c: Use C++ exception handling.
8469         * selftest-arch.c: Use C++ exception handling.
8470         * s390-tdep.c: Use C++ exception handling.
8471         * rust-lang.c: Use C++ exception handling.
8472         * rust-exp.y: Use C++ exception handling.
8473         * rs6000-tdep.c: Use C++ exception handling.
8474         * rs6000-aix-tdep.c: Use C++ exception handling.
8475         * riscv-tdep.c: Use C++ exception handling.
8476         * remote.c: Use C++ exception handling.
8477         * remote-fileio.c: Use C++ exception handling.
8478         * record-full.c: Use C++ exception handling.
8479         * record-btrace.c: Use C++ exception handling.
8480         * python/python.c: Use C++ exception handling.
8481         * python/py-value.c: Use C++ exception handling.
8482         * python/py-utils.c: Use C++ exception handling.
8483         * python/py-unwind.c: Use C++ exception handling.
8484         * python/py-type.c: Use C++ exception handling.
8485         * python/py-symbol.c: Use C++ exception handling.
8486         * python/py-record.c: Use C++ exception handling.
8487         * python/py-record-btrace.c: Use C++ exception handling.
8488         * python/py-progspace.c: Use C++ exception handling.
8489         * python/py-prettyprint.c: Use C++ exception handling.
8490         * python/py-param.c: Use C++ exception handling.
8491         * python/py-objfile.c: Use C++ exception handling.
8492         * python/py-linetable.c: Use C++ exception handling.
8493         * python/py-lazy-string.c: Use C++ exception handling.
8494         * python/py-infthread.c: Use C++ exception handling.
8495         * python/py-inferior.c: Use C++ exception handling.
8496         * python/py-gdb-readline.c: Use C++ exception handling.
8497         * python/py-framefilter.c: Use C++ exception handling.
8498         * python/py-frame.c: Use C++ exception handling.
8499         * python/py-finishbreakpoint.c: Use C++ exception handling.
8500         * python/py-cmd.c: Use C++ exception handling.
8501         * python/py-breakpoint.c: Use C++ exception handling.
8502         * python/py-arch.c: Use C++ exception handling.
8503         * printcmd.c: Use C++ exception handling.
8504         * ppc-linux-tdep.c: Use C++ exception handling.
8505         * parse.c: Use C++ exception handling.
8506         * p-valprint.c: Use C++ exception handling.
8507         * objc-lang.c: Use C++ exception handling.
8508         * mi/mi-main.c: Use C++ exception handling.
8509         * mi/mi-interp.c: Use C++ exception handling.
8510         * mi/mi-cmd-stack.c: Use C++ exception handling.
8511         * mi/mi-cmd-break.c: Use C++ exception handling.
8512         * main.c: Use C++ exception handling.
8513         * linux-thread-db.c: Use C++ exception handling.
8514         * linux-tdep.c: Use C++ exception handling.
8515         * linux-nat.c: Use C++ exception handling.
8516         * linux-fork.c: Use C++ exception handling.
8517         * linespec.c: Use C++ exception handling.
8518         * language.c: Use C++ exception handling.
8519         * jit.c: Use C++ exception handling.
8520         * infrun.c: Use C++ exception handling.
8521         * infcmd.c: Use C++ exception handling.
8522         * infcall.c: Use C++ exception handling.
8523         * inf-loop.c: Use C++ exception handling.
8524         * i386-tdep.c: Use C++ exception handling.
8525         * i386-linux-tdep.c: Use C++ exception handling.
8526         * guile/scm-value.c: Use C++ exception handling.
8527         * guile/scm-type.c: Use C++ exception handling.
8528         * guile/scm-symtab.c: Use C++ exception handling.
8529         * guile/scm-symbol.c: Use C++ exception handling.
8530         * guile/scm-pretty-print.c: Use C++ exception handling.
8531         * guile/scm-ports.c: Use C++ exception handling.
8532         * guile/scm-param.c: Use C++ exception handling.
8533         * guile/scm-math.c: Use C++ exception handling.
8534         * guile/scm-lazy-string.c: Use C++ exception handling.
8535         * guile/scm-frame.c: Use C++ exception handling.
8536         * guile/scm-disasm.c: Use C++ exception handling.
8537         * guile/scm-cmd.c: Use C++ exception handling.
8538         * guile/scm-breakpoint.c: Use C++ exception handling.
8539         * guile/scm-block.c: Use C++ exception handling.
8540         * guile/guile-internal.h: Use C++ exception handling.
8541         * gnu-v3-abi.c: Use C++ exception handling.
8542         * gdbtypes.c: Use C++ exception handling.
8543         * frame.c: Use C++ exception handling.
8544         * frame-unwind.c: Use C++ exception handling.
8545         * fbsd-tdep.c: Use C++ exception handling.
8546         * f-valprint.c: Use C++ exception handling.
8547         * exec.c: Use C++ exception handling.
8548         * event-top.c: Use C++ exception handling.
8549         * event-loop.c: Use C++ exception handling.
8550         * eval.c: Use C++ exception handling.
8551         * dwarf2read.c: Use C++ exception handling.
8552         * dwarf2loc.c: Use C++ exception handling.
8553         * dwarf2-frame.c: Use C++ exception handling.
8554         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8555         * dwarf-index-write.c: Use C++ exception handling.
8556         * dwarf-index-cache.c: Use C++ exception handling.
8557         * dtrace-probe.c: Use C++ exception handling.
8558         * disasm-selftests.c: Use C++ exception handling.
8559         * darwin-nat.c: Use C++ exception handling.
8560         * cp-valprint.c: Use C++ exception handling.
8561         * cp-support.c: Use C++ exception handling.
8562         * cp-abi.c: Use C++ exception handling.
8563         * corelow.c: Use C++ exception handling.
8564         * completer.c: Use C++ exception handling.
8565         * compile/compile-object-run.c: Use C++ exception handling.
8566         * compile/compile-object-load.c: Use C++ exception handling.
8567         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8568         * compile/compile-c-symbols.c: Use C++ exception handling.
8569         * common/selftest.c: Use C++ exception handling.
8570         * common/new-op.c: Use C++ exception handling.
8571         * cli/cli-script.c: Use C++ exception handling.
8572         * cli/cli-interp.c: Use C++ exception handling.
8573         * cli/cli-cmds.c: Use C++ exception handling.
8574         * c-varobj.c: Use C++ exception handling.
8575         * btrace.c: Use C++ exception handling.
8576         * breakpoint.c: Use C++ exception handling.
8577         * break-catch-throw.c: Use C++ exception handling.
8578         * arch-utils.c: Use C++ exception handling.
8579         * amd64-tdep.c: Use C++ exception handling.
8580         * ada-valprint.c: Use C++ exception handling.
8581         * ada-typeprint.c: Use C++ exception handling.
8582         * ada-lang.c: Use C++ exception handling.
8583         * aarch64-tdep.c: Use C++ exception handling.
8584
8585 2019-04-08  Tom Tromey  <tom@tromey.com>
8586
8587         * xml-support.c (gdb_xml_parser::parse): Update.
8588         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8589         * value.c (show_convenience): Update.
8590         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8591         (test_parse_flags_qcs): Update.
8592         * thread.c (thr_try_catch_cmd): Update.
8593         * target.c (target_translate_tls_address): Update.
8594         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8595         (info_frame_command_core, frame_apply_command_count): Update.
8596         * rust-exp.y (rust_lex_exception_test): Update.
8597         * riscv-tdep.c (riscv_print_one_register_info): Update.
8598         * remote.c (remote_target::enable_btrace): Update.
8599         * record-btrace.c (record_btrace_enable_warn): Update.
8600         * python/py-utils.c (gdbpy_convert_exception): Update.
8601         * printcmd.c (do_one_display, print_variable_and_value): Update.
8602         * mi/mi-main.c (mi_print_exception): Update.
8603         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8604         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8605         * linux-nat.c (linux_nat_target::attach): Update.
8606         * linux-fork.c (class scoped_switch_fork_info): Update.
8607         * infrun.c (displaced_step_prepare): Update.
8608         * infcall.c (call_function_by_hand_dummy): Update.
8609         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8610         * gnu-v3-abi.c (print_one_vtable): Update.
8611         * frame.c (get_prev_frame_always): Update.
8612         * f-valprint.c (info_common_command_for_block): Update.
8613         * exec.c (try_open_exec_file): Update.
8614         * exceptions.c (print_exception, exception_print)
8615         (exception_fprintf, exception_print_same): Update.
8616         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8617         * dwarf-index-cache.c (index_cache::store)
8618         (index_cache::lookup_gdb_index): Update.
8619         * darwin-nat.c (maybe_cache_shell): Update.
8620         * cp-valprint.c (cp_print_value_fields): Update.
8621         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8622         (gcc_cplus_symbol_address): Update.
8623         * compile/compile-c-symbols.c (gcc_convert_symbol)
8624         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8625         * common/selftest.c: Update.
8626         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8627         a std::string.
8628         (exception_try_scope_entry, exception_try_scope_exit): Don't
8629         declare.
8630         (struct exception_try_scope): Remove.
8631         (TRY): Don't use exception_try_scope.
8632         (struct gdb_exception): Add constructor, operator=.
8633         <what>: New method.
8634         (struct gdb_exception_RETURN_MASK_ALL)
8635         (struct gdb_exception_RETURN_MASK_ERROR)
8636         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8637         (struct gdb_quit_bad_alloc): Update.
8638         * common/common-exceptions.c (exception_none): Change
8639         initializer.
8640         (struct catcher) <state, exception>: Initialize inline.
8641         <prev>: Remove member.
8642         (current_catcher): Remove.
8643         (catchers): New global.
8644         (exceptions_state_mc_init): Simplify.
8645         (catcher_pop): Remove.
8646         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8647         (try_scope_depth, exception_try_scope_entry)
8648         (exception_try_scope_exit): Remove.
8649         (throw_exception_sjlj): Update.
8650         (exception_messages, exception_messages_size): Remove.
8651         (throw_it): Simplify.
8652         (gdb_exception_sliced_copy): Remove.
8653         (throw_exception_cxx): Update.
8654         * cli/cli-script.c (script_from_file): Update.
8655         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8656         Update.
8657         * ada-valprint.c (ada_val_print): Update.
8658         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8659         (create_excep_cond_exprs): Update.
8660
8661 2019-04-08  Tom Tromey  <tom@tromey.com>
8662
8663         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8664         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8665         (TRY, CATCH, END_CATCH): Remove some definitions.
8666         * common/common-exceptions.c: Don't use GDB_XCPT.
8667         (catcher_list_size): Remove.
8668         (throw_exception, throw_it): Simplify.
8669
8670 2019-04-05  Tom Tromey  <tom@tromey.com>
8671
8672         Revert the header-sorting patch.
8673         * ft32-tdep.c: Revert.
8674         * frv-tdep.c: Revert.
8675         * frv-linux-tdep.c: Revert.
8676         * frame.c: Revert.
8677         * frame-unwind.c: Revert.
8678         * frame-base.c: Revert.
8679         * fork-child.c: Revert.
8680         * findvar.c: Revert.
8681         * findcmd.c: Revert.
8682         * filesystem.c: Revert.
8683         * filename-seen-cache.h: Revert.
8684         * filename-seen-cache.c: Revert.
8685         * fbsd-tdep.c: Revert.
8686         * fbsd-nat.h: Revert.
8687         * fbsd-nat.c: Revert.
8688         * f-valprint.c: Revert.
8689         * f-typeprint.c: Revert.
8690         * f-lang.c: Revert.
8691         * extension.h: Revert.
8692         * extension.c: Revert.
8693         * extension-priv.h: Revert.
8694         * expprint.c: Revert.
8695         * exec.h: Revert.
8696         * exec.c: Revert.
8697         * exceptions.c: Revert.
8698         * event-top.c: Revert.
8699         * event-loop.c: Revert.
8700         * eval.c: Revert.
8701         * elfread.c: Revert.
8702         * dwarf2read.h: Revert.
8703         * dwarf2read.c: Revert.
8704         * dwarf2loc.c: Revert.
8705         * dwarf2expr.h: Revert.
8706         * dwarf2expr.c: Revert.
8707         * dwarf2-frame.c: Revert.
8708         * dwarf2-frame-tailcall.c: Revert.
8709         * dwarf-index-write.h: Revert.
8710         * dwarf-index-write.c: Revert.
8711         * dwarf-index-common.c: Revert.
8712         * dwarf-index-cache.h: Revert.
8713         * dwarf-index-cache.c: Revert.
8714         * dummy-frame.c: Revert.
8715         * dtrace-probe.c: Revert.
8716         * disasm.h: Revert.
8717         * disasm.c: Revert.
8718         * disasm-selftests.c: Revert.
8719         * dictionary.c: Revert.
8720         * dicos-tdep.c: Revert.
8721         * demangle.c: Revert.
8722         * dcache.h: Revert.
8723         * dcache.c: Revert.
8724         * darwin-nat.h: Revert.
8725         * darwin-nat.c: Revert.
8726         * darwin-nat-info.c: Revert.
8727         * d-valprint.c: Revert.
8728         * d-namespace.c: Revert.
8729         * d-lang.c: Revert.
8730         * ctf.c: Revert.
8731         * csky-tdep.c: Revert.
8732         * csky-linux-tdep.c: Revert.
8733         * cris-tdep.c: Revert.
8734         * cris-linux-tdep.c: Revert.
8735         * cp-valprint.c: Revert.
8736         * cp-support.c: Revert.
8737         * cp-namespace.c: Revert.
8738         * cp-abi.c: Revert.
8739         * corelow.c: Revert.
8740         * corefile.c: Revert.
8741         * continuations.c: Revert.
8742         * completer.h: Revert.
8743         * completer.c: Revert.
8744         * complaints.c: Revert.
8745         * coffread.c: Revert.
8746         * coff-pe-read.c: Revert.
8747         * cli-out.h: Revert.
8748         * cli-out.c: Revert.
8749         * charset.c: Revert.
8750         * c-varobj.c: Revert.
8751         * c-valprint.c: Revert.
8752         * c-typeprint.c: Revert.
8753         * c-lang.c: Revert.
8754         * buildsym.c: Revert.
8755         * buildsym-legacy.c: Revert.
8756         * build-id.h: Revert.
8757         * build-id.c: Revert.
8758         * btrace.c: Revert.
8759         * bsd-uthread.c: Revert.
8760         * breakpoint.h: Revert.
8761         * breakpoint.c: Revert.
8762         * break-catch-throw.c: Revert.
8763         * break-catch-syscall.c: Revert.
8764         * break-catch-sig.c: Revert.
8765         * blockframe.c: Revert.
8766         * block.c: Revert.
8767         * bfin-tdep.c: Revert.
8768         * bfin-linux-tdep.c: Revert.
8769         * bfd-target.c: Revert.
8770         * bcache.c: Revert.
8771         * ax-general.c: Revert.
8772         * ax-gdb.h: Revert.
8773         * ax-gdb.c: Revert.
8774         * avr-tdep.c: Revert.
8775         * auxv.c: Revert.
8776         * auto-load.c: Revert.
8777         * arm-wince-tdep.c: Revert.
8778         * arm-tdep.c: Revert.
8779         * arm-symbian-tdep.c: Revert.
8780         * arm-pikeos-tdep.c: Revert.
8781         * arm-obsd-tdep.c: Revert.
8782         * arm-nbsd-tdep.c: Revert.
8783         * arm-nbsd-nat.c: Revert.
8784         * arm-linux-tdep.c: Revert.
8785         * arm-linux-nat.c: Revert.
8786         * arm-fbsd-tdep.c: Revert.
8787         * arm-fbsd-nat.c: Revert.
8788         * arm-bsd-tdep.c: Revert.
8789         * arch-utils.c: Revert.
8790         * arc-tdep.c: Revert.
8791         * arc-newlib-tdep.c: Revert.
8792         * annotate.h: Revert.
8793         * annotate.c: Revert.
8794         * amd64-windows-tdep.c: Revert.
8795         * amd64-windows-nat.c: Revert.
8796         * amd64-tdep.c: Revert.
8797         * amd64-sol2-tdep.c: Revert.
8798         * amd64-obsd-tdep.c: Revert.
8799         * amd64-obsd-nat.c: Revert.
8800         * amd64-nbsd-tdep.c: Revert.
8801         * amd64-nbsd-nat.c: Revert.
8802         * amd64-nat.c: Revert.
8803         * amd64-linux-tdep.c: Revert.
8804         * amd64-linux-nat.c: Revert.
8805         * amd64-fbsd-tdep.c: Revert.
8806         * amd64-fbsd-nat.c: Revert.
8807         * amd64-dicos-tdep.c: Revert.
8808         * amd64-darwin-tdep.c: Revert.
8809         * amd64-bsd-nat.c: Revert.
8810         * alpha-tdep.c: Revert.
8811         * alpha-obsd-tdep.c: Revert.
8812         * alpha-nbsd-tdep.c: Revert.
8813         * alpha-mdebug-tdep.c: Revert.
8814         * alpha-linux-tdep.c: Revert.
8815         * alpha-linux-nat.c: Revert.
8816         * alpha-bsd-tdep.c: Revert.
8817         * alpha-bsd-nat.c: Revert.
8818         * aix-thread.c: Revert.
8819         * agent.c: Revert.
8820         * addrmap.c: Revert.
8821         * ada-varobj.c: Revert.
8822         * ada-valprint.c: Revert.
8823         * ada-typeprint.c: Revert.
8824         * ada-tasks.c: Revert.
8825         * ada-lang.c: Revert.
8826         * aarch64-tdep.c: Revert.
8827         * aarch64-ravenscar-thread.c: Revert.
8828         * aarch64-newlib-tdep.c: Revert.
8829         * aarch64-linux-tdep.c: Revert.
8830         * aarch64-linux-nat.c: Revert.
8831         * aarch64-fbsd-tdep.c: Revert.
8832         * aarch64-fbsd-nat.c: Revert.
8833         * aarch32-linux-nat.c: Revert.
8834
8835 2019-04-05  Tom Tromey  <tom@tromey.com>
8836
8837         * ft32-tdep.c: Sort headers.
8838         * frv-tdep.c: Sort headers.
8839         * frv-linux-tdep.c: Sort headers.
8840         * frame.c: Sort headers.
8841         * frame-unwind.c: Sort headers.
8842         * frame-base.c: Sort headers.
8843         * fork-child.c: Sort headers.
8844         * findvar.c: Sort headers.
8845         * findcmd.c: Sort headers.
8846         * filesystem.c: Sort headers.
8847         * filename-seen-cache.h: Sort headers.
8848         * filename-seen-cache.c: Sort headers.
8849         * fbsd-tdep.c: Sort headers.
8850         * fbsd-nat.h: Sort headers.
8851         * fbsd-nat.c: Sort headers.
8852         * f-valprint.c: Sort headers.
8853         * f-typeprint.c: Sort headers.
8854         * f-lang.c: Sort headers.
8855         * extension.h: Sort headers.
8856         * extension.c: Sort headers.
8857         * extension-priv.h: Sort headers.
8858         * expprint.c: Sort headers.
8859         * exec.h: Sort headers.
8860         * exec.c: Sort headers.
8861         * exceptions.c: Sort headers.
8862         * event-top.c: Sort headers.
8863         * event-loop.c: Sort headers.
8864         * eval.c: Sort headers.
8865         * elfread.c: Sort headers.
8866         * dwarf2read.h: Sort headers.
8867         * dwarf2read.c: Sort headers.
8868         * dwarf2loc.c: Sort headers.
8869         * dwarf2expr.h: Sort headers.
8870         * dwarf2expr.c: Sort headers.
8871         * dwarf2-frame.c: Sort headers.
8872         * dwarf2-frame-tailcall.c: Sort headers.
8873         * dwarf-index-write.h: Sort headers.
8874         * dwarf-index-write.c: Sort headers.
8875         * dwarf-index-common.c: Sort headers.
8876         * dwarf-index-cache.h: Sort headers.
8877         * dwarf-index-cache.c: Sort headers.
8878         * dummy-frame.c: Sort headers.
8879         * dtrace-probe.c: Sort headers.
8880         * disasm.h: Sort headers.
8881         * disasm.c: Sort headers.
8882         * disasm-selftests.c: Sort headers.
8883         * dictionary.c: Sort headers.
8884         * dicos-tdep.c: Sort headers.
8885         * demangle.c: Sort headers.
8886         * dcache.h: Sort headers.
8887         * dcache.c: Sort headers.
8888         * darwin-nat.h: Sort headers.
8889         * darwin-nat.c: Sort headers.
8890         * darwin-nat-info.c: Sort headers.
8891         * d-valprint.c: Sort headers.
8892         * d-namespace.c: Sort headers.
8893         * d-lang.c: Sort headers.
8894         * ctf.c: Sort headers.
8895         * csky-tdep.c: Sort headers.
8896         * csky-linux-tdep.c: Sort headers.
8897         * cris-tdep.c: Sort headers.
8898         * cris-linux-tdep.c: Sort headers.
8899         * cp-valprint.c: Sort headers.
8900         * cp-support.c: Sort headers.
8901         * cp-namespace.c: Sort headers.
8902         * cp-abi.c: Sort headers.
8903         * corelow.c: Sort headers.
8904         * corefile.c: Sort headers.
8905         * continuations.c: Sort headers.
8906         * completer.h: Sort headers.
8907         * completer.c: Sort headers.
8908         * complaints.c: Sort headers.
8909         * coffread.c: Sort headers.
8910         * coff-pe-read.c: Sort headers.
8911         * cli-out.h: Sort headers.
8912         * cli-out.c: Sort headers.
8913         * charset.c: Sort headers.
8914         * c-varobj.c: Sort headers.
8915         * c-valprint.c: Sort headers.
8916         * c-typeprint.c: Sort headers.
8917         * c-lang.c: Sort headers.
8918         * buildsym.c: Sort headers.
8919         * buildsym-legacy.c: Sort headers.
8920         * build-id.h: Sort headers.
8921         * build-id.c: Sort headers.
8922         * btrace.c: Sort headers.
8923         * bsd-uthread.c: Sort headers.
8924         * breakpoint.h: Sort headers.
8925         * breakpoint.c: Sort headers.
8926         * break-catch-throw.c: Sort headers.
8927         * break-catch-syscall.c: Sort headers.
8928         * break-catch-sig.c: Sort headers.
8929         * blockframe.c: Sort headers.
8930         * block.c: Sort headers.
8931         * bfin-tdep.c: Sort headers.
8932         * bfin-linux-tdep.c: Sort headers.
8933         * bfd-target.c: Sort headers.
8934         * bcache.c: Sort headers.
8935         * ax-general.c: Sort headers.
8936         * ax-gdb.h: Sort headers.
8937         * ax-gdb.c: Sort headers.
8938         * avr-tdep.c: Sort headers.
8939         * auxv.c: Sort headers.
8940         * auto-load.c: Sort headers.
8941         * arm-wince-tdep.c: Sort headers.
8942         * arm-tdep.c: Sort headers.
8943         * arm-symbian-tdep.c: Sort headers.
8944         * arm-pikeos-tdep.c: Sort headers.
8945         * arm-obsd-tdep.c: Sort headers.
8946         * arm-nbsd-tdep.c: Sort headers.
8947         * arm-nbsd-nat.c: Sort headers.
8948         * arm-linux-tdep.c: Sort headers.
8949         * arm-linux-nat.c: Sort headers.
8950         * arm-fbsd-tdep.c: Sort headers.
8951         * arm-fbsd-nat.c: Sort headers.
8952         * arm-bsd-tdep.c: Sort headers.
8953         * arch-utils.c: Sort headers.
8954         * arc-tdep.c: Sort headers.
8955         * arc-newlib-tdep.c: Sort headers.
8956         * annotate.h: Sort headers.
8957         * annotate.c: Sort headers.
8958         * amd64-windows-tdep.c: Sort headers.
8959         * amd64-windows-nat.c: Sort headers.
8960         * amd64-tdep.c: Sort headers.
8961         * amd64-sol2-tdep.c: Sort headers.
8962         * amd64-obsd-tdep.c: Sort headers.
8963         * amd64-obsd-nat.c: Sort headers.
8964         * amd64-nbsd-tdep.c: Sort headers.
8965         * amd64-nbsd-nat.c: Sort headers.
8966         * amd64-nat.c: Sort headers.
8967         * amd64-linux-tdep.c: Sort headers.
8968         * amd64-linux-nat.c: Sort headers.
8969         * amd64-fbsd-tdep.c: Sort headers.
8970         * amd64-fbsd-nat.c: Sort headers.
8971         * amd64-dicos-tdep.c: Sort headers.
8972         * amd64-darwin-tdep.c: Sort headers.
8973         * amd64-bsd-nat.c: Sort headers.
8974         * alpha-tdep.c: Sort headers.
8975         * alpha-obsd-tdep.c: Sort headers.
8976         * alpha-nbsd-tdep.c: Sort headers.
8977         * alpha-mdebug-tdep.c: Sort headers.
8978         * alpha-linux-tdep.c: Sort headers.
8979         * alpha-linux-nat.c: Sort headers.
8980         * alpha-bsd-tdep.c: Sort headers.
8981         * alpha-bsd-nat.c: Sort headers.
8982         * aix-thread.c: Sort headers.
8983         * agent.c: Sort headers.
8984         * addrmap.c: Sort headers.
8985         * ada-varobj.c: Sort headers.
8986         * ada-valprint.c: Sort headers.
8987         * ada-typeprint.c: Sort headers.
8988         * ada-tasks.c: Sort headers.
8989         * ada-lang.c: Sort headers.
8990         * aarch64-tdep.c: Sort headers.
8991         * aarch64-ravenscar-thread.c: Sort headers.
8992         * aarch64-newlib-tdep.c: Sort headers.
8993         * aarch64-linux-tdep.c: Sort headers.
8994         * aarch64-linux-nat.c: Sort headers.
8995         * aarch64-fbsd-tdep.c: Sort headers.
8996         * aarch64-fbsd-nat.c: Sort headers.
8997         * aarch32-linux-nat.c: Sort headers.
8998
8999 2019-04-04  Tom Tromey  <tom@tromey.com>
9000
9001         * varobj.c (varobj_create): Update.
9002         * rust-exp.y (struct rust_parser) <update_innermost_block,
9003         lookup_symbol>: New methods.
9004         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9005         Rename.
9006         (rust_parser::rust_lookup_type)
9007         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9008         * printcmd.c (display_command, do_one_display): Update.
9009         * parser-defs.h (struct parser_state) <parser_state>: Add
9010         "tracker" parameter.
9011         (block_tracker): New member.
9012         (class innermost_block_tracker) <innermost_block_tracker>: Add
9013         "types" parameter.
9014         <reset>: Remove method.
9015         (innermost_block): Don't declare.
9016         (null_post_parser): Update.
9017         * parse.c (innermost_block): Remove global.
9018         (write_dollar_variable): Update.
9019         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9020         Remove "tracker_types" parameter.
9021         (parse_expression): Add "tracker" parameter.
9022         (parse_expression_for_completion): Update.
9023         (null_post_parser): Add "tracker" parameter.
9024         * p-exp.y: Update rules.
9025         * m2-exp.y: Update rules.
9026         * language.h (struct language_defn) <la_post_parser>: Add
9027         "tracker" parameter.
9028         * go-exp.y: Update rules.
9029         * f-exp.y: Update rules.
9030         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9031         parameter.
9032         * d-exp.y: Update rules.
9033         * c-exp.y: Update rules.
9034         * breakpoint.c (set_breakpoint_condition): Create an
9035         innermost_block_tracker.
9036         (watch_command_1): Likewise.
9037         * ada-lang.c (resolve): Add "tracker" parameter.
9038         (resolve_subexp): Likewise.
9039         * ada-exp.y (write_var_from_sym): Update.
9040
9041 2019-04-04  Tom Tromey  <tom@tromey.com>
9042
9043         * type-stack.h: New file.
9044         * type-stack.c: New file.
9045         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9046         type-stack.h.
9047         (insert_into_type_stack, insert_type, push_type, push_type_int)
9048         (insert_type_address_space, pop_type, pop_type_int)
9049         (pop_typelist, pop_type_stack, append_type_stack)
9050         (push_type_stack, get_type_stack, push_typelist)
9051         (follow_type_instance_flags, follow_types): Don't declare.
9052         * parse.c (type_stack): Remove global.
9053         (parse_exp_in_context): Update.
9054         (insert_into_type_stack, insert_type, push_type, push_type_int)
9055         (insert_type_address_space, pop_type, pop_type_int)
9056         (pop_typelist, pop_type_stack, append_type_stack)
9057         (push_type_stack, get_type_stack, push_typelist)
9058         (follow_type_instance_flags, follow_types): Remove (moved to
9059         type-stack.c).
9060         * f-exp.y (type_stack): New global.
9061         Update rules.
9062         (push_kind_type, f_parse): Update.
9063         * d-exp.y (type_stack): New global.
9064         Update rules.
9065         (d_parse): Update.
9066         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9067         Update rules.
9068         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9069         (HFILES_NO_SRCDIR): Add type-stack.h.
9070
9071 2019-04-04  Tom Tromey  <tom@tromey.com>
9072
9073         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9074         (rust_parser::convert_ast_to_expression, rust_parse)
9075         (rust_lex_test_completion, rust_lex_tests): Update.
9076         * parser-defs.h (struct expr_completion_state): New.
9077         (struct parser_state) <parser_state>: Add completion parameter.
9078         <mark_struct_expression, mark_completion_tag>: New methods.
9079         <parse_completion, m_completion_state>: New members.
9080         (prefixify_expression, null_post_parser): Update.
9081         (mark_struct_expression, mark_completion_tag): Don't declare.
9082         * parse.c (parse_completion, expout_last_struct)
9083         (expout_tag_completion_type, expout_completion_name): Remove
9084         globals.
9085         (parser_state::mark_struct_expression)
9086         (parser_state::mark_completion_tag): Now methods.
9087         (prefixify_expression): Add last_struct parameter.
9088         (prefixify_subexp): Likewise.
9089         (parse_exp_1): Update.
9090         (parse_exp_in_context): Add cstate parameter.  Update.
9091         (parse_expression_for_completion): Create an
9092         expr_completion_state.
9093         (null_post_parser): Add "completion" parameter.
9094         * p-exp.y: Update rules.
9095         (yylex): Update.
9096         * language.h (struct language_defn) <la_post_parser>: Add
9097         "completing" parameter.
9098         * go-exp.y: Update rules.
9099         (lex_one_token): Update.
9100         * expression.h (parse_completion): Don't declare.
9101         * d-exp.y: Update rules.
9102         (lex_one_token): Update rules.
9103         * c-exp.y: Update rules.
9104         (lex_one_token): Update.
9105         * ada-lang.c (resolve): Add "parse_completion" parameter.
9106         (resolve_subexp): Likewise.
9107         (ada_resolve_function): Likewise.
9108
9109 2019-04-04  Tom Tromey  <tom@tromey.com>
9110
9111         * parser-defs.h (struct parser_state) <start_arglist,
9112         end_arglist>: New methods.
9113         <arglist_len, m_funcall_chain>: New members.
9114         (arglist_len, start_arglist, end_arglist): Don't declare.
9115         * parse.c (arglist_len, funcall_chain): Remove global.
9116         (start_arglist, end_arglist): Remove functions.
9117         (parse_exp_in_context): Update.
9118         * p-exp.y: Update rules.
9119         * m2-exp.y: Update rules.
9120         * go-exp.y: Update rules.
9121         * f-exp.y: Update rules.
9122         * d-exp.y: Update rules.
9123         * c-exp.y: Update rules.
9124
9125 2019-04-04  Tom Tromey  <tom@tromey.com>
9126
9127         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9128         lex_operator, push_back>: New methods.
9129         Update all rules.
9130         (rust_parser::lex_hex, lex_escape): Rename and update.
9131         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9132         (rust_parser::lex_operator): Rename and update.
9133         (rust_parser::lex_number, rustyylex, rustyyerror)
9134         (rust_lex_test_init, rust_lex_test_sequence)
9135         (rust_lex_test_push_back, rust_lex_tests): Update.
9136         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9137         parameter.
9138         <lexptr, prev_lexptr>: New members.
9139         (lexptr, prev_lexptr): Don't declare.
9140         * parse.c (lexptr, prev_lexptr): Remove globals.
9141         (parse_exp_in_context): Update.
9142         * p-exp.y (yylex, yyerror): Update.
9143         * m2-exp.y (parse_number, yylex, yyerror): Update.
9144         * go-exp.y (lex_one_token, yyerror): Update.
9145         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9146         * d-exp.y (lex_one_token, yyerror): Update.
9147         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9148         (lex_one_token, yyerror): Update.
9149         * ada-lex.l (YY_INPUT): Update.
9150         (rewind_to_char): Update.
9151         * ada-exp.y (yyerror): Update.
9152
9153 2019-04-04  Tom Tromey  <tom@tromey.com>
9154
9155         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9156         * parser-defs.h (struct parser_state) <parser_state>: Add new
9157         parameter.
9158         <comma_terminates>: New member.
9159         (comma_terminates): Don't declare global.
9160         * parse.c (comma_terminates): Remove global.
9161         (parse_exp_in_context): Update.
9162         * p-exp.y (yylex): Update.
9163         * m2-exp.y (yylex): Update.
9164         * go-exp.y (lex_one_token): Update.
9165         * f-exp.y (yylex): Update.
9166         * d-exp.y (lex_one_token): Update.
9167         * c-exp.y (lex_one_token): Update.
9168         * ada-lex.l: Update.
9169
9170 2019-04-04  Tom Tromey  <tom@tromey.com>
9171
9172         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9173         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9174         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9175         * parser-defs.h (paren_depth): Don't declare.
9176         * parse.c (paren_depth): Remove global.
9177         (parse_exp_in_context): Update.
9178         * p-exp.y (paren_depth): New global.
9179         (pascal_parse): Initialize it.
9180         * m2-exp.y (paren_depth): New global.
9181         (m2_parse): Initialize it.
9182         * go-exp.y (paren_depth): New global.
9183         (go_parse): Initialize it.
9184         * f-exp.y (paren_depth): New global.
9185         (f_parse): Initialize it.
9186         * d-exp.y (paren_depth): New global.
9187         (d_parse): Initialize it.
9188         * c-exp.y (paren_depth): New global.
9189         (c_parse): Initialize it.
9190         * ada-lex.l (paren_depth): New global.
9191         (lexer_init): Initialize it.
9192
9193 2019-04-04  Tom Tromey  <tom@tromey.com>
9194
9195         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9196         (rust_parser::convert_ast_to_type)
9197         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9198         * parser-defs.h (struct parser_state) <parser_state>: Add
9199         parameters.  Initialize new members.
9200         <expression_context_block, expression_context_pc>: New members.
9201         * parse.c (expression_context_block, expression_context_pc):
9202         Remove globals.
9203         (parse_exp_in_context): Update.
9204         * p-exp.y: Update all rules.
9205         (yylex): Update.
9206         * m2-exp.y: Update all rules.
9207         (yylex): Update.
9208         * go-exp.y (yylex): Update.
9209         * f-exp.y (yylex): Update.
9210         * d-exp.y: Update all rules.
9211         (yylex): Update.
9212         * c-exp.y: Update all rules.
9213         (lex_one_token, classify_name, yylex, c_parse): Update.
9214         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9215
9216 2019-04-04  Tom Tromey  <tom@tromey.com>
9217
9218         * gdbarch.h, gdbarch.c: Rebuild.
9219         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9220         * stap-probe.h:
9221         (struct stap_parse_info): Replace "parser_state" with
9222         "expr_builder".
9223         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9224         (parser_state): New class.
9225         * parse.c (expr_builder): Rename.
9226         (expr_builder::release): Rename.
9227         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9228         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9229         (write_exp_elt_longcst, write_exp_elt_floatcst)
9230         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9231         (write_exp_string_vector, write_exp_bitstring)
9232         (write_exp_msymbol, mark_struct_expression)
9233         (write_dollar_variable)
9234         (insert_type_address_space, increase_expout_size): Replace
9235         "parser_state" with "expr_builder".
9236         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9237         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9238         "parser_state" with "expr_builder".
9239
9240 2019-04-04  Tom Tromey  <tom@tromey.com>
9241
9242         * rust-exp.y: Replace "parse_language" with method call.
9243         * p-exp.y:
9244         (yylex): Replace "parse_language" with method call.
9245         * m2-exp.y:
9246         (yylex): Replace "parse_language" with method call.
9247         * go-exp.y (classify_name): Replace "parse_language" with method
9248         call.
9249         * f-exp.y (yylex): Replace "parse_language" with method call.
9250         * d-exp.y (lex_one_token): Replace "parse_language" with method
9251         call.
9252         * c-exp.y:
9253         (lex_one_token, classify_name, yylex): Replace "parse_language"
9254         with method call.
9255         * ada-exp.y (find_primitive_type, type_char)
9256         (type_system_address): Replace "parse_language" with method call.
9257
9258 2019-04-04  Tom Tromey  <tom@tromey.com>
9259
9260         * rust-exp.y: Replace "parse_gdbarch" with method call.
9261         * parse.c (write_dollar_variable, insert_type_address_space):
9262         Replace "parse_gdbarch" with method call.
9263         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9264         call.
9265         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9266         call.
9267         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9268         "parse_gdbarch" with method call.
9269         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9270         with method call.
9271         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9272         "parse_gdbarch" with method call.
9273         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9274         "parse_gdbarch" with method call.
9275         * c-exp.y (parse_type, parse_number, classify_name): Replace
9276         "parse_gdbarch" with method call.
9277         * ada-lex.l: Replace "parse_gdbarch" with method call.
9278         * ada-exp.y (parse_type, find_primitive_type, type_char)
9279         (type_system_address): Replace "parse_gdbarch" with method call.
9280
9281 2019-04-04  Tom Tromey  <tom@tromey.com>
9282
9283         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9284         * stap-probe.c (stap_parse_argument): Update.
9285         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9286         initial_size parameter.
9287         * rust-exp.y (rust_lex_tests): Update.
9288         * parse.c (parser_state): Update.
9289         (parse_exp_in_context): Update.
9290         * parser-defs.h (struct parser_state) <parser_state>: Remove
9291         "initial_size" parameter.
9292
9293 2019-04-04  Tom Tromey  <tom@tromey.com>
9294
9295         * parser-defs.h (increase_expout_size): Don't declare.
9296         * parse.c (increase_expout_size): Now static.
9297
9298 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9299
9300         * gnu-nat.c (gnu_nat_target::wait): Fix
9301         target_waitstatus_to_string call.
9302
9303 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * eval.c (evaluate_subexp_standard): Handle internal functions
9306         during Fortran function call handling.
9307
9308 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * NEWS: Mention new internal functions.
9311         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9312         (read_base_type): Use dwarf2_init_complex_target_type.
9313         * value.c (creal_internal_fn): New function.
9314         (cimag_internal_fn): New function.
9315         (_initialize_values): Register new internal functions.
9316
9317 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9318
9319         * infrun.c (stop_all_threads): If debug_infrun, always
9320         trace the wait status after wait_one, using
9321         target_waitstatus_to_string and target_pid_to_str.
9322         (handle_inferior_event): Replace various trace of
9323         wait status kind by a single trace.
9324         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9325         wait status kind image by target_waitstatus_to_string.
9326         * target/waitstatus.c (target_waitstatus_to_string): Fix
9327         obsolete comment.
9328
9329 2019-04-01  Tom Tromey  <tromey@adacore.com>
9330
9331         PR symtab/23331:
9332         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9333
9334 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9335             Pedro Alves  <palves@redhat.com>
9336
9337         * top.c (quit_force): Call 'finalize_values'.
9338         * value.c (finalize_values): New function.
9339         * value.h (finalize_values): Declare.
9340
9341 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9342
9343         * NEWS: Announce $_gdb_major and $_gdb_minor.
9344
9345         * top.c (init_gdb_version_vars): New function.
9346         (gdb_init): Call init_gdb_version_vars.
9347
9348 2019-03-29  Tom Tromey  <tromey@adacore.com>
9349
9350         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9351         help text.  Remove dead code.
9352
9353 2019-03-29  Keith Seitz  <keiths@redhat.com>
9354
9355         From Siddhesh Poyarekar:
9356         * f-lang.h (f77_get_upperbound): Return LONGEST.
9357         (f77_get_lowerbound): Likewise.
9358         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9359         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9360         print them.
9361         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9362         plongest to format print it.
9363         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9364         (f77_get_upperbound): Likewise.
9365         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9366         LOWER_BOUND to LONGEST.
9367         (f77_create_arrayprint_offset_tbl): Likewise.
9368
9369 2019-03-29  Keith Seitz  <keiths@redhat.com>
9370
9371         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9372         %s/pulongest for TYPE_LENGTH instead of %d in format
9373         strings.
9374         * ada-typerint.c (ada_print_type): Likewise.
9375         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9376         * compile/compile-c-support.c (generate_register_struct): Likewise.
9377         * gdbtypes.c (recursive_dump_type): Likewise.
9378         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9379         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9380         instead of %d in format strings.
9381         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9382         to std::min to ULONGEST.
9383         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9384         instead of %d in format strings.
9385         * tracepoint.c (info_scope_command): Likewise.
9386         * typeprint.c (print_offset_data::update)
9387         (print_offset_data::finish): Likewise.
9388         * xtensa-tdep.c (xtensa_store_return_value)
9389         (xtensa_push_dummy_call): Likewise.
9390
9391 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9392
9393         * windows-nat.c (display_selector): Fixed format specifications
9394         for 64-bit Cygwin.
9395
9396 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9397
9398         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9399
9400 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9401
9402         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9403         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9404         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9405         (nios2_linux_init_abi): Install it.
9406
9407 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9408
9409         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9410
9411 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9412
9413         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9414
9415 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9416             Tom Tromey  <tromey@adacore.com>
9417
9418         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9419
9420 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9421
9422         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9423         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9424         method to compute the bounds of range types. Also print "[evaluated]"
9425         if the bounds' values come from a dynamic evaluation.
9426
9427 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9430         whitespace when pretty printing is on.
9431
9432 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9433
9434         * ppc-linux-nat.c: Add include.
9435
9436 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9437
9438         * NEWS: Mention AArch64 Pointer Authentication.
9439
9440 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9441
9442         * arm-linux-nat.c: Add include.
9443
9444 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9445
9446         * source-cache.c (source_cache::get_source_lines): Re-read
9447         fullname after calling open_source_file.
9448
9449 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9450
9451         * NEWS: Mention TLS support for FreeBSD.
9452
9453 2019-03-25  Tom Tromey  <tromey@adacore.com>
9454
9455         * minsyms.c (BUNCH_SIZE): Update comment.
9456         (~minimal_symbol_reader): Remove old comment.
9457         (compact_minimal_symbols): Update comment.
9458         (minimal_symbol_reader::install): Remove old comment.  Update
9459         other comments.
9460
9461 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9462
9463         * s390-linux-nat.c: Add include.
9464
9465 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9466
9467         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9468         Call linux_get_hwcap.
9469         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9470         Likewise.
9471         (aarch64_linux_get_hwcap): Remove function.
9472         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9473         declaration.
9474         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9475         linux_get_hwcap.
9476         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9477         * linux-tdep.c (linux_get_hwcap): Add function.
9478         (linux_get_hwcap2): Likewise.
9479         * linux-tdep.h (linux_get_hwcap): Add declaration.
9480         (linux_get_hwcap2): Likewise.
9481         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9482         (ppc_linux_get_hwcap2): Likewise.
9483         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9484         linux_get_hwcap.
9485         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9486         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9487         (ppc_linux_nat_target::read_description): Likewise.
9488         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9489         * s390-linux-nat.c: Likewise.
9490         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9491
9492 2019-03-24  Tom Tromey  <tom@tromey.com>
9493
9494         * ada-lang.c (standard_lookup): Simplify initialization.
9495         (ada_lookup_symbol_nonlocal): Simplify return.
9496         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9497         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9498         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9499         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9500         initialization.
9501         * solib.c (solib_global_lookup): Simplify.
9502         * symtab.c (null_block_symbol): Remove.
9503         (symbol_cache_lookup): Simplify returns.
9504         (lookup_language_this): Simplify returns.
9505         (lookup_symbol_aux): Simplify return.
9506         (lookup_local_symbol): Simplify returns.
9507         (lookup_global_symbol_from_objfile): Simplify return.
9508         (lookup_symbol_in_objfile_symtabs)
9509         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9510         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9511         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9512         * cp-namespace.c (cp_lookup_bare_symbol)
9513         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9514         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9515         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9516         (cp_lookup_symbol_via_imports): Simplify initialization.
9517         (find_symbol_in_baseclass): Likewise.
9518         * symtab.h (null_block_symbol): Remove.
9519         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9520         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9521         (d_lookup_symbol_module): Likewise.
9522         (find_symbol_in_baseclass): Simplify initialization.
9523
9524 2019-03-24  Tom Tromey  <tom@tromey.com>
9525
9526         * expression.h: Don't include symtab.h.
9527         (struct block): Forward declare.
9528
9529 2019-03-24  Tom Tromey  <tom@tromey.com>
9530
9531         * c-exp.y (typebase): Remove casts.
9532         * gdbtypes.c (lookup_unsigned_typename, )
9533         (lookup_signed_typename): Remove cast.
9534         * eval.c (parse_to_comma_and_eval): Remove cast.
9535         * parse.c (write_dollar_variable): Remove cast.
9536         * block.h (struct block) <superblock>: Now const.
9537         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9538         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9539         (map_block): Make "block" const.
9540         * symfile.h (struct quick_symbol_functions)
9541         <map_matching_symbols>: Constify block argument to "callback".
9542         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9543         const.
9544         (find_pc_sect_compunit_symtab): Make "b" const.
9545         (find_symbol_at_address): Likewise.
9546         (search_symbols): Likewise.
9547         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9548         (dw2_debug_names_lookup_symbol): Likewise.
9549         (dw2_map_matching_symbols): Update.
9550         * p-valprint.c (pascal_val_print): Remove "block".
9551         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9552         (aux_add_nonlocal_symbols): Make "block" const.
9553         (resolve_subexp): Remove cast.
9554         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9555         const.
9556         (iterate_over_file_blocks): Likewise.
9557         * f-exp.y (%union) <bval>: Remove.
9558         * coffread.c (patch_opaque_types): Make "b" const.
9559         * spu-tdep.c (spu_catch_start): Make "block" const.
9560         * c-valprint.c (print_unpacked_pointer): Remove "block".
9561         * symmisc.c (dump_symtab_1): Make "b" const.
9562         (block_depth): Make "block" const.
9563         * d-exp.y (%union) <bval>: Remove.
9564         * cp-support.h (cp_lookup_rtti_type): Update.
9565         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9566         * psymtab.c (psym_lookup_symbol): Make "block" const.
9567         (maintenance_check_psymtabs): Make "b" const.
9568         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9569         (enumerate_locals, enumerate_args): Update.
9570         * python/py-symtab.c (stpy_global_block): Make "block" const.
9571         (stpy_static_block): Likewise.
9572         * inline-frame.c (block_starting_point_at): Make "new_block"
9573         const.
9574         * block.c (find_block_in_blockvector): Make return type const.
9575         (blockvector_for_pc_sect): Make "b" const.
9576         (find_block_in_blockvector): Make "b" const.
9577
9578 2019-03-23  Tom Tromey  <tom@tromey.com>
9579
9580         * varobj.c (varobj_create): Update.
9581         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9582         * printcmd.c (display_command, do_one_display): Don't reset
9583         innermost_block.
9584         * parser-defs.h (enum innermost_block_tracker_type): Move to
9585         expression.h.
9586         (innermost_block): Update comment.
9587         * parse.c (parse_exp_1): Add tracker_types parameter.
9588         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9589         tracker_types parameter.  Reset innermost_block.
9590         (parse_exp_in_context): Remove.
9591         (parse_expression_for_completion): Update.
9592         * objfiles.c (~objfile): Don't reset expression_context_block or
9593         innermost_block.
9594         * expression.h (enum innermost_block_tracker_type): Move from
9595         parser-defs.h.
9596         (parse_exp_1): Add tracker_types parameter.
9597         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9598         reset innermost_block.
9599
9600 2019-03-23  Tom Tromey  <tom@tromey.com>
9601
9602         * objfiles.h: Include bcache.h.
9603
9604 2019-03-23  Tom Tromey  <tom@tromey.com>
9605
9606         * linespec.c (get_current_search_block): Use
9607         scoped_restore_current_language.
9608         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9609
9610 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9611             Jiong Wang  <jiong.wang@arm.com>
9612
9613         * aarch64-linux-tdep.c
9614         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9615         section.
9616         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9617
9618 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9619             Jiong Wang  <jiong.wang@arm.com>
9620
9621         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9622         instructions.
9623         (aarch64_analyze_prologue_test): Add PACIASP test.
9624         (aarch64_prologue_prev_register): Unmask PC value.
9625
9626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9627             Jiong Wang  <jiong.wang@arm.com>
9628
9629         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9630         (aarch64_dwarf2_prev_register): Unmask PC value.
9631         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9632         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9633         DW_CFA_AARCH64_negate_ra_state.
9634         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9635
9636 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9637             Jiong Wang  <jiong.wang@arm.com>
9638
9639         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9640         registers.
9641         (aarch64_pseudo_register_name): Likewise.
9642         (aarch64_pseudo_register_type): Likewise.
9643         (aarch64_pseudo_register_reggroup_p): Likewise.
9644         (aarch64_gdbarch_init): Add pauth registers.
9645         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9646         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9647         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9648         (struct gdbarch_tdep): Add regnum for ra_state.
9649
9650 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9651             Jiong Wang  <jiong.wang@arm.com>
9652
9653         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9654
9655 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9656             Jiong Wang  <jiong.wang@arm.com>
9657
9658         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9659         function.
9660         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9661         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9662         (aarch64_gdbarch_init): Add puth registers.
9663         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9664         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9665         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9666
9667 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9668             Jiong Wang  <jiong.wang@arm.com>
9669
9670         * aarch64-linux-nat.c
9671         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9672         * aarch64-linux-tdep.c
9673         (aarch64_linux_core_read_description): Likewise.
9674         (aarch64_linux_get_hwcap): New function.
9675         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9676         (aarch64_linux_get_hwcap): New declaration.
9677
9678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9679             Jiong Wang  <jiong.wang@arm.com>
9680
9681         * aarch64-linux-nat.c
9682         (aarch64_linux_nat_target::read_description): Add pauth param.
9683         * aarch64-linux-tdep.c
9684         (aarch64_linux_core_read_description): Likewise.
9685         * aarch64-tdep.c (struct target_desc): Add in pauth.
9686         (aarch64_read_description): Add pauth param.
9687         (aarch64_gdbarch_init): Likewise.
9688         * aarch64-tdep.h (aarch64_read_description): Likewise.
9689         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9690         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9691         * features/Makefile: Add new files.
9692         * features/aarch64-pauth.c: New file.
9693         * features/aarch64-pauth.xml: New file.
9694
9695 2019-03-20  Tom Tromey  <tromey@adacore.com>
9696
9697         * infrun.c (handle_inferior_event): Rename from
9698         handle_inferior_event_1.  Create a scoped_value_mark.
9699         (handle_inferior_event): Remove.
9700
9701 2019-03-19  Tom Tromey  <tromey@adacore.com>
9702
9703         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9704         * infrun.h (print_stop_event): Add "displays" parameter.
9705         * infrun.c (print_stop_event): Add "displays" parameter.
9706
9707 2019-03-19  Pedro Alves  <palves@redhat.com>
9708
9709         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9710         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9711         to -1.  Fix TABs vs spaces.
9712         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9713         * tui/tui-out.h (tui_ui_out) Add intro comments.
9714         <m_line, m_start_of_line>: In-class initialize, and add describing
9715         comment.
9716
9717 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9718
9719         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9720         variable names.
9721         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9722
9723 2019-03-18  Pedro Alves  <palves@redhat.com>
9724             Eli Zaretskii <eliz@gnu.org>
9725
9726         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9727         m_line and m_start_of_line.
9728
9729 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9730
9731         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9732         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9733         it returns a newline.  This fixes a regression in TU mode, whereby
9734         the next line is output on the same screen line as the user input.
9735
9736 2019-03-18  Tom Tromey  <tromey@adacore.com>
9737
9738         * minsyms.c (minimal_symbol_reader::install): Remove call to
9739         obstack_blank.
9740
9741 2019-03-18  Pedro Alves  <palves@redhat.com>
9742
9743         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9744         New globals.
9745         (apply_style): New, factored out from ...
9746         (apply_ansi_escape): ... this.  Handle reverse video mode.
9747         (tui_set_reverse_mode): New function.
9748         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9749         * tui/tui-winsource.c (tui_show_source_line): Use
9750         tui_set_reverse_mode instead of setting A_STANDOUT.
9751         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9752         New setter methods.
9753
9754 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9755
9756         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9757         Handle tabs.
9758
9759 2019-03-18  Tom Tromey  <tromey@adacore.com>
9760
9761         * ada-lang.c (empty_array): Add "high" parameter.
9762         (ada_evaluate_subexp): Update.
9763
9764 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9765
9766         * unittests/string_view-selftests.c: Define
9767         _initialize_string_view_selftests unconditionally.
9768
9769 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9770
9771         PR gdb/24350
9772         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9773
9774 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9775
9776         PR gdb/24351
9777         * windows-nat.c (display_selector): Fix format specifiers.
9778
9779 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9780
9781         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9782         tui_refill_source_window instead of tui_refresh_win, to update the
9783         current execution line.  This fixes redisplay of the current line
9784         when stepping through the code with "next" or "step".
9785
9786 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9787
9788         * source-cache.c (source_cache::get_source_lines): Call
9789         find_source_lines to initialize s->nlines.  This fixes vertical
9790         scrolling of TUI source window when the DOWN arrow is pressed.
9791
9792 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9793
9794         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9795         linux-thread-db.c (_initialize_thread_db): Likewise.
9796
9797 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9798
9799         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9800         wclrtoeol in tui_show_source_line".  This reverts changes made in
9801         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9802
9803 2019-03-15  Tom Tromey  <tom@tromey.com>
9804
9805         * symtab.h (struct minimal_symbol): Derive from
9806         general_symbol_info.
9807         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9808         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9809         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9810         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9811         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9812         (MSYMBOL_SEARCH_NAME): Update.
9813         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9814         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9815         * minsyms.c (minimal_symbol_reader::record_full): Update.
9816
9817 2019-03-15  Tom Tromey  <tom@tromey.com>
9818
9819         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9820
9821 2019-03-15  Tom Tromey  <tom@tromey.com>
9822
9823         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9824         unique_xmalloc_ptr.
9825         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9826         Update.
9827         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9828         (build_minimal_symbol_hash_tables)
9829         (minimal_symbol_reader::install): Update.
9830
9831 2019-03-15  Tom Tromey  <tom@tromey.com>
9832
9833         * symtab.c (create_demangled_names_hash): Update.
9834         (symbol_set_names): Update.
9835         * objfiles.h (struct objfile_per_bfd_storage)
9836         <demangled_names_hash>: Now an htab_up.
9837         * objfiles.c (objfile_per_bfd_storage): Simplify.
9838
9839 2019-03-15  Tom Tromey  <tom@tromey.com>
9840
9841         * objfiles.h (struct objfile_per_bfd_storage): Declare
9842         destructor.
9843         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9844         New.
9845         (get_objfile_bfd_data): Use new.  Don't initialize
9846         language_of_main.
9847         (free_objfile_per_bfd_storage): Remove.
9848         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9849
9850 2019-03-15  Tom Tromey  <tom@tromey.com>
9851
9852         * symfile.c (reread_symbols): Update.
9853         * objfiles.c (objfile::objfile): Update.
9854         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9855         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9856         comment.
9857         (minimal_symbol_reader::install): Update.
9858         (terminate_minimal_symbol_table): Remove.
9859         * jit.c (jit_object_close_impl): Update.
9860
9861 2019-03-15  Tom Tromey  <tom@tromey.com>
9862
9863         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9864         initializations.
9865
9866 2019-03-15  Tom Tromey  <tom@tromey.com>
9867
9868         * objfiles.h (struct objfile_per_bfd_storage)
9869         <demangled_hash_languages>: Now a bitset.
9870         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9871         (lookup_minimal_symbol): Update.
9872
9873 2019-03-15  Tom Tromey  <tom@tromey.com>
9874
9875         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9876         Don't return the symbol.
9877         * coffread.c (record_minimal_symbol): Use record_full.
9878
9879 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9880
9881         The MS-Windows port of ncurses fails to switch to a color pair if
9882         one or both of the colors are the implicit default colors.  This
9883         change records the default colors when TUI is initialized, and
9884         then specifies them explicitly when a color pair uses the default
9885         colors.  This allows color styling in TUI mode on MS-Windows.
9886
9887         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9888         ncurses_norm_attr.
9889         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9890         colors in ncurses_norm_attr.
9891         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9892         "none", replace it with the default color recorded in
9893         ncurses_norm_attr.
9894
9895 2019-03-14  Tom Tromey  <tromey@adacore.com>
9896
9897         * source-cache.h (class source_cache) <get_source_lines>: Return
9898         std::string.
9899         * source-cache.c (source_cache::extract_lines): Handle case where
9900         first_pos==npos.  Return std::string.
9901         (source_cache::get_source_lines): Update.
9902
9903 2019-03-14  Tom Tromey  <tromey@adacore.com>
9904
9905         * NEWS: Add item for "style sources" commands.
9906         * source-cache.c (source_cache::get_source_lines): Check
9907         source_styling.
9908         * cli/cli-style.c (source_styling): New global.
9909         (_initialize_cli_style): Add "style sources" commands.
9910         (show_style_sources): New function.
9911         * cli/cli-style.h (source_styling): Declare.
9912
9913 2019-03-14  Pedro Alves  <palves@redhat.com>
9914             Tom Tromey  <tromey@adacore.com>
9915
9916         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9917         * tui/tui-winsource.c (tui_refill_source_window): New function,
9918         from...
9919         (tui_horizontal_source_scroll): ... here.  Move some logic.
9920         * cli/cli-style.c (set_style_enabled): Notify new observable.
9921         * tui/tui-hooks.c (tui_redisplay_source): New function.
9922         (tui_attach_detach_observers): Attach or detach
9923         tui_redisplay_source.
9924         * observable.h (source_styling_changed): New observable.
9925         * observable.c: Define source_styling_changed observable.
9926
9927 2019-03-13  Tom Tromey  <tromey@adacore.com>
9928
9929         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9930         (i386_gnu_nat_target::store_registers): Update.
9931         * target-debug.h (target_debug_print_std_string): New macro.
9932         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9933         * windows-tdep.c (display_one_tib): Update.
9934         * tui/tui-stack.c (tui_make_status_line): Update.
9935         * top.c (print_inferior_quit_action): Update.
9936         * thread.c (thr_try_catch_cmd): Update.
9937         (add_thread_with_info): Update.
9938         (thread_target_id_str): Update.
9939         (thr_try_catch_cmd): Update.
9940         (thread_command): Update.
9941         (thread_find_command): Update.
9942         * record-btrace.c (record_btrace_target::info_record)
9943         (record_btrace_resume_thread, record_btrace_target::resume)
9944         (record_btrace_cancel_resume, record_btrace_step_thread)
9945         (record_btrace_target::wait, record_btrace_target::wait)
9946         (record_btrace_target::wait, record_btrace_target::stop): Update.
9947         * progspace.c (print_program_space): Update.
9948         * process-stratum-target.c
9949         (process_stratum_target::thread_address_space): Update.
9950         * linux-fork.c (linux_fork_mourn_inferior)
9951         (detach_checkpoint_command, info_checkpoints_command)
9952         (linux_fork_context): Update.
9953         (linux_fork_detach): Update.
9954         (class scoped_switch_fork_info): Update.
9955         (delete_checkpoint_command): Update.
9956         * infrun.c (follow_fork_inferior): Update.
9957         (follow_fork_inferior): Update.
9958         (proceed_after_vfork_done): Update.
9959         (handle_vfork_child_exec_or_exit): Update.
9960         (follow_exec): Update.
9961         (displaced_step_prepare_throw): Update.
9962         (displaced_step_restore): Update.
9963         (start_step_over): Update.
9964         (resume_1): Update.
9965         (clear_proceed_status_thread): Update.
9966         (proceed): Update.
9967         (print_target_wait_results): Update.
9968         (do_target_wait): Update.
9969         (context_switch): Update.
9970         (stop_all_threads): Update.
9971         (restart_threads): Update.
9972         (finish_step_over): Update.
9973         (handle_signal_stop): Update.
9974         (switch_back_to_stepped_thread): Update.
9975         (keep_going_pass_signal): Update.
9976         (print_exited_reason): Update.
9977         (normal_stop): Update.
9978         * inferior.c (inferior_pid_to_str): Change return type.
9979         (print_selected_inferior): Update.
9980         (add_inferior): Update.
9981         (detach_inferior): Update.
9982         * dummy-frame.c (fprint_dummy_frames): Update.
9983         * dcache.c (dcache_info_1): Update.
9984         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9985         (btrace_fetch, btrace_clear): Update.
9986         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9987         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9988         type.
9989         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9990         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9991         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9992         * gdbarch.c, gdbarch.h: Rebuild.
9993         * gdbarch.sh (core_pid_to_str): Change return type.
9994         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9995         return type.
9996         (windows_nat_target::pid_to_str): Change return type.
9997         (windows_delete_thread): Update.
9998         (windows_nat_target::attach): Update.
9999         (windows_nat_target::files_info): Update.
10000         * target-delegates.c: Rebuild.
10001         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10002         return type.
10003         (sol_thread_target::pid_to_str): Change return type.
10004         * remote.c (class remote_target) <pid_to_str>: Change return
10005         type.
10006         (remote_target::pid_to_str): Change return type.
10007         (extended_remote_target::attach, remote_target::remote_stop_ns)
10008         (remote_target::remote_notif_remove_queued_reply)
10009         (remote_target::push_stop_reply, remote_target::disable_btrace):
10010         Update.
10011         (extended_remote_target::attach): Update.
10012         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10013         type.
10014         (gdbsim_target::pid_to_str): Change return type.
10015         * ravenscar-thread.c (struct ravenscar_thread_target)
10016         <pid_to_str>: Change return type.
10017         (ravenscar_thread_target::pid_to_str): Change return type.
10018         * procfs.c (class procfs_target) <pid_to_str>: Change return
10019         type.
10020         (procfs_target::pid_to_str): Change return type.
10021         (procfs_target::attach): Update.
10022         (procfs_target::detach): Update.
10023         (procfs_target::fetch_registers): Update.
10024         (procfs_target::store_registers): Update.
10025         (procfs_target::wait): Update.
10026         (procfs_target::files_info): Update.
10027         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10028         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10029         return type.
10030         (nto_procfs_target::pid_to_str): Change return type.
10031         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10032         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10033         return type.
10034         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10035         (exit_lwp): Update.
10036         (attach_proc_task_lwp_callback, get_detach_signal)
10037         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10038         (linux_nat_target::resume, wait_lwp, stop_callback)
10039         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10040         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10041         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10042         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10043         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10044         type.
10045         (inf_ptrace_target::attach): Update.
10046         (inf_ptrace_target::files_info): Update.
10047         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10048         type.
10049         (go32_nat_target::pid_to_str): Change return type.
10050         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10051         (gnu_nat_target::wait): Update.
10052         (gnu_nat_target::wait): Update.
10053         (gnu_nat_target::resume): Update.
10054         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10055         (fbsd_nat_target::wait): Update.
10056         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10057         type.
10058         (darwin_nat_target::attach): Update.
10059         * corelow.c (class core_target) <pid_to_str>: Change return type.
10060         (core_target::pid_to_str): Change return type.
10061         * target.c (normal_pid_to_str): Change return type.
10062         (default_pid_to_str): Likewise.
10063         (target_pid_to_str): Change return type.
10064         (target_translate_tls_address): Update.
10065         (target_announce_detach): Update.
10066         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10067         return type.
10068         (bsd_uthread_target::pid_to_str): Change return type.
10069         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10070         type.
10071         (bsd_kvm_target::pid_to_str): Change return type.
10072         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10073         return type.
10074         (aix_thread_target::pid_to_str): Change return type.
10075         * target.h (struct target_ops) <pid_to_str>: Change return type.
10076         (target_pid_to_str, normal_pid_to_str): Likewise.
10077         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10078         type.
10079         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10080         type.
10081         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10082         return type.
10083         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10084         type.
10085         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10086         type.
10087         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10088         return type.
10089
10090 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10091
10092         * NEWS: Mention that the new default MI version is 3.  Mention
10093         changes to the output of commands and events that deal with
10094         multi-location breakpoints.
10095         * breakpoint.c: Include "mi/mi-out.h".
10096         (print_one_breakpoint): Change output syntax if using MI version
10097         >= 3.
10098         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10099         New.
10100         (mi_multi_location_breakpoint_output_fixed): New.
10101         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10102         (mi_cmd_fix_multi_location_breakpoint_output): New.
10103         (mi_multi_location_breakpoint_output_fixed): New.
10104         * mi/mi-cmds.c (mi_cmds): Register command
10105         -fix-multi-location-breakpoint-output.
10106         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10107         interpreter "mi".
10108
10109 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10110
10111         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10112         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10113         instantiate mi_ui_out based on interpreter name.
10114         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10115         * mi/mi-main.c (mi_load_progress): Likewise.
10116
10117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10118
10119         * NEWS: Combine separate "New targets" sections for 8.3.
10120
10121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10122
10123         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10124         (ppcfbsd_init_abi): Install gdbarch
10125         "fetch_tls_load_module_address" and "get_thread_local_address"
10126         methods.
10127
10128 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10129
10130         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10131         (riscv_fbsd_init_abi): Install gdbarch
10132         "fetch_tls_load_module_address" and "get_thread_local_address"
10133         methods.
10134
10135 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10136
10137         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10138         (i386fbsd_init_abi): Install gdbarch
10139         "fetch_tls_load_module_address" and "get_thread_local_address"
10140         methods.
10141
10142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10143
10144         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10145         (amd64fbsd_init_abi): Install gdbarch
10146         "fetch_tls_load_module_address" and "get_thread_local_address"
10147         methods.
10148
10149 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10150
10151         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10152         (struct fbsd_pspace_data): New type.
10153         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10154         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10155         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10156         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10157         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10158
10159 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10160
10161         * gdbtypes.c (lookup_struct_elt): New function.
10162         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10163         * gdbtypes.h (struct struct_elt): New type.
10164         (lookup_struct_elt): New prototype.
10165
10166 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10167
10168         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10169         remove disabled code block.
10170
10171 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10172
10173         * gdbarch.sh (get_thread_local_address): New method.
10174         * gdbarch.h, gdbarch.c: Regenerate.
10175         * target.c (target_translate_tls_address): Use
10176         gdbarch_get_thread_local_address if present instead of
10177         target::get_thread_local_address.
10178
10179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10180
10181         * target.h (target::get_thread_local_address): Update comment.
10182
10183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10184
10185         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10186         objfile->separate_debug_objfile_backlink if not NULL.
10187
10188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10189
10190         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10191         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10192         (amd64bsd_store_inferior_registers): Likewise.
10193         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10194         Enable segment base registers.
10195         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10196         PT_GETFSBASE and PT_GETGSBASE.
10197         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10198         PT_SETGSBASE.
10199         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10200         segment base registers.
10201         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10202
10203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10204
10205         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10206         Update calls to i386_target_description to add 'segments'
10207         parameter.
10208         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10209         add segment base registers.
10210         * arch/i386.c (i386_create_target_description): Add 'segments'
10211         parameter to enable segment base registers.
10212         * arch/i386.h (i386_create_target_description): Likewise.
10213         * features/i386/32bit-segments.xml: New file.
10214         * features/i386/32bit-segments.c: Generate.
10215         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10216         call to i386_target_description to add 'segments' parameter.
10217         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10218         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10219         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10220         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10221         if feature is present.
10222         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10223         Add 'segments' parameter to call to i386_target_description.
10224         (i386_target_description): Add 'segments' parameter to enable
10225         segment base registers.
10226         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10227         to call to i386_target_description.
10228         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10229         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10230         Define I386_NUM_REGS.
10231         (i386_target_description): Add 'segments' parameter to enable
10232         segment base registers.
10233
10234 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10235
10236         PR/24325
10237         * source-cache.c: #undef open and close, to avoid unresolved
10238         externals during linking.
10239
10240 2019-03-12  Tom Tromey  <tromey@adacore.com>
10241
10242         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10243         const.  Add initializers.
10244         (_initialize_remote): Don't initialize ptid globals.
10245
10246 2019-03-12  Pedro Alves  <palves@redhat.com>
10247
10248         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10249
10250 2019-03-12  Pedro Alves  <palves@redhat.com>
10251
10252         * cp-name-parser.y (main): Remove unused 'len' variable.
10253
10254 2019-03-12  Tom Tromey  <tromey@adacore.com>
10255
10256         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10257         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10258
10259 2019-03-12  Tom Tromey  <tromey@adacore.com>
10260
10261         * linux-nat.c (iterate_over_lwps): Update.
10262         (stop_callback): Remove parameter.
10263         (stop_wait_callback, detach_callback, resume_set_callback)
10264         (select_singlestep_lwp_callback, set_ignore_sigint)
10265         (status_callback, resumed_callback, resume_clear_callback)
10266         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10267         data parameter.
10268         (linux_nat_target::detach, linux_nat_target::resume)
10269         (linux_stop_and_wait_all_lwps, select_event_lwp)
10270         (linux_nat_filter_event, linux_nat_wait_1)
10271         (linux_nat_target::kill, linux_nat_target::stop)
10272         (linux_nat_target::stop): Update.
10273         (linux_nat_resume_callback): Change type.
10274         (resume_stopped_resumed_lwps, count_events_callback)
10275         (select_event_lwp_callback): Likewise.
10276         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10277         * arm-linux-nat.c (struct update_registers_data): Remove.
10278         (update_registers_callback): Change type.
10279         (arm_linux_insert_hw_breakpoint1): Update.
10280         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10281         parameter.
10282         (x86_linux_dr_set_addr): Update.
10283         (x86_linux_dr_set_control): Update.
10284         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10285         (iterate_over_lwps): Use gdb::function_view.
10286         * nat/aarch64-linux-hw-point.c (struct
10287         aarch64_dr_update_callback_param): Remove.
10288         (debug_reg_change_callback): Change type.
10289         (aarch64_notify_debug_reg_change): Update.
10290         * s390-linux-nat.c (s390_refresh_per_info): Update.
10291
10292 2019-03-11  Tom Tromey  <tromey@adacore.com>
10293
10294         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10295         redundant assignment to "this_cu".
10296
10297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10298
10299         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10300
10301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10302
10303         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10304         from...
10305         (rank_one_type): ... this.
10306
10307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10308
10309         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10310         from...
10311         (rank_one_type): ... this.
10312
10313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10314
10315         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10316         from...
10317         (rank_one_type): ... this.
10318
10319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10320
10321         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10322         from...
10323         (rank_one_type): ... this.
10324
10325 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10326
10327         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10328         from...
10329         (rank_one_type): ... this.
10330
10331 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10332
10333         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10334         from...
10335         (rank_one_type): ... this.
10336
10337 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10338
10339         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10340         from...
10341         (rank_one_type): ... this.
10342
10343 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10344
10345         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10346         from...
10347         (rank_one_type): ... this.
10348
10349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10350
10351         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10352         from...
10353         (rank_one_type): ... this.
10354
10355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10356
10357         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10358         from...
10359         (rank_one_type): ... this.
10360
10361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10362
10363         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10364         from...
10365         (rank_one_type): ... this.
10366
10367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10368
10369         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10370         from...
10371         (rank_one_type): ... this.
10372
10373 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10374
10375         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10376         inferior-events' shows the example events.
10377
10378 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10379
10380         Support styling on native MS-Windows console
10381
10382         PR/24315
10383         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10384         on MS-Windows if $TERM is not defined.
10385
10386         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10387
10388         * posix-hdep.c (gdb_console_fputs):
10389         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10390         functions.
10391         * ui-file.h (gdb_console_fputs): Add prototype.
10392
10393         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10394         back to fputs only if the former returns zero.
10395
10396 2019-03-07  Tom Tromey  <tom@tromey.com>
10397
10398         * symmisc.c (print_symbol_bcache_statistics): Update.
10399         (print_objfile_statistics): Update.
10400         * symfile.c (allocate_symtab): Update.
10401         * stabsread.c: Don't include bcache.h.
10402         * psymtab.h (struct psymbol_bcache): Don't declare.
10403         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10404         (psymbol_bcache_init, psymbol_bcache_free)
10405         (psymbol_bcache_get_bcache): Don't declare.
10406         * psymtab.c (struct psymbol_bcache): Remove.
10407         (psymtab_storage::psymtab_storage): Update.
10408         (psymtab_storage::~psymtab_storage): Update.
10409         (psymbol_bcache_init, psymbol_bcache_free)
10410         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10411         (add_psymbol_to_bcache): Update.
10412         (allocate_psymtab): Update.
10413         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10414         macro_cache>: No longer pointers.
10415         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10416         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10417         * macrotab.c (macro_bcache): Update.
10418         * macroexp.c: Don't include bcache.h.
10419         * gdbtypes.c (check_types_worklist): Update.
10420         (types_deeply_equal): Remove TRY/CATCH.  Update.
10421         * elfread.c (elf_symtab_read): Update.
10422         * dwarf2read.c: Don't include bcache.h.
10423         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10424         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10425         (print_bcache_statistics, bcache_memory_used): Don't declare.
10426         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10427         methods.  Rename all data members.
10428         * bcache.c (struct bcache): Move to bcache.h.
10429         (bcache::expand_hash_table): Rename from expand_hash_table.
10430         (bcache): Remove.
10431         (bcache::insert): Rename from bcache_full.
10432         (bcache::compare): Rename from bcache_compare.
10433         (bcache_xmalloc): Remove.
10434         (bcache::~bcache): Rename from bcache_xfree.
10435         (bcache::print_statistics): Rename from print_bcache_statistics.
10436         (bcache::memory_used): Rename from bcache_memory_used.
10437
10438 2019-03-07  Pedro Alves  <palves@redhat.com>
10439
10440         * infrun.c (normal_stop): Also check for
10441         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10442
10443 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10444
10445         * f-lang.c (value_from_host_double): Moved to...
10446         * value.c (value_from_host_double): ...here.
10447         * value.h (value_from_host_double): Declare.
10448         * guile/scm-math.c (vlscm_convert_typed_number): Use
10449         value_from_host_double.
10450         (vlscm_convert_number): Likewise.
10451         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10452         * python/py-value.c (convert_value_from_python): Likewise.
10453
10454 2019-03-06  Tom Tromey  <tom@tromey.com>
10455
10456         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10457
10458 2019-03-06  Tom Tromey  <tom@tromey.com>
10459
10460         * utils.h (free_current_contents): Don't declare.
10461         * utils.c (free_current_contents): Remove.
10462
10463 2019-03-06  Tom Tromey  <tom@tromey.com>
10464
10465         * top.c (quit_force): Update.
10466         * main.c (captured_command_loop): Update.
10467         * common/new-op.c (operator new): Update.
10468         * common/common-exceptions.c (struct catcher)
10469         <save_cleanup_chain>: Remove member.
10470         (exceptions_state_mc_init): Update.
10471         (exception_try_scope_entry): Return nullptr.
10472         (exception_try_scope_exit, exception_rethrow)
10473         (throw_exception_sjlj, throw_exception_cxx): Update.
10474         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10475         (all_cleanups, do_cleanups, discard_cleanups)
10476         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10477         (restore_cleanups, restore_final_cleanups): Don't declare.
10478         (do_final_cleanups): Remove parameter.
10479         * common/cleanups.c (cleanup_chain, make_cleanup)
10480         (make_cleanup_dtor, all_cleanups, do_cleanups)
10481         (discard_my_cleanups, discard_cleanups)
10482         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10483         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10484         (null_cleanup): Remove.
10485         (do_final_cleanups): Remove parameter.
10486
10487 2019-03-06  Tom Tromey  <tom@tromey.com>
10488
10489         * remote.c (remote_target::remote_parse_stop_reply): Use
10490         unique_xmalloc_ptr.
10491
10492 2019-03-06  Tom Tromey  <tom@tromey.com>
10493
10494         * stabsread.c (struct stabs_field_info): Rename from field_info.
10495         <list, fnlist>: Add initializers.
10496         <obstack>: New member.
10497         (read_member_functions, read_struct_fields, read_baseclasses):
10498         Allocate on obstack.  Don't use cleanups.
10499         (read_one_struct_field, read_member_functions, read_struct_fields)
10500         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10501         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10502         (read_struct_type): Update.
10503
10504 2019-03-06  Tom Tromey  <tom@tromey.com>
10505
10506         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10507         * common/filestuff.h (make_cleanup_close): Don't declare.
10508         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10509         Remove.
10510
10511 2019-03-06  Tom Tromey  <tom@tromey.com>
10512
10513         * solib-aix.c: Use make_scope_exit.
10514
10515 2019-03-06  Tom Tromey  <tom@tromey.com>
10516
10517         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10518         Use make_scope_exit.
10519
10520 2019-03-06  Tom Tromey  <tom@tromey.com>
10521
10522         * solib-svr4.c (disable_probes_interface): Remove parameter.
10523         (svr4_handle_solib_event): Use make_scope_exit.
10524
10525 2019-03-06  Tom Tromey  <tom@tromey.com>
10526
10527         * remote.c (struct stop_reply_deleter): Remove.
10528         (stop_reply_up): Update.
10529         (struct stop_reply): Derive from notif_event.  Don't typedef.
10530         <regcache>: Now a std::vector.
10531         (stop_reply_xfree): Remove.
10532         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10533         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10534         (remote_target::discard_pending_stop_replies): Use delete.
10535         (remote_target::remote_parse_stop_reply): Update.
10536         (remote_target::process_stop_reply): Update.
10537         * remote-notif.h (struct notif_event): Add virtual destructor.
10538         Remove "dtr" member.
10539         (struct notif_client) <alloc_event>: Return a unique_ptr.
10540         (notif_event_xfree): Don't declare.
10541         (notif_event_up): New typedef.
10542         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10543         (notif_event_xfree, do_notif_event_xfree): Remove.
10544         (remote_notif_state_xfree): Update.
10545
10546 2019-03-06  Tom Tromey  <tom@tromey.com>
10547
10548         * infrun.c (displaced_step_clear_cleanup): Now a
10549         forward_scope_exit type.
10550         (displaced_step_prepare_throw): Update.
10551         (displaced_step_fixup): Update.
10552
10553 2019-03-06  Tom Tromey  <tom@tromey.com>
10554
10555         * inferior.h (class inferior): Update comment.
10556         * gdbthread.h (class thread_info): Update comment.
10557
10558 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10559             Tom Tromey  <tom@tromey.com>
10560
10561         * stabsread.h (struct stab_section_list): Remove.
10562         (coffstab_build_psymtabs): Update.
10563         * dbxread.c (symbuf_sections): Now a std::vector.
10564         (sect_idx): New global.
10565         (fill_symbuf): Update.
10566         (coffstab_build_psymtabs): Change type of stabsects parameter.
10567         Update.
10568         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10569         std::vector.
10570         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10571         (coff_locate_sections): Update.
10572         (coff_symfile_read): Remove cleanups.  Update.
10573         (init_stringtab): Add storage parameter.
10574         (free_stringtab, free_stringtab_cleanup): Remove.
10575         (init_lineno): Add storage parameter.
10576         (free_linetab, free_linetab_cleanup): Remove.
10577
10578 2019-03-06  Pedro Alves  <palves@redhat.com>
10579
10580         * linux-fork.c (fork_info::clobber_regs): Delete.
10581         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10582         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10583         comment.  Adjust.
10584         (scoped_switch_fork_info::scoped_switch_fork_info)
10585         (checkpoint_command, linux_fork_context): Adjust
10586         fork_save_infrun_state calls.
10587
10588 2019-03-06  Pedro Alves  <palves@redhat.com>
10589
10590         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10591         (inf_has_multiple_threads): Return 'bool' and rewrite using
10592         inferior_info::threads().
10593
10594 2019-03-06  Pedro Alves  <palves@redhat.com>
10595
10596         * linux-fork.c: Include <list>.
10597         (fork_list): Now a std::list instance.
10598         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10599         (forks_exist_p, find_last_fork): Adjust.
10600         (new_fork): Delete.
10601         (one_fork_p): New.
10602         (add_fork): Adjust.
10603         (free_fork): Delete, folded into fork_info::~fork_info().
10604         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10605         Adjust.
10606         (init_fork_list): Delete.
10607         (linux_fork_killall, linux_fork_mourn_inferior)
10608         (linux_fork_detach, info_checkpoints_command): Adjust.
10609         (_initialize_linux_fork): No longer call init_fork_list.
10610
10611 2019-03-06  Pedro Alves  <palves@redhat.com>
10612
10613         * linux-fork.c (new_fork): New, split out of ...
10614         (add_fork): ... this.  Return void.  Move "first fork" special
10615         case from here, to ...
10616         (checkpoint_command): ... here.
10617         * linux-linux.h (add_fork): Return void.
10618
10619 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10620
10621         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10622
10623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10624             Chris January  <chris.january@arm.com>
10625             David Lecomber  <david.lecomber@arm.com>
10626
10627         * f-exp.y: New token, UNOP_INTRINSIC.
10628         (exp): New pattern using UNOP_INTRINSIC token.
10629         (f77_keywords): Add 'abs' keyword.
10630         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10631         (value_from_host_double): New function.
10632         (evaluate_subexp_f): Support UNOP_ABS.
10633
10634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10637         types.
10638
10639 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10642         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10643         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10644
10645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10646
10647         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10648
10649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10650             Chris January  <chris.january@arm.com>
10651
10652         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10653         * f-exp.y: Define 'KIND' token.
10654         (exp): New pattern for KIND expressions.
10655         (ptype): Handle types with a kind extension.
10656         (direct_abs_decl): Extend to spot kind extensions.
10657         (f77_keywords): Add 'kind' to the list.
10658         (push_kind_type): New function.
10659         (convert_to_kind_type): New function.
10660         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10661         * parse.c (operator_length_standard): Likewise.
10662         * parser-defs.h (enum type_pieces): Add tp_kind.
10663         * std-operator.def: Add UNOP_KIND.
10664
10665 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10666
10667         * f-exp.y (f_parse): Set yydebug.
10668
10669 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10670
10671         * f-lang.c (evaluate_subexp_f): New function.
10672         (exp_descriptor_f): New global.
10673         (f_language_defn): Use exp_descriptor_f instead of
10674         exp_descriptor_standard.
10675
10676 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10677
10678         * f-exp.y (struct token): Add comments.
10679         (dot_ops): Remove uppercase versions and the end marker.
10680         (f77_keywords): Likewise.
10681         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10682         entries in the dot_ops array are case insensitive, and use
10683         strncasecmp to compare strings.  Also some whitespace cleanup in
10684         this area.  Similar for the f77_keywords array, except entries in
10685         this list might be case sensitive.
10686
10687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10688
10689         * f-exp.y (struct f77_boolean_val): Add comments.
10690         (boolean_values): Remove uppercase versions, and end marker.
10691         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10692         and use strncasecmp to achieve case insensitivity.  Additionally,
10693         perform whitespace cleanup around this code.
10694
10695 2019-03-06  Tom Tromey  <tromey@adacore.com>
10696
10697         * remote-sim.c (gdbsim_target_open): Use result of
10698         gdb_argv::release.
10699
10700 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10701         Dirk Schubert  <dirk.schubert@arm.com>
10702         Chris January  <chris.january@arm.com>
10703
10704         * eval.c (evaluate_subexp_standard): Call Fortran argument
10705         wrapping logic.
10706         * f-lang.c (struct value): A value which can be passed into a
10707         Fortran function call.
10708         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10709         where appropriate.
10710         (struct type): Value ready for a Fortran function call.
10711         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10712         is needed.
10713         * f-lang.h (fortran_argument_convert): Declaration.
10714         (fortran_preserve_arg_pointer): Declaration.
10715         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10716
10717 2019-03-05  Tom Tromey  <tromey@adacore.com>
10718
10719         * python/py-prettyprint.c (print_string_repr): Remove #if.
10720         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10721
10722 2019-03-05  Tom Tromey  <tromey@adacore.com>
10723
10724         * target.c (the_dummy_target): Move later.  Change type to
10725         "dummy_target".
10726         (initialize_targets): Don't initialize the_dummy_target.
10727
10728 2019-03-05  Tom Tromey  <tromey@adacore.com>
10729
10730         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10731         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10732
10733 2019-03-05  Tom Tromey  <tromey@adacore.com>
10734
10735         * windows-nat.c (windows_nat_target::attach)
10736         (windows_nat_target::detach): Don't call gdb_flush.
10737         * valprint.c (generic_val_print, val_print, val_print_string):
10738         Don't call gdb_flush.
10739         * utils.c (defaulted_query): Don't call gdb_flush.
10740         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10741         * target.c (target_announce_detach): Don't call gdb_flush.
10742         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10743         * remote.c (extended_remote_target::attach): Don't call
10744         gdb_flush.
10745         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10746         * printcmd.c (do_examine): Don't call gdb_flush.
10747         (info_display_command): Don't call gdb_flush.
10748         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10749         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10750         * memattr.c (info_mem_command): Don't call gdb_flush.
10751         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10752         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10753         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10754         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10755         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10756         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10757         (gnu_nat_target::detach): Don't call gdb_flush.
10758         * f-valprint.c (f_val_print): Don't call gdb_flush.
10759         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10760         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10761         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10762         gdb_flush.
10763         * c-valprint.c (c_val_print): Don't call gdb_flush.
10764         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10765
10766 2019-03-05  Tom Tromey  <tromey@adacore.com>
10767
10768         * varobj.c (update_dynamic_varobj_children): Update.
10769         (install_default_visualizer): Use reset, not release.
10770         * value.c (set_internalvar): Update.
10771         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10772         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10773         ATTRIBUTE_UNUSED_RESULT.
10774
10775 2019-03-05  Tom Tromey  <tromey@adacore.com>
10776
10777         * remote.c (class scoped_remote_fd) <release>: Add
10778         ATTRIBUTE_UNUSED_RESULT.
10779
10780 2019-03-05  Tom Tromey  <tromey@adacore.com>
10781
10782         * macroexp.c (struct macro_buffer) <release>: Add
10783         ATTRIBUTE_UNUSED_RESULT.
10784
10785 2019-03-05  Tom Tromey  <tromey@adacore.com>
10786
10787         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10788         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10789         ATTRIBUTE_UNUSED_RESULT.
10790
10791 2019-03-05  Tom Tromey  <tromey@adacore.com>
10792
10793         * common/scoped_fd.h (class scoped_fd) <release>: Add
10794         ATTRIBUTE_UNUSED_RESULT.
10795
10796 2019-03-05  Tom Tromey  <tromey@adacore.com>
10797
10798         * parser-defs.h (struct parser_state) <release>: Add
10799         ATTRIBUTE_UNUSED_RESULT.
10800
10801 2019-03-05  Tom Tromey  <tromey@adacore.com>
10802
10803         * utils.h (class gdb_argv) <release>: Add
10804         ATTRIBUTE_UNUSED_RESULT.
10805         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10806
10807 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10808
10809         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10810         for-loop range, to avoid compiler warnings.
10811
10812         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10813         avoid compiler warnings about unused variables.
10814
10815         * NEWS: Mention end of support for native debugging on MS-Windows
10816         before XP.
10817
10818         PR gdb/24292
10819         * common/netstuff.c:
10820         * gdbserver/gdbreplay.c
10821         * gdbserver/remote-utils.c:
10822         * ser-tcp.c:
10823         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10824         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10825         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10826         'getaddrinfo' and 'freeaddrinfo' were not available before
10827         Windows XP, and mingw.org's MinGW headers by default define
10828         _WIN32_WINNT to 0x500.
10829
10830 2019-03-01  Gary Benson <gbenson@redhat.com>
10831
10832         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10833
10834 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10835             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10836
10837         PR gdb/8527
10838         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10839         set_sigint_trap, clear_sigint_trap.
10840
10841 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10842
10843         * target.c (target_detach): Clear the regcache and the
10844         frame cache.
10845
10846 2019-02-27  Pedro Alves  <palves@redhat.com>
10847
10848         * utils.c (set_screen_size): When we cap the height/width sizes,
10849         tweak the corresponding command variable to show "unlimited":
10850
10851 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10852             Pedro Alves  <palves@redhat.com>
10853
10854         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10855         before calling rl_set_screen_size.
10856
10857 2019-02-27  Tom Tromey  <tromey@adacore.com>
10858
10859         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10860         define.
10861         * python/py-value.c: Remove Python 2.4 workaround.
10862         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10863         workaround.
10864         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10865         Python 2.4 workaround.
10866         * python/python-internal.h: Remove Python 2.4 comment.
10867         (Py_ssize_t): Don't define.
10868         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10869         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10870         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10871         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10872         * python/python.c (do_start_initialization): Remove Python 2.4
10873         workaround.
10874         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10875         (print_children): Remove Python 2.4 workaround.
10876         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10877         workaround.
10878         (CHARBUFFERPROC_NAME): Remove.
10879         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10880         Python 2.4 workaround.
10881
10882 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10883
10884         * NEWS: Note minimum Python version.
10885
10886 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10887
10888         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10889         code from these functions.  Remove corresponding ifdefs.  Use
10890         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10891         Remove gotos and target of gotos.
10892         (infpy_search_memory): Likewise.
10893
10894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10895
10896         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10897         (hppa_gdbarch_init): Don't register deleted functions with
10898         gdbarch.
10899
10900 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10901
10902         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10903         (h8300_unwind_sp): Delete.
10904         (h8300_dummy_id): Delete.
10905         (h8300_gdbarch_init): Don't register deleted functions with
10906         gdbarch.
10907
10908 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10909
10910         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10911         (ft32_unwind_pc): Delete.
10912         (ft32_unwind_sp): Delete.
10913         (ft32_gdbarch_init): Don't register deleted functions with
10914         gdbarch.
10915
10916 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10917
10918         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10919         (frv_unwind_pc): Delete.
10920         (frv_unwind_sp): Delete.
10921         (frv_gdbarch_init): Don't register deleted functions with
10922         gdbarch.
10923
10924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10927         (riscv_unwind_pc): Delete.
10928         (riscv_unwind_sp): Delete.
10929         (riscv_gdbarch_init): Don't register deleted functions with
10930         gdbarch.
10931
10932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10935         (csky_unwind_pc): Delete.
10936         (csky_unwind_sp): Delete.
10937         (csky_gdbarch_init): Don't register deleted functions with
10938         gdbarch.
10939
10940 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10941
10942         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10943         (cris_unwind_pc): Delete.
10944         (cris_unwind_sp): Delete.
10945         (cris_gdbarch_init): Don't register deleted functions with
10946         gdbarch.
10947
10948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10949
10950         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10951         (bfin_unwind_pc): Delete.
10952         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10953
10954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10955
10956         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10957         (arm_unwind_pc): Delete.
10958         (arm_unwind_sp): Delete.
10959         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10960
10961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10962
10963         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10964         (arc_unwind_pc): Delete.
10965         (arc_unwind_sp): Delete.
10966         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10967
10968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10969
10970         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10971         (alpha_unwind_pc): Delete.
10972         (alpha_gdbarch_init): Don't register deleted functions with
10973         gdbarch.
10974
10975 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10976
10977         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10978         (aarch64_unwind_pc): Delete.
10979         (aarch64_unwind_sp): Delete.
10980         (aarch64_gdbarch_init): Don't register deleted functions with
10981         gdbarch.
10982
10983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10984
10985         * gdbtypes.c (type_align): Don't consider static members when
10986         computing structure alignment.
10987
10988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10989
10990         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10991         return 0 for other types.
10992         * arch-utils.c (default_type_align): Always return 0.
10993         * gdbarch.h: Regenerate.
10994         * gdbarch.sh (type_align): Extend comment.
10995         * gdbtypes.c (type_align): Add additional comments, always call
10996         gdbarch_type_align before applying the default rules.
10997         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10998         generic code will then apply a suitable default.
10999         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11000         types, return 0 for other types.
11001
11002 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11003
11004         * NEWS: Create a new section for the next release branch.
11005         Rename the section of the current branch, now that it has
11006         been cut.
11007
11008 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11009
11010         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11011         * version.in: Bump version to 8.3.50.DATE-git.
11012
11013 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11014
11015         * aix-thread.c (ptid_cmp): Remove unused variable.
11016         (get_signaled_thread): Likewise.
11017         (store_regs_user_thread): Likewise.
11018         (store_regs_kernel_thread): Likewise.
11019         (fetch_regs_kernel_thread): Remove shadowed variable.
11020
11021 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11022
11023         * features/riscv/32bit-cpu.xml: Add register numbers.
11024         * features/riscv/32bit-fpu.c: Regenerate.
11025         * features/riscv/32bit-fpu.xml: Add register numbers.
11026         * features/riscv/64bit-cpu.xml: Add register numbers.
11027         * features/riscv/64bit-fpu.c: Regenerate.
11028         * features/riscv/64bit-fpu.xml: Add register numbers.
11029
11030 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11031
11032         * NEWS: Mention two argument form of gdb.Value constructor.
11033         * python/py-value.c (convert_buffer_and_type_to_value): New
11034         function.
11035         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11036         Add support for handling an optional second argument.  Call
11037         convert_buffer_and_type_to_value as appropriate.
11038         * python/python-internal.h (Py_buffer_deleter): New struct.
11039         (Py_buffer_up): New typedef.
11040
11041 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11042
11043         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11044         instead of releasing ownership.
11045
11046 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11047
11048         * dwarf2read.c (open_and_init_dwp_file): Call
11049         elf_numsections instead of bfd_count_sections to initialize
11050         dwp_file->num_sections.
11051
11052 2019-02-25  Tom Tromey  <tromey@adacore.com>
11053
11054         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11055
11056 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11057
11058         * gcore.in: Add '--readnever' option when invoking GDB.
11059
11060 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11061
11062         * MAINTAINERS: Update my email address.
11063
11064 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11065
11066         * build-id.c (build_id_to_debug_bfd_1): New function.
11067         (build_id_to_debug_bfd): Look for separate debug file in
11068         sysroot.
11069
11070 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11071
11072         * gdbarch.sh: Update the copyright year range that is placed into
11073         generated files.
11074
11075 2019-02-22  Keith Seitz  <keiths@redhat.com>
11076
11077         PR symtab/23853
11078         * linespec.c (create_sals_line_offset): Search for the default
11079         symtab's filename instead of its fullname.
11080
11081 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11082
11083         * NEWS: Update style defaults.
11084
11085 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11086
11087         * main.c (captured_main_1): Disable styling in batch mode.
11088
11089 2019-02-20  Tom Tromey  <tom@tromey.com>
11090
11091         * symtab.c (symtab_symbol_info): Fix typos.
11092
11093 2019-02-20  Tom Tromey  <tromey@adacore.com>
11094
11095         * findcmd.c (_initialize_mem_search): Use upper case for
11096         metasyntactic variables.
11097
11098 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11099
11100         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11101         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11102
11103 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11104
11105         * top.h (source_file_name): Change to std::string.
11106         * top.c (source_file_name): Likewise.
11107         (command_line_input): Adjust.
11108         * cli/cli-script.c (script_from_file): Adjust.
11109
11110 2019-02-19  Tom Tromey  <tromey@adacore.com>
11111
11112         * ravenscar-thread.c
11113         (ravenscar_thread_target::update_thread_list): Don't call
11114         ada_build_task_list.
11115         * ada-lang.h (ada_build_task_list): Don't declare.
11116         * ada-tasks.c (struct ada_tasks_inferior_data)
11117         <task_list_valid_p>: Now bool.
11118         (read_known_tasks, ada_task_list_changed)
11119         (ada_tasks_invalidate_inferior_data): Update.
11120         (read_known_tasks_array): Return bool.
11121         (read_known_tasks_list): Likewise.
11122         (read_known_tasks): Return void.
11123         (ada_build_task_list): Now static.
11124
11125 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11128         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11129
11130 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11131
11132         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11133         variant for ada_tasks_pspace_data_handle and
11134         ada_tasks_inferior_data_handle.
11135         (ada_tasks_pspace_data_cleanup): New function.
11136         (ada_tasks_inferior_data_cleanup): New function.
11137
11138 2019-02-17  Tom Tromey  <tom@tromey.com>
11139
11140         * macrotab.h (macro_source_fullname): Return a std::string.
11141         * macrotab.c (macro_include, check_for_redefinition)
11142         (macro_undef, macro_lookup_definition, foreach_macro)
11143         (foreach_macro_in_scope): Update.
11144         (macro_source_fullname): Return a std::string.
11145         * macrocmd.c (show_pp_source_pos): Update.
11146
11147 2019-02-17  Tom Tromey  <tom@tromey.com>
11148
11149         * macrocmd.c (show_pp_source_pos): Style the file names.
11150
11151 2019-02-17  Tom Tromey  <tom@tromey.com>
11152
11153         PR tui/24197:
11154         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11155
11156 2019-02-17  Tom Tromey  <tom@tromey.com>
11157
11158         * ada-lang.c (user_select_syms): Use filtered printing.
11159         * utils.c (wrap_style): New global.
11160         (desired_style): Remove.
11161         (emit_style_escape): Add stream parameter.
11162         (set_output_style, reset_terminal_style, prompt_for_continue):
11163         Update.
11164         (flush_wrap_buffer): Only flush gdb_stdout.
11165         (wrap_here): Set wrap_style.
11166         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11167         treat escape sequences as a character.  Change when wrap buffer is
11168         flushed.
11169         (fputs_styled): Do not set the output style when the default is
11170         requested.
11171         * ui-style.h (struct ui_file_style) <is_default>: New method.
11172         * source.c (print_source_lines_base): Emit escape sequences in one
11173         piece.
11174
11175 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11176
11177         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11178         integers and enumeration types.
11179
11180 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11181
11182         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11183         instead of lookup_symbol_in_language
11184         (do_exact_match): New function.
11185         (ada_get_symbol_name_matcher): Return do_exact_match when
11186         doing a verbatim match.
11187
11188 2019-02-15  Tom Tromey  <tromey@adacore.com>
11189
11190         * ravenscar-thread.c (ravenscar_thread_target::resume)
11191         (ravenscar_thread_target::wait): Special case wildcard requests.
11192
11193 2019-02-15  Tom Tromey  <tromey@adacore.com>
11194
11195         * ravenscar-thread.c (base_ptid): Remove.
11196         (struct ravenscar_thread_target) <close>: New method.
11197         <m_base_ptid>: New member.
11198         <update_inferior_ptid, active_task, task_is_currently_active,
11199         runtime_initialized>: Declare methods.
11200         <ravenscar_thread_target>: Add constructor.
11201         (ravenscar_thread_target::task_is_currently_active)
11202         (ravenscar_thread_target::update_inferior_ptid)
11203         (ravenscar_runtime_initialized): Rename.  Now methods.
11204         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11205         (ravenscar_thread_target::update_thread_list): Update.
11206         (ravenscar_thread_target::active_task): Now method.
11207         (ravenscar_thread_target::store_registers)
11208         (ravenscar_thread_target::prepare_to_store)
11209         (ravenscar_thread_target::prepare_to_store)
11210         (ravenscar_thread_target::mourn_inferior): Update.
11211         (ravenscar_inferior_created): Use "new" to create target.
11212         (ravenscar_thread_target::get_ada_task_ptid): Update.
11213         (_initialize_ravenscar): Don't initialize base_ptid.
11214         (ravenscar_ops): Remove global.
11215
11216 2019-02-15  Tom Tromey  <tromey@adacore.com>
11217
11218         * target.h (push_target): Declare new overload.
11219         * target.c (push_target): New overload, taking an rvalue reference.
11220         * remote.c (remote_target::open_1): Use push_target overload.
11221         * corelow.c (core_target_open): Use push_target overload.
11222
11223 2019-02-15  Tom Tromey  <tromey@adacore.com>
11224
11225         * ravenscar-thread.c (is_ravenscar_task)
11226         (ravenscar_task_is_currently_active): Return bool.
11227         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11228         (_initialize_ravenscar): Remove "(void)".
11229         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11230         Return bool.
11231
11232 2019-02-15  Tom Tromey  <tromey@adacore.com>
11233
11234         * ravenscar-thread.c (ravenscar_runtime_initializer)
11235         (has_ravenscar_runtime, get_running_thread_id)
11236         (ravenscar_thread_target::resume): Fix indentation.
11237
11238 2019-02-15  Tom Tromey  <tromey@adacore.com>
11239
11240         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11241         from ravenscar_arch_ops.
11242         (sparc_ravenscar_ops::fetch_registers)
11243         (sparc_ravenscar_ops::store_registers): Now methods.
11244         (sparc_ravenscar_prepare_to_store): Remove.
11245         (sparc_ravenscar_ops): Redefine.
11246         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11247         methods and destructor.  Remove members.
11248         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11249         (ravenscar_thread_target::store_registers)
11250         (ravenscar_thread_target::prepare_to_store): Update.
11251         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11252         Remove.
11253         (struct ppc_ravenscar_powerpc_ops): Derive from
11254         ravenscar_arch_ops.
11255         (ppc_ravenscar_powerpc_ops::fetch_registers)
11256         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11257         (ppc_ravenscar_powerpc_ops): Redefine.
11258         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11259         (ppc_ravenscar_e500_ops::fetch_registers)
11260         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11261         (ppc_ravenscar_e500_ops): Redefine.
11262         * aarch64-ravenscar-thread.c
11263         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11264         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11265         (aarch64_ravenscar_fetch_registers)
11266         (aarch64_ravenscar_store_registers): Now methods.
11267         (aarch64_ravenscar_ops): Redefine.
11268
11269 2019-02-15  Tom Tromey  <tromey@adacore.com>
11270
11271         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11272         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11273         (ravenscar_thread_target::stopped_by_watchpoint)
11274         (ravenscar_thread_target::stopped_data_address)
11275         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11276
11277 2019-02-15  Tom Tromey  <tromey@adacore.com>
11278
11279         * ravenscar-thread.c: Fix some typos.
11280
11281 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11282             Tom Tromey  <tromey@adacore.com>
11283
11284         * ada-lang.c (ada_exception_sal): Change addr_string to a
11285         std::string.
11286         (create_ada_exception_catchpoint): Update.
11287
11288 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11289             Tom Tromey  <tromey@adacore.com>
11290
11291         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11292         (bp_location_ops): Remove.
11293         (base_breakpoint_allocate_location): Update.
11294         (free_bp_location): Update.
11295         * ada-lang.c (class ada_catchpoint_location)
11296         <ada_catchpoint_location>: Remove ops parameter.
11297         (ada_catchpoint_location_dtor): Remove.
11298         (ada_catchpoint_location_ops): Remove.
11299         (allocate_location_exception): Update.
11300         * breakpoint.h (struct bp_location_ops): Remove.
11301         (class bp_location) <bp_location>: Remove bp_location_ops
11302         parameter.
11303         <~bp_location>: Add destructor.
11304         <ops>: Remove.
11305
11306 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11307             Pedro Alves  <palves@redhat.com>
11308
11309         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11310         'PATH_MAX'.
11311
11312 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11313             Samuel Thibault  <samuel.thibault@gnu.org>
11314             Thomas Schwinge  <thomas@codesourcery.com>
11315
11316         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11317         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11318
11319 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11320
11321         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11322         (check_empty): Use "const char *".
11323
11324         * gnu-nat.c (gnu_nat_target::detach): Instead of
11325         'detach_inferior (pid)' call
11326         'detach_inferior (find_inferior_pid (pid))'.
11327
11328         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11329         'nat/fork-inferior.o'.
11330         * gnu-nat.c: #include "nat/fork-inferior.h".
11331
11332         * gnu-nat.c (gnu_nat_target::detach): Instead of
11333         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11334         * gnu-nat.h: #include "inf-child.h".
11335         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11336         'i386_gnu_nat_target::fetch_registers'.
11337         (gnu_store_registers): Rename/move to
11338         'i386_gnu_nat_target::store_registers'.
11339
11340         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11341         * gnu-nat.h (mach_thread_info): New function.
11342         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11343
11344         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11345
11346 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11347
11348         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11349
11350 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11351
11352         * windows-nat.c (windows_add_thread): Add new parameter
11353         "main_thread_p" with default value set to false.  Update
11354         function documentation as well as all callers.
11355         (windows_delete_thread): Likewise.
11356         (fake_create_process): Update call to windows_add_thread.
11357         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11358         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11359         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11360         call to windows_delete_thread.
11361
11362 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11363
11364         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11365
11366 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11367
11368         * symfile.c (find_separate_debug_file): Use canonical path of
11369         sysroot with child_path instead of gdb_sysroot if it is valid.
11370
11371 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11372
11373         * symfile.c (find_separate_debug_file): Use child_path to
11374         determine if an object file is under a sysroot.
11375
11376 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11377
11378         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11379         unittests/child-path-selftests.c.
11380         * common/pathstuff.c (child_path): New function.
11381         * common/pathstuff.h (child_path): New prototype.
11382         * unittests/child-path-selftests.c: New file.
11383
11384 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11385
11386         * symfile.c (find_separate_debug_file): Look for separate debug
11387         files in debug directories under the sysroot.
11388
11389 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11390
11391         * symtab.h (struct minimal_symbol data_p): New const method.
11392         (struct minimal_symbol text_p): Likewise.
11393         * symtab.c (output_source_filename): Use file name style
11394         to print file name.
11395         (print_symbol_info): Likewise.
11396         (print_msymbol_info): Use address style to print addresses.
11397         Use function name style to print executable text symbols.
11398         (expand_symtab_containing_pc): Use data_p.
11399         (find_pc_sect_compunit_symtab): Likewise.
11400
11401 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11402
11403         * breakpoint.c (describe_other_breakpoints): Use address style
11404         to print addresses.
11405         (say_where): Likewise.
11406
11407 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11408
11409         * ada-typeprint.c (print_func_type): Print function name
11410         style to print function name.
11411         * c-typeprint.c (c_print_type_1): Likewise.
11412
11413 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11414
11415         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11416         for execve.
11417
11418 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11419
11420         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11421         type_stack.
11422
11423 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11424
11425         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11426         TYPE_CODE_REF types.
11427
11428 2019-02-08  Jim Wilson  <jimw@sifive.com>
11429
11430         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11431         (riscv_linux_fregset): New.
11432         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11433
11434 2019-02-07  Tom Tromey  <tom@tromey.com>
11435
11436         * thread.c (thread_cancel_execution_command): Update.
11437         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11438         methods.
11439         (struct thread_fsm_ops): Remove.
11440         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11441         (thread_fsm_should_stop, thread_fsm_return_value)
11442         (thread_fsm_set_finished, thread_fsm_finished_p)
11443         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11444         Don't declare.
11445         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11446         * infrun.c (clear_proceed_status_thread)
11447         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11448         (print_stop_event): Update.
11449         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11450         Add constructor.
11451         (step_command_fsm_ops): Remove.
11452         (new_step_command_fsm): Remove.
11453         (step_1): Update.
11454         (step_command_fsm::should_stop): Rename from
11455         step_command_fsm_should_stop.
11456         (step_command_fsm::clean_up): Rename from
11457         step_command_fsm_clean_up.
11458         (step_command_fsm::do_async_reply_reason): Rename from
11459         step_command_fsm_async_reply_reason.
11460         (struct until_next_fsm): Inherit from thread_fsm.  Add
11461         constructor.
11462         (until_next_fsm_ops): Remove.
11463         (new_until_next_fsm): Remove.
11464         (until_next_fsm::should_stop): Rename from
11465         until_next_fsm_should_stop.
11466         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11467         (until_next_fsm::do_async_reply_reason): Rename from
11468         until_next_fsm_async_reply_reason.
11469         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11470         constructor.  Change type of breakpoint.
11471         (finish_command_fsm_ops): Remove.
11472         (new_finish_command_fsm): Remove.
11473         (finish_command_fsm::should_stop): Rename from
11474         finish_command_fsm_should_stop.
11475         (finish_command_fsm::clean_up): Rename from
11476         finish_command_fsm_clean_up.
11477         (finish_command_fsm::return_value): Rename from
11478         finish_command_fsm_return_value.
11479         (finish_command_fsm::do_async_reply_reason): Rename from
11480         finish_command_fsm_async_reply_reason.
11481         (finish_command): Update.
11482         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11483         Add constructor.
11484         (call_thread_fsm_ops): Remove.
11485         (call_thread_fsm::call_thread_fsm): Rename from
11486         new_call_thread_fsm.
11487         (call_thread_fsm::should_stop): Rename from
11488         call_thread_fsm_should_stop.
11489         (call_thread_fsm::should_notify_stop): Rename from
11490         call_thread_fsm_should_notify_stop.
11491         (run_inferior_call, call_function_by_hand_dummy): Update.
11492         * cli/cli-interp.c (should_print_stop_to_console): Update.
11493         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11494         Add constructor.  Change type of location_breakpoint,
11495         caller_breakpoint.
11496         (until_break_fsm_ops): Remove.
11497         (new_until_break_fsm): Remove.
11498         (until_break_fsm::should_stop): Rename from
11499         until_break_fsm_should_stop.
11500         (until_break_fsm::clean_up): Rename from
11501         until_break_fsm_clean_up.
11502         (until_break_fsm::do_async_reply_reason): Rename from
11503         until_break_fsm_async_reply_reason.
11504         (until_break_command): Update.
11505         * thread-fsm.c: Remove.
11506         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11507
11508 2019-02-07  Tom Tromey  <tom@tromey.com>
11509
11510         * yy-remap.h: Add include guard.
11511         * xtensa-tdep.h: Add include guard.
11512         * xcoffread.h: Rename include guard.
11513         * varobj-iter.h: Add include guard.
11514         * tui/tui.h: Rename include guard.
11515         * tui/tui-winsource.h: Rename include guard.
11516         * tui/tui-wingeneral.h: Rename include guard.
11517         * tui/tui-windata.h: Rename include guard.
11518         * tui/tui-win.h: Rename include guard.
11519         * tui/tui-stack.h: Rename include guard.
11520         * tui/tui-source.h: Rename include guard.
11521         * tui/tui-regs.h: Rename include guard.
11522         * tui/tui-out.h: Rename include guard.
11523         * tui/tui-layout.h: Rename include guard.
11524         * tui/tui-io.h: Rename include guard.
11525         * tui/tui-hooks.h: Rename include guard.
11526         * tui/tui-file.h: Rename include guard.
11527         * tui/tui-disasm.h: Rename include guard.
11528         * tui/tui-data.h: Rename include guard.
11529         * tui/tui-command.h: Rename include guard.
11530         * tic6x-tdep.h: Add include guard.
11531         * target/waitstatus.h: Rename include guard.
11532         * target/wait.h: Rename include guard.
11533         * target/target.h: Rename include guard.
11534         * target/resume.h: Rename include guard.
11535         * target-float.h: Rename include guard.
11536         * stabsread.h: Add include guard.
11537         * rs6000-tdep.h: Add include guard.
11538         * riscv-fbsd-tdep.h: Add include guard.
11539         * regformats/regdef.h: Rename include guard.
11540         * record.h: Rename include guard.
11541         * python/python.h: Rename include guard.
11542         * python/python-internal.h: Rename include guard.
11543         * python/py-stopevent.h: Rename include guard.
11544         * python/py-ref.h: Rename include guard.
11545         * python/py-record.h: Rename include guard.
11546         * python/py-record-full.h: Rename include guard.
11547         * python/py-record-btrace.h: Rename include guard.
11548         * python/py-instruction.h: Rename include guard.
11549         * python/py-events.h: Rename include guard.
11550         * python/py-event.h: Rename include guard.
11551         * procfs.h: Add include guard.
11552         * proc-utils.h: Add include guard.
11553         * p-lang.h: Add include guard.
11554         * or1k-tdep.h: Rename include guard.
11555         * observable.h: Rename include guard.
11556         * nto-tdep.h: Rename include guard.
11557         * nat/x86-linux.h: Rename include guard.
11558         * nat/x86-linux-dregs.h: Rename include guard.
11559         * nat/x86-gcc-cpuid.h: Add include guard.
11560         * nat/x86-dregs.h: Rename include guard.
11561         * nat/x86-cpuid.h: Rename include guard.
11562         * nat/ppc-linux.h: Rename include guard.
11563         * nat/mips-linux-watch.h: Rename include guard.
11564         * nat/linux-waitpid.h: Rename include guard.
11565         * nat/linux-ptrace.h: Rename include guard.
11566         * nat/linux-procfs.h: Rename include guard.
11567         * nat/linux-osdata.h: Rename include guard.
11568         * nat/linux-nat.h: Rename include guard.
11569         * nat/linux-namespaces.h: Rename include guard.
11570         * nat/linux-btrace.h: Rename include guard.
11571         * nat/glibc_thread_db.h: Rename include guard.
11572         * nat/gdb_thread_db.h: Rename include guard.
11573         * nat/gdb_ptrace.h: Rename include guard.
11574         * nat/fork-inferior.h: Rename include guard.
11575         * nat/amd64-linux-siginfo.h: Rename include guard.
11576         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11577         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11578         * nat/aarch64-linux.h: Rename include guard.
11579         * nat/aarch64-linux-hw-point.h: Rename include guard.
11580         * mn10300-tdep.h: Add include guard.
11581         * mips-linux-tdep.h: Add include guard.
11582         * mi/mi-parse.h: Rename include guard.
11583         * mi/mi-out.h: Rename include guard.
11584         * mi/mi-main.h: Rename include guard.
11585         * mi/mi-interp.h: Rename include guard.
11586         * mi/mi-getopt.h: Rename include guard.
11587         * mi/mi-console.h: Rename include guard.
11588         * mi/mi-common.h: Rename include guard.
11589         * mi/mi-cmds.h: Rename include guard.
11590         * mi/mi-cmd-break.h: Rename include guard.
11591         * m2-lang.h: Add include guard.
11592         * location.h: Rename include guard.
11593         * linux-record.h: Rename include guard.
11594         * linux-nat.h: Add include guard.
11595         * linux-fork.h: Add include guard.
11596         * i386-darwin-tdep.h: Rename include guard.
11597         * hppa-linux-offsets.h: Add include guard.
11598         * guile/guile.h: Rename include guard.
11599         * guile/guile-internal.h: Rename include guard.
11600         * gnu-nat.h: Rename include guard.
11601         * gdb-stabs.h: Rename include guard.
11602         * frv-tdep.h: Add include guard.
11603         * f-lang.h: Add include guard.
11604         * event-loop.h: Add include guard.
11605         * darwin-nat.h: Rename include guard.
11606         * cp-abi.h: Rename include guard.
11607         * config/sparc/nm-sol2.h: Rename include guard.
11608         * config/nm-nto.h: Rename include guard.
11609         * config/nm-linux.h: Add include guard.
11610         * config/i386/nm-i386gnu.h: Rename include guard.
11611         * config/djgpp/nl_types.h: Rename include guard.
11612         * config/djgpp/langinfo.h: Rename include guard.
11613         * compile/gcc-cp-plugin.h: Add include guard.
11614         * compile/gcc-c-plugin.h: Add include guard.
11615         * compile/compile.h: Rename include guard.
11616         * compile/compile-object-run.h: Rename include guard.
11617         * compile/compile-object-load.h: Rename include guard.
11618         * compile/compile-internal.h: Rename include guard.
11619         * compile/compile-cplus.h: Rename include guard.
11620         * compile/compile-c.h: Rename include guard.
11621         * common/xml-utils.h: Rename include guard.
11622         * common/x86-xstate.h: Rename include guard.
11623         * common/version.h: Rename include guard.
11624         * common/vec.h: Rename include guard.
11625         * common/tdesc.h: Rename include guard.
11626         * common/selftest.h: Rename include guard.
11627         * common/scoped_restore.h: Rename include guard.
11628         * common/scoped_mmap.h: Rename include guard.
11629         * common/scoped_fd.h: Rename include guard.
11630         * common/safe-iterator.h: Rename include guard.
11631         * common/run-time-clock.h: Rename include guard.
11632         * common/refcounted-object.h: Rename include guard.
11633         * common/queue.h: Rename include guard.
11634         * common/ptid.h: Rename include guard.
11635         * common/print-utils.h: Rename include guard.
11636         * common/preprocessor.h: Rename include guard.
11637         * common/pathstuff.h: Rename include guard.
11638         * common/observable.h: Rename include guard.
11639         * common/netstuff.h: Rename include guard.
11640         * common/job-control.h: Rename include guard.
11641         * common/host-defs.h: Rename include guard.
11642         * common/gdb_wait.h: Rename include guard.
11643         * common/gdb_vecs.h: Rename include guard.
11644         * common/gdb_unlinker.h: Rename include guard.
11645         * common/gdb_unique_ptr.h: Rename include guard.
11646         * common/gdb_tilde_expand.h: Rename include guard.
11647         * common/gdb_sys_time.h: Rename include guard.
11648         * common/gdb_string_view.h: Rename include guard.
11649         * common/gdb_splay_tree.h: Rename include guard.
11650         * common/gdb_setjmp.h: Rename include guard.
11651         * common/gdb_ref_ptr.h: Rename include guard.
11652         * common/gdb_optional.h: Rename include guard.
11653         * common/gdb_locale.h: Rename include guard.
11654         * common/gdb_assert.h: Rename include guard.
11655         * common/filtered-iterator.h: Rename include guard.
11656         * common/filestuff.h: Rename include guard.
11657         * common/fileio.h: Rename include guard.
11658         * common/environ.h: Rename include guard.
11659         * common/common-utils.h: Rename include guard.
11660         * common/common-types.h: Rename include guard.
11661         * common/common-regcache.h: Rename include guard.
11662         * common/common-inferior.h: Rename include guard.
11663         * common/common-gdbthread.h: Rename include guard.
11664         * common/common-exceptions.h: Rename include guard.
11665         * common/common-defs.h: Rename include guard.
11666         * common/common-debug.h: Rename include guard.
11667         * common/cleanups.h: Rename include guard.
11668         * common/buffer.h: Rename include guard.
11669         * common/btrace-common.h: Rename include guard.
11670         * common/break-common.h: Rename include guard.
11671         * cli/cli-utils.h: Rename include guard.
11672         * cli/cli-style.h: Rename include guard.
11673         * cli/cli-setshow.h: Rename include guard.
11674         * cli/cli-script.h: Rename include guard.
11675         * cli/cli-interp.h: Rename include guard.
11676         * cli/cli-decode.h: Rename include guard.
11677         * cli/cli-cmds.h: Rename include guard.
11678         * charset-list.h: Add include guard.
11679         * buildsym-legacy.h: Rename include guard.
11680         * bfin-tdep.h: Add include guard.
11681         * ax.h: Rename include guard.
11682         * arm-linux-tdep.h: Add include guard.
11683         * arm-fbsd-tdep.h: Add include guard.
11684         * arch/xtensa.h: Rename include guard.
11685         * arch/tic6x.h: Add include guard.
11686         * arch/i386.h: Add include guard.
11687         * arch/arm.h: Rename include guard.
11688         * arch/arm-linux.h: Rename include guard.
11689         * arch/arm-get-next-pcs.h: Rename include guard.
11690         * arch/amd64.h: Add include guard.
11691         * arch/aarch64-insn.h: Rename include guard.
11692         * arch-utils.h: Rename include guard.
11693         * annotate.h: Add include guard.
11694         * amd64-darwin-tdep.h: Rename include guard.
11695         * aarch64-linux-tdep.h: Add include guard.
11696         * aarch64-fbsd-tdep.h: Add include guard.
11697         * aarch32-linux-nat.h: Add include guard.
11698
11699 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11700
11701         * macrotab.c (macro_define_internal): New function that
11702         factorizes macro_define_object_internal and macro_define_function
11703         code.
11704         (macro_define_object_internal): Use macro_define_internal.
11705         (macro_define_function): Likewise.
11706
11707 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11708
11709         * macrocmd.c (extract_identifier): Return
11710         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11711         callers.
11712
11713 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11714
11715         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11716
11717 2019-02-05  Tom Tromey  <tom@tromey.com>
11718
11719         * target.c (target_stack::unpush): Move assertion earlier.
11720
11721 2019-01-30  Tom Tromey  <tom@tromey.com>
11722
11723         PR python/23615:
11724         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11725         (gdbpy_parse_and_eval): Likewise.
11726         * python/python-internal.h (gdbpy_allow_threads): New class.
11727
11728 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11729
11730         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11731         (aarch64_fbsd_fpregmap): Move earlier.
11732         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11733         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11734         instead of individual calls to trad_frame_set_reg_addr.
11735         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11736         earlier.
11737         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11738         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11739         instead of individual calls to trad_frame_set_reg_addr.
11740
11741 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11742
11743         * CONTRIBUTE: Replace contribution list with wiki link.
11744
11745 2019-01-25  Tom Tromey  <tom@tromey.com>
11746
11747         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11748
11749 2019-01-25  Tom Tromey  <tom@tromey.com>
11750
11751         * xtensa-linux-nat.c: Fix common/ includes.
11752         * xml-support.h: Fix common/ includes.
11753         * xml-support.c: Fix common/ includes.
11754         * x86-linux-nat.c: Fix common/ includes.
11755         * windows-nat.c: Fix common/ includes.
11756         * varobj.h: Fix common/ includes.
11757         * varobj.c: Fix common/ includes.
11758         * value.c: Fix common/ includes.
11759         * valops.c: Fix common/ includes.
11760         * utils.c: Fix common/ includes.
11761         * unittests/xml-utils-selftests.c: Fix common/ includes.
11762         * unittests/utils-selftests.c: Fix common/ includes.
11763         * unittests/unpack-selftests.c: Fix common/ includes.
11764         * unittests/tracepoint-selftests.c: Fix common/ includes.
11765         * unittests/style-selftests.c: Fix common/ includes.
11766         * unittests/string_view-selftests.c: Fix common/ includes.
11767         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11768         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11769         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11770         * unittests/rsp-low-selftests.c: Fix common/ includes.
11771         * unittests/parse-connection-spec-selftests.c: Fix common/
11772         includes.
11773         * unittests/optional-selftests.c: Fix common/ includes.
11774         * unittests/offset-type-selftests.c: Fix common/ includes.
11775         * unittests/observable-selftests.c: Fix common/ includes.
11776         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11777         * unittests/memrange-selftests.c: Fix common/ includes.
11778         * unittests/memory-map-selftests.c: Fix common/ includes.
11779         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11780         * unittests/function-view-selftests.c: Fix common/ includes.
11781         * unittests/environ-selftests.c: Fix common/ includes.
11782         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11783         * unittests/common-utils-selftests.c: Fix common/ includes.
11784         * unittests/cli-utils-selftests.c: Fix common/ includes.
11785         * unittests/array-view-selftests.c: Fix common/ includes.
11786         * ui-file.c: Fix common/ includes.
11787         * tui/tui-io.c: Fix common/ includes.
11788         * tracepoint.h: Fix common/ includes.
11789         * tracepoint.c: Fix common/ includes.
11790         * tracefile-tfile.c: Fix common/ includes.
11791         * top.h: Fix common/ includes.
11792         * top.c: Fix common/ includes.
11793         * thread.c: Fix common/ includes.
11794         * target/waitstatus.h: Fix common/ includes.
11795         * target/waitstatus.c: Fix common/ includes.
11796         * target.h: Fix common/ includes.
11797         * target.c: Fix common/ includes.
11798         * target-memory.c: Fix common/ includes.
11799         * target-descriptions.c: Fix common/ includes.
11800         * symtab.h: Fix common/ includes.
11801         * symfile.c: Fix common/ includes.
11802         * stap-probe.c: Fix common/ includes.
11803         * spu-linux-nat.c: Fix common/ includes.
11804         * sparc-nat.c: Fix common/ includes.
11805         * source.c: Fix common/ includes.
11806         * solib.c: Fix common/ includes.
11807         * solib-target.c: Fix common/ includes.
11808         * ser-unix.c: Fix common/ includes.
11809         * ser-tcp.c: Fix common/ includes.
11810         * ser-pipe.c: Fix common/ includes.
11811         * ser-base.c: Fix common/ includes.
11812         * selftest-arch.c: Fix common/ includes.
11813         * s12z-tdep.c: Fix common/ includes.
11814         * rust-exp.y: Fix common/ includes.
11815         * rs6000-aix-tdep.c: Fix common/ includes.
11816         * riscv-tdep.c: Fix common/ includes.
11817         * remote.c: Fix common/ includes.
11818         * remote-notif.h: Fix common/ includes.
11819         * remote-fileio.h: Fix common/ includes.
11820         * remote-fileio.c: Fix common/ includes.
11821         * regcache.h: Fix common/ includes.
11822         * regcache.c: Fix common/ includes.
11823         * record-btrace.c: Fix common/ includes.
11824         * python/python.c: Fix common/ includes.
11825         * python/py-type.c: Fix common/ includes.
11826         * python/py-inferior.c: Fix common/ includes.
11827         * progspace.h: Fix common/ includes.
11828         * producer.c: Fix common/ includes.
11829         * procfs.c: Fix common/ includes.
11830         * proc-api.c: Fix common/ includes.
11831         * printcmd.c: Fix common/ includes.
11832         * ppc-linux-nat.c: Fix common/ includes.
11833         * parser-defs.h: Fix common/ includes.
11834         * osdata.c: Fix common/ includes.
11835         * obsd-nat.c: Fix common/ includes.
11836         * nat/x86-linux.c: Fix common/ includes.
11837         * nat/x86-linux-dregs.c: Fix common/ includes.
11838         * nat/x86-dregs.h: Fix common/ includes.
11839         * nat/x86-dregs.c: Fix common/ includes.
11840         * nat/ppc-linux.c: Fix common/ includes.
11841         * nat/mips-linux-watch.h: Fix common/ includes.
11842         * nat/mips-linux-watch.c: Fix common/ includes.
11843         * nat/linux-waitpid.c: Fix common/ includes.
11844         * nat/linux-ptrace.h: Fix common/ includes.
11845         * nat/linux-ptrace.c: Fix common/ includes.
11846         * nat/linux-procfs.c: Fix common/ includes.
11847         * nat/linux-personality.c: Fix common/ includes.
11848         * nat/linux-osdata.c: Fix common/ includes.
11849         * nat/linux-namespaces.c: Fix common/ includes.
11850         * nat/linux-btrace.h: Fix common/ includes.
11851         * nat/linux-btrace.c: Fix common/ includes.
11852         * nat/fork-inferior.c: Fix common/ includes.
11853         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11854         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11855         * nat/aarch64-linux.c: Fix common/ includes.
11856         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11857         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11858         * namespace.h: Fix common/ includes.
11859         * mips-linux-tdep.c: Fix common/ includes.
11860         * minsyms.c: Fix common/ includes.
11861         * mi/mi-parse.h: Fix common/ includes.
11862         * mi/mi-main.c: Fix common/ includes.
11863         * mi/mi-cmd-env.c: Fix common/ includes.
11864         * memrange.h: Fix common/ includes.
11865         * memattr.c: Fix common/ includes.
11866         * maint.h: Fix common/ includes.
11867         * maint.c: Fix common/ includes.
11868         * main.c: Fix common/ includes.
11869         * machoread.c: Fix common/ includes.
11870         * location.c: Fix common/ includes.
11871         * linux-thread-db.c: Fix common/ includes.
11872         * linux-nat.c: Fix common/ includes.
11873         * linux-fork.c: Fix common/ includes.
11874         * inline-frame.c: Fix common/ includes.
11875         * infrun.c: Fix common/ includes.
11876         * inflow.c: Fix common/ includes.
11877         * inferior.h: Fix common/ includes.
11878         * inferior.c: Fix common/ includes.
11879         * infcmd.c: Fix common/ includes.
11880         * inf-ptrace.c: Fix common/ includes.
11881         * inf-child.c: Fix common/ includes.
11882         * ia64-linux-nat.c: Fix common/ includes.
11883         * i387-tdep.c: Fix common/ includes.
11884         * i386-tdep.c: Fix common/ includes.
11885         * i386-linux-tdep.c: Fix common/ includes.
11886         * i386-linux-nat.c: Fix common/ includes.
11887         * i386-go32-tdep.c: Fix common/ includes.
11888         * i386-fbsd-tdep.c: Fix common/ includes.
11889         * i386-fbsd-nat.c: Fix common/ includes.
11890         * guile/scm-type.c: Fix common/ includes.
11891         * guile/guile.c: Fix common/ includes.
11892         * go32-nat.c: Fix common/ includes.
11893         * gnu-nat.c: Fix common/ includes.
11894         * gdbthread.h: Fix common/ includes.
11895         * gdbarch-selftests.c: Fix common/ includes.
11896         * gdb_usleep.c: Fix common/ includes.
11897         * gdb_select.h: Fix common/ includes.
11898         * gdb_bfd.c: Fix common/ includes.
11899         * gcore.c: Fix common/ includes.
11900         * fork-child.c: Fix common/ includes.
11901         * findvar.c: Fix common/ includes.
11902         * fbsd-nat.c: Fix common/ includes.
11903         * event-top.c: Fix common/ includes.
11904         * event-loop.c: Fix common/ includes.
11905         * dwarf2read.c: Fix common/ includes.
11906         * dwarf2loc.c: Fix common/ includes.
11907         * dwarf2-frame.c: Fix common/ includes.
11908         * dwarf-index-cache.c: Fix common/ includes.
11909         * dtrace-probe.c: Fix common/ includes.
11910         * disasm-selftests.c: Fix common/ includes.
11911         * defs.h: Fix common/ includes.
11912         * csky-tdep.c: Fix common/ includes.
11913         * cp-valprint.c: Fix common/ includes.
11914         * cp-support.h: Fix common/ includes.
11915         * cp-support.c: Fix common/ includes.
11916         * corelow.c: Fix common/ includes.
11917         * completer.h: Fix common/ includes.
11918         * completer.c: Fix common/ includes.
11919         * compile/compile.c: Fix common/ includes.
11920         * compile/compile-loc2c.c: Fix common/ includes.
11921         * compile/compile-cplus-types.c: Fix common/ includes.
11922         * compile/compile-cplus-symbols.c: Fix common/ includes.
11923         * command.h: Fix common/ includes.
11924         * cli/cli-dump.c: Fix common/ includes.
11925         * cli/cli-cmds.c: Fix common/ includes.
11926         * charset.c: Fix common/ includes.
11927         * build-id.c: Fix common/ includes.
11928         * btrace.h: Fix common/ includes.
11929         * btrace.c: Fix common/ includes.
11930         * breakpoint.h: Fix common/ includes.
11931         * breakpoint.c: Fix common/ includes.
11932         * ax.h:
11933         (enum agent_op): Fix common/ includes.
11934         * ax-general.c (struct aop_map): Fix common/ includes.
11935         * ax-gdb.c: Fix common/ includes.
11936         * auxv.c: Fix common/ includes.
11937         * auto-load.c: Fix common/ includes.
11938         * arm-tdep.c: Fix common/ includes.
11939         * arch/riscv.c: Fix common/ includes.
11940         * arch/ppc-linux-common.c: Fix common/ includes.
11941         * arch/i386.c: Fix common/ includes.
11942         * arch/arm.c: Fix common/ includes.
11943         * arch/arm-linux.c: Fix common/ includes.
11944         * arch/arm-get-next-pcs.c: Fix common/ includes.
11945         * arch/amd64.c: Fix common/ includes.
11946         * arch/aarch64.c: Fix common/ includes.
11947         * arch/aarch64-insn.c: Fix common/ includes.
11948         * arch-utils.c: Fix common/ includes.
11949         * amd64-windows-tdep.c: Fix common/ includes.
11950         * amd64-tdep.c: Fix common/ includes.
11951         * amd64-sol2-tdep.c: Fix common/ includes.
11952         * amd64-obsd-tdep.c: Fix common/ includes.
11953         * amd64-nbsd-tdep.c: Fix common/ includes.
11954         * amd64-linux-tdep.c: Fix common/ includes.
11955         * amd64-linux-nat.c: Fix common/ includes.
11956         * amd64-fbsd-tdep.c: Fix common/ includes.
11957         * amd64-fbsd-nat.c: Fix common/ includes.
11958         * amd64-dicos-tdep.c: Fix common/ includes.
11959         * amd64-darwin-tdep.c: Fix common/ includes.
11960         * agent.c: Fix common/ includes.
11961         * ada-lang.h: Fix common/ includes.
11962         * ada-lang.c: Fix common/ includes.
11963         * aarch64-tdep.c: Fix common/ includes.
11964
11965 2019-01-25  Tom Tromey  <tom@tromey.com>
11966
11967         * common/create-version.sh: Use common/version.h.
11968
11969 2019-01-24  Pedro Alves  <palves@redhat.com>
11970
11971         * infrun.c (signal_stop, signal_print, signal_program)
11972         (signal_catch, signal_pass): Now arrays instead of pointers.
11973         (update_signals_program_target, do_target_resume)
11974         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11975         * linux-nat.c (linux_nat_target::pass_signals)
11976         (linux_nat_target::create_inferior, linux_nat_target::attach):
11977         Adjust.
11978         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11979         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11980         * procfs.c (procfs_target::pass_signals): Adjust.
11981         * record-full.c (record_full_target::resume): Adjust.
11982         * remote.c (remote_target::pass_signals)
11983         (remote_target::program_signals): Adjust.
11984         * target-debug.h (target_debug_print_signals): Now takes a
11985         gdb::array_view as parameter.  Adjust.
11986         * target.h (target_ops) <pass_signals, program_signals>: Replace
11987         pointer and length parameters with gdb::array_view.
11988         (target_pass_signals, target_program_signals): Likewise.
11989         * target-delegates.c: Regenerate.
11990
11991 2019-01-24  Pedro Alves  <palves@redhat.com>
11992
11993         * common/forward-scope-exit.h
11994         (forward_scope_exit::forward_scope_exit): Pass arguments to
11995         m_bind_function directly, instead of creating a std::bind and
11996         copying that.
11997
11998 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11999
12000         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12001         for static members.
12002         (pass_in_v_vfp_candidate): Likewise.
12003
12004 2019-01-23  Tom Tromey  <tom@tromey.com>
12005             Pedro Alves  <palves@redhat.com>
12006
12007         * regcache.c (class regcache_invalidator): Remove.
12008         (regcache::raw_write): Use make_scope_exit.
12009
12010 2019-01-23  Tom Tromey  <tom@tromey.com>
12011
12012         * ui-out.h (class ui_out_emit_type): Update comment.
12013
12014 2019-01-23  Tom Tromey  <tom@tromey.com>
12015
12016         * infrun.c (fetch_inferior_event): Update comment.
12017
12018 2019-01-23  Tom Tromey  <tom@tromey.com>
12019             Pedro Alves  <palves@redhat.com>
12020
12021         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12022         parameter.
12023         (fetch_inferior_event): Use SCOPE_EXIT.
12024
12025
12026 2019-01-23  Tom Tromey  <tom@tromey.com>
12027             Pedro Alves  <palves@redhat.com>
12028
12029         * infrun.c (disable_thread_events): Delete.
12030         (stop_all_threads): Use SCOPE_EXIT.
12031
12032 2019-01-23  Tom Tromey  <tom@tromey.com>
12033             Pedro Alves  <palves@redhat.com>
12034
12035         * symfile.c: Include forward-scope-exit.h.
12036         (clear_symtab_users_cleanup): Replace forward declaration with
12037         a FORWARD_SCOPE_EXIT.
12038         (syms_from_objfile_1): Use the forward_scope_exit and
12039         gdb::optional instead of cleanup_function.
12040         (reread_symbols): Use the forward_scope_exit instead of
12041         cleanup_function.
12042         (clear_symtab_users_cleanup): Remove function.
12043
12044 2019-01-23  Tom Tromey  <tom@tromey.com>
12045             Pedro Alves  <palves@redhat.com>
12046
12047         * linux-nat.c: Include scope-exit.h.
12048         (cleanup_target_stop): Remove.
12049         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12050         SCOPE_EXIT.
12051
12052 2019-01-23  Tom Tromey  <tom@tromey.com>
12053             Pedro Alves  <palves@redhat.com>
12054
12055         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12056         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12057
12058 2019-01-23  Tom Tromey  <tom@tromey.com>
12059             Andrew Burgess  <andrew.burgess@embecosm.com>
12060             Pedro Alves  <palves@redhat.com>
12061
12062         * infrun.c (fetch_inferior_event): Use scope_exit.
12063         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12064         * top.c (execute_command): Use scope_exit.
12065         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12066         * utils.c (do_bpstat_clear_actions_cleanup)
12067         (make_bpstat_clear_actions_cleanup): Remove.
12068
12069 2019-01-23  Tom Tromey  <tom@tromey.com>
12070             Pedro Alves  <palves@redhat.com>
12071
12072         * infrun.c: Include "common/scope-exit.h"
12073         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12074         (wait_for_inferior): Use SCOPE_EXIT.
12075         (fetch_inferior_event): Use scope_exit.
12076
12077 2019-01-23  Tom Tromey  <tom@tromey.com>
12078             Pedro Alves  <palves@redhat.com>
12079
12080         * breakpoint.c (create_breakpoint): Remove cleanup.
12081
12082 2019-01-23  Tom Tromey  <tom@tromey.com>
12083             Andrew Burgess  <andrew.burgess@embecosm.com>
12084             Pedro Alves  <palves@redhat.com>
12085
12086 2019-01-23  Pedro Alves  <palves@redhat.com>
12087
12088         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12089
12090 2019-01-23  Pedro Alves  <palves@redhat.com>
12091             Andrew Burgess  <andrew.burgess@embecosm.com>
12092
12093         * gdbthread.h: Include "common/forward-scope-exit.h".
12094         (scoped_finish_thread_state): Redefine custom class in terms of
12095         forward_scope_exit.
12096
12097 2019-01-23  Pedro Alves  <palves@redhat.com>
12098             Andrew Burgess  <andrew.burgess@embecosm.com>
12099
12100         * common/forward-scope-exit.h: New file.
12101
12102 2019-01-23  Pedro Alves  <palves@redhat.com>
12103             Andrew Burgess  <andrew.burgess@embecosm.com>
12104             Tom Tromey  <tom@tromey.com>
12105
12106         * common/scope-exit.h: New file.
12107
12108 2019-01-23  Pedro Alves  <palves@redhat.com>
12109
12110         * common/preprocessor.h (ESC): Rename to ...
12111         (ESC_PARENS): ... this.
12112         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12113         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12114
12115 2019-01-23  Tom Tromey  <tom@tromey.com>
12116
12117         * language.h (class scoped_switch_to_sym_language_if_auto):
12118         Initialize m_lang in both cases.
12119
12120 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12121
12122         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12123         with XCNEW.
12124
12125 2019-01-22  Tom Tromey  <tom@tromey.com>
12126
12127         * corelow.c: Do not include sys/file.h.
12128
12129 2019-01-22  Tom Tromey  <tom@tromey.com>
12130
12131         * tui/tui-wingeneral.h: Include gdb_curses.h.
12132
12133 2019-01-22  Tom Tromey  <tom@tromey.com>
12134
12135         * source-cache.h (class source_cache) <get_source_lines,
12136         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12137
12138 2019-01-22  Tom Tromey  <tom@tromey.com>
12139
12140         * remote-fileio.h (struct remote_target): Declare.
12141
12142 2019-01-22  Tom Tromey  <tom@tromey.com>
12143
12144         * python/py-arch.c: Do not include py-ref.h.
12145         * python/py-bpevent.c: Do not include py-ref.h.
12146         * python/py-cmd.c: Do not include py-ref.h.
12147         * python/py-continueevent.c: Do not include py-ref.h.
12148         * python/py-event.h: Do not include py-ref.h.
12149         * python/py-evtregistry.c: Do not include py-ref.h.
12150         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12151         * python/py-frame.c: Do not include py-ref.h.
12152         * python/py-framefilter.c: Do not include py-ref.h.
12153         * python/py-function.c: Do not include py-ref.h.
12154         * python/py-infevents.c: Do not include py-ref.h.
12155         * python/py-linetable.c: Do not include py-ref.h.
12156         * python/py-objfile.c: Do not include py-ref.h.
12157         * python/py-param.c: Do not include py-ref.h.
12158         * python/py-prettyprint.c: Do not include py-ref.h.
12159         * python/py-progspace.c: Do not include py-ref.h.
12160         * python/py-symbol.c: Do not include py-ref.h.
12161         * python/py-symtab.c: Do not include py-ref.h.
12162         * python/py-type.c: Do not include py-ref.h.
12163         * python/py-unwind.c: Do not include py-ref.h.
12164         * python/py-utils.c: Do not include py-ref.h.
12165         * python/py-value.c: Do not include py-ref.h.
12166         * python/py-varobj.c: Do not include py-ref.h.
12167         * python/py-xmethods.c: Do not include py-ref.h.
12168         * python/python.c: Do not include py-ref.h.
12169         * varobj.c: Do not include py-ref.h.
12170
12171 2019-01-22  Tom Tromey  <tom@tromey.com>
12172
12173         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12174         keyword for bcache.
12175
12176 2019-01-22  Tom Tromey  <tom@tromey.com>
12177
12178         * compile/compile-cplus-types.c: Remove a comment by #include.
12179
12180 2019-01-22  Tom Tromey  <tom@tromey.com>
12181
12182         * compile/gcc-c-plugin.h: Include compile-internal.h.
12183
12184 2019-01-22  Tom Tromey  <tom@tromey.com>
12185
12186         * stabsread.c (EXTERN): Do not define.
12187         (symnum, next_symbol_text_func, processing_gcc_compilation)
12188         (within_function, global_sym_chain, global_stabs)
12189         (previous_stab_code, this_object_header_files)
12190         (n_this_object_header_files)
12191         (n_allocated_this_object_header_files): Define.
12192         * stabsread.h (EXTERN): Never define.  Use "extern".
12193
12194 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12195
12196         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12197         history_value.
12198
12199 2019-01-21  Tom Tromey  <tom@tromey.com>
12200
12201         * ui-out.c: Fix includes.
12202         * tui/tui-source.c: Fix includes.
12203         * target.c: Fix includes.
12204         * remote.c: Fix includes.
12205         * regcache.c: Fix includes.
12206         * python/py-block.c: Fix includes.
12207         * printcmd.c: Fix includes.
12208         * or1k-tdep.c: Fix includes.
12209         * mi/mi-main.c: Fix includes.
12210         * m32r-tdep.c: Fix includes.
12211         * csky-tdep.c: Fix includes.
12212         * compile/compile-cplus-types.c: Fix includes.
12213         * cli/cli-interp.c: Fix includes.
12214
12215 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12216
12217         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12218         for padding.
12219
12220 2019-01-16  Tom Tromey  <tom@tromey.com>
12221
12222         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12223         earlier.
12224         (struct objfile) <msymbols_range>: Move from top level.
12225         <msymbols>: New method.
12226         (class objfile_msymbols): Remove.
12227         * symtab.c (default_collect_symbol_completion_matches_break_on):
12228         Update.
12229         * symmisc.c (dump_msymbols): Update.
12230         * stabsread.c (scan_file_globals): Update.
12231         * objc-lang.c (info_selectors_command, info_classes_command)
12232         (find_methods): Update.
12233         * minsyms.c (find_solib_trampoline_target): Update.
12234         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12235         * coffread.c (coff_symfile_read): Update.
12236         * ada-lang.c (ada_lookup_simple_minsym)
12237         (ada_collect_symbol_completion_matches): Update.
12238
12239 2019-01-16  Tom Tromey  <tom@tromey.com>
12240
12241         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12242         type.  Remove no-argument constructor.
12243         <iterator::operator++>: Simplify.
12244         <begin>: Update.
12245         <end>: Use minimal_symbol_count.
12246
12247 2019-01-16  Tom Tromey  <tom@tromey.com>
12248
12249         * objfiles.h (struct objfile) <psymtabs>: New method.
12250         (class objfile_psymtabs): Remove.
12251         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12252         typedef.
12253         <range>: New method.
12254         (require_partial_symbols): Change return type.
12255         * psymtab.c (require_partial_symbols)
12256         (psym_expand_symtabs_matching): Update.
12257         * mdebugread.c (parse_partial_symbols): Update.
12258         * dbxread.c (dbx_end_psymtab): Update.
12259
12260 2019-01-15  Tom Tromey  <tom@tromey.com>
12261
12262         * symtab.c (lookup_objfile_from_block)
12263         (lookup_symbol_in_objfile_symtabs)
12264         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12265         (find_line_symtab, info_sources_command)
12266         (default_collect_symbol_completion_matches_break_on)
12267         (make_source_files_completion_list): Update.
12268         * symmisc.c (print_objfile_statistics, dump_objfile)
12269         (maintenance_print_symbols, maintenance_info_symtabs)
12270         (maintenance_check_symtabs, maintenance_info_line_tables):
12271         Update.
12272         * source.c (select_source_symtab)
12273         (forget_cached_source_info_for_objfile): Update.
12274         * objfiles.h (class objfile_compunits): Remove.
12275         (struct objfile) <compunits_range>: New typedef.
12276         (compunits): New method.
12277         * objfiles.c (objfile_relocate1): Update.
12278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12279         * maint.c (count_symtabs_and_blocks): Update.
12280         * linespec.c (iterate_over_all_matching_symtabs): Update.
12281         * cp-support.c (add_symbol_overload_list_qualified): Update.
12282         * coffread.c (coff_symtab_read): Update.
12283         * ada-lang.c (add_nonlocal_symbols)
12284         (ada_collect_symbol_completion_matches)
12285         (ada_add_global_exceptions): Update.
12286
12287 2019-01-15  Tom Tromey  <tom@tromey.com>
12288
12289         * progspace.h (program_space) <objfiles_safe_range>: New
12290         typedef.
12291         <objfiles_safe>: New method.
12292         * objfiles.h (class all_objfiles_safe): Remove.
12293         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12294         * jit.c (jit_inferior_exit_hook): Update.
12295
12296 2019-01-17  Tom Tromey  <tom@tromey.com>
12297
12298         * progspace.h (program_space) <objfiles_range>: New typedef.
12299         <objfiles>: New method.
12300         <objfiles_head>: Rename from objfiles.
12301         (object_files): Update.
12302         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12303         * guile/scm-pretty-print.c
12304         (ppscm_find_pretty_printer_from_objfiles): Update.
12305         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12306         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12307         Update.
12308         * python/py-progspace.c (pspy_get_objfiles): Update.
12309         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12310         Update.
12311         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12312         (objfpy_lookup_objfile_by_build_id): Update.
12313         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12314         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12315         Update.
12316         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12317         (expand_symtab_containing_pc, lookup_objfile_from_block)
12318         (lookup_static_symbol, basic_lookup_transparent_type)
12319         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12320         (find_line_symtab, info_sources_command)
12321         (default_collect_symbol_completion_matches_break_on)
12322         (make_source_files_completion_list, find_main_name): Update.
12323         * symmisc.c (print_symbol_bcache_statistics)
12324         (print_objfile_statistics, maintenance_print_symbols)
12325         (maintenance_print_msymbols, maintenance_print_objfiles)
12326         (maintenance_info_symtabs, maintenance_check_symtabs)
12327         (maintenance_expand_symtabs, maintenance_info_line_tables):
12328         Update.
12329         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12330         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12331         (map_overlay_command, unmap_overlay_command)
12332         (simple_overlay_update, expand_symtabs_matching)
12333         (map_symbol_filenames): Update.
12334         * symfile-debug.c (set_debug_symfile): Update.
12335         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12336         Update.
12337         * source.c (select_source_symtab, forget_cached_source_info):
12338         Update.
12339         * solib.c (solib_read_symbols): Update.
12340         * solib-spu.c (append_ocl_sos): Update.
12341         * psymtab.c (maintenance_print_psymbols)
12342         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12343         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12344         * printcmd.c (info_symbol_command): Update.
12345         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12346         Update.
12347         * objfiles.h (class all_objfiles): Remove.
12348         * objfiles.c (have_partial_symbols, have_full_symbols)
12349         (have_minimal_symbols, qsort_cmp, update_section_map)
12350         (shared_objfile_contains_address_p)
12351         (default_iterate_over_objfiles_in_search_order): Update.
12352         * objc-lang.c (info_selectors_command, info_classes_command)
12353         (find_methods): Update.
12354         * minsyms.c (find_solib_trampoline_target): Update.
12355         * maint.c (maintenance_info_sections)
12356         (maintenance_translate_address, count_symtabs_and_blocks):
12357         Update.
12358         * main.c (captured_main_1): Update.
12359         * linux-thread-db.c (try_thread_db_load_from_pdir)
12360         (has_libpthread): Update.
12361         * linespec.c (iterate_over_all_matching_symtabs)
12362         (search_minsyms_for_name): Update.
12363         * jit.c (jit_find_objf_with_entry_addr): Update.
12364         * hppa-tdep.c (find_unwind_entry)
12365         (hppa_lookup_stub_minimal_symbol): Update.
12366         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12367         Update.
12368         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12369         (elf_gnu_ifunc_resolve_by_got): Update.
12370         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12371         * dwarf-index-write.c (save_gdb_index_command): Update.
12372         * cp-support.c (add_symbol_overload_list_qualified): Update.
12373         * breakpoint.c (create_overlay_event_breakpoint)
12374         (create_longjmp_master_breakpoint)
12375         (create_std_terminate_master_breakpoint)
12376         (create_exception_master_breakpoint): Update.
12377         * blockframe.c (find_pc_partial_function): Update.
12378         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12379         (ada_collect_symbol_completion_matches)
12380         (ada_add_global_exceptions): Update.
12381
12382 2019-01-17  Tom Tromey  <tom@tromey.com>
12383
12384         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12385         declare VEC.
12386         (solib_target_parse_libraries): Change return type.
12387         (library_list_start_segment, library_list_start_section)
12388         (library_list_end_library, library_list_start_library); Update.
12389         (solib_target_free_library_list): Remove.
12390         (solib_target_parse_libraries): Remove cleanup.  Change return
12391         type.
12392         (solib_target_current_sos): Update.
12393
12394 2019-01-17  Tom Tromey  <tromey@bapiya>
12395
12396         * valprint.c: Replace "the the" with "the".
12397         * symtab.c: Replace "the the" with "the".
12398         * solib.c: Replace "the the" with "the".
12399         * solib-dsbt.c: Replace "the the" with "the".
12400         * linespec.c: Replace "the the" with "the".
12401         * dwarf2loc.h: Replace "the the" with "the".
12402         * amd64-windows-tdep.c: Replace "the the" with "the".
12403         * aarch64-tdep.c: Replace "the the" with "the".
12404
12405 2019-01-16  Keith Seitz  <keiths@redhat.com>
12406
12407         PR gdb/23773
12408         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12409         <builder>: Rename to ..
12410         <m_builder>: ... this and make private.
12411         (dwarf2_cu::get_builder): New method.  Change all users of
12412         `builder' to use this method.
12413         (dwarf2_start_symtab): Move to ...
12414         (dwarf2_cu::start_symtab): ... here.  Update all callers
12415         (setup_type_unit_groups): Move to ...
12416         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12417         callers.
12418         (dwarf2_cu::reset_builder): New method.
12419         (process_full_compunit, process_full_type_unit): Use
12420         dwarf2_cu::reset_builder.
12421         (follow_die_offset): Record the ancestor CU if it is different
12422         from the followed DIE's CU.
12423         (follow_die_sig_1): Likewise.
12424
12425 2019-01-15  Tom Tromey  <tom@tromey.com>
12426
12427         * remote.c (class remote_state) <buf>: Now a char_vector.
12428         <buf_size>: Remove.
12429         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12430         parameter.
12431         (remote_target::getpkt_or_notif_sane_1)
12432         (remote_target::getpkt_sane)
12433         (remote_target::getpkt_or_notif_sane): Likewise.
12434         (class remote_target) <putpkt>: New overload.
12435         (remote_target::read_frame): Change type of "buf_p".  Remove
12436         sizeof_p parameter.
12437         (packet_ok): New overload.
12438         (packet_check_result): New overload.
12439         Update all uses.
12440
12441 2019-01-14  Tom Tromey  <tom@tromey.com>
12442
12443         * remote-notif.c (handle_notification, remote_notif_ack)
12444         (remote_notif_parse): Make "buf" const.
12445         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12446         const.
12447         (remote_notif_parse, remote_notif_ack, handle_notification):
12448         Likewise.
12449         * remote.c (remote_notif_stop_parse): Make "buf" const.
12450         (remote_target::remote_parse_stop_reply): Make "buf" const.
12451         (remote_notif_stop_ack): Make "buf" const.
12452
12453 2019-01-14  Tom Tromey  <tom@tromey.com>
12454
12455         * remote.c (remote_console_output): Make parameter const.
12456
12457 2019-01-14  Tom Tromey  <tom@tromey.com>
12458
12459         * target-debug.h (target_debug_print_signals): Constify.
12460         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12461         * procfs.c (procfs_target::pass_signals): Update.
12462         * linux-nat.c (linux_nat_target::pass_signals): Update.
12463         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12464         * target-delegates.c: Rebuild.
12465         * remote.c (remote_target::program_signals): Update.
12466         (remote_target::pass_signals): Update.
12467         * target.c (target_pass_signals): Constify argument.
12468         (target_program_signals): Likewise.
12469         * target.h (struct target_ops) <pass_signals, program_signals>:
12470         Constify argument.
12471         (target_pass_signals, target_program_signals): Constify argument.
12472
12473 2019-01-14  Tom Tromey  <tom@tromey.com>
12474
12475         PR tui/28819:
12476         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12477
12478 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12479
12480         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12481         field.
12482         * rs6000-tdep.c: Include reggroups.h.
12483         (IS_V_ALIAS_PSEUDOREG): Define.
12484         (rs6000_register_name): Return names for the "vX" aliases.
12485         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12486         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12487         aliases.  Call default_register_reggroup_p for all other
12488         pseudo-registers.
12489         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12490         New functions.
12491         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12492         Handle "vX" aliases.
12493         (v_alias_pseudo_register_collect): New function.
12494         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12495         (rs6000_gdbarch_init): Initialize "vX" aliases as
12496         pseudo-registers.  Restore registration of
12497         rs6000_pseudo_register_reggroup_p with
12498         set_tdesc_pseudo_register_reggroup_p.
12499
12500 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12501
12502         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12503         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12504         set_gdbarch_num_pseudo_regs.
12505
12506 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12507
12508         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12509         Remove arg prefixname, add do_set and do_show.
12510         Add member functions set_list and show_list.
12511         * cli/cli-style.c (class cli_style_option): Update accordingly.
12512         (style_set_list): Move to file scope.
12513         (style_show_list): Likewise.
12514         (set_style): Call help_list.
12515         (show_style): Call cmd_show_list.
12516         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12517         Update to use the new macro.
12518
12519 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12520
12521         * ada-lang.c (_initialize_ada_language): Expand the help text
12522         for the "catch exception" command.
12523
12524 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12525
12526         * symtab.c (matching_obj_sections): Initialize obj,
12527         declare it closer to its usage.
12528
12529 2019-01-10  Tom Tromey  <tom@tromey.com>
12530
12531         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12532         (basic_inf_threads_range): Remove.
12533         (inf_threads_range, inf_non_exited_threads_range)
12534         (safe_inf_threads_range): Use next_adapter.
12535
12536 2019-01-10  Keith Seitz  <keiths@redhat.com>
12537
12538         PR gdb/23712
12539         PR symtab/23010
12540         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12541         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12542
12543 2019-01-10  Keith Seitz  <keiths@redhat.com>
12544
12545         PR gdb/23712
12546         PR symtab/23010
12547         * dictionary.c (pending_to_vector): Remove.
12548         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12549         Remove _1 suffix, replacing functions of the same name.  Update
12550         all callers.
12551         (dict_create_hashed, dict_create_hashed_expandable)
12552         (dict_create_linear, dict_create_linear_expandable, dict_free)
12553         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12554         Make functions static.
12555
12556 2019-01-10  Keith Seitz  <keiths@redhat.com>
12557
12558         PR gdb/23712
12559         PR symtab/23010
12560         * dictionary.h (struct dictionary): Replace declaration with
12561         multidictionary.
12562         (dict_create_hashed, dict_create_hashed_expandable)
12563         (dict_create_linear, dict_create_linear_expandable)
12564         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12565         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12566         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12567         taking multidictionary argument.
12568         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12569         * block.h (struct block) <dict>: Change to multidictionary
12570         and rename `multidict'.
12571         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12572         symmisc.c: Update all dictionary references to multidictionary.
12573
12574 2019-01-10  Keith Seitz  <keiths@redhat.com>
12575
12576         PR gdb/23712
12577         PR symtab/23010
12578         * dictionary.c: Include unordered_map.
12579         (pending_to_vector): New function.
12580         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12581         Rewrite the non-"_1" functions to take vector instead
12582         of linked list.
12583         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12584         "new" _1 versions of the same name.
12585         (multidictionary): Define.
12586         (std::hash<enum language): New definition.
12587         (collate_pending_symbols_by_language, mdict_create_hashed)
12588         (mdict_create_hashed_expandable, mdict_create_linear)
12589         (mdict_create_linear_expandable, mdict_free)
12590         (find_language_dictionary, create_new_language_dictionary)
12591         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12592         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12593         (mdict_size, mdict_empty): New functions.
12594         * dictionary.h (mdict_iterator): Define.
12595
12596 2019-01-10  Pedro Alves  <palves@redhat.com>
12597
12598         * breakpoint.c (read_uploaded_action)
12599         (create_tracepoint_from_upload): Adjust to use
12600         gdb::unique_xmalloc_ptr.
12601         * ctf.c (ctf_write_uploaded_tp):
12602         (SET_ARRAY_FIELD): Use emplace_back.
12603         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12604         * tracefile-tfile.c (tfile_write_uploaded_tp):
12605         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12606         gdb::unique_xmalloc_ptr.
12607         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12608         at_string, cond_string, cmd_strings>: Replace char pointers
12609         with gdb::unique_xmalloc_ptr.
12610
12611 2019-01-10  Pedro Alves  <palves@redhat.com>
12612
12613         * solib-target.c (library_list_start_library): Don't xstrdup name.
12614
12615 2019-01-10  Pedro Alves  <palves@redhat.com>
12616
12617         * mdebugread.c (parse_partial_symbols): Use
12618         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12619
12620 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12621
12622         * linux-fork.c (scoped_switch_fork_info)
12623         <~scoped_switch_fork_info>: Fix incorrect variable name.
12624
12625 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12626
12627         * linux-fork.c (scoped_switch_fork_info)
12628         <scoped_switch_fork_info>: Make explicit.
12629         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12630
12631 2019-01-10  Tom Tromey  <tom@tromey.com>
12632
12633         * objfiles.h (objfile::reset_psymtabs): Update.
12634         * objfiles.c (objfile::objfile): Update.
12635         * psymtab.h (psymtab_storage::obstack): Update.
12636         (psymtab_storage::m_obstack): Use gdb::optional.
12637         (class psymtab_storage): Update comment.  Remove objfile
12638         parameter.
12639         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12640
12641 2019-01-10  Tom Tromey  <tom@tromey.com>
12642
12643         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12644         <free_psymtabs>: Now private.
12645         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12646         (allocate_psymtab): Use new method.
12647
12648 2019-01-10  Tom Tromey  <tom@tromey.com>
12649
12650         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12651         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12652         * mdebugread.c (parse_partial_symbols): Use
12653         allocate_dependencies.
12654         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12655         allocate_dependencies.
12656         (process_psymtab_comp_unit_reader)
12657         (build_type_psymtab_dependencies): Likewise.
12658         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12659
12660 2019-01-10  Tom Tromey  <tom@tromey.com>
12661
12662         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12663         PSYMBOL_SET_LANGUAGE.
12664         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12665
12666 2019-01-10  Tom Tromey  <tom@tromey.com>
12667
12668         * psymtab.h (psymtab_storage::obstack): New method.
12669         <m_obstack>: Rename from obstack; now private.
12670         * psymtab.c (psymtab_storage): Update.
12671         * dwarf2read.c (create_addrmap_from_index)
12672         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12673         Update.
12674
12675 2019-01-10  Tom Tromey  <tom@tromey.com>
12676
12677         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12678         * objfiles.h (objfile::reset_psymtabs): New method.
12679
12680 2019-01-10  Tom Tromey  <tom@tromey.com>
12681
12682         * symmisc.c (print_symbol_bcache_statistics): Update.
12683         (print_objfile_statistics): Update.
12684         * symfile.c (reread_symbols): Update.
12685         * psymtab.h (class psymtab_storage): New.
12686         * psymtab.c (psymtab_storage): New constructor.
12687         (~psymtab_storage): New destructor.
12688         (require_partial_symbols): Update.
12689         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12690         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12691         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12692         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12693         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12694         (start_psymtab_common, end_psymtab_common)
12695         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12696         (allocate_psymtab): Update.
12697         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12698         Update.
12699         (dump_psymtab_addrmap, maintenance_print_psymbols)
12700         (maintenance_check_psymtabs): Update.
12701         (class objfile_psymtabs): Move to objfiles.h.
12702         * psympriv.h (discard_psymtab): Now inline.
12703         (psymtab_discarder::psymtab_discarder): Update.
12704         (psymtab_discarder::~psymtab_discarder): Update.
12705         (ALL_OBJFILE_PSYMTABS): Rewrite.
12706         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12707         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12708         Remove fields.
12709         <partial_symtabs>: New field.
12710         (class objfile_psymtabs): Move from psymtab.h.  Update.
12711         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12712         psymbol_cache.
12713         (objfile::~objfile): Don't destroy psymbol_cache.
12714         * mdebugread.c (parse_partial_symbols): Update.
12715         * dwarf2read.c (create_addrmap_from_index)
12716         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12717         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12718         (add_partial_subprogram, dwarf2_ranges_read): Update.
12719         * dwarf-index-write.c (write_address_map)
12720         (write_one_signatured_type, recursively_write_psymbols)
12721         (class debug_names, class debug_names, write_psymtabs_to_index):
12722         Update.
12723
12724 2019-01-10  Tom Tromey  <tom@tromey.com>
12725
12726         * symtab.h (SYMBOL_SET_NAMES): Update.
12727         (symbol_set_names): Update.
12728         (MSYMBOL_SET_NAMES): Update.
12729         * symtab.c (symbol_set_names): Change argument to be an
12730         objfile_per_bfd_storage.
12731         * psymtab.c (add_psymbol_to_bcache): Update.
12732         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12733
12734 2019-01-10  Tom Tromey  <tom@tromey.com>
12735
12736         * symtab.c (create_demangled_names_hash): Change argument to be an
12737         objfile_per_bfd_storage.
12738         (symbol_set_names): Update.
12739
12740 2019-01-10  Tom Tromey  <tom@tromey.com>
12741
12742         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12743         init_psymbol_list.
12744         * psymtab.c (init_psymbol_list): Do nothing if already called.
12745         * psympriv.h (init_psymbol_list): Add comment.
12746         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12747         init_psymbol_list.
12748         * dbxread.c (dbx_symfile_read): Unconditionally call
12749         init_psymbol_list.
12750
12751 2019-01-10  Tom Tromey  <tom@tromey.com>
12752
12753         * xcoffread.c (scan_xcoff_symtab): Update.
12754         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12755         "where".
12756         * mdebugread.c (parse_partial_symbols)
12757         (handle_psymbol_enumerators): Update.
12758         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12759         * dbxread.c (read_dbx_symtab): Update.
12760         * psympriv.h (psymbol_placement): New enum.
12761         (add_psymbol_to_list): Update.
12762
12763 2019-01-10  Tom Tromey  <tom@tromey.com>
12764
12765         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12766         static_psymbols parameters.
12767         (scan_xcoff_symtab): Update.
12768         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12769         static_psymbols parameters.
12770         * psympriv.h (start_psymtab_common): Update.
12771         * mdebugread.c (parse_partial_symbols): Update.
12772         * dwarf2read.c (create_partial_symtab): Update.
12773         * dbxread.c (read_dbx_symtab): Update.
12774         (start_psymtab): Remove global_psymbols and static_psymbols
12775         parameters.
12776
12777 2019-01-10  Tom Tromey  <tom@tromey.com>
12778
12779         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12780         * psymtab.c (allocate_psymtab): Add comment.
12781         * psympriv.h (allocate_psymtab): Add comment.
12782         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12783         initializations.
12784         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12785
12786 2019-01-10  Tom Tromey  <tom@tromey.com>
12787
12788         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12789         Don't declare.
12790         * mipsread.c: Include mdebugread.h.
12791         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12792         Declare.
12793         * elfread.c: Include mdebugread.h.
12794
12795 2019-01-09  Tom Tromey  <tom@tromey.com>
12796
12797         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12798         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12799         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12800         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12801         (psym_lookup_symbol, psym_find_last_source_symtab)
12802         (psym_forget_cached_source_info, psym_print_stats)
12803         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12804         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12805         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12806         (psym_find_compunit_symtab_by_address)
12807         (maintenance_print_psymbols, maintenance_info_psymtabs)
12808         (maintenance_check_psymtabs): Use ranged for.
12809         * psymtab.h (class objfile_psymtabs): New.
12810         (require_partial_symbols): Return objfile_psymtabs.
12811         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12812
12813 2019-01-09  Tom Tromey  <tom@tromey.com>
12814
12815         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12816         (find_pc_mapped_section, list_overlays_command)
12817         (map_overlay_command, unmap_overlay_command)
12818         (simple_overlay_update): Use all_objfiles.
12819         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12820         * printcmd.c (info_symbol_command): Use all_objfiles.
12821         * objfiles.h (ALL_OBJSECTIONS): Remove.
12822         * maint.c (maintenance_translate_address): Use all_objfiles.
12823         * gcore.c (gcore_create_callback): Use all_objfiles.
12824         (objfile_find_memory_regions): Likewise.
12825
12826 2019-01-09  Tom Tromey  <tom@tromey.com>
12827
12828         * symtab.c (find_line_symtab, info_sources_command)
12829         (make_source_files_completion_list): Use objfile_compunits.
12830         * source.c (select_source_symtab): Use objfile_compunits.
12831         * objfiles.h (struct objfile): Update comment.
12832         (ALL_OBJFILES): Remove.
12833         (ALL_FILETABS): Remove.
12834         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12835         objfile_compunits.
12836
12837 2019-01-09  Tom Tromey  <tom@tromey.com>
12838
12839         * symmisc.c (print_objfile_statistics, dump_objfile)
12840         (maintenance_print_symbols): Use compunit_filetabs.
12841         * source.c (forget_cached_source_info_for_objfile): Use
12842         compunit_filetabs.
12843         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12844         (ALL_FILETABS): Use compunit_filetabs.
12845         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12846         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12847
12848 2019-01-09  Tom Tromey  <tom@tromey.com>
12849
12850         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12851         (compunit_filetabs): New.
12852         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12853         compunit_filetabs.
12854         (info_sources_command, make_source_files_completion_list): Remove
12855         declaration.
12856         * symmisc.c (print_objfile_statistics, dump_objfile)
12857         (maintenance_print_symbols): Remove declaration.
12858         (maintenance_info_symtabs): Use compunit_filetabs.
12859         (maintenance_info_line_tables): Likewise.
12860         * source.c (select_source_symtab): Change local variable name.
12861         (forget_cached_source_info_for_objfile): Remove declaration.
12862         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12863         * objfiles.c (objfile_relocate1): Remove declaration.
12864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12865         declaration.
12866         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12867         * coffread.c (coff_symtab_read): Remove declaration.
12868         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12869         compunit_filetabs.
12870
12871 2019-01-09  Tom Tromey  <tom@tromey.com>
12872
12873         * symtab.c (lookup_objfile_from_block)
12874         (find_pc_sect_compunit_symtab, search_symbols)
12875         (default_collect_symbol_completion_matches_break_on): Use
12876         objfile_compunits.
12877         * objfiles.h (ALL_COMPUNITS): Remove.
12878         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12879         * cp-support.c (add_symbol_overload_list_qualified): Use
12880         objfile_compunits.
12881         * ada-lang.c (ada_collect_symbol_completion_matches)
12882         (ada_add_global_exceptions): Use objfile_compunits.
12883
12884 2019-01-09  Tom Tromey  <tom@tromey.com>
12885
12886         * source.c (select_source_symtab)
12887         (forget_cached_source_info_for_objfile): Remove declaration.
12888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12889         declaration.
12890         * maint.c (count_symtabs_and_blocks): Remove declaration.
12891         * cp-support.c (add_symbol_overload_list_qualified): Remove
12892         declaration.
12893         * coffread.c (coff_symtab_read): Remove declaration.
12894         * symtab.c (lookup_symbol_in_objfile_symtabs)
12895         (basic_lookup_transparent_type_1): Use objfile_compunits.
12896         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12897         (info_sources_command, search_symbols)
12898         (default_collect_symbol_completion_matches_break_on)
12899         (make_source_files_completion_list): Remove declaration.
12900         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12901         (ada_collect_symbol_completion_matches)
12902         (ada_add_global_exceptions): Remove declaration.
12903         * linespec.c (iterate_over_all_matching_symtabs): Use
12904         objfile_compunits.
12905         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12906         (class objfile_compunits): New.
12907         (ALL_COMPUNITS): Use objfile_compunits.
12908         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12909         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12910         objfile_compunits.
12911         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12912
12913 2019-01-09  Tom Tromey  <tom@tromey.com>
12914
12915         * symtab.c (search_symbols)
12916         (default_collect_symbol_completion_matches_break_on): Use
12917         objfile_msymbols.
12918         * ada-lang.c (ada_lookup_simple_minsym)
12919         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12920         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12921         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12922         objfile_msymbols.
12923         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12924         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12925         * objc-lang.c (find_methods): Use objfile_msymbols.
12926         (info_selectors_command, info_classes_command): Likewise.
12927         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12928         * objfiles.h (class objfile_msymbols): New.
12929         (ALL_OBJFILE_MSYMBOLS): Remove.
12930         (ALL_MSYMBOLS): Remove.
12931
12932 2019-01-09  Tom Tromey  <tom@tromey.com>
12933
12934         * common/next-iterator.h (next_adapter): Add Iterator template
12935         parameter.
12936         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12937         (class all_objfiles_safe): New.
12938         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12939         * objfiles.c (put_objfile_before): Update comment.
12940         (add_separate_debug_objfile): Likewise.
12941         (free_all_objfiles): Use all_objfiles_safe.
12942         (objfile_purge_solibs): Likewise.
12943
12944 2019-01-09  Tom Tromey  <tom@tromey.com>
12945
12946         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12947         (expand_symtab_containing_pc, lookup_static_symbol)
12948         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12949         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12950         all_objfiles.
12951         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12952         * breakpoint.c (create_overlay_event_breakpoint)
12953         (create_longjmp_master_breakpoint)
12954         (create_std_terminate_master_breakpoint)
12955         (create_exception_master_breakpoint): Use all_objfiles.
12956         * linux-thread-db.c (try_thread_db_load_from_pdir)
12957         (has_libpthread): Use all_objfiles.
12958         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12959         * linespec.c (iterate_over_all_matching_symtabs)
12960         (search_minsyms_for_name): Use all_objfiles.
12961         * maint.c (maintenance_info_sections): Use all_objfiles.
12962         * main.c (captured_main_1): Use all_objfiles.
12963         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12964         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12965         * guile/scm-pretty-print.c
12966         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12967         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12968         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12969         (maintenance_print_msymbols): Use all_objfiles.
12970         * source.c (select_source_symtab): Use all_objfiles.
12971         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12972         * symfile.c (remove_symbol_file_command)
12973         (expand_symtabs_matching, map_symbol_filenames): Use
12974         all_objfiles.
12975         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12976         all_objfiles.
12977         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12978         * objc-lang.c (find_methods): Use all_objfiles.
12979         * objfiles.c (have_partial_symbols, have_full_symbols)
12980         (have_minimal_symbols, qsort_cmp)
12981         (default_iterate_over_objfiles_in_search_order): Use
12982         all_objfiles.
12983         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12984         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12985         (maintenance_check_psymtabs): Use all_objfiles.
12986         (ALL_PSYMTABS): Remove.
12987         * compile/compile-object-run.c (do_module_cleanup): Use
12988         all_objfiles.
12989         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12990         * cp-support.c (add_symbol_overload_list_qualified): Use
12991         all_objfiles.
12992         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12993         Use all_objfiles.
12994         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12995         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12996         all_objfiles.
12997         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12998         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12999         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13000         Uses all_objfiles.
13001         * solib.c (solib_read_symbols): Use all_objfiles
13002
13003 2019-01-09  Tom Tromey  <tom@tromey.com>
13004
13005         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13006         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13007         all_objfiles.
13008         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13009         * symmisc.c (print_symbol_bcache_statistics)
13010         (print_objfile_statistics, maintenance_print_objfiles)
13011         (maintenance_info_symtabs, maintenance_check_symtabs)
13012         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13013         all_objfiles.
13014         * source.c (forget_cached_source_info): Use all_objfiles.
13015         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13016         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13017         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13018         * objfiles.c (update_section_map): Use all_objfiles.
13019         (shared_objfile_contains_address_p): Likewise.
13020         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13021         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13022
13023 2019-01-09  Tom Tromey  <tom@tromey.com>
13024
13025         * common/next-iterator.h: New file.
13026         * objfiles.h (class all_objfiles): New.
13027         (struct objfile_iterator): New.
13028
13029 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13030
13031         * NEWS: Move the description of the changed "frame", "select-frame",
13032          and "info frame" commands to the Changed commands section.
13033
13034 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13035
13036         * gdbtypes.c (check_stub_method_group): Remove handling of old
13037         mangling schemes.
13038         * linespec.c (find_methods): Likewise.
13039         * stabsread.c (read_member_functions): Likewise.
13040         * valops.c (search_struct_method): Likewise.
13041         (value_struct_elt_for_reference): Likewise.
13042         * NEWS: Mention this change.
13043
13044 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13045
13046         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13047         print_source_lines.
13048         * source.c (print_source_lines_base): Update line number check.
13049         (print_source_lines): New function.
13050         (source_lines_range::source_lines_range): New function.
13051         * source.h (class source_lines_range): New class.
13052         (print_source_lines): New declaration.
13053
13054 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13055
13056         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13057
13058 2019-01-08  Tom Tromey  <tom@tromey.com>
13059             Simon Marchi  <simon.marchi@ericsson.com>
13060
13061         PR gdb/24060
13062         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13063         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13064         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13065         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13066         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13067         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13068
13069 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13070
13071         * source.c (select_source_symtab): Move header comment to
13072         declaration in source.h.
13073         (forget_cached_source_info_for_objfile): Likewise.
13074         (forget_cached_source_info): Likewise.
13075         (identify_source_line): Likewise.
13076         * source.h (identify_source_line): Move declaration from symtab.h
13077         and add comment from source.c
13078         (print_source_lines): Likewise.
13079         (forget_cached_source_info_for_objfile): Likewise.
13080         (forget_cached_source_info): Likewise.
13081         (select_source_symtab): Likewise.
13082         (enum print_source_lines_flag): Move definition from symtab.h.
13083         * symtab.h (identify_source_line): Move declaration to source.h.
13084         (print_source_lines): Likewise.
13085         (forget_cached_source_info_for_objfile): Likewise.
13086         (forget_cached_source_info): Likewise.
13087         (select_source_symtab): Likewise.
13088         (enum print_source_lines_flag): Move definition to source.h.
13089         * tui/tui-hooks.c: Add 'source.h' include.
13090
13091 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13092
13093         * source.c (print_source_lines_base): Handle requests to print
13094         reverse line number sequences, and guard against empty lines
13095         string.
13096
13097 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13098
13099         * source.c (print_source_lines_base): Fix skip of '\r' if next
13100         character is '\n'.
13101
13102 2019-01-06  Tom Tromey  <tom@tromey.com>
13103
13104         * c-exp.y (struct c_parse_state) <macro_original_text,
13105         expansion_obstack>: New member.
13106         (macro_original_text, expansion_obstack): Remove globals.
13107         (scan_macro_expansion, scanning_macro_expansion)
13108         (finished_macro_expansion): Update.
13109         (scan_macro_cleanup): Remove.
13110         (yylex, c_parse): Update.
13111
13112 2019-01-06  Tom Tromey  <tom@tromey.com>
13113
13114         * c-exp.y (struct c_parse_state) <strings>: New member.
13115         (operator_stoken): Update.
13116
13117 2019-01-06  Tom Tromey  <tom@tromey.com>
13118
13119         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13120         (union type_stack_elt) <typelist_val>: Now a pointer to
13121         std::vector.
13122         (type_stack_cleanup): Don't declare.
13123         (push_typelist): Update.
13124         * parse.c (pop_typelist): Return a std::vector.
13125         (push_typelist): Take a std::vector.
13126         (follow_types): Update.  Do not free args.
13127         (type_stack_cleanup): Remove.
13128         * c-exp.y (struct c_parse_state): New.
13129         (cpstate): New global.
13130         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13131         (nonempty_typelist): Update.
13132         (func_mod): Create a new vector.
13133         (c_parse): Create a c_parse_state.
13134         (check_parameter_typelist): Do not delete params.
13135         (function_method): Update.  Do not delete type_list.
13136
13137 2019-01-06  Tom Tromey  <tom@tromey.com>
13138
13139         PR gdb/28155:
13140         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13141         check_typedef.
13142         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13143         (print_return_value): Likewise.
13144
13145 2019-01-05  Tom Tromey  <tom@tromey.com>
13146
13147         * contrib/cleanup_check.py: Remove.
13148         * contrib/gcc-with-excheck: Remove.
13149         * contrib/exsummary.py: Remove.
13150         * contrib/excheck.py: Remove.
13151
13152 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13153
13154         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13155         NULL. Initialize tpprev to NULL instead of assigning it
13156         to NULL on the next statement.
13157         * windows-nat.c (windows_delete_thread): Remove check for
13158         main_thread_id before printing thread exit notifications.
13159         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13160         Remove thread ID check against main_thread_id.
13161         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13162         windows_delete_thread.
13163         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13164
13165 2019-01-04  Tom Tromey  <tom@tromey.com>
13166
13167         * compile/compile.c (_initialize_compile): Use upper case for
13168         metasyntactic variables.
13169         * symmisc.c (_initialize_symmisc): Use upper case for
13170         metasyntactic variables.
13171         * psymtab.c (_initialize_psymtab): Use upper case for
13172         metasyntactic variables.
13173         * demangle.c (demangle_command): Use upper case for metasyntactic
13174         variables.
13175         (_initialize_demangler): Likewise.
13176         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13177         variables.
13178
13179 2019-01-03  Tom Tromey  <tom@tromey.com>
13180
13181         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13182
13183 2019-01-03  Tom Tromey  <tom@tromey.com>
13184
13185         * python/py-symtab.c (salpy_str): Update.
13186         (struct salpy_sal_object) <symtab>: Now a PyObject.
13187         (salpy_dealloc): Update.
13188         (del_objfile_sal): Use gdbpy_ref.
13189
13190 2019-01-03  Tom Tromey  <tom@tromey.com>
13191
13192         * python/py-type.c (convert_field): Use new_reference.  Return
13193         gdbpy_ref.
13194         (make_fielditem): Return gdbpy_ref.
13195         (typy_fields): Update.
13196         (typy_getitem): Update.
13197         (field_name): Return gdbpy_ref.  Use new_reference.
13198         (typy_iterator_iternext): Update.
13199
13200 2019-01-03  Tom Tromey  <tom@tromey.com>
13201
13202         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13203
13204 2019-01-03  Tom Tromey  <tom@tromey.com>
13205
13206         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13207         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13208         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13209         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13210         (pspy_set_type_printers): Likewise.
13211         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13212         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13213         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13214         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13215         (objfpy_set_type_printers): Likewise.
13216
13217 2019-01-03  Tom Tromey  <tom@tromey.com>
13218
13219         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13220         (gdbpy_print_stack): Use gdbpy_err_fetch.
13221         * python/python-internal.h (class gdbpy_err_fetch): New class.
13222         (class gdbpy_enter) <m_error_type, m_error_value,
13223         m_error_traceback>: Remove.
13224         <m_error>: New member.
13225         (gdbpy_exception_to_string): Don't declare.
13226         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13227         * python/py-value.c (convert_value_from_python): Use
13228         gdbpy_err_fetch.
13229         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13230         gdbpy_exception_to_string.
13231         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13232         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13233         gdbpy_err_fetch.
13234
13235 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13236
13237         * linux-nat.c (delete_lwp_cleanup): Delete.
13238         (struct lwp_deleter): New struct.
13239         (lwp_info_up): New typedef.
13240         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13241         lwp_info_up.
13242
13243 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13244
13245         * linux-fork.c (class scoped_switch_fork_info): New class.
13246         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13247
13248 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13249
13250         * valops.c (find_overload_match): Remove use of null_cleanup, and
13251         calls to do_cleanups.
13252
13253 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13254
13255         * compile/compile-cplus-types.c
13256         (compile_cplus_instance::decl_name): Handle changes to
13257         cp_func_name.
13258         * cp-support.c (cp_func_name): Update header comment, update
13259         return type.
13260         * cp-support.h (cp_func_name): Update return type in declaration.
13261         * valops.c (find_overload_match): Move temp_func local to top
13262         level of function and change its type.  Use temp_func to hold and
13263         delete temporary string obtained from cp_func_name.
13264
13265 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13266
13267         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13268         gdb::char_vector, remove cleanup, and update uses of `msg`.
13269
13270 2019-01-03  Jim Wilson  <jimw@sifive.com>
13271
13272         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13273
13274 2019-01-02  Tom Tromey  <tom@tromey.com>
13275
13276         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13277         (tdesc_parse_xml): Remove cleanups.
13278         * target-descriptions.h (make_cleanup_free_target_description):
13279         Don't declare.
13280         (target_desc_deleter): New struct.
13281         (target_desc_up): New typedef.
13282         * target-descriptions.c (target_desc_deleter::operator()): Rename
13283         from free_target_description.
13284         (make_cleanup_free_target_description): Remove.
13285
13286 2019-01-02  Tom Tromey  <tom@tromey.com>
13287
13288         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13289         constructor, destructor.
13290         (linespec_parser): Remove typedef.
13291         (~linespec_parser): Rename from linespec_parser_delete.
13292         (linespec_lex_to_end, linespec_complete_label)
13293         (linespec_complete): Update.
13294         (decode_line_full): Remove cleanups.
13295         (decode_line_1): Update.
13296
13297 2019-01-02  Tom Tromey  <tom@tromey.com>
13298
13299         * python/python-internal.h (inferior_to_inferior_object): Change
13300         return type.
13301         * python/py-exitedevent.c (create_exited_event_object): Update.
13302         * python/py-inferior.c (inferior_to_inferior_object): Return
13303         gdbpy_ref.
13304         (python_new_inferior, python_inferior_deleted)
13305         (thread_to_thread_object, delete_thread_object)
13306         (build_inferior_list, gdbpy_selected_inferior): Update.
13307         * python/py-infthread.c (create_thread_object): Update.  Also fail
13308         if inferior_to_inferior_object fails.
13309
13310 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13311
13312         * inferior.h (class inferior) <displaced_step_state>: New field.
13313         * infrun.h (struct displaced_step_state): Move here from
13314         infrun.c.  Initialize fields, add constructor.
13315         <inf>: Remove field.
13316         <reset>: New method.
13317         * infrun.c (struct displaced_step_inferior_state): Move to
13318         infrun.h.
13319         (displaced_step_inferior_states): Remove.
13320         (get_displaced_stepping_state): Adust.
13321         (displaced_step_in_progress_any_inferior): Adjust.
13322         (displaced_step_in_progress_thread): Adjust.
13323         (displaced_step_in_progress): Adjust.
13324         (add_displaced_stepping_state): Remove.
13325         (get_displaced_step_closure_by_addr): Adjust.
13326         (remove_displaced_stepping_state): Remove.
13327         (infrun_inferior_exit): Call displaced_step_state.reset.
13328         (use_displaced_stepping): Don't check for NULL.
13329         (displaced_step_prepare_throw): Call
13330         get_displaced_stepping_state.
13331         (displaced_step_fixup): Don't check for NULL.
13332         (prepare_for_detach): Don't check for NULL.
13333
13334 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13335
13336         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13337          in case of call that did not complete.
13338
13339 2019-01-02  Andrey Utkin  <autkin@undo.io>
13340
13341         * symfile.c (find_separate_debug_file): Fix search of debug files for
13342         remote debuggee.
13343
13344 2019-01-02  Tom Tromey  <tom@tromey.com>
13345
13346         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13347         indentation.
13348         * python/py-frame.c (frapy_older): Remove cast.
13349         (frapy_newer): Likewise.
13350         * python/py-breakpoint.c (local_setattro): Remove cast.
13351         * python/py-arch.c (archpy_name): Remove local variable.
13352         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13353
13354 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13355
13356         * unittests/basic_string_view/element_access/char/empty.cc:
13357         Fix year range in copyright header.
13358
13359 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13360
13361         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13362         Delete.
13363         <operator==>: Update with for removed field.
13364         <hash>: Likewise.
13365         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13366         <isa_features>: ...this.
13367         <abi_features>: New field.
13368         (riscv_isa_flen): Update comment.
13369         (riscv_abi_xlen): New declaration.
13370         (riscv_abi_flen): New declaration.
13371         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13372         isa_features.
13373         (riscv_abi_xlen): New function.
13374         (riscv_isa_flen): Update to get answer from isa_features.
13375         (riscv_abi_flen): New function.
13376         (riscv_has_fp_abi): Update to get answer from abi_features.
13377         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13378         xlen and flen.
13379         (riscv_call_info) <xlen, flen>: Update comment.
13380         (riscv_call_arg_struct): Remove invalid assertions
13381         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13382         is removed.
13383         (riscv_gdbarch_init): Gather isa features and abi features
13384         separately, ensure both match on the gdbarch when reusing an old
13385         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13386         a target with 64-bit float hardware.
13387
13388 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13389
13390         * source.c (search_command_helper): Stop reverse search
13391         when line 1 has been searched.
13392
13393 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13394
13395         * record-full.c (record_full_base_target::close): Rewrite
13396         record_full_core_buf_list free logic.
13397
13398 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13399
13400         * break-catch-syscall.c (print_one_catch_syscall): xfree
13401         the last text.
13402
13403 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13404
13405         * top.c (print_gdb_version): Update Copyright year in version
13406         message.
13407
13408 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13409
13410         Update copyright year range in all GDB files.
13411
13412 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13413
13414         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13415
13416 For older changes see ChangeLog-2018.
13417 \f
13418 Local Variables:
13419 mode: change-log
13420 left-margin: 8
13421 fill-column: 74
13422 version-control: never
13423 coding: utf-8
13424 End:
13425