gdb/ChangeLog

   1 2020-03-13  Tom Tromey  <tom@tromey.com>
   2
   3         * valprint.c (do_val_print): Call la_value_print_inner, if
   4         available.
   5         * rust-lang.c (rust_language_defn): Update.
   6         * p-lang.c (pascal_language_defn): Update.
   7         * opencl-lang.c (opencl_language_defn): Update.
   8         * objc-lang.c (objc_language_defn): Update.
   9         * m2-lang.c (m2_language_defn): Update.
  10         * language.h (struct language_defn) <la_value_print_inner>: New
  11         member.
  12         * language.c (unknown_language_defn, auto_language_defn): Update.
  13         * go-lang.c (go_language_defn): Update.
  14         * f-lang.c (f_language_defn): Update.
  15         * d-lang.c (d_language_defn): Update.
  16         * c-lang.c (c_language_defn, cplus_language_defn)
  17         (asm_language_defn, minimal_language_defn): Update.
  18         * ada-lang.c (ada_language_defn): Update.
  19
  20 2020-03-13  Tom Tromey  <tom@tromey.com>
  21
  22         * c-valprint.c (c_value_print): Use common_val_print.
  23
  24 2020-03-13  Tom Tromey  <tom@tromey.com>
  25
  26         * cp-valprint.c (cp_print_static_field): Use common_val_print.
  27
  28 2020-03-13  Tom Tromey  <tom@tromey.com>
  29
  30         * f-valprint.c (f77_print_array_1, f_val_print): Use
  31         common_val_print.
  32
  33 2020-03-13  Tom Tromey  <tom@tromey.com>
  34
  35         * riscv-tdep.c (riscv_print_one_register_info): Use
  36         common_val_print.
  37
  38 2020-03-13  Tom Tromey  <tom@tromey.com>
  39
  40         * mi/mi-main.c (output_register): Use common_val_print.
  41
  42 2020-03-13  Tom Tromey  <tom@tromey.com>
  43
  44         * infcmd.c (default_print_one_register_info): Use
  45         common_val_print.
  46
  47 2020-03-13  Tom Tromey  <tom@tromey.com>
  48
  49         * valprint.h (common_val_print_checked): Declare.
  50         * valprint.c (common_val_print_checked): New function.
  51         * stack.c (print_frame_arg): Use common_val_print_checked.
  52
  53 2020-03-13  Tom Tromey  <tom@tromey.com>
  54
  55         * valprint.c (do_val_print): New function, from val_print.
  56         (val_print): Use do_val_print.
  57         (common_val_print): Use do_val_print.
  58
  59 2020-03-13  Tom Tromey  <tom@tromey.com>
  60
  61         * valprint.c (value_print): Use scoped_value_mark.
  62
  63 2020-03-13  Tom de Vries  <tdevries@suse.de>
  64
  65         PR symtab/25646
  66         * psymtab.c (partial_symtab::partial_symtab): Don't set
  67         globals_offset and statics_offset.  Push element onto
  68         current_global_psymbols and current_static_psymbols stacks.
  69         (concat): New function.
  70         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
  71         element from current_global_psymbols and current_static_psymbols
  72         stacks.  Concat popped elements to global_psymbols and
  73         static_symbols.
  74         (add_psymbol_to_list): Use current_global_psymbols and
  75         current_static_psymbols stacks.
  76         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
  77         current_static_psymbols fields.
  78
  79 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * corelow.c (sniff_core_bfd): Remove.
  82         (class core_target) <m_core_vec>: Remove.
  83         (core_target::core_target): Update.
  84         (core_file_fns): Remove.
  85         (deprecated_add_core_fns): Remove.
  86         (default_core_sniffer): Remove.
  87         (sniff_core_bfd): Remove.
  88         (default_check_format): Remove.
  89         (gdb_check_format): Remove.
  90         (core_target_open): Update.
  91         (core_target::get_core_register_section): Update.
  92         (get_core_registers_cb): Update.
  93         (core_target::fetch_registers): Update.
  94         * gdbcore.h (struct core_fns): Remove.
  95         (deprecated_add_core_fns): Remove.
  96         (default_core_sniffer): Remove.
  97         (default_check_format): Remove.
  98
  99 2020-03-12  Tom Tromey  <tom@tromey.com>
 100
 101         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
 102         CORE_ADDR.
 103         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
 104
 105 2020-03-12  Tom Tromey  <tom@tromey.com>
 106
 107         * remote.c (remote_target::download_tracepoint)
 108         (remote_target::enable_tracepoint)
 109         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
 110         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
 111         sprintf_vma.
 112
 113 2020-03-12  Tom Tromey  <tom@tromey.com>
 114
 115         * symfile-mem.c: Update CORE_ADDR size assert.
 116
 117 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 118
 119         * selftest.m4: Move to gdbsupport/.
 120         * acinclude.m4: Update path to selftest.m4.
 121
 122 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 123
 124         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
 125         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
 126         gdbarch-selfselftests.c and selftest-arch.c.
 127         (SUBDIR_UNITTESTS_OBS): Rename to...
 128         (SELFTESTS_OBS): ... this.
 129         (COMMON_SFILES): Remove disasm-selftests.c and
 130         gdbarch-selftests.c.
 131         * configure.ac: Don't add selftest-arch.{c,o} to
 132         CONFIG_{SRCS,OBS}.
 133         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
 134         preprocessor conditions.
 135
 136 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 137
 138         * configure.ac: Don't source bfd/development.sh.
 139         * selftest.m4: Modify comment.
 140         * configure: Re-generate.
 141
 142 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 143
 144         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
 145         not "true" or "false".
 146         * configure: Re-generate.
 147
 148 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
 151         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
 152         renamed to arm_nbsd_supply_gregset.
 153         (fetch_register): Update to call arm_nbsd_supply_gregset.
 154         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
 155         (arm_netbsd_nat_target::fetch_registers): Update.
 156         (fetch_elfcore_registers): Removed.
 157         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
 158         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
 159         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
 160         not require NetBSD system headers.
 161         (arm_nbsd_regset): New struct.
 162         (arm_nbsd_iterate_over_regset_sections): New function.
 163         (arm_netbsd_init_abi_common): Updated to call
 164         set_gdbarch_iterate_over_regset_sections.
 165         * arm-nbsd-tdep.h: New file.
 166
 167 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
 168
 169         * symtab.c (find_pc_sect_line): Add check which prevents infinite
 170         recursion.
 171
 172 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
 173
 174         * configure: Re-generate.
 175
 176 2020-03-11  Tom Tromey  <tromey@adacore.com>
 177
 178         * ada-typeprint.c (print_choices): Fix comment.
 179
 180 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 181
 182         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
 183         previous item in the list, when the list has no items.
 184
 185 2020-03-11  Tom de Vries  <tdevries@suse.de>
 186
 187         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
 188         PROP_LOCLIST handling code.
 189
 190 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * buildsym-legacy.c (record_line): Pass extra parameter to
 193         record_line.
 194         * buildsym.c (buildsym_compunit::record_line): Take an extra
 195         parameter, reduce duplication in the line table, and record the
 196         is_stmt flag in the line table.
 197         * buildsym.h (buildsym_compunit::record_line): Add extra
 198         parameter.
 199         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
 200         non-statement lines.
 201         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
 202         this to the symtab builder.
 203         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
 204         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
 205         through to dwarf_record_line_1.
 206         * infrun.c (process_event_stop_test): When stepping, don't stop at
 207         a non-statement instruction, and only refresh the step info when
 208         we land in the middle of a line's range.  Also add an extra
 209         comment.
 210         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
 211         field.
 212         * record-btrace.c (btrace_find_line_range): Only record lines
 213         marked as is-statement.
 214         * stack.c (frame_show_address): Show the frame address if we are
 215         in a non-statement sal.
 216         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
 217         (maintenance_print_one_line_table): Print a header for the is_stmt
 218         column, and include is_stmt information in the output.
 219         * symtab.c (find_pc_sect_line): Find lines marked as statements in
 220         preference to non-statements.
 221         (find_pcs_for_symtab_line): Prefer is-statement entries.
 222         (find_line_common): Likewise.
 223         * symtab.h (struct linetable_entry): Add is_stmt field.
 224         (struct symtab_and_line): Likewise.
 225         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
 226         arranging the line table.
 227
 228 2020-03-07  Tom de Vries  <tdevries@suse.de>
 229
 230         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
 231         DIE.
 232
 233 2020-03-07  Tom Tromey  <tom@tromey.com>
 234
 235         * valops.c (value_literal_complex): Remove obsolete comment.
 236         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
 237         comment.
 238
 239 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         * infrun.h: Forward-declare thread_info.
 242         (set_step_info): Add thread_info parameter, add doc.
 243         * infrun.c (set_step_info): Add thread_info parameter, move doc
 244         to header.
 245         * infrun.c (process_event_stop_test): Pass thread to
 246         set_step_info call.
 247         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
 248         set_step_info.
 249         (prepare_one_step): Add thread_info parameter, pass it to
 250         set_step_frame and prepare_one_step (recursive) call.
 251         (step_1): Pass thread to prepare_one_step call.
 252         (step_command_fsm::should_stop): Pass thread to
 253         prepare_one_step.
 254         (until_next_fsm): Pass thread to set_step_frame call.
 255         (finish_command): Pass thread to set_step_info call.
 256
 257 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
 258
 259         * windows-tdep.c (windows_solib_create_inferior_hook):
 260         Check if inferior is running.
 261
 262 2020-03-06  Tom de Vries  <tdevries@suse.de>
 263
 264         * NEWS: Fix "the the".
 265         * ctfread.c: Same.
 266
 267 2020-03-06  Tom de Vries  <tdevries@suse.de>
 268
 269         * psymtab.c (psymtab_to_symtab): Don't print "done.".
 270
 271 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 272
 273         * .dir-locals.el: Add a comment referencing the other copies of
 274         this file.
 275
 276 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
 277
 278         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
 279         psargs.
 280
 281 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 282
 283         * .gitattributes: New file.
 284
 285 2020-03-04  Tom Tromey  <tom@tromey.com>
 286
 287         * symmisc.c (print_symbol_bcache_statistics)
 288         (print_objfile_statistics): Update.
 289         * symfile.c (allocate_symtab): Use intern.
 290         * psymtab.c (partial_symtab::partial_symtab): Use intern.
 291         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 292         macro_cache>: Remove.
 293         <string_cache>: New member.
 294         (struct objfile) <intern>: New methods.
 295         * elfread.c (elf_symtab_read): Use intern.
 296         * dwarf2/read.c (fixup_go_packaging): Intern package name.
 297         (dwarf2_compute_name, dwarf2_physname)
 298         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
 299         names.
 300         (guess_partial_die_structure_name): Update.
 301         (partial_die_info::fixup): Intern name.
 302         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
 303         name.
 304         (dwarf2_name): Intern name.  Update.
 305         * buildsym.c (buildsym_compunit::get_macro_table): Use
 306         string_cache.
 307
 308 2020-03-04  Tom Tromey  <tom@tromey.com>
 309
 310         * jit.c (bfd_open_from_target_memory): Make "target" const.
 311         * corefile.c (gnutarget): Now const.
 312         * gdbcore.h (gnutarget): Now const.
 313
 314 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
 315
 316         * NEWS: Mention support for WOW64 processes.
 317         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
 318         (amd64_windows_segment_register_p): Remove static.
 319         (_initialize_amd64_windows_nat): Update.
 320         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
 321         * i386-windows-nat.c (context_offset): Update.
 322         (i386_mappings): Rename and remove static.
 323         (i386_windows_segment_register_p): Remove static.
 324         (_initialize_i386_windows_nat): Update.
 325         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
 326         (STATUS_WX86_SINGLE_STEP): New macro.
 327         (EnumProcessModulesEx): New macro.
 328         (Wow64SuspendThread): New macro.
 329         (Wow64GetThreadContext): New macro.
 330         (Wow64SetThreadContext): New macro.
 331         (Wow64GetThreadSelectorEntry): New macro.
 332         (windows_set_context_register_offsets): Add static.
 333         (windows_set_segment_register_p): Likewise.
 334         (windows_add_thread): Adapt for WOW64 processes.
 335         (windows_fetch_one_register): Likewise.
 336         (windows_nat_target::fetch_registers): Likewise.
 337         (windows_store_one_register): Likewise.
 338         (display_selector): Likewise.
 339         (display_selectors): Likewise.
 340         (handle_exception): Likewise.
 341         (windows_continue): Likewise.
 342         (windows_nat_target::resume): Likewise.
 343         (windows_add_all_dlls): Likewise.
 344         (do_initial_windows_stuff): Likewise.
 345         (windows_nat_target::attach): Likewise.
 346         (windows_get_exec_module_filename): Likewise.
 347         (windows_nat_target::create_inferior): Likewise.
 348         (windows_xfer_siginfo): Likewise.
 349         (_initialize_loadable): Initialize Wow64SuspendThread,
 350         Wow64GetThreadContext, Wow64SetThreadContext,
 351         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
 352         * windows-nat.h (windows_set_context_register_offsets):
 353         Remove declaration.
 354         (windows_set_segment_register_p): Likewise.
 355         (i386_windows_segment_register_p): Add declaration.
 356         (amd64_windows_segment_register_p): Likewise.
 357
 358 2020-03-04  Luis Machado  <luis.machado@linaro.org>
 359
 360         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
 361         in "info registers" for AArch64/ARM.
 362
 363         The change caused "info registers" to not print GPR's.
 364
 365         gdb/ChangeLog:
 366
 367         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 368
 369         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 370         when reg->group is empty and reggroup is not.
 371
 372 2020-03-03  Tom Tromey  <tromey@adacore.com>
 373
 374         * dwarf2/frame.c (struct dwarf2_frame_cache)
 375         <checked_tailcall_bottom, entry_cfa_sp_offset,
 376         entry_cfa_sp_offset_p>: Remove members.
 377         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 378         (dwarf2_frame_prev_register): Don't call
 379         dwarf2_tailcall_sniffer_first.
 380         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 381         * frame-unwind.c (add_unwinder): New fuction.
 382         (frame_unwind_init): Use it.  Add tailcall unwinder.
 383
 384 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 385             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 386
 387         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 388         value should be printed as true.
 389
 390 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 391
 392         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 393         (windows_init_abi): Set and use windows_so_ops.
 394
 395 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 396
 397         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 398         when verifying if dealing with a convenience variable.
 399
 400 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 401
 402         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 403
 404 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 405
 406         * infrun.c (gdbarch_supports_displaced_stepping): New.
 407         (use_displaced_stepping): Break up conditions in smaller pieces.
 408         Use gdbarch_supports_displaced_stepping.
 409         (displaced_step_prepare_throw): Use
 410         gdbarch_supports_displaced_stepping.
 411
 412 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * NEWS: Mention new behaviour of the history filename.
 415         * top.c (write_history_p): Add comment.
 416         (show_write_history_p): Add header comment, give a different
 417         message when history writing is on, but the history filename is
 418         empty.
 419         (history_filename): Add comment.
 420         (history_filename_empty): New function.
 421         (show_history_filename): Add header comment, give a different
 422         message when the filename is empty.
 423         (init_history): Compare history_filename against nullptr, and only
 424         read history if the filename is not empty.
 425         (set_history_filename): Add header comment, and only make
 426         non-empty filenames absolute.
 427         (init_main): Make the filename argument to 'set history filename'
 428         optional.
 429
 430 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 431
 432         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 433         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 434         (fetch_fp_register): Update.
 435         (fetch_fp_regs): Update.
 436         (store_fp_register): Update.
 437         (store_fp_regs): Update.
 438         (arm_netbsd_nat_target::read_description): New function.
 439         (fetch_elfcore_registers): Update.
 440
 441 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 442
 443         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 444         general_thread if the stop reply is missing a thread-id.
 445         (remote_target::process_stop_reply): Use the first non-exited
 446         thread if the target didn't pass a thread-id.
 447         * infrun.c (do_target_wait): Move call to
 448         switch_to_inferior_no_thread to ....
 449         (do_target_wait_1): ... here.
 450
 451 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 452
 453         * debuginfod-support.c: Include defs.h first.
 454
 455 2020-02-28  Tom de Vries  <tdevries@suse.de>
 456
 457         * symfile.c (set_initial_language): Use default language for lookup.
 458
 459 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 462         reader variable, pass `this` to read_cutu_die_from_dwo.
 463
 464 2020-02-27  Aaron Merey  <amerey@redhat.com>
 465
 466         * source.c (open_source_file): Check for nullptr when computing
 467         srcpath.
 468
 469 2020-02-27  Tom Tromey  <tromey@adacore.com>
 470
 471         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 472         member.
 473         (dwarf2_add_field): Don't update nfields.
 474         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 475
 476 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 479         abs.
 480
 481 2020-02-26  Tom Tromey  <tom@tromey.com>
 482
 483         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 484         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 485         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 486         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 487         per_cu_data.
 488
 489 2020-02-26  Tom Tromey  <tom@tromey.com>
 490
 491         * dwarf2/index-write.c (psym_index_map): Change type.
 492         (add_address_entry_worker, write_one_signatured_type)
 493         (recursively_count_psymbols, recursively_write_psymbols)
 494         (class debug_names, psyms_seen_size, write_gdbindex)
 495         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 496
 497 2020-02-26  Aaron Merey  <amerey@redhat.com>
 498
 499         * Makefile.in: Handle optional debuginfod support.
 500         * NEWS: Update.
 501         * README: Add --with-debuginfod summary.
 502         * config.in: Regenerate.
 503         * configure: Regenerate.
 504         * configure.ac: Handle optional debuginfod support.
 505         * debuginfod-support.c: debuginfod helper functions.
 506         * debuginfod-support.h: Ditto.
 507         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 508         summary.
 509         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 510         when a dwz file cannot be found.
 511         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 512         debuginfo file cannot be found.
 513         * source.c (open_source_file): Query debuginfod servers when a
 514         source file cannot be found.
 515         * top.c (print_gdb_configuration): Include
 516         --{with,without}-debuginfod in the output.
 517
 518 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 519
 520         * thread.c (thr_try_catch_cmd): Print thread name.
 521
 522 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 523
 524         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 525         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 526         dwarf2_fetch_die_type_sect_off): Move to...
 527         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 528         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 529         dwarf2_fetch_die_type_sect_off): ... here.
 530         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 531         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 532         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 533
 534 2020-02-26  Tom de Vries  <tdevries@suse.de>
 535
 536         PR gdb/25603
 537         * symfile.c (set_initial_language): Exit-early if
 538         language_mode == language_mode_manual.
 539
 540 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 541
 542         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 543         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 544         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 545
 546 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * gdbtypes.c (create_array_type_with_stride): Handle negative
 549         array strides.
 550         * valarith.c (value_subscripted_rvalue): Likewise.
 551
 552 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 553
 554         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 555
 556 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 557
 558         * loc.h (dwarf2_get_die_type): Move to...
 559         * read.h (dwarf2_get_die_type): ... here.
 560         * read.c (dwarf2_get_die_type): Move doc to header.
 561
 562 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 563
 564         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 565         'gnulib/Makefile.in' to the list.
 566
 567 2020-02-24  Tom Tromey  <tom@tromey.com>
 568
 569         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 570         Remove.
 571         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 572         XOBNEWVEC.
 573
 574 2020-02-24  Tom Tromey  <tom@tromey.com>
 575
 576         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 577         New method.
 578         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 579         (dw2_do_instantiate_symtab, dw2_get_file_names)
 580         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 581
 582 2020-02-24  Tom Tromey  <tom@tromey.com>
 583
 584         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 585         make_scoped_restore.
 586         (dwarf2_psymtab::read_symtab): Don't clear
 587         reading_partial_symbols.
 588
 589 2020-02-24  Tom de Vries  <tdevries@suse.de>
 590
 591         PR gdb/25592
 592         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 593
 594 2020-02-24  Tom de Vries  <tdevries@suse.de>
 595
 596         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 597         commands layout next/prev/regs.
 598
 599 2020-02-22  Tom Tromey  <tom@tromey.com>
 600
 601         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 602         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 603
 604 2020-02-22  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 607
 608 2020-02-22  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 611         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 612         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 613         * tui/tui.c (_initialize_tui): Add usage text.
 614
 615 2020-02-22  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-win.c (tui_set_focus_command)
 618         (tui_set_win_height_command): Use error_no_arg.
 619         (_initialize_tui_win): Update help text.
 620         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 621
 622 2020-02-22  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 625         * tui/tui-disasm.h (struct tui_disasm_window)
 626         <display_start_addr>: Declare.
 627         * tui/tui-source.h (struct tui_source_window)
 628         <display_start_addr>: Declare.
 629         * tui/tui-winsource.h (struct tui_source_window_base)
 630         <show_source_line, display_start_addr>: New methods.
 631         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 632         Rename and move to protected section.
 633         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 634         (tui_source_window_base::do_erase_source_content): Update.
 635         (tui_source_window_base::show_source_line): Now a method.
 636         (tui_source_window_base::show_source_content)
 637         (tui_source_window_base::tui_source_window_base)
 638         (tui_source_window_base::rerender)
 639         (tui_source_window_base::refill)
 640         (tui_source_window_base::do_scroll_horizontal)
 641         (tui_source_window_base::set_is_exec_point_at)
 642         (tui_source_window_base::update_breakpoint_info)
 643         (tui_source_window_base::update_exec_info): Update.
 644         * tui/tui-source.c (tui_source_window::set_contents)
 645         (tui_source_window::showing_source_p)
 646         (tui_source_window::do_scroll_vertical)
 647         (tui_source_window::location_matches_p)
 648         (tui_source_window::line_is_displayed): Update.
 649         (tui_source_window::display_start_addr): New method.
 650         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 651         (tui_disasm_window::do_scroll_vertical)
 652         (tui_disasm_window::location_matches_p): Update.
 653         (tui_disasm_window::display_start_addr): New method.
 654
 655 2020-02-22  Tom Tromey  <tom@tromey.com>
 656
 657         * NEWS: Add entry for gdb.register_window_type.
 658         * tui/tui-layout.h (window_factory): New typedef.
 659         (tui_register_window): Declare.
 660         * tui/tui-layout.c (saved_tui_windows): New global.
 661         (tui_apply_current_layout): Use it.
 662         (tui_register_window): New function.
 663         * python/python.c (do_start_initialization): Call
 664         gdbpy_initialize_tui.
 665         (python_GdbMethods): Add "register_window_type" function.
 666         * python/python-internal.h (gdbpy_register_tui_window)
 667         (gdbpy_initialize_tui): Declare.
 668         * python/py-tui.c: New file.
 669         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 670
 671 2020-02-22  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 674
 675 2020-02-22  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 678         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 679         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 680         (tui_set_win_focus_to): Move from tui-win.c.
 681
 682 2020-02-22  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 685         functions.
 686         (known_window_types): New global.
 687         (tui_get_window_by_name): Reimplement.
 688         (initialize_known_windows): New function.
 689         (validate_window_name): Rewrite.
 690         (_initialize_tui_layout): Call initialize_known_windows.
 691
 692 2020-02-22  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 695         Remove constants.
 696         * tui/tui-winsource.h (struct tui_source_window_base)
 697         <tui_source_window_base>: Remove parameter.
 698         * tui/tui-winsource.c
 699         (tui_source_window_base::tui_source_window_base): Remove
 700         parameter.
 701         (tui_source_window_base::refill): Update.
 702         * tui/tui-stack.h (struct tui_locator_window)
 703         <tui_locator_window>: Update.
 704         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 705         Default the constructor.
 706         * tui/tui-regs.h (struct tui_data_item_window)
 707         <tui_data_item_window>: Default the constructor.
 708         (struct tui_data_window) <tui_data_window>: Likewise.
 709         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 710         Default the constructor.
 711         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 712         Default the constructor.
 713         <type>: Remove.
 714         (struct tui_win_info) <tui_win_info>: Default the constructor.
 715         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 716         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 717         Default the constructor.
 718
 719 2020-02-22  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 722         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 723         * tui/tui-win.c (tui_resize_all): Don't call
 724         tui_delete_invisible_windows.
 725         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 726         done.
 727         (tui_set_layout): Update.
 728         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 729         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 730         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 731
 732 2020-02-22  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 735         correctly.
 736
 737 2020-02-22  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 740
 741 2020-02-22  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-winsource.h (struct tui_source_window_iterator)
 744         <inner_iterator>: New etytypedef.
 745         <tui_source_window_iterator>: Take "end" parameter.
 746         <tui_source_window_iterator>: Take iterator.
 747         <operator*, advance>: Update.
 748         <m_iter>: Change type.
 749         <m_end>: New field.
 750         (struct tui_source_windows) <begin, end>: Update.
 751         * tui/tui-layout.c (tui_windows): New global.
 752         (tui_apply_current_layout): Clear tui_windows.
 753         (tui_layout_window::apply): Update tui_windows.
 754         * tui/tui-data.h (tui_windows): Declare.
 755         (all_tui_windows): Now inline function.
 756         (class tui_window_iterator, struct all_tui_windows): Remove.
 757
 758 2020-02-22  Tom Tromey  <tom@tromey.com>
 759
 760         PR tui/17850:
 761         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 762         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 763         "height" argument.
 764         (class tui_layout_window) <get_sizes>: Likewise.
 765         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 766         argument.
 767         <get_sizes>: Add "height" argument.
 768         <m_vertical>: New field.
 769         * tui/tui-layout.c (tui_layout_split::clone): Update.
 770         (tui_layout_split::get_sizes): Add "height" argument.
 771         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 772         (tui_new_layout_command): Parse "-horizontal".
 773         (_initialize_tui_layout): Update help string.
 774         (tui_layout_split::specification): Add "-horizontal" when needed.
 775         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 776         argument.
 777         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 778         New methods.
 779
 780 2020-02-22  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-layout.h (enum tui_adjust_result): New.
 783         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 784         (class tui_layout_window) <adjust_size>: Return
 785         tui_adjust_result.  Rewrite.
 786         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 787         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 788
 789 2020-02-22  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 792         parameter and return types.
 793         (class tui_layout_base) <specification>: Add "depth".
 794         (class tui_layout_window) <specification>: Add "depth".
 795         (class tui_layout_split) <specification>: Add "depth".
 796         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 797         and return types.
 798         (tui_new_layout_command): Parse sub-layouts.
 799         (_initialize_tui_layout): Update help string.
 800         (tui_layout_window::specification): Add "depth".
 801         (add_layout_command): Update.
 802
 803 2020-02-22  Tom Tromey  <tom@tromey.com>
 804
 805         * NEWS: Add "tui new-layout" item.
 806         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 807         Add new-layout command to help text.
 808         (validate_window_name): New function.
 809         (tui_new_layout_command): New function.
 810         (_initialize_tui_layout): Register "new-layout".
 811         (tui_layout_window::specification): New method.
 812         (tui_layout_window::specification): New method.
 813         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 814         method.
 815         (class tui_layout_window) <specification>: New method.
 816         (class tui_layout_split) <specification>: New method.
 817
 818 2020-02-22  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 821         * tui/tui-win.c (window_name_completer): Update comment.
 822         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 823         Declare method.
 824         (class tui_layout_window) <replace_window>: Likewise.
 825         (class tui_layout_split) <replace_window>: Likewise.
 826         (tui_set_layout): Don't declare.
 827         (tui_set_initial_layout): Declare function.
 828         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 829         (asm_regs_layout): New globals.
 830         (tui_current_layout, show_layout): Remove.
 831         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 832         (find_layout, tui_apply_layout): New function.
 833         (layout_completer): Remove.
 834         (tui_next_layout): Reimplement.
 835         (tui_next_layout_command): New function.
 836         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 837         (tui_regs_layout): Reimplement.
 838         (tui_regs_layout_command): New function.
 839         (extract_display_start_addr): Rewrite.
 840         (next_layout, prev_layout): Remove.
 841         (tui_layout_window::replace_window): New method.
 842         (tui_layout_split::replace_window): New method.
 843         (destroy_layout): New function.
 844         (layout_list): New global.
 845         (add_layout_command): New function.
 846         (initialize_layouts): Update.
 847         (tui_layout_command): New function.
 848         (_initialize_tui_layout): Install "layout" commands.
 849         * tui/tui-data.h (enum tui_layout_type): Remove.
 850         (tui_current_layout): Don't declare.
 851
 852 2020-02-22  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-regs.c (tui_reg_layout): Remove.
 855         (tui_reg_command): Use tui_regs_layout.
 856         * tui/tui-layout.h (tui_reg_command): Declare.
 857         * tui/tui-layout.c (tui_reg_command): New function.
 858
 859 2020-02-22  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui.c (tui_rl_delete_other_windows): Call
 862         tui_remove_some_windows.
 863         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 864         Declare method.
 865         (class tui_layout_window) <remove_windows>: New method.
 866         (class tui_layout_split) <remove_windows>: Declare.
 867         (tui_remove_some_windows): Declare.
 868         * tui/tui-layout.c (tui_remove_some_windows): New function.
 869         (tui_layout_split::remove_windows): New method.
 870
 871 2020-02-22  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 874         * tui/tui-layout.h (tui_next_layout): Declare.
 875         * tui/tui-layout.c (tui_next_layout): New function.
 876
 877 2020-02-22  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 880         correct coordinates.
 881
 882 2020-02-22  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 885         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 886         DATA_WIN case.
 887
 888 2020-02-22  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 891         TUI_DISASM_WIN, not tui_win_list.
 892
 893 2020-02-22  Tom Tromey  <tom@tromey.com>
 894
 895         * valprint.c (generic_val_print_enum_1)
 896         (val_print_type_code_flags): Style member names.
 897         * rust-lang.c (val_print_struct, rust_print_enum)
 898         (rust_print_struct_def, rust_internal_print_type): Style member
 899         names.
 900         * p-valprint.c (pascal_object_print_value_fields): Style member
 901         names.  Only call fprintf_symbol_filtered for static members.
 902         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 903         * f-valprint.c (f_val_print): Style member names.
 904         * f-typeprint.c (f_type_print_base): Style member names.
 905         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 906         call fprintf_symbol_filtered for static members.
 907         (cp_print_class_member): Style member names.
 908         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 909         member names.
 910         * ada-valprint.c (ada_print_scalar): Style enum names.
 911         (ada_val_print_enum): Likewise.
 912         * ada-typeprint.c (print_enum_type): Style enum names.
 913
 914 2020-02-21  Tom Tromey  <tom@tromey.com>
 915
 916         * psympriv.h (struct partial_symtab): Update comment.
 917
 918 2020-02-21  Tom Tromey  <tromey@adacore.com>
 919
 920         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 921         type is CORE_ADDR.
 922
 923 2020-02-21  Tom de Vries  <tdevries@suse.de>
 924
 925         PR gdb/25534
 926         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 927         if dependencies[i]->user != NULL.
 928
 929 2020-02-21  Ali Tamur  <tamur@google.com>
 930
 931         * dwarf2/read.c (dwarf2_name): Add null check.
 932
 933 2020-02-20  Tom Tromey  <tom@tromey.com>
 934
 935         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 936         ">=", in binary search.
 937         (dwarf2_find_containing_comp_unit): New overload.
 938         (run_test): New self-test.
 939         (_initialize_dwarf2_read): Register new test.
 940
 941 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 942
 943         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 944         * riscv-tdep.h: Likewise.
 945         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 946         rv32-only CSR.
 947         * features/riscv/64bit-csr.xml: Regenerated.
 948
 949 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 950             Tom Tromey  <tom@tromey.com>
 951
 952         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 953         of 'fputc_unfiltered'.
 954         (putchar_unfiltered): Call 'fputc_unfiltered'.
 955         (fputc_unfiltered): Call 'fputs_unfiltered'.
 956
 957 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * config.in: Regenerate.
 960         * configure: Regenerate.
 961         * configure.ac: Add --with-python-libdir option.
 962         * main.c: Use WITH_PYTHON_LIBDIR.
 963
 964 2020-02-19  Tom Tromey  <tom@tromey.com>
 965
 966         * symtab.c (general_symbol_info::compute_and_set_names): Use
 967         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 968
 969 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 970
 971         * dwarf2/read.c (allocate_signatured_type_table,
 972         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 973         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 974         Remove objfile parameter, update all callers.
 975
 976 2020-02-19  Doug Evans  <dje@google.com>
 977
 978         PR rust/25535
 979         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 980         rust_enum_variant calculation.
 981
 982 2020-02-19  Tom Tromey  <tromey@adacore.com>
 983
 984         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 985
 986 2020-02-19  Tom Tromey  <tromey@adacore.com>
 987
 988         * ada-lang.c (cache_symbol): Use obstack_strdup.
 989
 990 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * configure: Regenerate.
 993
 994 2020-02-19  Tom Tromey  <tromey@adacore.com>
 995
 996         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 997         NULL check.
 998
 999 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
1000
1001         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
1002
1003 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
1006         if GDBSERVER is not defined.
1007         (riscv_tdesc_cache): Likewise, also store const target_desc.
1008         (STATIC_IN_GDB): Define.
1009         (riscv_create_target_description): Update declaration with
1010         STATIC_IN_GDB.
1011         (riscv_lookup_target_description): New function, only define if
1012         GDBSERVER is not defined.
1013         * arch/riscv.h (riscv_create_target_description): Declare only
1014         when GDBSERVER is defined.
1015         (riscv_lookup_target_description): New declaration when GDBSERVER
1016         is not defined.
1017         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
1018         (riscv_linux_read_features): ...this, and return
1019         riscv_gdbarch_features instead of target_desc.
1020         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
1021         (riscv_linux_read_description): Rename to...
1022         (riscv_linux_read_features): ...this.
1023         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1024         Update to use riscv_gdbarch_features and
1025         riscv_lookup_target_description.
1026         * riscv-tdep.c (riscv_find_default_target_description): Use
1027         riscv_lookup_target_description instead of
1028         riscv_create_target_description.
1029
1030 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1031
1032         * valprint.c (generic_val_print_enum_1): When printing a flag
1033         enum with value 0 and there is no enumerator with value 0, print
1034         just "0" instead of "(unknown: 0x0)".
1035
1036 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1037
1038         * valprint.c (generic_val_print_enum_1): Print unknown part of
1039         flag enum in hex.
1040
1041 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1042
1043         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1044         flag enums to contain duplicate enumerators.
1045         * valprint.c (generic_val_print_enum_1): Update comment.
1046
1047 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1048
1049         * dwarf2/read.c: Include "count-one-bits.h".
1050         (update_enumeration_type_from_children): If an enumerator has
1051         multiple bits set, don't treat the enumeration as a "flag enum".
1052         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1053         of flag enums have 0 or 1 bit set.
1054
1055 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1056
1057         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1058         conversion.
1059         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1060         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1061         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1062         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1063         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1064
1065 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1066
1067         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1068
1069 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1070
1071         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1072         displaced_step_closure_up.
1073         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1074         (struct displaced_step_closure_up):
1075         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1076         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1077         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1078         Likewise.
1079         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1080         * gdbarch.c, gdbarch.h: Re-generate.
1081         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1082         displaced_step_closure_up.
1083         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1084         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1085         * infrun.h (displaced_step_closure_up): New type alias.
1086         (struct displaced_step_inferior_state) <step_closure>: Change
1087         type to displaced_step_closure_up.
1088         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1089         displaced_step_closure_up.
1090         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1091
1092 2020-02-14  Tom Tromey  <tom@tromey.com>
1093
1094         * minidebug.c (gnu_debug_key): New global.
1095         (find_separate_debug_file_in_section): Use it.
1096
1097 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1098
1099         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
1100         std::unique_ptr.
1101         * gdbarch.c: Re-generate.
1102         * gdbarch.h: Re-generate.
1103         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
1104         change.
1105         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
1106         type to std::unique_ptr.
1107         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1108         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1109         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1110         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1111         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
1112         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1113         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1114         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1115         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1116
1117 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1118
1119         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1120         std::unique_ptr.
1121         (displaced_step_clear): Rename to...
1122         (displaced_step_reset): ... this.  Just call displaced->reset ().
1123         (displaced_step_clear_cleanup): Rename to...
1124         (displaced_step_reset_cleanup): ... this.
1125         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1126         (displaced_step_fixup): Likewise.
1127         (resume_1): Likewise.
1128         (handle_inferior_event): Restore child's memory before calling
1129         displaced_step_fixup on the parent.
1130         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1131         to std::unique_ptr.
1132         <step_closure>: Change type to std::unique_ptr.
1133
1134 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1135
1136         * arm-tdep.c: Include count-one-bits.h.
1137         (cleanup_block_store_pc): Use count_one_bits.
1138         (cleanup_block_load_pc): Use count_one_bits.
1139         (arm_copy_block_xfer): Use count_one_bits.
1140         (thumb2_copy_block_xfer): Use count_one_bits.
1141         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1142         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1143         (thumb_get_next_pcs_raw): Use count_one_bits.
1144         (arm_get_next_pcs_raw): Use count_one_bits_l.
1145         * arch/arm.c (bitcount): Remove.
1146         * arch/arm.h (bitcount): Remove.
1147
1148 2020-02-14  Tom Tromey  <tromey@adacore.com>
1149
1150         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1151         Update.
1152         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1153         * dwarf2/loc.c (call_site_find_chain_1): Return
1154         unique_xmalloc_ptr.
1155         (call_site_find_chain): Likewise.
1156
1157 2020-02-14  Richard Biener  <rguenther@suse.de>
1158
1159         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1160         on expression with division operators.
1161
1162 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1163
1164         * MAINTAINERS (Write After Approval): Adding myself.
1165
1166 2020-02-12  Tom Tromey  <tom@tromey.com>
1167
1168         * event-loop.c (event_data, gdb_event, event_handler_func):
1169         Remove.
1170
1171 2020-02-12  Tom Tromey  <tom@tromey.com>
1172
1173         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1174         (dwarf2_frame_objfile_data): Add comment.
1175         (find_comp_unit, set_comp_unit): New functions.
1176         (dwarf2_frame_find_fde): Use find_comp_unit.
1177         (dwarf2_build_frame_info): Use set_comp_unit.
1178
1179 2020-02-12  Tom Tromey  <tom@tromey.com>
1180
1181         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1182         (comp_unit): Don't initialize objfile.
1183         (execute_cfa_program): Add text_offset parameter.
1184         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1185         (dwarf2_frame_cache): Update.
1186         (dwarf2_build_frame_info): Don't set "objfile" member.
1187
1188 2020-02-12  Tom Tromey  <tom@tromey.com>
1189
1190         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1191         (decode_frame_entry): Likewise.
1192         (dwarf2_build_frame_info): Update.
1193
1194 2020-02-12  Tom Tromey  <tom@tromey.com>
1195
1196         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1197         (decode_frame_entry_1): Use the comp_unit obstack.
1198
1199 2020-02-12  Tom Tromey  <tom@tromey.com>
1200
1201         * dwarf2/frame.c (struct comp_unit): Add initializers and
1202         constructor.
1203         (dwarf2_frame_objfile_data): Store a comp_unit.
1204         (dwarf2_frame_find_fde): Update.
1205         (dwarf2_build_frame_info): Use "new".
1206
1207 2020-02-12  Tom Tromey  <tom@tromey.com>
1208
1209         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
1210         (dwarf2_fde_table): Typedef for std::vector.
1211         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
1212         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
1213         (decode_frame_entry): Update.
1214         (dwarf2_build_frame_info): Use "new".
1215
1216 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1217
1218         * arm-tdep.c (arm_gdbarch_init): Update.
1219         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
1220         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
1221         have_neon, is_m>: Change to bool.
1222
1223 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
1226
1227 2020-02-12  Tom Tromey  <tom@tromey.com>
1228
1229         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
1230
1231 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
1232
1233         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
1234         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
1235
1236 2020-02-11  Tom Tromey  <tom@tromey.com>
1237
1238         * psymtab.h: Update comment.
1239
1240 2020-02-11  Tom Tromey  <tom@tromey.com>
1241
1242         * gdb_obstack.h (struct auto_obstack): Use
1243         DISABLE_COPY_AND_ASSIGN.
1244
1245 2020-02-11  Tom Tromey  <tom@tromey.com>
1246
1247         * dwarf2/frame.h (struct objfile): Don't forward declare.
1248
1249 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1250
1251         * cris-tdep.c (cris_supply_gregset): Change signature to match
1252         what struct regset expects.
1253         (cris_regset): New struct.
1254         (fetch_core_registers): Remove.
1255         (cris_iterate_over_regset_sections): New function.
1256         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
1257         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
1258
1259 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1260
1261         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
1262         registers.
1263
1264 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1265
1266         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
1267
1268 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1269
1270         * configure: Re-generate.
1271
1272 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1273
1274         * configure: Re-generate.
1275
1276 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1277
1278         * acinclude: Update warning.m4 path.
1279         * warning.m4: Move to gdbsupport.
1280
1281 2020-02-11  Tom Tromey  <tromey@adacore.com>
1282
1283         * remote.c (remote_console_output): Update.
1284         * printcmd.c (printf_command): Update.
1285         * event-loop.c (gdb_wait_for_event): Update.
1286         * linux-nat.c (sigchld_handler): Update.
1287         * remote-sim.c (gdb_os_write_stdout): Update.
1288         (gdb_os_flush_stdout): Update.
1289         (gdb_os_flush_stderr): Update.
1290         (gdb_os_write_stderr): Update.
1291         * exceptions.c (print_exception): Update.
1292         * remote-fileio.c (remote_fileio_func_read): Update.
1293         (remote_fileio_func_write): Update.
1294         * tui/tui.c (tui_enable): Update.
1295         * tui/tui-interp.c (tui_interp::init): Update.
1296         * utils.c (init_page_info): Update.
1297         (putchar_unfiltered, fputc_unfiltered): Update.
1298         (gdb_flush): Update.
1299         (emit_style_escape): Update.
1300         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1301         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1302         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1303         (stderr_file::write): Update.
1304         (stderr_file::puts): Update.
1305         * ui-file.h (ui_file_isatty, ui_file_write)
1306         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1307         (ui_file_puts): Don't declare.
1308
1309 2020-02-10  Tom de Vries  <tdevries@suse.de>
1310
1311         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1312         sentinel to char *.
1313
1314 2020-02-09  Tom de Vries  <tdevries@suse.de>
1315
1316         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1317         filename if it matches "<artificial>".
1318
1319 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1320
1321         * windows-tdep.c (struct enum_value_name): New struct.
1322         (create_enum): New function.
1323         (windows_get_siginfo_type): Create and use enum types.
1324
1325 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1326
1327         * NEWS: Mention $_siginfo support for Windows.
1328         * windows-nat.c (handle_exception): Set siginfo_er.
1329         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1330         (windows_xfer_siginfo): New function.
1331         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1332         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1333         (init_windows_gdbarch_data): New function.
1334         (get_windows_gdbarch_data): New function.
1335         (windows_get_siginfo_type): New function.
1336         (windows_init_abi): Register windows_get_siginfo_type.
1337         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1338
1339 2020-02-08  Tom Tromey  <tom@tromey.com>
1340
1341         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1342         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1343         <keep>: Declare method.
1344         <m_keep>: Remove member.
1345         <~cutu_reader>: Remove.
1346         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1347         (cutu_reader::cutu_reader): Update.
1348         (cutu_reader::keep): Rename from ~cutu_reader.
1349         (process_psymtab_comp_unit, build_type_psymtabs_1)
1350         (process_skeletonless_type_unit, load_partial_comp_unit)
1351         (load_full_comp_unit, dwarf2_read_addr_index)
1352         (read_signatured_type): Update.
1353
1354 2020-02-08  Tom Tromey  <tom@tromey.com>
1355
1356         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1357         "want_partial_unit" parameter.
1358         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1359         Inline check for DW_TAG_partial_unit.
1360         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1361
1362 2020-02-08  Tom Tromey  <tom@tromey.com>
1363
1364         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1365         read.c.
1366         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1367         read.c.
1368
1369 2020-02-08  Tom Tromey  <tom@tromey.com>
1370
1371         * dwarf2/read.c (read_address): Move to comp-unit.c.
1372         (dwarf2_rnglists_process, dwarf2_ranges_process)
1373         (read_attribute_value, dwarf_decode_lines_1)
1374         (var_decode_location, decode_locdesc): Update.
1375         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1376         read.c.  Remove "cu" parameter.
1377         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1378         method.
1379
1380 2020-02-08  Tom Tromey  <tom@tromey.com>
1381
1382         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1383         (read_indirect_line_string): Update.
1384         * dwarf2/comp-unit.c (read_offset): Remove.
1385         (read_comp_unit_head): Update.
1386         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1387         method.
1388         (read_offset): Don't declare.
1389
1390 2020-02-08  Tom Tromey  <tom@tromey.com>
1391
1392         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1393         * dwarf2/read.c (struct comp_unit_head): Move to
1394         dwarf2/comp-unit.h.
1395         (enum class rcuh_kind): Move to comp-unit.h.
1396         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1397         (read_comp_unit_head, error_check_comp_unit_head)
1398         (read_and_check_comp_unit_head): Move to comp-unit.c.
1399         (read_offset, dwarf_unit_type_name): Likewise.
1400         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1401         (cutu_reader::cutu_reader, read_call_site_scope)
1402         (find_partial_die, follow_die_offset): Update.
1403         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1404
1405 2020-02-08  Tom Tromey  <tom@tromey.com>
1406
1407         * dwarf2/read.c (read_offset_1): Move to leb.c.
1408         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1409         (dwarf_decode_macro_bytes): Update.
1410         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1411         * dwarf2/leb.h (read_offset): Declare.
1412
1413 2020-02-08  Tom Tromey  <tom@tromey.com>
1414
1415         * dwarf2/read.c (dwarf2_section_size): Remove.
1416         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1417         Update.
1418         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1419
1420 2020-02-08  Tom Tromey  <tom@tromey.com>
1421
1422         * dwarf2/read.c (read_initial_length): Move to leb.c.
1423         * dwarf2/leb.h (read_initial_length): Declare.
1424         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1425         handle_nonstd parameter.
1426         * dwarf2/frame.c (read_initial_length): Remove.
1427         (decode_frame_entry_1): Update.
1428
1429 2020-02-08  Tom Tromey  <tom@tromey.com>
1430
1431         * dwarf2/loc.c (dwarf2_find_location_expression)
1432         (dwarf_evaluate_loc_desc::get_tls_address)
1433         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1434         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1435         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1436         (dwarf2_compile_property_to_c)
1437         (dwarf2_loc_desc_get_symbol_read_needs)
1438         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1439         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1440         (loclist_describe_location, loclist_tracepoint_var_ref)
1441         (loclist_generate_c_location): Update.
1442         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1443         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1444         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1445         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1446         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1447         (dwarf2_per_cu_data::addr_size)
1448         (dwarf2_per_cu_data::ref_addr_size)
1449         (dwarf2_per_cu_data::text_offset)
1450         (dwarf2_per_cu_data::addr_type): Now methods.
1451         (per_cu_header_read_in): Make per_cu "const".
1452         (dwarf2_version): Remove.
1453         (dwarf2_per_cu_data::int_type): Now a method.
1454         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1455         (set_die_type, read_array_type, read_subrange_index_type)
1456         (read_tag_string_type, read_subrange_type): Update.
1457         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1458         offset_size, ref_addr_size, text_offset, addr_type, version,
1459         objfile, int_type, addr_sized_int_type>: Declare methods.
1460
1461 2020-02-08  Tom Tromey  <tom@tromey.com>
1462
1463         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1464         Move earlier.
1465
1466 2020-02-08  Tom Tromey  <tom@tromey.com>
1467
1468         * dwarf2/read.h (dwarf_line_debug): Declare.
1469         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1470         * dwarf2/read.c: Move line_header code to new files.
1471         (dwarf_line_debug): No longer static.
1472         * dwarf2/line-header.c: New file.
1473         * dwarf2/line-header.h: New file.
1474
1475 2020-02-08  Tom Tromey  <tom@tromey.com>
1476
1477         * dwarf2/read.c (struct line_header) <file_full_name,
1478         file_file_name>: Return unique_xmalloc_ptr.
1479         (line_header::file_file_name): Update.
1480         (line_header::file_full_name): Update.
1481         (dw2_get_file_names_reader): Update.
1482         (macro_start_file): Update.
1483
1484 2020-02-08  Tom Tromey  <tom@tromey.com>
1485
1486         * dwarf2/read.c (struct line_header) <file_full_name,
1487         file_file_name>: Declare methods.
1488         (dw2_get_file_names_reader): Update.
1489         (file_file_name): Now a method.
1490         (file_full_name): Likewise.
1491         (macro_start_file): Update.
1492
1493 2020-02-08  Tom Tromey  <tom@tromey.com>
1494
1495         * dwarf2/read.c (dwarf_always_disassemble)
1496         (show_dwarf_always_disassemble): Move to loc.c.
1497         (_initialize_dwarf2_read): Move "always-disassemble" registration
1498         to loc.c.
1499         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1500         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1501         static.
1502         (show_dwarf_always_disassemble): Move from read.c.
1503         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1504
1505 2020-02-08  Tom Tromey  <tom@tromey.com>
1506
1507         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1508         (create_quick_file_names_table): Return htab_up.
1509         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1510         Update.
1511         * dwarf2/read.h (struct dwarf2_per_objfile)
1512         <quick_file_names_table>: Now htab_up.
1513
1514 2020-02-08  Tom Tromey  <tom@tromey.com>
1515
1516         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1517
1518 2020-02-08  Tom Tromey  <tom@tromey.com>
1519
1520         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1521         Rewrite.
1522         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1523         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1524         (abbrev_table::abbrev_table): No longer inline.
1525         (ABBREV_HASH_SIZE): Remove.
1526         (abbrev_table::m_abbrevs): Now an htab_up.
1527
1528 2020-02-08  Tom Tromey  <tom@tromey.com>
1529
1530         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1531         (cutu_reader): Update.
1532         (build_type_psymtabs_1): Update.
1533         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1534         (abbrev_table::alloc_abbrev): Update.
1535         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1536         (abbrev_table::read): New static method, renamed from
1537         abbrev_table_read_table.
1538         (abbrev_table::alloc_abbrev)
1539         (abbrev_table::add_abbrev): Now private.
1540         (abbrev_table::abbrev_table): Now private.
1541         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1542
1543 2020-02-08  Tom Tromey  <tom@tromey.com>
1544
1545         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1546         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1547         htab_up.
1548
1549 2020-02-08  Tom Tromey  <tom@tromey.com>
1550
1551         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1552         htab_up.
1553         (lookup_dwo_unit_in_dwp): Update.
1554         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1555         on obstack.
1556
1557 2020-02-08  Tom Tromey  <tom@tromey.com>
1558
1559         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1560         obstack.
1561
1562 2020-02-08  Tom Tromey  <tom@tromey.com>
1563
1564         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1565         line_header_hash.
1566         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1567         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1568         Change type to htab_up.
1569
1570 2020-02-08  Tom Tromey  <tom@tromey.com>
1571
1572         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1573         htab_up.  Don't allocate on obstack.
1574         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1575         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1576         Change type to htab_up.
1577
1578 2020-02-08  Tom Tromey  <tom@tromey.com>
1579
1580         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1581         Change type to htab_up.
1582         * dwarf2/read.c (create_signatured_type_table_from_index)
1583         (create_signatured_type_table_from_debug_names)
1584         (create_all_type_units, add_type_unit)
1585         (lookup_dwo_signatured_type, lookup_signatured_type)
1586         (process_skeletonless_type_unit): Update.
1587         (create_debug_type_hash_table, create_debug_types_hash_table):
1588         Change type of types_htab.
1589         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1590         htab_up.  Don't allocate on obstack.
1591         (create_cus_hash_table): Change type of cus_htab parameter.
1592         (struct dwo_file) <cus, tus>: Now htab_up.
1593         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1594         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1595         (queue_and_load_all_dwo_tus): Update.
1596         * dwarf2/index-write.c (write_gdbindex): Update.
1597         (write_debug_names): Update.
1598
1599 2020-02-08  Tom Tromey  <tom@tromey.com>
1600
1601         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1602         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1603         destructor.
1604         (struct dwarf2_per_objfile) <queue>: New member.
1605         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1606         dwarf2/read.h.
1607         (dwarf2_queue, dwarf2_queue_tail): Remove.
1608         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1609         DISABLE_COPY_AND_ASSIGN.
1610         <m_per_objfile>: New member.
1611         <~dwarf2_queue_guard>: Rewrite.
1612         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1613         Update.
1614         (~dwarf2_queue_item): New.
1615
1616 2020-02-08  Tom Tromey  <tom@tromey.com>
1617
1618         * dwarf2/read.c (struct die_info) <has_children>: New member.
1619         (dw2_get_file_names_reader): Remove has_children.
1620         (dw2_get_file_names): Update.
1621         (read_cutu_die_from_dwo): Remove has_children.
1622         (cutu_reader::init_tu_and_read_dwo_dies)
1623         (cutu_reader::cutu_reader): Update.
1624         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1625         Remove has_children.
1626         (build_type_psymtabs_1, process_skeletonless_type_unit)
1627         (load_partial_comp_unit, load_full_comp_unit): Update.
1628         (create_dwo_cu_reader): Remove has_children.
1629         (create_cus_hash_table, read_die_and_children): Update.
1630         (read_full_die_1,read_full_die): Remove has_children.
1631         (read_signatured_type): Update.
1632         (class cutu_reader) <has_children>: Remove.
1633
1634 2020-02-08  Tom Tromey  <tom@tromey.com>
1635
1636         * dwarf2/expr.c: Rename from dwarf2expr.c.
1637         * dwarf2/expr.h: Rename from dwarf2expr.h.
1638         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1639         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1640         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1641         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1642         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1643         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1644         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1645         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1646         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1647         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1648         * dwarf2/loc.c: Rename from dwarf2loc.c.
1649         * dwarf2/loc.h: Rename from dwarf2loc.h.
1650         * dwarf2/read.c: Rename from dwarf2read.c.
1651         * dwarf2/read.h: Rename from dwarf2read.h.
1652         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1653         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1654         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1655         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1656         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1657         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1658         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1659         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1660         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1661         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1662         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1663         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1664         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1665         Update.
1666         * Makefile.in (COMMON_SFILES): Update.
1667         (HFILES_NO_SRCDIR): Update.
1668
1669 2020-02-08  Tom Tromey  <tom@tromey.com>
1670
1671         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1672         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1673
1674 2020-02-08  Tom Tromey  <tom@tromey.com>
1675
1676         * dwarf2read.h (struct die_info): Don't declare.
1677
1678 2020-02-08  Tom Tromey  <tom@tromey.com>
1679
1680         * dwarf2read.h (die_info_ptr): Remove typedef.
1681
1682 2020-02-08  Tom Tromey  <tom@tromey.com>
1683
1684         * dwarf2read.c (read_call_site_scope)
1685         (handle_data_member_location, dwarf2_add_member_fn)
1686         (mark_common_block_symbol_computed, read_common_block)
1687         (attr_to_dynamic_prop, partial_die_info::read)
1688         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1689         (dwarf2_symbol_mark_computed, set_die_type): Update.
1690         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1691         method.
1692         (attr_form_is_block): Don't declare.
1693         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1694
1695 2020-02-08  Tom Tromey  <tom@tromey.com>
1696
1697         * dwarf2read.c (dwarf2_find_base_address, )
1698         (read_call_site_scope, rust_containing_type)
1699         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1700         (handle_data_member_location, dwarf2_add_member_fn)
1701         (get_alignment, read_structure_type, process_structure_scope)
1702         (mark_common_block_symbol_computed, read_common_block)
1703         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1704         (partial_die_info::read, read_attribute_value, new_symbol)
1705         (lookup_die_type, dwarf2_get_ref_die_offset)
1706         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1707         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1708         (dwarf2_symbol_mark_computed): Update.
1709         * dwarf2/attribute.h (struct attribute) <value_as_address,
1710         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1711         methods.
1712         (value_as_address, attr_form_is_section_offset)
1713         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1714         * dwarf2/attribute.c (attribute::value_as_address)
1715         (attribute::form_is_section_offset, attribute::form_is_constant)
1716         (attribute::form_is_ref): Now methods.
1717
1718 2020-02-08  Tom Tromey  <tom@tromey.com>
1719
1720         * dwarf2read.c (struct attribute, DW_STRING)
1721         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1722         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1723         (attr_form_is_block, attr_form_is_section_offset)
1724         (attr_form_is_constant, attr_form_is_ref): Move.
1725         * dwarf2/attribute.h: New file.
1726         * dwarf2/attribute.c: New file, from dwarf2read.c.
1727         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1728
1729 2020-02-08  Tom Tromey  <tom@tromey.com>
1730
1731         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1732         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1733         Move.
1734         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1735         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1736         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1737         abbrev.c.
1738         * dwarf2/abbrev.h: New file.
1739         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1740         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1741
1742 2020-02-08  Tom Tromey  <tom@tromey.com>
1743
1744         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1745         (dwarf2_section_size, dwarf2_get_section_info)
1746         (create_signatured_type_table_from_debug_names)
1747         (create_addrmap_from_aranges, read_debug_names_from_section)
1748         (get_gdb_index_contents_from_section, read_comp_unit_head)
1749         (error_check_comp_unit_head, read_abbrev_offset)
1750         (create_debug_type_hash_table, init_cu_die_reader)
1751         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1752         (read_comp_units_from_section, create_cus_hash_table)
1753         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1754         (create_dwp_v2_section, dwarf2_rnglists_process)
1755         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1756         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1757         (read_indirect_string_from_dwz, read_addr_index_1)
1758         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1759         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1760         (fill_in_loclist_baton): Update.
1761         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1762         get_containing_section, get_bfd_owner, get_bfd_section,
1763         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1764         (dwarf2_read_section, get_section_name, get_section_file_name)
1765         (get_containing_section, get_section_bfd_owner)
1766         (get_section_bfd_section, get_section_name, get_section_file_name)
1767         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1768         declare.
1769         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1770         (dwarf2_section_info::get_bfd_owner)
1771         (dwarf2_section_info::get_bfd_section)
1772         (dwarf2_section_info::get_name)
1773         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1774         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1775         (dwarf2_section_info::read): Now methods.
1776         * dwarf-index-write.c (class debug_names): Update.
1777
1778 2020-02-08  Tom Tromey  <tom@tromey.com>
1779
1780         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1781         Move to dwarf2/section.h.
1782         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1783         (get_section_bfd_section, get_section_name)
1784         (get_section_file_name, get_section_id, get_section_flags)
1785         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1786         dwarf2/section.c.
1787         * dwarf2/section.h: New file.
1788         * dwarf2/section.c: New file, from dwarf2read.c.
1789         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1790
1791 2020-02-08  Tom Tromey  <tom@tromey.com>
1792
1793         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1794         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1795         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1796         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1797         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1798         * dwarf2/leb.h: New file, from dwarf2read.c.
1799         * dwarf2/leb.c: New file, from dwarf2read.c.
1800         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1801         Remove.
1802         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1803         (COMMON_SFILES): Add dwarf2/leb.c.
1804
1805 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1806
1807         GDB 9.1 released.
1808
1809 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1810
1811         PR gdb/25190:
1812         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1813         * gdb/remote.c (remote_console_output): Update.
1814         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1815         (ui_file_puts): ...this.
1816         * gdb/ui-file.h (ui_file_puts): Add declaration.
1817         * gdb/utils.c (emit_style_escape): Update.
1818         (flush_wrap_buffer): Update.
1819         (fputs_maybe_filtered): Update.
1820         (fputs_unfiltered): Add function.
1821
1822 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1823
1824         * gdb/event-loop.c (gdb_wait_for_event): Update.
1825         * gdb/printcmd.c (printf_command): Update.
1826         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1827         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1828         (gdb_os_flush_stderr): Update.
1829         * gdb/remote.c (remote_console_output): Update.
1830         * gdb/ui-file.c (gdb_flush): Rename to...
1831         (ui_file_flush): ...this.
1832         (stderr_file::write): Update.
1833         (stderr_file::puts): Update.
1834         * gdb/ui-file.h (gdb_flush): Rename to...
1835         (ui_file_flush): ...this.
1836         * gdb/utils.c (gdb_flush): Add function.
1837         * gdb/utils.h (gdb_flush): Add declaration.
1838
1839 2020-02-07  Tom Tromey  <tromey@adacore.com>
1840
1841         PR breakpoints/24915:
1842         * source.c (find_and_open_source): Do not check basenames_may_differ.
1843
1844 2020-02-07  Tom Tromey  <tom@tromey.com>
1845
1846         * README: Update gdbserver documentation.
1847         * gdbserver: Move to top level.
1848         * configure.tgt (build_gdbserver): Remove.
1849         * configure.ac: Remove --enable-gdbserver.
1850         * configure: Rebuild.
1851         * Makefile.in (distclean): Don't mention gdbserver.
1852
1853 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1854
1855         * source-cache.c (source_cache::ensure): Surround
1856         get_plain_source_lines with a try/catch.
1857         (source_cache::get_line_charpos): Get rid of try/catch
1858         and only check for the return value of "ensure".
1859         * tui/tui-source.c (tui_source_window::set_contents):
1860         Simplify "nlines" calculation.
1861
1862 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1863
1864         * MAINTAINERS (Write After Approval): Add myself.
1865
1866 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1867
1868         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1869         function call.
1870
1871 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1872
1873         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1874
1875 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1876
1877         * nat/riscv-linux-tdesc.h: New file.
1878         * nat/riscv-linux-tdesc.c: New file, taking code from...
1879         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1880         ... here.
1881         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1882         NATDEPFILES.
1883
1884 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1887         we don't set the fake simulator ptid to the null_ptid.
1888
1889 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1890
1891         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1892         * gdbthread.h (class thread_info) <resumed>: Likewise.
1893         * infrun.c (resume_1): Likewise.
1894         (proceed): Likewise.
1895         (infrun_thread_stop_requested): Likewise.
1896         (stop_all_threads): Likewise.
1897         (handle_inferior_event): Likewise.
1898         (restart_threads): Likewise.
1899         (finish_step_over): Likewise.
1900         (keep_going_stepped_thread): Likewise.
1901         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1902         (linux_handle_extended_wait): Likewise.
1903         * record-btrace.c (get_thread_current_frame_id): Likewise.
1904         * record-full.c (record_full_wait_1): Likewise.
1905         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1906         * target.c (target_resume): Likewise.
1907         * thread.c (set_running_thread): Likewise.
1908
1909 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1910
1911         * f-valprint.c (f77_print_array_1): Changed datatype of index
1912         variable to LONGEST from int to enable it to contain bound
1913         values correctly.
1914
1915 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1916
1917         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1918         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1919         offsets according to FLEN determined.
1920         (riscv_linux_nat_target::read_description): Determine FLEN
1921         dynamically.
1922         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1923         according to FLEN determined.
1924         (riscv_linux_nat_target::store_registers): Likewise.
1925
1926 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1927
1928         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1929         when reg->group is empty and reggroup is not.
1930
1931 2020-01-31  Tom Tromey  <tromey@adacore.com>
1932
1933         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1934         Call beneath target's mourn_inferior after unpushing.
1935
1936 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         PR tui/9765
1939         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1940         have enough lines to fill the screen, still return the lowest
1941         address we found.
1942
1943 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1946         '-', '<', and '>' commands.
1947
1948 2020-01-29  Pedro Alves  <palves@redhat.com>
1949             Sergio Durigan Junior  <sergiodj@redhat.com>
1950
1951         * infcmd.c (construct_inferior_arguments): Assert that
1952         'argc' is greater than 0.
1953
1954 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1955
1956         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1957         (BRK_INSN_MASK): Define to 0xd4200000.
1958         (aarch64_program_breakpoint_here_p): New function.
1959         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1960         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1961         breakpoint.c.
1962         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1963         breakpoint.h
1964         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1965         call gdbarch_program_breakpoint_here_p.
1966         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1967         default_program_breakpoint_here_p, changed return type to bool and
1968         simplified.
1969         * breakpoint.h (program_breakpoint_here): Moved prototype to
1970         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1971         return type to bool.
1972         * gdbarch.c: Regenerate.
1973         * gdbarch.h: Regenerate.
1974         * gdbarch.sh (program_breakpoint_here_p): New method.
1975         * infrun.c (handle_signal_stop): Call
1976         gdbarch_program_breakpoint_here_p.
1977
1978 2020-01-26  Tom Tromey  <tom@tromey.com>
1979
1980         * ctfread.c (struct ctf_fp_info): Reindent.
1981         (_initialize_ctfread): Remove.
1982
1983 2020-01-26  Tom Tromey  <tom@tromey.com>
1984
1985         * psymtab.c (partial_map_expand_apply)
1986         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1987         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1988         (psym_print_stats, psym_expand_symtabs_for_function)
1989         (psym_map_symbol_filenames, psym_map_matching_symbols)
1990         (psym_expand_symtabs_matching)
1991         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1992         (maintenance_check_psymtabs): Use new methods.
1993         * psympriv.h (struct partial_symtab) <readin_p,
1994         get_compunit_symtab>: New methods.
1995         <readin, compunit_symtab>: Remove members.
1996         (struct standard_psymtab): New.
1997         (struct legacy_psymtab): Derive from standard_psymtab.
1998         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1999         standard_psymtab.
2000         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
2001
2002 2020-01-26  Tom Tromey  <tom@tromey.com>
2003
2004         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
2005         read_dependencies.  Add assert.
2006         * psymtab.c (partial_symtab::read_dependencies): New method.
2007         * psympriv.h (struct partial_symtab) <read_dependencies>: New
2008         method.
2009         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
2010         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
2011         read_dependencies.
2012         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
2013         Add assert.
2014
2015 2020-01-26  Tom Tromey  <tom@tromey.com>
2016
2017         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
2018         Call expand_psymtab.
2019         (xcoff_read_symtab): Call expand_psymtab.
2020         (xcoff_start_psymtab, xcoff_end_psymtab): Set
2021         legacy_expand_psymtab.
2022         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
2023         method.
2024         (struct legacy_psymtab) <expand_psymtab>: Implement.
2025         <legacy_expand_psymtab>: New member.
2026         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
2027         (parse_partial_symbols): Set legacy_expand_psymtab.
2028         (psymtab_to_symtab_1): Change argument order.  Call
2029         expand_psymtab.
2030         (new_psymtab): Set legacy_expand_psymtab.
2031         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
2032         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
2033         expand_psymtab.
2034         (dwarf2_psymtab::expand_psymtab): Rename from
2035         psymtab_to_symtab_1.  Call expand_psymtab.
2036         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
2037         (dbx_end_psymtab): Likewise.
2038         (dbx_psymtab_to_symtab_1): Change argument order. Call
2039         expand_psymtab.
2040         (dbx_read_symtab): Call expand_psymtab.
2041         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2042         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2043         (ctf_psymtab::read_symtab): Call expand_psymtab.
2044
2045 2020-01-26  Tom Tromey  <tom@tromey.com>
2046
2047         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2048         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2049         messages.
2050         * mdebugread.c (mdebug_read_symtab): Remove prints.
2051         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2052         assert.
2053         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2054
2055 2020-01-26  Tom Tromey  <tom@tromey.com>
2056
2057         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2058         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2059         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2060         legacy_symtab.
2061         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2062         * psymtab.c (psymtab_to_symtab): Call method.
2063         (dump_psymtab): Update.
2064         * psympriv.h (struct partial_symtab): Add virtual destructor.
2065         <read_symtab>: New method.
2066         (struct legacy_symtab): New.
2067         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2068         (struct pst_map) <pst>: Now a legacy_psymtab.
2069         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2070         (new_psymtab): Use legacy_psymtab.
2071         * dwarf2read.h (struct dwarf2_psymtab): New.
2072         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2073         * dwarf2read.c (dwarf2_create_include_psymtab)
2074         (dwarf2_build_include_psymtabs, create_type_unit_group)
2075         (create_partial_symtab, process_psymtab_comp_unit_reader)
2076         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2077         (set_partial_user): Use dwarf2_psymtab.
2078         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2079         (psymtab_to_symtab_1, process_full_comp_unit)
2080         (process_full_type_unit, dwarf2_ranges_read)
2081         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2082         (dwarf_decode_lines): Use dwarf2_psymtab.
2083         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2084         (add_address_entry_worker, write_one_signatured_type)
2085         (recursively_count_psymbols, recursively_write_psymbols)
2086         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2087         (write_debug_names): Likewise.
2088         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2089         <pst>: Now a legacy_psymtab.
2090         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2091         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2092         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2093         * ctfread.c (struct ctf_psymtab): New.
2094         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2095         ctf_psymtab.
2096         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
2097         (create_partial_symtab): Return a ctf_psymtab.
2098         (scan_partial_symbols): Update.
2099
2100 2020-01-26  Tom Tromey  <tom@tromey.com>
2101
2102         * xcoffread.c (xcoff_start_psymtab): Use new.
2103         * psymtab.c (partial_symtab::partial_symtab): New constructor,
2104         renamed from start_psymtab_common.
2105         * psympriv.h (struct partial_symtab): Add new constructor.
2106         (start_psymtab_common): Don't declare.
2107         * mdebugread.c (parse_partial_symbols): Use new.
2108         * dwarf2read.c (create_partial_symtab): Use new.
2109         * dbxread.c (start_psymtab): Use new.
2110         * ctfread.c (create_partial_symtab): Use new.
2111
2112 2020-01-26  Tom Tromey  <tom@tromey.com>
2113
2114         * xcoffread.c (xcoff_end_psymtab): Use new.
2115         * psymtab.c (start_psymtab_common): Use new.
2116         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2117         Update.
2118         * psympriv.h (struct partial_symtab): Add parameters to
2119         constructor.  Don't inline.
2120         (allocate_psymtab): Don't declare.
2121         * mdebugread.c (new_psymtab): Use new.
2122         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2123         * dbxread.c (dbx_end_psymtab): Use new.
2124
2125 2020-01-26  Tom Tromey  <tom@tromey.com>
2126
2127         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2128         allocate_psymtab.  Update documentation.
2129         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2130         allocate_psymtab.  Do not use new.
2131         (allocate_psymtab): Use new.  Update.
2132
2133 2020-01-26  Tom Tromey  <tom@tromey.com>
2134
2135         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2136         * psymtab.c (psym_print_stats): Update.
2137         * psympriv.h (struct partial_symtab) <readin,
2138         psymtabs_addrmap_supported, anonymous>: Now bool.
2139         * mdebugread.c (psymtab_to_symtab_1): Update.
2140         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2141         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2142         (process_full_comp_unit, process_full_type_unit): Update.
2143         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2144         * ctfread.c (psymtab_to_symtab): Update.
2145
2146 2020-01-26  Tom Tromey  <tom@tromey.com>
2147
2148         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2149         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2150         * psymtab.c (psymtab_storage): Delete psymtabs.
2151         (psymtab_storage::allocate_psymtab): Use new.
2152         (psymtab_storage::discard_psymtab): Use delete.
2153         * psympriv.h (struct partial_symtab): Add constructor and
2154         initializers.
2155
2156 2020-01-26  Tom Tromey  <tom@tromey.com>
2157
2158         * machoread.c: Do not include psympriv.h.
2159
2160 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2161
2162         * NEWS: Mention the new option and the set/show commands.
2163
2164 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2165
2166         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2167         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2168         (validate_exec_file): New variables, enums, functions.
2169         (exec_file_locate_attach, print_section_info): Style the filenames.
2170         (_initialize_exec): Install show_exec_file_mismatch_command and
2171          set_exec_file_mismatch_command.
2172         * gdbcore.h (validate_exec_file): Declare.
2173         * infcmd.c (attach_command): Call validate_exec_file.
2174         * remote.c ( remote_target::remote_add_inferior): Likewise.
2175
2176 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * frame.c (find_frame_sal): Move call to get_next_frame into more
2179         inner scope.
2180         * inline-frame.c (inilne_state) <inline_state>: Update argument
2181         types.
2182         (inilne_state) <skipped_symbol>: Rename to...
2183         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2184         (skip_inline_frames): Build vector of skipped symbols and use this
2185         to reate the inline_state.
2186         (inline_skipped_symbol): Add a comment and some assertions, fetch
2187         skipped symbol from the list.
2188
2189 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * buildsym.c (lte_is_less_than): Delete.
2192         (buildsym_compunit::end_symtab_with_blockvector): Create local
2193         lambda function to sort line table entries, and use
2194         std::stable_sort instead of std::sort.
2195         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2196         markers when looking for a previous line.
2197
2198 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * dwarf2read.c (lnp_state_machine::record_line): Include
2201         end_sequence parameter in debug print out.  Record the line if we
2202         are at an end_sequence marker even if it's not the start of a
2203         statement.
2204         * symmisc.c (maintenance_print_one_line_table): Print end of
2205         sequence markers with 'END' not '0'.
2206
2207 2020-01-24  Pedro Alves  <palves@redhat.com>
2208
2209         PR gdb/25410
2210         * thread.c (scoped_restore_current_thread::restore): Use
2211         switch_to_inferior_no_thread.
2212         * exec.c: Include "progspace-and-thread.h".
2213         (add_target_sections, remove_target_sections):
2214         scoped_restore_current_pspace_and_thread instead of
2215         scoped_restore_current_thread.
2216         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
2217         and aspace to the inferior before calling clone_program_space.
2218         Remove stale comment.
2219
2220 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2221
2222         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
2223         (arm_netbsd_nat_target::fetch_registers): ...this.
2224         (arm_nbsd_nat_target::store_registers): Rename to...
2225         (arm_netbsd_nat_target::store_registers): ...this.
2226
2227 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2228
2229         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2230         register_t.
2231
2232 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2233
2234         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
2235         Update comment.
2236         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
2237         Likewise.
2238         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
2239         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
2240         the correct replacement (iterate_over_regset_sections).
2241         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
2242         Update comment.
2243
2244 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
2245
2246         PR gdb/23718
2247         * gdb/python/python.c (execute_gdb_command): Call
2248         async_enable_stdin in catch block.
2249
2250 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
2253         SWITCH_THRU_ALL_UIS.
2254
2255 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         PR tui/9765
2258         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
2259         comment, add extra parameter, and update to store previous symbol
2260         when appropriate.
2261         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
2262         add extra parameter.
2263         * tui/tui-disasm.c (tui_disassemble): Update header comment,
2264         remove unneeded parameter, add try/catch around gdb_print_insn,
2265         rewrite to add items to asm_lines vector.
2266         (tui_find_backward_disassembly_start_address): New function.
2267         (tui_find_disassembly_address): Updated throughout.
2268         (tui_disasm_window::set_contents): Update for changes to
2269         tui_disassemble.
2270         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2271         number of lines to scroll.
2272
2273 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2274
2275         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2276         (SECT_OFF_DATA): Likewise.
2277         (SECT_OFF_RODATA): Likewise.
2278         (SECT_OFF_TEXT): Likewise.
2279         (SECT_OFF_BSS): Likewise.
2280         (struct objfile) <text_section_offset, data_section_offset>: New
2281         methods.
2282         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2283         objfile::text_section_offset.
2284         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2285         * coffread.c (coff_symtab_read): Likewise.
2286         (enter_linenos): Likewise.
2287         (process_coff_symbol): Likewise.
2288         * ctfread.c (get_objfile_text_range): Likewise.
2289         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2290         Use objfile::data_section_offset.
2291         * dwarf2-frame.c (execute_cfa_program): Use
2292         objfile::text_section_offset.
2293         (dwarf2_frame_find_fde): Likewise.
2294         * dwarf2read.c (create_addrmap_from_index): Likewise.
2295         (create_addrmap_from_aranges): Likewise.
2296         (dw2_find_pc_sect_compunit_symtab): Likewise.
2297         (process_psymtab_comp_unit_reader): Likewise.
2298         (add_partial_symbol): Likewise.
2299         (add_partial_subprogram): Likewise.
2300         (process_full_comp_unit): Likewise.
2301         (read_file_scope): Likewise.
2302         (read_func_scope): Likewise.
2303         (read_lexical_block_scope): Likewise.
2304         (read_call_site_scope): Likewise.
2305         (dwarf2_rnglists_process): Likewise.
2306         (dwarf2_ranges_process): Likewise.
2307         (dwarf2_ranges_read): Likewise.
2308         (dwarf_decode_lines_1): Likewise.
2309         (new_symbol): Likewise.
2310         (dwarf2_fetch_die_loc_sect_off): Likewise.
2311         (dwarf2_per_cu_text_offset): Likewise.
2312         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2313         * hppa-tdep.c (read_unwind_info): Likewise.
2314         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2315         * psympriv.h (struct partial_symtab): Likewise.
2316         * psymtab.c (find_pc_sect_psymtab): Likewise.
2317         * solib-svr4.c (enable_break): Likewise.
2318         * stap-probe.c (relocate_address): Use
2319         objfile::data_section_offset.
2320         * xcoffread.c (enter_line_range): Use
2321         objfile::text_section_offset.
2322         (read_xcoff_symtab): Likewise.
2323
2324 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2325
2326         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2327         declaration to narrower scopes.
2328
2329 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2330
2331         * darwin-nat.h (struct darwin_exception_msg, enum
2332         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2333         Move up.
2334         (class darwin_nat_target) <wait_1, check_new_threads,
2335         decode_exception_message, decode_message, stop_inferior,
2336         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2337         * darwin-nat.c (darwin_check_new_threads): Rename to...
2338         (darwin_nat_target::check_new_threads): ... this.
2339         (darwin_suspend_inferior_it): Remove.
2340         (darwin_decode_exception_message): Rename to...
2341         (darwin_nat_target::decode_exception_message): ... this.
2342         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2343         (darwin_decode_message): Rename to...
2344         (darwin_nat_target::decode_message): ... this.
2345         (cancel_breakpoint): Rename to...
2346         (darwin_nat_target::cancel_breakpoint): ... this.
2347         (darwin_wait): Rename to...
2348         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2349         instead of iterate_over_inferiors.
2350         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2351         (darwin_stop_inferior): Rename to...
2352         (darwin_nat_target::stop_inferior): ... this.
2353         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2354         (darwin_init_thread_list): Rename to...
2355         (darwin_nat_target::init_thread_list): ... this.
2356         (darwin_ptrace_him): Rename to...
2357         (darwin_nat_target::ptrace_him): ... this.
2358         (darwin_nat_target::create_inferior): Pass lambda function to
2359         fork_inferior.
2360         (darwin_nat_target::detach): Call stop_inferior instead of
2361         darwin_stop_inferior.
2362         * fork-inferior.h (fork_inferior): Change init_trace_fun
2363         parameter to gdb::function_view.
2364         * fork-inferior.c (fork_inferior): Likewise.
2365
2366 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2367
2368         * i386-cygwin-tdep.c (core_process_module_section): Update.
2369         * windows-nat.c (struct lm_info_windows): Add text_offset.
2370         (windows_xfer_shared_libraries): Update.
2371         * windows-tdep.c (windows_xfer_shared_library):
2372         Add text_offset_cached argument.
2373         * windows-tdep.h (windows_xfer_shared_library): Update.
2374
2375 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2376
2377         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2378
2379 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2380
2381         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2382         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2383         replace with range-based for.
2384         (gdbsim_interrupt_inferior): Remove.
2385         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2386         with a range-based for.  Inline code from
2387         gdbsim_interrupt_inferior.
2388
2389 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2390
2391         * infrun.c (proceed): Fix indentation.
2392
2393 2020-01-21  Tom Tromey  <tromey@adacore.com>
2394
2395         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2396         * python/python.c (python_extension_ops): Update.
2397         (gdbpy_colorize): New function.
2398         * python/lib/gdb/__init__.py (colorize): New function.
2399         * extension.h (ext_lang_colorize): Declare.
2400         * extension.c (ext_lang_colorize): New function.
2401         * extension-priv.h (struct extension_language_ops) <colorize>: New
2402         member.
2403         * cli/cli-style.c (_initialize_cli_style): Update help text.
2404
2405 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2406
2407         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2408         <cond>: Change type to bool.
2409         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2410         (aarch64_displaced_step_cb): Likewise.
2411         (aarch64_displaced_step_tb): Likewise.
2412
2413 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2414
2415         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2416         output.
2417
2418 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2419
2420         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2421         <pc_adjust>: Adjust the documentation.
2422         (aarch64_displaced_step_fixup): Check if PC really moved before
2423         adjusting it.
2424
2425 2020-01-19  Tom Tromey  <tom@tromey.com>
2426
2427         * disasm.c (~gdb_disassembler): New destructor.
2428         (gdb_buffered_insn_length): Call disassemble_free_target.
2429         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2430         DISABLE_COPY_AND_ASSIGN.
2431
2432 2020-01-19  Tom Tromey  <tom@tromey.com>
2433
2434         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2435         (die_reader_func_ftype): Remove.
2436         (cutu_reader): New class.
2437         (dw2_get_file_names_reader): Remove "data" parameter.
2438         (dw2_get_file_names): Use cutu_reader.
2439         (create_debug_type_hash_table): Update.
2440         (read_cutu_die_from_dwo): Update comment.
2441         (lookup_dwo_unit): Add dwo_name parameter.
2442         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2443         die_reader_func_ftype and data parameters.
2444         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2445         Remove die_reader_func_ftype and data parameters.
2446         (~cutu_reader): New; from init_cutu_and_read_dies.
2447         (cutu_reader::cutu_reader): Rename from
2448         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2449         and data parameters.
2450         (init_cutu_and_read_dies_simple): Remove.
2451         (struct process_psymtab_comp_unit_data): Remove.
2452         (process_psymtab_comp_unit_reader): Remove data parameter; add
2453         want_partial_unit and pretend_language parameters.
2454         (process_psymtab_comp_unit): Use cutu_reader.
2455         (build_type_psymtabs_reader): Remove data parameter.
2456         (build_type_psymtabs_1): Use cutu_reader.
2457         (process_skeletonless_type_unit): Likewise.
2458         (load_partial_comp_unit_reader): Remove.
2459         (load_partial_comp_unit): Use cutu_reader.
2460         (load_full_comp_unit_reader): Remove.
2461         (load_full_comp_unit): Use cutu_reader.
2462         (struct create_dwo_cu_data): Remove.
2463         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2464         dwo_unit parameters.
2465         (create_cus_hash_table): Use cutu_reader.
2466         (struct dwarf2_read_addr_index_data): Remove.
2467         (dwarf2_read_addr_index_reader): Remove.
2468         (dwarf2_read_addr_index): Use cutu_reader.
2469         (read_signatured_type_reader): Remove.
2470         (read_signatured_type): Use cutu_reader.
2471
2472 2020-01-19  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2475         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2476         (tui_wrefresh): Declare.
2477         * tui/tui-wingeneral.c (suppress_output): New global.
2478         (tui_suppress_output, ~tui_suppress_output): New constructor and
2479         destructor.
2480         (tui_wrefresh): New function.
2481         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2482         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2483         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2484         method.
2485         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2486         tui_wrefresh.
2487         (tui_data_window::no_refresh): New method.
2488         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2489         (tui_reg_command): Use tui_suppress_output
2490         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2491         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2492         method.
2493         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2494
2495 2020-01-19  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2498         Handle case where symtab is null.
2499
2500 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2501
2502         * linux-fork.c (one_fork_p): Simplify.
2503
2504 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2505
2506         * top.c (struct qt_args): Remove.
2507         (kill_or_detach): Change return type to void, replace `void *`
2508         parameter with a proper one.
2509         (print_inferior_quit_action):  Likewise.
2510         (quit_confirm): Use range-based for loop to iterate over inferiors.
2511         (quit_force): Likewise.
2512
2513 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2514
2515         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2516         `void *` parameter with proper parameters.
2517         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2518         (print_one_inferior): Change return type to void, replace `void *`
2519         parameter with proper parameters.
2520         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2521         inferiors.
2522         (get_other_inferior): Remove.
2523         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2524         inferiors.
2525
2526 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2527
2528         * mi/mi-interp.c (report_initial_inferior): Remove.
2529         (mi_interp::init): Use range-based for to iterate over inferiors.
2530
2531 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2532
2533         * python/py-inferior.c (build_inferior_list): Remove.
2534         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2535
2536 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2537
2538         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2539         (btrace_stitch_trace): Likewise.
2540         * charset.c (intermediate_encoding): Likewise (vaild).
2541         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2542         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2543         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2544
2545 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2546
2547         * windows-tdep.c (windows_get_tlb_type):
2548         Add rtl_user_process_parameters type.
2549
2550 2020-01-16  Pedro Alves  <palves@redhat.com>
2551             Norbert Lange  <nolange79@gmail.com>
2552
2553         PR build/24805
2554         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2555         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2556         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2557         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2558         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2559         (ps_plog): Redeclare exported functions with default visibility.
2560
2561 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2562
2563         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2564         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2565
2566 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2567
2568         * infcmd.c (post_create_inferior): Use get_thread_regcache
2569         instead of get_current_regcache.
2570
2571 2020-01-14  Tom Tromey  <tom@tromey.com>
2572
2573         PR symtab/12535:
2574         * python/python.c (gdbpy_decode_line): Treat empty string the same
2575         as no argument.
2576
2577 2020-01-14  Tom Tromey  <tom@tromey.com>
2578
2579         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2580
2581 2020-01-14  Tom Tromey  <tom@tromey.com>
2582
2583         * nat/linux-btrace.c: Don't include <config.h>.
2584         * nat/linux-ptrace.c: Don't include <config.h>.
2585         * nat/x86-linux-dregs.c: Don't include <config.h>.
2586
2587 2020-01-14  Tom Tromey  <tom@tromey.com>
2588
2589         * configure: Rebuild.
2590         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2591
2592 2020-01-14  Tom Tromey  <tom@tromey.com>
2593
2594         * nat/x86-linux-dregs.c: Include configh.h.
2595         * nat/linux-ptrace.c: Include configh.h.
2596         * nat/linux-btrace.c: Include configh.h.
2597         * defs.h: Include config.h, bfd.h.
2598         * configure.ac: Don't source common.host.
2599         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2600         * configure: Rebuild.
2601         * acinclude.m4: Update path.
2602         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2603         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2604         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2605         (CLIBS): Add LIBSUPPORT.
2606         (CDEPS): Likewise.
2607         (COMMON_SFILES): Remove gdbsupport files.
2608         (HFILES_NO_SRCDIR): Likewise.
2609         (stamp-version): Update path to create-version.sh.
2610         (ALLDEPFILES): Remove gdbsupport files.
2611
2612 2020-01-14  Tom Tromey  <tom@tromey.com>
2613
2614         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2615         USE_WIN32API when needed.
2616         * configure.ac (USE_WIN32API): Don't define.
2617         (WIN32LIBS): Use WIN32APILIBS.
2618         * configure: Rebuild.
2619
2620 2020-01-14  Tom Tromey  <tom@tromey.com>
2621
2622         * configure: Rebuild.
2623         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2624
2625 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2626
2627         * skip.c (skip_function_command): Make skip w/o arguments use the
2628         name of the inlined function if pc is inside any inlined function.
2629
2630 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2631
2632         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2633         * infrun.c (resume_1): Likewise.
2634         (handle_inferior_event): Remove stale comment.
2635         * linux-nat.c (linux_nat_target::resume): Update comments.
2636         (save_stop_reason): Likewise.
2637         (linux_nat_filter_event): Likewise.
2638         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2639
2640 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * elfread.c (record_minimal_symbol): Set section index to 0 for
2643         non-allocatable sections.
2644
2645
2646 2020-01-13  Ali Tamur <tamur@google.com>
2647
2648         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2649         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2650         to gdb::optional.  Update comments.
2651         (dwo_file): Update comments.
2652         (read_attribute): Update API to take an additional out parameter,
2653         need_reprocess.  This is used to mark attributes that need other
2654         attributes (e.g. str_offsets_base) for correct computation which may not
2655         have been read yet.
2656         (read_attribute_reprocess): New function declaration.
2657         (read_addr_index): Likewise.
2658         (read_dwo_str_index): Likewise.
2659         (read_stub_str_index): Likewise.
2660         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2661         (lookup_addr_base): New function definition.
2662         (lookup_ranges_base): Likewise.
2663         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2664         lookup_ranges_base.
2665         (init_cutu_and_read_dies): Update comments.
2666         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2667         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2668         Update comments.
2669         (init_cutu_and_read_dies_simple): Reflect API changes.
2670         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2671         (create_cus_hash_table): Change API to take parent compile unit.
2672         Reflect API changes.
2673         (open_and_init_dwo_file): Reflect API changes.
2674         (dwarf2_get_pc_bounds): Update comments.
2675         (dwarf2_record_block_ranges): Likewise.
2676         (read_full_die_1): Change implementation to reprocess attributes that
2677         need str_offsets_base and addr_base.
2678         (partial_die_info::read): Likewise.
2679         (read_attribute_reprocess): New function definition.
2680         (read_attribute_value): Change API to take an additional out parameter,
2681         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2682         when a non-dwo compile unit has index based attributes.
2683         (read_attribute): Reflect API changes.
2684         (read_addr_index_1): Reflect API changes.  Update comments.
2685         (dwarf2_read_addr_index_data): Reflect API changes.
2686         (dwarf2_read_addr_index): Likewise.
2687         (read_str_index): Change API and implementation.  This becomes a helper
2688         to be used by the new string index related methods.  Update error
2689         message and comments.
2690         (read_dwo_str_index): New function definition.
2691         (read_stub_str_index): Likewise.
2692         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2693         * symfile.h (dwarf2_debug_sections): Likewise.
2694         * xcoffread.c (dwarf2_debug_sections): Likewise.
2695
2696 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2697
2698         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2699         core_reg_sect type to gdb_byte *.
2700         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2701         * cris-tdep.c (fetch_core_registers): Likewise.
2702         * corelow.c (core_target::get_core_register_section): Change
2703         type of `contents` to gdb::byte_vector.
2704
2705 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * tui/tui-wingeneral.c (box_win): Position the title in the center
2708         of the border.
2709
2710 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2711
2712         * corelow.c (core_target::get_core_register_section): Use
2713           std::vector instead of alloca.
2714
2715 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2716
2717         * warning.m4: Add -Wmissing-declarations to build_warnings.
2718         * configure: Re-generate.
2719
2720 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2721
2722         * python/python.c (init__gdb_module): Add declaration.
2723
2724 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2725
2726         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2727         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2728         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2729         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2730         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2731         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2732         * ada-exp.y (_initialize_ada_exp): Add declaration.
2733         * ada-lang.c (_initialize_ada_language): Add declaration.
2734         * ada-tasks.c (_initialize_tasks): Add declaration.
2735         * agent.c (_initialize_agent): Add declaration.
2736         * aix-thread.c (_initialize_aix_thread): Add declaration.
2737         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2738         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2739         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2740         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2741         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2742         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2743         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2744         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2745         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2746         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2747         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2748         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2749         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2750         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2751         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2752         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2753         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2754         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2755         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2756         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2757         * annotate.c (_initialize_annotate): Add declaration.
2758         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2759         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2760         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2761         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2762         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2763         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2764         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2765         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2766         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2767         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2768         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2769         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2770         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2771         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2772         * auto-load.c (_initialize_auto_load): Add declaration.
2773         * auxv.c (_initialize_auxv): Add declaration.
2774         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2775         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2776         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2777         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2778         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2779         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2780         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2781         * breakpoint.c (_initialize_breakpoint): Add declaration.
2782         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2783         * btrace.c (_initialize_btrace): Add declaration.
2784         * charset.c (_initialize_charset): Add declaration.
2785         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2786         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2787         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2788         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2789         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2790         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2791         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2792         * coffread.c (_initialize_coffread): Add declaration.
2793         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2794         * compile/compile.c (_initialize_compile): Add declaration.
2795         * complaints.c (_initialize_complaints): Add declaration.
2796         * completer.c (_initialize_completer): Add declaration.
2797         * copying.c (_initialize_copying): Add declaration.
2798         * corefile.c (_initialize_core): Add declaration.
2799         * corelow.c (_initialize_corelow): Add declaration.
2800         * cp-abi.c (_initialize_cp_abi): Add declaration.
2801         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2802         * cp-support.c (_initialize_cp_support): Add declaration.
2803         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2804         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2805         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2806         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2807         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2808         * ctfread.c (_initialize_ctfread): Add declaration.
2809         * d-lang.c (_initialize_d_language): Add declaration.
2810         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2811         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2812         * dbxread.c (_initialize_dbxread): Add declaration.
2813         * dcache.c (_initialize_dcache): Add declaration.
2814         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2815         * disasm.c (_initialize_disasm): Add declaration.
2816         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2817         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2818         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2819         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2820         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2821         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2822         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2823         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2824         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2825         * elfread.c (_initialize_elfread): Add declaration.
2826         * exec.c (_initialize_exec): Add declaration.
2827         * extension.c (_initialize_extension): Add declaration.
2828         * f-lang.c (_initialize_f_language): Add declaration.
2829         * f-valprint.c (_initialize_f_valprint): Add declaration.
2830         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2831         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2832         * filesystem.c (_initialize_filesystem): Add declaration.
2833         * findcmd.c (_initialize_mem_search): Add declaration.
2834         * findvar.c (_initialize_findvar): Add declaration.
2835         * fork-child.c (_initialize_fork_child): Add declaration.
2836         * frame-base.c (_initialize_frame_base): Add declaration.
2837         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2838         * frame.c (_initialize_frame): Add declaration.
2839         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2840         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2841         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2842         * gcore.c (_initialize_gcore): Add declaration.
2843         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2844         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2845         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2846         * gdbarch.c (_initialize_gdbarch): Add declaration.
2847         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2848         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2849         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2850         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2851         * go-lang.c (_initialize_go_language): Add declaration.
2852         * go32-nat.c (_initialize_go32_nat): Add declaration.
2853         * guile/guile.c (_initialize_guile): Add declaration.
2854         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2855         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2856         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2857         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2858         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2859         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2860         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2861         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2862         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2863         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2864         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2865         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2866         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2867         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2868         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2869         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2870         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2871         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2872         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2873         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2874         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2875         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2876         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2877         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2878         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2879         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2880         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2881         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2882         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2883         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2884         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2885         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2886         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2887         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2888         * infcall.c (_initialize_infcall): Add declaration.
2889         * infcmd.c (_initialize_infcmd): Add declaration.
2890         * inflow.c (_initialize_inflow): Add declaration.
2891         * infrun.c (_initialize_infrun): Add declaration.
2892         * interps.c (_initialize_interpreter): Add declaration.
2893         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2894         * jit.c (_initialize_jit): Add declaration.
2895         * language.c (_initialize_language): Add declaration.
2896         * linux-fork.c (_initialize_linux_fork): Add declaration.
2897         * linux-nat.c (_initialize_linux_nat): Add declaration.
2898         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2899         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2900         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2901         * m2-lang.c (_initialize_m2_language): Add declaration.
2902         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2903         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2904         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2905         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2906         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2907         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2908         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2909         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2910         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2911         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2912         * machoread.c (_initialize_machoread): Add declaration.
2913         * macrocmd.c (_initialize_macrocmd): Add declaration.
2914         * macroscope.c (_initialize_macroscope): Add declaration.
2915         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2916         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2917         * maint.c (_initialize_maint_cmds): Add declaration.
2918         * mdebugread.c (_initialize_mdebugread): Add declaration.
2919         * memattr.c (_initialize_mem): Add declaration.
2920         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2921         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2922         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2923         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2924         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2925         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2926         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2927         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2928         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2929         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2930         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2931         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2932         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2933         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2934         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2935         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2936         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2937         * mipsread.c (_initialize_mipsread): Add declaration.
2938         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2939         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2940         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2941         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2942         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2943         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2944         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2945         * nto-procfs.c (_initialize_procfs): Add declaration.
2946         * objc-lang.c (_initialize_objc_language): Add declaration.
2947         * observable.c (_initialize_observer): Add declaration.
2948         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2949         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2950         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2951         * osabi.c (_initialize_gdb_osabi): Add declaration.
2952         * osdata.c (_initialize_osdata): Add declaration.
2953         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2954         * parse.c (_initialize_parse): Add declaration.
2955         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2956         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2957         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2958         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2959         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2960         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2961         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2962         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2963         * printcmd.c (_initialize_printcmd): Add declaration.
2964         * probe.c (_initialize_probe): Add declaration.
2965         * proc-api.c (_initialize_proc_api): Add declaration.
2966         * proc-events.c (_initialize_proc_events): Add declaration.
2967         * proc-service.c (_initialize_proc_service): Add declaration.
2968         * procfs.c (_initialize_procfs): Add declaration.
2969         * producer.c (_initialize_producer): Add declaration.
2970         * psymtab.c (_initialize_psymtab): Add declaration.
2971         * python/python.c (_initialize_python): Add declaration.
2972         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2973         * record-btrace.c (_initialize_record_btrace): Add declaration.
2974         * record-full.c (_initialize_record_full): Add declaration.
2975         * record.c (_initialize_record): Add declaration.
2976         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2977         * regcache.c (_initialize_regcache): Add declaration.
2978         * reggroups.c (_initialize_reggroup): Add declaration.
2979         * remote-notif.c (_initialize_notif): Add declaration.
2980         * remote-sim.c (_initialize_remote_sim): Add declaration.
2981         * remote.c (_initialize_remote): Add declaration.
2982         * reverse.c (_initialize_reverse): Add declaration.
2983         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2984         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2985         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2986         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2987         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2988         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2989         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2990         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2991         Add declaration.
2992         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2993         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2994         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2995         * rust-exp.y (_initialize_rust_exp): Add declaration.
2996         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2997         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2998         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2999         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
3000         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
3001         * score-tdep.c (_initialize_score_tdep): Add declaration.
3002         * ser-go32.c (_initialize_ser_dos): Add declaration.
3003         * ser-mingw.c (_initialize_ser_windows): Add declaration.
3004         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
3005         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
3006         * ser-uds.c (_initialize_ser_socket): Add declaration.
3007         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
3008         * serial.c (_initialize_serial): Add declaration.
3009         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
3010         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
3011         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
3012         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
3013         * skip.c (_initialize_step_skip): Add declaration.
3014         * sol-thread.c (_initialize_sol_thread): Add declaration.
3015         * solib-aix.c (_initialize_solib_aix): Add declaration.
3016         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
3017         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
3018         * solib-frv.c (_initialize_frv_solib): Add declaration.
3019         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
3020         * solib-target.c (_initialize_solib_target): Add declaration.
3021         * solib.c (_initialize_solib): Add declaration.
3022         * source-cache.c (_initialize_source_cache): Add declaration.
3023         * source.c (_initialize_source): Add declaration.
3024         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
3025         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
3026         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
3027         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
3028         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
3029         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
3030         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
3031         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
3032         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
3033         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
3034         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
3035         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
3036         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
3037         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
3038         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
3039         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
3040         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3041         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3042         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3043         * stabsread.c (_initialize_stabsread): Add declaration.
3044         * stack.c (_initialize_stack): Add declaration.
3045         * stap-probe.c (_initialize_stap_probe): Add declaration.
3046         * std-regs.c (_initialize_frame_reg): Add declaration.
3047         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3048         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3049         * symfile.c (_initialize_symfile): Add declaration.
3050         * symmisc.c (_initialize_symmisc): Add declaration.
3051         * symtab.c (_initialize_symtab): Add declaration.
3052         * target.c (_initialize_target): Add declaration.
3053         * target-connection.c (_initialize_target_connection): Add
3054         declaration.
3055         * target-dcache.c (_initialize_target_dcache): Add declaration.
3056         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3057         * thread.c (_initialize_thread): Add declaration.
3058         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3059         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3060         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3061         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3062         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3063         * tracectf.c (_initialize_ctf): Add declaration.
3064         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3065         * tracefile.c (_initialize_tracefile): Add declaration.
3066         * tracepoint.c (_initialize_tracepoint): Add declaration.
3067         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3068         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3069         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3070         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3071         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3072         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3073         * tui/tui.c (_initialize_tui): Add declaration.
3074         * typeprint.c (_initialize_typeprint): Add declaration.
3075         * ui-style.c (_initialize_ui_style): Add declaration.
3076         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3077         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3078         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3079         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3080         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3081         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3082         * unittests/filtered_iterator-selftests.c
3083         (_initialize_filtered_iterator_selftests): Add declaration.
3084         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3085         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3086         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3087         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3088         * unittests/main-thread-selftests.c
3089         (_initialize_main_thread_selftests): Add declaration.
3090         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3091         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3092         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3093         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3094         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3095         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
3096         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
3097         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
3098         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
3099         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
3100         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
3101         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
3102         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
3103         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
3104         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
3105         declaration.
3106         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
3107         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
3108         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
3109         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
3110         * user-regs.c (_initialize_user_regs): Add declaration.
3111         * utils.c (_initialize_utils): Add declaration.
3112         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
3113         * valops.c (_initialize_valops): Add declaration.
3114         * valprint.c (_initialize_valprint): Add declaration.
3115         * value.c (_initialize_values): Add declaration.
3116         * varobj.c (_initialize_varobj): Add declaration.
3117         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3118         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3119         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3120         * windows-nat.c (_initialize_windows_nat): Add declaration.
3121         (_initialize_check_for_gdb_ini): Add declaration.
3122         (_initialize_loadable): Add declaration.
3123         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3124         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3125         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3126         * xcoffread.c (_initialize_xcoffread): Add declaration.
3127         * xml-support.c (_initialize_xml_support): Add declaration.
3128         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3129         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3130         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3131         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3132
3133 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * regformats/regdat.sh: Generate declaration for init function.
3136
3137 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3138
3139         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3140         up.
3141         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3142         close_one_inferior>: New methods.
3143         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3144         pass down target to find_inferior_pid.
3145         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3146         Pass down target to find_inferior_ptid.
3147         (gdbsim_target::create_inferior): Pass down target to
3148         add_thread_silent.
3149         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3150         target down to find_inferior_ptid and switch_to_thread.
3151         (gdbsim_target::close): Update to call close_one_inferior.
3152         (struct resume_data): Remove.
3153         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3154         directly, rather than through a void pointer.
3155         (gdbsim_target::resume): Update to call resume_one_inferior.
3156
3157 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3158
3159         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3160
3161 2020-01-12  Pedro Alves  <palves@redhat.com>
3162
3163         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3164         directly for the current inferior instead of
3165         discard_all_inferiors.
3166         (discard_all_inferiors): Delete.
3167
3168 2020-01-11  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3171         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3172         deprecated_safe_get_selected_frame.
3173
3174 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3175
3176         * inferior.c (print_inferior): Switch inferior before printing it.
3177
3178 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3179             Pedro Alves  <palves@redhat.com>
3180
3181         * progspace-and-thread.c (switch_to_program_space_and_thread):
3182         Assert there's an inferior for PSPACE.  Use
3183         switch_to_inferior_no_thread to switch the inferior too.
3184         * progspace.c (program_space::~program_space): Call
3185         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3186         (program_space::free_all_objfiles): Don't call clear_symtab_users
3187         here.
3188         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3189
3190 2020-01-10  Pedro Alves  <palves@redhat.com>
3191
3192         * NEWS: Mention multi-target debugging, "info connections", and
3193         "add-inferior -no-connection".
3194
3195 2020-01-10  Pedro Alves  <palves@redhat.com>
3196
3197         * infrun.c: Include "target-connection.h".
3198         (check_multi_target_resumption): New.
3199         (proceed): Call it.
3200         * target-connection.c (make_target_connection_string): Make
3201         extern.
3202         * target-connection.h (make_target_connection_string): Declare.
3203
3204 2020-01-10  Pedro Alves  <palves@redhat.com>
3205
3206         * Makefile.in (COMMON_SFILES): Add target-connection.c.
3207         * inferior.c (uiout_field_connection): New function.
3208         (print_inferior): Add new "connection-id" column.
3209         (add_inferior_command): Show connection number/string of added
3210         inferior.
3211         * process-stratum-target.h
3212         (process_stratum_target::connection_string): New virtual method.
3213         (process_stratum_target::connection_number): New field.
3214         * remote.c (remote_target::connection_string): New override.
3215         * target-connection.c: New file.
3216         * target-connection.h: New file.
3217         * target.c (decref_target): Remove process_stratum targets from
3218         the connection list.
3219         (target_stack::push): Add process_stratum targets to the
3220         connection list.
3221
3222 2020-01-10  Pedro Alves  <palves@redhat.com>
3223
3224         Revert:
3225         2016-04-12  Pedro Alves  <palves@redhat.com>
3226         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
3227         Remove references to name.
3228         * serial.h (struct serial) <name>: Delete.
3229
3230 2020-01-10  Pedro Alves  <palves@redhat.com>
3231
3232         * gdbarch-selftests.c (register_to_value_test): Remove "target
3233         already pushed" check.
3234
3235 2020-01-10  Pedro Alves  <palves@redhat.com>
3236             John Baldwin  <jhb@FreeBSD.org>
3237
3238         * aarch64-linux-nat.c
3239         (aarch64_linux_nat_target::thread_architecture): Adjust.
3240         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
3241         (task_command_1): Likewise.
3242         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
3243         (aix_thread_target::wait, aix_thread_target::fetch_registers)
3244         (aix_thread_target::store_registers)
3245         (aix_thread_target::thread_alive): Adjust.
3246         * amd64-fbsd-tdep.c: Include "inferior.h".
3247         (amd64fbsd_get_thread_local_address): Pass down target.
3248         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
3249         thread's gdbarch instead of target_gdbarch.
3250         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
3251         get_last_target_status.
3252         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
3253         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
3254         inferiors.
3255         (update_inserted_breakpoint_locations): Skip if inferiors with no
3256         execution.
3257         (update_global_location_list): When handling moribund locations,
3258         find representative inferior for location's pspace, and use thread
3259         count of its process_stratum target.
3260         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
3261         * bsd-uthread.c (bsd_uthread_target::wait): Use
3262         as_process_stratum_target and adjust thread_change_ptid and
3263         add_thread calls.
3264         (bsd_uthread_target::update_thread_list): Use
3265         as_process_stratum_target and adjust find_thread_ptid,
3266         thread_change_ptid and add_thread calls.
3267         * btrace.c (maint_btrace_packet_history_cmd): Adjust
3268         find_thread_ptid call.
3269         * corelow.c (add_to_thread_list): Adjust add_thread call.
3270         (core_target_open): Adjust add_thread_silent and thread_count
3271         calls.
3272         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3273         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3274         * event-top.c (async_disconnect): Pop targets from all inferiors.
3275         * exec.c (add_target_sections): Push exec target on all inferiors
3276         sharing the program space.
3277         (remove_target_sections): Remove the exec target from all
3278         inferiors sharing the program space.
3279         (exec_on_vfork): New.
3280         * exec.h (exec_on_vfork): Declare.
3281         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3282         Pass it down.
3283         (fbsd_nat_target::update_thread_list): Adjust.
3284         (fbsd_nat_target::resume): Adjust.
3285         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3286         down.
3287         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3288         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3289         get_thread_arch_regcache call.
3290         * fork-child.c (gdb_startup_inferior): Pass target down to
3291         startup_inferior and set_executing.
3292         * gdbthread.h (struct process_stratum_target): Forward declare.
3293         (add_thread, add_thread_silent, add_thread_with_info)
3294         (in_thread_list): Add process_stratum_target parameter.
3295         (find_thread_ptid(inferior*, ptid_t)): New overload.
3296         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3297         parameter.
3298         (all_threads()): Delete overload.
3299         (all_threads, all_non_exited_threads): Add process_stratum_target
3300         parameter.
3301         (all_threads_safe): Use brace initialization.
3302         (thread_count): Add process_stratum_target parameter.
3303         (set_resumed, set_running, set_stop_requested, set_executing)
3304         (threads_are_executing, finish_thread_state): Add
3305         process_stratum_target parameter.
3306         (switch_to_thread): Use is_current_thread.
3307         * i386-fbsd-tdep.c: Include "inferior.h".
3308         (i386fbsd_get_thread_local_address): Pass down target.
3309         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3310         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3311         have_inferiors check.
3312         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3313         (inf_ptrace_target::attach): Adjust.
3314         * infcall.c (run_inferior_call): Adjust.
3315         * infcmd.c (run_command_1): Pass target to
3316         scoped_finish_thread_state.
3317         (proceed_thread_callback): Skip inferiors with no execution.
3318         (continue_command): Rename 'all_threads' local to avoid hiding
3319         'all_threads' function.  Adjust get_last_target_status call.
3320         (prepare_one_step): Adjust set_running call.
3321         (signal_command): Use user_visible_resume_target.  Compare thread
3322         pointers instead of inferior_ptid.
3323         (info_program_command): Adjust to pass down target.
3324         (attach_command): Mark target's 'thread_executing' flag.
3325         (stop_current_target_threads_ns): New, factored out from ...
3326         (interrupt_target_1): ... this.  Switch inferior before making
3327         target calls.
3328         * inferior-iter.h
3329         (struct all_inferiors_iterator, struct all_inferiors_range)
3330         (struct all_inferiors_safe_range)
3331         (struct all_non_exited_inferiors_range): Filter on
3332         process_stratum_target too.  Remove explicit.
3333         * inferior.c (inferior::inferior): Push dummy target on target
3334         stack.
3335         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3336         Add process_stratum_target parameter, and pass it down.
3337         (have_live_inferiors): Adjust.
3338         (switch_to_inferior_and_push_target): New.
3339         (add_inferior_command, clone_inferior_command): Handle
3340         "-no-connection" parameter.  Use
3341         switch_to_inferior_and_push_target.
3342         (_initialize_inferior): Mention "-no-connection" option in
3343         the help of "add-inferior" and "clone-inferior" commands.
3344         * inferior.h: Include "process-stratum-target.h".
3345         (interrupt_target_1): Use bool.
3346         (struct inferior) <push_target, unpush_target, target_is_pushed,
3347         find_target_beneath, top_target, process_target, target_at,
3348         m_stack>: New.
3349         (discard_all_inferiors): Delete.
3350         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3351         (all_inferiors, all_non_exited_inferiors): Add
3352         process_stratum_target parameter.
3353         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3354         (target_last_proc_target): New global.
3355         (follow_fork_inferior): Push target on new inferior.  Pass target
3356         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3357         reference count.
3358         (follow_fork): Adjust get_last_target_status call.  Also consider
3359         target.
3360         (follow_exec): Push target on new inferior.
3361         (struct execution_control_state) <target>: New field.
3362         (user_visible_resume_target): New.
3363         (do_target_resume): Call target_async.
3364         (resume_1): Set target's threads_executing flag.  Consider resume
3365         target.
3366         (commit_resume_all_targets): New.
3367         (proceed): Also consider resume target.  Skip threads of inferiors
3368         with no execution.  Commit resumtion in all targets.
3369         (start_remote): Pass current inferior to wait_for_inferior.
3370         (infrun_thread_stop_requested): Consider target as well.  Pass
3371         thread_info pointer to clear_inline_frame_state instead of ptid.
3372         (infrun_thread_thread_exit): Consider target as well.
3373         (random_pending_event_thread): New inferior parameter.  Use it.
3374         (do_target_wait): Rename to ...
3375         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3376         down.
3377         (threads_are_resumed_pending_p, do_target_wait): New.
3378         (prepare_for_detach): Adjust calls.
3379         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3380         do_target_wait_1 instead of do_target_wait.
3381         (fetch_inferior_event): Adjust.  Switch to representative
3382         inferior.  Pass target down.
3383         (set_last_target_status): Add process_stratum_target parameter.
3384         Save target in global.
3385         (get_last_target_status): Add process_stratum_target parameter and
3386         handle it.
3387         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3388         (context_switch): Check inferior_ptid == null_ptid before calling
3389         inferior_thread().
3390         (get_inferior_stop_soon): Pass down target.
3391         (wait_one): Rename to ...
3392         (poll_one_curr_target): ... this.
3393         (struct wait_one_event): New.
3394         (wait_one): New.
3395         (stop_all_threads): Adjust.
3396         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3397         event's target.
3398         (switch_back_to_stepped_thread): Also consider target.
3399         (print_stop_event): Update.
3400         (normal_stop): Update.  Also consider the resume target.
3401         * infrun.h (wait_for_inferior): Remove declaration.
3402         (user_visible_resume_target): New declaration.
3403         (get_last_target_status, set_last_target_status): New
3404         process_stratum_target parameter.
3405         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3406         process_stratum_target parameter, and use it.
3407         (clear_inline_frame_state (thread_info*)): New.
3408         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3409         process_stratum_target parameter.
3410         (clear_inline_frame_state (thread_info*)): Declare.
3411         * linux-fork.c (delete_checkpoint_command): Pass target down to
3412         find_thread_ptid.
3413         (checkpoint_command): Adjust.
3414         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3415         instead of just tweaking inferior_ptid.
3416         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3417         (exit_lwp): Pass target down to find_thread_ptid.
3418         (attach_proc_task_lwp_callback): Pass target down to
3419         add_thread/set_running/set_executing.
3420         (linux_nat_target::attach): Pass target down to
3421         thread_change_ptid.
3422         (get_detach_signal): Pass target down to find_thread_ptid.
3423         Consider last target status's target.
3424         (linux_resume_one_lwp_throw, resume_lwp)
3425         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3426         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3427         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3428         (linux_nat_target::async_wait_fd): New.
3429         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3430         target down.
3431         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3432         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3433         * linux-thread-db.c (struct thread_db_info::process_target): New
3434         field.
3435         (add_thread_db_info): Save target.
3436         (get_thread_db_info): New process_stratum_target parameter.  Also
3437         match target.
3438         (delete_thread_db_info): New process_stratum_target parameter.
3439         Also match target.
3440         (thread_from_lwp): Adjust to pass down target.
3441         (thread_db_notice_clone): Pass down target.
3442         (check_thread_db_callback): Pass down target.
3443         (try_thread_db_load_1): Always push the thread_db target.
3444         (try_thread_db_load, record_thread): Pass target down.
3445         (thread_db_target::detach): Pass target down.  Always unpush the
3446         thread_db target.
3447         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3448         target down.  Always unpush the thread_db target.
3449         (find_new_threads_callback, thread_db_find_new_threads_2)
3450         (thread_db_target::update_thread_list): Pass target down.
3451         (thread_db_target::pid_to_str): Pass current inferior down.
3452         (thread_db_target::get_thread_local_address): Pass target down.
3453         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3454         target down.
3455         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3456         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3457         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3458         (procfs_init_inferior): Rename to ...
3459         (procfs_target::procfs_init_inferior): ... this and adjust.
3460         (procfs_target::create_inferior, procfs_notice_thread)
3461         (procfs_do_thread_registers): Adjust.
3462         * ppc-fbsd-tdep.c: Include "inferior.h".
3463         (ppcfbsd_get_thread_local_address): Pass down target.
3464         * proc-service.c (ps_xfer_memory): Switch current inferior and
3465         program space as well.
3466         (get_ps_regcache): Pass target down.
3467         * process-stratum-target.c
3468         (process_stratum_target::thread_address_space)
3469         (process_stratum_target::thread_architecture): Pass target down.
3470         * process-stratum-target.h
3471         (process_stratum_target::threads_executing): New field.
3472         (as_process_stratum_target): New.
3473         * ravenscar-thread.c
3474         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3475         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3476         down.
3477         * record-btrace.c (record_btrace_target::info_record): Adjust.
3478         (record_btrace_target::record_method)
3479         (record_btrace_target::record_is_replaying)
3480         (record_btrace_target::fetch_registers)
3481         (get_thread_current_frame_id, record_btrace_target::resume)
3482         (record_btrace_target::wait, record_btrace_target::stop): Pass
3483         target down.
3484         * record-full.c (record_full_wait_1): Switch to event thread.
3485         Pass target down.
3486         * regcache.c (regcache::regcache)
3487         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3488         process_stratum_target parameter and handle it.
3489         (current_thread_target): New global.
3490         (get_thread_regcache): Add process_stratum_target parameter and
3491         handle it.  Switch inferior before calling target method.
3492         (get_thread_regcache): Pass target down.
3493         (get_thread_regcache_for_ptid): Pass target down.
3494         (registers_changed_ptid): Add process_stratum_target parameter and
3495         handle it.
3496         (registers_changed_thread, registers_changed): Pass target down.
3497         (test_get_thread_arch_aspace_regcache): New.
3498         (current_regcache_test): Define a couple local test_target_ops
3499         instances and use them for testing.
3500         (readwrite_regcache): Pass process_stratum_target parameter.
3501         (cooked_read_test, cooked_write_test): Pass mock_target down.
3502         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3503         (get_thread_arch_aspace_regcache): Add process_stratum_target
3504         parameter.
3505         (regcache::target): New method.
3506         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3507         (regcache::registers_changed_ptid): Add process_stratum_target
3508         parameter.
3509         (regcache::m_target): New field.
3510         (registers_changed_ptid): Add process_stratum_target parameter.
3511         * remote.c (remote_state::supports_vCont_probed): New field.
3512         (remote_target::async_wait_fd): New method.
3513         (remote_unpush_and_throw): Add remote_target parameter.
3514         (get_current_remote_target): Adjust.
3515         (remote_target::remote_add_inferior): Push target.
3516         (remote_target::remote_add_thread)
3517         (remote_target::remote_notice_new_inferior)
3518         (get_remote_thread_info): Pass target down.
3519         (remote_target::update_thread_list): Skip threads of inferiors
3520         bound to other targets.  (remote_target::close): Don't discard
3521         inferiors.  (remote_target::add_current_inferior_and_thread)
3522         (remote_target::process_initial_stop_replies)
3523         (remote_target::start_remote)
3524         (remote_target::remote_serial_quit_handler): Pass down target.
3525         (remote_target::remote_unpush_target): New remote_target
3526         parameter.  Unpush the target from all inferiors.
3527         (remote_target::remote_unpush_and_throw): New remote_target
3528         parameter.  Pass it down.
3529         (remote_target::open_1): Check whether the current inferior has
3530         execution instead of checking whether any inferior is live.  Pass
3531         target down.
3532         (remote_target::remote_detach_1): Pass down target.  Use
3533         remote_unpush_target.
3534         (extended_remote_target::attach): Pass down target.
3535         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3536         (remote_target::append_resumption): Pass down target.
3537         (remote_target::append_pending_thread_resumptions)
3538         (remote_target::remote_resume_with_hc, remote_target::resume)
3539         (remote_target::commit_resume): Pass down target.
3540         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3541         (remote_target::interrupt_query)
3542         (remote_target::remove_new_fork_children)
3543         (remote_target::check_pending_events_prevent_wildcard_vcont)
3544         (remote_target::remote_parse_stop_reply)
3545         (remote_target::process_stop_reply): Pass down target.
3546         (first_remote_resumed_thread): New remote_target parameter.  Pass
3547         it down.
3548         (remote_target::wait_as): Pass down target.
3549         (unpush_and_perror): New remote_target parameter.  Pass it down.
3550         (remote_target::readchar, remote_target::remote_serial_write)
3551         (remote_target::getpkt_or_notif_sane_1)
3552         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3553         down target.
3554         (remote_target::mourn_inferior): Pass down target.  Use
3555         remote_unpush_target.
3556         (remote_target::core_of_thread)
3557         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3558         (remote_target::pid_to_exec_file)
3559         (remote_target::thread_handle_to_thread_info): Pass down target.
3560         (remote_target::async_wait_fd): New.
3561         * riscv-fbsd-tdep.c: Include "inferior.h".
3562         (riscv_fbsd_get_thread_local_address): Pass down target.
3563         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3564         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3565         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3566         Adjust.
3567         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3568         * solib-svr4.c (enable_break): Pass down target.
3569         * spu-multiarch.c (parse_spufs_run): Pass down target.
3570         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3571         * target-delegates.c: Regenerate.
3572         * target.c (g_target_stack): Delete.
3573         (current_top_target): Return the current inferior's top target.
3574         (target_has_execution_1): Refer to the passed-in inferior's top
3575         target.
3576         (target_supports_terminal_ours): Check whether the initial
3577         inferior was already created.
3578         (decref_target): New.
3579         (target_stack::push): Incref/decref the target.
3580         (push_target, push_target, unpush_target): Adjust.
3581         (target_stack::unpush): Defref target.
3582         (target_is_pushed): Return bool.  Adjust to refer to the current
3583         inferior's target stack.
3584         (dispose_inferior): Delete, and inline parts ...
3585         (target_preopen): ... here.  Only dispose of the current inferior.
3586         (target_detach): Hold strong target reference while detaching.
3587         Pass target down.
3588         (target_thread_name): Add assertion.
3589         (target_resume): Pass down target.
3590         (target_ops::beneath, find_target_at): Adjust to refer to the
3591         current inferior's target stack.
3592         (get_dummy_target): New.
3593         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3594         has a thread running.
3595         (initialize_targets): Rename to ...
3596         (_initialize_target): ... this.
3597         * target.h: Include "gdbsupport/refcounted-object.h".
3598         (struct target_ops): Inherit refcounted_object.
3599         (target_ops::shortname, target_ops::longname): Make const.
3600         (target_ops::async_wait_fd): New method.
3601         (decref_target): Declare.
3602         (struct target_ops_ref_policy): New.
3603         (target_ops_ref): New typedef.
3604         (get_dummy_target): Declare function.
3605         (target_is_pushed): Return bool.
3606         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3607         (all_matching_threads_iterator::all_matching_threads_iterator):
3608         Handle filter target.
3609         * thread-iter.h (struct all_matching_threads_iterator, struct
3610         all_matching_threads_range, class all_non_exited_threads_range):
3611         Filter by target too.  Remove explicit.
3612         * thread.c (threads_executing): Delete.
3613         (inferior_thread): Pass down current inferior.
3614         (clear_thread_inferior_resources): Pass down thread pointer
3615         instead of ptid_t.
3616         (add_thread_silent, add_thread_with_info, add_thread): Add
3617         process_stratum_target parameter.  Use it for thread and inferior
3618         searches.
3619         (is_current_thread): New.
3620         (thread_info::deletable): Use it.
3621         (find_thread_ptid, thread_count, in_thread_list)
3622         (thread_change_ptid, set_resumed, set_running): New
3623         process_stratum_target parameter.  Pass it down.
3624         (set_executing): New process_stratum_target parameter.  Pass it
3625         down.  Adjust reference to 'threads_executing'.
3626         (threads_are_executing): New process_stratum_target parameter.
3627         Adjust reference to 'threads_executing'.
3628         (set_stop_requested, finish_thread_state): New
3629         process_stratum_target parameter.  Pass it down.
3630         (switch_to_thread): Also match inferior.
3631         (switch_to_thread): New process_stratum_target parameter.  Pass it
3632         down.
3633         (update_threads_executing): Reimplement.
3634         * top.c (quit_force): Pop targets from all inferior.
3635         (gdb_init): Don't call initialize_targets.
3636         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3637         Declare.
3638         (windows_add_thread, windows_delete_thread): Adjust.
3639         (get_windows_debug_event): Rename to ...
3640         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3641         * tracefile-tfile.c (tfile_target_open): Pass down target.
3642         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3643         Forward declare.
3644         (switch_to_thread): Add process_stratum_target parameter.
3645         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3646         parameter.  Use it.
3647         (mi_on_resume): Pass target down.
3648         * nat/fork-inferior.c (startup_inferior): Add
3649         process_stratum_target parameter.  Pass it down.
3650         * nat/fork-inferior.h (startup_inferior): Add
3651         process_stratum_target parameter.
3652         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3653
3654 2020-01-10  Pedro Alves  <palves@redhat.com>
3655
3656         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3657         directly.  Instead find the first thread in the thread list and
3658         use switch_to_thread.
3659
3660 2020-01-10  Pedro Alves  <palves@redhat.com>
3661
3662         * remote.c (remote_target::remote_add_inferior): Don't bind a
3663         process to the current inferior if the current inferior is already
3664         bound to a process.
3665
3666 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3667             Pedro Alves  <palves@redhat.com>
3668
3669         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3670         If no process is specified, return null_ptid instead of
3671         inferior_ptid.
3672         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3673         TARGET_WAITKIND_SIGNALLED with no pid.
3674
3675 2020-01-10  Pedro Alves  <palves@redhat.com>
3676
3677         * remote.c (first_remote_resumed_thread): New.
3678         (remote_target::wait_as): Use it as default event_ptid instead of
3679         inferior_ptid.
3680
3681 2020-01-10  Pedro Alves  <palves@redhat.com>
3682
3683         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3684
3685 2020-01-10  Pedro Alves  <palves@redhat.com>
3686
3687         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3688         not -1.
3689
3690 2020-01-10  Pedro Alves  <palves@redhat.com>
3691
3692         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3693         ptid to get_last_target_status.
3694         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3695         ptid to get_last_target_status.
3696         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3697         get_last_target_status.
3698         (info_program_command): Don't pass a target_waitstatus to
3699         get_last_target_status.
3700         * infrun.c (init_wait_for_inferior): Use
3701         nullify_last_target_wait_ptid.
3702         (get_last_target_status): Handle nullptr arguments.
3703         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3704         (print_stop_event): Don't pass a ptid to get_last_target_status.
3705         (normal_stop): Don't pass a ptid to get_last_target_status.
3706         * infrun.h (get_last_target_status, set_last_target_status): Move
3707         comments here and update.
3708         (nullify_last_target_wait_ptid): Declare.
3709         * linux-fork.c (fork_load_infrun_state): Remove local extern
3710         declaration of nullify_last_target_wait_ptid.
3711         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3712         to get_last_target_status.
3713
3714 2020-01-10  Pedro Alves  <palves@redhat.com>
3715
3716         * gdbthread.h (scoped_restore_current_thread)
3717         <dont_restore, restore, m_dont_restore>: Declare.
3718         * thread.c (thread_alive): Add assertion.  Return bool.
3719         (switch_to_thread_if_alive): New.
3720         (prune_threads): Switch inferior/thread.
3721         (print_thread_info_1): Switch thread before calling target methods.
3722         (scoped_restore_current_thread::restore): New, factored out from
3723         ...
3724         (scoped_restore_current_thread::~scoped_restore_current_thread):
3725         ... this.
3726         (scoped_restore_current_thread::scoped_restore_current_thread):
3727         Add assertion.
3728         (thread_apply_all_command, thread_select): Use
3729         switch_to_thread_if_alive.
3730         * infrun.c (proceed, restart_threads, handle_signal_stop)
3731         (switch_back_to_stepped_thread): Switch current thread before
3732         calling target methods.
3733
3734 2020-01-10  Pedro Alves <palves@redhat.com>
3735
3736         * inferior.c (switch_to_inferior_no_thread): New function,
3737         factored out from ...
3738         (inferior_command): ... here.
3739         * inferior.h (switch_to_inferior_no_thread): Declare.
3740         * mi/mi-main.c (run_one_inferior): Use
3741         switch_to_inferior_no_thread.
3742
3743 2020-01-10  Pedro Alves  <palves@redhat.com>
3744
3745         * infcmd.c (kill_command): Remove dead code.
3746
3747 2020-01-10  Pedro Alves  <palves@redhat.com>
3748
3749         * remote.c (remote_target::mourn_inferior): No longer check
3750         whether the target is running.
3751
3752 2020-01-10  Pedro Alves  <palves@redhat.com>
3753
3754         * corelow.c (core_target::has_execution): Change parameter type to
3755         inferior pointer.
3756         * inferior.c (number_of_live_inferiors): Use
3757         inferior::has_execution instead of target_has_execution_1.
3758         * inferior.h (inferior::has_execution): New.
3759         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3760         inferior::has_execution instead of target_has_execution_1.
3761         * process-stratum-target.c
3762         (process_stratum_target::has_execution): Change parameter type to
3763         inferior pointer.  Check the inferior's PID instead of
3764         inferior_ptid.
3765         * process-stratum-target.h
3766         (process_stratum_target::has_execution): Change parameter type to
3767         inferior pointer.
3768         * record-full.c (record_full_core_target::has_execution): Change
3769         parameter type to inferior pointer.
3770         * target.c (target_has_execution_1): Change parameter type to
3771         inferior pointer.
3772         (target_has_execution_current): Adjust.
3773         * target.h (target_ops::has_execution): Change parameter type to
3774         inferior pointer.
3775         (target_has_execution_1): Change parameter type to inferior
3776         pointer.  Change return type to bool.
3777         * tracefile.h (tracefile_target::has_execution): Change parameter
3778         type to inferior pointer.
3779
3780 2020-01-10  Pedro Alves  <palves@redhat.com>
3781
3782         * exceptions.c (print_flush): Remove current_top_target() check.
3783
3784 2020-01-10  Pedro Alves  <palves@redhat.com>
3785
3786         * remote.c (show_remote_exec_file): Show the current inferior's
3787         exec-file instead of the command variable's value.
3788
3789 2020-01-10  Pedro Alves  <palves@redhat.com>
3790
3791         * record-full.c (record_full_resume_ptid): New global.
3792         (record_full_target::resume): Set it.
3793         (record_full_wait_1): Use record_full_resume_ptid instead of
3794         inferior_ptid.
3795
3796 2020-01-10  Pedro Alves  <palves@redhat.com>
3797
3798         * gdbthread.h (scoped_restore_current_thread)
3799         <dont_restore, restore, m_dont_restore>: Declare.
3800         * thread.c (thread_alive): Add assertion.  Return bool.
3801         (switch_to_thread_if_alive): New.
3802         (prune_threads): Switch inferior/thread.
3803         (print_thread_info_1): Switch thread before calling target methods.
3804         (scoped_restore_current_thread::restore): New, factored out from
3805         ...
3806         (scoped_restore_current_thread::~scoped_restore_current_thread):
3807         ... this.
3808         (scoped_restore_current_thread::scoped_restore_current_thread):
3809         Add assertion.
3810         (thread_apply_all_command, thread_select): Use
3811         switch_to_thread_if_alive.
3812
3813 2020-01-10  George Barrett  <bob@bob131.so>
3814
3815         * stap-probe.c (stap_modify_semaphore): Don't check for null
3816         semaphores.
3817         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3818         for null semaphores.
3819
3820 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3821
3822         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3823         all source windows, and maintain horizontal scroll status while
3824         doing so.
3825
3826 2020-01-09  Tom Tromey  <tom@tromey.com>
3827
3828         PR tui/18932:
3829         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3830         update_source_window, not print_source_lines.
3831
3832 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3833
3834         * tui/tui.c (tui_enable): Register tui hooks after calling
3835         tui_display_main.
3836
3837 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3838
3839         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3840
3841 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3842
3843         * thread.c (print_thread_info_1): Fix indentation.
3844
3845 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3846
3847         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3848         unique_xmalloc_ptr outside the if to always free the demangled name.
3849
3850 2020-01-08  Tom Tromey  <tromey@adacore.com>
3851
3852         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3853         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3854         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3855         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3856         Remove.
3857         (section_offsets): New typedef.
3858         * symtab.c (fixup_section, get_msymbol_address): Update.
3859         * symmisc.c (dump_msymbols): Update.
3860         * symfile.h (relative_addr_info_to_section_offsets)
3861         (symfile_map_offsets_to_segments): Update.
3862         * symfile.c (build_section_addr_info_from_objfile)
3863         (init_objfile_sect_indices): Update.
3864         (struct place_section_arg): Change type of "offsets".
3865         (place_section): Update.
3866         (relative_addr_info_to_section_offsets): Change type of
3867         "section_offsets".  Remove "num_sections" parameter.
3868         (default_symfile_offsets, syms_from_objfile_1)
3869         (set_objfile_default_section_offset): Update.
3870         (reread_symbols): No need to preserve section offsets by hand.
3871         (symfile_map_offsets_to_segments): Change type of "offsets".
3872         * stap-probe.c (relocate_address): Update.
3873         * stabsread.h (process_one_symbol): Update.
3874         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3875         (solib_target_relocate_section_addresses): Update.
3876         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3877         Update.
3878         * solib-frv.c (frv_relocate_main_executable): Update.
3879         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3880         * solib-aix.c (solib_aix_get_section_offsets): Change return
3881         type.
3882         (solib_aix_solib_create_inferior_hook): Update.
3883         * remote.c (remote_target::get_offsets): Update.
3884         * psymtab.c (find_pc_sect_psymtab): Update.
3885         * psympriv.h (struct partial_symbol) <address, text_low,
3886         text_high>: Update.
3887         * objfiles.h (obj_section_offset): Update.
3888         (struct objfile) <section_offsets>: Change type.
3889         <num_sections>: Remove.
3890         (objfile_relocate): Update.
3891         * objfiles.c (entry_point_address_query): Update
3892         (relocate_one_symbol): Change type of "section_offsets".
3893         (objfile_relocate1, objfile_relocate1): Change type of
3894         "new_offsets".
3895         (objfile_rebase1): Update.
3896         * mipsread.c (mipscoff_symfile_read): Update.
3897         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3898         parameter.
3899         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3900         (parse_external, psymtab_to_symtab_1): Update.
3901         * machoread.c (macho_symfile_offsets): Update.
3902         * ia64-tdep.c (ia64_find_unwind_table): Update.
3903         * hppa-tdep.c (read_unwind_info): Update.
3904         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3905         * dwarf2read.c (create_addrmap_from_index)
3906         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3907         (process_psymtab_comp_unit_reader, add_partial_symbol)
3908         (add_partial_subprogram, process_full_comp_unit)
3909         (read_file_scope, read_func_scope, read_lexical_block_scope)
3910         (read_call_site_scope, dwarf2_rnglists_process)
3911         (dwarf2_ranges_process, dwarf2_ranges_read)
3912         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3913         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3914         Update.
3915         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3916         Update.
3917         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3918         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3919         (process_one_symbol): Change type of "section_offsets".
3920         * ctfread.c (get_objfile_text_range): Update.
3921         * coffread.c (coff_symtab_read, enter_linenos)
3922         (process_coff_symbol): Update.
3923         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3924         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3925
3926 2020-01-08  Tom Tromey  <tromey@adacore.com>
3927
3928         * dwarf2read.c (parse_macro_definition): Use std::string.
3929         (parse_macro_definition): Likewise.
3930
3931 2020-01-08  Tom Tromey  <tromey@adacore.com>
3932
3933         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3934         (ATTR_ALLOC_CHUNK): Remove.
3935
3936 2020-01-08  Tom Tromey  <tromey@adacore.com>
3937
3938         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3939
3940 2020-01-08  Tom Tromey  <tromey@adacore.com>
3941
3942         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3943         (dwarf2_compute_name, open_dwo_file): Likewise.
3944         (process_enumeration_scope): Use std::vector.
3945         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3946         (partial_die_info::fixup, dwarf2_start_subfile)
3947         (guess_full_die_structure_name, dwarf2_name): Likewise.
3948         (determine_prefix): Update.
3949         (guess_full_die_structure_name): Make return type const.
3950         (partial_die_full_name): Return unique_xmalloc_ptr.
3951         (DW_FIELD_ALLOC_CHUNK): Remove.
3952
3953 2020-01-07  Tom Tromey  <tromey@adacore.com>
3954
3955         PR build/24937:
3956         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3957
3958 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3959
3960         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3961
3962 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * stack.c (print_frame_info): Move disassemble_next_line code
3965         inside source_print block.
3966
3967 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3968
3969         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3970         gdb/signals.h, as we are now using native signal symbols.
3971
3972 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3973
3974         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3975         overflow by an early check of content vs threshold.
3976         * tui/tui-source.c (tui_source_window::line_is_displayed):
3977         Likewise.
3978
3979 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3980
3981         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3982
3983 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3984
3985         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3986         export table if no section contains it's RVA.
3987
3988 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3989
3990         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3991
3992 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3993
3994         * source.c (print_source_lines_base): Set last_line_listed.
3995
3996 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3997
3998         * tui/tui-disasm.c: Remove trailing spaces.
3999
4000 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4001             Pedro Alves  <palves@redhat.com>
4002
4003         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
4004         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
4005         (windows_gdb_signal_to_target): New function, uses the above
4006         enumeration to convert GDB internal signal codes to equivalent
4007         Windows codes.
4008         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
4009         * windows-nat.c: Include "gdb_wait.h".
4010         (get_windows_debug_event): Extract the fatal exception from the
4011         exit status and convert to the equivalent Posix signal number.
4012         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
4013         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
4014         * gdbsupport/gdb_wait.c: New file, implements
4015         windows_status_to_termsig.
4016         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
4017         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
4018
4019 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
4022         show_layout.
4023
4024 2020-01-05  Luis Machado  <luis.machado@linaro.org>
4025
4026         * aarch64-linux-nat.c
4027         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
4028         and bfd_mach_aarch64.
4029
4030 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * ui-file.c (stdio_file::can_emit_style_escape)
4033         (tee_file::can_emit_style_escape): Ensure style is used also on
4034         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
4035         to gdb_stdout.
4036         * main.c (set_gdb_data_directory): Use file style to output the
4037         warning that the given pathname is not a directory.
4038         * top.c (show_history_filename, gdb_safe_append_history)
4039         (show_gdb_datadir): Use file style.
4040
4041 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4042
4043         * solib-target.c (struct lm_info_target):
4044         Change offsets to be a unique_xmalloc_ptr.
4045         (solib_target_relocate_section_addresses): Update.
4046
4047 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4048
4049         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4050
4051 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4052
4053         * MAINTAINERS (Write After Approval): Add myself.
4054
4055 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4056
4057         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4058         Cell BE architecture.
4059         * target.h (struct target_ops) <thread_architecture>: Likewise.
4060
4061 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4062
4063         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4064
4065 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4066
4067         * MAINTAINERS (Write After Approval): Add myself.
4068
4069 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4070
4071         * gdbarch.sh: Update copyright year range of generated files.
4072
4073 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4074
4075         Update copyright year range in all GDB files.
4076
4077 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4078
4079         * copyright.py: Convert to Python 3.
4080
4081 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4082
4083         * copyright.py: Adapt after move of gnulib directory from gdb
4084         directory to toplevel directory.
4085
4086 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4087
4088         * copyright.py (main): Exit if run from the wrong directory.
4089
4090 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4091
4092         * top.c (print_gdb_version): Change copyright year to 2020.
4093
4094 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4095
4096         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
4097
4098 For older changes see ChangeLog-2019.
4099 \f
4100 Local Variables:
4101 mode: change-log
4102 left-margin: 8
4103 fill-column: 74
4104 version-control: never
4105 coding: utf-8
4106 End: