gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
   4         (struct fbsd_pspace_data): New type.
   5         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
   6         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
   7         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
   8         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
   9         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
  10
  11 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  12
  13         * gdbtypes.c (lookup_struct_elt): New function.
  14         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
  15         * gdbtypes.h (struct struct_elt): New type.
  16         (lookup_struct_elt): New prototype.
  17
  18 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  19
  20         * gdbtypes.c (lookup_struct_elt_type): Update comment and
  21         remove disabled code block.
  22
  23 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  24
  25         * gdbarch.sh (get_thread_local_address): New method.
  26         * gdbarch.h, gdbarch.c: Regenerate.
  27         * target.c (target_translate_tls_address): Use
  28         gdbarch_get_thread_local_address if present instead of
  29         target::get_thread_local_address.
  30
  31 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  32
  33         * target.h (target::get_thread_local_address): Update comment.
  34
  35 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  36
  37         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  38         objfile->separate_debug_objfile_backlink if not NULL.
  39
  40 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  41
  42         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  43         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  44         (amd64bsd_store_inferior_registers): Likewise.
  45         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  46         Enable segment base registers.
  47         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  48         PT_GETFSBASE and PT_GETGSBASE.
  49         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  50         PT_SETGSBASE.
  51         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  52         segment base registers.
  53         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  54
  55 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  56
  57         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  58         Update calls to i386_target_description to add 'segments'
  59         parameter.
  60         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  61         add segment base registers.
  62         * arch/i386.c (i386_create_target_description): Add 'segments'
  63         parameter to enable segment base registers.
  64         * arch/i386.h (i386_create_target_description): Likewise.
  65         * features/i386/32bit-segments.xml: New file.
  66         * features/i386/32bit-segments.c: Generate.
  67         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
  68         call to i386_target_description to add 'segments' parameter.
  69         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  70         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
  71         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
  72         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
  73         if feature is present.
  74         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
  75         Add 'segments' parameter to call to i386_target_description.
  76         (i386_target_description): Add 'segments' parameter to enable
  77         segment base registers.
  78         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
  79         to call to i386_target_description.
  80         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
  81         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
  82         Define I386_NUM_REGS.
  83         (i386_target_description): Add 'segments' parameter to enable
  84         segment base registers.
  85
  86 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  87
  88         PR/24325
  89         * source-cache.c: #undef open and close, to avoid unresolved
  90         externals during linking.
  91
  92 2019-03-12  Tom Tromey  <tromey@adacore.com>
  93
  94         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
  95         const.  Add initializers.
  96         (_initialize_remote): Don't initialize ptid globals.
  97
  98 2019-03-12  Pedro Alves  <palves@redhat.com>
  99
 100         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 101
 102 2019-03-12  Pedro Alves  <palves@redhat.com>
 103
 104         * cp-name-parser.y (main): Remove unused 'len' variable.
 105
 106 2019-03-12  Tom Tromey  <tromey@adacore.com>
 107
 108         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 109         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 110
 111 2019-03-12  Tom Tromey  <tromey@adacore.com>
 112
 113         * linux-nat.c (iterate_over_lwps): Update.
 114         (stop_callback): Remove parameter.
 115         (stop_wait_callback, detach_callback, resume_set_callback)
 116         (select_singlestep_lwp_callback, set_ignore_sigint)
 117         (status_callback, resumed_callback, resume_clear_callback)
 118         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 119         data parameter.
 120         (linux_nat_target::detach, linux_nat_target::resume)
 121         (linux_stop_and_wait_all_lwps, select_event_lwp)
 122         (linux_nat_filter_event, linux_nat_wait_1)
 123         (linux_nat_target::kill, linux_nat_target::stop)
 124         (linux_nat_target::stop): Update.
 125         (linux_nat_resume_callback): Change type.
 126         (resume_stopped_resumed_lwps, count_events_callback)
 127         (select_event_lwp_callback): Likewise.
 128         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 129         * arm-linux-nat.c (struct update_registers_data): Remove.
 130         (update_registers_callback): Change type.
 131         (arm_linux_insert_hw_breakpoint1): Update.
 132         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 133         parameter.
 134         (x86_linux_dr_set_addr): Update.
 135         (x86_linux_dr_set_control): Update.
 136         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 137         (iterate_over_lwps): Use gdb::function_view.
 138         * nat/aarch64-linux-hw-point.c (struct
 139         aarch64_dr_update_callback_param): Remove.
 140         (debug_reg_change_callback): Change type.
 141         (aarch64_notify_debug_reg_change): Update.
 142         * s390-linux-nat.c (s390_refresh_per_info): Update.
 143
 144 2019-03-11  Tom Tromey  <tromey@adacore.com>
 145
 146         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 147         redundant assignment to "this_cu".
 148
 149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 150
 151         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 152
 153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 154
 155         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 156         from...
 157         (rank_one_type): ... this.
 158
 159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 160
 161         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 162         from...
 163         (rank_one_type): ... this.
 164
 165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 166
 167         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 168         from...
 169         (rank_one_type): ... this.
 170
 171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 172
 173         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 174         from...
 175         (rank_one_type): ... this.
 176
 177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 178
 179         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 180         from...
 181         (rank_one_type): ... this.
 182
 183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 184
 185         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 186         from...
 187         (rank_one_type): ... this.
 188
 189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 190
 191         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 192         from...
 193         (rank_one_type): ... this.
 194
 195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 196
 197         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 198         from...
 199         (rank_one_type): ... this.
 200
 201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 202
 203         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 204         from...
 205         (rank_one_type): ... this.
 206
 207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 208
 209         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 210         from...
 211         (rank_one_type): ... this.
 212
 213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 214
 215         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 216         from...
 217         (rank_one_type): ... this.
 218
 219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 220
 221         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 222         from...
 223         (rank_one_type): ... this.
 224
 225 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 226
 227         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 228         inferior-events' shows the example events.
 229
 230 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 231
 232         Support styling on native MS-Windows console
 233
 234         PR/24315
 235         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 236         on MS-Windows if $TERM is not defined.
 237
 238         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 239
 240         * posix-hdep.c (gdb_console_fputs):
 241         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 242         functions.
 243         * ui-file.h (gdb_console_fputs): Add prototype.
 244
 245         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 246         back to fputs only if the former returns zero.
 247
 248 2019-03-07  Tom Tromey  <tom@tromey.com>
 249
 250         * symmisc.c (print_symbol_bcache_statistics): Update.
 251         (print_objfile_statistics): Update.
 252         * symfile.c (allocate_symtab): Update.
 253         * stabsread.c: Don't include bcache.h.
 254         * psymtab.h (struct psymbol_bcache): Don't declare.
 255         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 256         (psymbol_bcache_init, psymbol_bcache_free)
 257         (psymbol_bcache_get_bcache): Don't declare.
 258         * psymtab.c (struct psymbol_bcache): Remove.
 259         (psymtab_storage::psymtab_storage): Update.
 260         (psymtab_storage::~psymtab_storage): Update.
 261         (psymbol_bcache_init, psymbol_bcache_free)
 262         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 263         (add_psymbol_to_bcache): Update.
 264         (allocate_psymtab): Update.
 265         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 266         macro_cache>: No longer pointers.
 267         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 268         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 269         * macrotab.c (macro_bcache): Update.
 270         * macroexp.c: Don't include bcache.h.
 271         * gdbtypes.c (check_types_worklist): Update.
 272         (types_deeply_equal): Remove TRY/CATCH.  Update.
 273         * elfread.c (elf_symtab_read): Update.
 274         * dwarf2read.c: Don't include bcache.h.
 275         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 276         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 277         (print_bcache_statistics, bcache_memory_used): Don't declare.
 278         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 279         methods.  Rename all data members.
 280         * bcache.c (struct bcache): Move to bcache.h.
 281         (bcache::expand_hash_table): Rename from expand_hash_table.
 282         (bcache): Remove.
 283         (bcache::insert): Rename from bcache_full.
 284         (bcache::compare): Rename from bcache_compare.
 285         (bcache_xmalloc): Remove.
 286         (bcache::~bcache): Rename from bcache_xfree.
 287         (bcache::print_statistics): Rename from print_bcache_statistics.
 288         (bcache::memory_used): Rename from bcache_memory_used.
 289
 290 2019-03-07  Pedro Alves  <palves@redhat.com>
 291
 292         * infrun.c (normal_stop): Also check for
 293         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 294
 295 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 296
 297         * f-lang.c (value_from_host_double): Moved to...
 298         * value.c (value_from_host_double): ...here.
 299         * value.h (value_from_host_double): Declare.
 300         * guile/scm-math.c (vlscm_convert_typed_number): Use
 301         value_from_host_double.
 302         (vlscm_convert_number): Likewise.
 303         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 304         * python/py-value.c (convert_value_from_python): Likewise.
 305
 306 2019-03-06  Tom Tromey  <tom@tromey.com>
 307
 308         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 309
 310 2019-03-06  Tom Tromey  <tom@tromey.com>
 311
 312         * utils.h (free_current_contents): Don't declare.
 313         * utils.c (free_current_contents): Remove.
 314
 315 2019-03-06  Tom Tromey  <tom@tromey.com>
 316
 317         * top.c (quit_force): Update.
 318         * main.c (captured_command_loop): Update.
 319         * common/new-op.c (operator new): Update.
 320         * common/common-exceptions.c (struct catcher)
 321         <save_cleanup_chain>: Remove member.
 322         (exceptions_state_mc_init): Update.
 323         (exception_try_scope_entry): Return nullptr.
 324         (exception_try_scope_exit, exception_rethrow)
 325         (throw_exception_sjlj, throw_exception_cxx): Update.
 326         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 327         (all_cleanups, do_cleanups, discard_cleanups)
 328         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 329         (restore_cleanups, restore_final_cleanups): Don't declare.
 330         (do_final_cleanups): Remove parameter.
 331         * common/cleanups.c (cleanup_chain, make_cleanup)
 332         (make_cleanup_dtor, all_cleanups, do_cleanups)
 333         (discard_my_cleanups, discard_cleanups)
 334         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 335         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 336         (null_cleanup): Remove.
 337         (do_final_cleanups): Remove parameter.
 338
 339 2019-03-06  Tom Tromey  <tom@tromey.com>
 340
 341         * remote.c (remote_target::remote_parse_stop_reply): Use
 342         unique_xmalloc_ptr.
 343
 344 2019-03-06  Tom Tromey  <tom@tromey.com>
 345
 346         * stabsread.c (struct stabs_field_info): Rename from field_info.
 347         <list, fnlist>: Add initializers.
 348         <obstack>: New member.
 349         (read_member_functions, read_struct_fields, read_baseclasses):
 350         Allocate on obstack.  Don't use cleanups.
 351         (read_one_struct_field, read_member_functions, read_struct_fields)
 352         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 353         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 354         (read_struct_type): Update.
 355
 356 2019-03-06  Tom Tromey  <tom@tromey.com>
 357
 358         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 359         * common/filestuff.h (make_cleanup_close): Don't declare.
 360         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 361         Remove.
 362
 363 2019-03-06  Tom Tromey  <tom@tromey.com>
 364
 365         * solib-aix.c: Use make_scope_exit.
 366
 367 2019-03-06  Tom Tromey  <tom@tromey.com>
 368
 369         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 370         Use make_scope_exit.
 371
 372 2019-03-06  Tom Tromey  <tom@tromey.com>
 373
 374         * solib-svr4.c (disable_probes_interface): Remove parameter.
 375         (svr4_handle_solib_event): Use make_scope_exit.
 376
 377 2019-03-06  Tom Tromey  <tom@tromey.com>
 378
 379         * remote.c (struct stop_reply_deleter): Remove.
 380         (stop_reply_up): Update.
 381         (struct stop_reply): Derive from notif_event.  Don't typedef.
 382         <regcache>: Now a std::vector.
 383         (stop_reply_xfree): Remove.
 384         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 385         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 386         (remote_target::discard_pending_stop_replies): Use delete.
 387         (remote_target::remote_parse_stop_reply): Update.
 388         (remote_target::process_stop_reply): Update.
 389         * remote-notif.h (struct notif_event): Add virtual destructor.
 390         Remove "dtr" member.
 391         (struct notif_client) <alloc_event>: Return a unique_ptr.
 392         (notif_event_xfree): Don't declare.
 393         (notif_event_up): New typedef.
 394         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 395         (notif_event_xfree, do_notif_event_xfree): Remove.
 396         (remote_notif_state_xfree): Update.
 397
 398 2019-03-06  Tom Tromey  <tom@tromey.com>
 399
 400         * infrun.c (displaced_step_clear_cleanup): Now a
 401         forward_scope_exit type.
 402         (displaced_step_prepare_throw): Update.
 403         (displaced_step_fixup): Update.
 404
 405 2019-03-06  Tom Tromey  <tom@tromey.com>
 406
 407         * inferior.h (class inferior): Update comment.
 408         * gdbthread.h (class thread_info): Update comment.
 409
 410 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 411             Tom Tromey  <tom@tromey.com>
 412
 413         * stabsread.h (struct stab_section_list): Remove.
 414         (coffstab_build_psymtabs): Update.
 415         * dbxread.c (symbuf_sections): Now a std::vector.
 416         (sect_idx): New global.
 417         (fill_symbuf): Update.
 418         (coffstab_build_psymtabs): Change type of stabsects parameter.
 419         Update.
 420         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 421         std::vector.
 422         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 423         (coff_locate_sections): Update.
 424         (coff_symfile_read): Remove cleanups.  Update.
 425         (init_stringtab): Add storage parameter.
 426         (free_stringtab, free_stringtab_cleanup): Remove.
 427         (init_lineno): Add storage parameter.
 428         (free_linetab, free_linetab_cleanup): Remove.
 429
 430 2019-03-06  Pedro Alves  <palves@redhat.com>
 431
 432         * linux-fork.c (fork_info::clobber_regs): Delete.
 433         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 434         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 435         comment.  Adjust.
 436         (scoped_switch_fork_info::scoped_switch_fork_info)
 437         (checkpoint_command, linux_fork_context): Adjust
 438         fork_save_infrun_state calls.
 439
 440 2019-03-06  Pedro Alves  <palves@redhat.com>
 441
 442         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 443         (inf_has_multiple_threads): Return 'bool' and rewrite using
 444         inferior_info::threads().
 445
 446 2019-03-06  Pedro Alves  <palves@redhat.com>
 447
 448         * linux-fork.c: Include <list>.
 449         (fork_list): Now a std::list instance.
 450         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 451         (forks_exist_p, find_last_fork): Adjust.
 452         (new_fork): Delete.
 453         (one_fork_p): New.
 454         (add_fork): Adjust.
 455         (free_fork): Delete, folded into fork_info::~fork_info().
 456         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 457         Adjust.
 458         (init_fork_list): Delete.
 459         (linux_fork_killall, linux_fork_mourn_inferior)
 460         (linux_fork_detach, info_checkpoints_command): Adjust.
 461         (_initialize_linux_fork): No longer call init_fork_list.
 462
 463 2019-03-06  Pedro Alves  <palves@redhat.com>
 464
 465         * linux-fork.c (new_fork): New, split out of ...
 466         (add_fork): ... this.  Return void.  Move "first fork" special
 467         case from here, to ...
 468         (checkpoint_command): ... here.
 469         * linux-linux.h (add_fork): Return void.
 470
 471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 472
 473         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 474
 475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 476             Chris January  <chris.january@arm.com>
 477             David Lecomber  <david.lecomber@arm.com>
 478
 479         * f-exp.y: New token, UNOP_INTRINSIC.
 480         (exp): New pattern using UNOP_INTRINSIC token.
 481         (f77_keywords): Add 'abs' keyword.
 482         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 483         (value_from_host_double): New function.
 484         (evaluate_subexp_f): Support UNOP_ABS.
 485
 486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 487
 488         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 489         types.
 490
 491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 492
 493         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 494         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 495         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 496
 497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 500
 501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 502             Chris January  <chris.january@arm.com>
 503
 504         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 505         * f-exp.y: Define 'KIND' token.
 506         (exp): New pattern for KIND expressions.
 507         (ptype): Handle types with a kind extension.
 508         (direct_abs_decl): Extend to spot kind extensions.
 509         (f77_keywords): Add 'kind' to the list.
 510         (push_kind_type): New function.
 511         (convert_to_kind_type): New function.
 512         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 513         * parse.c (operator_length_standard): Likewise.
 514         * parser-defs.h (enum type_pieces): Add tp_kind.
 515         * std-operator.def: Add UNOP_KIND.
 516
 517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * f-exp.y (f_parse): Set yydebug.
 520
 521 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * f-lang.c (evaluate_subexp_f): New function.
 524         (exp_descriptor_f): New global.
 525         (f_language_defn): Use exp_descriptor_f instead of
 526         exp_descriptor_standard.
 527
 528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * f-exp.y (struct token): Add comments.
 531         (dot_ops): Remove uppercase versions and the end marker.
 532         (f77_keywords): Likewise.
 533         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 534         entries in the dot_ops array are case insensitive, and use
 535         strncasecmp to compare strings.  Also some whitespace cleanup in
 536         this area.  Similar for the f77_keywords array, except entries in
 537         this list might be case sensitive.
 538
 539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * f-exp.y (struct f77_boolean_val): Add comments.
 542         (boolean_values): Remove uppercase versions, and end marker.
 543         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 544         and use strncasecmp to achieve case insensitivity.  Additionally,
 545         perform whitespace cleanup around this code.
 546
 547 2019-03-06  Tom Tromey  <tromey@adacore.com>
 548
 549         * remote-sim.c (gdbsim_target_open): Use result of
 550         gdb_argv::release.
 551
 552 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 553         Dirk Schubert  <dirk.schubert@arm.com>
 554         Chris January  <chris.january@arm.com>
 555
 556         * eval.c (evaluate_subexp_standard): Call Fortran argument
 557         wrapping logic.
 558         * f-lang.c (struct value): A value which can be passed into a
 559         Fortran function call.
 560         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 561         where appropriate.
 562         (struct type): Value ready for a Fortran function call.
 563         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 564         is needed.
 565         * f-lang.h (fortran_argument_convert): Declaration.
 566         (fortran_preserve_arg_pointer): Declaration.
 567         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 568
 569 2019-03-05  Tom Tromey  <tromey@adacore.com>
 570
 571         * python/py-prettyprint.c (print_string_repr): Remove #if.
 572         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 573
 574 2019-03-05  Tom Tromey  <tromey@adacore.com>
 575
 576         * target.c (the_dummy_target): Move later.  Change type to
 577         "dummy_target".
 578         (initialize_targets): Don't initialize the_dummy_target.
 579
 580 2019-03-05  Tom Tromey  <tromey@adacore.com>
 581
 582         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 583         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 584
 585 2019-03-05  Tom Tromey  <tromey@adacore.com>
 586
 587         * windows-nat.c (windows_nat_target::attach)
 588         (windows_nat_target::detach): Don't call gdb_flush.
 589         * valprint.c (generic_val_print, val_print, val_print_string):
 590         Don't call gdb_flush.
 591         * utils.c (defaulted_query): Don't call gdb_flush.
 592         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 593         * target.c (target_announce_detach): Don't call gdb_flush.
 594         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 595         * remote.c (extended_remote_target::attach): Don't call
 596         gdb_flush.
 597         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 598         * printcmd.c (do_examine): Don't call gdb_flush.
 599         (info_display_command): Don't call gdb_flush.
 600         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 601         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 602         * memattr.c (info_mem_command): Don't call gdb_flush.
 603         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 604         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 605         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 606         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 607         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 608         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 609         (gnu_nat_target::detach): Don't call gdb_flush.
 610         * f-valprint.c (f_val_print): Don't call gdb_flush.
 611         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 612         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 613         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 614         gdb_flush.
 615         * c-valprint.c (c_val_print): Don't call gdb_flush.
 616         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 617
 618 2019-03-05  Tom Tromey  <tromey@adacore.com>
 619
 620         * varobj.c (update_dynamic_varobj_children): Update.
 621         (install_default_visualizer): Use reset, not release.
 622         * value.c (set_internalvar): Update.
 623         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 624         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 625         ATTRIBUTE_UNUSED_RESULT.
 626
 627 2019-03-05  Tom Tromey  <tromey@adacore.com>
 628
 629         * remote.c (class scoped_remote_fd) <release>: Add
 630         ATTRIBUTE_UNUSED_RESULT.
 631
 632 2019-03-05  Tom Tromey  <tromey@adacore.com>
 633
 634         * macroexp.c (struct macro_buffer) <release>: Add
 635         ATTRIBUTE_UNUSED_RESULT.
 636
 637 2019-03-05  Tom Tromey  <tromey@adacore.com>
 638
 639         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 640         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 641         ATTRIBUTE_UNUSED_RESULT.
 642
 643 2019-03-05  Tom Tromey  <tromey@adacore.com>
 644
 645         * common/scoped_fd.h (class scoped_fd) <release>: Add
 646         ATTRIBUTE_UNUSED_RESULT.
 647
 648 2019-03-05  Tom Tromey  <tromey@adacore.com>
 649
 650         * parser-defs.h (struct parser_state) <release>: Add
 651         ATTRIBUTE_UNUSED_RESULT.
 652
 653 2019-03-05  Tom Tromey  <tromey@adacore.com>
 654
 655         * utils.h (class gdb_argv) <release>: Add
 656         ATTRIBUTE_UNUSED_RESULT.
 657         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 658
 659 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 660
 661         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 662         for-loop range, to avoid compiler warnings.
 663
 664         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 665         avoid compiler warnings about unused variables.
 666
 667         * NEWS: Mention end of support for native debugging on MS-Windows
 668         before XP.
 669
 670         PR gdb/24292
 671         * common/netstuff.c:
 672         * gdbserver/gdbreplay.c
 673         * gdbserver/remote-utils.c:
 674         * ser-tcp.c:
 675         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 676         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 677         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 678         'getaddrinfo' and 'freeaddrinfo' were not available before
 679         Windows XP, and mingw.org's MinGW headers by default define
 680         _WIN32_WINNT to 0x500.
 681
 682 2019-03-01  Gary Benson <gbenson@redhat.com>
 683
 684         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 685
 686 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 687             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 688
 689         PR gdb/8527
 690         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 691         set_sigint_trap, clear_sigint_trap.
 692
 693 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 694
 695         * target.c (target_detach): Clear the regcache and the
 696         frame cache.
 697
 698 2019-02-27  Pedro Alves  <palves@redhat.com>
 699
 700         * utils.c (set_screen_size): When we cap the height/width sizes,
 701         tweak the corresponding command variable to show "unlimited":
 702
 703 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 704             Pedro Alves  <palves@redhat.com>
 705
 706         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 707         before calling rl_set_screen_size.
 708
 709 2019-02-27  Tom Tromey  <tromey@adacore.com>
 710
 711         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 712         define.
 713         * python/py-value.c: Remove Python 2.4 workaround.
 714         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 715         workaround.
 716         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 717         Python 2.4 workaround.
 718         * python/python-internal.h: Remove Python 2.4 comment.
 719         (Py_ssize_t): Don't define.
 720         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 721         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 722         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 723         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 724         * python/python.c (do_start_initialization): Remove Python 2.4
 725         workaround.
 726         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 727         (print_children): Remove Python 2.4 workaround.
 728         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 729         workaround.
 730         (CHARBUFFERPROC_NAME): Remove.
 731         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 732         Python 2.4 workaround.
 733
 734 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 735
 736         * NEWS: Note minimum Python version.
 737
 738 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 739
 740         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 741         code from these functions.  Remove corresponding ifdefs.  Use
 742         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 743         Remove gotos and target of gotos.
 744         (infpy_search_memory): Likewise.
 745
 746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 749         (hppa_gdbarch_init): Don't register deleted functions with
 750         gdbarch.
 751
 752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 755         (h8300_unwind_sp): Delete.
 756         (h8300_dummy_id): Delete.
 757         (h8300_gdbarch_init): Don't register deleted functions with
 758         gdbarch.
 759
 760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 763         (ft32_unwind_pc): Delete.
 764         (ft32_unwind_sp): Delete.
 765         (ft32_gdbarch_init): Don't register deleted functions with
 766         gdbarch.
 767
 768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 769
 770         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 771         (frv_unwind_pc): Delete.
 772         (frv_unwind_sp): Delete.
 773         (frv_gdbarch_init): Don't register deleted functions with
 774         gdbarch.
 775
 776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 779         (riscv_unwind_pc): Delete.
 780         (riscv_unwind_sp): Delete.
 781         (riscv_gdbarch_init): Don't register deleted functions with
 782         gdbarch.
 783
 784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 787         (csky_unwind_pc): Delete.
 788         (csky_unwind_sp): Delete.
 789         (csky_gdbarch_init): Don't register deleted functions with
 790         gdbarch.
 791
 792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 795         (cris_unwind_pc): Delete.
 796         (cris_unwind_sp): Delete.
 797         (cris_gdbarch_init): Don't register deleted functions with
 798         gdbarch.
 799
 800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 803         (bfin_unwind_pc): Delete.
 804         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 805
 806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 809         (arm_unwind_pc): Delete.
 810         (arm_unwind_sp): Delete.
 811         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 812
 813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 816         (arc_unwind_pc): Delete.
 817         (arc_unwind_sp): Delete.
 818         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 819
 820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 821
 822         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 823         (alpha_unwind_pc): Delete.
 824         (alpha_gdbarch_init): Don't register deleted functions with
 825         gdbarch.
 826
 827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 830         (aarch64_unwind_pc): Delete.
 831         (aarch64_unwind_sp): Delete.
 832         (aarch64_gdbarch_init): Don't register deleted functions with
 833         gdbarch.
 834
 835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * gdbtypes.c (type_align): Don't consider static members when
 838         computing structure alignment.
 839
 840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 843         return 0 for other types.
 844         * arch-utils.c (default_type_align): Always return 0.
 845         * gdbarch.h: Regenerate.
 846         * gdbarch.sh (type_align): Extend comment.
 847         * gdbtypes.c (type_align): Add additional comments, always call
 848         gdbarch_type_align before applying the default rules.
 849         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 850         generic code will then apply a suitable default.
 851         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 852         types, return 0 for other types.
 853
 854 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 855
 856         * NEWS: Create a new section for the next release branch.
 857         Rename the section of the current branch, now that it has
 858         been cut.
 859
 860 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 861
 862         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 863         * version.in: Bump version to 8.3.50.DATE-git.
 864
 865 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 866
 867         * aix-thread.c (ptid_cmp): Remove unused variable.
 868         (get_signaled_thread): Likewise.
 869         (store_regs_user_thread): Likewise.
 870         (store_regs_kernel_thread): Likewise.
 871         (fetch_regs_kernel_thread): Remove shadowed variable.
 872
 873 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * features/riscv/32bit-cpu.xml: Add register numbers.
 876         * features/riscv/32bit-fpu.c: Regenerate.
 877         * features/riscv/32bit-fpu.xml: Add register numbers.
 878         * features/riscv/64bit-cpu.xml: Add register numbers.
 879         * features/riscv/64bit-fpu.c: Regenerate.
 880         * features/riscv/64bit-fpu.xml: Add register numbers.
 881
 882 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 883
 884         * NEWS: Mention two argument form of gdb.Value constructor.
 885         * python/py-value.c (convert_buffer_and_type_to_value): New
 886         function.
 887         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 888         Add support for handling an optional second argument.  Call
 889         convert_buffer_and_type_to_value as appropriate.
 890         * python/python-internal.h (Py_buffer_deleter): New struct.
 891         (Py_buffer_up): New typedef.
 892
 893 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 894
 895         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 896         instead of releasing ownership.
 897
 898 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 899
 900         * dwarf2read.c (open_and_init_dwp_file): Call
 901         elf_numsections instead of bfd_count_sections to initialize
 902         dwp_file->num_sections.
 903
 904 2019-02-25  Tom Tromey  <tromey@adacore.com>
 905
 906         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 907
 908 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 909
 910         * gcore.in: Add '--readnever' option when invoking GDB.
 911
 912 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 913
 914         * MAINTAINERS: Update my email address.
 915
 916 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 917
 918         * build-id.c (build_id_to_debug_bfd_1): New function.
 919         (build_id_to_debug_bfd): Look for separate debug file in
 920         sysroot.
 921
 922 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * gdbarch.sh: Update the copyright year range that is placed into
 925         generated files.
 926
 927 2019-02-22  Keith Seitz  <keiths@redhat.com>
 928
 929         PR symtab/23853
 930         * linespec.c (create_sals_line_offset): Search for the default
 931         symtab's filename instead of its fullname.
 932
 933 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 934
 935         * NEWS: Update style defaults.
 936
 937 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 938
 939         * main.c (captured_main_1): Disable styling in batch mode.
 940
 941 2019-02-20  Tom Tromey  <tom@tromey.com>
 942
 943         * symtab.c (symtab_symbol_info): Fix typos.
 944
 945 2019-02-20  Tom Tromey  <tromey@adacore.com>
 946
 947         * findcmd.c (_initialize_mem_search): Use upper case for
 948         metasyntactic variables.
 949
 950 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 951
 952         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 953         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 954
 955 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 956
 957         * top.h (source_file_name): Change to std::string.
 958         * top.c (source_file_name): Likewise.
 959         (command_line_input): Adjust.
 960         * cli/cli-script.c (script_from_file): Adjust.
 961
 962 2019-02-19  Tom Tromey  <tromey@adacore.com>
 963
 964         * ravenscar-thread.c
 965         (ravenscar_thread_target::update_thread_list): Don't call
 966         ada_build_task_list.
 967         * ada-lang.h (ada_build_task_list): Don't declare.
 968         * ada-tasks.c (struct ada_tasks_inferior_data)
 969         <task_list_valid_p>: Now bool.
 970         (read_known_tasks, ada_task_list_changed)
 971         (ada_tasks_invalidate_inferior_data): Update.
 972         (read_known_tasks_array): Return bool.
 973         (read_known_tasks_list): Likewise.
 974         (read_known_tasks): Return void.
 975         (ada_build_task_list): Now static.
 976
 977 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 980         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 981
 982 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 983
 984         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 985         variant for ada_tasks_pspace_data_handle and
 986         ada_tasks_inferior_data_handle.
 987         (ada_tasks_pspace_data_cleanup): New function.
 988         (ada_tasks_inferior_data_cleanup): New function.
 989
 990 2019-02-17  Tom Tromey  <tom@tromey.com>
 991
 992         * macrotab.h (macro_source_fullname): Return a std::string.
 993         * macrotab.c (macro_include, check_for_redefinition)
 994         (macro_undef, macro_lookup_definition, foreach_macro)
 995         (foreach_macro_in_scope): Update.
 996         (macro_source_fullname): Return a std::string.
 997         * macrocmd.c (show_pp_source_pos): Update.
 998
 999 2019-02-17  Tom Tromey  <tom@tromey.com>
1000
1001         * macrocmd.c (show_pp_source_pos): Style the file names.
1002
1003 2019-02-17  Tom Tromey  <tom@tromey.com>
1004
1005         PR tui/24197:
1006         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1007
1008 2019-02-17  Tom Tromey  <tom@tromey.com>
1009
1010         * ada-lang.c (user_select_syms): Use filtered printing.
1011         * utils.c (wrap_style): New global.
1012         (desired_style): Remove.
1013         (emit_style_escape): Add stream parameter.
1014         (set_output_style, reset_terminal_style, prompt_for_continue):
1015         Update.
1016         (flush_wrap_buffer): Only flush gdb_stdout.
1017         (wrap_here): Set wrap_style.
1018         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1019         treat escape sequences as a character.  Change when wrap buffer is
1020         flushed.
1021         (fputs_styled): Do not set the output style when the default is
1022         requested.
1023         * ui-style.h (struct ui_file_style) <is_default>: New method.
1024         * source.c (print_source_lines_base): Emit escape sequences in one
1025         piece.
1026
1027 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1028
1029         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1030         integers and enumeration types.
1031
1032 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1033
1034         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1035         instead of lookup_symbol_in_language
1036         (do_exact_match): New function.
1037         (ada_get_symbol_name_matcher): Return do_exact_match when
1038         doing a verbatim match.
1039
1040 2019-02-15  Tom Tromey  <tromey@adacore.com>
1041
1042         * ravenscar-thread.c (ravenscar_thread_target::resume)
1043         (ravenscar_thread_target::wait): Special case wildcard requests.
1044
1045 2019-02-15  Tom Tromey  <tromey@adacore.com>
1046
1047         * ravenscar-thread.c (base_ptid): Remove.
1048         (struct ravenscar_thread_target) <close>: New method.
1049         <m_base_ptid>: New member.
1050         <update_inferior_ptid, active_task, task_is_currently_active,
1051         runtime_initialized>: Declare methods.
1052         <ravenscar_thread_target>: Add constructor.
1053         (ravenscar_thread_target::task_is_currently_active)
1054         (ravenscar_thread_target::update_inferior_ptid)
1055         (ravenscar_runtime_initialized): Rename.  Now methods.
1056         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1057         (ravenscar_thread_target::update_thread_list): Update.
1058         (ravenscar_thread_target::active_task): Now method.
1059         (ravenscar_thread_target::store_registers)
1060         (ravenscar_thread_target::prepare_to_store)
1061         (ravenscar_thread_target::prepare_to_store)
1062         (ravenscar_thread_target::mourn_inferior): Update.
1063         (ravenscar_inferior_created): Use "new" to create target.
1064         (ravenscar_thread_target::get_ada_task_ptid): Update.
1065         (_initialize_ravenscar): Don't initialize base_ptid.
1066         (ravenscar_ops): Remove global.
1067
1068 2019-02-15  Tom Tromey  <tromey@adacore.com>
1069
1070         * target.h (push_target): Declare new overload.
1071         * target.c (push_target): New overload, taking an rvalue reference.
1072         * remote.c (remote_target::open_1): Use push_target overload.
1073         * corelow.c (core_target_open): Use push_target overload.
1074
1075 2019-02-15  Tom Tromey  <tromey@adacore.com>
1076
1077         * ravenscar-thread.c (is_ravenscar_task)
1078         (ravenscar_task_is_currently_active): Return bool.
1079         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1080         (_initialize_ravenscar): Remove "(void)".
1081         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1082         Return bool.
1083
1084 2019-02-15  Tom Tromey  <tromey@adacore.com>
1085
1086         * ravenscar-thread.c (ravenscar_runtime_initializer)
1087         (has_ravenscar_runtime, get_running_thread_id)
1088         (ravenscar_thread_target::resume): Fix indentation.
1089
1090 2019-02-15  Tom Tromey  <tromey@adacore.com>
1091
1092         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1093         from ravenscar_arch_ops.
1094         (sparc_ravenscar_ops::fetch_registers)
1095         (sparc_ravenscar_ops::store_registers): Now methods.
1096         (sparc_ravenscar_prepare_to_store): Remove.
1097         (sparc_ravenscar_ops): Redefine.
1098         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1099         methods and destructor.  Remove members.
1100         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1101         (ravenscar_thread_target::store_registers)
1102         (ravenscar_thread_target::prepare_to_store): Update.
1103         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1104         Remove.
1105         (struct ppc_ravenscar_powerpc_ops): Derive from
1106         ravenscar_arch_ops.
1107         (ppc_ravenscar_powerpc_ops::fetch_registers)
1108         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1109         (ppc_ravenscar_powerpc_ops): Redefine.
1110         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1111         (ppc_ravenscar_e500_ops::fetch_registers)
1112         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1113         (ppc_ravenscar_e500_ops): Redefine.
1114         * aarch64-ravenscar-thread.c
1115         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1116         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1117         (aarch64_ravenscar_fetch_registers)
1118         (aarch64_ravenscar_store_registers): Now methods.
1119         (aarch64_ravenscar_ops): Redefine.
1120
1121 2019-02-15  Tom Tromey  <tromey@adacore.com>
1122
1123         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1124         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1125         (ravenscar_thread_target::stopped_by_watchpoint)
1126         (ravenscar_thread_target::stopped_data_address)
1127         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1128
1129 2019-02-15  Tom Tromey  <tromey@adacore.com>
1130
1131         * ravenscar-thread.c: Fix some typos.
1132
1133 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1134             Tom Tromey  <tromey@adacore.com>
1135
1136         * ada-lang.c (ada_exception_sal): Change addr_string to a
1137         std::string.
1138         (create_ada_exception_catchpoint): Update.
1139
1140 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1141             Tom Tromey  <tromey@adacore.com>
1142
1143         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1144         (bp_location_ops): Remove.
1145         (base_breakpoint_allocate_location): Update.
1146         (free_bp_location): Update.
1147         * ada-lang.c (class ada_catchpoint_location)
1148         <ada_catchpoint_location>: Remove ops parameter.
1149         (ada_catchpoint_location_dtor): Remove.
1150         (ada_catchpoint_location_ops): Remove.
1151         (allocate_location_exception): Update.
1152         * breakpoint.h (struct bp_location_ops): Remove.
1153         (class bp_location) <bp_location>: Remove bp_location_ops
1154         parameter.
1155         <~bp_location>: Add destructor.
1156         <ops>: Remove.
1157
1158 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1159             Pedro Alves  <palves@redhat.com>
1160
1161         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1162         'PATH_MAX'.
1163
1164 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1165             Samuel Thibault  <samuel.thibault@gnu.org>
1166             Thomas Schwinge  <thomas@codesourcery.com>
1167
1168         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1169         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1170
1171 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1172
1173         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1174         (check_empty): Use "const char *".
1175
1176         * gnu-nat.c (gnu_nat_target::detach): Instead of
1177         'detach_inferior (pid)' call
1178         'detach_inferior (find_inferior_pid (pid))'.
1179
1180         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1181         'nat/fork-inferior.o'.
1182         * gnu-nat.c: #include "nat/fork-inferior.h".
1183
1184         * gnu-nat.c (gnu_nat_target::detach): Instead of
1185         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1186         * gnu-nat.h: #include "inf-child.h".
1187         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1188         'i386_gnu_nat_target::fetch_registers'.
1189         (gnu_store_registers): Rename/move to
1190         'i386_gnu_nat_target::store_registers'.
1191
1192         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1193         * gnu-nat.h (mach_thread_info): New function.
1194         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1195
1196         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1197
1198 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1199
1200         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1201
1202 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1203
1204         * windows-nat.c (windows_add_thread): Add new parameter
1205         "main_thread_p" with default value set to false.  Update
1206         function documentation as well as all callers.
1207         (windows_delete_thread): Likewise.
1208         (fake_create_process): Update call to windows_add_thread.
1209         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1210         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1211         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1212         call to windows_delete_thread.
1213
1214 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1215
1216         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1217
1218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1219
1220         * symfile.c (find_separate_debug_file): Use canonical path of
1221         sysroot with child_path instead of gdb_sysroot if it is valid.
1222
1223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1224
1225         * symfile.c (find_separate_debug_file): Use child_path to
1226         determine if an object file is under a sysroot.
1227
1228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1229
1230         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1231         unittests/child-path-selftests.c.
1232         * common/pathstuff.c (child_path): New function.
1233         * common/pathstuff.h (child_path): New prototype.
1234         * unittests/child-path-selftests.c: New file.
1235
1236 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1237
1238         * symfile.c (find_separate_debug_file): Look for separate debug
1239         files in debug directories under the sysroot.
1240
1241 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1242
1243         * symtab.h (struct minimal_symbol data_p): New const method.
1244         (struct minimal_symbol text_p): Likewise.
1245         * symtab.c (output_source_filename): Use file name style
1246         to print file name.
1247         (print_symbol_info): Likewise.
1248         (print_msymbol_info): Use address style to print addresses.
1249         Use function name style to print executable text symbols.
1250         (expand_symtab_containing_pc): Use data_p.
1251         (find_pc_sect_compunit_symtab): Likewise.
1252
1253 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * breakpoint.c (describe_other_breakpoints): Use address style
1256         to print addresses.
1257         (say_where): Likewise.
1258
1259 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260
1261         * ada-typeprint.c (print_func_type): Print function name
1262         style to print function name.
1263         * c-typeprint.c (c_print_type_1): Likewise.
1264
1265 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1266
1267         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1268         for execve.
1269
1270 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1271
1272         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1273         type_stack.
1274
1275 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1276
1277         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1278         TYPE_CODE_REF types.
1279
1280 2019-02-08  Jim Wilson  <jimw@sifive.com>
1281
1282         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1283         (riscv_linux_fregset): New.
1284         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1285
1286 2019-02-07  Tom Tromey  <tom@tromey.com>
1287
1288         * thread.c (thread_cancel_execution_command): Update.
1289         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1290         methods.
1291         (struct thread_fsm_ops): Remove.
1292         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1293         (thread_fsm_should_stop, thread_fsm_return_value)
1294         (thread_fsm_set_finished, thread_fsm_finished_p)
1295         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1296         Don't declare.
1297         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1298         * infrun.c (clear_proceed_status_thread)
1299         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1300         (print_stop_event): Update.
1301         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1302         Add constructor.
1303         (step_command_fsm_ops): Remove.
1304         (new_step_command_fsm): Remove.
1305         (step_1): Update.
1306         (step_command_fsm::should_stop): Rename from
1307         step_command_fsm_should_stop.
1308         (step_command_fsm::clean_up): Rename from
1309         step_command_fsm_clean_up.
1310         (step_command_fsm::do_async_reply_reason): Rename from
1311         step_command_fsm_async_reply_reason.
1312         (struct until_next_fsm): Inherit from thread_fsm.  Add
1313         constructor.
1314         (until_next_fsm_ops): Remove.
1315         (new_until_next_fsm): Remove.
1316         (until_next_fsm::should_stop): Rename from
1317         until_next_fsm_should_stop.
1318         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1319         (until_next_fsm::do_async_reply_reason): Rename from
1320         until_next_fsm_async_reply_reason.
1321         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1322         constructor.  Change type of breakpoint.
1323         (finish_command_fsm_ops): Remove.
1324         (new_finish_command_fsm): Remove.
1325         (finish_command_fsm::should_stop): Rename from
1326         finish_command_fsm_should_stop.
1327         (finish_command_fsm::clean_up): Rename from
1328         finish_command_fsm_clean_up.
1329         (finish_command_fsm::return_value): Rename from
1330         finish_command_fsm_return_value.
1331         (finish_command_fsm::do_async_reply_reason): Rename from
1332         finish_command_fsm_async_reply_reason.
1333         (finish_command): Update.
1334         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1335         Add constructor.
1336         (call_thread_fsm_ops): Remove.
1337         (call_thread_fsm::call_thread_fsm): Rename from
1338         new_call_thread_fsm.
1339         (call_thread_fsm::should_stop): Rename from
1340         call_thread_fsm_should_stop.
1341         (call_thread_fsm::should_notify_stop): Rename from
1342         call_thread_fsm_should_notify_stop.
1343         (run_inferior_call, call_function_by_hand_dummy): Update.
1344         * cli/cli-interp.c (should_print_stop_to_console): Update.
1345         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1346         Add constructor.  Change type of location_breakpoint,
1347         caller_breakpoint.
1348         (until_break_fsm_ops): Remove.
1349         (new_until_break_fsm): Remove.
1350         (until_break_fsm::should_stop): Rename from
1351         until_break_fsm_should_stop.
1352         (until_break_fsm::clean_up): Rename from
1353         until_break_fsm_clean_up.
1354         (until_break_fsm::do_async_reply_reason): Rename from
1355         until_break_fsm_async_reply_reason.
1356         (until_break_command): Update.
1357         * thread-fsm.c: Remove.
1358         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1359
1360 2019-02-07  Tom Tromey  <tom@tromey.com>
1361
1362         * yy-remap.h: Add include guard.
1363         * xtensa-tdep.h: Add include guard.
1364         * xcoffread.h: Rename include guard.
1365         * varobj-iter.h: Add include guard.
1366         * tui/tui.h: Rename include guard.
1367         * tui/tui-winsource.h: Rename include guard.
1368         * tui/tui-wingeneral.h: Rename include guard.
1369         * tui/tui-windata.h: Rename include guard.
1370         * tui/tui-win.h: Rename include guard.
1371         * tui/tui-stack.h: Rename include guard.
1372         * tui/tui-source.h: Rename include guard.
1373         * tui/tui-regs.h: Rename include guard.
1374         * tui/tui-out.h: Rename include guard.
1375         * tui/tui-layout.h: Rename include guard.
1376         * tui/tui-io.h: Rename include guard.
1377         * tui/tui-hooks.h: Rename include guard.
1378         * tui/tui-file.h: Rename include guard.
1379         * tui/tui-disasm.h: Rename include guard.
1380         * tui/tui-data.h: Rename include guard.
1381         * tui/tui-command.h: Rename include guard.
1382         * tic6x-tdep.h: Add include guard.
1383         * target/waitstatus.h: Rename include guard.
1384         * target/wait.h: Rename include guard.
1385         * target/target.h: Rename include guard.
1386         * target/resume.h: Rename include guard.
1387         * target-float.h: Rename include guard.
1388         * stabsread.h: Add include guard.
1389         * rs6000-tdep.h: Add include guard.
1390         * riscv-fbsd-tdep.h: Add include guard.
1391         * regformats/regdef.h: Rename include guard.
1392         * record.h: Rename include guard.
1393         * python/python.h: Rename include guard.
1394         * python/python-internal.h: Rename include guard.
1395         * python/py-stopevent.h: Rename include guard.
1396         * python/py-ref.h: Rename include guard.
1397         * python/py-record.h: Rename include guard.
1398         * python/py-record-full.h: Rename include guard.
1399         * python/py-record-btrace.h: Rename include guard.
1400         * python/py-instruction.h: Rename include guard.
1401         * python/py-events.h: Rename include guard.
1402         * python/py-event.h: Rename include guard.
1403         * procfs.h: Add include guard.
1404         * proc-utils.h: Add include guard.
1405         * p-lang.h: Add include guard.
1406         * or1k-tdep.h: Rename include guard.
1407         * observable.h: Rename include guard.
1408         * nto-tdep.h: Rename include guard.
1409         * nat/x86-linux.h: Rename include guard.
1410         * nat/x86-linux-dregs.h: Rename include guard.
1411         * nat/x86-gcc-cpuid.h: Add include guard.
1412         * nat/x86-dregs.h: Rename include guard.
1413         * nat/x86-cpuid.h: Rename include guard.
1414         * nat/ppc-linux.h: Rename include guard.
1415         * nat/mips-linux-watch.h: Rename include guard.
1416         * nat/linux-waitpid.h: Rename include guard.
1417         * nat/linux-ptrace.h: Rename include guard.
1418         * nat/linux-procfs.h: Rename include guard.
1419         * nat/linux-osdata.h: Rename include guard.
1420         * nat/linux-nat.h: Rename include guard.
1421         * nat/linux-namespaces.h: Rename include guard.
1422         * nat/linux-btrace.h: Rename include guard.
1423         * nat/glibc_thread_db.h: Rename include guard.
1424         * nat/gdb_thread_db.h: Rename include guard.
1425         * nat/gdb_ptrace.h: Rename include guard.
1426         * nat/fork-inferior.h: Rename include guard.
1427         * nat/amd64-linux-siginfo.h: Rename include guard.
1428         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1429         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1430         * nat/aarch64-linux.h: Rename include guard.
1431         * nat/aarch64-linux-hw-point.h: Rename include guard.
1432         * mn10300-tdep.h: Add include guard.
1433         * mips-linux-tdep.h: Add include guard.
1434         * mi/mi-parse.h: Rename include guard.
1435         * mi/mi-out.h: Rename include guard.
1436         * mi/mi-main.h: Rename include guard.
1437         * mi/mi-interp.h: Rename include guard.
1438         * mi/mi-getopt.h: Rename include guard.
1439         * mi/mi-console.h: Rename include guard.
1440         * mi/mi-common.h: Rename include guard.
1441         * mi/mi-cmds.h: Rename include guard.
1442         * mi/mi-cmd-break.h: Rename include guard.
1443         * m2-lang.h: Add include guard.
1444         * location.h: Rename include guard.
1445         * linux-record.h: Rename include guard.
1446         * linux-nat.h: Add include guard.
1447         * linux-fork.h: Add include guard.
1448         * i386-darwin-tdep.h: Rename include guard.
1449         * hppa-linux-offsets.h: Add include guard.
1450         * guile/guile.h: Rename include guard.
1451         * guile/guile-internal.h: Rename include guard.
1452         * gnu-nat.h: Rename include guard.
1453         * gdb-stabs.h: Rename include guard.
1454         * frv-tdep.h: Add include guard.
1455         * f-lang.h: Add include guard.
1456         * event-loop.h: Add include guard.
1457         * darwin-nat.h: Rename include guard.
1458         * cp-abi.h: Rename include guard.
1459         * config/sparc/nm-sol2.h: Rename include guard.
1460         * config/nm-nto.h: Rename include guard.
1461         * config/nm-linux.h: Add include guard.
1462         * config/i386/nm-i386gnu.h: Rename include guard.
1463         * config/djgpp/nl_types.h: Rename include guard.
1464         * config/djgpp/langinfo.h: Rename include guard.
1465         * compile/gcc-cp-plugin.h: Add include guard.
1466         * compile/gcc-c-plugin.h: Add include guard.
1467         * compile/compile.h: Rename include guard.
1468         * compile/compile-object-run.h: Rename include guard.
1469         * compile/compile-object-load.h: Rename include guard.
1470         * compile/compile-internal.h: Rename include guard.
1471         * compile/compile-cplus.h: Rename include guard.
1472         * compile/compile-c.h: Rename include guard.
1473         * common/xml-utils.h: Rename include guard.
1474         * common/x86-xstate.h: Rename include guard.
1475         * common/version.h: Rename include guard.
1476         * common/vec.h: Rename include guard.
1477         * common/tdesc.h: Rename include guard.
1478         * common/selftest.h: Rename include guard.
1479         * common/scoped_restore.h: Rename include guard.
1480         * common/scoped_mmap.h: Rename include guard.
1481         * common/scoped_fd.h: Rename include guard.
1482         * common/safe-iterator.h: Rename include guard.
1483         * common/run-time-clock.h: Rename include guard.
1484         * common/refcounted-object.h: Rename include guard.
1485         * common/queue.h: Rename include guard.
1486         * common/ptid.h: Rename include guard.
1487         * common/print-utils.h: Rename include guard.
1488         * common/preprocessor.h: Rename include guard.
1489         * common/pathstuff.h: Rename include guard.
1490         * common/observable.h: Rename include guard.
1491         * common/netstuff.h: Rename include guard.
1492         * common/job-control.h: Rename include guard.
1493         * common/host-defs.h: Rename include guard.
1494         * common/gdb_wait.h: Rename include guard.
1495         * common/gdb_vecs.h: Rename include guard.
1496         * common/gdb_unlinker.h: Rename include guard.
1497         * common/gdb_unique_ptr.h: Rename include guard.
1498         * common/gdb_tilde_expand.h: Rename include guard.
1499         * common/gdb_sys_time.h: Rename include guard.
1500         * common/gdb_string_view.h: Rename include guard.
1501         * common/gdb_splay_tree.h: Rename include guard.
1502         * common/gdb_setjmp.h: Rename include guard.
1503         * common/gdb_ref_ptr.h: Rename include guard.
1504         * common/gdb_optional.h: Rename include guard.
1505         * common/gdb_locale.h: Rename include guard.
1506         * common/gdb_assert.h: Rename include guard.
1507         * common/filtered-iterator.h: Rename include guard.
1508         * common/filestuff.h: Rename include guard.
1509         * common/fileio.h: Rename include guard.
1510         * common/environ.h: Rename include guard.
1511         * common/common-utils.h: Rename include guard.
1512         * common/common-types.h: Rename include guard.
1513         * common/common-regcache.h: Rename include guard.
1514         * common/common-inferior.h: Rename include guard.
1515         * common/common-gdbthread.h: Rename include guard.
1516         * common/common-exceptions.h: Rename include guard.
1517         * common/common-defs.h: Rename include guard.
1518         * common/common-debug.h: Rename include guard.
1519         * common/cleanups.h: Rename include guard.
1520         * common/buffer.h: Rename include guard.
1521         * common/btrace-common.h: Rename include guard.
1522         * common/break-common.h: Rename include guard.
1523         * cli/cli-utils.h: Rename include guard.
1524         * cli/cli-style.h: Rename include guard.
1525         * cli/cli-setshow.h: Rename include guard.
1526         * cli/cli-script.h: Rename include guard.
1527         * cli/cli-interp.h: Rename include guard.
1528         * cli/cli-decode.h: Rename include guard.
1529         * cli/cli-cmds.h: Rename include guard.
1530         * charset-list.h: Add include guard.
1531         * buildsym-legacy.h: Rename include guard.
1532         * bfin-tdep.h: Add include guard.
1533         * ax.h: Rename include guard.
1534         * arm-linux-tdep.h: Add include guard.
1535         * arm-fbsd-tdep.h: Add include guard.
1536         * arch/xtensa.h: Rename include guard.
1537         * arch/tic6x.h: Add include guard.
1538         * arch/i386.h: Add include guard.
1539         * arch/arm.h: Rename include guard.
1540         * arch/arm-linux.h: Rename include guard.
1541         * arch/arm-get-next-pcs.h: Rename include guard.
1542         * arch/amd64.h: Add include guard.
1543         * arch/aarch64-insn.h: Rename include guard.
1544         * arch-utils.h: Rename include guard.
1545         * annotate.h: Add include guard.
1546         * amd64-darwin-tdep.h: Rename include guard.
1547         * aarch64-linux-tdep.h: Add include guard.
1548         * aarch64-fbsd-tdep.h: Add include guard.
1549         * aarch32-linux-nat.h: Add include guard.
1550
1551 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1552
1553         * macrotab.c (macro_define_internal): New function that
1554         factorizes macro_define_object_internal and macro_define_function
1555         code.
1556         (macro_define_object_internal): Use macro_define_internal.
1557         (macro_define_function): Likewise.
1558
1559 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1560
1561         * macrocmd.c (extract_identifier): Return
1562         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1563         callers.
1564
1565 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1566
1567         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1568
1569 2019-02-05  Tom Tromey  <tom@tromey.com>
1570
1571         * target.c (target_stack::unpush): Move assertion earlier.
1572
1573 2019-01-30  Tom Tromey  <tom@tromey.com>
1574
1575         PR python/23615:
1576         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1577         (gdbpy_parse_and_eval): Likewise.
1578         * python/python-internal.h (gdbpy_allow_threads): New class.
1579
1580 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1581
1582         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1583         (aarch64_fbsd_fpregmap): Move earlier.
1584         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1585         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1586         instead of individual calls to trad_frame_set_reg_addr.
1587         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1588         earlier.
1589         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1590         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1591         instead of individual calls to trad_frame_set_reg_addr.
1592
1593 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1594
1595         * CONTRIBUTE: Replace contribution list with wiki link.
1596
1597 2019-01-25  Tom Tromey  <tom@tromey.com>
1598
1599         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1600
1601 2019-01-25  Tom Tromey  <tom@tromey.com>
1602
1603         * xtensa-linux-nat.c: Fix common/ includes.
1604         * xml-support.h: Fix common/ includes.
1605         * xml-support.c: Fix common/ includes.
1606         * x86-linux-nat.c: Fix common/ includes.
1607         * windows-nat.c: Fix common/ includes.
1608         * varobj.h: Fix common/ includes.
1609         * varobj.c: Fix common/ includes.
1610         * value.c: Fix common/ includes.
1611         * valops.c: Fix common/ includes.
1612         * utils.c: Fix common/ includes.
1613         * unittests/xml-utils-selftests.c: Fix common/ includes.
1614         * unittests/utils-selftests.c: Fix common/ includes.
1615         * unittests/unpack-selftests.c: Fix common/ includes.
1616         * unittests/tracepoint-selftests.c: Fix common/ includes.
1617         * unittests/style-selftests.c: Fix common/ includes.
1618         * unittests/string_view-selftests.c: Fix common/ includes.
1619         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1620         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1621         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1622         * unittests/rsp-low-selftests.c: Fix common/ includes.
1623         * unittests/parse-connection-spec-selftests.c: Fix common/
1624         includes.
1625         * unittests/optional-selftests.c: Fix common/ includes.
1626         * unittests/offset-type-selftests.c: Fix common/ includes.
1627         * unittests/observable-selftests.c: Fix common/ includes.
1628         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1629         * unittests/memrange-selftests.c: Fix common/ includes.
1630         * unittests/memory-map-selftests.c: Fix common/ includes.
1631         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1632         * unittests/function-view-selftests.c: Fix common/ includes.
1633         * unittests/environ-selftests.c: Fix common/ includes.
1634         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1635         * unittests/common-utils-selftests.c: Fix common/ includes.
1636         * unittests/cli-utils-selftests.c: Fix common/ includes.
1637         * unittests/array-view-selftests.c: Fix common/ includes.
1638         * ui-file.c: Fix common/ includes.
1639         * tui/tui-io.c: Fix common/ includes.
1640         * tracepoint.h: Fix common/ includes.
1641         * tracepoint.c: Fix common/ includes.
1642         * tracefile-tfile.c: Fix common/ includes.
1643         * top.h: Fix common/ includes.
1644         * top.c: Fix common/ includes.
1645         * thread.c: Fix common/ includes.
1646         * target/waitstatus.h: Fix common/ includes.
1647         * target/waitstatus.c: Fix common/ includes.
1648         * target.h: Fix common/ includes.
1649         * target.c: Fix common/ includes.
1650         * target-memory.c: Fix common/ includes.
1651         * target-descriptions.c: Fix common/ includes.
1652         * symtab.h: Fix common/ includes.
1653         * symfile.c: Fix common/ includes.
1654         * stap-probe.c: Fix common/ includes.
1655         * spu-linux-nat.c: Fix common/ includes.
1656         * sparc-nat.c: Fix common/ includes.
1657         * source.c: Fix common/ includes.
1658         * solib.c: Fix common/ includes.
1659         * solib-target.c: Fix common/ includes.
1660         * ser-unix.c: Fix common/ includes.
1661         * ser-tcp.c: Fix common/ includes.
1662         * ser-pipe.c: Fix common/ includes.
1663         * ser-base.c: Fix common/ includes.
1664         * selftest-arch.c: Fix common/ includes.
1665         * s12z-tdep.c: Fix common/ includes.
1666         * rust-exp.y: Fix common/ includes.
1667         * rs6000-aix-tdep.c: Fix common/ includes.
1668         * riscv-tdep.c: Fix common/ includes.
1669         * remote.c: Fix common/ includes.
1670         * remote-notif.h: Fix common/ includes.
1671         * remote-fileio.h: Fix common/ includes.
1672         * remote-fileio.c: Fix common/ includes.
1673         * regcache.h: Fix common/ includes.
1674         * regcache.c: Fix common/ includes.
1675         * record-btrace.c: Fix common/ includes.
1676         * python/python.c: Fix common/ includes.
1677         * python/py-type.c: Fix common/ includes.
1678         * python/py-inferior.c: Fix common/ includes.
1679         * progspace.h: Fix common/ includes.
1680         * producer.c: Fix common/ includes.
1681         * procfs.c: Fix common/ includes.
1682         * proc-api.c: Fix common/ includes.
1683         * printcmd.c: Fix common/ includes.
1684         * ppc-linux-nat.c: Fix common/ includes.
1685         * parser-defs.h: Fix common/ includes.
1686         * osdata.c: Fix common/ includes.
1687         * obsd-nat.c: Fix common/ includes.
1688         * nat/x86-linux.c: Fix common/ includes.
1689         * nat/x86-linux-dregs.c: Fix common/ includes.
1690         * nat/x86-dregs.h: Fix common/ includes.
1691         * nat/x86-dregs.c: Fix common/ includes.
1692         * nat/ppc-linux.c: Fix common/ includes.
1693         * nat/mips-linux-watch.h: Fix common/ includes.
1694         * nat/mips-linux-watch.c: Fix common/ includes.
1695         * nat/linux-waitpid.c: Fix common/ includes.
1696         * nat/linux-ptrace.h: Fix common/ includes.
1697         * nat/linux-ptrace.c: Fix common/ includes.
1698         * nat/linux-procfs.c: Fix common/ includes.
1699         * nat/linux-personality.c: Fix common/ includes.
1700         * nat/linux-osdata.c: Fix common/ includes.
1701         * nat/linux-namespaces.c: Fix common/ includes.
1702         * nat/linux-btrace.h: Fix common/ includes.
1703         * nat/linux-btrace.c: Fix common/ includes.
1704         * nat/fork-inferior.c: Fix common/ includes.
1705         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1706         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1707         * nat/aarch64-linux.c: Fix common/ includes.
1708         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1709         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1710         * namespace.h: Fix common/ includes.
1711         * mips-linux-tdep.c: Fix common/ includes.
1712         * minsyms.c: Fix common/ includes.
1713         * mi/mi-parse.h: Fix common/ includes.
1714         * mi/mi-main.c: Fix common/ includes.
1715         * mi/mi-cmd-env.c: Fix common/ includes.
1716         * memrange.h: Fix common/ includes.
1717         * memattr.c: Fix common/ includes.
1718         * maint.h: Fix common/ includes.
1719         * maint.c: Fix common/ includes.
1720         * main.c: Fix common/ includes.
1721         * machoread.c: Fix common/ includes.
1722         * location.c: Fix common/ includes.
1723         * linux-thread-db.c: Fix common/ includes.
1724         * linux-nat.c: Fix common/ includes.
1725         * linux-fork.c: Fix common/ includes.
1726         * inline-frame.c: Fix common/ includes.
1727         * infrun.c: Fix common/ includes.
1728         * inflow.c: Fix common/ includes.
1729         * inferior.h: Fix common/ includes.
1730         * inferior.c: Fix common/ includes.
1731         * infcmd.c: Fix common/ includes.
1732         * inf-ptrace.c: Fix common/ includes.
1733         * inf-child.c: Fix common/ includes.
1734         * ia64-linux-nat.c: Fix common/ includes.
1735         * i387-tdep.c: Fix common/ includes.
1736         * i386-tdep.c: Fix common/ includes.
1737         * i386-linux-tdep.c: Fix common/ includes.
1738         * i386-linux-nat.c: Fix common/ includes.
1739         * i386-go32-tdep.c: Fix common/ includes.
1740         * i386-fbsd-tdep.c: Fix common/ includes.
1741         * i386-fbsd-nat.c: Fix common/ includes.
1742         * guile/scm-type.c: Fix common/ includes.
1743         * guile/guile.c: Fix common/ includes.
1744         * go32-nat.c: Fix common/ includes.
1745         * gnu-nat.c: Fix common/ includes.
1746         * gdbthread.h: Fix common/ includes.
1747         * gdbarch-selftests.c: Fix common/ includes.
1748         * gdb_usleep.c: Fix common/ includes.
1749         * gdb_select.h: Fix common/ includes.
1750         * gdb_bfd.c: Fix common/ includes.
1751         * gcore.c: Fix common/ includes.
1752         * fork-child.c: Fix common/ includes.
1753         * findvar.c: Fix common/ includes.
1754         * fbsd-nat.c: Fix common/ includes.
1755         * event-top.c: Fix common/ includes.
1756         * event-loop.c: Fix common/ includes.
1757         * dwarf2read.c: Fix common/ includes.
1758         * dwarf2loc.c: Fix common/ includes.
1759         * dwarf2-frame.c: Fix common/ includes.
1760         * dwarf-index-cache.c: Fix common/ includes.
1761         * dtrace-probe.c: Fix common/ includes.
1762         * disasm-selftests.c: Fix common/ includes.
1763         * defs.h: Fix common/ includes.
1764         * csky-tdep.c: Fix common/ includes.
1765         * cp-valprint.c: Fix common/ includes.
1766         * cp-support.h: Fix common/ includes.
1767         * cp-support.c: Fix common/ includes.
1768         * corelow.c: Fix common/ includes.
1769         * completer.h: Fix common/ includes.
1770         * completer.c: Fix common/ includes.
1771         * compile/compile.c: Fix common/ includes.
1772         * compile/compile-loc2c.c: Fix common/ includes.
1773         * compile/compile-cplus-types.c: Fix common/ includes.
1774         * compile/compile-cplus-symbols.c: Fix common/ includes.
1775         * command.h: Fix common/ includes.
1776         * cli/cli-dump.c: Fix common/ includes.
1777         * cli/cli-cmds.c: Fix common/ includes.
1778         * charset.c: Fix common/ includes.
1779         * build-id.c: Fix common/ includes.
1780         * btrace.h: Fix common/ includes.
1781         * btrace.c: Fix common/ includes.
1782         * breakpoint.h: Fix common/ includes.
1783         * breakpoint.c: Fix common/ includes.
1784         * ax.h:
1785         (enum agent_op): Fix common/ includes.
1786         * ax-general.c (struct aop_map): Fix common/ includes.
1787         * ax-gdb.c: Fix common/ includes.
1788         * auxv.c: Fix common/ includes.
1789         * auto-load.c: Fix common/ includes.
1790         * arm-tdep.c: Fix common/ includes.
1791         * arch/riscv.c: Fix common/ includes.
1792         * arch/ppc-linux-common.c: Fix common/ includes.
1793         * arch/i386.c: Fix common/ includes.
1794         * arch/arm.c: Fix common/ includes.
1795         * arch/arm-linux.c: Fix common/ includes.
1796         * arch/arm-get-next-pcs.c: Fix common/ includes.
1797         * arch/amd64.c: Fix common/ includes.
1798         * arch/aarch64.c: Fix common/ includes.
1799         * arch/aarch64-insn.c: Fix common/ includes.
1800         * arch-utils.c: Fix common/ includes.
1801         * amd64-windows-tdep.c: Fix common/ includes.
1802         * amd64-tdep.c: Fix common/ includes.
1803         * amd64-sol2-tdep.c: Fix common/ includes.
1804         * amd64-obsd-tdep.c: Fix common/ includes.
1805         * amd64-nbsd-tdep.c: Fix common/ includes.
1806         * amd64-linux-tdep.c: Fix common/ includes.
1807         * amd64-linux-nat.c: Fix common/ includes.
1808         * amd64-fbsd-tdep.c: Fix common/ includes.
1809         * amd64-fbsd-nat.c: Fix common/ includes.
1810         * amd64-dicos-tdep.c: Fix common/ includes.
1811         * amd64-darwin-tdep.c: Fix common/ includes.
1812         * agent.c: Fix common/ includes.
1813         * ada-lang.h: Fix common/ includes.
1814         * ada-lang.c: Fix common/ includes.
1815         * aarch64-tdep.c: Fix common/ includes.
1816
1817 2019-01-25  Tom Tromey  <tom@tromey.com>
1818
1819         * common/create-version.sh: Use common/version.h.
1820
1821 2019-01-24  Pedro Alves  <palves@redhat.com>
1822
1823         * infrun.c (signal_stop, signal_print, signal_program)
1824         (signal_catch, signal_pass): Now arrays instead of pointers.
1825         (update_signals_program_target, do_target_resume)
1826         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1827         * linux-nat.c (linux_nat_target::pass_signals)
1828         (linux_nat_target::create_inferior, linux_nat_target::attach):
1829         Adjust.
1830         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1831         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1832         * procfs.c (procfs_target::pass_signals): Adjust.
1833         * record-full.c (record_full_target::resume): Adjust.
1834         * remote.c (remote_target::pass_signals)
1835         (remote_target::program_signals): Adjust.
1836         * target-debug.h (target_debug_print_signals): Now takes a
1837         gdb::array_view as parameter.  Adjust.
1838         * target.h (target_ops) <pass_signals, program_signals>: Replace
1839         pointer and length parameters with gdb::array_view.
1840         (target_pass_signals, target_program_signals): Likewise.
1841         * target-delegates.c: Regenerate.
1842
1843 2019-01-24  Pedro Alves  <palves@redhat.com>
1844
1845         * common/forward-scope-exit.h
1846         (forward_scope_exit::forward_scope_exit): Pass arguments to
1847         m_bind_function directly, instead of creating a std::bind and
1848         copying that.
1849
1850 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1851
1852         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1853         for static members.
1854         (pass_in_v_vfp_candidate): Likewise.
1855
1856 2019-01-23  Tom Tromey  <tom@tromey.com>
1857             Pedro Alves  <palves@redhat.com>
1858
1859         * regcache.c (class regcache_invalidator): Remove.
1860         (regcache::raw_write): Use make_scope_exit.
1861
1862 2019-01-23  Tom Tromey  <tom@tromey.com>
1863
1864         * ui-out.h (class ui_out_emit_type): Update comment.
1865
1866 2019-01-23  Tom Tromey  <tom@tromey.com>
1867
1868         * infrun.c (fetch_inferior_event): Update comment.
1869
1870 2019-01-23  Tom Tromey  <tom@tromey.com>
1871             Pedro Alves  <palves@redhat.com>
1872
1873         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1874         parameter.
1875         (fetch_inferior_event): Use SCOPE_EXIT.
1876
1877
1878 2019-01-23  Tom Tromey  <tom@tromey.com>
1879             Pedro Alves  <palves@redhat.com>
1880
1881         * infrun.c (disable_thread_events): Delete.
1882         (stop_all_threads): Use SCOPE_EXIT.
1883
1884 2019-01-23  Tom Tromey  <tom@tromey.com>
1885             Pedro Alves  <palves@redhat.com>
1886
1887         * symfile.c: Include forward-scope-exit.h.
1888         (clear_symtab_users_cleanup): Replace forward declaration with
1889         a FORWARD_SCOPE_EXIT.
1890         (syms_from_objfile_1): Use the forward_scope_exit and
1891         gdb::optional instead of cleanup_function.
1892         (reread_symbols): Use the forward_scope_exit instead of
1893         cleanup_function.
1894         (clear_symtab_users_cleanup): Remove function.
1895
1896 2019-01-23  Tom Tromey  <tom@tromey.com>
1897             Pedro Alves  <palves@redhat.com>
1898
1899         * linux-nat.c: Include scope-exit.h.
1900         (cleanup_target_stop): Remove.
1901         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1902         SCOPE_EXIT.
1903
1904 2019-01-23  Tom Tromey  <tom@tromey.com>
1905             Pedro Alves  <palves@redhat.com>
1906
1907         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1908         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1909
1910 2019-01-23  Tom Tromey  <tom@tromey.com>
1911             Andrew Burgess  <andrew.burgess@embecosm.com>
1912             Pedro Alves  <palves@redhat.com>
1913
1914         * infrun.c (fetch_inferior_event): Use scope_exit.
1915         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1916         * top.c (execute_command): Use scope_exit.
1917         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1918         * utils.c (do_bpstat_clear_actions_cleanup)
1919         (make_bpstat_clear_actions_cleanup): Remove.
1920
1921 2019-01-23  Tom Tromey  <tom@tromey.com>
1922             Pedro Alves  <palves@redhat.com>
1923
1924         * infrun.c: Include "common/scope-exit.h"
1925         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1926         (wait_for_inferior): Use SCOPE_EXIT.
1927         (fetch_inferior_event): Use scope_exit.
1928
1929 2019-01-23  Tom Tromey  <tom@tromey.com>
1930             Pedro Alves  <palves@redhat.com>
1931
1932         * breakpoint.c (create_breakpoint): Remove cleanup.
1933
1934 2019-01-23  Tom Tromey  <tom@tromey.com>
1935             Andrew Burgess  <andrew.burgess@embecosm.com>
1936             Pedro Alves  <palves@redhat.com>
1937
1938 2019-01-23  Pedro Alves  <palves@redhat.com>
1939
1940         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1941
1942 2019-01-23  Pedro Alves  <palves@redhat.com>
1943             Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * gdbthread.h: Include "common/forward-scope-exit.h".
1946         (scoped_finish_thread_state): Redefine custom class in terms of
1947         forward_scope_exit.
1948
1949 2019-01-23  Pedro Alves  <palves@redhat.com>
1950             Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * common/forward-scope-exit.h: New file.
1953
1954 2019-01-23  Pedro Alves  <palves@redhat.com>
1955             Andrew Burgess  <andrew.burgess@embecosm.com>
1956             Tom Tromey  <tom@tromey.com>
1957
1958         * common/scope-exit.h: New file.
1959
1960 2019-01-23  Pedro Alves  <palves@redhat.com>
1961
1962         * common/preprocessor.h (ESC): Rename to ...
1963         (ESC_PARENS): ... this.
1964         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1965         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1966
1967 2019-01-23  Tom Tromey  <tom@tromey.com>
1968
1969         * language.h (class scoped_switch_to_sym_language_if_auto):
1970         Initialize m_lang in both cases.
1971
1972 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1973
1974         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1975         with XCNEW.
1976
1977 2019-01-22  Tom Tromey  <tom@tromey.com>
1978
1979         * corelow.c: Do not include sys/file.h.
1980
1981 2019-01-22  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-wingeneral.h: Include gdb_curses.h.
1984
1985 2019-01-22  Tom Tromey  <tom@tromey.com>
1986
1987         * source-cache.h (class source_cache) <get_source_lines,
1988         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1989
1990 2019-01-22  Tom Tromey  <tom@tromey.com>
1991
1992         * remote-fileio.h (struct remote_target): Declare.
1993
1994 2019-01-22  Tom Tromey  <tom@tromey.com>
1995
1996         * python/py-arch.c: Do not include py-ref.h.
1997         * python/py-bpevent.c: Do not include py-ref.h.
1998         * python/py-cmd.c: Do not include py-ref.h.
1999         * python/py-continueevent.c: Do not include py-ref.h.
2000         * python/py-event.h: Do not include py-ref.h.
2001         * python/py-evtregistry.c: Do not include py-ref.h.
2002         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2003         * python/py-frame.c: Do not include py-ref.h.
2004         * python/py-framefilter.c: Do not include py-ref.h.
2005         * python/py-function.c: Do not include py-ref.h.
2006         * python/py-infevents.c: Do not include py-ref.h.
2007         * python/py-linetable.c: Do not include py-ref.h.
2008         * python/py-objfile.c: Do not include py-ref.h.
2009         * python/py-param.c: Do not include py-ref.h.
2010         * python/py-prettyprint.c: Do not include py-ref.h.
2011         * python/py-progspace.c: Do not include py-ref.h.
2012         * python/py-symbol.c: Do not include py-ref.h.
2013         * python/py-symtab.c: Do not include py-ref.h.
2014         * python/py-type.c: Do not include py-ref.h.
2015         * python/py-unwind.c: Do not include py-ref.h.
2016         * python/py-utils.c: Do not include py-ref.h.
2017         * python/py-value.c: Do not include py-ref.h.
2018         * python/py-varobj.c: Do not include py-ref.h.
2019         * python/py-xmethods.c: Do not include py-ref.h.
2020         * python/python.c: Do not include py-ref.h.
2021         * varobj.c: Do not include py-ref.h.
2022
2023 2019-01-22  Tom Tromey  <tom@tromey.com>
2024
2025         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2026         keyword for bcache.
2027
2028 2019-01-22  Tom Tromey  <tom@tromey.com>
2029
2030         * compile/compile-cplus-types.c: Remove a comment by #include.
2031
2032 2019-01-22  Tom Tromey  <tom@tromey.com>
2033
2034         * compile/gcc-c-plugin.h: Include compile-internal.h.
2035
2036 2019-01-22  Tom Tromey  <tom@tromey.com>
2037
2038         * stabsread.c (EXTERN): Do not define.
2039         (symnum, next_symbol_text_func, processing_gcc_compilation)
2040         (within_function, global_sym_chain, global_stabs)
2041         (previous_stab_code, this_object_header_files)
2042         (n_this_object_header_files)
2043         (n_allocated_this_object_header_files): Define.
2044         * stabsread.h (EXTERN): Never define.  Use "extern".
2045
2046 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2047
2048         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2049         history_value.
2050
2051 2019-01-21  Tom Tromey  <tom@tromey.com>
2052
2053         * ui-out.c: Fix includes.
2054         * tui/tui-source.c: Fix includes.
2055         * target.c: Fix includes.
2056         * remote.c: Fix includes.
2057         * regcache.c: Fix includes.
2058         * python/py-block.c: Fix includes.
2059         * printcmd.c: Fix includes.
2060         * or1k-tdep.c: Fix includes.
2061         * mi/mi-main.c: Fix includes.
2062         * m32r-tdep.c: Fix includes.
2063         * csky-tdep.c: Fix includes.
2064         * compile/compile-cplus-types.c: Fix includes.
2065         * cli/cli-interp.c: Fix includes.
2066
2067 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2068
2069         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2070         for padding.
2071
2072 2019-01-16  Tom Tromey  <tom@tromey.com>
2073
2074         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2075         earlier.
2076         (struct objfile) <msymbols_range>: Move from top level.
2077         <msymbols>: New method.
2078         (class objfile_msymbols): Remove.
2079         * symtab.c (default_collect_symbol_completion_matches_break_on):
2080         Update.
2081         * symmisc.c (dump_msymbols): Update.
2082         * stabsread.c (scan_file_globals): Update.
2083         * objc-lang.c (info_selectors_command, info_classes_command)
2084         (find_methods): Update.
2085         * minsyms.c (find_solib_trampoline_target): Update.
2086         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2087         * coffread.c (coff_symfile_read): Update.
2088         * ada-lang.c (ada_lookup_simple_minsym)
2089         (ada_collect_symbol_completion_matches): Update.
2090
2091 2019-01-16  Tom Tromey  <tom@tromey.com>
2092
2093         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2094         type.  Remove no-argument constructor.
2095         <iterator::operator++>: Simplify.
2096         <begin>: Update.
2097         <end>: Use minimal_symbol_count.
2098
2099 2019-01-16  Tom Tromey  <tom@tromey.com>
2100
2101         * objfiles.h (struct objfile) <psymtabs>: New method.
2102         (class objfile_psymtabs): Remove.
2103         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2104         typedef.
2105         <range>: New method.
2106         (require_partial_symbols): Change return type.
2107         * psymtab.c (require_partial_symbols)
2108         (psym_expand_symtabs_matching): Update.
2109         * mdebugread.c (parse_partial_symbols): Update.
2110         * dbxread.c (dbx_end_psymtab): Update.
2111
2112 2019-01-15  Tom Tromey  <tom@tromey.com>
2113
2114         * symtab.c (lookup_objfile_from_block)
2115         (lookup_symbol_in_objfile_symtabs)
2116         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2117         (find_line_symtab, info_sources_command)
2118         (default_collect_symbol_completion_matches_break_on)
2119         (make_source_files_completion_list): Update.
2120         * symmisc.c (print_objfile_statistics, dump_objfile)
2121         (maintenance_print_symbols, maintenance_info_symtabs)
2122         (maintenance_check_symtabs, maintenance_info_line_tables):
2123         Update.
2124         * source.c (select_source_symtab)
2125         (forget_cached_source_info_for_objfile): Update.
2126         * objfiles.h (class objfile_compunits): Remove.
2127         (struct objfile) <compunits_range>: New typedef.
2128         (compunits): New method.
2129         * objfiles.c (objfile_relocate1): Update.
2130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2131         * maint.c (count_symtabs_and_blocks): Update.
2132         * linespec.c (iterate_over_all_matching_symtabs): Update.
2133         * cp-support.c (add_symbol_overload_list_qualified): Update.
2134         * coffread.c (coff_symtab_read): Update.
2135         * ada-lang.c (add_nonlocal_symbols)
2136         (ada_collect_symbol_completion_matches)
2137         (ada_add_global_exceptions): Update.
2138
2139 2019-01-15  Tom Tromey  <tom@tromey.com>
2140
2141         * progspace.h (program_space) <objfiles_safe_range>: New
2142         typedef.
2143         <objfiles_safe>: New method.
2144         * objfiles.h (class all_objfiles_safe): Remove.
2145         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2146         * jit.c (jit_inferior_exit_hook): Update.
2147
2148 2019-01-17  Tom Tromey  <tom@tromey.com>
2149
2150         * progspace.h (program_space) <objfiles_range>: New typedef.
2151         <objfiles>: New method.
2152         <objfiles_head>: Rename from objfiles.
2153         (object_files): Update.
2154         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2155         * guile/scm-pretty-print.c
2156         (ppscm_find_pretty_printer_from_objfiles): Update.
2157         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2158         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2159         Update.
2160         * python/py-progspace.c (pspy_get_objfiles): Update.
2161         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2162         Update.
2163         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2164         (objfpy_lookup_objfile_by_build_id): Update.
2165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2166         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2167         Update.
2168         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2169         (expand_symtab_containing_pc, lookup_objfile_from_block)
2170         (lookup_static_symbol, basic_lookup_transparent_type)
2171         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2172         (find_line_symtab, info_sources_command)
2173         (default_collect_symbol_completion_matches_break_on)
2174         (make_source_files_completion_list, find_main_name): Update.
2175         * symmisc.c (print_symbol_bcache_statistics)
2176         (print_objfile_statistics, maintenance_print_symbols)
2177         (maintenance_print_msymbols, maintenance_print_objfiles)
2178         (maintenance_info_symtabs, maintenance_check_symtabs)
2179         (maintenance_expand_symtabs, maintenance_info_line_tables):
2180         Update.
2181         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2182         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2183         (map_overlay_command, unmap_overlay_command)
2184         (simple_overlay_update, expand_symtabs_matching)
2185         (map_symbol_filenames): Update.
2186         * symfile-debug.c (set_debug_symfile): Update.
2187         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2188         Update.
2189         * source.c (select_source_symtab, forget_cached_source_info):
2190         Update.
2191         * solib.c (solib_read_symbols): Update.
2192         * solib-spu.c (append_ocl_sos): Update.
2193         * psymtab.c (maintenance_print_psymbols)
2194         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2195         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2196         * printcmd.c (info_symbol_command): Update.
2197         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2198         Update.
2199         * objfiles.h (class all_objfiles): Remove.
2200         * objfiles.c (have_partial_symbols, have_full_symbols)
2201         (have_minimal_symbols, qsort_cmp, update_section_map)
2202         (shared_objfile_contains_address_p)
2203         (default_iterate_over_objfiles_in_search_order): Update.
2204         * objc-lang.c (info_selectors_command, info_classes_command)
2205         (find_methods): Update.
2206         * minsyms.c (find_solib_trampoline_target): Update.
2207         * maint.c (maintenance_info_sections)
2208         (maintenance_translate_address, count_symtabs_and_blocks):
2209         Update.
2210         * main.c (captured_main_1): Update.
2211         * linux-thread-db.c (try_thread_db_load_from_pdir)
2212         (has_libpthread): Update.
2213         * linespec.c (iterate_over_all_matching_symtabs)
2214         (search_minsyms_for_name): Update.
2215         * jit.c (jit_find_objf_with_entry_addr): Update.
2216         * hppa-tdep.c (find_unwind_entry)
2217         (hppa_lookup_stub_minimal_symbol): Update.
2218         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2219         Update.
2220         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2221         (elf_gnu_ifunc_resolve_by_got): Update.
2222         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2223         * dwarf-index-write.c (save_gdb_index_command): Update.
2224         * cp-support.c (add_symbol_overload_list_qualified): Update.
2225         * breakpoint.c (create_overlay_event_breakpoint)
2226         (create_longjmp_master_breakpoint)
2227         (create_std_terminate_master_breakpoint)
2228         (create_exception_master_breakpoint): Update.
2229         * blockframe.c (find_pc_partial_function): Update.
2230         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2231         (ada_collect_symbol_completion_matches)
2232         (ada_add_global_exceptions): Update.
2233
2234 2019-01-17  Tom Tromey  <tom@tromey.com>
2235
2236         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2237         declare VEC.
2238         (solib_target_parse_libraries): Change return type.
2239         (library_list_start_segment, library_list_start_section)
2240         (library_list_end_library, library_list_start_library); Update.
2241         (solib_target_free_library_list): Remove.
2242         (solib_target_parse_libraries): Remove cleanup.  Change return
2243         type.
2244         (solib_target_current_sos): Update.
2245
2246 2019-01-17  Tom Tromey  <tromey@bapiya>
2247
2248         * valprint.c: Replace "the the" with "the".
2249         * symtab.c: Replace "the the" with "the".
2250         * solib.c: Replace "the the" with "the".
2251         * solib-dsbt.c: Replace "the the" with "the".
2252         * linespec.c: Replace "the the" with "the".
2253         * dwarf2loc.h: Replace "the the" with "the".
2254         * amd64-windows-tdep.c: Replace "the the" with "the".
2255         * aarch64-tdep.c: Replace "the the" with "the".
2256
2257 2019-01-16  Keith Seitz  <keiths@redhat.com>
2258
2259         PR gdb/23773
2260         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2261         <builder>: Rename to ..
2262         <m_builder>: ... this and make private.
2263         (dwarf2_cu::get_builder): New method.  Change all users of
2264         `builder' to use this method.
2265         (dwarf2_start_symtab): Move to ...
2266         (dwarf2_cu::start_symtab): ... here.  Update all callers
2267         (setup_type_unit_groups): Move to ...
2268         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2269         callers.
2270         (dwarf2_cu::reset_builder): New method.
2271         (process_full_compunit, process_full_type_unit): Use
2272         dwarf2_cu::reset_builder.
2273         (follow_die_offset): Record the ancestor CU if it is different
2274         from the followed DIE's CU.
2275         (follow_die_sig_1): Likewise.
2276
2277 2019-01-15  Tom Tromey  <tom@tromey.com>
2278
2279         * remote.c (class remote_state) <buf>: Now a char_vector.
2280         <buf_size>: Remove.
2281         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2282         parameter.
2283         (remote_target::getpkt_or_notif_sane_1)
2284         (remote_target::getpkt_sane)
2285         (remote_target::getpkt_or_notif_sane): Likewise.
2286         (class remote_target) <putpkt>: New overload.
2287         (remote_target::read_frame): Change type of "buf_p".  Remove
2288         sizeof_p parameter.
2289         (packet_ok): New overload.
2290         (packet_check_result): New overload.
2291         Update all uses.
2292
2293 2019-01-14  Tom Tromey  <tom@tromey.com>
2294
2295         * remote-notif.c (handle_notification, remote_notif_ack)
2296         (remote_notif_parse): Make "buf" const.
2297         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2298         const.
2299         (remote_notif_parse, remote_notif_ack, handle_notification):
2300         Likewise.
2301         * remote.c (remote_notif_stop_parse): Make "buf" const.
2302         (remote_target::remote_parse_stop_reply): Make "buf" const.
2303         (remote_notif_stop_ack): Make "buf" const.
2304
2305 2019-01-14  Tom Tromey  <tom@tromey.com>
2306
2307         * remote.c (remote_console_output): Make parameter const.
2308
2309 2019-01-14  Tom Tromey  <tom@tromey.com>
2310
2311         * target-debug.h (target_debug_print_signals): Constify.
2312         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2313         * procfs.c (procfs_target::pass_signals): Update.
2314         * linux-nat.c (linux_nat_target::pass_signals): Update.
2315         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2316         * target-delegates.c: Rebuild.
2317         * remote.c (remote_target::program_signals): Update.
2318         (remote_target::pass_signals): Update.
2319         * target.c (target_pass_signals): Constify argument.
2320         (target_program_signals): Likewise.
2321         * target.h (struct target_ops) <pass_signals, program_signals>:
2322         Constify argument.
2323         (target_pass_signals, target_program_signals): Constify argument.
2324
2325 2019-01-14  Tom Tromey  <tom@tromey.com>
2326
2327         PR tui/28819:
2328         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2329
2330 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2331
2332         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2333         field.
2334         * rs6000-tdep.c: Include reggroups.h.
2335         (IS_V_ALIAS_PSEUDOREG): Define.
2336         (rs6000_register_name): Return names for the "vX" aliases.
2337         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2338         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2339         aliases.  Call default_register_reggroup_p for all other
2340         pseudo-registers.
2341         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2342         New functions.
2343         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2344         Handle "vX" aliases.
2345         (v_alias_pseudo_register_collect): New function.
2346         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2347         (rs6000_gdbarch_init): Initialize "vX" aliases as
2348         pseudo-registers.  Restore registration of
2349         rs6000_pseudo_register_reggroup_p with
2350         set_tdesc_pseudo_register_reggroup_p.
2351
2352 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2353
2354         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2355         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2356         set_gdbarch_num_pseudo_regs.
2357
2358 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2359
2360         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2361         Remove arg prefixname, add do_set and do_show.
2362         Add member functions set_list and show_list.
2363         * cli/cli-style.c (class cli_style_option): Update accordingly.
2364         (style_set_list): Move to file scope.
2365         (style_show_list): Likewise.
2366         (set_style): Call help_list.
2367         (show_style): Call cmd_show_list.
2368         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2369         Update to use the new macro.
2370
2371 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2372
2373         * ada-lang.c (_initialize_ada_language): Expand the help text
2374         for the "catch exception" command.
2375
2376 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2377
2378         * symtab.c (matching_obj_sections): Initialize obj,
2379         declare it closer to its usage.
2380
2381 2019-01-10  Tom Tromey  <tom@tromey.com>
2382
2383         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2384         (basic_inf_threads_range): Remove.
2385         (inf_threads_range, inf_non_exited_threads_range)
2386         (safe_inf_threads_range): Use next_adapter.
2387
2388 2019-01-10  Keith Seitz  <keiths@redhat.com>
2389
2390         PR gdb/23712
2391         PR symtab/23010
2392         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2393         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2394
2395 2019-01-10  Keith Seitz  <keiths@redhat.com>
2396
2397         PR gdb/23712
2398         PR symtab/23010
2399         * dictionary.c (pending_to_vector): Remove.
2400         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2401         Remove _1 suffix, replacing functions of the same name.  Update
2402         all callers.
2403         (dict_create_hashed, dict_create_hashed_expandable)
2404         (dict_create_linear, dict_create_linear_expandable, dict_free)
2405         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2406         Make functions static.
2407
2408 2019-01-10  Keith Seitz  <keiths@redhat.com>
2409
2410         PR gdb/23712
2411         PR symtab/23010
2412         * dictionary.h (struct dictionary): Replace declaration with
2413         multidictionary.
2414         (dict_create_hashed, dict_create_hashed_expandable)
2415         (dict_create_linear, dict_create_linear_expandable)
2416         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2417         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2418         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2419         taking multidictionary argument.
2420         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2421         * block.h (struct block) <dict>: Change to multidictionary
2422         and rename `multidict'.
2423         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2424         symmisc.c: Update all dictionary references to multidictionary.
2425
2426 2019-01-10  Keith Seitz  <keiths@redhat.com>
2427
2428         PR gdb/23712
2429         PR symtab/23010
2430         * dictionary.c: Include unordered_map.
2431         (pending_to_vector): New function.
2432         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2433         Rewrite the non-"_1" functions to take vector instead
2434         of linked list.
2435         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2436         "new" _1 versions of the same name.
2437         (multidictionary): Define.
2438         (std::hash<enum language): New definition.
2439         (collate_pending_symbols_by_language, mdict_create_hashed)
2440         (mdict_create_hashed_expandable, mdict_create_linear)
2441         (mdict_create_linear_expandable, mdict_free)
2442         (find_language_dictionary, create_new_language_dictionary)
2443         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2444         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2445         (mdict_size, mdict_empty): New functions.
2446         * dictionary.h (mdict_iterator): Define.
2447
2448 2019-01-10  Pedro Alves  <palves@redhat.com>
2449
2450         * breakpoint.c (read_uploaded_action)
2451         (create_tracepoint_from_upload): Adjust to use
2452         gdb::unique_xmalloc_ptr.
2453         * ctf.c (ctf_write_uploaded_tp):
2454         (SET_ARRAY_FIELD): Use emplace_back.
2455         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2456         * tracefile-tfile.c (tfile_write_uploaded_tp):
2457         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2458         gdb::unique_xmalloc_ptr.
2459         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2460         at_string, cond_string, cmd_strings>: Replace char pointers
2461         with gdb::unique_xmalloc_ptr.
2462
2463 2019-01-10  Pedro Alves  <palves@redhat.com>
2464
2465         * solib-target.c (library_list_start_library): Don't xstrdup name.
2466
2467 2019-01-10  Pedro Alves  <palves@redhat.com>
2468
2469         * mdebugread.c (parse_partial_symbols): Use
2470         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2471
2472 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * linux-fork.c (scoped_switch_fork_info)
2475         <~scoped_switch_fork_info>: Fix incorrect variable name.
2476
2477 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * linux-fork.c (scoped_switch_fork_info)
2480         <scoped_switch_fork_info>: Make explicit.
2481         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2482
2483 2019-01-10  Tom Tromey  <tom@tromey.com>
2484
2485         * objfiles.h (objfile::reset_psymtabs): Update.
2486         * objfiles.c (objfile::objfile): Update.
2487         * psymtab.h (psymtab_storage::obstack): Update.
2488         (psymtab_storage::m_obstack): Use gdb::optional.
2489         (class psymtab_storage): Update comment.  Remove objfile
2490         parameter.
2491         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2492
2493 2019-01-10  Tom Tromey  <tom@tromey.com>
2494
2495         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2496         <free_psymtabs>: Now private.
2497         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2498         (allocate_psymtab): Use new method.
2499
2500 2019-01-10  Tom Tromey  <tom@tromey.com>
2501
2502         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2503         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2504         * mdebugread.c (parse_partial_symbols): Use
2505         allocate_dependencies.
2506         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2507         allocate_dependencies.
2508         (process_psymtab_comp_unit_reader)
2509         (build_type_psymtab_dependencies): Likewise.
2510         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2511
2512 2019-01-10  Tom Tromey  <tom@tromey.com>
2513
2514         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2515         PSYMBOL_SET_LANGUAGE.
2516         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2517
2518 2019-01-10  Tom Tromey  <tom@tromey.com>
2519
2520         * psymtab.h (psymtab_storage::obstack): New method.
2521         <m_obstack>: Rename from obstack; now private.
2522         * psymtab.c (psymtab_storage): Update.
2523         * dwarf2read.c (create_addrmap_from_index)
2524         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2525         Update.
2526
2527 2019-01-10  Tom Tromey  <tom@tromey.com>
2528
2529         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2530         * objfiles.h (objfile::reset_psymtabs): New method.
2531
2532 2019-01-10  Tom Tromey  <tom@tromey.com>
2533
2534         * symmisc.c (print_symbol_bcache_statistics): Update.
2535         (print_objfile_statistics): Update.
2536         * symfile.c (reread_symbols): Update.
2537         * psymtab.h (class psymtab_storage): New.
2538         * psymtab.c (psymtab_storage): New constructor.
2539         (~psymtab_storage): New destructor.
2540         (require_partial_symbols): Update.
2541         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2542         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2543         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2544         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2545         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2546         (start_psymtab_common, end_psymtab_common)
2547         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2548         (allocate_psymtab): Update.
2549         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2550         Update.
2551         (dump_psymtab_addrmap, maintenance_print_psymbols)
2552         (maintenance_check_psymtabs): Update.
2553         (class objfile_psymtabs): Move to objfiles.h.
2554         * psympriv.h (discard_psymtab): Now inline.
2555         (psymtab_discarder::psymtab_discarder): Update.
2556         (psymtab_discarder::~psymtab_discarder): Update.
2557         (ALL_OBJFILE_PSYMTABS): Rewrite.
2558         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2559         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2560         Remove fields.
2561         <partial_symtabs>: New field.
2562         (class objfile_psymtabs): Move from psymtab.h.  Update.
2563         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2564         psymbol_cache.
2565         (objfile::~objfile): Don't destroy psymbol_cache.
2566         * mdebugread.c (parse_partial_symbols): Update.
2567         * dwarf2read.c (create_addrmap_from_index)
2568         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2569         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2570         (add_partial_subprogram, dwarf2_ranges_read): Update.
2571         * dwarf-index-write.c (write_address_map)
2572         (write_one_signatured_type, recursively_write_psymbols)
2573         (class debug_names, class debug_names, write_psymtabs_to_index):
2574         Update.
2575
2576 2019-01-10  Tom Tromey  <tom@tromey.com>
2577
2578         * symtab.h (SYMBOL_SET_NAMES): Update.
2579         (symbol_set_names): Update.
2580         (MSYMBOL_SET_NAMES): Update.
2581         * symtab.c (symbol_set_names): Change argument to be an
2582         objfile_per_bfd_storage.
2583         * psymtab.c (add_psymbol_to_bcache): Update.
2584         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2585
2586 2019-01-10  Tom Tromey  <tom@tromey.com>
2587
2588         * symtab.c (create_demangled_names_hash): Change argument to be an
2589         objfile_per_bfd_storage.
2590         (symbol_set_names): Update.
2591
2592 2019-01-10  Tom Tromey  <tom@tromey.com>
2593
2594         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2595         init_psymbol_list.
2596         * psymtab.c (init_psymbol_list): Do nothing if already called.
2597         * psympriv.h (init_psymbol_list): Add comment.
2598         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2599         init_psymbol_list.
2600         * dbxread.c (dbx_symfile_read): Unconditionally call
2601         init_psymbol_list.
2602
2603 2019-01-10  Tom Tromey  <tom@tromey.com>
2604
2605         * xcoffread.c (scan_xcoff_symtab): Update.
2606         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2607         "where".
2608         * mdebugread.c (parse_partial_symbols)
2609         (handle_psymbol_enumerators): Update.
2610         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2611         * dbxread.c (read_dbx_symtab): Update.
2612         * psympriv.h (psymbol_placement): New enum.
2613         (add_psymbol_to_list): Update.
2614
2615 2019-01-10  Tom Tromey  <tom@tromey.com>
2616
2617         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2618         static_psymbols parameters.
2619         (scan_xcoff_symtab): Update.
2620         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2621         static_psymbols parameters.
2622         * psympriv.h (start_psymtab_common): Update.
2623         * mdebugread.c (parse_partial_symbols): Update.
2624         * dwarf2read.c (create_partial_symtab): Update.
2625         * dbxread.c (read_dbx_symtab): Update.
2626         (start_psymtab): Remove global_psymbols and static_psymbols
2627         parameters.
2628
2629 2019-01-10  Tom Tromey  <tom@tromey.com>
2630
2631         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2632         * psymtab.c (allocate_psymtab): Add comment.
2633         * psympriv.h (allocate_psymtab): Add comment.
2634         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2635         initializations.
2636         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2637
2638 2019-01-10  Tom Tromey  <tom@tromey.com>
2639
2640         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2641         Don't declare.
2642         * mipsread.c: Include mdebugread.h.
2643         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2644         Declare.
2645         * elfread.c: Include mdebugread.h.
2646
2647 2019-01-09  Tom Tromey  <tom@tromey.com>
2648
2649         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2650         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2651         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2652         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2653         (psym_lookup_symbol, psym_find_last_source_symtab)
2654         (psym_forget_cached_source_info, psym_print_stats)
2655         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2656         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2657         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2658         (psym_find_compunit_symtab_by_address)
2659         (maintenance_print_psymbols, maintenance_info_psymtabs)
2660         (maintenance_check_psymtabs): Use ranged for.
2661         * psymtab.h (class objfile_psymtabs): New.
2662         (require_partial_symbols): Return objfile_psymtabs.
2663         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2664
2665 2019-01-09  Tom Tromey  <tom@tromey.com>
2666
2667         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2668         (find_pc_mapped_section, list_overlays_command)
2669         (map_overlay_command, unmap_overlay_command)
2670         (simple_overlay_update): Use all_objfiles.
2671         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2672         * printcmd.c (info_symbol_command): Use all_objfiles.
2673         * objfiles.h (ALL_OBJSECTIONS): Remove.
2674         * maint.c (maintenance_translate_address): Use all_objfiles.
2675         * gcore.c (gcore_create_callback): Use all_objfiles.
2676         (objfile_find_memory_regions): Likewise.
2677
2678 2019-01-09  Tom Tromey  <tom@tromey.com>
2679
2680         * symtab.c (find_line_symtab, info_sources_command)
2681         (make_source_files_completion_list): Use objfile_compunits.
2682         * source.c (select_source_symtab): Use objfile_compunits.
2683         * objfiles.h (struct objfile): Update comment.
2684         (ALL_OBJFILES): Remove.
2685         (ALL_FILETABS): Remove.
2686         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2687         objfile_compunits.
2688
2689 2019-01-09  Tom Tromey  <tom@tromey.com>
2690
2691         * symmisc.c (print_objfile_statistics, dump_objfile)
2692         (maintenance_print_symbols): Use compunit_filetabs.
2693         * source.c (forget_cached_source_info_for_objfile): Use
2694         compunit_filetabs.
2695         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2696         (ALL_FILETABS): Use compunit_filetabs.
2697         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2698         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2699
2700 2019-01-09  Tom Tromey  <tom@tromey.com>
2701
2702         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2703         (compunit_filetabs): New.
2704         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2705         compunit_filetabs.
2706         (info_sources_command, make_source_files_completion_list): Remove
2707         declaration.
2708         * symmisc.c (print_objfile_statistics, dump_objfile)
2709         (maintenance_print_symbols): Remove declaration.
2710         (maintenance_info_symtabs): Use compunit_filetabs.
2711         (maintenance_info_line_tables): Likewise.
2712         * source.c (select_source_symtab): Change local variable name.
2713         (forget_cached_source_info_for_objfile): Remove declaration.
2714         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2715         * objfiles.c (objfile_relocate1): Remove declaration.
2716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2717         declaration.
2718         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2719         * coffread.c (coff_symtab_read): Remove declaration.
2720         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2721         compunit_filetabs.
2722
2723 2019-01-09  Tom Tromey  <tom@tromey.com>
2724
2725         * symtab.c (lookup_objfile_from_block)
2726         (find_pc_sect_compunit_symtab, search_symbols)
2727         (default_collect_symbol_completion_matches_break_on): Use
2728         objfile_compunits.
2729         * objfiles.h (ALL_COMPUNITS): Remove.
2730         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2731         * cp-support.c (add_symbol_overload_list_qualified): Use
2732         objfile_compunits.
2733         * ada-lang.c (ada_collect_symbol_completion_matches)
2734         (ada_add_global_exceptions): Use objfile_compunits.
2735
2736 2019-01-09  Tom Tromey  <tom@tromey.com>
2737
2738         * source.c (select_source_symtab)
2739         (forget_cached_source_info_for_objfile): Remove declaration.
2740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2741         declaration.
2742         * maint.c (count_symtabs_and_blocks): Remove declaration.
2743         * cp-support.c (add_symbol_overload_list_qualified): Remove
2744         declaration.
2745         * coffread.c (coff_symtab_read): Remove declaration.
2746         * symtab.c (lookup_symbol_in_objfile_symtabs)
2747         (basic_lookup_transparent_type_1): Use objfile_compunits.
2748         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2749         (info_sources_command, search_symbols)
2750         (default_collect_symbol_completion_matches_break_on)
2751         (make_source_files_completion_list): Remove declaration.
2752         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2753         (ada_collect_symbol_completion_matches)
2754         (ada_add_global_exceptions): Remove declaration.
2755         * linespec.c (iterate_over_all_matching_symtabs): Use
2756         objfile_compunits.
2757         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2758         (class objfile_compunits): New.
2759         (ALL_COMPUNITS): Use objfile_compunits.
2760         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2761         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2762         objfile_compunits.
2763         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2764
2765 2019-01-09  Tom Tromey  <tom@tromey.com>
2766
2767         * symtab.c (search_symbols)
2768         (default_collect_symbol_completion_matches_break_on): Use
2769         objfile_msymbols.
2770         * ada-lang.c (ada_lookup_simple_minsym)
2771         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2772         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2773         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2774         objfile_msymbols.
2775         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2776         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2777         * objc-lang.c (find_methods): Use objfile_msymbols.
2778         (info_selectors_command, info_classes_command): Likewise.
2779         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2780         * objfiles.h (class objfile_msymbols): New.
2781         (ALL_OBJFILE_MSYMBOLS): Remove.
2782         (ALL_MSYMBOLS): Remove.
2783
2784 2019-01-09  Tom Tromey  <tom@tromey.com>
2785
2786         * common/next-iterator.h (next_adapter): Add Iterator template
2787         parameter.
2788         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2789         (class all_objfiles_safe): New.
2790         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2791         * objfiles.c (put_objfile_before): Update comment.
2792         (add_separate_debug_objfile): Likewise.
2793         (free_all_objfiles): Use all_objfiles_safe.
2794         (objfile_purge_solibs): Likewise.
2795
2796 2019-01-09  Tom Tromey  <tom@tromey.com>
2797
2798         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2799         (expand_symtab_containing_pc, lookup_static_symbol)
2800         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2801         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2802         all_objfiles.
2803         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2804         * breakpoint.c (create_overlay_event_breakpoint)
2805         (create_longjmp_master_breakpoint)
2806         (create_std_terminate_master_breakpoint)
2807         (create_exception_master_breakpoint): Use all_objfiles.
2808         * linux-thread-db.c (try_thread_db_load_from_pdir)
2809         (has_libpthread): Use all_objfiles.
2810         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2811         * linespec.c (iterate_over_all_matching_symtabs)
2812         (search_minsyms_for_name): Use all_objfiles.
2813         * maint.c (maintenance_info_sections): Use all_objfiles.
2814         * main.c (captured_main_1): Use all_objfiles.
2815         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2816         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2817         * guile/scm-pretty-print.c
2818         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2819         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2820         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2821         (maintenance_print_msymbols): Use all_objfiles.
2822         * source.c (select_source_symtab): Use all_objfiles.
2823         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2824         * symfile.c (remove_symbol_file_command)
2825         (expand_symtabs_matching, map_symbol_filenames): Use
2826         all_objfiles.
2827         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2828         all_objfiles.
2829         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2830         * objc-lang.c (find_methods): Use all_objfiles.
2831         * objfiles.c (have_partial_symbols, have_full_symbols)
2832         (have_minimal_symbols, qsort_cmp)
2833         (default_iterate_over_objfiles_in_search_order): Use
2834         all_objfiles.
2835         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2836         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2837         (maintenance_check_psymtabs): Use all_objfiles.
2838         (ALL_PSYMTABS): Remove.
2839         * compile/compile-object-run.c (do_module_cleanup): Use
2840         all_objfiles.
2841         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2842         * cp-support.c (add_symbol_overload_list_qualified): Use
2843         all_objfiles.
2844         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2845         Use all_objfiles.
2846         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2847         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2848         all_objfiles.
2849         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2850         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2851         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2852         Uses all_objfiles.
2853         * solib.c (solib_read_symbols): Use all_objfiles
2854
2855 2019-01-09  Tom Tromey  <tom@tromey.com>
2856
2857         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2858         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2859         all_objfiles.
2860         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2861         * symmisc.c (print_symbol_bcache_statistics)
2862         (print_objfile_statistics, maintenance_print_objfiles)
2863         (maintenance_info_symtabs, maintenance_check_symtabs)
2864         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2865         all_objfiles.
2866         * source.c (forget_cached_source_info): Use all_objfiles.
2867         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2868         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2869         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2870         * objfiles.c (update_section_map): Use all_objfiles.
2871         (shared_objfile_contains_address_p): Likewise.
2872         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2873         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2874
2875 2019-01-09  Tom Tromey  <tom@tromey.com>
2876
2877         * common/next-iterator.h: New file.
2878         * objfiles.h (class all_objfiles): New.
2879         (struct objfile_iterator): New.
2880
2881 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         * NEWS: Move the description of the changed "frame", "select-frame",
2884          and "info frame" commands to the Changed commands section.
2885
2886 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2887
2888         * gdbtypes.c (check_stub_method_group): Remove handling of old
2889         mangling schemes.
2890         * linespec.c (find_methods): Likewise.
2891         * stabsread.c (read_member_functions): Likewise.
2892         * valops.c (search_struct_method): Likewise.
2893         (value_struct_elt_for_reference): Likewise.
2894         * NEWS: Mention this change.
2895
2896 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2899         print_source_lines.
2900         * source.c (print_source_lines_base): Update line number check.
2901         (print_source_lines): New function.
2902         (source_lines_range::source_lines_range): New function.
2903         * source.h (class source_lines_range): New class.
2904         (print_source_lines): New declaration.
2905
2906 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2907
2908         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2909
2910 2019-01-08  Tom Tromey  <tom@tromey.com>
2911             Simon Marchi  <simon.marchi@ericsson.com>
2912
2913         PR gdb/24060
2914         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2915         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2916         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2917         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2918         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2919         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2920
2921 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * source.c (select_source_symtab): Move header comment to
2924         declaration in source.h.
2925         (forget_cached_source_info_for_objfile): Likewise.
2926         (forget_cached_source_info): Likewise.
2927         (identify_source_line): Likewise.
2928         * source.h (identify_source_line): Move declaration from symtab.h
2929         and add comment from source.c
2930         (print_source_lines): Likewise.
2931         (forget_cached_source_info_for_objfile): Likewise.
2932         (forget_cached_source_info): Likewise.
2933         (select_source_symtab): Likewise.
2934         (enum print_source_lines_flag): Move definition from symtab.h.
2935         * symtab.h (identify_source_line): Move declaration to source.h.
2936         (print_source_lines): Likewise.
2937         (forget_cached_source_info_for_objfile): Likewise.
2938         (forget_cached_source_info): Likewise.
2939         (select_source_symtab): Likewise.
2940         (enum print_source_lines_flag): Move definition to source.h.
2941         * tui/tui-hooks.c: Add 'source.h' include.
2942
2943 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2944
2945         * source.c (print_source_lines_base): Handle requests to print
2946         reverse line number sequences, and guard against empty lines
2947         string.
2948
2949 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * source.c (print_source_lines_base): Fix skip of '\r' if next
2952         character is '\n'.
2953
2954 2019-01-06  Tom Tromey  <tom@tromey.com>
2955
2956         * c-exp.y (struct c_parse_state) <macro_original_text,
2957         expansion_obstack>: New member.
2958         (macro_original_text, expansion_obstack): Remove globals.
2959         (scan_macro_expansion, scanning_macro_expansion)
2960         (finished_macro_expansion): Update.
2961         (scan_macro_cleanup): Remove.
2962         (yylex, c_parse): Update.
2963
2964 2019-01-06  Tom Tromey  <tom@tromey.com>
2965
2966         * c-exp.y (struct c_parse_state) <strings>: New member.
2967         (operator_stoken): Update.
2968
2969 2019-01-06  Tom Tromey  <tom@tromey.com>
2970
2971         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2972         (union type_stack_elt) <typelist_val>: Now a pointer to
2973         std::vector.
2974         (type_stack_cleanup): Don't declare.
2975         (push_typelist): Update.
2976         * parse.c (pop_typelist): Return a std::vector.
2977         (push_typelist): Take a std::vector.
2978         (follow_types): Update.  Do not free args.
2979         (type_stack_cleanup): Remove.
2980         * c-exp.y (struct c_parse_state): New.
2981         (cpstate): New global.
2982         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2983         (nonempty_typelist): Update.
2984         (func_mod): Create a new vector.
2985         (c_parse): Create a c_parse_state.
2986         (check_parameter_typelist): Do not delete params.
2987         (function_method): Update.  Do not delete type_list.
2988
2989 2019-01-06  Tom Tromey  <tom@tromey.com>
2990
2991         PR gdb/28155:
2992         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2993         check_typedef.
2994         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2995         (print_return_value): Likewise.
2996
2997 2019-01-05  Tom Tromey  <tom@tromey.com>
2998
2999         * contrib/cleanup_check.py: Remove.
3000         * contrib/gcc-with-excheck: Remove.
3001         * contrib/exsummary.py: Remove.
3002         * contrib/excheck.py: Remove.
3003
3004 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3005
3006         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3007         NULL. Initialize tpprev to NULL instead of assigning it
3008         to NULL on the next statement.
3009         * windows-nat.c (windows_delete_thread): Remove check for
3010         main_thread_id before printing thread exit notifications.
3011         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3012         Remove thread ID check against main_thread_id.
3013         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3014         windows_delete_thread.
3015         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3016
3017 2019-01-04  Tom Tromey  <tom@tromey.com>
3018
3019         * compile/compile.c (_initialize_compile): Use upper case for
3020         metasyntactic variables.
3021         * symmisc.c (_initialize_symmisc): Use upper case for
3022         metasyntactic variables.
3023         * psymtab.c (_initialize_psymtab): Use upper case for
3024         metasyntactic variables.
3025         * demangle.c (demangle_command): Use upper case for metasyntactic
3026         variables.
3027         (_initialize_demangler): Likewise.
3028         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3029         variables.
3030
3031 2019-01-03  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3034
3035 2019-01-03  Tom Tromey  <tom@tromey.com>
3036
3037         * python/py-symtab.c (salpy_str): Update.
3038         (struct salpy_sal_object) <symtab>: Now a PyObject.
3039         (salpy_dealloc): Update.
3040         (del_objfile_sal): Use gdbpy_ref.
3041
3042 2019-01-03  Tom Tromey  <tom@tromey.com>
3043
3044         * python/py-type.c (convert_field): Use new_reference.  Return
3045         gdbpy_ref.
3046         (make_fielditem): Return gdbpy_ref.
3047         (typy_fields): Update.
3048         (typy_getitem): Update.
3049         (field_name): Return gdbpy_ref.  Use new_reference.
3050         (typy_iterator_iternext): Update.
3051
3052 2019-01-03  Tom Tromey  <tom@tromey.com>
3053
3054         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3055
3056 2019-01-03  Tom Tromey  <tom@tromey.com>
3057
3058         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3059         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3060         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3061         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3062         (pspy_set_type_printers): Likewise.
3063         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3064         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3065         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3066         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3067         (objfpy_set_type_printers): Likewise.
3068
3069 2019-01-03  Tom Tromey  <tom@tromey.com>
3070
3071         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3072         (gdbpy_print_stack): Use gdbpy_err_fetch.
3073         * python/python-internal.h (class gdbpy_err_fetch): New class.
3074         (class gdbpy_enter) <m_error_type, m_error_value,
3075         m_error_traceback>: Remove.
3076         <m_error>: New member.
3077         (gdbpy_exception_to_string): Don't declare.
3078         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3079         * python/py-value.c (convert_value_from_python): Use
3080         gdbpy_err_fetch.
3081         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3082         gdbpy_exception_to_string.
3083         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3084         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3085         gdbpy_err_fetch.
3086
3087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * linux-nat.c (delete_lwp_cleanup): Delete.
3090         (struct lwp_deleter): New struct.
3091         (lwp_info_up): New typedef.
3092         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3093         lwp_info_up.
3094
3095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * linux-fork.c (class scoped_switch_fork_info): New class.
3098         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3099
3100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * valops.c (find_overload_match): Remove use of null_cleanup, and
3103         calls to do_cleanups.
3104
3105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * compile/compile-cplus-types.c
3108         (compile_cplus_instance::decl_name): Handle changes to
3109         cp_func_name.
3110         * cp-support.c (cp_func_name): Update header comment, update
3111         return type.
3112         * cp-support.h (cp_func_name): Update return type in declaration.
3113         * valops.c (find_overload_match): Move temp_func local to top
3114         level of function and change its type.  Use temp_func to hold and
3115         delete temporary string obtained from cp_func_name.
3116
3117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3120         gdb::char_vector, remove cleanup, and update uses of `msg`.
3121
3122 2019-01-03  Jim Wilson  <jimw@sifive.com>
3123
3124         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3125
3126 2019-01-02  Tom Tromey  <tom@tromey.com>
3127
3128         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3129         (tdesc_parse_xml): Remove cleanups.
3130         * target-descriptions.h (make_cleanup_free_target_description):
3131         Don't declare.
3132         (target_desc_deleter): New struct.
3133         (target_desc_up): New typedef.
3134         * target-descriptions.c (target_desc_deleter::operator()): Rename
3135         from free_target_description.
3136         (make_cleanup_free_target_description): Remove.
3137
3138 2019-01-02  Tom Tromey  <tom@tromey.com>
3139
3140         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3141         constructor, destructor.
3142         (linespec_parser): Remove typedef.
3143         (~linespec_parser): Rename from linespec_parser_delete.
3144         (linespec_lex_to_end, linespec_complete_label)
3145         (linespec_complete): Update.
3146         (decode_line_full): Remove cleanups.
3147         (decode_line_1): Update.
3148
3149 2019-01-02  Tom Tromey  <tom@tromey.com>
3150
3151         * python/python-internal.h (inferior_to_inferior_object): Change
3152         return type.
3153         * python/py-exitedevent.c (create_exited_event_object): Update.
3154         * python/py-inferior.c (inferior_to_inferior_object): Return
3155         gdbpy_ref.
3156         (python_new_inferior, python_inferior_deleted)
3157         (thread_to_thread_object, delete_thread_object)
3158         (build_inferior_list, gdbpy_selected_inferior): Update.
3159         * python/py-infthread.c (create_thread_object): Update.  Also fail
3160         if inferior_to_inferior_object fails.
3161
3162 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3163
3164         * inferior.h (class inferior) <displaced_step_state>: New field.
3165         * infrun.h (struct displaced_step_state): Move here from
3166         infrun.c.  Initialize fields, add constructor.
3167         <inf>: Remove field.
3168         <reset>: New method.
3169         * infrun.c (struct displaced_step_inferior_state): Move to
3170         infrun.h.
3171         (displaced_step_inferior_states): Remove.
3172         (get_displaced_stepping_state): Adust.
3173         (displaced_step_in_progress_any_inferior): Adjust.
3174         (displaced_step_in_progress_thread): Adjust.
3175         (displaced_step_in_progress): Adjust.
3176         (add_displaced_stepping_state): Remove.
3177         (get_displaced_step_closure_by_addr): Adjust.
3178         (remove_displaced_stepping_state): Remove.
3179         (infrun_inferior_exit): Call displaced_step_state.reset.
3180         (use_displaced_stepping): Don't check for NULL.
3181         (displaced_step_prepare_throw): Call
3182         get_displaced_stepping_state.
3183         (displaced_step_fixup): Don't check for NULL.
3184         (prepare_for_detach): Don't check for NULL.
3185
3186 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3187
3188         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3189          in case of call that did not complete.
3190
3191 2019-01-02  Andrey Utkin  <autkin@undo.io>
3192
3193         * symfile.c (find_separate_debug_file): Fix search of debug files for
3194         remote debuggee.
3195
3196 2019-01-02  Tom Tromey  <tom@tromey.com>
3197
3198         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3199         indentation.
3200         * python/py-frame.c (frapy_older): Remove cast.
3201         (frapy_newer): Likewise.
3202         * python/py-breakpoint.c (local_setattro): Remove cast.
3203         * python/py-arch.c (archpy_name): Remove local variable.
3204         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3205
3206 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3207
3208         * unittests/basic_string_view/element_access/char/empty.cc:
3209         Fix year range in copyright header.
3210
3211 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3214         Delete.
3215         <operator==>: Update with for removed field.
3216         <hash>: Likewise.
3217         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3218         <isa_features>: ...this.
3219         <abi_features>: New field.
3220         (riscv_isa_flen): Update comment.
3221         (riscv_abi_xlen): New declaration.
3222         (riscv_abi_flen): New declaration.
3223         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3224         isa_features.
3225         (riscv_abi_xlen): New function.
3226         (riscv_isa_flen): Update to get answer from isa_features.
3227         (riscv_abi_flen): New function.
3228         (riscv_has_fp_abi): Update to get answer from abi_features.
3229         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3230         xlen and flen.
3231         (riscv_call_info) <xlen, flen>: Update comment.
3232         (riscv_call_arg_struct): Remove invalid assertions
3233         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3234         is removed.
3235         (riscv_gdbarch_init): Gather isa features and abi features
3236         separately, ensure both match on the gdbarch when reusing an old
3237         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3238         a target with 64-bit float hardware.
3239
3240 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3241
3242         * source.c (search_command_helper): Stop reverse search
3243         when line 1 has been searched.
3244
3245 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         * record-full.c (record_full_base_target::close): Rewrite
3248         record_full_core_buf_list free logic.
3249
3250 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3251
3252         * break-catch-syscall.c (print_one_catch_syscall): xfree
3253         the last text.
3254
3255 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3256
3257         * top.c (print_gdb_version): Update Copyright year in version
3258         message.
3259
3260 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3261
3262         Update copyright year range in all GDB files.
3263
3264 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3265
3266         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3267
3268 For older changes see ChangeLog-2018.
3269 \f
3270 Local Variables:
3271 mode: change-log
3272 left-margin: 8
3273 fill-column: 74
3274 version-control: never
3275 coding: utf-8
3276 End:
3277