gdb/ChangeLog

   1 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
   2             Andrew Burgess  <andrew.burgess@embecosm.com>
   3
   4         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
   5         for nested static variables when searchin VAR_DOMAIN.
   6         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
   7         global scope, update comment.
   8         (add_partial_subprogram): Call add_partial_subprogram recursively
   9         for nested subroutines when processinng Fortran.
  10         (load_partial_dies): Process the child entities of a subprogram
  11         when processing Fortran.
  12         (partial_die_parent_scope): Handle building scope
  13         for Fortran nested functions.
  14         (process_die): Record that nested functions have a scope.
  15         (new_symbol): Always record Fortran subprograms on the global
  16         symbol list.
  17         (determine_prefix): How to build the prefix for Fortran
  18         subprograms.
  19
  20 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  21
  22         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
  23         have just sent the thread a SIGSTOP and are waiting for it to
  24         arrive.
  25
  26 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * btrace.c (btrace_add_pc): Remove whitespace before the template
  29         parameter in 'std::vector <...>'.
  30         (parse_xml_btrace_block): Likewise.
  31         (btrace_maint_decode_pt): Likewise.
  32         (btrace_maint_update_packets): Likewise.
  33         (btrace_maint_print_packets): Likewise.
  34         * btrace.h (struct btrace_maint_info): Likewise.
  35         * dwarf2read.c (struct type_unit_group): Likewise.
  36         (build_type_psymtabs_reader): Likewise.
  37         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  38         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  39         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  40
  41 2019-10-03  Tom de Vries  <tdevries@suse.de>
  42
  43         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  44         the first line of the help text for set/show style metadata.
  45
  46 2019-10-02  Tom Tromey  <tromey@adacore.com>
  47
  48         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
  49         * gdbsupport/common-inferior.c: New file.
  50         * infcmd.c (startup_with_shell): Don't define.
  51         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  52         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  53         * inferior.h (startup_with_shell): Don't declare.
  54
  55 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  56
  57         * gdbsupport/gdb_assert.h: Include errors.h.
  58         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  59
  60 2019-10-02  Tom Tromey  <tromey@adacore.com>
  61
  62         * NEWS: Add $_ada_exception entry.
  63         * ada-lang.c (struct ada_catchpoint): Add constructor.
  64         <m_kind>: New member.
  65         (allocate_location_exception, re_set_exception): Remove
  66         "ex" parameter.
  67         (should_stop_exception): Compute $_ada_exception.
  68         (check_status_exception, print_it_exception)
  69         (print_one_exception, print_mention_exception): Remove
  70         "ex" parameter.
  71         (allocate_location_catch_exception, re_set_catch_exception)
  72         (check_status_exception, print_it_catch_exception)
  73         (print_one_catch_exception, print_mention_catch_exception)
  74         (print_recreate_catch_exception)
  75         (allocate_location_catch_exception_unhandled)
  76         (re_set_catch_exception_unhandled)
  77         (check_status_exception, print_it_catch_exception_unhandled)
  78         (print_one_catch_exception_unhandled)
  79         (print_mention_catch_exception_unhandled)
  80         (print_recreate_catch_exception_unhandled)
  81         (allocate_location_catch_assert, re_set_catch_assert)
  82         (check_status_assert, print_it_catch_assert)
  83         (print_one_catch_assert, print_mention_catch_assert)
  84         (print_recreate_catch_assert)
  85         (allocate_location_catch_handlers, re_set_catch_handlers)
  86         (check_status_handlers, print_it_catch_handlers)
  87         (print_one_catch_handlers, print_mention_catch_handlers)
  88         (print_recreate_catch_handlers): Remove.
  89         (create_ada_exception_catchpoint): Update.
  90         (initialize_ada_catchpoint_ops): Update.
  91
  92 2019-10-02  Tom Tromey  <tromey@adacore.com>
  93
  94         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
  95         (create_excep_cond_exprs): Simplify exception string computation.
  96         (ada_exception_catchpoint_cond_string): Likewise.
  97
  98 2019-10-02  Tom Tromey  <tromey@adacore.com>
  99
 100         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 101         * ada-lang.c (lesseq_defined_than): Handle
 102         LOC_STATIC.
 103         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 104         parameter.
 105         (dwarf2_has_info): Likewise.
 106         (new_symbol): Set maybe_copied on symbol when
 107         appropriate.
 108         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 109         parameter.
 110         <can_copy>: New member.
 111         * elfread.c (record_minimal_symbol): Set maybe_copied
 112         on symbol when appropriate.
 113         (elf_symfile_read): Update call to dwarf2_has_info.
 114         * minsyms.c (lookup_minimal_symbol_linkage): New
 115         function.
 116         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 117         * symtab.c (get_symbol_address, get_msymbol_address):
 118         New functions.
 119         * symtab.h (get_symbol_address, get_msymbol_address):
 120         Declare.
 121         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 122         maybe_copied.
 123         (struct symbol, struct minimal_symbol) <maybe_copied>:
 124         New member.
 125
 126 2019-10-02  Tom Tromey  <tromey@adacore.com>
 127
 128         * source.c (struct current_source_location): New.
 129         (current_source_key): New global.
 130         (current_source_symtab, current_source_line)
 131         (current_source_pspace): Remove.
 132         (get_source_location): New function.
 133         (get_current_source_symtab_and_line)
 134         (set_default_source_symtab_and_line)
 135         (set_current_source_symtab_and_line)
 136         (clear_current_source_symtab_and_line, select_source_symtab)
 137         (info_source_command, print_source_lines_base)
 138         (info_line_command, search_command_helper, _initialize_source):
 139         Update.
 140
 141 2019-10-02  Tom Tromey  <tromey@adacore.com>
 142
 143         * source.c (select_source_symtab): Don't call
 144         decode_line_with_current_source.
 145
 146 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 147
 148         * symtab.c (lookup_global_symbol): Search global block.
 149
 150 2019-10-02  Tom Tromey  <tromey@adacore.com>
 151
 152         * coffread.c (process_coff_symbol): Update.
 153         * dwarf2read.c (var_decode_location, new_symbol): Update.
 154         * mdebugread.c (parse_symbol): Update.
 155         * objfiles.c (relocate_one_symbol): Update.
 156         * stabsread.c (define_symbol, fix_common_block)
 157         (scan_file_globals): Update.
 158         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 159         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 160         * xcoffread.c (process_xcoff_symbol): Update.
 161
 162 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 163
 164         * MAINTAINERS: Update my email address.
 165
 166 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 169         std::vector.
 170         (build_type_psymtabs_reader): Update for std::vector.
 171         (build_type_psymtab_dependencies): Likewise.
 172         * dwarf2read.h: Remove use of DEF_VEC_P.
 173         (typedef sig_type_ptr): Delete.
 174
 175 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 178         to std::vector.
 179         (btrace_maint_decode_pt): Likewise, and move allocation of the
 180         vector outside of the loop.
 181         (btrace_maint_update_packets): Update to handle change from VEC to
 182         std::vector.
 183         (btrace_maint_print_packets): Likewise.
 184         (maint_info_btrace_cmd): Likewise.
 185         * btrace.h: Remove use of DEF_VEC_O.
 186         (typedef btrace_pt_packet_s): Delete.
 187         (struct btrace_maint_info) <packets>: Change fromm VEC to
 188         std::vector.
 189         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 190
 191 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 192
 193         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 194         make accesses into the vector constant references.
 195         (btrace_add_pc): Update for std::vector.
 196         (btrace_stitch_bts): Likewise.
 197         (parse_xml_btrace_block): Likewise.
 198         (btrace_maint_update_packets): Likewise.
 199         (btrace_maint_print_packets): Likewise.
 200         (maint_info_btrace_cmd): Likewise.
 201         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 202         std::vector.
 203         (btrace_data::empty): Likewise.
 204         (btrace_data_append): Likewise.
 205         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 206         (typedef btrace_block_s): Delete.
 207         (struct btrace_block): Add constructor.
 208         (struct btrace_data_bts) <blocks>: Change to std::vector.
 209         * nat/linux-btrace.c (perf_event_read_bts): Update for
 210         std::vector.
 211         (linux_read_bts): Likewise.
 212
 213 2019-10-01  Tom Tromey  <tom@tromey.com>
 214
 215         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 216
 217 2019-10-01  Tom Tromey  <tom@tromey.com>
 218
 219         * stack.c (print_frame, info_frame_command_core): Use
 220         styled_string.
 221         * linux-thread-db.c (try_thread_db_load_1)
 222         (try_thread_db_load_from_pdir_1): Use styled_string.
 223         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 224         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 225         (maybe_print_unsupported_script_warning)
 226         (maybe_print_script_not_found_warning): Use styled_string.
 227         * ada-lang.c (user_select_syms): Use styled_string.
 228
 229 2019-10-01  Tom Tromey  <tom@tromey.com>
 230
 231         * p-lang.c (pascal_printstr): Use metadata style.
 232         * value.c (show_convenience): Use metadata style.
 233         * valprint.c (valprint_check_validity, val_print_optimized_out)
 234         (val_print_not_saved, val_print_unavailable)
 235         (val_print_invalid_address, generic_val_print, val_print)
 236         (value_check_printable, val_print_array_elements): Use metadata
 237         style.
 238         * ui-out.h (class ui_out) <field_fmt>: New overload.
 239         <do_field_fmt>: Add style parameter.
 240         * ui-out.c (ui_out::field_fmt): New overload.
 241         * typeprint.c (type_print_unknown_return_type)
 242         (val_print_not_allocated, val_print_not_associated): Use metadata
 243         style.
 244         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 245         parameter.
 246         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 247         * tracepoint.c (tvariables_info_1): Use metadata style.
 248         * stack.c (print_frame_arg, print_frame_info, print_frame)
 249         (info_frame_command_core): Use metadata style.
 250         * skip.c (info_skip_command): Use metadata style.
 251         * rust-lang.c (rust_print_enum): Use metadata style.
 252         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 253         metadata style.
 254         * python/py-framefilter.c (py_print_single_arg): Use metadata
 255         style.
 256         * printcmd.c (do_one_display, print_variable_and_value): Use
 257         metadata style.
 258         * p-valprint.c (pascal_val_print)
 259         (pascal_object_print_value_fields): Use metadata style.
 260         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 261         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 262         parameter.
 263         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 264         * m2-valprint.c (m2_print_long_set): Use metadata style.
 265         * m2-typeprint.c (m2_print_type): Use metadata style.
 266         * infcmd.c (print_return_value_1): Use metadata style.
 267         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 268         * f-valprint.c (info_common_command_for_block): Use metadata
 269         style.
 270         * f-typeprint.c (f_type_print_base): Use metadata style.
 271         * expprint.c (print_subexp_standard): Use metadata style.
 272         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 273         * cli/cli-style.h (class cli_style_option): Add constructor.
 274         (metadata_style): Declare.
 275         * cli/cli-style.c (metadata_style): New global.
 276         (_initialize_cli_style): Register metadata style.
 277         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 278         parameter.
 279         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 280         * c-typeprint.c (c_type_print_base_struct_union)
 281         (c_type_print_base_1): Use metadata style.
 282         * breakpoint.c (watchpoint_value_print)
 283         (print_one_breakpoint_location): Use metadata style.
 284         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 285         style.
 286         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 287         style.
 288         * ada-valprint.c (val_print_packed_array_elements, printstr)
 289         (print_field_values, ada_val_print_ref, ada_val_print): Use
 290         metadata style.
 291         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 292         style.
 293         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 294         style.
 295         * ada-lang.c (user_select_syms): Use metadata style.
 296
 297 2019-10-01  Tom Tromey  <tom@tromey.com>
 298
 299         * cli/cli-cmds.c (pwd_command): Style output.
 300
 301 2019-10-01  Pedro Alves  <palves@redhat.com>
 302             Tom Tromey  <tom@tromey.com>
 303
 304         * symtab.c (print_symbol_info): Use %ps.
 305         (print_msymbol_info): Use %ps.
 306         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 307         * printcmd.c (print_variable_and_value): Use %ps.
 308         * macrocmd.c (show_pp_source_pos): Use %ps.
 309         * infrun.c (print_exited_reason): Use ui_out::message.
 310         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 311         (describe_other_breakpoints): Use ui_out::message and new
 312         formats.
 313         (say_where): Use new formats.
 314         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 315         and new formats.
 316
 317 2019-10-01  Pedro Alves  <palves@redhat.com>
 318             Tom Tromey  <tom@tromey.com>
 319
 320         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 321         (test_gdb_formats): New function.
 322         (run_tests): Call it.
 323         (test_format_specifier): Update.
 324         * utils.h (fputs_filtered): Update comment.
 325         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 326         (fputs_styled_unfiltered): Declare.
 327         * utils.c (fputs_styled_unfiltered): New function.
 328         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 329         (vfprintf_filtered): Update.
 330         (vfprintf_unfiltered, vprintf_filtered): Update.
 331         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 332         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 333         disallow_ui_out_field>: New constants.
 334         (enum class field_kind): New.
 335         (struct base_field_s, struct signed_field_s): New.
 336         (signed_field): New function.
 337         (struct string_field_s): New.
 338         (string_field): New function.
 339         (struct styled_string_s): New.
 340         (styled_string): New function.
 341         (class ui_out) <message>: Add comment.
 342         <vmessage, call_do_message>: New methods.
 343         <do_message>: Add style parameter.
 344         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 345         methods.
 346         (ui_out::message): Rewrite.
 347         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 348         parameter.
 349         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 350         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 351         gdb_extensions parameter.
 352         (class format_piece): Add parameter to constructor.
 353         (n_int_args): New field.
 354         * gdbsupport/format.c (format_pieces::format_pieces): Add
 355         gdb_extensions parameter.  Handle '*'.
 356         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 357         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 358         vfprintf_styled_no_gdbfmt.
 359         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 360         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 361         unfiltered output.
 362         * ui-style.h (struct ui_file_style) <ptr>: New method.
 363
 364 2019-10-01  Tom Tromey  <tom@tromey.com>
 365
 366         * unittests/format_pieces-selftests.c: Update.  Add final format.
 367         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 368         empty literal pieces.
 369
 370 2019-10-01  Tom Tromey  <tom@tromey.com>
 371
 372         * ui-out.h (enum class ui_out_style_kind): Remove.
 373         (class ui_out) <field_string, field_stsream, do_field_string>:
 374         Change type of "style".
 375         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 376         (ui_out::field_string): Update.
 377         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 378         of "style".
 379         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 380         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 381         * stack.c (print_frame_arg, print_frame_info, print_frame):
 382         Update.
 383         * source.c (print_source_lines_base): Update.
 384         * solib.c (info_sharedlibrary_command): Update.
 385         * skip.c (info_skip_command): Update.
 386         * record-btrace.c (btrace_call_history_src_line)
 387         (btrace_call_history): Update.
 388         * python/py-framefilter.c (py_print_frame): Update.
 389         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 390         "style".
 391         * mi/mi-out.c (mi_ui_out::do_table_header)
 392         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 393         (mi_ui_out::do_field_string): Update.
 394         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 395         Update.
 396         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 397         "style".
 398         * cli-out.c (cli_ui_out::do_table_header)
 399         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 400         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 401         (cli_ui_out::do_field_fmt): Update.
 402         * breakpoint.c (print_breakpoint_location): Update.
 403         (update_static_tracepoint): Update.
 404
 405 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 406
 407         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 408         conversion of gdb_datadir.
 409         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 410         remove not needed c_str ().
 411
 412 2019-09-30  Ali Tamur <tamur@google.com>
 413
 414         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 415         (dwarf2_string_attr): Likewise.
 416
 417 2019-09-30  Ali Tamur <tamur@google.com>
 418
 419         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 420         (process_full_type_unit): Likewise.
 421         (dump_die_shallow): Likewise.
 422         (cu_debug_loc_section): Likewise.
 423
 424 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 425
 426         * minsyms.c (compare_minimal_symbols): Rename to...
 427         (minimal_symbol_is_less_than): ...this, and adjust to STL
 428         conventions (return bool, take arguments as references)
 429         (minimal_symbol_reader::install): Call std::sort instead
 430         of qsort.
 431
 432 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 433
 434         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 435         hash and why.
 436         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 437         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 438
 439 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 440
 441         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 442         * psympriv.h (add_psymbol_to_list): Move comment here and update
 443         it.
 444
 445 2019-09-29  Tom de Vries  <tdevries@suse.de>
 446
 447         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 448         Use $tmpdir/$(basename "$output_file").dwz instead of
 449         "${output_file}.dwz".
 450
 451 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 452
 453         PR gdb/25045
 454         * hppa-linux-nat.c: Include gdbarch.h.
 455
 456 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 457
 458         * blockframe.c (find_pc_partial_function): Change return type to bool.
 459         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 460         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 461         (stub_gnu_ifunc_resolve_name): Likewise.
 462         * symtab.c (compare_filenames_for_search): Likewise.
 463         (compare_glob_filenames_for_search): Likewise.
 464         (matching_obj_sections): Likewise.
 465         (symbol_matches_domain): Likewise.
 466         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 467         (find_line_pc): Change return type to bool.
 468         (find_line_pc_range): Likewise.
 469         (producer_is_realview): Likewise.
 470         * symtab.h (symbol_matches_domain): Likewise.
 471         (find_pc_partial_function): Likewise.
 472         (find_pc_line_pc_range): Likewise.
 473         (in_gnu_ifunc_stub): Likewise.
 474         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 475         (find_line_pc): Likewise.
 476         (find_line_pc_range): Likewise.
 477         (matching_obj_sections): Likewise.
 478         (find_line_symtab): Change out parameter to bool.
 479         (producer_is_realview): Change return type to bool.
 480         (compare_filenames_for_search): Likewise.
 481         (compare_glob_filenames_for_search): Likewise.
 482
 483 2019-09-26  Tom Tromey  <tom@tromey.com>
 484
 485         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 486         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 487         * gdb_usleep.h: Remove.
 488         * gdb_usleep.c: Remove.
 489         * utils.c: Don't include gdb_usleep.h.
 490
 491 2019-09-26  Tom Tromey  <tromey@adacore.com>
 492
 493         * python/py-type.c (type_to_type_object): Call check_typedef
 494         for stub types.
 495
 496 2019-09-26  Tom Tromey  <tom@tromey.com>
 497
 498         * utils.h (initialize_utils): Don't declare.
 499         * top.c (gdb_init): Don't call initialize_utils.
 500         * utils.c (initialize_utils): Remove.  Move contents...
 501         (_initialize_utils): ... here.
 502
 503 2019-09-25  Tom Tromey  <tom@tromey.com>
 504
 505         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 506         * utils.h (make_hex_string): Don't declare.
 507         * utils.c (make_hex_string): Remove.
 508
 509 2019-09-24  Tom de Vries  <tdevries@suse.de>
 510
 511         PR gdb/23815
 512         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 513         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 514
 515 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 516
 517         * NEWS: Mention new simulator port for PRU.
 518
 519 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * ada-exp.y (write_object_remaining): Update.
 522         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 523         and eliminate the static buffer.
 524         (ada_decode_symbol): Update.
 525         (ada_la_decode): Update.
 526         (ada_sniff_from_mangled_name): Update.
 527         (is_valid_name_for_wild_match): Update.
 528         (ada_lookup_name_info::matches): Update and simplify.
 529         (name_matches_regex): Update.
 530         (ada_add_global_exceptions): Update.
 531         * ada-lang.h (ada_decode): Update signature.
 532         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 533         * dwarf-index-write.c (debug_names::insert): Update.
 534
 535 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 536
 537         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 538         formatting.
 539
 540 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 541
 542         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 543         Change "nonzero" to "true" in documentation.
 544
 545 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 546
 547         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 548         (_initialize_darwin_solib): Don't set
 549         darwin_so_ops.lookup_lib_global_symbol.
 550         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 551         set_gdbarch_iterate_over_objfiles_in_search_order.
 552         (elf_lookup_lib_symbol): Rename to...
 553         (svr4_iterate_over_objfiles_in_search_order): this, and update
 554         to iterate semantics.
 555         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 556         * solib.c (solib_global_lookup): Remove.
 557         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 558         (solib_global_lookup): Remove.
 559         * symtab.c (lookup_global_or_static_symbol): Remove call to
 560         solib_global_lookup.
 561
 562 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 563
 564         * NEWS: Move entries about default MI version now being
 565         version 3, and about the GDB/MI fix for multi-location
 566         breakpoints to the "since GDB 8.3" section.
 567
 568 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 569
 570         GDB 8.3.1 released.
 571
 572 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 573
 574         * NEWS: Mention that Cell/B.E. debugging support was removed.
 575         * MAINTAINERS: Remove spu target.
 576
 577         * config/djgpp/fnchange.lst: Remove entries for removed files.
 578
 579         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 580         spu-multiarch.o, and spu-tdep.o.
 581         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 582         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 583         spu-multiarch.c, and spu-tdep.c.
 584         * spu-linux-nat.c: Remove file.
 585         * spu-multiarch.c: Remove file.
 586         * spu-tdep.c: Remove file.
 587         * spu-tdep.h: Remove file.
 588         * solib-spu.c: Remove file.
 589         * solib-spu.h: Remove file.
 590
 591         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 592         * configure.nat (spu-linux): Remove.
 593         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 594         solib-multiarch.o from gdb_target_obs.
 595         (spu*-*-*): Remove.
 596
 597         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 598         feature flag.
 599         (ppc_linux_no_features): Update.
 600         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 601         Cell/B.E. support.
 602         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 603         (tdesc_powerpc_cell64l): Likewise.
 604         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 605         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 606         Cell/B.E. support.
 607         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 608         Do not include "features/rs6000/powerpc-cell32l.c" or
 609         "features/rs6000/powerpc-cell64l.c".
 610         (ppc_linux_spu_section): Remove.
 611         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 612         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 613         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 614         (ppc_linux_spe_context_lookup): Remove.
 615         (ppc_linux_spe_context_inferior_created): Remove.
 616         (ppc_linux_spe_context_solib_loaded): Remove.
 617         (ppc_linux_spe_context_solib_unloaded): Remove.
 618         (ppc_linux_spe_context): Remove.
 619         (struct ppu2spu_cache): Remove.
 620         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 621         (struct ppu2spu_data): Remove.
 622         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 623         ppu2spu_unwind): Remove.
 624         (ppc_linux_init_abi): Remove Cell/B.E. support.
 625         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 626
 627         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 628         (rs6000/powerpc-cell64l-expedite): Likewise
 629         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 630         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 631         rs6000/powerpc-cell64l.xml.
 632         * features/rs6000/powerpc-cell32l.xml: Remove.
 633         * features/rs6000/powerpc-cell64l.xml: Likewise.
 634         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 635         * features/rs6000/powerpc-cell64l.c: Likewise.
 636         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 637         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 638         * regformats/reg-spu.dat: Remove.
 639
 640         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 641         * corelow.c (struct spuid_list): Remove.
 642         (add_to_spuid_list): Remove.
 643         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 644         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 645         (remote_protocol_features): Remove associated entries.
 646         (_initialize_remote): No longer initialize them.
 647         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 648         * linux-nat.c (SPUFS_MAGIC): Remove.
 649         (linux_proc_xfer_spu): Remove.
 650         (spu_enumerate_spu_ids): Remove.
 651         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 652         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 653         (linux_make_corefile_notes): No longer call it.
 654
 655         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 656         (cooked_write_test): Likewise.
 657
 658 2019-09-20  Tom Tromey  <tom@tromey.com>
 659
 660         * NEWS: Mention case-sensitivity of TUI commands.
 661         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 662         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 663         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 664
 665 2019-09-20  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-source.c (tui_source_window::set_contents): Use
 668         make_unique_xstrdup.
 669         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 670         make_unique_xstrdup.
 671
 672 2019-09-20  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-data.c: Remove separator comments.
 675         * tui/tui-layout.c: Remove separator comments.
 676         * tui/tui-win.c: Remove separator comments.
 677         * tui/tui-wingeneral.c: Remove separator comments.
 678
 679 2019-09-20  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui.h (strcat_to_buf): Don't declare.
 682         * tui/tui.c (strcat_to_buf): Remove.
 683
 684 2019-09-20  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 687         from "fullname".
 688         * tui/tui-source.c (tui_source_window::set_contents)
 689         (tui_source_window::location_matches_p)
 690         (tui_source_window::maybe_update): Update.
 691
 692 2019-09-20  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 695         Update.
 696         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 697         prefix.
 698         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 699         (tui_data_window::line_from_reg_element_no)
 700         (tui_data_window::first_reg_element_no_inline)
 701         (tui_data_window::show_registers)
 702         (tui_data_window::show_register_group)
 703         (tui_data_window::display_registers_from)
 704         (tui_data_window::display_registers_from_line)
 705         (tui_data_window::first_data_item_displayed)
 706         (tui_data_window::delete_data_content_windows)
 707         (tui_data_window::erase_data_content)
 708         (tui_data_window::do_scroll_vertical)
 709         (tui_data_window::refresh_window)
 710         (tui_data_window::check_register_values): Update.
 711
 712 2019-09-20  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 715         (struct tui_locator_window) <full_name, proc_name>: Now
 716         std::string.
 717         * tui/tui-stack.c (tui_locator_window::make_status_line)
 718         (tui_locator_window::set_locator_fullname)
 719         (tui_locator_window::set_locator_info): Update.
 720         * tui/tui-source.c (tui_source_window::set_contents)
 721         (tui_source_window::showing_source_p): Update.
 722
 723 2019-09-20  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 726         Don't call tui_locator_win_info_ptr.
 727
 728 2019-09-20  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 731
 732 2019-09-20  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 735         height for locator.
 736         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 737         * tui/tui-layout.c (show_source_disasm_command, show_data)
 738         (show_source_or_disasm_and_command): Use 1 as height for locator.
 739
 740 2019-09-20  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui.c (tui_enable): Update.
 743         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 744         Update.
 745         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 746         Update.
 747         * tui/tui-data.c (win_resized): Now bool.
 748         (tui_win_resized): Return bool.
 749         (tui_set_win_resized_to): Accept a bool.
 750
 751 2019-09-20  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 754         Change type of "refresh_values_only".
 755         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 756         type of "refresh_values_only".
 757
 758 2019-09-20  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 761         std::string.
 762         (tui_disassemble): Add "pos" parameter.
 763         (tui_disasm_window::set_contents): Simplify.
 764
 765 2019-09-20  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-winsource.h (struct tui_source_window_base)
 768         <show_source_content>: Now private.
 769         * tui/tui-winsource.c
 770         (tui_source_window_base::show_source_content): Don't handle empty
 771         content case.
 772
 773 2019-09-20  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-layout.c (show_source_disasm_command)
 776         (show_source_or_disasm_and_command): Don't call
 777         show_source_content.
 778
 779 2019-09-20  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 782         Declare.
 783         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 784         from tui_make_status_line.
 785         (tui_locator_window::rerender): Update.
 786
 787 2019-09-20  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 790         (tui_locator_window::rerender): Update.
 791
 792 2019-09-20  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-winsource.h (struct tui_source_window_base)
 795         <~tui_source_window_base>: Don't declare.
 796         <fullname>: Remove.
 797         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 798         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 799         member.
 800         * tui/tui-source.c (tui_source_window::set_contents): Update.
 801         (tui_source_window::location_matches_p)
 802         (tui_source_window::maybe_update): Update.
 803
 804 2019-09-20  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-winsource.h (~tui_source_element): Remove.
 807         (tui_source_element): Update.
 808         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 809         * tui/tui-winsource.c (tui_show_source_line): Update.
 810         * tui/tui-source.c (tui_source_window::set_contents): Update.
 811         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 812
 813 2019-09-20  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 816         declare.
 817         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 818         tui_clear_source_windows_detail.
 819         * tui/tui-winsource.h (struct tui_source_window_base)
 820         <clear_detail>: Don't declare.
 821         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 822         Remove.
 823         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 824
 825 2019-09-20  Tom Tromey  <tromey@adacore.com>
 826
 827         PR ada/24919:
 828         * block.c (contained_in): Fix final return value.
 829
 830 2019-09-20  Alan Modra  <amodra@gmail.com>
 831
 832         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 833         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 834         (read_indirect_string_from_dwz): Use bfd accessor.
 835         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 836         * machoread.c (macho_symfile_read_all_oso): Likewise.
 837         * solib.c (solib_bfd_open): Likewise.
 838
 839 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 840
 841         * eval.c: Move declaration of overload_resolution to...
 842         * value.h: ...here.
 843
 844 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 845
 846         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 847         * arm-linux-tdep.c: Likewise.
 848         * arm-nbsd-nat.c: Likewise.
 849         * arm-tdep.h: Declare arm_apcs_32.
 850         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 851
 852 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 853
 854         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 855         * dwarf2read.h: Declare dwarf_always_disassemble.
 856
 857 2019-09-19  Tom de Vries  <tdevries@suse.de>
 858
 859         PR gdb/25009
 860         * source-cache.c (source_cache::ensure): Catch exception thrown during
 861         construction of the highlighter.
 862
 863 2019-09-18  Alan Modra  <amodra@gmail.com>
 864
 865         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 866         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 867         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 868         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 869         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 870         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 871         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 872         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 873         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 874         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 875         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 876         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 877         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 878         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 879         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 880         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 881         * mi/mi-interp.c: Update throughout for bfd section macro and
 882         function changes.
 883         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 884         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 885
 886 2019-09-18  Tom Tromey  <tom@tromey.com>
 887
 888         * NEWS: Add entry.
 889         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 890         call rl_initialize.
 891         (tui_enable): Do not call rl_initialize.
 892
 893 2019-09-18  Christian Groessler  <chris@groessler.org>
 894
 895         * alpha-linux-nat.c: Include gdbarch.h.
 896
 897 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 898
 899         * ui-file.c: Include cli/cli-style.h.
 900         (term_cli_styling): Remove cli_styling declaration.
 901
 902 2019-09-18  Alan Modra  <amodra@gmail.com>
 903
 904         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 905         to bfd_asymbol_section.
 906
 907 2019-09-18  Alan Modra  <amodra@gmail.com>
 908
 909         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 910         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 911         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 912
 913 2019-09-18  Alan Modra  <amodra@gmail.com>
 914
 915         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 916         * spu-linux-nat.c (spu_bfd_open): Likewise.
 917
 918 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 919
 920         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 921         to bool to match definition in dwarf2read.c.
 922
 923 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 924
 925         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 926         (print_signatures): Likewise.
 927         (trust_pad_over_xvs): Likewise.
 928         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 929         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 930         * arm-linux-nat.c (arm_apcs_32): Likewise.
 931         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 932         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 933         * arm-tdep.c (arm_debug): Likewise.
 934         (arm_apcs_32): Likewise.
 935         * auto-load.c (debug_auto_load): Likewise.
 936         (auto_load_gdb_scripts): Likewise.
 937         (global_auto_load): Likewise.
 938         (auto_load_local_gdbinit): Likewise.
 939         (auto_load_local_gdbinit_loaded): Likewise.
 940         * auto-load.h (global_auto_load): Likewise.
 941         (auto_load_local_gdbinit): Likewise.
 942         (auto_load_local_gdbinit_loaded): Likewise.
 943         * breakpoint.c (disconnected_dprintf): Likewise.
 944         (breakpoint_proceeded): Likewise.
 945         (automatic_hardware_breakpoints): Likewise.
 946         (always_inserted_mode): Likewise.
 947         (target_exact_watchpoints): Likewise.
 948         (_initialize_breakpoint): Update.
 949         * breakpoint.h (target_exact_watchpoints): Change to bool.
 950         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 951         * cli/cli-cmds.c (trace_commands): Likewise.
 952         * cli/cli-cmds.h (trace_commands): Likewise.
 953         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 954         to bool*.
 955         * cli/cli-logging.c (logging_overwrite): Change to bool.
 956         (logging_redirect): Likewise.
 957         (debug_redirect): Likewise.
 958         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 959         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 960         to bool.
 961         <boolean_option_def>: Update.
 962         (struct flag_option_def): Change default type of Context to bool
 963         from int.
 964         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 965         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 966         (get_setshow_command_value_string): Likewise.
 967         * cli/cli-style.c (cli_styling): Change to bool.
 968         (source_styling): Likewise.
 969         * cli/cli-style.h (source_styling): Likewise.
 970         (cli_styling): Likewise.
 971         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 972         to bool.
 973         * command.h (var_types): Update comment.
 974         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 975         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 976         bool.
 977         (debug_compile_cplus_scopes): Likewise.
 978         * compile/compile-internal.h (compile_debug): Likewise.
 979         * compile/compile.c (compile_debug): Likewise.
 980         (struct compile_options) <raw>: Likewise.
 981         * cp-support.c (catch_demangler_crashes): Likewise.
 982         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 983         (usr_cmd_cris_dwarf2_cfi): Likewise.
 984         * csky-tdep.c (csky_debug): Likewise.
 985         * darwin-nat.c (enable_mach_exceptions): Likewise.
 986         * dcache.c (dcache_enabled_p): Likewise.
 987         * defs.h (info_verbose): Likewise.
 988         * demangle.c (demangle): Likewise.
 989         (asm_demangle): Likewise.
 990         * dwarf-index-cache.c (debug_index_cache): Likewise.
 991         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 992         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 993         * dwarf2read.c (check_physname): Likewise.
 994         (use_deprecated_index_sections): Likewise.
 995         (dwarf_always_disassemble): Likewise.
 996         * eval.c (overload_resolution): Likewise.
 997         * event-top.c (set_editing_cmd_var): Likewise.
 998         (exec_done_display_p): Likewise.
 999         * event-top.h (set_editing_cmd_var): Likewise.
1000         (exec_done_display_p): Likewise.
1001         * exec.c (write_files): Likewise.
1002         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1003         (debug_fbsd_nat): Likewise.
1004         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1005         Likewise.
1006         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1007         <backtrace_past_entry> Likewise.
1008         * gdb-demangle.h (demangle): Likewise.
1009         (asm_demangle): Likewise.
1010         * gdb_bfd.c (bfd_sharing): Likewise.
1011         * gdbcore.h (write_files): Likewise.
1012         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1013         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1014         * gdbthread.h (print_thread_events): Likewise.
1015         * gdbtypes.c (opaque_type_resolution): Likewise.
1016         (strict_type_checking): Likewise.
1017         * gnu-nat.c (gnu_debug_flag): Likewise.
1018         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1019         * guile/scm-param.c (pascm_variable): Add boolval.
1020         (add_setshow_generic): Update.
1021         (pascm_param_value): Update.
1022         (pascm_set_param_value_x): Update.
1023         * hppa-tdep.c (hppa_debug): Change to bool..
1024         * infcall.c (may_call_functions_p): Likewise.
1025         (coerce_float_to_double_p): Likewise.
1026         (unwind_on_signal_p): Likewise.
1027         (unwind_on_terminating_exception_p): Likewise.
1028         * infcmd.c (startup_with_shell): Likewise.
1029         * inferior.c (print_inferior_events): Likewise.
1030         * inferior.h (startup_with_shell): Likewise.
1031         (print_inferior_events): Likewise.
1032         * infrun.c (step_stop_if_no_debug): Likewise.
1033         (detach_fork): Likewise.
1034         (debug_displaced): Likewise.
1035         (disable_randomization): Likewise.
1036         (non_stop): Likewise.
1037         (non_stop_1): Likewise.
1038         (observer_mode): Likewise.
1039         (observer_mode_1): Likewise.
1040         (set_observer_mode): Update.
1041         (sched_multi): Change to bool.
1042         * infrun.h (debug_displaced): Likewise.
1043         (sched_multi): Likewise.
1044         (step_stop_if_no_debug): Likewise.
1045         (non_stop): Likewise.
1046         (disable_randomization): Likewise.
1047         * linux-tdep.c (use_coredump_filter): Likewise.
1048         (dump_excluded_mappings): Likewise.
1049         * linux-thread-db.c (auto_load_thread_db): Likewise.
1050         (check_thread_db_on_load): Likewise.
1051         * main.c (captured_main_1): Update.
1052         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1053         xx2_opt, boolean_opt>: Change to bool.
1054         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1055         * maint.c (maintenance_profile_p): Likewise.
1056         (per_command_time): Likewise.
1057         (per_command_space): Likewise.
1058         (per_command_symtab): Likewise.
1059         * memattr.c (inaccessible_by_default): Likewise.
1060         * mi/mi-main.c (mi_async): Likewise.
1061         (mi_async_1): Likewise.
1062         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1063         * nat/fork-inferior.h (startup_with_shell): Likewise.
1064         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1065         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1066         * nios2-tdep.c (nios2_debug): Likewise.
1067         * or1k-tdep.c (or1k_debug): Likewise.
1068         * parse.c (parser_debug): Likewise.
1069         * parser-defs.h (parser_debug): Likewise.
1070         * printcmd.c (print_symbol_filename): Likewise.
1071         * proc-api.c (procfs_trace): Likewise.
1072         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1073         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1074         (set_parameter_value): Update.
1075         (add_setshow_generic): Update.
1076         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1077         to bool*.
1078         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1079         int*.
1080         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1081         * record-btrace.c (record_btrace_target::store_registers): Update.
1082         * record-full.c (record_full_memory_query): Change to bool.
1083         (record_full_stop_at_limit): Likewise.
1084         * record-full.h (record_full_memory_query): Likewise.
1085         * remote-notif.c (notif_debug): Likewise.
1086         * remote-notif.h (notif_debug): Likewise.
1087         * remote.c (use_range_stepping): Likewise.
1088         (interrupt_on_connect): Likewise.
1089         (remote_break): Likewise.
1090         * ser-tcp.c (tcp_auto_retry): Likewise.
1091         * ser-unix.c (serial_hwflow): Likewise.
1092         * skip.c (debug_skip): Likewise.
1093         * solib-aix.c (solib_aix_debug): Likewise.
1094         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1095         (spu_auto_flush_cache_p): Likewise.
1096         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1097         Likewise.
1098         (struct info_print_options) <quiet>: Likewise.
1099         * symfile-debug.c (debug_symfile): Likewise.
1100         * symfile.c (auto_solib_add): Likewise.
1101         (separate_debug_file_debug): Likewise.
1102         * symfile.h (auto_solib_add): Likewise.
1103         (separate_debug_file_debug): Likewise.
1104         * symtab.c (basenames_may_differ): Likewise.
1105         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1106         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1107         (struct info_types_options) <quiet>: Likewise.
1108         * symtab.h (demangle): Likewise.
1109         (basenames_may_differ): Likewise.
1110         * target-dcache.c (stack_cache_enabled_1): Likewise.
1111         (code_cache_enabled_1): Likewise.
1112         * target.c (trust_readonly): Likewise.
1113         (may_write_registers): Likewise.
1114         (may_write_memory): Likewise.
1115         (may_insert_breakpoints): Likewise.
1116         (may_insert_tracepoints): Likewise.
1117         (may_insert_fast_tracepoints): Likewise.
1118         (may_stop): Likewise.
1119         (auto_connect_native_target): Likewise.
1120         (target_stop_and_wait): Update.
1121         (target_async_permitted): Change to bool.
1122         (target_async_permitted_1): Likewise.
1123         (may_write_registers_1): Likewise.
1124         (may_write_memory_1): Likewise.
1125         (may_insert_breakpoints_1): Likewise.
1126         (may_insert_tracepoints_1): Likewise.
1127         (may_insert_fast_tracepoints_1): Likewise.
1128         (may_stop_1): Likewise.
1129         * target.h (target_async_permitted): Likewise.
1130         (may_write_registers): Likewise.
1131         (may_write_memory): Likewise.
1132         (may_insert_breakpoints): Likewise.
1133         (may_insert_tracepoints): Likewise.
1134         (may_insert_fast_tracepoints): Likewise.
1135         (may_stop): Likewise.
1136         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1137         (make_thread_apply_all_options_def_group): Change argument from int*
1138         to bool*.
1139         (thread_apply_all_command): Update.
1140         (print_thread_events): Change to bool.
1141         * top.c (confirm): Likewise.
1142         (command_editing_p): Likewise.
1143         (history_expansion_p): Likewise.
1144         (write_history_p): Likewise.
1145         (info_verbose): Likewise.
1146         * top.h (confirm): Likewise.
1147         (history_expansion_p): Likewise.
1148         * tracepoint.c (disconnected_tracing): Likewise.
1149         (circular_trace_buffer): Likewise.
1150         * typeprint.c (print_methods): Likewise.
1151         (print_typedefs): Likewise.
1152         * utils.c (debug_timestamp): Likewise.
1153         (sevenbit_strings): Likewise.
1154         (pagination_enabled): Likewise.
1155         * utils.h (sevenbit_strings): Likewise.
1156         (pagination_enabled): Likewise.
1157         * valops.c (overload_resolution): Likewise.
1158         * valprint.h (struct value_print_options) <prettyformat_arrays,
1159         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1160         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1161         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1162         Likewise.
1163         * windows-nat.c (new_console): Likewise.
1164         (cygwin_exceptions): Likewise.
1165         (new_group): Likewise.
1166         (debug_exec): Likewise.
1167         (debug_events): Likewise.
1168         (debug_memory): Likewise.
1169         (debug_exceptions): Likewise.
1170         (useshell): Likewise.
1171         * windows-tdep.c (maint_display_all_tib): Likewise.
1172         * xml-support.c (debug_xml): Likewise.
1173
1174 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1175
1176         * source.c (prepare_path_for_appending): New function.
1177         (openp): Make use of new function.
1178         (find_and_open_source): Search for the compilation directory and
1179         source file as a relative path beneath the directory search path.
1180
1181 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * source-cache.c (source_cache::get_line_charpos): Catch
1184         exceptions and return false, this matches the behaviour documented
1185         in the header file.
1186
1187 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1188
1189         * ada-tasks.c (info_task): Remove quoting of the task's name.
1190
1191 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * symfile.c (auto_solib_add): Replace comment with a reference
1194         to the header file.
1195
1196 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1197
1198         * NEWS: Mention that gdb can now be compiled with Python 3
1199         on Windows.
1200
1201 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * maint.c (maint_print_section_data::maint_print_section_data):
1204         Force use of 'float log10 (float)' by casting the argument to
1205         float.
1206
1207 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * maint.c: Add 'cmath' include.
1210         (struct maint_print_section_data): New structure.
1211         (print_section_index): New function.
1212         (print_bfd_section_info): Add header comment, small whitespace
1213         cleanup, and update to call new print_section_index function.
1214         (print_objfile_section_info): Likewise.
1215         (maint_obj_section_from_bfd_section): New function.
1216         (print_bfd_section_info_maybe_relocated): New function.
1217         (maintenance_info_sections): Add header comment, always use
1218         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1219
1220 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1223         inner scope, add check that the objfile has psymtabs before
1224         checking psymtabs_addrmap.
1225         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1226
1227 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1228
1229         * NEWS: Announce that Ada task names are now shown at more places,
1230         and between quotes (except in info task output).
1231         * gdb/ada-tasks.c (task_to_str): New function.
1232         (display_current_task_id): Call task_to_str.
1233         (task_command_1): Likewise.
1234         (print_ada_task_info): In non-mi mode, Properly align headers and data
1235         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1236
1237 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1238
1239         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1240         prstatus.pr_lwp.pr_info instead of making it up.
1241
1242 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1243
1244         * auto-load.c (auto_load_expand_dir_vars): Update.
1245         * defs.h (gdb_datadir): Change to std::string.
1246         (python_libdir): Likewise.
1247         (relocate_gdb_directory): Change return type to std::string.
1248         * guile/guile.c (gdbscm_data_directory): Update.
1249         (initialize_scheme_side): Update.
1250         * jit.c (jit_reader_dir): Change to std::string.
1251         (jit_reader_load_command): Update.
1252         * main.c (gdb_datadir): Change to std::string.
1253         (python_libdir): Likewise.
1254         (set_gdb_data_directory): Update.
1255         (relocate_path): Change to return std::string.
1256         (relocate_gdb_directory): Change to return std::string.
1257         (relocate_gdbinit_path_maybe_in_datadir): Update.
1258         (captured_main_1): Update.
1259         * python/python.c (do_start_initialization): Update.
1260         * top.c (show_gdb_datadir): Update.
1261         * xml-syscall.c (xml_init_syscalls_info): Update.
1262         (init_syscalls_info): Update.
1263
1264 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1265
1266         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1267         out of get_init_files.
1268         (get_init_files): Update.
1269
1270 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * main.c (get_init_files): Change to use std::string.
1273         (captured_main_1): Update.
1274         (print_gdb_help): Update.
1275
1276 2019-09-11  Ali Tamur  <tamur@google.com>
1277
1278         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1279         implementation.
1280
1281 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1282
1283         * dbxread.c (read_dbx_symtab): Update.
1284         * dwarf2read.c (load_partial_dies): Update.
1285         * mdebugread.c (parse_partial_symbols): Update.
1286         (handle_psymbol_enumerators): Update.
1287         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1288         * psymtab.c (add_psymbol_to_bcache): Likewise.
1289         (add_psymbol_to_list): Likewise.
1290         * symtab.c (symbol_set_names): Likewise.
1291         * symtab.h (symbol_set_names): Likewise.
1292         * xcoffread.c (scan_xcoff_symtab): Update.
1293
1294 2019-09-11  Tom Tromey  <tom@tromey.com>
1295
1296         * symfile-mem.c (symbol_file_add_from_memory): Use
1297         bfd_set_filename.
1298         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1299         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1300
1301 2019-09-10  Tom Tromey  <tromey@adacore.com>
1302
1303         * dwarf-index-write.c (write_psymbols): Extend error message.
1304         (debug_names::insert): Add Ada code.
1305         (debug_names::write_psymbols): Remove Ada check.
1306         (debug_names) <m_string_obstack>: New member.
1307         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1308         (gdb_index_symbol_name_matcher::matches): Remove.
1309         (mapped_index_base::find_name_components_bounds): Add "lang"
1310         parameter.
1311         (mapped_index_base::build_name_components): Also split names
1312         according to Ada syntax.
1313         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1314         type of "match_callback".
1315         (check_match, check_find_bounds_finds)
1316         (dw2_expand_symtabs_matching): Update.
1317         (dw2_debug_names_iterator): Add new constructor.
1318         (dw2_debug_names_map_matching_symbols): New function.
1319         (dw2_debug_names_expand_symtabs_matching): Update.
1320         (dwarf2_debug_names_functions): Use
1321         dw2_debug_names_map_matching_symbols.
1322
1323 2019-09-10  Tom Tromey  <tromey@adacore.com>
1324
1325         * dwarf2read.c (dw2_get_file_names_reader): Add the
1326         CU's file name to the results.
1327
1328 2019-09-10  Tom Tromey  <tromey@adacore.com>
1329
1330         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1331         map_matching_symbols.  Update.
1332         * dwarf2read.c (dw2_map_matching_symbols): Update.
1333         * psymtab.c (match_partial_symbol): Change type; update.
1334         (psym_map_matching_symbols): Likewise.
1335         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1336         type; update.
1337         * symfile.h (struct quick_symbol_functions)
1338         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1339         Remove "match".
1340
1341 2019-09-10  Tom Tromey  <tromey@adacore.com>
1342
1343         * psymtab.c (map_block): Remove.
1344         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1345         * symtab.c (iterate_over_symbols_terminated): New function.
1346         * symtab.c (iterate_over_symbols_terminated): Declare.
1347
1348 2019-09-10  Tom Tromey  <tromey@adacore.com>
1349
1350         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1351         * language.h (struct language_defn) <la_iterate_over_symbols>:
1352         Return bool.
1353         * symtab.c (iterate_over_symbols): Return bool.
1354         * symtab.h (iterate_over_symbols): Return bool.
1355
1356 2019-09-10  Tom Tromey  <tromey@adacore.com>
1357
1358         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1359         (add_nonlocal_symbols): Update.
1360         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1361         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1362         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1363         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1364         Change type of "callback".  Remove "data".
1365
1366
1367 2019-09-09  Ali Tamur  <tamur@google.com>
1368
1369         * dwarf2read.c (comp_unit_head): Update comment.
1370         (dwarf2_dwo_name): New function declaration.
1371         (dwarf_unit_type_name): New function declaration.
1372         (read_comp_unit_head): Add support for new compilation units,
1373         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1374         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1375         (currently named as "signature") in their header. Also clarify error
1376         messages.
1377         (lookup_dwo_id): New function. Returns the dwo id of the given
1378         compile unit.
1379         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1380         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1381         functions.
1382         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1383         (dwarf2_dwo_name): Get the dwo name if present.
1384         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1385         purposes.
1386
1387 2019-09-09  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1390
1391 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1392
1393         * python/python.c (do_start_initialization): Make progname_copy static,
1394         to avoid a leak report.
1395
1396 2019-09-08  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1399
1400 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1401
1402         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1403         Change type to gdb::optional<block_enum>.
1404         (dw2_symtab_iter_init): Change block_index parameter type
1405         to gdb::optional<block_enum>.
1406         (dw2_lookup_symbol): Change block_index parameter
1407         type to block_enum.c
1408         (dw2_debug_names_lookup_symbol): Likewise.
1409         * psymtab.c (psym_lookup_symbol): Likewise.
1410         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1411         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1412         Likewise.
1413
1414 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1415
1416         * defs.h (relocate_gdb_directory): Change int to bool in
1417         signature and rename flag to relocatable.
1418         * main.c (relocate_path): Likewise.
1419         (relocate_gdb_directory): Likewise.
1420
1421 2019-09-06  Alan Modra  <amodra@gmail.com>
1422
1423         * coffread.c (coff_symfile_read): Constify filename variable.
1424         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1425         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1426         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1427         * solib.c (reload_shared_libraries_1): Likewise.
1428         * symfile.c (reread_symbols): Likewise.
1429         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1430         * solib-darwin.c (darwin_bfd_open): Likewise.
1431         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1432
1433 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1436         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1437
1438 2019-09-03  Tom Tromey  <tromey@adacore.com>
1439
1440         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1441         types.
1442         (has_negatives): Unbias a range type bound.
1443         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1444         * gdbtypes.c (operator==): Handle new field.
1445         (create_range_type): Add "bias" parameter.
1446         (create_static_range_type, resolve_dynamic_range): Update.
1447         * gdbtypes.h (struct range_bounds) <bias>: New member.
1448         (create_range_type): Add bias parameter.
1449         * printcmd.c (print_scalar_formatted): Unbias range types.
1450         * value.c (unpack_long): Unbias range types.
1451         (pack_long): Bias range types.
1452
1453 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1454
1455         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1456         probe arguments.
1457
1458 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1459
1460         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1461         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1462         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1463         (compile_probe_arg): Likewise.
1464         * probe.h (get_argument_count): Likewise.
1465         * solib-svr4.c (solib_event_probe_action): Likewise.
1466         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1467
1468 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1471         code to here...
1472         (svr4_create_solib_event_breakpoints): ...from here.
1473
1474 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1475
1476         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1477         suffix from warning message.
1478
1479 2019-08-30  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-winsource.h (struct tui_source_window_base)
1482         <refresh_all>: Don't declare.
1483         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1484         Remove.
1485         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1486         tui_show_locator_content.
1487         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1488         declare.
1489         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1490         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1491         declare.
1492
1493 2019-08-30  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1496
1497 2019-08-30  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1500         Remove unnecessary forward declarations.
1501
1502 2019-08-30  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1505         rerender.
1506         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1507         tui_show_locator_content.
1508
1509 2019-08-30  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1512         (tui_locator_window::rerender): Rewrite using body of previous
1513         tui_show_locator_content.
1514
1515 2019-08-30  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1518         set_locator_fullname>: New methods.
1519         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1520         Rename from tui_set_locator_fullname.
1521         (tui_locator_window::set_locator_info): Rename from
1522         tui_set_locator_info.  Return bool.
1523         (tui_update_locator_fullname, tui_show_frame_info): Update.
1524
1525 2019-08-30  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1528
1529 2019-08-30  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1532         call touchwin.
1533
1534 2019-08-30  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-wingeneral.c (box_win): Assume win_info and
1537         win_info->handle cannot be NULL.
1538
1539 2019-08-30  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1542         refresh_window>: Declare.
1543         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1544         resize.
1545         (tui_data_item_window::rerender): Rename from
1546         tui_display_register.
1547         (tui_data_item_window::refresh_window): New method.
1548         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1549         no-op.
1550
1551 2019-08-30  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1554         regs_column_count, current_group>: Move later.  Now private.
1555         <get_current_group>: New method.
1556         * tui/tui-regs.c (tui_reg_command): Update.
1557         * tui/tui-layout.c (tui_set_layout): Update.
1558
1559 2019-08-30  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1562         (tui_data_window::rerender): Don't call
1563         check_and_display_highlight_if_needed.
1564         (tui_data_window::refresh_all): Remove call to
1565         erase_data_content.
1566
1567 2019-08-30  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1570         (tui_data_window::display_registers_from)
1571         (tui_data_window::display_reg_element_at_line)
1572         (tui_data_window::display_registers_from_line): Remove checks of
1573         "empty".
1574
1575 2019-08-30  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1578         Don't declare.
1579         * tui/tui-regs.c (tui_data_window::show_registers): Call
1580         rerender.
1581         (tui_data_window::rerender): Rename from display_all_data.
1582         (tui_data_window::rerender): Remove old implementation.
1583
1584 2019-08-30  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1587         text.
1588         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1589
1590 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1591             Sergio Durigan Junior  <sergiodj@redhat.com>
1592
1593         PR win32/24284
1594         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1595
1596 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1599         when searching for types.
1600
1601 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * f-lang.c (f_language_defn): Use f_print_typedef.
1604         * f-lang.h (f_print_typedef): Declare.
1605         * f-typeprint.c (f_print_typedef): Define.
1606
1607 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1608
1609         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1610
1611 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * cli/cli-utils.c (info_print_options_defs): Delete.
1614         (make_info_print_options_def_group): Delete.
1615         (extract_info_print_options): Delete.
1616         (info_print_command_completer): Delete.
1617         (info_print_args_help): Add extra parameter, and optionally
1618         include text about -n flag.
1619         * cli/cli-utils.h (struct info_print_options): Delete.
1620         (extract_info_print_options): Delete declaration.
1621         (info_print_command_completer): Delete declaration.
1622         (info_print_args_help): Add extra parameter, extend header
1623         comment.
1624         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1625         search_symbols.
1626         * stack.c (struct info_print_options): New type.
1627         (info_print_options_defs): New file scoped variable.
1628         (make_info_print_options_def_group): New static function.
1629         (info_print_command_completer): New static function.
1630         (info_locals_command): Update to use new local functions.
1631         (info_args_command): Likewise.
1632         (_initialize_stack): Add extra parameter to calls to
1633         info_print_args_help.
1634         * symtab.c (search_symbols): Add extra parameter, use this to
1635         possibly excluse non-debug symbols.
1636         (symtab_symbol_info): Add extra parameter, which is passed on to
1637         search_symbols.
1638         (struct info_print_options): New type.
1639         (info_print_options_defs): New file scoped variable.
1640         (make_info_print_options_def_group): New static function.
1641         (info_print_command_completer): New static function.
1642         (info_variables_command): Update to use local functions, and pass
1643         extra parameter through to symtab_symbol_info.
1644         (info_functions_command): Likewise.
1645         (info_types_command): Pass additional argument through to
1646         symtab_symbol_info.
1647         (rbreak_command): Pass extra argument to search_symbols.
1648         (_initialize_symtab): Add extra arguments for calls to
1649         info_print_args_help, and update help text for 'info variables',
1650         'whereis', and 'info functions' commands.
1651         * symtab.h (search_symbols): Add extra argument to declaration.
1652         * NEWS: Mention new flags.
1653
1654 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1655
1656         * symtab.c (lookup_static_symbol): Call the new function (and move
1657         it down to be next to lookup_global_symbol).
1658         (struct global_sym_lookup_data): Add block_enum member and rename to...
1659         (struct global_or_static_sym_lookup_data): ...this.
1660         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1661         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1662         (lookup_symbol_global_or_static_iterator_cb): ...this.
1663         (lookup_global_or_static_symbol): New function.
1664         (lookup_global_symbol): Call new function.
1665
1666 2019-08-26  Tom de Vries  <tdevries@suse.de>
1667
1668         PR c++/24852
1669         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1670         when pc_probe.prob == NULL.
1671
1672 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1673
1674         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1675         variable symbol_linkage to symbol_linkage_.
1676
1677 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1678
1679         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1680         represent whether the symbol is static, dynamic, or we don't
1681         know.
1682
1683 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1684
1685         * gdb/rx-tdep.c (rx_register_names): New.
1686         (rx_register_name): Delete.
1687         (rx_psw_type): Delete.
1688         (rx_fpsw_type): Delete.
1689         (rx_register_type): Delete.
1690         (rx_gdbarch_init): Convert target-descriptions.
1691         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1692         * gdb/features/Makefile: Add rx.xml.
1693         * gdb/features/rx.xml: New.
1694         * gdb/features/rx.c: Generated.
1695         * gdb/NEWS: Mention target description support.
1696
1697 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1698
1699         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1700         *slot_ptr.
1701
1702 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1703
1704         * configure.ac: Don't check for 'dlfcn.h' (moved to
1705         gdbsupport/common.m4).
1706         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1707         'gdbsupport/'.
1708         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1709         * compile/compile-c-support.c: Include
1710         'gdbsupport/gdb-dlfcn.h'.
1711         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1712         * gdb-dlfcn.c: Move to...
1713         * gdbsupport/gdb-dlfcn.c: ... here.
1714         * gdb-dlfcn.h: Move to...
1715         * gdbsupport/gdb-dlfcn.h: ... here.
1716
1717 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1718
1719         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1720         the offset field signed.
1721
1722 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1723
1724         * python/lib/gdb/__init__.py (_execute_file): New function.
1725         * python/python.c (python_run_simple_file): Call gdb._execute_file
1726         on Windows.
1727
1728 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1729
1730         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1731         all uses as this was never set to anything but a zero value.
1732
1733 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1734
1735         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1736
1737 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1738
1739         * tui/tui-data.h (tui_gen_win_info): Add an =default
1740         move constructor, required by some GCC versions.
1741
1742 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1743
1744         * go32-nat.c (go32_sysinfo): Add hygon_p.
1745
1746 2019-08-20  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1749         line_from_reg_element_no, first_reg_element_no_inline,
1750         display_all_data, delete_data_content_windows,
1751         erase_data_content>: Now private.
1752
1753 2019-08-20  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1756         (tui_unhighlight_win, tui_highlight_win)
1757         (tui_win_info::make_window): Update.
1758         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1759
1760 2019-08-20  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1763         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1764         (MAX_PID_WIDTH): Move to tui-stack.c.
1765         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1766         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1767         (MAX_PID_WIDTH): Move from tui-data.h.
1768
1769 2019-08-20  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1772         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1773         (box_win): Update.
1774         (tui_gen_win_info::make_window): Rename from tui_make_window.
1775         (tui_win_info::make_window): New method.
1776         (tui_gen_win_info::make_visible): Update.
1777         * tui/tui-source.c (tui_source_window::set_contents): Update.
1778         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1779         (tui_data_window::display_registers_from): Update.
1780         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1781         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1782         Declare.
1783         <can_box>: Remove.
1784         <title>: Remove.
1785         (struct tui_win_info) <make_window>: Declare.
1786         <can_box>: Now virtual.
1787         <title>: New member.
1788         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1789         * tui/tui-command.c (tui_cmd_window::resize): Update.
1790
1791 2019-08-20  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1794         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1795         (tui_data_window::check_register_values): Update.
1796
1797 2019-08-20  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-regs.h (struct tui_data_window): Use
1800         DISABLE_COPY_AND_ASSIGN.
1801         <regs_content>: Change type, removing unique_ptr.
1802         <tui_data_window>: Add move constructor.
1803         * tui/tui-regs.c (tui_data_window::show_registers)
1804         (tui_data_window::show_register_group)
1805         (tui_data_window::display_registers_from)
1806         (tui_data_window::display_registers_from)
1807         (tui_data_window::first_data_item_displayed)
1808         (tui_data_window::delete_data_content_windows)
1809         (tui_data_window::rerender, tui_data_window::refresh_window)
1810         (tui_data_window::check_register_values): Update.
1811
1812 2019-08-20  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1815         show_register_group>: Declare.
1816         (tui_show_register_group): Don't declare.
1817         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1818         tui_show_registers.
1819         (tui_data_window::show_register_group): Rename from
1820         tui_show_register_group.
1821         (tui_data_window::check_register_values, tui_reg_command):
1822         Update.
1823         * tui/tui-layout.c (tui_set_layout): Update.
1824
1825 2019-08-20  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1828         Declare.
1829         (tui_check_register_values): Don't declare.
1830         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1831         from tui_check_register_values.
1832         * tui/tui-hooks.c (tui_register_changed): Update.
1833
1834 2019-08-20  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-regs.c (tui_reg_layout): Move later.
1837         (tui_show_registers): Don't enable TUI mode or change layout.
1838
1839 2019-08-20  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-regs.h (struct tui_data_item_window)
1842         <~tui_data_item_window>: Remove.
1843         <content>: Now a unique_xmalloc_ptr.
1844         * tui/tui-regs.c (tui_register_format): Return a
1845         unique_xmalloc_ptr.
1846         (tui_get_register): Update.
1847         (~tui_data_item_window): Remove.
1848         (tui_data_window::display_registers_from, tui_display_register):
1849         Update.
1850         * tui/tui-io.h (tui_expand_tabs): Update.
1851         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1852         Remove "col" parameter.
1853
1854 2019-08-20  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1857         field.
1858         * tui/tui-regs.c (~tui_data_item_window): Update.
1859
1860 2019-08-20  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1863         earlier.
1864
1865 2019-08-20  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1868
1869 2019-08-20  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-source.h (struct tui_source_window): Update.
1872         * tui/tui-regs.c (tui_show_registers): Update.
1873         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1874         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1875         (NO_REGS_STRING): Remove defines.
1876
1877 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1878
1879         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1880         unnecessary thread walk if remote doesn't support the packet.
1881
1882 2019-08-19  Tom Tromey  <tromey@adacore.com>
1883
1884         * python/py-value.c (value_has_field): Fix indentation.
1885
1886 2019-08-19  Tom Tromey  <tromey@adacore.com>
1887
1888         * printcmd.c (do_one_display, info_display_command): Update.
1889         * block.h (contained_in): Return bool.  Add allow_nested
1890         parameter.
1891         * block.c (contained_in): Return bool.  Add allow_nested
1892         parameter.
1893
1894 2019-08-19  Tom Tromey  <tom@tromey.com>
1895
1896         * configure: Rebuild.
1897         * configure.ac: Disallow the combination of -static-libstdc++ and
1898         source highlight.
1899         * source-cache.c (get_language_name): Handle rust.
1900         (source_cache::get_source_lines): Ignore highlighting exceptions.
1901
1902 2019-08-16  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1905         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1906         (struct tui_source_window_base) <make_visible, refresh_window,
1907         resize>: Remove methods.
1908         <execution_info>: Remove field.
1909         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1910         (tui_show_source_line, tui_source_window_base)
1911         (~tui_source_window_base): Update.
1912         (tui_source_window_base::resize)
1913         (tui_source_window_base::make_visible)
1914         (tui_source_window_base::refresh_window): Remove.
1915         (tui_source_window_base::update_exec_info): Update.
1916         * tui/tui-source.c (tui_source_window::set_contents): Update.
1917         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1918
1919 2019-08-16  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1922         deprecated_query_hook.
1923
1924 2019-08-16  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1927         (tui_update_source_windows_with_line): Update.
1928         * tui/tui-source.h (struct tui_source_window)
1929         <show_symtab_source>: Declare.
1930         (tui_show_symtab_source): Don't declare.
1931         * tui/tui-source.c (tui_show_symtab_source): Rename from
1932         tui_show_symtab_source.
1933
1934 2019-08-16  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-winsource.h (struct tui_source_window_base)
1937         <set_contents>: Declare.
1938         * tui/tui-winsource.c
1939         (tui_source_window_base::update_source_window_as_is): Update.
1940         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1941         Declare.
1942         (tui_set_source_content): Don't declare.
1943         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1944         tui_set_source_content.
1945         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1946         Declare.
1947         (tui_set_disassem_content): Don't declare.
1948         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1949         tui_set_disassem_content.
1950
1951 2019-08-16  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-winsource.h (struct tui_source_window_base)
1954         <update_breakpoint_info>: Declare.
1955         (tui_update_breakpoint_info): Don't declare.
1956         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1957         (tui_update_all_breakpoint_info): Update.
1958         (tui_source_window_base::update_breakpoint_info): Rename from
1959         tui_update_breakpoint_info.
1960         (tui_source_window_base::update_exec_info): Update.
1961
1962 2019-08-16  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-winsource.h (struct tui_source_window_base)
1965         <update_source_window>: Declare.
1966         (tui_update_source_window): Don't declare.
1967         * tui/tui-winsource.c
1968         (tui_source_window_base::update_source_window): Rename from
1969         tui_update_source_window.
1970         (tui_source_window_base::rerender): Update.
1971         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1972         * tui/tui-disasm.c (tui_show_disassem)
1973         (tui_show_disassem_and_update_source)
1974         (tui_disasm_window::maybe_update): Update.
1975
1976 2019-08-16  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-winsource.h (struct tui_source_window_base)
1979         <update_source_window_as_is>: Declare.
1980         (tui_update_source_window_as_is): Don't declare.
1981         * tui/tui-winsource.c (tui_update_source_window): Update
1982         (tui_source_window_base::update_source_window_as_is): Rename from
1983         tui_update_source_window_as_is.
1984         (tui_source_window_base::refill): Update.
1985         * tui/tui-source.c (tui_show_symtab_source): Update.
1986         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1987         Update.
1988
1989 2019-08-16  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-winsource.h (tui_update_source_window)
1992         (tui_update_source_window_as_is): Remove "noerror" parameter.
1993         * tui/tui-winsource.c (tui_update_source_window)
1994         (tui_update_source_window_as_is): Remove "noerror" parameter.
1995         (tui_update_source_windows_with_addr)
1996         (tui_update_source_windows_with_line)
1997         (tui_source_window_base::rerender)
1998         (tui_source_window_base::refill): Update.
1999         * tui/tui-source.h (tui_set_source_content)
2000         (tui_show_symtab_source): Remove "noerror" parameter.
2001         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2002         parameter.
2003         (tui_show_symtab_source): Likewise.
2004         (tui_source_window::maybe_update): Update.
2005         * tui/tui-disasm.c (tui_show_disassem)
2006         (tui_show_disassem_and_update_source)
2007         (tui_disasm_window::do_scroll_vertical)
2008         (tui_disasm_window::maybe_update): Update.
2009
2010 2019-08-16  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui.c (tui_is_window_visible): Update.
2013         * tui/tui-wingeneral.c (tui_make_window)
2014         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2015         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2016         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2017         (tui_set_win_height_command, parse_scrolling_args): Update.
2018         * tui/tui-source.c (tui_source_window::style_changed): Update.
2019         * tui/tui-regs.c (tui_show_registers)
2020         (tui_data_window::first_data_item_displayed)
2021         (tui_data_window::delete_data_content_windows)
2022         (tui_check_register_values, tui_reg_command): Update.
2023         * tui/tui-disasm.c (tui_show_disassem): Update.
2024         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2025         method.
2026         <is_visible>: Remove field.
2027         * tui/tui-data.c (tui_next_win, tui_prev_win)
2028         (tui_delete_invisible_windows): Update.
2029
2030 2019-08-16  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-winsource.h (struct tui_source_window_base)
2033         <m_has_locator>: Remove.
2034         * tui/tui-layout.c (show_source_disasm_command, show_data)
2035         (show_source_or_disasm_and_command): Update.
2036
2037 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2038
2039         * NEWS (Other MI changes): New subsection.
2040         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2041         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2042         * arch-utils.c (default_get_pc_address_flags): New function.
2043         * arch-utils.h (default_get_pc_address_flags): New declaration.
2044         * gdbarch.sh: Add get_pc_address_flags.
2045         * gdbarch.c: Regenerate.
2046         * gdbarch.h: Likewise.
2047         * stack.c (print_pc): New function.
2048         (print_frame_info) (print_frame): Call print_pc.
2049
2050 2019-08-16  Tom de Vries  <tdevries@suse.de>
2051
2052         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2053         print_objfile_section_info.
2054
2055 2019-08-15  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2058         calling update_cmdwin_start_line.
2059         * tui/tui-winsource.h (struct tui_source_window_base)
2060         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2061         <rerender>: Declare.
2062         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2063         Call rerender.
2064         (tui_source_window_base::set_new_height): Remove.
2065         (tui_source_window_base::rerender): Rename from
2066         do_make_visible_with_new_height.
2067         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2068         resize method.
2069         (tui_win_info::make_invisible_and_set_new_height)
2070         (tui_win_info::make_visible_with_new_height): Remove.
2071         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2072         Declare.
2073         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2074         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2075         do_make_visible_with_new_height>: Don't declare.
2076         <rerender>: Declare.
2077         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2078         set_new_height.
2079         (tui_data_window::do_make_visible_with_new_height): Remove.
2080         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2081         call tui_show_locator_content.
2082         (tui_gen_win_info::resize): Call rerender.
2083         (show_source_or_disasm_and_command): Don't call
2084         tui_show_locator_content.
2085         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2086         method.
2087         (struct tui_win_info) <rerender>: Declare.
2088         <set_new_height, make_invisible_and_set_new_height,
2089         make_visible_with_new_height>: Don't declare.
2090         * tui/tui-data.c (tui_win_list::rerender): New method.
2091         * tui/tui-command.h (struct tui_cmd_window)
2092         <do_make_visible_with_new_height>: Don't declare.
2093         * tui/tui-command.c
2094         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2095
2096 2019-08-15  Tom Tromey  <tromey@adacore.com>
2097
2098         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2099         * ada-lang.c (ada_enum_name): Likewise.
2100
2101 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2102
2103         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2104         leading underscore.
2105         (GdbOutputErrorFile): Likewise.
2106         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2107         accordingly.
2108         (execute_unwinders): Rename to have a leading underscore.
2109         (auto_load_packages): Likewise.
2110         (global scope): Adjust call to auto_load_packages accordingly.
2111         (GdbSetPythonDirectory): Likewise.
2112         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2113         instead of execute_unwinders.
2114
2115 2019-08-15  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2118         (show_data): Don't change window visibility.
2119         (tui_gen_win_info::resize): Remove special case for command
2120         window.  Use wresize, when available.
2121         (show_source_or_disasm_and_command): Don't change window
2122         visibility.
2123         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2124         <make_visible>: New method.
2125         * tui/tui-command.c (tui_cmd_window::resize): New method.
2126
2127 2019-08-15  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2130         (struct tui_source_windows): New.
2131         * tui/tui-winsource.c (tui_display_main): Update.
2132         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2133         (new_height_ok, parse_scrolling_args): Update.
2134         * tui/tui-layout.c (show_layout, show_data): Update.
2135         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2136         (tui_add_to_source_windows): Don't declare.
2137         * tui/tui-data.c (source_windows, tui_source_windows)
2138         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2139
2140 2019-08-15  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2143         Rename from reset.
2144         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2145         * tui/tui-layout.c (show_source_disasm_command, show_data):
2146         Update.
2147         (tui_gen_win_info::resize): Rename.
2148         (show_source_or_disasm_and_command): Update.
2149         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2150         reset.
2151
2152 2019-08-15  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2155         * tui/tui-interp.c (tui_interp::init): Don't call
2156         tui_initialize_static_data.
2157         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2158
2159 2019-08-15  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2162         examine tui_win_list.
2163
2164 2019-08-15  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2167         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2168         tui_clear_source_content.
2169         (tui_clear_source_content): Remove.
2170         (tui_source_window_base::do_erase_source_content): Hoist call to
2171         content.clear().
2172         * tui/tui-stack.c (tui_show_frame_info): Don't call
2173         tui_clear_source_content.
2174
2175 2019-08-15  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (struct tui_source_window_base)
2178         <do_erase_source_content>: New method.
2179         <erase_source_content>: New method.
2180         (tui_erase_source_content): Don't declare.
2181         * tui/tui-winsource.c (tui_clear_source_content): Update.
2182         (tui_source_window_base::do_erase_source_content): Rename from
2183         tui_erase_source_content.
2184         (tui_source_window_base::show_source_content): Update.
2185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2186         * tui/tui-source.h (struct tui_source_window)
2187         <erase_source_content>: New method.
2188         * tui/tui-disasm.h (struct tui_disasm_window)
2189         <erase_source_content>: New method.
2190
2191 2019-08-15  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2194         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2195         constructor.
2196         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2197         * tui/tui-source.c (tui_set_source_content): Update.
2198         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2199
2200 2019-08-15  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2203         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2204         tui-source.c.
2205         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2206         Declare.
2207         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2208         method.
2209         (tui_source_window::maybe_update): Update.
2210
2211 2019-08-15  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2214         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2215         tui-disasm.c.
2216         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2217         Declare.
2218         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2219         method.
2220         (tui_disasm_window::maybe_update): Update.
2221
2222 2019-08-15  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-winsource.h (struct tui_source_window_base)
2225         <maybe_update>: Declare.
2226         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2227         method.
2228         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2229         Declare.
2230         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2231         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2232         Declare.
2233         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2234
2235 2019-08-15  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2238
2239 2019-08-15  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-wingeneral.c: Include tui-stack.h.
2242         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2243         (struct tui_locator_window): Move from tui-data.h.
2244         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2245         (tui_initialize_static_data): Move from tui-data.c.
2246         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2247         (struct tui_locator_window): Move to tui-stack.c.
2248         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2249         (tui_initialize_static_data): Move to tui-stack.c.
2250
2251 2019-08-15  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-layout.c (show_source_disasm_command)
2254         (show_source_or_disasm_and_command): Use make_visible method, not
2255         tui_make_window.
2256         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2257         Remove.
2258
2259 2019-08-15  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-wingeneral.h (tui_make_window): Update.
2262         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2263         parameter.
2264         (tui_gen_win_info::make_visible): Update.
2265         * tui/tui-regs.c (tui_data_window::display_registers_from):
2266         Update.
2267         * tui/tui-layout.c (show_source_disasm_command)
2268         (show_source_or_disasm_and_command): Update.
2269         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2270         (enum tui_box): Remove.
2271         (struct tui_win_info) <can_box>: New method.
2272         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2273         method.
2274
2275 2019-08-15  Tom de Vries  <tdevries@suse.de>
2276
2277         * linux-nat-trad.c: Include gdbarch.h.
2278
2279 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2282         register sizes.
2283
2284 2019-08-14  Tom Tromey  <tromey@adacore.com>
2285
2286         * darwin-nat.c: Include gdbarch.h.
2287         * darwin-nat-info.c: Include gdbarch.h.
2288
2289 2019-08-13  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2292         Remove.
2293         * tui/tui-data.c (tui_initialize_static_data): Update.
2294
2295 2019-08-13  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-winsource.h (struct tui_exec_info_window)
2298         <~tui_exec_info_window, maybe_allocate_content, get_content,
2299         m_content>: Remove.
2300         (struct tui_source_window_base) <set_exec_info_content,
2301         show_exec_info_content>: Don't declare.
2302         * tui/tui-winsource.c
2303         (tui_exec_info_window::maybe_allocate_content): Remove.
2304         (tui_source_window_base::update_exec_info): Rename from
2305         set_exec_info_content.
2306         (tui_source_window_base::show_exec_info_content)
2307         (tui_source_window_base::update_exec_info): Remove.
2308
2309 2019-08-13  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2312         declare.
2313         * tui/tui-winsource.c (tui_update_source_window_as_is)
2314         (tui_update_source_windows_with_addr, tui_erase_source_content):
2315         Update.
2316         (tui_clear_exec_info_content): Remove.
2317
2318 2019-08-13  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2321         declare.
2322         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2323         call tui_erase_exec_info_content.
2324         (tui_clear_exec_info_content): Rename from
2325         tui_erase_exec_info_content.
2326         (tui_clear_exec_info_content): Delete.
2327
2328 2019-08-13  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-winsource.h (struct tui_source_window_base)
2331         <show_exec_info_content>: Declare.
2332         (tui_show_exec_info_content): Don't declare.
2333         * tui/tui-winsource.c
2334         (tui_source_window_base::show_exec_info_content): Rename from
2335         tui_show_exec_info_content.
2336         (tui_source_window_base::update_exec_info): Update.
2337
2338 2019-08-13  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2341         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2342         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2343         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2344         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2345         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2346         ... here.
2347
2348 2019-08-13  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-winsource.h (struct tui_source_window_base)
2351         <update_exec_info>: Declare.
2352         (tui_update_exec_info): Don't declare.
2353         * tui/tui-winsource.c (tui_update_source_window_as_is)
2354         (tui_source_window_base::refresh_all)
2355         (tui_update_all_breakpoint_info): Update.
2356         (tui_source_window_base::update_exec_info): Rename from
2357         tui_update_exec_info.
2358         * tui/tui-stack.c (tui_show_frame_info): Update.
2359
2360 2019-08-13  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-winsource.h (struct tui_source_window_base)
2363         <set_exec_info_content>: Declare.
2364         (tui_set_exec_info_content): Don't declare.
2365         * tui/tui-winsource.c
2366         (tui_source_window_base::set_exec_info_content): Rename from
2367         tui_set_exec_info_content.
2368         (tui_update_exec_info): Update.
2369
2370 2019-08-13  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-winsource.h (struct tui_source_window_base)
2373         <show_source_content>: Declare.
2374         (tui_show_source_content): Don't declare.
2375         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2376         (tui_source_window_base::show_source_content): Rename from
2377         tui_show_source_content.
2378         (tui_source_window_base::refresh_all): Update.
2379         * tui/tui-layout.c (show_source_disasm_command)
2380         (show_source_or_disasm_and_command): Update.
2381
2382 2019-08-13  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-winsource.c (tui_erase_source_content)
2385         (tui_show_source_content, tui_source_window_base::refresh_all):
2386         Update.
2387         * tui/tui-wingeneral.h
2388         (tui_check_and_display_highlight_if_needed): Don't declare.
2389         * tui/tui-wingeneral.c
2390         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2391         check_and_display_highlight_if_needed.
2392         * tui/tui-win.c (tui_rehighlight_all)
2393         (tui_win_info::make_visible_with_new_height): Update.
2394         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2395         (tui_data_window::erase_data_content)
2396         (tui_data_window::display_all_data): Update.
2397         * tui/tui-data.h (struct tui_win_info)
2398         <check_and_display_highlight_if_needed>: Declare.
2399
2400 2019-08-13  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-win.c (tui_resize_all): Call
2403         tui_delete_invisible_windows.
2404         * tui/tui-layout.c (show_layout): Call
2405         tui_delete_invisible_windows.
2406         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2407         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2408
2409 2019-08-13  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2412         tui_add_win_to_layout.
2413
2414 2019-08-13  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2417         * tui/tui-layout.c (tui_default_win_height): Now static.
2418
2419 2019-08-13  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2422         single switch.
2423         (show_source_disasm_command, show_source_or_disasm_and_command):
2424         Don't check current layout.
2425
2426 2019-08-13  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-wingeneral.c (make_all_visible): Remove.
2429         (tui_make_all_invisible): Simplify.
2430         * tui/tui-layout.c (tui_make_all_invisible): Move from
2431         tui-wingeneral.c; simplify.
2432         (show_layout): Hoist call to tui_make_all_invisible.
2433         (show_data): Don't call tui_make_all_invisible.
2434
2435 2019-08-13  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2438         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2439
2440 2019-08-13  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2443         tui-data.c.
2444         (show_source_disasm_command, show_data)
2445         (show_source_or_disasm_and_command): Don't use
2446         tui_set_current_layout_to.
2447         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2448         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2449         tui-layout.c.
2450         (tui_set_current_layout_to): Remove.
2451
2452 2019-08-13  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-layout.c (tui_set_layout): Update.
2455         * tui/tui-data.h (struct tui_layout_def): Remove.
2456         (tui_layout_def): Don't declare.
2457         * tui/tui-data.c (layout_def): Remove.
2458         (tui_layout_def): Remove.
2459
2460 2019-08-13  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-winsource.h (struct tui_source_window_base)
2463         <clear_detail>: No longer "override".
2464         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2465         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2466         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2467         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2468         Remove.
2469         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2470
2471 2019-08-13  Tom Tromey  <tromey@adacore.com>
2472
2473         * tracepoint.c: Don't include readline.h or history.h.
2474
2475 2019-08-12  Tom Tromey  <tom@tromey.com>
2476
2477         * configure: Rebuild.
2478         * configure.ac: Check for readline 7.
2479         * NEWS: Mention readline 7 requirement.
2480         * README: Update.
2481
2482 2019-08-12  Tom Tromey  <tom@tromey.com>
2483
2484         * mingw-hdep.c (gdb_select): Remove readline hack.
2485
2486 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2487
2488         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2489         when the function fails.
2490
2491 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2492
2493         * s390-tdep.c (s390_type_align): New function.
2494         (s390_gdbarch_init): Set it as type_align gdbarch method.
2495
2496 2019-08-09  Tom de Vries  <tdevries@suse.de>
2497
2498         PR gdb/24591
2499         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2500         pc_low with relocation offset.
2501
2502 2019-08-07  Tom Tromey  <tromey@adacore.com>
2503
2504         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2505         (print_frame_args): Update.
2506         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2507         Update.
2508         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2509         * frame.h (struct frame_arg): Add initializers.
2510         <error>: Now a unique_xmalloc_ptr.
2511
2512 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2513
2514         * NEWS: Expand the Pointer Authentication entry.
2515         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2516         (aarch64_frame_unmask_lr): ... to this.
2517         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2518         Call aarch64_frame_unmask_lr.
2519         * frame.c (struct frame_info): Add "masked" variable.
2520         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2521         (fprint_frame): Check for masked pc.
2522         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2523         declarations.
2524         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2525         * stack.c (print_frame): Check for masked pc.
2526
2527 2019-08-06  Tom Tromey  <tom@tromey.com>
2528
2529         * stabsread.c (patch_block_stabs, read_one_struct_field)
2530         (read_enum_type): Use obstack_strndup.
2531         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2532         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2533         * dwarf2read.c (guess_full_die_structure_name)
2534         (anonymous_struct_prefix): Use obstack_strndup.
2535         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2536         * c-exp.y (yylex): Use obstack_strndup.
2537         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2538         (write_var_or_type): Use obstack_strndup.
2539
2540 2019-08-06  Tom Tromey  <tom@tromey.com>
2541
2542         * symfile.c (reread_symbols): Use obstack_strdup.
2543         * stabsread.c (read_type): Use obstack_strdup.
2544         * gdb_obstack.h (obstack_strdup): New overload.
2545         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2546         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2547         (dwarf2_canonicalize_name): Use obstack_strdup.
2548         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2549         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2550         Use obstack_strdup.
2551
2552 2019-08-06  Tom Tromey  <tom@tromey.com>
2553
2554         * gdb_obstack.h (obstack_strdup): Define.
2555         * gdb_obstack.c (obstack_strdup): Don't define.
2556
2557 2019-08-06  Tom Tromey  <tom@tromey.com>
2558
2559         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2560         obstack_strdup.
2561         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2562         obstack_strdup.
2563         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2564         * stabsread.c (common_block_start): Use obstack_strdup.
2565         * objfiles.c (set_objfile_main_name, objfile): Use
2566         obstack_strdup.
2567         * namespace.c (add_using_directive): Use obstack_strdup.
2568         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2569         * jit.c (finalize_symtab): Use obstack_strdup.
2570         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2571         (guess_partial_die_structure_name, partial_die_info::fixup)
2572         (dwarf2_name): Use obstack_strdup.
2573         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2574         obstack_strdup.
2575         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2576         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2577         obstack_strdup.
2578         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2579
2580 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581
2582         * unittests/help-doc-selftests.c: New file.
2583         * Makefile.in: Add the new file.
2584
2585 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2586
2587         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2588         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2589         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2590         the trailing '.' is not output, and the first character is uppercased.
2591         (print_help_for_command): Update call to print_doc_line.
2592         (print_doc_of_command): Likewise.
2593         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2594         * cli/cli-option.c (append_indented_doc): Do not append newline.
2595         (build_help_option): Append newline after first appended_indented_doc
2596         only if a second call is done.
2597         (build_help): Append 2 new lines before each option, except the first
2598         one.
2599         * compile/compile.c (_initialize_compile): Add new lines after
2600         %OPTIONS%, when not at the end of the help.
2601         Change help doc or code
2602         producing the help doc to respect the invariants.
2603         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2604         Also removed the new line after 'Options:', as all other commands
2605         do not put an empty line between 'Options:' and the first option.
2606         * printcmd.c (_initialize_printcmd): Likewise.
2607         * stack.c (_initialize_stack): Likewise.
2608         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2609         incorrectly telling COMMAND is optional.
2610         * ada-lang.c (_initialize_ada_language): Change help doc or code
2611         producing the help doc to respect the invariants.
2612         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2613         * breakpoint.c (_initialize_breakpoint): Likewise.
2614         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2615         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2616         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2617         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2618         _initialize_cli_style): Likewise.
2619         * corelow.c (core_target_info): Likewise.
2620         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2621         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2622         * filesystem.c (_initialize_filesystem): Likewise.
2623         * frame.c (_initialize_frame): Likewise.
2624         * gnu-nat.c (add_task_commands): Likewise.
2625         * infcall.c (_initialize_infcall): Likewise.
2626         * infcmd.c (_initialize_infcmd): Likewise.
2627         * interps.c (_initialize_interpreter): Likewise.
2628         * language.c (_initialize_language): Likewise.
2629         * linux-fork.c (_initialize_linux_fork): Likewise.
2630         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2631         * maint.c (_initialize_maint_cmds): Likewise.
2632         * memattr.c (_initialize_mem): Likewise.
2633         * printcmd.c (_initialize_printcmd): Likewise.
2634         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2635         _RegEx): Likewise.
2636         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2637         * record-btrace.c (_initialize_record_btrace): Likewise.
2638         * record-full.c (_initialize_record_full): Likewise.
2639         * record.c (_initialize_record): Likewise.
2640         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2641         * regcache.c (_initialize_regcache): Likewise.
2642         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2643         _initialize_remote): Likewise.
2644         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2645         * serial.c (_initialize_serial): Likewise.
2646         * skip.c (_initialize_step_skip): Likewise.
2647         * source.c (_initialize_source): Likewise.
2648         * stack.c (_initialize_stack): Likewise.
2649         * symfile.c (_initialize_symfile): Likewise.
2650         * symtab.c (_initialize_symtab): Likewise.
2651         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2652         * top.c (init_main): Likewise.
2653         * tracefile-tfile.c (tfile_target_info): Likewise.
2654         * tracepoint.c (_initialize_tracepoint): Likewise.
2655         * tui/tui-win.c (_initialize_tui_win): Likewise.
2656         * utils.c (add_internal_problem_command): Likewise.
2657         * valprint.c (value_print_option_defs): Likewise.
2658
2659 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2660
2661         PR build/24886
2662         * configure.ac: Drop enable-libmcheck support.
2663         * configure, config.in: Rebuild.
2664         * libmcheck.m4: Remove.
2665         * acinclude.m4: Don't include it.
2666         * Makefile.in: Don't distribute it.
2667         * top.c (print_gdb_configuration): Don't mention it.
2668
2669 2019-08-06  Tom Tromey  <tom@tromey.com>
2670
2671         * utils.c (set_output_style): Sometimes pass stream to
2672         emit_style_escape.
2673         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2674         * record-btrace.c (btrace_insn_history): Update.
2675         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2676         method.
2677         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2678         Update initializers.
2679         <m_uiout>: New field.
2680         <m_di>: Move lower.
2681         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2682         Remove "uiout" parameter.
2683         (dump_insns): Update.
2684         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2685         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2686
2687 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2688
2689         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2690         (error_in_psymtab_expansion): Likewise.
2691         (lookup_symbol_via_quick_fns): Likewise.
2692         (basic_lookup_transparent_type_quick): Likewise.
2693         (basic_lookup_transparent_type_1): Likewise.
2694
2695 2019-08-06  Tom Tromey  <tromey@adacore.com>
2696
2697         * source.c (last_source_error): Now bool.
2698         (print_source_lines_base): Make "noprint" bool.  Only open
2699         source file when last_source_visited changes.
2700
2701 2019-08-06  Tom Tromey  <tromey@adacore.com>
2702
2703         * annotate.c (annotate_source_line): Use g_source_cache.
2704         * source-cache.c (source_cache::get_plain_source_lines): Change
2705         parameters.  Populate m_offset_cache.
2706         (source_cache::ensure): New method.
2707         (source_cache::get_line_charpos): New method.
2708         (extract_lines): Move lower.  Change parameters.
2709         (source_cache::get_source_lines): Move lower.
2710         * source-cache.h (class source_cache): Update comment.
2711         <get_line_charpos>: New method.
2712         <get_source_lines>: Update comment.
2713         <clear>: Clear m_offset_cache.
2714         <get_plain_source_lines>: Change parameters.
2715         <ensure>: New method
2716         <m_offset_cache>: New member.
2717         * source.c (forget_cached_source_info_for_objfile): Update.
2718         (info_source_command): Use g_source_cache.
2719         (find_source_lines, open_source_file_with_line_charpos): Remove.
2720         (print_source_lines_base, search_command_helper): Use g_source_cache.
2721         * source.h (open_source_file_with_line_charpos): Don't declare.
2722         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2723         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2724         Use g_source_cache.
2725
2726 2019-08-06  Tom Tromey  <tromey@adacore.com>
2727
2728         * source-cache.c (source_cache::get_plain_source_lines):
2729         Remove "first_line" and "last_line" parameters.
2730         (source_cache::get_source_lines): Cache plain text.
2731         * source-cache.h (class source_cache)
2732         <get_plain_source_lines>: Update.
2733
2734 2019-08-06  Tom Tromey  <tromey@adacore.com>
2735
2736         * source-cache.c (extract_lines): No longer a method.
2737         Changed type of parameter.  Include final newline.
2738         (selftests::extract_lines_test): New function.
2739         (_initialize_source_cache): Likewise.
2740         * source-cache.h (class source_cache)
2741         <extract_lines>: Don't declare.
2742
2743 2019-08-06  Tom Tromey  <tromey@adacore.com>
2744
2745         * breakpoint.c (init_breakpoint_sal): Update.
2746         (breakpoint): Update.
2747         * breakpoint.h (struct breakpoint) <filter>: Now a
2748         unique_xmalloc_ptr.
2749
2750 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2751
2752         * NEWS: Mention dictionary access on blocks.
2753         * python/py-block.c (blpy_getitem): New function.
2754         (block_object_as_mapping): New struct.
2755         (block_object_type): Use new struct for tp_as_mapping field.
2756
2757 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2758
2759         * objfiles.h (objfile): Add a comment describing partial symbols.
2760
2761 2019-08-05  Tom Tromey  <tromey@adacore.com>
2762
2763         * compile/compile.c (_initialize_compile): Use _(), not N_().
2764         * thread.c (_initialize_thread): Use _(), not N_().
2765         * stack.c (_initialize_stack): Use _(), not N_().
2766         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2767
2768 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2769
2770         * dwarf2read.c (struct dw2_symtab_iterator):
2771         <want_specific_block>: Remove.
2772         <block_index>: Change type to gdb::optional.
2773         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2774         change type of BLOCK_INDEX parameter to gdb::optional.
2775         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2776         (dw2_lookup_symbol): Don't pass argument for
2777         WANT_SPECIFIC_BLOCK.
2778         (dw2_expand_symtabs_for_function): Don't pass argument for
2779         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2780         (class dw2_debug_names_iterator)
2781         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2782         parameter, change BLOCK_INDEX type to gdb::optional.
2783         <m_want_specific_block>: Remove.
2784         <m_block_index>: Change type to gdb::optional.
2785         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2786         gdb::optional.  Re-write in function of gdb::optional.
2787         (dw2_debug_names_lookup_symbol): Don't pass argument for
2788         WANT_SPECIFIC_BLOCK.
2789         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2790         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2791         BLOCK_INDEX.
2792
2793 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2794
2795         * NEWS: Mention changes to "info sources" command.
2796
2797 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2798
2799         * symtab.c (filename_partial_match_opts): New struct type.
2800         (struct output_source_filename_data): New members
2801         regexp, c_regexp, partial_match.
2802         (output_source_filename): Use new members to decide to print file.
2803         (info_sources_option_defs): New variable.
2804         (make_info_sources_options_def_group, print_info_sources_header,
2805         info_sources_command_completer):
2806         New functions.
2807         (info_sources_command): Read new optional arguments.
2808         (_initialize_symtab): Update info sources help.
2809
2810 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2811
2812         * ada-lang.c (exception_support_info_v0): Renamed from...
2813         (default_exception_support_info): ... this.  Create new
2814         definition for v1.
2815         (ada_has_this_exception_support): Look up catch_handlers_sym.
2816         (ada_exception_support_info_sniffer): Try v0 after default.
2817
2818 2019-08-01  Tom Tromey  <tromey@adacore.com>
2819
2820         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2821         gdbarch.h.
2822
2823 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2824
2825         * s12z-tdep.c: Fix include path for s12z-opc.h.
2826
2827 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2828
2829         * NEWS: Require GNU make 3.82.
2830
2831 2019-07-16  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2834         declare.
2835
2836 2019-07-30  Tom Tromey  <tromey@adacore.com>
2837
2838         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2839
2840 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2841
2842         * printcmd.c (print_address_symbolic): Print negative offsets.
2843         (build_address_symbolic): Force signed arithmetic when computing
2844         offset.
2845
2846 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2847
2848         PR/24474: Add a function to lookup static variables.
2849         * NEWS: Mention this new function.
2850         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2851         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2852         * python/python.c (python_GdbMethods): Add new function.
2853
2854 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2855
2856         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2857         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2858         (objfpy_lookup_static_symbol): New function.
2859         (objfile_object_methods): Add new functions.
2860
2861 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2862
2863         * NEWS: Mention 'set|show print frame-info'.  Mention new
2864         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2865         backtrace argument.  Mention that python frame filtering code
2866         is now consistent with what 'backtrace' command prints.
2867
2868 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2869
2870         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2871         comments.
2872         (print_frame_info_auto, print_frame_info_source_line,
2873         print_frame_info_location, print_frame_info_source_and_location,
2874         print_frame_info_location_and_address, print_frame_info_short_location):
2875         New declarations.
2876         (struct frame_print_options): New member print_frame_info.
2877         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2878         * stack.h (get_user_print_what_frame_info): New declaration.
2879         (frame_show_address): New declaration.
2880         * stack.c (print_frame_arguments_choices): New value 'presence'.
2881         (print_frame_info_auto, print_frame_info_source_line,
2882         print_frame_info_location, print_frame_info_source_and_location,
2883         print_frame_info_location_and_address, print_frame_info_short_location,
2884         print_frame_info_choices, print_frame_info_print_what): New definitions.
2885         (print_frame_args): Only print dots for args if print frame-arguments
2886         is 'presence'.
2887         (frame_print_option_defs): New element for "frame-info".
2888         (get_user_print_what_frame_info): New function.
2889         (frame_show_address): Make non static.  Move comment to stack.h.
2890         (print_frame_info_to_print_what): New function.
2891         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2892         to decide what to print.
2893         (backtrace_command_1): Handle the new print_frame_arguments_presence
2894         value.
2895         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2896         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2897         (py_print_frame): In non-mi mode, use LOCATION as default for
2898         print_what, similarly to frame information printed directly by
2899         backtrace command. Handle frame-info user option in non MI mode.
2900
2901 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2902
2903         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2904         Add case for debugging 32-bit target on 64-bit host.  Revise
2905         comment.
2906
2907 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2908
2909         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2910         instead of find_function_entry_range_from_pc.
2911
2912 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2913
2914         * stack.c (find_frame_funname): Remove code which preferred
2915         minsym over symtab sym in "certain pathological cases".
2916
2917         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2918         parameter.  Change type of "do_demangle" to bool.
2919         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2920         Pass suitable "prefer_sym_over_minsym" flag to
2921         build_address_symbolic().  Don't output "+" for negative offsets.
2922         * printcmd.c (print_address_symbolic): Update invocation of
2923         build_address_symbolic to include a "prefer_sym_over_minsym"
2924         flag.
2925         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2926         Restrict cases in which use of minimal symbol is preferred to that
2927         of a found symbol.  Update comments.
2928
2929         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2930         for entry pc when entry pc is out of range for that FDE.
2931
2932 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2933
2934         PR gdb/24839:
2935         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2936         type.
2937
2938 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2939
2940         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2941         this function's Python signature.
2942
2943
2944 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2945
2946         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2947         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2948         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2949         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2950         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2951
2952
2953 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2954
2955         * h8300-tdep.c (h8300_register_name_common): New.
2956         h8300_register_name): Use h8300_register_name_common.
2957         (h8300s_register_name): Likewise.
2958         (h8300sx_register_name): Likewise.
2959         (h8300h_register_nam): New.
2960         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2961
2962
2963 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2964
2965         * arm-tdep.c (arm_skip_cmse_entry): New function.
2966         (arm_is_sgstubs_section): New function.
2967         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2968
2969 2019-07-22  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2972         Don't self-assign.
2973
2974 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2977         type_print.
2978
2979 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2982         so that GDB doesn't match any msymbols when searching in the
2983         TYPES_DOMAIN.
2984         (print_symbol_info): Print using typedef_print or type_print based
2985         on the type of the symbol.  Add updated FIXME comment moved from...
2986         (_initialize_symtab): ... move and update FIXME comment to above.
2987
2988 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2989
2990         * NEWS: Mention adding -q option to "info types".
2991         * symtab.c (struct info_types_options): New struct.
2992         (info_types_options_defs): New variable.
2993         (make_info_types_options_def_group): New function.
2994         (info_types_command): Use gdb::option framework to parse options.
2995         (info_types_command_completer): New function.
2996         (_initialize_symtab): Extend the help text on "info types" and
2997         register command completer.
2998
2999 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3000
3001         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3002         (lookup_symbol_in_objfile): Change int to block_enum and add a
3003         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3004
3005 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3006
3007         * MAINTAINERS (Write After Approval): Add self.
3008
3009 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3010
3011         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3012         instruction to the dummy code region.
3013
3014 2019-07-19  Tom Tromey  <tromey@adacore.com>
3015
3016         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3017         (ARGSUSED, PARAMS, __func__): Remove rules.
3018
3019 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3020
3021         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3022         * features/arm/arm-with-iwmmxt.c: Remove.
3023         * features/arm/arm-with-iwmmxt.xml: Remove.
3024         * features/arm/arm-with-m-fpa-layout.c: Remove.
3025         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3026         * features/arm/arm-with-m-vfp-d16.c: Remove.
3027         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3028         * features/arm/arm-with-m.c: Remove.
3029         * features/arm/arm-with-m.xml: Remove.
3030         * features/arm/arm-with-neon.c: Remove.
3031         * features/arm/arm-with-neon.xml: Remove.
3032         * features/arm/arm-with-vfpv2.c: Remove.
3033         * features/arm/arm-with-vfpv2.xml: Remove.
3034         * features/arm/arm-with-vfpv3.c: Remove.
3035         * features/arm/arm-with-vfpv3.xml: Remove.
3036
3037 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3038
3039         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3040
3041 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3042
3043         * arch/aarch32.c (aarch32_create_target_description): Create
3044         target descriptions using features.
3045         * arch/arm.c (arm_create_target_description)
3046         (arm_create_mprofile_target_description): Likewise.
3047         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3048
3049 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3050
3051         * Makefile.in: Add new files.
3052         * aarch32-tdep.c: New file.
3053         * aarch32-tdep.h: New file.
3054         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3055         Call aarch32_read_description.
3056         * arch/aarch32.c: New file.
3057         * arch/aarch32.h: New file.
3058         * arch/arm.c (arm_create_target_description)
3059         (arm_create_mprofile_target_description): New function.
3060         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3061         (arm_create_target_description)
3062         (arm_create_mprofile_target_description): New declaration.
3063         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3064         read_description functions.
3065         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3066         Likewise.
3067         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3068         * arm-tdep.c (tdesc_arm_list): New variable.
3069         (arm_register_g_packet_guesses): Call create description functions.
3070         (arm_read_description) (arm_read_mprofile_description): New
3071         function.
3072         * arm-tdep.h (arm_read_description)
3073         (arm_read_mprofile_description): Add declaration.
3074         * configure.tgt: Add new files.
3075
3076 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3077
3078         * top.c (new_ui_command): Open specified terminal just once.
3079
3080 2019-07-18  Tom Tromey  <tromey@adacore.com>
3081
3082         * symtab.c (main_name): Constify return type.
3083         * symfile.c (set_initial_language): Update.
3084         * symtab.h (main_name): Constify return type.
3085
3086 2019-07-17  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-winsource.c (tui_update_source_window)
3089         (tui_update_source_window_as_is)
3090         (tui_update_source_windows_with_line): Remove return.
3091         * tui/tui-disasm.c (tui_show_disassem)
3092         (tui_show_disassem_and_update_source): Remove return.
3093         * tui/tui.c (tui_reset): Remove return.
3094         * tui/tui-wingeneral.c
3095         (tui_check_and_display_highlight_if_needed): Remove return.
3096
3097 2019-07-17  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3100
3101 2019-07-17  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-winsource.h (struct tui_exec_info_window)
3104         (struct tui_source_window_base): Move from tui-data.h.
3105         * tui/tui-winsource.c: Move many method definitions from
3106         elsewhere.  Remove "structuring" comments.
3107         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3108         (tui_source_window_base::refresh_window): Move to
3109         tui-winsource.c.
3110         * tui/tui-win.c (tui_source_window_base::refresh_all)
3111         (tui_source_window_base::update_tab_width)
3112         (tui_source_window_base::set_new_height)
3113         (tui_source_window_base::do_make_visible_with_new_height): Move to
3114         tui-winsource.c.
3115         * tui/tui-source.h: Update.
3116         * tui/tui-source.c (tui_source_window_base::reset): Move to
3117         tui-winsource.c.
3118         * tui/tui-disasm.h: Update.
3119         * tui/tui-data.h (struct tui_exec_info_window): Move to
3120         tui-winsource.h.
3121         (struct tui_source_window_base): Likewise.
3122         * tui/tui-data.c (tui_source_window_base::clear_detail)
3123         (tui_source_window_base, ~tui_source_window_base): Move to
3124         tui-winsource.c.
3125
3126 2019-07-17  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-win.c (tui_resize_all)
3129         (tui_source_window_base::update_tab_width)
3130         (tui_adjust_win_heights): Update.
3131         (tui_win_info::make_invisible_and_set_new_height): Rename from
3132         make_invisible_and_set_new_height.
3133         * tui/tui-data.h (struct tui_win_info)
3134         <make_invisible_and_set_new_height>: New method.
3135
3136 2019-07-17  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui.c: Update.
3139         * tui/tui-source.h (struct tui_source_window): Move from
3140         tui-data.h.
3141         * tui/tui-layout.c: Update.
3142         * tui/tui-disasm.c: Update.
3143         * tui/tui-data.h (struct tui_source_window): Move to
3144         tui-source.h.
3145
3146 2019-07-17  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3149         tui-data.h.
3150         * tui/tui-data.h (struct tui_disasm_window): Move to
3151         tui-disasm.h.
3152
3153 2019-07-17  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-regs.h (struct tui_data_item_window): Move from
3156         tui-data.h.
3157         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3158         * tui/tui-data.h (struct tui_data_item_window): Move to
3159         tui-regs.h.
3160         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3161
3162 2019-07-17  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui.c: Update.
3165         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3166         (tui_cmd_window::max_height): Move to tui-command.c.
3167         * tui/tui-layout.c: Update.
3168         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3169         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3170         tui-command.c.
3171         * tui/tui-command.h (struct tui_cmd_window): Move from
3172         tui-data.h.
3173         * tui/tui-command.c: Remove "structuring" comments.
3174         (tui_cmd_window::clear_detail)
3175         (tui_cmd_window::do_make_visible_with_new_height)
3176         (tui_cmd_window::max_height): Move from elsewhere.
3177
3178 2019-07-17  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3181         Now static.
3182         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3183         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui.c: Update.
3188         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3189         tui-regs.c.
3190         * tui/tui-windata.h: Remove file.
3191         * tui/tui-windata.c: Remove file.
3192         * tui/tui-win.c (tui_data_window::set_new_height)
3193         (tui_data_window::do_make_visible_with_new_height): Move to
3194         tui-regs.c.
3195         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3196         * tui/tui-regs.c: Remove "structuring" comments.
3197         (tui_data_window::first_data_item_displayed)
3198         (tui_data_window::delete_data_content_windows)
3199         (tui_data_window::erase_data_content)
3200         (tui_data_window::display_all_data)
3201         (tui_data_window::refresh_all)
3202         (tui_data_window::do_scroll_vertical)
3203         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3204         (tui_data_window::do_make_visible_with_new_height)
3205         (tui_data_window::refresh_window): Move from elsewhere.
3206         (_initialize_tui_regs): Move to end of file.
3207         * tui/tui-layout.c: Update.
3208         * tui/tui-hooks.c: Update.
3209         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3210         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3211         tui-regs.c.
3212         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3213
3214 2019-07-17  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3217         seen.
3218
3219 2019-07-17  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-win.c (tui_source_window_base::set_new_height)
3222         (tui_source_window_base::do_make_visible_with_new_height): Use
3223         m_has_locator field directly.
3224         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3225         method.
3226         (struct tui_source_window_base) <has_locator>: Likewise.
3227
3228 2019-07-17  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3231         Don't declare.
3232         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3233         Remove.
3234         * tui/tui-win.c (tui_source_window_base::set_new_height)
3235         (tui_source_window_base::set_new_height)
3236         (make_invisible_and_set_new_height)
3237         (tui_source_window_base::do_make_visible_with_new_height)
3238         (tui_source_window_base::do_make_visible_with_new_height):
3239         Update.
3240         * tui/tui-layout.c (show_source_disasm_command, show_data)
3241         (show_source_or_disasm_and_command): Update.
3242         * tui/tui-layout.c (show_layout): Update.
3243
3244 2019-07-17  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-layout.c (make_data_window): Remove.
3247         (show_data): Unify creation and re-initialization cases.
3248
3249 2019-07-17  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-layout.c (make_source_window, make_disasm_window):
3252         Remove.
3253         (show_data): Unify creation and re-initialization cases.
3254
3255 2019-07-17  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-layout.c (make_command_window): Remove.
3258         (show_source_disasm_command, show_source_or_disasm_and_command):
3259         Unify creation and re-initialization cases.
3260
3261 2019-07-17  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3264         creation and re-initialization cases.
3265
3266 2019-07-17  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-regs.c (tui_get_register): Return void.
3269
3270 2019-07-17  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3273         Simplify.
3274
3275 2019-07-17  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3278         resetting.
3279
3280 2019-07-17  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3283         * tui/tui-regs.c (tui_reg_layout): New function.
3284         (tui_show_registers, tui_reg_command): Use it.
3285         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3286         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3287         parameters.
3288         (tui_layout_command): Remove.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-layout.h (tui/tui-layout): Return void.
3293         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3294
3295 2019-07-17  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-layout.c (show_source_disasm_command, show_data):
3298         Update.
3299         (reset_locator): Remove.
3300         (show_source_or_disasm_and_command): Update.
3301
3302 2019-07-17  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-source.c (tui_source_window_base::reset): Remove
3305         win_type parameter.
3306         * tui/tui-layout.c (make_command_window, make_source_window)
3307         (make_disasm_window, make_data_window)
3308         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3309         (reset_locator, show_source_or_disasm_and_command): Update.
3310         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3311         win_type parameter.
3312         (struct tui_source_window_base) <reset>: Likewise.
3313
3314 2019-07-17  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-layout.c (show_source_disasm_command): Use
3317         reset_locator.
3318         (reset_locator): New function.
3319         (init_and_make_win): Remove.
3320         (show_source_or_disasm_and_command): Use reset_locator.
3321
3322 2019-07-17  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3325         condition.
3326         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3327         Remove condition.
3328         * tui/tui-source.c (tui_source_window_base::reset): New method.
3329         * tui/tui-layout.c (make_command_window): Don't call
3330         init_and_make_win.
3331         (make_source_window, make_disasm_window): Don't call
3332         make_source_or_disasm_window.
3333         (make_data_window): Don't call init_and_make_win.  Change calling
3334         convention.
3335         (show_source_disasm_command, show_data): Simplify.
3336         (make_source_or_disasm_window): Remove.
3337         (show_source_or_disasm_and_command): Simplify.
3338         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3339         (struct tui_source_window_base) <reset>: Likewise.
3340         <execution_info>: Remove initializer.
3341         * tui/tui-data.c (tui_source_window_base): Initialize
3342         execution_info.
3343
3344 2019-07-17  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3347         variable.
3348
3349 2019-07-17  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui.c (tui_rl_other_window): Update.
3352         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3353         superclass method first.  Always iterate over regs_content.
3354         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3355         method.
3356         * tui/tui-win.c (tui_set_focus_command): Update.
3357
3358 2019-07-17  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-win.c (tui_set_focus_command): Rename from
3361         tui_set_focus.  Call tui_enable.
3362         (tui_set_focus_command): Remove.
3363
3364 2019-07-17  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3367         refresh_window.
3368         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3369         touchwin.
3370         (tui_data_window::refresh_window): Call refresh_window on data
3371         items.  Always call superclass refresh_window.
3372         (tui_win_info::refresh): Remove.
3373         (tui_source_window_base::refresh_window): Update.
3374         (tui_refresh_all): Update.
3375         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3376         refresh_window.
3377         (show_source_or_disasm_and_command): Likewise.
3378         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3379         (struct tui_source_window_base) <refresh>: Likewise.
3380
3381 2019-07-17  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-winsource.c (tui_clear_source_content)
3384         (tui_show_source_content): Update.
3385         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3386         whether content is empty.
3387         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3388         Remove.
3389
3390 2019-07-17  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3393         window's contents.
3394         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3395         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3396
3397 2019-07-17  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3400         (struct tui_data_item_window): Update.
3401
3402 2019-07-17  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3405         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3406         defines.
3407
3408 2019-07-17  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-winsource.h (tui_erase_source_content)
3411         (tui_clear_source_content): Remove "display_prompt" parameter.
3412         * tui/tui-winsource.c (tui_update_source_window_as_is)
3413         (tui_update_source_windows_with_addr): Update.
3414         (tui_clear_source_content): Remove "display_prompt" parameter.
3415         (tui_erase_source_content): Likewise.  Simplify.
3416         (tui_show_source_content): Update.
3417         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3418         * tui/tui-stack.c (tui_show_frame_info): Update.
3419         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3420         Remove defines.
3421
3422 2019-07-17  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3425         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3426         parameter.
3427         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3428         parameter.
3429
3430 2019-07-17  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-winsource.c (tui_clear_source_content)
3433         (tui_show_source_content, tui_show_exec_info_content)
3434         (tui_clear_exec_info_content): Update.
3435         * tui/tui-stack.c (tui_show_locator_content): Update.
3436         (tui_show_frame_info): Update.
3437         * tui/tui-source.h (tui_source_window): Don't declare.
3438         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3439         from tui_source_is_displayed.
3440         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3441         Remove field.
3442         (struct tui_source_window_base) <content_in_use>: New field.  Now
3443         bool.
3444         (struct tui_source_window) <showing_source_p>: New method.
3445         (TUI_SRC_WIN): Change cast.
3446         * tui/tui-data.c (tui_initialize_static_data): Update.
3447
3448 2019-07-17  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3451         location_matches_p.
3452         * tui/tui-source.c (tui_source_window::location_matches_p): New
3453         method.
3454         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3455         method.
3456         * tui/tui-data.h (struct tui_source_window_base)
3457         <location_matches_p>: New method.
3458         (struct tui_source_window, struct tui_disasm_window)
3459         <location_matches_p>: Likewise.
3460
3461 2019-07-17  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-win.c (tui_set_win_height_command): Rename from
3464         tui_set_win_height.
3465         (tui_set_win_height_command): Remove.
3466
3467 2019-07-17  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-source.c (tui_source_window): New constructor.  Add
3470         observer.
3471         (~tui_source_window): New destructor.
3472         (tui_source_window::style_changed): New method.
3473         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3474         (tui_attach_detach_observers): Update.
3475         * tui/tui-data.h (struct tui_source_window): Make constructor not
3476         inline.  Add destructor.
3477         (struct tui_source_window) <style_changed>: New method.
3478         <m_observable>: New member.
3479
3480 2019-07-17  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3483         * tui/tui-win.c (tui_resize_all): Fix typo.
3484
3485 2019-07-17  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3488         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3489         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3490         * tui/tui-win.c (window_name_completer): Use foreach.
3491         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3492         (update_tab_width): Likewise.
3493         * tui/tui-layout.c (show_layout): Update.
3494         * tui/tui-data.h (class tui_window_iterator): New.
3495         (struct all_tui_windows): New.
3496         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3497
3498 2019-07-17  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3501         parameter.  Don't reference globals.
3502         (tui_reg_command): Update.
3503
3504 2019-07-17  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-regs.c (tui_show_registers): Simplify.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-regs.c (tui_show_registers): Update.
3511         (tui_show_register_group): Add win_info parameter.
3512
3513 2019-07-17  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3516         Rename from tui_display_reg_element_at_line.
3517         (tui_data_window::display_registers_from_line): Update.
3518         * tui/tui-data.h (struct tui_data_window)
3519         <display_reg_element_at_line>: New method.
3520
3521 2019-07-17  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-regs.h (tui_display_registers_from)
3524         (tui_display_registers_from_line): Don't declare.
3525         * tui/tui-windata.c (tui_data_window::display_all_data)
3526         (tui_data_window::refresh_all)
3527         (tui_data_window::do_scroll_vertical): Update.
3528         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3529         from tui_display_registers_from.
3530         (tui_display_reg_element_at_line): Update.
3531         (tui_data_window::display_registers_from_line): Rename from
3532         tui_display_registers_from_line.
3533         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3534         display_registers_from_line>: New methods.
3535
3536 2019-07-17  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3539         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3540         from tui_erase_data_content.
3541         (tui_data_window::display_all_data)
3542         (tui_data_window::refresh_all)
3543         (tui_data_window::do_scroll_vertical): Update.
3544         * tui/tui-regs.c (tui_show_registers): Update.
3545         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3546         New method.
3547
3548 2019-07-17  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3551         declare.
3552         * tui/tui-windata.c
3553         (tui_data_window::delete_data_content_windows): Rename from
3554         tui_delete_data_content_windows.
3555         (tui_data_window::display_all_data)
3556         (tui_data_window::do_scroll_vertical): Update.
3557         * tui/tui-data.h (struct tui_data_window)
3558         <delete_data_content_windows>: New method.
3559
3560 2019-07-17  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3563         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3564
3565 2019-07-17  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3568         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3569         from tui_display_all_data.
3570         * tui/tui-win.c
3571         (tui_data_window::do_make_visible_with_new_height): Update.
3572         * tui/tui-regs.c (tui_show_registers): Update.
3573         * tui/tui-layout.c (tui_set_layout): Update.
3574         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3575         method.
3576
3577 2019-07-17  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3580         * tui/tui-windata.c (tui_display_data_from): Remove.
3581         (tui_data_window::refresh_all): Update.
3582
3583 2019-07-17  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3586         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3587         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3588         tui_display_registers_from_line.
3589         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3590         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3591         "force_display" parameter.
3592
3593 2019-07-17  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3596         declare.
3597         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3598         Rename from tui_first_reg_element_no_inline.
3599         (tui_display_reg_element_at_line)
3600         (tui_display_registers_from_line): Update.
3601         * tui/tui-data.h (struct tui_data_window)
3602         <first_reg_element_no_inline>: New method.
3603
3604 2019-07-17  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-windata.c (tui_display_data_from)
3607         (tui_data_window::do_scroll_vertical): Update.
3608         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3609         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3610         Rename from tui_line_from_reg_element_no.
3611         (tui_display_registers_from_line): Update.
3612         * tui/tui-data.h (struct tui_data_window)
3613         <line_from_reg_element_no>: New method.
3614
3615 2019-07-17  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3618         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3619         tui_last_regs_line_no.
3620         (tui_display_reg_element_at_line)
3621         (tui_display_registers_from_line): Update.
3622         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3623         method.
3624
3625 2019-07-17  Tom Tromey  <tom@tromey.com>
3626
3627         PR tui/24722:
3628         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3629         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3630         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3631         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3632         (tui_update_breakpoint_info): Likewise.
3633         * tui/tui-hooks.c (tui_event_create_breakpoint)
3634         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3635         Update.
3636
3637 2019-07-17  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3640
3641 2019-07-17  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-winsource.c (tui_update_source_window_as_is)
3644         (tui_update_source_windows_with_addr): Update.
3645         * tui/tui-source.h (tui_set_source_content)
3646         (tui_show_symtab_source): Add "win_info" parameter.
3647         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3648         parameter.
3649         (tui_show_symtab_source): Likewise.
3650
3651 2019-07-17  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-wingeneral.c
3654         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3655
3656 2019-07-17  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3659         (struct tui_cmd_window) <can_scroll>: New method.
3660         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3661         method.
3662
3663 2019-07-17  Tom Tromey  <tromey@adacore.com>
3664
3665         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3666         do_field_signed>: Rename.  Change type of "value".
3667         * ui-out.c (ui_out::field_signed): Rename from field_int.
3668         Change type of "value".
3669         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3670         type of "value".
3671         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3672         do_field_int.  Change type of "value".
3673         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3674         do_field_int.  Change type of "value".
3675         * tracepoint.c (trace_status_mi, tfind_1)
3676         (print_one_static_tracepoint_marker): Update.
3677         * thread.c (print_thread_info_1, print_selected_thread_frame):
3678         Update.
3679         * stack.c (print_frame, print_frame_info): Update.
3680         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3681         Update.
3682         * source.c (print_source_lines_base): Update.
3683         * skip.c (info_skip_command): Update.
3684         * record-btrace.c (btrace_ui_out_decode_error)
3685         (btrace_call_history_src_line): Update.
3686         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3687         Update.
3688         * progspace.c (print_program_space): Update.
3689         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3690         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3691         do_field_int.  Change type of "value".
3692         * mi/mi-out.c (mi_ui_out::do_table_begin)
3693         (mi_ui_out::do_table_header): Update.
3694         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3695         type of "value".
3696         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3697         (mi_cmd_data_list_changed_registers, output_register)
3698         (mi_cmd_data_read_memory, mi_load_progress)
3699         (mi_cmd_trace_frame_collected): Update.
3700         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3701         Update.
3702         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3703         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3704         (mi_cmd_var_list_children, varobj_update_one): Update.
3705         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3706         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3707         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3708         * inferior.c (print_inferior): Update.
3709         * gdb_bfd.c (print_one_bfd): Update.
3710         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3711         Update.
3712         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3713         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3714         do_field_int.  Change type of "value".
3715         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3716         do_field_int.  Change type of "value".
3717         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3718         (print_one_breakpoint_location, print_it_catch_fork)
3719         (print_one_catch_fork, print_it_catch_vfork)
3720         (print_one_catch_vfork, print_it_catch_solib)
3721         (print_it_catch_exec, print_it_ranged_breakpoint)
3722         (print_mention_watchpoint, print_mention_masked_watchpoint)
3723         (bkpt_print_it, update_static_tracepoint): Update.
3724         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3725         * break-catch-syscall.c (print_it_catch_syscall): Update.
3726         * ada-tasks.c (print_ada_task_info): Update.
3727         * ada-lang.c (print_it_exception, print_mention_exception):
3728         Update.
3729
3730 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         PR breakpoints/24541
3733         * gdbarch.c: Regenerate.
3734         * gdbarch.h: Regenerate.
3735         * gdbarch.sh: Adjust return type and parameter types for
3736         'stap_adjust_register'.
3737         (i386_stap_adjust_register): Adjust signature and return new
3738         register name.
3739         * stap-probe.c (stap_parse_register_operand): Adjust use of
3740         'gdbarch_stap_adjust_register'.
3741
3742 2019-07-17  Tom Tromey  <tromey@adacore.com>
3743
3744         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3745         declare VEC.
3746         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3747         std::vector.
3748         (struct s390_process_info): Add initializers.
3749         (s390_add_process): Use new.
3750         (s390_linux_nat_target::low_forget_process): Use delete.
3751         (s390_linux_nat_target::low_new_fork)
3752         (s390_linux_nat_target::stopped_by_watchpoint)
3753         (s390_linux_nat_target::low_prepare_to_resume)
3754         (s390_linux_nat_target::insert_watchpoint)
3755         (s390_linux_nat_target::insert_hw_breakpoint)
3756         (s390_linux_nat_target::remove_watchpoint)
3757         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3758
3759 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3760
3761         * aarch64-fbsd-nat.c: Include regcache.h.
3762         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3763         argument.
3764         (aarch64_fbsd_nat_target::fetch_registers)
3765         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3766         variable.
3767         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3768
3769 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3770
3771         * fbsd-nat.c: Include gdbarch.h.
3772
3773 2019-07-15  Tom Tromey  <tromey@adacore.com>
3774
3775         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3776
3777 2019-07-15  Tom Tromey  <tromey@adacore.com>
3778
3779         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3780         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3781         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3782         * cli-out.c (cli_ui_out::do_field_int): New method.
3783         * ui-out.c (ui_out::field_unsigned): New method.
3784         * symfile.c (generic_load): Use field_unsigned.
3785         (print_transfer_performance): Likewise.
3786         * record-btrace.c (ui_out_field_uint): Remove.
3787         (btrace_call_history_insn_range, btrace_call_history): Use
3788         field_unsigned.
3789         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3790         field_unsigned.
3791         * ui-out.h (class ui_out) <field_unsigned>: New method.
3792         <do_field_unsigned>: Likewise.
3793
3794 2019-07-15  Tom Tromey  <tromey@adacore.com>
3795
3796         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3797         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3798         * target.c (flash_erase_command): Use field_string.
3799         * infrun.c (print_signal_received_reason): Use field_string.
3800         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3801         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3802         field_string.
3803         * ada-tasks.c (print_ada_task_info): Use field_string.
3804
3805 2019-07-15  Tom Tromey  <tromey@adacore.com>
3806
3807         * target.c (flash_erase_command): Use field_core_addr.
3808         * symfile.c (generic_load): Use field_core_addr.
3809         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3810         Use field_core_addr.
3811         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3812         field_core_addr.
3813
3814 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3817         value if its desired type is smaller than a CORE_ADDR and signed.
3818
3819 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3822         of changes to field names, and use new is_reference field to
3823         decide if a property is a reference or not.
3824         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3825         field.
3826         (struct dwarf2_property_baton): Update header comment, rename
3827         'referenced_type' to 'property_type' and update comments.
3828         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3829         default property type, store in property baton, update to take
3830         accound of renamed field.
3831         (read_func_scope): Update call to attr_to_dynamic_prop.
3832         (read_array_type): Likewise.
3833         (dwarf2_per_cu_addr_sized_int_type): New function.
3834         (read_subrange_index_type): Move type finding code to
3835         dwarf2_per_cu_addr_sized_int_type.
3836         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3837         (dwarf2_per_cu_addr_type): New function.
3838         (set_die_type): Update calls to attr_to_dynamic_prop.
3839
3840 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3841
3842         * dwarf2read.c (read_subrange_index_type): New function.
3843         (read_subrange_type): Move code into new function and call it.
3844         * gdbtypes.c (create_range_type): Add some asserts.
3845
3846 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3849         update return statements.
3850         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3851         declaration, and update comment to match.
3852         * gdbtypes.c (resolve_dynamic_array): Update call to
3853         dwarf2_evaluate_property to match new return type.
3854
3855 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * valarith.c (value_subscripted_rvalue): Change lowerbound
3858         parameter type from int to LONGEST.
3859         * value.h (value_subscripted_rvalue): Likewise in declaration.
3860
3861 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * cli/cli-utils.c (info_print_command_completer): New function.
3864         * cli/cli-utils.h: Add 'completer.h' include, and forward
3865         declaration for 'struct cmd_list_element'.
3866         (info_print_command_completer): Declare.
3867         * stack.c (_initialize_stack): Add completer for 'info locals' and
3868         'info args'.
3869         * symtab.c (_initialize_symtab): Add completer for 'info
3870         variables' and 'info functions'.
3871         * NEWS: Mention completion for additional info commands.
3872
3873 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * cli/cli-utils.c (extract_info_print_args): Delete.
3876         (extract_arg_maybe_quoted): Delete.
3877         (info_print_options_defs): New variable.
3878         (make_info_print_options_def_group): New function.
3879         (extract_info_print_options): Define new function.
3880         * cli/cli-utils.h (extract_info_print_args): Delete.
3881         (struct info_print_options): New structure.
3882         (extract_info_print_options): Declare new function.
3883         * stack.c (info_locals_command): Update to use new
3884         extract_info_print_options, also add a header comment.
3885         (info_args_command): Likewise.
3886         * symtab.c (info_variables_command): Likewise.
3887         (info_functions_command): Likewise.
3888
3889 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3892         to extract string arguments.
3893         * common/common-utils.c (extract_string_maybe_quoted): New function.
3894         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3895
3896 2019-07-11  Tom Tromey  <tromey@adacore.com>
3897
3898         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3899         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3900         * top.h (gdbinit): Don't declare.
3901         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3902         into...
3903         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3904         * top.c (gdb_init): Don't call init_cli_cmds.
3905         (gdbinit): Remove.
3906         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3907
3908 2019-07-11  Tom Tromey  <tromey@adacore.com>
3909
3910         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3911         after it has been moved.
3912
3913 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         * valops.c (value_must_coerce_to_target): Change return type to
3916         bool.
3917         * value.h (value_must_coerce_to_target): Likewise.
3918
3919 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3920
3921         * breakpoint.c (is_hardware_watchpoint): Remove
3922         forward-declaration.
3923         (is_masked_watchpoint): Change return type to bool.
3924         (is_tracepoint): Likewise.
3925         (is_breakpoint): Likewise.
3926         (is_hardware_watchpoint): Likewise.
3927         (is_watchpoint): Likewise.
3928         (is_no_memory_software_watchpoint): Likewise.
3929         (is_catchpoint): Likewise.
3930         (breakpoint_1): Make FILTER parameter's return type bool.
3931         is_masked_watchpoint): Change return type to bool.
3932         (save_breakpoints): Make FILTER parameter's return type bool.
3933         * breakpoint.h (is_breakpoint): Change return type to bool.
3934         (is_watchpoint): Likewise.
3935         (is_catchpoint): Likewise.
3936         (is_tracepoint): Likewise.
3937
3938 2019-07-10  Tom Tromey  <tom@tromey.com>
3939
3940         * defs.h: Don't include gdbarch.h.
3941         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3942         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3943         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3944         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3945         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3946         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3947         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3948         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3949         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3950         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3951         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3952         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3953         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3954         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3955         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3956         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3957         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3958         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3959         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3960         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3961         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3962         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3963         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3964         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3965         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3966         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3967         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3968
3969 2019-07-10  Tom Tromey  <tromey@adacore.com>
3970
3971         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3972         * breakpoint.c (init_ada_exception_breakpoint): Register as
3973         bp_catchpoint.
3974         (print_one_breakpoint_location, print_one_breakpoint): Use
3975         is_ada_exception_catchpoint.
3976         * ada-lang.c (class ada_catchpoint_location): Pass
3977         bp_loc_software_breakpoint to bp_location constructor.
3978         (is_ada_exception_catchpoint): New function.
3979
3980 2019-07-10  Tom Tromey  <tromey@adacore.com>
3981
3982         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3983         VEC.
3984         (struct arm_exidx_entry): New method operator<.
3985         (struct arm_exidx_data) <section_maps>: Change type.
3986         (arm_exidx_data_free): Remove.
3987         (arm_exidx_data_key): Change type.  Move lower.
3988         (arm_exidx_new_objfile): Update.
3989         (arm_compare_exidx_entries): Remove.
3990         (arm_find_exidx_entry, _initialize_arm_tdep)
3991
3992 2019-07-10  Tom Tromey  <tromey@adacore.com>
3993
3994         * solib-spu.c (ocl_program_data_key): Change type.
3995         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3996         Update.
3997
3998 2019-07-10  Tom Tromey  <tromey@adacore.com>
3999
4000         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4001         (struct solib_aix_inferior_data) <library_list>: Change type.
4002         (solib_aix_inferior_data_handle): Change type.
4003         (get_solib_aix_inferior_data): Update.
4004         (solib_aix_free_library_list): Remove.
4005         (library_list_start_library): Update.
4006         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4007         return type.
4008         (solib_aix_get_library_list)
4009         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4010         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4011
4012 2019-07-10  Tom Tromey  <tromey@adacore.com>
4013
4014         * solib-dsbt.c (struct dsbt_info): Add initializers.
4015         (solib_dsbt_pspace_data): Change type.
4016         (dsbt_pspace_data_cleanup): Remove.
4017         (get_dsbt_info, _initialize_dsbt_solib): Update.
4018
4019 2019-07-10  Tom Tromey  <tromey@adacore.com>
4020
4021         * spu-tdep.c (spu_overlay_data): Change type.
4022         (spu_get_overlay_table, spu_overlay_new_objfile)
4023         (_initialize_spu_tdep): Update.
4024
4025 2019-07-10  Tom Tromey  <tromey@adacore.com>
4026
4027         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4028         destructor.
4029         (dbx_objfile_data_key): Change type and declare later.
4030         (DBX_SYMFILE_INFO): Rewrite.
4031         * dbxread.c (dbx_objfile_data_key): Change type.
4032         (dbx_symfile_init): Update.
4033         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4034         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4035         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4036
4037 2019-07-10  Tom Tromey  <tromey@adacore.com>
4038
4039         * jit.c (jit_program_space_key): Change type.  Move lower.
4040         (get_jit_program_space_data): Update.
4041         (jit_program_space_data_cleanup): Remove.
4042         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4043         Update.
4044         (struct jit_program_space_data): Add initializers.
4045
4046 2019-07-10  Tom Tromey  <tromey@adacore.com>
4047
4048         * solib-darwin.c (struct darwin_info): Add initializers.
4049         (solib_darwin_pspace_data): Change type.
4050         (darwin_pspace_data_cleanup): Remove.
4051         (get_darwin_info, _initialize_darwin_solib): Update.
4052
4053 2019-07-10  Tom Tromey  <tromey@adacore.com>
4054
4055         * remote-sim.c (struct sim_inferior_data): Add initializers,
4056         constructor, and destructor.
4057         (sim_inferior_data_key): Change type.  Move lower.
4058         (check_for_duplicate_sim_descriptor): Update.
4059         (get_sim_inferior_data): Use new.  Update.
4060         (~sim_inferior_data_cleanup): Rename from
4061         sim_inferior_data_cleanup.  Simplify.
4062         (gdbsim_close_inferior, simulator_command)
4063         (sim_command_completer, _initialize_remote_sim): Update.
4064         (next_pid, INITIAL_PID): Move earlier.
4065
4066 2019-07-10  Tom Tromey  <tromey@adacore.com>
4067
4068         * python/python-internal.h (create_thread_object): Return
4069         gdbpy_ref.
4070         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4071         * python/py-inferior.c (struct threadlist_entry): Add
4072         constructor.
4073         <thread_obj>: Now a gdbpy_ref.
4074         (thread_to_thread_object): Update.
4075         (add_thread_object): Use new.
4076         (delete_thread_object): Use delete.
4077         (infpy_threads): Update.
4078         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4079         GIL.
4080
4081 2019-07-10  Tom Tromey  <tromey@adacore.com>
4082
4083         * valops.c (value_cast): Specialize error message for Ada.
4084
4085 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4086
4087         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4088
4089 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4090
4091         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4092         bpstat_should_step): Return bool, adjust comments.
4093         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4094         bpstat_should_step): Likewise.
4095
4096 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * features/Makefile: Use feature target descriptions for Arm.
4099         * features/arm/arm-core.c: Generate new file.
4100         * features/arm/arm-fpa.c: Likewise.
4101         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4102         * features/arm/arm-m-profile.c: Likewise.
4103         * features/arm/arm-vfpv2.c: Likewise.
4104         * features/arm/arm-vfpv3.c: Likewise.
4105         * features/arm/xscale-iwmmxt.c: Likewise.
4106         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4107
4108 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4109
4110         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4111         ptrace earlier.
4112
4113 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4114
4115         * features/aarch64-pauth.c: Regenerate.
4116
4117 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4118
4119         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4120         bool.
4121         (bpstat_what): Use false instead of 0.
4122
4123 2019-07-09  Pedro Alves  <palves@redhat.com>
4124
4125         * break-catch-throw.c (is_exception_catchpoint): New.
4126         * breakpoint.c (print_one_breakpoint_location): New parameter
4127         'raw_loc'.  Handle it.  Use
4128         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4129         looking at the breakpoint's type.
4130         (print_one_breakpoint): If handling "maint info breakpoints", also
4131         print locations of exception catchpoints.
4132         * breakpoint.h (is_exception_catchpoint): Declare.
4133
4134 2019-07-09  Pedro Alves  <palves@redhat.com>
4135
4136         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4137         "addr" field.
4138         (allocate_location_exception_catchpoint): New.
4139         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4140         (initialize_throw_catchpoint_ops): Install
4141         allocate_location_exception_catchpoint as allocate_location
4142         method.
4143         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4144         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4145         bp_loc_other.
4146         (breakpoint_address_is_meaningful): Delete.
4147         (bl_address_is_meaningful): New.
4148         (breakpoint_locations_match): Adjust comment.
4149         (bp_location_from_bp_type): New, factored out of...
4150         (bp_location::bp_location(breakpoint *)): ... this.
4151         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4152         factored out of...
4153         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4154         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4155         breakpoint_address_is_meaningful.
4156         (bp_locations_compare): Adjust comment.
4157         (update_global_location_list): Use bl_address_is_meaningful
4158         instead of breakpoint_address_is_meaningful.
4159         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4160         explicit.
4161         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4162         * python/py-breakpoint.c (bppy_get_location): No longer check
4163         whether location is null.
4164
4165 2019-07-09  Pedro Alves  <palves@redhat.com>
4166
4167         PR c++/15468
4168         * breakpoint.c (print_one_breakpoint_location): Remove
4169         single-location assert.
4170
4171 2019-07-09  Tom Tromey  <tom@tromey.com>
4172
4173         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4174         * configure: Rebuild.
4175         * configure.ac: Change common to gdbsupport.
4176         * gdbsupport: Rename from common.
4177         * acinclude.m4: Change common to gdbsupport.
4178         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4179         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4180         gdbsupport.
4181         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4182         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4183         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4184         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4185         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4186         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4187         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4188         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4189         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4190         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4191         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4192         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4193         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4194         coff-pe-read.c, command.h, compile/compile-c-support.c,
4195         compile/compile-c.h, compile/compile-cplus-symbols.c,
4196         compile/compile-cplus-types.c, compile/compile-cplus.h,
4197         compile/compile-loc2c.c, compile/compile.c, completer.c,
4198         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4199         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4200         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4201         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4202         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4203         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4204         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4205         features/aarch64-core.c, features/aarch64-fpu.c,
4206         features/aarch64-pauth.c, features/aarch64-sve.c,
4207         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4208         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4209         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4210         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4211         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4212         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4213         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4214         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4215         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4216         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4217         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4218         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4219         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4220         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4221         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4222         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4223         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4224         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4225         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4226         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4227         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4228         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4229         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4230         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4231         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4232         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4233         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4234         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4235         minsyms.c, mips-linux-tdep.c, namespace.h,
4236         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4237         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4238         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4239         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4240         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4241         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4242         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4243         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4244         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4245         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4246         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4247         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4248         procfs.c, producer.c, progspace.h, psymtab.h,
4249         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4250         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4251         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4252         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4253         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4254         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4255         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4256         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4257         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4258         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4259         target-memory.c, target.c, target.h, target/waitstatus.c,
4260         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4261         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4262         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4263         unittests/array-view-selftests.c,
4264         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4265         unittests/common-utils-selftests.c,
4266         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4267         unittests/format_pieces-selftests.c,
4268         unittests/function-view-selftests.c,
4269         unittests/lookup_name_info-selftests.c,
4270         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4271         unittests/mkdir-recursive-selftests.c,
4272         unittests/observable-selftests.c,
4273         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4274         unittests/parse-connection-spec-selftests.c,
4275         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4276         unittests/scoped_fd-selftests.c,
4277         unittests/scoped_mmap-selftests.c,
4278         unittests/scoped_restore-selftests.c,
4279         unittests/string_view-selftests.c, unittests/style-selftests.c,
4280         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4281         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4282         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4283         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4284         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4285         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4286
4287 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4290         bool value.
4291         (decode_digits_ordinary): Set explicit_line field in sal.
4292         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4293         symtab_and_line that was set on an explicit line number in
4294         assembler code.  Do always update the recorded symtab and line if
4295         we do skip the prologue.
4296
4297 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4298
4299         * breakpoint.c (set_breakpoint_location_function): Remove
4300         explicit_loc parameter.
4301         (momentary_breakpoint_from_master): Update call to
4302         set_breakpoint_location_function.
4303         (add_location_to_breakpoint): Likewise.
4304
4305 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4308         required features based on default bfd type when no specific bfd
4309         is present.
4310
4311 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4312
4313         * NEWS: Mention that GDB printf and eval commands can now print
4314         C-style and Ada-style convenience var strings without
4315         calling the inferior.
4316         * printcmd.c (printf_c_string): Locally print GDB internal var
4317         instead of transiting via the inferior.
4318         (printf_wide_c_string): Likewise.
4319
4320 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4321
4322         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4323
4324 2019-07-04  Tom Tromey  <tom@tromey.com>
4325
4326         PR tui/24724:
4327         * tui/tui-winsource.c (tui_clear_source_content): Update.
4328         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4329         (tui_update_breakpoint_info): Update.
4330         (tui_set_exec_info_content): Update.
4331         * tui/tui-source.c (tui_set_source_content_nil): Update.
4332         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4333         has_break.
4334         * tui/tui-data.h (enum tui_bp_flag): New.
4335         (tui_bp_flags): New enum flags type.
4336         (struct tui_source_element) <break_mode>: Change type.  Rename
4337         from has_break.
4338         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4339         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4340         constants.
4341         * tui/tui-winsource.h: Fix comment.
4342
4343 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4344
4345         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4346         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4347         (store_fpregs_to_thread)
4348         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4349         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4350         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4351         (IWMMXT_REGS_SIZE): Add define.
4352         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4353         (fetch_vfp_regs, store_vfp_regs)
4354         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4355         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4356
4357 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4358
4359         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4360         defines.
4361         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4362         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4363         (ARM_INT_REGISTER_SIZE): ...to this.
4364         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4365         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4366         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4367         (arm_linux_collect_gregset, supply_nwfpe_register)
4368         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4369         defines.
4370         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4371         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4372         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4373         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4374         (arm_return_in_memory, arm_store_return_value)
4375         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4376         (arm_record_ld_st_multiple): Likewise.
4377         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4378         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4379
4380 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4381
4382         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4383         AARCH64_DISPLACED_MODIFIED_INSNS.
4384         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4385         (aarch64_displaced_step_copy_insn): Likewise.
4386         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4387         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4388         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4389         ARM_DISPLACED_MODIFIED_INSNS.
4390         * arm-tdep.c (arm_gdbarch_init): Likewise.
4391         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4392         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4393         (struct arm_displaced_step_closure): Use
4394         ARM_DISPLACED_MODIFIED_INSNS.
4395
4396 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4397
4398         * features/Makefile: Remove unused xml files.
4399         * features/aarch64.xml: Remove.
4400         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4401         * features/i386/amd64-avx-avx512.xml: Remove.
4402         * features/i386/amd64-avx-linux.xml: Remove.
4403         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4404         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4405         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4406         * features/i386/amd64-avx-mpx.xml: Remove.
4407         * features/i386/amd64-avx.xml: Remove.
4408         * features/i386/amd64-linux.xml: Remove.
4409         * features/i386/amd64-mpx-linux.xml: Remove.
4410         * features/i386/amd64-mpx.xml: Remove.
4411         * features/i386/amd64.xml: Remove.
4412         * features/i386/i386-avx-avx512-linux.xml: Remove.
4413         * features/i386/i386-avx-avx512.xml: Remove.
4414         * features/i386/i386-avx-linux.xml: Remove.
4415         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4416         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4417         * features/i386/i386-avx-mpx-linux.xml: Remove.
4418         * features/i386/i386-avx-mpx.xml: Remove.
4419         * features/i386/i386-avx.xml: Remove.
4420         * features/i386/i386-linux.xml: Remove.
4421         * features/i386/i386-mmx-linux.xml: Remove.
4422         * features/i386/i386-mmx.xml: Remove.
4423         * features/i386/i386-mpx-linux.xml: Remove.
4424         * features/i386/i386-mpx.xml: Remove.
4425         * features/i386/i386.xml: Remove.
4426         * features/i386/x32-avx-avx512-linux.xml: Remove.
4427         * features/i386/x32-avx-linux.xml: Remove.
4428         * features/i386/x32-linux.xml: Remove.
4429
4430 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4431
4432         * regformats/aarch64.dat: Remove.
4433         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4434         * regformats/i386/amd64-avx-linux.dat: Remove.
4435         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4436         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4437         * regformats/i386/amd64-linux.dat: Remove.
4438         * regformats/i386/amd64-mpx-linux.dat: Remove.
4439         * regformats/i386/amd64.dat: Remove.
4440         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4441         * regformats/i386/i386-avx-linux.dat: Remove.
4442         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4443         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4444         * regformats/i386/i386-linux.dat: Remove.
4445         * regformats/i386/i386-mmx-linux.dat: Remove.
4446         * regformats/i386/i386-mpx-linux.dat: Remove.
4447         * regformats/i386/i386.dat: Remove.
4448         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4449         * regformats/i386/x32-avx-linux.dat: Remove.
4450         * regformats/i386/x32-linux.dat: Remove.
4451
4452 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4453
4454         * aarch64-tdep.c: Remove xml self tests.
4455         * amd64-linux-tdep.c: Likewise.
4456         * amd64-tdep.c: Likewise.
4457         * i386-linux-tdep.c: Likewise.
4458         * i386-tdep.c: Likewise.
4459
4460 2019-07-03  Pedro Alves  <palves@redhat.com>
4461
4462         PR cli/24732
4463         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4464         (pipe_cmd_option_defs): New.
4465         (make_pipe_cmd_options_def_group): New.
4466         (pipe_command): Use gdb::option::process_options.
4467         (pipe_command_completer): New function.
4468         (_initialize_cli_cmds): Install completer for "pipe" command.
4469
4470 2019-07-03  Pedro Alves  <palves@redhat.com>
4471
4472         * cli/cli-option.c (union option_value) <string>: New field.
4473         (struct option_def_and_value): Add ctor, move ctor, dtor and
4474         use DISABLE_COPY_AND_ASSIGN.
4475         (option_def_and_value::clear_value): New.
4476         (parse_option, save_option_value_in_ctx, get_val_type_str)
4477         (add_setshow_cmds_for_options): Handle var_string.
4478         * cli-option.h (union option_def::var_address) <string>: New
4479         field.
4480         (struct string_option_def): New.
4481         * maint-test-options.c (struct test_options_opts): Add default
4482         ctor and use DISABLE_COPY_AND_ASSIGN.
4483         <string_opt>: New field.
4484         (test_options_opts::~test_options_opts): New.
4485         (test_options_opts::dump): Also dump "-string".
4486         (test_options_option_defs): Install "string.
4487
4488 2019-07-03  Pedro Alves  <palves@redhat.com>
4489
4490         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4491         option_value with a null enumeration.
4492         (complete_options): Save the option values in the context.
4493         (save_option_value_in_ctx): New, factored out from ...
4494         (process_options): ... here.
4495         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4496         of the function.
4497         * maint-test-options.c (test_options_opts::dump): New, factored
4498         out from ...
4499         (maintenance_test_options_command_mode): ... here.
4500         (maintenance_test_options_command_completion_result): Delete.
4501         (maintenance_test_options_command_completion_text): Update
4502         comment.
4503         (maintenance_show_test_options_completion_result): Change
4504         prototype.  Just print
4505         maintenance_test_options_command_completion_text.
4506         (save_completion_result): New.
4507         (maintenance_test_options_completer_mode): Pass options context to
4508         complete_options, and then save a dump.
4509         (_initialize_maint_test_options): Use add_cmd to install "maint
4510         show test-options-completion-result".
4511
4512 2019-07-03  Pedro Alves  <palves@redhat.com>
4513
4514         * NEWS (New commands): Mention "with" and "maint with".
4515         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4516         (with_command, with_command_completer): New.
4517         (pipe_command): Adjust to new repeat_previous
4518         interface.
4519         (_initialize_cli_cmds): Install the "with" command and its "w"
4520         alias.
4521         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4522         declarations.
4523         * cli/cli-setshow.c (parse_cli_var_uinteger)
4524         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4525         argument strings for all var_types.
4526         (get_setshow_command_value_string): New, factored out from ...
4527         (do_show_command): ... this.
4528         * cli/cli-setshow.h: Include <string>.
4529         (get_setshow_command_value_string): Declare.
4530         * command.h (repeat_previous): Now returns const char *.  Adjust
4531         comment.
4532         * maint.c: Include "cli/cli-cmds.h".
4533         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4534         (_initialize_maint_cmds): Register the "maintenance with" command.
4535         * top.c (repeat_previous): Move bits from pipe_command here:
4536         Return the saved command line, if any; error out if there's no
4537         command to relaunch.
4538
4539 2019-07-03  Pedro Alves  <palves@redhat.com>
4540
4541         * NEWS (New commands): Mention "maint set/show test-settings"
4542         instead of "maint test-settings".
4543         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4544         (maintenance_test_settings_set_list): Rename to ...
4545         (maintenance_set_test_settings_list): ... this.
4546         (maintenance_test_settings_show_list): Rename to  ...
4547         (maintenance_show_test_settings_list): ... this.
4548         (maintenance_test_settings_cmd): Delete.
4549         (maintenance_test_settings_set_cmd): ...
4550         (maintenance_set_test_settings_cmd): ... this.
4551         (maintenance_test_settings_show_cmd): ...
4552         (maintenance_show_test_settings_cmd): ... this.
4553         (maintenance_test_settings_show_value_cmd):
4554         (maintenance_show_test_settings_value_cmd): ... this.
4555         (_initialize_maint_test_settings): No longer install the "maint
4556         test-settings" prefix command.  Rename "maint test-settings set"
4557         to "maint set test-settings", and "maint test-settings show" to
4558         "maint show test-settings".  Adjust all subcommands.
4559
4560 2019-07-03  Pedro Alves  <palves@redhat.com>
4561
4562         * maint-test-settings.c: Fix file's intro comment.  Replace all
4563         references to "test-options" with references to "test-settings",
4564         in comments.
4565
4566 2019-07-03  Pedro Alves  <palves@redhat.com>
4567
4568         * maint-test-settings.c (maintenance_test_settings_xxx)
4569         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4570         New.
4571         (maintenance_test_settings_enums): Use them.
4572         (maintenance_test_settings_enum): Default to
4573         maintenance_test_settings_xxx.
4574         (_initialize_maint_test_settings): Initialize
4575         MAINTENANCE_TEST_SETTINGS_FILENAME.
4576
4577 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4578
4579         * breakpoint.h (remove_breakpoints_inf): Change return type to
4580         void, move function documentation here.
4581         * breakpoint.c (remove_breakpoints_inf): Change return type to
4582         void, move function documentation to header.
4583
4584 2019-07-02  Pedro Alves  <palves@redhat.com>
4585
4586         * NEWS (Completion improvements): Mention "info threads".
4587         * thread.c (struct info_threads_opts, info_threads_option_defs)
4588         (make_info_threads_options_def_group): New.
4589         (info_threads_command): Use gdb::option::process_options.
4590         (info_threads_command_completer): New.
4591         (_initialize_thread): Use gdb::option::build_help to build the
4592         help text for "info threads".
4593
4594 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4595
4596         * defs.h (generic_load): Move from here...
4597         * symfile.h (generic_load): ... to here.  Rename name parameter
4598         to args.
4599         * symfile.c (generic_load): Add comment.
4600
4601 2019-07-01  Tom Tromey  <tromey@adacore.com>
4602
4603         * dwarf2read.c
4604         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4605         declaration of without_params.  Fix formatting.
4606
4607 2019-07-01  Tom Tromey  <tromey@adacore.com>
4608
4609         * ada-exp.y (find_primitive_type): Update.
4610         * ada-lang.h (ada_lookup_symbol): Update.
4611         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4612         parameter.
4613         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4614
4615 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4616
4617         PR breakpoints/24541
4618         * gdbarch.c: Regenerate.
4619         * gdbarch.h: Regenerate.
4620         * gdbarch.sh: Add 'stap_adjust_register'.
4621         * i386-tdep.c: Include '<unordered_set>'.
4622         (i386_stap_adjust_register): New function.
4623         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4624         * stap-probe.c (stap_parse_register_operand): Call
4625         'gdbarch_stap_adjust_register'.
4626
4627 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4628
4629         PR python/24742
4630         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4631         * python/python.c (do_start_initialization): Use 'xmalloc'
4632         instead of 'PyMem_Malloc'.
4633
4634 2019-06-28  Tom Tromey  <tromey@adacore.com>
4635
4636         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4637         for Ada.
4638
4639 2019-06-27  Tom Tromey  <tromey@adacore.com>
4640
4641         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4642         objfile_key.
4643         (arm_find_mapping_symbol, arm_record_special_symbol)
4644         (_initialize_arm_tdep): Update.
4645         (arm_objfile_data_free): Remove.
4646
4647 2019-06-27  Tom Tromey  <tromey@adacore.com>
4648
4649         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4650         to cp_print_static_field.
4651
4652 2019-06-26  Tom Tromey  <tromey@adacore.com>
4653
4654         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4655         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4656         declare.
4657
4658 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4659
4660         * features/aarch64-core.c (create_feature_aarch64_core):
4661         Regenerate.
4662         * features/aarch64-core.xml: Add cpsr flags.
4663
4664 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4667         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4668
4669 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4670
4671         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4672         field.
4673         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4674         use.
4675         (arm_record_special_symbol): Don't insert new symbol in sorted
4676         position, push it at the end.
4677
4678 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4679
4680         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4681         (arm_mapping_symbol_s): Remove.
4682         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4683         (arm_mapping_symbol_vec): New typedef.
4684         (struct arm_per_objfile): Add constructor.
4685         <section_maps>: Change type to
4686         std::unique_ptr<arm_mapping_symbol_vec[]>.
4687         (arm_compare_mapping_symbols): Remove.
4688         (arm_find_mapping_symbol): Adjust to section_maps type change.
4689         (arm_objfile_data_free): Call delete on arm_per_objfile.
4690         (arm_record_special_symbol): Adjust to section_maps type change.
4691         Allocate arm_per_objfile with new.
4692
4693 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4694
4695         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4696         with the command prefix.
4697
4698 2019-06-25  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4701         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4702
4703 2019-06-25  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4706         type.
4707         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4708         protected.
4709
4710 2019-06-25  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui-winsource.c
4713         (tui_source_window_base::set_is_exec_point_at): Add check against
4714         LOA_ADDRESS.
4715
4716 2019-06-25  Tom Tromey  <tom@tromey.com>
4717
4718         * tui/tui-source.c (tui_set_source_content): Don't check before
4719         xfree.
4720         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4721
4722 2019-06-25  Tom Tromey  <tom@tromey.com>
4723
4724         * tui/tui-winsource.h (tui_update_source_window_as_is)
4725         (tui_alloc_source_buffer, tui_line_is_displayed)
4726         (tui_addr_is_displayed): Change type of win_info.
4727         * tui/tui-winsource.c (tui_update_source_window_as_is)
4728         (tui_clear_source_content, tui_show_source_line)
4729         (tui_show_source_content, tui_source_window_base::refill)
4730         (tui_source_window_base::set_is_exec_point_at)
4731         (tui_source_window_base::set_is_exec_point_at)
4732         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4733         (tui_alloc_source_buffer, tui_line_is_displayed)
4734         (tui_addr_is_displayed): Change type of win_info.  Update.
4735         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4736         (tui_source_window_base::do_make_visible_with_new_height):
4737         Update.
4738         * tui/tui-source.c (tui_set_source_content)
4739         (tui_set_source_content_nil)
4740         (tui_source_window::do_scroll_vertical): Update.
4741         * tui/tui-layout.c (show_layout): Update.
4742         * tui/tui-disasm.c (tui_set_disassem_content)
4743         (tui_disasm_window::do_scroll_vertical): Update.
4744         * tui/tui-data.h (tui_win_content): Remove.
4745         (struct tui_gen_win_info) <content, content_size>: Remove.
4746         (struct tui_source_element): Add initializers and destructor.
4747         (union tui_which_element, struct tui_win_element): Remove.
4748         (struct tui_source_window_base) <content>: New field.
4749         (struct tui_data_window): Remove destructor.
4750         (tui_alloc_content, tui_free_win_content)
4751         (tui_free_all_source_wins_content): Don't declare.
4752         * tui/tui-data.c (tui_initialize_static_data): Update.
4753         (init_content_element, tui_alloc_content): Remove.
4754         (~tui_gen_win_info): Update.
4755         (~tui_data_window, tui_free_all_source_wins_content)
4756         (tui_free_win_content, free_content, free_content_elements):
4757         Remove.
4758
4759 2019-06-25  Tom Tromey  <tom@tromey.com>
4760
4761         * tui/tui-winsource.h (tui_clear_source_content)
4762         (tui_erase_source_content, tui_show_source_content): Change type
4763         of win_info.
4764         * tui/tui-winsource.c (tui_clear_source_content)
4765         (tui_erase_source_content, tui_show_source_content): Change type
4766         of win_info.
4767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4768         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4769         win_info.
4770         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4771         win_info.
4772         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4773
4774 2019-06-25  Tom Tromey  <tom@tromey.com>
4775
4776         * tui/tui-winsource.c (tui_clear_source_content)
4777         (tui_source_window_base::set_is_exec_point_at): Update.
4778         * tui/tui-source.c (tui_set_source_content_nil): Update.
4779         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4780         a bool.
4781         * tui/tui-data.c (init_content_element): Update.
4782
4783 2019-06-25  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4786         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4787         * tui/tui-layout.c (init_and_make_win): Update.
4788         * tui/tui.h (enum tui_win_type): Update.
4789         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4790         tui_win_is_auxillary.
4791         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4792         tui_win_is_auxillary.
4793
4794 2019-06-25  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4797         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4798         (tui_delete_data_content_windows, tui_display_all_data)
4799         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4800         Update.
4801         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4802         * tui/tui-regs.c (tui_last_regs_line_no)
4803         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4804         (tui_show_registers): Update.
4805         (tui_show_register_group): Return void.  Update.
4806         (tui_display_registers_from, tui_display_reg_element_at_line)
4807         (tui_display_registers_from_line, tui_check_register_values):
4808         Update.
4809         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4810         member.
4811         (struct tui_data_window) <regs_content>: Now a std::vector.
4812         <regs_content_count>: Remove.
4813         (tui_add_content_elements, tui_free_data_content): Don't declare.
4814         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4815         (init_content_element): Remove DATA_WIN case.  Add assert.
4816         (tui_add_content_elements): Remove.
4817         (tui_data_window): Update.
4818         (tui_free_data_content): Remove.
4819         (free_content_elements): Remove DATA_WIN case.
4820
4821 2019-06-25  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-data.c (tui_data_item_window): Update.
4824         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4825         * tui/tui-windata.c (tui_display_all_data)
4826         (tui_display_data_from_line): Update.
4827         (tui_check_data_values): Remove.
4828         * tui/tui-regs.c (tui_show_register_group)
4829         (tui_display_reg_element_at_line): Update.
4830         * tui/tui-hooks.c (tui_register_changed)
4831         (tui_refresh_frame_and_register_information): Call
4832         tui_check_register_values.
4833         * tui/tui-data.h (struct tui_data_window) <data_content,
4834         data_content_count, data_type>: Remove.
4835         (enum tui_data_type): Remove.
4836
4837         * tui/tui-data.c (tui_data_window::clear_detail)
4838         (~tui_data_window): Update.
4839
4840 2019-06-25  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4843         declare.
4844         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4845         Rename from tui_first_data_item_displayed.  Update.
4846         (tui_data_window::refresh_all)
4847         (tui_data_window::do_scroll_vertical): Update.
4848         * tui/tui-data.h (struct tui_data_window)
4849         <first_data_item_displayed>: Declare new method.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4854         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4855         contents...
4856         (tui_initialize_static_data): ...here.
4857
4858 2019-06-25  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4861         (tui_display_registers_from, tui_check_register_values): Update.
4862         (tui_display_register): Remove win_info parameter; update.
4863         (tui_get_register): Change type of parameters.
4864         * tui/tui-data.h (struct tui_data_element): Remove.
4865         (union tui_which_element) <data>: Remove.
4866         <data_window>: Change type.
4867         (struct tui_data_item_window): New.
4868         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4869         case.  Add assert.
4870         (~tui_data_item_window): New destructor.
4871         (free_content_elements): Remove DATA_ITEM_WIN case.
4872
4873 2019-06-25  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4876         Remove.
4877
4878 2019-06-25  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-data.h (struct tui_command_element): Remove.
4881         (union tui_which_element) <command>: Remove.
4882         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4883         assert.
4884         (free_content_elements): Remove CMD_WIN case.
4885
4886 2019-06-25  Tom Tromey  <tom@tromey.com>
4887
4888         * tui/tui-layout.c (tui_set_layout): Update.
4889         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4890         * tui/tui-data.c (layout_def): Update.
4891
4892 2019-06-25  Tom Tromey  <tom@tromey.com>
4893
4894         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4895         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4896         (tui_source_window_base::set_new_height): Update.
4897         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4898         Update.
4899         (tui_set_locator_fullname, tui_set_locator_info)
4900         (tui_show_frame_info): Update.
4901         * tui/tui-source.c (tui_set_source_content)
4902         (tui_source_is_displayed): Update.
4903         * tui/tui-layout.c (show_source_disasm_command, show_data)
4904         (show_source_or_disasm_and_command): Update.
4905         * tui/tui-disasm.c (tui_set_disassem_content)
4906         (tui_get_begin_asm_address): Update.
4907         * tui/tui-data.h (struct tui_locator_element): Remove.
4908         (union tui_which_element) <locator>: Remove.
4909         (struct tui_locator_window): New.
4910         (tui_locator_win_info_ptr): Change return type.
4911         * tui/tui-data.c (_locator): Change type.
4912         (tui_locator_win_info_ptr): Change return type.
4913         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4914         (tui_alloc_content): Add assert.
4915
4916 2019-06-25  Tom Tromey  <tom@tromey.com>
4917
4918         * tui/tui-winsource.c
4919         (tui_exec_info_window::maybe_allocate_content): New method.
4920         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4921         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4922         (make_source_or_disasm_window): Add cast.
4923         * tui/tui-data.h (union tui_which_element) <simple_string>:
4924         Remove.
4925         (struct tui_source_info): New.
4926         (struct tui_source_window_base) <execution_info>: Change type.
4927         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4928         case, and add assert.
4929         (tui_alloc_content): Add assert.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4934         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4935         * tui/tui-data.c (tui_alloc_win_info): Remove.
4936
4937 2019-06-25  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4940         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4941         can_highlight.
4942
4943 2019-06-25  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4946         make_visible_with_new_height method.
4947         (tui_win_info::make_visible_with_new_height): New method.
4948         (tui_source_window_base::do_make_visible_with_new_height)
4949         (tui_data_window::do_make_visible_with_new_height)
4950         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4951         (make_visible_with_new_height): Remove.
4952         (tui_resize_all, tui_adjust_win_heights): Use
4953         make_visible_with_new_height method.
4954         * tui/tui-data.h (struct tui_win_info)
4955         <do_make_visible_with_new_height, make_visible_with_new_height>:
4956         New methods.
4957         (struct tui_source_window_base, struct tui_data_window)
4958         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4959         methods.
4960
4961 2019-06-25  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4964         method.
4965         (update_tab_width): Call update_tab_width method.
4966         * tui/tui-data.h (struct tui_win_info)
4967         (struct tui_source_window_base) <update_tab_width>: New methods.
4968
4969 2019-06-25  Tom Tromey  <tom@tromey.com>
4970
4971         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4972         parameter.
4973         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4974         parameter.
4975         (tui_gen_win_info::make_visible): Update.
4976         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4977         parameter.
4978         * tui/tui-data.h (enum tui_box): New enum.
4979         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4984         init_and_make_win for EXEC_INFO_WIN.
4985         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4986         longer inline.
4987         (struct tui_win_info) <~tui_win_info>: Inline.
4988         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4989         Don't declare.
4990         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4991         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4992         Remove.
4993         (tui_initialize_static_data): Update.
4994         (~tui_gen_win_info): Handle more cleanup here.
4995         (~tui_source_window_base): Delete "execution_info".
4996         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4997
4998 2019-06-25  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-layout.c (make_command_window): Don't set
5001         can_highlight.
5002         (show_source_disasm_command): Call the reset method.
5003         (show_data): Don't set can_highlight.  Call the reset method.
5004         (tui_gen_win_info::reset): Rename from init_gen_win_info
5005         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5006         (show_source_or_disasm_and_command): Call the reset method.
5007         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5008         (struct tui_cmd_window): Set can_highlight.
5009
5010 2019-06-25  Tom Tromey  <tom@tromey.com>
5011
5012         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5013         from make_visible.
5014         (tui_make_visible, tui_make_invisible): Rewrite.
5015         (tui_win_info::make_visible): Remove.
5016         (tui_source_window_base::make_visible): Update.
5017         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5018         method.  Moved from...
5019         (struct tui_win_info) <make_visible>: ...here.
5020
5021 2019-06-25  Tom Tromey  <tom@tromey.com>
5022
5023         * tui/tui-winsource.c
5024         (tui_source_window_base::do_scroll_horizontal): Remove direction
5025         parameter.
5026         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5027         direction parameter.
5028         * tui/tui-win.c (tui_win_info::forward_scroll)
5029         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5030         (tui_win_info::right_scroll): Update.
5031         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5032         direction parameter.
5033         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5034         direction parameter.
5035         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5036         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5037         Remove direction parameter.
5038         (struct tui_source_window_base, struct tui_source_window)
5039         (struct tui_disasm_window, struct tui_data_window)
5040         (struct tui_cmd_window): Update.
5041
5042 2019-06-25  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-winsource.h (tui_set_exec_info_content)
5045         (tui_show_exec_info_content, tui_erase_exec_info_content)
5046         (tui_clear_exec_info_content, tui_update_exec_info): Change
5047         argument to tui_source_window_base.
5048         * tui/tui-winsource.c (tui_set_exec_info_content)
5049         (tui_show_exec_info_content, tui_erase_exec_info_content)
5050         (tui_clear_exec_info_content, tui_update_exec_info): Change
5051         argument to tui_source_window_base.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5056         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5057
5058 2019-06-25  Tom Tromey  <tom@tromey.com>
5059
5060         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5061         check.
5062
5063 2019-06-25  Tom Tromey  <tom@tromey.com>
5064
5065         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5066         type to void.
5067         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5068         type to void.
5069         * tui/tui-source.c (tui_set_source_content): Update.
5070         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5071
5072 2019-06-25  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-win.c (window_name_completer, tui_set_focus)
5075         (tui_all_windows_info): Use name method.
5076         * tui/tui-data.h (struct tui_gen_win_info)
5077         (struct tui_source_window, struct tui_disasm_window)
5078         (struct tui_data_window, struct tui_cmd_window) <name>: New
5079         method.
5080         (tui_win_name): Don't declare.
5081         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5082         (tui_win_name): Remove.
5083
5084 2019-06-25  Tom Tromey  <tom@tromey.com>
5085
5086         * tui/tui-winsource.h (tui_update_source_window)
5087         (tui_update_source_window_as_is): Change parameter type.
5088         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5089         to be a tui_source_window_base.
5090         (tui_update_source_window_as_is): Likewise.
5091         * tui/tui-win.c (make_visible_with_new_height): Update.
5092
5093 2019-06-25  Tom Tromey  <tom@tromey.com>
5094
5095         * tui/tui-winsource.c (tui_erase_source_content)
5096         (tui_show_source_content, tui_show_exec_info_content)
5097         (tui_erase_exec_info_content): Use refresh_window method.
5098         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5099         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5100         from tui_refresh_win.
5101         (tui_data_window::refresh_window): New method.
5102         (tui_win_info::refresh, tui_source_window_base::refresh)
5103         (tui_refresh_all): Use refresh_window method.
5104         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5105         method.
5106         * tui/tui-regs.c (tui_display_register): Call refresh_window
5107         method.
5108         * tui/tui-layout.c (show_source_disasm_command)
5109         (show_source_or_disasm_and_command): Call refresh_window method.
5110         * tui/tui-data.h (struct tui_gen_win_info)
5111         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5112         New method.
5113
5114 2019-06-25  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui.c (tui_rl_other_window, tui_enable)
5117         (tui_is_window_visible, tui_get_command_dimension): Update.
5118         * tui/tui-winsource.c (tui_update_source_window_as_is)
5119         (tui_clear_source_content, tui_erase_source_content)
5120         (tui_show_source_line, tui_source_window_base::refill)
5121         (tui_source_window_base::do_scroll_horizontal)
5122         (tui_source_window_base::set_is_exec_point_at)
5123         (tui_update_breakpoint_info, tui_set_exec_info_content)
5124         (tui_alloc_source_buffer, tui_line_is_displayed)
5125         (tui_addr_is_displayed): Update.
5126         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5127         (tui_check_and_display_highlight_if_needed)
5128         (tui_win_info::make_visible, tui_win_info::refresh)
5129         (tui_refresh_all): Update.
5130         * tui/tui-windata.c (tui_first_data_item_displayed)
5131         (tui_delete_data_content_windows, tui_erase_data_content)
5132         (tui_display_all_data, tui_data_window::refresh_all)
5133         (tui_check_data_values): Update.
5134         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5135         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5136         (tui_win_info::backward_scroll, tui_refresh_all_win)
5137         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5138         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5139         (tui_source_window_base::set_new_height)
5140         (tui_data_window::set_new_height)
5141         (make_invisible_and_set_new_height)
5142         (make_visible_with_new_height, new_height_ok)
5143         (parse_scrolling_args): Update.
5144         * tui/tui-stack.c (tui_show_frame_info): Update.
5145         * tui/tui-source.c (tui_set_source_content)
5146         (tui_set_source_content_nil, tui_source_is_displayed)
5147         (tui_source_window::do_scroll_vertical): Update.
5148         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5149         (tui_display_registers_from, tui_display_reg_element_at_line)
5150         (tui_check_register_values, tui_reg_command): Update.
5151         * tui/tui-layout.c (tui_default_win_height)
5152         (show_source_disasm_command, show_data, init_and_make_win)
5153         (show_source_or_disasm_and_command): Update.
5154         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5155         (tui_redisplay_readline, tui_mld_flush)
5156         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5157         (tui_getc): Update.
5158         * tui/tui-disasm.c (tui_set_disassem_content)
5159         (tui_disasm_window::do_scroll_vertical): Update.
5160         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5161         Now virtual.
5162         (struct tui_win_info): Derive from tui_gen_win_info.
5163         <~tui_win_info>: Mark as override.
5164         <generic>: Remove member.
5165         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5166         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5167         (~tui_data_window, ~tui_win_info)
5168         (tui_free_all_source_wins_content): Update.
5169         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5170
5171 2019-06-25  Tom Tromey  <tom@tromey.com>
5172
5173         * tui/tui-layout.c (init_and_make_win): Use new.
5174         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5175         destructor, initializers.
5176         (tui_alloc_generic_win_info): Don't declare.
5177         * tui/tui-data.c (_locator): Add argument to constructor.
5178         (source_win, disasm_win): New globals.
5179         (exec_info): Remove.
5180         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5181         Update.
5182         (tui_alloc_generic_win_info): Remove.
5183         (init_content_element): Use new.
5184         (tui_win_info::tui_win_info): Update.
5185         (free_content_elements) <case DATA_WIN>: Use delete.
5186
5187 2019-06-25  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5190         * tui/tui-windata.c (tui_first_data_item_displayed)
5191         (tui_delete_data_content_windows): Update.
5192         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5193         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5194         (tui_display_registers_from, tui_check_register_values): Update.
5195         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5196         pointer.
5197         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5198         window.
5199         (tui_free_data_content): Update.
5200         (free_content_elements) <case DATA_WIN>: Free the window.
5201
5202 2019-06-25  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5205         Update.
5206         * tui/tui-layout.c (make_command_window)
5207         (show_source_disasm_command, show_data, init_and_make_win)
5208         (show_source_or_disasm_and_command): Update.
5209         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5210         method.
5211         <can_highight, is_highlighted>: Now bool.
5212         (tui_set_win_highlight): Don't declare.
5213         * tui/tui-data.c (tui_set_win_highlight): Remove.
5214
5215 2019-06-25  Tom Tromey  <tom@tromey.com>
5216
5217         * tui/tui-wingeneral.c (make_visible): Remove check of window
5218         type.
5219
5220 2019-06-25  Tom Tromey  <tom@tromey.com>
5221
5222         * tui/tui-win.c (tui_win_info::max_height)
5223         (tui_cmd_window::max_height): New methods.
5224         (new_height_ok): Call max_height.
5225         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5226         <max_height>: New method.
5227
5228 2019-06-25  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-win.c (tui_source_window_base::set_new_height)
5231         (tui_data_window::set_new_height): New methods.
5232         (make_invisible_and_set_new_height): Call set_new_height method.
5233         * tui/tui-data.h (struct tui_win_info)
5234         (struct tui_source_window_base, struct tui_data_window)
5235         <set_new_height>: New method.
5236
5237 2019-06-25  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5240         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5241         tui_refresh_data_win.
5242         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5243         method.
5244         (tui_refresh_all_win): Call the refresh_all method.
5245         (tui_set_focus): Likewise.
5246         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5247         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5248         Likewise.
5249
5250 2019-06-25  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-winsource.h (tui_refill_source_window)
5253         (tui_set_is_exec_point_at): Don't declare.
5254         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5255         (tui_source_window_base::refill): Rename from
5256         tui_refill_source_window.
5257         (tui_source_window_base::do_scroll_horizontal): Update.
5258         (tui_source_window_base::set_is_exec_point_at): Rename from
5259         tui_set_is_exec_point_at.
5260         (tui_update_all_breakpoint_info): Update.
5261         * tui/tui-stack.c (tui_show_frame_info): Update.
5262         * tui/tui-layout.c (show_data): Add cast.
5263         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5264         * tui/tui-data.h (struct tui_source_window_base) <refill,
5265         set_is_exec_point_at>: New methods.
5266         (tui_source_windows, tui_add_to_source_windows): Update types.
5267         (tui_add_to_source_windows): Remove redundant declaration.
5268         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5269         (tui_source_windows): Change return type.
5270         (tui_clear_source_windows_detail): Update.
5271         (tui_add_to_source_windows): Change type of parameter.
5272         (tui_free_all_source_wins_content): Update.
5273
5274 2019-06-25  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-wingeneral.c (tui_win_info::refresh)
5277         (tui_source_window_base::refresh): New methods.
5278         (tui_refresh_all): Call the refresh method.
5279         * tui/tui-data.h (struct tui_win_info)
5280         (struct tui_source_window_base) <refresh>: New method.
5281
5282 2019-06-25  Tom Tromey  <tom@tromey.com>
5283
5284         * tui/tui.h (tui_is_window_visible): Return bool.
5285         * tui/tui.c (tui_is_window_visible): Return bool.
5286         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5287         (tui_make_visible, tui_make_invisible)
5288         (tui_win_info::make_visible)
5289         (tui_source_window_base::make_visible, make_all_visible)
5290         (tui_make_all_visible, tui_make_all_invisible): Update.
5291         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5292         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5293         bool.
5294         (struct tui_win_info, struct tui_source_window_base)
5295         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5296         * tui/tui-data.c (tui_init_generic_part): Update.
5297
5298 2019-06-25  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5301         (tui_source_window_base::make_visible): New methods.
5302         (make_all_visible): Make method call.
5303         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5304         (struct tui_source_window_base, struct tui_cmd_window): Override
5305         make_visible.
5306         (tui_win_is_source_type): Don't declare.
5307         * tui/tui-data.c (tui_win_is_source_type): Remove.
5308
5309 2019-06-25  Tom Tromey  <tom@tromey.com>
5310
5311         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5312         NULL check.
5313
5314 2019-06-25  Tom Tromey  <tom@tromey.com>
5315
5316         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5317         Inline constructor.  Add initializers for members.
5318         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5319         constructors; now inline in class.
5320
5321 2019-06-25  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-regs.c (tui_show_registers): Update.
5324         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5325         bool.
5326         * tui/tui-data.c (tui_data_window::clear_detail)
5327         (tui_data_window): Update.
5328
5329 2019-06-25  Tom Tromey  <tom@tromey.com>
5330
5331         * tui/tui-windata.c (tui_display_all_data)
5332         (tui_display_data_from_line, tui_display_data_from)
5333         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5334         Update.
5335         * tui/tui-regs.c (tui_last_regs_line_no)
5336         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5337         (tui_show_registers, tui_show_register_group)
5338         (tui_display_registers_from, tui_display_reg_element_at_line)
5339         (tui_display_registers_from_line, tui_check_register_values)
5340         (tui_reg_next, tui_reg_prev): Update.
5341         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5342         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5343         tui_data_window.
5344         (struct tui_win_info) <detail>: Remove.  Add new fields from
5345         tui_data_info.
5346         (TUI_DATA_WIN): Add cast.
5347         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5348         (~tui_data_window): Simplify.
5349
5350 2019-06-25  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-layout.c (show_source_disasm_command)
5353         (show_source_or_disasm_and_command): Update.
5354         * tui/tui-io.c (update_cmdwin_start_line)
5355         (tui_redisplay_readline): Update.
5356         * tui/tui-data.h (struct tui_command_info): Remove.
5357         (struct tui_win_info) <detail>: Remove command_info member.
5358         (struct tui_data_window) <start_line>: New member, from
5359         tui_command_info.
5360         (TUI_CMD_WIN): Add casts.
5361
5362 2019-06-25  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-winsource.c (tui_update_source_window)
5365         (tui_refill_source_window)
5366         (tui_source_window_base::do_scroll_horizontal)
5367         (tui_update_breakpoint_info, tui_set_exec_info_content)
5368         (tui_show_exec_info_content, tui_erase_exec_info_content)
5369         (tui_clear_exec_info_content): Update.
5370         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5371         Update.
5372         * tui/tui-win.c (make_invisible_and_set_new_height)
5373         (make_visible_with_new_height): Update.
5374         * tui/tui-source.c (tui_set_source_content)
5375         (tui_show_symtab_source): Update.
5376         * tui/tui-layout.c (extract_display_start_addr)
5377         (show_source_disasm_command, show_data)
5378         (make_source_or_disasm_window)
5379         (show_source_or_disasm_and_command): Update.
5380         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5381         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5382         "gdbarch".
5383         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5384         to tui_source_window_base.
5385         (struct tui_win_info) <detail>: Remove source_info member.
5386         (struct tui_source_window_base) <has_locator>: Inline.
5387         Move contents from tui_source_info; rename has_locator member to
5388         m_has_locator.
5389         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5390         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5391         header file.
5392         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5393         Simplify.
5394         (tui_free_all_source_wins_content): Cast to
5395         tui_source_window_base.
5396
5397 2019-06-25  Tom Tromey  <tom@tromey.com>
5398
5399         * tui/tui-win.c (make_invisible_and_set_new_height)
5400         (make_visible_with_new_height): Call has_locator method.
5401         * tui/tui-layout.c (show_source_disasm_command, show_data)
5402         (show_source_or_disasm_and_command): Update for bool change.
5403         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5404         (tui_win_info) <has_locator>: New method.
5405         (struct tui_source_window_base) <has_locator>: New method.
5406         (tui_win_has_locator): Don't declare.
5407         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5408         from tui_win_has_locator.
5409         (tui_source_window_base): Use false, not FALSE.
5410
5411 2019-06-25  Tom Tromey  <tom@tromey.com>
5412
5413         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5414         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5415         clear_detail method directly.
5416         (tui_clear_win_detail): Remove.
5417
5418 2019-06-25  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5421         "this", not TUI_DISASM_WIN.
5422
5423 2019-06-25  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5426         declare.
5427         * tui/tui-winsource.c
5428         (tui_source_window_base::do_scroll_horizontal): Rename from
5429         tui_horizontal_source_scroll.
5430         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5431         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5432         from tui_vertical_data_scroll.
5433         * tui/tui-win.h (tui_scroll): Don't declare.
5434         * tui/tui-win.c (tui_win_info::forward_scroll)
5435         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5436         (tui_win_info::right_scroll): Rename and update.
5437         (tui_scroll_forward_command, tui_scroll_backward_command)
5438         (tui_scroll_left_command, tui_scroll_right_command): Update.
5439         (tui_scroll): Remove.
5440         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5441         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5442         from tui_vertical_source_scroll.
5443         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5444         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5445         from tui_vertical_disassem_scroll.
5446         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5447         do_scroll_horizontal>: New methods.
5448         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5449         Likewise.
5450         (struct tui_source_window_base): Add do_scroll_horizontal.
5451         (struct tui_source_window, struct tui_disasm_window): Add
5452         do_scroll_vertical.
5453         (struct tui_data_window, struct tui_cmd_window): Add
5454         do_scroll_horizontal and do_scroll_vertical.
5455         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-data.h (struct tui_source_window_base): New struct.
5460         (struct tui_source_window): Derive from tui_source_window_base.
5461         (struct tui_disasm_window): New struct.
5462         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5463         from tui_source_window::clear_detail.
5464         (tui_source_window_base): Rename from tui_source_window.
5465         (~tui_source_window_base): Rename from ~tui_source_window.
5466         (tui_alloc_win_info): Create a tui_disasm_window.
5467
5468 2019-06-25  Tom Tromey  <tom@tromey.com>
5469
5470         * tui/tui-data.h (struct tui_source_window)
5471         (struct tui_data_window): Declare destructors.
5472         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5473         destructors.
5474         (tui_win_info): Simplify.
5475
5476 2019-06-25  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-winsource.c (tui_display_main)
5479         (tui_update_source_windows_with_addr)
5480         (tui_update_all_breakpoint_info): Update.
5481         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5482         (new_height_ok, parse_scrolling_args): Update.
5483         * tui/tui-stack.c (tui_show_frame_info): Update.
5484         * tui/tui-data.h (struct tui_list): Remove.
5485         (tui_source_windows): Return a reference to a std::vector.
5486         * tui/tui-data.c (source_windows): Now a std::vector.
5487         (tui_source_windows): Change return type.
5488         (tui_clear_source_windows): Rewrite.
5489         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5490         (tui_free_all_source_wins_content): Rewrite.
5491
5492 2019-06-25  Tom Tromey  <tom@tromey.com>
5493
5494         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5495         (struct tui_data_window, struct tui_cmd_window): Declare
5496         clear_detail method.
5497         * tui/tui-data.c (tui_source_window::clear_detail)
5498         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5499         methods.
5500         (tui_clear_win_detail): Simplify.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-layout.c (make_source_window, make_disasm_window)
5505         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5506         Return the new window.
5507         (show_source_disasm_command, show_data)
5508         (show_source_or_disasm_and_command): Update.
5509
5510 2019-06-25  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5513         parameter.  Return the new window.
5514         (show_source_disasm_command): Update and remove NULL check.
5515         (show_source_or_disasm_and_command): Update.
5516
5517 2019-06-25  Tom Tromey  <tom@tromey.com>
5518
5519         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5520
5521 2019-06-25  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-data.h (struct tui_win_info): Make constructor
5524         protected.  Make destructor virtual.  Add initializers.
5525         (tui_source_window, tui_data_window, tui_cmd_window): New
5526         classes.
5527         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5528         constructor.  Add "type" parameter.
5529         (tui_source_window, tui_data_window, tui_cmd_window): New
5530         constructors.
5531         (tui_alloc_win_info): Instantiate the appropriate subclass.
5532
5533 2019-06-25  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-win.c (tui_resize_all): Use delete.
5536         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5537         destructor.
5538         (tui_free_window): Don't declare.
5539         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5540         Update.
5541
5542 2019-06-25  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-data.h (struct tui_win_info): Add constructor.
5545         * tui/tui-data.c (tui_alloc_win_info): Use new.
5546         (tui_free_window): Use delete.
5547
5548 2019-06-22  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5551         declare.
5552         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5553
5554 2019-06-22  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5557         declare.
5558         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5559
5560 2019-06-22  Tom de Vries  <tdevries@suse.de>
5561
5562         * dwarf2read.c (create_addrmap_from_aranges)
5563         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5564         instead of '%zu'.
5565
5566 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5567
5568         * dwarf2read.h (dwarf2_section_info_def): Remove.
5569         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5570         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5571         std::vector<dwarf2_section_info>.
5572         (struct dwo_file) <~dwo_file>: Remove.
5573         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5574         types field.
5575         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5576         (dwarf2_read_debug_names): Likewise.
5577         (create_debug_types_hash_table): Change parameter type to
5578         array_view, adjust code accordingly.
5579         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5580         (partial_die_info::fixup): Likewise.
5581         (determine_prefix): Likewise.
5582         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5583
5584 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5585
5586         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5587         gdb_bfd_ref_ptr.
5588         <~dwo_file>: Remove call to gdb_bfd_unref.
5589         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5590         gdb_bfd_ref_ptr::get.
5591
5592 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5593
5594         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5595         type to htab_up.
5596         * dwarf2read.c (struct dwo_file): Initialize fields.
5597         <~dwo_file>: New.
5598         (free_dwo_file): Remove, move content to ~dwo_file.
5599         (struct dwo_file_deleter): Remove.
5600         (dwo_file_up>: Remove custom deleter.
5601         (free_dwo_files): Remove.
5602         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5603         dwo_files.
5604         (process_skeletonless_type_units): Call unique_ptr::get.
5605         (allocate_dwo_file_hash_table): Add deleter to created hash
5606         table.  Change return type to htab_up.
5607         (lookup_dwo_file_slot): Don't memset dwo_file, call
5608         unique_ptr::get.
5609         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5610         (create_dwo_unit_in_dwp_v2): Likewise.
5611         (open_and_init_dwo_file): Likewise.
5612         (free_dwo_file_from_slot): Remove.
5613
5614 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5615
5616         * dwarf2read.h (struct dwarf2_section_info) <readin,
5617         is_virtual>: Change type to bool.
5618         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5619         true instead of 1.
5620
5621 2019-06-19  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-data.h (tui_init_content_element): Don't declare.
5624
5625 2019-06-19  Tom Tromey  <tom@tromey.com>
5626
5627         * tui/tui-data.h (tui_init_win_info): Don't declare.
5628
5629 2019-06-19  Tom de Vries  <tdevries@suse.de>
5630
5631         * dwarf2read.h (abstract_to_concrete): Change type to
5632         std::unordered_map<sect_offset, std::vector<sect_offset>,
5633         gdb::hash_enum<sect_offset>>.
5634
5635 2019-06-19  Tom Tromey  <tromey@adacore.com>
5636
5637         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5638         EVAL_AVOID_SIDE_EFFECTS specially.
5639
5640 2019-06-19  Tom Tromey  <tromey@adacore.com>
5641
5642         * source-cache.c (highlighter): New global.
5643         (source_cache::get_source_lines): Create a highlighter on demand.
5644
5645 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * defs.h (deprecated_interactive_hook): Delete declaration.
5648         * interps.c (clear_interpreter_hooks): Remove use of
5649         deprecated_interactive_hook.
5650         * top.c (deprecated_interactive_hook): Delete definition.
5651         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5652
5653 2019-06-18  Tom de Vries  <tdevries@suse.de>
5654
5655         PR gdb/24515
5656         * dwarf2read.h (abstract_to_concrete): Change type from
5657         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5658         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5659         * dwarf2read.c (read_variable): Update.
5660         (dwarf2_fetch_die_loc_sect_off): Update.
5661
5662 2019-06-17  Tom de Vries  <tdevries@suse.de>
5663
5664         PR gdb/24617
5665         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5666         accessing parent[parent_len - 1].
5667
5668 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5669
5670         PR gdb/24364
5671         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5672         call dtrace_process_dof with NULL dof.
5673
5674 2019-06-16  Tom de Vries  <tdevries@suse.de>
5675
5676         PR gdb/24445
5677         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5678
5679 2019-06-16  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5682         (make_all_visible): Use address of member.
5683
5684 2019-06-16  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5687         (tui_free_window, free_content, free_content_elements): Remove
5688         unnecessary cast.
5689         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5690         cast.
5691         * tui/tui-regs.c (tui_show_register_group)
5692         (tui_display_registers_from, tui_display_reg_element_at_line):
5693         Remove unnecessary cast.
5694
5695 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * linux-nat.c (normal_mask): Delete.
5698         (_initialize_linux_nat): Don't initialise normal_mask.
5699
5700 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5701
5702         PR gdb/24445
5703         * dwarf-index-write.h (write_psymtabs_to_index): Add
5704         dwz_basename parameter.
5705         * dwarf-index-write.c (write_gdbindex): Move file writing to
5706         write_gdbindex_1.  Change return type void.
5707         (assert_file_size): Move up, remove filename parameter.
5708         (write_gdbindex_1): New function.
5709         (write_debug_names): Change return type to void, call
5710         assert_file_size.
5711         (struct index_wip_file): New struct.
5712         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5713         file logic to index_wip_file.  Write index for dwz file if
5714         needed.
5715         (save_gdb_index_command): Pass basename of dwz file, if present.
5716         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5717         build-id of dwz file, if present.
5718         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5719         (dwarf2_get_dwz_file): Likewise.
5720         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5721         (dwarf2_get_dwz_file): Likewise.
5722
5723 2019-06-16  Tom Tromey  <tom@tromey.com>
5724
5725         * coffread.c (process_coff_symbol): Use xstrdup.
5726         * value.c (create_internalvar): Use xstrdup.
5727
5728 2019-06-16  Tom Tromey  <tom@tromey.com>
5729
5730         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5731         * breakpoint.c (stopin_command, stopat_command)
5732         (until_break_command, decode_location_default): Remove unnecessary
5733         cast.
5734         * utils.c (subset_compare): Remove unnecessary cast.
5735         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5736         cast.
5737         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5738         cast.
5739         * infcmd.c (path_command): Remove unnecessary cast.
5740         * coffread.c (decode_type): Remove unnecessary cast.
5741         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5742         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5743         * tui/tui-stack.c (tui_show_locator_content)
5744         (tui_show_frame_info): Remove unnecessary cast.
5745         * tui/tui-win.c (tui_scroll_forward_command)
5746         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5747         (parse_scrolling_args): Remove unnecessary cast.
5748         * tui/tui-data.c (init_win_info, tui_del_window)
5749         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5750         (free_content_elements): Remove unnecessary cast.
5751         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5752         unnecessary cast.
5753         * tui/tui-source.c (tui_set_source_content)
5754         (tui_vertical_source_scroll): Remove unnecessary cast.
5755         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5756         cast.
5757         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5758         * tui/tui-regs.c (tui_display_registers_from)
5759         (tui_display_register): Remove unnecessary cast.
5760         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5761         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5762         (make_visible): Remove unnecessary cast.
5763         * tui/tui-winsource.c (tui_erase_source_content)
5764         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5765         unnecessary cast.
5766         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5767         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5768         * stabsread.c (read_type, read_array_type, read_range_type):
5769         Remove unnecessary cast.
5770         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5771         (parse_symbol, parse_type, upgrade_type, parse_external)
5772         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5773         unnecessary cast.
5774         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5775
5776 2019-06-16  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-data.c (tui_alloc_generic_win_info)
5779         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5780         checks.
5781
5782 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5783             Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * f-typeprint.c (f_print_type): Don't return early for not
5786         associated or not allocated types.
5787         (f_type_print_varspec_suffix): Add print_rank parameter and print
5788         ranks of array types in case they dangling.
5789         (f_type_print_base): Add print_rank parameter.
5790
5791 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5792
5793         * NEWS: Mention new MI commands.
5794         * break-catch-throw.c (enum exception_event_kind): Move to
5795         breakpoint.h.
5796         (print_mention_exception_catchpoint): Output text as a single
5797         message.
5798         (catch_exception_command_1): Rename to...
5799         (catch_exception_event): ...this, make non-static, update header
5800         command, and change some parameter types.
5801         (catch_catch_command): Update for changes to
5802         catch_exception_command_1.
5803         (catch_throw_command): Likewise.
5804         (catch_rethrow_command): Likewise.
5805         * breakpoint.c (enum exception_event_kind): Delete.
5806         * breakpoint.h (enum exception_event_kind): Moved here from
5807         break-catch-throw.c.
5808         (catch_exception_event): Declare.
5809         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5810         (mi_cmd_catch_throw): New function.
5811         (mi_cmd_catch_rethrow): New function.
5812         (mi_cmd_catch_catch): New function.
5813         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5814         'catch-catch' entries.
5815         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5816         (mi_cmd_catch_rethrow): Declare.
5817         (mi_cmd_catch_catch): Declare.
5818
5819 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5820
5821         * annotate.c (annotate_source_line): Change return type to void,
5822         update implementation to match.
5823         * annotate.h (annotate_source_line): Change return type to void,
5824         update header comment.
5825         * stack.c (print_frame_info): Don't change what frame information
5826         is printed based on whether annotations are on or not.
5827
5828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5831         (annotate_source): Make static.
5832         (annotate_source_line): Moved from source.c and renamed from
5833         identify_source_line.  Update the return type.
5834         * annotate.h (annotate_source): Delete declaration.
5835         (annotate_source_line): Declaration moved from source.h, and
5836         renamed from identify_source_line.  Return type updated.
5837         * source.c (identify_source_line): Moved to annotate.c and renamed
5838         to annotate_source_line.
5839         (info_line_command): Remove check of annotation_level.
5840         * source.h (identify_source_line): Move declaration to annotate.h
5841         and rename to annotate_source_line.
5842         * stack.c: Add 'annotate.h' include.
5843         (print_frame_info): Remove check of annotation_level before
5844         calling annotate_source_line.
5845
5846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * source-cache.c (source_cache::get_plain_source_lines): Use
5849         open_source_file_with_line_charpos instead of just
5850         open_source_file, remove call to find_source_lines.
5851         (source_cache::get_source_lines): Likewise.
5852         * source.c (find_source_lines): Make static.
5853         (get_filename_and_charpos): Renamed into...
5854         (open_source_file_with_line_charpos): ..this along with changes to
5855         return a scoped_fd, and some other minor clean ups.
5856         (identify_source_line): Use open_source_file_with_line_charpos.
5857         (search_command_helper): Use open_source_file_with_line_charpos
5858         instead of just open_source_file, remove call to
5859         find_source_lines.
5860         * source.h (open_source_file_with_line_charpos): Declare new
5861         function.
5862         (find_source_lines): Delete declaration.
5863
5864 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5865
5866         * source.c (get_filename_and_charpos): Remove fullname
5867         parameter.
5868         (identify_source_line): Update call to get_filename_and_charpos.
5869
5870 2019-06-14  Tom Tromey  <tromey@adacore.com>
5871
5872         PR gdb/24502:
5873         * ui-style.h (skip_ansi_escape): Update comment.
5874         * ui-file.h (class no_terminal_escape_file): New class.
5875         * ui-file.c (no_terminal_escape_file::write)
5876         (no_terminal_escape_file::puts): New methods.
5877         * cli/cli-logging.c (handle_redirections): Use
5878         no_terminal_escape_file.
5879
5880 2019-06-14  Tom Tromey  <tromey@adacore.com>
5881
5882         * NEWS: Move convenience variable news above Python news.
5883
5884 2019-06-14  Tom Tromey  <tom@tromey.com>
5885
5886         * gnulib: Move directory to top-level.
5887         * configure.ac: Don't configure gnulib.
5888         * configure: Rebuild.
5889         * common/common-defs.h: Use new path to gnulib.
5890         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5891         (GNULIB_H): Remove.
5892         (INCGNU): Look in new gnulib location.
5893         (HFILES_NO_SRCDIR): Remove gnulib files.
5894         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5895         (generated_files): Remove GNULIB_H.
5896         ($(LIBGNU), all-lib): Remove targets.
5897         (distclean): Don't mention GNULIB_BUILDDIR.
5898         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5899
5900 2019-06-14  Tom Tromey  <tromey@adacore.com>
5901
5902         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5903         Warn if symbol file does not provide any symbols.
5904
5905 2019-06-14  Tom Tromey  <tromey@adacore.com>
5906
5907         * source.c (find_and_open_source): Respect basenames_may_differ.
5908
5909 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * annotate.c (annotate_breakpoints_invalid): Make use of
5912         scoped_restore_terminal_state.
5913         (annotate_frames_invalid): Likewise.
5914
5915 2019-06-14  Tom Tromey  <tromey@adacore.com>
5916
5917         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5918         allow assignment to an internalvar.
5919
5920 2019-06-14  Tom Tromey  <tromey@adacore.com>
5921
5922         * ada-lex.l: Allow "_" in attribute names.
5923
5924 2019-06-14  Tom Tromey  <tromey@adacore.com>
5925
5926         PR gdb/24653:
5927         * regcache.c (registers_changed): Don't call alloca.
5928         * top.c (execute_command): Don't call alloca.
5929
5930 2019-06-13  Pedro Alves  <palves@redhat.com>
5931
5932         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5933         'expression'.  When parsing an expression, error out if there's
5934         junk after "unlimited".
5935         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5936         (do_set_command): Adjust calls to is_unlimited_literal.
5937
5938 2019-06-13  Pedro Alves  <palves@redhat.com>
5939
5940         * compile/compile.c (make_compile_options_def_group): Add braces
5941         around array_view initializer.
5942         * thread.c (make_thread_apply_all_options_def_group)
5943         (make_thread_apply_all_options_def_group): Likewise.
5944
5945 2019-06-13  Pedro Alves  <palves@redhat.com>
5946
5947         * NEWS (New commands): Mention "maint test-options
5948         require-delimiter", "maint test-options unknown-is-error", "maint
5949         test-options unknown-is-operand" and "maint show
5950         test-options-completion-result".
5951         (New command options, command completion): New section.
5952         (Completion improvements): New section.
5953         Mention that you can abbreviate "unlimited".
5954
5955 2019-06-13  Pedro Alves  <palves@redhat.com>
5956
5957         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5958         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5959         * unittests/cli-utils-selftests.c (test_parse_flags)
5960         (test_parse_flags_qcs): Delete.
5961         (test_cli_utils): Don't call deleted functions.
5962
5963 2019-06-13  Pedro Alves  <palves@redhat.com>
5964
5965         * thread.c: Include "cli/cli-option.h".
5966         (tp_array_compar_ascending): Global.
5967         (tp_array_compar): Delete function.
5968         (tp_array_compar_ascending, tp_array_compar_descending): New
5969         functions.
5970         (ascending_option_def, qcs_flag_option_def)
5971         (thr_qcs_flags_option_defs)
5972         (make_thread_apply_all_options_def_group)
5973         (make_thread_apply_options_def_group): New.
5974         (thread_apply_all_command): Use gdb::option::process_options.
5975         (thread_apply_command_completer)
5976         (thread_apply_all_command_completer): New.
5977         (thread_apply_command): Use gdb::option::process_options.
5978         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5979         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5980         to generate help text of "thread apply".  Adjust "taas"'s help.
5981         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5982         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5983
5984 2019-06-13  Pedro Alves  <palves@redhat.com>
5985
5986         * thread.c (thread_apply_command): Check for invalid TID with
5987         isdigit instead of !isalpha.
5988
5989 2019-06-13  Pedro Alves  <palves@redhat.com>
5990
5991         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5992         (validate_flags_qcs): New.
5993         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5994         (validate_flags_qcs): Declare.
5995         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5996         (make_frame_apply_options_def_group): New.
5997         (frame_apply_command_count): Process options with
5998         gdb::option::process_options.
5999         (frame_apply_completer): New.
6000         (frame_apply_level_completer, frame_apply_all_completer)
6001         (frame_apply_completer): New.
6002         (_initialize_stack): Update help of "frame apply", "frame apply
6003         level", "frame apply all" and "faas" to mention supported options
6004         and install command completers.
6005         * stack.h (frame_apply_all_completer): Declare.
6006         * thread.c: Include "stack.h".
6007         (tfaas_command): Add "--".
6008         (_initialize_thread): Update help "tfaas" to mention supported
6009         options and install command completer.
6010
6011 2019-06-13  Pedro Alves  <palves@redhat.com>
6012
6013         * completer.c (complete_nested_command_line): New.
6014         (gdb_completion_word_break_characters_throw): Add assertion.
6015         * completer.h (complete_nested_command_line): Declare.
6016
6017 2019-06-13  Pedro Alves  <palves@redhat.com>
6018
6019         * stack.c (parse_backtrace_qualifiers): New.
6020         (backtrace_command): Use it.
6021         (backtrace_command_completer): Complete on qualifiers.
6022
6023 2019-06-13  Pedro Alves  <palves@redhat.com>
6024
6025         * frame.c: Include "cli/cli-option.h.
6026         (user_set_backtrace_options): New.
6027         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6028         Delete.
6029         (get_prev_frame): Adjust.
6030         (boolean_option_def, uinteger_option_def)
6031         (set_backtrace_option_defs): New.
6032         (_initialize_frame): Adjust and use
6033         gdb::option::add_setshow_cmds_for_options to install "set
6034         backtrace past-main" and "set backtrace past-entry".
6035         * frame.h: Include "cli/cli-option.h".
6036         (struct frame_print_options): Forward declare.
6037         (print_frame_arguments_all, print_frame_arguments_scalars)
6038         (print_frame_arguments_none): Declare.
6039         (print_entry_values): Delete declaration.
6040         (struct frame_print_options, user_frame_print_options): New.
6041         (struct set_backtrace_options): New.
6042         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6043         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6044         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6045         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6046         (list_args_or_locals): Add frame_print_options parameter.
6047         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6048         * python/py-framefilter.c (enumerate_args): Pass down
6049         USER_FRAME_PRINT_OPTIONS.
6050         * stack.c: Include "cli/cli-option.h".
6051         (print_frame_arguments_all, print_frame_arguments_scalars)
6052         (print_frame_arguments_none): Declare.
6053         (print_raw_frame_arguments, print_entry_values): Delete.
6054         (user_frame_print_options): New.
6055         (boolean_option_def, enum_option_def, frame_print_option_defs):
6056         New.
6057         (struct backtrace_cmd_options): New.
6058         (bt_flag_option_def): New.
6059         (backtrace_command_option_defs): New.
6060         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6061         (print_frame_arg, read_frame_arg, print_frame_args)
6062         (print_frame_info, print_frame): Add frame_print_options parameter
6063         and use it.
6064         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6065         (backtrace_command_1): Add frame_print_options and
6066         backtrace_cmd_options parameters and use them.
6067         (make_backtrace_options_def_group): New.
6068         (backtrace_command): Process command options with
6069         gdb::option::process_options.
6070         (backtrace_command_completer): New.
6071         (_initialize_stack): Extend "backtrace"'s help to mention
6072         supported options.  Install completer for "backtrace".
6073         Install some settings commands with add_setshow_cmds_for_options.
6074
6075 2019-06-13  Pedro Alves  <palves@redhat.com>
6076
6077         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6078         and that "set/show print raw frame-arguments" are now deprecated.
6079
6080         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6081         command.
6082         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6083         * stack.c (_initialize_stack): Install "set/show print
6084         raw-frame-arguments", and deprecate "set/show print raw
6085         frame-arguments".
6086         * valprint.c (_initialize_valprint): Deprecate "set/show print
6087         raw".
6088
6089 2019-06-13  Pedro Alves  <palves@redhat.com>
6090
6091         * compile/compile.c (struct compile_options): New.
6092         (compile_flag_option_def, compile_command_option_defs)
6093         (make_compile_options_def_group): New.
6094         (compile_file_command): Handle options with
6095         gdb::option::process_options.
6096         (compile_file_command_completer): New function.
6097         (compile_code_command): Handle options with
6098         gdb::option::process_options.
6099         (compile_code_command_completer): New function.
6100         (_initialize_compiler): Install completers for "compile code" and
6101         "compile file".  Mention available options in "compile code" and
6102         "compile code"'s help.
6103         * completer.c (advance_to_completion_word): New, factored out from
6104         ...
6105         (advance_to_expression_complete_word_point): ... this.
6106         (advance_to_filename_complete_word_point): New.
6107         * completer.h (advance_to_filename_complete_word_point): New
6108         declaration.
6109
6110 2019-06-13  Pedro Alves  <palves@redhat.com>
6111
6112         * compile/compile.c: Include "cli/cli-option.h".
6113         (compile_print_value): Scope data pointer is now a
6114         value_print_options pointer; adjust.
6115         (compile_print_command): Process options.  Scope data pointer is
6116         now a value_print_options pointer; adjust.
6117         (_initialize_compile): Update "compile print"'s help to include
6118         supported options.  Install a completer for "compile print".
6119         * cp-valprint.c (show_vtblprint, show_objectprint)
6120         (show_static_field_print): Delete.
6121         (_initialize_cp_valprint): Don't install "set print
6122         static-members", "set print vtbl", "set print object" here.
6123         * printcmd.c: Include "cli/cli-option.h" and
6124         "common/gdb_optional.h".
6125         (print_command_parse_format): Rework to fill in a
6126         value_print_options instead of a format_data.
6127         (print_value): Change parameter type from format_data pointer to
6128         value_print_options reference.  Adjust.
6129         (print_command_1): Process options.  Adjust to pass down a
6130         value_print_options.
6131         (print_command_completer): New.
6132         (_initialize_printcmd): Install print_command_completer as
6133         handle_brkchars completer for the "print" command.  Update
6134         "print"'s help to include supported options.
6135         * valprint.c: Include "cli/cli-option.h".
6136         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6137         here from cp-valprint.c.
6138         (boolean_option_def, uinteger_option_def)
6139         (value_print_option_defs, make_value_print_options_def_group):
6140         New.  Use gdb::option::add_setshow_cmds_for_options to install
6141         "set print elements", "set print null-stop", "set print repeats",
6142         "set print pretty", "set print union", "set print array", "set
6143         print address", "set print symbol", "set print array-indexes".
6144         * valprint.h: Include <string> and "cli/cli-option.h".
6145         (make_value_print_options_def_group): Declare.
6146         (print_value): Change parameter type from format_data pointer to
6147         value_print_options reference.
6148         (print_command_completer): Declare.
6149
6150 2019-06-13  Pedro Alves  <palves@redhat.com>
6151
6152         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6153         (COMMON_SFILES): Add maint-test-settings.c.
6154         * cli/cli-decode.c (boolean_enums): New global, factored out from
6155         ...
6156         (add_setshow_boolean_cmd): ... here.
6157         * cli/cli-decode.h (boolean_enums): Declare.
6158         * cli/cli-option.c: New file.
6159         * cli/cli-option.h: New file.
6160         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6161         factored out from ...
6162         (parse_cli_boolean_value(const char *)): ... this.
6163         (is_unlimited_literal): Change parameter type to pointer to
6164         pointer.  Adjust and advance ARG pointer.
6165         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6166         (parse_cli_var_enum): New, factored out from ...
6167         (do_set_command): ... this.  Adjust.
6168         * cli/cli-setshow.h (parse_cli_boolean_value)
6169         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6170         (parse_cli_var_enum): Declare.
6171         * cli/cli-utils.c: Include "cli/cli-option.h".
6172         (get_ulongest): New.
6173         * cli/cli-utils.h (get_ulongest): Declare.
6174         (check_for_argument): New overloads.
6175         * maint-test-options.c: New file.
6176
6177 2019-06-13  Pedro Alves  <palves@redhat.com>
6178
6179         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6180         parse a range if "-" is at the end of the string.
6181
6182 2019-06-13  Pedro Alves  <palves@redhat.com>
6183
6184         * cli/cli-setshow.c (parse_auto_binary_operation)
6185         (parse_cli_boolean_value): Don't allow "o".
6186
6187 2019-06-13  Pedro Alves  <palves@redhat.com>
6188
6189         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6190         * NEWS: Mention maint test-settings KIND.
6191         * maint-test-settings.c: New file.
6192
6193 2019-06-13  Pedro Alves  <palves@redhat.com>
6194
6195         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6196         completer.
6197         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6198         "set" completers.
6199
6200 2019-06-13  Pedro Alves  <palves@redhat.com>
6201
6202         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6203         after item.
6204
6205 2019-06-13  Pedro Alves  <palves@redhat.com>
6206
6207         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6208
6209 2019-06-13  Pedro Alves <palves@redhat.com>
6210
6211         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6212         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6213         call.
6214         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6215         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6216         calls.
6217         (check_for_argument): Skip spaces after argument.
6218
6219 2019-06-13  Pedro Alves  <palves@redhat.com>
6220
6221         * thread.c (thread_apply_command): Adjust TID parsing.
6222         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6223         detected before end of string.
6224         (tid_is_in_list): Error out if LIST is invalid.
6225
6226 2019-06-13  Pedro Alves  <palves@redhat.com>
6227
6228         * completer.c (complete_line_internal_1): Rewind completion word
6229         point.
6230         (completion_tracker::advance_custom_word_point_by): Change
6231         parameter type to int.
6232         * completer.h (completion_tracker::advance_custom_word_point_by):
6233         Likewise.
6234
6235 2019-06-13  Pedro Alves  <palves@redhat.com>
6236
6237         * completer.c (advance_to_completion_word): Handle delimiters.
6238
6239 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6240
6241         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6242
6243 2019-06-11  Tom Tromey  <tom@tromey.com>
6244
6245         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6246         (xmalloc_failed): Move to alloc.c.
6247         * alloc.c: New file.
6248         * Makefile.in (COMMON_SFILES): Add alloc.c.
6249
6250 2019-06-11  Tom Tromey  <tom@tromey.com>
6251
6252         * nat/linux-waitpid.c: Don't include server.h.
6253         (linux_debug): Remove.
6254         (my_waitpid): Update.
6255
6256 2019-06-11  Tom Tromey  <tromey@adacore.com>
6257
6258         * infcall.c (_initialize_infcall): Remove trailing newline from
6259         help.
6260         * user-regs.c (_initialize_user_regs): Remove trailing newline
6261         from help.
6262         * typeprint.c (_initialize_typeprint): Remove trailing newline
6263         from help.
6264         * reverse.c (_initialize_reverse): Remove trailing newlines from
6265         help.
6266         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6267         from help.
6268         * language.c (add_set_language_command): Remove trailing newline
6269         from help.
6270         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6271         help.
6272         * disasm.c (_initialize_disasm): Remove trailing newline from
6273         help.
6274         * top.c (init_main): Remove trailing newline from help.
6275         * interps.c (_initialize_interpreter): Remove trailing newline
6276         from help.
6277         * btrace.c (_initialize_btrace): Remove trailing newlines from
6278         help.
6279         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6280         from help.
6281         * python/python.c (_initialize_python): Remove trailing newline
6282         from help.
6283         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6284         help.
6285         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6286         from help.  Reformat some text.
6287         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6288         from help.
6289         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6290         newline from help.
6291
6292 2019-06-11  Tom Tromey  <tromey@adacore.com>
6293
6294         * darwin-nat.c (darwin_decode_exception_message)
6295         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6296
6297 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * valops.c (value_slice): Check for not allocated or not
6300         associated values.
6301
6302 2019-06-10  Tom de Vries  <tdevries@suse.de>
6303
6304         PR gdb/24618
6305         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6306         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6307         invalid.
6308
6309 2019-06-10  Tom de Vries  <tdevries@suse.de>
6310
6311         PR gdb/24611
6312         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6313         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6314
6315 2019-06-10  Tom de Vries  <tdevries@suse.de>
6316
6317         PR symtab/24545
6318         * symtab.c (struct demangled_name_entry): Add language field.
6319         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6320         static minimal symbol".  Set and use language field.
6321
6322 2019-06-10  Tom Tromey  <tromey@adacore.com>
6323
6324         * ada-lang.c (_initialize_ada_language): Update help text.
6325
6326 2019-06-10  Tom Tromey  <tromey@adacore.com>
6327
6328         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6329         with a newline.
6330         * guile/guile.c (handle_boot_error): Don't end warning with a
6331         newline.
6332         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6333         warning with a newline.
6334         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6335         newline.
6336         (s12z_frame_cache): Likewise.
6337         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6338         a newline.
6339         * solib-svr4.c (disable_probes_interface): Don't end warning with
6340         a newline.
6341         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6342         newline.
6343         * python/python.c (do_finish_initialization): Don't end warning
6344         with a newline.
6345
6346 2019-06-10  Tom Tromey  <tom@tromey.com>
6347
6348         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6349         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6350         gdbpy_enter.
6351
6352 2019-06-10  Tom Tromey  <tromey@adacore.com>
6353
6354         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6355         data.
6356         (elf_new_init): Don't call stabsread_new_init.
6357         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6358         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6359         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6360
6361 2019-06-10  Tom de Vries  <tdevries@suse.de>
6362
6363         PR symtab/16264
6364         PR symtab/24517
6365         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6366
6367 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6368
6369         * source.c (find_and_open_source): Also rewrite relative file
6370         names.
6371
6372 2019-04-26  Amos Bird  <amosbird@gmail.com>
6373
6374         * annotate.c (annotate_thread_exited): Add "thread-exited"
6375         annotation.
6376
6377 2019-06-06  Tom Tromey  <tromey@adacore.com>
6378
6379         * maint.h (class scoped_command_stats): Use
6380         DISABLE_COPY_AND_ASSIGN.
6381         <print_time>: New method.
6382         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6383         print_time.
6384         (scoped_command_stats::print_time): New method.
6385
6386 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6389         instructions of lengths 6 or 8 bytes.
6390
6391 2019-06-04  Pedro Alves  <palves@redhat.com>
6392
6393         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6394
6395         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6396         * breakpoint.c (condition_completer): Likewise.
6397         * cli/cli-dump.c (scan_expression): Likewise.
6398         * common/filestuff.c (mkdir_recursive): Likewise.
6399         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6400         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6401         (gdb_abspath): Likewise.
6402         * compile/compile-cplus-types.c
6403         (compile_cplus_instance::decl_name): Likewise.
6404         * completer.c (complete_explicit_location):
6405         (signal_completer, reg_or_group_completer_1): Likewise.
6406         * cp-support.c (cp_remove_params_if_any): Likewise.
6407         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6408         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6409         * infcmd.c (strip_bg_char): Likewise.
6410         * linespec.c (copy_token_string): Likewise.
6411         * mi/mi-main.c (output_cores): Likewise.
6412         * psymtab.c (psymtab_search_name):
6413         * symfile.c (test_set_ext_lang_command): Likewise.
6414         * target.c (target_fileio_read_stralloc): Likewise.
6415         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6416         * value.c (complete_internalvar): Likewise.
6417
6418 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6419
6420         Add objfile property to gdb.Type.
6421         * NEWS: Mention Python API addition.
6422         * python/py-type.c (typy_get_objfile): New method.
6423
6424 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6425
6426         * NEWS: Mention the new set|show style [title|highlight].
6427         Mention changes to "show style", "help" and "apropos".
6428
6429 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6430
6431         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6432         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6433         instead of print_help_for_command.
6434         (print_doc_of_command): New function.
6435         (help_list): Add 'apropos -v word' suggestion.
6436         (print_help_for_command): Style the command name using title style.
6437         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6438         (_initialize_cli_cmds): Describe -v in apropos_command help.
6439
6440 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6441
6442         * cli/cli-style.h (cli_style_option): Add name in constructor,
6443         add m_name class member, add constructor with intensity,
6444         add name class function.
6445         (cli_style_option::add_setshow_commands): Remove name argument.
6446         (highlight_style, title_style): New styles.
6447         * cli/cli-style.c (do_show): New function that shows a style
6448         characteristic styling the style name with itself.
6449         (set_style_name): New function.
6450         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6451         Update all callers according to the changes in cli/cli-style.h.
6452         * utils.h (fputs_highlighted): New function.
6453         * utils.c (fputs_highlighted): Likewise.
6454
6455 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6456
6457         * NEWS: Mention new pipe command and new convenience variables.
6458
6459 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6460
6461         * cli/cli-cmds.c (pipe_command): New function.
6462         (_initialize_cli_cmds): Call add_com for pipe_command.
6463         Define | as an alias for pipe.
6464         (exit_status_set_internal_vars): New function.
6465         (shell_escape): Call exit_status_set_internal_vars.
6466         cli/cli-decode.c (find_command_name_length): Recognize | as
6467         a single character command.
6468
6469 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6470
6471         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6472         top.c (execute_command_to_ui_file): New function, mostly a copy
6473         of execute_command_to_string.
6474         (execute_command_to_string): Implement by calling
6475         execute_command_to_ui_file.
6476
6477 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6478
6479         * top.h (saved_command_line): Remove declaration.
6480         * top.c (previous_saved_command_line, previous_repeat_arguments):
6481         New variables.
6482         (saved_command_line): Make static, define together with other
6483         'repeat variables'.
6484         (dont_repeat): Clear repeat_arguments.
6485         (repeat_previous, get_saved_command_line, save_command_line):
6486         New functions.
6487         (gdb_init): Initialize saved_command_line
6488         and previous_saved_command_line.
6489         * main.c (captured_main_1): Remove saved_command_line initialization.
6490         * event-top.c (handle_line_of_input): Update to use
6491         the new 'repeat' related functions instead of direct access to
6492         saved_command_line.
6493         * command.h (repeat_previous, get_saved_command_line,
6494         save_command_line): New declarations.
6495         (dont_repeat): Add comment.
6496
6497 2019-05-30  Tom Tromey  <tromey@adacore.com>
6498
6499         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6500         Fix comment.
6501         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6502
6503 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6504
6505         PR cli/24587
6506         * completer.c (complete): Initialize variable word.
6507
6508 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6509
6510         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6511         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6512         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6513         'body' is NULL to the outter 'if', protecting the '!is_define'
6514         situation as well.
6515
6516 2019-05-29  Tom Tromey  <tromey@adacore.com>
6517
6518         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6519         (dwarf_unknown): New function.
6520         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6521         (dwarf_type_encoding_name): Use dwarf_unknown.
6522
6523 2019-05-29  Tom Tromey  <tromey@adacore.com>
6524
6525         PR c++/20020:
6526         * cp-valprint.c (cp_print_value_fields): Call
6527         cp_print_static_field inside "try".
6528
6529 2019-05-29  Tom Tromey  <tromey@adacore.com>
6530
6531         * inflow.c (struct terminal_info): Add default operator=.
6532         * configure: Rebuild.
6533         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6534         -Wdeprecated-copy-dtor, -Wredundant-move.
6535
6536 2019-05-29  Tom Tromey  <tromey@adacore.com>
6537
6538         * NEWS: Add entry.
6539         * infcmd.c (print_return_value_1): Handle finish_print
6540         option.
6541         (show_print_finish): New function.
6542         (_initialize_infcmd): Add "set/show print finish" commands.
6543         * valprint.c (user_print_options): Initialize new member.
6544         * valprint.h (struct value_print_options) <finish_print>: New
6545         member.
6546
6547 2019-05-28  Tom Tromey  <tromey@adacore.com>
6548
6549         * ada-lang.c (ada_remove_Xbn_suffix)
6550         (find_old_style_renaming_symbol)
6551         (parse_old_style_renaming): Remove.
6552         (ada_find_renaming_symbol): Don't call
6553         find_old_style_renaming_symbol.
6554         (ada_is_renaming_symbol): Rename from
6555         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6556         bool.  Now static.
6557         (ada_read_var_value): Update and simplify.
6558         * ada-exp.y (write_var_or_type): Remove old code.
6559
6560 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6561
6562         * event-top.c: Remove include comment.
6563         * inflow.c (class scoped_ignore_sigttou): Move from here...
6564         * inflow.h (class scoped_ignore_sigttou): ...to here.
6565         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6566         * top.c:  Remove include comment.
6567
6568 2019-05-27  Tom Tromey  <tom@tromey.com>
6569
6570         * NEWS: Fix typo.
6571
6572 2019-05-22  Tom Tromey  <tromey@adacore.com>
6573
6574         * target.c (target_follow_exec): Constify parameter.
6575         * target-delegates.c: Rebuild.
6576         * remote.c (remote_target::follow_exec): Constify parameter.
6577         * infrun.c (follow_exec): Constify parameter.
6578         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6579         (target_follow_exec): Likewise.
6580
6581 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6584         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6585
6586 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6587
6588         * NEWS: Add debugredirect and testsuite sections.
6589
6590 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6591
6592         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6593         target descriptions using exclusively floating point register name
6594         aliases.
6595
6596 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         PR gdb/18644:
6599         * f-lang.c (build_fortran_types): Handle the case where
6600         gdbarch_floatformat_for_type returns a nullptr.
6601
6602 2019-05-21  Tom de Vries  <tdevries@suse.de>
6603
6604         PR cli/24587
6605         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6606
6607 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         PR gdb/18644:
6610         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6611         16-byte floats.
6612         * i386-tdep.c (i386_floatformat_for_type): Use
6613         floatformats_ia64_quad for the 16-byte floating point component
6614         within a fortran 32-byte complex number.
6615
6616 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6619         delete default constructor.
6620         (find_partial_die): Update to return const struct.
6621         (partial_die_parent_scope): Move variable declaration into scope
6622         of its use and change its type to auto.
6623         (guess_partial_die_structure_name): Likewise.
6624         (partial_die_info::fixup): Likewise.
6625
6626 2019-05-17  Tom Tromey  <tromey@adacore.com>
6627
6628         * source.c (find_and_open_source): Remove cast.
6629
6630 2019-05-17  Tom Tromey  <tromey@adacore.com>
6631
6632         * annotate.c (annotate_source): Make "filename" const.
6633         * annotate.h (annotate_source): Use const.
6634
6635 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6636
6637         * disasm.c (set_disassembler_options): Send errors to stderr.
6638
6639 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6640
6641         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6642         (cli_interp_base::set_logging): Check debug_redirect.
6643         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6644         * cli/cli-logging.c (debug_redirect): Add static variable.
6645         (pop_output_files): Add default param.
6646         (handle_redirections): Print debug setting.
6647         (show_logging_command): Likewise.
6648         (_initialize_cli_logging): Add debugredirect command.
6649         * interps.c (current_interp_set_logging): Add debug_redirect
6650         parameter.
6651         * interps.h (set_logging): Add debug_redirect parameter.
6652         (current_interp_set_logging): Likewise.
6653         * mi/mi-common.h: Likewise.
6654         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6655
6656 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6657             Tom Tromey  <tromey@adacore.com>
6658
6659         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6660         directly.
6661         * cli/cli-interp.h (make_logging_output): Remove declaration.
6662         * cli/cli-logging.c (make_logging_output): Remove function.
6663         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6664         directly.
6665         * ui-file.c (tee_file::tee_file): Remove bools.
6666         (tee_file::~tee_file): Remove deletes.
6667         * ui-file.h (tee_file): Remove bools.
6668
6669 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6670
6671         * mi/mi-cmds.h (mi_cmd_complete): New function.
6672         * mi/mi-main.c (mi_cmd_complete): Likewise.
6673         * mi/mi-cmds.c: Define new MI command -complete.
6674         * NEWS: Mention new -complete command.
6675
6676 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6677
6678         * completer.h (complete): New function.
6679         * completer.c (complete): Likewise.
6680         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6681         function defined in completer.h.
6682
6683 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6684
6685         * MAINTAINERS (Write After Approval): Add myself.
6686
6687 2019-05-17  Tom de Vries  <tdevries@suse.de>
6688
6689         PR gdb/24094
6690         * dwarf2read.c (struct cu_partial_die_info): New struct.
6691         (find_partial_die): Return cu_partial_die_info.
6692         (partial_die_parent_scope, guess_partial_die_structure_name)
6693         (partial_die_info::fixup): Handle new return type of find_partial_die.
6694
6695 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6696
6697         PR breakpoints/24541
6698         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6699         "std::string", simplifying the algorithm.
6700
6701 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6702
6703         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6704         (stap_static_probe_ops::get_probes): Likewise.
6705
6706 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6707
6708         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6709         '-')" and "else if".
6710         (stap_parse_single_operand): Join checks for
6711         "gdbarch_stap_parse_special_token_p" and
6712         "gdbarch_stap_parse_special_token" in the same "if" statement.
6713         Invert check when verifying for operation on register
6714         displacement.
6715
6716 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6717
6718         * stap-probe.c (stap_get_opcode): Update comment.
6719         (stap_get_expected_argument_type): Likewise.
6720         (handle_stap_probe): Likewise.
6721
6722 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6723
6724         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6725         return type to 'bool'.  Adjust comment.  Use 'bool' when
6726         appropriate.
6727         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6728         * stap-probe.c (stap_parse_argument_1): Likewise.
6729         (stap_is_operator): Likewise.
6730         (stap_is_generic_prefix): Likewise.
6731         (stap_is_register_prefix): Likewise.
6732         (stap_is_register_indirection_prefix): Likewise.
6733         (stap_is_integer_prefix): Likewise.
6734         (stap_generic_check_suffix): Likewise.
6735         (stap_check_integer_suffix): Likewise.
6736         (stap_check_register_suffix): Likewise.
6737         (stap_check_register_indirection_suffix): Likewise.
6738         (stap_parse_register_operand): Likewise.
6739         (stap_parse_single_operand): Likewise.
6740         (stap_parse_argument_1): Likewise.
6741         (stap_probe::get_argument_count): Likewise.
6742         (stap_is_operator): Likewise.
6743
6744 2019-05-16  Tom Tromey  <tromey@adacore.com>
6745
6746         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6747         keyword to foreach.
6748
6749 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6750
6751         * linux-thread-db.c (try_thread_db_load_1): Change return type
6752         to bool.
6753         (try_thread_db_load): Likewise.
6754         (try_thread_db_load_from_pdir_1): Likewise.
6755         (try_thread_db_load_from_pdir): Likewise.
6756         (try_thread_db_load_from_sdir): Likewise.
6757         (try_thread_db_load_from_dir): Likewise.
6758         (thread_db_load_search): Likewise.
6759         (has_libpthread): Likewise.
6760         (thread_db_load): Likewise.
6761
6762 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6763
6764         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6765         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6766         NULL, and complain/return if that's the case.
6767
6768 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6769
6770         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6771         (advance, posn, abstract_read_memory): New functions.
6772         [struct mem_read_abstraction]: New struct.
6773         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6774
6775 2019-05-14  Tom Tromey  <tromey@adacore.com>
6776
6777         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6778         value is not lval_memory.
6779
6780 2019-05-14  Tom Tromey  <tromey@adacore.com>
6781
6782         * solib.c (info_sharedlibrary_command): Style the file name.
6783
6784 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6785
6786         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6787         (aarch64_vnv_type): Likewise.
6788         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6789         * common/tdesc.c: Likewise.
6790         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6791         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6792         * features/aarch64-fpu.xml: Add ieee half view.
6793         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6794         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6795         * gdbtypes.h (struct builtin_type): Likewise.
6796         (struct objfile_type): Likewise.
6797
6798 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6799
6800         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6801         typo.
6802         * location.h (string_to_event_location): Likewise.
6803
6804 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6805
6806         GDB 8.3 released.
6807
6808 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6809
6810         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6811         New variable declaration.
6812         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6813         New variable.
6814         (print_one_breakpoint): Use ui_out::test_flags and new global
6815         variable to compute use_fixed_output.
6816         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6817         Remove.
6818         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6819         (mi_multi_location_breakpoint_output_fixed): Remove.
6820         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6821         new variable.
6822         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6823         fix_multi_location_breakpoint_output flag if version >= 3.
6824         * ui-out.h (enum ui_out_flag)
6825         <fix_multi_location_breakpoint_output>: New enumerator.
6826
6827 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6828
6829         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6830
6831 2019-05-10  Tom Tromey  <tromey@adacore.com>
6832
6833         * ada-lang.c (catch_ada_completer): New function.
6834         (_initialize_ada_language): Use it.
6835
6836 2019-05-10  Tom Tromey  <tromey@adacore.com>
6837
6838         * thread.c (print_thread_info): Make "requested_threads" const.
6839         * gdbthread.h (print_thread_info): Make "requested_threads"
6840         const.
6841         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6842         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6843
6844 2019-05-08  Tom Tromey  <tom@tromey.com>
6845
6846         * gdbtypes.c (objfile_type_data): Change type.
6847         (objfile_type, _initialize_gdbtypes): Update.
6848
6849 2019-05-08  Tom Tromey  <tom@tromey.com>
6850
6851         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6852         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6853         (_initialize_dwarf2_frame): Update.
6854
6855 2019-05-08  Tom Tromey  <tom@tromey.com>
6856
6857         * objc-lang.c (objc_objfile_data): Change type.
6858         (find_methods): Update.
6859         (_initialize_objc_lang): Remove.
6860
6861 2019-05-08  Tom Tromey  <tom@tromey.com>
6862
6863         * stabsread.c (rs6000_builtin_type_data): Change type.
6864         (rs6000_builtin_type, _initialize_stabsread): Update.
6865
6866 2019-05-08  Tom Tromey  <tom@tromey.com>
6867
6868         * mips-tdep.c (mips_pdr_data): Remove.
6869         (_initialize_mips_tdep): Update.
6870
6871 2019-05-08  Tom Tromey  <tom@tromey.com>
6872
6873         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6874         (hppa_init_objfile_priv_data, read_unwind_info)
6875         (find_unwind_entry, _initialize_hppa_tdep): Update.
6876
6877 2019-05-08  Tom Tromey  <tom@tromey.com>
6878
6879         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6880         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6881         on obstack.
6882         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6883
6884 2019-05-08  Tom Tromey  <tom@tromey.com>
6885
6886         * mdebugread.c (basic_type_data): Change type.
6887         (basic_type, _initialize_mdebugread): Update.
6888
6889 2019-05-08  Tom Tromey  <tom@tromey.com>
6890
6891         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6892
6893 2019-05-08  Tom Tromey  <tom@tromey.com>
6894
6895         * nto-tdep.c (nto_inferior_data_reg): Change type.
6896         (nto_inferior_data): Update.
6897         (nto_inferior_data_cleanup, nto_new_inferior_data)
6898         (_initialize_nto_tdep): Remove.
6899         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6900
6901 2019-05-08  Tom Tromey  <tom@tromey.com>
6902
6903         * ada-lang.c (struct ada_inferior_data): Add initializers.
6904         (ada_inferior_data): Change type.
6905         (ada_inferior_data_cleanup): Remove.
6906         (get_ada_inferior_data, ada_inferior_exit)
6907         (struct ada_pspace_data): Add initializers, destructor.
6908         (ada_pspace_data_handle): Change type.
6909         (get_ada_pspace_data): Update.
6910         (ada_pspace_data_cleanup): Remove.
6911
6912 2019-05-08  Tom Tromey  <tom@tromey.com>
6913
6914         * coffread.c (struct coff_symfile_info): Add initializers.
6915         (coff_objfile_data_key): Move lower.  Change type.
6916         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6917         Update.
6918         (coff_free_info): Remove.
6919
6920 2019-05-08  Tom Tromey  <tom@tromey.com>
6921
6922         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6923         (fbsd_pspace_data_handle): Move lower.  Change type.
6924         (get_fbsd_pspace_data): Update.
6925         (fbsd_pspace_data_cleanup): Remove.
6926         (_initialize_fbsd_tdep): Update.
6927
6928 2019-05-08  Tom Tromey  <tom@tromey.com>
6929
6930         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6931         (get_ada_tasks_pspace_data): Update.
6932         (ada_tasks_pspace_data_cleanup): Remove.
6933         (_initialize_tasks): Update.
6934         (ada_tasks_inferior_data_handle): Change type.
6935         (get_ada_tasks_inferior_data): Update.
6936         (ada_tasks_inferior_data_cleanup): Remove.
6937         (struct ada_tasks_pspace_data): Add initializers.
6938
6939 2019-05-08  Tom Tromey  <tom@tromey.com>
6940
6941         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6942         * symfile-debug.c (debug_sym_get_probes): Change type.
6943         * stap-probe.c (handle_stap_probe):
6944         (stap_static_probe_ops::get_probes): Change type.
6945         * probe.h (class static_probe_ops) <get_probes>: Change type.
6946         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6947         (parse_probes_in_pspace): Update.
6948         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6949         Update.
6950         (any_static_probe_ops::get_probes): Change type.
6951         * elfread.c (elfread_data): New typedef.
6952         (probe_key): Change type.
6953         (elf_get_probes): Likewise.  Update.
6954         (probe_key_free): Remove.
6955         (_initialize_elfread): Update.
6956         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6957         Change type.
6958         (dtrace_process_dof_probe, dtrace_process_dof)
6959         (dtrace_static_probe_ops::get_probe): Change type.
6960
6961 2019-05-08  Tom Tromey  <tom@tromey.com>
6962
6963         * xcoffread.c (struct xcoff_symfile_info): Rename from
6964         coff_symfile_info.  Add initializers.
6965         (xcoff_objfile_data_key): Move lower.  Change type.
6966         (XCOFF_DATA): Rewrite.
6967         (xcoff_free_info): Remove.
6968         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6969         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6970         (xcoff_initial_scan): Update.
6971
6972 2019-05-08  Tom Tromey  <tom@tromey.com>
6973
6974         * solib-svr4.c (struct svr4_info): Add initializers and
6975         destructor.
6976         <probes_table>: Now an htab_up.
6977         (solib_svr4_pspace_data): Change type.
6978         (free_probes_table): Simplify.
6979         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6980         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6981         (probes_table_remove_objfile_probes, register_solib_event_probe)
6982         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6983         (_initialize_svr4_solib): Update.
6984
6985 2019-05-08  Tom Tromey  <tom@tromey.com>
6986
6987         * remote.c (remote_pspace_data): Change type.
6988         (remote_pspace_data_cleanup): Remove.
6989         (get_remote_exec_file, set_pspace_remote_exec_file)
6990         (_initialize_remote): Update.
6991
6992 2019-05-08  Tom Tromey  <tom@tromey.com>
6993
6994         * breakpoint.c (breakpoint_objfile_key): Change type.
6995         (get_breakpoint_objfile_data): Update.
6996         (free_breakpoint_objfile_data): Remove.
6997         (_initialize_breakpoint): Update.
6998
6999 2019-05-08  Tom Tromey  <tom@tromey.com>
7000
7001         * linux-tdep.c (struct linux_info): Add initializers.
7002         (linux_inferior_data): Move.  Change type.
7003         (invalidate_linux_cache_inf): Update.
7004         (linux_inferior_data_cleanup): Remove.
7005         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7006
7007 2019-05-08  Tom Tromey  <tom@tromey.com>
7008
7009         * auxv.c (auxv_inferior_data): Move.  Change type.
7010         (auxv_inferior_data_cleanup): Remove.
7011         (invalidate_auxv_cache_inf): Rewrite.
7012         (get_auxv_inferior_data, _initialize_auxv): Update.
7013
7014 2019-05-08  Tom Tromey  <tom@tromey.com>
7015
7016         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7017         (symfile_debug_objfile_data_key): Change type.
7018         (symfile_debug_installed, debug_qf_has_symbols)
7019         (debug_qf_find_last_source_symtab)
7020         (debug_qf_forget_cached_source_info)
7021         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7022         (debug_qf_print_stats, debug_qf_dump)
7023         (debug_qf_expand_symtabs_for_function)
7024         (debug_qf_expand_all_symtabs)
7025         (debug_qf_expand_symtabs_with_fullname)
7026         (debug_qf_map_matching_symbols)
7027         (debug_qf_expand_symtabs_matching)
7028         (debug_qf_find_pc_sect_compunit_symtab)
7029         (debug_qf_map_symbol_filenames)
7030         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7031         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7032         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7033         (debug_sym_read_linetable, debug_sym_relocate): Update.
7034         (symfile_debug_free_objfile): Remove.
7035         (install_symfile_debug_logging, _initialize_symfile_debug):
7036         Update.
7037
7038 2019-05-08  Tom Tromey  <tom@tromey.com>
7039
7040         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7041         allocate_on_obstack.
7042         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7043         (get_dwarf2_per_objfile): Update.
7044         (set_dwarf2_per_objfile): Remove.
7045         (dwarf2_has_info, dwarf2_get_section_info): Update.
7046         (dwarf2_free_objfile): Remove.
7047         (_initialize_dwarf2_read): Update.
7048
7049 2019-05-08  Tom Tromey  <tom@tromey.com>
7050
7051         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7052         initializers.
7053         <unsupported_script_warning_printed,
7054         script_not_found_warning_printed>: Now bool.
7055         (auto_load_pspace_data): Change type.
7056         (~auto_load_pspace_info): Rename from
7057         auto_load_pspace_data_cleanup.
7058         (get_auto_load_pspace_data, init_loaded_scripts_info)
7059         (clear_section_scripts, maybe_print_unsupported_script_warning)
7060         (maybe_print_script_not_found_warning, _initialize_auto_load):
7061         Update.
7062
7063 2019-05-08  Tom Tromey  <tom@tromey.com>
7064
7065         * objfiles.c (objfile_pspace_info): Add destructor and
7066         initializers.
7067         (objfiles_pspace_data): Change type.
7068         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7069         (get_objfile_pspace_data): Update.
7070         (objfiles_bfd_data): Change type.
7071         (get_objfile_bfd_data): Update.
7072         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7073
7074 2019-05-08  Tom Tromey  <tom@tromey.com>
7075
7076         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7077         Change type.
7078         (get_catch_syscall_inferior_data): Update.
7079         (catch_syscall_inferior_data_cleanup): Remove.
7080         (_initialize_break_catch_syscall): Update.
7081
7082 2019-05-08  Tom Tromey  <tom@tromey.com>
7083
7084         * inflow.c (struct terminal_info): Add destructor and
7085         initializers.
7086         (inflow_inferior_data): Change type.
7087         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7088         (get_inflow_inferior_data, inflow_inferior_exit)
7089         (swap_terminal_info, _initialize_inflow): Update.
7090
7091 2019-05-08  Tom Tromey  <tom@tromey.com>
7092
7093         * target-dcache.c (target_dcache_cleanup): Remove.
7094         (target_dcache_aspace_key): Change type.
7095         (target_dcache_init_p, target_dcache_invalidate)
7096         (target_dcache_get, target_dcache_get_or_init)
7097         (_initialize_target_dcache): Update.
7098         * dcache.h (struct dcache_deleter): New.
7099
7100 2019-05-08  Tom Tromey  <tom@tromey.com>
7101
7102         * symtab.c (struct symbol_cache): Add destructor and
7103         initializers.
7104         (symbol_cache_key): Move.  Change type.
7105         (make_symbol_cache, free_symbol_cache): Remove.
7106         (get_symbol_cache): Update.
7107         (symbol_cache_cleanup): Remove.
7108         (ALL_PSPACES, symbol_cache_flush)
7109         (maintenance_print_symbol_cache)
7110         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7111         Update.
7112
7113 2019-05-08  Tom Tromey  <tom@tromey.com>
7114
7115         * symtab.c (struct main_info): Add destructor and initializers.
7116         (main_progspace_key): Move.  Change type.
7117         (get_main_info): Update.
7118         (main_info_cleanup): Remove.
7119         (_initialize_symtab): Update.
7120
7121 2019-05-08  Tom Tromey  <tom@tromey.com>
7122
7123         * registry.h (DECLARE_REGISTRY): Define the _key class.
7124
7125 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7126
7127         * NEWS: Merge two 'New commands' sections.
7128
7129 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7130
7131         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7132         parameter and use Ada language definition instead.
7133         (ada_val_print_ptr): Remove unused language parameter.
7134         (ada_val_print_num): Remove language parameter and use Ada language
7135         definition instead.
7136         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7137         parameter.
7138         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7139         parameter and use Ada language definition instead.
7140         (ada_val_print_1): Update all ada_val_print_xxx calls.
7141         Remove language parameter.
7142         (ada_val_print): Update ada_val_print_1 call.
7143
7144 2019-05-08  Tom Tromey  <tromey@adacore.com>
7145
7146         * remote.c (remote_hw_watchpoint_limit)
7147         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7148         Now static.
7149
7150 2019-05-08  Tom Tromey  <tromey@adacore.com>
7151
7152         * maint.c (_initialize_maint_cmds): Move initialization code to
7153         remote.c.
7154         (watchdog, show_watchdog): Move to remote.c.
7155         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7156         "watchdog" static.
7157         (_initialize_remote): Move initialization code from maint.c.
7158         * defs.h (watchdog): Don't declare.
7159
7160 2019-05-08  Tom Tromey  <tromey@adacore.com>
7161
7162         * tui/tui-interp.c: Include main.h.
7163         * interps.c: Include main.h.
7164         * main.h (interpreter_p): Declare.
7165         * defs.h (interpreter_p): Don't declare.
7166
7167 2019-05-08  Tom Tromey  <tromey@adacore.com>
7168
7169         * dwarf2loc.c: Include dwarf2read.h.
7170         * defs.h (read_unsigned_leb128): Don't declare.
7171         * dwarf2read.h (read_unsigned_leb128): Declare.
7172
7173 2019-05-08  Tom Tromey  <tromey@adacore.com>
7174
7175         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7176         method.
7177
7178 2019-05-08  Tom Tromey  <tromey@adacore.com>
7179
7180         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7181         when no wrap column is set.
7182
7183 2019-05-08  Tom Tromey  <tromey@adacore.com>
7184
7185         * c-lang.c (c_get_string): Handle non-C-style arrays.
7186
7187 2019-05-08  Tom Tromey  <tromey@adacore.com>
7188
7189         * typeprint.c (print_offset_data::update): Print the bit offset,
7190         not the number of bits remaining.
7191
7192 2019-05-08  Tom Tromey  <tromey@adacore.com>
7193
7194         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7195         padding at end of comment.
7196
7197 2019-05-08  Tom Tromey  <tromey@adacore.com>
7198
7199         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7200         Compare main types.
7201
7202 2019-05-06  Tom Tromey  <tom@tromey.com>
7203
7204         * common/scoped_mmap.c: Include common-defs.h.
7205         * common/scoped_mmap.h: Don't include config.h.
7206
7207 2019-05-04  Tom Tromey  <tom@tromey.com>
7208
7209         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7210         (struct aarch64_call_info): Add initializers.
7211         <si>: Now a std::vector.
7212         (pass_on_stack, aarch64_push_dummy_call): Update.
7213
7214 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7215             Tom Tromey  <tom@tromey.com>
7216
7217         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7218         (ppc_threads): Now a std::vector.  Now static.
7219         (hwdebug_find_thread_points_by_tid)
7220         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7221         Update.
7222
7223 2019-05-04  Tom Tromey  <tom@tromey.com>
7224
7225         * arc-tdep.c (arc_tdesc_init): Return bool.
7226
7227 2019-05-04  Tom Tromey  <tom@tromey.com>
7228
7229         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7230         Use gdb_assert_not_reached.
7231
7232 2019-05-04  Tom Tromey  <tom@tromey.com>
7233
7234         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7235         "false".
7236
7237 2019-05-04  Tom Tromey  <tom@tromey.com>
7238
7239         * arc-tdep.c (arc_tdesc_init): Use bool.
7240
7241 2019-05-04  Tom Tromey  <tom@tromey.com>
7242
7243         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7244
7245 2019-05-04  Tom Tromey  <tom@tromey.com>
7246
7247         * cli/cli-cmds.c (valid_command_p): Return bool.
7248
7249 2019-05-04  Tom Tromey  <tom@tromey.com>
7250
7251         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7252         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7253
7254 2019-05-04  Raul Tambre  <raul@tambre.ee>
7255
7256         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7257         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7258         operator for comparison.
7259
7260 2019-05-04  Tom Tromey  <tom@tromey.com>
7261
7262         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7263         (lookup_partial_symbol, print_partial_symbols)
7264         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7265         (psymbol_compare): Update.
7266         (add_psymbol_to_bcache): Clear the entire psymbol.
7267         (maintenance_check_psymtabs): Update.
7268         * psympriv.h (struct partial_symbol): Don't derive from
7269         general_symbol_info.
7270         <obj_section, unrelocated_address, address,
7271         set_unrelocated_address>: Update.
7272         <ginfo>: New member.
7273         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7274         (debug_names::write_psymbols): Update.
7275
7276 2019-05-04  Tom de Vries  <tdevries@suse.de>
7277
7278         * contrib/cc-with-tweaks.sh: Support -n arg.
7279
7280 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7281
7282         * corelow.c (core_target::detach): Ensure frame cache and
7283         register caches are cleared.
7284         inferior.c (exit_inferior_1): Likewise.
7285
7286 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7287             Tom Tromey  <tom@tromey.com>
7288
7289         * dictionary.c (collate_pending_symbols_by_language): Remove
7290         "struct" from foreach.
7291         * symtab.c (lookup_global_symbol_from_objfile)
7292         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7293         foreach.
7294         * ser-tcp.c (net_open): Remove "struct" from foreach.
7295         * objfiles.c (objfile_relocate, objfile_rebase)
7296         (objfile_has_symbols): Remove "struct" from foreach.
7297         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7298         from foreach.
7299         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7300         foreach.
7301         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7302         "struct" from foreach.
7303         * ada-lang.c (create_excep_cond_exprs)
7304         (ada_exception_catchpoint_cond_string): Remove "struct" from
7305         foreach.
7306
7307 2019-05-03  Tom Tromey  <tromey@adacore.com>
7308
7309         * ada-exp.y (convert_char_literal): Check suffix of each
7310         enumerator.
7311
7312 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7313
7314         PR ada/21406:
7315         * ada-exp.y (yywrap): Don't define.
7316         * ada-lex.l (%option): Add noyywrap
7317         (yywrap): Remove.
7318
7319 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7320
7321         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7322         _WIN32_WINNT to the XP level, unless already defined to a higher
7323         level.
7324
7325         * unittests/parse-connection-spec-selftests.c:
7326         * ser-tcp.c:
7327         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7328         override.
7329
7330         * symfile.c (find_separate_debug_file): Remove colon from the
7331         drive spec of DOS/Windows file names of the target, so that the
7332         file name produced from DEBUGDIR and the target's directory will
7333         be valid on DOS/Windows systems.
7334
7335 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7336
7337         * rust-lang.c (val_print_struct): Handle printing structures
7338         containing strings.
7339
7340 2019-05-02  Tom Tromey  <tromey@adacore.com>
7341
7342         * valarith.c (_initialize_valarith): Remove.
7343
7344 2019-05-01  Tom Tromey  <tromey@adacore.com>
7345
7346         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7347         bitfields.
7348
7349 2019-05-01  Tom Tromey  <tromey@adacore.com>
7350
7351         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7352         for big-endian copies.
7353
7354 2019-04-30  Ali Tamur  <tamur@google.com>
7355         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7356         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7357         (read_3_bytes): New function.
7358
7359 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7360
7361         * windows-nat.c (main_thread_id): Delete.
7362         (handle_output_debug_string): Replace main_thread_id by
7363         current_event.dwThreadId.
7364         (fake_create_process): Likewise.
7365         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7366         Do not set main_thread_id.
7367         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7368         current_event.dwThreadId.
7369         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7370
7371 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7372
7373         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7374         Use current_event.dwThreadId instead of main_thread_id.
7375
7376 2019-04-30  Tom Tromey  <tromey@adacore.com>
7377
7378         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7379         (create_excep_cond_exprs): Iterate over program spaces.
7380         (ada_exception_catchpoint_cond_string): Examine all minimal
7381         symbols for exception types.
7382
7383 2019-04-30  Tom Tromey  <tromey@adacore.com>
7384
7385         PR c++/24470:
7386         * dwarf2read.c (process_structure_scope): Handle case where type
7387         has template parameters but no symbol was created.
7388
7389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7390             Chris January  <chris.january@arm.com>
7391
7392         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7393         qualifier.
7394         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7395
7396 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7397
7398         * f-typeprint.c (f_print_type): Update rules for printing
7399         whitespace.
7400         (f_type_print_varspec_suffix): Likewise.
7401
7402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7403             Chris January  <chris.january@arm.com>
7404
7405         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7406         function arguments.
7407
7408 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * f-lang.c (build_fortran_types): Change name of void type to
7411         lower case.
7412         * f-typeprint.c (f_type_print_base): Print the name of the void
7413         type, rather than a fixed string.
7414         * f-valprint.c (f_decorations): Use lower case void string.
7415
7416 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7417             Chris January  <chris.january@arm.com>
7418
7419         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7420         types for Fortran.
7421
7422 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7423             Chris January  <chris.january@arm.com>
7424             David Lecomber  <david.lecomber@arm.com>
7425
7426         * f-exp.y (BINOP_INTRINSIC): New token.
7427         (exp): New parser rule handling BINOP_INTRINSIC.
7428         (f77_keywords): Add new builtin procedures.
7429         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7430         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7431         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7432         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7433         (print_unop_subexp_f): New function.
7434         (print_binop_subexp_f): New function.
7435         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7436         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7437         (dump_subexp_body_f): Likewise.
7438         (operator_check_f): Likewise.
7439         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7440         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7441
7442 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7443
7444         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7445         UNOP_KIND.
7446         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7447         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7448         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7449         (operator_length_f): New fuction.
7450         (print_subexp_f): New function.
7451         (op_name_f): New function.
7452         (dump_subexp_body_f): New function.
7453         (operator_check_f): New function.
7454         (exp_descriptor_f): Replace standard expression handling functions
7455         with new functions.
7456         * gdb/fortran-operator.def: New file.
7457         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7458         * gdb/std-operator.def: Remove UNOP_KIND.
7459
7460 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * std-operator.def: Remove unbalanced, stray double quote
7463         character.
7464
7465 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7466             Chris January  <chris.january@arm.com>
7467             Daniel Everett  <daniel.everett@arm.com>
7468             Nick Forrington  <nick.forrington@arm.com>
7469             Richard Bunt  <richard.bunt@arm.com>
7470
7471         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7472         of depth when printing anonymous structs or unions.
7473         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7474         Don't print either the top-level value, or the children if the
7475         max-depth is exceeded.
7476         (ppscm_print_children): When printing the key of a map, allow one
7477         extra level of depth.
7478         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7479         print either the top-level value, or the children if the max-depth
7480         is exceeded.
7481         (print_children): When printing the key of a map, allow one extra
7482         level of depth.
7483         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7484         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7485         (user_print_options): Initialise max_depth field.
7486         (val_print_scalar_or_string_type_p): New function.
7487         (val_print): Check to see if the max depth has been reached.
7488         (val_print_check_max_depth): Define new function.
7489         (show_print_max_depth): New function.
7490         (_initialize_valprint): Add 'print max-depth' option.
7491         * valprint.h (struct value_print_options) <max_depth>: New field.
7492         (val_print_check_max_depth): Declare new function.
7493         * NEWS: Document new feature.
7494
7495 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * ada-lang.c (ada_language_defn): Initialise new field.
7498         * c-lang.c (c_is_string_type_p): New function.
7499         (c_language_defn): Initialise new field.
7500         (cplus_language_defn): Initialise new field.
7501         (asm_language_defn): Initialise new field.
7502         (minimal_language_defn): Initialise new field.
7503         * c-lang.h (c_is_string_type_p): Declare new function.
7504         * d-lang.c (d_language_defn): Initialise new field.
7505         * f-lang.c (f_is_string_type_p): New function.
7506         (f_language_defn): Initialise new field.
7507         * go-lang.c (go_is_string_type_p): New function.
7508         (go_language_defn): Initialise new field.
7509         * language.c (default_is_string_type_p): New function.
7510         (unknown_language_defn): Initialise new field.
7511         (auto_language_defn): Initialise new field.
7512         * language.h (struct language_defn) <la_is_string_type_p>: New
7513         member variable.
7514         (default_is_string_type_p): Declare new function.
7515         * m2-lang.c (m2_language_defn): Initialise new field.
7516         * objc-lang.c (objc_language_defn): Initialise new field.
7517         * opencl-lang.c (opencl_language_defn): Initialise new field.
7518         * p-lang.c (pascal_is_string_type_p): New function.
7519         (pascal_language_defn): Initialise new field.
7520         * rust-lang.c (rust_is_string_type_p): New function.
7521         (rust_language_defn): Initialise new field.
7522
7523 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7524
7525         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7526         New field.
7527         * ada-lang.c (ada_language_defn): Initialise new field.
7528         * c-lang.c (c_language_defn): Likewise.
7529         (cplus_language_defn): Likewise.
7530         (asm_language_defn): Likewise.
7531         (minimal_language_defn): Likewise.
7532         * d-lang.c (d_language_defn): Likewise.
7533         * f-lang.c (f_language_defn): Likewise.
7534         * go-lang.c (go_language_defn): Likewise.
7535         * language.c (unknown_language_defn): Likewise.
7536         (auto_language_defn): Likewise.
7537         * m2-lang.c (m2_language_defn): Likewise.
7538         * objc-lang.c (objc_language_defn): Likewise.
7539         * opencl-lang.c (opencl_language_defn): Likewise.
7540         * p-lang.c (pascal_language_defn): Likewise.
7541         * rust-lang.c (rust_language_defn): Likewise.
7542
7543 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7544
7545         * ada-lang.c (ada_is_character_type): Change return type to bool.
7546         (ada_is_string_type): Likewise.
7547         * ada-lang.h (ada_is_character_type): Update declaration
7548         (ada_is_string_type): Likewise.
7549
7550 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7551
7552         Support style in 'frame|thread apply'
7553
7554         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7555         * record.c (record_start, record_stop): Update callers of
7556         execute_command_to_string with false.
7557         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7558         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7559         methods.
7560         (class string_file): New constructor with term_out parameter.
7561         Override methods term_out and can_emit_style_escape.  New member
7562         term_out.
7563         (class stdio_file): Override can_emit_style_escape.
7564         (class tee_file): Override term_out and can_emit_style_escape.
7565         * utils.h (can_emit_style_escape): Remove.
7566         * utils.c (can_emit_style_escape): Likewise.
7567         Update all callers of can_emit_style_escape (SOMESTREAM) to
7568         SOMESTREAM->can_emit_style_escape.
7569         * source-cache.c (source_cache::get_source_lines): Likewise.
7570         * stack.c (frame_apply_command_count): Call execute_command_to_string
7571         passing the term_out characteristic of the current gdb_stdout.
7572         * thread.c (thr_try_catch_cmd): Likewise.
7573         * top.c (execute_command_to_string): pass term_out parameter
7574         to construct the string_file for the command output.
7575         * ui-file.c (term_cli_styling): New function (most code moved
7576         from utils.c can_emit_style_escape).
7577         (string_file::string_file, string_file::can_emit_style_escape,
7578         stdio_file::can_emit_style_escape, tee_file::term_out,
7579         tee_file::can_emit_style_escape): New functions.
7580
7581 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7582
7583         * NEWS: Mention the new set|show may-call-functions.
7584         * infcall.c (may_call_functions_p): New variable.
7585         (show_may_call_functions_p): New function.
7586         (call_function_by_hand_dummy): Throws an error if not
7587         may-call-functions.
7588         (_initialize_infcall): Call add_setshow_boolean_cmd for
7589         may-call-functions.
7590
7591 2019-04-25  Keith Seitz  <keiths@redhat.com>
7592
7593         PR c++/24367
7594         * cp-support.c (inspect_type): Don't attempt substitutions
7595         of symbol with the same name.
7596
7597 2019-04-25  Tom Tromey  <tromey@adacore.com>
7598
7599         PR gdb/24475:
7600         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7601         static.
7602
7603 2019-04-25  Tom Tromey  <tromey@adacore.com>
7604
7605         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7606         rvalue reference.
7607         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7608         (gdb_xml_parser::parse): Use std::move.
7609         * python/python-internal.h (gdbpy_convert_exception): Take a const
7610         reference.
7611         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7612         std::move.
7613         * python/py-utils.c (gdbpy_convert_exception): Take a const
7614         reference.
7615         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7616         Use std::move.
7617         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7618         Use std::move.
7619         * mi/mi-main.c (mi_print_exception): Take a const reference.
7620         * main.c (handle_command_errors): Take a const reference.
7621         * linespec.c (parse_linespec): Use std::move.
7622         * infcall.c (run_inferior_call): Use std::move.
7623         (call_function_by_hand_dummy): Use std::move.
7624         * exec.c (try_open_exec_file): Use std::move.
7625         * exceptions.h (exception_print, exception_fprintf)
7626         (exception_print_same): Update.
7627         * exceptions.c (print_exception, exception_print)
7628         (exception_fprintf, exception_print_same): Change parameters to
7629         const reference.
7630         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7631         * common/new-op.c: Use std::move.
7632         * common/common-exceptions.h (struct gdb_exception): Add move
7633         constructor.
7634         (struct gdb_exception_error, struct gdb_exception_quit, struct
7635         gdb_quit_bad_alloc): Change constructor to move constructor.
7636         (throw_exception): Change parameter to rvalue reference.
7637         * common/common-exceptions.c (throw_exception): Take rvalue
7638         reference.
7639         * cli/cli-interp.c (safe_execute_command): Use std::move.
7640         * breakpoint.c (insert_bp_location, location_to_sals): Use
7641         std::move.
7642
7643 2019-04-25  Tom Tromey  <tromey@adacore.com>
7644
7645         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7646         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7647         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7648         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7649         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7650         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7651         guile/scm-value.c: Use unpack.
7652         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7653         gdbscm_gdb_exception.
7654         (gdbscm_throw_gdb_exception): Likewise.
7655         (struct gdbscm_gdb_exception): New.
7656         (unpack): New function.
7657         (gdbscm_wrap): Use unpack.
7658
7659 2019-04-25  Tom Tromey  <tromey@adacore.com>
7660
7661         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7662         (gdb_rl_callback_handler): Use std::move.
7663         * common/common-exceptions.h (struct gdb_exception): Add move
7664         assignment operator.
7665         (throw_exception_sjlj): Change "exception" to const reference.
7666         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7667         (throw_exception_sjlj): Change "exception" to const reference.
7668
7669 2019-04-25  Tom Tromey  <tromey@adacore.com>
7670
7671         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7672         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7673         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7674         Update.
7675         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7676         Update.
7677         * mi/mi-interp.c (mi_interp::exec): Update.
7678         * linespec.c (parse_linespec): Update.
7679         * infcall.c (run_inferior_call): Update.
7680         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7681         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7682         (gdbscm_lookup_global_symbol): Update.
7683         * guile/scm-param.c (gdbscm_parameter_value): Update.
7684         * guile/scm-frame.c (gdbscm_frame_read_register)
7685         (gdbscm_frame_read_var): Update.
7686         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7687         * exec.c (try_open_exec_file): Update.
7688         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7689         (gdb_rl_callback_handler): Update.
7690         * common/common-exceptions.h (exception_none): Don't declare.
7691         * common/common-exceptions.c (exception_none): Don't define.
7692         (struct catcher) <exception>: Update.
7693         * cli/cli-interp.c (safe_execute_command): Update.
7694         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7695
7696 2019-04-25  Ali Tamur  <tamur@google.com>
7697
7698         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7699         (read_attribute_value): Likewise.
7700         (dwarf2_read_addr_index): Update comment.
7701         (read_str_index): Add DW_FORM_strx.
7702         (dwarf2_string_attr): Likewise.
7703         (dwarf2_const_value_attr): Likewise.
7704         (dump_die_shallow): Likewise.
7705         (dwarf2_fetch_constant_bytes): Likewise.
7706         (skip_form_bytes): Likewise.
7707         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7708
7709 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7710
7711         PR corefiles/11608
7712         PR corefiles/18187
7713         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7714         OFFSET.  Verify if current mapping contains an ELF header.
7715         (linux_find_memory_regions_full): Adjust call to
7716         dump_mapping_p.
7717
7718 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7719             Kang Li <kanglictf@gmail.com>
7720
7721         PR gdb/21600
7722
7723         * dwarf2-frame.c (read_initial_length): Be consistent about using
7724         unsigned representation of length.
7725         (decode_frame_entry_1): Likewise.  Check for wraparound of
7726         end pointer as well as buffer overflow.
7727
7728 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7729
7730         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7731         "vq".
7732
7733 2019-04-24  Tom Tromey  <tromey@adacore.com>
7734
7735         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7736
7737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * s12z-tdep.c (s12z_unwind_pc): Delete.
7740         (s12z_unwind_sp): Delete.
7741         (s12z_gdbarch_init): Don't register deleted functions with
7742         gdbarch.
7743
7744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7745
7746         * rl78-tdep.c (rl78_unwind_sp): Delete.
7747         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7748
7749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7752         (xstormy16_unwind_pc): Delete.
7753         (xstormy16_dummy_id): Delete.
7754         (xstormy16_gdbarch_init): Don't register deleted functions with
7755         gdbarch.
7756
7757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7758
7759         * vax-tdep.c (vax_unwind_pc): Delete.
7760         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7761
7762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * v850-tdep.c (v850_unwind_sp): Delete.
7765         (v850_unwind_pc): Delete.
7766         (v850_dummy_id): Delete.
7767         (v850_gdbarch_init): Don't register deleted functions with
7768         gdbarch.
7769
7770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7773         (tilegx_unwind_pc): Delete.
7774         (tilegx_unwind_dummy_id): Delete.
7775         (tilegx_gdbarch_init): Don't register deleted functions with
7776         gdbarch.
7777
7778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7779
7780         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7781         (tic6x_dummy_id): Delete.
7782         (tic6x_gdbarch_init): Don't register deleted functions with
7783         gdbarch.
7784
7785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * sparc-tdep.c (sparc_unwind_pc): Delete.
7788         (sparc32_gdbarch_init): Don't register deleted function with
7789         gdbarch.
7790
7791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * sh-tdep.c (sh_unwind_sp): Delete.
7794         (sh_unwind_pc): Delete.
7795         (sh_dummy_id): Delete.
7796         (sh_gdbarch_init): Don't register deleted functions with
7797         gdbarch.
7798
7799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * score-tdep.c (score_unwind_sp): Delete.
7802         (score_unwind_pc): Delete.
7803         (score_dummy_id): Delete.
7804         (score_gdbarch_init): Don't register deleted functions with
7805         gdbarch.
7806
7807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * rx-tdep.c (rx_unwind_pc): Delete.
7810         (rx_unwind_sp): Delete.
7811         (rx_dummy_id): Delete.
7812         (rx_gdbarch_init): Don't register deleted functions with
7813         gdbarch.  Update comment.
7814
7815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7818         (rs6000_dummy_id): Delete.
7819         (rs6000_gdbarch_init): Don't register deleted functions with
7820         gdbarch.
7821
7822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * or1k-tdep.c (or1k_dummy_id): Delete.
7825         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7826
7827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7828
7829         * nios2-tdep.c (nios2_dummy_id): Delete.
7830         (nios2_unwind_sp): Delete.
7831         (nios2_gdbarch_init): Don't register deleted functions with
7832         gdbarch.
7833
7834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * nds32-tdep.c (nds32_dummy_id): Delete.
7837         (nds32_unwind_pc): Delete.
7838         (nds32_unwind_sp): Delete.
7839         (nds32_gdbarch_init): Don't register deleted functions with
7840         gdbarch.
7841
7842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * msp430-tdep.c (msp430_unwind_pc): Delete.
7845         (msp430_unwind_sp): Delete.
7846         (msp430_dummy_id): Delete.
7847         (msp430_gdbarch_init): Don't register deleted functions with
7848         gdbarch.
7849
7850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7851
7852         * moxie-tdep.c (moxie_unwind_sp): Delete.
7853         (moxie_unwind_pc): Delete.
7854         (moxie_dummy_id): Delete.
7855         (moxie_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7861         (mn10300_unwind_pc): Delete.
7862         (mn10300_unwind_sp): Delete.
7863         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7864         mn10300_unwind_sp.
7865         (mn10300_frame_unwind_init): Don't register deleted functions with
7866         gdbarch.
7867
7868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * mep-tdep.c (mep_unwind_pc): Delete.
7871         (mep_unwind_sp): Delete.
7872         (mep_dummy_id): Delete.
7873         (mep_gdbarch_init): Don't register deleted functions with
7874         gdbarch.
7875
7876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7877
7878         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7879         (m68hc11_unwind_sp): Delete.
7880         (m68hc11_gdbarch_init): Don't register deleted functions with
7881         gdbarch.
7882
7883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * m32r-tdep.c (m32r_unwind_sp): Delete.
7886         (m32r_unwind_pc): Delete.
7887         (m32r_dummy_id): Delete.
7888         (m32r_gdbarch_init): Don't register deleted functions with
7889         gdbarch.
7890
7891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * m32c-tdep.c (m32c_unwind_pc): Delete.
7894         (m32c_unwind_sp): Delete.
7895         (m32c_dummy_id): Delete.
7896         (m32c_gdbarch_init): Don't register deleted functions with
7897         gdbarch.
7898
7899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7900
7901         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7902         (lm32_unwind_pc): Delete.
7903         (lm32_dummy_id): Delete.
7904         (lm32_gdbarch_init): Don't register deleted functions with
7905         gdbarch.
7906
7907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7910         (iq2000_unwind_pc): Delete.
7911         (iq2000_dummy_id): Delete.
7912         (iq2000_gdbarch_init): Don't register deleted functions with
7913         gdbarch.
7914
7915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         * nds32-tdep.c (nds32_type_align): Delete.
7918         (nds32_push_dummy_call): Use type_align instead.
7919
7920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7921
7922         * arm-tdep.c (arm_type_align): Only handle vector override case.
7923         (arm_push_dummy_call): Use type_align.
7924         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7925
7926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7929         case.
7930         (pass_on_stack): Use type_align.
7931         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7932         function.
7933
7934 2019-04-23  Tom Tromey  <tromey@adacore.com>
7935
7936         * dwarf2read.c (line_header::file_name_at): Remove unused
7937         overload.
7938
7939 2019-04-23  Tom de Vries  <tdevries@suse.de>
7940
7941         PR gdb/24438
7942         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7943         invocation.
7944
7945
7946 2019-03-27  Ali Tamur  <tamur@google.com>
7947
7948         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7949         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7950         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7951         (dwarf_expr_context::get_addr_index): Likewise
7952         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7953         (symbol_needs_eval_context::get_addr_index): Likewise
7954         (disassemble_dwarf_expression): Add DW_OP_addrx
7955         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7956         (read_cutu_die_from_dwo): Update comment
7957         (skip_one_die): Add DW_FORM_addrx
7958         (read_attribute_value): Likewise
7959         (var_decode_location): Add DW_OP_addrx
7960         (dwarf2_const_value_attr): Add DW_FORM_addrx
7961         (dump_die_shallow): Likewise
7962         (dwarf2_fetch_constant_bytes): Likewise
7963         (decode_locdesc): Add DW_OP_addrx
7964         (skip_form_bytes): Add DW_FORM_addrx
7965
7966 2019-04-22  Ali Tamur  <tamur@google.com>
7967
7968         * MAINTAINERS (Write After Approval): Add self.
7969
7970 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7971
7972         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7973         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7974         (open_symbol_file_object): Likewise.
7975         (svr4_default_sos): Add info parameter.
7976         (svr4_read_so_list): Likewise.
7977         (svr4_current_sos_direct): Adjust functions calls to pass down
7978         info.
7979         (svr4_current_sos_1): Add info parameter.
7980         (svr4_current_sos): Call get_svr4_info, pass info down to
7981         svr4_current_sos_1.
7982         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7983         get_svr4_info.
7984         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7985         get_svr4_info.
7986         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7987         to get_svr4_info.
7988         (probes_table_remove_objfile_probes): Likewise.
7989         (register_solib_event_probe): Add info parameter.
7990         (solist_update_incremental): Pass info parameter down to
7991         svr4_read_so_list.
7992         (disable_probes_interface): Add info parameter.
7993         (svr4_handle_solib_event): Pass current_program_space to
7994         get_svr4_info.  Adjust disable_probes_interface cleanup.
7995         (svr4_create_probe_breakpoints): Add info parameter, pass it
7996         down to register_solib_event_probe.
7997         (svr4_create_solib_event_breakpoints): Add info parameter,
7998         pass it down to svr4_create_probe_breakpoints.
7999         (enable_break): Pass info down to
8000         svr4_create_solib_event_breakpoints.
8001         (svr4_solib_create_inferior_hook): Pass current_program_space to
8002         get_svr4_info.
8003         (svr4_clear_solib): Likewise.
8004
8005 2019-04-22  Pedro Alves  <palves@redhat.com>
8006
8007         * solib-svr4.c (svr4_free_objfile_observer): New.
8008         (probe_and_action::objfile): New field.
8009         (probes_table_htab_remove_objfile_probes)
8010         (probes_table_remove_objfile_probes): New functions.
8011         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8012         in the new probe_and_action.  Don't store the probe in 'lookup'.
8013         (svr4_create_probe_breakpoints): Pass objfile to
8014         register_solib_event_probe.
8015         (_initialize_svr4_solib): Register a free_objfile observer.
8016
8017 2019-04-19  Tom Tromey  <tom@tromey.com>
8018
8019         * common/queue.h: Remove.
8020
8021 2019-04-19  Tom Tromey  <tom@tromey.com>
8022
8023         * event-loop.c: Don't include "common/queue.h".
8024
8025 2019-04-19  Tom Tromey  <tom@tromey.com>
8026
8027         * remote.c (remote_target): Use delete.
8028         * remote-notif.h: Include <list>, not "common/queue.h".
8029         (notif_client_p): Remove typedef.
8030         (remote_notif_state): Add constructor, destructor, initializer.
8031         <notif_queue>: Now a std::list.
8032         (remote_notif_state_xfree): Don't declare.
8033         * remote-notif.c (remote_notif_process, handle_notification)
8034         (remote_notif_state_allocate): Update.
8035         (~remote_notif_state): Rename from remote_notif_state_xfree.
8036
8037 2019-04-19  Tom Tromey  <tom@tromey.com>
8038
8039         * symfile.c (reread_symbols): Update.
8040         * objfiles.c (objfile_register_static_link)
8041         (objfile_lookup_static_link): Update
8042         (~objfile) Don't delete static_links.
8043         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8044
8045 2019-04-19  Tom Tromey  <tom@tromey.com>
8046
8047         * type-stack.h (struct type_stack) <insert>: Constify string.
8048         * type-stack.c (type_stack::insert): Constify string.
8049         * gdbtypes.h (lookup_template_type): Update.
8050         (address_space_name_to_int): Update.
8051         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8052         const.
8053         (lookup_template_type): Make name const.
8054         * c-exp.y: Update rules.
8055         (lex_one_token, classify_name, classify_inner_name)
8056         (c_print_token): Update.
8057         * p-exp.y: Update rules.
8058         (yylex): Update.
8059         * f-exp.y: Update rules.
8060         (yylex): Update.
8061         * d-exp.y: Update rules.
8062         (lex_one_token, classify_name, classify_inner_name): Update.
8063         * parse.c (write_dollar_variable, copy_name): Return std::string.
8064         * parser-defs.h (copy_name): Change return type.
8065         * m2-exp.y: Update rules.
8066         (yylex): Update.
8067         * go-exp.y (lex_one_token): Update.
8068         Update rules.
8069         (classify_unsafe_function, classify_packaged_name)
8070         (classify_name, yylex): Update.
8071
8072 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8073
8074         * configure.ac: add --enable-source-highlight switch.
8075         * configure: Regenerate.
8076         * top.c (print_gdb_version): plumb --enable-source-highlight
8077         status to "show configuration".
8078
8079 2019-04-19  Tom Tromey  <tromey@adacore.com>
8080
8081         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8082         Check ADA_TYPE_P.
8083         (empty_record, ada_template_to_fixed_record_type_1)
8084         (template_to_static_fixed_type)
8085         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8086         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8087         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8088         macros.
8089
8090 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8091
8092         PR symtab/24423:
8093         * source.c (print_source_lines_base): Advance "iter" when a
8094         control character is seen.
8095
8096 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8097
8098         * inferior.h (struct infcall_suspend_state_deleter):
8099         Catch exception in destructor to avoid crash.
8100
8101 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8102
8103         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8104         close to the add_com "shell".
8105
8106 2019-04-18  Tom Tromey  <tromey@adacore.com>
8107
8108         * process-stratum-target.h (class process_stratum_target)
8109         <stratum>: Add "final".
8110
8111 2019-04-17  Tom Tromey  <tromey@adacore.com>
8112
8113         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8114         against nullptr before use.
8115
8116 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8117
8118         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8119
8120 2019-04-17  Jim Wilson  <jimw@sifive.com>
8121             Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8124         code read might fail, assume 4-byte breakpoint in that case.
8125
8126 2019-04-15  Leszek Swirski  <leszeks@google.com>
8127
8128         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8129         rather than a hand-rolled POD check when checking for forced MEMORY
8130         classification.
8131
8132 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8133
8134         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8135         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8136         function.
8137         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8138         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8139         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8140         declaration.
8141
8142 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8143
8144         * aarch64-linux-nat.c
8145         (aarch64_linux_nat_target::thread_architecture): Add override.
8146         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8147         each VQ.
8148
8149 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8150
8151         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8152
8153 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8154
8155         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8156         target types of size 96-bits, add some additional comments, and
8157         check that the builtin type we found was the correct size.
8158
8159 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8160
8161         * utils.c (prompt_for_continue): Don't restore the styling at the
8162         end, as applied_style has the wrong value.  This fixes styling in
8163         long lists of file names that are interrupted by the "Continue?"
8164         prompt.
8165
8166 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8169         * c-lang.c (c_language_defn): Likewise.
8170         (cplus_language_defn): Likewise.
8171         (asm_language_defn): Likewise.
8172         (minimal_language_defn): Likewise.
8173         * d-lang.c (d_language_defn): Likewise.
8174         * f-lang.c (f_language_defn): Likewise.
8175         * go-lang.c (go_language_defn): Likewise.
8176         * language.c (unknown_language_defn): Likewise.
8177         (auto_language_defn): Likewise.
8178         * language.h (struct language_defn): Remove la_magic field.
8179         (LANG_MAGIC): Delete.
8180         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8181         * objc-lang.c (objc_language_defn): Likewise.
8182         * opencl-lang.c (opencl_language_defn): Likewise.
8183         * p-lang.c (pascal_language_defn): Likewise.
8184         * rust-lang.c (rust_language_defn): Likewise.
8185
8186 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * riscv-tdep.c (riscv_type_align): New function.
8189         (riscv_type_alignment): Delete.
8190         (riscv_arg_location): Use 'type_align'.
8191         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8192
8193 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * gdbtypes.c (type_align): A struct with no non-static fields also
8196         has alignment of 1.
8197
8198 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8201         component to 0.
8202         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8203         member.
8204         (riscv_struct_info::analyse): New implementation using new
8205         analyse_inner member function.
8206         (riscv_struct_info::field_offset): New member function.
8207         (riscv_struct_info::m_offsets): New member variable.
8208         (riscv_struct_info::analyse_inner): New private member function,
8209         takes the old implementation of riscv_struct_info::analyse but
8210         extended to track field offsets.
8211         (riscv_call_arg_struct): Update the struct folding special cases
8212         to handle cases where empty C++ structs, which are non-zero
8213         length, are found.
8214         (riscv_arg_location): Initialise the length of each location, a
8215         non-zero length now indicates the location is in use.
8216         (riscv_push_dummy_call): Allow for the first location having a
8217         non-zero offset when setting up arguments.
8218         (riscv_return_value): Likewise, but for return values.
8219
8220 2019-04-11  Tom Tromey  <tromey@adacore.com>
8221
8222         * utils.c (internal_vproblem): Make "msg" const.
8223
8224 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8225
8226         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8227         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8228         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8229         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8230
8231 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8232
8233         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8234         function.
8235         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8236         of amd64_collect_native_gregset.
8237         (amd64_linux_nat_target::store_registers): Likewise.
8238
8239 2019-04-10  Tom Tromey  <tom@tromey.com>
8240
8241         * symtab.c (lookup_global_symbol_from_objfile)
8242         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8243         * objfiles.h (class separate_debug_iterator): New.
8244         (class separate_debug_range): New.
8245         (struct objfile) <separate_debug_objfiles>: New method.
8246         (objfile_separate_debug_iterate): Don't declare.
8247         * objfiles.c (separate_debug_iterator::operator++): Rename from
8248         objfile_separate_debug_iterate.
8249         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8250         iterator.
8251         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8252         iterator.
8253
8254 2019-04-10  Tom Tromey  <tom@tromey.com>
8255
8256         * symfile.c (reread_symbols): Remove old comment.
8257         * objfiles.c (free_all_objfiles): Fix a typo.
8258
8259 2019-04-10  Tom Tromey  <tom@tromey.com>
8260
8261         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8262         * minsyms.c (lookup_minimal_symbol): Use foreach.
8263         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8264         (lookup_minimal_symbol_solib_trampoline): Likewise.
8265         * symfile.c (reread_symbols): Use foreach.
8266
8267 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8268             Tom Tromey  <tromey@adacore.com>
8269
8270         PR rust/24414:
8271         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8272         (rust_lex_int_test): Change "value" to be LONGEST.
8273         (rust_lex_tests): Add test for long integer literal.
8274
8275 2019-04-09  Tom Tromey  <tromey@adacore.com>
8276
8277         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8278         to bool.
8279         (extended_remote_target::attach): Update.
8280         (remote_target::remote_notice_new_inferior): Update.
8281         (remote_target::add_current_inferior_and_thread): Update.
8282         * inferior.c (exit_inferior_1): Use "false".
8283         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8284
8285 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8286
8287         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8288         the "start" command.
8289
8290 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8291
8292         * python/py-inferior.c (infpy_thread_from_thread_handle):
8293         Adjust comments to reflect renaming of thread_from_thread_handle
8294         to thread_from_handle.  Adjust keywords.  Fix type error message.
8295         (inferior_object_methods): Add thread_from_handle.  Retain
8296         thread_from_thread_handle, but mark it as deprecated.
8297
8298 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8299
8300         * gdbthread.h (find_thread_by_handle): Revise declaration.
8301         * thread.c (find_thread_by_handle): Likewise.  Adjust
8302         implementation too.
8303         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8304         support for buffer objects as handles.
8305
8306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8307
8308         * python/py-infthread.c (thpy_thread_handle): New function.
8309         (thread_object_methods): Register thpy_thread_handle.
8310
8311 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8312
8313         * gdbthread.h (thread_to_thread_handle): Declare.
8314         * thread.c (gdbtypes.h): Include.
8315         (thread_to_thread_handle): New function.
8316
8317         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8318         (target_thread_info_to_thread_handle): Declare.
8319         * target.c (target_thread_info_to_thread_handle): New function.
8320         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8321         * target-delegates.c: Regenerate.
8322
8323         * linux-thread-db.c (class thread_db_target): Add method
8324         thread_info_to_thread_handle.
8325         (thread_db_target::thread_info_to_thread_handle): Define.
8326         * remote.c (class remote_target): Add new method
8327         thread_info_to_thread_handle.
8328         (remote_target::thread_info_to_thread_handle): Define.
8329
8330 2019-04-08  Pedro Alves  <palves@redhat.com>
8331
8332         * common/common-exceptions.c (throw_exception): Don't create
8333         named object to throw; throw directly.
8334         (throw_it): Likewise.  Don't initialize gdb_exception::message
8335         here, with new; pass FMT and AP to the ctor instead.
8336         * common/common-exceptions.h: Include <string>.
8337         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8338         const char *, va_list)): New ctor.  Use std::make_shared.
8339         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8340         errors)): Delete.
8341         (gdb_exception_error::gdb_exception_error(enum errors, const char
8342         *, va_list)): New.
8343         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8344         Add assertion.
8345         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8346         errors)): Delete.
8347         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8348         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8349         Add assertion.
8350
8351 2019-04-08  Tom Tromey  <tom@tromey.com>
8352
8353         * valops.c (value_rtti_indirect_type): Replace throw_exception
8354         with throw.
8355         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8356         with throw.
8357         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8358         throw.
8359         * target.c (target_translate_tls_address): Replace throw_exception
8360         with throw.
8361         * stack.c (frame_apply_command_count): Replace throw_exception
8362         with throw.
8363         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8364         throw.
8365         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8366         with throw.
8367         * rs6000-tdep.c (rs6000_frame_cache)
8368         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8369         * remote.c: Replace throw_exception with throw.
8370         * record-full.c (record_full_message, record_full_wait_1)
8371         (record_full_restore): Replace throw_exception with throw.
8372         * record-btrace.c:
8373         (get_thread_current_frame_id, record_btrace_start_replaying)
8374         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8375         (cmd_record_btrace_start): Replace throw_exception with throw.
8376         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8377         throw.
8378         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8379         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8380         * linespec.c:
8381         (find_linespec_symbols): Replace throw_exception with throw.
8382         * infrun.c (displaced_step_prepare, resume): Replace
8383         throw_exception with throw.
8384         * infcmd.c (post_create_inferior): Replace throw_exception with
8385         throw.
8386         * inf-loop.c (inferior_event_handler): Replace throw_exception
8387         with throw.
8388         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8389         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8390         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8391         (get_prev_frame_always, get_frame_pc_if_available)
8392         (get_frame_address_in_block_if_available, get_frame_language):
8393         Replace throw_exception with throw.
8394         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8395         throw_exception with throw.
8396         * eval.c (fetch_subexp_value, evaluate_var_value)
8397         (evaluate_funcall, evaluate_subexp_standard): Replace
8398         throw_exception with throw.
8399         * dwarf2loc.c (call_site_find_chain)
8400         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8401         Replace throw_exception with throw.
8402         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8403         with throw.
8404         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8405         throw.
8406         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8407         * completer.c (complete_line_internal): Replace throw_exception
8408         with throw.
8409         * compile/compile-object-run.c (compile_object_run): Replace
8410         throw_exception with throw.
8411         * cli/cli-script.c (process_next_line): Replace throw_exception
8412         with throw.
8413         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8414         (btrace_enable, btrace_maint_update_pt_packets): Replace
8415         throw_exception with throw.
8416         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8417         throw_exception with throw.
8418         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8419         throw_exception with throw.
8420         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8421         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8422         * aarch64-tdep.c (aarch64_make_prologue_cache)
8423         (aarch64_make_stub_cache): Replace throw_exception with throw.
8424
8425 2019-04-08  Tom Tromey  <tom@tromey.com>
8426
8427         * common/common-exceptions.c (throw_exception): Rename from
8428         throw_exception_cxx.  Remove old copy.  Make argument const.
8429         (throw_it): Create and throw exception objects directly.
8430         * common/common-exceptions.h (throw_exception): Make argument
8431         const.
8432         (struct gdb_exception_error): Add constructor.
8433         (struct gdb_exception_quit): Add constructor.
8434
8435 2019-04-08  Tom Tromey  <tom@tromey.com>
8436
8437         * common/common-exceptions.h (exception_rethrow): Don't declare.
8438         (TRY_SJLJ): Update comment.
8439         (TRY, CATCH, END_CATCH): Remove.
8440         * common/common-exceptions.c (exception_rethrow): Remove.
8441
8442 2019-04-08  Tom Tromey  <tom@tromey.com>
8443
8444         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8445         Remove.
8446         (gdb_exception_error): Rename from
8447         gdb_exception_RETURN_MASK_ERROR.
8448         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8449         (gdb_quit_bad_alloc): Update.
8450         * aarch64-tdep.c: Update.
8451         * ada-lang.c: Update.
8452         * ada-typeprint.c: Update.
8453         * ada-valprint.c: Update.
8454         * amd64-tdep.c: Update.
8455         * arch-utils.c: Update.
8456         * break-catch-throw.c: Update.
8457         * breakpoint.c: Update.
8458         * btrace.c: Update.
8459         * c-varobj.c: Update.
8460         * cli/cli-cmds.c: Update.
8461         * cli/cli-interp.c: Update.
8462         * cli/cli-script.c: Update.
8463         * common/common-exceptions.c: Update.
8464         * common/new-op.c: Update.
8465         * common/selftest.c: Update.
8466         * compile/compile-c-symbols.c: Update.
8467         * compile/compile-cplus-symbols.c: Update.
8468         * compile/compile-object-load.c: Update.
8469         * compile/compile-object-run.c: Update.
8470         * completer.c: Update.
8471         * corelow.c: Update.
8472         * cp-abi.c: Update.
8473         * cp-support.c: Update.
8474         * cp-valprint.c: Update.
8475         * darwin-nat.c: Update.
8476         * disasm-selftests.c: Update.
8477         * dtrace-probe.c: Update.
8478         * dwarf-index-cache.c: Update.
8479         * dwarf-index-write.c: Update.
8480         * dwarf2-frame-tailcall.c: Update.
8481         * dwarf2-frame.c: Update.
8482         * dwarf2loc.c: Update.
8483         * dwarf2read.c: Update.
8484         * eval.c: Update.
8485         * event-loop.c: Update.
8486         * event-top.c: Update.
8487         * exec.c: Update.
8488         * f-valprint.c: Update.
8489         * fbsd-tdep.c: Update.
8490         * frame-unwind.c: Update.
8491         * frame.c: Update.
8492         * gdbtypes.c: Update.
8493         * gnu-v3-abi.c: Update.
8494         * guile/guile-internal.h: Update.
8495         * guile/scm-block.c: Update.
8496         * guile/scm-breakpoint.c: Update.
8497         * guile/scm-cmd.c: Update.
8498         * guile/scm-disasm.c: Update.
8499         * guile/scm-frame.c: Update.
8500         * guile/scm-lazy-string.c: Update.
8501         * guile/scm-math.c: Update.
8502         * guile/scm-param.c: Update.
8503         * guile/scm-ports.c: Update.
8504         * guile/scm-pretty-print.c: Update.
8505         * guile/scm-symbol.c: Update.
8506         * guile/scm-symtab.c: Update.
8507         * guile/scm-type.c: Update.
8508         * guile/scm-value.c: Update.
8509         * i386-linux-tdep.c: Update.
8510         * i386-tdep.c: Update.
8511         * inf-loop.c: Update.
8512         * infcall.c: Update.
8513         * infcmd.c: Update.
8514         * infrun.c: Update.
8515         * jit.c: Update.
8516         * language.c: Update.
8517         * linespec.c: Update.
8518         * linux-fork.c: Update.
8519         * linux-nat.c: Update.
8520         * linux-tdep.c: Update.
8521         * linux-thread-db.c: Update.
8522         * main.c: Update.
8523         * mi/mi-cmd-break.c: Update.
8524         * mi/mi-cmd-stack.c: Update.
8525         * mi/mi-interp.c: Update.
8526         * mi/mi-main.c: Update.
8527         * objc-lang.c: Update.
8528         * p-valprint.c: Update.
8529         * parse.c: Update.
8530         * ppc-linux-tdep.c: Update.
8531         * printcmd.c: Update.
8532         * python/py-arch.c: Update.
8533         * python/py-breakpoint.c: Update.
8534         * python/py-cmd.c: Update.
8535         * python/py-finishbreakpoint.c: Update.
8536         * python/py-frame.c: Update.
8537         * python/py-framefilter.c: Update.
8538         * python/py-gdb-readline.c: Update.
8539         * python/py-inferior.c: Update.
8540         * python/py-infthread.c: Update.
8541         * python/py-lazy-string.c: Update.
8542         * python/py-linetable.c: Update.
8543         * python/py-objfile.c: Update.
8544         * python/py-param.c: Update.
8545         * python/py-prettyprint.c: Update.
8546         * python/py-progspace.c: Update.
8547         * python/py-record-btrace.c: Update.
8548         * python/py-record.c: Update.
8549         * python/py-symbol.c: Update.
8550         * python/py-type.c: Update.
8551         * python/py-unwind.c: Update.
8552         * python/py-utils.c: Update.
8553         * python/py-value.c: Update.
8554         * python/python.c: Update.
8555         * record-btrace.c: Update.
8556         * record-full.c: Update.
8557         * remote-fileio.c: Update.
8558         * remote.c: Update.
8559         * riscv-tdep.c: Update.
8560         * rs6000-aix-tdep.c: Update.
8561         * rs6000-tdep.c: Update.
8562         * rust-exp.y: Update.
8563         * rust-lang.c: Update.
8564         * s390-tdep.c: Update.
8565         * selftest-arch.c: Update.
8566         * solib-dsbt.c: Update.
8567         * solib-frv.c: Update.
8568         * solib-spu.c: Update.
8569         * solib-svr4.c: Update.
8570         * solib.c: Update.
8571         * sparc64-linux-tdep.c: Update.
8572         * stack.c: Update.
8573         * symfile-mem.c: Update.
8574         * symmisc.c: Update.
8575         * target.c: Update.
8576         * thread.c: Update.
8577         * top.c: Update.
8578         * tracefile-tfile.c: Update.
8579         * tui/tui.c: Update.
8580         * typeprint.c: Update.
8581         * unittests/cli-utils-selftests.c: Update.
8582         * unittests/parse-connection-spec-selftests.c: Update.
8583         * valops.c: Update.
8584         * valprint.c: Update.
8585         * value.c: Update.
8586         * varobj.c: Update.
8587         * windows-nat.c: Update.
8588         * x86-linux-nat.c: Update.
8589         * xml-support.c: Update.
8590
8591 2019-04-08  Tom Tromey  <tom@tromey.com>
8592
8593         * xml-support.c: Use C++ exception handling.
8594         * x86-linux-nat.c: Use C++ exception handling.
8595         * windows-nat.c: Use C++ exception handling.
8596         * varobj.c: Use C++ exception handling.
8597         * value.c: Use C++ exception handling.
8598         * valprint.c: Use C++ exception handling.
8599         * valops.c: Use C++ exception handling.
8600         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8601         handling.
8602         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8603         * typeprint.c: Use C++ exception handling.
8604         * tui/tui.c: Use C++ exception handling.
8605         * tracefile-tfile.c: Use C++ exception handling.
8606         * top.c: Use C++ exception handling.
8607         * thread.c: Use C++ exception handling.
8608         * target.c: Use C++ exception handling.
8609         * symmisc.c: Use C++ exception handling.
8610         * symfile-mem.c: Use C++ exception handling.
8611         * stack.c: Use C++ exception handling.
8612         * sparc64-linux-tdep.c: Use C++ exception handling.
8613         * solib.c: Use C++ exception handling.
8614         * solib-svr4.c: Use C++ exception handling.
8615         * solib-spu.c: Use C++ exception handling.
8616         * solib-frv.c: Use C++ exception handling.
8617         * solib-dsbt.c: Use C++ exception handling.
8618         * selftest-arch.c: Use C++ exception handling.
8619         * s390-tdep.c: Use C++ exception handling.
8620         * rust-lang.c: Use C++ exception handling.
8621         * rust-exp.y: Use C++ exception handling.
8622         * rs6000-tdep.c: Use C++ exception handling.
8623         * rs6000-aix-tdep.c: Use C++ exception handling.
8624         * riscv-tdep.c: Use C++ exception handling.
8625         * remote.c: Use C++ exception handling.
8626         * remote-fileio.c: Use C++ exception handling.
8627         * record-full.c: Use C++ exception handling.
8628         * record-btrace.c: Use C++ exception handling.
8629         * python/python.c: Use C++ exception handling.
8630         * python/py-value.c: Use C++ exception handling.
8631         * python/py-utils.c: Use C++ exception handling.
8632         * python/py-unwind.c: Use C++ exception handling.
8633         * python/py-type.c: Use C++ exception handling.
8634         * python/py-symbol.c: Use C++ exception handling.
8635         * python/py-record.c: Use C++ exception handling.
8636         * python/py-record-btrace.c: Use C++ exception handling.
8637         * python/py-progspace.c: Use C++ exception handling.
8638         * python/py-prettyprint.c: Use C++ exception handling.
8639         * python/py-param.c: Use C++ exception handling.
8640         * python/py-objfile.c: Use C++ exception handling.
8641         * python/py-linetable.c: Use C++ exception handling.
8642         * python/py-lazy-string.c: Use C++ exception handling.
8643         * python/py-infthread.c: Use C++ exception handling.
8644         * python/py-inferior.c: Use C++ exception handling.
8645         * python/py-gdb-readline.c: Use C++ exception handling.
8646         * python/py-framefilter.c: Use C++ exception handling.
8647         * python/py-frame.c: Use C++ exception handling.
8648         * python/py-finishbreakpoint.c: Use C++ exception handling.
8649         * python/py-cmd.c: Use C++ exception handling.
8650         * python/py-breakpoint.c: Use C++ exception handling.
8651         * python/py-arch.c: Use C++ exception handling.
8652         * printcmd.c: Use C++ exception handling.
8653         * ppc-linux-tdep.c: Use C++ exception handling.
8654         * parse.c: Use C++ exception handling.
8655         * p-valprint.c: Use C++ exception handling.
8656         * objc-lang.c: Use C++ exception handling.
8657         * mi/mi-main.c: Use C++ exception handling.
8658         * mi/mi-interp.c: Use C++ exception handling.
8659         * mi/mi-cmd-stack.c: Use C++ exception handling.
8660         * mi/mi-cmd-break.c: Use C++ exception handling.
8661         * main.c: Use C++ exception handling.
8662         * linux-thread-db.c: Use C++ exception handling.
8663         * linux-tdep.c: Use C++ exception handling.
8664         * linux-nat.c: Use C++ exception handling.
8665         * linux-fork.c: Use C++ exception handling.
8666         * linespec.c: Use C++ exception handling.
8667         * language.c: Use C++ exception handling.
8668         * jit.c: Use C++ exception handling.
8669         * infrun.c: Use C++ exception handling.
8670         * infcmd.c: Use C++ exception handling.
8671         * infcall.c: Use C++ exception handling.
8672         * inf-loop.c: Use C++ exception handling.
8673         * i386-tdep.c: Use C++ exception handling.
8674         * i386-linux-tdep.c: Use C++ exception handling.
8675         * guile/scm-value.c: Use C++ exception handling.
8676         * guile/scm-type.c: Use C++ exception handling.
8677         * guile/scm-symtab.c: Use C++ exception handling.
8678         * guile/scm-symbol.c: Use C++ exception handling.
8679         * guile/scm-pretty-print.c: Use C++ exception handling.
8680         * guile/scm-ports.c: Use C++ exception handling.
8681         * guile/scm-param.c: Use C++ exception handling.
8682         * guile/scm-math.c: Use C++ exception handling.
8683         * guile/scm-lazy-string.c: Use C++ exception handling.
8684         * guile/scm-frame.c: Use C++ exception handling.
8685         * guile/scm-disasm.c: Use C++ exception handling.
8686         * guile/scm-cmd.c: Use C++ exception handling.
8687         * guile/scm-breakpoint.c: Use C++ exception handling.
8688         * guile/scm-block.c: Use C++ exception handling.
8689         * guile/guile-internal.h: Use C++ exception handling.
8690         * gnu-v3-abi.c: Use C++ exception handling.
8691         * gdbtypes.c: Use C++ exception handling.
8692         * frame.c: Use C++ exception handling.
8693         * frame-unwind.c: Use C++ exception handling.
8694         * fbsd-tdep.c: Use C++ exception handling.
8695         * f-valprint.c: Use C++ exception handling.
8696         * exec.c: Use C++ exception handling.
8697         * event-top.c: Use C++ exception handling.
8698         * event-loop.c: Use C++ exception handling.
8699         * eval.c: Use C++ exception handling.
8700         * dwarf2read.c: Use C++ exception handling.
8701         * dwarf2loc.c: Use C++ exception handling.
8702         * dwarf2-frame.c: Use C++ exception handling.
8703         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8704         * dwarf-index-write.c: Use C++ exception handling.
8705         * dwarf-index-cache.c: Use C++ exception handling.
8706         * dtrace-probe.c: Use C++ exception handling.
8707         * disasm-selftests.c: Use C++ exception handling.
8708         * darwin-nat.c: Use C++ exception handling.
8709         * cp-valprint.c: Use C++ exception handling.
8710         * cp-support.c: Use C++ exception handling.
8711         * cp-abi.c: Use C++ exception handling.
8712         * corelow.c: Use C++ exception handling.
8713         * completer.c: Use C++ exception handling.
8714         * compile/compile-object-run.c: Use C++ exception handling.
8715         * compile/compile-object-load.c: Use C++ exception handling.
8716         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8717         * compile/compile-c-symbols.c: Use C++ exception handling.
8718         * common/selftest.c: Use C++ exception handling.
8719         * common/new-op.c: Use C++ exception handling.
8720         * cli/cli-script.c: Use C++ exception handling.
8721         * cli/cli-interp.c: Use C++ exception handling.
8722         * cli/cli-cmds.c: Use C++ exception handling.
8723         * c-varobj.c: Use C++ exception handling.
8724         * btrace.c: Use C++ exception handling.
8725         * breakpoint.c: Use C++ exception handling.
8726         * break-catch-throw.c: Use C++ exception handling.
8727         * arch-utils.c: Use C++ exception handling.
8728         * amd64-tdep.c: Use C++ exception handling.
8729         * ada-valprint.c: Use C++ exception handling.
8730         * ada-typeprint.c: Use C++ exception handling.
8731         * ada-lang.c: Use C++ exception handling.
8732         * aarch64-tdep.c: Use C++ exception handling.
8733
8734 2019-04-08  Tom Tromey  <tom@tromey.com>
8735
8736         * xml-support.c (gdb_xml_parser::parse): Update.
8737         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8738         * value.c (show_convenience): Update.
8739         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8740         (test_parse_flags_qcs): Update.
8741         * thread.c (thr_try_catch_cmd): Update.
8742         * target.c (target_translate_tls_address): Update.
8743         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8744         (info_frame_command_core, frame_apply_command_count): Update.
8745         * rust-exp.y (rust_lex_exception_test): Update.
8746         * riscv-tdep.c (riscv_print_one_register_info): Update.
8747         * remote.c (remote_target::enable_btrace): Update.
8748         * record-btrace.c (record_btrace_enable_warn): Update.
8749         * python/py-utils.c (gdbpy_convert_exception): Update.
8750         * printcmd.c (do_one_display, print_variable_and_value): Update.
8751         * mi/mi-main.c (mi_print_exception): Update.
8752         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8753         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8754         * linux-nat.c (linux_nat_target::attach): Update.
8755         * linux-fork.c (class scoped_switch_fork_info): Update.
8756         * infrun.c (displaced_step_prepare): Update.
8757         * infcall.c (call_function_by_hand_dummy): Update.
8758         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8759         * gnu-v3-abi.c (print_one_vtable): Update.
8760         * frame.c (get_prev_frame_always): Update.
8761         * f-valprint.c (info_common_command_for_block): Update.
8762         * exec.c (try_open_exec_file): Update.
8763         * exceptions.c (print_exception, exception_print)
8764         (exception_fprintf, exception_print_same): Update.
8765         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8766         * dwarf-index-cache.c (index_cache::store)
8767         (index_cache::lookup_gdb_index): Update.
8768         * darwin-nat.c (maybe_cache_shell): Update.
8769         * cp-valprint.c (cp_print_value_fields): Update.
8770         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8771         (gcc_cplus_symbol_address): Update.
8772         * compile/compile-c-symbols.c (gcc_convert_symbol)
8773         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8774         * common/selftest.c: Update.
8775         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8776         a std::string.
8777         (exception_try_scope_entry, exception_try_scope_exit): Don't
8778         declare.
8779         (struct exception_try_scope): Remove.
8780         (TRY): Don't use exception_try_scope.
8781         (struct gdb_exception): Add constructor, operator=.
8782         <what>: New method.
8783         (struct gdb_exception_RETURN_MASK_ALL)
8784         (struct gdb_exception_RETURN_MASK_ERROR)
8785         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8786         (struct gdb_quit_bad_alloc): Update.
8787         * common/common-exceptions.c (exception_none): Change
8788         initializer.
8789         (struct catcher) <state, exception>: Initialize inline.
8790         <prev>: Remove member.
8791         (current_catcher): Remove.
8792         (catchers): New global.
8793         (exceptions_state_mc_init): Simplify.
8794         (catcher_pop): Remove.
8795         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8796         (try_scope_depth, exception_try_scope_entry)
8797         (exception_try_scope_exit): Remove.
8798         (throw_exception_sjlj): Update.
8799         (exception_messages, exception_messages_size): Remove.
8800         (throw_it): Simplify.
8801         (gdb_exception_sliced_copy): Remove.
8802         (throw_exception_cxx): Update.
8803         * cli/cli-script.c (script_from_file): Update.
8804         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8805         Update.
8806         * ada-valprint.c (ada_val_print): Update.
8807         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8808         (create_excep_cond_exprs): Update.
8809
8810 2019-04-08  Tom Tromey  <tom@tromey.com>
8811
8812         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8813         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8814         (TRY, CATCH, END_CATCH): Remove some definitions.
8815         * common/common-exceptions.c: Don't use GDB_XCPT.
8816         (catcher_list_size): Remove.
8817         (throw_exception, throw_it): Simplify.
8818
8819 2019-04-05  Tom Tromey  <tom@tromey.com>
8820
8821         Revert the header-sorting patch.
8822         * ft32-tdep.c: Revert.
8823         * frv-tdep.c: Revert.
8824         * frv-linux-tdep.c: Revert.
8825         * frame.c: Revert.
8826         * frame-unwind.c: Revert.
8827         * frame-base.c: Revert.
8828         * fork-child.c: Revert.
8829         * findvar.c: Revert.
8830         * findcmd.c: Revert.
8831         * filesystem.c: Revert.
8832         * filename-seen-cache.h: Revert.
8833         * filename-seen-cache.c: Revert.
8834         * fbsd-tdep.c: Revert.
8835         * fbsd-nat.h: Revert.
8836         * fbsd-nat.c: Revert.
8837         * f-valprint.c: Revert.
8838         * f-typeprint.c: Revert.
8839         * f-lang.c: Revert.
8840         * extension.h: Revert.
8841         * extension.c: Revert.
8842         * extension-priv.h: Revert.
8843         * expprint.c: Revert.
8844         * exec.h: Revert.
8845         * exec.c: Revert.
8846         * exceptions.c: Revert.
8847         * event-top.c: Revert.
8848         * event-loop.c: Revert.
8849         * eval.c: Revert.
8850         * elfread.c: Revert.
8851         * dwarf2read.h: Revert.
8852         * dwarf2read.c: Revert.
8853         * dwarf2loc.c: Revert.
8854         * dwarf2expr.h: Revert.
8855         * dwarf2expr.c: Revert.
8856         * dwarf2-frame.c: Revert.
8857         * dwarf2-frame-tailcall.c: Revert.
8858         * dwarf-index-write.h: Revert.
8859         * dwarf-index-write.c: Revert.
8860         * dwarf-index-common.c: Revert.
8861         * dwarf-index-cache.h: Revert.
8862         * dwarf-index-cache.c: Revert.
8863         * dummy-frame.c: Revert.
8864         * dtrace-probe.c: Revert.
8865         * disasm.h: Revert.
8866         * disasm.c: Revert.
8867         * disasm-selftests.c: Revert.
8868         * dictionary.c: Revert.
8869         * dicos-tdep.c: Revert.
8870         * demangle.c: Revert.
8871         * dcache.h: Revert.
8872         * dcache.c: Revert.
8873         * darwin-nat.h: Revert.
8874         * darwin-nat.c: Revert.
8875         * darwin-nat-info.c: Revert.
8876         * d-valprint.c: Revert.
8877         * d-namespace.c: Revert.
8878         * d-lang.c: Revert.
8879         * ctf.c: Revert.
8880         * csky-tdep.c: Revert.
8881         * csky-linux-tdep.c: Revert.
8882         * cris-tdep.c: Revert.
8883         * cris-linux-tdep.c: Revert.
8884         * cp-valprint.c: Revert.
8885         * cp-support.c: Revert.
8886         * cp-namespace.c: Revert.
8887         * cp-abi.c: Revert.
8888         * corelow.c: Revert.
8889         * corefile.c: Revert.
8890         * continuations.c: Revert.
8891         * completer.h: Revert.
8892         * completer.c: Revert.
8893         * complaints.c: Revert.
8894         * coffread.c: Revert.
8895         * coff-pe-read.c: Revert.
8896         * cli-out.h: Revert.
8897         * cli-out.c: Revert.
8898         * charset.c: Revert.
8899         * c-varobj.c: Revert.
8900         * c-valprint.c: Revert.
8901         * c-typeprint.c: Revert.
8902         * c-lang.c: Revert.
8903         * buildsym.c: Revert.
8904         * buildsym-legacy.c: Revert.
8905         * build-id.h: Revert.
8906         * build-id.c: Revert.
8907         * btrace.c: Revert.
8908         * bsd-uthread.c: Revert.
8909         * breakpoint.h: Revert.
8910         * breakpoint.c: Revert.
8911         * break-catch-throw.c: Revert.
8912         * break-catch-syscall.c: Revert.
8913         * break-catch-sig.c: Revert.
8914         * blockframe.c: Revert.
8915         * block.c: Revert.
8916         * bfin-tdep.c: Revert.
8917         * bfin-linux-tdep.c: Revert.
8918         * bfd-target.c: Revert.
8919         * bcache.c: Revert.
8920         * ax-general.c: Revert.
8921         * ax-gdb.h: Revert.
8922         * ax-gdb.c: Revert.
8923         * avr-tdep.c: Revert.
8924         * auxv.c: Revert.
8925         * auto-load.c: Revert.
8926         * arm-wince-tdep.c: Revert.
8927         * arm-tdep.c: Revert.
8928         * arm-symbian-tdep.c: Revert.
8929         * arm-pikeos-tdep.c: Revert.
8930         * arm-obsd-tdep.c: Revert.
8931         * arm-nbsd-tdep.c: Revert.
8932         * arm-nbsd-nat.c: Revert.
8933         * arm-linux-tdep.c: Revert.
8934         * arm-linux-nat.c: Revert.
8935         * arm-fbsd-tdep.c: Revert.
8936         * arm-fbsd-nat.c: Revert.
8937         * arm-bsd-tdep.c: Revert.
8938         * arch-utils.c: Revert.
8939         * arc-tdep.c: Revert.
8940         * arc-newlib-tdep.c: Revert.
8941         * annotate.h: Revert.
8942         * annotate.c: Revert.
8943         * amd64-windows-tdep.c: Revert.
8944         * amd64-windows-nat.c: Revert.
8945         * amd64-tdep.c: Revert.
8946         * amd64-sol2-tdep.c: Revert.
8947         * amd64-obsd-tdep.c: Revert.
8948         * amd64-obsd-nat.c: Revert.
8949         * amd64-nbsd-tdep.c: Revert.
8950         * amd64-nbsd-nat.c: Revert.
8951         * amd64-nat.c: Revert.
8952         * amd64-linux-tdep.c: Revert.
8953         * amd64-linux-nat.c: Revert.
8954         * amd64-fbsd-tdep.c: Revert.
8955         * amd64-fbsd-nat.c: Revert.
8956         * amd64-dicos-tdep.c: Revert.
8957         * amd64-darwin-tdep.c: Revert.
8958         * amd64-bsd-nat.c: Revert.
8959         * alpha-tdep.c: Revert.
8960         * alpha-obsd-tdep.c: Revert.
8961         * alpha-nbsd-tdep.c: Revert.
8962         * alpha-mdebug-tdep.c: Revert.
8963         * alpha-linux-tdep.c: Revert.
8964         * alpha-linux-nat.c: Revert.
8965         * alpha-bsd-tdep.c: Revert.
8966         * alpha-bsd-nat.c: Revert.
8967         * aix-thread.c: Revert.
8968         * agent.c: Revert.
8969         * addrmap.c: Revert.
8970         * ada-varobj.c: Revert.
8971         * ada-valprint.c: Revert.
8972         * ada-typeprint.c: Revert.
8973         * ada-tasks.c: Revert.
8974         * ada-lang.c: Revert.
8975         * aarch64-tdep.c: Revert.
8976         * aarch64-ravenscar-thread.c: Revert.
8977         * aarch64-newlib-tdep.c: Revert.
8978         * aarch64-linux-tdep.c: Revert.
8979         * aarch64-linux-nat.c: Revert.
8980         * aarch64-fbsd-tdep.c: Revert.
8981         * aarch64-fbsd-nat.c: Revert.
8982         * aarch32-linux-nat.c: Revert.
8983
8984 2019-04-05  Tom Tromey  <tom@tromey.com>
8985
8986         * ft32-tdep.c: Sort headers.
8987         * frv-tdep.c: Sort headers.
8988         * frv-linux-tdep.c: Sort headers.
8989         * frame.c: Sort headers.
8990         * frame-unwind.c: Sort headers.
8991         * frame-base.c: Sort headers.
8992         * fork-child.c: Sort headers.
8993         * findvar.c: Sort headers.
8994         * findcmd.c: Sort headers.
8995         * filesystem.c: Sort headers.
8996         * filename-seen-cache.h: Sort headers.
8997         * filename-seen-cache.c: Sort headers.
8998         * fbsd-tdep.c: Sort headers.
8999         * fbsd-nat.h: Sort headers.
9000         * fbsd-nat.c: Sort headers.
9001         * f-valprint.c: Sort headers.
9002         * f-typeprint.c: Sort headers.
9003         * f-lang.c: Sort headers.
9004         * extension.h: Sort headers.
9005         * extension.c: Sort headers.
9006         * extension-priv.h: Sort headers.
9007         * expprint.c: Sort headers.
9008         * exec.h: Sort headers.
9009         * exec.c: Sort headers.
9010         * exceptions.c: Sort headers.
9011         * event-top.c: Sort headers.
9012         * event-loop.c: Sort headers.
9013         * eval.c: Sort headers.
9014         * elfread.c: Sort headers.
9015         * dwarf2read.h: Sort headers.
9016         * dwarf2read.c: Sort headers.
9017         * dwarf2loc.c: Sort headers.
9018         * dwarf2expr.h: Sort headers.
9019         * dwarf2expr.c: Sort headers.
9020         * dwarf2-frame.c: Sort headers.
9021         * dwarf2-frame-tailcall.c: Sort headers.
9022         * dwarf-index-write.h: Sort headers.
9023         * dwarf-index-write.c: Sort headers.
9024         * dwarf-index-common.c: Sort headers.
9025         * dwarf-index-cache.h: Sort headers.
9026         * dwarf-index-cache.c: Sort headers.
9027         * dummy-frame.c: Sort headers.
9028         * dtrace-probe.c: Sort headers.
9029         * disasm.h: Sort headers.
9030         * disasm.c: Sort headers.
9031         * disasm-selftests.c: Sort headers.
9032         * dictionary.c: Sort headers.
9033         * dicos-tdep.c: Sort headers.
9034         * demangle.c: Sort headers.
9035         * dcache.h: Sort headers.
9036         * dcache.c: Sort headers.
9037         * darwin-nat.h: Sort headers.
9038         * darwin-nat.c: Sort headers.
9039         * darwin-nat-info.c: Sort headers.
9040         * d-valprint.c: Sort headers.
9041         * d-namespace.c: Sort headers.
9042         * d-lang.c: Sort headers.
9043         * ctf.c: Sort headers.
9044         * csky-tdep.c: Sort headers.
9045         * csky-linux-tdep.c: Sort headers.
9046         * cris-tdep.c: Sort headers.
9047         * cris-linux-tdep.c: Sort headers.
9048         * cp-valprint.c: Sort headers.
9049         * cp-support.c: Sort headers.
9050         * cp-namespace.c: Sort headers.
9051         * cp-abi.c: Sort headers.
9052         * corelow.c: Sort headers.
9053         * corefile.c: Sort headers.
9054         * continuations.c: Sort headers.
9055         * completer.h: Sort headers.
9056         * completer.c: Sort headers.
9057         * complaints.c: Sort headers.
9058         * coffread.c: Sort headers.
9059         * coff-pe-read.c: Sort headers.
9060         * cli-out.h: Sort headers.
9061         * cli-out.c: Sort headers.
9062         * charset.c: Sort headers.
9063         * c-varobj.c: Sort headers.
9064         * c-valprint.c: Sort headers.
9065         * c-typeprint.c: Sort headers.
9066         * c-lang.c: Sort headers.
9067         * buildsym.c: Sort headers.
9068         * buildsym-legacy.c: Sort headers.
9069         * build-id.h: Sort headers.
9070         * build-id.c: Sort headers.
9071         * btrace.c: Sort headers.
9072         * bsd-uthread.c: Sort headers.
9073         * breakpoint.h: Sort headers.
9074         * breakpoint.c: Sort headers.
9075         * break-catch-throw.c: Sort headers.
9076         * break-catch-syscall.c: Sort headers.
9077         * break-catch-sig.c: Sort headers.
9078         * blockframe.c: Sort headers.
9079         * block.c: Sort headers.
9080         * bfin-tdep.c: Sort headers.
9081         * bfin-linux-tdep.c: Sort headers.
9082         * bfd-target.c: Sort headers.
9083         * bcache.c: Sort headers.
9084         * ax-general.c: Sort headers.
9085         * ax-gdb.h: Sort headers.
9086         * ax-gdb.c: Sort headers.
9087         * avr-tdep.c: Sort headers.
9088         * auxv.c: Sort headers.
9089         * auto-load.c: Sort headers.
9090         * arm-wince-tdep.c: Sort headers.
9091         * arm-tdep.c: Sort headers.
9092         * arm-symbian-tdep.c: Sort headers.
9093         * arm-pikeos-tdep.c: Sort headers.
9094         * arm-obsd-tdep.c: Sort headers.
9095         * arm-nbsd-tdep.c: Sort headers.
9096         * arm-nbsd-nat.c: Sort headers.
9097         * arm-linux-tdep.c: Sort headers.
9098         * arm-linux-nat.c: Sort headers.
9099         * arm-fbsd-tdep.c: Sort headers.
9100         * arm-fbsd-nat.c: Sort headers.
9101         * arm-bsd-tdep.c: Sort headers.
9102         * arch-utils.c: Sort headers.
9103         * arc-tdep.c: Sort headers.
9104         * arc-newlib-tdep.c: Sort headers.
9105         * annotate.h: Sort headers.
9106         * annotate.c: Sort headers.
9107         * amd64-windows-tdep.c: Sort headers.
9108         * amd64-windows-nat.c: Sort headers.
9109         * amd64-tdep.c: Sort headers.
9110         * amd64-sol2-tdep.c: Sort headers.
9111         * amd64-obsd-tdep.c: Sort headers.
9112         * amd64-obsd-nat.c: Sort headers.
9113         * amd64-nbsd-tdep.c: Sort headers.
9114         * amd64-nbsd-nat.c: Sort headers.
9115         * amd64-nat.c: Sort headers.
9116         * amd64-linux-tdep.c: Sort headers.
9117         * amd64-linux-nat.c: Sort headers.
9118         * amd64-fbsd-tdep.c: Sort headers.
9119         * amd64-fbsd-nat.c: Sort headers.
9120         * amd64-dicos-tdep.c: Sort headers.
9121         * amd64-darwin-tdep.c: Sort headers.
9122         * amd64-bsd-nat.c: Sort headers.
9123         * alpha-tdep.c: Sort headers.
9124         * alpha-obsd-tdep.c: Sort headers.
9125         * alpha-nbsd-tdep.c: Sort headers.
9126         * alpha-mdebug-tdep.c: Sort headers.
9127         * alpha-linux-tdep.c: Sort headers.
9128         * alpha-linux-nat.c: Sort headers.
9129         * alpha-bsd-tdep.c: Sort headers.
9130         * alpha-bsd-nat.c: Sort headers.
9131         * aix-thread.c: Sort headers.
9132         * agent.c: Sort headers.
9133         * addrmap.c: Sort headers.
9134         * ada-varobj.c: Sort headers.
9135         * ada-valprint.c: Sort headers.
9136         * ada-typeprint.c: Sort headers.
9137         * ada-tasks.c: Sort headers.
9138         * ada-lang.c: Sort headers.
9139         * aarch64-tdep.c: Sort headers.
9140         * aarch64-ravenscar-thread.c: Sort headers.
9141         * aarch64-newlib-tdep.c: Sort headers.
9142         * aarch64-linux-tdep.c: Sort headers.
9143         * aarch64-linux-nat.c: Sort headers.
9144         * aarch64-fbsd-tdep.c: Sort headers.
9145         * aarch64-fbsd-nat.c: Sort headers.
9146         * aarch32-linux-nat.c: Sort headers.
9147
9148 2019-04-04  Tom Tromey  <tom@tromey.com>
9149
9150         * varobj.c (varobj_create): Update.
9151         * rust-exp.y (struct rust_parser) <update_innermost_block,
9152         lookup_symbol>: New methods.
9153         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9154         Rename.
9155         (rust_parser::rust_lookup_type)
9156         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9157         * printcmd.c (display_command, do_one_display): Update.
9158         * parser-defs.h (struct parser_state) <parser_state>: Add
9159         "tracker" parameter.
9160         (block_tracker): New member.
9161         (class innermost_block_tracker) <innermost_block_tracker>: Add
9162         "types" parameter.
9163         <reset>: Remove method.
9164         (innermost_block): Don't declare.
9165         (null_post_parser): Update.
9166         * parse.c (innermost_block): Remove global.
9167         (write_dollar_variable): Update.
9168         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9169         Remove "tracker_types" parameter.
9170         (parse_expression): Add "tracker" parameter.
9171         (parse_expression_for_completion): Update.
9172         (null_post_parser): Add "tracker" parameter.
9173         * p-exp.y: Update rules.
9174         * m2-exp.y: Update rules.
9175         * language.h (struct language_defn) <la_post_parser>: Add
9176         "tracker" parameter.
9177         * go-exp.y: Update rules.
9178         * f-exp.y: Update rules.
9179         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9180         parameter.
9181         * d-exp.y: Update rules.
9182         * c-exp.y: Update rules.
9183         * breakpoint.c (set_breakpoint_condition): Create an
9184         innermost_block_tracker.
9185         (watch_command_1): Likewise.
9186         * ada-lang.c (resolve): Add "tracker" parameter.
9187         (resolve_subexp): Likewise.
9188         * ada-exp.y (write_var_from_sym): Update.
9189
9190 2019-04-04  Tom Tromey  <tom@tromey.com>
9191
9192         * type-stack.h: New file.
9193         * type-stack.c: New file.
9194         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9195         type-stack.h.
9196         (insert_into_type_stack, insert_type, push_type, push_type_int)
9197         (insert_type_address_space, pop_type, pop_type_int)
9198         (pop_typelist, pop_type_stack, append_type_stack)
9199         (push_type_stack, get_type_stack, push_typelist)
9200         (follow_type_instance_flags, follow_types): Don't declare.
9201         * parse.c (type_stack): Remove global.
9202         (parse_exp_in_context): Update.
9203         (insert_into_type_stack, insert_type, push_type, push_type_int)
9204         (insert_type_address_space, pop_type, pop_type_int)
9205         (pop_typelist, pop_type_stack, append_type_stack)
9206         (push_type_stack, get_type_stack, push_typelist)
9207         (follow_type_instance_flags, follow_types): Remove (moved to
9208         type-stack.c).
9209         * f-exp.y (type_stack): New global.
9210         Update rules.
9211         (push_kind_type, f_parse): Update.
9212         * d-exp.y (type_stack): New global.
9213         Update rules.
9214         (d_parse): Update.
9215         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9216         Update rules.
9217         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9218         (HFILES_NO_SRCDIR): Add type-stack.h.
9219
9220 2019-04-04  Tom Tromey  <tom@tromey.com>
9221
9222         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9223         (rust_parser::convert_ast_to_expression, rust_parse)
9224         (rust_lex_test_completion, rust_lex_tests): Update.
9225         * parser-defs.h (struct expr_completion_state): New.
9226         (struct parser_state) <parser_state>: Add completion parameter.
9227         <mark_struct_expression, mark_completion_tag>: New methods.
9228         <parse_completion, m_completion_state>: New members.
9229         (prefixify_expression, null_post_parser): Update.
9230         (mark_struct_expression, mark_completion_tag): Don't declare.
9231         * parse.c (parse_completion, expout_last_struct)
9232         (expout_tag_completion_type, expout_completion_name): Remove
9233         globals.
9234         (parser_state::mark_struct_expression)
9235         (parser_state::mark_completion_tag): Now methods.
9236         (prefixify_expression): Add last_struct parameter.
9237         (prefixify_subexp): Likewise.
9238         (parse_exp_1): Update.
9239         (parse_exp_in_context): Add cstate parameter.  Update.
9240         (parse_expression_for_completion): Create an
9241         expr_completion_state.
9242         (null_post_parser): Add "completion" parameter.
9243         * p-exp.y: Update rules.
9244         (yylex): Update.
9245         * language.h (struct language_defn) <la_post_parser>: Add
9246         "completing" parameter.
9247         * go-exp.y: Update rules.
9248         (lex_one_token): Update.
9249         * expression.h (parse_completion): Don't declare.
9250         * d-exp.y: Update rules.
9251         (lex_one_token): Update rules.
9252         * c-exp.y: Update rules.
9253         (lex_one_token): Update.
9254         * ada-lang.c (resolve): Add "parse_completion" parameter.
9255         (resolve_subexp): Likewise.
9256         (ada_resolve_function): Likewise.
9257
9258 2019-04-04  Tom Tromey  <tom@tromey.com>
9259
9260         * parser-defs.h (struct parser_state) <start_arglist,
9261         end_arglist>: New methods.
9262         <arglist_len, m_funcall_chain>: New members.
9263         (arglist_len, start_arglist, end_arglist): Don't declare.
9264         * parse.c (arglist_len, funcall_chain): Remove global.
9265         (start_arglist, end_arglist): Remove functions.
9266         (parse_exp_in_context): Update.
9267         * p-exp.y: Update rules.
9268         * m2-exp.y: Update rules.
9269         * go-exp.y: Update rules.
9270         * f-exp.y: Update rules.
9271         * d-exp.y: Update rules.
9272         * c-exp.y: Update rules.
9273
9274 2019-04-04  Tom Tromey  <tom@tromey.com>
9275
9276         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9277         lex_operator, push_back>: New methods.
9278         Update all rules.
9279         (rust_parser::lex_hex, lex_escape): Rename and update.
9280         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9281         (rust_parser::lex_operator): Rename and update.
9282         (rust_parser::lex_number, rustyylex, rustyyerror)
9283         (rust_lex_test_init, rust_lex_test_sequence)
9284         (rust_lex_test_push_back, rust_lex_tests): Update.
9285         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9286         parameter.
9287         <lexptr, prev_lexptr>: New members.
9288         (lexptr, prev_lexptr): Don't declare.
9289         * parse.c (lexptr, prev_lexptr): Remove globals.
9290         (parse_exp_in_context): Update.
9291         * p-exp.y (yylex, yyerror): Update.
9292         * m2-exp.y (parse_number, yylex, yyerror): Update.
9293         * go-exp.y (lex_one_token, yyerror): Update.
9294         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9295         * d-exp.y (lex_one_token, yyerror): Update.
9296         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9297         (lex_one_token, yyerror): Update.
9298         * ada-lex.l (YY_INPUT): Update.
9299         (rewind_to_char): Update.
9300         * ada-exp.y (yyerror): Update.
9301
9302 2019-04-04  Tom Tromey  <tom@tromey.com>
9303
9304         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9305         * parser-defs.h (struct parser_state) <parser_state>: Add new
9306         parameter.
9307         <comma_terminates>: New member.
9308         (comma_terminates): Don't declare global.
9309         * parse.c (comma_terminates): Remove global.
9310         (parse_exp_in_context): Update.
9311         * p-exp.y (yylex): Update.
9312         * m2-exp.y (yylex): Update.
9313         * go-exp.y (lex_one_token): Update.
9314         * f-exp.y (yylex): Update.
9315         * d-exp.y (lex_one_token): Update.
9316         * c-exp.y (lex_one_token): Update.
9317         * ada-lex.l: Update.
9318
9319 2019-04-04  Tom Tromey  <tom@tromey.com>
9320
9321         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9322         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9323         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9324         * parser-defs.h (paren_depth): Don't declare.
9325         * parse.c (paren_depth): Remove global.
9326         (parse_exp_in_context): Update.
9327         * p-exp.y (paren_depth): New global.
9328         (pascal_parse): Initialize it.
9329         * m2-exp.y (paren_depth): New global.
9330         (m2_parse): Initialize it.
9331         * go-exp.y (paren_depth): New global.
9332         (go_parse): Initialize it.
9333         * f-exp.y (paren_depth): New global.
9334         (f_parse): Initialize it.
9335         * d-exp.y (paren_depth): New global.
9336         (d_parse): Initialize it.
9337         * c-exp.y (paren_depth): New global.
9338         (c_parse): Initialize it.
9339         * ada-lex.l (paren_depth): New global.
9340         (lexer_init): Initialize it.
9341
9342 2019-04-04  Tom Tromey  <tom@tromey.com>
9343
9344         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9345         (rust_parser::convert_ast_to_type)
9346         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9347         * parser-defs.h (struct parser_state) <parser_state>: Add
9348         parameters.  Initialize new members.
9349         <expression_context_block, expression_context_pc>: New members.
9350         * parse.c (expression_context_block, expression_context_pc):
9351         Remove globals.
9352         (parse_exp_in_context): Update.
9353         * p-exp.y: Update all rules.
9354         (yylex): Update.
9355         * m2-exp.y: Update all rules.
9356         (yylex): Update.
9357         * go-exp.y (yylex): Update.
9358         * f-exp.y (yylex): Update.
9359         * d-exp.y: Update all rules.
9360         (yylex): Update.
9361         * c-exp.y: Update all rules.
9362         (lex_one_token, classify_name, yylex, c_parse): Update.
9363         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9364
9365 2019-04-04  Tom Tromey  <tom@tromey.com>
9366
9367         * gdbarch.h, gdbarch.c: Rebuild.
9368         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9369         * stap-probe.h:
9370         (struct stap_parse_info): Replace "parser_state" with
9371         "expr_builder".
9372         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9373         (parser_state): New class.
9374         * parse.c (expr_builder): Rename.
9375         (expr_builder::release): Rename.
9376         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9377         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9378         (write_exp_elt_longcst, write_exp_elt_floatcst)
9379         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9380         (write_exp_string_vector, write_exp_bitstring)
9381         (write_exp_msymbol, mark_struct_expression)
9382         (write_dollar_variable)
9383         (insert_type_address_space, increase_expout_size): Replace
9384         "parser_state" with "expr_builder".
9385         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9386         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9387         "parser_state" with "expr_builder".
9388
9389 2019-04-04  Tom Tromey  <tom@tromey.com>
9390
9391         * rust-exp.y: Replace "parse_language" with method call.
9392         * p-exp.y:
9393         (yylex): Replace "parse_language" with method call.
9394         * m2-exp.y:
9395         (yylex): Replace "parse_language" with method call.
9396         * go-exp.y (classify_name): Replace "parse_language" with method
9397         call.
9398         * f-exp.y (yylex): Replace "parse_language" with method call.
9399         * d-exp.y (lex_one_token): Replace "parse_language" with method
9400         call.
9401         * c-exp.y:
9402         (lex_one_token, classify_name, yylex): Replace "parse_language"
9403         with method call.
9404         * ada-exp.y (find_primitive_type, type_char)
9405         (type_system_address): Replace "parse_language" with method call.
9406
9407 2019-04-04  Tom Tromey  <tom@tromey.com>
9408
9409         * rust-exp.y: Replace "parse_gdbarch" with method call.
9410         * parse.c (write_dollar_variable, insert_type_address_space):
9411         Replace "parse_gdbarch" with method call.
9412         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9413         call.
9414         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9415         call.
9416         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9417         "parse_gdbarch" with method call.
9418         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9419         with method call.
9420         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9421         "parse_gdbarch" with method call.
9422         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9423         "parse_gdbarch" with method call.
9424         * c-exp.y (parse_type, parse_number, classify_name): Replace
9425         "parse_gdbarch" with method call.
9426         * ada-lex.l: Replace "parse_gdbarch" with method call.
9427         * ada-exp.y (parse_type, find_primitive_type, type_char)
9428         (type_system_address): Replace "parse_gdbarch" with method call.
9429
9430 2019-04-04  Tom Tromey  <tom@tromey.com>
9431
9432         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9433         * stap-probe.c (stap_parse_argument): Update.
9434         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9435         initial_size parameter.
9436         * rust-exp.y (rust_lex_tests): Update.
9437         * parse.c (parser_state): Update.
9438         (parse_exp_in_context): Update.
9439         * parser-defs.h (struct parser_state) <parser_state>: Remove
9440         "initial_size" parameter.
9441
9442 2019-04-04  Tom Tromey  <tom@tromey.com>
9443
9444         * parser-defs.h (increase_expout_size): Don't declare.
9445         * parse.c (increase_expout_size): Now static.
9446
9447 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9448
9449         * gnu-nat.c (gnu_nat_target::wait): Fix
9450         target_waitstatus_to_string call.
9451
9452 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9453
9454         * eval.c (evaluate_subexp_standard): Handle internal functions
9455         during Fortran function call handling.
9456
9457 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9458
9459         * NEWS: Mention new internal functions.
9460         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9461         (read_base_type): Use dwarf2_init_complex_target_type.
9462         * value.c (creal_internal_fn): New function.
9463         (cimag_internal_fn): New function.
9464         (_initialize_values): Register new internal functions.
9465
9466 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9467
9468         * infrun.c (stop_all_threads): If debug_infrun, always
9469         trace the wait status after wait_one, using
9470         target_waitstatus_to_string and target_pid_to_str.
9471         (handle_inferior_event): Replace various trace of
9472         wait status kind by a single trace.
9473         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9474         wait status kind image by target_waitstatus_to_string.
9475         * target/waitstatus.c (target_waitstatus_to_string): Fix
9476         obsolete comment.
9477
9478 2019-04-01  Tom Tromey  <tromey@adacore.com>
9479
9480         PR symtab/23331:
9481         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9482
9483 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9484             Pedro Alves  <palves@redhat.com>
9485
9486         * top.c (quit_force): Call 'finalize_values'.
9487         * value.c (finalize_values): New function.
9488         * value.h (finalize_values): Declare.
9489
9490 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9491
9492         * NEWS: Announce $_gdb_major and $_gdb_minor.
9493
9494         * top.c (init_gdb_version_vars): New function.
9495         (gdb_init): Call init_gdb_version_vars.
9496
9497 2019-03-29  Tom Tromey  <tromey@adacore.com>
9498
9499         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9500         help text.  Remove dead code.
9501
9502 2019-03-29  Keith Seitz  <keiths@redhat.com>
9503
9504         From Siddhesh Poyarekar:
9505         * f-lang.h (f77_get_upperbound): Return LONGEST.
9506         (f77_get_lowerbound): Likewise.
9507         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9508         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9509         print them.
9510         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9511         plongest to format print it.
9512         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9513         (f77_get_upperbound): Likewise.
9514         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9515         LOWER_BOUND to LONGEST.
9516         (f77_create_arrayprint_offset_tbl): Likewise.
9517
9518 2019-03-29  Keith Seitz  <keiths@redhat.com>
9519
9520         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9521         %s/pulongest for TYPE_LENGTH instead of %d in format
9522         strings.
9523         * ada-typerint.c (ada_print_type): Likewise.
9524         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9525         * compile/compile-c-support.c (generate_register_struct): Likewise.
9526         * gdbtypes.c (recursive_dump_type): Likewise.
9527         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9528         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9529         instead of %d in format strings.
9530         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9531         to std::min to ULONGEST.
9532         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9533         instead of %d in format strings.
9534         * tracepoint.c (info_scope_command): Likewise.
9535         * typeprint.c (print_offset_data::update)
9536         (print_offset_data::finish): Likewise.
9537         * xtensa-tdep.c (xtensa_store_return_value)
9538         (xtensa_push_dummy_call): Likewise.
9539
9540 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9541
9542         * windows-nat.c (display_selector): Fixed format specifications
9543         for 64-bit Cygwin.
9544
9545 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9546
9547         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9548
9549 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9550
9551         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9552         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9553         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9554         (nios2_linux_init_abi): Install it.
9555
9556 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9557
9558         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9559
9560 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9561
9562         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9563
9564 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9565             Tom Tromey  <tromey@adacore.com>
9566
9567         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9568
9569 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9570
9571         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9572         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9573         method to compute the bounds of range types. Also print "[evaluated]"
9574         if the bounds' values come from a dynamic evaluation.
9575
9576 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9577
9578         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9579         whitespace when pretty printing is on.
9580
9581 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9582
9583         * ppc-linux-nat.c: Add include.
9584
9585 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9586
9587         * NEWS: Mention AArch64 Pointer Authentication.
9588
9589 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9590
9591         * arm-linux-nat.c: Add include.
9592
9593 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9594
9595         * source-cache.c (source_cache::get_source_lines): Re-read
9596         fullname after calling open_source_file.
9597
9598 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9599
9600         * NEWS: Mention TLS support for FreeBSD.
9601
9602 2019-03-25  Tom Tromey  <tromey@adacore.com>
9603
9604         * minsyms.c (BUNCH_SIZE): Update comment.
9605         (~minimal_symbol_reader): Remove old comment.
9606         (compact_minimal_symbols): Update comment.
9607         (minimal_symbol_reader::install): Remove old comment.  Update
9608         other comments.
9609
9610 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9611
9612         * s390-linux-nat.c: Add include.
9613
9614 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9615
9616         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9617         Call linux_get_hwcap.
9618         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9619         Likewise.
9620         (aarch64_linux_get_hwcap): Remove function.
9621         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9622         declaration.
9623         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9624         linux_get_hwcap.
9625         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9626         * linux-tdep.c (linux_get_hwcap): Add function.
9627         (linux_get_hwcap2): Likewise.
9628         * linux-tdep.h (linux_get_hwcap): Add declaration.
9629         (linux_get_hwcap2): Likewise.
9630         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9631         (ppc_linux_get_hwcap2): Likewise.
9632         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9633         linux_get_hwcap.
9634         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9635         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9636         (ppc_linux_nat_target::read_description): Likewise.
9637         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9638         * s390-linux-nat.c: Likewise.
9639         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9640
9641 2019-03-24  Tom Tromey  <tom@tromey.com>
9642
9643         * ada-lang.c (standard_lookup): Simplify initialization.
9644         (ada_lookup_symbol_nonlocal): Simplify return.
9645         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9646         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9647         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9648         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9649         initialization.
9650         * solib.c (solib_global_lookup): Simplify.
9651         * symtab.c (null_block_symbol): Remove.
9652         (symbol_cache_lookup): Simplify returns.
9653         (lookup_language_this): Simplify returns.
9654         (lookup_symbol_aux): Simplify return.
9655         (lookup_local_symbol): Simplify returns.
9656         (lookup_global_symbol_from_objfile): Simplify return.
9657         (lookup_symbol_in_objfile_symtabs)
9658         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9659         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9660         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9661         * cp-namespace.c (cp_lookup_bare_symbol)
9662         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9663         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9664         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9665         (cp_lookup_symbol_via_imports): Simplify initialization.
9666         (find_symbol_in_baseclass): Likewise.
9667         * symtab.h (null_block_symbol): Remove.
9668         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9669         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9670         (d_lookup_symbol_module): Likewise.
9671         (find_symbol_in_baseclass): Simplify initialization.
9672
9673 2019-03-24  Tom Tromey  <tom@tromey.com>
9674
9675         * expression.h: Don't include symtab.h.
9676         (struct block): Forward declare.
9677
9678 2019-03-24  Tom Tromey  <tom@tromey.com>
9679
9680         * c-exp.y (typebase): Remove casts.
9681         * gdbtypes.c (lookup_unsigned_typename, )
9682         (lookup_signed_typename): Remove cast.
9683         * eval.c (parse_to_comma_and_eval): Remove cast.
9684         * parse.c (write_dollar_variable): Remove cast.
9685         * block.h (struct block) <superblock>: Now const.
9686         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9687         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9688         (map_block): Make "block" const.
9689         * symfile.h (struct quick_symbol_functions)
9690         <map_matching_symbols>: Constify block argument to "callback".
9691         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9692         const.
9693         (find_pc_sect_compunit_symtab): Make "b" const.
9694         (find_symbol_at_address): Likewise.
9695         (search_symbols): Likewise.
9696         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9697         (dw2_debug_names_lookup_symbol): Likewise.
9698         (dw2_map_matching_symbols): Update.
9699         * p-valprint.c (pascal_val_print): Remove "block".
9700         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9701         (aux_add_nonlocal_symbols): Make "block" const.
9702         (resolve_subexp): Remove cast.
9703         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9704         const.
9705         (iterate_over_file_blocks): Likewise.
9706         * f-exp.y (%union) <bval>: Remove.
9707         * coffread.c (patch_opaque_types): Make "b" const.
9708         * spu-tdep.c (spu_catch_start): Make "block" const.
9709         * c-valprint.c (print_unpacked_pointer): Remove "block".
9710         * symmisc.c (dump_symtab_1): Make "b" const.
9711         (block_depth): Make "block" const.
9712         * d-exp.y (%union) <bval>: Remove.
9713         * cp-support.h (cp_lookup_rtti_type): Update.
9714         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9715         * psymtab.c (psym_lookup_symbol): Make "block" const.
9716         (maintenance_check_psymtabs): Make "b" const.
9717         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9718         (enumerate_locals, enumerate_args): Update.
9719         * python/py-symtab.c (stpy_global_block): Make "block" const.
9720         (stpy_static_block): Likewise.
9721         * inline-frame.c (block_starting_point_at): Make "new_block"
9722         const.
9723         * block.c (find_block_in_blockvector): Make return type const.
9724         (blockvector_for_pc_sect): Make "b" const.
9725         (find_block_in_blockvector): Make "b" const.
9726
9727 2019-03-23  Tom Tromey  <tom@tromey.com>
9728
9729         * varobj.c (varobj_create): Update.
9730         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9731         * printcmd.c (display_command, do_one_display): Don't reset
9732         innermost_block.
9733         * parser-defs.h (enum innermost_block_tracker_type): Move to
9734         expression.h.
9735         (innermost_block): Update comment.
9736         * parse.c (parse_exp_1): Add tracker_types parameter.
9737         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9738         tracker_types parameter.  Reset innermost_block.
9739         (parse_exp_in_context): Remove.
9740         (parse_expression_for_completion): Update.
9741         * objfiles.c (~objfile): Don't reset expression_context_block or
9742         innermost_block.
9743         * expression.h (enum innermost_block_tracker_type): Move from
9744         parser-defs.h.
9745         (parse_exp_1): Add tracker_types parameter.
9746         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9747         reset innermost_block.
9748
9749 2019-03-23  Tom Tromey  <tom@tromey.com>
9750
9751         * objfiles.h: Include bcache.h.
9752
9753 2019-03-23  Tom Tromey  <tom@tromey.com>
9754
9755         * linespec.c (get_current_search_block): Use
9756         scoped_restore_current_language.
9757         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9758
9759 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9760             Jiong Wang  <jiong.wang@arm.com>
9761
9762         * aarch64-linux-tdep.c
9763         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9764         section.
9765         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9766
9767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9768             Jiong Wang  <jiong.wang@arm.com>
9769
9770         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9771         instructions.
9772         (aarch64_analyze_prologue_test): Add PACIASP test.
9773         (aarch64_prologue_prev_register): Unmask PC value.
9774
9775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9776             Jiong Wang  <jiong.wang@arm.com>
9777
9778         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9779         (aarch64_dwarf2_prev_register): Unmask PC value.
9780         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9781         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9782         DW_CFA_AARCH64_negate_ra_state.
9783         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9784
9785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9786             Jiong Wang  <jiong.wang@arm.com>
9787
9788         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9789         registers.
9790         (aarch64_pseudo_register_name): Likewise.
9791         (aarch64_pseudo_register_type): Likewise.
9792         (aarch64_pseudo_register_reggroup_p): Likewise.
9793         (aarch64_gdbarch_init): Add pauth registers.
9794         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9795         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9796         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9797         (struct gdbarch_tdep): Add regnum for ra_state.
9798
9799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9800             Jiong Wang  <jiong.wang@arm.com>
9801
9802         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9803
9804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9805             Jiong Wang  <jiong.wang@arm.com>
9806
9807         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9808         function.
9809         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9810         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9811         (aarch64_gdbarch_init): Add puth registers.
9812         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9813         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9814         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9815
9816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9817             Jiong Wang  <jiong.wang@arm.com>
9818
9819         * aarch64-linux-nat.c
9820         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9821         * aarch64-linux-tdep.c
9822         (aarch64_linux_core_read_description): Likewise.
9823         (aarch64_linux_get_hwcap): New function.
9824         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9825         (aarch64_linux_get_hwcap): New declaration.
9826
9827 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9828             Jiong Wang  <jiong.wang@arm.com>
9829
9830         * aarch64-linux-nat.c
9831         (aarch64_linux_nat_target::read_description): Add pauth param.
9832         * aarch64-linux-tdep.c
9833         (aarch64_linux_core_read_description): Likewise.
9834         * aarch64-tdep.c (struct target_desc): Add in pauth.
9835         (aarch64_read_description): Add pauth param.
9836         (aarch64_gdbarch_init): Likewise.
9837         * aarch64-tdep.h (aarch64_read_description): Likewise.
9838         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9839         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9840         * features/Makefile: Add new files.
9841         * features/aarch64-pauth.c: New file.
9842         * features/aarch64-pauth.xml: New file.
9843
9844 2019-03-20  Tom Tromey  <tromey@adacore.com>
9845
9846         * infrun.c (handle_inferior_event): Rename from
9847         handle_inferior_event_1.  Create a scoped_value_mark.
9848         (handle_inferior_event): Remove.
9849
9850 2019-03-19  Tom Tromey  <tromey@adacore.com>
9851
9852         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9853         * infrun.h (print_stop_event): Add "displays" parameter.
9854         * infrun.c (print_stop_event): Add "displays" parameter.
9855
9856 2019-03-19  Pedro Alves  <palves@redhat.com>
9857
9858         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9859         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9860         to -1.  Fix TABs vs spaces.
9861         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9862         * tui/tui-out.h (tui_ui_out) Add intro comments.
9863         <m_line, m_start_of_line>: In-class initialize, and add describing
9864         comment.
9865
9866 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9867
9868         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9869         variable names.
9870         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9871
9872 2019-03-18  Pedro Alves  <palves@redhat.com>
9873             Eli Zaretskii <eliz@gnu.org>
9874
9875         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9876         m_line and m_start_of_line.
9877
9878 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9879
9880         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9881         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9882         it returns a newline.  This fixes a regression in TU mode, whereby
9883         the next line is output on the same screen line as the user input.
9884
9885 2019-03-18  Tom Tromey  <tromey@adacore.com>
9886
9887         * minsyms.c (minimal_symbol_reader::install): Remove call to
9888         obstack_blank.
9889
9890 2019-03-18  Pedro Alves  <palves@redhat.com>
9891
9892         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9893         New globals.
9894         (apply_style): New, factored out from ...
9895         (apply_ansi_escape): ... this.  Handle reverse video mode.
9896         (tui_set_reverse_mode): New function.
9897         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9898         * tui/tui-winsource.c (tui_show_source_line): Use
9899         tui_set_reverse_mode instead of setting A_STANDOUT.
9900         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9901         New setter methods.
9902
9903 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9904
9905         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9906         Handle tabs.
9907
9908 2019-03-18  Tom Tromey  <tromey@adacore.com>
9909
9910         * ada-lang.c (empty_array): Add "high" parameter.
9911         (ada_evaluate_subexp): Update.
9912
9913 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9914
9915         * unittests/string_view-selftests.c: Define
9916         _initialize_string_view_selftests unconditionally.
9917
9918 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9919
9920         PR gdb/24350
9921         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9922
9923 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9924
9925         PR gdb/24351
9926         * windows-nat.c (display_selector): Fix format specifiers.
9927
9928 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9929
9930         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9931         tui_refill_source_window instead of tui_refresh_win, to update the
9932         current execution line.  This fixes redisplay of the current line
9933         when stepping through the code with "next" or "step".
9934
9935 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9936
9937         * source-cache.c (source_cache::get_source_lines): Call
9938         find_source_lines to initialize s->nlines.  This fixes vertical
9939         scrolling of TUI source window when the DOWN arrow is pressed.
9940
9941 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9942
9943         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9944         linux-thread-db.c (_initialize_thread_db): Likewise.
9945
9946 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9947
9948         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9949         wclrtoeol in tui_show_source_line".  This reverts changes made in
9950         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9951
9952 2019-03-15  Tom Tromey  <tom@tromey.com>
9953
9954         * symtab.h (struct minimal_symbol): Derive from
9955         general_symbol_info.
9956         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9957         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9958         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9959         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9960         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9961         (MSYMBOL_SEARCH_NAME): Update.
9962         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9963         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9964         * minsyms.c (minimal_symbol_reader::record_full): Update.
9965
9966 2019-03-15  Tom Tromey  <tom@tromey.com>
9967
9968         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9969
9970 2019-03-15  Tom Tromey  <tom@tromey.com>
9971
9972         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9973         unique_xmalloc_ptr.
9974         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9975         Update.
9976         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9977         (build_minimal_symbol_hash_tables)
9978         (minimal_symbol_reader::install): Update.
9979
9980 2019-03-15  Tom Tromey  <tom@tromey.com>
9981
9982         * symtab.c (create_demangled_names_hash): Update.
9983         (symbol_set_names): Update.
9984         * objfiles.h (struct objfile_per_bfd_storage)
9985         <demangled_names_hash>: Now an htab_up.
9986         * objfiles.c (objfile_per_bfd_storage): Simplify.
9987
9988 2019-03-15  Tom Tromey  <tom@tromey.com>
9989
9990         * objfiles.h (struct objfile_per_bfd_storage): Declare
9991         destructor.
9992         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9993         New.
9994         (get_objfile_bfd_data): Use new.  Don't initialize
9995         language_of_main.
9996         (free_objfile_per_bfd_storage): Remove.
9997         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9998
9999 2019-03-15  Tom Tromey  <tom@tromey.com>
10000
10001         * symfile.c (reread_symbols): Update.
10002         * objfiles.c (objfile::objfile): Update.
10003         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10004         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10005         comment.
10006         (minimal_symbol_reader::install): Update.
10007         (terminate_minimal_symbol_table): Remove.
10008         * jit.c (jit_object_close_impl): Update.
10009
10010 2019-03-15  Tom Tromey  <tom@tromey.com>
10011
10012         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10013         initializations.
10014
10015 2019-03-15  Tom Tromey  <tom@tromey.com>
10016
10017         * objfiles.h (struct objfile_per_bfd_storage)
10018         <demangled_hash_languages>: Now a bitset.
10019         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10020         (lookup_minimal_symbol): Update.
10021
10022 2019-03-15  Tom Tromey  <tom@tromey.com>
10023
10024         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10025         Don't return the symbol.
10026         * coffread.c (record_minimal_symbol): Use record_full.
10027
10028 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10029
10030         The MS-Windows port of ncurses fails to switch to a color pair if
10031         one or both of the colors are the implicit default colors.  This
10032         change records the default colors when TUI is initialized, and
10033         then specifies them explicitly when a color pair uses the default
10034         colors.  This allows color styling in TUI mode on MS-Windows.
10035
10036         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10037         ncurses_norm_attr.
10038         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10039         colors in ncurses_norm_attr.
10040         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10041         "none", replace it with the default color recorded in
10042         ncurses_norm_attr.
10043
10044 2019-03-14  Tom Tromey  <tromey@adacore.com>
10045
10046         * source-cache.h (class source_cache) <get_source_lines>: Return
10047         std::string.
10048         * source-cache.c (source_cache::extract_lines): Handle case where
10049         first_pos==npos.  Return std::string.
10050         (source_cache::get_source_lines): Update.
10051
10052 2019-03-14  Tom Tromey  <tromey@adacore.com>
10053
10054         * NEWS: Add item for "style sources" commands.
10055         * source-cache.c (source_cache::get_source_lines): Check
10056         source_styling.
10057         * cli/cli-style.c (source_styling): New global.
10058         (_initialize_cli_style): Add "style sources" commands.
10059         (show_style_sources): New function.
10060         * cli/cli-style.h (source_styling): Declare.
10061
10062 2019-03-14  Pedro Alves  <palves@redhat.com>
10063             Tom Tromey  <tromey@adacore.com>
10064
10065         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10066         * tui/tui-winsource.c (tui_refill_source_window): New function,
10067         from...
10068         (tui_horizontal_source_scroll): ... here.  Move some logic.
10069         * cli/cli-style.c (set_style_enabled): Notify new observable.
10070         * tui/tui-hooks.c (tui_redisplay_source): New function.
10071         (tui_attach_detach_observers): Attach or detach
10072         tui_redisplay_source.
10073         * observable.h (source_styling_changed): New observable.
10074         * observable.c: Define source_styling_changed observable.
10075
10076 2019-03-13  Tom Tromey  <tromey@adacore.com>
10077
10078         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10079         (i386_gnu_nat_target::store_registers): Update.
10080         * target-debug.h (target_debug_print_std_string): New macro.
10081         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10082         * windows-tdep.c (display_one_tib): Update.
10083         * tui/tui-stack.c (tui_make_status_line): Update.
10084         * top.c (print_inferior_quit_action): Update.
10085         * thread.c (thr_try_catch_cmd): Update.
10086         (add_thread_with_info): Update.
10087         (thread_target_id_str): Update.
10088         (thr_try_catch_cmd): Update.
10089         (thread_command): Update.
10090         (thread_find_command): Update.
10091         * record-btrace.c (record_btrace_target::info_record)
10092         (record_btrace_resume_thread, record_btrace_target::resume)
10093         (record_btrace_cancel_resume, record_btrace_step_thread)
10094         (record_btrace_target::wait, record_btrace_target::wait)
10095         (record_btrace_target::wait, record_btrace_target::stop): Update.
10096         * progspace.c (print_program_space): Update.
10097         * process-stratum-target.c
10098         (process_stratum_target::thread_address_space): Update.
10099         * linux-fork.c (linux_fork_mourn_inferior)
10100         (detach_checkpoint_command, info_checkpoints_command)
10101         (linux_fork_context): Update.
10102         (linux_fork_detach): Update.
10103         (class scoped_switch_fork_info): Update.
10104         (delete_checkpoint_command): Update.
10105         * infrun.c (follow_fork_inferior): Update.
10106         (follow_fork_inferior): Update.
10107         (proceed_after_vfork_done): Update.
10108         (handle_vfork_child_exec_or_exit): Update.
10109         (follow_exec): Update.
10110         (displaced_step_prepare_throw): Update.
10111         (displaced_step_restore): Update.
10112         (start_step_over): Update.
10113         (resume_1): Update.
10114         (clear_proceed_status_thread): Update.
10115         (proceed): Update.
10116         (print_target_wait_results): Update.
10117         (do_target_wait): Update.
10118         (context_switch): Update.
10119         (stop_all_threads): Update.
10120         (restart_threads): Update.
10121         (finish_step_over): Update.
10122         (handle_signal_stop): Update.
10123         (switch_back_to_stepped_thread): Update.
10124         (keep_going_pass_signal): Update.
10125         (print_exited_reason): Update.
10126         (normal_stop): Update.
10127         * inferior.c (inferior_pid_to_str): Change return type.
10128         (print_selected_inferior): Update.
10129         (add_inferior): Update.
10130         (detach_inferior): Update.
10131         * dummy-frame.c (fprint_dummy_frames): Update.
10132         * dcache.c (dcache_info_1): Update.
10133         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10134         (btrace_fetch, btrace_clear): Update.
10135         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10136         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10137         type.
10138         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10139         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10140         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10141         * gdbarch.c, gdbarch.h: Rebuild.
10142         * gdbarch.sh (core_pid_to_str): Change return type.
10143         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10144         return type.
10145         (windows_nat_target::pid_to_str): Change return type.
10146         (windows_delete_thread): Update.
10147         (windows_nat_target::attach): Update.
10148         (windows_nat_target::files_info): Update.
10149         * target-delegates.c: Rebuild.
10150         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10151         return type.
10152         (sol_thread_target::pid_to_str): Change return type.
10153         * remote.c (class remote_target) <pid_to_str>: Change return
10154         type.
10155         (remote_target::pid_to_str): Change return type.
10156         (extended_remote_target::attach, remote_target::remote_stop_ns)
10157         (remote_target::remote_notif_remove_queued_reply)
10158         (remote_target::push_stop_reply, remote_target::disable_btrace):
10159         Update.
10160         (extended_remote_target::attach): Update.
10161         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10162         type.
10163         (gdbsim_target::pid_to_str): Change return type.
10164         * ravenscar-thread.c (struct ravenscar_thread_target)
10165         <pid_to_str>: Change return type.
10166         (ravenscar_thread_target::pid_to_str): Change return type.
10167         * procfs.c (class procfs_target) <pid_to_str>: Change return
10168         type.
10169         (procfs_target::pid_to_str): Change return type.
10170         (procfs_target::attach): Update.
10171         (procfs_target::detach): Update.
10172         (procfs_target::fetch_registers): Update.
10173         (procfs_target::store_registers): Update.
10174         (procfs_target::wait): Update.
10175         (procfs_target::files_info): Update.
10176         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10177         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10178         return type.
10179         (nto_procfs_target::pid_to_str): Change return type.
10180         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10181         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10182         return type.
10183         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10184         (exit_lwp): Update.
10185         (attach_proc_task_lwp_callback, get_detach_signal)
10186         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10187         (linux_nat_target::resume, wait_lwp, stop_callback)
10188         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10189         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10190         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10191         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10192         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10193         type.
10194         (inf_ptrace_target::attach): Update.
10195         (inf_ptrace_target::files_info): Update.
10196         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10197         type.
10198         (go32_nat_target::pid_to_str): Change return type.
10199         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10200         (gnu_nat_target::wait): Update.
10201         (gnu_nat_target::wait): Update.
10202         (gnu_nat_target::resume): Update.
10203         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10204         (fbsd_nat_target::wait): Update.
10205         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10206         type.
10207         (darwin_nat_target::attach): Update.
10208         * corelow.c (class core_target) <pid_to_str>: Change return type.
10209         (core_target::pid_to_str): Change return type.
10210         * target.c (normal_pid_to_str): Change return type.
10211         (default_pid_to_str): Likewise.
10212         (target_pid_to_str): Change return type.
10213         (target_translate_tls_address): Update.
10214         (target_announce_detach): Update.
10215         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10216         return type.
10217         (bsd_uthread_target::pid_to_str): Change return type.
10218         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10219         type.
10220         (bsd_kvm_target::pid_to_str): Change return type.
10221         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10222         return type.
10223         (aix_thread_target::pid_to_str): Change return type.
10224         * target.h (struct target_ops) <pid_to_str>: Change return type.
10225         (target_pid_to_str, normal_pid_to_str): Likewise.
10226         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10227         type.
10228         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10229         type.
10230         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10231         return type.
10232         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10233         type.
10234         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10235         type.
10236         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10237         return type.
10238
10239 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10240
10241         * NEWS: Mention that the new default MI version is 3.  Mention
10242         changes to the output of commands and events that deal with
10243         multi-location breakpoints.
10244         * breakpoint.c: Include "mi/mi-out.h".
10245         (print_one_breakpoint): Change output syntax if using MI version
10246         >= 3.
10247         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10248         New.
10249         (mi_multi_location_breakpoint_output_fixed): New.
10250         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10251         (mi_cmd_fix_multi_location_breakpoint_output): New.
10252         (mi_multi_location_breakpoint_output_fixed): New.
10253         * mi/mi-cmds.c (mi_cmds): Register command
10254         -fix-multi-location-breakpoint-output.
10255         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10256         interpreter "mi".
10257
10258 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10259
10260         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10261         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10262         instantiate mi_ui_out based on interpreter name.
10263         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10264         * mi/mi-main.c (mi_load_progress): Likewise.
10265
10266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10267
10268         * NEWS: Combine separate "New targets" sections for 8.3.
10269
10270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10271
10272         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10273         (ppcfbsd_init_abi): Install gdbarch
10274         "fetch_tls_load_module_address" and "get_thread_local_address"
10275         methods.
10276
10277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10278
10279         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10280         (riscv_fbsd_init_abi): Install gdbarch
10281         "fetch_tls_load_module_address" and "get_thread_local_address"
10282         methods.
10283
10284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10285
10286         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10287         (i386fbsd_init_abi): Install gdbarch
10288         "fetch_tls_load_module_address" and "get_thread_local_address"
10289         methods.
10290
10291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10292
10293         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10294         (amd64fbsd_init_abi): Install gdbarch
10295         "fetch_tls_load_module_address" and "get_thread_local_address"
10296         methods.
10297
10298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10299
10300         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10301         (struct fbsd_pspace_data): New type.
10302         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10303         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10304         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10305         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10306         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10307
10308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10309
10310         * gdbtypes.c (lookup_struct_elt): New function.
10311         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10312         * gdbtypes.h (struct struct_elt): New type.
10313         (lookup_struct_elt): New prototype.
10314
10315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10316
10317         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10318         remove disabled code block.
10319
10320 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10321
10322         * gdbarch.sh (get_thread_local_address): New method.
10323         * gdbarch.h, gdbarch.c: Regenerate.
10324         * target.c (target_translate_tls_address): Use
10325         gdbarch_get_thread_local_address if present instead of
10326         target::get_thread_local_address.
10327
10328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10329
10330         * target.h (target::get_thread_local_address): Update comment.
10331
10332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10333
10334         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10335         objfile->separate_debug_objfile_backlink if not NULL.
10336
10337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10338
10339         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10340         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10341         (amd64bsd_store_inferior_registers): Likewise.
10342         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10343         Enable segment base registers.
10344         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10345         PT_GETFSBASE and PT_GETGSBASE.
10346         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10347         PT_SETGSBASE.
10348         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10349         segment base registers.
10350         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10351
10352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10353
10354         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10355         Update calls to i386_target_description to add 'segments'
10356         parameter.
10357         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10358         add segment base registers.
10359         * arch/i386.c (i386_create_target_description): Add 'segments'
10360         parameter to enable segment base registers.
10361         * arch/i386.h (i386_create_target_description): Likewise.
10362         * features/i386/32bit-segments.xml: New file.
10363         * features/i386/32bit-segments.c: Generate.
10364         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10365         call to i386_target_description to add 'segments' parameter.
10366         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10367         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10368         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10369         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10370         if feature is present.
10371         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10372         Add 'segments' parameter to call to i386_target_description.
10373         (i386_target_description): Add 'segments' parameter to enable
10374         segment base registers.
10375         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10376         to call to i386_target_description.
10377         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10378         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10379         Define I386_NUM_REGS.
10380         (i386_target_description): Add 'segments' parameter to enable
10381         segment base registers.
10382
10383 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10384
10385         PR/24325
10386         * source-cache.c: #undef open and close, to avoid unresolved
10387         externals during linking.
10388
10389 2019-03-12  Tom Tromey  <tromey@adacore.com>
10390
10391         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10392         const.  Add initializers.
10393         (_initialize_remote): Don't initialize ptid globals.
10394
10395 2019-03-12  Pedro Alves  <palves@redhat.com>
10396
10397         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10398
10399 2019-03-12  Pedro Alves  <palves@redhat.com>
10400
10401         * cp-name-parser.y (main): Remove unused 'len' variable.
10402
10403 2019-03-12  Tom Tromey  <tromey@adacore.com>
10404
10405         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10406         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10407
10408 2019-03-12  Tom Tromey  <tromey@adacore.com>
10409
10410         * linux-nat.c (iterate_over_lwps): Update.
10411         (stop_callback): Remove parameter.
10412         (stop_wait_callback, detach_callback, resume_set_callback)
10413         (select_singlestep_lwp_callback, set_ignore_sigint)
10414         (status_callback, resumed_callback, resume_clear_callback)
10415         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10416         data parameter.
10417         (linux_nat_target::detach, linux_nat_target::resume)
10418         (linux_stop_and_wait_all_lwps, select_event_lwp)
10419         (linux_nat_filter_event, linux_nat_wait_1)
10420         (linux_nat_target::kill, linux_nat_target::stop)
10421         (linux_nat_target::stop): Update.
10422         (linux_nat_resume_callback): Change type.
10423         (resume_stopped_resumed_lwps, count_events_callback)
10424         (select_event_lwp_callback): Likewise.
10425         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10426         * arm-linux-nat.c (struct update_registers_data): Remove.
10427         (update_registers_callback): Change type.
10428         (arm_linux_insert_hw_breakpoint1): Update.
10429         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10430         parameter.
10431         (x86_linux_dr_set_addr): Update.
10432         (x86_linux_dr_set_control): Update.
10433         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10434         (iterate_over_lwps): Use gdb::function_view.
10435         * nat/aarch64-linux-hw-point.c (struct
10436         aarch64_dr_update_callback_param): Remove.
10437         (debug_reg_change_callback): Change type.
10438         (aarch64_notify_debug_reg_change): Update.
10439         * s390-linux-nat.c (s390_refresh_per_info): Update.
10440
10441 2019-03-11  Tom Tromey  <tromey@adacore.com>
10442
10443         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10444         redundant assignment to "this_cu".
10445
10446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10447
10448         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10449
10450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10451
10452         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10453         from...
10454         (rank_one_type): ... this.
10455
10456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10457
10458         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10459         from...
10460         (rank_one_type): ... this.
10461
10462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10463
10464         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10465         from...
10466         (rank_one_type): ... this.
10467
10468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10469
10470         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10471         from...
10472         (rank_one_type): ... this.
10473
10474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10475
10476         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10477         from...
10478         (rank_one_type): ... this.
10479
10480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10481
10482         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10483         from...
10484         (rank_one_type): ... this.
10485
10486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10487
10488         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10489         from...
10490         (rank_one_type): ... this.
10491
10492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10493
10494         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10495         from...
10496         (rank_one_type): ... this.
10497
10498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10499
10500         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10501         from...
10502         (rank_one_type): ... this.
10503
10504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10505
10506         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10507         from...
10508         (rank_one_type): ... this.
10509
10510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10511
10512         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10513         from...
10514         (rank_one_type): ... this.
10515
10516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10517
10518         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10519         from...
10520         (rank_one_type): ... this.
10521
10522 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10523
10524         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10525         inferior-events' shows the example events.
10526
10527 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10528
10529         Support styling on native MS-Windows console
10530
10531         PR/24315
10532         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10533         on MS-Windows if $TERM is not defined.
10534
10535         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10536
10537         * posix-hdep.c (gdb_console_fputs):
10538         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10539         functions.
10540         * ui-file.h (gdb_console_fputs): Add prototype.
10541
10542         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10543         back to fputs only if the former returns zero.
10544
10545 2019-03-07  Tom Tromey  <tom@tromey.com>
10546
10547         * symmisc.c (print_symbol_bcache_statistics): Update.
10548         (print_objfile_statistics): Update.
10549         * symfile.c (allocate_symtab): Update.
10550         * stabsread.c: Don't include bcache.h.
10551         * psymtab.h (struct psymbol_bcache): Don't declare.
10552         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10553         (psymbol_bcache_init, psymbol_bcache_free)
10554         (psymbol_bcache_get_bcache): Don't declare.
10555         * psymtab.c (struct psymbol_bcache): Remove.
10556         (psymtab_storage::psymtab_storage): Update.
10557         (psymtab_storage::~psymtab_storage): Update.
10558         (psymbol_bcache_init, psymbol_bcache_free)
10559         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10560         (add_psymbol_to_bcache): Update.
10561         (allocate_psymtab): Update.
10562         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10563         macro_cache>: No longer pointers.
10564         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10565         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10566         * macrotab.c (macro_bcache): Update.
10567         * macroexp.c: Don't include bcache.h.
10568         * gdbtypes.c (check_types_worklist): Update.
10569         (types_deeply_equal): Remove TRY/CATCH.  Update.
10570         * elfread.c (elf_symtab_read): Update.
10571         * dwarf2read.c: Don't include bcache.h.
10572         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10573         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10574         (print_bcache_statistics, bcache_memory_used): Don't declare.
10575         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10576         methods.  Rename all data members.
10577         * bcache.c (struct bcache): Move to bcache.h.
10578         (bcache::expand_hash_table): Rename from expand_hash_table.
10579         (bcache): Remove.
10580         (bcache::insert): Rename from bcache_full.
10581         (bcache::compare): Rename from bcache_compare.
10582         (bcache_xmalloc): Remove.
10583         (bcache::~bcache): Rename from bcache_xfree.
10584         (bcache::print_statistics): Rename from print_bcache_statistics.
10585         (bcache::memory_used): Rename from bcache_memory_used.
10586
10587 2019-03-07  Pedro Alves  <palves@redhat.com>
10588
10589         * infrun.c (normal_stop): Also check for
10590         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10591
10592 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10593
10594         * f-lang.c (value_from_host_double): Moved to...
10595         * value.c (value_from_host_double): ...here.
10596         * value.h (value_from_host_double): Declare.
10597         * guile/scm-math.c (vlscm_convert_typed_number): Use
10598         value_from_host_double.
10599         (vlscm_convert_number): Likewise.
10600         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10601         * python/py-value.c (convert_value_from_python): Likewise.
10602
10603 2019-03-06  Tom Tromey  <tom@tromey.com>
10604
10605         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10606
10607 2019-03-06  Tom Tromey  <tom@tromey.com>
10608
10609         * utils.h (free_current_contents): Don't declare.
10610         * utils.c (free_current_contents): Remove.
10611
10612 2019-03-06  Tom Tromey  <tom@tromey.com>
10613
10614         * top.c (quit_force): Update.
10615         * main.c (captured_command_loop): Update.
10616         * common/new-op.c (operator new): Update.
10617         * common/common-exceptions.c (struct catcher)
10618         <save_cleanup_chain>: Remove member.
10619         (exceptions_state_mc_init): Update.
10620         (exception_try_scope_entry): Return nullptr.
10621         (exception_try_scope_exit, exception_rethrow)
10622         (throw_exception_sjlj, throw_exception_cxx): Update.
10623         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10624         (all_cleanups, do_cleanups, discard_cleanups)
10625         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10626         (restore_cleanups, restore_final_cleanups): Don't declare.
10627         (do_final_cleanups): Remove parameter.
10628         * common/cleanups.c (cleanup_chain, make_cleanup)
10629         (make_cleanup_dtor, all_cleanups, do_cleanups)
10630         (discard_my_cleanups, discard_cleanups)
10631         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10632         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10633         (null_cleanup): Remove.
10634         (do_final_cleanups): Remove parameter.
10635
10636 2019-03-06  Tom Tromey  <tom@tromey.com>
10637
10638         * remote.c (remote_target::remote_parse_stop_reply): Use
10639         unique_xmalloc_ptr.
10640
10641 2019-03-06  Tom Tromey  <tom@tromey.com>
10642
10643         * stabsread.c (struct stabs_field_info): Rename from field_info.
10644         <list, fnlist>: Add initializers.
10645         <obstack>: New member.
10646         (read_member_functions, read_struct_fields, read_baseclasses):
10647         Allocate on obstack.  Don't use cleanups.
10648         (read_one_struct_field, read_member_functions, read_struct_fields)
10649         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10650         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10651         (read_struct_type): Update.
10652
10653 2019-03-06  Tom Tromey  <tom@tromey.com>
10654
10655         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10656         * common/filestuff.h (make_cleanup_close): Don't declare.
10657         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10658         Remove.
10659
10660 2019-03-06  Tom Tromey  <tom@tromey.com>
10661
10662         * solib-aix.c: Use make_scope_exit.
10663
10664 2019-03-06  Tom Tromey  <tom@tromey.com>
10665
10666         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10667         Use make_scope_exit.
10668
10669 2019-03-06  Tom Tromey  <tom@tromey.com>
10670
10671         * solib-svr4.c (disable_probes_interface): Remove parameter.
10672         (svr4_handle_solib_event): Use make_scope_exit.
10673
10674 2019-03-06  Tom Tromey  <tom@tromey.com>
10675
10676         * remote.c (struct stop_reply_deleter): Remove.
10677         (stop_reply_up): Update.
10678         (struct stop_reply): Derive from notif_event.  Don't typedef.
10679         <regcache>: Now a std::vector.
10680         (stop_reply_xfree): Remove.
10681         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10682         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10683         (remote_target::discard_pending_stop_replies): Use delete.
10684         (remote_target::remote_parse_stop_reply): Update.
10685         (remote_target::process_stop_reply): Update.
10686         * remote-notif.h (struct notif_event): Add virtual destructor.
10687         Remove "dtr" member.
10688         (struct notif_client) <alloc_event>: Return a unique_ptr.
10689         (notif_event_xfree): Don't declare.
10690         (notif_event_up): New typedef.
10691         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10692         (notif_event_xfree, do_notif_event_xfree): Remove.
10693         (remote_notif_state_xfree): Update.
10694
10695 2019-03-06  Tom Tromey  <tom@tromey.com>
10696
10697         * infrun.c (displaced_step_clear_cleanup): Now a
10698         forward_scope_exit type.
10699         (displaced_step_prepare_throw): Update.
10700         (displaced_step_fixup): Update.
10701
10702 2019-03-06  Tom Tromey  <tom@tromey.com>
10703
10704         * inferior.h (class inferior): Update comment.
10705         * gdbthread.h (class thread_info): Update comment.
10706
10707 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10708             Tom Tromey  <tom@tromey.com>
10709
10710         * stabsread.h (struct stab_section_list): Remove.
10711         (coffstab_build_psymtabs): Update.
10712         * dbxread.c (symbuf_sections): Now a std::vector.
10713         (sect_idx): New global.
10714         (fill_symbuf): Update.
10715         (coffstab_build_psymtabs): Change type of stabsects parameter.
10716         Update.
10717         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10718         std::vector.
10719         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10720         (coff_locate_sections): Update.
10721         (coff_symfile_read): Remove cleanups.  Update.
10722         (init_stringtab): Add storage parameter.
10723         (free_stringtab, free_stringtab_cleanup): Remove.
10724         (init_lineno): Add storage parameter.
10725         (free_linetab, free_linetab_cleanup): Remove.
10726
10727 2019-03-06  Pedro Alves  <palves@redhat.com>
10728
10729         * linux-fork.c (fork_info::clobber_regs): Delete.
10730         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10731         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10732         comment.  Adjust.
10733         (scoped_switch_fork_info::scoped_switch_fork_info)
10734         (checkpoint_command, linux_fork_context): Adjust
10735         fork_save_infrun_state calls.
10736
10737 2019-03-06  Pedro Alves  <palves@redhat.com>
10738
10739         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10740         (inf_has_multiple_threads): Return 'bool' and rewrite using
10741         inferior_info::threads().
10742
10743 2019-03-06  Pedro Alves  <palves@redhat.com>
10744
10745         * linux-fork.c: Include <list>.
10746         (fork_list): Now a std::list instance.
10747         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10748         (forks_exist_p, find_last_fork): Adjust.
10749         (new_fork): Delete.
10750         (one_fork_p): New.
10751         (add_fork): Adjust.
10752         (free_fork): Delete, folded into fork_info::~fork_info().
10753         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10754         Adjust.
10755         (init_fork_list): Delete.
10756         (linux_fork_killall, linux_fork_mourn_inferior)
10757         (linux_fork_detach, info_checkpoints_command): Adjust.
10758         (_initialize_linux_fork): No longer call init_fork_list.
10759
10760 2019-03-06  Pedro Alves  <palves@redhat.com>
10761
10762         * linux-fork.c (new_fork): New, split out of ...
10763         (add_fork): ... this.  Return void.  Move "first fork" special
10764         case from here, to ...
10765         (checkpoint_command): ... here.
10766         * linux-linux.h (add_fork): Return void.
10767
10768 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10769
10770         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10771
10772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10773             Chris January  <chris.january@arm.com>
10774             David Lecomber  <david.lecomber@arm.com>
10775
10776         * f-exp.y: New token, UNOP_INTRINSIC.
10777         (exp): New pattern using UNOP_INTRINSIC token.
10778         (f77_keywords): Add 'abs' keyword.
10779         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10780         (value_from_host_double): New function.
10781         (evaluate_subexp_f): Support UNOP_ABS.
10782
10783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10784
10785         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10786         types.
10787
10788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10789
10790         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10791         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10792         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10793
10794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10795
10796         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10797
10798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10799             Chris January  <chris.january@arm.com>
10800
10801         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10802         * f-exp.y: Define 'KIND' token.
10803         (exp): New pattern for KIND expressions.
10804         (ptype): Handle types with a kind extension.
10805         (direct_abs_decl): Extend to spot kind extensions.
10806         (f77_keywords): Add 'kind' to the list.
10807         (push_kind_type): New function.
10808         (convert_to_kind_type): New function.
10809         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10810         * parse.c (operator_length_standard): Likewise.
10811         * parser-defs.h (enum type_pieces): Add tp_kind.
10812         * std-operator.def: Add UNOP_KIND.
10813
10814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * f-exp.y (f_parse): Set yydebug.
10817
10818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10819
10820         * f-lang.c (evaluate_subexp_f): New function.
10821         (exp_descriptor_f): New global.
10822         (f_language_defn): Use exp_descriptor_f instead of
10823         exp_descriptor_standard.
10824
10825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10826
10827         * f-exp.y (struct token): Add comments.
10828         (dot_ops): Remove uppercase versions and the end marker.
10829         (f77_keywords): Likewise.
10830         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10831         entries in the dot_ops array are case insensitive, and use
10832         strncasecmp to compare strings.  Also some whitespace cleanup in
10833         this area.  Similar for the f77_keywords array, except entries in
10834         this list might be case sensitive.
10835
10836 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * f-exp.y (struct f77_boolean_val): Add comments.
10839         (boolean_values): Remove uppercase versions, and end marker.
10840         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10841         and use strncasecmp to achieve case insensitivity.  Additionally,
10842         perform whitespace cleanup around this code.
10843
10844 2019-03-06  Tom Tromey  <tromey@adacore.com>
10845
10846         * remote-sim.c (gdbsim_target_open): Use result of
10847         gdb_argv::release.
10848
10849 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10850         Dirk Schubert  <dirk.schubert@arm.com>
10851         Chris January  <chris.january@arm.com>
10852
10853         * eval.c (evaluate_subexp_standard): Call Fortran argument
10854         wrapping logic.
10855         * f-lang.c (struct value): A value which can be passed into a
10856         Fortran function call.
10857         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10858         where appropriate.
10859         (struct type): Value ready for a Fortran function call.
10860         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10861         is needed.
10862         * f-lang.h (fortran_argument_convert): Declaration.
10863         (fortran_preserve_arg_pointer): Declaration.
10864         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10865
10866 2019-03-05  Tom Tromey  <tromey@adacore.com>
10867
10868         * python/py-prettyprint.c (print_string_repr): Remove #if.
10869         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10870
10871 2019-03-05  Tom Tromey  <tromey@adacore.com>
10872
10873         * target.c (the_dummy_target): Move later.  Change type to
10874         "dummy_target".
10875         (initialize_targets): Don't initialize the_dummy_target.
10876
10877 2019-03-05  Tom Tromey  <tromey@adacore.com>
10878
10879         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10880         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10881
10882 2019-03-05  Tom Tromey  <tromey@adacore.com>
10883
10884         * windows-nat.c (windows_nat_target::attach)
10885         (windows_nat_target::detach): Don't call gdb_flush.
10886         * valprint.c (generic_val_print, val_print, val_print_string):
10887         Don't call gdb_flush.
10888         * utils.c (defaulted_query): Don't call gdb_flush.
10889         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10890         * target.c (target_announce_detach): Don't call gdb_flush.
10891         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10892         * remote.c (extended_remote_target::attach): Don't call
10893         gdb_flush.
10894         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10895         * printcmd.c (do_examine): Don't call gdb_flush.
10896         (info_display_command): Don't call gdb_flush.
10897         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10898         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10899         * memattr.c (info_mem_command): Don't call gdb_flush.
10900         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10901         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10902         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10903         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10904         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10905         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10906         (gnu_nat_target::detach): Don't call gdb_flush.
10907         * f-valprint.c (f_val_print): Don't call gdb_flush.
10908         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10909         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10910         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10911         gdb_flush.
10912         * c-valprint.c (c_val_print): Don't call gdb_flush.
10913         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10914
10915 2019-03-05  Tom Tromey  <tromey@adacore.com>
10916
10917         * varobj.c (update_dynamic_varobj_children): Update.
10918         (install_default_visualizer): Use reset, not release.
10919         * value.c (set_internalvar): Update.
10920         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10921         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10922         ATTRIBUTE_UNUSED_RESULT.
10923
10924 2019-03-05  Tom Tromey  <tromey@adacore.com>
10925
10926         * remote.c (class scoped_remote_fd) <release>: Add
10927         ATTRIBUTE_UNUSED_RESULT.
10928
10929 2019-03-05  Tom Tromey  <tromey@adacore.com>
10930
10931         * macroexp.c (struct macro_buffer) <release>: Add
10932         ATTRIBUTE_UNUSED_RESULT.
10933
10934 2019-03-05  Tom Tromey  <tromey@adacore.com>
10935
10936         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10937         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10938         ATTRIBUTE_UNUSED_RESULT.
10939
10940 2019-03-05  Tom Tromey  <tromey@adacore.com>
10941
10942         * common/scoped_fd.h (class scoped_fd) <release>: Add
10943         ATTRIBUTE_UNUSED_RESULT.
10944
10945 2019-03-05  Tom Tromey  <tromey@adacore.com>
10946
10947         * parser-defs.h (struct parser_state) <release>: Add
10948         ATTRIBUTE_UNUSED_RESULT.
10949
10950 2019-03-05  Tom Tromey  <tromey@adacore.com>
10951
10952         * utils.h (class gdb_argv) <release>: Add
10953         ATTRIBUTE_UNUSED_RESULT.
10954         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10955
10956 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10957
10958         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10959         for-loop range, to avoid compiler warnings.
10960
10961         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10962         avoid compiler warnings about unused variables.
10963
10964         * NEWS: Mention end of support for native debugging on MS-Windows
10965         before XP.
10966
10967         PR gdb/24292
10968         * common/netstuff.c:
10969         * gdbserver/gdbreplay.c
10970         * gdbserver/remote-utils.c:
10971         * ser-tcp.c:
10972         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10973         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10974         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10975         'getaddrinfo' and 'freeaddrinfo' were not available before
10976         Windows XP, and mingw.org's MinGW headers by default define
10977         _WIN32_WINNT to 0x500.
10978
10979 2019-03-01  Gary Benson <gbenson@redhat.com>
10980
10981         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10982
10983 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10984             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10985
10986         PR gdb/8527
10987         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10988         set_sigint_trap, clear_sigint_trap.
10989
10990 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10991
10992         * target.c (target_detach): Clear the regcache and the
10993         frame cache.
10994
10995 2019-02-27  Pedro Alves  <palves@redhat.com>
10996
10997         * utils.c (set_screen_size): When we cap the height/width sizes,
10998         tweak the corresponding command variable to show "unlimited":
10999
11000 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11001             Pedro Alves  <palves@redhat.com>
11002
11003         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11004         before calling rl_set_screen_size.
11005
11006 2019-02-27  Tom Tromey  <tromey@adacore.com>
11007
11008         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11009         define.
11010         * python/py-value.c: Remove Python 2.4 workaround.
11011         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11012         workaround.
11013         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11014         Python 2.4 workaround.
11015         * python/python-internal.h: Remove Python 2.4 comment.
11016         (Py_ssize_t): Don't define.
11017         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11018         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11019         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11020         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11021         * python/python.c (do_start_initialization): Remove Python 2.4
11022         workaround.
11023         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11024         (print_children): Remove Python 2.4 workaround.
11025         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11026         workaround.
11027         (CHARBUFFERPROC_NAME): Remove.
11028         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11029         Python 2.4 workaround.
11030
11031 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11032
11033         * NEWS: Note minimum Python version.
11034
11035 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11036
11037         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11038         code from these functions.  Remove corresponding ifdefs.  Use
11039         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11040         Remove gotos and target of gotos.
11041         (infpy_search_memory): Likewise.
11042
11043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11044
11045         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11046         (hppa_gdbarch_init): Don't register deleted functions with
11047         gdbarch.
11048
11049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11050
11051         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11052         (h8300_unwind_sp): Delete.
11053         (h8300_dummy_id): Delete.
11054         (h8300_gdbarch_init): Don't register deleted functions with
11055         gdbarch.
11056
11057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11058
11059         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11060         (ft32_unwind_pc): Delete.
11061         (ft32_unwind_sp): Delete.
11062         (ft32_gdbarch_init): Don't register deleted functions with
11063         gdbarch.
11064
11065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11066
11067         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11068         (frv_unwind_pc): Delete.
11069         (frv_unwind_sp): Delete.
11070         (frv_gdbarch_init): Don't register deleted functions with
11071         gdbarch.
11072
11073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11076         (riscv_unwind_pc): Delete.
11077         (riscv_unwind_sp): Delete.
11078         (riscv_gdbarch_init): Don't register deleted functions with
11079         gdbarch.
11080
11081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11082
11083         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11084         (csky_unwind_pc): Delete.
11085         (csky_unwind_sp): Delete.
11086         (csky_gdbarch_init): Don't register deleted functions with
11087         gdbarch.
11088
11089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11090
11091         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11092         (cris_unwind_pc): Delete.
11093         (cris_unwind_sp): Delete.
11094         (cris_gdbarch_init): Don't register deleted functions with
11095         gdbarch.
11096
11097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11100         (bfin_unwind_pc): Delete.
11101         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11102
11103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11104
11105         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11106         (arm_unwind_pc): Delete.
11107         (arm_unwind_sp): Delete.
11108         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11109
11110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11111
11112         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11113         (arc_unwind_pc): Delete.
11114         (arc_unwind_sp): Delete.
11115         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11116
11117 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11118
11119         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11120         (alpha_unwind_pc): Delete.
11121         (alpha_gdbarch_init): Don't register deleted functions with
11122         gdbarch.
11123
11124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11125
11126         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11127         (aarch64_unwind_pc): Delete.
11128         (aarch64_unwind_sp): Delete.
11129         (aarch64_gdbarch_init): Don't register deleted functions with
11130         gdbarch.
11131
11132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11133
11134         * gdbtypes.c (type_align): Don't consider static members when
11135         computing structure alignment.
11136
11137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11138
11139         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11140         return 0 for other types.
11141         * arch-utils.c (default_type_align): Always return 0.
11142         * gdbarch.h: Regenerate.
11143         * gdbarch.sh (type_align): Extend comment.
11144         * gdbtypes.c (type_align): Add additional comments, always call
11145         gdbarch_type_align before applying the default rules.
11146         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11147         generic code will then apply a suitable default.
11148         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11149         types, return 0 for other types.
11150
11151 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11152
11153         * NEWS: Create a new section for the next release branch.
11154         Rename the section of the current branch, now that it has
11155         been cut.
11156
11157 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11158
11159         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11160         * version.in: Bump version to 8.3.50.DATE-git.
11161
11162 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11163
11164         * aix-thread.c (ptid_cmp): Remove unused variable.
11165         (get_signaled_thread): Likewise.
11166         (store_regs_user_thread): Likewise.
11167         (store_regs_kernel_thread): Likewise.
11168         (fetch_regs_kernel_thread): Remove shadowed variable.
11169
11170 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * features/riscv/32bit-cpu.xml: Add register numbers.
11173         * features/riscv/32bit-fpu.c: Regenerate.
11174         * features/riscv/32bit-fpu.xml: Add register numbers.
11175         * features/riscv/64bit-cpu.xml: Add register numbers.
11176         * features/riscv/64bit-fpu.c: Regenerate.
11177         * features/riscv/64bit-fpu.xml: Add register numbers.
11178
11179 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11180
11181         * NEWS: Mention two argument form of gdb.Value constructor.
11182         * python/py-value.c (convert_buffer_and_type_to_value): New
11183         function.
11184         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11185         Add support for handling an optional second argument.  Call
11186         convert_buffer_and_type_to_value as appropriate.
11187         * python/python-internal.h (Py_buffer_deleter): New struct.
11188         (Py_buffer_up): New typedef.
11189
11190 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11191
11192         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11193         instead of releasing ownership.
11194
11195 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11196
11197         * dwarf2read.c (open_and_init_dwp_file): Call
11198         elf_numsections instead of bfd_count_sections to initialize
11199         dwp_file->num_sections.
11200
11201 2019-02-25  Tom Tromey  <tromey@adacore.com>
11202
11203         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11204
11205 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11206
11207         * gcore.in: Add '--readnever' option when invoking GDB.
11208
11209 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11210
11211         * MAINTAINERS: Update my email address.
11212
11213 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11214
11215         * build-id.c (build_id_to_debug_bfd_1): New function.
11216         (build_id_to_debug_bfd): Look for separate debug file in
11217         sysroot.
11218
11219 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11220
11221         * gdbarch.sh: Update the copyright year range that is placed into
11222         generated files.
11223
11224 2019-02-22  Keith Seitz  <keiths@redhat.com>
11225
11226         PR symtab/23853
11227         * linespec.c (create_sals_line_offset): Search for the default
11228         symtab's filename instead of its fullname.
11229
11230 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11231
11232         * NEWS: Update style defaults.
11233
11234 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11235
11236         * main.c (captured_main_1): Disable styling in batch mode.
11237
11238 2019-02-20  Tom Tromey  <tom@tromey.com>
11239
11240         * symtab.c (symtab_symbol_info): Fix typos.
11241
11242 2019-02-20  Tom Tromey  <tromey@adacore.com>
11243
11244         * findcmd.c (_initialize_mem_search): Use upper case for
11245         metasyntactic variables.
11246
11247 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11248
11249         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11250         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11251
11252 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11253
11254         * top.h (source_file_name): Change to std::string.
11255         * top.c (source_file_name): Likewise.
11256         (command_line_input): Adjust.
11257         * cli/cli-script.c (script_from_file): Adjust.
11258
11259 2019-02-19  Tom Tromey  <tromey@adacore.com>
11260
11261         * ravenscar-thread.c
11262         (ravenscar_thread_target::update_thread_list): Don't call
11263         ada_build_task_list.
11264         * ada-lang.h (ada_build_task_list): Don't declare.
11265         * ada-tasks.c (struct ada_tasks_inferior_data)
11266         <task_list_valid_p>: Now bool.
11267         (read_known_tasks, ada_task_list_changed)
11268         (ada_tasks_invalidate_inferior_data): Update.
11269         (read_known_tasks_array): Return bool.
11270         (read_known_tasks_list): Likewise.
11271         (read_known_tasks): Return void.
11272         (ada_build_task_list): Now static.
11273
11274 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11275
11276         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11277         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11278
11279 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11280
11281         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11282         variant for ada_tasks_pspace_data_handle and
11283         ada_tasks_inferior_data_handle.
11284         (ada_tasks_pspace_data_cleanup): New function.
11285         (ada_tasks_inferior_data_cleanup): New function.
11286
11287 2019-02-17  Tom Tromey  <tom@tromey.com>
11288
11289         * macrotab.h (macro_source_fullname): Return a std::string.
11290         * macrotab.c (macro_include, check_for_redefinition)
11291         (macro_undef, macro_lookup_definition, foreach_macro)
11292         (foreach_macro_in_scope): Update.
11293         (macro_source_fullname): Return a std::string.
11294         * macrocmd.c (show_pp_source_pos): Update.
11295
11296 2019-02-17  Tom Tromey  <tom@tromey.com>
11297
11298         * macrocmd.c (show_pp_source_pos): Style the file names.
11299
11300 2019-02-17  Tom Tromey  <tom@tromey.com>
11301
11302         PR tui/24197:
11303         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11304
11305 2019-02-17  Tom Tromey  <tom@tromey.com>
11306
11307         * ada-lang.c (user_select_syms): Use filtered printing.
11308         * utils.c (wrap_style): New global.
11309         (desired_style): Remove.
11310         (emit_style_escape): Add stream parameter.
11311         (set_output_style, reset_terminal_style, prompt_for_continue):
11312         Update.
11313         (flush_wrap_buffer): Only flush gdb_stdout.
11314         (wrap_here): Set wrap_style.
11315         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11316         treat escape sequences as a character.  Change when wrap buffer is
11317         flushed.
11318         (fputs_styled): Do not set the output style when the default is
11319         requested.
11320         * ui-style.h (struct ui_file_style) <is_default>: New method.
11321         * source.c (print_source_lines_base): Emit escape sequences in one
11322         piece.
11323
11324 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11325
11326         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11327         integers and enumeration types.
11328
11329 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11330
11331         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11332         instead of lookup_symbol_in_language
11333         (do_exact_match): New function.
11334         (ada_get_symbol_name_matcher): Return do_exact_match when
11335         doing a verbatim match.
11336
11337 2019-02-15  Tom Tromey  <tromey@adacore.com>
11338
11339         * ravenscar-thread.c (ravenscar_thread_target::resume)
11340         (ravenscar_thread_target::wait): Special case wildcard requests.
11341
11342 2019-02-15  Tom Tromey  <tromey@adacore.com>
11343
11344         * ravenscar-thread.c (base_ptid): Remove.
11345         (struct ravenscar_thread_target) <close>: New method.
11346         <m_base_ptid>: New member.
11347         <update_inferior_ptid, active_task, task_is_currently_active,
11348         runtime_initialized>: Declare methods.
11349         <ravenscar_thread_target>: Add constructor.
11350         (ravenscar_thread_target::task_is_currently_active)
11351         (ravenscar_thread_target::update_inferior_ptid)
11352         (ravenscar_runtime_initialized): Rename.  Now methods.
11353         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11354         (ravenscar_thread_target::update_thread_list): Update.
11355         (ravenscar_thread_target::active_task): Now method.
11356         (ravenscar_thread_target::store_registers)
11357         (ravenscar_thread_target::prepare_to_store)
11358         (ravenscar_thread_target::prepare_to_store)
11359         (ravenscar_thread_target::mourn_inferior): Update.
11360         (ravenscar_inferior_created): Use "new" to create target.
11361         (ravenscar_thread_target::get_ada_task_ptid): Update.
11362         (_initialize_ravenscar): Don't initialize base_ptid.
11363         (ravenscar_ops): Remove global.
11364
11365 2019-02-15  Tom Tromey  <tromey@adacore.com>
11366
11367         * target.h (push_target): Declare new overload.
11368         * target.c (push_target): New overload, taking an rvalue reference.
11369         * remote.c (remote_target::open_1): Use push_target overload.
11370         * corelow.c (core_target_open): Use push_target overload.
11371
11372 2019-02-15  Tom Tromey  <tromey@adacore.com>
11373
11374         * ravenscar-thread.c (is_ravenscar_task)
11375         (ravenscar_task_is_currently_active): Return bool.
11376         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11377         (_initialize_ravenscar): Remove "(void)".
11378         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11379         Return bool.
11380
11381 2019-02-15  Tom Tromey  <tromey@adacore.com>
11382
11383         * ravenscar-thread.c (ravenscar_runtime_initializer)
11384         (has_ravenscar_runtime, get_running_thread_id)
11385         (ravenscar_thread_target::resume): Fix indentation.
11386
11387 2019-02-15  Tom Tromey  <tromey@adacore.com>
11388
11389         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11390         from ravenscar_arch_ops.
11391         (sparc_ravenscar_ops::fetch_registers)
11392         (sparc_ravenscar_ops::store_registers): Now methods.
11393         (sparc_ravenscar_prepare_to_store): Remove.
11394         (sparc_ravenscar_ops): Redefine.
11395         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11396         methods and destructor.  Remove members.
11397         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11398         (ravenscar_thread_target::store_registers)
11399         (ravenscar_thread_target::prepare_to_store): Update.
11400         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11401         Remove.
11402         (struct ppc_ravenscar_powerpc_ops): Derive from
11403         ravenscar_arch_ops.
11404         (ppc_ravenscar_powerpc_ops::fetch_registers)
11405         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11406         (ppc_ravenscar_powerpc_ops): Redefine.
11407         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11408         (ppc_ravenscar_e500_ops::fetch_registers)
11409         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11410         (ppc_ravenscar_e500_ops): Redefine.
11411         * aarch64-ravenscar-thread.c
11412         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11413         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11414         (aarch64_ravenscar_fetch_registers)
11415         (aarch64_ravenscar_store_registers): Now methods.
11416         (aarch64_ravenscar_ops): Redefine.
11417
11418 2019-02-15  Tom Tromey  <tromey@adacore.com>
11419
11420         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11421         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11422         (ravenscar_thread_target::stopped_by_watchpoint)
11423         (ravenscar_thread_target::stopped_data_address)
11424         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11425
11426 2019-02-15  Tom Tromey  <tromey@adacore.com>
11427
11428         * ravenscar-thread.c: Fix some typos.
11429
11430 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11431             Tom Tromey  <tromey@adacore.com>
11432
11433         * ada-lang.c (ada_exception_sal): Change addr_string to a
11434         std::string.
11435         (create_ada_exception_catchpoint): Update.
11436
11437 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11438             Tom Tromey  <tromey@adacore.com>
11439
11440         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11441         (bp_location_ops): Remove.
11442         (base_breakpoint_allocate_location): Update.
11443         (free_bp_location): Update.
11444         * ada-lang.c (class ada_catchpoint_location)
11445         <ada_catchpoint_location>: Remove ops parameter.
11446         (ada_catchpoint_location_dtor): Remove.
11447         (ada_catchpoint_location_ops): Remove.
11448         (allocate_location_exception): Update.
11449         * breakpoint.h (struct bp_location_ops): Remove.
11450         (class bp_location) <bp_location>: Remove bp_location_ops
11451         parameter.
11452         <~bp_location>: Add destructor.
11453         <ops>: Remove.
11454
11455 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11456             Pedro Alves  <palves@redhat.com>
11457
11458         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11459         'PATH_MAX'.
11460
11461 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11462             Samuel Thibault  <samuel.thibault@gnu.org>
11463             Thomas Schwinge  <thomas@codesourcery.com>
11464
11465         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11466         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11467
11468 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11469
11470         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11471         (check_empty): Use "const char *".
11472
11473         * gnu-nat.c (gnu_nat_target::detach): Instead of
11474         'detach_inferior (pid)' call
11475         'detach_inferior (find_inferior_pid (pid))'.
11476
11477         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11478         'nat/fork-inferior.o'.
11479         * gnu-nat.c: #include "nat/fork-inferior.h".
11480
11481         * gnu-nat.c (gnu_nat_target::detach): Instead of
11482         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11483         * gnu-nat.h: #include "inf-child.h".
11484         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11485         'i386_gnu_nat_target::fetch_registers'.
11486         (gnu_store_registers): Rename/move to
11487         'i386_gnu_nat_target::store_registers'.
11488
11489         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11490         * gnu-nat.h (mach_thread_info): New function.
11491         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11492
11493         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11494
11495 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11496
11497         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11498
11499 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11500
11501         * windows-nat.c (windows_add_thread): Add new parameter
11502         "main_thread_p" with default value set to false.  Update
11503         function documentation as well as all callers.
11504         (windows_delete_thread): Likewise.
11505         (fake_create_process): Update call to windows_add_thread.
11506         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11507         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11508         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11509         call to windows_delete_thread.
11510
11511 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11512
11513         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11514
11515 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11516
11517         * symfile.c (find_separate_debug_file): Use canonical path of
11518         sysroot with child_path instead of gdb_sysroot if it is valid.
11519
11520 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11521
11522         * symfile.c (find_separate_debug_file): Use child_path to
11523         determine if an object file is under a sysroot.
11524
11525 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11526
11527         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11528         unittests/child-path-selftests.c.
11529         * common/pathstuff.c (child_path): New function.
11530         * common/pathstuff.h (child_path): New prototype.
11531         * unittests/child-path-selftests.c: New file.
11532
11533 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11534
11535         * symfile.c (find_separate_debug_file): Look for separate debug
11536         files in debug directories under the sysroot.
11537
11538 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11539
11540         * symtab.h (struct minimal_symbol data_p): New const method.
11541         (struct minimal_symbol text_p): Likewise.
11542         * symtab.c (output_source_filename): Use file name style
11543         to print file name.
11544         (print_symbol_info): Likewise.
11545         (print_msymbol_info): Use address style to print addresses.
11546         Use function name style to print executable text symbols.
11547         (expand_symtab_containing_pc): Use data_p.
11548         (find_pc_sect_compunit_symtab): Likewise.
11549
11550 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11551
11552         * breakpoint.c (describe_other_breakpoints): Use address style
11553         to print addresses.
11554         (say_where): Likewise.
11555
11556 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11557
11558         * ada-typeprint.c (print_func_type): Print function name
11559         style to print function name.
11560         * c-typeprint.c (c_print_type_1): Likewise.
11561
11562 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11563
11564         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11565         for execve.
11566
11567 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11568
11569         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11570         type_stack.
11571
11572 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11573
11574         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11575         TYPE_CODE_REF types.
11576
11577 2019-02-08  Jim Wilson  <jimw@sifive.com>
11578
11579         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11580         (riscv_linux_fregset): New.
11581         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11582
11583 2019-02-07  Tom Tromey  <tom@tromey.com>
11584
11585         * thread.c (thread_cancel_execution_command): Update.
11586         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11587         methods.
11588         (struct thread_fsm_ops): Remove.
11589         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11590         (thread_fsm_should_stop, thread_fsm_return_value)
11591         (thread_fsm_set_finished, thread_fsm_finished_p)
11592         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11593         Don't declare.
11594         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11595         * infrun.c (clear_proceed_status_thread)
11596         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11597         (print_stop_event): Update.
11598         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11599         Add constructor.
11600         (step_command_fsm_ops): Remove.
11601         (new_step_command_fsm): Remove.
11602         (step_1): Update.
11603         (step_command_fsm::should_stop): Rename from
11604         step_command_fsm_should_stop.
11605         (step_command_fsm::clean_up): Rename from
11606         step_command_fsm_clean_up.
11607         (step_command_fsm::do_async_reply_reason): Rename from
11608         step_command_fsm_async_reply_reason.
11609         (struct until_next_fsm): Inherit from thread_fsm.  Add
11610         constructor.
11611         (until_next_fsm_ops): Remove.
11612         (new_until_next_fsm): Remove.
11613         (until_next_fsm::should_stop): Rename from
11614         until_next_fsm_should_stop.
11615         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11616         (until_next_fsm::do_async_reply_reason): Rename from
11617         until_next_fsm_async_reply_reason.
11618         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11619         constructor.  Change type of breakpoint.
11620         (finish_command_fsm_ops): Remove.
11621         (new_finish_command_fsm): Remove.
11622         (finish_command_fsm::should_stop): Rename from
11623         finish_command_fsm_should_stop.
11624         (finish_command_fsm::clean_up): Rename from
11625         finish_command_fsm_clean_up.
11626         (finish_command_fsm::return_value): Rename from
11627         finish_command_fsm_return_value.
11628         (finish_command_fsm::do_async_reply_reason): Rename from
11629         finish_command_fsm_async_reply_reason.
11630         (finish_command): Update.
11631         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11632         Add constructor.
11633         (call_thread_fsm_ops): Remove.
11634         (call_thread_fsm::call_thread_fsm): Rename from
11635         new_call_thread_fsm.
11636         (call_thread_fsm::should_stop): Rename from
11637         call_thread_fsm_should_stop.
11638         (call_thread_fsm::should_notify_stop): Rename from
11639         call_thread_fsm_should_notify_stop.
11640         (run_inferior_call, call_function_by_hand_dummy): Update.
11641         * cli/cli-interp.c (should_print_stop_to_console): Update.
11642         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11643         Add constructor.  Change type of location_breakpoint,
11644         caller_breakpoint.
11645         (until_break_fsm_ops): Remove.
11646         (new_until_break_fsm): Remove.
11647         (until_break_fsm::should_stop): Rename from
11648         until_break_fsm_should_stop.
11649         (until_break_fsm::clean_up): Rename from
11650         until_break_fsm_clean_up.
11651         (until_break_fsm::do_async_reply_reason): Rename from
11652         until_break_fsm_async_reply_reason.
11653         (until_break_command): Update.
11654         * thread-fsm.c: Remove.
11655         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11656
11657 2019-02-07  Tom Tromey  <tom@tromey.com>
11658
11659         * yy-remap.h: Add include guard.
11660         * xtensa-tdep.h: Add include guard.
11661         * xcoffread.h: Rename include guard.
11662         * varobj-iter.h: Add include guard.
11663         * tui/tui.h: Rename include guard.
11664         * tui/tui-winsource.h: Rename include guard.
11665         * tui/tui-wingeneral.h: Rename include guard.
11666         * tui/tui-windata.h: Rename include guard.
11667         * tui/tui-win.h: Rename include guard.
11668         * tui/tui-stack.h: Rename include guard.
11669         * tui/tui-source.h: Rename include guard.
11670         * tui/tui-regs.h: Rename include guard.
11671         * tui/tui-out.h: Rename include guard.
11672         * tui/tui-layout.h: Rename include guard.
11673         * tui/tui-io.h: Rename include guard.
11674         * tui/tui-hooks.h: Rename include guard.
11675         * tui/tui-file.h: Rename include guard.
11676         * tui/tui-disasm.h: Rename include guard.
11677         * tui/tui-data.h: Rename include guard.
11678         * tui/tui-command.h: Rename include guard.
11679         * tic6x-tdep.h: Add include guard.
11680         * target/waitstatus.h: Rename include guard.
11681         * target/wait.h: Rename include guard.
11682         * target/target.h: Rename include guard.
11683         * target/resume.h: Rename include guard.
11684         * target-float.h: Rename include guard.
11685         * stabsread.h: Add include guard.
11686         * rs6000-tdep.h: Add include guard.
11687         * riscv-fbsd-tdep.h: Add include guard.
11688         * regformats/regdef.h: Rename include guard.
11689         * record.h: Rename include guard.
11690         * python/python.h: Rename include guard.
11691         * python/python-internal.h: Rename include guard.
11692         * python/py-stopevent.h: Rename include guard.
11693         * python/py-ref.h: Rename include guard.
11694         * python/py-record.h: Rename include guard.
11695         * python/py-record-full.h: Rename include guard.
11696         * python/py-record-btrace.h: Rename include guard.
11697         * python/py-instruction.h: Rename include guard.
11698         * python/py-events.h: Rename include guard.
11699         * python/py-event.h: Rename include guard.
11700         * procfs.h: Add include guard.
11701         * proc-utils.h: Add include guard.
11702         * p-lang.h: Add include guard.
11703         * or1k-tdep.h: Rename include guard.
11704         * observable.h: Rename include guard.
11705         * nto-tdep.h: Rename include guard.
11706         * nat/x86-linux.h: Rename include guard.
11707         * nat/x86-linux-dregs.h: Rename include guard.
11708         * nat/x86-gcc-cpuid.h: Add include guard.
11709         * nat/x86-dregs.h: Rename include guard.
11710         * nat/x86-cpuid.h: Rename include guard.
11711         * nat/ppc-linux.h: Rename include guard.
11712         * nat/mips-linux-watch.h: Rename include guard.
11713         * nat/linux-waitpid.h: Rename include guard.
11714         * nat/linux-ptrace.h: Rename include guard.
11715         * nat/linux-procfs.h: Rename include guard.
11716         * nat/linux-osdata.h: Rename include guard.
11717         * nat/linux-nat.h: Rename include guard.
11718         * nat/linux-namespaces.h: Rename include guard.
11719         * nat/linux-btrace.h: Rename include guard.
11720         * nat/glibc_thread_db.h: Rename include guard.
11721         * nat/gdb_thread_db.h: Rename include guard.
11722         * nat/gdb_ptrace.h: Rename include guard.
11723         * nat/fork-inferior.h: Rename include guard.
11724         * nat/amd64-linux-siginfo.h: Rename include guard.
11725         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11726         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11727         * nat/aarch64-linux.h: Rename include guard.
11728         * nat/aarch64-linux-hw-point.h: Rename include guard.
11729         * mn10300-tdep.h: Add include guard.
11730         * mips-linux-tdep.h: Add include guard.
11731         * mi/mi-parse.h: Rename include guard.
11732         * mi/mi-out.h: Rename include guard.
11733         * mi/mi-main.h: Rename include guard.
11734         * mi/mi-interp.h: Rename include guard.
11735         * mi/mi-getopt.h: Rename include guard.
11736         * mi/mi-console.h: Rename include guard.
11737         * mi/mi-common.h: Rename include guard.
11738         * mi/mi-cmds.h: Rename include guard.
11739         * mi/mi-cmd-break.h: Rename include guard.
11740         * m2-lang.h: Add include guard.
11741         * location.h: Rename include guard.
11742         * linux-record.h: Rename include guard.
11743         * linux-nat.h: Add include guard.
11744         * linux-fork.h: Add include guard.
11745         * i386-darwin-tdep.h: Rename include guard.
11746         * hppa-linux-offsets.h: Add include guard.
11747         * guile/guile.h: Rename include guard.
11748         * guile/guile-internal.h: Rename include guard.
11749         * gnu-nat.h: Rename include guard.
11750         * gdb-stabs.h: Rename include guard.
11751         * frv-tdep.h: Add include guard.
11752         * f-lang.h: Add include guard.
11753         * event-loop.h: Add include guard.
11754         * darwin-nat.h: Rename include guard.
11755         * cp-abi.h: Rename include guard.
11756         * config/sparc/nm-sol2.h: Rename include guard.
11757         * config/nm-nto.h: Rename include guard.
11758         * config/nm-linux.h: Add include guard.
11759         * config/i386/nm-i386gnu.h: Rename include guard.
11760         * config/djgpp/nl_types.h: Rename include guard.
11761         * config/djgpp/langinfo.h: Rename include guard.
11762         * compile/gcc-cp-plugin.h: Add include guard.
11763         * compile/gcc-c-plugin.h: Add include guard.
11764         * compile/compile.h: Rename include guard.
11765         * compile/compile-object-run.h: Rename include guard.
11766         * compile/compile-object-load.h: Rename include guard.
11767         * compile/compile-internal.h: Rename include guard.
11768         * compile/compile-cplus.h: Rename include guard.
11769         * compile/compile-c.h: Rename include guard.
11770         * common/xml-utils.h: Rename include guard.
11771         * common/x86-xstate.h: Rename include guard.
11772         * common/version.h: Rename include guard.
11773         * common/vec.h: Rename include guard.
11774         * common/tdesc.h: Rename include guard.
11775         * common/selftest.h: Rename include guard.
11776         * common/scoped_restore.h: Rename include guard.
11777         * common/scoped_mmap.h: Rename include guard.
11778         * common/scoped_fd.h: Rename include guard.
11779         * common/safe-iterator.h: Rename include guard.
11780         * common/run-time-clock.h: Rename include guard.
11781         * common/refcounted-object.h: Rename include guard.
11782         * common/queue.h: Rename include guard.
11783         * common/ptid.h: Rename include guard.
11784         * common/print-utils.h: Rename include guard.
11785         * common/preprocessor.h: Rename include guard.
11786         * common/pathstuff.h: Rename include guard.
11787         * common/observable.h: Rename include guard.
11788         * common/netstuff.h: Rename include guard.
11789         * common/job-control.h: Rename include guard.
11790         * common/host-defs.h: Rename include guard.
11791         * common/gdb_wait.h: Rename include guard.
11792         * common/gdb_vecs.h: Rename include guard.
11793         * common/gdb_unlinker.h: Rename include guard.
11794         * common/gdb_unique_ptr.h: Rename include guard.
11795         * common/gdb_tilde_expand.h: Rename include guard.
11796         * common/gdb_sys_time.h: Rename include guard.
11797         * common/gdb_string_view.h: Rename include guard.
11798         * common/gdb_splay_tree.h: Rename include guard.
11799         * common/gdb_setjmp.h: Rename include guard.
11800         * common/gdb_ref_ptr.h: Rename include guard.
11801         * common/gdb_optional.h: Rename include guard.
11802         * common/gdb_locale.h: Rename include guard.
11803         * common/gdb_assert.h: Rename include guard.
11804         * common/filtered-iterator.h: Rename include guard.
11805         * common/filestuff.h: Rename include guard.
11806         * common/fileio.h: Rename include guard.
11807         * common/environ.h: Rename include guard.
11808         * common/common-utils.h: Rename include guard.
11809         * common/common-types.h: Rename include guard.
11810         * common/common-regcache.h: Rename include guard.
11811         * common/common-inferior.h: Rename include guard.
11812         * common/common-gdbthread.h: Rename include guard.
11813         * common/common-exceptions.h: Rename include guard.
11814         * common/common-defs.h: Rename include guard.
11815         * common/common-debug.h: Rename include guard.
11816         * common/cleanups.h: Rename include guard.
11817         * common/buffer.h: Rename include guard.
11818         * common/btrace-common.h: Rename include guard.
11819         * common/break-common.h: Rename include guard.
11820         * cli/cli-utils.h: Rename include guard.
11821         * cli/cli-style.h: Rename include guard.
11822         * cli/cli-setshow.h: Rename include guard.
11823         * cli/cli-script.h: Rename include guard.
11824         * cli/cli-interp.h: Rename include guard.
11825         * cli/cli-decode.h: Rename include guard.
11826         * cli/cli-cmds.h: Rename include guard.
11827         * charset-list.h: Add include guard.
11828         * buildsym-legacy.h: Rename include guard.
11829         * bfin-tdep.h: Add include guard.
11830         * ax.h: Rename include guard.
11831         * arm-linux-tdep.h: Add include guard.
11832         * arm-fbsd-tdep.h: Add include guard.
11833         * arch/xtensa.h: Rename include guard.
11834         * arch/tic6x.h: Add include guard.
11835         * arch/i386.h: Add include guard.
11836         * arch/arm.h: Rename include guard.
11837         * arch/arm-linux.h: Rename include guard.
11838         * arch/arm-get-next-pcs.h: Rename include guard.
11839         * arch/amd64.h: Add include guard.
11840         * arch/aarch64-insn.h: Rename include guard.
11841         * arch-utils.h: Rename include guard.
11842         * annotate.h: Add include guard.
11843         * amd64-darwin-tdep.h: Rename include guard.
11844         * aarch64-linux-tdep.h: Add include guard.
11845         * aarch64-fbsd-tdep.h: Add include guard.
11846         * aarch32-linux-nat.h: Add include guard.
11847
11848 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11849
11850         * macrotab.c (macro_define_internal): New function that
11851         factorizes macro_define_object_internal and macro_define_function
11852         code.
11853         (macro_define_object_internal): Use macro_define_internal.
11854         (macro_define_function): Likewise.
11855
11856 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11857
11858         * macrocmd.c (extract_identifier): Return
11859         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11860         callers.
11861
11862 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11863
11864         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11865
11866 2019-02-05  Tom Tromey  <tom@tromey.com>
11867
11868         * target.c (target_stack::unpush): Move assertion earlier.
11869
11870 2019-01-30  Tom Tromey  <tom@tromey.com>
11871
11872         PR python/23615:
11873         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11874         (gdbpy_parse_and_eval): Likewise.
11875         * python/python-internal.h (gdbpy_allow_threads): New class.
11876
11877 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11878
11879         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11880         (aarch64_fbsd_fpregmap): Move earlier.
11881         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11882         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11883         instead of individual calls to trad_frame_set_reg_addr.
11884         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11885         earlier.
11886         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11887         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11888         instead of individual calls to trad_frame_set_reg_addr.
11889
11890 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11891
11892         * CONTRIBUTE: Replace contribution list with wiki link.
11893
11894 2019-01-25  Tom Tromey  <tom@tromey.com>
11895
11896         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11897
11898 2019-01-25  Tom Tromey  <tom@tromey.com>
11899
11900         * xtensa-linux-nat.c: Fix common/ includes.
11901         * xml-support.h: Fix common/ includes.
11902         * xml-support.c: Fix common/ includes.
11903         * x86-linux-nat.c: Fix common/ includes.
11904         * windows-nat.c: Fix common/ includes.
11905         * varobj.h: Fix common/ includes.
11906         * varobj.c: Fix common/ includes.
11907         * value.c: Fix common/ includes.
11908         * valops.c: Fix common/ includes.
11909         * utils.c: Fix common/ includes.
11910         * unittests/xml-utils-selftests.c: Fix common/ includes.
11911         * unittests/utils-selftests.c: Fix common/ includes.
11912         * unittests/unpack-selftests.c: Fix common/ includes.
11913         * unittests/tracepoint-selftests.c: Fix common/ includes.
11914         * unittests/style-selftests.c: Fix common/ includes.
11915         * unittests/string_view-selftests.c: Fix common/ includes.
11916         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11917         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11918         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11919         * unittests/rsp-low-selftests.c: Fix common/ includes.
11920         * unittests/parse-connection-spec-selftests.c: Fix common/
11921         includes.
11922         * unittests/optional-selftests.c: Fix common/ includes.
11923         * unittests/offset-type-selftests.c: Fix common/ includes.
11924         * unittests/observable-selftests.c: Fix common/ includes.
11925         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11926         * unittests/memrange-selftests.c: Fix common/ includes.
11927         * unittests/memory-map-selftests.c: Fix common/ includes.
11928         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11929         * unittests/function-view-selftests.c: Fix common/ includes.
11930         * unittests/environ-selftests.c: Fix common/ includes.
11931         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11932         * unittests/common-utils-selftests.c: Fix common/ includes.
11933         * unittests/cli-utils-selftests.c: Fix common/ includes.
11934         * unittests/array-view-selftests.c: Fix common/ includes.
11935         * ui-file.c: Fix common/ includes.
11936         * tui/tui-io.c: Fix common/ includes.
11937         * tracepoint.h: Fix common/ includes.
11938         * tracepoint.c: Fix common/ includes.
11939         * tracefile-tfile.c: Fix common/ includes.
11940         * top.h: Fix common/ includes.
11941         * top.c: Fix common/ includes.
11942         * thread.c: Fix common/ includes.
11943         * target/waitstatus.h: Fix common/ includes.
11944         * target/waitstatus.c: Fix common/ includes.
11945         * target.h: Fix common/ includes.
11946         * target.c: Fix common/ includes.
11947         * target-memory.c: Fix common/ includes.
11948         * target-descriptions.c: Fix common/ includes.
11949         * symtab.h: Fix common/ includes.
11950         * symfile.c: Fix common/ includes.
11951         * stap-probe.c: Fix common/ includes.
11952         * spu-linux-nat.c: Fix common/ includes.
11953         * sparc-nat.c: Fix common/ includes.
11954         * source.c: Fix common/ includes.
11955         * solib.c: Fix common/ includes.
11956         * solib-target.c: Fix common/ includes.
11957         * ser-unix.c: Fix common/ includes.
11958         * ser-tcp.c: Fix common/ includes.
11959         * ser-pipe.c: Fix common/ includes.
11960         * ser-base.c: Fix common/ includes.
11961         * selftest-arch.c: Fix common/ includes.
11962         * s12z-tdep.c: Fix common/ includes.
11963         * rust-exp.y: Fix common/ includes.
11964         * rs6000-aix-tdep.c: Fix common/ includes.
11965         * riscv-tdep.c: Fix common/ includes.
11966         * remote.c: Fix common/ includes.
11967         * remote-notif.h: Fix common/ includes.
11968         * remote-fileio.h: Fix common/ includes.
11969         * remote-fileio.c: Fix common/ includes.
11970         * regcache.h: Fix common/ includes.
11971         * regcache.c: Fix common/ includes.
11972         * record-btrace.c: Fix common/ includes.
11973         * python/python.c: Fix common/ includes.
11974         * python/py-type.c: Fix common/ includes.
11975         * python/py-inferior.c: Fix common/ includes.
11976         * progspace.h: Fix common/ includes.
11977         * producer.c: Fix common/ includes.
11978         * procfs.c: Fix common/ includes.
11979         * proc-api.c: Fix common/ includes.
11980         * printcmd.c: Fix common/ includes.
11981         * ppc-linux-nat.c: Fix common/ includes.
11982         * parser-defs.h: Fix common/ includes.
11983         * osdata.c: Fix common/ includes.
11984         * obsd-nat.c: Fix common/ includes.
11985         * nat/x86-linux.c: Fix common/ includes.
11986         * nat/x86-linux-dregs.c: Fix common/ includes.
11987         * nat/x86-dregs.h: Fix common/ includes.
11988         * nat/x86-dregs.c: Fix common/ includes.
11989         * nat/ppc-linux.c: Fix common/ includes.
11990         * nat/mips-linux-watch.h: Fix common/ includes.
11991         * nat/mips-linux-watch.c: Fix common/ includes.
11992         * nat/linux-waitpid.c: Fix common/ includes.
11993         * nat/linux-ptrace.h: Fix common/ includes.
11994         * nat/linux-ptrace.c: Fix common/ includes.
11995         * nat/linux-procfs.c: Fix common/ includes.
11996         * nat/linux-personality.c: Fix common/ includes.
11997         * nat/linux-osdata.c: Fix common/ includes.
11998         * nat/linux-namespaces.c: Fix common/ includes.
11999         * nat/linux-btrace.h: Fix common/ includes.
12000         * nat/linux-btrace.c: Fix common/ includes.
12001         * nat/fork-inferior.c: Fix common/ includes.
12002         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12003         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12004         * nat/aarch64-linux.c: Fix common/ includes.
12005         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12006         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12007         * namespace.h: Fix common/ includes.
12008         * mips-linux-tdep.c: Fix common/ includes.
12009         * minsyms.c: Fix common/ includes.
12010         * mi/mi-parse.h: Fix common/ includes.
12011         * mi/mi-main.c: Fix common/ includes.
12012         * mi/mi-cmd-env.c: Fix common/ includes.
12013         * memrange.h: Fix common/ includes.
12014         * memattr.c: Fix common/ includes.
12015         * maint.h: Fix common/ includes.
12016         * maint.c: Fix common/ includes.
12017         * main.c: Fix common/ includes.
12018         * machoread.c: Fix common/ includes.
12019         * location.c: Fix common/ includes.
12020         * linux-thread-db.c: Fix common/ includes.
12021         * linux-nat.c: Fix common/ includes.
12022         * linux-fork.c: Fix common/ includes.
12023         * inline-frame.c: Fix common/ includes.
12024         * infrun.c: Fix common/ includes.
12025         * inflow.c: Fix common/ includes.
12026         * inferior.h: Fix common/ includes.
12027         * inferior.c: Fix common/ includes.
12028         * infcmd.c: Fix common/ includes.
12029         * inf-ptrace.c: Fix common/ includes.
12030         * inf-child.c: Fix common/ includes.
12031         * ia64-linux-nat.c: Fix common/ includes.
12032         * i387-tdep.c: Fix common/ includes.
12033         * i386-tdep.c: Fix common/ includes.
12034         * i386-linux-tdep.c: Fix common/ includes.
12035         * i386-linux-nat.c: Fix common/ includes.
12036         * i386-go32-tdep.c: Fix common/ includes.
12037         * i386-fbsd-tdep.c: Fix common/ includes.
12038         * i386-fbsd-nat.c: Fix common/ includes.
12039         * guile/scm-type.c: Fix common/ includes.
12040         * guile/guile.c: Fix common/ includes.
12041         * go32-nat.c: Fix common/ includes.
12042         * gnu-nat.c: Fix common/ includes.
12043         * gdbthread.h: Fix common/ includes.
12044         * gdbarch-selftests.c: Fix common/ includes.
12045         * gdb_usleep.c: Fix common/ includes.
12046         * gdb_select.h: Fix common/ includes.
12047         * gdb_bfd.c: Fix common/ includes.
12048         * gcore.c: Fix common/ includes.
12049         * fork-child.c: Fix common/ includes.
12050         * findvar.c: Fix common/ includes.
12051         * fbsd-nat.c: Fix common/ includes.
12052         * event-top.c: Fix common/ includes.
12053         * event-loop.c: Fix common/ includes.
12054         * dwarf2read.c: Fix common/ includes.
12055         * dwarf2loc.c: Fix common/ includes.
12056         * dwarf2-frame.c: Fix common/ includes.
12057         * dwarf-index-cache.c: Fix common/ includes.
12058         * dtrace-probe.c: Fix common/ includes.
12059         * disasm-selftests.c: Fix common/ includes.
12060         * defs.h: Fix common/ includes.
12061         * csky-tdep.c: Fix common/ includes.
12062         * cp-valprint.c: Fix common/ includes.
12063         * cp-support.h: Fix common/ includes.
12064         * cp-support.c: Fix common/ includes.
12065         * corelow.c: Fix common/ includes.
12066         * completer.h: Fix common/ includes.
12067         * completer.c: Fix common/ includes.
12068         * compile/compile.c: Fix common/ includes.
12069         * compile/compile-loc2c.c: Fix common/ includes.
12070         * compile/compile-cplus-types.c: Fix common/ includes.
12071         * compile/compile-cplus-symbols.c: Fix common/ includes.
12072         * command.h: Fix common/ includes.
12073         * cli/cli-dump.c: Fix common/ includes.
12074         * cli/cli-cmds.c: Fix common/ includes.
12075         * charset.c: Fix common/ includes.
12076         * build-id.c: Fix common/ includes.
12077         * btrace.h: Fix common/ includes.
12078         * btrace.c: Fix common/ includes.
12079         * breakpoint.h: Fix common/ includes.
12080         * breakpoint.c: Fix common/ includes.
12081         * ax.h:
12082         (enum agent_op): Fix common/ includes.
12083         * ax-general.c (struct aop_map): Fix common/ includes.
12084         * ax-gdb.c: Fix common/ includes.
12085         * auxv.c: Fix common/ includes.
12086         * auto-load.c: Fix common/ includes.
12087         * arm-tdep.c: Fix common/ includes.
12088         * arch/riscv.c: Fix common/ includes.
12089         * arch/ppc-linux-common.c: Fix common/ includes.
12090         * arch/i386.c: Fix common/ includes.
12091         * arch/arm.c: Fix common/ includes.
12092         * arch/arm-linux.c: Fix common/ includes.
12093         * arch/arm-get-next-pcs.c: Fix common/ includes.
12094         * arch/amd64.c: Fix common/ includes.
12095         * arch/aarch64.c: Fix common/ includes.
12096         * arch/aarch64-insn.c: Fix common/ includes.
12097         * arch-utils.c: Fix common/ includes.
12098         * amd64-windows-tdep.c: Fix common/ includes.
12099         * amd64-tdep.c: Fix common/ includes.
12100         * amd64-sol2-tdep.c: Fix common/ includes.
12101         * amd64-obsd-tdep.c: Fix common/ includes.
12102         * amd64-nbsd-tdep.c: Fix common/ includes.
12103         * amd64-linux-tdep.c: Fix common/ includes.
12104         * amd64-linux-nat.c: Fix common/ includes.
12105         * amd64-fbsd-tdep.c: Fix common/ includes.
12106         * amd64-fbsd-nat.c: Fix common/ includes.
12107         * amd64-dicos-tdep.c: Fix common/ includes.
12108         * amd64-darwin-tdep.c: Fix common/ includes.
12109         * agent.c: Fix common/ includes.
12110         * ada-lang.h: Fix common/ includes.
12111         * ada-lang.c: Fix common/ includes.
12112         * aarch64-tdep.c: Fix common/ includes.
12113
12114 2019-01-25  Tom Tromey  <tom@tromey.com>
12115
12116         * common/create-version.sh: Use common/version.h.
12117
12118 2019-01-24  Pedro Alves  <palves@redhat.com>
12119
12120         * infrun.c (signal_stop, signal_print, signal_program)
12121         (signal_catch, signal_pass): Now arrays instead of pointers.
12122         (update_signals_program_target, do_target_resume)
12123         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12124         * linux-nat.c (linux_nat_target::pass_signals)
12125         (linux_nat_target::create_inferior, linux_nat_target::attach):
12126         Adjust.
12127         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12128         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12129         * procfs.c (procfs_target::pass_signals): Adjust.
12130         * record-full.c (record_full_target::resume): Adjust.
12131         * remote.c (remote_target::pass_signals)
12132         (remote_target::program_signals): Adjust.
12133         * target-debug.h (target_debug_print_signals): Now takes a
12134         gdb::array_view as parameter.  Adjust.
12135         * target.h (target_ops) <pass_signals, program_signals>: Replace
12136         pointer and length parameters with gdb::array_view.
12137         (target_pass_signals, target_program_signals): Likewise.
12138         * target-delegates.c: Regenerate.
12139
12140 2019-01-24  Pedro Alves  <palves@redhat.com>
12141
12142         * common/forward-scope-exit.h
12143         (forward_scope_exit::forward_scope_exit): Pass arguments to
12144         m_bind_function directly, instead of creating a std::bind and
12145         copying that.
12146
12147 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12148
12149         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12150         for static members.
12151         (pass_in_v_vfp_candidate): Likewise.
12152
12153 2019-01-23  Tom Tromey  <tom@tromey.com>
12154             Pedro Alves  <palves@redhat.com>
12155
12156         * regcache.c (class regcache_invalidator): Remove.
12157         (regcache::raw_write): Use make_scope_exit.
12158
12159 2019-01-23  Tom Tromey  <tom@tromey.com>
12160
12161         * ui-out.h (class ui_out_emit_type): Update comment.
12162
12163 2019-01-23  Tom Tromey  <tom@tromey.com>
12164
12165         * infrun.c (fetch_inferior_event): Update comment.
12166
12167 2019-01-23  Tom Tromey  <tom@tromey.com>
12168             Pedro Alves  <palves@redhat.com>
12169
12170         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12171         parameter.
12172         (fetch_inferior_event): Use SCOPE_EXIT.
12173
12174
12175 2019-01-23  Tom Tromey  <tom@tromey.com>
12176             Pedro Alves  <palves@redhat.com>
12177
12178         * infrun.c (disable_thread_events): Delete.
12179         (stop_all_threads): Use SCOPE_EXIT.
12180
12181 2019-01-23  Tom Tromey  <tom@tromey.com>
12182             Pedro Alves  <palves@redhat.com>
12183
12184         * symfile.c: Include forward-scope-exit.h.
12185         (clear_symtab_users_cleanup): Replace forward declaration with
12186         a FORWARD_SCOPE_EXIT.
12187         (syms_from_objfile_1): Use the forward_scope_exit and
12188         gdb::optional instead of cleanup_function.
12189         (reread_symbols): Use the forward_scope_exit instead of
12190         cleanup_function.
12191         (clear_symtab_users_cleanup): Remove function.
12192
12193 2019-01-23  Tom Tromey  <tom@tromey.com>
12194             Pedro Alves  <palves@redhat.com>
12195
12196         * linux-nat.c: Include scope-exit.h.
12197         (cleanup_target_stop): Remove.
12198         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12199         SCOPE_EXIT.
12200
12201 2019-01-23  Tom Tromey  <tom@tromey.com>
12202             Pedro Alves  <palves@redhat.com>
12203
12204         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12205         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12206
12207 2019-01-23  Tom Tromey  <tom@tromey.com>
12208             Andrew Burgess  <andrew.burgess@embecosm.com>
12209             Pedro Alves  <palves@redhat.com>
12210
12211         * infrun.c (fetch_inferior_event): Use scope_exit.
12212         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12213         * top.c (execute_command): Use scope_exit.
12214         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12215         * utils.c (do_bpstat_clear_actions_cleanup)
12216         (make_bpstat_clear_actions_cleanup): Remove.
12217
12218 2019-01-23  Tom Tromey  <tom@tromey.com>
12219             Pedro Alves  <palves@redhat.com>
12220
12221         * infrun.c: Include "common/scope-exit.h"
12222         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12223         (wait_for_inferior): Use SCOPE_EXIT.
12224         (fetch_inferior_event): Use scope_exit.
12225
12226 2019-01-23  Tom Tromey  <tom@tromey.com>
12227             Pedro Alves  <palves@redhat.com>
12228
12229         * breakpoint.c (create_breakpoint): Remove cleanup.
12230
12231 2019-01-23  Tom Tromey  <tom@tromey.com>
12232             Andrew Burgess  <andrew.burgess@embecosm.com>
12233             Pedro Alves  <palves@redhat.com>
12234
12235 2019-01-23  Pedro Alves  <palves@redhat.com>
12236
12237         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12238
12239 2019-01-23  Pedro Alves  <palves@redhat.com>
12240             Andrew Burgess  <andrew.burgess@embecosm.com>
12241
12242         * gdbthread.h: Include "common/forward-scope-exit.h".
12243         (scoped_finish_thread_state): Redefine custom class in terms of
12244         forward_scope_exit.
12245
12246 2019-01-23  Pedro Alves  <palves@redhat.com>
12247             Andrew Burgess  <andrew.burgess@embecosm.com>
12248
12249         * common/forward-scope-exit.h: New file.
12250
12251 2019-01-23  Pedro Alves  <palves@redhat.com>
12252             Andrew Burgess  <andrew.burgess@embecosm.com>
12253             Tom Tromey  <tom@tromey.com>
12254
12255         * common/scope-exit.h: New file.
12256
12257 2019-01-23  Pedro Alves  <palves@redhat.com>
12258
12259         * common/preprocessor.h (ESC): Rename to ...
12260         (ESC_PARENS): ... this.
12261         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12262         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12263
12264 2019-01-23  Tom Tromey  <tom@tromey.com>
12265
12266         * language.h (class scoped_switch_to_sym_language_if_auto):
12267         Initialize m_lang in both cases.
12268
12269 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12270
12271         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12272         with XCNEW.
12273
12274 2019-01-22  Tom Tromey  <tom@tromey.com>
12275
12276         * corelow.c: Do not include sys/file.h.
12277
12278 2019-01-22  Tom Tromey  <tom@tromey.com>
12279
12280         * tui/tui-wingeneral.h: Include gdb_curses.h.
12281
12282 2019-01-22  Tom Tromey  <tom@tromey.com>
12283
12284         * source-cache.h (class source_cache) <get_source_lines,
12285         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12286
12287 2019-01-22  Tom Tromey  <tom@tromey.com>
12288
12289         * remote-fileio.h (struct remote_target): Declare.
12290
12291 2019-01-22  Tom Tromey  <tom@tromey.com>
12292
12293         * python/py-arch.c: Do not include py-ref.h.
12294         * python/py-bpevent.c: Do not include py-ref.h.
12295         * python/py-cmd.c: Do not include py-ref.h.
12296         * python/py-continueevent.c: Do not include py-ref.h.
12297         * python/py-event.h: Do not include py-ref.h.
12298         * python/py-evtregistry.c: Do not include py-ref.h.
12299         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12300         * python/py-frame.c: Do not include py-ref.h.
12301         * python/py-framefilter.c: Do not include py-ref.h.
12302         * python/py-function.c: Do not include py-ref.h.
12303         * python/py-infevents.c: Do not include py-ref.h.
12304         * python/py-linetable.c: Do not include py-ref.h.
12305         * python/py-objfile.c: Do not include py-ref.h.
12306         * python/py-param.c: Do not include py-ref.h.
12307         * python/py-prettyprint.c: Do not include py-ref.h.
12308         * python/py-progspace.c: Do not include py-ref.h.
12309         * python/py-symbol.c: Do not include py-ref.h.
12310         * python/py-symtab.c: Do not include py-ref.h.
12311         * python/py-type.c: Do not include py-ref.h.
12312         * python/py-unwind.c: Do not include py-ref.h.
12313         * python/py-utils.c: Do not include py-ref.h.
12314         * python/py-value.c: Do not include py-ref.h.
12315         * python/py-varobj.c: Do not include py-ref.h.
12316         * python/py-xmethods.c: Do not include py-ref.h.
12317         * python/python.c: Do not include py-ref.h.
12318         * varobj.c: Do not include py-ref.h.
12319
12320 2019-01-22  Tom Tromey  <tom@tromey.com>
12321
12322         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12323         keyword for bcache.
12324
12325 2019-01-22  Tom Tromey  <tom@tromey.com>
12326
12327         * compile/compile-cplus-types.c: Remove a comment by #include.
12328
12329 2019-01-22  Tom Tromey  <tom@tromey.com>
12330
12331         * compile/gcc-c-plugin.h: Include compile-internal.h.
12332
12333 2019-01-22  Tom Tromey  <tom@tromey.com>
12334
12335         * stabsread.c (EXTERN): Do not define.
12336         (symnum, next_symbol_text_func, processing_gcc_compilation)
12337         (within_function, global_sym_chain, global_stabs)
12338         (previous_stab_code, this_object_header_files)
12339         (n_this_object_header_files)
12340         (n_allocated_this_object_header_files): Define.
12341         * stabsread.h (EXTERN): Never define.  Use "extern".
12342
12343 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12344
12345         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12346         history_value.
12347
12348 2019-01-21  Tom Tromey  <tom@tromey.com>
12349
12350         * ui-out.c: Fix includes.
12351         * tui/tui-source.c: Fix includes.
12352         * target.c: Fix includes.
12353         * remote.c: Fix includes.
12354         * regcache.c: Fix includes.
12355         * python/py-block.c: Fix includes.
12356         * printcmd.c: Fix includes.
12357         * or1k-tdep.c: Fix includes.
12358         * mi/mi-main.c: Fix includes.
12359         * m32r-tdep.c: Fix includes.
12360         * csky-tdep.c: Fix includes.
12361         * compile/compile-cplus-types.c: Fix includes.
12362         * cli/cli-interp.c: Fix includes.
12363
12364 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12365
12366         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12367         for padding.
12368
12369 2019-01-16  Tom Tromey  <tom@tromey.com>
12370
12371         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12372         earlier.
12373         (struct objfile) <msymbols_range>: Move from top level.
12374         <msymbols>: New method.
12375         (class objfile_msymbols): Remove.
12376         * symtab.c (default_collect_symbol_completion_matches_break_on):
12377         Update.
12378         * symmisc.c (dump_msymbols): Update.
12379         * stabsread.c (scan_file_globals): Update.
12380         * objc-lang.c (info_selectors_command, info_classes_command)
12381         (find_methods): Update.
12382         * minsyms.c (find_solib_trampoline_target): Update.
12383         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12384         * coffread.c (coff_symfile_read): Update.
12385         * ada-lang.c (ada_lookup_simple_minsym)
12386         (ada_collect_symbol_completion_matches): Update.
12387
12388 2019-01-16  Tom Tromey  <tom@tromey.com>
12389
12390         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12391         type.  Remove no-argument constructor.
12392         <iterator::operator++>: Simplify.
12393         <begin>: Update.
12394         <end>: Use minimal_symbol_count.
12395
12396 2019-01-16  Tom Tromey  <tom@tromey.com>
12397
12398         * objfiles.h (struct objfile) <psymtabs>: New method.
12399         (class objfile_psymtabs): Remove.
12400         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12401         typedef.
12402         <range>: New method.
12403         (require_partial_symbols): Change return type.
12404         * psymtab.c (require_partial_symbols)
12405         (psym_expand_symtabs_matching): Update.
12406         * mdebugread.c (parse_partial_symbols): Update.
12407         * dbxread.c (dbx_end_psymtab): Update.
12408
12409 2019-01-15  Tom Tromey  <tom@tromey.com>
12410
12411         * symtab.c (lookup_objfile_from_block)
12412         (lookup_symbol_in_objfile_symtabs)
12413         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12414         (find_line_symtab, info_sources_command)
12415         (default_collect_symbol_completion_matches_break_on)
12416         (make_source_files_completion_list): Update.
12417         * symmisc.c (print_objfile_statistics, dump_objfile)
12418         (maintenance_print_symbols, maintenance_info_symtabs)
12419         (maintenance_check_symtabs, maintenance_info_line_tables):
12420         Update.
12421         * source.c (select_source_symtab)
12422         (forget_cached_source_info_for_objfile): Update.
12423         * objfiles.h (class objfile_compunits): Remove.
12424         (struct objfile) <compunits_range>: New typedef.
12425         (compunits): New method.
12426         * objfiles.c (objfile_relocate1): Update.
12427         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12428         * maint.c (count_symtabs_and_blocks): Update.
12429         * linespec.c (iterate_over_all_matching_symtabs): Update.
12430         * cp-support.c (add_symbol_overload_list_qualified): Update.
12431         * coffread.c (coff_symtab_read): Update.
12432         * ada-lang.c (add_nonlocal_symbols)
12433         (ada_collect_symbol_completion_matches)
12434         (ada_add_global_exceptions): Update.
12435
12436 2019-01-15  Tom Tromey  <tom@tromey.com>
12437
12438         * progspace.h (program_space) <objfiles_safe_range>: New
12439         typedef.
12440         <objfiles_safe>: New method.
12441         * objfiles.h (class all_objfiles_safe): Remove.
12442         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12443         * jit.c (jit_inferior_exit_hook): Update.
12444
12445 2019-01-17  Tom Tromey  <tom@tromey.com>
12446
12447         * progspace.h (program_space) <objfiles_range>: New typedef.
12448         <objfiles>: New method.
12449         <objfiles_head>: Rename from objfiles.
12450         (object_files): Update.
12451         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12452         * guile/scm-pretty-print.c
12453         (ppscm_find_pretty_printer_from_objfiles): Update.
12454         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12455         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12456         Update.
12457         * python/py-progspace.c (pspy_get_objfiles): Update.
12458         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12459         Update.
12460         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12461         (objfpy_lookup_objfile_by_build_id): Update.
12462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12463         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12464         Update.
12465         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12466         (expand_symtab_containing_pc, lookup_objfile_from_block)
12467         (lookup_static_symbol, basic_lookup_transparent_type)
12468         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12469         (find_line_symtab, info_sources_command)
12470         (default_collect_symbol_completion_matches_break_on)
12471         (make_source_files_completion_list, find_main_name): Update.
12472         * symmisc.c (print_symbol_bcache_statistics)
12473         (print_objfile_statistics, maintenance_print_symbols)
12474         (maintenance_print_msymbols, maintenance_print_objfiles)
12475         (maintenance_info_symtabs, maintenance_check_symtabs)
12476         (maintenance_expand_symtabs, maintenance_info_line_tables):
12477         Update.
12478         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12479         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12480         (map_overlay_command, unmap_overlay_command)
12481         (simple_overlay_update, expand_symtabs_matching)
12482         (map_symbol_filenames): Update.
12483         * symfile-debug.c (set_debug_symfile): Update.
12484         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12485         Update.
12486         * source.c (select_source_symtab, forget_cached_source_info):
12487         Update.
12488         * solib.c (solib_read_symbols): Update.
12489         * solib-spu.c (append_ocl_sos): Update.
12490         * psymtab.c (maintenance_print_psymbols)
12491         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12492         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12493         * printcmd.c (info_symbol_command): Update.
12494         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12495         Update.
12496         * objfiles.h (class all_objfiles): Remove.
12497         * objfiles.c (have_partial_symbols, have_full_symbols)
12498         (have_minimal_symbols, qsort_cmp, update_section_map)
12499         (shared_objfile_contains_address_p)
12500         (default_iterate_over_objfiles_in_search_order): Update.
12501         * objc-lang.c (info_selectors_command, info_classes_command)
12502         (find_methods): Update.
12503         * minsyms.c (find_solib_trampoline_target): Update.
12504         * maint.c (maintenance_info_sections)
12505         (maintenance_translate_address, count_symtabs_and_blocks):
12506         Update.
12507         * main.c (captured_main_1): Update.
12508         * linux-thread-db.c (try_thread_db_load_from_pdir)
12509         (has_libpthread): Update.
12510         * linespec.c (iterate_over_all_matching_symtabs)
12511         (search_minsyms_for_name): Update.
12512         * jit.c (jit_find_objf_with_entry_addr): Update.
12513         * hppa-tdep.c (find_unwind_entry)
12514         (hppa_lookup_stub_minimal_symbol): Update.
12515         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12516         Update.
12517         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12518         (elf_gnu_ifunc_resolve_by_got): Update.
12519         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12520         * dwarf-index-write.c (save_gdb_index_command): Update.
12521         * cp-support.c (add_symbol_overload_list_qualified): Update.
12522         * breakpoint.c (create_overlay_event_breakpoint)
12523         (create_longjmp_master_breakpoint)
12524         (create_std_terminate_master_breakpoint)
12525         (create_exception_master_breakpoint): Update.
12526         * blockframe.c (find_pc_partial_function): Update.
12527         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12528         (ada_collect_symbol_completion_matches)
12529         (ada_add_global_exceptions): Update.
12530
12531 2019-01-17  Tom Tromey  <tom@tromey.com>
12532
12533         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12534         declare VEC.
12535         (solib_target_parse_libraries): Change return type.
12536         (library_list_start_segment, library_list_start_section)
12537         (library_list_end_library, library_list_start_library); Update.
12538         (solib_target_free_library_list): Remove.
12539         (solib_target_parse_libraries): Remove cleanup.  Change return
12540         type.
12541         (solib_target_current_sos): Update.
12542
12543 2019-01-17  Tom Tromey  <tromey@bapiya>
12544
12545         * valprint.c: Replace "the the" with "the".
12546         * symtab.c: Replace "the the" with "the".
12547         * solib.c: Replace "the the" with "the".
12548         * solib-dsbt.c: Replace "the the" with "the".
12549         * linespec.c: Replace "the the" with "the".
12550         * dwarf2loc.h: Replace "the the" with "the".
12551         * amd64-windows-tdep.c: Replace "the the" with "the".
12552         * aarch64-tdep.c: Replace "the the" with "the".
12553
12554 2019-01-16  Keith Seitz  <keiths@redhat.com>
12555
12556         PR gdb/23773
12557         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12558         <builder>: Rename to ..
12559         <m_builder>: ... this and make private.
12560         (dwarf2_cu::get_builder): New method.  Change all users of
12561         `builder' to use this method.
12562         (dwarf2_start_symtab): Move to ...
12563         (dwarf2_cu::start_symtab): ... here.  Update all callers
12564         (setup_type_unit_groups): Move to ...
12565         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12566         callers.
12567         (dwarf2_cu::reset_builder): New method.
12568         (process_full_compunit, process_full_type_unit): Use
12569         dwarf2_cu::reset_builder.
12570         (follow_die_offset): Record the ancestor CU if it is different
12571         from the followed DIE's CU.
12572         (follow_die_sig_1): Likewise.
12573
12574 2019-01-15  Tom Tromey  <tom@tromey.com>
12575
12576         * remote.c (class remote_state) <buf>: Now a char_vector.
12577         <buf_size>: Remove.
12578         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12579         parameter.
12580         (remote_target::getpkt_or_notif_sane_1)
12581         (remote_target::getpkt_sane)
12582         (remote_target::getpkt_or_notif_sane): Likewise.
12583         (class remote_target) <putpkt>: New overload.
12584         (remote_target::read_frame): Change type of "buf_p".  Remove
12585         sizeof_p parameter.
12586         (packet_ok): New overload.
12587         (packet_check_result): New overload.
12588         Update all uses.
12589
12590 2019-01-14  Tom Tromey  <tom@tromey.com>
12591
12592         * remote-notif.c (handle_notification, remote_notif_ack)
12593         (remote_notif_parse): Make "buf" const.
12594         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12595         const.
12596         (remote_notif_parse, remote_notif_ack, handle_notification):
12597         Likewise.
12598         * remote.c (remote_notif_stop_parse): Make "buf" const.
12599         (remote_target::remote_parse_stop_reply): Make "buf" const.
12600         (remote_notif_stop_ack): Make "buf" const.
12601
12602 2019-01-14  Tom Tromey  <tom@tromey.com>
12603
12604         * remote.c (remote_console_output): Make parameter const.
12605
12606 2019-01-14  Tom Tromey  <tom@tromey.com>
12607
12608         * target-debug.h (target_debug_print_signals): Constify.
12609         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12610         * procfs.c (procfs_target::pass_signals): Update.
12611         * linux-nat.c (linux_nat_target::pass_signals): Update.
12612         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12613         * target-delegates.c: Rebuild.
12614         * remote.c (remote_target::program_signals): Update.
12615         (remote_target::pass_signals): Update.
12616         * target.c (target_pass_signals): Constify argument.
12617         (target_program_signals): Likewise.
12618         * target.h (struct target_ops) <pass_signals, program_signals>:
12619         Constify argument.
12620         (target_pass_signals, target_program_signals): Constify argument.
12621
12622 2019-01-14  Tom Tromey  <tom@tromey.com>
12623
12624         PR tui/28819:
12625         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12626
12627 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12628
12629         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12630         field.
12631         * rs6000-tdep.c: Include reggroups.h.
12632         (IS_V_ALIAS_PSEUDOREG): Define.
12633         (rs6000_register_name): Return names for the "vX" aliases.
12634         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12635         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12636         aliases.  Call default_register_reggroup_p for all other
12637         pseudo-registers.
12638         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12639         New functions.
12640         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12641         Handle "vX" aliases.
12642         (v_alias_pseudo_register_collect): New function.
12643         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12644         (rs6000_gdbarch_init): Initialize "vX" aliases as
12645         pseudo-registers.  Restore registration of
12646         rs6000_pseudo_register_reggroup_p with
12647         set_tdesc_pseudo_register_reggroup_p.
12648
12649 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12650
12651         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12652         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12653         set_gdbarch_num_pseudo_regs.
12654
12655 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12656
12657         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12658         Remove arg prefixname, add do_set and do_show.
12659         Add member functions set_list and show_list.
12660         * cli/cli-style.c (class cli_style_option): Update accordingly.
12661         (style_set_list): Move to file scope.
12662         (style_show_list): Likewise.
12663         (set_style): Call help_list.
12664         (show_style): Call cmd_show_list.
12665         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12666         Update to use the new macro.
12667
12668 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12669
12670         * ada-lang.c (_initialize_ada_language): Expand the help text
12671         for the "catch exception" command.
12672
12673 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12674
12675         * symtab.c (matching_obj_sections): Initialize obj,
12676         declare it closer to its usage.
12677
12678 2019-01-10  Tom Tromey  <tom@tromey.com>
12679
12680         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12681         (basic_inf_threads_range): Remove.
12682         (inf_threads_range, inf_non_exited_threads_range)
12683         (safe_inf_threads_range): Use next_adapter.
12684
12685 2019-01-10  Keith Seitz  <keiths@redhat.com>
12686
12687         PR gdb/23712
12688         PR symtab/23010
12689         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12690         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12691
12692 2019-01-10  Keith Seitz  <keiths@redhat.com>
12693
12694         PR gdb/23712
12695         PR symtab/23010
12696         * dictionary.c (pending_to_vector): Remove.
12697         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12698         Remove _1 suffix, replacing functions of the same name.  Update
12699         all callers.
12700         (dict_create_hashed, dict_create_hashed_expandable)
12701         (dict_create_linear, dict_create_linear_expandable, dict_free)
12702         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12703         Make functions static.
12704
12705 2019-01-10  Keith Seitz  <keiths@redhat.com>
12706
12707         PR gdb/23712
12708         PR symtab/23010
12709         * dictionary.h (struct dictionary): Replace declaration with
12710         multidictionary.
12711         (dict_create_hashed, dict_create_hashed_expandable)
12712         (dict_create_linear, dict_create_linear_expandable)
12713         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12714         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12715         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12716         taking multidictionary argument.
12717         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12718         * block.h (struct block) <dict>: Change to multidictionary
12719         and rename `multidict'.
12720         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12721         symmisc.c: Update all dictionary references to multidictionary.
12722
12723 2019-01-10  Keith Seitz  <keiths@redhat.com>
12724
12725         PR gdb/23712
12726         PR symtab/23010
12727         * dictionary.c: Include unordered_map.
12728         (pending_to_vector): New function.
12729         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12730         Rewrite the non-"_1" functions to take vector instead
12731         of linked list.
12732         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12733         "new" _1 versions of the same name.
12734         (multidictionary): Define.
12735         (std::hash<enum language): New definition.
12736         (collate_pending_symbols_by_language, mdict_create_hashed)
12737         (mdict_create_hashed_expandable, mdict_create_linear)
12738         (mdict_create_linear_expandable, mdict_free)
12739         (find_language_dictionary, create_new_language_dictionary)
12740         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12741         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12742         (mdict_size, mdict_empty): New functions.
12743         * dictionary.h (mdict_iterator): Define.
12744
12745 2019-01-10  Pedro Alves  <palves@redhat.com>
12746
12747         * breakpoint.c (read_uploaded_action)
12748         (create_tracepoint_from_upload): Adjust to use
12749         gdb::unique_xmalloc_ptr.
12750         * ctf.c (ctf_write_uploaded_tp):
12751         (SET_ARRAY_FIELD): Use emplace_back.
12752         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12753         * tracefile-tfile.c (tfile_write_uploaded_tp):
12754         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12755         gdb::unique_xmalloc_ptr.
12756         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12757         at_string, cond_string, cmd_strings>: Replace char pointers
12758         with gdb::unique_xmalloc_ptr.
12759
12760 2019-01-10  Pedro Alves  <palves@redhat.com>
12761
12762         * solib-target.c (library_list_start_library): Don't xstrdup name.
12763
12764 2019-01-10  Pedro Alves  <palves@redhat.com>
12765
12766         * mdebugread.c (parse_partial_symbols): Use
12767         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12768
12769 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12770
12771         * linux-fork.c (scoped_switch_fork_info)
12772         <~scoped_switch_fork_info>: Fix incorrect variable name.
12773
12774 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12775
12776         * linux-fork.c (scoped_switch_fork_info)
12777         <scoped_switch_fork_info>: Make explicit.
12778         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12779
12780 2019-01-10  Tom Tromey  <tom@tromey.com>
12781
12782         * objfiles.h (objfile::reset_psymtabs): Update.
12783         * objfiles.c (objfile::objfile): Update.
12784         * psymtab.h (psymtab_storage::obstack): Update.
12785         (psymtab_storage::m_obstack): Use gdb::optional.
12786         (class psymtab_storage): Update comment.  Remove objfile
12787         parameter.
12788         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12789
12790 2019-01-10  Tom Tromey  <tom@tromey.com>
12791
12792         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12793         <free_psymtabs>: Now private.
12794         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12795         (allocate_psymtab): Use new method.
12796
12797 2019-01-10  Tom Tromey  <tom@tromey.com>
12798
12799         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12800         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12801         * mdebugread.c (parse_partial_symbols): Use
12802         allocate_dependencies.
12803         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12804         allocate_dependencies.
12805         (process_psymtab_comp_unit_reader)
12806         (build_type_psymtab_dependencies): Likewise.
12807         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12808
12809 2019-01-10  Tom Tromey  <tom@tromey.com>
12810
12811         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12812         PSYMBOL_SET_LANGUAGE.
12813         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12814
12815 2019-01-10  Tom Tromey  <tom@tromey.com>
12816
12817         * psymtab.h (psymtab_storage::obstack): New method.
12818         <m_obstack>: Rename from obstack; now private.
12819         * psymtab.c (psymtab_storage): Update.
12820         * dwarf2read.c (create_addrmap_from_index)
12821         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12822         Update.
12823
12824 2019-01-10  Tom Tromey  <tom@tromey.com>
12825
12826         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12827         * objfiles.h (objfile::reset_psymtabs): New method.
12828
12829 2019-01-10  Tom Tromey  <tom@tromey.com>
12830
12831         * symmisc.c (print_symbol_bcache_statistics): Update.
12832         (print_objfile_statistics): Update.
12833         * symfile.c (reread_symbols): Update.
12834         * psymtab.h (class psymtab_storage): New.
12835         * psymtab.c (psymtab_storage): New constructor.
12836         (~psymtab_storage): New destructor.
12837         (require_partial_symbols): Update.
12838         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12839         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12840         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12841         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12842         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12843         (start_psymtab_common, end_psymtab_common)
12844         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12845         (allocate_psymtab): Update.
12846         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12847         Update.
12848         (dump_psymtab_addrmap, maintenance_print_psymbols)
12849         (maintenance_check_psymtabs): Update.
12850         (class objfile_psymtabs): Move to objfiles.h.
12851         * psympriv.h (discard_psymtab): Now inline.
12852         (psymtab_discarder::psymtab_discarder): Update.
12853         (psymtab_discarder::~psymtab_discarder): Update.
12854         (ALL_OBJFILE_PSYMTABS): Rewrite.
12855         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12856         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12857         Remove fields.
12858         <partial_symtabs>: New field.
12859         (class objfile_psymtabs): Move from psymtab.h.  Update.
12860         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12861         psymbol_cache.
12862         (objfile::~objfile): Don't destroy psymbol_cache.
12863         * mdebugread.c (parse_partial_symbols): Update.
12864         * dwarf2read.c (create_addrmap_from_index)
12865         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12866         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12867         (add_partial_subprogram, dwarf2_ranges_read): Update.
12868         * dwarf-index-write.c (write_address_map)
12869         (write_one_signatured_type, recursively_write_psymbols)
12870         (class debug_names, class debug_names, write_psymtabs_to_index):
12871         Update.
12872
12873 2019-01-10  Tom Tromey  <tom@tromey.com>
12874
12875         * symtab.h (SYMBOL_SET_NAMES): Update.
12876         (symbol_set_names): Update.
12877         (MSYMBOL_SET_NAMES): Update.
12878         * symtab.c (symbol_set_names): Change argument to be an
12879         objfile_per_bfd_storage.
12880         * psymtab.c (add_psymbol_to_bcache): Update.
12881         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12882
12883 2019-01-10  Tom Tromey  <tom@tromey.com>
12884
12885         * symtab.c (create_demangled_names_hash): Change argument to be an
12886         objfile_per_bfd_storage.
12887         (symbol_set_names): Update.
12888
12889 2019-01-10  Tom Tromey  <tom@tromey.com>
12890
12891         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12892         init_psymbol_list.
12893         * psymtab.c (init_psymbol_list): Do nothing if already called.
12894         * psympriv.h (init_psymbol_list): Add comment.
12895         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12896         init_psymbol_list.
12897         * dbxread.c (dbx_symfile_read): Unconditionally call
12898         init_psymbol_list.
12899
12900 2019-01-10  Tom Tromey  <tom@tromey.com>
12901
12902         * xcoffread.c (scan_xcoff_symtab): Update.
12903         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12904         "where".
12905         * mdebugread.c (parse_partial_symbols)
12906         (handle_psymbol_enumerators): Update.
12907         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12908         * dbxread.c (read_dbx_symtab): Update.
12909         * psympriv.h (psymbol_placement): New enum.
12910         (add_psymbol_to_list): Update.
12911
12912 2019-01-10  Tom Tromey  <tom@tromey.com>
12913
12914         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12915         static_psymbols parameters.
12916         (scan_xcoff_symtab): Update.
12917         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12918         static_psymbols parameters.
12919         * psympriv.h (start_psymtab_common): Update.
12920         * mdebugread.c (parse_partial_symbols): Update.
12921         * dwarf2read.c (create_partial_symtab): Update.
12922         * dbxread.c (read_dbx_symtab): Update.
12923         (start_psymtab): Remove global_psymbols and static_psymbols
12924         parameters.
12925
12926 2019-01-10  Tom Tromey  <tom@tromey.com>
12927
12928         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12929         * psymtab.c (allocate_psymtab): Add comment.
12930         * psympriv.h (allocate_psymtab): Add comment.
12931         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12932         initializations.
12933         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12934
12935 2019-01-10  Tom Tromey  <tom@tromey.com>
12936
12937         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12938         Don't declare.
12939         * mipsread.c: Include mdebugread.h.
12940         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12941         Declare.
12942         * elfread.c: Include mdebugread.h.
12943
12944 2019-01-09  Tom Tromey  <tom@tromey.com>
12945
12946         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12947         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12948         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12949         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12950         (psym_lookup_symbol, psym_find_last_source_symtab)
12951         (psym_forget_cached_source_info, psym_print_stats)
12952         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12953         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12954         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12955         (psym_find_compunit_symtab_by_address)
12956         (maintenance_print_psymbols, maintenance_info_psymtabs)
12957         (maintenance_check_psymtabs): Use ranged for.
12958         * psymtab.h (class objfile_psymtabs): New.
12959         (require_partial_symbols): Return objfile_psymtabs.
12960         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12961
12962 2019-01-09  Tom Tromey  <tom@tromey.com>
12963
12964         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12965         (find_pc_mapped_section, list_overlays_command)
12966         (map_overlay_command, unmap_overlay_command)
12967         (simple_overlay_update): Use all_objfiles.
12968         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12969         * printcmd.c (info_symbol_command): Use all_objfiles.
12970         * objfiles.h (ALL_OBJSECTIONS): Remove.
12971         * maint.c (maintenance_translate_address): Use all_objfiles.
12972         * gcore.c (gcore_create_callback): Use all_objfiles.
12973         (objfile_find_memory_regions): Likewise.
12974
12975 2019-01-09  Tom Tromey  <tom@tromey.com>
12976
12977         * symtab.c (find_line_symtab, info_sources_command)
12978         (make_source_files_completion_list): Use objfile_compunits.
12979         * source.c (select_source_symtab): Use objfile_compunits.
12980         * objfiles.h (struct objfile): Update comment.
12981         (ALL_OBJFILES): Remove.
12982         (ALL_FILETABS): Remove.
12983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12984         objfile_compunits.
12985
12986 2019-01-09  Tom Tromey  <tom@tromey.com>
12987
12988         * symmisc.c (print_objfile_statistics, dump_objfile)
12989         (maintenance_print_symbols): Use compunit_filetabs.
12990         * source.c (forget_cached_source_info_for_objfile): Use
12991         compunit_filetabs.
12992         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12993         (ALL_FILETABS): Use compunit_filetabs.
12994         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12995         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12996
12997 2019-01-09  Tom Tromey  <tom@tromey.com>
12998
12999         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13000         (compunit_filetabs): New.
13001         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13002         compunit_filetabs.
13003         (info_sources_command, make_source_files_completion_list): Remove
13004         declaration.
13005         * symmisc.c (print_objfile_statistics, dump_objfile)
13006         (maintenance_print_symbols): Remove declaration.
13007         (maintenance_info_symtabs): Use compunit_filetabs.
13008         (maintenance_info_line_tables): Likewise.
13009         * source.c (select_source_symtab): Change local variable name.
13010         (forget_cached_source_info_for_objfile): Remove declaration.
13011         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13012         * objfiles.c (objfile_relocate1): Remove declaration.
13013         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13014         declaration.
13015         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13016         * coffread.c (coff_symtab_read): Remove declaration.
13017         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13018         compunit_filetabs.
13019
13020 2019-01-09  Tom Tromey  <tom@tromey.com>
13021
13022         * symtab.c (lookup_objfile_from_block)
13023         (find_pc_sect_compunit_symtab, search_symbols)
13024         (default_collect_symbol_completion_matches_break_on): Use
13025         objfile_compunits.
13026         * objfiles.h (ALL_COMPUNITS): Remove.
13027         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13028         * cp-support.c (add_symbol_overload_list_qualified): Use
13029         objfile_compunits.
13030         * ada-lang.c (ada_collect_symbol_completion_matches)
13031         (ada_add_global_exceptions): Use objfile_compunits.
13032
13033 2019-01-09  Tom Tromey  <tom@tromey.com>
13034
13035         * source.c (select_source_symtab)
13036         (forget_cached_source_info_for_objfile): Remove declaration.
13037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13038         declaration.
13039         * maint.c (count_symtabs_and_blocks): Remove declaration.
13040         * cp-support.c (add_symbol_overload_list_qualified): Remove
13041         declaration.
13042         * coffread.c (coff_symtab_read): Remove declaration.
13043         * symtab.c (lookup_symbol_in_objfile_symtabs)
13044         (basic_lookup_transparent_type_1): Use objfile_compunits.
13045         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13046         (info_sources_command, search_symbols)
13047         (default_collect_symbol_completion_matches_break_on)
13048         (make_source_files_completion_list): Remove declaration.
13049         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13050         (ada_collect_symbol_completion_matches)
13051         (ada_add_global_exceptions): Remove declaration.
13052         * linespec.c (iterate_over_all_matching_symtabs): Use
13053         objfile_compunits.
13054         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13055         (class objfile_compunits): New.
13056         (ALL_COMPUNITS): Use objfile_compunits.
13057         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13058         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13059         objfile_compunits.
13060         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13061
13062 2019-01-09  Tom Tromey  <tom@tromey.com>
13063
13064         * symtab.c (search_symbols)
13065         (default_collect_symbol_completion_matches_break_on): Use
13066         objfile_msymbols.
13067         * ada-lang.c (ada_lookup_simple_minsym)
13068         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13069         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13070         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13071         objfile_msymbols.
13072         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13073         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13074         * objc-lang.c (find_methods): Use objfile_msymbols.
13075         (info_selectors_command, info_classes_command): Likewise.
13076         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13077         * objfiles.h (class objfile_msymbols): New.
13078         (ALL_OBJFILE_MSYMBOLS): Remove.
13079         (ALL_MSYMBOLS): Remove.
13080
13081 2019-01-09  Tom Tromey  <tom@tromey.com>
13082
13083         * common/next-iterator.h (next_adapter): Add Iterator template
13084         parameter.
13085         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13086         (class all_objfiles_safe): New.
13087         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13088         * objfiles.c (put_objfile_before): Update comment.
13089         (add_separate_debug_objfile): Likewise.
13090         (free_all_objfiles): Use all_objfiles_safe.
13091         (objfile_purge_solibs): Likewise.
13092
13093 2019-01-09  Tom Tromey  <tom@tromey.com>
13094
13095         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13096         (expand_symtab_containing_pc, lookup_static_symbol)
13097         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13098         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13099         all_objfiles.
13100         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13101         * breakpoint.c (create_overlay_event_breakpoint)
13102         (create_longjmp_master_breakpoint)
13103         (create_std_terminate_master_breakpoint)
13104         (create_exception_master_breakpoint): Use all_objfiles.
13105         * linux-thread-db.c (try_thread_db_load_from_pdir)
13106         (has_libpthread): Use all_objfiles.
13107         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13108         * linespec.c (iterate_over_all_matching_symtabs)
13109         (search_minsyms_for_name): Use all_objfiles.
13110         * maint.c (maintenance_info_sections): Use all_objfiles.
13111         * main.c (captured_main_1): Use all_objfiles.
13112         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13113         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13114         * guile/scm-pretty-print.c
13115         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13116         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13117         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13118         (maintenance_print_msymbols): Use all_objfiles.
13119         * source.c (select_source_symtab): Use all_objfiles.
13120         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13121         * symfile.c (remove_symbol_file_command)
13122         (expand_symtabs_matching, map_symbol_filenames): Use
13123         all_objfiles.
13124         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13125         all_objfiles.
13126         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13127         * objc-lang.c (find_methods): Use all_objfiles.
13128         * objfiles.c (have_partial_symbols, have_full_symbols)
13129         (have_minimal_symbols, qsort_cmp)
13130         (default_iterate_over_objfiles_in_search_order): Use
13131         all_objfiles.
13132         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13133         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13134         (maintenance_check_psymtabs): Use all_objfiles.
13135         (ALL_PSYMTABS): Remove.
13136         * compile/compile-object-run.c (do_module_cleanup): Use
13137         all_objfiles.
13138         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13139         * cp-support.c (add_symbol_overload_list_qualified): Use
13140         all_objfiles.
13141         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13142         Use all_objfiles.
13143         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13144         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13145         all_objfiles.
13146         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13147         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13148         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13149         Uses all_objfiles.
13150         * solib.c (solib_read_symbols): Use all_objfiles
13151
13152 2019-01-09  Tom Tromey  <tom@tromey.com>
13153
13154         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13155         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13156         all_objfiles.
13157         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13158         * symmisc.c (print_symbol_bcache_statistics)
13159         (print_objfile_statistics, maintenance_print_objfiles)
13160         (maintenance_info_symtabs, maintenance_check_symtabs)
13161         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13162         all_objfiles.
13163         * source.c (forget_cached_source_info): Use all_objfiles.
13164         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13165         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13166         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13167         * objfiles.c (update_section_map): Use all_objfiles.
13168         (shared_objfile_contains_address_p): Likewise.
13169         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13170         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13171
13172 2019-01-09  Tom Tromey  <tom@tromey.com>
13173
13174         * common/next-iterator.h: New file.
13175         * objfiles.h (class all_objfiles): New.
13176         (struct objfile_iterator): New.
13177
13178 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13179
13180         * NEWS: Move the description of the changed "frame", "select-frame",
13181          and "info frame" commands to the Changed commands section.
13182
13183 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13184
13185         * gdbtypes.c (check_stub_method_group): Remove handling of old
13186         mangling schemes.
13187         * linespec.c (find_methods): Likewise.
13188         * stabsread.c (read_member_functions): Likewise.
13189         * valops.c (search_struct_method): Likewise.
13190         (value_struct_elt_for_reference): Likewise.
13191         * NEWS: Mention this change.
13192
13193 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13194
13195         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13196         print_source_lines.
13197         * source.c (print_source_lines_base): Update line number check.
13198         (print_source_lines): New function.
13199         (source_lines_range::source_lines_range): New function.
13200         * source.h (class source_lines_range): New class.
13201         (print_source_lines): New declaration.
13202
13203 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13204
13205         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13206
13207 2019-01-08  Tom Tromey  <tom@tromey.com>
13208             Simon Marchi  <simon.marchi@ericsson.com>
13209
13210         PR gdb/24060
13211         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13212         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13213         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13214         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13215         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13216         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13217
13218 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13219
13220         * source.c (select_source_symtab): Move header comment to
13221         declaration in source.h.
13222         (forget_cached_source_info_for_objfile): Likewise.
13223         (forget_cached_source_info): Likewise.
13224         (identify_source_line): Likewise.
13225         * source.h (identify_source_line): Move declaration from symtab.h
13226         and add comment from source.c
13227         (print_source_lines): Likewise.
13228         (forget_cached_source_info_for_objfile): Likewise.
13229         (forget_cached_source_info): Likewise.
13230         (select_source_symtab): Likewise.
13231         (enum print_source_lines_flag): Move definition from symtab.h.
13232         * symtab.h (identify_source_line): Move declaration to source.h.
13233         (print_source_lines): Likewise.
13234         (forget_cached_source_info_for_objfile): Likewise.
13235         (forget_cached_source_info): Likewise.
13236         (select_source_symtab): Likewise.
13237         (enum print_source_lines_flag): Move definition to source.h.
13238         * tui/tui-hooks.c: Add 'source.h' include.
13239
13240 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13241
13242         * source.c (print_source_lines_base): Handle requests to print
13243         reverse line number sequences, and guard against empty lines
13244         string.
13245
13246 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13247
13248         * source.c (print_source_lines_base): Fix skip of '\r' if next
13249         character is '\n'.
13250
13251 2019-01-06  Tom Tromey  <tom@tromey.com>
13252
13253         * c-exp.y (struct c_parse_state) <macro_original_text,
13254         expansion_obstack>: New member.
13255         (macro_original_text, expansion_obstack): Remove globals.
13256         (scan_macro_expansion, scanning_macro_expansion)
13257         (finished_macro_expansion): Update.
13258         (scan_macro_cleanup): Remove.
13259         (yylex, c_parse): Update.
13260
13261 2019-01-06  Tom Tromey  <tom@tromey.com>
13262
13263         * c-exp.y (struct c_parse_state) <strings>: New member.
13264         (operator_stoken): Update.
13265
13266 2019-01-06  Tom Tromey  <tom@tromey.com>
13267
13268         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13269         (union type_stack_elt) <typelist_val>: Now a pointer to
13270         std::vector.
13271         (type_stack_cleanup): Don't declare.
13272         (push_typelist): Update.
13273         * parse.c (pop_typelist): Return a std::vector.
13274         (push_typelist): Take a std::vector.
13275         (follow_types): Update.  Do not free args.
13276         (type_stack_cleanup): Remove.
13277         * c-exp.y (struct c_parse_state): New.
13278         (cpstate): New global.
13279         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13280         (nonempty_typelist): Update.
13281         (func_mod): Create a new vector.
13282         (c_parse): Create a c_parse_state.
13283         (check_parameter_typelist): Do not delete params.
13284         (function_method): Update.  Do not delete type_list.
13285
13286 2019-01-06  Tom Tromey  <tom@tromey.com>
13287
13288         PR gdb/28155:
13289         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13290         check_typedef.
13291         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13292         (print_return_value): Likewise.
13293
13294 2019-01-05  Tom Tromey  <tom@tromey.com>
13295
13296         * contrib/cleanup_check.py: Remove.
13297         * contrib/gcc-with-excheck: Remove.
13298         * contrib/exsummary.py: Remove.
13299         * contrib/excheck.py: Remove.
13300
13301 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13302
13303         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13304         NULL. Initialize tpprev to NULL instead of assigning it
13305         to NULL on the next statement.
13306         * windows-nat.c (windows_delete_thread): Remove check for
13307         main_thread_id before printing thread exit notifications.
13308         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13309         Remove thread ID check against main_thread_id.
13310         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13311         windows_delete_thread.
13312         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13313
13314 2019-01-04  Tom Tromey  <tom@tromey.com>
13315
13316         * compile/compile.c (_initialize_compile): Use upper case for
13317         metasyntactic variables.
13318         * symmisc.c (_initialize_symmisc): Use upper case for
13319         metasyntactic variables.
13320         * psymtab.c (_initialize_psymtab): Use upper case for
13321         metasyntactic variables.
13322         * demangle.c (demangle_command): Use upper case for metasyntactic
13323         variables.
13324         (_initialize_demangler): Likewise.
13325         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13326         variables.
13327
13328 2019-01-03  Tom Tromey  <tom@tromey.com>
13329
13330         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13331
13332 2019-01-03  Tom Tromey  <tom@tromey.com>
13333
13334         * python/py-symtab.c (salpy_str): Update.
13335         (struct salpy_sal_object) <symtab>: Now a PyObject.
13336         (salpy_dealloc): Update.
13337         (del_objfile_sal): Use gdbpy_ref.
13338
13339 2019-01-03  Tom Tromey  <tom@tromey.com>
13340
13341         * python/py-type.c (convert_field): Use new_reference.  Return
13342         gdbpy_ref.
13343         (make_fielditem): Return gdbpy_ref.
13344         (typy_fields): Update.
13345         (typy_getitem): Update.
13346         (field_name): Return gdbpy_ref.  Use new_reference.
13347         (typy_iterator_iternext): Update.
13348
13349 2019-01-03  Tom Tromey  <tom@tromey.com>
13350
13351         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13352
13353 2019-01-03  Tom Tromey  <tom@tromey.com>
13354
13355         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13356         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13357         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13358         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13359         (pspy_set_type_printers): Likewise.
13360         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13361         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13362         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13363         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13364         (objfpy_set_type_printers): Likewise.
13365
13366 2019-01-03  Tom Tromey  <tom@tromey.com>
13367
13368         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13369         (gdbpy_print_stack): Use gdbpy_err_fetch.
13370         * python/python-internal.h (class gdbpy_err_fetch): New class.
13371         (class gdbpy_enter) <m_error_type, m_error_value,
13372         m_error_traceback>: Remove.
13373         <m_error>: New member.
13374         (gdbpy_exception_to_string): Don't declare.
13375         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13376         * python/py-value.c (convert_value_from_python): Use
13377         gdbpy_err_fetch.
13378         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13379         gdbpy_exception_to_string.
13380         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13381         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13382         gdbpy_err_fetch.
13383
13384 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13385
13386         * linux-nat.c (delete_lwp_cleanup): Delete.
13387         (struct lwp_deleter): New struct.
13388         (lwp_info_up): New typedef.
13389         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13390         lwp_info_up.
13391
13392 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13393
13394         * linux-fork.c (class scoped_switch_fork_info): New class.
13395         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13396
13397 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13398
13399         * valops.c (find_overload_match): Remove use of null_cleanup, and
13400         calls to do_cleanups.
13401
13402 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13403
13404         * compile/compile-cplus-types.c
13405         (compile_cplus_instance::decl_name): Handle changes to
13406         cp_func_name.
13407         * cp-support.c (cp_func_name): Update header comment, update
13408         return type.
13409         * cp-support.h (cp_func_name): Update return type in declaration.
13410         * valops.c (find_overload_match): Move temp_func local to top
13411         level of function and change its type.  Use temp_func to hold and
13412         delete temporary string obtained from cp_func_name.
13413
13414 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13415
13416         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13417         gdb::char_vector, remove cleanup, and update uses of `msg`.
13418
13419 2019-01-03  Jim Wilson  <jimw@sifive.com>
13420
13421         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13422
13423 2019-01-02  Tom Tromey  <tom@tromey.com>
13424
13425         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13426         (tdesc_parse_xml): Remove cleanups.
13427         * target-descriptions.h (make_cleanup_free_target_description):
13428         Don't declare.
13429         (target_desc_deleter): New struct.
13430         (target_desc_up): New typedef.
13431         * target-descriptions.c (target_desc_deleter::operator()): Rename
13432         from free_target_description.
13433         (make_cleanup_free_target_description): Remove.
13434
13435 2019-01-02  Tom Tromey  <tom@tromey.com>
13436
13437         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13438         constructor, destructor.
13439         (linespec_parser): Remove typedef.
13440         (~linespec_parser): Rename from linespec_parser_delete.
13441         (linespec_lex_to_end, linespec_complete_label)
13442         (linespec_complete): Update.
13443         (decode_line_full): Remove cleanups.
13444         (decode_line_1): Update.
13445
13446 2019-01-02  Tom Tromey  <tom@tromey.com>
13447
13448         * python/python-internal.h (inferior_to_inferior_object): Change
13449         return type.
13450         * python/py-exitedevent.c (create_exited_event_object): Update.
13451         * python/py-inferior.c (inferior_to_inferior_object): Return
13452         gdbpy_ref.
13453         (python_new_inferior, python_inferior_deleted)
13454         (thread_to_thread_object, delete_thread_object)
13455         (build_inferior_list, gdbpy_selected_inferior): Update.
13456         * python/py-infthread.c (create_thread_object): Update.  Also fail
13457         if inferior_to_inferior_object fails.
13458
13459 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13460
13461         * inferior.h (class inferior) <displaced_step_state>: New field.
13462         * infrun.h (struct displaced_step_state): Move here from
13463         infrun.c.  Initialize fields, add constructor.
13464         <inf>: Remove field.
13465         <reset>: New method.
13466         * infrun.c (struct displaced_step_inferior_state): Move to
13467         infrun.h.
13468         (displaced_step_inferior_states): Remove.
13469         (get_displaced_stepping_state): Adust.
13470         (displaced_step_in_progress_any_inferior): Adjust.
13471         (displaced_step_in_progress_thread): Adjust.
13472         (displaced_step_in_progress): Adjust.
13473         (add_displaced_stepping_state): Remove.
13474         (get_displaced_step_closure_by_addr): Adjust.
13475         (remove_displaced_stepping_state): Remove.
13476         (infrun_inferior_exit): Call displaced_step_state.reset.
13477         (use_displaced_stepping): Don't check for NULL.
13478         (displaced_step_prepare_throw): Call
13479         get_displaced_stepping_state.
13480         (displaced_step_fixup): Don't check for NULL.
13481         (prepare_for_detach): Don't check for NULL.
13482
13483 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13484
13485         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13486          in case of call that did not complete.
13487
13488 2019-01-02  Andrey Utkin  <autkin@undo.io>
13489
13490         * symfile.c (find_separate_debug_file): Fix search of debug files for
13491         remote debuggee.
13492
13493 2019-01-02  Tom Tromey  <tom@tromey.com>
13494
13495         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13496         indentation.
13497         * python/py-frame.c (frapy_older): Remove cast.
13498         (frapy_newer): Likewise.
13499         * python/py-breakpoint.c (local_setattro): Remove cast.
13500         * python/py-arch.c (archpy_name): Remove local variable.
13501         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13502
13503 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13504
13505         * unittests/basic_string_view/element_access/char/empty.cc:
13506         Fix year range in copyright header.
13507
13508 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13509
13510         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13511         Delete.
13512         <operator==>: Update with for removed field.
13513         <hash>: Likewise.
13514         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13515         <isa_features>: ...this.
13516         <abi_features>: New field.
13517         (riscv_isa_flen): Update comment.
13518         (riscv_abi_xlen): New declaration.
13519         (riscv_abi_flen): New declaration.
13520         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13521         isa_features.
13522         (riscv_abi_xlen): New function.
13523         (riscv_isa_flen): Update to get answer from isa_features.
13524         (riscv_abi_flen): New function.
13525         (riscv_has_fp_abi): Update to get answer from abi_features.
13526         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13527         xlen and flen.
13528         (riscv_call_info) <xlen, flen>: Update comment.
13529         (riscv_call_arg_struct): Remove invalid assertions
13530         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13531         is removed.
13532         (riscv_gdbarch_init): Gather isa features and abi features
13533         separately, ensure both match on the gdbarch when reusing an old
13534         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13535         a target with 64-bit float hardware.
13536
13537 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13538
13539         * source.c (search_command_helper): Stop reverse search
13540         when line 1 has been searched.
13541
13542 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13543
13544         * record-full.c (record_full_base_target::close): Rewrite
13545         record_full_core_buf_list free logic.
13546
13547 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13548
13549         * break-catch-syscall.c (print_one_catch_syscall): xfree
13550         the last text.
13551
13552 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13553
13554         * top.c (print_gdb_version): Update Copyright year in version
13555         message.
13556
13557 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13558
13559         Update copyright year range in all GDB files.
13560
13561 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13562
13563         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13564
13565 For older changes see ChangeLog-2018.
13566 \f
13567 Local Variables:
13568 mode: change-log
13569 left-margin: 8
13570 fill-column: 74
13571 version-control: never
13572 coding: utf-8
13573 End:
13574