gdb/ChangeLog

   1 2019-03-18  Tom Tromey  <tromey@adacore.com>
   2
   3         * minsyms.c (minimal_symbol_reader::install): Remove call to
   4         obstack_blank.
   5
   6 2019-03-18  Pedro Alves  <palves@redhat.com>
   7
   8         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
   9         New globals.
  10         (apply_style): New, factored out from ...
  11         (apply_ansi_escape): ... this.  Handle reverse video mode.
  12         (tui_set_reverse_mode): New function.
  13         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  14         * tui/tui-winsource.c (tui_show_source_line): Use
  15         tui_set_reverse_mode instead of setting A_STANDOUT.
  16         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  17         New setter methods.
  18
  19 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  20
  21         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  22         Handle tabs.
  23
  24 2019-03-18  Tom Tromey  <tromey@adacore.com>
  25
  26         * ada-lang.c (empty_array): Add "high" parameter.
  27         (ada_evaluate_subexp): Update.
  28
  29 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  30
  31         * unittests/string_view-selftests.c: Define
  32         _initialize_string_view_selftests unconditionally.
  33
  34 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  35
  36         PR gdb/24350
  37         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  38
  39 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  40
  41         PR gdb/24351
  42         * windows-nat.c (display_selector): Fix format specifiers.
  43
  44 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  45
  46         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  47         tui_refill_source_window instead of tui_refresh_win, to update the
  48         current execution line.  This fixes redisplay of the current line
  49         when stepping through the code with "next" or "step".
  50
  51 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  52
  53         * source-cache.c (source_cache::get_source_lines): Call
  54         find_source_lines to initialize s->nlines.  This fixes vertical
  55         scrolling of TUI source window when the DOWN arrow is pressed.
  56
  57 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  58
  59         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  60         linux-thread-db.c (_initialize_thread_db): Likewise.
  61
  62 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  63
  64         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  65         wclrtoeol in tui_show_source_line".  This reverts changes made in
  66         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  67
  68 2019-03-15  Tom Tromey  <tom@tromey.com>
  69
  70         * symtab.h (struct minimal_symbol): Derive from
  71         general_symbol_info.
  72         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  73         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  74         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  75         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  76         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  77         (MSYMBOL_SEARCH_NAME): Update.
  78         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  79         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  80         * minsyms.c (minimal_symbol_reader::record_full): Update.
  81
  82 2019-03-15  Tom Tromey  <tom@tromey.com>
  83
  84         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  85
  86 2019-03-15  Tom Tromey  <tom@tromey.com>
  87
  88         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  89         unique_xmalloc_ptr.
  90         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  91         Update.
  92         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  93         (build_minimal_symbol_hash_tables)
  94         (minimal_symbol_reader::install): Update.
  95
  96 2019-03-15  Tom Tromey  <tom@tromey.com>
  97
  98         * symtab.c (create_demangled_names_hash): Update.
  99         (symbol_set_names): Update.
 100         * objfiles.h (struct objfile_per_bfd_storage)
 101         <demangled_names_hash>: Now an htab_up.
 102         * objfiles.c (objfile_per_bfd_storage): Simplify.
 103
 104 2019-03-15  Tom Tromey  <tom@tromey.com>
 105
 106         * objfiles.h (struct objfile_per_bfd_storage): Declare
 107         destructor.
 108         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 109         New.
 110         (get_objfile_bfd_data): Use new.  Don't initialize
 111         language_of_main.
 112         (free_objfile_per_bfd_storage): Remove.
 113         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 114
 115 2019-03-15  Tom Tromey  <tom@tromey.com>
 116
 117         * symfile.c (reread_symbols): Update.
 118         * objfiles.c (objfile::objfile): Update.
 119         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 120         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 121         comment.
 122         (minimal_symbol_reader::install): Update.
 123         (terminate_minimal_symbol_table): Remove.
 124         * jit.c (jit_object_close_impl): Update.
 125
 126 2019-03-15  Tom Tromey  <tom@tromey.com>
 127
 128         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 129         initializations.
 130
 131 2019-03-15  Tom Tromey  <tom@tromey.com>
 132
 133         * objfiles.h (struct objfile_per_bfd_storage)
 134         <demangled_hash_languages>: Now a bitset.
 135         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 136         (lookup_minimal_symbol): Update.
 137
 138 2019-03-15  Tom Tromey  <tom@tromey.com>
 139
 140         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 141         Don't return the symbol.
 142         * coffread.c (record_minimal_symbol): Use record_full.
 143
 144 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 145
 146         The MS-Windows port of ncurses fails to switch to a color pair if
 147         one or both of the colors are the implicit default colors.  This
 148         change records the default colors when TUI is initialized, and
 149         then specifies them explicitly when a color pair uses the default
 150         colors.  This allows color styling in TUI mode on MS-Windows.
 151
 152         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 153         ncurses_norm_attr.
 154         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 155         colors in ncurses_norm_attr.
 156         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 157         "none", replace it with the default color recorded in
 158         ncurses_norm_attr.
 159
 160 2019-03-14  Tom Tromey  <tromey@adacore.com>
 161
 162         * source-cache.h (class source_cache) <get_source_lines>: Return
 163         std::string.
 164         * source-cache.c (source_cache::extract_lines): Handle case where
 165         first_pos==npos.  Return std::string.
 166         (source_cache::get_source_lines): Update.
 167
 168 2019-03-14  Tom Tromey  <tromey@adacore.com>
 169
 170         * NEWS: Add item for "style sources" commands.
 171         * source-cache.c (source_cache::get_source_lines): Check
 172         source_styling.
 173         * cli/cli-style.c (source_styling): New global.
 174         (_initialize_cli_style): Add "style sources" commands.
 175         (show_style_sources): New function.
 176         * cli/cli-style.h (source_styling): Declare.
 177
 178 2019-03-14  Pedro Alves  <palves@redhat.com>
 179             Tom Tromey  <tromey@adacore.com>
 180
 181         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 182         * tui/tui-winsource.c (tui_refill_source_window): New function,
 183         from...
 184         (tui_horizontal_source_scroll): ... here.  Move some logic.
 185         * cli/cli-style.c (set_style_enabled): Notify new observable.
 186         * tui/tui-hooks.c (tui_redisplay_source): New function.
 187         (tui_attach_detach_observers): Attach or detach
 188         tui_redisplay_source.
 189         * observable.h (source_styling_changed): New observable.
 190         * observable.c: Define source_styling_changed observable.
 191
 192 2019-03-13  Tom Tromey  <tromey@adacore.com>
 193
 194         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 195         (i386_gnu_nat_target::store_registers): Update.
 196         * target-debug.h (target_debug_print_std_string): New macro.
 197         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 198         * windows-tdep.c (display_one_tib): Update.
 199         * tui/tui-stack.c (tui_make_status_line): Update.
 200         * top.c (print_inferior_quit_action): Update.
 201         * thread.c (thr_try_catch_cmd): Update.
 202         (add_thread_with_info): Update.
 203         (thread_target_id_str): Update.
 204         (thr_try_catch_cmd): Update.
 205         (thread_command): Update.
 206         (thread_find_command): Update.
 207         * record-btrace.c (record_btrace_target::info_record)
 208         (record_btrace_resume_thread, record_btrace_target::resume)
 209         (record_btrace_cancel_resume, record_btrace_step_thread)
 210         (record_btrace_target::wait, record_btrace_target::wait)
 211         (record_btrace_target::wait, record_btrace_target::stop): Update.
 212         * progspace.c (print_program_space): Update.
 213         * process-stratum-target.c
 214         (process_stratum_target::thread_address_space): Update.
 215         * linux-fork.c (linux_fork_mourn_inferior)
 216         (detach_checkpoint_command, info_checkpoints_command)
 217         (linux_fork_context): Update.
 218         (linux_fork_detach): Update.
 219         (class scoped_switch_fork_info): Update.
 220         (delete_checkpoint_command): Update.
 221         * infrun.c (follow_fork_inferior): Update.
 222         (follow_fork_inferior): Update.
 223         (proceed_after_vfork_done): Update.
 224         (handle_vfork_child_exec_or_exit): Update.
 225         (follow_exec): Update.
 226         (displaced_step_prepare_throw): Update.
 227         (displaced_step_restore): Update.
 228         (start_step_over): Update.
 229         (resume_1): Update.
 230         (clear_proceed_status_thread): Update.
 231         (proceed): Update.
 232         (print_target_wait_results): Update.
 233         (do_target_wait): Update.
 234         (context_switch): Update.
 235         (stop_all_threads): Update.
 236         (restart_threads): Update.
 237         (finish_step_over): Update.
 238         (handle_signal_stop): Update.
 239         (switch_back_to_stepped_thread): Update.
 240         (keep_going_pass_signal): Update.
 241         (print_exited_reason): Update.
 242         (normal_stop): Update.
 243         * inferior.c (inferior_pid_to_str): Change return type.
 244         (print_selected_inferior): Update.
 245         (add_inferior): Update.
 246         (detach_inferior): Update.
 247         * dummy-frame.c (fprint_dummy_frames): Update.
 248         * dcache.c (dcache_info_1): Update.
 249         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 250         (btrace_fetch, btrace_clear): Update.
 251         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 252         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 253         type.
 254         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 255         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 256         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 257         * gdbarch.c, gdbarch.h: Rebuild.
 258         * gdbarch.sh (core_pid_to_str): Change return type.
 259         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 260         return type.
 261         (windows_nat_target::pid_to_str): Change return type.
 262         (windows_delete_thread): Update.
 263         (windows_nat_target::attach): Update.
 264         (windows_nat_target::files_info): Update.
 265         * target-delegates.c: Rebuild.
 266         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 267         return type.
 268         (sol_thread_target::pid_to_str): Change return type.
 269         * remote.c (class remote_target) <pid_to_str>: Change return
 270         type.
 271         (remote_target::pid_to_str): Change return type.
 272         (extended_remote_target::attach, remote_target::remote_stop_ns)
 273         (remote_target::remote_notif_remove_queued_reply)
 274         (remote_target::push_stop_reply, remote_target::disable_btrace):
 275         Update.
 276         (extended_remote_target::attach): Update.
 277         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 278         type.
 279         (gdbsim_target::pid_to_str): Change return type.
 280         * ravenscar-thread.c (struct ravenscar_thread_target)
 281         <pid_to_str>: Change return type.
 282         (ravenscar_thread_target::pid_to_str): Change return type.
 283         * procfs.c (class procfs_target) <pid_to_str>: Change return
 284         type.
 285         (procfs_target::pid_to_str): Change return type.
 286         (procfs_target::attach): Update.
 287         (procfs_target::detach): Update.
 288         (procfs_target::fetch_registers): Update.
 289         (procfs_target::store_registers): Update.
 290         (procfs_target::wait): Update.
 291         (procfs_target::files_info): Update.
 292         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 293         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 294         return type.
 295         (nto_procfs_target::pid_to_str): Change return type.
 296         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 297         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 298         return type.
 299         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 300         (exit_lwp): Update.
 301         (attach_proc_task_lwp_callback, get_detach_signal)
 302         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 303         (linux_nat_target::resume, wait_lwp, stop_callback)
 304         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 305         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 306         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 307         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 308         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 309         type.
 310         (inf_ptrace_target::attach): Update.
 311         (inf_ptrace_target::files_info): Update.
 312         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 313         type.
 314         (go32_nat_target::pid_to_str): Change return type.
 315         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 316         (gnu_nat_target::wait): Update.
 317         (gnu_nat_target::wait): Update.
 318         (gnu_nat_target::resume): Update.
 319         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 320         (fbsd_nat_target::wait): Update.
 321         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 322         type.
 323         (darwin_nat_target::attach): Update.
 324         * corelow.c (class core_target) <pid_to_str>: Change return type.
 325         (core_target::pid_to_str): Change return type.
 326         * target.c (normal_pid_to_str): Change return type.
 327         (default_pid_to_str): Likewise.
 328         (target_pid_to_str): Change return type.
 329         (target_translate_tls_address): Update.
 330         (target_announce_detach): Update.
 331         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 332         return type.
 333         (bsd_uthread_target::pid_to_str): Change return type.
 334         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 335         type.
 336         (bsd_kvm_target::pid_to_str): Change return type.
 337         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 338         return type.
 339         (aix_thread_target::pid_to_str): Change return type.
 340         * target.h (struct target_ops) <pid_to_str>: Change return type.
 341         (target_pid_to_str, normal_pid_to_str): Likewise.
 342         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 343         type.
 344         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 345         type.
 346         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 347         return type.
 348         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 349         type.
 350         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 351         type.
 352         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 353         return type.
 354
 355 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 356
 357         * NEWS: Mention that the new default MI version is 3.  Mention
 358         changes to the output of commands and events that deal with
 359         multi-location breakpoints.
 360         * breakpoint.c: Include "mi/mi-out.h".
 361         (print_one_breakpoint): Change output syntax if using MI version
 362         >= 3.
 363         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 364         New.
 365         (mi_multi_location_breakpoint_output_fixed): New.
 366         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 367         (mi_cmd_fix_multi_location_breakpoint_output): New.
 368         (mi_multi_location_breakpoint_output_fixed): New.
 369         * mi/mi-cmds.c (mi_cmds): Register command
 370         -fix-multi-location-breakpoint-output.
 371         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 372         interpreter "mi".
 373
 374 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 375
 376         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 377         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 378         instantiate mi_ui_out based on interpreter name.
 379         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 380         * mi/mi-main.c (mi_load_progress): Likewise.
 381
 382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 383
 384         * NEWS: Combine separate "New targets" sections for 8.3.
 385
 386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 387
 388         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 389         (ppcfbsd_init_abi): Install gdbarch
 390         "fetch_tls_load_module_address" and "get_thread_local_address"
 391         methods.
 392
 393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 394
 395         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 396         (riscv_fbsd_init_abi): Install gdbarch
 397         "fetch_tls_load_module_address" and "get_thread_local_address"
 398         methods.
 399
 400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 401
 402         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 403         (i386fbsd_init_abi): Install gdbarch
 404         "fetch_tls_load_module_address" and "get_thread_local_address"
 405         methods.
 406
 407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 408
 409         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 410         (amd64fbsd_init_abi): Install gdbarch
 411         "fetch_tls_load_module_address" and "get_thread_local_address"
 412         methods.
 413
 414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 415
 416         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 417         (struct fbsd_pspace_data): New type.
 418         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 419         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 420         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 421         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 422         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 423
 424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 425
 426         * gdbtypes.c (lookup_struct_elt): New function.
 427         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 428         * gdbtypes.h (struct struct_elt): New type.
 429         (lookup_struct_elt): New prototype.
 430
 431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 432
 433         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 434         remove disabled code block.
 435
 436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 437
 438         * gdbarch.sh (get_thread_local_address): New method.
 439         * gdbarch.h, gdbarch.c: Regenerate.
 440         * target.c (target_translate_tls_address): Use
 441         gdbarch_get_thread_local_address if present instead of
 442         target::get_thread_local_address.
 443
 444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 445
 446         * target.h (target::get_thread_local_address): Update comment.
 447
 448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 449
 450         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 451         objfile->separate_debug_objfile_backlink if not NULL.
 452
 453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 454
 455         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 456         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 457         (amd64bsd_store_inferior_registers): Likewise.
 458         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 459         Enable segment base registers.
 460         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 461         PT_GETFSBASE and PT_GETGSBASE.
 462         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 463         PT_SETGSBASE.
 464         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 465         segment base registers.
 466         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 467
 468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 469
 470         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 471         Update calls to i386_target_description to add 'segments'
 472         parameter.
 473         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 474         add segment base registers.
 475         * arch/i386.c (i386_create_target_description): Add 'segments'
 476         parameter to enable segment base registers.
 477         * arch/i386.h (i386_create_target_description): Likewise.
 478         * features/i386/32bit-segments.xml: New file.
 479         * features/i386/32bit-segments.c: Generate.
 480         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 481         call to i386_target_description to add 'segments' parameter.
 482         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 483         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 484         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 485         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 486         if feature is present.
 487         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 488         Add 'segments' parameter to call to i386_target_description.
 489         (i386_target_description): Add 'segments' parameter to enable
 490         segment base registers.
 491         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 492         to call to i386_target_description.
 493         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 494         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 495         Define I386_NUM_REGS.
 496         (i386_target_description): Add 'segments' parameter to enable
 497         segment base registers.
 498
 499 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 500
 501         PR/24325
 502         * source-cache.c: #undef open and close, to avoid unresolved
 503         externals during linking.
 504
 505 2019-03-12  Tom Tromey  <tromey@adacore.com>
 506
 507         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 508         const.  Add initializers.
 509         (_initialize_remote): Don't initialize ptid globals.
 510
 511 2019-03-12  Pedro Alves  <palves@redhat.com>
 512
 513         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 514
 515 2019-03-12  Pedro Alves  <palves@redhat.com>
 516
 517         * cp-name-parser.y (main): Remove unused 'len' variable.
 518
 519 2019-03-12  Tom Tromey  <tromey@adacore.com>
 520
 521         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 522         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 523
 524 2019-03-12  Tom Tromey  <tromey@adacore.com>
 525
 526         * linux-nat.c (iterate_over_lwps): Update.
 527         (stop_callback): Remove parameter.
 528         (stop_wait_callback, detach_callback, resume_set_callback)
 529         (select_singlestep_lwp_callback, set_ignore_sigint)
 530         (status_callback, resumed_callback, resume_clear_callback)
 531         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 532         data parameter.
 533         (linux_nat_target::detach, linux_nat_target::resume)
 534         (linux_stop_and_wait_all_lwps, select_event_lwp)
 535         (linux_nat_filter_event, linux_nat_wait_1)
 536         (linux_nat_target::kill, linux_nat_target::stop)
 537         (linux_nat_target::stop): Update.
 538         (linux_nat_resume_callback): Change type.
 539         (resume_stopped_resumed_lwps, count_events_callback)
 540         (select_event_lwp_callback): Likewise.
 541         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 542         * arm-linux-nat.c (struct update_registers_data): Remove.
 543         (update_registers_callback): Change type.
 544         (arm_linux_insert_hw_breakpoint1): Update.
 545         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 546         parameter.
 547         (x86_linux_dr_set_addr): Update.
 548         (x86_linux_dr_set_control): Update.
 549         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 550         (iterate_over_lwps): Use gdb::function_view.
 551         * nat/aarch64-linux-hw-point.c (struct
 552         aarch64_dr_update_callback_param): Remove.
 553         (debug_reg_change_callback): Change type.
 554         (aarch64_notify_debug_reg_change): Update.
 555         * s390-linux-nat.c (s390_refresh_per_info): Update.
 556
 557 2019-03-11  Tom Tromey  <tromey@adacore.com>
 558
 559         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 560         redundant assignment to "this_cu".
 561
 562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 563
 564         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 565
 566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 567
 568         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 569         from...
 570         (rank_one_type): ... this.
 571
 572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 573
 574         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 575         from...
 576         (rank_one_type): ... this.
 577
 578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 579
 580         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 581         from...
 582         (rank_one_type): ... this.
 583
 584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 585
 586         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 587         from...
 588         (rank_one_type): ... this.
 589
 590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 591
 592         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 593         from...
 594         (rank_one_type): ... this.
 595
 596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 597
 598         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 599         from...
 600         (rank_one_type): ... this.
 601
 602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 603
 604         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 605         from...
 606         (rank_one_type): ... this.
 607
 608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 609
 610         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 611         from...
 612         (rank_one_type): ... this.
 613
 614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 615
 616         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 617         from...
 618         (rank_one_type): ... this.
 619
 620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 621
 622         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 623         from...
 624         (rank_one_type): ... this.
 625
 626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 627
 628         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 629         from...
 630         (rank_one_type): ... this.
 631
 632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 633
 634         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 635         from...
 636         (rank_one_type): ... this.
 637
 638 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 639
 640         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 641         inferior-events' shows the example events.
 642
 643 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 644
 645         Support styling on native MS-Windows console
 646
 647         PR/24315
 648         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 649         on MS-Windows if $TERM is not defined.
 650
 651         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 652
 653         * posix-hdep.c (gdb_console_fputs):
 654         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 655         functions.
 656         * ui-file.h (gdb_console_fputs): Add prototype.
 657
 658         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 659         back to fputs only if the former returns zero.
 660
 661 2019-03-07  Tom Tromey  <tom@tromey.com>
 662
 663         * symmisc.c (print_symbol_bcache_statistics): Update.
 664         (print_objfile_statistics): Update.
 665         * symfile.c (allocate_symtab): Update.
 666         * stabsread.c: Don't include bcache.h.
 667         * psymtab.h (struct psymbol_bcache): Don't declare.
 668         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 669         (psymbol_bcache_init, psymbol_bcache_free)
 670         (psymbol_bcache_get_bcache): Don't declare.
 671         * psymtab.c (struct psymbol_bcache): Remove.
 672         (psymtab_storage::psymtab_storage): Update.
 673         (psymtab_storage::~psymtab_storage): Update.
 674         (psymbol_bcache_init, psymbol_bcache_free)
 675         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 676         (add_psymbol_to_bcache): Update.
 677         (allocate_psymtab): Update.
 678         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 679         macro_cache>: No longer pointers.
 680         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 681         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 682         * macrotab.c (macro_bcache): Update.
 683         * macroexp.c: Don't include bcache.h.
 684         * gdbtypes.c (check_types_worklist): Update.
 685         (types_deeply_equal): Remove TRY/CATCH.  Update.
 686         * elfread.c (elf_symtab_read): Update.
 687         * dwarf2read.c: Don't include bcache.h.
 688         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 689         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 690         (print_bcache_statistics, bcache_memory_used): Don't declare.
 691         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 692         methods.  Rename all data members.
 693         * bcache.c (struct bcache): Move to bcache.h.
 694         (bcache::expand_hash_table): Rename from expand_hash_table.
 695         (bcache): Remove.
 696         (bcache::insert): Rename from bcache_full.
 697         (bcache::compare): Rename from bcache_compare.
 698         (bcache_xmalloc): Remove.
 699         (bcache::~bcache): Rename from bcache_xfree.
 700         (bcache::print_statistics): Rename from print_bcache_statistics.
 701         (bcache::memory_used): Rename from bcache_memory_used.
 702
 703 2019-03-07  Pedro Alves  <palves@redhat.com>
 704
 705         * infrun.c (normal_stop): Also check for
 706         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 707
 708 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * f-lang.c (value_from_host_double): Moved to...
 711         * value.c (value_from_host_double): ...here.
 712         * value.h (value_from_host_double): Declare.
 713         * guile/scm-math.c (vlscm_convert_typed_number): Use
 714         value_from_host_double.
 715         (vlscm_convert_number): Likewise.
 716         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 717         * python/py-value.c (convert_value_from_python): Likewise.
 718
 719 2019-03-06  Tom Tromey  <tom@tromey.com>
 720
 721         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 722
 723 2019-03-06  Tom Tromey  <tom@tromey.com>
 724
 725         * utils.h (free_current_contents): Don't declare.
 726         * utils.c (free_current_contents): Remove.
 727
 728 2019-03-06  Tom Tromey  <tom@tromey.com>
 729
 730         * top.c (quit_force): Update.
 731         * main.c (captured_command_loop): Update.
 732         * common/new-op.c (operator new): Update.
 733         * common/common-exceptions.c (struct catcher)
 734         <save_cleanup_chain>: Remove member.
 735         (exceptions_state_mc_init): Update.
 736         (exception_try_scope_entry): Return nullptr.
 737         (exception_try_scope_exit, exception_rethrow)
 738         (throw_exception_sjlj, throw_exception_cxx): Update.
 739         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 740         (all_cleanups, do_cleanups, discard_cleanups)
 741         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 742         (restore_cleanups, restore_final_cleanups): Don't declare.
 743         (do_final_cleanups): Remove parameter.
 744         * common/cleanups.c (cleanup_chain, make_cleanup)
 745         (make_cleanup_dtor, all_cleanups, do_cleanups)
 746         (discard_my_cleanups, discard_cleanups)
 747         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 748         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 749         (null_cleanup): Remove.
 750         (do_final_cleanups): Remove parameter.
 751
 752 2019-03-06  Tom Tromey  <tom@tromey.com>
 753
 754         * remote.c (remote_target::remote_parse_stop_reply): Use
 755         unique_xmalloc_ptr.
 756
 757 2019-03-06  Tom Tromey  <tom@tromey.com>
 758
 759         * stabsread.c (struct stabs_field_info): Rename from field_info.
 760         <list, fnlist>: Add initializers.
 761         <obstack>: New member.
 762         (read_member_functions, read_struct_fields, read_baseclasses):
 763         Allocate on obstack.  Don't use cleanups.
 764         (read_one_struct_field, read_member_functions, read_struct_fields)
 765         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 766         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 767         (read_struct_type): Update.
 768
 769 2019-03-06  Tom Tromey  <tom@tromey.com>
 770
 771         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 772         * common/filestuff.h (make_cleanup_close): Don't declare.
 773         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 774         Remove.
 775
 776 2019-03-06  Tom Tromey  <tom@tromey.com>
 777
 778         * solib-aix.c: Use make_scope_exit.
 779
 780 2019-03-06  Tom Tromey  <tom@tromey.com>
 781
 782         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 783         Use make_scope_exit.
 784
 785 2019-03-06  Tom Tromey  <tom@tromey.com>
 786
 787         * solib-svr4.c (disable_probes_interface): Remove parameter.
 788         (svr4_handle_solib_event): Use make_scope_exit.
 789
 790 2019-03-06  Tom Tromey  <tom@tromey.com>
 791
 792         * remote.c (struct stop_reply_deleter): Remove.
 793         (stop_reply_up): Update.
 794         (struct stop_reply): Derive from notif_event.  Don't typedef.
 795         <regcache>: Now a std::vector.
 796         (stop_reply_xfree): Remove.
 797         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 798         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 799         (remote_target::discard_pending_stop_replies): Use delete.
 800         (remote_target::remote_parse_stop_reply): Update.
 801         (remote_target::process_stop_reply): Update.
 802         * remote-notif.h (struct notif_event): Add virtual destructor.
 803         Remove "dtr" member.
 804         (struct notif_client) <alloc_event>: Return a unique_ptr.
 805         (notif_event_xfree): Don't declare.
 806         (notif_event_up): New typedef.
 807         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 808         (notif_event_xfree, do_notif_event_xfree): Remove.
 809         (remote_notif_state_xfree): Update.
 810
 811 2019-03-06  Tom Tromey  <tom@tromey.com>
 812
 813         * infrun.c (displaced_step_clear_cleanup): Now a
 814         forward_scope_exit type.
 815         (displaced_step_prepare_throw): Update.
 816         (displaced_step_fixup): Update.
 817
 818 2019-03-06  Tom Tromey  <tom@tromey.com>
 819
 820         * inferior.h (class inferior): Update comment.
 821         * gdbthread.h (class thread_info): Update comment.
 822
 823 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 824             Tom Tromey  <tom@tromey.com>
 825
 826         * stabsread.h (struct stab_section_list): Remove.
 827         (coffstab_build_psymtabs): Update.
 828         * dbxread.c (symbuf_sections): Now a std::vector.
 829         (sect_idx): New global.
 830         (fill_symbuf): Update.
 831         (coffstab_build_psymtabs): Change type of stabsects parameter.
 832         Update.
 833         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 834         std::vector.
 835         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 836         (coff_locate_sections): Update.
 837         (coff_symfile_read): Remove cleanups.  Update.
 838         (init_stringtab): Add storage parameter.
 839         (free_stringtab, free_stringtab_cleanup): Remove.
 840         (init_lineno): Add storage parameter.
 841         (free_linetab, free_linetab_cleanup): Remove.
 842
 843 2019-03-06  Pedro Alves  <palves@redhat.com>
 844
 845         * linux-fork.c (fork_info::clobber_regs): Delete.
 846         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 847         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 848         comment.  Adjust.
 849         (scoped_switch_fork_info::scoped_switch_fork_info)
 850         (checkpoint_command, linux_fork_context): Adjust
 851         fork_save_infrun_state calls.
 852
 853 2019-03-06  Pedro Alves  <palves@redhat.com>
 854
 855         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 856         (inf_has_multiple_threads): Return 'bool' and rewrite using
 857         inferior_info::threads().
 858
 859 2019-03-06  Pedro Alves  <palves@redhat.com>
 860
 861         * linux-fork.c: Include <list>.
 862         (fork_list): Now a std::list instance.
 863         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 864         (forks_exist_p, find_last_fork): Adjust.
 865         (new_fork): Delete.
 866         (one_fork_p): New.
 867         (add_fork): Adjust.
 868         (free_fork): Delete, folded into fork_info::~fork_info().
 869         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 870         Adjust.
 871         (init_fork_list): Delete.
 872         (linux_fork_killall, linux_fork_mourn_inferior)
 873         (linux_fork_detach, info_checkpoints_command): Adjust.
 874         (_initialize_linux_fork): No longer call init_fork_list.
 875
 876 2019-03-06  Pedro Alves  <palves@redhat.com>
 877
 878         * linux-fork.c (new_fork): New, split out of ...
 879         (add_fork): ... this.  Return void.  Move "first fork" special
 880         case from here, to ...
 881         (checkpoint_command): ... here.
 882         * linux-linux.h (add_fork): Return void.
 883
 884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 887
 888 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 889             Chris January  <chris.january@arm.com>
 890             David Lecomber  <david.lecomber@arm.com>
 891
 892         * f-exp.y: New token, UNOP_INTRINSIC.
 893         (exp): New pattern using UNOP_INTRINSIC token.
 894         (f77_keywords): Add 'abs' keyword.
 895         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 896         (value_from_host_double): New function.
 897         (evaluate_subexp_f): Support UNOP_ABS.
 898
 899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 902         types.
 903
 904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 907         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 908         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 909
 910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 911
 912         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 913
 914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 915             Chris January  <chris.january@arm.com>
 916
 917         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 918         * f-exp.y: Define 'KIND' token.
 919         (exp): New pattern for KIND expressions.
 920         (ptype): Handle types with a kind extension.
 921         (direct_abs_decl): Extend to spot kind extensions.
 922         (f77_keywords): Add 'kind' to the list.
 923         (push_kind_type): New function.
 924         (convert_to_kind_type): New function.
 925         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 926         * parse.c (operator_length_standard): Likewise.
 927         * parser-defs.h (enum type_pieces): Add tp_kind.
 928         * std-operator.def: Add UNOP_KIND.
 929
 930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * f-exp.y (f_parse): Set yydebug.
 933
 934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * f-lang.c (evaluate_subexp_f): New function.
 937         (exp_descriptor_f): New global.
 938         (f_language_defn): Use exp_descriptor_f instead of
 939         exp_descriptor_standard.
 940
 941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * f-exp.y (struct token): Add comments.
 944         (dot_ops): Remove uppercase versions and the end marker.
 945         (f77_keywords): Likewise.
 946         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 947         entries in the dot_ops array are case insensitive, and use
 948         strncasecmp to compare strings.  Also some whitespace cleanup in
 949         this area.  Similar for the f77_keywords array, except entries in
 950         this list might be case sensitive.
 951
 952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * f-exp.y (struct f77_boolean_val): Add comments.
 955         (boolean_values): Remove uppercase versions, and end marker.
 956         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 957         and use strncasecmp to achieve case insensitivity.  Additionally,
 958         perform whitespace cleanup around this code.
 959
 960 2019-03-06  Tom Tromey  <tromey@adacore.com>
 961
 962         * remote-sim.c (gdbsim_target_open): Use result of
 963         gdb_argv::release.
 964
 965 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 966         Dirk Schubert  <dirk.schubert@arm.com>
 967         Chris January  <chris.january@arm.com>
 968
 969         * eval.c (evaluate_subexp_standard): Call Fortran argument
 970         wrapping logic.
 971         * f-lang.c (struct value): A value which can be passed into a
 972         Fortran function call.
 973         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 974         where appropriate.
 975         (struct type): Value ready for a Fortran function call.
 976         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 977         is needed.
 978         * f-lang.h (fortran_argument_convert): Declaration.
 979         (fortran_preserve_arg_pointer): Declaration.
 980         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 981
 982 2019-03-05  Tom Tromey  <tromey@adacore.com>
 983
 984         * python/py-prettyprint.c (print_string_repr): Remove #if.
 985         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 986
 987 2019-03-05  Tom Tromey  <tromey@adacore.com>
 988
 989         * target.c (the_dummy_target): Move later.  Change type to
 990         "dummy_target".
 991         (initialize_targets): Don't initialize the_dummy_target.
 992
 993 2019-03-05  Tom Tromey  <tromey@adacore.com>
 994
 995         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 996         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 997
 998 2019-03-05  Tom Tromey  <tromey@adacore.com>
 999
1000         * windows-nat.c (windows_nat_target::attach)
1001         (windows_nat_target::detach): Don't call gdb_flush.
1002         * valprint.c (generic_val_print, val_print, val_print_string):
1003         Don't call gdb_flush.
1004         * utils.c (defaulted_query): Don't call gdb_flush.
1005         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1006         * target.c (target_announce_detach): Don't call gdb_flush.
1007         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1008         * remote.c (extended_remote_target::attach): Don't call
1009         gdb_flush.
1010         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1011         * printcmd.c (do_examine): Don't call gdb_flush.
1012         (info_display_command): Don't call gdb_flush.
1013         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1014         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1015         * memattr.c (info_mem_command): Don't call gdb_flush.
1016         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1017         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1018         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1019         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1020         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1021         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1022         (gnu_nat_target::detach): Don't call gdb_flush.
1023         * f-valprint.c (f_val_print): Don't call gdb_flush.
1024         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1025         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1026         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1027         gdb_flush.
1028         * c-valprint.c (c_val_print): Don't call gdb_flush.
1029         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1030
1031 2019-03-05  Tom Tromey  <tromey@adacore.com>
1032
1033         * varobj.c (update_dynamic_varobj_children): Update.
1034         (install_default_visualizer): Use reset, not release.
1035         * value.c (set_internalvar): Update.
1036         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1037         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1038         ATTRIBUTE_UNUSED_RESULT.
1039
1040 2019-03-05  Tom Tromey  <tromey@adacore.com>
1041
1042         * remote.c (class scoped_remote_fd) <release>: Add
1043         ATTRIBUTE_UNUSED_RESULT.
1044
1045 2019-03-05  Tom Tromey  <tromey@adacore.com>
1046
1047         * macroexp.c (struct macro_buffer) <release>: Add
1048         ATTRIBUTE_UNUSED_RESULT.
1049
1050 2019-03-05  Tom Tromey  <tromey@adacore.com>
1051
1052         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1053         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1054         ATTRIBUTE_UNUSED_RESULT.
1055
1056 2019-03-05  Tom Tromey  <tromey@adacore.com>
1057
1058         * common/scoped_fd.h (class scoped_fd) <release>: Add
1059         ATTRIBUTE_UNUSED_RESULT.
1060
1061 2019-03-05  Tom Tromey  <tromey@adacore.com>
1062
1063         * parser-defs.h (struct parser_state) <release>: Add
1064         ATTRIBUTE_UNUSED_RESULT.
1065
1066 2019-03-05  Tom Tromey  <tromey@adacore.com>
1067
1068         * utils.h (class gdb_argv) <release>: Add
1069         ATTRIBUTE_UNUSED_RESULT.
1070         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1071
1072 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1073
1074         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1075         for-loop range, to avoid compiler warnings.
1076
1077         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1078         avoid compiler warnings about unused variables.
1079
1080         * NEWS: Mention end of support for native debugging on MS-Windows
1081         before XP.
1082
1083         PR gdb/24292
1084         * common/netstuff.c:
1085         * gdbserver/gdbreplay.c
1086         * gdbserver/remote-utils.c:
1087         * ser-tcp.c:
1088         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1089         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1090         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1091         'getaddrinfo' and 'freeaddrinfo' were not available before
1092         Windows XP, and mingw.org's MinGW headers by default define
1093         _WIN32_WINNT to 0x500.
1094
1095 2019-03-01  Gary Benson <gbenson@redhat.com>
1096
1097         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1098
1099 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1100             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1101
1102         PR gdb/8527
1103         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1104         set_sigint_trap, clear_sigint_trap.
1105
1106 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1107
1108         * target.c (target_detach): Clear the regcache and the
1109         frame cache.
1110
1111 2019-02-27  Pedro Alves  <palves@redhat.com>
1112
1113         * utils.c (set_screen_size): When we cap the height/width sizes,
1114         tweak the corresponding command variable to show "unlimited":
1115
1116 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1117             Pedro Alves  <palves@redhat.com>
1118
1119         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1120         before calling rl_set_screen_size.
1121
1122 2019-02-27  Tom Tromey  <tromey@adacore.com>
1123
1124         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1125         define.
1126         * python/py-value.c: Remove Python 2.4 workaround.
1127         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1128         workaround.
1129         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1130         Python 2.4 workaround.
1131         * python/python-internal.h: Remove Python 2.4 comment.
1132         (Py_ssize_t): Don't define.
1133         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1134         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1135         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1136         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1137         * python/python.c (do_start_initialization): Remove Python 2.4
1138         workaround.
1139         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1140         (print_children): Remove Python 2.4 workaround.
1141         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1142         workaround.
1143         (CHARBUFFERPROC_NAME): Remove.
1144         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1145         Python 2.4 workaround.
1146
1147 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1148
1149         * NEWS: Note minimum Python version.
1150
1151 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1152
1153         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1154         code from these functions.  Remove corresponding ifdefs.  Use
1155         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1156         Remove gotos and target of gotos.
1157         (infpy_search_memory): Likewise.
1158
1159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1162         (hppa_gdbarch_init): Don't register deleted functions with
1163         gdbarch.
1164
1165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1168         (h8300_unwind_sp): Delete.
1169         (h8300_dummy_id): Delete.
1170         (h8300_gdbarch_init): Don't register deleted functions with
1171         gdbarch.
1172
1173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1176         (ft32_unwind_pc): Delete.
1177         (ft32_unwind_sp): Delete.
1178         (ft32_gdbarch_init): Don't register deleted functions with
1179         gdbarch.
1180
1181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1184         (frv_unwind_pc): Delete.
1185         (frv_unwind_sp): Delete.
1186         (frv_gdbarch_init): Don't register deleted functions with
1187         gdbarch.
1188
1189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1192         (riscv_unwind_pc): Delete.
1193         (riscv_unwind_sp): Delete.
1194         (riscv_gdbarch_init): Don't register deleted functions with
1195         gdbarch.
1196
1197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1200         (csky_unwind_pc): Delete.
1201         (csky_unwind_sp): Delete.
1202         (csky_gdbarch_init): Don't register deleted functions with
1203         gdbarch.
1204
1205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1208         (cris_unwind_pc): Delete.
1209         (cris_unwind_sp): Delete.
1210         (cris_gdbarch_init): Don't register deleted functions with
1211         gdbarch.
1212
1213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1216         (bfin_unwind_pc): Delete.
1217         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1218
1219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1222         (arm_unwind_pc): Delete.
1223         (arm_unwind_sp): Delete.
1224         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1225
1226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1229         (arc_unwind_pc): Delete.
1230         (arc_unwind_sp): Delete.
1231         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1232
1233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1236         (alpha_unwind_pc): Delete.
1237         (alpha_gdbarch_init): Don't register deleted functions with
1238         gdbarch.
1239
1240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1243         (aarch64_unwind_pc): Delete.
1244         (aarch64_unwind_sp): Delete.
1245         (aarch64_gdbarch_init): Don't register deleted functions with
1246         gdbarch.
1247
1248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * gdbtypes.c (type_align): Don't consider static members when
1251         computing structure alignment.
1252
1253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1256         return 0 for other types.
1257         * arch-utils.c (default_type_align): Always return 0.
1258         * gdbarch.h: Regenerate.
1259         * gdbarch.sh (type_align): Extend comment.
1260         * gdbtypes.c (type_align): Add additional comments, always call
1261         gdbarch_type_align before applying the default rules.
1262         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1263         generic code will then apply a suitable default.
1264         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1265         types, return 0 for other types.
1266
1267 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1268
1269         * NEWS: Create a new section for the next release branch.
1270         Rename the section of the current branch, now that it has
1271         been cut.
1272
1273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1274
1275         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1276         * version.in: Bump version to 8.3.50.DATE-git.
1277
1278 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1279
1280         * aix-thread.c (ptid_cmp): Remove unused variable.
1281         (get_signaled_thread): Likewise.
1282         (store_regs_user_thread): Likewise.
1283         (store_regs_kernel_thread): Likewise.
1284         (fetch_regs_kernel_thread): Remove shadowed variable.
1285
1286 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * features/riscv/32bit-cpu.xml: Add register numbers.
1289         * features/riscv/32bit-fpu.c: Regenerate.
1290         * features/riscv/32bit-fpu.xml: Add register numbers.
1291         * features/riscv/64bit-cpu.xml: Add register numbers.
1292         * features/riscv/64bit-fpu.c: Regenerate.
1293         * features/riscv/64bit-fpu.xml: Add register numbers.
1294
1295 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1296
1297         * NEWS: Mention two argument form of gdb.Value constructor.
1298         * python/py-value.c (convert_buffer_and_type_to_value): New
1299         function.
1300         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1301         Add support for handling an optional second argument.  Call
1302         convert_buffer_and_type_to_value as appropriate.
1303         * python/python-internal.h (Py_buffer_deleter): New struct.
1304         (Py_buffer_up): New typedef.
1305
1306 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1307
1308         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1309         instead of releasing ownership.
1310
1311 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1312
1313         * dwarf2read.c (open_and_init_dwp_file): Call
1314         elf_numsections instead of bfd_count_sections to initialize
1315         dwp_file->num_sections.
1316
1317 2019-02-25  Tom Tromey  <tromey@adacore.com>
1318
1319         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1320
1321 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1322
1323         * gcore.in: Add '--readnever' option when invoking GDB.
1324
1325 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1326
1327         * MAINTAINERS: Update my email address.
1328
1329 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * build-id.c (build_id_to_debug_bfd_1): New function.
1332         (build_id_to_debug_bfd): Look for separate debug file in
1333         sysroot.
1334
1335 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * gdbarch.sh: Update the copyright year range that is placed into
1338         generated files.
1339
1340 2019-02-22  Keith Seitz  <keiths@redhat.com>
1341
1342         PR symtab/23853
1343         * linespec.c (create_sals_line_offset): Search for the default
1344         symtab's filename instead of its fullname.
1345
1346 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1347
1348         * NEWS: Update style defaults.
1349
1350 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1351
1352         * main.c (captured_main_1): Disable styling in batch mode.
1353
1354 2019-02-20  Tom Tromey  <tom@tromey.com>
1355
1356         * symtab.c (symtab_symbol_info): Fix typos.
1357
1358 2019-02-20  Tom Tromey  <tromey@adacore.com>
1359
1360         * findcmd.c (_initialize_mem_search): Use upper case for
1361         metasyntactic variables.
1362
1363 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1364
1365         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1366         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1367
1368 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1369
1370         * top.h (source_file_name): Change to std::string.
1371         * top.c (source_file_name): Likewise.
1372         (command_line_input): Adjust.
1373         * cli/cli-script.c (script_from_file): Adjust.
1374
1375 2019-02-19  Tom Tromey  <tromey@adacore.com>
1376
1377         * ravenscar-thread.c
1378         (ravenscar_thread_target::update_thread_list): Don't call
1379         ada_build_task_list.
1380         * ada-lang.h (ada_build_task_list): Don't declare.
1381         * ada-tasks.c (struct ada_tasks_inferior_data)
1382         <task_list_valid_p>: Now bool.
1383         (read_known_tasks, ada_task_list_changed)
1384         (ada_tasks_invalidate_inferior_data): Update.
1385         (read_known_tasks_array): Return bool.
1386         (read_known_tasks_list): Likewise.
1387         (read_known_tasks): Return void.
1388         (ada_build_task_list): Now static.
1389
1390 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1393         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1394
1395 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1396
1397         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1398         variant for ada_tasks_pspace_data_handle and
1399         ada_tasks_inferior_data_handle.
1400         (ada_tasks_pspace_data_cleanup): New function.
1401         (ada_tasks_inferior_data_cleanup): New function.
1402
1403 2019-02-17  Tom Tromey  <tom@tromey.com>
1404
1405         * macrotab.h (macro_source_fullname): Return a std::string.
1406         * macrotab.c (macro_include, check_for_redefinition)
1407         (macro_undef, macro_lookup_definition, foreach_macro)
1408         (foreach_macro_in_scope): Update.
1409         (macro_source_fullname): Return a std::string.
1410         * macrocmd.c (show_pp_source_pos): Update.
1411
1412 2019-02-17  Tom Tromey  <tom@tromey.com>
1413
1414         * macrocmd.c (show_pp_source_pos): Style the file names.
1415
1416 2019-02-17  Tom Tromey  <tom@tromey.com>
1417
1418         PR tui/24197:
1419         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1420
1421 2019-02-17  Tom Tromey  <tom@tromey.com>
1422
1423         * ada-lang.c (user_select_syms): Use filtered printing.
1424         * utils.c (wrap_style): New global.
1425         (desired_style): Remove.
1426         (emit_style_escape): Add stream parameter.
1427         (set_output_style, reset_terminal_style, prompt_for_continue):
1428         Update.
1429         (flush_wrap_buffer): Only flush gdb_stdout.
1430         (wrap_here): Set wrap_style.
1431         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1432         treat escape sequences as a character.  Change when wrap buffer is
1433         flushed.
1434         (fputs_styled): Do not set the output style when the default is
1435         requested.
1436         * ui-style.h (struct ui_file_style) <is_default>: New method.
1437         * source.c (print_source_lines_base): Emit escape sequences in one
1438         piece.
1439
1440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1441
1442         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1443         integers and enumeration types.
1444
1445 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1446
1447         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1448         instead of lookup_symbol_in_language
1449         (do_exact_match): New function.
1450         (ada_get_symbol_name_matcher): Return do_exact_match when
1451         doing a verbatim match.
1452
1453 2019-02-15  Tom Tromey  <tromey@adacore.com>
1454
1455         * ravenscar-thread.c (ravenscar_thread_target::resume)
1456         (ravenscar_thread_target::wait): Special case wildcard requests.
1457
1458 2019-02-15  Tom Tromey  <tromey@adacore.com>
1459
1460         * ravenscar-thread.c (base_ptid): Remove.
1461         (struct ravenscar_thread_target) <close>: New method.
1462         <m_base_ptid>: New member.
1463         <update_inferior_ptid, active_task, task_is_currently_active,
1464         runtime_initialized>: Declare methods.
1465         <ravenscar_thread_target>: Add constructor.
1466         (ravenscar_thread_target::task_is_currently_active)
1467         (ravenscar_thread_target::update_inferior_ptid)
1468         (ravenscar_runtime_initialized): Rename.  Now methods.
1469         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1470         (ravenscar_thread_target::update_thread_list): Update.
1471         (ravenscar_thread_target::active_task): Now method.
1472         (ravenscar_thread_target::store_registers)
1473         (ravenscar_thread_target::prepare_to_store)
1474         (ravenscar_thread_target::prepare_to_store)
1475         (ravenscar_thread_target::mourn_inferior): Update.
1476         (ravenscar_inferior_created): Use "new" to create target.
1477         (ravenscar_thread_target::get_ada_task_ptid): Update.
1478         (_initialize_ravenscar): Don't initialize base_ptid.
1479         (ravenscar_ops): Remove global.
1480
1481 2019-02-15  Tom Tromey  <tromey@adacore.com>
1482
1483         * target.h (push_target): Declare new overload.
1484         * target.c (push_target): New overload, taking an rvalue reference.
1485         * remote.c (remote_target::open_1): Use push_target overload.
1486         * corelow.c (core_target_open): Use push_target overload.
1487
1488 2019-02-15  Tom Tromey  <tromey@adacore.com>
1489
1490         * ravenscar-thread.c (is_ravenscar_task)
1491         (ravenscar_task_is_currently_active): Return bool.
1492         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1493         (_initialize_ravenscar): Remove "(void)".
1494         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1495         Return bool.
1496
1497 2019-02-15  Tom Tromey  <tromey@adacore.com>
1498
1499         * ravenscar-thread.c (ravenscar_runtime_initializer)
1500         (has_ravenscar_runtime, get_running_thread_id)
1501         (ravenscar_thread_target::resume): Fix indentation.
1502
1503 2019-02-15  Tom Tromey  <tromey@adacore.com>
1504
1505         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1506         from ravenscar_arch_ops.
1507         (sparc_ravenscar_ops::fetch_registers)
1508         (sparc_ravenscar_ops::store_registers): Now methods.
1509         (sparc_ravenscar_prepare_to_store): Remove.
1510         (sparc_ravenscar_ops): Redefine.
1511         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1512         methods and destructor.  Remove members.
1513         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1514         (ravenscar_thread_target::store_registers)
1515         (ravenscar_thread_target::prepare_to_store): Update.
1516         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1517         Remove.
1518         (struct ppc_ravenscar_powerpc_ops): Derive from
1519         ravenscar_arch_ops.
1520         (ppc_ravenscar_powerpc_ops::fetch_registers)
1521         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1522         (ppc_ravenscar_powerpc_ops): Redefine.
1523         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1524         (ppc_ravenscar_e500_ops::fetch_registers)
1525         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1526         (ppc_ravenscar_e500_ops): Redefine.
1527         * aarch64-ravenscar-thread.c
1528         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1529         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1530         (aarch64_ravenscar_fetch_registers)
1531         (aarch64_ravenscar_store_registers): Now methods.
1532         (aarch64_ravenscar_ops): Redefine.
1533
1534 2019-02-15  Tom Tromey  <tromey@adacore.com>
1535
1536         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1537         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1538         (ravenscar_thread_target::stopped_by_watchpoint)
1539         (ravenscar_thread_target::stopped_data_address)
1540         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1541
1542 2019-02-15  Tom Tromey  <tromey@adacore.com>
1543
1544         * ravenscar-thread.c: Fix some typos.
1545
1546 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1547             Tom Tromey  <tromey@adacore.com>
1548
1549         * ada-lang.c (ada_exception_sal): Change addr_string to a
1550         std::string.
1551         (create_ada_exception_catchpoint): Update.
1552
1553 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1554             Tom Tromey  <tromey@adacore.com>
1555
1556         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1557         (bp_location_ops): Remove.
1558         (base_breakpoint_allocate_location): Update.
1559         (free_bp_location): Update.
1560         * ada-lang.c (class ada_catchpoint_location)
1561         <ada_catchpoint_location>: Remove ops parameter.
1562         (ada_catchpoint_location_dtor): Remove.
1563         (ada_catchpoint_location_ops): Remove.
1564         (allocate_location_exception): Update.
1565         * breakpoint.h (struct bp_location_ops): Remove.
1566         (class bp_location) <bp_location>: Remove bp_location_ops
1567         parameter.
1568         <~bp_location>: Add destructor.
1569         <ops>: Remove.
1570
1571 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1572             Pedro Alves  <palves@redhat.com>
1573
1574         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1575         'PATH_MAX'.
1576
1577 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1578             Samuel Thibault  <samuel.thibault@gnu.org>
1579             Thomas Schwinge  <thomas@codesourcery.com>
1580
1581         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1582         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1583
1584 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1585
1586         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1587         (check_empty): Use "const char *".
1588
1589         * gnu-nat.c (gnu_nat_target::detach): Instead of
1590         'detach_inferior (pid)' call
1591         'detach_inferior (find_inferior_pid (pid))'.
1592
1593         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1594         'nat/fork-inferior.o'.
1595         * gnu-nat.c: #include "nat/fork-inferior.h".
1596
1597         * gnu-nat.c (gnu_nat_target::detach): Instead of
1598         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1599         * gnu-nat.h: #include "inf-child.h".
1600         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1601         'i386_gnu_nat_target::fetch_registers'.
1602         (gnu_store_registers): Rename/move to
1603         'i386_gnu_nat_target::store_registers'.
1604
1605         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1606         * gnu-nat.h (mach_thread_info): New function.
1607         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1608
1609         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1610
1611 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1612
1613         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1614
1615 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1616
1617         * windows-nat.c (windows_add_thread): Add new parameter
1618         "main_thread_p" with default value set to false.  Update
1619         function documentation as well as all callers.
1620         (windows_delete_thread): Likewise.
1621         (fake_create_process): Update call to windows_add_thread.
1622         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1623         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1624         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1625         call to windows_delete_thread.
1626
1627 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1628
1629         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1630
1631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1632
1633         * symfile.c (find_separate_debug_file): Use canonical path of
1634         sysroot with child_path instead of gdb_sysroot if it is valid.
1635
1636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1637
1638         * symfile.c (find_separate_debug_file): Use child_path to
1639         determine if an object file is under a sysroot.
1640
1641 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1642
1643         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1644         unittests/child-path-selftests.c.
1645         * common/pathstuff.c (child_path): New function.
1646         * common/pathstuff.h (child_path): New prototype.
1647         * unittests/child-path-selftests.c: New file.
1648
1649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1650
1651         * symfile.c (find_separate_debug_file): Look for separate debug
1652         files in debug directories under the sysroot.
1653
1654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1655
1656         * symtab.h (struct minimal_symbol data_p): New const method.
1657         (struct minimal_symbol text_p): Likewise.
1658         * symtab.c (output_source_filename): Use file name style
1659         to print file name.
1660         (print_symbol_info): Likewise.
1661         (print_msymbol_info): Use address style to print addresses.
1662         Use function name style to print executable text symbols.
1663         (expand_symtab_containing_pc): Use data_p.
1664         (find_pc_sect_compunit_symtab): Likewise.
1665
1666 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * breakpoint.c (describe_other_breakpoints): Use address style
1669         to print addresses.
1670         (say_where): Likewise.
1671
1672 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1673
1674         * ada-typeprint.c (print_func_type): Print function name
1675         style to print function name.
1676         * c-typeprint.c (c_print_type_1): Likewise.
1677
1678 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1679
1680         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1681         for execve.
1682
1683 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1684
1685         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1686         type_stack.
1687
1688 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1689
1690         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1691         TYPE_CODE_REF types.
1692
1693 2019-02-08  Jim Wilson  <jimw@sifive.com>
1694
1695         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1696         (riscv_linux_fregset): New.
1697         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1698
1699 2019-02-07  Tom Tromey  <tom@tromey.com>
1700
1701         * thread.c (thread_cancel_execution_command): Update.
1702         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1703         methods.
1704         (struct thread_fsm_ops): Remove.
1705         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1706         (thread_fsm_should_stop, thread_fsm_return_value)
1707         (thread_fsm_set_finished, thread_fsm_finished_p)
1708         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1709         Don't declare.
1710         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1711         * infrun.c (clear_proceed_status_thread)
1712         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1713         (print_stop_event): Update.
1714         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1715         Add constructor.
1716         (step_command_fsm_ops): Remove.
1717         (new_step_command_fsm): Remove.
1718         (step_1): Update.
1719         (step_command_fsm::should_stop): Rename from
1720         step_command_fsm_should_stop.
1721         (step_command_fsm::clean_up): Rename from
1722         step_command_fsm_clean_up.
1723         (step_command_fsm::do_async_reply_reason): Rename from
1724         step_command_fsm_async_reply_reason.
1725         (struct until_next_fsm): Inherit from thread_fsm.  Add
1726         constructor.
1727         (until_next_fsm_ops): Remove.
1728         (new_until_next_fsm): Remove.
1729         (until_next_fsm::should_stop): Rename from
1730         until_next_fsm_should_stop.
1731         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1732         (until_next_fsm::do_async_reply_reason): Rename from
1733         until_next_fsm_async_reply_reason.
1734         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1735         constructor.  Change type of breakpoint.
1736         (finish_command_fsm_ops): Remove.
1737         (new_finish_command_fsm): Remove.
1738         (finish_command_fsm::should_stop): Rename from
1739         finish_command_fsm_should_stop.
1740         (finish_command_fsm::clean_up): Rename from
1741         finish_command_fsm_clean_up.
1742         (finish_command_fsm::return_value): Rename from
1743         finish_command_fsm_return_value.
1744         (finish_command_fsm::do_async_reply_reason): Rename from
1745         finish_command_fsm_async_reply_reason.
1746         (finish_command): Update.
1747         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1748         Add constructor.
1749         (call_thread_fsm_ops): Remove.
1750         (call_thread_fsm::call_thread_fsm): Rename from
1751         new_call_thread_fsm.
1752         (call_thread_fsm::should_stop): Rename from
1753         call_thread_fsm_should_stop.
1754         (call_thread_fsm::should_notify_stop): Rename from
1755         call_thread_fsm_should_notify_stop.
1756         (run_inferior_call, call_function_by_hand_dummy): Update.
1757         * cli/cli-interp.c (should_print_stop_to_console): Update.
1758         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1759         Add constructor.  Change type of location_breakpoint,
1760         caller_breakpoint.
1761         (until_break_fsm_ops): Remove.
1762         (new_until_break_fsm): Remove.
1763         (until_break_fsm::should_stop): Rename from
1764         until_break_fsm_should_stop.
1765         (until_break_fsm::clean_up): Rename from
1766         until_break_fsm_clean_up.
1767         (until_break_fsm::do_async_reply_reason): Rename from
1768         until_break_fsm_async_reply_reason.
1769         (until_break_command): Update.
1770         * thread-fsm.c: Remove.
1771         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1772
1773 2019-02-07  Tom Tromey  <tom@tromey.com>
1774
1775         * yy-remap.h: Add include guard.
1776         * xtensa-tdep.h: Add include guard.
1777         * xcoffread.h: Rename include guard.
1778         * varobj-iter.h: Add include guard.
1779         * tui/tui.h: Rename include guard.
1780         * tui/tui-winsource.h: Rename include guard.
1781         * tui/tui-wingeneral.h: Rename include guard.
1782         * tui/tui-windata.h: Rename include guard.
1783         * tui/tui-win.h: Rename include guard.
1784         * tui/tui-stack.h: Rename include guard.
1785         * tui/tui-source.h: Rename include guard.
1786         * tui/tui-regs.h: Rename include guard.
1787         * tui/tui-out.h: Rename include guard.
1788         * tui/tui-layout.h: Rename include guard.
1789         * tui/tui-io.h: Rename include guard.
1790         * tui/tui-hooks.h: Rename include guard.
1791         * tui/tui-file.h: Rename include guard.
1792         * tui/tui-disasm.h: Rename include guard.
1793         * tui/tui-data.h: Rename include guard.
1794         * tui/tui-command.h: Rename include guard.
1795         * tic6x-tdep.h: Add include guard.
1796         * target/waitstatus.h: Rename include guard.
1797         * target/wait.h: Rename include guard.
1798         * target/target.h: Rename include guard.
1799         * target/resume.h: Rename include guard.
1800         * target-float.h: Rename include guard.
1801         * stabsread.h: Add include guard.
1802         * rs6000-tdep.h: Add include guard.
1803         * riscv-fbsd-tdep.h: Add include guard.
1804         * regformats/regdef.h: Rename include guard.
1805         * record.h: Rename include guard.
1806         * python/python.h: Rename include guard.
1807         * python/python-internal.h: Rename include guard.
1808         * python/py-stopevent.h: Rename include guard.
1809         * python/py-ref.h: Rename include guard.
1810         * python/py-record.h: Rename include guard.
1811         * python/py-record-full.h: Rename include guard.
1812         * python/py-record-btrace.h: Rename include guard.
1813         * python/py-instruction.h: Rename include guard.
1814         * python/py-events.h: Rename include guard.
1815         * python/py-event.h: Rename include guard.
1816         * procfs.h: Add include guard.
1817         * proc-utils.h: Add include guard.
1818         * p-lang.h: Add include guard.
1819         * or1k-tdep.h: Rename include guard.
1820         * observable.h: Rename include guard.
1821         * nto-tdep.h: Rename include guard.
1822         * nat/x86-linux.h: Rename include guard.
1823         * nat/x86-linux-dregs.h: Rename include guard.
1824         * nat/x86-gcc-cpuid.h: Add include guard.
1825         * nat/x86-dregs.h: Rename include guard.
1826         * nat/x86-cpuid.h: Rename include guard.
1827         * nat/ppc-linux.h: Rename include guard.
1828         * nat/mips-linux-watch.h: Rename include guard.
1829         * nat/linux-waitpid.h: Rename include guard.
1830         * nat/linux-ptrace.h: Rename include guard.
1831         * nat/linux-procfs.h: Rename include guard.
1832         * nat/linux-osdata.h: Rename include guard.
1833         * nat/linux-nat.h: Rename include guard.
1834         * nat/linux-namespaces.h: Rename include guard.
1835         * nat/linux-btrace.h: Rename include guard.
1836         * nat/glibc_thread_db.h: Rename include guard.
1837         * nat/gdb_thread_db.h: Rename include guard.
1838         * nat/gdb_ptrace.h: Rename include guard.
1839         * nat/fork-inferior.h: Rename include guard.
1840         * nat/amd64-linux-siginfo.h: Rename include guard.
1841         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1842         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1843         * nat/aarch64-linux.h: Rename include guard.
1844         * nat/aarch64-linux-hw-point.h: Rename include guard.
1845         * mn10300-tdep.h: Add include guard.
1846         * mips-linux-tdep.h: Add include guard.
1847         * mi/mi-parse.h: Rename include guard.
1848         * mi/mi-out.h: Rename include guard.
1849         * mi/mi-main.h: Rename include guard.
1850         * mi/mi-interp.h: Rename include guard.
1851         * mi/mi-getopt.h: Rename include guard.
1852         * mi/mi-console.h: Rename include guard.
1853         * mi/mi-common.h: Rename include guard.
1854         * mi/mi-cmds.h: Rename include guard.
1855         * mi/mi-cmd-break.h: Rename include guard.
1856         * m2-lang.h: Add include guard.
1857         * location.h: Rename include guard.
1858         * linux-record.h: Rename include guard.
1859         * linux-nat.h: Add include guard.
1860         * linux-fork.h: Add include guard.
1861         * i386-darwin-tdep.h: Rename include guard.
1862         * hppa-linux-offsets.h: Add include guard.
1863         * guile/guile.h: Rename include guard.
1864         * guile/guile-internal.h: Rename include guard.
1865         * gnu-nat.h: Rename include guard.
1866         * gdb-stabs.h: Rename include guard.
1867         * frv-tdep.h: Add include guard.
1868         * f-lang.h: Add include guard.
1869         * event-loop.h: Add include guard.
1870         * darwin-nat.h: Rename include guard.
1871         * cp-abi.h: Rename include guard.
1872         * config/sparc/nm-sol2.h: Rename include guard.
1873         * config/nm-nto.h: Rename include guard.
1874         * config/nm-linux.h: Add include guard.
1875         * config/i386/nm-i386gnu.h: Rename include guard.
1876         * config/djgpp/nl_types.h: Rename include guard.
1877         * config/djgpp/langinfo.h: Rename include guard.
1878         * compile/gcc-cp-plugin.h: Add include guard.
1879         * compile/gcc-c-plugin.h: Add include guard.
1880         * compile/compile.h: Rename include guard.
1881         * compile/compile-object-run.h: Rename include guard.
1882         * compile/compile-object-load.h: Rename include guard.
1883         * compile/compile-internal.h: Rename include guard.
1884         * compile/compile-cplus.h: Rename include guard.
1885         * compile/compile-c.h: Rename include guard.
1886         * common/xml-utils.h: Rename include guard.
1887         * common/x86-xstate.h: Rename include guard.
1888         * common/version.h: Rename include guard.
1889         * common/vec.h: Rename include guard.
1890         * common/tdesc.h: Rename include guard.
1891         * common/selftest.h: Rename include guard.
1892         * common/scoped_restore.h: Rename include guard.
1893         * common/scoped_mmap.h: Rename include guard.
1894         * common/scoped_fd.h: Rename include guard.
1895         * common/safe-iterator.h: Rename include guard.
1896         * common/run-time-clock.h: Rename include guard.
1897         * common/refcounted-object.h: Rename include guard.
1898         * common/queue.h: Rename include guard.
1899         * common/ptid.h: Rename include guard.
1900         * common/print-utils.h: Rename include guard.
1901         * common/preprocessor.h: Rename include guard.
1902         * common/pathstuff.h: Rename include guard.
1903         * common/observable.h: Rename include guard.
1904         * common/netstuff.h: Rename include guard.
1905         * common/job-control.h: Rename include guard.
1906         * common/host-defs.h: Rename include guard.
1907         * common/gdb_wait.h: Rename include guard.
1908         * common/gdb_vecs.h: Rename include guard.
1909         * common/gdb_unlinker.h: Rename include guard.
1910         * common/gdb_unique_ptr.h: Rename include guard.
1911         * common/gdb_tilde_expand.h: Rename include guard.
1912         * common/gdb_sys_time.h: Rename include guard.
1913         * common/gdb_string_view.h: Rename include guard.
1914         * common/gdb_splay_tree.h: Rename include guard.
1915         * common/gdb_setjmp.h: Rename include guard.
1916         * common/gdb_ref_ptr.h: Rename include guard.
1917         * common/gdb_optional.h: Rename include guard.
1918         * common/gdb_locale.h: Rename include guard.
1919         * common/gdb_assert.h: Rename include guard.
1920         * common/filtered-iterator.h: Rename include guard.
1921         * common/filestuff.h: Rename include guard.
1922         * common/fileio.h: Rename include guard.
1923         * common/environ.h: Rename include guard.
1924         * common/common-utils.h: Rename include guard.
1925         * common/common-types.h: Rename include guard.
1926         * common/common-regcache.h: Rename include guard.
1927         * common/common-inferior.h: Rename include guard.
1928         * common/common-gdbthread.h: Rename include guard.
1929         * common/common-exceptions.h: Rename include guard.
1930         * common/common-defs.h: Rename include guard.
1931         * common/common-debug.h: Rename include guard.
1932         * common/cleanups.h: Rename include guard.
1933         * common/buffer.h: Rename include guard.
1934         * common/btrace-common.h: Rename include guard.
1935         * common/break-common.h: Rename include guard.
1936         * cli/cli-utils.h: Rename include guard.
1937         * cli/cli-style.h: Rename include guard.
1938         * cli/cli-setshow.h: Rename include guard.
1939         * cli/cli-script.h: Rename include guard.
1940         * cli/cli-interp.h: Rename include guard.
1941         * cli/cli-decode.h: Rename include guard.
1942         * cli/cli-cmds.h: Rename include guard.
1943         * charset-list.h: Add include guard.
1944         * buildsym-legacy.h: Rename include guard.
1945         * bfin-tdep.h: Add include guard.
1946         * ax.h: Rename include guard.
1947         * arm-linux-tdep.h: Add include guard.
1948         * arm-fbsd-tdep.h: Add include guard.
1949         * arch/xtensa.h: Rename include guard.
1950         * arch/tic6x.h: Add include guard.
1951         * arch/i386.h: Add include guard.
1952         * arch/arm.h: Rename include guard.
1953         * arch/arm-linux.h: Rename include guard.
1954         * arch/arm-get-next-pcs.h: Rename include guard.
1955         * arch/amd64.h: Add include guard.
1956         * arch/aarch64-insn.h: Rename include guard.
1957         * arch-utils.h: Rename include guard.
1958         * annotate.h: Add include guard.
1959         * amd64-darwin-tdep.h: Rename include guard.
1960         * aarch64-linux-tdep.h: Add include guard.
1961         * aarch64-fbsd-tdep.h: Add include guard.
1962         * aarch32-linux-nat.h: Add include guard.
1963
1964 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1965
1966         * macrotab.c (macro_define_internal): New function that
1967         factorizes macro_define_object_internal and macro_define_function
1968         code.
1969         (macro_define_object_internal): Use macro_define_internal.
1970         (macro_define_function): Likewise.
1971
1972 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1973
1974         * macrocmd.c (extract_identifier): Return
1975         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1976         callers.
1977
1978 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1979
1980         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1981
1982 2019-02-05  Tom Tromey  <tom@tromey.com>
1983
1984         * target.c (target_stack::unpush): Move assertion earlier.
1985
1986 2019-01-30  Tom Tromey  <tom@tromey.com>
1987
1988         PR python/23615:
1989         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1990         (gdbpy_parse_and_eval): Likewise.
1991         * python/python-internal.h (gdbpy_allow_threads): New class.
1992
1993 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1994
1995         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1996         (aarch64_fbsd_fpregmap): Move earlier.
1997         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1998         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1999         instead of individual calls to trad_frame_set_reg_addr.
2000         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2001         earlier.
2002         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2003         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2004         instead of individual calls to trad_frame_set_reg_addr.
2005
2006 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2007
2008         * CONTRIBUTE: Replace contribution list with wiki link.
2009
2010 2019-01-25  Tom Tromey  <tom@tromey.com>
2011
2012         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2013
2014 2019-01-25  Tom Tromey  <tom@tromey.com>
2015
2016         * xtensa-linux-nat.c: Fix common/ includes.
2017         * xml-support.h: Fix common/ includes.
2018         * xml-support.c: Fix common/ includes.
2019         * x86-linux-nat.c: Fix common/ includes.
2020         * windows-nat.c: Fix common/ includes.
2021         * varobj.h: Fix common/ includes.
2022         * varobj.c: Fix common/ includes.
2023         * value.c: Fix common/ includes.
2024         * valops.c: Fix common/ includes.
2025         * utils.c: Fix common/ includes.
2026         * unittests/xml-utils-selftests.c: Fix common/ includes.
2027         * unittests/utils-selftests.c: Fix common/ includes.
2028         * unittests/unpack-selftests.c: Fix common/ includes.
2029         * unittests/tracepoint-selftests.c: Fix common/ includes.
2030         * unittests/style-selftests.c: Fix common/ includes.
2031         * unittests/string_view-selftests.c: Fix common/ includes.
2032         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2033         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2034         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2035         * unittests/rsp-low-selftests.c: Fix common/ includes.
2036         * unittests/parse-connection-spec-selftests.c: Fix common/
2037         includes.
2038         * unittests/optional-selftests.c: Fix common/ includes.
2039         * unittests/offset-type-selftests.c: Fix common/ includes.
2040         * unittests/observable-selftests.c: Fix common/ includes.
2041         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2042         * unittests/memrange-selftests.c: Fix common/ includes.
2043         * unittests/memory-map-selftests.c: Fix common/ includes.
2044         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2045         * unittests/function-view-selftests.c: Fix common/ includes.
2046         * unittests/environ-selftests.c: Fix common/ includes.
2047         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2048         * unittests/common-utils-selftests.c: Fix common/ includes.
2049         * unittests/cli-utils-selftests.c: Fix common/ includes.
2050         * unittests/array-view-selftests.c: Fix common/ includes.
2051         * ui-file.c: Fix common/ includes.
2052         * tui/tui-io.c: Fix common/ includes.
2053         * tracepoint.h: Fix common/ includes.
2054         * tracepoint.c: Fix common/ includes.
2055         * tracefile-tfile.c: Fix common/ includes.
2056         * top.h: Fix common/ includes.
2057         * top.c: Fix common/ includes.
2058         * thread.c: Fix common/ includes.
2059         * target/waitstatus.h: Fix common/ includes.
2060         * target/waitstatus.c: Fix common/ includes.
2061         * target.h: Fix common/ includes.
2062         * target.c: Fix common/ includes.
2063         * target-memory.c: Fix common/ includes.
2064         * target-descriptions.c: Fix common/ includes.
2065         * symtab.h: Fix common/ includes.
2066         * symfile.c: Fix common/ includes.
2067         * stap-probe.c: Fix common/ includes.
2068         * spu-linux-nat.c: Fix common/ includes.
2069         * sparc-nat.c: Fix common/ includes.
2070         * source.c: Fix common/ includes.
2071         * solib.c: Fix common/ includes.
2072         * solib-target.c: Fix common/ includes.
2073         * ser-unix.c: Fix common/ includes.
2074         * ser-tcp.c: Fix common/ includes.
2075         * ser-pipe.c: Fix common/ includes.
2076         * ser-base.c: Fix common/ includes.
2077         * selftest-arch.c: Fix common/ includes.
2078         * s12z-tdep.c: Fix common/ includes.
2079         * rust-exp.y: Fix common/ includes.
2080         * rs6000-aix-tdep.c: Fix common/ includes.
2081         * riscv-tdep.c: Fix common/ includes.
2082         * remote.c: Fix common/ includes.
2083         * remote-notif.h: Fix common/ includes.
2084         * remote-fileio.h: Fix common/ includes.
2085         * remote-fileio.c: Fix common/ includes.
2086         * regcache.h: Fix common/ includes.
2087         * regcache.c: Fix common/ includes.
2088         * record-btrace.c: Fix common/ includes.
2089         * python/python.c: Fix common/ includes.
2090         * python/py-type.c: Fix common/ includes.
2091         * python/py-inferior.c: Fix common/ includes.
2092         * progspace.h: Fix common/ includes.
2093         * producer.c: Fix common/ includes.
2094         * procfs.c: Fix common/ includes.
2095         * proc-api.c: Fix common/ includes.
2096         * printcmd.c: Fix common/ includes.
2097         * ppc-linux-nat.c: Fix common/ includes.
2098         * parser-defs.h: Fix common/ includes.
2099         * osdata.c: Fix common/ includes.
2100         * obsd-nat.c: Fix common/ includes.
2101         * nat/x86-linux.c: Fix common/ includes.
2102         * nat/x86-linux-dregs.c: Fix common/ includes.
2103         * nat/x86-dregs.h: Fix common/ includes.
2104         * nat/x86-dregs.c: Fix common/ includes.
2105         * nat/ppc-linux.c: Fix common/ includes.
2106         * nat/mips-linux-watch.h: Fix common/ includes.
2107         * nat/mips-linux-watch.c: Fix common/ includes.
2108         * nat/linux-waitpid.c: Fix common/ includes.
2109         * nat/linux-ptrace.h: Fix common/ includes.
2110         * nat/linux-ptrace.c: Fix common/ includes.
2111         * nat/linux-procfs.c: Fix common/ includes.
2112         * nat/linux-personality.c: Fix common/ includes.
2113         * nat/linux-osdata.c: Fix common/ includes.
2114         * nat/linux-namespaces.c: Fix common/ includes.
2115         * nat/linux-btrace.h: Fix common/ includes.
2116         * nat/linux-btrace.c: Fix common/ includes.
2117         * nat/fork-inferior.c: Fix common/ includes.
2118         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2119         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2120         * nat/aarch64-linux.c: Fix common/ includes.
2121         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2122         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2123         * namespace.h: Fix common/ includes.
2124         * mips-linux-tdep.c: Fix common/ includes.
2125         * minsyms.c: Fix common/ includes.
2126         * mi/mi-parse.h: Fix common/ includes.
2127         * mi/mi-main.c: Fix common/ includes.
2128         * mi/mi-cmd-env.c: Fix common/ includes.
2129         * memrange.h: Fix common/ includes.
2130         * memattr.c: Fix common/ includes.
2131         * maint.h: Fix common/ includes.
2132         * maint.c: Fix common/ includes.
2133         * main.c: Fix common/ includes.
2134         * machoread.c: Fix common/ includes.
2135         * location.c: Fix common/ includes.
2136         * linux-thread-db.c: Fix common/ includes.
2137         * linux-nat.c: Fix common/ includes.
2138         * linux-fork.c: Fix common/ includes.
2139         * inline-frame.c: Fix common/ includes.
2140         * infrun.c: Fix common/ includes.
2141         * inflow.c: Fix common/ includes.
2142         * inferior.h: Fix common/ includes.
2143         * inferior.c: Fix common/ includes.
2144         * infcmd.c: Fix common/ includes.
2145         * inf-ptrace.c: Fix common/ includes.
2146         * inf-child.c: Fix common/ includes.
2147         * ia64-linux-nat.c: Fix common/ includes.
2148         * i387-tdep.c: Fix common/ includes.
2149         * i386-tdep.c: Fix common/ includes.
2150         * i386-linux-tdep.c: Fix common/ includes.
2151         * i386-linux-nat.c: Fix common/ includes.
2152         * i386-go32-tdep.c: Fix common/ includes.
2153         * i386-fbsd-tdep.c: Fix common/ includes.
2154         * i386-fbsd-nat.c: Fix common/ includes.
2155         * guile/scm-type.c: Fix common/ includes.
2156         * guile/guile.c: Fix common/ includes.
2157         * go32-nat.c: Fix common/ includes.
2158         * gnu-nat.c: Fix common/ includes.
2159         * gdbthread.h: Fix common/ includes.
2160         * gdbarch-selftests.c: Fix common/ includes.
2161         * gdb_usleep.c: Fix common/ includes.
2162         * gdb_select.h: Fix common/ includes.
2163         * gdb_bfd.c: Fix common/ includes.
2164         * gcore.c: Fix common/ includes.
2165         * fork-child.c: Fix common/ includes.
2166         * findvar.c: Fix common/ includes.
2167         * fbsd-nat.c: Fix common/ includes.
2168         * event-top.c: Fix common/ includes.
2169         * event-loop.c: Fix common/ includes.
2170         * dwarf2read.c: Fix common/ includes.
2171         * dwarf2loc.c: Fix common/ includes.
2172         * dwarf2-frame.c: Fix common/ includes.
2173         * dwarf-index-cache.c: Fix common/ includes.
2174         * dtrace-probe.c: Fix common/ includes.
2175         * disasm-selftests.c: Fix common/ includes.
2176         * defs.h: Fix common/ includes.
2177         * csky-tdep.c: Fix common/ includes.
2178         * cp-valprint.c: Fix common/ includes.
2179         * cp-support.h: Fix common/ includes.
2180         * cp-support.c: Fix common/ includes.
2181         * corelow.c: Fix common/ includes.
2182         * completer.h: Fix common/ includes.
2183         * completer.c: Fix common/ includes.
2184         * compile/compile.c: Fix common/ includes.
2185         * compile/compile-loc2c.c: Fix common/ includes.
2186         * compile/compile-cplus-types.c: Fix common/ includes.
2187         * compile/compile-cplus-symbols.c: Fix common/ includes.
2188         * command.h: Fix common/ includes.
2189         * cli/cli-dump.c: Fix common/ includes.
2190         * cli/cli-cmds.c: Fix common/ includes.
2191         * charset.c: Fix common/ includes.
2192         * build-id.c: Fix common/ includes.
2193         * btrace.h: Fix common/ includes.
2194         * btrace.c: Fix common/ includes.
2195         * breakpoint.h: Fix common/ includes.
2196         * breakpoint.c: Fix common/ includes.
2197         * ax.h:
2198         (enum agent_op): Fix common/ includes.
2199         * ax-general.c (struct aop_map): Fix common/ includes.
2200         * ax-gdb.c: Fix common/ includes.
2201         * auxv.c: Fix common/ includes.
2202         * auto-load.c: Fix common/ includes.
2203         * arm-tdep.c: Fix common/ includes.
2204         * arch/riscv.c: Fix common/ includes.
2205         * arch/ppc-linux-common.c: Fix common/ includes.
2206         * arch/i386.c: Fix common/ includes.
2207         * arch/arm.c: Fix common/ includes.
2208         * arch/arm-linux.c: Fix common/ includes.
2209         * arch/arm-get-next-pcs.c: Fix common/ includes.
2210         * arch/amd64.c: Fix common/ includes.
2211         * arch/aarch64.c: Fix common/ includes.
2212         * arch/aarch64-insn.c: Fix common/ includes.
2213         * arch-utils.c: Fix common/ includes.
2214         * amd64-windows-tdep.c: Fix common/ includes.
2215         * amd64-tdep.c: Fix common/ includes.
2216         * amd64-sol2-tdep.c: Fix common/ includes.
2217         * amd64-obsd-tdep.c: Fix common/ includes.
2218         * amd64-nbsd-tdep.c: Fix common/ includes.
2219         * amd64-linux-tdep.c: Fix common/ includes.
2220         * amd64-linux-nat.c: Fix common/ includes.
2221         * amd64-fbsd-tdep.c: Fix common/ includes.
2222         * amd64-fbsd-nat.c: Fix common/ includes.
2223         * amd64-dicos-tdep.c: Fix common/ includes.
2224         * amd64-darwin-tdep.c: Fix common/ includes.
2225         * agent.c: Fix common/ includes.
2226         * ada-lang.h: Fix common/ includes.
2227         * ada-lang.c: Fix common/ includes.
2228         * aarch64-tdep.c: Fix common/ includes.
2229
2230 2019-01-25  Tom Tromey  <tom@tromey.com>
2231
2232         * common/create-version.sh: Use common/version.h.
2233
2234 2019-01-24  Pedro Alves  <palves@redhat.com>
2235
2236         * infrun.c (signal_stop, signal_print, signal_program)
2237         (signal_catch, signal_pass): Now arrays instead of pointers.
2238         (update_signals_program_target, do_target_resume)
2239         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2240         * linux-nat.c (linux_nat_target::pass_signals)
2241         (linux_nat_target::create_inferior, linux_nat_target::attach):
2242         Adjust.
2243         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2244         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2245         * procfs.c (procfs_target::pass_signals): Adjust.
2246         * record-full.c (record_full_target::resume): Adjust.
2247         * remote.c (remote_target::pass_signals)
2248         (remote_target::program_signals): Adjust.
2249         * target-debug.h (target_debug_print_signals): Now takes a
2250         gdb::array_view as parameter.  Adjust.
2251         * target.h (target_ops) <pass_signals, program_signals>: Replace
2252         pointer and length parameters with gdb::array_view.
2253         (target_pass_signals, target_program_signals): Likewise.
2254         * target-delegates.c: Regenerate.
2255
2256 2019-01-24  Pedro Alves  <palves@redhat.com>
2257
2258         * common/forward-scope-exit.h
2259         (forward_scope_exit::forward_scope_exit): Pass arguments to
2260         m_bind_function directly, instead of creating a std::bind and
2261         copying that.
2262
2263 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2264
2265         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2266         for static members.
2267         (pass_in_v_vfp_candidate): Likewise.
2268
2269 2019-01-23  Tom Tromey  <tom@tromey.com>
2270             Pedro Alves  <palves@redhat.com>
2271
2272         * regcache.c (class regcache_invalidator): Remove.
2273         (regcache::raw_write): Use make_scope_exit.
2274
2275 2019-01-23  Tom Tromey  <tom@tromey.com>
2276
2277         * ui-out.h (class ui_out_emit_type): Update comment.
2278
2279 2019-01-23  Tom Tromey  <tom@tromey.com>
2280
2281         * infrun.c (fetch_inferior_event): Update comment.
2282
2283 2019-01-23  Tom Tromey  <tom@tromey.com>
2284             Pedro Alves  <palves@redhat.com>
2285
2286         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2287         parameter.
2288         (fetch_inferior_event): Use SCOPE_EXIT.
2289
2290
2291 2019-01-23  Tom Tromey  <tom@tromey.com>
2292             Pedro Alves  <palves@redhat.com>
2293
2294         * infrun.c (disable_thread_events): Delete.
2295         (stop_all_threads): Use SCOPE_EXIT.
2296
2297 2019-01-23  Tom Tromey  <tom@tromey.com>
2298             Pedro Alves  <palves@redhat.com>
2299
2300         * symfile.c: Include forward-scope-exit.h.
2301         (clear_symtab_users_cleanup): Replace forward declaration with
2302         a FORWARD_SCOPE_EXIT.
2303         (syms_from_objfile_1): Use the forward_scope_exit and
2304         gdb::optional instead of cleanup_function.
2305         (reread_symbols): Use the forward_scope_exit instead of
2306         cleanup_function.
2307         (clear_symtab_users_cleanup): Remove function.
2308
2309 2019-01-23  Tom Tromey  <tom@tromey.com>
2310             Pedro Alves  <palves@redhat.com>
2311
2312         * linux-nat.c: Include scope-exit.h.
2313         (cleanup_target_stop): Remove.
2314         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2315         SCOPE_EXIT.
2316
2317 2019-01-23  Tom Tromey  <tom@tromey.com>
2318             Pedro Alves  <palves@redhat.com>
2319
2320         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2321         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2322
2323 2019-01-23  Tom Tromey  <tom@tromey.com>
2324             Andrew Burgess  <andrew.burgess@embecosm.com>
2325             Pedro Alves  <palves@redhat.com>
2326
2327         * infrun.c (fetch_inferior_event): Use scope_exit.
2328         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2329         * top.c (execute_command): Use scope_exit.
2330         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2331         * utils.c (do_bpstat_clear_actions_cleanup)
2332         (make_bpstat_clear_actions_cleanup): Remove.
2333
2334 2019-01-23  Tom Tromey  <tom@tromey.com>
2335             Pedro Alves  <palves@redhat.com>
2336
2337         * infrun.c: Include "common/scope-exit.h"
2338         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2339         (wait_for_inferior): Use SCOPE_EXIT.
2340         (fetch_inferior_event): Use scope_exit.
2341
2342 2019-01-23  Tom Tromey  <tom@tromey.com>
2343             Pedro Alves  <palves@redhat.com>
2344
2345         * breakpoint.c (create_breakpoint): Remove cleanup.
2346
2347 2019-01-23  Tom Tromey  <tom@tromey.com>
2348             Andrew Burgess  <andrew.burgess@embecosm.com>
2349             Pedro Alves  <palves@redhat.com>
2350
2351 2019-01-23  Pedro Alves  <palves@redhat.com>
2352
2353         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2354
2355 2019-01-23  Pedro Alves  <palves@redhat.com>
2356             Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * gdbthread.h: Include "common/forward-scope-exit.h".
2359         (scoped_finish_thread_state): Redefine custom class in terms of
2360         forward_scope_exit.
2361
2362 2019-01-23  Pedro Alves  <palves@redhat.com>
2363             Andrew Burgess  <andrew.burgess@embecosm.com>
2364
2365         * common/forward-scope-exit.h: New file.
2366
2367 2019-01-23  Pedro Alves  <palves@redhat.com>
2368             Andrew Burgess  <andrew.burgess@embecosm.com>
2369             Tom Tromey  <tom@tromey.com>
2370
2371         * common/scope-exit.h: New file.
2372
2373 2019-01-23  Pedro Alves  <palves@redhat.com>
2374
2375         * common/preprocessor.h (ESC): Rename to ...
2376         (ESC_PARENS): ... this.
2377         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2378         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2379
2380 2019-01-23  Tom Tromey  <tom@tromey.com>
2381
2382         * language.h (class scoped_switch_to_sym_language_if_auto):
2383         Initialize m_lang in both cases.
2384
2385 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2386
2387         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2388         with XCNEW.
2389
2390 2019-01-22  Tom Tromey  <tom@tromey.com>
2391
2392         * corelow.c: Do not include sys/file.h.
2393
2394 2019-01-22  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-wingeneral.h: Include gdb_curses.h.
2397
2398 2019-01-22  Tom Tromey  <tom@tromey.com>
2399
2400         * source-cache.h (class source_cache) <get_source_lines,
2401         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2402
2403 2019-01-22  Tom Tromey  <tom@tromey.com>
2404
2405         * remote-fileio.h (struct remote_target): Declare.
2406
2407 2019-01-22  Tom Tromey  <tom@tromey.com>
2408
2409         * python/py-arch.c: Do not include py-ref.h.
2410         * python/py-bpevent.c: Do not include py-ref.h.
2411         * python/py-cmd.c: Do not include py-ref.h.
2412         * python/py-continueevent.c: Do not include py-ref.h.
2413         * python/py-event.h: Do not include py-ref.h.
2414         * python/py-evtregistry.c: Do not include py-ref.h.
2415         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2416         * python/py-frame.c: Do not include py-ref.h.
2417         * python/py-framefilter.c: Do not include py-ref.h.
2418         * python/py-function.c: Do not include py-ref.h.
2419         * python/py-infevents.c: Do not include py-ref.h.
2420         * python/py-linetable.c: Do not include py-ref.h.
2421         * python/py-objfile.c: Do not include py-ref.h.
2422         * python/py-param.c: Do not include py-ref.h.
2423         * python/py-prettyprint.c: Do not include py-ref.h.
2424         * python/py-progspace.c: Do not include py-ref.h.
2425         * python/py-symbol.c: Do not include py-ref.h.
2426         * python/py-symtab.c: Do not include py-ref.h.
2427         * python/py-type.c: Do not include py-ref.h.
2428         * python/py-unwind.c: Do not include py-ref.h.
2429         * python/py-utils.c: Do not include py-ref.h.
2430         * python/py-value.c: Do not include py-ref.h.
2431         * python/py-varobj.c: Do not include py-ref.h.
2432         * python/py-xmethods.c: Do not include py-ref.h.
2433         * python/python.c: Do not include py-ref.h.
2434         * varobj.c: Do not include py-ref.h.
2435
2436 2019-01-22  Tom Tromey  <tom@tromey.com>
2437
2438         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2439         keyword for bcache.
2440
2441 2019-01-22  Tom Tromey  <tom@tromey.com>
2442
2443         * compile/compile-cplus-types.c: Remove a comment by #include.
2444
2445 2019-01-22  Tom Tromey  <tom@tromey.com>
2446
2447         * compile/gcc-c-plugin.h: Include compile-internal.h.
2448
2449 2019-01-22  Tom Tromey  <tom@tromey.com>
2450
2451         * stabsread.c (EXTERN): Do not define.
2452         (symnum, next_symbol_text_func, processing_gcc_compilation)
2453         (within_function, global_sym_chain, global_stabs)
2454         (previous_stab_code, this_object_header_files)
2455         (n_this_object_header_files)
2456         (n_allocated_this_object_header_files): Define.
2457         * stabsread.h (EXTERN): Never define.  Use "extern".
2458
2459 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2462         history_value.
2463
2464 2019-01-21  Tom Tromey  <tom@tromey.com>
2465
2466         * ui-out.c: Fix includes.
2467         * tui/tui-source.c: Fix includes.
2468         * target.c: Fix includes.
2469         * remote.c: Fix includes.
2470         * regcache.c: Fix includes.
2471         * python/py-block.c: Fix includes.
2472         * printcmd.c: Fix includes.
2473         * or1k-tdep.c: Fix includes.
2474         * mi/mi-main.c: Fix includes.
2475         * m32r-tdep.c: Fix includes.
2476         * csky-tdep.c: Fix includes.
2477         * compile/compile-cplus-types.c: Fix includes.
2478         * cli/cli-interp.c: Fix includes.
2479
2480 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2481
2482         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2483         for padding.
2484
2485 2019-01-16  Tom Tromey  <tom@tromey.com>
2486
2487         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2488         earlier.
2489         (struct objfile) <msymbols_range>: Move from top level.
2490         <msymbols>: New method.
2491         (class objfile_msymbols): Remove.
2492         * symtab.c (default_collect_symbol_completion_matches_break_on):
2493         Update.
2494         * symmisc.c (dump_msymbols): Update.
2495         * stabsread.c (scan_file_globals): Update.
2496         * objc-lang.c (info_selectors_command, info_classes_command)
2497         (find_methods): Update.
2498         * minsyms.c (find_solib_trampoline_target): Update.
2499         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2500         * coffread.c (coff_symfile_read): Update.
2501         * ada-lang.c (ada_lookup_simple_minsym)
2502         (ada_collect_symbol_completion_matches): Update.
2503
2504 2019-01-16  Tom Tromey  <tom@tromey.com>
2505
2506         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2507         type.  Remove no-argument constructor.
2508         <iterator::operator++>: Simplify.
2509         <begin>: Update.
2510         <end>: Use minimal_symbol_count.
2511
2512 2019-01-16  Tom Tromey  <tom@tromey.com>
2513
2514         * objfiles.h (struct objfile) <psymtabs>: New method.
2515         (class objfile_psymtabs): Remove.
2516         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2517         typedef.
2518         <range>: New method.
2519         (require_partial_symbols): Change return type.
2520         * psymtab.c (require_partial_symbols)
2521         (psym_expand_symtabs_matching): Update.
2522         * mdebugread.c (parse_partial_symbols): Update.
2523         * dbxread.c (dbx_end_psymtab): Update.
2524
2525 2019-01-15  Tom Tromey  <tom@tromey.com>
2526
2527         * symtab.c (lookup_objfile_from_block)
2528         (lookup_symbol_in_objfile_symtabs)
2529         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2530         (find_line_symtab, info_sources_command)
2531         (default_collect_symbol_completion_matches_break_on)
2532         (make_source_files_completion_list): Update.
2533         * symmisc.c (print_objfile_statistics, dump_objfile)
2534         (maintenance_print_symbols, maintenance_info_symtabs)
2535         (maintenance_check_symtabs, maintenance_info_line_tables):
2536         Update.
2537         * source.c (select_source_symtab)
2538         (forget_cached_source_info_for_objfile): Update.
2539         * objfiles.h (class objfile_compunits): Remove.
2540         (struct objfile) <compunits_range>: New typedef.
2541         (compunits): New method.
2542         * objfiles.c (objfile_relocate1): Update.
2543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2544         * maint.c (count_symtabs_and_blocks): Update.
2545         * linespec.c (iterate_over_all_matching_symtabs): Update.
2546         * cp-support.c (add_symbol_overload_list_qualified): Update.
2547         * coffread.c (coff_symtab_read): Update.
2548         * ada-lang.c (add_nonlocal_symbols)
2549         (ada_collect_symbol_completion_matches)
2550         (ada_add_global_exceptions): Update.
2551
2552 2019-01-15  Tom Tromey  <tom@tromey.com>
2553
2554         * progspace.h (program_space) <objfiles_safe_range>: New
2555         typedef.
2556         <objfiles_safe>: New method.
2557         * objfiles.h (class all_objfiles_safe): Remove.
2558         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2559         * jit.c (jit_inferior_exit_hook): Update.
2560
2561 2019-01-17  Tom Tromey  <tom@tromey.com>
2562
2563         * progspace.h (program_space) <objfiles_range>: New typedef.
2564         <objfiles>: New method.
2565         <objfiles_head>: Rename from objfiles.
2566         (object_files): Update.
2567         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2568         * guile/scm-pretty-print.c
2569         (ppscm_find_pretty_printer_from_objfiles): Update.
2570         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2571         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2572         Update.
2573         * python/py-progspace.c (pspy_get_objfiles): Update.
2574         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2575         Update.
2576         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2577         (objfpy_lookup_objfile_by_build_id): Update.
2578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2579         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2580         Update.
2581         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2582         (expand_symtab_containing_pc, lookup_objfile_from_block)
2583         (lookup_static_symbol, basic_lookup_transparent_type)
2584         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2585         (find_line_symtab, info_sources_command)
2586         (default_collect_symbol_completion_matches_break_on)
2587         (make_source_files_completion_list, find_main_name): Update.
2588         * symmisc.c (print_symbol_bcache_statistics)
2589         (print_objfile_statistics, maintenance_print_symbols)
2590         (maintenance_print_msymbols, maintenance_print_objfiles)
2591         (maintenance_info_symtabs, maintenance_check_symtabs)
2592         (maintenance_expand_symtabs, maintenance_info_line_tables):
2593         Update.
2594         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2595         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2596         (map_overlay_command, unmap_overlay_command)
2597         (simple_overlay_update, expand_symtabs_matching)
2598         (map_symbol_filenames): Update.
2599         * symfile-debug.c (set_debug_symfile): Update.
2600         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2601         Update.
2602         * source.c (select_source_symtab, forget_cached_source_info):
2603         Update.
2604         * solib.c (solib_read_symbols): Update.
2605         * solib-spu.c (append_ocl_sos): Update.
2606         * psymtab.c (maintenance_print_psymbols)
2607         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2608         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2609         * printcmd.c (info_symbol_command): Update.
2610         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2611         Update.
2612         * objfiles.h (class all_objfiles): Remove.
2613         * objfiles.c (have_partial_symbols, have_full_symbols)
2614         (have_minimal_symbols, qsort_cmp, update_section_map)
2615         (shared_objfile_contains_address_p)
2616         (default_iterate_over_objfiles_in_search_order): Update.
2617         * objc-lang.c (info_selectors_command, info_classes_command)
2618         (find_methods): Update.
2619         * minsyms.c (find_solib_trampoline_target): Update.
2620         * maint.c (maintenance_info_sections)
2621         (maintenance_translate_address, count_symtabs_and_blocks):
2622         Update.
2623         * main.c (captured_main_1): Update.
2624         * linux-thread-db.c (try_thread_db_load_from_pdir)
2625         (has_libpthread): Update.
2626         * linespec.c (iterate_over_all_matching_symtabs)
2627         (search_minsyms_for_name): Update.
2628         * jit.c (jit_find_objf_with_entry_addr): Update.
2629         * hppa-tdep.c (find_unwind_entry)
2630         (hppa_lookup_stub_minimal_symbol): Update.
2631         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2632         Update.
2633         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2634         (elf_gnu_ifunc_resolve_by_got): Update.
2635         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2636         * dwarf-index-write.c (save_gdb_index_command): Update.
2637         * cp-support.c (add_symbol_overload_list_qualified): Update.
2638         * breakpoint.c (create_overlay_event_breakpoint)
2639         (create_longjmp_master_breakpoint)
2640         (create_std_terminate_master_breakpoint)
2641         (create_exception_master_breakpoint): Update.
2642         * blockframe.c (find_pc_partial_function): Update.
2643         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2644         (ada_collect_symbol_completion_matches)
2645         (ada_add_global_exceptions): Update.
2646
2647 2019-01-17  Tom Tromey  <tom@tromey.com>
2648
2649         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2650         declare VEC.
2651         (solib_target_parse_libraries): Change return type.
2652         (library_list_start_segment, library_list_start_section)
2653         (library_list_end_library, library_list_start_library); Update.
2654         (solib_target_free_library_list): Remove.
2655         (solib_target_parse_libraries): Remove cleanup.  Change return
2656         type.
2657         (solib_target_current_sos): Update.
2658
2659 2019-01-17  Tom Tromey  <tromey@bapiya>
2660
2661         * valprint.c: Replace "the the" with "the".
2662         * symtab.c: Replace "the the" with "the".
2663         * solib.c: Replace "the the" with "the".
2664         * solib-dsbt.c: Replace "the the" with "the".
2665         * linespec.c: Replace "the the" with "the".
2666         * dwarf2loc.h: Replace "the the" with "the".
2667         * amd64-windows-tdep.c: Replace "the the" with "the".
2668         * aarch64-tdep.c: Replace "the the" with "the".
2669
2670 2019-01-16  Keith Seitz  <keiths@redhat.com>
2671
2672         PR gdb/23773
2673         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2674         <builder>: Rename to ..
2675         <m_builder>: ... this and make private.
2676         (dwarf2_cu::get_builder): New method.  Change all users of
2677         `builder' to use this method.
2678         (dwarf2_start_symtab): Move to ...
2679         (dwarf2_cu::start_symtab): ... here.  Update all callers
2680         (setup_type_unit_groups): Move to ...
2681         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2682         callers.
2683         (dwarf2_cu::reset_builder): New method.
2684         (process_full_compunit, process_full_type_unit): Use
2685         dwarf2_cu::reset_builder.
2686         (follow_die_offset): Record the ancestor CU if it is different
2687         from the followed DIE's CU.
2688         (follow_die_sig_1): Likewise.
2689
2690 2019-01-15  Tom Tromey  <tom@tromey.com>
2691
2692         * remote.c (class remote_state) <buf>: Now a char_vector.
2693         <buf_size>: Remove.
2694         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2695         parameter.
2696         (remote_target::getpkt_or_notif_sane_1)
2697         (remote_target::getpkt_sane)
2698         (remote_target::getpkt_or_notif_sane): Likewise.
2699         (class remote_target) <putpkt>: New overload.
2700         (remote_target::read_frame): Change type of "buf_p".  Remove
2701         sizeof_p parameter.
2702         (packet_ok): New overload.
2703         (packet_check_result): New overload.
2704         Update all uses.
2705
2706 2019-01-14  Tom Tromey  <tom@tromey.com>
2707
2708         * remote-notif.c (handle_notification, remote_notif_ack)
2709         (remote_notif_parse): Make "buf" const.
2710         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2711         const.
2712         (remote_notif_parse, remote_notif_ack, handle_notification):
2713         Likewise.
2714         * remote.c (remote_notif_stop_parse): Make "buf" const.
2715         (remote_target::remote_parse_stop_reply): Make "buf" const.
2716         (remote_notif_stop_ack): Make "buf" const.
2717
2718 2019-01-14  Tom Tromey  <tom@tromey.com>
2719
2720         * remote.c (remote_console_output): Make parameter const.
2721
2722 2019-01-14  Tom Tromey  <tom@tromey.com>
2723
2724         * target-debug.h (target_debug_print_signals): Constify.
2725         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2726         * procfs.c (procfs_target::pass_signals): Update.
2727         * linux-nat.c (linux_nat_target::pass_signals): Update.
2728         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2729         * target-delegates.c: Rebuild.
2730         * remote.c (remote_target::program_signals): Update.
2731         (remote_target::pass_signals): Update.
2732         * target.c (target_pass_signals): Constify argument.
2733         (target_program_signals): Likewise.
2734         * target.h (struct target_ops) <pass_signals, program_signals>:
2735         Constify argument.
2736         (target_pass_signals, target_program_signals): Constify argument.
2737
2738 2019-01-14  Tom Tromey  <tom@tromey.com>
2739
2740         PR tui/28819:
2741         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2742
2743 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2744
2745         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2746         field.
2747         * rs6000-tdep.c: Include reggroups.h.
2748         (IS_V_ALIAS_PSEUDOREG): Define.
2749         (rs6000_register_name): Return names for the "vX" aliases.
2750         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2751         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2752         aliases.  Call default_register_reggroup_p for all other
2753         pseudo-registers.
2754         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2755         New functions.
2756         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2757         Handle "vX" aliases.
2758         (v_alias_pseudo_register_collect): New function.
2759         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2760         (rs6000_gdbarch_init): Initialize "vX" aliases as
2761         pseudo-registers.  Restore registration of
2762         rs6000_pseudo_register_reggroup_p with
2763         set_tdesc_pseudo_register_reggroup_p.
2764
2765 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2766
2767         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2768         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2769         set_gdbarch_num_pseudo_regs.
2770
2771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2772
2773         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2774         Remove arg prefixname, add do_set and do_show.
2775         Add member functions set_list and show_list.
2776         * cli/cli-style.c (class cli_style_option): Update accordingly.
2777         (style_set_list): Move to file scope.
2778         (style_show_list): Likewise.
2779         (set_style): Call help_list.
2780         (show_style): Call cmd_show_list.
2781         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2782         Update to use the new macro.
2783
2784 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2785
2786         * ada-lang.c (_initialize_ada_language): Expand the help text
2787         for the "catch exception" command.
2788
2789 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2790
2791         * symtab.c (matching_obj_sections): Initialize obj,
2792         declare it closer to its usage.
2793
2794 2019-01-10  Tom Tromey  <tom@tromey.com>
2795
2796         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2797         (basic_inf_threads_range): Remove.
2798         (inf_threads_range, inf_non_exited_threads_range)
2799         (safe_inf_threads_range): Use next_adapter.
2800
2801 2019-01-10  Keith Seitz  <keiths@redhat.com>
2802
2803         PR gdb/23712
2804         PR symtab/23010
2805         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2806         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2807
2808 2019-01-10  Keith Seitz  <keiths@redhat.com>
2809
2810         PR gdb/23712
2811         PR symtab/23010
2812         * dictionary.c (pending_to_vector): Remove.
2813         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2814         Remove _1 suffix, replacing functions of the same name.  Update
2815         all callers.
2816         (dict_create_hashed, dict_create_hashed_expandable)
2817         (dict_create_linear, dict_create_linear_expandable, dict_free)
2818         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2819         Make functions static.
2820
2821 2019-01-10  Keith Seitz  <keiths@redhat.com>
2822
2823         PR gdb/23712
2824         PR symtab/23010
2825         * dictionary.h (struct dictionary): Replace declaration with
2826         multidictionary.
2827         (dict_create_hashed, dict_create_hashed_expandable)
2828         (dict_create_linear, dict_create_linear_expandable)
2829         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2830         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2831         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2832         taking multidictionary argument.
2833         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2834         * block.h (struct block) <dict>: Change to multidictionary
2835         and rename `multidict'.
2836         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2837         symmisc.c: Update all dictionary references to multidictionary.
2838
2839 2019-01-10  Keith Seitz  <keiths@redhat.com>
2840
2841         PR gdb/23712
2842         PR symtab/23010
2843         * dictionary.c: Include unordered_map.
2844         (pending_to_vector): New function.
2845         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2846         Rewrite the non-"_1" functions to take vector instead
2847         of linked list.
2848         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2849         "new" _1 versions of the same name.
2850         (multidictionary): Define.
2851         (std::hash<enum language): New definition.
2852         (collate_pending_symbols_by_language, mdict_create_hashed)
2853         (mdict_create_hashed_expandable, mdict_create_linear)
2854         (mdict_create_linear_expandable, mdict_free)
2855         (find_language_dictionary, create_new_language_dictionary)
2856         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2857         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2858         (mdict_size, mdict_empty): New functions.
2859         * dictionary.h (mdict_iterator): Define.
2860
2861 2019-01-10  Pedro Alves  <palves@redhat.com>
2862
2863         * breakpoint.c (read_uploaded_action)
2864         (create_tracepoint_from_upload): Adjust to use
2865         gdb::unique_xmalloc_ptr.
2866         * ctf.c (ctf_write_uploaded_tp):
2867         (SET_ARRAY_FIELD): Use emplace_back.
2868         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2869         * tracefile-tfile.c (tfile_write_uploaded_tp):
2870         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2871         gdb::unique_xmalloc_ptr.
2872         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2873         at_string, cond_string, cmd_strings>: Replace char pointers
2874         with gdb::unique_xmalloc_ptr.
2875
2876 2019-01-10  Pedro Alves  <palves@redhat.com>
2877
2878         * solib-target.c (library_list_start_library): Don't xstrdup name.
2879
2880 2019-01-10  Pedro Alves  <palves@redhat.com>
2881
2882         * mdebugread.c (parse_partial_symbols): Use
2883         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2884
2885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * linux-fork.c (scoped_switch_fork_info)
2888         <~scoped_switch_fork_info>: Fix incorrect variable name.
2889
2890 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2891
2892         * linux-fork.c (scoped_switch_fork_info)
2893         <scoped_switch_fork_info>: Make explicit.
2894         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2895
2896 2019-01-10  Tom Tromey  <tom@tromey.com>
2897
2898         * objfiles.h (objfile::reset_psymtabs): Update.
2899         * objfiles.c (objfile::objfile): Update.
2900         * psymtab.h (psymtab_storage::obstack): Update.
2901         (psymtab_storage::m_obstack): Use gdb::optional.
2902         (class psymtab_storage): Update comment.  Remove objfile
2903         parameter.
2904         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2905
2906 2019-01-10  Tom Tromey  <tom@tromey.com>
2907
2908         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2909         <free_psymtabs>: Now private.
2910         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2911         (allocate_psymtab): Use new method.
2912
2913 2019-01-10  Tom Tromey  <tom@tromey.com>
2914
2915         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2916         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2917         * mdebugread.c (parse_partial_symbols): Use
2918         allocate_dependencies.
2919         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2920         allocate_dependencies.
2921         (process_psymtab_comp_unit_reader)
2922         (build_type_psymtab_dependencies): Likewise.
2923         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2924
2925 2019-01-10  Tom Tromey  <tom@tromey.com>
2926
2927         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2928         PSYMBOL_SET_LANGUAGE.
2929         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2930
2931 2019-01-10  Tom Tromey  <tom@tromey.com>
2932
2933         * psymtab.h (psymtab_storage::obstack): New method.
2934         <m_obstack>: Rename from obstack; now private.
2935         * psymtab.c (psymtab_storage): Update.
2936         * dwarf2read.c (create_addrmap_from_index)
2937         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2938         Update.
2939
2940 2019-01-10  Tom Tromey  <tom@tromey.com>
2941
2942         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2943         * objfiles.h (objfile::reset_psymtabs): New method.
2944
2945 2019-01-10  Tom Tromey  <tom@tromey.com>
2946
2947         * symmisc.c (print_symbol_bcache_statistics): Update.
2948         (print_objfile_statistics): Update.
2949         * symfile.c (reread_symbols): Update.
2950         * psymtab.h (class psymtab_storage): New.
2951         * psymtab.c (psymtab_storage): New constructor.
2952         (~psymtab_storage): New destructor.
2953         (require_partial_symbols): Update.
2954         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2955         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2956         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2957         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2958         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2959         (start_psymtab_common, end_psymtab_common)
2960         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2961         (allocate_psymtab): Update.
2962         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2963         Update.
2964         (dump_psymtab_addrmap, maintenance_print_psymbols)
2965         (maintenance_check_psymtabs): Update.
2966         (class objfile_psymtabs): Move to objfiles.h.
2967         * psympriv.h (discard_psymtab): Now inline.
2968         (psymtab_discarder::psymtab_discarder): Update.
2969         (psymtab_discarder::~psymtab_discarder): Update.
2970         (ALL_OBJFILE_PSYMTABS): Rewrite.
2971         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2972         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2973         Remove fields.
2974         <partial_symtabs>: New field.
2975         (class objfile_psymtabs): Move from psymtab.h.  Update.
2976         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2977         psymbol_cache.
2978         (objfile::~objfile): Don't destroy psymbol_cache.
2979         * mdebugread.c (parse_partial_symbols): Update.
2980         * dwarf2read.c (create_addrmap_from_index)
2981         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2982         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2983         (add_partial_subprogram, dwarf2_ranges_read): Update.
2984         * dwarf-index-write.c (write_address_map)
2985         (write_one_signatured_type, recursively_write_psymbols)
2986         (class debug_names, class debug_names, write_psymtabs_to_index):
2987         Update.
2988
2989 2019-01-10  Tom Tromey  <tom@tromey.com>
2990
2991         * symtab.h (SYMBOL_SET_NAMES): Update.
2992         (symbol_set_names): Update.
2993         (MSYMBOL_SET_NAMES): Update.
2994         * symtab.c (symbol_set_names): Change argument to be an
2995         objfile_per_bfd_storage.
2996         * psymtab.c (add_psymbol_to_bcache): Update.
2997         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2998
2999 2019-01-10  Tom Tromey  <tom@tromey.com>
3000
3001         * symtab.c (create_demangled_names_hash): Change argument to be an
3002         objfile_per_bfd_storage.
3003         (symbol_set_names): Update.
3004
3005 2019-01-10  Tom Tromey  <tom@tromey.com>
3006
3007         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3008         init_psymbol_list.
3009         * psymtab.c (init_psymbol_list): Do nothing if already called.
3010         * psympriv.h (init_psymbol_list): Add comment.
3011         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3012         init_psymbol_list.
3013         * dbxread.c (dbx_symfile_read): Unconditionally call
3014         init_psymbol_list.
3015
3016 2019-01-10  Tom Tromey  <tom@tromey.com>
3017
3018         * xcoffread.c (scan_xcoff_symtab): Update.
3019         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3020         "where".
3021         * mdebugread.c (parse_partial_symbols)
3022         (handle_psymbol_enumerators): Update.
3023         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3024         * dbxread.c (read_dbx_symtab): Update.
3025         * psympriv.h (psymbol_placement): New enum.
3026         (add_psymbol_to_list): Update.
3027
3028 2019-01-10  Tom Tromey  <tom@tromey.com>
3029
3030         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3031         static_psymbols parameters.
3032         (scan_xcoff_symtab): Update.
3033         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3034         static_psymbols parameters.
3035         * psympriv.h (start_psymtab_common): Update.
3036         * mdebugread.c (parse_partial_symbols): Update.
3037         * dwarf2read.c (create_partial_symtab): Update.
3038         * dbxread.c (read_dbx_symtab): Update.
3039         (start_psymtab): Remove global_psymbols and static_psymbols
3040         parameters.
3041
3042 2019-01-10  Tom Tromey  <tom@tromey.com>
3043
3044         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3045         * psymtab.c (allocate_psymtab): Add comment.
3046         * psympriv.h (allocate_psymtab): Add comment.
3047         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3048         initializations.
3049         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3050
3051 2019-01-10  Tom Tromey  <tom@tromey.com>
3052
3053         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3054         Don't declare.
3055         * mipsread.c: Include mdebugread.h.
3056         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3057         Declare.
3058         * elfread.c: Include mdebugread.h.
3059
3060 2019-01-09  Tom Tromey  <tom@tromey.com>
3061
3062         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3063         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3064         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3065         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3066         (psym_lookup_symbol, psym_find_last_source_symtab)
3067         (psym_forget_cached_source_info, psym_print_stats)
3068         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3069         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3070         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3071         (psym_find_compunit_symtab_by_address)
3072         (maintenance_print_psymbols, maintenance_info_psymtabs)
3073         (maintenance_check_psymtabs): Use ranged for.
3074         * psymtab.h (class objfile_psymtabs): New.
3075         (require_partial_symbols): Return objfile_psymtabs.
3076         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3077
3078 2019-01-09  Tom Tromey  <tom@tromey.com>
3079
3080         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3081         (find_pc_mapped_section, list_overlays_command)
3082         (map_overlay_command, unmap_overlay_command)
3083         (simple_overlay_update): Use all_objfiles.
3084         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3085         * printcmd.c (info_symbol_command): Use all_objfiles.
3086         * objfiles.h (ALL_OBJSECTIONS): Remove.
3087         * maint.c (maintenance_translate_address): Use all_objfiles.
3088         * gcore.c (gcore_create_callback): Use all_objfiles.
3089         (objfile_find_memory_regions): Likewise.
3090
3091 2019-01-09  Tom Tromey  <tom@tromey.com>
3092
3093         * symtab.c (find_line_symtab, info_sources_command)
3094         (make_source_files_completion_list): Use objfile_compunits.
3095         * source.c (select_source_symtab): Use objfile_compunits.
3096         * objfiles.h (struct objfile): Update comment.
3097         (ALL_OBJFILES): Remove.
3098         (ALL_FILETABS): Remove.
3099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3100         objfile_compunits.
3101
3102 2019-01-09  Tom Tromey  <tom@tromey.com>
3103
3104         * symmisc.c (print_objfile_statistics, dump_objfile)
3105         (maintenance_print_symbols): Use compunit_filetabs.
3106         * source.c (forget_cached_source_info_for_objfile): Use
3107         compunit_filetabs.
3108         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3109         (ALL_FILETABS): Use compunit_filetabs.
3110         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3111         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3112
3113 2019-01-09  Tom Tromey  <tom@tromey.com>
3114
3115         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3116         (compunit_filetabs): New.
3117         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3118         compunit_filetabs.
3119         (info_sources_command, make_source_files_completion_list): Remove
3120         declaration.
3121         * symmisc.c (print_objfile_statistics, dump_objfile)
3122         (maintenance_print_symbols): Remove declaration.
3123         (maintenance_info_symtabs): Use compunit_filetabs.
3124         (maintenance_info_line_tables): Likewise.
3125         * source.c (select_source_symtab): Change local variable name.
3126         (forget_cached_source_info_for_objfile): Remove declaration.
3127         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3128         * objfiles.c (objfile_relocate1): Remove declaration.
3129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3130         declaration.
3131         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3132         * coffread.c (coff_symtab_read): Remove declaration.
3133         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3134         compunit_filetabs.
3135
3136 2019-01-09  Tom Tromey  <tom@tromey.com>
3137
3138         * symtab.c (lookup_objfile_from_block)
3139         (find_pc_sect_compunit_symtab, search_symbols)
3140         (default_collect_symbol_completion_matches_break_on): Use
3141         objfile_compunits.
3142         * objfiles.h (ALL_COMPUNITS): Remove.
3143         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3144         * cp-support.c (add_symbol_overload_list_qualified): Use
3145         objfile_compunits.
3146         * ada-lang.c (ada_collect_symbol_completion_matches)
3147         (ada_add_global_exceptions): Use objfile_compunits.
3148
3149 2019-01-09  Tom Tromey  <tom@tromey.com>
3150
3151         * source.c (select_source_symtab)
3152         (forget_cached_source_info_for_objfile): Remove declaration.
3153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3154         declaration.
3155         * maint.c (count_symtabs_and_blocks): Remove declaration.
3156         * cp-support.c (add_symbol_overload_list_qualified): Remove
3157         declaration.
3158         * coffread.c (coff_symtab_read): Remove declaration.
3159         * symtab.c (lookup_symbol_in_objfile_symtabs)
3160         (basic_lookup_transparent_type_1): Use objfile_compunits.
3161         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3162         (info_sources_command, search_symbols)
3163         (default_collect_symbol_completion_matches_break_on)
3164         (make_source_files_completion_list): Remove declaration.
3165         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3166         (ada_collect_symbol_completion_matches)
3167         (ada_add_global_exceptions): Remove declaration.
3168         * linespec.c (iterate_over_all_matching_symtabs): Use
3169         objfile_compunits.
3170         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3171         (class objfile_compunits): New.
3172         (ALL_COMPUNITS): Use objfile_compunits.
3173         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3174         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3175         objfile_compunits.
3176         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3177
3178 2019-01-09  Tom Tromey  <tom@tromey.com>
3179
3180         * symtab.c (search_symbols)
3181         (default_collect_symbol_completion_matches_break_on): Use
3182         objfile_msymbols.
3183         * ada-lang.c (ada_lookup_simple_minsym)
3184         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3185         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3186         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3187         objfile_msymbols.
3188         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3189         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3190         * objc-lang.c (find_methods): Use objfile_msymbols.
3191         (info_selectors_command, info_classes_command): Likewise.
3192         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3193         * objfiles.h (class objfile_msymbols): New.
3194         (ALL_OBJFILE_MSYMBOLS): Remove.
3195         (ALL_MSYMBOLS): Remove.
3196
3197 2019-01-09  Tom Tromey  <tom@tromey.com>
3198
3199         * common/next-iterator.h (next_adapter): Add Iterator template
3200         parameter.
3201         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3202         (class all_objfiles_safe): New.
3203         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3204         * objfiles.c (put_objfile_before): Update comment.
3205         (add_separate_debug_objfile): Likewise.
3206         (free_all_objfiles): Use all_objfiles_safe.
3207         (objfile_purge_solibs): Likewise.
3208
3209 2019-01-09  Tom Tromey  <tom@tromey.com>
3210
3211         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3212         (expand_symtab_containing_pc, lookup_static_symbol)
3213         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3214         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3215         all_objfiles.
3216         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3217         * breakpoint.c (create_overlay_event_breakpoint)
3218         (create_longjmp_master_breakpoint)
3219         (create_std_terminate_master_breakpoint)
3220         (create_exception_master_breakpoint): Use all_objfiles.
3221         * linux-thread-db.c (try_thread_db_load_from_pdir)
3222         (has_libpthread): Use all_objfiles.
3223         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3224         * linespec.c (iterate_over_all_matching_symtabs)
3225         (search_minsyms_for_name): Use all_objfiles.
3226         * maint.c (maintenance_info_sections): Use all_objfiles.
3227         * main.c (captured_main_1): Use all_objfiles.
3228         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3229         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3230         * guile/scm-pretty-print.c
3231         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3232         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3233         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3234         (maintenance_print_msymbols): Use all_objfiles.
3235         * source.c (select_source_symtab): Use all_objfiles.
3236         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3237         * symfile.c (remove_symbol_file_command)
3238         (expand_symtabs_matching, map_symbol_filenames): Use
3239         all_objfiles.
3240         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3241         all_objfiles.
3242         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3243         * objc-lang.c (find_methods): Use all_objfiles.
3244         * objfiles.c (have_partial_symbols, have_full_symbols)
3245         (have_minimal_symbols, qsort_cmp)
3246         (default_iterate_over_objfiles_in_search_order): Use
3247         all_objfiles.
3248         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3249         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3250         (maintenance_check_psymtabs): Use all_objfiles.
3251         (ALL_PSYMTABS): Remove.
3252         * compile/compile-object-run.c (do_module_cleanup): Use
3253         all_objfiles.
3254         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3255         * cp-support.c (add_symbol_overload_list_qualified): Use
3256         all_objfiles.
3257         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3258         Use all_objfiles.
3259         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3260         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3261         all_objfiles.
3262         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3263         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3264         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3265         Uses all_objfiles.
3266         * solib.c (solib_read_symbols): Use all_objfiles
3267
3268 2019-01-09  Tom Tromey  <tom@tromey.com>
3269
3270         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3271         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3272         all_objfiles.
3273         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3274         * symmisc.c (print_symbol_bcache_statistics)
3275         (print_objfile_statistics, maintenance_print_objfiles)
3276         (maintenance_info_symtabs, maintenance_check_symtabs)
3277         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3278         all_objfiles.
3279         * source.c (forget_cached_source_info): Use all_objfiles.
3280         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3281         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3282         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3283         * objfiles.c (update_section_map): Use all_objfiles.
3284         (shared_objfile_contains_address_p): Likewise.
3285         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3286         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3287
3288 2019-01-09  Tom Tromey  <tom@tromey.com>
3289
3290         * common/next-iterator.h: New file.
3291         * objfiles.h (class all_objfiles): New.
3292         (struct objfile_iterator): New.
3293
3294 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3295
3296         * NEWS: Move the description of the changed "frame", "select-frame",
3297          and "info frame" commands to the Changed commands section.
3298
3299 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3300
3301         * gdbtypes.c (check_stub_method_group): Remove handling of old
3302         mangling schemes.
3303         * linespec.c (find_methods): Likewise.
3304         * stabsread.c (read_member_functions): Likewise.
3305         * valops.c (search_struct_method): Likewise.
3306         (value_struct_elt_for_reference): Likewise.
3307         * NEWS: Mention this change.
3308
3309 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3310
3311         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3312         print_source_lines.
3313         * source.c (print_source_lines_base): Update line number check.
3314         (print_source_lines): New function.
3315         (source_lines_range::source_lines_range): New function.
3316         * source.h (class source_lines_range): New class.
3317         (print_source_lines): New declaration.
3318
3319 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3320
3321         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3322
3323 2019-01-08  Tom Tromey  <tom@tromey.com>
3324             Simon Marchi  <simon.marchi@ericsson.com>
3325
3326         PR gdb/24060
3327         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3328         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3329         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3330         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3331         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3332         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3333
3334 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3335
3336         * source.c (select_source_symtab): Move header comment to
3337         declaration in source.h.
3338         (forget_cached_source_info_for_objfile): Likewise.
3339         (forget_cached_source_info): Likewise.
3340         (identify_source_line): Likewise.
3341         * source.h (identify_source_line): Move declaration from symtab.h
3342         and add comment from source.c
3343         (print_source_lines): Likewise.
3344         (forget_cached_source_info_for_objfile): Likewise.
3345         (forget_cached_source_info): Likewise.
3346         (select_source_symtab): Likewise.
3347         (enum print_source_lines_flag): Move definition from symtab.h.
3348         * symtab.h (identify_source_line): Move declaration to source.h.
3349         (print_source_lines): Likewise.
3350         (forget_cached_source_info_for_objfile): Likewise.
3351         (forget_cached_source_info): Likewise.
3352         (select_source_symtab): Likewise.
3353         (enum print_source_lines_flag): Move definition to source.h.
3354         * tui/tui-hooks.c: Add 'source.h' include.
3355
3356 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * source.c (print_source_lines_base): Handle requests to print
3359         reverse line number sequences, and guard against empty lines
3360         string.
3361
3362 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * source.c (print_source_lines_base): Fix skip of '\r' if next
3365         character is '\n'.
3366
3367 2019-01-06  Tom Tromey  <tom@tromey.com>
3368
3369         * c-exp.y (struct c_parse_state) <macro_original_text,
3370         expansion_obstack>: New member.
3371         (macro_original_text, expansion_obstack): Remove globals.
3372         (scan_macro_expansion, scanning_macro_expansion)
3373         (finished_macro_expansion): Update.
3374         (scan_macro_cleanup): Remove.
3375         (yylex, c_parse): Update.
3376
3377 2019-01-06  Tom Tromey  <tom@tromey.com>
3378
3379         * c-exp.y (struct c_parse_state) <strings>: New member.
3380         (operator_stoken): Update.
3381
3382 2019-01-06  Tom Tromey  <tom@tromey.com>
3383
3384         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3385         (union type_stack_elt) <typelist_val>: Now a pointer to
3386         std::vector.
3387         (type_stack_cleanup): Don't declare.
3388         (push_typelist): Update.
3389         * parse.c (pop_typelist): Return a std::vector.
3390         (push_typelist): Take a std::vector.
3391         (follow_types): Update.  Do not free args.
3392         (type_stack_cleanup): Remove.
3393         * c-exp.y (struct c_parse_state): New.
3394         (cpstate): New global.
3395         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3396         (nonempty_typelist): Update.
3397         (func_mod): Create a new vector.
3398         (c_parse): Create a c_parse_state.
3399         (check_parameter_typelist): Do not delete params.
3400         (function_method): Update.  Do not delete type_list.
3401
3402 2019-01-06  Tom Tromey  <tom@tromey.com>
3403
3404         PR gdb/28155:
3405         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3406         check_typedef.
3407         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3408         (print_return_value): Likewise.
3409
3410 2019-01-05  Tom Tromey  <tom@tromey.com>
3411
3412         * contrib/cleanup_check.py: Remove.
3413         * contrib/gcc-with-excheck: Remove.
3414         * contrib/exsummary.py: Remove.
3415         * contrib/excheck.py: Remove.
3416
3417 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3418
3419         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3420         NULL. Initialize tpprev to NULL instead of assigning it
3421         to NULL on the next statement.
3422         * windows-nat.c (windows_delete_thread): Remove check for
3423         main_thread_id before printing thread exit notifications.
3424         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3425         Remove thread ID check against main_thread_id.
3426         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3427         windows_delete_thread.
3428         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3429
3430 2019-01-04  Tom Tromey  <tom@tromey.com>
3431
3432         * compile/compile.c (_initialize_compile): Use upper case for
3433         metasyntactic variables.
3434         * symmisc.c (_initialize_symmisc): Use upper case for
3435         metasyntactic variables.
3436         * psymtab.c (_initialize_psymtab): Use upper case for
3437         metasyntactic variables.
3438         * demangle.c (demangle_command): Use upper case for metasyntactic
3439         variables.
3440         (_initialize_demangler): Likewise.
3441         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3442         variables.
3443
3444 2019-01-03  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3447
3448 2019-01-03  Tom Tromey  <tom@tromey.com>
3449
3450         * python/py-symtab.c (salpy_str): Update.
3451         (struct salpy_sal_object) <symtab>: Now a PyObject.
3452         (salpy_dealloc): Update.
3453         (del_objfile_sal): Use gdbpy_ref.
3454
3455 2019-01-03  Tom Tromey  <tom@tromey.com>
3456
3457         * python/py-type.c (convert_field): Use new_reference.  Return
3458         gdbpy_ref.
3459         (make_fielditem): Return gdbpy_ref.
3460         (typy_fields): Update.
3461         (typy_getitem): Update.
3462         (field_name): Return gdbpy_ref.  Use new_reference.
3463         (typy_iterator_iternext): Update.
3464
3465 2019-01-03  Tom Tromey  <tom@tromey.com>
3466
3467         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3468
3469 2019-01-03  Tom Tromey  <tom@tromey.com>
3470
3471         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3472         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3473         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3474         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3475         (pspy_set_type_printers): Likewise.
3476         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3477         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3478         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3479         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3480         (objfpy_set_type_printers): Likewise.
3481
3482 2019-01-03  Tom Tromey  <tom@tromey.com>
3483
3484         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3485         (gdbpy_print_stack): Use gdbpy_err_fetch.
3486         * python/python-internal.h (class gdbpy_err_fetch): New class.
3487         (class gdbpy_enter) <m_error_type, m_error_value,
3488         m_error_traceback>: Remove.
3489         <m_error>: New member.
3490         (gdbpy_exception_to_string): Don't declare.
3491         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3492         * python/py-value.c (convert_value_from_python): Use
3493         gdbpy_err_fetch.
3494         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3495         gdbpy_exception_to_string.
3496         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3497         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3498         gdbpy_err_fetch.
3499
3500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * linux-nat.c (delete_lwp_cleanup): Delete.
3503         (struct lwp_deleter): New struct.
3504         (lwp_info_up): New typedef.
3505         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3506         lwp_info_up.
3507
3508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3509
3510         * linux-fork.c (class scoped_switch_fork_info): New class.
3511         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3512
3513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3514
3515         * valops.c (find_overload_match): Remove use of null_cleanup, and
3516         calls to do_cleanups.
3517
3518 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * compile/compile-cplus-types.c
3521         (compile_cplus_instance::decl_name): Handle changes to
3522         cp_func_name.
3523         * cp-support.c (cp_func_name): Update header comment, update
3524         return type.
3525         * cp-support.h (cp_func_name): Update return type in declaration.
3526         * valops.c (find_overload_match): Move temp_func local to top
3527         level of function and change its type.  Use temp_func to hold and
3528         delete temporary string obtained from cp_func_name.
3529
3530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3533         gdb::char_vector, remove cleanup, and update uses of `msg`.
3534
3535 2019-01-03  Jim Wilson  <jimw@sifive.com>
3536
3537         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3538
3539 2019-01-02  Tom Tromey  <tom@tromey.com>
3540
3541         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3542         (tdesc_parse_xml): Remove cleanups.
3543         * target-descriptions.h (make_cleanup_free_target_description):
3544         Don't declare.
3545         (target_desc_deleter): New struct.
3546         (target_desc_up): New typedef.
3547         * target-descriptions.c (target_desc_deleter::operator()): Rename
3548         from free_target_description.
3549         (make_cleanup_free_target_description): Remove.
3550
3551 2019-01-02  Tom Tromey  <tom@tromey.com>
3552
3553         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3554         constructor, destructor.
3555         (linespec_parser): Remove typedef.
3556         (~linespec_parser): Rename from linespec_parser_delete.
3557         (linespec_lex_to_end, linespec_complete_label)
3558         (linespec_complete): Update.
3559         (decode_line_full): Remove cleanups.
3560         (decode_line_1): Update.
3561
3562 2019-01-02  Tom Tromey  <tom@tromey.com>
3563
3564         * python/python-internal.h (inferior_to_inferior_object): Change
3565         return type.
3566         * python/py-exitedevent.c (create_exited_event_object): Update.
3567         * python/py-inferior.c (inferior_to_inferior_object): Return
3568         gdbpy_ref.
3569         (python_new_inferior, python_inferior_deleted)
3570         (thread_to_thread_object, delete_thread_object)
3571         (build_inferior_list, gdbpy_selected_inferior): Update.
3572         * python/py-infthread.c (create_thread_object): Update.  Also fail
3573         if inferior_to_inferior_object fails.
3574
3575 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3576
3577         * inferior.h (class inferior) <displaced_step_state>: New field.
3578         * infrun.h (struct displaced_step_state): Move here from
3579         infrun.c.  Initialize fields, add constructor.
3580         <inf>: Remove field.
3581         <reset>: New method.
3582         * infrun.c (struct displaced_step_inferior_state): Move to
3583         infrun.h.
3584         (displaced_step_inferior_states): Remove.
3585         (get_displaced_stepping_state): Adust.
3586         (displaced_step_in_progress_any_inferior): Adjust.
3587         (displaced_step_in_progress_thread): Adjust.
3588         (displaced_step_in_progress): Adjust.
3589         (add_displaced_stepping_state): Remove.
3590         (get_displaced_step_closure_by_addr): Adjust.
3591         (remove_displaced_stepping_state): Remove.
3592         (infrun_inferior_exit): Call displaced_step_state.reset.
3593         (use_displaced_stepping): Don't check for NULL.
3594         (displaced_step_prepare_throw): Call
3595         get_displaced_stepping_state.
3596         (displaced_step_fixup): Don't check for NULL.
3597         (prepare_for_detach): Don't check for NULL.
3598
3599 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3602          in case of call that did not complete.
3603
3604 2019-01-02  Andrey Utkin  <autkin@undo.io>
3605
3606         * symfile.c (find_separate_debug_file): Fix search of debug files for
3607         remote debuggee.
3608
3609 2019-01-02  Tom Tromey  <tom@tromey.com>
3610
3611         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3612         indentation.
3613         * python/py-frame.c (frapy_older): Remove cast.
3614         (frapy_newer): Likewise.
3615         * python/py-breakpoint.c (local_setattro): Remove cast.
3616         * python/py-arch.c (archpy_name): Remove local variable.
3617         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3618
3619 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3620
3621         * unittests/basic_string_view/element_access/char/empty.cc:
3622         Fix year range in copyright header.
3623
3624 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3625
3626         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3627         Delete.
3628         <operator==>: Update with for removed field.
3629         <hash>: Likewise.
3630         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3631         <isa_features>: ...this.
3632         <abi_features>: New field.
3633         (riscv_isa_flen): Update comment.
3634         (riscv_abi_xlen): New declaration.
3635         (riscv_abi_flen): New declaration.
3636         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3637         isa_features.
3638         (riscv_abi_xlen): New function.
3639         (riscv_isa_flen): Update to get answer from isa_features.
3640         (riscv_abi_flen): New function.
3641         (riscv_has_fp_abi): Update to get answer from abi_features.
3642         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3643         xlen and flen.
3644         (riscv_call_info) <xlen, flen>: Update comment.
3645         (riscv_call_arg_struct): Remove invalid assertions
3646         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3647         is removed.
3648         (riscv_gdbarch_init): Gather isa features and abi features
3649         separately, ensure both match on the gdbarch when reusing an old
3650         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3651         a target with 64-bit float hardware.
3652
3653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3654
3655         * source.c (search_command_helper): Stop reverse search
3656         when line 1 has been searched.
3657
3658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3659
3660         * record-full.c (record_full_base_target::close): Rewrite
3661         record_full_core_buf_list free logic.
3662
3663 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3664
3665         * break-catch-syscall.c (print_one_catch_syscall): xfree
3666         the last text.
3667
3668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3669
3670         * top.c (print_gdb_version): Update Copyright year in version
3671         message.
3672
3673 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3674
3675         Update copyright year range in all GDB files.
3676
3677 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3678
3679         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3680
3681 For older changes see ChangeLog-2018.
3682 \f
3683 Local Variables:
3684 mode: change-log
3685 left-margin: 8
3686 fill-column: 74
3687 version-control: never
3688 coding: utf-8
3689 End:
3690