gdb/ChangeLog

   1 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * .dir-locals.el: Add a comment referencing the other copies of
   4         this file.
   5
   6 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
   9         psargs.
  10
  11 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  12
  13         * .gitattributes: New file.
  14
  15 2020-03-04  Tom Tromey  <tom@tromey.com>
  16
  17         * symmisc.c (print_symbol_bcache_statistics)
  18         (print_objfile_statistics): Update.
  19         * symfile.c (allocate_symtab): Use intern.
  20         * psymtab.c (partial_symtab::partial_symtab): Use intern.
  21         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
  22         macro_cache>: Remove.
  23         <string_cache>: New member.
  24         (struct objfile) <intern>: New methods.
  25         * elfread.c (elf_symtab_read): Use intern.
  26         * dwarf2/read.c (fixup_go_packaging): Intern package name.
  27         (dwarf2_compute_name, dwarf2_physname)
  28         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
  29         names.
  30         (guess_partial_die_structure_name): Update.
  31         (partial_die_info::fixup): Intern name.
  32         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
  33         name.
  34         (dwarf2_name): Intern name.  Update.
  35         * buildsym.c (buildsym_compunit::get_macro_table): Use
  36         string_cache.
  37
  38 2020-03-04  Tom Tromey  <tom@tromey.com>
  39
  40         * jit.c (bfd_open_from_target_memory): Make "target" const.
  41         * corefile.c (gnutarget): Now const.
  42         * gdbcore.h (gnutarget): Now const.
  43
  44 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
  45
  46         * NEWS: Mention support for WOW64 processes.
  47         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
  48         (amd64_windows_segment_register_p): Remove static.
  49         (_initialize_amd64_windows_nat): Update.
  50         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
  51         * i386-windows-nat.c (context_offset): Update.
  52         (i386_mappings): Rename and remove static.
  53         (i386_windows_segment_register_p): Remove static.
  54         (_initialize_i386_windows_nat): Update.
  55         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
  56         (STATUS_WX86_SINGLE_STEP): New macro.
  57         (EnumProcessModulesEx): New macro.
  58         (Wow64SuspendThread): New macro.
  59         (Wow64GetThreadContext): New macro.
  60         (Wow64SetThreadContext): New macro.
  61         (Wow64GetThreadSelectorEntry): New macro.
  62         (windows_set_context_register_offsets): Add static.
  63         (windows_set_segment_register_p): Likewise.
  64         (windows_add_thread): Adapt for WOW64 processes.
  65         (windows_fetch_one_register): Likewise.
  66         (windows_nat_target::fetch_registers): Likewise.
  67         (windows_store_one_register): Likewise.
  68         (display_selector): Likewise.
  69         (display_selectors): Likewise.
  70         (handle_exception): Likewise.
  71         (windows_continue): Likewise.
  72         (windows_nat_target::resume): Likewise.
  73         (windows_add_all_dlls): Likewise.
  74         (do_initial_windows_stuff): Likewise.
  75         (windows_nat_target::attach): Likewise.
  76         (windows_get_exec_module_filename): Likewise.
  77         (windows_nat_target::create_inferior): Likewise.
  78         (windows_xfer_siginfo): Likewise.
  79         (_initialize_loadable): Initialize Wow64SuspendThread,
  80         Wow64GetThreadContext, Wow64SetThreadContext,
  81         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
  82         * windows-nat.h (windows_set_context_register_offsets):
  83         Remove declaration.
  84         (windows_set_segment_register_p): Likewise.
  85         (i386_windows_segment_register_p): Add declaration.
  86         (amd64_windows_segment_register_p): Likewise.
  87
  88 2020-03-04  Luis Machado  <luis.machado@linaro.org>
  89
  90         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
  91         in "info registers" for AArch64/ARM.
  92
  93         The change caused "info registers" to not print GPR's.
  94
  95         gdb/ChangeLog:
  96
  97         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
  98
  99         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 100         when reg->group is empty and reggroup is not.
 101
 102 2020-03-03  Tom Tromey  <tromey@adacore.com>
 103
 104         * dwarf2/frame.c (struct dwarf2_frame_cache)
 105         <checked_tailcall_bottom, entry_cfa_sp_offset,
 106         entry_cfa_sp_offset_p>: Remove members.
 107         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 108         (dwarf2_frame_prev_register): Don't call
 109         dwarf2_tailcall_sniffer_first.
 110         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 111         * frame-unwind.c (add_unwinder): New fuction.
 112         (frame_unwind_init): Use it.  Add tailcall unwinder.
 113
 114 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 115             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 116
 117         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 118         value should be printed as true.
 119
 120 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 121
 122         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 123         (windows_init_abi): Set and use windows_so_ops.
 124
 125 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 126
 127         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 128         when verifying if dealing with a convenience variable.
 129
 130 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 131
 132         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 133
 134 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 135
 136         * infrun.c (gdbarch_supports_displaced_stepping): New.
 137         (use_displaced_stepping): Break up conditions in smaller pieces.
 138         Use gdbarch_supports_displaced_stepping.
 139         (displaced_step_prepare_throw): Use
 140         gdbarch_supports_displaced_stepping.
 141
 142 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * NEWS: Mention new behaviour of the history filename.
 145         * top.c (write_history_p): Add comment.
 146         (show_write_history_p): Add header comment, give a different
 147         message when history writing is on, but the history filename is
 148         empty.
 149         (history_filename): Add comment.
 150         (history_filename_empty): New function.
 151         (show_history_filename): Add header comment, give a different
 152         message when the filename is empty.
 153         (init_history): Compare history_filename against nullptr, and only
 154         read history if the filename is not empty.
 155         (set_history_filename): Add header comment, and only make
 156         non-empty filenames absolute.
 157         (init_main): Make the filename argument to 'set history filename'
 158         optional.
 159
 160 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 161
 162         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 163         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 164         (fetch_fp_register): Update.
 165         (fetch_fp_regs): Update.
 166         (store_fp_register): Update.
 167         (store_fp_regs): Update.
 168         (arm_netbsd_nat_target::read_description): New function.
 169         (fetch_elfcore_registers): Update.
 170
 171 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 174         general_thread if the stop reply is missing a thread-id.
 175         (remote_target::process_stop_reply): Use the first non-exited
 176         thread if the target didn't pass a thread-id.
 177         * infrun.c (do_target_wait): Move call to
 178         switch_to_inferior_no_thread to ....
 179         (do_target_wait_1): ... here.
 180
 181 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 182
 183         * debuginfod-support.c: Include defs.h first.
 184
 185 2020-02-28  Tom de Vries  <tdevries@suse.de>
 186
 187         * symfile.c (set_initial_language): Use default language for lookup.
 188
 189 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 190
 191         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 192         reader variable, pass `this` to read_cutu_die_from_dwo.
 193
 194 2020-02-27  Aaron Merey  <amerey@redhat.com>
 195
 196         * source.c (open_source_file): Check for nullptr when computing
 197         srcpath.
 198
 199 2020-02-27  Tom Tromey  <tromey@adacore.com>
 200
 201         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 202         member.
 203         (dwarf2_add_field): Don't update nfields.
 204         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 205
 206 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 209         abs.
 210
 211 2020-02-26  Tom Tromey  <tom@tromey.com>
 212
 213         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 214         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 215         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 216         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 217         per_cu_data.
 218
 219 2020-02-26  Tom Tromey  <tom@tromey.com>
 220
 221         * dwarf2/index-write.c (psym_index_map): Change type.
 222         (add_address_entry_worker, write_one_signatured_type)
 223         (recursively_count_psymbols, recursively_write_psymbols)
 224         (class debug_names, psyms_seen_size, write_gdbindex)
 225         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 226
 227 2020-02-26  Aaron Merey  <amerey@redhat.com>
 228
 229         * Makefile.in: Handle optional debuginfod support.
 230         * NEWS: Update.
 231         * README: Add --with-debuginfod summary.
 232         * config.in: Regenerate.
 233         * configure: Regenerate.
 234         * configure.ac: Handle optional debuginfod support.
 235         * debuginfod-support.c: debuginfod helper functions.
 236         * debuginfod-support.h: Ditto.
 237         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 238         summary.
 239         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 240         when a dwz file cannot be found.
 241         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 242         debuginfo file cannot be found.
 243         * source.c (open_source_file): Query debuginfod servers when a
 244         source file cannot be found.
 245         * top.c (print_gdb_configuration): Include
 246         --{with,without}-debuginfod in the output.
 247
 248 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 249
 250         * thread.c (thr_try_catch_cmd): Print thread name.
 251
 252 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 253
 254         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 255         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 256         dwarf2_fetch_die_type_sect_off): Move to...
 257         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 258         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 259         dwarf2_fetch_die_type_sect_off): ... here.
 260         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 261         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 262         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 263
 264 2020-02-26  Tom de Vries  <tdevries@suse.de>
 265
 266         PR gdb/25603
 267         * symfile.c (set_initial_language): Exit-early if
 268         language_mode == language_mode_manual.
 269
 270 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 271
 272         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 273         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 274         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 275
 276 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * gdbtypes.c (create_array_type_with_stride): Handle negative
 279         array strides.
 280         * valarith.c (value_subscripted_rvalue): Likewise.
 281
 282 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 283
 284         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 285
 286 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 287
 288         * loc.h (dwarf2_get_die_type): Move to...
 289         * read.h (dwarf2_get_die_type): ... here.
 290         * read.c (dwarf2_get_die_type): Move doc to header.
 291
 292 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 293
 294         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 295         'gnulib/Makefile.in' to the list.
 296
 297 2020-02-24  Tom Tromey  <tom@tromey.com>
 298
 299         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 300         Remove.
 301         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 302         XOBNEWVEC.
 303
 304 2020-02-24  Tom Tromey  <tom@tromey.com>
 305
 306         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 307         New method.
 308         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 309         (dw2_do_instantiate_symtab, dw2_get_file_names)
 310         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 311
 312 2020-02-24  Tom Tromey  <tom@tromey.com>
 313
 314         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 315         make_scoped_restore.
 316         (dwarf2_psymtab::read_symtab): Don't clear
 317         reading_partial_symbols.
 318
 319 2020-02-24  Tom de Vries  <tdevries@suse.de>
 320
 321         PR gdb/25592
 322         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 323
 324 2020-02-24  Tom de Vries  <tdevries@suse.de>
 325
 326         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 327         commands layout next/prev/regs.
 328
 329 2020-02-22  Tom Tromey  <tom@tromey.com>
 330
 331         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 332         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 333
 334 2020-02-22  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 337
 338 2020-02-22  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 341         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 342         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 343         * tui/tui.c (_initialize_tui): Add usage text.
 344
 345 2020-02-22  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-win.c (tui_set_focus_command)
 348         (tui_set_win_height_command): Use error_no_arg.
 349         (_initialize_tui_win): Update help text.
 350         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 351
 352 2020-02-22  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 355         * tui/tui-disasm.h (struct tui_disasm_window)
 356         <display_start_addr>: Declare.
 357         * tui/tui-source.h (struct tui_source_window)
 358         <display_start_addr>: Declare.
 359         * tui/tui-winsource.h (struct tui_source_window_base)
 360         <show_source_line, display_start_addr>: New methods.
 361         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 362         Rename and move to protected section.
 363         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 364         (tui_source_window_base::do_erase_source_content): Update.
 365         (tui_source_window_base::show_source_line): Now a method.
 366         (tui_source_window_base::show_source_content)
 367         (tui_source_window_base::tui_source_window_base)
 368         (tui_source_window_base::rerender)
 369         (tui_source_window_base::refill)
 370         (tui_source_window_base::do_scroll_horizontal)
 371         (tui_source_window_base::set_is_exec_point_at)
 372         (tui_source_window_base::update_breakpoint_info)
 373         (tui_source_window_base::update_exec_info): Update.
 374         * tui/tui-source.c (tui_source_window::set_contents)
 375         (tui_source_window::showing_source_p)
 376         (tui_source_window::do_scroll_vertical)
 377         (tui_source_window::location_matches_p)
 378         (tui_source_window::line_is_displayed): Update.
 379         (tui_source_window::display_start_addr): New method.
 380         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 381         (tui_disasm_window::do_scroll_vertical)
 382         (tui_disasm_window::location_matches_p): Update.
 383         (tui_disasm_window::display_start_addr): New method.
 384
 385 2020-02-22  Tom Tromey  <tom@tromey.com>
 386
 387         * NEWS: Add entry for gdb.register_window_type.
 388         * tui/tui-layout.h (window_factory): New typedef.
 389         (tui_register_window): Declare.
 390         * tui/tui-layout.c (saved_tui_windows): New global.
 391         (tui_apply_current_layout): Use it.
 392         (tui_register_window): New function.
 393         * python/python.c (do_start_initialization): Call
 394         gdbpy_initialize_tui.
 395         (python_GdbMethods): Add "register_window_type" function.
 396         * python/python-internal.h (gdbpy_register_tui_window)
 397         (gdbpy_initialize_tui): Declare.
 398         * python/py-tui.c: New file.
 399         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 400
 401 2020-02-22  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 404
 405 2020-02-22  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 408         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 409         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 410         (tui_set_win_focus_to): Move from tui-win.c.
 411
 412 2020-02-22  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 415         functions.
 416         (known_window_types): New global.
 417         (tui_get_window_by_name): Reimplement.
 418         (initialize_known_windows): New function.
 419         (validate_window_name): Rewrite.
 420         (_initialize_tui_layout): Call initialize_known_windows.
 421
 422 2020-02-22  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 425         Remove constants.
 426         * tui/tui-winsource.h (struct tui_source_window_base)
 427         <tui_source_window_base>: Remove parameter.
 428         * tui/tui-winsource.c
 429         (tui_source_window_base::tui_source_window_base): Remove
 430         parameter.
 431         (tui_source_window_base::refill): Update.
 432         * tui/tui-stack.h (struct tui_locator_window)
 433         <tui_locator_window>: Update.
 434         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 435         Default the constructor.
 436         * tui/tui-regs.h (struct tui_data_item_window)
 437         <tui_data_item_window>: Default the constructor.
 438         (struct tui_data_window) <tui_data_window>: Likewise.
 439         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 440         Default the constructor.
 441         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 442         Default the constructor.
 443         <type>: Remove.
 444         (struct tui_win_info) <tui_win_info>: Default the constructor.
 445         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 446         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 447         Default the constructor.
 448
 449 2020-02-22  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 452         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 453         * tui/tui-win.c (tui_resize_all): Don't call
 454         tui_delete_invisible_windows.
 455         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 456         done.
 457         (tui_set_layout): Update.
 458         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 459         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 460         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 461
 462 2020-02-22  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 465         correctly.
 466
 467 2020-02-22  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 470
 471 2020-02-22  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-winsource.h (struct tui_source_window_iterator)
 474         <inner_iterator>: New etytypedef.
 475         <tui_source_window_iterator>: Take "end" parameter.
 476         <tui_source_window_iterator>: Take iterator.
 477         <operator*, advance>: Update.
 478         <m_iter>: Change type.
 479         <m_end>: New field.
 480         (struct tui_source_windows) <begin, end>: Update.
 481         * tui/tui-layout.c (tui_windows): New global.
 482         (tui_apply_current_layout): Clear tui_windows.
 483         (tui_layout_window::apply): Update tui_windows.
 484         * tui/tui-data.h (tui_windows): Declare.
 485         (all_tui_windows): Now inline function.
 486         (class tui_window_iterator, struct all_tui_windows): Remove.
 487
 488 2020-02-22  Tom Tromey  <tom@tromey.com>
 489
 490         PR tui/17850:
 491         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 492         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 493         "height" argument.
 494         (class tui_layout_window) <get_sizes>: Likewise.
 495         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 496         argument.
 497         <get_sizes>: Add "height" argument.
 498         <m_vertical>: New field.
 499         * tui/tui-layout.c (tui_layout_split::clone): Update.
 500         (tui_layout_split::get_sizes): Add "height" argument.
 501         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 502         (tui_new_layout_command): Parse "-horizontal".
 503         (_initialize_tui_layout): Update help string.
 504         (tui_layout_split::specification): Add "-horizontal" when needed.
 505         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 506         argument.
 507         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 508         New methods.
 509
 510 2020-02-22  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-layout.h (enum tui_adjust_result): New.
 513         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 514         (class tui_layout_window) <adjust_size>: Return
 515         tui_adjust_result.  Rewrite.
 516         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 517         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 518
 519 2020-02-22  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 522         parameter and return types.
 523         (class tui_layout_base) <specification>: Add "depth".
 524         (class tui_layout_window) <specification>: Add "depth".
 525         (class tui_layout_split) <specification>: Add "depth".
 526         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 527         and return types.
 528         (tui_new_layout_command): Parse sub-layouts.
 529         (_initialize_tui_layout): Update help string.
 530         (tui_layout_window::specification): Add "depth".
 531         (add_layout_command): Update.
 532
 533 2020-02-22  Tom Tromey  <tom@tromey.com>
 534
 535         * NEWS: Add "tui new-layout" item.
 536         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 537         Add new-layout command to help text.
 538         (validate_window_name): New function.
 539         (tui_new_layout_command): New function.
 540         (_initialize_tui_layout): Register "new-layout".
 541         (tui_layout_window::specification): New method.
 542         (tui_layout_window::specification): New method.
 543         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 544         method.
 545         (class tui_layout_window) <specification>: New method.
 546         (class tui_layout_split) <specification>: New method.
 547
 548 2020-02-22  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 551         * tui/tui-win.c (window_name_completer): Update comment.
 552         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 553         Declare method.
 554         (class tui_layout_window) <replace_window>: Likewise.
 555         (class tui_layout_split) <replace_window>: Likewise.
 556         (tui_set_layout): Don't declare.
 557         (tui_set_initial_layout): Declare function.
 558         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 559         (asm_regs_layout): New globals.
 560         (tui_current_layout, show_layout): Remove.
 561         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 562         (find_layout, tui_apply_layout): New function.
 563         (layout_completer): Remove.
 564         (tui_next_layout): Reimplement.
 565         (tui_next_layout_command): New function.
 566         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 567         (tui_regs_layout): Reimplement.
 568         (tui_regs_layout_command): New function.
 569         (extract_display_start_addr): Rewrite.
 570         (next_layout, prev_layout): Remove.
 571         (tui_layout_window::replace_window): New method.
 572         (tui_layout_split::replace_window): New method.
 573         (destroy_layout): New function.
 574         (layout_list): New global.
 575         (add_layout_command): New function.
 576         (initialize_layouts): Update.
 577         (tui_layout_command): New function.
 578         (_initialize_tui_layout): Install "layout" commands.
 579         * tui/tui-data.h (enum tui_layout_type): Remove.
 580         (tui_current_layout): Don't declare.
 581
 582 2020-02-22  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-regs.c (tui_reg_layout): Remove.
 585         (tui_reg_command): Use tui_regs_layout.
 586         * tui/tui-layout.h (tui_reg_command): Declare.
 587         * tui/tui-layout.c (tui_reg_command): New function.
 588
 589 2020-02-22  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui.c (tui_rl_delete_other_windows): Call
 592         tui_remove_some_windows.
 593         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 594         Declare method.
 595         (class tui_layout_window) <remove_windows>: New method.
 596         (class tui_layout_split) <remove_windows>: Declare.
 597         (tui_remove_some_windows): Declare.
 598         * tui/tui-layout.c (tui_remove_some_windows): New function.
 599         (tui_layout_split::remove_windows): New method.
 600
 601 2020-02-22  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 604         * tui/tui-layout.h (tui_next_layout): Declare.
 605         * tui/tui-layout.c (tui_next_layout): New function.
 606
 607 2020-02-22  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 610         correct coordinates.
 611
 612 2020-02-22  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 615         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 616         DATA_WIN case.
 617
 618 2020-02-22  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 621         TUI_DISASM_WIN, not tui_win_list.
 622
 623 2020-02-22  Tom Tromey  <tom@tromey.com>
 624
 625         * valprint.c (generic_val_print_enum_1)
 626         (val_print_type_code_flags): Style member names.
 627         * rust-lang.c (val_print_struct, rust_print_enum)
 628         (rust_print_struct_def, rust_internal_print_type): Style member
 629         names.
 630         * p-valprint.c (pascal_object_print_value_fields): Style member
 631         names.  Only call fprintf_symbol_filtered for static members.
 632         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 633         * f-valprint.c (f_val_print): Style member names.
 634         * f-typeprint.c (f_type_print_base): Style member names.
 635         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 636         call fprintf_symbol_filtered for static members.
 637         (cp_print_class_member): Style member names.
 638         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 639         member names.
 640         * ada-valprint.c (ada_print_scalar): Style enum names.
 641         (ada_val_print_enum): Likewise.
 642         * ada-typeprint.c (print_enum_type): Style enum names.
 643
 644 2020-02-21  Tom Tromey  <tom@tromey.com>
 645
 646         * psympriv.h (struct partial_symtab): Update comment.
 647
 648 2020-02-21  Tom Tromey  <tromey@adacore.com>
 649
 650         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 651         type is CORE_ADDR.
 652
 653 2020-02-21  Tom de Vries  <tdevries@suse.de>
 654
 655         PR gdb/25534
 656         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 657         if dependencies[i]->user != NULL.
 658
 659 2020-02-21  Ali Tamur  <tamur@google.com>
 660
 661         * dwarf2/read.c (dwarf2_name): Add null check.
 662
 663 2020-02-20  Tom Tromey  <tom@tromey.com>
 664
 665         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 666         ">=", in binary search.
 667         (dwarf2_find_containing_comp_unit): New overload.
 668         (run_test): New self-test.
 669         (_initialize_dwarf2_read): Register new test.
 670
 671 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 672
 673         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 674         * riscv-tdep.h: Likewise.
 675         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 676         rv32-only CSR.
 677         * features/riscv/64bit-csr.xml: Regenerated.
 678
 679 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 680             Tom Tromey  <tom@tromey.com>
 681
 682         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 683         of 'fputc_unfiltered'.
 684         (putchar_unfiltered): Call 'fputc_unfiltered'.
 685         (fputc_unfiltered): Call 'fputs_unfiltered'.
 686
 687 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * config.in: Regenerate.
 690         * configure: Regenerate.
 691         * configure.ac: Add --with-python-libdir option.
 692         * main.c: Use WITH_PYTHON_LIBDIR.
 693
 694 2020-02-19  Tom Tromey  <tom@tromey.com>
 695
 696         * symtab.c (general_symbol_info::compute_and_set_names): Use
 697         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 698
 699 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 700
 701         * dwarf2/read.c (allocate_signatured_type_table,
 702         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 703         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 704         Remove objfile parameter, update all callers.
 705
 706 2020-02-19  Doug Evans  <dje@google.com>
 707
 708         PR rust/25535
 709         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 710         rust_enum_variant calculation.
 711
 712 2020-02-19  Tom Tromey  <tromey@adacore.com>
 713
 714         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 715
 716 2020-02-19  Tom Tromey  <tromey@adacore.com>
 717
 718         * ada-lang.c (cache_symbol): Use obstack_strdup.
 719
 720 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * configure: Regenerate.
 723
 724 2020-02-19  Tom Tromey  <tromey@adacore.com>
 725
 726         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 727         NULL check.
 728
 729 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
 730
 731         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
 732
 733 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
 736         if GDBSERVER is not defined.
 737         (riscv_tdesc_cache): Likewise, also store const target_desc.
 738         (STATIC_IN_GDB): Define.
 739         (riscv_create_target_description): Update declaration with
 740         STATIC_IN_GDB.
 741         (riscv_lookup_target_description): New function, only define if
 742         GDBSERVER is not defined.
 743         * arch/riscv.h (riscv_create_target_description): Declare only
 744         when GDBSERVER is defined.
 745         (riscv_lookup_target_description): New declaration when GDBSERVER
 746         is not defined.
 747         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
 748         (riscv_linux_read_features): ...this, and return
 749         riscv_gdbarch_features instead of target_desc.
 750         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
 751         (riscv_linux_read_description): Rename to...
 752         (riscv_linux_read_features): ...this.
 753         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 754         Update to use riscv_gdbarch_features and
 755         riscv_lookup_target_description.
 756         * riscv-tdep.c (riscv_find_default_target_description): Use
 757         riscv_lookup_target_description instead of
 758         riscv_create_target_description.
 759
 760 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 761
 762         * valprint.c (generic_val_print_enum_1): When printing a flag
 763         enum with value 0 and there is no enumerator with value 0, print
 764         just "0" instead of "(unknown: 0x0)".
 765
 766 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 767
 768         * valprint.c (generic_val_print_enum_1): Print unknown part of
 769         flag enum in hex.
 770
 771 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 772
 773         * dwarf2/read.c (update_enumeration_type_from_children): Allow
 774         flag enums to contain duplicate enumerators.
 775         * valprint.c (generic_val_print_enum_1): Update comment.
 776
 777 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 778
 779         * dwarf2/read.c: Include "count-one-bits.h".
 780         (update_enumeration_type_from_children): If an enumerator has
 781         multiple bits set, don't treat the enumeration as a "flag enum".
 782         * valprint.c (generic_val_print_enum_1): Assert that enumerators
 783         of flag enums have 0 or 1 bit set.
 784
 785 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 786
 787         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
 788         conversion.
 789         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 790         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 791         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 792         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 793         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 794
 795 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 796
 797         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
 798
 799 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 800
 801         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
 802         displaced_step_closure_up.
 803         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 804         (struct displaced_step_closure_up):
 805         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 806         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 807         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
 808         Likewise.
 809         * gdbarch.sh (displaced_step_copy_insn): Likewise.
 810         * gdbarch.c, gdbarch.h: Re-generate.
 811         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
 812         displaced_step_closure_up.
 813         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 814         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 815         * infrun.h (displaced_step_closure_up): New type alias.
 816         (struct displaced_step_inferior_state) <step_closure>: Change
 817         type to displaced_step_closure_up.
 818         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
 819         displaced_step_closure_up.
 820         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 821
 822 2020-02-14  Tom Tromey  <tom@tromey.com>
 823
 824         * minidebug.c (gnu_debug_key): New global.
 825         (find_separate_debug_file_in_section): Use it.
 826
 827 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 828
 829         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
 830         std::unique_ptr.
 831         * gdbarch.c: Re-generate.
 832         * gdbarch.h: Re-generate.
 833         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
 834         change.
 835         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
 836         type to std::unique_ptr.
 837         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 838         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 839         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 840         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 841         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
 842         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 843         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 844         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 845         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 846
 847 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 848
 849         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
 850         std::unique_ptr.
 851         (displaced_step_clear): Rename to...
 852         (displaced_step_reset): ... this.  Just call displaced->reset ().
 853         (displaced_step_clear_cleanup): Rename to...
 854         (displaced_step_reset_cleanup): ... this.
 855         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
 856         (displaced_step_fixup): Likewise.
 857         (resume_1): Likewise.
 858         (handle_inferior_event): Restore child's memory before calling
 859         displaced_step_fixup on the parent.
 860         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
 861         to std::unique_ptr.
 862         <step_closure>: Change type to std::unique_ptr.
 863
 864 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 865
 866         * arm-tdep.c: Include count-one-bits.h.
 867         (cleanup_block_store_pc): Use count_one_bits.
 868         (cleanup_block_load_pc): Use count_one_bits.
 869         (arm_copy_block_xfer): Use count_one_bits.
 870         (thumb2_copy_block_xfer): Use count_one_bits.
 871         (thumb_copy_pop_pc_16bit): Use count_one_bits.
 872         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
 873         (thumb_get_next_pcs_raw): Use count_one_bits.
 874         (arm_get_next_pcs_raw): Use count_one_bits_l.
 875         * arch/arm.c (bitcount): Remove.
 876         * arch/arm.h (bitcount): Remove.
 877
 878 2020-02-14  Tom Tromey  <tromey@adacore.com>
 879
 880         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
 881         Update.
 882         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
 883         * dwarf2/loc.c (call_site_find_chain_1): Return
 884         unique_xmalloc_ptr.
 885         (call_site_find_chain): Likewise.
 886
 887 2020-02-14  Richard Biener  <rguenther@suse.de>
 888
 889         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
 890         on expression with division operators.
 891
 892 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 893
 894         * MAINTAINERS (Write After Approval): Adding myself.
 895
 896 2020-02-12  Tom Tromey  <tom@tromey.com>
 897
 898         * event-loop.c (event_data, gdb_event, event_handler_func):
 899         Remove.
 900
 901 2020-02-12  Tom Tromey  <tom@tromey.com>
 902
 903         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
 904         (dwarf2_frame_objfile_data): Add comment.
 905         (find_comp_unit, set_comp_unit): New functions.
 906         (dwarf2_frame_find_fde): Use find_comp_unit.
 907         (dwarf2_build_frame_info): Use set_comp_unit.
 908
 909 2020-02-12  Tom Tromey  <tom@tromey.com>
 910
 911         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
 912         (comp_unit): Don't initialize objfile.
 913         (execute_cfa_program): Add text_offset parameter.
 914         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
 915         (dwarf2_frame_cache): Update.
 916         (dwarf2_build_frame_info): Don't set "objfile" member.
 917
 918 2020-02-12  Tom Tromey  <tom@tromey.com>
 919
 920         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
 921         (decode_frame_entry): Likewise.
 922         (dwarf2_build_frame_info): Update.
 923
 924 2020-02-12  Tom Tromey  <tom@tromey.com>
 925
 926         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
 927         (decode_frame_entry_1): Use the comp_unit obstack.
 928
 929 2020-02-12  Tom Tromey  <tom@tromey.com>
 930
 931         * dwarf2/frame.c (struct comp_unit): Add initializers and
 932         constructor.
 933         (dwarf2_frame_objfile_data): Store a comp_unit.
 934         (dwarf2_frame_find_fde): Update.
 935         (dwarf2_build_frame_info): Use "new".
 936
 937 2020-02-12  Tom Tromey  <tom@tromey.com>
 938
 939         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
 940         (dwarf2_fde_table): Typedef for std::vector.
 941         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
 942         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
 943         (decode_frame_entry): Update.
 944         (dwarf2_build_frame_info): Use "new".
 945
 946 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 947
 948         * arm-tdep.c (arm_gdbarch_init): Update.
 949         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
 950         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
 951         have_neon, is_m>: Change to bool.
 952
 953 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 954
 955         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
 956
 957 2020-02-12  Tom Tromey  <tom@tromey.com>
 958
 959         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
 960
 961 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
 962
 963         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
 964         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
 965
 966 2020-02-11  Tom Tromey  <tom@tromey.com>
 967
 968         * psymtab.h: Update comment.
 969
 970 2020-02-11  Tom Tromey  <tom@tromey.com>
 971
 972         * gdb_obstack.h (struct auto_obstack): Use
 973         DISABLE_COPY_AND_ASSIGN.
 974
 975 2020-02-11  Tom Tromey  <tom@tromey.com>
 976
 977         * dwarf2/frame.h (struct objfile): Don't forward declare.
 978
 979 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 980
 981         * cris-tdep.c (cris_supply_gregset): Change signature to match
 982         what struct regset expects.
 983         (cris_regset): New struct.
 984         (fetch_core_registers): Remove.
 985         (cris_iterate_over_regset_sections): New function.
 986         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
 987         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
 988
 989 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 990
 991         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
 992         registers.
 993
 994 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 995
 996         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
 997
 998 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 999
1000         * configure: Re-generate.
1001
1002 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1003
1004         * configure: Re-generate.
1005
1006 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * acinclude: Update warning.m4 path.
1009         * warning.m4: Move to gdbsupport.
1010
1011 2020-02-11  Tom Tromey  <tromey@adacore.com>
1012
1013         * remote.c (remote_console_output): Update.
1014         * printcmd.c (printf_command): Update.
1015         * event-loop.c (gdb_wait_for_event): Update.
1016         * linux-nat.c (sigchld_handler): Update.
1017         * remote-sim.c (gdb_os_write_stdout): Update.
1018         (gdb_os_flush_stdout): Update.
1019         (gdb_os_flush_stderr): Update.
1020         (gdb_os_write_stderr): Update.
1021         * exceptions.c (print_exception): Update.
1022         * remote-fileio.c (remote_fileio_func_read): Update.
1023         (remote_fileio_func_write): Update.
1024         * tui/tui.c (tui_enable): Update.
1025         * tui/tui-interp.c (tui_interp::init): Update.
1026         * utils.c (init_page_info): Update.
1027         (putchar_unfiltered, fputc_unfiltered): Update.
1028         (gdb_flush): Update.
1029         (emit_style_escape): Update.
1030         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1031         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1032         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1033         (stderr_file::write): Update.
1034         (stderr_file::puts): Update.
1035         * ui-file.h (ui_file_isatty, ui_file_write)
1036         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1037         (ui_file_puts): Don't declare.
1038
1039 2020-02-10  Tom de Vries  <tdevries@suse.de>
1040
1041         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1042         sentinel to char *.
1043
1044 2020-02-09  Tom de Vries  <tdevries@suse.de>
1045
1046         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1047         filename if it matches "<artificial>".
1048
1049 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1050
1051         * windows-tdep.c (struct enum_value_name): New struct.
1052         (create_enum): New function.
1053         (windows_get_siginfo_type): Create and use enum types.
1054
1055 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1056
1057         * NEWS: Mention $_siginfo support for Windows.
1058         * windows-nat.c (handle_exception): Set siginfo_er.
1059         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1060         (windows_xfer_siginfo): New function.
1061         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1062         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1063         (init_windows_gdbarch_data): New function.
1064         (get_windows_gdbarch_data): New function.
1065         (windows_get_siginfo_type): New function.
1066         (windows_init_abi): Register windows_get_siginfo_type.
1067         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1068
1069 2020-02-08  Tom Tromey  <tom@tromey.com>
1070
1071         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1072         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1073         <keep>: Declare method.
1074         <m_keep>: Remove member.
1075         <~cutu_reader>: Remove.
1076         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1077         (cutu_reader::cutu_reader): Update.
1078         (cutu_reader::keep): Rename from ~cutu_reader.
1079         (process_psymtab_comp_unit, build_type_psymtabs_1)
1080         (process_skeletonless_type_unit, load_partial_comp_unit)
1081         (load_full_comp_unit, dwarf2_read_addr_index)
1082         (read_signatured_type): Update.
1083
1084 2020-02-08  Tom Tromey  <tom@tromey.com>
1085
1086         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1087         "want_partial_unit" parameter.
1088         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1089         Inline check for DW_TAG_partial_unit.
1090         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1091
1092 2020-02-08  Tom Tromey  <tom@tromey.com>
1093
1094         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1095         read.c.
1096         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1097         read.c.
1098
1099 2020-02-08  Tom Tromey  <tom@tromey.com>
1100
1101         * dwarf2/read.c (read_address): Move to comp-unit.c.
1102         (dwarf2_rnglists_process, dwarf2_ranges_process)
1103         (read_attribute_value, dwarf_decode_lines_1)
1104         (var_decode_location, decode_locdesc): Update.
1105         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1106         read.c.  Remove "cu" parameter.
1107         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1108         method.
1109
1110 2020-02-08  Tom Tromey  <tom@tromey.com>
1111
1112         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1113         (read_indirect_line_string): Update.
1114         * dwarf2/comp-unit.c (read_offset): Remove.
1115         (read_comp_unit_head): Update.
1116         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1117         method.
1118         (read_offset): Don't declare.
1119
1120 2020-02-08  Tom Tromey  <tom@tromey.com>
1121
1122         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1123         * dwarf2/read.c (struct comp_unit_head): Move to
1124         dwarf2/comp-unit.h.
1125         (enum class rcuh_kind): Move to comp-unit.h.
1126         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1127         (read_comp_unit_head, error_check_comp_unit_head)
1128         (read_and_check_comp_unit_head): Move to comp-unit.c.
1129         (read_offset, dwarf_unit_type_name): Likewise.
1130         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1131         (cutu_reader::cutu_reader, read_call_site_scope)
1132         (find_partial_die, follow_die_offset): Update.
1133         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1134
1135 2020-02-08  Tom Tromey  <tom@tromey.com>
1136
1137         * dwarf2/read.c (read_offset_1): Move to leb.c.
1138         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1139         (dwarf_decode_macro_bytes): Update.
1140         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1141         * dwarf2/leb.h (read_offset): Declare.
1142
1143 2020-02-08  Tom Tromey  <tom@tromey.com>
1144
1145         * dwarf2/read.c (dwarf2_section_size): Remove.
1146         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1147         Update.
1148         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1149
1150 2020-02-08  Tom Tromey  <tom@tromey.com>
1151
1152         * dwarf2/read.c (read_initial_length): Move to leb.c.
1153         * dwarf2/leb.h (read_initial_length): Declare.
1154         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1155         handle_nonstd parameter.
1156         * dwarf2/frame.c (read_initial_length): Remove.
1157         (decode_frame_entry_1): Update.
1158
1159 2020-02-08  Tom Tromey  <tom@tromey.com>
1160
1161         * dwarf2/loc.c (dwarf2_find_location_expression)
1162         (dwarf_evaluate_loc_desc::get_tls_address)
1163         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1164         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1165         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1166         (dwarf2_compile_property_to_c)
1167         (dwarf2_loc_desc_get_symbol_read_needs)
1168         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1169         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1170         (loclist_describe_location, loclist_tracepoint_var_ref)
1171         (loclist_generate_c_location): Update.
1172         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1173         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1174         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1175         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1176         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1177         (dwarf2_per_cu_data::addr_size)
1178         (dwarf2_per_cu_data::ref_addr_size)
1179         (dwarf2_per_cu_data::text_offset)
1180         (dwarf2_per_cu_data::addr_type): Now methods.
1181         (per_cu_header_read_in): Make per_cu "const".
1182         (dwarf2_version): Remove.
1183         (dwarf2_per_cu_data::int_type): Now a method.
1184         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1185         (set_die_type, read_array_type, read_subrange_index_type)
1186         (read_tag_string_type, read_subrange_type): Update.
1187         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1188         offset_size, ref_addr_size, text_offset, addr_type, version,
1189         objfile, int_type, addr_sized_int_type>: Declare methods.
1190
1191 2020-02-08  Tom Tromey  <tom@tromey.com>
1192
1193         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1194         Move earlier.
1195
1196 2020-02-08  Tom Tromey  <tom@tromey.com>
1197
1198         * dwarf2/read.h (dwarf_line_debug): Declare.
1199         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1200         * dwarf2/read.c: Move line_header code to new files.
1201         (dwarf_line_debug): No longer static.
1202         * dwarf2/line-header.c: New file.
1203         * dwarf2/line-header.h: New file.
1204
1205 2020-02-08  Tom Tromey  <tom@tromey.com>
1206
1207         * dwarf2/read.c (struct line_header) <file_full_name,
1208         file_file_name>: Return unique_xmalloc_ptr.
1209         (line_header::file_file_name): Update.
1210         (line_header::file_full_name): Update.
1211         (dw2_get_file_names_reader): Update.
1212         (macro_start_file): Update.
1213
1214 2020-02-08  Tom Tromey  <tom@tromey.com>
1215
1216         * dwarf2/read.c (struct line_header) <file_full_name,
1217         file_file_name>: Declare methods.
1218         (dw2_get_file_names_reader): Update.
1219         (file_file_name): Now a method.
1220         (file_full_name): Likewise.
1221         (macro_start_file): Update.
1222
1223 2020-02-08  Tom Tromey  <tom@tromey.com>
1224
1225         * dwarf2/read.c (dwarf_always_disassemble)
1226         (show_dwarf_always_disassemble): Move to loc.c.
1227         (_initialize_dwarf2_read): Move "always-disassemble" registration
1228         to loc.c.
1229         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1230         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1231         static.
1232         (show_dwarf_always_disassemble): Move from read.c.
1233         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1234
1235 2020-02-08  Tom Tromey  <tom@tromey.com>
1236
1237         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1238         (create_quick_file_names_table): Return htab_up.
1239         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1240         Update.
1241         * dwarf2/read.h (struct dwarf2_per_objfile)
1242         <quick_file_names_table>: Now htab_up.
1243
1244 2020-02-08  Tom Tromey  <tom@tromey.com>
1245
1246         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1247
1248 2020-02-08  Tom Tromey  <tom@tromey.com>
1249
1250         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1251         Rewrite.
1252         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1253         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1254         (abbrev_table::abbrev_table): No longer inline.
1255         (ABBREV_HASH_SIZE): Remove.
1256         (abbrev_table::m_abbrevs): Now an htab_up.
1257
1258 2020-02-08  Tom Tromey  <tom@tromey.com>
1259
1260         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1261         (cutu_reader): Update.
1262         (build_type_psymtabs_1): Update.
1263         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1264         (abbrev_table::alloc_abbrev): Update.
1265         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1266         (abbrev_table::read): New static method, renamed from
1267         abbrev_table_read_table.
1268         (abbrev_table::alloc_abbrev)
1269         (abbrev_table::add_abbrev): Now private.
1270         (abbrev_table::abbrev_table): Now private.
1271         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1272
1273 2020-02-08  Tom Tromey  <tom@tromey.com>
1274
1275         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1276         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1277         htab_up.
1278
1279 2020-02-08  Tom Tromey  <tom@tromey.com>
1280
1281         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1282         htab_up.
1283         (lookup_dwo_unit_in_dwp): Update.
1284         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1285         on obstack.
1286
1287 2020-02-08  Tom Tromey  <tom@tromey.com>
1288
1289         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1290         obstack.
1291
1292 2020-02-08  Tom Tromey  <tom@tromey.com>
1293
1294         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1295         line_header_hash.
1296         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1297         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1298         Change type to htab_up.
1299
1300 2020-02-08  Tom Tromey  <tom@tromey.com>
1301
1302         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1303         htab_up.  Don't allocate on obstack.
1304         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1305         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1306         Change type to htab_up.
1307
1308 2020-02-08  Tom Tromey  <tom@tromey.com>
1309
1310         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1311         Change type to htab_up.
1312         * dwarf2/read.c (create_signatured_type_table_from_index)
1313         (create_signatured_type_table_from_debug_names)
1314         (create_all_type_units, add_type_unit)
1315         (lookup_dwo_signatured_type, lookup_signatured_type)
1316         (process_skeletonless_type_unit): Update.
1317         (create_debug_type_hash_table, create_debug_types_hash_table):
1318         Change type of types_htab.
1319         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1320         htab_up.  Don't allocate on obstack.
1321         (create_cus_hash_table): Change type of cus_htab parameter.
1322         (struct dwo_file) <cus, tus>: Now htab_up.
1323         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1324         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1325         (queue_and_load_all_dwo_tus): Update.
1326         * dwarf2/index-write.c (write_gdbindex): Update.
1327         (write_debug_names): Update.
1328
1329 2020-02-08  Tom Tromey  <tom@tromey.com>
1330
1331         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1332         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1333         destructor.
1334         (struct dwarf2_per_objfile) <queue>: New member.
1335         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1336         dwarf2/read.h.
1337         (dwarf2_queue, dwarf2_queue_tail): Remove.
1338         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1339         DISABLE_COPY_AND_ASSIGN.
1340         <m_per_objfile>: New member.
1341         <~dwarf2_queue_guard>: Rewrite.
1342         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1343         Update.
1344         (~dwarf2_queue_item): New.
1345
1346 2020-02-08  Tom Tromey  <tom@tromey.com>
1347
1348         * dwarf2/read.c (struct die_info) <has_children>: New member.
1349         (dw2_get_file_names_reader): Remove has_children.
1350         (dw2_get_file_names): Update.
1351         (read_cutu_die_from_dwo): Remove has_children.
1352         (cutu_reader::init_tu_and_read_dwo_dies)
1353         (cutu_reader::cutu_reader): Update.
1354         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1355         Remove has_children.
1356         (build_type_psymtabs_1, process_skeletonless_type_unit)
1357         (load_partial_comp_unit, load_full_comp_unit): Update.
1358         (create_dwo_cu_reader): Remove has_children.
1359         (create_cus_hash_table, read_die_and_children): Update.
1360         (read_full_die_1,read_full_die): Remove has_children.
1361         (read_signatured_type): Update.
1362         (class cutu_reader) <has_children>: Remove.
1363
1364 2020-02-08  Tom Tromey  <tom@tromey.com>
1365
1366         * dwarf2/expr.c: Rename from dwarf2expr.c.
1367         * dwarf2/expr.h: Rename from dwarf2expr.h.
1368         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1369         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1370         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1371         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1372         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1373         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1374         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1375         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1376         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1377         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1378         * dwarf2/loc.c: Rename from dwarf2loc.c.
1379         * dwarf2/loc.h: Rename from dwarf2loc.h.
1380         * dwarf2/read.c: Rename from dwarf2read.c.
1381         * dwarf2/read.h: Rename from dwarf2read.h.
1382         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1383         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1384         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1385         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1386         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1387         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1388         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1389         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1390         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1391         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1392         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1393         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1394         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1395         Update.
1396         * Makefile.in (COMMON_SFILES): Update.
1397         (HFILES_NO_SRCDIR): Update.
1398
1399 2020-02-08  Tom Tromey  <tom@tromey.com>
1400
1401         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1402         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1403
1404 2020-02-08  Tom Tromey  <tom@tromey.com>
1405
1406         * dwarf2read.h (struct die_info): Don't declare.
1407
1408 2020-02-08  Tom Tromey  <tom@tromey.com>
1409
1410         * dwarf2read.h (die_info_ptr): Remove typedef.
1411
1412 2020-02-08  Tom Tromey  <tom@tromey.com>
1413
1414         * dwarf2read.c (read_call_site_scope)
1415         (handle_data_member_location, dwarf2_add_member_fn)
1416         (mark_common_block_symbol_computed, read_common_block)
1417         (attr_to_dynamic_prop, partial_die_info::read)
1418         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1419         (dwarf2_symbol_mark_computed, set_die_type): Update.
1420         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1421         method.
1422         (attr_form_is_block): Don't declare.
1423         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1424
1425 2020-02-08  Tom Tromey  <tom@tromey.com>
1426
1427         * dwarf2read.c (dwarf2_find_base_address, )
1428         (read_call_site_scope, rust_containing_type)
1429         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1430         (handle_data_member_location, dwarf2_add_member_fn)
1431         (get_alignment, read_structure_type, process_structure_scope)
1432         (mark_common_block_symbol_computed, read_common_block)
1433         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1434         (partial_die_info::read, read_attribute_value, new_symbol)
1435         (lookup_die_type, dwarf2_get_ref_die_offset)
1436         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1437         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1438         (dwarf2_symbol_mark_computed): Update.
1439         * dwarf2/attribute.h (struct attribute) <value_as_address,
1440         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1441         methods.
1442         (value_as_address, attr_form_is_section_offset)
1443         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1444         * dwarf2/attribute.c (attribute::value_as_address)
1445         (attribute::form_is_section_offset, attribute::form_is_constant)
1446         (attribute::form_is_ref): Now methods.
1447
1448 2020-02-08  Tom Tromey  <tom@tromey.com>
1449
1450         * dwarf2read.c (struct attribute, DW_STRING)
1451         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1452         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1453         (attr_form_is_block, attr_form_is_section_offset)
1454         (attr_form_is_constant, attr_form_is_ref): Move.
1455         * dwarf2/attribute.h: New file.
1456         * dwarf2/attribute.c: New file, from dwarf2read.c.
1457         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1458
1459 2020-02-08  Tom Tromey  <tom@tromey.com>
1460
1461         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1462         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1463         Move.
1464         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1465         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1466         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1467         abbrev.c.
1468         * dwarf2/abbrev.h: New file.
1469         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1470         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1471
1472 2020-02-08  Tom Tromey  <tom@tromey.com>
1473
1474         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1475         (dwarf2_section_size, dwarf2_get_section_info)
1476         (create_signatured_type_table_from_debug_names)
1477         (create_addrmap_from_aranges, read_debug_names_from_section)
1478         (get_gdb_index_contents_from_section, read_comp_unit_head)
1479         (error_check_comp_unit_head, read_abbrev_offset)
1480         (create_debug_type_hash_table, init_cu_die_reader)
1481         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1482         (read_comp_units_from_section, create_cus_hash_table)
1483         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1484         (create_dwp_v2_section, dwarf2_rnglists_process)
1485         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1486         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1487         (read_indirect_string_from_dwz, read_addr_index_1)
1488         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1489         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1490         (fill_in_loclist_baton): Update.
1491         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1492         get_containing_section, get_bfd_owner, get_bfd_section,
1493         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1494         (dwarf2_read_section, get_section_name, get_section_file_name)
1495         (get_containing_section, get_section_bfd_owner)
1496         (get_section_bfd_section, get_section_name, get_section_file_name)
1497         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1498         declare.
1499         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1500         (dwarf2_section_info::get_bfd_owner)
1501         (dwarf2_section_info::get_bfd_section)
1502         (dwarf2_section_info::get_name)
1503         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1504         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1505         (dwarf2_section_info::read): Now methods.
1506         * dwarf-index-write.c (class debug_names): Update.
1507
1508 2020-02-08  Tom Tromey  <tom@tromey.com>
1509
1510         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1511         Move to dwarf2/section.h.
1512         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1513         (get_section_bfd_section, get_section_name)
1514         (get_section_file_name, get_section_id, get_section_flags)
1515         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1516         dwarf2/section.c.
1517         * dwarf2/section.h: New file.
1518         * dwarf2/section.c: New file, from dwarf2read.c.
1519         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1520
1521 2020-02-08  Tom Tromey  <tom@tromey.com>
1522
1523         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1524         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1525         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1526         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1527         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1528         * dwarf2/leb.h: New file, from dwarf2read.c.
1529         * dwarf2/leb.c: New file, from dwarf2read.c.
1530         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1531         Remove.
1532         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1533         (COMMON_SFILES): Add dwarf2/leb.c.
1534
1535 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1536
1537         GDB 9.1 released.
1538
1539 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1540
1541         PR gdb/25190:
1542         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1543         * gdb/remote.c (remote_console_output): Update.
1544         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1545         (ui_file_puts): ...this.
1546         * gdb/ui-file.h (ui_file_puts): Add declaration.
1547         * gdb/utils.c (emit_style_escape): Update.
1548         (flush_wrap_buffer): Update.
1549         (fputs_maybe_filtered): Update.
1550         (fputs_unfiltered): Add function.
1551
1552 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1553
1554         * gdb/event-loop.c (gdb_wait_for_event): Update.
1555         * gdb/printcmd.c (printf_command): Update.
1556         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1557         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1558         (gdb_os_flush_stderr): Update.
1559         * gdb/remote.c (remote_console_output): Update.
1560         * gdb/ui-file.c (gdb_flush): Rename to...
1561         (ui_file_flush): ...this.
1562         (stderr_file::write): Update.
1563         (stderr_file::puts): Update.
1564         * gdb/ui-file.h (gdb_flush): Rename to...
1565         (ui_file_flush): ...this.
1566         * gdb/utils.c (gdb_flush): Add function.
1567         * gdb/utils.h (gdb_flush): Add declaration.
1568
1569 2020-02-07  Tom Tromey  <tromey@adacore.com>
1570
1571         PR breakpoints/24915:
1572         * source.c (find_and_open_source): Do not check basenames_may_differ.
1573
1574 2020-02-07  Tom Tromey  <tom@tromey.com>
1575
1576         * README: Update gdbserver documentation.
1577         * gdbserver: Move to top level.
1578         * configure.tgt (build_gdbserver): Remove.
1579         * configure.ac: Remove --enable-gdbserver.
1580         * configure: Rebuild.
1581         * Makefile.in (distclean): Don't mention gdbserver.
1582
1583 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1584
1585         * source-cache.c (source_cache::ensure): Surround
1586         get_plain_source_lines with a try/catch.
1587         (source_cache::get_line_charpos): Get rid of try/catch
1588         and only check for the return value of "ensure".
1589         * tui/tui-source.c (tui_source_window::set_contents):
1590         Simplify "nlines" calculation.
1591
1592 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1593
1594         * MAINTAINERS (Write After Approval): Add myself.
1595
1596 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1597
1598         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1599         function call.
1600
1601 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1602
1603         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1604
1605 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1606
1607         * nat/riscv-linux-tdesc.h: New file.
1608         * nat/riscv-linux-tdesc.c: New file, taking code from...
1609         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1610         ... here.
1611         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1612         NATDEPFILES.
1613
1614 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1617         we don't set the fake simulator ptid to the null_ptid.
1618
1619 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1620
1621         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1622         * gdbthread.h (class thread_info) <resumed>: Likewise.
1623         * infrun.c (resume_1): Likewise.
1624         (proceed): Likewise.
1625         (infrun_thread_stop_requested): Likewise.
1626         (stop_all_threads): Likewise.
1627         (handle_inferior_event): Likewise.
1628         (restart_threads): Likewise.
1629         (finish_step_over): Likewise.
1630         (keep_going_stepped_thread): Likewise.
1631         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1632         (linux_handle_extended_wait): Likewise.
1633         * record-btrace.c (get_thread_current_frame_id): Likewise.
1634         * record-full.c (record_full_wait_1): Likewise.
1635         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1636         * target.c (target_resume): Likewise.
1637         * thread.c (set_running_thread): Likewise.
1638
1639 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1640
1641         * f-valprint.c (f77_print_array_1): Changed datatype of index
1642         variable to LONGEST from int to enable it to contain bound
1643         values correctly.
1644
1645 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1646
1647         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1648         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1649         offsets according to FLEN determined.
1650         (riscv_linux_nat_target::read_description): Determine FLEN
1651         dynamically.
1652         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1653         according to FLEN determined.
1654         (riscv_linux_nat_target::store_registers): Likewise.
1655
1656 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1657
1658         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1659         when reg->group is empty and reggroup is not.
1660
1661 2020-01-31  Tom Tromey  <tromey@adacore.com>
1662
1663         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1664         Call beneath target's mourn_inferior after unpushing.
1665
1666 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1667
1668         PR tui/9765
1669         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1670         have enough lines to fill the screen, still return the lowest
1671         address we found.
1672
1673 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1676         '-', '<', and '>' commands.
1677
1678 2020-01-29  Pedro Alves  <palves@redhat.com>
1679             Sergio Durigan Junior  <sergiodj@redhat.com>
1680
1681         * infcmd.c (construct_inferior_arguments): Assert that
1682         'argc' is greater than 0.
1683
1684 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1685
1686         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1687         (BRK_INSN_MASK): Define to 0xd4200000.
1688         (aarch64_program_breakpoint_here_p): New function.
1689         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1690         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1691         breakpoint.c.
1692         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1693         breakpoint.h
1694         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1695         call gdbarch_program_breakpoint_here_p.
1696         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1697         default_program_breakpoint_here_p, changed return type to bool and
1698         simplified.
1699         * breakpoint.h (program_breakpoint_here): Moved prototype to
1700         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1701         return type to bool.
1702         * gdbarch.c: Regenerate.
1703         * gdbarch.h: Regenerate.
1704         * gdbarch.sh (program_breakpoint_here_p): New method.
1705         * infrun.c (handle_signal_stop): Call
1706         gdbarch_program_breakpoint_here_p.
1707
1708 2020-01-26  Tom Tromey  <tom@tromey.com>
1709
1710         * ctfread.c (struct ctf_fp_info): Reindent.
1711         (_initialize_ctfread): Remove.
1712
1713 2020-01-26  Tom Tromey  <tom@tromey.com>
1714
1715         * psymtab.c (partial_map_expand_apply)
1716         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1717         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1718         (psym_print_stats, psym_expand_symtabs_for_function)
1719         (psym_map_symbol_filenames, psym_map_matching_symbols)
1720         (psym_expand_symtabs_matching)
1721         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1722         (maintenance_check_psymtabs): Use new methods.
1723         * psympriv.h (struct partial_symtab) <readin_p,
1724         get_compunit_symtab>: New methods.
1725         <readin, compunit_symtab>: Remove members.
1726         (struct standard_psymtab): New.
1727         (struct legacy_psymtab): Derive from standard_psymtab.
1728         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1729         standard_psymtab.
1730         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
1731
1732 2020-01-26  Tom Tromey  <tom@tromey.com>
1733
1734         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
1735         read_dependencies.  Add assert.
1736         * psymtab.c (partial_symtab::read_dependencies): New method.
1737         * psympriv.h (struct partial_symtab) <read_dependencies>: New
1738         method.
1739         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
1740         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
1741         read_dependencies.
1742         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
1743         Add assert.
1744
1745 2020-01-26  Tom Tromey  <tom@tromey.com>
1746
1747         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
1748         Call expand_psymtab.
1749         (xcoff_read_symtab): Call expand_psymtab.
1750         (xcoff_start_psymtab, xcoff_end_psymtab): Set
1751         legacy_expand_psymtab.
1752         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
1753         method.
1754         (struct legacy_psymtab) <expand_psymtab>: Implement.
1755         <legacy_expand_psymtab>: New member.
1756         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
1757         (parse_partial_symbols): Set legacy_expand_psymtab.
1758         (psymtab_to_symtab_1): Change argument order.  Call
1759         expand_psymtab.
1760         (new_psymtab): Set legacy_expand_psymtab.
1761         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
1762         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
1763         expand_psymtab.
1764         (dwarf2_psymtab::expand_psymtab): Rename from
1765         psymtab_to_symtab_1.  Call expand_psymtab.
1766         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
1767         (dbx_end_psymtab): Likewise.
1768         (dbx_psymtab_to_symtab_1): Change argument order. Call
1769         expand_psymtab.
1770         (dbx_read_symtab): Call expand_psymtab.
1771         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
1772         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
1773         (ctf_psymtab::read_symtab): Call expand_psymtab.
1774
1775 2020-01-26  Tom Tromey  <tom@tromey.com>
1776
1777         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
1778         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
1779         messages.
1780         * mdebugread.c (mdebug_read_symtab): Remove prints.
1781         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
1782         assert.
1783         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
1784
1785 2020-01-26  Tom Tromey  <tom@tromey.com>
1786
1787         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
1788         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
1789         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
1790         legacy_symtab.
1791         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
1792         * psymtab.c (psymtab_to_symtab): Call method.
1793         (dump_psymtab): Update.
1794         * psympriv.h (struct partial_symtab): Add virtual destructor.
1795         <read_symtab>: New method.
1796         (struct legacy_symtab): New.
1797         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
1798         (struct pst_map) <pst>: Now a legacy_psymtab.
1799         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
1800         (new_psymtab): Use legacy_psymtab.
1801         * dwarf2read.h (struct dwarf2_psymtab): New.
1802         (struct dwarf2_per_cu_data) <psymtab>: Use it.
1803         * dwarf2read.c (dwarf2_create_include_psymtab)
1804         (dwarf2_build_include_psymtabs, create_type_unit_group)
1805         (create_partial_symtab, process_psymtab_comp_unit_reader)
1806         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
1807         (set_partial_user): Use dwarf2_psymtab.
1808         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
1809         (psymtab_to_symtab_1, process_full_comp_unit)
1810         (process_full_type_unit, dwarf2_ranges_read)
1811         (dwarf2_get_pc_bounds, psymtab_include_file_name)
1812         (dwarf_decode_lines): Use dwarf2_psymtab.
1813         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
1814         (add_address_entry_worker, write_one_signatured_type)
1815         (recursively_count_psymbols, recursively_write_psymbols)
1816         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
1817         (write_debug_names): Likewise.
1818         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
1819         <pst>: Now a legacy_psymtab.
1820         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
1821         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
1822         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
1823         * ctfread.c (struct ctf_psymtab): New.
1824         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
1825         ctf_psymtab.
1826         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
1827         (create_partial_symtab): Return a ctf_psymtab.
1828         (scan_partial_symbols): Update.
1829
1830 2020-01-26  Tom Tromey  <tom@tromey.com>
1831
1832         * xcoffread.c (xcoff_start_psymtab): Use new.
1833         * psymtab.c (partial_symtab::partial_symtab): New constructor,
1834         renamed from start_psymtab_common.
1835         * psympriv.h (struct partial_symtab): Add new constructor.
1836         (start_psymtab_common): Don't declare.
1837         * mdebugread.c (parse_partial_symbols): Use new.
1838         * dwarf2read.c (create_partial_symtab): Use new.
1839         * dbxread.c (start_psymtab): Use new.
1840         * ctfread.c (create_partial_symtab): Use new.
1841
1842 2020-01-26  Tom Tromey  <tom@tromey.com>
1843
1844         * xcoffread.c (xcoff_end_psymtab): Use new.
1845         * psymtab.c (start_psymtab_common): Use new.
1846         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
1847         Update.
1848         * psympriv.h (struct partial_symtab): Add parameters to
1849         constructor.  Don't inline.
1850         (allocate_psymtab): Don't declare.
1851         * mdebugread.c (new_psymtab): Use new.
1852         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
1853         * dbxread.c (dbx_end_psymtab): Use new.
1854
1855 2020-01-26  Tom Tromey  <tom@tromey.com>
1856
1857         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
1858         allocate_psymtab.  Update documentation.
1859         * psymtab.c (psymtab_storage::install_psymtab): Rename from
1860         allocate_psymtab.  Do not use new.
1861         (allocate_psymtab): Use new.  Update.
1862
1863 2020-01-26  Tom Tromey  <tom@tromey.com>
1864
1865         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1866         * psymtab.c (psym_print_stats): Update.
1867         * psympriv.h (struct partial_symtab) <readin,
1868         psymtabs_addrmap_supported, anonymous>: Now bool.
1869         * mdebugread.c (psymtab_to_symtab_1): Update.
1870         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
1871         (build_type_psymtabs_reader, psymtab_to_symtab_1)
1872         (process_full_comp_unit, process_full_type_unit): Update.
1873         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1874         * ctfread.c (psymtab_to_symtab): Update.
1875
1876 2020-01-26  Tom Tromey  <tom@tromey.com>
1877
1878         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
1879         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
1880         * psymtab.c (psymtab_storage): Delete psymtabs.
1881         (psymtab_storage::allocate_psymtab): Use new.
1882         (psymtab_storage::discard_psymtab): Use delete.
1883         * psympriv.h (struct partial_symtab): Add constructor and
1884         initializers.
1885
1886 2020-01-26  Tom Tromey  <tom@tromey.com>
1887
1888         * machoread.c: Do not include psympriv.h.
1889
1890 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1891
1892         * NEWS: Mention the new option and the set/show commands.
1893
1894 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1895
1896         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
1897         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
1898         (validate_exec_file): New variables, enums, functions.
1899         (exec_file_locate_attach, print_section_info): Style the filenames.
1900         (_initialize_exec): Install show_exec_file_mismatch_command and
1901          set_exec_file_mismatch_command.
1902         * gdbcore.h (validate_exec_file): Declare.
1903         * infcmd.c (attach_command): Call validate_exec_file.
1904         * remote.c ( remote_target::remote_add_inferior): Likewise.
1905
1906 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * frame.c (find_frame_sal): Move call to get_next_frame into more
1909         inner scope.
1910         * inline-frame.c (inilne_state) <inline_state>: Update argument
1911         types.
1912         (inilne_state) <skipped_symbol>: Rename to...
1913         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
1914         (skip_inline_frames): Build vector of skipped symbols and use this
1915         to reate the inline_state.
1916         (inline_skipped_symbol): Add a comment and some assertions, fetch
1917         skipped symbol from the list.
1918
1919 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * buildsym.c (lte_is_less_than): Delete.
1922         (buildsym_compunit::end_symtab_with_blockvector): Create local
1923         lambda function to sort line table entries, and use
1924         std::stable_sort instead of std::sort.
1925         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
1926         markers when looking for a previous line.
1927
1928 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * dwarf2read.c (lnp_state_machine::record_line): Include
1931         end_sequence parameter in debug print out.  Record the line if we
1932         are at an end_sequence marker even if it's not the start of a
1933         statement.
1934         * symmisc.c (maintenance_print_one_line_table): Print end of
1935         sequence markers with 'END' not '0'.
1936
1937 2020-01-24  Pedro Alves  <palves@redhat.com>
1938
1939         PR gdb/25410
1940         * thread.c (scoped_restore_current_thread::restore): Use
1941         switch_to_inferior_no_thread.
1942         * exec.c: Include "progspace-and-thread.h".
1943         (add_target_sections, remove_target_sections):
1944         scoped_restore_current_pspace_and_thread instead of
1945         scoped_restore_current_thread.
1946         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
1947         and aspace to the inferior before calling clone_program_space.
1948         Remove stale comment.
1949
1950 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1951
1952         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
1953         (arm_netbsd_nat_target::fetch_registers): ...this.
1954         (arm_nbsd_nat_target::store_registers): Rename to...
1955         (arm_netbsd_nat_target::store_registers): ...this.
1956
1957 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1958
1959         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1960         register_t.
1961
1962 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1963
1964         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
1965         Update comment.
1966         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
1967         Likewise.
1968         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
1969         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
1970         the correct replacement (iterate_over_regset_sections).
1971         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
1972         Update comment.
1973
1974 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
1975
1976         PR gdb/23718
1977         * gdb/python/python.c (execute_gdb_command): Call
1978         async_enable_stdin in catch block.
1979
1980 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
1983         SWITCH_THRU_ALL_UIS.
1984
1985 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         PR tui/9765
1988         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
1989         comment, add extra parameter, and update to store previous symbol
1990         when appropriate.
1991         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
1992         add extra parameter.
1993         * tui/tui-disasm.c (tui_disassemble): Update header comment,
1994         remove unneeded parameter, add try/catch around gdb_print_insn,
1995         rewrite to add items to asm_lines vector.
1996         (tui_find_backward_disassembly_start_address): New function.
1997         (tui_find_disassembly_address): Updated throughout.
1998         (tui_disasm_window::set_contents): Update for changes to
1999         tui_disassemble.
2000         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2001         number of lines to scroll.
2002
2003 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2004
2005         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2006         (SECT_OFF_DATA): Likewise.
2007         (SECT_OFF_RODATA): Likewise.
2008         (SECT_OFF_TEXT): Likewise.
2009         (SECT_OFF_BSS): Likewise.
2010         (struct objfile) <text_section_offset, data_section_offset>: New
2011         methods.
2012         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2013         objfile::text_section_offset.
2014         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2015         * coffread.c (coff_symtab_read): Likewise.
2016         (enter_linenos): Likewise.
2017         (process_coff_symbol): Likewise.
2018         * ctfread.c (get_objfile_text_range): Likewise.
2019         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2020         Use objfile::data_section_offset.
2021         * dwarf2-frame.c (execute_cfa_program): Use
2022         objfile::text_section_offset.
2023         (dwarf2_frame_find_fde): Likewise.
2024         * dwarf2read.c (create_addrmap_from_index): Likewise.
2025         (create_addrmap_from_aranges): Likewise.
2026         (dw2_find_pc_sect_compunit_symtab): Likewise.
2027         (process_psymtab_comp_unit_reader): Likewise.
2028         (add_partial_symbol): Likewise.
2029         (add_partial_subprogram): Likewise.
2030         (process_full_comp_unit): Likewise.
2031         (read_file_scope): Likewise.
2032         (read_func_scope): Likewise.
2033         (read_lexical_block_scope): Likewise.
2034         (read_call_site_scope): Likewise.
2035         (dwarf2_rnglists_process): Likewise.
2036         (dwarf2_ranges_process): Likewise.
2037         (dwarf2_ranges_read): Likewise.
2038         (dwarf_decode_lines_1): Likewise.
2039         (new_symbol): Likewise.
2040         (dwarf2_fetch_die_loc_sect_off): Likewise.
2041         (dwarf2_per_cu_text_offset): Likewise.
2042         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2043         * hppa-tdep.c (read_unwind_info): Likewise.
2044         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2045         * psympriv.h (struct partial_symtab): Likewise.
2046         * psymtab.c (find_pc_sect_psymtab): Likewise.
2047         * solib-svr4.c (enable_break): Likewise.
2048         * stap-probe.c (relocate_address): Use
2049         objfile::data_section_offset.
2050         * xcoffread.c (enter_line_range): Use
2051         objfile::text_section_offset.
2052         (read_xcoff_symtab): Likewise.
2053
2054 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2055
2056         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2057         declaration to narrower scopes.
2058
2059 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2060
2061         * darwin-nat.h (struct darwin_exception_msg, enum
2062         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2063         Move up.
2064         (class darwin_nat_target) <wait_1, check_new_threads,
2065         decode_exception_message, decode_message, stop_inferior,
2066         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2067         * darwin-nat.c (darwin_check_new_threads): Rename to...
2068         (darwin_nat_target::check_new_threads): ... this.
2069         (darwin_suspend_inferior_it): Remove.
2070         (darwin_decode_exception_message): Rename to...
2071         (darwin_nat_target::decode_exception_message): ... this.
2072         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2073         (darwin_decode_message): Rename to...
2074         (darwin_nat_target::decode_message): ... this.
2075         (cancel_breakpoint): Rename to...
2076         (darwin_nat_target::cancel_breakpoint): ... this.
2077         (darwin_wait): Rename to...
2078         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2079         instead of iterate_over_inferiors.
2080         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2081         (darwin_stop_inferior): Rename to...
2082         (darwin_nat_target::stop_inferior): ... this.
2083         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2084         (darwin_init_thread_list): Rename to...
2085         (darwin_nat_target::init_thread_list): ... this.
2086         (darwin_ptrace_him): Rename to...
2087         (darwin_nat_target::ptrace_him): ... this.
2088         (darwin_nat_target::create_inferior): Pass lambda function to
2089         fork_inferior.
2090         (darwin_nat_target::detach): Call stop_inferior instead of
2091         darwin_stop_inferior.
2092         * fork-inferior.h (fork_inferior): Change init_trace_fun
2093         parameter to gdb::function_view.
2094         * fork-inferior.c (fork_inferior): Likewise.
2095
2096 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2097
2098         * i386-cygwin-tdep.c (core_process_module_section): Update.
2099         * windows-nat.c (struct lm_info_windows): Add text_offset.
2100         (windows_xfer_shared_libraries): Update.
2101         * windows-tdep.c (windows_xfer_shared_library):
2102         Add text_offset_cached argument.
2103         * windows-tdep.h (windows_xfer_shared_library): Update.
2104
2105 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2106
2107         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2108
2109 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2110
2111         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2112         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2113         replace with range-based for.
2114         (gdbsim_interrupt_inferior): Remove.
2115         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2116         with a range-based for.  Inline code from
2117         gdbsim_interrupt_inferior.
2118
2119 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2120
2121         * infrun.c (proceed): Fix indentation.
2122
2123 2020-01-21  Tom Tromey  <tromey@adacore.com>
2124
2125         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2126         * python/python.c (python_extension_ops): Update.
2127         (gdbpy_colorize): New function.
2128         * python/lib/gdb/__init__.py (colorize): New function.
2129         * extension.h (ext_lang_colorize): Declare.
2130         * extension.c (ext_lang_colorize): New function.
2131         * extension-priv.h (struct extension_language_ops) <colorize>: New
2132         member.
2133         * cli/cli-style.c (_initialize_cli_style): Update help text.
2134
2135 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2136
2137         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2138         <cond>: Change type to bool.
2139         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2140         (aarch64_displaced_step_cb): Likewise.
2141         (aarch64_displaced_step_tb): Likewise.
2142
2143 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2144
2145         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2146         output.
2147
2148 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2149
2150         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2151         <pc_adjust>: Adjust the documentation.
2152         (aarch64_displaced_step_fixup): Check if PC really moved before
2153         adjusting it.
2154
2155 2020-01-19  Tom Tromey  <tom@tromey.com>
2156
2157         * disasm.c (~gdb_disassembler): New destructor.
2158         (gdb_buffered_insn_length): Call disassemble_free_target.
2159         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2160         DISABLE_COPY_AND_ASSIGN.
2161
2162 2020-01-19  Tom Tromey  <tom@tromey.com>
2163
2164         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2165         (die_reader_func_ftype): Remove.
2166         (cutu_reader): New class.
2167         (dw2_get_file_names_reader): Remove "data" parameter.
2168         (dw2_get_file_names): Use cutu_reader.
2169         (create_debug_type_hash_table): Update.
2170         (read_cutu_die_from_dwo): Update comment.
2171         (lookup_dwo_unit): Add dwo_name parameter.
2172         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2173         die_reader_func_ftype and data parameters.
2174         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2175         Remove die_reader_func_ftype and data parameters.
2176         (~cutu_reader): New; from init_cutu_and_read_dies.
2177         (cutu_reader::cutu_reader): Rename from
2178         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2179         and data parameters.
2180         (init_cutu_and_read_dies_simple): Remove.
2181         (struct process_psymtab_comp_unit_data): Remove.
2182         (process_psymtab_comp_unit_reader): Remove data parameter; add
2183         want_partial_unit and pretend_language parameters.
2184         (process_psymtab_comp_unit): Use cutu_reader.
2185         (build_type_psymtabs_reader): Remove data parameter.
2186         (build_type_psymtabs_1): Use cutu_reader.
2187         (process_skeletonless_type_unit): Likewise.
2188         (load_partial_comp_unit_reader): Remove.
2189         (load_partial_comp_unit): Use cutu_reader.
2190         (load_full_comp_unit_reader): Remove.
2191         (load_full_comp_unit): Use cutu_reader.
2192         (struct create_dwo_cu_data): Remove.
2193         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2194         dwo_unit parameters.
2195         (create_cus_hash_table): Use cutu_reader.
2196         (struct dwarf2_read_addr_index_data): Remove.
2197         (dwarf2_read_addr_index_reader): Remove.
2198         (dwarf2_read_addr_index): Use cutu_reader.
2199         (read_signatured_type_reader): Remove.
2200         (read_signatured_type): Use cutu_reader.
2201
2202 2020-01-19  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2205         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2206         (tui_wrefresh): Declare.
2207         * tui/tui-wingeneral.c (suppress_output): New global.
2208         (tui_suppress_output, ~tui_suppress_output): New constructor and
2209         destructor.
2210         (tui_wrefresh): New function.
2211         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2212         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2213         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2214         method.
2215         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2216         tui_wrefresh.
2217         (tui_data_window::no_refresh): New method.
2218         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2219         (tui_reg_command): Use tui_suppress_output
2220         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2221         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2222         method.
2223         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2224
2225 2020-01-19  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2228         Handle case where symtab is null.
2229
2230 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2231
2232         * linux-fork.c (one_fork_p): Simplify.
2233
2234 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2235
2236         * top.c (struct qt_args): Remove.
2237         (kill_or_detach): Change return type to void, replace `void *`
2238         parameter with a proper one.
2239         (print_inferior_quit_action):  Likewise.
2240         (quit_confirm): Use range-based for loop to iterate over inferiors.
2241         (quit_force): Likewise.
2242
2243 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2244
2245         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2246         `void *` parameter with proper parameters.
2247         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2248         (print_one_inferior): Change return type to void, replace `void *`
2249         parameter with proper parameters.
2250         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2251         inferiors.
2252         (get_other_inferior): Remove.
2253         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2254         inferiors.
2255
2256 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2257
2258         * mi/mi-interp.c (report_initial_inferior): Remove.
2259         (mi_interp::init): Use range-based for to iterate over inferiors.
2260
2261 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2262
2263         * python/py-inferior.c (build_inferior_list): Remove.
2264         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2265
2266 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2267
2268         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2269         (btrace_stitch_trace): Likewise.
2270         * charset.c (intermediate_encoding): Likewise (vaild).
2271         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2272         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2273         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2274
2275 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2276
2277         * windows-tdep.c (windows_get_tlb_type):
2278         Add rtl_user_process_parameters type.
2279
2280 2020-01-16  Pedro Alves  <palves@redhat.com>
2281             Norbert Lange  <nolange79@gmail.com>
2282
2283         PR build/24805
2284         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2285         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2286         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2287         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2288         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2289         (ps_plog): Redeclare exported functions with default visibility.
2290
2291 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2292
2293         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2294         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2295
2296 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2297
2298         * infcmd.c (post_create_inferior): Use get_thread_regcache
2299         instead of get_current_regcache.
2300
2301 2020-01-14  Tom Tromey  <tom@tromey.com>
2302
2303         PR symtab/12535:
2304         * python/python.c (gdbpy_decode_line): Treat empty string the same
2305         as no argument.
2306
2307 2020-01-14  Tom Tromey  <tom@tromey.com>
2308
2309         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2310
2311 2020-01-14  Tom Tromey  <tom@tromey.com>
2312
2313         * nat/linux-btrace.c: Don't include <config.h>.
2314         * nat/linux-ptrace.c: Don't include <config.h>.
2315         * nat/x86-linux-dregs.c: Don't include <config.h>.
2316
2317 2020-01-14  Tom Tromey  <tom@tromey.com>
2318
2319         * configure: Rebuild.
2320         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2321
2322 2020-01-14  Tom Tromey  <tom@tromey.com>
2323
2324         * nat/x86-linux-dregs.c: Include configh.h.
2325         * nat/linux-ptrace.c: Include configh.h.
2326         * nat/linux-btrace.c: Include configh.h.
2327         * defs.h: Include config.h, bfd.h.
2328         * configure.ac: Don't source common.host.
2329         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2330         * configure: Rebuild.
2331         * acinclude.m4: Update path.
2332         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2333         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2334         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2335         (CLIBS): Add LIBSUPPORT.
2336         (CDEPS): Likewise.
2337         (COMMON_SFILES): Remove gdbsupport files.
2338         (HFILES_NO_SRCDIR): Likewise.
2339         (stamp-version): Update path to create-version.sh.
2340         (ALLDEPFILES): Remove gdbsupport files.
2341
2342 2020-01-14  Tom Tromey  <tom@tromey.com>
2343
2344         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2345         USE_WIN32API when needed.
2346         * configure.ac (USE_WIN32API): Don't define.
2347         (WIN32LIBS): Use WIN32APILIBS.
2348         * configure: Rebuild.
2349
2350 2020-01-14  Tom Tromey  <tom@tromey.com>
2351
2352         * configure: Rebuild.
2353         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2354
2355 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2356
2357         * skip.c (skip_function_command): Make skip w/o arguments use the
2358         name of the inlined function if pc is inside any inlined function.
2359
2360 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2361
2362         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2363         * infrun.c (resume_1): Likewise.
2364         (handle_inferior_event): Remove stale comment.
2365         * linux-nat.c (linux_nat_target::resume): Update comments.
2366         (save_stop_reason): Likewise.
2367         (linux_nat_filter_event): Likewise.
2368         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2369
2370 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * elfread.c (record_minimal_symbol): Set section index to 0 for
2373         non-allocatable sections.
2374
2375
2376 2020-01-13  Ali Tamur <tamur@google.com>
2377
2378         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2379         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2380         to gdb::optional.  Update comments.
2381         (dwo_file): Update comments.
2382         (read_attribute): Update API to take an additional out parameter,
2383         need_reprocess.  This is used to mark attributes that need other
2384         attributes (e.g. str_offsets_base) for correct computation which may not
2385         have been read yet.
2386         (read_attribute_reprocess): New function declaration.
2387         (read_addr_index): Likewise.
2388         (read_dwo_str_index): Likewise.
2389         (read_stub_str_index): Likewise.
2390         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2391         (lookup_addr_base): New function definition.
2392         (lookup_ranges_base): Likewise.
2393         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2394         lookup_ranges_base.
2395         (init_cutu_and_read_dies): Update comments.
2396         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2397         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2398         Update comments.
2399         (init_cutu_and_read_dies_simple): Reflect API changes.
2400         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2401         (create_cus_hash_table): Change API to take parent compile unit.
2402         Reflect API changes.
2403         (open_and_init_dwo_file): Reflect API changes.
2404         (dwarf2_get_pc_bounds): Update comments.
2405         (dwarf2_record_block_ranges): Likewise.
2406         (read_full_die_1): Change implementation to reprocess attributes that
2407         need str_offsets_base and addr_base.
2408         (partial_die_info::read): Likewise.
2409         (read_attribute_reprocess): New function definition.
2410         (read_attribute_value): Change API to take an additional out parameter,
2411         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2412         when a non-dwo compile unit has index based attributes.
2413         (read_attribute): Reflect API changes.
2414         (read_addr_index_1): Reflect API changes.  Update comments.
2415         (dwarf2_read_addr_index_data): Reflect API changes.
2416         (dwarf2_read_addr_index): Likewise.
2417         (read_str_index): Change API and implementation.  This becomes a helper
2418         to be used by the new string index related methods.  Update error
2419         message and comments.
2420         (read_dwo_str_index): New function definition.
2421         (read_stub_str_index): Likewise.
2422         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2423         * symfile.h (dwarf2_debug_sections): Likewise.
2424         * xcoffread.c (dwarf2_debug_sections): Likewise.
2425
2426 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2427
2428         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2429         core_reg_sect type to gdb_byte *.
2430         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2431         * cris-tdep.c (fetch_core_registers): Likewise.
2432         * corelow.c (core_target::get_core_register_section): Change
2433         type of `contents` to gdb::byte_vector.
2434
2435 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * tui/tui-wingeneral.c (box_win): Position the title in the center
2438         of the border.
2439
2440 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2441
2442         * corelow.c (core_target::get_core_register_section): Use
2443           std::vector instead of alloca.
2444
2445 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2446
2447         * warning.m4: Add -Wmissing-declarations to build_warnings.
2448         * configure: Re-generate.
2449
2450 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2451
2452         * python/python.c (init__gdb_module): Add declaration.
2453
2454 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2455
2456         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2457         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2458         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2459         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2460         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2461         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2462         * ada-exp.y (_initialize_ada_exp): Add declaration.
2463         * ada-lang.c (_initialize_ada_language): Add declaration.
2464         * ada-tasks.c (_initialize_tasks): Add declaration.
2465         * agent.c (_initialize_agent): Add declaration.
2466         * aix-thread.c (_initialize_aix_thread): Add declaration.
2467         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2468         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2469         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2470         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2471         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2472         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2473         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2474         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2475         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2476         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2477         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2478         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2479         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2480         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2481         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2482         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2483         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2484         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2485         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2486         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2487         * annotate.c (_initialize_annotate): Add declaration.
2488         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2489         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2490         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2491         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2492         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2493         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2494         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2495         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2496         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2497         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2498         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2499         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2500         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2501         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2502         * auto-load.c (_initialize_auto_load): Add declaration.
2503         * auxv.c (_initialize_auxv): Add declaration.
2504         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2505         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2506         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2507         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2508         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2509         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2510         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2511         * breakpoint.c (_initialize_breakpoint): Add declaration.
2512         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2513         * btrace.c (_initialize_btrace): Add declaration.
2514         * charset.c (_initialize_charset): Add declaration.
2515         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2516         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2517         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2518         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2519         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2520         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2521         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2522         * coffread.c (_initialize_coffread): Add declaration.
2523         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2524         * compile/compile.c (_initialize_compile): Add declaration.
2525         * complaints.c (_initialize_complaints): Add declaration.
2526         * completer.c (_initialize_completer): Add declaration.
2527         * copying.c (_initialize_copying): Add declaration.
2528         * corefile.c (_initialize_core): Add declaration.
2529         * corelow.c (_initialize_corelow): Add declaration.
2530         * cp-abi.c (_initialize_cp_abi): Add declaration.
2531         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2532         * cp-support.c (_initialize_cp_support): Add declaration.
2533         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2534         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2535         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2536         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2537         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2538         * ctfread.c (_initialize_ctfread): Add declaration.
2539         * d-lang.c (_initialize_d_language): Add declaration.
2540         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2541         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2542         * dbxread.c (_initialize_dbxread): Add declaration.
2543         * dcache.c (_initialize_dcache): Add declaration.
2544         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2545         * disasm.c (_initialize_disasm): Add declaration.
2546         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2547         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2548         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2549         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2550         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2551         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2552         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2553         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2554         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2555         * elfread.c (_initialize_elfread): Add declaration.
2556         * exec.c (_initialize_exec): Add declaration.
2557         * extension.c (_initialize_extension): Add declaration.
2558         * f-lang.c (_initialize_f_language): Add declaration.
2559         * f-valprint.c (_initialize_f_valprint): Add declaration.
2560         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2561         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2562         * filesystem.c (_initialize_filesystem): Add declaration.
2563         * findcmd.c (_initialize_mem_search): Add declaration.
2564         * findvar.c (_initialize_findvar): Add declaration.
2565         * fork-child.c (_initialize_fork_child): Add declaration.
2566         * frame-base.c (_initialize_frame_base): Add declaration.
2567         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2568         * frame.c (_initialize_frame): Add declaration.
2569         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2570         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2571         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2572         * gcore.c (_initialize_gcore): Add declaration.
2573         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2574         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2575         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2576         * gdbarch.c (_initialize_gdbarch): Add declaration.
2577         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2578         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2579         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2580         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2581         * go-lang.c (_initialize_go_language): Add declaration.
2582         * go32-nat.c (_initialize_go32_nat): Add declaration.
2583         * guile/guile.c (_initialize_guile): Add declaration.
2584         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2585         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2586         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2587         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2588         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2589         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2590         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2591         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2592         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2593         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2594         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2595         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2596         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2597         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2598         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2599         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2600         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2601         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2602         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2603         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2604         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2605         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2606         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2607         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2608         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2609         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2610         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2611         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2612         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2613         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2614         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2615         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2616         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2617         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2618         * infcall.c (_initialize_infcall): Add declaration.
2619         * infcmd.c (_initialize_infcmd): Add declaration.
2620         * inflow.c (_initialize_inflow): Add declaration.
2621         * infrun.c (_initialize_infrun): Add declaration.
2622         * interps.c (_initialize_interpreter): Add declaration.
2623         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2624         * jit.c (_initialize_jit): Add declaration.
2625         * language.c (_initialize_language): Add declaration.
2626         * linux-fork.c (_initialize_linux_fork): Add declaration.
2627         * linux-nat.c (_initialize_linux_nat): Add declaration.
2628         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2629         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2630         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2631         * m2-lang.c (_initialize_m2_language): Add declaration.
2632         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2633         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2634         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2635         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2636         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2637         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2638         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2639         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2640         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2641         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2642         * machoread.c (_initialize_machoread): Add declaration.
2643         * macrocmd.c (_initialize_macrocmd): Add declaration.
2644         * macroscope.c (_initialize_macroscope): Add declaration.
2645         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2646         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2647         * maint.c (_initialize_maint_cmds): Add declaration.
2648         * mdebugread.c (_initialize_mdebugread): Add declaration.
2649         * memattr.c (_initialize_mem): Add declaration.
2650         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2651         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2652         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2653         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2654         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2655         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2656         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2657         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2658         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2659         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2660         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2661         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2662         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2663         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2664         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2665         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2666         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2667         * mipsread.c (_initialize_mipsread): Add declaration.
2668         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2669         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2670         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2671         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2672         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2673         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2674         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2675         * nto-procfs.c (_initialize_procfs): Add declaration.
2676         * objc-lang.c (_initialize_objc_language): Add declaration.
2677         * observable.c (_initialize_observer): Add declaration.
2678         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2679         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2680         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2681         * osabi.c (_initialize_gdb_osabi): Add declaration.
2682         * osdata.c (_initialize_osdata): Add declaration.
2683         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2684         * parse.c (_initialize_parse): Add declaration.
2685         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2686         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2687         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2688         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2689         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2690         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2691         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2692         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2693         * printcmd.c (_initialize_printcmd): Add declaration.
2694         * probe.c (_initialize_probe): Add declaration.
2695         * proc-api.c (_initialize_proc_api): Add declaration.
2696         * proc-events.c (_initialize_proc_events): Add declaration.
2697         * proc-service.c (_initialize_proc_service): Add declaration.
2698         * procfs.c (_initialize_procfs): Add declaration.
2699         * producer.c (_initialize_producer): Add declaration.
2700         * psymtab.c (_initialize_psymtab): Add declaration.
2701         * python/python.c (_initialize_python): Add declaration.
2702         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2703         * record-btrace.c (_initialize_record_btrace): Add declaration.
2704         * record-full.c (_initialize_record_full): Add declaration.
2705         * record.c (_initialize_record): Add declaration.
2706         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2707         * regcache.c (_initialize_regcache): Add declaration.
2708         * reggroups.c (_initialize_reggroup): Add declaration.
2709         * remote-notif.c (_initialize_notif): Add declaration.
2710         * remote-sim.c (_initialize_remote_sim): Add declaration.
2711         * remote.c (_initialize_remote): Add declaration.
2712         * reverse.c (_initialize_reverse): Add declaration.
2713         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2714         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2715         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2716         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2717         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2718         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2719         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2720         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2721         Add declaration.
2722         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2723         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2724         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2725         * rust-exp.y (_initialize_rust_exp): Add declaration.
2726         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2727         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2728         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2729         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
2730         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
2731         * score-tdep.c (_initialize_score_tdep): Add declaration.
2732         * ser-go32.c (_initialize_ser_dos): Add declaration.
2733         * ser-mingw.c (_initialize_ser_windows): Add declaration.
2734         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
2735         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
2736         * ser-uds.c (_initialize_ser_socket): Add declaration.
2737         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
2738         * serial.c (_initialize_serial): Add declaration.
2739         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
2740         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
2741         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
2742         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
2743         * skip.c (_initialize_step_skip): Add declaration.
2744         * sol-thread.c (_initialize_sol_thread): Add declaration.
2745         * solib-aix.c (_initialize_solib_aix): Add declaration.
2746         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
2747         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
2748         * solib-frv.c (_initialize_frv_solib): Add declaration.
2749         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
2750         * solib-target.c (_initialize_solib_target): Add declaration.
2751         * solib.c (_initialize_solib): Add declaration.
2752         * source-cache.c (_initialize_source_cache): Add declaration.
2753         * source.c (_initialize_source): Add declaration.
2754         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
2755         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
2756         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
2757         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
2758         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
2759         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
2760         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
2761         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
2762         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
2763         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
2764         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
2765         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
2766         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
2767         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
2768         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
2769         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
2770         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
2771         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
2772         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
2773         * stabsread.c (_initialize_stabsread): Add declaration.
2774         * stack.c (_initialize_stack): Add declaration.
2775         * stap-probe.c (_initialize_stap_probe): Add declaration.
2776         * std-regs.c (_initialize_frame_reg): Add declaration.
2777         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
2778         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
2779         * symfile.c (_initialize_symfile): Add declaration.
2780         * symmisc.c (_initialize_symmisc): Add declaration.
2781         * symtab.c (_initialize_symtab): Add declaration.
2782         * target.c (_initialize_target): Add declaration.
2783         * target-connection.c (_initialize_target_connection): Add
2784         declaration.
2785         * target-dcache.c (_initialize_target_dcache): Add declaration.
2786         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
2787         * thread.c (_initialize_thread): Add declaration.
2788         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
2789         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
2790         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
2791         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
2792         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
2793         * tracectf.c (_initialize_ctf): Add declaration.
2794         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
2795         * tracefile.c (_initialize_tracefile): Add declaration.
2796         * tracepoint.c (_initialize_tracepoint): Add declaration.
2797         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
2798         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
2799         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
2800         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
2801         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
2802         * tui/tui-win.c (_initialize_tui_win): Add declaration.
2803         * tui/tui.c (_initialize_tui): Add declaration.
2804         * typeprint.c (_initialize_typeprint): Add declaration.
2805         * ui-style.c (_initialize_ui_style): Add declaration.
2806         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
2807         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
2808         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
2809         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
2810         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
2811         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
2812         * unittests/filtered_iterator-selftests.c
2813         (_initialize_filtered_iterator_selftests): Add declaration.
2814         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
2815         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
2816         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
2817         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
2818         * unittests/main-thread-selftests.c
2819         (_initialize_main_thread_selftests): Add declaration.
2820         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
2821         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
2822         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
2823         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
2824         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
2825         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
2826         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
2827         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
2828         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
2829         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
2830         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
2831         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
2832         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
2833         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
2834         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
2835         declaration.
2836         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
2837         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
2838         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
2839         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
2840         * user-regs.c (_initialize_user_regs): Add declaration.
2841         * utils.c (_initialize_utils): Add declaration.
2842         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
2843         * valops.c (_initialize_valops): Add declaration.
2844         * valprint.c (_initialize_valprint): Add declaration.
2845         * value.c (_initialize_values): Add declaration.
2846         * varobj.c (_initialize_varobj): Add declaration.
2847         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
2848         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
2849         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
2850         * windows-nat.c (_initialize_windows_nat): Add declaration.
2851         (_initialize_check_for_gdb_ini): Add declaration.
2852         (_initialize_loadable): Add declaration.
2853         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
2854         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
2855         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
2856         * xcoffread.c (_initialize_xcoffread): Add declaration.
2857         * xml-support.c (_initialize_xml_support): Add declaration.
2858         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
2859         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
2860         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
2861         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
2862
2863 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2864
2865         * regformats/regdat.sh: Generate declaration for init function.
2866
2867 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2868
2869         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
2870         up.
2871         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
2872         close_one_inferior>: New methods.
2873         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
2874         pass down target to find_inferior_pid.
2875         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
2876         Pass down target to find_inferior_ptid.
2877         (gdbsim_target::create_inferior): Pass down target to
2878         add_thread_silent.
2879         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
2880         target down to find_inferior_ptid and switch_to_thread.
2881         (gdbsim_target::close): Update to call close_one_inferior.
2882         (struct resume_data): Remove.
2883         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
2884         directly, rather than through a void pointer.
2885         (gdbsim_target::resume): Update to call resume_one_inferior.
2886
2887 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
2888
2889         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
2890
2891 2020-01-12  Pedro Alves  <palves@redhat.com>
2892
2893         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
2894         directly for the current inferior instead of
2895         discard_all_inferiors.
2896         (discard_all_inferiors): Delete.
2897
2898 2020-01-11  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-wingeneral.c (box_win): Check cli_styling.
2901         * tui/tui-winsource.c (tui_source_window_base::refill): Use
2902         deprecated_safe_get_selected_frame.
2903
2904 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2905
2906         * inferior.c (print_inferior): Switch inferior before printing it.
2907
2908 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
2909             Pedro Alves  <palves@redhat.com>
2910
2911         * progspace-and-thread.c (switch_to_program_space_and_thread):
2912         Assert there's an inferior for PSPACE.  Use
2913         switch_to_inferior_no_thread to switch the inferior too.
2914         * progspace.c (program_space::~program_space): Call
2915         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
2916         (program_space::free_all_objfiles): Don't call clear_symtab_users
2917         here.
2918         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
2919
2920 2020-01-10  Pedro Alves  <palves@redhat.com>
2921
2922         * NEWS: Mention multi-target debugging, "info connections", and
2923         "add-inferior -no-connection".
2924
2925 2020-01-10  Pedro Alves  <palves@redhat.com>
2926
2927         * infrun.c: Include "target-connection.h".
2928         (check_multi_target_resumption): New.
2929         (proceed): Call it.
2930         * target-connection.c (make_target_connection_string): Make
2931         extern.
2932         * target-connection.h (make_target_connection_string): Declare.
2933
2934 2020-01-10  Pedro Alves  <palves@redhat.com>
2935
2936         * Makefile.in (COMMON_SFILES): Add target-connection.c.
2937         * inferior.c (uiout_field_connection): New function.
2938         (print_inferior): Add new "connection-id" column.
2939         (add_inferior_command): Show connection number/string of added
2940         inferior.
2941         * process-stratum-target.h
2942         (process_stratum_target::connection_string): New virtual method.
2943         (process_stratum_target::connection_number): New field.
2944         * remote.c (remote_target::connection_string): New override.
2945         * target-connection.c: New file.
2946         * target-connection.h: New file.
2947         * target.c (decref_target): Remove process_stratum targets from
2948         the connection list.
2949         (target_stack::push): Add process_stratum targets to the
2950         connection list.
2951
2952 2020-01-10  Pedro Alves  <palves@redhat.com>
2953
2954         Revert:
2955         2016-04-12  Pedro Alves  <palves@redhat.com>
2956         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
2957         Remove references to name.
2958         * serial.h (struct serial) <name>: Delete.
2959
2960 2020-01-10  Pedro Alves  <palves@redhat.com>
2961
2962         * gdbarch-selftests.c (register_to_value_test): Remove "target
2963         already pushed" check.
2964
2965 2020-01-10  Pedro Alves  <palves@redhat.com>
2966             John Baldwin  <jhb@FreeBSD.org>
2967
2968         * aarch64-linux-nat.c
2969         (aarch64_linux_nat_target::thread_architecture): Adjust.
2970         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
2971         (task_command_1): Likewise.
2972         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
2973         (aix_thread_target::wait, aix_thread_target::fetch_registers)
2974         (aix_thread_target::store_registers)
2975         (aix_thread_target::thread_alive): Adjust.
2976         * amd64-fbsd-tdep.c: Include "inferior.h".
2977         (amd64fbsd_get_thread_local_address): Pass down target.
2978         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
2979         thread's gdbarch instead of target_gdbarch.
2980         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
2981         get_last_target_status.
2982         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
2983         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
2984         inferiors.
2985         (update_inserted_breakpoint_locations): Skip if inferiors with no
2986         execution.
2987         (update_global_location_list): When handling moribund locations,
2988         find representative inferior for location's pspace, and use thread
2989         count of its process_stratum target.
2990         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
2991         * bsd-uthread.c (bsd_uthread_target::wait): Use
2992         as_process_stratum_target and adjust thread_change_ptid and
2993         add_thread calls.
2994         (bsd_uthread_target::update_thread_list): Use
2995         as_process_stratum_target and adjust find_thread_ptid,
2996         thread_change_ptid and add_thread calls.
2997         * btrace.c (maint_btrace_packet_history_cmd): Adjust
2998         find_thread_ptid call.
2999         * corelow.c (add_to_thread_list): Adjust add_thread call.
3000         (core_target_open): Adjust add_thread_silent and thread_count
3001         calls.
3002         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3003         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3004         * event-top.c (async_disconnect): Pop targets from all inferiors.
3005         * exec.c (add_target_sections): Push exec target on all inferiors
3006         sharing the program space.
3007         (remove_target_sections): Remove the exec target from all
3008         inferiors sharing the program space.
3009         (exec_on_vfork): New.
3010         * exec.h (exec_on_vfork): Declare.
3011         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3012         Pass it down.
3013         (fbsd_nat_target::update_thread_list): Adjust.
3014         (fbsd_nat_target::resume): Adjust.
3015         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3016         down.
3017         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3018         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3019         get_thread_arch_regcache call.
3020         * fork-child.c (gdb_startup_inferior): Pass target down to
3021         startup_inferior and set_executing.
3022         * gdbthread.h (struct process_stratum_target): Forward declare.
3023         (add_thread, add_thread_silent, add_thread_with_info)
3024         (in_thread_list): Add process_stratum_target parameter.
3025         (find_thread_ptid(inferior*, ptid_t)): New overload.
3026         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3027         parameter.
3028         (all_threads()): Delete overload.
3029         (all_threads, all_non_exited_threads): Add process_stratum_target
3030         parameter.
3031         (all_threads_safe): Use brace initialization.
3032         (thread_count): Add process_stratum_target parameter.
3033         (set_resumed, set_running, set_stop_requested, set_executing)
3034         (threads_are_executing, finish_thread_state): Add
3035         process_stratum_target parameter.
3036         (switch_to_thread): Use is_current_thread.
3037         * i386-fbsd-tdep.c: Include "inferior.h".
3038         (i386fbsd_get_thread_local_address): Pass down target.
3039         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3040         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3041         have_inferiors check.
3042         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3043         (inf_ptrace_target::attach): Adjust.
3044         * infcall.c (run_inferior_call): Adjust.
3045         * infcmd.c (run_command_1): Pass target to
3046         scoped_finish_thread_state.
3047         (proceed_thread_callback): Skip inferiors with no execution.
3048         (continue_command): Rename 'all_threads' local to avoid hiding
3049         'all_threads' function.  Adjust get_last_target_status call.
3050         (prepare_one_step): Adjust set_running call.
3051         (signal_command): Use user_visible_resume_target.  Compare thread
3052         pointers instead of inferior_ptid.
3053         (info_program_command): Adjust to pass down target.
3054         (attach_command): Mark target's 'thread_executing' flag.
3055         (stop_current_target_threads_ns): New, factored out from ...
3056         (interrupt_target_1): ... this.  Switch inferior before making
3057         target calls.
3058         * inferior-iter.h
3059         (struct all_inferiors_iterator, struct all_inferiors_range)
3060         (struct all_inferiors_safe_range)
3061         (struct all_non_exited_inferiors_range): Filter on
3062         process_stratum_target too.  Remove explicit.
3063         * inferior.c (inferior::inferior): Push dummy target on target
3064         stack.
3065         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3066         Add process_stratum_target parameter, and pass it down.
3067         (have_live_inferiors): Adjust.
3068         (switch_to_inferior_and_push_target): New.
3069         (add_inferior_command, clone_inferior_command): Handle
3070         "-no-connection" parameter.  Use
3071         switch_to_inferior_and_push_target.
3072         (_initialize_inferior): Mention "-no-connection" option in
3073         the help of "add-inferior" and "clone-inferior" commands.
3074         * inferior.h: Include "process-stratum-target.h".
3075         (interrupt_target_1): Use bool.
3076         (struct inferior) <push_target, unpush_target, target_is_pushed,
3077         find_target_beneath, top_target, process_target, target_at,
3078         m_stack>: New.
3079         (discard_all_inferiors): Delete.
3080         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3081         (all_inferiors, all_non_exited_inferiors): Add
3082         process_stratum_target parameter.
3083         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3084         (target_last_proc_target): New global.
3085         (follow_fork_inferior): Push target on new inferior.  Pass target
3086         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3087         reference count.
3088         (follow_fork): Adjust get_last_target_status call.  Also consider
3089         target.
3090         (follow_exec): Push target on new inferior.
3091         (struct execution_control_state) <target>: New field.
3092         (user_visible_resume_target): New.
3093         (do_target_resume): Call target_async.
3094         (resume_1): Set target's threads_executing flag.  Consider resume
3095         target.
3096         (commit_resume_all_targets): New.
3097         (proceed): Also consider resume target.  Skip threads of inferiors
3098         with no execution.  Commit resumtion in all targets.
3099         (start_remote): Pass current inferior to wait_for_inferior.
3100         (infrun_thread_stop_requested): Consider target as well.  Pass
3101         thread_info pointer to clear_inline_frame_state instead of ptid.
3102         (infrun_thread_thread_exit): Consider target as well.
3103         (random_pending_event_thread): New inferior parameter.  Use it.
3104         (do_target_wait): Rename to ...
3105         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3106         down.
3107         (threads_are_resumed_pending_p, do_target_wait): New.
3108         (prepare_for_detach): Adjust calls.
3109         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3110         do_target_wait_1 instead of do_target_wait.
3111         (fetch_inferior_event): Adjust.  Switch to representative
3112         inferior.  Pass target down.
3113         (set_last_target_status): Add process_stratum_target parameter.
3114         Save target in global.
3115         (get_last_target_status): Add process_stratum_target parameter and
3116         handle it.
3117         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3118         (context_switch): Check inferior_ptid == null_ptid before calling
3119         inferior_thread().
3120         (get_inferior_stop_soon): Pass down target.
3121         (wait_one): Rename to ...
3122         (poll_one_curr_target): ... this.
3123         (struct wait_one_event): New.
3124         (wait_one): New.
3125         (stop_all_threads): Adjust.
3126         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3127         event's target.
3128         (switch_back_to_stepped_thread): Also consider target.
3129         (print_stop_event): Update.
3130         (normal_stop): Update.  Also consider the resume target.
3131         * infrun.h (wait_for_inferior): Remove declaration.
3132         (user_visible_resume_target): New declaration.
3133         (get_last_target_status, set_last_target_status): New
3134         process_stratum_target parameter.
3135         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3136         process_stratum_target parameter, and use it.
3137         (clear_inline_frame_state (thread_info*)): New.
3138         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3139         process_stratum_target parameter.
3140         (clear_inline_frame_state (thread_info*)): Declare.
3141         * linux-fork.c (delete_checkpoint_command): Pass target down to
3142         find_thread_ptid.
3143         (checkpoint_command): Adjust.
3144         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3145         instead of just tweaking inferior_ptid.
3146         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3147         (exit_lwp): Pass target down to find_thread_ptid.
3148         (attach_proc_task_lwp_callback): Pass target down to
3149         add_thread/set_running/set_executing.
3150         (linux_nat_target::attach): Pass target down to
3151         thread_change_ptid.
3152         (get_detach_signal): Pass target down to find_thread_ptid.
3153         Consider last target status's target.
3154         (linux_resume_one_lwp_throw, resume_lwp)
3155         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3156         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3157         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3158         (linux_nat_target::async_wait_fd): New.
3159         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3160         target down.
3161         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3162         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3163         * linux-thread-db.c (struct thread_db_info::process_target): New
3164         field.
3165         (add_thread_db_info): Save target.
3166         (get_thread_db_info): New process_stratum_target parameter.  Also
3167         match target.
3168         (delete_thread_db_info): New process_stratum_target parameter.
3169         Also match target.
3170         (thread_from_lwp): Adjust to pass down target.
3171         (thread_db_notice_clone): Pass down target.
3172         (check_thread_db_callback): Pass down target.
3173         (try_thread_db_load_1): Always push the thread_db target.
3174         (try_thread_db_load, record_thread): Pass target down.
3175         (thread_db_target::detach): Pass target down.  Always unpush the
3176         thread_db target.
3177         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3178         target down.  Always unpush the thread_db target.
3179         (find_new_threads_callback, thread_db_find_new_threads_2)
3180         (thread_db_target::update_thread_list): Pass target down.
3181         (thread_db_target::pid_to_str): Pass current inferior down.
3182         (thread_db_target::get_thread_local_address): Pass target down.
3183         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3184         target down.
3185         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3186         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3187         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3188         (procfs_init_inferior): Rename to ...
3189         (procfs_target::procfs_init_inferior): ... this and adjust.
3190         (procfs_target::create_inferior, procfs_notice_thread)
3191         (procfs_do_thread_registers): Adjust.
3192         * ppc-fbsd-tdep.c: Include "inferior.h".
3193         (ppcfbsd_get_thread_local_address): Pass down target.
3194         * proc-service.c (ps_xfer_memory): Switch current inferior and
3195         program space as well.
3196         (get_ps_regcache): Pass target down.
3197         * process-stratum-target.c
3198         (process_stratum_target::thread_address_space)
3199         (process_stratum_target::thread_architecture): Pass target down.
3200         * process-stratum-target.h
3201         (process_stratum_target::threads_executing): New field.
3202         (as_process_stratum_target): New.
3203         * ravenscar-thread.c
3204         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3205         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3206         down.
3207         * record-btrace.c (record_btrace_target::info_record): Adjust.
3208         (record_btrace_target::record_method)
3209         (record_btrace_target::record_is_replaying)
3210         (record_btrace_target::fetch_registers)
3211         (get_thread_current_frame_id, record_btrace_target::resume)
3212         (record_btrace_target::wait, record_btrace_target::stop): Pass
3213         target down.
3214         * record-full.c (record_full_wait_1): Switch to event thread.
3215         Pass target down.
3216         * regcache.c (regcache::regcache)
3217         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3218         process_stratum_target parameter and handle it.
3219         (current_thread_target): New global.
3220         (get_thread_regcache): Add process_stratum_target parameter and
3221         handle it.  Switch inferior before calling target method.
3222         (get_thread_regcache): Pass target down.
3223         (get_thread_regcache_for_ptid): Pass target down.
3224         (registers_changed_ptid): Add process_stratum_target parameter and
3225         handle it.
3226         (registers_changed_thread, registers_changed): Pass target down.
3227         (test_get_thread_arch_aspace_regcache): New.
3228         (current_regcache_test): Define a couple local test_target_ops
3229         instances and use them for testing.
3230         (readwrite_regcache): Pass process_stratum_target parameter.
3231         (cooked_read_test, cooked_write_test): Pass mock_target down.
3232         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3233         (get_thread_arch_aspace_regcache): Add process_stratum_target
3234         parameter.
3235         (regcache::target): New method.
3236         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3237         (regcache::registers_changed_ptid): Add process_stratum_target
3238         parameter.
3239         (regcache::m_target): New field.
3240         (registers_changed_ptid): Add process_stratum_target parameter.
3241         * remote.c (remote_state::supports_vCont_probed): New field.
3242         (remote_target::async_wait_fd): New method.
3243         (remote_unpush_and_throw): Add remote_target parameter.
3244         (get_current_remote_target): Adjust.
3245         (remote_target::remote_add_inferior): Push target.
3246         (remote_target::remote_add_thread)
3247         (remote_target::remote_notice_new_inferior)
3248         (get_remote_thread_info): Pass target down.
3249         (remote_target::update_thread_list): Skip threads of inferiors
3250         bound to other targets.  (remote_target::close): Don't discard
3251         inferiors.  (remote_target::add_current_inferior_and_thread)
3252         (remote_target::process_initial_stop_replies)
3253         (remote_target::start_remote)
3254         (remote_target::remote_serial_quit_handler): Pass down target.
3255         (remote_target::remote_unpush_target): New remote_target
3256         parameter.  Unpush the target from all inferiors.
3257         (remote_target::remote_unpush_and_throw): New remote_target
3258         parameter.  Pass it down.
3259         (remote_target::open_1): Check whether the current inferior has
3260         execution instead of checking whether any inferior is live.  Pass
3261         target down.
3262         (remote_target::remote_detach_1): Pass down target.  Use
3263         remote_unpush_target.
3264         (extended_remote_target::attach): Pass down target.
3265         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3266         (remote_target::append_resumption): Pass down target.
3267         (remote_target::append_pending_thread_resumptions)
3268         (remote_target::remote_resume_with_hc, remote_target::resume)
3269         (remote_target::commit_resume): Pass down target.
3270         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3271         (remote_target::interrupt_query)
3272         (remote_target::remove_new_fork_children)
3273         (remote_target::check_pending_events_prevent_wildcard_vcont)
3274         (remote_target::remote_parse_stop_reply)
3275         (remote_target::process_stop_reply): Pass down target.
3276         (first_remote_resumed_thread): New remote_target parameter.  Pass
3277         it down.
3278         (remote_target::wait_as): Pass down target.
3279         (unpush_and_perror): New remote_target parameter.  Pass it down.
3280         (remote_target::readchar, remote_target::remote_serial_write)
3281         (remote_target::getpkt_or_notif_sane_1)
3282         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3283         down target.
3284         (remote_target::mourn_inferior): Pass down target.  Use
3285         remote_unpush_target.
3286         (remote_target::core_of_thread)
3287         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3288         (remote_target::pid_to_exec_file)
3289         (remote_target::thread_handle_to_thread_info): Pass down target.
3290         (remote_target::async_wait_fd): New.
3291         * riscv-fbsd-tdep.c: Include "inferior.h".
3292         (riscv_fbsd_get_thread_local_address): Pass down target.
3293         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3294         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3295         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3296         Adjust.
3297         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3298         * solib-svr4.c (enable_break): Pass down target.
3299         * spu-multiarch.c (parse_spufs_run): Pass down target.
3300         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3301         * target-delegates.c: Regenerate.
3302         * target.c (g_target_stack): Delete.
3303         (current_top_target): Return the current inferior's top target.
3304         (target_has_execution_1): Refer to the passed-in inferior's top
3305         target.
3306         (target_supports_terminal_ours): Check whether the initial
3307         inferior was already created.
3308         (decref_target): New.
3309         (target_stack::push): Incref/decref the target.
3310         (push_target, push_target, unpush_target): Adjust.
3311         (target_stack::unpush): Defref target.
3312         (target_is_pushed): Return bool.  Adjust to refer to the current
3313         inferior's target stack.
3314         (dispose_inferior): Delete, and inline parts ...
3315         (target_preopen): ... here.  Only dispose of the current inferior.
3316         (target_detach): Hold strong target reference while detaching.
3317         Pass target down.
3318         (target_thread_name): Add assertion.
3319         (target_resume): Pass down target.
3320         (target_ops::beneath, find_target_at): Adjust to refer to the
3321         current inferior's target stack.
3322         (get_dummy_target): New.
3323         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3324         has a thread running.
3325         (initialize_targets): Rename to ...
3326         (_initialize_target): ... this.
3327         * target.h: Include "gdbsupport/refcounted-object.h".
3328         (struct target_ops): Inherit refcounted_object.
3329         (target_ops::shortname, target_ops::longname): Make const.
3330         (target_ops::async_wait_fd): New method.
3331         (decref_target): Declare.
3332         (struct target_ops_ref_policy): New.
3333         (target_ops_ref): New typedef.
3334         (get_dummy_target): Declare function.
3335         (target_is_pushed): Return bool.
3336         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3337         (all_matching_threads_iterator::all_matching_threads_iterator):
3338         Handle filter target.
3339         * thread-iter.h (struct all_matching_threads_iterator, struct
3340         all_matching_threads_range, class all_non_exited_threads_range):
3341         Filter by target too.  Remove explicit.
3342         * thread.c (threads_executing): Delete.
3343         (inferior_thread): Pass down current inferior.
3344         (clear_thread_inferior_resources): Pass down thread pointer
3345         instead of ptid_t.
3346         (add_thread_silent, add_thread_with_info, add_thread): Add
3347         process_stratum_target parameter.  Use it for thread and inferior
3348         searches.
3349         (is_current_thread): New.
3350         (thread_info::deletable): Use it.
3351         (find_thread_ptid, thread_count, in_thread_list)
3352         (thread_change_ptid, set_resumed, set_running): New
3353         process_stratum_target parameter.  Pass it down.
3354         (set_executing): New process_stratum_target parameter.  Pass it
3355         down.  Adjust reference to 'threads_executing'.
3356         (threads_are_executing): New process_stratum_target parameter.
3357         Adjust reference to 'threads_executing'.
3358         (set_stop_requested, finish_thread_state): New
3359         process_stratum_target parameter.  Pass it down.
3360         (switch_to_thread): Also match inferior.
3361         (switch_to_thread): New process_stratum_target parameter.  Pass it
3362         down.
3363         (update_threads_executing): Reimplement.
3364         * top.c (quit_force): Pop targets from all inferior.
3365         (gdb_init): Don't call initialize_targets.
3366         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3367         Declare.
3368         (windows_add_thread, windows_delete_thread): Adjust.
3369         (get_windows_debug_event): Rename to ...
3370         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3371         * tracefile-tfile.c (tfile_target_open): Pass down target.
3372         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3373         Forward declare.
3374         (switch_to_thread): Add process_stratum_target parameter.
3375         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3376         parameter.  Use it.
3377         (mi_on_resume): Pass target down.
3378         * nat/fork-inferior.c (startup_inferior): Add
3379         process_stratum_target parameter.  Pass it down.
3380         * nat/fork-inferior.h (startup_inferior): Add
3381         process_stratum_target parameter.
3382         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3383
3384 2020-01-10  Pedro Alves  <palves@redhat.com>
3385
3386         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3387         directly.  Instead find the first thread in the thread list and
3388         use switch_to_thread.
3389
3390 2020-01-10  Pedro Alves  <palves@redhat.com>
3391
3392         * remote.c (remote_target::remote_add_inferior): Don't bind a
3393         process to the current inferior if the current inferior is already
3394         bound to a process.
3395
3396 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3397             Pedro Alves  <palves@redhat.com>
3398
3399         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3400         If no process is specified, return null_ptid instead of
3401         inferior_ptid.
3402         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3403         TARGET_WAITKIND_SIGNALLED with no pid.
3404
3405 2020-01-10  Pedro Alves  <palves@redhat.com>
3406
3407         * remote.c (first_remote_resumed_thread): New.
3408         (remote_target::wait_as): Use it as default event_ptid instead of
3409         inferior_ptid.
3410
3411 2020-01-10  Pedro Alves  <palves@redhat.com>
3412
3413         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3414
3415 2020-01-10  Pedro Alves  <palves@redhat.com>
3416
3417         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3418         not -1.
3419
3420 2020-01-10  Pedro Alves  <palves@redhat.com>
3421
3422         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3423         ptid to get_last_target_status.
3424         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3425         ptid to get_last_target_status.
3426         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3427         get_last_target_status.
3428         (info_program_command): Don't pass a target_waitstatus to
3429         get_last_target_status.
3430         * infrun.c (init_wait_for_inferior): Use
3431         nullify_last_target_wait_ptid.
3432         (get_last_target_status): Handle nullptr arguments.
3433         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3434         (print_stop_event): Don't pass a ptid to get_last_target_status.
3435         (normal_stop): Don't pass a ptid to get_last_target_status.
3436         * infrun.h (get_last_target_status, set_last_target_status): Move
3437         comments here and update.
3438         (nullify_last_target_wait_ptid): Declare.
3439         * linux-fork.c (fork_load_infrun_state): Remove local extern
3440         declaration of nullify_last_target_wait_ptid.
3441         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3442         to get_last_target_status.
3443
3444 2020-01-10  Pedro Alves  <palves@redhat.com>
3445
3446         * gdbthread.h (scoped_restore_current_thread)
3447         <dont_restore, restore, m_dont_restore>: Declare.
3448         * thread.c (thread_alive): Add assertion.  Return bool.
3449         (switch_to_thread_if_alive): New.
3450         (prune_threads): Switch inferior/thread.
3451         (print_thread_info_1): Switch thread before calling target methods.
3452         (scoped_restore_current_thread::restore): New, factored out from
3453         ...
3454         (scoped_restore_current_thread::~scoped_restore_current_thread):
3455         ... this.
3456         (scoped_restore_current_thread::scoped_restore_current_thread):
3457         Add assertion.
3458         (thread_apply_all_command, thread_select): Use
3459         switch_to_thread_if_alive.
3460         * infrun.c (proceed, restart_threads, handle_signal_stop)
3461         (switch_back_to_stepped_thread): Switch current thread before
3462         calling target methods.
3463
3464 2020-01-10  Pedro Alves <palves@redhat.com>
3465
3466         * inferior.c (switch_to_inferior_no_thread): New function,
3467         factored out from ...
3468         (inferior_command): ... here.
3469         * inferior.h (switch_to_inferior_no_thread): Declare.
3470         * mi/mi-main.c (run_one_inferior): Use
3471         switch_to_inferior_no_thread.
3472
3473 2020-01-10  Pedro Alves  <palves@redhat.com>
3474
3475         * infcmd.c (kill_command): Remove dead code.
3476
3477 2020-01-10  Pedro Alves  <palves@redhat.com>
3478
3479         * remote.c (remote_target::mourn_inferior): No longer check
3480         whether the target is running.
3481
3482 2020-01-10  Pedro Alves  <palves@redhat.com>
3483
3484         * corelow.c (core_target::has_execution): Change parameter type to
3485         inferior pointer.
3486         * inferior.c (number_of_live_inferiors): Use
3487         inferior::has_execution instead of target_has_execution_1.
3488         * inferior.h (inferior::has_execution): New.
3489         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3490         inferior::has_execution instead of target_has_execution_1.
3491         * process-stratum-target.c
3492         (process_stratum_target::has_execution): Change parameter type to
3493         inferior pointer.  Check the inferior's PID instead of
3494         inferior_ptid.
3495         * process-stratum-target.h
3496         (process_stratum_target::has_execution): Change parameter type to
3497         inferior pointer.
3498         * record-full.c (record_full_core_target::has_execution): Change
3499         parameter type to inferior pointer.
3500         * target.c (target_has_execution_1): Change parameter type to
3501         inferior pointer.
3502         (target_has_execution_current): Adjust.
3503         * target.h (target_ops::has_execution): Change parameter type to
3504         inferior pointer.
3505         (target_has_execution_1): Change parameter type to inferior
3506         pointer.  Change return type to bool.
3507         * tracefile.h (tracefile_target::has_execution): Change parameter
3508         type to inferior pointer.
3509
3510 2020-01-10  Pedro Alves  <palves@redhat.com>
3511
3512         * exceptions.c (print_flush): Remove current_top_target() check.
3513
3514 2020-01-10  Pedro Alves  <palves@redhat.com>
3515
3516         * remote.c (show_remote_exec_file): Show the current inferior's
3517         exec-file instead of the command variable's value.
3518
3519 2020-01-10  Pedro Alves  <palves@redhat.com>
3520
3521         * record-full.c (record_full_resume_ptid): New global.
3522         (record_full_target::resume): Set it.
3523         (record_full_wait_1): Use record_full_resume_ptid instead of
3524         inferior_ptid.
3525
3526 2020-01-10  Pedro Alves  <palves@redhat.com>
3527
3528         * gdbthread.h (scoped_restore_current_thread)
3529         <dont_restore, restore, m_dont_restore>: Declare.
3530         * thread.c (thread_alive): Add assertion.  Return bool.
3531         (switch_to_thread_if_alive): New.
3532         (prune_threads): Switch inferior/thread.
3533         (print_thread_info_1): Switch thread before calling target methods.
3534         (scoped_restore_current_thread::restore): New, factored out from
3535         ...
3536         (scoped_restore_current_thread::~scoped_restore_current_thread):
3537         ... this.
3538         (scoped_restore_current_thread::scoped_restore_current_thread):
3539         Add assertion.
3540         (thread_apply_all_command, thread_select): Use
3541         switch_to_thread_if_alive.
3542
3543 2020-01-10  George Barrett  <bob@bob131.so>
3544
3545         * stap-probe.c (stap_modify_semaphore): Don't check for null
3546         semaphores.
3547         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3548         for null semaphores.
3549
3550 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3553         all source windows, and maintain horizontal scroll status while
3554         doing so.
3555
3556 2020-01-09  Tom Tromey  <tom@tromey.com>
3557
3558         PR tui/18932:
3559         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3560         update_source_window, not print_source_lines.
3561
3562 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * tui/tui.c (tui_enable): Register tui hooks after calling
3565         tui_display_main.
3566
3567 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3568
3569         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3570
3571 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3572
3573         * thread.c (print_thread_info_1): Fix indentation.
3574
3575 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3576
3577         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3578         unique_xmalloc_ptr outside the if to always free the demangled name.
3579
3580 2020-01-08  Tom Tromey  <tromey@adacore.com>
3581
3582         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3583         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3584         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3585         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3586         Remove.
3587         (section_offsets): New typedef.
3588         * symtab.c (fixup_section, get_msymbol_address): Update.
3589         * symmisc.c (dump_msymbols): Update.
3590         * symfile.h (relative_addr_info_to_section_offsets)
3591         (symfile_map_offsets_to_segments): Update.
3592         * symfile.c (build_section_addr_info_from_objfile)
3593         (init_objfile_sect_indices): Update.
3594         (struct place_section_arg): Change type of "offsets".
3595         (place_section): Update.
3596         (relative_addr_info_to_section_offsets): Change type of
3597         "section_offsets".  Remove "num_sections" parameter.
3598         (default_symfile_offsets, syms_from_objfile_1)
3599         (set_objfile_default_section_offset): Update.
3600         (reread_symbols): No need to preserve section offsets by hand.
3601         (symfile_map_offsets_to_segments): Change type of "offsets".
3602         * stap-probe.c (relocate_address): Update.
3603         * stabsread.h (process_one_symbol): Update.
3604         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3605         (solib_target_relocate_section_addresses): Update.
3606         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3607         Update.
3608         * solib-frv.c (frv_relocate_main_executable): Update.
3609         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3610         * solib-aix.c (solib_aix_get_section_offsets): Change return
3611         type.
3612         (solib_aix_solib_create_inferior_hook): Update.
3613         * remote.c (remote_target::get_offsets): Update.
3614         * psymtab.c (find_pc_sect_psymtab): Update.
3615         * psympriv.h (struct partial_symbol) <address, text_low,
3616         text_high>: Update.
3617         * objfiles.h (obj_section_offset): Update.
3618         (struct objfile) <section_offsets>: Change type.
3619         <num_sections>: Remove.
3620         (objfile_relocate): Update.
3621         * objfiles.c (entry_point_address_query): Update
3622         (relocate_one_symbol): Change type of "section_offsets".
3623         (objfile_relocate1, objfile_relocate1): Change type of
3624         "new_offsets".
3625         (objfile_rebase1): Update.
3626         * mipsread.c (mipscoff_symfile_read): Update.
3627         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3628         parameter.
3629         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3630         (parse_external, psymtab_to_symtab_1): Update.
3631         * machoread.c (macho_symfile_offsets): Update.
3632         * ia64-tdep.c (ia64_find_unwind_table): Update.
3633         * hppa-tdep.c (read_unwind_info): Update.
3634         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3635         * dwarf2read.c (create_addrmap_from_index)
3636         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3637         (process_psymtab_comp_unit_reader, add_partial_symbol)
3638         (add_partial_subprogram, process_full_comp_unit)
3639         (read_file_scope, read_func_scope, read_lexical_block_scope)
3640         (read_call_site_scope, dwarf2_rnglists_process)
3641         (dwarf2_ranges_process, dwarf2_ranges_read)
3642         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3643         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3644         Update.
3645         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3646         Update.
3647         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3648         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3649         (process_one_symbol): Change type of "section_offsets".
3650         * ctfread.c (get_objfile_text_range): Update.
3651         * coffread.c (coff_symtab_read, enter_linenos)
3652         (process_coff_symbol): Update.
3653         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3654         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3655
3656 2020-01-08  Tom Tromey  <tromey@adacore.com>
3657
3658         * dwarf2read.c (parse_macro_definition): Use std::string.
3659         (parse_macro_definition): Likewise.
3660
3661 2020-01-08  Tom Tromey  <tromey@adacore.com>
3662
3663         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3664         (ATTR_ALLOC_CHUNK): Remove.
3665
3666 2020-01-08  Tom Tromey  <tromey@adacore.com>
3667
3668         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3669
3670 2020-01-08  Tom Tromey  <tromey@adacore.com>
3671
3672         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3673         (dwarf2_compute_name, open_dwo_file): Likewise.
3674         (process_enumeration_scope): Use std::vector.
3675         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3676         (partial_die_info::fixup, dwarf2_start_subfile)
3677         (guess_full_die_structure_name, dwarf2_name): Likewise.
3678         (determine_prefix): Update.
3679         (guess_full_die_structure_name): Make return type const.
3680         (partial_die_full_name): Return unique_xmalloc_ptr.
3681         (DW_FIELD_ALLOC_CHUNK): Remove.
3682
3683 2020-01-07  Tom Tromey  <tromey@adacore.com>
3684
3685         PR build/24937:
3686         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3687
3688 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3689
3690         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3691
3692 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * stack.c (print_frame_info): Move disassemble_next_line code
3695         inside source_print block.
3696
3697 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3698
3699         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3700         gdb/signals.h, as we are now using native signal symbols.
3701
3702 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3703
3704         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3705         overflow by an early check of content vs threshold.
3706         * tui/tui-source.c (tui_source_window::line_is_displayed):
3707         Likewise.
3708
3709 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3710
3711         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3712
3713 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3714
3715         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3716         export table if no section contains it's RVA.
3717
3718 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3719
3720         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3721
3722 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3723
3724         * source.c (print_source_lines_base): Set last_line_listed.
3725
3726 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3727
3728         * tui/tui-disasm.c: Remove trailing spaces.
3729
3730 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3731             Pedro Alves  <palves@redhat.com>
3732
3733         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
3734         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
3735         (windows_gdb_signal_to_target): New function, uses the above
3736         enumeration to convert GDB internal signal codes to equivalent
3737         Windows codes.
3738         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
3739         * windows-nat.c: Include "gdb_wait.h".
3740         (get_windows_debug_event): Extract the fatal exception from the
3741         exit status and convert to the equivalent Posix signal number.
3742         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
3743         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
3744         * gdbsupport/gdb_wait.c: New file, implements
3745         windows_status_to_termsig.
3746         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
3747         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
3748
3749 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
3752         show_layout.
3753
3754 2020-01-05  Luis Machado  <luis.machado@linaro.org>
3755
3756         * aarch64-linux-nat.c
3757         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
3758         and bfd_mach_aarch64.
3759
3760 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3761
3762         * ui-file.c (stdio_file::can_emit_style_escape)
3763         (tee_file::can_emit_style_escape): Ensure style is used also on
3764         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
3765         to gdb_stdout.
3766         * main.c (set_gdb_data_directory): Use file style to output the
3767         warning that the given pathname is not a directory.
3768         * top.c (show_history_filename, gdb_safe_append_history)
3769         (show_gdb_datadir): Use file style.
3770
3771 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3772
3773         * solib-target.c (struct lm_info_target):
3774         Change offsets to be a unique_xmalloc_ptr.
3775         (solib_target_relocate_section_addresses): Update.
3776
3777 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3778
3779         * windows-nat.c (windows_clear_solib): Free so_list linked list.
3780
3781 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3782
3783         * MAINTAINERS (Write After Approval): Add myself.
3784
3785 2020-01-02  Luis Machado  <luis.machado@linaro.org>
3786
3787         * proc-service.c (get_ps_regcache): Remove reference to obsolete
3788         Cell BE architecture.
3789         * target.h (struct target_ops) <thread_architecture>: Likewise.
3790
3791 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3792
3793         * Makefile.in: Use INSTALL_PROGRAM_ENV.
3794
3795 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3796
3797         * MAINTAINERS (Write After Approval): Add myself.
3798
3799 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3800
3801         * gdbarch.sh: Update copyright year range of generated files.
3802
3803 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3804
3805         Update copyright year range in all GDB files.
3806
3807 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3808
3809         * copyright.py: Convert to Python 3.
3810
3811 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3812
3813         * copyright.py: Adapt after move of gnulib directory from gdb
3814         directory to toplevel directory.
3815
3816 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3817
3818         * copyright.py (main): Exit if run from the wrong directory.
3819
3820 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3821
3822         * top.c (print_gdb_version): Change copyright year to 2020.
3823
3824 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3825
3826         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
3827
3828 For older changes see ChangeLog-2019.
3829 \f
3830 Local Variables:
3831 mode: change-log
3832 left-margin: 8
3833 fill-column: 74
3834 version-control: never
3835 coding: utf-8
3836 End: