gdb/ChangeLog

   1 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
   4         std::unique_ptr.
   5         * gdbarch.c: Re-generate.
   6         * gdbarch.h: Re-generate.
   7         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
   8         change.
   9         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
  10         type to std::unique_ptr.
  11         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
  12         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
  13         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
  14         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
  15         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
  16         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
  17         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
  18         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
  19         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
  20
  21 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
  22
  23         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
  24         std::unique_ptr.
  25         (displaced_step_clear): Rename to...
  26         (displaced_step_reset): ... this.  Just call displaced->reset ().
  27         (displaced_step_clear_cleanup): Rename to...
  28         (displaced_step_reset_cleanup): ... this.
  29         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
  30         (displaced_step_fixup): Likewise.
  31         (resume_1): Likewise.
  32         (handle_inferior_event): Restore child's memory before calling
  33         displaced_step_fixup on the parent.
  34         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
  35         to std::unique_ptr.
  36         <step_closure>: Change type to std::unique_ptr.
  37
  38 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
  39
  40         * arm-tdep.c: Include count-one-bits.h.
  41         (cleanup_block_store_pc): Use count_one_bits.
  42         (cleanup_block_load_pc): Use count_one_bits.
  43         (arm_copy_block_xfer): Use count_one_bits.
  44         (thumb2_copy_block_xfer): Use count_one_bits.
  45         (thumb_copy_pop_pc_16bit): Use count_one_bits.
  46         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
  47         (thumb_get_next_pcs_raw): Use count_one_bits.
  48         (arm_get_next_pcs_raw): Use count_one_bits_l.
  49         * arch/arm.c (bitcount): Remove.
  50         * arch/arm.h (bitcount): Remove.
  51
  52 2020-02-14  Tom Tromey  <tromey@adacore.com>
  53
  54         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
  55         Update.
  56         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
  57         * dwarf2/loc.c (call_site_find_chain_1): Return
  58         unique_xmalloc_ptr.
  59         (call_site_find_chain): Likewise.
  60
  61 2020-02-14  Richard Biener  <rguenther@suse.de>
  62
  63         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
  64         on expression with division operators.
  65
  66 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
  67
  68         * MAINTAINERS (Write After Approval): Adding myself.
  69
  70 2020-02-12  Tom Tromey  <tom@tromey.com>
  71
  72         * event-loop.c (event_data, gdb_event, event_handler_func):
  73         Remove.
  74
  75 2020-02-12  Tom Tromey  <tom@tromey.com>
  76
  77         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
  78         (dwarf2_frame_objfile_data): Add comment.
  79         (find_comp_unit, set_comp_unit): New functions.
  80         (dwarf2_frame_find_fde): Use find_comp_unit.
  81         (dwarf2_build_frame_info): Use set_comp_unit.
  82
  83 2020-02-12  Tom Tromey  <tom@tromey.com>
  84
  85         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
  86         (comp_unit): Don't initialize objfile.
  87         (execute_cfa_program): Add text_offset parameter.
  88         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
  89         (dwarf2_frame_cache): Update.
  90         (dwarf2_build_frame_info): Don't set "objfile" member.
  91
  92 2020-02-12  Tom Tromey  <tom@tromey.com>
  93
  94         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
  95         (decode_frame_entry): Likewise.
  96         (dwarf2_build_frame_info): Update.
  97
  98 2020-02-12  Tom Tromey  <tom@tromey.com>
  99
 100         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
 101         (decode_frame_entry_1): Use the comp_unit obstack.
 102
 103 2020-02-12  Tom Tromey  <tom@tromey.com>
 104
 105         * dwarf2/frame.c (struct comp_unit): Add initializers and
 106         constructor.
 107         (dwarf2_frame_objfile_data): Store a comp_unit.
 108         (dwarf2_frame_find_fde): Update.
 109         (dwarf2_build_frame_info): Use "new".
 110
 111 2020-02-12  Tom Tromey  <tom@tromey.com>
 112
 113         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
 114         (dwarf2_fde_table): Typedef for std::vector.
 115         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
 116         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
 117         (decode_frame_entry): Update.
 118         (dwarf2_build_frame_info): Use "new".
 119
 120 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * arm-tdep.c (arm_gdbarch_init): Update.
 123         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
 124         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
 125         have_neon, is_m>: Change to bool.
 126
 127 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 128
 129         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
 130
 131 2020-02-12  Tom Tromey  <tom@tromey.com>
 132
 133         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
 134
 135 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
 136
 137         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
 138         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
 139
 140 2020-02-11  Tom Tromey  <tom@tromey.com>
 141
 142         * psymtab.h: Update comment.
 143
 144 2020-02-11  Tom Tromey  <tom@tromey.com>
 145
 146         * gdb_obstack.h (struct auto_obstack): Use
 147         DISABLE_COPY_AND_ASSIGN.
 148
 149 2020-02-11  Tom Tromey  <tom@tromey.com>
 150
 151         * dwarf2/frame.h (struct objfile): Don't forward declare.
 152
 153 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * cris-tdep.c (cris_supply_gregset): Change signature to match
 156         what struct regset expects.
 157         (cris_regset): New struct.
 158         (fetch_core_registers): Remove.
 159         (cris_iterate_over_regset_sections): New function.
 160         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
 161         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
 162
 163 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
 166         registers.
 167
 168 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
 171
 172 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 173
 174         * configure: Re-generate.
 175
 176 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 177
 178         * configure: Re-generate.
 179
 180 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 181
 182         * acinclude: Update warning.m4 path.
 183         * warning.m4: Move to gdbsupport.
 184
 185 2020-02-11  Tom Tromey  <tromey@adacore.com>
 186
 187         * remote.c (remote_console_output): Update.
 188         * printcmd.c (printf_command): Update.
 189         * event-loop.c (gdb_wait_for_event): Update.
 190         * linux-nat.c (sigchld_handler): Update.
 191         * remote-sim.c (gdb_os_write_stdout): Update.
 192         (gdb_os_flush_stdout): Update.
 193         (gdb_os_flush_stderr): Update.
 194         (gdb_os_write_stderr): Update.
 195         * exceptions.c (print_exception): Update.
 196         * remote-fileio.c (remote_fileio_func_read): Update.
 197         (remote_fileio_func_write): Update.
 198         * tui/tui.c (tui_enable): Update.
 199         * tui/tui-interp.c (tui_interp::init): Update.
 200         * utils.c (init_page_info): Update.
 201         (putchar_unfiltered, fputc_unfiltered): Update.
 202         (gdb_flush): Update.
 203         (emit_style_escape): Update.
 204         (flush_wrap_buffer, fputs_maybe_filtered): Update.
 205         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
 206         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
 207         (stderr_file::write): Update.
 208         (stderr_file::puts): Update.
 209         * ui-file.h (ui_file_isatty, ui_file_write)
 210         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
 211         (ui_file_puts): Don't declare.
 212
 213 2020-02-10  Tom de Vries  <tdevries@suse.de>
 214
 215         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
 216         sentinel to char *.
 217
 218 2020-02-09  Tom de Vries  <tdevries@suse.de>
 219
 220         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
 221         filename if it matches "<artificial>".
 222
 223 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 224
 225         * windows-tdep.c (struct enum_value_name): New struct.
 226         (create_enum): New function.
 227         (windows_get_siginfo_type): Create and use enum types.
 228
 229 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 230
 231         * NEWS: Mention $_siginfo support for Windows.
 232         * windows-nat.c (handle_exception): Set siginfo_er.
 233         (windows_nat_target::mourn_inferior): Reset siginfo_er.
 234         (windows_xfer_siginfo): New function.
 235         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
 236         * windows-tdep.c (struct windows_gdbarch_data): New struct.
 237         (init_windows_gdbarch_data): New function.
 238         (get_windows_gdbarch_data): New function.
 239         (windows_get_siginfo_type): New function.
 240         (windows_init_abi): Register windows_get_siginfo_type.
 241         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
 242
 243 2020-02-08  Tom Tromey  <tom@tromey.com>
 244
 245         * dwarf2/read.c (class cutu_reader) <cutu_reader,
 246         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
 247         <keep>: Declare method.
 248         <m_keep>: Remove member.
 249         <~cutu_reader>: Remove.
 250         (cutu_reader::init_tu_and_read_dwo_dies): Update.
 251         (cutu_reader::cutu_reader): Update.
 252         (cutu_reader::keep): Rename from ~cutu_reader.
 253         (process_psymtab_comp_unit, build_type_psymtabs_1)
 254         (process_skeletonless_type_unit, load_partial_comp_unit)
 255         (load_full_comp_unit, dwarf2_read_addr_index)
 256         (read_signatured_type): Update.
 257
 258 2020-02-08  Tom Tromey  <tom@tromey.com>
 259
 260         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
 261         "want_partial_unit" parameter.
 262         (process_psymtab_comp_unit): Change want_partial_unit to bool.
 263         Inline check for DW_TAG_partial_unit.
 264         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
 265
 266 2020-02-08  Tom Tromey  <tom@tromey.com>
 267
 268         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
 269         read.c.
 270         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
 271         read.c.
 272
 273 2020-02-08  Tom Tromey  <tom@tromey.com>
 274
 275         * dwarf2/read.c (read_address): Move to comp-unit.c.
 276         (dwarf2_rnglists_process, dwarf2_ranges_process)
 277         (read_attribute_value, dwarf_decode_lines_1)
 278         (var_decode_location, decode_locdesc): Update.
 279         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
 280         read.c.  Remove "cu" parameter.
 281         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
 282         method.
 283
 284 2020-02-08  Tom Tromey  <tom@tromey.com>
 285
 286         * dwarf2/read.c (read_attribute_value, read_indirect_string)
 287         (read_indirect_line_string): Update.
 288         * dwarf2/comp-unit.c (read_offset): Remove.
 289         (read_comp_unit_head): Update.
 290         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
 291         method.
 292         (read_offset): Don't declare.
 293
 294 2020-02-08  Tom Tromey  <tom@tromey.com>
 295
 296         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
 297         * dwarf2/read.c (struct comp_unit_head): Move to
 298         dwarf2/comp-unit.h.
 299         (enum class rcuh_kind): Move to comp-unit.h.
 300         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
 301         (read_comp_unit_head, error_check_comp_unit_head)
 302         (read_and_check_comp_unit_head): Move to comp-unit.c.
 303         (read_offset, dwarf_unit_type_name): Likewise.
 304         (create_debug_type_hash_table, read_cutu_die_from_dwo)
 305         (cutu_reader::cutu_reader, read_call_site_scope)
 306         (find_partial_die, follow_die_offset): Update.
 307         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
 308
 309 2020-02-08  Tom Tromey  <tom@tromey.com>
 310
 311         * dwarf2/read.c (read_offset_1): Move to leb.c.
 312         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
 313         (dwarf_decode_macro_bytes): Update.
 314         * dwarf2/leb.c (read_offset): Rename; move from read.c.
 315         * dwarf2/leb.h (read_offset): Declare.
 316
 317 2020-02-08  Tom Tromey  <tom@tromey.com>
 318
 319         * dwarf2/read.c (dwarf2_section_size): Remove.
 320         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
 321         Update.
 322         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
 323
 324 2020-02-08  Tom Tromey  <tom@tromey.com>
 325
 326         * dwarf2/read.c (read_initial_length): Move to leb.c.
 327         * dwarf2/leb.h (read_initial_length): Declare.
 328         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
 329         handle_nonstd parameter.
 330         * dwarf2/frame.c (read_initial_length): Remove.
 331         (decode_frame_entry_1): Update.
 332
 333 2020-02-08  Tom Tromey  <tom@tromey.com>
 334
 335         * dwarf2/loc.c (dwarf2_find_location_expression)
 336         (dwarf_evaluate_loc_desc::get_tls_address)
 337         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
 338         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
 339         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
 340         (dwarf2_compile_property_to_c)
 341         (dwarf2_loc_desc_get_symbol_read_needs)
 342         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
 343         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
 344         (loclist_describe_location, loclist_tracepoint_var_ref)
 345         (loclist_generate_c_location): Update.
 346         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 347         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
 348         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
 349         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
 350         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
 351         (dwarf2_per_cu_data::addr_size)
 352         (dwarf2_per_cu_data::ref_addr_size)
 353         (dwarf2_per_cu_data::text_offset)
 354         (dwarf2_per_cu_data::addr_type): Now methods.
 355         (per_cu_header_read_in): Make per_cu "const".
 356         (dwarf2_version): Remove.
 357         (dwarf2_per_cu_data::int_type): Now a method.
 358         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
 359         (set_die_type, read_array_type, read_subrange_index_type)
 360         (read_tag_string_type, read_subrange_type): Update.
 361         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
 362         offset_size, ref_addr_size, text_offset, addr_type, version,
 363         objfile, int_type, addr_sized_int_type>: Declare methods.
 364
 365 2020-02-08  Tom Tromey  <tom@tromey.com>
 366
 367         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
 368         Move earlier.
 369
 370 2020-02-08  Tom Tromey  <tom@tromey.com>
 371
 372         * dwarf2/read.h (dwarf_line_debug): Declare.
 373         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
 374         * dwarf2/read.c: Move line_header code to new files.
 375         (dwarf_line_debug): No longer static.
 376         * dwarf2/line-header.c: New file.
 377         * dwarf2/line-header.h: New file.
 378
 379 2020-02-08  Tom Tromey  <tom@tromey.com>
 380
 381         * dwarf2/read.c (struct line_header) <file_full_name,
 382         file_file_name>: Return unique_xmalloc_ptr.
 383         (line_header::file_file_name): Update.
 384         (line_header::file_full_name): Update.
 385         (dw2_get_file_names_reader): Update.
 386         (macro_start_file): Update.
 387
 388 2020-02-08  Tom Tromey  <tom@tromey.com>
 389
 390         * dwarf2/read.c (struct line_header) <file_full_name,
 391         file_file_name>: Declare methods.
 392         (dw2_get_file_names_reader): Update.
 393         (file_file_name): Now a method.
 394         (file_full_name): Likewise.
 395         (macro_start_file): Update.
 396
 397 2020-02-08  Tom Tromey  <tom@tromey.com>
 398
 399         * dwarf2/read.c (dwarf_always_disassemble)
 400         (show_dwarf_always_disassemble): Move to loc.c.
 401         (_initialize_dwarf2_read): Move "always-disassemble" registration
 402         to loc.c.
 403         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
 404         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
 405         static.
 406         (show_dwarf_always_disassemble): Move from read.c.
 407         (_initialize_dwarf2loc): Move always-disassemble from read.c.
 408
 409 2020-02-08  Tom Tromey  <tom@tromey.com>
 410
 411         * dwarf2/read.c (~dwarf2_per_objfile): Update.
 412         (create_quick_file_names_table): Return htab_up.
 413         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
 414         Update.
 415         * dwarf2/read.h (struct dwarf2_per_objfile)
 416         <quick_file_names_table>: Now htab_up.
 417
 418 2020-02-08  Tom Tromey  <tom@tromey.com>
 419
 420         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
 421
 422 2020-02-08  Tom Tromey  <tom@tromey.com>
 423
 424         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
 425         Rewrite.
 426         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
 427         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
 428         (abbrev_table::abbrev_table): No longer inline.
 429         (ABBREV_HASH_SIZE): Remove.
 430         (abbrev_table::m_abbrevs): Now an htab_up.
 431
 432 2020-02-08  Tom Tromey  <tom@tromey.com>
 433
 434         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
 435         (cutu_reader): Update.
 436         (build_type_psymtabs_1): Update.
 437         * dwarf2/abbrev.c (abbrev_table::read): Rename.
 438         (abbrev_table::alloc_abbrev): Update.
 439         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
 440         (abbrev_table::read): New static method, renamed from
 441         abbrev_table_read_table.
 442         (abbrev_table::alloc_abbrev)
 443         (abbrev_table::add_abbrev): Now private.
 444         (abbrev_table::abbrev_table): Now private.
 445         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
 446
 447 2020-02-08  Tom Tromey  <tom@tromey.com>
 448
 449         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
 450         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
 451         htab_up.
 452
 453 2020-02-08  Tom Tromey  <tom@tromey.com>
 454
 455         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
 456         htab_up.
 457         (lookup_dwo_unit_in_dwp): Update.
 458         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
 459         on obstack.
 460
 461 2020-02-08  Tom Tromey  <tom@tromey.com>
 462
 463         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
 464         obstack.
 465
 466 2020-02-08  Tom Tromey  <tom@tromey.com>
 467
 468         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
 469         line_header_hash.
 470         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
 471         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
 472         Change type to htab_up.
 473
 474 2020-02-08  Tom Tromey  <tom@tromey.com>
 475
 476         * dwarf2/read.c (allocate_type_unit_groups_table): Return
 477         htab_up.  Don't allocate on obstack.
 478         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
 479         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
 480         Change type to htab_up.
 481
 482 2020-02-08  Tom Tromey  <tom@tromey.com>
 483
 484         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
 485         Change type to htab_up.
 486         * dwarf2/read.c (create_signatured_type_table_from_index)
 487         (create_signatured_type_table_from_debug_names)
 488         (create_all_type_units, add_type_unit)
 489         (lookup_dwo_signatured_type, lookup_signatured_type)
 490         (process_skeletonless_type_unit): Update.
 491         (create_debug_type_hash_table, create_debug_types_hash_table):
 492         Change type of types_htab.
 493         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
 494         htab_up.  Don't allocate on obstack.
 495         (create_cus_hash_table): Change type of cus_htab parameter.
 496         (struct dwo_file) <cus, tus>: Now htab_up.
 497         (lookup_dwo_signatured_type, lookup_dwo_cutu)
 498         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
 499         (queue_and_load_all_dwo_tus): Update.
 500         * dwarf2/index-write.c (write_gdbindex): Update.
 501         (write_debug_names): Update.
 502
 503 2020-02-08  Tom Tromey  <tom@tromey.com>
 504
 505         * dwarf2/read.h (struct dwarf2_queue_item): Move from
 506         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
 507         destructor.
 508         (struct dwarf2_per_objfile) <queue>: New member.
 509         * dwarf2/read.c (struct dwarf2_queue_item): Move to
 510         dwarf2/read.h.
 511         (dwarf2_queue, dwarf2_queue_tail): Remove.
 512         (class dwarf2_queue_guard): Add parameter to constructor.  Use
 513         DISABLE_COPY_AND_ASSIGN.
 514         <m_per_objfile>: New member.
 515         <~dwarf2_queue_guard>: Rewrite.
 516         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
 517         Update.
 518         (~dwarf2_queue_item): New.
 519
 520 2020-02-08  Tom Tromey  <tom@tromey.com>
 521
 522         * dwarf2/read.c (struct die_info) <has_children>: New member.
 523         (dw2_get_file_names_reader): Remove has_children.
 524         (dw2_get_file_names): Update.
 525         (read_cutu_die_from_dwo): Remove has_children.
 526         (cutu_reader::init_tu_and_read_dwo_dies)
 527         (cutu_reader::cutu_reader): Update.
 528         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
 529         Remove has_children.
 530         (build_type_psymtabs_1, process_skeletonless_type_unit)
 531         (load_partial_comp_unit, load_full_comp_unit): Update.
 532         (create_dwo_cu_reader): Remove has_children.
 533         (create_cus_hash_table, read_die_and_children): Update.
 534         (read_full_die_1,read_full_die): Remove has_children.
 535         (read_signatured_type): Update.
 536         (class cutu_reader) <has_children>: Remove.
 537
 538 2020-02-08  Tom Tromey  <tom@tromey.com>
 539
 540         * dwarf2/expr.c: Rename from dwarf2expr.c.
 541         * dwarf2/expr.h: Rename from dwarf2expr.h.
 542         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
 543         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
 544         * dwarf2/frame.c: Rename from dwarf2-frame.c.
 545         * dwarf2/frame.h: Rename from dwarf2-frame.h.
 546         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
 547         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
 548         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
 549         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
 550         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
 551         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
 552         * dwarf2/loc.c: Rename from dwarf2loc.c.
 553         * dwarf2/loc.h: Rename from dwarf2loc.h.
 554         * dwarf2/read.c: Rename from dwarf2read.c.
 555         * dwarf2/read.h: Rename from dwarf2read.h.
 556         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
 557         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
 558         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
 559         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
 560         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
 561         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
 562         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
 563         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
 564         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
 565         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
 566         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
 567         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
 568         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
 569         Update.
 570         * Makefile.in (COMMON_SFILES): Update.
 571         (HFILES_NO_SRCDIR): Update.
 572
 573 2020-02-08  Tom Tromey  <tom@tromey.com>
 574
 575         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
 576         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
 577
 578 2020-02-08  Tom Tromey  <tom@tromey.com>
 579
 580         * dwarf2read.h (struct die_info): Don't declare.
 581
 582 2020-02-08  Tom Tromey  <tom@tromey.com>
 583
 584         * dwarf2read.h (die_info_ptr): Remove typedef.
 585
 586 2020-02-08  Tom Tromey  <tom@tromey.com>
 587
 588         * dwarf2read.c (read_call_site_scope)
 589         (handle_data_member_location, dwarf2_add_member_fn)
 590         (mark_common_block_symbol_computed, read_common_block)
 591         (attr_to_dynamic_prop, partial_die_info::read)
 592         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
 593         (dwarf2_symbol_mark_computed, set_die_type): Update.
 594         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
 595         method.
 596         (attr_form_is_block): Don't declare.
 597         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
 598
 599 2020-02-08  Tom Tromey  <tom@tromey.com>
 600
 601         * dwarf2read.c (dwarf2_find_base_address, )
 602         (read_call_site_scope, rust_containing_type)
 603         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
 604         (handle_data_member_location, dwarf2_add_member_fn)
 605         (get_alignment, read_structure_type, process_structure_scope)
 606         (mark_common_block_symbol_computed, read_common_block)
 607         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
 608         (partial_die_info::read, read_attribute_value, new_symbol)
 609         (lookup_die_type, dwarf2_get_ref_die_offset)
 610         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
 611         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
 612         (dwarf2_symbol_mark_computed): Update.
 613         * dwarf2/attribute.h (struct attribute) <value_as_address,
 614         form_is_section_offset, form_is_constant, form_is_ref>: Declare
 615         methods.
 616         (value_as_address, attr_form_is_section_offset)
 617         (attr_form_is_constant, attr_form_is_ref): Don't declare.
 618         * dwarf2/attribute.c (attribute::value_as_address)
 619         (attribute::form_is_section_offset, attribute::form_is_constant)
 620         (attribute::form_is_ref): Now methods.
 621
 622 2020-02-08  Tom Tromey  <tom@tromey.com>
 623
 624         * dwarf2read.c (struct attribute, DW_STRING)
 625         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
 626         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
 627         (attr_form_is_block, attr_form_is_section_offset)
 628         (attr_form_is_constant, attr_form_is_ref): Move.
 629         * dwarf2/attribute.h: New file.
 630         * dwarf2/attribute.c: New file, from dwarf2read.c.
 631         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
 632
 633 2020-02-08  Tom Tromey  <tom@tromey.com>
 634
 635         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
 636         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
 637         Move.
 638         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
 639         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
 640         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
 641         abbrev.c.
 642         * dwarf2/abbrev.h: New file.
 643         * dwarf2/abbrev.c: New file, from dwarf2read.c.
 644         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
 645
 646 2020-02-08  Tom Tromey  <tom@tromey.com>
 647
 648         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
 649         (dwarf2_section_size, dwarf2_get_section_info)
 650         (create_signatured_type_table_from_debug_names)
 651         (create_addrmap_from_aranges, read_debug_names_from_section)
 652         (get_gdb_index_contents_from_section, read_comp_unit_head)
 653         (error_check_comp_unit_head, read_abbrev_offset)
 654         (create_debug_type_hash_table, init_cu_die_reader)
 655         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
 656         (read_comp_units_from_section, create_cus_hash_table)
 657         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
 658         (create_dwp_v2_section, dwarf2_rnglists_process)
 659         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
 660         (abbrev_table_read_table, read_indirect_string_at_offset_from)
 661         (read_indirect_string_from_dwz, read_addr_index_1)
 662         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
 663         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 664         (fill_in_loclist_baton): Update.
 665         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
 666         get_containing_section, get_bfd_owner, get_bfd_section,
 667         get_file_name, get_id, get_flags, empty, read>: Declare methods.
 668         (dwarf2_read_section, get_section_name, get_section_file_name)
 669         (get_containing_section, get_section_bfd_owner)
 670         (get_section_bfd_section, get_section_name, get_section_file_name)
 671         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
 672         declare.
 673         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
 674         (dwarf2_section_info::get_bfd_owner)
 675         (dwarf2_section_info::get_bfd_section)
 676         (dwarf2_section_info::get_name)
 677         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
 678         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
 679         (dwarf2_section_info::read): Now methods.
 680         * dwarf-index-write.c (class debug_names): Update.
 681
 682 2020-02-08  Tom Tromey  <tom@tromey.com>
 683
 684         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
 685         Move to dwarf2/section.h.
 686         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
 687         (get_section_bfd_section, get_section_name)
 688         (get_section_file_name, get_section_id, get_section_flags)
 689         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
 690         dwarf2/section.c.
 691         * dwarf2/section.h: New file.
 692         * dwarf2/section.c: New file, from dwarf2read.c.
 693         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
 694
 695 2020-02-08  Tom Tromey  <tom@tromey.com>
 696
 697         * dwarf2read.h (read_unsigned_leb128): Don't declare.
 698         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
 699         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
 700         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
 701         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
 702         * dwarf2/leb.h: New file, from dwarf2read.c.
 703         * dwarf2/leb.c: New file, from dwarf2read.c.
 704         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
 705         Remove.
 706         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
 707         (COMMON_SFILES): Add dwarf2/leb.c.
 708
 709 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
 710
 711         GDB 9.1 released.
 712
 713 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 714
 715         PR gdb/25190:
 716         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
 717         * gdb/remote.c (remote_console_output): Update.
 718         * gdb/ui-file.c (fputs_unfiltered): Rename to...
 719         (ui_file_puts): ...this.
 720         * gdb/ui-file.h (ui_file_puts): Add declaration.
 721         * gdb/utils.c (emit_style_escape): Update.
 722         (flush_wrap_buffer): Update.
 723         (fputs_maybe_filtered): Update.
 724         (fputs_unfiltered): Add function.
 725
 726 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 727
 728         * gdb/event-loop.c (gdb_wait_for_event): Update.
 729         * gdb/printcmd.c (printf_command): Update.
 730         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
 731         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
 732         (gdb_os_flush_stderr): Update.
 733         * gdb/remote.c (remote_console_output): Update.
 734         * gdb/ui-file.c (gdb_flush): Rename to...
 735         (ui_file_flush): ...this.
 736         (stderr_file::write): Update.
 737         (stderr_file::puts): Update.
 738         * gdb/ui-file.h (gdb_flush): Rename to...
 739         (ui_file_flush): ...this.
 740         * gdb/utils.c (gdb_flush): Add function.
 741         * gdb/utils.h (gdb_flush): Add declaration.
 742
 743 2020-02-07  Tom Tromey  <tromey@adacore.com>
 744
 745         PR breakpoints/24915:
 746         * source.c (find_and_open_source): Do not check basenames_may_differ.
 747
 748 2020-02-07  Tom Tromey  <tom@tromey.com>
 749
 750         * README: Update gdbserver documentation.
 751         * gdbserver: Move to top level.
 752         * configure.tgt (build_gdbserver): Remove.
 753         * configure.ac: Remove --enable-gdbserver.
 754         * configure: Rebuild.
 755         * Makefile.in (distclean): Don't mention gdbserver.
 756
 757 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 758
 759         * source-cache.c (source_cache::ensure): Surround
 760         get_plain_source_lines with a try/catch.
 761         (source_cache::get_line_charpos): Get rid of try/catch
 762         and only check for the return value of "ensure".
 763         * tui/tui-source.c (tui_source_window::set_contents):
 764         Simplify "nlines" calculation.
 765
 766 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 767
 768         * MAINTAINERS (Write After Approval): Add myself.
 769
 770 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 771
 772         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
 773         function call.
 774
 775 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 776
 777         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
 778
 779 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
 780
 781         * nat/riscv-linux-tdesc.h: New file.
 782         * nat/riscv-linux-tdesc.c: New file, taking code from...
 783         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 784         ... here.
 785         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
 786         NATDEPFILES.
 787
 788 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
 791         we don't set the fake simulator ptid to the null_ptid.
 792
 793 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
 794
 795         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
 796         * gdbthread.h (class thread_info) <resumed>: Likewise.
 797         * infrun.c (resume_1): Likewise.
 798         (proceed): Likewise.
 799         (infrun_thread_stop_requested): Likewise.
 800         (stop_all_threads): Likewise.
 801         (handle_inferior_event): Likewise.
 802         (restart_threads): Likewise.
 803         (finish_step_over): Likewise.
 804         (keep_going_stepped_thread): Likewise.
 805         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
 806         (linux_handle_extended_wait): Likewise.
 807         * record-btrace.c (get_thread_current_frame_id): Likewise.
 808         * record-full.c (record_full_wait_1): Likewise.
 809         * remote.c (remote_target::process_initial_stop_replies): Likewise.
 810         * target.c (target_resume): Likewise.
 811         * thread.c (set_running_thread): Likewise.
 812
 813 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 814
 815         * f-valprint.c (f77_print_array_1): Changed datatype of index
 816         variable to LONGEST from int to enable it to contain bound
 817         values correctly.
 818
 819 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
 820
 821         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
 822         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
 823         offsets according to FLEN determined.
 824         (riscv_linux_nat_target::read_description): Determine FLEN
 825         dynamically.
 826         (riscv_linux_nat_target::fetch_registers): Size regset buffer
 827         according to FLEN determined.
 828         (riscv_linux_nat_target::store_registers): Likewise.
 829
 830 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 831
 832         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 833         when reg->group is empty and reggroup is not.
 834
 835 2020-01-31  Tom Tromey  <tromey@adacore.com>
 836
 837         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
 838         Call beneath target's mourn_inferior after unpushing.
 839
 840 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         PR tui/9765
 843         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
 844         have enough lines to fill the screen, still return the lowest
 845         address we found.
 846
 847 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
 850         '-', '<', and '>' commands.
 851
 852 2020-01-29  Pedro Alves  <palves@redhat.com>
 853             Sergio Durigan Junior  <sergiodj@redhat.com>
 854
 855         * infcmd.c (construct_inferior_arguments): Assert that
 856         'argc' is greater than 0.
 857
 858 2020-01-29  Luis Machado  <luis.machado@linaro.org>
 859
 860         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
 861         (BRK_INSN_MASK): Define to 0xd4200000.
 862         (aarch64_program_breakpoint_here_p): New function.
 863         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
 864         * arch-utils.c (default_program_breakpoint_here_p): Moved from
 865         breakpoint.c.
 866         * arch-utils.h (default_program_breakpoint_here_p): Moved from
 867         breakpoint.h
 868         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
 869         call gdbarch_program_breakpoint_here_p.
 870         (program_breakpoint_here): Moved to arch-utils.c, renamed to
 871         default_program_breakpoint_here_p, changed return type to bool and
 872         simplified.
 873         * breakpoint.h (program_breakpoint_here): Moved prototype to
 874         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
 875         return type to bool.
 876         * gdbarch.c: Regenerate.
 877         * gdbarch.h: Regenerate.
 878         * gdbarch.sh (program_breakpoint_here_p): New method.
 879         * infrun.c (handle_signal_stop): Call
 880         gdbarch_program_breakpoint_here_p.
 881
 882 2020-01-26  Tom Tromey  <tom@tromey.com>
 883
 884         * ctfread.c (struct ctf_fp_info): Reindent.
 885         (_initialize_ctfread): Remove.
 886
 887 2020-01-26  Tom Tromey  <tom@tromey.com>
 888
 889         * psymtab.c (partial_map_expand_apply)
 890         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
 891         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
 892         (psym_print_stats, psym_expand_symtabs_for_function)
 893         (psym_map_symbol_filenames, psym_map_matching_symbols)
 894         (psym_expand_symtabs_matching)
 895         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
 896         (maintenance_check_psymtabs): Use new methods.
 897         * psympriv.h (struct partial_symtab) <readin_p,
 898         get_compunit_symtab>: New methods.
 899         <readin, compunit_symtab>: Remove members.
 900         (struct standard_psymtab): New.
 901         (struct legacy_psymtab): Derive from standard_psymtab.
 902         * dwarf2read.h (struct dwarf2_psymtab): Derive from
 903         standard_psymtab.
 904         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
 905
 906 2020-01-26  Tom Tromey  <tom@tromey.com>
 907
 908         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
 909         read_dependencies.  Add assert.
 910         * psymtab.c (partial_symtab::read_dependencies): New method.
 911         * psympriv.h (struct partial_symtab) <read_dependencies>: New
 912         method.
 913         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
 914         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
 915         read_dependencies.
 916         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
 917         Add assert.
 918
 919 2020-01-26  Tom Tromey  <tom@tromey.com>
 920
 921         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
 922         Call expand_psymtab.
 923         (xcoff_read_symtab): Call expand_psymtab.
 924         (xcoff_start_psymtab, xcoff_end_psymtab): Set
 925         legacy_expand_psymtab.
 926         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
 927         method.
 928         (struct legacy_psymtab) <expand_psymtab>: Implement.
 929         <legacy_expand_psymtab>: New member.
 930         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
 931         (parse_partial_symbols): Set legacy_expand_psymtab.
 932         (psymtab_to_symtab_1): Change argument order.  Call
 933         expand_psymtab.
 934         (new_psymtab): Set legacy_expand_psymtab.
 935         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
 936         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
 937         expand_psymtab.
 938         (dwarf2_psymtab::expand_psymtab): Rename from
 939         psymtab_to_symtab_1.  Call expand_psymtab.
 940         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
 941         (dbx_end_psymtab): Likewise.
 942         (dbx_psymtab_to_symtab_1): Change argument order. Call
 943         expand_psymtab.
 944         (dbx_read_symtab): Call expand_psymtab.
 945         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
 946         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
 947         (ctf_psymtab::read_symtab): Call expand_psymtab.
 948
 949 2020-01-26  Tom Tromey  <tom@tromey.com>
 950
 951         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
 952         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
 953         messages.
 954         * mdebugread.c (mdebug_read_symtab): Remove prints.
 955         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
 956         assert.
 957         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
 958
 959 2020-01-26  Tom Tromey  <tom@tromey.com>
 960
 961         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
 962         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
 963         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
 964         legacy_symtab.
 965         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
 966         * psymtab.c (psymtab_to_symtab): Call method.
 967         (dump_psymtab): Update.
 968         * psympriv.h (struct partial_symtab): Add virtual destructor.
 969         <read_symtab>: New method.
 970         (struct legacy_symtab): New.
 971         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
 972         (struct pst_map) <pst>: Now a legacy_psymtab.
 973         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
 974         (new_psymtab): Use legacy_psymtab.
 975         * dwarf2read.h (struct dwarf2_psymtab): New.
 976         (struct dwarf2_per_cu_data) <psymtab>: Use it.
 977         * dwarf2read.c (dwarf2_create_include_psymtab)
 978         (dwarf2_build_include_psymtabs, create_type_unit_group)
 979         (create_partial_symtab, process_psymtab_comp_unit_reader)
 980         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
 981         (set_partial_user): Use dwarf2_psymtab.
 982         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
 983         (psymtab_to_symtab_1, process_full_comp_unit)
 984         (process_full_type_unit, dwarf2_ranges_read)
 985         (dwarf2_get_pc_bounds, psymtab_include_file_name)
 986         (dwarf_decode_lines): Use dwarf2_psymtab.
 987         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
 988         (add_address_entry_worker, write_one_signatured_type)
 989         (recursively_count_psymbols, recursively_write_psymbols)
 990         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
 991         (write_debug_names): Likewise.
 992         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
 993         <pst>: Now a legacy_psymtab.
 994         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
 995         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
 996         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
 997         * ctfread.c (struct ctf_psymtab): New.
 998         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
 999         ctf_psymtab.
1000         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
1001         (create_partial_symtab): Return a ctf_psymtab.
1002         (scan_partial_symbols): Update.
1003
1004 2020-01-26  Tom Tromey  <tom@tromey.com>
1005
1006         * xcoffread.c (xcoff_start_psymtab): Use new.
1007         * psymtab.c (partial_symtab::partial_symtab): New constructor,
1008         renamed from start_psymtab_common.
1009         * psympriv.h (struct partial_symtab): Add new constructor.
1010         (start_psymtab_common): Don't declare.
1011         * mdebugread.c (parse_partial_symbols): Use new.
1012         * dwarf2read.c (create_partial_symtab): Use new.
1013         * dbxread.c (start_psymtab): Use new.
1014         * ctfread.c (create_partial_symtab): Use new.
1015
1016 2020-01-26  Tom Tromey  <tom@tromey.com>
1017
1018         * xcoffread.c (xcoff_end_psymtab): Use new.
1019         * psymtab.c (start_psymtab_common): Use new.
1020         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
1021         Update.
1022         * psympriv.h (struct partial_symtab): Add parameters to
1023         constructor.  Don't inline.
1024         (allocate_psymtab): Don't declare.
1025         * mdebugread.c (new_psymtab): Use new.
1026         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
1027         * dbxread.c (dbx_end_psymtab): Use new.
1028
1029 2020-01-26  Tom Tromey  <tom@tromey.com>
1030
1031         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
1032         allocate_psymtab.  Update documentation.
1033         * psymtab.c (psymtab_storage::install_psymtab): Rename from
1034         allocate_psymtab.  Do not use new.
1035         (allocate_psymtab): Use new.  Update.
1036
1037 2020-01-26  Tom Tromey  <tom@tromey.com>
1038
1039         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1040         * psymtab.c (psym_print_stats): Update.
1041         * psympriv.h (struct partial_symtab) <readin,
1042         psymtabs_addrmap_supported, anonymous>: Now bool.
1043         * mdebugread.c (psymtab_to_symtab_1): Update.
1044         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
1045         (build_type_psymtabs_reader, psymtab_to_symtab_1)
1046         (process_full_comp_unit, process_full_type_unit): Update.
1047         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1048         * ctfread.c (psymtab_to_symtab): Update.
1049
1050 2020-01-26  Tom Tromey  <tom@tromey.com>
1051
1052         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
1053         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
1054         * psymtab.c (psymtab_storage): Delete psymtabs.
1055         (psymtab_storage::allocate_psymtab): Use new.
1056         (psymtab_storage::discard_psymtab): Use delete.
1057         * psympriv.h (struct partial_symtab): Add constructor and
1058         initializers.
1059
1060 2020-01-26  Tom Tromey  <tom@tromey.com>
1061
1062         * machoread.c: Do not include psympriv.h.
1063
1064 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1065
1066         * NEWS: Mention the new option and the set/show commands.
1067
1068 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1069
1070         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
1071         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
1072         (validate_exec_file): New variables, enums, functions.
1073         (exec_file_locate_attach, print_section_info): Style the filenames.
1074         (_initialize_exec): Install show_exec_file_mismatch_command and
1075          set_exec_file_mismatch_command.
1076         * gdbcore.h (validate_exec_file): Declare.
1077         * infcmd.c (attach_command): Call validate_exec_file.
1078         * remote.c ( remote_target::remote_add_inferior): Likewise.
1079
1080 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * frame.c (find_frame_sal): Move call to get_next_frame into more
1083         inner scope.
1084         * inline-frame.c (inilne_state) <inline_state>: Update argument
1085         types.
1086         (inilne_state) <skipped_symbol>: Rename to...
1087         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
1088         (skip_inline_frames): Build vector of skipped symbols and use this
1089         to reate the inline_state.
1090         (inline_skipped_symbol): Add a comment and some assertions, fetch
1091         skipped symbol from the list.
1092
1093 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * buildsym.c (lte_is_less_than): Delete.
1096         (buildsym_compunit::end_symtab_with_blockvector): Create local
1097         lambda function to sort line table entries, and use
1098         std::stable_sort instead of std::sort.
1099         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
1100         markers when looking for a previous line.
1101
1102 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * dwarf2read.c (lnp_state_machine::record_line): Include
1105         end_sequence parameter in debug print out.  Record the line if we
1106         are at an end_sequence marker even if it's not the start of a
1107         statement.
1108         * symmisc.c (maintenance_print_one_line_table): Print end of
1109         sequence markers with 'END' not '0'.
1110
1111 2020-01-24  Pedro Alves  <palves@redhat.com>
1112
1113         PR gdb/25410
1114         * thread.c (scoped_restore_current_thread::restore): Use
1115         switch_to_inferior_no_thread.
1116         * exec.c: Include "progspace-and-thread.h".
1117         (add_target_sections, remove_target_sections):
1118         scoped_restore_current_pspace_and_thread instead of
1119         scoped_restore_current_thread.
1120         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
1121         and aspace to the inferior before calling clone_program_space.
1122         Remove stale comment.
1123
1124 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1125
1126         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
1127         (arm_netbsd_nat_target::fetch_registers): ...this.
1128         (arm_nbsd_nat_target::store_registers): Rename to...
1129         (arm_netbsd_nat_target::store_registers): ...this.
1130
1131 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1132
1133         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1134         register_t.
1135
1136 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1137
1138         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
1139         Update comment.
1140         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
1141         Likewise.
1142         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
1143         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
1144         the correct replacement (iterate_over_regset_sections).
1145         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
1146         Update comment.
1147
1148 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
1149
1150         PR gdb/23718
1151         * gdb/python/python.c (execute_gdb_command): Call
1152         async_enable_stdin in catch block.
1153
1154 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
1157         SWITCH_THRU_ALL_UIS.
1158
1159 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         PR tui/9765
1162         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
1163         comment, add extra parameter, and update to store previous symbol
1164         when appropriate.
1165         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
1166         add extra parameter.
1167         * tui/tui-disasm.c (tui_disassemble): Update header comment,
1168         remove unneeded parameter, add try/catch around gdb_print_insn,
1169         rewrite to add items to asm_lines vector.
1170         (tui_find_backward_disassembly_start_address): New function.
1171         (tui_find_disassembly_address): Updated throughout.
1172         (tui_disasm_window::set_contents): Update for changes to
1173         tui_disassemble.
1174         (tui_disasm_window::do_scroll_vertical): No need to adjust the
1175         number of lines to scroll.
1176
1177 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
1178
1179         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
1180         (SECT_OFF_DATA): Likewise.
1181         (SECT_OFF_RODATA): Likewise.
1182         (SECT_OFF_TEXT): Likewise.
1183         (SECT_OFF_BSS): Likewise.
1184         (struct objfile) <text_section_offset, data_section_offset>: New
1185         methods.
1186         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
1187         objfile::text_section_offset.
1188         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
1189         * coffread.c (coff_symtab_read): Likewise.
1190         (enter_linenos): Likewise.
1191         (process_coff_symbol): Likewise.
1192         * ctfread.c (get_objfile_text_range): Likewise.
1193         * dtrace-probe.c (dtrace_probe::get_relocated_address):
1194         Use objfile::data_section_offset.
1195         * dwarf2-frame.c (execute_cfa_program): Use
1196         objfile::text_section_offset.
1197         (dwarf2_frame_find_fde): Likewise.
1198         * dwarf2read.c (create_addrmap_from_index): Likewise.
1199         (create_addrmap_from_aranges): Likewise.
1200         (dw2_find_pc_sect_compunit_symtab): Likewise.
1201         (process_psymtab_comp_unit_reader): Likewise.
1202         (add_partial_symbol): Likewise.
1203         (add_partial_subprogram): Likewise.
1204         (process_full_comp_unit): Likewise.
1205         (read_file_scope): Likewise.
1206         (read_func_scope): Likewise.
1207         (read_lexical_block_scope): Likewise.
1208         (read_call_site_scope): Likewise.
1209         (dwarf2_rnglists_process): Likewise.
1210         (dwarf2_ranges_process): Likewise.
1211         (dwarf2_ranges_read): Likewise.
1212         (dwarf_decode_lines_1): Likewise.
1213         (new_symbol): Likewise.
1214         (dwarf2_fetch_die_loc_sect_off): Likewise.
1215         (dwarf2_per_cu_text_offset): Likewise.
1216         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
1217         * hppa-tdep.c (read_unwind_info): Likewise.
1218         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
1219         * psympriv.h (struct partial_symtab): Likewise.
1220         * psymtab.c (find_pc_sect_psymtab): Likewise.
1221         * solib-svr4.c (enable_break): Likewise.
1222         * stap-probe.c (relocate_address): Use
1223         objfile::data_section_offset.
1224         * xcoffread.c (enter_line_range): Use
1225         objfile::text_section_offset.
1226         (read_xcoff_symtab): Likewise.
1227
1228 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1229
1230         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
1231         declaration to narrower scopes.
1232
1233 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1234
1235         * darwin-nat.h (struct darwin_exception_msg, enum
1236         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
1237         Move up.
1238         (class darwin_nat_target) <wait_1, check_new_threads,
1239         decode_exception_message, decode_message, stop_inferior,
1240         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
1241         * darwin-nat.c (darwin_check_new_threads): Rename to...
1242         (darwin_nat_target::check_new_threads): ... this.
1243         (darwin_suspend_inferior_it): Remove.
1244         (darwin_decode_exception_message): Rename to...
1245         (darwin_nat_target::decode_exception_message): ... this.
1246         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
1247         (darwin_decode_message): Rename to...
1248         (darwin_nat_target::decode_message): ... this.
1249         (cancel_breakpoint): Rename to...
1250         (darwin_nat_target::cancel_breakpoint): ... this.
1251         (darwin_wait): Rename to...
1252         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
1253         instead of iterate_over_inferiors.
1254         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
1255         (darwin_stop_inferior): Rename to...
1256         (darwin_nat_target::stop_inferior): ... this.
1257         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
1258         (darwin_init_thread_list): Rename to...
1259         (darwin_nat_target::init_thread_list): ... this.
1260         (darwin_ptrace_him): Rename to...
1261         (darwin_nat_target::ptrace_him): ... this.
1262         (darwin_nat_target::create_inferior): Pass lambda function to
1263         fork_inferior.
1264         (darwin_nat_target::detach): Call stop_inferior instead of
1265         darwin_stop_inferior.
1266         * fork-inferior.h (fork_inferior): Change init_trace_fun
1267         parameter to gdb::function_view.
1268         * fork-inferior.c (fork_inferior): Likewise.
1269
1270 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
1271
1272         * i386-cygwin-tdep.c (core_process_module_section): Update.
1273         * windows-nat.c (struct lm_info_windows): Add text_offset.
1274         (windows_xfer_shared_libraries): Update.
1275         * windows-tdep.c (windows_xfer_shared_library):
1276         Add text_offset_cached argument.
1277         * windows-tdep.h (windows_xfer_shared_library): Update.
1278
1279 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * gdbarch.sh: Add declaration for _initialize_gdbarch.
1282
1283 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1284
1285         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
1286         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
1287         replace with range-based for.
1288         (gdbsim_interrupt_inferior): Remove.
1289         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
1290         with a range-based for.  Inline code from
1291         gdbsim_interrupt_inferior.
1292
1293 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1294
1295         * infrun.c (proceed): Fix indentation.
1296
1297 2020-01-21  Tom Tromey  <tromey@adacore.com>
1298
1299         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
1300         * python/python.c (python_extension_ops): Update.
1301         (gdbpy_colorize): New function.
1302         * python/lib/gdb/__init__.py (colorize): New function.
1303         * extension.h (ext_lang_colorize): Declare.
1304         * extension.c (ext_lang_colorize): New function.
1305         * extension-priv.h (struct extension_language_ops) <colorize>: New
1306         member.
1307         * cli/cli-style.c (_initialize_cli_style): Update help text.
1308
1309 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1310
1311         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
1312         <cond>: Change type to bool.
1313         (aarch64_displaced_step_b_cond): Update cond to use bool type.
1314         (aarch64_displaced_step_cb): Likewise.
1315         (aarch64_displaced_step_tb): Likewise.
1316
1317 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1318
1319         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
1320         output.
1321
1322 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1323
1324         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
1325         <pc_adjust>: Adjust the documentation.
1326         (aarch64_displaced_step_fixup): Check if PC really moved before
1327         adjusting it.
1328
1329 2020-01-19  Tom Tromey  <tom@tromey.com>
1330
1331         * disasm.c (~gdb_disassembler): New destructor.
1332         (gdb_buffered_insn_length): Call disassemble_free_target.
1333         * disasm.h (class gdb_disassembler): Declare destructor.  Use
1334         DISABLE_COPY_AND_ASSIGN.
1335
1336 2020-01-19  Tom Tromey  <tom@tromey.com>
1337
1338         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
1339         (die_reader_func_ftype): Remove.
1340         (cutu_reader): New class.
1341         (dw2_get_file_names_reader): Remove "data" parameter.
1342         (dw2_get_file_names): Use cutu_reader.
1343         (create_debug_type_hash_table): Update.
1344         (read_cutu_die_from_dwo): Update comment.
1345         (lookup_dwo_unit): Add dwo_name parameter.
1346         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
1347         die_reader_func_ftype and data parameters.
1348         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
1349         Remove die_reader_func_ftype and data parameters.
1350         (~cutu_reader): New; from init_cutu_and_read_dies.
1351         (cutu_reader::cutu_reader): Rename from
1352         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
1353         and data parameters.
1354         (init_cutu_and_read_dies_simple): Remove.
1355         (struct process_psymtab_comp_unit_data): Remove.
1356         (process_psymtab_comp_unit_reader): Remove data parameter; add
1357         want_partial_unit and pretend_language parameters.
1358         (process_psymtab_comp_unit): Use cutu_reader.
1359         (build_type_psymtabs_reader): Remove data parameter.
1360         (build_type_psymtabs_1): Use cutu_reader.
1361         (process_skeletonless_type_unit): Likewise.
1362         (load_partial_comp_unit_reader): Remove.
1363         (load_partial_comp_unit): Use cutu_reader.
1364         (load_full_comp_unit_reader): Remove.
1365         (load_full_comp_unit): Use cutu_reader.
1366         (struct create_dwo_cu_data): Remove.
1367         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
1368         dwo_unit parameters.
1369         (create_cus_hash_table): Use cutu_reader.
1370         (struct dwarf2_read_addr_index_data): Remove.
1371         (dwarf2_read_addr_index_reader): Remove.
1372         (dwarf2_read_addr_index): Use cutu_reader.
1373         (read_signatured_type_reader): Remove.
1374         (read_signatured_type): Use cutu_reader.
1375
1376 2020-01-19  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
1379         * tui/tui-wingeneral.h (class tui_suppress_output): New.
1380         (tui_wrefresh): Declare.
1381         * tui/tui-wingeneral.c (suppress_output): New global.
1382         (tui_suppress_output, ~tui_suppress_output): New constructor and
1383         destructor.
1384         (tui_wrefresh): New function.
1385         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
1386         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
1387         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
1388         method.
1389         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
1390         tui_wrefresh.
1391         (tui_data_window::no_refresh): New method.
1392         (tui_data_item_window::refresh_window): Call tui_wrefresh.
1393         (tui_reg_command): Use tui_suppress_output
1394         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
1395         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
1396         method.
1397         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
1398
1399 2020-01-19  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-winsource.c (tui_update_source_windows_with_line):
1402         Handle case where symtab is null.
1403
1404 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
1405
1406         * linux-fork.c (one_fork_p): Simplify.
1407
1408 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1409
1410         * top.c (struct qt_args): Remove.
1411         (kill_or_detach): Change return type to void, replace `void *`
1412         parameter with a proper one.
1413         (print_inferior_quit_action):  Likewise.
1414         (quit_confirm): Use range-based for loop to iterate over inferiors.
1415         (quit_force): Likewise.
1416
1417 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1418
1419         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
1420         `void *` parameter with proper parameters.
1421         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
1422         (print_one_inferior): Change return type to void, replace `void *`
1423         parameter with proper parameters.
1424         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
1425         inferiors.
1426         (get_other_inferior): Remove.
1427         (mi_cmd_remove_inferior): Use range-based loop to iterate over
1428         inferiors.
1429
1430 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1431
1432         * mi/mi-interp.c (report_initial_inferior): Remove.
1433         (mi_interp::init): Use range-based for to iterate over inferiors.
1434
1435 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1436
1437         * python/py-inferior.c (build_inferior_list): Remove.
1438         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
1439
1440 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
1441
1442         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
1443         (btrace_stitch_trace): Likewise.
1444         * charset.c (intermediate_encoding): Likewise (vaild).
1445         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
1446         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
1447         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
1448
1449 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
1450
1451         * windows-tdep.c (windows_get_tlb_type):
1452         Add rtl_user_process_parameters type.
1453
1454 2020-01-16  Pedro Alves  <palves@redhat.com>
1455             Norbert Lange  <nolange79@gmail.com>
1456
1457         PR build/24805
1458         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
1459         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
1460         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
1461         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
1462         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
1463         (ps_plog): Redeclare exported functions with default visibility.
1464
1465 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
1466
1467         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
1468         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
1469
1470 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
1471
1472         * infcmd.c (post_create_inferior): Use get_thread_regcache
1473         instead of get_current_regcache.
1474
1475 2020-01-14  Tom Tromey  <tom@tromey.com>
1476
1477         PR symtab/12535:
1478         * python/python.c (gdbpy_decode_line): Treat empty string the same
1479         as no argument.
1480
1481 2020-01-14  Tom Tromey  <tom@tromey.com>
1482
1483         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
1484
1485 2020-01-14  Tom Tromey  <tom@tromey.com>
1486
1487         * nat/linux-btrace.c: Don't include <config.h>.
1488         * nat/linux-ptrace.c: Don't include <config.h>.
1489         * nat/x86-linux-dregs.c: Don't include <config.h>.
1490
1491 2020-01-14  Tom Tromey  <tom@tromey.com>
1492
1493         * configure: Rebuild.
1494         * configure.ac: Move many checks to ../gdbsupport/common.m4.
1495
1496 2020-01-14  Tom Tromey  <tom@tromey.com>
1497
1498         * nat/x86-linux-dregs.c: Include configh.h.
1499         * nat/linux-ptrace.c: Include configh.h.
1500         * nat/linux-btrace.c: Include configh.h.
1501         * defs.h: Include config.h, bfd.h.
1502         * configure.ac: Don't source common.host.
1503         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
1504         * configure: Rebuild.
1505         * acinclude.m4: Update path.
1506         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
1507         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
1508         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
1509         (CLIBS): Add LIBSUPPORT.
1510         (CDEPS): Likewise.
1511         (COMMON_SFILES): Remove gdbsupport files.
1512         (HFILES_NO_SRCDIR): Likewise.
1513         (stamp-version): Update path to create-version.sh.
1514         (ALLDEPFILES): Remove gdbsupport files.
1515
1516 2020-01-14  Tom Tromey  <tom@tromey.com>
1517
1518         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
1519         USE_WIN32API when needed.
1520         * configure.ac (USE_WIN32API): Don't define.
1521         (WIN32LIBS): Use WIN32APILIBS.
1522         * configure: Rebuild.
1523
1524 2020-01-14  Tom Tromey  <tom@tromey.com>
1525
1526         * configure: Rebuild.
1527         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
1528
1529 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1530
1531         * skip.c (skip_function_command): Make skip w/o arguments use the
1532         name of the inlined function if pc is inside any inlined function.
1533
1534 2020-01-14  Luis Machado  <luis.machado@linaro.org>
1535
1536         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
1537         * infrun.c (resume_1): Likewise.
1538         (handle_inferior_event): Remove stale comment.
1539         * linux-nat.c (linux_nat_target::resume): Update comments.
1540         (save_stop_reason): Likewise.
1541         (linux_nat_filter_event): Likewise.
1542         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
1543
1544 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * elfread.c (record_minimal_symbol): Set section index to 0 for
1547         non-allocatable sections.
1548
1549
1550 2020-01-13  Ali Tamur <tamur@google.com>
1551
1552         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
1553         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
1554         to gdb::optional.  Update comments.
1555         (dwo_file): Update comments.
1556         (read_attribute): Update API to take an additional out parameter,
1557         need_reprocess.  This is used to mark attributes that need other
1558         attributes (e.g. str_offsets_base) for correct computation which may not
1559         have been read yet.
1560         (read_attribute_reprocess): New function declaration.
1561         (read_addr_index): Likewise.
1562         (read_dwo_str_index): Likewise.
1563         (read_stub_str_index): Likewise.
1564         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
1565         (lookup_addr_base): New function definition.
1566         (lookup_ranges_base): Likewise.
1567         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
1568         lookup_ranges_base.
1569         (init_cutu_and_read_dies): Update comments.
1570         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
1571         unit.  This is used to inherit parent's str_offsets_base and addr_base.
1572         Update comments.
1573         (init_cutu_and_read_dies_simple): Reflect API changes.
1574         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
1575         (create_cus_hash_table): Change API to take parent compile unit.
1576         Reflect API changes.
1577         (open_and_init_dwo_file): Reflect API changes.
1578         (dwarf2_get_pc_bounds): Update comments.
1579         (dwarf2_record_block_ranges): Likewise.
1580         (read_full_die_1): Change implementation to reprocess attributes that
1581         need str_offsets_base and addr_base.
1582         (partial_die_info::read): Likewise.
1583         (read_attribute_reprocess): New function definition.
1584         (read_attribute_value): Change API to take an additional out parameter,
1585         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
1586         when a non-dwo compile unit has index based attributes.
1587         (read_attribute): Reflect API changes.
1588         (read_addr_index_1): Reflect API changes.  Update comments.
1589         (dwarf2_read_addr_index_data): Reflect API changes.
1590         (dwarf2_read_addr_index): Likewise.
1591         (read_str_index): Change API and implementation.  This becomes a helper
1592         to be used by the new string index related methods.  Update error
1593         message and comments.
1594         (read_dwo_str_index): New function definition.
1595         (read_stub_str_index): Likewise.
1596         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
1597         * symfile.h (dwarf2_debug_sections): Likewise.
1598         * xcoffread.c (dwarf2_debug_sections): Likewise.
1599
1600 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1601
1602         * gdbcore.h (struct core_fns) <core_read_registers>: Change
1603         core_reg_sect type to gdb_byte *.
1604         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
1605         * cris-tdep.c (fetch_core_registers): Likewise.
1606         * corelow.c (core_target::get_core_register_section): Change
1607         type of `contents` to gdb::byte_vector.
1608
1609 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1610
1611         * tui/tui-wingeneral.c (box_win): Position the title in the center
1612         of the border.
1613
1614 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
1615
1616         * corelow.c (core_target::get_core_register_section): Use
1617           std::vector instead of alloca.
1618
1619 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1620
1621         * warning.m4: Add -Wmissing-declarations to build_warnings.
1622         * configure: Re-generate.
1623
1624 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1625
1626         * python/python.c (init__gdb_module): Add declaration.
1627
1628 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1629
1630         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
1631         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
1632         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
1633         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
1634         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
1635         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
1636         * ada-exp.y (_initialize_ada_exp): Add declaration.
1637         * ada-lang.c (_initialize_ada_language): Add declaration.
1638         * ada-tasks.c (_initialize_tasks): Add declaration.
1639         * agent.c (_initialize_agent): Add declaration.
1640         * aix-thread.c (_initialize_aix_thread): Add declaration.
1641         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
1642         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
1643         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
1644         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
1645         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
1646         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
1647         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
1648         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
1649         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
1650         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
1651         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
1652         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
1653         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
1654         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
1655         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
1656         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
1657         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
1658         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
1659         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
1660         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
1661         * annotate.c (_initialize_annotate): Add declaration.
1662         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
1663         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
1664         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
1665         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
1666         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
1667         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
1668         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
1669         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
1670         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
1671         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
1672         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
1673         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
1674         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
1675         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
1676         * auto-load.c (_initialize_auto_load): Add declaration.
1677         * auxv.c (_initialize_auxv): Add declaration.
1678         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
1679         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
1680         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
1681         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
1682         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
1683         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
1684         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
1685         * breakpoint.c (_initialize_breakpoint): Add declaration.
1686         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
1687         * btrace.c (_initialize_btrace): Add declaration.
1688         * charset.c (_initialize_charset): Add declaration.
1689         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
1690         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
1691         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
1692         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
1693         * cli/cli-script.c (_initialize_cli_script): Add declaration.
1694         * cli/cli-style.c (_initialize_cli_style): Add declaration.
1695         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
1696         * coffread.c (_initialize_coffread): Add declaration.
1697         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
1698         * compile/compile.c (_initialize_compile): Add declaration.
1699         * complaints.c (_initialize_complaints): Add declaration.
1700         * completer.c (_initialize_completer): Add declaration.
1701         * copying.c (_initialize_copying): Add declaration.
1702         * corefile.c (_initialize_core): Add declaration.
1703         * corelow.c (_initialize_corelow): Add declaration.
1704         * cp-abi.c (_initialize_cp_abi): Add declaration.
1705         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
1706         * cp-support.c (_initialize_cp_support): Add declaration.
1707         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
1708         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
1709         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
1710         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
1711         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
1712         * ctfread.c (_initialize_ctfread): Add declaration.
1713         * d-lang.c (_initialize_d_language): Add declaration.
1714         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
1715         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
1716         * dbxread.c (_initialize_dbxread): Add declaration.
1717         * dcache.c (_initialize_dcache): Add declaration.
1718         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
1719         * disasm.c (_initialize_disasm): Add declaration.
1720         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
1721         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
1722         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
1723         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
1724         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
1725         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
1726         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
1727         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
1728         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
1729         * elfread.c (_initialize_elfread): Add declaration.
1730         * exec.c (_initialize_exec): Add declaration.
1731         * extension.c (_initialize_extension): Add declaration.
1732         * f-lang.c (_initialize_f_language): Add declaration.
1733         * f-valprint.c (_initialize_f_valprint): Add declaration.
1734         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
1735         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
1736         * filesystem.c (_initialize_filesystem): Add declaration.
1737         * findcmd.c (_initialize_mem_search): Add declaration.
1738         * findvar.c (_initialize_findvar): Add declaration.
1739         * fork-child.c (_initialize_fork_child): Add declaration.
1740         * frame-base.c (_initialize_frame_base): Add declaration.
1741         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
1742         * frame.c (_initialize_frame): Add declaration.
1743         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
1744         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
1745         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
1746         * gcore.c (_initialize_gcore): Add declaration.
1747         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
1748         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
1749         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
1750         * gdbarch.c (_initialize_gdbarch): Add declaration.
1751         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
1752         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
1753         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
1754         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
1755         * go-lang.c (_initialize_go_language): Add declaration.
1756         * go32-nat.c (_initialize_go32_nat): Add declaration.
1757         * guile/guile.c (_initialize_guile): Add declaration.
1758         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
1759         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
1760         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
1761         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
1762         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
1763         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
1764         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
1765         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
1766         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
1767         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
1768         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
1769         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
1770         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
1771         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
1772         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
1773         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
1774         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
1775         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
1776         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
1777         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
1778         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
1779         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
1780         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
1781         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
1782         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
1783         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
1784         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
1785         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
1786         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
1787         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
1788         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
1789         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
1790         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
1791         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
1792         * infcall.c (_initialize_infcall): Add declaration.
1793         * infcmd.c (_initialize_infcmd): Add declaration.
1794         * inflow.c (_initialize_inflow): Add declaration.
1795         * infrun.c (_initialize_infrun): Add declaration.
1796         * interps.c (_initialize_interpreter): Add declaration.
1797         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
1798         * jit.c (_initialize_jit): Add declaration.
1799         * language.c (_initialize_language): Add declaration.
1800         * linux-fork.c (_initialize_linux_fork): Add declaration.
1801         * linux-nat.c (_initialize_linux_nat): Add declaration.
1802         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
1803         * linux-thread-db.c (_initialize_thread_db): Add declaration.
1804         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
1805         * m2-lang.c (_initialize_m2_language): Add declaration.
1806         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
1807         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
1808         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
1809         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
1810         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
1811         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
1812         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
1813         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
1814         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
1815         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
1816         * machoread.c (_initialize_machoread): Add declaration.
1817         * macrocmd.c (_initialize_macrocmd): Add declaration.
1818         * macroscope.c (_initialize_macroscope): Add declaration.
1819         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
1820         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
1821         * maint.c (_initialize_maint_cmds): Add declaration.
1822         * mdebugread.c (_initialize_mdebugread): Add declaration.
1823         * memattr.c (_initialize_mem): Add declaration.
1824         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
1825         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
1826         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
1827         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
1828         * mi/mi-main.c (_initialize_mi_main): Add declaration.
1829         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
1830         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
1831         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
1832         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
1833         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
1834         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
1835         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
1836         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
1837         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
1838         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
1839         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
1840         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
1841         * mipsread.c (_initialize_mipsread): Add declaration.
1842         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
1843         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
1844         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
1845         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
1846         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
1847         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
1848         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
1849         * nto-procfs.c (_initialize_procfs): Add declaration.
1850         * objc-lang.c (_initialize_objc_language): Add declaration.
1851         * observable.c (_initialize_observer): Add declaration.
1852         * opencl-lang.c (_initialize_opencl_language): Add declaration.
1853         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
1854         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
1855         * osabi.c (_initialize_gdb_osabi): Add declaration.
1856         * osdata.c (_initialize_osdata): Add declaration.
1857         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
1858         * parse.c (_initialize_parse): Add declaration.
1859         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
1860         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
1861         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
1862         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
1863         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
1864         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
1865         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
1866         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
1867         * printcmd.c (_initialize_printcmd): Add declaration.
1868         * probe.c (_initialize_probe): Add declaration.
1869         * proc-api.c (_initialize_proc_api): Add declaration.
1870         * proc-events.c (_initialize_proc_events): Add declaration.
1871         * proc-service.c (_initialize_proc_service): Add declaration.
1872         * procfs.c (_initialize_procfs): Add declaration.
1873         * producer.c (_initialize_producer): Add declaration.
1874         * psymtab.c (_initialize_psymtab): Add declaration.
1875         * python/python.c (_initialize_python): Add declaration.
1876         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
1877         * record-btrace.c (_initialize_record_btrace): Add declaration.
1878         * record-full.c (_initialize_record_full): Add declaration.
1879         * record.c (_initialize_record): Add declaration.
1880         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
1881         * regcache.c (_initialize_regcache): Add declaration.
1882         * reggroups.c (_initialize_reggroup): Add declaration.
1883         * remote-notif.c (_initialize_notif): Add declaration.
1884         * remote-sim.c (_initialize_remote_sim): Add declaration.
1885         * remote.c (_initialize_remote): Add declaration.
1886         * reverse.c (_initialize_reverse): Add declaration.
1887         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
1888         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
1889         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
1890         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
1891         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
1892         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
1893         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
1894         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
1895         Add declaration.
1896         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
1897         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
1898         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
1899         * rust-exp.y (_initialize_rust_exp): Add declaration.
1900         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
1901         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
1902         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
1903         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
1904         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
1905         * score-tdep.c (_initialize_score_tdep): Add declaration.
1906         * ser-go32.c (_initialize_ser_dos): Add declaration.
1907         * ser-mingw.c (_initialize_ser_windows): Add declaration.
1908         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
1909         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
1910         * ser-uds.c (_initialize_ser_socket): Add declaration.
1911         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
1912         * serial.c (_initialize_serial): Add declaration.
1913         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
1914         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
1915         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
1916         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
1917         * skip.c (_initialize_step_skip): Add declaration.
1918         * sol-thread.c (_initialize_sol_thread): Add declaration.
1919         * solib-aix.c (_initialize_solib_aix): Add declaration.
1920         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
1921         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
1922         * solib-frv.c (_initialize_frv_solib): Add declaration.
1923         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
1924         * solib-target.c (_initialize_solib_target): Add declaration.
1925         * solib.c (_initialize_solib): Add declaration.
1926         * source-cache.c (_initialize_source_cache): Add declaration.
1927         * source.c (_initialize_source): Add declaration.
1928         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
1929         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
1930         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
1931         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
1932         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
1933         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
1934         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
1935         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
1936         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
1937         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
1938         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
1939         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
1940         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
1941         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
1942         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
1943         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
1944         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
1945         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
1946         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
1947         * stabsread.c (_initialize_stabsread): Add declaration.
1948         * stack.c (_initialize_stack): Add declaration.
1949         * stap-probe.c (_initialize_stap_probe): Add declaration.
1950         * std-regs.c (_initialize_frame_reg): Add declaration.
1951         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
1952         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
1953         * symfile.c (_initialize_symfile): Add declaration.
1954         * symmisc.c (_initialize_symmisc): Add declaration.
1955         * symtab.c (_initialize_symtab): Add declaration.
1956         * target.c (_initialize_target): Add declaration.
1957         * target-connection.c (_initialize_target_connection): Add
1958         declaration.
1959         * target-dcache.c (_initialize_target_dcache): Add declaration.
1960         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
1961         * thread.c (_initialize_thread): Add declaration.
1962         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
1963         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
1964         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
1965         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
1966         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
1967         * tracectf.c (_initialize_ctf): Add declaration.
1968         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
1969         * tracefile.c (_initialize_tracefile): Add declaration.
1970         * tracepoint.c (_initialize_tracepoint): Add declaration.
1971         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
1972         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
1973         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
1974         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
1975         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
1976         * tui/tui-win.c (_initialize_tui_win): Add declaration.
1977         * tui/tui.c (_initialize_tui): Add declaration.
1978         * typeprint.c (_initialize_typeprint): Add declaration.
1979         * ui-style.c (_initialize_ui_style): Add declaration.
1980         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
1981         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
1982         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
1983         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
1984         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
1985         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
1986         * unittests/filtered_iterator-selftests.c
1987         (_initialize_filtered_iterator_selftests): Add declaration.
1988         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
1989         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
1990         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
1991         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
1992         * unittests/main-thread-selftests.c
1993         (_initialize_main_thread_selftests): Add declaration.
1994         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
1995         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
1996         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
1997         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
1998         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
1999         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
2000         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
2001         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
2002         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
2003         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
2004         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
2005         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
2006         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
2007         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
2008         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
2009         declaration.
2010         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
2011         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
2012         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
2013         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
2014         * user-regs.c (_initialize_user_regs): Add declaration.
2015         * utils.c (_initialize_utils): Add declaration.
2016         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
2017         * valops.c (_initialize_valops): Add declaration.
2018         * valprint.c (_initialize_valprint): Add declaration.
2019         * value.c (_initialize_values): Add declaration.
2020         * varobj.c (_initialize_varobj): Add declaration.
2021         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
2022         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
2023         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
2024         * windows-nat.c (_initialize_windows_nat): Add declaration.
2025         (_initialize_check_for_gdb_ini): Add declaration.
2026         (_initialize_loadable): Add declaration.
2027         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
2028         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
2029         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
2030         * xcoffread.c (_initialize_xcoffread): Add declaration.
2031         * xml-support.c (_initialize_xml_support): Add declaration.
2032         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
2033         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
2034         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
2035         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
2036
2037 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2038
2039         * regformats/regdat.sh: Generate declaration for init function.
2040
2041 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2042
2043         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
2044         up.
2045         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
2046         close_one_inferior>: New methods.
2047         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
2048         pass down target to find_inferior_pid.
2049         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
2050         Pass down target to find_inferior_ptid.
2051         (gdbsim_target::create_inferior): Pass down target to
2052         add_thread_silent.
2053         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
2054         target down to find_inferior_ptid and switch_to_thread.
2055         (gdbsim_target::close): Update to call close_one_inferior.
2056         (struct resume_data): Remove.
2057         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
2058         directly, rather than through a void pointer.
2059         (gdbsim_target::resume): Update to call resume_one_inferior.
2060
2061 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
2062
2063         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
2064
2065 2020-01-12  Pedro Alves  <palves@redhat.com>
2066
2067         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
2068         directly for the current inferior instead of
2069         discard_all_inferiors.
2070         (discard_all_inferiors): Delete.
2071
2072 2020-01-11  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-wingeneral.c (box_win): Check cli_styling.
2075         * tui/tui-winsource.c (tui_source_window_base::refill): Use
2076         deprecated_safe_get_selected_frame.
2077
2078 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2079
2080         * inferior.c (print_inferior): Switch inferior before printing it.
2081
2082 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
2083             Pedro Alves  <palves@redhat.com>
2084
2085         * progspace-and-thread.c (switch_to_program_space_and_thread):
2086         Assert there's an inferior for PSPACE.  Use
2087         switch_to_inferior_no_thread to switch the inferior too.
2088         * progspace.c (program_space::~program_space): Call
2089         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
2090         (program_space::free_all_objfiles): Don't call clear_symtab_users
2091         here.
2092         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
2093
2094 2020-01-10  Pedro Alves  <palves@redhat.com>
2095
2096         * NEWS: Mention multi-target debugging, "info connections", and
2097         "add-inferior -no-connection".
2098
2099 2020-01-10  Pedro Alves  <palves@redhat.com>
2100
2101         * infrun.c: Include "target-connection.h".
2102         (check_multi_target_resumption): New.
2103         (proceed): Call it.
2104         * target-connection.c (make_target_connection_string): Make
2105         extern.
2106         * target-connection.h (make_target_connection_string): Declare.
2107
2108 2020-01-10  Pedro Alves  <palves@redhat.com>
2109
2110         * Makefile.in (COMMON_SFILES): Add target-connection.c.
2111         * inferior.c (uiout_field_connection): New function.
2112         (print_inferior): Add new "connection-id" column.
2113         (add_inferior_command): Show connection number/string of added
2114         inferior.
2115         * process-stratum-target.h
2116         (process_stratum_target::connection_string): New virtual method.
2117         (process_stratum_target::connection_number): New field.
2118         * remote.c (remote_target::connection_string): New override.
2119         * target-connection.c: New file.
2120         * target-connection.h: New file.
2121         * target.c (decref_target): Remove process_stratum targets from
2122         the connection list.
2123         (target_stack::push): Add process_stratum targets to the
2124         connection list.
2125
2126 2020-01-10  Pedro Alves  <palves@redhat.com>
2127
2128         Revert:
2129         2016-04-12  Pedro Alves  <palves@redhat.com>
2130         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
2131         Remove references to name.
2132         * serial.h (struct serial) <name>: Delete.
2133
2134 2020-01-10  Pedro Alves  <palves@redhat.com>
2135
2136         * gdbarch-selftests.c (register_to_value_test): Remove "target
2137         already pushed" check.
2138
2139 2020-01-10  Pedro Alves  <palves@redhat.com>
2140             John Baldwin  <jhb@FreeBSD.org>
2141
2142         * aarch64-linux-nat.c
2143         (aarch64_linux_nat_target::thread_architecture): Adjust.
2144         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
2145         (task_command_1): Likewise.
2146         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
2147         (aix_thread_target::wait, aix_thread_target::fetch_registers)
2148         (aix_thread_target::store_registers)
2149         (aix_thread_target::thread_alive): Adjust.
2150         * amd64-fbsd-tdep.c: Include "inferior.h".
2151         (amd64fbsd_get_thread_local_address): Pass down target.
2152         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
2153         thread's gdbarch instead of target_gdbarch.
2154         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
2155         get_last_target_status.
2156         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
2157         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
2158         inferiors.
2159         (update_inserted_breakpoint_locations): Skip if inferiors with no
2160         execution.
2161         (update_global_location_list): When handling moribund locations,
2162         find representative inferior for location's pspace, and use thread
2163         count of its process_stratum target.
2164         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
2165         * bsd-uthread.c (bsd_uthread_target::wait): Use
2166         as_process_stratum_target and adjust thread_change_ptid and
2167         add_thread calls.
2168         (bsd_uthread_target::update_thread_list): Use
2169         as_process_stratum_target and adjust find_thread_ptid,
2170         thread_change_ptid and add_thread calls.
2171         * btrace.c (maint_btrace_packet_history_cmd): Adjust
2172         find_thread_ptid call.
2173         * corelow.c (add_to_thread_list): Adjust add_thread call.
2174         (core_target_open): Adjust add_thread_silent and thread_count
2175         calls.
2176         (core_target::pid_to_str): Adjust find_inferior_ptid call.
2177         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
2178         * event-top.c (async_disconnect): Pop targets from all inferiors.
2179         * exec.c (add_target_sections): Push exec target on all inferiors
2180         sharing the program space.
2181         (remove_target_sections): Remove the exec target from all
2182         inferiors sharing the program space.
2183         (exec_on_vfork): New.
2184         * exec.h (exec_on_vfork): Declare.
2185         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
2186         Pass it down.
2187         (fbsd_nat_target::update_thread_list): Adjust.
2188         (fbsd_nat_target::resume): Adjust.
2189         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
2190         down.
2191         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
2192         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
2193         get_thread_arch_regcache call.
2194         * fork-child.c (gdb_startup_inferior): Pass target down to
2195         startup_inferior and set_executing.
2196         * gdbthread.h (struct process_stratum_target): Forward declare.
2197         (add_thread, add_thread_silent, add_thread_with_info)
2198         (in_thread_list): Add process_stratum_target parameter.
2199         (find_thread_ptid(inferior*, ptid_t)): New overload.
2200         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
2201         parameter.
2202         (all_threads()): Delete overload.
2203         (all_threads, all_non_exited_threads): Add process_stratum_target
2204         parameter.
2205         (all_threads_safe): Use brace initialization.
2206         (thread_count): Add process_stratum_target parameter.
2207         (set_resumed, set_running, set_stop_requested, set_executing)
2208         (threads_are_executing, finish_thread_state): Add
2209         process_stratum_target parameter.
2210         (switch_to_thread): Use is_current_thread.
2211         * i386-fbsd-tdep.c: Include "inferior.h".
2212         (i386fbsd_get_thread_local_address): Pass down target.
2213         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
2214         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
2215         have_inferiors check.
2216         * inf-ptrace.c (inf_ptrace_target::create_inferior)
2217         (inf_ptrace_target::attach): Adjust.
2218         * infcall.c (run_inferior_call): Adjust.
2219         * infcmd.c (run_command_1): Pass target to
2220         scoped_finish_thread_state.
2221         (proceed_thread_callback): Skip inferiors with no execution.
2222         (continue_command): Rename 'all_threads' local to avoid hiding
2223         'all_threads' function.  Adjust get_last_target_status call.
2224         (prepare_one_step): Adjust set_running call.
2225         (signal_command): Use user_visible_resume_target.  Compare thread
2226         pointers instead of inferior_ptid.
2227         (info_program_command): Adjust to pass down target.
2228         (attach_command): Mark target's 'thread_executing' flag.
2229         (stop_current_target_threads_ns): New, factored out from ...
2230         (interrupt_target_1): ... this.  Switch inferior before making
2231         target calls.
2232         * inferior-iter.h
2233         (struct all_inferiors_iterator, struct all_inferiors_range)
2234         (struct all_inferiors_safe_range)
2235         (struct all_non_exited_inferiors_range): Filter on
2236         process_stratum_target too.  Remove explicit.
2237         * inferior.c (inferior::inferior): Push dummy target on target
2238         stack.
2239         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
2240         Add process_stratum_target parameter, and pass it down.
2241         (have_live_inferiors): Adjust.
2242         (switch_to_inferior_and_push_target): New.
2243         (add_inferior_command, clone_inferior_command): Handle
2244         "-no-connection" parameter.  Use
2245         switch_to_inferior_and_push_target.
2246         (_initialize_inferior): Mention "-no-connection" option in
2247         the help of "add-inferior" and "clone-inferior" commands.
2248         * inferior.h: Include "process-stratum-target.h".
2249         (interrupt_target_1): Use bool.
2250         (struct inferior) <push_target, unpush_target, target_is_pushed,
2251         find_target_beneath, top_target, process_target, target_at,
2252         m_stack>: New.
2253         (discard_all_inferiors): Delete.
2254         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
2255         (all_inferiors, all_non_exited_inferiors): Add
2256         process_stratum_target parameter.
2257         * infrun.c: Include "gdb_select.h" and <unordered_map>.
2258         (target_last_proc_target): New global.
2259         (follow_fork_inferior): Push target on new inferior.  Pass target
2260         to add_thread_silent.  Call exec_on_vfork.  Handle target's
2261         reference count.
2262         (follow_fork): Adjust get_last_target_status call.  Also consider
2263         target.
2264         (follow_exec): Push target on new inferior.
2265         (struct execution_control_state) <target>: New field.
2266         (user_visible_resume_target): New.
2267         (do_target_resume): Call target_async.
2268         (resume_1): Set target's threads_executing flag.  Consider resume
2269         target.
2270         (commit_resume_all_targets): New.
2271         (proceed): Also consider resume target.  Skip threads of inferiors
2272         with no execution.  Commit resumtion in all targets.
2273         (start_remote): Pass current inferior to wait_for_inferior.
2274         (infrun_thread_stop_requested): Consider target as well.  Pass
2275         thread_info pointer to clear_inline_frame_state instead of ptid.
2276         (infrun_thread_thread_exit): Consider target as well.
2277         (random_pending_event_thread): New inferior parameter.  Use it.
2278         (do_target_wait): Rename to ...
2279         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
2280         down.
2281         (threads_are_resumed_pending_p, do_target_wait): New.
2282         (prepare_for_detach): Adjust calls.
2283         (wait_for_inferior): New inferior parameter.  Handle it.  Use
2284         do_target_wait_1 instead of do_target_wait.
2285         (fetch_inferior_event): Adjust.  Switch to representative
2286         inferior.  Pass target down.
2287         (set_last_target_status): Add process_stratum_target parameter.
2288         Save target in global.
2289         (get_last_target_status): Add process_stratum_target parameter and
2290         handle it.
2291         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
2292         (context_switch): Check inferior_ptid == null_ptid before calling
2293         inferior_thread().
2294         (get_inferior_stop_soon): Pass down target.
2295         (wait_one): Rename to ...
2296         (poll_one_curr_target): ... this.
2297         (struct wait_one_event): New.
2298         (wait_one): New.
2299         (stop_all_threads): Adjust.
2300         (handle_no_resumed, handle_inferior_event): Adjust to consider the
2301         event's target.
2302         (switch_back_to_stepped_thread): Also consider target.
2303         (print_stop_event): Update.
2304         (normal_stop): Update.  Also consider the resume target.
2305         * infrun.h (wait_for_inferior): Remove declaration.
2306         (user_visible_resume_target): New declaration.
2307         (get_last_target_status, set_last_target_status): New
2308         process_stratum_target parameter.
2309         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2310         process_stratum_target parameter, and use it.
2311         (clear_inline_frame_state (thread_info*)): New.
2312         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2313         process_stratum_target parameter.
2314         (clear_inline_frame_state (thread_info*)): Declare.
2315         * linux-fork.c (delete_checkpoint_command): Pass target down to
2316         find_thread_ptid.
2317         (checkpoint_command): Adjust.
2318         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
2319         instead of just tweaking inferior_ptid.
2320         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
2321         (exit_lwp): Pass target down to find_thread_ptid.
2322         (attach_proc_task_lwp_callback): Pass target down to
2323         add_thread/set_running/set_executing.
2324         (linux_nat_target::attach): Pass target down to
2325         thread_change_ptid.
2326         (get_detach_signal): Pass target down to find_thread_ptid.
2327         Consider last target status's target.
2328         (linux_resume_one_lwp_throw, resume_lwp)
2329         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
2330         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
2331         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
2332         (linux_nat_target::async_wait_fd): New.
2333         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
2334         target down.
2335         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
2336         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
2337         * linux-thread-db.c (struct thread_db_info::process_target): New
2338         field.
2339         (add_thread_db_info): Save target.
2340         (get_thread_db_info): New process_stratum_target parameter.  Also
2341         match target.
2342         (delete_thread_db_info): New process_stratum_target parameter.
2343         Also match target.
2344         (thread_from_lwp): Adjust to pass down target.
2345         (thread_db_notice_clone): Pass down target.
2346         (check_thread_db_callback): Pass down target.
2347         (try_thread_db_load_1): Always push the thread_db target.
2348         (try_thread_db_load, record_thread): Pass target down.
2349         (thread_db_target::detach): Pass target down.  Always unpush the
2350         thread_db target.
2351         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
2352         target down.  Always unpush the thread_db target.
2353         (find_new_threads_callback, thread_db_find_new_threads_2)
2354         (thread_db_target::update_thread_list): Pass target down.
2355         (thread_db_target::pid_to_str): Pass current inferior down.
2356         (thread_db_target::get_thread_local_address): Pass target down.
2357         (thread_db_target::resume, maintenance_check_libthread_db): Pass
2358         target down.
2359         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
2360         * procfs.c (procfs_target::procfs_init_inferior): Declare.
2361         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
2362         (procfs_init_inferior): Rename to ...
2363         (procfs_target::procfs_init_inferior): ... this and adjust.
2364         (procfs_target::create_inferior, procfs_notice_thread)
2365         (procfs_do_thread_registers): Adjust.
2366         * ppc-fbsd-tdep.c: Include "inferior.h".
2367         (ppcfbsd_get_thread_local_address): Pass down target.
2368         * proc-service.c (ps_xfer_memory): Switch current inferior and
2369         program space as well.
2370         (get_ps_regcache): Pass target down.
2371         * process-stratum-target.c
2372         (process_stratum_target::thread_address_space)
2373         (process_stratum_target::thread_architecture): Pass target down.
2374         * process-stratum-target.h
2375         (process_stratum_target::threads_executing): New field.
2376         (as_process_stratum_target): New.
2377         * ravenscar-thread.c
2378         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
2379         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
2380         down.
2381         * record-btrace.c (record_btrace_target::info_record): Adjust.
2382         (record_btrace_target::record_method)
2383         (record_btrace_target::record_is_replaying)
2384         (record_btrace_target::fetch_registers)
2385         (get_thread_current_frame_id, record_btrace_target::resume)
2386         (record_btrace_target::wait, record_btrace_target::stop): Pass
2387         target down.
2388         * record-full.c (record_full_wait_1): Switch to event thread.
2389         Pass target down.
2390         * regcache.c (regcache::regcache)
2391         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
2392         process_stratum_target parameter and handle it.
2393         (current_thread_target): New global.
2394         (get_thread_regcache): Add process_stratum_target parameter and
2395         handle it.  Switch inferior before calling target method.
2396         (get_thread_regcache): Pass target down.
2397         (get_thread_regcache_for_ptid): Pass target down.
2398         (registers_changed_ptid): Add process_stratum_target parameter and
2399         handle it.
2400         (registers_changed_thread, registers_changed): Pass target down.
2401         (test_get_thread_arch_aspace_regcache): New.
2402         (current_regcache_test): Define a couple local test_target_ops
2403         instances and use them for testing.
2404         (readwrite_regcache): Pass process_stratum_target parameter.
2405         (cooked_read_test, cooked_write_test): Pass mock_target down.
2406         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
2407         (get_thread_arch_aspace_regcache): Add process_stratum_target
2408         parameter.
2409         (regcache::target): New method.
2410         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
2411         (regcache::registers_changed_ptid): Add process_stratum_target
2412         parameter.
2413         (regcache::m_target): New field.
2414         (registers_changed_ptid): Add process_stratum_target parameter.
2415         * remote.c (remote_state::supports_vCont_probed): New field.
2416         (remote_target::async_wait_fd): New method.
2417         (remote_unpush_and_throw): Add remote_target parameter.
2418         (get_current_remote_target): Adjust.
2419         (remote_target::remote_add_inferior): Push target.
2420         (remote_target::remote_add_thread)
2421         (remote_target::remote_notice_new_inferior)
2422         (get_remote_thread_info): Pass target down.
2423         (remote_target::update_thread_list): Skip threads of inferiors
2424         bound to other targets.  (remote_target::close): Don't discard
2425         inferiors.  (remote_target::add_current_inferior_and_thread)
2426         (remote_target::process_initial_stop_replies)
2427         (remote_target::start_remote)
2428         (remote_target::remote_serial_quit_handler): Pass down target.
2429         (remote_target::remote_unpush_target): New remote_target
2430         parameter.  Unpush the target from all inferiors.
2431         (remote_target::remote_unpush_and_throw): New remote_target
2432         parameter.  Pass it down.
2433         (remote_target::open_1): Check whether the current inferior has
2434         execution instead of checking whether any inferior is live.  Pass
2435         target down.
2436         (remote_target::remote_detach_1): Pass down target.  Use
2437         remote_unpush_target.
2438         (extended_remote_target::attach): Pass down target.
2439         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
2440         (remote_target::append_resumption): Pass down target.
2441         (remote_target::append_pending_thread_resumptions)
2442         (remote_target::remote_resume_with_hc, remote_target::resume)
2443         (remote_target::commit_resume): Pass down target.
2444         (remote_target::remote_stop_ns): Check supports_vCont_probed.
2445         (remote_target::interrupt_query)
2446         (remote_target::remove_new_fork_children)
2447         (remote_target::check_pending_events_prevent_wildcard_vcont)
2448         (remote_target::remote_parse_stop_reply)
2449         (remote_target::process_stop_reply): Pass down target.
2450         (first_remote_resumed_thread): New remote_target parameter.  Pass
2451         it down.
2452         (remote_target::wait_as): Pass down target.
2453         (unpush_and_perror): New remote_target parameter.  Pass it down.
2454         (remote_target::readchar, remote_target::remote_serial_write)
2455         (remote_target::getpkt_or_notif_sane_1)
2456         (remote_target::kill_new_fork_children, remote_target::kill): Pass
2457         down target.
2458         (remote_target::mourn_inferior): Pass down target.  Use
2459         remote_unpush_target.
2460         (remote_target::core_of_thread)
2461         (remote_target::remote_btrace_maybe_reopen): Pass down target.
2462         (remote_target::pid_to_exec_file)
2463         (remote_target::thread_handle_to_thread_info): Pass down target.
2464         (remote_target::async_wait_fd): New.
2465         * riscv-fbsd-tdep.c: Include "inferior.h".
2466         (riscv_fbsd_get_thread_local_address): Pass down target.
2467         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
2468         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
2469         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
2470         Adjust.
2471         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
2472         * solib-svr4.c (enable_break): Pass down target.
2473         * spu-multiarch.c (parse_spufs_run): Pass down target.
2474         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
2475         * target-delegates.c: Regenerate.
2476         * target.c (g_target_stack): Delete.
2477         (current_top_target): Return the current inferior's top target.
2478         (target_has_execution_1): Refer to the passed-in inferior's top
2479         target.
2480         (target_supports_terminal_ours): Check whether the initial
2481         inferior was already created.
2482         (decref_target): New.
2483         (target_stack::push): Incref/decref the target.
2484         (push_target, push_target, unpush_target): Adjust.
2485         (target_stack::unpush): Defref target.
2486         (target_is_pushed): Return bool.  Adjust to refer to the current
2487         inferior's target stack.
2488         (dispose_inferior): Delete, and inline parts ...
2489         (target_preopen): ... here.  Only dispose of the current inferior.
2490         (target_detach): Hold strong target reference while detaching.
2491         Pass target down.
2492         (target_thread_name): Add assertion.
2493         (target_resume): Pass down target.
2494         (target_ops::beneath, find_target_at): Adjust to refer to the
2495         current inferior's target stack.
2496         (get_dummy_target): New.
2497         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
2498         has a thread running.
2499         (initialize_targets): Rename to ...
2500         (_initialize_target): ... this.
2501         * target.h: Include "gdbsupport/refcounted-object.h".
2502         (struct target_ops): Inherit refcounted_object.
2503         (target_ops::shortname, target_ops::longname): Make const.
2504         (target_ops::async_wait_fd): New method.
2505         (decref_target): Declare.
2506         (struct target_ops_ref_policy): New.
2507         (target_ops_ref): New typedef.
2508         (get_dummy_target): Declare function.
2509         (target_is_pushed): Return bool.
2510         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
2511         (all_matching_threads_iterator::all_matching_threads_iterator):
2512         Handle filter target.
2513         * thread-iter.h (struct all_matching_threads_iterator, struct
2514         all_matching_threads_range, class all_non_exited_threads_range):
2515         Filter by target too.  Remove explicit.
2516         * thread.c (threads_executing): Delete.
2517         (inferior_thread): Pass down current inferior.
2518         (clear_thread_inferior_resources): Pass down thread pointer
2519         instead of ptid_t.
2520         (add_thread_silent, add_thread_with_info, add_thread): Add
2521         process_stratum_target parameter.  Use it for thread and inferior
2522         searches.
2523         (is_current_thread): New.
2524         (thread_info::deletable): Use it.
2525         (find_thread_ptid, thread_count, in_thread_list)
2526         (thread_change_ptid, set_resumed, set_running): New
2527         process_stratum_target parameter.  Pass it down.
2528         (set_executing): New process_stratum_target parameter.  Pass it
2529         down.  Adjust reference to 'threads_executing'.
2530         (threads_are_executing): New process_stratum_target parameter.
2531         Adjust reference to 'threads_executing'.
2532         (set_stop_requested, finish_thread_state): New
2533         process_stratum_target parameter.  Pass it down.
2534         (switch_to_thread): Also match inferior.
2535         (switch_to_thread): New process_stratum_target parameter.  Pass it
2536         down.
2537         (update_threads_executing): Reimplement.
2538         * top.c (quit_force): Pop targets from all inferior.
2539         (gdb_init): Don't call initialize_targets.
2540         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
2541         Declare.
2542         (windows_add_thread, windows_delete_thread): Adjust.
2543         (get_windows_debug_event): Rename to ...
2544         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
2545         * tracefile-tfile.c (tfile_target_open): Pass down target.
2546         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
2547         Forward declare.
2548         (switch_to_thread): Add process_stratum_target parameter.
2549         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
2550         parameter.  Use it.
2551         (mi_on_resume): Pass target down.
2552         * nat/fork-inferior.c (startup_inferior): Add
2553         process_stratum_target parameter.  Pass it down.
2554         * nat/fork-inferior.h (startup_inferior): Add
2555         process_stratum_target parameter.
2556         * python/py-threadevent.c (py_get_event_thread): Pass target down.
2557
2558 2020-01-10  Pedro Alves  <palves@redhat.com>
2559
2560         * remote.c (remote_target::start_remote): Don't set inferior_ptid
2561         directly.  Instead find the first thread in the thread list and
2562         use switch_to_thread.
2563
2564 2020-01-10  Pedro Alves  <palves@redhat.com>
2565
2566         * remote.c (remote_target::remote_add_inferior): Don't bind a
2567         process to the current inferior if the current inferior is already
2568         bound to a process.
2569
2570 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2571             Pedro Alves  <palves@redhat.com>
2572
2573         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
2574         If no process is specified, return null_ptid instead of
2575         inferior_ptid.
2576         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
2577         TARGET_WAITKIND_SIGNALLED with no pid.
2578
2579 2020-01-10  Pedro Alves  <palves@redhat.com>
2580
2581         * remote.c (first_remote_resumed_thread): New.
2582         (remote_target::wait_as): Use it as default event_ptid instead of
2583         inferior_ptid.
2584
2585 2020-01-10  Pedro Alves  <palves@redhat.com>
2586
2587         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
2588
2589 2020-01-10  Pedro Alves  <palves@redhat.com>
2590
2591         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
2592         not -1.
2593
2594 2020-01-10  Pedro Alves  <palves@redhat.com>
2595
2596         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
2597         ptid to get_last_target_status.
2598         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
2599         ptid to get_last_target_status.
2600         * infcmd.c (continue_command): Don't pass a target_waitstatus to
2601         get_last_target_status.
2602         (info_program_command): Don't pass a target_waitstatus to
2603         get_last_target_status.
2604         * infrun.c (init_wait_for_inferior): Use
2605         nullify_last_target_wait_ptid.
2606         (get_last_target_status): Handle nullptr arguments.
2607         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
2608         (print_stop_event): Don't pass a ptid to get_last_target_status.
2609         (normal_stop): Don't pass a ptid to get_last_target_status.
2610         * infrun.h (get_last_target_status, set_last_target_status): Move
2611         comments here and update.
2612         (nullify_last_target_wait_ptid): Declare.
2613         * linux-fork.c (fork_load_infrun_state): Remove local extern
2614         declaration of nullify_last_target_wait_ptid.
2615         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
2616         to get_last_target_status.
2617
2618 2020-01-10  Pedro Alves  <palves@redhat.com>
2619
2620         * gdbthread.h (scoped_restore_current_thread)
2621         <dont_restore, restore, m_dont_restore>: Declare.
2622         * thread.c (thread_alive): Add assertion.  Return bool.
2623         (switch_to_thread_if_alive): New.
2624         (prune_threads): Switch inferior/thread.
2625         (print_thread_info_1): Switch thread before calling target methods.
2626         (scoped_restore_current_thread::restore): New, factored out from
2627         ...
2628         (scoped_restore_current_thread::~scoped_restore_current_thread):
2629         ... this.
2630         (scoped_restore_current_thread::scoped_restore_current_thread):
2631         Add assertion.
2632         (thread_apply_all_command, thread_select): Use
2633         switch_to_thread_if_alive.
2634         * infrun.c (proceed, restart_threads, handle_signal_stop)
2635         (switch_back_to_stepped_thread): Switch current thread before
2636         calling target methods.
2637
2638 2020-01-10  Pedro Alves <palves@redhat.com>
2639
2640         * inferior.c (switch_to_inferior_no_thread): New function,
2641         factored out from ...
2642         (inferior_command): ... here.
2643         * inferior.h (switch_to_inferior_no_thread): Declare.
2644         * mi/mi-main.c (run_one_inferior): Use
2645         switch_to_inferior_no_thread.
2646
2647 2020-01-10  Pedro Alves  <palves@redhat.com>
2648
2649         * infcmd.c (kill_command): Remove dead code.
2650
2651 2020-01-10  Pedro Alves  <palves@redhat.com>
2652
2653         * remote.c (remote_target::mourn_inferior): No longer check
2654         whether the target is running.
2655
2656 2020-01-10  Pedro Alves  <palves@redhat.com>
2657
2658         * corelow.c (core_target::has_execution): Change parameter type to
2659         inferior pointer.
2660         * inferior.c (number_of_live_inferiors): Use
2661         inferior::has_execution instead of target_has_execution_1.
2662         * inferior.h (inferior::has_execution): New.
2663         * linux-thread-db.c (thread_db_target::update_thread_list): Use
2664         inferior::has_execution instead of target_has_execution_1.
2665         * process-stratum-target.c
2666         (process_stratum_target::has_execution): Change parameter type to
2667         inferior pointer.  Check the inferior's PID instead of
2668         inferior_ptid.
2669         * process-stratum-target.h
2670         (process_stratum_target::has_execution): Change parameter type to
2671         inferior pointer.
2672         * record-full.c (record_full_core_target::has_execution): Change
2673         parameter type to inferior pointer.
2674         * target.c (target_has_execution_1): Change parameter type to
2675         inferior pointer.
2676         (target_has_execution_current): Adjust.
2677         * target.h (target_ops::has_execution): Change parameter type to
2678         inferior pointer.
2679         (target_has_execution_1): Change parameter type to inferior
2680         pointer.  Change return type to bool.
2681         * tracefile.h (tracefile_target::has_execution): Change parameter
2682         type to inferior pointer.
2683
2684 2020-01-10  Pedro Alves  <palves@redhat.com>
2685
2686         * exceptions.c (print_flush): Remove current_top_target() check.
2687
2688 2020-01-10  Pedro Alves  <palves@redhat.com>
2689
2690         * remote.c (show_remote_exec_file): Show the current inferior's
2691         exec-file instead of the command variable's value.
2692
2693 2020-01-10  Pedro Alves  <palves@redhat.com>
2694
2695         * record-full.c (record_full_resume_ptid): New global.
2696         (record_full_target::resume): Set it.
2697         (record_full_wait_1): Use record_full_resume_ptid instead of
2698         inferior_ptid.
2699
2700 2020-01-10  Pedro Alves  <palves@redhat.com>
2701
2702         * gdbthread.h (scoped_restore_current_thread)
2703         <dont_restore, restore, m_dont_restore>: Declare.
2704         * thread.c (thread_alive): Add assertion.  Return bool.
2705         (switch_to_thread_if_alive): New.
2706         (prune_threads): Switch inferior/thread.
2707         (print_thread_info_1): Switch thread before calling target methods.
2708         (scoped_restore_current_thread::restore): New, factored out from
2709         ...
2710         (scoped_restore_current_thread::~scoped_restore_current_thread):
2711         ... this.
2712         (scoped_restore_current_thread::scoped_restore_current_thread):
2713         Add assertion.
2714         (thread_apply_all_command, thread_select): Use
2715         switch_to_thread_if_alive.
2716
2717 2020-01-10  George Barrett  <bob@bob131.so>
2718
2719         * stap-probe.c (stap_modify_semaphore): Don't check for null
2720         semaphores.
2721         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
2722         for null semaphores.
2723
2724 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
2727         all source windows, and maintain horizontal scroll status while
2728         doing so.
2729
2730 2020-01-09  Tom Tromey  <tom@tromey.com>
2731
2732         PR tui/18932:
2733         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
2734         update_source_window, not print_source_lines.
2735
2736 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * tui/tui.c (tui_enable): Register tui hooks after calling
2739         tui_display_main.
2740
2741 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2742
2743         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
2744
2745 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
2746
2747         * thread.c (print_thread_info_1): Fix indentation.
2748
2749 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2750
2751         * symtab.c (general_symbol_info::compute_and_set_names): Move the
2752         unique_xmalloc_ptr outside the if to always free the demangled name.
2753
2754 2020-01-08  Tom Tromey  <tromey@adacore.com>
2755
2756         * xcoffread.c (enter_line_range, read_xcoff_symtab)
2757         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
2758         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
2759         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
2760         Remove.
2761         (section_offsets): New typedef.
2762         * symtab.c (fixup_section, get_msymbol_address): Update.
2763         * symmisc.c (dump_msymbols): Update.
2764         * symfile.h (relative_addr_info_to_section_offsets)
2765         (symfile_map_offsets_to_segments): Update.
2766         * symfile.c (build_section_addr_info_from_objfile)
2767         (init_objfile_sect_indices): Update.
2768         (struct place_section_arg): Change type of "offsets".
2769         (place_section): Update.
2770         (relative_addr_info_to_section_offsets): Change type of
2771         "section_offsets".  Remove "num_sections" parameter.
2772         (default_symfile_offsets, syms_from_objfile_1)
2773         (set_objfile_default_section_offset): Update.
2774         (reread_symbols): No need to preserve section offsets by hand.
2775         (symfile_map_offsets_to_segments): Change type of "offsets".
2776         * stap-probe.c (relocate_address): Update.
2777         * stabsread.h (process_one_symbol): Update.
2778         * solib-target.c (struct lm_info_target) <offsets>: Change type.
2779         (solib_target_relocate_section_addresses): Update.
2780         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
2781         Update.
2782         * solib-frv.c (frv_relocate_main_executable): Update.
2783         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
2784         * solib-aix.c (solib_aix_get_section_offsets): Change return
2785         type.
2786         (solib_aix_solib_create_inferior_hook): Update.
2787         * remote.c (remote_target::get_offsets): Update.
2788         * psymtab.c (find_pc_sect_psymtab): Update.
2789         * psympriv.h (struct partial_symbol) <address, text_low,
2790         text_high>: Update.
2791         * objfiles.h (obj_section_offset): Update.
2792         (struct objfile) <section_offsets>: Change type.
2793         <num_sections>: Remove.
2794         (objfile_relocate): Update.
2795         * objfiles.c (entry_point_address_query): Update
2796         (relocate_one_symbol): Change type of "section_offsets".
2797         (objfile_relocate1, objfile_relocate1): Change type of
2798         "new_offsets".
2799         (objfile_rebase1): Update.
2800         * mipsread.c (mipscoff_symfile_read): Update.
2801         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
2802         parameter.
2803         * mdebugread.c (parse_symbol): Change type of "section_offsets".
2804         (parse_external, psymtab_to_symtab_1): Update.
2805         * machoread.c (macho_symfile_offsets): Update.
2806         * ia64-tdep.c (ia64_find_unwind_table): Update.
2807         * hppa-tdep.c (read_unwind_info): Update.
2808         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
2809         * dwarf2read.c (create_addrmap_from_index)
2810         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2811         (process_psymtab_comp_unit_reader, add_partial_symbol)
2812         (add_partial_subprogram, process_full_comp_unit)
2813         (read_file_scope, read_func_scope, read_lexical_block_scope)
2814         (read_call_site_scope, dwarf2_rnglists_process)
2815         (dwarf2_ranges_process, dwarf2_ranges_read)
2816         (dwarf_decode_lines_1, var_decode_location, new_symbol)
2817         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
2818         Update.
2819         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
2820         Update.
2821         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
2822         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
2823         (process_one_symbol): Change type of "section_offsets".
2824         * ctfread.c (get_objfile_text_range): Update.
2825         * coffread.c (coff_symtab_read, enter_linenos)
2826         (process_coff_symbol): Update.
2827         * coff-pe-read.c (add_pe_forwarded_sym): Update.
2828         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
2829
2830 2020-01-08  Tom Tromey  <tromey@adacore.com>
2831
2832         * dwarf2read.c (parse_macro_definition): Use std::string.
2833         (parse_macro_definition): Likewise.
2834
2835 2020-01-08  Tom Tromey  <tromey@adacore.com>
2836
2837         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
2838         (ATTR_ALLOC_CHUNK): Remove.
2839
2840 2020-01-08  Tom Tromey  <tromey@adacore.com>
2841
2842         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
2843
2844 2020-01-08  Tom Tromey  <tromey@adacore.com>
2845
2846         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
2847         (dwarf2_compute_name, open_dwo_file): Likewise.
2848         (process_enumeration_scope): Use std::vector.
2849         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
2850         (partial_die_info::fixup, dwarf2_start_subfile)
2851         (guess_full_die_structure_name, dwarf2_name): Likewise.
2852         (determine_prefix): Update.
2853         (guess_full_die_structure_name): Make return type const.
2854         (partial_die_full_name): Return unique_xmalloc_ptr.
2855         (DW_FIELD_ALLOC_CHUNK): Remove.
2856
2857 2020-01-07  Tom Tromey  <tromey@adacore.com>
2858
2859         PR build/24937:
2860         * stap-probe.c (class stap_static_probe_ops): Add constructor.
2861
2862 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2863
2864         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
2865
2866 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * stack.c (print_frame_info): Move disassemble_next_line code
2869         inside source_print block.
2870
2871 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2872
2873         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
2874         gdb/signals.h, as we are now using native signal symbols.
2875
2876 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2877
2878         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
2879         overflow by an early check of content vs threshold.
2880         * tui/tui-source.c (tui_source_window::line_is_displayed):
2881         Likewise.
2882
2883 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2884
2885         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
2886
2887 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2888
2889         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
2890         export table if no section contains it's RVA.
2891
2892 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2893
2894         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
2895
2896 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
2897
2898         * source.c (print_source_lines_base): Set last_line_listed.
2899
2900 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2901
2902         * tui/tui-disasm.c: Remove trailing spaces.
2903
2904 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2905             Pedro Alves  <palves@redhat.com>
2906
2907         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
2908         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
2909         (windows_gdb_signal_to_target): New function, uses the above
2910         enumeration to convert GDB internal signal codes to equivalent
2911         Windows codes.
2912         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
2913         * windows-nat.c: Include "gdb_wait.h".
2914         (get_windows_debug_event): Extract the fatal exception from the
2915         exit status and convert to the equivalent Posix signal number.
2916         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
2917         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
2918         * gdbsupport/gdb_wait.c: New file, implements
2919         windows_status_to_termsig.
2920         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
2921         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
2922
2923 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
2926         show_layout.
2927
2928 2020-01-05  Luis Machado  <luis.machado@linaro.org>
2929
2930         * aarch64-linux-nat.c
2931         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
2932         and bfd_mach_aarch64.
2933
2934 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935
2936         * ui-file.c (stdio_file::can_emit_style_escape)
2937         (tee_file::can_emit_style_escape): Ensure style is used also on
2938         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
2939         to gdb_stdout.
2940         * main.c (set_gdb_data_directory): Use file style to output the
2941         warning that the given pathname is not a directory.
2942         * top.c (show_history_filename, gdb_safe_append_history)
2943         (show_gdb_datadir): Use file style.
2944
2945 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2946
2947         * solib-target.c (struct lm_info_target):
2948         Change offsets to be a unique_xmalloc_ptr.
2949         (solib_target_relocate_section_addresses): Update.
2950
2951 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2952
2953         * windows-nat.c (windows_clear_solib): Free so_list linked list.
2954
2955 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2956
2957         * MAINTAINERS (Write After Approval): Add myself.
2958
2959 2020-01-02  Luis Machado  <luis.machado@linaro.org>
2960
2961         * proc-service.c (get_ps_regcache): Remove reference to obsolete
2962         Cell BE architecture.
2963         * target.h (struct target_ops) <thread_architecture>: Likewise.
2964
2965 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
2966
2967         * Makefile.in: Use INSTALL_PROGRAM_ENV.
2968
2969 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
2970
2971         * MAINTAINERS (Write After Approval): Add myself.
2972
2973 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2974
2975         * gdbarch.sh: Update copyright year range of generated files.
2976
2977 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2978
2979         Update copyright year range in all GDB files.
2980
2981 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2982
2983         * copyright.py: Convert to Python 3.
2984
2985 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2986
2987         * copyright.py: Adapt after move of gnulib directory from gdb
2988         directory to toplevel directory.
2989
2990 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2991
2992         * copyright.py (main): Exit if run from the wrong directory.
2993
2994 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2995
2996         * top.c (print_gdb_version): Change copyright year to 2020.
2997
2998 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
2999
3000         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
3001
3002 For older changes see ChangeLog-2019.
3003 \f
3004 Local Variables:
3005 mode: change-log
3006 left-margin: 8
3007 fill-column: 74
3008 version-control: never
3009 coding: utf-8
3010 End: