gdb/ChangeLog

   1 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
   4         * unittests/vec-utils-selftests.c: New file.
   5         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
   6
   7 2019-11-10  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
  10         (tui_highlight_win): Likewise.
  11         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
  12         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
  13         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
  14         Don't set can_highlight.
  15
  16 2019-11-10  Tom Tromey  <tom@tromey.com>
  17
  18         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
  19         Remove unused declaration.
  20
  21 2019-11-08  Tom Tromey  <tromey@adacore.com>
  22
  23         * top.c (read_command_file): Update.
  24         (command_line_input): Make return type const.
  25         * python/py-gdb-readline.c: Update.
  26         * linespec.c (decode_line_2): Update.
  27         * defs.h (command_line_input): Make return type const.
  28         * cli/cli-script.c (read_next_line): Make return type const.
  29         * ada-lang.c (get_selections): Update.
  30
  31 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
  34         * mi/mi-main.c (output_cores): Likewise.
  35         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
  36         (linux_xfer_osdata_modules): Likewise.
  37         * remote.c (register_remote_support_xml): Likewise.
  38         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
  39         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
  40
  41 2019-11-06  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-interp.c: Don't include readline.h.
  44         * tui/tui-hooks.c: Don't include readline.h.
  45         * symmisc.c: Include tilde.h, not readline.h.
  46         * symfile.c: Include tilde.h, not readline.h.
  47         * source.c: Include tilde.h, not readline.h.
  48         * solib.c: Include tilde.h, not readline.h.
  49         * psymtab.c: Include tilde.h, not readline.h.
  50         * exec.c: Include tilde.h, not readline.h.
  51         * corelow.c: Include tilde.h, not readline.h.
  52         * cli/cli-dump.c: Include tilde.h, not readline.h.
  53         * cli/cli-cmds.c: Don't include readline.h.
  54
  55 2019-11-05  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
  58         (tui_disassemble): Set addr_size.
  59         (tui_disasm_window::set_contents): Use addr_size.
  60
  61 2019-11-05  Tom Tromey  <tom@tromey.com>
  62
  63         * rust-lang.c (rust_language_defn): Update.
  64         * python/py-value.c (valpy_string): Call c_get_string.
  65         * p-lang.c (pascal_language_defn): Update.
  66         * opencl-lang.c (opencl_language_defn): Update.
  67         * objc-lang.c (objc_language_defn): Update.
  68         * m2-lang.c (m2_language_defn): Update.
  69         * language.c (unknown_language_defn, auto_language_defn): Update.
  70         (default_get_string): Remove.
  71         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
  72         * go-lang.c (go_language_defn): Update.
  73         * f-lang.c (f_language_defn): Update.
  74         * d-lang.c (d_language_defn): Update.
  75         * c-lang.c (c_language_defn, cplus_language_defn)
  76         (asm_language_defn, minimal_language_defn): Update.
  77         * ada-lang.c (ada_language_defn): Update.
  78         * language.h (struct language_defn) <la_get_string>: Remove.
  79         (LA_GET_STRING): Remove.
  80         (default_get_string): Don't declare.
  81
  82 2019-11-05  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-source.h (struct tui_source_window): Inline
  85         constructor.  Remove destructor.
  86         <style_changed, m_observable>: Move to superclass.
  87         * tui/tui-winsource.h (tui_copy_source_line): Declare.
  88         (struct tui_source_window_base): Move private members to end.
  89         <style_changed, m_observable>: Move from tui_source_window.
  90         * tui/tui-winsource.c (tui_copy_source_line): Move from
  91         tui-source.c.  Rename from copy_source_line.  Add special handling
  92         for negative line number.
  93         (tui_source_window_base::style_changed): Move from
  94         tui_source_window.
  95         (tui_source_window_base): Register observer.
  96         (~tui_source_window_base): New.
  97         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
  98         rename.
  99         (tui_source_window::set_contents): Use tui_copy_source_line.
 100         (tui_source_window::tui_source_window): Move to tui-source.h.
 101         (tui_source_window::~tui_source_window): Remove.
 102         (tui_source_window::style_changed): Move to superclass.
 103         * tui/tui-disasm.c (tui_disassemble): Create string file with
 104         styling, when possible.  Add "addr_size" parameter.
 105         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 106         Don't compute maximum size.
 107         (len_without_escapes): New function
 108
 109 2019-11-05  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 112         std::string.
 113         * tui/tui-winsource.c (tui_show_source_line): Update.
 114         * tui/tui-source.c (tui_source_window::set_contents): Update.
 115         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 116
 117 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 118
 119         * symtab.h (gdb_static_assert): Put && operator at the beginning
 120         of the line instead of the end.
 121
 122 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 125         and sizeof (symbol).
 126         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 127
 128 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 129
 130         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 131         * configure.host: Mark *-*-solaris2.10* obsolete.
 132         * configure.tgt: Mark Solaris < 11 obsolete.
 133         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 134         Update target triplet.
 135
 136 2019-11-01  Tom Tromey  <tromey@adacore.com>
 137
 138         * utils.c (print_sys_errmsg): Simplify.
 139
 140 2019-11-01  Tom Tromey  <tromey@adacore.com>
 141
 142         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 143
 144 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 145
 146         * configure: Regenerate.
 147         * configure.ac: Remove check for strerror_r.
 148         * gdbsupport/common.m4: Check for strerror_r.
 149
 150 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 151
 152         PR gdb/25124
 153
 154         * arm-tdep.c (arm_per_objfile): Rename to ...
 155         (arm_per_bfd): ... this.
 156         (arm_objfile_data_key): Rename to ...
 157         (arm_bfd_data_key): ... this.
 158         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 159         data.
 160         (arm_record_special_symbol): Likewise.
 161
 162 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 163
 164         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 165         end.
 166         * c-typeprint.c (c_print_typedef): Likewise.
 167         * f-typeprint.c (f_print_typedef): Likewise.
 168         * m2-typeprint.c (m2_print_typedef): Likewise.
 169         * p-typeprint.c (pascal_print_typedef): Likewise.
 170         * rust-lang.c (rust_print_typedef): Likewise.
 171         * symtab.c (print_symbol_info): Print a newline after calling
 172         typedef_print.
 173
 174 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * symtab.c (info_module_cmdlist): New variable.
 177         (info_module_command): New function.
 178         (search_module_symbols): New function.
 179         (info_module_subcommand): New function.
 180         (struct info_modules_var_func_options): New struct.
 181         (info_modules_var_func_options_defs): New variable.
 182         (make_info_modules_var_func_options_def_group): New function.
 183         (info_module_functions_command): New function.
 184         (info_module_variables_command): New function.
 185         (info_module_var_func_command_completer): New function.
 186         (_initialize_symtab): Register new 'info module functions' and
 187         'info module variables' commands.
 188         * symtab.h (typedef symbol_search_in_module): New typedef.
 189         (search_module_symbols): Declare new function.
 190         * NEWS: Mention new commands.
 191
 192 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 195         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 196         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 197         MODULES_DOMAIN.
 198         (scan_partial_symbols): Only create partial module symbols for non
 199         declarations.
 200         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 201         and MODULES_DOMAIN.
 202         * symtab.c (search_domain_name): Likewise.
 203         (search_symbols): Likewise.
 204         (print_symbol_info): Likewise.
 205         (symtab_symbol_info): Likewise.
 206         (info_modules_command): New function.
 207         (_initialize_symtab): Register 'info modules' command.
 208         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 209         * NEWS: Mention new 'info modules' command.
 210
 211 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 212
 213         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 214         and $_gdb_maint_setting_str.
 215
 216 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 217
 218         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 219         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 220         (str_value_from_setting, gdb_setting_str_internal_fn)
 221         (gdb_maint_setting_str_internal_fn): New functions.
 222         (_initialize_cli_cmds): Define the new convenience functions.
 223         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 224         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 225
 226 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 227
 228         * agent.c (set_can_use_agent): When the setting is turned on,
 229         look up agent symbols if we don't have them yet.
 230         (agent_new_objfile): Don't look up agent symbols when the agent
 231         setting is off.
 232
 233 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 234
 235         * config.in: Regenerate.
 236
 237 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 238
 239         * configure: Regenerate.
 240         * configure.ac: Check for strerror_r.
 241         * gdbsupport/common-utils.h (safe_strerror): Change return value
 242         to const char * and document that this function is now threadsafe.
 243         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 244         thread_local and call strerror_r, if available.
 245         * utils.c (perror_string): Update.
 246         (print_sys_errmsg): Update.
 247
 248 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 249
 250         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 251         objfile_key.
 252         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 253         objfile to fetch per-bfd data.
 254         (arm_find_exidx_entry): Likewise.
 255
 256 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 257
 258         * gdbsupport/agent.c (debug_agent): Change type to bool.
 259         (use_agent): Likewise.
 260         (all_agent_symbols_look_up): Likewise.
 261         (agent_loaded_p): Change return value to bool.
 262         (agent_look_up_symbols): Update.
 263         (agent_capability_check): Change return value to bool.
 264         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 265         (debug_agent): Change type to bool.
 266         (use_agent): Likewise.
 267         (agent_capability_check): Change return value to bool.
 268
 269 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 270
 271         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 272         (build_minimal_symbol_hash_tables): Code to clear the table moved
 273         to clear_minimal_symbol_hash_tables.
 274         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 275         when needed.
 276
 277 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 278
 279         * infcmd.c: Remove includes.
 280         * infrun.c: Remove includes.
 281
 282 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 283
 284         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 285         (grow_vect): Remove declaration.
 286         (ada_type_of_array): Remove declaration.
 287         (ada_update_initial_language): Remove declaration.
 288         (ada_fold_name): Remove declaration.
 289         (ada_fill_in_ada_prototype): Remove declaration.
 290         (user_select_syms): Remove declaration.
 291         (get_selections): Remove declaration.
 292         (ada_tag_type): Remove declaration.
 293         (ada_value_tag): Remove declaration.
 294         (ada_is_others_clause): Remove declaration.
 295         (ada_in_variant): Remove declaration.
 296         (ada_value_struct_elt): Remove declaration.
 297         (ada_attribute_name): Remove declaration.
 298         (ada_system_address_type): Remove declaration.
 299         * ada-lang.c (ada_watch_location_expression): Make static.
 300         (GROW_VECT): Move here from ada-lang.h.
 301         (grow_vect): Make static.
 302         (ada_update_initial_language): Make static.
 303         (ada_fold_name): Make static.
 304         (ada_type_of_array): Make static.
 305         (encoded_ordered_before): Move up.
 306         (sort_choices): Move up.
 307         (print_signatures): Move up.
 308         (ada_print_symbol_signature): Move up.
 309         (get_selections): Move up and make static.
 310         (user_select_syms): Move up and make static.
 311         (ada_value_struct_elt): Move up and make static.
 312         (ada_tag_type): Make static.
 313         (ada_value_tag): Make static.
 314         (ada_is_others_clause): Make static.
 315         (ada_in_variant): Make static.
 316         (ada_attribute_name): Make static.
 317
 318 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 319
 320         * ada-lang.c: Remove includes.
 321         * ada-typeprint.c: Remove includes.
 322         * ada-valprint.c: Remove includes.
 323
 324 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 325
 326         * addrmap.c: Add static assertions of type size, moved from
 327         _initialize_addrmap.
 328         (_initialize_addrmap): Remove.
 329
 330 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 331
 332         * coffread.c (record_minimal_symbol): Update.
 333         (process_coff_symbol): Update.
 334         * dbxread.c (read_dbx_symtab): Update.
 335         * dwarf2read.c (add_partial_symbol): Update.
 336         (fixup_go_packaging): Update.
 337         (load_partial_dies): Update.
 338         (new_symbol): Update.
 339         * elfread.c (record_minimal_symbol): Change signature to use
 340         gdb::string_view instead of name+len.
 341         (elf_symtab_read): Update.
 342         (elf_rel_plt_read): Update.
 343         * mdebugread.c (parse_partial_symbols): Update.
 344         (handle_psymbol_enumerators): Update.
 345         (new_symbol): Update.
 346         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 347         to use gdb::string_view instead of name+len.
 348         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 349         * psympriv.h (add_psymbol_to_list): Likewise.
 350         * psymtab.c (add_psymbol_to_bcache): Likewise.
 351         (add_psymbol_to_list): Likewise.
 352         * stabsread.c (define_symbol): Update.
 353         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 354         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 355         (symbol_set_names): Likewise.
 356         * xcoffread.c (scan_xcoff_symtab): Update.
 357
 358 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * symtab.h (symbol_set_names): Document that copy_name must be
 361         set to true for non-nullterminated strings.
 362         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 363         linkage_name if the entry was not found and we need to demangle.
 364
 365 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 368         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 369         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 370         * gdbsupport/gdb_binary_search.h: New file.
 371
 372 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 373
 374         * NEWS: Mention new --with-system-gdbinit-dir option.
 375         * config.in: Regenerate.
 376         * configure: Regenerate.
 377         * configure.ac: Add new option --with-system-gdbinit-dir.
 378         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 379         for a ".gdb" suffix.
 380         * main.c (get_init_files): Change system_gdbinit argument to
 381         a vector and return the files in SYSTEM_GDBINIT_DIR in
 382         addition to SYSTEM_GDBINIT.
 383         (captured_main_1): Update.
 384         (print_gdb_help): Update.
 385         * top.c (print_gdb_configuration): Also print the value of
 386         SYSTEM_GDBINIT_DIR.
 387
 388 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 391         that takes gdb::string_view arguments.
 392
 393 2019-10-26  Tom de Vries  <tdevries@suse.de>
 394
 395         * aarch64-linux-tdep.c: Fix typos in comments.
 396         * aarch64-tdep.c: Same.
 397         * ada-lang.c: Same.
 398         * amd64-nat.c: Same.
 399         * arc-tdep.c: Same.
 400         * arch/aarch64-insn.c: Same.
 401         * block.c: Same.
 402         * breakpoint.h: Same.
 403         * btrace.h: Same.
 404         * c-varobj.c: Same.
 405         * cli/cli-decode.c: Same.
 406         * cli/cli-script.c: Same.
 407         * cli/cli-utils.h: Same.
 408         * coff-pe-read.c: Same.
 409         * coffread.c: Same.
 410         * compile/compile-cplus-symbols.c: Same.
 411         * compile/compile-object-run.c: Same.
 412         * completer.c: Same.
 413         * corelow.c: Same.
 414         * cp-support.c: Same.
 415         * demangle.c: Same.
 416         * dwarf-index-write.c: Same.
 417         * dwarf2-frame.c: Same.
 418         * dwarf2-frame.h: Same.
 419         * eval.c: Same.
 420         * frame-base.h: Same.
 421         * frame.h: Same.
 422         * gdbcmd.h: Same.
 423         * gdbtypes.h: Same.
 424         * gnu-nat.c: Same.
 425         * guile/scm-objfile.c: Same.
 426         * i386-tdep.c: Same.
 427         * i386-tdep.h: Same.
 428         * infcall.c: Same.
 429         * infcall.h: Same.
 430         * linux-nat.c: Same.
 431         * m68k-tdep.c: Same.
 432         * macroexp.c: Same.
 433         * memattr.c: Same.
 434         * mi/mi-cmd-disas.c: Same.
 435         * mi/mi-getopt.h: Same.
 436         * mi/mi-main.c: Same.
 437         * minsyms.c: Same.
 438         * nat/aarch64-sve-linux-sigcontext.h: Same.
 439         * objfiles.h: Same.
 440         * ppc-linux-nat.c: Same.
 441         * ppc-linux-tdep.c: Same.
 442         * ppc-tdep.h: Same.
 443         * progspace.h: Same.
 444         * prologue-value.h: Same.
 445         * python/py-evtregistry.c: Same.
 446         * python/py-instruction.h: Same.
 447         * record-btrace.c: Same.
 448         * record-full.c: Same.
 449         * remote.c: Same.
 450         * rs6000-tdep.c: Same.
 451         * ser-tcp.c: Same.
 452         * sol-thread.c: Same.
 453         * sparc-sol2-tdep.c: Same.
 454         * sparc64-tdep.c: Same.
 455         * stabsread.c: Same.
 456         * symfile.c: Same.
 457         * symtab.h: Same.
 458         * target.c: Same.
 459         * tracepoint.c: Same.
 460         * tui/tui-data.h: Same.
 461         * tui/tui-io.c: Same.
 462         * tui/tui-win.c: Same.
 463         * tui/tui.c: Same.
 464         * unittests/rsp-low-selftests.c: Same.
 465         * user-regs.h: Same.
 466         * utils.c: Same.
 467         * utils.h: Same.
 468         * valarith.c: Same.
 469         * valops.c: Same.
 470         * valprint.c: Same.
 471         * valprint.h: Same.
 472         * value.c: Same.
 473         * value.h: Same.
 474         * varobj.c: Same.
 475         * x86-nat.h: Same.
 476         * xtensa-tdep.c: Same.
 477
 478 2019-10-25  Ali Tamur <tamur@google.com>
 479
 480         * charset.c (find_charset_names): Reflect API change.
 481
 482 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 483
 484         * symtab.c (struct demangled_name_entry): Change demangled name
 485         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 486         part of the struct anymore.
 487         (symbol_set_names): No longer obstack allocate + copy the demangled
 488         name, just store the allocated name from bfd.
 489
 490 2019-10-25  Tom Tromey  <tromey@adacore.com>
 491
 492         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 493         (bsearch_cie_cmp, add_cie): Remove.
 494         (find_cie): Reimplement.
 495         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 496         (dwarf2_build_frame_info): Update.
 497
 498 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 499
 500         PR gdb/25126
 501         * symfile.c (reread_symbols): Call forget_cached_source_info to
 502         clear the stale source cache.
 503
 504 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 505
 506         * configure: Regenerate.
 507         * configure.ac: Remove code that sets python_has_threads.
 508
 509 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 510
 511         * config.in: Regenerate.
 512         * configure: Regenerate.
 513         * configure.ac: Remove the code that uses sed to get the python
 514         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 515
 516 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 519         error paths.
 520
 521 2019-10-23  Tom Tromey  <tom@tromey.com>
 522
 523         * arc-tdep.c: Remove ".." from include.
 524         * frv-tdep.c: Remove ".." from include.
 525         * lm32-tdep.c: Remove ".." from include.
 526         * microblaze-tdep.c: Remove ".." from include.
 527         * or1k-tdep.h: Remove ".." from include.
 528         * s12z-tdep.c: Remove ".." from include.
 529         * Makefile.in (OPCODES_CFLAGS): Add comment.
 530         (TOP_CFLAGS): New variable.
 531         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 532
 533 2019-10-23  Tom Tromey  <tom@tromey.com>
 534
 535         * Makefile.in (READLINE_DIR): Update.
 536
 537 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 538
 539         * infcall.c (call_function_by_hand_dummy): Fix the function
 540         comment.  And extract out a code section into...
 541         (reserve_stack_space): ...this new function.
 542
 543 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 544
 545         * infcall.c (value_arg_coerce): Remove an unused parameter.
 546         (call_function_by_hand_dummy): Update the call to
 547         'value_arg_coerce'.
 548
 549 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 550
 551         * infcall.c (call_function_by_hand_dummy): Refactor.
 552
 553 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 554
 555         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 556
 557 2019-10-23  Tom Tromey  <tom@tromey.com>
 558
 559         * configure: Rebuild.
 560         * configure.ac: Don't check for sigprocmask.
 561         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 562
 563 2019-10-23  Tom Tromey  <tom@tromey.com>
 564
 565         * configure: Rebuild.
 566         * acinclude.m4: Use m4_include, not sinclude.
 567
 568 2019-10-23  Tom de Vries  <tdevries@suse.de>
 569
 570         PR breakpoints/24687
 571         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 572
 573 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 574
 575         * symtab.c (struct demangled_name_entry) <language>: Change from
 576         bitfield to regular variable.
 577
 578 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * symtab.c (struct demangled_name_entry): Add a constructor.
 581         (free_demangled_name_entry): New function to call the destructor
 582         for demangled_name_entry.
 583         (create_demangled_names_hash): Pass free_demangled_name_entry to
 584         htab_create_alloc.
 585         (symbol_set_names): Call placement new for demangled_name_entry.
 586         * utils.c: No longer include xxhash.h here, now that fast_hash
 587         is inlined in the header.
 588         * utils.h: Instead, include it here.
 589
 590 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 591
 592         * Makefile.in: Link with libxxhash.
 593         * config.in: Regenerate.
 594         * configure: Regenerate.
 595         * configure.ac: Search for libxxhash.
 596         * utils.c (fast_hash): Use xxhash if present.
 597
 598 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 599
 600         * utils.h (fast_hash): New function.
 601         * symtab.c (hash_demangled_name_entry): Call new function
 602         fast_hash.
 603
 604 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 605
 606         * symtab.c (struct demangled_name_entry): Change type of mangled
 607         to gdb::string_view. Also adds a constructor that takes the
 608         mangled name.
 609         (hash_demangled_name_entry): Update.
 610         (eq_demangled_name_entry): Update.
 611         (free_demangled_name_entry): New function to call the destructor
 612         now that this is not a POD anymore.
 613         (create_demangled_names_hash): Pass free_demangled_name_entry to
 614         htab_create_alloc.
 615         (symbol_set_names): Update.
 616
 617 2019-10-21  Ali Tamur  <tamu@google.com>
 618
 619         * dwarf2read.c (dir_index): Change type.
 620         (file_name_index): Likewise.
 621         (line_header::include_dir_at): Change comment and implementation on
 622         whether it is DWARF 5.
 623         (line_header::is_valid_file_index): New function.
 624         (line_header::file_name_at): Change comment and implementation on
 625         whether it is DWARF 5.
 626         (line_header::file_names): Change to private field renamed as
 627         m_file_names and introduce a new accessor method.
 628         (line_header::file_names_size): New method.
 629         (line_header::include_dirs): Change to private field and rename as
 630         m_include_dirs.
 631         (dw2_get_file_names_reader): Define local var at a smaller scope and
 632         reflect API change.
 633         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 634         (process_structure_scope): Likewise.
 635         (line_header::add_include_dir): Change message and reflect renaming.
 636         (line_header::add_file_name): Likewise.
 637         (read_formatted_entries): Handle DW_FORM_data16.
 638         (dwarf_decode_line_header): Fix line header length calculation.
 639         (psymtab_include_file_name): Change comment and API.
 640         (lnp_state_machine::m_file): Update comment and reflect type change.
 641         (lnp_state_machine::record_line): Reflect type change.
 642         (dwarf_decode_lines): Reflect API change.
 643         (file_file_name): Likewise.
 644         (file_full_name): Likewise.
 645
 646 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 649
 650 2019-10-21  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 653
 654 2019-10-21  Tom Tromey  <tom@tromey.com>
 655
 656         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 657         NM_H.   Use AC_CONFIG_LINKS.
 658         * configure: Rebuild.
 659         * Makefile.in (NM_H): New variable.
 660         (generated_files): Add NM_H.  Remove gcore.
 661         (nm.h, stamp-nmh): New targets.
 662
 663 2019-10-20  Tom Tromey  <tom@tromey.com>
 664
 665         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 666         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 667         obsolete comment.
 668         (put_objfile_before): Now static.
 669
 670 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * gdbsupport/common-utils.h (startswith): Change return type to
 673         bool.
 674
 675 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 676
 677         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 678         * breakpoint.c (bp_locations_compare): Rename to...
 679         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 680         (update_global_location_list): Use std::sort instead of qsort.
 681         * buildsym.c (compare_line_numbers): Rename to...
 682         (lte_is_less_than): ...this, and change to std::sort semantics.
 683         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 684         instead of qsort.
 685         * disasm.c (compare_lines): Rename to...
 686         (line_is_less_than): ...this, and change to std::sort semantics.
 687         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 688         of qsort.
 689         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 690         (fde_is_less_than): ...this, and change to std::sort semantics.
 691         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 692         * mdebugread.c (compare_blocks):
 693         (block_is_less_than): ...this, and change to std::sort semantics.
 694         (sort_blocks): Call std::sort instead of qsort.
 695         * objfiles.c (qsort_cmp): Rename to...
 696         (sort_cmp): ...this, and change to std::sort semantics.
 697         (update_section_map): Call std::sort instead of qsort.
 698         * remote.c (compare_pnums): Remove.
 699         (map_regcache_remote_table): Call std::sort instead of qsort.
 700         * utils.c (compare_positive_ints): Remove.
 701         * utils.h (compare_positive_ints): Remove.
 702         * xcoffread.c (compare_lte): Remove.
 703         (arrange_linetable): Call std::sort instead of qsort.
 704
 705 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 706
 707         * symfile.c (init_entry_point_info): Fix typo.
 708         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 709
 710 2019-10-18  Tom de Vries  <tdevries@suse.de>
 711
 712         * aarch64-tdep.c: Fix typos in comments.
 713         * ada-lang.c: Same.
 714         * ada-tasks.c: Same.
 715         * alpha-tdep.c: Same.
 716         * alpha-tdep.h: Same.
 717         * amd64-nat.c: Same.
 718         * amd64-windows-tdep.c: Same.
 719         * arc-tdep.c: Same.
 720         * arc-tdep.h: Same.
 721         * arch-utils.c: Same.
 722         * arm-nbsd-tdep.c: Same.
 723         * arm-tdep.c: Same.
 724         * ax-gdb.c: Same.
 725         * blockframe.c: Same.
 726         * btrace.c: Same.
 727         * c-varobj.c: Same.
 728         * coff-pe-read.c: Same.
 729         * coffread.c: Same.
 730         * cris-tdep.c: Same.
 731         * darwin-nat.c: Same.
 732         * dbxread.c: Same.
 733         * dcache.c: Same.
 734         * disasm.c: Same.
 735         * dtrace-probe.c: Same.
 736         * dwarf-index-write.c: Same.
 737         * dwarf2-frame-tailcall.c: Same.
 738         * dwarf2-frame.c: Same.
 739         * dwarf2read.c: Same.
 740         * eval.c: Same.
 741         * exceptions.c: Same.
 742         * fbsd-tdep.c: Same.
 743         * findvar.c: Same.
 744         * frame.c: Same.
 745         * frv-tdep.c: Same.
 746         * gnu-v3-abi.c: Same.
 747         * go32-nat.c: Same.
 748         * h8300-tdep.c: Same.
 749         * hppa-tdep.c: Same.
 750         * i386-linux-tdep.c: Same.
 751         * i386-tdep.c: Same.
 752         * ia64-libunwind-tdep.c: Same.
 753         * ia64-tdep.c: Same.
 754         * infcmd.c: Same.
 755         * infrun.c: Same.
 756         * linespec.c: Same.
 757         * linux-nat.c: Same.
 758         * linux-thread-db.c: Same.
 759         * machoread.c: Same.
 760         * mdebugread.c: Same.
 761         * mep-tdep.c: Same.
 762         * mn10300-tdep.c: Same.
 763         * namespace.c: Same.
 764         * objfiles.c: Same.
 765         * opencl-lang.c: Same.
 766         * or1k-tdep.c: Same.
 767         * osabi.c: Same.
 768         * ppc-linux-nat.c: Same.
 769         * ppc-linux-tdep.c: Same.
 770         * ppc-sysv-tdep.c: Same.
 771         * printcmd.c: Same.
 772         * procfs.c: Same.
 773         * record-btrace.c: Same.
 774         * record-full.c: Same.
 775         * remote-fileio.c: Same.
 776         * remote.c: Same.
 777         * rs6000-tdep.c: Same.
 778         * s12z-tdep.c: Same.
 779         * score-tdep.c: Same.
 780         * ser-base.c: Same.
 781         * ser-go32.c: Same.
 782         * skip.c: Same.
 783         * sol-thread.c: Same.
 784         * solib-svr4.c: Same.
 785         * solib.c: Same.
 786         * source.c: Same.
 787         * sparc-nat.c: Same.
 788         * sparc-sol2-tdep.c: Same.
 789         * sparc-tdep.c: Same.
 790         * sparc64-tdep.c: Same.
 791         * stabsread.c: Same.
 792         * stack.c: Same.
 793         * symfile.c: Same.
 794         * symtab.c: Same.
 795         * target-descriptions.c: Same.
 796         * target-float.c: Same.
 797         * thread.c: Same.
 798         * utils.c: Same.
 799         * valops.c: Same.
 800         * valprint.c: Same.
 801         * value.c: Same.
 802         * varobj.c: Same.
 803         * windows-nat.c: Same.
 804         * xcoffread.c: Same.
 805         * xstormy16-tdep.c: Same.
 806         * xtensa-tdep.c: Same.
 807
 808 2019-10-17  Tom Tromey  <tromey@adacore.com>
 809
 810         * configure: Rebuild.
 811         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 812         in AC_CONFIG_FILES invocation.
 813         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 814         new-style config.status invocation.
 815
 816 2019-10-17  Tom de Vries  <tdevries@suse.de>
 817
 818         * arm-nbsd-nat.c: Fix typos in comments.
 819         * arm-tdep.c: Same.
 820         * darwin-nat-info.c: Same.
 821         * dwarf2read.c: Same.
 822         * elfread.c: Same.
 823         * event-top.c: Same.
 824         * findvar.c: Same.
 825         * gdbtypes.c: Same.
 826         * hppa-tdep.c: Same.
 827         * i386-tdep.c: Same.
 828         * jit.c: Same.
 829         * main.c: Same.
 830         * mdebugread.c: Same.
 831         * moxie-tdep.c: Same.
 832         * nto-procfs.c: Same.
 833         * osabi.c: Same.
 834         * ppc-linux-tdep.c: Same.
 835         * remote.c: Same.
 836         * riscv-tdep.c: Same.
 837         * s390-tdep.c: Same.
 838         * sh-tdep.c: Same.
 839         * sparc-linux-tdep.c: Same.
 840         * sparc-nat.c: Same.
 841         * stack.c: Same.
 842         * target-descriptions.c: Same.
 843         * top.c: Same.
 844         * varobj.c: Same.
 845
 846 2019-10-16  Tom Tromey  <tom@tromey.com>
 847
 848         * objfiles.h (struct objfile) <original_name>: Now const.
 849
 850 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 851
 852         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 853         pass on to sigsetjmp's second argument.
 854         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 855
 856 2019-10-16  Keith Seitz  <keiths@redhat.com>
 857
 858         PR gdb/23567
 859         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 860         sections whose size is greater than the file size.
 861
 862 2019-10-16  Jim Wilson  <jimw@sifive.com>
 863
 864         * riscv-tdep.c (riscv_gcc_target_options): New.
 865         (riscv_gnu_triplet_regexp): New.
 866         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 867         set_gdbarch_gnu_triplet_regexp.
 868
 869 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 870
 871         * Makefile.in: Add xml-builtin.h.
 872         * features/feature_to_c.sh: Add an include for xml-builtin.h
 873         to ensure that the compiler checks that the types match.
 874         * xml-builtin.h: New file.
 875         * xml-support.c (fetch_xml_builtin): Add missing const.
 876         * xml-support.h: Remove declaration of xml_builtins.
 877
 878 2019-10-16  Tom de Vries  <tdevries@suse.de>
 879
 880         PR tdep/25096
 881         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 882         (amd64_classify_aggregate): ... here.
 883         (amd64_classify_aggregate_field): Handled fiels of nested structs
 884         recursively.
 885
 886 2019-10-16  Tom de Vries  <tdevries@suse.de>
 887
 888         PR tdep/24104
 889         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 890         that handles 'theclass'.
 891
 892 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * linespec.c (decode_digits_ordinary): Update comment.
 895         * make-target-delegates: No longer need to handle VEC case.
 896         * memrange.c (normalize_mem_ranges): Update comment.
 897         * namespace.c (add_using_directive): Update comment.
 898         * objc-lang.c (uniquify_strings): Update comment.
 899         * ppc-linux-nat.c (struct thread_points): Update comment.
 900         * probe.h (find_probes_in_objfile): Update comment.
 901         * target.h (enum flash_preserve_mode): Update comment.
 902         * varobj.c (varobj_restrict_range): Update comment.
 903         * varobj.h (varobj_list_children): Update comment.
 904
 905 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * Makefile.in: Remove references to vec.h and vec.c.
 908         * aarch64-tdep.c: No longer include vec.h.
 909         * ada-lang.c: Likewise.
 910         * ada-lang.h: Likewise.
 911         * arm-tdep.c: Likewise.
 912         * ax.h: Likewise.
 913         * breakpoint.h: Likewise.
 914         * charset.c: Likewise.
 915         * cp-support.h: Likewise.
 916         * dtrace-probe.c: Likewise.
 917         * dwarf2read.c: Likewise.
 918         * extension.h: Likewise.
 919         * gdb_bfd.c: Likewise.
 920         * gdbsupport/gdb_vecs.h: Likewise.
 921         * gdbsupport/vec.c: Remove.
 922         * gdbsupport/vec.h: Remove.
 923         * gdbthread.h: Likewise.
 924         * guile/scm-type.c: Likewise.
 925         * inline-frame.c: Likewise.
 926         * machoread.c: Likewise.
 927         * memattr.c: Likewise.
 928         * memrange.h: Likewise.
 929         * namespace.h: Likewise.
 930         * nat/linux-btrace.h: Likewise.
 931         * osdata.c: Likewise.
 932         * parser-defs.h: Likewise.
 933         * progspace.h: Likewise.
 934         * python/py-type.c: Likewise.
 935         * record-btrace.c: Likewise.
 936         * rust-exp.y: Likewise.
 937         * solib-target.c: Likewise.
 938         * stap-probe.c: Likewise.
 939         * target-descriptions.c: Likewise.
 940         * target-memory.c: Likewise.
 941         * target.h: Likewise.
 942         * varobj.c: Likewise.
 943         * varobj.h: Likewise.
 944         * xml-support.h: Likewise.
 945
 946 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 949         Update for new std::vector based implementation.
 950         (process_psymtab_comp_unit_reader): Likewise.
 951         (scan_partial_symbols): Likewise.
 952         (recursively_compute_inclusions): Likewise.
 953         (compute_compunit_symtab_includes): Likewise.
 954         (process_imported_unit_die): Likewise.
 955         (queue_and_load_dwo_tu): Likewise.
 956         (follow_die_sig_1): Likewise.
 957         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 958         (typedef dwarf2_per_cu_ptr): Remove.
 959         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 960         function.
 961         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 962         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 963         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 964         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 965         std::vector.
 966
 967 2019-10-15  Tom Tromey  <tromey@adacore.com>
 968
 969         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 970         TID.
 971
 972 2019-10-15  Tom Tromey  <tromey@adacore.com>
 973
 974         * windows-nat.c (windows_nat_target::fetch_registers)
 975         (windows_nat_target::store_registers): Rename "pid" to "tid".
 976
 977 2019-10-15  Tom Tromey  <tromey@adacore.com>
 978
 979         * gdbarch.h, gdbarch.c: Rebuild.
 980         * gdbarch.sh (gcc_target_options): Change return type to
 981         std::string.
 982         * compile/compile.c (get_args): Update.
 983         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 984         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 985         std::string.
 986         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 987         std::string.
 988         * arch-utils.c (default_gcc_target_options): Return std::string.
 989         * arch-utils.h (default_gcc_target_options): Return std::string.
 990         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 991
 992 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 993
 994         * breakpoint.c (breakpoint_chain): Make static.
 995         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 996         of accessing breakpoint_chain.
 997
 998 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1001         to a gdb::function_view and return value to bool.
1002         * breakpoint.h (iterate_over_breakpoints): Likewise.
1003         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1004         (pop_dummy_frame): Update.
1005         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1006         (gdbscm_breakpoints): Update.
1007         * python/py-breakpoint.c (build_bp_list): Update.
1008         (gdbpy_breakpoints): Update.
1009         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1010         Update.
1011         (bpfinishpy_handle_stop): Update.
1012         (bpfinishpy_handle_exit): Update.
1013         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1014         (svr4_update_solib_event_breakpoints): Update.
1015
1016 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1017
1018         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1019         when unwrapping single-field structs.
1020
1021 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1022
1023         * dwarf2read.c: Remove includes.
1024
1025 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1026
1027         * ui-out.c (ui_out::call_do_message): Silence
1028         -Wformat-nonliteral warning.
1029
1030 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1031
1032         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1033         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1034         include: readline/tilde.h.
1035
1036 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1037
1038         * remote.c (remote_target::get_trace_status): Remove declaration of
1039         trace_regblock_size.
1040
1041 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1044         (show_user): Remove declaration of cmdlist.
1045         * cli/cli-cmds.h (max_user_call_depth): Declare.
1046         * cli/cli-script.c (execute_user_command): Remove declaration
1047         of max_user_call_depth.
1048
1049 2019-10-11  Jim Wilson  <jimw@sifive.com>
1050
1051         * gdbsupport/print-utils.h (pulongest): Fix comment.
1052         (plongest): Likewise.
1053         (phex): Add missing comment, mention leading zeros.
1054         (phex_nz): Add mention of no leading zeros to comment.
1055
1056         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1057         plongest instead of unsigned long long cast.
1058
1059 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1062         for external_editor_command and gdbtk_test.
1063
1064 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1065
1066         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1067         * varobj.c (varobjdebug): Move comment to...
1068         * varobj.h (varobjdebug): ...here, and declare.
1069
1070 2019-10-09  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1073         erase_data_content.
1074
1075 2019-10-09  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1078         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1079         * tui/tui-command.c (tui_cmd_window::resize)
1080         (tui_refresh_cmd_win): Update.
1081         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1082         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1083         * tui/tui-data.c (~tui_gen_win_info): Remove.
1084         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1085         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1086         (tui_redisplay_readline, tui_mld_flush)
1087         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1088         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1089         (tui_data_window::erase_data_content)
1090         (tui_data_item_window::rerender)
1091         (tui_data_item_window::refresh_window): Update.
1092         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1093         (box_win, tui_gen_win_info::make_window)
1094         (tui_gen_win_info::make_visible): Update.
1095         (tui_delete_win): Remove.
1096         * tui/tui-winsource.c
1097         (tui_source_window_base::do_erase_source_content): Update.
1098         (tui_show_source_line, tui_source_window_base::update_tab_width)
1099         (tui_source_window_base::update_exec_info): Update.
1100         * tui/tui-data.h (struct curses_deleter): New.
1101         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1102         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1103
1104 2019-10-09  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1107
1108 2019-10-09  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1111         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1112
1113 2019-10-09  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1116         window height directly.
1117         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1118         declare.
1119         * tui/tui-layout.c (tui_default_win_height): Remove.
1120         (tui_default_win_viewport_height): Remove.
1121
1122 2019-10-09  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui.h: Remove comments.
1125
1126 2019-10-09  Tom de Vries  <tdevries@suse.de>
1127
1128         * python/lib/gdb/printer/bound_registers.py: Use
1129         '^builtin_type_bound128' as regexp argument for
1130         add_builtin_pretty_printer.
1131
1132 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1133
1134         * guile/guile.c (guile_extension_script_ops): Remove forward
1135         declaration and mark as static.
1136         (guile_script_ops): Likewise.
1137         (extension_language_guile): Move further down in the file so
1138         it can reference the definitions for guile_{extension_,}script_ops.
1139
1140 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1141
1142         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1143         except SORTL, DFLTCC, and KDSA.
1144
1145 2019-10-08  Tom Tromey  <tromey@adacore.com>
1146
1147         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1148         (struct safe_symbol_file_add_args): Remove.
1149
1150 2019-10-08  Tom Tromey  <tromey@adacore.com>
1151
1152         * windows-nat.c: Don't include buildsym-legacy.h.
1153
1154 2019-10-08  Tom Tromey  <tromey@adacore.com>
1155
1156         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1157
1158 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1159
1160         * gdbtypes.c (overload_debug): Move comment to header.
1161         * gdbtypes.h (overload_debug): Declare.
1162         * valops.c: Remove declaration of overload_debug, instead
1163         include gdbtypes.h.
1164
1165 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1166
1167         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1168         through _().
1169         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1170         move comment...
1171         * language.h (lang_frame_mismatch_warn): ... here. Also add
1172         declaration.
1173         * top.c (lang_frame_mismatch_warn): Remove declaration.
1174         (check_frame_language_change): Pass lang_frame_mismatch_warn
1175         through _().
1176
1177 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1178
1179         * c-lang.h (vtbl_ptr_name): Declare.
1180         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1181         it from the header.
1182         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1183
1184 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1185
1186         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1187         gdb_static_assert.
1188
1189 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1190
1191         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1192         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1193         * ctfread.c: New file.
1194         * ctfread.h: New file.
1195         * elfread.c: Include ctfread.h.
1196         (struct elfinfo text_p): New member ctfsect.
1197         (elf_locate_sections): Mark CTF section.
1198         (elf_symfile_read): Call elfctf_build_psymtabs.
1199         * Makefile.in (LIBCTF): Add.
1200         (CLIBS): Use it.
1201         (CDEPS): Likewise.
1202         (DIST): Add ctfread.c.
1203
1204 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * ctfread.c (struct nextfield): Renamed to ...
1207         (struct ctf_nextfield): ... this.
1208         (struct field_info): Renamed to ...
1209         (strut ctf_field_info): ... this.
1210         (attach_fields_to_type): Update for renamed structures.
1211         (ctf_add_member_cb): Likewise.
1212         (ctf_add_enum_member_cb): Likewise.
1213         (process_struct_members): Likewise.
1214         (process_enum_type): Likewise.
1215
1216 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1217
1218         * tracectf.h: Rename, was ctf.h.
1219         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1220         * tracefile.c: Likewise.
1221         * tracepoint.c: Remove unused include ctf.h.
1222         * mi/mi-main.c: Likewise.
1223         * Makefile.in Replace ctf.c with tracectf.c.
1224
1225 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1226
1227         * version.in: Change version number to "9.0.50.DATE-git".
1228
1229 2019-10-03  Tom Tromey  <tom@tromey.com>
1230
1231         PR rust/24976:
1232         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1233
1234 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1237         cp_search_name_hash.
1238         * NEWS: Add entry about nested function support.
1239
1240 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1241             Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1244         for nested static variables when searchin VAR_DOMAIN.
1245         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1246         global scope, update comment.
1247         (add_partial_subprogram): Call add_partial_subprogram recursively
1248         for nested subroutines when processinng Fortran.
1249         (load_partial_dies): Process the child entities of a subprogram
1250         when processing Fortran.
1251         (partial_die_parent_scope): Handle building scope
1252         for Fortran nested functions.
1253         (process_die): Record that nested functions have a scope.
1254         (new_symbol): Always record Fortran subprograms on the global
1255         symbol list.
1256         (determine_prefix): How to build the prefix for Fortran
1257         subprograms.
1258
1259 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1262         have just sent the thread a SIGSTOP and are waiting for it to
1263         arrive.
1264
1265 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * btrace.c (btrace_add_pc): Remove whitespace before the template
1268         parameter in 'std::vector <...>'.
1269         (parse_xml_btrace_block): Likewise.
1270         (btrace_maint_decode_pt): Likewise.
1271         (btrace_maint_update_packets): Likewise.
1272         (btrace_maint_print_packets): Likewise.
1273         * btrace.h (struct btrace_maint_info): Likewise.
1274         * dwarf2read.c (struct type_unit_group): Likewise.
1275         (build_type_psymtabs_reader): Likewise.
1276         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1277         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1278         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1279
1280 2019-10-03  Tom de Vries  <tdevries@suse.de>
1281
1282         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1283         the first line of the help text for set/show style metadata.
1284
1285 2019-10-02  Tom Tromey  <tromey@adacore.com>
1286
1287         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1288         * gdbsupport/common-inferior.c: New file.
1289         * infcmd.c (startup_with_shell): Don't define.
1290         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1291         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1292         * inferior.h (startup_with_shell): Don't declare.
1293
1294 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1295
1296         * gdbsupport/gdb_assert.h: Include errors.h.
1297         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1298
1299 2019-10-02  Tom Tromey  <tromey@adacore.com>
1300
1301         * NEWS: Add $_ada_exception entry.
1302         * ada-lang.c (struct ada_catchpoint): Add constructor.
1303         <m_kind>: New member.
1304         (allocate_location_exception, re_set_exception): Remove
1305         "ex" parameter.
1306         (should_stop_exception): Compute $_ada_exception.
1307         (check_status_exception, print_it_exception)
1308         (print_one_exception, print_mention_exception): Remove
1309         "ex" parameter.
1310         (allocate_location_catch_exception, re_set_catch_exception)
1311         (check_status_exception, print_it_catch_exception)
1312         (print_one_catch_exception, print_mention_catch_exception)
1313         (print_recreate_catch_exception)
1314         (allocate_location_catch_exception_unhandled)
1315         (re_set_catch_exception_unhandled)
1316         (check_status_exception, print_it_catch_exception_unhandled)
1317         (print_one_catch_exception_unhandled)
1318         (print_mention_catch_exception_unhandled)
1319         (print_recreate_catch_exception_unhandled)
1320         (allocate_location_catch_assert, re_set_catch_assert)
1321         (check_status_assert, print_it_catch_assert)
1322         (print_one_catch_assert, print_mention_catch_assert)
1323         (print_recreate_catch_assert)
1324         (allocate_location_catch_handlers, re_set_catch_handlers)
1325         (check_status_handlers, print_it_catch_handlers)
1326         (print_one_catch_handlers, print_mention_catch_handlers)
1327         (print_recreate_catch_handlers): Remove.
1328         (create_ada_exception_catchpoint): Update.
1329         (initialize_ada_catchpoint_ops): Update.
1330
1331 2019-10-02  Tom Tromey  <tromey@adacore.com>
1332
1333         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1334         (create_excep_cond_exprs): Simplify exception string computation.
1335         (ada_exception_catchpoint_cond_string): Likewise.
1336
1337 2019-10-02  Tom Tromey  <tromey@adacore.com>
1338
1339         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1340         * ada-lang.c (lesseq_defined_than): Handle
1341         LOC_STATIC.
1342         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1343         parameter.
1344         (dwarf2_has_info): Likewise.
1345         (new_symbol): Set maybe_copied on symbol when
1346         appropriate.
1347         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1348         parameter.
1349         <can_copy>: New member.
1350         * elfread.c (record_minimal_symbol): Set maybe_copied
1351         on symbol when appropriate.
1352         (elf_symfile_read): Update call to dwarf2_has_info.
1353         * minsyms.c (lookup_minimal_symbol_linkage): New
1354         function.
1355         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1356         * symtab.c (get_symbol_address, get_msymbol_address):
1357         New functions.
1358         * symtab.h (get_symbol_address, get_msymbol_address):
1359         Declare.
1360         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1361         maybe_copied.
1362         (struct symbol, struct minimal_symbol) <maybe_copied>:
1363         New member.
1364
1365 2019-10-02  Tom Tromey  <tromey@adacore.com>
1366
1367         * source.c (struct current_source_location): New.
1368         (current_source_key): New global.
1369         (current_source_symtab, current_source_line)
1370         (current_source_pspace): Remove.
1371         (get_source_location): New function.
1372         (get_current_source_symtab_and_line)
1373         (set_default_source_symtab_and_line)
1374         (set_current_source_symtab_and_line)
1375         (clear_current_source_symtab_and_line, select_source_symtab)
1376         (info_source_command, print_source_lines_base)
1377         (info_line_command, search_command_helper, _initialize_source):
1378         Update.
1379
1380 2019-10-02  Tom Tromey  <tromey@adacore.com>
1381
1382         * source.c (select_source_symtab): Don't call
1383         decode_line_with_current_source.
1384
1385 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * symtab.c (lookup_global_symbol): Search global block.
1388
1389 2019-10-02  Tom Tromey  <tromey@adacore.com>
1390
1391         * coffread.c (process_coff_symbol): Update.
1392         * dwarf2read.c (var_decode_location, new_symbol): Update.
1393         * mdebugread.c (parse_symbol): Update.
1394         * objfiles.c (relocate_one_symbol): Update.
1395         * stabsread.c (define_symbol, fix_common_block)
1396         (scan_file_globals): Update.
1397         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1398         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1399         * xcoffread.c (process_xcoff_symbol): Update.
1400
1401 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1402
1403         * MAINTAINERS: Update my email address.
1404
1405 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1408         std::vector.
1409         (build_type_psymtabs_reader): Update for std::vector.
1410         (build_type_psymtab_dependencies): Likewise.
1411         * dwarf2read.h: Remove use of DEF_VEC_P.
1412         (typedef sig_type_ptr): Delete.
1413
1414 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1417         to std::vector.
1418         (btrace_maint_decode_pt): Likewise, and move allocation of the
1419         vector outside of the loop.
1420         (btrace_maint_update_packets): Update to handle change from VEC to
1421         std::vector.
1422         (btrace_maint_print_packets): Likewise.
1423         (maint_info_btrace_cmd): Likewise.
1424         * btrace.h: Remove use of DEF_VEC_O.
1425         (typedef btrace_pt_packet_s): Delete.
1426         (struct btrace_maint_info) <packets>: Change fromm VEC to
1427         std::vector.
1428         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1429
1430 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1433         make accesses into the vector constant references.
1434         (btrace_add_pc): Update for std::vector.
1435         (btrace_stitch_bts): Likewise.
1436         (parse_xml_btrace_block): Likewise.
1437         (btrace_maint_update_packets): Likewise.
1438         (btrace_maint_print_packets): Likewise.
1439         (maint_info_btrace_cmd): Likewise.
1440         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1441         std::vector.
1442         (btrace_data::empty): Likewise.
1443         (btrace_data_append): Likewise.
1444         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1445         (typedef btrace_block_s): Delete.
1446         (struct btrace_block): Add constructor.
1447         (struct btrace_data_bts) <blocks>: Change to std::vector.
1448         * nat/linux-btrace.c (perf_event_read_bts): Update for
1449         std::vector.
1450         (linux_read_bts): Likewise.
1451
1452 2019-10-01  Tom Tromey  <tom@tromey.com>
1453
1454         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1455
1456 2019-10-01  Tom Tromey  <tom@tromey.com>
1457
1458         * stack.c (print_frame, info_frame_command_core): Use
1459         styled_string.
1460         * linux-thread-db.c (try_thread_db_load_1)
1461         (try_thread_db_load_from_pdir_1): Use styled_string.
1462         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1463         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1464         (maybe_print_unsupported_script_warning)
1465         (maybe_print_script_not_found_warning): Use styled_string.
1466         * ada-lang.c (user_select_syms): Use styled_string.
1467
1468 2019-10-01  Tom Tromey  <tom@tromey.com>
1469
1470         * p-lang.c (pascal_printstr): Use metadata style.
1471         * value.c (show_convenience): Use metadata style.
1472         * valprint.c (valprint_check_validity, val_print_optimized_out)
1473         (val_print_not_saved, val_print_unavailable)
1474         (val_print_invalid_address, generic_val_print, val_print)
1475         (value_check_printable, val_print_array_elements): Use metadata
1476         style.
1477         * ui-out.h (class ui_out) <field_fmt>: New overload.
1478         <do_field_fmt>: Add style parameter.
1479         * ui-out.c (ui_out::field_fmt): New overload.
1480         * typeprint.c (type_print_unknown_return_type)
1481         (val_print_not_allocated, val_print_not_associated): Use metadata
1482         style.
1483         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1484         parameter.
1485         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1486         * tracepoint.c (tvariables_info_1): Use metadata style.
1487         * stack.c (print_frame_arg, print_frame_info, print_frame)
1488         (info_frame_command_core): Use metadata style.
1489         * skip.c (info_skip_command): Use metadata style.
1490         * rust-lang.c (rust_print_enum): Use metadata style.
1491         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1492         metadata style.
1493         * python/py-framefilter.c (py_print_single_arg): Use metadata
1494         style.
1495         * printcmd.c (do_one_display, print_variable_and_value): Use
1496         metadata style.
1497         * p-valprint.c (pascal_val_print)
1498         (pascal_object_print_value_fields): Use metadata style.
1499         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1500         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1501         parameter.
1502         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1503         * m2-valprint.c (m2_print_long_set): Use metadata style.
1504         * m2-typeprint.c (m2_print_type): Use metadata style.
1505         * infcmd.c (print_return_value_1): Use metadata style.
1506         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1507         * f-valprint.c (info_common_command_for_block): Use metadata
1508         style.
1509         * f-typeprint.c (f_type_print_base): Use metadata style.
1510         * expprint.c (print_subexp_standard): Use metadata style.
1511         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1512         * cli/cli-style.h (class cli_style_option): Add constructor.
1513         (metadata_style): Declare.
1514         * cli/cli-style.c (metadata_style): New global.
1515         (_initialize_cli_style): Register metadata style.
1516         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1517         parameter.
1518         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1519         * c-typeprint.c (c_type_print_base_struct_union)
1520         (c_type_print_base_1): Use metadata style.
1521         * breakpoint.c (watchpoint_value_print)
1522         (print_one_breakpoint_location): Use metadata style.
1523         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1524         style.
1525         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1526         style.
1527         * ada-valprint.c (val_print_packed_array_elements, printstr)
1528         (print_field_values, ada_val_print_ref, ada_val_print): Use
1529         metadata style.
1530         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1531         style.
1532         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1533         style.
1534         * ada-lang.c (user_select_syms): Use metadata style.
1535
1536 2019-10-01  Tom Tromey  <tom@tromey.com>
1537
1538         * cli/cli-cmds.c (pwd_command): Style output.
1539
1540 2019-10-01  Pedro Alves  <palves@redhat.com>
1541             Tom Tromey  <tom@tromey.com>
1542
1543         * symtab.c (print_symbol_info): Use %ps.
1544         (print_msymbol_info): Use %ps.
1545         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1546         * printcmd.c (print_variable_and_value): Use %ps.
1547         * macrocmd.c (show_pp_source_pos): Use %ps.
1548         * infrun.c (print_exited_reason): Use ui_out::message.
1549         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1550         (describe_other_breakpoints): Use ui_out::message and new
1551         formats.
1552         (say_where): Use new formats.
1553         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1554         and new formats.
1555
1556 2019-10-01  Pedro Alves  <palves@redhat.com>
1557             Tom Tromey  <tom@tromey.com>
1558
1559         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1560         (test_gdb_formats): New function.
1561         (run_tests): Call it.
1562         (test_format_specifier): Update.
1563         * utils.h (fputs_filtered): Update comment.
1564         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1565         (fputs_styled_unfiltered): Declare.
1566         * utils.c (fputs_styled_unfiltered): New function.
1567         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1568         (vfprintf_filtered): Update.
1569         (vfprintf_unfiltered, vprintf_filtered): Update.
1570         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1571         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1572         disallow_ui_out_field>: New constants.
1573         (enum class field_kind): New.
1574         (struct base_field_s, struct signed_field_s): New.
1575         (signed_field): New function.
1576         (struct string_field_s): New.
1577         (string_field): New function.
1578         (struct styled_string_s): New.
1579         (styled_string): New function.
1580         (class ui_out) <message>: Add comment.
1581         <vmessage, call_do_message>: New methods.
1582         <do_message>: Add style parameter.
1583         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1584         methods.
1585         (ui_out::message): Rewrite.
1586         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1587         parameter.
1588         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1589         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1590         gdb_extensions parameter.
1591         (class format_piece): Add parameter to constructor.
1592         (n_int_args): New field.
1593         * gdbsupport/format.c (format_pieces::format_pieces): Add
1594         gdb_extensions parameter.  Handle '*'.
1595         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1596         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1597         vfprintf_styled_no_gdbfmt.
1598         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1599         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1600         unfiltered output.
1601         * ui-style.h (struct ui_file_style) <ptr>: New method.
1602
1603 2019-10-01  Tom Tromey  <tom@tromey.com>
1604
1605         * unittests/format_pieces-selftests.c: Update.  Add final format.
1606         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1607         empty literal pieces.
1608
1609 2019-10-01  Tom Tromey  <tom@tromey.com>
1610
1611         * ui-out.h (enum class ui_out_style_kind): Remove.
1612         (class ui_out) <field_string, field_stsream, do_field_string>:
1613         Change type of "style".
1614         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1615         (ui_out::field_string): Update.
1616         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1617         of "style".
1618         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1619         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1620         * stack.c (print_frame_arg, print_frame_info, print_frame):
1621         Update.
1622         * source.c (print_source_lines_base): Update.
1623         * solib.c (info_sharedlibrary_command): Update.
1624         * skip.c (info_skip_command): Update.
1625         * record-btrace.c (btrace_call_history_src_line)
1626         (btrace_call_history): Update.
1627         * python/py-framefilter.c (py_print_frame): Update.
1628         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1629         "style".
1630         * mi/mi-out.c (mi_ui_out::do_table_header)
1631         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1632         (mi_ui_out::do_field_string): Update.
1633         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1634         Update.
1635         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1636         "style".
1637         * cli-out.c (cli_ui_out::do_table_header)
1638         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1639         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1640         (cli_ui_out::do_field_fmt): Update.
1641         * breakpoint.c (print_breakpoint_location): Update.
1642         (update_static_tracepoint): Update.
1643
1644 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1645
1646         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1647         conversion of gdb_datadir.
1648         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1649         remove not needed c_str ().
1650
1651 2019-09-30  Ali Tamur <tamur@google.com>
1652
1653         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1654         (dwarf2_string_attr): Likewise.
1655
1656 2019-09-30  Ali Tamur <tamur@google.com>
1657
1658         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1659         (process_full_type_unit): Likewise.
1660         (dump_die_shallow): Likewise.
1661         (cu_debug_loc_section): Likewise.
1662
1663 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1664
1665         * minsyms.c (compare_minimal_symbols): Rename to...
1666         (minimal_symbol_is_less_than): ...this, and adjust to STL
1667         conventions (return bool, take arguments as references)
1668         (minimal_symbol_reader::install): Call std::sort instead
1669         of qsort.
1670
1671 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1672
1673         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1674         hash and why.
1675         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1676         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1677
1678 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1679
1680         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1681         * psympriv.h (add_psymbol_to_list): Move comment here and update
1682         it.
1683
1684 2019-09-29  Tom de Vries  <tdevries@suse.de>
1685
1686         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1687         Use $tmpdir/$(basename "$output_file").dwz instead of
1688         "${output_file}.dwz".
1689
1690 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1691
1692         PR gdb/25045
1693         * hppa-linux-nat.c: Include gdbarch.h.
1694
1695 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1696
1697         * blockframe.c (find_pc_partial_function): Change return type to bool.
1698         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1699         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1700         (stub_gnu_ifunc_resolve_name): Likewise.
1701         * symtab.c (compare_filenames_for_search): Likewise.
1702         (compare_glob_filenames_for_search): Likewise.
1703         (matching_obj_sections): Likewise.
1704         (symbol_matches_domain): Likewise.
1705         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1706         (find_line_pc): Change return type to bool.
1707         (find_line_pc_range): Likewise.
1708         (producer_is_realview): Likewise.
1709         * symtab.h (symbol_matches_domain): Likewise.
1710         (find_pc_partial_function): Likewise.
1711         (find_pc_line_pc_range): Likewise.
1712         (in_gnu_ifunc_stub): Likewise.
1713         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1714         (find_line_pc): Likewise.
1715         (find_line_pc_range): Likewise.
1716         (matching_obj_sections): Likewise.
1717         (find_line_symtab): Change out parameter to bool.
1718         (producer_is_realview): Change return type to bool.
1719         (compare_filenames_for_search): Likewise.
1720         (compare_glob_filenames_for_search): Likewise.
1721
1722 2019-09-26  Tom Tromey  <tom@tromey.com>
1723
1724         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1725         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1726         * gdb_usleep.h: Remove.
1727         * gdb_usleep.c: Remove.
1728         * utils.c: Don't include gdb_usleep.h.
1729
1730 2019-09-26  Tom Tromey  <tromey@adacore.com>
1731
1732         * python/py-type.c (type_to_type_object): Call check_typedef
1733         for stub types.
1734
1735 2019-09-26  Tom Tromey  <tom@tromey.com>
1736
1737         * utils.h (initialize_utils): Don't declare.
1738         * top.c (gdb_init): Don't call initialize_utils.
1739         * utils.c (initialize_utils): Remove.  Move contents...
1740         (_initialize_utils): ... here.
1741
1742 2019-09-25  Tom Tromey  <tom@tromey.com>
1743
1744         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1745         * utils.h (make_hex_string): Don't declare.
1746         * utils.c (make_hex_string): Remove.
1747
1748 2019-09-24  Tom de Vries  <tdevries@suse.de>
1749
1750         PR gdb/23815
1751         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1752         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1753
1754 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1755
1756         * NEWS: Mention new simulator port for PRU.
1757
1758 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1759
1760         * ada-exp.y (write_object_remaining): Update.
1761         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1762         and eliminate the static buffer.
1763         (ada_decode_symbol): Update.
1764         (ada_la_decode): Update.
1765         (ada_sniff_from_mangled_name): Update.
1766         (is_valid_name_for_wild_match): Update.
1767         (ada_lookup_name_info::matches): Update and simplify.
1768         (name_matches_regex): Update.
1769         (ada_add_global_exceptions): Update.
1770         * ada-lang.h (ada_decode): Update signature.
1771         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1772         * dwarf-index-write.c (debug_names::insert): Update.
1773
1774 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1775
1776         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1777         formatting.
1778
1779 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1780
1781         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1782         Change "nonzero" to "true" in documentation.
1783
1784 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1785
1786         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1787         (_initialize_darwin_solib): Don't set
1788         darwin_so_ops.lookup_lib_global_symbol.
1789         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1790         set_gdbarch_iterate_over_objfiles_in_search_order.
1791         (elf_lookup_lib_symbol): Rename to...
1792         (svr4_iterate_over_objfiles_in_search_order): this, and update
1793         to iterate semantics.
1794         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1795         * solib.c (solib_global_lookup): Remove.
1796         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1797         (solib_global_lookup): Remove.
1798         * symtab.c (lookup_global_or_static_symbol): Remove call to
1799         solib_global_lookup.
1800
1801 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1802
1803         * NEWS: Move entries about default MI version now being
1804         version 3, and about the GDB/MI fix for multi-location
1805         breakpoints to the "since GDB 8.3" section.
1806
1807 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1808
1809         GDB 8.3.1 released.
1810
1811 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1812
1813         * NEWS: Mention that Cell/B.E. debugging support was removed.
1814         * MAINTAINERS: Remove spu target.
1815
1816         * config/djgpp/fnchange.lst: Remove entries for removed files.
1817
1818         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1819         spu-multiarch.o, and spu-tdep.o.
1820         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1821         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1822         spu-multiarch.c, and spu-tdep.c.
1823         * spu-linux-nat.c: Remove file.
1824         * spu-multiarch.c: Remove file.
1825         * spu-tdep.c: Remove file.
1826         * spu-tdep.h: Remove file.
1827         * solib-spu.c: Remove file.
1828         * solib-spu.h: Remove file.
1829
1830         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1831         * configure.nat (spu-linux): Remove.
1832         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1833         solib-multiarch.o from gdb_target_obs.
1834         (spu*-*-*): Remove.
1835
1836         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1837         feature flag.
1838         (ppc_linux_no_features): Update.
1839         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1840         Cell/B.E. support.
1841         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1842         (tdesc_powerpc_cell64l): Likewise.
1843         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1844         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1845         Cell/B.E. support.
1846         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1847         Do not include "features/rs6000/powerpc-cell32l.c" or
1848         "features/rs6000/powerpc-cell64l.c".
1849         (ppc_linux_spu_section): Remove.
1850         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1851         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1852         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1853         (ppc_linux_spe_context_lookup): Remove.
1854         (ppc_linux_spe_context_inferior_created): Remove.
1855         (ppc_linux_spe_context_solib_loaded): Remove.
1856         (ppc_linux_spe_context_solib_unloaded): Remove.
1857         (ppc_linux_spe_context): Remove.
1858         (struct ppu2spu_cache): Remove.
1859         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1860         (struct ppu2spu_data): Remove.
1861         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1862         ppu2spu_unwind): Remove.
1863         (ppc_linux_init_abi): Remove Cell/B.E. support.
1864         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1865
1866         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1867         (rs6000/powerpc-cell64l-expedite): Likewise
1868         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1869         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1870         rs6000/powerpc-cell64l.xml.
1871         * features/rs6000/powerpc-cell32l.xml: Remove.
1872         * features/rs6000/powerpc-cell64l.xml: Likewise.
1873         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1874         * features/rs6000/powerpc-cell64l.c: Likewise.
1875         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1876         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1877         * regformats/reg-spu.dat: Remove.
1878
1879         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1880         * corelow.c (struct spuid_list): Remove.
1881         (add_to_spuid_list): Remove.
1882         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1883         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1884         (remote_protocol_features): Remove associated entries.
1885         (_initialize_remote): No longer initialize them.
1886         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1887         * linux-nat.c (SPUFS_MAGIC): Remove.
1888         (linux_proc_xfer_spu): Remove.
1889         (spu_enumerate_spu_ids): Remove.
1890         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1891         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1892         (linux_make_corefile_notes): No longer call it.
1893
1894         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1895         (cooked_write_test): Likewise.
1896
1897 2019-09-20  Tom Tromey  <tom@tromey.com>
1898
1899         * NEWS: Mention case-sensitivity of TUI commands.
1900         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1901         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1902         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1903
1904 2019-09-20  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-source.c (tui_source_window::set_contents): Use
1907         make_unique_xstrdup.
1908         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1909         make_unique_xstrdup.
1910
1911 2019-09-20  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-data.c: Remove separator comments.
1914         * tui/tui-layout.c: Remove separator comments.
1915         * tui/tui-win.c: Remove separator comments.
1916         * tui/tui-wingeneral.c: Remove separator comments.
1917
1918 2019-09-20  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui.h (strcat_to_buf): Don't declare.
1921         * tui/tui.c (strcat_to_buf): Remove.
1922
1923 2019-09-20  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1926         from "fullname".
1927         * tui/tui-source.c (tui_source_window::set_contents)
1928         (tui_source_window::location_matches_p)
1929         (tui_source_window::maybe_update): Update.
1930
1931 2019-09-20  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1934         Update.
1935         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1936         prefix.
1937         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1938         (tui_data_window::line_from_reg_element_no)
1939         (tui_data_window::first_reg_element_no_inline)
1940         (tui_data_window::show_registers)
1941         (tui_data_window::show_register_group)
1942         (tui_data_window::display_registers_from)
1943         (tui_data_window::display_registers_from_line)
1944         (tui_data_window::first_data_item_displayed)
1945         (tui_data_window::delete_data_content_windows)
1946         (tui_data_window::erase_data_content)
1947         (tui_data_window::do_scroll_vertical)
1948         (tui_data_window::refresh_window)
1949         (tui_data_window::check_register_values): Update.
1950
1951 2019-09-20  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1954         (struct tui_locator_window) <full_name, proc_name>: Now
1955         std::string.
1956         * tui/tui-stack.c (tui_locator_window::make_status_line)
1957         (tui_locator_window::set_locator_fullname)
1958         (tui_locator_window::set_locator_info): Update.
1959         * tui/tui-source.c (tui_source_window::set_contents)
1960         (tui_source_window::showing_source_p): Update.
1961
1962 2019-09-20  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1965         Don't call tui_locator_win_info_ptr.
1966
1967 2019-09-20  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1970
1971 2019-09-20  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1974         height for locator.
1975         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1976         * tui/tui-layout.c (show_source_disasm_command, show_data)
1977         (show_source_or_disasm_and_command): Use 1 as height for locator.
1978
1979 2019-09-20  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui.c (tui_enable): Update.
1982         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1983         Update.
1984         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1985         Update.
1986         * tui/tui-data.c (win_resized): Now bool.
1987         (tui_win_resized): Return bool.
1988         (tui_set_win_resized_to): Accept a bool.
1989
1990 2019-09-20  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1993         Change type of "refresh_values_only".
1994         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1995         type of "refresh_values_only".
1996
1997 2019-09-20  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2000         std::string.
2001         (tui_disassemble): Add "pos" parameter.
2002         (tui_disasm_window::set_contents): Simplify.
2003
2004 2019-09-20  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-winsource.h (struct tui_source_window_base)
2007         <show_source_content>: Now private.
2008         * tui/tui-winsource.c
2009         (tui_source_window_base::show_source_content): Don't handle empty
2010         content case.
2011
2012 2019-09-20  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-layout.c (show_source_disasm_command)
2015         (show_source_or_disasm_and_command): Don't call
2016         show_source_content.
2017
2018 2019-09-20  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2021         Declare.
2022         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2023         from tui_make_status_line.
2024         (tui_locator_window::rerender): Update.
2025
2026 2019-09-20  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2029         (tui_locator_window::rerender): Update.
2030
2031 2019-09-20  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-winsource.h (struct tui_source_window_base)
2034         <~tui_source_window_base>: Don't declare.
2035         <fullname>: Remove.
2036         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2037         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2038         member.
2039         * tui/tui-source.c (tui_source_window::set_contents): Update.
2040         (tui_source_window::location_matches_p)
2041         (tui_source_window::maybe_update): Update.
2042
2043 2019-09-20  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-winsource.h (~tui_source_element): Remove.
2046         (tui_source_element): Update.
2047         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2048         * tui/tui-winsource.c (tui_show_source_line): Update.
2049         * tui/tui-source.c (tui_source_window::set_contents): Update.
2050         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2051
2052 2019-09-20  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2055         declare.
2056         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2057         tui_clear_source_windows_detail.
2058         * tui/tui-winsource.h (struct tui_source_window_base)
2059         <clear_detail>: Don't declare.
2060         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2061         Remove.
2062         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2063
2064 2019-09-20  Tom Tromey  <tromey@adacore.com>
2065
2066         PR ada/24919:
2067         * block.c (contained_in): Fix final return value.
2068
2069 2019-09-20  Alan Modra  <amodra@gmail.com>
2070
2071         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2072         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2073         (read_indirect_string_from_dwz): Use bfd accessor.
2074         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2075         * machoread.c (macho_symfile_read_all_oso): Likewise.
2076         * solib.c (solib_bfd_open): Likewise.
2077
2078 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2079
2080         * eval.c: Move declaration of overload_resolution to...
2081         * value.h: ...here.
2082
2083 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2084
2085         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2086         * arm-linux-tdep.c: Likewise.
2087         * arm-nbsd-nat.c: Likewise.
2088         * arm-tdep.h: Declare arm_apcs_32.
2089         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2090
2091 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2092
2093         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2094         * dwarf2read.h: Declare dwarf_always_disassemble.
2095
2096 2019-09-19  Tom de Vries  <tdevries@suse.de>
2097
2098         PR gdb/25009
2099         * source-cache.c (source_cache::ensure): Catch exception thrown during
2100         construction of the highlighter.
2101
2102 2019-09-18  Alan Modra  <amodra@gmail.com>
2103
2104         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2105         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2106         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2107         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2108         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2109         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2110         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2111         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2112         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2113         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2114         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2115         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2116         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2117         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2118         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2119         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2120         * mi/mi-interp.c: Update throughout for bfd section macro and
2121         function changes.
2122         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2123         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2124
2125 2019-09-18  Tom Tromey  <tom@tromey.com>
2126
2127         * NEWS: Add entry.
2128         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2129         call rl_initialize.
2130         (tui_enable): Do not call rl_initialize.
2131
2132 2019-09-18  Christian Groessler  <chris@groessler.org>
2133
2134         * alpha-linux-nat.c: Include gdbarch.h.
2135
2136 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2137
2138         * ui-file.c: Include cli/cli-style.h.
2139         (term_cli_styling): Remove cli_styling declaration.
2140
2141 2019-09-18  Alan Modra  <amodra@gmail.com>
2142
2143         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2144         to bfd_asymbol_section.
2145
2146 2019-09-18  Alan Modra  <amodra@gmail.com>
2147
2148         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2149         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2150         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2151
2152 2019-09-18  Alan Modra  <amodra@gmail.com>
2153
2154         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2155         * spu-linux-nat.c (spu_bfd_open): Likewise.
2156
2157 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2158
2159         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2160         to bool to match definition in dwarf2read.c.
2161
2162 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2163
2164         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2165         (print_signatures): Likewise.
2166         (trust_pad_over_xvs): Likewise.
2167         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2168         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2169         * arm-linux-nat.c (arm_apcs_32): Likewise.
2170         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2171         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2172         * arm-tdep.c (arm_debug): Likewise.
2173         (arm_apcs_32): Likewise.
2174         * auto-load.c (debug_auto_load): Likewise.
2175         (auto_load_gdb_scripts): Likewise.
2176         (global_auto_load): Likewise.
2177         (auto_load_local_gdbinit): Likewise.
2178         (auto_load_local_gdbinit_loaded): Likewise.
2179         * auto-load.h (global_auto_load): Likewise.
2180         (auto_load_local_gdbinit): Likewise.
2181         (auto_load_local_gdbinit_loaded): Likewise.
2182         * breakpoint.c (disconnected_dprintf): Likewise.
2183         (breakpoint_proceeded): Likewise.
2184         (automatic_hardware_breakpoints): Likewise.
2185         (always_inserted_mode): Likewise.
2186         (target_exact_watchpoints): Likewise.
2187         (_initialize_breakpoint): Update.
2188         * breakpoint.h (target_exact_watchpoints): Change to bool.
2189         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2190         * cli/cli-cmds.c (trace_commands): Likewise.
2191         * cli/cli-cmds.h (trace_commands): Likewise.
2192         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2193         to bool*.
2194         * cli/cli-logging.c (logging_overwrite): Change to bool.
2195         (logging_redirect): Likewise.
2196         (debug_redirect): Likewise.
2197         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2198         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2199         to bool.
2200         <boolean_option_def>: Update.
2201         (struct flag_option_def): Change default type of Context to bool
2202         from int.
2203         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2204         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2205         (get_setshow_command_value_string): Likewise.
2206         * cli/cli-style.c (cli_styling): Change to bool.
2207         (source_styling): Likewise.
2208         * cli/cli-style.h (source_styling): Likewise.
2209         (cli_styling): Likewise.
2210         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2211         to bool.
2212         * command.h (var_types): Update comment.
2213         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2214         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2215         bool.
2216         (debug_compile_cplus_scopes): Likewise.
2217         * compile/compile-internal.h (compile_debug): Likewise.
2218         * compile/compile.c (compile_debug): Likewise.
2219         (struct compile_options) <raw>: Likewise.
2220         * cp-support.c (catch_demangler_crashes): Likewise.
2221         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2222         (usr_cmd_cris_dwarf2_cfi): Likewise.
2223         * csky-tdep.c (csky_debug): Likewise.
2224         * darwin-nat.c (enable_mach_exceptions): Likewise.
2225         * dcache.c (dcache_enabled_p): Likewise.
2226         * defs.h (info_verbose): Likewise.
2227         * demangle.c (demangle): Likewise.
2228         (asm_demangle): Likewise.
2229         * dwarf-index-cache.c (debug_index_cache): Likewise.
2230         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2231         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2232         * dwarf2read.c (check_physname): Likewise.
2233         (use_deprecated_index_sections): Likewise.
2234         (dwarf_always_disassemble): Likewise.
2235         * eval.c (overload_resolution): Likewise.
2236         * event-top.c (set_editing_cmd_var): Likewise.
2237         (exec_done_display_p): Likewise.
2238         * event-top.h (set_editing_cmd_var): Likewise.
2239         (exec_done_display_p): Likewise.
2240         * exec.c (write_files): Likewise.
2241         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2242         (debug_fbsd_nat): Likewise.
2243         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2244         Likewise.
2245         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2246         <backtrace_past_entry> Likewise.
2247         * gdb-demangle.h (demangle): Likewise.
2248         (asm_demangle): Likewise.
2249         * gdb_bfd.c (bfd_sharing): Likewise.
2250         * gdbcore.h (write_files): Likewise.
2251         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2252         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2253         * gdbthread.h (print_thread_events): Likewise.
2254         * gdbtypes.c (opaque_type_resolution): Likewise.
2255         (strict_type_checking): Likewise.
2256         * gnu-nat.c (gnu_debug_flag): Likewise.
2257         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2258         * guile/scm-param.c (pascm_variable): Add boolval.
2259         (add_setshow_generic): Update.
2260         (pascm_param_value): Update.
2261         (pascm_set_param_value_x): Update.
2262         * hppa-tdep.c (hppa_debug): Change to bool..
2263         * infcall.c (may_call_functions_p): Likewise.
2264         (coerce_float_to_double_p): Likewise.
2265         (unwind_on_signal_p): Likewise.
2266         (unwind_on_terminating_exception_p): Likewise.
2267         * infcmd.c (startup_with_shell): Likewise.
2268         * inferior.c (print_inferior_events): Likewise.
2269         * inferior.h (startup_with_shell): Likewise.
2270         (print_inferior_events): Likewise.
2271         * infrun.c (step_stop_if_no_debug): Likewise.
2272         (detach_fork): Likewise.
2273         (debug_displaced): Likewise.
2274         (disable_randomization): Likewise.
2275         (non_stop): Likewise.
2276         (non_stop_1): Likewise.
2277         (observer_mode): Likewise.
2278         (observer_mode_1): Likewise.
2279         (set_observer_mode): Update.
2280         (sched_multi): Change to bool.
2281         * infrun.h (debug_displaced): Likewise.
2282         (sched_multi): Likewise.
2283         (step_stop_if_no_debug): Likewise.
2284         (non_stop): Likewise.
2285         (disable_randomization): Likewise.
2286         * linux-tdep.c (use_coredump_filter): Likewise.
2287         (dump_excluded_mappings): Likewise.
2288         * linux-thread-db.c (auto_load_thread_db): Likewise.
2289         (check_thread_db_on_load): Likewise.
2290         * main.c (captured_main_1): Update.
2291         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2292         xx2_opt, boolean_opt>: Change to bool.
2293         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2294         * maint.c (maintenance_profile_p): Likewise.
2295         (per_command_time): Likewise.
2296         (per_command_space): Likewise.
2297         (per_command_symtab): Likewise.
2298         * memattr.c (inaccessible_by_default): Likewise.
2299         * mi/mi-main.c (mi_async): Likewise.
2300         (mi_async_1): Likewise.
2301         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2302         * nat/fork-inferior.h (startup_with_shell): Likewise.
2303         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2304         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2305         * nios2-tdep.c (nios2_debug): Likewise.
2306         * or1k-tdep.c (or1k_debug): Likewise.
2307         * parse.c (parser_debug): Likewise.
2308         * parser-defs.h (parser_debug): Likewise.
2309         * printcmd.c (print_symbol_filename): Likewise.
2310         * proc-api.c (procfs_trace): Likewise.
2311         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2312         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2313         (set_parameter_value): Update.
2314         (add_setshow_generic): Update.
2315         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2316         to bool*.
2317         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2318         int*.
2319         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2320         * record-btrace.c (record_btrace_target::store_registers): Update.
2321         * record-full.c (record_full_memory_query): Change to bool.
2322         (record_full_stop_at_limit): Likewise.
2323         * record-full.h (record_full_memory_query): Likewise.
2324         * remote-notif.c (notif_debug): Likewise.
2325         * remote-notif.h (notif_debug): Likewise.
2326         * remote.c (use_range_stepping): Likewise.
2327         (interrupt_on_connect): Likewise.
2328         (remote_break): Likewise.
2329         * ser-tcp.c (tcp_auto_retry): Likewise.
2330         * ser-unix.c (serial_hwflow): Likewise.
2331         * skip.c (debug_skip): Likewise.
2332         * solib-aix.c (solib_aix_debug): Likewise.
2333         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2334         (spu_auto_flush_cache_p): Likewise.
2335         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2336         Likewise.
2337         (struct info_print_options) <quiet>: Likewise.
2338         * symfile-debug.c (debug_symfile): Likewise.
2339         * symfile.c (auto_solib_add): Likewise.
2340         (separate_debug_file_debug): Likewise.
2341         * symfile.h (auto_solib_add): Likewise.
2342         (separate_debug_file_debug): Likewise.
2343         * symtab.c (basenames_may_differ): Likewise.
2344         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2345         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2346         (struct info_types_options) <quiet>: Likewise.
2347         * symtab.h (demangle): Likewise.
2348         (basenames_may_differ): Likewise.
2349         * target-dcache.c (stack_cache_enabled_1): Likewise.
2350         (code_cache_enabled_1): Likewise.
2351         * target.c (trust_readonly): Likewise.
2352         (may_write_registers): Likewise.
2353         (may_write_memory): Likewise.
2354         (may_insert_breakpoints): Likewise.
2355         (may_insert_tracepoints): Likewise.
2356         (may_insert_fast_tracepoints): Likewise.
2357         (may_stop): Likewise.
2358         (auto_connect_native_target): Likewise.
2359         (target_stop_and_wait): Update.
2360         (target_async_permitted): Change to bool.
2361         (target_async_permitted_1): Likewise.
2362         (may_write_registers_1): Likewise.
2363         (may_write_memory_1): Likewise.
2364         (may_insert_breakpoints_1): Likewise.
2365         (may_insert_tracepoints_1): Likewise.
2366         (may_insert_fast_tracepoints_1): Likewise.
2367         (may_stop_1): Likewise.
2368         * target.h (target_async_permitted): Likewise.
2369         (may_write_registers): Likewise.
2370         (may_write_memory): Likewise.
2371         (may_insert_breakpoints): Likewise.
2372         (may_insert_tracepoints): Likewise.
2373         (may_insert_fast_tracepoints): Likewise.
2374         (may_stop): Likewise.
2375         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2376         (make_thread_apply_all_options_def_group): Change argument from int*
2377         to bool*.
2378         (thread_apply_all_command): Update.
2379         (print_thread_events): Change to bool.
2380         * top.c (confirm): Likewise.
2381         (command_editing_p): Likewise.
2382         (history_expansion_p): Likewise.
2383         (write_history_p): Likewise.
2384         (info_verbose): Likewise.
2385         * top.h (confirm): Likewise.
2386         (history_expansion_p): Likewise.
2387         * tracepoint.c (disconnected_tracing): Likewise.
2388         (circular_trace_buffer): Likewise.
2389         * typeprint.c (print_methods): Likewise.
2390         (print_typedefs): Likewise.
2391         * utils.c (debug_timestamp): Likewise.
2392         (sevenbit_strings): Likewise.
2393         (pagination_enabled): Likewise.
2394         * utils.h (sevenbit_strings): Likewise.
2395         (pagination_enabled): Likewise.
2396         * valops.c (overload_resolution): Likewise.
2397         * valprint.h (struct value_print_options) <prettyformat_arrays,
2398         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2399         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2400         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2401         Likewise.
2402         * windows-nat.c (new_console): Likewise.
2403         (cygwin_exceptions): Likewise.
2404         (new_group): Likewise.
2405         (debug_exec): Likewise.
2406         (debug_events): Likewise.
2407         (debug_memory): Likewise.
2408         (debug_exceptions): Likewise.
2409         (useshell): Likewise.
2410         * windows-tdep.c (maint_display_all_tib): Likewise.
2411         * xml-support.c (debug_xml): Likewise.
2412
2413 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2414
2415         * source.c (prepare_path_for_appending): New function.
2416         (openp): Make use of new function.
2417         (find_and_open_source): Search for the compilation directory and
2418         source file as a relative path beneath the directory search path.
2419
2420 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * source-cache.c (source_cache::get_line_charpos): Catch
2423         exceptions and return false, this matches the behaviour documented
2424         in the header file.
2425
2426 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2427
2428         * ada-tasks.c (info_task): Remove quoting of the task's name.
2429
2430 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2431
2432         * symfile.c (auto_solib_add): Replace comment with a reference
2433         to the header file.
2434
2435 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2436
2437         * NEWS: Mention that gdb can now be compiled with Python 3
2438         on Windows.
2439
2440 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * maint.c (maint_print_section_data::maint_print_section_data):
2443         Force use of 'float log10 (float)' by casting the argument to
2444         float.
2445
2446 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2447
2448         * maint.c: Add 'cmath' include.
2449         (struct maint_print_section_data): New structure.
2450         (print_section_index): New function.
2451         (print_bfd_section_info): Add header comment, small whitespace
2452         cleanup, and update to call new print_section_index function.
2453         (print_objfile_section_info): Likewise.
2454         (maint_obj_section_from_bfd_section): New function.
2455         (print_bfd_section_info_maybe_relocated): New function.
2456         (maintenance_info_sections): Add header comment, always use
2457         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2458
2459 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2462         inner scope, add check that the objfile has psymtabs before
2463         checking psymtabs_addrmap.
2464         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2465
2466 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2467
2468         * NEWS: Announce that Ada task names are now shown at more places,
2469         and between quotes (except in info task output).
2470         * gdb/ada-tasks.c (task_to_str): New function.
2471         (display_current_task_id): Call task_to_str.
2472         (task_command_1): Likewise.
2473         (print_ada_task_info): In non-mi mode, Properly align headers and data
2474         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2475
2476 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2477
2478         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2479         prstatus.pr_lwp.pr_info instead of making it up.
2480
2481 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2482
2483         * auto-load.c (auto_load_expand_dir_vars): Update.
2484         * defs.h (gdb_datadir): Change to std::string.
2485         (python_libdir): Likewise.
2486         (relocate_gdb_directory): Change return type to std::string.
2487         * guile/guile.c (gdbscm_data_directory): Update.
2488         (initialize_scheme_side): Update.
2489         * jit.c (jit_reader_dir): Change to std::string.
2490         (jit_reader_load_command): Update.
2491         * main.c (gdb_datadir): Change to std::string.
2492         (python_libdir): Likewise.
2493         (set_gdb_data_directory): Update.
2494         (relocate_path): Change to return std::string.
2495         (relocate_gdb_directory): Change to return std::string.
2496         (relocate_gdbinit_path_maybe_in_datadir): Update.
2497         (captured_main_1): Update.
2498         * python/python.c (do_start_initialization): Update.
2499         * top.c (show_gdb_datadir): Update.
2500         * xml-syscall.c (xml_init_syscalls_info): Update.
2501         (init_syscalls_info): Update.
2502
2503 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2504
2505         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2506         out of get_init_files.
2507         (get_init_files): Update.
2508
2509 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2510
2511         * main.c (get_init_files): Change to use std::string.
2512         (captured_main_1): Update.
2513         (print_gdb_help): Update.
2514
2515 2019-09-11  Ali Tamur  <tamur@google.com>
2516
2517         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2518         implementation.
2519
2520 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2521
2522         * dbxread.c (read_dbx_symtab): Update.
2523         * dwarf2read.c (load_partial_dies): Update.
2524         * mdebugread.c (parse_partial_symbols): Update.
2525         (handle_psymbol_enumerators): Update.
2526         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2527         * psymtab.c (add_psymbol_to_bcache): Likewise.
2528         (add_psymbol_to_list): Likewise.
2529         * symtab.c (symbol_set_names): Likewise.
2530         * symtab.h (symbol_set_names): Likewise.
2531         * xcoffread.c (scan_xcoff_symtab): Update.
2532
2533 2019-09-11  Tom Tromey  <tom@tromey.com>
2534
2535         * symfile-mem.c (symbol_file_add_from_memory): Use
2536         bfd_set_filename.
2537         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2538         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2539
2540 2019-09-10  Tom Tromey  <tromey@adacore.com>
2541
2542         * dwarf-index-write.c (write_psymbols): Extend error message.
2543         (debug_names::insert): Add Ada code.
2544         (debug_names::write_psymbols): Remove Ada check.
2545         (debug_names) <m_string_obstack>: New member.
2546         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2547         (gdb_index_symbol_name_matcher::matches): Remove.
2548         (mapped_index_base::find_name_components_bounds): Add "lang"
2549         parameter.
2550         (mapped_index_base::build_name_components): Also split names
2551         according to Ada syntax.
2552         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2553         type of "match_callback".
2554         (check_match, check_find_bounds_finds)
2555         (dw2_expand_symtabs_matching): Update.
2556         (dw2_debug_names_iterator): Add new constructor.
2557         (dw2_debug_names_map_matching_symbols): New function.
2558         (dw2_debug_names_expand_symtabs_matching): Update.
2559         (dwarf2_debug_names_functions): Use
2560         dw2_debug_names_map_matching_symbols.
2561
2562 2019-09-10  Tom Tromey  <tromey@adacore.com>
2563
2564         * dwarf2read.c (dw2_get_file_names_reader): Add the
2565         CU's file name to the results.
2566
2567 2019-09-10  Tom Tromey  <tromey@adacore.com>
2568
2569         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2570         map_matching_symbols.  Update.
2571         * dwarf2read.c (dw2_map_matching_symbols): Update.
2572         * psymtab.c (match_partial_symbol): Change type; update.
2573         (psym_map_matching_symbols): Likewise.
2574         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2575         type; update.
2576         * symfile.h (struct quick_symbol_functions)
2577         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2578         Remove "match".
2579
2580 2019-09-10  Tom Tromey  <tromey@adacore.com>
2581
2582         * psymtab.c (map_block): Remove.
2583         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2584         * symtab.c (iterate_over_symbols_terminated): New function.
2585         * symtab.c (iterate_over_symbols_terminated): Declare.
2586
2587 2019-09-10  Tom Tromey  <tromey@adacore.com>
2588
2589         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2590         * language.h (struct language_defn) <la_iterate_over_symbols>:
2591         Return bool.
2592         * symtab.c (iterate_over_symbols): Return bool.
2593         * symtab.h (iterate_over_symbols): Return bool.
2594
2595 2019-09-10  Tom Tromey  <tromey@adacore.com>
2596
2597         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2598         (add_nonlocal_symbols): Update.
2599         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2600         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2601         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2602         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2603         Change type of "callback".  Remove "data".
2604
2605
2606 2019-09-09  Ali Tamur  <tamur@google.com>
2607
2608         * dwarf2read.c (comp_unit_head): Update comment.
2609         (dwarf2_dwo_name): New function declaration.
2610         (dwarf_unit_type_name): New function declaration.
2611         (read_comp_unit_head): Add support for new compilation units,
2612         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2613         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2614         (currently named as "signature") in their header. Also clarify error
2615         messages.
2616         (lookup_dwo_id): New function. Returns the dwo id of the given
2617         compile unit.
2618         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2619         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2620         functions.
2621         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2622         (dwarf2_dwo_name): Get the dwo name if present.
2623         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2624         purposes.
2625
2626 2019-09-09  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2629
2630 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2631
2632         * python/python.c (do_start_initialization): Make progname_copy static,
2633         to avoid a leak report.
2634
2635 2019-09-08  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2638
2639 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2640
2641         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2642         Change type to gdb::optional<block_enum>.
2643         (dw2_symtab_iter_init): Change block_index parameter type
2644         to gdb::optional<block_enum>.
2645         (dw2_lookup_symbol): Change block_index parameter
2646         type to block_enum.c
2647         (dw2_debug_names_lookup_symbol): Likewise.
2648         * psymtab.c (psym_lookup_symbol): Likewise.
2649         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2650         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2651         Likewise.
2652
2653 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2654
2655         * defs.h (relocate_gdb_directory): Change int to bool in
2656         signature and rename flag to relocatable.
2657         * main.c (relocate_path): Likewise.
2658         (relocate_gdb_directory): Likewise.
2659
2660 2019-09-06  Alan Modra  <amodra@gmail.com>
2661
2662         * coffread.c (coff_symfile_read): Constify filename variable.
2663         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2664         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2665         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2666         * solib.c (reload_shared_libraries_1): Likewise.
2667         * symfile.c (reread_symbols): Likewise.
2668         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2669         * solib-darwin.c (darwin_bfd_open): Likewise.
2670         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2671
2672 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2675         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2676
2677 2019-09-03  Tom Tromey  <tromey@adacore.com>
2678
2679         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2680         types.
2681         (has_negatives): Unbias a range type bound.
2682         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2683         * gdbtypes.c (operator==): Handle new field.
2684         (create_range_type): Add "bias" parameter.
2685         (create_static_range_type, resolve_dynamic_range): Update.
2686         * gdbtypes.h (struct range_bounds) <bias>: New member.
2687         (create_range_type): Add bias parameter.
2688         * printcmd.c (print_scalar_formatted): Unbias range types.
2689         * value.c (unpack_long): Unbias range types.
2690         (pack_long): Bias range types.
2691
2692 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2693
2694         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2695         probe arguments.
2696
2697 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2698
2699         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2700         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2701         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2702         (compile_probe_arg): Likewise.
2703         * probe.h (get_argument_count): Likewise.
2704         * solib-svr4.c (solib_event_probe_action): Likewise.
2705         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2706
2707 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2708
2709         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2710         code to here...
2711         (svr4_create_solib_event_breakpoints): ...from here.
2712
2713 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2714
2715         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2716         suffix from warning message.
2717
2718 2019-08-30  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-winsource.h (struct tui_source_window_base)
2721         <refresh_all>: Don't declare.
2722         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2723         Remove.
2724         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2725         tui_show_locator_content.
2726         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2727         declare.
2728         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2729         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2730         declare.
2731
2732 2019-08-30  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2735
2736 2019-08-30  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2739         Remove unnecessary forward declarations.
2740
2741 2019-08-30  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2744         rerender.
2745         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2746         tui_show_locator_content.
2747
2748 2019-08-30  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2751         (tui_locator_window::rerender): Rewrite using body of previous
2752         tui_show_locator_content.
2753
2754 2019-08-30  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2757         set_locator_fullname>: New methods.
2758         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2759         Rename from tui_set_locator_fullname.
2760         (tui_locator_window::set_locator_info): Rename from
2761         tui_set_locator_info.  Return bool.
2762         (tui_update_locator_fullname, tui_show_frame_info): Update.
2763
2764 2019-08-30  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2767
2768 2019-08-30  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2771         call touchwin.
2772
2773 2019-08-30  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-wingeneral.c (box_win): Assume win_info and
2776         win_info->handle cannot be NULL.
2777
2778 2019-08-30  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2781         refresh_window>: Declare.
2782         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2783         resize.
2784         (tui_data_item_window::rerender): Rename from
2785         tui_display_register.
2786         (tui_data_item_window::refresh_window): New method.
2787         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2788         no-op.
2789
2790 2019-08-30  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2793         regs_column_count, current_group>: Move later.  Now private.
2794         <get_current_group>: New method.
2795         * tui/tui-regs.c (tui_reg_command): Update.
2796         * tui/tui-layout.c (tui_set_layout): Update.
2797
2798 2019-08-30  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2801         (tui_data_window::rerender): Don't call
2802         check_and_display_highlight_if_needed.
2803         (tui_data_window::refresh_all): Remove call to
2804         erase_data_content.
2805
2806 2019-08-30  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2809         (tui_data_window::display_registers_from)
2810         (tui_data_window::display_reg_element_at_line)
2811         (tui_data_window::display_registers_from_line): Remove checks of
2812         "empty".
2813
2814 2019-08-30  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2817         Don't declare.
2818         * tui/tui-regs.c (tui_data_window::show_registers): Call
2819         rerender.
2820         (tui_data_window::rerender): Rename from display_all_data.
2821         (tui_data_window::rerender): Remove old implementation.
2822
2823 2019-08-30  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2826         text.
2827         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2828
2829 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2830             Sergio Durigan Junior  <sergiodj@redhat.com>
2831
2832         PR win32/24284
2833         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2834
2835 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2838         when searching for types.
2839
2840 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * f-lang.c (f_language_defn): Use f_print_typedef.
2843         * f-lang.h (f_print_typedef): Declare.
2844         * f-typeprint.c (f_print_typedef): Define.
2845
2846 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2847
2848         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2849
2850 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * cli/cli-utils.c (info_print_options_defs): Delete.
2853         (make_info_print_options_def_group): Delete.
2854         (extract_info_print_options): Delete.
2855         (info_print_command_completer): Delete.
2856         (info_print_args_help): Add extra parameter, and optionally
2857         include text about -n flag.
2858         * cli/cli-utils.h (struct info_print_options): Delete.
2859         (extract_info_print_options): Delete declaration.
2860         (info_print_command_completer): Delete declaration.
2861         (info_print_args_help): Add extra parameter, extend header
2862         comment.
2863         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2864         search_symbols.
2865         * stack.c (struct info_print_options): New type.
2866         (info_print_options_defs): New file scoped variable.
2867         (make_info_print_options_def_group): New static function.
2868         (info_print_command_completer): New static function.
2869         (info_locals_command): Update to use new local functions.
2870         (info_args_command): Likewise.
2871         (_initialize_stack): Add extra parameter to calls to
2872         info_print_args_help.
2873         * symtab.c (search_symbols): Add extra parameter, use this to
2874         possibly excluse non-debug symbols.
2875         (symtab_symbol_info): Add extra parameter, which is passed on to
2876         search_symbols.
2877         (struct info_print_options): New type.
2878         (info_print_options_defs): New file scoped variable.
2879         (make_info_print_options_def_group): New static function.
2880         (info_print_command_completer): New static function.
2881         (info_variables_command): Update to use local functions, and pass
2882         extra parameter through to symtab_symbol_info.
2883         (info_functions_command): Likewise.
2884         (info_types_command): Pass additional argument through to
2885         symtab_symbol_info.
2886         (rbreak_command): Pass extra argument to search_symbols.
2887         (_initialize_symtab): Add extra arguments for calls to
2888         info_print_args_help, and update help text for 'info variables',
2889         'whereis', and 'info functions' commands.
2890         * symtab.h (search_symbols): Add extra argument to declaration.
2891         * NEWS: Mention new flags.
2892
2893 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2894
2895         * symtab.c (lookup_static_symbol): Call the new function (and move
2896         it down to be next to lookup_global_symbol).
2897         (struct global_sym_lookup_data): Add block_enum member and rename to...
2898         (struct global_or_static_sym_lookup_data): ...this.
2899         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2900         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2901         (lookup_symbol_global_or_static_iterator_cb): ...this.
2902         (lookup_global_or_static_symbol): New function.
2903         (lookup_global_symbol): Call new function.
2904
2905 2019-08-26  Tom de Vries  <tdevries@suse.de>
2906
2907         PR c++/24852
2908         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2909         when pc_probe.prob == NULL.
2910
2911 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2912
2913         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2914         variable symbol_linkage to symbol_linkage_.
2915
2916 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2917
2918         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2919         represent whether the symbol is static, dynamic, or we don't
2920         know.
2921
2922 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2923
2924         * gdb/rx-tdep.c (rx_register_names): New.
2925         (rx_register_name): Delete.
2926         (rx_psw_type): Delete.
2927         (rx_fpsw_type): Delete.
2928         (rx_register_type): Delete.
2929         (rx_gdbarch_init): Convert target-descriptions.
2930         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2931         * gdb/features/Makefile: Add rx.xml.
2932         * gdb/features/rx.xml: New.
2933         * gdb/features/rx.c: Generated.
2934         * gdb/NEWS: Mention target description support.
2935
2936 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2937
2938         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2939         *slot_ptr.
2940
2941 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2942
2943         * configure.ac: Don't check for 'dlfcn.h' (moved to
2944         gdbsupport/common.m4).
2945         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2946         'gdbsupport/'.
2947         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2948         * compile/compile-c-support.c: Include
2949         'gdbsupport/gdb-dlfcn.h'.
2950         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2951         * gdb-dlfcn.c: Move to...
2952         * gdbsupport/gdb-dlfcn.c: ... here.
2953         * gdb-dlfcn.h: Move to...
2954         * gdbsupport/gdb-dlfcn.h: ... here.
2955
2956 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2957
2958         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2959         the offset field signed.
2960
2961 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2962
2963         * python/lib/gdb/__init__.py (_execute_file): New function.
2964         * python/python.c (python_run_simple_file): Call gdb._execute_file
2965         on Windows.
2966
2967 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2970         all uses as this was never set to anything but a zero value.
2971
2972 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2973
2974         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2975
2976 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2977
2978         * tui/tui-data.h (tui_gen_win_info): Add an =default
2979         move constructor, required by some GCC versions.
2980
2981 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2982
2983         * go32-nat.c (go32_sysinfo): Add hygon_p.
2984
2985 2019-08-20  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2988         line_from_reg_element_no, first_reg_element_no_inline,
2989         display_all_data, delete_data_content_windows,
2990         erase_data_content>: Now private.
2991
2992 2019-08-20  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2995         (tui_unhighlight_win, tui_highlight_win)
2996         (tui_win_info::make_window): Update.
2997         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2998
2999 2019-08-20  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3002         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3003         (MAX_PID_WIDTH): Move to tui-stack.c.
3004         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3005         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3006         (MAX_PID_WIDTH): Move from tui-data.h.
3007
3008 2019-08-20  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3011         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3012         (box_win): Update.
3013         (tui_gen_win_info::make_window): Rename from tui_make_window.
3014         (tui_win_info::make_window): New method.
3015         (tui_gen_win_info::make_visible): Update.
3016         * tui/tui-source.c (tui_source_window::set_contents): Update.
3017         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3018         (tui_data_window::display_registers_from): Update.
3019         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3020         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3021         Declare.
3022         <can_box>: Remove.
3023         <title>: Remove.
3024         (struct tui_win_info) <make_window>: Declare.
3025         <can_box>: Now virtual.
3026         <title>: New member.
3027         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3028         * tui/tui-command.c (tui_cmd_window::resize): Update.
3029
3030 2019-08-20  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3033         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3034         (tui_data_window::check_register_values): Update.
3035
3036 2019-08-20  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-regs.h (struct tui_data_window): Use
3039         DISABLE_COPY_AND_ASSIGN.
3040         <regs_content>: Change type, removing unique_ptr.
3041         <tui_data_window>: Add move constructor.
3042         * tui/tui-regs.c (tui_data_window::show_registers)
3043         (tui_data_window::show_register_group)
3044         (tui_data_window::display_registers_from)
3045         (tui_data_window::display_registers_from)
3046         (tui_data_window::first_data_item_displayed)
3047         (tui_data_window::delete_data_content_windows)
3048         (tui_data_window::rerender, tui_data_window::refresh_window)
3049         (tui_data_window::check_register_values): Update.
3050
3051 2019-08-20  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3054         show_register_group>: Declare.
3055         (tui_show_register_group): Don't declare.
3056         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3057         tui_show_registers.
3058         (tui_data_window::show_register_group): Rename from
3059         tui_show_register_group.
3060         (tui_data_window::check_register_values, tui_reg_command):
3061         Update.
3062         * tui/tui-layout.c (tui_set_layout): Update.
3063
3064 2019-08-20  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3067         Declare.
3068         (tui_check_register_values): Don't declare.
3069         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3070         from tui_check_register_values.
3071         * tui/tui-hooks.c (tui_register_changed): Update.
3072
3073 2019-08-20  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-regs.c (tui_reg_layout): Move later.
3076         (tui_show_registers): Don't enable TUI mode or change layout.
3077
3078 2019-08-20  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-regs.h (struct tui_data_item_window)
3081         <~tui_data_item_window>: Remove.
3082         <content>: Now a unique_xmalloc_ptr.
3083         * tui/tui-regs.c (tui_register_format): Return a
3084         unique_xmalloc_ptr.
3085         (tui_get_register): Update.
3086         (~tui_data_item_window): Remove.
3087         (tui_data_window::display_registers_from, tui_display_register):
3088         Update.
3089         * tui/tui-io.h (tui_expand_tabs): Update.
3090         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3091         Remove "col" parameter.
3092
3093 2019-08-20  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3096         field.
3097         * tui/tui-regs.c (~tui_data_item_window): Update.
3098
3099 2019-08-20  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3102         earlier.
3103
3104 2019-08-20  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3107
3108 2019-08-20  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-source.h (struct tui_source_window): Update.
3111         * tui/tui-regs.c (tui_show_registers): Update.
3112         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3113         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3114         (NO_REGS_STRING): Remove defines.
3115
3116 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3117
3118         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3119         unnecessary thread walk if remote doesn't support the packet.
3120
3121 2019-08-19  Tom Tromey  <tromey@adacore.com>
3122
3123         * python/py-value.c (value_has_field): Fix indentation.
3124
3125 2019-08-19  Tom Tromey  <tromey@adacore.com>
3126
3127         * printcmd.c (do_one_display, info_display_command): Update.
3128         * block.h (contained_in): Return bool.  Add allow_nested
3129         parameter.
3130         * block.c (contained_in): Return bool.  Add allow_nested
3131         parameter.
3132
3133 2019-08-19  Tom Tromey  <tom@tromey.com>
3134
3135         * configure: Rebuild.
3136         * configure.ac: Disallow the combination of -static-libstdc++ and
3137         source highlight.
3138         * source-cache.c (get_language_name): Handle rust.
3139         (source_cache::get_source_lines): Ignore highlighting exceptions.
3140
3141 2019-08-16  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3144         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3145         (struct tui_source_window_base) <make_visible, refresh_window,
3146         resize>: Remove methods.
3147         <execution_info>: Remove field.
3148         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3149         (tui_show_source_line, tui_source_window_base)
3150         (~tui_source_window_base): Update.
3151         (tui_source_window_base::resize)
3152         (tui_source_window_base::make_visible)
3153         (tui_source_window_base::refresh_window): Remove.
3154         (tui_source_window_base::update_exec_info): Update.
3155         * tui/tui-source.c (tui_source_window::set_contents): Update.
3156         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3157
3158 2019-08-16  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3161         deprecated_query_hook.
3162
3163 2019-08-16  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3166         (tui_update_source_windows_with_line): Update.
3167         * tui/tui-source.h (struct tui_source_window)
3168         <show_symtab_source>: Declare.
3169         (tui_show_symtab_source): Don't declare.
3170         * tui/tui-source.c (tui_show_symtab_source): Rename from
3171         tui_show_symtab_source.
3172
3173 2019-08-16  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-winsource.h (struct tui_source_window_base)
3176         <set_contents>: Declare.
3177         * tui/tui-winsource.c
3178         (tui_source_window_base::update_source_window_as_is): Update.
3179         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3180         Declare.
3181         (tui_set_source_content): Don't declare.
3182         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3183         tui_set_source_content.
3184         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3185         Declare.
3186         (tui_set_disassem_content): Don't declare.
3187         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3188         tui_set_disassem_content.
3189
3190 2019-08-16  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-winsource.h (struct tui_source_window_base)
3193         <update_breakpoint_info>: Declare.
3194         (tui_update_breakpoint_info): Don't declare.
3195         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3196         (tui_update_all_breakpoint_info): Update.
3197         (tui_source_window_base::update_breakpoint_info): Rename from
3198         tui_update_breakpoint_info.
3199         (tui_source_window_base::update_exec_info): Update.
3200
3201 2019-08-16  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-winsource.h (struct tui_source_window_base)
3204         <update_source_window>: Declare.
3205         (tui_update_source_window): Don't declare.
3206         * tui/tui-winsource.c
3207         (tui_source_window_base::update_source_window): Rename from
3208         tui_update_source_window.
3209         (tui_source_window_base::rerender): Update.
3210         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3211         * tui/tui-disasm.c (tui_show_disassem)
3212         (tui_show_disassem_and_update_source)
3213         (tui_disasm_window::maybe_update): Update.
3214
3215 2019-08-16  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.h (struct tui_source_window_base)
3218         <update_source_window_as_is>: Declare.
3219         (tui_update_source_window_as_is): Don't declare.
3220         * tui/tui-winsource.c (tui_update_source_window): Update
3221         (tui_source_window_base::update_source_window_as_is): Rename from
3222         tui_update_source_window_as_is.
3223         (tui_source_window_base::refill): Update.
3224         * tui/tui-source.c (tui_show_symtab_source): Update.
3225         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3226         Update.
3227
3228 2019-08-16  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-winsource.h (tui_update_source_window)
3231         (tui_update_source_window_as_is): Remove "noerror" parameter.
3232         * tui/tui-winsource.c (tui_update_source_window)
3233         (tui_update_source_window_as_is): Remove "noerror" parameter.
3234         (tui_update_source_windows_with_addr)
3235         (tui_update_source_windows_with_line)
3236         (tui_source_window_base::rerender)
3237         (tui_source_window_base::refill): Update.
3238         * tui/tui-source.h (tui_set_source_content)
3239         (tui_show_symtab_source): Remove "noerror" parameter.
3240         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3241         parameter.
3242         (tui_show_symtab_source): Likewise.
3243         (tui_source_window::maybe_update): Update.
3244         * tui/tui-disasm.c (tui_show_disassem)
3245         (tui_show_disassem_and_update_source)
3246         (tui_disasm_window::do_scroll_vertical)
3247         (tui_disasm_window::maybe_update): Update.
3248
3249 2019-08-16  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui.c (tui_is_window_visible): Update.
3252         * tui/tui-wingeneral.c (tui_make_window)
3253         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3254         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3255         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3256         (tui_set_win_height_command, parse_scrolling_args): Update.
3257         * tui/tui-source.c (tui_source_window::style_changed): Update.
3258         * tui/tui-regs.c (tui_show_registers)
3259         (tui_data_window::first_data_item_displayed)
3260         (tui_data_window::delete_data_content_windows)
3261         (tui_check_register_values, tui_reg_command): Update.
3262         * tui/tui-disasm.c (tui_show_disassem): Update.
3263         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3264         method.
3265         <is_visible>: Remove field.
3266         * tui/tui-data.c (tui_next_win, tui_prev_win)
3267         (tui_delete_invisible_windows): Update.
3268
3269 2019-08-16  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-winsource.h (struct tui_source_window_base)
3272         <m_has_locator>: Remove.
3273         * tui/tui-layout.c (show_source_disasm_command, show_data)
3274         (show_source_or_disasm_and_command): Update.
3275
3276 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3277
3278         * NEWS (Other MI changes): New subsection.
3279         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3280         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3281         * arch-utils.c (default_get_pc_address_flags): New function.
3282         * arch-utils.h (default_get_pc_address_flags): New declaration.
3283         * gdbarch.sh: Add get_pc_address_flags.
3284         * gdbarch.c: Regenerate.
3285         * gdbarch.h: Likewise.
3286         * stack.c (print_pc): New function.
3287         (print_frame_info) (print_frame): Call print_pc.
3288
3289 2019-08-16  Tom de Vries  <tdevries@suse.de>
3290
3291         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3292         print_objfile_section_info.
3293
3294 2019-08-15  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3297         calling update_cmdwin_start_line.
3298         * tui/tui-winsource.h (struct tui_source_window_base)
3299         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3300         <rerender>: Declare.
3301         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3302         Call rerender.
3303         (tui_source_window_base::set_new_height): Remove.
3304         (tui_source_window_base::rerender): Rename from
3305         do_make_visible_with_new_height.
3306         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3307         resize method.
3308         (tui_win_info::make_invisible_and_set_new_height)
3309         (tui_win_info::make_visible_with_new_height): Remove.
3310         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3311         Declare.
3312         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3313         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3314         do_make_visible_with_new_height>: Don't declare.
3315         <rerender>: Declare.
3316         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3317         set_new_height.
3318         (tui_data_window::do_make_visible_with_new_height): Remove.
3319         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3320         call tui_show_locator_content.
3321         (tui_gen_win_info::resize): Call rerender.
3322         (show_source_or_disasm_and_command): Don't call
3323         tui_show_locator_content.
3324         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3325         method.
3326         (struct tui_win_info) <rerender>: Declare.
3327         <set_new_height, make_invisible_and_set_new_height,
3328         make_visible_with_new_height>: Don't declare.
3329         * tui/tui-data.c (tui_win_list::rerender): New method.
3330         * tui/tui-command.h (struct tui_cmd_window)
3331         <do_make_visible_with_new_height>: Don't declare.
3332         * tui/tui-command.c
3333         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3334
3335 2019-08-15  Tom Tromey  <tromey@adacore.com>
3336
3337         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3338         * ada-lang.c (ada_enum_name): Likewise.
3339
3340 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3341
3342         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3343         leading underscore.
3344         (GdbOutputErrorFile): Likewise.
3345         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3346         accordingly.
3347         (execute_unwinders): Rename to have a leading underscore.
3348         (auto_load_packages): Likewise.
3349         (global scope): Adjust call to auto_load_packages accordingly.
3350         (GdbSetPythonDirectory): Likewise.
3351         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3352         instead of execute_unwinders.
3353
3354 2019-08-15  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3357         (show_data): Don't change window visibility.
3358         (tui_gen_win_info::resize): Remove special case for command
3359         window.  Use wresize, when available.
3360         (show_source_or_disasm_and_command): Don't change window
3361         visibility.
3362         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3363         <make_visible>: New method.
3364         * tui/tui-command.c (tui_cmd_window::resize): New method.
3365
3366 2019-08-15  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3369         (struct tui_source_windows): New.
3370         * tui/tui-winsource.c (tui_display_main): Update.
3371         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3372         (new_height_ok, parse_scrolling_args): Update.
3373         * tui/tui-layout.c (show_layout, show_data): Update.
3374         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3375         (tui_add_to_source_windows): Don't declare.
3376         * tui/tui-data.c (source_windows, tui_source_windows)
3377         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3378
3379 2019-08-15  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3382         Rename from reset.
3383         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3384         * tui/tui-layout.c (show_source_disasm_command, show_data):
3385         Update.
3386         (tui_gen_win_info::resize): Rename.
3387         (show_source_or_disasm_and_command): Update.
3388         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3389         reset.
3390
3391 2019-08-15  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3394         * tui/tui-interp.c (tui_interp::init): Don't call
3395         tui_initialize_static_data.
3396         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3397
3398 2019-08-15  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3401         examine tui_win_list.
3402
3403 2019-08-15  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3406         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3407         tui_clear_source_content.
3408         (tui_clear_source_content): Remove.
3409         (tui_source_window_base::do_erase_source_content): Hoist call to
3410         content.clear().
3411         * tui/tui-stack.c (tui_show_frame_info): Don't call
3412         tui_clear_source_content.
3413
3414 2019-08-15  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-winsource.h (struct tui_source_window_base)
3417         <do_erase_source_content>: New method.
3418         <erase_source_content>: New method.
3419         (tui_erase_source_content): Don't declare.
3420         * tui/tui-winsource.c (tui_clear_source_content): Update.
3421         (tui_source_window_base::do_erase_source_content): Rename from
3422         tui_erase_source_content.
3423         (tui_source_window_base::show_source_content): Update.
3424         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3425         * tui/tui-source.h (struct tui_source_window)
3426         <erase_source_content>: New method.
3427         * tui/tui-disasm.h (struct tui_disasm_window)
3428         <erase_source_content>: New method.
3429
3430 2019-08-15  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3433         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3434         constructor.
3435         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3436         * tui/tui-source.c (tui_set_source_content): Update.
3437         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3438
3439 2019-08-15  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3442         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3443         tui-source.c.
3444         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3445         Declare.
3446         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3447         method.
3448         (tui_source_window::maybe_update): Update.
3449
3450 2019-08-15  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3453         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3454         tui-disasm.c.
3455         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3456         Declare.
3457         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3458         method.
3459         (tui_disasm_window::maybe_update): Update.
3460
3461 2019-08-15  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-winsource.h (struct tui_source_window_base)
3464         <maybe_update>: Declare.
3465         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3466         method.
3467         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3468         Declare.
3469         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3470         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3471         Declare.
3472         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3473
3474 2019-08-15  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3477
3478 2019-08-15  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-wingeneral.c: Include tui-stack.h.
3481         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3482         (struct tui_locator_window): Move from tui-data.h.
3483         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3484         (tui_initialize_static_data): Move from tui-data.c.
3485         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3486         (struct tui_locator_window): Move to tui-stack.c.
3487         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3488         (tui_initialize_static_data): Move to tui-stack.c.
3489
3490 2019-08-15  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-layout.c (show_source_disasm_command)
3493         (show_source_or_disasm_and_command): Use make_visible method, not
3494         tui_make_window.
3495         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3496         Remove.
3497
3498 2019-08-15  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-wingeneral.h (tui_make_window): Update.
3501         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3502         parameter.
3503         (tui_gen_win_info::make_visible): Update.
3504         * tui/tui-regs.c (tui_data_window::display_registers_from):
3505         Update.
3506         * tui/tui-layout.c (show_source_disasm_command)
3507         (show_source_or_disasm_and_command): Update.
3508         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3509         (enum tui_box): Remove.
3510         (struct tui_win_info) <can_box>: New method.
3511         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3512         method.
3513
3514 2019-08-15  Tom de Vries  <tdevries@suse.de>
3515
3516         * linux-nat-trad.c: Include gdbarch.h.
3517
3518 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3519
3520         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3521         register sizes.
3522
3523 2019-08-14  Tom Tromey  <tromey@adacore.com>
3524
3525         * darwin-nat.c: Include gdbarch.h.
3526         * darwin-nat-info.c: Include gdbarch.h.
3527
3528 2019-08-13  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3531         Remove.
3532         * tui/tui-data.c (tui_initialize_static_data): Update.
3533
3534 2019-08-13  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-winsource.h (struct tui_exec_info_window)
3537         <~tui_exec_info_window, maybe_allocate_content, get_content,
3538         m_content>: Remove.
3539         (struct tui_source_window_base) <set_exec_info_content,
3540         show_exec_info_content>: Don't declare.
3541         * tui/tui-winsource.c
3542         (tui_exec_info_window::maybe_allocate_content): Remove.
3543         (tui_source_window_base::update_exec_info): Rename from
3544         set_exec_info_content.
3545         (tui_source_window_base::show_exec_info_content)
3546         (tui_source_window_base::update_exec_info): Remove.
3547
3548 2019-08-13  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3551         declare.
3552         * tui/tui-winsource.c (tui_update_source_window_as_is)
3553         (tui_update_source_windows_with_addr, tui_erase_source_content):
3554         Update.
3555         (tui_clear_exec_info_content): Remove.
3556
3557 2019-08-13  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3560         declare.
3561         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3562         call tui_erase_exec_info_content.
3563         (tui_clear_exec_info_content): Rename from
3564         tui_erase_exec_info_content.
3565         (tui_clear_exec_info_content): Delete.
3566
3567 2019-08-13  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-winsource.h (struct tui_source_window_base)
3570         <show_exec_info_content>: Declare.
3571         (tui_show_exec_info_content): Don't declare.
3572         * tui/tui-winsource.c
3573         (tui_source_window_base::show_exec_info_content): Rename from
3574         tui_show_exec_info_content.
3575         (tui_source_window_base::update_exec_info): Update.
3576
3577 2019-08-13  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3580         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3581         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3582         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3583         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3584         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3585         ... here.
3586
3587 2019-08-13  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-winsource.h (struct tui_source_window_base)
3590         <update_exec_info>: Declare.
3591         (tui_update_exec_info): Don't declare.
3592         * tui/tui-winsource.c (tui_update_source_window_as_is)
3593         (tui_source_window_base::refresh_all)
3594         (tui_update_all_breakpoint_info): Update.
3595         (tui_source_window_base::update_exec_info): Rename from
3596         tui_update_exec_info.
3597         * tui/tui-stack.c (tui_show_frame_info): Update.
3598
3599 2019-08-13  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-winsource.h (struct tui_source_window_base)
3602         <set_exec_info_content>: Declare.
3603         (tui_set_exec_info_content): Don't declare.
3604         * tui/tui-winsource.c
3605         (tui_source_window_base::set_exec_info_content): Rename from
3606         tui_set_exec_info_content.
3607         (tui_update_exec_info): Update.
3608
3609 2019-08-13  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-winsource.h (struct tui_source_window_base)
3612         <show_source_content>: Declare.
3613         (tui_show_source_content): Don't declare.
3614         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3615         (tui_source_window_base::show_source_content): Rename from
3616         tui_show_source_content.
3617         (tui_source_window_base::refresh_all): Update.
3618         * tui/tui-layout.c (show_source_disasm_command)
3619         (show_source_or_disasm_and_command): Update.
3620
3621 2019-08-13  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-winsource.c (tui_erase_source_content)
3624         (tui_show_source_content, tui_source_window_base::refresh_all):
3625         Update.
3626         * tui/tui-wingeneral.h
3627         (tui_check_and_display_highlight_if_needed): Don't declare.
3628         * tui/tui-wingeneral.c
3629         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3630         check_and_display_highlight_if_needed.
3631         * tui/tui-win.c (tui_rehighlight_all)
3632         (tui_win_info::make_visible_with_new_height): Update.
3633         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3634         (tui_data_window::erase_data_content)
3635         (tui_data_window::display_all_data): Update.
3636         * tui/tui-data.h (struct tui_win_info)
3637         <check_and_display_highlight_if_needed>: Declare.
3638
3639 2019-08-13  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-win.c (tui_resize_all): Call
3642         tui_delete_invisible_windows.
3643         * tui/tui-layout.c (show_layout): Call
3644         tui_delete_invisible_windows.
3645         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3646         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3647
3648 2019-08-13  Tom Tromey  <tom@tromey.com>
3649
3650         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3651         tui_add_win_to_layout.
3652
3653 2019-08-13  Tom Tromey  <tom@tromey.com>
3654
3655         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3656         * tui/tui-layout.c (tui_default_win_height): Now static.
3657
3658 2019-08-13  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3661         single switch.
3662         (show_source_disasm_command, show_source_or_disasm_and_command):
3663         Don't check current layout.
3664
3665 2019-08-13  Tom Tromey  <tom@tromey.com>
3666
3667         * tui/tui-wingeneral.c (make_all_visible): Remove.
3668         (tui_make_all_invisible): Simplify.
3669         * tui/tui-layout.c (tui_make_all_invisible): Move from
3670         tui-wingeneral.c; simplify.
3671         (show_layout): Hoist call to tui_make_all_invisible.
3672         (show_data): Don't call tui_make_all_invisible.
3673
3674 2019-08-13  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3677         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3678
3679 2019-08-13  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3682         tui-data.c.
3683         (show_source_disasm_command, show_data)
3684         (show_source_or_disasm_and_command): Don't use
3685         tui_set_current_layout_to.
3686         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3687         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3688         tui-layout.c.
3689         (tui_set_current_layout_to): Remove.
3690
3691 2019-08-13  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-layout.c (tui_set_layout): Update.
3694         * tui/tui-data.h (struct tui_layout_def): Remove.
3695         (tui_layout_def): Don't declare.
3696         * tui/tui-data.c (layout_def): Remove.
3697         (tui_layout_def): Remove.
3698
3699 2019-08-13  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.h (struct tui_source_window_base)
3702         <clear_detail>: No longer "override".
3703         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3704         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3705         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3706         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3707         Remove.
3708         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3709
3710 2019-08-13  Tom Tromey  <tromey@adacore.com>
3711
3712         * tracepoint.c: Don't include readline.h or history.h.
3713
3714 2019-08-12  Tom Tromey  <tom@tromey.com>
3715
3716         * configure: Rebuild.
3717         * configure.ac: Check for readline 7.
3718         * NEWS: Mention readline 7 requirement.
3719         * README: Update.
3720
3721 2019-08-12  Tom Tromey  <tom@tromey.com>
3722
3723         * mingw-hdep.c (gdb_select): Remove readline hack.
3724
3725 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3726
3727         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3728         when the function fails.
3729
3730 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3731
3732         * s390-tdep.c (s390_type_align): New function.
3733         (s390_gdbarch_init): Set it as type_align gdbarch method.
3734
3735 2019-08-09  Tom de Vries  <tdevries@suse.de>
3736
3737         PR gdb/24591
3738         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3739         pc_low with relocation offset.
3740
3741 2019-08-07  Tom Tromey  <tromey@adacore.com>
3742
3743         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3744         (print_frame_args): Update.
3745         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3746         Update.
3747         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3748         * frame.h (struct frame_arg): Add initializers.
3749         <error>: Now a unique_xmalloc_ptr.
3750
3751 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3752
3753         * NEWS: Expand the Pointer Authentication entry.
3754         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3755         (aarch64_frame_unmask_lr): ... to this.
3756         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3757         Call aarch64_frame_unmask_lr.
3758         * frame.c (struct frame_info): Add "masked" variable.
3759         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3760         (fprint_frame): Check for masked pc.
3761         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3762         declarations.
3763         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3764         * stack.c (print_frame): Check for masked pc.
3765
3766 2019-08-06  Tom Tromey  <tom@tromey.com>
3767
3768         * stabsread.c (patch_block_stabs, read_one_struct_field)
3769         (read_enum_type): Use obstack_strndup.
3770         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3771         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3772         * dwarf2read.c (guess_full_die_structure_name)
3773         (anonymous_struct_prefix): Use obstack_strndup.
3774         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3775         * c-exp.y (yylex): Use obstack_strndup.
3776         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3777         (write_var_or_type): Use obstack_strndup.
3778
3779 2019-08-06  Tom Tromey  <tom@tromey.com>
3780
3781         * symfile.c (reread_symbols): Use obstack_strdup.
3782         * stabsread.c (read_type): Use obstack_strdup.
3783         * gdb_obstack.h (obstack_strdup): New overload.
3784         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3785         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3786         (dwarf2_canonicalize_name): Use obstack_strdup.
3787         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3788         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3789         Use obstack_strdup.
3790
3791 2019-08-06  Tom Tromey  <tom@tromey.com>
3792
3793         * gdb_obstack.h (obstack_strdup): Define.
3794         * gdb_obstack.c (obstack_strdup): Don't define.
3795
3796 2019-08-06  Tom Tromey  <tom@tromey.com>
3797
3798         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3799         obstack_strdup.
3800         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3801         obstack_strdup.
3802         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3803         * stabsread.c (common_block_start): Use obstack_strdup.
3804         * objfiles.c (set_objfile_main_name, objfile): Use
3805         obstack_strdup.
3806         * namespace.c (add_using_directive): Use obstack_strdup.
3807         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3808         * jit.c (finalize_symtab): Use obstack_strdup.
3809         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3810         (guess_partial_die_structure_name, partial_die_info::fixup)
3811         (dwarf2_name): Use obstack_strdup.
3812         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3813         obstack_strdup.
3814         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3815         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3816         obstack_strdup.
3817         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3818
3819 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * unittests/help-doc-selftests.c: New file.
3822         * Makefile.in: Add the new file.
3823
3824 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3825
3826         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3827         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3828         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3829         the trailing '.' is not output, and the first character is uppercased.
3830         (print_help_for_command): Update call to print_doc_line.
3831         (print_doc_of_command): Likewise.
3832         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3833         * cli/cli-option.c (append_indented_doc): Do not append newline.
3834         (build_help_option): Append newline after first appended_indented_doc
3835         only if a second call is done.
3836         (build_help): Append 2 new lines before each option, except the first
3837         one.
3838         * compile/compile.c (_initialize_compile): Add new lines after
3839         %OPTIONS%, when not at the end of the help.
3840         Change help doc or code
3841         producing the help doc to respect the invariants.
3842         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3843         Also removed the new line after 'Options:', as all other commands
3844         do not put an empty line between 'Options:' and the first option.
3845         * printcmd.c (_initialize_printcmd): Likewise.
3846         * stack.c (_initialize_stack): Likewise.
3847         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3848         incorrectly telling COMMAND is optional.
3849         * ada-lang.c (_initialize_ada_language): Change help doc or code
3850         producing the help doc to respect the invariants.
3851         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3852         * breakpoint.c (_initialize_breakpoint): Likewise.
3853         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3854         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3855         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3856         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3857         _initialize_cli_style): Likewise.
3858         * corelow.c (core_target_info): Likewise.
3859         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3860         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3861         * filesystem.c (_initialize_filesystem): Likewise.
3862         * frame.c (_initialize_frame): Likewise.
3863         * gnu-nat.c (add_task_commands): Likewise.
3864         * infcall.c (_initialize_infcall): Likewise.
3865         * infcmd.c (_initialize_infcmd): Likewise.
3866         * interps.c (_initialize_interpreter): Likewise.
3867         * language.c (_initialize_language): Likewise.
3868         * linux-fork.c (_initialize_linux_fork): Likewise.
3869         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3870         * maint.c (_initialize_maint_cmds): Likewise.
3871         * memattr.c (_initialize_mem): Likewise.
3872         * printcmd.c (_initialize_printcmd): Likewise.
3873         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3874         _RegEx): Likewise.
3875         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3876         * record-btrace.c (_initialize_record_btrace): Likewise.
3877         * record-full.c (_initialize_record_full): Likewise.
3878         * record.c (_initialize_record): Likewise.
3879         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3880         * regcache.c (_initialize_regcache): Likewise.
3881         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3882         _initialize_remote): Likewise.
3883         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3884         * serial.c (_initialize_serial): Likewise.
3885         * skip.c (_initialize_step_skip): Likewise.
3886         * source.c (_initialize_source): Likewise.
3887         * stack.c (_initialize_stack): Likewise.
3888         * symfile.c (_initialize_symfile): Likewise.
3889         * symtab.c (_initialize_symtab): Likewise.
3890         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3891         * top.c (init_main): Likewise.
3892         * tracefile-tfile.c (tfile_target_info): Likewise.
3893         * tracepoint.c (_initialize_tracepoint): Likewise.
3894         * tui/tui-win.c (_initialize_tui_win): Likewise.
3895         * utils.c (add_internal_problem_command): Likewise.
3896         * valprint.c (value_print_option_defs): Likewise.
3897
3898 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3899
3900         PR build/24886
3901         * configure.ac: Drop enable-libmcheck support.
3902         * configure, config.in: Rebuild.
3903         * libmcheck.m4: Remove.
3904         * acinclude.m4: Don't include it.
3905         * Makefile.in: Don't distribute it.
3906         * top.c (print_gdb_configuration): Don't mention it.
3907
3908 2019-08-06  Tom Tromey  <tom@tromey.com>
3909
3910         * utils.c (set_output_style): Sometimes pass stream to
3911         emit_style_escape.
3912         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3913         * record-btrace.c (btrace_insn_history): Update.
3914         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3915         method.
3916         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3917         Update initializers.
3918         <m_uiout>: New field.
3919         <m_di>: Move lower.
3920         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3921         Remove "uiout" parameter.
3922         (dump_insns): Update.
3923         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3924         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3925
3926 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3927
3928         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3929         (error_in_psymtab_expansion): Likewise.
3930         (lookup_symbol_via_quick_fns): Likewise.
3931         (basic_lookup_transparent_type_quick): Likewise.
3932         (basic_lookup_transparent_type_1): Likewise.
3933
3934 2019-08-06  Tom Tromey  <tromey@adacore.com>
3935
3936         * source.c (last_source_error): Now bool.
3937         (print_source_lines_base): Make "noprint" bool.  Only open
3938         source file when last_source_visited changes.
3939
3940 2019-08-06  Tom Tromey  <tromey@adacore.com>
3941
3942         * annotate.c (annotate_source_line): Use g_source_cache.
3943         * source-cache.c (source_cache::get_plain_source_lines): Change
3944         parameters.  Populate m_offset_cache.
3945         (source_cache::ensure): New method.
3946         (source_cache::get_line_charpos): New method.
3947         (extract_lines): Move lower.  Change parameters.
3948         (source_cache::get_source_lines): Move lower.
3949         * source-cache.h (class source_cache): Update comment.
3950         <get_line_charpos>: New method.
3951         <get_source_lines>: Update comment.
3952         <clear>: Clear m_offset_cache.
3953         <get_plain_source_lines>: Change parameters.
3954         <ensure>: New method
3955         <m_offset_cache>: New member.
3956         * source.c (forget_cached_source_info_for_objfile): Update.
3957         (info_source_command): Use g_source_cache.
3958         (find_source_lines, open_source_file_with_line_charpos): Remove.
3959         (print_source_lines_base, search_command_helper): Use g_source_cache.
3960         * source.h (open_source_file_with_line_charpos): Don't declare.
3961         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3962         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3963         Use g_source_cache.
3964
3965 2019-08-06  Tom Tromey  <tromey@adacore.com>
3966
3967         * source-cache.c (source_cache::get_plain_source_lines):
3968         Remove "first_line" and "last_line" parameters.
3969         (source_cache::get_source_lines): Cache plain text.
3970         * source-cache.h (class source_cache)
3971         <get_plain_source_lines>: Update.
3972
3973 2019-08-06  Tom Tromey  <tromey@adacore.com>
3974
3975         * source-cache.c (extract_lines): No longer a method.
3976         Changed type of parameter.  Include final newline.
3977         (selftests::extract_lines_test): New function.
3978         (_initialize_source_cache): Likewise.
3979         * source-cache.h (class source_cache)
3980         <extract_lines>: Don't declare.
3981
3982 2019-08-06  Tom Tromey  <tromey@adacore.com>
3983
3984         * breakpoint.c (init_breakpoint_sal): Update.
3985         (breakpoint): Update.
3986         * breakpoint.h (struct breakpoint) <filter>: Now a
3987         unique_xmalloc_ptr.
3988
3989 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3990
3991         * NEWS: Mention dictionary access on blocks.
3992         * python/py-block.c (blpy_getitem): New function.
3993         (block_object_as_mapping): New struct.
3994         (block_object_type): Use new struct for tp_as_mapping field.
3995
3996 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3997
3998         * objfiles.h (objfile): Add a comment describing partial symbols.
3999
4000 2019-08-05  Tom Tromey  <tromey@adacore.com>
4001
4002         * compile/compile.c (_initialize_compile): Use _(), not N_().
4003         * thread.c (_initialize_thread): Use _(), not N_().
4004         * stack.c (_initialize_stack): Use _(), not N_().
4005         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4006
4007 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4008
4009         * dwarf2read.c (struct dw2_symtab_iterator):
4010         <want_specific_block>: Remove.
4011         <block_index>: Change type to gdb::optional.
4012         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4013         change type of BLOCK_INDEX parameter to gdb::optional.
4014         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4015         (dw2_lookup_symbol): Don't pass argument for
4016         WANT_SPECIFIC_BLOCK.
4017         (dw2_expand_symtabs_for_function): Don't pass argument for
4018         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4019         (class dw2_debug_names_iterator)
4020         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4021         parameter, change BLOCK_INDEX type to gdb::optional.
4022         <m_want_specific_block>: Remove.
4023         <m_block_index>: Change type to gdb::optional.
4024         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4025         gdb::optional.  Re-write in function of gdb::optional.
4026         (dw2_debug_names_lookup_symbol): Don't pass argument for
4027         WANT_SPECIFIC_BLOCK.
4028         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4029         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4030         BLOCK_INDEX.
4031
4032 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4033
4034         * NEWS: Mention changes to "info sources" command.
4035
4036 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4037
4038         * symtab.c (filename_partial_match_opts): New struct type.
4039         (struct output_source_filename_data): New members
4040         regexp, c_regexp, partial_match.
4041         (output_source_filename): Use new members to decide to print file.
4042         (info_sources_option_defs): New variable.
4043         (make_info_sources_options_def_group, print_info_sources_header,
4044         info_sources_command_completer):
4045         New functions.
4046         (info_sources_command): Read new optional arguments.
4047         (_initialize_symtab): Update info sources help.
4048
4049 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4050
4051         * ada-lang.c (exception_support_info_v0): Renamed from...
4052         (default_exception_support_info): ... this.  Create new
4053         definition for v1.
4054         (ada_has_this_exception_support): Look up catch_handlers_sym.
4055         (ada_exception_support_info_sniffer): Try v0 after default.
4056
4057 2019-08-01  Tom Tromey  <tromey@adacore.com>
4058
4059         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4060         gdbarch.h.
4061
4062 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4063
4064         * s12z-tdep.c: Fix include path for s12z-opc.h.
4065
4066 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4067
4068         * NEWS: Require GNU make 3.82.
4069
4070 2019-07-16  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4073         declare.
4074
4075 2019-07-30  Tom Tromey  <tromey@adacore.com>
4076
4077         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4078
4079 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4080
4081         * printcmd.c (print_address_symbolic): Print negative offsets.
4082         (build_address_symbolic): Force signed arithmetic when computing
4083         offset.
4084
4085 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4086
4087         PR/24474: Add a function to lookup static variables.
4088         * NEWS: Mention this new function.
4089         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4090         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4091         * python/python.c (python_GdbMethods): Add new function.
4092
4093 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4094
4095         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4096         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4097         (objfpy_lookup_static_symbol): New function.
4098         (objfile_object_methods): Add new functions.
4099
4100 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4101
4102         * NEWS: Mention 'set|show print frame-info'.  Mention new
4103         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4104         backtrace argument.  Mention that python frame filtering code
4105         is now consistent with what 'backtrace' command prints.
4106
4107 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4108
4109         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4110         comments.
4111         (print_frame_info_auto, print_frame_info_source_line,
4112         print_frame_info_location, print_frame_info_source_and_location,
4113         print_frame_info_location_and_address, print_frame_info_short_location):
4114         New declarations.
4115         (struct frame_print_options): New member print_frame_info.
4116         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4117         * stack.h (get_user_print_what_frame_info): New declaration.
4118         (frame_show_address): New declaration.
4119         * stack.c (print_frame_arguments_choices): New value 'presence'.
4120         (print_frame_info_auto, print_frame_info_source_line,
4121         print_frame_info_location, print_frame_info_source_and_location,
4122         print_frame_info_location_and_address, print_frame_info_short_location,
4123         print_frame_info_choices, print_frame_info_print_what): New definitions.
4124         (print_frame_args): Only print dots for args if print frame-arguments
4125         is 'presence'.
4126         (frame_print_option_defs): New element for "frame-info".
4127         (get_user_print_what_frame_info): New function.
4128         (frame_show_address): Make non static.  Move comment to stack.h.
4129         (print_frame_info_to_print_what): New function.
4130         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4131         to decide what to print.
4132         (backtrace_command_1): Handle the new print_frame_arguments_presence
4133         value.
4134         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4135         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4136         (py_print_frame): In non-mi mode, use LOCATION as default for
4137         print_what, similarly to frame information printed directly by
4138         backtrace command. Handle frame-info user option in non MI mode.
4139
4140 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4141
4142         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4143         Add case for debugging 32-bit target on 64-bit host.  Revise
4144         comment.
4145
4146 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4147
4148         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4149         instead of find_function_entry_range_from_pc.
4150
4151 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4152
4153         * stack.c (find_frame_funname): Remove code which preferred
4154         minsym over symtab sym in "certain pathological cases".
4155
4156         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4157         parameter.  Change type of "do_demangle" to bool.
4158         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4159         Pass suitable "prefer_sym_over_minsym" flag to
4160         build_address_symbolic().  Don't output "+" for negative offsets.
4161         * printcmd.c (print_address_symbolic): Update invocation of
4162         build_address_symbolic to include a "prefer_sym_over_minsym"
4163         flag.
4164         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4165         Restrict cases in which use of minimal symbol is preferred to that
4166         of a found symbol.  Update comments.
4167
4168         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4169         for entry pc when entry pc is out of range for that FDE.
4170
4171 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4172
4173         PR gdb/24839:
4174         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4175         type.
4176
4177 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4178
4179         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4180         this function's Python signature.
4181
4182
4183 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4184
4185         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4186         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4187         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4188         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4189         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4190
4191
4192 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4193
4194         * h8300-tdep.c (h8300_register_name_common): New.
4195         h8300_register_name): Use h8300_register_name_common.
4196         (h8300s_register_name): Likewise.
4197         (h8300sx_register_name): Likewise.
4198         (h8300h_register_nam): New.
4199         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4200
4201
4202 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4203
4204         * arm-tdep.c (arm_skip_cmse_entry): New function.
4205         (arm_is_sgstubs_section): New function.
4206         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4207
4208 2019-07-22  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4211         Don't self-assign.
4212
4213 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4216         type_print.
4217
4218 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4221         so that GDB doesn't match any msymbols when searching in the
4222         TYPES_DOMAIN.
4223         (print_symbol_info): Print using typedef_print or type_print based
4224         on the type of the symbol.  Add updated FIXME comment moved from...
4225         (_initialize_symtab): ... move and update FIXME comment to above.
4226
4227 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * NEWS: Mention adding -q option to "info types".
4230         * symtab.c (struct info_types_options): New struct.
4231         (info_types_options_defs): New variable.
4232         (make_info_types_options_def_group): New function.
4233         (info_types_command): Use gdb::option framework to parse options.
4234         (info_types_command_completer): New function.
4235         (_initialize_symtab): Extend the help text on "info types" and
4236         register command completer.
4237
4238 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4239
4240         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4241         (lookup_symbol_in_objfile): Change int to block_enum and add a
4242         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4243
4244 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4245
4246         * MAINTAINERS (Write After Approval): Add self.
4247
4248 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4251         instruction to the dummy code region.
4252
4253 2019-07-19  Tom Tromey  <tromey@adacore.com>
4254
4255         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4256         (ARGSUSED, PARAMS, __func__): Remove rules.
4257
4258 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4259
4260         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4261         * features/arm/arm-with-iwmmxt.c: Remove.
4262         * features/arm/arm-with-iwmmxt.xml: Remove.
4263         * features/arm/arm-with-m-fpa-layout.c: Remove.
4264         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4265         * features/arm/arm-with-m-vfp-d16.c: Remove.
4266         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4267         * features/arm/arm-with-m.c: Remove.
4268         * features/arm/arm-with-m.xml: Remove.
4269         * features/arm/arm-with-neon.c: Remove.
4270         * features/arm/arm-with-neon.xml: Remove.
4271         * features/arm/arm-with-vfpv2.c: Remove.
4272         * features/arm/arm-with-vfpv2.xml: Remove.
4273         * features/arm/arm-with-vfpv3.c: Remove.
4274         * features/arm/arm-with-vfpv3.xml: Remove.
4275
4276 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4277
4278         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4279
4280 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4281
4282         * arch/aarch32.c (aarch32_create_target_description): Create
4283         target descriptions using features.
4284         * arch/arm.c (arm_create_target_description)
4285         (arm_create_mprofile_target_description): Likewise.
4286         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4287
4288 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4289
4290         * Makefile.in: Add new files.
4291         * aarch32-tdep.c: New file.
4292         * aarch32-tdep.h: New file.
4293         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4294         Call aarch32_read_description.
4295         * arch/aarch32.c: New file.
4296         * arch/aarch32.h: New file.
4297         * arch/arm.c (arm_create_target_description)
4298         (arm_create_mprofile_target_description): New function.
4299         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4300         (arm_create_target_description)
4301         (arm_create_mprofile_target_description): New declaration.
4302         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4303         read_description functions.
4304         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4305         Likewise.
4306         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4307         * arm-tdep.c (tdesc_arm_list): New variable.
4308         (arm_register_g_packet_guesses): Call create description functions.
4309         (arm_read_description) (arm_read_mprofile_description): New
4310         function.
4311         * arm-tdep.h (arm_read_description)
4312         (arm_read_mprofile_description): Add declaration.
4313         * configure.tgt: Add new files.
4314
4315 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4316
4317         * top.c (new_ui_command): Open specified terminal just once.
4318
4319 2019-07-18  Tom Tromey  <tromey@adacore.com>
4320
4321         * symtab.c (main_name): Constify return type.
4322         * symfile.c (set_initial_language): Update.
4323         * symtab.h (main_name): Constify return type.
4324
4325 2019-07-17  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-winsource.c (tui_update_source_window)
4328         (tui_update_source_window_as_is)
4329         (tui_update_source_windows_with_line): Remove return.
4330         * tui/tui-disasm.c (tui_show_disassem)
4331         (tui_show_disassem_and_update_source): Remove return.
4332         * tui/tui.c (tui_reset): Remove return.
4333         * tui/tui-wingeneral.c
4334         (tui_check_and_display_highlight_if_needed): Remove return.
4335
4336 2019-07-17  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4339
4340 2019-07-17  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-winsource.h (struct tui_exec_info_window)
4343         (struct tui_source_window_base): Move from tui-data.h.
4344         * tui/tui-winsource.c: Move many method definitions from
4345         elsewhere.  Remove "structuring" comments.
4346         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4347         (tui_source_window_base::refresh_window): Move to
4348         tui-winsource.c.
4349         * tui/tui-win.c (tui_source_window_base::refresh_all)
4350         (tui_source_window_base::update_tab_width)
4351         (tui_source_window_base::set_new_height)
4352         (tui_source_window_base::do_make_visible_with_new_height): Move to
4353         tui-winsource.c.
4354         * tui/tui-source.h: Update.
4355         * tui/tui-source.c (tui_source_window_base::reset): Move to
4356         tui-winsource.c.
4357         * tui/tui-disasm.h: Update.
4358         * tui/tui-data.h (struct tui_exec_info_window): Move to
4359         tui-winsource.h.
4360         (struct tui_source_window_base): Likewise.
4361         * tui/tui-data.c (tui_source_window_base::clear_detail)
4362         (tui_source_window_base, ~tui_source_window_base): Move to
4363         tui-winsource.c.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-win.c (tui_resize_all)
4368         (tui_source_window_base::update_tab_width)
4369         (tui_adjust_win_heights): Update.
4370         (tui_win_info::make_invisible_and_set_new_height): Rename from
4371         make_invisible_and_set_new_height.
4372         * tui/tui-data.h (struct tui_win_info)
4373         <make_invisible_and_set_new_height>: New method.
4374
4375 2019-07-17  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui.c: Update.
4378         * tui/tui-source.h (struct tui_source_window): Move from
4379         tui-data.h.
4380         * tui/tui-layout.c: Update.
4381         * tui/tui-disasm.c: Update.
4382         * tui/tui-data.h (struct tui_source_window): Move to
4383         tui-source.h.
4384
4385 2019-07-17  Tom Tromey  <tom@tromey.com>
4386
4387         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4388         tui-data.h.
4389         * tui/tui-data.h (struct tui_disasm_window): Move to
4390         tui-disasm.h.
4391
4392 2019-07-17  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-regs.h (struct tui_data_item_window): Move from
4395         tui-data.h.
4396         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4397         * tui/tui-data.h (struct tui_data_item_window): Move to
4398         tui-regs.h.
4399         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4400
4401 2019-07-17  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui.c: Update.
4404         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4405         (tui_cmd_window::max_height): Move to tui-command.c.
4406         * tui/tui-layout.c: Update.
4407         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4408         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4409         tui-command.c.
4410         * tui/tui-command.h (struct tui_cmd_window): Move from
4411         tui-data.h.
4412         * tui/tui-command.c: Remove "structuring" comments.
4413         (tui_cmd_window::clear_detail)
4414         (tui_cmd_window::do_make_visible_with_new_height)
4415         (tui_cmd_window::max_height): Move from elsewhere.
4416
4417 2019-07-17  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4420         Now static.
4421         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4422         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4423
4424 2019-07-17  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui.c: Update.
4427         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4428         tui-regs.c.
4429         * tui/tui-windata.h: Remove file.
4430         * tui/tui-windata.c: Remove file.
4431         * tui/tui-win.c (tui_data_window::set_new_height)
4432         (tui_data_window::do_make_visible_with_new_height): Move to
4433         tui-regs.c.
4434         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4435         * tui/tui-regs.c: Remove "structuring" comments.
4436         (tui_data_window::first_data_item_displayed)
4437         (tui_data_window::delete_data_content_windows)
4438         (tui_data_window::erase_data_content)
4439         (tui_data_window::display_all_data)
4440         (tui_data_window::refresh_all)
4441         (tui_data_window::do_scroll_vertical)
4442         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4443         (tui_data_window::do_make_visible_with_new_height)
4444         (tui_data_window::refresh_window): Move from elsewhere.
4445         (_initialize_tui_regs): Move to end of file.
4446         * tui/tui-layout.c: Update.
4447         * tui/tui-hooks.c: Update.
4448         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4449         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4450         tui-regs.c.
4451         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4452
4453 2019-07-17  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4456         seen.
4457
4458 2019-07-17  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-win.c (tui_source_window_base::set_new_height)
4461         (tui_source_window_base::do_make_visible_with_new_height): Use
4462         m_has_locator field directly.
4463         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4464         method.
4465         (struct tui_source_window_base) <has_locator>: Likewise.
4466
4467 2019-07-17  Tom Tromey  <tom@tromey.com>
4468
4469         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4470         Don't declare.
4471         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4472         Remove.
4473         * tui/tui-win.c (tui_source_window_base::set_new_height)
4474         (tui_source_window_base::set_new_height)
4475         (make_invisible_and_set_new_height)
4476         (tui_source_window_base::do_make_visible_with_new_height)
4477         (tui_source_window_base::do_make_visible_with_new_height):
4478         Update.
4479         * tui/tui-layout.c (show_source_disasm_command, show_data)
4480         (show_source_or_disasm_and_command): Update.
4481         * tui/tui-layout.c (show_layout): Update.
4482
4483 2019-07-17  Tom Tromey  <tom@tromey.com>
4484
4485         * tui/tui-layout.c (make_data_window): Remove.
4486         (show_data): Unify creation and re-initialization cases.
4487
4488 2019-07-17  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-layout.c (make_source_window, make_disasm_window):
4491         Remove.
4492         (show_data): Unify creation and re-initialization cases.
4493
4494 2019-07-17  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-layout.c (make_command_window): Remove.
4497         (show_source_disasm_command, show_source_or_disasm_and_command):
4498         Unify creation and re-initialization cases.
4499
4500 2019-07-17  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4503         creation and re-initialization cases.
4504
4505 2019-07-17  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-regs.c (tui_get_register): Return void.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4512         Simplify.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4517         resetting.
4518
4519 2019-07-17  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4522         * tui/tui-regs.c (tui_reg_layout): New function.
4523         (tui_show_registers, tui_reg_command): Use it.
4524         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4525         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4526         parameters.
4527         (tui_layout_command): Remove.
4528
4529 2019-07-17  Tom Tromey  <tom@tromey.com>
4530
4531         * tui/tui-layout.h (tui/tui-layout): Return void.
4532         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4533
4534 2019-07-17  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui-layout.c (show_source_disasm_command, show_data):
4537         Update.
4538         (reset_locator): Remove.
4539         (show_source_or_disasm_and_command): Update.
4540
4541 2019-07-17  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-source.c (tui_source_window_base::reset): Remove
4544         win_type parameter.
4545         * tui/tui-layout.c (make_command_window, make_source_window)
4546         (make_disasm_window, make_data_window)
4547         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4548         (reset_locator, show_source_or_disasm_and_command): Update.
4549         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4550         win_type parameter.
4551         (struct tui_source_window_base) <reset>: Likewise.
4552
4553 2019-07-17  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-layout.c (show_source_disasm_command): Use
4556         reset_locator.
4557         (reset_locator): New function.
4558         (init_and_make_win): Remove.
4559         (show_source_or_disasm_and_command): Use reset_locator.
4560
4561 2019-07-17  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4564         condition.
4565         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4566         Remove condition.
4567         * tui/tui-source.c (tui_source_window_base::reset): New method.
4568         * tui/tui-layout.c (make_command_window): Don't call
4569         init_and_make_win.
4570         (make_source_window, make_disasm_window): Don't call
4571         make_source_or_disasm_window.
4572         (make_data_window): Don't call init_and_make_win.  Change calling
4573         convention.
4574         (show_source_disasm_command, show_data): Simplify.
4575         (make_source_or_disasm_window): Remove.
4576         (show_source_or_disasm_and_command): Simplify.
4577         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4578         (struct tui_source_window_base) <reset>: Likewise.
4579         <execution_info>: Remove initializer.
4580         * tui/tui-data.c (tui_source_window_base): Initialize
4581         execution_info.
4582
4583 2019-07-17  Tom Tromey  <tom@tromey.com>
4584
4585         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4586         variable.
4587
4588 2019-07-17  Tom Tromey  <tom@tromey.com>
4589
4590         * tui/tui.c (tui_rl_other_window): Update.
4591         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4592         superclass method first.  Always iterate over regs_content.
4593         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4594         method.
4595         * tui/tui-win.c (tui_set_focus_command): Update.
4596
4597 2019-07-17  Tom Tromey  <tom@tromey.com>
4598
4599         * tui/tui-win.c (tui_set_focus_command): Rename from
4600         tui_set_focus.  Call tui_enable.
4601         (tui_set_focus_command): Remove.
4602
4603 2019-07-17  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4606         refresh_window.
4607         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4608         touchwin.
4609         (tui_data_window::refresh_window): Call refresh_window on data
4610         items.  Always call superclass refresh_window.
4611         (tui_win_info::refresh): Remove.
4612         (tui_source_window_base::refresh_window): Update.
4613         (tui_refresh_all): Update.
4614         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4615         refresh_window.
4616         (show_source_or_disasm_and_command): Likewise.
4617         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4618         (struct tui_source_window_base) <refresh>: Likewise.
4619
4620 2019-07-17  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-winsource.c (tui_clear_source_content)
4623         (tui_show_source_content): Update.
4624         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4625         whether content is empty.
4626         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4627         Remove.
4628
4629 2019-07-17  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4632         window's contents.
4633         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4634         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4635
4636 2019-07-17  Tom Tromey  <tom@tromey.com>
4637
4638         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4639         (struct tui_data_item_window): Update.
4640
4641 2019-07-17  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4644         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4645         defines.
4646
4647 2019-07-17  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-winsource.h (tui_erase_source_content)
4650         (tui_clear_source_content): Remove "display_prompt" parameter.
4651         * tui/tui-winsource.c (tui_update_source_window_as_is)
4652         (tui_update_source_windows_with_addr): Update.
4653         (tui_clear_source_content): Remove "display_prompt" parameter.
4654         (tui_erase_source_content): Likewise.  Simplify.
4655         (tui_show_source_content): Update.
4656         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4657         * tui/tui-stack.c (tui_show_frame_info): Update.
4658         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4659         Remove defines.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4664         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4665         parameter.
4666         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4667         parameter.
4668
4669 2019-07-17  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-winsource.c (tui_clear_source_content)
4672         (tui_show_source_content, tui_show_exec_info_content)
4673         (tui_clear_exec_info_content): Update.
4674         * tui/tui-stack.c (tui_show_locator_content): Update.
4675         (tui_show_frame_info): Update.
4676         * tui/tui-source.h (tui_source_window): Don't declare.
4677         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4678         from tui_source_is_displayed.
4679         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4680         Remove field.
4681         (struct tui_source_window_base) <content_in_use>: New field.  Now
4682         bool.
4683         (struct tui_source_window) <showing_source_p>: New method.
4684         (TUI_SRC_WIN): Change cast.
4685         * tui/tui-data.c (tui_initialize_static_data): Update.
4686
4687 2019-07-17  Tom Tromey  <tom@tromey.com>
4688
4689         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4690         location_matches_p.
4691         * tui/tui-source.c (tui_source_window::location_matches_p): New
4692         method.
4693         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4694         method.
4695         * tui/tui-data.h (struct tui_source_window_base)
4696         <location_matches_p>: New method.
4697         (struct tui_source_window, struct tui_disasm_window)
4698         <location_matches_p>: Likewise.
4699
4700 2019-07-17  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-win.c (tui_set_win_height_command): Rename from
4703         tui_set_win_height.
4704         (tui_set_win_height_command): Remove.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-source.c (tui_source_window): New constructor.  Add
4709         observer.
4710         (~tui_source_window): New destructor.
4711         (tui_source_window::style_changed): New method.
4712         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4713         (tui_attach_detach_observers): Update.
4714         * tui/tui-data.h (struct tui_source_window): Make constructor not
4715         inline.  Add destructor.
4716         (struct tui_source_window) <style_changed>: New method.
4717         <m_observable>: New member.
4718
4719 2019-07-17  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4722         * tui/tui-win.c (tui_resize_all): Fix typo.
4723
4724 2019-07-17  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4727         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4728         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4729         * tui/tui-win.c (window_name_completer): Use foreach.
4730         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4731         (update_tab_width): Likewise.
4732         * tui/tui-layout.c (show_layout): Update.
4733         * tui/tui-data.h (class tui_window_iterator): New.
4734         (struct all_tui_windows): New.
4735         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4736
4737 2019-07-17  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4740         parameter.  Don't reference globals.
4741         (tui_reg_command): Update.
4742
4743 2019-07-17  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-regs.c (tui_show_registers): Simplify.
4746
4747 2019-07-17  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-regs.c (tui_show_registers): Update.
4750         (tui_show_register_group): Add win_info parameter.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4755         Rename from tui_display_reg_element_at_line.
4756         (tui_data_window::display_registers_from_line): Update.
4757         * tui/tui-data.h (struct tui_data_window)
4758         <display_reg_element_at_line>: New method.
4759
4760 2019-07-17  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-regs.h (tui_display_registers_from)
4763         (tui_display_registers_from_line): Don't declare.
4764         * tui/tui-windata.c (tui_data_window::display_all_data)
4765         (tui_data_window::refresh_all)
4766         (tui_data_window::do_scroll_vertical): Update.
4767         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4768         from tui_display_registers_from.
4769         (tui_display_reg_element_at_line): Update.
4770         (tui_data_window::display_registers_from_line): Rename from
4771         tui_display_registers_from_line.
4772         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4773         display_registers_from_line>: New methods.
4774
4775 2019-07-17  Tom Tromey  <tom@tromey.com>
4776
4777         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4778         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4779         from tui_erase_data_content.
4780         (tui_data_window::display_all_data)
4781         (tui_data_window::refresh_all)
4782         (tui_data_window::do_scroll_vertical): Update.
4783         * tui/tui-regs.c (tui_show_registers): Update.
4784         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4785         New method.
4786
4787 2019-07-17  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4790         declare.
4791         * tui/tui-windata.c
4792         (tui_data_window::delete_data_content_windows): Rename from
4793         tui_delete_data_content_windows.
4794         (tui_data_window::display_all_data)
4795         (tui_data_window::do_scroll_vertical): Update.
4796         * tui/tui-data.h (struct tui_data_window)
4797         <delete_data_content_windows>: New method.
4798
4799 2019-07-17  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4802         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4803
4804 2019-07-17  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4807         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4808         from tui_display_all_data.
4809         * tui/tui-win.c
4810         (tui_data_window::do_make_visible_with_new_height): Update.
4811         * tui/tui-regs.c (tui_show_registers): Update.
4812         * tui/tui-layout.c (tui_set_layout): Update.
4813         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4814         method.
4815
4816 2019-07-17  Tom Tromey  <tom@tromey.com>
4817
4818         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4819         * tui/tui-windata.c (tui_display_data_from): Remove.
4820         (tui_data_window::refresh_all): Update.
4821
4822 2019-07-17  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4825         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4826         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4827         tui_display_registers_from_line.
4828         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4829         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4830         "force_display" parameter.
4831
4832 2019-07-17  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4835         declare.
4836         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4837         Rename from tui_first_reg_element_no_inline.
4838         (tui_display_reg_element_at_line)
4839         (tui_display_registers_from_line): Update.
4840         * tui/tui-data.h (struct tui_data_window)
4841         <first_reg_element_no_inline>: New method.
4842
4843 2019-07-17  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-windata.c (tui_display_data_from)
4846         (tui_data_window::do_scroll_vertical): Update.
4847         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4848         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4849         Rename from tui_line_from_reg_element_no.
4850         (tui_display_registers_from_line): Update.
4851         * tui/tui-data.h (struct tui_data_window)
4852         <line_from_reg_element_no>: New method.
4853
4854 2019-07-17  Tom Tromey  <tom@tromey.com>
4855
4856         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4857         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4858         tui_last_regs_line_no.
4859         (tui_display_reg_element_at_line)
4860         (tui_display_registers_from_line): Update.
4861         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4862         method.
4863
4864 2019-07-17  Tom Tromey  <tom@tromey.com>
4865
4866         PR tui/24722:
4867         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4868         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4869         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4870         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4871         (tui_update_breakpoint_info): Likewise.
4872         * tui/tui-hooks.c (tui_event_create_breakpoint)
4873         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4874         Update.
4875
4876 2019-07-17  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4879
4880 2019-07-17  Tom Tromey  <tom@tromey.com>
4881
4882         * tui/tui-winsource.c (tui_update_source_window_as_is)
4883         (tui_update_source_windows_with_addr): Update.
4884         * tui/tui-source.h (tui_set_source_content)
4885         (tui_show_symtab_source): Add "win_info" parameter.
4886         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4887         parameter.
4888         (tui_show_symtab_source): Likewise.
4889
4890 2019-07-17  Tom Tromey  <tom@tromey.com>
4891
4892         * tui/tui-wingeneral.c
4893         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4894
4895 2019-07-17  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4898         (struct tui_cmd_window) <can_scroll>: New method.
4899         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4900         method.
4901
4902 2019-07-17  Tom Tromey  <tromey@adacore.com>
4903
4904         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4905         do_field_signed>: Rename.  Change type of "value".
4906         * ui-out.c (ui_out::field_signed): Rename from field_int.
4907         Change type of "value".
4908         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4909         type of "value".
4910         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4911         do_field_int.  Change type of "value".
4912         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4913         do_field_int.  Change type of "value".
4914         * tracepoint.c (trace_status_mi, tfind_1)
4915         (print_one_static_tracepoint_marker): Update.
4916         * thread.c (print_thread_info_1, print_selected_thread_frame):
4917         Update.
4918         * stack.c (print_frame, print_frame_info): Update.
4919         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4920         Update.
4921         * source.c (print_source_lines_base): Update.
4922         * skip.c (info_skip_command): Update.
4923         * record-btrace.c (btrace_ui_out_decode_error)
4924         (btrace_call_history_src_line): Update.
4925         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4926         Update.
4927         * progspace.c (print_program_space): Update.
4928         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4929         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4930         do_field_int.  Change type of "value".
4931         * mi/mi-out.c (mi_ui_out::do_table_begin)
4932         (mi_ui_out::do_table_header): Update.
4933         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4934         type of "value".
4935         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4936         (mi_cmd_data_list_changed_registers, output_register)
4937         (mi_cmd_data_read_memory, mi_load_progress)
4938         (mi_cmd_trace_frame_collected): Update.
4939         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4940         Update.
4941         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4942         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4943         (mi_cmd_var_list_children, varobj_update_one): Update.
4944         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4945         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4946         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4947         * inferior.c (print_inferior): Update.
4948         * gdb_bfd.c (print_one_bfd): Update.
4949         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4950         Update.
4951         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4952         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4953         do_field_int.  Change type of "value".
4954         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4955         do_field_int.  Change type of "value".
4956         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4957         (print_one_breakpoint_location, print_it_catch_fork)
4958         (print_one_catch_fork, print_it_catch_vfork)
4959         (print_one_catch_vfork, print_it_catch_solib)
4960         (print_it_catch_exec, print_it_ranged_breakpoint)
4961         (print_mention_watchpoint, print_mention_masked_watchpoint)
4962         (bkpt_print_it, update_static_tracepoint): Update.
4963         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4964         * break-catch-syscall.c (print_it_catch_syscall): Update.
4965         * ada-tasks.c (print_ada_task_info): Update.
4966         * ada-lang.c (print_it_exception, print_mention_exception):
4967         Update.
4968
4969 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4970
4971         PR breakpoints/24541
4972         * gdbarch.c: Regenerate.
4973         * gdbarch.h: Regenerate.
4974         * gdbarch.sh: Adjust return type and parameter types for
4975         'stap_adjust_register'.
4976         (i386_stap_adjust_register): Adjust signature and return new
4977         register name.
4978         * stap-probe.c (stap_parse_register_operand): Adjust use of
4979         'gdbarch_stap_adjust_register'.
4980
4981 2019-07-17  Tom Tromey  <tromey@adacore.com>
4982
4983         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4984         declare VEC.
4985         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4986         std::vector.
4987         (struct s390_process_info): Add initializers.
4988         (s390_add_process): Use new.
4989         (s390_linux_nat_target::low_forget_process): Use delete.
4990         (s390_linux_nat_target::low_new_fork)
4991         (s390_linux_nat_target::stopped_by_watchpoint)
4992         (s390_linux_nat_target::low_prepare_to_resume)
4993         (s390_linux_nat_target::insert_watchpoint)
4994         (s390_linux_nat_target::insert_hw_breakpoint)
4995         (s390_linux_nat_target::remove_watchpoint)
4996         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4997
4998 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4999
5000         * aarch64-fbsd-nat.c: Include regcache.h.
5001         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5002         argument.
5003         (aarch64_fbsd_nat_target::fetch_registers)
5004         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5005         variable.
5006         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5007
5008 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5009
5010         * fbsd-nat.c: Include gdbarch.h.
5011
5012 2019-07-15  Tom Tromey  <tromey@adacore.com>
5013
5014         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5015
5016 2019-07-15  Tom Tromey  <tromey@adacore.com>
5017
5018         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5019         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5020         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5021         * cli-out.c (cli_ui_out::do_field_int): New method.
5022         * ui-out.c (ui_out::field_unsigned): New method.
5023         * symfile.c (generic_load): Use field_unsigned.
5024         (print_transfer_performance): Likewise.
5025         * record-btrace.c (ui_out_field_uint): Remove.
5026         (btrace_call_history_insn_range, btrace_call_history): Use
5027         field_unsigned.
5028         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5029         field_unsigned.
5030         * ui-out.h (class ui_out) <field_unsigned>: New method.
5031         <do_field_unsigned>: Likewise.
5032
5033 2019-07-15  Tom Tromey  <tromey@adacore.com>
5034
5035         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5036         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5037         * target.c (flash_erase_command): Use field_string.
5038         * infrun.c (print_signal_received_reason): Use field_string.
5039         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5040         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5041         field_string.
5042         * ada-tasks.c (print_ada_task_info): Use field_string.
5043
5044 2019-07-15  Tom Tromey  <tromey@adacore.com>
5045
5046         * target.c (flash_erase_command): Use field_core_addr.
5047         * symfile.c (generic_load): Use field_core_addr.
5048         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5049         Use field_core_addr.
5050         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5051         field_core_addr.
5052
5053 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5054
5055         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5056         value if its desired type is smaller than a CORE_ADDR and signed.
5057
5058 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5061         of changes to field names, and use new is_reference field to
5062         decide if a property is a reference or not.
5063         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5064         field.
5065         (struct dwarf2_property_baton): Update header comment, rename
5066         'referenced_type' to 'property_type' and update comments.
5067         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5068         default property type, store in property baton, update to take
5069         accound of renamed field.
5070         (read_func_scope): Update call to attr_to_dynamic_prop.
5071         (read_array_type): Likewise.
5072         (dwarf2_per_cu_addr_sized_int_type): New function.
5073         (read_subrange_index_type): Move type finding code to
5074         dwarf2_per_cu_addr_sized_int_type.
5075         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5076         (dwarf2_per_cu_addr_type): New function.
5077         (set_die_type): Update calls to attr_to_dynamic_prop.
5078
5079 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         * dwarf2read.c (read_subrange_index_type): New function.
5082         (read_subrange_type): Move code into new function and call it.
5083         * gdbtypes.c (create_range_type): Add some asserts.
5084
5085 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5086
5087         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5088         update return statements.
5089         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5090         declaration, and update comment to match.
5091         * gdbtypes.c (resolve_dynamic_array): Update call to
5092         dwarf2_evaluate_property to match new return type.
5093
5094 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * valarith.c (value_subscripted_rvalue): Change lowerbound
5097         parameter type from int to LONGEST.
5098         * value.h (value_subscripted_rvalue): Likewise in declaration.
5099
5100 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * cli/cli-utils.c (info_print_command_completer): New function.
5103         * cli/cli-utils.h: Add 'completer.h' include, and forward
5104         declaration for 'struct cmd_list_element'.
5105         (info_print_command_completer): Declare.
5106         * stack.c (_initialize_stack): Add completer for 'info locals' and
5107         'info args'.
5108         * symtab.c (_initialize_symtab): Add completer for 'info
5109         variables' and 'info functions'.
5110         * NEWS: Mention completion for additional info commands.
5111
5112 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * cli/cli-utils.c (extract_info_print_args): Delete.
5115         (extract_arg_maybe_quoted): Delete.
5116         (info_print_options_defs): New variable.
5117         (make_info_print_options_def_group): New function.
5118         (extract_info_print_options): Define new function.
5119         * cli/cli-utils.h (extract_info_print_args): Delete.
5120         (struct info_print_options): New structure.
5121         (extract_info_print_options): Declare new function.
5122         * stack.c (info_locals_command): Update to use new
5123         extract_info_print_options, also add a header comment.
5124         (info_args_command): Likewise.
5125         * symtab.c (info_variables_command): Likewise.
5126         (info_functions_command): Likewise.
5127
5128 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5131         to extract string arguments.
5132         * common/common-utils.c (extract_string_maybe_quoted): New function.
5133         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5134
5135 2019-07-11  Tom Tromey  <tromey@adacore.com>
5136
5137         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5138         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5139         * top.h (gdbinit): Don't declare.
5140         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5141         into...
5142         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5143         * top.c (gdb_init): Don't call init_cli_cmds.
5144         (gdbinit): Remove.
5145         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5146
5147 2019-07-11  Tom Tromey  <tromey@adacore.com>
5148
5149         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5150         after it has been moved.
5151
5152 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5153
5154         * valops.c (value_must_coerce_to_target): Change return type to
5155         bool.
5156         * value.h (value_must_coerce_to_target): Likewise.
5157
5158 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5159
5160         * breakpoint.c (is_hardware_watchpoint): Remove
5161         forward-declaration.
5162         (is_masked_watchpoint): Change return type to bool.
5163         (is_tracepoint): Likewise.
5164         (is_breakpoint): Likewise.
5165         (is_hardware_watchpoint): Likewise.
5166         (is_watchpoint): Likewise.
5167         (is_no_memory_software_watchpoint): Likewise.
5168         (is_catchpoint): Likewise.
5169         (breakpoint_1): Make FILTER parameter's return type bool.
5170         is_masked_watchpoint): Change return type to bool.
5171         (save_breakpoints): Make FILTER parameter's return type bool.
5172         * breakpoint.h (is_breakpoint): Change return type to bool.
5173         (is_watchpoint): Likewise.
5174         (is_catchpoint): Likewise.
5175         (is_tracepoint): Likewise.
5176
5177 2019-07-10  Tom Tromey  <tom@tromey.com>
5178
5179         * defs.h: Don't include gdbarch.h.
5180         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5181         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5182         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5183         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5184         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5185         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5186         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5187         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5188         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5189         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5190         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5191         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5192         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5193         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5194         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5195         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5196         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5197         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5198         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5199         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5200         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5201         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5202         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5203         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5204         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5205         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5206         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5207
5208 2019-07-10  Tom Tromey  <tromey@adacore.com>
5209
5210         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5211         * breakpoint.c (init_ada_exception_breakpoint): Register as
5212         bp_catchpoint.
5213         (print_one_breakpoint_location, print_one_breakpoint): Use
5214         is_ada_exception_catchpoint.
5215         * ada-lang.c (class ada_catchpoint_location): Pass
5216         bp_loc_software_breakpoint to bp_location constructor.
5217         (is_ada_exception_catchpoint): New function.
5218
5219 2019-07-10  Tom Tromey  <tromey@adacore.com>
5220
5221         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5222         VEC.
5223         (struct arm_exidx_entry): New method operator<.
5224         (struct arm_exidx_data) <section_maps>: Change type.
5225         (arm_exidx_data_free): Remove.
5226         (arm_exidx_data_key): Change type.  Move lower.
5227         (arm_exidx_new_objfile): Update.
5228         (arm_compare_exidx_entries): Remove.
5229         (arm_find_exidx_entry, _initialize_arm_tdep)
5230
5231 2019-07-10  Tom Tromey  <tromey@adacore.com>
5232
5233         * solib-spu.c (ocl_program_data_key): Change type.
5234         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5235         Update.
5236
5237 2019-07-10  Tom Tromey  <tromey@adacore.com>
5238
5239         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5240         (struct solib_aix_inferior_data) <library_list>: Change type.
5241         (solib_aix_inferior_data_handle): Change type.
5242         (get_solib_aix_inferior_data): Update.
5243         (solib_aix_free_library_list): Remove.
5244         (library_list_start_library): Update.
5245         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5246         return type.
5247         (solib_aix_get_library_list)
5248         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5249         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5250
5251 2019-07-10  Tom Tromey  <tromey@adacore.com>
5252
5253         * solib-dsbt.c (struct dsbt_info): Add initializers.
5254         (solib_dsbt_pspace_data): Change type.
5255         (dsbt_pspace_data_cleanup): Remove.
5256         (get_dsbt_info, _initialize_dsbt_solib): Update.
5257
5258 2019-07-10  Tom Tromey  <tromey@adacore.com>
5259
5260         * spu-tdep.c (spu_overlay_data): Change type.
5261         (spu_get_overlay_table, spu_overlay_new_objfile)
5262         (_initialize_spu_tdep): Update.
5263
5264 2019-07-10  Tom Tromey  <tromey@adacore.com>
5265
5266         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5267         destructor.
5268         (dbx_objfile_data_key): Change type and declare later.
5269         (DBX_SYMFILE_INFO): Rewrite.
5270         * dbxread.c (dbx_objfile_data_key): Change type.
5271         (dbx_symfile_init): Update.
5272         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5273         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5274         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5275
5276 2019-07-10  Tom Tromey  <tromey@adacore.com>
5277
5278         * jit.c (jit_program_space_key): Change type.  Move lower.
5279         (get_jit_program_space_data): Update.
5280         (jit_program_space_data_cleanup): Remove.
5281         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5282         Update.
5283         (struct jit_program_space_data): Add initializers.
5284
5285 2019-07-10  Tom Tromey  <tromey@adacore.com>
5286
5287         * solib-darwin.c (struct darwin_info): Add initializers.
5288         (solib_darwin_pspace_data): Change type.
5289         (darwin_pspace_data_cleanup): Remove.
5290         (get_darwin_info, _initialize_darwin_solib): Update.
5291
5292 2019-07-10  Tom Tromey  <tromey@adacore.com>
5293
5294         * remote-sim.c (struct sim_inferior_data): Add initializers,
5295         constructor, and destructor.
5296         (sim_inferior_data_key): Change type.  Move lower.
5297         (check_for_duplicate_sim_descriptor): Update.
5298         (get_sim_inferior_data): Use new.  Update.
5299         (~sim_inferior_data_cleanup): Rename from
5300         sim_inferior_data_cleanup.  Simplify.
5301         (gdbsim_close_inferior, simulator_command)
5302         (sim_command_completer, _initialize_remote_sim): Update.
5303         (next_pid, INITIAL_PID): Move earlier.
5304
5305 2019-07-10  Tom Tromey  <tromey@adacore.com>
5306
5307         * python/python-internal.h (create_thread_object): Return
5308         gdbpy_ref.
5309         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5310         * python/py-inferior.c (struct threadlist_entry): Add
5311         constructor.
5312         <thread_obj>: Now a gdbpy_ref.
5313         (thread_to_thread_object): Update.
5314         (add_thread_object): Use new.
5315         (delete_thread_object): Use delete.
5316         (infpy_threads): Update.
5317         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5318         GIL.
5319
5320 2019-07-10  Tom Tromey  <tromey@adacore.com>
5321
5322         * valops.c (value_cast): Specialize error message for Ada.
5323
5324 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5325
5326         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5327
5328 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5329
5330         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5331         bpstat_should_step): Return bool, adjust comments.
5332         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5333         bpstat_should_step): Likewise.
5334
5335 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5336
5337         * features/Makefile: Use feature target descriptions for Arm.
5338         * features/arm/arm-core.c: Generate new file.
5339         * features/arm/arm-fpa.c: Likewise.
5340         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5341         * features/arm/arm-m-profile.c: Likewise.
5342         * features/arm/arm-vfpv2.c: Likewise.
5343         * features/arm/arm-vfpv3.c: Likewise.
5344         * features/arm/xscale-iwmmxt.c: Likewise.
5345         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5346
5347 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5348
5349         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5350         ptrace earlier.
5351
5352 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5353
5354         * features/aarch64-pauth.c: Regenerate.
5355
5356 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5357
5358         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5359         bool.
5360         (bpstat_what): Use false instead of 0.
5361
5362 2019-07-09  Pedro Alves  <palves@redhat.com>
5363
5364         * break-catch-throw.c (is_exception_catchpoint): New.
5365         * breakpoint.c (print_one_breakpoint_location): New parameter
5366         'raw_loc'.  Handle it.  Use
5367         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5368         looking at the breakpoint's type.
5369         (print_one_breakpoint): If handling "maint info breakpoints", also
5370         print locations of exception catchpoints.
5371         * breakpoint.h (is_exception_catchpoint): Declare.
5372
5373 2019-07-09  Pedro Alves  <palves@redhat.com>
5374
5375         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5376         "addr" field.
5377         (allocate_location_exception_catchpoint): New.
5378         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5379         (initialize_throw_catchpoint_ops): Install
5380         allocate_location_exception_catchpoint as allocate_location
5381         method.
5382         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5383         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5384         bp_loc_other.
5385         (breakpoint_address_is_meaningful): Delete.
5386         (bl_address_is_meaningful): New.
5387         (breakpoint_locations_match): Adjust comment.
5388         (bp_location_from_bp_type): New, factored out of...
5389         (bp_location::bp_location(breakpoint *)): ... this.
5390         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5391         factored out of...
5392         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5393         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5394         breakpoint_address_is_meaningful.
5395         (bp_locations_compare): Adjust comment.
5396         (update_global_location_list): Use bl_address_is_meaningful
5397         instead of breakpoint_address_is_meaningful.
5398         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5399         explicit.
5400         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5401         * python/py-breakpoint.c (bppy_get_location): No longer check
5402         whether location is null.
5403
5404 2019-07-09  Pedro Alves  <palves@redhat.com>
5405
5406         PR c++/15468
5407         * breakpoint.c (print_one_breakpoint_location): Remove
5408         single-location assert.
5409
5410 2019-07-09  Tom Tromey  <tom@tromey.com>
5411
5412         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5413         * configure: Rebuild.
5414         * configure.ac: Change common to gdbsupport.
5415         * gdbsupport: Rename from common.
5416         * acinclude.m4: Change common to gdbsupport.
5417         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5418         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5419         gdbsupport.
5420         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5421         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5422         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5423         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5424         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5425         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5426         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5427         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5428         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5429         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5430         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5431         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5432         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5433         coff-pe-read.c, command.h, compile/compile-c-support.c,
5434         compile/compile-c.h, compile/compile-cplus-symbols.c,
5435         compile/compile-cplus-types.c, compile/compile-cplus.h,
5436         compile/compile-loc2c.c, compile/compile.c, completer.c,
5437         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5438         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5439         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5440         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5441         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5442         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5443         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5444         features/aarch64-core.c, features/aarch64-fpu.c,
5445         features/aarch64-pauth.c, features/aarch64-sve.c,
5446         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5447         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5448         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5449         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5450         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5451         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5452         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5453         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5454         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5455         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5456         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5457         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5458         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5459         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5460         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5461         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5462         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5463         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5464         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5465         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5466         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5467         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5468         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5469         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5470         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5471         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5472         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5473         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5474         minsyms.c, mips-linux-tdep.c, namespace.h,
5475         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5476         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5477         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5478         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5479         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5480         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5481         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5482         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5483         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5484         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5485         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5486         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5487         procfs.c, producer.c, progspace.h, psymtab.h,
5488         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5489         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5490         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5491         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5492         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5493         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5494         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5495         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5496         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5497         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5498         target-memory.c, target.c, target.h, target/waitstatus.c,
5499         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5500         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5501         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5502         unittests/array-view-selftests.c,
5503         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5504         unittests/common-utils-selftests.c,
5505         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5506         unittests/format_pieces-selftests.c,
5507         unittests/function-view-selftests.c,
5508         unittests/lookup_name_info-selftests.c,
5509         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5510         unittests/mkdir-recursive-selftests.c,
5511         unittests/observable-selftests.c,
5512         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5513         unittests/parse-connection-spec-selftests.c,
5514         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5515         unittests/scoped_fd-selftests.c,
5516         unittests/scoped_mmap-selftests.c,
5517         unittests/scoped_restore-selftests.c,
5518         unittests/string_view-selftests.c, unittests/style-selftests.c,
5519         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5520         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5521         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5522         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5523         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5524         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5525
5526 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5529         bool value.
5530         (decode_digits_ordinary): Set explicit_line field in sal.
5531         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5532         symtab_and_line that was set on an explicit line number in
5533         assembler code.  Do always update the recorded symtab and line if
5534         we do skip the prologue.
5535
5536 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * breakpoint.c (set_breakpoint_location_function): Remove
5539         explicit_loc parameter.
5540         (momentary_breakpoint_from_master): Update call to
5541         set_breakpoint_location_function.
5542         (add_location_to_breakpoint): Likewise.
5543
5544 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5547         required features based on default bfd type when no specific bfd
5548         is present.
5549
5550 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5551
5552         * NEWS: Mention that GDB printf and eval commands can now print
5553         C-style and Ada-style convenience var strings without
5554         calling the inferior.
5555         * printcmd.c (printf_c_string): Locally print GDB internal var
5556         instead of transiting via the inferior.
5557         (printf_wide_c_string): Likewise.
5558
5559 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5560
5561         PR breakpoints/25011
5562         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5563
5564 2019-07-04  Tom Tromey  <tom@tromey.com>
5565
5566         PR tui/24724:
5567         * tui/tui-winsource.c (tui_clear_source_content): Update.
5568         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5569         (tui_update_breakpoint_info): Update.
5570         (tui_set_exec_info_content): Update.
5571         * tui/tui-source.c (tui_set_source_content_nil): Update.
5572         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5573         has_break.
5574         * tui/tui-data.h (enum tui_bp_flag): New.
5575         (tui_bp_flags): New enum flags type.
5576         (struct tui_source_element) <break_mode>: Change type.  Rename
5577         from has_break.
5578         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5579         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5580         constants.
5581         * tui/tui-winsource.h: Fix comment.
5582
5583 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5584
5585         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5586         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5587         (store_fpregs_to_thread)
5588         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5589         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5590         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5591         (IWMMXT_REGS_SIZE): Add define.
5592         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5593         (fetch_vfp_regs, store_vfp_regs)
5594         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5595         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5596
5597 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5598
5599         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5600         defines.
5601         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5602         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5603         (ARM_INT_REGISTER_SIZE): ...to this.
5604         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5605         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5606         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5607         (arm_linux_collect_gregset, supply_nwfpe_register)
5608         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5609         defines.
5610         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5611         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5612         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5613         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5614         (arm_return_in_memory, arm_store_return_value)
5615         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5616         (arm_record_ld_st_multiple): Likewise.
5617         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5618         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5619
5620 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5621
5622         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5623         AARCH64_DISPLACED_MODIFIED_INSNS.
5624         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5625         (aarch64_displaced_step_copy_insn): Likewise.
5626         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5627         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5628         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5629         ARM_DISPLACED_MODIFIED_INSNS.
5630         * arm-tdep.c (arm_gdbarch_init): Likewise.
5631         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5632         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5633         (struct arm_displaced_step_closure): Use
5634         ARM_DISPLACED_MODIFIED_INSNS.
5635
5636 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5637
5638         * features/Makefile: Remove unused xml files.
5639         * features/aarch64.xml: Remove.
5640         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5641         * features/i386/amd64-avx-avx512.xml: Remove.
5642         * features/i386/amd64-avx-linux.xml: Remove.
5643         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5644         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5645         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5646         * features/i386/amd64-avx-mpx.xml: Remove.
5647         * features/i386/amd64-avx.xml: Remove.
5648         * features/i386/amd64-linux.xml: Remove.
5649         * features/i386/amd64-mpx-linux.xml: Remove.
5650         * features/i386/amd64-mpx.xml: Remove.
5651         * features/i386/amd64.xml: Remove.
5652         * features/i386/i386-avx-avx512-linux.xml: Remove.
5653         * features/i386/i386-avx-avx512.xml: Remove.
5654         * features/i386/i386-avx-linux.xml: Remove.
5655         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5656         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5657         * features/i386/i386-avx-mpx-linux.xml: Remove.
5658         * features/i386/i386-avx-mpx.xml: Remove.
5659         * features/i386/i386-avx.xml: Remove.
5660         * features/i386/i386-linux.xml: Remove.
5661         * features/i386/i386-mmx-linux.xml: Remove.
5662         * features/i386/i386-mmx.xml: Remove.
5663         * features/i386/i386-mpx-linux.xml: Remove.
5664         * features/i386/i386-mpx.xml: Remove.
5665         * features/i386/i386.xml: Remove.
5666         * features/i386/x32-avx-avx512-linux.xml: Remove.
5667         * features/i386/x32-avx-linux.xml: Remove.
5668         * features/i386/x32-linux.xml: Remove.
5669
5670 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5671
5672         * regformats/aarch64.dat: Remove.
5673         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5674         * regformats/i386/amd64-avx-linux.dat: Remove.
5675         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5676         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5677         * regformats/i386/amd64-linux.dat: Remove.
5678         * regformats/i386/amd64-mpx-linux.dat: Remove.
5679         * regformats/i386/amd64.dat: Remove.
5680         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5681         * regformats/i386/i386-avx-linux.dat: Remove.
5682         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5683         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5684         * regformats/i386/i386-linux.dat: Remove.
5685         * regformats/i386/i386-mmx-linux.dat: Remove.
5686         * regformats/i386/i386-mpx-linux.dat: Remove.
5687         * regformats/i386/i386.dat: Remove.
5688         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5689         * regformats/i386/x32-avx-linux.dat: Remove.
5690         * regformats/i386/x32-linux.dat: Remove.
5691
5692 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5693
5694         * aarch64-tdep.c: Remove xml self tests.
5695         * amd64-linux-tdep.c: Likewise.
5696         * amd64-tdep.c: Likewise.
5697         * i386-linux-tdep.c: Likewise.
5698         * i386-tdep.c: Likewise.
5699
5700 2019-07-03  Pedro Alves  <palves@redhat.com>
5701
5702         PR cli/24732
5703         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5704         (pipe_cmd_option_defs): New.
5705         (make_pipe_cmd_options_def_group): New.
5706         (pipe_command): Use gdb::option::process_options.
5707         (pipe_command_completer): New function.
5708         (_initialize_cli_cmds): Install completer for "pipe" command.
5709
5710 2019-07-03  Pedro Alves  <palves@redhat.com>
5711
5712         * cli/cli-option.c (union option_value) <string>: New field.
5713         (struct option_def_and_value): Add ctor, move ctor, dtor and
5714         use DISABLE_COPY_AND_ASSIGN.
5715         (option_def_and_value::clear_value): New.
5716         (parse_option, save_option_value_in_ctx, get_val_type_str)
5717         (add_setshow_cmds_for_options): Handle var_string.
5718         * cli-option.h (union option_def::var_address) <string>: New
5719         field.
5720         (struct string_option_def): New.
5721         * maint-test-options.c (struct test_options_opts): Add default
5722         ctor and use DISABLE_COPY_AND_ASSIGN.
5723         <string_opt>: New field.
5724         (test_options_opts::~test_options_opts): New.
5725         (test_options_opts::dump): Also dump "-string".
5726         (test_options_option_defs): Install "string.
5727
5728 2019-07-03  Pedro Alves  <palves@redhat.com>
5729
5730         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5731         option_value with a null enumeration.
5732         (complete_options): Save the option values in the context.
5733         (save_option_value_in_ctx): New, factored out from ...
5734         (process_options): ... here.
5735         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5736         of the function.
5737         * maint-test-options.c (test_options_opts::dump): New, factored
5738         out from ...
5739         (maintenance_test_options_command_mode): ... here.
5740         (maintenance_test_options_command_completion_result): Delete.
5741         (maintenance_test_options_command_completion_text): Update
5742         comment.
5743         (maintenance_show_test_options_completion_result): Change
5744         prototype.  Just print
5745         maintenance_test_options_command_completion_text.
5746         (save_completion_result): New.
5747         (maintenance_test_options_completer_mode): Pass options context to
5748         complete_options, and then save a dump.
5749         (_initialize_maint_test_options): Use add_cmd to install "maint
5750         show test-options-completion-result".
5751
5752 2019-07-03  Pedro Alves  <palves@redhat.com>
5753
5754         * NEWS (New commands): Mention "with" and "maint with".
5755         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5756         (with_command, with_command_completer): New.
5757         (pipe_command): Adjust to new repeat_previous
5758         interface.
5759         (_initialize_cli_cmds): Install the "with" command and its "w"
5760         alias.
5761         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5762         declarations.
5763         * cli/cli-setshow.c (parse_cli_var_uinteger)
5764         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5765         argument strings for all var_types.
5766         (get_setshow_command_value_string): New, factored out from ...
5767         (do_show_command): ... this.
5768         * cli/cli-setshow.h: Include <string>.
5769         (get_setshow_command_value_string): Declare.
5770         * command.h (repeat_previous): Now returns const char *.  Adjust
5771         comment.
5772         * maint.c: Include "cli/cli-cmds.h".
5773         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5774         (_initialize_maint_cmds): Register the "maintenance with" command.
5775         * top.c (repeat_previous): Move bits from pipe_command here:
5776         Return the saved command line, if any; error out if there's no
5777         command to relaunch.
5778
5779 2019-07-03  Pedro Alves  <palves@redhat.com>
5780
5781         * NEWS (New commands): Mention "maint set/show test-settings"
5782         instead of "maint test-settings".
5783         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5784         (maintenance_test_settings_set_list): Rename to ...
5785         (maintenance_set_test_settings_list): ... this.
5786         (maintenance_test_settings_show_list): Rename to  ...
5787         (maintenance_show_test_settings_list): ... this.
5788         (maintenance_test_settings_cmd): Delete.
5789         (maintenance_test_settings_set_cmd): ...
5790         (maintenance_set_test_settings_cmd): ... this.
5791         (maintenance_test_settings_show_cmd): ...
5792         (maintenance_show_test_settings_cmd): ... this.
5793         (maintenance_test_settings_show_value_cmd):
5794         (maintenance_show_test_settings_value_cmd): ... this.
5795         (_initialize_maint_test_settings): No longer install the "maint
5796         test-settings" prefix command.  Rename "maint test-settings set"
5797         to "maint set test-settings", and "maint test-settings show" to
5798         "maint show test-settings".  Adjust all subcommands.
5799
5800 2019-07-03  Pedro Alves  <palves@redhat.com>
5801
5802         * maint-test-settings.c: Fix file's intro comment.  Replace all
5803         references to "test-options" with references to "test-settings",
5804         in comments.
5805
5806 2019-07-03  Pedro Alves  <palves@redhat.com>
5807
5808         * maint-test-settings.c (maintenance_test_settings_xxx)
5809         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5810         New.
5811         (maintenance_test_settings_enums): Use them.
5812         (maintenance_test_settings_enum): Default to
5813         maintenance_test_settings_xxx.
5814         (_initialize_maint_test_settings): Initialize
5815         MAINTENANCE_TEST_SETTINGS_FILENAME.
5816
5817 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5818
5819         * breakpoint.h (remove_breakpoints_inf): Change return type to
5820         void, move function documentation here.
5821         * breakpoint.c (remove_breakpoints_inf): Change return type to
5822         void, move function documentation to header.
5823
5824 2019-07-02  Pedro Alves  <palves@redhat.com>
5825
5826         * NEWS (Completion improvements): Mention "info threads".
5827         * thread.c (struct info_threads_opts, info_threads_option_defs)
5828         (make_info_threads_options_def_group): New.
5829         (info_threads_command): Use gdb::option::process_options.
5830         (info_threads_command_completer): New.
5831         (_initialize_thread): Use gdb::option::build_help to build the
5832         help text for "info threads".
5833
5834 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5835
5836         * defs.h (generic_load): Move from here...
5837         * symfile.h (generic_load): ... to here.  Rename name parameter
5838         to args.
5839         * symfile.c (generic_load): Add comment.
5840
5841 2019-07-01  Tom Tromey  <tromey@adacore.com>
5842
5843         * dwarf2read.c
5844         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5845         declaration of without_params.  Fix formatting.
5846
5847 2019-07-01  Tom Tromey  <tromey@adacore.com>
5848
5849         * ada-exp.y (find_primitive_type): Update.
5850         * ada-lang.h (ada_lookup_symbol): Update.
5851         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5852         parameter.
5853         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5854
5855 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5856
5857         PR breakpoints/24541
5858         * gdbarch.c: Regenerate.
5859         * gdbarch.h: Regenerate.
5860         * gdbarch.sh: Add 'stap_adjust_register'.
5861         * i386-tdep.c: Include '<unordered_set>'.
5862         (i386_stap_adjust_register): New function.
5863         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5864         * stap-probe.c (stap_parse_register_operand): Call
5865         'gdbarch_stap_adjust_register'.
5866
5867 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5868
5869         PR python/24742
5870         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5871         * python/python.c (do_start_initialization): Use 'xmalloc'
5872         instead of 'PyMem_Malloc'.
5873
5874 2019-06-28  Tom Tromey  <tromey@adacore.com>
5875
5876         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5877         for Ada.
5878
5879 2019-06-27  Tom Tromey  <tromey@adacore.com>
5880
5881         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5882         objfile_key.
5883         (arm_find_mapping_symbol, arm_record_special_symbol)
5884         (_initialize_arm_tdep): Update.
5885         (arm_objfile_data_free): Remove.
5886
5887 2019-06-27  Tom Tromey  <tromey@adacore.com>
5888
5889         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5890         to cp_print_static_field.
5891
5892 2019-06-26  Tom Tromey  <tromey@adacore.com>
5893
5894         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5895         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5896         declare.
5897
5898 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5899
5900         * features/aarch64-core.c (create_feature_aarch64_core):
5901         Regenerate.
5902         * features/aarch64-core.xml: Add cpsr flags.
5903
5904 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5905
5906         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5907         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5908
5909 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5910
5911         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5912         field.
5913         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5914         use.
5915         (arm_record_special_symbol): Don't insert new symbol in sorted
5916         position, push it at the end.
5917
5918 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5919
5920         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5921         (arm_mapping_symbol_s): Remove.
5922         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5923         (arm_mapping_symbol_vec): New typedef.
5924         (struct arm_per_objfile): Add constructor.
5925         <section_maps>: Change type to
5926         std::unique_ptr<arm_mapping_symbol_vec[]>.
5927         (arm_compare_mapping_symbols): Remove.
5928         (arm_find_mapping_symbol): Adjust to section_maps type change.
5929         (arm_objfile_data_free): Call delete on arm_per_objfile.
5930         (arm_record_special_symbol): Adjust to section_maps type change.
5931         Allocate arm_per_objfile with new.
5932
5933 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5934
5935         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5936         with the command prefix.
5937
5938 2019-06-25  Tom Tromey  <tom@tromey.com>
5939
5940         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5941         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5942
5943 2019-06-25  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5946         type.
5947         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5948         protected.
5949
5950 2019-06-25  Tom Tromey  <tom@tromey.com>
5951
5952         * tui/tui-winsource.c
5953         (tui_source_window_base::set_is_exec_point_at): Add check against
5954         LOA_ADDRESS.
5955
5956 2019-06-25  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-source.c (tui_set_source_content): Don't check before
5959         xfree.
5960         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-winsource.h (tui_update_source_window_as_is)
5965         (tui_alloc_source_buffer, tui_line_is_displayed)
5966         (tui_addr_is_displayed): Change type of win_info.
5967         * tui/tui-winsource.c (tui_update_source_window_as_is)
5968         (tui_clear_source_content, tui_show_source_line)
5969         (tui_show_source_content, tui_source_window_base::refill)
5970         (tui_source_window_base::set_is_exec_point_at)
5971         (tui_source_window_base::set_is_exec_point_at)
5972         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5973         (tui_alloc_source_buffer, tui_line_is_displayed)
5974         (tui_addr_is_displayed): Change type of win_info.  Update.
5975         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5976         (tui_source_window_base::do_make_visible_with_new_height):
5977         Update.
5978         * tui/tui-source.c (tui_set_source_content)
5979         (tui_set_source_content_nil)
5980         (tui_source_window::do_scroll_vertical): Update.
5981         * tui/tui-layout.c (show_layout): Update.
5982         * tui/tui-disasm.c (tui_set_disassem_content)
5983         (tui_disasm_window::do_scroll_vertical): Update.
5984         * tui/tui-data.h (tui_win_content): Remove.
5985         (struct tui_gen_win_info) <content, content_size>: Remove.
5986         (struct tui_source_element): Add initializers and destructor.
5987         (union tui_which_element, struct tui_win_element): Remove.
5988         (struct tui_source_window_base) <content>: New field.
5989         (struct tui_data_window): Remove destructor.
5990         (tui_alloc_content, tui_free_win_content)
5991         (tui_free_all_source_wins_content): Don't declare.
5992         * tui/tui-data.c (tui_initialize_static_data): Update.
5993         (init_content_element, tui_alloc_content): Remove.
5994         (~tui_gen_win_info): Update.
5995         (~tui_data_window, tui_free_all_source_wins_content)
5996         (tui_free_win_content, free_content, free_content_elements):
5997         Remove.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-winsource.h (tui_clear_source_content)
6002         (tui_erase_source_content, tui_show_source_content): Change type
6003         of win_info.
6004         * tui/tui-winsource.c (tui_clear_source_content)
6005         (tui_erase_source_content, tui_show_source_content): Change type
6006         of win_info.
6007         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6008         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6009         win_info.
6010         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6011         win_info.
6012         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6013
6014 2019-06-25  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui-winsource.c (tui_clear_source_content)
6017         (tui_source_window_base::set_is_exec_point_at): Update.
6018         * tui/tui-source.c (tui_set_source_content_nil): Update.
6019         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6020         a bool.
6021         * tui/tui-data.c (init_content_element): Update.
6022
6023 2019-06-25  Tom Tromey  <tom@tromey.com>
6024
6025         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6026         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6027         * tui/tui-layout.c (init_and_make_win): Update.
6028         * tui/tui.h (enum tui_win_type): Update.
6029         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6030         tui_win_is_auxillary.
6031         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6032         tui_win_is_auxillary.
6033
6034 2019-06-25  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6037         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6038         (tui_delete_data_content_windows, tui_display_all_data)
6039         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6040         Update.
6041         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6042         * tui/tui-regs.c (tui_last_regs_line_no)
6043         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6044         (tui_show_registers): Update.
6045         (tui_show_register_group): Return void.  Update.
6046         (tui_display_registers_from, tui_display_reg_element_at_line)
6047         (tui_display_registers_from_line, tui_check_register_values):
6048         Update.
6049         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6050         member.
6051         (struct tui_data_window) <regs_content>: Now a std::vector.
6052         <regs_content_count>: Remove.
6053         (tui_add_content_elements, tui_free_data_content): Don't declare.
6054         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6055         (init_content_element): Remove DATA_WIN case.  Add assert.
6056         (tui_add_content_elements): Remove.
6057         (tui_data_window): Update.
6058         (tui_free_data_content): Remove.
6059         (free_content_elements): Remove DATA_WIN case.
6060
6061 2019-06-25  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-data.c (tui_data_item_window): Update.
6064         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6065         * tui/tui-windata.c (tui_display_all_data)
6066         (tui_display_data_from_line): Update.
6067         (tui_check_data_values): Remove.
6068         * tui/tui-regs.c (tui_show_register_group)
6069         (tui_display_reg_element_at_line): Update.
6070         * tui/tui-hooks.c (tui_register_changed)
6071         (tui_refresh_frame_and_register_information): Call
6072         tui_check_register_values.
6073         * tui/tui-data.h (struct tui_data_window) <data_content,
6074         data_content_count, data_type>: Remove.
6075         (enum tui_data_type): Remove.
6076
6077         * tui/tui-data.c (tui_data_window::clear_detail)
6078         (~tui_data_window): Update.
6079
6080 2019-06-25  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6083         declare.
6084         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6085         Rename from tui_first_data_item_displayed.  Update.
6086         (tui_data_window::refresh_all)
6087         (tui_data_window::do_scroll_vertical): Update.
6088         * tui/tui-data.h (struct tui_data_window)
6089         <first_data_item_displayed>: Declare new method.
6090
6091 2019-06-25  Tom Tromey  <tom@tromey.com>
6092
6093         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6094         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6095         contents...
6096         (tui_initialize_static_data): ...here.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6101         (tui_display_registers_from, tui_check_register_values): Update.
6102         (tui_display_register): Remove win_info parameter; update.
6103         (tui_get_register): Change type of parameters.
6104         * tui/tui-data.h (struct tui_data_element): Remove.
6105         (union tui_which_element) <data>: Remove.
6106         <data_window>: Change type.
6107         (struct tui_data_item_window): New.
6108         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6109         case.  Add assert.
6110         (~tui_data_item_window): New destructor.
6111         (free_content_elements): Remove DATA_ITEM_WIN case.
6112
6113 2019-06-25  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6116         Remove.
6117
6118 2019-06-25  Tom Tromey  <tom@tromey.com>
6119
6120         * tui/tui-data.h (struct tui_command_element): Remove.
6121         (union tui_which_element) <command>: Remove.
6122         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6123         assert.
6124         (free_content_elements): Remove CMD_WIN case.
6125
6126 2019-06-25  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-layout.c (tui_set_layout): Update.
6129         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6130         * tui/tui-data.c (layout_def): Update.
6131
6132 2019-06-25  Tom Tromey  <tom@tromey.com>
6133
6134         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6136         (tui_source_window_base::set_new_height): Update.
6137         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6138         Update.
6139         (tui_set_locator_fullname, tui_set_locator_info)
6140         (tui_show_frame_info): Update.
6141         * tui/tui-source.c (tui_set_source_content)
6142         (tui_source_is_displayed): Update.
6143         * tui/tui-layout.c (show_source_disasm_command, show_data)
6144         (show_source_or_disasm_and_command): Update.
6145         * tui/tui-disasm.c (tui_set_disassem_content)
6146         (tui_get_begin_asm_address): Update.
6147         * tui/tui-data.h (struct tui_locator_element): Remove.
6148         (union tui_which_element) <locator>: Remove.
6149         (struct tui_locator_window): New.
6150         (tui_locator_win_info_ptr): Change return type.
6151         * tui/tui-data.c (_locator): Change type.
6152         (tui_locator_win_info_ptr): Change return type.
6153         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6154         (tui_alloc_content): Add assert.
6155
6156 2019-06-25  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-winsource.c
6159         (tui_exec_info_window::maybe_allocate_content): New method.
6160         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6161         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6162         (make_source_or_disasm_window): Add cast.
6163         * tui/tui-data.h (union tui_which_element) <simple_string>:
6164         Remove.
6165         (struct tui_source_info): New.
6166         (struct tui_source_window_base) <execution_info>: Change type.
6167         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6168         case, and add assert.
6169         (tui_alloc_content): Add assert.
6170
6171 2019-06-25  Tom Tromey  <tom@tromey.com>
6172
6173         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6174         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6175         * tui/tui-data.c (tui_alloc_win_info): Remove.
6176
6177 2019-06-25  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6180         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6181         can_highlight.
6182
6183 2019-06-25  Tom Tromey  <tom@tromey.com>
6184
6185         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6186         make_visible_with_new_height method.
6187         (tui_win_info::make_visible_with_new_height): New method.
6188         (tui_source_window_base::do_make_visible_with_new_height)
6189         (tui_data_window::do_make_visible_with_new_height)
6190         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6191         (make_visible_with_new_height): Remove.
6192         (tui_resize_all, tui_adjust_win_heights): Use
6193         make_visible_with_new_height method.
6194         * tui/tui-data.h (struct tui_win_info)
6195         <do_make_visible_with_new_height, make_visible_with_new_height>:
6196         New methods.
6197         (struct tui_source_window_base, struct tui_data_window)
6198         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6199         methods.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6204         method.
6205         (update_tab_width): Call update_tab_width method.
6206         * tui/tui-data.h (struct tui_win_info)
6207         (struct tui_source_window_base) <update_tab_width>: New methods.
6208
6209 2019-06-25  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6212         parameter.
6213         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6214         parameter.
6215         (tui_gen_win_info::make_visible): Update.
6216         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6217         parameter.
6218         * tui/tui-data.h (enum tui_box): New enum.
6219         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6220
6221 2019-06-25  Tom Tromey  <tom@tromey.com>
6222
6223         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6224         init_and_make_win for EXEC_INFO_WIN.
6225         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6226         longer inline.
6227         (struct tui_win_info) <~tui_win_info>: Inline.
6228         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6229         Don't declare.
6230         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6231         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6232         Remove.
6233         (tui_initialize_static_data): Update.
6234         (~tui_gen_win_info): Handle more cleanup here.
6235         (~tui_source_window_base): Delete "execution_info".
6236         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6237
6238 2019-06-25  Tom Tromey  <tom@tromey.com>
6239
6240         * tui/tui-layout.c (make_command_window): Don't set
6241         can_highlight.
6242         (show_source_disasm_command): Call the reset method.
6243         (show_data): Don't set can_highlight.  Call the reset method.
6244         (tui_gen_win_info::reset): Rename from init_gen_win_info
6245         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6246         (show_source_or_disasm_and_command): Call the reset method.
6247         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6248         (struct tui_cmd_window): Set can_highlight.
6249
6250 2019-06-25  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6253         from make_visible.
6254         (tui_make_visible, tui_make_invisible): Rewrite.
6255         (tui_win_info::make_visible): Remove.
6256         (tui_source_window_base::make_visible): Update.
6257         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6258         method.  Moved from...
6259         (struct tui_win_info) <make_visible>: ...here.
6260
6261 2019-06-25  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-winsource.c
6264         (tui_source_window_base::do_scroll_horizontal): Remove direction
6265         parameter.
6266         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6267         direction parameter.
6268         * tui/tui-win.c (tui_win_info::forward_scroll)
6269         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6270         (tui_win_info::right_scroll): Update.
6271         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6272         direction parameter.
6273         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6274         direction parameter.
6275         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6276         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6277         Remove direction parameter.
6278         (struct tui_source_window_base, struct tui_source_window)
6279         (struct tui_disasm_window, struct tui_data_window)
6280         (struct tui_cmd_window): Update.
6281
6282 2019-06-25  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui-winsource.h (tui_set_exec_info_content)
6285         (tui_show_exec_info_content, tui_erase_exec_info_content)
6286         (tui_clear_exec_info_content, tui_update_exec_info): Change
6287         argument to tui_source_window_base.
6288         * tui/tui-winsource.c (tui_set_exec_info_content)
6289         (tui_show_exec_info_content, tui_erase_exec_info_content)
6290         (tui_clear_exec_info_content, tui_update_exec_info): Change
6291         argument to tui_source_window_base.
6292
6293 2019-06-25  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6296         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6297
6298 2019-06-25  Tom Tromey  <tom@tromey.com>
6299
6300         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6301         check.
6302
6303 2019-06-25  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6306         type to void.
6307         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6308         type to void.
6309         * tui/tui-source.c (tui_set_source_content): Update.
6310         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6311
6312 2019-06-25  Tom Tromey  <tom@tromey.com>
6313
6314         * tui/tui-win.c (window_name_completer, tui_set_focus)
6315         (tui_all_windows_info): Use name method.
6316         * tui/tui-data.h (struct tui_gen_win_info)
6317         (struct tui_source_window, struct tui_disasm_window)
6318         (struct tui_data_window, struct tui_cmd_window) <name>: New
6319         method.
6320         (tui_win_name): Don't declare.
6321         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6322         (tui_win_name): Remove.
6323
6324 2019-06-25  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui-winsource.h (tui_update_source_window)
6327         (tui_update_source_window_as_is): Change parameter type.
6328         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6329         to be a tui_source_window_base.
6330         (tui_update_source_window_as_is): Likewise.
6331         * tui/tui-win.c (make_visible_with_new_height): Update.
6332
6333 2019-06-25  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-winsource.c (tui_erase_source_content)
6336         (tui_show_source_content, tui_show_exec_info_content)
6337         (tui_erase_exec_info_content): Use refresh_window method.
6338         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6339         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6340         from tui_refresh_win.
6341         (tui_data_window::refresh_window): New method.
6342         (tui_win_info::refresh, tui_source_window_base::refresh)
6343         (tui_refresh_all): Use refresh_window method.
6344         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6345         method.
6346         * tui/tui-regs.c (tui_display_register): Call refresh_window
6347         method.
6348         * tui/tui-layout.c (show_source_disasm_command)
6349         (show_source_or_disasm_and_command): Call refresh_window method.
6350         * tui/tui-data.h (struct tui_gen_win_info)
6351         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6352         New method.
6353
6354 2019-06-25  Tom Tromey  <tom@tromey.com>
6355
6356         * tui/tui.c (tui_rl_other_window, tui_enable)
6357         (tui_is_window_visible, tui_get_command_dimension): Update.
6358         * tui/tui-winsource.c (tui_update_source_window_as_is)
6359         (tui_clear_source_content, tui_erase_source_content)
6360         (tui_show_source_line, tui_source_window_base::refill)
6361         (tui_source_window_base::do_scroll_horizontal)
6362         (tui_source_window_base::set_is_exec_point_at)
6363         (tui_update_breakpoint_info, tui_set_exec_info_content)
6364         (tui_alloc_source_buffer, tui_line_is_displayed)
6365         (tui_addr_is_displayed): Update.
6366         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6367         (tui_check_and_display_highlight_if_needed)
6368         (tui_win_info::make_visible, tui_win_info::refresh)
6369         (tui_refresh_all): Update.
6370         * tui/tui-windata.c (tui_first_data_item_displayed)
6371         (tui_delete_data_content_windows, tui_erase_data_content)
6372         (tui_display_all_data, tui_data_window::refresh_all)
6373         (tui_check_data_values): Update.
6374         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6375         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6376         (tui_win_info::backward_scroll, tui_refresh_all_win)
6377         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6378         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6379         (tui_source_window_base::set_new_height)
6380         (tui_data_window::set_new_height)
6381         (make_invisible_and_set_new_height)
6382         (make_visible_with_new_height, new_height_ok)
6383         (parse_scrolling_args): Update.
6384         * tui/tui-stack.c (tui_show_frame_info): Update.
6385         * tui/tui-source.c (tui_set_source_content)
6386         (tui_set_source_content_nil, tui_source_is_displayed)
6387         (tui_source_window::do_scroll_vertical): Update.
6388         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6389         (tui_display_registers_from, tui_display_reg_element_at_line)
6390         (tui_check_register_values, tui_reg_command): Update.
6391         * tui/tui-layout.c (tui_default_win_height)
6392         (show_source_disasm_command, show_data, init_and_make_win)
6393         (show_source_or_disasm_and_command): Update.
6394         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6395         (tui_redisplay_readline, tui_mld_flush)
6396         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6397         (tui_getc): Update.
6398         * tui/tui-disasm.c (tui_set_disassem_content)
6399         (tui_disasm_window::do_scroll_vertical): Update.
6400         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6401         Now virtual.
6402         (struct tui_win_info): Derive from tui_gen_win_info.
6403         <~tui_win_info>: Mark as override.
6404         <generic>: Remove member.
6405         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6406         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6407         (~tui_data_window, ~tui_win_info)
6408         (tui_free_all_source_wins_content): Update.
6409         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6410
6411 2019-06-25  Tom Tromey  <tom@tromey.com>
6412
6413         * tui/tui-layout.c (init_and_make_win): Use new.
6414         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6415         destructor, initializers.
6416         (tui_alloc_generic_win_info): Don't declare.
6417         * tui/tui-data.c (_locator): Add argument to constructor.
6418         (source_win, disasm_win): New globals.
6419         (exec_info): Remove.
6420         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6421         Update.
6422         (tui_alloc_generic_win_info): Remove.
6423         (init_content_element): Use new.
6424         (tui_win_info::tui_win_info): Update.
6425         (free_content_elements) <case DATA_WIN>: Use delete.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6430         * tui/tui-windata.c (tui_first_data_item_displayed)
6431         (tui_delete_data_content_windows): Update.
6432         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6433         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6434         (tui_display_registers_from, tui_check_register_values): Update.
6435         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6436         pointer.
6437         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6438         window.
6439         (tui_free_data_content): Update.
6440         (free_content_elements) <case DATA_WIN>: Free the window.
6441
6442 2019-06-25  Tom Tromey  <tom@tromey.com>
6443
6444         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6445         Update.
6446         * tui/tui-layout.c (make_command_window)
6447         (show_source_disasm_command, show_data, init_and_make_win)
6448         (show_source_or_disasm_and_command): Update.
6449         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6450         method.
6451         <can_highight, is_highlighted>: Now bool.
6452         (tui_set_win_highlight): Don't declare.
6453         * tui/tui-data.c (tui_set_win_highlight): Remove.
6454
6455 2019-06-25  Tom Tromey  <tom@tromey.com>
6456
6457         * tui/tui-wingeneral.c (make_visible): Remove check of window
6458         type.
6459
6460 2019-06-25  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-win.c (tui_win_info::max_height)
6463         (tui_cmd_window::max_height): New methods.
6464         (new_height_ok): Call max_height.
6465         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6466         <max_height>: New method.
6467
6468 2019-06-25  Tom Tromey  <tom@tromey.com>
6469
6470         * tui/tui-win.c (tui_source_window_base::set_new_height)
6471         (tui_data_window::set_new_height): New methods.
6472         (make_invisible_and_set_new_height): Call set_new_height method.
6473         * tui/tui-data.h (struct tui_win_info)
6474         (struct tui_source_window_base, struct tui_data_window)
6475         <set_new_height>: New method.
6476
6477 2019-06-25  Tom Tromey  <tom@tromey.com>
6478
6479         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6480         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6481         tui_refresh_data_win.
6482         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6483         method.
6484         (tui_refresh_all_win): Call the refresh_all method.
6485         (tui_set_focus): Likewise.
6486         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6487         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6488         Likewise.
6489
6490 2019-06-25  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-winsource.h (tui_refill_source_window)
6493         (tui_set_is_exec_point_at): Don't declare.
6494         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6495         (tui_source_window_base::refill): Rename from
6496         tui_refill_source_window.
6497         (tui_source_window_base::do_scroll_horizontal): Update.
6498         (tui_source_window_base::set_is_exec_point_at): Rename from
6499         tui_set_is_exec_point_at.
6500         (tui_update_all_breakpoint_info): Update.
6501         * tui/tui-stack.c (tui_show_frame_info): Update.
6502         * tui/tui-layout.c (show_data): Add cast.
6503         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6504         * tui/tui-data.h (struct tui_source_window_base) <refill,
6505         set_is_exec_point_at>: New methods.
6506         (tui_source_windows, tui_add_to_source_windows): Update types.
6507         (tui_add_to_source_windows): Remove redundant declaration.
6508         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6509         (tui_source_windows): Change return type.
6510         (tui_clear_source_windows_detail): Update.
6511         (tui_add_to_source_windows): Change type of parameter.
6512         (tui_free_all_source_wins_content): Update.
6513
6514 2019-06-25  Tom Tromey  <tom@tromey.com>
6515
6516         * tui/tui-wingeneral.c (tui_win_info::refresh)
6517         (tui_source_window_base::refresh): New methods.
6518         (tui_refresh_all): Call the refresh method.
6519         * tui/tui-data.h (struct tui_win_info)
6520         (struct tui_source_window_base) <refresh>: New method.
6521
6522 2019-06-25  Tom Tromey  <tom@tromey.com>
6523
6524         * tui/tui.h (tui_is_window_visible): Return bool.
6525         * tui/tui.c (tui_is_window_visible): Return bool.
6526         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6527         (tui_make_visible, tui_make_invisible)
6528         (tui_win_info::make_visible)
6529         (tui_source_window_base::make_visible, make_all_visible)
6530         (tui_make_all_visible, tui_make_all_invisible): Update.
6531         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6532         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6533         bool.
6534         (struct tui_win_info, struct tui_source_window_base)
6535         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6536         * tui/tui-data.c (tui_init_generic_part): Update.
6537
6538 2019-06-25  Tom Tromey  <tom@tromey.com>
6539
6540         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6541         (tui_source_window_base::make_visible): New methods.
6542         (make_all_visible): Make method call.
6543         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6544         (struct tui_source_window_base, struct tui_cmd_window): Override
6545         make_visible.
6546         (tui_win_is_source_type): Don't declare.
6547         * tui/tui-data.c (tui_win_is_source_type): Remove.
6548
6549 2019-06-25  Tom Tromey  <tom@tromey.com>
6550
6551         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6552         NULL check.
6553
6554 2019-06-25  Tom Tromey  <tom@tromey.com>
6555
6556         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6557         Inline constructor.  Add initializers for members.
6558         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6559         constructors; now inline in class.
6560
6561 2019-06-25  Tom Tromey  <tom@tromey.com>
6562
6563         * tui/tui-regs.c (tui_show_registers): Update.
6564         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6565         bool.
6566         * tui/tui-data.c (tui_data_window::clear_detail)
6567         (tui_data_window): Update.
6568
6569 2019-06-25  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-windata.c (tui_display_all_data)
6572         (tui_display_data_from_line, tui_display_data_from)
6573         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6574         Update.
6575         * tui/tui-regs.c (tui_last_regs_line_no)
6576         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6577         (tui_show_registers, tui_show_register_group)
6578         (tui_display_registers_from, tui_display_reg_element_at_line)
6579         (tui_display_registers_from_line, tui_check_register_values)
6580         (tui_reg_next, tui_reg_prev): Update.
6581         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6582         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6583         tui_data_window.
6584         (struct tui_win_info) <detail>: Remove.  Add new fields from
6585         tui_data_info.
6586         (TUI_DATA_WIN): Add cast.
6587         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6588         (~tui_data_window): Simplify.
6589
6590 2019-06-25  Tom Tromey  <tom@tromey.com>
6591
6592         * tui/tui-layout.c (show_source_disasm_command)
6593         (show_source_or_disasm_and_command): Update.
6594         * tui/tui-io.c (update_cmdwin_start_line)
6595         (tui_redisplay_readline): Update.
6596         * tui/tui-data.h (struct tui_command_info): Remove.
6597         (struct tui_win_info) <detail>: Remove command_info member.
6598         (struct tui_data_window) <start_line>: New member, from
6599         tui_command_info.
6600         (TUI_CMD_WIN): Add casts.
6601
6602 2019-06-25  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-winsource.c (tui_update_source_window)
6605         (tui_refill_source_window)
6606         (tui_source_window_base::do_scroll_horizontal)
6607         (tui_update_breakpoint_info, tui_set_exec_info_content)
6608         (tui_show_exec_info_content, tui_erase_exec_info_content)
6609         (tui_clear_exec_info_content): Update.
6610         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6611         Update.
6612         * tui/tui-win.c (make_invisible_and_set_new_height)
6613         (make_visible_with_new_height): Update.
6614         * tui/tui-source.c (tui_set_source_content)
6615         (tui_show_symtab_source): Update.
6616         * tui/tui-layout.c (extract_display_start_addr)
6617         (show_source_disasm_command, show_data)
6618         (make_source_or_disasm_window)
6619         (show_source_or_disasm_and_command): Update.
6620         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6621         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6622         "gdbarch".
6623         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6624         to tui_source_window_base.
6625         (struct tui_win_info) <detail>: Remove source_info member.
6626         (struct tui_source_window_base) <has_locator>: Inline.
6627         Move contents from tui_source_info; rename has_locator member to
6628         m_has_locator.
6629         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6630         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6631         header file.
6632         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6633         Simplify.
6634         (tui_free_all_source_wins_content): Cast to
6635         tui_source_window_base.
6636
6637 2019-06-25  Tom Tromey  <tom@tromey.com>
6638
6639         * tui/tui-win.c (make_invisible_and_set_new_height)
6640         (make_visible_with_new_height): Call has_locator method.
6641         * tui/tui-layout.c (show_source_disasm_command, show_data)
6642         (show_source_or_disasm_and_command): Update for bool change.
6643         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6644         (tui_win_info) <has_locator>: New method.
6645         (struct tui_source_window_base) <has_locator>: New method.
6646         (tui_win_has_locator): Don't declare.
6647         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6648         from tui_win_has_locator.
6649         (tui_source_window_base): Use false, not FALSE.
6650
6651 2019-06-25  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6654         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6655         clear_detail method directly.
6656         (tui_clear_win_detail): Remove.
6657
6658 2019-06-25  Tom Tromey  <tom@tromey.com>
6659
6660         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6661         "this", not TUI_DISASM_WIN.
6662
6663 2019-06-25  Tom Tromey  <tom@tromey.com>
6664
6665         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6666         declare.
6667         * tui/tui-winsource.c
6668         (tui_source_window_base::do_scroll_horizontal): Rename from
6669         tui_horizontal_source_scroll.
6670         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6671         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6672         from tui_vertical_data_scroll.
6673         * tui/tui-win.h (tui_scroll): Don't declare.
6674         * tui/tui-win.c (tui_win_info::forward_scroll)
6675         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6676         (tui_win_info::right_scroll): Rename and update.
6677         (tui_scroll_forward_command, tui_scroll_backward_command)
6678         (tui_scroll_left_command, tui_scroll_right_command): Update.
6679         (tui_scroll): Remove.
6680         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6681         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6682         from tui_vertical_source_scroll.
6683         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6684         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6685         from tui_vertical_disassem_scroll.
6686         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6687         do_scroll_horizontal>: New methods.
6688         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6689         Likewise.
6690         (struct tui_source_window_base): Add do_scroll_horizontal.
6691         (struct tui_source_window, struct tui_disasm_window): Add
6692         do_scroll_vertical.
6693         (struct tui_data_window, struct tui_cmd_window): Add
6694         do_scroll_horizontal and do_scroll_vertical.
6695         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6696
6697 2019-06-25  Tom Tromey  <tom@tromey.com>
6698
6699         * tui/tui-data.h (struct tui_source_window_base): New struct.
6700         (struct tui_source_window): Derive from tui_source_window_base.
6701         (struct tui_disasm_window): New struct.
6702         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6703         from tui_source_window::clear_detail.
6704         (tui_source_window_base): Rename from tui_source_window.
6705         (~tui_source_window_base): Rename from ~tui_source_window.
6706         (tui_alloc_win_info): Create a tui_disasm_window.
6707
6708 2019-06-25  Tom Tromey  <tom@tromey.com>
6709
6710         * tui/tui-data.h (struct tui_source_window)
6711         (struct tui_data_window): Declare destructors.
6712         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6713         destructors.
6714         (tui_win_info): Simplify.
6715
6716 2019-06-25  Tom Tromey  <tom@tromey.com>
6717
6718         * tui/tui-winsource.c (tui_display_main)
6719         (tui_update_source_windows_with_addr)
6720         (tui_update_all_breakpoint_info): Update.
6721         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6722         (new_height_ok, parse_scrolling_args): Update.
6723         * tui/tui-stack.c (tui_show_frame_info): Update.
6724         * tui/tui-data.h (struct tui_list): Remove.
6725         (tui_source_windows): Return a reference to a std::vector.
6726         * tui/tui-data.c (source_windows): Now a std::vector.
6727         (tui_source_windows): Change return type.
6728         (tui_clear_source_windows): Rewrite.
6729         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6730         (tui_free_all_source_wins_content): Rewrite.
6731
6732 2019-06-25  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6735         (struct tui_data_window, struct tui_cmd_window): Declare
6736         clear_detail method.
6737         * tui/tui-data.c (tui_source_window::clear_detail)
6738         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6739         methods.
6740         (tui_clear_win_detail): Simplify.
6741
6742 2019-06-25  Tom Tromey  <tom@tromey.com>
6743
6744         * tui/tui-layout.c (make_source_window, make_disasm_window)
6745         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6746         Return the new window.
6747         (show_source_disasm_command, show_data)
6748         (show_source_or_disasm_and_command): Update.
6749
6750 2019-06-25  Tom Tromey  <tom@tromey.com>
6751
6752         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6753         parameter.  Return the new window.
6754         (show_source_disasm_command): Update and remove NULL check.
6755         (show_source_or_disasm_and_command): Update.
6756
6757 2019-06-25  Tom Tromey  <tom@tromey.com>
6758
6759         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6760
6761 2019-06-25  Tom Tromey  <tom@tromey.com>
6762
6763         * tui/tui-data.h (struct tui_win_info): Make constructor
6764         protected.  Make destructor virtual.  Add initializers.
6765         (tui_source_window, tui_data_window, tui_cmd_window): New
6766         classes.
6767         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6768         constructor.  Add "type" parameter.
6769         (tui_source_window, tui_data_window, tui_cmd_window): New
6770         constructors.
6771         (tui_alloc_win_info): Instantiate the appropriate subclass.
6772
6773 2019-06-25  Tom Tromey  <tom@tromey.com>
6774
6775         * tui/tui-win.c (tui_resize_all): Use delete.
6776         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6777         destructor.
6778         (tui_free_window): Don't declare.
6779         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6780         Update.
6781
6782 2019-06-25  Tom Tromey  <tom@tromey.com>
6783
6784         * tui/tui-data.h (struct tui_win_info): Add constructor.
6785         * tui/tui-data.c (tui_alloc_win_info): Use new.
6786         (tui_free_window): Use delete.
6787
6788 2019-06-22  Tom Tromey  <tom@tromey.com>
6789
6790         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6791         declare.
6792         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6793
6794 2019-06-22  Tom Tromey  <tom@tromey.com>
6795
6796         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6797         declare.
6798         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6799
6800 2019-06-22  Tom de Vries  <tdevries@suse.de>
6801
6802         * dwarf2read.c (create_addrmap_from_aranges)
6803         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6804         instead of '%zu'.
6805
6806 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6807
6808         * dwarf2read.h (dwarf2_section_info_def): Remove.
6809         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6810         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6811         std::vector<dwarf2_section_info>.
6812         (struct dwo_file) <~dwo_file>: Remove.
6813         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6814         types field.
6815         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6816         (dwarf2_read_debug_names): Likewise.
6817         (create_debug_types_hash_table): Change parameter type to
6818         array_view, adjust code accordingly.
6819         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6820         (partial_die_info::fixup): Likewise.
6821         (determine_prefix): Likewise.
6822         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6823
6824 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6825
6826         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6827         gdb_bfd_ref_ptr.
6828         <~dwo_file>: Remove call to gdb_bfd_unref.
6829         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6830         gdb_bfd_ref_ptr::get.
6831
6832 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6833
6834         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6835         type to htab_up.
6836         * dwarf2read.c (struct dwo_file): Initialize fields.
6837         <~dwo_file>: New.
6838         (free_dwo_file): Remove, move content to ~dwo_file.
6839         (struct dwo_file_deleter): Remove.
6840         (dwo_file_up>: Remove custom deleter.
6841         (free_dwo_files): Remove.
6842         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6843         dwo_files.
6844         (process_skeletonless_type_units): Call unique_ptr::get.
6845         (allocate_dwo_file_hash_table): Add deleter to created hash
6846         table.  Change return type to htab_up.
6847         (lookup_dwo_file_slot): Don't memset dwo_file, call
6848         unique_ptr::get.
6849         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6850         (create_dwo_unit_in_dwp_v2): Likewise.
6851         (open_and_init_dwo_file): Likewise.
6852         (free_dwo_file_from_slot): Remove.
6853
6854 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6855
6856         * dwarf2read.h (struct dwarf2_section_info) <readin,
6857         is_virtual>: Change type to bool.
6858         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6859         true instead of 1.
6860
6861 2019-06-19  Tom Tromey  <tom@tromey.com>
6862
6863         * tui/tui-data.h (tui_init_content_element): Don't declare.
6864
6865 2019-06-19  Tom Tromey  <tom@tromey.com>
6866
6867         * tui/tui-data.h (tui_init_win_info): Don't declare.
6868
6869 2019-06-19  Tom de Vries  <tdevries@suse.de>
6870
6871         * dwarf2read.h (abstract_to_concrete): Change type to
6872         std::unordered_map<sect_offset, std::vector<sect_offset>,
6873         gdb::hash_enum<sect_offset>>.
6874
6875 2019-06-19  Tom Tromey  <tromey@adacore.com>
6876
6877         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6878         EVAL_AVOID_SIDE_EFFECTS specially.
6879
6880 2019-06-19  Tom Tromey  <tromey@adacore.com>
6881
6882         * source-cache.c (highlighter): New global.
6883         (source_cache::get_source_lines): Create a highlighter on demand.
6884
6885 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * defs.h (deprecated_interactive_hook): Delete declaration.
6888         * interps.c (clear_interpreter_hooks): Remove use of
6889         deprecated_interactive_hook.
6890         * top.c (deprecated_interactive_hook): Delete definition.
6891         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6892
6893 2019-06-18  Tom de Vries  <tdevries@suse.de>
6894
6895         PR gdb/24515
6896         * dwarf2read.h (abstract_to_concrete): Change type from
6897         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6898         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6899         * dwarf2read.c (read_variable): Update.
6900         (dwarf2_fetch_die_loc_sect_off): Update.
6901
6902 2019-06-17  Tom de Vries  <tdevries@suse.de>
6903
6904         PR gdb/24617
6905         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6906         accessing parent[parent_len - 1].
6907
6908 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6909
6910         PR gdb/24364
6911         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6912         call dtrace_process_dof with NULL dof.
6913
6914 2019-06-16  Tom de Vries  <tdevries@suse.de>
6915
6916         PR gdb/24445
6917         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6918
6919 2019-06-16  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6922         (make_all_visible): Use address of member.
6923
6924 2019-06-16  Tom Tromey  <tom@tromey.com>
6925
6926         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6927         (tui_free_window, free_content, free_content_elements): Remove
6928         unnecessary cast.
6929         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6930         cast.
6931         * tui/tui-regs.c (tui_show_register_group)
6932         (tui_display_registers_from, tui_display_reg_element_at_line):
6933         Remove unnecessary cast.
6934
6935 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * linux-nat.c (normal_mask): Delete.
6938         (_initialize_linux_nat): Don't initialise normal_mask.
6939
6940 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6941
6942         PR gdb/24445
6943         * dwarf-index-write.h (write_psymtabs_to_index): Add
6944         dwz_basename parameter.
6945         * dwarf-index-write.c (write_gdbindex): Move file writing to
6946         write_gdbindex_1.  Change return type void.
6947         (assert_file_size): Move up, remove filename parameter.
6948         (write_gdbindex_1): New function.
6949         (write_debug_names): Change return type to void, call
6950         assert_file_size.
6951         (struct index_wip_file): New struct.
6952         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6953         file logic to index_wip_file.  Write index for dwz file if
6954         needed.
6955         (save_gdb_index_command): Pass basename of dwz file, if present.
6956         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6957         build-id of dwz file, if present.
6958         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6959         (dwarf2_get_dwz_file): Likewise.
6960         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6961         (dwarf2_get_dwz_file): Likewise.
6962
6963 2019-06-16  Tom Tromey  <tom@tromey.com>
6964
6965         * coffread.c (process_coff_symbol): Use xstrdup.
6966         * value.c (create_internalvar): Use xstrdup.
6967
6968 2019-06-16  Tom Tromey  <tom@tromey.com>
6969
6970         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6971         * breakpoint.c (stopin_command, stopat_command)
6972         (until_break_command, decode_location_default): Remove unnecessary
6973         cast.
6974         * utils.c (subset_compare): Remove unnecessary cast.
6975         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6976         cast.
6977         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6978         cast.
6979         * infcmd.c (path_command): Remove unnecessary cast.
6980         * coffread.c (decode_type): Remove unnecessary cast.
6981         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6982         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6983         * tui/tui-stack.c (tui_show_locator_content)
6984         (tui_show_frame_info): Remove unnecessary cast.
6985         * tui/tui-win.c (tui_scroll_forward_command)
6986         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6987         (parse_scrolling_args): Remove unnecessary cast.
6988         * tui/tui-data.c (init_win_info, tui_del_window)
6989         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6990         (free_content_elements): Remove unnecessary cast.
6991         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6992         unnecessary cast.
6993         * tui/tui-source.c (tui_set_source_content)
6994         (tui_vertical_source_scroll): Remove unnecessary cast.
6995         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6996         cast.
6997         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6998         * tui/tui-regs.c (tui_display_registers_from)
6999         (tui_display_register): Remove unnecessary cast.
7000         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7001         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7002         (make_visible): Remove unnecessary cast.
7003         * tui/tui-winsource.c (tui_erase_source_content)
7004         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7005         unnecessary cast.
7006         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7007         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7008         * stabsread.c (read_type, read_array_type, read_range_type):
7009         Remove unnecessary cast.
7010         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7011         (parse_symbol, parse_type, upgrade_type, parse_external)
7012         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7013         unnecessary cast.
7014         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7015
7016 2019-06-16  Tom Tromey  <tom@tromey.com>
7017
7018         * tui/tui-data.c (tui_alloc_generic_win_info)
7019         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7020         checks.
7021
7022 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7023             Andrew Burgess  <andrew.burgess@embecosm.com>
7024
7025         * f-typeprint.c (f_print_type): Don't return early for not
7026         associated or not allocated types.
7027         (f_type_print_varspec_suffix): Add print_rank parameter and print
7028         ranks of array types in case they dangling.
7029         (f_type_print_base): Add print_rank parameter.
7030
7031 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * NEWS: Mention new MI commands.
7034         * break-catch-throw.c (enum exception_event_kind): Move to
7035         breakpoint.h.
7036         (print_mention_exception_catchpoint): Output text as a single
7037         message.
7038         (catch_exception_command_1): Rename to...
7039         (catch_exception_event): ...this, make non-static, update header
7040         command, and change some parameter types.
7041         (catch_catch_command): Update for changes to
7042         catch_exception_command_1.
7043         (catch_throw_command): Likewise.
7044         (catch_rethrow_command): Likewise.
7045         * breakpoint.c (enum exception_event_kind): Delete.
7046         * breakpoint.h (enum exception_event_kind): Moved here from
7047         break-catch-throw.c.
7048         (catch_exception_event): Declare.
7049         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7050         (mi_cmd_catch_throw): New function.
7051         (mi_cmd_catch_rethrow): New function.
7052         (mi_cmd_catch_catch): New function.
7053         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7054         'catch-catch' entries.
7055         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7056         (mi_cmd_catch_rethrow): Declare.
7057         (mi_cmd_catch_catch): Declare.
7058
7059 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7060
7061         * annotate.c (annotate_source_line): Change return type to void,
7062         update implementation to match.
7063         * annotate.h (annotate_source_line): Change return type to void,
7064         update header comment.
7065         * stack.c (print_frame_info): Don't change what frame information
7066         is printed based on whether annotations are on or not.
7067
7068 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7069
7070         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7071         (annotate_source): Make static.
7072         (annotate_source_line): Moved from source.c and renamed from
7073         identify_source_line.  Update the return type.
7074         * annotate.h (annotate_source): Delete declaration.
7075         (annotate_source_line): Declaration moved from source.h, and
7076         renamed from identify_source_line.  Return type updated.
7077         * source.c (identify_source_line): Moved to annotate.c and renamed
7078         to annotate_source_line.
7079         (info_line_command): Remove check of annotation_level.
7080         * source.h (identify_source_line): Move declaration to annotate.h
7081         and rename to annotate_source_line.
7082         * stack.c: Add 'annotate.h' include.
7083         (print_frame_info): Remove check of annotation_level before
7084         calling annotate_source_line.
7085
7086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7087
7088         * source-cache.c (source_cache::get_plain_source_lines): Use
7089         open_source_file_with_line_charpos instead of just
7090         open_source_file, remove call to find_source_lines.
7091         (source_cache::get_source_lines): Likewise.
7092         * source.c (find_source_lines): Make static.
7093         (get_filename_and_charpos): Renamed into...
7094         (open_source_file_with_line_charpos): ..this along with changes to
7095         return a scoped_fd, and some other minor clean ups.
7096         (identify_source_line): Use open_source_file_with_line_charpos.
7097         (search_command_helper): Use open_source_file_with_line_charpos
7098         instead of just open_source_file, remove call to
7099         find_source_lines.
7100         * source.h (open_source_file_with_line_charpos): Declare new
7101         function.
7102         (find_source_lines): Delete declaration.
7103
7104 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * source.c (get_filename_and_charpos): Remove fullname
7107         parameter.
7108         (identify_source_line): Update call to get_filename_and_charpos.
7109
7110 2019-06-14  Tom Tromey  <tromey@adacore.com>
7111
7112         PR gdb/24502:
7113         * ui-style.h (skip_ansi_escape): Update comment.
7114         * ui-file.h (class no_terminal_escape_file): New class.
7115         * ui-file.c (no_terminal_escape_file::write)
7116         (no_terminal_escape_file::puts): New methods.
7117         * cli/cli-logging.c (handle_redirections): Use
7118         no_terminal_escape_file.
7119
7120 2019-06-14  Tom Tromey  <tromey@adacore.com>
7121
7122         * NEWS: Move convenience variable news above Python news.
7123
7124 2019-06-14  Tom Tromey  <tom@tromey.com>
7125
7126         * gnulib: Move directory to top-level.
7127         * configure.ac: Don't configure gnulib.
7128         * configure: Rebuild.
7129         * common/common-defs.h: Use new path to gnulib.
7130         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7131         (GNULIB_H): Remove.
7132         (INCGNU): Look in new gnulib location.
7133         (HFILES_NO_SRCDIR): Remove gnulib files.
7134         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7135         (generated_files): Remove GNULIB_H.
7136         ($(LIBGNU), all-lib): Remove targets.
7137         (distclean): Don't mention GNULIB_BUILDDIR.
7138         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7139
7140 2019-06-14  Tom Tromey  <tromey@adacore.com>
7141
7142         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7143         Warn if symbol file does not provide any symbols.
7144
7145 2019-06-14  Tom Tromey  <tromey@adacore.com>
7146
7147         * source.c (find_and_open_source): Respect basenames_may_differ.
7148
7149 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * annotate.c (annotate_breakpoints_invalid): Make use of
7152         scoped_restore_terminal_state.
7153         (annotate_frames_invalid): Likewise.
7154
7155 2019-06-14  Tom Tromey  <tromey@adacore.com>
7156
7157         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7158         allow assignment to an internalvar.
7159
7160 2019-06-14  Tom Tromey  <tromey@adacore.com>
7161
7162         * ada-lex.l: Allow "_" in attribute names.
7163
7164 2019-06-14  Tom Tromey  <tromey@adacore.com>
7165
7166         PR gdb/24653:
7167         * regcache.c (registers_changed): Don't call alloca.
7168         * top.c (execute_command): Don't call alloca.
7169
7170 2019-06-13  Pedro Alves  <palves@redhat.com>
7171
7172         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7173         'expression'.  When parsing an expression, error out if there's
7174         junk after "unlimited".
7175         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7176         (do_set_command): Adjust calls to is_unlimited_literal.
7177
7178 2019-06-13  Pedro Alves  <palves@redhat.com>
7179
7180         * compile/compile.c (make_compile_options_def_group): Add braces
7181         around array_view initializer.
7182         * thread.c (make_thread_apply_all_options_def_group)
7183         (make_thread_apply_all_options_def_group): Likewise.
7184
7185 2019-06-13  Pedro Alves  <palves@redhat.com>
7186
7187         * NEWS (New commands): Mention "maint test-options
7188         require-delimiter", "maint test-options unknown-is-error", "maint
7189         test-options unknown-is-operand" and "maint show
7190         test-options-completion-result".
7191         (New command options, command completion): New section.
7192         (Completion improvements): New section.
7193         Mention that you can abbreviate "unlimited".
7194
7195 2019-06-13  Pedro Alves  <palves@redhat.com>
7196
7197         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7198         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7199         * unittests/cli-utils-selftests.c (test_parse_flags)
7200         (test_parse_flags_qcs): Delete.
7201         (test_cli_utils): Don't call deleted functions.
7202
7203 2019-06-13  Pedro Alves  <palves@redhat.com>
7204
7205         * thread.c: Include "cli/cli-option.h".
7206         (tp_array_compar_ascending): Global.
7207         (tp_array_compar): Delete function.
7208         (tp_array_compar_ascending, tp_array_compar_descending): New
7209         functions.
7210         (ascending_option_def, qcs_flag_option_def)
7211         (thr_qcs_flags_option_defs)
7212         (make_thread_apply_all_options_def_group)
7213         (make_thread_apply_options_def_group): New.
7214         (thread_apply_all_command): Use gdb::option::process_options.
7215         (thread_apply_command_completer)
7216         (thread_apply_all_command_completer): New.
7217         (thread_apply_command): Use gdb::option::process_options.
7218         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7219         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7220         to generate help text of "thread apply".  Adjust "taas"'s help.
7221         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7222         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7223
7224 2019-06-13  Pedro Alves  <palves@redhat.com>
7225
7226         * thread.c (thread_apply_command): Check for invalid TID with
7227         isdigit instead of !isalpha.
7228
7229 2019-06-13  Pedro Alves  <palves@redhat.com>
7230
7231         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7232         (validate_flags_qcs): New.
7233         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7234         (validate_flags_qcs): Declare.
7235         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7236         (make_frame_apply_options_def_group): New.
7237         (frame_apply_command_count): Process options with
7238         gdb::option::process_options.
7239         (frame_apply_completer): New.
7240         (frame_apply_level_completer, frame_apply_all_completer)
7241         (frame_apply_completer): New.
7242         (_initialize_stack): Update help of "frame apply", "frame apply
7243         level", "frame apply all" and "faas" to mention supported options
7244         and install command completers.
7245         * stack.h (frame_apply_all_completer): Declare.
7246         * thread.c: Include "stack.h".
7247         (tfaas_command): Add "--".
7248         (_initialize_thread): Update help "tfaas" to mention supported
7249         options and install command completer.
7250
7251 2019-06-13  Pedro Alves  <palves@redhat.com>
7252
7253         * completer.c (complete_nested_command_line): New.
7254         (gdb_completion_word_break_characters_throw): Add assertion.
7255         * completer.h (complete_nested_command_line): Declare.
7256
7257 2019-06-13  Pedro Alves  <palves@redhat.com>
7258
7259         * stack.c (parse_backtrace_qualifiers): New.
7260         (backtrace_command): Use it.
7261         (backtrace_command_completer): Complete on qualifiers.
7262
7263 2019-06-13  Pedro Alves  <palves@redhat.com>
7264
7265         * frame.c: Include "cli/cli-option.h.
7266         (user_set_backtrace_options): New.
7267         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7268         Delete.
7269         (get_prev_frame): Adjust.
7270         (boolean_option_def, uinteger_option_def)
7271         (set_backtrace_option_defs): New.
7272         (_initialize_frame): Adjust and use
7273         gdb::option::add_setshow_cmds_for_options to install "set
7274         backtrace past-main" and "set backtrace past-entry".
7275         * frame.h: Include "cli/cli-option.h".
7276         (struct frame_print_options): Forward declare.
7277         (print_frame_arguments_all, print_frame_arguments_scalars)
7278         (print_frame_arguments_none): Declare.
7279         (print_entry_values): Delete declaration.
7280         (struct frame_print_options, user_frame_print_options): New.
7281         (struct set_backtrace_options): New.
7282         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7283         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7284         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7285         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7286         (list_args_or_locals): Add frame_print_options parameter.
7287         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7288         * python/py-framefilter.c (enumerate_args): Pass down
7289         USER_FRAME_PRINT_OPTIONS.
7290         * stack.c: Include "cli/cli-option.h".
7291         (print_frame_arguments_all, print_frame_arguments_scalars)
7292         (print_frame_arguments_none): Declare.
7293         (print_raw_frame_arguments, print_entry_values): Delete.
7294         (user_frame_print_options): New.
7295         (boolean_option_def, enum_option_def, frame_print_option_defs):
7296         New.
7297         (struct backtrace_cmd_options): New.
7298         (bt_flag_option_def): New.
7299         (backtrace_command_option_defs): New.
7300         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7301         (print_frame_arg, read_frame_arg, print_frame_args)
7302         (print_frame_info, print_frame): Add frame_print_options parameter
7303         and use it.
7304         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7305         (backtrace_command_1): Add frame_print_options and
7306         backtrace_cmd_options parameters and use them.
7307         (make_backtrace_options_def_group): New.
7308         (backtrace_command): Process command options with
7309         gdb::option::process_options.
7310         (backtrace_command_completer): New.
7311         (_initialize_stack): Extend "backtrace"'s help to mention
7312         supported options.  Install completer for "backtrace".
7313         Install some settings commands with add_setshow_cmds_for_options.
7314
7315 2019-06-13  Pedro Alves  <palves@redhat.com>
7316
7317         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7318         and that "set/show print raw frame-arguments" are now deprecated.
7319
7320         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7321         command.
7322         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7323         * stack.c (_initialize_stack): Install "set/show print
7324         raw-frame-arguments", and deprecate "set/show print raw
7325         frame-arguments".
7326         * valprint.c (_initialize_valprint): Deprecate "set/show print
7327         raw".
7328
7329 2019-06-13  Pedro Alves  <palves@redhat.com>
7330
7331         * compile/compile.c (struct compile_options): New.
7332         (compile_flag_option_def, compile_command_option_defs)
7333         (make_compile_options_def_group): New.
7334         (compile_file_command): Handle options with
7335         gdb::option::process_options.
7336         (compile_file_command_completer): New function.
7337         (compile_code_command): Handle options with
7338         gdb::option::process_options.
7339         (compile_code_command_completer): New function.
7340         (_initialize_compiler): Install completers for "compile code" and
7341         "compile file".  Mention available options in "compile code" and
7342         "compile code"'s help.
7343         * completer.c (advance_to_completion_word): New, factored out from
7344         ...
7345         (advance_to_expression_complete_word_point): ... this.
7346         (advance_to_filename_complete_word_point): New.
7347         * completer.h (advance_to_filename_complete_word_point): New
7348         declaration.
7349
7350 2019-06-13  Pedro Alves  <palves@redhat.com>
7351
7352         * compile/compile.c: Include "cli/cli-option.h".
7353         (compile_print_value): Scope data pointer is now a
7354         value_print_options pointer; adjust.
7355         (compile_print_command): Process options.  Scope data pointer is
7356         now a value_print_options pointer; adjust.
7357         (_initialize_compile): Update "compile print"'s help to include
7358         supported options.  Install a completer for "compile print".
7359         * cp-valprint.c (show_vtblprint, show_objectprint)
7360         (show_static_field_print): Delete.
7361         (_initialize_cp_valprint): Don't install "set print
7362         static-members", "set print vtbl", "set print object" here.
7363         * printcmd.c: Include "cli/cli-option.h" and
7364         "common/gdb_optional.h".
7365         (print_command_parse_format): Rework to fill in a
7366         value_print_options instead of a format_data.
7367         (print_value): Change parameter type from format_data pointer to
7368         value_print_options reference.  Adjust.
7369         (print_command_1): Process options.  Adjust to pass down a
7370         value_print_options.
7371         (print_command_completer): New.
7372         (_initialize_printcmd): Install print_command_completer as
7373         handle_brkchars completer for the "print" command.  Update
7374         "print"'s help to include supported options.
7375         * valprint.c: Include "cli/cli-option.h".
7376         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7377         here from cp-valprint.c.
7378         (boolean_option_def, uinteger_option_def)
7379         (value_print_option_defs, make_value_print_options_def_group):
7380         New.  Use gdb::option::add_setshow_cmds_for_options to install
7381         "set print elements", "set print null-stop", "set print repeats",
7382         "set print pretty", "set print union", "set print array", "set
7383         print address", "set print symbol", "set print array-indexes".
7384         * valprint.h: Include <string> and "cli/cli-option.h".
7385         (make_value_print_options_def_group): Declare.
7386         (print_value): Change parameter type from format_data pointer to
7387         value_print_options reference.
7388         (print_command_completer): Declare.
7389
7390 2019-06-13  Pedro Alves  <palves@redhat.com>
7391
7392         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7393         (COMMON_SFILES): Add maint-test-settings.c.
7394         * cli/cli-decode.c (boolean_enums): New global, factored out from
7395         ...
7396         (add_setshow_boolean_cmd): ... here.
7397         * cli/cli-decode.h (boolean_enums): Declare.
7398         * cli/cli-option.c: New file.
7399         * cli/cli-option.h: New file.
7400         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7401         factored out from ...
7402         (parse_cli_boolean_value(const char *)): ... this.
7403         (is_unlimited_literal): Change parameter type to pointer to
7404         pointer.  Adjust and advance ARG pointer.
7405         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7406         (parse_cli_var_enum): New, factored out from ...
7407         (do_set_command): ... this.  Adjust.
7408         * cli/cli-setshow.h (parse_cli_boolean_value)
7409         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7410         (parse_cli_var_enum): Declare.
7411         * cli/cli-utils.c: Include "cli/cli-option.h".
7412         (get_ulongest): New.
7413         * cli/cli-utils.h (get_ulongest): Declare.
7414         (check_for_argument): New overloads.
7415         * maint-test-options.c: New file.
7416
7417 2019-06-13  Pedro Alves  <palves@redhat.com>
7418
7419         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7420         parse a range if "-" is at the end of the string.
7421
7422 2019-06-13  Pedro Alves  <palves@redhat.com>
7423
7424         * cli/cli-setshow.c (parse_auto_binary_operation)
7425         (parse_cli_boolean_value): Don't allow "o".
7426
7427 2019-06-13  Pedro Alves  <palves@redhat.com>
7428
7429         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7430         * NEWS: Mention maint test-settings KIND.
7431         * maint-test-settings.c: New file.
7432
7433 2019-06-13  Pedro Alves  <palves@redhat.com>
7434
7435         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7436         completer.
7437         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7438         "set" completers.
7439
7440 2019-06-13  Pedro Alves  <palves@redhat.com>
7441
7442         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7443         after item.
7444
7445 2019-06-13  Pedro Alves  <palves@redhat.com>
7446
7447         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7448
7449 2019-06-13  Pedro Alves <palves@redhat.com>
7450
7451         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7452         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7453         call.
7454         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7455         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7456         calls.
7457         (check_for_argument): Skip spaces after argument.
7458
7459 2019-06-13  Pedro Alves  <palves@redhat.com>
7460
7461         * thread.c (thread_apply_command): Adjust TID parsing.
7462         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7463         detected before end of string.
7464         (tid_is_in_list): Error out if LIST is invalid.
7465
7466 2019-06-13  Pedro Alves  <palves@redhat.com>
7467
7468         * completer.c (complete_line_internal_1): Rewind completion word
7469         point.
7470         (completion_tracker::advance_custom_word_point_by): Change
7471         parameter type to int.
7472         * completer.h (completion_tracker::advance_custom_word_point_by):
7473         Likewise.
7474
7475 2019-06-13  Pedro Alves  <palves@redhat.com>
7476
7477         * completer.c (advance_to_completion_word): Handle delimiters.
7478
7479 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7480
7481         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7482
7483 2019-06-11  Tom Tromey  <tom@tromey.com>
7484
7485         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7486         (xmalloc_failed): Move to alloc.c.
7487         * alloc.c: New file.
7488         * Makefile.in (COMMON_SFILES): Add alloc.c.
7489
7490 2019-06-11  Tom Tromey  <tom@tromey.com>
7491
7492         * nat/linux-waitpid.c: Don't include server.h.
7493         (linux_debug): Remove.
7494         (my_waitpid): Update.
7495
7496 2019-06-11  Tom Tromey  <tromey@adacore.com>
7497
7498         * infcall.c (_initialize_infcall): Remove trailing newline from
7499         help.
7500         * user-regs.c (_initialize_user_regs): Remove trailing newline
7501         from help.
7502         * typeprint.c (_initialize_typeprint): Remove trailing newline
7503         from help.
7504         * reverse.c (_initialize_reverse): Remove trailing newlines from
7505         help.
7506         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7507         from help.
7508         * language.c (add_set_language_command): Remove trailing newline
7509         from help.
7510         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7511         help.
7512         * disasm.c (_initialize_disasm): Remove trailing newline from
7513         help.
7514         * top.c (init_main): Remove trailing newline from help.
7515         * interps.c (_initialize_interpreter): Remove trailing newline
7516         from help.
7517         * btrace.c (_initialize_btrace): Remove trailing newlines from
7518         help.
7519         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7520         from help.
7521         * python/python.c (_initialize_python): Remove trailing newline
7522         from help.
7523         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7524         help.
7525         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7526         from help.  Reformat some text.
7527         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7528         from help.
7529         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7530         newline from help.
7531
7532 2019-06-11  Tom Tromey  <tromey@adacore.com>
7533
7534         * darwin-nat.c (darwin_decode_exception_message)
7535         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7536
7537 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * valops.c (value_slice): Check for not allocated or not
7540         associated values.
7541
7542 2019-06-10  Tom de Vries  <tdevries@suse.de>
7543
7544         PR gdb/24618
7545         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7546         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7547         invalid.
7548
7549 2019-06-10  Tom de Vries  <tdevries@suse.de>
7550
7551         PR gdb/24611
7552         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7553         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7554
7555 2019-06-10  Tom de Vries  <tdevries@suse.de>
7556
7557         PR symtab/24545
7558         * symtab.c (struct demangled_name_entry): Add language field.
7559         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7560         static minimal symbol".  Set and use language field.
7561
7562 2019-06-10  Tom Tromey  <tromey@adacore.com>
7563
7564         * ada-lang.c (_initialize_ada_language): Update help text.
7565
7566 2019-06-10  Tom Tromey  <tromey@adacore.com>
7567
7568         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7569         with a newline.
7570         * guile/guile.c (handle_boot_error): Don't end warning with a
7571         newline.
7572         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7573         warning with a newline.
7574         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7575         newline.
7576         (s12z_frame_cache): Likewise.
7577         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7578         a newline.
7579         * solib-svr4.c (disable_probes_interface): Don't end warning with
7580         a newline.
7581         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7582         newline.
7583         * python/python.c (do_finish_initialization): Don't end warning
7584         with a newline.
7585
7586 2019-06-10  Tom Tromey  <tom@tromey.com>
7587
7588         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7589         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7590         gdbpy_enter.
7591
7592 2019-06-10  Tom Tromey  <tromey@adacore.com>
7593
7594         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7595         data.
7596         (elf_new_init): Don't call stabsread_new_init.
7597         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7598         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7599         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7600
7601 2019-06-10  Tom de Vries  <tdevries@suse.de>
7602
7603         PR symtab/16264
7604         PR symtab/24517
7605         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7606
7607 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7608
7609         * source.c (find_and_open_source): Also rewrite relative file
7610         names.
7611
7612 2019-04-26  Amos Bird  <amosbird@gmail.com>
7613
7614         * annotate.c (annotate_thread_exited): Add "thread-exited"
7615         annotation.
7616
7617 2019-06-06  Tom Tromey  <tromey@adacore.com>
7618
7619         * maint.h (class scoped_command_stats): Use
7620         DISABLE_COPY_AND_ASSIGN.
7621         <print_time>: New method.
7622         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7623         print_time.
7624         (scoped_command_stats::print_time): New method.
7625
7626 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7629         instructions of lengths 6 or 8 bytes.
7630
7631 2019-06-04  Pedro Alves  <palves@redhat.com>
7632
7633         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7634
7635         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7636         * breakpoint.c (condition_completer): Likewise.
7637         * cli/cli-dump.c (scan_expression): Likewise.
7638         * common/filestuff.c (mkdir_recursive): Likewise.
7639         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7640         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7641         (gdb_abspath): Likewise.
7642         * compile/compile-cplus-types.c
7643         (compile_cplus_instance::decl_name): Likewise.
7644         * completer.c (complete_explicit_location):
7645         (signal_completer, reg_or_group_completer_1): Likewise.
7646         * cp-support.c (cp_remove_params_if_any): Likewise.
7647         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7648         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7649         * infcmd.c (strip_bg_char): Likewise.
7650         * linespec.c (copy_token_string): Likewise.
7651         * mi/mi-main.c (output_cores): Likewise.
7652         * psymtab.c (psymtab_search_name):
7653         * symfile.c (test_set_ext_lang_command): Likewise.
7654         * target.c (target_fileio_read_stralloc): Likewise.
7655         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7656         * value.c (complete_internalvar): Likewise.
7657
7658 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7659
7660         Add objfile property to gdb.Type.
7661         * NEWS: Mention Python API addition.
7662         * python/py-type.c (typy_get_objfile): New method.
7663
7664 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7665
7666         * NEWS: Mention the new set|show style [title|highlight].
7667         Mention changes to "show style", "help" and "apropos".
7668
7669 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7670
7671         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7672         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7673         instead of print_help_for_command.
7674         (print_doc_of_command): New function.
7675         (help_list): Add 'apropos -v word' suggestion.
7676         (print_help_for_command): Style the command name using title style.
7677         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7678         (_initialize_cli_cmds): Describe -v in apropos_command help.
7679
7680 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7681
7682         * cli/cli-style.h (cli_style_option): Add name in constructor,
7683         add m_name class member, add constructor with intensity,
7684         add name class function.
7685         (cli_style_option::add_setshow_commands): Remove name argument.
7686         (highlight_style, title_style): New styles.
7687         * cli/cli-style.c (do_show): New function that shows a style
7688         characteristic styling the style name with itself.
7689         (set_style_name): New function.
7690         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7691         Update all callers according to the changes in cli/cli-style.h.
7692         * utils.h (fputs_highlighted): New function.
7693         * utils.c (fputs_highlighted): Likewise.
7694
7695 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7696
7697         * NEWS: Mention new pipe command and new convenience variables.
7698
7699 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7700
7701         * cli/cli-cmds.c (pipe_command): New function.
7702         (_initialize_cli_cmds): Call add_com for pipe_command.
7703         Define | as an alias for pipe.
7704         (exit_status_set_internal_vars): New function.
7705         (shell_escape): Call exit_status_set_internal_vars.
7706         cli/cli-decode.c (find_command_name_length): Recognize | as
7707         a single character command.
7708
7709 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7710
7711         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7712         top.c (execute_command_to_ui_file): New function, mostly a copy
7713         of execute_command_to_string.
7714         (execute_command_to_string): Implement by calling
7715         execute_command_to_ui_file.
7716
7717 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7718
7719         * top.h (saved_command_line): Remove declaration.
7720         * top.c (previous_saved_command_line, previous_repeat_arguments):
7721         New variables.
7722         (saved_command_line): Make static, define together with other
7723         'repeat variables'.
7724         (dont_repeat): Clear repeat_arguments.
7725         (repeat_previous, get_saved_command_line, save_command_line):
7726         New functions.
7727         (gdb_init): Initialize saved_command_line
7728         and previous_saved_command_line.
7729         * main.c (captured_main_1): Remove saved_command_line initialization.
7730         * event-top.c (handle_line_of_input): Update to use
7731         the new 'repeat' related functions instead of direct access to
7732         saved_command_line.
7733         * command.h (repeat_previous, get_saved_command_line,
7734         save_command_line): New declarations.
7735         (dont_repeat): Add comment.
7736
7737 2019-05-30  Tom Tromey  <tromey@adacore.com>
7738
7739         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7740         Fix comment.
7741         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7742
7743 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7744
7745         PR cli/24587
7746         * completer.c (complete): Initialize variable word.
7747
7748 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7749
7750         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7751         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7752         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7753         'body' is NULL to the outter 'if', protecting the '!is_define'
7754         situation as well.
7755
7756 2019-05-29  Tom Tromey  <tromey@adacore.com>
7757
7758         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7759         (dwarf_unknown): New function.
7760         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7761         (dwarf_type_encoding_name): Use dwarf_unknown.
7762
7763 2019-05-29  Tom Tromey  <tromey@adacore.com>
7764
7765         PR c++/20020:
7766         * cp-valprint.c (cp_print_value_fields): Call
7767         cp_print_static_field inside "try".
7768
7769 2019-05-29  Tom Tromey  <tromey@adacore.com>
7770
7771         * inflow.c (struct terminal_info): Add default operator=.
7772         * configure: Rebuild.
7773         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7774         -Wdeprecated-copy-dtor, -Wredundant-move.
7775
7776 2019-05-29  Tom Tromey  <tromey@adacore.com>
7777
7778         * NEWS: Add entry.
7779         * infcmd.c (print_return_value_1): Handle finish_print
7780         option.
7781         (show_print_finish): New function.
7782         (_initialize_infcmd): Add "set/show print finish" commands.
7783         * valprint.c (user_print_options): Initialize new member.
7784         * valprint.h (struct value_print_options) <finish_print>: New
7785         member.
7786
7787 2019-05-28  Tom Tromey  <tromey@adacore.com>
7788
7789         * ada-lang.c (ada_remove_Xbn_suffix)
7790         (find_old_style_renaming_symbol)
7791         (parse_old_style_renaming): Remove.
7792         (ada_find_renaming_symbol): Don't call
7793         find_old_style_renaming_symbol.
7794         (ada_is_renaming_symbol): Rename from
7795         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7796         bool.  Now static.
7797         (ada_read_var_value): Update and simplify.
7798         * ada-exp.y (write_var_or_type): Remove old code.
7799
7800 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7801
7802         PR gdb/25010
7803         * event-top.c: Remove include comment.
7804         * inflow.c (class scoped_ignore_sigttou): Move from here...
7805         * inflow.h (class scoped_ignore_sigttou): ...to here.
7806         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7807         * top.c:  Remove include comment.
7808
7809 2019-05-27  Tom Tromey  <tom@tromey.com>
7810
7811         * NEWS: Fix typo.
7812
7813 2019-05-22  Tom Tromey  <tromey@adacore.com>
7814
7815         * target.c (target_follow_exec): Constify parameter.
7816         * target-delegates.c: Rebuild.
7817         * remote.c (remote_target::follow_exec): Constify parameter.
7818         * infrun.c (follow_exec): Constify parameter.
7819         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7820         (target_follow_exec): Likewise.
7821
7822 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7823
7824         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7825         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7826
7827 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7828
7829         * NEWS: Add debugredirect and testsuite sections.
7830
7831 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7832
7833         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7834         target descriptions using exclusively floating point register name
7835         aliases.
7836
7837 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         PR gdb/18644:
7840         * f-lang.c (build_fortran_types): Handle the case where
7841         gdbarch_floatformat_for_type returns a nullptr.
7842
7843 2019-05-21  Tom de Vries  <tdevries@suse.de>
7844
7845         PR cli/24587
7846         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7847
7848 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         PR gdb/18644:
7851         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7852         16-byte floats.
7853         * i386-tdep.c (i386_floatformat_for_type): Use
7854         floatformats_ia64_quad for the 16-byte floating point component
7855         within a fortran 32-byte complex number.
7856
7857 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7860         delete default constructor.
7861         (find_partial_die): Update to return const struct.
7862         (partial_die_parent_scope): Move variable declaration into scope
7863         of its use and change its type to auto.
7864         (guess_partial_die_structure_name): Likewise.
7865         (partial_die_info::fixup): Likewise.
7866
7867 2019-05-17  Tom Tromey  <tromey@adacore.com>
7868
7869         * source.c (find_and_open_source): Remove cast.
7870
7871 2019-05-17  Tom Tromey  <tromey@adacore.com>
7872
7873         * annotate.c (annotate_source): Make "filename" const.
7874         * annotate.h (annotate_source): Use const.
7875
7876 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7877
7878         * disasm.c (set_disassembler_options): Send errors to stderr.
7879
7880 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7881
7882         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7883         (cli_interp_base::set_logging): Check debug_redirect.
7884         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7885         * cli/cli-logging.c (debug_redirect): Add static variable.
7886         (pop_output_files): Add default param.
7887         (handle_redirections): Print debug setting.
7888         (show_logging_command): Likewise.
7889         (_initialize_cli_logging): Add debugredirect command.
7890         * interps.c (current_interp_set_logging): Add debug_redirect
7891         parameter.
7892         * interps.h (set_logging): Add debug_redirect parameter.
7893         (current_interp_set_logging): Likewise.
7894         * mi/mi-common.h: Likewise.
7895         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7896
7897 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7898             Tom Tromey  <tromey@adacore.com>
7899
7900         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7901         directly.
7902         * cli/cli-interp.h (make_logging_output): Remove declaration.
7903         * cli/cli-logging.c (make_logging_output): Remove function.
7904         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7905         directly.
7906         * ui-file.c (tee_file::tee_file): Remove bools.
7907         (tee_file::~tee_file): Remove deletes.
7908         * ui-file.h (tee_file): Remove bools.
7909
7910 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7911
7912         * mi/mi-cmds.h (mi_cmd_complete): New function.
7913         * mi/mi-main.c (mi_cmd_complete): Likewise.
7914         * mi/mi-cmds.c: Define new MI command -complete.
7915         * NEWS: Mention new -complete command.
7916
7917 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7918
7919         * completer.h (complete): New function.
7920         * completer.c (complete): Likewise.
7921         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7922         function defined in completer.h.
7923
7924 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7925
7926         * MAINTAINERS (Write After Approval): Add myself.
7927
7928 2019-05-17  Tom de Vries  <tdevries@suse.de>
7929
7930         PR gdb/24094
7931         * dwarf2read.c (struct cu_partial_die_info): New struct.
7932         (find_partial_die): Return cu_partial_die_info.
7933         (partial_die_parent_scope, guess_partial_die_structure_name)
7934         (partial_die_info::fixup): Handle new return type of find_partial_die.
7935
7936 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7937
7938         PR breakpoints/24541
7939         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7940         "std::string", simplifying the algorithm.
7941
7942 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7943
7944         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7945         (stap_static_probe_ops::get_probes): Likewise.
7946
7947 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7948
7949         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7950         '-')" and "else if".
7951         (stap_parse_single_operand): Join checks for
7952         "gdbarch_stap_parse_special_token_p" and
7953         "gdbarch_stap_parse_special_token" in the same "if" statement.
7954         Invert check when verifying for operation on register
7955         displacement.
7956
7957 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7958
7959         * stap-probe.c (stap_get_opcode): Update comment.
7960         (stap_get_expected_argument_type): Likewise.
7961         (handle_stap_probe): Likewise.
7962
7963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7964
7965         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7966         return type to 'bool'.  Adjust comment.  Use 'bool' when
7967         appropriate.
7968         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7969         * stap-probe.c (stap_parse_argument_1): Likewise.
7970         (stap_is_operator): Likewise.
7971         (stap_is_generic_prefix): Likewise.
7972         (stap_is_register_prefix): Likewise.
7973         (stap_is_register_indirection_prefix): Likewise.
7974         (stap_is_integer_prefix): Likewise.
7975         (stap_generic_check_suffix): Likewise.
7976         (stap_check_integer_suffix): Likewise.
7977         (stap_check_register_suffix): Likewise.
7978         (stap_check_register_indirection_suffix): Likewise.
7979         (stap_parse_register_operand): Likewise.
7980         (stap_parse_single_operand): Likewise.
7981         (stap_parse_argument_1): Likewise.
7982         (stap_probe::get_argument_count): Likewise.
7983         (stap_is_operator): Likewise.
7984
7985 2019-05-16  Tom Tromey  <tromey@adacore.com>
7986
7987         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7988         keyword to foreach.
7989
7990 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7991
7992         * linux-thread-db.c (try_thread_db_load_1): Change return type
7993         to bool.
7994         (try_thread_db_load): Likewise.
7995         (try_thread_db_load_from_pdir_1): Likewise.
7996         (try_thread_db_load_from_pdir): Likewise.
7997         (try_thread_db_load_from_sdir): Likewise.
7998         (try_thread_db_load_from_dir): Likewise.
7999         (thread_db_load_search): Likewise.
8000         (has_libpthread): Likewise.
8001         (thread_db_load): Likewise.
8002
8003 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8004
8005         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8006         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8007         NULL, and complain/return if that's the case.
8008
8009 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8010
8011         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8012         (advance, posn, abstract_read_memory): New functions.
8013         [struct mem_read_abstraction]: New struct.
8014         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8015
8016 2019-05-14  Tom Tromey  <tromey@adacore.com>
8017
8018         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8019         value is not lval_memory.
8020
8021 2019-05-14  Tom Tromey  <tromey@adacore.com>
8022
8023         * solib.c (info_sharedlibrary_command): Style the file name.
8024
8025 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8026
8027         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8028         (aarch64_vnv_type): Likewise.
8029         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8030         * common/tdesc.c: Likewise.
8031         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8032         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8033         * features/aarch64-fpu.xml: Add ieee half view.
8034         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8035         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8036         * gdbtypes.h (struct builtin_type): Likewise.
8037         (struct objfile_type): Likewise.
8038
8039 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8040
8041         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8042         typo.
8043         * location.h (string_to_event_location): Likewise.
8044
8045 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8046
8047         GDB 8.3 released.
8048
8049 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8050
8051         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8052         New variable declaration.
8053         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8054         New variable.
8055         (print_one_breakpoint): Use ui_out::test_flags and new global
8056         variable to compute use_fixed_output.
8057         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8058         Remove.
8059         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8060         (mi_multi_location_breakpoint_output_fixed): Remove.
8061         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8062         new variable.
8063         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8064         fix_multi_location_breakpoint_output flag if version >= 3.
8065         * ui-out.h (enum ui_out_flag)
8066         <fix_multi_location_breakpoint_output>: New enumerator.
8067
8068 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8069
8070         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8071
8072 2019-05-10  Tom Tromey  <tromey@adacore.com>
8073
8074         * ada-lang.c (catch_ada_completer): New function.
8075         (_initialize_ada_language): Use it.
8076
8077 2019-05-10  Tom Tromey  <tromey@adacore.com>
8078
8079         * thread.c (print_thread_info): Make "requested_threads" const.
8080         * gdbthread.h (print_thread_info): Make "requested_threads"
8081         const.
8082         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8083         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8084
8085 2019-05-08  Tom Tromey  <tom@tromey.com>
8086
8087         * gdbtypes.c (objfile_type_data): Change type.
8088         (objfile_type, _initialize_gdbtypes): Update.
8089
8090 2019-05-08  Tom Tromey  <tom@tromey.com>
8091
8092         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8093         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8094         (_initialize_dwarf2_frame): Update.
8095
8096 2019-05-08  Tom Tromey  <tom@tromey.com>
8097
8098         * objc-lang.c (objc_objfile_data): Change type.
8099         (find_methods): Update.
8100         (_initialize_objc_lang): Remove.
8101
8102 2019-05-08  Tom Tromey  <tom@tromey.com>
8103
8104         * stabsread.c (rs6000_builtin_type_data): Change type.
8105         (rs6000_builtin_type, _initialize_stabsread): Update.
8106
8107 2019-05-08  Tom Tromey  <tom@tromey.com>
8108
8109         * mips-tdep.c (mips_pdr_data): Remove.
8110         (_initialize_mips_tdep): Update.
8111
8112 2019-05-08  Tom Tromey  <tom@tromey.com>
8113
8114         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8115         (hppa_init_objfile_priv_data, read_unwind_info)
8116         (find_unwind_entry, _initialize_hppa_tdep): Update.
8117
8118 2019-05-08  Tom Tromey  <tom@tromey.com>
8119
8120         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8121         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8122         on obstack.
8123         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8124
8125 2019-05-08  Tom Tromey  <tom@tromey.com>
8126
8127         * mdebugread.c (basic_type_data): Change type.
8128         (basic_type, _initialize_mdebugread): Update.
8129
8130 2019-05-08  Tom Tromey  <tom@tromey.com>
8131
8132         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8133
8134 2019-05-08  Tom Tromey  <tom@tromey.com>
8135
8136         * nto-tdep.c (nto_inferior_data_reg): Change type.
8137         (nto_inferior_data): Update.
8138         (nto_inferior_data_cleanup, nto_new_inferior_data)
8139         (_initialize_nto_tdep): Remove.
8140         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8141
8142 2019-05-08  Tom Tromey  <tom@tromey.com>
8143
8144         * ada-lang.c (struct ada_inferior_data): Add initializers.
8145         (ada_inferior_data): Change type.
8146         (ada_inferior_data_cleanup): Remove.
8147         (get_ada_inferior_data, ada_inferior_exit)
8148         (struct ada_pspace_data): Add initializers, destructor.
8149         (ada_pspace_data_handle): Change type.
8150         (get_ada_pspace_data): Update.
8151         (ada_pspace_data_cleanup): Remove.
8152
8153 2019-05-08  Tom Tromey  <tom@tromey.com>
8154
8155         * coffread.c (struct coff_symfile_info): Add initializers.
8156         (coff_objfile_data_key): Move lower.  Change type.
8157         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8158         Update.
8159         (coff_free_info): Remove.
8160
8161 2019-05-08  Tom Tromey  <tom@tromey.com>
8162
8163         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8164         (fbsd_pspace_data_handle): Move lower.  Change type.
8165         (get_fbsd_pspace_data): Update.
8166         (fbsd_pspace_data_cleanup): Remove.
8167         (_initialize_fbsd_tdep): Update.
8168
8169 2019-05-08  Tom Tromey  <tom@tromey.com>
8170
8171         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8172         (get_ada_tasks_pspace_data): Update.
8173         (ada_tasks_pspace_data_cleanup): Remove.
8174         (_initialize_tasks): Update.
8175         (ada_tasks_inferior_data_handle): Change type.
8176         (get_ada_tasks_inferior_data): Update.
8177         (ada_tasks_inferior_data_cleanup): Remove.
8178         (struct ada_tasks_pspace_data): Add initializers.
8179
8180 2019-05-08  Tom Tromey  <tom@tromey.com>
8181
8182         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8183         * symfile-debug.c (debug_sym_get_probes): Change type.
8184         * stap-probe.c (handle_stap_probe):
8185         (stap_static_probe_ops::get_probes): Change type.
8186         * probe.h (class static_probe_ops) <get_probes>: Change type.
8187         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8188         (parse_probes_in_pspace): Update.
8189         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8190         Update.
8191         (any_static_probe_ops::get_probes): Change type.
8192         * elfread.c (elfread_data): New typedef.
8193         (probe_key): Change type.
8194         (elf_get_probes): Likewise.  Update.
8195         (probe_key_free): Remove.
8196         (_initialize_elfread): Update.
8197         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8198         Change type.
8199         (dtrace_process_dof_probe, dtrace_process_dof)
8200         (dtrace_static_probe_ops::get_probe): Change type.
8201
8202 2019-05-08  Tom Tromey  <tom@tromey.com>
8203
8204         * xcoffread.c (struct xcoff_symfile_info): Rename from
8205         coff_symfile_info.  Add initializers.
8206         (xcoff_objfile_data_key): Move lower.  Change type.
8207         (XCOFF_DATA): Rewrite.
8208         (xcoff_free_info): Remove.
8209         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8210         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8211         (xcoff_initial_scan): Update.
8212
8213 2019-05-08  Tom Tromey  <tom@tromey.com>
8214
8215         * solib-svr4.c (struct svr4_info): Add initializers and
8216         destructor.
8217         <probes_table>: Now an htab_up.
8218         (solib_svr4_pspace_data): Change type.
8219         (free_probes_table): Simplify.
8220         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8221         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8222         (probes_table_remove_objfile_probes, register_solib_event_probe)
8223         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8224         (_initialize_svr4_solib): Update.
8225
8226 2019-05-08  Tom Tromey  <tom@tromey.com>
8227
8228         * remote.c (remote_pspace_data): Change type.
8229         (remote_pspace_data_cleanup): Remove.
8230         (get_remote_exec_file, set_pspace_remote_exec_file)
8231         (_initialize_remote): Update.
8232
8233 2019-05-08  Tom Tromey  <tom@tromey.com>
8234
8235         * breakpoint.c (breakpoint_objfile_key): Change type.
8236         (get_breakpoint_objfile_data): Update.
8237         (free_breakpoint_objfile_data): Remove.
8238         (_initialize_breakpoint): Update.
8239
8240 2019-05-08  Tom Tromey  <tom@tromey.com>
8241
8242         * linux-tdep.c (struct linux_info): Add initializers.
8243         (linux_inferior_data): Move.  Change type.
8244         (invalidate_linux_cache_inf): Update.
8245         (linux_inferior_data_cleanup): Remove.
8246         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8247
8248 2019-05-08  Tom Tromey  <tom@tromey.com>
8249
8250         * auxv.c (auxv_inferior_data): Move.  Change type.
8251         (auxv_inferior_data_cleanup): Remove.
8252         (invalidate_auxv_cache_inf): Rewrite.
8253         (get_auxv_inferior_data, _initialize_auxv): Update.
8254
8255 2019-05-08  Tom Tromey  <tom@tromey.com>
8256
8257         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8258         (symfile_debug_objfile_data_key): Change type.
8259         (symfile_debug_installed, debug_qf_has_symbols)
8260         (debug_qf_find_last_source_symtab)
8261         (debug_qf_forget_cached_source_info)
8262         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8263         (debug_qf_print_stats, debug_qf_dump)
8264         (debug_qf_expand_symtabs_for_function)
8265         (debug_qf_expand_all_symtabs)
8266         (debug_qf_expand_symtabs_with_fullname)
8267         (debug_qf_map_matching_symbols)
8268         (debug_qf_expand_symtabs_matching)
8269         (debug_qf_find_pc_sect_compunit_symtab)
8270         (debug_qf_map_symbol_filenames)
8271         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8272         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8273         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8274         (debug_sym_read_linetable, debug_sym_relocate): Update.
8275         (symfile_debug_free_objfile): Remove.
8276         (install_symfile_debug_logging, _initialize_symfile_debug):
8277         Update.
8278
8279 2019-05-08  Tom Tromey  <tom@tromey.com>
8280
8281         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8282         allocate_on_obstack.
8283         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8284         (get_dwarf2_per_objfile): Update.
8285         (set_dwarf2_per_objfile): Remove.
8286         (dwarf2_has_info, dwarf2_get_section_info): Update.
8287         (dwarf2_free_objfile): Remove.
8288         (_initialize_dwarf2_read): Update.
8289
8290 2019-05-08  Tom Tromey  <tom@tromey.com>
8291
8292         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8293         initializers.
8294         <unsupported_script_warning_printed,
8295         script_not_found_warning_printed>: Now bool.
8296         (auto_load_pspace_data): Change type.
8297         (~auto_load_pspace_info): Rename from
8298         auto_load_pspace_data_cleanup.
8299         (get_auto_load_pspace_data, init_loaded_scripts_info)
8300         (clear_section_scripts, maybe_print_unsupported_script_warning)
8301         (maybe_print_script_not_found_warning, _initialize_auto_load):
8302         Update.
8303
8304 2019-05-08  Tom Tromey  <tom@tromey.com>
8305
8306         * objfiles.c (objfile_pspace_info): Add destructor and
8307         initializers.
8308         (objfiles_pspace_data): Change type.
8309         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8310         (get_objfile_pspace_data): Update.
8311         (objfiles_bfd_data): Change type.
8312         (get_objfile_bfd_data): Update.
8313         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8314
8315 2019-05-08  Tom Tromey  <tom@tromey.com>
8316
8317         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8318         Change type.
8319         (get_catch_syscall_inferior_data): Update.
8320         (catch_syscall_inferior_data_cleanup): Remove.
8321         (_initialize_break_catch_syscall): Update.
8322
8323 2019-05-08  Tom Tromey  <tom@tromey.com>
8324
8325         * inflow.c (struct terminal_info): Add destructor and
8326         initializers.
8327         (inflow_inferior_data): Change type.
8328         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8329         (get_inflow_inferior_data, inflow_inferior_exit)
8330         (swap_terminal_info, _initialize_inflow): Update.
8331
8332 2019-05-08  Tom Tromey  <tom@tromey.com>
8333
8334         * target-dcache.c (target_dcache_cleanup): Remove.
8335         (target_dcache_aspace_key): Change type.
8336         (target_dcache_init_p, target_dcache_invalidate)
8337         (target_dcache_get, target_dcache_get_or_init)
8338         (_initialize_target_dcache): Update.
8339         * dcache.h (struct dcache_deleter): New.
8340
8341 2019-05-08  Tom Tromey  <tom@tromey.com>
8342
8343         * symtab.c (struct symbol_cache): Add destructor and
8344         initializers.
8345         (symbol_cache_key): Move.  Change type.
8346         (make_symbol_cache, free_symbol_cache): Remove.
8347         (get_symbol_cache): Update.
8348         (symbol_cache_cleanup): Remove.
8349         (ALL_PSPACES, symbol_cache_flush)
8350         (maintenance_print_symbol_cache)
8351         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8352         Update.
8353
8354 2019-05-08  Tom Tromey  <tom@tromey.com>
8355
8356         * symtab.c (struct main_info): Add destructor and initializers.
8357         (main_progspace_key): Move.  Change type.
8358         (get_main_info): Update.
8359         (main_info_cleanup): Remove.
8360         (_initialize_symtab): Update.
8361
8362 2019-05-08  Tom Tromey  <tom@tromey.com>
8363
8364         * registry.h (DECLARE_REGISTRY): Define the _key class.
8365
8366 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8367
8368         * NEWS: Merge two 'New commands' sections.
8369
8370 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8371
8372         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8373         parameter and use Ada language definition instead.
8374         (ada_val_print_ptr): Remove unused language parameter.
8375         (ada_val_print_num): Remove language parameter and use Ada language
8376         definition instead.
8377         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8378         parameter.
8379         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8380         parameter and use Ada language definition instead.
8381         (ada_val_print_1): Update all ada_val_print_xxx calls.
8382         Remove language parameter.
8383         (ada_val_print): Update ada_val_print_1 call.
8384
8385 2019-05-08  Tom Tromey  <tromey@adacore.com>
8386
8387         * remote.c (remote_hw_watchpoint_limit)
8388         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8389         Now static.
8390
8391 2019-05-08  Tom Tromey  <tromey@adacore.com>
8392
8393         * maint.c (_initialize_maint_cmds): Move initialization code to
8394         remote.c.
8395         (watchdog, show_watchdog): Move to remote.c.
8396         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8397         "watchdog" static.
8398         (_initialize_remote): Move initialization code from maint.c.
8399         * defs.h (watchdog): Don't declare.
8400
8401 2019-05-08  Tom Tromey  <tromey@adacore.com>
8402
8403         * tui/tui-interp.c: Include main.h.
8404         * interps.c: Include main.h.
8405         * main.h (interpreter_p): Declare.
8406         * defs.h (interpreter_p): Don't declare.
8407
8408 2019-05-08  Tom Tromey  <tromey@adacore.com>
8409
8410         * dwarf2loc.c: Include dwarf2read.h.
8411         * defs.h (read_unsigned_leb128): Don't declare.
8412         * dwarf2read.h (read_unsigned_leb128): Declare.
8413
8414 2019-05-08  Tom Tromey  <tromey@adacore.com>
8415
8416         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8417         method.
8418
8419 2019-05-08  Tom Tromey  <tromey@adacore.com>
8420
8421         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8422         when no wrap column is set.
8423
8424 2019-05-08  Tom Tromey  <tromey@adacore.com>
8425
8426         * c-lang.c (c_get_string): Handle non-C-style arrays.
8427
8428 2019-05-08  Tom Tromey  <tromey@adacore.com>
8429
8430         * typeprint.c (print_offset_data::update): Print the bit offset,
8431         not the number of bits remaining.
8432
8433 2019-05-08  Tom Tromey  <tromey@adacore.com>
8434
8435         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8436         padding at end of comment.
8437
8438 2019-05-08  Tom Tromey  <tromey@adacore.com>
8439
8440         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8441         Compare main types.
8442
8443 2019-05-06  Tom Tromey  <tom@tromey.com>
8444
8445         * common/scoped_mmap.c: Include common-defs.h.
8446         * common/scoped_mmap.h: Don't include config.h.
8447
8448 2019-05-04  Tom Tromey  <tom@tromey.com>
8449
8450         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8451         (struct aarch64_call_info): Add initializers.
8452         <si>: Now a std::vector.
8453         (pass_on_stack, aarch64_push_dummy_call): Update.
8454
8455 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8456             Tom Tromey  <tom@tromey.com>
8457
8458         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8459         (ppc_threads): Now a std::vector.  Now static.
8460         (hwdebug_find_thread_points_by_tid)
8461         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8462         Update.
8463
8464 2019-05-04  Tom Tromey  <tom@tromey.com>
8465
8466         * arc-tdep.c (arc_tdesc_init): Return bool.
8467
8468 2019-05-04  Tom Tromey  <tom@tromey.com>
8469
8470         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8471         Use gdb_assert_not_reached.
8472
8473 2019-05-04  Tom Tromey  <tom@tromey.com>
8474
8475         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8476         "false".
8477
8478 2019-05-04  Tom Tromey  <tom@tromey.com>
8479
8480         * arc-tdep.c (arc_tdesc_init): Use bool.
8481
8482 2019-05-04  Tom Tromey  <tom@tromey.com>
8483
8484         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8485
8486 2019-05-04  Tom Tromey  <tom@tromey.com>
8487
8488         * cli/cli-cmds.c (valid_command_p): Return bool.
8489
8490 2019-05-04  Tom Tromey  <tom@tromey.com>
8491
8492         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8493         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8494
8495 2019-05-04  Raul Tambre  <raul@tambre.ee>
8496
8497         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8498         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8499         operator for comparison.
8500
8501 2019-05-04  Tom Tromey  <tom@tromey.com>
8502
8503         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8504         (lookup_partial_symbol, print_partial_symbols)
8505         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8506         (psymbol_compare): Update.
8507         (add_psymbol_to_bcache): Clear the entire psymbol.
8508         (maintenance_check_psymtabs): Update.
8509         * psympriv.h (struct partial_symbol): Don't derive from
8510         general_symbol_info.
8511         <obj_section, unrelocated_address, address,
8512         set_unrelocated_address>: Update.
8513         <ginfo>: New member.
8514         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8515         (debug_names::write_psymbols): Update.
8516
8517 2019-05-04  Tom de Vries  <tdevries@suse.de>
8518
8519         * contrib/cc-with-tweaks.sh: Support -n arg.
8520
8521 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8522
8523         * corelow.c (core_target::detach): Ensure frame cache and
8524         register caches are cleared.
8525         inferior.c (exit_inferior_1): Likewise.
8526
8527 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8528             Tom Tromey  <tom@tromey.com>
8529
8530         * dictionary.c (collate_pending_symbols_by_language): Remove
8531         "struct" from foreach.
8532         * symtab.c (lookup_global_symbol_from_objfile)
8533         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8534         foreach.
8535         * ser-tcp.c (net_open): Remove "struct" from foreach.
8536         * objfiles.c (objfile_relocate, objfile_rebase)
8537         (objfile_has_symbols): Remove "struct" from foreach.
8538         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8539         from foreach.
8540         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8541         foreach.
8542         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8543         "struct" from foreach.
8544         * ada-lang.c (create_excep_cond_exprs)
8545         (ada_exception_catchpoint_cond_string): Remove "struct" from
8546         foreach.
8547
8548 2019-05-03  Tom Tromey  <tromey@adacore.com>
8549
8550         * ada-exp.y (convert_char_literal): Check suffix of each
8551         enumerator.
8552
8553 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8554
8555         PR ada/21406:
8556         * ada-exp.y (yywrap): Don't define.
8557         * ada-lex.l (%option): Add noyywrap
8558         (yywrap): Remove.
8559
8560 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8561
8562         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8563         _WIN32_WINNT to the XP level, unless already defined to a higher
8564         level.
8565
8566         * unittests/parse-connection-spec-selftests.c:
8567         * ser-tcp.c:
8568         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8569         override.
8570
8571         * symfile.c (find_separate_debug_file): Remove colon from the
8572         drive spec of DOS/Windows file names of the target, so that the
8573         file name produced from DEBUGDIR and the target's directory will
8574         be valid on DOS/Windows systems.
8575
8576 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8577
8578         * rust-lang.c (val_print_struct): Handle printing structures
8579         containing strings.
8580
8581 2019-05-02  Tom Tromey  <tromey@adacore.com>
8582
8583         * valarith.c (_initialize_valarith): Remove.
8584
8585 2019-05-01  Tom Tromey  <tromey@adacore.com>
8586
8587         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8588         bitfields.
8589
8590 2019-05-01  Tom Tromey  <tromey@adacore.com>
8591
8592         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8593         for big-endian copies.
8594
8595 2019-04-30  Ali Tamur  <tamur@google.com>
8596         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8597         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8598         (read_3_bytes): New function.
8599
8600 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8601
8602         * windows-nat.c (main_thread_id): Delete.
8603         (handle_output_debug_string): Replace main_thread_id by
8604         current_event.dwThreadId.
8605         (fake_create_process): Likewise.
8606         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8607         Do not set main_thread_id.
8608         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8609         current_event.dwThreadId.
8610         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8611
8612 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8613
8614         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8615         Use current_event.dwThreadId instead of main_thread_id.
8616
8617 2019-04-30  Tom Tromey  <tromey@adacore.com>
8618
8619         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8620         (create_excep_cond_exprs): Iterate over program spaces.
8621         (ada_exception_catchpoint_cond_string): Examine all minimal
8622         symbols for exception types.
8623
8624 2019-04-30  Tom Tromey  <tromey@adacore.com>
8625
8626         PR c++/24470:
8627         * dwarf2read.c (process_structure_scope): Handle case where type
8628         has template parameters but no symbol was created.
8629
8630 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8631             Chris January  <chris.january@arm.com>
8632
8633         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8634         qualifier.
8635         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8636
8637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8638
8639         * f-typeprint.c (f_print_type): Update rules for printing
8640         whitespace.
8641         (f_type_print_varspec_suffix): Likewise.
8642
8643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8644             Chris January  <chris.january@arm.com>
8645
8646         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8647         function arguments.
8648
8649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8650
8651         * f-lang.c (build_fortran_types): Change name of void type to
8652         lower case.
8653         * f-typeprint.c (f_type_print_base): Print the name of the void
8654         type, rather than a fixed string.
8655         * f-valprint.c (f_decorations): Use lower case void string.
8656
8657 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8658             Chris January  <chris.january@arm.com>
8659
8660         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8661         types for Fortran.
8662
8663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8664             Chris January  <chris.january@arm.com>
8665             David Lecomber  <david.lecomber@arm.com>
8666
8667         * f-exp.y (BINOP_INTRINSIC): New token.
8668         (exp): New parser rule handling BINOP_INTRINSIC.
8669         (f77_keywords): Add new builtin procedures.
8670         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8671         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8672         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8673         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8674         (print_unop_subexp_f): New function.
8675         (print_binop_subexp_f): New function.
8676         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8677         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8678         (dump_subexp_body_f): Likewise.
8679         (operator_check_f): Likewise.
8680         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8681         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8682
8683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8684
8685         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8686         UNOP_KIND.
8687         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8688         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8689         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8690         (operator_length_f): New fuction.
8691         (print_subexp_f): New function.
8692         (op_name_f): New function.
8693         (dump_subexp_body_f): New function.
8694         (operator_check_f): New function.
8695         (exp_descriptor_f): Replace standard expression handling functions
8696         with new functions.
8697         * gdb/fortran-operator.def: New file.
8698         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8699         * gdb/std-operator.def: Remove UNOP_KIND.
8700
8701 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8702
8703         * std-operator.def: Remove unbalanced, stray double quote
8704         character.
8705
8706 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8707             Chris January  <chris.january@arm.com>
8708             Daniel Everett  <daniel.everett@arm.com>
8709             Nick Forrington  <nick.forrington@arm.com>
8710             Richard Bunt  <richard.bunt@arm.com>
8711
8712         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8713         of depth when printing anonymous structs or unions.
8714         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8715         Don't print either the top-level value, or the children if the
8716         max-depth is exceeded.
8717         (ppscm_print_children): When printing the key of a map, allow one
8718         extra level of depth.
8719         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8720         print either the top-level value, or the children if the max-depth
8721         is exceeded.
8722         (print_children): When printing the key of a map, allow one extra
8723         level of depth.
8724         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8725         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8726         (user_print_options): Initialise max_depth field.
8727         (val_print_scalar_or_string_type_p): New function.
8728         (val_print): Check to see if the max depth has been reached.
8729         (val_print_check_max_depth): Define new function.
8730         (show_print_max_depth): New function.
8731         (_initialize_valprint): Add 'print max-depth' option.
8732         * valprint.h (struct value_print_options) <max_depth>: New field.
8733         (val_print_check_max_depth): Declare new function.
8734         * NEWS: Document new feature.
8735
8736 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8737
8738         * ada-lang.c (ada_language_defn): Initialise new field.
8739         * c-lang.c (c_is_string_type_p): New function.
8740         (c_language_defn): Initialise new field.
8741         (cplus_language_defn): Initialise new field.
8742         (asm_language_defn): Initialise new field.
8743         (minimal_language_defn): Initialise new field.
8744         * c-lang.h (c_is_string_type_p): Declare new function.
8745         * d-lang.c (d_language_defn): Initialise new field.
8746         * f-lang.c (f_is_string_type_p): New function.
8747         (f_language_defn): Initialise new field.
8748         * go-lang.c (go_is_string_type_p): New function.
8749         (go_language_defn): Initialise new field.
8750         * language.c (default_is_string_type_p): New function.
8751         (unknown_language_defn): Initialise new field.
8752         (auto_language_defn): Initialise new field.
8753         * language.h (struct language_defn) <la_is_string_type_p>: New
8754         member variable.
8755         (default_is_string_type_p): Declare new function.
8756         * m2-lang.c (m2_language_defn): Initialise new field.
8757         * objc-lang.c (objc_language_defn): Initialise new field.
8758         * opencl-lang.c (opencl_language_defn): Initialise new field.
8759         * p-lang.c (pascal_is_string_type_p): New function.
8760         (pascal_language_defn): Initialise new field.
8761         * rust-lang.c (rust_is_string_type_p): New function.
8762         (rust_language_defn): Initialise new field.
8763
8764 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8767         New field.
8768         * ada-lang.c (ada_language_defn): Initialise new field.
8769         * c-lang.c (c_language_defn): Likewise.
8770         (cplus_language_defn): Likewise.
8771         (asm_language_defn): Likewise.
8772         (minimal_language_defn): Likewise.
8773         * d-lang.c (d_language_defn): Likewise.
8774         * f-lang.c (f_language_defn): Likewise.
8775         * go-lang.c (go_language_defn): Likewise.
8776         * language.c (unknown_language_defn): Likewise.
8777         (auto_language_defn): Likewise.
8778         * m2-lang.c (m2_language_defn): Likewise.
8779         * objc-lang.c (objc_language_defn): Likewise.
8780         * opencl-lang.c (opencl_language_defn): Likewise.
8781         * p-lang.c (pascal_language_defn): Likewise.
8782         * rust-lang.c (rust_language_defn): Likewise.
8783
8784 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8785
8786         * ada-lang.c (ada_is_character_type): Change return type to bool.
8787         (ada_is_string_type): Likewise.
8788         * ada-lang.h (ada_is_character_type): Update declaration
8789         (ada_is_string_type): Likewise.
8790
8791 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8792
8793         Support style in 'frame|thread apply'
8794
8795         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8796         * record.c (record_start, record_stop): Update callers of
8797         execute_command_to_string with false.
8798         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8799         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8800         methods.
8801         (class string_file): New constructor with term_out parameter.
8802         Override methods term_out and can_emit_style_escape.  New member
8803         term_out.
8804         (class stdio_file): Override can_emit_style_escape.
8805         (class tee_file): Override term_out and can_emit_style_escape.
8806         * utils.h (can_emit_style_escape): Remove.
8807         * utils.c (can_emit_style_escape): Likewise.
8808         Update all callers of can_emit_style_escape (SOMESTREAM) to
8809         SOMESTREAM->can_emit_style_escape.
8810         * source-cache.c (source_cache::get_source_lines): Likewise.
8811         * stack.c (frame_apply_command_count): Call execute_command_to_string
8812         passing the term_out characteristic of the current gdb_stdout.
8813         * thread.c (thr_try_catch_cmd): Likewise.
8814         * top.c (execute_command_to_string): pass term_out parameter
8815         to construct the string_file for the command output.
8816         * ui-file.c (term_cli_styling): New function (most code moved
8817         from utils.c can_emit_style_escape).
8818         (string_file::string_file, string_file::can_emit_style_escape,
8819         stdio_file::can_emit_style_escape, tee_file::term_out,
8820         tee_file::can_emit_style_escape): New functions.
8821
8822 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8823
8824         * NEWS: Mention the new set|show may-call-functions.
8825         * infcall.c (may_call_functions_p): New variable.
8826         (show_may_call_functions_p): New function.
8827         (call_function_by_hand_dummy): Throws an error if not
8828         may-call-functions.
8829         (_initialize_infcall): Call add_setshow_boolean_cmd for
8830         may-call-functions.
8831
8832 2019-04-25  Keith Seitz  <keiths@redhat.com>
8833
8834         PR c++/24367
8835         * cp-support.c (inspect_type): Don't attempt substitutions
8836         of symbol with the same name.
8837
8838 2019-04-25  Tom Tromey  <tromey@adacore.com>
8839
8840         PR gdb/24475:
8841         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8842         static.
8843
8844 2019-04-25  Tom Tromey  <tromey@adacore.com>
8845
8846         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8847         rvalue reference.
8848         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8849         (gdb_xml_parser::parse): Use std::move.
8850         * python/python-internal.h (gdbpy_convert_exception): Take a const
8851         reference.
8852         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8853         std::move.
8854         * python/py-utils.c (gdbpy_convert_exception): Take a const
8855         reference.
8856         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8857         Use std::move.
8858         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8859         Use std::move.
8860         * mi/mi-main.c (mi_print_exception): Take a const reference.
8861         * main.c (handle_command_errors): Take a const reference.
8862         * linespec.c (parse_linespec): Use std::move.
8863         * infcall.c (run_inferior_call): Use std::move.
8864         (call_function_by_hand_dummy): Use std::move.
8865         * exec.c (try_open_exec_file): Use std::move.
8866         * exceptions.h (exception_print, exception_fprintf)
8867         (exception_print_same): Update.
8868         * exceptions.c (print_exception, exception_print)
8869         (exception_fprintf, exception_print_same): Change parameters to
8870         const reference.
8871         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8872         * common/new-op.c: Use std::move.
8873         * common/common-exceptions.h (struct gdb_exception): Add move
8874         constructor.
8875         (struct gdb_exception_error, struct gdb_exception_quit, struct
8876         gdb_quit_bad_alloc): Change constructor to move constructor.
8877         (throw_exception): Change parameter to rvalue reference.
8878         * common/common-exceptions.c (throw_exception): Take rvalue
8879         reference.
8880         * cli/cli-interp.c (safe_execute_command): Use std::move.
8881         * breakpoint.c (insert_bp_location, location_to_sals): Use
8882         std::move.
8883
8884 2019-04-25  Tom Tromey  <tromey@adacore.com>
8885
8886         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8887         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8888         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8889         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8890         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8891         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8892         guile/scm-value.c: Use unpack.
8893         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8894         gdbscm_gdb_exception.
8895         (gdbscm_throw_gdb_exception): Likewise.
8896         (struct gdbscm_gdb_exception): New.
8897         (unpack): New function.
8898         (gdbscm_wrap): Use unpack.
8899
8900 2019-04-25  Tom Tromey  <tromey@adacore.com>
8901
8902         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8903         (gdb_rl_callback_handler): Use std::move.
8904         * common/common-exceptions.h (struct gdb_exception): Add move
8905         assignment operator.
8906         (throw_exception_sjlj): Change "exception" to const reference.
8907         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8908         (throw_exception_sjlj): Change "exception" to const reference.
8909
8910 2019-04-25  Tom Tromey  <tromey@adacore.com>
8911
8912         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8913         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8914         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8915         Update.
8916         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8917         Update.
8918         * mi/mi-interp.c (mi_interp::exec): Update.
8919         * linespec.c (parse_linespec): Update.
8920         * infcall.c (run_inferior_call): Update.
8921         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8922         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8923         (gdbscm_lookup_global_symbol): Update.
8924         * guile/scm-param.c (gdbscm_parameter_value): Update.
8925         * guile/scm-frame.c (gdbscm_frame_read_register)
8926         (gdbscm_frame_read_var): Update.
8927         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8928         * exec.c (try_open_exec_file): Update.
8929         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8930         (gdb_rl_callback_handler): Update.
8931         * common/common-exceptions.h (exception_none): Don't declare.
8932         * common/common-exceptions.c (exception_none): Don't define.
8933         (struct catcher) <exception>: Update.
8934         * cli/cli-interp.c (safe_execute_command): Update.
8935         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8936
8937 2019-04-25  Ali Tamur  <tamur@google.com>
8938
8939         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8940         (read_attribute_value): Likewise.
8941         (dwarf2_read_addr_index): Update comment.
8942         (read_str_index): Add DW_FORM_strx.
8943         (dwarf2_string_attr): Likewise.
8944         (dwarf2_const_value_attr): Likewise.
8945         (dump_die_shallow): Likewise.
8946         (dwarf2_fetch_constant_bytes): Likewise.
8947         (skip_form_bytes): Likewise.
8948         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8949
8950 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8951
8952         PR corefiles/11608
8953         PR corefiles/18187
8954         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8955         OFFSET.  Verify if current mapping contains an ELF header.
8956         (linux_find_memory_regions_full): Adjust call to
8957         dump_mapping_p.
8958
8959 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8960             Kang Li <kanglictf@gmail.com>
8961
8962         PR gdb/21600
8963
8964         * dwarf2-frame.c (read_initial_length): Be consistent about using
8965         unsigned representation of length.
8966         (decode_frame_entry_1): Likewise.  Check for wraparound of
8967         end pointer as well as buffer overflow.
8968
8969 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8970
8971         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8972         "vq".
8973
8974 2019-04-24  Tom Tromey  <tromey@adacore.com>
8975
8976         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8977
8978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8979
8980         * s12z-tdep.c (s12z_unwind_pc): Delete.
8981         (s12z_unwind_sp): Delete.
8982         (s12z_gdbarch_init): Don't register deleted functions with
8983         gdbarch.
8984
8985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8986
8987         * rl78-tdep.c (rl78_unwind_sp): Delete.
8988         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8989
8990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8991
8992         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8993         (xstormy16_unwind_pc): Delete.
8994         (xstormy16_dummy_id): Delete.
8995         (xstormy16_gdbarch_init): Don't register deleted functions with
8996         gdbarch.
8997
8998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8999
9000         * vax-tdep.c (vax_unwind_pc): Delete.
9001         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9002
9003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9004
9005         * v850-tdep.c (v850_unwind_sp): Delete.
9006         (v850_unwind_pc): Delete.
9007         (v850_dummy_id): Delete.
9008         (v850_gdbarch_init): Don't register deleted functions with
9009         gdbarch.
9010
9011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9012
9013         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9014         (tilegx_unwind_pc): Delete.
9015         (tilegx_unwind_dummy_id): Delete.
9016         (tilegx_gdbarch_init): Don't register deleted functions with
9017         gdbarch.
9018
9019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9022         (tic6x_dummy_id): Delete.
9023         (tic6x_gdbarch_init): Don't register deleted functions with
9024         gdbarch.
9025
9026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9027
9028         * sparc-tdep.c (sparc_unwind_pc): Delete.
9029         (sparc32_gdbarch_init): Don't register deleted function with
9030         gdbarch.
9031
9032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9033
9034         * sh-tdep.c (sh_unwind_sp): Delete.
9035         (sh_unwind_pc): Delete.
9036         (sh_dummy_id): Delete.
9037         (sh_gdbarch_init): Don't register deleted functions with
9038         gdbarch.
9039
9040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9041
9042         * score-tdep.c (score_unwind_sp): Delete.
9043         (score_unwind_pc): Delete.
9044         (score_dummy_id): Delete.
9045         (score_gdbarch_init): Don't register deleted functions with
9046         gdbarch.
9047
9048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * rx-tdep.c (rx_unwind_pc): Delete.
9051         (rx_unwind_sp): Delete.
9052         (rx_dummy_id): Delete.
9053         (rx_gdbarch_init): Don't register deleted functions with
9054         gdbarch.  Update comment.
9055
9056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9057
9058         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9059         (rs6000_dummy_id): Delete.
9060         (rs6000_gdbarch_init): Don't register deleted functions with
9061         gdbarch.
9062
9063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9064
9065         * or1k-tdep.c (or1k_dummy_id): Delete.
9066         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9067
9068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9069
9070         * nios2-tdep.c (nios2_dummy_id): Delete.
9071         (nios2_unwind_sp): Delete.
9072         (nios2_gdbarch_init): Don't register deleted functions with
9073         gdbarch.
9074
9075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9076
9077         * nds32-tdep.c (nds32_dummy_id): Delete.
9078         (nds32_unwind_pc): Delete.
9079         (nds32_unwind_sp): Delete.
9080         (nds32_gdbarch_init): Don't register deleted functions with
9081         gdbarch.
9082
9083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9084
9085         * msp430-tdep.c (msp430_unwind_pc): Delete.
9086         (msp430_unwind_sp): Delete.
9087         (msp430_dummy_id): Delete.
9088         (msp430_gdbarch_init): Don't register deleted functions with
9089         gdbarch.
9090
9091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9092
9093         * moxie-tdep.c (moxie_unwind_sp): Delete.
9094         (moxie_unwind_pc): Delete.
9095         (moxie_dummy_id): Delete.
9096         (moxie_gdbarch_init): Don't register deleted functions with
9097         gdbarch.
9098
9099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9100
9101         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9102         (mn10300_unwind_pc): Delete.
9103         (mn10300_unwind_sp): Delete.
9104         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9105         mn10300_unwind_sp.
9106         (mn10300_frame_unwind_init): Don't register deleted functions with
9107         gdbarch.
9108
9109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9110
9111         * mep-tdep.c (mep_unwind_pc): Delete.
9112         (mep_unwind_sp): Delete.
9113         (mep_dummy_id): Delete.
9114         (mep_gdbarch_init): Don't register deleted functions with
9115         gdbarch.
9116
9117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9120         (m68hc11_unwind_sp): Delete.
9121         (m68hc11_gdbarch_init): Don't register deleted functions with
9122         gdbarch.
9123
9124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9125
9126         * m32r-tdep.c (m32r_unwind_sp): Delete.
9127         (m32r_unwind_pc): Delete.
9128         (m32r_dummy_id): Delete.
9129         (m32r_gdbarch_init): Don't register deleted functions with
9130         gdbarch.
9131
9132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9133
9134         * m32c-tdep.c (m32c_unwind_pc): Delete.
9135         (m32c_unwind_sp): Delete.
9136         (m32c_dummy_id): Delete.
9137         (m32c_gdbarch_init): Don't register deleted functions with
9138         gdbarch.
9139
9140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9143         (lm32_unwind_pc): Delete.
9144         (lm32_dummy_id): Delete.
9145         (lm32_gdbarch_init): Don't register deleted functions with
9146         gdbarch.
9147
9148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9149
9150         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9151         (iq2000_unwind_pc): Delete.
9152         (iq2000_dummy_id): Delete.
9153         (iq2000_gdbarch_init): Don't register deleted functions with
9154         gdbarch.
9155
9156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9157
9158         * nds32-tdep.c (nds32_type_align): Delete.
9159         (nds32_push_dummy_call): Use type_align instead.
9160
9161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * arm-tdep.c (arm_type_align): Only handle vector override case.
9164         (arm_push_dummy_call): Use type_align.
9165         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9166
9167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9168
9169         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9170         case.
9171         (pass_on_stack): Use type_align.
9172         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9173         function.
9174
9175 2019-04-23  Tom Tromey  <tromey@adacore.com>
9176
9177         * dwarf2read.c (line_header::file_name_at): Remove unused
9178         overload.
9179
9180 2019-04-23  Tom de Vries  <tdevries@suse.de>
9181
9182         PR gdb/24438
9183         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9184         invocation.
9185
9186
9187 2019-03-27  Ali Tamur  <tamur@google.com>
9188
9189         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9190         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9191         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9192         (dwarf_expr_context::get_addr_index): Likewise
9193         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9194         (symbol_needs_eval_context::get_addr_index): Likewise
9195         (disassemble_dwarf_expression): Add DW_OP_addrx
9196         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9197         (read_cutu_die_from_dwo): Update comment
9198         (skip_one_die): Add DW_FORM_addrx
9199         (read_attribute_value): Likewise
9200         (var_decode_location): Add DW_OP_addrx
9201         (dwarf2_const_value_attr): Add DW_FORM_addrx
9202         (dump_die_shallow): Likewise
9203         (dwarf2_fetch_constant_bytes): Likewise
9204         (decode_locdesc): Add DW_OP_addrx
9205         (skip_form_bytes): Add DW_FORM_addrx
9206
9207 2019-04-22  Ali Tamur  <tamur@google.com>
9208
9209         * MAINTAINERS (Write After Approval): Add self.
9210
9211 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9212
9213         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9214         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9215         (open_symbol_file_object): Likewise.
9216         (svr4_default_sos): Add info parameter.
9217         (svr4_read_so_list): Likewise.
9218         (svr4_current_sos_direct): Adjust functions calls to pass down
9219         info.
9220         (svr4_current_sos_1): Add info parameter.
9221         (svr4_current_sos): Call get_svr4_info, pass info down to
9222         svr4_current_sos_1.
9223         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9224         get_svr4_info.
9225         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9226         get_svr4_info.
9227         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9228         to get_svr4_info.
9229         (probes_table_remove_objfile_probes): Likewise.
9230         (register_solib_event_probe): Add info parameter.
9231         (solist_update_incremental): Pass info parameter down to
9232         svr4_read_so_list.
9233         (disable_probes_interface): Add info parameter.
9234         (svr4_handle_solib_event): Pass current_program_space to
9235         get_svr4_info.  Adjust disable_probes_interface cleanup.
9236         (svr4_create_probe_breakpoints): Add info parameter, pass it
9237         down to register_solib_event_probe.
9238         (svr4_create_solib_event_breakpoints): Add info parameter,
9239         pass it down to svr4_create_probe_breakpoints.
9240         (enable_break): Pass info down to
9241         svr4_create_solib_event_breakpoints.
9242         (svr4_solib_create_inferior_hook): Pass current_program_space to
9243         get_svr4_info.
9244         (svr4_clear_solib): Likewise.
9245
9246 2019-04-22  Pedro Alves  <palves@redhat.com>
9247
9248         * solib-svr4.c (svr4_free_objfile_observer): New.
9249         (probe_and_action::objfile): New field.
9250         (probes_table_htab_remove_objfile_probes)
9251         (probes_table_remove_objfile_probes): New functions.
9252         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9253         in the new probe_and_action.  Don't store the probe in 'lookup'.
9254         (svr4_create_probe_breakpoints): Pass objfile to
9255         register_solib_event_probe.
9256         (_initialize_svr4_solib): Register a free_objfile observer.
9257
9258 2019-04-19  Tom Tromey  <tom@tromey.com>
9259
9260         * common/queue.h: Remove.
9261
9262 2019-04-19  Tom Tromey  <tom@tromey.com>
9263
9264         * event-loop.c: Don't include "common/queue.h".
9265
9266 2019-04-19  Tom Tromey  <tom@tromey.com>
9267
9268         * remote.c (remote_target): Use delete.
9269         * remote-notif.h: Include <list>, not "common/queue.h".
9270         (notif_client_p): Remove typedef.
9271         (remote_notif_state): Add constructor, destructor, initializer.
9272         <notif_queue>: Now a std::list.
9273         (remote_notif_state_xfree): Don't declare.
9274         * remote-notif.c (remote_notif_process, handle_notification)
9275         (remote_notif_state_allocate): Update.
9276         (~remote_notif_state): Rename from remote_notif_state_xfree.
9277
9278 2019-04-19  Tom Tromey  <tom@tromey.com>
9279
9280         * symfile.c (reread_symbols): Update.
9281         * objfiles.c (objfile_register_static_link)
9282         (objfile_lookup_static_link): Update
9283         (~objfile) Don't delete static_links.
9284         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9285
9286 2019-04-19  Tom Tromey  <tom@tromey.com>
9287
9288         * type-stack.h (struct type_stack) <insert>: Constify string.
9289         * type-stack.c (type_stack::insert): Constify string.
9290         * gdbtypes.h (lookup_template_type): Update.
9291         (address_space_name_to_int): Update.
9292         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9293         const.
9294         (lookup_template_type): Make name const.
9295         * c-exp.y: Update rules.
9296         (lex_one_token, classify_name, classify_inner_name)
9297         (c_print_token): Update.
9298         * p-exp.y: Update rules.
9299         (yylex): Update.
9300         * f-exp.y: Update rules.
9301         (yylex): Update.
9302         * d-exp.y: Update rules.
9303         (lex_one_token, classify_name, classify_inner_name): Update.
9304         * parse.c (write_dollar_variable, copy_name): Return std::string.
9305         * parser-defs.h (copy_name): Change return type.
9306         * m2-exp.y: Update rules.
9307         (yylex): Update.
9308         * go-exp.y (lex_one_token): Update.
9309         Update rules.
9310         (classify_unsafe_function, classify_packaged_name)
9311         (classify_name, yylex): Update.
9312
9313 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9314
9315         * configure.ac: add --enable-source-highlight switch.
9316         * configure: Regenerate.
9317         * top.c (print_gdb_version): plumb --enable-source-highlight
9318         status to "show configuration".
9319
9320 2019-04-19  Tom Tromey  <tromey@adacore.com>
9321
9322         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9323         Check ADA_TYPE_P.
9324         (empty_record, ada_template_to_fixed_record_type_1)
9325         (template_to_static_fixed_type)
9326         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9327         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9328         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9329         macros.
9330
9331 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9332
9333         PR symtab/24423:
9334         * source.c (print_source_lines_base): Advance "iter" when a
9335         control character is seen.
9336
9337 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9338
9339         * inferior.h (struct infcall_suspend_state_deleter):
9340         Catch exception in destructor to avoid crash.
9341
9342 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9343
9344         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9345         close to the add_com "shell".
9346
9347 2019-04-18  Tom Tromey  <tromey@adacore.com>
9348
9349         * process-stratum-target.h (class process_stratum_target)
9350         <stratum>: Add "final".
9351
9352 2019-04-17  Tom Tromey  <tromey@adacore.com>
9353
9354         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9355         against nullptr before use.
9356
9357 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9358
9359         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9360
9361 2019-04-17  Jim Wilson  <jimw@sifive.com>
9362             Andrew Burgess  <andrew.burgess@embecosm.com>
9363
9364         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9365         code read might fail, assume 4-byte breakpoint in that case.
9366
9367 2019-04-15  Leszek Swirski  <leszeks@google.com>
9368
9369         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9370         rather than a hand-rolled POD check when checking for forced MEMORY
9371         classification.
9372
9373 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9374
9375         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9376         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9377         function.
9378         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9379         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9380         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9381         declaration.
9382
9383 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9384
9385         * aarch64-linux-nat.c
9386         (aarch64_linux_nat_target::thread_architecture): Add override.
9387         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9388         each VQ.
9389
9390 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9391
9392         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9393
9394 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9397         target types of size 96-bits, add some additional comments, and
9398         check that the builtin type we found was the correct size.
9399
9400 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9401
9402         * utils.c (prompt_for_continue): Don't restore the styling at the
9403         end, as applied_style has the wrong value.  This fixes styling in
9404         long lists of file names that are interrupted by the "Continue?"
9405         prompt.
9406
9407 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9410         * c-lang.c (c_language_defn): Likewise.
9411         (cplus_language_defn): Likewise.
9412         (asm_language_defn): Likewise.
9413         (minimal_language_defn): Likewise.
9414         * d-lang.c (d_language_defn): Likewise.
9415         * f-lang.c (f_language_defn): Likewise.
9416         * go-lang.c (go_language_defn): Likewise.
9417         * language.c (unknown_language_defn): Likewise.
9418         (auto_language_defn): Likewise.
9419         * language.h (struct language_defn): Remove la_magic field.
9420         (LANG_MAGIC): Delete.
9421         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9422         * objc-lang.c (objc_language_defn): Likewise.
9423         * opencl-lang.c (opencl_language_defn): Likewise.
9424         * p-lang.c (pascal_language_defn): Likewise.
9425         * rust-lang.c (rust_language_defn): Likewise.
9426
9427 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * riscv-tdep.c (riscv_type_align): New function.
9430         (riscv_type_alignment): Delete.
9431         (riscv_arg_location): Use 'type_align'.
9432         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9433
9434 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9435
9436         * gdbtypes.c (type_align): A struct with no non-static fields also
9437         has alignment of 1.
9438
9439 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9440
9441         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9442         component to 0.
9443         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9444         member.
9445         (riscv_struct_info::analyse): New implementation using new
9446         analyse_inner member function.
9447         (riscv_struct_info::field_offset): New member function.
9448         (riscv_struct_info::m_offsets): New member variable.
9449         (riscv_struct_info::analyse_inner): New private member function,
9450         takes the old implementation of riscv_struct_info::analyse but
9451         extended to track field offsets.
9452         (riscv_call_arg_struct): Update the struct folding special cases
9453         to handle cases where empty C++ structs, which are non-zero
9454         length, are found.
9455         (riscv_arg_location): Initialise the length of each location, a
9456         non-zero length now indicates the location is in use.
9457         (riscv_push_dummy_call): Allow for the first location having a
9458         non-zero offset when setting up arguments.
9459         (riscv_return_value): Likewise, but for return values.
9460
9461 2019-04-11  Tom Tromey  <tromey@adacore.com>
9462
9463         * utils.c (internal_vproblem): Make "msg" const.
9464
9465 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9466
9467         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9468         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9469         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9470         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9471
9472 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9473
9474         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9475         function.
9476         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9477         of amd64_collect_native_gregset.
9478         (amd64_linux_nat_target::store_registers): Likewise.
9479
9480 2019-04-10  Tom Tromey  <tom@tromey.com>
9481
9482         * symtab.c (lookup_global_symbol_from_objfile)
9483         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9484         * objfiles.h (class separate_debug_iterator): New.
9485         (class separate_debug_range): New.
9486         (struct objfile) <separate_debug_objfiles>: New method.
9487         (objfile_separate_debug_iterate): Don't declare.
9488         * objfiles.c (separate_debug_iterator::operator++): Rename from
9489         objfile_separate_debug_iterate.
9490         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9491         iterator.
9492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9493         iterator.
9494
9495 2019-04-10  Tom Tromey  <tom@tromey.com>
9496
9497         * symfile.c (reread_symbols): Remove old comment.
9498         * objfiles.c (free_all_objfiles): Fix a typo.
9499
9500 2019-04-10  Tom Tromey  <tom@tromey.com>
9501
9502         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9503         * minsyms.c (lookup_minimal_symbol): Use foreach.
9504         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9505         (lookup_minimal_symbol_solib_trampoline): Likewise.
9506         * symfile.c (reread_symbols): Use foreach.
9507
9508 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9509             Tom Tromey  <tromey@adacore.com>
9510
9511         PR rust/24414:
9512         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9513         (rust_lex_int_test): Change "value" to be LONGEST.
9514         (rust_lex_tests): Add test for long integer literal.
9515
9516 2019-04-09  Tom Tromey  <tromey@adacore.com>
9517
9518         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9519         to bool.
9520         (extended_remote_target::attach): Update.
9521         (remote_target::remote_notice_new_inferior): Update.
9522         (remote_target::add_current_inferior_and_thread): Update.
9523         * inferior.c (exit_inferior_1): Use "false".
9524         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9525
9526 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9527
9528         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9529         the "start" command.
9530
9531 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9532
9533         * python/py-inferior.c (infpy_thread_from_thread_handle):
9534         Adjust comments to reflect renaming of thread_from_thread_handle
9535         to thread_from_handle.  Adjust keywords.  Fix type error message.
9536         (inferior_object_methods): Add thread_from_handle.  Retain
9537         thread_from_thread_handle, but mark it as deprecated.
9538
9539 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9540
9541         * gdbthread.h (find_thread_by_handle): Revise declaration.
9542         * thread.c (find_thread_by_handle): Likewise.  Adjust
9543         implementation too.
9544         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9545         support for buffer objects as handles.
9546
9547 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9548
9549         * python/py-infthread.c (thpy_thread_handle): New function.
9550         (thread_object_methods): Register thpy_thread_handle.
9551
9552 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9553
9554         * gdbthread.h (thread_to_thread_handle): Declare.
9555         * thread.c (gdbtypes.h): Include.
9556         (thread_to_thread_handle): New function.
9557
9558         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9559         (target_thread_info_to_thread_handle): Declare.
9560         * target.c (target_thread_info_to_thread_handle): New function.
9561         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9562         * target-delegates.c: Regenerate.
9563
9564         * linux-thread-db.c (class thread_db_target): Add method
9565         thread_info_to_thread_handle.
9566         (thread_db_target::thread_info_to_thread_handle): Define.
9567         * remote.c (class remote_target): Add new method
9568         thread_info_to_thread_handle.
9569         (remote_target::thread_info_to_thread_handle): Define.
9570
9571 2019-04-08  Pedro Alves  <palves@redhat.com>
9572
9573         * common/common-exceptions.c (throw_exception): Don't create
9574         named object to throw; throw directly.
9575         (throw_it): Likewise.  Don't initialize gdb_exception::message
9576         here, with new; pass FMT and AP to the ctor instead.
9577         * common/common-exceptions.h: Include <string>.
9578         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9579         const char *, va_list)): New ctor.  Use std::make_shared.
9580         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9581         errors)): Delete.
9582         (gdb_exception_error::gdb_exception_error(enum errors, const char
9583         *, va_list)): New.
9584         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9585         Add assertion.
9586         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9587         errors)): Delete.
9588         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9589         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9590         Add assertion.
9591
9592 2019-04-08  Tom Tromey  <tom@tromey.com>
9593
9594         * valops.c (value_rtti_indirect_type): Replace throw_exception
9595         with throw.
9596         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9597         with throw.
9598         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9599         throw.
9600         * target.c (target_translate_tls_address): Replace throw_exception
9601         with throw.
9602         * stack.c (frame_apply_command_count): Replace throw_exception
9603         with throw.
9604         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9605         throw.
9606         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9607         with throw.
9608         * rs6000-tdep.c (rs6000_frame_cache)
9609         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9610         * remote.c: Replace throw_exception with throw.
9611         * record-full.c (record_full_message, record_full_wait_1)
9612         (record_full_restore): Replace throw_exception with throw.
9613         * record-btrace.c:
9614         (get_thread_current_frame_id, record_btrace_start_replaying)
9615         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9616         (cmd_record_btrace_start): Replace throw_exception with throw.
9617         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9618         throw.
9619         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9620         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9621         * linespec.c:
9622         (find_linespec_symbols): Replace throw_exception with throw.
9623         * infrun.c (displaced_step_prepare, resume): Replace
9624         throw_exception with throw.
9625         * infcmd.c (post_create_inferior): Replace throw_exception with
9626         throw.
9627         * inf-loop.c (inferior_event_handler): Replace throw_exception
9628         with throw.
9629         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9630         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9631         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9632         (get_prev_frame_always, get_frame_pc_if_available)
9633         (get_frame_address_in_block_if_available, get_frame_language):
9634         Replace throw_exception with throw.
9635         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9636         throw_exception with throw.
9637         * eval.c (fetch_subexp_value, evaluate_var_value)
9638         (evaluate_funcall, evaluate_subexp_standard): Replace
9639         throw_exception with throw.
9640         * dwarf2loc.c (call_site_find_chain)
9641         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9642         Replace throw_exception with throw.
9643         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9644         with throw.
9645         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9646         throw.
9647         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9648         * completer.c (complete_line_internal): Replace throw_exception
9649         with throw.
9650         * compile/compile-object-run.c (compile_object_run): Replace
9651         throw_exception with throw.
9652         * cli/cli-script.c (process_next_line): Replace throw_exception
9653         with throw.
9654         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9655         (btrace_enable, btrace_maint_update_pt_packets): Replace
9656         throw_exception with throw.
9657         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9658         throw_exception with throw.
9659         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9660         throw_exception with throw.
9661         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9662         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9663         * aarch64-tdep.c (aarch64_make_prologue_cache)
9664         (aarch64_make_stub_cache): Replace throw_exception with throw.
9665
9666 2019-04-08  Tom Tromey  <tom@tromey.com>
9667
9668         * common/common-exceptions.c (throw_exception): Rename from
9669         throw_exception_cxx.  Remove old copy.  Make argument const.
9670         (throw_it): Create and throw exception objects directly.
9671         * common/common-exceptions.h (throw_exception): Make argument
9672         const.
9673         (struct gdb_exception_error): Add constructor.
9674         (struct gdb_exception_quit): Add constructor.
9675
9676 2019-04-08  Tom Tromey  <tom@tromey.com>
9677
9678         * common/common-exceptions.h (exception_rethrow): Don't declare.
9679         (TRY_SJLJ): Update comment.
9680         (TRY, CATCH, END_CATCH): Remove.
9681         * common/common-exceptions.c (exception_rethrow): Remove.
9682
9683 2019-04-08  Tom Tromey  <tom@tromey.com>
9684
9685         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9686         Remove.
9687         (gdb_exception_error): Rename from
9688         gdb_exception_RETURN_MASK_ERROR.
9689         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9690         (gdb_quit_bad_alloc): Update.
9691         * aarch64-tdep.c: Update.
9692         * ada-lang.c: Update.
9693         * ada-typeprint.c: Update.
9694         * ada-valprint.c: Update.
9695         * amd64-tdep.c: Update.
9696         * arch-utils.c: Update.
9697         * break-catch-throw.c: Update.
9698         * breakpoint.c: Update.
9699         * btrace.c: Update.
9700         * c-varobj.c: Update.
9701         * cli/cli-cmds.c: Update.
9702         * cli/cli-interp.c: Update.
9703         * cli/cli-script.c: Update.
9704         * common/common-exceptions.c: Update.
9705         * common/new-op.c: Update.
9706         * common/selftest.c: Update.
9707         * compile/compile-c-symbols.c: Update.
9708         * compile/compile-cplus-symbols.c: Update.
9709         * compile/compile-object-load.c: Update.
9710         * compile/compile-object-run.c: Update.
9711         * completer.c: Update.
9712         * corelow.c: Update.
9713         * cp-abi.c: Update.
9714         * cp-support.c: Update.
9715         * cp-valprint.c: Update.
9716         * darwin-nat.c: Update.
9717         * disasm-selftests.c: Update.
9718         * dtrace-probe.c: Update.
9719         * dwarf-index-cache.c: Update.
9720         * dwarf-index-write.c: Update.
9721         * dwarf2-frame-tailcall.c: Update.
9722         * dwarf2-frame.c: Update.
9723         * dwarf2loc.c: Update.
9724         * dwarf2read.c: Update.
9725         * eval.c: Update.
9726         * event-loop.c: Update.
9727         * event-top.c: Update.
9728         * exec.c: Update.
9729         * f-valprint.c: Update.
9730         * fbsd-tdep.c: Update.
9731         * frame-unwind.c: Update.
9732         * frame.c: Update.
9733         * gdbtypes.c: Update.
9734         * gnu-v3-abi.c: Update.
9735         * guile/guile-internal.h: Update.
9736         * guile/scm-block.c: Update.
9737         * guile/scm-breakpoint.c: Update.
9738         * guile/scm-cmd.c: Update.
9739         * guile/scm-disasm.c: Update.
9740         * guile/scm-frame.c: Update.
9741         * guile/scm-lazy-string.c: Update.
9742         * guile/scm-math.c: Update.
9743         * guile/scm-param.c: Update.
9744         * guile/scm-ports.c: Update.
9745         * guile/scm-pretty-print.c: Update.
9746         * guile/scm-symbol.c: Update.
9747         * guile/scm-symtab.c: Update.
9748         * guile/scm-type.c: Update.
9749         * guile/scm-value.c: Update.
9750         * i386-linux-tdep.c: Update.
9751         * i386-tdep.c: Update.
9752         * inf-loop.c: Update.
9753         * infcall.c: Update.
9754         * infcmd.c: Update.
9755         * infrun.c: Update.
9756         * jit.c: Update.
9757         * language.c: Update.
9758         * linespec.c: Update.
9759         * linux-fork.c: Update.
9760         * linux-nat.c: Update.
9761         * linux-tdep.c: Update.
9762         * linux-thread-db.c: Update.
9763         * main.c: Update.
9764         * mi/mi-cmd-break.c: Update.
9765         * mi/mi-cmd-stack.c: Update.
9766         * mi/mi-interp.c: Update.
9767         * mi/mi-main.c: Update.
9768         * objc-lang.c: Update.
9769         * p-valprint.c: Update.
9770         * parse.c: Update.
9771         * ppc-linux-tdep.c: Update.
9772         * printcmd.c: Update.
9773         * python/py-arch.c: Update.
9774         * python/py-breakpoint.c: Update.
9775         * python/py-cmd.c: Update.
9776         * python/py-finishbreakpoint.c: Update.
9777         * python/py-frame.c: Update.
9778         * python/py-framefilter.c: Update.
9779         * python/py-gdb-readline.c: Update.
9780         * python/py-inferior.c: Update.
9781         * python/py-infthread.c: Update.
9782         * python/py-lazy-string.c: Update.
9783         * python/py-linetable.c: Update.
9784         * python/py-objfile.c: Update.
9785         * python/py-param.c: Update.
9786         * python/py-prettyprint.c: Update.
9787         * python/py-progspace.c: Update.
9788         * python/py-record-btrace.c: Update.
9789         * python/py-record.c: Update.
9790         * python/py-symbol.c: Update.
9791         * python/py-type.c: Update.
9792         * python/py-unwind.c: Update.
9793         * python/py-utils.c: Update.
9794         * python/py-value.c: Update.
9795         * python/python.c: Update.
9796         * record-btrace.c: Update.
9797         * record-full.c: Update.
9798         * remote-fileio.c: Update.
9799         * remote.c: Update.
9800         * riscv-tdep.c: Update.
9801         * rs6000-aix-tdep.c: Update.
9802         * rs6000-tdep.c: Update.
9803         * rust-exp.y: Update.
9804         * rust-lang.c: Update.
9805         * s390-tdep.c: Update.
9806         * selftest-arch.c: Update.
9807         * solib-dsbt.c: Update.
9808         * solib-frv.c: Update.
9809         * solib-spu.c: Update.
9810         * solib-svr4.c: Update.
9811         * solib.c: Update.
9812         * sparc64-linux-tdep.c: Update.
9813         * stack.c: Update.
9814         * symfile-mem.c: Update.
9815         * symmisc.c: Update.
9816         * target.c: Update.
9817         * thread.c: Update.
9818         * top.c: Update.
9819         * tracefile-tfile.c: Update.
9820         * tui/tui.c: Update.
9821         * typeprint.c: Update.
9822         * unittests/cli-utils-selftests.c: Update.
9823         * unittests/parse-connection-spec-selftests.c: Update.
9824         * valops.c: Update.
9825         * valprint.c: Update.
9826         * value.c: Update.
9827         * varobj.c: Update.
9828         * windows-nat.c: Update.
9829         * x86-linux-nat.c: Update.
9830         * xml-support.c: Update.
9831
9832 2019-04-08  Tom Tromey  <tom@tromey.com>
9833
9834         * xml-support.c: Use C++ exception handling.
9835         * x86-linux-nat.c: Use C++ exception handling.
9836         * windows-nat.c: Use C++ exception handling.
9837         * varobj.c: Use C++ exception handling.
9838         * value.c: Use C++ exception handling.
9839         * valprint.c: Use C++ exception handling.
9840         * valops.c: Use C++ exception handling.
9841         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9842         handling.
9843         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9844         * typeprint.c: Use C++ exception handling.
9845         * tui/tui.c: Use C++ exception handling.
9846         * tracefile-tfile.c: Use C++ exception handling.
9847         * top.c: Use C++ exception handling.
9848         * thread.c: Use C++ exception handling.
9849         * target.c: Use C++ exception handling.
9850         * symmisc.c: Use C++ exception handling.
9851         * symfile-mem.c: Use C++ exception handling.
9852         * stack.c: Use C++ exception handling.
9853         * sparc64-linux-tdep.c: Use C++ exception handling.
9854         * solib.c: Use C++ exception handling.
9855         * solib-svr4.c: Use C++ exception handling.
9856         * solib-spu.c: Use C++ exception handling.
9857         * solib-frv.c: Use C++ exception handling.
9858         * solib-dsbt.c: Use C++ exception handling.
9859         * selftest-arch.c: Use C++ exception handling.
9860         * s390-tdep.c: Use C++ exception handling.
9861         * rust-lang.c: Use C++ exception handling.
9862         * rust-exp.y: Use C++ exception handling.
9863         * rs6000-tdep.c: Use C++ exception handling.
9864         * rs6000-aix-tdep.c: Use C++ exception handling.
9865         * riscv-tdep.c: Use C++ exception handling.
9866         * remote.c: Use C++ exception handling.
9867         * remote-fileio.c: Use C++ exception handling.
9868         * record-full.c: Use C++ exception handling.
9869         * record-btrace.c: Use C++ exception handling.
9870         * python/python.c: Use C++ exception handling.
9871         * python/py-value.c: Use C++ exception handling.
9872         * python/py-utils.c: Use C++ exception handling.
9873         * python/py-unwind.c: Use C++ exception handling.
9874         * python/py-type.c: Use C++ exception handling.
9875         * python/py-symbol.c: Use C++ exception handling.
9876         * python/py-record.c: Use C++ exception handling.
9877         * python/py-record-btrace.c: Use C++ exception handling.
9878         * python/py-progspace.c: Use C++ exception handling.
9879         * python/py-prettyprint.c: Use C++ exception handling.
9880         * python/py-param.c: Use C++ exception handling.
9881         * python/py-objfile.c: Use C++ exception handling.
9882         * python/py-linetable.c: Use C++ exception handling.
9883         * python/py-lazy-string.c: Use C++ exception handling.
9884         * python/py-infthread.c: Use C++ exception handling.
9885         * python/py-inferior.c: Use C++ exception handling.
9886         * python/py-gdb-readline.c: Use C++ exception handling.
9887         * python/py-framefilter.c: Use C++ exception handling.
9888         * python/py-frame.c: Use C++ exception handling.
9889         * python/py-finishbreakpoint.c: Use C++ exception handling.
9890         * python/py-cmd.c: Use C++ exception handling.
9891         * python/py-breakpoint.c: Use C++ exception handling.
9892         * python/py-arch.c: Use C++ exception handling.
9893         * printcmd.c: Use C++ exception handling.
9894         * ppc-linux-tdep.c: Use C++ exception handling.
9895         * parse.c: Use C++ exception handling.
9896         * p-valprint.c: Use C++ exception handling.
9897         * objc-lang.c: Use C++ exception handling.
9898         * mi/mi-main.c: Use C++ exception handling.
9899         * mi/mi-interp.c: Use C++ exception handling.
9900         * mi/mi-cmd-stack.c: Use C++ exception handling.
9901         * mi/mi-cmd-break.c: Use C++ exception handling.
9902         * main.c: Use C++ exception handling.
9903         * linux-thread-db.c: Use C++ exception handling.
9904         * linux-tdep.c: Use C++ exception handling.
9905         * linux-nat.c: Use C++ exception handling.
9906         * linux-fork.c: Use C++ exception handling.
9907         * linespec.c: Use C++ exception handling.
9908         * language.c: Use C++ exception handling.
9909         * jit.c: Use C++ exception handling.
9910         * infrun.c: Use C++ exception handling.
9911         * infcmd.c: Use C++ exception handling.
9912         * infcall.c: Use C++ exception handling.
9913         * inf-loop.c: Use C++ exception handling.
9914         * i386-tdep.c: Use C++ exception handling.
9915         * i386-linux-tdep.c: Use C++ exception handling.
9916         * guile/scm-value.c: Use C++ exception handling.
9917         * guile/scm-type.c: Use C++ exception handling.
9918         * guile/scm-symtab.c: Use C++ exception handling.
9919         * guile/scm-symbol.c: Use C++ exception handling.
9920         * guile/scm-pretty-print.c: Use C++ exception handling.
9921         * guile/scm-ports.c: Use C++ exception handling.
9922         * guile/scm-param.c: Use C++ exception handling.
9923         * guile/scm-math.c: Use C++ exception handling.
9924         * guile/scm-lazy-string.c: Use C++ exception handling.
9925         * guile/scm-frame.c: Use C++ exception handling.
9926         * guile/scm-disasm.c: Use C++ exception handling.
9927         * guile/scm-cmd.c: Use C++ exception handling.
9928         * guile/scm-breakpoint.c: Use C++ exception handling.
9929         * guile/scm-block.c: Use C++ exception handling.
9930         * guile/guile-internal.h: Use C++ exception handling.
9931         * gnu-v3-abi.c: Use C++ exception handling.
9932         * gdbtypes.c: Use C++ exception handling.
9933         * frame.c: Use C++ exception handling.
9934         * frame-unwind.c: Use C++ exception handling.
9935         * fbsd-tdep.c: Use C++ exception handling.
9936         * f-valprint.c: Use C++ exception handling.
9937         * exec.c: Use C++ exception handling.
9938         * event-top.c: Use C++ exception handling.
9939         * event-loop.c: Use C++ exception handling.
9940         * eval.c: Use C++ exception handling.
9941         * dwarf2read.c: Use C++ exception handling.
9942         * dwarf2loc.c: Use C++ exception handling.
9943         * dwarf2-frame.c: Use C++ exception handling.
9944         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9945         * dwarf-index-write.c: Use C++ exception handling.
9946         * dwarf-index-cache.c: Use C++ exception handling.
9947         * dtrace-probe.c: Use C++ exception handling.
9948         * disasm-selftests.c: Use C++ exception handling.
9949         * darwin-nat.c: Use C++ exception handling.
9950         * cp-valprint.c: Use C++ exception handling.
9951         * cp-support.c: Use C++ exception handling.
9952         * cp-abi.c: Use C++ exception handling.
9953         * corelow.c: Use C++ exception handling.
9954         * completer.c: Use C++ exception handling.
9955         * compile/compile-object-run.c: Use C++ exception handling.
9956         * compile/compile-object-load.c: Use C++ exception handling.
9957         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9958         * compile/compile-c-symbols.c: Use C++ exception handling.
9959         * common/selftest.c: Use C++ exception handling.
9960         * common/new-op.c: Use C++ exception handling.
9961         * cli/cli-script.c: Use C++ exception handling.
9962         * cli/cli-interp.c: Use C++ exception handling.
9963         * cli/cli-cmds.c: Use C++ exception handling.
9964         * c-varobj.c: Use C++ exception handling.
9965         * btrace.c: Use C++ exception handling.
9966         * breakpoint.c: Use C++ exception handling.
9967         * break-catch-throw.c: Use C++ exception handling.
9968         * arch-utils.c: Use C++ exception handling.
9969         * amd64-tdep.c: Use C++ exception handling.
9970         * ada-valprint.c: Use C++ exception handling.
9971         * ada-typeprint.c: Use C++ exception handling.
9972         * ada-lang.c: Use C++ exception handling.
9973         * aarch64-tdep.c: Use C++ exception handling.
9974
9975 2019-04-08  Tom Tromey  <tom@tromey.com>
9976
9977         * xml-support.c (gdb_xml_parser::parse): Update.
9978         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9979         * value.c (show_convenience): Update.
9980         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9981         (test_parse_flags_qcs): Update.
9982         * thread.c (thr_try_catch_cmd): Update.
9983         * target.c (target_translate_tls_address): Update.
9984         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9985         (info_frame_command_core, frame_apply_command_count): Update.
9986         * rust-exp.y (rust_lex_exception_test): Update.
9987         * riscv-tdep.c (riscv_print_one_register_info): Update.
9988         * remote.c (remote_target::enable_btrace): Update.
9989         * record-btrace.c (record_btrace_enable_warn): Update.
9990         * python/py-utils.c (gdbpy_convert_exception): Update.
9991         * printcmd.c (do_one_display, print_variable_and_value): Update.
9992         * mi/mi-main.c (mi_print_exception): Update.
9993         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9994         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9995         * linux-nat.c (linux_nat_target::attach): Update.
9996         * linux-fork.c (class scoped_switch_fork_info): Update.
9997         * infrun.c (displaced_step_prepare): Update.
9998         * infcall.c (call_function_by_hand_dummy): Update.
9999         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10000         * gnu-v3-abi.c (print_one_vtable): Update.
10001         * frame.c (get_prev_frame_always): Update.
10002         * f-valprint.c (info_common_command_for_block): Update.
10003         * exec.c (try_open_exec_file): Update.
10004         * exceptions.c (print_exception, exception_print)
10005         (exception_fprintf, exception_print_same): Update.
10006         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10007         * dwarf-index-cache.c (index_cache::store)
10008         (index_cache::lookup_gdb_index): Update.
10009         * darwin-nat.c (maybe_cache_shell): Update.
10010         * cp-valprint.c (cp_print_value_fields): Update.
10011         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10012         (gcc_cplus_symbol_address): Update.
10013         * compile/compile-c-symbols.c (gcc_convert_symbol)
10014         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10015         * common/selftest.c: Update.
10016         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10017         a std::string.
10018         (exception_try_scope_entry, exception_try_scope_exit): Don't
10019         declare.
10020         (struct exception_try_scope): Remove.
10021         (TRY): Don't use exception_try_scope.
10022         (struct gdb_exception): Add constructor, operator=.
10023         <what>: New method.
10024         (struct gdb_exception_RETURN_MASK_ALL)
10025         (struct gdb_exception_RETURN_MASK_ERROR)
10026         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10027         (struct gdb_quit_bad_alloc): Update.
10028         * common/common-exceptions.c (exception_none): Change
10029         initializer.
10030         (struct catcher) <state, exception>: Initialize inline.
10031         <prev>: Remove member.
10032         (current_catcher): Remove.
10033         (catchers): New global.
10034         (exceptions_state_mc_init): Simplify.
10035         (catcher_pop): Remove.
10036         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10037         (try_scope_depth, exception_try_scope_entry)
10038         (exception_try_scope_exit): Remove.
10039         (throw_exception_sjlj): Update.
10040         (exception_messages, exception_messages_size): Remove.
10041         (throw_it): Simplify.
10042         (gdb_exception_sliced_copy): Remove.
10043         (throw_exception_cxx): Update.
10044         * cli/cli-script.c (script_from_file): Update.
10045         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10046         Update.
10047         * ada-valprint.c (ada_val_print): Update.
10048         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10049         (create_excep_cond_exprs): Update.
10050
10051 2019-04-08  Tom Tromey  <tom@tromey.com>
10052
10053         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10054         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10055         (TRY, CATCH, END_CATCH): Remove some definitions.
10056         * common/common-exceptions.c: Don't use GDB_XCPT.
10057         (catcher_list_size): Remove.
10058         (throw_exception, throw_it): Simplify.
10059
10060 2019-04-05  Tom Tromey  <tom@tromey.com>
10061
10062         Revert the header-sorting patch.
10063         * ft32-tdep.c: Revert.
10064         * frv-tdep.c: Revert.
10065         * frv-linux-tdep.c: Revert.
10066         * frame.c: Revert.
10067         * frame-unwind.c: Revert.
10068         * frame-base.c: Revert.
10069         * fork-child.c: Revert.
10070         * findvar.c: Revert.
10071         * findcmd.c: Revert.
10072         * filesystem.c: Revert.
10073         * filename-seen-cache.h: Revert.
10074         * filename-seen-cache.c: Revert.
10075         * fbsd-tdep.c: Revert.
10076         * fbsd-nat.h: Revert.
10077         * fbsd-nat.c: Revert.
10078         * f-valprint.c: Revert.
10079         * f-typeprint.c: Revert.
10080         * f-lang.c: Revert.
10081         * extension.h: Revert.
10082         * extension.c: Revert.
10083         * extension-priv.h: Revert.
10084         * expprint.c: Revert.
10085         * exec.h: Revert.
10086         * exec.c: Revert.
10087         * exceptions.c: Revert.
10088         * event-top.c: Revert.
10089         * event-loop.c: Revert.
10090         * eval.c: Revert.
10091         * elfread.c: Revert.
10092         * dwarf2read.h: Revert.
10093         * dwarf2read.c: Revert.
10094         * dwarf2loc.c: Revert.
10095         * dwarf2expr.h: Revert.
10096         * dwarf2expr.c: Revert.
10097         * dwarf2-frame.c: Revert.
10098         * dwarf2-frame-tailcall.c: Revert.
10099         * dwarf-index-write.h: Revert.
10100         * dwarf-index-write.c: Revert.
10101         * dwarf-index-common.c: Revert.
10102         * dwarf-index-cache.h: Revert.
10103         * dwarf-index-cache.c: Revert.
10104         * dummy-frame.c: Revert.
10105         * dtrace-probe.c: Revert.
10106         * disasm.h: Revert.
10107         * disasm.c: Revert.
10108         * disasm-selftests.c: Revert.
10109         * dictionary.c: Revert.
10110         * dicos-tdep.c: Revert.
10111         * demangle.c: Revert.
10112         * dcache.h: Revert.
10113         * dcache.c: Revert.
10114         * darwin-nat.h: Revert.
10115         * darwin-nat.c: Revert.
10116         * darwin-nat-info.c: Revert.
10117         * d-valprint.c: Revert.
10118         * d-namespace.c: Revert.
10119         * d-lang.c: Revert.
10120         * ctf.c: Revert.
10121         * csky-tdep.c: Revert.
10122         * csky-linux-tdep.c: Revert.
10123         * cris-tdep.c: Revert.
10124         * cris-linux-tdep.c: Revert.
10125         * cp-valprint.c: Revert.
10126         * cp-support.c: Revert.
10127         * cp-namespace.c: Revert.
10128         * cp-abi.c: Revert.
10129         * corelow.c: Revert.
10130         * corefile.c: Revert.
10131         * continuations.c: Revert.
10132         * completer.h: Revert.
10133         * completer.c: Revert.
10134         * complaints.c: Revert.
10135         * coffread.c: Revert.
10136         * coff-pe-read.c: Revert.
10137         * cli-out.h: Revert.
10138         * cli-out.c: Revert.
10139         * charset.c: Revert.
10140         * c-varobj.c: Revert.
10141         * c-valprint.c: Revert.
10142         * c-typeprint.c: Revert.
10143         * c-lang.c: Revert.
10144         * buildsym.c: Revert.
10145         * buildsym-legacy.c: Revert.
10146         * build-id.h: Revert.
10147         * build-id.c: Revert.
10148         * btrace.c: Revert.
10149         * bsd-uthread.c: Revert.
10150         * breakpoint.h: Revert.
10151         * breakpoint.c: Revert.
10152         * break-catch-throw.c: Revert.
10153         * break-catch-syscall.c: Revert.
10154         * break-catch-sig.c: Revert.
10155         * blockframe.c: Revert.
10156         * block.c: Revert.
10157         * bfin-tdep.c: Revert.
10158         * bfin-linux-tdep.c: Revert.
10159         * bfd-target.c: Revert.
10160         * bcache.c: Revert.
10161         * ax-general.c: Revert.
10162         * ax-gdb.h: Revert.
10163         * ax-gdb.c: Revert.
10164         * avr-tdep.c: Revert.
10165         * auxv.c: Revert.
10166         * auto-load.c: Revert.
10167         * arm-wince-tdep.c: Revert.
10168         * arm-tdep.c: Revert.
10169         * arm-symbian-tdep.c: Revert.
10170         * arm-pikeos-tdep.c: Revert.
10171         * arm-obsd-tdep.c: Revert.
10172         * arm-nbsd-tdep.c: Revert.
10173         * arm-nbsd-nat.c: Revert.
10174         * arm-linux-tdep.c: Revert.
10175         * arm-linux-nat.c: Revert.
10176         * arm-fbsd-tdep.c: Revert.
10177         * arm-fbsd-nat.c: Revert.
10178         * arm-bsd-tdep.c: Revert.
10179         * arch-utils.c: Revert.
10180         * arc-tdep.c: Revert.
10181         * arc-newlib-tdep.c: Revert.
10182         * annotate.h: Revert.
10183         * annotate.c: Revert.
10184         * amd64-windows-tdep.c: Revert.
10185         * amd64-windows-nat.c: Revert.
10186         * amd64-tdep.c: Revert.
10187         * amd64-sol2-tdep.c: Revert.
10188         * amd64-obsd-tdep.c: Revert.
10189         * amd64-obsd-nat.c: Revert.
10190         * amd64-nbsd-tdep.c: Revert.
10191         * amd64-nbsd-nat.c: Revert.
10192         * amd64-nat.c: Revert.
10193         * amd64-linux-tdep.c: Revert.
10194         * amd64-linux-nat.c: Revert.
10195         * amd64-fbsd-tdep.c: Revert.
10196         * amd64-fbsd-nat.c: Revert.
10197         * amd64-dicos-tdep.c: Revert.
10198         * amd64-darwin-tdep.c: Revert.
10199         * amd64-bsd-nat.c: Revert.
10200         * alpha-tdep.c: Revert.
10201         * alpha-obsd-tdep.c: Revert.
10202         * alpha-nbsd-tdep.c: Revert.
10203         * alpha-mdebug-tdep.c: Revert.
10204         * alpha-linux-tdep.c: Revert.
10205         * alpha-linux-nat.c: Revert.
10206         * alpha-bsd-tdep.c: Revert.
10207         * alpha-bsd-nat.c: Revert.
10208         * aix-thread.c: Revert.
10209         * agent.c: Revert.
10210         * addrmap.c: Revert.
10211         * ada-varobj.c: Revert.
10212         * ada-valprint.c: Revert.
10213         * ada-typeprint.c: Revert.
10214         * ada-tasks.c: Revert.
10215         * ada-lang.c: Revert.
10216         * aarch64-tdep.c: Revert.
10217         * aarch64-ravenscar-thread.c: Revert.
10218         * aarch64-newlib-tdep.c: Revert.
10219         * aarch64-linux-tdep.c: Revert.
10220         * aarch64-linux-nat.c: Revert.
10221         * aarch64-fbsd-tdep.c: Revert.
10222         * aarch64-fbsd-nat.c: Revert.
10223         * aarch32-linux-nat.c: Revert.
10224
10225 2019-04-05  Tom Tromey  <tom@tromey.com>
10226
10227         * ft32-tdep.c: Sort headers.
10228         * frv-tdep.c: Sort headers.
10229         * frv-linux-tdep.c: Sort headers.
10230         * frame.c: Sort headers.
10231         * frame-unwind.c: Sort headers.
10232         * frame-base.c: Sort headers.
10233         * fork-child.c: Sort headers.
10234         * findvar.c: Sort headers.
10235         * findcmd.c: Sort headers.
10236         * filesystem.c: Sort headers.
10237         * filename-seen-cache.h: Sort headers.
10238         * filename-seen-cache.c: Sort headers.
10239         * fbsd-tdep.c: Sort headers.
10240         * fbsd-nat.h: Sort headers.
10241         * fbsd-nat.c: Sort headers.
10242         * f-valprint.c: Sort headers.
10243         * f-typeprint.c: Sort headers.
10244         * f-lang.c: Sort headers.
10245         * extension.h: Sort headers.
10246         * extension.c: Sort headers.
10247         * extension-priv.h: Sort headers.
10248         * expprint.c: Sort headers.
10249         * exec.h: Sort headers.
10250         * exec.c: Sort headers.
10251         * exceptions.c: Sort headers.
10252         * event-top.c: Sort headers.
10253         * event-loop.c: Sort headers.
10254         * eval.c: Sort headers.
10255         * elfread.c: Sort headers.
10256         * dwarf2read.h: Sort headers.
10257         * dwarf2read.c: Sort headers.
10258         * dwarf2loc.c: Sort headers.
10259         * dwarf2expr.h: Sort headers.
10260         * dwarf2expr.c: Sort headers.
10261         * dwarf2-frame.c: Sort headers.
10262         * dwarf2-frame-tailcall.c: Sort headers.
10263         * dwarf-index-write.h: Sort headers.
10264         * dwarf-index-write.c: Sort headers.
10265         * dwarf-index-common.c: Sort headers.
10266         * dwarf-index-cache.h: Sort headers.
10267         * dwarf-index-cache.c: Sort headers.
10268         * dummy-frame.c: Sort headers.
10269         * dtrace-probe.c: Sort headers.
10270         * disasm.h: Sort headers.
10271         * disasm.c: Sort headers.
10272         * disasm-selftests.c: Sort headers.
10273         * dictionary.c: Sort headers.
10274         * dicos-tdep.c: Sort headers.
10275         * demangle.c: Sort headers.
10276         * dcache.h: Sort headers.
10277         * dcache.c: Sort headers.
10278         * darwin-nat.h: Sort headers.
10279         * darwin-nat.c: Sort headers.
10280         * darwin-nat-info.c: Sort headers.
10281         * d-valprint.c: Sort headers.
10282         * d-namespace.c: Sort headers.
10283         * d-lang.c: Sort headers.
10284         * ctf.c: Sort headers.
10285         * csky-tdep.c: Sort headers.
10286         * csky-linux-tdep.c: Sort headers.
10287         * cris-tdep.c: Sort headers.
10288         * cris-linux-tdep.c: Sort headers.
10289         * cp-valprint.c: Sort headers.
10290         * cp-support.c: Sort headers.
10291         * cp-namespace.c: Sort headers.
10292         * cp-abi.c: Sort headers.
10293         * corelow.c: Sort headers.
10294         * corefile.c: Sort headers.
10295         * continuations.c: Sort headers.
10296         * completer.h: Sort headers.
10297         * completer.c: Sort headers.
10298         * complaints.c: Sort headers.
10299         * coffread.c: Sort headers.
10300         * coff-pe-read.c: Sort headers.
10301         * cli-out.h: Sort headers.
10302         * cli-out.c: Sort headers.
10303         * charset.c: Sort headers.
10304         * c-varobj.c: Sort headers.
10305         * c-valprint.c: Sort headers.
10306         * c-typeprint.c: Sort headers.
10307         * c-lang.c: Sort headers.
10308         * buildsym.c: Sort headers.
10309         * buildsym-legacy.c: Sort headers.
10310         * build-id.h: Sort headers.
10311         * build-id.c: Sort headers.
10312         * btrace.c: Sort headers.
10313         * bsd-uthread.c: Sort headers.
10314         * breakpoint.h: Sort headers.
10315         * breakpoint.c: Sort headers.
10316         * break-catch-throw.c: Sort headers.
10317         * break-catch-syscall.c: Sort headers.
10318         * break-catch-sig.c: Sort headers.
10319         * blockframe.c: Sort headers.
10320         * block.c: Sort headers.
10321         * bfin-tdep.c: Sort headers.
10322         * bfin-linux-tdep.c: Sort headers.
10323         * bfd-target.c: Sort headers.
10324         * bcache.c: Sort headers.
10325         * ax-general.c: Sort headers.
10326         * ax-gdb.h: Sort headers.
10327         * ax-gdb.c: Sort headers.
10328         * avr-tdep.c: Sort headers.
10329         * auxv.c: Sort headers.
10330         * auto-load.c: Sort headers.
10331         * arm-wince-tdep.c: Sort headers.
10332         * arm-tdep.c: Sort headers.
10333         * arm-symbian-tdep.c: Sort headers.
10334         * arm-pikeos-tdep.c: Sort headers.
10335         * arm-obsd-tdep.c: Sort headers.
10336         * arm-nbsd-tdep.c: Sort headers.
10337         * arm-nbsd-nat.c: Sort headers.
10338         * arm-linux-tdep.c: Sort headers.
10339         * arm-linux-nat.c: Sort headers.
10340         * arm-fbsd-tdep.c: Sort headers.
10341         * arm-fbsd-nat.c: Sort headers.
10342         * arm-bsd-tdep.c: Sort headers.
10343         * arch-utils.c: Sort headers.
10344         * arc-tdep.c: Sort headers.
10345         * arc-newlib-tdep.c: Sort headers.
10346         * annotate.h: Sort headers.
10347         * annotate.c: Sort headers.
10348         * amd64-windows-tdep.c: Sort headers.
10349         * amd64-windows-nat.c: Sort headers.
10350         * amd64-tdep.c: Sort headers.
10351         * amd64-sol2-tdep.c: Sort headers.
10352         * amd64-obsd-tdep.c: Sort headers.
10353         * amd64-obsd-nat.c: Sort headers.
10354         * amd64-nbsd-tdep.c: Sort headers.
10355         * amd64-nbsd-nat.c: Sort headers.
10356         * amd64-nat.c: Sort headers.
10357         * amd64-linux-tdep.c: Sort headers.
10358         * amd64-linux-nat.c: Sort headers.
10359         * amd64-fbsd-tdep.c: Sort headers.
10360         * amd64-fbsd-nat.c: Sort headers.
10361         * amd64-dicos-tdep.c: Sort headers.
10362         * amd64-darwin-tdep.c: Sort headers.
10363         * amd64-bsd-nat.c: Sort headers.
10364         * alpha-tdep.c: Sort headers.
10365         * alpha-obsd-tdep.c: Sort headers.
10366         * alpha-nbsd-tdep.c: Sort headers.
10367         * alpha-mdebug-tdep.c: Sort headers.
10368         * alpha-linux-tdep.c: Sort headers.
10369         * alpha-linux-nat.c: Sort headers.
10370         * alpha-bsd-tdep.c: Sort headers.
10371         * alpha-bsd-nat.c: Sort headers.
10372         * aix-thread.c: Sort headers.
10373         * agent.c: Sort headers.
10374         * addrmap.c: Sort headers.
10375         * ada-varobj.c: Sort headers.
10376         * ada-valprint.c: Sort headers.
10377         * ada-typeprint.c: Sort headers.
10378         * ada-tasks.c: Sort headers.
10379         * ada-lang.c: Sort headers.
10380         * aarch64-tdep.c: Sort headers.
10381         * aarch64-ravenscar-thread.c: Sort headers.
10382         * aarch64-newlib-tdep.c: Sort headers.
10383         * aarch64-linux-tdep.c: Sort headers.
10384         * aarch64-linux-nat.c: Sort headers.
10385         * aarch64-fbsd-tdep.c: Sort headers.
10386         * aarch64-fbsd-nat.c: Sort headers.
10387         * aarch32-linux-nat.c: Sort headers.
10388
10389 2019-04-04  Tom Tromey  <tom@tromey.com>
10390
10391         * varobj.c (varobj_create): Update.
10392         * rust-exp.y (struct rust_parser) <update_innermost_block,
10393         lookup_symbol>: New methods.
10394         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10395         Rename.
10396         (rust_parser::rust_lookup_type)
10397         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10398         * printcmd.c (display_command, do_one_display): Update.
10399         * parser-defs.h (struct parser_state) <parser_state>: Add
10400         "tracker" parameter.
10401         (block_tracker): New member.
10402         (class innermost_block_tracker) <innermost_block_tracker>: Add
10403         "types" parameter.
10404         <reset>: Remove method.
10405         (innermost_block): Don't declare.
10406         (null_post_parser): Update.
10407         * parse.c (innermost_block): Remove global.
10408         (write_dollar_variable): Update.
10409         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10410         Remove "tracker_types" parameter.
10411         (parse_expression): Add "tracker" parameter.
10412         (parse_expression_for_completion): Update.
10413         (null_post_parser): Add "tracker" parameter.
10414         * p-exp.y: Update rules.
10415         * m2-exp.y: Update rules.
10416         * language.h (struct language_defn) <la_post_parser>: Add
10417         "tracker" parameter.
10418         * go-exp.y: Update rules.
10419         * f-exp.y: Update rules.
10420         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10421         parameter.
10422         * d-exp.y: Update rules.
10423         * c-exp.y: Update rules.
10424         * breakpoint.c (set_breakpoint_condition): Create an
10425         innermost_block_tracker.
10426         (watch_command_1): Likewise.
10427         * ada-lang.c (resolve): Add "tracker" parameter.
10428         (resolve_subexp): Likewise.
10429         * ada-exp.y (write_var_from_sym): Update.
10430
10431 2019-04-04  Tom Tromey  <tom@tromey.com>
10432
10433         * type-stack.h: New file.
10434         * type-stack.c: New file.
10435         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10436         type-stack.h.
10437         (insert_into_type_stack, insert_type, push_type, push_type_int)
10438         (insert_type_address_space, pop_type, pop_type_int)
10439         (pop_typelist, pop_type_stack, append_type_stack)
10440         (push_type_stack, get_type_stack, push_typelist)
10441         (follow_type_instance_flags, follow_types): Don't declare.
10442         * parse.c (type_stack): Remove global.
10443         (parse_exp_in_context): Update.
10444         (insert_into_type_stack, insert_type, push_type, push_type_int)
10445         (insert_type_address_space, pop_type, pop_type_int)
10446         (pop_typelist, pop_type_stack, append_type_stack)
10447         (push_type_stack, get_type_stack, push_typelist)
10448         (follow_type_instance_flags, follow_types): Remove (moved to
10449         type-stack.c).
10450         * f-exp.y (type_stack): New global.
10451         Update rules.
10452         (push_kind_type, f_parse): Update.
10453         * d-exp.y (type_stack): New global.
10454         Update rules.
10455         (d_parse): Update.
10456         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10457         Update rules.
10458         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10459         (HFILES_NO_SRCDIR): Add type-stack.h.
10460
10461 2019-04-04  Tom Tromey  <tom@tromey.com>
10462
10463         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10464         (rust_parser::convert_ast_to_expression, rust_parse)
10465         (rust_lex_test_completion, rust_lex_tests): Update.
10466         * parser-defs.h (struct expr_completion_state): New.
10467         (struct parser_state) <parser_state>: Add completion parameter.
10468         <mark_struct_expression, mark_completion_tag>: New methods.
10469         <parse_completion, m_completion_state>: New members.
10470         (prefixify_expression, null_post_parser): Update.
10471         (mark_struct_expression, mark_completion_tag): Don't declare.
10472         * parse.c (parse_completion, expout_last_struct)
10473         (expout_tag_completion_type, expout_completion_name): Remove
10474         globals.
10475         (parser_state::mark_struct_expression)
10476         (parser_state::mark_completion_tag): Now methods.
10477         (prefixify_expression): Add last_struct parameter.
10478         (prefixify_subexp): Likewise.
10479         (parse_exp_1): Update.
10480         (parse_exp_in_context): Add cstate parameter.  Update.
10481         (parse_expression_for_completion): Create an
10482         expr_completion_state.
10483         (null_post_parser): Add "completion" parameter.
10484         * p-exp.y: Update rules.
10485         (yylex): Update.
10486         * language.h (struct language_defn) <la_post_parser>: Add
10487         "completing" parameter.
10488         * go-exp.y: Update rules.
10489         (lex_one_token): Update.
10490         * expression.h (parse_completion): Don't declare.
10491         * d-exp.y: Update rules.
10492         (lex_one_token): Update rules.
10493         * c-exp.y: Update rules.
10494         (lex_one_token): Update.
10495         * ada-lang.c (resolve): Add "parse_completion" parameter.
10496         (resolve_subexp): Likewise.
10497         (ada_resolve_function): Likewise.
10498
10499 2019-04-04  Tom Tromey  <tom@tromey.com>
10500
10501         * parser-defs.h (struct parser_state) <start_arglist,
10502         end_arglist>: New methods.
10503         <arglist_len, m_funcall_chain>: New members.
10504         (arglist_len, start_arglist, end_arglist): Don't declare.
10505         * parse.c (arglist_len, funcall_chain): Remove global.
10506         (start_arglist, end_arglist): Remove functions.
10507         (parse_exp_in_context): Update.
10508         * p-exp.y: Update rules.
10509         * m2-exp.y: Update rules.
10510         * go-exp.y: Update rules.
10511         * f-exp.y: Update rules.
10512         * d-exp.y: Update rules.
10513         * c-exp.y: Update rules.
10514
10515 2019-04-04  Tom Tromey  <tom@tromey.com>
10516
10517         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10518         lex_operator, push_back>: New methods.
10519         Update all rules.
10520         (rust_parser::lex_hex, lex_escape): Rename and update.
10521         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10522         (rust_parser::lex_operator): Rename and update.
10523         (rust_parser::lex_number, rustyylex, rustyyerror)
10524         (rust_lex_test_init, rust_lex_test_sequence)
10525         (rust_lex_test_push_back, rust_lex_tests): Update.
10526         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10527         parameter.
10528         <lexptr, prev_lexptr>: New members.
10529         (lexptr, prev_lexptr): Don't declare.
10530         * parse.c (lexptr, prev_lexptr): Remove globals.
10531         (parse_exp_in_context): Update.
10532         * p-exp.y (yylex, yyerror): Update.
10533         * m2-exp.y (parse_number, yylex, yyerror): Update.
10534         * go-exp.y (lex_one_token, yyerror): Update.
10535         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10536         * d-exp.y (lex_one_token, yyerror): Update.
10537         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10538         (lex_one_token, yyerror): Update.
10539         * ada-lex.l (YY_INPUT): Update.
10540         (rewind_to_char): Update.
10541         * ada-exp.y (yyerror): Update.
10542
10543 2019-04-04  Tom Tromey  <tom@tromey.com>
10544
10545         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10546         * parser-defs.h (struct parser_state) <parser_state>: Add new
10547         parameter.
10548         <comma_terminates>: New member.
10549         (comma_terminates): Don't declare global.
10550         * parse.c (comma_terminates): Remove global.
10551         (parse_exp_in_context): Update.
10552         * p-exp.y (yylex): Update.
10553         * m2-exp.y (yylex): Update.
10554         * go-exp.y (lex_one_token): Update.
10555         * f-exp.y (yylex): Update.
10556         * d-exp.y (lex_one_token): Update.
10557         * c-exp.y (lex_one_token): Update.
10558         * ada-lex.l: Update.
10559
10560 2019-04-04  Tom Tromey  <tom@tromey.com>
10561
10562         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10563         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10564         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10565         * parser-defs.h (paren_depth): Don't declare.
10566         * parse.c (paren_depth): Remove global.
10567         (parse_exp_in_context): Update.
10568         * p-exp.y (paren_depth): New global.
10569         (pascal_parse): Initialize it.
10570         * m2-exp.y (paren_depth): New global.
10571         (m2_parse): Initialize it.
10572         * go-exp.y (paren_depth): New global.
10573         (go_parse): Initialize it.
10574         * f-exp.y (paren_depth): New global.
10575         (f_parse): Initialize it.
10576         * d-exp.y (paren_depth): New global.
10577         (d_parse): Initialize it.
10578         * c-exp.y (paren_depth): New global.
10579         (c_parse): Initialize it.
10580         * ada-lex.l (paren_depth): New global.
10581         (lexer_init): Initialize it.
10582
10583 2019-04-04  Tom Tromey  <tom@tromey.com>
10584
10585         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10586         (rust_parser::convert_ast_to_type)
10587         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10588         * parser-defs.h (struct parser_state) <parser_state>: Add
10589         parameters.  Initialize new members.
10590         <expression_context_block, expression_context_pc>: New members.
10591         * parse.c (expression_context_block, expression_context_pc):
10592         Remove globals.
10593         (parse_exp_in_context): Update.
10594         * p-exp.y: Update all rules.
10595         (yylex): Update.
10596         * m2-exp.y: Update all rules.
10597         (yylex): Update.
10598         * go-exp.y (yylex): Update.
10599         * f-exp.y (yylex): Update.
10600         * d-exp.y: Update all rules.
10601         (yylex): Update.
10602         * c-exp.y: Update all rules.
10603         (lex_one_token, classify_name, yylex, c_parse): Update.
10604         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10605
10606 2019-04-04  Tom Tromey  <tom@tromey.com>
10607
10608         * gdbarch.h, gdbarch.c: Rebuild.
10609         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10610         * stap-probe.h:
10611         (struct stap_parse_info): Replace "parser_state" with
10612         "expr_builder".
10613         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10614         (parser_state): New class.
10615         * parse.c (expr_builder): Rename.
10616         (expr_builder::release): Rename.
10617         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10618         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10619         (write_exp_elt_longcst, write_exp_elt_floatcst)
10620         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10621         (write_exp_string_vector, write_exp_bitstring)
10622         (write_exp_msymbol, mark_struct_expression)
10623         (write_dollar_variable)
10624         (insert_type_address_space, increase_expout_size): Replace
10625         "parser_state" with "expr_builder".
10626         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10627         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10628         "parser_state" with "expr_builder".
10629
10630 2019-04-04  Tom Tromey  <tom@tromey.com>
10631
10632         * rust-exp.y: Replace "parse_language" with method call.
10633         * p-exp.y:
10634         (yylex): Replace "parse_language" with method call.
10635         * m2-exp.y:
10636         (yylex): Replace "parse_language" with method call.
10637         * go-exp.y (classify_name): Replace "parse_language" with method
10638         call.
10639         * f-exp.y (yylex): Replace "parse_language" with method call.
10640         * d-exp.y (lex_one_token): Replace "parse_language" with method
10641         call.
10642         * c-exp.y:
10643         (lex_one_token, classify_name, yylex): Replace "parse_language"
10644         with method call.
10645         * ada-exp.y (find_primitive_type, type_char)
10646         (type_system_address): Replace "parse_language" with method call.
10647
10648 2019-04-04  Tom Tromey  <tom@tromey.com>
10649
10650         * rust-exp.y: Replace "parse_gdbarch" with method call.
10651         * parse.c (write_dollar_variable, insert_type_address_space):
10652         Replace "parse_gdbarch" with method call.
10653         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10654         call.
10655         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10656         call.
10657         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10658         "parse_gdbarch" with method call.
10659         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10660         with method call.
10661         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10662         "parse_gdbarch" with method call.
10663         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10664         "parse_gdbarch" with method call.
10665         * c-exp.y (parse_type, parse_number, classify_name): Replace
10666         "parse_gdbarch" with method call.
10667         * ada-lex.l: Replace "parse_gdbarch" with method call.
10668         * ada-exp.y (parse_type, find_primitive_type, type_char)
10669         (type_system_address): Replace "parse_gdbarch" with method call.
10670
10671 2019-04-04  Tom Tromey  <tom@tromey.com>
10672
10673         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10674         * stap-probe.c (stap_parse_argument): Update.
10675         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10676         initial_size parameter.
10677         * rust-exp.y (rust_lex_tests): Update.
10678         * parse.c (parser_state): Update.
10679         (parse_exp_in_context): Update.
10680         * parser-defs.h (struct parser_state) <parser_state>: Remove
10681         "initial_size" parameter.
10682
10683 2019-04-04  Tom Tromey  <tom@tromey.com>
10684
10685         * parser-defs.h (increase_expout_size): Don't declare.
10686         * parse.c (increase_expout_size): Now static.
10687
10688 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10689
10690         * gnu-nat.c (gnu_nat_target::wait): Fix
10691         target_waitstatus_to_string call.
10692
10693 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10694
10695         * eval.c (evaluate_subexp_standard): Handle internal functions
10696         during Fortran function call handling.
10697
10698 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10699
10700         * NEWS: Mention new internal functions.
10701         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10702         (read_base_type): Use dwarf2_init_complex_target_type.
10703         * value.c (creal_internal_fn): New function.
10704         (cimag_internal_fn): New function.
10705         (_initialize_values): Register new internal functions.
10706
10707 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10708
10709         * infrun.c (stop_all_threads): If debug_infrun, always
10710         trace the wait status after wait_one, using
10711         target_waitstatus_to_string and target_pid_to_str.
10712         (handle_inferior_event): Replace various trace of
10713         wait status kind by a single trace.
10714         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10715         wait status kind image by target_waitstatus_to_string.
10716         * target/waitstatus.c (target_waitstatus_to_string): Fix
10717         obsolete comment.
10718
10719 2019-04-01  Tom Tromey  <tromey@adacore.com>
10720
10721         PR symtab/23331:
10722         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10723
10724 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10725             Pedro Alves  <palves@redhat.com>
10726
10727         * top.c (quit_force): Call 'finalize_values'.
10728         * value.c (finalize_values): New function.
10729         * value.h (finalize_values): Declare.
10730
10731 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10732
10733         * NEWS: Announce $_gdb_major and $_gdb_minor.
10734
10735         * top.c (init_gdb_version_vars): New function.
10736         (gdb_init): Call init_gdb_version_vars.
10737
10738 2019-03-29  Tom Tromey  <tromey@adacore.com>
10739
10740         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10741         help text.  Remove dead code.
10742
10743 2019-03-29  Keith Seitz  <keiths@redhat.com>
10744
10745         From Siddhesh Poyarekar:
10746         * f-lang.h (f77_get_upperbound): Return LONGEST.
10747         (f77_get_lowerbound): Likewise.
10748         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10749         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10750         print them.
10751         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10752         plongest to format print it.
10753         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10754         (f77_get_upperbound): Likewise.
10755         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10756         LOWER_BOUND to LONGEST.
10757         (f77_create_arrayprint_offset_tbl): Likewise.
10758
10759 2019-03-29  Keith Seitz  <keiths@redhat.com>
10760
10761         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10762         %s/pulongest for TYPE_LENGTH instead of %d in format
10763         strings.
10764         * ada-typerint.c (ada_print_type): Likewise.
10765         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10766         * compile/compile-c-support.c (generate_register_struct): Likewise.
10767         * gdbtypes.c (recursive_dump_type): Likewise.
10768         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10769         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10770         instead of %d in format strings.
10771         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10772         to std::min to ULONGEST.
10773         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10774         instead of %d in format strings.
10775         * tracepoint.c (info_scope_command): Likewise.
10776         * typeprint.c (print_offset_data::update)
10777         (print_offset_data::finish): Likewise.
10778         * xtensa-tdep.c (xtensa_store_return_value)
10779         (xtensa_push_dummy_call): Likewise.
10780
10781 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10782
10783         * windows-nat.c (display_selector): Fixed format specifications
10784         for 64-bit Cygwin.
10785
10786 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10787
10788         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10789
10790 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10791
10792         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10793         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10794         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10795         (nios2_linux_init_abi): Install it.
10796
10797 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10798
10799         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10800
10801 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10802
10803         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10804
10805 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10806             Tom Tromey  <tromey@adacore.com>
10807
10808         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10809
10810 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10811
10812         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10813         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10814         method to compute the bounds of range types. Also print "[evaluated]"
10815         if the bounds' values come from a dynamic evaluation.
10816
10817 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10818
10819         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10820         whitespace when pretty printing is on.
10821
10822 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10823
10824         * ppc-linux-nat.c: Add include.
10825
10826 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10827
10828         * NEWS: Mention AArch64 Pointer Authentication.
10829
10830 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10831
10832         * arm-linux-nat.c: Add include.
10833
10834 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10835
10836         * source-cache.c (source_cache::get_source_lines): Re-read
10837         fullname after calling open_source_file.
10838
10839 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10840
10841         * NEWS: Mention TLS support for FreeBSD.
10842
10843 2019-03-25  Tom Tromey  <tromey@adacore.com>
10844
10845         * minsyms.c (BUNCH_SIZE): Update comment.
10846         (~minimal_symbol_reader): Remove old comment.
10847         (compact_minimal_symbols): Update comment.
10848         (minimal_symbol_reader::install): Remove old comment.  Update
10849         other comments.
10850
10851 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10852
10853         * s390-linux-nat.c: Add include.
10854
10855 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10856
10857         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10858         Call linux_get_hwcap.
10859         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10860         Likewise.
10861         (aarch64_linux_get_hwcap): Remove function.
10862         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10863         declaration.
10864         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10865         linux_get_hwcap.
10866         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10867         * linux-tdep.c (linux_get_hwcap): Add function.
10868         (linux_get_hwcap2): Likewise.
10869         * linux-tdep.h (linux_get_hwcap): Add declaration.
10870         (linux_get_hwcap2): Likewise.
10871         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10872         (ppc_linux_get_hwcap2): Likewise.
10873         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10874         linux_get_hwcap.
10875         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10876         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10877         (ppc_linux_nat_target::read_description): Likewise.
10878         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10879         * s390-linux-nat.c: Likewise.
10880         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10881
10882 2019-03-24  Tom Tromey  <tom@tromey.com>
10883
10884         * ada-lang.c (standard_lookup): Simplify initialization.
10885         (ada_lookup_symbol_nonlocal): Simplify return.
10886         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10887         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10888         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10889         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10890         initialization.
10891         * solib.c (solib_global_lookup): Simplify.
10892         * symtab.c (null_block_symbol): Remove.
10893         (symbol_cache_lookup): Simplify returns.
10894         (lookup_language_this): Simplify returns.
10895         (lookup_symbol_aux): Simplify return.
10896         (lookup_local_symbol): Simplify returns.
10897         (lookup_global_symbol_from_objfile): Simplify return.
10898         (lookup_symbol_in_objfile_symtabs)
10899         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10900         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10901         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10902         * cp-namespace.c (cp_lookup_bare_symbol)
10903         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10904         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10905         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10906         (cp_lookup_symbol_via_imports): Simplify initialization.
10907         (find_symbol_in_baseclass): Likewise.
10908         * symtab.h (null_block_symbol): Remove.
10909         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10910         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10911         (d_lookup_symbol_module): Likewise.
10912         (find_symbol_in_baseclass): Simplify initialization.
10913
10914 2019-03-24  Tom Tromey  <tom@tromey.com>
10915
10916         * expression.h: Don't include symtab.h.
10917         (struct block): Forward declare.
10918
10919 2019-03-24  Tom Tromey  <tom@tromey.com>
10920
10921         * c-exp.y (typebase): Remove casts.
10922         * gdbtypes.c (lookup_unsigned_typename, )
10923         (lookup_signed_typename): Remove cast.
10924         * eval.c (parse_to_comma_and_eval): Remove cast.
10925         * parse.c (write_dollar_variable): Remove cast.
10926         * block.h (struct block) <superblock>: Now const.
10927         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10928         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10929         (map_block): Make "block" const.
10930         * symfile.h (struct quick_symbol_functions)
10931         <map_matching_symbols>: Constify block argument to "callback".
10932         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10933         const.
10934         (find_pc_sect_compunit_symtab): Make "b" const.
10935         (find_symbol_at_address): Likewise.
10936         (search_symbols): Likewise.
10937         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10938         (dw2_debug_names_lookup_symbol): Likewise.
10939         (dw2_map_matching_symbols): Update.
10940         * p-valprint.c (pascal_val_print): Remove "block".
10941         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10942         (aux_add_nonlocal_symbols): Make "block" const.
10943         (resolve_subexp): Remove cast.
10944         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10945         const.
10946         (iterate_over_file_blocks): Likewise.
10947         * f-exp.y (%union) <bval>: Remove.
10948         * coffread.c (patch_opaque_types): Make "b" const.
10949         * spu-tdep.c (spu_catch_start): Make "block" const.
10950         * c-valprint.c (print_unpacked_pointer): Remove "block".
10951         * symmisc.c (dump_symtab_1): Make "b" const.
10952         (block_depth): Make "block" const.
10953         * d-exp.y (%union) <bval>: Remove.
10954         * cp-support.h (cp_lookup_rtti_type): Update.
10955         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10956         * psymtab.c (psym_lookup_symbol): Make "block" const.
10957         (maintenance_check_psymtabs): Make "b" const.
10958         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10959         (enumerate_locals, enumerate_args): Update.
10960         * python/py-symtab.c (stpy_global_block): Make "block" const.
10961         (stpy_static_block): Likewise.
10962         * inline-frame.c (block_starting_point_at): Make "new_block"
10963         const.
10964         * block.c (find_block_in_blockvector): Make return type const.
10965         (blockvector_for_pc_sect): Make "b" const.
10966         (find_block_in_blockvector): Make "b" const.
10967
10968 2019-03-23  Tom Tromey  <tom@tromey.com>
10969
10970         * varobj.c (varobj_create): Update.
10971         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10972         * printcmd.c (display_command, do_one_display): Don't reset
10973         innermost_block.
10974         * parser-defs.h (enum innermost_block_tracker_type): Move to
10975         expression.h.
10976         (innermost_block): Update comment.
10977         * parse.c (parse_exp_1): Add tracker_types parameter.
10978         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10979         tracker_types parameter.  Reset innermost_block.
10980         (parse_exp_in_context): Remove.
10981         (parse_expression_for_completion): Update.
10982         * objfiles.c (~objfile): Don't reset expression_context_block or
10983         innermost_block.
10984         * expression.h (enum innermost_block_tracker_type): Move from
10985         parser-defs.h.
10986         (parse_exp_1): Add tracker_types parameter.
10987         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10988         reset innermost_block.
10989
10990 2019-03-23  Tom Tromey  <tom@tromey.com>
10991
10992         * objfiles.h: Include bcache.h.
10993
10994 2019-03-23  Tom Tromey  <tom@tromey.com>
10995
10996         * linespec.c (get_current_search_block): Use
10997         scoped_restore_current_language.
10998         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10999
11000 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11001             Jiong Wang  <jiong.wang@arm.com>
11002
11003         * aarch64-linux-tdep.c
11004         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11005         section.
11006         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11007
11008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11009             Jiong Wang  <jiong.wang@arm.com>
11010
11011         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11012         instructions.
11013         (aarch64_analyze_prologue_test): Add PACIASP test.
11014         (aarch64_prologue_prev_register): Unmask PC value.
11015
11016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11017             Jiong Wang  <jiong.wang@arm.com>
11018
11019         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11020         (aarch64_dwarf2_prev_register): Unmask PC value.
11021         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11022         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11023         DW_CFA_AARCH64_negate_ra_state.
11024         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11025
11026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11027             Jiong Wang  <jiong.wang@arm.com>
11028
11029         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11030         registers.
11031         (aarch64_pseudo_register_name): Likewise.
11032         (aarch64_pseudo_register_type): Likewise.
11033         (aarch64_pseudo_register_reggroup_p): Likewise.
11034         (aarch64_gdbarch_init): Add pauth registers.
11035         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11036         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11037         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11038         (struct gdbarch_tdep): Add regnum for ra_state.
11039
11040 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11041             Jiong Wang  <jiong.wang@arm.com>
11042
11043         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11044
11045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11046             Jiong Wang  <jiong.wang@arm.com>
11047
11048         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11049         function.
11050         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11051         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11052         (aarch64_gdbarch_init): Add puth registers.
11053         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11054         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11055         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11056
11057 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11058             Jiong Wang  <jiong.wang@arm.com>
11059
11060         * aarch64-linux-nat.c
11061         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11062         * aarch64-linux-tdep.c
11063         (aarch64_linux_core_read_description): Likewise.
11064         (aarch64_linux_get_hwcap): New function.
11065         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11066         (aarch64_linux_get_hwcap): New declaration.
11067
11068 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11069             Jiong Wang  <jiong.wang@arm.com>
11070
11071         * aarch64-linux-nat.c
11072         (aarch64_linux_nat_target::read_description): Add pauth param.
11073         * aarch64-linux-tdep.c
11074         (aarch64_linux_core_read_description): Likewise.
11075         * aarch64-tdep.c (struct target_desc): Add in pauth.
11076         (aarch64_read_description): Add pauth param.
11077         (aarch64_gdbarch_init): Likewise.
11078         * aarch64-tdep.h (aarch64_read_description): Likewise.
11079         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11080         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11081         * features/Makefile: Add new files.
11082         * features/aarch64-pauth.c: New file.
11083         * features/aarch64-pauth.xml: New file.
11084
11085 2019-03-20  Tom Tromey  <tromey@adacore.com>
11086
11087         * infrun.c (handle_inferior_event): Rename from
11088         handle_inferior_event_1.  Create a scoped_value_mark.
11089         (handle_inferior_event): Remove.
11090
11091 2019-03-19  Tom Tromey  <tromey@adacore.com>
11092
11093         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11094         * infrun.h (print_stop_event): Add "displays" parameter.
11095         * infrun.c (print_stop_event): Add "displays" parameter.
11096
11097 2019-03-19  Pedro Alves  <palves@redhat.com>
11098
11099         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11100         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11101         to -1.  Fix TABs vs spaces.
11102         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11103         * tui/tui-out.h (tui_ui_out) Add intro comments.
11104         <m_line, m_start_of_line>: In-class initialize, and add describing
11105         comment.
11106
11107 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11108
11109         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11110         variable names.
11111         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11112
11113 2019-03-18  Pedro Alves  <palves@redhat.com>
11114             Eli Zaretskii <eliz@gnu.org>
11115
11116         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11117         m_line and m_start_of_line.
11118
11119 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11120
11121         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11122         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11123         it returns a newline.  This fixes a regression in TU mode, whereby
11124         the next line is output on the same screen line as the user input.
11125
11126 2019-03-18  Tom Tromey  <tromey@adacore.com>
11127
11128         * minsyms.c (minimal_symbol_reader::install): Remove call to
11129         obstack_blank.
11130
11131 2019-03-18  Pedro Alves  <palves@redhat.com>
11132
11133         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11134         New globals.
11135         (apply_style): New, factored out from ...
11136         (apply_ansi_escape): ... this.  Handle reverse video mode.
11137         (tui_set_reverse_mode): New function.
11138         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11139         * tui/tui-winsource.c (tui_show_source_line): Use
11140         tui_set_reverse_mode instead of setting A_STANDOUT.
11141         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11142         New setter methods.
11143
11144 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11145
11146         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11147         Handle tabs.
11148
11149 2019-03-18  Tom Tromey  <tromey@adacore.com>
11150
11151         * ada-lang.c (empty_array): Add "high" parameter.
11152         (ada_evaluate_subexp): Update.
11153
11154 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11155
11156         * unittests/string_view-selftests.c: Define
11157         _initialize_string_view_selftests unconditionally.
11158
11159 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11160
11161         PR gdb/24350
11162         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11163
11164 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11165
11166         PR gdb/24351
11167         * windows-nat.c (display_selector): Fix format specifiers.
11168
11169 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11170
11171         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11172         tui_refill_source_window instead of tui_refresh_win, to update the
11173         current execution line.  This fixes redisplay of the current line
11174         when stepping through the code with "next" or "step".
11175
11176 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11177
11178         * source-cache.c (source_cache::get_source_lines): Call
11179         find_source_lines to initialize s->nlines.  This fixes vertical
11180         scrolling of TUI source window when the DOWN arrow is pressed.
11181
11182 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11183
11184         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11185         linux-thread-db.c (_initialize_thread_db): Likewise.
11186
11187 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11188
11189         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11190         wclrtoeol in tui_show_source_line".  This reverts changes made in
11191         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11192
11193 2019-03-15  Tom Tromey  <tom@tromey.com>
11194
11195         * symtab.h (struct minimal_symbol): Derive from
11196         general_symbol_info.
11197         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11198         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11199         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11200         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11201         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11202         (MSYMBOL_SEARCH_NAME): Update.
11203         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11204         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11205         * minsyms.c (minimal_symbol_reader::record_full): Update.
11206
11207 2019-03-15  Tom Tromey  <tom@tromey.com>
11208
11209         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11210
11211 2019-03-15  Tom Tromey  <tom@tromey.com>
11212
11213         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11214         unique_xmalloc_ptr.
11215         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11216         Update.
11217         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11218         (build_minimal_symbol_hash_tables)
11219         (minimal_symbol_reader::install): Update.
11220
11221 2019-03-15  Tom Tromey  <tom@tromey.com>
11222
11223         * symtab.c (create_demangled_names_hash): Update.
11224         (symbol_set_names): Update.
11225         * objfiles.h (struct objfile_per_bfd_storage)
11226         <demangled_names_hash>: Now an htab_up.
11227         * objfiles.c (objfile_per_bfd_storage): Simplify.
11228
11229 2019-03-15  Tom Tromey  <tom@tromey.com>
11230
11231         * objfiles.h (struct objfile_per_bfd_storage): Declare
11232         destructor.
11233         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11234         New.
11235         (get_objfile_bfd_data): Use new.  Don't initialize
11236         language_of_main.
11237         (free_objfile_per_bfd_storage): Remove.
11238         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11239
11240 2019-03-15  Tom Tromey  <tom@tromey.com>
11241
11242         * symfile.c (reread_symbols): Update.
11243         * objfiles.c (objfile::objfile): Update.
11244         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11245         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11246         comment.
11247         (minimal_symbol_reader::install): Update.
11248         (terminate_minimal_symbol_table): Remove.
11249         * jit.c (jit_object_close_impl): Update.
11250
11251 2019-03-15  Tom Tromey  <tom@tromey.com>
11252
11253         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11254         initializations.
11255
11256 2019-03-15  Tom Tromey  <tom@tromey.com>
11257
11258         * objfiles.h (struct objfile_per_bfd_storage)
11259         <demangled_hash_languages>: Now a bitset.
11260         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11261         (lookup_minimal_symbol): Update.
11262
11263 2019-03-15  Tom Tromey  <tom@tromey.com>
11264
11265         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11266         Don't return the symbol.
11267         * coffread.c (record_minimal_symbol): Use record_full.
11268
11269 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11270
11271         The MS-Windows port of ncurses fails to switch to a color pair if
11272         one or both of the colors are the implicit default colors.  This
11273         change records the default colors when TUI is initialized, and
11274         then specifies them explicitly when a color pair uses the default
11275         colors.  This allows color styling in TUI mode on MS-Windows.
11276
11277         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11278         ncurses_norm_attr.
11279         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11280         colors in ncurses_norm_attr.
11281         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11282         "none", replace it with the default color recorded in
11283         ncurses_norm_attr.
11284
11285 2019-03-14  Tom Tromey  <tromey@adacore.com>
11286
11287         * source-cache.h (class source_cache) <get_source_lines>: Return
11288         std::string.
11289         * source-cache.c (source_cache::extract_lines): Handle case where
11290         first_pos==npos.  Return std::string.
11291         (source_cache::get_source_lines): Update.
11292
11293 2019-03-14  Tom Tromey  <tromey@adacore.com>
11294
11295         * NEWS: Add item for "style sources" commands.
11296         * source-cache.c (source_cache::get_source_lines): Check
11297         source_styling.
11298         * cli/cli-style.c (source_styling): New global.
11299         (_initialize_cli_style): Add "style sources" commands.
11300         (show_style_sources): New function.
11301         * cli/cli-style.h (source_styling): Declare.
11302
11303 2019-03-14  Pedro Alves  <palves@redhat.com>
11304             Tom Tromey  <tromey@adacore.com>
11305
11306         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11307         * tui/tui-winsource.c (tui_refill_source_window): New function,
11308         from...
11309         (tui_horizontal_source_scroll): ... here.  Move some logic.
11310         * cli/cli-style.c (set_style_enabled): Notify new observable.
11311         * tui/tui-hooks.c (tui_redisplay_source): New function.
11312         (tui_attach_detach_observers): Attach or detach
11313         tui_redisplay_source.
11314         * observable.h (source_styling_changed): New observable.
11315         * observable.c: Define source_styling_changed observable.
11316
11317 2019-03-13  Tom Tromey  <tromey@adacore.com>
11318
11319         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11320         (i386_gnu_nat_target::store_registers): Update.
11321         * target-debug.h (target_debug_print_std_string): New macro.
11322         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11323         * windows-tdep.c (display_one_tib): Update.
11324         * tui/tui-stack.c (tui_make_status_line): Update.
11325         * top.c (print_inferior_quit_action): Update.
11326         * thread.c (thr_try_catch_cmd): Update.
11327         (add_thread_with_info): Update.
11328         (thread_target_id_str): Update.
11329         (thr_try_catch_cmd): Update.
11330         (thread_command): Update.
11331         (thread_find_command): Update.
11332         * record-btrace.c (record_btrace_target::info_record)
11333         (record_btrace_resume_thread, record_btrace_target::resume)
11334         (record_btrace_cancel_resume, record_btrace_step_thread)
11335         (record_btrace_target::wait, record_btrace_target::wait)
11336         (record_btrace_target::wait, record_btrace_target::stop): Update.
11337         * progspace.c (print_program_space): Update.
11338         * process-stratum-target.c
11339         (process_stratum_target::thread_address_space): Update.
11340         * linux-fork.c (linux_fork_mourn_inferior)
11341         (detach_checkpoint_command, info_checkpoints_command)
11342         (linux_fork_context): Update.
11343         (linux_fork_detach): Update.
11344         (class scoped_switch_fork_info): Update.
11345         (delete_checkpoint_command): Update.
11346         * infrun.c (follow_fork_inferior): Update.
11347         (follow_fork_inferior): Update.
11348         (proceed_after_vfork_done): Update.
11349         (handle_vfork_child_exec_or_exit): Update.
11350         (follow_exec): Update.
11351         (displaced_step_prepare_throw): Update.
11352         (displaced_step_restore): Update.
11353         (start_step_over): Update.
11354         (resume_1): Update.
11355         (clear_proceed_status_thread): Update.
11356         (proceed): Update.
11357         (print_target_wait_results): Update.
11358         (do_target_wait): Update.
11359         (context_switch): Update.
11360         (stop_all_threads): Update.
11361         (restart_threads): Update.
11362         (finish_step_over): Update.
11363         (handle_signal_stop): Update.
11364         (switch_back_to_stepped_thread): Update.
11365         (keep_going_pass_signal): Update.
11366         (print_exited_reason): Update.
11367         (normal_stop): Update.
11368         * inferior.c (inferior_pid_to_str): Change return type.
11369         (print_selected_inferior): Update.
11370         (add_inferior): Update.
11371         (detach_inferior): Update.
11372         * dummy-frame.c (fprint_dummy_frames): Update.
11373         * dcache.c (dcache_info_1): Update.
11374         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11375         (btrace_fetch, btrace_clear): Update.
11376         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11377         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11378         type.
11379         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11380         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11381         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11382         * gdbarch.c, gdbarch.h: Rebuild.
11383         * gdbarch.sh (core_pid_to_str): Change return type.
11384         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11385         return type.
11386         (windows_nat_target::pid_to_str): Change return type.
11387         (windows_delete_thread): Update.
11388         (windows_nat_target::attach): Update.
11389         (windows_nat_target::files_info): Update.
11390         * target-delegates.c: Rebuild.
11391         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11392         return type.
11393         (sol_thread_target::pid_to_str): Change return type.
11394         * remote.c (class remote_target) <pid_to_str>: Change return
11395         type.
11396         (remote_target::pid_to_str): Change return type.
11397         (extended_remote_target::attach, remote_target::remote_stop_ns)
11398         (remote_target::remote_notif_remove_queued_reply)
11399         (remote_target::push_stop_reply, remote_target::disable_btrace):
11400         Update.
11401         (extended_remote_target::attach): Update.
11402         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11403         type.
11404         (gdbsim_target::pid_to_str): Change return type.
11405         * ravenscar-thread.c (struct ravenscar_thread_target)
11406         <pid_to_str>: Change return type.
11407         (ravenscar_thread_target::pid_to_str): Change return type.
11408         * procfs.c (class procfs_target) <pid_to_str>: Change return
11409         type.
11410         (procfs_target::pid_to_str): Change return type.
11411         (procfs_target::attach): Update.
11412         (procfs_target::detach): Update.
11413         (procfs_target::fetch_registers): Update.
11414         (procfs_target::store_registers): Update.
11415         (procfs_target::wait): Update.
11416         (procfs_target::files_info): Update.
11417         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11418         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11419         return type.
11420         (nto_procfs_target::pid_to_str): Change return type.
11421         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11422         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11423         return type.
11424         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11425         (exit_lwp): Update.
11426         (attach_proc_task_lwp_callback, get_detach_signal)
11427         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11428         (linux_nat_target::resume, wait_lwp, stop_callback)
11429         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11430         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11431         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11432         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11433         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11434         type.
11435         (inf_ptrace_target::attach): Update.
11436         (inf_ptrace_target::files_info): Update.
11437         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11438         type.
11439         (go32_nat_target::pid_to_str): Change return type.
11440         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11441         (gnu_nat_target::wait): Update.
11442         (gnu_nat_target::wait): Update.
11443         (gnu_nat_target::resume): Update.
11444         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11445         (fbsd_nat_target::wait): Update.
11446         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11447         type.
11448         (darwin_nat_target::attach): Update.
11449         * corelow.c (class core_target) <pid_to_str>: Change return type.
11450         (core_target::pid_to_str): Change return type.
11451         * target.c (normal_pid_to_str): Change return type.
11452         (default_pid_to_str): Likewise.
11453         (target_pid_to_str): Change return type.
11454         (target_translate_tls_address): Update.
11455         (target_announce_detach): Update.
11456         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11457         return type.
11458         (bsd_uthread_target::pid_to_str): Change return type.
11459         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11460         type.
11461         (bsd_kvm_target::pid_to_str): Change return type.
11462         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11463         return type.
11464         (aix_thread_target::pid_to_str): Change return type.
11465         * target.h (struct target_ops) <pid_to_str>: Change return type.
11466         (target_pid_to_str, normal_pid_to_str): Likewise.
11467         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11468         type.
11469         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11470         type.
11471         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11472         return type.
11473         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11474         type.
11475         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11476         type.
11477         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11478         return type.
11479
11480 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11481
11482         * NEWS: Mention that the new default MI version is 3.  Mention
11483         changes to the output of commands and events that deal with
11484         multi-location breakpoints.
11485         * breakpoint.c: Include "mi/mi-out.h".
11486         (print_one_breakpoint): Change output syntax if using MI version
11487         >= 3.
11488         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11489         New.
11490         (mi_multi_location_breakpoint_output_fixed): New.
11491         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11492         (mi_cmd_fix_multi_location_breakpoint_output): New.
11493         (mi_multi_location_breakpoint_output_fixed): New.
11494         * mi/mi-cmds.c (mi_cmds): Register command
11495         -fix-multi-location-breakpoint-output.
11496         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11497         interpreter "mi".
11498
11499 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11500
11501         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11502         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11503         instantiate mi_ui_out based on interpreter name.
11504         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11505         * mi/mi-main.c (mi_load_progress): Likewise.
11506
11507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11508
11509         * NEWS: Combine separate "New targets" sections for 8.3.
11510
11511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11512
11513         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11514         (ppcfbsd_init_abi): Install gdbarch
11515         "fetch_tls_load_module_address" and "get_thread_local_address"
11516         methods.
11517
11518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11519
11520         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11521         (riscv_fbsd_init_abi): Install gdbarch
11522         "fetch_tls_load_module_address" and "get_thread_local_address"
11523         methods.
11524
11525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11526
11527         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11528         (i386fbsd_init_abi): Install gdbarch
11529         "fetch_tls_load_module_address" and "get_thread_local_address"
11530         methods.
11531
11532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11533
11534         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11535         (amd64fbsd_init_abi): Install gdbarch
11536         "fetch_tls_load_module_address" and "get_thread_local_address"
11537         methods.
11538
11539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11540
11541         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11542         (struct fbsd_pspace_data): New type.
11543         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11544         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11545         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11546         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11547         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11548
11549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11550
11551         * gdbtypes.c (lookup_struct_elt): New function.
11552         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11553         * gdbtypes.h (struct struct_elt): New type.
11554         (lookup_struct_elt): New prototype.
11555
11556 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11557
11558         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11559         remove disabled code block.
11560
11561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11562
11563         * gdbarch.sh (get_thread_local_address): New method.
11564         * gdbarch.h, gdbarch.c: Regenerate.
11565         * target.c (target_translate_tls_address): Use
11566         gdbarch_get_thread_local_address if present instead of
11567         target::get_thread_local_address.
11568
11569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11570
11571         * target.h (target::get_thread_local_address): Update comment.
11572
11573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11574
11575         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11576         objfile->separate_debug_objfile_backlink if not NULL.
11577
11578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11579
11580         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11581         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11582         (amd64bsd_store_inferior_registers): Likewise.
11583         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11584         Enable segment base registers.
11585         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11586         PT_GETFSBASE and PT_GETGSBASE.
11587         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11588         PT_SETGSBASE.
11589         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11590         segment base registers.
11591         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11592
11593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11594
11595         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11596         Update calls to i386_target_description to add 'segments'
11597         parameter.
11598         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11599         add segment base registers.
11600         * arch/i386.c (i386_create_target_description): Add 'segments'
11601         parameter to enable segment base registers.
11602         * arch/i386.h (i386_create_target_description): Likewise.
11603         * features/i386/32bit-segments.xml: New file.
11604         * features/i386/32bit-segments.c: Generate.
11605         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11606         call to i386_target_description to add 'segments' parameter.
11607         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11608         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11609         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11610         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11611         if feature is present.
11612         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11613         Add 'segments' parameter to call to i386_target_description.
11614         (i386_target_description): Add 'segments' parameter to enable
11615         segment base registers.
11616         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11617         to call to i386_target_description.
11618         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11619         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11620         Define I386_NUM_REGS.
11621         (i386_target_description): Add 'segments' parameter to enable
11622         segment base registers.
11623
11624 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11625
11626         PR/24325
11627         * source-cache.c: #undef open and close, to avoid unresolved
11628         externals during linking.
11629
11630 2019-03-12  Tom Tromey  <tromey@adacore.com>
11631
11632         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11633         const.  Add initializers.
11634         (_initialize_remote): Don't initialize ptid globals.
11635
11636 2019-03-12  Pedro Alves  <palves@redhat.com>
11637
11638         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11639
11640 2019-03-12  Pedro Alves  <palves@redhat.com>
11641
11642         * cp-name-parser.y (main): Remove unused 'len' variable.
11643
11644 2019-03-12  Tom Tromey  <tromey@adacore.com>
11645
11646         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11647         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11648
11649 2019-03-12  Tom Tromey  <tromey@adacore.com>
11650
11651         * linux-nat.c (iterate_over_lwps): Update.
11652         (stop_callback): Remove parameter.
11653         (stop_wait_callback, detach_callback, resume_set_callback)
11654         (select_singlestep_lwp_callback, set_ignore_sigint)
11655         (status_callback, resumed_callback, resume_clear_callback)
11656         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11657         data parameter.
11658         (linux_nat_target::detach, linux_nat_target::resume)
11659         (linux_stop_and_wait_all_lwps, select_event_lwp)
11660         (linux_nat_filter_event, linux_nat_wait_1)
11661         (linux_nat_target::kill, linux_nat_target::stop)
11662         (linux_nat_target::stop): Update.
11663         (linux_nat_resume_callback): Change type.
11664         (resume_stopped_resumed_lwps, count_events_callback)
11665         (select_event_lwp_callback): Likewise.
11666         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11667         * arm-linux-nat.c (struct update_registers_data): Remove.
11668         (update_registers_callback): Change type.
11669         (arm_linux_insert_hw_breakpoint1): Update.
11670         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11671         parameter.
11672         (x86_linux_dr_set_addr): Update.
11673         (x86_linux_dr_set_control): Update.
11674         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11675         (iterate_over_lwps): Use gdb::function_view.
11676         * nat/aarch64-linux-hw-point.c (struct
11677         aarch64_dr_update_callback_param): Remove.
11678         (debug_reg_change_callback): Change type.
11679         (aarch64_notify_debug_reg_change): Update.
11680         * s390-linux-nat.c (s390_refresh_per_info): Update.
11681
11682 2019-03-11  Tom Tromey  <tromey@adacore.com>
11683
11684         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11685         redundant assignment to "this_cu".
11686
11687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11688
11689         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11690
11691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11692
11693         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11694         from...
11695         (rank_one_type): ... this.
11696
11697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11698
11699         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11700         from...
11701         (rank_one_type): ... this.
11702
11703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11704
11705         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11706         from...
11707         (rank_one_type): ... this.
11708
11709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11710
11711         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11712         from...
11713         (rank_one_type): ... this.
11714
11715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11716
11717         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11718         from...
11719         (rank_one_type): ... this.
11720
11721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11722
11723         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11724         from...
11725         (rank_one_type): ... this.
11726
11727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11728
11729         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11730         from...
11731         (rank_one_type): ... this.
11732
11733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11734
11735         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11736         from...
11737         (rank_one_type): ... this.
11738
11739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11740
11741         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11742         from...
11743         (rank_one_type): ... this.
11744
11745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11746
11747         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11748         from...
11749         (rank_one_type): ... this.
11750
11751 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11752
11753         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11754         from...
11755         (rank_one_type): ... this.
11756
11757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11758
11759         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11760         from...
11761         (rank_one_type): ... this.
11762
11763 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11764
11765         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11766         inferior-events' shows the example events.
11767
11768 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11769
11770         Support styling on native MS-Windows console
11771
11772         PR/24315
11773         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11774         on MS-Windows if $TERM is not defined.
11775
11776         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11777
11778         * posix-hdep.c (gdb_console_fputs):
11779         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11780         functions.
11781         * ui-file.h (gdb_console_fputs): Add prototype.
11782
11783         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11784         back to fputs only if the former returns zero.
11785
11786 2019-03-07  Tom Tromey  <tom@tromey.com>
11787
11788         * symmisc.c (print_symbol_bcache_statistics): Update.
11789         (print_objfile_statistics): Update.
11790         * symfile.c (allocate_symtab): Update.
11791         * stabsread.c: Don't include bcache.h.
11792         * psymtab.h (struct psymbol_bcache): Don't declare.
11793         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11794         (psymbol_bcache_init, psymbol_bcache_free)
11795         (psymbol_bcache_get_bcache): Don't declare.
11796         * psymtab.c (struct psymbol_bcache): Remove.
11797         (psymtab_storage::psymtab_storage): Update.
11798         (psymtab_storage::~psymtab_storage): Update.
11799         (psymbol_bcache_init, psymbol_bcache_free)
11800         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11801         (add_psymbol_to_bcache): Update.
11802         (allocate_psymtab): Update.
11803         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11804         macro_cache>: No longer pointers.
11805         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11806         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11807         * macrotab.c (macro_bcache): Update.
11808         * macroexp.c: Don't include bcache.h.
11809         * gdbtypes.c (check_types_worklist): Update.
11810         (types_deeply_equal): Remove TRY/CATCH.  Update.
11811         * elfread.c (elf_symtab_read): Update.
11812         * dwarf2read.c: Don't include bcache.h.
11813         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11814         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11815         (print_bcache_statistics, bcache_memory_used): Don't declare.
11816         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11817         methods.  Rename all data members.
11818         * bcache.c (struct bcache): Move to bcache.h.
11819         (bcache::expand_hash_table): Rename from expand_hash_table.
11820         (bcache): Remove.
11821         (bcache::insert): Rename from bcache_full.
11822         (bcache::compare): Rename from bcache_compare.
11823         (bcache_xmalloc): Remove.
11824         (bcache::~bcache): Rename from bcache_xfree.
11825         (bcache::print_statistics): Rename from print_bcache_statistics.
11826         (bcache::memory_used): Rename from bcache_memory_used.
11827
11828 2019-03-07  Pedro Alves  <palves@redhat.com>
11829
11830         * infrun.c (normal_stop): Also check for
11831         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11832
11833 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * f-lang.c (value_from_host_double): Moved to...
11836         * value.c (value_from_host_double): ...here.
11837         * value.h (value_from_host_double): Declare.
11838         * guile/scm-math.c (vlscm_convert_typed_number): Use
11839         value_from_host_double.
11840         (vlscm_convert_number): Likewise.
11841         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11842         * python/py-value.c (convert_value_from_python): Likewise.
11843
11844 2019-03-06  Tom Tromey  <tom@tromey.com>
11845
11846         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11847
11848 2019-03-06  Tom Tromey  <tom@tromey.com>
11849
11850         * utils.h (free_current_contents): Don't declare.
11851         * utils.c (free_current_contents): Remove.
11852
11853 2019-03-06  Tom Tromey  <tom@tromey.com>
11854
11855         * top.c (quit_force): Update.
11856         * main.c (captured_command_loop): Update.
11857         * common/new-op.c (operator new): Update.
11858         * common/common-exceptions.c (struct catcher)
11859         <save_cleanup_chain>: Remove member.
11860         (exceptions_state_mc_init): Update.
11861         (exception_try_scope_entry): Return nullptr.
11862         (exception_try_scope_exit, exception_rethrow)
11863         (throw_exception_sjlj, throw_exception_cxx): Update.
11864         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11865         (all_cleanups, do_cleanups, discard_cleanups)
11866         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11867         (restore_cleanups, restore_final_cleanups): Don't declare.
11868         (do_final_cleanups): Remove parameter.
11869         * common/cleanups.c (cleanup_chain, make_cleanup)
11870         (make_cleanup_dtor, all_cleanups, do_cleanups)
11871         (discard_my_cleanups, discard_cleanups)
11872         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11873         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11874         (null_cleanup): Remove.
11875         (do_final_cleanups): Remove parameter.
11876
11877 2019-03-06  Tom Tromey  <tom@tromey.com>
11878
11879         * remote.c (remote_target::remote_parse_stop_reply): Use
11880         unique_xmalloc_ptr.
11881
11882 2019-03-06  Tom Tromey  <tom@tromey.com>
11883
11884         * stabsread.c (struct stabs_field_info): Rename from field_info.
11885         <list, fnlist>: Add initializers.
11886         <obstack>: New member.
11887         (read_member_functions, read_struct_fields, read_baseclasses):
11888         Allocate on obstack.  Don't use cleanups.
11889         (read_one_struct_field, read_member_functions, read_struct_fields)
11890         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11891         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11892         (read_struct_type): Update.
11893
11894 2019-03-06  Tom Tromey  <tom@tromey.com>
11895
11896         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11897         * common/filestuff.h (make_cleanup_close): Don't declare.
11898         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11899         Remove.
11900
11901 2019-03-06  Tom Tromey  <tom@tromey.com>
11902
11903         * solib-aix.c: Use make_scope_exit.
11904
11905 2019-03-06  Tom Tromey  <tom@tromey.com>
11906
11907         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11908         Use make_scope_exit.
11909
11910 2019-03-06  Tom Tromey  <tom@tromey.com>
11911
11912         * solib-svr4.c (disable_probes_interface): Remove parameter.
11913         (svr4_handle_solib_event): Use make_scope_exit.
11914
11915 2019-03-06  Tom Tromey  <tom@tromey.com>
11916
11917         * remote.c (struct stop_reply_deleter): Remove.
11918         (stop_reply_up): Update.
11919         (struct stop_reply): Derive from notif_event.  Don't typedef.
11920         <regcache>: Now a std::vector.
11921         (stop_reply_xfree): Remove.
11922         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11923         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11924         (remote_target::discard_pending_stop_replies): Use delete.
11925         (remote_target::remote_parse_stop_reply): Update.
11926         (remote_target::process_stop_reply): Update.
11927         * remote-notif.h (struct notif_event): Add virtual destructor.
11928         Remove "dtr" member.
11929         (struct notif_client) <alloc_event>: Return a unique_ptr.
11930         (notif_event_xfree): Don't declare.
11931         (notif_event_up): New typedef.
11932         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11933         (notif_event_xfree, do_notif_event_xfree): Remove.
11934         (remote_notif_state_xfree): Update.
11935
11936 2019-03-06  Tom Tromey  <tom@tromey.com>
11937
11938         * infrun.c (displaced_step_clear_cleanup): Now a
11939         forward_scope_exit type.
11940         (displaced_step_prepare_throw): Update.
11941         (displaced_step_fixup): Update.
11942
11943 2019-03-06  Tom Tromey  <tom@tromey.com>
11944
11945         * inferior.h (class inferior): Update comment.
11946         * gdbthread.h (class thread_info): Update comment.
11947
11948 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11949             Tom Tromey  <tom@tromey.com>
11950
11951         * stabsread.h (struct stab_section_list): Remove.
11952         (coffstab_build_psymtabs): Update.
11953         * dbxread.c (symbuf_sections): Now a std::vector.
11954         (sect_idx): New global.
11955         (fill_symbuf): Update.
11956         (coffstab_build_psymtabs): Change type of stabsects parameter.
11957         Update.
11958         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11959         std::vector.
11960         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11961         (coff_locate_sections): Update.
11962         (coff_symfile_read): Remove cleanups.  Update.
11963         (init_stringtab): Add storage parameter.
11964         (free_stringtab, free_stringtab_cleanup): Remove.
11965         (init_lineno): Add storage parameter.
11966         (free_linetab, free_linetab_cleanup): Remove.
11967
11968 2019-03-06  Pedro Alves  <palves@redhat.com>
11969
11970         * linux-fork.c (fork_info::clobber_regs): Delete.
11971         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11972         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11973         comment.  Adjust.
11974         (scoped_switch_fork_info::scoped_switch_fork_info)
11975         (checkpoint_command, linux_fork_context): Adjust
11976         fork_save_infrun_state calls.
11977
11978 2019-03-06  Pedro Alves  <palves@redhat.com>
11979
11980         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11981         (inf_has_multiple_threads): Return 'bool' and rewrite using
11982         inferior_info::threads().
11983
11984 2019-03-06  Pedro Alves  <palves@redhat.com>
11985
11986         * linux-fork.c: Include <list>.
11987         (fork_list): Now a std::list instance.
11988         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11989         (forks_exist_p, find_last_fork): Adjust.
11990         (new_fork): Delete.
11991         (one_fork_p): New.
11992         (add_fork): Adjust.
11993         (free_fork): Delete, folded into fork_info::~fork_info().
11994         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11995         Adjust.
11996         (init_fork_list): Delete.
11997         (linux_fork_killall, linux_fork_mourn_inferior)
11998         (linux_fork_detach, info_checkpoints_command): Adjust.
11999         (_initialize_linux_fork): No longer call init_fork_list.
12000
12001 2019-03-06  Pedro Alves  <palves@redhat.com>
12002
12003         * linux-fork.c (new_fork): New, split out of ...
12004         (add_fork): ... this.  Return void.  Move "first fork" special
12005         case from here, to ...
12006         (checkpoint_command): ... here.
12007         * linux-linux.h (add_fork): Return void.
12008
12009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12010
12011         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12012
12013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12014             Chris January  <chris.january@arm.com>
12015             David Lecomber  <david.lecomber@arm.com>
12016
12017         * f-exp.y: New token, UNOP_INTRINSIC.
12018         (exp): New pattern using UNOP_INTRINSIC token.
12019         (f77_keywords): Add 'abs' keyword.
12020         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12021         (value_from_host_double): New function.
12022         (evaluate_subexp_f): Support UNOP_ABS.
12023
12024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12025
12026         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12027         types.
12028
12029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12030
12031         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12032         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12033         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12034
12035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12036
12037         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12038
12039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12040             Chris January  <chris.january@arm.com>
12041
12042         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12043         * f-exp.y: Define 'KIND' token.
12044         (exp): New pattern for KIND expressions.
12045         (ptype): Handle types with a kind extension.
12046         (direct_abs_decl): Extend to spot kind extensions.
12047         (f77_keywords): Add 'kind' to the list.
12048         (push_kind_type): New function.
12049         (convert_to_kind_type): New function.
12050         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12051         * parse.c (operator_length_standard): Likewise.
12052         * parser-defs.h (enum type_pieces): Add tp_kind.
12053         * std-operator.def: Add UNOP_KIND.
12054
12055 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12056
12057         * f-exp.y (f_parse): Set yydebug.
12058
12059 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12060
12061         * f-lang.c (evaluate_subexp_f): New function.
12062         (exp_descriptor_f): New global.
12063         (f_language_defn): Use exp_descriptor_f instead of
12064         exp_descriptor_standard.
12065
12066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12067
12068         * f-exp.y (struct token): Add comments.
12069         (dot_ops): Remove uppercase versions and the end marker.
12070         (f77_keywords): Likewise.
12071         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12072         entries in the dot_ops array are case insensitive, and use
12073         strncasecmp to compare strings.  Also some whitespace cleanup in
12074         this area.  Similar for the f77_keywords array, except entries in
12075         this list might be case sensitive.
12076
12077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12078
12079         * f-exp.y (struct f77_boolean_val): Add comments.
12080         (boolean_values): Remove uppercase versions, and end marker.
12081         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12082         and use strncasecmp to achieve case insensitivity.  Additionally,
12083         perform whitespace cleanup around this code.
12084
12085 2019-03-06  Tom Tromey  <tromey@adacore.com>
12086
12087         * remote-sim.c (gdbsim_target_open): Use result of
12088         gdb_argv::release.
12089
12090 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12091         Dirk Schubert  <dirk.schubert@arm.com>
12092         Chris January  <chris.january@arm.com>
12093
12094         * eval.c (evaluate_subexp_standard): Call Fortran argument
12095         wrapping logic.
12096         * f-lang.c (struct value): A value which can be passed into a
12097         Fortran function call.
12098         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12099         where appropriate.
12100         (struct type): Value ready for a Fortran function call.
12101         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12102         is needed.
12103         * f-lang.h (fortran_argument_convert): Declaration.
12104         (fortran_preserve_arg_pointer): Declaration.
12105         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12106
12107 2019-03-05  Tom Tromey  <tromey@adacore.com>
12108
12109         * python/py-prettyprint.c (print_string_repr): Remove #if.
12110         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12111
12112 2019-03-05  Tom Tromey  <tromey@adacore.com>
12113
12114         * target.c (the_dummy_target): Move later.  Change type to
12115         "dummy_target".
12116         (initialize_targets): Don't initialize the_dummy_target.
12117
12118 2019-03-05  Tom Tromey  <tromey@adacore.com>
12119
12120         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12121         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12122
12123 2019-03-05  Tom Tromey  <tromey@adacore.com>
12124
12125         * windows-nat.c (windows_nat_target::attach)
12126         (windows_nat_target::detach): Don't call gdb_flush.
12127         * valprint.c (generic_val_print, val_print, val_print_string):
12128         Don't call gdb_flush.
12129         * utils.c (defaulted_query): Don't call gdb_flush.
12130         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12131         * target.c (target_announce_detach): Don't call gdb_flush.
12132         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12133         * remote.c (extended_remote_target::attach): Don't call
12134         gdb_flush.
12135         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12136         * printcmd.c (do_examine): Don't call gdb_flush.
12137         (info_display_command): Don't call gdb_flush.
12138         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12139         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12140         * memattr.c (info_mem_command): Don't call gdb_flush.
12141         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12142         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12143         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12144         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12145         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12146         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12147         (gnu_nat_target::detach): Don't call gdb_flush.
12148         * f-valprint.c (f_val_print): Don't call gdb_flush.
12149         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12150         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12151         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12152         gdb_flush.
12153         * c-valprint.c (c_val_print): Don't call gdb_flush.
12154         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12155
12156 2019-03-05  Tom Tromey  <tromey@adacore.com>
12157
12158         * varobj.c (update_dynamic_varobj_children): Update.
12159         (install_default_visualizer): Use reset, not release.
12160         * value.c (set_internalvar): Update.
12161         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12162         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12163         ATTRIBUTE_UNUSED_RESULT.
12164
12165 2019-03-05  Tom Tromey  <tromey@adacore.com>
12166
12167         * remote.c (class scoped_remote_fd) <release>: Add
12168         ATTRIBUTE_UNUSED_RESULT.
12169
12170 2019-03-05  Tom Tromey  <tromey@adacore.com>
12171
12172         * macroexp.c (struct macro_buffer) <release>: Add
12173         ATTRIBUTE_UNUSED_RESULT.
12174
12175 2019-03-05  Tom Tromey  <tromey@adacore.com>
12176
12177         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12178         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12179         ATTRIBUTE_UNUSED_RESULT.
12180
12181 2019-03-05  Tom Tromey  <tromey@adacore.com>
12182
12183         * common/scoped_fd.h (class scoped_fd) <release>: Add
12184         ATTRIBUTE_UNUSED_RESULT.
12185
12186 2019-03-05  Tom Tromey  <tromey@adacore.com>
12187
12188         * parser-defs.h (struct parser_state) <release>: Add
12189         ATTRIBUTE_UNUSED_RESULT.
12190
12191 2019-03-05  Tom Tromey  <tromey@adacore.com>
12192
12193         * utils.h (class gdb_argv) <release>: Add
12194         ATTRIBUTE_UNUSED_RESULT.
12195         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12196
12197 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12198
12199         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12200         for-loop range, to avoid compiler warnings.
12201
12202         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12203         avoid compiler warnings about unused variables.
12204
12205         * NEWS: Mention end of support for native debugging on MS-Windows
12206         before XP.
12207
12208         PR gdb/24292
12209         * common/netstuff.c:
12210         * gdbserver/gdbreplay.c
12211         * gdbserver/remote-utils.c:
12212         * ser-tcp.c:
12213         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12214         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12215         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12216         'getaddrinfo' and 'freeaddrinfo' were not available before
12217         Windows XP, and mingw.org's MinGW headers by default define
12218         _WIN32_WINNT to 0x500.
12219
12220 2019-03-01  Gary Benson <gbenson@redhat.com>
12221
12222         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12223
12224 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12225             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12226
12227         PR gdb/8527
12228         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12229         set_sigint_trap, clear_sigint_trap.
12230
12231 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12232
12233         * target.c (target_detach): Clear the regcache and the
12234         frame cache.
12235
12236 2019-02-27  Pedro Alves  <palves@redhat.com>
12237
12238         * utils.c (set_screen_size): When we cap the height/width sizes,
12239         tweak the corresponding command variable to show "unlimited":
12240
12241 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12242             Pedro Alves  <palves@redhat.com>
12243
12244         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12245         before calling rl_set_screen_size.
12246
12247 2019-02-27  Tom Tromey  <tromey@adacore.com>
12248
12249         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12250         define.
12251         * python/py-value.c: Remove Python 2.4 workaround.
12252         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12253         workaround.
12254         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12255         Python 2.4 workaround.
12256         * python/python-internal.h: Remove Python 2.4 comment.
12257         (Py_ssize_t): Don't define.
12258         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12259         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12260         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12261         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12262         * python/python.c (do_start_initialization): Remove Python 2.4
12263         workaround.
12264         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12265         (print_children): Remove Python 2.4 workaround.
12266         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12267         workaround.
12268         (CHARBUFFERPROC_NAME): Remove.
12269         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12270         Python 2.4 workaround.
12271
12272 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12273
12274         * NEWS: Note minimum Python version.
12275
12276 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12277
12278         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12279         code from these functions.  Remove corresponding ifdefs.  Use
12280         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12281         Remove gotos and target of gotos.
12282         (infpy_search_memory): Likewise.
12283
12284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12285
12286         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12287         (hppa_gdbarch_init): Don't register deleted functions with
12288         gdbarch.
12289
12290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12291
12292         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12293         (h8300_unwind_sp): Delete.
12294         (h8300_dummy_id): Delete.
12295         (h8300_gdbarch_init): Don't register deleted functions with
12296         gdbarch.
12297
12298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12299
12300         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12301         (ft32_unwind_pc): Delete.
12302         (ft32_unwind_sp): Delete.
12303         (ft32_gdbarch_init): Don't register deleted functions with
12304         gdbarch.
12305
12306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12307
12308         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12309         (frv_unwind_pc): Delete.
12310         (frv_unwind_sp): Delete.
12311         (frv_gdbarch_init): Don't register deleted functions with
12312         gdbarch.
12313
12314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12315
12316         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12317         (riscv_unwind_pc): Delete.
12318         (riscv_unwind_sp): Delete.
12319         (riscv_gdbarch_init): Don't register deleted functions with
12320         gdbarch.
12321
12322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12323
12324         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12325         (csky_unwind_pc): Delete.
12326         (csky_unwind_sp): Delete.
12327         (csky_gdbarch_init): Don't register deleted functions with
12328         gdbarch.
12329
12330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12331
12332         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12333         (cris_unwind_pc): Delete.
12334         (cris_unwind_sp): Delete.
12335         (cris_gdbarch_init): Don't register deleted functions with
12336         gdbarch.
12337
12338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12339
12340         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12341         (bfin_unwind_pc): Delete.
12342         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12343
12344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12345
12346         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12347         (arm_unwind_pc): Delete.
12348         (arm_unwind_sp): Delete.
12349         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12350
12351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12352
12353         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12354         (arc_unwind_pc): Delete.
12355         (arc_unwind_sp): Delete.
12356         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12357
12358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12359
12360         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12361         (alpha_unwind_pc): Delete.
12362         (alpha_gdbarch_init): Don't register deleted functions with
12363         gdbarch.
12364
12365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12366
12367         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12368         (aarch64_unwind_pc): Delete.
12369         (aarch64_unwind_sp): Delete.
12370         (aarch64_gdbarch_init): Don't register deleted functions with
12371         gdbarch.
12372
12373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12374
12375         * gdbtypes.c (type_align): Don't consider static members when
12376         computing structure alignment.
12377
12378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12379
12380         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12381         return 0 for other types.
12382         * arch-utils.c (default_type_align): Always return 0.
12383         * gdbarch.h: Regenerate.
12384         * gdbarch.sh (type_align): Extend comment.
12385         * gdbtypes.c (type_align): Add additional comments, always call
12386         gdbarch_type_align before applying the default rules.
12387         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12388         generic code will then apply a suitable default.
12389         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12390         types, return 0 for other types.
12391
12392 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12393
12394         * NEWS: Create a new section for the next release branch.
12395         Rename the section of the current branch, now that it has
12396         been cut.
12397
12398 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12399
12400         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12401         * version.in: Bump version to 8.3.50.DATE-git.
12402
12403 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12404
12405         * aix-thread.c (ptid_cmp): Remove unused variable.
12406         (get_signaled_thread): Likewise.
12407         (store_regs_user_thread): Likewise.
12408         (store_regs_kernel_thread): Likewise.
12409         (fetch_regs_kernel_thread): Remove shadowed variable.
12410
12411 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12412
12413         * features/riscv/32bit-cpu.xml: Add register numbers.
12414         * features/riscv/32bit-fpu.c: Regenerate.
12415         * features/riscv/32bit-fpu.xml: Add register numbers.
12416         * features/riscv/64bit-cpu.xml: Add register numbers.
12417         * features/riscv/64bit-fpu.c: Regenerate.
12418         * features/riscv/64bit-fpu.xml: Add register numbers.
12419
12420 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12421
12422         * NEWS: Mention two argument form of gdb.Value constructor.
12423         * python/py-value.c (convert_buffer_and_type_to_value): New
12424         function.
12425         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12426         Add support for handling an optional second argument.  Call
12427         convert_buffer_and_type_to_value as appropriate.
12428         * python/python-internal.h (Py_buffer_deleter): New struct.
12429         (Py_buffer_up): New typedef.
12430
12431 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12432
12433         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12434         instead of releasing ownership.
12435
12436 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12437
12438         * dwarf2read.c (open_and_init_dwp_file): Call
12439         elf_numsections instead of bfd_count_sections to initialize
12440         dwp_file->num_sections.
12441
12442 2019-02-25  Tom Tromey  <tromey@adacore.com>
12443
12444         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12445
12446 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12447
12448         * gcore.in: Add '--readnever' option when invoking GDB.
12449
12450 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12451
12452         * MAINTAINERS: Update my email address.
12453
12454 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12455
12456         * build-id.c (build_id_to_debug_bfd_1): New function.
12457         (build_id_to_debug_bfd): Look for separate debug file in
12458         sysroot.
12459
12460 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12461
12462         * gdbarch.sh: Update the copyright year range that is placed into
12463         generated files.
12464
12465 2019-02-22  Keith Seitz  <keiths@redhat.com>
12466
12467         PR symtab/23853
12468         * linespec.c (create_sals_line_offset): Search for the default
12469         symtab's filename instead of its fullname.
12470
12471 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12472
12473         * NEWS: Update style defaults.
12474
12475 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12476
12477         * main.c (captured_main_1): Disable styling in batch mode.
12478
12479 2019-02-20  Tom Tromey  <tom@tromey.com>
12480
12481         * symtab.c (symtab_symbol_info): Fix typos.
12482
12483 2019-02-20  Tom Tromey  <tromey@adacore.com>
12484
12485         * findcmd.c (_initialize_mem_search): Use upper case for
12486         metasyntactic variables.
12487
12488 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12489
12490         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12491         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12492
12493 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12494
12495         * top.h (source_file_name): Change to std::string.
12496         * top.c (source_file_name): Likewise.
12497         (command_line_input): Adjust.
12498         * cli/cli-script.c (script_from_file): Adjust.
12499
12500 2019-02-19  Tom Tromey  <tromey@adacore.com>
12501
12502         * ravenscar-thread.c
12503         (ravenscar_thread_target::update_thread_list): Don't call
12504         ada_build_task_list.
12505         * ada-lang.h (ada_build_task_list): Don't declare.
12506         * ada-tasks.c (struct ada_tasks_inferior_data)
12507         <task_list_valid_p>: Now bool.
12508         (read_known_tasks, ada_task_list_changed)
12509         (ada_tasks_invalidate_inferior_data): Update.
12510         (read_known_tasks_array): Return bool.
12511         (read_known_tasks_list): Likewise.
12512         (read_known_tasks): Return void.
12513         (ada_build_task_list): Now static.
12514
12515 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12516
12517         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12518         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12519
12520 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12521
12522         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12523         variant for ada_tasks_pspace_data_handle and
12524         ada_tasks_inferior_data_handle.
12525         (ada_tasks_pspace_data_cleanup): New function.
12526         (ada_tasks_inferior_data_cleanup): New function.
12527
12528 2019-02-17  Tom Tromey  <tom@tromey.com>
12529
12530         * macrotab.h (macro_source_fullname): Return a std::string.
12531         * macrotab.c (macro_include, check_for_redefinition)
12532         (macro_undef, macro_lookup_definition, foreach_macro)
12533         (foreach_macro_in_scope): Update.
12534         (macro_source_fullname): Return a std::string.
12535         * macrocmd.c (show_pp_source_pos): Update.
12536
12537 2019-02-17  Tom Tromey  <tom@tromey.com>
12538
12539         * macrocmd.c (show_pp_source_pos): Style the file names.
12540
12541 2019-02-17  Tom Tromey  <tom@tromey.com>
12542
12543         PR tui/24197:
12544         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12545
12546 2019-02-17  Tom Tromey  <tom@tromey.com>
12547
12548         * ada-lang.c (user_select_syms): Use filtered printing.
12549         * utils.c (wrap_style): New global.
12550         (desired_style): Remove.
12551         (emit_style_escape): Add stream parameter.
12552         (set_output_style, reset_terminal_style, prompt_for_continue):
12553         Update.
12554         (flush_wrap_buffer): Only flush gdb_stdout.
12555         (wrap_here): Set wrap_style.
12556         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12557         treat escape sequences as a character.  Change when wrap buffer is
12558         flushed.
12559         (fputs_styled): Do not set the output style when the default is
12560         requested.
12561         * ui-style.h (struct ui_file_style) <is_default>: New method.
12562         * source.c (print_source_lines_base): Emit escape sequences in one
12563         piece.
12564
12565 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12566
12567         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12568         integers and enumeration types.
12569
12570 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12571
12572         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12573         instead of lookup_symbol_in_language
12574         (do_exact_match): New function.
12575         (ada_get_symbol_name_matcher): Return do_exact_match when
12576         doing a verbatim match.
12577
12578 2019-02-15  Tom Tromey  <tromey@adacore.com>
12579
12580         * ravenscar-thread.c (ravenscar_thread_target::resume)
12581         (ravenscar_thread_target::wait): Special case wildcard requests.
12582
12583 2019-02-15  Tom Tromey  <tromey@adacore.com>
12584
12585         * ravenscar-thread.c (base_ptid): Remove.
12586         (struct ravenscar_thread_target) <close>: New method.
12587         <m_base_ptid>: New member.
12588         <update_inferior_ptid, active_task, task_is_currently_active,
12589         runtime_initialized>: Declare methods.
12590         <ravenscar_thread_target>: Add constructor.
12591         (ravenscar_thread_target::task_is_currently_active)
12592         (ravenscar_thread_target::update_inferior_ptid)
12593         (ravenscar_runtime_initialized): Rename.  Now methods.
12594         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12595         (ravenscar_thread_target::update_thread_list): Update.
12596         (ravenscar_thread_target::active_task): Now method.
12597         (ravenscar_thread_target::store_registers)
12598         (ravenscar_thread_target::prepare_to_store)
12599         (ravenscar_thread_target::prepare_to_store)
12600         (ravenscar_thread_target::mourn_inferior): Update.
12601         (ravenscar_inferior_created): Use "new" to create target.
12602         (ravenscar_thread_target::get_ada_task_ptid): Update.
12603         (_initialize_ravenscar): Don't initialize base_ptid.
12604         (ravenscar_ops): Remove global.
12605
12606 2019-02-15  Tom Tromey  <tromey@adacore.com>
12607
12608         * target.h (push_target): Declare new overload.
12609         * target.c (push_target): New overload, taking an rvalue reference.
12610         * remote.c (remote_target::open_1): Use push_target overload.
12611         * corelow.c (core_target_open): Use push_target overload.
12612
12613 2019-02-15  Tom Tromey  <tromey@adacore.com>
12614
12615         * ravenscar-thread.c (is_ravenscar_task)
12616         (ravenscar_task_is_currently_active): Return bool.
12617         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12618         (_initialize_ravenscar): Remove "(void)".
12619         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12620         Return bool.
12621
12622 2019-02-15  Tom Tromey  <tromey@adacore.com>
12623
12624         * ravenscar-thread.c (ravenscar_runtime_initializer)
12625         (has_ravenscar_runtime, get_running_thread_id)
12626         (ravenscar_thread_target::resume): Fix indentation.
12627
12628 2019-02-15  Tom Tromey  <tromey@adacore.com>
12629
12630         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12631         from ravenscar_arch_ops.
12632         (sparc_ravenscar_ops::fetch_registers)
12633         (sparc_ravenscar_ops::store_registers): Now methods.
12634         (sparc_ravenscar_prepare_to_store): Remove.
12635         (sparc_ravenscar_ops): Redefine.
12636         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12637         methods and destructor.  Remove members.
12638         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12639         (ravenscar_thread_target::store_registers)
12640         (ravenscar_thread_target::prepare_to_store): Update.
12641         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12642         Remove.
12643         (struct ppc_ravenscar_powerpc_ops): Derive from
12644         ravenscar_arch_ops.
12645         (ppc_ravenscar_powerpc_ops::fetch_registers)
12646         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12647         (ppc_ravenscar_powerpc_ops): Redefine.
12648         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12649         (ppc_ravenscar_e500_ops::fetch_registers)
12650         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12651         (ppc_ravenscar_e500_ops): Redefine.
12652         * aarch64-ravenscar-thread.c
12653         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12654         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12655         (aarch64_ravenscar_fetch_registers)
12656         (aarch64_ravenscar_store_registers): Now methods.
12657         (aarch64_ravenscar_ops): Redefine.
12658
12659 2019-02-15  Tom Tromey  <tromey@adacore.com>
12660
12661         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12662         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12663         (ravenscar_thread_target::stopped_by_watchpoint)
12664         (ravenscar_thread_target::stopped_data_address)
12665         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12666
12667 2019-02-15  Tom Tromey  <tromey@adacore.com>
12668
12669         * ravenscar-thread.c: Fix some typos.
12670
12671 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12672             Tom Tromey  <tromey@adacore.com>
12673
12674         * ada-lang.c (ada_exception_sal): Change addr_string to a
12675         std::string.
12676         (create_ada_exception_catchpoint): Update.
12677
12678 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12679             Tom Tromey  <tromey@adacore.com>
12680
12681         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12682         (bp_location_ops): Remove.
12683         (base_breakpoint_allocate_location): Update.
12684         (free_bp_location): Update.
12685         * ada-lang.c (class ada_catchpoint_location)
12686         <ada_catchpoint_location>: Remove ops parameter.
12687         (ada_catchpoint_location_dtor): Remove.
12688         (ada_catchpoint_location_ops): Remove.
12689         (allocate_location_exception): Update.
12690         * breakpoint.h (struct bp_location_ops): Remove.
12691         (class bp_location) <bp_location>: Remove bp_location_ops
12692         parameter.
12693         <~bp_location>: Add destructor.
12694         <ops>: Remove.
12695
12696 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12697             Pedro Alves  <palves@redhat.com>
12698
12699         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12700         'PATH_MAX'.
12701
12702 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12703             Samuel Thibault  <samuel.thibault@gnu.org>
12704             Thomas Schwinge  <thomas@codesourcery.com>
12705
12706         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12707         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12708
12709 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12710
12711         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12712         (check_empty): Use "const char *".
12713
12714         * gnu-nat.c (gnu_nat_target::detach): Instead of
12715         'detach_inferior (pid)' call
12716         'detach_inferior (find_inferior_pid (pid))'.
12717
12718         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12719         'nat/fork-inferior.o'.
12720         * gnu-nat.c: #include "nat/fork-inferior.h".
12721
12722         * gnu-nat.c (gnu_nat_target::detach): Instead of
12723         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12724         * gnu-nat.h: #include "inf-child.h".
12725         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12726         'i386_gnu_nat_target::fetch_registers'.
12727         (gnu_store_registers): Rename/move to
12728         'i386_gnu_nat_target::store_registers'.
12729
12730         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12731         * gnu-nat.h (mach_thread_info): New function.
12732         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12733
12734         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12735
12736 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12737
12738         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12739
12740 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12741
12742         * windows-nat.c (windows_add_thread): Add new parameter
12743         "main_thread_p" with default value set to false.  Update
12744         function documentation as well as all callers.
12745         (windows_delete_thread): Likewise.
12746         (fake_create_process): Update call to windows_add_thread.
12747         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12748         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12749         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12750         call to windows_delete_thread.
12751
12752 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12753
12754         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12755
12756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12757
12758         * symfile.c (find_separate_debug_file): Use canonical path of
12759         sysroot with child_path instead of gdb_sysroot if it is valid.
12760
12761 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12762
12763         * symfile.c (find_separate_debug_file): Use child_path to
12764         determine if an object file is under a sysroot.
12765
12766 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12767
12768         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12769         unittests/child-path-selftests.c.
12770         * common/pathstuff.c (child_path): New function.
12771         * common/pathstuff.h (child_path): New prototype.
12772         * unittests/child-path-selftests.c: New file.
12773
12774 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12775
12776         * symfile.c (find_separate_debug_file): Look for separate debug
12777         files in debug directories under the sysroot.
12778
12779 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12780
12781         * symtab.h (struct minimal_symbol data_p): New const method.
12782         (struct minimal_symbol text_p): Likewise.
12783         * symtab.c (output_source_filename): Use file name style
12784         to print file name.
12785         (print_symbol_info): Likewise.
12786         (print_msymbol_info): Use address style to print addresses.
12787         Use function name style to print executable text symbols.
12788         (expand_symtab_containing_pc): Use data_p.
12789         (find_pc_sect_compunit_symtab): Likewise.
12790
12791 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12792
12793         * breakpoint.c (describe_other_breakpoints): Use address style
12794         to print addresses.
12795         (say_where): Likewise.
12796
12797 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12798
12799         * ada-typeprint.c (print_func_type): Print function name
12800         style to print function name.
12801         * c-typeprint.c (c_print_type_1): Likewise.
12802
12803 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12804
12805         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12806         for execve.
12807
12808 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12809
12810         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12811         type_stack.
12812
12813 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12814
12815         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12816         TYPE_CODE_REF types.
12817
12818 2019-02-08  Jim Wilson  <jimw@sifive.com>
12819
12820         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12821         (riscv_linux_fregset): New.
12822         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12823
12824 2019-02-07  Tom Tromey  <tom@tromey.com>
12825
12826         * thread.c (thread_cancel_execution_command): Update.
12827         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12828         methods.
12829         (struct thread_fsm_ops): Remove.
12830         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12831         (thread_fsm_should_stop, thread_fsm_return_value)
12832         (thread_fsm_set_finished, thread_fsm_finished_p)
12833         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12834         Don't declare.
12835         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12836         * infrun.c (clear_proceed_status_thread)
12837         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12838         (print_stop_event): Update.
12839         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12840         Add constructor.
12841         (step_command_fsm_ops): Remove.
12842         (new_step_command_fsm): Remove.
12843         (step_1): Update.
12844         (step_command_fsm::should_stop): Rename from
12845         step_command_fsm_should_stop.
12846         (step_command_fsm::clean_up): Rename from
12847         step_command_fsm_clean_up.
12848         (step_command_fsm::do_async_reply_reason): Rename from
12849         step_command_fsm_async_reply_reason.
12850         (struct until_next_fsm): Inherit from thread_fsm.  Add
12851         constructor.
12852         (until_next_fsm_ops): Remove.
12853         (new_until_next_fsm): Remove.
12854         (until_next_fsm::should_stop): Rename from
12855         until_next_fsm_should_stop.
12856         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12857         (until_next_fsm::do_async_reply_reason): Rename from
12858         until_next_fsm_async_reply_reason.
12859         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12860         constructor.  Change type of breakpoint.
12861         (finish_command_fsm_ops): Remove.
12862         (new_finish_command_fsm): Remove.
12863         (finish_command_fsm::should_stop): Rename from
12864         finish_command_fsm_should_stop.
12865         (finish_command_fsm::clean_up): Rename from
12866         finish_command_fsm_clean_up.
12867         (finish_command_fsm::return_value): Rename from
12868         finish_command_fsm_return_value.
12869         (finish_command_fsm::do_async_reply_reason): Rename from
12870         finish_command_fsm_async_reply_reason.
12871         (finish_command): Update.
12872         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12873         Add constructor.
12874         (call_thread_fsm_ops): Remove.
12875         (call_thread_fsm::call_thread_fsm): Rename from
12876         new_call_thread_fsm.
12877         (call_thread_fsm::should_stop): Rename from
12878         call_thread_fsm_should_stop.
12879         (call_thread_fsm::should_notify_stop): Rename from
12880         call_thread_fsm_should_notify_stop.
12881         (run_inferior_call, call_function_by_hand_dummy): Update.
12882         * cli/cli-interp.c (should_print_stop_to_console): Update.
12883         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12884         Add constructor.  Change type of location_breakpoint,
12885         caller_breakpoint.
12886         (until_break_fsm_ops): Remove.
12887         (new_until_break_fsm): Remove.
12888         (until_break_fsm::should_stop): Rename from
12889         until_break_fsm_should_stop.
12890         (until_break_fsm::clean_up): Rename from
12891         until_break_fsm_clean_up.
12892         (until_break_fsm::do_async_reply_reason): Rename from
12893         until_break_fsm_async_reply_reason.
12894         (until_break_command): Update.
12895         * thread-fsm.c: Remove.
12896         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12897
12898 2019-02-07  Tom Tromey  <tom@tromey.com>
12899
12900         * yy-remap.h: Add include guard.
12901         * xtensa-tdep.h: Add include guard.
12902         * xcoffread.h: Rename include guard.
12903         * varobj-iter.h: Add include guard.
12904         * tui/tui.h: Rename include guard.
12905         * tui/tui-winsource.h: Rename include guard.
12906         * tui/tui-wingeneral.h: Rename include guard.
12907         * tui/tui-windata.h: Rename include guard.
12908         * tui/tui-win.h: Rename include guard.
12909         * tui/tui-stack.h: Rename include guard.
12910         * tui/tui-source.h: Rename include guard.
12911         * tui/tui-regs.h: Rename include guard.
12912         * tui/tui-out.h: Rename include guard.
12913         * tui/tui-layout.h: Rename include guard.
12914         * tui/tui-io.h: Rename include guard.
12915         * tui/tui-hooks.h: Rename include guard.
12916         * tui/tui-file.h: Rename include guard.
12917         * tui/tui-disasm.h: Rename include guard.
12918         * tui/tui-data.h: Rename include guard.
12919         * tui/tui-command.h: Rename include guard.
12920         * tic6x-tdep.h: Add include guard.
12921         * target/waitstatus.h: Rename include guard.
12922         * target/wait.h: Rename include guard.
12923         * target/target.h: Rename include guard.
12924         * target/resume.h: Rename include guard.
12925         * target-float.h: Rename include guard.
12926         * stabsread.h: Add include guard.
12927         * rs6000-tdep.h: Add include guard.
12928         * riscv-fbsd-tdep.h: Add include guard.
12929         * regformats/regdef.h: Rename include guard.
12930         * record.h: Rename include guard.
12931         * python/python.h: Rename include guard.
12932         * python/python-internal.h: Rename include guard.
12933         * python/py-stopevent.h: Rename include guard.
12934         * python/py-ref.h: Rename include guard.
12935         * python/py-record.h: Rename include guard.
12936         * python/py-record-full.h: Rename include guard.
12937         * python/py-record-btrace.h: Rename include guard.
12938         * python/py-instruction.h: Rename include guard.
12939         * python/py-events.h: Rename include guard.
12940         * python/py-event.h: Rename include guard.
12941         * procfs.h: Add include guard.
12942         * proc-utils.h: Add include guard.
12943         * p-lang.h: Add include guard.
12944         * or1k-tdep.h: Rename include guard.
12945         * observable.h: Rename include guard.
12946         * nto-tdep.h: Rename include guard.
12947         * nat/x86-linux.h: Rename include guard.
12948         * nat/x86-linux-dregs.h: Rename include guard.
12949         * nat/x86-gcc-cpuid.h: Add include guard.
12950         * nat/x86-dregs.h: Rename include guard.
12951         * nat/x86-cpuid.h: Rename include guard.
12952         * nat/ppc-linux.h: Rename include guard.
12953         * nat/mips-linux-watch.h: Rename include guard.
12954         * nat/linux-waitpid.h: Rename include guard.
12955         * nat/linux-ptrace.h: Rename include guard.
12956         * nat/linux-procfs.h: Rename include guard.
12957         * nat/linux-osdata.h: Rename include guard.
12958         * nat/linux-nat.h: Rename include guard.
12959         * nat/linux-namespaces.h: Rename include guard.
12960         * nat/linux-btrace.h: Rename include guard.
12961         * nat/glibc_thread_db.h: Rename include guard.
12962         * nat/gdb_thread_db.h: Rename include guard.
12963         * nat/gdb_ptrace.h: Rename include guard.
12964         * nat/fork-inferior.h: Rename include guard.
12965         * nat/amd64-linux-siginfo.h: Rename include guard.
12966         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12967         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12968         * nat/aarch64-linux.h: Rename include guard.
12969         * nat/aarch64-linux-hw-point.h: Rename include guard.
12970         * mn10300-tdep.h: Add include guard.
12971         * mips-linux-tdep.h: Add include guard.
12972         * mi/mi-parse.h: Rename include guard.
12973         * mi/mi-out.h: Rename include guard.
12974         * mi/mi-main.h: Rename include guard.
12975         * mi/mi-interp.h: Rename include guard.
12976         * mi/mi-getopt.h: Rename include guard.
12977         * mi/mi-console.h: Rename include guard.
12978         * mi/mi-common.h: Rename include guard.
12979         * mi/mi-cmds.h: Rename include guard.
12980         * mi/mi-cmd-break.h: Rename include guard.
12981         * m2-lang.h: Add include guard.
12982         * location.h: Rename include guard.
12983         * linux-record.h: Rename include guard.
12984         * linux-nat.h: Add include guard.
12985         * linux-fork.h: Add include guard.
12986         * i386-darwin-tdep.h: Rename include guard.
12987         * hppa-linux-offsets.h: Add include guard.
12988         * guile/guile.h: Rename include guard.
12989         * guile/guile-internal.h: Rename include guard.
12990         * gnu-nat.h: Rename include guard.
12991         * gdb-stabs.h: Rename include guard.
12992         * frv-tdep.h: Add include guard.
12993         * f-lang.h: Add include guard.
12994         * event-loop.h: Add include guard.
12995         * darwin-nat.h: Rename include guard.
12996         * cp-abi.h: Rename include guard.
12997         * config/sparc/nm-sol2.h: Rename include guard.
12998         * config/nm-nto.h: Rename include guard.
12999         * config/nm-linux.h: Add include guard.
13000         * config/i386/nm-i386gnu.h: Rename include guard.
13001         * config/djgpp/nl_types.h: Rename include guard.
13002         * config/djgpp/langinfo.h: Rename include guard.
13003         * compile/gcc-cp-plugin.h: Add include guard.
13004         * compile/gcc-c-plugin.h: Add include guard.
13005         * compile/compile.h: Rename include guard.
13006         * compile/compile-object-run.h: Rename include guard.
13007         * compile/compile-object-load.h: Rename include guard.
13008         * compile/compile-internal.h: Rename include guard.
13009         * compile/compile-cplus.h: Rename include guard.
13010         * compile/compile-c.h: Rename include guard.
13011         * common/xml-utils.h: Rename include guard.
13012         * common/x86-xstate.h: Rename include guard.
13013         * common/version.h: Rename include guard.
13014         * common/vec.h: Rename include guard.
13015         * common/tdesc.h: Rename include guard.
13016         * common/selftest.h: Rename include guard.
13017         * common/scoped_restore.h: Rename include guard.
13018         * common/scoped_mmap.h: Rename include guard.
13019         * common/scoped_fd.h: Rename include guard.
13020         * common/safe-iterator.h: Rename include guard.
13021         * common/run-time-clock.h: Rename include guard.
13022         * common/refcounted-object.h: Rename include guard.
13023         * common/queue.h: Rename include guard.
13024         * common/ptid.h: Rename include guard.
13025         * common/print-utils.h: Rename include guard.
13026         * common/preprocessor.h: Rename include guard.
13027         * common/pathstuff.h: Rename include guard.
13028         * common/observable.h: Rename include guard.
13029         * common/netstuff.h: Rename include guard.
13030         * common/job-control.h: Rename include guard.
13031         * common/host-defs.h: Rename include guard.
13032         * common/gdb_wait.h: Rename include guard.
13033         * common/gdb_vecs.h: Rename include guard.
13034         * common/gdb_unlinker.h: Rename include guard.
13035         * common/gdb_unique_ptr.h: Rename include guard.
13036         * common/gdb_tilde_expand.h: Rename include guard.
13037         * common/gdb_sys_time.h: Rename include guard.
13038         * common/gdb_string_view.h: Rename include guard.
13039         * common/gdb_splay_tree.h: Rename include guard.
13040         * common/gdb_setjmp.h: Rename include guard.
13041         * common/gdb_ref_ptr.h: Rename include guard.
13042         * common/gdb_optional.h: Rename include guard.
13043         * common/gdb_locale.h: Rename include guard.
13044         * common/gdb_assert.h: Rename include guard.
13045         * common/filtered-iterator.h: Rename include guard.
13046         * common/filestuff.h: Rename include guard.
13047         * common/fileio.h: Rename include guard.
13048         * common/environ.h: Rename include guard.
13049         * common/common-utils.h: Rename include guard.
13050         * common/common-types.h: Rename include guard.
13051         * common/common-regcache.h: Rename include guard.
13052         * common/common-inferior.h: Rename include guard.
13053         * common/common-gdbthread.h: Rename include guard.
13054         * common/common-exceptions.h: Rename include guard.
13055         * common/common-defs.h: Rename include guard.
13056         * common/common-debug.h: Rename include guard.
13057         * common/cleanups.h: Rename include guard.
13058         * common/buffer.h: Rename include guard.
13059         * common/btrace-common.h: Rename include guard.
13060         * common/break-common.h: Rename include guard.
13061         * cli/cli-utils.h: Rename include guard.
13062         * cli/cli-style.h: Rename include guard.
13063         * cli/cli-setshow.h: Rename include guard.
13064         * cli/cli-script.h: Rename include guard.
13065         * cli/cli-interp.h: Rename include guard.
13066         * cli/cli-decode.h: Rename include guard.
13067         * cli/cli-cmds.h: Rename include guard.
13068         * charset-list.h: Add include guard.
13069         * buildsym-legacy.h: Rename include guard.
13070         * bfin-tdep.h: Add include guard.
13071         * ax.h: Rename include guard.
13072         * arm-linux-tdep.h: Add include guard.
13073         * arm-fbsd-tdep.h: Add include guard.
13074         * arch/xtensa.h: Rename include guard.
13075         * arch/tic6x.h: Add include guard.
13076         * arch/i386.h: Add include guard.
13077         * arch/arm.h: Rename include guard.
13078         * arch/arm-linux.h: Rename include guard.
13079         * arch/arm-get-next-pcs.h: Rename include guard.
13080         * arch/amd64.h: Add include guard.
13081         * arch/aarch64-insn.h: Rename include guard.
13082         * arch-utils.h: Rename include guard.
13083         * annotate.h: Add include guard.
13084         * amd64-darwin-tdep.h: Rename include guard.
13085         * aarch64-linux-tdep.h: Add include guard.
13086         * aarch64-fbsd-tdep.h: Add include guard.
13087         * aarch32-linux-nat.h: Add include guard.
13088
13089 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13090
13091         * macrotab.c (macro_define_internal): New function that
13092         factorizes macro_define_object_internal and macro_define_function
13093         code.
13094         (macro_define_object_internal): Use macro_define_internal.
13095         (macro_define_function): Likewise.
13096
13097 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13098
13099         * macrocmd.c (extract_identifier): Return
13100         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13101         callers.
13102
13103 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13104
13105         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13106
13107 2019-02-05  Tom Tromey  <tom@tromey.com>
13108
13109         * target.c (target_stack::unpush): Move assertion earlier.
13110
13111 2019-01-30  Tom Tromey  <tom@tromey.com>
13112
13113         PR python/23615:
13114         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13115         (gdbpy_parse_and_eval): Likewise.
13116         * python/python-internal.h (gdbpy_allow_threads): New class.
13117
13118 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13119
13120         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13121         (aarch64_fbsd_fpregmap): Move earlier.
13122         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13123         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13124         instead of individual calls to trad_frame_set_reg_addr.
13125         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13126         earlier.
13127         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13128         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13129         instead of individual calls to trad_frame_set_reg_addr.
13130
13131 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13132
13133         * CONTRIBUTE: Replace contribution list with wiki link.
13134
13135 2019-01-25  Tom Tromey  <tom@tromey.com>
13136
13137         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13138
13139 2019-01-25  Tom Tromey  <tom@tromey.com>
13140
13141         * xtensa-linux-nat.c: Fix common/ includes.
13142         * xml-support.h: Fix common/ includes.
13143         * xml-support.c: Fix common/ includes.
13144         * x86-linux-nat.c: Fix common/ includes.
13145         * windows-nat.c: Fix common/ includes.
13146         * varobj.h: Fix common/ includes.
13147         * varobj.c: Fix common/ includes.
13148         * value.c: Fix common/ includes.
13149         * valops.c: Fix common/ includes.
13150         * utils.c: Fix common/ includes.
13151         * unittests/xml-utils-selftests.c: Fix common/ includes.
13152         * unittests/utils-selftests.c: Fix common/ includes.
13153         * unittests/unpack-selftests.c: Fix common/ includes.
13154         * unittests/tracepoint-selftests.c: Fix common/ includes.
13155         * unittests/style-selftests.c: Fix common/ includes.
13156         * unittests/string_view-selftests.c: Fix common/ includes.
13157         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13158         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13159         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13160         * unittests/rsp-low-selftests.c: Fix common/ includes.
13161         * unittests/parse-connection-spec-selftests.c: Fix common/
13162         includes.
13163         * unittests/optional-selftests.c: Fix common/ includes.
13164         * unittests/offset-type-selftests.c: Fix common/ includes.
13165         * unittests/observable-selftests.c: Fix common/ includes.
13166         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13167         * unittests/memrange-selftests.c: Fix common/ includes.
13168         * unittests/memory-map-selftests.c: Fix common/ includes.
13169         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13170         * unittests/function-view-selftests.c: Fix common/ includes.
13171         * unittests/environ-selftests.c: Fix common/ includes.
13172         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13173         * unittests/common-utils-selftests.c: Fix common/ includes.
13174         * unittests/cli-utils-selftests.c: Fix common/ includes.
13175         * unittests/array-view-selftests.c: Fix common/ includes.
13176         * ui-file.c: Fix common/ includes.
13177         * tui/tui-io.c: Fix common/ includes.
13178         * tracepoint.h: Fix common/ includes.
13179         * tracepoint.c: Fix common/ includes.
13180         * tracefile-tfile.c: Fix common/ includes.
13181         * top.h: Fix common/ includes.
13182         * top.c: Fix common/ includes.
13183         * thread.c: Fix common/ includes.
13184         * target/waitstatus.h: Fix common/ includes.
13185         * target/waitstatus.c: Fix common/ includes.
13186         * target.h: Fix common/ includes.
13187         * target.c: Fix common/ includes.
13188         * target-memory.c: Fix common/ includes.
13189         * target-descriptions.c: Fix common/ includes.
13190         * symtab.h: Fix common/ includes.
13191         * symfile.c: Fix common/ includes.
13192         * stap-probe.c: Fix common/ includes.
13193         * spu-linux-nat.c: Fix common/ includes.
13194         * sparc-nat.c: Fix common/ includes.
13195         * source.c: Fix common/ includes.
13196         * solib.c: Fix common/ includes.
13197         * solib-target.c: Fix common/ includes.
13198         * ser-unix.c: Fix common/ includes.
13199         * ser-tcp.c: Fix common/ includes.
13200         * ser-pipe.c: Fix common/ includes.
13201         * ser-base.c: Fix common/ includes.
13202         * selftest-arch.c: Fix common/ includes.
13203         * s12z-tdep.c: Fix common/ includes.
13204         * rust-exp.y: Fix common/ includes.
13205         * rs6000-aix-tdep.c: Fix common/ includes.
13206         * riscv-tdep.c: Fix common/ includes.
13207         * remote.c: Fix common/ includes.
13208         * remote-notif.h: Fix common/ includes.
13209         * remote-fileio.h: Fix common/ includes.
13210         * remote-fileio.c: Fix common/ includes.
13211         * regcache.h: Fix common/ includes.
13212         * regcache.c: Fix common/ includes.
13213         * record-btrace.c: Fix common/ includes.
13214         * python/python.c: Fix common/ includes.
13215         * python/py-type.c: Fix common/ includes.
13216         * python/py-inferior.c: Fix common/ includes.
13217         * progspace.h: Fix common/ includes.
13218         * producer.c: Fix common/ includes.
13219         * procfs.c: Fix common/ includes.
13220         * proc-api.c: Fix common/ includes.
13221         * printcmd.c: Fix common/ includes.
13222         * ppc-linux-nat.c: Fix common/ includes.
13223         * parser-defs.h: Fix common/ includes.
13224         * osdata.c: Fix common/ includes.
13225         * obsd-nat.c: Fix common/ includes.
13226         * nat/x86-linux.c: Fix common/ includes.
13227         * nat/x86-linux-dregs.c: Fix common/ includes.
13228         * nat/x86-dregs.h: Fix common/ includes.
13229         * nat/x86-dregs.c: Fix common/ includes.
13230         * nat/ppc-linux.c: Fix common/ includes.
13231         * nat/mips-linux-watch.h: Fix common/ includes.
13232         * nat/mips-linux-watch.c: Fix common/ includes.
13233         * nat/linux-waitpid.c: Fix common/ includes.
13234         * nat/linux-ptrace.h: Fix common/ includes.
13235         * nat/linux-ptrace.c: Fix common/ includes.
13236         * nat/linux-procfs.c: Fix common/ includes.
13237         * nat/linux-personality.c: Fix common/ includes.
13238         * nat/linux-osdata.c: Fix common/ includes.
13239         * nat/linux-namespaces.c: Fix common/ includes.
13240         * nat/linux-btrace.h: Fix common/ includes.
13241         * nat/linux-btrace.c: Fix common/ includes.
13242         * nat/fork-inferior.c: Fix common/ includes.
13243         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13244         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13245         * nat/aarch64-linux.c: Fix common/ includes.
13246         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13247         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13248         * namespace.h: Fix common/ includes.
13249         * mips-linux-tdep.c: Fix common/ includes.
13250         * minsyms.c: Fix common/ includes.
13251         * mi/mi-parse.h: Fix common/ includes.
13252         * mi/mi-main.c: Fix common/ includes.
13253         * mi/mi-cmd-env.c: Fix common/ includes.
13254         * memrange.h: Fix common/ includes.
13255         * memattr.c: Fix common/ includes.
13256         * maint.h: Fix common/ includes.
13257         * maint.c: Fix common/ includes.
13258         * main.c: Fix common/ includes.
13259         * machoread.c: Fix common/ includes.
13260         * location.c: Fix common/ includes.
13261         * linux-thread-db.c: Fix common/ includes.
13262         * linux-nat.c: Fix common/ includes.
13263         * linux-fork.c: Fix common/ includes.
13264         * inline-frame.c: Fix common/ includes.
13265         * infrun.c: Fix common/ includes.
13266         * inflow.c: Fix common/ includes.
13267         * inferior.h: Fix common/ includes.
13268         * inferior.c: Fix common/ includes.
13269         * infcmd.c: Fix common/ includes.
13270         * inf-ptrace.c: Fix common/ includes.
13271         * inf-child.c: Fix common/ includes.
13272         * ia64-linux-nat.c: Fix common/ includes.
13273         * i387-tdep.c: Fix common/ includes.
13274         * i386-tdep.c: Fix common/ includes.
13275         * i386-linux-tdep.c: Fix common/ includes.
13276         * i386-linux-nat.c: Fix common/ includes.
13277         * i386-go32-tdep.c: Fix common/ includes.
13278         * i386-fbsd-tdep.c: Fix common/ includes.
13279         * i386-fbsd-nat.c: Fix common/ includes.
13280         * guile/scm-type.c: Fix common/ includes.
13281         * guile/guile.c: Fix common/ includes.
13282         * go32-nat.c: Fix common/ includes.
13283         * gnu-nat.c: Fix common/ includes.
13284         * gdbthread.h: Fix common/ includes.
13285         * gdbarch-selftests.c: Fix common/ includes.
13286         * gdb_usleep.c: Fix common/ includes.
13287         * gdb_select.h: Fix common/ includes.
13288         * gdb_bfd.c: Fix common/ includes.
13289         * gcore.c: Fix common/ includes.
13290         * fork-child.c: Fix common/ includes.
13291         * findvar.c: Fix common/ includes.
13292         * fbsd-nat.c: Fix common/ includes.
13293         * event-top.c: Fix common/ includes.
13294         * event-loop.c: Fix common/ includes.
13295         * dwarf2read.c: Fix common/ includes.
13296         * dwarf2loc.c: Fix common/ includes.
13297         * dwarf2-frame.c: Fix common/ includes.
13298         * dwarf-index-cache.c: Fix common/ includes.
13299         * dtrace-probe.c: Fix common/ includes.
13300         * disasm-selftests.c: Fix common/ includes.
13301         * defs.h: Fix common/ includes.
13302         * csky-tdep.c: Fix common/ includes.
13303         * cp-valprint.c: Fix common/ includes.
13304         * cp-support.h: Fix common/ includes.
13305         * cp-support.c: Fix common/ includes.
13306         * corelow.c: Fix common/ includes.
13307         * completer.h: Fix common/ includes.
13308         * completer.c: Fix common/ includes.
13309         * compile/compile.c: Fix common/ includes.
13310         * compile/compile-loc2c.c: Fix common/ includes.
13311         * compile/compile-cplus-types.c: Fix common/ includes.
13312         * compile/compile-cplus-symbols.c: Fix common/ includes.
13313         * command.h: Fix common/ includes.
13314         * cli/cli-dump.c: Fix common/ includes.
13315         * cli/cli-cmds.c: Fix common/ includes.
13316         * charset.c: Fix common/ includes.
13317         * build-id.c: Fix common/ includes.
13318         * btrace.h: Fix common/ includes.
13319         * btrace.c: Fix common/ includes.
13320         * breakpoint.h: Fix common/ includes.
13321         * breakpoint.c: Fix common/ includes.
13322         * ax.h:
13323         (enum agent_op): Fix common/ includes.
13324         * ax-general.c (struct aop_map): Fix common/ includes.
13325         * ax-gdb.c: Fix common/ includes.
13326         * auxv.c: Fix common/ includes.
13327         * auto-load.c: Fix common/ includes.
13328         * arm-tdep.c: Fix common/ includes.
13329         * arch/riscv.c: Fix common/ includes.
13330         * arch/ppc-linux-common.c: Fix common/ includes.
13331         * arch/i386.c: Fix common/ includes.
13332         * arch/arm.c: Fix common/ includes.
13333         * arch/arm-linux.c: Fix common/ includes.
13334         * arch/arm-get-next-pcs.c: Fix common/ includes.
13335         * arch/amd64.c: Fix common/ includes.
13336         * arch/aarch64.c: Fix common/ includes.
13337         * arch/aarch64-insn.c: Fix common/ includes.
13338         * arch-utils.c: Fix common/ includes.
13339         * amd64-windows-tdep.c: Fix common/ includes.
13340         * amd64-tdep.c: Fix common/ includes.
13341         * amd64-sol2-tdep.c: Fix common/ includes.
13342         * amd64-obsd-tdep.c: Fix common/ includes.
13343         * amd64-nbsd-tdep.c: Fix common/ includes.
13344         * amd64-linux-tdep.c: Fix common/ includes.
13345         * amd64-linux-nat.c: Fix common/ includes.
13346         * amd64-fbsd-tdep.c: Fix common/ includes.
13347         * amd64-fbsd-nat.c: Fix common/ includes.
13348         * amd64-dicos-tdep.c: Fix common/ includes.
13349         * amd64-darwin-tdep.c: Fix common/ includes.
13350         * agent.c: Fix common/ includes.
13351         * ada-lang.h: Fix common/ includes.
13352         * ada-lang.c: Fix common/ includes.
13353         * aarch64-tdep.c: Fix common/ includes.
13354
13355 2019-01-25  Tom Tromey  <tom@tromey.com>
13356
13357         * common/create-version.sh: Use common/version.h.
13358
13359 2019-01-24  Pedro Alves  <palves@redhat.com>
13360
13361         * infrun.c (signal_stop, signal_print, signal_program)
13362         (signal_catch, signal_pass): Now arrays instead of pointers.
13363         (update_signals_program_target, do_target_resume)
13364         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13365         * linux-nat.c (linux_nat_target::pass_signals)
13366         (linux_nat_target::create_inferior, linux_nat_target::attach):
13367         Adjust.
13368         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13369         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13370         * procfs.c (procfs_target::pass_signals): Adjust.
13371         * record-full.c (record_full_target::resume): Adjust.
13372         * remote.c (remote_target::pass_signals)
13373         (remote_target::program_signals): Adjust.
13374         * target-debug.h (target_debug_print_signals): Now takes a
13375         gdb::array_view as parameter.  Adjust.
13376         * target.h (target_ops) <pass_signals, program_signals>: Replace
13377         pointer and length parameters with gdb::array_view.
13378         (target_pass_signals, target_program_signals): Likewise.
13379         * target-delegates.c: Regenerate.
13380
13381 2019-01-24  Pedro Alves  <palves@redhat.com>
13382
13383         * common/forward-scope-exit.h
13384         (forward_scope_exit::forward_scope_exit): Pass arguments to
13385         m_bind_function directly, instead of creating a std::bind and
13386         copying that.
13387
13388 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13389
13390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13391         for static members.
13392         (pass_in_v_vfp_candidate): Likewise.
13393
13394 2019-01-23  Tom Tromey  <tom@tromey.com>
13395             Pedro Alves  <palves@redhat.com>
13396
13397         * regcache.c (class regcache_invalidator): Remove.
13398         (regcache::raw_write): Use make_scope_exit.
13399
13400 2019-01-23  Tom Tromey  <tom@tromey.com>
13401
13402         * ui-out.h (class ui_out_emit_type): Update comment.
13403
13404 2019-01-23  Tom Tromey  <tom@tromey.com>
13405
13406         * infrun.c (fetch_inferior_event): Update comment.
13407
13408 2019-01-23  Tom Tromey  <tom@tromey.com>
13409             Pedro Alves  <palves@redhat.com>
13410
13411         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13412         parameter.
13413         (fetch_inferior_event): Use SCOPE_EXIT.
13414
13415
13416 2019-01-23  Tom Tromey  <tom@tromey.com>
13417             Pedro Alves  <palves@redhat.com>
13418
13419         * infrun.c (disable_thread_events): Delete.
13420         (stop_all_threads): Use SCOPE_EXIT.
13421
13422 2019-01-23  Tom Tromey  <tom@tromey.com>
13423             Pedro Alves  <palves@redhat.com>
13424
13425         * symfile.c: Include forward-scope-exit.h.
13426         (clear_symtab_users_cleanup): Replace forward declaration with
13427         a FORWARD_SCOPE_EXIT.
13428         (syms_from_objfile_1): Use the forward_scope_exit and
13429         gdb::optional instead of cleanup_function.
13430         (reread_symbols): Use the forward_scope_exit instead of
13431         cleanup_function.
13432         (clear_symtab_users_cleanup): Remove function.
13433
13434 2019-01-23  Tom Tromey  <tom@tromey.com>
13435             Pedro Alves  <palves@redhat.com>
13436
13437         * linux-nat.c: Include scope-exit.h.
13438         (cleanup_target_stop): Remove.
13439         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13440         SCOPE_EXIT.
13441
13442 2019-01-23  Tom Tromey  <tom@tromey.com>
13443             Pedro Alves  <palves@redhat.com>
13444
13445         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13446         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13447
13448 2019-01-23  Tom Tromey  <tom@tromey.com>
13449             Andrew Burgess  <andrew.burgess@embecosm.com>
13450             Pedro Alves  <palves@redhat.com>
13451
13452         * infrun.c (fetch_inferior_event): Use scope_exit.
13453         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13454         * top.c (execute_command): Use scope_exit.
13455         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13456         * utils.c (do_bpstat_clear_actions_cleanup)
13457         (make_bpstat_clear_actions_cleanup): Remove.
13458
13459 2019-01-23  Tom Tromey  <tom@tromey.com>
13460             Pedro Alves  <palves@redhat.com>
13461
13462         * infrun.c: Include "common/scope-exit.h"
13463         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13464         (wait_for_inferior): Use SCOPE_EXIT.
13465         (fetch_inferior_event): Use scope_exit.
13466
13467 2019-01-23  Tom Tromey  <tom@tromey.com>
13468             Pedro Alves  <palves@redhat.com>
13469
13470         * breakpoint.c (create_breakpoint): Remove cleanup.
13471
13472 2019-01-23  Tom Tromey  <tom@tromey.com>
13473             Andrew Burgess  <andrew.burgess@embecosm.com>
13474             Pedro Alves  <palves@redhat.com>
13475
13476 2019-01-23  Pedro Alves  <palves@redhat.com>
13477
13478         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13479
13480 2019-01-23  Pedro Alves  <palves@redhat.com>
13481             Andrew Burgess  <andrew.burgess@embecosm.com>
13482
13483         * gdbthread.h: Include "common/forward-scope-exit.h".
13484         (scoped_finish_thread_state): Redefine custom class in terms of
13485         forward_scope_exit.
13486
13487 2019-01-23  Pedro Alves  <palves@redhat.com>
13488             Andrew Burgess  <andrew.burgess@embecosm.com>
13489
13490         * common/forward-scope-exit.h: New file.
13491
13492 2019-01-23  Pedro Alves  <palves@redhat.com>
13493             Andrew Burgess  <andrew.burgess@embecosm.com>
13494             Tom Tromey  <tom@tromey.com>
13495
13496         * common/scope-exit.h: New file.
13497
13498 2019-01-23  Pedro Alves  <palves@redhat.com>
13499
13500         * common/preprocessor.h (ESC): Rename to ...
13501         (ESC_PARENS): ... this.
13502         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13503         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13504
13505 2019-01-23  Tom Tromey  <tom@tromey.com>
13506
13507         * language.h (class scoped_switch_to_sym_language_if_auto):
13508         Initialize m_lang in both cases.
13509
13510 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13511
13512         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13513         with XCNEW.
13514
13515 2019-01-22  Tom Tromey  <tom@tromey.com>
13516
13517         * corelow.c: Do not include sys/file.h.
13518
13519 2019-01-22  Tom Tromey  <tom@tromey.com>
13520
13521         * tui/tui-wingeneral.h: Include gdb_curses.h.
13522
13523 2019-01-22  Tom Tromey  <tom@tromey.com>
13524
13525         * source-cache.h (class source_cache) <get_source_lines,
13526         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13527
13528 2019-01-22  Tom Tromey  <tom@tromey.com>
13529
13530         * remote-fileio.h (struct remote_target): Declare.
13531
13532 2019-01-22  Tom Tromey  <tom@tromey.com>
13533
13534         * python/py-arch.c: Do not include py-ref.h.
13535         * python/py-bpevent.c: Do not include py-ref.h.
13536         * python/py-cmd.c: Do not include py-ref.h.
13537         * python/py-continueevent.c: Do not include py-ref.h.
13538         * python/py-event.h: Do not include py-ref.h.
13539         * python/py-evtregistry.c: Do not include py-ref.h.
13540         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13541         * python/py-frame.c: Do not include py-ref.h.
13542         * python/py-framefilter.c: Do not include py-ref.h.
13543         * python/py-function.c: Do not include py-ref.h.
13544         * python/py-infevents.c: Do not include py-ref.h.
13545         * python/py-linetable.c: Do not include py-ref.h.
13546         * python/py-objfile.c: Do not include py-ref.h.
13547         * python/py-param.c: Do not include py-ref.h.
13548         * python/py-prettyprint.c: Do not include py-ref.h.
13549         * python/py-progspace.c: Do not include py-ref.h.
13550         * python/py-symbol.c: Do not include py-ref.h.
13551         * python/py-symtab.c: Do not include py-ref.h.
13552         * python/py-type.c: Do not include py-ref.h.
13553         * python/py-unwind.c: Do not include py-ref.h.
13554         * python/py-utils.c: Do not include py-ref.h.
13555         * python/py-value.c: Do not include py-ref.h.
13556         * python/py-varobj.c: Do not include py-ref.h.
13557         * python/py-xmethods.c: Do not include py-ref.h.
13558         * python/python.c: Do not include py-ref.h.
13559         * varobj.c: Do not include py-ref.h.
13560
13561 2019-01-22  Tom Tromey  <tom@tromey.com>
13562
13563         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13564         keyword for bcache.
13565
13566 2019-01-22  Tom Tromey  <tom@tromey.com>
13567
13568         * compile/compile-cplus-types.c: Remove a comment by #include.
13569
13570 2019-01-22  Tom Tromey  <tom@tromey.com>
13571
13572         * compile/gcc-c-plugin.h: Include compile-internal.h.
13573
13574 2019-01-22  Tom Tromey  <tom@tromey.com>
13575
13576         * stabsread.c (EXTERN): Do not define.
13577         (symnum, next_symbol_text_func, processing_gcc_compilation)
13578         (within_function, global_sym_chain, global_stabs)
13579         (previous_stab_code, this_object_header_files)
13580         (n_this_object_header_files)
13581         (n_allocated_this_object_header_files): Define.
13582         * stabsread.h (EXTERN): Never define.  Use "extern".
13583
13584 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13585
13586         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13587         history_value.
13588
13589 2019-01-21  Tom Tromey  <tom@tromey.com>
13590
13591         * ui-out.c: Fix includes.
13592         * tui/tui-source.c: Fix includes.
13593         * target.c: Fix includes.
13594         * remote.c: Fix includes.
13595         * regcache.c: Fix includes.
13596         * python/py-block.c: Fix includes.
13597         * printcmd.c: Fix includes.
13598         * or1k-tdep.c: Fix includes.
13599         * mi/mi-main.c: Fix includes.
13600         * m32r-tdep.c: Fix includes.
13601         * csky-tdep.c: Fix includes.
13602         * compile/compile-cplus-types.c: Fix includes.
13603         * cli/cli-interp.c: Fix includes.
13604
13605 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13606
13607         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13608         for padding.
13609
13610 2019-01-16  Tom Tromey  <tom@tromey.com>
13611
13612         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13613         earlier.
13614         (struct objfile) <msymbols_range>: Move from top level.
13615         <msymbols>: New method.
13616         (class objfile_msymbols): Remove.
13617         * symtab.c (default_collect_symbol_completion_matches_break_on):
13618         Update.
13619         * symmisc.c (dump_msymbols): Update.
13620         * stabsread.c (scan_file_globals): Update.
13621         * objc-lang.c (info_selectors_command, info_classes_command)
13622         (find_methods): Update.
13623         * minsyms.c (find_solib_trampoline_target): Update.
13624         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13625         * coffread.c (coff_symfile_read): Update.
13626         * ada-lang.c (ada_lookup_simple_minsym)
13627         (ada_collect_symbol_completion_matches): Update.
13628
13629 2019-01-16  Tom Tromey  <tom@tromey.com>
13630
13631         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13632         type.  Remove no-argument constructor.
13633         <iterator::operator++>: Simplify.
13634         <begin>: Update.
13635         <end>: Use minimal_symbol_count.
13636
13637 2019-01-16  Tom Tromey  <tom@tromey.com>
13638
13639         * objfiles.h (struct objfile) <psymtabs>: New method.
13640         (class objfile_psymtabs): Remove.
13641         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13642         typedef.
13643         <range>: New method.
13644         (require_partial_symbols): Change return type.
13645         * psymtab.c (require_partial_symbols)
13646         (psym_expand_symtabs_matching): Update.
13647         * mdebugread.c (parse_partial_symbols): Update.
13648         * dbxread.c (dbx_end_psymtab): Update.
13649
13650 2019-01-15  Tom Tromey  <tom@tromey.com>
13651
13652         * symtab.c (lookup_objfile_from_block)
13653         (lookup_symbol_in_objfile_symtabs)
13654         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13655         (find_line_symtab, info_sources_command)
13656         (default_collect_symbol_completion_matches_break_on)
13657         (make_source_files_completion_list): Update.
13658         * symmisc.c (print_objfile_statistics, dump_objfile)
13659         (maintenance_print_symbols, maintenance_info_symtabs)
13660         (maintenance_check_symtabs, maintenance_info_line_tables):
13661         Update.
13662         * source.c (select_source_symtab)
13663         (forget_cached_source_info_for_objfile): Update.
13664         * objfiles.h (class objfile_compunits): Remove.
13665         (struct objfile) <compunits_range>: New typedef.
13666         (compunits): New method.
13667         * objfiles.c (objfile_relocate1): Update.
13668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13669         * maint.c (count_symtabs_and_blocks): Update.
13670         * linespec.c (iterate_over_all_matching_symtabs): Update.
13671         * cp-support.c (add_symbol_overload_list_qualified): Update.
13672         * coffread.c (coff_symtab_read): Update.
13673         * ada-lang.c (add_nonlocal_symbols)
13674         (ada_collect_symbol_completion_matches)
13675         (ada_add_global_exceptions): Update.
13676
13677 2019-01-15  Tom Tromey  <tom@tromey.com>
13678
13679         * progspace.h (program_space) <objfiles_safe_range>: New
13680         typedef.
13681         <objfiles_safe>: New method.
13682         * objfiles.h (class all_objfiles_safe): Remove.
13683         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13684         * jit.c (jit_inferior_exit_hook): Update.
13685
13686 2019-01-17  Tom Tromey  <tom@tromey.com>
13687
13688         * progspace.h (program_space) <objfiles_range>: New typedef.
13689         <objfiles>: New method.
13690         <objfiles_head>: Rename from objfiles.
13691         (object_files): Update.
13692         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13693         * guile/scm-pretty-print.c
13694         (ppscm_find_pretty_printer_from_objfiles): Update.
13695         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13696         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13697         Update.
13698         * python/py-progspace.c (pspy_get_objfiles): Update.
13699         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13700         Update.
13701         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13702         (objfpy_lookup_objfile_by_build_id): Update.
13703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13704         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13705         Update.
13706         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13707         (expand_symtab_containing_pc, lookup_objfile_from_block)
13708         (lookup_static_symbol, basic_lookup_transparent_type)
13709         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13710         (find_line_symtab, info_sources_command)
13711         (default_collect_symbol_completion_matches_break_on)
13712         (make_source_files_completion_list, find_main_name): Update.
13713         * symmisc.c (print_symbol_bcache_statistics)
13714         (print_objfile_statistics, maintenance_print_symbols)
13715         (maintenance_print_msymbols, maintenance_print_objfiles)
13716         (maintenance_info_symtabs, maintenance_check_symtabs)
13717         (maintenance_expand_symtabs, maintenance_info_line_tables):
13718         Update.
13719         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13720         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13721         (map_overlay_command, unmap_overlay_command)
13722         (simple_overlay_update, expand_symtabs_matching)
13723         (map_symbol_filenames): Update.
13724         * symfile-debug.c (set_debug_symfile): Update.
13725         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13726         Update.
13727         * source.c (select_source_symtab, forget_cached_source_info):
13728         Update.
13729         * solib.c (solib_read_symbols): Update.
13730         * solib-spu.c (append_ocl_sos): Update.
13731         * psymtab.c (maintenance_print_psymbols)
13732         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13733         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13734         * printcmd.c (info_symbol_command): Update.
13735         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13736         Update.
13737         * objfiles.h (class all_objfiles): Remove.
13738         * objfiles.c (have_partial_symbols, have_full_symbols)
13739         (have_minimal_symbols, qsort_cmp, update_section_map)
13740         (shared_objfile_contains_address_p)
13741         (default_iterate_over_objfiles_in_search_order): Update.
13742         * objc-lang.c (info_selectors_command, info_classes_command)
13743         (find_methods): Update.
13744         * minsyms.c (find_solib_trampoline_target): Update.
13745         * maint.c (maintenance_info_sections)
13746         (maintenance_translate_address, count_symtabs_and_blocks):
13747         Update.
13748         * main.c (captured_main_1): Update.
13749         * linux-thread-db.c (try_thread_db_load_from_pdir)
13750         (has_libpthread): Update.
13751         * linespec.c (iterate_over_all_matching_symtabs)
13752         (search_minsyms_for_name): Update.
13753         * jit.c (jit_find_objf_with_entry_addr): Update.
13754         * hppa-tdep.c (find_unwind_entry)
13755         (hppa_lookup_stub_minimal_symbol): Update.
13756         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13757         Update.
13758         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13759         (elf_gnu_ifunc_resolve_by_got): Update.
13760         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13761         * dwarf-index-write.c (save_gdb_index_command): Update.
13762         * cp-support.c (add_symbol_overload_list_qualified): Update.
13763         * breakpoint.c (create_overlay_event_breakpoint)
13764         (create_longjmp_master_breakpoint)
13765         (create_std_terminate_master_breakpoint)
13766         (create_exception_master_breakpoint): Update.
13767         * blockframe.c (find_pc_partial_function): Update.
13768         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13769         (ada_collect_symbol_completion_matches)
13770         (ada_add_global_exceptions): Update.
13771
13772 2019-01-17  Tom Tromey  <tom@tromey.com>
13773
13774         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13775         declare VEC.
13776         (solib_target_parse_libraries): Change return type.
13777         (library_list_start_segment, library_list_start_section)
13778         (library_list_end_library, library_list_start_library); Update.
13779         (solib_target_free_library_list): Remove.
13780         (solib_target_parse_libraries): Remove cleanup.  Change return
13781         type.
13782         (solib_target_current_sos): Update.
13783
13784 2019-01-17  Tom Tromey  <tromey@bapiya>
13785
13786         * valprint.c: Replace "the the" with "the".
13787         * symtab.c: Replace "the the" with "the".
13788         * solib.c: Replace "the the" with "the".
13789         * solib-dsbt.c: Replace "the the" with "the".
13790         * linespec.c: Replace "the the" with "the".
13791         * dwarf2loc.h: Replace "the the" with "the".
13792         * amd64-windows-tdep.c: Replace "the the" with "the".
13793         * aarch64-tdep.c: Replace "the the" with "the".
13794
13795 2019-01-16  Keith Seitz  <keiths@redhat.com>
13796
13797         PR gdb/23773
13798         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13799         <builder>: Rename to ..
13800         <m_builder>: ... this and make private.
13801         (dwarf2_cu::get_builder): New method.  Change all users of
13802         `builder' to use this method.
13803         (dwarf2_start_symtab): Move to ...
13804         (dwarf2_cu::start_symtab): ... here.  Update all callers
13805         (setup_type_unit_groups): Move to ...
13806         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13807         callers.
13808         (dwarf2_cu::reset_builder): New method.
13809         (process_full_compunit, process_full_type_unit): Use
13810         dwarf2_cu::reset_builder.
13811         (follow_die_offset): Record the ancestor CU if it is different
13812         from the followed DIE's CU.
13813         (follow_die_sig_1): Likewise.
13814
13815 2019-01-15  Tom Tromey  <tom@tromey.com>
13816
13817         * remote.c (class remote_state) <buf>: Now a char_vector.
13818         <buf_size>: Remove.
13819         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13820         parameter.
13821         (remote_target::getpkt_or_notif_sane_1)
13822         (remote_target::getpkt_sane)
13823         (remote_target::getpkt_or_notif_sane): Likewise.
13824         (class remote_target) <putpkt>: New overload.
13825         (remote_target::read_frame): Change type of "buf_p".  Remove
13826         sizeof_p parameter.
13827         (packet_ok): New overload.
13828         (packet_check_result): New overload.
13829         Update all uses.
13830
13831 2019-01-14  Tom Tromey  <tom@tromey.com>
13832
13833         * remote-notif.c (handle_notification, remote_notif_ack)
13834         (remote_notif_parse): Make "buf" const.
13835         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13836         const.
13837         (remote_notif_parse, remote_notif_ack, handle_notification):
13838         Likewise.
13839         * remote.c (remote_notif_stop_parse): Make "buf" const.
13840         (remote_target::remote_parse_stop_reply): Make "buf" const.
13841         (remote_notif_stop_ack): Make "buf" const.
13842
13843 2019-01-14  Tom Tromey  <tom@tromey.com>
13844
13845         * remote.c (remote_console_output): Make parameter const.
13846
13847 2019-01-14  Tom Tromey  <tom@tromey.com>
13848
13849         * target-debug.h (target_debug_print_signals): Constify.
13850         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13851         * procfs.c (procfs_target::pass_signals): Update.
13852         * linux-nat.c (linux_nat_target::pass_signals): Update.
13853         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13854         * target-delegates.c: Rebuild.
13855         * remote.c (remote_target::program_signals): Update.
13856         (remote_target::pass_signals): Update.
13857         * target.c (target_pass_signals): Constify argument.
13858         (target_program_signals): Likewise.
13859         * target.h (struct target_ops) <pass_signals, program_signals>:
13860         Constify argument.
13861         (target_pass_signals, target_program_signals): Constify argument.
13862
13863 2019-01-14  Tom Tromey  <tom@tromey.com>
13864
13865         PR tui/28819:
13866         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13867
13868 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13869
13870         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13871         field.
13872         * rs6000-tdep.c: Include reggroups.h.
13873         (IS_V_ALIAS_PSEUDOREG): Define.
13874         (rs6000_register_name): Return names for the "vX" aliases.
13875         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13876         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13877         aliases.  Call default_register_reggroup_p for all other
13878         pseudo-registers.
13879         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13880         New functions.
13881         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13882         Handle "vX" aliases.
13883         (v_alias_pseudo_register_collect): New function.
13884         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13885         (rs6000_gdbarch_init): Initialize "vX" aliases as
13886         pseudo-registers.  Restore registration of
13887         rs6000_pseudo_register_reggroup_p with
13888         set_tdesc_pseudo_register_reggroup_p.
13889
13890 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13891
13892         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13893         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13894         set_gdbarch_num_pseudo_regs.
13895
13896 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13897
13898         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13899         Remove arg prefixname, add do_set and do_show.
13900         Add member functions set_list and show_list.
13901         * cli/cli-style.c (class cli_style_option): Update accordingly.
13902         (style_set_list): Move to file scope.
13903         (style_show_list): Likewise.
13904         (set_style): Call help_list.
13905         (show_style): Call cmd_show_list.
13906         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13907         Update to use the new macro.
13908
13909 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13910
13911         * ada-lang.c (_initialize_ada_language): Expand the help text
13912         for the "catch exception" command.
13913
13914 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13915
13916         * symtab.c (matching_obj_sections): Initialize obj,
13917         declare it closer to its usage.
13918
13919 2019-01-10  Tom Tromey  <tom@tromey.com>
13920
13921         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13922         (basic_inf_threads_range): Remove.
13923         (inf_threads_range, inf_non_exited_threads_range)
13924         (safe_inf_threads_range): Use next_adapter.
13925
13926 2019-01-10  Keith Seitz  <keiths@redhat.com>
13927
13928         PR gdb/23712
13929         PR symtab/23010
13930         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13931         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13932
13933 2019-01-10  Keith Seitz  <keiths@redhat.com>
13934
13935         PR gdb/23712
13936         PR symtab/23010
13937         * dictionary.c (pending_to_vector): Remove.
13938         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13939         Remove _1 suffix, replacing functions of the same name.  Update
13940         all callers.
13941         (dict_create_hashed, dict_create_hashed_expandable)
13942         (dict_create_linear, dict_create_linear_expandable, dict_free)
13943         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13944         Make functions static.
13945
13946 2019-01-10  Keith Seitz  <keiths@redhat.com>
13947
13948         PR gdb/23712
13949         PR symtab/23010
13950         * dictionary.h (struct dictionary): Replace declaration with
13951         multidictionary.
13952         (dict_create_hashed, dict_create_hashed_expandable)
13953         (dict_create_linear, dict_create_linear_expandable)
13954         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13955         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13956         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13957         taking multidictionary argument.
13958         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13959         * block.h (struct block) <dict>: Change to multidictionary
13960         and rename `multidict'.
13961         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13962         symmisc.c: Update all dictionary references to multidictionary.
13963
13964 2019-01-10  Keith Seitz  <keiths@redhat.com>
13965
13966         PR gdb/23712
13967         PR symtab/23010
13968         * dictionary.c: Include unordered_map.
13969         (pending_to_vector): New function.
13970         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13971         Rewrite the non-"_1" functions to take vector instead
13972         of linked list.
13973         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13974         "new" _1 versions of the same name.
13975         (multidictionary): Define.
13976         (std::hash<enum language): New definition.
13977         (collate_pending_symbols_by_language, mdict_create_hashed)
13978         (mdict_create_hashed_expandable, mdict_create_linear)
13979         (mdict_create_linear_expandable, mdict_free)
13980         (find_language_dictionary, create_new_language_dictionary)
13981         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13982         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13983         (mdict_size, mdict_empty): New functions.
13984         * dictionary.h (mdict_iterator): Define.
13985
13986 2019-01-10  Pedro Alves  <palves@redhat.com>
13987
13988         * breakpoint.c (read_uploaded_action)
13989         (create_tracepoint_from_upload): Adjust to use
13990         gdb::unique_xmalloc_ptr.
13991         * ctf.c (ctf_write_uploaded_tp):
13992         (SET_ARRAY_FIELD): Use emplace_back.
13993         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13994         * tracefile-tfile.c (tfile_write_uploaded_tp):
13995         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13996         gdb::unique_xmalloc_ptr.
13997         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13998         at_string, cond_string, cmd_strings>: Replace char pointers
13999         with gdb::unique_xmalloc_ptr.
14000
14001 2019-01-10  Pedro Alves  <palves@redhat.com>
14002
14003         * solib-target.c (library_list_start_library): Don't xstrdup name.
14004
14005 2019-01-10  Pedro Alves  <palves@redhat.com>
14006
14007         * mdebugread.c (parse_partial_symbols): Use
14008         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14009
14010 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14011
14012         * linux-fork.c (scoped_switch_fork_info)
14013         <~scoped_switch_fork_info>: Fix incorrect variable name.
14014
14015 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14016
14017         * linux-fork.c (scoped_switch_fork_info)
14018         <scoped_switch_fork_info>: Make explicit.
14019         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14020
14021 2019-01-10  Tom Tromey  <tom@tromey.com>
14022
14023         * objfiles.h (objfile::reset_psymtabs): Update.
14024         * objfiles.c (objfile::objfile): Update.
14025         * psymtab.h (psymtab_storage::obstack): Update.
14026         (psymtab_storage::m_obstack): Use gdb::optional.
14027         (class psymtab_storage): Update comment.  Remove objfile
14028         parameter.
14029         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14030
14031 2019-01-10  Tom Tromey  <tom@tromey.com>
14032
14033         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14034         <free_psymtabs>: Now private.
14035         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14036         (allocate_psymtab): Use new method.
14037
14038 2019-01-10  Tom Tromey  <tom@tromey.com>
14039
14040         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14041         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14042         * mdebugread.c (parse_partial_symbols): Use
14043         allocate_dependencies.
14044         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14045         allocate_dependencies.
14046         (process_psymtab_comp_unit_reader)
14047         (build_type_psymtab_dependencies): Likewise.
14048         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14049
14050 2019-01-10  Tom Tromey  <tom@tromey.com>
14051
14052         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14053         PSYMBOL_SET_LANGUAGE.
14054         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14055
14056 2019-01-10  Tom Tromey  <tom@tromey.com>
14057
14058         * psymtab.h (psymtab_storage::obstack): New method.
14059         <m_obstack>: Rename from obstack; now private.
14060         * psymtab.c (psymtab_storage): Update.
14061         * dwarf2read.c (create_addrmap_from_index)
14062         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14063         Update.
14064
14065 2019-01-10  Tom Tromey  <tom@tromey.com>
14066
14067         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14068         * objfiles.h (objfile::reset_psymtabs): New method.
14069
14070 2019-01-10  Tom Tromey  <tom@tromey.com>
14071
14072         * symmisc.c (print_symbol_bcache_statistics): Update.
14073         (print_objfile_statistics): Update.
14074         * symfile.c (reread_symbols): Update.
14075         * psymtab.h (class psymtab_storage): New.
14076         * psymtab.c (psymtab_storage): New constructor.
14077         (~psymtab_storage): New destructor.
14078         (require_partial_symbols): Update.
14079         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14080         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14081         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14082         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14083         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14084         (start_psymtab_common, end_psymtab_common)
14085         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14086         (allocate_psymtab): Update.
14087         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14088         Update.
14089         (dump_psymtab_addrmap, maintenance_print_psymbols)
14090         (maintenance_check_psymtabs): Update.
14091         (class objfile_psymtabs): Move to objfiles.h.
14092         * psympriv.h (discard_psymtab): Now inline.
14093         (psymtab_discarder::psymtab_discarder): Update.
14094         (psymtab_discarder::~psymtab_discarder): Update.
14095         (ALL_OBJFILE_PSYMTABS): Rewrite.
14096         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14097         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14098         Remove fields.
14099         <partial_symtabs>: New field.
14100         (class objfile_psymtabs): Move from psymtab.h.  Update.
14101         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14102         psymbol_cache.
14103         (objfile::~objfile): Don't destroy psymbol_cache.
14104         * mdebugread.c (parse_partial_symbols): Update.
14105         * dwarf2read.c (create_addrmap_from_index)
14106         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14107         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14108         (add_partial_subprogram, dwarf2_ranges_read): Update.
14109         * dwarf-index-write.c (write_address_map)
14110         (write_one_signatured_type, recursively_write_psymbols)
14111         (class debug_names, class debug_names, write_psymtabs_to_index):
14112         Update.
14113
14114 2019-01-10  Tom Tromey  <tom@tromey.com>
14115
14116         * symtab.h (SYMBOL_SET_NAMES): Update.
14117         (symbol_set_names): Update.
14118         (MSYMBOL_SET_NAMES): Update.
14119         * symtab.c (symbol_set_names): Change argument to be an
14120         objfile_per_bfd_storage.
14121         * psymtab.c (add_psymbol_to_bcache): Update.
14122         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14123
14124 2019-01-10  Tom Tromey  <tom@tromey.com>
14125
14126         * symtab.c (create_demangled_names_hash): Change argument to be an
14127         objfile_per_bfd_storage.
14128         (symbol_set_names): Update.
14129
14130 2019-01-10  Tom Tromey  <tom@tromey.com>
14131
14132         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14133         init_psymbol_list.
14134         * psymtab.c (init_psymbol_list): Do nothing if already called.
14135         * psympriv.h (init_psymbol_list): Add comment.
14136         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14137         init_psymbol_list.
14138         * dbxread.c (dbx_symfile_read): Unconditionally call
14139         init_psymbol_list.
14140
14141 2019-01-10  Tom Tromey  <tom@tromey.com>
14142
14143         * xcoffread.c (scan_xcoff_symtab): Update.
14144         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14145         "where".
14146         * mdebugread.c (parse_partial_symbols)
14147         (handle_psymbol_enumerators): Update.
14148         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14149         * dbxread.c (read_dbx_symtab): Update.
14150         * psympriv.h (psymbol_placement): New enum.
14151         (add_psymbol_to_list): Update.
14152
14153 2019-01-10  Tom Tromey  <tom@tromey.com>
14154
14155         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14156         static_psymbols parameters.
14157         (scan_xcoff_symtab): Update.
14158         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14159         static_psymbols parameters.
14160         * psympriv.h (start_psymtab_common): Update.
14161         * mdebugread.c (parse_partial_symbols): Update.
14162         * dwarf2read.c (create_partial_symtab): Update.
14163         * dbxread.c (read_dbx_symtab): Update.
14164         (start_psymtab): Remove global_psymbols and static_psymbols
14165         parameters.
14166
14167 2019-01-10  Tom Tromey  <tom@tromey.com>
14168
14169         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14170         * psymtab.c (allocate_psymtab): Add comment.
14171         * psympriv.h (allocate_psymtab): Add comment.
14172         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14173         initializations.
14174         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14175
14176 2019-01-10  Tom Tromey  <tom@tromey.com>
14177
14178         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14179         Don't declare.
14180         * mipsread.c: Include mdebugread.h.
14181         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14182         Declare.
14183         * elfread.c: Include mdebugread.h.
14184
14185 2019-01-09  Tom Tromey  <tom@tromey.com>
14186
14187         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14188         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14189         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14190         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14191         (psym_lookup_symbol, psym_find_last_source_symtab)
14192         (psym_forget_cached_source_info, psym_print_stats)
14193         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14194         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14195         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14196         (psym_find_compunit_symtab_by_address)
14197         (maintenance_print_psymbols, maintenance_info_psymtabs)
14198         (maintenance_check_psymtabs): Use ranged for.
14199         * psymtab.h (class objfile_psymtabs): New.
14200         (require_partial_symbols): Return objfile_psymtabs.
14201         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14202
14203 2019-01-09  Tom Tromey  <tom@tromey.com>
14204
14205         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14206         (find_pc_mapped_section, list_overlays_command)
14207         (map_overlay_command, unmap_overlay_command)
14208         (simple_overlay_update): Use all_objfiles.
14209         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14210         * printcmd.c (info_symbol_command): Use all_objfiles.
14211         * objfiles.h (ALL_OBJSECTIONS): Remove.
14212         * maint.c (maintenance_translate_address): Use all_objfiles.
14213         * gcore.c (gcore_create_callback): Use all_objfiles.
14214         (objfile_find_memory_regions): Likewise.
14215
14216 2019-01-09  Tom Tromey  <tom@tromey.com>
14217
14218         * symtab.c (find_line_symtab, info_sources_command)
14219         (make_source_files_completion_list): Use objfile_compunits.
14220         * source.c (select_source_symtab): Use objfile_compunits.
14221         * objfiles.h (struct objfile): Update comment.
14222         (ALL_OBJFILES): Remove.
14223         (ALL_FILETABS): Remove.
14224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14225         objfile_compunits.
14226
14227 2019-01-09  Tom Tromey  <tom@tromey.com>
14228
14229         * symmisc.c (print_objfile_statistics, dump_objfile)
14230         (maintenance_print_symbols): Use compunit_filetabs.
14231         * source.c (forget_cached_source_info_for_objfile): Use
14232         compunit_filetabs.
14233         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14234         (ALL_FILETABS): Use compunit_filetabs.
14235         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14236         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14237
14238 2019-01-09  Tom Tromey  <tom@tromey.com>
14239
14240         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14241         (compunit_filetabs): New.
14242         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14243         compunit_filetabs.
14244         (info_sources_command, make_source_files_completion_list): Remove
14245         declaration.
14246         * symmisc.c (print_objfile_statistics, dump_objfile)
14247         (maintenance_print_symbols): Remove declaration.
14248         (maintenance_info_symtabs): Use compunit_filetabs.
14249         (maintenance_info_line_tables): Likewise.
14250         * source.c (select_source_symtab): Change local variable name.
14251         (forget_cached_source_info_for_objfile): Remove declaration.
14252         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14253         * objfiles.c (objfile_relocate1): Remove declaration.
14254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14255         declaration.
14256         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14257         * coffread.c (coff_symtab_read): Remove declaration.
14258         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14259         compunit_filetabs.
14260
14261 2019-01-09  Tom Tromey  <tom@tromey.com>
14262
14263         * symtab.c (lookup_objfile_from_block)
14264         (find_pc_sect_compunit_symtab, search_symbols)
14265         (default_collect_symbol_completion_matches_break_on): Use
14266         objfile_compunits.
14267         * objfiles.h (ALL_COMPUNITS): Remove.
14268         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14269         * cp-support.c (add_symbol_overload_list_qualified): Use
14270         objfile_compunits.
14271         * ada-lang.c (ada_collect_symbol_completion_matches)
14272         (ada_add_global_exceptions): Use objfile_compunits.
14273
14274 2019-01-09  Tom Tromey  <tom@tromey.com>
14275
14276         * source.c (select_source_symtab)
14277         (forget_cached_source_info_for_objfile): Remove declaration.
14278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14279         declaration.
14280         * maint.c (count_symtabs_and_blocks): Remove declaration.
14281         * cp-support.c (add_symbol_overload_list_qualified): Remove
14282         declaration.
14283         * coffread.c (coff_symtab_read): Remove declaration.
14284         * symtab.c (lookup_symbol_in_objfile_symtabs)
14285         (basic_lookup_transparent_type_1): Use objfile_compunits.
14286         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14287         (info_sources_command, search_symbols)
14288         (default_collect_symbol_completion_matches_break_on)
14289         (make_source_files_completion_list): Remove declaration.
14290         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14291         (ada_collect_symbol_completion_matches)
14292         (ada_add_global_exceptions): Remove declaration.
14293         * linespec.c (iterate_over_all_matching_symtabs): Use
14294         objfile_compunits.
14295         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14296         (class objfile_compunits): New.
14297         (ALL_COMPUNITS): Use objfile_compunits.
14298         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14299         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14300         objfile_compunits.
14301         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14302
14303 2019-01-09  Tom Tromey  <tom@tromey.com>
14304
14305         * symtab.c (search_symbols)
14306         (default_collect_symbol_completion_matches_break_on): Use
14307         objfile_msymbols.
14308         * ada-lang.c (ada_lookup_simple_minsym)
14309         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14310         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14311         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14312         objfile_msymbols.
14313         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14314         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14315         * objc-lang.c (find_methods): Use objfile_msymbols.
14316         (info_selectors_command, info_classes_command): Likewise.
14317         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14318         * objfiles.h (class objfile_msymbols): New.
14319         (ALL_OBJFILE_MSYMBOLS): Remove.
14320         (ALL_MSYMBOLS): Remove.
14321
14322 2019-01-09  Tom Tromey  <tom@tromey.com>
14323
14324         * common/next-iterator.h (next_adapter): Add Iterator template
14325         parameter.
14326         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14327         (class all_objfiles_safe): New.
14328         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14329         * objfiles.c (put_objfile_before): Update comment.
14330         (add_separate_debug_objfile): Likewise.
14331         (free_all_objfiles): Use all_objfiles_safe.
14332         (objfile_purge_solibs): Likewise.
14333
14334 2019-01-09  Tom Tromey  <tom@tromey.com>
14335
14336         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14337         (expand_symtab_containing_pc, lookup_static_symbol)
14338         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14339         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14340         all_objfiles.
14341         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14342         * breakpoint.c (create_overlay_event_breakpoint)
14343         (create_longjmp_master_breakpoint)
14344         (create_std_terminate_master_breakpoint)
14345         (create_exception_master_breakpoint): Use all_objfiles.
14346         * linux-thread-db.c (try_thread_db_load_from_pdir)
14347         (has_libpthread): Use all_objfiles.
14348         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14349         * linespec.c (iterate_over_all_matching_symtabs)
14350         (search_minsyms_for_name): Use all_objfiles.
14351         * maint.c (maintenance_info_sections): Use all_objfiles.
14352         * main.c (captured_main_1): Use all_objfiles.
14353         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14354         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14355         * guile/scm-pretty-print.c
14356         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14357         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14358         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14359         (maintenance_print_msymbols): Use all_objfiles.
14360         * source.c (select_source_symtab): Use all_objfiles.
14361         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14362         * symfile.c (remove_symbol_file_command)
14363         (expand_symtabs_matching, map_symbol_filenames): Use
14364         all_objfiles.
14365         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14366         all_objfiles.
14367         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14368         * objc-lang.c (find_methods): Use all_objfiles.
14369         * objfiles.c (have_partial_symbols, have_full_symbols)
14370         (have_minimal_symbols, qsort_cmp)
14371         (default_iterate_over_objfiles_in_search_order): Use
14372         all_objfiles.
14373         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14374         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14375         (maintenance_check_psymtabs): Use all_objfiles.
14376         (ALL_PSYMTABS): Remove.
14377         * compile/compile-object-run.c (do_module_cleanup): Use
14378         all_objfiles.
14379         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14380         * cp-support.c (add_symbol_overload_list_qualified): Use
14381         all_objfiles.
14382         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14383         Use all_objfiles.
14384         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14385         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14386         all_objfiles.
14387         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14388         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14389         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14390         Uses all_objfiles.
14391         * solib.c (solib_read_symbols): Use all_objfiles
14392
14393 2019-01-09  Tom Tromey  <tom@tromey.com>
14394
14395         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14396         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14397         all_objfiles.
14398         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14399         * symmisc.c (print_symbol_bcache_statistics)
14400         (print_objfile_statistics, maintenance_print_objfiles)
14401         (maintenance_info_symtabs, maintenance_check_symtabs)
14402         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14403         all_objfiles.
14404         * source.c (forget_cached_source_info): Use all_objfiles.
14405         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14406         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14407         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14408         * objfiles.c (update_section_map): Use all_objfiles.
14409         (shared_objfile_contains_address_p): Likewise.
14410         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14411         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14412
14413 2019-01-09  Tom Tromey  <tom@tromey.com>
14414
14415         * common/next-iterator.h: New file.
14416         * objfiles.h (class all_objfiles): New.
14417         (struct objfile_iterator): New.
14418
14419 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14420
14421         * NEWS: Move the description of the changed "frame", "select-frame",
14422          and "info frame" commands to the Changed commands section.
14423
14424 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14425
14426         * gdbtypes.c (check_stub_method_group): Remove handling of old
14427         mangling schemes.
14428         * linespec.c (find_methods): Likewise.
14429         * stabsread.c (read_member_functions): Likewise.
14430         * valops.c (search_struct_method): Likewise.
14431         (value_struct_elt_for_reference): Likewise.
14432         * NEWS: Mention this change.
14433
14434 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14435
14436         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14437         print_source_lines.
14438         * source.c (print_source_lines_base): Update line number check.
14439         (print_source_lines): New function.
14440         (source_lines_range::source_lines_range): New function.
14441         * source.h (class source_lines_range): New class.
14442         (print_source_lines): New declaration.
14443
14444 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14445
14446         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14447
14448 2019-01-08  Tom Tromey  <tom@tromey.com>
14449             Simon Marchi  <simon.marchi@ericsson.com>
14450
14451         PR gdb/24060
14452         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14453         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14454         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14455         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14456         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14457         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14458
14459 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14460
14461         * source.c (select_source_symtab): Move header comment to
14462         declaration in source.h.
14463         (forget_cached_source_info_for_objfile): Likewise.
14464         (forget_cached_source_info): Likewise.
14465         (identify_source_line): Likewise.
14466         * source.h (identify_source_line): Move declaration from symtab.h
14467         and add comment from source.c
14468         (print_source_lines): Likewise.
14469         (forget_cached_source_info_for_objfile): Likewise.
14470         (forget_cached_source_info): Likewise.
14471         (select_source_symtab): Likewise.
14472         (enum print_source_lines_flag): Move definition from symtab.h.
14473         * symtab.h (identify_source_line): Move declaration to source.h.
14474         (print_source_lines): Likewise.
14475         (forget_cached_source_info_for_objfile): Likewise.
14476         (forget_cached_source_info): Likewise.
14477         (select_source_symtab): Likewise.
14478         (enum print_source_lines_flag): Move definition to source.h.
14479         * tui/tui-hooks.c: Add 'source.h' include.
14480
14481 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14482
14483         * source.c (print_source_lines_base): Handle requests to print
14484         reverse line number sequences, and guard against empty lines
14485         string.
14486
14487 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14488
14489         * source.c (print_source_lines_base): Fix skip of '\r' if next
14490         character is '\n'.
14491
14492 2019-01-06  Tom Tromey  <tom@tromey.com>
14493
14494         * c-exp.y (struct c_parse_state) <macro_original_text,
14495         expansion_obstack>: New member.
14496         (macro_original_text, expansion_obstack): Remove globals.
14497         (scan_macro_expansion, scanning_macro_expansion)
14498         (finished_macro_expansion): Update.
14499         (scan_macro_cleanup): Remove.
14500         (yylex, c_parse): Update.
14501
14502 2019-01-06  Tom Tromey  <tom@tromey.com>
14503
14504         * c-exp.y (struct c_parse_state) <strings>: New member.
14505         (operator_stoken): Update.
14506
14507 2019-01-06  Tom Tromey  <tom@tromey.com>
14508
14509         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14510         (union type_stack_elt) <typelist_val>: Now a pointer to
14511         std::vector.
14512         (type_stack_cleanup): Don't declare.
14513         (push_typelist): Update.
14514         * parse.c (pop_typelist): Return a std::vector.
14515         (push_typelist): Take a std::vector.
14516         (follow_types): Update.  Do not free args.
14517         (type_stack_cleanup): Remove.
14518         * c-exp.y (struct c_parse_state): New.
14519         (cpstate): New global.
14520         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14521         (nonempty_typelist): Update.
14522         (func_mod): Create a new vector.
14523         (c_parse): Create a c_parse_state.
14524         (check_parameter_typelist): Do not delete params.
14525         (function_method): Update.  Do not delete type_list.
14526
14527 2019-01-06  Tom Tromey  <tom@tromey.com>
14528
14529         PR gdb/28155:
14530         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14531         check_typedef.
14532         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14533         (print_return_value): Likewise.
14534
14535 2019-01-05  Tom Tromey  <tom@tromey.com>
14536
14537         * contrib/cleanup_check.py: Remove.
14538         * contrib/gcc-with-excheck: Remove.
14539         * contrib/exsummary.py: Remove.
14540         * contrib/excheck.py: Remove.
14541
14542 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14543
14544         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14545         NULL. Initialize tpprev to NULL instead of assigning it
14546         to NULL on the next statement.
14547         * windows-nat.c (windows_delete_thread): Remove check for
14548         main_thread_id before printing thread exit notifications.
14549         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14550         Remove thread ID check against main_thread_id.
14551         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14552         windows_delete_thread.
14553         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14554
14555 2019-01-04  Tom Tromey  <tom@tromey.com>
14556
14557         * compile/compile.c (_initialize_compile): Use upper case for
14558         metasyntactic variables.
14559         * symmisc.c (_initialize_symmisc): Use upper case for
14560         metasyntactic variables.
14561         * psymtab.c (_initialize_psymtab): Use upper case for
14562         metasyntactic variables.
14563         * demangle.c (demangle_command): Use upper case for metasyntactic
14564         variables.
14565         (_initialize_demangler): Likewise.
14566         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14567         variables.
14568
14569 2019-01-03  Tom Tromey  <tom@tromey.com>
14570
14571         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14572
14573 2019-01-03  Tom Tromey  <tom@tromey.com>
14574
14575         * python/py-symtab.c (salpy_str): Update.
14576         (struct salpy_sal_object) <symtab>: Now a PyObject.
14577         (salpy_dealloc): Update.
14578         (del_objfile_sal): Use gdbpy_ref.
14579
14580 2019-01-03  Tom Tromey  <tom@tromey.com>
14581
14582         * python/py-type.c (convert_field): Use new_reference.  Return
14583         gdbpy_ref.
14584         (make_fielditem): Return gdbpy_ref.
14585         (typy_fields): Update.
14586         (typy_getitem): Update.
14587         (field_name): Return gdbpy_ref.  Use new_reference.
14588         (typy_iterator_iternext): Update.
14589
14590 2019-01-03  Tom Tromey  <tom@tromey.com>
14591
14592         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14593
14594 2019-01-03  Tom Tromey  <tom@tromey.com>
14595
14596         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14597         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14598         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14599         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14600         (pspy_set_type_printers): Likewise.
14601         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14602         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14603         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14604         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14605         (objfpy_set_type_printers): Likewise.
14606
14607 2019-01-03  Tom Tromey  <tom@tromey.com>
14608
14609         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14610         (gdbpy_print_stack): Use gdbpy_err_fetch.
14611         * python/python-internal.h (class gdbpy_err_fetch): New class.
14612         (class gdbpy_enter) <m_error_type, m_error_value,
14613         m_error_traceback>: Remove.
14614         <m_error>: New member.
14615         (gdbpy_exception_to_string): Don't declare.
14616         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14617         * python/py-value.c (convert_value_from_python): Use
14618         gdbpy_err_fetch.
14619         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14620         gdbpy_exception_to_string.
14621         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14622         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14623         gdbpy_err_fetch.
14624
14625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14626
14627         * linux-nat.c (delete_lwp_cleanup): Delete.
14628         (struct lwp_deleter): New struct.
14629         (lwp_info_up): New typedef.
14630         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14631         lwp_info_up.
14632
14633 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14634
14635         * linux-fork.c (class scoped_switch_fork_info): New class.
14636         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14637
14638 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14639
14640         * valops.c (find_overload_match): Remove use of null_cleanup, and
14641         calls to do_cleanups.
14642
14643 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14644
14645         * compile/compile-cplus-types.c
14646         (compile_cplus_instance::decl_name): Handle changes to
14647         cp_func_name.
14648         * cp-support.c (cp_func_name): Update header comment, update
14649         return type.
14650         * cp-support.h (cp_func_name): Update return type in declaration.
14651         * valops.c (find_overload_match): Move temp_func local to top
14652         level of function and change its type.  Use temp_func to hold and
14653         delete temporary string obtained from cp_func_name.
14654
14655 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14656
14657         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14658         gdb::char_vector, remove cleanup, and update uses of `msg`.
14659
14660 2019-01-03  Jim Wilson  <jimw@sifive.com>
14661
14662         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14663
14664 2019-01-02  Tom Tromey  <tom@tromey.com>
14665
14666         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14667         (tdesc_parse_xml): Remove cleanups.
14668         * target-descriptions.h (make_cleanup_free_target_description):
14669         Don't declare.
14670         (target_desc_deleter): New struct.
14671         (target_desc_up): New typedef.
14672         * target-descriptions.c (target_desc_deleter::operator()): Rename
14673         from free_target_description.
14674         (make_cleanup_free_target_description): Remove.
14675
14676 2019-01-02  Tom Tromey  <tom@tromey.com>
14677
14678         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14679         constructor, destructor.
14680         (linespec_parser): Remove typedef.
14681         (~linespec_parser): Rename from linespec_parser_delete.
14682         (linespec_lex_to_end, linespec_complete_label)
14683         (linespec_complete): Update.
14684         (decode_line_full): Remove cleanups.
14685         (decode_line_1): Update.
14686
14687 2019-01-02  Tom Tromey  <tom@tromey.com>
14688
14689         * python/python-internal.h (inferior_to_inferior_object): Change
14690         return type.
14691         * python/py-exitedevent.c (create_exited_event_object): Update.
14692         * python/py-inferior.c (inferior_to_inferior_object): Return
14693         gdbpy_ref.
14694         (python_new_inferior, python_inferior_deleted)
14695         (thread_to_thread_object, delete_thread_object)
14696         (build_inferior_list, gdbpy_selected_inferior): Update.
14697         * python/py-infthread.c (create_thread_object): Update.  Also fail
14698         if inferior_to_inferior_object fails.
14699
14700 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14701
14702         * inferior.h (class inferior) <displaced_step_state>: New field.
14703         * infrun.h (struct displaced_step_state): Move here from
14704         infrun.c.  Initialize fields, add constructor.
14705         <inf>: Remove field.
14706         <reset>: New method.
14707         * infrun.c (struct displaced_step_inferior_state): Move to
14708         infrun.h.
14709         (displaced_step_inferior_states): Remove.
14710         (get_displaced_stepping_state): Adust.
14711         (displaced_step_in_progress_any_inferior): Adjust.
14712         (displaced_step_in_progress_thread): Adjust.
14713         (displaced_step_in_progress): Adjust.
14714         (add_displaced_stepping_state): Remove.
14715         (get_displaced_step_closure_by_addr): Adjust.
14716         (remove_displaced_stepping_state): Remove.
14717         (infrun_inferior_exit): Call displaced_step_state.reset.
14718         (use_displaced_stepping): Don't check for NULL.
14719         (displaced_step_prepare_throw): Call
14720         get_displaced_stepping_state.
14721         (displaced_step_fixup): Don't check for NULL.
14722         (prepare_for_detach): Don't check for NULL.
14723
14724 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14725
14726         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14727          in case of call that did not complete.
14728
14729 2019-01-02  Andrey Utkin  <autkin@undo.io>
14730
14731         * symfile.c (find_separate_debug_file): Fix search of debug files for
14732         remote debuggee.
14733
14734 2019-01-02  Tom Tromey  <tom@tromey.com>
14735
14736         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14737         indentation.
14738         * python/py-frame.c (frapy_older): Remove cast.
14739         (frapy_newer): Likewise.
14740         * python/py-breakpoint.c (local_setattro): Remove cast.
14741         * python/py-arch.c (archpy_name): Remove local variable.
14742         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14743
14744 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14745
14746         * unittests/basic_string_view/element_access/char/empty.cc:
14747         Fix year range in copyright header.
14748
14749 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14750
14751         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14752         Delete.
14753         <operator==>: Update with for removed field.
14754         <hash>: Likewise.
14755         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14756         <isa_features>: ...this.
14757         <abi_features>: New field.
14758         (riscv_isa_flen): Update comment.
14759         (riscv_abi_xlen): New declaration.
14760         (riscv_abi_flen): New declaration.
14761         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14762         isa_features.
14763         (riscv_abi_xlen): New function.
14764         (riscv_isa_flen): Update to get answer from isa_features.
14765         (riscv_abi_flen): New function.
14766         (riscv_has_fp_abi): Update to get answer from abi_features.
14767         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14768         xlen and flen.
14769         (riscv_call_info) <xlen, flen>: Update comment.
14770         (riscv_call_arg_struct): Remove invalid assertions
14771         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14772         is removed.
14773         (riscv_gdbarch_init): Gather isa features and abi features
14774         separately, ensure both match on the gdbarch when reusing an old
14775         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14776         a target with 64-bit float hardware.
14777
14778 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14779
14780         * source.c (search_command_helper): Stop reverse search
14781         when line 1 has been searched.
14782
14783 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14784
14785         * record-full.c (record_full_base_target::close): Rewrite
14786         record_full_core_buf_list free logic.
14787
14788 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14789
14790         * break-catch-syscall.c (print_one_catch_syscall): xfree
14791         the last text.
14792
14793 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14794
14795         * top.c (print_gdb_version): Update Copyright year in version
14796         message.
14797
14798 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14799
14800         Update copyright year range in all GDB files.
14801
14802 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14803
14804         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14805
14806 For older changes see ChangeLog-2018.
14807 \f
14808 Local Variables:
14809 mode: change-log
14810 left-margin: 8
14811 fill-column: 74
14812 version-control: never
14813 coding: utf-8
14814 End:
14815