gdb/ChangeLog

   1 2019-06-11  Tom Tromey  <tromey@adacore.com>
   2
   3         * darwin-nat.c (darwin_decode_exception_message)
   4         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
   5
   6 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * valops.c (value_slice): Check for not allocated or not
   9         associated values.
  10
  11 2019-06-10  Tom de Vries  <tdevries@suse.de>
  12
  13         PR gdb/24618
  14         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
  15         sure an empty slot (defined by a 32-bit zero pair) is recognized as
  16         invalid.
  17
  18 2019-06-10  Tom de Vries  <tdevries@suse.de>
  19
  20         PR gdb/24611
  21         * linespec.c (linespec_lexer_lex_string): Remove incorrect
  22         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
  23
  24 2019-06-10  Tom de Vries  <tdevries@suse.de>
  25
  26         PR symtab/24545
  27         * symtab.c (struct demangled_name_entry): Add language field.
  28         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  29         static minimal symbol".  Set and use language field.
  30
  31 2019-06-10  Tom Tromey  <tromey@adacore.com>
  32
  33         * ada-lang.c (_initialize_ada_language): Update help text.
  34
  35 2019-06-10  Tom Tromey  <tromey@adacore.com>
  36
  37         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
  38         with a newline.
  39         * guile/guile.c (handle_boot_error): Don't end warning with a
  40         newline.
  41         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
  42         warning with a newline.
  43         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
  44         newline.
  45         (s12z_frame_cache): Likewise.
  46         * dwarf-index-cache.c (index_cache::store): Don't end warning with
  47         a newline.
  48         * solib-svr4.c (disable_probes_interface): Don't end warning with
  49         a newline.
  50         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
  51         newline.
  52         * python/python.c (do_finish_initialization): Don't end warning
  53         with a newline.
  54
  55 2019-06-10  Tom Tromey  <tom@tromey.com>
  56
  57         * python/py-breakpoint.c (gdbpy_breakpoint_created)
  58         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
  59         gdbpy_enter.
  60
  61 2019-06-10  Tom Tromey  <tromey@adacore.com>
  62
  63         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
  64         data.
  65         (elf_new_init): Don't call stabsread_new_init.
  66         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
  67         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
  68         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
  69
  70 2019-06-10  Tom de Vries  <tdevries@suse.de>
  71
  72         PR symtab/16264
  73         PR symtab/24517
  74         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
  75
  76 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
  77
  78         * source.c (find_and_open_source): Also rewrite relative file
  79         names.
  80
  81 2019-04-26  Amos Bird  <amosbird@gmail.com>
  82
  83         * annotate.c (annotate_thread_exited): Add "thread-exited"
  84         annotation.
  85
  86 2019-06-06  Tom Tromey  <tromey@adacore.com>
  87
  88         * maint.h (class scoped_command_stats): Use
  89         DISABLE_COPY_AND_ASSIGN.
  90         <print_time>: New method.
  91         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
  92         print_time.
  93         (scoped_command_stats::print_time): New method.
  94
  95 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
  98         instructions of lengths 6 or 8 bytes.
  99
 100 2019-06-04  Pedro Alves  <palves@redhat.com>
 101
 102         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 103
 104         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 105         * breakpoint.c (condition_completer): Likewise.
 106         * cli/cli-dump.c (scan_expression): Likewise.
 107         * common/filestuff.c (mkdir_recursive): Likewise.
 108         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 109         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 110         (gdb_abspath): Likewise.
 111         * compile/compile-cplus-types.c
 112         (compile_cplus_instance::decl_name): Likewise.
 113         * completer.c (complete_explicit_location):
 114         (signal_completer, reg_or_group_completer_1): Likewise.
 115         * cp-support.c (cp_remove_params_if_any): Likewise.
 116         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 117         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 118         * infcmd.c (strip_bg_char): Likewise.
 119         * linespec.c (copy_token_string): Likewise.
 120         * mi/mi-main.c (output_cores): Likewise.
 121         * psymtab.c (psymtab_search_name):
 122         * symfile.c (test_set_ext_lang_command): Likewise.
 123         * target.c (target_fileio_read_stralloc): Likewise.
 124         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 125         * value.c (complete_internalvar): Likewise.
 126
 127 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 128
 129         Add objfile property to gdb.Type.
 130         * NEWS: Mention Python API addition.
 131         * python/py-type.c (typy_get_objfile): New method.
 132
 133 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 134
 135         * NEWS: Mention the new set|show style [title|highlight].
 136         Mention changes to "show style", "help" and "apropos".
 137
 138 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 139
 140         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 141         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 142         instead of print_help_for_command.
 143         (print_doc_of_command): New function.
 144         (help_list): Add 'apropos -v word' suggestion.
 145         (print_help_for_command): Style the command name using title style.
 146         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 147         (_initialize_cli_cmds): Describe -v in apropos_command help.
 148
 149 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 150
 151         * cli/cli-style.h (cli_style_option): Add name in constructor,
 152         add m_name class member, add constructor with intensity,
 153         add name class function.
 154         (cli_style_option::add_setshow_commands): Remove name argument.
 155         (highlight_style, title_style): New styles.
 156         * cli/cli-style.c (do_show): New function that shows a style
 157         characteristic styling the style name with itself.
 158         (set_style_name): New function.
 159         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 160         Update all callers according to the changes in cli/cli-style.h.
 161         * utils.h (fputs_highlighted): New function.
 162         * utils.c (fputs_highlighted): Likewise.
 163
 164 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 165
 166         * NEWS: Mention new pipe command and new convenience variables.
 167
 168 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 169
 170         * cli/cli-cmds.c (pipe_command): New function.
 171         (_initialize_cli_cmds): Call add_com for pipe_command.
 172         Define | as an alias for pipe.
 173         (exit_status_set_internal_vars): New function.
 174         (shell_escape): Call exit_status_set_internal_vars.
 175         cli/cli-decode.c (find_command_name_length): Recognize | as
 176         a single character command.
 177
 178 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 179
 180         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 181         top.c (execute_command_to_ui_file): New function, mostly a copy
 182         of execute_command_to_string.
 183         (execute_command_to_string): Implement by calling
 184         execute_command_to_ui_file.
 185
 186 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 187
 188         * top.h (saved_command_line): Remove declaration.
 189         * top.c (previous_saved_command_line, previous_repeat_arguments):
 190         New variables.
 191         (saved_command_line): Make static, define together with other
 192         'repeat variables'.
 193         (dont_repeat): Clear repeat_arguments.
 194         (repeat_previous, get_saved_command_line, save_command_line):
 195         New functions.
 196         (gdb_init): Initialize saved_command_line
 197         and previous_saved_command_line.
 198         * main.c (captured_main_1): Remove saved_command_line initialization.
 199         * event-top.c (handle_line_of_input): Update to use
 200         the new 'repeat' related functions instead of direct access to
 201         saved_command_line.
 202         * command.h (repeat_previous, get_saved_command_line,
 203         save_command_line): New declarations.
 204         (dont_repeat): Add comment.
 205
 206 2019-05-30  Tom Tromey  <tromey@adacore.com>
 207
 208         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 209         Fix comment.
 210         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 211
 212 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 213
 214         PR cli/24587
 215         * completer.c (complete): Initialize variable word.
 216
 217 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 218
 219         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 220         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 221         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 222         'body' is NULL to the outter 'if', protecting the '!is_define'
 223         situation as well.
 224
 225 2019-05-29  Tom Tromey  <tromey@adacore.com>
 226
 227         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 228         (dwarf_unknown): New function.
 229         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 230         (dwarf_type_encoding_name): Use dwarf_unknown.
 231
 232 2019-05-29  Tom Tromey  <tromey@adacore.com>
 233
 234         PR c++/20020:
 235         * cp-valprint.c (cp_print_value_fields): Call
 236         cp_print_static_field inside "try".
 237
 238 2019-05-29  Tom Tromey  <tromey@adacore.com>
 239
 240         * inflow.c (struct terminal_info): Add default operator=.
 241         * configure: Rebuild.
 242         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 243         -Wdeprecated-copy-dtor, -Wredundant-move.
 244
 245 2019-05-29  Tom Tromey  <tromey@adacore.com>
 246
 247         * NEWS: Add entry.
 248         * infcmd.c (print_return_value_1): Handle finish_print
 249         option.
 250         (show_print_finish): New function.
 251         (_initialize_infcmd): Add "set/show print finish" commands.
 252         * valprint.c (user_print_options): Initialize new member.
 253         * valprint.h (struct value_print_options) <finish_print>: New
 254         member.
 255
 256 2019-05-28  Tom Tromey  <tromey@adacore.com>
 257
 258         * ada-lang.c (ada_remove_Xbn_suffix)
 259         (find_old_style_renaming_symbol)
 260         (parse_old_style_renaming): Remove.
 261         (ada_find_renaming_symbol): Don't call
 262         find_old_style_renaming_symbol.
 263         (ada_is_renaming_symbol): Rename from
 264         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 265         bool.  Now static.
 266         (ada_read_var_value): Update and simplify.
 267         * ada-exp.y (write_var_or_type): Remove old code.
 268
 269 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 270
 271         * event-top.c: Remove include comment.
 272         * inflow.c (class scoped_ignore_sigttou): Move from here...
 273         * inflow.h (class scoped_ignore_sigttou): ...to here.
 274         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 275         * top.c:  Remove include comment.
 276
 277 2019-05-27  Tom Tromey  <tom@tromey.com>
 278
 279         * NEWS: Fix typo.
 280
 281 2019-05-22  Tom Tromey  <tromey@adacore.com>
 282
 283         * target.c (target_follow_exec): Constify parameter.
 284         * target-delegates.c: Rebuild.
 285         * remote.c (remote_target::follow_exec): Constify parameter.
 286         * infrun.c (follow_exec): Constify parameter.
 287         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 288         (target_follow_exec): Likewise.
 289
 290 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 291
 292         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 293         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 294
 295 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 296
 297         * NEWS: Add debugredirect and testsuite sections.
 298
 299 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 300
 301         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 302         target descriptions using exclusively floating point register name
 303         aliases.
 304
 305 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         PR gdb/18644:
 308         * f-lang.c (build_fortran_types): Handle the case where
 309         gdbarch_floatformat_for_type returns a nullptr.
 310
 311 2019-05-21  Tom de Vries  <tdevries@suse.de>
 312
 313         PR cli/24587
 314         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 315
 316 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         PR gdb/18644:
 319         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 320         16-byte floats.
 321         * i386-tdep.c (i386_floatformat_for_type): Use
 322         floatformats_ia64_quad for the 16-byte floating point component
 323         within a fortran 32-byte complex number.
 324
 325 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 326
 327         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 328         delete default constructor.
 329         (find_partial_die): Update to return const struct.
 330         (partial_die_parent_scope): Move variable declaration into scope
 331         of its use and change its type to auto.
 332         (guess_partial_die_structure_name): Likewise.
 333         (partial_die_info::fixup): Likewise.
 334
 335 2019-05-17  Tom Tromey  <tromey@adacore.com>
 336
 337         * source.c (find_and_open_source): Remove cast.
 338
 339 2019-05-17  Tom Tromey  <tromey@adacore.com>
 340
 341         * annotate.c (annotate_source): Make "filename" const.
 342         * annotate.h (annotate_source): Use const.
 343
 344 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * disasm.c (set_disassembler_options): Send errors to stderr.
 347
 348 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 349
 350         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 351         (cli_interp_base::set_logging): Check debug_redirect.
 352         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 353         * cli/cli-logging.c (debug_redirect): Add static variable.
 354         (pop_output_files): Add default param.
 355         (handle_redirections): Print debug setting.
 356         (show_logging_command): Likewise.
 357         (_initialize_cli_logging): Add debugredirect command.
 358         * interps.c (current_interp_set_logging): Add debug_redirect
 359         parameter.
 360         * interps.h (set_logging): Add debug_redirect parameter.
 361         (current_interp_set_logging): Likewise.
 362         * mi/mi-common.h: Likewise.
 363         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 364
 365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 366             Tom Tromey  <tromey@adacore.com>
 367
 368         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 369         directly.
 370         * cli/cli-interp.h (make_logging_output): Remove declaration.
 371         * cli/cli-logging.c (make_logging_output): Remove function.
 372         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 373         directly.
 374         * ui-file.c (tee_file::tee_file): Remove bools.
 375         (tee_file::~tee_file): Remove deletes.
 376         * ui-file.h (tee_file): Remove bools.
 377
 378 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 379
 380         * mi/mi-cmds.h (mi_cmd_complete): New function.
 381         * mi/mi-main.c (mi_cmd_complete): Likewise.
 382         * mi/mi-cmds.c: Define new MI command -complete.
 383         * NEWS: Mention new -complete command.
 384
 385 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 386
 387         * completer.h (complete): New function.
 388         * completer.c (complete): Likewise.
 389         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 390         function defined in completer.h.
 391
 392 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 393
 394        * MAINTAINERS (Write After Approval): Add myself.
 395
 396 2019-05-17  Tom de Vries  <tdevries@suse.de>
 397
 398         PR gdb/24094
 399         * dwarf2read.c (struct cu_partial_die_info): New struct.
 400         (find_partial_die): Return cu_partial_die_info.
 401         (partial_die_parent_scope, guess_partial_die_structure_name)
 402         (partial_die_info::fixup): Handle new return type of find_partial_die.
 403
 404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 405
 406         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 407         "std::string", simplifying the algorithm.
 408
 409 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 410
 411         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 412         (stap_static_probe_ops::get_probes): Likewise.
 413
 414 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 415
 416         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 417         '-')" and "else if".
 418         (stap_parse_single_operand): Join checks for
 419         "gdbarch_stap_parse_special_token_p" and
 420         "gdbarch_stap_parse_special_token" in the same "if" statement.
 421         Invert check when verifying for operation on register
 422         displacement.
 423
 424 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 425
 426         * stap-probe.c (stap_get_opcode): Update comment.
 427         (stap_get_expected_argument_type): Likewise.
 428         (handle_stap_probe): Likewise.
 429
 430 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 431
 432         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 433         return type to 'bool'.  Adjust comment.  Use 'bool' when
 434         appropriate.
 435         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 436         * stap-probe.c (stap_parse_argument_1): Likewise.
 437         (stap_is_operator): Likewise.
 438         (stap_is_generic_prefix): Likewise.
 439         (stap_is_register_prefix): Likewise.
 440         (stap_is_register_indirection_prefix): Likewise.
 441         (stap_is_integer_prefix): Likewise.
 442         (stap_generic_check_suffix): Likewise.
 443         (stap_check_integer_suffix): Likewise.
 444         (stap_check_register_suffix): Likewise.
 445         (stap_check_register_indirection_suffix): Likewise.
 446         (stap_parse_register_operand): Likewise.
 447         (stap_parse_single_operand): Likewise.
 448         (stap_parse_argument_1): Likewise.
 449         (stap_probe::get_argument_count): Likewise.
 450         (stap_is_operator): Likewise.
 451
 452 2019-05-16  Tom Tromey  <tromey@adacore.com>
 453
 454         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 455         keyword to foreach.
 456
 457 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 458
 459         * linux-thread-db.c (try_thread_db_load_1): Change return type
 460         to bool.
 461         (try_thread_db_load): Likewise.
 462         (try_thread_db_load_from_pdir_1): Likewise.
 463         (try_thread_db_load_from_pdir): Likewise.
 464         (try_thread_db_load_from_sdir): Likewise.
 465         (try_thread_db_load_from_dir): Likewise.
 466         (thread_db_load_search): Likewise.
 467         (has_libpthread): Likewise.
 468         (thread_db_load): Likewise.
 469
 470 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 471
 472         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 473         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 474         NULL, and complain/return if that's the case.
 475
 476 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 477
 478         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 479         (advance, posn, abstract_read_memory): New functions.
 480         [struct mem_read_abstraction]: New struct.
 481         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 482
 483 2019-05-14  Tom Tromey  <tromey@adacore.com>
 484
 485         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 486         value is not lval_memory.
 487
 488 2019-05-14  Tom Tromey  <tromey@adacore.com>
 489
 490         * solib.c (info_sharedlibrary_command): Style the file name.
 491
 492 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 493
 494         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 495         (aarch64_vnv_type): Likewise.
 496         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 497         * common/tdesc.c: Likewise.
 498         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 499         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 500         * features/aarch64-fpu.xml: Add ieee half view.
 501         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 502         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 503         * gdbtypes.h (struct builtin_type): Likewise.
 504         (struct objfile_type): Likewise.
 505
 506 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 507
 508         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 509         typo.
 510         * location.h (string_to_event_location): Likewise.
 511
 512 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 513
 514         GDB 8.3 released.
 515
 516 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 517
 518         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 519         New variable declaration.
 520         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 521         New variable.
 522         (print_one_breakpoint): Use ui_out::test_flags and new global
 523         variable to compute use_fixed_output.
 524         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 525         Remove.
 526         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 527         (mi_multi_location_breakpoint_output_fixed): Remove.
 528         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 529         new variable.
 530         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 531         fix_multi_location_breakpoint_output flag if version >= 3.
 532         * ui-out.h (enum ui_out_flag)
 533         <fix_multi_location_breakpoint_output>: New enumerator.
 534
 535 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 536
 537         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 538
 539 2019-05-10  Tom Tromey  <tromey@adacore.com>
 540
 541         * ada-lang.c (catch_ada_completer): New function.
 542         (_initialize_ada_language): Use it.
 543
 544 2019-05-10  Tom Tromey  <tromey@adacore.com>
 545
 546         * thread.c (print_thread_info): Make "requested_threads" const.
 547         * gdbthread.h (print_thread_info): Make "requested_threads"
 548         const.
 549         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 550         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 551
 552 2019-05-08  Tom Tromey  <tom@tromey.com>
 553
 554         * gdbtypes.c (objfile_type_data): Change type.
 555         (objfile_type, _initialize_gdbtypes): Update.
 556
 557 2019-05-08  Tom Tromey  <tom@tromey.com>
 558
 559         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 560         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 561         (_initialize_dwarf2_frame): Update.
 562
 563 2019-05-08  Tom Tromey  <tom@tromey.com>
 564
 565         * objc-lang.c (objc_objfile_data): Change type.
 566         (find_methods): Update.
 567         (_initialize_objc_lang): Remove.
 568
 569 2019-05-08  Tom Tromey  <tom@tromey.com>
 570
 571         * stabsread.c (rs6000_builtin_type_data): Change type.
 572         (rs6000_builtin_type, _initialize_stabsread): Update.
 573
 574 2019-05-08  Tom Tromey  <tom@tromey.com>
 575
 576         * mips-tdep.c (mips_pdr_data): Remove.
 577         (_initialize_mips_tdep): Update.
 578
 579 2019-05-08  Tom Tromey  <tom@tromey.com>
 580
 581         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 582         (hppa_init_objfile_priv_data, read_unwind_info)
 583         (find_unwind_entry, _initialize_hppa_tdep): Update.
 584
 585 2019-05-08  Tom Tromey  <tom@tromey.com>
 586
 587         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 588         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 589         on obstack.
 590         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 591
 592 2019-05-08  Tom Tromey  <tom@tromey.com>
 593
 594         * mdebugread.c (basic_type_data): Change type.
 595         (basic_type, _initialize_mdebugread): Update.
 596
 597 2019-05-08  Tom Tromey  <tom@tromey.com>
 598
 599         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 600
 601 2019-05-08  Tom Tromey  <tom@tromey.com>
 602
 603         * nto-tdep.c (nto_inferior_data_reg): Change type.
 604         (nto_inferior_data): Update.
 605         (nto_inferior_data_cleanup, nto_new_inferior_data)
 606         (_initialize_nto_tdep): Remove.
 607         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 608
 609 2019-05-08  Tom Tromey  <tom@tromey.com>
 610
 611         * ada-lang.c (struct ada_inferior_data): Add initializers.
 612         (ada_inferior_data): Change type.
 613         (ada_inferior_data_cleanup): Remove.
 614         (get_ada_inferior_data, ada_inferior_exit)
 615         (struct ada_pspace_data): Add initializers, destructor.
 616         (ada_pspace_data_handle): Change type.
 617         (get_ada_pspace_data): Update.
 618         (ada_pspace_data_cleanup): Remove.
 619
 620 2019-05-08  Tom Tromey  <tom@tromey.com>
 621
 622         * coffread.c (struct coff_symfile_info): Add initializers.
 623         (coff_objfile_data_key): Move lower.  Change type.
 624         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 625         Update.
 626         (coff_free_info): Remove.
 627
 628 2019-05-08  Tom Tromey  <tom@tromey.com>
 629
 630         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 631         (fbsd_pspace_data_handle): Move lower.  Change type.
 632         (get_fbsd_pspace_data): Update.
 633         (fbsd_pspace_data_cleanup): Remove.
 634         (_initialize_fbsd_tdep): Update.
 635
 636 2019-05-08  Tom Tromey  <tom@tromey.com>
 637
 638         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 639         (get_ada_tasks_pspace_data): Update.
 640         (ada_tasks_pspace_data_cleanup): Remove.
 641         (_initialize_tasks): Update.
 642         (ada_tasks_inferior_data_handle): Change type.
 643         (get_ada_tasks_inferior_data): Update.
 644         (ada_tasks_inferior_data_cleanup): Remove.
 645         (struct ada_tasks_pspace_data): Add initializers.
 646
 647 2019-05-08  Tom Tromey  <tom@tromey.com>
 648
 649         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 650         * symfile-debug.c (debug_sym_get_probes): Change type.
 651         * stap-probe.c (handle_stap_probe):
 652         (stap_static_probe_ops::get_probes): Change type.
 653         * probe.h (class static_probe_ops) <get_probes>: Change type.
 654         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 655         (parse_probes_in_pspace): Update.
 656         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 657         Update.
 658         (any_static_probe_ops::get_probes): Change type.
 659         * elfread.c (elfread_data): New typedef.
 660         (probe_key): Change type.
 661         (elf_get_probes): Likewise.  Update.
 662         (probe_key_free): Remove.
 663         (_initialize_elfread): Update.
 664         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 665         Change type.
 666         (dtrace_process_dof_probe, dtrace_process_dof)
 667         (dtrace_static_probe_ops::get_probe): Change type.
 668
 669 2019-05-08  Tom Tromey  <tom@tromey.com>
 670
 671         * xcoffread.c (struct xcoff_symfile_info): Rename from
 672         coff_symfile_info.  Add initializers.
 673         (xcoff_objfile_data_key): Move lower.  Change type.
 674         (XCOFF_DATA): Rewrite.
 675         (xcoff_free_info): Remove.
 676         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 677         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 678         (xcoff_initial_scan): Update.
 679
 680 2019-05-08  Tom Tromey  <tom@tromey.com>
 681
 682         * solib-svr4.c (struct svr4_info): Add initializers and
 683         destructor.
 684         <probes_table>: Now an htab_up.
 685         (solib_svr4_pspace_data): Change type.
 686         (free_probes_table): Simplify.
 687         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 688         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 689         (probes_table_remove_objfile_probes, register_solib_event_probe)
 690         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 691         (_initialize_svr4_solib): Update.
 692
 693 2019-05-08  Tom Tromey  <tom@tromey.com>
 694
 695         * remote.c (remote_pspace_data): Change type.
 696         (remote_pspace_data_cleanup): Remove.
 697         (get_remote_exec_file, set_pspace_remote_exec_file)
 698         (_initialize_remote): Update.
 699
 700 2019-05-08  Tom Tromey  <tom@tromey.com>
 701
 702         * breakpoint.c (breakpoint_objfile_key): Change type.
 703         (get_breakpoint_objfile_data): Update.
 704         (free_breakpoint_objfile_data): Remove.
 705         (_initialize_breakpoint): Update.
 706
 707 2019-05-08  Tom Tromey  <tom@tromey.com>
 708
 709         * linux-tdep.c (struct linux_info): Add initializers.
 710         (linux_inferior_data): Move.  Change type.
 711         (invalidate_linux_cache_inf): Update.
 712         (linux_inferior_data_cleanup): Remove.
 713         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 714
 715 2019-05-08  Tom Tromey  <tom@tromey.com>
 716
 717         * auxv.c (auxv_inferior_data): Move.  Change type.
 718         (auxv_inferior_data_cleanup): Remove.
 719         (invalidate_auxv_cache_inf): Rewrite.
 720         (get_auxv_inferior_data, _initialize_auxv): Update.
 721
 722 2019-05-08  Tom Tromey  <tom@tromey.com>
 723
 724         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 725         (symfile_debug_objfile_data_key): Change type.
 726         (symfile_debug_installed, debug_qf_has_symbols)
 727         (debug_qf_find_last_source_symtab)
 728         (debug_qf_forget_cached_source_info)
 729         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 730         (debug_qf_print_stats, debug_qf_dump)
 731         (debug_qf_expand_symtabs_for_function)
 732         (debug_qf_expand_all_symtabs)
 733         (debug_qf_expand_symtabs_with_fullname)
 734         (debug_qf_map_matching_symbols)
 735         (debug_qf_expand_symtabs_matching)
 736         (debug_qf_find_pc_sect_compunit_symtab)
 737         (debug_qf_map_symbol_filenames)
 738         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 739         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 740         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 741         (debug_sym_read_linetable, debug_sym_relocate): Update.
 742         (symfile_debug_free_objfile): Remove.
 743         (install_symfile_debug_logging, _initialize_symfile_debug):
 744         Update.
 745
 746 2019-05-08  Tom Tromey  <tom@tromey.com>
 747
 748         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 749         allocate_on_obstack.
 750         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 751         (get_dwarf2_per_objfile): Update.
 752         (set_dwarf2_per_objfile): Remove.
 753         (dwarf2_has_info, dwarf2_get_section_info): Update.
 754         (dwarf2_free_objfile): Remove.
 755         (_initialize_dwarf2_read): Update.
 756
 757 2019-05-08  Tom Tromey  <tom@tromey.com>
 758
 759         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 760         initializers.
 761         <unsupported_script_warning_printed,
 762         script_not_found_warning_printed>: Now bool.
 763         (auto_load_pspace_data): Change type.
 764         (~auto_load_pspace_info): Rename from
 765         auto_load_pspace_data_cleanup.
 766         (get_auto_load_pspace_data, init_loaded_scripts_info)
 767         (clear_section_scripts, maybe_print_unsupported_script_warning)
 768         (maybe_print_script_not_found_warning, _initialize_auto_load):
 769         Update.
 770
 771 2019-05-08  Tom Tromey  <tom@tromey.com>
 772
 773         * objfiles.c (objfile_pspace_info): Add destructor and
 774         initializers.
 775         (objfiles_pspace_data): Change type.
 776         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 777         (get_objfile_pspace_data): Update.
 778         (objfiles_bfd_data): Change type.
 779         (get_objfile_bfd_data): Update.
 780         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 781
 782 2019-05-08  Tom Tromey  <tom@tromey.com>
 783
 784         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 785         Change type.
 786         (get_catch_syscall_inferior_data): Update.
 787         (catch_syscall_inferior_data_cleanup): Remove.
 788         (_initialize_break_catch_syscall): Update.
 789
 790 2019-05-08  Tom Tromey  <tom@tromey.com>
 791
 792         * inflow.c (struct terminal_info): Add destructor and
 793         initializers.
 794         (inflow_inferior_data): Change type.
 795         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 796         (get_inflow_inferior_data, inflow_inferior_exit)
 797         (swap_terminal_info, _initialize_inflow): Update.
 798
 799 2019-05-08  Tom Tromey  <tom@tromey.com>
 800
 801         * target-dcache.c (target_dcache_cleanup): Remove.
 802         (target_dcache_aspace_key): Change type.
 803         (target_dcache_init_p, target_dcache_invalidate)
 804         (target_dcache_get, target_dcache_get_or_init)
 805         (_initialize_target_dcache): Update.
 806         * dcache.h (struct dcache_deleter): New.
 807
 808 2019-05-08  Tom Tromey  <tom@tromey.com>
 809
 810         * symtab.c (struct symbol_cache): Add destructor and
 811         initializers.
 812         (symbol_cache_key): Move.  Change type.
 813         (make_symbol_cache, free_symbol_cache): Remove.
 814         (get_symbol_cache): Update.
 815         (symbol_cache_cleanup): Remove.
 816         (ALL_PSPACES, symbol_cache_flush)
 817         (maintenance_print_symbol_cache)
 818         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 819         Update.
 820
 821 2019-05-08  Tom Tromey  <tom@tromey.com>
 822
 823         * symtab.c (struct main_info): Add destructor and initializers.
 824         (main_progspace_key): Move.  Change type.
 825         (get_main_info): Update.
 826         (main_info_cleanup): Remove.
 827         (_initialize_symtab): Update.
 828
 829 2019-05-08  Tom Tromey  <tom@tromey.com>
 830
 831         * registry.h (DECLARE_REGISTRY): Define the _key class.
 832
 833 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * NEWS: Merge two 'New commands' sections.
 836
 837 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 838
 839         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 840         parameter and use Ada language definition instead.
 841         (ada_val_print_ptr): Remove unused language parameter.
 842         (ada_val_print_num): Remove language parameter and use Ada language
 843         definition instead.
 844         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 845         parameter.
 846         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 847         parameter and use Ada language definition instead.
 848         (ada_val_print_1): Update all ada_val_print_xxx calls.
 849         Remove language parameter.
 850         (ada_val_print): Update ada_val_print_1 call.
 851
 852 2019-05-08  Tom Tromey  <tromey@adacore.com>
 853
 854         * remote.c (remote_hw_watchpoint_limit)
 855         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 856         Now static.
 857
 858 2019-05-08  Tom Tromey  <tromey@adacore.com>
 859
 860         * maint.c (_initialize_maint_cmds): Move initialization code to
 861         remote.c.
 862         (watchdog, show_watchdog): Move to remote.c.
 863         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 864         "watchdog" static.
 865         (_initialize_remote): Move initialization code from maint.c.
 866         * defs.h (watchdog): Don't declare.
 867
 868 2019-05-08  Tom Tromey  <tromey@adacore.com>
 869
 870         * tui/tui-interp.c: Include main.h.
 871         * interps.c: Include main.h.
 872         * main.h (interpreter_p): Declare.
 873         * defs.h (interpreter_p): Don't declare.
 874
 875 2019-05-08  Tom Tromey  <tromey@adacore.com>
 876
 877         * dwarf2loc.c: Include dwarf2read.h.
 878         * defs.h (read_unsigned_leb128): Don't declare.
 879         * dwarf2read.h (read_unsigned_leb128): Declare.
 880
 881 2019-05-08  Tom Tromey  <tromey@adacore.com>
 882
 883         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 884         method.
 885
 886 2019-05-08  Tom Tromey  <tromey@adacore.com>
 887
 888         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 889         when no wrap column is set.
 890
 891 2019-05-08  Tom Tromey  <tromey@adacore.com>
 892
 893         * c-lang.c (c_get_string): Handle non-C-style arrays.
 894
 895 2019-05-08  Tom Tromey  <tromey@adacore.com>
 896
 897         * typeprint.c (print_offset_data::update): Print the bit offset,
 898         not the number of bits remaining.
 899
 900 2019-05-08  Tom Tromey  <tromey@adacore.com>
 901
 902         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 903         padding at end of comment.
 904
 905 2019-05-08  Tom Tromey  <tromey@adacore.com>
 906
 907         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 908         Compare main types.
 909
 910 2019-05-06  Tom Tromey  <tom@tromey.com>
 911
 912         * common/scoped_mmap.c: Include common-defs.h.
 913         * common/scoped_mmap.h: Don't include config.h.
 914
 915 2019-05-04  Tom Tromey  <tom@tromey.com>
 916
 917         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 918         (struct aarch64_call_info): Add initializers.
 919         <si>: Now a std::vector.
 920         (pass_on_stack, aarch64_push_dummy_call): Update.
 921
 922 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 923             Tom Tromey  <tom@tromey.com>
 924
 925         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 926         (ppc_threads): Now a std::vector.  Now static.
 927         (hwdebug_find_thread_points_by_tid)
 928         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 929         Update.
 930
 931 2019-05-04  Tom Tromey  <tom@tromey.com>
 932
 933         * arc-tdep.c (arc_tdesc_init): Return bool.
 934
 935 2019-05-04  Tom Tromey  <tom@tromey.com>
 936
 937         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 938         Use gdb_assert_not_reached.
 939
 940 2019-05-04  Tom Tromey  <tom@tromey.com>
 941
 942         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 943         "false".
 944
 945 2019-05-04  Tom Tromey  <tom@tromey.com>
 946
 947         * arc-tdep.c (arc_tdesc_init): Use bool.
 948
 949 2019-05-04  Tom Tromey  <tom@tromey.com>
 950
 951         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 952
 953 2019-05-04  Tom Tromey  <tom@tromey.com>
 954
 955         * cli/cli-cmds.c (valid_command_p): Return bool.
 956
 957 2019-05-04  Tom Tromey  <tom@tromey.com>
 958
 959         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 960         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 961
 962 2019-05-04  Raul Tambre  <raul@tambre.ee>
 963
 964         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 965         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 966         operator for comparison.
 967
 968 2019-05-04  Tom Tromey  <tom@tromey.com>
 969
 970         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 971         (lookup_partial_symbol, print_partial_symbols)
 972         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 973         (psymbol_compare): Update.
 974         (add_psymbol_to_bcache): Clear the entire psymbol.
 975         (maintenance_check_psymtabs): Update.
 976         * psympriv.h (struct partial_symbol): Don't derive from
 977         general_symbol_info.
 978         <obj_section, unrelocated_address, address,
 979         set_unrelocated_address>: Update.
 980         <ginfo>: New member.
 981         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 982         (debug_names::write_psymbols): Update.
 983
 984 2019-05-04  Tom de Vries  <tdevries@suse.de>
 985
 986         * contrib/cc-with-tweaks.sh: Support -n arg.
 987
 988 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 989
 990         * corelow.c (core_target::detach): Ensure frame cache and
 991         register caches are cleared.
 992         inferior.c (exit_inferior_1): Likewise.
 993
 994 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 995             Tom Tromey  <tom@tromey.com>
 996
 997         * dictionary.c (collate_pending_symbols_by_language): Remove
 998         "struct" from foreach.
 999         * symtab.c (lookup_global_symbol_from_objfile)
1000         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1001         foreach.
1002         * ser-tcp.c (net_open): Remove "struct" from foreach.
1003         * objfiles.c (objfile_relocate, objfile_rebase)
1004         (objfile_has_symbols): Remove "struct" from foreach.
1005         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1006         from foreach.
1007         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1008         foreach.
1009         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1010         "struct" from foreach.
1011         * ada-lang.c (create_excep_cond_exprs)
1012         (ada_exception_catchpoint_cond_string): Remove "struct" from
1013         foreach.
1014
1015 2019-05-03  Tom Tromey  <tromey@adacore.com>
1016
1017         * ada-exp.y (convert_char_literal): Check suffix of each
1018         enumerator.
1019
1020 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1021
1022         PR ada/21406:
1023         * ada-exp.y (yywrap): Don't define.
1024         * ada-lex.l (%option): Add noyywrap
1025         (yywrap): Remove.
1026
1027 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1028
1029         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1030         _WIN32_WINNT to the XP level, unless already defined to a higher
1031         level.
1032
1033         * unittests/parse-connection-spec-selftests.c:
1034         * ser-tcp.c:
1035         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1036         override.
1037
1038         * symfile.c (find_separate_debug_file): Remove colon from the
1039         drive spec of DOS/Windows file names of the target, so that the
1040         file name produced from DEBUGDIR and the target's directory will
1041         be valid on DOS/Windows systems.
1042
1043 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * rust-lang.c (val_print_struct): Handle printing structures
1046         containing strings.
1047
1048 2019-05-02  Tom Tromey  <tromey@adacore.com>
1049
1050         * valarith.c (_initialize_valarith): Remove.
1051
1052 2019-05-01  Tom Tromey  <tromey@adacore.com>
1053
1054         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1055         bitfields.
1056
1057 2019-05-01  Tom Tromey  <tromey@adacore.com>
1058
1059         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1060         for big-endian copies.
1061
1062 2019-04-30  Ali Tamur  <tamur@google.com>
1063         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1064         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1065         (read_3_bytes): New function.
1066
1067 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1068
1069         * windows-nat.c (main_thread_id): Delete.
1070         (handle_output_debug_string): Replace main_thread_id by
1071         current_event.dwThreadId.
1072         (fake_create_process): Likewise.
1073         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1074         Do not set main_thread_id.
1075         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1076         current_event.dwThreadId.
1077         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1078
1079 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1080
1081         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1082         Use current_event.dwThreadId instead of main_thread_id.
1083
1084 2019-04-30  Tom Tromey  <tromey@adacore.com>
1085
1086         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1087         (create_excep_cond_exprs): Iterate over program spaces.
1088         (ada_exception_catchpoint_cond_string): Examine all minimal
1089         symbols for exception types.
1090
1091 2019-04-30  Tom Tromey  <tromey@adacore.com>
1092
1093         PR c++/24470:
1094         * dwarf2read.c (process_structure_scope): Handle case where type
1095         has template parameters but no symbol was created.
1096
1097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1098             Chris January  <chris.january@arm.com>
1099
1100         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1101         qualifier.
1102         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1103
1104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * f-typeprint.c (f_print_type): Update rules for printing
1107         whitespace.
1108         (f_type_print_varspec_suffix): Likewise.
1109
1110 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1111             Chris January  <chris.january@arm.com>
1112
1113         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1114         function arguments.
1115
1116 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * f-lang.c (build_fortran_types): Change name of void type to
1119         lower case.
1120         * f-typeprint.c (f_type_print_base): Print the name of the void
1121         type, rather than a fixed string.
1122         * f-valprint.c (f_decorations): Use lower case void string.
1123
1124 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1125             Chris January  <chris.january@arm.com>
1126
1127         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1128         types for Fortran.
1129
1130 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1131             Chris January  <chris.january@arm.com>
1132             David Lecomber  <david.lecomber@arm.com>
1133
1134         * f-exp.y (BINOP_INTRINSIC): New token.
1135         (exp): New parser rule handling BINOP_INTRINSIC.
1136         (f77_keywords): Add new builtin procedures.
1137         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1138         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1139         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1140         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1141         (print_unop_subexp_f): New function.
1142         (print_binop_subexp_f): New function.
1143         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1144         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1145         (dump_subexp_body_f): Likewise.
1146         (operator_check_f): Likewise.
1147         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1148         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1149
1150 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1153         UNOP_KIND.
1154         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1155         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1156         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1157         (operator_length_f): New fuction.
1158         (print_subexp_f): New function.
1159         (op_name_f): New function.
1160         (dump_subexp_body_f): New function.
1161         (operator_check_f): New function.
1162         (exp_descriptor_f): Replace standard expression handling functions
1163         with new functions.
1164         * gdb/fortran-operator.def: New file.
1165         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1166         * gdb/std-operator.def: Remove UNOP_KIND.
1167
1168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * std-operator.def: Remove unbalanced, stray double quote
1171         character.
1172
1173 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1174             Chris January  <chris.january@arm.com>
1175             Daniel Everett  <daniel.everett@arm.com>
1176             Nick Forrington  <nick.forrington@arm.com>
1177             Richard Bunt  <richard.bunt@arm.com>
1178
1179         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1180         of depth when printing anonymous structs or unions.
1181         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1182         Don't print either the top-level value, or the children if the
1183         max-depth is exceeded.
1184         (ppscm_print_children): When printing the key of a map, allow one
1185         extra level of depth.
1186         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1187         print either the top-level value, or the children if the max-depth
1188         is exceeded.
1189         (print_children): When printing the key of a map, allow one extra
1190         level of depth.
1191         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1192         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1193         (user_print_options): Initialise max_depth field.
1194         (val_print_scalar_or_string_type_p): New function.
1195         (val_print): Check to see if the max depth has been reached.
1196         (val_print_check_max_depth): Define new function.
1197         (show_print_max_depth): New function.
1198         (_initialize_valprint): Add 'print max-depth' option.
1199         * valprint.h (struct value_print_options) <max_depth>: New field.
1200         (val_print_check_max_depth): Declare new function.
1201         * NEWS: Document new feature.
1202
1203 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * ada-lang.c (ada_language_defn): Initialise new field.
1206         * c-lang.c (c_is_string_type_p): New function.
1207         (c_language_defn): Initialise new field.
1208         (cplus_language_defn): Initialise new field.
1209         (asm_language_defn): Initialise new field.
1210         (minimal_language_defn): Initialise new field.
1211         * c-lang.h (c_is_string_type_p): Declare new function.
1212         * d-lang.c (d_language_defn): Initialise new field.
1213         * f-lang.c (f_is_string_type_p): New function.
1214         (f_language_defn): Initialise new field.
1215         * go-lang.c (go_is_string_type_p): New function.
1216         (go_language_defn): Initialise new field.
1217         * language.c (default_is_string_type_p): New function.
1218         (unknown_language_defn): Initialise new field.
1219         (auto_language_defn): Initialise new field.
1220         * language.h (struct language_defn) <la_is_string_type_p>: New
1221         member variable.
1222         (default_is_string_type_p): Declare new function.
1223         * m2-lang.c (m2_language_defn): Initialise new field.
1224         * objc-lang.c (objc_language_defn): Initialise new field.
1225         * opencl-lang.c (opencl_language_defn): Initialise new field.
1226         * p-lang.c (pascal_is_string_type_p): New function.
1227         (pascal_language_defn): Initialise new field.
1228         * rust-lang.c (rust_is_string_type_p): New function.
1229         (rust_language_defn): Initialise new field.
1230
1231 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1234         New field.
1235         * ada-lang.c (ada_language_defn): Initialise new field.
1236         * c-lang.c (c_language_defn): Likewise.
1237         (cplus_language_defn): Likewise.
1238         (asm_language_defn): Likewise.
1239         (minimal_language_defn): Likewise.
1240         * d-lang.c (d_language_defn): Likewise.
1241         * f-lang.c (f_language_defn): Likewise.
1242         * go-lang.c (go_language_defn): Likewise.
1243         * language.c (unknown_language_defn): Likewise.
1244         (auto_language_defn): Likewise.
1245         * m2-lang.c (m2_language_defn): Likewise.
1246         * objc-lang.c (objc_language_defn): Likewise.
1247         * opencl-lang.c (opencl_language_defn): Likewise.
1248         * p-lang.c (pascal_language_defn): Likewise.
1249         * rust-lang.c (rust_language_defn): Likewise.
1250
1251 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * ada-lang.c (ada_is_character_type): Change return type to bool.
1254         (ada_is_string_type): Likewise.
1255         * ada-lang.h (ada_is_character_type): Update declaration
1256         (ada_is_string_type): Likewise.
1257
1258 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         Support style in 'frame|thread apply'
1261
1262         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1263         * record.c (record_start, record_stop): Update callers of
1264         execute_command_to_string with false.
1265         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1266         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1267         methods.
1268         (class string_file): New constructor with term_out parameter.
1269         Override methods term_out and can_emit_style_escape.  New member
1270         term_out.
1271         (class stdio_file): Override can_emit_style_escape.
1272         (class tee_file): Override term_out and can_emit_style_escape.
1273         * utils.h (can_emit_style_escape): Remove.
1274         * utils.c (can_emit_style_escape): Likewise.
1275         Update all callers of can_emit_style_escape (SOMESTREAM) to
1276         SOMESTREAM->can_emit_style_escape.
1277         * source-cache.c (source_cache::get_source_lines): Likewise.
1278         * stack.c (frame_apply_command_count): Call execute_command_to_string
1279         passing the term_out characteristic of the current gdb_stdout.
1280         * thread.c (thr_try_catch_cmd): Likewise.
1281         * top.c (execute_command_to_string): pass term_out parameter
1282         to construct the string_file for the command output.
1283         * ui-file.c (term_cli_styling): New function (most code moved
1284         from utils.c can_emit_style_escape).
1285         (string_file::string_file, string_file::can_emit_style_escape,
1286         stdio_file::can_emit_style_escape, tee_file::term_out,
1287         tee_file::can_emit_style_escape): New functions.
1288
1289 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1290
1291         * NEWS: Mention the new set|show may-call-functions.
1292         * infcall.c (may_call_functions_p): New variable.
1293         (show_may_call_functions_p): New function.
1294         (call_function_by_hand_dummy): Throws an error if not
1295         may-call-functions.
1296         (_initialize_infcall): Call add_setshow_boolean_cmd for
1297         may-call-functions.
1298
1299 2019-04-25  Keith Seitz  <keiths@redhat.com>
1300
1301         PR c++/24367
1302         * cp-support.c (inspect_type): Don't attempt substitutions
1303         of symbol with the same name.
1304
1305 2019-04-25  Tom Tromey  <tromey@adacore.com>
1306
1307         PR gdb/24475:
1308         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1309         static.
1310
1311 2019-04-25  Tom Tromey  <tromey@adacore.com>
1312
1313         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1314         rvalue reference.
1315         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1316         (gdb_xml_parser::parse): Use std::move.
1317         * python/python-internal.h (gdbpy_convert_exception): Take a const
1318         reference.
1319         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1320         std::move.
1321         * python/py-utils.c (gdbpy_convert_exception): Take a const
1322         reference.
1323         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1324         Use std::move.
1325         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1326         Use std::move.
1327         * mi/mi-main.c (mi_print_exception): Take a const reference.
1328         * main.c (handle_command_errors): Take a const reference.
1329         * linespec.c (parse_linespec): Use std::move.
1330         * infcall.c (run_inferior_call): Use std::move.
1331         (call_function_by_hand_dummy): Use std::move.
1332         * exec.c (try_open_exec_file): Use std::move.
1333         * exceptions.h (exception_print, exception_fprintf)
1334         (exception_print_same): Update.
1335         * exceptions.c (print_exception, exception_print)
1336         (exception_fprintf, exception_print_same): Change parameters to
1337         const reference.
1338         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1339         * common/new-op.c: Use std::move.
1340         * common/common-exceptions.h (struct gdb_exception): Add move
1341         constructor.
1342         (struct gdb_exception_error, struct gdb_exception_quit, struct
1343         gdb_quit_bad_alloc): Change constructor to move constructor.
1344         (throw_exception): Change parameter to rvalue reference.
1345         * common/common-exceptions.c (throw_exception): Take rvalue
1346         reference.
1347         * cli/cli-interp.c (safe_execute_command): Use std::move.
1348         * breakpoint.c (insert_bp_location, location_to_sals): Use
1349         std::move.
1350
1351 2019-04-25  Tom Tromey  <tromey@adacore.com>
1352
1353         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1354         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1355         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1356         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1357         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1358         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1359         guile/scm-value.c: Use unpack.
1360         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1361         gdbscm_gdb_exception.
1362         (gdbscm_throw_gdb_exception): Likewise.
1363         (struct gdbscm_gdb_exception): New.
1364         (unpack): New function.
1365         (gdbscm_wrap): Use unpack.
1366
1367 2019-04-25  Tom Tromey  <tromey@adacore.com>
1368
1369         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1370         (gdb_rl_callback_handler): Use std::move.
1371         * common/common-exceptions.h (struct gdb_exception): Add move
1372         assignment operator.
1373         (throw_exception_sjlj): Change "exception" to const reference.
1374         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1375         (throw_exception_sjlj): Change "exception" to const reference.
1376
1377 2019-04-25  Tom Tromey  <tromey@adacore.com>
1378
1379         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1380         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1381         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1382         Update.
1383         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1384         Update.
1385         * mi/mi-interp.c (mi_interp::exec): Update.
1386         * linespec.c (parse_linespec): Update.
1387         * infcall.c (run_inferior_call): Update.
1388         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1389         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1390         (gdbscm_lookup_global_symbol): Update.
1391         * guile/scm-param.c (gdbscm_parameter_value): Update.
1392         * guile/scm-frame.c (gdbscm_frame_read_register)
1393         (gdbscm_frame_read_var): Update.
1394         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1395         * exec.c (try_open_exec_file): Update.
1396         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1397         (gdb_rl_callback_handler): Update.
1398         * common/common-exceptions.h (exception_none): Don't declare.
1399         * common/common-exceptions.c (exception_none): Don't define.
1400         (struct catcher) <exception>: Update.
1401         * cli/cli-interp.c (safe_execute_command): Update.
1402         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1403
1404 2019-04-25  Ali Tamur  <tamur@google.com>
1405
1406         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1407         (read_attribute_value): Likewise.
1408         (dwarf2_read_addr_index): Update comment.
1409         (read_str_index): Add DW_FORM_strx.
1410         (dwarf2_string_attr): Likewise.
1411         (dwarf2_const_value_attr): Likewise.
1412         (dump_die_shallow): Likewise.
1413         (dwarf2_fetch_constant_bytes): Likewise.
1414         (skip_form_bytes): Likewise.
1415         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1416
1417 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1418
1419         PR corefiles/11608
1420         PR corefiles/18187
1421         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1422         OFFSET.  Verify if current mapping contains an ELF header.
1423         (linux_find_memory_regions_full): Adjust call to
1424         dump_mapping_p.
1425
1426 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1427             Kang Li <kanglictf@gmail.com>
1428
1429         PR gdb/21600
1430
1431         * dwarf2-frame.c (read_initial_length): Be consistent about using
1432         unsigned representation of length.
1433         (decode_frame_entry_1): Likewise.  Check for wraparound of
1434         end pointer as well as buffer overflow.
1435
1436 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1437
1438         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1439         "vq".
1440
1441 2019-04-24  Tom Tromey  <tromey@adacore.com>
1442
1443         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1444
1445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * s12z-tdep.c (s12z_unwind_pc): Delete.
1448         (s12z_unwind_sp): Delete.
1449         (s12z_gdbarch_init): Don't register deleted functions with
1450         gdbarch.
1451
1452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * rl78-tdep.c (rl78_unwind_sp): Delete.
1455         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1456
1457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1460         (xstormy16_unwind_pc): Delete.
1461         (xstormy16_dummy_id): Delete.
1462         (xstormy16_gdbarch_init): Don't register deleted functions with
1463         gdbarch.
1464
1465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * vax-tdep.c (vax_unwind_pc): Delete.
1468         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1469
1470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * v850-tdep.c (v850_unwind_sp): Delete.
1473         (v850_unwind_pc): Delete.
1474         (v850_dummy_id): Delete.
1475         (v850_gdbarch_init): Don't register deleted functions with
1476         gdbarch.
1477
1478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1481         (tilegx_unwind_pc): Delete.
1482         (tilegx_unwind_dummy_id): Delete.
1483         (tilegx_gdbarch_init): Don't register deleted functions with
1484         gdbarch.
1485
1486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1489         (tic6x_dummy_id): Delete.
1490         (tic6x_gdbarch_init): Don't register deleted functions with
1491         gdbarch.
1492
1493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * sparc-tdep.c (sparc_unwind_pc): Delete.
1496         (sparc32_gdbarch_init): Don't register deleted function with
1497         gdbarch.
1498
1499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * sh-tdep.c (sh_unwind_sp): Delete.
1502         (sh_unwind_pc): Delete.
1503         (sh_dummy_id): Delete.
1504         (sh_gdbarch_init): Don't register deleted functions with
1505         gdbarch.
1506
1507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1508
1509         * score-tdep.c (score_unwind_sp): Delete.
1510         (score_unwind_pc): Delete.
1511         (score_dummy_id): Delete.
1512         (score_gdbarch_init): Don't register deleted functions with
1513         gdbarch.
1514
1515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * rx-tdep.c (rx_unwind_pc): Delete.
1518         (rx_unwind_sp): Delete.
1519         (rx_dummy_id): Delete.
1520         (rx_gdbarch_init): Don't register deleted functions with
1521         gdbarch.  Update comment.
1522
1523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1526         (rs6000_dummy_id): Delete.
1527         (rs6000_gdbarch_init): Don't register deleted functions with
1528         gdbarch.
1529
1530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * or1k-tdep.c (or1k_dummy_id): Delete.
1533         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1534
1535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * nios2-tdep.c (nios2_dummy_id): Delete.
1538         (nios2_unwind_sp): Delete.
1539         (nios2_gdbarch_init): Don't register deleted functions with
1540         gdbarch.
1541
1542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * nds32-tdep.c (nds32_dummy_id): Delete.
1545         (nds32_unwind_pc): Delete.
1546         (nds32_unwind_sp): Delete.
1547         (nds32_gdbarch_init): Don't register deleted functions with
1548         gdbarch.
1549
1550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * msp430-tdep.c (msp430_unwind_pc): Delete.
1553         (msp430_unwind_sp): Delete.
1554         (msp430_dummy_id): Delete.
1555         (msp430_gdbarch_init): Don't register deleted functions with
1556         gdbarch.
1557
1558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1559
1560         * moxie-tdep.c (moxie_unwind_sp): Delete.
1561         (moxie_unwind_pc): Delete.
1562         (moxie_dummy_id): Delete.
1563         (moxie_gdbarch_init): Don't register deleted functions with
1564         gdbarch.
1565
1566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1569         (mn10300_unwind_pc): Delete.
1570         (mn10300_unwind_sp): Delete.
1571         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1572         mn10300_unwind_sp.
1573         (mn10300_frame_unwind_init): Don't register deleted functions with
1574         gdbarch.
1575
1576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * mep-tdep.c (mep_unwind_pc): Delete.
1579         (mep_unwind_sp): Delete.
1580         (mep_dummy_id): Delete.
1581         (mep_gdbarch_init): Don't register deleted functions with
1582         gdbarch.
1583
1584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1587         (m68hc11_unwind_sp): Delete.
1588         (m68hc11_gdbarch_init): Don't register deleted functions with
1589         gdbarch.
1590
1591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * m32r-tdep.c (m32r_unwind_sp): Delete.
1594         (m32r_unwind_pc): Delete.
1595         (m32r_dummy_id): Delete.
1596         (m32r_gdbarch_init): Don't register deleted functions with
1597         gdbarch.
1598
1599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * m32c-tdep.c (m32c_unwind_pc): Delete.
1602         (m32c_unwind_sp): Delete.
1603         (m32c_dummy_id): Delete.
1604         (m32c_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1610         (lm32_unwind_pc): Delete.
1611         (lm32_dummy_id): Delete.
1612         (lm32_gdbarch_init): Don't register deleted functions with
1613         gdbarch.
1614
1615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1618         (iq2000_unwind_pc): Delete.
1619         (iq2000_dummy_id): Delete.
1620         (iq2000_gdbarch_init): Don't register deleted functions with
1621         gdbarch.
1622
1623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * nds32-tdep.c (nds32_type_align): Delete.
1626         (nds32_push_dummy_call): Use type_align instead.
1627
1628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * arm-tdep.c (arm_type_align): Only handle vector override case.
1631         (arm_push_dummy_call): Use type_align.
1632         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1633
1634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1637         case.
1638         (pass_on_stack): Use type_align.
1639         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1640         function.
1641
1642 2019-04-23  Tom Tromey  <tromey@adacore.com>
1643
1644         * dwarf2read.c (line_header::file_name_at): Remove unused
1645         overload.
1646
1647 2019-04-23  Tom de Vries  <tdevries@suse.de>
1648
1649         PR gdb/24438
1650         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1651         invocation.
1652
1653
1654 2019-03-27  Ali Tamur  <tamur@google.com>
1655
1656         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1657         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1658         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1659         (dwarf_expr_context::get_addr_index): Likewise
1660         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1661         (symbol_needs_eval_context::get_addr_index): Likewise
1662         (disassemble_dwarf_expression): Add DW_OP_addrx
1663         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1664         (read_cutu_die_from_dwo): Update comment
1665         (skip_one_die): Add DW_FORM_addrx
1666         (read_attribute_value): Likewise
1667         (var_decode_location): Add DW_OP_addrx
1668         (dwarf2_const_value_attr): Add DW_FORM_addrx
1669         (dump_die_shallow): Likewise
1670         (dwarf2_fetch_constant_bytes): Likewise
1671         (decode_locdesc): Add DW_OP_addrx
1672         (skip_form_bytes): Add DW_FORM_addrx
1673
1674 2019-04-22  Ali Tamur  <tamur@google.com>
1675
1676         * MAINTAINERS (Write After Approval): Add self.
1677
1678 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1679
1680         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1681         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1682         (open_symbol_file_object): Likewise.
1683         (svr4_default_sos): Add info parameter.
1684         (svr4_read_so_list): Likewise.
1685         (svr4_current_sos_direct): Adjust functions calls to pass down
1686         info.
1687         (svr4_current_sos_1): Add info parameter.
1688         (svr4_current_sos): Call get_svr4_info, pass info down to
1689         svr4_current_sos_1.
1690         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1691         get_svr4_info.
1692         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1693         get_svr4_info.
1694         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1695         to get_svr4_info.
1696         (probes_table_remove_objfile_probes): Likewise.
1697         (register_solib_event_probe): Add info parameter.
1698         (solist_update_incremental): Pass info parameter down to
1699         svr4_read_so_list.
1700         (disable_probes_interface): Add info parameter.
1701         (svr4_handle_solib_event): Pass current_program_space to
1702         get_svr4_info.  Adjust disable_probes_interface cleanup.
1703         (svr4_create_probe_breakpoints): Add info parameter, pass it
1704         down to register_solib_event_probe.
1705         (svr4_create_solib_event_breakpoints): Add info parameter,
1706         pass it down to svr4_create_probe_breakpoints.
1707         (enable_break): Pass info down to
1708         svr4_create_solib_event_breakpoints.
1709         (svr4_solib_create_inferior_hook): Pass current_program_space to
1710         get_svr4_info.
1711         (svr4_clear_solib): Likewise.
1712
1713 2019-04-22  Pedro Alves  <palves@redhat.com>
1714
1715         * solib-svr4.c (svr4_free_objfile_observer): New.
1716         (probe_and_action::objfile): New field.
1717         (probes_table_htab_remove_objfile_probes)
1718         (probes_table_remove_objfile_probes): New functions.
1719         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1720         in the new probe_and_action.  Don't store the probe in 'lookup'.
1721         (svr4_create_probe_breakpoints): Pass objfile to
1722         register_solib_event_probe.
1723         (_initialize_svr4_solib): Register a free_objfile observer.
1724
1725 2019-04-19  Tom Tromey  <tom@tromey.com>
1726
1727         * common/queue.h: Remove.
1728
1729 2019-04-19  Tom Tromey  <tom@tromey.com>
1730
1731         * event-loop.c: Don't include "common/queue.h".
1732
1733 2019-04-19  Tom Tromey  <tom@tromey.com>
1734
1735         * remote.c (remote_target): Use delete.
1736         * remote-notif.h: Include <list>, not "common/queue.h".
1737         (notif_client_p): Remove typedef.
1738         (remote_notif_state): Add constructor, destructor, initializer.
1739         <notif_queue>: Now a std::list.
1740         (remote_notif_state_xfree): Don't declare.
1741         * remote-notif.c (remote_notif_process, handle_notification)
1742         (remote_notif_state_allocate): Update.
1743         (~remote_notif_state): Rename from remote_notif_state_xfree.
1744
1745 2019-04-19  Tom Tromey  <tom@tromey.com>
1746
1747         * symfile.c (reread_symbols): Update.
1748         * objfiles.c (objfile_register_static_link)
1749         (objfile_lookup_static_link): Update
1750         (~objfile) Don't delete static_links.
1751         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1752
1753 2019-04-19  Tom Tromey  <tom@tromey.com>
1754
1755         * type-stack.h (struct type_stack) <insert>: Constify string.
1756         * type-stack.c (type_stack::insert): Constify string.
1757         * gdbtypes.h (lookup_template_type): Update.
1758         (address_space_name_to_int): Update.
1759         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1760         const.
1761         (lookup_template_type): Make name const.
1762         * c-exp.y: Update rules.
1763         (lex_one_token, classify_name, classify_inner_name)
1764         (c_print_token): Update.
1765         * p-exp.y: Update rules.
1766         (yylex): Update.
1767         * f-exp.y: Update rules.
1768         (yylex): Update.
1769         * d-exp.y: Update rules.
1770         (lex_one_token, classify_name, classify_inner_name): Update.
1771         * parse.c (write_dollar_variable, copy_name): Return std::string.
1772         * parser-defs.h (copy_name): Change return type.
1773         * m2-exp.y: Update rules.
1774         (yylex): Update.
1775         * go-exp.y (lex_one_token): Update.
1776         Update rules.
1777         (classify_unsafe_function, classify_packaged_name)
1778         (classify_name, yylex): Update.
1779
1780 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1781
1782         * configure.ac: add --enable-source-highlight switch.
1783         * configure: Regenerate.
1784         * top.c (print_gdb_version): plumb --enable-source-highlight
1785         status to "show configuration".
1786
1787 2019-04-19  Tom Tromey  <tromey@adacore.com>
1788
1789         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1790         Check ADA_TYPE_P.
1791         (empty_record, ada_template_to_fixed_record_type_1)
1792         (template_to_static_fixed_type)
1793         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1794         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1795         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1796         macros.
1797
1798 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1799
1800         PR symtab/24423:
1801         * source.c (print_source_lines_base): Advance "iter" when a
1802         control character is seen.
1803
1804 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1805
1806         * inferior.h (struct infcall_suspend_state_deleter):
1807         Catch exception in destructor to avoid crash.
1808
1809 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1810
1811         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1812         close to the add_com "shell".
1813
1814 2019-04-18  Tom Tromey  <tromey@adacore.com>
1815
1816         * process-stratum-target.h (class process_stratum_target)
1817         <stratum>: Add "final".
1818
1819 2019-04-17  Tom Tromey  <tromey@adacore.com>
1820
1821         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1822         against nullptr before use.
1823
1824 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1825
1826         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1827
1828 2019-04-17  Jim Wilson  <jimw@sifive.com>
1829             Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1832         code read might fail, assume 4-byte breakpoint in that case.
1833
1834 2019-04-15  Leszek Swirski  <leszeks@google.com>
1835
1836         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1837         rather than a hand-rolled POD check when checking for forced MEMORY
1838         classification.
1839
1840 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1841
1842         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1843         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1844         function.
1845         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1846         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1847         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1848         declaration.
1849
1850 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1851
1852         * aarch64-linux-nat.c
1853         (aarch64_linux_nat_target::thread_architecture): Add override.
1854         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1855         each VQ.
1856
1857 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1858
1859         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1860
1861 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1862
1863         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1864         target types of size 96-bits, add some additional comments, and
1865         check that the builtin type we found was the correct size.
1866
1867 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1868
1869         * utils.c (prompt_for_continue): Don't restore the styling at the
1870         end, as applied_style has the wrong value.  This fixes styling in
1871         long lists of file names that are interrupted by the "Continue?"
1872         prompt.
1873
1874 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1877         * c-lang.c (c_language_defn): Likewise.
1878         (cplus_language_defn): Likewise.
1879         (asm_language_defn): Likewise.
1880         (minimal_language_defn): Likewise.
1881         * d-lang.c (d_language_defn): Likewise.
1882         * f-lang.c (f_language_defn): Likewise.
1883         * go-lang.c (go_language_defn): Likewise.
1884         * language.c (unknown_language_defn): Likewise.
1885         (auto_language_defn): Likewise.
1886         * language.h (struct language_defn): Remove la_magic field.
1887         (LANG_MAGIC): Delete.
1888         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1889         * objc-lang.c (objc_language_defn): Likewise.
1890         * opencl-lang.c (opencl_language_defn): Likewise.
1891         * p-lang.c (pascal_language_defn): Likewise.
1892         * rust-lang.c (rust_language_defn): Likewise.
1893
1894 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * riscv-tdep.c (riscv_type_align): New function.
1897         (riscv_type_alignment): Delete.
1898         (riscv_arg_location): Use 'type_align'.
1899         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1900
1901 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1902
1903         * gdbtypes.c (type_align): A struct with no non-static fields also
1904         has alignment of 1.
1905
1906 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1909         component to 0.
1910         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1911         member.
1912         (riscv_struct_info::analyse): New implementation using new
1913         analyse_inner member function.
1914         (riscv_struct_info::field_offset): New member function.
1915         (riscv_struct_info::m_offsets): New member variable.
1916         (riscv_struct_info::analyse_inner): New private member function,
1917         takes the old implementation of riscv_struct_info::analyse but
1918         extended to track field offsets.
1919         (riscv_call_arg_struct): Update the struct folding special cases
1920         to handle cases where empty C++ structs, which are non-zero
1921         length, are found.
1922         (riscv_arg_location): Initialise the length of each location, a
1923         non-zero length now indicates the location is in use.
1924         (riscv_push_dummy_call): Allow for the first location having a
1925         non-zero offset when setting up arguments.
1926         (riscv_return_value): Likewise, but for return values.
1927
1928 2019-04-11  Tom Tromey  <tromey@adacore.com>
1929
1930         * utils.c (internal_vproblem): Make "msg" const.
1931
1932 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1933
1934         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1935         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1936         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1937         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1938
1939 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1940
1941         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1942         function.
1943         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1944         of amd64_collect_native_gregset.
1945         (amd64_linux_nat_target::store_registers): Likewise.
1946
1947 2019-04-10  Tom Tromey  <tom@tromey.com>
1948
1949         * symtab.c (lookup_global_symbol_from_objfile)
1950         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1951         * objfiles.h (class separate_debug_iterator): New.
1952         (class separate_debug_range): New.
1953         (struct objfile) <separate_debug_objfiles>: New method.
1954         (objfile_separate_debug_iterate): Don't declare.
1955         * objfiles.c (separate_debug_iterator::operator++): Rename from
1956         objfile_separate_debug_iterate.
1957         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1958         iterator.
1959         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1960         iterator.
1961
1962 2019-04-10  Tom Tromey  <tom@tromey.com>
1963
1964         * symfile.c (reread_symbols): Remove old comment.
1965         * objfiles.c (free_all_objfiles): Fix a typo.
1966
1967 2019-04-10  Tom Tromey  <tom@tromey.com>
1968
1969         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1970         * minsyms.c (lookup_minimal_symbol): Use foreach.
1971         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1972         (lookup_minimal_symbol_solib_trampoline): Likewise.
1973         * symfile.c (reread_symbols): Use foreach.
1974
1975 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1976             Tom Tromey  <tromey@adacore.com>
1977
1978         PR rust/24414:
1979         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1980         (rust_lex_int_test): Change "value" to be LONGEST.
1981         (rust_lex_tests): Add test for long integer literal.
1982
1983 2019-04-09  Tom Tromey  <tromey@adacore.com>
1984
1985         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1986         to bool.
1987         (extended_remote_target::attach): Update.
1988         (remote_target::remote_notice_new_inferior): Update.
1989         (remote_target::add_current_inferior_and_thread): Update.
1990         * inferior.c (exit_inferior_1): Use "false".
1991         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1992
1993 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1994
1995         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1996         the "start" command.
1997
1998 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1999
2000         * python/py-inferior.c (infpy_thread_from_thread_handle):
2001         Adjust comments to reflect renaming of thread_from_thread_handle
2002         to thread_from_handle.  Adjust keywords.  Fix type error message.
2003         (inferior_object_methods): Add thread_from_handle.  Retain
2004         thread_from_thread_handle, but mark it as deprecated.
2005
2006 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2007
2008         * gdbthread.h (find_thread_by_handle): Revise declaration.
2009         * thread.c (find_thread_by_handle): Likewise.  Adjust
2010         implementation too.
2011         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2012         support for buffer objects as handles.
2013
2014 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2015
2016         * python/py-infthread.c (thpy_thread_handle): New function.
2017         (thread_object_methods): Register thpy_thread_handle.
2018
2019 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2020
2021         * gdbthread.h (thread_to_thread_handle): Declare.
2022         * thread.c (gdbtypes.h): Include.
2023         (thread_to_thread_handle): New function.
2024
2025         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2026         (target_thread_info_to_thread_handle): Declare.
2027         * target.c (target_thread_info_to_thread_handle): New function.
2028         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2029         * target-delegates.c: Regenerate.
2030
2031         * linux-thread-db.c (class thread_db_target): Add method
2032         thread_info_to_thread_handle.
2033         (thread_db_target::thread_info_to_thread_handle): Define.
2034         * remote.c (class remote_target): Add new method
2035         thread_info_to_thread_handle.
2036         (remote_target::thread_info_to_thread_handle): Define.
2037
2038 2019-04-08  Pedro Alves  <palves@redhat.com>
2039
2040         * common/common-exceptions.c (throw_exception): Don't create
2041         named object to throw; throw directly.
2042         (throw_it): Likewise.  Don't initialize gdb_exception::message
2043         here, with new; pass FMT and AP to the ctor instead.
2044         * common/common-exceptions.h: Include <string>.
2045         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2046         const char *, va_list)): New ctor.  Use std::make_shared.
2047         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2048         errors)): Delete.
2049         (gdb_exception_error::gdb_exception_error(enum errors, const char
2050         *, va_list)): New.
2051         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2052         Add assertion.
2053         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2054         errors)): Delete.
2055         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2056         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2057         Add assertion.
2058
2059 2019-04-08  Tom Tromey  <tom@tromey.com>
2060
2061         * valops.c (value_rtti_indirect_type): Replace throw_exception
2062         with throw.
2063         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2064         with throw.
2065         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2066         throw.
2067         * target.c (target_translate_tls_address): Replace throw_exception
2068         with throw.
2069         * stack.c (frame_apply_command_count): Replace throw_exception
2070         with throw.
2071         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2072         throw.
2073         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2074         with throw.
2075         * rs6000-tdep.c (rs6000_frame_cache)
2076         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2077         * remote.c: Replace throw_exception with throw.
2078         * record-full.c (record_full_message, record_full_wait_1)
2079         (record_full_restore): Replace throw_exception with throw.
2080         * record-btrace.c:
2081         (get_thread_current_frame_id, record_btrace_start_replaying)
2082         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2083         (cmd_record_btrace_start): Replace throw_exception with throw.
2084         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2085         throw.
2086         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2087         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2088         * linespec.c:
2089         (find_linespec_symbols): Replace throw_exception with throw.
2090         * infrun.c (displaced_step_prepare, resume): Replace
2091         throw_exception with throw.
2092         * infcmd.c (post_create_inferior): Replace throw_exception with
2093         throw.
2094         * inf-loop.c (inferior_event_handler): Replace throw_exception
2095         with throw.
2096         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2097         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2098         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2099         (get_prev_frame_always, get_frame_pc_if_available)
2100         (get_frame_address_in_block_if_available, get_frame_language):
2101         Replace throw_exception with throw.
2102         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2103         throw_exception with throw.
2104         * eval.c (fetch_subexp_value, evaluate_var_value)
2105         (evaluate_funcall, evaluate_subexp_standard): Replace
2106         throw_exception with throw.
2107         * dwarf2loc.c (call_site_find_chain)
2108         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2109         Replace throw_exception with throw.
2110         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2111         with throw.
2112         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2113         throw.
2114         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2115         * completer.c (complete_line_internal): Replace throw_exception
2116         with throw.
2117         * compile/compile-object-run.c (compile_object_run): Replace
2118         throw_exception with throw.
2119         * cli/cli-script.c (process_next_line): Replace throw_exception
2120         with throw.
2121         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2122         (btrace_enable, btrace_maint_update_pt_packets): Replace
2123         throw_exception with throw.
2124         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2125         throw_exception with throw.
2126         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2127         throw_exception with throw.
2128         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2129         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2130         * aarch64-tdep.c (aarch64_make_prologue_cache)
2131         (aarch64_make_stub_cache): Replace throw_exception with throw.
2132
2133 2019-04-08  Tom Tromey  <tom@tromey.com>
2134
2135         * common/common-exceptions.c (throw_exception): Rename from
2136         throw_exception_cxx.  Remove old copy.  Make argument const.
2137         (throw_it): Create and throw exception objects directly.
2138         * common/common-exceptions.h (throw_exception): Make argument
2139         const.
2140         (struct gdb_exception_error): Add constructor.
2141         (struct gdb_exception_quit): Add constructor.
2142
2143 2019-04-08  Tom Tromey  <tom@tromey.com>
2144
2145         * common/common-exceptions.h (exception_rethrow): Don't declare.
2146         (TRY_SJLJ): Update comment.
2147         (TRY, CATCH, END_CATCH): Remove.
2148         * common/common-exceptions.c (exception_rethrow): Remove.
2149
2150 2019-04-08  Tom Tromey  <tom@tromey.com>
2151
2152         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2153         Remove.
2154         (gdb_exception_error): Rename from
2155         gdb_exception_RETURN_MASK_ERROR.
2156         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2157         (gdb_quit_bad_alloc): Update.
2158         * aarch64-tdep.c: Update.
2159         * ada-lang.c: Update.
2160         * ada-typeprint.c: Update.
2161         * ada-valprint.c: Update.
2162         * amd64-tdep.c: Update.
2163         * arch-utils.c: Update.
2164         * break-catch-throw.c: Update.
2165         * breakpoint.c: Update.
2166         * btrace.c: Update.
2167         * c-varobj.c: Update.
2168         * cli/cli-cmds.c: Update.
2169         * cli/cli-interp.c: Update.
2170         * cli/cli-script.c: Update.
2171         * common/common-exceptions.c: Update.
2172         * common/new-op.c: Update.
2173         * common/selftest.c: Update.
2174         * compile/compile-c-symbols.c: Update.
2175         * compile/compile-cplus-symbols.c: Update.
2176         * compile/compile-object-load.c: Update.
2177         * compile/compile-object-run.c: Update.
2178         * completer.c: Update.
2179         * corelow.c: Update.
2180         * cp-abi.c: Update.
2181         * cp-support.c: Update.
2182         * cp-valprint.c: Update.
2183         * darwin-nat.c: Update.
2184         * disasm-selftests.c: Update.
2185         * dtrace-probe.c: Update.
2186         * dwarf-index-cache.c: Update.
2187         * dwarf-index-write.c: Update.
2188         * dwarf2-frame-tailcall.c: Update.
2189         * dwarf2-frame.c: Update.
2190         * dwarf2loc.c: Update.
2191         * dwarf2read.c: Update.
2192         * eval.c: Update.
2193         * event-loop.c: Update.
2194         * event-top.c: Update.
2195         * exec.c: Update.
2196         * f-valprint.c: Update.
2197         * fbsd-tdep.c: Update.
2198         * frame-unwind.c: Update.
2199         * frame.c: Update.
2200         * gdbtypes.c: Update.
2201         * gnu-v3-abi.c: Update.
2202         * guile/guile-internal.h: Update.
2203         * guile/scm-block.c: Update.
2204         * guile/scm-breakpoint.c: Update.
2205         * guile/scm-cmd.c: Update.
2206         * guile/scm-disasm.c: Update.
2207         * guile/scm-frame.c: Update.
2208         * guile/scm-lazy-string.c: Update.
2209         * guile/scm-math.c: Update.
2210         * guile/scm-param.c: Update.
2211         * guile/scm-ports.c: Update.
2212         * guile/scm-pretty-print.c: Update.
2213         * guile/scm-symbol.c: Update.
2214         * guile/scm-symtab.c: Update.
2215         * guile/scm-type.c: Update.
2216         * guile/scm-value.c: Update.
2217         * i386-linux-tdep.c: Update.
2218         * i386-tdep.c: Update.
2219         * inf-loop.c: Update.
2220         * infcall.c: Update.
2221         * infcmd.c: Update.
2222         * infrun.c: Update.
2223         * jit.c: Update.
2224         * language.c: Update.
2225         * linespec.c: Update.
2226         * linux-fork.c: Update.
2227         * linux-nat.c: Update.
2228         * linux-tdep.c: Update.
2229         * linux-thread-db.c: Update.
2230         * main.c: Update.
2231         * mi/mi-cmd-break.c: Update.
2232         * mi/mi-cmd-stack.c: Update.
2233         * mi/mi-interp.c: Update.
2234         * mi/mi-main.c: Update.
2235         * objc-lang.c: Update.
2236         * p-valprint.c: Update.
2237         * parse.c: Update.
2238         * ppc-linux-tdep.c: Update.
2239         * printcmd.c: Update.
2240         * python/py-arch.c: Update.
2241         * python/py-breakpoint.c: Update.
2242         * python/py-cmd.c: Update.
2243         * python/py-finishbreakpoint.c: Update.
2244         * python/py-frame.c: Update.
2245         * python/py-framefilter.c: Update.
2246         * python/py-gdb-readline.c: Update.
2247         * python/py-inferior.c: Update.
2248         * python/py-infthread.c: Update.
2249         * python/py-lazy-string.c: Update.
2250         * python/py-linetable.c: Update.
2251         * python/py-objfile.c: Update.
2252         * python/py-param.c: Update.
2253         * python/py-prettyprint.c: Update.
2254         * python/py-progspace.c: Update.
2255         * python/py-record-btrace.c: Update.
2256         * python/py-record.c: Update.
2257         * python/py-symbol.c: Update.
2258         * python/py-type.c: Update.
2259         * python/py-unwind.c: Update.
2260         * python/py-utils.c: Update.
2261         * python/py-value.c: Update.
2262         * python/python.c: Update.
2263         * record-btrace.c: Update.
2264         * record-full.c: Update.
2265         * remote-fileio.c: Update.
2266         * remote.c: Update.
2267         * riscv-tdep.c: Update.
2268         * rs6000-aix-tdep.c: Update.
2269         * rs6000-tdep.c: Update.
2270         * rust-exp.y: Update.
2271         * rust-lang.c: Update.
2272         * s390-tdep.c: Update.
2273         * selftest-arch.c: Update.
2274         * solib-dsbt.c: Update.
2275         * solib-frv.c: Update.
2276         * solib-spu.c: Update.
2277         * solib-svr4.c: Update.
2278         * solib.c: Update.
2279         * sparc64-linux-tdep.c: Update.
2280         * stack.c: Update.
2281         * symfile-mem.c: Update.
2282         * symmisc.c: Update.
2283         * target.c: Update.
2284         * thread.c: Update.
2285         * top.c: Update.
2286         * tracefile-tfile.c: Update.
2287         * tui/tui.c: Update.
2288         * typeprint.c: Update.
2289         * unittests/cli-utils-selftests.c: Update.
2290         * unittests/parse-connection-spec-selftests.c: Update.
2291         * valops.c: Update.
2292         * valprint.c: Update.
2293         * value.c: Update.
2294         * varobj.c: Update.
2295         * windows-nat.c: Update.
2296         * x86-linux-nat.c: Update.
2297         * xml-support.c: Update.
2298
2299 2019-04-08  Tom Tromey  <tom@tromey.com>
2300
2301         * xml-support.c: Use C++ exception handling.
2302         * x86-linux-nat.c: Use C++ exception handling.
2303         * windows-nat.c: Use C++ exception handling.
2304         * varobj.c: Use C++ exception handling.
2305         * value.c: Use C++ exception handling.
2306         * valprint.c: Use C++ exception handling.
2307         * valops.c: Use C++ exception handling.
2308         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2309         handling.
2310         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2311         * typeprint.c: Use C++ exception handling.
2312         * tui/tui.c: Use C++ exception handling.
2313         * tracefile-tfile.c: Use C++ exception handling.
2314         * top.c: Use C++ exception handling.
2315         * thread.c: Use C++ exception handling.
2316         * target.c: Use C++ exception handling.
2317         * symmisc.c: Use C++ exception handling.
2318         * symfile-mem.c: Use C++ exception handling.
2319         * stack.c: Use C++ exception handling.
2320         * sparc64-linux-tdep.c: Use C++ exception handling.
2321         * solib.c: Use C++ exception handling.
2322         * solib-svr4.c: Use C++ exception handling.
2323         * solib-spu.c: Use C++ exception handling.
2324         * solib-frv.c: Use C++ exception handling.
2325         * solib-dsbt.c: Use C++ exception handling.
2326         * selftest-arch.c: Use C++ exception handling.
2327         * s390-tdep.c: Use C++ exception handling.
2328         * rust-lang.c: Use C++ exception handling.
2329         * rust-exp.y: Use C++ exception handling.
2330         * rs6000-tdep.c: Use C++ exception handling.
2331         * rs6000-aix-tdep.c: Use C++ exception handling.
2332         * riscv-tdep.c: Use C++ exception handling.
2333         * remote.c: Use C++ exception handling.
2334         * remote-fileio.c: Use C++ exception handling.
2335         * record-full.c: Use C++ exception handling.
2336         * record-btrace.c: Use C++ exception handling.
2337         * python/python.c: Use C++ exception handling.
2338         * python/py-value.c: Use C++ exception handling.
2339         * python/py-utils.c: Use C++ exception handling.
2340         * python/py-unwind.c: Use C++ exception handling.
2341         * python/py-type.c: Use C++ exception handling.
2342         * python/py-symbol.c: Use C++ exception handling.
2343         * python/py-record.c: Use C++ exception handling.
2344         * python/py-record-btrace.c: Use C++ exception handling.
2345         * python/py-progspace.c: Use C++ exception handling.
2346         * python/py-prettyprint.c: Use C++ exception handling.
2347         * python/py-param.c: Use C++ exception handling.
2348         * python/py-objfile.c: Use C++ exception handling.
2349         * python/py-linetable.c: Use C++ exception handling.
2350         * python/py-lazy-string.c: Use C++ exception handling.
2351         * python/py-infthread.c: Use C++ exception handling.
2352         * python/py-inferior.c: Use C++ exception handling.
2353         * python/py-gdb-readline.c: Use C++ exception handling.
2354         * python/py-framefilter.c: Use C++ exception handling.
2355         * python/py-frame.c: Use C++ exception handling.
2356         * python/py-finishbreakpoint.c: Use C++ exception handling.
2357         * python/py-cmd.c: Use C++ exception handling.
2358         * python/py-breakpoint.c: Use C++ exception handling.
2359         * python/py-arch.c: Use C++ exception handling.
2360         * printcmd.c: Use C++ exception handling.
2361         * ppc-linux-tdep.c: Use C++ exception handling.
2362         * parse.c: Use C++ exception handling.
2363         * p-valprint.c: Use C++ exception handling.
2364         * objc-lang.c: Use C++ exception handling.
2365         * mi/mi-main.c: Use C++ exception handling.
2366         * mi/mi-interp.c: Use C++ exception handling.
2367         * mi/mi-cmd-stack.c: Use C++ exception handling.
2368         * mi/mi-cmd-break.c: Use C++ exception handling.
2369         * main.c: Use C++ exception handling.
2370         * linux-thread-db.c: Use C++ exception handling.
2371         * linux-tdep.c: Use C++ exception handling.
2372         * linux-nat.c: Use C++ exception handling.
2373         * linux-fork.c: Use C++ exception handling.
2374         * linespec.c: Use C++ exception handling.
2375         * language.c: Use C++ exception handling.
2376         * jit.c: Use C++ exception handling.
2377         * infrun.c: Use C++ exception handling.
2378         * infcmd.c: Use C++ exception handling.
2379         * infcall.c: Use C++ exception handling.
2380         * inf-loop.c: Use C++ exception handling.
2381         * i386-tdep.c: Use C++ exception handling.
2382         * i386-linux-tdep.c: Use C++ exception handling.
2383         * guile/scm-value.c: Use C++ exception handling.
2384         * guile/scm-type.c: Use C++ exception handling.
2385         * guile/scm-symtab.c: Use C++ exception handling.
2386         * guile/scm-symbol.c: Use C++ exception handling.
2387         * guile/scm-pretty-print.c: Use C++ exception handling.
2388         * guile/scm-ports.c: Use C++ exception handling.
2389         * guile/scm-param.c: Use C++ exception handling.
2390         * guile/scm-math.c: Use C++ exception handling.
2391         * guile/scm-lazy-string.c: Use C++ exception handling.
2392         * guile/scm-frame.c: Use C++ exception handling.
2393         * guile/scm-disasm.c: Use C++ exception handling.
2394         * guile/scm-cmd.c: Use C++ exception handling.
2395         * guile/scm-breakpoint.c: Use C++ exception handling.
2396         * guile/scm-block.c: Use C++ exception handling.
2397         * guile/guile-internal.h: Use C++ exception handling.
2398         * gnu-v3-abi.c: Use C++ exception handling.
2399         * gdbtypes.c: Use C++ exception handling.
2400         * frame.c: Use C++ exception handling.
2401         * frame-unwind.c: Use C++ exception handling.
2402         * fbsd-tdep.c: Use C++ exception handling.
2403         * f-valprint.c: Use C++ exception handling.
2404         * exec.c: Use C++ exception handling.
2405         * event-top.c: Use C++ exception handling.
2406         * event-loop.c: Use C++ exception handling.
2407         * eval.c: Use C++ exception handling.
2408         * dwarf2read.c: Use C++ exception handling.
2409         * dwarf2loc.c: Use C++ exception handling.
2410         * dwarf2-frame.c: Use C++ exception handling.
2411         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2412         * dwarf-index-write.c: Use C++ exception handling.
2413         * dwarf-index-cache.c: Use C++ exception handling.
2414         * dtrace-probe.c: Use C++ exception handling.
2415         * disasm-selftests.c: Use C++ exception handling.
2416         * darwin-nat.c: Use C++ exception handling.
2417         * cp-valprint.c: Use C++ exception handling.
2418         * cp-support.c: Use C++ exception handling.
2419         * cp-abi.c: Use C++ exception handling.
2420         * corelow.c: Use C++ exception handling.
2421         * completer.c: Use C++ exception handling.
2422         * compile/compile-object-run.c: Use C++ exception handling.
2423         * compile/compile-object-load.c: Use C++ exception handling.
2424         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2425         * compile/compile-c-symbols.c: Use C++ exception handling.
2426         * common/selftest.c: Use C++ exception handling.
2427         * common/new-op.c: Use C++ exception handling.
2428         * cli/cli-script.c: Use C++ exception handling.
2429         * cli/cli-interp.c: Use C++ exception handling.
2430         * cli/cli-cmds.c: Use C++ exception handling.
2431         * c-varobj.c: Use C++ exception handling.
2432         * btrace.c: Use C++ exception handling.
2433         * breakpoint.c: Use C++ exception handling.
2434         * break-catch-throw.c: Use C++ exception handling.
2435         * arch-utils.c: Use C++ exception handling.
2436         * amd64-tdep.c: Use C++ exception handling.
2437         * ada-valprint.c: Use C++ exception handling.
2438         * ada-typeprint.c: Use C++ exception handling.
2439         * ada-lang.c: Use C++ exception handling.
2440         * aarch64-tdep.c: Use C++ exception handling.
2441
2442 2019-04-08  Tom Tromey  <tom@tromey.com>
2443
2444         * xml-support.c (gdb_xml_parser::parse): Update.
2445         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2446         * value.c (show_convenience): Update.
2447         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2448         (test_parse_flags_qcs): Update.
2449         * thread.c (thr_try_catch_cmd): Update.
2450         * target.c (target_translate_tls_address): Update.
2451         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2452         (info_frame_command_core, frame_apply_command_count): Update.
2453         * rust-exp.y (rust_lex_exception_test): Update.
2454         * riscv-tdep.c (riscv_print_one_register_info): Update.
2455         * remote.c (remote_target::enable_btrace): Update.
2456         * record-btrace.c (record_btrace_enable_warn): Update.
2457         * python/py-utils.c (gdbpy_convert_exception): Update.
2458         * printcmd.c (do_one_display, print_variable_and_value): Update.
2459         * mi/mi-main.c (mi_print_exception): Update.
2460         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2461         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2462         * linux-nat.c (linux_nat_target::attach): Update.
2463         * linux-fork.c (class scoped_switch_fork_info): Update.
2464         * infrun.c (displaced_step_prepare): Update.
2465         * infcall.c (call_function_by_hand_dummy): Update.
2466         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2467         * gnu-v3-abi.c (print_one_vtable): Update.
2468         * frame.c (get_prev_frame_always): Update.
2469         * f-valprint.c (info_common_command_for_block): Update.
2470         * exec.c (try_open_exec_file): Update.
2471         * exceptions.c (print_exception, exception_print)
2472         (exception_fprintf, exception_print_same): Update.
2473         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2474         * dwarf-index-cache.c (index_cache::store)
2475         (index_cache::lookup_gdb_index): Update.
2476         * darwin-nat.c (maybe_cache_shell): Update.
2477         * cp-valprint.c (cp_print_value_fields): Update.
2478         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2479         (gcc_cplus_symbol_address): Update.
2480         * compile/compile-c-symbols.c (gcc_convert_symbol)
2481         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2482         * common/selftest.c: Update.
2483         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2484         a std::string.
2485         (exception_try_scope_entry, exception_try_scope_exit): Don't
2486         declare.
2487         (struct exception_try_scope): Remove.
2488         (TRY): Don't use exception_try_scope.
2489         (struct gdb_exception): Add constructor, operator=.
2490         <what>: New method.
2491         (struct gdb_exception_RETURN_MASK_ALL)
2492         (struct gdb_exception_RETURN_MASK_ERROR)
2493         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2494         (struct gdb_quit_bad_alloc): Update.
2495         * common/common-exceptions.c (exception_none): Change
2496         initializer.
2497         (struct catcher) <state, exception>: Initialize inline.
2498         <prev>: Remove member.
2499         (current_catcher): Remove.
2500         (catchers): New global.
2501         (exceptions_state_mc_init): Simplify.
2502         (catcher_pop): Remove.
2503         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2504         (try_scope_depth, exception_try_scope_entry)
2505         (exception_try_scope_exit): Remove.
2506         (throw_exception_sjlj): Update.
2507         (exception_messages, exception_messages_size): Remove.
2508         (throw_it): Simplify.
2509         (gdb_exception_sliced_copy): Remove.
2510         (throw_exception_cxx): Update.
2511         * cli/cli-script.c (script_from_file): Update.
2512         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2513         Update.
2514         * ada-valprint.c (ada_val_print): Update.
2515         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2516         (create_excep_cond_exprs): Update.
2517
2518 2019-04-08  Tom Tromey  <tom@tromey.com>
2519
2520         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2521         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2522         (TRY, CATCH, END_CATCH): Remove some definitions.
2523         * common/common-exceptions.c: Don't use GDB_XCPT.
2524         (catcher_list_size): Remove.
2525         (throw_exception, throw_it): Simplify.
2526
2527 2019-04-05  Tom Tromey  <tom@tromey.com>
2528
2529         Revert the header-sorting patch.
2530         * ft32-tdep.c: Revert.
2531         * frv-tdep.c: Revert.
2532         * frv-linux-tdep.c: Revert.
2533         * frame.c: Revert.
2534         * frame-unwind.c: Revert.
2535         * frame-base.c: Revert.
2536         * fork-child.c: Revert.
2537         * findvar.c: Revert.
2538         * findcmd.c: Revert.
2539         * filesystem.c: Revert.
2540         * filename-seen-cache.h: Revert.
2541         * filename-seen-cache.c: Revert.
2542         * fbsd-tdep.c: Revert.
2543         * fbsd-nat.h: Revert.
2544         * fbsd-nat.c: Revert.
2545         * f-valprint.c: Revert.
2546         * f-typeprint.c: Revert.
2547         * f-lang.c: Revert.
2548         * extension.h: Revert.
2549         * extension.c: Revert.
2550         * extension-priv.h: Revert.
2551         * expprint.c: Revert.
2552         * exec.h: Revert.
2553         * exec.c: Revert.
2554         * exceptions.c: Revert.
2555         * event-top.c: Revert.
2556         * event-loop.c: Revert.
2557         * eval.c: Revert.
2558         * elfread.c: Revert.
2559         * dwarf2read.h: Revert.
2560         * dwarf2read.c: Revert.
2561         * dwarf2loc.c: Revert.
2562         * dwarf2expr.h: Revert.
2563         * dwarf2expr.c: Revert.
2564         * dwarf2-frame.c: Revert.
2565         * dwarf2-frame-tailcall.c: Revert.
2566         * dwarf-index-write.h: Revert.
2567         * dwarf-index-write.c: Revert.
2568         * dwarf-index-common.c: Revert.
2569         * dwarf-index-cache.h: Revert.
2570         * dwarf-index-cache.c: Revert.
2571         * dummy-frame.c: Revert.
2572         * dtrace-probe.c: Revert.
2573         * disasm.h: Revert.
2574         * disasm.c: Revert.
2575         * disasm-selftests.c: Revert.
2576         * dictionary.c: Revert.
2577         * dicos-tdep.c: Revert.
2578         * demangle.c: Revert.
2579         * dcache.h: Revert.
2580         * dcache.c: Revert.
2581         * darwin-nat.h: Revert.
2582         * darwin-nat.c: Revert.
2583         * darwin-nat-info.c: Revert.
2584         * d-valprint.c: Revert.
2585         * d-namespace.c: Revert.
2586         * d-lang.c: Revert.
2587         * ctf.c: Revert.
2588         * csky-tdep.c: Revert.
2589         * csky-linux-tdep.c: Revert.
2590         * cris-tdep.c: Revert.
2591         * cris-linux-tdep.c: Revert.
2592         * cp-valprint.c: Revert.
2593         * cp-support.c: Revert.
2594         * cp-namespace.c: Revert.
2595         * cp-abi.c: Revert.
2596         * corelow.c: Revert.
2597         * corefile.c: Revert.
2598         * continuations.c: Revert.
2599         * completer.h: Revert.
2600         * completer.c: Revert.
2601         * complaints.c: Revert.
2602         * coffread.c: Revert.
2603         * coff-pe-read.c: Revert.
2604         * cli-out.h: Revert.
2605         * cli-out.c: Revert.
2606         * charset.c: Revert.
2607         * c-varobj.c: Revert.
2608         * c-valprint.c: Revert.
2609         * c-typeprint.c: Revert.
2610         * c-lang.c: Revert.
2611         * buildsym.c: Revert.
2612         * buildsym-legacy.c: Revert.
2613         * build-id.h: Revert.
2614         * build-id.c: Revert.
2615         * btrace.c: Revert.
2616         * bsd-uthread.c: Revert.
2617         * breakpoint.h: Revert.
2618         * breakpoint.c: Revert.
2619         * break-catch-throw.c: Revert.
2620         * break-catch-syscall.c: Revert.
2621         * break-catch-sig.c: Revert.
2622         * blockframe.c: Revert.
2623         * block.c: Revert.
2624         * bfin-tdep.c: Revert.
2625         * bfin-linux-tdep.c: Revert.
2626         * bfd-target.c: Revert.
2627         * bcache.c: Revert.
2628         * ax-general.c: Revert.
2629         * ax-gdb.h: Revert.
2630         * ax-gdb.c: Revert.
2631         * avr-tdep.c: Revert.
2632         * auxv.c: Revert.
2633         * auto-load.c: Revert.
2634         * arm-wince-tdep.c: Revert.
2635         * arm-tdep.c: Revert.
2636         * arm-symbian-tdep.c: Revert.
2637         * arm-pikeos-tdep.c: Revert.
2638         * arm-obsd-tdep.c: Revert.
2639         * arm-nbsd-tdep.c: Revert.
2640         * arm-nbsd-nat.c: Revert.
2641         * arm-linux-tdep.c: Revert.
2642         * arm-linux-nat.c: Revert.
2643         * arm-fbsd-tdep.c: Revert.
2644         * arm-fbsd-nat.c: Revert.
2645         * arm-bsd-tdep.c: Revert.
2646         * arch-utils.c: Revert.
2647         * arc-tdep.c: Revert.
2648         * arc-newlib-tdep.c: Revert.
2649         * annotate.h: Revert.
2650         * annotate.c: Revert.
2651         * amd64-windows-tdep.c: Revert.
2652         * amd64-windows-nat.c: Revert.
2653         * amd64-tdep.c: Revert.
2654         * amd64-sol2-tdep.c: Revert.
2655         * amd64-obsd-tdep.c: Revert.
2656         * amd64-obsd-nat.c: Revert.
2657         * amd64-nbsd-tdep.c: Revert.
2658         * amd64-nbsd-nat.c: Revert.
2659         * amd64-nat.c: Revert.
2660         * amd64-linux-tdep.c: Revert.
2661         * amd64-linux-nat.c: Revert.
2662         * amd64-fbsd-tdep.c: Revert.
2663         * amd64-fbsd-nat.c: Revert.
2664         * amd64-dicos-tdep.c: Revert.
2665         * amd64-darwin-tdep.c: Revert.
2666         * amd64-bsd-nat.c: Revert.
2667         * alpha-tdep.c: Revert.
2668         * alpha-obsd-tdep.c: Revert.
2669         * alpha-nbsd-tdep.c: Revert.
2670         * alpha-mdebug-tdep.c: Revert.
2671         * alpha-linux-tdep.c: Revert.
2672         * alpha-linux-nat.c: Revert.
2673         * alpha-bsd-tdep.c: Revert.
2674         * alpha-bsd-nat.c: Revert.
2675         * aix-thread.c: Revert.
2676         * agent.c: Revert.
2677         * addrmap.c: Revert.
2678         * ada-varobj.c: Revert.
2679         * ada-valprint.c: Revert.
2680         * ada-typeprint.c: Revert.
2681         * ada-tasks.c: Revert.
2682         * ada-lang.c: Revert.
2683         * aarch64-tdep.c: Revert.
2684         * aarch64-ravenscar-thread.c: Revert.
2685         * aarch64-newlib-tdep.c: Revert.
2686         * aarch64-linux-tdep.c: Revert.
2687         * aarch64-linux-nat.c: Revert.
2688         * aarch64-fbsd-tdep.c: Revert.
2689         * aarch64-fbsd-nat.c: Revert.
2690         * aarch32-linux-nat.c: Revert.
2691
2692 2019-04-05  Tom Tromey  <tom@tromey.com>
2693
2694         * ft32-tdep.c: Sort headers.
2695         * frv-tdep.c: Sort headers.
2696         * frv-linux-tdep.c: Sort headers.
2697         * frame.c: Sort headers.
2698         * frame-unwind.c: Sort headers.
2699         * frame-base.c: Sort headers.
2700         * fork-child.c: Sort headers.
2701         * findvar.c: Sort headers.
2702         * findcmd.c: Sort headers.
2703         * filesystem.c: Sort headers.
2704         * filename-seen-cache.h: Sort headers.
2705         * filename-seen-cache.c: Sort headers.
2706         * fbsd-tdep.c: Sort headers.
2707         * fbsd-nat.h: Sort headers.
2708         * fbsd-nat.c: Sort headers.
2709         * f-valprint.c: Sort headers.
2710         * f-typeprint.c: Sort headers.
2711         * f-lang.c: Sort headers.
2712         * extension.h: Sort headers.
2713         * extension.c: Sort headers.
2714         * extension-priv.h: Sort headers.
2715         * expprint.c: Sort headers.
2716         * exec.h: Sort headers.
2717         * exec.c: Sort headers.
2718         * exceptions.c: Sort headers.
2719         * event-top.c: Sort headers.
2720         * event-loop.c: Sort headers.
2721         * eval.c: Sort headers.
2722         * elfread.c: Sort headers.
2723         * dwarf2read.h: Sort headers.
2724         * dwarf2read.c: Sort headers.
2725         * dwarf2loc.c: Sort headers.
2726         * dwarf2expr.h: Sort headers.
2727         * dwarf2expr.c: Sort headers.
2728         * dwarf2-frame.c: Sort headers.
2729         * dwarf2-frame-tailcall.c: Sort headers.
2730         * dwarf-index-write.h: Sort headers.
2731         * dwarf-index-write.c: Sort headers.
2732         * dwarf-index-common.c: Sort headers.
2733         * dwarf-index-cache.h: Sort headers.
2734         * dwarf-index-cache.c: Sort headers.
2735         * dummy-frame.c: Sort headers.
2736         * dtrace-probe.c: Sort headers.
2737         * disasm.h: Sort headers.
2738         * disasm.c: Sort headers.
2739         * disasm-selftests.c: Sort headers.
2740         * dictionary.c: Sort headers.
2741         * dicos-tdep.c: Sort headers.
2742         * demangle.c: Sort headers.
2743         * dcache.h: Sort headers.
2744         * dcache.c: Sort headers.
2745         * darwin-nat.h: Sort headers.
2746         * darwin-nat.c: Sort headers.
2747         * darwin-nat-info.c: Sort headers.
2748         * d-valprint.c: Sort headers.
2749         * d-namespace.c: Sort headers.
2750         * d-lang.c: Sort headers.
2751         * ctf.c: Sort headers.
2752         * csky-tdep.c: Sort headers.
2753         * csky-linux-tdep.c: Sort headers.
2754         * cris-tdep.c: Sort headers.
2755         * cris-linux-tdep.c: Sort headers.
2756         * cp-valprint.c: Sort headers.
2757         * cp-support.c: Sort headers.
2758         * cp-namespace.c: Sort headers.
2759         * cp-abi.c: Sort headers.
2760         * corelow.c: Sort headers.
2761         * corefile.c: Sort headers.
2762         * continuations.c: Sort headers.
2763         * completer.h: Sort headers.
2764         * completer.c: Sort headers.
2765         * complaints.c: Sort headers.
2766         * coffread.c: Sort headers.
2767         * coff-pe-read.c: Sort headers.
2768         * cli-out.h: Sort headers.
2769         * cli-out.c: Sort headers.
2770         * charset.c: Sort headers.
2771         * c-varobj.c: Sort headers.
2772         * c-valprint.c: Sort headers.
2773         * c-typeprint.c: Sort headers.
2774         * c-lang.c: Sort headers.
2775         * buildsym.c: Sort headers.
2776         * buildsym-legacy.c: Sort headers.
2777         * build-id.h: Sort headers.
2778         * build-id.c: Sort headers.
2779         * btrace.c: Sort headers.
2780         * bsd-uthread.c: Sort headers.
2781         * breakpoint.h: Sort headers.
2782         * breakpoint.c: Sort headers.
2783         * break-catch-throw.c: Sort headers.
2784         * break-catch-syscall.c: Sort headers.
2785         * break-catch-sig.c: Sort headers.
2786         * blockframe.c: Sort headers.
2787         * block.c: Sort headers.
2788         * bfin-tdep.c: Sort headers.
2789         * bfin-linux-tdep.c: Sort headers.
2790         * bfd-target.c: Sort headers.
2791         * bcache.c: Sort headers.
2792         * ax-general.c: Sort headers.
2793         * ax-gdb.h: Sort headers.
2794         * ax-gdb.c: Sort headers.
2795         * avr-tdep.c: Sort headers.
2796         * auxv.c: Sort headers.
2797         * auto-load.c: Sort headers.
2798         * arm-wince-tdep.c: Sort headers.
2799         * arm-tdep.c: Sort headers.
2800         * arm-symbian-tdep.c: Sort headers.
2801         * arm-pikeos-tdep.c: Sort headers.
2802         * arm-obsd-tdep.c: Sort headers.
2803         * arm-nbsd-tdep.c: Sort headers.
2804         * arm-nbsd-nat.c: Sort headers.
2805         * arm-linux-tdep.c: Sort headers.
2806         * arm-linux-nat.c: Sort headers.
2807         * arm-fbsd-tdep.c: Sort headers.
2808         * arm-fbsd-nat.c: Sort headers.
2809         * arm-bsd-tdep.c: Sort headers.
2810         * arch-utils.c: Sort headers.
2811         * arc-tdep.c: Sort headers.
2812         * arc-newlib-tdep.c: Sort headers.
2813         * annotate.h: Sort headers.
2814         * annotate.c: Sort headers.
2815         * amd64-windows-tdep.c: Sort headers.
2816         * amd64-windows-nat.c: Sort headers.
2817         * amd64-tdep.c: Sort headers.
2818         * amd64-sol2-tdep.c: Sort headers.
2819         * amd64-obsd-tdep.c: Sort headers.
2820         * amd64-obsd-nat.c: Sort headers.
2821         * amd64-nbsd-tdep.c: Sort headers.
2822         * amd64-nbsd-nat.c: Sort headers.
2823         * amd64-nat.c: Sort headers.
2824         * amd64-linux-tdep.c: Sort headers.
2825         * amd64-linux-nat.c: Sort headers.
2826         * amd64-fbsd-tdep.c: Sort headers.
2827         * amd64-fbsd-nat.c: Sort headers.
2828         * amd64-dicos-tdep.c: Sort headers.
2829         * amd64-darwin-tdep.c: Sort headers.
2830         * amd64-bsd-nat.c: Sort headers.
2831         * alpha-tdep.c: Sort headers.
2832         * alpha-obsd-tdep.c: Sort headers.
2833         * alpha-nbsd-tdep.c: Sort headers.
2834         * alpha-mdebug-tdep.c: Sort headers.
2835         * alpha-linux-tdep.c: Sort headers.
2836         * alpha-linux-nat.c: Sort headers.
2837         * alpha-bsd-tdep.c: Sort headers.
2838         * alpha-bsd-nat.c: Sort headers.
2839         * aix-thread.c: Sort headers.
2840         * agent.c: Sort headers.
2841         * addrmap.c: Sort headers.
2842         * ada-varobj.c: Sort headers.
2843         * ada-valprint.c: Sort headers.
2844         * ada-typeprint.c: Sort headers.
2845         * ada-tasks.c: Sort headers.
2846         * ada-lang.c: Sort headers.
2847         * aarch64-tdep.c: Sort headers.
2848         * aarch64-ravenscar-thread.c: Sort headers.
2849         * aarch64-newlib-tdep.c: Sort headers.
2850         * aarch64-linux-tdep.c: Sort headers.
2851         * aarch64-linux-nat.c: Sort headers.
2852         * aarch64-fbsd-tdep.c: Sort headers.
2853         * aarch64-fbsd-nat.c: Sort headers.
2854         * aarch32-linux-nat.c: Sort headers.
2855
2856 2019-04-04  Tom Tromey  <tom@tromey.com>
2857
2858         * varobj.c (varobj_create): Update.
2859         * rust-exp.y (struct rust_parser) <update_innermost_block,
2860         lookup_symbol>: New methods.
2861         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2862         Rename.
2863         (rust_parser::rust_lookup_type)
2864         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2865         * printcmd.c (display_command, do_one_display): Update.
2866         * parser-defs.h (struct parser_state) <parser_state>: Add
2867         "tracker" parameter.
2868         (block_tracker): New member.
2869         (class innermost_block_tracker) <innermost_block_tracker>: Add
2870         "types" parameter.
2871         <reset>: Remove method.
2872         (innermost_block): Don't declare.
2873         (null_post_parser): Update.
2874         * parse.c (innermost_block): Remove global.
2875         (write_dollar_variable): Update.
2876         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2877         Remove "tracker_types" parameter.
2878         (parse_expression): Add "tracker" parameter.
2879         (parse_expression_for_completion): Update.
2880         (null_post_parser): Add "tracker" parameter.
2881         * p-exp.y: Update rules.
2882         * m2-exp.y: Update rules.
2883         * language.h (struct language_defn) <la_post_parser>: Add
2884         "tracker" parameter.
2885         * go-exp.y: Update rules.
2886         * f-exp.y: Update rules.
2887         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2888         parameter.
2889         * d-exp.y: Update rules.
2890         * c-exp.y: Update rules.
2891         * breakpoint.c (set_breakpoint_condition): Create an
2892         innermost_block_tracker.
2893         (watch_command_1): Likewise.
2894         * ada-lang.c (resolve): Add "tracker" parameter.
2895         (resolve_subexp): Likewise.
2896         * ada-exp.y (write_var_from_sym): Update.
2897
2898 2019-04-04  Tom Tromey  <tom@tromey.com>
2899
2900         * type-stack.h: New file.
2901         * type-stack.c: New file.
2902         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2903         type-stack.h.
2904         (insert_into_type_stack, insert_type, push_type, push_type_int)
2905         (insert_type_address_space, pop_type, pop_type_int)
2906         (pop_typelist, pop_type_stack, append_type_stack)
2907         (push_type_stack, get_type_stack, push_typelist)
2908         (follow_type_instance_flags, follow_types): Don't declare.
2909         * parse.c (type_stack): Remove global.
2910         (parse_exp_in_context): Update.
2911         (insert_into_type_stack, insert_type, push_type, push_type_int)
2912         (insert_type_address_space, pop_type, pop_type_int)
2913         (pop_typelist, pop_type_stack, append_type_stack)
2914         (push_type_stack, get_type_stack, push_typelist)
2915         (follow_type_instance_flags, follow_types): Remove (moved to
2916         type-stack.c).
2917         * f-exp.y (type_stack): New global.
2918         Update rules.
2919         (push_kind_type, f_parse): Update.
2920         * d-exp.y (type_stack): New global.
2921         Update rules.
2922         (d_parse): Update.
2923         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2924         Update rules.
2925         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2926         (HFILES_NO_SRCDIR): Add type-stack.h.
2927
2928 2019-04-04  Tom Tromey  <tom@tromey.com>
2929
2930         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2931         (rust_parser::convert_ast_to_expression, rust_parse)
2932         (rust_lex_test_completion, rust_lex_tests): Update.
2933         * parser-defs.h (struct expr_completion_state): New.
2934         (struct parser_state) <parser_state>: Add completion parameter.
2935         <mark_struct_expression, mark_completion_tag>: New methods.
2936         <parse_completion, m_completion_state>: New members.
2937         (prefixify_expression, null_post_parser): Update.
2938         (mark_struct_expression, mark_completion_tag): Don't declare.
2939         * parse.c (parse_completion, expout_last_struct)
2940         (expout_tag_completion_type, expout_completion_name): Remove
2941         globals.
2942         (parser_state::mark_struct_expression)
2943         (parser_state::mark_completion_tag): Now methods.
2944         (prefixify_expression): Add last_struct parameter.
2945         (prefixify_subexp): Likewise.
2946         (parse_exp_1): Update.
2947         (parse_exp_in_context): Add cstate parameter.  Update.
2948         (parse_expression_for_completion): Create an
2949         expr_completion_state.
2950         (null_post_parser): Add "completion" parameter.
2951         * p-exp.y: Update rules.
2952         (yylex): Update.
2953         * language.h (struct language_defn) <la_post_parser>: Add
2954         "completing" parameter.
2955         * go-exp.y: Update rules.
2956         (lex_one_token): Update.
2957         * expression.h (parse_completion): Don't declare.
2958         * d-exp.y: Update rules.
2959         (lex_one_token): Update rules.
2960         * c-exp.y: Update rules.
2961         (lex_one_token): Update.
2962         * ada-lang.c (resolve): Add "parse_completion" parameter.
2963         (resolve_subexp): Likewise.
2964         (ada_resolve_function): Likewise.
2965
2966 2019-04-04  Tom Tromey  <tom@tromey.com>
2967
2968         * parser-defs.h (struct parser_state) <start_arglist,
2969         end_arglist>: New methods.
2970         <arglist_len, m_funcall_chain>: New members.
2971         (arglist_len, start_arglist, end_arglist): Don't declare.
2972         * parse.c (arglist_len, funcall_chain): Remove global.
2973         (start_arglist, end_arglist): Remove functions.
2974         (parse_exp_in_context): Update.
2975         * p-exp.y: Update rules.
2976         * m2-exp.y: Update rules.
2977         * go-exp.y: Update rules.
2978         * f-exp.y: Update rules.
2979         * d-exp.y: Update rules.
2980         * c-exp.y: Update rules.
2981
2982 2019-04-04  Tom Tromey  <tom@tromey.com>
2983
2984         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2985         lex_operator, push_back>: New methods.
2986         Update all rules.
2987         (rust_parser::lex_hex, lex_escape): Rename and update.
2988         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2989         (rust_parser::lex_operator): Rename and update.
2990         (rust_parser::lex_number, rustyylex, rustyyerror)
2991         (rust_lex_test_init, rust_lex_test_sequence)
2992         (rust_lex_test_push_back, rust_lex_tests): Update.
2993         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2994         parameter.
2995         <lexptr, prev_lexptr>: New members.
2996         (lexptr, prev_lexptr): Don't declare.
2997         * parse.c (lexptr, prev_lexptr): Remove globals.
2998         (parse_exp_in_context): Update.
2999         * p-exp.y (yylex, yyerror): Update.
3000         * m2-exp.y (parse_number, yylex, yyerror): Update.
3001         * go-exp.y (lex_one_token, yyerror): Update.
3002         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3003         * d-exp.y (lex_one_token, yyerror): Update.
3004         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3005         (lex_one_token, yyerror): Update.
3006         * ada-lex.l (YY_INPUT): Update.
3007         (rewind_to_char): Update.
3008         * ada-exp.y (yyerror): Update.
3009
3010 2019-04-04  Tom Tromey  <tom@tromey.com>
3011
3012         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3013         * parser-defs.h (struct parser_state) <parser_state>: Add new
3014         parameter.
3015         <comma_terminates>: New member.
3016         (comma_terminates): Don't declare global.
3017         * parse.c (comma_terminates): Remove global.
3018         (parse_exp_in_context): Update.
3019         * p-exp.y (yylex): Update.
3020         * m2-exp.y (yylex): Update.
3021         * go-exp.y (lex_one_token): Update.
3022         * f-exp.y (yylex): Update.
3023         * d-exp.y (lex_one_token): Update.
3024         * c-exp.y (lex_one_token): Update.
3025         * ada-lex.l: Update.
3026
3027 2019-04-04  Tom Tromey  <tom@tromey.com>
3028
3029         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3030         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3031         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3032         * parser-defs.h (paren_depth): Don't declare.
3033         * parse.c (paren_depth): Remove global.
3034         (parse_exp_in_context): Update.
3035         * p-exp.y (paren_depth): New global.
3036         (pascal_parse): Initialize it.
3037         * m2-exp.y (paren_depth): New global.
3038         (m2_parse): Initialize it.
3039         * go-exp.y (paren_depth): New global.
3040         (go_parse): Initialize it.
3041         * f-exp.y (paren_depth): New global.
3042         (f_parse): Initialize it.
3043         * d-exp.y (paren_depth): New global.
3044         (d_parse): Initialize it.
3045         * c-exp.y (paren_depth): New global.
3046         (c_parse): Initialize it.
3047         * ada-lex.l (paren_depth): New global.
3048         (lexer_init): Initialize it.
3049
3050 2019-04-04  Tom Tromey  <tom@tromey.com>
3051
3052         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3053         (rust_parser::convert_ast_to_type)
3054         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3055         * parser-defs.h (struct parser_state) <parser_state>: Add
3056         parameters.  Initialize new members.
3057         <expression_context_block, expression_context_pc>: New members.
3058         * parse.c (expression_context_block, expression_context_pc):
3059         Remove globals.
3060         (parse_exp_in_context): Update.
3061         * p-exp.y: Update all rules.
3062         (yylex): Update.
3063         * m2-exp.y: Update all rules.
3064         (yylex): Update.
3065         * go-exp.y (yylex): Update.
3066         * f-exp.y (yylex): Update.
3067         * d-exp.y: Update all rules.
3068         (yylex): Update.
3069         * c-exp.y: Update all rules.
3070         (lex_one_token, classify_name, yylex, c_parse): Update.
3071         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3072
3073 2019-04-04  Tom Tromey  <tom@tromey.com>
3074
3075         * gdbarch.h, gdbarch.c: Rebuild.
3076         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3077         * stap-probe.h:
3078         (struct stap_parse_info): Replace "parser_state" with
3079         "expr_builder".
3080         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3081         (parser_state): New class.
3082         * parse.c (expr_builder): Rename.
3083         (expr_builder::release): Rename.
3084         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3085         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3086         (write_exp_elt_longcst, write_exp_elt_floatcst)
3087         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3088         (write_exp_string_vector, write_exp_bitstring)
3089         (write_exp_msymbol, mark_struct_expression)
3090         (write_dollar_variable)
3091         (insert_type_address_space, increase_expout_size): Replace
3092         "parser_state" with "expr_builder".
3093         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3094         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3095         "parser_state" with "expr_builder".
3096
3097 2019-04-04  Tom Tromey  <tom@tromey.com>
3098
3099         * rust-exp.y: Replace "parse_language" with method call.
3100         * p-exp.y:
3101         (yylex): Replace "parse_language" with method call.
3102         * m2-exp.y:
3103         (yylex): Replace "parse_language" with method call.
3104         * go-exp.y (classify_name): Replace "parse_language" with method
3105         call.
3106         * f-exp.y (yylex): Replace "parse_language" with method call.
3107         * d-exp.y (lex_one_token): Replace "parse_language" with method
3108         call.
3109         * c-exp.y:
3110         (lex_one_token, classify_name, yylex): Replace "parse_language"
3111         with method call.
3112         * ada-exp.y (find_primitive_type, type_char)
3113         (type_system_address): Replace "parse_language" with method call.
3114
3115 2019-04-04  Tom Tromey  <tom@tromey.com>
3116
3117         * rust-exp.y: Replace "parse_gdbarch" with method call.
3118         * parse.c (write_dollar_variable, insert_type_address_space):
3119         Replace "parse_gdbarch" with method call.
3120         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3121         call.
3122         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3123         call.
3124         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3125         "parse_gdbarch" with method call.
3126         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3127         with method call.
3128         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3129         "parse_gdbarch" with method call.
3130         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3131         "parse_gdbarch" with method call.
3132         * c-exp.y (parse_type, parse_number, classify_name): Replace
3133         "parse_gdbarch" with method call.
3134         * ada-lex.l: Replace "parse_gdbarch" with method call.
3135         * ada-exp.y (parse_type, find_primitive_type, type_char)
3136         (type_system_address): Replace "parse_gdbarch" with method call.
3137
3138 2019-04-04  Tom Tromey  <tom@tromey.com>
3139
3140         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3141         * stap-probe.c (stap_parse_argument): Update.
3142         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3143         initial_size parameter.
3144         * rust-exp.y (rust_lex_tests): Update.
3145         * parse.c (parser_state): Update.
3146         (parse_exp_in_context): Update.
3147         * parser-defs.h (struct parser_state) <parser_state>: Remove
3148         "initial_size" parameter.
3149
3150 2019-04-04  Tom Tromey  <tom@tromey.com>
3151
3152         * parser-defs.h (increase_expout_size): Don't declare.
3153         * parse.c (increase_expout_size): Now static.
3154
3155 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3156
3157         * gnu-nat.c (gnu_nat_target::wait): Fix
3158         target_waitstatus_to_string call.
3159
3160 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * eval.c (evaluate_subexp_standard): Handle internal functions
3163         during Fortran function call handling.
3164
3165 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * NEWS: Mention new internal functions.
3168         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3169         (read_base_type): Use dwarf2_init_complex_target_type.
3170         * value.c (creal_internal_fn): New function.
3171         (cimag_internal_fn): New function.
3172         (_initialize_values): Register new internal functions.
3173
3174 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3175
3176         * infrun.c (stop_all_threads): If debug_infrun, always
3177         trace the wait status after wait_one, using
3178         target_waitstatus_to_string and target_pid_to_str.
3179         (handle_inferior_event): Replace various trace of
3180         wait status kind by a single trace.
3181         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3182         wait status kind image by target_waitstatus_to_string.
3183         * target/waitstatus.c (target_waitstatus_to_string): Fix
3184         obsolete comment.
3185
3186 2019-04-01  Tom Tromey  <tromey@adacore.com>
3187
3188         PR symtab/23331:
3189         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3190
3191 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3192             Pedro Alves  <palves@redhat.com>
3193
3194         * top.c (quit_force): Call 'finalize_values'.
3195         * value.c (finalize_values): New function.
3196         * value.h (finalize_values): Declare.
3197
3198 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3199
3200         * NEWS: Announce $_gdb_major and $_gdb_minor.
3201
3202         * top.c (init_gdb_version_vars): New function.
3203         (gdb_init): Call init_gdb_version_vars.
3204
3205 2019-03-29  Tom Tromey  <tromey@adacore.com>
3206
3207         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3208         help text.  Remove dead code.
3209
3210 2019-03-29  Keith Seitz  <keiths@redhat.com>
3211
3212         From Siddhesh Poyarekar:
3213         * f-lang.h (f77_get_upperbound): Return LONGEST.
3214         (f77_get_lowerbound): Likewise.
3215         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3216         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3217         print them.
3218         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3219         plongest to format print it.
3220         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3221         (f77_get_upperbound): Likewise.
3222         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3223         LOWER_BOUND to LONGEST.
3224         (f77_create_arrayprint_offset_tbl): Likewise.
3225
3226 2019-03-29  Keith Seitz  <keiths@redhat.com>
3227
3228         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3229         %s/pulongest for TYPE_LENGTH instead of %d in format
3230         strings.
3231         * ada-typerint.c (ada_print_type): Likewise.
3232         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3233         * compile/compile-c-support.c (generate_register_struct): Likewise.
3234         * gdbtypes.c (recursive_dump_type): Likewise.
3235         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3236         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3237         instead of %d in format strings.
3238         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3239         to std::min to ULONGEST.
3240         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3241         instead of %d in format strings.
3242         * tracepoint.c (info_scope_command): Likewise.
3243         * typeprint.c (print_offset_data::update)
3244         (print_offset_data::finish): Likewise.
3245         * xtensa-tdep.c (xtensa_store_return_value)
3246         (xtensa_push_dummy_call): Likewise.
3247
3248 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3249
3250         * windows-nat.c (display_selector): Fixed format specifications
3251         for 64-bit Cygwin.
3252
3253 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3254
3255         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3256
3257 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3258
3259         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3260         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3261         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3262         (nios2_linux_init_abi): Install it.
3263
3264 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3265
3266         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3267
3268 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3269
3270         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3271
3272 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3273             Tom Tromey  <tromey@adacore.com>
3274
3275         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3276
3277 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3278
3279         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3280         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3281         method to compute the bounds of range types. Also print "[evaluated]"
3282         if the bounds' values come from a dynamic evaluation.
3283
3284 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3287         whitespace when pretty printing is on.
3288
3289 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3290
3291         * ppc-linux-nat.c: Add include.
3292
3293 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3294
3295         * NEWS: Mention AArch64 Pointer Authentication.
3296
3297 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3298
3299         * arm-linux-nat.c: Add include.
3300
3301 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3302
3303         * source-cache.c (source_cache::get_source_lines): Re-read
3304         fullname after calling open_source_file.
3305
3306 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3307
3308         * NEWS: Mention TLS support for FreeBSD.
3309
3310 2019-03-25  Tom Tromey  <tromey@adacore.com>
3311
3312         * minsyms.c (BUNCH_SIZE): Update comment.
3313         (~minimal_symbol_reader): Remove old comment.
3314         (compact_minimal_symbols): Update comment.
3315         (minimal_symbol_reader::install): Remove old comment.  Update
3316         other comments.
3317
3318 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3319
3320         * s390-linux-nat.c: Add include.
3321
3322 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3323
3324         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3325         Call linux_get_hwcap.
3326         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3327         Likewise.
3328         (aarch64_linux_get_hwcap): Remove function.
3329         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3330         declaration.
3331         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3332         linux_get_hwcap.
3333         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3334         * linux-tdep.c (linux_get_hwcap): Add function.
3335         (linux_get_hwcap2): Likewise.
3336         * linux-tdep.h (linux_get_hwcap): Add declaration.
3337         (linux_get_hwcap2): Likewise.
3338         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3339         (ppc_linux_get_hwcap2): Likewise.
3340         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3341         linux_get_hwcap.
3342         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3343         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3344         (ppc_linux_nat_target::read_description): Likewise.
3345         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3346         * s390-linux-nat.c: Likewise.
3347         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3348
3349 2019-03-24  Tom Tromey  <tom@tromey.com>
3350
3351         * ada-lang.c (standard_lookup): Simplify initialization.
3352         (ada_lookup_symbol_nonlocal): Simplify return.
3353         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3354         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3355         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3356         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3357         initialization.
3358         * solib.c (solib_global_lookup): Simplify.
3359         * symtab.c (null_block_symbol): Remove.
3360         (symbol_cache_lookup): Simplify returns.
3361         (lookup_language_this): Simplify returns.
3362         (lookup_symbol_aux): Simplify return.
3363         (lookup_local_symbol): Simplify returns.
3364         (lookup_global_symbol_from_objfile): Simplify return.
3365         (lookup_symbol_in_objfile_symtabs)
3366         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3367         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3368         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3369         * cp-namespace.c (cp_lookup_bare_symbol)
3370         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3371         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3372         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3373         (cp_lookup_symbol_via_imports): Simplify initialization.
3374         (find_symbol_in_baseclass): Likewise.
3375         * symtab.h (null_block_symbol): Remove.
3376         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3377         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3378         (d_lookup_symbol_module): Likewise.
3379         (find_symbol_in_baseclass): Simplify initialization.
3380
3381 2019-03-24  Tom Tromey  <tom@tromey.com>
3382
3383         * expression.h: Don't include symtab.h.
3384         (struct block): Forward declare.
3385
3386 2019-03-24  Tom Tromey  <tom@tromey.com>
3387
3388         * c-exp.y (typebase): Remove casts.
3389         * gdbtypes.c (lookup_unsigned_typename, )
3390         (lookup_signed_typename): Remove cast.
3391         * eval.c (parse_to_comma_and_eval): Remove cast.
3392         * parse.c (write_dollar_variable): Remove cast.
3393         * block.h (struct block) <superblock>: Now const.
3394         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3395         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3396         (map_block): Make "block" const.
3397         * symfile.h (struct quick_symbol_functions)
3398         <map_matching_symbols>: Constify block argument to "callback".
3399         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3400         const.
3401         (find_pc_sect_compunit_symtab): Make "b" const.
3402         (find_symbol_at_address): Likewise.
3403         (search_symbols): Likewise.
3404         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3405         (dw2_debug_names_lookup_symbol): Likewise.
3406         (dw2_map_matching_symbols): Update.
3407         * p-valprint.c (pascal_val_print): Remove "block".
3408         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3409         (aux_add_nonlocal_symbols): Make "block" const.
3410         (resolve_subexp): Remove cast.
3411         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3412         const.
3413         (iterate_over_file_blocks): Likewise.
3414         * f-exp.y (%union) <bval>: Remove.
3415         * coffread.c (patch_opaque_types): Make "b" const.
3416         * spu-tdep.c (spu_catch_start): Make "block" const.
3417         * c-valprint.c (print_unpacked_pointer): Remove "block".
3418         * symmisc.c (dump_symtab_1): Make "b" const.
3419         (block_depth): Make "block" const.
3420         * d-exp.y (%union) <bval>: Remove.
3421         * cp-support.h (cp_lookup_rtti_type): Update.
3422         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3423         * psymtab.c (psym_lookup_symbol): Make "block" const.
3424         (maintenance_check_psymtabs): Make "b" const.
3425         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3426         (enumerate_locals, enumerate_args): Update.
3427         * python/py-symtab.c (stpy_global_block): Make "block" const.
3428         (stpy_static_block): Likewise.
3429         * inline-frame.c (block_starting_point_at): Make "new_block"
3430         const.
3431         * block.c (find_block_in_blockvector): Make return type const.
3432         (blockvector_for_pc_sect): Make "b" const.
3433         (find_block_in_blockvector): Make "b" const.
3434
3435 2019-03-23  Tom Tromey  <tom@tromey.com>
3436
3437         * varobj.c (varobj_create): Update.
3438         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3439         * printcmd.c (display_command, do_one_display): Don't reset
3440         innermost_block.
3441         * parser-defs.h (enum innermost_block_tracker_type): Move to
3442         expression.h.
3443         (innermost_block): Update comment.
3444         * parse.c (parse_exp_1): Add tracker_types parameter.
3445         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3446         tracker_types parameter.  Reset innermost_block.
3447         (parse_exp_in_context): Remove.
3448         (parse_expression_for_completion): Update.
3449         * objfiles.c (~objfile): Don't reset expression_context_block or
3450         innermost_block.
3451         * expression.h (enum innermost_block_tracker_type): Move from
3452         parser-defs.h.
3453         (parse_exp_1): Add tracker_types parameter.
3454         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3455         reset innermost_block.
3456
3457 2019-03-23  Tom Tromey  <tom@tromey.com>
3458
3459         * objfiles.h: Include bcache.h.
3460
3461 2019-03-23  Tom Tromey  <tom@tromey.com>
3462
3463         * linespec.c (get_current_search_block): Use
3464         scoped_restore_current_language.
3465         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3466
3467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3468             Jiong Wang  <jiong.wang@arm.com>
3469
3470         * aarch64-linux-tdep.c
3471         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3472         section.
3473         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3474
3475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3476             Jiong Wang  <jiong.wang@arm.com>
3477
3478         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3479         instructions.
3480         (aarch64_analyze_prologue_test): Add PACIASP test.
3481         (aarch64_prologue_prev_register): Unmask PC value.
3482
3483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3484             Jiong Wang  <jiong.wang@arm.com>
3485
3486         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3487         (aarch64_dwarf2_prev_register): Unmask PC value.
3488         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3489         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3490         DW_CFA_AARCH64_negate_ra_state.
3491         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3492
3493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3494             Jiong Wang  <jiong.wang@arm.com>
3495
3496         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3497         registers.
3498         (aarch64_pseudo_register_name): Likewise.
3499         (aarch64_pseudo_register_type): Likewise.
3500         (aarch64_pseudo_register_reggroup_p): Likewise.
3501         (aarch64_gdbarch_init): Add pauth registers.
3502         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3503         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3504         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3505         (struct gdbarch_tdep): Add regnum for ra_state.
3506
3507 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3508             Jiong Wang  <jiong.wang@arm.com>
3509
3510         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3511
3512 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3513             Jiong Wang  <jiong.wang@arm.com>
3514
3515         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3516         function.
3517         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3518         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3519         (aarch64_gdbarch_init): Add puth registers.
3520         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3521         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3522         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3523
3524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3525             Jiong Wang  <jiong.wang@arm.com>
3526
3527         * aarch64-linux-nat.c
3528         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3529         * aarch64-linux-tdep.c
3530         (aarch64_linux_core_read_description): Likewise.
3531         (aarch64_linux_get_hwcap): New function.
3532         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3533         (aarch64_linux_get_hwcap): New declaration.
3534
3535 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3536             Jiong Wang  <jiong.wang@arm.com>
3537
3538         * aarch64-linux-nat.c
3539         (aarch64_linux_nat_target::read_description): Add pauth param.
3540         * aarch64-linux-tdep.c
3541         (aarch64_linux_core_read_description): Likewise.
3542         * aarch64-tdep.c (struct target_desc): Add in pauth.
3543         (aarch64_read_description): Add pauth param.
3544         (aarch64_gdbarch_init): Likewise.
3545         * aarch64-tdep.h (aarch64_read_description): Likewise.
3546         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3547         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3548         * features/Makefile: Add new files.
3549         * features/aarch64-pauth.c: New file.
3550         * features/aarch64-pauth.xml: New file.
3551
3552 2019-03-20  Tom Tromey  <tromey@adacore.com>
3553
3554         * infrun.c (handle_inferior_event): Rename from
3555         handle_inferior_event_1.  Create a scoped_value_mark.
3556         (handle_inferior_event): Remove.
3557
3558 2019-03-19  Tom Tromey  <tromey@adacore.com>
3559
3560         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3561         * infrun.h (print_stop_event): Add "displays" parameter.
3562         * infrun.c (print_stop_event): Add "displays" parameter.
3563
3564 2019-03-19  Pedro Alves  <palves@redhat.com>
3565
3566         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3567         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3568         to -1.  Fix TABs vs spaces.
3569         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3570         * tui/tui-out.h (tui_ui_out) Add intro comments.
3571         <m_line, m_start_of_line>: In-class initialize, and add describing
3572         comment.
3573
3574 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3575
3576         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3577         variable names.
3578         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3579
3580 2019-03-18  Pedro Alves  <palves@redhat.com>
3581             Eli Zaretskii <eliz@gnu.org>
3582
3583         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3584         m_line and m_start_of_line.
3585
3586 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3587
3588         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3589         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3590         it returns a newline.  This fixes a regression in TU mode, whereby
3591         the next line is output on the same screen line as the user input.
3592
3593 2019-03-18  Tom Tromey  <tromey@adacore.com>
3594
3595         * minsyms.c (minimal_symbol_reader::install): Remove call to
3596         obstack_blank.
3597
3598 2019-03-18  Pedro Alves  <palves@redhat.com>
3599
3600         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3601         New globals.
3602         (apply_style): New, factored out from ...
3603         (apply_ansi_escape): ... this.  Handle reverse video mode.
3604         (tui_set_reverse_mode): New function.
3605         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3606         * tui/tui-winsource.c (tui_show_source_line): Use
3607         tui_set_reverse_mode instead of setting A_STANDOUT.
3608         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3609         New setter methods.
3610
3611 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3612
3613         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3614         Handle tabs.
3615
3616 2019-03-18  Tom Tromey  <tromey@adacore.com>
3617
3618         * ada-lang.c (empty_array): Add "high" parameter.
3619         (ada_evaluate_subexp): Update.
3620
3621 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3622
3623         * unittests/string_view-selftests.c: Define
3624         _initialize_string_view_selftests unconditionally.
3625
3626 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3627
3628         PR gdb/24350
3629         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3630
3631 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3632
3633         PR gdb/24351
3634         * windows-nat.c (display_selector): Fix format specifiers.
3635
3636 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3637
3638         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3639         tui_refill_source_window instead of tui_refresh_win, to update the
3640         current execution line.  This fixes redisplay of the current line
3641         when stepping through the code with "next" or "step".
3642
3643 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3644
3645         * source-cache.c (source_cache::get_source_lines): Call
3646         find_source_lines to initialize s->nlines.  This fixes vertical
3647         scrolling of TUI source window when the DOWN arrow is pressed.
3648
3649 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3650
3651         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3652         linux-thread-db.c (_initialize_thread_db): Likewise.
3653
3654 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3655
3656         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3657         wclrtoeol in tui_show_source_line".  This reverts changes made in
3658         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3659
3660 2019-03-15  Tom Tromey  <tom@tromey.com>
3661
3662         * symtab.h (struct minimal_symbol): Derive from
3663         general_symbol_info.
3664         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3665         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3666         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3667         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3668         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3669         (MSYMBOL_SEARCH_NAME): Update.
3670         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3671         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3672         * minsyms.c (minimal_symbol_reader::record_full): Update.
3673
3674 2019-03-15  Tom Tromey  <tom@tromey.com>
3675
3676         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3677
3678 2019-03-15  Tom Tromey  <tom@tromey.com>
3679
3680         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3681         unique_xmalloc_ptr.
3682         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3683         Update.
3684         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3685         (build_minimal_symbol_hash_tables)
3686         (minimal_symbol_reader::install): Update.
3687
3688 2019-03-15  Tom Tromey  <tom@tromey.com>
3689
3690         * symtab.c (create_demangled_names_hash): Update.
3691         (symbol_set_names): Update.
3692         * objfiles.h (struct objfile_per_bfd_storage)
3693         <demangled_names_hash>: Now an htab_up.
3694         * objfiles.c (objfile_per_bfd_storage): Simplify.
3695
3696 2019-03-15  Tom Tromey  <tom@tromey.com>
3697
3698         * objfiles.h (struct objfile_per_bfd_storage): Declare
3699         destructor.
3700         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3701         New.
3702         (get_objfile_bfd_data): Use new.  Don't initialize
3703         language_of_main.
3704         (free_objfile_per_bfd_storage): Remove.
3705         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3706
3707 2019-03-15  Tom Tromey  <tom@tromey.com>
3708
3709         * symfile.c (reread_symbols): Update.
3710         * objfiles.c (objfile::objfile): Update.
3711         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3712         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3713         comment.
3714         (minimal_symbol_reader::install): Update.
3715         (terminate_minimal_symbol_table): Remove.
3716         * jit.c (jit_object_close_impl): Update.
3717
3718 2019-03-15  Tom Tromey  <tom@tromey.com>
3719
3720         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3721         initializations.
3722
3723 2019-03-15  Tom Tromey  <tom@tromey.com>
3724
3725         * objfiles.h (struct objfile_per_bfd_storage)
3726         <demangled_hash_languages>: Now a bitset.
3727         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3728         (lookup_minimal_symbol): Update.
3729
3730 2019-03-15  Tom Tromey  <tom@tromey.com>
3731
3732         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3733         Don't return the symbol.
3734         * coffread.c (record_minimal_symbol): Use record_full.
3735
3736 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3737
3738         The MS-Windows port of ncurses fails to switch to a color pair if
3739         one or both of the colors are the implicit default colors.  This
3740         change records the default colors when TUI is initialized, and
3741         then specifies them explicitly when a color pair uses the default
3742         colors.  This allows color styling in TUI mode on MS-Windows.
3743
3744         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3745         ncurses_norm_attr.
3746         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3747         colors in ncurses_norm_attr.
3748         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3749         "none", replace it with the default color recorded in
3750         ncurses_norm_attr.
3751
3752 2019-03-14  Tom Tromey  <tromey@adacore.com>
3753
3754         * source-cache.h (class source_cache) <get_source_lines>: Return
3755         std::string.
3756         * source-cache.c (source_cache::extract_lines): Handle case where
3757         first_pos==npos.  Return std::string.
3758         (source_cache::get_source_lines): Update.
3759
3760 2019-03-14  Tom Tromey  <tromey@adacore.com>
3761
3762         * NEWS: Add item for "style sources" commands.
3763         * source-cache.c (source_cache::get_source_lines): Check
3764         source_styling.
3765         * cli/cli-style.c (source_styling): New global.
3766         (_initialize_cli_style): Add "style sources" commands.
3767         (show_style_sources): New function.
3768         * cli/cli-style.h (source_styling): Declare.
3769
3770 2019-03-14  Pedro Alves  <palves@redhat.com>
3771             Tom Tromey  <tromey@adacore.com>
3772
3773         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3774         * tui/tui-winsource.c (tui_refill_source_window): New function,
3775         from...
3776         (tui_horizontal_source_scroll): ... here.  Move some logic.
3777         * cli/cli-style.c (set_style_enabled): Notify new observable.
3778         * tui/tui-hooks.c (tui_redisplay_source): New function.
3779         (tui_attach_detach_observers): Attach or detach
3780         tui_redisplay_source.
3781         * observable.h (source_styling_changed): New observable.
3782         * observable.c: Define source_styling_changed observable.
3783
3784 2019-03-13  Tom Tromey  <tromey@adacore.com>
3785
3786         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3787         (i386_gnu_nat_target::store_registers): Update.
3788         * target-debug.h (target_debug_print_std_string): New macro.
3789         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3790         * windows-tdep.c (display_one_tib): Update.
3791         * tui/tui-stack.c (tui_make_status_line): Update.
3792         * top.c (print_inferior_quit_action): Update.
3793         * thread.c (thr_try_catch_cmd): Update.
3794         (add_thread_with_info): Update.
3795         (thread_target_id_str): Update.
3796         (thr_try_catch_cmd): Update.
3797         (thread_command): Update.
3798         (thread_find_command): Update.
3799         * record-btrace.c (record_btrace_target::info_record)
3800         (record_btrace_resume_thread, record_btrace_target::resume)
3801         (record_btrace_cancel_resume, record_btrace_step_thread)
3802         (record_btrace_target::wait, record_btrace_target::wait)
3803         (record_btrace_target::wait, record_btrace_target::stop): Update.
3804         * progspace.c (print_program_space): Update.
3805         * process-stratum-target.c
3806         (process_stratum_target::thread_address_space): Update.
3807         * linux-fork.c (linux_fork_mourn_inferior)
3808         (detach_checkpoint_command, info_checkpoints_command)
3809         (linux_fork_context): Update.
3810         (linux_fork_detach): Update.
3811         (class scoped_switch_fork_info): Update.
3812         (delete_checkpoint_command): Update.
3813         * infrun.c (follow_fork_inferior): Update.
3814         (follow_fork_inferior): Update.
3815         (proceed_after_vfork_done): Update.
3816         (handle_vfork_child_exec_or_exit): Update.
3817         (follow_exec): Update.
3818         (displaced_step_prepare_throw): Update.
3819         (displaced_step_restore): Update.
3820         (start_step_over): Update.
3821         (resume_1): Update.
3822         (clear_proceed_status_thread): Update.
3823         (proceed): Update.
3824         (print_target_wait_results): Update.
3825         (do_target_wait): Update.
3826         (context_switch): Update.
3827         (stop_all_threads): Update.
3828         (restart_threads): Update.
3829         (finish_step_over): Update.
3830         (handle_signal_stop): Update.
3831         (switch_back_to_stepped_thread): Update.
3832         (keep_going_pass_signal): Update.
3833         (print_exited_reason): Update.
3834         (normal_stop): Update.
3835         * inferior.c (inferior_pid_to_str): Change return type.
3836         (print_selected_inferior): Update.
3837         (add_inferior): Update.
3838         (detach_inferior): Update.
3839         * dummy-frame.c (fprint_dummy_frames): Update.
3840         * dcache.c (dcache_info_1): Update.
3841         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3842         (btrace_fetch, btrace_clear): Update.
3843         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3844         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3845         type.
3846         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3847         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3848         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3849         * gdbarch.c, gdbarch.h: Rebuild.
3850         * gdbarch.sh (core_pid_to_str): Change return type.
3851         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3852         return type.
3853         (windows_nat_target::pid_to_str): Change return type.
3854         (windows_delete_thread): Update.
3855         (windows_nat_target::attach): Update.
3856         (windows_nat_target::files_info): Update.
3857         * target-delegates.c: Rebuild.
3858         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3859         return type.
3860         (sol_thread_target::pid_to_str): Change return type.
3861         * remote.c (class remote_target) <pid_to_str>: Change return
3862         type.
3863         (remote_target::pid_to_str): Change return type.
3864         (extended_remote_target::attach, remote_target::remote_stop_ns)
3865         (remote_target::remote_notif_remove_queued_reply)
3866         (remote_target::push_stop_reply, remote_target::disable_btrace):
3867         Update.
3868         (extended_remote_target::attach): Update.
3869         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3870         type.
3871         (gdbsim_target::pid_to_str): Change return type.
3872         * ravenscar-thread.c (struct ravenscar_thread_target)
3873         <pid_to_str>: Change return type.
3874         (ravenscar_thread_target::pid_to_str): Change return type.
3875         * procfs.c (class procfs_target) <pid_to_str>: Change return
3876         type.
3877         (procfs_target::pid_to_str): Change return type.
3878         (procfs_target::attach): Update.
3879         (procfs_target::detach): Update.
3880         (procfs_target::fetch_registers): Update.
3881         (procfs_target::store_registers): Update.
3882         (procfs_target::wait): Update.
3883         (procfs_target::files_info): Update.
3884         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3885         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3886         return type.
3887         (nto_procfs_target::pid_to_str): Change return type.
3888         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3889         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3890         return type.
3891         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3892         (exit_lwp): Update.
3893         (attach_proc_task_lwp_callback, get_detach_signal)
3894         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3895         (linux_nat_target::resume, wait_lwp, stop_callback)
3896         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3897         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3898         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3899         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3900         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3901         type.
3902         (inf_ptrace_target::attach): Update.
3903         (inf_ptrace_target::files_info): Update.
3904         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3905         type.
3906         (go32_nat_target::pid_to_str): Change return type.
3907         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3908         (gnu_nat_target::wait): Update.
3909         (gnu_nat_target::wait): Update.
3910         (gnu_nat_target::resume): Update.
3911         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3912         (fbsd_nat_target::wait): Update.
3913         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3914         type.
3915         (darwin_nat_target::attach): Update.
3916         * corelow.c (class core_target) <pid_to_str>: Change return type.
3917         (core_target::pid_to_str): Change return type.
3918         * target.c (normal_pid_to_str): Change return type.
3919         (default_pid_to_str): Likewise.
3920         (target_pid_to_str): Change return type.
3921         (target_translate_tls_address): Update.
3922         (target_announce_detach): Update.
3923         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3924         return type.
3925         (bsd_uthread_target::pid_to_str): Change return type.
3926         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3927         type.
3928         (bsd_kvm_target::pid_to_str): Change return type.
3929         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3930         return type.
3931         (aix_thread_target::pid_to_str): Change return type.
3932         * target.h (struct target_ops) <pid_to_str>: Change return type.
3933         (target_pid_to_str, normal_pid_to_str): Likewise.
3934         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3935         type.
3936         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3937         type.
3938         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3939         return type.
3940         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3941         type.
3942         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3943         type.
3944         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3945         return type.
3946
3947 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3948
3949         * NEWS: Mention that the new default MI version is 3.  Mention
3950         changes to the output of commands and events that deal with
3951         multi-location breakpoints.
3952         * breakpoint.c: Include "mi/mi-out.h".
3953         (print_one_breakpoint): Change output syntax if using MI version
3954         >= 3.
3955         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3956         New.
3957         (mi_multi_location_breakpoint_output_fixed): New.
3958         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3959         (mi_cmd_fix_multi_location_breakpoint_output): New.
3960         (mi_multi_location_breakpoint_output_fixed): New.
3961         * mi/mi-cmds.c (mi_cmds): Register command
3962         -fix-multi-location-breakpoint-output.
3963         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3964         interpreter "mi".
3965
3966 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3967
3968         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3969         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3970         instantiate mi_ui_out based on interpreter name.
3971         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3972         * mi/mi-main.c (mi_load_progress): Likewise.
3973
3974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3975
3976         * NEWS: Combine separate "New targets" sections for 8.3.
3977
3978 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3979
3980         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3981         (ppcfbsd_init_abi): Install gdbarch
3982         "fetch_tls_load_module_address" and "get_thread_local_address"
3983         methods.
3984
3985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3986
3987         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3988         (riscv_fbsd_init_abi): Install gdbarch
3989         "fetch_tls_load_module_address" and "get_thread_local_address"
3990         methods.
3991
3992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3993
3994         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3995         (i386fbsd_init_abi): Install gdbarch
3996         "fetch_tls_load_module_address" and "get_thread_local_address"
3997         methods.
3998
3999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4000
4001         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4002         (amd64fbsd_init_abi): Install gdbarch
4003         "fetch_tls_load_module_address" and "get_thread_local_address"
4004         methods.
4005
4006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4007
4008         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4009         (struct fbsd_pspace_data): New type.
4010         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4011         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4012         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4013         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4014         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4015
4016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4017
4018         * gdbtypes.c (lookup_struct_elt): New function.
4019         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4020         * gdbtypes.h (struct struct_elt): New type.
4021         (lookup_struct_elt): New prototype.
4022
4023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4024
4025         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4026         remove disabled code block.
4027
4028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4029
4030         * gdbarch.sh (get_thread_local_address): New method.
4031         * gdbarch.h, gdbarch.c: Regenerate.
4032         * target.c (target_translate_tls_address): Use
4033         gdbarch_get_thread_local_address if present instead of
4034         target::get_thread_local_address.
4035
4036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4037
4038         * target.h (target::get_thread_local_address): Update comment.
4039
4040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4041
4042         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4043         objfile->separate_debug_objfile_backlink if not NULL.
4044
4045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4046
4047         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4048         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4049         (amd64bsd_store_inferior_registers): Likewise.
4050         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4051         Enable segment base registers.
4052         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4053         PT_GETFSBASE and PT_GETGSBASE.
4054         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4055         PT_SETGSBASE.
4056         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4057         segment base registers.
4058         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4059
4060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4061
4062         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4063         Update calls to i386_target_description to add 'segments'
4064         parameter.
4065         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4066         add segment base registers.
4067         * arch/i386.c (i386_create_target_description): Add 'segments'
4068         parameter to enable segment base registers.
4069         * arch/i386.h (i386_create_target_description): Likewise.
4070         * features/i386/32bit-segments.xml: New file.
4071         * features/i386/32bit-segments.c: Generate.
4072         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4073         call to i386_target_description to add 'segments' parameter.
4074         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4075         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4076         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4077         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4078         if feature is present.
4079         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4080         Add 'segments' parameter to call to i386_target_description.
4081         (i386_target_description): Add 'segments' parameter to enable
4082         segment base registers.
4083         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4084         to call to i386_target_description.
4085         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4086         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4087         Define I386_NUM_REGS.
4088         (i386_target_description): Add 'segments' parameter to enable
4089         segment base registers.
4090
4091 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4092
4093         PR/24325
4094         * source-cache.c: #undef open and close, to avoid unresolved
4095         externals during linking.
4096
4097 2019-03-12  Tom Tromey  <tromey@adacore.com>
4098
4099         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4100         const.  Add initializers.
4101         (_initialize_remote): Don't initialize ptid globals.
4102
4103 2019-03-12  Pedro Alves  <palves@redhat.com>
4104
4105         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4106
4107 2019-03-12  Pedro Alves  <palves@redhat.com>
4108
4109         * cp-name-parser.y (main): Remove unused 'len' variable.
4110
4111 2019-03-12  Tom Tromey  <tromey@adacore.com>
4112
4113         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4114         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4115
4116 2019-03-12  Tom Tromey  <tromey@adacore.com>
4117
4118         * linux-nat.c (iterate_over_lwps): Update.
4119         (stop_callback): Remove parameter.
4120         (stop_wait_callback, detach_callback, resume_set_callback)
4121         (select_singlestep_lwp_callback, set_ignore_sigint)
4122         (status_callback, resumed_callback, resume_clear_callback)
4123         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4124         data parameter.
4125         (linux_nat_target::detach, linux_nat_target::resume)
4126         (linux_stop_and_wait_all_lwps, select_event_lwp)
4127         (linux_nat_filter_event, linux_nat_wait_1)
4128         (linux_nat_target::kill, linux_nat_target::stop)
4129         (linux_nat_target::stop): Update.
4130         (linux_nat_resume_callback): Change type.
4131         (resume_stopped_resumed_lwps, count_events_callback)
4132         (select_event_lwp_callback): Likewise.
4133         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4134         * arm-linux-nat.c (struct update_registers_data): Remove.
4135         (update_registers_callback): Change type.
4136         (arm_linux_insert_hw_breakpoint1): Update.
4137         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4138         parameter.
4139         (x86_linux_dr_set_addr): Update.
4140         (x86_linux_dr_set_control): Update.
4141         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4142         (iterate_over_lwps): Use gdb::function_view.
4143         * nat/aarch64-linux-hw-point.c (struct
4144         aarch64_dr_update_callback_param): Remove.
4145         (debug_reg_change_callback): Change type.
4146         (aarch64_notify_debug_reg_change): Update.
4147         * s390-linux-nat.c (s390_refresh_per_info): Update.
4148
4149 2019-03-11  Tom Tromey  <tromey@adacore.com>
4150
4151         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4152         redundant assignment to "this_cu".
4153
4154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4155
4156         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4157
4158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4159
4160         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4161         from...
4162         (rank_one_type): ... this.
4163
4164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4165
4166         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4167         from...
4168         (rank_one_type): ... this.
4169
4170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4171
4172         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4173         from...
4174         (rank_one_type): ... this.
4175
4176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4177
4178         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4179         from...
4180         (rank_one_type): ... this.
4181
4182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4183
4184         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4185         from...
4186         (rank_one_type): ... this.
4187
4188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4189
4190         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4191         from...
4192         (rank_one_type): ... this.
4193
4194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4195
4196         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4197         from...
4198         (rank_one_type): ... this.
4199
4200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4201
4202         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4203         from...
4204         (rank_one_type): ... this.
4205
4206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4207
4208         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4209         from...
4210         (rank_one_type): ... this.
4211
4212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4213
4214         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4215         from...
4216         (rank_one_type): ... this.
4217
4218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4219
4220         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4221         from...
4222         (rank_one_type): ... this.
4223
4224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4225
4226         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4227         from...
4228         (rank_one_type): ... this.
4229
4230 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4231
4232         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4233         inferior-events' shows the example events.
4234
4235 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4236
4237         Support styling on native MS-Windows console
4238
4239         PR/24315
4240         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4241         on MS-Windows if $TERM is not defined.
4242
4243         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4244
4245         * posix-hdep.c (gdb_console_fputs):
4246         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4247         functions.
4248         * ui-file.h (gdb_console_fputs): Add prototype.
4249
4250         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4251         back to fputs only if the former returns zero.
4252
4253 2019-03-07  Tom Tromey  <tom@tromey.com>
4254
4255         * symmisc.c (print_symbol_bcache_statistics): Update.
4256         (print_objfile_statistics): Update.
4257         * symfile.c (allocate_symtab): Update.
4258         * stabsread.c: Don't include bcache.h.
4259         * psymtab.h (struct psymbol_bcache): Don't declare.
4260         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4261         (psymbol_bcache_init, psymbol_bcache_free)
4262         (psymbol_bcache_get_bcache): Don't declare.
4263         * psymtab.c (struct psymbol_bcache): Remove.
4264         (psymtab_storage::psymtab_storage): Update.
4265         (psymtab_storage::~psymtab_storage): Update.
4266         (psymbol_bcache_init, psymbol_bcache_free)
4267         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4268         (add_psymbol_to_bcache): Update.
4269         (allocate_psymtab): Update.
4270         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4271         macro_cache>: No longer pointers.
4272         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4273         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4274         * macrotab.c (macro_bcache): Update.
4275         * macroexp.c: Don't include bcache.h.
4276         * gdbtypes.c (check_types_worklist): Update.
4277         (types_deeply_equal): Remove TRY/CATCH.  Update.
4278         * elfread.c (elf_symtab_read): Update.
4279         * dwarf2read.c: Don't include bcache.h.
4280         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4281         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4282         (print_bcache_statistics, bcache_memory_used): Don't declare.
4283         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4284         methods.  Rename all data members.
4285         * bcache.c (struct bcache): Move to bcache.h.
4286         (bcache::expand_hash_table): Rename from expand_hash_table.
4287         (bcache): Remove.
4288         (bcache::insert): Rename from bcache_full.
4289         (bcache::compare): Rename from bcache_compare.
4290         (bcache_xmalloc): Remove.
4291         (bcache::~bcache): Rename from bcache_xfree.
4292         (bcache::print_statistics): Rename from print_bcache_statistics.
4293         (bcache::memory_used): Rename from bcache_memory_used.
4294
4295 2019-03-07  Pedro Alves  <palves@redhat.com>
4296
4297         * infrun.c (normal_stop): Also check for
4298         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4299
4300 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * f-lang.c (value_from_host_double): Moved to...
4303         * value.c (value_from_host_double): ...here.
4304         * value.h (value_from_host_double): Declare.
4305         * guile/scm-math.c (vlscm_convert_typed_number): Use
4306         value_from_host_double.
4307         (vlscm_convert_number): Likewise.
4308         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4309         * python/py-value.c (convert_value_from_python): Likewise.
4310
4311 2019-03-06  Tom Tromey  <tom@tromey.com>
4312
4313         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4314
4315 2019-03-06  Tom Tromey  <tom@tromey.com>
4316
4317         * utils.h (free_current_contents): Don't declare.
4318         * utils.c (free_current_contents): Remove.
4319
4320 2019-03-06  Tom Tromey  <tom@tromey.com>
4321
4322         * top.c (quit_force): Update.
4323         * main.c (captured_command_loop): Update.
4324         * common/new-op.c (operator new): Update.
4325         * common/common-exceptions.c (struct catcher)
4326         <save_cleanup_chain>: Remove member.
4327         (exceptions_state_mc_init): Update.
4328         (exception_try_scope_entry): Return nullptr.
4329         (exception_try_scope_exit, exception_rethrow)
4330         (throw_exception_sjlj, throw_exception_cxx): Update.
4331         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4332         (all_cleanups, do_cleanups, discard_cleanups)
4333         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4334         (restore_cleanups, restore_final_cleanups): Don't declare.
4335         (do_final_cleanups): Remove parameter.
4336         * common/cleanups.c (cleanup_chain, make_cleanup)
4337         (make_cleanup_dtor, all_cleanups, do_cleanups)
4338         (discard_my_cleanups, discard_cleanups)
4339         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4340         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4341         (null_cleanup): Remove.
4342         (do_final_cleanups): Remove parameter.
4343
4344 2019-03-06  Tom Tromey  <tom@tromey.com>
4345
4346         * remote.c (remote_target::remote_parse_stop_reply): Use
4347         unique_xmalloc_ptr.
4348
4349 2019-03-06  Tom Tromey  <tom@tromey.com>
4350
4351         * stabsread.c (struct stabs_field_info): Rename from field_info.
4352         <list, fnlist>: Add initializers.
4353         <obstack>: New member.
4354         (read_member_functions, read_struct_fields, read_baseclasses):
4355         Allocate on obstack.  Don't use cleanups.
4356         (read_one_struct_field, read_member_functions, read_struct_fields)
4357         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4358         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4359         (read_struct_type): Update.
4360
4361 2019-03-06  Tom Tromey  <tom@tromey.com>
4362
4363         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4364         * common/filestuff.h (make_cleanup_close): Don't declare.
4365         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4366         Remove.
4367
4368 2019-03-06  Tom Tromey  <tom@tromey.com>
4369
4370         * solib-aix.c: Use make_scope_exit.
4371
4372 2019-03-06  Tom Tromey  <tom@tromey.com>
4373
4374         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4375         Use make_scope_exit.
4376
4377 2019-03-06  Tom Tromey  <tom@tromey.com>
4378
4379         * solib-svr4.c (disable_probes_interface): Remove parameter.
4380         (svr4_handle_solib_event): Use make_scope_exit.
4381
4382 2019-03-06  Tom Tromey  <tom@tromey.com>
4383
4384         * remote.c (struct stop_reply_deleter): Remove.
4385         (stop_reply_up): Update.
4386         (struct stop_reply): Derive from notif_event.  Don't typedef.
4387         <regcache>: Now a std::vector.
4388         (stop_reply_xfree): Remove.
4389         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4390         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4391         (remote_target::discard_pending_stop_replies): Use delete.
4392         (remote_target::remote_parse_stop_reply): Update.
4393         (remote_target::process_stop_reply): Update.
4394         * remote-notif.h (struct notif_event): Add virtual destructor.
4395         Remove "dtr" member.
4396         (struct notif_client) <alloc_event>: Return a unique_ptr.
4397         (notif_event_xfree): Don't declare.
4398         (notif_event_up): New typedef.
4399         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4400         (notif_event_xfree, do_notif_event_xfree): Remove.
4401         (remote_notif_state_xfree): Update.
4402
4403 2019-03-06  Tom Tromey  <tom@tromey.com>
4404
4405         * infrun.c (displaced_step_clear_cleanup): Now a
4406         forward_scope_exit type.
4407         (displaced_step_prepare_throw): Update.
4408         (displaced_step_fixup): Update.
4409
4410 2019-03-06  Tom Tromey  <tom@tromey.com>
4411
4412         * inferior.h (class inferior): Update comment.
4413         * gdbthread.h (class thread_info): Update comment.
4414
4415 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4416             Tom Tromey  <tom@tromey.com>
4417
4418         * stabsread.h (struct stab_section_list): Remove.
4419         (coffstab_build_psymtabs): Update.
4420         * dbxread.c (symbuf_sections): Now a std::vector.
4421         (sect_idx): New global.
4422         (fill_symbuf): Update.
4423         (coffstab_build_psymtabs): Change type of stabsects parameter.
4424         Update.
4425         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4426         std::vector.
4427         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4428         (coff_locate_sections): Update.
4429         (coff_symfile_read): Remove cleanups.  Update.
4430         (init_stringtab): Add storage parameter.
4431         (free_stringtab, free_stringtab_cleanup): Remove.
4432         (init_lineno): Add storage parameter.
4433         (free_linetab, free_linetab_cleanup): Remove.
4434
4435 2019-03-06  Pedro Alves  <palves@redhat.com>
4436
4437         * linux-fork.c (fork_info::clobber_regs): Delete.
4438         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4439         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4440         comment.  Adjust.
4441         (scoped_switch_fork_info::scoped_switch_fork_info)
4442         (checkpoint_command, linux_fork_context): Adjust
4443         fork_save_infrun_state calls.
4444
4445 2019-03-06  Pedro Alves  <palves@redhat.com>
4446
4447         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4448         (inf_has_multiple_threads): Return 'bool' and rewrite using
4449         inferior_info::threads().
4450
4451 2019-03-06  Pedro Alves  <palves@redhat.com>
4452
4453         * linux-fork.c: Include <list>.
4454         (fork_list): Now a std::list instance.
4455         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4456         (forks_exist_p, find_last_fork): Adjust.
4457         (new_fork): Delete.
4458         (one_fork_p): New.
4459         (add_fork): Adjust.
4460         (free_fork): Delete, folded into fork_info::~fork_info().
4461         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4462         Adjust.
4463         (init_fork_list): Delete.
4464         (linux_fork_killall, linux_fork_mourn_inferior)
4465         (linux_fork_detach, info_checkpoints_command): Adjust.
4466         (_initialize_linux_fork): No longer call init_fork_list.
4467
4468 2019-03-06  Pedro Alves  <palves@redhat.com>
4469
4470         * linux-fork.c (new_fork): New, split out of ...
4471         (add_fork): ... this.  Return void.  Move "first fork" special
4472         case from here, to ...
4473         (checkpoint_command): ... here.
4474         * linux-linux.h (add_fork): Return void.
4475
4476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4479
4480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4481             Chris January  <chris.january@arm.com>
4482             David Lecomber  <david.lecomber@arm.com>
4483
4484         * f-exp.y: New token, UNOP_INTRINSIC.
4485         (exp): New pattern using UNOP_INTRINSIC token.
4486         (f77_keywords): Add 'abs' keyword.
4487         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4488         (value_from_host_double): New function.
4489         (evaluate_subexp_f): Support UNOP_ABS.
4490
4491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4494         types.
4495
4496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4499         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4500         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4501
4502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4505
4506 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4507             Chris January  <chris.january@arm.com>
4508
4509         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4510         * f-exp.y: Define 'KIND' token.
4511         (exp): New pattern for KIND expressions.
4512         (ptype): Handle types with a kind extension.
4513         (direct_abs_decl): Extend to spot kind extensions.
4514         (f77_keywords): Add 'kind' to the list.
4515         (push_kind_type): New function.
4516         (convert_to_kind_type): New function.
4517         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4518         * parse.c (operator_length_standard): Likewise.
4519         * parser-defs.h (enum type_pieces): Add tp_kind.
4520         * std-operator.def: Add UNOP_KIND.
4521
4522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * f-exp.y (f_parse): Set yydebug.
4525
4526 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * f-lang.c (evaluate_subexp_f): New function.
4529         (exp_descriptor_f): New global.
4530         (f_language_defn): Use exp_descriptor_f instead of
4531         exp_descriptor_standard.
4532
4533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * f-exp.y (struct token): Add comments.
4536         (dot_ops): Remove uppercase versions and the end marker.
4537         (f77_keywords): Likewise.
4538         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4539         entries in the dot_ops array are case insensitive, and use
4540         strncasecmp to compare strings.  Also some whitespace cleanup in
4541         this area.  Similar for the f77_keywords array, except entries in
4542         this list might be case sensitive.
4543
4544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * f-exp.y (struct f77_boolean_val): Add comments.
4547         (boolean_values): Remove uppercase versions, and end marker.
4548         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4549         and use strncasecmp to achieve case insensitivity.  Additionally,
4550         perform whitespace cleanup around this code.
4551
4552 2019-03-06  Tom Tromey  <tromey@adacore.com>
4553
4554         * remote-sim.c (gdbsim_target_open): Use result of
4555         gdb_argv::release.
4556
4557 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4558         Dirk Schubert  <dirk.schubert@arm.com>
4559         Chris January  <chris.january@arm.com>
4560
4561         * eval.c (evaluate_subexp_standard): Call Fortran argument
4562         wrapping logic.
4563         * f-lang.c (struct value): A value which can be passed into a
4564         Fortran function call.
4565         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4566         where appropriate.
4567         (struct type): Value ready for a Fortran function call.
4568         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4569         is needed.
4570         * f-lang.h (fortran_argument_convert): Declaration.
4571         (fortran_preserve_arg_pointer): Declaration.
4572         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4573
4574 2019-03-05  Tom Tromey  <tromey@adacore.com>
4575
4576         * python/py-prettyprint.c (print_string_repr): Remove #if.
4577         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4578
4579 2019-03-05  Tom Tromey  <tromey@adacore.com>
4580
4581         * target.c (the_dummy_target): Move later.  Change type to
4582         "dummy_target".
4583         (initialize_targets): Don't initialize the_dummy_target.
4584
4585 2019-03-05  Tom Tromey  <tromey@adacore.com>
4586
4587         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4588         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4589
4590 2019-03-05  Tom Tromey  <tromey@adacore.com>
4591
4592         * windows-nat.c (windows_nat_target::attach)
4593         (windows_nat_target::detach): Don't call gdb_flush.
4594         * valprint.c (generic_val_print, val_print, val_print_string):
4595         Don't call gdb_flush.
4596         * utils.c (defaulted_query): Don't call gdb_flush.
4597         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4598         * target.c (target_announce_detach): Don't call gdb_flush.
4599         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4600         * remote.c (extended_remote_target::attach): Don't call
4601         gdb_flush.
4602         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4603         * printcmd.c (do_examine): Don't call gdb_flush.
4604         (info_display_command): Don't call gdb_flush.
4605         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4606         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4607         * memattr.c (info_mem_command): Don't call gdb_flush.
4608         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4609         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4610         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4611         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4612         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4613         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4614         (gnu_nat_target::detach): Don't call gdb_flush.
4615         * f-valprint.c (f_val_print): Don't call gdb_flush.
4616         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4617         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4618         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4619         gdb_flush.
4620         * c-valprint.c (c_val_print): Don't call gdb_flush.
4621         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4622
4623 2019-03-05  Tom Tromey  <tromey@adacore.com>
4624
4625         * varobj.c (update_dynamic_varobj_children): Update.
4626         (install_default_visualizer): Use reset, not release.
4627         * value.c (set_internalvar): Update.
4628         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4629         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4630         ATTRIBUTE_UNUSED_RESULT.
4631
4632 2019-03-05  Tom Tromey  <tromey@adacore.com>
4633
4634         * remote.c (class scoped_remote_fd) <release>: Add
4635         ATTRIBUTE_UNUSED_RESULT.
4636
4637 2019-03-05  Tom Tromey  <tromey@adacore.com>
4638
4639         * macroexp.c (struct macro_buffer) <release>: Add
4640         ATTRIBUTE_UNUSED_RESULT.
4641
4642 2019-03-05  Tom Tromey  <tromey@adacore.com>
4643
4644         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4645         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4646         ATTRIBUTE_UNUSED_RESULT.
4647
4648 2019-03-05  Tom Tromey  <tromey@adacore.com>
4649
4650         * common/scoped_fd.h (class scoped_fd) <release>: Add
4651         ATTRIBUTE_UNUSED_RESULT.
4652
4653 2019-03-05  Tom Tromey  <tromey@adacore.com>
4654
4655         * parser-defs.h (struct parser_state) <release>: Add
4656         ATTRIBUTE_UNUSED_RESULT.
4657
4658 2019-03-05  Tom Tromey  <tromey@adacore.com>
4659
4660         * utils.h (class gdb_argv) <release>: Add
4661         ATTRIBUTE_UNUSED_RESULT.
4662         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4663
4664 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4665
4666         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4667         for-loop range, to avoid compiler warnings.
4668
4669         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4670         avoid compiler warnings about unused variables.
4671
4672         * NEWS: Mention end of support for native debugging on MS-Windows
4673         before XP.
4674
4675         PR gdb/24292
4676         * common/netstuff.c:
4677         * gdbserver/gdbreplay.c
4678         * gdbserver/remote-utils.c:
4679         * ser-tcp.c:
4680         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4681         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4682         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4683         'getaddrinfo' and 'freeaddrinfo' were not available before
4684         Windows XP, and mingw.org's MinGW headers by default define
4685         _WIN32_WINNT to 0x500.
4686
4687 2019-03-01  Gary Benson <gbenson@redhat.com>
4688
4689         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4690
4691 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4692             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4693
4694         PR gdb/8527
4695         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4696         set_sigint_trap, clear_sigint_trap.
4697
4698 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4699
4700         * target.c (target_detach): Clear the regcache and the
4701         frame cache.
4702
4703 2019-02-27  Pedro Alves  <palves@redhat.com>
4704
4705         * utils.c (set_screen_size): When we cap the height/width sizes,
4706         tweak the corresponding command variable to show "unlimited":
4707
4708 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4709             Pedro Alves  <palves@redhat.com>
4710
4711         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4712         before calling rl_set_screen_size.
4713
4714 2019-02-27  Tom Tromey  <tromey@adacore.com>
4715
4716         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4717         define.
4718         * python/py-value.c: Remove Python 2.4 workaround.
4719         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4720         workaround.
4721         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4722         Python 2.4 workaround.
4723         * python/python-internal.h: Remove Python 2.4 comment.
4724         (Py_ssize_t): Don't define.
4725         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4726         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4727         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4728         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4729         * python/python.c (do_start_initialization): Remove Python 2.4
4730         workaround.
4731         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4732         (print_children): Remove Python 2.4 workaround.
4733         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4734         workaround.
4735         (CHARBUFFERPROC_NAME): Remove.
4736         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4737         Python 2.4 workaround.
4738
4739 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4740
4741         * NEWS: Note minimum Python version.
4742
4743 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4744
4745         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4746         code from these functions.  Remove corresponding ifdefs.  Use
4747         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4748         Remove gotos and target of gotos.
4749         (infpy_search_memory): Likewise.
4750
4751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4754         (hppa_gdbarch_init): Don't register deleted functions with
4755         gdbarch.
4756
4757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4760         (h8300_unwind_sp): Delete.
4761         (h8300_dummy_id): Delete.
4762         (h8300_gdbarch_init): Don't register deleted functions with
4763         gdbarch.
4764
4765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4768         (ft32_unwind_pc): Delete.
4769         (ft32_unwind_sp): Delete.
4770         (ft32_gdbarch_init): Don't register deleted functions with
4771         gdbarch.
4772
4773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4776         (frv_unwind_pc): Delete.
4777         (frv_unwind_sp): Delete.
4778         (frv_gdbarch_init): Don't register deleted functions with
4779         gdbarch.
4780
4781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4782
4783         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4784         (riscv_unwind_pc): Delete.
4785         (riscv_unwind_sp): Delete.
4786         (riscv_gdbarch_init): Don't register deleted functions with
4787         gdbarch.
4788
4789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4792         (csky_unwind_pc): Delete.
4793         (csky_unwind_sp): Delete.
4794         (csky_gdbarch_init): Don't register deleted functions with
4795         gdbarch.
4796
4797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4800         (cris_unwind_pc): Delete.
4801         (cris_unwind_sp): Delete.
4802         (cris_gdbarch_init): Don't register deleted functions with
4803         gdbarch.
4804
4805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4808         (bfin_unwind_pc): Delete.
4809         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4810
4811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4814         (arm_unwind_pc): Delete.
4815         (arm_unwind_sp): Delete.
4816         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4817
4818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4821         (arc_unwind_pc): Delete.
4822         (arc_unwind_sp): Delete.
4823         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4824
4825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4828         (alpha_unwind_pc): Delete.
4829         (alpha_gdbarch_init): Don't register deleted functions with
4830         gdbarch.
4831
4832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4833
4834         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4835         (aarch64_unwind_pc): Delete.
4836         (aarch64_unwind_sp): Delete.
4837         (aarch64_gdbarch_init): Don't register deleted functions with
4838         gdbarch.
4839
4840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * gdbtypes.c (type_align): Don't consider static members when
4843         computing structure alignment.
4844
4845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4848         return 0 for other types.
4849         * arch-utils.c (default_type_align): Always return 0.
4850         * gdbarch.h: Regenerate.
4851         * gdbarch.sh (type_align): Extend comment.
4852         * gdbtypes.c (type_align): Add additional comments, always call
4853         gdbarch_type_align before applying the default rules.
4854         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4855         generic code will then apply a suitable default.
4856         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4857         types, return 0 for other types.
4858
4859 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4860
4861         * NEWS: Create a new section for the next release branch.
4862         Rename the section of the current branch, now that it has
4863         been cut.
4864
4865 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4866
4867         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4868         * version.in: Bump version to 8.3.50.DATE-git.
4869
4870 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4871
4872         * aix-thread.c (ptid_cmp): Remove unused variable.
4873         (get_signaled_thread): Likewise.
4874         (store_regs_user_thread): Likewise.
4875         (store_regs_kernel_thread): Likewise.
4876         (fetch_regs_kernel_thread): Remove shadowed variable.
4877
4878 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * features/riscv/32bit-cpu.xml: Add register numbers.
4881         * features/riscv/32bit-fpu.c: Regenerate.
4882         * features/riscv/32bit-fpu.xml: Add register numbers.
4883         * features/riscv/64bit-cpu.xml: Add register numbers.
4884         * features/riscv/64bit-fpu.c: Regenerate.
4885         * features/riscv/64bit-fpu.xml: Add register numbers.
4886
4887 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4888
4889         * NEWS: Mention two argument form of gdb.Value constructor.
4890         * python/py-value.c (convert_buffer_and_type_to_value): New
4891         function.
4892         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4893         Add support for handling an optional second argument.  Call
4894         convert_buffer_and_type_to_value as appropriate.
4895         * python/python-internal.h (Py_buffer_deleter): New struct.
4896         (Py_buffer_up): New typedef.
4897
4898 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4899
4900         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4901         instead of releasing ownership.
4902
4903 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4904
4905         * dwarf2read.c (open_and_init_dwp_file): Call
4906         elf_numsections instead of bfd_count_sections to initialize
4907         dwp_file->num_sections.
4908
4909 2019-02-25  Tom Tromey  <tromey@adacore.com>
4910
4911         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4912
4913 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4914
4915         * gcore.in: Add '--readnever' option when invoking GDB.
4916
4917 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4918
4919         * MAINTAINERS: Update my email address.
4920
4921 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4922
4923         * build-id.c (build_id_to_debug_bfd_1): New function.
4924         (build_id_to_debug_bfd): Look for separate debug file in
4925         sysroot.
4926
4927 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * gdbarch.sh: Update the copyright year range that is placed into
4930         generated files.
4931
4932 2019-02-22  Keith Seitz  <keiths@redhat.com>
4933
4934         PR symtab/23853
4935         * linespec.c (create_sals_line_offset): Search for the default
4936         symtab's filename instead of its fullname.
4937
4938 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4939
4940         * NEWS: Update style defaults.
4941
4942 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4943
4944         * main.c (captured_main_1): Disable styling in batch mode.
4945
4946 2019-02-20  Tom Tromey  <tom@tromey.com>
4947
4948         * symtab.c (symtab_symbol_info): Fix typos.
4949
4950 2019-02-20  Tom Tromey  <tromey@adacore.com>
4951
4952         * findcmd.c (_initialize_mem_search): Use upper case for
4953         metasyntactic variables.
4954
4955 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4956
4957         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4958         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4959
4960 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4961
4962         * top.h (source_file_name): Change to std::string.
4963         * top.c (source_file_name): Likewise.
4964         (command_line_input): Adjust.
4965         * cli/cli-script.c (script_from_file): Adjust.
4966
4967 2019-02-19  Tom Tromey  <tromey@adacore.com>
4968
4969         * ravenscar-thread.c
4970         (ravenscar_thread_target::update_thread_list): Don't call
4971         ada_build_task_list.
4972         * ada-lang.h (ada_build_task_list): Don't declare.
4973         * ada-tasks.c (struct ada_tasks_inferior_data)
4974         <task_list_valid_p>: Now bool.
4975         (read_known_tasks, ada_task_list_changed)
4976         (ada_tasks_invalidate_inferior_data): Update.
4977         (read_known_tasks_array): Return bool.
4978         (read_known_tasks_list): Likewise.
4979         (read_known_tasks): Return void.
4980         (ada_build_task_list): Now static.
4981
4982 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4985         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4986
4987 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4988
4989         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4990         variant for ada_tasks_pspace_data_handle and
4991         ada_tasks_inferior_data_handle.
4992         (ada_tasks_pspace_data_cleanup): New function.
4993         (ada_tasks_inferior_data_cleanup): New function.
4994
4995 2019-02-17  Tom Tromey  <tom@tromey.com>
4996
4997         * macrotab.h (macro_source_fullname): Return a std::string.
4998         * macrotab.c (macro_include, check_for_redefinition)
4999         (macro_undef, macro_lookup_definition, foreach_macro)
5000         (foreach_macro_in_scope): Update.
5001         (macro_source_fullname): Return a std::string.
5002         * macrocmd.c (show_pp_source_pos): Update.
5003
5004 2019-02-17  Tom Tromey  <tom@tromey.com>
5005
5006         * macrocmd.c (show_pp_source_pos): Style the file names.
5007
5008 2019-02-17  Tom Tromey  <tom@tromey.com>
5009
5010         PR tui/24197:
5011         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5012
5013 2019-02-17  Tom Tromey  <tom@tromey.com>
5014
5015         * ada-lang.c (user_select_syms): Use filtered printing.
5016         * utils.c (wrap_style): New global.
5017         (desired_style): Remove.
5018         (emit_style_escape): Add stream parameter.
5019         (set_output_style, reset_terminal_style, prompt_for_continue):
5020         Update.
5021         (flush_wrap_buffer): Only flush gdb_stdout.
5022         (wrap_here): Set wrap_style.
5023         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5024         treat escape sequences as a character.  Change when wrap buffer is
5025         flushed.
5026         (fputs_styled): Do not set the output style when the default is
5027         requested.
5028         * ui-style.h (struct ui_file_style) <is_default>: New method.
5029         * source.c (print_source_lines_base): Emit escape sequences in one
5030         piece.
5031
5032 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5033
5034         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5035         integers and enumeration types.
5036
5037 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5038
5039         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5040         instead of lookup_symbol_in_language
5041         (do_exact_match): New function.
5042         (ada_get_symbol_name_matcher): Return do_exact_match when
5043         doing a verbatim match.
5044
5045 2019-02-15  Tom Tromey  <tromey@adacore.com>
5046
5047         * ravenscar-thread.c (ravenscar_thread_target::resume)
5048         (ravenscar_thread_target::wait): Special case wildcard requests.
5049
5050 2019-02-15  Tom Tromey  <tromey@adacore.com>
5051
5052         * ravenscar-thread.c (base_ptid): Remove.
5053         (struct ravenscar_thread_target) <close>: New method.
5054         <m_base_ptid>: New member.
5055         <update_inferior_ptid, active_task, task_is_currently_active,
5056         runtime_initialized>: Declare methods.
5057         <ravenscar_thread_target>: Add constructor.
5058         (ravenscar_thread_target::task_is_currently_active)
5059         (ravenscar_thread_target::update_inferior_ptid)
5060         (ravenscar_runtime_initialized): Rename.  Now methods.
5061         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5062         (ravenscar_thread_target::update_thread_list): Update.
5063         (ravenscar_thread_target::active_task): Now method.
5064         (ravenscar_thread_target::store_registers)
5065         (ravenscar_thread_target::prepare_to_store)
5066         (ravenscar_thread_target::prepare_to_store)
5067         (ravenscar_thread_target::mourn_inferior): Update.
5068         (ravenscar_inferior_created): Use "new" to create target.
5069         (ravenscar_thread_target::get_ada_task_ptid): Update.
5070         (_initialize_ravenscar): Don't initialize base_ptid.
5071         (ravenscar_ops): Remove global.
5072
5073 2019-02-15  Tom Tromey  <tromey@adacore.com>
5074
5075         * target.h (push_target): Declare new overload.
5076         * target.c (push_target): New overload, taking an rvalue reference.
5077         * remote.c (remote_target::open_1): Use push_target overload.
5078         * corelow.c (core_target_open): Use push_target overload.
5079
5080 2019-02-15  Tom Tromey  <tromey@adacore.com>
5081
5082         * ravenscar-thread.c (is_ravenscar_task)
5083         (ravenscar_task_is_currently_active): Return bool.
5084         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5085         (_initialize_ravenscar): Remove "(void)".
5086         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5087         Return bool.
5088
5089 2019-02-15  Tom Tromey  <tromey@adacore.com>
5090
5091         * ravenscar-thread.c (ravenscar_runtime_initializer)
5092         (has_ravenscar_runtime, get_running_thread_id)
5093         (ravenscar_thread_target::resume): Fix indentation.
5094
5095 2019-02-15  Tom Tromey  <tromey@adacore.com>
5096
5097         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5098         from ravenscar_arch_ops.
5099         (sparc_ravenscar_ops::fetch_registers)
5100         (sparc_ravenscar_ops::store_registers): Now methods.
5101         (sparc_ravenscar_prepare_to_store): Remove.
5102         (sparc_ravenscar_ops): Redefine.
5103         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5104         methods and destructor.  Remove members.
5105         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5106         (ravenscar_thread_target::store_registers)
5107         (ravenscar_thread_target::prepare_to_store): Update.
5108         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5109         Remove.
5110         (struct ppc_ravenscar_powerpc_ops): Derive from
5111         ravenscar_arch_ops.
5112         (ppc_ravenscar_powerpc_ops::fetch_registers)
5113         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5114         (ppc_ravenscar_powerpc_ops): Redefine.
5115         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5116         (ppc_ravenscar_e500_ops::fetch_registers)
5117         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5118         (ppc_ravenscar_e500_ops): Redefine.
5119         * aarch64-ravenscar-thread.c
5120         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5121         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5122         (aarch64_ravenscar_fetch_registers)
5123         (aarch64_ravenscar_store_registers): Now methods.
5124         (aarch64_ravenscar_ops): Redefine.
5125
5126 2019-02-15  Tom Tromey  <tromey@adacore.com>
5127
5128         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5129         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5130         (ravenscar_thread_target::stopped_by_watchpoint)
5131         (ravenscar_thread_target::stopped_data_address)
5132         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5133
5134 2019-02-15  Tom Tromey  <tromey@adacore.com>
5135
5136         * ravenscar-thread.c: Fix some typos.
5137
5138 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5139             Tom Tromey  <tromey@adacore.com>
5140
5141         * ada-lang.c (ada_exception_sal): Change addr_string to a
5142         std::string.
5143         (create_ada_exception_catchpoint): Update.
5144
5145 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5146             Tom Tromey  <tromey@adacore.com>
5147
5148         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5149         (bp_location_ops): Remove.
5150         (base_breakpoint_allocate_location): Update.
5151         (free_bp_location): Update.
5152         * ada-lang.c (class ada_catchpoint_location)
5153         <ada_catchpoint_location>: Remove ops parameter.
5154         (ada_catchpoint_location_dtor): Remove.
5155         (ada_catchpoint_location_ops): Remove.
5156         (allocate_location_exception): Update.
5157         * breakpoint.h (struct bp_location_ops): Remove.
5158         (class bp_location) <bp_location>: Remove bp_location_ops
5159         parameter.
5160         <~bp_location>: Add destructor.
5161         <ops>: Remove.
5162
5163 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5164             Pedro Alves  <palves@redhat.com>
5165
5166         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5167         'PATH_MAX'.
5168
5169 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5170             Samuel Thibault  <samuel.thibault@gnu.org>
5171             Thomas Schwinge  <thomas@codesourcery.com>
5172
5173         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5174         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5175
5176 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5177
5178         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5179         (check_empty): Use "const char *".
5180
5181         * gnu-nat.c (gnu_nat_target::detach): Instead of
5182         'detach_inferior (pid)' call
5183         'detach_inferior (find_inferior_pid (pid))'.
5184
5185         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5186         'nat/fork-inferior.o'.
5187         * gnu-nat.c: #include "nat/fork-inferior.h".
5188
5189         * gnu-nat.c (gnu_nat_target::detach): Instead of
5190         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5191         * gnu-nat.h: #include "inf-child.h".
5192         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5193         'i386_gnu_nat_target::fetch_registers'.
5194         (gnu_store_registers): Rename/move to
5195         'i386_gnu_nat_target::store_registers'.
5196
5197         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5198         * gnu-nat.h (mach_thread_info): New function.
5199         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5200
5201         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5202
5203 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5204
5205         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5206
5207 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5208
5209         * windows-nat.c (windows_add_thread): Add new parameter
5210         "main_thread_p" with default value set to false.  Update
5211         function documentation as well as all callers.
5212         (windows_delete_thread): Likewise.
5213         (fake_create_process): Update call to windows_add_thread.
5214         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5215         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5216         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5217         call to windows_delete_thread.
5218
5219 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5220
5221         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5222
5223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5224
5225         * symfile.c (find_separate_debug_file): Use canonical path of
5226         sysroot with child_path instead of gdb_sysroot if it is valid.
5227
5228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5229
5230         * symfile.c (find_separate_debug_file): Use child_path to
5231         determine if an object file is under a sysroot.
5232
5233 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5234
5235         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5236         unittests/child-path-selftests.c.
5237         * common/pathstuff.c (child_path): New function.
5238         * common/pathstuff.h (child_path): New prototype.
5239         * unittests/child-path-selftests.c: New file.
5240
5241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5242
5243         * symfile.c (find_separate_debug_file): Look for separate debug
5244         files in debug directories under the sysroot.
5245
5246 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5247
5248         * symtab.h (struct minimal_symbol data_p): New const method.
5249         (struct minimal_symbol text_p): Likewise.
5250         * symtab.c (output_source_filename): Use file name style
5251         to print file name.
5252         (print_symbol_info): Likewise.
5253         (print_msymbol_info): Use address style to print addresses.
5254         Use function name style to print executable text symbols.
5255         (expand_symtab_containing_pc): Use data_p.
5256         (find_pc_sect_compunit_symtab): Likewise.
5257
5258 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5259
5260         * breakpoint.c (describe_other_breakpoints): Use address style
5261         to print addresses.
5262         (say_where): Likewise.
5263
5264 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5265
5266         * ada-typeprint.c (print_func_type): Print function name
5267         style to print function name.
5268         * c-typeprint.c (c_print_type_1): Likewise.
5269
5270 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5271
5272         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5273         for execve.
5274
5275 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5276
5277         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5278         type_stack.
5279
5280 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5281
5282         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5283         TYPE_CODE_REF types.
5284
5285 2019-02-08  Jim Wilson  <jimw@sifive.com>
5286
5287         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5288         (riscv_linux_fregset): New.
5289         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5290
5291 2019-02-07  Tom Tromey  <tom@tromey.com>
5292
5293         * thread.c (thread_cancel_execution_command): Update.
5294         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5295         methods.
5296         (struct thread_fsm_ops): Remove.
5297         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5298         (thread_fsm_should_stop, thread_fsm_return_value)
5299         (thread_fsm_set_finished, thread_fsm_finished_p)
5300         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5301         Don't declare.
5302         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5303         * infrun.c (clear_proceed_status_thread)
5304         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5305         (print_stop_event): Update.
5306         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5307         Add constructor.
5308         (step_command_fsm_ops): Remove.
5309         (new_step_command_fsm): Remove.
5310         (step_1): Update.
5311         (step_command_fsm::should_stop): Rename from
5312         step_command_fsm_should_stop.
5313         (step_command_fsm::clean_up): Rename from
5314         step_command_fsm_clean_up.
5315         (step_command_fsm::do_async_reply_reason): Rename from
5316         step_command_fsm_async_reply_reason.
5317         (struct until_next_fsm): Inherit from thread_fsm.  Add
5318         constructor.
5319         (until_next_fsm_ops): Remove.
5320         (new_until_next_fsm): Remove.
5321         (until_next_fsm::should_stop): Rename from
5322         until_next_fsm_should_stop.
5323         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5324         (until_next_fsm::do_async_reply_reason): Rename from
5325         until_next_fsm_async_reply_reason.
5326         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5327         constructor.  Change type of breakpoint.
5328         (finish_command_fsm_ops): Remove.
5329         (new_finish_command_fsm): Remove.
5330         (finish_command_fsm::should_stop): Rename from
5331         finish_command_fsm_should_stop.
5332         (finish_command_fsm::clean_up): Rename from
5333         finish_command_fsm_clean_up.
5334         (finish_command_fsm::return_value): Rename from
5335         finish_command_fsm_return_value.
5336         (finish_command_fsm::do_async_reply_reason): Rename from
5337         finish_command_fsm_async_reply_reason.
5338         (finish_command): Update.
5339         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5340         Add constructor.
5341         (call_thread_fsm_ops): Remove.
5342         (call_thread_fsm::call_thread_fsm): Rename from
5343         new_call_thread_fsm.
5344         (call_thread_fsm::should_stop): Rename from
5345         call_thread_fsm_should_stop.
5346         (call_thread_fsm::should_notify_stop): Rename from
5347         call_thread_fsm_should_notify_stop.
5348         (run_inferior_call, call_function_by_hand_dummy): Update.
5349         * cli/cli-interp.c (should_print_stop_to_console): Update.
5350         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5351         Add constructor.  Change type of location_breakpoint,
5352         caller_breakpoint.
5353         (until_break_fsm_ops): Remove.
5354         (new_until_break_fsm): Remove.
5355         (until_break_fsm::should_stop): Rename from
5356         until_break_fsm_should_stop.
5357         (until_break_fsm::clean_up): Rename from
5358         until_break_fsm_clean_up.
5359         (until_break_fsm::do_async_reply_reason): Rename from
5360         until_break_fsm_async_reply_reason.
5361         (until_break_command): Update.
5362         * thread-fsm.c: Remove.
5363         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5364
5365 2019-02-07  Tom Tromey  <tom@tromey.com>
5366
5367         * yy-remap.h: Add include guard.
5368         * xtensa-tdep.h: Add include guard.
5369         * xcoffread.h: Rename include guard.
5370         * varobj-iter.h: Add include guard.
5371         * tui/tui.h: Rename include guard.
5372         * tui/tui-winsource.h: Rename include guard.
5373         * tui/tui-wingeneral.h: Rename include guard.
5374         * tui/tui-windata.h: Rename include guard.
5375         * tui/tui-win.h: Rename include guard.
5376         * tui/tui-stack.h: Rename include guard.
5377         * tui/tui-source.h: Rename include guard.
5378         * tui/tui-regs.h: Rename include guard.
5379         * tui/tui-out.h: Rename include guard.
5380         * tui/tui-layout.h: Rename include guard.
5381         * tui/tui-io.h: Rename include guard.
5382         * tui/tui-hooks.h: Rename include guard.
5383         * tui/tui-file.h: Rename include guard.
5384         * tui/tui-disasm.h: Rename include guard.
5385         * tui/tui-data.h: Rename include guard.
5386         * tui/tui-command.h: Rename include guard.
5387         * tic6x-tdep.h: Add include guard.
5388         * target/waitstatus.h: Rename include guard.
5389         * target/wait.h: Rename include guard.
5390         * target/target.h: Rename include guard.
5391         * target/resume.h: Rename include guard.
5392         * target-float.h: Rename include guard.
5393         * stabsread.h: Add include guard.
5394         * rs6000-tdep.h: Add include guard.
5395         * riscv-fbsd-tdep.h: Add include guard.
5396         * regformats/regdef.h: Rename include guard.
5397         * record.h: Rename include guard.
5398         * python/python.h: Rename include guard.
5399         * python/python-internal.h: Rename include guard.
5400         * python/py-stopevent.h: Rename include guard.
5401         * python/py-ref.h: Rename include guard.
5402         * python/py-record.h: Rename include guard.
5403         * python/py-record-full.h: Rename include guard.
5404         * python/py-record-btrace.h: Rename include guard.
5405         * python/py-instruction.h: Rename include guard.
5406         * python/py-events.h: Rename include guard.
5407         * python/py-event.h: Rename include guard.
5408         * procfs.h: Add include guard.
5409         * proc-utils.h: Add include guard.
5410         * p-lang.h: Add include guard.
5411         * or1k-tdep.h: Rename include guard.
5412         * observable.h: Rename include guard.
5413         * nto-tdep.h: Rename include guard.
5414         * nat/x86-linux.h: Rename include guard.
5415         * nat/x86-linux-dregs.h: Rename include guard.
5416         * nat/x86-gcc-cpuid.h: Add include guard.
5417         * nat/x86-dregs.h: Rename include guard.
5418         * nat/x86-cpuid.h: Rename include guard.
5419         * nat/ppc-linux.h: Rename include guard.
5420         * nat/mips-linux-watch.h: Rename include guard.
5421         * nat/linux-waitpid.h: Rename include guard.
5422         * nat/linux-ptrace.h: Rename include guard.
5423         * nat/linux-procfs.h: Rename include guard.
5424         * nat/linux-osdata.h: Rename include guard.
5425         * nat/linux-nat.h: Rename include guard.
5426         * nat/linux-namespaces.h: Rename include guard.
5427         * nat/linux-btrace.h: Rename include guard.
5428         * nat/glibc_thread_db.h: Rename include guard.
5429         * nat/gdb_thread_db.h: Rename include guard.
5430         * nat/gdb_ptrace.h: Rename include guard.
5431         * nat/fork-inferior.h: Rename include guard.
5432         * nat/amd64-linux-siginfo.h: Rename include guard.
5433         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5434         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5435         * nat/aarch64-linux.h: Rename include guard.
5436         * nat/aarch64-linux-hw-point.h: Rename include guard.
5437         * mn10300-tdep.h: Add include guard.
5438         * mips-linux-tdep.h: Add include guard.
5439         * mi/mi-parse.h: Rename include guard.
5440         * mi/mi-out.h: Rename include guard.
5441         * mi/mi-main.h: Rename include guard.
5442         * mi/mi-interp.h: Rename include guard.
5443         * mi/mi-getopt.h: Rename include guard.
5444         * mi/mi-console.h: Rename include guard.
5445         * mi/mi-common.h: Rename include guard.
5446         * mi/mi-cmds.h: Rename include guard.
5447         * mi/mi-cmd-break.h: Rename include guard.
5448         * m2-lang.h: Add include guard.
5449         * location.h: Rename include guard.
5450         * linux-record.h: Rename include guard.
5451         * linux-nat.h: Add include guard.
5452         * linux-fork.h: Add include guard.
5453         * i386-darwin-tdep.h: Rename include guard.
5454         * hppa-linux-offsets.h: Add include guard.
5455         * guile/guile.h: Rename include guard.
5456         * guile/guile-internal.h: Rename include guard.
5457         * gnu-nat.h: Rename include guard.
5458         * gdb-stabs.h: Rename include guard.
5459         * frv-tdep.h: Add include guard.
5460         * f-lang.h: Add include guard.
5461         * event-loop.h: Add include guard.
5462         * darwin-nat.h: Rename include guard.
5463         * cp-abi.h: Rename include guard.
5464         * config/sparc/nm-sol2.h: Rename include guard.
5465         * config/nm-nto.h: Rename include guard.
5466         * config/nm-linux.h: Add include guard.
5467         * config/i386/nm-i386gnu.h: Rename include guard.
5468         * config/djgpp/nl_types.h: Rename include guard.
5469         * config/djgpp/langinfo.h: Rename include guard.
5470         * compile/gcc-cp-plugin.h: Add include guard.
5471         * compile/gcc-c-plugin.h: Add include guard.
5472         * compile/compile.h: Rename include guard.
5473         * compile/compile-object-run.h: Rename include guard.
5474         * compile/compile-object-load.h: Rename include guard.
5475         * compile/compile-internal.h: Rename include guard.
5476         * compile/compile-cplus.h: Rename include guard.
5477         * compile/compile-c.h: Rename include guard.
5478         * common/xml-utils.h: Rename include guard.
5479         * common/x86-xstate.h: Rename include guard.
5480         * common/version.h: Rename include guard.
5481         * common/vec.h: Rename include guard.
5482         * common/tdesc.h: Rename include guard.
5483         * common/selftest.h: Rename include guard.
5484         * common/scoped_restore.h: Rename include guard.
5485         * common/scoped_mmap.h: Rename include guard.
5486         * common/scoped_fd.h: Rename include guard.
5487         * common/safe-iterator.h: Rename include guard.
5488         * common/run-time-clock.h: Rename include guard.
5489         * common/refcounted-object.h: Rename include guard.
5490         * common/queue.h: Rename include guard.
5491         * common/ptid.h: Rename include guard.
5492         * common/print-utils.h: Rename include guard.
5493         * common/preprocessor.h: Rename include guard.
5494         * common/pathstuff.h: Rename include guard.
5495         * common/observable.h: Rename include guard.
5496         * common/netstuff.h: Rename include guard.
5497         * common/job-control.h: Rename include guard.
5498         * common/host-defs.h: Rename include guard.
5499         * common/gdb_wait.h: Rename include guard.
5500         * common/gdb_vecs.h: Rename include guard.
5501         * common/gdb_unlinker.h: Rename include guard.
5502         * common/gdb_unique_ptr.h: Rename include guard.
5503         * common/gdb_tilde_expand.h: Rename include guard.
5504         * common/gdb_sys_time.h: Rename include guard.
5505         * common/gdb_string_view.h: Rename include guard.
5506         * common/gdb_splay_tree.h: Rename include guard.
5507         * common/gdb_setjmp.h: Rename include guard.
5508         * common/gdb_ref_ptr.h: Rename include guard.
5509         * common/gdb_optional.h: Rename include guard.
5510         * common/gdb_locale.h: Rename include guard.
5511         * common/gdb_assert.h: Rename include guard.
5512         * common/filtered-iterator.h: Rename include guard.
5513         * common/filestuff.h: Rename include guard.
5514         * common/fileio.h: Rename include guard.
5515         * common/environ.h: Rename include guard.
5516         * common/common-utils.h: Rename include guard.
5517         * common/common-types.h: Rename include guard.
5518         * common/common-regcache.h: Rename include guard.
5519         * common/common-inferior.h: Rename include guard.
5520         * common/common-gdbthread.h: Rename include guard.
5521         * common/common-exceptions.h: Rename include guard.
5522         * common/common-defs.h: Rename include guard.
5523         * common/common-debug.h: Rename include guard.
5524         * common/cleanups.h: Rename include guard.
5525         * common/buffer.h: Rename include guard.
5526         * common/btrace-common.h: Rename include guard.
5527         * common/break-common.h: Rename include guard.
5528         * cli/cli-utils.h: Rename include guard.
5529         * cli/cli-style.h: Rename include guard.
5530         * cli/cli-setshow.h: Rename include guard.
5531         * cli/cli-script.h: Rename include guard.
5532         * cli/cli-interp.h: Rename include guard.
5533         * cli/cli-decode.h: Rename include guard.
5534         * cli/cli-cmds.h: Rename include guard.
5535         * charset-list.h: Add include guard.
5536         * buildsym-legacy.h: Rename include guard.
5537         * bfin-tdep.h: Add include guard.
5538         * ax.h: Rename include guard.
5539         * arm-linux-tdep.h: Add include guard.
5540         * arm-fbsd-tdep.h: Add include guard.
5541         * arch/xtensa.h: Rename include guard.
5542         * arch/tic6x.h: Add include guard.
5543         * arch/i386.h: Add include guard.
5544         * arch/arm.h: Rename include guard.
5545         * arch/arm-linux.h: Rename include guard.
5546         * arch/arm-get-next-pcs.h: Rename include guard.
5547         * arch/amd64.h: Add include guard.
5548         * arch/aarch64-insn.h: Rename include guard.
5549         * arch-utils.h: Rename include guard.
5550         * annotate.h: Add include guard.
5551         * amd64-darwin-tdep.h: Rename include guard.
5552         * aarch64-linux-tdep.h: Add include guard.
5553         * aarch64-fbsd-tdep.h: Add include guard.
5554         * aarch32-linux-nat.h: Add include guard.
5555
5556 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5557
5558         * macrotab.c (macro_define_internal): New function that
5559         factorizes macro_define_object_internal and macro_define_function
5560         code.
5561         (macro_define_object_internal): Use macro_define_internal.
5562         (macro_define_function): Likewise.
5563
5564 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5565
5566         * macrocmd.c (extract_identifier): Return
5567         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5568         callers.
5569
5570 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5571
5572         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5573
5574 2019-02-05  Tom Tromey  <tom@tromey.com>
5575
5576         * target.c (target_stack::unpush): Move assertion earlier.
5577
5578 2019-01-30  Tom Tromey  <tom@tromey.com>
5579
5580         PR python/23615:
5581         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5582         (gdbpy_parse_and_eval): Likewise.
5583         * python/python-internal.h (gdbpy_allow_threads): New class.
5584
5585 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5586
5587         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5588         (aarch64_fbsd_fpregmap): Move earlier.
5589         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5590         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5591         instead of individual calls to trad_frame_set_reg_addr.
5592         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5593         earlier.
5594         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5595         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5596         instead of individual calls to trad_frame_set_reg_addr.
5597
5598 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5599
5600         * CONTRIBUTE: Replace contribution list with wiki link.
5601
5602 2019-01-25  Tom Tromey  <tom@tromey.com>
5603
5604         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5605
5606 2019-01-25  Tom Tromey  <tom@tromey.com>
5607
5608         * xtensa-linux-nat.c: Fix common/ includes.
5609         * xml-support.h: Fix common/ includes.
5610         * xml-support.c: Fix common/ includes.
5611         * x86-linux-nat.c: Fix common/ includes.
5612         * windows-nat.c: Fix common/ includes.
5613         * varobj.h: Fix common/ includes.
5614         * varobj.c: Fix common/ includes.
5615         * value.c: Fix common/ includes.
5616         * valops.c: Fix common/ includes.
5617         * utils.c: Fix common/ includes.
5618         * unittests/xml-utils-selftests.c: Fix common/ includes.
5619         * unittests/utils-selftests.c: Fix common/ includes.
5620         * unittests/unpack-selftests.c: Fix common/ includes.
5621         * unittests/tracepoint-selftests.c: Fix common/ includes.
5622         * unittests/style-selftests.c: Fix common/ includes.
5623         * unittests/string_view-selftests.c: Fix common/ includes.
5624         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5625         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5626         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5627         * unittests/rsp-low-selftests.c: Fix common/ includes.
5628         * unittests/parse-connection-spec-selftests.c: Fix common/
5629         includes.
5630         * unittests/optional-selftests.c: Fix common/ includes.
5631         * unittests/offset-type-selftests.c: Fix common/ includes.
5632         * unittests/observable-selftests.c: Fix common/ includes.
5633         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5634         * unittests/memrange-selftests.c: Fix common/ includes.
5635         * unittests/memory-map-selftests.c: Fix common/ includes.
5636         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5637         * unittests/function-view-selftests.c: Fix common/ includes.
5638         * unittests/environ-selftests.c: Fix common/ includes.
5639         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5640         * unittests/common-utils-selftests.c: Fix common/ includes.
5641         * unittests/cli-utils-selftests.c: Fix common/ includes.
5642         * unittests/array-view-selftests.c: Fix common/ includes.
5643         * ui-file.c: Fix common/ includes.
5644         * tui/tui-io.c: Fix common/ includes.
5645         * tracepoint.h: Fix common/ includes.
5646         * tracepoint.c: Fix common/ includes.
5647         * tracefile-tfile.c: Fix common/ includes.
5648         * top.h: Fix common/ includes.
5649         * top.c: Fix common/ includes.
5650         * thread.c: Fix common/ includes.
5651         * target/waitstatus.h: Fix common/ includes.
5652         * target/waitstatus.c: Fix common/ includes.
5653         * target.h: Fix common/ includes.
5654         * target.c: Fix common/ includes.
5655         * target-memory.c: Fix common/ includes.
5656         * target-descriptions.c: Fix common/ includes.
5657         * symtab.h: Fix common/ includes.
5658         * symfile.c: Fix common/ includes.
5659         * stap-probe.c: Fix common/ includes.
5660         * spu-linux-nat.c: Fix common/ includes.
5661         * sparc-nat.c: Fix common/ includes.
5662         * source.c: Fix common/ includes.
5663         * solib.c: Fix common/ includes.
5664         * solib-target.c: Fix common/ includes.
5665         * ser-unix.c: Fix common/ includes.
5666         * ser-tcp.c: Fix common/ includes.
5667         * ser-pipe.c: Fix common/ includes.
5668         * ser-base.c: Fix common/ includes.
5669         * selftest-arch.c: Fix common/ includes.
5670         * s12z-tdep.c: Fix common/ includes.
5671         * rust-exp.y: Fix common/ includes.
5672         * rs6000-aix-tdep.c: Fix common/ includes.
5673         * riscv-tdep.c: Fix common/ includes.
5674         * remote.c: Fix common/ includes.
5675         * remote-notif.h: Fix common/ includes.
5676         * remote-fileio.h: Fix common/ includes.
5677         * remote-fileio.c: Fix common/ includes.
5678         * regcache.h: Fix common/ includes.
5679         * regcache.c: Fix common/ includes.
5680         * record-btrace.c: Fix common/ includes.
5681         * python/python.c: Fix common/ includes.
5682         * python/py-type.c: Fix common/ includes.
5683         * python/py-inferior.c: Fix common/ includes.
5684         * progspace.h: Fix common/ includes.
5685         * producer.c: Fix common/ includes.
5686         * procfs.c: Fix common/ includes.
5687         * proc-api.c: Fix common/ includes.
5688         * printcmd.c: Fix common/ includes.
5689         * ppc-linux-nat.c: Fix common/ includes.
5690         * parser-defs.h: Fix common/ includes.
5691         * osdata.c: Fix common/ includes.
5692         * obsd-nat.c: Fix common/ includes.
5693         * nat/x86-linux.c: Fix common/ includes.
5694         * nat/x86-linux-dregs.c: Fix common/ includes.
5695         * nat/x86-dregs.h: Fix common/ includes.
5696         * nat/x86-dregs.c: Fix common/ includes.
5697         * nat/ppc-linux.c: Fix common/ includes.
5698         * nat/mips-linux-watch.h: Fix common/ includes.
5699         * nat/mips-linux-watch.c: Fix common/ includes.
5700         * nat/linux-waitpid.c: Fix common/ includes.
5701         * nat/linux-ptrace.h: Fix common/ includes.
5702         * nat/linux-ptrace.c: Fix common/ includes.
5703         * nat/linux-procfs.c: Fix common/ includes.
5704         * nat/linux-personality.c: Fix common/ includes.
5705         * nat/linux-osdata.c: Fix common/ includes.
5706         * nat/linux-namespaces.c: Fix common/ includes.
5707         * nat/linux-btrace.h: Fix common/ includes.
5708         * nat/linux-btrace.c: Fix common/ includes.
5709         * nat/fork-inferior.c: Fix common/ includes.
5710         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5711         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5712         * nat/aarch64-linux.c: Fix common/ includes.
5713         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5714         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5715         * namespace.h: Fix common/ includes.
5716         * mips-linux-tdep.c: Fix common/ includes.
5717         * minsyms.c: Fix common/ includes.
5718         * mi/mi-parse.h: Fix common/ includes.
5719         * mi/mi-main.c: Fix common/ includes.
5720         * mi/mi-cmd-env.c: Fix common/ includes.
5721         * memrange.h: Fix common/ includes.
5722         * memattr.c: Fix common/ includes.
5723         * maint.h: Fix common/ includes.
5724         * maint.c: Fix common/ includes.
5725         * main.c: Fix common/ includes.
5726         * machoread.c: Fix common/ includes.
5727         * location.c: Fix common/ includes.
5728         * linux-thread-db.c: Fix common/ includes.
5729         * linux-nat.c: Fix common/ includes.
5730         * linux-fork.c: Fix common/ includes.
5731         * inline-frame.c: Fix common/ includes.
5732         * infrun.c: Fix common/ includes.
5733         * inflow.c: Fix common/ includes.
5734         * inferior.h: Fix common/ includes.
5735         * inferior.c: Fix common/ includes.
5736         * infcmd.c: Fix common/ includes.
5737         * inf-ptrace.c: Fix common/ includes.
5738         * inf-child.c: Fix common/ includes.
5739         * ia64-linux-nat.c: Fix common/ includes.
5740         * i387-tdep.c: Fix common/ includes.
5741         * i386-tdep.c: Fix common/ includes.
5742         * i386-linux-tdep.c: Fix common/ includes.
5743         * i386-linux-nat.c: Fix common/ includes.
5744         * i386-go32-tdep.c: Fix common/ includes.
5745         * i386-fbsd-tdep.c: Fix common/ includes.
5746         * i386-fbsd-nat.c: Fix common/ includes.
5747         * guile/scm-type.c: Fix common/ includes.
5748         * guile/guile.c: Fix common/ includes.
5749         * go32-nat.c: Fix common/ includes.
5750         * gnu-nat.c: Fix common/ includes.
5751         * gdbthread.h: Fix common/ includes.
5752         * gdbarch-selftests.c: Fix common/ includes.
5753         * gdb_usleep.c: Fix common/ includes.
5754         * gdb_select.h: Fix common/ includes.
5755         * gdb_bfd.c: Fix common/ includes.
5756         * gcore.c: Fix common/ includes.
5757         * fork-child.c: Fix common/ includes.
5758         * findvar.c: Fix common/ includes.
5759         * fbsd-nat.c: Fix common/ includes.
5760         * event-top.c: Fix common/ includes.
5761         * event-loop.c: Fix common/ includes.
5762         * dwarf2read.c: Fix common/ includes.
5763         * dwarf2loc.c: Fix common/ includes.
5764         * dwarf2-frame.c: Fix common/ includes.
5765         * dwarf-index-cache.c: Fix common/ includes.
5766         * dtrace-probe.c: Fix common/ includes.
5767         * disasm-selftests.c: Fix common/ includes.
5768         * defs.h: Fix common/ includes.
5769         * csky-tdep.c: Fix common/ includes.
5770         * cp-valprint.c: Fix common/ includes.
5771         * cp-support.h: Fix common/ includes.
5772         * cp-support.c: Fix common/ includes.
5773         * corelow.c: Fix common/ includes.
5774         * completer.h: Fix common/ includes.
5775         * completer.c: Fix common/ includes.
5776         * compile/compile.c: Fix common/ includes.
5777         * compile/compile-loc2c.c: Fix common/ includes.
5778         * compile/compile-cplus-types.c: Fix common/ includes.
5779         * compile/compile-cplus-symbols.c: Fix common/ includes.
5780         * command.h: Fix common/ includes.
5781         * cli/cli-dump.c: Fix common/ includes.
5782         * cli/cli-cmds.c: Fix common/ includes.
5783         * charset.c: Fix common/ includes.
5784         * build-id.c: Fix common/ includes.
5785         * btrace.h: Fix common/ includes.
5786         * btrace.c: Fix common/ includes.
5787         * breakpoint.h: Fix common/ includes.
5788         * breakpoint.c: Fix common/ includes.
5789         * ax.h:
5790         (enum agent_op): Fix common/ includes.
5791         * ax-general.c (struct aop_map): Fix common/ includes.
5792         * ax-gdb.c: Fix common/ includes.
5793         * auxv.c: Fix common/ includes.
5794         * auto-load.c: Fix common/ includes.
5795         * arm-tdep.c: Fix common/ includes.
5796         * arch/riscv.c: Fix common/ includes.
5797         * arch/ppc-linux-common.c: Fix common/ includes.
5798         * arch/i386.c: Fix common/ includes.
5799         * arch/arm.c: Fix common/ includes.
5800         * arch/arm-linux.c: Fix common/ includes.
5801         * arch/arm-get-next-pcs.c: Fix common/ includes.
5802         * arch/amd64.c: Fix common/ includes.
5803         * arch/aarch64.c: Fix common/ includes.
5804         * arch/aarch64-insn.c: Fix common/ includes.
5805         * arch-utils.c: Fix common/ includes.
5806         * amd64-windows-tdep.c: Fix common/ includes.
5807         * amd64-tdep.c: Fix common/ includes.
5808         * amd64-sol2-tdep.c: Fix common/ includes.
5809         * amd64-obsd-tdep.c: Fix common/ includes.
5810         * amd64-nbsd-tdep.c: Fix common/ includes.
5811         * amd64-linux-tdep.c: Fix common/ includes.
5812         * amd64-linux-nat.c: Fix common/ includes.
5813         * amd64-fbsd-tdep.c: Fix common/ includes.
5814         * amd64-fbsd-nat.c: Fix common/ includes.
5815         * amd64-dicos-tdep.c: Fix common/ includes.
5816         * amd64-darwin-tdep.c: Fix common/ includes.
5817         * agent.c: Fix common/ includes.
5818         * ada-lang.h: Fix common/ includes.
5819         * ada-lang.c: Fix common/ includes.
5820         * aarch64-tdep.c: Fix common/ includes.
5821
5822 2019-01-25  Tom Tromey  <tom@tromey.com>
5823
5824         * common/create-version.sh: Use common/version.h.
5825
5826 2019-01-24  Pedro Alves  <palves@redhat.com>
5827
5828         * infrun.c (signal_stop, signal_print, signal_program)
5829         (signal_catch, signal_pass): Now arrays instead of pointers.
5830         (update_signals_program_target, do_target_resume)
5831         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5832         * linux-nat.c (linux_nat_target::pass_signals)
5833         (linux_nat_target::create_inferior, linux_nat_target::attach):
5834         Adjust.
5835         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5836         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5837         * procfs.c (procfs_target::pass_signals): Adjust.
5838         * record-full.c (record_full_target::resume): Adjust.
5839         * remote.c (remote_target::pass_signals)
5840         (remote_target::program_signals): Adjust.
5841         * target-debug.h (target_debug_print_signals): Now takes a
5842         gdb::array_view as parameter.  Adjust.
5843         * target.h (target_ops) <pass_signals, program_signals>: Replace
5844         pointer and length parameters with gdb::array_view.
5845         (target_pass_signals, target_program_signals): Likewise.
5846         * target-delegates.c: Regenerate.
5847
5848 2019-01-24  Pedro Alves  <palves@redhat.com>
5849
5850         * common/forward-scope-exit.h
5851         (forward_scope_exit::forward_scope_exit): Pass arguments to
5852         m_bind_function directly, instead of creating a std::bind and
5853         copying that.
5854
5855 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5856
5857         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5858         for static members.
5859         (pass_in_v_vfp_candidate): Likewise.
5860
5861 2019-01-23  Tom Tromey  <tom@tromey.com>
5862             Pedro Alves  <palves@redhat.com>
5863
5864         * regcache.c (class regcache_invalidator): Remove.
5865         (regcache::raw_write): Use make_scope_exit.
5866
5867 2019-01-23  Tom Tromey  <tom@tromey.com>
5868
5869         * ui-out.h (class ui_out_emit_type): Update comment.
5870
5871 2019-01-23  Tom Tromey  <tom@tromey.com>
5872
5873         * infrun.c (fetch_inferior_event): Update comment.
5874
5875 2019-01-23  Tom Tromey  <tom@tromey.com>
5876             Pedro Alves  <palves@redhat.com>
5877
5878         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5879         parameter.
5880         (fetch_inferior_event): Use SCOPE_EXIT.
5881
5882
5883 2019-01-23  Tom Tromey  <tom@tromey.com>
5884             Pedro Alves  <palves@redhat.com>
5885
5886         * infrun.c (disable_thread_events): Delete.
5887         (stop_all_threads): Use SCOPE_EXIT.
5888
5889 2019-01-23  Tom Tromey  <tom@tromey.com>
5890             Pedro Alves  <palves@redhat.com>
5891
5892         * symfile.c: Include forward-scope-exit.h.
5893         (clear_symtab_users_cleanup): Replace forward declaration with
5894         a FORWARD_SCOPE_EXIT.
5895         (syms_from_objfile_1): Use the forward_scope_exit and
5896         gdb::optional instead of cleanup_function.
5897         (reread_symbols): Use the forward_scope_exit instead of
5898         cleanup_function.
5899         (clear_symtab_users_cleanup): Remove function.
5900
5901 2019-01-23  Tom Tromey  <tom@tromey.com>
5902             Pedro Alves  <palves@redhat.com>
5903
5904         * linux-nat.c: Include scope-exit.h.
5905         (cleanup_target_stop): Remove.
5906         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5907         SCOPE_EXIT.
5908
5909 2019-01-23  Tom Tromey  <tom@tromey.com>
5910             Pedro Alves  <palves@redhat.com>
5911
5912         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5913         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5914
5915 2019-01-23  Tom Tromey  <tom@tromey.com>
5916             Andrew Burgess  <andrew.burgess@embecosm.com>
5917             Pedro Alves  <palves@redhat.com>
5918
5919         * infrun.c (fetch_inferior_event): Use scope_exit.
5920         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5921         * top.c (execute_command): Use scope_exit.
5922         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5923         * utils.c (do_bpstat_clear_actions_cleanup)
5924         (make_bpstat_clear_actions_cleanup): Remove.
5925
5926 2019-01-23  Tom Tromey  <tom@tromey.com>
5927             Pedro Alves  <palves@redhat.com>
5928
5929         * infrun.c: Include "common/scope-exit.h"
5930         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5931         (wait_for_inferior): Use SCOPE_EXIT.
5932         (fetch_inferior_event): Use scope_exit.
5933
5934 2019-01-23  Tom Tromey  <tom@tromey.com>
5935             Pedro Alves  <palves@redhat.com>
5936
5937         * breakpoint.c (create_breakpoint): Remove cleanup.
5938
5939 2019-01-23  Tom Tromey  <tom@tromey.com>
5940             Andrew Burgess  <andrew.burgess@embecosm.com>
5941             Pedro Alves  <palves@redhat.com>
5942
5943 2019-01-23  Pedro Alves  <palves@redhat.com>
5944
5945         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5946
5947 2019-01-23  Pedro Alves  <palves@redhat.com>
5948             Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * gdbthread.h: Include "common/forward-scope-exit.h".
5951         (scoped_finish_thread_state): Redefine custom class in terms of
5952         forward_scope_exit.
5953
5954 2019-01-23  Pedro Alves  <palves@redhat.com>
5955             Andrew Burgess  <andrew.burgess@embecosm.com>
5956
5957         * common/forward-scope-exit.h: New file.
5958
5959 2019-01-23  Pedro Alves  <palves@redhat.com>
5960             Andrew Burgess  <andrew.burgess@embecosm.com>
5961             Tom Tromey  <tom@tromey.com>
5962
5963         * common/scope-exit.h: New file.
5964
5965 2019-01-23  Pedro Alves  <palves@redhat.com>
5966
5967         * common/preprocessor.h (ESC): Rename to ...
5968         (ESC_PARENS): ... this.
5969         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5970         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5971
5972 2019-01-23  Tom Tromey  <tom@tromey.com>
5973
5974         * language.h (class scoped_switch_to_sym_language_if_auto):
5975         Initialize m_lang in both cases.
5976
5977 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5978
5979         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5980         with XCNEW.
5981
5982 2019-01-22  Tom Tromey  <tom@tromey.com>
5983
5984         * corelow.c: Do not include sys/file.h.
5985
5986 2019-01-22  Tom Tromey  <tom@tromey.com>
5987
5988         * tui/tui-wingeneral.h: Include gdb_curses.h.
5989
5990 2019-01-22  Tom Tromey  <tom@tromey.com>
5991
5992         * source-cache.h (class source_cache) <get_source_lines,
5993         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5994
5995 2019-01-22  Tom Tromey  <tom@tromey.com>
5996
5997         * remote-fileio.h (struct remote_target): Declare.
5998
5999 2019-01-22  Tom Tromey  <tom@tromey.com>
6000
6001         * python/py-arch.c: Do not include py-ref.h.
6002         * python/py-bpevent.c: Do not include py-ref.h.
6003         * python/py-cmd.c: Do not include py-ref.h.
6004         * python/py-continueevent.c: Do not include py-ref.h.
6005         * python/py-event.h: Do not include py-ref.h.
6006         * python/py-evtregistry.c: Do not include py-ref.h.
6007         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6008         * python/py-frame.c: Do not include py-ref.h.
6009         * python/py-framefilter.c: Do not include py-ref.h.
6010         * python/py-function.c: Do not include py-ref.h.
6011         * python/py-infevents.c: Do not include py-ref.h.
6012         * python/py-linetable.c: Do not include py-ref.h.
6013         * python/py-objfile.c: Do not include py-ref.h.
6014         * python/py-param.c: Do not include py-ref.h.
6015         * python/py-prettyprint.c: Do not include py-ref.h.
6016         * python/py-progspace.c: Do not include py-ref.h.
6017         * python/py-symbol.c: Do not include py-ref.h.
6018         * python/py-symtab.c: Do not include py-ref.h.
6019         * python/py-type.c: Do not include py-ref.h.
6020         * python/py-unwind.c: Do not include py-ref.h.
6021         * python/py-utils.c: Do not include py-ref.h.
6022         * python/py-value.c: Do not include py-ref.h.
6023         * python/py-varobj.c: Do not include py-ref.h.
6024         * python/py-xmethods.c: Do not include py-ref.h.
6025         * python/python.c: Do not include py-ref.h.
6026         * varobj.c: Do not include py-ref.h.
6027
6028 2019-01-22  Tom Tromey  <tom@tromey.com>
6029
6030         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6031         keyword for bcache.
6032
6033 2019-01-22  Tom Tromey  <tom@tromey.com>
6034
6035         * compile/compile-cplus-types.c: Remove a comment by #include.
6036
6037 2019-01-22  Tom Tromey  <tom@tromey.com>
6038
6039         * compile/gcc-c-plugin.h: Include compile-internal.h.
6040
6041 2019-01-22  Tom Tromey  <tom@tromey.com>
6042
6043         * stabsread.c (EXTERN): Do not define.
6044         (symnum, next_symbol_text_func, processing_gcc_compilation)
6045         (within_function, global_sym_chain, global_stabs)
6046         (previous_stab_code, this_object_header_files)
6047         (n_this_object_header_files)
6048         (n_allocated_this_object_header_files): Define.
6049         * stabsread.h (EXTERN): Never define.  Use "extern".
6050
6051 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6052
6053         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6054         history_value.
6055
6056 2019-01-21  Tom Tromey  <tom@tromey.com>
6057
6058         * ui-out.c: Fix includes.
6059         * tui/tui-source.c: Fix includes.
6060         * target.c: Fix includes.
6061         * remote.c: Fix includes.
6062         * regcache.c: Fix includes.
6063         * python/py-block.c: Fix includes.
6064         * printcmd.c: Fix includes.
6065         * or1k-tdep.c: Fix includes.
6066         * mi/mi-main.c: Fix includes.
6067         * m32r-tdep.c: Fix includes.
6068         * csky-tdep.c: Fix includes.
6069         * compile/compile-cplus-types.c: Fix includes.
6070         * cli/cli-interp.c: Fix includes.
6071
6072 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6075         for padding.
6076
6077 2019-01-16  Tom Tromey  <tom@tromey.com>
6078
6079         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6080         earlier.
6081         (struct objfile) <msymbols_range>: Move from top level.
6082         <msymbols>: New method.
6083         (class objfile_msymbols): Remove.
6084         * symtab.c (default_collect_symbol_completion_matches_break_on):
6085         Update.
6086         * symmisc.c (dump_msymbols): Update.
6087         * stabsread.c (scan_file_globals): Update.
6088         * objc-lang.c (info_selectors_command, info_classes_command)
6089         (find_methods): Update.
6090         * minsyms.c (find_solib_trampoline_target): Update.
6091         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6092         * coffread.c (coff_symfile_read): Update.
6093         * ada-lang.c (ada_lookup_simple_minsym)
6094         (ada_collect_symbol_completion_matches): Update.
6095
6096 2019-01-16  Tom Tromey  <tom@tromey.com>
6097
6098         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6099         type.  Remove no-argument constructor.
6100         <iterator::operator++>: Simplify.
6101         <begin>: Update.
6102         <end>: Use minimal_symbol_count.
6103
6104 2019-01-16  Tom Tromey  <tom@tromey.com>
6105
6106         * objfiles.h (struct objfile) <psymtabs>: New method.
6107         (class objfile_psymtabs): Remove.
6108         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6109         typedef.
6110         <range>: New method.
6111         (require_partial_symbols): Change return type.
6112         * psymtab.c (require_partial_symbols)
6113         (psym_expand_symtabs_matching): Update.
6114         * mdebugread.c (parse_partial_symbols): Update.
6115         * dbxread.c (dbx_end_psymtab): Update.
6116
6117 2019-01-15  Tom Tromey  <tom@tromey.com>
6118
6119         * symtab.c (lookup_objfile_from_block)
6120         (lookup_symbol_in_objfile_symtabs)
6121         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6122         (find_line_symtab, info_sources_command)
6123         (default_collect_symbol_completion_matches_break_on)
6124         (make_source_files_completion_list): Update.
6125         * symmisc.c (print_objfile_statistics, dump_objfile)
6126         (maintenance_print_symbols, maintenance_info_symtabs)
6127         (maintenance_check_symtabs, maintenance_info_line_tables):
6128         Update.
6129         * source.c (select_source_symtab)
6130         (forget_cached_source_info_for_objfile): Update.
6131         * objfiles.h (class objfile_compunits): Remove.
6132         (struct objfile) <compunits_range>: New typedef.
6133         (compunits): New method.
6134         * objfiles.c (objfile_relocate1): Update.
6135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6136         * maint.c (count_symtabs_and_blocks): Update.
6137         * linespec.c (iterate_over_all_matching_symtabs): Update.
6138         * cp-support.c (add_symbol_overload_list_qualified): Update.
6139         * coffread.c (coff_symtab_read): Update.
6140         * ada-lang.c (add_nonlocal_symbols)
6141         (ada_collect_symbol_completion_matches)
6142         (ada_add_global_exceptions): Update.
6143
6144 2019-01-15  Tom Tromey  <tom@tromey.com>
6145
6146         * progspace.h (program_space) <objfiles_safe_range>: New
6147         typedef.
6148         <objfiles_safe>: New method.
6149         * objfiles.h (class all_objfiles_safe): Remove.
6150         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6151         * jit.c (jit_inferior_exit_hook): Update.
6152
6153 2019-01-17  Tom Tromey  <tom@tromey.com>
6154
6155         * progspace.h (program_space) <objfiles_range>: New typedef.
6156         <objfiles>: New method.
6157         <objfiles_head>: Rename from objfiles.
6158         (object_files): Update.
6159         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6160         * guile/scm-pretty-print.c
6161         (ppscm_find_pretty_printer_from_objfiles): Update.
6162         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6163         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6164         Update.
6165         * python/py-progspace.c (pspy_get_objfiles): Update.
6166         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6167         Update.
6168         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6169         (objfpy_lookup_objfile_by_build_id): Update.
6170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6171         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6172         Update.
6173         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6174         (expand_symtab_containing_pc, lookup_objfile_from_block)
6175         (lookup_static_symbol, basic_lookup_transparent_type)
6176         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6177         (find_line_symtab, info_sources_command)
6178         (default_collect_symbol_completion_matches_break_on)
6179         (make_source_files_completion_list, find_main_name): Update.
6180         * symmisc.c (print_symbol_bcache_statistics)
6181         (print_objfile_statistics, maintenance_print_symbols)
6182         (maintenance_print_msymbols, maintenance_print_objfiles)
6183         (maintenance_info_symtabs, maintenance_check_symtabs)
6184         (maintenance_expand_symtabs, maintenance_info_line_tables):
6185         Update.
6186         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6187         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6188         (map_overlay_command, unmap_overlay_command)
6189         (simple_overlay_update, expand_symtabs_matching)
6190         (map_symbol_filenames): Update.
6191         * symfile-debug.c (set_debug_symfile): Update.
6192         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6193         Update.
6194         * source.c (select_source_symtab, forget_cached_source_info):
6195         Update.
6196         * solib.c (solib_read_symbols): Update.
6197         * solib-spu.c (append_ocl_sos): Update.
6198         * psymtab.c (maintenance_print_psymbols)
6199         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6200         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6201         * printcmd.c (info_symbol_command): Update.
6202         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6203         Update.
6204         * objfiles.h (class all_objfiles): Remove.
6205         * objfiles.c (have_partial_symbols, have_full_symbols)
6206         (have_minimal_symbols, qsort_cmp, update_section_map)
6207         (shared_objfile_contains_address_p)
6208         (default_iterate_over_objfiles_in_search_order): Update.
6209         * objc-lang.c (info_selectors_command, info_classes_command)
6210         (find_methods): Update.
6211         * minsyms.c (find_solib_trampoline_target): Update.
6212         * maint.c (maintenance_info_sections)
6213         (maintenance_translate_address, count_symtabs_and_blocks):
6214         Update.
6215         * main.c (captured_main_1): Update.
6216         * linux-thread-db.c (try_thread_db_load_from_pdir)
6217         (has_libpthread): Update.
6218         * linespec.c (iterate_over_all_matching_symtabs)
6219         (search_minsyms_for_name): Update.
6220         * jit.c (jit_find_objf_with_entry_addr): Update.
6221         * hppa-tdep.c (find_unwind_entry)
6222         (hppa_lookup_stub_minimal_symbol): Update.
6223         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6224         Update.
6225         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6226         (elf_gnu_ifunc_resolve_by_got): Update.
6227         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6228         * dwarf-index-write.c (save_gdb_index_command): Update.
6229         * cp-support.c (add_symbol_overload_list_qualified): Update.
6230         * breakpoint.c (create_overlay_event_breakpoint)
6231         (create_longjmp_master_breakpoint)
6232         (create_std_terminate_master_breakpoint)
6233         (create_exception_master_breakpoint): Update.
6234         * blockframe.c (find_pc_partial_function): Update.
6235         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6236         (ada_collect_symbol_completion_matches)
6237         (ada_add_global_exceptions): Update.
6238
6239 2019-01-17  Tom Tromey  <tom@tromey.com>
6240
6241         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6242         declare VEC.
6243         (solib_target_parse_libraries): Change return type.
6244         (library_list_start_segment, library_list_start_section)
6245         (library_list_end_library, library_list_start_library); Update.
6246         (solib_target_free_library_list): Remove.
6247         (solib_target_parse_libraries): Remove cleanup.  Change return
6248         type.
6249         (solib_target_current_sos): Update.
6250
6251 2019-01-17  Tom Tromey  <tromey@bapiya>
6252
6253         * valprint.c: Replace "the the" with "the".
6254         * symtab.c: Replace "the the" with "the".
6255         * solib.c: Replace "the the" with "the".
6256         * solib-dsbt.c: Replace "the the" with "the".
6257         * linespec.c: Replace "the the" with "the".
6258         * dwarf2loc.h: Replace "the the" with "the".
6259         * amd64-windows-tdep.c: Replace "the the" with "the".
6260         * aarch64-tdep.c: Replace "the the" with "the".
6261
6262 2019-01-16  Keith Seitz  <keiths@redhat.com>
6263
6264         PR gdb/23773
6265         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6266         <builder>: Rename to ..
6267         <m_builder>: ... this and make private.
6268         (dwarf2_cu::get_builder): New method.  Change all users of
6269         `builder' to use this method.
6270         (dwarf2_start_symtab): Move to ...
6271         (dwarf2_cu::start_symtab): ... here.  Update all callers
6272         (setup_type_unit_groups): Move to ...
6273         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6274         callers.
6275         (dwarf2_cu::reset_builder): New method.
6276         (process_full_compunit, process_full_type_unit): Use
6277         dwarf2_cu::reset_builder.
6278         (follow_die_offset): Record the ancestor CU if it is different
6279         from the followed DIE's CU.
6280         (follow_die_sig_1): Likewise.
6281
6282 2019-01-15  Tom Tromey  <tom@tromey.com>
6283
6284         * remote.c (class remote_state) <buf>: Now a char_vector.
6285         <buf_size>: Remove.
6286         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6287         parameter.
6288         (remote_target::getpkt_or_notif_sane_1)
6289         (remote_target::getpkt_sane)
6290         (remote_target::getpkt_or_notif_sane): Likewise.
6291         (class remote_target) <putpkt>: New overload.
6292         (remote_target::read_frame): Change type of "buf_p".  Remove
6293         sizeof_p parameter.
6294         (packet_ok): New overload.
6295         (packet_check_result): New overload.
6296         Update all uses.
6297
6298 2019-01-14  Tom Tromey  <tom@tromey.com>
6299
6300         * remote-notif.c (handle_notification, remote_notif_ack)
6301         (remote_notif_parse): Make "buf" const.
6302         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6303         const.
6304         (remote_notif_parse, remote_notif_ack, handle_notification):
6305         Likewise.
6306         * remote.c (remote_notif_stop_parse): Make "buf" const.
6307         (remote_target::remote_parse_stop_reply): Make "buf" const.
6308         (remote_notif_stop_ack): Make "buf" const.
6309
6310 2019-01-14  Tom Tromey  <tom@tromey.com>
6311
6312         * remote.c (remote_console_output): Make parameter const.
6313
6314 2019-01-14  Tom Tromey  <tom@tromey.com>
6315
6316         * target-debug.h (target_debug_print_signals): Constify.
6317         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6318         * procfs.c (procfs_target::pass_signals): Update.
6319         * linux-nat.c (linux_nat_target::pass_signals): Update.
6320         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6321         * target-delegates.c: Rebuild.
6322         * remote.c (remote_target::program_signals): Update.
6323         (remote_target::pass_signals): Update.
6324         * target.c (target_pass_signals): Constify argument.
6325         (target_program_signals): Likewise.
6326         * target.h (struct target_ops) <pass_signals, program_signals>:
6327         Constify argument.
6328         (target_pass_signals, target_program_signals): Constify argument.
6329
6330 2019-01-14  Tom Tromey  <tom@tromey.com>
6331
6332         PR tui/28819:
6333         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6334
6335 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6336
6337         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6338         field.
6339         * rs6000-tdep.c: Include reggroups.h.
6340         (IS_V_ALIAS_PSEUDOREG): Define.
6341         (rs6000_register_name): Return names for the "vX" aliases.
6342         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6343         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6344         aliases.  Call default_register_reggroup_p for all other
6345         pseudo-registers.
6346         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6347         New functions.
6348         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6349         Handle "vX" aliases.
6350         (v_alias_pseudo_register_collect): New function.
6351         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6352         (rs6000_gdbarch_init): Initialize "vX" aliases as
6353         pseudo-registers.  Restore registration of
6354         rs6000_pseudo_register_reggroup_p with
6355         set_tdesc_pseudo_register_reggroup_p.
6356
6357 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6358
6359         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6360         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6361         set_gdbarch_num_pseudo_regs.
6362
6363 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6364
6365         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6366         Remove arg prefixname, add do_set and do_show.
6367         Add member functions set_list and show_list.
6368         * cli/cli-style.c (class cli_style_option): Update accordingly.
6369         (style_set_list): Move to file scope.
6370         (style_show_list): Likewise.
6371         (set_style): Call help_list.
6372         (show_style): Call cmd_show_list.
6373         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6374         Update to use the new macro.
6375
6376 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6377
6378         * ada-lang.c (_initialize_ada_language): Expand the help text
6379         for the "catch exception" command.
6380
6381 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6382
6383         * symtab.c (matching_obj_sections): Initialize obj,
6384         declare it closer to its usage.
6385
6386 2019-01-10  Tom Tromey  <tom@tromey.com>
6387
6388         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6389         (basic_inf_threads_range): Remove.
6390         (inf_threads_range, inf_non_exited_threads_range)
6391         (safe_inf_threads_range): Use next_adapter.
6392
6393 2019-01-10  Keith Seitz  <keiths@redhat.com>
6394
6395         PR gdb/23712
6396         PR symtab/23010
6397         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6398         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6399
6400 2019-01-10  Keith Seitz  <keiths@redhat.com>
6401
6402         PR gdb/23712
6403         PR symtab/23010
6404         * dictionary.c (pending_to_vector): Remove.
6405         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6406         Remove _1 suffix, replacing functions of the same name.  Update
6407         all callers.
6408         (dict_create_hashed, dict_create_hashed_expandable)
6409         (dict_create_linear, dict_create_linear_expandable, dict_free)
6410         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6411         Make functions static.
6412
6413 2019-01-10  Keith Seitz  <keiths@redhat.com>
6414
6415         PR gdb/23712
6416         PR symtab/23010
6417         * dictionary.h (struct dictionary): Replace declaration with
6418         multidictionary.
6419         (dict_create_hashed, dict_create_hashed_expandable)
6420         (dict_create_linear, dict_create_linear_expandable)
6421         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6422         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6423         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6424         taking multidictionary argument.
6425         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6426         * block.h (struct block) <dict>: Change to multidictionary
6427         and rename `multidict'.
6428         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6429         symmisc.c: Update all dictionary references to multidictionary.
6430
6431 2019-01-10  Keith Seitz  <keiths@redhat.com>
6432
6433         PR gdb/23712
6434         PR symtab/23010
6435         * dictionary.c: Include unordered_map.
6436         (pending_to_vector): New function.
6437         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6438         Rewrite the non-"_1" functions to take vector instead
6439         of linked list.
6440         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6441         "new" _1 versions of the same name.
6442         (multidictionary): Define.
6443         (std::hash<enum language): New definition.
6444         (collate_pending_symbols_by_language, mdict_create_hashed)
6445         (mdict_create_hashed_expandable, mdict_create_linear)
6446         (mdict_create_linear_expandable, mdict_free)
6447         (find_language_dictionary, create_new_language_dictionary)
6448         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6449         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6450         (mdict_size, mdict_empty): New functions.
6451         * dictionary.h (mdict_iterator): Define.
6452
6453 2019-01-10  Pedro Alves  <palves@redhat.com>
6454
6455         * breakpoint.c (read_uploaded_action)
6456         (create_tracepoint_from_upload): Adjust to use
6457         gdb::unique_xmalloc_ptr.
6458         * ctf.c (ctf_write_uploaded_tp):
6459         (SET_ARRAY_FIELD): Use emplace_back.
6460         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6461         * tracefile-tfile.c (tfile_write_uploaded_tp):
6462         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6463         gdb::unique_xmalloc_ptr.
6464         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6465         at_string, cond_string, cmd_strings>: Replace char pointers
6466         with gdb::unique_xmalloc_ptr.
6467
6468 2019-01-10  Pedro Alves  <palves@redhat.com>
6469
6470         * solib-target.c (library_list_start_library): Don't xstrdup name.
6471
6472 2019-01-10  Pedro Alves  <palves@redhat.com>
6473
6474         * mdebugread.c (parse_partial_symbols): Use
6475         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6476
6477 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * linux-fork.c (scoped_switch_fork_info)
6480         <~scoped_switch_fork_info>: Fix incorrect variable name.
6481
6482 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * linux-fork.c (scoped_switch_fork_info)
6485         <scoped_switch_fork_info>: Make explicit.
6486         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6487
6488 2019-01-10  Tom Tromey  <tom@tromey.com>
6489
6490         * objfiles.h (objfile::reset_psymtabs): Update.
6491         * objfiles.c (objfile::objfile): Update.
6492         * psymtab.h (psymtab_storage::obstack): Update.
6493         (psymtab_storage::m_obstack): Use gdb::optional.
6494         (class psymtab_storage): Update comment.  Remove objfile
6495         parameter.
6496         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6497
6498 2019-01-10  Tom Tromey  <tom@tromey.com>
6499
6500         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6501         <free_psymtabs>: Now private.
6502         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6503         (allocate_psymtab): Use new method.
6504
6505 2019-01-10  Tom Tromey  <tom@tromey.com>
6506
6507         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6508         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6509         * mdebugread.c (parse_partial_symbols): Use
6510         allocate_dependencies.
6511         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6512         allocate_dependencies.
6513         (process_psymtab_comp_unit_reader)
6514         (build_type_psymtab_dependencies): Likewise.
6515         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6516
6517 2019-01-10  Tom Tromey  <tom@tromey.com>
6518
6519         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6520         PSYMBOL_SET_LANGUAGE.
6521         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6522
6523 2019-01-10  Tom Tromey  <tom@tromey.com>
6524
6525         * psymtab.h (psymtab_storage::obstack): New method.
6526         <m_obstack>: Rename from obstack; now private.
6527         * psymtab.c (psymtab_storage): Update.
6528         * dwarf2read.c (create_addrmap_from_index)
6529         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6530         Update.
6531
6532 2019-01-10  Tom Tromey  <tom@tromey.com>
6533
6534         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6535         * objfiles.h (objfile::reset_psymtabs): New method.
6536
6537 2019-01-10  Tom Tromey  <tom@tromey.com>
6538
6539         * symmisc.c (print_symbol_bcache_statistics): Update.
6540         (print_objfile_statistics): Update.
6541         * symfile.c (reread_symbols): Update.
6542         * psymtab.h (class psymtab_storage): New.
6543         * psymtab.c (psymtab_storage): New constructor.
6544         (~psymtab_storage): New destructor.
6545         (require_partial_symbols): Update.
6546         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6547         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6548         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6549         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6550         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6551         (start_psymtab_common, end_psymtab_common)
6552         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6553         (allocate_psymtab): Update.
6554         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6555         Update.
6556         (dump_psymtab_addrmap, maintenance_print_psymbols)
6557         (maintenance_check_psymtabs): Update.
6558         (class objfile_psymtabs): Move to objfiles.h.
6559         * psympriv.h (discard_psymtab): Now inline.
6560         (psymtab_discarder::psymtab_discarder): Update.
6561         (psymtab_discarder::~psymtab_discarder): Update.
6562         (ALL_OBJFILE_PSYMTABS): Rewrite.
6563         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6564         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6565         Remove fields.
6566         <partial_symtabs>: New field.
6567         (class objfile_psymtabs): Move from psymtab.h.  Update.
6568         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6569         psymbol_cache.
6570         (objfile::~objfile): Don't destroy psymbol_cache.
6571         * mdebugread.c (parse_partial_symbols): Update.
6572         * dwarf2read.c (create_addrmap_from_index)
6573         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6574         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6575         (add_partial_subprogram, dwarf2_ranges_read): Update.
6576         * dwarf-index-write.c (write_address_map)
6577         (write_one_signatured_type, recursively_write_psymbols)
6578         (class debug_names, class debug_names, write_psymtabs_to_index):
6579         Update.
6580
6581 2019-01-10  Tom Tromey  <tom@tromey.com>
6582
6583         * symtab.h (SYMBOL_SET_NAMES): Update.
6584         (symbol_set_names): Update.
6585         (MSYMBOL_SET_NAMES): Update.
6586         * symtab.c (symbol_set_names): Change argument to be an
6587         objfile_per_bfd_storage.
6588         * psymtab.c (add_psymbol_to_bcache): Update.
6589         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6590
6591 2019-01-10  Tom Tromey  <tom@tromey.com>
6592
6593         * symtab.c (create_demangled_names_hash): Change argument to be an
6594         objfile_per_bfd_storage.
6595         (symbol_set_names): Update.
6596
6597 2019-01-10  Tom Tromey  <tom@tromey.com>
6598
6599         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6600         init_psymbol_list.
6601         * psymtab.c (init_psymbol_list): Do nothing if already called.
6602         * psympriv.h (init_psymbol_list): Add comment.
6603         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6604         init_psymbol_list.
6605         * dbxread.c (dbx_symfile_read): Unconditionally call
6606         init_psymbol_list.
6607
6608 2019-01-10  Tom Tromey  <tom@tromey.com>
6609
6610         * xcoffread.c (scan_xcoff_symtab): Update.
6611         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6612         "where".
6613         * mdebugread.c (parse_partial_symbols)
6614         (handle_psymbol_enumerators): Update.
6615         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6616         * dbxread.c (read_dbx_symtab): Update.
6617         * psympriv.h (psymbol_placement): New enum.
6618         (add_psymbol_to_list): Update.
6619
6620 2019-01-10  Tom Tromey  <tom@tromey.com>
6621
6622         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6623         static_psymbols parameters.
6624         (scan_xcoff_symtab): Update.
6625         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6626         static_psymbols parameters.
6627         * psympriv.h (start_psymtab_common): Update.
6628         * mdebugread.c (parse_partial_symbols): Update.
6629         * dwarf2read.c (create_partial_symtab): Update.
6630         * dbxread.c (read_dbx_symtab): Update.
6631         (start_psymtab): Remove global_psymbols and static_psymbols
6632         parameters.
6633
6634 2019-01-10  Tom Tromey  <tom@tromey.com>
6635
6636         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6637         * psymtab.c (allocate_psymtab): Add comment.
6638         * psympriv.h (allocate_psymtab): Add comment.
6639         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6640         initializations.
6641         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6642
6643 2019-01-10  Tom Tromey  <tom@tromey.com>
6644
6645         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6646         Don't declare.
6647         * mipsread.c: Include mdebugread.h.
6648         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6649         Declare.
6650         * elfread.c: Include mdebugread.h.
6651
6652 2019-01-09  Tom Tromey  <tom@tromey.com>
6653
6654         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6655         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6656         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6657         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6658         (psym_lookup_symbol, psym_find_last_source_symtab)
6659         (psym_forget_cached_source_info, psym_print_stats)
6660         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6661         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6662         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6663         (psym_find_compunit_symtab_by_address)
6664         (maintenance_print_psymbols, maintenance_info_psymtabs)
6665         (maintenance_check_psymtabs): Use ranged for.
6666         * psymtab.h (class objfile_psymtabs): New.
6667         (require_partial_symbols): Return objfile_psymtabs.
6668         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6669
6670 2019-01-09  Tom Tromey  <tom@tromey.com>
6671
6672         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6673         (find_pc_mapped_section, list_overlays_command)
6674         (map_overlay_command, unmap_overlay_command)
6675         (simple_overlay_update): Use all_objfiles.
6676         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6677         * printcmd.c (info_symbol_command): Use all_objfiles.
6678         * objfiles.h (ALL_OBJSECTIONS): Remove.
6679         * maint.c (maintenance_translate_address): Use all_objfiles.
6680         * gcore.c (gcore_create_callback): Use all_objfiles.
6681         (objfile_find_memory_regions): Likewise.
6682
6683 2019-01-09  Tom Tromey  <tom@tromey.com>
6684
6685         * symtab.c (find_line_symtab, info_sources_command)
6686         (make_source_files_completion_list): Use objfile_compunits.
6687         * source.c (select_source_symtab): Use objfile_compunits.
6688         * objfiles.h (struct objfile): Update comment.
6689         (ALL_OBJFILES): Remove.
6690         (ALL_FILETABS): Remove.
6691         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6692         objfile_compunits.
6693
6694 2019-01-09  Tom Tromey  <tom@tromey.com>
6695
6696         * symmisc.c (print_objfile_statistics, dump_objfile)
6697         (maintenance_print_symbols): Use compunit_filetabs.
6698         * source.c (forget_cached_source_info_for_objfile): Use
6699         compunit_filetabs.
6700         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6701         (ALL_FILETABS): Use compunit_filetabs.
6702         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6703         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6704
6705 2019-01-09  Tom Tromey  <tom@tromey.com>
6706
6707         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6708         (compunit_filetabs): New.
6709         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6710         compunit_filetabs.
6711         (info_sources_command, make_source_files_completion_list): Remove
6712         declaration.
6713         * symmisc.c (print_objfile_statistics, dump_objfile)
6714         (maintenance_print_symbols): Remove declaration.
6715         (maintenance_info_symtabs): Use compunit_filetabs.
6716         (maintenance_info_line_tables): Likewise.
6717         * source.c (select_source_symtab): Change local variable name.
6718         (forget_cached_source_info_for_objfile): Remove declaration.
6719         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6720         * objfiles.c (objfile_relocate1): Remove declaration.
6721         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6722         declaration.
6723         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6724         * coffread.c (coff_symtab_read): Remove declaration.
6725         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6726         compunit_filetabs.
6727
6728 2019-01-09  Tom Tromey  <tom@tromey.com>
6729
6730         * symtab.c (lookup_objfile_from_block)
6731         (find_pc_sect_compunit_symtab, search_symbols)
6732         (default_collect_symbol_completion_matches_break_on): Use
6733         objfile_compunits.
6734         * objfiles.h (ALL_COMPUNITS): Remove.
6735         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6736         * cp-support.c (add_symbol_overload_list_qualified): Use
6737         objfile_compunits.
6738         * ada-lang.c (ada_collect_symbol_completion_matches)
6739         (ada_add_global_exceptions): Use objfile_compunits.
6740
6741 2019-01-09  Tom Tromey  <tom@tromey.com>
6742
6743         * source.c (select_source_symtab)
6744         (forget_cached_source_info_for_objfile): Remove declaration.
6745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6746         declaration.
6747         * maint.c (count_symtabs_and_blocks): Remove declaration.
6748         * cp-support.c (add_symbol_overload_list_qualified): Remove
6749         declaration.
6750         * coffread.c (coff_symtab_read): Remove declaration.
6751         * symtab.c (lookup_symbol_in_objfile_symtabs)
6752         (basic_lookup_transparent_type_1): Use objfile_compunits.
6753         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6754         (info_sources_command, search_symbols)
6755         (default_collect_symbol_completion_matches_break_on)
6756         (make_source_files_completion_list): Remove declaration.
6757         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6758         (ada_collect_symbol_completion_matches)
6759         (ada_add_global_exceptions): Remove declaration.
6760         * linespec.c (iterate_over_all_matching_symtabs): Use
6761         objfile_compunits.
6762         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6763         (class objfile_compunits): New.
6764         (ALL_COMPUNITS): Use objfile_compunits.
6765         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6766         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6767         objfile_compunits.
6768         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6769
6770 2019-01-09  Tom Tromey  <tom@tromey.com>
6771
6772         * symtab.c (search_symbols)
6773         (default_collect_symbol_completion_matches_break_on): Use
6774         objfile_msymbols.
6775         * ada-lang.c (ada_lookup_simple_minsym)
6776         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6777         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6778         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6779         objfile_msymbols.
6780         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6781         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6782         * objc-lang.c (find_methods): Use objfile_msymbols.
6783         (info_selectors_command, info_classes_command): Likewise.
6784         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6785         * objfiles.h (class objfile_msymbols): New.
6786         (ALL_OBJFILE_MSYMBOLS): Remove.
6787         (ALL_MSYMBOLS): Remove.
6788
6789 2019-01-09  Tom Tromey  <tom@tromey.com>
6790
6791         * common/next-iterator.h (next_adapter): Add Iterator template
6792         parameter.
6793         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6794         (class all_objfiles_safe): New.
6795         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6796         * objfiles.c (put_objfile_before): Update comment.
6797         (add_separate_debug_objfile): Likewise.
6798         (free_all_objfiles): Use all_objfiles_safe.
6799         (objfile_purge_solibs): Likewise.
6800
6801 2019-01-09  Tom Tromey  <tom@tromey.com>
6802
6803         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6804         (expand_symtab_containing_pc, lookup_static_symbol)
6805         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6806         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6807         all_objfiles.
6808         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6809         * breakpoint.c (create_overlay_event_breakpoint)
6810         (create_longjmp_master_breakpoint)
6811         (create_std_terminate_master_breakpoint)
6812         (create_exception_master_breakpoint): Use all_objfiles.
6813         * linux-thread-db.c (try_thread_db_load_from_pdir)
6814         (has_libpthread): Use all_objfiles.
6815         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6816         * linespec.c (iterate_over_all_matching_symtabs)
6817         (search_minsyms_for_name): Use all_objfiles.
6818         * maint.c (maintenance_info_sections): Use all_objfiles.
6819         * main.c (captured_main_1): Use all_objfiles.
6820         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6821         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6822         * guile/scm-pretty-print.c
6823         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6824         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6825         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6826         (maintenance_print_msymbols): Use all_objfiles.
6827         * source.c (select_source_symtab): Use all_objfiles.
6828         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6829         * symfile.c (remove_symbol_file_command)
6830         (expand_symtabs_matching, map_symbol_filenames): Use
6831         all_objfiles.
6832         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6833         all_objfiles.
6834         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6835         * objc-lang.c (find_methods): Use all_objfiles.
6836         * objfiles.c (have_partial_symbols, have_full_symbols)
6837         (have_minimal_symbols, qsort_cmp)
6838         (default_iterate_over_objfiles_in_search_order): Use
6839         all_objfiles.
6840         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6841         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6842         (maintenance_check_psymtabs): Use all_objfiles.
6843         (ALL_PSYMTABS): Remove.
6844         * compile/compile-object-run.c (do_module_cleanup): Use
6845         all_objfiles.
6846         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6847         * cp-support.c (add_symbol_overload_list_qualified): Use
6848         all_objfiles.
6849         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6850         Use all_objfiles.
6851         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6852         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6853         all_objfiles.
6854         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6855         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6856         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6857         Uses all_objfiles.
6858         * solib.c (solib_read_symbols): Use all_objfiles
6859
6860 2019-01-09  Tom Tromey  <tom@tromey.com>
6861
6862         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6863         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6864         all_objfiles.
6865         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6866         * symmisc.c (print_symbol_bcache_statistics)
6867         (print_objfile_statistics, maintenance_print_objfiles)
6868         (maintenance_info_symtabs, maintenance_check_symtabs)
6869         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6870         all_objfiles.
6871         * source.c (forget_cached_source_info): Use all_objfiles.
6872         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6873         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6874         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6875         * objfiles.c (update_section_map): Use all_objfiles.
6876         (shared_objfile_contains_address_p): Likewise.
6877         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6878         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6879
6880 2019-01-09  Tom Tromey  <tom@tromey.com>
6881
6882         * common/next-iterator.h: New file.
6883         * objfiles.h (class all_objfiles): New.
6884         (struct objfile_iterator): New.
6885
6886 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6887
6888         * NEWS: Move the description of the changed "frame", "select-frame",
6889          and "info frame" commands to the Changed commands section.
6890
6891 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6892
6893         * gdbtypes.c (check_stub_method_group): Remove handling of old
6894         mangling schemes.
6895         * linespec.c (find_methods): Likewise.
6896         * stabsread.c (read_member_functions): Likewise.
6897         * valops.c (search_struct_method): Likewise.
6898         (value_struct_elt_for_reference): Likewise.
6899         * NEWS: Mention this change.
6900
6901 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6902
6903         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6904         print_source_lines.
6905         * source.c (print_source_lines_base): Update line number check.
6906         (print_source_lines): New function.
6907         (source_lines_range::source_lines_range): New function.
6908         * source.h (class source_lines_range): New class.
6909         (print_source_lines): New declaration.
6910
6911 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6912
6913         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6914
6915 2019-01-08  Tom Tromey  <tom@tromey.com>
6916             Simon Marchi  <simon.marchi@ericsson.com>
6917
6918         PR gdb/24060
6919         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6920         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6921         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6922         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6923         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6924         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6925
6926 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * source.c (select_source_symtab): Move header comment to
6929         declaration in source.h.
6930         (forget_cached_source_info_for_objfile): Likewise.
6931         (forget_cached_source_info): Likewise.
6932         (identify_source_line): Likewise.
6933         * source.h (identify_source_line): Move declaration from symtab.h
6934         and add comment from source.c
6935         (print_source_lines): Likewise.
6936         (forget_cached_source_info_for_objfile): Likewise.
6937         (forget_cached_source_info): Likewise.
6938         (select_source_symtab): Likewise.
6939         (enum print_source_lines_flag): Move definition from symtab.h.
6940         * symtab.h (identify_source_line): Move declaration to source.h.
6941         (print_source_lines): Likewise.
6942         (forget_cached_source_info_for_objfile): Likewise.
6943         (forget_cached_source_info): Likewise.
6944         (select_source_symtab): Likewise.
6945         (enum print_source_lines_flag): Move definition to source.h.
6946         * tui/tui-hooks.c: Add 'source.h' include.
6947
6948 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * source.c (print_source_lines_base): Handle requests to print
6951         reverse line number sequences, and guard against empty lines
6952         string.
6953
6954 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6955
6956         * source.c (print_source_lines_base): Fix skip of '\r' if next
6957         character is '\n'.
6958
6959 2019-01-06  Tom Tromey  <tom@tromey.com>
6960
6961         * c-exp.y (struct c_parse_state) <macro_original_text,
6962         expansion_obstack>: New member.
6963         (macro_original_text, expansion_obstack): Remove globals.
6964         (scan_macro_expansion, scanning_macro_expansion)
6965         (finished_macro_expansion): Update.
6966         (scan_macro_cleanup): Remove.
6967         (yylex, c_parse): Update.
6968
6969 2019-01-06  Tom Tromey  <tom@tromey.com>
6970
6971         * c-exp.y (struct c_parse_state) <strings>: New member.
6972         (operator_stoken): Update.
6973
6974 2019-01-06  Tom Tromey  <tom@tromey.com>
6975
6976         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6977         (union type_stack_elt) <typelist_val>: Now a pointer to
6978         std::vector.
6979         (type_stack_cleanup): Don't declare.
6980         (push_typelist): Update.
6981         * parse.c (pop_typelist): Return a std::vector.
6982         (push_typelist): Take a std::vector.
6983         (follow_types): Update.  Do not free args.
6984         (type_stack_cleanup): Remove.
6985         * c-exp.y (struct c_parse_state): New.
6986         (cpstate): New global.
6987         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6988         (nonempty_typelist): Update.
6989         (func_mod): Create a new vector.
6990         (c_parse): Create a c_parse_state.
6991         (check_parameter_typelist): Do not delete params.
6992         (function_method): Update.  Do not delete type_list.
6993
6994 2019-01-06  Tom Tromey  <tom@tromey.com>
6995
6996         PR gdb/28155:
6997         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6998         check_typedef.
6999         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7000         (print_return_value): Likewise.
7001
7002 2019-01-05  Tom Tromey  <tom@tromey.com>
7003
7004         * contrib/cleanup_check.py: Remove.
7005         * contrib/gcc-with-excheck: Remove.
7006         * contrib/exsummary.py: Remove.
7007         * contrib/excheck.py: Remove.
7008
7009 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7010
7011         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7012         NULL. Initialize tpprev to NULL instead of assigning it
7013         to NULL on the next statement.
7014         * windows-nat.c (windows_delete_thread): Remove check for
7015         main_thread_id before printing thread exit notifications.
7016         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7017         Remove thread ID check against main_thread_id.
7018         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7019         windows_delete_thread.
7020         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7021
7022 2019-01-04  Tom Tromey  <tom@tromey.com>
7023
7024         * compile/compile.c (_initialize_compile): Use upper case for
7025         metasyntactic variables.
7026         * symmisc.c (_initialize_symmisc): Use upper case for
7027         metasyntactic variables.
7028         * psymtab.c (_initialize_psymtab): Use upper case for
7029         metasyntactic variables.
7030         * demangle.c (demangle_command): Use upper case for metasyntactic
7031         variables.
7032         (_initialize_demangler): Likewise.
7033         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7034         variables.
7035
7036 2019-01-03  Tom Tromey  <tom@tromey.com>
7037
7038         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7039
7040 2019-01-03  Tom Tromey  <tom@tromey.com>
7041
7042         * python/py-symtab.c (salpy_str): Update.
7043         (struct salpy_sal_object) <symtab>: Now a PyObject.
7044         (salpy_dealloc): Update.
7045         (del_objfile_sal): Use gdbpy_ref.
7046
7047 2019-01-03  Tom Tromey  <tom@tromey.com>
7048
7049         * python/py-type.c (convert_field): Use new_reference.  Return
7050         gdbpy_ref.
7051         (make_fielditem): Return gdbpy_ref.
7052         (typy_fields): Update.
7053         (typy_getitem): Update.
7054         (field_name): Return gdbpy_ref.  Use new_reference.
7055         (typy_iterator_iternext): Update.
7056
7057 2019-01-03  Tom Tromey  <tom@tromey.com>
7058
7059         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7060
7061 2019-01-03  Tom Tromey  <tom@tromey.com>
7062
7063         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7064         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7065         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7066         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7067         (pspy_set_type_printers): Likewise.
7068         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7069         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7070         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7071         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7072         (objfpy_set_type_printers): Likewise.
7073
7074 2019-01-03  Tom Tromey  <tom@tromey.com>
7075
7076         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7077         (gdbpy_print_stack): Use gdbpy_err_fetch.
7078         * python/python-internal.h (class gdbpy_err_fetch): New class.
7079         (class gdbpy_enter) <m_error_type, m_error_value,
7080         m_error_traceback>: Remove.
7081         <m_error>: New member.
7082         (gdbpy_exception_to_string): Don't declare.
7083         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7084         * python/py-value.c (convert_value_from_python): Use
7085         gdbpy_err_fetch.
7086         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7087         gdbpy_exception_to_string.
7088         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7089         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7090         gdbpy_err_fetch.
7091
7092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7093
7094         * linux-nat.c (delete_lwp_cleanup): Delete.
7095         (struct lwp_deleter): New struct.
7096         (lwp_info_up): New typedef.
7097         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7098         lwp_info_up.
7099
7100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * linux-fork.c (class scoped_switch_fork_info): New class.
7103         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7104
7105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * valops.c (find_overload_match): Remove use of null_cleanup, and
7108         calls to do_cleanups.
7109
7110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7111
7112         * compile/compile-cplus-types.c
7113         (compile_cplus_instance::decl_name): Handle changes to
7114         cp_func_name.
7115         * cp-support.c (cp_func_name): Update header comment, update
7116         return type.
7117         * cp-support.h (cp_func_name): Update return type in declaration.
7118         * valops.c (find_overload_match): Move temp_func local to top
7119         level of function and change its type.  Use temp_func to hold and
7120         delete temporary string obtained from cp_func_name.
7121
7122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7123
7124         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7125         gdb::char_vector, remove cleanup, and update uses of `msg`.
7126
7127 2019-01-03  Jim Wilson  <jimw@sifive.com>
7128
7129         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7130
7131 2019-01-02  Tom Tromey  <tom@tromey.com>
7132
7133         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7134         (tdesc_parse_xml): Remove cleanups.
7135         * target-descriptions.h (make_cleanup_free_target_description):
7136         Don't declare.
7137         (target_desc_deleter): New struct.
7138         (target_desc_up): New typedef.
7139         * target-descriptions.c (target_desc_deleter::operator()): Rename
7140         from free_target_description.
7141         (make_cleanup_free_target_description): Remove.
7142
7143 2019-01-02  Tom Tromey  <tom@tromey.com>
7144
7145         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7146         constructor, destructor.
7147         (linespec_parser): Remove typedef.
7148         (~linespec_parser): Rename from linespec_parser_delete.
7149         (linespec_lex_to_end, linespec_complete_label)
7150         (linespec_complete): Update.
7151         (decode_line_full): Remove cleanups.
7152         (decode_line_1): Update.
7153
7154 2019-01-02  Tom Tromey  <tom@tromey.com>
7155
7156         * python/python-internal.h (inferior_to_inferior_object): Change
7157         return type.
7158         * python/py-exitedevent.c (create_exited_event_object): Update.
7159         * python/py-inferior.c (inferior_to_inferior_object): Return
7160         gdbpy_ref.
7161         (python_new_inferior, python_inferior_deleted)
7162         (thread_to_thread_object, delete_thread_object)
7163         (build_inferior_list, gdbpy_selected_inferior): Update.
7164         * python/py-infthread.c (create_thread_object): Update.  Also fail
7165         if inferior_to_inferior_object fails.
7166
7167 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7168
7169         * inferior.h (class inferior) <displaced_step_state>: New field.
7170         * infrun.h (struct displaced_step_state): Move here from
7171         infrun.c.  Initialize fields, add constructor.
7172         <inf>: Remove field.
7173         <reset>: New method.
7174         * infrun.c (struct displaced_step_inferior_state): Move to
7175         infrun.h.
7176         (displaced_step_inferior_states): Remove.
7177         (get_displaced_stepping_state): Adust.
7178         (displaced_step_in_progress_any_inferior): Adjust.
7179         (displaced_step_in_progress_thread): Adjust.
7180         (displaced_step_in_progress): Adjust.
7181         (add_displaced_stepping_state): Remove.
7182         (get_displaced_step_closure_by_addr): Adjust.
7183         (remove_displaced_stepping_state): Remove.
7184         (infrun_inferior_exit): Call displaced_step_state.reset.
7185         (use_displaced_stepping): Don't check for NULL.
7186         (displaced_step_prepare_throw): Call
7187         get_displaced_stepping_state.
7188         (displaced_step_fixup): Don't check for NULL.
7189         (prepare_for_detach): Don't check for NULL.
7190
7191 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7192
7193         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7194          in case of call that did not complete.
7195
7196 2019-01-02  Andrey Utkin  <autkin@undo.io>
7197
7198         * symfile.c (find_separate_debug_file): Fix search of debug files for
7199         remote debuggee.
7200
7201 2019-01-02  Tom Tromey  <tom@tromey.com>
7202
7203         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7204         indentation.
7205         * python/py-frame.c (frapy_older): Remove cast.
7206         (frapy_newer): Likewise.
7207         * python/py-breakpoint.c (local_setattro): Remove cast.
7208         * python/py-arch.c (archpy_name): Remove local variable.
7209         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7210
7211 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7212
7213         * unittests/basic_string_view/element_access/char/empty.cc:
7214         Fix year range in copyright header.
7215
7216 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7219         Delete.
7220         <operator==>: Update with for removed field.
7221         <hash>: Likewise.
7222         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7223         <isa_features>: ...this.
7224         <abi_features>: New field.
7225         (riscv_isa_flen): Update comment.
7226         (riscv_abi_xlen): New declaration.
7227         (riscv_abi_flen): New declaration.
7228         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7229         isa_features.
7230         (riscv_abi_xlen): New function.
7231         (riscv_isa_flen): Update to get answer from isa_features.
7232         (riscv_abi_flen): New function.
7233         (riscv_has_fp_abi): Update to get answer from abi_features.
7234         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7235         xlen and flen.
7236         (riscv_call_info) <xlen, flen>: Update comment.
7237         (riscv_call_arg_struct): Remove invalid assertions
7238         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7239         is removed.
7240         (riscv_gdbarch_init): Gather isa features and abi features
7241         separately, ensure both match on the gdbarch when reusing an old
7242         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7243         a target with 64-bit float hardware.
7244
7245 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7246
7247         * source.c (search_command_helper): Stop reverse search
7248         when line 1 has been searched.
7249
7250 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7251
7252         * record-full.c (record_full_base_target::close): Rewrite
7253         record_full_core_buf_list free logic.
7254
7255 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7256
7257         * break-catch-syscall.c (print_one_catch_syscall): xfree
7258         the last text.
7259
7260 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7261
7262         * top.c (print_gdb_version): Update Copyright year in version
7263         message.
7264
7265 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7266
7267         Update copyright year range in all GDB files.
7268
7269 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7270
7271         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7272
7273 For older changes see ChangeLog-2018.
7274 \f
7275 Local Variables:
7276 mode: change-log
7277 left-margin: 8
7278 fill-column: 74
7279 version-control: never
7280 coding: utf-8
7281 End:
7282