gdb/ChangeLog

   1 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * rust-lang.c (val_print_struct): Handle printing structures
   4         containing strings.
   5
   6 2019-05-02  Tom Tromey  <tromey@adacore.com>
   7
   8         * valarith.c (_initialize_valarith): Remove.
   9
  10 2019-05-01  Tom Tromey  <tromey@adacore.com>
  11
  12         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  13         bitfields.
  14
  15 2019-05-01  Tom Tromey  <tromey@adacore.com>
  16
  17         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  18         for big-endian copies.
  19
  20 2019-04-30  Ali Tamur  <tamur@google.com>
  21         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  22         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  23         (read_3_bytes): New function.
  24
  25 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * windows-nat.c (main_thread_id): Delete.
  28         (handle_output_debug_string): Replace main_thread_id by
  29         current_event.dwThreadId.
  30         (fake_create_process): Likewise.
  31         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  32         Do not set main_thread_id.
  33         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  34         current_event.dwThreadId.
  35         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  36
  37 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  38
  39         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  40         Use current_event.dwThreadId instead of main_thread_id.
  41
  42 2019-04-30  Tom Tromey  <tromey@adacore.com>
  43
  44         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  45         (create_excep_cond_exprs): Iterate over program spaces.
  46         (ada_exception_catchpoint_cond_string): Examine all minimal
  47         symbols for exception types.
  48
  49 2019-04-30  Tom Tromey  <tromey@adacore.com>
  50
  51         PR c++/24470:
  52         * dwarf2read.c (process_structure_scope): Handle case where type
  53         has template parameters but no symbol was created.
  54
  55 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  56             Chris January  <chris.january@arm.com>
  57
  58         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  59         qualifier.
  60         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  61
  62 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * f-typeprint.c (f_print_type): Update rules for printing
  65         whitespace.
  66         (f_type_print_varspec_suffix): Likewise.
  67
  68 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  69             Chris January  <chris.january@arm.com>
  70
  71         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  72         function arguments.
  73
  74 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * f-lang.c (build_fortran_types): Change name of void type to
  77         lower case.
  78         * f-typeprint.c (f_type_print_base): Print the name of the void
  79         type, rather than a fixed string.
  80         * f-valprint.c (f_decorations): Use lower case void string.
  81
  82 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  83             Chris January  <chris.january@arm.com>
  84
  85         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  86         types for Fortran.
  87
  88 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  89             Chris January  <chris.january@arm.com>
  90             David Lecomber  <david.lecomber@arm.com>
  91
  92         * f-exp.y (BINOP_INTRINSIC): New token.
  93         (exp): New parser rule handling BINOP_INTRINSIC.
  94         (f77_keywords): Add new builtin procedures.
  95         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  96         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  97         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  98         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  99         (print_unop_subexp_f): New function.
 100         (print_binop_subexp_f): New function.
 101         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 102         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 103         (dump_subexp_body_f): Likewise.
 104         (operator_check_f): Likewise.
 105         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 106         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 107
 108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 109
 110         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 111         UNOP_KIND.
 112         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 113         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 114         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 115         (operator_length_f): New fuction.
 116         (print_subexp_f): New function.
 117         (op_name_f): New function.
 118         (dump_subexp_body_f): New function.
 119         (operator_check_f): New function.
 120         (exp_descriptor_f): Replace standard expression handling functions
 121         with new functions.
 122         * gdb/fortran-operator.def: New file.
 123         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 124         * gdb/std-operator.def: Remove UNOP_KIND.
 125
 126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 127
 128         * std-operator.def: Remove unbalanced, stray double quote
 129         character.
 130
 131 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 132             Chris January  <chris.january@arm.com>
 133             Daniel Everett  <daniel.everett@arm.com>
 134             Nick Forrington  <nick.forrington@arm.com>
 135             Richard Bunt  <richard.bunt@arm.com>
 136
 137         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 138         of depth when printing anonymous structs or unions.
 139         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 140         Don't print either the top-level value, or the children if the
 141         max-depth is exceeded.
 142         (ppscm_print_children): When printing the key of a map, allow one
 143         extra level of depth.
 144         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 145         print either the top-level value, or the children if the max-depth
 146         is exceeded.
 147         (print_children): When printing the key of a map, allow one extra
 148         level of depth.
 149         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 150         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 151         (user_print_options): Initialise max_depth field.
 152         (val_print_scalar_or_string_type_p): New function.
 153         (val_print): Check to see if the max depth has been reached.
 154         (val_print_check_max_depth): Define new function.
 155         (show_print_max_depth): New function.
 156         (_initialize_valprint): Add 'print max-depth' option.
 157         * valprint.h (struct value_print_options) <max_depth>: New field.
 158         (val_print_check_max_depth): Declare new function.
 159         * NEWS: Document new feature.
 160
 161 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 162
 163         * ada-lang.c (ada_language_defn): Initialise new field.
 164         * c-lang.c (c_is_string_type_p): New function.
 165         (c_language_defn): Initialise new field.
 166         (cplus_language_defn): Initialise new field.
 167         (asm_language_defn): Initialise new field.
 168         (minimal_language_defn): Initialise new field.
 169         * c-lang.h (c_is_string_type_p): Declare new function.
 170         * d-lang.c (d_language_defn): Initialise new field.
 171         * f-lang.c (f_is_string_type_p): New function.
 172         (f_language_defn): Initialise new field.
 173         * go-lang.c (go_is_string_type_p): New function.
 174         (go_language_defn): Initialise new field.
 175         * language.c (default_is_string_type_p): New function.
 176         (unknown_language_defn): Initialise new field.
 177         (auto_language_defn): Initialise new field.
 178         * language.h (struct language_defn) <la_is_string_type_p>: New
 179         member variable.
 180         (default_is_string_type_p): Declare new function.
 181         * m2-lang.c (m2_language_defn): Initialise new field.
 182         * objc-lang.c (objc_language_defn): Initialise new field.
 183         * opencl-lang.c (opencl_language_defn): Initialise new field.
 184         * p-lang.c (pascal_is_string_type_p): New function.
 185         (pascal_language_defn): Initialise new field.
 186         * rust-lang.c (rust_is_string_type_p): New function.
 187         (rust_language_defn): Initialise new field.
 188
 189 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 192         New field.
 193         * ada-lang.c (ada_language_defn): Initialise new field.
 194         * c-lang.c (c_language_defn): Likewise.
 195         (cplus_language_defn): Likewise.
 196         (asm_language_defn): Likewise.
 197         (minimal_language_defn): Likewise.
 198         * d-lang.c (d_language_defn): Likewise.
 199         * f-lang.c (f_language_defn): Likewise.
 200         * go-lang.c (go_language_defn): Likewise.
 201         * language.c (unknown_language_defn): Likewise.
 202         (auto_language_defn): Likewise.
 203         * m2-lang.c (m2_language_defn): Likewise.
 204         * objc-lang.c (objc_language_defn): Likewise.
 205         * opencl-lang.c (opencl_language_defn): Likewise.
 206         * p-lang.c (pascal_language_defn): Likewise.
 207         * rust-lang.c (rust_language_defn): Likewise.
 208
 209 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 210
 211         * ada-lang.c (ada_is_character_type): Change return type to bool.
 212         (ada_is_string_type): Likewise.
 213         * ada-lang.h (ada_is_character_type): Update declaration
 214         (ada_is_string_type): Likewise.
 215
 216 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 217
 218         Support style in 'frame|thread apply'
 219
 220         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 221         * record.c (record_start, record_stop): Update callers of
 222         execute_command_to_string with false.
 223         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 224         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 225         methods.
 226         (class string_file): New constructor with term_out parameter.
 227         Override methods term_out and can_emit_style_escape.  New member
 228         term_out.
 229         (class stdio_file): Override can_emit_style_escape.
 230         (class tee_file): Override term_out and can_emit_style_escape.
 231         * utils.h (can_emit_style_escape): Remove.
 232         * utils.c (can_emit_style_escape): Likewise.
 233         Update all callers of can_emit_style_escape (SOMESTREAM) to
 234         SOMESTREAM->can_emit_style_escape.
 235         * source-cache.c (source_cache::get_source_lines): Likewise.
 236         * stack.c (frame_apply_command_count): Call execute_command_to_string
 237         passing the term_out characteristic of the current gdb_stdout.
 238         * thread.c (thr_try_catch_cmd): Likewise.
 239         * top.c (execute_command_to_string): pass term_out parameter
 240         to construct the string_file for the command output.
 241         * ui-file.c (term_cli_styling): New function (most code moved
 242         from utils.c can_emit_style_escape).
 243         (string_file::string_file, string_file::can_emit_style_escape,
 244         stdio_file::can_emit_style_escape, tee_file::term_out,
 245         tee_file::can_emit_style_escape): New functions.
 246
 247 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 248
 249         * NEWS: Mention the new set|show may-call-functions.
 250         * infcall.c (may_call_functions_p): New variable.
 251         (show_may_call_functions_p): New function.
 252         (call_function_by_hand_dummy): Throws an error if not
 253         may-call-functions.
 254         (_initialize_infcall): Call add_setshow_boolean_cmd for
 255         may-call-functions.
 256
 257 2019-04-25  Keith Seitz  <keiths@redhat.com>
 258
 259         PR c++/24367
 260         * cp-support.c (inspect_type): Don't attempt substitutions
 261         of symbol with the same name.
 262
 263 2019-04-25  Tom Tromey  <tromey@adacore.com>
 264
 265         PR gdb/24475:
 266         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 267         static.
 268
 269 2019-04-25  Tom Tromey  <tromey@adacore.com>
 270
 271         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 272         rvalue reference.
 273         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 274         (gdb_xml_parser::parse): Use std::move.
 275         * python/python-internal.h (gdbpy_convert_exception): Take a const
 276         reference.
 277         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 278         std::move.
 279         * python/py-utils.c (gdbpy_convert_exception): Take a const
 280         reference.
 281         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 282         Use std::move.
 283         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 284         Use std::move.
 285         * mi/mi-main.c (mi_print_exception): Take a const reference.
 286         * main.c (handle_command_errors): Take a const reference.
 287         * linespec.c (parse_linespec): Use std::move.
 288         * infcall.c (run_inferior_call): Use std::move.
 289         (call_function_by_hand_dummy): Use std::move.
 290         * exec.c (try_open_exec_file): Use std::move.
 291         * exceptions.h (exception_print, exception_fprintf)
 292         (exception_print_same): Update.
 293         * exceptions.c (print_exception, exception_print)
 294         (exception_fprintf, exception_print_same): Change parameters to
 295         const reference.
 296         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 297         * common/new-op.c: Use std::move.
 298         * common/common-exceptions.h (struct gdb_exception): Add move
 299         constructor.
 300         (struct gdb_exception_error, struct gdb_exception_quit, struct
 301         gdb_quit_bad_alloc): Change constructor to move constructor.
 302         (throw_exception): Change parameter to rvalue reference.
 303         * common/common-exceptions.c (throw_exception): Take rvalue
 304         reference.
 305         * cli/cli-interp.c (safe_execute_command): Use std::move.
 306         * breakpoint.c (insert_bp_location, location_to_sals): Use
 307         std::move.
 308
 309 2019-04-25  Tom Tromey  <tromey@adacore.com>
 310
 311         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 312         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 313         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 314         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 315         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 316         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 317         guile/scm-value.c: Use unpack.
 318         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 319         gdbscm_gdb_exception.
 320         (gdbscm_throw_gdb_exception): Likewise.
 321         (struct gdbscm_gdb_exception): New.
 322         (unpack): New function.
 323         (gdbscm_wrap): Use unpack.
 324
 325 2019-04-25  Tom Tromey  <tromey@adacore.com>
 326
 327         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 328         (gdb_rl_callback_handler): Use std::move.
 329         * common/common-exceptions.h (struct gdb_exception): Add move
 330         assignment operator.
 331         (throw_exception_sjlj): Change "exception" to const reference.
 332         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 333         (throw_exception_sjlj): Change "exception" to const reference.
 334
 335 2019-04-25  Tom Tromey  <tromey@adacore.com>
 336
 337         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 338         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 339         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 340         Update.
 341         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 342         Update.
 343         * mi/mi-interp.c (mi_interp::exec): Update.
 344         * linespec.c (parse_linespec): Update.
 345         * infcall.c (run_inferior_call): Update.
 346         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 347         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 348         (gdbscm_lookup_global_symbol): Update.
 349         * guile/scm-param.c (gdbscm_parameter_value): Update.
 350         * guile/scm-frame.c (gdbscm_frame_read_register)
 351         (gdbscm_frame_read_var): Update.
 352         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 353         * exec.c (try_open_exec_file): Update.
 354         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 355         (gdb_rl_callback_handler): Update.
 356         * common/common-exceptions.h (exception_none): Don't declare.
 357         * common/common-exceptions.c (exception_none): Don't define.
 358         (struct catcher) <exception>: Update.
 359         * cli/cli-interp.c (safe_execute_command): Update.
 360         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 361
 362 2019-04-25  Ali Tamur  <tamur@google.com>
 363
 364         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 365         (read_attribute_value): Likewise.
 366         (dwarf2_read_addr_index): Update comment.
 367         (read_str_index): Add DW_FORM_strx.
 368         (dwarf2_string_attr): Likewise.
 369         (dwarf2_const_value_attr): Likewise.
 370         (dump_die_shallow): Likewise.
 371         (dwarf2_fetch_constant_bytes): Likewise.
 372         (skip_form_bytes): Likewise.
 373         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 374
 375 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 376
 377         PR corefiles/11608
 378         PR corefiles/18187
 379         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 380         OFFSET.  Verify if current mapping contains an ELF header.
 381         (linux_find_memory_regions_full): Adjust call to
 382         dump_mapping_p.
 383
 384 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 385             Kang Li <kanglictf@gmail.com>
 386
 387         PR gdb/21600
 388
 389         * dwarf2-frame.c (read_initial_length): Be consistent about using
 390         unsigned representation of length.
 391         (decode_frame_entry_1): Likewise.  Check for wraparound of
 392         end pointer as well as buffer overflow.
 393
 394 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 395
 396         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 397         "vq".
 398
 399 2019-04-24  Tom Tromey  <tromey@adacore.com>
 400
 401         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 402
 403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * s12z-tdep.c (s12z_unwind_pc): Delete.
 406         (s12z_unwind_sp): Delete.
 407         (s12z_gdbarch_init): Don't register deleted functions with
 408         gdbarch.
 409
 410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * rl78-tdep.c (rl78_unwind_sp): Delete.
 413         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 414
 415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 418         (xstormy16_unwind_pc): Delete.
 419         (xstormy16_dummy_id): Delete.
 420         (xstormy16_gdbarch_init): Don't register deleted functions with
 421         gdbarch.
 422
 423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * vax-tdep.c (vax_unwind_pc): Delete.
 426         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 427
 428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * v850-tdep.c (v850_unwind_sp): Delete.
 431         (v850_unwind_pc): Delete.
 432         (v850_dummy_id): Delete.
 433         (v850_gdbarch_init): Don't register deleted functions with
 434         gdbarch.
 435
 436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 439         (tilegx_unwind_pc): Delete.
 440         (tilegx_unwind_dummy_id): Delete.
 441         (tilegx_gdbarch_init): Don't register deleted functions with
 442         gdbarch.
 443
 444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 447         (tic6x_dummy_id): Delete.
 448         (tic6x_gdbarch_init): Don't register deleted functions with
 449         gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * sparc-tdep.c (sparc_unwind_pc): Delete.
 454         (sparc32_gdbarch_init): Don't register deleted function with
 455         gdbarch.
 456
 457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * sh-tdep.c (sh_unwind_sp): Delete.
 460         (sh_unwind_pc): Delete.
 461         (sh_dummy_id): Delete.
 462         (sh_gdbarch_init): Don't register deleted functions with
 463         gdbarch.
 464
 465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         * score-tdep.c (score_unwind_sp): Delete.
 468         (score_unwind_pc): Delete.
 469         (score_dummy_id): Delete.
 470         (score_gdbarch_init): Don't register deleted functions with
 471         gdbarch.
 472
 473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 474
 475         * rx-tdep.c (rx_unwind_pc): Delete.
 476         (rx_unwind_sp): Delete.
 477         (rx_dummy_id): Delete.
 478         (rx_gdbarch_init): Don't register deleted functions with
 479         gdbarch.  Update comment.
 480
 481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 484         (rs6000_dummy_id): Delete.
 485         (rs6000_gdbarch_init): Don't register deleted functions with
 486         gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * or1k-tdep.c (or1k_dummy_id): Delete.
 491         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 492
 493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * nios2-tdep.c (nios2_dummy_id): Delete.
 496         (nios2_unwind_sp): Delete.
 497         (nios2_gdbarch_init): Don't register deleted functions with
 498         gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * nds32-tdep.c (nds32_dummy_id): Delete.
 503         (nds32_unwind_pc): Delete.
 504         (nds32_unwind_sp): Delete.
 505         (nds32_gdbarch_init): Don't register deleted functions with
 506         gdbarch.
 507
 508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * msp430-tdep.c (msp430_unwind_pc): Delete.
 511         (msp430_unwind_sp): Delete.
 512         (msp430_dummy_id): Delete.
 513         (msp430_gdbarch_init): Don't register deleted functions with
 514         gdbarch.
 515
 516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * moxie-tdep.c (moxie_unwind_sp): Delete.
 519         (moxie_unwind_pc): Delete.
 520         (moxie_dummy_id): Delete.
 521         (moxie_gdbarch_init): Don't register deleted functions with
 522         gdbarch.
 523
 524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 527         (mn10300_unwind_pc): Delete.
 528         (mn10300_unwind_sp): Delete.
 529         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 530         mn10300_unwind_sp.
 531         (mn10300_frame_unwind_init): Don't register deleted functions with
 532         gdbarch.
 533
 534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 535
 536         * mep-tdep.c (mep_unwind_pc): Delete.
 537         (mep_unwind_sp): Delete.
 538         (mep_dummy_id): Delete.
 539         (mep_gdbarch_init): Don't register deleted functions with
 540         gdbarch.
 541
 542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 545         (m68hc11_unwind_sp): Delete.
 546         (m68hc11_gdbarch_init): Don't register deleted functions with
 547         gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * m32r-tdep.c (m32r_unwind_sp): Delete.
 552         (m32r_unwind_pc): Delete.
 553         (m32r_dummy_id): Delete.
 554         (m32r_gdbarch_init): Don't register deleted functions with
 555         gdbarch.
 556
 557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * m32c-tdep.c (m32c_unwind_pc): Delete.
 560         (m32c_unwind_sp): Delete.
 561         (m32c_dummy_id): Delete.
 562         (m32c_gdbarch_init): Don't register deleted functions with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 568         (lm32_unwind_pc): Delete.
 569         (lm32_dummy_id): Delete.
 570         (lm32_gdbarch_init): Don't register deleted functions with
 571         gdbarch.
 572
 573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 576         (iq2000_unwind_pc): Delete.
 577         (iq2000_dummy_id): Delete.
 578         (iq2000_gdbarch_init): Don't register deleted functions with
 579         gdbarch.
 580
 581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * nds32-tdep.c (nds32_type_align): Delete.
 584         (nds32_push_dummy_call): Use type_align instead.
 585
 586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * arm-tdep.c (arm_type_align): Only handle vector override case.
 589         (arm_push_dummy_call): Use type_align.
 590         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 591
 592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 595         case.
 596         (pass_on_stack): Use type_align.
 597         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 598         function.
 599
 600 2019-04-23  Tom Tromey  <tromey@adacore.com>
 601
 602         * dwarf2read.c (line_header::file_name_at): Remove unused
 603         overload.
 604
 605 2019-04-23  Tom de Vries  <tdevries@suse.de>
 606
 607         PR gdb/24438
 608         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 609         invocation.
 610
 611
 612 2019-03-27  Ali Tamur  <tamur@google.com>
 613
 614         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 615         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 616         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 617         (dwarf_expr_context::get_addr_index): Likewise
 618         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 619         (symbol_needs_eval_context::get_addr_index): Likewise
 620         (disassemble_dwarf_expression): Add DW_OP_addrx
 621         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 622         (read_cutu_die_from_dwo): Update comment
 623         (skip_one_die): Add DW_FORM_addrx
 624         (read_attribute_value): Likewise
 625         (var_decode_location): Add DW_OP_addrx
 626         (dwarf2_const_value_attr): Add DW_FORM_addrx
 627         (dump_die_shallow): Likewise
 628         (dwarf2_fetch_constant_bytes): Likewise
 629         (decode_locdesc): Add DW_OP_addrx
 630         (skip_form_bytes): Add DW_FORM_addrx
 631
 632 2019-04-22  Ali Tamur  <tamur@google.com>
 633
 634         * MAINTAINERS (Write After Approval): Add self.
 635
 636 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 637
 638         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 639         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 640         (open_symbol_file_object): Likewise.
 641         (svr4_default_sos): Add info parameter.
 642         (svr4_read_so_list): Likewise.
 643         (svr4_current_sos_direct): Adjust functions calls to pass down
 644         info.
 645         (svr4_current_sos_1): Add info parameter.
 646         (svr4_current_sos): Call get_svr4_info, pass info down to
 647         svr4_current_sos_1.
 648         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 649         get_svr4_info.
 650         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 651         get_svr4_info.
 652         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 653         to get_svr4_info.
 654         (probes_table_remove_objfile_probes): Likewise.
 655         (register_solib_event_probe): Add info parameter.
 656         (solist_update_incremental): Pass info parameter down to
 657         svr4_read_so_list.
 658         (disable_probes_interface): Add info parameter.
 659         (svr4_handle_solib_event): Pass current_program_space to
 660         get_svr4_info.  Adjust disable_probes_interface cleanup.
 661         (svr4_create_probe_breakpoints): Add info parameter, pass it
 662         down to register_solib_event_probe.
 663         (svr4_create_solib_event_breakpoints): Add info parameter,
 664         pass it down to svr4_create_probe_breakpoints.
 665         (enable_break): Pass info down to
 666         svr4_create_solib_event_breakpoints.
 667         (svr4_solib_create_inferior_hook): Pass current_program_space to
 668         get_svr4_info.
 669         (svr4_clear_solib): Likewise.
 670
 671 2019-04-22  Pedro Alves  <palves@redhat.com>
 672
 673         * solib-svr4.c (svr4_free_objfile_observer): New.
 674         (probe_and_action::objfile): New field.
 675         (probes_table_htab_remove_objfile_probes)
 676         (probes_table_remove_objfile_probes): New functions.
 677         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 678         in the new probe_and_action.  Don't store the probe in 'lookup'.
 679         (svr4_create_probe_breakpoints): Pass objfile to
 680         register_solib_event_probe.
 681         (_initialize_svr4_solib): Register a free_objfile observer.
 682
 683 2019-04-19  Tom Tromey  <tom@tromey.com>
 684
 685         * common/queue.h: Remove.
 686
 687 2019-04-19  Tom Tromey  <tom@tromey.com>
 688
 689         * event-loop.c: Don't include "common/queue.h".
 690
 691 2019-04-19  Tom Tromey  <tom@tromey.com>
 692
 693         * remote.c (remote_target): Use delete.
 694         * remote-notif.h: Include <list>, not "common/queue.h".
 695         (notif_client_p): Remove typedef.
 696         (remote_notif_state): Add constructor, destructor, initializer.
 697         <notif_queue>: Now a std::list.
 698         (remote_notif_state_xfree): Don't declare.
 699         * remote-notif.c (remote_notif_process, handle_notification)
 700         (remote_notif_state_allocate): Update.
 701         (~remote_notif_state): Rename from remote_notif_state_xfree.
 702
 703 2019-04-19  Tom Tromey  <tom@tromey.com>
 704
 705         * symfile.c (reread_symbols): Update.
 706         * objfiles.c (objfile_register_static_link)
 707         (objfile_lookup_static_link): Update
 708         (~objfile) Don't delete static_links.
 709         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 710
 711 2019-04-19  Tom Tromey  <tom@tromey.com>
 712
 713         * type-stack.h (struct type_stack) <insert>: Constify string.
 714         * type-stack.c (type_stack::insert): Constify string.
 715         * gdbtypes.h (lookup_template_type): Update.
 716         (address_space_name_to_int): Update.
 717         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 718         const.
 719         (lookup_template_type): Make name const.
 720         * c-exp.y: Update rules.
 721         (lex_one_token, classify_name, classify_inner_name)
 722         (c_print_token): Update.
 723         * p-exp.y: Update rules.
 724         (yylex): Update.
 725         * f-exp.y: Update rules.
 726         (yylex): Update.
 727         * d-exp.y: Update rules.
 728         (lex_one_token, classify_name, classify_inner_name): Update.
 729         * parse.c (write_dollar_variable, copy_name): Return std::string.
 730         * parser-defs.h (copy_name): Change return type.
 731         * m2-exp.y: Update rules.
 732         (yylex): Update.
 733         * go-exp.y (lex_one_token): Update.
 734         Update rules.
 735         (classify_unsafe_function, classify_packaged_name)
 736         (classify_name, yylex): Update.
 737
 738 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 739
 740         * configure.ac: add --enable-source-highlight switch.
 741         * configure: Regenerate.
 742         * top.c (print_gdb_version): plumb --enable-source-highlight
 743         status to "show configuration".
 744
 745 2019-04-19  Tom Tromey  <tromey@adacore.com>
 746
 747         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 748         Check ADA_TYPE_P.
 749         (empty_record, ada_template_to_fixed_record_type_1)
 750         (template_to_static_fixed_type)
 751         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 752         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 753         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 754         macros.
 755
 756 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 757
 758         PR symtab/24423:
 759         * source.c (print_source_lines_base): Advance "iter" when a
 760         control character is seen.
 761
 762 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 763
 764         * inferior.h (struct infcall_suspend_state_deleter):
 765         Catch exception in destructor to avoid crash.
 766
 767 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 768
 769         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 770         close to the add_com "shell".
 771
 772 2019-04-18  Tom Tromey  <tromey@adacore.com>
 773
 774         * process-stratum-target.h (class process_stratum_target)
 775         <stratum>: Add "final".
 776
 777 2019-04-17  Tom Tromey  <tromey@adacore.com>
 778
 779         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 780         against nullptr before use.
 781
 782 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 783
 784         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 785
 786 2019-04-17  Jim Wilson  <jimw@sifive.com>
 787             Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 790         code read might fail, assume 4-byte breakpoint in that case.
 791
 792 2019-04-15  Leszek Swirski  <leszeks@google.com>
 793
 794         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 795         rather than a hand-rolled POD check when checking for forced MEMORY
 796         classification.
 797
 798 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 801         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 802         function.
 803         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 804         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 805         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 806         declaration.
 807
 808 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 809
 810         * aarch64-linux-nat.c
 811         (aarch64_linux_nat_target::thread_architecture): Add override.
 812         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 813         each VQ.
 814
 815 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 816
 817         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 818
 819 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 822         target types of size 96-bits, add some additional comments, and
 823         check that the builtin type we found was the correct size.
 824
 825 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 826
 827         * utils.c (prompt_for_continue): Don't restore the styling at the
 828         end, as applied_style has the wrong value.  This fixes styling in
 829         long lists of file names that are interrupted by the "Continue?"
 830         prompt.
 831
 832 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 835         * c-lang.c (c_language_defn): Likewise.
 836         (cplus_language_defn): Likewise.
 837         (asm_language_defn): Likewise.
 838         (minimal_language_defn): Likewise.
 839         * d-lang.c (d_language_defn): Likewise.
 840         * f-lang.c (f_language_defn): Likewise.
 841         * go-lang.c (go_language_defn): Likewise.
 842         * language.c (unknown_language_defn): Likewise.
 843         (auto_language_defn): Likewise.
 844         * language.h (struct language_defn): Remove la_magic field.
 845         (LANG_MAGIC): Delete.
 846         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 847         * objc-lang.c (objc_language_defn): Likewise.
 848         * opencl-lang.c (opencl_language_defn): Likewise.
 849         * p-lang.c (pascal_language_defn): Likewise.
 850         * rust-lang.c (rust_language_defn): Likewise.
 851
 852 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * riscv-tdep.c (riscv_type_align): New function.
 855         (riscv_type_alignment): Delete.
 856         (riscv_arg_location): Use 'type_align'.
 857         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 858
 859 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * gdbtypes.c (type_align): A struct with no non-static fields also
 862         has alignment of 1.
 863
 864 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 865
 866         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 867         component to 0.
 868         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 869         member.
 870         (riscv_struct_info::analyse): New implementation using new
 871         analyse_inner member function.
 872         (riscv_struct_info::field_offset): New member function.
 873         (riscv_struct_info::m_offsets): New member variable.
 874         (riscv_struct_info::analyse_inner): New private member function,
 875         takes the old implementation of riscv_struct_info::analyse but
 876         extended to track field offsets.
 877         (riscv_call_arg_struct): Update the struct folding special cases
 878         to handle cases where empty C++ structs, which are non-zero
 879         length, are found.
 880         (riscv_arg_location): Initialise the length of each location, a
 881         non-zero length now indicates the location is in use.
 882         (riscv_push_dummy_call): Allow for the first location having a
 883         non-zero offset when setting up arguments.
 884         (riscv_return_value): Likewise, but for return values.
 885
 886 2019-04-11  Tom Tromey  <tromey@adacore.com>
 887
 888         * utils.c (internal_vproblem): Make "msg" const.
 889
 890 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 893         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 894         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 895         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 896
 897 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 898
 899         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 900         function.
 901         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 902         of amd64_collect_native_gregset.
 903         (amd64_linux_nat_target::store_registers): Likewise.
 904
 905 2019-04-10  Tom Tromey  <tom@tromey.com>
 906
 907         * symtab.c (lookup_global_symbol_from_objfile)
 908         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 909         * objfiles.h (class separate_debug_iterator): New.
 910         (class separate_debug_range): New.
 911         (struct objfile) <separate_debug_objfiles>: New method.
 912         (objfile_separate_debug_iterate): Don't declare.
 913         * objfiles.c (separate_debug_iterator::operator++): Rename from
 914         objfile_separate_debug_iterate.
 915         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 916         iterator.
 917         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 918         iterator.
 919
 920 2019-04-10  Tom Tromey  <tom@tromey.com>
 921
 922         * symfile.c (reread_symbols): Remove old comment.
 923         * objfiles.c (free_all_objfiles): Fix a typo.
 924
 925 2019-04-10  Tom Tromey  <tom@tromey.com>
 926
 927         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 928         * minsyms.c (lookup_minimal_symbol): Use foreach.
 929         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 930         (lookup_minimal_symbol_solib_trampoline): Likewise.
 931         * symfile.c (reread_symbols): Use foreach.
 932
 933 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 934             Tom Tromey  <tromey@adacore.com>
 935
 936         PR rust/24414:
 937         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 938         (rust_lex_int_test): Change "value" to be LONGEST.
 939         (rust_lex_tests): Add test for long integer literal.
 940
 941 2019-04-09  Tom Tromey  <tromey@adacore.com>
 942
 943         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 944         to bool.
 945         (extended_remote_target::attach): Update.
 946         (remote_target::remote_notice_new_inferior): Update.
 947         (remote_target::add_current_inferior_and_thread): Update.
 948         * inferior.c (exit_inferior_1): Use "false".
 949         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 950
 951 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 952
 953         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 954         the "start" command.
 955
 956 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 957
 958         * python/py-inferior.c (infpy_thread_from_thread_handle):
 959         Adjust comments to reflect renaming of thread_from_thread_handle
 960         to thread_from_handle.  Adjust keywords.  Fix type error message.
 961         (inferior_object_methods): Add thread_from_handle.  Retain
 962         thread_from_thread_handle, but mark it as deprecated.
 963
 964 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 965
 966         * gdbthread.h (find_thread_by_handle): Revise declaration.
 967         * thread.c (find_thread_by_handle): Likewise.  Adjust
 968         implementation too.
 969         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 970         support for buffer objects as handles.
 971
 972 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 973
 974         * python/py-infthread.c (thpy_thread_handle): New function.
 975         (thread_object_methods): Register thpy_thread_handle.
 976
 977 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 978
 979         * gdbthread.h (thread_to_thread_handle): Declare.
 980         * thread.c (gdbtypes.h): Include.
 981         (thread_to_thread_handle): New function.
 982
 983         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 984         (target_thread_info_to_thread_handle): Declare.
 985         * target.c (target_thread_info_to_thread_handle): New function.
 986         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 987         * target-delegates.c: Regenerate.
 988
 989         * linux-thread-db.c (class thread_db_target): Add method
 990         thread_info_to_thread_handle.
 991         (thread_db_target::thread_info_to_thread_handle): Define.
 992         * remote.c (class remote_target): Add new method
 993         thread_info_to_thread_handle.
 994         (remote_target::thread_info_to_thread_handle): Define.
 995
 996 2019-04-08  Pedro Alves  <palves@redhat.com>
 997
 998         * common/common-exceptions.c (throw_exception): Don't create
 999         named object to throw; throw directly.
1000         (throw_it): Likewise.  Don't initialize gdb_exception::message
1001         here, with new; pass FMT and AP to the ctor instead.
1002         * common/common-exceptions.h: Include <string>.
1003         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1004         const char *, va_list)): New ctor.  Use std::make_shared.
1005         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1006         errors)): Delete.
1007         (gdb_exception_error::gdb_exception_error(enum errors, const char
1008         *, va_list)): New.
1009         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1010         Add assertion.
1011         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1012         errors)): Delete.
1013         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1014         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1015         Add assertion.
1016
1017 2019-04-08  Tom Tromey  <tom@tromey.com>
1018
1019         * valops.c (value_rtti_indirect_type): Replace throw_exception
1020         with throw.
1021         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1022         with throw.
1023         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1024         throw.
1025         * target.c (target_translate_tls_address): Replace throw_exception
1026         with throw.
1027         * stack.c (frame_apply_command_count): Replace throw_exception
1028         with throw.
1029         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1030         throw.
1031         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1032         with throw.
1033         * rs6000-tdep.c (rs6000_frame_cache)
1034         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1035         * remote.c: Replace throw_exception with throw.
1036         * record-full.c (record_full_message, record_full_wait_1)
1037         (record_full_restore): Replace throw_exception with throw.
1038         * record-btrace.c:
1039         (get_thread_current_frame_id, record_btrace_start_replaying)
1040         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1041         (cmd_record_btrace_start): Replace throw_exception with throw.
1042         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1043         throw.
1044         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1045         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1046         * linespec.c:
1047         (find_linespec_symbols): Replace throw_exception with throw.
1048         * infrun.c (displaced_step_prepare, resume): Replace
1049         throw_exception with throw.
1050         * infcmd.c (post_create_inferior): Replace throw_exception with
1051         throw.
1052         * inf-loop.c (inferior_event_handler): Replace throw_exception
1053         with throw.
1054         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1055         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1056         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1057         (get_prev_frame_always, get_frame_pc_if_available)
1058         (get_frame_address_in_block_if_available, get_frame_language):
1059         Replace throw_exception with throw.
1060         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1061         throw_exception with throw.
1062         * eval.c (fetch_subexp_value, evaluate_var_value)
1063         (evaluate_funcall, evaluate_subexp_standard): Replace
1064         throw_exception with throw.
1065         * dwarf2loc.c (call_site_find_chain)
1066         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1067         Replace throw_exception with throw.
1068         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1069         with throw.
1070         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1071         throw.
1072         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1073         * completer.c (complete_line_internal): Replace throw_exception
1074         with throw.
1075         * compile/compile-object-run.c (compile_object_run): Replace
1076         throw_exception with throw.
1077         * cli/cli-script.c (process_next_line): Replace throw_exception
1078         with throw.
1079         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1080         (btrace_enable, btrace_maint_update_pt_packets): Replace
1081         throw_exception with throw.
1082         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1083         throw_exception with throw.
1084         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1085         throw_exception with throw.
1086         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1087         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1088         * aarch64-tdep.c (aarch64_make_prologue_cache)
1089         (aarch64_make_stub_cache): Replace throw_exception with throw.
1090
1091 2019-04-08  Tom Tromey  <tom@tromey.com>
1092
1093         * common/common-exceptions.c (throw_exception): Rename from
1094         throw_exception_cxx.  Remove old copy.  Make argument const.
1095         (throw_it): Create and throw exception objects directly.
1096         * common/common-exceptions.h (throw_exception): Make argument
1097         const.
1098         (struct gdb_exception_error): Add constructor.
1099         (struct gdb_exception_quit): Add constructor.
1100
1101 2019-04-08  Tom Tromey  <tom@tromey.com>
1102
1103         * common/common-exceptions.h (exception_rethrow): Don't declare.
1104         (TRY_SJLJ): Update comment.
1105         (TRY, CATCH, END_CATCH): Remove.
1106         * common/common-exceptions.c (exception_rethrow): Remove.
1107
1108 2019-04-08  Tom Tromey  <tom@tromey.com>
1109
1110         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1111         Remove.
1112         (gdb_exception_error): Rename from
1113         gdb_exception_RETURN_MASK_ERROR.
1114         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1115         (gdb_quit_bad_alloc): Update.
1116         * aarch64-tdep.c: Update.
1117         * ada-lang.c: Update.
1118         * ada-typeprint.c: Update.
1119         * ada-valprint.c: Update.
1120         * amd64-tdep.c: Update.
1121         * arch-utils.c: Update.
1122         * break-catch-throw.c: Update.
1123         * breakpoint.c: Update.
1124         * btrace.c: Update.
1125         * c-varobj.c: Update.
1126         * cli/cli-cmds.c: Update.
1127         * cli/cli-interp.c: Update.
1128         * cli/cli-script.c: Update.
1129         * common/common-exceptions.c: Update.
1130         * common/new-op.c: Update.
1131         * common/selftest.c: Update.
1132         * compile/compile-c-symbols.c: Update.
1133         * compile/compile-cplus-symbols.c: Update.
1134         * compile/compile-object-load.c: Update.
1135         * compile/compile-object-run.c: Update.
1136         * completer.c: Update.
1137         * corelow.c: Update.
1138         * cp-abi.c: Update.
1139         * cp-support.c: Update.
1140         * cp-valprint.c: Update.
1141         * darwin-nat.c: Update.
1142         * disasm-selftests.c: Update.
1143         * dtrace-probe.c: Update.
1144         * dwarf-index-cache.c: Update.
1145         * dwarf-index-write.c: Update.
1146         * dwarf2-frame-tailcall.c: Update.
1147         * dwarf2-frame.c: Update.
1148         * dwarf2loc.c: Update.
1149         * dwarf2read.c: Update.
1150         * eval.c: Update.
1151         * event-loop.c: Update.
1152         * event-top.c: Update.
1153         * exec.c: Update.
1154         * f-valprint.c: Update.
1155         * fbsd-tdep.c: Update.
1156         * frame-unwind.c: Update.
1157         * frame.c: Update.
1158         * gdbtypes.c: Update.
1159         * gnu-v3-abi.c: Update.
1160         * guile/guile-internal.h: Update.
1161         * guile/scm-block.c: Update.
1162         * guile/scm-breakpoint.c: Update.
1163         * guile/scm-cmd.c: Update.
1164         * guile/scm-disasm.c: Update.
1165         * guile/scm-frame.c: Update.
1166         * guile/scm-lazy-string.c: Update.
1167         * guile/scm-math.c: Update.
1168         * guile/scm-param.c: Update.
1169         * guile/scm-ports.c: Update.
1170         * guile/scm-pretty-print.c: Update.
1171         * guile/scm-symbol.c: Update.
1172         * guile/scm-symtab.c: Update.
1173         * guile/scm-type.c: Update.
1174         * guile/scm-value.c: Update.
1175         * i386-linux-tdep.c: Update.
1176         * i386-tdep.c: Update.
1177         * inf-loop.c: Update.
1178         * infcall.c: Update.
1179         * infcmd.c: Update.
1180         * infrun.c: Update.
1181         * jit.c: Update.
1182         * language.c: Update.
1183         * linespec.c: Update.
1184         * linux-fork.c: Update.
1185         * linux-nat.c: Update.
1186         * linux-tdep.c: Update.
1187         * linux-thread-db.c: Update.
1188         * main.c: Update.
1189         * mi/mi-cmd-break.c: Update.
1190         * mi/mi-cmd-stack.c: Update.
1191         * mi/mi-interp.c: Update.
1192         * mi/mi-main.c: Update.
1193         * objc-lang.c: Update.
1194         * p-valprint.c: Update.
1195         * parse.c: Update.
1196         * ppc-linux-tdep.c: Update.
1197         * printcmd.c: Update.
1198         * python/py-arch.c: Update.
1199         * python/py-breakpoint.c: Update.
1200         * python/py-cmd.c: Update.
1201         * python/py-finishbreakpoint.c: Update.
1202         * python/py-frame.c: Update.
1203         * python/py-framefilter.c: Update.
1204         * python/py-gdb-readline.c: Update.
1205         * python/py-inferior.c: Update.
1206         * python/py-infthread.c: Update.
1207         * python/py-lazy-string.c: Update.
1208         * python/py-linetable.c: Update.
1209         * python/py-objfile.c: Update.
1210         * python/py-param.c: Update.
1211         * python/py-prettyprint.c: Update.
1212         * python/py-progspace.c: Update.
1213         * python/py-record-btrace.c: Update.
1214         * python/py-record.c: Update.
1215         * python/py-symbol.c: Update.
1216         * python/py-type.c: Update.
1217         * python/py-unwind.c: Update.
1218         * python/py-utils.c: Update.
1219         * python/py-value.c: Update.
1220         * python/python.c: Update.
1221         * record-btrace.c: Update.
1222         * record-full.c: Update.
1223         * remote-fileio.c: Update.
1224         * remote.c: Update.
1225         * riscv-tdep.c: Update.
1226         * rs6000-aix-tdep.c: Update.
1227         * rs6000-tdep.c: Update.
1228         * rust-exp.y: Update.
1229         * rust-lang.c: Update.
1230         * s390-tdep.c: Update.
1231         * selftest-arch.c: Update.
1232         * solib-dsbt.c: Update.
1233         * solib-frv.c: Update.
1234         * solib-spu.c: Update.
1235         * solib-svr4.c: Update.
1236         * solib.c: Update.
1237         * sparc64-linux-tdep.c: Update.
1238         * stack.c: Update.
1239         * symfile-mem.c: Update.
1240         * symmisc.c: Update.
1241         * target.c: Update.
1242         * thread.c: Update.
1243         * top.c: Update.
1244         * tracefile-tfile.c: Update.
1245         * tui/tui.c: Update.
1246         * typeprint.c: Update.
1247         * unittests/cli-utils-selftests.c: Update.
1248         * unittests/parse-connection-spec-selftests.c: Update.
1249         * valops.c: Update.
1250         * valprint.c: Update.
1251         * value.c: Update.
1252         * varobj.c: Update.
1253         * windows-nat.c: Update.
1254         * x86-linux-nat.c: Update.
1255         * xml-support.c: Update.
1256
1257 2019-04-08  Tom Tromey  <tom@tromey.com>
1258
1259         * xml-support.c: Use C++ exception handling.
1260         * x86-linux-nat.c: Use C++ exception handling.
1261         * windows-nat.c: Use C++ exception handling.
1262         * varobj.c: Use C++ exception handling.
1263         * value.c: Use C++ exception handling.
1264         * valprint.c: Use C++ exception handling.
1265         * valops.c: Use C++ exception handling.
1266         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1267         handling.
1268         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1269         * typeprint.c: Use C++ exception handling.
1270         * tui/tui.c: Use C++ exception handling.
1271         * tracefile-tfile.c: Use C++ exception handling.
1272         * top.c: Use C++ exception handling.
1273         * thread.c: Use C++ exception handling.
1274         * target.c: Use C++ exception handling.
1275         * symmisc.c: Use C++ exception handling.
1276         * symfile-mem.c: Use C++ exception handling.
1277         * stack.c: Use C++ exception handling.
1278         * sparc64-linux-tdep.c: Use C++ exception handling.
1279         * solib.c: Use C++ exception handling.
1280         * solib-svr4.c: Use C++ exception handling.
1281         * solib-spu.c: Use C++ exception handling.
1282         * solib-frv.c: Use C++ exception handling.
1283         * solib-dsbt.c: Use C++ exception handling.
1284         * selftest-arch.c: Use C++ exception handling.
1285         * s390-tdep.c: Use C++ exception handling.
1286         * rust-lang.c: Use C++ exception handling.
1287         * rust-exp.y: Use C++ exception handling.
1288         * rs6000-tdep.c: Use C++ exception handling.
1289         * rs6000-aix-tdep.c: Use C++ exception handling.
1290         * riscv-tdep.c: Use C++ exception handling.
1291         * remote.c: Use C++ exception handling.
1292         * remote-fileio.c: Use C++ exception handling.
1293         * record-full.c: Use C++ exception handling.
1294         * record-btrace.c: Use C++ exception handling.
1295         * python/python.c: Use C++ exception handling.
1296         * python/py-value.c: Use C++ exception handling.
1297         * python/py-utils.c: Use C++ exception handling.
1298         * python/py-unwind.c: Use C++ exception handling.
1299         * python/py-type.c: Use C++ exception handling.
1300         * python/py-symbol.c: Use C++ exception handling.
1301         * python/py-record.c: Use C++ exception handling.
1302         * python/py-record-btrace.c: Use C++ exception handling.
1303         * python/py-progspace.c: Use C++ exception handling.
1304         * python/py-prettyprint.c: Use C++ exception handling.
1305         * python/py-param.c: Use C++ exception handling.
1306         * python/py-objfile.c: Use C++ exception handling.
1307         * python/py-linetable.c: Use C++ exception handling.
1308         * python/py-lazy-string.c: Use C++ exception handling.
1309         * python/py-infthread.c: Use C++ exception handling.
1310         * python/py-inferior.c: Use C++ exception handling.
1311         * python/py-gdb-readline.c: Use C++ exception handling.
1312         * python/py-framefilter.c: Use C++ exception handling.
1313         * python/py-frame.c: Use C++ exception handling.
1314         * python/py-finishbreakpoint.c: Use C++ exception handling.
1315         * python/py-cmd.c: Use C++ exception handling.
1316         * python/py-breakpoint.c: Use C++ exception handling.
1317         * python/py-arch.c: Use C++ exception handling.
1318         * printcmd.c: Use C++ exception handling.
1319         * ppc-linux-tdep.c: Use C++ exception handling.
1320         * parse.c: Use C++ exception handling.
1321         * p-valprint.c: Use C++ exception handling.
1322         * objc-lang.c: Use C++ exception handling.
1323         * mi/mi-main.c: Use C++ exception handling.
1324         * mi/mi-interp.c: Use C++ exception handling.
1325         * mi/mi-cmd-stack.c: Use C++ exception handling.
1326         * mi/mi-cmd-break.c: Use C++ exception handling.
1327         * main.c: Use C++ exception handling.
1328         * linux-thread-db.c: Use C++ exception handling.
1329         * linux-tdep.c: Use C++ exception handling.
1330         * linux-nat.c: Use C++ exception handling.
1331         * linux-fork.c: Use C++ exception handling.
1332         * linespec.c: Use C++ exception handling.
1333         * language.c: Use C++ exception handling.
1334         * jit.c: Use C++ exception handling.
1335         * infrun.c: Use C++ exception handling.
1336         * infcmd.c: Use C++ exception handling.
1337         * infcall.c: Use C++ exception handling.
1338         * inf-loop.c: Use C++ exception handling.
1339         * i386-tdep.c: Use C++ exception handling.
1340         * i386-linux-tdep.c: Use C++ exception handling.
1341         * guile/scm-value.c: Use C++ exception handling.
1342         * guile/scm-type.c: Use C++ exception handling.
1343         * guile/scm-symtab.c: Use C++ exception handling.
1344         * guile/scm-symbol.c: Use C++ exception handling.
1345         * guile/scm-pretty-print.c: Use C++ exception handling.
1346         * guile/scm-ports.c: Use C++ exception handling.
1347         * guile/scm-param.c: Use C++ exception handling.
1348         * guile/scm-math.c: Use C++ exception handling.
1349         * guile/scm-lazy-string.c: Use C++ exception handling.
1350         * guile/scm-frame.c: Use C++ exception handling.
1351         * guile/scm-disasm.c: Use C++ exception handling.
1352         * guile/scm-cmd.c: Use C++ exception handling.
1353         * guile/scm-breakpoint.c: Use C++ exception handling.
1354         * guile/scm-block.c: Use C++ exception handling.
1355         * guile/guile-internal.h: Use C++ exception handling.
1356         * gnu-v3-abi.c: Use C++ exception handling.
1357         * gdbtypes.c: Use C++ exception handling.
1358         * frame.c: Use C++ exception handling.
1359         * frame-unwind.c: Use C++ exception handling.
1360         * fbsd-tdep.c: Use C++ exception handling.
1361         * f-valprint.c: Use C++ exception handling.
1362         * exec.c: Use C++ exception handling.
1363         * event-top.c: Use C++ exception handling.
1364         * event-loop.c: Use C++ exception handling.
1365         * eval.c: Use C++ exception handling.
1366         * dwarf2read.c: Use C++ exception handling.
1367         * dwarf2loc.c: Use C++ exception handling.
1368         * dwarf2-frame.c: Use C++ exception handling.
1369         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1370         * dwarf-index-write.c: Use C++ exception handling.
1371         * dwarf-index-cache.c: Use C++ exception handling.
1372         * dtrace-probe.c: Use C++ exception handling.
1373         * disasm-selftests.c: Use C++ exception handling.
1374         * darwin-nat.c: Use C++ exception handling.
1375         * cp-valprint.c: Use C++ exception handling.
1376         * cp-support.c: Use C++ exception handling.
1377         * cp-abi.c: Use C++ exception handling.
1378         * corelow.c: Use C++ exception handling.
1379         * completer.c: Use C++ exception handling.
1380         * compile/compile-object-run.c: Use C++ exception handling.
1381         * compile/compile-object-load.c: Use C++ exception handling.
1382         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1383         * compile/compile-c-symbols.c: Use C++ exception handling.
1384         * common/selftest.c: Use C++ exception handling.
1385         * common/new-op.c: Use C++ exception handling.
1386         * cli/cli-script.c: Use C++ exception handling.
1387         * cli/cli-interp.c: Use C++ exception handling.
1388         * cli/cli-cmds.c: Use C++ exception handling.
1389         * c-varobj.c: Use C++ exception handling.
1390         * btrace.c: Use C++ exception handling.
1391         * breakpoint.c: Use C++ exception handling.
1392         * break-catch-throw.c: Use C++ exception handling.
1393         * arch-utils.c: Use C++ exception handling.
1394         * amd64-tdep.c: Use C++ exception handling.
1395         * ada-valprint.c: Use C++ exception handling.
1396         * ada-typeprint.c: Use C++ exception handling.
1397         * ada-lang.c: Use C++ exception handling.
1398         * aarch64-tdep.c: Use C++ exception handling.
1399
1400 2019-04-08  Tom Tromey  <tom@tromey.com>
1401
1402         * xml-support.c (gdb_xml_parser::parse): Update.
1403         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1404         * value.c (show_convenience): Update.
1405         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1406         (test_parse_flags_qcs): Update.
1407         * thread.c (thr_try_catch_cmd): Update.
1408         * target.c (target_translate_tls_address): Update.
1409         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1410         (info_frame_command_core, frame_apply_command_count): Update.
1411         * rust-exp.y (rust_lex_exception_test): Update.
1412         * riscv-tdep.c (riscv_print_one_register_info): Update.
1413         * remote.c (remote_target::enable_btrace): Update.
1414         * record-btrace.c (record_btrace_enable_warn): Update.
1415         * python/py-utils.c (gdbpy_convert_exception): Update.
1416         * printcmd.c (do_one_display, print_variable_and_value): Update.
1417         * mi/mi-main.c (mi_print_exception): Update.
1418         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1419         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1420         * linux-nat.c (linux_nat_target::attach): Update.
1421         * linux-fork.c (class scoped_switch_fork_info): Update.
1422         * infrun.c (displaced_step_prepare): Update.
1423         * infcall.c (call_function_by_hand_dummy): Update.
1424         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1425         * gnu-v3-abi.c (print_one_vtable): Update.
1426         * frame.c (get_prev_frame_always): Update.
1427         * f-valprint.c (info_common_command_for_block): Update.
1428         * exec.c (try_open_exec_file): Update.
1429         * exceptions.c (print_exception, exception_print)
1430         (exception_fprintf, exception_print_same): Update.
1431         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1432         * dwarf-index-cache.c (index_cache::store)
1433         (index_cache::lookup_gdb_index): Update.
1434         * darwin-nat.c (maybe_cache_shell): Update.
1435         * cp-valprint.c (cp_print_value_fields): Update.
1436         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1437         (gcc_cplus_symbol_address): Update.
1438         * compile/compile-c-symbols.c (gcc_convert_symbol)
1439         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1440         * common/selftest.c: Update.
1441         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1442         a std::string.
1443         (exception_try_scope_entry, exception_try_scope_exit): Don't
1444         declare.
1445         (struct exception_try_scope): Remove.
1446         (TRY): Don't use exception_try_scope.
1447         (struct gdb_exception): Add constructor, operator=.
1448         <what>: New method.
1449         (struct gdb_exception_RETURN_MASK_ALL)
1450         (struct gdb_exception_RETURN_MASK_ERROR)
1451         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1452         (struct gdb_quit_bad_alloc): Update.
1453         * common/common-exceptions.c (exception_none): Change
1454         initializer.
1455         (struct catcher) <state, exception>: Initialize inline.
1456         <prev>: Remove member.
1457         (current_catcher): Remove.
1458         (catchers): New global.
1459         (exceptions_state_mc_init): Simplify.
1460         (catcher_pop): Remove.
1461         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1462         (try_scope_depth, exception_try_scope_entry)
1463         (exception_try_scope_exit): Remove.
1464         (throw_exception_sjlj): Update.
1465         (exception_messages, exception_messages_size): Remove.
1466         (throw_it): Simplify.
1467         (gdb_exception_sliced_copy): Remove.
1468         (throw_exception_cxx): Update.
1469         * cli/cli-script.c (script_from_file): Update.
1470         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1471         Update.
1472         * ada-valprint.c (ada_val_print): Update.
1473         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1474         (create_excep_cond_exprs): Update.
1475
1476 2019-04-08  Tom Tromey  <tom@tromey.com>
1477
1478         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1479         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1480         (TRY, CATCH, END_CATCH): Remove some definitions.
1481         * common/common-exceptions.c: Don't use GDB_XCPT.
1482         (catcher_list_size): Remove.
1483         (throw_exception, throw_it): Simplify.
1484
1485 2019-04-05  Tom Tromey  <tom@tromey.com>
1486
1487         Revert the header-sorting patch.
1488         * ft32-tdep.c: Revert.
1489         * frv-tdep.c: Revert.
1490         * frv-linux-tdep.c: Revert.
1491         * frame.c: Revert.
1492         * frame-unwind.c: Revert.
1493         * frame-base.c: Revert.
1494         * fork-child.c: Revert.
1495         * findvar.c: Revert.
1496         * findcmd.c: Revert.
1497         * filesystem.c: Revert.
1498         * filename-seen-cache.h: Revert.
1499         * filename-seen-cache.c: Revert.
1500         * fbsd-tdep.c: Revert.
1501         * fbsd-nat.h: Revert.
1502         * fbsd-nat.c: Revert.
1503         * f-valprint.c: Revert.
1504         * f-typeprint.c: Revert.
1505         * f-lang.c: Revert.
1506         * extension.h: Revert.
1507         * extension.c: Revert.
1508         * extension-priv.h: Revert.
1509         * expprint.c: Revert.
1510         * exec.h: Revert.
1511         * exec.c: Revert.
1512         * exceptions.c: Revert.
1513         * event-top.c: Revert.
1514         * event-loop.c: Revert.
1515         * eval.c: Revert.
1516         * elfread.c: Revert.
1517         * dwarf2read.h: Revert.
1518         * dwarf2read.c: Revert.
1519         * dwarf2loc.c: Revert.
1520         * dwarf2expr.h: Revert.
1521         * dwarf2expr.c: Revert.
1522         * dwarf2-frame.c: Revert.
1523         * dwarf2-frame-tailcall.c: Revert.
1524         * dwarf-index-write.h: Revert.
1525         * dwarf-index-write.c: Revert.
1526         * dwarf-index-common.c: Revert.
1527         * dwarf-index-cache.h: Revert.
1528         * dwarf-index-cache.c: Revert.
1529         * dummy-frame.c: Revert.
1530         * dtrace-probe.c: Revert.
1531         * disasm.h: Revert.
1532         * disasm.c: Revert.
1533         * disasm-selftests.c: Revert.
1534         * dictionary.c: Revert.
1535         * dicos-tdep.c: Revert.
1536         * demangle.c: Revert.
1537         * dcache.h: Revert.
1538         * dcache.c: Revert.
1539         * darwin-nat.h: Revert.
1540         * darwin-nat.c: Revert.
1541         * darwin-nat-info.c: Revert.
1542         * d-valprint.c: Revert.
1543         * d-namespace.c: Revert.
1544         * d-lang.c: Revert.
1545         * ctf.c: Revert.
1546         * csky-tdep.c: Revert.
1547         * csky-linux-tdep.c: Revert.
1548         * cris-tdep.c: Revert.
1549         * cris-linux-tdep.c: Revert.
1550         * cp-valprint.c: Revert.
1551         * cp-support.c: Revert.
1552         * cp-namespace.c: Revert.
1553         * cp-abi.c: Revert.
1554         * corelow.c: Revert.
1555         * corefile.c: Revert.
1556         * continuations.c: Revert.
1557         * completer.h: Revert.
1558         * completer.c: Revert.
1559         * complaints.c: Revert.
1560         * coffread.c: Revert.
1561         * coff-pe-read.c: Revert.
1562         * cli-out.h: Revert.
1563         * cli-out.c: Revert.
1564         * charset.c: Revert.
1565         * c-varobj.c: Revert.
1566         * c-valprint.c: Revert.
1567         * c-typeprint.c: Revert.
1568         * c-lang.c: Revert.
1569         * buildsym.c: Revert.
1570         * buildsym-legacy.c: Revert.
1571         * build-id.h: Revert.
1572         * build-id.c: Revert.
1573         * btrace.c: Revert.
1574         * bsd-uthread.c: Revert.
1575         * breakpoint.h: Revert.
1576         * breakpoint.c: Revert.
1577         * break-catch-throw.c: Revert.
1578         * break-catch-syscall.c: Revert.
1579         * break-catch-sig.c: Revert.
1580         * blockframe.c: Revert.
1581         * block.c: Revert.
1582         * bfin-tdep.c: Revert.
1583         * bfin-linux-tdep.c: Revert.
1584         * bfd-target.c: Revert.
1585         * bcache.c: Revert.
1586         * ax-general.c: Revert.
1587         * ax-gdb.h: Revert.
1588         * ax-gdb.c: Revert.
1589         * avr-tdep.c: Revert.
1590         * auxv.c: Revert.
1591         * auto-load.c: Revert.
1592         * arm-wince-tdep.c: Revert.
1593         * arm-tdep.c: Revert.
1594         * arm-symbian-tdep.c: Revert.
1595         * arm-pikeos-tdep.c: Revert.
1596         * arm-obsd-tdep.c: Revert.
1597         * arm-nbsd-tdep.c: Revert.
1598         * arm-nbsd-nat.c: Revert.
1599         * arm-linux-tdep.c: Revert.
1600         * arm-linux-nat.c: Revert.
1601         * arm-fbsd-tdep.c: Revert.
1602         * arm-fbsd-nat.c: Revert.
1603         * arm-bsd-tdep.c: Revert.
1604         * arch-utils.c: Revert.
1605         * arc-tdep.c: Revert.
1606         * arc-newlib-tdep.c: Revert.
1607         * annotate.h: Revert.
1608         * annotate.c: Revert.
1609         * amd64-windows-tdep.c: Revert.
1610         * amd64-windows-nat.c: Revert.
1611         * amd64-tdep.c: Revert.
1612         * amd64-sol2-tdep.c: Revert.
1613         * amd64-obsd-tdep.c: Revert.
1614         * amd64-obsd-nat.c: Revert.
1615         * amd64-nbsd-tdep.c: Revert.
1616         * amd64-nbsd-nat.c: Revert.
1617         * amd64-nat.c: Revert.
1618         * amd64-linux-tdep.c: Revert.
1619         * amd64-linux-nat.c: Revert.
1620         * amd64-fbsd-tdep.c: Revert.
1621         * amd64-fbsd-nat.c: Revert.
1622         * amd64-dicos-tdep.c: Revert.
1623         * amd64-darwin-tdep.c: Revert.
1624         * amd64-bsd-nat.c: Revert.
1625         * alpha-tdep.c: Revert.
1626         * alpha-obsd-tdep.c: Revert.
1627         * alpha-nbsd-tdep.c: Revert.
1628         * alpha-mdebug-tdep.c: Revert.
1629         * alpha-linux-tdep.c: Revert.
1630         * alpha-linux-nat.c: Revert.
1631         * alpha-bsd-tdep.c: Revert.
1632         * alpha-bsd-nat.c: Revert.
1633         * aix-thread.c: Revert.
1634         * agent.c: Revert.
1635         * addrmap.c: Revert.
1636         * ada-varobj.c: Revert.
1637         * ada-valprint.c: Revert.
1638         * ada-typeprint.c: Revert.
1639         * ada-tasks.c: Revert.
1640         * ada-lang.c: Revert.
1641         * aarch64-tdep.c: Revert.
1642         * aarch64-ravenscar-thread.c: Revert.
1643         * aarch64-newlib-tdep.c: Revert.
1644         * aarch64-linux-tdep.c: Revert.
1645         * aarch64-linux-nat.c: Revert.
1646         * aarch64-fbsd-tdep.c: Revert.
1647         * aarch64-fbsd-nat.c: Revert.
1648         * aarch32-linux-nat.c: Revert.
1649
1650 2019-04-05  Tom Tromey  <tom@tromey.com>
1651
1652         * ft32-tdep.c: Sort headers.
1653         * frv-tdep.c: Sort headers.
1654         * frv-linux-tdep.c: Sort headers.
1655         * frame.c: Sort headers.
1656         * frame-unwind.c: Sort headers.
1657         * frame-base.c: Sort headers.
1658         * fork-child.c: Sort headers.
1659         * findvar.c: Sort headers.
1660         * findcmd.c: Sort headers.
1661         * filesystem.c: Sort headers.
1662         * filename-seen-cache.h: Sort headers.
1663         * filename-seen-cache.c: Sort headers.
1664         * fbsd-tdep.c: Sort headers.
1665         * fbsd-nat.h: Sort headers.
1666         * fbsd-nat.c: Sort headers.
1667         * f-valprint.c: Sort headers.
1668         * f-typeprint.c: Sort headers.
1669         * f-lang.c: Sort headers.
1670         * extension.h: Sort headers.
1671         * extension.c: Sort headers.
1672         * extension-priv.h: Sort headers.
1673         * expprint.c: Sort headers.
1674         * exec.h: Sort headers.
1675         * exec.c: Sort headers.
1676         * exceptions.c: Sort headers.
1677         * event-top.c: Sort headers.
1678         * event-loop.c: Sort headers.
1679         * eval.c: Sort headers.
1680         * elfread.c: Sort headers.
1681         * dwarf2read.h: Sort headers.
1682         * dwarf2read.c: Sort headers.
1683         * dwarf2loc.c: Sort headers.
1684         * dwarf2expr.h: Sort headers.
1685         * dwarf2expr.c: Sort headers.
1686         * dwarf2-frame.c: Sort headers.
1687         * dwarf2-frame-tailcall.c: Sort headers.
1688         * dwarf-index-write.h: Sort headers.
1689         * dwarf-index-write.c: Sort headers.
1690         * dwarf-index-common.c: Sort headers.
1691         * dwarf-index-cache.h: Sort headers.
1692         * dwarf-index-cache.c: Sort headers.
1693         * dummy-frame.c: Sort headers.
1694         * dtrace-probe.c: Sort headers.
1695         * disasm.h: Sort headers.
1696         * disasm.c: Sort headers.
1697         * disasm-selftests.c: Sort headers.
1698         * dictionary.c: Sort headers.
1699         * dicos-tdep.c: Sort headers.
1700         * demangle.c: Sort headers.
1701         * dcache.h: Sort headers.
1702         * dcache.c: Sort headers.
1703         * darwin-nat.h: Sort headers.
1704         * darwin-nat.c: Sort headers.
1705         * darwin-nat-info.c: Sort headers.
1706         * d-valprint.c: Sort headers.
1707         * d-namespace.c: Sort headers.
1708         * d-lang.c: Sort headers.
1709         * ctf.c: Sort headers.
1710         * csky-tdep.c: Sort headers.
1711         * csky-linux-tdep.c: Sort headers.
1712         * cris-tdep.c: Sort headers.
1713         * cris-linux-tdep.c: Sort headers.
1714         * cp-valprint.c: Sort headers.
1715         * cp-support.c: Sort headers.
1716         * cp-namespace.c: Sort headers.
1717         * cp-abi.c: Sort headers.
1718         * corelow.c: Sort headers.
1719         * corefile.c: Sort headers.
1720         * continuations.c: Sort headers.
1721         * completer.h: Sort headers.
1722         * completer.c: Sort headers.
1723         * complaints.c: Sort headers.
1724         * coffread.c: Sort headers.
1725         * coff-pe-read.c: Sort headers.
1726         * cli-out.h: Sort headers.
1727         * cli-out.c: Sort headers.
1728         * charset.c: Sort headers.
1729         * c-varobj.c: Sort headers.
1730         * c-valprint.c: Sort headers.
1731         * c-typeprint.c: Sort headers.
1732         * c-lang.c: Sort headers.
1733         * buildsym.c: Sort headers.
1734         * buildsym-legacy.c: Sort headers.
1735         * build-id.h: Sort headers.
1736         * build-id.c: Sort headers.
1737         * btrace.c: Sort headers.
1738         * bsd-uthread.c: Sort headers.
1739         * breakpoint.h: Sort headers.
1740         * breakpoint.c: Sort headers.
1741         * break-catch-throw.c: Sort headers.
1742         * break-catch-syscall.c: Sort headers.
1743         * break-catch-sig.c: Sort headers.
1744         * blockframe.c: Sort headers.
1745         * block.c: Sort headers.
1746         * bfin-tdep.c: Sort headers.
1747         * bfin-linux-tdep.c: Sort headers.
1748         * bfd-target.c: Sort headers.
1749         * bcache.c: Sort headers.
1750         * ax-general.c: Sort headers.
1751         * ax-gdb.h: Sort headers.
1752         * ax-gdb.c: Sort headers.
1753         * avr-tdep.c: Sort headers.
1754         * auxv.c: Sort headers.
1755         * auto-load.c: Sort headers.
1756         * arm-wince-tdep.c: Sort headers.
1757         * arm-tdep.c: Sort headers.
1758         * arm-symbian-tdep.c: Sort headers.
1759         * arm-pikeos-tdep.c: Sort headers.
1760         * arm-obsd-tdep.c: Sort headers.
1761         * arm-nbsd-tdep.c: Sort headers.
1762         * arm-nbsd-nat.c: Sort headers.
1763         * arm-linux-tdep.c: Sort headers.
1764         * arm-linux-nat.c: Sort headers.
1765         * arm-fbsd-tdep.c: Sort headers.
1766         * arm-fbsd-nat.c: Sort headers.
1767         * arm-bsd-tdep.c: Sort headers.
1768         * arch-utils.c: Sort headers.
1769         * arc-tdep.c: Sort headers.
1770         * arc-newlib-tdep.c: Sort headers.
1771         * annotate.h: Sort headers.
1772         * annotate.c: Sort headers.
1773         * amd64-windows-tdep.c: Sort headers.
1774         * amd64-windows-nat.c: Sort headers.
1775         * amd64-tdep.c: Sort headers.
1776         * amd64-sol2-tdep.c: Sort headers.
1777         * amd64-obsd-tdep.c: Sort headers.
1778         * amd64-obsd-nat.c: Sort headers.
1779         * amd64-nbsd-tdep.c: Sort headers.
1780         * amd64-nbsd-nat.c: Sort headers.
1781         * amd64-nat.c: Sort headers.
1782         * amd64-linux-tdep.c: Sort headers.
1783         * amd64-linux-nat.c: Sort headers.
1784         * amd64-fbsd-tdep.c: Sort headers.
1785         * amd64-fbsd-nat.c: Sort headers.
1786         * amd64-dicos-tdep.c: Sort headers.
1787         * amd64-darwin-tdep.c: Sort headers.
1788         * amd64-bsd-nat.c: Sort headers.
1789         * alpha-tdep.c: Sort headers.
1790         * alpha-obsd-tdep.c: Sort headers.
1791         * alpha-nbsd-tdep.c: Sort headers.
1792         * alpha-mdebug-tdep.c: Sort headers.
1793         * alpha-linux-tdep.c: Sort headers.
1794         * alpha-linux-nat.c: Sort headers.
1795         * alpha-bsd-tdep.c: Sort headers.
1796         * alpha-bsd-nat.c: Sort headers.
1797         * aix-thread.c: Sort headers.
1798         * agent.c: Sort headers.
1799         * addrmap.c: Sort headers.
1800         * ada-varobj.c: Sort headers.
1801         * ada-valprint.c: Sort headers.
1802         * ada-typeprint.c: Sort headers.
1803         * ada-tasks.c: Sort headers.
1804         * ada-lang.c: Sort headers.
1805         * aarch64-tdep.c: Sort headers.
1806         * aarch64-ravenscar-thread.c: Sort headers.
1807         * aarch64-newlib-tdep.c: Sort headers.
1808         * aarch64-linux-tdep.c: Sort headers.
1809         * aarch64-linux-nat.c: Sort headers.
1810         * aarch64-fbsd-tdep.c: Sort headers.
1811         * aarch64-fbsd-nat.c: Sort headers.
1812         * aarch32-linux-nat.c: Sort headers.
1813
1814 2019-04-04  Tom Tromey  <tom@tromey.com>
1815
1816         * varobj.c (varobj_create): Update.
1817         * rust-exp.y (struct rust_parser) <update_innermost_block,
1818         lookup_symbol>: New methods.
1819         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1820         Rename.
1821         (rust_parser::rust_lookup_type)
1822         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1823         * printcmd.c (display_command, do_one_display): Update.
1824         * parser-defs.h (struct parser_state) <parser_state>: Add
1825         "tracker" parameter.
1826         (block_tracker): New member.
1827         (class innermost_block_tracker) <innermost_block_tracker>: Add
1828         "types" parameter.
1829         <reset>: Remove method.
1830         (innermost_block): Don't declare.
1831         (null_post_parser): Update.
1832         * parse.c (innermost_block): Remove global.
1833         (write_dollar_variable): Update.
1834         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1835         Remove "tracker_types" parameter.
1836         (parse_expression): Add "tracker" parameter.
1837         (parse_expression_for_completion): Update.
1838         (null_post_parser): Add "tracker" parameter.
1839         * p-exp.y: Update rules.
1840         * m2-exp.y: Update rules.
1841         * language.h (struct language_defn) <la_post_parser>: Add
1842         "tracker" parameter.
1843         * go-exp.y: Update rules.
1844         * f-exp.y: Update rules.
1845         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1846         parameter.
1847         * d-exp.y: Update rules.
1848         * c-exp.y: Update rules.
1849         * breakpoint.c (set_breakpoint_condition): Create an
1850         innermost_block_tracker.
1851         (watch_command_1): Likewise.
1852         * ada-lang.c (resolve): Add "tracker" parameter.
1853         (resolve_subexp): Likewise.
1854         * ada-exp.y (write_var_from_sym): Update.
1855
1856 2019-04-04  Tom Tromey  <tom@tromey.com>
1857
1858         * type-stack.h: New file.
1859         * type-stack.c: New file.
1860         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1861         type-stack.h.
1862         (insert_into_type_stack, insert_type, push_type, push_type_int)
1863         (insert_type_address_space, pop_type, pop_type_int)
1864         (pop_typelist, pop_type_stack, append_type_stack)
1865         (push_type_stack, get_type_stack, push_typelist)
1866         (follow_type_instance_flags, follow_types): Don't declare.
1867         * parse.c (type_stack): Remove global.
1868         (parse_exp_in_context): Update.
1869         (insert_into_type_stack, insert_type, push_type, push_type_int)
1870         (insert_type_address_space, pop_type, pop_type_int)
1871         (pop_typelist, pop_type_stack, append_type_stack)
1872         (push_type_stack, get_type_stack, push_typelist)
1873         (follow_type_instance_flags, follow_types): Remove (moved to
1874         type-stack.c).
1875         * f-exp.y (type_stack): New global.
1876         Update rules.
1877         (push_kind_type, f_parse): Update.
1878         * d-exp.y (type_stack): New global.
1879         Update rules.
1880         (d_parse): Update.
1881         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1882         Update rules.
1883         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1884         (HFILES_NO_SRCDIR): Add type-stack.h.
1885
1886 2019-04-04  Tom Tromey  <tom@tromey.com>
1887
1888         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1889         (rust_parser::convert_ast_to_expression, rust_parse)
1890         (rust_lex_test_completion, rust_lex_tests): Update.
1891         * parser-defs.h (struct expr_completion_state): New.
1892         (struct parser_state) <parser_state>: Add completion parameter.
1893         <mark_struct_expression, mark_completion_tag>: New methods.
1894         <parse_completion, m_completion_state>: New members.
1895         (prefixify_expression, null_post_parser): Update.
1896         (mark_struct_expression, mark_completion_tag): Don't declare.
1897         * parse.c (parse_completion, expout_last_struct)
1898         (expout_tag_completion_type, expout_completion_name): Remove
1899         globals.
1900         (parser_state::mark_struct_expression)
1901         (parser_state::mark_completion_tag): Now methods.
1902         (prefixify_expression): Add last_struct parameter.
1903         (prefixify_subexp): Likewise.
1904         (parse_exp_1): Update.
1905         (parse_exp_in_context): Add cstate parameter.  Update.
1906         (parse_expression_for_completion): Create an
1907         expr_completion_state.
1908         (null_post_parser): Add "completion" parameter.
1909         * p-exp.y: Update rules.
1910         (yylex): Update.
1911         * language.h (struct language_defn) <la_post_parser>: Add
1912         "completing" parameter.
1913         * go-exp.y: Update rules.
1914         (lex_one_token): Update.
1915         * expression.h (parse_completion): Don't declare.
1916         * d-exp.y: Update rules.
1917         (lex_one_token): Update rules.
1918         * c-exp.y: Update rules.
1919         (lex_one_token): Update.
1920         * ada-lang.c (resolve): Add "parse_completion" parameter.
1921         (resolve_subexp): Likewise.
1922         (ada_resolve_function): Likewise.
1923
1924 2019-04-04  Tom Tromey  <tom@tromey.com>
1925
1926         * parser-defs.h (struct parser_state) <start_arglist,
1927         end_arglist>: New methods.
1928         <arglist_len, m_funcall_chain>: New members.
1929         (arglist_len, start_arglist, end_arglist): Don't declare.
1930         * parse.c (arglist_len, funcall_chain): Remove global.
1931         (start_arglist, end_arglist): Remove functions.
1932         (parse_exp_in_context): Update.
1933         * p-exp.y: Update rules.
1934         * m2-exp.y: Update rules.
1935         * go-exp.y: Update rules.
1936         * f-exp.y: Update rules.
1937         * d-exp.y: Update rules.
1938         * c-exp.y: Update rules.
1939
1940 2019-04-04  Tom Tromey  <tom@tromey.com>
1941
1942         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1943         lex_operator, push_back>: New methods.
1944         Update all rules.
1945         (rust_parser::lex_hex, lex_escape): Rename and update.
1946         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1947         (rust_parser::lex_operator): Rename and update.
1948         (rust_parser::lex_number, rustyylex, rustyyerror)
1949         (rust_lex_test_init, rust_lex_test_sequence)
1950         (rust_lex_test_push_back, rust_lex_tests): Update.
1951         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1952         parameter.
1953         <lexptr, prev_lexptr>: New members.
1954         (lexptr, prev_lexptr): Don't declare.
1955         * parse.c (lexptr, prev_lexptr): Remove globals.
1956         (parse_exp_in_context): Update.
1957         * p-exp.y (yylex, yyerror): Update.
1958         * m2-exp.y (parse_number, yylex, yyerror): Update.
1959         * go-exp.y (lex_one_token, yyerror): Update.
1960         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1961         * d-exp.y (lex_one_token, yyerror): Update.
1962         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1963         (lex_one_token, yyerror): Update.
1964         * ada-lex.l (YY_INPUT): Update.
1965         (rewind_to_char): Update.
1966         * ada-exp.y (yyerror): Update.
1967
1968 2019-04-04  Tom Tromey  <tom@tromey.com>
1969
1970         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1971         * parser-defs.h (struct parser_state) <parser_state>: Add new
1972         parameter.
1973         <comma_terminates>: New member.
1974         (comma_terminates): Don't declare global.
1975         * parse.c (comma_terminates): Remove global.
1976         (parse_exp_in_context): Update.
1977         * p-exp.y (yylex): Update.
1978         * m2-exp.y (yylex): Update.
1979         * go-exp.y (lex_one_token): Update.
1980         * f-exp.y (yylex): Update.
1981         * d-exp.y (lex_one_token): Update.
1982         * c-exp.y (lex_one_token): Update.
1983         * ada-lex.l: Update.
1984
1985 2019-04-04  Tom Tromey  <tom@tromey.com>
1986
1987         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1988         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1989         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1990         * parser-defs.h (paren_depth): Don't declare.
1991         * parse.c (paren_depth): Remove global.
1992         (parse_exp_in_context): Update.
1993         * p-exp.y (paren_depth): New global.
1994         (pascal_parse): Initialize it.
1995         * m2-exp.y (paren_depth): New global.
1996         (m2_parse): Initialize it.
1997         * go-exp.y (paren_depth): New global.
1998         (go_parse): Initialize it.
1999         * f-exp.y (paren_depth): New global.
2000         (f_parse): Initialize it.
2001         * d-exp.y (paren_depth): New global.
2002         (d_parse): Initialize it.
2003         * c-exp.y (paren_depth): New global.
2004         (c_parse): Initialize it.
2005         * ada-lex.l (paren_depth): New global.
2006         (lexer_init): Initialize it.
2007
2008 2019-04-04  Tom Tromey  <tom@tromey.com>
2009
2010         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2011         (rust_parser::convert_ast_to_type)
2012         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2013         * parser-defs.h (struct parser_state) <parser_state>: Add
2014         parameters.  Initialize new members.
2015         <expression_context_block, expression_context_pc>: New members.
2016         * parse.c (expression_context_block, expression_context_pc):
2017         Remove globals.
2018         (parse_exp_in_context): Update.
2019         * p-exp.y: Update all rules.
2020         (yylex): Update.
2021         * m2-exp.y: Update all rules.
2022         (yylex): Update.
2023         * go-exp.y (yylex): Update.
2024         * f-exp.y (yylex): Update.
2025         * d-exp.y: Update all rules.
2026         (yylex): Update.
2027         * c-exp.y: Update all rules.
2028         (lex_one_token, classify_name, yylex, c_parse): Update.
2029         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2030
2031 2019-04-04  Tom Tromey  <tom@tromey.com>
2032
2033         * gdbarch.h, gdbarch.c: Rebuild.
2034         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2035         * stap-probe.h:
2036         (struct stap_parse_info): Replace "parser_state" with
2037         "expr_builder".
2038         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2039         (parser_state): New class.
2040         * parse.c (expr_builder): Rename.
2041         (expr_builder::release): Rename.
2042         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2043         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2044         (write_exp_elt_longcst, write_exp_elt_floatcst)
2045         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2046         (write_exp_string_vector, write_exp_bitstring)
2047         (write_exp_msymbol, mark_struct_expression)
2048         (write_dollar_variable)
2049         (insert_type_address_space, increase_expout_size): Replace
2050         "parser_state" with "expr_builder".
2051         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2052         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2053         "parser_state" with "expr_builder".
2054
2055 2019-04-04  Tom Tromey  <tom@tromey.com>
2056
2057         * rust-exp.y: Replace "parse_language" with method call.
2058         * p-exp.y:
2059         (yylex): Replace "parse_language" with method call.
2060         * m2-exp.y:
2061         (yylex): Replace "parse_language" with method call.
2062         * go-exp.y (classify_name): Replace "parse_language" with method
2063         call.
2064         * f-exp.y (yylex): Replace "parse_language" with method call.
2065         * d-exp.y (lex_one_token): Replace "parse_language" with method
2066         call.
2067         * c-exp.y:
2068         (lex_one_token, classify_name, yylex): Replace "parse_language"
2069         with method call.
2070         * ada-exp.y (find_primitive_type, type_char)
2071         (type_system_address): Replace "parse_language" with method call.
2072
2073 2019-04-04  Tom Tromey  <tom@tromey.com>
2074
2075         * rust-exp.y: Replace "parse_gdbarch" with method call.
2076         * parse.c (write_dollar_variable, insert_type_address_space):
2077         Replace "parse_gdbarch" with method call.
2078         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2079         call.
2080         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2081         call.
2082         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2083         "parse_gdbarch" with method call.
2084         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2085         with method call.
2086         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2087         "parse_gdbarch" with method call.
2088         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2089         "parse_gdbarch" with method call.
2090         * c-exp.y (parse_type, parse_number, classify_name): Replace
2091         "parse_gdbarch" with method call.
2092         * ada-lex.l: Replace "parse_gdbarch" with method call.
2093         * ada-exp.y (parse_type, find_primitive_type, type_char)
2094         (type_system_address): Replace "parse_gdbarch" with method call.
2095
2096 2019-04-04  Tom Tromey  <tom@tromey.com>
2097
2098         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2099         * stap-probe.c (stap_parse_argument): Update.
2100         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2101         initial_size parameter.
2102         * rust-exp.y (rust_lex_tests): Update.
2103         * parse.c (parser_state): Update.
2104         (parse_exp_in_context): Update.
2105         * parser-defs.h (struct parser_state) <parser_state>: Remove
2106         "initial_size" parameter.
2107
2108 2019-04-04  Tom Tromey  <tom@tromey.com>
2109
2110         * parser-defs.h (increase_expout_size): Don't declare.
2111         * parse.c (increase_expout_size): Now static.
2112
2113 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2114
2115         * gnu-nat.c (gnu_nat_target::wait): Fix
2116         target_waitstatus_to_string call.
2117
2118 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * eval.c (evaluate_subexp_standard): Handle internal functions
2121         during Fortran function call handling.
2122
2123 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * NEWS: Mention new internal functions.
2126         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2127         (read_base_type): Use dwarf2_init_complex_target_type.
2128         * value.c (creal_internal_fn): New function.
2129         (cimag_internal_fn): New function.
2130         (_initialize_values): Register new internal functions.
2131
2132 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * infrun.c (stop_all_threads): If debug_infrun, always
2135         trace the wait status after wait_one, using
2136         target_waitstatus_to_string and target_pid_to_str.
2137         (handle_inferior_event): Replace various trace of
2138         wait status kind by a single trace.
2139         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2140         wait status kind image by target_waitstatus_to_string.
2141         * target/waitstatus.c (target_waitstatus_to_string): Fix
2142         obsolete comment.
2143
2144 2019-04-01  Tom Tromey  <tromey@adacore.com>
2145
2146         PR symtab/23331:
2147         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2148
2149 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2150             Pedro Alves  <palves@redhat.com>
2151
2152         * top.c (quit_force): Call 'finalize_values'.
2153         * value.c (finalize_values): New function.
2154         * value.h (finalize_values): Declare.
2155
2156 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2157
2158         * NEWS: Announce $_gdb_major and $_gdb_minor.
2159
2160         * top.c (init_gdb_version_vars): New function.
2161         (gdb_init): Call init_gdb_version_vars.
2162
2163 2019-03-29  Tom Tromey  <tromey@adacore.com>
2164
2165         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2166         help text.  Remove dead code.
2167
2168 2019-03-29  Keith Seitz  <keiths@redhat.com>
2169
2170         From Siddhesh Poyarekar:
2171         * f-lang.h (f77_get_upperbound): Return LONGEST.
2172         (f77_get_lowerbound): Likewise.
2173         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2174         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2175         print them.
2176         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2177         plongest to format print it.
2178         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2179         (f77_get_upperbound): Likewise.
2180         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2181         LOWER_BOUND to LONGEST.
2182         (f77_create_arrayprint_offset_tbl): Likewise.
2183
2184 2019-03-29  Keith Seitz  <keiths@redhat.com>
2185
2186         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2187         %s/pulongest for TYPE_LENGTH instead of %d in format
2188         strings.
2189         * ada-typerint.c (ada_print_type): Likewise.
2190         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2191         * compile/compile-c-support.c (generate_register_struct): Likewise.
2192         * gdbtypes.c (recursive_dump_type): Likewise.
2193         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2194         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2195         instead of %d in format strings.
2196         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2197         to std::min to ULONGEST.
2198         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2199         instead of %d in format strings.
2200         * tracepoint.c (info_scope_command): Likewise.
2201         * typeprint.c (print_offset_data::update)
2202         (print_offset_data::finish): Likewise.
2203         * xtensa-tdep.c (xtensa_store_return_value)
2204         (xtensa_push_dummy_call): Likewise.
2205
2206 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2207
2208         * windows-nat.c (display_selector): Fixed format specifications
2209         for 64-bit Cygwin.
2210
2211 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212
2213         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2214
2215 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2216
2217         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2218         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2219         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2220         (nios2_linux_init_abi): Install it.
2221
2222 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2223
2224         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2225
2226 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2227
2228         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2229
2230 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2231             Tom Tromey  <tromey@adacore.com>
2232
2233         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2234
2235 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2236
2237         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2238         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2239         method to compute the bounds of range types. Also print "[evaluated]"
2240         if the bounds' values come from a dynamic evaluation.
2241
2242 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2245         whitespace when pretty printing is on.
2246
2247 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2248
2249         * ppc-linux-nat.c: Add include.
2250
2251 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2252
2253         * NEWS: Mention AArch64 Pointer Authentication.
2254
2255 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2256
2257         * arm-linux-nat.c: Add include.
2258
2259 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2260
2261         * source-cache.c (source_cache::get_source_lines): Re-read
2262         fullname after calling open_source_file.
2263
2264 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2265
2266         * NEWS: Mention TLS support for FreeBSD.
2267
2268 2019-03-25  Tom Tromey  <tromey@adacore.com>
2269
2270         * minsyms.c (BUNCH_SIZE): Update comment.
2271         (~minimal_symbol_reader): Remove old comment.
2272         (compact_minimal_symbols): Update comment.
2273         (minimal_symbol_reader::install): Remove old comment.  Update
2274         other comments.
2275
2276 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2277
2278         * s390-linux-nat.c: Add include.
2279
2280 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2281
2282         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2283         Call linux_get_hwcap.
2284         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2285         Likewise.
2286         (aarch64_linux_get_hwcap): Remove function.
2287         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2288         declaration.
2289         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2290         linux_get_hwcap.
2291         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2292         * linux-tdep.c (linux_get_hwcap): Add function.
2293         (linux_get_hwcap2): Likewise.
2294         * linux-tdep.h (linux_get_hwcap): Add declaration.
2295         (linux_get_hwcap2): Likewise.
2296         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2297         (ppc_linux_get_hwcap2): Likewise.
2298         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2299         linux_get_hwcap.
2300         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2301         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2302         (ppc_linux_nat_target::read_description): Likewise.
2303         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2304         * s390-linux-nat.c: Likewise.
2305         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2306
2307 2019-03-24  Tom Tromey  <tom@tromey.com>
2308
2309         * ada-lang.c (standard_lookup): Simplify initialization.
2310         (ada_lookup_symbol_nonlocal): Simplify return.
2311         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2312         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2313         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2314         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2315         initialization.
2316         * solib.c (solib_global_lookup): Simplify.
2317         * symtab.c (null_block_symbol): Remove.
2318         (symbol_cache_lookup): Simplify returns.
2319         (lookup_language_this): Simplify returns.
2320         (lookup_symbol_aux): Simplify return.
2321         (lookup_local_symbol): Simplify returns.
2322         (lookup_global_symbol_from_objfile): Simplify return.
2323         (lookup_symbol_in_objfile_symtabs)
2324         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2325         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2326         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2327         * cp-namespace.c (cp_lookup_bare_symbol)
2328         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2329         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2330         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2331         (cp_lookup_symbol_via_imports): Simplify initialization.
2332         (find_symbol_in_baseclass): Likewise.
2333         * symtab.h (null_block_symbol): Remove.
2334         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2335         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2336         (d_lookup_symbol_module): Likewise.
2337         (find_symbol_in_baseclass): Simplify initialization.
2338
2339 2019-03-24  Tom Tromey  <tom@tromey.com>
2340
2341         * expression.h: Don't include symtab.h.
2342         (struct block): Forward declare.
2343
2344 2019-03-24  Tom Tromey  <tom@tromey.com>
2345
2346         * c-exp.y (typebase): Remove casts.
2347         * gdbtypes.c (lookup_unsigned_typename, )
2348         (lookup_signed_typename): Remove cast.
2349         * eval.c (parse_to_comma_and_eval): Remove cast.
2350         * parse.c (write_dollar_variable): Remove cast.
2351         * block.h (struct block) <superblock>: Now const.
2352         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2353         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2354         (map_block): Make "block" const.
2355         * symfile.h (struct quick_symbol_functions)
2356         <map_matching_symbols>: Constify block argument to "callback".
2357         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2358         const.
2359         (find_pc_sect_compunit_symtab): Make "b" const.
2360         (find_symbol_at_address): Likewise.
2361         (search_symbols): Likewise.
2362         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2363         (dw2_debug_names_lookup_symbol): Likewise.
2364         (dw2_map_matching_symbols): Update.
2365         * p-valprint.c (pascal_val_print): Remove "block".
2366         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2367         (aux_add_nonlocal_symbols): Make "block" const.
2368         (resolve_subexp): Remove cast.
2369         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2370         const.
2371         (iterate_over_file_blocks): Likewise.
2372         * f-exp.y (%union) <bval>: Remove.
2373         * coffread.c (patch_opaque_types): Make "b" const.
2374         * spu-tdep.c (spu_catch_start): Make "block" const.
2375         * c-valprint.c (print_unpacked_pointer): Remove "block".
2376         * symmisc.c (dump_symtab_1): Make "b" const.
2377         (block_depth): Make "block" const.
2378         * d-exp.y (%union) <bval>: Remove.
2379         * cp-support.h (cp_lookup_rtti_type): Update.
2380         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2381         * psymtab.c (psym_lookup_symbol): Make "block" const.
2382         (maintenance_check_psymtabs): Make "b" const.
2383         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2384         (enumerate_locals, enumerate_args): Update.
2385         * python/py-symtab.c (stpy_global_block): Make "block" const.
2386         (stpy_static_block): Likewise.
2387         * inline-frame.c (block_starting_point_at): Make "new_block"
2388         const.
2389         * block.c (find_block_in_blockvector): Make return type const.
2390         (blockvector_for_pc_sect): Make "b" const.
2391         (find_block_in_blockvector): Make "b" const.
2392
2393 2019-03-23  Tom Tromey  <tom@tromey.com>
2394
2395         * varobj.c (varobj_create): Update.
2396         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2397         * printcmd.c (display_command, do_one_display): Don't reset
2398         innermost_block.
2399         * parser-defs.h (enum innermost_block_tracker_type): Move to
2400         expression.h.
2401         (innermost_block): Update comment.
2402         * parse.c (parse_exp_1): Add tracker_types parameter.
2403         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2404         tracker_types parameter.  Reset innermost_block.
2405         (parse_exp_in_context): Remove.
2406         (parse_expression_for_completion): Update.
2407         * objfiles.c (~objfile): Don't reset expression_context_block or
2408         innermost_block.
2409         * expression.h (enum innermost_block_tracker_type): Move from
2410         parser-defs.h.
2411         (parse_exp_1): Add tracker_types parameter.
2412         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2413         reset innermost_block.
2414
2415 2019-03-23  Tom Tromey  <tom@tromey.com>
2416
2417         * objfiles.h: Include bcache.h.
2418
2419 2019-03-23  Tom Tromey  <tom@tromey.com>
2420
2421         * linespec.c (get_current_search_block): Use
2422         scoped_restore_current_language.
2423         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2424
2425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2426             Jiong Wang  <jiong.wang@arm.com>
2427
2428         * aarch64-linux-tdep.c
2429         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2430         section.
2431         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2432
2433 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2434             Jiong Wang  <jiong.wang@arm.com>
2435
2436         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2437         instructions.
2438         (aarch64_analyze_prologue_test): Add PACIASP test.
2439         (aarch64_prologue_prev_register): Unmask PC value.
2440
2441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2442             Jiong Wang  <jiong.wang@arm.com>
2443
2444         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2445         (aarch64_dwarf2_prev_register): Unmask PC value.
2446         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2447         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2448         DW_CFA_AARCH64_negate_ra_state.
2449         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2450
2451 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2452             Jiong Wang  <jiong.wang@arm.com>
2453
2454         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2455         registers.
2456         (aarch64_pseudo_register_name): Likewise.
2457         (aarch64_pseudo_register_type): Likewise.
2458         (aarch64_pseudo_register_reggroup_p): Likewise.
2459         (aarch64_gdbarch_init): Add pauth registers.
2460         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2461         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2462         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2463         (struct gdbarch_tdep): Add regnum for ra_state.
2464
2465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2466             Jiong Wang  <jiong.wang@arm.com>
2467
2468         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2469
2470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2471             Jiong Wang  <jiong.wang@arm.com>
2472
2473         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2474         function.
2475         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2476         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2477         (aarch64_gdbarch_init): Add puth registers.
2478         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2479         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2480         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2481
2482 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2483             Jiong Wang  <jiong.wang@arm.com>
2484
2485         * aarch64-linux-nat.c
2486         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2487         * aarch64-linux-tdep.c
2488         (aarch64_linux_core_read_description): Likewise.
2489         (aarch64_linux_get_hwcap): New function.
2490         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2491         (aarch64_linux_get_hwcap): New declaration.
2492
2493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2494             Jiong Wang  <jiong.wang@arm.com>
2495
2496         * aarch64-linux-nat.c
2497         (aarch64_linux_nat_target::read_description): Add pauth param.
2498         * aarch64-linux-tdep.c
2499         (aarch64_linux_core_read_description): Likewise.
2500         * aarch64-tdep.c (struct target_desc): Add in pauth.
2501         (aarch64_read_description): Add pauth param.
2502         (aarch64_gdbarch_init): Likewise.
2503         * aarch64-tdep.h (aarch64_read_description): Likewise.
2504         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2505         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2506         * features/Makefile: Add new files.
2507         * features/aarch64-pauth.c: New file.
2508         * features/aarch64-pauth.xml: New file.
2509
2510 2019-03-20  Tom Tromey  <tromey@adacore.com>
2511
2512         * infrun.c (handle_inferior_event): Rename from
2513         handle_inferior_event_1.  Create a scoped_value_mark.
2514         (handle_inferior_event): Remove.
2515
2516 2019-03-19  Tom Tromey  <tromey@adacore.com>
2517
2518         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2519         * infrun.h (print_stop_event): Add "displays" parameter.
2520         * infrun.c (print_stop_event): Add "displays" parameter.
2521
2522 2019-03-19  Pedro Alves  <palves@redhat.com>
2523
2524         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2525         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2526         to -1.  Fix TABs vs spaces.
2527         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2528         * tui/tui-out.h (tui_ui_out) Add intro comments.
2529         <m_line, m_start_of_line>: In-class initialize, and add describing
2530         comment.
2531
2532 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2535         variable names.
2536         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2537
2538 2019-03-18  Pedro Alves  <palves@redhat.com>
2539             Eli Zaretskii <eliz@gnu.org>
2540
2541         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2542         m_line and m_start_of_line.
2543
2544 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2545
2546         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2547         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2548         it returns a newline.  This fixes a regression in TU mode, whereby
2549         the next line is output on the same screen line as the user input.
2550
2551 2019-03-18  Tom Tromey  <tromey@adacore.com>
2552
2553         * minsyms.c (minimal_symbol_reader::install): Remove call to
2554         obstack_blank.
2555
2556 2019-03-18  Pedro Alves  <palves@redhat.com>
2557
2558         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2559         New globals.
2560         (apply_style): New, factored out from ...
2561         (apply_ansi_escape): ... this.  Handle reverse video mode.
2562         (tui_set_reverse_mode): New function.
2563         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2564         * tui/tui-winsource.c (tui_show_source_line): Use
2565         tui_set_reverse_mode instead of setting A_STANDOUT.
2566         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2567         New setter methods.
2568
2569 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2570
2571         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2572         Handle tabs.
2573
2574 2019-03-18  Tom Tromey  <tromey@adacore.com>
2575
2576         * ada-lang.c (empty_array): Add "high" parameter.
2577         (ada_evaluate_subexp): Update.
2578
2579 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2580
2581         * unittests/string_view-selftests.c: Define
2582         _initialize_string_view_selftests unconditionally.
2583
2584 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2585
2586         PR gdb/24350
2587         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2588
2589 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2590
2591         PR gdb/24351
2592         * windows-nat.c (display_selector): Fix format specifiers.
2593
2594 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2595
2596         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2597         tui_refill_source_window instead of tui_refresh_win, to update the
2598         current execution line.  This fixes redisplay of the current line
2599         when stepping through the code with "next" or "step".
2600
2601 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2602
2603         * source-cache.c (source_cache::get_source_lines): Call
2604         find_source_lines to initialize s->nlines.  This fixes vertical
2605         scrolling of TUI source window when the DOWN arrow is pressed.
2606
2607 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2608
2609         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2610         linux-thread-db.c (_initialize_thread_db): Likewise.
2611
2612 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2613
2614         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2615         wclrtoeol in tui_show_source_line".  This reverts changes made in
2616         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2617
2618 2019-03-15  Tom Tromey  <tom@tromey.com>
2619
2620         * symtab.h (struct minimal_symbol): Derive from
2621         general_symbol_info.
2622         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2623         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2624         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2625         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2626         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2627         (MSYMBOL_SEARCH_NAME): Update.
2628         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2629         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2630         * minsyms.c (minimal_symbol_reader::record_full): Update.
2631
2632 2019-03-15  Tom Tromey  <tom@tromey.com>
2633
2634         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2635
2636 2019-03-15  Tom Tromey  <tom@tromey.com>
2637
2638         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2639         unique_xmalloc_ptr.
2640         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2641         Update.
2642         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2643         (build_minimal_symbol_hash_tables)
2644         (minimal_symbol_reader::install): Update.
2645
2646 2019-03-15  Tom Tromey  <tom@tromey.com>
2647
2648         * symtab.c (create_demangled_names_hash): Update.
2649         (symbol_set_names): Update.
2650         * objfiles.h (struct objfile_per_bfd_storage)
2651         <demangled_names_hash>: Now an htab_up.
2652         * objfiles.c (objfile_per_bfd_storage): Simplify.
2653
2654 2019-03-15  Tom Tromey  <tom@tromey.com>
2655
2656         * objfiles.h (struct objfile_per_bfd_storage): Declare
2657         destructor.
2658         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2659         New.
2660         (get_objfile_bfd_data): Use new.  Don't initialize
2661         language_of_main.
2662         (free_objfile_per_bfd_storage): Remove.
2663         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2664
2665 2019-03-15  Tom Tromey  <tom@tromey.com>
2666
2667         * symfile.c (reread_symbols): Update.
2668         * objfiles.c (objfile::objfile): Update.
2669         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2670         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2671         comment.
2672         (minimal_symbol_reader::install): Update.
2673         (terminate_minimal_symbol_table): Remove.
2674         * jit.c (jit_object_close_impl): Update.
2675
2676 2019-03-15  Tom Tromey  <tom@tromey.com>
2677
2678         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2679         initializations.
2680
2681 2019-03-15  Tom Tromey  <tom@tromey.com>
2682
2683         * objfiles.h (struct objfile_per_bfd_storage)
2684         <demangled_hash_languages>: Now a bitset.
2685         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2686         (lookup_minimal_symbol): Update.
2687
2688 2019-03-15  Tom Tromey  <tom@tromey.com>
2689
2690         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2691         Don't return the symbol.
2692         * coffread.c (record_minimal_symbol): Use record_full.
2693
2694 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2695
2696         The MS-Windows port of ncurses fails to switch to a color pair if
2697         one or both of the colors are the implicit default colors.  This
2698         change records the default colors when TUI is initialized, and
2699         then specifies them explicitly when a color pair uses the default
2700         colors.  This allows color styling in TUI mode on MS-Windows.
2701
2702         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2703         ncurses_norm_attr.
2704         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2705         colors in ncurses_norm_attr.
2706         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2707         "none", replace it with the default color recorded in
2708         ncurses_norm_attr.
2709
2710 2019-03-14  Tom Tromey  <tromey@adacore.com>
2711
2712         * source-cache.h (class source_cache) <get_source_lines>: Return
2713         std::string.
2714         * source-cache.c (source_cache::extract_lines): Handle case where
2715         first_pos==npos.  Return std::string.
2716         (source_cache::get_source_lines): Update.
2717
2718 2019-03-14  Tom Tromey  <tromey@adacore.com>
2719
2720         * NEWS: Add item for "style sources" commands.
2721         * source-cache.c (source_cache::get_source_lines): Check
2722         source_styling.
2723         * cli/cli-style.c (source_styling): New global.
2724         (_initialize_cli_style): Add "style sources" commands.
2725         (show_style_sources): New function.
2726         * cli/cli-style.h (source_styling): Declare.
2727
2728 2019-03-14  Pedro Alves  <palves@redhat.com>
2729             Tom Tromey  <tromey@adacore.com>
2730
2731         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2732         * tui/tui-winsource.c (tui_refill_source_window): New function,
2733         from...
2734         (tui_horizontal_source_scroll): ... here.  Move some logic.
2735         * cli/cli-style.c (set_style_enabled): Notify new observable.
2736         * tui/tui-hooks.c (tui_redisplay_source): New function.
2737         (tui_attach_detach_observers): Attach or detach
2738         tui_redisplay_source.
2739         * observable.h (source_styling_changed): New observable.
2740         * observable.c: Define source_styling_changed observable.
2741
2742 2019-03-13  Tom Tromey  <tromey@adacore.com>
2743
2744         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2745         (i386_gnu_nat_target::store_registers): Update.
2746         * target-debug.h (target_debug_print_std_string): New macro.
2747         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2748         * windows-tdep.c (display_one_tib): Update.
2749         * tui/tui-stack.c (tui_make_status_line): Update.
2750         * top.c (print_inferior_quit_action): Update.
2751         * thread.c (thr_try_catch_cmd): Update.
2752         (add_thread_with_info): Update.
2753         (thread_target_id_str): Update.
2754         (thr_try_catch_cmd): Update.
2755         (thread_command): Update.
2756         (thread_find_command): Update.
2757         * record-btrace.c (record_btrace_target::info_record)
2758         (record_btrace_resume_thread, record_btrace_target::resume)
2759         (record_btrace_cancel_resume, record_btrace_step_thread)
2760         (record_btrace_target::wait, record_btrace_target::wait)
2761         (record_btrace_target::wait, record_btrace_target::stop): Update.
2762         * progspace.c (print_program_space): Update.
2763         * process-stratum-target.c
2764         (process_stratum_target::thread_address_space): Update.
2765         * linux-fork.c (linux_fork_mourn_inferior)
2766         (detach_checkpoint_command, info_checkpoints_command)
2767         (linux_fork_context): Update.
2768         (linux_fork_detach): Update.
2769         (class scoped_switch_fork_info): Update.
2770         (delete_checkpoint_command): Update.
2771         * infrun.c (follow_fork_inferior): Update.
2772         (follow_fork_inferior): Update.
2773         (proceed_after_vfork_done): Update.
2774         (handle_vfork_child_exec_or_exit): Update.
2775         (follow_exec): Update.
2776         (displaced_step_prepare_throw): Update.
2777         (displaced_step_restore): Update.
2778         (start_step_over): Update.
2779         (resume_1): Update.
2780         (clear_proceed_status_thread): Update.
2781         (proceed): Update.
2782         (print_target_wait_results): Update.
2783         (do_target_wait): Update.
2784         (context_switch): Update.
2785         (stop_all_threads): Update.
2786         (restart_threads): Update.
2787         (finish_step_over): Update.
2788         (handle_signal_stop): Update.
2789         (switch_back_to_stepped_thread): Update.
2790         (keep_going_pass_signal): Update.
2791         (print_exited_reason): Update.
2792         (normal_stop): Update.
2793         * inferior.c (inferior_pid_to_str): Change return type.
2794         (print_selected_inferior): Update.
2795         (add_inferior): Update.
2796         (detach_inferior): Update.
2797         * dummy-frame.c (fprint_dummy_frames): Update.
2798         * dcache.c (dcache_info_1): Update.
2799         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2800         (btrace_fetch, btrace_clear): Update.
2801         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2802         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2803         type.
2804         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2805         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2806         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2807         * gdbarch.c, gdbarch.h: Rebuild.
2808         * gdbarch.sh (core_pid_to_str): Change return type.
2809         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2810         return type.
2811         (windows_nat_target::pid_to_str): Change return type.
2812         (windows_delete_thread): Update.
2813         (windows_nat_target::attach): Update.
2814         (windows_nat_target::files_info): Update.
2815         * target-delegates.c: Rebuild.
2816         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2817         return type.
2818         (sol_thread_target::pid_to_str): Change return type.
2819         * remote.c (class remote_target) <pid_to_str>: Change return
2820         type.
2821         (remote_target::pid_to_str): Change return type.
2822         (extended_remote_target::attach, remote_target::remote_stop_ns)
2823         (remote_target::remote_notif_remove_queued_reply)
2824         (remote_target::push_stop_reply, remote_target::disable_btrace):
2825         Update.
2826         (extended_remote_target::attach): Update.
2827         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2828         type.
2829         (gdbsim_target::pid_to_str): Change return type.
2830         * ravenscar-thread.c (struct ravenscar_thread_target)
2831         <pid_to_str>: Change return type.
2832         (ravenscar_thread_target::pid_to_str): Change return type.
2833         * procfs.c (class procfs_target) <pid_to_str>: Change return
2834         type.
2835         (procfs_target::pid_to_str): Change return type.
2836         (procfs_target::attach): Update.
2837         (procfs_target::detach): Update.
2838         (procfs_target::fetch_registers): Update.
2839         (procfs_target::store_registers): Update.
2840         (procfs_target::wait): Update.
2841         (procfs_target::files_info): Update.
2842         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2843         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2844         return type.
2845         (nto_procfs_target::pid_to_str): Change return type.
2846         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2847         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2848         return type.
2849         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2850         (exit_lwp): Update.
2851         (attach_proc_task_lwp_callback, get_detach_signal)
2852         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2853         (linux_nat_target::resume, wait_lwp, stop_callback)
2854         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2855         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2856         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2857         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2858         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2859         type.
2860         (inf_ptrace_target::attach): Update.
2861         (inf_ptrace_target::files_info): Update.
2862         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2863         type.
2864         (go32_nat_target::pid_to_str): Change return type.
2865         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2866         (gnu_nat_target::wait): Update.
2867         (gnu_nat_target::wait): Update.
2868         (gnu_nat_target::resume): Update.
2869         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2870         (fbsd_nat_target::wait): Update.
2871         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2872         type.
2873         (darwin_nat_target::attach): Update.
2874         * corelow.c (class core_target) <pid_to_str>: Change return type.
2875         (core_target::pid_to_str): Change return type.
2876         * target.c (normal_pid_to_str): Change return type.
2877         (default_pid_to_str): Likewise.
2878         (target_pid_to_str): Change return type.
2879         (target_translate_tls_address): Update.
2880         (target_announce_detach): Update.
2881         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2882         return type.
2883         (bsd_uthread_target::pid_to_str): Change return type.
2884         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2885         type.
2886         (bsd_kvm_target::pid_to_str): Change return type.
2887         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2888         return type.
2889         (aix_thread_target::pid_to_str): Change return type.
2890         * target.h (struct target_ops) <pid_to_str>: Change return type.
2891         (target_pid_to_str, normal_pid_to_str): Likewise.
2892         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2893         type.
2894         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2895         type.
2896         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2897         return type.
2898         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2899         type.
2900         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2901         type.
2902         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2903         return type.
2904
2905 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2906
2907         * NEWS: Mention that the new default MI version is 3.  Mention
2908         changes to the output of commands and events that deal with
2909         multi-location breakpoints.
2910         * breakpoint.c: Include "mi/mi-out.h".
2911         (print_one_breakpoint): Change output syntax if using MI version
2912         >= 3.
2913         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2914         New.
2915         (mi_multi_location_breakpoint_output_fixed): New.
2916         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2917         (mi_cmd_fix_multi_location_breakpoint_output): New.
2918         (mi_multi_location_breakpoint_output_fixed): New.
2919         * mi/mi-cmds.c (mi_cmds): Register command
2920         -fix-multi-location-breakpoint-output.
2921         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2922         interpreter "mi".
2923
2924 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2925
2926         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2927         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2928         instantiate mi_ui_out based on interpreter name.
2929         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2930         * mi/mi-main.c (mi_load_progress): Likewise.
2931
2932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2933
2934         * NEWS: Combine separate "New targets" sections for 8.3.
2935
2936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2937
2938         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2939         (ppcfbsd_init_abi): Install gdbarch
2940         "fetch_tls_load_module_address" and "get_thread_local_address"
2941         methods.
2942
2943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2944
2945         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2946         (riscv_fbsd_init_abi): Install gdbarch
2947         "fetch_tls_load_module_address" and "get_thread_local_address"
2948         methods.
2949
2950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2951
2952         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2953         (i386fbsd_init_abi): Install gdbarch
2954         "fetch_tls_load_module_address" and "get_thread_local_address"
2955         methods.
2956
2957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2958
2959         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2960         (amd64fbsd_init_abi): Install gdbarch
2961         "fetch_tls_load_module_address" and "get_thread_local_address"
2962         methods.
2963
2964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2965
2966         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2967         (struct fbsd_pspace_data): New type.
2968         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2969         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2970         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2971         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2972         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2973
2974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2975
2976         * gdbtypes.c (lookup_struct_elt): New function.
2977         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2978         * gdbtypes.h (struct struct_elt): New type.
2979         (lookup_struct_elt): New prototype.
2980
2981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2982
2983         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2984         remove disabled code block.
2985
2986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2987
2988         * gdbarch.sh (get_thread_local_address): New method.
2989         * gdbarch.h, gdbarch.c: Regenerate.
2990         * target.c (target_translate_tls_address): Use
2991         gdbarch_get_thread_local_address if present instead of
2992         target::get_thread_local_address.
2993
2994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2995
2996         * target.h (target::get_thread_local_address): Update comment.
2997
2998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2999
3000         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3001         objfile->separate_debug_objfile_backlink if not NULL.
3002
3003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3004
3005         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3006         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3007         (amd64bsd_store_inferior_registers): Likewise.
3008         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3009         Enable segment base registers.
3010         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3011         PT_GETFSBASE and PT_GETGSBASE.
3012         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3013         PT_SETGSBASE.
3014         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3015         segment base registers.
3016         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3017
3018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3019
3020         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3021         Update calls to i386_target_description to add 'segments'
3022         parameter.
3023         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3024         add segment base registers.
3025         * arch/i386.c (i386_create_target_description): Add 'segments'
3026         parameter to enable segment base registers.
3027         * arch/i386.h (i386_create_target_description): Likewise.
3028         * features/i386/32bit-segments.xml: New file.
3029         * features/i386/32bit-segments.c: Generate.
3030         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3031         call to i386_target_description to add 'segments' parameter.
3032         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3033         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3034         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3035         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3036         if feature is present.
3037         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3038         Add 'segments' parameter to call to i386_target_description.
3039         (i386_target_description): Add 'segments' parameter to enable
3040         segment base registers.
3041         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3042         to call to i386_target_description.
3043         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3044         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3045         Define I386_NUM_REGS.
3046         (i386_target_description): Add 'segments' parameter to enable
3047         segment base registers.
3048
3049 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3050
3051         PR/24325
3052         * source-cache.c: #undef open and close, to avoid unresolved
3053         externals during linking.
3054
3055 2019-03-12  Tom Tromey  <tromey@adacore.com>
3056
3057         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3058         const.  Add initializers.
3059         (_initialize_remote): Don't initialize ptid globals.
3060
3061 2019-03-12  Pedro Alves  <palves@redhat.com>
3062
3063         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3064
3065 2019-03-12  Pedro Alves  <palves@redhat.com>
3066
3067         * cp-name-parser.y (main): Remove unused 'len' variable.
3068
3069 2019-03-12  Tom Tromey  <tromey@adacore.com>
3070
3071         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3072         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3073
3074 2019-03-12  Tom Tromey  <tromey@adacore.com>
3075
3076         * linux-nat.c (iterate_over_lwps): Update.
3077         (stop_callback): Remove parameter.
3078         (stop_wait_callback, detach_callback, resume_set_callback)
3079         (select_singlestep_lwp_callback, set_ignore_sigint)
3080         (status_callback, resumed_callback, resume_clear_callback)
3081         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3082         data parameter.
3083         (linux_nat_target::detach, linux_nat_target::resume)
3084         (linux_stop_and_wait_all_lwps, select_event_lwp)
3085         (linux_nat_filter_event, linux_nat_wait_1)
3086         (linux_nat_target::kill, linux_nat_target::stop)
3087         (linux_nat_target::stop): Update.
3088         (linux_nat_resume_callback): Change type.
3089         (resume_stopped_resumed_lwps, count_events_callback)
3090         (select_event_lwp_callback): Likewise.
3091         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3092         * arm-linux-nat.c (struct update_registers_data): Remove.
3093         (update_registers_callback): Change type.
3094         (arm_linux_insert_hw_breakpoint1): Update.
3095         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3096         parameter.
3097         (x86_linux_dr_set_addr): Update.
3098         (x86_linux_dr_set_control): Update.
3099         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3100         (iterate_over_lwps): Use gdb::function_view.
3101         * nat/aarch64-linux-hw-point.c (struct
3102         aarch64_dr_update_callback_param): Remove.
3103         (debug_reg_change_callback): Change type.
3104         (aarch64_notify_debug_reg_change): Update.
3105         * s390-linux-nat.c (s390_refresh_per_info): Update.
3106
3107 2019-03-11  Tom Tromey  <tromey@adacore.com>
3108
3109         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3110         redundant assignment to "this_cu".
3111
3112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3113
3114         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3115
3116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3117
3118         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3119         from...
3120         (rank_one_type): ... this.
3121
3122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3125         from...
3126         (rank_one_type): ... this.
3127
3128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3131         from...
3132         (rank_one_type): ... this.
3133
3134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3135
3136         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3137         from...
3138         (rank_one_type): ... this.
3139
3140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3141
3142         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3143         from...
3144         (rank_one_type): ... this.
3145
3146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3147
3148         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3149         from...
3150         (rank_one_type): ... this.
3151
3152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3153
3154         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3155         from...
3156         (rank_one_type): ... this.
3157
3158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3159
3160         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3161         from...
3162         (rank_one_type): ... this.
3163
3164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3165
3166         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3167         from...
3168         (rank_one_type): ... this.
3169
3170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3171
3172         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3173         from...
3174         (rank_one_type): ... this.
3175
3176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3177
3178         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3179         from...
3180         (rank_one_type): ... this.
3181
3182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3183
3184         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3185         from...
3186         (rank_one_type): ... this.
3187
3188 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3189
3190         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3191         inferior-events' shows the example events.
3192
3193 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3194
3195         Support styling on native MS-Windows console
3196
3197         PR/24315
3198         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3199         on MS-Windows if $TERM is not defined.
3200
3201         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3202
3203         * posix-hdep.c (gdb_console_fputs):
3204         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3205         functions.
3206         * ui-file.h (gdb_console_fputs): Add prototype.
3207
3208         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3209         back to fputs only if the former returns zero.
3210
3211 2019-03-07  Tom Tromey  <tom@tromey.com>
3212
3213         * symmisc.c (print_symbol_bcache_statistics): Update.
3214         (print_objfile_statistics): Update.
3215         * symfile.c (allocate_symtab): Update.
3216         * stabsread.c: Don't include bcache.h.
3217         * psymtab.h (struct psymbol_bcache): Don't declare.
3218         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3219         (psymbol_bcache_init, psymbol_bcache_free)
3220         (psymbol_bcache_get_bcache): Don't declare.
3221         * psymtab.c (struct psymbol_bcache): Remove.
3222         (psymtab_storage::psymtab_storage): Update.
3223         (psymtab_storage::~psymtab_storage): Update.
3224         (psymbol_bcache_init, psymbol_bcache_free)
3225         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3226         (add_psymbol_to_bcache): Update.
3227         (allocate_psymtab): Update.
3228         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3229         macro_cache>: No longer pointers.
3230         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3231         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3232         * macrotab.c (macro_bcache): Update.
3233         * macroexp.c: Don't include bcache.h.
3234         * gdbtypes.c (check_types_worklist): Update.
3235         (types_deeply_equal): Remove TRY/CATCH.  Update.
3236         * elfread.c (elf_symtab_read): Update.
3237         * dwarf2read.c: Don't include bcache.h.
3238         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3239         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3240         (print_bcache_statistics, bcache_memory_used): Don't declare.
3241         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3242         methods.  Rename all data members.
3243         * bcache.c (struct bcache): Move to bcache.h.
3244         (bcache::expand_hash_table): Rename from expand_hash_table.
3245         (bcache): Remove.
3246         (bcache::insert): Rename from bcache_full.
3247         (bcache::compare): Rename from bcache_compare.
3248         (bcache_xmalloc): Remove.
3249         (bcache::~bcache): Rename from bcache_xfree.
3250         (bcache::print_statistics): Rename from print_bcache_statistics.
3251         (bcache::memory_used): Rename from bcache_memory_used.
3252
3253 2019-03-07  Pedro Alves  <palves@redhat.com>
3254
3255         * infrun.c (normal_stop): Also check for
3256         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3257
3258 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3259
3260         * f-lang.c (value_from_host_double): Moved to...
3261         * value.c (value_from_host_double): ...here.
3262         * value.h (value_from_host_double): Declare.
3263         * guile/scm-math.c (vlscm_convert_typed_number): Use
3264         value_from_host_double.
3265         (vlscm_convert_number): Likewise.
3266         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3267         * python/py-value.c (convert_value_from_python): Likewise.
3268
3269 2019-03-06  Tom Tromey  <tom@tromey.com>
3270
3271         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3272
3273 2019-03-06  Tom Tromey  <tom@tromey.com>
3274
3275         * utils.h (free_current_contents): Don't declare.
3276         * utils.c (free_current_contents): Remove.
3277
3278 2019-03-06  Tom Tromey  <tom@tromey.com>
3279
3280         * top.c (quit_force): Update.
3281         * main.c (captured_command_loop): Update.
3282         * common/new-op.c (operator new): Update.
3283         * common/common-exceptions.c (struct catcher)
3284         <save_cleanup_chain>: Remove member.
3285         (exceptions_state_mc_init): Update.
3286         (exception_try_scope_entry): Return nullptr.
3287         (exception_try_scope_exit, exception_rethrow)
3288         (throw_exception_sjlj, throw_exception_cxx): Update.
3289         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3290         (all_cleanups, do_cleanups, discard_cleanups)
3291         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3292         (restore_cleanups, restore_final_cleanups): Don't declare.
3293         (do_final_cleanups): Remove parameter.
3294         * common/cleanups.c (cleanup_chain, make_cleanup)
3295         (make_cleanup_dtor, all_cleanups, do_cleanups)
3296         (discard_my_cleanups, discard_cleanups)
3297         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3298         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3299         (null_cleanup): Remove.
3300         (do_final_cleanups): Remove parameter.
3301
3302 2019-03-06  Tom Tromey  <tom@tromey.com>
3303
3304         * remote.c (remote_target::remote_parse_stop_reply): Use
3305         unique_xmalloc_ptr.
3306
3307 2019-03-06  Tom Tromey  <tom@tromey.com>
3308
3309         * stabsread.c (struct stabs_field_info): Rename from field_info.
3310         <list, fnlist>: Add initializers.
3311         <obstack>: New member.
3312         (read_member_functions, read_struct_fields, read_baseclasses):
3313         Allocate on obstack.  Don't use cleanups.
3314         (read_one_struct_field, read_member_functions, read_struct_fields)
3315         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3316         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3317         (read_struct_type): Update.
3318
3319 2019-03-06  Tom Tromey  <tom@tromey.com>
3320
3321         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3322         * common/filestuff.h (make_cleanup_close): Don't declare.
3323         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3324         Remove.
3325
3326 2019-03-06  Tom Tromey  <tom@tromey.com>
3327
3328         * solib-aix.c: Use make_scope_exit.
3329
3330 2019-03-06  Tom Tromey  <tom@tromey.com>
3331
3332         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3333         Use make_scope_exit.
3334
3335 2019-03-06  Tom Tromey  <tom@tromey.com>
3336
3337         * solib-svr4.c (disable_probes_interface): Remove parameter.
3338         (svr4_handle_solib_event): Use make_scope_exit.
3339
3340 2019-03-06  Tom Tromey  <tom@tromey.com>
3341
3342         * remote.c (struct stop_reply_deleter): Remove.
3343         (stop_reply_up): Update.
3344         (struct stop_reply): Derive from notif_event.  Don't typedef.
3345         <regcache>: Now a std::vector.
3346         (stop_reply_xfree): Remove.
3347         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3348         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3349         (remote_target::discard_pending_stop_replies): Use delete.
3350         (remote_target::remote_parse_stop_reply): Update.
3351         (remote_target::process_stop_reply): Update.
3352         * remote-notif.h (struct notif_event): Add virtual destructor.
3353         Remove "dtr" member.
3354         (struct notif_client) <alloc_event>: Return a unique_ptr.
3355         (notif_event_xfree): Don't declare.
3356         (notif_event_up): New typedef.
3357         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3358         (notif_event_xfree, do_notif_event_xfree): Remove.
3359         (remote_notif_state_xfree): Update.
3360
3361 2019-03-06  Tom Tromey  <tom@tromey.com>
3362
3363         * infrun.c (displaced_step_clear_cleanup): Now a
3364         forward_scope_exit type.
3365         (displaced_step_prepare_throw): Update.
3366         (displaced_step_fixup): Update.
3367
3368 2019-03-06  Tom Tromey  <tom@tromey.com>
3369
3370         * inferior.h (class inferior): Update comment.
3371         * gdbthread.h (class thread_info): Update comment.
3372
3373 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3374             Tom Tromey  <tom@tromey.com>
3375
3376         * stabsread.h (struct stab_section_list): Remove.
3377         (coffstab_build_psymtabs): Update.
3378         * dbxread.c (symbuf_sections): Now a std::vector.
3379         (sect_idx): New global.
3380         (fill_symbuf): Update.
3381         (coffstab_build_psymtabs): Change type of stabsects parameter.
3382         Update.
3383         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3384         std::vector.
3385         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3386         (coff_locate_sections): Update.
3387         (coff_symfile_read): Remove cleanups.  Update.
3388         (init_stringtab): Add storage parameter.
3389         (free_stringtab, free_stringtab_cleanup): Remove.
3390         (init_lineno): Add storage parameter.
3391         (free_linetab, free_linetab_cleanup): Remove.
3392
3393 2019-03-06  Pedro Alves  <palves@redhat.com>
3394
3395         * linux-fork.c (fork_info::clobber_regs): Delete.
3396         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3397         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3398         comment.  Adjust.
3399         (scoped_switch_fork_info::scoped_switch_fork_info)
3400         (checkpoint_command, linux_fork_context): Adjust
3401         fork_save_infrun_state calls.
3402
3403 2019-03-06  Pedro Alves  <palves@redhat.com>
3404
3405         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3406         (inf_has_multiple_threads): Return 'bool' and rewrite using
3407         inferior_info::threads().
3408
3409 2019-03-06  Pedro Alves  <palves@redhat.com>
3410
3411         * linux-fork.c: Include <list>.
3412         (fork_list): Now a std::list instance.
3413         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3414         (forks_exist_p, find_last_fork): Adjust.
3415         (new_fork): Delete.
3416         (one_fork_p): New.
3417         (add_fork): Adjust.
3418         (free_fork): Delete, folded into fork_info::~fork_info().
3419         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3420         Adjust.
3421         (init_fork_list): Delete.
3422         (linux_fork_killall, linux_fork_mourn_inferior)
3423         (linux_fork_detach, info_checkpoints_command): Adjust.
3424         (_initialize_linux_fork): No longer call init_fork_list.
3425
3426 2019-03-06  Pedro Alves  <palves@redhat.com>
3427
3428         * linux-fork.c (new_fork): New, split out of ...
3429         (add_fork): ... this.  Return void.  Move "first fork" special
3430         case from here, to ...
3431         (checkpoint_command): ... here.
3432         * linux-linux.h (add_fork): Return void.
3433
3434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3437
3438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3439             Chris January  <chris.january@arm.com>
3440             David Lecomber  <david.lecomber@arm.com>
3441
3442         * f-exp.y: New token, UNOP_INTRINSIC.
3443         (exp): New pattern using UNOP_INTRINSIC token.
3444         (f77_keywords): Add 'abs' keyword.
3445         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3446         (value_from_host_double): New function.
3447         (evaluate_subexp_f): Support UNOP_ABS.
3448
3449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3450
3451         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3452         types.
3453
3454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3457         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3458         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3459
3460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3463
3464 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3465             Chris January  <chris.january@arm.com>
3466
3467         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3468         * f-exp.y: Define 'KIND' token.
3469         (exp): New pattern for KIND expressions.
3470         (ptype): Handle types with a kind extension.
3471         (direct_abs_decl): Extend to spot kind extensions.
3472         (f77_keywords): Add 'kind' to the list.
3473         (push_kind_type): New function.
3474         (convert_to_kind_type): New function.
3475         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3476         * parse.c (operator_length_standard): Likewise.
3477         * parser-defs.h (enum type_pieces): Add tp_kind.
3478         * std-operator.def: Add UNOP_KIND.
3479
3480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * f-exp.y (f_parse): Set yydebug.
3483
3484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * f-lang.c (evaluate_subexp_f): New function.
3487         (exp_descriptor_f): New global.
3488         (f_language_defn): Use exp_descriptor_f instead of
3489         exp_descriptor_standard.
3490
3491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * f-exp.y (struct token): Add comments.
3494         (dot_ops): Remove uppercase versions and the end marker.
3495         (f77_keywords): Likewise.
3496         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3497         entries in the dot_ops array are case insensitive, and use
3498         strncasecmp to compare strings.  Also some whitespace cleanup in
3499         this area.  Similar for the f77_keywords array, except entries in
3500         this list might be case sensitive.
3501
3502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * f-exp.y (struct f77_boolean_val): Add comments.
3505         (boolean_values): Remove uppercase versions, and end marker.
3506         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3507         and use strncasecmp to achieve case insensitivity.  Additionally,
3508         perform whitespace cleanup around this code.
3509
3510 2019-03-06  Tom Tromey  <tromey@adacore.com>
3511
3512         * remote-sim.c (gdbsim_target_open): Use result of
3513         gdb_argv::release.
3514
3515 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3516         Dirk Schubert  <dirk.schubert@arm.com>
3517         Chris January  <chris.january@arm.com>
3518
3519         * eval.c (evaluate_subexp_standard): Call Fortran argument
3520         wrapping logic.
3521         * f-lang.c (struct value): A value which can be passed into a
3522         Fortran function call.
3523         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3524         where appropriate.
3525         (struct type): Value ready for a Fortran function call.
3526         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3527         is needed.
3528         * f-lang.h (fortran_argument_convert): Declaration.
3529         (fortran_preserve_arg_pointer): Declaration.
3530         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3531
3532 2019-03-05  Tom Tromey  <tromey@adacore.com>
3533
3534         * python/py-prettyprint.c (print_string_repr): Remove #if.
3535         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3536
3537 2019-03-05  Tom Tromey  <tromey@adacore.com>
3538
3539         * target.c (the_dummy_target): Move later.  Change type to
3540         "dummy_target".
3541         (initialize_targets): Don't initialize the_dummy_target.
3542
3543 2019-03-05  Tom Tromey  <tromey@adacore.com>
3544
3545         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3546         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3547
3548 2019-03-05  Tom Tromey  <tromey@adacore.com>
3549
3550         * windows-nat.c (windows_nat_target::attach)
3551         (windows_nat_target::detach): Don't call gdb_flush.
3552         * valprint.c (generic_val_print, val_print, val_print_string):
3553         Don't call gdb_flush.
3554         * utils.c (defaulted_query): Don't call gdb_flush.
3555         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3556         * target.c (target_announce_detach): Don't call gdb_flush.
3557         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3558         * remote.c (extended_remote_target::attach): Don't call
3559         gdb_flush.
3560         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3561         * printcmd.c (do_examine): Don't call gdb_flush.
3562         (info_display_command): Don't call gdb_flush.
3563         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3564         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3565         * memattr.c (info_mem_command): Don't call gdb_flush.
3566         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3567         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3568         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3569         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3570         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3571         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3572         (gnu_nat_target::detach): Don't call gdb_flush.
3573         * f-valprint.c (f_val_print): Don't call gdb_flush.
3574         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3575         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3576         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3577         gdb_flush.
3578         * c-valprint.c (c_val_print): Don't call gdb_flush.
3579         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3580
3581 2019-03-05  Tom Tromey  <tromey@adacore.com>
3582
3583         * varobj.c (update_dynamic_varobj_children): Update.
3584         (install_default_visualizer): Use reset, not release.
3585         * value.c (set_internalvar): Update.
3586         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3587         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3588         ATTRIBUTE_UNUSED_RESULT.
3589
3590 2019-03-05  Tom Tromey  <tromey@adacore.com>
3591
3592         * remote.c (class scoped_remote_fd) <release>: Add
3593         ATTRIBUTE_UNUSED_RESULT.
3594
3595 2019-03-05  Tom Tromey  <tromey@adacore.com>
3596
3597         * macroexp.c (struct macro_buffer) <release>: Add
3598         ATTRIBUTE_UNUSED_RESULT.
3599
3600 2019-03-05  Tom Tromey  <tromey@adacore.com>
3601
3602         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3603         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3604         ATTRIBUTE_UNUSED_RESULT.
3605
3606 2019-03-05  Tom Tromey  <tromey@adacore.com>
3607
3608         * common/scoped_fd.h (class scoped_fd) <release>: Add
3609         ATTRIBUTE_UNUSED_RESULT.
3610
3611 2019-03-05  Tom Tromey  <tromey@adacore.com>
3612
3613         * parser-defs.h (struct parser_state) <release>: Add
3614         ATTRIBUTE_UNUSED_RESULT.
3615
3616 2019-03-05  Tom Tromey  <tromey@adacore.com>
3617
3618         * utils.h (class gdb_argv) <release>: Add
3619         ATTRIBUTE_UNUSED_RESULT.
3620         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3621
3622 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3623
3624         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3625         for-loop range, to avoid compiler warnings.
3626
3627         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3628         avoid compiler warnings about unused variables.
3629
3630         * NEWS: Mention end of support for native debugging on MS-Windows
3631         before XP.
3632
3633         PR gdb/24292
3634         * common/netstuff.c:
3635         * gdbserver/gdbreplay.c
3636         * gdbserver/remote-utils.c:
3637         * ser-tcp.c:
3638         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3639         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3640         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3641         'getaddrinfo' and 'freeaddrinfo' were not available before
3642         Windows XP, and mingw.org's MinGW headers by default define
3643         _WIN32_WINNT to 0x500.
3644
3645 2019-03-01  Gary Benson <gbenson@redhat.com>
3646
3647         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3648
3649 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3650             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3651
3652         PR gdb/8527
3653         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3654         set_sigint_trap, clear_sigint_trap.
3655
3656 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3657
3658         * target.c (target_detach): Clear the regcache and the
3659         frame cache.
3660
3661 2019-02-27  Pedro Alves  <palves@redhat.com>
3662
3663         * utils.c (set_screen_size): When we cap the height/width sizes,
3664         tweak the corresponding command variable to show "unlimited":
3665
3666 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3667             Pedro Alves  <palves@redhat.com>
3668
3669         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3670         before calling rl_set_screen_size.
3671
3672 2019-02-27  Tom Tromey  <tromey@adacore.com>
3673
3674         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3675         define.
3676         * python/py-value.c: Remove Python 2.4 workaround.
3677         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3678         workaround.
3679         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3680         Python 2.4 workaround.
3681         * python/python-internal.h: Remove Python 2.4 comment.
3682         (Py_ssize_t): Don't define.
3683         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3684         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3685         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3686         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3687         * python/python.c (do_start_initialization): Remove Python 2.4
3688         workaround.
3689         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3690         (print_children): Remove Python 2.4 workaround.
3691         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3692         workaround.
3693         (CHARBUFFERPROC_NAME): Remove.
3694         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3695         Python 2.4 workaround.
3696
3697 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3698
3699         * NEWS: Note minimum Python version.
3700
3701 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3702
3703         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3704         code from these functions.  Remove corresponding ifdefs.  Use
3705         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3706         Remove gotos and target of gotos.
3707         (infpy_search_memory): Likewise.
3708
3709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3712         (hppa_gdbarch_init): Don't register deleted functions with
3713         gdbarch.
3714
3715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3718         (h8300_unwind_sp): Delete.
3719         (h8300_dummy_id): Delete.
3720         (h8300_gdbarch_init): Don't register deleted functions with
3721         gdbarch.
3722
3723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3726         (ft32_unwind_pc): Delete.
3727         (ft32_unwind_sp): Delete.
3728         (ft32_gdbarch_init): Don't register deleted functions with
3729         gdbarch.
3730
3731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3732
3733         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3734         (frv_unwind_pc): Delete.
3735         (frv_unwind_sp): Delete.
3736         (frv_gdbarch_init): Don't register deleted functions with
3737         gdbarch.
3738
3739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3742         (riscv_unwind_pc): Delete.
3743         (riscv_unwind_sp): Delete.
3744         (riscv_gdbarch_init): Don't register deleted functions with
3745         gdbarch.
3746
3747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3748
3749         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3750         (csky_unwind_pc): Delete.
3751         (csky_unwind_sp): Delete.
3752         (csky_gdbarch_init): Don't register deleted functions with
3753         gdbarch.
3754
3755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3758         (cris_unwind_pc): Delete.
3759         (cris_unwind_sp): Delete.
3760         (cris_gdbarch_init): Don't register deleted functions with
3761         gdbarch.
3762
3763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3766         (bfin_unwind_pc): Delete.
3767         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3768
3769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3772         (arm_unwind_pc): Delete.
3773         (arm_unwind_sp): Delete.
3774         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3775
3776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3779         (arc_unwind_pc): Delete.
3780         (arc_unwind_sp): Delete.
3781         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3782
3783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3786         (alpha_unwind_pc): Delete.
3787         (alpha_gdbarch_init): Don't register deleted functions with
3788         gdbarch.
3789
3790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3793         (aarch64_unwind_pc): Delete.
3794         (aarch64_unwind_sp): Delete.
3795         (aarch64_gdbarch_init): Don't register deleted functions with
3796         gdbarch.
3797
3798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * gdbtypes.c (type_align): Don't consider static members when
3801         computing structure alignment.
3802
3803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3806         return 0 for other types.
3807         * arch-utils.c (default_type_align): Always return 0.
3808         * gdbarch.h: Regenerate.
3809         * gdbarch.sh (type_align): Extend comment.
3810         * gdbtypes.c (type_align): Add additional comments, always call
3811         gdbarch_type_align before applying the default rules.
3812         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3813         generic code will then apply a suitable default.
3814         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3815         types, return 0 for other types.
3816
3817 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3818
3819         * NEWS: Create a new section for the next release branch.
3820         Rename the section of the current branch, now that it has
3821         been cut.
3822
3823 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3824
3825         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3826         * version.in: Bump version to 8.3.50.DATE-git.
3827
3828 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3829
3830         * aix-thread.c (ptid_cmp): Remove unused variable.
3831         (get_signaled_thread): Likewise.
3832         (store_regs_user_thread): Likewise.
3833         (store_regs_kernel_thread): Likewise.
3834         (fetch_regs_kernel_thread): Remove shadowed variable.
3835
3836 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * features/riscv/32bit-cpu.xml: Add register numbers.
3839         * features/riscv/32bit-fpu.c: Regenerate.
3840         * features/riscv/32bit-fpu.xml: Add register numbers.
3841         * features/riscv/64bit-cpu.xml: Add register numbers.
3842         * features/riscv/64bit-fpu.c: Regenerate.
3843         * features/riscv/64bit-fpu.xml: Add register numbers.
3844
3845 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3846
3847         * NEWS: Mention two argument form of gdb.Value constructor.
3848         * python/py-value.c (convert_buffer_and_type_to_value): New
3849         function.
3850         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3851         Add support for handling an optional second argument.  Call
3852         convert_buffer_and_type_to_value as appropriate.
3853         * python/python-internal.h (Py_buffer_deleter): New struct.
3854         (Py_buffer_up): New typedef.
3855
3856 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3857
3858         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3859         instead of releasing ownership.
3860
3861 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3862
3863         * dwarf2read.c (open_and_init_dwp_file): Call
3864         elf_numsections instead of bfd_count_sections to initialize
3865         dwp_file->num_sections.
3866
3867 2019-02-25  Tom Tromey  <tromey@adacore.com>
3868
3869         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3870
3871 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3872
3873         * gcore.in: Add '--readnever' option when invoking GDB.
3874
3875 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3876
3877         * MAINTAINERS: Update my email address.
3878
3879 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3880
3881         * build-id.c (build_id_to_debug_bfd_1): New function.
3882         (build_id_to_debug_bfd): Look for separate debug file in
3883         sysroot.
3884
3885 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * gdbarch.sh: Update the copyright year range that is placed into
3888         generated files.
3889
3890 2019-02-22  Keith Seitz  <keiths@redhat.com>
3891
3892         PR symtab/23853
3893         * linespec.c (create_sals_line_offset): Search for the default
3894         symtab's filename instead of its fullname.
3895
3896 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3897
3898         * NEWS: Update style defaults.
3899
3900 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3901
3902         * main.c (captured_main_1): Disable styling in batch mode.
3903
3904 2019-02-20  Tom Tromey  <tom@tromey.com>
3905
3906         * symtab.c (symtab_symbol_info): Fix typos.
3907
3908 2019-02-20  Tom Tromey  <tromey@adacore.com>
3909
3910         * findcmd.c (_initialize_mem_search): Use upper case for
3911         metasyntactic variables.
3912
3913 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3914
3915         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3916         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3917
3918 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3919
3920         * top.h (source_file_name): Change to std::string.
3921         * top.c (source_file_name): Likewise.
3922         (command_line_input): Adjust.
3923         * cli/cli-script.c (script_from_file): Adjust.
3924
3925 2019-02-19  Tom Tromey  <tromey@adacore.com>
3926
3927         * ravenscar-thread.c
3928         (ravenscar_thread_target::update_thread_list): Don't call
3929         ada_build_task_list.
3930         * ada-lang.h (ada_build_task_list): Don't declare.
3931         * ada-tasks.c (struct ada_tasks_inferior_data)
3932         <task_list_valid_p>: Now bool.
3933         (read_known_tasks, ada_task_list_changed)
3934         (ada_tasks_invalidate_inferior_data): Update.
3935         (read_known_tasks_array): Return bool.
3936         (read_known_tasks_list): Likewise.
3937         (read_known_tasks): Return void.
3938         (ada_build_task_list): Now static.
3939
3940 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3943         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3944
3945 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3946
3947         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3948         variant for ada_tasks_pspace_data_handle and
3949         ada_tasks_inferior_data_handle.
3950         (ada_tasks_pspace_data_cleanup): New function.
3951         (ada_tasks_inferior_data_cleanup): New function.
3952
3953 2019-02-17  Tom Tromey  <tom@tromey.com>
3954
3955         * macrotab.h (macro_source_fullname): Return a std::string.
3956         * macrotab.c (macro_include, check_for_redefinition)
3957         (macro_undef, macro_lookup_definition, foreach_macro)
3958         (foreach_macro_in_scope): Update.
3959         (macro_source_fullname): Return a std::string.
3960         * macrocmd.c (show_pp_source_pos): Update.
3961
3962 2019-02-17  Tom Tromey  <tom@tromey.com>
3963
3964         * macrocmd.c (show_pp_source_pos): Style the file names.
3965
3966 2019-02-17  Tom Tromey  <tom@tromey.com>
3967
3968         PR tui/24197:
3969         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3970
3971 2019-02-17  Tom Tromey  <tom@tromey.com>
3972
3973         * ada-lang.c (user_select_syms): Use filtered printing.
3974         * utils.c (wrap_style): New global.
3975         (desired_style): Remove.
3976         (emit_style_escape): Add stream parameter.
3977         (set_output_style, reset_terminal_style, prompt_for_continue):
3978         Update.
3979         (flush_wrap_buffer): Only flush gdb_stdout.
3980         (wrap_here): Set wrap_style.
3981         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3982         treat escape sequences as a character.  Change when wrap buffer is
3983         flushed.
3984         (fputs_styled): Do not set the output style when the default is
3985         requested.
3986         * ui-style.h (struct ui_file_style) <is_default>: New method.
3987         * source.c (print_source_lines_base): Emit escape sequences in one
3988         piece.
3989
3990 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3991
3992         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3993         integers and enumeration types.
3994
3995 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3996
3997         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3998         instead of lookup_symbol_in_language
3999         (do_exact_match): New function.
4000         (ada_get_symbol_name_matcher): Return do_exact_match when
4001         doing a verbatim match.
4002
4003 2019-02-15  Tom Tromey  <tromey@adacore.com>
4004
4005         * ravenscar-thread.c (ravenscar_thread_target::resume)
4006         (ravenscar_thread_target::wait): Special case wildcard requests.
4007
4008 2019-02-15  Tom Tromey  <tromey@adacore.com>
4009
4010         * ravenscar-thread.c (base_ptid): Remove.
4011         (struct ravenscar_thread_target) <close>: New method.
4012         <m_base_ptid>: New member.
4013         <update_inferior_ptid, active_task, task_is_currently_active,
4014         runtime_initialized>: Declare methods.
4015         <ravenscar_thread_target>: Add constructor.
4016         (ravenscar_thread_target::task_is_currently_active)
4017         (ravenscar_thread_target::update_inferior_ptid)
4018         (ravenscar_runtime_initialized): Rename.  Now methods.
4019         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4020         (ravenscar_thread_target::update_thread_list): Update.
4021         (ravenscar_thread_target::active_task): Now method.
4022         (ravenscar_thread_target::store_registers)
4023         (ravenscar_thread_target::prepare_to_store)
4024         (ravenscar_thread_target::prepare_to_store)
4025         (ravenscar_thread_target::mourn_inferior): Update.
4026         (ravenscar_inferior_created): Use "new" to create target.
4027         (ravenscar_thread_target::get_ada_task_ptid): Update.
4028         (_initialize_ravenscar): Don't initialize base_ptid.
4029         (ravenscar_ops): Remove global.
4030
4031 2019-02-15  Tom Tromey  <tromey@adacore.com>
4032
4033         * target.h (push_target): Declare new overload.
4034         * target.c (push_target): New overload, taking an rvalue reference.
4035         * remote.c (remote_target::open_1): Use push_target overload.
4036         * corelow.c (core_target_open): Use push_target overload.
4037
4038 2019-02-15  Tom Tromey  <tromey@adacore.com>
4039
4040         * ravenscar-thread.c (is_ravenscar_task)
4041         (ravenscar_task_is_currently_active): Return bool.
4042         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4043         (_initialize_ravenscar): Remove "(void)".
4044         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4045         Return bool.
4046
4047 2019-02-15  Tom Tromey  <tromey@adacore.com>
4048
4049         * ravenscar-thread.c (ravenscar_runtime_initializer)
4050         (has_ravenscar_runtime, get_running_thread_id)
4051         (ravenscar_thread_target::resume): Fix indentation.
4052
4053 2019-02-15  Tom Tromey  <tromey@adacore.com>
4054
4055         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4056         from ravenscar_arch_ops.
4057         (sparc_ravenscar_ops::fetch_registers)
4058         (sparc_ravenscar_ops::store_registers): Now methods.
4059         (sparc_ravenscar_prepare_to_store): Remove.
4060         (sparc_ravenscar_ops): Redefine.
4061         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4062         methods and destructor.  Remove members.
4063         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4064         (ravenscar_thread_target::store_registers)
4065         (ravenscar_thread_target::prepare_to_store): Update.
4066         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4067         Remove.
4068         (struct ppc_ravenscar_powerpc_ops): Derive from
4069         ravenscar_arch_ops.
4070         (ppc_ravenscar_powerpc_ops::fetch_registers)
4071         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4072         (ppc_ravenscar_powerpc_ops): Redefine.
4073         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4074         (ppc_ravenscar_e500_ops::fetch_registers)
4075         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4076         (ppc_ravenscar_e500_ops): Redefine.
4077         * aarch64-ravenscar-thread.c
4078         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4079         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4080         (aarch64_ravenscar_fetch_registers)
4081         (aarch64_ravenscar_store_registers): Now methods.
4082         (aarch64_ravenscar_ops): Redefine.
4083
4084 2019-02-15  Tom Tromey  <tromey@adacore.com>
4085
4086         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4087         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4088         (ravenscar_thread_target::stopped_by_watchpoint)
4089         (ravenscar_thread_target::stopped_data_address)
4090         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4091
4092 2019-02-15  Tom Tromey  <tromey@adacore.com>
4093
4094         * ravenscar-thread.c: Fix some typos.
4095
4096 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097             Tom Tromey  <tromey@adacore.com>
4098
4099         * ada-lang.c (ada_exception_sal): Change addr_string to a
4100         std::string.
4101         (create_ada_exception_catchpoint): Update.
4102
4103 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4104             Tom Tromey  <tromey@adacore.com>
4105
4106         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4107         (bp_location_ops): Remove.
4108         (base_breakpoint_allocate_location): Update.
4109         (free_bp_location): Update.
4110         * ada-lang.c (class ada_catchpoint_location)
4111         <ada_catchpoint_location>: Remove ops parameter.
4112         (ada_catchpoint_location_dtor): Remove.
4113         (ada_catchpoint_location_ops): Remove.
4114         (allocate_location_exception): Update.
4115         * breakpoint.h (struct bp_location_ops): Remove.
4116         (class bp_location) <bp_location>: Remove bp_location_ops
4117         parameter.
4118         <~bp_location>: Add destructor.
4119         <ops>: Remove.
4120
4121 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4122             Pedro Alves  <palves@redhat.com>
4123
4124         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4125         'PATH_MAX'.
4126
4127 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4128             Samuel Thibault  <samuel.thibault@gnu.org>
4129             Thomas Schwinge  <thomas@codesourcery.com>
4130
4131         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4132         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4133
4134 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4135
4136         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4137         (check_empty): Use "const char *".
4138
4139         * gnu-nat.c (gnu_nat_target::detach): Instead of
4140         'detach_inferior (pid)' call
4141         'detach_inferior (find_inferior_pid (pid))'.
4142
4143         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4144         'nat/fork-inferior.o'.
4145         * gnu-nat.c: #include "nat/fork-inferior.h".
4146
4147         * gnu-nat.c (gnu_nat_target::detach): Instead of
4148         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4149         * gnu-nat.h: #include "inf-child.h".
4150         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4151         'i386_gnu_nat_target::fetch_registers'.
4152         (gnu_store_registers): Rename/move to
4153         'i386_gnu_nat_target::store_registers'.
4154
4155         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4156         * gnu-nat.h (mach_thread_info): New function.
4157         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4158
4159         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4160
4161 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4162
4163         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4164
4165 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4166
4167         * windows-nat.c (windows_add_thread): Add new parameter
4168         "main_thread_p" with default value set to false.  Update
4169         function documentation as well as all callers.
4170         (windows_delete_thread): Likewise.
4171         (fake_create_process): Update call to windows_add_thread.
4172         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4173         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4174         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4175         call to windows_delete_thread.
4176
4177 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4178
4179         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4180
4181 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4182
4183         * symfile.c (find_separate_debug_file): Use canonical path of
4184         sysroot with child_path instead of gdb_sysroot if it is valid.
4185
4186 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4187
4188         * symfile.c (find_separate_debug_file): Use child_path to
4189         determine if an object file is under a sysroot.
4190
4191 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4192
4193         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4194         unittests/child-path-selftests.c.
4195         * common/pathstuff.c (child_path): New function.
4196         * common/pathstuff.h (child_path): New prototype.
4197         * unittests/child-path-selftests.c: New file.
4198
4199 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4200
4201         * symfile.c (find_separate_debug_file): Look for separate debug
4202         files in debug directories under the sysroot.
4203
4204 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4205
4206         * symtab.h (struct minimal_symbol data_p): New const method.
4207         (struct minimal_symbol text_p): Likewise.
4208         * symtab.c (output_source_filename): Use file name style
4209         to print file name.
4210         (print_symbol_info): Likewise.
4211         (print_msymbol_info): Use address style to print addresses.
4212         Use function name style to print executable text symbols.
4213         (expand_symtab_containing_pc): Use data_p.
4214         (find_pc_sect_compunit_symtab): Likewise.
4215
4216 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4217
4218         * breakpoint.c (describe_other_breakpoints): Use address style
4219         to print addresses.
4220         (say_where): Likewise.
4221
4222 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4223
4224         * ada-typeprint.c (print_func_type): Print function name
4225         style to print function name.
4226         * c-typeprint.c (c_print_type_1): Likewise.
4227
4228 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4229
4230         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4231         for execve.
4232
4233 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4234
4235         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4236         type_stack.
4237
4238 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4239
4240         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4241         TYPE_CODE_REF types.
4242
4243 2019-02-08  Jim Wilson  <jimw@sifive.com>
4244
4245         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4246         (riscv_linux_fregset): New.
4247         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4248
4249 2019-02-07  Tom Tromey  <tom@tromey.com>
4250
4251         * thread.c (thread_cancel_execution_command): Update.
4252         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4253         methods.
4254         (struct thread_fsm_ops): Remove.
4255         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4256         (thread_fsm_should_stop, thread_fsm_return_value)
4257         (thread_fsm_set_finished, thread_fsm_finished_p)
4258         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4259         Don't declare.
4260         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4261         * infrun.c (clear_proceed_status_thread)
4262         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4263         (print_stop_event): Update.
4264         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4265         Add constructor.
4266         (step_command_fsm_ops): Remove.
4267         (new_step_command_fsm): Remove.
4268         (step_1): Update.
4269         (step_command_fsm::should_stop): Rename from
4270         step_command_fsm_should_stop.
4271         (step_command_fsm::clean_up): Rename from
4272         step_command_fsm_clean_up.
4273         (step_command_fsm::do_async_reply_reason): Rename from
4274         step_command_fsm_async_reply_reason.
4275         (struct until_next_fsm): Inherit from thread_fsm.  Add
4276         constructor.
4277         (until_next_fsm_ops): Remove.
4278         (new_until_next_fsm): Remove.
4279         (until_next_fsm::should_stop): Rename from
4280         until_next_fsm_should_stop.
4281         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4282         (until_next_fsm::do_async_reply_reason): Rename from
4283         until_next_fsm_async_reply_reason.
4284         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4285         constructor.  Change type of breakpoint.
4286         (finish_command_fsm_ops): Remove.
4287         (new_finish_command_fsm): Remove.
4288         (finish_command_fsm::should_stop): Rename from
4289         finish_command_fsm_should_stop.
4290         (finish_command_fsm::clean_up): Rename from
4291         finish_command_fsm_clean_up.
4292         (finish_command_fsm::return_value): Rename from
4293         finish_command_fsm_return_value.
4294         (finish_command_fsm::do_async_reply_reason): Rename from
4295         finish_command_fsm_async_reply_reason.
4296         (finish_command): Update.
4297         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4298         Add constructor.
4299         (call_thread_fsm_ops): Remove.
4300         (call_thread_fsm::call_thread_fsm): Rename from
4301         new_call_thread_fsm.
4302         (call_thread_fsm::should_stop): Rename from
4303         call_thread_fsm_should_stop.
4304         (call_thread_fsm::should_notify_stop): Rename from
4305         call_thread_fsm_should_notify_stop.
4306         (run_inferior_call, call_function_by_hand_dummy): Update.
4307         * cli/cli-interp.c (should_print_stop_to_console): Update.
4308         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4309         Add constructor.  Change type of location_breakpoint,
4310         caller_breakpoint.
4311         (until_break_fsm_ops): Remove.
4312         (new_until_break_fsm): Remove.
4313         (until_break_fsm::should_stop): Rename from
4314         until_break_fsm_should_stop.
4315         (until_break_fsm::clean_up): Rename from
4316         until_break_fsm_clean_up.
4317         (until_break_fsm::do_async_reply_reason): Rename from
4318         until_break_fsm_async_reply_reason.
4319         (until_break_command): Update.
4320         * thread-fsm.c: Remove.
4321         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4322
4323 2019-02-07  Tom Tromey  <tom@tromey.com>
4324
4325         * yy-remap.h: Add include guard.
4326         * xtensa-tdep.h: Add include guard.
4327         * xcoffread.h: Rename include guard.
4328         * varobj-iter.h: Add include guard.
4329         * tui/tui.h: Rename include guard.
4330         * tui/tui-winsource.h: Rename include guard.
4331         * tui/tui-wingeneral.h: Rename include guard.
4332         * tui/tui-windata.h: Rename include guard.
4333         * tui/tui-win.h: Rename include guard.
4334         * tui/tui-stack.h: Rename include guard.
4335         * tui/tui-source.h: Rename include guard.
4336         * tui/tui-regs.h: Rename include guard.
4337         * tui/tui-out.h: Rename include guard.
4338         * tui/tui-layout.h: Rename include guard.
4339         * tui/tui-io.h: Rename include guard.
4340         * tui/tui-hooks.h: Rename include guard.
4341         * tui/tui-file.h: Rename include guard.
4342         * tui/tui-disasm.h: Rename include guard.
4343         * tui/tui-data.h: Rename include guard.
4344         * tui/tui-command.h: Rename include guard.
4345         * tic6x-tdep.h: Add include guard.
4346         * target/waitstatus.h: Rename include guard.
4347         * target/wait.h: Rename include guard.
4348         * target/target.h: Rename include guard.
4349         * target/resume.h: Rename include guard.
4350         * target-float.h: Rename include guard.
4351         * stabsread.h: Add include guard.
4352         * rs6000-tdep.h: Add include guard.
4353         * riscv-fbsd-tdep.h: Add include guard.
4354         * regformats/regdef.h: Rename include guard.
4355         * record.h: Rename include guard.
4356         * python/python.h: Rename include guard.
4357         * python/python-internal.h: Rename include guard.
4358         * python/py-stopevent.h: Rename include guard.
4359         * python/py-ref.h: Rename include guard.
4360         * python/py-record.h: Rename include guard.
4361         * python/py-record-full.h: Rename include guard.
4362         * python/py-record-btrace.h: Rename include guard.
4363         * python/py-instruction.h: Rename include guard.
4364         * python/py-events.h: Rename include guard.
4365         * python/py-event.h: Rename include guard.
4366         * procfs.h: Add include guard.
4367         * proc-utils.h: Add include guard.
4368         * p-lang.h: Add include guard.
4369         * or1k-tdep.h: Rename include guard.
4370         * observable.h: Rename include guard.
4371         * nto-tdep.h: Rename include guard.
4372         * nat/x86-linux.h: Rename include guard.
4373         * nat/x86-linux-dregs.h: Rename include guard.
4374         * nat/x86-gcc-cpuid.h: Add include guard.
4375         * nat/x86-dregs.h: Rename include guard.
4376         * nat/x86-cpuid.h: Rename include guard.
4377         * nat/ppc-linux.h: Rename include guard.
4378         * nat/mips-linux-watch.h: Rename include guard.
4379         * nat/linux-waitpid.h: Rename include guard.
4380         * nat/linux-ptrace.h: Rename include guard.
4381         * nat/linux-procfs.h: Rename include guard.
4382         * nat/linux-osdata.h: Rename include guard.
4383         * nat/linux-nat.h: Rename include guard.
4384         * nat/linux-namespaces.h: Rename include guard.
4385         * nat/linux-btrace.h: Rename include guard.
4386         * nat/glibc_thread_db.h: Rename include guard.
4387         * nat/gdb_thread_db.h: Rename include guard.
4388         * nat/gdb_ptrace.h: Rename include guard.
4389         * nat/fork-inferior.h: Rename include guard.
4390         * nat/amd64-linux-siginfo.h: Rename include guard.
4391         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4392         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4393         * nat/aarch64-linux.h: Rename include guard.
4394         * nat/aarch64-linux-hw-point.h: Rename include guard.
4395         * mn10300-tdep.h: Add include guard.
4396         * mips-linux-tdep.h: Add include guard.
4397         * mi/mi-parse.h: Rename include guard.
4398         * mi/mi-out.h: Rename include guard.
4399         * mi/mi-main.h: Rename include guard.
4400         * mi/mi-interp.h: Rename include guard.
4401         * mi/mi-getopt.h: Rename include guard.
4402         * mi/mi-console.h: Rename include guard.
4403         * mi/mi-common.h: Rename include guard.
4404         * mi/mi-cmds.h: Rename include guard.
4405         * mi/mi-cmd-break.h: Rename include guard.
4406         * m2-lang.h: Add include guard.
4407         * location.h: Rename include guard.
4408         * linux-record.h: Rename include guard.
4409         * linux-nat.h: Add include guard.
4410         * linux-fork.h: Add include guard.
4411         * i386-darwin-tdep.h: Rename include guard.
4412         * hppa-linux-offsets.h: Add include guard.
4413         * guile/guile.h: Rename include guard.
4414         * guile/guile-internal.h: Rename include guard.
4415         * gnu-nat.h: Rename include guard.
4416         * gdb-stabs.h: Rename include guard.
4417         * frv-tdep.h: Add include guard.
4418         * f-lang.h: Add include guard.
4419         * event-loop.h: Add include guard.
4420         * darwin-nat.h: Rename include guard.
4421         * cp-abi.h: Rename include guard.
4422         * config/sparc/nm-sol2.h: Rename include guard.
4423         * config/nm-nto.h: Rename include guard.
4424         * config/nm-linux.h: Add include guard.
4425         * config/i386/nm-i386gnu.h: Rename include guard.
4426         * config/djgpp/nl_types.h: Rename include guard.
4427         * config/djgpp/langinfo.h: Rename include guard.
4428         * compile/gcc-cp-plugin.h: Add include guard.
4429         * compile/gcc-c-plugin.h: Add include guard.
4430         * compile/compile.h: Rename include guard.
4431         * compile/compile-object-run.h: Rename include guard.
4432         * compile/compile-object-load.h: Rename include guard.
4433         * compile/compile-internal.h: Rename include guard.
4434         * compile/compile-cplus.h: Rename include guard.
4435         * compile/compile-c.h: Rename include guard.
4436         * common/xml-utils.h: Rename include guard.
4437         * common/x86-xstate.h: Rename include guard.
4438         * common/version.h: Rename include guard.
4439         * common/vec.h: Rename include guard.
4440         * common/tdesc.h: Rename include guard.
4441         * common/selftest.h: Rename include guard.
4442         * common/scoped_restore.h: Rename include guard.
4443         * common/scoped_mmap.h: Rename include guard.
4444         * common/scoped_fd.h: Rename include guard.
4445         * common/safe-iterator.h: Rename include guard.
4446         * common/run-time-clock.h: Rename include guard.
4447         * common/refcounted-object.h: Rename include guard.
4448         * common/queue.h: Rename include guard.
4449         * common/ptid.h: Rename include guard.
4450         * common/print-utils.h: Rename include guard.
4451         * common/preprocessor.h: Rename include guard.
4452         * common/pathstuff.h: Rename include guard.
4453         * common/observable.h: Rename include guard.
4454         * common/netstuff.h: Rename include guard.
4455         * common/job-control.h: Rename include guard.
4456         * common/host-defs.h: Rename include guard.
4457         * common/gdb_wait.h: Rename include guard.
4458         * common/gdb_vecs.h: Rename include guard.
4459         * common/gdb_unlinker.h: Rename include guard.
4460         * common/gdb_unique_ptr.h: Rename include guard.
4461         * common/gdb_tilde_expand.h: Rename include guard.
4462         * common/gdb_sys_time.h: Rename include guard.
4463         * common/gdb_string_view.h: Rename include guard.
4464         * common/gdb_splay_tree.h: Rename include guard.
4465         * common/gdb_setjmp.h: Rename include guard.
4466         * common/gdb_ref_ptr.h: Rename include guard.
4467         * common/gdb_optional.h: Rename include guard.
4468         * common/gdb_locale.h: Rename include guard.
4469         * common/gdb_assert.h: Rename include guard.
4470         * common/filtered-iterator.h: Rename include guard.
4471         * common/filestuff.h: Rename include guard.
4472         * common/fileio.h: Rename include guard.
4473         * common/environ.h: Rename include guard.
4474         * common/common-utils.h: Rename include guard.
4475         * common/common-types.h: Rename include guard.
4476         * common/common-regcache.h: Rename include guard.
4477         * common/common-inferior.h: Rename include guard.
4478         * common/common-gdbthread.h: Rename include guard.
4479         * common/common-exceptions.h: Rename include guard.
4480         * common/common-defs.h: Rename include guard.
4481         * common/common-debug.h: Rename include guard.
4482         * common/cleanups.h: Rename include guard.
4483         * common/buffer.h: Rename include guard.
4484         * common/btrace-common.h: Rename include guard.
4485         * common/break-common.h: Rename include guard.
4486         * cli/cli-utils.h: Rename include guard.
4487         * cli/cli-style.h: Rename include guard.
4488         * cli/cli-setshow.h: Rename include guard.
4489         * cli/cli-script.h: Rename include guard.
4490         * cli/cli-interp.h: Rename include guard.
4491         * cli/cli-decode.h: Rename include guard.
4492         * cli/cli-cmds.h: Rename include guard.
4493         * charset-list.h: Add include guard.
4494         * buildsym-legacy.h: Rename include guard.
4495         * bfin-tdep.h: Add include guard.
4496         * ax.h: Rename include guard.
4497         * arm-linux-tdep.h: Add include guard.
4498         * arm-fbsd-tdep.h: Add include guard.
4499         * arch/xtensa.h: Rename include guard.
4500         * arch/tic6x.h: Add include guard.
4501         * arch/i386.h: Add include guard.
4502         * arch/arm.h: Rename include guard.
4503         * arch/arm-linux.h: Rename include guard.
4504         * arch/arm-get-next-pcs.h: Rename include guard.
4505         * arch/amd64.h: Add include guard.
4506         * arch/aarch64-insn.h: Rename include guard.
4507         * arch-utils.h: Rename include guard.
4508         * annotate.h: Add include guard.
4509         * amd64-darwin-tdep.h: Rename include guard.
4510         * aarch64-linux-tdep.h: Add include guard.
4511         * aarch64-fbsd-tdep.h: Add include guard.
4512         * aarch32-linux-nat.h: Add include guard.
4513
4514 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4515
4516         * macrotab.c (macro_define_internal): New function that
4517         factorizes macro_define_object_internal and macro_define_function
4518         code.
4519         (macro_define_object_internal): Use macro_define_internal.
4520         (macro_define_function): Likewise.
4521
4522 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4523
4524         * macrocmd.c (extract_identifier): Return
4525         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4526         callers.
4527
4528 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4529
4530         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4531
4532 2019-02-05  Tom Tromey  <tom@tromey.com>
4533
4534         * target.c (target_stack::unpush): Move assertion earlier.
4535
4536 2019-01-30  Tom Tromey  <tom@tromey.com>
4537
4538         PR python/23615:
4539         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4540         (gdbpy_parse_and_eval): Likewise.
4541         * python/python-internal.h (gdbpy_allow_threads): New class.
4542
4543 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4544
4545         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4546         (aarch64_fbsd_fpregmap): Move earlier.
4547         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4548         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4549         instead of individual calls to trad_frame_set_reg_addr.
4550         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4551         earlier.
4552         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4553         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4554         instead of individual calls to trad_frame_set_reg_addr.
4555
4556 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4557
4558         * CONTRIBUTE: Replace contribution list with wiki link.
4559
4560 2019-01-25  Tom Tromey  <tom@tromey.com>
4561
4562         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4563
4564 2019-01-25  Tom Tromey  <tom@tromey.com>
4565
4566         * xtensa-linux-nat.c: Fix common/ includes.
4567         * xml-support.h: Fix common/ includes.
4568         * xml-support.c: Fix common/ includes.
4569         * x86-linux-nat.c: Fix common/ includes.
4570         * windows-nat.c: Fix common/ includes.
4571         * varobj.h: Fix common/ includes.
4572         * varobj.c: Fix common/ includes.
4573         * value.c: Fix common/ includes.
4574         * valops.c: Fix common/ includes.
4575         * utils.c: Fix common/ includes.
4576         * unittests/xml-utils-selftests.c: Fix common/ includes.
4577         * unittests/utils-selftests.c: Fix common/ includes.
4578         * unittests/unpack-selftests.c: Fix common/ includes.
4579         * unittests/tracepoint-selftests.c: Fix common/ includes.
4580         * unittests/style-selftests.c: Fix common/ includes.
4581         * unittests/string_view-selftests.c: Fix common/ includes.
4582         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4583         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4584         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4585         * unittests/rsp-low-selftests.c: Fix common/ includes.
4586         * unittests/parse-connection-spec-selftests.c: Fix common/
4587         includes.
4588         * unittests/optional-selftests.c: Fix common/ includes.
4589         * unittests/offset-type-selftests.c: Fix common/ includes.
4590         * unittests/observable-selftests.c: Fix common/ includes.
4591         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4592         * unittests/memrange-selftests.c: Fix common/ includes.
4593         * unittests/memory-map-selftests.c: Fix common/ includes.
4594         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4595         * unittests/function-view-selftests.c: Fix common/ includes.
4596         * unittests/environ-selftests.c: Fix common/ includes.
4597         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4598         * unittests/common-utils-selftests.c: Fix common/ includes.
4599         * unittests/cli-utils-selftests.c: Fix common/ includes.
4600         * unittests/array-view-selftests.c: Fix common/ includes.
4601         * ui-file.c: Fix common/ includes.
4602         * tui/tui-io.c: Fix common/ includes.
4603         * tracepoint.h: Fix common/ includes.
4604         * tracepoint.c: Fix common/ includes.
4605         * tracefile-tfile.c: Fix common/ includes.
4606         * top.h: Fix common/ includes.
4607         * top.c: Fix common/ includes.
4608         * thread.c: Fix common/ includes.
4609         * target/waitstatus.h: Fix common/ includes.
4610         * target/waitstatus.c: Fix common/ includes.
4611         * target.h: Fix common/ includes.
4612         * target.c: Fix common/ includes.
4613         * target-memory.c: Fix common/ includes.
4614         * target-descriptions.c: Fix common/ includes.
4615         * symtab.h: Fix common/ includes.
4616         * symfile.c: Fix common/ includes.
4617         * stap-probe.c: Fix common/ includes.
4618         * spu-linux-nat.c: Fix common/ includes.
4619         * sparc-nat.c: Fix common/ includes.
4620         * source.c: Fix common/ includes.
4621         * solib.c: Fix common/ includes.
4622         * solib-target.c: Fix common/ includes.
4623         * ser-unix.c: Fix common/ includes.
4624         * ser-tcp.c: Fix common/ includes.
4625         * ser-pipe.c: Fix common/ includes.
4626         * ser-base.c: Fix common/ includes.
4627         * selftest-arch.c: Fix common/ includes.
4628         * s12z-tdep.c: Fix common/ includes.
4629         * rust-exp.y: Fix common/ includes.
4630         * rs6000-aix-tdep.c: Fix common/ includes.
4631         * riscv-tdep.c: Fix common/ includes.
4632         * remote.c: Fix common/ includes.
4633         * remote-notif.h: Fix common/ includes.
4634         * remote-fileio.h: Fix common/ includes.
4635         * remote-fileio.c: Fix common/ includes.
4636         * regcache.h: Fix common/ includes.
4637         * regcache.c: Fix common/ includes.
4638         * record-btrace.c: Fix common/ includes.
4639         * python/python.c: Fix common/ includes.
4640         * python/py-type.c: Fix common/ includes.
4641         * python/py-inferior.c: Fix common/ includes.
4642         * progspace.h: Fix common/ includes.
4643         * producer.c: Fix common/ includes.
4644         * procfs.c: Fix common/ includes.
4645         * proc-api.c: Fix common/ includes.
4646         * printcmd.c: Fix common/ includes.
4647         * ppc-linux-nat.c: Fix common/ includes.
4648         * parser-defs.h: Fix common/ includes.
4649         * osdata.c: Fix common/ includes.
4650         * obsd-nat.c: Fix common/ includes.
4651         * nat/x86-linux.c: Fix common/ includes.
4652         * nat/x86-linux-dregs.c: Fix common/ includes.
4653         * nat/x86-dregs.h: Fix common/ includes.
4654         * nat/x86-dregs.c: Fix common/ includes.
4655         * nat/ppc-linux.c: Fix common/ includes.
4656         * nat/mips-linux-watch.h: Fix common/ includes.
4657         * nat/mips-linux-watch.c: Fix common/ includes.
4658         * nat/linux-waitpid.c: Fix common/ includes.
4659         * nat/linux-ptrace.h: Fix common/ includes.
4660         * nat/linux-ptrace.c: Fix common/ includes.
4661         * nat/linux-procfs.c: Fix common/ includes.
4662         * nat/linux-personality.c: Fix common/ includes.
4663         * nat/linux-osdata.c: Fix common/ includes.
4664         * nat/linux-namespaces.c: Fix common/ includes.
4665         * nat/linux-btrace.h: Fix common/ includes.
4666         * nat/linux-btrace.c: Fix common/ includes.
4667         * nat/fork-inferior.c: Fix common/ includes.
4668         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4669         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4670         * nat/aarch64-linux.c: Fix common/ includes.
4671         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4672         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4673         * namespace.h: Fix common/ includes.
4674         * mips-linux-tdep.c: Fix common/ includes.
4675         * minsyms.c: Fix common/ includes.
4676         * mi/mi-parse.h: Fix common/ includes.
4677         * mi/mi-main.c: Fix common/ includes.
4678         * mi/mi-cmd-env.c: Fix common/ includes.
4679         * memrange.h: Fix common/ includes.
4680         * memattr.c: Fix common/ includes.
4681         * maint.h: Fix common/ includes.
4682         * maint.c: Fix common/ includes.
4683         * main.c: Fix common/ includes.
4684         * machoread.c: Fix common/ includes.
4685         * location.c: Fix common/ includes.
4686         * linux-thread-db.c: Fix common/ includes.
4687         * linux-nat.c: Fix common/ includes.
4688         * linux-fork.c: Fix common/ includes.
4689         * inline-frame.c: Fix common/ includes.
4690         * infrun.c: Fix common/ includes.
4691         * inflow.c: Fix common/ includes.
4692         * inferior.h: Fix common/ includes.
4693         * inferior.c: Fix common/ includes.
4694         * infcmd.c: Fix common/ includes.
4695         * inf-ptrace.c: Fix common/ includes.
4696         * inf-child.c: Fix common/ includes.
4697         * ia64-linux-nat.c: Fix common/ includes.
4698         * i387-tdep.c: Fix common/ includes.
4699         * i386-tdep.c: Fix common/ includes.
4700         * i386-linux-tdep.c: Fix common/ includes.
4701         * i386-linux-nat.c: Fix common/ includes.
4702         * i386-go32-tdep.c: Fix common/ includes.
4703         * i386-fbsd-tdep.c: Fix common/ includes.
4704         * i386-fbsd-nat.c: Fix common/ includes.
4705         * guile/scm-type.c: Fix common/ includes.
4706         * guile/guile.c: Fix common/ includes.
4707         * go32-nat.c: Fix common/ includes.
4708         * gnu-nat.c: Fix common/ includes.
4709         * gdbthread.h: Fix common/ includes.
4710         * gdbarch-selftests.c: Fix common/ includes.
4711         * gdb_usleep.c: Fix common/ includes.
4712         * gdb_select.h: Fix common/ includes.
4713         * gdb_bfd.c: Fix common/ includes.
4714         * gcore.c: Fix common/ includes.
4715         * fork-child.c: Fix common/ includes.
4716         * findvar.c: Fix common/ includes.
4717         * fbsd-nat.c: Fix common/ includes.
4718         * event-top.c: Fix common/ includes.
4719         * event-loop.c: Fix common/ includes.
4720         * dwarf2read.c: Fix common/ includes.
4721         * dwarf2loc.c: Fix common/ includes.
4722         * dwarf2-frame.c: Fix common/ includes.
4723         * dwarf-index-cache.c: Fix common/ includes.
4724         * dtrace-probe.c: Fix common/ includes.
4725         * disasm-selftests.c: Fix common/ includes.
4726         * defs.h: Fix common/ includes.
4727         * csky-tdep.c: Fix common/ includes.
4728         * cp-valprint.c: Fix common/ includes.
4729         * cp-support.h: Fix common/ includes.
4730         * cp-support.c: Fix common/ includes.
4731         * corelow.c: Fix common/ includes.
4732         * completer.h: Fix common/ includes.
4733         * completer.c: Fix common/ includes.
4734         * compile/compile.c: Fix common/ includes.
4735         * compile/compile-loc2c.c: Fix common/ includes.
4736         * compile/compile-cplus-types.c: Fix common/ includes.
4737         * compile/compile-cplus-symbols.c: Fix common/ includes.
4738         * command.h: Fix common/ includes.
4739         * cli/cli-dump.c: Fix common/ includes.
4740         * cli/cli-cmds.c: Fix common/ includes.
4741         * charset.c: Fix common/ includes.
4742         * build-id.c: Fix common/ includes.
4743         * btrace.h: Fix common/ includes.
4744         * btrace.c: Fix common/ includes.
4745         * breakpoint.h: Fix common/ includes.
4746         * breakpoint.c: Fix common/ includes.
4747         * ax.h:
4748         (enum agent_op): Fix common/ includes.
4749         * ax-general.c (struct aop_map): Fix common/ includes.
4750         * ax-gdb.c: Fix common/ includes.
4751         * auxv.c: Fix common/ includes.
4752         * auto-load.c: Fix common/ includes.
4753         * arm-tdep.c: Fix common/ includes.
4754         * arch/riscv.c: Fix common/ includes.
4755         * arch/ppc-linux-common.c: Fix common/ includes.
4756         * arch/i386.c: Fix common/ includes.
4757         * arch/arm.c: Fix common/ includes.
4758         * arch/arm-linux.c: Fix common/ includes.
4759         * arch/arm-get-next-pcs.c: Fix common/ includes.
4760         * arch/amd64.c: Fix common/ includes.
4761         * arch/aarch64.c: Fix common/ includes.
4762         * arch/aarch64-insn.c: Fix common/ includes.
4763         * arch-utils.c: Fix common/ includes.
4764         * amd64-windows-tdep.c: Fix common/ includes.
4765         * amd64-tdep.c: Fix common/ includes.
4766         * amd64-sol2-tdep.c: Fix common/ includes.
4767         * amd64-obsd-tdep.c: Fix common/ includes.
4768         * amd64-nbsd-tdep.c: Fix common/ includes.
4769         * amd64-linux-tdep.c: Fix common/ includes.
4770         * amd64-linux-nat.c: Fix common/ includes.
4771         * amd64-fbsd-tdep.c: Fix common/ includes.
4772         * amd64-fbsd-nat.c: Fix common/ includes.
4773         * amd64-dicos-tdep.c: Fix common/ includes.
4774         * amd64-darwin-tdep.c: Fix common/ includes.
4775         * agent.c: Fix common/ includes.
4776         * ada-lang.h: Fix common/ includes.
4777         * ada-lang.c: Fix common/ includes.
4778         * aarch64-tdep.c: Fix common/ includes.
4779
4780 2019-01-25  Tom Tromey  <tom@tromey.com>
4781
4782         * common/create-version.sh: Use common/version.h.
4783
4784 2019-01-24  Pedro Alves  <palves@redhat.com>
4785
4786         * infrun.c (signal_stop, signal_print, signal_program)
4787         (signal_catch, signal_pass): Now arrays instead of pointers.
4788         (update_signals_program_target, do_target_resume)
4789         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4790         * linux-nat.c (linux_nat_target::pass_signals)
4791         (linux_nat_target::create_inferior, linux_nat_target::attach):
4792         Adjust.
4793         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4794         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4795         * procfs.c (procfs_target::pass_signals): Adjust.
4796         * record-full.c (record_full_target::resume): Adjust.
4797         * remote.c (remote_target::pass_signals)
4798         (remote_target::program_signals): Adjust.
4799         * target-debug.h (target_debug_print_signals): Now takes a
4800         gdb::array_view as parameter.  Adjust.
4801         * target.h (target_ops) <pass_signals, program_signals>: Replace
4802         pointer and length parameters with gdb::array_view.
4803         (target_pass_signals, target_program_signals): Likewise.
4804         * target-delegates.c: Regenerate.
4805
4806 2019-01-24  Pedro Alves  <palves@redhat.com>
4807
4808         * common/forward-scope-exit.h
4809         (forward_scope_exit::forward_scope_exit): Pass arguments to
4810         m_bind_function directly, instead of creating a std::bind and
4811         copying that.
4812
4813 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4814
4815         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4816         for static members.
4817         (pass_in_v_vfp_candidate): Likewise.
4818
4819 2019-01-23  Tom Tromey  <tom@tromey.com>
4820             Pedro Alves  <palves@redhat.com>
4821
4822         * regcache.c (class regcache_invalidator): Remove.
4823         (regcache::raw_write): Use make_scope_exit.
4824
4825 2019-01-23  Tom Tromey  <tom@tromey.com>
4826
4827         * ui-out.h (class ui_out_emit_type): Update comment.
4828
4829 2019-01-23  Tom Tromey  <tom@tromey.com>
4830
4831         * infrun.c (fetch_inferior_event): Update comment.
4832
4833 2019-01-23  Tom Tromey  <tom@tromey.com>
4834             Pedro Alves  <palves@redhat.com>
4835
4836         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4837         parameter.
4838         (fetch_inferior_event): Use SCOPE_EXIT.
4839
4840
4841 2019-01-23  Tom Tromey  <tom@tromey.com>
4842             Pedro Alves  <palves@redhat.com>
4843
4844         * infrun.c (disable_thread_events): Delete.
4845         (stop_all_threads): Use SCOPE_EXIT.
4846
4847 2019-01-23  Tom Tromey  <tom@tromey.com>
4848             Pedro Alves  <palves@redhat.com>
4849
4850         * symfile.c: Include forward-scope-exit.h.
4851         (clear_symtab_users_cleanup): Replace forward declaration with
4852         a FORWARD_SCOPE_EXIT.
4853         (syms_from_objfile_1): Use the forward_scope_exit and
4854         gdb::optional instead of cleanup_function.
4855         (reread_symbols): Use the forward_scope_exit instead of
4856         cleanup_function.
4857         (clear_symtab_users_cleanup): Remove function.
4858
4859 2019-01-23  Tom Tromey  <tom@tromey.com>
4860             Pedro Alves  <palves@redhat.com>
4861
4862         * linux-nat.c: Include scope-exit.h.
4863         (cleanup_target_stop): Remove.
4864         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4865         SCOPE_EXIT.
4866
4867 2019-01-23  Tom Tromey  <tom@tromey.com>
4868             Pedro Alves  <palves@redhat.com>
4869
4870         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4871         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4872
4873 2019-01-23  Tom Tromey  <tom@tromey.com>
4874             Andrew Burgess  <andrew.burgess@embecosm.com>
4875             Pedro Alves  <palves@redhat.com>
4876
4877         * infrun.c (fetch_inferior_event): Use scope_exit.
4878         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4879         * top.c (execute_command): Use scope_exit.
4880         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4881         * utils.c (do_bpstat_clear_actions_cleanup)
4882         (make_bpstat_clear_actions_cleanup): Remove.
4883
4884 2019-01-23  Tom Tromey  <tom@tromey.com>
4885             Pedro Alves  <palves@redhat.com>
4886
4887         * infrun.c: Include "common/scope-exit.h"
4888         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4889         (wait_for_inferior): Use SCOPE_EXIT.
4890         (fetch_inferior_event): Use scope_exit.
4891
4892 2019-01-23  Tom Tromey  <tom@tromey.com>
4893             Pedro Alves  <palves@redhat.com>
4894
4895         * breakpoint.c (create_breakpoint): Remove cleanup.
4896
4897 2019-01-23  Tom Tromey  <tom@tromey.com>
4898             Andrew Burgess  <andrew.burgess@embecosm.com>
4899             Pedro Alves  <palves@redhat.com>
4900
4901 2019-01-23  Pedro Alves  <palves@redhat.com>
4902
4903         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4904
4905 2019-01-23  Pedro Alves  <palves@redhat.com>
4906             Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * gdbthread.h: Include "common/forward-scope-exit.h".
4909         (scoped_finish_thread_state): Redefine custom class in terms of
4910         forward_scope_exit.
4911
4912 2019-01-23  Pedro Alves  <palves@redhat.com>
4913             Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * common/forward-scope-exit.h: New file.
4916
4917 2019-01-23  Pedro Alves  <palves@redhat.com>
4918             Andrew Burgess  <andrew.burgess@embecosm.com>
4919             Tom Tromey  <tom@tromey.com>
4920
4921         * common/scope-exit.h: New file.
4922
4923 2019-01-23  Pedro Alves  <palves@redhat.com>
4924
4925         * common/preprocessor.h (ESC): Rename to ...
4926         (ESC_PARENS): ... this.
4927         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4928         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4929
4930 2019-01-23  Tom Tromey  <tom@tromey.com>
4931
4932         * language.h (class scoped_switch_to_sym_language_if_auto):
4933         Initialize m_lang in both cases.
4934
4935 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4936
4937         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4938         with XCNEW.
4939
4940 2019-01-22  Tom Tromey  <tom@tromey.com>
4941
4942         * corelow.c: Do not include sys/file.h.
4943
4944 2019-01-22  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-wingeneral.h: Include gdb_curses.h.
4947
4948 2019-01-22  Tom Tromey  <tom@tromey.com>
4949
4950         * source-cache.h (class source_cache) <get_source_lines,
4951         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4952
4953 2019-01-22  Tom Tromey  <tom@tromey.com>
4954
4955         * remote-fileio.h (struct remote_target): Declare.
4956
4957 2019-01-22  Tom Tromey  <tom@tromey.com>
4958
4959         * python/py-arch.c: Do not include py-ref.h.
4960         * python/py-bpevent.c: Do not include py-ref.h.
4961         * python/py-cmd.c: Do not include py-ref.h.
4962         * python/py-continueevent.c: Do not include py-ref.h.
4963         * python/py-event.h: Do not include py-ref.h.
4964         * python/py-evtregistry.c: Do not include py-ref.h.
4965         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4966         * python/py-frame.c: Do not include py-ref.h.
4967         * python/py-framefilter.c: Do not include py-ref.h.
4968         * python/py-function.c: Do not include py-ref.h.
4969         * python/py-infevents.c: Do not include py-ref.h.
4970         * python/py-linetable.c: Do not include py-ref.h.
4971         * python/py-objfile.c: Do not include py-ref.h.
4972         * python/py-param.c: Do not include py-ref.h.
4973         * python/py-prettyprint.c: Do not include py-ref.h.
4974         * python/py-progspace.c: Do not include py-ref.h.
4975         * python/py-symbol.c: Do not include py-ref.h.
4976         * python/py-symtab.c: Do not include py-ref.h.
4977         * python/py-type.c: Do not include py-ref.h.
4978         * python/py-unwind.c: Do not include py-ref.h.
4979         * python/py-utils.c: Do not include py-ref.h.
4980         * python/py-value.c: Do not include py-ref.h.
4981         * python/py-varobj.c: Do not include py-ref.h.
4982         * python/py-xmethods.c: Do not include py-ref.h.
4983         * python/python.c: Do not include py-ref.h.
4984         * varobj.c: Do not include py-ref.h.
4985
4986 2019-01-22  Tom Tromey  <tom@tromey.com>
4987
4988         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4989         keyword for bcache.
4990
4991 2019-01-22  Tom Tromey  <tom@tromey.com>
4992
4993         * compile/compile-cplus-types.c: Remove a comment by #include.
4994
4995 2019-01-22  Tom Tromey  <tom@tromey.com>
4996
4997         * compile/gcc-c-plugin.h: Include compile-internal.h.
4998
4999 2019-01-22  Tom Tromey  <tom@tromey.com>
5000
5001         * stabsread.c (EXTERN): Do not define.
5002         (symnum, next_symbol_text_func, processing_gcc_compilation)
5003         (within_function, global_sym_chain, global_stabs)
5004         (previous_stab_code, this_object_header_files)
5005         (n_this_object_header_files)
5006         (n_allocated_this_object_header_files): Define.
5007         * stabsread.h (EXTERN): Never define.  Use "extern".
5008
5009 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5010
5011         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5012         history_value.
5013
5014 2019-01-21  Tom Tromey  <tom@tromey.com>
5015
5016         * ui-out.c: Fix includes.
5017         * tui/tui-source.c: Fix includes.
5018         * target.c: Fix includes.
5019         * remote.c: Fix includes.
5020         * regcache.c: Fix includes.
5021         * python/py-block.c: Fix includes.
5022         * printcmd.c: Fix includes.
5023         * or1k-tdep.c: Fix includes.
5024         * mi/mi-main.c: Fix includes.
5025         * m32r-tdep.c: Fix includes.
5026         * csky-tdep.c: Fix includes.
5027         * compile/compile-cplus-types.c: Fix includes.
5028         * cli/cli-interp.c: Fix includes.
5029
5030 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5031
5032         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5033         for padding.
5034
5035 2019-01-16  Tom Tromey  <tom@tromey.com>
5036
5037         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5038         earlier.
5039         (struct objfile) <msymbols_range>: Move from top level.
5040         <msymbols>: New method.
5041         (class objfile_msymbols): Remove.
5042         * symtab.c (default_collect_symbol_completion_matches_break_on):
5043         Update.
5044         * symmisc.c (dump_msymbols): Update.
5045         * stabsread.c (scan_file_globals): Update.
5046         * objc-lang.c (info_selectors_command, info_classes_command)
5047         (find_methods): Update.
5048         * minsyms.c (find_solib_trampoline_target): Update.
5049         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5050         * coffread.c (coff_symfile_read): Update.
5051         * ada-lang.c (ada_lookup_simple_minsym)
5052         (ada_collect_symbol_completion_matches): Update.
5053
5054 2019-01-16  Tom Tromey  <tom@tromey.com>
5055
5056         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5057         type.  Remove no-argument constructor.
5058         <iterator::operator++>: Simplify.
5059         <begin>: Update.
5060         <end>: Use minimal_symbol_count.
5061
5062 2019-01-16  Tom Tromey  <tom@tromey.com>
5063
5064         * objfiles.h (struct objfile) <psymtabs>: New method.
5065         (class objfile_psymtabs): Remove.
5066         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5067         typedef.
5068         <range>: New method.
5069         (require_partial_symbols): Change return type.
5070         * psymtab.c (require_partial_symbols)
5071         (psym_expand_symtabs_matching): Update.
5072         * mdebugread.c (parse_partial_symbols): Update.
5073         * dbxread.c (dbx_end_psymtab): Update.
5074
5075 2019-01-15  Tom Tromey  <tom@tromey.com>
5076
5077         * symtab.c (lookup_objfile_from_block)
5078         (lookup_symbol_in_objfile_symtabs)
5079         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5080         (find_line_symtab, info_sources_command)
5081         (default_collect_symbol_completion_matches_break_on)
5082         (make_source_files_completion_list): Update.
5083         * symmisc.c (print_objfile_statistics, dump_objfile)
5084         (maintenance_print_symbols, maintenance_info_symtabs)
5085         (maintenance_check_symtabs, maintenance_info_line_tables):
5086         Update.
5087         * source.c (select_source_symtab)
5088         (forget_cached_source_info_for_objfile): Update.
5089         * objfiles.h (class objfile_compunits): Remove.
5090         (struct objfile) <compunits_range>: New typedef.
5091         (compunits): New method.
5092         * objfiles.c (objfile_relocate1): Update.
5093         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5094         * maint.c (count_symtabs_and_blocks): Update.
5095         * linespec.c (iterate_over_all_matching_symtabs): Update.
5096         * cp-support.c (add_symbol_overload_list_qualified): Update.
5097         * coffread.c (coff_symtab_read): Update.
5098         * ada-lang.c (add_nonlocal_symbols)
5099         (ada_collect_symbol_completion_matches)
5100         (ada_add_global_exceptions): Update.
5101
5102 2019-01-15  Tom Tromey  <tom@tromey.com>
5103
5104         * progspace.h (program_space) <objfiles_safe_range>: New
5105         typedef.
5106         <objfiles_safe>: New method.
5107         * objfiles.h (class all_objfiles_safe): Remove.
5108         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5109         * jit.c (jit_inferior_exit_hook): Update.
5110
5111 2019-01-17  Tom Tromey  <tom@tromey.com>
5112
5113         * progspace.h (program_space) <objfiles_range>: New typedef.
5114         <objfiles>: New method.
5115         <objfiles_head>: Rename from objfiles.
5116         (object_files): Update.
5117         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5118         * guile/scm-pretty-print.c
5119         (ppscm_find_pretty_printer_from_objfiles): Update.
5120         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5121         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5122         Update.
5123         * python/py-progspace.c (pspy_get_objfiles): Update.
5124         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5125         Update.
5126         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5127         (objfpy_lookup_objfile_by_build_id): Update.
5128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5129         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5130         Update.
5131         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5132         (expand_symtab_containing_pc, lookup_objfile_from_block)
5133         (lookup_static_symbol, basic_lookup_transparent_type)
5134         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5135         (find_line_symtab, info_sources_command)
5136         (default_collect_symbol_completion_matches_break_on)
5137         (make_source_files_completion_list, find_main_name): Update.
5138         * symmisc.c (print_symbol_bcache_statistics)
5139         (print_objfile_statistics, maintenance_print_symbols)
5140         (maintenance_print_msymbols, maintenance_print_objfiles)
5141         (maintenance_info_symtabs, maintenance_check_symtabs)
5142         (maintenance_expand_symtabs, maintenance_info_line_tables):
5143         Update.
5144         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5145         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5146         (map_overlay_command, unmap_overlay_command)
5147         (simple_overlay_update, expand_symtabs_matching)
5148         (map_symbol_filenames): Update.
5149         * symfile-debug.c (set_debug_symfile): Update.
5150         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5151         Update.
5152         * source.c (select_source_symtab, forget_cached_source_info):
5153         Update.
5154         * solib.c (solib_read_symbols): Update.
5155         * solib-spu.c (append_ocl_sos): Update.
5156         * psymtab.c (maintenance_print_psymbols)
5157         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5158         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5159         * printcmd.c (info_symbol_command): Update.
5160         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5161         Update.
5162         * objfiles.h (class all_objfiles): Remove.
5163         * objfiles.c (have_partial_symbols, have_full_symbols)
5164         (have_minimal_symbols, qsort_cmp, update_section_map)
5165         (shared_objfile_contains_address_p)
5166         (default_iterate_over_objfiles_in_search_order): Update.
5167         * objc-lang.c (info_selectors_command, info_classes_command)
5168         (find_methods): Update.
5169         * minsyms.c (find_solib_trampoline_target): Update.
5170         * maint.c (maintenance_info_sections)
5171         (maintenance_translate_address, count_symtabs_and_blocks):
5172         Update.
5173         * main.c (captured_main_1): Update.
5174         * linux-thread-db.c (try_thread_db_load_from_pdir)
5175         (has_libpthread): Update.
5176         * linespec.c (iterate_over_all_matching_symtabs)
5177         (search_minsyms_for_name): Update.
5178         * jit.c (jit_find_objf_with_entry_addr): Update.
5179         * hppa-tdep.c (find_unwind_entry)
5180         (hppa_lookup_stub_minimal_symbol): Update.
5181         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5182         Update.
5183         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5184         (elf_gnu_ifunc_resolve_by_got): Update.
5185         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5186         * dwarf-index-write.c (save_gdb_index_command): Update.
5187         * cp-support.c (add_symbol_overload_list_qualified): Update.
5188         * breakpoint.c (create_overlay_event_breakpoint)
5189         (create_longjmp_master_breakpoint)
5190         (create_std_terminate_master_breakpoint)
5191         (create_exception_master_breakpoint): Update.
5192         * blockframe.c (find_pc_partial_function): Update.
5193         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5194         (ada_collect_symbol_completion_matches)
5195         (ada_add_global_exceptions): Update.
5196
5197 2019-01-17  Tom Tromey  <tom@tromey.com>
5198
5199         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5200         declare VEC.
5201         (solib_target_parse_libraries): Change return type.
5202         (library_list_start_segment, library_list_start_section)
5203         (library_list_end_library, library_list_start_library); Update.
5204         (solib_target_free_library_list): Remove.
5205         (solib_target_parse_libraries): Remove cleanup.  Change return
5206         type.
5207         (solib_target_current_sos): Update.
5208
5209 2019-01-17  Tom Tromey  <tromey@bapiya>
5210
5211         * valprint.c: Replace "the the" with "the".
5212         * symtab.c: Replace "the the" with "the".
5213         * solib.c: Replace "the the" with "the".
5214         * solib-dsbt.c: Replace "the the" with "the".
5215         * linespec.c: Replace "the the" with "the".
5216         * dwarf2loc.h: Replace "the the" with "the".
5217         * amd64-windows-tdep.c: Replace "the the" with "the".
5218         * aarch64-tdep.c: Replace "the the" with "the".
5219
5220 2019-01-16  Keith Seitz  <keiths@redhat.com>
5221
5222         PR gdb/23773
5223         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5224         <builder>: Rename to ..
5225         <m_builder>: ... this and make private.
5226         (dwarf2_cu::get_builder): New method.  Change all users of
5227         `builder' to use this method.
5228         (dwarf2_start_symtab): Move to ...
5229         (dwarf2_cu::start_symtab): ... here.  Update all callers
5230         (setup_type_unit_groups): Move to ...
5231         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5232         callers.
5233         (dwarf2_cu::reset_builder): New method.
5234         (process_full_compunit, process_full_type_unit): Use
5235         dwarf2_cu::reset_builder.
5236         (follow_die_offset): Record the ancestor CU if it is different
5237         from the followed DIE's CU.
5238         (follow_die_sig_1): Likewise.
5239
5240 2019-01-15  Tom Tromey  <tom@tromey.com>
5241
5242         * remote.c (class remote_state) <buf>: Now a char_vector.
5243         <buf_size>: Remove.
5244         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5245         parameter.
5246         (remote_target::getpkt_or_notif_sane_1)
5247         (remote_target::getpkt_sane)
5248         (remote_target::getpkt_or_notif_sane): Likewise.
5249         (class remote_target) <putpkt>: New overload.
5250         (remote_target::read_frame): Change type of "buf_p".  Remove
5251         sizeof_p parameter.
5252         (packet_ok): New overload.
5253         (packet_check_result): New overload.
5254         Update all uses.
5255
5256 2019-01-14  Tom Tromey  <tom@tromey.com>
5257
5258         * remote-notif.c (handle_notification, remote_notif_ack)
5259         (remote_notif_parse): Make "buf" const.
5260         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5261         const.
5262         (remote_notif_parse, remote_notif_ack, handle_notification):
5263         Likewise.
5264         * remote.c (remote_notif_stop_parse): Make "buf" const.
5265         (remote_target::remote_parse_stop_reply): Make "buf" const.
5266         (remote_notif_stop_ack): Make "buf" const.
5267
5268 2019-01-14  Tom Tromey  <tom@tromey.com>
5269
5270         * remote.c (remote_console_output): Make parameter const.
5271
5272 2019-01-14  Tom Tromey  <tom@tromey.com>
5273
5274         * target-debug.h (target_debug_print_signals): Constify.
5275         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5276         * procfs.c (procfs_target::pass_signals): Update.
5277         * linux-nat.c (linux_nat_target::pass_signals): Update.
5278         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5279         * target-delegates.c: Rebuild.
5280         * remote.c (remote_target::program_signals): Update.
5281         (remote_target::pass_signals): Update.
5282         * target.c (target_pass_signals): Constify argument.
5283         (target_program_signals): Likewise.
5284         * target.h (struct target_ops) <pass_signals, program_signals>:
5285         Constify argument.
5286         (target_pass_signals, target_program_signals): Constify argument.
5287
5288 2019-01-14  Tom Tromey  <tom@tromey.com>
5289
5290         PR tui/28819:
5291         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5292
5293 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5294
5295         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5296         field.
5297         * rs6000-tdep.c: Include reggroups.h.
5298         (IS_V_ALIAS_PSEUDOREG): Define.
5299         (rs6000_register_name): Return names for the "vX" aliases.
5300         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5301         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5302         aliases.  Call default_register_reggroup_p for all other
5303         pseudo-registers.
5304         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5305         New functions.
5306         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5307         Handle "vX" aliases.
5308         (v_alias_pseudo_register_collect): New function.
5309         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5310         (rs6000_gdbarch_init): Initialize "vX" aliases as
5311         pseudo-registers.  Restore registration of
5312         rs6000_pseudo_register_reggroup_p with
5313         set_tdesc_pseudo_register_reggroup_p.
5314
5315 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5316
5317         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5318         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5319         set_gdbarch_num_pseudo_regs.
5320
5321 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5322
5323         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5324         Remove arg prefixname, add do_set and do_show.
5325         Add member functions set_list and show_list.
5326         * cli/cli-style.c (class cli_style_option): Update accordingly.
5327         (style_set_list): Move to file scope.
5328         (style_show_list): Likewise.
5329         (set_style): Call help_list.
5330         (show_style): Call cmd_show_list.
5331         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5332         Update to use the new macro.
5333
5334 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5335
5336         * ada-lang.c (_initialize_ada_language): Expand the help text
5337         for the "catch exception" command.
5338
5339 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5340
5341         * symtab.c (matching_obj_sections): Initialize obj,
5342         declare it closer to its usage.
5343
5344 2019-01-10  Tom Tromey  <tom@tromey.com>
5345
5346         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5347         (basic_inf_threads_range): Remove.
5348         (inf_threads_range, inf_non_exited_threads_range)
5349         (safe_inf_threads_range): Use next_adapter.
5350
5351 2019-01-10  Keith Seitz  <keiths@redhat.com>
5352
5353         PR gdb/23712
5354         PR symtab/23010
5355         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5356         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5357
5358 2019-01-10  Keith Seitz  <keiths@redhat.com>
5359
5360         PR gdb/23712
5361         PR symtab/23010
5362         * dictionary.c (pending_to_vector): Remove.
5363         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5364         Remove _1 suffix, replacing functions of the same name.  Update
5365         all callers.
5366         (dict_create_hashed, dict_create_hashed_expandable)
5367         (dict_create_linear, dict_create_linear_expandable, dict_free)
5368         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5369         Make functions static.
5370
5371 2019-01-10  Keith Seitz  <keiths@redhat.com>
5372
5373         PR gdb/23712
5374         PR symtab/23010
5375         * dictionary.h (struct dictionary): Replace declaration with
5376         multidictionary.
5377         (dict_create_hashed, dict_create_hashed_expandable)
5378         (dict_create_linear, dict_create_linear_expandable)
5379         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5380         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5381         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5382         taking multidictionary argument.
5383         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5384         * block.h (struct block) <dict>: Change to multidictionary
5385         and rename `multidict'.
5386         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5387         symmisc.c: Update all dictionary references to multidictionary.
5388
5389 2019-01-10  Keith Seitz  <keiths@redhat.com>
5390
5391         PR gdb/23712
5392         PR symtab/23010
5393         * dictionary.c: Include unordered_map.
5394         (pending_to_vector): New function.
5395         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5396         Rewrite the non-"_1" functions to take vector instead
5397         of linked list.
5398         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5399         "new" _1 versions of the same name.
5400         (multidictionary): Define.
5401         (std::hash<enum language): New definition.
5402         (collate_pending_symbols_by_language, mdict_create_hashed)
5403         (mdict_create_hashed_expandable, mdict_create_linear)
5404         (mdict_create_linear_expandable, mdict_free)
5405         (find_language_dictionary, create_new_language_dictionary)
5406         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5407         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5408         (mdict_size, mdict_empty): New functions.
5409         * dictionary.h (mdict_iterator): Define.
5410
5411 2019-01-10  Pedro Alves  <palves@redhat.com>
5412
5413         * breakpoint.c (read_uploaded_action)
5414         (create_tracepoint_from_upload): Adjust to use
5415         gdb::unique_xmalloc_ptr.
5416         * ctf.c (ctf_write_uploaded_tp):
5417         (SET_ARRAY_FIELD): Use emplace_back.
5418         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5419         * tracefile-tfile.c (tfile_write_uploaded_tp):
5420         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5421         gdb::unique_xmalloc_ptr.
5422         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5423         at_string, cond_string, cmd_strings>: Replace char pointers
5424         with gdb::unique_xmalloc_ptr.
5425
5426 2019-01-10  Pedro Alves  <palves@redhat.com>
5427
5428         * solib-target.c (library_list_start_library): Don't xstrdup name.
5429
5430 2019-01-10  Pedro Alves  <palves@redhat.com>
5431
5432         * mdebugread.c (parse_partial_symbols): Use
5433         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5434
5435 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5436
5437         * linux-fork.c (scoped_switch_fork_info)
5438         <~scoped_switch_fork_info>: Fix incorrect variable name.
5439
5440 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * linux-fork.c (scoped_switch_fork_info)
5443         <scoped_switch_fork_info>: Make explicit.
5444         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5445
5446 2019-01-10  Tom Tromey  <tom@tromey.com>
5447
5448         * objfiles.h (objfile::reset_psymtabs): Update.
5449         * objfiles.c (objfile::objfile): Update.
5450         * psymtab.h (psymtab_storage::obstack): Update.
5451         (psymtab_storage::m_obstack): Use gdb::optional.
5452         (class psymtab_storage): Update comment.  Remove objfile
5453         parameter.
5454         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5455
5456 2019-01-10  Tom Tromey  <tom@tromey.com>
5457
5458         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5459         <free_psymtabs>: Now private.
5460         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5461         (allocate_psymtab): Use new method.
5462
5463 2019-01-10  Tom Tromey  <tom@tromey.com>
5464
5465         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5466         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5467         * mdebugread.c (parse_partial_symbols): Use
5468         allocate_dependencies.
5469         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5470         allocate_dependencies.
5471         (process_psymtab_comp_unit_reader)
5472         (build_type_psymtab_dependencies): Likewise.
5473         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5474
5475 2019-01-10  Tom Tromey  <tom@tromey.com>
5476
5477         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5478         PSYMBOL_SET_LANGUAGE.
5479         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5480
5481 2019-01-10  Tom Tromey  <tom@tromey.com>
5482
5483         * psymtab.h (psymtab_storage::obstack): New method.
5484         <m_obstack>: Rename from obstack; now private.
5485         * psymtab.c (psymtab_storage): Update.
5486         * dwarf2read.c (create_addrmap_from_index)
5487         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5488         Update.
5489
5490 2019-01-10  Tom Tromey  <tom@tromey.com>
5491
5492         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5493         * objfiles.h (objfile::reset_psymtabs): New method.
5494
5495 2019-01-10  Tom Tromey  <tom@tromey.com>
5496
5497         * symmisc.c (print_symbol_bcache_statistics): Update.
5498         (print_objfile_statistics): Update.
5499         * symfile.c (reread_symbols): Update.
5500         * psymtab.h (class psymtab_storage): New.
5501         * psymtab.c (psymtab_storage): New constructor.
5502         (~psymtab_storage): New destructor.
5503         (require_partial_symbols): Update.
5504         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5505         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5506         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5507         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5508         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5509         (start_psymtab_common, end_psymtab_common)
5510         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5511         (allocate_psymtab): Update.
5512         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5513         Update.
5514         (dump_psymtab_addrmap, maintenance_print_psymbols)
5515         (maintenance_check_psymtabs): Update.
5516         (class objfile_psymtabs): Move to objfiles.h.
5517         * psympriv.h (discard_psymtab): Now inline.
5518         (psymtab_discarder::psymtab_discarder): Update.
5519         (psymtab_discarder::~psymtab_discarder): Update.
5520         (ALL_OBJFILE_PSYMTABS): Rewrite.
5521         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5522         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5523         Remove fields.
5524         <partial_symtabs>: New field.
5525         (class objfile_psymtabs): Move from psymtab.h.  Update.
5526         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5527         psymbol_cache.
5528         (objfile::~objfile): Don't destroy psymbol_cache.
5529         * mdebugread.c (parse_partial_symbols): Update.
5530         * dwarf2read.c (create_addrmap_from_index)
5531         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5532         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5533         (add_partial_subprogram, dwarf2_ranges_read): Update.
5534         * dwarf-index-write.c (write_address_map)
5535         (write_one_signatured_type, recursively_write_psymbols)
5536         (class debug_names, class debug_names, write_psymtabs_to_index):
5537         Update.
5538
5539 2019-01-10  Tom Tromey  <tom@tromey.com>
5540
5541         * symtab.h (SYMBOL_SET_NAMES): Update.
5542         (symbol_set_names): Update.
5543         (MSYMBOL_SET_NAMES): Update.
5544         * symtab.c (symbol_set_names): Change argument to be an
5545         objfile_per_bfd_storage.
5546         * psymtab.c (add_psymbol_to_bcache): Update.
5547         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5548
5549 2019-01-10  Tom Tromey  <tom@tromey.com>
5550
5551         * symtab.c (create_demangled_names_hash): Change argument to be an
5552         objfile_per_bfd_storage.
5553         (symbol_set_names): Update.
5554
5555 2019-01-10  Tom Tromey  <tom@tromey.com>
5556
5557         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5558         init_psymbol_list.
5559         * psymtab.c (init_psymbol_list): Do nothing if already called.
5560         * psympriv.h (init_psymbol_list): Add comment.
5561         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5562         init_psymbol_list.
5563         * dbxread.c (dbx_symfile_read): Unconditionally call
5564         init_psymbol_list.
5565
5566 2019-01-10  Tom Tromey  <tom@tromey.com>
5567
5568         * xcoffread.c (scan_xcoff_symtab): Update.
5569         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5570         "where".
5571         * mdebugread.c (parse_partial_symbols)
5572         (handle_psymbol_enumerators): Update.
5573         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5574         * dbxread.c (read_dbx_symtab): Update.
5575         * psympriv.h (psymbol_placement): New enum.
5576         (add_psymbol_to_list): Update.
5577
5578 2019-01-10  Tom Tromey  <tom@tromey.com>
5579
5580         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5581         static_psymbols parameters.
5582         (scan_xcoff_symtab): Update.
5583         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5584         static_psymbols parameters.
5585         * psympriv.h (start_psymtab_common): Update.
5586         * mdebugread.c (parse_partial_symbols): Update.
5587         * dwarf2read.c (create_partial_symtab): Update.
5588         * dbxread.c (read_dbx_symtab): Update.
5589         (start_psymtab): Remove global_psymbols and static_psymbols
5590         parameters.
5591
5592 2019-01-10  Tom Tromey  <tom@tromey.com>
5593
5594         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5595         * psymtab.c (allocate_psymtab): Add comment.
5596         * psympriv.h (allocate_psymtab): Add comment.
5597         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5598         initializations.
5599         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5600
5601 2019-01-10  Tom Tromey  <tom@tromey.com>
5602
5603         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5604         Don't declare.
5605         * mipsread.c: Include mdebugread.h.
5606         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5607         Declare.
5608         * elfread.c: Include mdebugread.h.
5609
5610 2019-01-09  Tom Tromey  <tom@tromey.com>
5611
5612         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5613         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5614         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5615         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5616         (psym_lookup_symbol, psym_find_last_source_symtab)
5617         (psym_forget_cached_source_info, psym_print_stats)
5618         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5619         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5620         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5621         (psym_find_compunit_symtab_by_address)
5622         (maintenance_print_psymbols, maintenance_info_psymtabs)
5623         (maintenance_check_psymtabs): Use ranged for.
5624         * psymtab.h (class objfile_psymtabs): New.
5625         (require_partial_symbols): Return objfile_psymtabs.
5626         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5627
5628 2019-01-09  Tom Tromey  <tom@tromey.com>
5629
5630         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5631         (find_pc_mapped_section, list_overlays_command)
5632         (map_overlay_command, unmap_overlay_command)
5633         (simple_overlay_update): Use all_objfiles.
5634         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5635         * printcmd.c (info_symbol_command): Use all_objfiles.
5636         * objfiles.h (ALL_OBJSECTIONS): Remove.
5637         * maint.c (maintenance_translate_address): Use all_objfiles.
5638         * gcore.c (gcore_create_callback): Use all_objfiles.
5639         (objfile_find_memory_regions): Likewise.
5640
5641 2019-01-09  Tom Tromey  <tom@tromey.com>
5642
5643         * symtab.c (find_line_symtab, info_sources_command)
5644         (make_source_files_completion_list): Use objfile_compunits.
5645         * source.c (select_source_symtab): Use objfile_compunits.
5646         * objfiles.h (struct objfile): Update comment.
5647         (ALL_OBJFILES): Remove.
5648         (ALL_FILETABS): Remove.
5649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5650         objfile_compunits.
5651
5652 2019-01-09  Tom Tromey  <tom@tromey.com>
5653
5654         * symmisc.c (print_objfile_statistics, dump_objfile)
5655         (maintenance_print_symbols): Use compunit_filetabs.
5656         * source.c (forget_cached_source_info_for_objfile): Use
5657         compunit_filetabs.
5658         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5659         (ALL_FILETABS): Use compunit_filetabs.
5660         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5661         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5662
5663 2019-01-09  Tom Tromey  <tom@tromey.com>
5664
5665         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5666         (compunit_filetabs): New.
5667         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5668         compunit_filetabs.
5669         (info_sources_command, make_source_files_completion_list): Remove
5670         declaration.
5671         * symmisc.c (print_objfile_statistics, dump_objfile)
5672         (maintenance_print_symbols): Remove declaration.
5673         (maintenance_info_symtabs): Use compunit_filetabs.
5674         (maintenance_info_line_tables): Likewise.
5675         * source.c (select_source_symtab): Change local variable name.
5676         (forget_cached_source_info_for_objfile): Remove declaration.
5677         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5678         * objfiles.c (objfile_relocate1): Remove declaration.
5679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5680         declaration.
5681         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5682         * coffread.c (coff_symtab_read): Remove declaration.
5683         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5684         compunit_filetabs.
5685
5686 2019-01-09  Tom Tromey  <tom@tromey.com>
5687
5688         * symtab.c (lookup_objfile_from_block)
5689         (find_pc_sect_compunit_symtab, search_symbols)
5690         (default_collect_symbol_completion_matches_break_on): Use
5691         objfile_compunits.
5692         * objfiles.h (ALL_COMPUNITS): Remove.
5693         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5694         * cp-support.c (add_symbol_overload_list_qualified): Use
5695         objfile_compunits.
5696         * ada-lang.c (ada_collect_symbol_completion_matches)
5697         (ada_add_global_exceptions): Use objfile_compunits.
5698
5699 2019-01-09  Tom Tromey  <tom@tromey.com>
5700
5701         * source.c (select_source_symtab)
5702         (forget_cached_source_info_for_objfile): Remove declaration.
5703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5704         declaration.
5705         * maint.c (count_symtabs_and_blocks): Remove declaration.
5706         * cp-support.c (add_symbol_overload_list_qualified): Remove
5707         declaration.
5708         * coffread.c (coff_symtab_read): Remove declaration.
5709         * symtab.c (lookup_symbol_in_objfile_symtabs)
5710         (basic_lookup_transparent_type_1): Use objfile_compunits.
5711         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5712         (info_sources_command, search_symbols)
5713         (default_collect_symbol_completion_matches_break_on)
5714         (make_source_files_completion_list): Remove declaration.
5715         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5716         (ada_collect_symbol_completion_matches)
5717         (ada_add_global_exceptions): Remove declaration.
5718         * linespec.c (iterate_over_all_matching_symtabs): Use
5719         objfile_compunits.
5720         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5721         (class objfile_compunits): New.
5722         (ALL_COMPUNITS): Use objfile_compunits.
5723         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5724         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5725         objfile_compunits.
5726         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5727
5728 2019-01-09  Tom Tromey  <tom@tromey.com>
5729
5730         * symtab.c (search_symbols)
5731         (default_collect_symbol_completion_matches_break_on): Use
5732         objfile_msymbols.
5733         * ada-lang.c (ada_lookup_simple_minsym)
5734         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5735         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5736         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5737         objfile_msymbols.
5738         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5739         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5740         * objc-lang.c (find_methods): Use objfile_msymbols.
5741         (info_selectors_command, info_classes_command): Likewise.
5742         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5743         * objfiles.h (class objfile_msymbols): New.
5744         (ALL_OBJFILE_MSYMBOLS): Remove.
5745         (ALL_MSYMBOLS): Remove.
5746
5747 2019-01-09  Tom Tromey  <tom@tromey.com>
5748
5749         * common/next-iterator.h (next_adapter): Add Iterator template
5750         parameter.
5751         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5752         (class all_objfiles_safe): New.
5753         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5754         * objfiles.c (put_objfile_before): Update comment.
5755         (add_separate_debug_objfile): Likewise.
5756         (free_all_objfiles): Use all_objfiles_safe.
5757         (objfile_purge_solibs): Likewise.
5758
5759 2019-01-09  Tom Tromey  <tom@tromey.com>
5760
5761         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5762         (expand_symtab_containing_pc, lookup_static_symbol)
5763         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5764         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5765         all_objfiles.
5766         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5767         * breakpoint.c (create_overlay_event_breakpoint)
5768         (create_longjmp_master_breakpoint)
5769         (create_std_terminate_master_breakpoint)
5770         (create_exception_master_breakpoint): Use all_objfiles.
5771         * linux-thread-db.c (try_thread_db_load_from_pdir)
5772         (has_libpthread): Use all_objfiles.
5773         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5774         * linespec.c (iterate_over_all_matching_symtabs)
5775         (search_minsyms_for_name): Use all_objfiles.
5776         * maint.c (maintenance_info_sections): Use all_objfiles.
5777         * main.c (captured_main_1): Use all_objfiles.
5778         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5779         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5780         * guile/scm-pretty-print.c
5781         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5782         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5783         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5784         (maintenance_print_msymbols): Use all_objfiles.
5785         * source.c (select_source_symtab): Use all_objfiles.
5786         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5787         * symfile.c (remove_symbol_file_command)
5788         (expand_symtabs_matching, map_symbol_filenames): Use
5789         all_objfiles.
5790         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5791         all_objfiles.
5792         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5793         * objc-lang.c (find_methods): Use all_objfiles.
5794         * objfiles.c (have_partial_symbols, have_full_symbols)
5795         (have_minimal_symbols, qsort_cmp)
5796         (default_iterate_over_objfiles_in_search_order): Use
5797         all_objfiles.
5798         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5799         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5800         (maintenance_check_psymtabs): Use all_objfiles.
5801         (ALL_PSYMTABS): Remove.
5802         * compile/compile-object-run.c (do_module_cleanup): Use
5803         all_objfiles.
5804         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5805         * cp-support.c (add_symbol_overload_list_qualified): Use
5806         all_objfiles.
5807         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5808         Use all_objfiles.
5809         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5810         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5811         all_objfiles.
5812         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5813         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5814         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5815         Uses all_objfiles.
5816         * solib.c (solib_read_symbols): Use all_objfiles
5817
5818 2019-01-09  Tom Tromey  <tom@tromey.com>
5819
5820         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5821         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5822         all_objfiles.
5823         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5824         * symmisc.c (print_symbol_bcache_statistics)
5825         (print_objfile_statistics, maintenance_print_objfiles)
5826         (maintenance_info_symtabs, maintenance_check_symtabs)
5827         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5828         all_objfiles.
5829         * source.c (forget_cached_source_info): Use all_objfiles.
5830         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5831         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5832         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5833         * objfiles.c (update_section_map): Use all_objfiles.
5834         (shared_objfile_contains_address_p): Likewise.
5835         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5836         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5837
5838 2019-01-09  Tom Tromey  <tom@tromey.com>
5839
5840         * common/next-iterator.h: New file.
5841         * objfiles.h (class all_objfiles): New.
5842         (struct objfile_iterator): New.
5843
5844 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5845
5846         * NEWS: Move the description of the changed "frame", "select-frame",
5847          and "info frame" commands to the Changed commands section.
5848
5849 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5850
5851         * gdbtypes.c (check_stub_method_group): Remove handling of old
5852         mangling schemes.
5853         * linespec.c (find_methods): Likewise.
5854         * stabsread.c (read_member_functions): Likewise.
5855         * valops.c (search_struct_method): Likewise.
5856         (value_struct_elt_for_reference): Likewise.
5857         * NEWS: Mention this change.
5858
5859 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5860
5861         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5862         print_source_lines.
5863         * source.c (print_source_lines_base): Update line number check.
5864         (print_source_lines): New function.
5865         (source_lines_range::source_lines_range): New function.
5866         * source.h (class source_lines_range): New class.
5867         (print_source_lines): New declaration.
5868
5869 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5870
5871         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5872
5873 2019-01-08  Tom Tromey  <tom@tromey.com>
5874             Simon Marchi  <simon.marchi@ericsson.com>
5875
5876         PR gdb/24060
5877         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5878         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5879         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5880         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5881         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5882         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5883
5884 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * source.c (select_source_symtab): Move header comment to
5887         declaration in source.h.
5888         (forget_cached_source_info_for_objfile): Likewise.
5889         (forget_cached_source_info): Likewise.
5890         (identify_source_line): Likewise.
5891         * source.h (identify_source_line): Move declaration from symtab.h
5892         and add comment from source.c
5893         (print_source_lines): Likewise.
5894         (forget_cached_source_info_for_objfile): Likewise.
5895         (forget_cached_source_info): Likewise.
5896         (select_source_symtab): Likewise.
5897         (enum print_source_lines_flag): Move definition from symtab.h.
5898         * symtab.h (identify_source_line): Move declaration to source.h.
5899         (print_source_lines): Likewise.
5900         (forget_cached_source_info_for_objfile): Likewise.
5901         (forget_cached_source_info): Likewise.
5902         (select_source_symtab): Likewise.
5903         (enum print_source_lines_flag): Move definition to source.h.
5904         * tui/tui-hooks.c: Add 'source.h' include.
5905
5906 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5907
5908         * source.c (print_source_lines_base): Handle requests to print
5909         reverse line number sequences, and guard against empty lines
5910         string.
5911
5912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5913
5914         * source.c (print_source_lines_base): Fix skip of '\r' if next
5915         character is '\n'.
5916
5917 2019-01-06  Tom Tromey  <tom@tromey.com>
5918
5919         * c-exp.y (struct c_parse_state) <macro_original_text,
5920         expansion_obstack>: New member.
5921         (macro_original_text, expansion_obstack): Remove globals.
5922         (scan_macro_expansion, scanning_macro_expansion)
5923         (finished_macro_expansion): Update.
5924         (scan_macro_cleanup): Remove.
5925         (yylex, c_parse): Update.
5926
5927 2019-01-06  Tom Tromey  <tom@tromey.com>
5928
5929         * c-exp.y (struct c_parse_state) <strings>: New member.
5930         (operator_stoken): Update.
5931
5932 2019-01-06  Tom Tromey  <tom@tromey.com>
5933
5934         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5935         (union type_stack_elt) <typelist_val>: Now a pointer to
5936         std::vector.
5937         (type_stack_cleanup): Don't declare.
5938         (push_typelist): Update.
5939         * parse.c (pop_typelist): Return a std::vector.
5940         (push_typelist): Take a std::vector.
5941         (follow_types): Update.  Do not free args.
5942         (type_stack_cleanup): Remove.
5943         * c-exp.y (struct c_parse_state): New.
5944         (cpstate): New global.
5945         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5946         (nonempty_typelist): Update.
5947         (func_mod): Create a new vector.
5948         (c_parse): Create a c_parse_state.
5949         (check_parameter_typelist): Do not delete params.
5950         (function_method): Update.  Do not delete type_list.
5951
5952 2019-01-06  Tom Tromey  <tom@tromey.com>
5953
5954         PR gdb/28155:
5955         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5956         check_typedef.
5957         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5958         (print_return_value): Likewise.
5959
5960 2019-01-05  Tom Tromey  <tom@tromey.com>
5961
5962         * contrib/cleanup_check.py: Remove.
5963         * contrib/gcc-with-excheck: Remove.
5964         * contrib/exsummary.py: Remove.
5965         * contrib/excheck.py: Remove.
5966
5967 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5968
5969         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5970         NULL. Initialize tpprev to NULL instead of assigning it
5971         to NULL on the next statement.
5972         * windows-nat.c (windows_delete_thread): Remove check for
5973         main_thread_id before printing thread exit notifications.
5974         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5975         Remove thread ID check against main_thread_id.
5976         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5977         windows_delete_thread.
5978         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5979
5980 2019-01-04  Tom Tromey  <tom@tromey.com>
5981
5982         * compile/compile.c (_initialize_compile): Use upper case for
5983         metasyntactic variables.
5984         * symmisc.c (_initialize_symmisc): Use upper case for
5985         metasyntactic variables.
5986         * psymtab.c (_initialize_psymtab): Use upper case for
5987         metasyntactic variables.
5988         * demangle.c (demangle_command): Use upper case for metasyntactic
5989         variables.
5990         (_initialize_demangler): Likewise.
5991         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5992         variables.
5993
5994 2019-01-03  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5997
5998 2019-01-03  Tom Tromey  <tom@tromey.com>
5999
6000         * python/py-symtab.c (salpy_str): Update.
6001         (struct salpy_sal_object) <symtab>: Now a PyObject.
6002         (salpy_dealloc): Update.
6003         (del_objfile_sal): Use gdbpy_ref.
6004
6005 2019-01-03  Tom Tromey  <tom@tromey.com>
6006
6007         * python/py-type.c (convert_field): Use new_reference.  Return
6008         gdbpy_ref.
6009         (make_fielditem): Return gdbpy_ref.
6010         (typy_fields): Update.
6011         (typy_getitem): Update.
6012         (field_name): Return gdbpy_ref.  Use new_reference.
6013         (typy_iterator_iternext): Update.
6014
6015 2019-01-03  Tom Tromey  <tom@tromey.com>
6016
6017         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6018
6019 2019-01-03  Tom Tromey  <tom@tromey.com>
6020
6021         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6022         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6023         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6024         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6025         (pspy_set_type_printers): Likewise.
6026         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6027         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6028         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6029         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6030         (objfpy_set_type_printers): Likewise.
6031
6032 2019-01-03  Tom Tromey  <tom@tromey.com>
6033
6034         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6035         (gdbpy_print_stack): Use gdbpy_err_fetch.
6036         * python/python-internal.h (class gdbpy_err_fetch): New class.
6037         (class gdbpy_enter) <m_error_type, m_error_value,
6038         m_error_traceback>: Remove.
6039         <m_error>: New member.
6040         (gdbpy_exception_to_string): Don't declare.
6041         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6042         * python/py-value.c (convert_value_from_python): Use
6043         gdbpy_err_fetch.
6044         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6045         gdbpy_exception_to_string.
6046         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6047         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6048         gdbpy_err_fetch.
6049
6050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * linux-nat.c (delete_lwp_cleanup): Delete.
6053         (struct lwp_deleter): New struct.
6054         (lwp_info_up): New typedef.
6055         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6056         lwp_info_up.
6057
6058 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * linux-fork.c (class scoped_switch_fork_info): New class.
6061         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6062
6063 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * valops.c (find_overload_match): Remove use of null_cleanup, and
6066         calls to do_cleanups.
6067
6068 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * compile/compile-cplus-types.c
6071         (compile_cplus_instance::decl_name): Handle changes to
6072         cp_func_name.
6073         * cp-support.c (cp_func_name): Update header comment, update
6074         return type.
6075         * cp-support.h (cp_func_name): Update return type in declaration.
6076         * valops.c (find_overload_match): Move temp_func local to top
6077         level of function and change its type.  Use temp_func to hold and
6078         delete temporary string obtained from cp_func_name.
6079
6080 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6081
6082         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6083         gdb::char_vector, remove cleanup, and update uses of `msg`.
6084
6085 2019-01-03  Jim Wilson  <jimw@sifive.com>
6086
6087         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6088
6089 2019-01-02  Tom Tromey  <tom@tromey.com>
6090
6091         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6092         (tdesc_parse_xml): Remove cleanups.
6093         * target-descriptions.h (make_cleanup_free_target_description):
6094         Don't declare.
6095         (target_desc_deleter): New struct.
6096         (target_desc_up): New typedef.
6097         * target-descriptions.c (target_desc_deleter::operator()): Rename
6098         from free_target_description.
6099         (make_cleanup_free_target_description): Remove.
6100
6101 2019-01-02  Tom Tromey  <tom@tromey.com>
6102
6103         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6104         constructor, destructor.
6105         (linespec_parser): Remove typedef.
6106         (~linespec_parser): Rename from linespec_parser_delete.
6107         (linespec_lex_to_end, linespec_complete_label)
6108         (linespec_complete): Update.
6109         (decode_line_full): Remove cleanups.
6110         (decode_line_1): Update.
6111
6112 2019-01-02  Tom Tromey  <tom@tromey.com>
6113
6114         * python/python-internal.h (inferior_to_inferior_object): Change
6115         return type.
6116         * python/py-exitedevent.c (create_exited_event_object): Update.
6117         * python/py-inferior.c (inferior_to_inferior_object): Return
6118         gdbpy_ref.
6119         (python_new_inferior, python_inferior_deleted)
6120         (thread_to_thread_object, delete_thread_object)
6121         (build_inferior_list, gdbpy_selected_inferior): Update.
6122         * python/py-infthread.c (create_thread_object): Update.  Also fail
6123         if inferior_to_inferior_object fails.
6124
6125 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6126
6127         * inferior.h (class inferior) <displaced_step_state>: New field.
6128         * infrun.h (struct displaced_step_state): Move here from
6129         infrun.c.  Initialize fields, add constructor.
6130         <inf>: Remove field.
6131         <reset>: New method.
6132         * infrun.c (struct displaced_step_inferior_state): Move to
6133         infrun.h.
6134         (displaced_step_inferior_states): Remove.
6135         (get_displaced_stepping_state): Adust.
6136         (displaced_step_in_progress_any_inferior): Adjust.
6137         (displaced_step_in_progress_thread): Adjust.
6138         (displaced_step_in_progress): Adjust.
6139         (add_displaced_stepping_state): Remove.
6140         (get_displaced_step_closure_by_addr): Adjust.
6141         (remove_displaced_stepping_state): Remove.
6142         (infrun_inferior_exit): Call displaced_step_state.reset.
6143         (use_displaced_stepping): Don't check for NULL.
6144         (displaced_step_prepare_throw): Call
6145         get_displaced_stepping_state.
6146         (displaced_step_fixup): Don't check for NULL.
6147         (prepare_for_detach): Don't check for NULL.
6148
6149 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6150
6151         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6152          in case of call that did not complete.
6153
6154 2019-01-02  Andrey Utkin  <autkin@undo.io>
6155
6156         * symfile.c (find_separate_debug_file): Fix search of debug files for
6157         remote debuggee.
6158
6159 2019-01-02  Tom Tromey  <tom@tromey.com>
6160
6161         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6162         indentation.
6163         * python/py-frame.c (frapy_older): Remove cast.
6164         (frapy_newer): Likewise.
6165         * python/py-breakpoint.c (local_setattro): Remove cast.
6166         * python/py-arch.c (archpy_name): Remove local variable.
6167         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6168
6169 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6170
6171         * unittests/basic_string_view/element_access/char/empty.cc:
6172         Fix year range in copyright header.
6173
6174 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6177         Delete.
6178         <operator==>: Update with for removed field.
6179         <hash>: Likewise.
6180         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6181         <isa_features>: ...this.
6182         <abi_features>: New field.
6183         (riscv_isa_flen): Update comment.
6184         (riscv_abi_xlen): New declaration.
6185         (riscv_abi_flen): New declaration.
6186         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6187         isa_features.
6188         (riscv_abi_xlen): New function.
6189         (riscv_isa_flen): Update to get answer from isa_features.
6190         (riscv_abi_flen): New function.
6191         (riscv_has_fp_abi): Update to get answer from abi_features.
6192         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6193         xlen and flen.
6194         (riscv_call_info) <xlen, flen>: Update comment.
6195         (riscv_call_arg_struct): Remove invalid assertions
6196         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6197         is removed.
6198         (riscv_gdbarch_init): Gather isa features and abi features
6199         separately, ensure both match on the gdbarch when reusing an old
6200         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6201         a target with 64-bit float hardware.
6202
6203 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6204
6205         * source.c (search_command_helper): Stop reverse search
6206         when line 1 has been searched.
6207
6208 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6209
6210         * record-full.c (record_full_base_target::close): Rewrite
6211         record_full_core_buf_list free logic.
6212
6213 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6214
6215         * break-catch-syscall.c (print_one_catch_syscall): xfree
6216         the last text.
6217
6218 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6219
6220         * top.c (print_gdb_version): Update Copyright year in version
6221         message.
6222
6223 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6224
6225         Update copyright year range in all GDB files.
6226
6227 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6228
6229         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6230
6231 For older changes see ChangeLog-2018.
6232 \f
6233 Local Variables:
6234 mode: change-log
6235 left-margin: 8
6236 fill-column: 74
6237 version-control: never
6238 coding: utf-8
6239 End:
6240