gdb/ChangeLog

   1 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * source-cache.c (source_cache::get_source_lines): Call
   4         find_source_lines to initialize s->nlines.  This fixes vertical
   5         scrolling of TUI source window when the DOWN arrow is pressed.
   6
   7 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   8
   9         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  10         linux-thread-db.c (_initialize_thread_db): Likewise.
  11
  12 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  13
  14         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  15         wclrtoeol in tui_show_source_line".  This reverts changes made in
  16         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  17
  18 2019-03-15  Tom Tromey  <tom@tromey.com>
  19
  20         * symtab.h (struct minimal_symbol): Derive from
  21         general_symbol_info.
  22         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  23         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  24         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  25         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  26         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  27         (MSYMBOL_SEARCH_NAME): Update.
  28         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  29         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  30         * minsyms.c (minimal_symbol_reader::record_full): Update.
  31
  32 2019-03-15  Tom Tromey  <tom@tromey.com>
  33
  34         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  35
  36 2019-03-15  Tom Tromey  <tom@tromey.com>
  37
  38         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  39         unique_xmalloc_ptr.
  40         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  41         Update.
  42         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  43         (build_minimal_symbol_hash_tables)
  44         (minimal_symbol_reader::install): Update.
  45
  46 2019-03-15  Tom Tromey  <tom@tromey.com>
  47
  48         * symtab.c (create_demangled_names_hash): Update.
  49         (symbol_set_names): Update.
  50         * objfiles.h (struct objfile_per_bfd_storage)
  51         <demangled_names_hash>: Now an htab_up.
  52         * objfiles.c (objfile_per_bfd_storage): Simplify.
  53
  54 2019-03-15  Tom Tromey  <tom@tromey.com>
  55
  56         * objfiles.h (struct objfile_per_bfd_storage): Declare
  57         destructor.
  58         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  59         New.
  60         (get_objfile_bfd_data): Use new.  Don't initialize
  61         language_of_main.
  62         (free_objfile_per_bfd_storage): Remove.
  63         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  64
  65 2019-03-15  Tom Tromey  <tom@tromey.com>
  66
  67         * symfile.c (reread_symbols): Update.
  68         * objfiles.c (objfile::objfile): Update.
  69         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  70         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  71         comment.
  72         (minimal_symbol_reader::install): Update.
  73         (terminate_minimal_symbol_table): Remove.
  74         * jit.c (jit_object_close_impl): Update.
  75
  76 2019-03-15  Tom Tromey  <tom@tromey.com>
  77
  78         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  79         initializations.
  80
  81 2019-03-15  Tom Tromey  <tom@tromey.com>
  82
  83         * objfiles.h (struct objfile_per_bfd_storage)
  84         <demangled_hash_languages>: Now a bitset.
  85         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  86         (lookup_minimal_symbol): Update.
  87
  88 2019-03-15  Tom Tromey  <tom@tromey.com>
  89
  90         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  91         Don't return the symbol.
  92         * coffread.c (record_minimal_symbol): Use record_full.
  93
  94 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  95
  96         The MS-Windows port of ncurses fails to switch to a color pair if
  97         one or both of the colors are the implicit default colors.  This
  98         change records the default colors when TUI is initialized, and
  99         then specifies them explicitly when a color pair uses the default
 100         colors.  This allows color styling in TUI mode on MS-Windows.
 101
 102         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 103         ncurses_norm_attr.
 104         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 105         colors in ncurses_norm_attr.
 106         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 107         "none", replace it with the default color recorded in
 108         ncurses_norm_attr.
 109
 110 2019-03-14  Tom Tromey  <tromey@adacore.com>
 111
 112         * source-cache.h (class source_cache) <get_source_lines>: Return
 113         std::string.
 114         * source-cache.c (source_cache::extract_lines): Handle case where
 115         first_pos==npos.  Return std::string.
 116         (source_cache::get_source_lines): Update.
 117
 118 2019-03-14  Tom Tromey  <tromey@adacore.com>
 119
 120         * NEWS: Add item for "style sources" commands.
 121         * source-cache.c (source_cache::get_source_lines): Check
 122         source_styling.
 123         * cli/cli-style.c (source_styling): New global.
 124         (_initialize_cli_style): Add "style sources" commands.
 125         (show_style_sources): New function.
 126         * cli/cli-style.h (source_styling): Declare.
 127
 128 2019-03-14  Pedro Alves  <palves@redhat.com>
 129             Tom Tromey  <tromey@adacore.com>
 130
 131         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 132         * tui/tui-winsource.c (tui_refill_source_window): New function,
 133         from...
 134         (tui_horizontal_source_scroll): ... here.  Move some logic.
 135         * cli/cli-style.c (set_style_enabled): Notify new observable.
 136         * tui/tui-hooks.c (tui_redisplay_source): New function.
 137         (tui_attach_detach_observers): Attach or detach
 138         tui_redisplay_source.
 139         * observable.h (source_styling_changed): New observable.
 140         * observable.c: Define source_styling_changed observable.
 141
 142 2019-03-13  Tom Tromey  <tromey@adacore.com>
 143
 144         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 145         (i386_gnu_nat_target::store_registers): Update.
 146         * target-debug.h (target_debug_print_std_string): New macro.
 147         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 148         * windows-tdep.c (display_one_tib): Update.
 149         * tui/tui-stack.c (tui_make_status_line): Update.
 150         * top.c (print_inferior_quit_action): Update.
 151         * thread.c (thr_try_catch_cmd): Update.
 152         (add_thread_with_info): Update.
 153         (thread_target_id_str): Update.
 154         (thr_try_catch_cmd): Update.
 155         (thread_command): Update.
 156         (thread_find_command): Update.
 157         * record-btrace.c (record_btrace_target::info_record)
 158         (record_btrace_resume_thread, record_btrace_target::resume)
 159         (record_btrace_cancel_resume, record_btrace_step_thread)
 160         (record_btrace_target::wait, record_btrace_target::wait)
 161         (record_btrace_target::wait, record_btrace_target::stop): Update.
 162         * progspace.c (print_program_space): Update.
 163         * process-stratum-target.c
 164         (process_stratum_target::thread_address_space): Update.
 165         * linux-fork.c (linux_fork_mourn_inferior)
 166         (detach_checkpoint_command, info_checkpoints_command)
 167         (linux_fork_context): Update.
 168         (linux_fork_detach): Update.
 169         (class scoped_switch_fork_info): Update.
 170         (delete_checkpoint_command): Update.
 171         * infrun.c (follow_fork_inferior): Update.
 172         (follow_fork_inferior): Update.
 173         (proceed_after_vfork_done): Update.
 174         (handle_vfork_child_exec_or_exit): Update.
 175         (follow_exec): Update.
 176         (displaced_step_prepare_throw): Update.
 177         (displaced_step_restore): Update.
 178         (start_step_over): Update.
 179         (resume_1): Update.
 180         (clear_proceed_status_thread): Update.
 181         (proceed): Update.
 182         (print_target_wait_results): Update.
 183         (do_target_wait): Update.
 184         (context_switch): Update.
 185         (stop_all_threads): Update.
 186         (restart_threads): Update.
 187         (finish_step_over): Update.
 188         (handle_signal_stop): Update.
 189         (switch_back_to_stepped_thread): Update.
 190         (keep_going_pass_signal): Update.
 191         (print_exited_reason): Update.
 192         (normal_stop): Update.
 193         * inferior.c (inferior_pid_to_str): Change return type.
 194         (print_selected_inferior): Update.
 195         (add_inferior): Update.
 196         (detach_inferior): Update.
 197         * dummy-frame.c (fprint_dummy_frames): Update.
 198         * dcache.c (dcache_info_1): Update.
 199         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 200         (btrace_fetch, btrace_clear): Update.
 201         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 202         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 203         type.
 204         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 205         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 206         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 207         * gdbarch.c, gdbarch.h: Rebuild.
 208         * gdbarch.sh (core_pid_to_str): Change return type.
 209         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 210         return type.
 211         (windows_nat_target::pid_to_str): Change return type.
 212         (windows_delete_thread): Update.
 213         (windows_nat_target::attach): Update.
 214         (windows_nat_target::files_info): Update.
 215         * target-delegates.c: Rebuild.
 216         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 217         return type.
 218         (sol_thread_target::pid_to_str): Change return type.
 219         * remote.c (class remote_target) <pid_to_str>: Change return
 220         type.
 221         (remote_target::pid_to_str): Change return type.
 222         (extended_remote_target::attach, remote_target::remote_stop_ns)
 223         (remote_target::remote_notif_remove_queued_reply)
 224         (remote_target::push_stop_reply, remote_target::disable_btrace):
 225         Update.
 226         (extended_remote_target::attach): Update.
 227         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 228         type.
 229         (gdbsim_target::pid_to_str): Change return type.
 230         * ravenscar-thread.c (struct ravenscar_thread_target)
 231         <pid_to_str>: Change return type.
 232         (ravenscar_thread_target::pid_to_str): Change return type.
 233         * procfs.c (class procfs_target) <pid_to_str>: Change return
 234         type.
 235         (procfs_target::pid_to_str): Change return type.
 236         (procfs_target::attach): Update.
 237         (procfs_target::detach): Update.
 238         (procfs_target::fetch_registers): Update.
 239         (procfs_target::store_registers): Update.
 240         (procfs_target::wait): Update.
 241         (procfs_target::files_info): Update.
 242         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 243         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 244         return type.
 245         (nto_procfs_target::pid_to_str): Change return type.
 246         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 247         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 248         return type.
 249         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 250         (exit_lwp): Update.
 251         (attach_proc_task_lwp_callback, get_detach_signal)
 252         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 253         (linux_nat_target::resume, wait_lwp, stop_callback)
 254         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 255         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 256         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 257         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 258         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 259         type.
 260         (inf_ptrace_target::attach): Update.
 261         (inf_ptrace_target::files_info): Update.
 262         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 263         type.
 264         (go32_nat_target::pid_to_str): Change return type.
 265         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 266         (gnu_nat_target::wait): Update.
 267         (gnu_nat_target::wait): Update.
 268         (gnu_nat_target::resume): Update.
 269         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 270         (fbsd_nat_target::wait): Update.
 271         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 272         type.
 273         (darwin_nat_target::attach): Update.
 274         * corelow.c (class core_target) <pid_to_str>: Change return type.
 275         (core_target::pid_to_str): Change return type.
 276         * target.c (normal_pid_to_str): Change return type.
 277         (default_pid_to_str): Likewise.
 278         (target_pid_to_str): Change return type.
 279         (target_translate_tls_address): Update.
 280         (target_announce_detach): Update.
 281         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 282         return type.
 283         (bsd_uthread_target::pid_to_str): Change return type.
 284         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 285         type.
 286         (bsd_kvm_target::pid_to_str): Change return type.
 287         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 288         return type.
 289         (aix_thread_target::pid_to_str): Change return type.
 290         * target.h (struct target_ops) <pid_to_str>: Change return type.
 291         (target_pid_to_str, normal_pid_to_str): Likewise.
 292         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 293         type.
 294         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 295         type.
 296         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 297         return type.
 298         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 299         type.
 300         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 301         type.
 302         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 303         return type.
 304
 305 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 306
 307         * NEWS: Mention that the new default MI version is 3.  Mention
 308         changes to the output of commands and events that deal with
 309         multi-location breakpoints.
 310         * breakpoint.c: Include "mi/mi-out.h".
 311         (print_one_breakpoint): Change output syntax if using MI version
 312         >= 3.
 313         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 314         New.
 315         (mi_multi_location_breakpoint_output_fixed): New.
 316         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 317         (mi_cmd_fix_multi_location_breakpoint_output): New.
 318         (mi_multi_location_breakpoint_output_fixed): New.
 319         * mi/mi-cmds.c (mi_cmds): Register command
 320         -fix-multi-location-breakpoint-output.
 321         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 322         interpreter "mi".
 323
 324 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 325
 326         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 327         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 328         instantiate mi_ui_out based on interpreter name.
 329         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 330         * mi/mi-main.c (mi_load_progress): Likewise.
 331
 332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 333
 334         * NEWS: Combine separate "New targets" sections for 8.3.
 335
 336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 337
 338         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 339         (ppcfbsd_init_abi): Install gdbarch
 340         "fetch_tls_load_module_address" and "get_thread_local_address"
 341         methods.
 342
 343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 344
 345         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 346         (riscv_fbsd_init_abi): Install gdbarch
 347         "fetch_tls_load_module_address" and "get_thread_local_address"
 348         methods.
 349
 350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 351
 352         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 353         (i386fbsd_init_abi): Install gdbarch
 354         "fetch_tls_load_module_address" and "get_thread_local_address"
 355         methods.
 356
 357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 358
 359         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 360         (amd64fbsd_init_abi): Install gdbarch
 361         "fetch_tls_load_module_address" and "get_thread_local_address"
 362         methods.
 363
 364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 367         (struct fbsd_pspace_data): New type.
 368         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 369         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 370         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 371         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 372         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 373
 374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 375
 376         * gdbtypes.c (lookup_struct_elt): New function.
 377         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 378         * gdbtypes.h (struct struct_elt): New type.
 379         (lookup_struct_elt): New prototype.
 380
 381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 382
 383         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 384         remove disabled code block.
 385
 386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 387
 388         * gdbarch.sh (get_thread_local_address): New method.
 389         * gdbarch.h, gdbarch.c: Regenerate.
 390         * target.c (target_translate_tls_address): Use
 391         gdbarch_get_thread_local_address if present instead of
 392         target::get_thread_local_address.
 393
 394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 395
 396         * target.h (target::get_thread_local_address): Update comment.
 397
 398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 399
 400         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 401         objfile->separate_debug_objfile_backlink if not NULL.
 402
 403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 406         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 407         (amd64bsd_store_inferior_registers): Likewise.
 408         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 409         Enable segment base registers.
 410         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 411         PT_GETFSBASE and PT_GETGSBASE.
 412         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 413         PT_SETGSBASE.
 414         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 415         segment base registers.
 416         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 417
 418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 419
 420         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 421         Update calls to i386_target_description to add 'segments'
 422         parameter.
 423         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 424         add segment base registers.
 425         * arch/i386.c (i386_create_target_description): Add 'segments'
 426         parameter to enable segment base registers.
 427         * arch/i386.h (i386_create_target_description): Likewise.
 428         * features/i386/32bit-segments.xml: New file.
 429         * features/i386/32bit-segments.c: Generate.
 430         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 431         call to i386_target_description to add 'segments' parameter.
 432         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 433         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 434         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 435         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 436         if feature is present.
 437         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 438         Add 'segments' parameter to call to i386_target_description.
 439         (i386_target_description): Add 'segments' parameter to enable
 440         segment base registers.
 441         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 442         to call to i386_target_description.
 443         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 444         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 445         Define I386_NUM_REGS.
 446         (i386_target_description): Add 'segments' parameter to enable
 447         segment base registers.
 448
 449 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 450
 451         PR/24325
 452         * source-cache.c: #undef open and close, to avoid unresolved
 453         externals during linking.
 454
 455 2019-03-12  Tom Tromey  <tromey@adacore.com>
 456
 457         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 458         const.  Add initializers.
 459         (_initialize_remote): Don't initialize ptid globals.
 460
 461 2019-03-12  Pedro Alves  <palves@redhat.com>
 462
 463         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 464
 465 2019-03-12  Pedro Alves  <palves@redhat.com>
 466
 467         * cp-name-parser.y (main): Remove unused 'len' variable.
 468
 469 2019-03-12  Tom Tromey  <tromey@adacore.com>
 470
 471         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 472         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 473
 474 2019-03-12  Tom Tromey  <tromey@adacore.com>
 475
 476         * linux-nat.c (iterate_over_lwps): Update.
 477         (stop_callback): Remove parameter.
 478         (stop_wait_callback, detach_callback, resume_set_callback)
 479         (select_singlestep_lwp_callback, set_ignore_sigint)
 480         (status_callback, resumed_callback, resume_clear_callback)
 481         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 482         data parameter.
 483         (linux_nat_target::detach, linux_nat_target::resume)
 484         (linux_stop_and_wait_all_lwps, select_event_lwp)
 485         (linux_nat_filter_event, linux_nat_wait_1)
 486         (linux_nat_target::kill, linux_nat_target::stop)
 487         (linux_nat_target::stop): Update.
 488         (linux_nat_resume_callback): Change type.
 489         (resume_stopped_resumed_lwps, count_events_callback)
 490         (select_event_lwp_callback): Likewise.
 491         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 492         * arm-linux-nat.c (struct update_registers_data): Remove.
 493         (update_registers_callback): Change type.
 494         (arm_linux_insert_hw_breakpoint1): Update.
 495         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 496         parameter.
 497         (x86_linux_dr_set_addr): Update.
 498         (x86_linux_dr_set_control): Update.
 499         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 500         (iterate_over_lwps): Use gdb::function_view.
 501         * nat/aarch64-linux-hw-point.c (struct
 502         aarch64_dr_update_callback_param): Remove.
 503         (debug_reg_change_callback): Change type.
 504         (aarch64_notify_debug_reg_change): Update.
 505         * s390-linux-nat.c (s390_refresh_per_info): Update.
 506
 507 2019-03-11  Tom Tromey  <tromey@adacore.com>
 508
 509         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 510         redundant assignment to "this_cu".
 511
 512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 513
 514         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 515
 516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 517
 518         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 519         from...
 520         (rank_one_type): ... this.
 521
 522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 523
 524         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 525         from...
 526         (rank_one_type): ... this.
 527
 528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 529
 530         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 531         from...
 532         (rank_one_type): ... this.
 533
 534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 535
 536         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 537         from...
 538         (rank_one_type): ... this.
 539
 540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 541
 542         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 543         from...
 544         (rank_one_type): ... this.
 545
 546 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 547
 548         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 549         from...
 550         (rank_one_type): ... this.
 551
 552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 553
 554         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 555         from...
 556         (rank_one_type): ... this.
 557
 558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 559
 560         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 561         from...
 562         (rank_one_type): ... this.
 563
 564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 565
 566         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 567         from...
 568         (rank_one_type): ... this.
 569
 570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 571
 572         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 573         from...
 574         (rank_one_type): ... this.
 575
 576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 577
 578         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 579         from...
 580         (rank_one_type): ... this.
 581
 582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 583
 584         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 585         from...
 586         (rank_one_type): ... this.
 587
 588 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 589
 590         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 591         inferior-events' shows the example events.
 592
 593 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 594
 595         Support styling on native MS-Windows console
 596
 597         PR/24315
 598         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 599         on MS-Windows if $TERM is not defined.
 600
 601         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 602
 603         * posix-hdep.c (gdb_console_fputs):
 604         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 605         functions.
 606         * ui-file.h (gdb_console_fputs): Add prototype.
 607
 608         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 609         back to fputs only if the former returns zero.
 610
 611 2019-03-07  Tom Tromey  <tom@tromey.com>
 612
 613         * symmisc.c (print_symbol_bcache_statistics): Update.
 614         (print_objfile_statistics): Update.
 615         * symfile.c (allocate_symtab): Update.
 616         * stabsread.c: Don't include bcache.h.
 617         * psymtab.h (struct psymbol_bcache): Don't declare.
 618         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 619         (psymbol_bcache_init, psymbol_bcache_free)
 620         (psymbol_bcache_get_bcache): Don't declare.
 621         * psymtab.c (struct psymbol_bcache): Remove.
 622         (psymtab_storage::psymtab_storage): Update.
 623         (psymtab_storage::~psymtab_storage): Update.
 624         (psymbol_bcache_init, psymbol_bcache_free)
 625         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 626         (add_psymbol_to_bcache): Update.
 627         (allocate_psymtab): Update.
 628         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 629         macro_cache>: No longer pointers.
 630         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 631         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 632         * macrotab.c (macro_bcache): Update.
 633         * macroexp.c: Don't include bcache.h.
 634         * gdbtypes.c (check_types_worklist): Update.
 635         (types_deeply_equal): Remove TRY/CATCH.  Update.
 636         * elfread.c (elf_symtab_read): Update.
 637         * dwarf2read.c: Don't include bcache.h.
 638         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 639         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 640         (print_bcache_statistics, bcache_memory_used): Don't declare.
 641         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 642         methods.  Rename all data members.
 643         * bcache.c (struct bcache): Move to bcache.h.
 644         (bcache::expand_hash_table): Rename from expand_hash_table.
 645         (bcache): Remove.
 646         (bcache::insert): Rename from bcache_full.
 647         (bcache::compare): Rename from bcache_compare.
 648         (bcache_xmalloc): Remove.
 649         (bcache::~bcache): Rename from bcache_xfree.
 650         (bcache::print_statistics): Rename from print_bcache_statistics.
 651         (bcache::memory_used): Rename from bcache_memory_used.
 652
 653 2019-03-07  Pedro Alves  <palves@redhat.com>
 654
 655         * infrun.c (normal_stop): Also check for
 656         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 657
 658 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * f-lang.c (value_from_host_double): Moved to...
 661         * value.c (value_from_host_double): ...here.
 662         * value.h (value_from_host_double): Declare.
 663         * guile/scm-math.c (vlscm_convert_typed_number): Use
 664         value_from_host_double.
 665         (vlscm_convert_number): Likewise.
 666         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 667         * python/py-value.c (convert_value_from_python): Likewise.
 668
 669 2019-03-06  Tom Tromey  <tom@tromey.com>
 670
 671         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 672
 673 2019-03-06  Tom Tromey  <tom@tromey.com>
 674
 675         * utils.h (free_current_contents): Don't declare.
 676         * utils.c (free_current_contents): Remove.
 677
 678 2019-03-06  Tom Tromey  <tom@tromey.com>
 679
 680         * top.c (quit_force): Update.
 681         * main.c (captured_command_loop): Update.
 682         * common/new-op.c (operator new): Update.
 683         * common/common-exceptions.c (struct catcher)
 684         <save_cleanup_chain>: Remove member.
 685         (exceptions_state_mc_init): Update.
 686         (exception_try_scope_entry): Return nullptr.
 687         (exception_try_scope_exit, exception_rethrow)
 688         (throw_exception_sjlj, throw_exception_cxx): Update.
 689         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 690         (all_cleanups, do_cleanups, discard_cleanups)
 691         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 692         (restore_cleanups, restore_final_cleanups): Don't declare.
 693         (do_final_cleanups): Remove parameter.
 694         * common/cleanups.c (cleanup_chain, make_cleanup)
 695         (make_cleanup_dtor, all_cleanups, do_cleanups)
 696         (discard_my_cleanups, discard_cleanups)
 697         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 698         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 699         (null_cleanup): Remove.
 700         (do_final_cleanups): Remove parameter.
 701
 702 2019-03-06  Tom Tromey  <tom@tromey.com>
 703
 704         * remote.c (remote_target::remote_parse_stop_reply): Use
 705         unique_xmalloc_ptr.
 706
 707 2019-03-06  Tom Tromey  <tom@tromey.com>
 708
 709         * stabsread.c (struct stabs_field_info): Rename from field_info.
 710         <list, fnlist>: Add initializers.
 711         <obstack>: New member.
 712         (read_member_functions, read_struct_fields, read_baseclasses):
 713         Allocate on obstack.  Don't use cleanups.
 714         (read_one_struct_field, read_member_functions, read_struct_fields)
 715         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 716         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 717         (read_struct_type): Update.
 718
 719 2019-03-06  Tom Tromey  <tom@tromey.com>
 720
 721         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 722         * common/filestuff.h (make_cleanup_close): Don't declare.
 723         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 724         Remove.
 725
 726 2019-03-06  Tom Tromey  <tom@tromey.com>
 727
 728         * solib-aix.c: Use make_scope_exit.
 729
 730 2019-03-06  Tom Tromey  <tom@tromey.com>
 731
 732         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 733         Use make_scope_exit.
 734
 735 2019-03-06  Tom Tromey  <tom@tromey.com>
 736
 737         * solib-svr4.c (disable_probes_interface): Remove parameter.
 738         (svr4_handle_solib_event): Use make_scope_exit.
 739
 740 2019-03-06  Tom Tromey  <tom@tromey.com>
 741
 742         * remote.c (struct stop_reply_deleter): Remove.
 743         (stop_reply_up): Update.
 744         (struct stop_reply): Derive from notif_event.  Don't typedef.
 745         <regcache>: Now a std::vector.
 746         (stop_reply_xfree): Remove.
 747         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 748         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 749         (remote_target::discard_pending_stop_replies): Use delete.
 750         (remote_target::remote_parse_stop_reply): Update.
 751         (remote_target::process_stop_reply): Update.
 752         * remote-notif.h (struct notif_event): Add virtual destructor.
 753         Remove "dtr" member.
 754         (struct notif_client) <alloc_event>: Return a unique_ptr.
 755         (notif_event_xfree): Don't declare.
 756         (notif_event_up): New typedef.
 757         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 758         (notif_event_xfree, do_notif_event_xfree): Remove.
 759         (remote_notif_state_xfree): Update.
 760
 761 2019-03-06  Tom Tromey  <tom@tromey.com>
 762
 763         * infrun.c (displaced_step_clear_cleanup): Now a
 764         forward_scope_exit type.
 765         (displaced_step_prepare_throw): Update.
 766         (displaced_step_fixup): Update.
 767
 768 2019-03-06  Tom Tromey  <tom@tromey.com>
 769
 770         * inferior.h (class inferior): Update comment.
 771         * gdbthread.h (class thread_info): Update comment.
 772
 773 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 774             Tom Tromey  <tom@tromey.com>
 775
 776         * stabsread.h (struct stab_section_list): Remove.
 777         (coffstab_build_psymtabs): Update.
 778         * dbxread.c (symbuf_sections): Now a std::vector.
 779         (sect_idx): New global.
 780         (fill_symbuf): Update.
 781         (coffstab_build_psymtabs): Change type of stabsects parameter.
 782         Update.
 783         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 784         std::vector.
 785         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 786         (coff_locate_sections): Update.
 787         (coff_symfile_read): Remove cleanups.  Update.
 788         (init_stringtab): Add storage parameter.
 789         (free_stringtab, free_stringtab_cleanup): Remove.
 790         (init_lineno): Add storage parameter.
 791         (free_linetab, free_linetab_cleanup): Remove.
 792
 793 2019-03-06  Pedro Alves  <palves@redhat.com>
 794
 795         * linux-fork.c (fork_info::clobber_regs): Delete.
 796         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 797         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 798         comment.  Adjust.
 799         (scoped_switch_fork_info::scoped_switch_fork_info)
 800         (checkpoint_command, linux_fork_context): Adjust
 801         fork_save_infrun_state calls.
 802
 803 2019-03-06  Pedro Alves  <palves@redhat.com>
 804
 805         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 806         (inf_has_multiple_threads): Return 'bool' and rewrite using
 807         inferior_info::threads().
 808
 809 2019-03-06  Pedro Alves  <palves@redhat.com>
 810
 811         * linux-fork.c: Include <list>.
 812         (fork_list): Now a std::list instance.
 813         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 814         (forks_exist_p, find_last_fork): Adjust.
 815         (new_fork): Delete.
 816         (one_fork_p): New.
 817         (add_fork): Adjust.
 818         (free_fork): Delete, folded into fork_info::~fork_info().
 819         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 820         Adjust.
 821         (init_fork_list): Delete.
 822         (linux_fork_killall, linux_fork_mourn_inferior)
 823         (linux_fork_detach, info_checkpoints_command): Adjust.
 824         (_initialize_linux_fork): No longer call init_fork_list.
 825
 826 2019-03-06  Pedro Alves  <palves@redhat.com>
 827
 828         * linux-fork.c (new_fork): New, split out of ...
 829         (add_fork): ... this.  Return void.  Move "first fork" special
 830         case from here, to ...
 831         (checkpoint_command): ... here.
 832         * linux-linux.h (add_fork): Return void.
 833
 834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 835
 836         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 837
 838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 839             Chris January  <chris.january@arm.com>
 840             David Lecomber  <david.lecomber@arm.com>
 841
 842         * f-exp.y: New token, UNOP_INTRINSIC.
 843         (exp): New pattern using UNOP_INTRINSIC token.
 844         (f77_keywords): Add 'abs' keyword.
 845         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 846         (value_from_host_double): New function.
 847         (evaluate_subexp_f): Support UNOP_ABS.
 848
 849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 852         types.
 853
 854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 857         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 858         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 859
 860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 863
 864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 865             Chris January  <chris.january@arm.com>
 866
 867         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 868         * f-exp.y: Define 'KIND' token.
 869         (exp): New pattern for KIND expressions.
 870         (ptype): Handle types with a kind extension.
 871         (direct_abs_decl): Extend to spot kind extensions.
 872         (f77_keywords): Add 'kind' to the list.
 873         (push_kind_type): New function.
 874         (convert_to_kind_type): New function.
 875         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 876         * parse.c (operator_length_standard): Likewise.
 877         * parser-defs.h (enum type_pieces): Add tp_kind.
 878         * std-operator.def: Add UNOP_KIND.
 879
 880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * f-exp.y (f_parse): Set yydebug.
 883
 884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * f-lang.c (evaluate_subexp_f): New function.
 887         (exp_descriptor_f): New global.
 888         (f_language_defn): Use exp_descriptor_f instead of
 889         exp_descriptor_standard.
 890
 891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * f-exp.y (struct token): Add comments.
 894         (dot_ops): Remove uppercase versions and the end marker.
 895         (f77_keywords): Likewise.
 896         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 897         entries in the dot_ops array are case insensitive, and use
 898         strncasecmp to compare strings.  Also some whitespace cleanup in
 899         this area.  Similar for the f77_keywords array, except entries in
 900         this list might be case sensitive.
 901
 902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * f-exp.y (struct f77_boolean_val): Add comments.
 905         (boolean_values): Remove uppercase versions, and end marker.
 906         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 907         and use strncasecmp to achieve case insensitivity.  Additionally,
 908         perform whitespace cleanup around this code.
 909
 910 2019-03-06  Tom Tromey  <tromey@adacore.com>
 911
 912         * remote-sim.c (gdbsim_target_open): Use result of
 913         gdb_argv::release.
 914
 915 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 916         Dirk Schubert  <dirk.schubert@arm.com>
 917         Chris January  <chris.january@arm.com>
 918
 919         * eval.c (evaluate_subexp_standard): Call Fortran argument
 920         wrapping logic.
 921         * f-lang.c (struct value): A value which can be passed into a
 922         Fortran function call.
 923         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 924         where appropriate.
 925         (struct type): Value ready for a Fortran function call.
 926         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 927         is needed.
 928         * f-lang.h (fortran_argument_convert): Declaration.
 929         (fortran_preserve_arg_pointer): Declaration.
 930         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 931
 932 2019-03-05  Tom Tromey  <tromey@adacore.com>
 933
 934         * python/py-prettyprint.c (print_string_repr): Remove #if.
 935         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 936
 937 2019-03-05  Tom Tromey  <tromey@adacore.com>
 938
 939         * target.c (the_dummy_target): Move later.  Change type to
 940         "dummy_target".
 941         (initialize_targets): Don't initialize the_dummy_target.
 942
 943 2019-03-05  Tom Tromey  <tromey@adacore.com>
 944
 945         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 946         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 947
 948 2019-03-05  Tom Tromey  <tromey@adacore.com>
 949
 950         * windows-nat.c (windows_nat_target::attach)
 951         (windows_nat_target::detach): Don't call gdb_flush.
 952         * valprint.c (generic_val_print, val_print, val_print_string):
 953         Don't call gdb_flush.
 954         * utils.c (defaulted_query): Don't call gdb_flush.
 955         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 956         * target.c (target_announce_detach): Don't call gdb_flush.
 957         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 958         * remote.c (extended_remote_target::attach): Don't call
 959         gdb_flush.
 960         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 961         * printcmd.c (do_examine): Don't call gdb_flush.
 962         (info_display_command): Don't call gdb_flush.
 963         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 964         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 965         * memattr.c (info_mem_command): Don't call gdb_flush.
 966         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 967         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 968         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 969         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 970         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 971         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 972         (gnu_nat_target::detach): Don't call gdb_flush.
 973         * f-valprint.c (f_val_print): Don't call gdb_flush.
 974         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 975         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 976         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 977         gdb_flush.
 978         * c-valprint.c (c_val_print): Don't call gdb_flush.
 979         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 980
 981 2019-03-05  Tom Tromey  <tromey@adacore.com>
 982
 983         * varobj.c (update_dynamic_varobj_children): Update.
 984         (install_default_visualizer): Use reset, not release.
 985         * value.c (set_internalvar): Update.
 986         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 987         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 988         ATTRIBUTE_UNUSED_RESULT.
 989
 990 2019-03-05  Tom Tromey  <tromey@adacore.com>
 991
 992         * remote.c (class scoped_remote_fd) <release>: Add
 993         ATTRIBUTE_UNUSED_RESULT.
 994
 995 2019-03-05  Tom Tromey  <tromey@adacore.com>
 996
 997         * macroexp.c (struct macro_buffer) <release>: Add
 998         ATTRIBUTE_UNUSED_RESULT.
 999
1000 2019-03-05  Tom Tromey  <tromey@adacore.com>
1001
1002         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1003         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1004         ATTRIBUTE_UNUSED_RESULT.
1005
1006 2019-03-05  Tom Tromey  <tromey@adacore.com>
1007
1008         * common/scoped_fd.h (class scoped_fd) <release>: Add
1009         ATTRIBUTE_UNUSED_RESULT.
1010
1011 2019-03-05  Tom Tromey  <tromey@adacore.com>
1012
1013         * parser-defs.h (struct parser_state) <release>: Add
1014         ATTRIBUTE_UNUSED_RESULT.
1015
1016 2019-03-05  Tom Tromey  <tromey@adacore.com>
1017
1018         * utils.h (class gdb_argv) <release>: Add
1019         ATTRIBUTE_UNUSED_RESULT.
1020         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1021
1022 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1023
1024         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1025         for-loop range, to avoid compiler warnings.
1026
1027         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1028         avoid compiler warnings about unused variables.
1029
1030         * NEWS: Mention end of support for native debugging on MS-Windows
1031         before XP.
1032
1033         PR gdb/24292
1034         * common/netstuff.c:
1035         * gdbserver/gdbreplay.c
1036         * gdbserver/remote-utils.c:
1037         * ser-tcp.c:
1038         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1039         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1040         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1041         'getaddrinfo' and 'freeaddrinfo' were not available before
1042         Windows XP, and mingw.org's MinGW headers by default define
1043         _WIN32_WINNT to 0x500.
1044
1045 2019-03-01  Gary Benson <gbenson@redhat.com>
1046
1047         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1048
1049 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1050             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1051
1052         PR gdb/8527
1053         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1054         set_sigint_trap, clear_sigint_trap.
1055
1056 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1057
1058         * target.c (target_detach): Clear the regcache and the
1059         frame cache.
1060
1061 2019-02-27  Pedro Alves  <palves@redhat.com>
1062
1063         * utils.c (set_screen_size): When we cap the height/width sizes,
1064         tweak the corresponding command variable to show "unlimited":
1065
1066 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1067             Pedro Alves  <palves@redhat.com>
1068
1069         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1070         before calling rl_set_screen_size.
1071
1072 2019-02-27  Tom Tromey  <tromey@adacore.com>
1073
1074         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1075         define.
1076         * python/py-value.c: Remove Python 2.4 workaround.
1077         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1078         workaround.
1079         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1080         Python 2.4 workaround.
1081         * python/python-internal.h: Remove Python 2.4 comment.
1082         (Py_ssize_t): Don't define.
1083         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1084         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1085         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1086         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1087         * python/python.c (do_start_initialization): Remove Python 2.4
1088         workaround.
1089         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1090         (print_children): Remove Python 2.4 workaround.
1091         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1092         workaround.
1093         (CHARBUFFERPROC_NAME): Remove.
1094         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1095         Python 2.4 workaround.
1096
1097 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1098
1099         * NEWS: Note minimum Python version.
1100
1101 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1102
1103         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1104         code from these functions.  Remove corresponding ifdefs.  Use
1105         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1106         Remove gotos and target of gotos.
1107         (infpy_search_memory): Likewise.
1108
1109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1112         (hppa_gdbarch_init): Don't register deleted functions with
1113         gdbarch.
1114
1115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1118         (h8300_unwind_sp): Delete.
1119         (h8300_dummy_id): Delete.
1120         (h8300_gdbarch_init): Don't register deleted functions with
1121         gdbarch.
1122
1123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1126         (ft32_unwind_pc): Delete.
1127         (ft32_unwind_sp): Delete.
1128         (ft32_gdbarch_init): Don't register deleted functions with
1129         gdbarch.
1130
1131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1134         (frv_unwind_pc): Delete.
1135         (frv_unwind_sp): Delete.
1136         (frv_gdbarch_init): Don't register deleted functions with
1137         gdbarch.
1138
1139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1142         (riscv_unwind_pc): Delete.
1143         (riscv_unwind_sp): Delete.
1144         (riscv_gdbarch_init): Don't register deleted functions with
1145         gdbarch.
1146
1147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1150         (csky_unwind_pc): Delete.
1151         (csky_unwind_sp): Delete.
1152         (csky_gdbarch_init): Don't register deleted functions with
1153         gdbarch.
1154
1155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1158         (cris_unwind_pc): Delete.
1159         (cris_unwind_sp): Delete.
1160         (cris_gdbarch_init): Don't register deleted functions with
1161         gdbarch.
1162
1163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1166         (bfin_unwind_pc): Delete.
1167         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1168
1169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1172         (arm_unwind_pc): Delete.
1173         (arm_unwind_sp): Delete.
1174         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1175
1176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1179         (arc_unwind_pc): Delete.
1180         (arc_unwind_sp): Delete.
1181         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1182
1183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1186         (alpha_unwind_pc): Delete.
1187         (alpha_gdbarch_init): Don't register deleted functions with
1188         gdbarch.
1189
1190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1191
1192         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1193         (aarch64_unwind_pc): Delete.
1194         (aarch64_unwind_sp): Delete.
1195         (aarch64_gdbarch_init): Don't register deleted functions with
1196         gdbarch.
1197
1198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * gdbtypes.c (type_align): Don't consider static members when
1201         computing structure alignment.
1202
1203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1206         return 0 for other types.
1207         * arch-utils.c (default_type_align): Always return 0.
1208         * gdbarch.h: Regenerate.
1209         * gdbarch.sh (type_align): Extend comment.
1210         * gdbtypes.c (type_align): Add additional comments, always call
1211         gdbarch_type_align before applying the default rules.
1212         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1213         generic code will then apply a suitable default.
1214         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1215         types, return 0 for other types.
1216
1217 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1218
1219         * NEWS: Create a new section for the next release branch.
1220         Rename the section of the current branch, now that it has
1221         been cut.
1222
1223 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1224
1225         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1226         * version.in: Bump version to 8.3.50.DATE-git.
1227
1228 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1229
1230         * aix-thread.c (ptid_cmp): Remove unused variable.
1231         (get_signaled_thread): Likewise.
1232         (store_regs_user_thread): Likewise.
1233         (store_regs_kernel_thread): Likewise.
1234         (fetch_regs_kernel_thread): Remove shadowed variable.
1235
1236 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * features/riscv/32bit-cpu.xml: Add register numbers.
1239         * features/riscv/32bit-fpu.c: Regenerate.
1240         * features/riscv/32bit-fpu.xml: Add register numbers.
1241         * features/riscv/64bit-cpu.xml: Add register numbers.
1242         * features/riscv/64bit-fpu.c: Regenerate.
1243         * features/riscv/64bit-fpu.xml: Add register numbers.
1244
1245 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1246
1247         * NEWS: Mention two argument form of gdb.Value constructor.
1248         * python/py-value.c (convert_buffer_and_type_to_value): New
1249         function.
1250         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1251         Add support for handling an optional second argument.  Call
1252         convert_buffer_and_type_to_value as appropriate.
1253         * python/python-internal.h (Py_buffer_deleter): New struct.
1254         (Py_buffer_up): New typedef.
1255
1256 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1257
1258         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1259         instead of releasing ownership.
1260
1261 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1262
1263         * dwarf2read.c (open_and_init_dwp_file): Call
1264         elf_numsections instead of bfd_count_sections to initialize
1265         dwp_file->num_sections.
1266
1267 2019-02-25  Tom Tromey  <tromey@adacore.com>
1268
1269         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1270
1271 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1272
1273         * gcore.in: Add '--readnever' option when invoking GDB.
1274
1275 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1276
1277         * MAINTAINERS: Update my email address.
1278
1279 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1280
1281         * build-id.c (build_id_to_debug_bfd_1): New function.
1282         (build_id_to_debug_bfd): Look for separate debug file in
1283         sysroot.
1284
1285 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * gdbarch.sh: Update the copyright year range that is placed into
1288         generated files.
1289
1290 2019-02-22  Keith Seitz  <keiths@redhat.com>
1291
1292         PR symtab/23853
1293         * linespec.c (create_sals_line_offset): Search for the default
1294         symtab's filename instead of its fullname.
1295
1296 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * NEWS: Update style defaults.
1299
1300 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * main.c (captured_main_1): Disable styling in batch mode.
1303
1304 2019-02-20  Tom Tromey  <tom@tromey.com>
1305
1306         * symtab.c (symtab_symbol_info): Fix typos.
1307
1308 2019-02-20  Tom Tromey  <tromey@adacore.com>
1309
1310         * findcmd.c (_initialize_mem_search): Use upper case for
1311         metasyntactic variables.
1312
1313 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1316         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1317
1318 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1319
1320         * top.h (source_file_name): Change to std::string.
1321         * top.c (source_file_name): Likewise.
1322         (command_line_input): Adjust.
1323         * cli/cli-script.c (script_from_file): Adjust.
1324
1325 2019-02-19  Tom Tromey  <tromey@adacore.com>
1326
1327         * ravenscar-thread.c
1328         (ravenscar_thread_target::update_thread_list): Don't call
1329         ada_build_task_list.
1330         * ada-lang.h (ada_build_task_list): Don't declare.
1331         * ada-tasks.c (struct ada_tasks_inferior_data)
1332         <task_list_valid_p>: Now bool.
1333         (read_known_tasks, ada_task_list_changed)
1334         (ada_tasks_invalidate_inferior_data): Update.
1335         (read_known_tasks_array): Return bool.
1336         (read_known_tasks_list): Likewise.
1337         (read_known_tasks): Return void.
1338         (ada_build_task_list): Now static.
1339
1340 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1343         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1344
1345 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346
1347         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1348         variant for ada_tasks_pspace_data_handle and
1349         ada_tasks_inferior_data_handle.
1350         (ada_tasks_pspace_data_cleanup): New function.
1351         (ada_tasks_inferior_data_cleanup): New function.
1352
1353 2019-02-17  Tom Tromey  <tom@tromey.com>
1354
1355         * macrotab.h (macro_source_fullname): Return a std::string.
1356         * macrotab.c (macro_include, check_for_redefinition)
1357         (macro_undef, macro_lookup_definition, foreach_macro)
1358         (foreach_macro_in_scope): Update.
1359         (macro_source_fullname): Return a std::string.
1360         * macrocmd.c (show_pp_source_pos): Update.
1361
1362 2019-02-17  Tom Tromey  <tom@tromey.com>
1363
1364         * macrocmd.c (show_pp_source_pos): Style the file names.
1365
1366 2019-02-17  Tom Tromey  <tom@tromey.com>
1367
1368         PR tui/24197:
1369         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1370
1371 2019-02-17  Tom Tromey  <tom@tromey.com>
1372
1373         * ada-lang.c (user_select_syms): Use filtered printing.
1374         * utils.c (wrap_style): New global.
1375         (desired_style): Remove.
1376         (emit_style_escape): Add stream parameter.
1377         (set_output_style, reset_terminal_style, prompt_for_continue):
1378         Update.
1379         (flush_wrap_buffer): Only flush gdb_stdout.
1380         (wrap_here): Set wrap_style.
1381         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1382         treat escape sequences as a character.  Change when wrap buffer is
1383         flushed.
1384         (fputs_styled): Do not set the output style when the default is
1385         requested.
1386         * ui-style.h (struct ui_file_style) <is_default>: New method.
1387         * source.c (print_source_lines_base): Emit escape sequences in one
1388         piece.
1389
1390 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1391
1392         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1393         integers and enumeration types.
1394
1395 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1396
1397         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1398         instead of lookup_symbol_in_language
1399         (do_exact_match): New function.
1400         (ada_get_symbol_name_matcher): Return do_exact_match when
1401         doing a verbatim match.
1402
1403 2019-02-15  Tom Tromey  <tromey@adacore.com>
1404
1405         * ravenscar-thread.c (ravenscar_thread_target::resume)
1406         (ravenscar_thread_target::wait): Special case wildcard requests.
1407
1408 2019-02-15  Tom Tromey  <tromey@adacore.com>
1409
1410         * ravenscar-thread.c (base_ptid): Remove.
1411         (struct ravenscar_thread_target) <close>: New method.
1412         <m_base_ptid>: New member.
1413         <update_inferior_ptid, active_task, task_is_currently_active,
1414         runtime_initialized>: Declare methods.
1415         <ravenscar_thread_target>: Add constructor.
1416         (ravenscar_thread_target::task_is_currently_active)
1417         (ravenscar_thread_target::update_inferior_ptid)
1418         (ravenscar_runtime_initialized): Rename.  Now methods.
1419         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1420         (ravenscar_thread_target::update_thread_list): Update.
1421         (ravenscar_thread_target::active_task): Now method.
1422         (ravenscar_thread_target::store_registers)
1423         (ravenscar_thread_target::prepare_to_store)
1424         (ravenscar_thread_target::prepare_to_store)
1425         (ravenscar_thread_target::mourn_inferior): Update.
1426         (ravenscar_inferior_created): Use "new" to create target.
1427         (ravenscar_thread_target::get_ada_task_ptid): Update.
1428         (_initialize_ravenscar): Don't initialize base_ptid.
1429         (ravenscar_ops): Remove global.
1430
1431 2019-02-15  Tom Tromey  <tromey@adacore.com>
1432
1433         * target.h (push_target): Declare new overload.
1434         * target.c (push_target): New overload, taking an rvalue reference.
1435         * remote.c (remote_target::open_1): Use push_target overload.
1436         * corelow.c (core_target_open): Use push_target overload.
1437
1438 2019-02-15  Tom Tromey  <tromey@adacore.com>
1439
1440         * ravenscar-thread.c (is_ravenscar_task)
1441         (ravenscar_task_is_currently_active): Return bool.
1442         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1443         (_initialize_ravenscar): Remove "(void)".
1444         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1445         Return bool.
1446
1447 2019-02-15  Tom Tromey  <tromey@adacore.com>
1448
1449         * ravenscar-thread.c (ravenscar_runtime_initializer)
1450         (has_ravenscar_runtime, get_running_thread_id)
1451         (ravenscar_thread_target::resume): Fix indentation.
1452
1453 2019-02-15  Tom Tromey  <tromey@adacore.com>
1454
1455         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1456         from ravenscar_arch_ops.
1457         (sparc_ravenscar_ops::fetch_registers)
1458         (sparc_ravenscar_ops::store_registers): Now methods.
1459         (sparc_ravenscar_prepare_to_store): Remove.
1460         (sparc_ravenscar_ops): Redefine.
1461         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1462         methods and destructor.  Remove members.
1463         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1464         (ravenscar_thread_target::store_registers)
1465         (ravenscar_thread_target::prepare_to_store): Update.
1466         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1467         Remove.
1468         (struct ppc_ravenscar_powerpc_ops): Derive from
1469         ravenscar_arch_ops.
1470         (ppc_ravenscar_powerpc_ops::fetch_registers)
1471         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1472         (ppc_ravenscar_powerpc_ops): Redefine.
1473         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1474         (ppc_ravenscar_e500_ops::fetch_registers)
1475         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1476         (ppc_ravenscar_e500_ops): Redefine.
1477         * aarch64-ravenscar-thread.c
1478         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1479         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1480         (aarch64_ravenscar_fetch_registers)
1481         (aarch64_ravenscar_store_registers): Now methods.
1482         (aarch64_ravenscar_ops): Redefine.
1483
1484 2019-02-15  Tom Tromey  <tromey@adacore.com>
1485
1486         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1487         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1488         (ravenscar_thread_target::stopped_by_watchpoint)
1489         (ravenscar_thread_target::stopped_data_address)
1490         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1491
1492 2019-02-15  Tom Tromey  <tromey@adacore.com>
1493
1494         * ravenscar-thread.c: Fix some typos.
1495
1496 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1497             Tom Tromey  <tromey@adacore.com>
1498
1499         * ada-lang.c (ada_exception_sal): Change addr_string to a
1500         std::string.
1501         (create_ada_exception_catchpoint): Update.
1502
1503 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1504             Tom Tromey  <tromey@adacore.com>
1505
1506         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1507         (bp_location_ops): Remove.
1508         (base_breakpoint_allocate_location): Update.
1509         (free_bp_location): Update.
1510         * ada-lang.c (class ada_catchpoint_location)
1511         <ada_catchpoint_location>: Remove ops parameter.
1512         (ada_catchpoint_location_dtor): Remove.
1513         (ada_catchpoint_location_ops): Remove.
1514         (allocate_location_exception): Update.
1515         * breakpoint.h (struct bp_location_ops): Remove.
1516         (class bp_location) <bp_location>: Remove bp_location_ops
1517         parameter.
1518         <~bp_location>: Add destructor.
1519         <ops>: Remove.
1520
1521 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1522             Pedro Alves  <palves@redhat.com>
1523
1524         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1525         'PATH_MAX'.
1526
1527 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1528             Samuel Thibault  <samuel.thibault@gnu.org>
1529             Thomas Schwinge  <thomas@codesourcery.com>
1530
1531         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1532         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1533
1534 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1535
1536         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1537         (check_empty): Use "const char *".
1538
1539         * gnu-nat.c (gnu_nat_target::detach): Instead of
1540         'detach_inferior (pid)' call
1541         'detach_inferior (find_inferior_pid (pid))'.
1542
1543         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1544         'nat/fork-inferior.o'.
1545         * gnu-nat.c: #include "nat/fork-inferior.h".
1546
1547         * gnu-nat.c (gnu_nat_target::detach): Instead of
1548         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1549         * gnu-nat.h: #include "inf-child.h".
1550         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1551         'i386_gnu_nat_target::fetch_registers'.
1552         (gnu_store_registers): Rename/move to
1553         'i386_gnu_nat_target::store_registers'.
1554
1555         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1556         * gnu-nat.h (mach_thread_info): New function.
1557         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1558
1559         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1560
1561 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1562
1563         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1564
1565 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1566
1567         * windows-nat.c (windows_add_thread): Add new parameter
1568         "main_thread_p" with default value set to false.  Update
1569         function documentation as well as all callers.
1570         (windows_delete_thread): Likewise.
1571         (fake_create_process): Update call to windows_add_thread.
1572         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1573         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1574         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1575         call to windows_delete_thread.
1576
1577 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1578
1579         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1580
1581 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1582
1583         * symfile.c (find_separate_debug_file): Use canonical path of
1584         sysroot with child_path instead of gdb_sysroot if it is valid.
1585
1586 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1587
1588         * symfile.c (find_separate_debug_file): Use child_path to
1589         determine if an object file is under a sysroot.
1590
1591 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1592
1593         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1594         unittests/child-path-selftests.c.
1595         * common/pathstuff.c (child_path): New function.
1596         * common/pathstuff.h (child_path): New prototype.
1597         * unittests/child-path-selftests.c: New file.
1598
1599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1600
1601         * symfile.c (find_separate_debug_file): Look for separate debug
1602         files in debug directories under the sysroot.
1603
1604 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1605
1606         * symtab.h (struct minimal_symbol data_p): New const method.
1607         (struct minimal_symbol text_p): Likewise.
1608         * symtab.c (output_source_filename): Use file name style
1609         to print file name.
1610         (print_symbol_info): Likewise.
1611         (print_msymbol_info): Use address style to print addresses.
1612         Use function name style to print executable text symbols.
1613         (expand_symtab_containing_pc): Use data_p.
1614         (find_pc_sect_compunit_symtab): Likewise.
1615
1616 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1617
1618         * breakpoint.c (describe_other_breakpoints): Use address style
1619         to print addresses.
1620         (say_where): Likewise.
1621
1622 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1623
1624         * ada-typeprint.c (print_func_type): Print function name
1625         style to print function name.
1626         * c-typeprint.c (c_print_type_1): Likewise.
1627
1628 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1629
1630         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1631         for execve.
1632
1633 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1634
1635         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1636         type_stack.
1637
1638 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1639
1640         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1641         TYPE_CODE_REF types.
1642
1643 2019-02-08  Jim Wilson  <jimw@sifive.com>
1644
1645         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1646         (riscv_linux_fregset): New.
1647         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1648
1649 2019-02-07  Tom Tromey  <tom@tromey.com>
1650
1651         * thread.c (thread_cancel_execution_command): Update.
1652         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1653         methods.
1654         (struct thread_fsm_ops): Remove.
1655         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1656         (thread_fsm_should_stop, thread_fsm_return_value)
1657         (thread_fsm_set_finished, thread_fsm_finished_p)
1658         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1659         Don't declare.
1660         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1661         * infrun.c (clear_proceed_status_thread)
1662         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1663         (print_stop_event): Update.
1664         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1665         Add constructor.
1666         (step_command_fsm_ops): Remove.
1667         (new_step_command_fsm): Remove.
1668         (step_1): Update.
1669         (step_command_fsm::should_stop): Rename from
1670         step_command_fsm_should_stop.
1671         (step_command_fsm::clean_up): Rename from
1672         step_command_fsm_clean_up.
1673         (step_command_fsm::do_async_reply_reason): Rename from
1674         step_command_fsm_async_reply_reason.
1675         (struct until_next_fsm): Inherit from thread_fsm.  Add
1676         constructor.
1677         (until_next_fsm_ops): Remove.
1678         (new_until_next_fsm): Remove.
1679         (until_next_fsm::should_stop): Rename from
1680         until_next_fsm_should_stop.
1681         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1682         (until_next_fsm::do_async_reply_reason): Rename from
1683         until_next_fsm_async_reply_reason.
1684         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1685         constructor.  Change type of breakpoint.
1686         (finish_command_fsm_ops): Remove.
1687         (new_finish_command_fsm): Remove.
1688         (finish_command_fsm::should_stop): Rename from
1689         finish_command_fsm_should_stop.
1690         (finish_command_fsm::clean_up): Rename from
1691         finish_command_fsm_clean_up.
1692         (finish_command_fsm::return_value): Rename from
1693         finish_command_fsm_return_value.
1694         (finish_command_fsm::do_async_reply_reason): Rename from
1695         finish_command_fsm_async_reply_reason.
1696         (finish_command): Update.
1697         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1698         Add constructor.
1699         (call_thread_fsm_ops): Remove.
1700         (call_thread_fsm::call_thread_fsm): Rename from
1701         new_call_thread_fsm.
1702         (call_thread_fsm::should_stop): Rename from
1703         call_thread_fsm_should_stop.
1704         (call_thread_fsm::should_notify_stop): Rename from
1705         call_thread_fsm_should_notify_stop.
1706         (run_inferior_call, call_function_by_hand_dummy): Update.
1707         * cli/cli-interp.c (should_print_stop_to_console): Update.
1708         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1709         Add constructor.  Change type of location_breakpoint,
1710         caller_breakpoint.
1711         (until_break_fsm_ops): Remove.
1712         (new_until_break_fsm): Remove.
1713         (until_break_fsm::should_stop): Rename from
1714         until_break_fsm_should_stop.
1715         (until_break_fsm::clean_up): Rename from
1716         until_break_fsm_clean_up.
1717         (until_break_fsm::do_async_reply_reason): Rename from
1718         until_break_fsm_async_reply_reason.
1719         (until_break_command): Update.
1720         * thread-fsm.c: Remove.
1721         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1722
1723 2019-02-07  Tom Tromey  <tom@tromey.com>
1724
1725         * yy-remap.h: Add include guard.
1726         * xtensa-tdep.h: Add include guard.
1727         * xcoffread.h: Rename include guard.
1728         * varobj-iter.h: Add include guard.
1729         * tui/tui.h: Rename include guard.
1730         * tui/tui-winsource.h: Rename include guard.
1731         * tui/tui-wingeneral.h: Rename include guard.
1732         * tui/tui-windata.h: Rename include guard.
1733         * tui/tui-win.h: Rename include guard.
1734         * tui/tui-stack.h: Rename include guard.
1735         * tui/tui-source.h: Rename include guard.
1736         * tui/tui-regs.h: Rename include guard.
1737         * tui/tui-out.h: Rename include guard.
1738         * tui/tui-layout.h: Rename include guard.
1739         * tui/tui-io.h: Rename include guard.
1740         * tui/tui-hooks.h: Rename include guard.
1741         * tui/tui-file.h: Rename include guard.
1742         * tui/tui-disasm.h: Rename include guard.
1743         * tui/tui-data.h: Rename include guard.
1744         * tui/tui-command.h: Rename include guard.
1745         * tic6x-tdep.h: Add include guard.
1746         * target/waitstatus.h: Rename include guard.
1747         * target/wait.h: Rename include guard.
1748         * target/target.h: Rename include guard.
1749         * target/resume.h: Rename include guard.
1750         * target-float.h: Rename include guard.
1751         * stabsread.h: Add include guard.
1752         * rs6000-tdep.h: Add include guard.
1753         * riscv-fbsd-tdep.h: Add include guard.
1754         * regformats/regdef.h: Rename include guard.
1755         * record.h: Rename include guard.
1756         * python/python.h: Rename include guard.
1757         * python/python-internal.h: Rename include guard.
1758         * python/py-stopevent.h: Rename include guard.
1759         * python/py-ref.h: Rename include guard.
1760         * python/py-record.h: Rename include guard.
1761         * python/py-record-full.h: Rename include guard.
1762         * python/py-record-btrace.h: Rename include guard.
1763         * python/py-instruction.h: Rename include guard.
1764         * python/py-events.h: Rename include guard.
1765         * python/py-event.h: Rename include guard.
1766         * procfs.h: Add include guard.
1767         * proc-utils.h: Add include guard.
1768         * p-lang.h: Add include guard.
1769         * or1k-tdep.h: Rename include guard.
1770         * observable.h: Rename include guard.
1771         * nto-tdep.h: Rename include guard.
1772         * nat/x86-linux.h: Rename include guard.
1773         * nat/x86-linux-dregs.h: Rename include guard.
1774         * nat/x86-gcc-cpuid.h: Add include guard.
1775         * nat/x86-dregs.h: Rename include guard.
1776         * nat/x86-cpuid.h: Rename include guard.
1777         * nat/ppc-linux.h: Rename include guard.
1778         * nat/mips-linux-watch.h: Rename include guard.
1779         * nat/linux-waitpid.h: Rename include guard.
1780         * nat/linux-ptrace.h: Rename include guard.
1781         * nat/linux-procfs.h: Rename include guard.
1782         * nat/linux-osdata.h: Rename include guard.
1783         * nat/linux-nat.h: Rename include guard.
1784         * nat/linux-namespaces.h: Rename include guard.
1785         * nat/linux-btrace.h: Rename include guard.
1786         * nat/glibc_thread_db.h: Rename include guard.
1787         * nat/gdb_thread_db.h: Rename include guard.
1788         * nat/gdb_ptrace.h: Rename include guard.
1789         * nat/fork-inferior.h: Rename include guard.
1790         * nat/amd64-linux-siginfo.h: Rename include guard.
1791         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1792         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1793         * nat/aarch64-linux.h: Rename include guard.
1794         * nat/aarch64-linux-hw-point.h: Rename include guard.
1795         * mn10300-tdep.h: Add include guard.
1796         * mips-linux-tdep.h: Add include guard.
1797         * mi/mi-parse.h: Rename include guard.
1798         * mi/mi-out.h: Rename include guard.
1799         * mi/mi-main.h: Rename include guard.
1800         * mi/mi-interp.h: Rename include guard.
1801         * mi/mi-getopt.h: Rename include guard.
1802         * mi/mi-console.h: Rename include guard.
1803         * mi/mi-common.h: Rename include guard.
1804         * mi/mi-cmds.h: Rename include guard.
1805         * mi/mi-cmd-break.h: Rename include guard.
1806         * m2-lang.h: Add include guard.
1807         * location.h: Rename include guard.
1808         * linux-record.h: Rename include guard.
1809         * linux-nat.h: Add include guard.
1810         * linux-fork.h: Add include guard.
1811         * i386-darwin-tdep.h: Rename include guard.
1812         * hppa-linux-offsets.h: Add include guard.
1813         * guile/guile.h: Rename include guard.
1814         * guile/guile-internal.h: Rename include guard.
1815         * gnu-nat.h: Rename include guard.
1816         * gdb-stabs.h: Rename include guard.
1817         * frv-tdep.h: Add include guard.
1818         * f-lang.h: Add include guard.
1819         * event-loop.h: Add include guard.
1820         * darwin-nat.h: Rename include guard.
1821         * cp-abi.h: Rename include guard.
1822         * config/sparc/nm-sol2.h: Rename include guard.
1823         * config/nm-nto.h: Rename include guard.
1824         * config/nm-linux.h: Add include guard.
1825         * config/i386/nm-i386gnu.h: Rename include guard.
1826         * config/djgpp/nl_types.h: Rename include guard.
1827         * config/djgpp/langinfo.h: Rename include guard.
1828         * compile/gcc-cp-plugin.h: Add include guard.
1829         * compile/gcc-c-plugin.h: Add include guard.
1830         * compile/compile.h: Rename include guard.
1831         * compile/compile-object-run.h: Rename include guard.
1832         * compile/compile-object-load.h: Rename include guard.
1833         * compile/compile-internal.h: Rename include guard.
1834         * compile/compile-cplus.h: Rename include guard.
1835         * compile/compile-c.h: Rename include guard.
1836         * common/xml-utils.h: Rename include guard.
1837         * common/x86-xstate.h: Rename include guard.
1838         * common/version.h: Rename include guard.
1839         * common/vec.h: Rename include guard.
1840         * common/tdesc.h: Rename include guard.
1841         * common/selftest.h: Rename include guard.
1842         * common/scoped_restore.h: Rename include guard.
1843         * common/scoped_mmap.h: Rename include guard.
1844         * common/scoped_fd.h: Rename include guard.
1845         * common/safe-iterator.h: Rename include guard.
1846         * common/run-time-clock.h: Rename include guard.
1847         * common/refcounted-object.h: Rename include guard.
1848         * common/queue.h: Rename include guard.
1849         * common/ptid.h: Rename include guard.
1850         * common/print-utils.h: Rename include guard.
1851         * common/preprocessor.h: Rename include guard.
1852         * common/pathstuff.h: Rename include guard.
1853         * common/observable.h: Rename include guard.
1854         * common/netstuff.h: Rename include guard.
1855         * common/job-control.h: Rename include guard.
1856         * common/host-defs.h: Rename include guard.
1857         * common/gdb_wait.h: Rename include guard.
1858         * common/gdb_vecs.h: Rename include guard.
1859         * common/gdb_unlinker.h: Rename include guard.
1860         * common/gdb_unique_ptr.h: Rename include guard.
1861         * common/gdb_tilde_expand.h: Rename include guard.
1862         * common/gdb_sys_time.h: Rename include guard.
1863         * common/gdb_string_view.h: Rename include guard.
1864         * common/gdb_splay_tree.h: Rename include guard.
1865         * common/gdb_setjmp.h: Rename include guard.
1866         * common/gdb_ref_ptr.h: Rename include guard.
1867         * common/gdb_optional.h: Rename include guard.
1868         * common/gdb_locale.h: Rename include guard.
1869         * common/gdb_assert.h: Rename include guard.
1870         * common/filtered-iterator.h: Rename include guard.
1871         * common/filestuff.h: Rename include guard.
1872         * common/fileio.h: Rename include guard.
1873         * common/environ.h: Rename include guard.
1874         * common/common-utils.h: Rename include guard.
1875         * common/common-types.h: Rename include guard.
1876         * common/common-regcache.h: Rename include guard.
1877         * common/common-inferior.h: Rename include guard.
1878         * common/common-gdbthread.h: Rename include guard.
1879         * common/common-exceptions.h: Rename include guard.
1880         * common/common-defs.h: Rename include guard.
1881         * common/common-debug.h: Rename include guard.
1882         * common/cleanups.h: Rename include guard.
1883         * common/buffer.h: Rename include guard.
1884         * common/btrace-common.h: Rename include guard.
1885         * common/break-common.h: Rename include guard.
1886         * cli/cli-utils.h: Rename include guard.
1887         * cli/cli-style.h: Rename include guard.
1888         * cli/cli-setshow.h: Rename include guard.
1889         * cli/cli-script.h: Rename include guard.
1890         * cli/cli-interp.h: Rename include guard.
1891         * cli/cli-decode.h: Rename include guard.
1892         * cli/cli-cmds.h: Rename include guard.
1893         * charset-list.h: Add include guard.
1894         * buildsym-legacy.h: Rename include guard.
1895         * bfin-tdep.h: Add include guard.
1896         * ax.h: Rename include guard.
1897         * arm-linux-tdep.h: Add include guard.
1898         * arm-fbsd-tdep.h: Add include guard.
1899         * arch/xtensa.h: Rename include guard.
1900         * arch/tic6x.h: Add include guard.
1901         * arch/i386.h: Add include guard.
1902         * arch/arm.h: Rename include guard.
1903         * arch/arm-linux.h: Rename include guard.
1904         * arch/arm-get-next-pcs.h: Rename include guard.
1905         * arch/amd64.h: Add include guard.
1906         * arch/aarch64-insn.h: Rename include guard.
1907         * arch-utils.h: Rename include guard.
1908         * annotate.h: Add include guard.
1909         * amd64-darwin-tdep.h: Rename include guard.
1910         * aarch64-linux-tdep.h: Add include guard.
1911         * aarch64-fbsd-tdep.h: Add include guard.
1912         * aarch32-linux-nat.h: Add include guard.
1913
1914 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1915
1916         * macrotab.c (macro_define_internal): New function that
1917         factorizes macro_define_object_internal and macro_define_function
1918         code.
1919         (macro_define_object_internal): Use macro_define_internal.
1920         (macro_define_function): Likewise.
1921
1922 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1923
1924         * macrocmd.c (extract_identifier): Return
1925         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1926         callers.
1927
1928 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1929
1930         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1931
1932 2019-02-05  Tom Tromey  <tom@tromey.com>
1933
1934         * target.c (target_stack::unpush): Move assertion earlier.
1935
1936 2019-01-30  Tom Tromey  <tom@tromey.com>
1937
1938         PR python/23615:
1939         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1940         (gdbpy_parse_and_eval): Likewise.
1941         * python/python-internal.h (gdbpy_allow_threads): New class.
1942
1943 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1944
1945         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1946         (aarch64_fbsd_fpregmap): Move earlier.
1947         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1948         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1949         instead of individual calls to trad_frame_set_reg_addr.
1950         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1951         earlier.
1952         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1953         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1954         instead of individual calls to trad_frame_set_reg_addr.
1955
1956 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1957
1958         * CONTRIBUTE: Replace contribution list with wiki link.
1959
1960 2019-01-25  Tom Tromey  <tom@tromey.com>
1961
1962         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1963
1964 2019-01-25  Tom Tromey  <tom@tromey.com>
1965
1966         * xtensa-linux-nat.c: Fix common/ includes.
1967         * xml-support.h: Fix common/ includes.
1968         * xml-support.c: Fix common/ includes.
1969         * x86-linux-nat.c: Fix common/ includes.
1970         * windows-nat.c: Fix common/ includes.
1971         * varobj.h: Fix common/ includes.
1972         * varobj.c: Fix common/ includes.
1973         * value.c: Fix common/ includes.
1974         * valops.c: Fix common/ includes.
1975         * utils.c: Fix common/ includes.
1976         * unittests/xml-utils-selftests.c: Fix common/ includes.
1977         * unittests/utils-selftests.c: Fix common/ includes.
1978         * unittests/unpack-selftests.c: Fix common/ includes.
1979         * unittests/tracepoint-selftests.c: Fix common/ includes.
1980         * unittests/style-selftests.c: Fix common/ includes.
1981         * unittests/string_view-selftests.c: Fix common/ includes.
1982         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1983         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1984         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1985         * unittests/rsp-low-selftests.c: Fix common/ includes.
1986         * unittests/parse-connection-spec-selftests.c: Fix common/
1987         includes.
1988         * unittests/optional-selftests.c: Fix common/ includes.
1989         * unittests/offset-type-selftests.c: Fix common/ includes.
1990         * unittests/observable-selftests.c: Fix common/ includes.
1991         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1992         * unittests/memrange-selftests.c: Fix common/ includes.
1993         * unittests/memory-map-selftests.c: Fix common/ includes.
1994         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1995         * unittests/function-view-selftests.c: Fix common/ includes.
1996         * unittests/environ-selftests.c: Fix common/ includes.
1997         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1998         * unittests/common-utils-selftests.c: Fix common/ includes.
1999         * unittests/cli-utils-selftests.c: Fix common/ includes.
2000         * unittests/array-view-selftests.c: Fix common/ includes.
2001         * ui-file.c: Fix common/ includes.
2002         * tui/tui-io.c: Fix common/ includes.
2003         * tracepoint.h: Fix common/ includes.
2004         * tracepoint.c: Fix common/ includes.
2005         * tracefile-tfile.c: Fix common/ includes.
2006         * top.h: Fix common/ includes.
2007         * top.c: Fix common/ includes.
2008         * thread.c: Fix common/ includes.
2009         * target/waitstatus.h: Fix common/ includes.
2010         * target/waitstatus.c: Fix common/ includes.
2011         * target.h: Fix common/ includes.
2012         * target.c: Fix common/ includes.
2013         * target-memory.c: Fix common/ includes.
2014         * target-descriptions.c: Fix common/ includes.
2015         * symtab.h: Fix common/ includes.
2016         * symfile.c: Fix common/ includes.
2017         * stap-probe.c: Fix common/ includes.
2018         * spu-linux-nat.c: Fix common/ includes.
2019         * sparc-nat.c: Fix common/ includes.
2020         * source.c: Fix common/ includes.
2021         * solib.c: Fix common/ includes.
2022         * solib-target.c: Fix common/ includes.
2023         * ser-unix.c: Fix common/ includes.
2024         * ser-tcp.c: Fix common/ includes.
2025         * ser-pipe.c: Fix common/ includes.
2026         * ser-base.c: Fix common/ includes.
2027         * selftest-arch.c: Fix common/ includes.
2028         * s12z-tdep.c: Fix common/ includes.
2029         * rust-exp.y: Fix common/ includes.
2030         * rs6000-aix-tdep.c: Fix common/ includes.
2031         * riscv-tdep.c: Fix common/ includes.
2032         * remote.c: Fix common/ includes.
2033         * remote-notif.h: Fix common/ includes.
2034         * remote-fileio.h: Fix common/ includes.
2035         * remote-fileio.c: Fix common/ includes.
2036         * regcache.h: Fix common/ includes.
2037         * regcache.c: Fix common/ includes.
2038         * record-btrace.c: Fix common/ includes.
2039         * python/python.c: Fix common/ includes.
2040         * python/py-type.c: Fix common/ includes.
2041         * python/py-inferior.c: Fix common/ includes.
2042         * progspace.h: Fix common/ includes.
2043         * producer.c: Fix common/ includes.
2044         * procfs.c: Fix common/ includes.
2045         * proc-api.c: Fix common/ includes.
2046         * printcmd.c: Fix common/ includes.
2047         * ppc-linux-nat.c: Fix common/ includes.
2048         * parser-defs.h: Fix common/ includes.
2049         * osdata.c: Fix common/ includes.
2050         * obsd-nat.c: Fix common/ includes.
2051         * nat/x86-linux.c: Fix common/ includes.
2052         * nat/x86-linux-dregs.c: Fix common/ includes.
2053         * nat/x86-dregs.h: Fix common/ includes.
2054         * nat/x86-dregs.c: Fix common/ includes.
2055         * nat/ppc-linux.c: Fix common/ includes.
2056         * nat/mips-linux-watch.h: Fix common/ includes.
2057         * nat/mips-linux-watch.c: Fix common/ includes.
2058         * nat/linux-waitpid.c: Fix common/ includes.
2059         * nat/linux-ptrace.h: Fix common/ includes.
2060         * nat/linux-ptrace.c: Fix common/ includes.
2061         * nat/linux-procfs.c: Fix common/ includes.
2062         * nat/linux-personality.c: Fix common/ includes.
2063         * nat/linux-osdata.c: Fix common/ includes.
2064         * nat/linux-namespaces.c: Fix common/ includes.
2065         * nat/linux-btrace.h: Fix common/ includes.
2066         * nat/linux-btrace.c: Fix common/ includes.
2067         * nat/fork-inferior.c: Fix common/ includes.
2068         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2069         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2070         * nat/aarch64-linux.c: Fix common/ includes.
2071         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2072         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2073         * namespace.h: Fix common/ includes.
2074         * mips-linux-tdep.c: Fix common/ includes.
2075         * minsyms.c: Fix common/ includes.
2076         * mi/mi-parse.h: Fix common/ includes.
2077         * mi/mi-main.c: Fix common/ includes.
2078         * mi/mi-cmd-env.c: Fix common/ includes.
2079         * memrange.h: Fix common/ includes.
2080         * memattr.c: Fix common/ includes.
2081         * maint.h: Fix common/ includes.
2082         * maint.c: Fix common/ includes.
2083         * main.c: Fix common/ includes.
2084         * machoread.c: Fix common/ includes.
2085         * location.c: Fix common/ includes.
2086         * linux-thread-db.c: Fix common/ includes.
2087         * linux-nat.c: Fix common/ includes.
2088         * linux-fork.c: Fix common/ includes.
2089         * inline-frame.c: Fix common/ includes.
2090         * infrun.c: Fix common/ includes.
2091         * inflow.c: Fix common/ includes.
2092         * inferior.h: Fix common/ includes.
2093         * inferior.c: Fix common/ includes.
2094         * infcmd.c: Fix common/ includes.
2095         * inf-ptrace.c: Fix common/ includes.
2096         * inf-child.c: Fix common/ includes.
2097         * ia64-linux-nat.c: Fix common/ includes.
2098         * i387-tdep.c: Fix common/ includes.
2099         * i386-tdep.c: Fix common/ includes.
2100         * i386-linux-tdep.c: Fix common/ includes.
2101         * i386-linux-nat.c: Fix common/ includes.
2102         * i386-go32-tdep.c: Fix common/ includes.
2103         * i386-fbsd-tdep.c: Fix common/ includes.
2104         * i386-fbsd-nat.c: Fix common/ includes.
2105         * guile/scm-type.c: Fix common/ includes.
2106         * guile/guile.c: Fix common/ includes.
2107         * go32-nat.c: Fix common/ includes.
2108         * gnu-nat.c: Fix common/ includes.
2109         * gdbthread.h: Fix common/ includes.
2110         * gdbarch-selftests.c: Fix common/ includes.
2111         * gdb_usleep.c: Fix common/ includes.
2112         * gdb_select.h: Fix common/ includes.
2113         * gdb_bfd.c: Fix common/ includes.
2114         * gcore.c: Fix common/ includes.
2115         * fork-child.c: Fix common/ includes.
2116         * findvar.c: Fix common/ includes.
2117         * fbsd-nat.c: Fix common/ includes.
2118         * event-top.c: Fix common/ includes.
2119         * event-loop.c: Fix common/ includes.
2120         * dwarf2read.c: Fix common/ includes.
2121         * dwarf2loc.c: Fix common/ includes.
2122         * dwarf2-frame.c: Fix common/ includes.
2123         * dwarf-index-cache.c: Fix common/ includes.
2124         * dtrace-probe.c: Fix common/ includes.
2125         * disasm-selftests.c: Fix common/ includes.
2126         * defs.h: Fix common/ includes.
2127         * csky-tdep.c: Fix common/ includes.
2128         * cp-valprint.c: Fix common/ includes.
2129         * cp-support.h: Fix common/ includes.
2130         * cp-support.c: Fix common/ includes.
2131         * corelow.c: Fix common/ includes.
2132         * completer.h: Fix common/ includes.
2133         * completer.c: Fix common/ includes.
2134         * compile/compile.c: Fix common/ includes.
2135         * compile/compile-loc2c.c: Fix common/ includes.
2136         * compile/compile-cplus-types.c: Fix common/ includes.
2137         * compile/compile-cplus-symbols.c: Fix common/ includes.
2138         * command.h: Fix common/ includes.
2139         * cli/cli-dump.c: Fix common/ includes.
2140         * cli/cli-cmds.c: Fix common/ includes.
2141         * charset.c: Fix common/ includes.
2142         * build-id.c: Fix common/ includes.
2143         * btrace.h: Fix common/ includes.
2144         * btrace.c: Fix common/ includes.
2145         * breakpoint.h: Fix common/ includes.
2146         * breakpoint.c: Fix common/ includes.
2147         * ax.h:
2148         (enum agent_op): Fix common/ includes.
2149         * ax-general.c (struct aop_map): Fix common/ includes.
2150         * ax-gdb.c: Fix common/ includes.
2151         * auxv.c: Fix common/ includes.
2152         * auto-load.c: Fix common/ includes.
2153         * arm-tdep.c: Fix common/ includes.
2154         * arch/riscv.c: Fix common/ includes.
2155         * arch/ppc-linux-common.c: Fix common/ includes.
2156         * arch/i386.c: Fix common/ includes.
2157         * arch/arm.c: Fix common/ includes.
2158         * arch/arm-linux.c: Fix common/ includes.
2159         * arch/arm-get-next-pcs.c: Fix common/ includes.
2160         * arch/amd64.c: Fix common/ includes.
2161         * arch/aarch64.c: Fix common/ includes.
2162         * arch/aarch64-insn.c: Fix common/ includes.
2163         * arch-utils.c: Fix common/ includes.
2164         * amd64-windows-tdep.c: Fix common/ includes.
2165         * amd64-tdep.c: Fix common/ includes.
2166         * amd64-sol2-tdep.c: Fix common/ includes.
2167         * amd64-obsd-tdep.c: Fix common/ includes.
2168         * amd64-nbsd-tdep.c: Fix common/ includes.
2169         * amd64-linux-tdep.c: Fix common/ includes.
2170         * amd64-linux-nat.c: Fix common/ includes.
2171         * amd64-fbsd-tdep.c: Fix common/ includes.
2172         * amd64-fbsd-nat.c: Fix common/ includes.
2173         * amd64-dicos-tdep.c: Fix common/ includes.
2174         * amd64-darwin-tdep.c: Fix common/ includes.
2175         * agent.c: Fix common/ includes.
2176         * ada-lang.h: Fix common/ includes.
2177         * ada-lang.c: Fix common/ includes.
2178         * aarch64-tdep.c: Fix common/ includes.
2179
2180 2019-01-25  Tom Tromey  <tom@tromey.com>
2181
2182         * common/create-version.sh: Use common/version.h.
2183
2184 2019-01-24  Pedro Alves  <palves@redhat.com>
2185
2186         * infrun.c (signal_stop, signal_print, signal_program)
2187         (signal_catch, signal_pass): Now arrays instead of pointers.
2188         (update_signals_program_target, do_target_resume)
2189         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2190         * linux-nat.c (linux_nat_target::pass_signals)
2191         (linux_nat_target::create_inferior, linux_nat_target::attach):
2192         Adjust.
2193         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2194         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2195         * procfs.c (procfs_target::pass_signals): Adjust.
2196         * record-full.c (record_full_target::resume): Adjust.
2197         * remote.c (remote_target::pass_signals)
2198         (remote_target::program_signals): Adjust.
2199         * target-debug.h (target_debug_print_signals): Now takes a
2200         gdb::array_view as parameter.  Adjust.
2201         * target.h (target_ops) <pass_signals, program_signals>: Replace
2202         pointer and length parameters with gdb::array_view.
2203         (target_pass_signals, target_program_signals): Likewise.
2204         * target-delegates.c: Regenerate.
2205
2206 2019-01-24  Pedro Alves  <palves@redhat.com>
2207
2208         * common/forward-scope-exit.h
2209         (forward_scope_exit::forward_scope_exit): Pass arguments to
2210         m_bind_function directly, instead of creating a std::bind and
2211         copying that.
2212
2213 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2214
2215         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2216         for static members.
2217         (pass_in_v_vfp_candidate): Likewise.
2218
2219 2019-01-23  Tom Tromey  <tom@tromey.com>
2220             Pedro Alves  <palves@redhat.com>
2221
2222         * regcache.c (class regcache_invalidator): Remove.
2223         (regcache::raw_write): Use make_scope_exit.
2224
2225 2019-01-23  Tom Tromey  <tom@tromey.com>
2226
2227         * ui-out.h (class ui_out_emit_type): Update comment.
2228
2229 2019-01-23  Tom Tromey  <tom@tromey.com>
2230
2231         * infrun.c (fetch_inferior_event): Update comment.
2232
2233 2019-01-23  Tom Tromey  <tom@tromey.com>
2234             Pedro Alves  <palves@redhat.com>
2235
2236         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2237         parameter.
2238         (fetch_inferior_event): Use SCOPE_EXIT.
2239
2240
2241 2019-01-23  Tom Tromey  <tom@tromey.com>
2242             Pedro Alves  <palves@redhat.com>
2243
2244         * infrun.c (disable_thread_events): Delete.
2245         (stop_all_threads): Use SCOPE_EXIT.
2246
2247 2019-01-23  Tom Tromey  <tom@tromey.com>
2248             Pedro Alves  <palves@redhat.com>
2249
2250         * symfile.c: Include forward-scope-exit.h.
2251         (clear_symtab_users_cleanup): Replace forward declaration with
2252         a FORWARD_SCOPE_EXIT.
2253         (syms_from_objfile_1): Use the forward_scope_exit and
2254         gdb::optional instead of cleanup_function.
2255         (reread_symbols): Use the forward_scope_exit instead of
2256         cleanup_function.
2257         (clear_symtab_users_cleanup): Remove function.
2258
2259 2019-01-23  Tom Tromey  <tom@tromey.com>
2260             Pedro Alves  <palves@redhat.com>
2261
2262         * linux-nat.c: Include scope-exit.h.
2263         (cleanup_target_stop): Remove.
2264         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2265         SCOPE_EXIT.
2266
2267 2019-01-23  Tom Tromey  <tom@tromey.com>
2268             Pedro Alves  <palves@redhat.com>
2269
2270         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2271         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2272
2273 2019-01-23  Tom Tromey  <tom@tromey.com>
2274             Andrew Burgess  <andrew.burgess@embecosm.com>
2275             Pedro Alves  <palves@redhat.com>
2276
2277         * infrun.c (fetch_inferior_event): Use scope_exit.
2278         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2279         * top.c (execute_command): Use scope_exit.
2280         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2281         * utils.c (do_bpstat_clear_actions_cleanup)
2282         (make_bpstat_clear_actions_cleanup): Remove.
2283
2284 2019-01-23  Tom Tromey  <tom@tromey.com>
2285             Pedro Alves  <palves@redhat.com>
2286
2287         * infrun.c: Include "common/scope-exit.h"
2288         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2289         (wait_for_inferior): Use SCOPE_EXIT.
2290         (fetch_inferior_event): Use scope_exit.
2291
2292 2019-01-23  Tom Tromey  <tom@tromey.com>
2293             Pedro Alves  <palves@redhat.com>
2294
2295         * breakpoint.c (create_breakpoint): Remove cleanup.
2296
2297 2019-01-23  Tom Tromey  <tom@tromey.com>
2298             Andrew Burgess  <andrew.burgess@embecosm.com>
2299             Pedro Alves  <palves@redhat.com>
2300
2301 2019-01-23  Pedro Alves  <palves@redhat.com>
2302
2303         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2304
2305 2019-01-23  Pedro Alves  <palves@redhat.com>
2306             Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * gdbthread.h: Include "common/forward-scope-exit.h".
2309         (scoped_finish_thread_state): Redefine custom class in terms of
2310         forward_scope_exit.
2311
2312 2019-01-23  Pedro Alves  <palves@redhat.com>
2313             Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * common/forward-scope-exit.h: New file.
2316
2317 2019-01-23  Pedro Alves  <palves@redhat.com>
2318             Andrew Burgess  <andrew.burgess@embecosm.com>
2319             Tom Tromey  <tom@tromey.com>
2320
2321         * common/scope-exit.h: New file.
2322
2323 2019-01-23  Pedro Alves  <palves@redhat.com>
2324
2325         * common/preprocessor.h (ESC): Rename to ...
2326         (ESC_PARENS): ... this.
2327         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2328         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2329
2330 2019-01-23  Tom Tromey  <tom@tromey.com>
2331
2332         * language.h (class scoped_switch_to_sym_language_if_auto):
2333         Initialize m_lang in both cases.
2334
2335 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2336
2337         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2338         with XCNEW.
2339
2340 2019-01-22  Tom Tromey  <tom@tromey.com>
2341
2342         * corelow.c: Do not include sys/file.h.
2343
2344 2019-01-22  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-wingeneral.h: Include gdb_curses.h.
2347
2348 2019-01-22  Tom Tromey  <tom@tromey.com>
2349
2350         * source-cache.h (class source_cache) <get_source_lines,
2351         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2352
2353 2019-01-22  Tom Tromey  <tom@tromey.com>
2354
2355         * remote-fileio.h (struct remote_target): Declare.
2356
2357 2019-01-22  Tom Tromey  <tom@tromey.com>
2358
2359         * python/py-arch.c: Do not include py-ref.h.
2360         * python/py-bpevent.c: Do not include py-ref.h.
2361         * python/py-cmd.c: Do not include py-ref.h.
2362         * python/py-continueevent.c: Do not include py-ref.h.
2363         * python/py-event.h: Do not include py-ref.h.
2364         * python/py-evtregistry.c: Do not include py-ref.h.
2365         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2366         * python/py-frame.c: Do not include py-ref.h.
2367         * python/py-framefilter.c: Do not include py-ref.h.
2368         * python/py-function.c: Do not include py-ref.h.
2369         * python/py-infevents.c: Do not include py-ref.h.
2370         * python/py-linetable.c: Do not include py-ref.h.
2371         * python/py-objfile.c: Do not include py-ref.h.
2372         * python/py-param.c: Do not include py-ref.h.
2373         * python/py-prettyprint.c: Do not include py-ref.h.
2374         * python/py-progspace.c: Do not include py-ref.h.
2375         * python/py-symbol.c: Do not include py-ref.h.
2376         * python/py-symtab.c: Do not include py-ref.h.
2377         * python/py-type.c: Do not include py-ref.h.
2378         * python/py-unwind.c: Do not include py-ref.h.
2379         * python/py-utils.c: Do not include py-ref.h.
2380         * python/py-value.c: Do not include py-ref.h.
2381         * python/py-varobj.c: Do not include py-ref.h.
2382         * python/py-xmethods.c: Do not include py-ref.h.
2383         * python/python.c: Do not include py-ref.h.
2384         * varobj.c: Do not include py-ref.h.
2385
2386 2019-01-22  Tom Tromey  <tom@tromey.com>
2387
2388         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2389         keyword for bcache.
2390
2391 2019-01-22  Tom Tromey  <tom@tromey.com>
2392
2393         * compile/compile-cplus-types.c: Remove a comment by #include.
2394
2395 2019-01-22  Tom Tromey  <tom@tromey.com>
2396
2397         * compile/gcc-c-plugin.h: Include compile-internal.h.
2398
2399 2019-01-22  Tom Tromey  <tom@tromey.com>
2400
2401         * stabsread.c (EXTERN): Do not define.
2402         (symnum, next_symbol_text_func, processing_gcc_compilation)
2403         (within_function, global_sym_chain, global_stabs)
2404         (previous_stab_code, this_object_header_files)
2405         (n_this_object_header_files)
2406         (n_allocated_this_object_header_files): Define.
2407         * stabsread.h (EXTERN): Never define.  Use "extern".
2408
2409 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2410
2411         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2412         history_value.
2413
2414 2019-01-21  Tom Tromey  <tom@tromey.com>
2415
2416         * ui-out.c: Fix includes.
2417         * tui/tui-source.c: Fix includes.
2418         * target.c: Fix includes.
2419         * remote.c: Fix includes.
2420         * regcache.c: Fix includes.
2421         * python/py-block.c: Fix includes.
2422         * printcmd.c: Fix includes.
2423         * or1k-tdep.c: Fix includes.
2424         * mi/mi-main.c: Fix includes.
2425         * m32r-tdep.c: Fix includes.
2426         * csky-tdep.c: Fix includes.
2427         * compile/compile-cplus-types.c: Fix includes.
2428         * cli/cli-interp.c: Fix includes.
2429
2430 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2431
2432         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2433         for padding.
2434
2435 2019-01-16  Tom Tromey  <tom@tromey.com>
2436
2437         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2438         earlier.
2439         (struct objfile) <msymbols_range>: Move from top level.
2440         <msymbols>: New method.
2441         (class objfile_msymbols): Remove.
2442         * symtab.c (default_collect_symbol_completion_matches_break_on):
2443         Update.
2444         * symmisc.c (dump_msymbols): Update.
2445         * stabsread.c (scan_file_globals): Update.
2446         * objc-lang.c (info_selectors_command, info_classes_command)
2447         (find_methods): Update.
2448         * minsyms.c (find_solib_trampoline_target): Update.
2449         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2450         * coffread.c (coff_symfile_read): Update.
2451         * ada-lang.c (ada_lookup_simple_minsym)
2452         (ada_collect_symbol_completion_matches): Update.
2453
2454 2019-01-16  Tom Tromey  <tom@tromey.com>
2455
2456         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2457         type.  Remove no-argument constructor.
2458         <iterator::operator++>: Simplify.
2459         <begin>: Update.
2460         <end>: Use minimal_symbol_count.
2461
2462 2019-01-16  Tom Tromey  <tom@tromey.com>
2463
2464         * objfiles.h (struct objfile) <psymtabs>: New method.
2465         (class objfile_psymtabs): Remove.
2466         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2467         typedef.
2468         <range>: New method.
2469         (require_partial_symbols): Change return type.
2470         * psymtab.c (require_partial_symbols)
2471         (psym_expand_symtabs_matching): Update.
2472         * mdebugread.c (parse_partial_symbols): Update.
2473         * dbxread.c (dbx_end_psymtab): Update.
2474
2475 2019-01-15  Tom Tromey  <tom@tromey.com>
2476
2477         * symtab.c (lookup_objfile_from_block)
2478         (lookup_symbol_in_objfile_symtabs)
2479         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2480         (find_line_symtab, info_sources_command)
2481         (default_collect_symbol_completion_matches_break_on)
2482         (make_source_files_completion_list): Update.
2483         * symmisc.c (print_objfile_statistics, dump_objfile)
2484         (maintenance_print_symbols, maintenance_info_symtabs)
2485         (maintenance_check_symtabs, maintenance_info_line_tables):
2486         Update.
2487         * source.c (select_source_symtab)
2488         (forget_cached_source_info_for_objfile): Update.
2489         * objfiles.h (class objfile_compunits): Remove.
2490         (struct objfile) <compunits_range>: New typedef.
2491         (compunits): New method.
2492         * objfiles.c (objfile_relocate1): Update.
2493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2494         * maint.c (count_symtabs_and_blocks): Update.
2495         * linespec.c (iterate_over_all_matching_symtabs): Update.
2496         * cp-support.c (add_symbol_overload_list_qualified): Update.
2497         * coffread.c (coff_symtab_read): Update.
2498         * ada-lang.c (add_nonlocal_symbols)
2499         (ada_collect_symbol_completion_matches)
2500         (ada_add_global_exceptions): Update.
2501
2502 2019-01-15  Tom Tromey  <tom@tromey.com>
2503
2504         * progspace.h (program_space) <objfiles_safe_range>: New
2505         typedef.
2506         <objfiles_safe>: New method.
2507         * objfiles.h (class all_objfiles_safe): Remove.
2508         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2509         * jit.c (jit_inferior_exit_hook): Update.
2510
2511 2019-01-17  Tom Tromey  <tom@tromey.com>
2512
2513         * progspace.h (program_space) <objfiles_range>: New typedef.
2514         <objfiles>: New method.
2515         <objfiles_head>: Rename from objfiles.
2516         (object_files): Update.
2517         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2518         * guile/scm-pretty-print.c
2519         (ppscm_find_pretty_printer_from_objfiles): Update.
2520         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2521         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2522         Update.
2523         * python/py-progspace.c (pspy_get_objfiles): Update.
2524         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2525         Update.
2526         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2527         (objfpy_lookup_objfile_by_build_id): Update.
2528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2529         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2530         Update.
2531         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2532         (expand_symtab_containing_pc, lookup_objfile_from_block)
2533         (lookup_static_symbol, basic_lookup_transparent_type)
2534         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2535         (find_line_symtab, info_sources_command)
2536         (default_collect_symbol_completion_matches_break_on)
2537         (make_source_files_completion_list, find_main_name): Update.
2538         * symmisc.c (print_symbol_bcache_statistics)
2539         (print_objfile_statistics, maintenance_print_symbols)
2540         (maintenance_print_msymbols, maintenance_print_objfiles)
2541         (maintenance_info_symtabs, maintenance_check_symtabs)
2542         (maintenance_expand_symtabs, maintenance_info_line_tables):
2543         Update.
2544         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2545         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2546         (map_overlay_command, unmap_overlay_command)
2547         (simple_overlay_update, expand_symtabs_matching)
2548         (map_symbol_filenames): Update.
2549         * symfile-debug.c (set_debug_symfile): Update.
2550         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2551         Update.
2552         * source.c (select_source_symtab, forget_cached_source_info):
2553         Update.
2554         * solib.c (solib_read_symbols): Update.
2555         * solib-spu.c (append_ocl_sos): Update.
2556         * psymtab.c (maintenance_print_psymbols)
2557         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2558         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2559         * printcmd.c (info_symbol_command): Update.
2560         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2561         Update.
2562         * objfiles.h (class all_objfiles): Remove.
2563         * objfiles.c (have_partial_symbols, have_full_symbols)
2564         (have_minimal_symbols, qsort_cmp, update_section_map)
2565         (shared_objfile_contains_address_p)
2566         (default_iterate_over_objfiles_in_search_order): Update.
2567         * objc-lang.c (info_selectors_command, info_classes_command)
2568         (find_methods): Update.
2569         * minsyms.c (find_solib_trampoline_target): Update.
2570         * maint.c (maintenance_info_sections)
2571         (maintenance_translate_address, count_symtabs_and_blocks):
2572         Update.
2573         * main.c (captured_main_1): Update.
2574         * linux-thread-db.c (try_thread_db_load_from_pdir)
2575         (has_libpthread): Update.
2576         * linespec.c (iterate_over_all_matching_symtabs)
2577         (search_minsyms_for_name): Update.
2578         * jit.c (jit_find_objf_with_entry_addr): Update.
2579         * hppa-tdep.c (find_unwind_entry)
2580         (hppa_lookup_stub_minimal_symbol): Update.
2581         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2582         Update.
2583         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2584         (elf_gnu_ifunc_resolve_by_got): Update.
2585         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2586         * dwarf-index-write.c (save_gdb_index_command): Update.
2587         * cp-support.c (add_symbol_overload_list_qualified): Update.
2588         * breakpoint.c (create_overlay_event_breakpoint)
2589         (create_longjmp_master_breakpoint)
2590         (create_std_terminate_master_breakpoint)
2591         (create_exception_master_breakpoint): Update.
2592         * blockframe.c (find_pc_partial_function): Update.
2593         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2594         (ada_collect_symbol_completion_matches)
2595         (ada_add_global_exceptions): Update.
2596
2597 2019-01-17  Tom Tromey  <tom@tromey.com>
2598
2599         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2600         declare VEC.
2601         (solib_target_parse_libraries): Change return type.
2602         (library_list_start_segment, library_list_start_section)
2603         (library_list_end_library, library_list_start_library); Update.
2604         (solib_target_free_library_list): Remove.
2605         (solib_target_parse_libraries): Remove cleanup.  Change return
2606         type.
2607         (solib_target_current_sos): Update.
2608
2609 2019-01-17  Tom Tromey  <tromey@bapiya>
2610
2611         * valprint.c: Replace "the the" with "the".
2612         * symtab.c: Replace "the the" with "the".
2613         * solib.c: Replace "the the" with "the".
2614         * solib-dsbt.c: Replace "the the" with "the".
2615         * linespec.c: Replace "the the" with "the".
2616         * dwarf2loc.h: Replace "the the" with "the".
2617         * amd64-windows-tdep.c: Replace "the the" with "the".
2618         * aarch64-tdep.c: Replace "the the" with "the".
2619
2620 2019-01-16  Keith Seitz  <keiths@redhat.com>
2621
2622         PR gdb/23773
2623         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2624         <builder>: Rename to ..
2625         <m_builder>: ... this and make private.
2626         (dwarf2_cu::get_builder): New method.  Change all users of
2627         `builder' to use this method.
2628         (dwarf2_start_symtab): Move to ...
2629         (dwarf2_cu::start_symtab): ... here.  Update all callers
2630         (setup_type_unit_groups): Move to ...
2631         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2632         callers.
2633         (dwarf2_cu::reset_builder): New method.
2634         (process_full_compunit, process_full_type_unit): Use
2635         dwarf2_cu::reset_builder.
2636         (follow_die_offset): Record the ancestor CU if it is different
2637         from the followed DIE's CU.
2638         (follow_die_sig_1): Likewise.
2639
2640 2019-01-15  Tom Tromey  <tom@tromey.com>
2641
2642         * remote.c (class remote_state) <buf>: Now a char_vector.
2643         <buf_size>: Remove.
2644         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2645         parameter.
2646         (remote_target::getpkt_or_notif_sane_1)
2647         (remote_target::getpkt_sane)
2648         (remote_target::getpkt_or_notif_sane): Likewise.
2649         (class remote_target) <putpkt>: New overload.
2650         (remote_target::read_frame): Change type of "buf_p".  Remove
2651         sizeof_p parameter.
2652         (packet_ok): New overload.
2653         (packet_check_result): New overload.
2654         Update all uses.
2655
2656 2019-01-14  Tom Tromey  <tom@tromey.com>
2657
2658         * remote-notif.c (handle_notification, remote_notif_ack)
2659         (remote_notif_parse): Make "buf" const.
2660         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2661         const.
2662         (remote_notif_parse, remote_notif_ack, handle_notification):
2663         Likewise.
2664         * remote.c (remote_notif_stop_parse): Make "buf" const.
2665         (remote_target::remote_parse_stop_reply): Make "buf" const.
2666         (remote_notif_stop_ack): Make "buf" const.
2667
2668 2019-01-14  Tom Tromey  <tom@tromey.com>
2669
2670         * remote.c (remote_console_output): Make parameter const.
2671
2672 2019-01-14  Tom Tromey  <tom@tromey.com>
2673
2674         * target-debug.h (target_debug_print_signals): Constify.
2675         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2676         * procfs.c (procfs_target::pass_signals): Update.
2677         * linux-nat.c (linux_nat_target::pass_signals): Update.
2678         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2679         * target-delegates.c: Rebuild.
2680         * remote.c (remote_target::program_signals): Update.
2681         (remote_target::pass_signals): Update.
2682         * target.c (target_pass_signals): Constify argument.
2683         (target_program_signals): Likewise.
2684         * target.h (struct target_ops) <pass_signals, program_signals>:
2685         Constify argument.
2686         (target_pass_signals, target_program_signals): Constify argument.
2687
2688 2019-01-14  Tom Tromey  <tom@tromey.com>
2689
2690         PR tui/28819:
2691         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2692
2693 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2694
2695         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2696         field.
2697         * rs6000-tdep.c: Include reggroups.h.
2698         (IS_V_ALIAS_PSEUDOREG): Define.
2699         (rs6000_register_name): Return names for the "vX" aliases.
2700         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2701         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2702         aliases.  Call default_register_reggroup_p for all other
2703         pseudo-registers.
2704         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2705         New functions.
2706         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2707         Handle "vX" aliases.
2708         (v_alias_pseudo_register_collect): New function.
2709         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2710         (rs6000_gdbarch_init): Initialize "vX" aliases as
2711         pseudo-registers.  Restore registration of
2712         rs6000_pseudo_register_reggroup_p with
2713         set_tdesc_pseudo_register_reggroup_p.
2714
2715 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2716
2717         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2718         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2719         set_gdbarch_num_pseudo_regs.
2720
2721 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2722
2723         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2724         Remove arg prefixname, add do_set and do_show.
2725         Add member functions set_list and show_list.
2726         * cli/cli-style.c (class cli_style_option): Update accordingly.
2727         (style_set_list): Move to file scope.
2728         (style_show_list): Likewise.
2729         (set_style): Call help_list.
2730         (show_style): Call cmd_show_list.
2731         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2732         Update to use the new macro.
2733
2734 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2735
2736         * ada-lang.c (_initialize_ada_language): Expand the help text
2737         for the "catch exception" command.
2738
2739 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2740
2741         * symtab.c (matching_obj_sections): Initialize obj,
2742         declare it closer to its usage.
2743
2744 2019-01-10  Tom Tromey  <tom@tromey.com>
2745
2746         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2747         (basic_inf_threads_range): Remove.
2748         (inf_threads_range, inf_non_exited_threads_range)
2749         (safe_inf_threads_range): Use next_adapter.
2750
2751 2019-01-10  Keith Seitz  <keiths@redhat.com>
2752
2753         PR gdb/23712
2754         PR symtab/23010
2755         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2756         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2757
2758 2019-01-10  Keith Seitz  <keiths@redhat.com>
2759
2760         PR gdb/23712
2761         PR symtab/23010
2762         * dictionary.c (pending_to_vector): Remove.
2763         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2764         Remove _1 suffix, replacing functions of the same name.  Update
2765         all callers.
2766         (dict_create_hashed, dict_create_hashed_expandable)
2767         (dict_create_linear, dict_create_linear_expandable, dict_free)
2768         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2769         Make functions static.
2770
2771 2019-01-10  Keith Seitz  <keiths@redhat.com>
2772
2773         PR gdb/23712
2774         PR symtab/23010
2775         * dictionary.h (struct dictionary): Replace declaration with
2776         multidictionary.
2777         (dict_create_hashed, dict_create_hashed_expandable)
2778         (dict_create_linear, dict_create_linear_expandable)
2779         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2780         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2781         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2782         taking multidictionary argument.
2783         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2784         * block.h (struct block) <dict>: Change to multidictionary
2785         and rename `multidict'.
2786         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2787         symmisc.c: Update all dictionary references to multidictionary.
2788
2789 2019-01-10  Keith Seitz  <keiths@redhat.com>
2790
2791         PR gdb/23712
2792         PR symtab/23010
2793         * dictionary.c: Include unordered_map.
2794         (pending_to_vector): New function.
2795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2796         Rewrite the non-"_1" functions to take vector instead
2797         of linked list.
2798         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2799         "new" _1 versions of the same name.
2800         (multidictionary): Define.
2801         (std::hash<enum language): New definition.
2802         (collate_pending_symbols_by_language, mdict_create_hashed)
2803         (mdict_create_hashed_expandable, mdict_create_linear)
2804         (mdict_create_linear_expandable, mdict_free)
2805         (find_language_dictionary, create_new_language_dictionary)
2806         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2807         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2808         (mdict_size, mdict_empty): New functions.
2809         * dictionary.h (mdict_iterator): Define.
2810
2811 2019-01-10  Pedro Alves  <palves@redhat.com>
2812
2813         * breakpoint.c (read_uploaded_action)
2814         (create_tracepoint_from_upload): Adjust to use
2815         gdb::unique_xmalloc_ptr.
2816         * ctf.c (ctf_write_uploaded_tp):
2817         (SET_ARRAY_FIELD): Use emplace_back.
2818         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2819         * tracefile-tfile.c (tfile_write_uploaded_tp):
2820         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2821         gdb::unique_xmalloc_ptr.
2822         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2823         at_string, cond_string, cmd_strings>: Replace char pointers
2824         with gdb::unique_xmalloc_ptr.
2825
2826 2019-01-10  Pedro Alves  <palves@redhat.com>
2827
2828         * solib-target.c (library_list_start_library): Don't xstrdup name.
2829
2830 2019-01-10  Pedro Alves  <palves@redhat.com>
2831
2832         * mdebugread.c (parse_partial_symbols): Use
2833         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2834
2835 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * linux-fork.c (scoped_switch_fork_info)
2838         <~scoped_switch_fork_info>: Fix incorrect variable name.
2839
2840 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * linux-fork.c (scoped_switch_fork_info)
2843         <scoped_switch_fork_info>: Make explicit.
2844         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2845
2846 2019-01-10  Tom Tromey  <tom@tromey.com>
2847
2848         * objfiles.h (objfile::reset_psymtabs): Update.
2849         * objfiles.c (objfile::objfile): Update.
2850         * psymtab.h (psymtab_storage::obstack): Update.
2851         (psymtab_storage::m_obstack): Use gdb::optional.
2852         (class psymtab_storage): Update comment.  Remove objfile
2853         parameter.
2854         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2855
2856 2019-01-10  Tom Tromey  <tom@tromey.com>
2857
2858         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2859         <free_psymtabs>: Now private.
2860         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2861         (allocate_psymtab): Use new method.
2862
2863 2019-01-10  Tom Tromey  <tom@tromey.com>
2864
2865         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2866         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2867         * mdebugread.c (parse_partial_symbols): Use
2868         allocate_dependencies.
2869         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2870         allocate_dependencies.
2871         (process_psymtab_comp_unit_reader)
2872         (build_type_psymtab_dependencies): Likewise.
2873         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2874
2875 2019-01-10  Tom Tromey  <tom@tromey.com>
2876
2877         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2878         PSYMBOL_SET_LANGUAGE.
2879         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2880
2881 2019-01-10  Tom Tromey  <tom@tromey.com>
2882
2883         * psymtab.h (psymtab_storage::obstack): New method.
2884         <m_obstack>: Rename from obstack; now private.
2885         * psymtab.c (psymtab_storage): Update.
2886         * dwarf2read.c (create_addrmap_from_index)
2887         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2888         Update.
2889
2890 2019-01-10  Tom Tromey  <tom@tromey.com>
2891
2892         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2893         * objfiles.h (objfile::reset_psymtabs): New method.
2894
2895 2019-01-10  Tom Tromey  <tom@tromey.com>
2896
2897         * symmisc.c (print_symbol_bcache_statistics): Update.
2898         (print_objfile_statistics): Update.
2899         * symfile.c (reread_symbols): Update.
2900         * psymtab.h (class psymtab_storage): New.
2901         * psymtab.c (psymtab_storage): New constructor.
2902         (~psymtab_storage): New destructor.
2903         (require_partial_symbols): Update.
2904         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2905         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2906         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2907         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2908         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2909         (start_psymtab_common, end_psymtab_common)
2910         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2911         (allocate_psymtab): Update.
2912         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2913         Update.
2914         (dump_psymtab_addrmap, maintenance_print_psymbols)
2915         (maintenance_check_psymtabs): Update.
2916         (class objfile_psymtabs): Move to objfiles.h.
2917         * psympriv.h (discard_psymtab): Now inline.
2918         (psymtab_discarder::psymtab_discarder): Update.
2919         (psymtab_discarder::~psymtab_discarder): Update.
2920         (ALL_OBJFILE_PSYMTABS): Rewrite.
2921         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2922         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2923         Remove fields.
2924         <partial_symtabs>: New field.
2925         (class objfile_psymtabs): Move from psymtab.h.  Update.
2926         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2927         psymbol_cache.
2928         (objfile::~objfile): Don't destroy psymbol_cache.
2929         * mdebugread.c (parse_partial_symbols): Update.
2930         * dwarf2read.c (create_addrmap_from_index)
2931         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2932         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2933         (add_partial_subprogram, dwarf2_ranges_read): Update.
2934         * dwarf-index-write.c (write_address_map)
2935         (write_one_signatured_type, recursively_write_psymbols)
2936         (class debug_names, class debug_names, write_psymtabs_to_index):
2937         Update.
2938
2939 2019-01-10  Tom Tromey  <tom@tromey.com>
2940
2941         * symtab.h (SYMBOL_SET_NAMES): Update.
2942         (symbol_set_names): Update.
2943         (MSYMBOL_SET_NAMES): Update.
2944         * symtab.c (symbol_set_names): Change argument to be an
2945         objfile_per_bfd_storage.
2946         * psymtab.c (add_psymbol_to_bcache): Update.
2947         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2948
2949 2019-01-10  Tom Tromey  <tom@tromey.com>
2950
2951         * symtab.c (create_demangled_names_hash): Change argument to be an
2952         objfile_per_bfd_storage.
2953         (symbol_set_names): Update.
2954
2955 2019-01-10  Tom Tromey  <tom@tromey.com>
2956
2957         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2958         init_psymbol_list.
2959         * psymtab.c (init_psymbol_list): Do nothing if already called.
2960         * psympriv.h (init_psymbol_list): Add comment.
2961         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2962         init_psymbol_list.
2963         * dbxread.c (dbx_symfile_read): Unconditionally call
2964         init_psymbol_list.
2965
2966 2019-01-10  Tom Tromey  <tom@tromey.com>
2967
2968         * xcoffread.c (scan_xcoff_symtab): Update.
2969         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2970         "where".
2971         * mdebugread.c (parse_partial_symbols)
2972         (handle_psymbol_enumerators): Update.
2973         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2974         * dbxread.c (read_dbx_symtab): Update.
2975         * psympriv.h (psymbol_placement): New enum.
2976         (add_psymbol_to_list): Update.
2977
2978 2019-01-10  Tom Tromey  <tom@tromey.com>
2979
2980         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2981         static_psymbols parameters.
2982         (scan_xcoff_symtab): Update.
2983         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2984         static_psymbols parameters.
2985         * psympriv.h (start_psymtab_common): Update.
2986         * mdebugread.c (parse_partial_symbols): Update.
2987         * dwarf2read.c (create_partial_symtab): Update.
2988         * dbxread.c (read_dbx_symtab): Update.
2989         (start_psymtab): Remove global_psymbols and static_psymbols
2990         parameters.
2991
2992 2019-01-10  Tom Tromey  <tom@tromey.com>
2993
2994         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2995         * psymtab.c (allocate_psymtab): Add comment.
2996         * psympriv.h (allocate_psymtab): Add comment.
2997         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2998         initializations.
2999         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3000
3001 2019-01-10  Tom Tromey  <tom@tromey.com>
3002
3003         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3004         Don't declare.
3005         * mipsread.c: Include mdebugread.h.
3006         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3007         Declare.
3008         * elfread.c: Include mdebugread.h.
3009
3010 2019-01-09  Tom Tromey  <tom@tromey.com>
3011
3012         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3013         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3014         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3015         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3016         (psym_lookup_symbol, psym_find_last_source_symtab)
3017         (psym_forget_cached_source_info, psym_print_stats)
3018         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3019         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3020         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3021         (psym_find_compunit_symtab_by_address)
3022         (maintenance_print_psymbols, maintenance_info_psymtabs)
3023         (maintenance_check_psymtabs): Use ranged for.
3024         * psymtab.h (class objfile_psymtabs): New.
3025         (require_partial_symbols): Return objfile_psymtabs.
3026         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3027
3028 2019-01-09  Tom Tromey  <tom@tromey.com>
3029
3030         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3031         (find_pc_mapped_section, list_overlays_command)
3032         (map_overlay_command, unmap_overlay_command)
3033         (simple_overlay_update): Use all_objfiles.
3034         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3035         * printcmd.c (info_symbol_command): Use all_objfiles.
3036         * objfiles.h (ALL_OBJSECTIONS): Remove.
3037         * maint.c (maintenance_translate_address): Use all_objfiles.
3038         * gcore.c (gcore_create_callback): Use all_objfiles.
3039         (objfile_find_memory_regions): Likewise.
3040
3041 2019-01-09  Tom Tromey  <tom@tromey.com>
3042
3043         * symtab.c (find_line_symtab, info_sources_command)
3044         (make_source_files_completion_list): Use objfile_compunits.
3045         * source.c (select_source_symtab): Use objfile_compunits.
3046         * objfiles.h (struct objfile): Update comment.
3047         (ALL_OBJFILES): Remove.
3048         (ALL_FILETABS): Remove.
3049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3050         objfile_compunits.
3051
3052 2019-01-09  Tom Tromey  <tom@tromey.com>
3053
3054         * symmisc.c (print_objfile_statistics, dump_objfile)
3055         (maintenance_print_symbols): Use compunit_filetabs.
3056         * source.c (forget_cached_source_info_for_objfile): Use
3057         compunit_filetabs.
3058         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3059         (ALL_FILETABS): Use compunit_filetabs.
3060         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3061         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3062
3063 2019-01-09  Tom Tromey  <tom@tromey.com>
3064
3065         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3066         (compunit_filetabs): New.
3067         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3068         compunit_filetabs.
3069         (info_sources_command, make_source_files_completion_list): Remove
3070         declaration.
3071         * symmisc.c (print_objfile_statistics, dump_objfile)
3072         (maintenance_print_symbols): Remove declaration.
3073         (maintenance_info_symtabs): Use compunit_filetabs.
3074         (maintenance_info_line_tables): Likewise.
3075         * source.c (select_source_symtab): Change local variable name.
3076         (forget_cached_source_info_for_objfile): Remove declaration.
3077         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3078         * objfiles.c (objfile_relocate1): Remove declaration.
3079         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3080         declaration.
3081         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3082         * coffread.c (coff_symtab_read): Remove declaration.
3083         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3084         compunit_filetabs.
3085
3086 2019-01-09  Tom Tromey  <tom@tromey.com>
3087
3088         * symtab.c (lookup_objfile_from_block)
3089         (find_pc_sect_compunit_symtab, search_symbols)
3090         (default_collect_symbol_completion_matches_break_on): Use
3091         objfile_compunits.
3092         * objfiles.h (ALL_COMPUNITS): Remove.
3093         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3094         * cp-support.c (add_symbol_overload_list_qualified): Use
3095         objfile_compunits.
3096         * ada-lang.c (ada_collect_symbol_completion_matches)
3097         (ada_add_global_exceptions): Use objfile_compunits.
3098
3099 2019-01-09  Tom Tromey  <tom@tromey.com>
3100
3101         * source.c (select_source_symtab)
3102         (forget_cached_source_info_for_objfile): Remove declaration.
3103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3104         declaration.
3105         * maint.c (count_symtabs_and_blocks): Remove declaration.
3106         * cp-support.c (add_symbol_overload_list_qualified): Remove
3107         declaration.
3108         * coffread.c (coff_symtab_read): Remove declaration.
3109         * symtab.c (lookup_symbol_in_objfile_symtabs)
3110         (basic_lookup_transparent_type_1): Use objfile_compunits.
3111         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3112         (info_sources_command, search_symbols)
3113         (default_collect_symbol_completion_matches_break_on)
3114         (make_source_files_completion_list): Remove declaration.
3115         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3116         (ada_collect_symbol_completion_matches)
3117         (ada_add_global_exceptions): Remove declaration.
3118         * linespec.c (iterate_over_all_matching_symtabs): Use
3119         objfile_compunits.
3120         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3121         (class objfile_compunits): New.
3122         (ALL_COMPUNITS): Use objfile_compunits.
3123         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3124         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3125         objfile_compunits.
3126         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3127
3128 2019-01-09  Tom Tromey  <tom@tromey.com>
3129
3130         * symtab.c (search_symbols)
3131         (default_collect_symbol_completion_matches_break_on): Use
3132         objfile_msymbols.
3133         * ada-lang.c (ada_lookup_simple_minsym)
3134         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3135         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3136         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3137         objfile_msymbols.
3138         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3139         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3140         * objc-lang.c (find_methods): Use objfile_msymbols.
3141         (info_selectors_command, info_classes_command): Likewise.
3142         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3143         * objfiles.h (class objfile_msymbols): New.
3144         (ALL_OBJFILE_MSYMBOLS): Remove.
3145         (ALL_MSYMBOLS): Remove.
3146
3147 2019-01-09  Tom Tromey  <tom@tromey.com>
3148
3149         * common/next-iterator.h (next_adapter): Add Iterator template
3150         parameter.
3151         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3152         (class all_objfiles_safe): New.
3153         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3154         * objfiles.c (put_objfile_before): Update comment.
3155         (add_separate_debug_objfile): Likewise.
3156         (free_all_objfiles): Use all_objfiles_safe.
3157         (objfile_purge_solibs): Likewise.
3158
3159 2019-01-09  Tom Tromey  <tom@tromey.com>
3160
3161         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3162         (expand_symtab_containing_pc, lookup_static_symbol)
3163         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3164         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3165         all_objfiles.
3166         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3167         * breakpoint.c (create_overlay_event_breakpoint)
3168         (create_longjmp_master_breakpoint)
3169         (create_std_terminate_master_breakpoint)
3170         (create_exception_master_breakpoint): Use all_objfiles.
3171         * linux-thread-db.c (try_thread_db_load_from_pdir)
3172         (has_libpthread): Use all_objfiles.
3173         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3174         * linespec.c (iterate_over_all_matching_symtabs)
3175         (search_minsyms_for_name): Use all_objfiles.
3176         * maint.c (maintenance_info_sections): Use all_objfiles.
3177         * main.c (captured_main_1): Use all_objfiles.
3178         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3179         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3180         * guile/scm-pretty-print.c
3181         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3182         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3183         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3184         (maintenance_print_msymbols): Use all_objfiles.
3185         * source.c (select_source_symtab): Use all_objfiles.
3186         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3187         * symfile.c (remove_symbol_file_command)
3188         (expand_symtabs_matching, map_symbol_filenames): Use
3189         all_objfiles.
3190         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3191         all_objfiles.
3192         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3193         * objc-lang.c (find_methods): Use all_objfiles.
3194         * objfiles.c (have_partial_symbols, have_full_symbols)
3195         (have_minimal_symbols, qsort_cmp)
3196         (default_iterate_over_objfiles_in_search_order): Use
3197         all_objfiles.
3198         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3199         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3200         (maintenance_check_psymtabs): Use all_objfiles.
3201         (ALL_PSYMTABS): Remove.
3202         * compile/compile-object-run.c (do_module_cleanup): Use
3203         all_objfiles.
3204         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3205         * cp-support.c (add_symbol_overload_list_qualified): Use
3206         all_objfiles.
3207         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3208         Use all_objfiles.
3209         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3210         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3211         all_objfiles.
3212         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3213         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3214         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3215         Uses all_objfiles.
3216         * solib.c (solib_read_symbols): Use all_objfiles
3217
3218 2019-01-09  Tom Tromey  <tom@tromey.com>
3219
3220         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3221         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3222         all_objfiles.
3223         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3224         * symmisc.c (print_symbol_bcache_statistics)
3225         (print_objfile_statistics, maintenance_print_objfiles)
3226         (maintenance_info_symtabs, maintenance_check_symtabs)
3227         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3228         all_objfiles.
3229         * source.c (forget_cached_source_info): Use all_objfiles.
3230         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3231         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3232         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3233         * objfiles.c (update_section_map): Use all_objfiles.
3234         (shared_objfile_contains_address_p): Likewise.
3235         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3236         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3237
3238 2019-01-09  Tom Tromey  <tom@tromey.com>
3239
3240         * common/next-iterator.h: New file.
3241         * objfiles.h (class all_objfiles): New.
3242         (struct objfile_iterator): New.
3243
3244 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3245
3246         * NEWS: Move the description of the changed "frame", "select-frame",
3247          and "info frame" commands to the Changed commands section.
3248
3249 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3250
3251         * gdbtypes.c (check_stub_method_group): Remove handling of old
3252         mangling schemes.
3253         * linespec.c (find_methods): Likewise.
3254         * stabsread.c (read_member_functions): Likewise.
3255         * valops.c (search_struct_method): Likewise.
3256         (value_struct_elt_for_reference): Likewise.
3257         * NEWS: Mention this change.
3258
3259 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3262         print_source_lines.
3263         * source.c (print_source_lines_base): Update line number check.
3264         (print_source_lines): New function.
3265         (source_lines_range::source_lines_range): New function.
3266         * source.h (class source_lines_range): New class.
3267         (print_source_lines): New declaration.
3268
3269 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3270
3271         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3272
3273 2019-01-08  Tom Tromey  <tom@tromey.com>
3274             Simon Marchi  <simon.marchi@ericsson.com>
3275
3276         PR gdb/24060
3277         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3278         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3279         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3280         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3281         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3282         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3283
3284 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * source.c (select_source_symtab): Move header comment to
3287         declaration in source.h.
3288         (forget_cached_source_info_for_objfile): Likewise.
3289         (forget_cached_source_info): Likewise.
3290         (identify_source_line): Likewise.
3291         * source.h (identify_source_line): Move declaration from symtab.h
3292         and add comment from source.c
3293         (print_source_lines): Likewise.
3294         (forget_cached_source_info_for_objfile): Likewise.
3295         (forget_cached_source_info): Likewise.
3296         (select_source_symtab): Likewise.
3297         (enum print_source_lines_flag): Move definition from symtab.h.
3298         * symtab.h (identify_source_line): Move declaration to source.h.
3299         (print_source_lines): Likewise.
3300         (forget_cached_source_info_for_objfile): Likewise.
3301         (forget_cached_source_info): Likewise.
3302         (select_source_symtab): Likewise.
3303         (enum print_source_lines_flag): Move definition to source.h.
3304         * tui/tui-hooks.c: Add 'source.h' include.
3305
3306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * source.c (print_source_lines_base): Handle requests to print
3309         reverse line number sequences, and guard against empty lines
3310         string.
3311
3312 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3313
3314         * source.c (print_source_lines_base): Fix skip of '\r' if next
3315         character is '\n'.
3316
3317 2019-01-06  Tom Tromey  <tom@tromey.com>
3318
3319         * c-exp.y (struct c_parse_state) <macro_original_text,
3320         expansion_obstack>: New member.
3321         (macro_original_text, expansion_obstack): Remove globals.
3322         (scan_macro_expansion, scanning_macro_expansion)
3323         (finished_macro_expansion): Update.
3324         (scan_macro_cleanup): Remove.
3325         (yylex, c_parse): Update.
3326
3327 2019-01-06  Tom Tromey  <tom@tromey.com>
3328
3329         * c-exp.y (struct c_parse_state) <strings>: New member.
3330         (operator_stoken): Update.
3331
3332 2019-01-06  Tom Tromey  <tom@tromey.com>
3333
3334         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3335         (union type_stack_elt) <typelist_val>: Now a pointer to
3336         std::vector.
3337         (type_stack_cleanup): Don't declare.
3338         (push_typelist): Update.
3339         * parse.c (pop_typelist): Return a std::vector.
3340         (push_typelist): Take a std::vector.
3341         (follow_types): Update.  Do not free args.
3342         (type_stack_cleanup): Remove.
3343         * c-exp.y (struct c_parse_state): New.
3344         (cpstate): New global.
3345         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3346         (nonempty_typelist): Update.
3347         (func_mod): Create a new vector.
3348         (c_parse): Create a c_parse_state.
3349         (check_parameter_typelist): Do not delete params.
3350         (function_method): Update.  Do not delete type_list.
3351
3352 2019-01-06  Tom Tromey  <tom@tromey.com>
3353
3354         PR gdb/28155:
3355         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3356         check_typedef.
3357         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3358         (print_return_value): Likewise.
3359
3360 2019-01-05  Tom Tromey  <tom@tromey.com>
3361
3362         * contrib/cleanup_check.py: Remove.
3363         * contrib/gcc-with-excheck: Remove.
3364         * contrib/exsummary.py: Remove.
3365         * contrib/excheck.py: Remove.
3366
3367 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3368
3369         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3370         NULL. Initialize tpprev to NULL instead of assigning it
3371         to NULL on the next statement.
3372         * windows-nat.c (windows_delete_thread): Remove check for
3373         main_thread_id before printing thread exit notifications.
3374         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3375         Remove thread ID check against main_thread_id.
3376         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3377         windows_delete_thread.
3378         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3379
3380 2019-01-04  Tom Tromey  <tom@tromey.com>
3381
3382         * compile/compile.c (_initialize_compile): Use upper case for
3383         metasyntactic variables.
3384         * symmisc.c (_initialize_symmisc): Use upper case for
3385         metasyntactic variables.
3386         * psymtab.c (_initialize_psymtab): Use upper case for
3387         metasyntactic variables.
3388         * demangle.c (demangle_command): Use upper case for metasyntactic
3389         variables.
3390         (_initialize_demangler): Likewise.
3391         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3392         variables.
3393
3394 2019-01-03  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3397
3398 2019-01-03  Tom Tromey  <tom@tromey.com>
3399
3400         * python/py-symtab.c (salpy_str): Update.
3401         (struct salpy_sal_object) <symtab>: Now a PyObject.
3402         (salpy_dealloc): Update.
3403         (del_objfile_sal): Use gdbpy_ref.
3404
3405 2019-01-03  Tom Tromey  <tom@tromey.com>
3406
3407         * python/py-type.c (convert_field): Use new_reference.  Return
3408         gdbpy_ref.
3409         (make_fielditem): Return gdbpy_ref.
3410         (typy_fields): Update.
3411         (typy_getitem): Update.
3412         (field_name): Return gdbpy_ref.  Use new_reference.
3413         (typy_iterator_iternext): Update.
3414
3415 2019-01-03  Tom Tromey  <tom@tromey.com>
3416
3417         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3418
3419 2019-01-03  Tom Tromey  <tom@tromey.com>
3420
3421         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3422         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3423         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3424         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3425         (pspy_set_type_printers): Likewise.
3426         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3427         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3428         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3429         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3430         (objfpy_set_type_printers): Likewise.
3431
3432 2019-01-03  Tom Tromey  <tom@tromey.com>
3433
3434         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3435         (gdbpy_print_stack): Use gdbpy_err_fetch.
3436         * python/python-internal.h (class gdbpy_err_fetch): New class.
3437         (class gdbpy_enter) <m_error_type, m_error_value,
3438         m_error_traceback>: Remove.
3439         <m_error>: New member.
3440         (gdbpy_exception_to_string): Don't declare.
3441         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3442         * python/py-value.c (convert_value_from_python): Use
3443         gdbpy_err_fetch.
3444         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3445         gdbpy_exception_to_string.
3446         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3447         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3448         gdbpy_err_fetch.
3449
3450 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * linux-nat.c (delete_lwp_cleanup): Delete.
3453         (struct lwp_deleter): New struct.
3454         (lwp_info_up): New typedef.
3455         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3456         lwp_info_up.
3457
3458 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3459
3460         * linux-fork.c (class scoped_switch_fork_info): New class.
3461         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3462
3463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * valops.c (find_overload_match): Remove use of null_cleanup, and
3466         calls to do_cleanups.
3467
3468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * compile/compile-cplus-types.c
3471         (compile_cplus_instance::decl_name): Handle changes to
3472         cp_func_name.
3473         * cp-support.c (cp_func_name): Update header comment, update
3474         return type.
3475         * cp-support.h (cp_func_name): Update return type in declaration.
3476         * valops.c (find_overload_match): Move temp_func local to top
3477         level of function and change its type.  Use temp_func to hold and
3478         delete temporary string obtained from cp_func_name.
3479
3480 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3483         gdb::char_vector, remove cleanup, and update uses of `msg`.
3484
3485 2019-01-03  Jim Wilson  <jimw@sifive.com>
3486
3487         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3488
3489 2019-01-02  Tom Tromey  <tom@tromey.com>
3490
3491         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3492         (tdesc_parse_xml): Remove cleanups.
3493         * target-descriptions.h (make_cleanup_free_target_description):
3494         Don't declare.
3495         (target_desc_deleter): New struct.
3496         (target_desc_up): New typedef.
3497         * target-descriptions.c (target_desc_deleter::operator()): Rename
3498         from free_target_description.
3499         (make_cleanup_free_target_description): Remove.
3500
3501 2019-01-02  Tom Tromey  <tom@tromey.com>
3502
3503         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3504         constructor, destructor.
3505         (linespec_parser): Remove typedef.
3506         (~linespec_parser): Rename from linespec_parser_delete.
3507         (linespec_lex_to_end, linespec_complete_label)
3508         (linespec_complete): Update.
3509         (decode_line_full): Remove cleanups.
3510         (decode_line_1): Update.
3511
3512 2019-01-02  Tom Tromey  <tom@tromey.com>
3513
3514         * python/python-internal.h (inferior_to_inferior_object): Change
3515         return type.
3516         * python/py-exitedevent.c (create_exited_event_object): Update.
3517         * python/py-inferior.c (inferior_to_inferior_object): Return
3518         gdbpy_ref.
3519         (python_new_inferior, python_inferior_deleted)
3520         (thread_to_thread_object, delete_thread_object)
3521         (build_inferior_list, gdbpy_selected_inferior): Update.
3522         * python/py-infthread.c (create_thread_object): Update.  Also fail
3523         if inferior_to_inferior_object fails.
3524
3525 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3526
3527         * inferior.h (class inferior) <displaced_step_state>: New field.
3528         * infrun.h (struct displaced_step_state): Move here from
3529         infrun.c.  Initialize fields, add constructor.
3530         <inf>: Remove field.
3531         <reset>: New method.
3532         * infrun.c (struct displaced_step_inferior_state): Move to
3533         infrun.h.
3534         (displaced_step_inferior_states): Remove.
3535         (get_displaced_stepping_state): Adust.
3536         (displaced_step_in_progress_any_inferior): Adjust.
3537         (displaced_step_in_progress_thread): Adjust.
3538         (displaced_step_in_progress): Adjust.
3539         (add_displaced_stepping_state): Remove.
3540         (get_displaced_step_closure_by_addr): Adjust.
3541         (remove_displaced_stepping_state): Remove.
3542         (infrun_inferior_exit): Call displaced_step_state.reset.
3543         (use_displaced_stepping): Don't check for NULL.
3544         (displaced_step_prepare_throw): Call
3545         get_displaced_stepping_state.
3546         (displaced_step_fixup): Don't check for NULL.
3547         (prepare_for_detach): Don't check for NULL.
3548
3549 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3550
3551         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3552          in case of call that did not complete.
3553
3554 2019-01-02  Andrey Utkin  <autkin@undo.io>
3555
3556         * symfile.c (find_separate_debug_file): Fix search of debug files for
3557         remote debuggee.
3558
3559 2019-01-02  Tom Tromey  <tom@tromey.com>
3560
3561         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3562         indentation.
3563         * python/py-frame.c (frapy_older): Remove cast.
3564         (frapy_newer): Likewise.
3565         * python/py-breakpoint.c (local_setattro): Remove cast.
3566         * python/py-arch.c (archpy_name): Remove local variable.
3567         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3568
3569 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3570
3571         * unittests/basic_string_view/element_access/char/empty.cc:
3572         Fix year range in copyright header.
3573
3574 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3577         Delete.
3578         <operator==>: Update with for removed field.
3579         <hash>: Likewise.
3580         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3581         <isa_features>: ...this.
3582         <abi_features>: New field.
3583         (riscv_isa_flen): Update comment.
3584         (riscv_abi_xlen): New declaration.
3585         (riscv_abi_flen): New declaration.
3586         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3587         isa_features.
3588         (riscv_abi_xlen): New function.
3589         (riscv_isa_flen): Update to get answer from isa_features.
3590         (riscv_abi_flen): New function.
3591         (riscv_has_fp_abi): Update to get answer from abi_features.
3592         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3593         xlen and flen.
3594         (riscv_call_info) <xlen, flen>: Update comment.
3595         (riscv_call_arg_struct): Remove invalid assertions
3596         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3597         is removed.
3598         (riscv_gdbarch_init): Gather isa features and abi features
3599         separately, ensure both match on the gdbarch when reusing an old
3600         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3601         a target with 64-bit float hardware.
3602
3603 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * source.c (search_command_helper): Stop reverse search
3606         when line 1 has been searched.
3607
3608 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3609
3610         * record-full.c (record_full_base_target::close): Rewrite
3611         record_full_core_buf_list free logic.
3612
3613 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3614
3615         * break-catch-syscall.c (print_one_catch_syscall): xfree
3616         the last text.
3617
3618 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3619
3620         * top.c (print_gdb_version): Update Copyright year in version
3621         message.
3622
3623 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3624
3625         Update copyright year range in all GDB files.
3626
3627 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3628
3629         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3630
3631 For older changes see ChangeLog-2018.
3632 \f
3633 Local Variables:
3634 mode: change-log
3635 left-margin: 8
3636 fill-column: 74
3637 version-control: never
3638 coding: utf-8
3639 End:
3640