gdb/ChangeLog

   1 2019-04-30  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (ada_lookup_simple_minsyms): New function.
   4         (create_excep_cond_exprs): Iterate over program spaces.
   5         (ada_exception_catchpoint_cond_string): Examine all minimal
   6         symbols for exception types.
   7
   8 2019-04-30  Tom Tromey  <tromey@adacore.com>
   9
  10         PR c++/24470:
  11         * dwarf2read.c (process_structure_scope): Handle case where type
  12         has template parameters but no symbol was created.
  13
  14 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  15             Chris January  <chris.january@arm.com>
  16
  17         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  18         qualifier.
  19         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  20
  21 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * f-typeprint.c (f_print_type): Update rules for printing
  24         whitespace.
  25         (f_type_print_varspec_suffix): Likewise.
  26
  27 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  28             Chris January  <chris.january@arm.com>
  29
  30         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  31         function arguments.
  32
  33 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  34
  35         * f-lang.c (build_fortran_types): Change name of void type to
  36         lower case.
  37         * f-typeprint.c (f_type_print_base): Print the name of the void
  38         type, rather than a fixed string.
  39         * f-valprint.c (f_decorations): Use lower case void string.
  40
  41 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  42             Chris January  <chris.january@arm.com>
  43
  44         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  45         types for Fortran.
  46
  47 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  48             Chris January  <chris.january@arm.com>
  49             David Lecomber  <david.lecomber@arm.com>
  50
  51         * f-exp.y (BINOP_INTRINSIC): New token.
  52         (exp): New parser rule handling BINOP_INTRINSIC.
  53         (f77_keywords): Add new builtin procedures.
  54         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  55         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  56         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  57         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  58         (print_unop_subexp_f): New function.
  59         (print_binop_subexp_f): New function.
  60         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  61         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  62         (dump_subexp_body_f): Likewise.
  63         (operator_check_f): Likewise.
  64         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  65         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  66
  67 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  68
  69         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  70         UNOP_KIND.
  71         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  72         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  73         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  74         (operator_length_f): New fuction.
  75         (print_subexp_f): New function.
  76         (op_name_f): New function.
  77         (dump_subexp_body_f): New function.
  78         (operator_check_f): New function.
  79         (exp_descriptor_f): Replace standard expression handling functions
  80         with new functions.
  81         * gdb/fortran-operator.def: New file.
  82         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  83         * gdb/std-operator.def: Remove UNOP_KIND.
  84
  85 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * std-operator.def: Remove unbalanced, stray double quote
  88         character.
  89
  90 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  91             Chris January  <chris.january@arm.com>
  92             Daniel Everett  <daniel.everett@arm.com>
  93             Nick Forrington  <nick.forrington@arm.com>
  94             Richard Bunt  <richard.bunt@arm.com>
  95
  96         * cp-valprint.c (cp_print_value_fields): Allow an additional level
  97         of depth when printing anonymous structs or unions.
  98         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  99         Don't print either the top-level value, or the children if the
 100         max-depth is exceeded.
 101         (ppscm_print_children): When printing the key of a map, allow one
 102         extra level of depth.
 103         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 104         print either the top-level value, or the children if the max-depth
 105         is exceeded.
 106         (print_children): When printing the key of a map, allow one extra
 107         level of depth.
 108         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 109         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 110         (user_print_options): Initialise max_depth field.
 111         (val_print_scalar_or_string_type_p): New function.
 112         (val_print): Check to see if the max depth has been reached.
 113         (val_print_check_max_depth): Define new function.
 114         (show_print_max_depth): New function.
 115         (_initialize_valprint): Add 'print max-depth' option.
 116         * valprint.h (struct value_print_options) <max_depth>: New field.
 117         (val_print_check_max_depth): Declare new function.
 118         * NEWS: Document new feature.
 119
 120 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 121
 122         * ada-lang.c (ada_language_defn): Initialise new field.
 123         * c-lang.c (c_is_string_type_p): New function.
 124         (c_language_defn): Initialise new field.
 125         (cplus_language_defn): Initialise new field.
 126         (asm_language_defn): Initialise new field.
 127         (minimal_language_defn): Initialise new field.
 128         * c-lang.h (c_is_string_type_p): Declare new function.
 129         * d-lang.c (d_language_defn): Initialise new field.
 130         * f-lang.c (f_is_string_type_p): New function.
 131         (f_language_defn): Initialise new field.
 132         * go-lang.c (go_is_string_type_p): New function.
 133         (go_language_defn): Initialise new field.
 134         * language.c (default_is_string_type_p): New function.
 135         (unknown_language_defn): Initialise new field.
 136         (auto_language_defn): Initialise new field.
 137         * language.h (struct language_defn) <la_is_string_type_p>: New
 138         member variable.
 139         (default_is_string_type_p): Declare new function.
 140         * m2-lang.c (m2_language_defn): Initialise new field.
 141         * objc-lang.c (objc_language_defn): Initialise new field.
 142         * opencl-lang.c (opencl_language_defn): Initialise new field.
 143         * p-lang.c (pascal_is_string_type_p): New function.
 144         (pascal_language_defn): Initialise new field.
 145         * rust-lang.c (rust_is_string_type_p): New function.
 146         (rust_language_defn): Initialise new field.
 147
 148 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 151         New field.
 152         * ada-lang.c (ada_language_defn): Initialise new field.
 153         * c-lang.c (c_language_defn): Likewise.
 154         (cplus_language_defn): Likewise.
 155         (asm_language_defn): Likewise.
 156         (minimal_language_defn): Likewise.
 157         * d-lang.c (d_language_defn): Likewise.
 158         * f-lang.c (f_language_defn): Likewise.
 159         * go-lang.c (go_language_defn): Likewise.
 160         * language.c (unknown_language_defn): Likewise.
 161         (auto_language_defn): Likewise.
 162         * m2-lang.c (m2_language_defn): Likewise.
 163         * objc-lang.c (objc_language_defn): Likewise.
 164         * opencl-lang.c (opencl_language_defn): Likewise.
 165         * p-lang.c (pascal_language_defn): Likewise.
 166         * rust-lang.c (rust_language_defn): Likewise.
 167
 168 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * ada-lang.c (ada_is_character_type): Change return type to bool.
 171         (ada_is_string_type): Likewise.
 172         * ada-lang.h (ada_is_character_type): Update declaration
 173         (ada_is_string_type): Likewise.
 174
 175 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 176
 177         Support style in 'frame|thread apply'
 178
 179         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 180         * record.c (record_start, record_stop): Update callers of
 181         execute_command_to_string with false.
 182         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 183         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 184         methods.
 185         (class string_file): New constructor with term_out parameter.
 186         Override methods term_out and can_emit_style_escape.  New member
 187         term_out.
 188         (class stdio_file): Override can_emit_style_escape.
 189         (class tee_file): Override term_out and can_emit_style_escape.
 190         * utils.h (can_emit_style_escape): Remove.
 191         * utils.c (can_emit_style_escape): Likewise.
 192         Update all callers of can_emit_style_escape (SOMESTREAM) to
 193         SOMESTREAM->can_emit_style_escape.
 194         * source-cache.c (source_cache::get_source_lines): Likewise.
 195         * stack.c (frame_apply_command_count): Call execute_command_to_string
 196         passing the term_out characteristic of the current gdb_stdout.
 197         * thread.c (thr_try_catch_cmd): Likewise.
 198         * top.c (execute_command_to_string): pass term_out parameter
 199         to construct the string_file for the command output.
 200         * ui-file.c (term_cli_styling): New function (most code moved
 201         from utils.c can_emit_style_escape).
 202         (string_file::string_file, string_file::can_emit_style_escape,
 203         stdio_file::can_emit_style_escape, tee_file::term_out,
 204         tee_file::can_emit_style_escape): New functions.
 205
 206 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 207
 208         * NEWS: Mention the new set|show may-call-functions.
 209         * infcall.c (may_call_functions_p): New variable.
 210         (show_may_call_functions_p): New function.
 211         (call_function_by_hand_dummy): Throws an error if not
 212         may-call-functions.
 213         (_initialize_infcall): Call add_setshow_boolean_cmd for
 214         may-call-functions.
 215
 216 2019-04-25  Keith Seitz  <keiths@redhat.com>
 217
 218         PR c++/24367
 219         * cp-support.c (inspect_type): Don't attempt substitutions
 220         of symbol with the same name.
 221
 222 2019-04-25  Tom Tromey  <tromey@adacore.com>
 223
 224         PR gdb/24475:
 225         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 226         static.
 227
 228 2019-04-25  Tom Tromey  <tromey@adacore.com>
 229
 230         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 231         rvalue reference.
 232         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 233         (gdb_xml_parser::parse): Use std::move.
 234         * python/python-internal.h (gdbpy_convert_exception): Take a const
 235         reference.
 236         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 237         std::move.
 238         * python/py-utils.c (gdbpy_convert_exception): Take a const
 239         reference.
 240         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 241         Use std::move.
 242         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 243         Use std::move.
 244         * mi/mi-main.c (mi_print_exception): Take a const reference.
 245         * main.c (handle_command_errors): Take a const reference.
 246         * linespec.c (parse_linespec): Use std::move.
 247         * infcall.c (run_inferior_call): Use std::move.
 248         (call_function_by_hand_dummy): Use std::move.
 249         * exec.c (try_open_exec_file): Use std::move.
 250         * exceptions.h (exception_print, exception_fprintf)
 251         (exception_print_same): Update.
 252         * exceptions.c (print_exception, exception_print)
 253         (exception_fprintf, exception_print_same): Change parameters to
 254         const reference.
 255         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 256         * common/new-op.c: Use std::move.
 257         * common/common-exceptions.h (struct gdb_exception): Add move
 258         constructor.
 259         (struct gdb_exception_error, struct gdb_exception_quit, struct
 260         gdb_quit_bad_alloc): Change constructor to move constructor.
 261         (throw_exception): Change parameter to rvalue reference.
 262         * common/common-exceptions.c (throw_exception): Take rvalue
 263         reference.
 264         * cli/cli-interp.c (safe_execute_command): Use std::move.
 265         * breakpoint.c (insert_bp_location, location_to_sals): Use
 266         std::move.
 267
 268 2019-04-25  Tom Tromey  <tromey@adacore.com>
 269
 270         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 271         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 272         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 273         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 274         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 275         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 276         guile/scm-value.c: Use unpack.
 277         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 278         gdbscm_gdb_exception.
 279         (gdbscm_throw_gdb_exception): Likewise.
 280         (struct gdbscm_gdb_exception): New.
 281         (unpack): New function.
 282         (gdbscm_wrap): Use unpack.
 283
 284 2019-04-25  Tom Tromey  <tromey@adacore.com>
 285
 286         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 287         (gdb_rl_callback_handler): Use std::move.
 288         * common/common-exceptions.h (struct gdb_exception): Add move
 289         assignment operator.
 290         (throw_exception_sjlj): Change "exception" to const reference.
 291         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 292         (throw_exception_sjlj): Change "exception" to const reference.
 293
 294 2019-04-25  Tom Tromey  <tromey@adacore.com>
 295
 296         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 297         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 298         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 299         Update.
 300         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 301         Update.
 302         * mi/mi-interp.c (mi_interp::exec): Update.
 303         * linespec.c (parse_linespec): Update.
 304         * infcall.c (run_inferior_call): Update.
 305         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 306         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 307         (gdbscm_lookup_global_symbol): Update.
 308         * guile/scm-param.c (gdbscm_parameter_value): Update.
 309         * guile/scm-frame.c (gdbscm_frame_read_register)
 310         (gdbscm_frame_read_var): Update.
 311         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 312         * exec.c (try_open_exec_file): Update.
 313         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 314         (gdb_rl_callback_handler): Update.
 315         * common/common-exceptions.h (exception_none): Don't declare.
 316         * common/common-exceptions.c (exception_none): Don't define.
 317         (struct catcher) <exception>: Update.
 318         * cli/cli-interp.c (safe_execute_command): Update.
 319         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 320
 321 2019-04-25  Ali Tamur  <tamur@google.com>
 322
 323         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 324         (read_attribute_value): Likewise.
 325         (dwarf2_read_addr_index): Update comment.
 326         (read_str_index): Add DW_FORM_strx.
 327         (dwarf2_string_attr): Likewise.
 328         (dwarf2_const_value_attr): Likewise.
 329         (dump_die_shallow): Likewise.
 330         (dwarf2_fetch_constant_bytes): Likewise.
 331         (skip_form_bytes): Likewise.
 332         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 333
 334 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 335
 336         PR corefiles/11608
 337         PR corefiles/18187
 338         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 339         OFFSET.  Verify if current mapping contains an ELF header.
 340         (linux_find_memory_regions_full): Adjust call to
 341         dump_mapping_p.
 342
 343 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 344             Kang Li <kanglictf@gmail.com>
 345
 346         PR gdb/21600
 347
 348         * dwarf2-frame.c (read_initial_length): Be consistent about using
 349         unsigned representation of length.
 350         (decode_frame_entry_1): Likewise.  Check for wraparound of
 351         end pointer as well as buffer overflow.
 352
 353 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 354
 355         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 356         "vq".
 357
 358 2019-04-24  Tom Tromey  <tromey@adacore.com>
 359
 360         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 361
 362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 363
 364         * s12z-tdep.c (s12z_unwind_pc): Delete.
 365         (s12z_unwind_sp): Delete.
 366         (s12z_gdbarch_init): Don't register deleted functions with
 367         gdbarch.
 368
 369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * rl78-tdep.c (rl78_unwind_sp): Delete.
 372         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 373
 374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 377         (xstormy16_unwind_pc): Delete.
 378         (xstormy16_dummy_id): Delete.
 379         (xstormy16_gdbarch_init): Don't register deleted functions with
 380         gdbarch.
 381
 382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * vax-tdep.c (vax_unwind_pc): Delete.
 385         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 386
 387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * v850-tdep.c (v850_unwind_sp): Delete.
 390         (v850_unwind_pc): Delete.
 391         (v850_dummy_id): Delete.
 392         (v850_gdbarch_init): Don't register deleted functions with
 393         gdbarch.
 394
 395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 398         (tilegx_unwind_pc): Delete.
 399         (tilegx_unwind_dummy_id): Delete.
 400         (tilegx_gdbarch_init): Don't register deleted functions with
 401         gdbarch.
 402
 403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 406         (tic6x_dummy_id): Delete.
 407         (tic6x_gdbarch_init): Don't register deleted functions with
 408         gdbarch.
 409
 410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * sparc-tdep.c (sparc_unwind_pc): Delete.
 413         (sparc32_gdbarch_init): Don't register deleted function with
 414         gdbarch.
 415
 416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 417
 418         * sh-tdep.c (sh_unwind_sp): Delete.
 419         (sh_unwind_pc): Delete.
 420         (sh_dummy_id): Delete.
 421         (sh_gdbarch_init): Don't register deleted functions with
 422         gdbarch.
 423
 424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 425
 426         * score-tdep.c (score_unwind_sp): Delete.
 427         (score_unwind_pc): Delete.
 428         (score_dummy_id): Delete.
 429         (score_gdbarch_init): Don't register deleted functions with
 430         gdbarch.
 431
 432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * rx-tdep.c (rx_unwind_pc): Delete.
 435         (rx_unwind_sp): Delete.
 436         (rx_dummy_id): Delete.
 437         (rx_gdbarch_init): Don't register deleted functions with
 438         gdbarch.  Update comment.
 439
 440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 441
 442         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 443         (rs6000_dummy_id): Delete.
 444         (rs6000_gdbarch_init): Don't register deleted functions with
 445         gdbarch.
 446
 447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         * or1k-tdep.c (or1k_dummy_id): Delete.
 450         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 451
 452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * nios2-tdep.c (nios2_dummy_id): Delete.
 455         (nios2_unwind_sp): Delete.
 456         (nios2_gdbarch_init): Don't register deleted functions with
 457         gdbarch.
 458
 459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * nds32-tdep.c (nds32_dummy_id): Delete.
 462         (nds32_unwind_pc): Delete.
 463         (nds32_unwind_sp): Delete.
 464         (nds32_gdbarch_init): Don't register deleted functions with
 465         gdbarch.
 466
 467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * msp430-tdep.c (msp430_unwind_pc): Delete.
 470         (msp430_unwind_sp): Delete.
 471         (msp430_dummy_id): Delete.
 472         (msp430_gdbarch_init): Don't register deleted functions with
 473         gdbarch.
 474
 475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 476
 477         * moxie-tdep.c (moxie_unwind_sp): Delete.
 478         (moxie_unwind_pc): Delete.
 479         (moxie_dummy_id): Delete.
 480         (moxie_gdbarch_init): Don't register deleted functions with
 481         gdbarch.
 482
 483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 486         (mn10300_unwind_pc): Delete.
 487         (mn10300_unwind_sp): Delete.
 488         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 489         mn10300_unwind_sp.
 490         (mn10300_frame_unwind_init): Don't register deleted functions with
 491         gdbarch.
 492
 493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * mep-tdep.c (mep_unwind_pc): Delete.
 496         (mep_unwind_sp): Delete.
 497         (mep_dummy_id): Delete.
 498         (mep_gdbarch_init): Don't register deleted functions with
 499         gdbarch.
 500
 501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 504         (m68hc11_unwind_sp): Delete.
 505         (m68hc11_gdbarch_init): Don't register deleted functions with
 506         gdbarch.
 507
 508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * m32r-tdep.c (m32r_unwind_sp): Delete.
 511         (m32r_unwind_pc): Delete.
 512         (m32r_dummy_id): Delete.
 513         (m32r_gdbarch_init): Don't register deleted functions with
 514         gdbarch.
 515
 516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * m32c-tdep.c (m32c_unwind_pc): Delete.
 519         (m32c_unwind_sp): Delete.
 520         (m32c_dummy_id): Delete.
 521         (m32c_gdbarch_init): Don't register deleted functions with
 522         gdbarch.
 523
 524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 527         (lm32_unwind_pc): Delete.
 528         (lm32_dummy_id): Delete.
 529         (lm32_gdbarch_init): Don't register deleted functions with
 530         gdbarch.
 531
 532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 535         (iq2000_unwind_pc): Delete.
 536         (iq2000_dummy_id): Delete.
 537         (iq2000_gdbarch_init): Don't register deleted functions with
 538         gdbarch.
 539
 540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * nds32-tdep.c (nds32_type_align): Delete.
 543         (nds32_push_dummy_call): Use type_align instead.
 544
 545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * arm-tdep.c (arm_type_align): Only handle vector override case.
 548         (arm_push_dummy_call): Use type_align.
 549         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 550
 551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 554         case.
 555         (pass_on_stack): Use type_align.
 556         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 557         function.
 558
 559 2019-04-23  Tom Tromey  <tromey@adacore.com>
 560
 561         * dwarf2read.c (line_header::file_name_at): Remove unused
 562         overload.
 563
 564 2019-04-23  Tom de Vries  <tdevries@suse.de>
 565
 566         PR gdb/24438
 567         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 568         invocation.
 569
 570
 571 2019-03-27  Ali Tamur  <tamur@google.com>
 572
 573         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 574         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 575         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 576         (dwarf_expr_context::get_addr_index): Likewise
 577         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 578         (symbol_needs_eval_context::get_addr_index): Likewise
 579         (disassemble_dwarf_expression): Add DW_OP_addrx
 580         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 581         (read_cutu_die_from_dwo): Update comment
 582         (skip_one_die): Add DW_FORM_addrx
 583         (read_attribute_value): Likewise
 584         (var_decode_location): Add DW_OP_addrx
 585         (dwarf2_const_value_attr): Add DW_FORM_addrx
 586         (dump_die_shallow): Likewise
 587         (dwarf2_fetch_constant_bytes): Likewise
 588         (decode_locdesc): Add DW_OP_addrx
 589         (skip_form_bytes): Add DW_FORM_addrx
 590
 591 2019-04-22  Ali Tamur  <tamur@google.com>
 592
 593         * MAINTAINERS (Write After Approval): Add self.
 594
 595 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 596
 597         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 598         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 599         (open_symbol_file_object): Likewise.
 600         (svr4_default_sos): Add info parameter.
 601         (svr4_read_so_list): Likewise.
 602         (svr4_current_sos_direct): Adjust functions calls to pass down
 603         info.
 604         (svr4_current_sos_1): Add info parameter.
 605         (svr4_current_sos): Call get_svr4_info, pass info down to
 606         svr4_current_sos_1.
 607         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 608         get_svr4_info.
 609         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 610         get_svr4_info.
 611         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 612         to get_svr4_info.
 613         (probes_table_remove_objfile_probes): Likewise.
 614         (register_solib_event_probe): Add info parameter.
 615         (solist_update_incremental): Pass info parameter down to
 616         svr4_read_so_list.
 617         (disable_probes_interface): Add info parameter.
 618         (svr4_handle_solib_event): Pass current_program_space to
 619         get_svr4_info.  Adjust disable_probes_interface cleanup.
 620         (svr4_create_probe_breakpoints): Add info parameter, pass it
 621         down to register_solib_event_probe.
 622         (svr4_create_solib_event_breakpoints): Add info parameter,
 623         pass it down to svr4_create_probe_breakpoints.
 624         (enable_break): Pass info down to
 625         svr4_create_solib_event_breakpoints.
 626         (svr4_solib_create_inferior_hook): Pass current_program_space to
 627         get_svr4_info.
 628         (svr4_clear_solib): Likewise.
 629
 630 2019-04-22  Pedro Alves  <palves@redhat.com>
 631
 632         * solib-svr4.c (svr4_free_objfile_observer): New.
 633         (probe_and_action::objfile): New field.
 634         (probes_table_htab_remove_objfile_probes)
 635         (probes_table_remove_objfile_probes): New functions.
 636         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 637         in the new probe_and_action.  Don't store the probe in 'lookup'.
 638         (svr4_create_probe_breakpoints): Pass objfile to
 639         register_solib_event_probe.
 640         (_initialize_svr4_solib): Register a free_objfile observer.
 641
 642 2019-04-19  Tom Tromey  <tom@tromey.com>
 643
 644         * common/queue.h: Remove.
 645
 646 2019-04-19  Tom Tromey  <tom@tromey.com>
 647
 648         * event-loop.c: Don't include "common/queue.h".
 649
 650 2019-04-19  Tom Tromey  <tom@tromey.com>
 651
 652         * remote.c (remote_target): Use delete.
 653         * remote-notif.h: Include <list>, not "common/queue.h".
 654         (notif_client_p): Remove typedef.
 655         (remote_notif_state): Add constructor, destructor, initializer.
 656         <notif_queue>: Now a std::list.
 657         (remote_notif_state_xfree): Don't declare.
 658         * remote-notif.c (remote_notif_process, handle_notification)
 659         (remote_notif_state_allocate): Update.
 660         (~remote_notif_state): Rename from remote_notif_state_xfree.
 661
 662 2019-04-19  Tom Tromey  <tom@tromey.com>
 663
 664         * symfile.c (reread_symbols): Update.
 665         * objfiles.c (objfile_register_static_link)
 666         (objfile_lookup_static_link): Update
 667         (~objfile) Don't delete static_links.
 668         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 669
 670 2019-04-19  Tom Tromey  <tom@tromey.com>
 671
 672         * type-stack.h (struct type_stack) <insert>: Constify string.
 673         * type-stack.c (type_stack::insert): Constify string.
 674         * gdbtypes.h (lookup_template_type): Update.
 675         (address_space_name_to_int): Update.
 676         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 677         const.
 678         (lookup_template_type): Make name const.
 679         * c-exp.y: Update rules.
 680         (lex_one_token, classify_name, classify_inner_name)
 681         (c_print_token): Update.
 682         * p-exp.y: Update rules.
 683         (yylex): Update.
 684         * f-exp.y: Update rules.
 685         (yylex): Update.
 686         * d-exp.y: Update rules.
 687         (lex_one_token, classify_name, classify_inner_name): Update.
 688         * parse.c (write_dollar_variable, copy_name): Return std::string.
 689         * parser-defs.h (copy_name): Change return type.
 690         * m2-exp.y: Update rules.
 691         (yylex): Update.
 692         * go-exp.y (lex_one_token): Update.
 693         Update rules.
 694         (classify_unsafe_function, classify_packaged_name)
 695         (classify_name, yylex): Update.
 696
 697 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 698
 699         * configure.ac: add --enable-source-highlight switch.
 700         * configure: Regenerate.
 701         * top.c (print_gdb_version): plumb --enable-source-highlight
 702         status to "show configuration".
 703
 704 2019-04-19  Tom Tromey  <tromey@adacore.com>
 705
 706         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 707         Check ADA_TYPE_P.
 708         (empty_record, ada_template_to_fixed_record_type_1)
 709         (template_to_static_fixed_type)
 710         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 711         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 712         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 713         macros.
 714
 715 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 716
 717         PR symtab/24423:
 718         * source.c (print_source_lines_base): Advance "iter" when a
 719         control character is seen.
 720
 721 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 722
 723         * inferior.h (struct infcall_suspend_state_deleter):
 724         Catch exception in destructor to avoid crash.
 725
 726 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 727
 728         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 729         close to the add_com "shell".
 730
 731 2019-04-18  Tom Tromey  <tromey@adacore.com>
 732
 733         * process-stratum-target.h (class process_stratum_target)
 734         <stratum>: Add "final".
 735
 736 2019-04-17  Tom Tromey  <tromey@adacore.com>
 737
 738         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 739         against nullptr before use.
 740
 741 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 742
 743         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 744
 745 2019-04-17  Jim Wilson  <jimw@sifive.com>
 746             Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 749         code read might fail, assume 4-byte breakpoint in that case.
 750
 751 2019-04-15  Leszek Swirski  <leszeks@google.com>
 752
 753         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 754         rather than a hand-rolled POD check when checking for forced MEMORY
 755         classification.
 756
 757 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 758
 759         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 760         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 761         function.
 762         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 763         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 764         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 765         declaration.
 766
 767 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * aarch64-linux-nat.c
 770         (aarch64_linux_nat_target::thread_architecture): Add override.
 771         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 772         each VQ.
 773
 774 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 775
 776         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 777
 778 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 781         target types of size 96-bits, add some additional comments, and
 782         check that the builtin type we found was the correct size.
 783
 784 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 785
 786         * utils.c (prompt_for_continue): Don't restore the styling at the
 787         end, as applied_style has the wrong value.  This fixes styling in
 788         long lists of file names that are interrupted by the "Continue?"
 789         prompt.
 790
 791 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 794         * c-lang.c (c_language_defn): Likewise.
 795         (cplus_language_defn): Likewise.
 796         (asm_language_defn): Likewise.
 797         (minimal_language_defn): Likewise.
 798         * d-lang.c (d_language_defn): Likewise.
 799         * f-lang.c (f_language_defn): Likewise.
 800         * go-lang.c (go_language_defn): Likewise.
 801         * language.c (unknown_language_defn): Likewise.
 802         (auto_language_defn): Likewise.
 803         * language.h (struct language_defn): Remove la_magic field.
 804         (LANG_MAGIC): Delete.
 805         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 806         * objc-lang.c (objc_language_defn): Likewise.
 807         * opencl-lang.c (opencl_language_defn): Likewise.
 808         * p-lang.c (pascal_language_defn): Likewise.
 809         * rust-lang.c (rust_language_defn): Likewise.
 810
 811 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * riscv-tdep.c (riscv_type_align): New function.
 814         (riscv_type_alignment): Delete.
 815         (riscv_arg_location): Use 'type_align'.
 816         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 817
 818 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * gdbtypes.c (type_align): A struct with no non-static fields also
 821         has alignment of 1.
 822
 823 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 826         component to 0.
 827         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 828         member.
 829         (riscv_struct_info::analyse): New implementation using new
 830         analyse_inner member function.
 831         (riscv_struct_info::field_offset): New member function.
 832         (riscv_struct_info::m_offsets): New member variable.
 833         (riscv_struct_info::analyse_inner): New private member function,
 834         takes the old implementation of riscv_struct_info::analyse but
 835         extended to track field offsets.
 836         (riscv_call_arg_struct): Update the struct folding special cases
 837         to handle cases where empty C++ structs, which are non-zero
 838         length, are found.
 839         (riscv_arg_location): Initialise the length of each location, a
 840         non-zero length now indicates the location is in use.
 841         (riscv_push_dummy_call): Allow for the first location having a
 842         non-zero offset when setting up arguments.
 843         (riscv_return_value): Likewise, but for return values.
 844
 845 2019-04-11  Tom Tromey  <tromey@adacore.com>
 846
 847         * utils.c (internal_vproblem): Make "msg" const.
 848
 849 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 850
 851         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 852         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 853         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 854         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 855
 856 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 857
 858         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 859         function.
 860         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 861         of amd64_collect_native_gregset.
 862         (amd64_linux_nat_target::store_registers): Likewise.
 863
 864 2019-04-10  Tom Tromey  <tom@tromey.com>
 865
 866         * symtab.c (lookup_global_symbol_from_objfile)
 867         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 868         * objfiles.h (class separate_debug_iterator): New.
 869         (class separate_debug_range): New.
 870         (struct objfile) <separate_debug_objfiles>: New method.
 871         (objfile_separate_debug_iterate): Don't declare.
 872         * objfiles.c (separate_debug_iterator::operator++): Rename from
 873         objfile_separate_debug_iterate.
 874         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 875         iterator.
 876         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 877         iterator.
 878
 879 2019-04-10  Tom Tromey  <tom@tromey.com>
 880
 881         * symfile.c (reread_symbols): Remove old comment.
 882         * objfiles.c (free_all_objfiles): Fix a typo.
 883
 884 2019-04-10  Tom Tromey  <tom@tromey.com>
 885
 886         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 887         * minsyms.c (lookup_minimal_symbol): Use foreach.
 888         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 889         (lookup_minimal_symbol_solib_trampoline): Likewise.
 890         * symfile.c (reread_symbols): Use foreach.
 891
 892 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 893             Tom Tromey  <tromey@adacore.com>
 894
 895         PR rust/24414:
 896         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 897         (rust_lex_int_test): Change "value" to be LONGEST.
 898         (rust_lex_tests): Add test for long integer literal.
 899
 900 2019-04-09  Tom Tromey  <tromey@adacore.com>
 901
 902         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 903         to bool.
 904         (extended_remote_target::attach): Update.
 905         (remote_target::remote_notice_new_inferior): Update.
 906         (remote_target::add_current_inferior_and_thread): Update.
 907         * inferior.c (exit_inferior_1): Use "false".
 908         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 909
 910 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 911
 912         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 913         the "start" command.
 914
 915 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 916
 917         * python/py-inferior.c (infpy_thread_from_thread_handle):
 918         Adjust comments to reflect renaming of thread_from_thread_handle
 919         to thread_from_handle.  Adjust keywords.  Fix type error message.
 920         (inferior_object_methods): Add thread_from_handle.  Retain
 921         thread_from_thread_handle, but mark it as deprecated.
 922
 923 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 924
 925         * gdbthread.h (find_thread_by_handle): Revise declaration.
 926         * thread.c (find_thread_by_handle): Likewise.  Adjust
 927         implementation too.
 928         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 929         support for buffer objects as handles.
 930
 931 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 932
 933         * python/py-infthread.c (thpy_thread_handle): New function.
 934         (thread_object_methods): Register thpy_thread_handle.
 935
 936 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 937
 938         * gdbthread.h (thread_to_thread_handle): Declare.
 939         * thread.c (gdbtypes.h): Include.
 940         (thread_to_thread_handle): New function.
 941
 942         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 943         (target_thread_info_to_thread_handle): Declare.
 944         * target.c (target_thread_info_to_thread_handle): New function.
 945         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 946         * target-delegates.c: Regenerate.
 947
 948         * linux-thread-db.c (class thread_db_target): Add method
 949         thread_info_to_thread_handle.
 950         (thread_db_target::thread_info_to_thread_handle): Define.
 951         * remote.c (class remote_target): Add new method
 952         thread_info_to_thread_handle.
 953         (remote_target::thread_info_to_thread_handle): Define.
 954
 955 2019-04-08  Pedro Alves  <palves@redhat.com>
 956
 957         * common/common-exceptions.c (throw_exception): Don't create
 958         named object to throw; throw directly.
 959         (throw_it): Likewise.  Don't initialize gdb_exception::message
 960         here, with new; pass FMT and AP to the ctor instead.
 961         * common/common-exceptions.h: Include <string>.
 962         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 963         const char *, va_list)): New ctor.  Use std::make_shared.
 964         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 965         errors)): Delete.
 966         (gdb_exception_error::gdb_exception_error(enum errors, const char
 967         *, va_list)): New.
 968         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 969         Add assertion.
 970         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 971         errors)): Delete.
 972         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 973         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 974         Add assertion.
 975
 976 2019-04-08  Tom Tromey  <tom@tromey.com>
 977
 978         * valops.c (value_rtti_indirect_type): Replace throw_exception
 979         with throw.
 980         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 981         with throw.
 982         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 983         throw.
 984         * target.c (target_translate_tls_address): Replace throw_exception
 985         with throw.
 986         * stack.c (frame_apply_command_count): Replace throw_exception
 987         with throw.
 988         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 989         throw.
 990         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 991         with throw.
 992         * rs6000-tdep.c (rs6000_frame_cache)
 993         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 994         * remote.c: Replace throw_exception with throw.
 995         * record-full.c (record_full_message, record_full_wait_1)
 996         (record_full_restore): Replace throw_exception with throw.
 997         * record-btrace.c:
 998         (get_thread_current_frame_id, record_btrace_start_replaying)
 999         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1000         (cmd_record_btrace_start): Replace throw_exception with throw.
1001         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1002         throw.
1003         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1004         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1005         * linespec.c:
1006         (find_linespec_symbols): Replace throw_exception with throw.
1007         * infrun.c (displaced_step_prepare, resume): Replace
1008         throw_exception with throw.
1009         * infcmd.c (post_create_inferior): Replace throw_exception with
1010         throw.
1011         * inf-loop.c (inferior_event_handler): Replace throw_exception
1012         with throw.
1013         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1014         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1015         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1016         (get_prev_frame_always, get_frame_pc_if_available)
1017         (get_frame_address_in_block_if_available, get_frame_language):
1018         Replace throw_exception with throw.
1019         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1020         throw_exception with throw.
1021         * eval.c (fetch_subexp_value, evaluate_var_value)
1022         (evaluate_funcall, evaluate_subexp_standard): Replace
1023         throw_exception with throw.
1024         * dwarf2loc.c (call_site_find_chain)
1025         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1026         Replace throw_exception with throw.
1027         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1028         with throw.
1029         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1030         throw.
1031         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1032         * completer.c (complete_line_internal): Replace throw_exception
1033         with throw.
1034         * compile/compile-object-run.c (compile_object_run): Replace
1035         throw_exception with throw.
1036         * cli/cli-script.c (process_next_line): Replace throw_exception
1037         with throw.
1038         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1039         (btrace_enable, btrace_maint_update_pt_packets): Replace
1040         throw_exception with throw.
1041         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1042         throw_exception with throw.
1043         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1044         throw_exception with throw.
1045         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1046         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1047         * aarch64-tdep.c (aarch64_make_prologue_cache)
1048         (aarch64_make_stub_cache): Replace throw_exception with throw.
1049
1050 2019-04-08  Tom Tromey  <tom@tromey.com>
1051
1052         * common/common-exceptions.c (throw_exception): Rename from
1053         throw_exception_cxx.  Remove old copy.  Make argument const.
1054         (throw_it): Create and throw exception objects directly.
1055         * common/common-exceptions.h (throw_exception): Make argument
1056         const.
1057         (struct gdb_exception_error): Add constructor.
1058         (struct gdb_exception_quit): Add constructor.
1059
1060 2019-04-08  Tom Tromey  <tom@tromey.com>
1061
1062         * common/common-exceptions.h (exception_rethrow): Don't declare.
1063         (TRY_SJLJ): Update comment.
1064         (TRY, CATCH, END_CATCH): Remove.
1065         * common/common-exceptions.c (exception_rethrow): Remove.
1066
1067 2019-04-08  Tom Tromey  <tom@tromey.com>
1068
1069         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1070         Remove.
1071         (gdb_exception_error): Rename from
1072         gdb_exception_RETURN_MASK_ERROR.
1073         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1074         (gdb_quit_bad_alloc): Update.
1075         * aarch64-tdep.c: Update.
1076         * ada-lang.c: Update.
1077         * ada-typeprint.c: Update.
1078         * ada-valprint.c: Update.
1079         * amd64-tdep.c: Update.
1080         * arch-utils.c: Update.
1081         * break-catch-throw.c: Update.
1082         * breakpoint.c: Update.
1083         * btrace.c: Update.
1084         * c-varobj.c: Update.
1085         * cli/cli-cmds.c: Update.
1086         * cli/cli-interp.c: Update.
1087         * cli/cli-script.c: Update.
1088         * common/common-exceptions.c: Update.
1089         * common/new-op.c: Update.
1090         * common/selftest.c: Update.
1091         * compile/compile-c-symbols.c: Update.
1092         * compile/compile-cplus-symbols.c: Update.
1093         * compile/compile-object-load.c: Update.
1094         * compile/compile-object-run.c: Update.
1095         * completer.c: Update.
1096         * corelow.c: Update.
1097         * cp-abi.c: Update.
1098         * cp-support.c: Update.
1099         * cp-valprint.c: Update.
1100         * darwin-nat.c: Update.
1101         * disasm-selftests.c: Update.
1102         * dtrace-probe.c: Update.
1103         * dwarf-index-cache.c: Update.
1104         * dwarf-index-write.c: Update.
1105         * dwarf2-frame-tailcall.c: Update.
1106         * dwarf2-frame.c: Update.
1107         * dwarf2loc.c: Update.
1108         * dwarf2read.c: Update.
1109         * eval.c: Update.
1110         * event-loop.c: Update.
1111         * event-top.c: Update.
1112         * exec.c: Update.
1113         * f-valprint.c: Update.
1114         * fbsd-tdep.c: Update.
1115         * frame-unwind.c: Update.
1116         * frame.c: Update.
1117         * gdbtypes.c: Update.
1118         * gnu-v3-abi.c: Update.
1119         * guile/guile-internal.h: Update.
1120         * guile/scm-block.c: Update.
1121         * guile/scm-breakpoint.c: Update.
1122         * guile/scm-cmd.c: Update.
1123         * guile/scm-disasm.c: Update.
1124         * guile/scm-frame.c: Update.
1125         * guile/scm-lazy-string.c: Update.
1126         * guile/scm-math.c: Update.
1127         * guile/scm-param.c: Update.
1128         * guile/scm-ports.c: Update.
1129         * guile/scm-pretty-print.c: Update.
1130         * guile/scm-symbol.c: Update.
1131         * guile/scm-symtab.c: Update.
1132         * guile/scm-type.c: Update.
1133         * guile/scm-value.c: Update.
1134         * i386-linux-tdep.c: Update.
1135         * i386-tdep.c: Update.
1136         * inf-loop.c: Update.
1137         * infcall.c: Update.
1138         * infcmd.c: Update.
1139         * infrun.c: Update.
1140         * jit.c: Update.
1141         * language.c: Update.
1142         * linespec.c: Update.
1143         * linux-fork.c: Update.
1144         * linux-nat.c: Update.
1145         * linux-tdep.c: Update.
1146         * linux-thread-db.c: Update.
1147         * main.c: Update.
1148         * mi/mi-cmd-break.c: Update.
1149         * mi/mi-cmd-stack.c: Update.
1150         * mi/mi-interp.c: Update.
1151         * mi/mi-main.c: Update.
1152         * objc-lang.c: Update.
1153         * p-valprint.c: Update.
1154         * parse.c: Update.
1155         * ppc-linux-tdep.c: Update.
1156         * printcmd.c: Update.
1157         * python/py-arch.c: Update.
1158         * python/py-breakpoint.c: Update.
1159         * python/py-cmd.c: Update.
1160         * python/py-finishbreakpoint.c: Update.
1161         * python/py-frame.c: Update.
1162         * python/py-framefilter.c: Update.
1163         * python/py-gdb-readline.c: Update.
1164         * python/py-inferior.c: Update.
1165         * python/py-infthread.c: Update.
1166         * python/py-lazy-string.c: Update.
1167         * python/py-linetable.c: Update.
1168         * python/py-objfile.c: Update.
1169         * python/py-param.c: Update.
1170         * python/py-prettyprint.c: Update.
1171         * python/py-progspace.c: Update.
1172         * python/py-record-btrace.c: Update.
1173         * python/py-record.c: Update.
1174         * python/py-symbol.c: Update.
1175         * python/py-type.c: Update.
1176         * python/py-unwind.c: Update.
1177         * python/py-utils.c: Update.
1178         * python/py-value.c: Update.
1179         * python/python.c: Update.
1180         * record-btrace.c: Update.
1181         * record-full.c: Update.
1182         * remote-fileio.c: Update.
1183         * remote.c: Update.
1184         * riscv-tdep.c: Update.
1185         * rs6000-aix-tdep.c: Update.
1186         * rs6000-tdep.c: Update.
1187         * rust-exp.y: Update.
1188         * rust-lang.c: Update.
1189         * s390-tdep.c: Update.
1190         * selftest-arch.c: Update.
1191         * solib-dsbt.c: Update.
1192         * solib-frv.c: Update.
1193         * solib-spu.c: Update.
1194         * solib-svr4.c: Update.
1195         * solib.c: Update.
1196         * sparc64-linux-tdep.c: Update.
1197         * stack.c: Update.
1198         * symfile-mem.c: Update.
1199         * symmisc.c: Update.
1200         * target.c: Update.
1201         * thread.c: Update.
1202         * top.c: Update.
1203         * tracefile-tfile.c: Update.
1204         * tui/tui.c: Update.
1205         * typeprint.c: Update.
1206         * unittests/cli-utils-selftests.c: Update.
1207         * unittests/parse-connection-spec-selftests.c: Update.
1208         * valops.c: Update.
1209         * valprint.c: Update.
1210         * value.c: Update.
1211         * varobj.c: Update.
1212         * windows-nat.c: Update.
1213         * x86-linux-nat.c: Update.
1214         * xml-support.c: Update.
1215
1216 2019-04-08  Tom Tromey  <tom@tromey.com>
1217
1218         * xml-support.c: Use C++ exception handling.
1219         * x86-linux-nat.c: Use C++ exception handling.
1220         * windows-nat.c: Use C++ exception handling.
1221         * varobj.c: Use C++ exception handling.
1222         * value.c: Use C++ exception handling.
1223         * valprint.c: Use C++ exception handling.
1224         * valops.c: Use C++ exception handling.
1225         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1226         handling.
1227         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1228         * typeprint.c: Use C++ exception handling.
1229         * tui/tui.c: Use C++ exception handling.
1230         * tracefile-tfile.c: Use C++ exception handling.
1231         * top.c: Use C++ exception handling.
1232         * thread.c: Use C++ exception handling.
1233         * target.c: Use C++ exception handling.
1234         * symmisc.c: Use C++ exception handling.
1235         * symfile-mem.c: Use C++ exception handling.
1236         * stack.c: Use C++ exception handling.
1237         * sparc64-linux-tdep.c: Use C++ exception handling.
1238         * solib.c: Use C++ exception handling.
1239         * solib-svr4.c: Use C++ exception handling.
1240         * solib-spu.c: Use C++ exception handling.
1241         * solib-frv.c: Use C++ exception handling.
1242         * solib-dsbt.c: Use C++ exception handling.
1243         * selftest-arch.c: Use C++ exception handling.
1244         * s390-tdep.c: Use C++ exception handling.
1245         * rust-lang.c: Use C++ exception handling.
1246         * rust-exp.y: Use C++ exception handling.
1247         * rs6000-tdep.c: Use C++ exception handling.
1248         * rs6000-aix-tdep.c: Use C++ exception handling.
1249         * riscv-tdep.c: Use C++ exception handling.
1250         * remote.c: Use C++ exception handling.
1251         * remote-fileio.c: Use C++ exception handling.
1252         * record-full.c: Use C++ exception handling.
1253         * record-btrace.c: Use C++ exception handling.
1254         * python/python.c: Use C++ exception handling.
1255         * python/py-value.c: Use C++ exception handling.
1256         * python/py-utils.c: Use C++ exception handling.
1257         * python/py-unwind.c: Use C++ exception handling.
1258         * python/py-type.c: Use C++ exception handling.
1259         * python/py-symbol.c: Use C++ exception handling.
1260         * python/py-record.c: Use C++ exception handling.
1261         * python/py-record-btrace.c: Use C++ exception handling.
1262         * python/py-progspace.c: Use C++ exception handling.
1263         * python/py-prettyprint.c: Use C++ exception handling.
1264         * python/py-param.c: Use C++ exception handling.
1265         * python/py-objfile.c: Use C++ exception handling.
1266         * python/py-linetable.c: Use C++ exception handling.
1267         * python/py-lazy-string.c: Use C++ exception handling.
1268         * python/py-infthread.c: Use C++ exception handling.
1269         * python/py-inferior.c: Use C++ exception handling.
1270         * python/py-gdb-readline.c: Use C++ exception handling.
1271         * python/py-framefilter.c: Use C++ exception handling.
1272         * python/py-frame.c: Use C++ exception handling.
1273         * python/py-finishbreakpoint.c: Use C++ exception handling.
1274         * python/py-cmd.c: Use C++ exception handling.
1275         * python/py-breakpoint.c: Use C++ exception handling.
1276         * python/py-arch.c: Use C++ exception handling.
1277         * printcmd.c: Use C++ exception handling.
1278         * ppc-linux-tdep.c: Use C++ exception handling.
1279         * parse.c: Use C++ exception handling.
1280         * p-valprint.c: Use C++ exception handling.
1281         * objc-lang.c: Use C++ exception handling.
1282         * mi/mi-main.c: Use C++ exception handling.
1283         * mi/mi-interp.c: Use C++ exception handling.
1284         * mi/mi-cmd-stack.c: Use C++ exception handling.
1285         * mi/mi-cmd-break.c: Use C++ exception handling.
1286         * main.c: Use C++ exception handling.
1287         * linux-thread-db.c: Use C++ exception handling.
1288         * linux-tdep.c: Use C++ exception handling.
1289         * linux-nat.c: Use C++ exception handling.
1290         * linux-fork.c: Use C++ exception handling.
1291         * linespec.c: Use C++ exception handling.
1292         * language.c: Use C++ exception handling.
1293         * jit.c: Use C++ exception handling.
1294         * infrun.c: Use C++ exception handling.
1295         * infcmd.c: Use C++ exception handling.
1296         * infcall.c: Use C++ exception handling.
1297         * inf-loop.c: Use C++ exception handling.
1298         * i386-tdep.c: Use C++ exception handling.
1299         * i386-linux-tdep.c: Use C++ exception handling.
1300         * guile/scm-value.c: Use C++ exception handling.
1301         * guile/scm-type.c: Use C++ exception handling.
1302         * guile/scm-symtab.c: Use C++ exception handling.
1303         * guile/scm-symbol.c: Use C++ exception handling.
1304         * guile/scm-pretty-print.c: Use C++ exception handling.
1305         * guile/scm-ports.c: Use C++ exception handling.
1306         * guile/scm-param.c: Use C++ exception handling.
1307         * guile/scm-math.c: Use C++ exception handling.
1308         * guile/scm-lazy-string.c: Use C++ exception handling.
1309         * guile/scm-frame.c: Use C++ exception handling.
1310         * guile/scm-disasm.c: Use C++ exception handling.
1311         * guile/scm-cmd.c: Use C++ exception handling.
1312         * guile/scm-breakpoint.c: Use C++ exception handling.
1313         * guile/scm-block.c: Use C++ exception handling.
1314         * guile/guile-internal.h: Use C++ exception handling.
1315         * gnu-v3-abi.c: Use C++ exception handling.
1316         * gdbtypes.c: Use C++ exception handling.
1317         * frame.c: Use C++ exception handling.
1318         * frame-unwind.c: Use C++ exception handling.
1319         * fbsd-tdep.c: Use C++ exception handling.
1320         * f-valprint.c: Use C++ exception handling.
1321         * exec.c: Use C++ exception handling.
1322         * event-top.c: Use C++ exception handling.
1323         * event-loop.c: Use C++ exception handling.
1324         * eval.c: Use C++ exception handling.
1325         * dwarf2read.c: Use C++ exception handling.
1326         * dwarf2loc.c: Use C++ exception handling.
1327         * dwarf2-frame.c: Use C++ exception handling.
1328         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1329         * dwarf-index-write.c: Use C++ exception handling.
1330         * dwarf-index-cache.c: Use C++ exception handling.
1331         * dtrace-probe.c: Use C++ exception handling.
1332         * disasm-selftests.c: Use C++ exception handling.
1333         * darwin-nat.c: Use C++ exception handling.
1334         * cp-valprint.c: Use C++ exception handling.
1335         * cp-support.c: Use C++ exception handling.
1336         * cp-abi.c: Use C++ exception handling.
1337         * corelow.c: Use C++ exception handling.
1338         * completer.c: Use C++ exception handling.
1339         * compile/compile-object-run.c: Use C++ exception handling.
1340         * compile/compile-object-load.c: Use C++ exception handling.
1341         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1342         * compile/compile-c-symbols.c: Use C++ exception handling.
1343         * common/selftest.c: Use C++ exception handling.
1344         * common/new-op.c: Use C++ exception handling.
1345         * cli/cli-script.c: Use C++ exception handling.
1346         * cli/cli-interp.c: Use C++ exception handling.
1347         * cli/cli-cmds.c: Use C++ exception handling.
1348         * c-varobj.c: Use C++ exception handling.
1349         * btrace.c: Use C++ exception handling.
1350         * breakpoint.c: Use C++ exception handling.
1351         * break-catch-throw.c: Use C++ exception handling.
1352         * arch-utils.c: Use C++ exception handling.
1353         * amd64-tdep.c: Use C++ exception handling.
1354         * ada-valprint.c: Use C++ exception handling.
1355         * ada-typeprint.c: Use C++ exception handling.
1356         * ada-lang.c: Use C++ exception handling.
1357         * aarch64-tdep.c: Use C++ exception handling.
1358
1359 2019-04-08  Tom Tromey  <tom@tromey.com>
1360
1361         * xml-support.c (gdb_xml_parser::parse): Update.
1362         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1363         * value.c (show_convenience): Update.
1364         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1365         (test_parse_flags_qcs): Update.
1366         * thread.c (thr_try_catch_cmd): Update.
1367         * target.c (target_translate_tls_address): Update.
1368         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1369         (info_frame_command_core, frame_apply_command_count): Update.
1370         * rust-exp.y (rust_lex_exception_test): Update.
1371         * riscv-tdep.c (riscv_print_one_register_info): Update.
1372         * remote.c (remote_target::enable_btrace): Update.
1373         * record-btrace.c (record_btrace_enable_warn): Update.
1374         * python/py-utils.c (gdbpy_convert_exception): Update.
1375         * printcmd.c (do_one_display, print_variable_and_value): Update.
1376         * mi/mi-main.c (mi_print_exception): Update.
1377         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1378         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1379         * linux-nat.c (linux_nat_target::attach): Update.
1380         * linux-fork.c (class scoped_switch_fork_info): Update.
1381         * infrun.c (displaced_step_prepare): Update.
1382         * infcall.c (call_function_by_hand_dummy): Update.
1383         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1384         * gnu-v3-abi.c (print_one_vtable): Update.
1385         * frame.c (get_prev_frame_always): Update.
1386         * f-valprint.c (info_common_command_for_block): Update.
1387         * exec.c (try_open_exec_file): Update.
1388         * exceptions.c (print_exception, exception_print)
1389         (exception_fprintf, exception_print_same): Update.
1390         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1391         * dwarf-index-cache.c (index_cache::store)
1392         (index_cache::lookup_gdb_index): Update.
1393         * darwin-nat.c (maybe_cache_shell): Update.
1394         * cp-valprint.c (cp_print_value_fields): Update.
1395         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1396         (gcc_cplus_symbol_address): Update.
1397         * compile/compile-c-symbols.c (gcc_convert_symbol)
1398         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1399         * common/selftest.c: Update.
1400         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1401         a std::string.
1402         (exception_try_scope_entry, exception_try_scope_exit): Don't
1403         declare.
1404         (struct exception_try_scope): Remove.
1405         (TRY): Don't use exception_try_scope.
1406         (struct gdb_exception): Add constructor, operator=.
1407         <what>: New method.
1408         (struct gdb_exception_RETURN_MASK_ALL)
1409         (struct gdb_exception_RETURN_MASK_ERROR)
1410         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1411         (struct gdb_quit_bad_alloc): Update.
1412         * common/common-exceptions.c (exception_none): Change
1413         initializer.
1414         (struct catcher) <state, exception>: Initialize inline.
1415         <prev>: Remove member.
1416         (current_catcher): Remove.
1417         (catchers): New global.
1418         (exceptions_state_mc_init): Simplify.
1419         (catcher_pop): Remove.
1420         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1421         (try_scope_depth, exception_try_scope_entry)
1422         (exception_try_scope_exit): Remove.
1423         (throw_exception_sjlj): Update.
1424         (exception_messages, exception_messages_size): Remove.
1425         (throw_it): Simplify.
1426         (gdb_exception_sliced_copy): Remove.
1427         (throw_exception_cxx): Update.
1428         * cli/cli-script.c (script_from_file): Update.
1429         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1430         Update.
1431         * ada-valprint.c (ada_val_print): Update.
1432         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1433         (create_excep_cond_exprs): Update.
1434
1435 2019-04-08  Tom Tromey  <tom@tromey.com>
1436
1437         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1438         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1439         (TRY, CATCH, END_CATCH): Remove some definitions.
1440         * common/common-exceptions.c: Don't use GDB_XCPT.
1441         (catcher_list_size): Remove.
1442         (throw_exception, throw_it): Simplify.
1443
1444 2019-04-05  Tom Tromey  <tom@tromey.com>
1445
1446         Revert the header-sorting patch.
1447         * ft32-tdep.c: Revert.
1448         * frv-tdep.c: Revert.
1449         * frv-linux-tdep.c: Revert.
1450         * frame.c: Revert.
1451         * frame-unwind.c: Revert.
1452         * frame-base.c: Revert.
1453         * fork-child.c: Revert.
1454         * findvar.c: Revert.
1455         * findcmd.c: Revert.
1456         * filesystem.c: Revert.
1457         * filename-seen-cache.h: Revert.
1458         * filename-seen-cache.c: Revert.
1459         * fbsd-tdep.c: Revert.
1460         * fbsd-nat.h: Revert.
1461         * fbsd-nat.c: Revert.
1462         * f-valprint.c: Revert.
1463         * f-typeprint.c: Revert.
1464         * f-lang.c: Revert.
1465         * extension.h: Revert.
1466         * extension.c: Revert.
1467         * extension-priv.h: Revert.
1468         * expprint.c: Revert.
1469         * exec.h: Revert.
1470         * exec.c: Revert.
1471         * exceptions.c: Revert.
1472         * event-top.c: Revert.
1473         * event-loop.c: Revert.
1474         * eval.c: Revert.
1475         * elfread.c: Revert.
1476         * dwarf2read.h: Revert.
1477         * dwarf2read.c: Revert.
1478         * dwarf2loc.c: Revert.
1479         * dwarf2expr.h: Revert.
1480         * dwarf2expr.c: Revert.
1481         * dwarf2-frame.c: Revert.
1482         * dwarf2-frame-tailcall.c: Revert.
1483         * dwarf-index-write.h: Revert.
1484         * dwarf-index-write.c: Revert.
1485         * dwarf-index-common.c: Revert.
1486         * dwarf-index-cache.h: Revert.
1487         * dwarf-index-cache.c: Revert.
1488         * dummy-frame.c: Revert.
1489         * dtrace-probe.c: Revert.
1490         * disasm.h: Revert.
1491         * disasm.c: Revert.
1492         * disasm-selftests.c: Revert.
1493         * dictionary.c: Revert.
1494         * dicos-tdep.c: Revert.
1495         * demangle.c: Revert.
1496         * dcache.h: Revert.
1497         * dcache.c: Revert.
1498         * darwin-nat.h: Revert.
1499         * darwin-nat.c: Revert.
1500         * darwin-nat-info.c: Revert.
1501         * d-valprint.c: Revert.
1502         * d-namespace.c: Revert.
1503         * d-lang.c: Revert.
1504         * ctf.c: Revert.
1505         * csky-tdep.c: Revert.
1506         * csky-linux-tdep.c: Revert.
1507         * cris-tdep.c: Revert.
1508         * cris-linux-tdep.c: Revert.
1509         * cp-valprint.c: Revert.
1510         * cp-support.c: Revert.
1511         * cp-namespace.c: Revert.
1512         * cp-abi.c: Revert.
1513         * corelow.c: Revert.
1514         * corefile.c: Revert.
1515         * continuations.c: Revert.
1516         * completer.h: Revert.
1517         * completer.c: Revert.
1518         * complaints.c: Revert.
1519         * coffread.c: Revert.
1520         * coff-pe-read.c: Revert.
1521         * cli-out.h: Revert.
1522         * cli-out.c: Revert.
1523         * charset.c: Revert.
1524         * c-varobj.c: Revert.
1525         * c-valprint.c: Revert.
1526         * c-typeprint.c: Revert.
1527         * c-lang.c: Revert.
1528         * buildsym.c: Revert.
1529         * buildsym-legacy.c: Revert.
1530         * build-id.h: Revert.
1531         * build-id.c: Revert.
1532         * btrace.c: Revert.
1533         * bsd-uthread.c: Revert.
1534         * breakpoint.h: Revert.
1535         * breakpoint.c: Revert.
1536         * break-catch-throw.c: Revert.
1537         * break-catch-syscall.c: Revert.
1538         * break-catch-sig.c: Revert.
1539         * blockframe.c: Revert.
1540         * block.c: Revert.
1541         * bfin-tdep.c: Revert.
1542         * bfin-linux-tdep.c: Revert.
1543         * bfd-target.c: Revert.
1544         * bcache.c: Revert.
1545         * ax-general.c: Revert.
1546         * ax-gdb.h: Revert.
1547         * ax-gdb.c: Revert.
1548         * avr-tdep.c: Revert.
1549         * auxv.c: Revert.
1550         * auto-load.c: Revert.
1551         * arm-wince-tdep.c: Revert.
1552         * arm-tdep.c: Revert.
1553         * arm-symbian-tdep.c: Revert.
1554         * arm-pikeos-tdep.c: Revert.
1555         * arm-obsd-tdep.c: Revert.
1556         * arm-nbsd-tdep.c: Revert.
1557         * arm-nbsd-nat.c: Revert.
1558         * arm-linux-tdep.c: Revert.
1559         * arm-linux-nat.c: Revert.
1560         * arm-fbsd-tdep.c: Revert.
1561         * arm-fbsd-nat.c: Revert.
1562         * arm-bsd-tdep.c: Revert.
1563         * arch-utils.c: Revert.
1564         * arc-tdep.c: Revert.
1565         * arc-newlib-tdep.c: Revert.
1566         * annotate.h: Revert.
1567         * annotate.c: Revert.
1568         * amd64-windows-tdep.c: Revert.
1569         * amd64-windows-nat.c: Revert.
1570         * amd64-tdep.c: Revert.
1571         * amd64-sol2-tdep.c: Revert.
1572         * amd64-obsd-tdep.c: Revert.
1573         * amd64-obsd-nat.c: Revert.
1574         * amd64-nbsd-tdep.c: Revert.
1575         * amd64-nbsd-nat.c: Revert.
1576         * amd64-nat.c: Revert.
1577         * amd64-linux-tdep.c: Revert.
1578         * amd64-linux-nat.c: Revert.
1579         * amd64-fbsd-tdep.c: Revert.
1580         * amd64-fbsd-nat.c: Revert.
1581         * amd64-dicos-tdep.c: Revert.
1582         * amd64-darwin-tdep.c: Revert.
1583         * amd64-bsd-nat.c: Revert.
1584         * alpha-tdep.c: Revert.
1585         * alpha-obsd-tdep.c: Revert.
1586         * alpha-nbsd-tdep.c: Revert.
1587         * alpha-mdebug-tdep.c: Revert.
1588         * alpha-linux-tdep.c: Revert.
1589         * alpha-linux-nat.c: Revert.
1590         * alpha-bsd-tdep.c: Revert.
1591         * alpha-bsd-nat.c: Revert.
1592         * aix-thread.c: Revert.
1593         * agent.c: Revert.
1594         * addrmap.c: Revert.
1595         * ada-varobj.c: Revert.
1596         * ada-valprint.c: Revert.
1597         * ada-typeprint.c: Revert.
1598         * ada-tasks.c: Revert.
1599         * ada-lang.c: Revert.
1600         * aarch64-tdep.c: Revert.
1601         * aarch64-ravenscar-thread.c: Revert.
1602         * aarch64-newlib-tdep.c: Revert.
1603         * aarch64-linux-tdep.c: Revert.
1604         * aarch64-linux-nat.c: Revert.
1605         * aarch64-fbsd-tdep.c: Revert.
1606         * aarch64-fbsd-nat.c: Revert.
1607         * aarch32-linux-nat.c: Revert.
1608
1609 2019-04-05  Tom Tromey  <tom@tromey.com>
1610
1611         * ft32-tdep.c: Sort headers.
1612         * frv-tdep.c: Sort headers.
1613         * frv-linux-tdep.c: Sort headers.
1614         * frame.c: Sort headers.
1615         * frame-unwind.c: Sort headers.
1616         * frame-base.c: Sort headers.
1617         * fork-child.c: Sort headers.
1618         * findvar.c: Sort headers.
1619         * findcmd.c: Sort headers.
1620         * filesystem.c: Sort headers.
1621         * filename-seen-cache.h: Sort headers.
1622         * filename-seen-cache.c: Sort headers.
1623         * fbsd-tdep.c: Sort headers.
1624         * fbsd-nat.h: Sort headers.
1625         * fbsd-nat.c: Sort headers.
1626         * f-valprint.c: Sort headers.
1627         * f-typeprint.c: Sort headers.
1628         * f-lang.c: Sort headers.
1629         * extension.h: Sort headers.
1630         * extension.c: Sort headers.
1631         * extension-priv.h: Sort headers.
1632         * expprint.c: Sort headers.
1633         * exec.h: Sort headers.
1634         * exec.c: Sort headers.
1635         * exceptions.c: Sort headers.
1636         * event-top.c: Sort headers.
1637         * event-loop.c: Sort headers.
1638         * eval.c: Sort headers.
1639         * elfread.c: Sort headers.
1640         * dwarf2read.h: Sort headers.
1641         * dwarf2read.c: Sort headers.
1642         * dwarf2loc.c: Sort headers.
1643         * dwarf2expr.h: Sort headers.
1644         * dwarf2expr.c: Sort headers.
1645         * dwarf2-frame.c: Sort headers.
1646         * dwarf2-frame-tailcall.c: Sort headers.
1647         * dwarf-index-write.h: Sort headers.
1648         * dwarf-index-write.c: Sort headers.
1649         * dwarf-index-common.c: Sort headers.
1650         * dwarf-index-cache.h: Sort headers.
1651         * dwarf-index-cache.c: Sort headers.
1652         * dummy-frame.c: Sort headers.
1653         * dtrace-probe.c: Sort headers.
1654         * disasm.h: Sort headers.
1655         * disasm.c: Sort headers.
1656         * disasm-selftests.c: Sort headers.
1657         * dictionary.c: Sort headers.
1658         * dicos-tdep.c: Sort headers.
1659         * demangle.c: Sort headers.
1660         * dcache.h: Sort headers.
1661         * dcache.c: Sort headers.
1662         * darwin-nat.h: Sort headers.
1663         * darwin-nat.c: Sort headers.
1664         * darwin-nat-info.c: Sort headers.
1665         * d-valprint.c: Sort headers.
1666         * d-namespace.c: Sort headers.
1667         * d-lang.c: Sort headers.
1668         * ctf.c: Sort headers.
1669         * csky-tdep.c: Sort headers.
1670         * csky-linux-tdep.c: Sort headers.
1671         * cris-tdep.c: Sort headers.
1672         * cris-linux-tdep.c: Sort headers.
1673         * cp-valprint.c: Sort headers.
1674         * cp-support.c: Sort headers.
1675         * cp-namespace.c: Sort headers.
1676         * cp-abi.c: Sort headers.
1677         * corelow.c: Sort headers.
1678         * corefile.c: Sort headers.
1679         * continuations.c: Sort headers.
1680         * completer.h: Sort headers.
1681         * completer.c: Sort headers.
1682         * complaints.c: Sort headers.
1683         * coffread.c: Sort headers.
1684         * coff-pe-read.c: Sort headers.
1685         * cli-out.h: Sort headers.
1686         * cli-out.c: Sort headers.
1687         * charset.c: Sort headers.
1688         * c-varobj.c: Sort headers.
1689         * c-valprint.c: Sort headers.
1690         * c-typeprint.c: Sort headers.
1691         * c-lang.c: Sort headers.
1692         * buildsym.c: Sort headers.
1693         * buildsym-legacy.c: Sort headers.
1694         * build-id.h: Sort headers.
1695         * build-id.c: Sort headers.
1696         * btrace.c: Sort headers.
1697         * bsd-uthread.c: Sort headers.
1698         * breakpoint.h: Sort headers.
1699         * breakpoint.c: Sort headers.
1700         * break-catch-throw.c: Sort headers.
1701         * break-catch-syscall.c: Sort headers.
1702         * break-catch-sig.c: Sort headers.
1703         * blockframe.c: Sort headers.
1704         * block.c: Sort headers.
1705         * bfin-tdep.c: Sort headers.
1706         * bfin-linux-tdep.c: Sort headers.
1707         * bfd-target.c: Sort headers.
1708         * bcache.c: Sort headers.
1709         * ax-general.c: Sort headers.
1710         * ax-gdb.h: Sort headers.
1711         * ax-gdb.c: Sort headers.
1712         * avr-tdep.c: Sort headers.
1713         * auxv.c: Sort headers.
1714         * auto-load.c: Sort headers.
1715         * arm-wince-tdep.c: Sort headers.
1716         * arm-tdep.c: Sort headers.
1717         * arm-symbian-tdep.c: Sort headers.
1718         * arm-pikeos-tdep.c: Sort headers.
1719         * arm-obsd-tdep.c: Sort headers.
1720         * arm-nbsd-tdep.c: Sort headers.
1721         * arm-nbsd-nat.c: Sort headers.
1722         * arm-linux-tdep.c: Sort headers.
1723         * arm-linux-nat.c: Sort headers.
1724         * arm-fbsd-tdep.c: Sort headers.
1725         * arm-fbsd-nat.c: Sort headers.
1726         * arm-bsd-tdep.c: Sort headers.
1727         * arch-utils.c: Sort headers.
1728         * arc-tdep.c: Sort headers.
1729         * arc-newlib-tdep.c: Sort headers.
1730         * annotate.h: Sort headers.
1731         * annotate.c: Sort headers.
1732         * amd64-windows-tdep.c: Sort headers.
1733         * amd64-windows-nat.c: Sort headers.
1734         * amd64-tdep.c: Sort headers.
1735         * amd64-sol2-tdep.c: Sort headers.
1736         * amd64-obsd-tdep.c: Sort headers.
1737         * amd64-obsd-nat.c: Sort headers.
1738         * amd64-nbsd-tdep.c: Sort headers.
1739         * amd64-nbsd-nat.c: Sort headers.
1740         * amd64-nat.c: Sort headers.
1741         * amd64-linux-tdep.c: Sort headers.
1742         * amd64-linux-nat.c: Sort headers.
1743         * amd64-fbsd-tdep.c: Sort headers.
1744         * amd64-fbsd-nat.c: Sort headers.
1745         * amd64-dicos-tdep.c: Sort headers.
1746         * amd64-darwin-tdep.c: Sort headers.
1747         * amd64-bsd-nat.c: Sort headers.
1748         * alpha-tdep.c: Sort headers.
1749         * alpha-obsd-tdep.c: Sort headers.
1750         * alpha-nbsd-tdep.c: Sort headers.
1751         * alpha-mdebug-tdep.c: Sort headers.
1752         * alpha-linux-tdep.c: Sort headers.
1753         * alpha-linux-nat.c: Sort headers.
1754         * alpha-bsd-tdep.c: Sort headers.
1755         * alpha-bsd-nat.c: Sort headers.
1756         * aix-thread.c: Sort headers.
1757         * agent.c: Sort headers.
1758         * addrmap.c: Sort headers.
1759         * ada-varobj.c: Sort headers.
1760         * ada-valprint.c: Sort headers.
1761         * ada-typeprint.c: Sort headers.
1762         * ada-tasks.c: Sort headers.
1763         * ada-lang.c: Sort headers.
1764         * aarch64-tdep.c: Sort headers.
1765         * aarch64-ravenscar-thread.c: Sort headers.
1766         * aarch64-newlib-tdep.c: Sort headers.
1767         * aarch64-linux-tdep.c: Sort headers.
1768         * aarch64-linux-nat.c: Sort headers.
1769         * aarch64-fbsd-tdep.c: Sort headers.
1770         * aarch64-fbsd-nat.c: Sort headers.
1771         * aarch32-linux-nat.c: Sort headers.
1772
1773 2019-04-04  Tom Tromey  <tom@tromey.com>
1774
1775         * varobj.c (varobj_create): Update.
1776         * rust-exp.y (struct rust_parser) <update_innermost_block,
1777         lookup_symbol>: New methods.
1778         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1779         Rename.
1780         (rust_parser::rust_lookup_type)
1781         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1782         * printcmd.c (display_command, do_one_display): Update.
1783         * parser-defs.h (struct parser_state) <parser_state>: Add
1784         "tracker" parameter.
1785         (block_tracker): New member.
1786         (class innermost_block_tracker) <innermost_block_tracker>: Add
1787         "types" parameter.
1788         <reset>: Remove method.
1789         (innermost_block): Don't declare.
1790         (null_post_parser): Update.
1791         * parse.c (innermost_block): Remove global.
1792         (write_dollar_variable): Update.
1793         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1794         Remove "tracker_types" parameter.
1795         (parse_expression): Add "tracker" parameter.
1796         (parse_expression_for_completion): Update.
1797         (null_post_parser): Add "tracker" parameter.
1798         * p-exp.y: Update rules.
1799         * m2-exp.y: Update rules.
1800         * language.h (struct language_defn) <la_post_parser>: Add
1801         "tracker" parameter.
1802         * go-exp.y: Update rules.
1803         * f-exp.y: Update rules.
1804         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1805         parameter.
1806         * d-exp.y: Update rules.
1807         * c-exp.y: Update rules.
1808         * breakpoint.c (set_breakpoint_condition): Create an
1809         innermost_block_tracker.
1810         (watch_command_1): Likewise.
1811         * ada-lang.c (resolve): Add "tracker" parameter.
1812         (resolve_subexp): Likewise.
1813         * ada-exp.y (write_var_from_sym): Update.
1814
1815 2019-04-04  Tom Tromey  <tom@tromey.com>
1816
1817         * type-stack.h: New file.
1818         * type-stack.c: New file.
1819         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1820         type-stack.h.
1821         (insert_into_type_stack, insert_type, push_type, push_type_int)
1822         (insert_type_address_space, pop_type, pop_type_int)
1823         (pop_typelist, pop_type_stack, append_type_stack)
1824         (push_type_stack, get_type_stack, push_typelist)
1825         (follow_type_instance_flags, follow_types): Don't declare.
1826         * parse.c (type_stack): Remove global.
1827         (parse_exp_in_context): Update.
1828         (insert_into_type_stack, insert_type, push_type, push_type_int)
1829         (insert_type_address_space, pop_type, pop_type_int)
1830         (pop_typelist, pop_type_stack, append_type_stack)
1831         (push_type_stack, get_type_stack, push_typelist)
1832         (follow_type_instance_flags, follow_types): Remove (moved to
1833         type-stack.c).
1834         * f-exp.y (type_stack): New global.
1835         Update rules.
1836         (push_kind_type, f_parse): Update.
1837         * d-exp.y (type_stack): New global.
1838         Update rules.
1839         (d_parse): Update.
1840         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1841         Update rules.
1842         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1843         (HFILES_NO_SRCDIR): Add type-stack.h.
1844
1845 2019-04-04  Tom Tromey  <tom@tromey.com>
1846
1847         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1848         (rust_parser::convert_ast_to_expression, rust_parse)
1849         (rust_lex_test_completion, rust_lex_tests): Update.
1850         * parser-defs.h (struct expr_completion_state): New.
1851         (struct parser_state) <parser_state>: Add completion parameter.
1852         <mark_struct_expression, mark_completion_tag>: New methods.
1853         <parse_completion, m_completion_state>: New members.
1854         (prefixify_expression, null_post_parser): Update.
1855         (mark_struct_expression, mark_completion_tag): Don't declare.
1856         * parse.c (parse_completion, expout_last_struct)
1857         (expout_tag_completion_type, expout_completion_name): Remove
1858         globals.
1859         (parser_state::mark_struct_expression)
1860         (parser_state::mark_completion_tag): Now methods.
1861         (prefixify_expression): Add last_struct parameter.
1862         (prefixify_subexp): Likewise.
1863         (parse_exp_1): Update.
1864         (parse_exp_in_context): Add cstate parameter.  Update.
1865         (parse_expression_for_completion): Create an
1866         expr_completion_state.
1867         (null_post_parser): Add "completion" parameter.
1868         * p-exp.y: Update rules.
1869         (yylex): Update.
1870         * language.h (struct language_defn) <la_post_parser>: Add
1871         "completing" parameter.
1872         * go-exp.y: Update rules.
1873         (lex_one_token): Update.
1874         * expression.h (parse_completion): Don't declare.
1875         * d-exp.y: Update rules.
1876         (lex_one_token): Update rules.
1877         * c-exp.y: Update rules.
1878         (lex_one_token): Update.
1879         * ada-lang.c (resolve): Add "parse_completion" parameter.
1880         (resolve_subexp): Likewise.
1881         (ada_resolve_function): Likewise.
1882
1883 2019-04-04  Tom Tromey  <tom@tromey.com>
1884
1885         * parser-defs.h (struct parser_state) <start_arglist,
1886         end_arglist>: New methods.
1887         <arglist_len, m_funcall_chain>: New members.
1888         (arglist_len, start_arglist, end_arglist): Don't declare.
1889         * parse.c (arglist_len, funcall_chain): Remove global.
1890         (start_arglist, end_arglist): Remove functions.
1891         (parse_exp_in_context): Update.
1892         * p-exp.y: Update rules.
1893         * m2-exp.y: Update rules.
1894         * go-exp.y: Update rules.
1895         * f-exp.y: Update rules.
1896         * d-exp.y: Update rules.
1897         * c-exp.y: Update rules.
1898
1899 2019-04-04  Tom Tromey  <tom@tromey.com>
1900
1901         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1902         lex_operator, push_back>: New methods.
1903         Update all rules.
1904         (rust_parser::lex_hex, lex_escape): Rename and update.
1905         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1906         (rust_parser::lex_operator): Rename and update.
1907         (rust_parser::lex_number, rustyylex, rustyyerror)
1908         (rust_lex_test_init, rust_lex_test_sequence)
1909         (rust_lex_test_push_back, rust_lex_tests): Update.
1910         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1911         parameter.
1912         <lexptr, prev_lexptr>: New members.
1913         (lexptr, prev_lexptr): Don't declare.
1914         * parse.c (lexptr, prev_lexptr): Remove globals.
1915         (parse_exp_in_context): Update.
1916         * p-exp.y (yylex, yyerror): Update.
1917         * m2-exp.y (parse_number, yylex, yyerror): Update.
1918         * go-exp.y (lex_one_token, yyerror): Update.
1919         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1920         * d-exp.y (lex_one_token, yyerror): Update.
1921         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1922         (lex_one_token, yyerror): Update.
1923         * ada-lex.l (YY_INPUT): Update.
1924         (rewind_to_char): Update.
1925         * ada-exp.y (yyerror): Update.
1926
1927 2019-04-04  Tom Tromey  <tom@tromey.com>
1928
1929         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1930         * parser-defs.h (struct parser_state) <parser_state>: Add new
1931         parameter.
1932         <comma_terminates>: New member.
1933         (comma_terminates): Don't declare global.
1934         * parse.c (comma_terminates): Remove global.
1935         (parse_exp_in_context): Update.
1936         * p-exp.y (yylex): Update.
1937         * m2-exp.y (yylex): Update.
1938         * go-exp.y (lex_one_token): Update.
1939         * f-exp.y (yylex): Update.
1940         * d-exp.y (lex_one_token): Update.
1941         * c-exp.y (lex_one_token): Update.
1942         * ada-lex.l: Update.
1943
1944 2019-04-04  Tom Tromey  <tom@tromey.com>
1945
1946         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1947         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1948         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1949         * parser-defs.h (paren_depth): Don't declare.
1950         * parse.c (paren_depth): Remove global.
1951         (parse_exp_in_context): Update.
1952         * p-exp.y (paren_depth): New global.
1953         (pascal_parse): Initialize it.
1954         * m2-exp.y (paren_depth): New global.
1955         (m2_parse): Initialize it.
1956         * go-exp.y (paren_depth): New global.
1957         (go_parse): Initialize it.
1958         * f-exp.y (paren_depth): New global.
1959         (f_parse): Initialize it.
1960         * d-exp.y (paren_depth): New global.
1961         (d_parse): Initialize it.
1962         * c-exp.y (paren_depth): New global.
1963         (c_parse): Initialize it.
1964         * ada-lex.l (paren_depth): New global.
1965         (lexer_init): Initialize it.
1966
1967 2019-04-04  Tom Tromey  <tom@tromey.com>
1968
1969         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1970         (rust_parser::convert_ast_to_type)
1971         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1972         * parser-defs.h (struct parser_state) <parser_state>: Add
1973         parameters.  Initialize new members.
1974         <expression_context_block, expression_context_pc>: New members.
1975         * parse.c (expression_context_block, expression_context_pc):
1976         Remove globals.
1977         (parse_exp_in_context): Update.
1978         * p-exp.y: Update all rules.
1979         (yylex): Update.
1980         * m2-exp.y: Update all rules.
1981         (yylex): Update.
1982         * go-exp.y (yylex): Update.
1983         * f-exp.y (yylex): Update.
1984         * d-exp.y: Update all rules.
1985         (yylex): Update.
1986         * c-exp.y: Update all rules.
1987         (lex_one_token, classify_name, yylex, c_parse): Update.
1988         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1989
1990 2019-04-04  Tom Tromey  <tom@tromey.com>
1991
1992         * gdbarch.h, gdbarch.c: Rebuild.
1993         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1994         * stap-probe.h:
1995         (struct stap_parse_info): Replace "parser_state" with
1996         "expr_builder".
1997         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1998         (parser_state): New class.
1999         * parse.c (expr_builder): Rename.
2000         (expr_builder::release): Rename.
2001         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2002         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2003         (write_exp_elt_longcst, write_exp_elt_floatcst)
2004         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2005         (write_exp_string_vector, write_exp_bitstring)
2006         (write_exp_msymbol, mark_struct_expression)
2007         (write_dollar_variable)
2008         (insert_type_address_space, increase_expout_size): Replace
2009         "parser_state" with "expr_builder".
2010         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2011         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2012         "parser_state" with "expr_builder".
2013
2014 2019-04-04  Tom Tromey  <tom@tromey.com>
2015
2016         * rust-exp.y: Replace "parse_language" with method call.
2017         * p-exp.y:
2018         (yylex): Replace "parse_language" with method call.
2019         * m2-exp.y:
2020         (yylex): Replace "parse_language" with method call.
2021         * go-exp.y (classify_name): Replace "parse_language" with method
2022         call.
2023         * f-exp.y (yylex): Replace "parse_language" with method call.
2024         * d-exp.y (lex_one_token): Replace "parse_language" with method
2025         call.
2026         * c-exp.y:
2027         (lex_one_token, classify_name, yylex): Replace "parse_language"
2028         with method call.
2029         * ada-exp.y (find_primitive_type, type_char)
2030         (type_system_address): Replace "parse_language" with method call.
2031
2032 2019-04-04  Tom Tromey  <tom@tromey.com>
2033
2034         * rust-exp.y: Replace "parse_gdbarch" with method call.
2035         * parse.c (write_dollar_variable, insert_type_address_space):
2036         Replace "parse_gdbarch" with method call.
2037         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2038         call.
2039         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2040         call.
2041         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2042         "parse_gdbarch" with method call.
2043         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2044         with method call.
2045         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2046         "parse_gdbarch" with method call.
2047         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2048         "parse_gdbarch" with method call.
2049         * c-exp.y (parse_type, parse_number, classify_name): Replace
2050         "parse_gdbarch" with method call.
2051         * ada-lex.l: Replace "parse_gdbarch" with method call.
2052         * ada-exp.y (parse_type, find_primitive_type, type_char)
2053         (type_system_address): Replace "parse_gdbarch" with method call.
2054
2055 2019-04-04  Tom Tromey  <tom@tromey.com>
2056
2057         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2058         * stap-probe.c (stap_parse_argument): Update.
2059         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2060         initial_size parameter.
2061         * rust-exp.y (rust_lex_tests): Update.
2062         * parse.c (parser_state): Update.
2063         (parse_exp_in_context): Update.
2064         * parser-defs.h (struct parser_state) <parser_state>: Remove
2065         "initial_size" parameter.
2066
2067 2019-04-04  Tom Tromey  <tom@tromey.com>
2068
2069         * parser-defs.h (increase_expout_size): Don't declare.
2070         * parse.c (increase_expout_size): Now static.
2071
2072 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2073
2074         * gnu-nat.c (gnu_nat_target::wait): Fix
2075         target_waitstatus_to_string call.
2076
2077 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         * eval.c (evaluate_subexp_standard): Handle internal functions
2080         during Fortran function call handling.
2081
2082 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * NEWS: Mention new internal functions.
2085         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2086         (read_base_type): Use dwarf2_init_complex_target_type.
2087         * value.c (creal_internal_fn): New function.
2088         (cimag_internal_fn): New function.
2089         (_initialize_values): Register new internal functions.
2090
2091 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2092
2093         * infrun.c (stop_all_threads): If debug_infrun, always
2094         trace the wait status after wait_one, using
2095         target_waitstatus_to_string and target_pid_to_str.
2096         (handle_inferior_event): Replace various trace of
2097         wait status kind by a single trace.
2098         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2099         wait status kind image by target_waitstatus_to_string.
2100         * target/waitstatus.c (target_waitstatus_to_string): Fix
2101         obsolete comment.
2102
2103 2019-04-01  Tom Tromey  <tromey@adacore.com>
2104
2105         PR symtab/23331:
2106         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2107
2108 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2109             Pedro Alves  <palves@redhat.com>
2110
2111         * top.c (quit_force): Call 'finalize_values'.
2112         * value.c (finalize_values): New function.
2113         * value.h (finalize_values): Declare.
2114
2115 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2116
2117         * NEWS: Announce $_gdb_major and $_gdb_minor.
2118
2119         * top.c (init_gdb_version_vars): New function.
2120         (gdb_init): Call init_gdb_version_vars.
2121
2122 2019-03-29  Tom Tromey  <tromey@adacore.com>
2123
2124         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2125         help text.  Remove dead code.
2126
2127 2019-03-29  Keith Seitz  <keiths@redhat.com>
2128
2129         From Siddhesh Poyarekar:
2130         * f-lang.h (f77_get_upperbound): Return LONGEST.
2131         (f77_get_lowerbound): Likewise.
2132         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2133         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2134         print them.
2135         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2136         plongest to format print it.
2137         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2138         (f77_get_upperbound): Likewise.
2139         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2140         LOWER_BOUND to LONGEST.
2141         (f77_create_arrayprint_offset_tbl): Likewise.
2142
2143 2019-03-29  Keith Seitz  <keiths@redhat.com>
2144
2145         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2146         %s/pulongest for TYPE_LENGTH instead of %d in format
2147         strings.
2148         * ada-typerint.c (ada_print_type): Likewise.
2149         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2150         * compile/compile-c-support.c (generate_register_struct): Likewise.
2151         * gdbtypes.c (recursive_dump_type): Likewise.
2152         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2153         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2154         instead of %d in format strings.
2155         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2156         to std::min to ULONGEST.
2157         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2158         instead of %d in format strings.
2159         * tracepoint.c (info_scope_command): Likewise.
2160         * typeprint.c (print_offset_data::update)
2161         (print_offset_data::finish): Likewise.
2162         * xtensa-tdep.c (xtensa_store_return_value)
2163         (xtensa_push_dummy_call): Likewise.
2164
2165 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2166
2167         * windows-nat.c (display_selector): Fixed format specifications
2168         for 64-bit Cygwin.
2169
2170 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2171
2172         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2173
2174 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2175
2176         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2177         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2178         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2179         (nios2_linux_init_abi): Install it.
2180
2181 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2182
2183         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2184
2185 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2186
2187         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2188
2189 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2190             Tom Tromey  <tromey@adacore.com>
2191
2192         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2193
2194 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2195
2196         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2197         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2198         method to compute the bounds of range types. Also print "[evaluated]"
2199         if the bounds' values come from a dynamic evaluation.
2200
2201 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2204         whitespace when pretty printing is on.
2205
2206 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2207
2208         * ppc-linux-nat.c: Add include.
2209
2210 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2211
2212         * NEWS: Mention AArch64 Pointer Authentication.
2213
2214 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2215
2216         * arm-linux-nat.c: Add include.
2217
2218 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2219
2220         * source-cache.c (source_cache::get_source_lines): Re-read
2221         fullname after calling open_source_file.
2222
2223 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2224
2225         * NEWS: Mention TLS support for FreeBSD.
2226
2227 2019-03-25  Tom Tromey  <tromey@adacore.com>
2228
2229         * minsyms.c (BUNCH_SIZE): Update comment.
2230         (~minimal_symbol_reader): Remove old comment.
2231         (compact_minimal_symbols): Update comment.
2232         (minimal_symbol_reader::install): Remove old comment.  Update
2233         other comments.
2234
2235 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2236
2237         * s390-linux-nat.c: Add include.
2238
2239 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2240
2241         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2242         Call linux_get_hwcap.
2243         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2244         Likewise.
2245         (aarch64_linux_get_hwcap): Remove function.
2246         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2247         declaration.
2248         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2249         linux_get_hwcap.
2250         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2251         * linux-tdep.c (linux_get_hwcap): Add function.
2252         (linux_get_hwcap2): Likewise.
2253         * linux-tdep.h (linux_get_hwcap): Add declaration.
2254         (linux_get_hwcap2): Likewise.
2255         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2256         (ppc_linux_get_hwcap2): Likewise.
2257         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2258         linux_get_hwcap.
2259         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2260         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2261         (ppc_linux_nat_target::read_description): Likewise.
2262         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2263         * s390-linux-nat.c: Likewise.
2264         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2265
2266 2019-03-24  Tom Tromey  <tom@tromey.com>
2267
2268         * ada-lang.c (standard_lookup): Simplify initialization.
2269         (ada_lookup_symbol_nonlocal): Simplify return.
2270         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2271         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2272         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2273         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2274         initialization.
2275         * solib.c (solib_global_lookup): Simplify.
2276         * symtab.c (null_block_symbol): Remove.
2277         (symbol_cache_lookup): Simplify returns.
2278         (lookup_language_this): Simplify returns.
2279         (lookup_symbol_aux): Simplify return.
2280         (lookup_local_symbol): Simplify returns.
2281         (lookup_global_symbol_from_objfile): Simplify return.
2282         (lookup_symbol_in_objfile_symtabs)
2283         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2284         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2285         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2286         * cp-namespace.c (cp_lookup_bare_symbol)
2287         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2288         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2289         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2290         (cp_lookup_symbol_via_imports): Simplify initialization.
2291         (find_symbol_in_baseclass): Likewise.
2292         * symtab.h (null_block_symbol): Remove.
2293         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2294         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2295         (d_lookup_symbol_module): Likewise.
2296         (find_symbol_in_baseclass): Simplify initialization.
2297
2298 2019-03-24  Tom Tromey  <tom@tromey.com>
2299
2300         * expression.h: Don't include symtab.h.
2301         (struct block): Forward declare.
2302
2303 2019-03-24  Tom Tromey  <tom@tromey.com>
2304
2305         * c-exp.y (typebase): Remove casts.
2306         * gdbtypes.c (lookup_unsigned_typename, )
2307         (lookup_signed_typename): Remove cast.
2308         * eval.c (parse_to_comma_and_eval): Remove cast.
2309         * parse.c (write_dollar_variable): Remove cast.
2310         * block.h (struct block) <superblock>: Now const.
2311         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2312         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2313         (map_block): Make "block" const.
2314         * symfile.h (struct quick_symbol_functions)
2315         <map_matching_symbols>: Constify block argument to "callback".
2316         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2317         const.
2318         (find_pc_sect_compunit_symtab): Make "b" const.
2319         (find_symbol_at_address): Likewise.
2320         (search_symbols): Likewise.
2321         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2322         (dw2_debug_names_lookup_symbol): Likewise.
2323         (dw2_map_matching_symbols): Update.
2324         * p-valprint.c (pascal_val_print): Remove "block".
2325         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2326         (aux_add_nonlocal_symbols): Make "block" const.
2327         (resolve_subexp): Remove cast.
2328         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2329         const.
2330         (iterate_over_file_blocks): Likewise.
2331         * f-exp.y (%union) <bval>: Remove.
2332         * coffread.c (patch_opaque_types): Make "b" const.
2333         * spu-tdep.c (spu_catch_start): Make "block" const.
2334         * c-valprint.c (print_unpacked_pointer): Remove "block".
2335         * symmisc.c (dump_symtab_1): Make "b" const.
2336         (block_depth): Make "block" const.
2337         * d-exp.y (%union) <bval>: Remove.
2338         * cp-support.h (cp_lookup_rtti_type): Update.
2339         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2340         * psymtab.c (psym_lookup_symbol): Make "block" const.
2341         (maintenance_check_psymtabs): Make "b" const.
2342         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2343         (enumerate_locals, enumerate_args): Update.
2344         * python/py-symtab.c (stpy_global_block): Make "block" const.
2345         (stpy_static_block): Likewise.
2346         * inline-frame.c (block_starting_point_at): Make "new_block"
2347         const.
2348         * block.c (find_block_in_blockvector): Make return type const.
2349         (blockvector_for_pc_sect): Make "b" const.
2350         (find_block_in_blockvector): Make "b" const.
2351
2352 2019-03-23  Tom Tromey  <tom@tromey.com>
2353
2354         * varobj.c (varobj_create): Update.
2355         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2356         * printcmd.c (display_command, do_one_display): Don't reset
2357         innermost_block.
2358         * parser-defs.h (enum innermost_block_tracker_type): Move to
2359         expression.h.
2360         (innermost_block): Update comment.
2361         * parse.c (parse_exp_1): Add tracker_types parameter.
2362         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2363         tracker_types parameter.  Reset innermost_block.
2364         (parse_exp_in_context): Remove.
2365         (parse_expression_for_completion): Update.
2366         * objfiles.c (~objfile): Don't reset expression_context_block or
2367         innermost_block.
2368         * expression.h (enum innermost_block_tracker_type): Move from
2369         parser-defs.h.
2370         (parse_exp_1): Add tracker_types parameter.
2371         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2372         reset innermost_block.
2373
2374 2019-03-23  Tom Tromey  <tom@tromey.com>
2375
2376         * objfiles.h: Include bcache.h.
2377
2378 2019-03-23  Tom Tromey  <tom@tromey.com>
2379
2380         * linespec.c (get_current_search_block): Use
2381         scoped_restore_current_language.
2382         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2383
2384 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2385             Jiong Wang  <jiong.wang@arm.com>
2386
2387         * aarch64-linux-tdep.c
2388         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2389         section.
2390         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2391
2392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2393             Jiong Wang  <jiong.wang@arm.com>
2394
2395         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2396         instructions.
2397         (aarch64_analyze_prologue_test): Add PACIASP test.
2398         (aarch64_prologue_prev_register): Unmask PC value.
2399
2400 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2401             Jiong Wang  <jiong.wang@arm.com>
2402
2403         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2404         (aarch64_dwarf2_prev_register): Unmask PC value.
2405         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2406         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2407         DW_CFA_AARCH64_negate_ra_state.
2408         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2409
2410 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2411             Jiong Wang  <jiong.wang@arm.com>
2412
2413         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2414         registers.
2415         (aarch64_pseudo_register_name): Likewise.
2416         (aarch64_pseudo_register_type): Likewise.
2417         (aarch64_pseudo_register_reggroup_p): Likewise.
2418         (aarch64_gdbarch_init): Add pauth registers.
2419         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2420         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2421         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2422         (struct gdbarch_tdep): Add regnum for ra_state.
2423
2424 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2425             Jiong Wang  <jiong.wang@arm.com>
2426
2427         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2428
2429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2430             Jiong Wang  <jiong.wang@arm.com>
2431
2432         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2433         function.
2434         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2435         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2436         (aarch64_gdbarch_init): Add puth registers.
2437         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2438         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2439         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2440
2441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2442             Jiong Wang  <jiong.wang@arm.com>
2443
2444         * aarch64-linux-nat.c
2445         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2446         * aarch64-linux-tdep.c
2447         (aarch64_linux_core_read_description): Likewise.
2448         (aarch64_linux_get_hwcap): New function.
2449         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2450         (aarch64_linux_get_hwcap): New declaration.
2451
2452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2453             Jiong Wang  <jiong.wang@arm.com>
2454
2455         * aarch64-linux-nat.c
2456         (aarch64_linux_nat_target::read_description): Add pauth param.
2457         * aarch64-linux-tdep.c
2458         (aarch64_linux_core_read_description): Likewise.
2459         * aarch64-tdep.c (struct target_desc): Add in pauth.
2460         (aarch64_read_description): Add pauth param.
2461         (aarch64_gdbarch_init): Likewise.
2462         * aarch64-tdep.h (aarch64_read_description): Likewise.
2463         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2464         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2465         * features/Makefile: Add new files.
2466         * features/aarch64-pauth.c: New file.
2467         * features/aarch64-pauth.xml: New file.
2468
2469 2019-03-20  Tom Tromey  <tromey@adacore.com>
2470
2471         * infrun.c (handle_inferior_event): Rename from
2472         handle_inferior_event_1.  Create a scoped_value_mark.
2473         (handle_inferior_event): Remove.
2474
2475 2019-03-19  Tom Tromey  <tromey@adacore.com>
2476
2477         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2478         * infrun.h (print_stop_event): Add "displays" parameter.
2479         * infrun.c (print_stop_event): Add "displays" parameter.
2480
2481 2019-03-19  Pedro Alves  <palves@redhat.com>
2482
2483         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2484         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2485         to -1.  Fix TABs vs spaces.
2486         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2487         * tui/tui-out.h (tui_ui_out) Add intro comments.
2488         <m_line, m_start_of_line>: In-class initialize, and add describing
2489         comment.
2490
2491 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2492
2493         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2494         variable names.
2495         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2496
2497 2019-03-18  Pedro Alves  <palves@redhat.com>
2498             Eli Zaretskii <eliz@gnu.org>
2499
2500         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2501         m_line and m_start_of_line.
2502
2503 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2504
2505         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2506         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2507         it returns a newline.  This fixes a regression in TU mode, whereby
2508         the next line is output on the same screen line as the user input.
2509
2510 2019-03-18  Tom Tromey  <tromey@adacore.com>
2511
2512         * minsyms.c (minimal_symbol_reader::install): Remove call to
2513         obstack_blank.
2514
2515 2019-03-18  Pedro Alves  <palves@redhat.com>
2516
2517         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2518         New globals.
2519         (apply_style): New, factored out from ...
2520         (apply_ansi_escape): ... this.  Handle reverse video mode.
2521         (tui_set_reverse_mode): New function.
2522         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2523         * tui/tui-winsource.c (tui_show_source_line): Use
2524         tui_set_reverse_mode instead of setting A_STANDOUT.
2525         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2526         New setter methods.
2527
2528 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2529
2530         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2531         Handle tabs.
2532
2533 2019-03-18  Tom Tromey  <tromey@adacore.com>
2534
2535         * ada-lang.c (empty_array): Add "high" parameter.
2536         (ada_evaluate_subexp): Update.
2537
2538 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2539
2540         * unittests/string_view-selftests.c: Define
2541         _initialize_string_view_selftests unconditionally.
2542
2543 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2544
2545         PR gdb/24350
2546         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2547
2548 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2549
2550         PR gdb/24351
2551         * windows-nat.c (display_selector): Fix format specifiers.
2552
2553 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2554
2555         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2556         tui_refill_source_window instead of tui_refresh_win, to update the
2557         current execution line.  This fixes redisplay of the current line
2558         when stepping through the code with "next" or "step".
2559
2560 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2561
2562         * source-cache.c (source_cache::get_source_lines): Call
2563         find_source_lines to initialize s->nlines.  This fixes vertical
2564         scrolling of TUI source window when the DOWN arrow is pressed.
2565
2566 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2569         linux-thread-db.c (_initialize_thread_db): Likewise.
2570
2571 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2572
2573         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2574         wclrtoeol in tui_show_source_line".  This reverts changes made in
2575         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2576
2577 2019-03-15  Tom Tromey  <tom@tromey.com>
2578
2579         * symtab.h (struct minimal_symbol): Derive from
2580         general_symbol_info.
2581         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2582         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2583         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2584         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2585         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2586         (MSYMBOL_SEARCH_NAME): Update.
2587         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2588         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2589         * minsyms.c (minimal_symbol_reader::record_full): Update.
2590
2591 2019-03-15  Tom Tromey  <tom@tromey.com>
2592
2593         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2594
2595 2019-03-15  Tom Tromey  <tom@tromey.com>
2596
2597         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2598         unique_xmalloc_ptr.
2599         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2600         Update.
2601         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2602         (build_minimal_symbol_hash_tables)
2603         (minimal_symbol_reader::install): Update.
2604
2605 2019-03-15  Tom Tromey  <tom@tromey.com>
2606
2607         * symtab.c (create_demangled_names_hash): Update.
2608         (symbol_set_names): Update.
2609         * objfiles.h (struct objfile_per_bfd_storage)
2610         <demangled_names_hash>: Now an htab_up.
2611         * objfiles.c (objfile_per_bfd_storage): Simplify.
2612
2613 2019-03-15  Tom Tromey  <tom@tromey.com>
2614
2615         * objfiles.h (struct objfile_per_bfd_storage): Declare
2616         destructor.
2617         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2618         New.
2619         (get_objfile_bfd_data): Use new.  Don't initialize
2620         language_of_main.
2621         (free_objfile_per_bfd_storage): Remove.
2622         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2623
2624 2019-03-15  Tom Tromey  <tom@tromey.com>
2625
2626         * symfile.c (reread_symbols): Update.
2627         * objfiles.c (objfile::objfile): Update.
2628         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2629         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2630         comment.
2631         (minimal_symbol_reader::install): Update.
2632         (terminate_minimal_symbol_table): Remove.
2633         * jit.c (jit_object_close_impl): Update.
2634
2635 2019-03-15  Tom Tromey  <tom@tromey.com>
2636
2637         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2638         initializations.
2639
2640 2019-03-15  Tom Tromey  <tom@tromey.com>
2641
2642         * objfiles.h (struct objfile_per_bfd_storage)
2643         <demangled_hash_languages>: Now a bitset.
2644         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2645         (lookup_minimal_symbol): Update.
2646
2647 2019-03-15  Tom Tromey  <tom@tromey.com>
2648
2649         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2650         Don't return the symbol.
2651         * coffread.c (record_minimal_symbol): Use record_full.
2652
2653 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2654
2655         The MS-Windows port of ncurses fails to switch to a color pair if
2656         one or both of the colors are the implicit default colors.  This
2657         change records the default colors when TUI is initialized, and
2658         then specifies them explicitly when a color pair uses the default
2659         colors.  This allows color styling in TUI mode on MS-Windows.
2660
2661         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2662         ncurses_norm_attr.
2663         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2664         colors in ncurses_norm_attr.
2665         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2666         "none", replace it with the default color recorded in
2667         ncurses_norm_attr.
2668
2669 2019-03-14  Tom Tromey  <tromey@adacore.com>
2670
2671         * source-cache.h (class source_cache) <get_source_lines>: Return
2672         std::string.
2673         * source-cache.c (source_cache::extract_lines): Handle case where
2674         first_pos==npos.  Return std::string.
2675         (source_cache::get_source_lines): Update.
2676
2677 2019-03-14  Tom Tromey  <tromey@adacore.com>
2678
2679         * NEWS: Add item for "style sources" commands.
2680         * source-cache.c (source_cache::get_source_lines): Check
2681         source_styling.
2682         * cli/cli-style.c (source_styling): New global.
2683         (_initialize_cli_style): Add "style sources" commands.
2684         (show_style_sources): New function.
2685         * cli/cli-style.h (source_styling): Declare.
2686
2687 2019-03-14  Pedro Alves  <palves@redhat.com>
2688             Tom Tromey  <tromey@adacore.com>
2689
2690         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2691         * tui/tui-winsource.c (tui_refill_source_window): New function,
2692         from...
2693         (tui_horizontal_source_scroll): ... here.  Move some logic.
2694         * cli/cli-style.c (set_style_enabled): Notify new observable.
2695         * tui/tui-hooks.c (tui_redisplay_source): New function.
2696         (tui_attach_detach_observers): Attach or detach
2697         tui_redisplay_source.
2698         * observable.h (source_styling_changed): New observable.
2699         * observable.c: Define source_styling_changed observable.
2700
2701 2019-03-13  Tom Tromey  <tromey@adacore.com>
2702
2703         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2704         (i386_gnu_nat_target::store_registers): Update.
2705         * target-debug.h (target_debug_print_std_string): New macro.
2706         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2707         * windows-tdep.c (display_one_tib): Update.
2708         * tui/tui-stack.c (tui_make_status_line): Update.
2709         * top.c (print_inferior_quit_action): Update.
2710         * thread.c (thr_try_catch_cmd): Update.
2711         (add_thread_with_info): Update.
2712         (thread_target_id_str): Update.
2713         (thr_try_catch_cmd): Update.
2714         (thread_command): Update.
2715         (thread_find_command): Update.
2716         * record-btrace.c (record_btrace_target::info_record)
2717         (record_btrace_resume_thread, record_btrace_target::resume)
2718         (record_btrace_cancel_resume, record_btrace_step_thread)
2719         (record_btrace_target::wait, record_btrace_target::wait)
2720         (record_btrace_target::wait, record_btrace_target::stop): Update.
2721         * progspace.c (print_program_space): Update.
2722         * process-stratum-target.c
2723         (process_stratum_target::thread_address_space): Update.
2724         * linux-fork.c (linux_fork_mourn_inferior)
2725         (detach_checkpoint_command, info_checkpoints_command)
2726         (linux_fork_context): Update.
2727         (linux_fork_detach): Update.
2728         (class scoped_switch_fork_info): Update.
2729         (delete_checkpoint_command): Update.
2730         * infrun.c (follow_fork_inferior): Update.
2731         (follow_fork_inferior): Update.
2732         (proceed_after_vfork_done): Update.
2733         (handle_vfork_child_exec_or_exit): Update.
2734         (follow_exec): Update.
2735         (displaced_step_prepare_throw): Update.
2736         (displaced_step_restore): Update.
2737         (start_step_over): Update.
2738         (resume_1): Update.
2739         (clear_proceed_status_thread): Update.
2740         (proceed): Update.
2741         (print_target_wait_results): Update.
2742         (do_target_wait): Update.
2743         (context_switch): Update.
2744         (stop_all_threads): Update.
2745         (restart_threads): Update.
2746         (finish_step_over): Update.
2747         (handle_signal_stop): Update.
2748         (switch_back_to_stepped_thread): Update.
2749         (keep_going_pass_signal): Update.
2750         (print_exited_reason): Update.
2751         (normal_stop): Update.
2752         * inferior.c (inferior_pid_to_str): Change return type.
2753         (print_selected_inferior): Update.
2754         (add_inferior): Update.
2755         (detach_inferior): Update.
2756         * dummy-frame.c (fprint_dummy_frames): Update.
2757         * dcache.c (dcache_info_1): Update.
2758         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2759         (btrace_fetch, btrace_clear): Update.
2760         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2761         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2762         type.
2763         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2764         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2765         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2766         * gdbarch.c, gdbarch.h: Rebuild.
2767         * gdbarch.sh (core_pid_to_str): Change return type.
2768         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2769         return type.
2770         (windows_nat_target::pid_to_str): Change return type.
2771         (windows_delete_thread): Update.
2772         (windows_nat_target::attach): Update.
2773         (windows_nat_target::files_info): Update.
2774         * target-delegates.c: Rebuild.
2775         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2776         return type.
2777         (sol_thread_target::pid_to_str): Change return type.
2778         * remote.c (class remote_target) <pid_to_str>: Change return
2779         type.
2780         (remote_target::pid_to_str): Change return type.
2781         (extended_remote_target::attach, remote_target::remote_stop_ns)
2782         (remote_target::remote_notif_remove_queued_reply)
2783         (remote_target::push_stop_reply, remote_target::disable_btrace):
2784         Update.
2785         (extended_remote_target::attach): Update.
2786         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2787         type.
2788         (gdbsim_target::pid_to_str): Change return type.
2789         * ravenscar-thread.c (struct ravenscar_thread_target)
2790         <pid_to_str>: Change return type.
2791         (ravenscar_thread_target::pid_to_str): Change return type.
2792         * procfs.c (class procfs_target) <pid_to_str>: Change return
2793         type.
2794         (procfs_target::pid_to_str): Change return type.
2795         (procfs_target::attach): Update.
2796         (procfs_target::detach): Update.
2797         (procfs_target::fetch_registers): Update.
2798         (procfs_target::store_registers): Update.
2799         (procfs_target::wait): Update.
2800         (procfs_target::files_info): Update.
2801         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2802         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2803         return type.
2804         (nto_procfs_target::pid_to_str): Change return type.
2805         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2806         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2807         return type.
2808         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2809         (exit_lwp): Update.
2810         (attach_proc_task_lwp_callback, get_detach_signal)
2811         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2812         (linux_nat_target::resume, wait_lwp, stop_callback)
2813         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2814         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2815         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2816         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2817         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2818         type.
2819         (inf_ptrace_target::attach): Update.
2820         (inf_ptrace_target::files_info): Update.
2821         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2822         type.
2823         (go32_nat_target::pid_to_str): Change return type.
2824         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2825         (gnu_nat_target::wait): Update.
2826         (gnu_nat_target::wait): Update.
2827         (gnu_nat_target::resume): Update.
2828         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2829         (fbsd_nat_target::wait): Update.
2830         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2831         type.
2832         (darwin_nat_target::attach): Update.
2833         * corelow.c (class core_target) <pid_to_str>: Change return type.
2834         (core_target::pid_to_str): Change return type.
2835         * target.c (normal_pid_to_str): Change return type.
2836         (default_pid_to_str): Likewise.
2837         (target_pid_to_str): Change return type.
2838         (target_translate_tls_address): Update.
2839         (target_announce_detach): Update.
2840         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2841         return type.
2842         (bsd_uthread_target::pid_to_str): Change return type.
2843         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2844         type.
2845         (bsd_kvm_target::pid_to_str): Change return type.
2846         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2847         return type.
2848         (aix_thread_target::pid_to_str): Change return type.
2849         * target.h (struct target_ops) <pid_to_str>: Change return type.
2850         (target_pid_to_str, normal_pid_to_str): Likewise.
2851         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2852         type.
2853         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2854         type.
2855         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2856         return type.
2857         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2858         type.
2859         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2860         type.
2861         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2862         return type.
2863
2864 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2865
2866         * NEWS: Mention that the new default MI version is 3.  Mention
2867         changes to the output of commands and events that deal with
2868         multi-location breakpoints.
2869         * breakpoint.c: Include "mi/mi-out.h".
2870         (print_one_breakpoint): Change output syntax if using MI version
2871         >= 3.
2872         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2873         New.
2874         (mi_multi_location_breakpoint_output_fixed): New.
2875         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2876         (mi_cmd_fix_multi_location_breakpoint_output): New.
2877         (mi_multi_location_breakpoint_output_fixed): New.
2878         * mi/mi-cmds.c (mi_cmds): Register command
2879         -fix-multi-location-breakpoint-output.
2880         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2881         interpreter "mi".
2882
2883 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2884
2885         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2886         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2887         instantiate mi_ui_out based on interpreter name.
2888         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2889         * mi/mi-main.c (mi_load_progress): Likewise.
2890
2891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2892
2893         * NEWS: Combine separate "New targets" sections for 8.3.
2894
2895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2896
2897         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2898         (ppcfbsd_init_abi): Install gdbarch
2899         "fetch_tls_load_module_address" and "get_thread_local_address"
2900         methods.
2901
2902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2903
2904         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2905         (riscv_fbsd_init_abi): Install gdbarch
2906         "fetch_tls_load_module_address" and "get_thread_local_address"
2907         methods.
2908
2909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2910
2911         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2912         (i386fbsd_init_abi): Install gdbarch
2913         "fetch_tls_load_module_address" and "get_thread_local_address"
2914         methods.
2915
2916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2917
2918         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2919         (amd64fbsd_init_abi): Install gdbarch
2920         "fetch_tls_load_module_address" and "get_thread_local_address"
2921         methods.
2922
2923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2924
2925         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2926         (struct fbsd_pspace_data): New type.
2927         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2928         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2929         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2930         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2931         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2932
2933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2934
2935         * gdbtypes.c (lookup_struct_elt): New function.
2936         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2937         * gdbtypes.h (struct struct_elt): New type.
2938         (lookup_struct_elt): New prototype.
2939
2940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2941
2942         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2943         remove disabled code block.
2944
2945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2946
2947         * gdbarch.sh (get_thread_local_address): New method.
2948         * gdbarch.h, gdbarch.c: Regenerate.
2949         * target.c (target_translate_tls_address): Use
2950         gdbarch_get_thread_local_address if present instead of
2951         target::get_thread_local_address.
2952
2953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2954
2955         * target.h (target::get_thread_local_address): Update comment.
2956
2957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2958
2959         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2960         objfile->separate_debug_objfile_backlink if not NULL.
2961
2962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2963
2964         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2965         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2966         (amd64bsd_store_inferior_registers): Likewise.
2967         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2968         Enable segment base registers.
2969         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2970         PT_GETFSBASE and PT_GETGSBASE.
2971         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2972         PT_SETGSBASE.
2973         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2974         segment base registers.
2975         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2976
2977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2978
2979         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2980         Update calls to i386_target_description to add 'segments'
2981         parameter.
2982         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2983         add segment base registers.
2984         * arch/i386.c (i386_create_target_description): Add 'segments'
2985         parameter to enable segment base registers.
2986         * arch/i386.h (i386_create_target_description): Likewise.
2987         * features/i386/32bit-segments.xml: New file.
2988         * features/i386/32bit-segments.c: Generate.
2989         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2990         call to i386_target_description to add 'segments' parameter.
2991         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2992         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2993         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2994         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2995         if feature is present.
2996         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2997         Add 'segments' parameter to call to i386_target_description.
2998         (i386_target_description): Add 'segments' parameter to enable
2999         segment base registers.
3000         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3001         to call to i386_target_description.
3002         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3003         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3004         Define I386_NUM_REGS.
3005         (i386_target_description): Add 'segments' parameter to enable
3006         segment base registers.
3007
3008 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3009
3010         PR/24325
3011         * source-cache.c: #undef open and close, to avoid unresolved
3012         externals during linking.
3013
3014 2019-03-12  Tom Tromey  <tromey@adacore.com>
3015
3016         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3017         const.  Add initializers.
3018         (_initialize_remote): Don't initialize ptid globals.
3019
3020 2019-03-12  Pedro Alves  <palves@redhat.com>
3021
3022         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3023
3024 2019-03-12  Pedro Alves  <palves@redhat.com>
3025
3026         * cp-name-parser.y (main): Remove unused 'len' variable.
3027
3028 2019-03-12  Tom Tromey  <tromey@adacore.com>
3029
3030         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3031         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3032
3033 2019-03-12  Tom Tromey  <tromey@adacore.com>
3034
3035         * linux-nat.c (iterate_over_lwps): Update.
3036         (stop_callback): Remove parameter.
3037         (stop_wait_callback, detach_callback, resume_set_callback)
3038         (select_singlestep_lwp_callback, set_ignore_sigint)
3039         (status_callback, resumed_callback, resume_clear_callback)
3040         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3041         data parameter.
3042         (linux_nat_target::detach, linux_nat_target::resume)
3043         (linux_stop_and_wait_all_lwps, select_event_lwp)
3044         (linux_nat_filter_event, linux_nat_wait_1)
3045         (linux_nat_target::kill, linux_nat_target::stop)
3046         (linux_nat_target::stop): Update.
3047         (linux_nat_resume_callback): Change type.
3048         (resume_stopped_resumed_lwps, count_events_callback)
3049         (select_event_lwp_callback): Likewise.
3050         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3051         * arm-linux-nat.c (struct update_registers_data): Remove.
3052         (update_registers_callback): Change type.
3053         (arm_linux_insert_hw_breakpoint1): Update.
3054         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3055         parameter.
3056         (x86_linux_dr_set_addr): Update.
3057         (x86_linux_dr_set_control): Update.
3058         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3059         (iterate_over_lwps): Use gdb::function_view.
3060         * nat/aarch64-linux-hw-point.c (struct
3061         aarch64_dr_update_callback_param): Remove.
3062         (debug_reg_change_callback): Change type.
3063         (aarch64_notify_debug_reg_change): Update.
3064         * s390-linux-nat.c (s390_refresh_per_info): Update.
3065
3066 2019-03-11  Tom Tromey  <tromey@adacore.com>
3067
3068         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3069         redundant assignment to "this_cu".
3070
3071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3072
3073         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3074
3075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3076
3077         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3078         from...
3079         (rank_one_type): ... this.
3080
3081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3082
3083         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3084         from...
3085         (rank_one_type): ... this.
3086
3087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3088
3089         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3090         from...
3091         (rank_one_type): ... this.
3092
3093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3094
3095         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3096         from...
3097         (rank_one_type): ... this.
3098
3099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3100
3101         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3102         from...
3103         (rank_one_type): ... this.
3104
3105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3106
3107         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3108         from...
3109         (rank_one_type): ... this.
3110
3111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3112
3113         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3114         from...
3115         (rank_one_type): ... this.
3116
3117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3118
3119         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3120         from...
3121         (rank_one_type): ... this.
3122
3123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3124
3125         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3126         from...
3127         (rank_one_type): ... this.
3128
3129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3130
3131         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3132         from...
3133         (rank_one_type): ... this.
3134
3135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3136
3137         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3138         from...
3139         (rank_one_type): ... this.
3140
3141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3142
3143         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3144         from...
3145         (rank_one_type): ... this.
3146
3147 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3148
3149         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3150         inferior-events' shows the example events.
3151
3152 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3153
3154         Support styling on native MS-Windows console
3155
3156         PR/24315
3157         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3158         on MS-Windows if $TERM is not defined.
3159
3160         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3161
3162         * posix-hdep.c (gdb_console_fputs):
3163         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3164         functions.
3165         * ui-file.h (gdb_console_fputs): Add prototype.
3166
3167         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3168         back to fputs only if the former returns zero.
3169
3170 2019-03-07  Tom Tromey  <tom@tromey.com>
3171
3172         * symmisc.c (print_symbol_bcache_statistics): Update.
3173         (print_objfile_statistics): Update.
3174         * symfile.c (allocate_symtab): Update.
3175         * stabsread.c: Don't include bcache.h.
3176         * psymtab.h (struct psymbol_bcache): Don't declare.
3177         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3178         (psymbol_bcache_init, psymbol_bcache_free)
3179         (psymbol_bcache_get_bcache): Don't declare.
3180         * psymtab.c (struct psymbol_bcache): Remove.
3181         (psymtab_storage::psymtab_storage): Update.
3182         (psymtab_storage::~psymtab_storage): Update.
3183         (psymbol_bcache_init, psymbol_bcache_free)
3184         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3185         (add_psymbol_to_bcache): Update.
3186         (allocate_psymtab): Update.
3187         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3188         macro_cache>: No longer pointers.
3189         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3190         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3191         * macrotab.c (macro_bcache): Update.
3192         * macroexp.c: Don't include bcache.h.
3193         * gdbtypes.c (check_types_worklist): Update.
3194         (types_deeply_equal): Remove TRY/CATCH.  Update.
3195         * elfread.c (elf_symtab_read): Update.
3196         * dwarf2read.c: Don't include bcache.h.
3197         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3198         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3199         (print_bcache_statistics, bcache_memory_used): Don't declare.
3200         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3201         methods.  Rename all data members.
3202         * bcache.c (struct bcache): Move to bcache.h.
3203         (bcache::expand_hash_table): Rename from expand_hash_table.
3204         (bcache): Remove.
3205         (bcache::insert): Rename from bcache_full.
3206         (bcache::compare): Rename from bcache_compare.
3207         (bcache_xmalloc): Remove.
3208         (bcache::~bcache): Rename from bcache_xfree.
3209         (bcache::print_statistics): Rename from print_bcache_statistics.
3210         (bcache::memory_used): Rename from bcache_memory_used.
3211
3212 2019-03-07  Pedro Alves  <palves@redhat.com>
3213
3214         * infrun.c (normal_stop): Also check for
3215         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3216
3217 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         * f-lang.c (value_from_host_double): Moved to...
3220         * value.c (value_from_host_double): ...here.
3221         * value.h (value_from_host_double): Declare.
3222         * guile/scm-math.c (vlscm_convert_typed_number): Use
3223         value_from_host_double.
3224         (vlscm_convert_number): Likewise.
3225         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3226         * python/py-value.c (convert_value_from_python): Likewise.
3227
3228 2019-03-06  Tom Tromey  <tom@tromey.com>
3229
3230         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3231
3232 2019-03-06  Tom Tromey  <tom@tromey.com>
3233
3234         * utils.h (free_current_contents): Don't declare.
3235         * utils.c (free_current_contents): Remove.
3236
3237 2019-03-06  Tom Tromey  <tom@tromey.com>
3238
3239         * top.c (quit_force): Update.
3240         * main.c (captured_command_loop): Update.
3241         * common/new-op.c (operator new): Update.
3242         * common/common-exceptions.c (struct catcher)
3243         <save_cleanup_chain>: Remove member.
3244         (exceptions_state_mc_init): Update.
3245         (exception_try_scope_entry): Return nullptr.
3246         (exception_try_scope_exit, exception_rethrow)
3247         (throw_exception_sjlj, throw_exception_cxx): Update.
3248         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3249         (all_cleanups, do_cleanups, discard_cleanups)
3250         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3251         (restore_cleanups, restore_final_cleanups): Don't declare.
3252         (do_final_cleanups): Remove parameter.
3253         * common/cleanups.c (cleanup_chain, make_cleanup)
3254         (make_cleanup_dtor, all_cleanups, do_cleanups)
3255         (discard_my_cleanups, discard_cleanups)
3256         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3257         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3258         (null_cleanup): Remove.
3259         (do_final_cleanups): Remove parameter.
3260
3261 2019-03-06  Tom Tromey  <tom@tromey.com>
3262
3263         * remote.c (remote_target::remote_parse_stop_reply): Use
3264         unique_xmalloc_ptr.
3265
3266 2019-03-06  Tom Tromey  <tom@tromey.com>
3267
3268         * stabsread.c (struct stabs_field_info): Rename from field_info.
3269         <list, fnlist>: Add initializers.
3270         <obstack>: New member.
3271         (read_member_functions, read_struct_fields, read_baseclasses):
3272         Allocate on obstack.  Don't use cleanups.
3273         (read_one_struct_field, read_member_functions, read_struct_fields)
3274         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3275         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3276         (read_struct_type): Update.
3277
3278 2019-03-06  Tom Tromey  <tom@tromey.com>
3279
3280         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3281         * common/filestuff.h (make_cleanup_close): Don't declare.
3282         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3283         Remove.
3284
3285 2019-03-06  Tom Tromey  <tom@tromey.com>
3286
3287         * solib-aix.c: Use make_scope_exit.
3288
3289 2019-03-06  Tom Tromey  <tom@tromey.com>
3290
3291         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3292         Use make_scope_exit.
3293
3294 2019-03-06  Tom Tromey  <tom@tromey.com>
3295
3296         * solib-svr4.c (disable_probes_interface): Remove parameter.
3297         (svr4_handle_solib_event): Use make_scope_exit.
3298
3299 2019-03-06  Tom Tromey  <tom@tromey.com>
3300
3301         * remote.c (struct stop_reply_deleter): Remove.
3302         (stop_reply_up): Update.
3303         (struct stop_reply): Derive from notif_event.  Don't typedef.
3304         <regcache>: Now a std::vector.
3305         (stop_reply_xfree): Remove.
3306         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3307         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3308         (remote_target::discard_pending_stop_replies): Use delete.
3309         (remote_target::remote_parse_stop_reply): Update.
3310         (remote_target::process_stop_reply): Update.
3311         * remote-notif.h (struct notif_event): Add virtual destructor.
3312         Remove "dtr" member.
3313         (struct notif_client) <alloc_event>: Return a unique_ptr.
3314         (notif_event_xfree): Don't declare.
3315         (notif_event_up): New typedef.
3316         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3317         (notif_event_xfree, do_notif_event_xfree): Remove.
3318         (remote_notif_state_xfree): Update.
3319
3320 2019-03-06  Tom Tromey  <tom@tromey.com>
3321
3322         * infrun.c (displaced_step_clear_cleanup): Now a
3323         forward_scope_exit type.
3324         (displaced_step_prepare_throw): Update.
3325         (displaced_step_fixup): Update.
3326
3327 2019-03-06  Tom Tromey  <tom@tromey.com>
3328
3329         * inferior.h (class inferior): Update comment.
3330         * gdbthread.h (class thread_info): Update comment.
3331
3332 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3333             Tom Tromey  <tom@tromey.com>
3334
3335         * stabsread.h (struct stab_section_list): Remove.
3336         (coffstab_build_psymtabs): Update.
3337         * dbxread.c (symbuf_sections): Now a std::vector.
3338         (sect_idx): New global.
3339         (fill_symbuf): Update.
3340         (coffstab_build_psymtabs): Change type of stabsects parameter.
3341         Update.
3342         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3343         std::vector.
3344         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3345         (coff_locate_sections): Update.
3346         (coff_symfile_read): Remove cleanups.  Update.
3347         (init_stringtab): Add storage parameter.
3348         (free_stringtab, free_stringtab_cleanup): Remove.
3349         (init_lineno): Add storage parameter.
3350         (free_linetab, free_linetab_cleanup): Remove.
3351
3352 2019-03-06  Pedro Alves  <palves@redhat.com>
3353
3354         * linux-fork.c (fork_info::clobber_regs): Delete.
3355         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3356         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3357         comment.  Adjust.
3358         (scoped_switch_fork_info::scoped_switch_fork_info)
3359         (checkpoint_command, linux_fork_context): Adjust
3360         fork_save_infrun_state calls.
3361
3362 2019-03-06  Pedro Alves  <palves@redhat.com>
3363
3364         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3365         (inf_has_multiple_threads): Return 'bool' and rewrite using
3366         inferior_info::threads().
3367
3368 2019-03-06  Pedro Alves  <palves@redhat.com>
3369
3370         * linux-fork.c: Include <list>.
3371         (fork_list): Now a std::list instance.
3372         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3373         (forks_exist_p, find_last_fork): Adjust.
3374         (new_fork): Delete.
3375         (one_fork_p): New.
3376         (add_fork): Adjust.
3377         (free_fork): Delete, folded into fork_info::~fork_info().
3378         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3379         Adjust.
3380         (init_fork_list): Delete.
3381         (linux_fork_killall, linux_fork_mourn_inferior)
3382         (linux_fork_detach, info_checkpoints_command): Adjust.
3383         (_initialize_linux_fork): No longer call init_fork_list.
3384
3385 2019-03-06  Pedro Alves  <palves@redhat.com>
3386
3387         * linux-fork.c (new_fork): New, split out of ...
3388         (add_fork): ... this.  Return void.  Move "first fork" special
3389         case from here, to ...
3390         (checkpoint_command): ... here.
3391         * linux-linux.h (add_fork): Return void.
3392
3393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3396
3397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3398             Chris January  <chris.january@arm.com>
3399             David Lecomber  <david.lecomber@arm.com>
3400
3401         * f-exp.y: New token, UNOP_INTRINSIC.
3402         (exp): New pattern using UNOP_INTRINSIC token.
3403         (f77_keywords): Add 'abs' keyword.
3404         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3405         (value_from_host_double): New function.
3406         (evaluate_subexp_f): Support UNOP_ABS.
3407
3408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3409
3410         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3411         types.
3412
3413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3416         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3417         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3418
3419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3422
3423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3424             Chris January  <chris.january@arm.com>
3425
3426         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3427         * f-exp.y: Define 'KIND' token.
3428         (exp): New pattern for KIND expressions.
3429         (ptype): Handle types with a kind extension.
3430         (direct_abs_decl): Extend to spot kind extensions.
3431         (f77_keywords): Add 'kind' to the list.
3432         (push_kind_type): New function.
3433         (convert_to_kind_type): New function.
3434         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3435         * parse.c (operator_length_standard): Likewise.
3436         * parser-defs.h (enum type_pieces): Add tp_kind.
3437         * std-operator.def: Add UNOP_KIND.
3438
3439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * f-exp.y (f_parse): Set yydebug.
3442
3443 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3444
3445         * f-lang.c (evaluate_subexp_f): New function.
3446         (exp_descriptor_f): New global.
3447         (f_language_defn): Use exp_descriptor_f instead of
3448         exp_descriptor_standard.
3449
3450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * f-exp.y (struct token): Add comments.
3453         (dot_ops): Remove uppercase versions and the end marker.
3454         (f77_keywords): Likewise.
3455         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3456         entries in the dot_ops array are case insensitive, and use
3457         strncasecmp to compare strings.  Also some whitespace cleanup in
3458         this area.  Similar for the f77_keywords array, except entries in
3459         this list might be case sensitive.
3460
3461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * f-exp.y (struct f77_boolean_val): Add comments.
3464         (boolean_values): Remove uppercase versions, and end marker.
3465         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3466         and use strncasecmp to achieve case insensitivity.  Additionally,
3467         perform whitespace cleanup around this code.
3468
3469 2019-03-06  Tom Tromey  <tromey@adacore.com>
3470
3471         * remote-sim.c (gdbsim_target_open): Use result of
3472         gdb_argv::release.
3473
3474 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3475         Dirk Schubert  <dirk.schubert@arm.com>
3476         Chris January  <chris.january@arm.com>
3477
3478         * eval.c (evaluate_subexp_standard): Call Fortran argument
3479         wrapping logic.
3480         * f-lang.c (struct value): A value which can be passed into a
3481         Fortran function call.
3482         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3483         where appropriate.
3484         (struct type): Value ready for a Fortran function call.
3485         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3486         is needed.
3487         * f-lang.h (fortran_argument_convert): Declaration.
3488         (fortran_preserve_arg_pointer): Declaration.
3489         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3490
3491 2019-03-05  Tom Tromey  <tromey@adacore.com>
3492
3493         * python/py-prettyprint.c (print_string_repr): Remove #if.
3494         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3495
3496 2019-03-05  Tom Tromey  <tromey@adacore.com>
3497
3498         * target.c (the_dummy_target): Move later.  Change type to
3499         "dummy_target".
3500         (initialize_targets): Don't initialize the_dummy_target.
3501
3502 2019-03-05  Tom Tromey  <tromey@adacore.com>
3503
3504         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3505         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3506
3507 2019-03-05  Tom Tromey  <tromey@adacore.com>
3508
3509         * windows-nat.c (windows_nat_target::attach)
3510         (windows_nat_target::detach): Don't call gdb_flush.
3511         * valprint.c (generic_val_print, val_print, val_print_string):
3512         Don't call gdb_flush.
3513         * utils.c (defaulted_query): Don't call gdb_flush.
3514         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3515         * target.c (target_announce_detach): Don't call gdb_flush.
3516         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3517         * remote.c (extended_remote_target::attach): Don't call
3518         gdb_flush.
3519         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3520         * printcmd.c (do_examine): Don't call gdb_flush.
3521         (info_display_command): Don't call gdb_flush.
3522         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3523         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3524         * memattr.c (info_mem_command): Don't call gdb_flush.
3525         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3526         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3527         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3528         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3529         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3530         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3531         (gnu_nat_target::detach): Don't call gdb_flush.
3532         * f-valprint.c (f_val_print): Don't call gdb_flush.
3533         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3534         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3535         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3536         gdb_flush.
3537         * c-valprint.c (c_val_print): Don't call gdb_flush.
3538         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3539
3540 2019-03-05  Tom Tromey  <tromey@adacore.com>
3541
3542         * varobj.c (update_dynamic_varobj_children): Update.
3543         (install_default_visualizer): Use reset, not release.
3544         * value.c (set_internalvar): Update.
3545         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3546         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3547         ATTRIBUTE_UNUSED_RESULT.
3548
3549 2019-03-05  Tom Tromey  <tromey@adacore.com>
3550
3551         * remote.c (class scoped_remote_fd) <release>: Add
3552         ATTRIBUTE_UNUSED_RESULT.
3553
3554 2019-03-05  Tom Tromey  <tromey@adacore.com>
3555
3556         * macroexp.c (struct macro_buffer) <release>: Add
3557         ATTRIBUTE_UNUSED_RESULT.
3558
3559 2019-03-05  Tom Tromey  <tromey@adacore.com>
3560
3561         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3562         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3563         ATTRIBUTE_UNUSED_RESULT.
3564
3565 2019-03-05  Tom Tromey  <tromey@adacore.com>
3566
3567         * common/scoped_fd.h (class scoped_fd) <release>: Add
3568         ATTRIBUTE_UNUSED_RESULT.
3569
3570 2019-03-05  Tom Tromey  <tromey@adacore.com>
3571
3572         * parser-defs.h (struct parser_state) <release>: Add
3573         ATTRIBUTE_UNUSED_RESULT.
3574
3575 2019-03-05  Tom Tromey  <tromey@adacore.com>
3576
3577         * utils.h (class gdb_argv) <release>: Add
3578         ATTRIBUTE_UNUSED_RESULT.
3579         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3580
3581 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3582
3583         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3584         for-loop range, to avoid compiler warnings.
3585
3586         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3587         avoid compiler warnings about unused variables.
3588
3589         * NEWS: Mention end of support for native debugging on MS-Windows
3590         before XP.
3591
3592         PR gdb/24292
3593         * common/netstuff.c:
3594         * gdbserver/gdbreplay.c
3595         * gdbserver/remote-utils.c:
3596         * ser-tcp.c:
3597         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3598         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3599         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3600         'getaddrinfo' and 'freeaddrinfo' were not available before
3601         Windows XP, and mingw.org's MinGW headers by default define
3602         _WIN32_WINNT to 0x500.
3603
3604 2019-03-01  Gary Benson <gbenson@redhat.com>
3605
3606         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3607
3608 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3609             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3610
3611         PR gdb/8527
3612         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3613         set_sigint_trap, clear_sigint_trap.
3614
3615 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3616
3617         * target.c (target_detach): Clear the regcache and the
3618         frame cache.
3619
3620 2019-02-27  Pedro Alves  <palves@redhat.com>
3621
3622         * utils.c (set_screen_size): When we cap the height/width sizes,
3623         tweak the corresponding command variable to show "unlimited":
3624
3625 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3626             Pedro Alves  <palves@redhat.com>
3627
3628         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3629         before calling rl_set_screen_size.
3630
3631 2019-02-27  Tom Tromey  <tromey@adacore.com>
3632
3633         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3634         define.
3635         * python/py-value.c: Remove Python 2.4 workaround.
3636         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3637         workaround.
3638         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3639         Python 2.4 workaround.
3640         * python/python-internal.h: Remove Python 2.4 comment.
3641         (Py_ssize_t): Don't define.
3642         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3643         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3644         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3645         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3646         * python/python.c (do_start_initialization): Remove Python 2.4
3647         workaround.
3648         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3649         (print_children): Remove Python 2.4 workaround.
3650         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3651         workaround.
3652         (CHARBUFFERPROC_NAME): Remove.
3653         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3654         Python 2.4 workaround.
3655
3656 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3657
3658         * NEWS: Note minimum Python version.
3659
3660 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3661
3662         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3663         code from these functions.  Remove corresponding ifdefs.  Use
3664         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3665         Remove gotos and target of gotos.
3666         (infpy_search_memory): Likewise.
3667
3668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3671         (hppa_gdbarch_init): Don't register deleted functions with
3672         gdbarch.
3673
3674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3677         (h8300_unwind_sp): Delete.
3678         (h8300_dummy_id): Delete.
3679         (h8300_gdbarch_init): Don't register deleted functions with
3680         gdbarch.
3681
3682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3685         (ft32_unwind_pc): Delete.
3686         (ft32_unwind_sp): Delete.
3687         (ft32_gdbarch_init): Don't register deleted functions with
3688         gdbarch.
3689
3690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3693         (frv_unwind_pc): Delete.
3694         (frv_unwind_sp): Delete.
3695         (frv_gdbarch_init): Don't register deleted functions with
3696         gdbarch.
3697
3698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3701         (riscv_unwind_pc): Delete.
3702         (riscv_unwind_sp): Delete.
3703         (riscv_gdbarch_init): Don't register deleted functions with
3704         gdbarch.
3705
3706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3709         (csky_unwind_pc): Delete.
3710         (csky_unwind_sp): Delete.
3711         (csky_gdbarch_init): Don't register deleted functions with
3712         gdbarch.
3713
3714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3717         (cris_unwind_pc): Delete.
3718         (cris_unwind_sp): Delete.
3719         (cris_gdbarch_init): Don't register deleted functions with
3720         gdbarch.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3725         (bfin_unwind_pc): Delete.
3726         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3727
3728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3731         (arm_unwind_pc): Delete.
3732         (arm_unwind_sp): Delete.
3733         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3734
3735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3736
3737         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3738         (arc_unwind_pc): Delete.
3739         (arc_unwind_sp): Delete.
3740         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3741
3742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3745         (alpha_unwind_pc): Delete.
3746         (alpha_gdbarch_init): Don't register deleted functions with
3747         gdbarch.
3748
3749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3752         (aarch64_unwind_pc): Delete.
3753         (aarch64_unwind_sp): Delete.
3754         (aarch64_gdbarch_init): Don't register deleted functions with
3755         gdbarch.
3756
3757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * gdbtypes.c (type_align): Don't consider static members when
3760         computing structure alignment.
3761
3762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3765         return 0 for other types.
3766         * arch-utils.c (default_type_align): Always return 0.
3767         * gdbarch.h: Regenerate.
3768         * gdbarch.sh (type_align): Extend comment.
3769         * gdbtypes.c (type_align): Add additional comments, always call
3770         gdbarch_type_align before applying the default rules.
3771         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3772         generic code will then apply a suitable default.
3773         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3774         types, return 0 for other types.
3775
3776 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3777
3778         * NEWS: Create a new section for the next release branch.
3779         Rename the section of the current branch, now that it has
3780         been cut.
3781
3782 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3783
3784         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3785         * version.in: Bump version to 8.3.50.DATE-git.
3786
3787 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3788
3789         * aix-thread.c (ptid_cmp): Remove unused variable.
3790         (get_signaled_thread): Likewise.
3791         (store_regs_user_thread): Likewise.
3792         (store_regs_kernel_thread): Likewise.
3793         (fetch_regs_kernel_thread): Remove shadowed variable.
3794
3795 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * features/riscv/32bit-cpu.xml: Add register numbers.
3798         * features/riscv/32bit-fpu.c: Regenerate.
3799         * features/riscv/32bit-fpu.xml: Add register numbers.
3800         * features/riscv/64bit-cpu.xml: Add register numbers.
3801         * features/riscv/64bit-fpu.c: Regenerate.
3802         * features/riscv/64bit-fpu.xml: Add register numbers.
3803
3804 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3805
3806         * NEWS: Mention two argument form of gdb.Value constructor.
3807         * python/py-value.c (convert_buffer_and_type_to_value): New
3808         function.
3809         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3810         Add support for handling an optional second argument.  Call
3811         convert_buffer_and_type_to_value as appropriate.
3812         * python/python-internal.h (Py_buffer_deleter): New struct.
3813         (Py_buffer_up): New typedef.
3814
3815 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3816
3817         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3818         instead of releasing ownership.
3819
3820 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3821
3822         * dwarf2read.c (open_and_init_dwp_file): Call
3823         elf_numsections instead of bfd_count_sections to initialize
3824         dwp_file->num_sections.
3825
3826 2019-02-25  Tom Tromey  <tromey@adacore.com>
3827
3828         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3829
3830 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3831
3832         * gcore.in: Add '--readnever' option when invoking GDB.
3833
3834 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3835
3836         * MAINTAINERS: Update my email address.
3837
3838 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3839
3840         * build-id.c (build_id_to_debug_bfd_1): New function.
3841         (build_id_to_debug_bfd): Look for separate debug file in
3842         sysroot.
3843
3844 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * gdbarch.sh: Update the copyright year range that is placed into
3847         generated files.
3848
3849 2019-02-22  Keith Seitz  <keiths@redhat.com>
3850
3851         PR symtab/23853
3852         * linespec.c (create_sals_line_offset): Search for the default
3853         symtab's filename instead of its fullname.
3854
3855 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3856
3857         * NEWS: Update style defaults.
3858
3859 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3860
3861         * main.c (captured_main_1): Disable styling in batch mode.
3862
3863 2019-02-20  Tom Tromey  <tom@tromey.com>
3864
3865         * symtab.c (symtab_symbol_info): Fix typos.
3866
3867 2019-02-20  Tom Tromey  <tromey@adacore.com>
3868
3869         * findcmd.c (_initialize_mem_search): Use upper case for
3870         metasyntactic variables.
3871
3872 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3873
3874         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3875         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3876
3877 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3878
3879         * top.h (source_file_name): Change to std::string.
3880         * top.c (source_file_name): Likewise.
3881         (command_line_input): Adjust.
3882         * cli/cli-script.c (script_from_file): Adjust.
3883
3884 2019-02-19  Tom Tromey  <tromey@adacore.com>
3885
3886         * ravenscar-thread.c
3887         (ravenscar_thread_target::update_thread_list): Don't call
3888         ada_build_task_list.
3889         * ada-lang.h (ada_build_task_list): Don't declare.
3890         * ada-tasks.c (struct ada_tasks_inferior_data)
3891         <task_list_valid_p>: Now bool.
3892         (read_known_tasks, ada_task_list_changed)
3893         (ada_tasks_invalidate_inferior_data): Update.
3894         (read_known_tasks_array): Return bool.
3895         (read_known_tasks_list): Likewise.
3896         (read_known_tasks): Return void.
3897         (ada_build_task_list): Now static.
3898
3899 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3902         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3903
3904 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3905
3906         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3907         variant for ada_tasks_pspace_data_handle and
3908         ada_tasks_inferior_data_handle.
3909         (ada_tasks_pspace_data_cleanup): New function.
3910         (ada_tasks_inferior_data_cleanup): New function.
3911
3912 2019-02-17  Tom Tromey  <tom@tromey.com>
3913
3914         * macrotab.h (macro_source_fullname): Return a std::string.
3915         * macrotab.c (macro_include, check_for_redefinition)
3916         (macro_undef, macro_lookup_definition, foreach_macro)
3917         (foreach_macro_in_scope): Update.
3918         (macro_source_fullname): Return a std::string.
3919         * macrocmd.c (show_pp_source_pos): Update.
3920
3921 2019-02-17  Tom Tromey  <tom@tromey.com>
3922
3923         * macrocmd.c (show_pp_source_pos): Style the file names.
3924
3925 2019-02-17  Tom Tromey  <tom@tromey.com>
3926
3927         PR tui/24197:
3928         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3929
3930 2019-02-17  Tom Tromey  <tom@tromey.com>
3931
3932         * ada-lang.c (user_select_syms): Use filtered printing.
3933         * utils.c (wrap_style): New global.
3934         (desired_style): Remove.
3935         (emit_style_escape): Add stream parameter.
3936         (set_output_style, reset_terminal_style, prompt_for_continue):
3937         Update.
3938         (flush_wrap_buffer): Only flush gdb_stdout.
3939         (wrap_here): Set wrap_style.
3940         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3941         treat escape sequences as a character.  Change when wrap buffer is
3942         flushed.
3943         (fputs_styled): Do not set the output style when the default is
3944         requested.
3945         * ui-style.h (struct ui_file_style) <is_default>: New method.
3946         * source.c (print_source_lines_base): Emit escape sequences in one
3947         piece.
3948
3949 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3950
3951         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3952         integers and enumeration types.
3953
3954 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3955
3956         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3957         instead of lookup_symbol_in_language
3958         (do_exact_match): New function.
3959         (ada_get_symbol_name_matcher): Return do_exact_match when
3960         doing a verbatim match.
3961
3962 2019-02-15  Tom Tromey  <tromey@adacore.com>
3963
3964         * ravenscar-thread.c (ravenscar_thread_target::resume)
3965         (ravenscar_thread_target::wait): Special case wildcard requests.
3966
3967 2019-02-15  Tom Tromey  <tromey@adacore.com>
3968
3969         * ravenscar-thread.c (base_ptid): Remove.
3970         (struct ravenscar_thread_target) <close>: New method.
3971         <m_base_ptid>: New member.
3972         <update_inferior_ptid, active_task, task_is_currently_active,
3973         runtime_initialized>: Declare methods.
3974         <ravenscar_thread_target>: Add constructor.
3975         (ravenscar_thread_target::task_is_currently_active)
3976         (ravenscar_thread_target::update_inferior_ptid)
3977         (ravenscar_runtime_initialized): Rename.  Now methods.
3978         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3979         (ravenscar_thread_target::update_thread_list): Update.
3980         (ravenscar_thread_target::active_task): Now method.
3981         (ravenscar_thread_target::store_registers)
3982         (ravenscar_thread_target::prepare_to_store)
3983         (ravenscar_thread_target::prepare_to_store)
3984         (ravenscar_thread_target::mourn_inferior): Update.
3985         (ravenscar_inferior_created): Use "new" to create target.
3986         (ravenscar_thread_target::get_ada_task_ptid): Update.
3987         (_initialize_ravenscar): Don't initialize base_ptid.
3988         (ravenscar_ops): Remove global.
3989
3990 2019-02-15  Tom Tromey  <tromey@adacore.com>
3991
3992         * target.h (push_target): Declare new overload.
3993         * target.c (push_target): New overload, taking an rvalue reference.
3994         * remote.c (remote_target::open_1): Use push_target overload.
3995         * corelow.c (core_target_open): Use push_target overload.
3996
3997 2019-02-15  Tom Tromey  <tromey@adacore.com>
3998
3999         * ravenscar-thread.c (is_ravenscar_task)
4000         (ravenscar_task_is_currently_active): Return bool.
4001         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4002         (_initialize_ravenscar): Remove "(void)".
4003         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4004         Return bool.
4005
4006 2019-02-15  Tom Tromey  <tromey@adacore.com>
4007
4008         * ravenscar-thread.c (ravenscar_runtime_initializer)
4009         (has_ravenscar_runtime, get_running_thread_id)
4010         (ravenscar_thread_target::resume): Fix indentation.
4011
4012 2019-02-15  Tom Tromey  <tromey@adacore.com>
4013
4014         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4015         from ravenscar_arch_ops.
4016         (sparc_ravenscar_ops::fetch_registers)
4017         (sparc_ravenscar_ops::store_registers): Now methods.
4018         (sparc_ravenscar_prepare_to_store): Remove.
4019         (sparc_ravenscar_ops): Redefine.
4020         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4021         methods and destructor.  Remove members.
4022         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4023         (ravenscar_thread_target::store_registers)
4024         (ravenscar_thread_target::prepare_to_store): Update.
4025         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4026         Remove.
4027         (struct ppc_ravenscar_powerpc_ops): Derive from
4028         ravenscar_arch_ops.
4029         (ppc_ravenscar_powerpc_ops::fetch_registers)
4030         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4031         (ppc_ravenscar_powerpc_ops): Redefine.
4032         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4033         (ppc_ravenscar_e500_ops::fetch_registers)
4034         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4035         (ppc_ravenscar_e500_ops): Redefine.
4036         * aarch64-ravenscar-thread.c
4037         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4038         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4039         (aarch64_ravenscar_fetch_registers)
4040         (aarch64_ravenscar_store_registers): Now methods.
4041         (aarch64_ravenscar_ops): Redefine.
4042
4043 2019-02-15  Tom Tromey  <tromey@adacore.com>
4044
4045         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4046         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4047         (ravenscar_thread_target::stopped_by_watchpoint)
4048         (ravenscar_thread_target::stopped_data_address)
4049         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4050
4051 2019-02-15  Tom Tromey  <tromey@adacore.com>
4052
4053         * ravenscar-thread.c: Fix some typos.
4054
4055 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4056             Tom Tromey  <tromey@adacore.com>
4057
4058         * ada-lang.c (ada_exception_sal): Change addr_string to a
4059         std::string.
4060         (create_ada_exception_catchpoint): Update.
4061
4062 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4063             Tom Tromey  <tromey@adacore.com>
4064
4065         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4066         (bp_location_ops): Remove.
4067         (base_breakpoint_allocate_location): Update.
4068         (free_bp_location): Update.
4069         * ada-lang.c (class ada_catchpoint_location)
4070         <ada_catchpoint_location>: Remove ops parameter.
4071         (ada_catchpoint_location_dtor): Remove.
4072         (ada_catchpoint_location_ops): Remove.
4073         (allocate_location_exception): Update.
4074         * breakpoint.h (struct bp_location_ops): Remove.
4075         (class bp_location) <bp_location>: Remove bp_location_ops
4076         parameter.
4077         <~bp_location>: Add destructor.
4078         <ops>: Remove.
4079
4080 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4081             Pedro Alves  <palves@redhat.com>
4082
4083         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4084         'PATH_MAX'.
4085
4086 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4087             Samuel Thibault  <samuel.thibault@gnu.org>
4088             Thomas Schwinge  <thomas@codesourcery.com>
4089
4090         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4091         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4092
4093 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4094
4095         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4096         (check_empty): Use "const char *".
4097
4098         * gnu-nat.c (gnu_nat_target::detach): Instead of
4099         'detach_inferior (pid)' call
4100         'detach_inferior (find_inferior_pid (pid))'.
4101
4102         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4103         'nat/fork-inferior.o'.
4104         * gnu-nat.c: #include "nat/fork-inferior.h".
4105
4106         * gnu-nat.c (gnu_nat_target::detach): Instead of
4107         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4108         * gnu-nat.h: #include "inf-child.h".
4109         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4110         'i386_gnu_nat_target::fetch_registers'.
4111         (gnu_store_registers): Rename/move to
4112         'i386_gnu_nat_target::store_registers'.
4113
4114         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4115         * gnu-nat.h (mach_thread_info): New function.
4116         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4117
4118         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4119
4120 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4121
4122         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4123
4124 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4125
4126         * windows-nat.c (windows_add_thread): Add new parameter
4127         "main_thread_p" with default value set to false.  Update
4128         function documentation as well as all callers.
4129         (windows_delete_thread): Likewise.
4130         (fake_create_process): Update call to windows_add_thread.
4131         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4132         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4133         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4134         call to windows_delete_thread.
4135
4136 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4137
4138         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4139
4140 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4141
4142         * symfile.c (find_separate_debug_file): Use canonical path of
4143         sysroot with child_path instead of gdb_sysroot if it is valid.
4144
4145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4146
4147         * symfile.c (find_separate_debug_file): Use child_path to
4148         determine if an object file is under a sysroot.
4149
4150 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4151
4152         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4153         unittests/child-path-selftests.c.
4154         * common/pathstuff.c (child_path): New function.
4155         * common/pathstuff.h (child_path): New prototype.
4156         * unittests/child-path-selftests.c: New file.
4157
4158 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4159
4160         * symfile.c (find_separate_debug_file): Look for separate debug
4161         files in debug directories under the sysroot.
4162
4163 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4164
4165         * symtab.h (struct minimal_symbol data_p): New const method.
4166         (struct minimal_symbol text_p): Likewise.
4167         * symtab.c (output_source_filename): Use file name style
4168         to print file name.
4169         (print_symbol_info): Likewise.
4170         (print_msymbol_info): Use address style to print addresses.
4171         Use function name style to print executable text symbols.
4172         (expand_symtab_containing_pc): Use data_p.
4173         (find_pc_sect_compunit_symtab): Likewise.
4174
4175 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4176
4177         * breakpoint.c (describe_other_breakpoints): Use address style
4178         to print addresses.
4179         (say_where): Likewise.
4180
4181 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4182
4183         * ada-typeprint.c (print_func_type): Print function name
4184         style to print function name.
4185         * c-typeprint.c (c_print_type_1): Likewise.
4186
4187 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4188
4189         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4190         for execve.
4191
4192 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4195         type_stack.
4196
4197 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4198
4199         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4200         TYPE_CODE_REF types.
4201
4202 2019-02-08  Jim Wilson  <jimw@sifive.com>
4203
4204         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4205         (riscv_linux_fregset): New.
4206         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4207
4208 2019-02-07  Tom Tromey  <tom@tromey.com>
4209
4210         * thread.c (thread_cancel_execution_command): Update.
4211         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4212         methods.
4213         (struct thread_fsm_ops): Remove.
4214         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4215         (thread_fsm_should_stop, thread_fsm_return_value)
4216         (thread_fsm_set_finished, thread_fsm_finished_p)
4217         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4218         Don't declare.
4219         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4220         * infrun.c (clear_proceed_status_thread)
4221         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4222         (print_stop_event): Update.
4223         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4224         Add constructor.
4225         (step_command_fsm_ops): Remove.
4226         (new_step_command_fsm): Remove.
4227         (step_1): Update.
4228         (step_command_fsm::should_stop): Rename from
4229         step_command_fsm_should_stop.
4230         (step_command_fsm::clean_up): Rename from
4231         step_command_fsm_clean_up.
4232         (step_command_fsm::do_async_reply_reason): Rename from
4233         step_command_fsm_async_reply_reason.
4234         (struct until_next_fsm): Inherit from thread_fsm.  Add
4235         constructor.
4236         (until_next_fsm_ops): Remove.
4237         (new_until_next_fsm): Remove.
4238         (until_next_fsm::should_stop): Rename from
4239         until_next_fsm_should_stop.
4240         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4241         (until_next_fsm::do_async_reply_reason): Rename from
4242         until_next_fsm_async_reply_reason.
4243         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4244         constructor.  Change type of breakpoint.
4245         (finish_command_fsm_ops): Remove.
4246         (new_finish_command_fsm): Remove.
4247         (finish_command_fsm::should_stop): Rename from
4248         finish_command_fsm_should_stop.
4249         (finish_command_fsm::clean_up): Rename from
4250         finish_command_fsm_clean_up.
4251         (finish_command_fsm::return_value): Rename from
4252         finish_command_fsm_return_value.
4253         (finish_command_fsm::do_async_reply_reason): Rename from
4254         finish_command_fsm_async_reply_reason.
4255         (finish_command): Update.
4256         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4257         Add constructor.
4258         (call_thread_fsm_ops): Remove.
4259         (call_thread_fsm::call_thread_fsm): Rename from
4260         new_call_thread_fsm.
4261         (call_thread_fsm::should_stop): Rename from
4262         call_thread_fsm_should_stop.
4263         (call_thread_fsm::should_notify_stop): Rename from
4264         call_thread_fsm_should_notify_stop.
4265         (run_inferior_call, call_function_by_hand_dummy): Update.
4266         * cli/cli-interp.c (should_print_stop_to_console): Update.
4267         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4268         Add constructor.  Change type of location_breakpoint,
4269         caller_breakpoint.
4270         (until_break_fsm_ops): Remove.
4271         (new_until_break_fsm): Remove.
4272         (until_break_fsm::should_stop): Rename from
4273         until_break_fsm_should_stop.
4274         (until_break_fsm::clean_up): Rename from
4275         until_break_fsm_clean_up.
4276         (until_break_fsm::do_async_reply_reason): Rename from
4277         until_break_fsm_async_reply_reason.
4278         (until_break_command): Update.
4279         * thread-fsm.c: Remove.
4280         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4281
4282 2019-02-07  Tom Tromey  <tom@tromey.com>
4283
4284         * yy-remap.h: Add include guard.
4285         * xtensa-tdep.h: Add include guard.
4286         * xcoffread.h: Rename include guard.
4287         * varobj-iter.h: Add include guard.
4288         * tui/tui.h: Rename include guard.
4289         * tui/tui-winsource.h: Rename include guard.
4290         * tui/tui-wingeneral.h: Rename include guard.
4291         * tui/tui-windata.h: Rename include guard.
4292         * tui/tui-win.h: Rename include guard.
4293         * tui/tui-stack.h: Rename include guard.
4294         * tui/tui-source.h: Rename include guard.
4295         * tui/tui-regs.h: Rename include guard.
4296         * tui/tui-out.h: Rename include guard.
4297         * tui/tui-layout.h: Rename include guard.
4298         * tui/tui-io.h: Rename include guard.
4299         * tui/tui-hooks.h: Rename include guard.
4300         * tui/tui-file.h: Rename include guard.
4301         * tui/tui-disasm.h: Rename include guard.
4302         * tui/tui-data.h: Rename include guard.
4303         * tui/tui-command.h: Rename include guard.
4304         * tic6x-tdep.h: Add include guard.
4305         * target/waitstatus.h: Rename include guard.
4306         * target/wait.h: Rename include guard.
4307         * target/target.h: Rename include guard.
4308         * target/resume.h: Rename include guard.
4309         * target-float.h: Rename include guard.
4310         * stabsread.h: Add include guard.
4311         * rs6000-tdep.h: Add include guard.
4312         * riscv-fbsd-tdep.h: Add include guard.
4313         * regformats/regdef.h: Rename include guard.
4314         * record.h: Rename include guard.
4315         * python/python.h: Rename include guard.
4316         * python/python-internal.h: Rename include guard.
4317         * python/py-stopevent.h: Rename include guard.
4318         * python/py-ref.h: Rename include guard.
4319         * python/py-record.h: Rename include guard.
4320         * python/py-record-full.h: Rename include guard.
4321         * python/py-record-btrace.h: Rename include guard.
4322         * python/py-instruction.h: Rename include guard.
4323         * python/py-events.h: Rename include guard.
4324         * python/py-event.h: Rename include guard.
4325         * procfs.h: Add include guard.
4326         * proc-utils.h: Add include guard.
4327         * p-lang.h: Add include guard.
4328         * or1k-tdep.h: Rename include guard.
4329         * observable.h: Rename include guard.
4330         * nto-tdep.h: Rename include guard.
4331         * nat/x86-linux.h: Rename include guard.
4332         * nat/x86-linux-dregs.h: Rename include guard.
4333         * nat/x86-gcc-cpuid.h: Add include guard.
4334         * nat/x86-dregs.h: Rename include guard.
4335         * nat/x86-cpuid.h: Rename include guard.
4336         * nat/ppc-linux.h: Rename include guard.
4337         * nat/mips-linux-watch.h: Rename include guard.
4338         * nat/linux-waitpid.h: Rename include guard.
4339         * nat/linux-ptrace.h: Rename include guard.
4340         * nat/linux-procfs.h: Rename include guard.
4341         * nat/linux-osdata.h: Rename include guard.
4342         * nat/linux-nat.h: Rename include guard.
4343         * nat/linux-namespaces.h: Rename include guard.
4344         * nat/linux-btrace.h: Rename include guard.
4345         * nat/glibc_thread_db.h: Rename include guard.
4346         * nat/gdb_thread_db.h: Rename include guard.
4347         * nat/gdb_ptrace.h: Rename include guard.
4348         * nat/fork-inferior.h: Rename include guard.
4349         * nat/amd64-linux-siginfo.h: Rename include guard.
4350         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4351         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4352         * nat/aarch64-linux.h: Rename include guard.
4353         * nat/aarch64-linux-hw-point.h: Rename include guard.
4354         * mn10300-tdep.h: Add include guard.
4355         * mips-linux-tdep.h: Add include guard.
4356         * mi/mi-parse.h: Rename include guard.
4357         * mi/mi-out.h: Rename include guard.
4358         * mi/mi-main.h: Rename include guard.
4359         * mi/mi-interp.h: Rename include guard.
4360         * mi/mi-getopt.h: Rename include guard.
4361         * mi/mi-console.h: Rename include guard.
4362         * mi/mi-common.h: Rename include guard.
4363         * mi/mi-cmds.h: Rename include guard.
4364         * mi/mi-cmd-break.h: Rename include guard.
4365         * m2-lang.h: Add include guard.
4366         * location.h: Rename include guard.
4367         * linux-record.h: Rename include guard.
4368         * linux-nat.h: Add include guard.
4369         * linux-fork.h: Add include guard.
4370         * i386-darwin-tdep.h: Rename include guard.
4371         * hppa-linux-offsets.h: Add include guard.
4372         * guile/guile.h: Rename include guard.
4373         * guile/guile-internal.h: Rename include guard.
4374         * gnu-nat.h: Rename include guard.
4375         * gdb-stabs.h: Rename include guard.
4376         * frv-tdep.h: Add include guard.
4377         * f-lang.h: Add include guard.
4378         * event-loop.h: Add include guard.
4379         * darwin-nat.h: Rename include guard.
4380         * cp-abi.h: Rename include guard.
4381         * config/sparc/nm-sol2.h: Rename include guard.
4382         * config/nm-nto.h: Rename include guard.
4383         * config/nm-linux.h: Add include guard.
4384         * config/i386/nm-i386gnu.h: Rename include guard.
4385         * config/djgpp/nl_types.h: Rename include guard.
4386         * config/djgpp/langinfo.h: Rename include guard.
4387         * compile/gcc-cp-plugin.h: Add include guard.
4388         * compile/gcc-c-plugin.h: Add include guard.
4389         * compile/compile.h: Rename include guard.
4390         * compile/compile-object-run.h: Rename include guard.
4391         * compile/compile-object-load.h: Rename include guard.
4392         * compile/compile-internal.h: Rename include guard.
4393         * compile/compile-cplus.h: Rename include guard.
4394         * compile/compile-c.h: Rename include guard.
4395         * common/xml-utils.h: Rename include guard.
4396         * common/x86-xstate.h: Rename include guard.
4397         * common/version.h: Rename include guard.
4398         * common/vec.h: Rename include guard.
4399         * common/tdesc.h: Rename include guard.
4400         * common/selftest.h: Rename include guard.
4401         * common/scoped_restore.h: Rename include guard.
4402         * common/scoped_mmap.h: Rename include guard.
4403         * common/scoped_fd.h: Rename include guard.
4404         * common/safe-iterator.h: Rename include guard.
4405         * common/run-time-clock.h: Rename include guard.
4406         * common/refcounted-object.h: Rename include guard.
4407         * common/queue.h: Rename include guard.
4408         * common/ptid.h: Rename include guard.
4409         * common/print-utils.h: Rename include guard.
4410         * common/preprocessor.h: Rename include guard.
4411         * common/pathstuff.h: Rename include guard.
4412         * common/observable.h: Rename include guard.
4413         * common/netstuff.h: Rename include guard.
4414         * common/job-control.h: Rename include guard.
4415         * common/host-defs.h: Rename include guard.
4416         * common/gdb_wait.h: Rename include guard.
4417         * common/gdb_vecs.h: Rename include guard.
4418         * common/gdb_unlinker.h: Rename include guard.
4419         * common/gdb_unique_ptr.h: Rename include guard.
4420         * common/gdb_tilde_expand.h: Rename include guard.
4421         * common/gdb_sys_time.h: Rename include guard.
4422         * common/gdb_string_view.h: Rename include guard.
4423         * common/gdb_splay_tree.h: Rename include guard.
4424         * common/gdb_setjmp.h: Rename include guard.
4425         * common/gdb_ref_ptr.h: Rename include guard.
4426         * common/gdb_optional.h: Rename include guard.
4427         * common/gdb_locale.h: Rename include guard.
4428         * common/gdb_assert.h: Rename include guard.
4429         * common/filtered-iterator.h: Rename include guard.
4430         * common/filestuff.h: Rename include guard.
4431         * common/fileio.h: Rename include guard.
4432         * common/environ.h: Rename include guard.
4433         * common/common-utils.h: Rename include guard.
4434         * common/common-types.h: Rename include guard.
4435         * common/common-regcache.h: Rename include guard.
4436         * common/common-inferior.h: Rename include guard.
4437         * common/common-gdbthread.h: Rename include guard.
4438         * common/common-exceptions.h: Rename include guard.
4439         * common/common-defs.h: Rename include guard.
4440         * common/common-debug.h: Rename include guard.
4441         * common/cleanups.h: Rename include guard.
4442         * common/buffer.h: Rename include guard.
4443         * common/btrace-common.h: Rename include guard.
4444         * common/break-common.h: Rename include guard.
4445         * cli/cli-utils.h: Rename include guard.
4446         * cli/cli-style.h: Rename include guard.
4447         * cli/cli-setshow.h: Rename include guard.
4448         * cli/cli-script.h: Rename include guard.
4449         * cli/cli-interp.h: Rename include guard.
4450         * cli/cli-decode.h: Rename include guard.
4451         * cli/cli-cmds.h: Rename include guard.
4452         * charset-list.h: Add include guard.
4453         * buildsym-legacy.h: Rename include guard.
4454         * bfin-tdep.h: Add include guard.
4455         * ax.h: Rename include guard.
4456         * arm-linux-tdep.h: Add include guard.
4457         * arm-fbsd-tdep.h: Add include guard.
4458         * arch/xtensa.h: Rename include guard.
4459         * arch/tic6x.h: Add include guard.
4460         * arch/i386.h: Add include guard.
4461         * arch/arm.h: Rename include guard.
4462         * arch/arm-linux.h: Rename include guard.
4463         * arch/arm-get-next-pcs.h: Rename include guard.
4464         * arch/amd64.h: Add include guard.
4465         * arch/aarch64-insn.h: Rename include guard.
4466         * arch-utils.h: Rename include guard.
4467         * annotate.h: Add include guard.
4468         * amd64-darwin-tdep.h: Rename include guard.
4469         * aarch64-linux-tdep.h: Add include guard.
4470         * aarch64-fbsd-tdep.h: Add include guard.
4471         * aarch32-linux-nat.h: Add include guard.
4472
4473 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4474
4475         * macrotab.c (macro_define_internal): New function that
4476         factorizes macro_define_object_internal and macro_define_function
4477         code.
4478         (macro_define_object_internal): Use macro_define_internal.
4479         (macro_define_function): Likewise.
4480
4481 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4482
4483         * macrocmd.c (extract_identifier): Return
4484         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4485         callers.
4486
4487 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4488
4489         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4490
4491 2019-02-05  Tom Tromey  <tom@tromey.com>
4492
4493         * target.c (target_stack::unpush): Move assertion earlier.
4494
4495 2019-01-30  Tom Tromey  <tom@tromey.com>
4496
4497         PR python/23615:
4498         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4499         (gdbpy_parse_and_eval): Likewise.
4500         * python/python-internal.h (gdbpy_allow_threads): New class.
4501
4502 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4503
4504         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4505         (aarch64_fbsd_fpregmap): Move earlier.
4506         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4507         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4508         instead of individual calls to trad_frame_set_reg_addr.
4509         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4510         earlier.
4511         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4512         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4513         instead of individual calls to trad_frame_set_reg_addr.
4514
4515 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4516
4517         * CONTRIBUTE: Replace contribution list with wiki link.
4518
4519 2019-01-25  Tom Tromey  <tom@tromey.com>
4520
4521         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4522
4523 2019-01-25  Tom Tromey  <tom@tromey.com>
4524
4525         * xtensa-linux-nat.c: Fix common/ includes.
4526         * xml-support.h: Fix common/ includes.
4527         * xml-support.c: Fix common/ includes.
4528         * x86-linux-nat.c: Fix common/ includes.
4529         * windows-nat.c: Fix common/ includes.
4530         * varobj.h: Fix common/ includes.
4531         * varobj.c: Fix common/ includes.
4532         * value.c: Fix common/ includes.
4533         * valops.c: Fix common/ includes.
4534         * utils.c: Fix common/ includes.
4535         * unittests/xml-utils-selftests.c: Fix common/ includes.
4536         * unittests/utils-selftests.c: Fix common/ includes.
4537         * unittests/unpack-selftests.c: Fix common/ includes.
4538         * unittests/tracepoint-selftests.c: Fix common/ includes.
4539         * unittests/style-selftests.c: Fix common/ includes.
4540         * unittests/string_view-selftests.c: Fix common/ includes.
4541         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4542         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4543         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4544         * unittests/rsp-low-selftests.c: Fix common/ includes.
4545         * unittests/parse-connection-spec-selftests.c: Fix common/
4546         includes.
4547         * unittests/optional-selftests.c: Fix common/ includes.
4548         * unittests/offset-type-selftests.c: Fix common/ includes.
4549         * unittests/observable-selftests.c: Fix common/ includes.
4550         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4551         * unittests/memrange-selftests.c: Fix common/ includes.
4552         * unittests/memory-map-selftests.c: Fix common/ includes.
4553         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4554         * unittests/function-view-selftests.c: Fix common/ includes.
4555         * unittests/environ-selftests.c: Fix common/ includes.
4556         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4557         * unittests/common-utils-selftests.c: Fix common/ includes.
4558         * unittests/cli-utils-selftests.c: Fix common/ includes.
4559         * unittests/array-view-selftests.c: Fix common/ includes.
4560         * ui-file.c: Fix common/ includes.
4561         * tui/tui-io.c: Fix common/ includes.
4562         * tracepoint.h: Fix common/ includes.
4563         * tracepoint.c: Fix common/ includes.
4564         * tracefile-tfile.c: Fix common/ includes.
4565         * top.h: Fix common/ includes.
4566         * top.c: Fix common/ includes.
4567         * thread.c: Fix common/ includes.
4568         * target/waitstatus.h: Fix common/ includes.
4569         * target/waitstatus.c: Fix common/ includes.
4570         * target.h: Fix common/ includes.
4571         * target.c: Fix common/ includes.
4572         * target-memory.c: Fix common/ includes.
4573         * target-descriptions.c: Fix common/ includes.
4574         * symtab.h: Fix common/ includes.
4575         * symfile.c: Fix common/ includes.
4576         * stap-probe.c: Fix common/ includes.
4577         * spu-linux-nat.c: Fix common/ includes.
4578         * sparc-nat.c: Fix common/ includes.
4579         * source.c: Fix common/ includes.
4580         * solib.c: Fix common/ includes.
4581         * solib-target.c: Fix common/ includes.
4582         * ser-unix.c: Fix common/ includes.
4583         * ser-tcp.c: Fix common/ includes.
4584         * ser-pipe.c: Fix common/ includes.
4585         * ser-base.c: Fix common/ includes.
4586         * selftest-arch.c: Fix common/ includes.
4587         * s12z-tdep.c: Fix common/ includes.
4588         * rust-exp.y: Fix common/ includes.
4589         * rs6000-aix-tdep.c: Fix common/ includes.
4590         * riscv-tdep.c: Fix common/ includes.
4591         * remote.c: Fix common/ includes.
4592         * remote-notif.h: Fix common/ includes.
4593         * remote-fileio.h: Fix common/ includes.
4594         * remote-fileio.c: Fix common/ includes.
4595         * regcache.h: Fix common/ includes.
4596         * regcache.c: Fix common/ includes.
4597         * record-btrace.c: Fix common/ includes.
4598         * python/python.c: Fix common/ includes.
4599         * python/py-type.c: Fix common/ includes.
4600         * python/py-inferior.c: Fix common/ includes.
4601         * progspace.h: Fix common/ includes.
4602         * producer.c: Fix common/ includes.
4603         * procfs.c: Fix common/ includes.
4604         * proc-api.c: Fix common/ includes.
4605         * printcmd.c: Fix common/ includes.
4606         * ppc-linux-nat.c: Fix common/ includes.
4607         * parser-defs.h: Fix common/ includes.
4608         * osdata.c: Fix common/ includes.
4609         * obsd-nat.c: Fix common/ includes.
4610         * nat/x86-linux.c: Fix common/ includes.
4611         * nat/x86-linux-dregs.c: Fix common/ includes.
4612         * nat/x86-dregs.h: Fix common/ includes.
4613         * nat/x86-dregs.c: Fix common/ includes.
4614         * nat/ppc-linux.c: Fix common/ includes.
4615         * nat/mips-linux-watch.h: Fix common/ includes.
4616         * nat/mips-linux-watch.c: Fix common/ includes.
4617         * nat/linux-waitpid.c: Fix common/ includes.
4618         * nat/linux-ptrace.h: Fix common/ includes.
4619         * nat/linux-ptrace.c: Fix common/ includes.
4620         * nat/linux-procfs.c: Fix common/ includes.
4621         * nat/linux-personality.c: Fix common/ includes.
4622         * nat/linux-osdata.c: Fix common/ includes.
4623         * nat/linux-namespaces.c: Fix common/ includes.
4624         * nat/linux-btrace.h: Fix common/ includes.
4625         * nat/linux-btrace.c: Fix common/ includes.
4626         * nat/fork-inferior.c: Fix common/ includes.
4627         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4628         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4629         * nat/aarch64-linux.c: Fix common/ includes.
4630         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4631         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4632         * namespace.h: Fix common/ includes.
4633         * mips-linux-tdep.c: Fix common/ includes.
4634         * minsyms.c: Fix common/ includes.
4635         * mi/mi-parse.h: Fix common/ includes.
4636         * mi/mi-main.c: Fix common/ includes.
4637         * mi/mi-cmd-env.c: Fix common/ includes.
4638         * memrange.h: Fix common/ includes.
4639         * memattr.c: Fix common/ includes.
4640         * maint.h: Fix common/ includes.
4641         * maint.c: Fix common/ includes.
4642         * main.c: Fix common/ includes.
4643         * machoread.c: Fix common/ includes.
4644         * location.c: Fix common/ includes.
4645         * linux-thread-db.c: Fix common/ includes.
4646         * linux-nat.c: Fix common/ includes.
4647         * linux-fork.c: Fix common/ includes.
4648         * inline-frame.c: Fix common/ includes.
4649         * infrun.c: Fix common/ includes.
4650         * inflow.c: Fix common/ includes.
4651         * inferior.h: Fix common/ includes.
4652         * inferior.c: Fix common/ includes.
4653         * infcmd.c: Fix common/ includes.
4654         * inf-ptrace.c: Fix common/ includes.
4655         * inf-child.c: Fix common/ includes.
4656         * ia64-linux-nat.c: Fix common/ includes.
4657         * i387-tdep.c: Fix common/ includes.
4658         * i386-tdep.c: Fix common/ includes.
4659         * i386-linux-tdep.c: Fix common/ includes.
4660         * i386-linux-nat.c: Fix common/ includes.
4661         * i386-go32-tdep.c: Fix common/ includes.
4662         * i386-fbsd-tdep.c: Fix common/ includes.
4663         * i386-fbsd-nat.c: Fix common/ includes.
4664         * guile/scm-type.c: Fix common/ includes.
4665         * guile/guile.c: Fix common/ includes.
4666         * go32-nat.c: Fix common/ includes.
4667         * gnu-nat.c: Fix common/ includes.
4668         * gdbthread.h: Fix common/ includes.
4669         * gdbarch-selftests.c: Fix common/ includes.
4670         * gdb_usleep.c: Fix common/ includes.
4671         * gdb_select.h: Fix common/ includes.
4672         * gdb_bfd.c: Fix common/ includes.
4673         * gcore.c: Fix common/ includes.
4674         * fork-child.c: Fix common/ includes.
4675         * findvar.c: Fix common/ includes.
4676         * fbsd-nat.c: Fix common/ includes.
4677         * event-top.c: Fix common/ includes.
4678         * event-loop.c: Fix common/ includes.
4679         * dwarf2read.c: Fix common/ includes.
4680         * dwarf2loc.c: Fix common/ includes.
4681         * dwarf2-frame.c: Fix common/ includes.
4682         * dwarf-index-cache.c: Fix common/ includes.
4683         * dtrace-probe.c: Fix common/ includes.
4684         * disasm-selftests.c: Fix common/ includes.
4685         * defs.h: Fix common/ includes.
4686         * csky-tdep.c: Fix common/ includes.
4687         * cp-valprint.c: Fix common/ includes.
4688         * cp-support.h: Fix common/ includes.
4689         * cp-support.c: Fix common/ includes.
4690         * corelow.c: Fix common/ includes.
4691         * completer.h: Fix common/ includes.
4692         * completer.c: Fix common/ includes.
4693         * compile/compile.c: Fix common/ includes.
4694         * compile/compile-loc2c.c: Fix common/ includes.
4695         * compile/compile-cplus-types.c: Fix common/ includes.
4696         * compile/compile-cplus-symbols.c: Fix common/ includes.
4697         * command.h: Fix common/ includes.
4698         * cli/cli-dump.c: Fix common/ includes.
4699         * cli/cli-cmds.c: Fix common/ includes.
4700         * charset.c: Fix common/ includes.
4701         * build-id.c: Fix common/ includes.
4702         * btrace.h: Fix common/ includes.
4703         * btrace.c: Fix common/ includes.
4704         * breakpoint.h: Fix common/ includes.
4705         * breakpoint.c: Fix common/ includes.
4706         * ax.h:
4707         (enum agent_op): Fix common/ includes.
4708         * ax-general.c (struct aop_map): Fix common/ includes.
4709         * ax-gdb.c: Fix common/ includes.
4710         * auxv.c: Fix common/ includes.
4711         * auto-load.c: Fix common/ includes.
4712         * arm-tdep.c: Fix common/ includes.
4713         * arch/riscv.c: Fix common/ includes.
4714         * arch/ppc-linux-common.c: Fix common/ includes.
4715         * arch/i386.c: Fix common/ includes.
4716         * arch/arm.c: Fix common/ includes.
4717         * arch/arm-linux.c: Fix common/ includes.
4718         * arch/arm-get-next-pcs.c: Fix common/ includes.
4719         * arch/amd64.c: Fix common/ includes.
4720         * arch/aarch64.c: Fix common/ includes.
4721         * arch/aarch64-insn.c: Fix common/ includes.
4722         * arch-utils.c: Fix common/ includes.
4723         * amd64-windows-tdep.c: Fix common/ includes.
4724         * amd64-tdep.c: Fix common/ includes.
4725         * amd64-sol2-tdep.c: Fix common/ includes.
4726         * amd64-obsd-tdep.c: Fix common/ includes.
4727         * amd64-nbsd-tdep.c: Fix common/ includes.
4728         * amd64-linux-tdep.c: Fix common/ includes.
4729         * amd64-linux-nat.c: Fix common/ includes.
4730         * amd64-fbsd-tdep.c: Fix common/ includes.
4731         * amd64-fbsd-nat.c: Fix common/ includes.
4732         * amd64-dicos-tdep.c: Fix common/ includes.
4733         * amd64-darwin-tdep.c: Fix common/ includes.
4734         * agent.c: Fix common/ includes.
4735         * ada-lang.h: Fix common/ includes.
4736         * ada-lang.c: Fix common/ includes.
4737         * aarch64-tdep.c: Fix common/ includes.
4738
4739 2019-01-25  Tom Tromey  <tom@tromey.com>
4740
4741         * common/create-version.sh: Use common/version.h.
4742
4743 2019-01-24  Pedro Alves  <palves@redhat.com>
4744
4745         * infrun.c (signal_stop, signal_print, signal_program)
4746         (signal_catch, signal_pass): Now arrays instead of pointers.
4747         (update_signals_program_target, do_target_resume)
4748         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4749         * linux-nat.c (linux_nat_target::pass_signals)
4750         (linux_nat_target::create_inferior, linux_nat_target::attach):
4751         Adjust.
4752         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4753         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4754         * procfs.c (procfs_target::pass_signals): Adjust.
4755         * record-full.c (record_full_target::resume): Adjust.
4756         * remote.c (remote_target::pass_signals)
4757         (remote_target::program_signals): Adjust.
4758         * target-debug.h (target_debug_print_signals): Now takes a
4759         gdb::array_view as parameter.  Adjust.
4760         * target.h (target_ops) <pass_signals, program_signals>: Replace
4761         pointer and length parameters with gdb::array_view.
4762         (target_pass_signals, target_program_signals): Likewise.
4763         * target-delegates.c: Regenerate.
4764
4765 2019-01-24  Pedro Alves  <palves@redhat.com>
4766
4767         * common/forward-scope-exit.h
4768         (forward_scope_exit::forward_scope_exit): Pass arguments to
4769         m_bind_function directly, instead of creating a std::bind and
4770         copying that.
4771
4772 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4773
4774         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4775         for static members.
4776         (pass_in_v_vfp_candidate): Likewise.
4777
4778 2019-01-23  Tom Tromey  <tom@tromey.com>
4779             Pedro Alves  <palves@redhat.com>
4780
4781         * regcache.c (class regcache_invalidator): Remove.
4782         (regcache::raw_write): Use make_scope_exit.
4783
4784 2019-01-23  Tom Tromey  <tom@tromey.com>
4785
4786         * ui-out.h (class ui_out_emit_type): Update comment.
4787
4788 2019-01-23  Tom Tromey  <tom@tromey.com>
4789
4790         * infrun.c (fetch_inferior_event): Update comment.
4791
4792 2019-01-23  Tom Tromey  <tom@tromey.com>
4793             Pedro Alves  <palves@redhat.com>
4794
4795         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4796         parameter.
4797         (fetch_inferior_event): Use SCOPE_EXIT.
4798
4799
4800 2019-01-23  Tom Tromey  <tom@tromey.com>
4801             Pedro Alves  <palves@redhat.com>
4802
4803         * infrun.c (disable_thread_events): Delete.
4804         (stop_all_threads): Use SCOPE_EXIT.
4805
4806 2019-01-23  Tom Tromey  <tom@tromey.com>
4807             Pedro Alves  <palves@redhat.com>
4808
4809         * symfile.c: Include forward-scope-exit.h.
4810         (clear_symtab_users_cleanup): Replace forward declaration with
4811         a FORWARD_SCOPE_EXIT.
4812         (syms_from_objfile_1): Use the forward_scope_exit and
4813         gdb::optional instead of cleanup_function.
4814         (reread_symbols): Use the forward_scope_exit instead of
4815         cleanup_function.
4816         (clear_symtab_users_cleanup): Remove function.
4817
4818 2019-01-23  Tom Tromey  <tom@tromey.com>
4819             Pedro Alves  <palves@redhat.com>
4820
4821         * linux-nat.c: Include scope-exit.h.
4822         (cleanup_target_stop): Remove.
4823         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4824         SCOPE_EXIT.
4825
4826 2019-01-23  Tom Tromey  <tom@tromey.com>
4827             Pedro Alves  <palves@redhat.com>
4828
4829         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4830         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4831
4832 2019-01-23  Tom Tromey  <tom@tromey.com>
4833             Andrew Burgess  <andrew.burgess@embecosm.com>
4834             Pedro Alves  <palves@redhat.com>
4835
4836         * infrun.c (fetch_inferior_event): Use scope_exit.
4837         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4838         * top.c (execute_command): Use scope_exit.
4839         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4840         * utils.c (do_bpstat_clear_actions_cleanup)
4841         (make_bpstat_clear_actions_cleanup): Remove.
4842
4843 2019-01-23  Tom Tromey  <tom@tromey.com>
4844             Pedro Alves  <palves@redhat.com>
4845
4846         * infrun.c: Include "common/scope-exit.h"
4847         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4848         (wait_for_inferior): Use SCOPE_EXIT.
4849         (fetch_inferior_event): Use scope_exit.
4850
4851 2019-01-23  Tom Tromey  <tom@tromey.com>
4852             Pedro Alves  <palves@redhat.com>
4853
4854         * breakpoint.c (create_breakpoint): Remove cleanup.
4855
4856 2019-01-23  Tom Tromey  <tom@tromey.com>
4857             Andrew Burgess  <andrew.burgess@embecosm.com>
4858             Pedro Alves  <palves@redhat.com>
4859
4860 2019-01-23  Pedro Alves  <palves@redhat.com>
4861
4862         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4863
4864 2019-01-23  Pedro Alves  <palves@redhat.com>
4865             Andrew Burgess  <andrew.burgess@embecosm.com>
4866
4867         * gdbthread.h: Include "common/forward-scope-exit.h".
4868         (scoped_finish_thread_state): Redefine custom class in terms of
4869         forward_scope_exit.
4870
4871 2019-01-23  Pedro Alves  <palves@redhat.com>
4872             Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * common/forward-scope-exit.h: New file.
4875
4876 2019-01-23  Pedro Alves  <palves@redhat.com>
4877             Andrew Burgess  <andrew.burgess@embecosm.com>
4878             Tom Tromey  <tom@tromey.com>
4879
4880         * common/scope-exit.h: New file.
4881
4882 2019-01-23  Pedro Alves  <palves@redhat.com>
4883
4884         * common/preprocessor.h (ESC): Rename to ...
4885         (ESC_PARENS): ... this.
4886         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4887         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4888
4889 2019-01-23  Tom Tromey  <tom@tromey.com>
4890
4891         * language.h (class scoped_switch_to_sym_language_if_auto):
4892         Initialize m_lang in both cases.
4893
4894 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4895
4896         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4897         with XCNEW.
4898
4899 2019-01-22  Tom Tromey  <tom@tromey.com>
4900
4901         * corelow.c: Do not include sys/file.h.
4902
4903 2019-01-22  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-wingeneral.h: Include gdb_curses.h.
4906
4907 2019-01-22  Tom Tromey  <tom@tromey.com>
4908
4909         * source-cache.h (class source_cache) <get_source_lines,
4910         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4911
4912 2019-01-22  Tom Tromey  <tom@tromey.com>
4913
4914         * remote-fileio.h (struct remote_target): Declare.
4915
4916 2019-01-22  Tom Tromey  <tom@tromey.com>
4917
4918         * python/py-arch.c: Do not include py-ref.h.
4919         * python/py-bpevent.c: Do not include py-ref.h.
4920         * python/py-cmd.c: Do not include py-ref.h.
4921         * python/py-continueevent.c: Do not include py-ref.h.
4922         * python/py-event.h: Do not include py-ref.h.
4923         * python/py-evtregistry.c: Do not include py-ref.h.
4924         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4925         * python/py-frame.c: Do not include py-ref.h.
4926         * python/py-framefilter.c: Do not include py-ref.h.
4927         * python/py-function.c: Do not include py-ref.h.
4928         * python/py-infevents.c: Do not include py-ref.h.
4929         * python/py-linetable.c: Do not include py-ref.h.
4930         * python/py-objfile.c: Do not include py-ref.h.
4931         * python/py-param.c: Do not include py-ref.h.
4932         * python/py-prettyprint.c: Do not include py-ref.h.
4933         * python/py-progspace.c: Do not include py-ref.h.
4934         * python/py-symbol.c: Do not include py-ref.h.
4935         * python/py-symtab.c: Do not include py-ref.h.
4936         * python/py-type.c: Do not include py-ref.h.
4937         * python/py-unwind.c: Do not include py-ref.h.
4938         * python/py-utils.c: Do not include py-ref.h.
4939         * python/py-value.c: Do not include py-ref.h.
4940         * python/py-varobj.c: Do not include py-ref.h.
4941         * python/py-xmethods.c: Do not include py-ref.h.
4942         * python/python.c: Do not include py-ref.h.
4943         * varobj.c: Do not include py-ref.h.
4944
4945 2019-01-22  Tom Tromey  <tom@tromey.com>
4946
4947         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4948         keyword for bcache.
4949
4950 2019-01-22  Tom Tromey  <tom@tromey.com>
4951
4952         * compile/compile-cplus-types.c: Remove a comment by #include.
4953
4954 2019-01-22  Tom Tromey  <tom@tromey.com>
4955
4956         * compile/gcc-c-plugin.h: Include compile-internal.h.
4957
4958 2019-01-22  Tom Tromey  <tom@tromey.com>
4959
4960         * stabsread.c (EXTERN): Do not define.
4961         (symnum, next_symbol_text_func, processing_gcc_compilation)
4962         (within_function, global_sym_chain, global_stabs)
4963         (previous_stab_code, this_object_header_files)
4964         (n_this_object_header_files)
4965         (n_allocated_this_object_header_files): Define.
4966         * stabsread.h (EXTERN): Never define.  Use "extern".
4967
4968 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4969
4970         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4971         history_value.
4972
4973 2019-01-21  Tom Tromey  <tom@tromey.com>
4974
4975         * ui-out.c: Fix includes.
4976         * tui/tui-source.c: Fix includes.
4977         * target.c: Fix includes.
4978         * remote.c: Fix includes.
4979         * regcache.c: Fix includes.
4980         * python/py-block.c: Fix includes.
4981         * printcmd.c: Fix includes.
4982         * or1k-tdep.c: Fix includes.
4983         * mi/mi-main.c: Fix includes.
4984         * m32r-tdep.c: Fix includes.
4985         * csky-tdep.c: Fix includes.
4986         * compile/compile-cplus-types.c: Fix includes.
4987         * cli/cli-interp.c: Fix includes.
4988
4989 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4990
4991         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4992         for padding.
4993
4994 2019-01-16  Tom Tromey  <tom@tromey.com>
4995
4996         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4997         earlier.
4998         (struct objfile) <msymbols_range>: Move from top level.
4999         <msymbols>: New method.
5000         (class objfile_msymbols): Remove.
5001         * symtab.c (default_collect_symbol_completion_matches_break_on):
5002         Update.
5003         * symmisc.c (dump_msymbols): Update.
5004         * stabsread.c (scan_file_globals): Update.
5005         * objc-lang.c (info_selectors_command, info_classes_command)
5006         (find_methods): Update.
5007         * minsyms.c (find_solib_trampoline_target): Update.
5008         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5009         * coffread.c (coff_symfile_read): Update.
5010         * ada-lang.c (ada_lookup_simple_minsym)
5011         (ada_collect_symbol_completion_matches): Update.
5012
5013 2019-01-16  Tom Tromey  <tom@tromey.com>
5014
5015         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5016         type.  Remove no-argument constructor.
5017         <iterator::operator++>: Simplify.
5018         <begin>: Update.
5019         <end>: Use minimal_symbol_count.
5020
5021 2019-01-16  Tom Tromey  <tom@tromey.com>
5022
5023         * objfiles.h (struct objfile) <psymtabs>: New method.
5024         (class objfile_psymtabs): Remove.
5025         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5026         typedef.
5027         <range>: New method.
5028         (require_partial_symbols): Change return type.
5029         * psymtab.c (require_partial_symbols)
5030         (psym_expand_symtabs_matching): Update.
5031         * mdebugread.c (parse_partial_symbols): Update.
5032         * dbxread.c (dbx_end_psymtab): Update.
5033
5034 2019-01-15  Tom Tromey  <tom@tromey.com>
5035
5036         * symtab.c (lookup_objfile_from_block)
5037         (lookup_symbol_in_objfile_symtabs)
5038         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5039         (find_line_symtab, info_sources_command)
5040         (default_collect_symbol_completion_matches_break_on)
5041         (make_source_files_completion_list): Update.
5042         * symmisc.c (print_objfile_statistics, dump_objfile)
5043         (maintenance_print_symbols, maintenance_info_symtabs)
5044         (maintenance_check_symtabs, maintenance_info_line_tables):
5045         Update.
5046         * source.c (select_source_symtab)
5047         (forget_cached_source_info_for_objfile): Update.
5048         * objfiles.h (class objfile_compunits): Remove.
5049         (struct objfile) <compunits_range>: New typedef.
5050         (compunits): New method.
5051         * objfiles.c (objfile_relocate1): Update.
5052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5053         * maint.c (count_symtabs_and_blocks): Update.
5054         * linespec.c (iterate_over_all_matching_symtabs): Update.
5055         * cp-support.c (add_symbol_overload_list_qualified): Update.
5056         * coffread.c (coff_symtab_read): Update.
5057         * ada-lang.c (add_nonlocal_symbols)
5058         (ada_collect_symbol_completion_matches)
5059         (ada_add_global_exceptions): Update.
5060
5061 2019-01-15  Tom Tromey  <tom@tromey.com>
5062
5063         * progspace.h (program_space) <objfiles_safe_range>: New
5064         typedef.
5065         <objfiles_safe>: New method.
5066         * objfiles.h (class all_objfiles_safe): Remove.
5067         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5068         * jit.c (jit_inferior_exit_hook): Update.
5069
5070 2019-01-17  Tom Tromey  <tom@tromey.com>
5071
5072         * progspace.h (program_space) <objfiles_range>: New typedef.
5073         <objfiles>: New method.
5074         <objfiles_head>: Rename from objfiles.
5075         (object_files): Update.
5076         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5077         * guile/scm-pretty-print.c
5078         (ppscm_find_pretty_printer_from_objfiles): Update.
5079         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5080         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5081         Update.
5082         * python/py-progspace.c (pspy_get_objfiles): Update.
5083         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5084         Update.
5085         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5086         (objfpy_lookup_objfile_by_build_id): Update.
5087         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5088         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5089         Update.
5090         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5091         (expand_symtab_containing_pc, lookup_objfile_from_block)
5092         (lookup_static_symbol, basic_lookup_transparent_type)
5093         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5094         (find_line_symtab, info_sources_command)
5095         (default_collect_symbol_completion_matches_break_on)
5096         (make_source_files_completion_list, find_main_name): Update.
5097         * symmisc.c (print_symbol_bcache_statistics)
5098         (print_objfile_statistics, maintenance_print_symbols)
5099         (maintenance_print_msymbols, maintenance_print_objfiles)
5100         (maintenance_info_symtabs, maintenance_check_symtabs)
5101         (maintenance_expand_symtabs, maintenance_info_line_tables):
5102         Update.
5103         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5104         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5105         (map_overlay_command, unmap_overlay_command)
5106         (simple_overlay_update, expand_symtabs_matching)
5107         (map_symbol_filenames): Update.
5108         * symfile-debug.c (set_debug_symfile): Update.
5109         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5110         Update.
5111         * source.c (select_source_symtab, forget_cached_source_info):
5112         Update.
5113         * solib.c (solib_read_symbols): Update.
5114         * solib-spu.c (append_ocl_sos): Update.
5115         * psymtab.c (maintenance_print_psymbols)
5116         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5117         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5118         * printcmd.c (info_symbol_command): Update.
5119         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5120         Update.
5121         * objfiles.h (class all_objfiles): Remove.
5122         * objfiles.c (have_partial_symbols, have_full_symbols)
5123         (have_minimal_symbols, qsort_cmp, update_section_map)
5124         (shared_objfile_contains_address_p)
5125         (default_iterate_over_objfiles_in_search_order): Update.
5126         * objc-lang.c (info_selectors_command, info_classes_command)
5127         (find_methods): Update.
5128         * minsyms.c (find_solib_trampoline_target): Update.
5129         * maint.c (maintenance_info_sections)
5130         (maintenance_translate_address, count_symtabs_and_blocks):
5131         Update.
5132         * main.c (captured_main_1): Update.
5133         * linux-thread-db.c (try_thread_db_load_from_pdir)
5134         (has_libpthread): Update.
5135         * linespec.c (iterate_over_all_matching_symtabs)
5136         (search_minsyms_for_name): Update.
5137         * jit.c (jit_find_objf_with_entry_addr): Update.
5138         * hppa-tdep.c (find_unwind_entry)
5139         (hppa_lookup_stub_minimal_symbol): Update.
5140         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5141         Update.
5142         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5143         (elf_gnu_ifunc_resolve_by_got): Update.
5144         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5145         * dwarf-index-write.c (save_gdb_index_command): Update.
5146         * cp-support.c (add_symbol_overload_list_qualified): Update.
5147         * breakpoint.c (create_overlay_event_breakpoint)
5148         (create_longjmp_master_breakpoint)
5149         (create_std_terminate_master_breakpoint)
5150         (create_exception_master_breakpoint): Update.
5151         * blockframe.c (find_pc_partial_function): Update.
5152         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5153         (ada_collect_symbol_completion_matches)
5154         (ada_add_global_exceptions): Update.
5155
5156 2019-01-17  Tom Tromey  <tom@tromey.com>
5157
5158         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5159         declare VEC.
5160         (solib_target_parse_libraries): Change return type.
5161         (library_list_start_segment, library_list_start_section)
5162         (library_list_end_library, library_list_start_library); Update.
5163         (solib_target_free_library_list): Remove.
5164         (solib_target_parse_libraries): Remove cleanup.  Change return
5165         type.
5166         (solib_target_current_sos): Update.
5167
5168 2019-01-17  Tom Tromey  <tromey@bapiya>
5169
5170         * valprint.c: Replace "the the" with "the".
5171         * symtab.c: Replace "the the" with "the".
5172         * solib.c: Replace "the the" with "the".
5173         * solib-dsbt.c: Replace "the the" with "the".
5174         * linespec.c: Replace "the the" with "the".
5175         * dwarf2loc.h: Replace "the the" with "the".
5176         * amd64-windows-tdep.c: Replace "the the" with "the".
5177         * aarch64-tdep.c: Replace "the the" with "the".
5178
5179 2019-01-16  Keith Seitz  <keiths@redhat.com>
5180
5181         PR gdb/23773
5182         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5183         <builder>: Rename to ..
5184         <m_builder>: ... this and make private.
5185         (dwarf2_cu::get_builder): New method.  Change all users of
5186         `builder' to use this method.
5187         (dwarf2_start_symtab): Move to ...
5188         (dwarf2_cu::start_symtab): ... here.  Update all callers
5189         (setup_type_unit_groups): Move to ...
5190         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5191         callers.
5192         (dwarf2_cu::reset_builder): New method.
5193         (process_full_compunit, process_full_type_unit): Use
5194         dwarf2_cu::reset_builder.
5195         (follow_die_offset): Record the ancestor CU if it is different
5196         from the followed DIE's CU.
5197         (follow_die_sig_1): Likewise.
5198
5199 2019-01-15  Tom Tromey  <tom@tromey.com>
5200
5201         * remote.c (class remote_state) <buf>: Now a char_vector.
5202         <buf_size>: Remove.
5203         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5204         parameter.
5205         (remote_target::getpkt_or_notif_sane_1)
5206         (remote_target::getpkt_sane)
5207         (remote_target::getpkt_or_notif_sane): Likewise.
5208         (class remote_target) <putpkt>: New overload.
5209         (remote_target::read_frame): Change type of "buf_p".  Remove
5210         sizeof_p parameter.
5211         (packet_ok): New overload.
5212         (packet_check_result): New overload.
5213         Update all uses.
5214
5215 2019-01-14  Tom Tromey  <tom@tromey.com>
5216
5217         * remote-notif.c (handle_notification, remote_notif_ack)
5218         (remote_notif_parse): Make "buf" const.
5219         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5220         const.
5221         (remote_notif_parse, remote_notif_ack, handle_notification):
5222         Likewise.
5223         * remote.c (remote_notif_stop_parse): Make "buf" const.
5224         (remote_target::remote_parse_stop_reply): Make "buf" const.
5225         (remote_notif_stop_ack): Make "buf" const.
5226
5227 2019-01-14  Tom Tromey  <tom@tromey.com>
5228
5229         * remote.c (remote_console_output): Make parameter const.
5230
5231 2019-01-14  Tom Tromey  <tom@tromey.com>
5232
5233         * target-debug.h (target_debug_print_signals): Constify.
5234         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5235         * procfs.c (procfs_target::pass_signals): Update.
5236         * linux-nat.c (linux_nat_target::pass_signals): Update.
5237         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5238         * target-delegates.c: Rebuild.
5239         * remote.c (remote_target::program_signals): Update.
5240         (remote_target::pass_signals): Update.
5241         * target.c (target_pass_signals): Constify argument.
5242         (target_program_signals): Likewise.
5243         * target.h (struct target_ops) <pass_signals, program_signals>:
5244         Constify argument.
5245         (target_pass_signals, target_program_signals): Constify argument.
5246
5247 2019-01-14  Tom Tromey  <tom@tromey.com>
5248
5249         PR tui/28819:
5250         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5251
5252 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5253
5254         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5255         field.
5256         * rs6000-tdep.c: Include reggroups.h.
5257         (IS_V_ALIAS_PSEUDOREG): Define.
5258         (rs6000_register_name): Return names for the "vX" aliases.
5259         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5260         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5261         aliases.  Call default_register_reggroup_p for all other
5262         pseudo-registers.
5263         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5264         New functions.
5265         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5266         Handle "vX" aliases.
5267         (v_alias_pseudo_register_collect): New function.
5268         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5269         (rs6000_gdbarch_init): Initialize "vX" aliases as
5270         pseudo-registers.  Restore registration of
5271         rs6000_pseudo_register_reggroup_p with
5272         set_tdesc_pseudo_register_reggroup_p.
5273
5274 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5275
5276         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5277         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5278         set_gdbarch_num_pseudo_regs.
5279
5280 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5281
5282         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5283         Remove arg prefixname, add do_set and do_show.
5284         Add member functions set_list and show_list.
5285         * cli/cli-style.c (class cli_style_option): Update accordingly.
5286         (style_set_list): Move to file scope.
5287         (style_show_list): Likewise.
5288         (set_style): Call help_list.
5289         (show_style): Call cmd_show_list.
5290         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5291         Update to use the new macro.
5292
5293 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5294
5295         * ada-lang.c (_initialize_ada_language): Expand the help text
5296         for the "catch exception" command.
5297
5298 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5299
5300         * symtab.c (matching_obj_sections): Initialize obj,
5301         declare it closer to its usage.
5302
5303 2019-01-10  Tom Tromey  <tom@tromey.com>
5304
5305         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5306         (basic_inf_threads_range): Remove.
5307         (inf_threads_range, inf_non_exited_threads_range)
5308         (safe_inf_threads_range): Use next_adapter.
5309
5310 2019-01-10  Keith Seitz  <keiths@redhat.com>
5311
5312         PR gdb/23712
5313         PR symtab/23010
5314         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5315         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5316
5317 2019-01-10  Keith Seitz  <keiths@redhat.com>
5318
5319         PR gdb/23712
5320         PR symtab/23010
5321         * dictionary.c (pending_to_vector): Remove.
5322         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5323         Remove _1 suffix, replacing functions of the same name.  Update
5324         all callers.
5325         (dict_create_hashed, dict_create_hashed_expandable)
5326         (dict_create_linear, dict_create_linear_expandable, dict_free)
5327         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5328         Make functions static.
5329
5330 2019-01-10  Keith Seitz  <keiths@redhat.com>
5331
5332         PR gdb/23712
5333         PR symtab/23010
5334         * dictionary.h (struct dictionary): Replace declaration with
5335         multidictionary.
5336         (dict_create_hashed, dict_create_hashed_expandable)
5337         (dict_create_linear, dict_create_linear_expandable)
5338         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5339         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5340         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5341         taking multidictionary argument.
5342         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5343         * block.h (struct block) <dict>: Change to multidictionary
5344         and rename `multidict'.
5345         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5346         symmisc.c: Update all dictionary references to multidictionary.
5347
5348 2019-01-10  Keith Seitz  <keiths@redhat.com>
5349
5350         PR gdb/23712
5351         PR symtab/23010
5352         * dictionary.c: Include unordered_map.
5353         (pending_to_vector): New function.
5354         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5355         Rewrite the non-"_1" functions to take vector instead
5356         of linked list.
5357         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5358         "new" _1 versions of the same name.
5359         (multidictionary): Define.
5360         (std::hash<enum language): New definition.
5361         (collate_pending_symbols_by_language, mdict_create_hashed)
5362         (mdict_create_hashed_expandable, mdict_create_linear)
5363         (mdict_create_linear_expandable, mdict_free)
5364         (find_language_dictionary, create_new_language_dictionary)
5365         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5366         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5367         (mdict_size, mdict_empty): New functions.
5368         * dictionary.h (mdict_iterator): Define.
5369
5370 2019-01-10  Pedro Alves  <palves@redhat.com>
5371
5372         * breakpoint.c (read_uploaded_action)
5373         (create_tracepoint_from_upload): Adjust to use
5374         gdb::unique_xmalloc_ptr.
5375         * ctf.c (ctf_write_uploaded_tp):
5376         (SET_ARRAY_FIELD): Use emplace_back.
5377         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5378         * tracefile-tfile.c (tfile_write_uploaded_tp):
5379         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5380         gdb::unique_xmalloc_ptr.
5381         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5382         at_string, cond_string, cmd_strings>: Replace char pointers
5383         with gdb::unique_xmalloc_ptr.
5384
5385 2019-01-10  Pedro Alves  <palves@redhat.com>
5386
5387         * solib-target.c (library_list_start_library): Don't xstrdup name.
5388
5389 2019-01-10  Pedro Alves  <palves@redhat.com>
5390
5391         * mdebugread.c (parse_partial_symbols): Use
5392         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5393
5394 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5395
5396         * linux-fork.c (scoped_switch_fork_info)
5397         <~scoped_switch_fork_info>: Fix incorrect variable name.
5398
5399 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * linux-fork.c (scoped_switch_fork_info)
5402         <scoped_switch_fork_info>: Make explicit.
5403         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5404
5405 2019-01-10  Tom Tromey  <tom@tromey.com>
5406
5407         * objfiles.h (objfile::reset_psymtabs): Update.
5408         * objfiles.c (objfile::objfile): Update.
5409         * psymtab.h (psymtab_storage::obstack): Update.
5410         (psymtab_storage::m_obstack): Use gdb::optional.
5411         (class psymtab_storage): Update comment.  Remove objfile
5412         parameter.
5413         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5414
5415 2019-01-10  Tom Tromey  <tom@tromey.com>
5416
5417         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5418         <free_psymtabs>: Now private.
5419         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5420         (allocate_psymtab): Use new method.
5421
5422 2019-01-10  Tom Tromey  <tom@tromey.com>
5423
5424         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5425         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5426         * mdebugread.c (parse_partial_symbols): Use
5427         allocate_dependencies.
5428         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5429         allocate_dependencies.
5430         (process_psymtab_comp_unit_reader)
5431         (build_type_psymtab_dependencies): Likewise.
5432         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5433
5434 2019-01-10  Tom Tromey  <tom@tromey.com>
5435
5436         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5437         PSYMBOL_SET_LANGUAGE.
5438         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5439
5440 2019-01-10  Tom Tromey  <tom@tromey.com>
5441
5442         * psymtab.h (psymtab_storage::obstack): New method.
5443         <m_obstack>: Rename from obstack; now private.
5444         * psymtab.c (psymtab_storage): Update.
5445         * dwarf2read.c (create_addrmap_from_index)
5446         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5447         Update.
5448
5449 2019-01-10  Tom Tromey  <tom@tromey.com>
5450
5451         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5452         * objfiles.h (objfile::reset_psymtabs): New method.
5453
5454 2019-01-10  Tom Tromey  <tom@tromey.com>
5455
5456         * symmisc.c (print_symbol_bcache_statistics): Update.
5457         (print_objfile_statistics): Update.
5458         * symfile.c (reread_symbols): Update.
5459         * psymtab.h (class psymtab_storage): New.
5460         * psymtab.c (psymtab_storage): New constructor.
5461         (~psymtab_storage): New destructor.
5462         (require_partial_symbols): Update.
5463         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5464         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5465         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5466         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5467         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5468         (start_psymtab_common, end_psymtab_common)
5469         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5470         (allocate_psymtab): Update.
5471         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5472         Update.
5473         (dump_psymtab_addrmap, maintenance_print_psymbols)
5474         (maintenance_check_psymtabs): Update.
5475         (class objfile_psymtabs): Move to objfiles.h.
5476         * psympriv.h (discard_psymtab): Now inline.
5477         (psymtab_discarder::psymtab_discarder): Update.
5478         (psymtab_discarder::~psymtab_discarder): Update.
5479         (ALL_OBJFILE_PSYMTABS): Rewrite.
5480         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5481         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5482         Remove fields.
5483         <partial_symtabs>: New field.
5484         (class objfile_psymtabs): Move from psymtab.h.  Update.
5485         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5486         psymbol_cache.
5487         (objfile::~objfile): Don't destroy psymbol_cache.
5488         * mdebugread.c (parse_partial_symbols): Update.
5489         * dwarf2read.c (create_addrmap_from_index)
5490         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5491         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5492         (add_partial_subprogram, dwarf2_ranges_read): Update.
5493         * dwarf-index-write.c (write_address_map)
5494         (write_one_signatured_type, recursively_write_psymbols)
5495         (class debug_names, class debug_names, write_psymtabs_to_index):
5496         Update.
5497
5498 2019-01-10  Tom Tromey  <tom@tromey.com>
5499
5500         * symtab.h (SYMBOL_SET_NAMES): Update.
5501         (symbol_set_names): Update.
5502         (MSYMBOL_SET_NAMES): Update.
5503         * symtab.c (symbol_set_names): Change argument to be an
5504         objfile_per_bfd_storage.
5505         * psymtab.c (add_psymbol_to_bcache): Update.
5506         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5507
5508 2019-01-10  Tom Tromey  <tom@tromey.com>
5509
5510         * symtab.c (create_demangled_names_hash): Change argument to be an
5511         objfile_per_bfd_storage.
5512         (symbol_set_names): Update.
5513
5514 2019-01-10  Tom Tromey  <tom@tromey.com>
5515
5516         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5517         init_psymbol_list.
5518         * psymtab.c (init_psymbol_list): Do nothing if already called.
5519         * psympriv.h (init_psymbol_list): Add comment.
5520         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5521         init_psymbol_list.
5522         * dbxread.c (dbx_symfile_read): Unconditionally call
5523         init_psymbol_list.
5524
5525 2019-01-10  Tom Tromey  <tom@tromey.com>
5526
5527         * xcoffread.c (scan_xcoff_symtab): Update.
5528         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5529         "where".
5530         * mdebugread.c (parse_partial_symbols)
5531         (handle_psymbol_enumerators): Update.
5532         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5533         * dbxread.c (read_dbx_symtab): Update.
5534         * psympriv.h (psymbol_placement): New enum.
5535         (add_psymbol_to_list): Update.
5536
5537 2019-01-10  Tom Tromey  <tom@tromey.com>
5538
5539         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5540         static_psymbols parameters.
5541         (scan_xcoff_symtab): Update.
5542         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5543         static_psymbols parameters.
5544         * psympriv.h (start_psymtab_common): Update.
5545         * mdebugread.c (parse_partial_symbols): Update.
5546         * dwarf2read.c (create_partial_symtab): Update.
5547         * dbxread.c (read_dbx_symtab): Update.
5548         (start_psymtab): Remove global_psymbols and static_psymbols
5549         parameters.
5550
5551 2019-01-10  Tom Tromey  <tom@tromey.com>
5552
5553         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5554         * psymtab.c (allocate_psymtab): Add comment.
5555         * psympriv.h (allocate_psymtab): Add comment.
5556         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5557         initializations.
5558         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5559
5560 2019-01-10  Tom Tromey  <tom@tromey.com>
5561
5562         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5563         Don't declare.
5564         * mipsread.c: Include mdebugread.h.
5565         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5566         Declare.
5567         * elfread.c: Include mdebugread.h.
5568
5569 2019-01-09  Tom Tromey  <tom@tromey.com>
5570
5571         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5572         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5573         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5574         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5575         (psym_lookup_symbol, psym_find_last_source_symtab)
5576         (psym_forget_cached_source_info, psym_print_stats)
5577         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5578         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5579         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5580         (psym_find_compunit_symtab_by_address)
5581         (maintenance_print_psymbols, maintenance_info_psymtabs)
5582         (maintenance_check_psymtabs): Use ranged for.
5583         * psymtab.h (class objfile_psymtabs): New.
5584         (require_partial_symbols): Return objfile_psymtabs.
5585         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5586
5587 2019-01-09  Tom Tromey  <tom@tromey.com>
5588
5589         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5590         (find_pc_mapped_section, list_overlays_command)
5591         (map_overlay_command, unmap_overlay_command)
5592         (simple_overlay_update): Use all_objfiles.
5593         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5594         * printcmd.c (info_symbol_command): Use all_objfiles.
5595         * objfiles.h (ALL_OBJSECTIONS): Remove.
5596         * maint.c (maintenance_translate_address): Use all_objfiles.
5597         * gcore.c (gcore_create_callback): Use all_objfiles.
5598         (objfile_find_memory_regions): Likewise.
5599
5600 2019-01-09  Tom Tromey  <tom@tromey.com>
5601
5602         * symtab.c (find_line_symtab, info_sources_command)
5603         (make_source_files_completion_list): Use objfile_compunits.
5604         * source.c (select_source_symtab): Use objfile_compunits.
5605         * objfiles.h (struct objfile): Update comment.
5606         (ALL_OBJFILES): Remove.
5607         (ALL_FILETABS): Remove.
5608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5609         objfile_compunits.
5610
5611 2019-01-09  Tom Tromey  <tom@tromey.com>
5612
5613         * symmisc.c (print_objfile_statistics, dump_objfile)
5614         (maintenance_print_symbols): Use compunit_filetabs.
5615         * source.c (forget_cached_source_info_for_objfile): Use
5616         compunit_filetabs.
5617         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5618         (ALL_FILETABS): Use compunit_filetabs.
5619         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5620         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5621
5622 2019-01-09  Tom Tromey  <tom@tromey.com>
5623
5624         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5625         (compunit_filetabs): New.
5626         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5627         compunit_filetabs.
5628         (info_sources_command, make_source_files_completion_list): Remove
5629         declaration.
5630         * symmisc.c (print_objfile_statistics, dump_objfile)
5631         (maintenance_print_symbols): Remove declaration.
5632         (maintenance_info_symtabs): Use compunit_filetabs.
5633         (maintenance_info_line_tables): Likewise.
5634         * source.c (select_source_symtab): Change local variable name.
5635         (forget_cached_source_info_for_objfile): Remove declaration.
5636         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5637         * objfiles.c (objfile_relocate1): Remove declaration.
5638         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5639         declaration.
5640         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5641         * coffread.c (coff_symtab_read): Remove declaration.
5642         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5643         compunit_filetabs.
5644
5645 2019-01-09  Tom Tromey  <tom@tromey.com>
5646
5647         * symtab.c (lookup_objfile_from_block)
5648         (find_pc_sect_compunit_symtab, search_symbols)
5649         (default_collect_symbol_completion_matches_break_on): Use
5650         objfile_compunits.
5651         * objfiles.h (ALL_COMPUNITS): Remove.
5652         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5653         * cp-support.c (add_symbol_overload_list_qualified): Use
5654         objfile_compunits.
5655         * ada-lang.c (ada_collect_symbol_completion_matches)
5656         (ada_add_global_exceptions): Use objfile_compunits.
5657
5658 2019-01-09  Tom Tromey  <tom@tromey.com>
5659
5660         * source.c (select_source_symtab)
5661         (forget_cached_source_info_for_objfile): Remove declaration.
5662         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5663         declaration.
5664         * maint.c (count_symtabs_and_blocks): Remove declaration.
5665         * cp-support.c (add_symbol_overload_list_qualified): Remove
5666         declaration.
5667         * coffread.c (coff_symtab_read): Remove declaration.
5668         * symtab.c (lookup_symbol_in_objfile_symtabs)
5669         (basic_lookup_transparent_type_1): Use objfile_compunits.
5670         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5671         (info_sources_command, search_symbols)
5672         (default_collect_symbol_completion_matches_break_on)
5673         (make_source_files_completion_list): Remove declaration.
5674         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5675         (ada_collect_symbol_completion_matches)
5676         (ada_add_global_exceptions): Remove declaration.
5677         * linespec.c (iterate_over_all_matching_symtabs): Use
5678         objfile_compunits.
5679         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5680         (class objfile_compunits): New.
5681         (ALL_COMPUNITS): Use objfile_compunits.
5682         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5683         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5684         objfile_compunits.
5685         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5686
5687 2019-01-09  Tom Tromey  <tom@tromey.com>
5688
5689         * symtab.c (search_symbols)
5690         (default_collect_symbol_completion_matches_break_on): Use
5691         objfile_msymbols.
5692         * ada-lang.c (ada_lookup_simple_minsym)
5693         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5694         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5695         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5696         objfile_msymbols.
5697         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5698         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5699         * objc-lang.c (find_methods): Use objfile_msymbols.
5700         (info_selectors_command, info_classes_command): Likewise.
5701         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5702         * objfiles.h (class objfile_msymbols): New.
5703         (ALL_OBJFILE_MSYMBOLS): Remove.
5704         (ALL_MSYMBOLS): Remove.
5705
5706 2019-01-09  Tom Tromey  <tom@tromey.com>
5707
5708         * common/next-iterator.h (next_adapter): Add Iterator template
5709         parameter.
5710         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5711         (class all_objfiles_safe): New.
5712         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5713         * objfiles.c (put_objfile_before): Update comment.
5714         (add_separate_debug_objfile): Likewise.
5715         (free_all_objfiles): Use all_objfiles_safe.
5716         (objfile_purge_solibs): Likewise.
5717
5718 2019-01-09  Tom Tromey  <tom@tromey.com>
5719
5720         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5721         (expand_symtab_containing_pc, lookup_static_symbol)
5722         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5723         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5724         all_objfiles.
5725         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5726         * breakpoint.c (create_overlay_event_breakpoint)
5727         (create_longjmp_master_breakpoint)
5728         (create_std_terminate_master_breakpoint)
5729         (create_exception_master_breakpoint): Use all_objfiles.
5730         * linux-thread-db.c (try_thread_db_load_from_pdir)
5731         (has_libpthread): Use all_objfiles.
5732         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5733         * linespec.c (iterate_over_all_matching_symtabs)
5734         (search_minsyms_for_name): Use all_objfiles.
5735         * maint.c (maintenance_info_sections): Use all_objfiles.
5736         * main.c (captured_main_1): Use all_objfiles.
5737         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5738         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5739         * guile/scm-pretty-print.c
5740         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5741         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5742         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5743         (maintenance_print_msymbols): Use all_objfiles.
5744         * source.c (select_source_symtab): Use all_objfiles.
5745         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5746         * symfile.c (remove_symbol_file_command)
5747         (expand_symtabs_matching, map_symbol_filenames): Use
5748         all_objfiles.
5749         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5750         all_objfiles.
5751         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5752         * objc-lang.c (find_methods): Use all_objfiles.
5753         * objfiles.c (have_partial_symbols, have_full_symbols)
5754         (have_minimal_symbols, qsort_cmp)
5755         (default_iterate_over_objfiles_in_search_order): Use
5756         all_objfiles.
5757         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5758         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5759         (maintenance_check_psymtabs): Use all_objfiles.
5760         (ALL_PSYMTABS): Remove.
5761         * compile/compile-object-run.c (do_module_cleanup): Use
5762         all_objfiles.
5763         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5764         * cp-support.c (add_symbol_overload_list_qualified): Use
5765         all_objfiles.
5766         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5767         Use all_objfiles.
5768         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5769         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5770         all_objfiles.
5771         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5772         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5773         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5774         Uses all_objfiles.
5775         * solib.c (solib_read_symbols): Use all_objfiles
5776
5777 2019-01-09  Tom Tromey  <tom@tromey.com>
5778
5779         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5780         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5781         all_objfiles.
5782         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5783         * symmisc.c (print_symbol_bcache_statistics)
5784         (print_objfile_statistics, maintenance_print_objfiles)
5785         (maintenance_info_symtabs, maintenance_check_symtabs)
5786         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5787         all_objfiles.
5788         * source.c (forget_cached_source_info): Use all_objfiles.
5789         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5790         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5791         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5792         * objfiles.c (update_section_map): Use all_objfiles.
5793         (shared_objfile_contains_address_p): Likewise.
5794         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5795         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5796
5797 2019-01-09  Tom Tromey  <tom@tromey.com>
5798
5799         * common/next-iterator.h: New file.
5800         * objfiles.h (class all_objfiles): New.
5801         (struct objfile_iterator): New.
5802
5803 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5804
5805         * NEWS: Move the description of the changed "frame", "select-frame",
5806          and "info frame" commands to the Changed commands section.
5807
5808 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5809
5810         * gdbtypes.c (check_stub_method_group): Remove handling of old
5811         mangling schemes.
5812         * linespec.c (find_methods): Likewise.
5813         * stabsread.c (read_member_functions): Likewise.
5814         * valops.c (search_struct_method): Likewise.
5815         (value_struct_elt_for_reference): Likewise.
5816         * NEWS: Mention this change.
5817
5818 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5821         print_source_lines.
5822         * source.c (print_source_lines_base): Update line number check.
5823         (print_source_lines): New function.
5824         (source_lines_range::source_lines_range): New function.
5825         * source.h (class source_lines_range): New class.
5826         (print_source_lines): New declaration.
5827
5828 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5829
5830         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5831
5832 2019-01-08  Tom Tromey  <tom@tromey.com>
5833             Simon Marchi  <simon.marchi@ericsson.com>
5834
5835         PR gdb/24060
5836         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5837         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5838         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5839         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5840         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5841         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5842
5843 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5844
5845         * source.c (select_source_symtab): Move header comment to
5846         declaration in source.h.
5847         (forget_cached_source_info_for_objfile): Likewise.
5848         (forget_cached_source_info): Likewise.
5849         (identify_source_line): Likewise.
5850         * source.h (identify_source_line): Move declaration from symtab.h
5851         and add comment from source.c
5852         (print_source_lines): Likewise.
5853         (forget_cached_source_info_for_objfile): Likewise.
5854         (forget_cached_source_info): Likewise.
5855         (select_source_symtab): Likewise.
5856         (enum print_source_lines_flag): Move definition from symtab.h.
5857         * symtab.h (identify_source_line): Move declaration to source.h.
5858         (print_source_lines): Likewise.
5859         (forget_cached_source_info_for_objfile): Likewise.
5860         (forget_cached_source_info): Likewise.
5861         (select_source_symtab): Likewise.
5862         (enum print_source_lines_flag): Move definition to source.h.
5863         * tui/tui-hooks.c: Add 'source.h' include.
5864
5865 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * source.c (print_source_lines_base): Handle requests to print
5868         reverse line number sequences, and guard against empty lines
5869         string.
5870
5871 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * source.c (print_source_lines_base): Fix skip of '\r' if next
5874         character is '\n'.
5875
5876 2019-01-06  Tom Tromey  <tom@tromey.com>
5877
5878         * c-exp.y (struct c_parse_state) <macro_original_text,
5879         expansion_obstack>: New member.
5880         (macro_original_text, expansion_obstack): Remove globals.
5881         (scan_macro_expansion, scanning_macro_expansion)
5882         (finished_macro_expansion): Update.
5883         (scan_macro_cleanup): Remove.
5884         (yylex, c_parse): Update.
5885
5886 2019-01-06  Tom Tromey  <tom@tromey.com>
5887
5888         * c-exp.y (struct c_parse_state) <strings>: New member.
5889         (operator_stoken): Update.
5890
5891 2019-01-06  Tom Tromey  <tom@tromey.com>
5892
5893         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5894         (union type_stack_elt) <typelist_val>: Now a pointer to
5895         std::vector.
5896         (type_stack_cleanup): Don't declare.
5897         (push_typelist): Update.
5898         * parse.c (pop_typelist): Return a std::vector.
5899         (push_typelist): Take a std::vector.
5900         (follow_types): Update.  Do not free args.
5901         (type_stack_cleanup): Remove.
5902         * c-exp.y (struct c_parse_state): New.
5903         (cpstate): New global.
5904         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5905         (nonempty_typelist): Update.
5906         (func_mod): Create a new vector.
5907         (c_parse): Create a c_parse_state.
5908         (check_parameter_typelist): Do not delete params.
5909         (function_method): Update.  Do not delete type_list.
5910
5911 2019-01-06  Tom Tromey  <tom@tromey.com>
5912
5913         PR gdb/28155:
5914         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5915         check_typedef.
5916         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5917         (print_return_value): Likewise.
5918
5919 2019-01-05  Tom Tromey  <tom@tromey.com>
5920
5921         * contrib/cleanup_check.py: Remove.
5922         * contrib/gcc-with-excheck: Remove.
5923         * contrib/exsummary.py: Remove.
5924         * contrib/excheck.py: Remove.
5925
5926 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5927
5928         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5929         NULL. Initialize tpprev to NULL instead of assigning it
5930         to NULL on the next statement.
5931         * windows-nat.c (windows_delete_thread): Remove check for
5932         main_thread_id before printing thread exit notifications.
5933         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5934         Remove thread ID check against main_thread_id.
5935         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5936         windows_delete_thread.
5937         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5938
5939 2019-01-04  Tom Tromey  <tom@tromey.com>
5940
5941         * compile/compile.c (_initialize_compile): Use upper case for
5942         metasyntactic variables.
5943         * symmisc.c (_initialize_symmisc): Use upper case for
5944         metasyntactic variables.
5945         * psymtab.c (_initialize_psymtab): Use upper case for
5946         metasyntactic variables.
5947         * demangle.c (demangle_command): Use upper case for metasyntactic
5948         variables.
5949         (_initialize_demangler): Likewise.
5950         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5951         variables.
5952
5953 2019-01-03  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5956
5957 2019-01-03  Tom Tromey  <tom@tromey.com>
5958
5959         * python/py-symtab.c (salpy_str): Update.
5960         (struct salpy_sal_object) <symtab>: Now a PyObject.
5961         (salpy_dealloc): Update.
5962         (del_objfile_sal): Use gdbpy_ref.
5963
5964 2019-01-03  Tom Tromey  <tom@tromey.com>
5965
5966         * python/py-type.c (convert_field): Use new_reference.  Return
5967         gdbpy_ref.
5968         (make_fielditem): Return gdbpy_ref.
5969         (typy_fields): Update.
5970         (typy_getitem): Update.
5971         (field_name): Return gdbpy_ref.  Use new_reference.
5972         (typy_iterator_iternext): Update.
5973
5974 2019-01-03  Tom Tromey  <tom@tromey.com>
5975
5976         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5977
5978 2019-01-03  Tom Tromey  <tom@tromey.com>
5979
5980         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5981         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5982         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5983         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5984         (pspy_set_type_printers): Likewise.
5985         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5986         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5987         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5988         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5989         (objfpy_set_type_printers): Likewise.
5990
5991 2019-01-03  Tom Tromey  <tom@tromey.com>
5992
5993         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5994         (gdbpy_print_stack): Use gdbpy_err_fetch.
5995         * python/python-internal.h (class gdbpy_err_fetch): New class.
5996         (class gdbpy_enter) <m_error_type, m_error_value,
5997         m_error_traceback>: Remove.
5998         <m_error>: New member.
5999         (gdbpy_exception_to_string): Don't declare.
6000         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6001         * python/py-value.c (convert_value_from_python): Use
6002         gdbpy_err_fetch.
6003         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6004         gdbpy_exception_to_string.
6005         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6006         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6007         gdbpy_err_fetch.
6008
6009 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * linux-nat.c (delete_lwp_cleanup): Delete.
6012         (struct lwp_deleter): New struct.
6013         (lwp_info_up): New typedef.
6014         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6015         lwp_info_up.
6016
6017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * linux-fork.c (class scoped_switch_fork_info): New class.
6020         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6021
6022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * valops.c (find_overload_match): Remove use of null_cleanup, and
6025         calls to do_cleanups.
6026
6027 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * compile/compile-cplus-types.c
6030         (compile_cplus_instance::decl_name): Handle changes to
6031         cp_func_name.
6032         * cp-support.c (cp_func_name): Update header comment, update
6033         return type.
6034         * cp-support.h (cp_func_name): Update return type in declaration.
6035         * valops.c (find_overload_match): Move temp_func local to top
6036         level of function and change its type.  Use temp_func to hold and
6037         delete temporary string obtained from cp_func_name.
6038
6039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6042         gdb::char_vector, remove cleanup, and update uses of `msg`.
6043
6044 2019-01-03  Jim Wilson  <jimw@sifive.com>
6045
6046         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6047
6048 2019-01-02  Tom Tromey  <tom@tromey.com>
6049
6050         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6051         (tdesc_parse_xml): Remove cleanups.
6052         * target-descriptions.h (make_cleanup_free_target_description):
6053         Don't declare.
6054         (target_desc_deleter): New struct.
6055         (target_desc_up): New typedef.
6056         * target-descriptions.c (target_desc_deleter::operator()): Rename
6057         from free_target_description.
6058         (make_cleanup_free_target_description): Remove.
6059
6060 2019-01-02  Tom Tromey  <tom@tromey.com>
6061
6062         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6063         constructor, destructor.
6064         (linespec_parser): Remove typedef.
6065         (~linespec_parser): Rename from linespec_parser_delete.
6066         (linespec_lex_to_end, linespec_complete_label)
6067         (linespec_complete): Update.
6068         (decode_line_full): Remove cleanups.
6069         (decode_line_1): Update.
6070
6071 2019-01-02  Tom Tromey  <tom@tromey.com>
6072
6073         * python/python-internal.h (inferior_to_inferior_object): Change
6074         return type.
6075         * python/py-exitedevent.c (create_exited_event_object): Update.
6076         * python/py-inferior.c (inferior_to_inferior_object): Return
6077         gdbpy_ref.
6078         (python_new_inferior, python_inferior_deleted)
6079         (thread_to_thread_object, delete_thread_object)
6080         (build_inferior_list, gdbpy_selected_inferior): Update.
6081         * python/py-infthread.c (create_thread_object): Update.  Also fail
6082         if inferior_to_inferior_object fails.
6083
6084 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6085
6086         * inferior.h (class inferior) <displaced_step_state>: New field.
6087         * infrun.h (struct displaced_step_state): Move here from
6088         infrun.c.  Initialize fields, add constructor.
6089         <inf>: Remove field.
6090         <reset>: New method.
6091         * infrun.c (struct displaced_step_inferior_state): Move to
6092         infrun.h.
6093         (displaced_step_inferior_states): Remove.
6094         (get_displaced_stepping_state): Adust.
6095         (displaced_step_in_progress_any_inferior): Adjust.
6096         (displaced_step_in_progress_thread): Adjust.
6097         (displaced_step_in_progress): Adjust.
6098         (add_displaced_stepping_state): Remove.
6099         (get_displaced_step_closure_by_addr): Adjust.
6100         (remove_displaced_stepping_state): Remove.
6101         (infrun_inferior_exit): Call displaced_step_state.reset.
6102         (use_displaced_stepping): Don't check for NULL.
6103         (displaced_step_prepare_throw): Call
6104         get_displaced_stepping_state.
6105         (displaced_step_fixup): Don't check for NULL.
6106         (prepare_for_detach): Don't check for NULL.
6107
6108 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6109
6110         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6111          in case of call that did not complete.
6112
6113 2019-01-02  Andrey Utkin  <autkin@undo.io>
6114
6115         * symfile.c (find_separate_debug_file): Fix search of debug files for
6116         remote debuggee.
6117
6118 2019-01-02  Tom Tromey  <tom@tromey.com>
6119
6120         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6121         indentation.
6122         * python/py-frame.c (frapy_older): Remove cast.
6123         (frapy_newer): Likewise.
6124         * python/py-breakpoint.c (local_setattro): Remove cast.
6125         * python/py-arch.c (archpy_name): Remove local variable.
6126         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6127
6128 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6129
6130         * unittests/basic_string_view/element_access/char/empty.cc:
6131         Fix year range in copyright header.
6132
6133 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6134
6135         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6136         Delete.
6137         <operator==>: Update with for removed field.
6138         <hash>: Likewise.
6139         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6140         <isa_features>: ...this.
6141         <abi_features>: New field.
6142         (riscv_isa_flen): Update comment.
6143         (riscv_abi_xlen): New declaration.
6144         (riscv_abi_flen): New declaration.
6145         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6146         isa_features.
6147         (riscv_abi_xlen): New function.
6148         (riscv_isa_flen): Update to get answer from isa_features.
6149         (riscv_abi_flen): New function.
6150         (riscv_has_fp_abi): Update to get answer from abi_features.
6151         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6152         xlen and flen.
6153         (riscv_call_info) <xlen, flen>: Update comment.
6154         (riscv_call_arg_struct): Remove invalid assertions
6155         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6156         is removed.
6157         (riscv_gdbarch_init): Gather isa features and abi features
6158         separately, ensure both match on the gdbarch when reusing an old
6159         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6160         a target with 64-bit float hardware.
6161
6162 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6163
6164         * source.c (search_command_helper): Stop reverse search
6165         when line 1 has been searched.
6166
6167 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168
6169         * record-full.c (record_full_base_target::close): Rewrite
6170         record_full_core_buf_list free logic.
6171
6172 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6173
6174         * break-catch-syscall.c (print_one_catch_syscall): xfree
6175         the last text.
6176
6177 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6178
6179         * top.c (print_gdb_version): Update Copyright year in version
6180         message.
6181
6182 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6183
6184         Update copyright year range in all GDB files.
6185
6186 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6187
6188         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6189
6190 For older changes see ChangeLog-2018.
6191 \f
6192 Local Variables:
6193 mode: change-log
6194 left-margin: 8
6195 fill-column: 74
6196 version-control: never
6197 coding: utf-8
6198 End:
6199