gdb/ChangeLog

   1 2019-06-06  Tom Tromey  <tromey@adacore.com>
   2
   3         * maint.h (class scoped_command_stats): Use
   4         DISABLE_COPY_AND_ASSIGN.
   5         <print_time>: New method.
   6         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
   7         print_time.
   8         (scoped_command_stats::print_time): New method.
   9
  10 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
  13         instructions of lengths 6 or 8 bytes.
  14
  15 2019-06-04  Pedro Alves  <palves@redhat.com>
  16
  17         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
  18
  19         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
  20         * breakpoint.c (condition_completer): Likewise.
  21         * cli/cli-dump.c (scan_expression): Likewise.
  22         * common/filestuff.c (mkdir_recursive): Likewise.
  23         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
  24         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
  25         (gdb_abspath): Likewise.
  26         * compile/compile-cplus-types.c
  27         (compile_cplus_instance::decl_name): Likewise.
  28         * completer.c (complete_explicit_location):
  29         (signal_completer, reg_or_group_completer_1): Likewise.
  30         * cp-support.c (cp_remove_params_if_any): Likewise.
  31         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
  32         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
  33         * infcmd.c (strip_bg_char): Likewise.
  34         * linespec.c (copy_token_string): Likewise.
  35         * mi/mi-main.c (output_cores): Likewise.
  36         * psymtab.c (psymtab_search_name):
  37         * symfile.c (test_set_ext_lang_command): Likewise.
  38         * target.c (target_fileio_read_stralloc): Likewise.
  39         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
  40         * value.c (complete_internalvar): Likewise.
  41
  42 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
  43
  44         Add objfile property to gdb.Type.
  45         * NEWS: Mention Python API addition.
  46         * python/py-type.c (typy_get_objfile): New method.
  47
  48 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  49
  50         * NEWS: Mention the new set|show style [title|highlight].
  51         Mention changes to "show style", "help" and "apropos".
  52
  53 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  54
  55         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
  56         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
  57         instead of print_help_for_command.
  58         (print_doc_of_command): New function.
  59         (help_list): Add 'apropos -v word' suggestion.
  60         (print_help_for_command): Style the command name using title style.
  61         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
  62         (_initialize_cli_cmds): Describe -v in apropos_command help.
  63
  64 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  65
  66         * cli/cli-style.h (cli_style_option): Add name in constructor,
  67         add m_name class member, add constructor with intensity,
  68         add name class function.
  69         (cli_style_option::add_setshow_commands): Remove name argument.
  70         (highlight_style, title_style): New styles.
  71         * cli/cli-style.c (do_show): New function that shows a style
  72         characteristic styling the style name with itself.
  73         (set_style_name): New function.
  74         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
  75         Update all callers according to the changes in cli/cli-style.h.
  76         * utils.h (fputs_highlighted): New function.
  77         * utils.c (fputs_highlighted): Likewise.
  78
  79 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  80
  81         * NEWS: Mention new pipe command and new convenience variables.
  82
  83 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  84
  85         * cli/cli-cmds.c (pipe_command): New function.
  86         (_initialize_cli_cmds): Call add_com for pipe_command.
  87         Define | as an alias for pipe.
  88         (exit_status_set_internal_vars): New function.
  89         (shell_escape): Call exit_status_set_internal_vars.
  90         cli/cli-decode.c (find_command_name_length): Recognize | as
  91         a single character command.
  92
  93 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  94
  95         * gdbcmd.h (execute_command_to_ui_file): New declaration.
  96         top.c (execute_command_to_ui_file): New function, mostly a copy
  97         of execute_command_to_string.
  98         (execute_command_to_string): Implement by calling
  99         execute_command_to_ui_file.
 100
 101 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 102
 103         * top.h (saved_command_line): Remove declaration.
 104         * top.c (previous_saved_command_line, previous_repeat_arguments):
 105         New variables.
 106         (saved_command_line): Make static, define together with other
 107         'repeat variables'.
 108         (dont_repeat): Clear repeat_arguments.
 109         (repeat_previous, get_saved_command_line, save_command_line):
 110         New functions.
 111         (gdb_init): Initialize saved_command_line
 112         and previous_saved_command_line.
 113         * main.c (captured_main_1): Remove saved_command_line initialization.
 114         * event-top.c (handle_line_of_input): Update to use
 115         the new 'repeat' related functions instead of direct access to
 116         saved_command_line.
 117         * command.h (repeat_previous, get_saved_command_line,
 118         save_command_line): New declarations.
 119         (dont_repeat): Add comment.
 120
 121 2019-05-30  Tom Tromey  <tromey@adacore.com>
 122
 123         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 124         Fix comment.
 125         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 126
 127 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 128
 129         PR cli/24587
 130         * completer.c (complete): Initialize variable word.
 131
 132 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 133
 134         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 135         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 136         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 137         'body' is NULL to the outter 'if', protecting the '!is_define'
 138         situation as well.
 139
 140 2019-05-29  Tom Tromey  <tromey@adacore.com>
 141
 142         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 143         (dwarf_unknown): New function.
 144         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 145         (dwarf_type_encoding_name): Use dwarf_unknown.
 146
 147 2019-05-29  Tom Tromey  <tromey@adacore.com>
 148
 149         PR c++/20020:
 150         * cp-valprint.c (cp_print_value_fields): Call
 151         cp_print_static_field inside "try".
 152
 153 2019-05-29  Tom Tromey  <tromey@adacore.com>
 154
 155         * inflow.c (struct terminal_info): Add default operator=.
 156         * configure: Rebuild.
 157         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 158         -Wdeprecated-copy-dtor, -Wredundant-move.
 159
 160 2019-05-29  Tom Tromey  <tromey@adacore.com>
 161
 162         * NEWS: Add entry.
 163         * infcmd.c (print_return_value_1): Handle finish_print
 164         option.
 165         (show_print_finish): New function.
 166         (_initialize_infcmd): Add "set/show print finish" commands.
 167         * valprint.c (user_print_options): Initialize new member.
 168         * valprint.h (struct value_print_options) <finish_print>: New
 169         member.
 170
 171 2019-05-28  Tom Tromey  <tromey@adacore.com>
 172
 173         * ada-lang.c (ada_remove_Xbn_suffix)
 174         (find_old_style_renaming_symbol)
 175         (parse_old_style_renaming): Remove.
 176         (ada_find_renaming_symbol): Don't call
 177         find_old_style_renaming_symbol.
 178         (ada_is_renaming_symbol): Rename from
 179         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 180         bool.  Now static.
 181         (ada_read_var_value): Update and simplify.
 182         * ada-exp.y (write_var_or_type): Remove old code.
 183
 184 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * event-top.c: Remove include comment.
 187         * inflow.c (class scoped_ignore_sigttou): Move from here...
 188         * inflow.h (class scoped_ignore_sigttou): ...to here.
 189         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 190         * top.c:  Remove include comment.
 191
 192 2019-05-27  Tom Tromey  <tom@tromey.com>
 193
 194         * NEWS: Fix typo.
 195
 196 2019-05-22  Tom Tromey  <tromey@adacore.com>
 197
 198         * target.c (target_follow_exec): Constify parameter.
 199         * target-delegates.c: Rebuild.
 200         * remote.c (remote_target::follow_exec): Constify parameter.
 201         * infrun.c (follow_exec): Constify parameter.
 202         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 203         (target_follow_exec): Likewise.
 204
 205 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 206
 207         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 208         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 209
 210 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 211
 212         * NEWS: Add debugredirect and testsuite sections.
 213
 214 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 215
 216         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 217         target descriptions using exclusively floating point register name
 218         aliases.
 219
 220 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         PR gdb/18644:
 223         * f-lang.c (build_fortran_types): Handle the case where
 224         gdbarch_floatformat_for_type returns a nullptr.
 225
 226 2019-05-21  Tom de Vries  <tdevries@suse.de>
 227
 228         PR cli/24587
 229         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 230
 231 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 232
 233         PR gdb/18644:
 234         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 235         16-byte floats.
 236         * i386-tdep.c (i386_floatformat_for_type): Use
 237         floatformats_ia64_quad for the 16-byte floating point component
 238         within a fortran 32-byte complex number.
 239
 240 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 241
 242         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 243         delete default constructor.
 244         (find_partial_die): Update to return const struct.
 245         (partial_die_parent_scope): Move variable declaration into scope
 246         of its use and change its type to auto.
 247         (guess_partial_die_structure_name): Likewise.
 248         (partial_die_info::fixup): Likewise.
 249
 250 2019-05-17  Tom Tromey  <tromey@adacore.com>
 251
 252         * source.c (find_and_open_source): Remove cast.
 253
 254 2019-05-17  Tom Tromey  <tromey@adacore.com>
 255
 256         * annotate.c (annotate_source): Make "filename" const.
 257         * annotate.h (annotate_source): Use const.
 258
 259 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * disasm.c (set_disassembler_options): Send errors to stderr.
 262
 263 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 266         (cli_interp_base::set_logging): Check debug_redirect.
 267         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 268         * cli/cli-logging.c (debug_redirect): Add static variable.
 269         (pop_output_files): Add default param.
 270         (handle_redirections): Print debug setting.
 271         (show_logging_command): Likewise.
 272         (_initialize_cli_logging): Add debugredirect command.
 273         * interps.c (current_interp_set_logging): Add debug_redirect
 274         parameter.
 275         * interps.h (set_logging): Add debug_redirect parameter.
 276         (current_interp_set_logging): Likewise.
 277         * mi/mi-common.h: Likewise.
 278         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 279
 280 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 281             Tom Tromey  <tromey@adacore.com>
 282
 283         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 284         directly.
 285         * cli/cli-interp.h (make_logging_output): Remove declaration.
 286         * cli/cli-logging.c (make_logging_output): Remove function.
 287         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 288         directly.
 289         * ui-file.c (tee_file::tee_file): Remove bools.
 290         (tee_file::~tee_file): Remove deletes.
 291         * ui-file.h (tee_file): Remove bools.
 292
 293 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 294
 295         * mi/mi-cmds.h (mi_cmd_complete): New function.
 296         * mi/mi-main.c (mi_cmd_complete): Likewise.
 297         * mi/mi-cmds.c: Define new MI command -complete.
 298         * NEWS: Mention new -complete command.
 299
 300 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 301
 302         * completer.h (complete): New function.
 303         * completer.c (complete): Likewise.
 304         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 305         function defined in completer.h.
 306
 307 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 308
 309        * MAINTAINERS (Write After Approval): Add myself.
 310
 311 2019-05-17  Tom de Vries  <tdevries@suse.de>
 312
 313         PR gdb/24094
 314         * dwarf2read.c (struct cu_partial_die_info): New struct.
 315         (find_partial_die): Return cu_partial_die_info.
 316         (partial_die_parent_scope, guess_partial_die_structure_name)
 317         (partial_die_info::fixup): Handle new return type of find_partial_die.
 318
 319 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 320
 321         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 322         "std::string", simplifying the algorithm.
 323
 324 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 325
 326         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 327         (stap_static_probe_ops::get_probes): Likewise.
 328
 329 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 330
 331         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 332         '-')" and "else if".
 333         (stap_parse_single_operand): Join checks for
 334         "gdbarch_stap_parse_special_token_p" and
 335         "gdbarch_stap_parse_special_token" in the same "if" statement.
 336         Invert check when verifying for operation on register
 337         displacement.
 338
 339 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 340
 341         * stap-probe.c (stap_get_opcode): Update comment.
 342         (stap_get_expected_argument_type): Likewise.
 343         (handle_stap_probe): Likewise.
 344
 345 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 346
 347         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 348         return type to 'bool'.  Adjust comment.  Use 'bool' when
 349         appropriate.
 350         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 351         * stap-probe.c (stap_parse_argument_1): Likewise.
 352         (stap_is_operator): Likewise.
 353         (stap_is_generic_prefix): Likewise.
 354         (stap_is_register_prefix): Likewise.
 355         (stap_is_register_indirection_prefix): Likewise.
 356         (stap_is_integer_prefix): Likewise.
 357         (stap_generic_check_suffix): Likewise.
 358         (stap_check_integer_suffix): Likewise.
 359         (stap_check_register_suffix): Likewise.
 360         (stap_check_register_indirection_suffix): Likewise.
 361         (stap_parse_register_operand): Likewise.
 362         (stap_parse_single_operand): Likewise.
 363         (stap_parse_argument_1): Likewise.
 364         (stap_probe::get_argument_count): Likewise.
 365         (stap_is_operator): Likewise.
 366
 367 2019-05-16  Tom Tromey  <tromey@adacore.com>
 368
 369         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 370         keyword to foreach.
 371
 372 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 373
 374         * linux-thread-db.c (try_thread_db_load_1): Change return type
 375         to bool.
 376         (try_thread_db_load): Likewise.
 377         (try_thread_db_load_from_pdir_1): Likewise.
 378         (try_thread_db_load_from_pdir): Likewise.
 379         (try_thread_db_load_from_sdir): Likewise.
 380         (try_thread_db_load_from_dir): Likewise.
 381         (thread_db_load_search): Likewise.
 382         (has_libpthread): Likewise.
 383         (thread_db_load): Likewise.
 384
 385 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 386
 387         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 388         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 389         NULL, and complain/return if that's the case.
 390
 391 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 392
 393         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 394         (advance, posn, abstract_read_memory): New functions.
 395         [struct mem_read_abstraction]: New struct.
 396         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 397
 398 2019-05-14  Tom Tromey  <tromey@adacore.com>
 399
 400         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 401         value is not lval_memory.
 402
 403 2019-05-14  Tom Tromey  <tromey@adacore.com>
 404
 405         * solib.c (info_sharedlibrary_command): Style the file name.
 406
 407 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 408
 409         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 410         (aarch64_vnv_type): Likewise.
 411         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 412         * common/tdesc.c: Likewise.
 413         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 414         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 415         * features/aarch64-fpu.xml: Add ieee half view.
 416         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 417         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 418         * gdbtypes.h (struct builtin_type): Likewise.
 419         (struct objfile_type): Likewise.
 420
 421 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 422
 423         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 424         typo.
 425         * location.h (string_to_event_location): Likewise.
 426
 427 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 428
 429         GDB 8.3 released.
 430
 431 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 432
 433         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 434         New variable declaration.
 435         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 436         New variable.
 437         (print_one_breakpoint): Use ui_out::test_flags and new global
 438         variable to compute use_fixed_output.
 439         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 440         Remove.
 441         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 442         (mi_multi_location_breakpoint_output_fixed): Remove.
 443         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 444         new variable.
 445         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 446         fix_multi_location_breakpoint_output flag if version >= 3.
 447         * ui-out.h (enum ui_out_flag)
 448         <fix_multi_location_breakpoint_output>: New enumerator.
 449
 450 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 451
 452         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 453
 454 2019-05-10  Tom Tromey  <tromey@adacore.com>
 455
 456         * ada-lang.c (catch_ada_completer): New function.
 457         (_initialize_ada_language): Use it.
 458
 459 2019-05-10  Tom Tromey  <tromey@adacore.com>
 460
 461         * thread.c (print_thread_info): Make "requested_threads" const.
 462         * gdbthread.h (print_thread_info): Make "requested_threads"
 463         const.
 464         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 465         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 466
 467 2019-05-08  Tom Tromey  <tom@tromey.com>
 468
 469         * gdbtypes.c (objfile_type_data): Change type.
 470         (objfile_type, _initialize_gdbtypes): Update.
 471
 472 2019-05-08  Tom Tromey  <tom@tromey.com>
 473
 474         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 475         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 476         (_initialize_dwarf2_frame): Update.
 477
 478 2019-05-08  Tom Tromey  <tom@tromey.com>
 479
 480         * objc-lang.c (objc_objfile_data): Change type.
 481         (find_methods): Update.
 482         (_initialize_objc_lang): Remove.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * stabsread.c (rs6000_builtin_type_data): Change type.
 487         (rs6000_builtin_type, _initialize_stabsread): Update.
 488
 489 2019-05-08  Tom Tromey  <tom@tromey.com>
 490
 491         * mips-tdep.c (mips_pdr_data): Remove.
 492         (_initialize_mips_tdep): Update.
 493
 494 2019-05-08  Tom Tromey  <tom@tromey.com>
 495
 496         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 497         (hppa_init_objfile_priv_data, read_unwind_info)
 498         (find_unwind_entry, _initialize_hppa_tdep): Update.
 499
 500 2019-05-08  Tom Tromey  <tom@tromey.com>
 501
 502         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 503         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 504         on obstack.
 505         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 506
 507 2019-05-08  Tom Tromey  <tom@tromey.com>
 508
 509         * mdebugread.c (basic_type_data): Change type.
 510         (basic_type, _initialize_mdebugread): Update.
 511
 512 2019-05-08  Tom Tromey  <tom@tromey.com>
 513
 514         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 515
 516 2019-05-08  Tom Tromey  <tom@tromey.com>
 517
 518         * nto-tdep.c (nto_inferior_data_reg): Change type.
 519         (nto_inferior_data): Update.
 520         (nto_inferior_data_cleanup, nto_new_inferior_data)
 521         (_initialize_nto_tdep): Remove.
 522         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 523
 524 2019-05-08  Tom Tromey  <tom@tromey.com>
 525
 526         * ada-lang.c (struct ada_inferior_data): Add initializers.
 527         (ada_inferior_data): Change type.
 528         (ada_inferior_data_cleanup): Remove.
 529         (get_ada_inferior_data, ada_inferior_exit)
 530         (struct ada_pspace_data): Add initializers, destructor.
 531         (ada_pspace_data_handle): Change type.
 532         (get_ada_pspace_data): Update.
 533         (ada_pspace_data_cleanup): Remove.
 534
 535 2019-05-08  Tom Tromey  <tom@tromey.com>
 536
 537         * coffread.c (struct coff_symfile_info): Add initializers.
 538         (coff_objfile_data_key): Move lower.  Change type.
 539         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 540         Update.
 541         (coff_free_info): Remove.
 542
 543 2019-05-08  Tom Tromey  <tom@tromey.com>
 544
 545         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 546         (fbsd_pspace_data_handle): Move lower.  Change type.
 547         (get_fbsd_pspace_data): Update.
 548         (fbsd_pspace_data_cleanup): Remove.
 549         (_initialize_fbsd_tdep): Update.
 550
 551 2019-05-08  Tom Tromey  <tom@tromey.com>
 552
 553         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 554         (get_ada_tasks_pspace_data): Update.
 555         (ada_tasks_pspace_data_cleanup): Remove.
 556         (_initialize_tasks): Update.
 557         (ada_tasks_inferior_data_handle): Change type.
 558         (get_ada_tasks_inferior_data): Update.
 559         (ada_tasks_inferior_data_cleanup): Remove.
 560         (struct ada_tasks_pspace_data): Add initializers.
 561
 562 2019-05-08  Tom Tromey  <tom@tromey.com>
 563
 564         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 565         * symfile-debug.c (debug_sym_get_probes): Change type.
 566         * stap-probe.c (handle_stap_probe):
 567         (stap_static_probe_ops::get_probes): Change type.
 568         * probe.h (class static_probe_ops) <get_probes>: Change type.
 569         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 570         (parse_probes_in_pspace): Update.
 571         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 572         Update.
 573         (any_static_probe_ops::get_probes): Change type.
 574         * elfread.c (elfread_data): New typedef.
 575         (probe_key): Change type.
 576         (elf_get_probes): Likewise.  Update.
 577         (probe_key_free): Remove.
 578         (_initialize_elfread): Update.
 579         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 580         Change type.
 581         (dtrace_process_dof_probe, dtrace_process_dof)
 582         (dtrace_static_probe_ops::get_probe): Change type.
 583
 584 2019-05-08  Tom Tromey  <tom@tromey.com>
 585
 586         * xcoffread.c (struct xcoff_symfile_info): Rename from
 587         coff_symfile_info.  Add initializers.
 588         (xcoff_objfile_data_key): Move lower.  Change type.
 589         (XCOFF_DATA): Rewrite.
 590         (xcoff_free_info): Remove.
 591         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 592         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 593         (xcoff_initial_scan): Update.
 594
 595 2019-05-08  Tom Tromey  <tom@tromey.com>
 596
 597         * solib-svr4.c (struct svr4_info): Add initializers and
 598         destructor.
 599         <probes_table>: Now an htab_up.
 600         (solib_svr4_pspace_data): Change type.
 601         (free_probes_table): Simplify.
 602         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 603         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 604         (probes_table_remove_objfile_probes, register_solib_event_probe)
 605         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 606         (_initialize_svr4_solib): Update.
 607
 608 2019-05-08  Tom Tromey  <tom@tromey.com>
 609
 610         * remote.c (remote_pspace_data): Change type.
 611         (remote_pspace_data_cleanup): Remove.
 612         (get_remote_exec_file, set_pspace_remote_exec_file)
 613         (_initialize_remote): Update.
 614
 615 2019-05-08  Tom Tromey  <tom@tromey.com>
 616
 617         * breakpoint.c (breakpoint_objfile_key): Change type.
 618         (get_breakpoint_objfile_data): Update.
 619         (free_breakpoint_objfile_data): Remove.
 620         (_initialize_breakpoint): Update.
 621
 622 2019-05-08  Tom Tromey  <tom@tromey.com>
 623
 624         * linux-tdep.c (struct linux_info): Add initializers.
 625         (linux_inferior_data): Move.  Change type.
 626         (invalidate_linux_cache_inf): Update.
 627         (linux_inferior_data_cleanup): Remove.
 628         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 629
 630 2019-05-08  Tom Tromey  <tom@tromey.com>
 631
 632         * auxv.c (auxv_inferior_data): Move.  Change type.
 633         (auxv_inferior_data_cleanup): Remove.
 634         (invalidate_auxv_cache_inf): Rewrite.
 635         (get_auxv_inferior_data, _initialize_auxv): Update.
 636
 637 2019-05-08  Tom Tromey  <tom@tromey.com>
 638
 639         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 640         (symfile_debug_objfile_data_key): Change type.
 641         (symfile_debug_installed, debug_qf_has_symbols)
 642         (debug_qf_find_last_source_symtab)
 643         (debug_qf_forget_cached_source_info)
 644         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 645         (debug_qf_print_stats, debug_qf_dump)
 646         (debug_qf_expand_symtabs_for_function)
 647         (debug_qf_expand_all_symtabs)
 648         (debug_qf_expand_symtabs_with_fullname)
 649         (debug_qf_map_matching_symbols)
 650         (debug_qf_expand_symtabs_matching)
 651         (debug_qf_find_pc_sect_compunit_symtab)
 652         (debug_qf_map_symbol_filenames)
 653         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 654         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 655         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 656         (debug_sym_read_linetable, debug_sym_relocate): Update.
 657         (symfile_debug_free_objfile): Remove.
 658         (install_symfile_debug_logging, _initialize_symfile_debug):
 659         Update.
 660
 661 2019-05-08  Tom Tromey  <tom@tromey.com>
 662
 663         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 664         allocate_on_obstack.
 665         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 666         (get_dwarf2_per_objfile): Update.
 667         (set_dwarf2_per_objfile): Remove.
 668         (dwarf2_has_info, dwarf2_get_section_info): Update.
 669         (dwarf2_free_objfile): Remove.
 670         (_initialize_dwarf2_read): Update.
 671
 672 2019-05-08  Tom Tromey  <tom@tromey.com>
 673
 674         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 675         initializers.
 676         <unsupported_script_warning_printed,
 677         script_not_found_warning_printed>: Now bool.
 678         (auto_load_pspace_data): Change type.
 679         (~auto_load_pspace_info): Rename from
 680         auto_load_pspace_data_cleanup.
 681         (get_auto_load_pspace_data, init_loaded_scripts_info)
 682         (clear_section_scripts, maybe_print_unsupported_script_warning)
 683         (maybe_print_script_not_found_warning, _initialize_auto_load):
 684         Update.
 685
 686 2019-05-08  Tom Tromey  <tom@tromey.com>
 687
 688         * objfiles.c (objfile_pspace_info): Add destructor and
 689         initializers.
 690         (objfiles_pspace_data): Change type.
 691         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 692         (get_objfile_pspace_data): Update.
 693         (objfiles_bfd_data): Change type.
 694         (get_objfile_bfd_data): Update.
 695         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 696
 697 2019-05-08  Tom Tromey  <tom@tromey.com>
 698
 699         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 700         Change type.
 701         (get_catch_syscall_inferior_data): Update.
 702         (catch_syscall_inferior_data_cleanup): Remove.
 703         (_initialize_break_catch_syscall): Update.
 704
 705 2019-05-08  Tom Tromey  <tom@tromey.com>
 706
 707         * inflow.c (struct terminal_info): Add destructor and
 708         initializers.
 709         (inflow_inferior_data): Change type.
 710         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 711         (get_inflow_inferior_data, inflow_inferior_exit)
 712         (swap_terminal_info, _initialize_inflow): Update.
 713
 714 2019-05-08  Tom Tromey  <tom@tromey.com>
 715
 716         * target-dcache.c (target_dcache_cleanup): Remove.
 717         (target_dcache_aspace_key): Change type.
 718         (target_dcache_init_p, target_dcache_invalidate)
 719         (target_dcache_get, target_dcache_get_or_init)
 720         (_initialize_target_dcache): Update.
 721         * dcache.h (struct dcache_deleter): New.
 722
 723 2019-05-08  Tom Tromey  <tom@tromey.com>
 724
 725         * symtab.c (struct symbol_cache): Add destructor and
 726         initializers.
 727         (symbol_cache_key): Move.  Change type.
 728         (make_symbol_cache, free_symbol_cache): Remove.
 729         (get_symbol_cache): Update.
 730         (symbol_cache_cleanup): Remove.
 731         (ALL_PSPACES, symbol_cache_flush)
 732         (maintenance_print_symbol_cache)
 733         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 734         Update.
 735
 736 2019-05-08  Tom Tromey  <tom@tromey.com>
 737
 738         * symtab.c (struct main_info): Add destructor and initializers.
 739         (main_progspace_key): Move.  Change type.
 740         (get_main_info): Update.
 741         (main_info_cleanup): Remove.
 742         (_initialize_symtab): Update.
 743
 744 2019-05-08  Tom Tromey  <tom@tromey.com>
 745
 746         * registry.h (DECLARE_REGISTRY): Define the _key class.
 747
 748 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * NEWS: Merge two 'New commands' sections.
 751
 752 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 753
 754         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 755         parameter and use Ada language definition instead.
 756         (ada_val_print_ptr): Remove unused language parameter.
 757         (ada_val_print_num): Remove language parameter and use Ada language
 758         definition instead.
 759         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 760         parameter.
 761         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 762         parameter and use Ada language definition instead.
 763         (ada_val_print_1): Update all ada_val_print_xxx calls.
 764         Remove language parameter.
 765         (ada_val_print): Update ada_val_print_1 call.
 766
 767 2019-05-08  Tom Tromey  <tromey@adacore.com>
 768
 769         * remote.c (remote_hw_watchpoint_limit)
 770         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 771         Now static.
 772
 773 2019-05-08  Tom Tromey  <tromey@adacore.com>
 774
 775         * maint.c (_initialize_maint_cmds): Move initialization code to
 776         remote.c.
 777         (watchdog, show_watchdog): Move to remote.c.
 778         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 779         "watchdog" static.
 780         (_initialize_remote): Move initialization code from maint.c.
 781         * defs.h (watchdog): Don't declare.
 782
 783 2019-05-08  Tom Tromey  <tromey@adacore.com>
 784
 785         * tui/tui-interp.c: Include main.h.
 786         * interps.c: Include main.h.
 787         * main.h (interpreter_p): Declare.
 788         * defs.h (interpreter_p): Don't declare.
 789
 790 2019-05-08  Tom Tromey  <tromey@adacore.com>
 791
 792         * dwarf2loc.c: Include dwarf2read.h.
 793         * defs.h (read_unsigned_leb128): Don't declare.
 794         * dwarf2read.h (read_unsigned_leb128): Declare.
 795
 796 2019-05-08  Tom Tromey  <tromey@adacore.com>
 797
 798         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 799         method.
 800
 801 2019-05-08  Tom Tromey  <tromey@adacore.com>
 802
 803         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 804         when no wrap column is set.
 805
 806 2019-05-08  Tom Tromey  <tromey@adacore.com>
 807
 808         * c-lang.c (c_get_string): Handle non-C-style arrays.
 809
 810 2019-05-08  Tom Tromey  <tromey@adacore.com>
 811
 812         * typeprint.c (print_offset_data::update): Print the bit offset,
 813         not the number of bits remaining.
 814
 815 2019-05-08  Tom Tromey  <tromey@adacore.com>
 816
 817         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 818         padding at end of comment.
 819
 820 2019-05-08  Tom Tromey  <tromey@adacore.com>
 821
 822         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 823         Compare main types.
 824
 825 2019-05-06  Tom Tromey  <tom@tromey.com>
 826
 827         * common/scoped_mmap.c: Include common-defs.h.
 828         * common/scoped_mmap.h: Don't include config.h.
 829
 830 2019-05-04  Tom Tromey  <tom@tromey.com>
 831
 832         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 833         (struct aarch64_call_info): Add initializers.
 834         <si>: Now a std::vector.
 835         (pass_on_stack, aarch64_push_dummy_call): Update.
 836
 837 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 838             Tom Tromey  <tom@tromey.com>
 839
 840         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 841         (ppc_threads): Now a std::vector.  Now static.
 842         (hwdebug_find_thread_points_by_tid)
 843         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 844         Update.
 845
 846 2019-05-04  Tom Tromey  <tom@tromey.com>
 847
 848         * arc-tdep.c (arc_tdesc_init): Return bool.
 849
 850 2019-05-04  Tom Tromey  <tom@tromey.com>
 851
 852         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 853         Use gdb_assert_not_reached.
 854
 855 2019-05-04  Tom Tromey  <tom@tromey.com>
 856
 857         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 858         "false".
 859
 860 2019-05-04  Tom Tromey  <tom@tromey.com>
 861
 862         * arc-tdep.c (arc_tdesc_init): Use bool.
 863
 864 2019-05-04  Tom Tromey  <tom@tromey.com>
 865
 866         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 867
 868 2019-05-04  Tom Tromey  <tom@tromey.com>
 869
 870         * cli/cli-cmds.c (valid_command_p): Return bool.
 871
 872 2019-05-04  Tom Tromey  <tom@tromey.com>
 873
 874         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 875         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 876
 877 2019-05-04  Raul Tambre  <raul@tambre.ee>
 878
 879         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 880         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 881         operator for comparison.
 882
 883 2019-05-04  Tom Tromey  <tom@tromey.com>
 884
 885         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 886         (lookup_partial_symbol, print_partial_symbols)
 887         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 888         (psymbol_compare): Update.
 889         (add_psymbol_to_bcache): Clear the entire psymbol.
 890         (maintenance_check_psymtabs): Update.
 891         * psympriv.h (struct partial_symbol): Don't derive from
 892         general_symbol_info.
 893         <obj_section, unrelocated_address, address,
 894         set_unrelocated_address>: Update.
 895         <ginfo>: New member.
 896         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 897         (debug_names::write_psymbols): Update.
 898
 899 2019-05-04  Tom de Vries  <tdevries@suse.de>
 900
 901         * contrib/cc-with-tweaks.sh: Support -n arg.
 902
 903 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 904
 905         * corelow.c (core_target::detach): Ensure frame cache and
 906         register caches are cleared.
 907         inferior.c (exit_inferior_1): Likewise.
 908
 909 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 910             Tom Tromey  <tom@tromey.com>
 911
 912         * dictionary.c (collate_pending_symbols_by_language): Remove
 913         "struct" from foreach.
 914         * symtab.c (lookup_global_symbol_from_objfile)
 915         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 916         foreach.
 917         * ser-tcp.c (net_open): Remove "struct" from foreach.
 918         * objfiles.c (objfile_relocate, objfile_rebase)
 919         (objfile_has_symbols): Remove "struct" from foreach.
 920         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 921         from foreach.
 922         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 923         foreach.
 924         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 925         "struct" from foreach.
 926         * ada-lang.c (create_excep_cond_exprs)
 927         (ada_exception_catchpoint_cond_string): Remove "struct" from
 928         foreach.
 929
 930 2019-05-03  Tom Tromey  <tromey@adacore.com>
 931
 932         * ada-exp.y (convert_char_literal): Check suffix of each
 933         enumerator.
 934
 935 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 936
 937         PR ada/21406:
 938         * ada-exp.y (yywrap): Don't define.
 939         * ada-lex.l (%option): Add noyywrap
 940         (yywrap): Remove.
 941
 942 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 943
 944         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 945         _WIN32_WINNT to the XP level, unless already defined to a higher
 946         level.
 947
 948         * unittests/parse-connection-spec-selftests.c:
 949         * ser-tcp.c:
 950         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 951         override.
 952
 953         * symfile.c (find_separate_debug_file): Remove colon from the
 954         drive spec of DOS/Windows file names of the target, so that the
 955         file name produced from DEBUGDIR and the target's directory will
 956         be valid on DOS/Windows systems.
 957
 958 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * rust-lang.c (val_print_struct): Handle printing structures
 961         containing strings.
 962
 963 2019-05-02  Tom Tromey  <tromey@adacore.com>
 964
 965         * valarith.c (_initialize_valarith): Remove.
 966
 967 2019-05-01  Tom Tromey  <tromey@adacore.com>
 968
 969         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 970         bitfields.
 971
 972 2019-05-01  Tom Tromey  <tromey@adacore.com>
 973
 974         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 975         for big-endian copies.
 976
 977 2019-04-30  Ali Tamur  <tamur@google.com>
 978         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 979         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 980         (read_3_bytes): New function.
 981
 982 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 983
 984         * windows-nat.c (main_thread_id): Delete.
 985         (handle_output_debug_string): Replace main_thread_id by
 986         current_event.dwThreadId.
 987         (fake_create_process): Likewise.
 988         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 989         Do not set main_thread_id.
 990         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 991         current_event.dwThreadId.
 992         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 993
 994 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 995
 996         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 997         Use current_event.dwThreadId instead of main_thread_id.
 998
 999 2019-04-30  Tom Tromey  <tromey@adacore.com>
1000
1001         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1002         (create_excep_cond_exprs): Iterate over program spaces.
1003         (ada_exception_catchpoint_cond_string): Examine all minimal
1004         symbols for exception types.
1005
1006 2019-04-30  Tom Tromey  <tromey@adacore.com>
1007
1008         PR c++/24470:
1009         * dwarf2read.c (process_structure_scope): Handle case where type
1010         has template parameters but no symbol was created.
1011
1012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1013             Chris January  <chris.january@arm.com>
1014
1015         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1016         qualifier.
1017         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1018
1019 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * f-typeprint.c (f_print_type): Update rules for printing
1022         whitespace.
1023         (f_type_print_varspec_suffix): Likewise.
1024
1025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1026             Chris January  <chris.january@arm.com>
1027
1028         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1029         function arguments.
1030
1031 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * f-lang.c (build_fortran_types): Change name of void type to
1034         lower case.
1035         * f-typeprint.c (f_type_print_base): Print the name of the void
1036         type, rather than a fixed string.
1037         * f-valprint.c (f_decorations): Use lower case void string.
1038
1039 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1040             Chris January  <chris.january@arm.com>
1041
1042         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1043         types for Fortran.
1044
1045 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1046             Chris January  <chris.january@arm.com>
1047             David Lecomber  <david.lecomber@arm.com>
1048
1049         * f-exp.y (BINOP_INTRINSIC): New token.
1050         (exp): New parser rule handling BINOP_INTRINSIC.
1051         (f77_keywords): Add new builtin procedures.
1052         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1053         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1054         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1055         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1056         (print_unop_subexp_f): New function.
1057         (print_binop_subexp_f): New function.
1058         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1059         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1060         (dump_subexp_body_f): Likewise.
1061         (operator_check_f): Likewise.
1062         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1063         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1064
1065 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1068         UNOP_KIND.
1069         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1070         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1071         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1072         (operator_length_f): New fuction.
1073         (print_subexp_f): New function.
1074         (op_name_f): New function.
1075         (dump_subexp_body_f): New function.
1076         (operator_check_f): New function.
1077         (exp_descriptor_f): Replace standard expression handling functions
1078         with new functions.
1079         * gdb/fortran-operator.def: New file.
1080         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1081         * gdb/std-operator.def: Remove UNOP_KIND.
1082
1083 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * std-operator.def: Remove unbalanced, stray double quote
1086         character.
1087
1088 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1089             Chris January  <chris.january@arm.com>
1090             Daniel Everett  <daniel.everett@arm.com>
1091             Nick Forrington  <nick.forrington@arm.com>
1092             Richard Bunt  <richard.bunt@arm.com>
1093
1094         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1095         of depth when printing anonymous structs or unions.
1096         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1097         Don't print either the top-level value, or the children if the
1098         max-depth is exceeded.
1099         (ppscm_print_children): When printing the key of a map, allow one
1100         extra level of depth.
1101         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1102         print either the top-level value, or the children if the max-depth
1103         is exceeded.
1104         (print_children): When printing the key of a map, allow one extra
1105         level of depth.
1106         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1107         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1108         (user_print_options): Initialise max_depth field.
1109         (val_print_scalar_or_string_type_p): New function.
1110         (val_print): Check to see if the max depth has been reached.
1111         (val_print_check_max_depth): Define new function.
1112         (show_print_max_depth): New function.
1113         (_initialize_valprint): Add 'print max-depth' option.
1114         * valprint.h (struct value_print_options) <max_depth>: New field.
1115         (val_print_check_max_depth): Declare new function.
1116         * NEWS: Document new feature.
1117
1118 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * ada-lang.c (ada_language_defn): Initialise new field.
1121         * c-lang.c (c_is_string_type_p): New function.
1122         (c_language_defn): Initialise new field.
1123         (cplus_language_defn): Initialise new field.
1124         (asm_language_defn): Initialise new field.
1125         (minimal_language_defn): Initialise new field.
1126         * c-lang.h (c_is_string_type_p): Declare new function.
1127         * d-lang.c (d_language_defn): Initialise new field.
1128         * f-lang.c (f_is_string_type_p): New function.
1129         (f_language_defn): Initialise new field.
1130         * go-lang.c (go_is_string_type_p): New function.
1131         (go_language_defn): Initialise new field.
1132         * language.c (default_is_string_type_p): New function.
1133         (unknown_language_defn): Initialise new field.
1134         (auto_language_defn): Initialise new field.
1135         * language.h (struct language_defn) <la_is_string_type_p>: New
1136         member variable.
1137         (default_is_string_type_p): Declare new function.
1138         * m2-lang.c (m2_language_defn): Initialise new field.
1139         * objc-lang.c (objc_language_defn): Initialise new field.
1140         * opencl-lang.c (opencl_language_defn): Initialise new field.
1141         * p-lang.c (pascal_is_string_type_p): New function.
1142         (pascal_language_defn): Initialise new field.
1143         * rust-lang.c (rust_is_string_type_p): New function.
1144         (rust_language_defn): Initialise new field.
1145
1146 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1149         New field.
1150         * ada-lang.c (ada_language_defn): Initialise new field.
1151         * c-lang.c (c_language_defn): Likewise.
1152         (cplus_language_defn): Likewise.
1153         (asm_language_defn): Likewise.
1154         (minimal_language_defn): Likewise.
1155         * d-lang.c (d_language_defn): Likewise.
1156         * f-lang.c (f_language_defn): Likewise.
1157         * go-lang.c (go_language_defn): Likewise.
1158         * language.c (unknown_language_defn): Likewise.
1159         (auto_language_defn): Likewise.
1160         * m2-lang.c (m2_language_defn): Likewise.
1161         * objc-lang.c (objc_language_defn): Likewise.
1162         * opencl-lang.c (opencl_language_defn): Likewise.
1163         * p-lang.c (pascal_language_defn): Likewise.
1164         * rust-lang.c (rust_language_defn): Likewise.
1165
1166 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1167
1168         * ada-lang.c (ada_is_character_type): Change return type to bool.
1169         (ada_is_string_type): Likewise.
1170         * ada-lang.h (ada_is_character_type): Update declaration
1171         (ada_is_string_type): Likewise.
1172
1173 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1174
1175         Support style in 'frame|thread apply'
1176
1177         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1178         * record.c (record_start, record_stop): Update callers of
1179         execute_command_to_string with false.
1180         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1181         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1182         methods.
1183         (class string_file): New constructor with term_out parameter.
1184         Override methods term_out and can_emit_style_escape.  New member
1185         term_out.
1186         (class stdio_file): Override can_emit_style_escape.
1187         (class tee_file): Override term_out and can_emit_style_escape.
1188         * utils.h (can_emit_style_escape): Remove.
1189         * utils.c (can_emit_style_escape): Likewise.
1190         Update all callers of can_emit_style_escape (SOMESTREAM) to
1191         SOMESTREAM->can_emit_style_escape.
1192         * source-cache.c (source_cache::get_source_lines): Likewise.
1193         * stack.c (frame_apply_command_count): Call execute_command_to_string
1194         passing the term_out characteristic of the current gdb_stdout.
1195         * thread.c (thr_try_catch_cmd): Likewise.
1196         * top.c (execute_command_to_string): pass term_out parameter
1197         to construct the string_file for the command output.
1198         * ui-file.c (term_cli_styling): New function (most code moved
1199         from utils.c can_emit_style_escape).
1200         (string_file::string_file, string_file::can_emit_style_escape,
1201         stdio_file::can_emit_style_escape, tee_file::term_out,
1202         tee_file::can_emit_style_escape): New functions.
1203
1204 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * NEWS: Mention the new set|show may-call-functions.
1207         * infcall.c (may_call_functions_p): New variable.
1208         (show_may_call_functions_p): New function.
1209         (call_function_by_hand_dummy): Throws an error if not
1210         may-call-functions.
1211         (_initialize_infcall): Call add_setshow_boolean_cmd for
1212         may-call-functions.
1213
1214 2019-04-25  Keith Seitz  <keiths@redhat.com>
1215
1216         PR c++/24367
1217         * cp-support.c (inspect_type): Don't attempt substitutions
1218         of symbol with the same name.
1219
1220 2019-04-25  Tom Tromey  <tromey@adacore.com>
1221
1222         PR gdb/24475:
1223         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1224         static.
1225
1226 2019-04-25  Tom Tromey  <tromey@adacore.com>
1227
1228         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1229         rvalue reference.
1230         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1231         (gdb_xml_parser::parse): Use std::move.
1232         * python/python-internal.h (gdbpy_convert_exception): Take a const
1233         reference.
1234         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1235         std::move.
1236         * python/py-utils.c (gdbpy_convert_exception): Take a const
1237         reference.
1238         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1239         Use std::move.
1240         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1241         Use std::move.
1242         * mi/mi-main.c (mi_print_exception): Take a const reference.
1243         * main.c (handle_command_errors): Take a const reference.
1244         * linespec.c (parse_linespec): Use std::move.
1245         * infcall.c (run_inferior_call): Use std::move.
1246         (call_function_by_hand_dummy): Use std::move.
1247         * exec.c (try_open_exec_file): Use std::move.
1248         * exceptions.h (exception_print, exception_fprintf)
1249         (exception_print_same): Update.
1250         * exceptions.c (print_exception, exception_print)
1251         (exception_fprintf, exception_print_same): Change parameters to
1252         const reference.
1253         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1254         * common/new-op.c: Use std::move.
1255         * common/common-exceptions.h (struct gdb_exception): Add move
1256         constructor.
1257         (struct gdb_exception_error, struct gdb_exception_quit, struct
1258         gdb_quit_bad_alloc): Change constructor to move constructor.
1259         (throw_exception): Change parameter to rvalue reference.
1260         * common/common-exceptions.c (throw_exception): Take rvalue
1261         reference.
1262         * cli/cli-interp.c (safe_execute_command): Use std::move.
1263         * breakpoint.c (insert_bp_location, location_to_sals): Use
1264         std::move.
1265
1266 2019-04-25  Tom Tromey  <tromey@adacore.com>
1267
1268         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1269         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1270         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1271         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1272         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1273         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1274         guile/scm-value.c: Use unpack.
1275         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1276         gdbscm_gdb_exception.
1277         (gdbscm_throw_gdb_exception): Likewise.
1278         (struct gdbscm_gdb_exception): New.
1279         (unpack): New function.
1280         (gdbscm_wrap): Use unpack.
1281
1282 2019-04-25  Tom Tromey  <tromey@adacore.com>
1283
1284         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1285         (gdb_rl_callback_handler): Use std::move.
1286         * common/common-exceptions.h (struct gdb_exception): Add move
1287         assignment operator.
1288         (throw_exception_sjlj): Change "exception" to const reference.
1289         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1290         (throw_exception_sjlj): Change "exception" to const reference.
1291
1292 2019-04-25  Tom Tromey  <tromey@adacore.com>
1293
1294         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1295         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1296         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1297         Update.
1298         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1299         Update.
1300         * mi/mi-interp.c (mi_interp::exec): Update.
1301         * linespec.c (parse_linespec): Update.
1302         * infcall.c (run_inferior_call): Update.
1303         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1304         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1305         (gdbscm_lookup_global_symbol): Update.
1306         * guile/scm-param.c (gdbscm_parameter_value): Update.
1307         * guile/scm-frame.c (gdbscm_frame_read_register)
1308         (gdbscm_frame_read_var): Update.
1309         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1310         * exec.c (try_open_exec_file): Update.
1311         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1312         (gdb_rl_callback_handler): Update.
1313         * common/common-exceptions.h (exception_none): Don't declare.
1314         * common/common-exceptions.c (exception_none): Don't define.
1315         (struct catcher) <exception>: Update.
1316         * cli/cli-interp.c (safe_execute_command): Update.
1317         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1318
1319 2019-04-25  Ali Tamur  <tamur@google.com>
1320
1321         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1322         (read_attribute_value): Likewise.
1323         (dwarf2_read_addr_index): Update comment.
1324         (read_str_index): Add DW_FORM_strx.
1325         (dwarf2_string_attr): Likewise.
1326         (dwarf2_const_value_attr): Likewise.
1327         (dump_die_shallow): Likewise.
1328         (dwarf2_fetch_constant_bytes): Likewise.
1329         (skip_form_bytes): Likewise.
1330         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1331
1332 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1333
1334         PR corefiles/11608
1335         PR corefiles/18187
1336         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1337         OFFSET.  Verify if current mapping contains an ELF header.
1338         (linux_find_memory_regions_full): Adjust call to
1339         dump_mapping_p.
1340
1341 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1342             Kang Li <kanglictf@gmail.com>
1343
1344         PR gdb/21600
1345
1346         * dwarf2-frame.c (read_initial_length): Be consistent about using
1347         unsigned representation of length.
1348         (decode_frame_entry_1): Likewise.  Check for wraparound of
1349         end pointer as well as buffer overflow.
1350
1351 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1352
1353         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1354         "vq".
1355
1356 2019-04-24  Tom Tromey  <tromey@adacore.com>
1357
1358         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1359
1360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * s12z-tdep.c (s12z_unwind_pc): Delete.
1363         (s12z_unwind_sp): Delete.
1364         (s12z_gdbarch_init): Don't register deleted functions with
1365         gdbarch.
1366
1367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * rl78-tdep.c (rl78_unwind_sp): Delete.
1370         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1371
1372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1375         (xstormy16_unwind_pc): Delete.
1376         (xstormy16_dummy_id): Delete.
1377         (xstormy16_gdbarch_init): Don't register deleted functions with
1378         gdbarch.
1379
1380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * vax-tdep.c (vax_unwind_pc): Delete.
1383         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1384
1385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * v850-tdep.c (v850_unwind_sp): Delete.
1388         (v850_unwind_pc): Delete.
1389         (v850_dummy_id): Delete.
1390         (v850_gdbarch_init): Don't register deleted functions with
1391         gdbarch.
1392
1393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1396         (tilegx_unwind_pc): Delete.
1397         (tilegx_unwind_dummy_id): Delete.
1398         (tilegx_gdbarch_init): Don't register deleted functions with
1399         gdbarch.
1400
1401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1404         (tic6x_dummy_id): Delete.
1405         (tic6x_gdbarch_init): Don't register deleted functions with
1406         gdbarch.
1407
1408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1409
1410         * sparc-tdep.c (sparc_unwind_pc): Delete.
1411         (sparc32_gdbarch_init): Don't register deleted function with
1412         gdbarch.
1413
1414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * sh-tdep.c (sh_unwind_sp): Delete.
1417         (sh_unwind_pc): Delete.
1418         (sh_dummy_id): Delete.
1419         (sh_gdbarch_init): Don't register deleted functions with
1420         gdbarch.
1421
1422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1423
1424         * score-tdep.c (score_unwind_sp): Delete.
1425         (score_unwind_pc): Delete.
1426         (score_dummy_id): Delete.
1427         (score_gdbarch_init): Don't register deleted functions with
1428         gdbarch.
1429
1430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * rx-tdep.c (rx_unwind_pc): Delete.
1433         (rx_unwind_sp): Delete.
1434         (rx_dummy_id): Delete.
1435         (rx_gdbarch_init): Don't register deleted functions with
1436         gdbarch.  Update comment.
1437
1438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1441         (rs6000_dummy_id): Delete.
1442         (rs6000_gdbarch_init): Don't register deleted functions with
1443         gdbarch.
1444
1445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * or1k-tdep.c (or1k_dummy_id): Delete.
1448         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1449
1450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * nios2-tdep.c (nios2_dummy_id): Delete.
1453         (nios2_unwind_sp): Delete.
1454         (nios2_gdbarch_init): Don't register deleted functions with
1455         gdbarch.
1456
1457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * nds32-tdep.c (nds32_dummy_id): Delete.
1460         (nds32_unwind_pc): Delete.
1461         (nds32_unwind_sp): Delete.
1462         (nds32_gdbarch_init): Don't register deleted functions with
1463         gdbarch.
1464
1465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * msp430-tdep.c (msp430_unwind_pc): Delete.
1468         (msp430_unwind_sp): Delete.
1469         (msp430_dummy_id): Delete.
1470         (msp430_gdbarch_init): Don't register deleted functions with
1471         gdbarch.
1472
1473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * moxie-tdep.c (moxie_unwind_sp): Delete.
1476         (moxie_unwind_pc): Delete.
1477         (moxie_dummy_id): Delete.
1478         (moxie_gdbarch_init): Don't register deleted functions with
1479         gdbarch.
1480
1481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1484         (mn10300_unwind_pc): Delete.
1485         (mn10300_unwind_sp): Delete.
1486         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1487         mn10300_unwind_sp.
1488         (mn10300_frame_unwind_init): Don't register deleted functions with
1489         gdbarch.
1490
1491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * mep-tdep.c (mep_unwind_pc): Delete.
1494         (mep_unwind_sp): Delete.
1495         (mep_dummy_id): Delete.
1496         (mep_gdbarch_init): Don't register deleted functions with
1497         gdbarch.
1498
1499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1502         (m68hc11_unwind_sp): Delete.
1503         (m68hc11_gdbarch_init): Don't register deleted functions with
1504         gdbarch.
1505
1506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * m32r-tdep.c (m32r_unwind_sp): Delete.
1509         (m32r_unwind_pc): Delete.
1510         (m32r_dummy_id): Delete.
1511         (m32r_gdbarch_init): Don't register deleted functions with
1512         gdbarch.
1513
1514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * m32c-tdep.c (m32c_unwind_pc): Delete.
1517         (m32c_unwind_sp): Delete.
1518         (m32c_dummy_id): Delete.
1519         (m32c_gdbarch_init): Don't register deleted functions with
1520         gdbarch.
1521
1522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1525         (lm32_unwind_pc): Delete.
1526         (lm32_dummy_id): Delete.
1527         (lm32_gdbarch_init): Don't register deleted functions with
1528         gdbarch.
1529
1530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1533         (iq2000_unwind_pc): Delete.
1534         (iq2000_dummy_id): Delete.
1535         (iq2000_gdbarch_init): Don't register deleted functions with
1536         gdbarch.
1537
1538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * nds32-tdep.c (nds32_type_align): Delete.
1541         (nds32_push_dummy_call): Use type_align instead.
1542
1543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1544
1545         * arm-tdep.c (arm_type_align): Only handle vector override case.
1546         (arm_push_dummy_call): Use type_align.
1547         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1548
1549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1552         case.
1553         (pass_on_stack): Use type_align.
1554         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1555         function.
1556
1557 2019-04-23  Tom Tromey  <tromey@adacore.com>
1558
1559         * dwarf2read.c (line_header::file_name_at): Remove unused
1560         overload.
1561
1562 2019-04-23  Tom de Vries  <tdevries@suse.de>
1563
1564         PR gdb/24438
1565         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1566         invocation.
1567
1568
1569 2019-03-27  Ali Tamur  <tamur@google.com>
1570
1571         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1572         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1573         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1574         (dwarf_expr_context::get_addr_index): Likewise
1575         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1576         (symbol_needs_eval_context::get_addr_index): Likewise
1577         (disassemble_dwarf_expression): Add DW_OP_addrx
1578         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1579         (read_cutu_die_from_dwo): Update comment
1580         (skip_one_die): Add DW_FORM_addrx
1581         (read_attribute_value): Likewise
1582         (var_decode_location): Add DW_OP_addrx
1583         (dwarf2_const_value_attr): Add DW_FORM_addrx
1584         (dump_die_shallow): Likewise
1585         (dwarf2_fetch_constant_bytes): Likewise
1586         (decode_locdesc): Add DW_OP_addrx
1587         (skip_form_bytes): Add DW_FORM_addrx
1588
1589 2019-04-22  Ali Tamur  <tamur@google.com>
1590
1591         * MAINTAINERS (Write After Approval): Add self.
1592
1593 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1594
1595         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1596         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1597         (open_symbol_file_object): Likewise.
1598         (svr4_default_sos): Add info parameter.
1599         (svr4_read_so_list): Likewise.
1600         (svr4_current_sos_direct): Adjust functions calls to pass down
1601         info.
1602         (svr4_current_sos_1): Add info parameter.
1603         (svr4_current_sos): Call get_svr4_info, pass info down to
1604         svr4_current_sos_1.
1605         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1606         get_svr4_info.
1607         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1608         get_svr4_info.
1609         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1610         to get_svr4_info.
1611         (probes_table_remove_objfile_probes): Likewise.
1612         (register_solib_event_probe): Add info parameter.
1613         (solist_update_incremental): Pass info parameter down to
1614         svr4_read_so_list.
1615         (disable_probes_interface): Add info parameter.
1616         (svr4_handle_solib_event): Pass current_program_space to
1617         get_svr4_info.  Adjust disable_probes_interface cleanup.
1618         (svr4_create_probe_breakpoints): Add info parameter, pass it
1619         down to register_solib_event_probe.
1620         (svr4_create_solib_event_breakpoints): Add info parameter,
1621         pass it down to svr4_create_probe_breakpoints.
1622         (enable_break): Pass info down to
1623         svr4_create_solib_event_breakpoints.
1624         (svr4_solib_create_inferior_hook): Pass current_program_space to
1625         get_svr4_info.
1626         (svr4_clear_solib): Likewise.
1627
1628 2019-04-22  Pedro Alves  <palves@redhat.com>
1629
1630         * solib-svr4.c (svr4_free_objfile_observer): New.
1631         (probe_and_action::objfile): New field.
1632         (probes_table_htab_remove_objfile_probes)
1633         (probes_table_remove_objfile_probes): New functions.
1634         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1635         in the new probe_and_action.  Don't store the probe in 'lookup'.
1636         (svr4_create_probe_breakpoints): Pass objfile to
1637         register_solib_event_probe.
1638         (_initialize_svr4_solib): Register a free_objfile observer.
1639
1640 2019-04-19  Tom Tromey  <tom@tromey.com>
1641
1642         * common/queue.h: Remove.
1643
1644 2019-04-19  Tom Tromey  <tom@tromey.com>
1645
1646         * event-loop.c: Don't include "common/queue.h".
1647
1648 2019-04-19  Tom Tromey  <tom@tromey.com>
1649
1650         * remote.c (remote_target): Use delete.
1651         * remote-notif.h: Include <list>, not "common/queue.h".
1652         (notif_client_p): Remove typedef.
1653         (remote_notif_state): Add constructor, destructor, initializer.
1654         <notif_queue>: Now a std::list.
1655         (remote_notif_state_xfree): Don't declare.
1656         * remote-notif.c (remote_notif_process, handle_notification)
1657         (remote_notif_state_allocate): Update.
1658         (~remote_notif_state): Rename from remote_notif_state_xfree.
1659
1660 2019-04-19  Tom Tromey  <tom@tromey.com>
1661
1662         * symfile.c (reread_symbols): Update.
1663         * objfiles.c (objfile_register_static_link)
1664         (objfile_lookup_static_link): Update
1665         (~objfile) Don't delete static_links.
1666         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1667
1668 2019-04-19  Tom Tromey  <tom@tromey.com>
1669
1670         * type-stack.h (struct type_stack) <insert>: Constify string.
1671         * type-stack.c (type_stack::insert): Constify string.
1672         * gdbtypes.h (lookup_template_type): Update.
1673         (address_space_name_to_int): Update.
1674         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1675         const.
1676         (lookup_template_type): Make name const.
1677         * c-exp.y: Update rules.
1678         (lex_one_token, classify_name, classify_inner_name)
1679         (c_print_token): Update.
1680         * p-exp.y: Update rules.
1681         (yylex): Update.
1682         * f-exp.y: Update rules.
1683         (yylex): Update.
1684         * d-exp.y: Update rules.
1685         (lex_one_token, classify_name, classify_inner_name): Update.
1686         * parse.c (write_dollar_variable, copy_name): Return std::string.
1687         * parser-defs.h (copy_name): Change return type.
1688         * m2-exp.y: Update rules.
1689         (yylex): Update.
1690         * go-exp.y (lex_one_token): Update.
1691         Update rules.
1692         (classify_unsafe_function, classify_packaged_name)
1693         (classify_name, yylex): Update.
1694
1695 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1696
1697         * configure.ac: add --enable-source-highlight switch.
1698         * configure: Regenerate.
1699         * top.c (print_gdb_version): plumb --enable-source-highlight
1700         status to "show configuration".
1701
1702 2019-04-19  Tom Tromey  <tromey@adacore.com>
1703
1704         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1705         Check ADA_TYPE_P.
1706         (empty_record, ada_template_to_fixed_record_type_1)
1707         (template_to_static_fixed_type)
1708         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1709         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1710         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1711         macros.
1712
1713 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1714
1715         PR symtab/24423:
1716         * source.c (print_source_lines_base): Advance "iter" when a
1717         control character is seen.
1718
1719 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1720
1721         * inferior.h (struct infcall_suspend_state_deleter):
1722         Catch exception in destructor to avoid crash.
1723
1724 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1725
1726         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1727         close to the add_com "shell".
1728
1729 2019-04-18  Tom Tromey  <tromey@adacore.com>
1730
1731         * process-stratum-target.h (class process_stratum_target)
1732         <stratum>: Add "final".
1733
1734 2019-04-17  Tom Tromey  <tromey@adacore.com>
1735
1736         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1737         against nullptr before use.
1738
1739 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1740
1741         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1742
1743 2019-04-17  Jim Wilson  <jimw@sifive.com>
1744             Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1747         code read might fail, assume 4-byte breakpoint in that case.
1748
1749 2019-04-15  Leszek Swirski  <leszeks@google.com>
1750
1751         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1752         rather than a hand-rolled POD check when checking for forced MEMORY
1753         classification.
1754
1755 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1756
1757         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1758         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1759         function.
1760         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1761         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1762         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1763         declaration.
1764
1765 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1766
1767         * aarch64-linux-nat.c
1768         (aarch64_linux_nat_target::thread_architecture): Add override.
1769         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1770         each VQ.
1771
1772 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1773
1774         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1775
1776 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1779         target types of size 96-bits, add some additional comments, and
1780         check that the builtin type we found was the correct size.
1781
1782 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1783
1784         * utils.c (prompt_for_continue): Don't restore the styling at the
1785         end, as applied_style has the wrong value.  This fixes styling in
1786         long lists of file names that are interrupted by the "Continue?"
1787         prompt.
1788
1789 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1792         * c-lang.c (c_language_defn): Likewise.
1793         (cplus_language_defn): Likewise.
1794         (asm_language_defn): Likewise.
1795         (minimal_language_defn): Likewise.
1796         * d-lang.c (d_language_defn): Likewise.
1797         * f-lang.c (f_language_defn): Likewise.
1798         * go-lang.c (go_language_defn): Likewise.
1799         * language.c (unknown_language_defn): Likewise.
1800         (auto_language_defn): Likewise.
1801         * language.h (struct language_defn): Remove la_magic field.
1802         (LANG_MAGIC): Delete.
1803         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1804         * objc-lang.c (objc_language_defn): Likewise.
1805         * opencl-lang.c (opencl_language_defn): Likewise.
1806         * p-lang.c (pascal_language_defn): Likewise.
1807         * rust-lang.c (rust_language_defn): Likewise.
1808
1809 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1810
1811         * riscv-tdep.c (riscv_type_align): New function.
1812         (riscv_type_alignment): Delete.
1813         (riscv_arg_location): Use 'type_align'.
1814         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1815
1816 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * gdbtypes.c (type_align): A struct with no non-static fields also
1819         has alignment of 1.
1820
1821 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1824         component to 0.
1825         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1826         member.
1827         (riscv_struct_info::analyse): New implementation using new
1828         analyse_inner member function.
1829         (riscv_struct_info::field_offset): New member function.
1830         (riscv_struct_info::m_offsets): New member variable.
1831         (riscv_struct_info::analyse_inner): New private member function,
1832         takes the old implementation of riscv_struct_info::analyse but
1833         extended to track field offsets.
1834         (riscv_call_arg_struct): Update the struct folding special cases
1835         to handle cases where empty C++ structs, which are non-zero
1836         length, are found.
1837         (riscv_arg_location): Initialise the length of each location, a
1838         non-zero length now indicates the location is in use.
1839         (riscv_push_dummy_call): Allow for the first location having a
1840         non-zero offset when setting up arguments.
1841         (riscv_return_value): Likewise, but for return values.
1842
1843 2019-04-11  Tom Tromey  <tromey@adacore.com>
1844
1845         * utils.c (internal_vproblem): Make "msg" const.
1846
1847 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1848
1849         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1850         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1851         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1852         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1853
1854 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1855
1856         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1857         function.
1858         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1859         of amd64_collect_native_gregset.
1860         (amd64_linux_nat_target::store_registers): Likewise.
1861
1862 2019-04-10  Tom Tromey  <tom@tromey.com>
1863
1864         * symtab.c (lookup_global_symbol_from_objfile)
1865         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1866         * objfiles.h (class separate_debug_iterator): New.
1867         (class separate_debug_range): New.
1868         (struct objfile) <separate_debug_objfiles>: New method.
1869         (objfile_separate_debug_iterate): Don't declare.
1870         * objfiles.c (separate_debug_iterator::operator++): Rename from
1871         objfile_separate_debug_iterate.
1872         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1873         iterator.
1874         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1875         iterator.
1876
1877 2019-04-10  Tom Tromey  <tom@tromey.com>
1878
1879         * symfile.c (reread_symbols): Remove old comment.
1880         * objfiles.c (free_all_objfiles): Fix a typo.
1881
1882 2019-04-10  Tom Tromey  <tom@tromey.com>
1883
1884         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1885         * minsyms.c (lookup_minimal_symbol): Use foreach.
1886         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1887         (lookup_minimal_symbol_solib_trampoline): Likewise.
1888         * symfile.c (reread_symbols): Use foreach.
1889
1890 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1891             Tom Tromey  <tromey@adacore.com>
1892
1893         PR rust/24414:
1894         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1895         (rust_lex_int_test): Change "value" to be LONGEST.
1896         (rust_lex_tests): Add test for long integer literal.
1897
1898 2019-04-09  Tom Tromey  <tromey@adacore.com>
1899
1900         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1901         to bool.
1902         (extended_remote_target::attach): Update.
1903         (remote_target::remote_notice_new_inferior): Update.
1904         (remote_target::add_current_inferior_and_thread): Update.
1905         * inferior.c (exit_inferior_1): Use "false".
1906         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1907
1908 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1909
1910         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1911         the "start" command.
1912
1913 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1914
1915         * python/py-inferior.c (infpy_thread_from_thread_handle):
1916         Adjust comments to reflect renaming of thread_from_thread_handle
1917         to thread_from_handle.  Adjust keywords.  Fix type error message.
1918         (inferior_object_methods): Add thread_from_handle.  Retain
1919         thread_from_thread_handle, but mark it as deprecated.
1920
1921 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1922
1923         * gdbthread.h (find_thread_by_handle): Revise declaration.
1924         * thread.c (find_thread_by_handle): Likewise.  Adjust
1925         implementation too.
1926         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1927         support for buffer objects as handles.
1928
1929 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1930
1931         * python/py-infthread.c (thpy_thread_handle): New function.
1932         (thread_object_methods): Register thpy_thread_handle.
1933
1934 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1935
1936         * gdbthread.h (thread_to_thread_handle): Declare.
1937         * thread.c (gdbtypes.h): Include.
1938         (thread_to_thread_handle): New function.
1939
1940         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1941         (target_thread_info_to_thread_handle): Declare.
1942         * target.c (target_thread_info_to_thread_handle): New function.
1943         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1944         * target-delegates.c: Regenerate.
1945
1946         * linux-thread-db.c (class thread_db_target): Add method
1947         thread_info_to_thread_handle.
1948         (thread_db_target::thread_info_to_thread_handle): Define.
1949         * remote.c (class remote_target): Add new method
1950         thread_info_to_thread_handle.
1951         (remote_target::thread_info_to_thread_handle): Define.
1952
1953 2019-04-08  Pedro Alves  <palves@redhat.com>
1954
1955         * common/common-exceptions.c (throw_exception): Don't create
1956         named object to throw; throw directly.
1957         (throw_it): Likewise.  Don't initialize gdb_exception::message
1958         here, with new; pass FMT and AP to the ctor instead.
1959         * common/common-exceptions.h: Include <string>.
1960         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1961         const char *, va_list)): New ctor.  Use std::make_shared.
1962         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1963         errors)): Delete.
1964         (gdb_exception_error::gdb_exception_error(enum errors, const char
1965         *, va_list)): New.
1966         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1967         Add assertion.
1968         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1969         errors)): Delete.
1970         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1971         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1972         Add assertion.
1973
1974 2019-04-08  Tom Tromey  <tom@tromey.com>
1975
1976         * valops.c (value_rtti_indirect_type): Replace throw_exception
1977         with throw.
1978         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1979         with throw.
1980         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1981         throw.
1982         * target.c (target_translate_tls_address): Replace throw_exception
1983         with throw.
1984         * stack.c (frame_apply_command_count): Replace throw_exception
1985         with throw.
1986         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1987         throw.
1988         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1989         with throw.
1990         * rs6000-tdep.c (rs6000_frame_cache)
1991         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1992         * remote.c: Replace throw_exception with throw.
1993         * record-full.c (record_full_message, record_full_wait_1)
1994         (record_full_restore): Replace throw_exception with throw.
1995         * record-btrace.c:
1996         (get_thread_current_frame_id, record_btrace_start_replaying)
1997         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1998         (cmd_record_btrace_start): Replace throw_exception with throw.
1999         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2000         throw.
2001         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2002         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2003         * linespec.c:
2004         (find_linespec_symbols): Replace throw_exception with throw.
2005         * infrun.c (displaced_step_prepare, resume): Replace
2006         throw_exception with throw.
2007         * infcmd.c (post_create_inferior): Replace throw_exception with
2008         throw.
2009         * inf-loop.c (inferior_event_handler): Replace throw_exception
2010         with throw.
2011         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2012         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2013         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2014         (get_prev_frame_always, get_frame_pc_if_available)
2015         (get_frame_address_in_block_if_available, get_frame_language):
2016         Replace throw_exception with throw.
2017         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2018         throw_exception with throw.
2019         * eval.c (fetch_subexp_value, evaluate_var_value)
2020         (evaluate_funcall, evaluate_subexp_standard): Replace
2021         throw_exception with throw.
2022         * dwarf2loc.c (call_site_find_chain)
2023         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2024         Replace throw_exception with throw.
2025         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2026         with throw.
2027         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2028         throw.
2029         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2030         * completer.c (complete_line_internal): Replace throw_exception
2031         with throw.
2032         * compile/compile-object-run.c (compile_object_run): Replace
2033         throw_exception with throw.
2034         * cli/cli-script.c (process_next_line): Replace throw_exception
2035         with throw.
2036         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2037         (btrace_enable, btrace_maint_update_pt_packets): Replace
2038         throw_exception with throw.
2039         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2040         throw_exception with throw.
2041         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2042         throw_exception with throw.
2043         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2044         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2045         * aarch64-tdep.c (aarch64_make_prologue_cache)
2046         (aarch64_make_stub_cache): Replace throw_exception with throw.
2047
2048 2019-04-08  Tom Tromey  <tom@tromey.com>
2049
2050         * common/common-exceptions.c (throw_exception): Rename from
2051         throw_exception_cxx.  Remove old copy.  Make argument const.
2052         (throw_it): Create and throw exception objects directly.
2053         * common/common-exceptions.h (throw_exception): Make argument
2054         const.
2055         (struct gdb_exception_error): Add constructor.
2056         (struct gdb_exception_quit): Add constructor.
2057
2058 2019-04-08  Tom Tromey  <tom@tromey.com>
2059
2060         * common/common-exceptions.h (exception_rethrow): Don't declare.
2061         (TRY_SJLJ): Update comment.
2062         (TRY, CATCH, END_CATCH): Remove.
2063         * common/common-exceptions.c (exception_rethrow): Remove.
2064
2065 2019-04-08  Tom Tromey  <tom@tromey.com>
2066
2067         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2068         Remove.
2069         (gdb_exception_error): Rename from
2070         gdb_exception_RETURN_MASK_ERROR.
2071         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2072         (gdb_quit_bad_alloc): Update.
2073         * aarch64-tdep.c: Update.
2074         * ada-lang.c: Update.
2075         * ada-typeprint.c: Update.
2076         * ada-valprint.c: Update.
2077         * amd64-tdep.c: Update.
2078         * arch-utils.c: Update.
2079         * break-catch-throw.c: Update.
2080         * breakpoint.c: Update.
2081         * btrace.c: Update.
2082         * c-varobj.c: Update.
2083         * cli/cli-cmds.c: Update.
2084         * cli/cli-interp.c: Update.
2085         * cli/cli-script.c: Update.
2086         * common/common-exceptions.c: Update.
2087         * common/new-op.c: Update.
2088         * common/selftest.c: Update.
2089         * compile/compile-c-symbols.c: Update.
2090         * compile/compile-cplus-symbols.c: Update.
2091         * compile/compile-object-load.c: Update.
2092         * compile/compile-object-run.c: Update.
2093         * completer.c: Update.
2094         * corelow.c: Update.
2095         * cp-abi.c: Update.
2096         * cp-support.c: Update.
2097         * cp-valprint.c: Update.
2098         * darwin-nat.c: Update.
2099         * disasm-selftests.c: Update.
2100         * dtrace-probe.c: Update.
2101         * dwarf-index-cache.c: Update.
2102         * dwarf-index-write.c: Update.
2103         * dwarf2-frame-tailcall.c: Update.
2104         * dwarf2-frame.c: Update.
2105         * dwarf2loc.c: Update.
2106         * dwarf2read.c: Update.
2107         * eval.c: Update.
2108         * event-loop.c: Update.
2109         * event-top.c: Update.
2110         * exec.c: Update.
2111         * f-valprint.c: Update.
2112         * fbsd-tdep.c: Update.
2113         * frame-unwind.c: Update.
2114         * frame.c: Update.
2115         * gdbtypes.c: Update.
2116         * gnu-v3-abi.c: Update.
2117         * guile/guile-internal.h: Update.
2118         * guile/scm-block.c: Update.
2119         * guile/scm-breakpoint.c: Update.
2120         * guile/scm-cmd.c: Update.
2121         * guile/scm-disasm.c: Update.
2122         * guile/scm-frame.c: Update.
2123         * guile/scm-lazy-string.c: Update.
2124         * guile/scm-math.c: Update.
2125         * guile/scm-param.c: Update.
2126         * guile/scm-ports.c: Update.
2127         * guile/scm-pretty-print.c: Update.
2128         * guile/scm-symbol.c: Update.
2129         * guile/scm-symtab.c: Update.
2130         * guile/scm-type.c: Update.
2131         * guile/scm-value.c: Update.
2132         * i386-linux-tdep.c: Update.
2133         * i386-tdep.c: Update.
2134         * inf-loop.c: Update.
2135         * infcall.c: Update.
2136         * infcmd.c: Update.
2137         * infrun.c: Update.
2138         * jit.c: Update.
2139         * language.c: Update.
2140         * linespec.c: Update.
2141         * linux-fork.c: Update.
2142         * linux-nat.c: Update.
2143         * linux-tdep.c: Update.
2144         * linux-thread-db.c: Update.
2145         * main.c: Update.
2146         * mi/mi-cmd-break.c: Update.
2147         * mi/mi-cmd-stack.c: Update.
2148         * mi/mi-interp.c: Update.
2149         * mi/mi-main.c: Update.
2150         * objc-lang.c: Update.
2151         * p-valprint.c: Update.
2152         * parse.c: Update.
2153         * ppc-linux-tdep.c: Update.
2154         * printcmd.c: Update.
2155         * python/py-arch.c: Update.
2156         * python/py-breakpoint.c: Update.
2157         * python/py-cmd.c: Update.
2158         * python/py-finishbreakpoint.c: Update.
2159         * python/py-frame.c: Update.
2160         * python/py-framefilter.c: Update.
2161         * python/py-gdb-readline.c: Update.
2162         * python/py-inferior.c: Update.
2163         * python/py-infthread.c: Update.
2164         * python/py-lazy-string.c: Update.
2165         * python/py-linetable.c: Update.
2166         * python/py-objfile.c: Update.
2167         * python/py-param.c: Update.
2168         * python/py-prettyprint.c: Update.
2169         * python/py-progspace.c: Update.
2170         * python/py-record-btrace.c: Update.
2171         * python/py-record.c: Update.
2172         * python/py-symbol.c: Update.
2173         * python/py-type.c: Update.
2174         * python/py-unwind.c: Update.
2175         * python/py-utils.c: Update.
2176         * python/py-value.c: Update.
2177         * python/python.c: Update.
2178         * record-btrace.c: Update.
2179         * record-full.c: Update.
2180         * remote-fileio.c: Update.
2181         * remote.c: Update.
2182         * riscv-tdep.c: Update.
2183         * rs6000-aix-tdep.c: Update.
2184         * rs6000-tdep.c: Update.
2185         * rust-exp.y: Update.
2186         * rust-lang.c: Update.
2187         * s390-tdep.c: Update.
2188         * selftest-arch.c: Update.
2189         * solib-dsbt.c: Update.
2190         * solib-frv.c: Update.
2191         * solib-spu.c: Update.
2192         * solib-svr4.c: Update.
2193         * solib.c: Update.
2194         * sparc64-linux-tdep.c: Update.
2195         * stack.c: Update.
2196         * symfile-mem.c: Update.
2197         * symmisc.c: Update.
2198         * target.c: Update.
2199         * thread.c: Update.
2200         * top.c: Update.
2201         * tracefile-tfile.c: Update.
2202         * tui/tui.c: Update.
2203         * typeprint.c: Update.
2204         * unittests/cli-utils-selftests.c: Update.
2205         * unittests/parse-connection-spec-selftests.c: Update.
2206         * valops.c: Update.
2207         * valprint.c: Update.
2208         * value.c: Update.
2209         * varobj.c: Update.
2210         * windows-nat.c: Update.
2211         * x86-linux-nat.c: Update.
2212         * xml-support.c: Update.
2213
2214 2019-04-08  Tom Tromey  <tom@tromey.com>
2215
2216         * xml-support.c: Use C++ exception handling.
2217         * x86-linux-nat.c: Use C++ exception handling.
2218         * windows-nat.c: Use C++ exception handling.
2219         * varobj.c: Use C++ exception handling.
2220         * value.c: Use C++ exception handling.
2221         * valprint.c: Use C++ exception handling.
2222         * valops.c: Use C++ exception handling.
2223         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2224         handling.
2225         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2226         * typeprint.c: Use C++ exception handling.
2227         * tui/tui.c: Use C++ exception handling.
2228         * tracefile-tfile.c: Use C++ exception handling.
2229         * top.c: Use C++ exception handling.
2230         * thread.c: Use C++ exception handling.
2231         * target.c: Use C++ exception handling.
2232         * symmisc.c: Use C++ exception handling.
2233         * symfile-mem.c: Use C++ exception handling.
2234         * stack.c: Use C++ exception handling.
2235         * sparc64-linux-tdep.c: Use C++ exception handling.
2236         * solib.c: Use C++ exception handling.
2237         * solib-svr4.c: Use C++ exception handling.
2238         * solib-spu.c: Use C++ exception handling.
2239         * solib-frv.c: Use C++ exception handling.
2240         * solib-dsbt.c: Use C++ exception handling.
2241         * selftest-arch.c: Use C++ exception handling.
2242         * s390-tdep.c: Use C++ exception handling.
2243         * rust-lang.c: Use C++ exception handling.
2244         * rust-exp.y: Use C++ exception handling.
2245         * rs6000-tdep.c: Use C++ exception handling.
2246         * rs6000-aix-tdep.c: Use C++ exception handling.
2247         * riscv-tdep.c: Use C++ exception handling.
2248         * remote.c: Use C++ exception handling.
2249         * remote-fileio.c: Use C++ exception handling.
2250         * record-full.c: Use C++ exception handling.
2251         * record-btrace.c: Use C++ exception handling.
2252         * python/python.c: Use C++ exception handling.
2253         * python/py-value.c: Use C++ exception handling.
2254         * python/py-utils.c: Use C++ exception handling.
2255         * python/py-unwind.c: Use C++ exception handling.
2256         * python/py-type.c: Use C++ exception handling.
2257         * python/py-symbol.c: Use C++ exception handling.
2258         * python/py-record.c: Use C++ exception handling.
2259         * python/py-record-btrace.c: Use C++ exception handling.
2260         * python/py-progspace.c: Use C++ exception handling.
2261         * python/py-prettyprint.c: Use C++ exception handling.
2262         * python/py-param.c: Use C++ exception handling.
2263         * python/py-objfile.c: Use C++ exception handling.
2264         * python/py-linetable.c: Use C++ exception handling.
2265         * python/py-lazy-string.c: Use C++ exception handling.
2266         * python/py-infthread.c: Use C++ exception handling.
2267         * python/py-inferior.c: Use C++ exception handling.
2268         * python/py-gdb-readline.c: Use C++ exception handling.
2269         * python/py-framefilter.c: Use C++ exception handling.
2270         * python/py-frame.c: Use C++ exception handling.
2271         * python/py-finishbreakpoint.c: Use C++ exception handling.
2272         * python/py-cmd.c: Use C++ exception handling.
2273         * python/py-breakpoint.c: Use C++ exception handling.
2274         * python/py-arch.c: Use C++ exception handling.
2275         * printcmd.c: Use C++ exception handling.
2276         * ppc-linux-tdep.c: Use C++ exception handling.
2277         * parse.c: Use C++ exception handling.
2278         * p-valprint.c: Use C++ exception handling.
2279         * objc-lang.c: Use C++ exception handling.
2280         * mi/mi-main.c: Use C++ exception handling.
2281         * mi/mi-interp.c: Use C++ exception handling.
2282         * mi/mi-cmd-stack.c: Use C++ exception handling.
2283         * mi/mi-cmd-break.c: Use C++ exception handling.
2284         * main.c: Use C++ exception handling.
2285         * linux-thread-db.c: Use C++ exception handling.
2286         * linux-tdep.c: Use C++ exception handling.
2287         * linux-nat.c: Use C++ exception handling.
2288         * linux-fork.c: Use C++ exception handling.
2289         * linespec.c: Use C++ exception handling.
2290         * language.c: Use C++ exception handling.
2291         * jit.c: Use C++ exception handling.
2292         * infrun.c: Use C++ exception handling.
2293         * infcmd.c: Use C++ exception handling.
2294         * infcall.c: Use C++ exception handling.
2295         * inf-loop.c: Use C++ exception handling.
2296         * i386-tdep.c: Use C++ exception handling.
2297         * i386-linux-tdep.c: Use C++ exception handling.
2298         * guile/scm-value.c: Use C++ exception handling.
2299         * guile/scm-type.c: Use C++ exception handling.
2300         * guile/scm-symtab.c: Use C++ exception handling.
2301         * guile/scm-symbol.c: Use C++ exception handling.
2302         * guile/scm-pretty-print.c: Use C++ exception handling.
2303         * guile/scm-ports.c: Use C++ exception handling.
2304         * guile/scm-param.c: Use C++ exception handling.
2305         * guile/scm-math.c: Use C++ exception handling.
2306         * guile/scm-lazy-string.c: Use C++ exception handling.
2307         * guile/scm-frame.c: Use C++ exception handling.
2308         * guile/scm-disasm.c: Use C++ exception handling.
2309         * guile/scm-cmd.c: Use C++ exception handling.
2310         * guile/scm-breakpoint.c: Use C++ exception handling.
2311         * guile/scm-block.c: Use C++ exception handling.
2312         * guile/guile-internal.h: Use C++ exception handling.
2313         * gnu-v3-abi.c: Use C++ exception handling.
2314         * gdbtypes.c: Use C++ exception handling.
2315         * frame.c: Use C++ exception handling.
2316         * frame-unwind.c: Use C++ exception handling.
2317         * fbsd-tdep.c: Use C++ exception handling.
2318         * f-valprint.c: Use C++ exception handling.
2319         * exec.c: Use C++ exception handling.
2320         * event-top.c: Use C++ exception handling.
2321         * event-loop.c: Use C++ exception handling.
2322         * eval.c: Use C++ exception handling.
2323         * dwarf2read.c: Use C++ exception handling.
2324         * dwarf2loc.c: Use C++ exception handling.
2325         * dwarf2-frame.c: Use C++ exception handling.
2326         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2327         * dwarf-index-write.c: Use C++ exception handling.
2328         * dwarf-index-cache.c: Use C++ exception handling.
2329         * dtrace-probe.c: Use C++ exception handling.
2330         * disasm-selftests.c: Use C++ exception handling.
2331         * darwin-nat.c: Use C++ exception handling.
2332         * cp-valprint.c: Use C++ exception handling.
2333         * cp-support.c: Use C++ exception handling.
2334         * cp-abi.c: Use C++ exception handling.
2335         * corelow.c: Use C++ exception handling.
2336         * completer.c: Use C++ exception handling.
2337         * compile/compile-object-run.c: Use C++ exception handling.
2338         * compile/compile-object-load.c: Use C++ exception handling.
2339         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2340         * compile/compile-c-symbols.c: Use C++ exception handling.
2341         * common/selftest.c: Use C++ exception handling.
2342         * common/new-op.c: Use C++ exception handling.
2343         * cli/cli-script.c: Use C++ exception handling.
2344         * cli/cli-interp.c: Use C++ exception handling.
2345         * cli/cli-cmds.c: Use C++ exception handling.
2346         * c-varobj.c: Use C++ exception handling.
2347         * btrace.c: Use C++ exception handling.
2348         * breakpoint.c: Use C++ exception handling.
2349         * break-catch-throw.c: Use C++ exception handling.
2350         * arch-utils.c: Use C++ exception handling.
2351         * amd64-tdep.c: Use C++ exception handling.
2352         * ada-valprint.c: Use C++ exception handling.
2353         * ada-typeprint.c: Use C++ exception handling.
2354         * ada-lang.c: Use C++ exception handling.
2355         * aarch64-tdep.c: Use C++ exception handling.
2356
2357 2019-04-08  Tom Tromey  <tom@tromey.com>
2358
2359         * xml-support.c (gdb_xml_parser::parse): Update.
2360         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2361         * value.c (show_convenience): Update.
2362         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2363         (test_parse_flags_qcs): Update.
2364         * thread.c (thr_try_catch_cmd): Update.
2365         * target.c (target_translate_tls_address): Update.
2366         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2367         (info_frame_command_core, frame_apply_command_count): Update.
2368         * rust-exp.y (rust_lex_exception_test): Update.
2369         * riscv-tdep.c (riscv_print_one_register_info): Update.
2370         * remote.c (remote_target::enable_btrace): Update.
2371         * record-btrace.c (record_btrace_enable_warn): Update.
2372         * python/py-utils.c (gdbpy_convert_exception): Update.
2373         * printcmd.c (do_one_display, print_variable_and_value): Update.
2374         * mi/mi-main.c (mi_print_exception): Update.
2375         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2376         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2377         * linux-nat.c (linux_nat_target::attach): Update.
2378         * linux-fork.c (class scoped_switch_fork_info): Update.
2379         * infrun.c (displaced_step_prepare): Update.
2380         * infcall.c (call_function_by_hand_dummy): Update.
2381         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2382         * gnu-v3-abi.c (print_one_vtable): Update.
2383         * frame.c (get_prev_frame_always): Update.
2384         * f-valprint.c (info_common_command_for_block): Update.
2385         * exec.c (try_open_exec_file): Update.
2386         * exceptions.c (print_exception, exception_print)
2387         (exception_fprintf, exception_print_same): Update.
2388         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2389         * dwarf-index-cache.c (index_cache::store)
2390         (index_cache::lookup_gdb_index): Update.
2391         * darwin-nat.c (maybe_cache_shell): Update.
2392         * cp-valprint.c (cp_print_value_fields): Update.
2393         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2394         (gcc_cplus_symbol_address): Update.
2395         * compile/compile-c-symbols.c (gcc_convert_symbol)
2396         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2397         * common/selftest.c: Update.
2398         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2399         a std::string.
2400         (exception_try_scope_entry, exception_try_scope_exit): Don't
2401         declare.
2402         (struct exception_try_scope): Remove.
2403         (TRY): Don't use exception_try_scope.
2404         (struct gdb_exception): Add constructor, operator=.
2405         <what>: New method.
2406         (struct gdb_exception_RETURN_MASK_ALL)
2407         (struct gdb_exception_RETURN_MASK_ERROR)
2408         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2409         (struct gdb_quit_bad_alloc): Update.
2410         * common/common-exceptions.c (exception_none): Change
2411         initializer.
2412         (struct catcher) <state, exception>: Initialize inline.
2413         <prev>: Remove member.
2414         (current_catcher): Remove.
2415         (catchers): New global.
2416         (exceptions_state_mc_init): Simplify.
2417         (catcher_pop): Remove.
2418         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2419         (try_scope_depth, exception_try_scope_entry)
2420         (exception_try_scope_exit): Remove.
2421         (throw_exception_sjlj): Update.
2422         (exception_messages, exception_messages_size): Remove.
2423         (throw_it): Simplify.
2424         (gdb_exception_sliced_copy): Remove.
2425         (throw_exception_cxx): Update.
2426         * cli/cli-script.c (script_from_file): Update.
2427         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2428         Update.
2429         * ada-valprint.c (ada_val_print): Update.
2430         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2431         (create_excep_cond_exprs): Update.
2432
2433 2019-04-08  Tom Tromey  <tom@tromey.com>
2434
2435         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2436         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2437         (TRY, CATCH, END_CATCH): Remove some definitions.
2438         * common/common-exceptions.c: Don't use GDB_XCPT.
2439         (catcher_list_size): Remove.
2440         (throw_exception, throw_it): Simplify.
2441
2442 2019-04-05  Tom Tromey  <tom@tromey.com>
2443
2444         Revert the header-sorting patch.
2445         * ft32-tdep.c: Revert.
2446         * frv-tdep.c: Revert.
2447         * frv-linux-tdep.c: Revert.
2448         * frame.c: Revert.
2449         * frame-unwind.c: Revert.
2450         * frame-base.c: Revert.
2451         * fork-child.c: Revert.
2452         * findvar.c: Revert.
2453         * findcmd.c: Revert.
2454         * filesystem.c: Revert.
2455         * filename-seen-cache.h: Revert.
2456         * filename-seen-cache.c: Revert.
2457         * fbsd-tdep.c: Revert.
2458         * fbsd-nat.h: Revert.
2459         * fbsd-nat.c: Revert.
2460         * f-valprint.c: Revert.
2461         * f-typeprint.c: Revert.
2462         * f-lang.c: Revert.
2463         * extension.h: Revert.
2464         * extension.c: Revert.
2465         * extension-priv.h: Revert.
2466         * expprint.c: Revert.
2467         * exec.h: Revert.
2468         * exec.c: Revert.
2469         * exceptions.c: Revert.
2470         * event-top.c: Revert.
2471         * event-loop.c: Revert.
2472         * eval.c: Revert.
2473         * elfread.c: Revert.
2474         * dwarf2read.h: Revert.
2475         * dwarf2read.c: Revert.
2476         * dwarf2loc.c: Revert.
2477         * dwarf2expr.h: Revert.
2478         * dwarf2expr.c: Revert.
2479         * dwarf2-frame.c: Revert.
2480         * dwarf2-frame-tailcall.c: Revert.
2481         * dwarf-index-write.h: Revert.
2482         * dwarf-index-write.c: Revert.
2483         * dwarf-index-common.c: Revert.
2484         * dwarf-index-cache.h: Revert.
2485         * dwarf-index-cache.c: Revert.
2486         * dummy-frame.c: Revert.
2487         * dtrace-probe.c: Revert.
2488         * disasm.h: Revert.
2489         * disasm.c: Revert.
2490         * disasm-selftests.c: Revert.
2491         * dictionary.c: Revert.
2492         * dicos-tdep.c: Revert.
2493         * demangle.c: Revert.
2494         * dcache.h: Revert.
2495         * dcache.c: Revert.
2496         * darwin-nat.h: Revert.
2497         * darwin-nat.c: Revert.
2498         * darwin-nat-info.c: Revert.
2499         * d-valprint.c: Revert.
2500         * d-namespace.c: Revert.
2501         * d-lang.c: Revert.
2502         * ctf.c: Revert.
2503         * csky-tdep.c: Revert.
2504         * csky-linux-tdep.c: Revert.
2505         * cris-tdep.c: Revert.
2506         * cris-linux-tdep.c: Revert.
2507         * cp-valprint.c: Revert.
2508         * cp-support.c: Revert.
2509         * cp-namespace.c: Revert.
2510         * cp-abi.c: Revert.
2511         * corelow.c: Revert.
2512         * corefile.c: Revert.
2513         * continuations.c: Revert.
2514         * completer.h: Revert.
2515         * completer.c: Revert.
2516         * complaints.c: Revert.
2517         * coffread.c: Revert.
2518         * coff-pe-read.c: Revert.
2519         * cli-out.h: Revert.
2520         * cli-out.c: Revert.
2521         * charset.c: Revert.
2522         * c-varobj.c: Revert.
2523         * c-valprint.c: Revert.
2524         * c-typeprint.c: Revert.
2525         * c-lang.c: Revert.
2526         * buildsym.c: Revert.
2527         * buildsym-legacy.c: Revert.
2528         * build-id.h: Revert.
2529         * build-id.c: Revert.
2530         * btrace.c: Revert.
2531         * bsd-uthread.c: Revert.
2532         * breakpoint.h: Revert.
2533         * breakpoint.c: Revert.
2534         * break-catch-throw.c: Revert.
2535         * break-catch-syscall.c: Revert.
2536         * break-catch-sig.c: Revert.
2537         * blockframe.c: Revert.
2538         * block.c: Revert.
2539         * bfin-tdep.c: Revert.
2540         * bfin-linux-tdep.c: Revert.
2541         * bfd-target.c: Revert.
2542         * bcache.c: Revert.
2543         * ax-general.c: Revert.
2544         * ax-gdb.h: Revert.
2545         * ax-gdb.c: Revert.
2546         * avr-tdep.c: Revert.
2547         * auxv.c: Revert.
2548         * auto-load.c: Revert.
2549         * arm-wince-tdep.c: Revert.
2550         * arm-tdep.c: Revert.
2551         * arm-symbian-tdep.c: Revert.
2552         * arm-pikeos-tdep.c: Revert.
2553         * arm-obsd-tdep.c: Revert.
2554         * arm-nbsd-tdep.c: Revert.
2555         * arm-nbsd-nat.c: Revert.
2556         * arm-linux-tdep.c: Revert.
2557         * arm-linux-nat.c: Revert.
2558         * arm-fbsd-tdep.c: Revert.
2559         * arm-fbsd-nat.c: Revert.
2560         * arm-bsd-tdep.c: Revert.
2561         * arch-utils.c: Revert.
2562         * arc-tdep.c: Revert.
2563         * arc-newlib-tdep.c: Revert.
2564         * annotate.h: Revert.
2565         * annotate.c: Revert.
2566         * amd64-windows-tdep.c: Revert.
2567         * amd64-windows-nat.c: Revert.
2568         * amd64-tdep.c: Revert.
2569         * amd64-sol2-tdep.c: Revert.
2570         * amd64-obsd-tdep.c: Revert.
2571         * amd64-obsd-nat.c: Revert.
2572         * amd64-nbsd-tdep.c: Revert.
2573         * amd64-nbsd-nat.c: Revert.
2574         * amd64-nat.c: Revert.
2575         * amd64-linux-tdep.c: Revert.
2576         * amd64-linux-nat.c: Revert.
2577         * amd64-fbsd-tdep.c: Revert.
2578         * amd64-fbsd-nat.c: Revert.
2579         * amd64-dicos-tdep.c: Revert.
2580         * amd64-darwin-tdep.c: Revert.
2581         * amd64-bsd-nat.c: Revert.
2582         * alpha-tdep.c: Revert.
2583         * alpha-obsd-tdep.c: Revert.
2584         * alpha-nbsd-tdep.c: Revert.
2585         * alpha-mdebug-tdep.c: Revert.
2586         * alpha-linux-tdep.c: Revert.
2587         * alpha-linux-nat.c: Revert.
2588         * alpha-bsd-tdep.c: Revert.
2589         * alpha-bsd-nat.c: Revert.
2590         * aix-thread.c: Revert.
2591         * agent.c: Revert.
2592         * addrmap.c: Revert.
2593         * ada-varobj.c: Revert.
2594         * ada-valprint.c: Revert.
2595         * ada-typeprint.c: Revert.
2596         * ada-tasks.c: Revert.
2597         * ada-lang.c: Revert.
2598         * aarch64-tdep.c: Revert.
2599         * aarch64-ravenscar-thread.c: Revert.
2600         * aarch64-newlib-tdep.c: Revert.
2601         * aarch64-linux-tdep.c: Revert.
2602         * aarch64-linux-nat.c: Revert.
2603         * aarch64-fbsd-tdep.c: Revert.
2604         * aarch64-fbsd-nat.c: Revert.
2605         * aarch32-linux-nat.c: Revert.
2606
2607 2019-04-05  Tom Tromey  <tom@tromey.com>
2608
2609         * ft32-tdep.c: Sort headers.
2610         * frv-tdep.c: Sort headers.
2611         * frv-linux-tdep.c: Sort headers.
2612         * frame.c: Sort headers.
2613         * frame-unwind.c: Sort headers.
2614         * frame-base.c: Sort headers.
2615         * fork-child.c: Sort headers.
2616         * findvar.c: Sort headers.
2617         * findcmd.c: Sort headers.
2618         * filesystem.c: Sort headers.
2619         * filename-seen-cache.h: Sort headers.
2620         * filename-seen-cache.c: Sort headers.
2621         * fbsd-tdep.c: Sort headers.
2622         * fbsd-nat.h: Sort headers.
2623         * fbsd-nat.c: Sort headers.
2624         * f-valprint.c: Sort headers.
2625         * f-typeprint.c: Sort headers.
2626         * f-lang.c: Sort headers.
2627         * extension.h: Sort headers.
2628         * extension.c: Sort headers.
2629         * extension-priv.h: Sort headers.
2630         * expprint.c: Sort headers.
2631         * exec.h: Sort headers.
2632         * exec.c: Sort headers.
2633         * exceptions.c: Sort headers.
2634         * event-top.c: Sort headers.
2635         * event-loop.c: Sort headers.
2636         * eval.c: Sort headers.
2637         * elfread.c: Sort headers.
2638         * dwarf2read.h: Sort headers.
2639         * dwarf2read.c: Sort headers.
2640         * dwarf2loc.c: Sort headers.
2641         * dwarf2expr.h: Sort headers.
2642         * dwarf2expr.c: Sort headers.
2643         * dwarf2-frame.c: Sort headers.
2644         * dwarf2-frame-tailcall.c: Sort headers.
2645         * dwarf-index-write.h: Sort headers.
2646         * dwarf-index-write.c: Sort headers.
2647         * dwarf-index-common.c: Sort headers.
2648         * dwarf-index-cache.h: Sort headers.
2649         * dwarf-index-cache.c: Sort headers.
2650         * dummy-frame.c: Sort headers.
2651         * dtrace-probe.c: Sort headers.
2652         * disasm.h: Sort headers.
2653         * disasm.c: Sort headers.
2654         * disasm-selftests.c: Sort headers.
2655         * dictionary.c: Sort headers.
2656         * dicos-tdep.c: Sort headers.
2657         * demangle.c: Sort headers.
2658         * dcache.h: Sort headers.
2659         * dcache.c: Sort headers.
2660         * darwin-nat.h: Sort headers.
2661         * darwin-nat.c: Sort headers.
2662         * darwin-nat-info.c: Sort headers.
2663         * d-valprint.c: Sort headers.
2664         * d-namespace.c: Sort headers.
2665         * d-lang.c: Sort headers.
2666         * ctf.c: Sort headers.
2667         * csky-tdep.c: Sort headers.
2668         * csky-linux-tdep.c: Sort headers.
2669         * cris-tdep.c: Sort headers.
2670         * cris-linux-tdep.c: Sort headers.
2671         * cp-valprint.c: Sort headers.
2672         * cp-support.c: Sort headers.
2673         * cp-namespace.c: Sort headers.
2674         * cp-abi.c: Sort headers.
2675         * corelow.c: Sort headers.
2676         * corefile.c: Sort headers.
2677         * continuations.c: Sort headers.
2678         * completer.h: Sort headers.
2679         * completer.c: Sort headers.
2680         * complaints.c: Sort headers.
2681         * coffread.c: Sort headers.
2682         * coff-pe-read.c: Sort headers.
2683         * cli-out.h: Sort headers.
2684         * cli-out.c: Sort headers.
2685         * charset.c: Sort headers.
2686         * c-varobj.c: Sort headers.
2687         * c-valprint.c: Sort headers.
2688         * c-typeprint.c: Sort headers.
2689         * c-lang.c: Sort headers.
2690         * buildsym.c: Sort headers.
2691         * buildsym-legacy.c: Sort headers.
2692         * build-id.h: Sort headers.
2693         * build-id.c: Sort headers.
2694         * btrace.c: Sort headers.
2695         * bsd-uthread.c: Sort headers.
2696         * breakpoint.h: Sort headers.
2697         * breakpoint.c: Sort headers.
2698         * break-catch-throw.c: Sort headers.
2699         * break-catch-syscall.c: Sort headers.
2700         * break-catch-sig.c: Sort headers.
2701         * blockframe.c: Sort headers.
2702         * block.c: Sort headers.
2703         * bfin-tdep.c: Sort headers.
2704         * bfin-linux-tdep.c: Sort headers.
2705         * bfd-target.c: Sort headers.
2706         * bcache.c: Sort headers.
2707         * ax-general.c: Sort headers.
2708         * ax-gdb.h: Sort headers.
2709         * ax-gdb.c: Sort headers.
2710         * avr-tdep.c: Sort headers.
2711         * auxv.c: Sort headers.
2712         * auto-load.c: Sort headers.
2713         * arm-wince-tdep.c: Sort headers.
2714         * arm-tdep.c: Sort headers.
2715         * arm-symbian-tdep.c: Sort headers.
2716         * arm-pikeos-tdep.c: Sort headers.
2717         * arm-obsd-tdep.c: Sort headers.
2718         * arm-nbsd-tdep.c: Sort headers.
2719         * arm-nbsd-nat.c: Sort headers.
2720         * arm-linux-tdep.c: Sort headers.
2721         * arm-linux-nat.c: Sort headers.
2722         * arm-fbsd-tdep.c: Sort headers.
2723         * arm-fbsd-nat.c: Sort headers.
2724         * arm-bsd-tdep.c: Sort headers.
2725         * arch-utils.c: Sort headers.
2726         * arc-tdep.c: Sort headers.
2727         * arc-newlib-tdep.c: Sort headers.
2728         * annotate.h: Sort headers.
2729         * annotate.c: Sort headers.
2730         * amd64-windows-tdep.c: Sort headers.
2731         * amd64-windows-nat.c: Sort headers.
2732         * amd64-tdep.c: Sort headers.
2733         * amd64-sol2-tdep.c: Sort headers.
2734         * amd64-obsd-tdep.c: Sort headers.
2735         * amd64-obsd-nat.c: Sort headers.
2736         * amd64-nbsd-tdep.c: Sort headers.
2737         * amd64-nbsd-nat.c: Sort headers.
2738         * amd64-nat.c: Sort headers.
2739         * amd64-linux-tdep.c: Sort headers.
2740         * amd64-linux-nat.c: Sort headers.
2741         * amd64-fbsd-tdep.c: Sort headers.
2742         * amd64-fbsd-nat.c: Sort headers.
2743         * amd64-dicos-tdep.c: Sort headers.
2744         * amd64-darwin-tdep.c: Sort headers.
2745         * amd64-bsd-nat.c: Sort headers.
2746         * alpha-tdep.c: Sort headers.
2747         * alpha-obsd-tdep.c: Sort headers.
2748         * alpha-nbsd-tdep.c: Sort headers.
2749         * alpha-mdebug-tdep.c: Sort headers.
2750         * alpha-linux-tdep.c: Sort headers.
2751         * alpha-linux-nat.c: Sort headers.
2752         * alpha-bsd-tdep.c: Sort headers.
2753         * alpha-bsd-nat.c: Sort headers.
2754         * aix-thread.c: Sort headers.
2755         * agent.c: Sort headers.
2756         * addrmap.c: Sort headers.
2757         * ada-varobj.c: Sort headers.
2758         * ada-valprint.c: Sort headers.
2759         * ada-typeprint.c: Sort headers.
2760         * ada-tasks.c: Sort headers.
2761         * ada-lang.c: Sort headers.
2762         * aarch64-tdep.c: Sort headers.
2763         * aarch64-ravenscar-thread.c: Sort headers.
2764         * aarch64-newlib-tdep.c: Sort headers.
2765         * aarch64-linux-tdep.c: Sort headers.
2766         * aarch64-linux-nat.c: Sort headers.
2767         * aarch64-fbsd-tdep.c: Sort headers.
2768         * aarch64-fbsd-nat.c: Sort headers.
2769         * aarch32-linux-nat.c: Sort headers.
2770
2771 2019-04-04  Tom Tromey  <tom@tromey.com>
2772
2773         * varobj.c (varobj_create): Update.
2774         * rust-exp.y (struct rust_parser) <update_innermost_block,
2775         lookup_symbol>: New methods.
2776         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2777         Rename.
2778         (rust_parser::rust_lookup_type)
2779         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2780         * printcmd.c (display_command, do_one_display): Update.
2781         * parser-defs.h (struct parser_state) <parser_state>: Add
2782         "tracker" parameter.
2783         (block_tracker): New member.
2784         (class innermost_block_tracker) <innermost_block_tracker>: Add
2785         "types" parameter.
2786         <reset>: Remove method.
2787         (innermost_block): Don't declare.
2788         (null_post_parser): Update.
2789         * parse.c (innermost_block): Remove global.
2790         (write_dollar_variable): Update.
2791         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2792         Remove "tracker_types" parameter.
2793         (parse_expression): Add "tracker" parameter.
2794         (parse_expression_for_completion): Update.
2795         (null_post_parser): Add "tracker" parameter.
2796         * p-exp.y: Update rules.
2797         * m2-exp.y: Update rules.
2798         * language.h (struct language_defn) <la_post_parser>: Add
2799         "tracker" parameter.
2800         * go-exp.y: Update rules.
2801         * f-exp.y: Update rules.
2802         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2803         parameter.
2804         * d-exp.y: Update rules.
2805         * c-exp.y: Update rules.
2806         * breakpoint.c (set_breakpoint_condition): Create an
2807         innermost_block_tracker.
2808         (watch_command_1): Likewise.
2809         * ada-lang.c (resolve): Add "tracker" parameter.
2810         (resolve_subexp): Likewise.
2811         * ada-exp.y (write_var_from_sym): Update.
2812
2813 2019-04-04  Tom Tromey  <tom@tromey.com>
2814
2815         * type-stack.h: New file.
2816         * type-stack.c: New file.
2817         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2818         type-stack.h.
2819         (insert_into_type_stack, insert_type, push_type, push_type_int)
2820         (insert_type_address_space, pop_type, pop_type_int)
2821         (pop_typelist, pop_type_stack, append_type_stack)
2822         (push_type_stack, get_type_stack, push_typelist)
2823         (follow_type_instance_flags, follow_types): Don't declare.
2824         * parse.c (type_stack): Remove global.
2825         (parse_exp_in_context): Update.
2826         (insert_into_type_stack, insert_type, push_type, push_type_int)
2827         (insert_type_address_space, pop_type, pop_type_int)
2828         (pop_typelist, pop_type_stack, append_type_stack)
2829         (push_type_stack, get_type_stack, push_typelist)
2830         (follow_type_instance_flags, follow_types): Remove (moved to
2831         type-stack.c).
2832         * f-exp.y (type_stack): New global.
2833         Update rules.
2834         (push_kind_type, f_parse): Update.
2835         * d-exp.y (type_stack): New global.
2836         Update rules.
2837         (d_parse): Update.
2838         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2839         Update rules.
2840         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2841         (HFILES_NO_SRCDIR): Add type-stack.h.
2842
2843 2019-04-04  Tom Tromey  <tom@tromey.com>
2844
2845         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2846         (rust_parser::convert_ast_to_expression, rust_parse)
2847         (rust_lex_test_completion, rust_lex_tests): Update.
2848         * parser-defs.h (struct expr_completion_state): New.
2849         (struct parser_state) <parser_state>: Add completion parameter.
2850         <mark_struct_expression, mark_completion_tag>: New methods.
2851         <parse_completion, m_completion_state>: New members.
2852         (prefixify_expression, null_post_parser): Update.
2853         (mark_struct_expression, mark_completion_tag): Don't declare.
2854         * parse.c (parse_completion, expout_last_struct)
2855         (expout_tag_completion_type, expout_completion_name): Remove
2856         globals.
2857         (parser_state::mark_struct_expression)
2858         (parser_state::mark_completion_tag): Now methods.
2859         (prefixify_expression): Add last_struct parameter.
2860         (prefixify_subexp): Likewise.
2861         (parse_exp_1): Update.
2862         (parse_exp_in_context): Add cstate parameter.  Update.
2863         (parse_expression_for_completion): Create an
2864         expr_completion_state.
2865         (null_post_parser): Add "completion" parameter.
2866         * p-exp.y: Update rules.
2867         (yylex): Update.
2868         * language.h (struct language_defn) <la_post_parser>: Add
2869         "completing" parameter.
2870         * go-exp.y: Update rules.
2871         (lex_one_token): Update.
2872         * expression.h (parse_completion): Don't declare.
2873         * d-exp.y: Update rules.
2874         (lex_one_token): Update rules.
2875         * c-exp.y: Update rules.
2876         (lex_one_token): Update.
2877         * ada-lang.c (resolve): Add "parse_completion" parameter.
2878         (resolve_subexp): Likewise.
2879         (ada_resolve_function): Likewise.
2880
2881 2019-04-04  Tom Tromey  <tom@tromey.com>
2882
2883         * parser-defs.h (struct parser_state) <start_arglist,
2884         end_arglist>: New methods.
2885         <arglist_len, m_funcall_chain>: New members.
2886         (arglist_len, start_arglist, end_arglist): Don't declare.
2887         * parse.c (arglist_len, funcall_chain): Remove global.
2888         (start_arglist, end_arglist): Remove functions.
2889         (parse_exp_in_context): Update.
2890         * p-exp.y: Update rules.
2891         * m2-exp.y: Update rules.
2892         * go-exp.y: Update rules.
2893         * f-exp.y: Update rules.
2894         * d-exp.y: Update rules.
2895         * c-exp.y: Update rules.
2896
2897 2019-04-04  Tom Tromey  <tom@tromey.com>
2898
2899         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2900         lex_operator, push_back>: New methods.
2901         Update all rules.
2902         (rust_parser::lex_hex, lex_escape): Rename and update.
2903         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2904         (rust_parser::lex_operator): Rename and update.
2905         (rust_parser::lex_number, rustyylex, rustyyerror)
2906         (rust_lex_test_init, rust_lex_test_sequence)
2907         (rust_lex_test_push_back, rust_lex_tests): Update.
2908         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2909         parameter.
2910         <lexptr, prev_lexptr>: New members.
2911         (lexptr, prev_lexptr): Don't declare.
2912         * parse.c (lexptr, prev_lexptr): Remove globals.
2913         (parse_exp_in_context): Update.
2914         * p-exp.y (yylex, yyerror): Update.
2915         * m2-exp.y (parse_number, yylex, yyerror): Update.
2916         * go-exp.y (lex_one_token, yyerror): Update.
2917         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2918         * d-exp.y (lex_one_token, yyerror): Update.
2919         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2920         (lex_one_token, yyerror): Update.
2921         * ada-lex.l (YY_INPUT): Update.
2922         (rewind_to_char): Update.
2923         * ada-exp.y (yyerror): Update.
2924
2925 2019-04-04  Tom Tromey  <tom@tromey.com>
2926
2927         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2928         * parser-defs.h (struct parser_state) <parser_state>: Add new
2929         parameter.
2930         <comma_terminates>: New member.
2931         (comma_terminates): Don't declare global.
2932         * parse.c (comma_terminates): Remove global.
2933         (parse_exp_in_context): Update.
2934         * p-exp.y (yylex): Update.
2935         * m2-exp.y (yylex): Update.
2936         * go-exp.y (lex_one_token): Update.
2937         * f-exp.y (yylex): Update.
2938         * d-exp.y (lex_one_token): Update.
2939         * c-exp.y (lex_one_token): Update.
2940         * ada-lex.l: Update.
2941
2942 2019-04-04  Tom Tromey  <tom@tromey.com>
2943
2944         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2945         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2946         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2947         * parser-defs.h (paren_depth): Don't declare.
2948         * parse.c (paren_depth): Remove global.
2949         (parse_exp_in_context): Update.
2950         * p-exp.y (paren_depth): New global.
2951         (pascal_parse): Initialize it.
2952         * m2-exp.y (paren_depth): New global.
2953         (m2_parse): Initialize it.
2954         * go-exp.y (paren_depth): New global.
2955         (go_parse): Initialize it.
2956         * f-exp.y (paren_depth): New global.
2957         (f_parse): Initialize it.
2958         * d-exp.y (paren_depth): New global.
2959         (d_parse): Initialize it.
2960         * c-exp.y (paren_depth): New global.
2961         (c_parse): Initialize it.
2962         * ada-lex.l (paren_depth): New global.
2963         (lexer_init): Initialize it.
2964
2965 2019-04-04  Tom Tromey  <tom@tromey.com>
2966
2967         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2968         (rust_parser::convert_ast_to_type)
2969         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2970         * parser-defs.h (struct parser_state) <parser_state>: Add
2971         parameters.  Initialize new members.
2972         <expression_context_block, expression_context_pc>: New members.
2973         * parse.c (expression_context_block, expression_context_pc):
2974         Remove globals.
2975         (parse_exp_in_context): Update.
2976         * p-exp.y: Update all rules.
2977         (yylex): Update.
2978         * m2-exp.y: Update all rules.
2979         (yylex): Update.
2980         * go-exp.y (yylex): Update.
2981         * f-exp.y (yylex): Update.
2982         * d-exp.y: Update all rules.
2983         (yylex): Update.
2984         * c-exp.y: Update all rules.
2985         (lex_one_token, classify_name, yylex, c_parse): Update.
2986         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2987
2988 2019-04-04  Tom Tromey  <tom@tromey.com>
2989
2990         * gdbarch.h, gdbarch.c: Rebuild.
2991         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2992         * stap-probe.h:
2993         (struct stap_parse_info): Replace "parser_state" with
2994         "expr_builder".
2995         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2996         (parser_state): New class.
2997         * parse.c (expr_builder): Rename.
2998         (expr_builder::release): Rename.
2999         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3000         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3001         (write_exp_elt_longcst, write_exp_elt_floatcst)
3002         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3003         (write_exp_string_vector, write_exp_bitstring)
3004         (write_exp_msymbol, mark_struct_expression)
3005         (write_dollar_variable)
3006         (insert_type_address_space, increase_expout_size): Replace
3007         "parser_state" with "expr_builder".
3008         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3009         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3010         "parser_state" with "expr_builder".
3011
3012 2019-04-04  Tom Tromey  <tom@tromey.com>
3013
3014         * rust-exp.y: Replace "parse_language" with method call.
3015         * p-exp.y:
3016         (yylex): Replace "parse_language" with method call.
3017         * m2-exp.y:
3018         (yylex): Replace "parse_language" with method call.
3019         * go-exp.y (classify_name): Replace "parse_language" with method
3020         call.
3021         * f-exp.y (yylex): Replace "parse_language" with method call.
3022         * d-exp.y (lex_one_token): Replace "parse_language" with method
3023         call.
3024         * c-exp.y:
3025         (lex_one_token, classify_name, yylex): Replace "parse_language"
3026         with method call.
3027         * ada-exp.y (find_primitive_type, type_char)
3028         (type_system_address): Replace "parse_language" with method call.
3029
3030 2019-04-04  Tom Tromey  <tom@tromey.com>
3031
3032         * rust-exp.y: Replace "parse_gdbarch" with method call.
3033         * parse.c (write_dollar_variable, insert_type_address_space):
3034         Replace "parse_gdbarch" with method call.
3035         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3036         call.
3037         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3038         call.
3039         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3040         "parse_gdbarch" with method call.
3041         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3042         with method call.
3043         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3044         "parse_gdbarch" with method call.
3045         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3046         "parse_gdbarch" with method call.
3047         * c-exp.y (parse_type, parse_number, classify_name): Replace
3048         "parse_gdbarch" with method call.
3049         * ada-lex.l: Replace "parse_gdbarch" with method call.
3050         * ada-exp.y (parse_type, find_primitive_type, type_char)
3051         (type_system_address): Replace "parse_gdbarch" with method call.
3052
3053 2019-04-04  Tom Tromey  <tom@tromey.com>
3054
3055         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3056         * stap-probe.c (stap_parse_argument): Update.
3057         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3058         initial_size parameter.
3059         * rust-exp.y (rust_lex_tests): Update.
3060         * parse.c (parser_state): Update.
3061         (parse_exp_in_context): Update.
3062         * parser-defs.h (struct parser_state) <parser_state>: Remove
3063         "initial_size" parameter.
3064
3065 2019-04-04  Tom Tromey  <tom@tromey.com>
3066
3067         * parser-defs.h (increase_expout_size): Don't declare.
3068         * parse.c (increase_expout_size): Now static.
3069
3070 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3071
3072         * gnu-nat.c (gnu_nat_target::wait): Fix
3073         target_waitstatus_to_string call.
3074
3075 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * eval.c (evaluate_subexp_standard): Handle internal functions
3078         during Fortran function call handling.
3079
3080 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * NEWS: Mention new internal functions.
3083         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3084         (read_base_type): Use dwarf2_init_complex_target_type.
3085         * value.c (creal_internal_fn): New function.
3086         (cimag_internal_fn): New function.
3087         (_initialize_values): Register new internal functions.
3088
3089 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3090
3091         * infrun.c (stop_all_threads): If debug_infrun, always
3092         trace the wait status after wait_one, using
3093         target_waitstatus_to_string and target_pid_to_str.
3094         (handle_inferior_event): Replace various trace of
3095         wait status kind by a single trace.
3096         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3097         wait status kind image by target_waitstatus_to_string.
3098         * target/waitstatus.c (target_waitstatus_to_string): Fix
3099         obsolete comment.
3100
3101 2019-04-01  Tom Tromey  <tromey@adacore.com>
3102
3103         PR symtab/23331:
3104         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3105
3106 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3107             Pedro Alves  <palves@redhat.com>
3108
3109         * top.c (quit_force): Call 'finalize_values'.
3110         * value.c (finalize_values): New function.
3111         * value.h (finalize_values): Declare.
3112
3113 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3114
3115         * NEWS: Announce $_gdb_major and $_gdb_minor.
3116
3117         * top.c (init_gdb_version_vars): New function.
3118         (gdb_init): Call init_gdb_version_vars.
3119
3120 2019-03-29  Tom Tromey  <tromey@adacore.com>
3121
3122         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3123         help text.  Remove dead code.
3124
3125 2019-03-29  Keith Seitz  <keiths@redhat.com>
3126
3127         From Siddhesh Poyarekar:
3128         * f-lang.h (f77_get_upperbound): Return LONGEST.
3129         (f77_get_lowerbound): Likewise.
3130         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3131         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3132         print them.
3133         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3134         plongest to format print it.
3135         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3136         (f77_get_upperbound): Likewise.
3137         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3138         LOWER_BOUND to LONGEST.
3139         (f77_create_arrayprint_offset_tbl): Likewise.
3140
3141 2019-03-29  Keith Seitz  <keiths@redhat.com>
3142
3143         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3144         %s/pulongest for TYPE_LENGTH instead of %d in format
3145         strings.
3146         * ada-typerint.c (ada_print_type): Likewise.
3147         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3148         * compile/compile-c-support.c (generate_register_struct): Likewise.
3149         * gdbtypes.c (recursive_dump_type): Likewise.
3150         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3151         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3152         instead of %d in format strings.
3153         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3154         to std::min to ULONGEST.
3155         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3156         instead of %d in format strings.
3157         * tracepoint.c (info_scope_command): Likewise.
3158         * typeprint.c (print_offset_data::update)
3159         (print_offset_data::finish): Likewise.
3160         * xtensa-tdep.c (xtensa_store_return_value)
3161         (xtensa_push_dummy_call): Likewise.
3162
3163 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3164
3165         * windows-nat.c (display_selector): Fixed format specifications
3166         for 64-bit Cygwin.
3167
3168 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3169
3170         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3171
3172 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3173
3174         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3175         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3176         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3177         (nios2_linux_init_abi): Install it.
3178
3179 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3180
3181         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3182
3183 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3184
3185         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3186
3187 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3188             Tom Tromey  <tromey@adacore.com>
3189
3190         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3191
3192 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3193
3194         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3195         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3196         method to compute the bounds of range types. Also print "[evaluated]"
3197         if the bounds' values come from a dynamic evaluation.
3198
3199 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3202         whitespace when pretty printing is on.
3203
3204 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3205
3206         * ppc-linux-nat.c: Add include.
3207
3208 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3209
3210         * NEWS: Mention AArch64 Pointer Authentication.
3211
3212 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3213
3214         * arm-linux-nat.c: Add include.
3215
3216 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3217
3218         * source-cache.c (source_cache::get_source_lines): Re-read
3219         fullname after calling open_source_file.
3220
3221 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3222
3223         * NEWS: Mention TLS support for FreeBSD.
3224
3225 2019-03-25  Tom Tromey  <tromey@adacore.com>
3226
3227         * minsyms.c (BUNCH_SIZE): Update comment.
3228         (~minimal_symbol_reader): Remove old comment.
3229         (compact_minimal_symbols): Update comment.
3230         (minimal_symbol_reader::install): Remove old comment.  Update
3231         other comments.
3232
3233 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3234
3235         * s390-linux-nat.c: Add include.
3236
3237 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3238
3239         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3240         Call linux_get_hwcap.
3241         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3242         Likewise.
3243         (aarch64_linux_get_hwcap): Remove function.
3244         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3245         declaration.
3246         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3247         linux_get_hwcap.
3248         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3249         * linux-tdep.c (linux_get_hwcap): Add function.
3250         (linux_get_hwcap2): Likewise.
3251         * linux-tdep.h (linux_get_hwcap): Add declaration.
3252         (linux_get_hwcap2): Likewise.
3253         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3254         (ppc_linux_get_hwcap2): Likewise.
3255         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3256         linux_get_hwcap.
3257         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3258         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3259         (ppc_linux_nat_target::read_description): Likewise.
3260         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3261         * s390-linux-nat.c: Likewise.
3262         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3263
3264 2019-03-24  Tom Tromey  <tom@tromey.com>
3265
3266         * ada-lang.c (standard_lookup): Simplify initialization.
3267         (ada_lookup_symbol_nonlocal): Simplify return.
3268         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3269         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3270         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3271         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3272         initialization.
3273         * solib.c (solib_global_lookup): Simplify.
3274         * symtab.c (null_block_symbol): Remove.
3275         (symbol_cache_lookup): Simplify returns.
3276         (lookup_language_this): Simplify returns.
3277         (lookup_symbol_aux): Simplify return.
3278         (lookup_local_symbol): Simplify returns.
3279         (lookup_global_symbol_from_objfile): Simplify return.
3280         (lookup_symbol_in_objfile_symtabs)
3281         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3282         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3283         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3284         * cp-namespace.c (cp_lookup_bare_symbol)
3285         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3286         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3287         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3288         (cp_lookup_symbol_via_imports): Simplify initialization.
3289         (find_symbol_in_baseclass): Likewise.
3290         * symtab.h (null_block_symbol): Remove.
3291         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3292         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3293         (d_lookup_symbol_module): Likewise.
3294         (find_symbol_in_baseclass): Simplify initialization.
3295
3296 2019-03-24  Tom Tromey  <tom@tromey.com>
3297
3298         * expression.h: Don't include symtab.h.
3299         (struct block): Forward declare.
3300
3301 2019-03-24  Tom Tromey  <tom@tromey.com>
3302
3303         * c-exp.y (typebase): Remove casts.
3304         * gdbtypes.c (lookup_unsigned_typename, )
3305         (lookup_signed_typename): Remove cast.
3306         * eval.c (parse_to_comma_and_eval): Remove cast.
3307         * parse.c (write_dollar_variable): Remove cast.
3308         * block.h (struct block) <superblock>: Now const.
3309         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3310         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3311         (map_block): Make "block" const.
3312         * symfile.h (struct quick_symbol_functions)
3313         <map_matching_symbols>: Constify block argument to "callback".
3314         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3315         const.
3316         (find_pc_sect_compunit_symtab): Make "b" const.
3317         (find_symbol_at_address): Likewise.
3318         (search_symbols): Likewise.
3319         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3320         (dw2_debug_names_lookup_symbol): Likewise.
3321         (dw2_map_matching_symbols): Update.
3322         * p-valprint.c (pascal_val_print): Remove "block".
3323         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3324         (aux_add_nonlocal_symbols): Make "block" const.
3325         (resolve_subexp): Remove cast.
3326         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3327         const.
3328         (iterate_over_file_blocks): Likewise.
3329         * f-exp.y (%union) <bval>: Remove.
3330         * coffread.c (patch_opaque_types): Make "b" const.
3331         * spu-tdep.c (spu_catch_start): Make "block" const.
3332         * c-valprint.c (print_unpacked_pointer): Remove "block".
3333         * symmisc.c (dump_symtab_1): Make "b" const.
3334         (block_depth): Make "block" const.
3335         * d-exp.y (%union) <bval>: Remove.
3336         * cp-support.h (cp_lookup_rtti_type): Update.
3337         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3338         * psymtab.c (psym_lookup_symbol): Make "block" const.
3339         (maintenance_check_psymtabs): Make "b" const.
3340         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3341         (enumerate_locals, enumerate_args): Update.
3342         * python/py-symtab.c (stpy_global_block): Make "block" const.
3343         (stpy_static_block): Likewise.
3344         * inline-frame.c (block_starting_point_at): Make "new_block"
3345         const.
3346         * block.c (find_block_in_blockvector): Make return type const.
3347         (blockvector_for_pc_sect): Make "b" const.
3348         (find_block_in_blockvector): Make "b" const.
3349
3350 2019-03-23  Tom Tromey  <tom@tromey.com>
3351
3352         * varobj.c (varobj_create): Update.
3353         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3354         * printcmd.c (display_command, do_one_display): Don't reset
3355         innermost_block.
3356         * parser-defs.h (enum innermost_block_tracker_type): Move to
3357         expression.h.
3358         (innermost_block): Update comment.
3359         * parse.c (parse_exp_1): Add tracker_types parameter.
3360         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3361         tracker_types parameter.  Reset innermost_block.
3362         (parse_exp_in_context): Remove.
3363         (parse_expression_for_completion): Update.
3364         * objfiles.c (~objfile): Don't reset expression_context_block or
3365         innermost_block.
3366         * expression.h (enum innermost_block_tracker_type): Move from
3367         parser-defs.h.
3368         (parse_exp_1): Add tracker_types parameter.
3369         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3370         reset innermost_block.
3371
3372 2019-03-23  Tom Tromey  <tom@tromey.com>
3373
3374         * objfiles.h: Include bcache.h.
3375
3376 2019-03-23  Tom Tromey  <tom@tromey.com>
3377
3378         * linespec.c (get_current_search_block): Use
3379         scoped_restore_current_language.
3380         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3381
3382 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3383             Jiong Wang  <jiong.wang@arm.com>
3384
3385         * aarch64-linux-tdep.c
3386         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3387         section.
3388         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3389
3390 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3391             Jiong Wang  <jiong.wang@arm.com>
3392
3393         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3394         instructions.
3395         (aarch64_analyze_prologue_test): Add PACIASP test.
3396         (aarch64_prologue_prev_register): Unmask PC value.
3397
3398 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3399             Jiong Wang  <jiong.wang@arm.com>
3400
3401         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3402         (aarch64_dwarf2_prev_register): Unmask PC value.
3403         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3404         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3405         DW_CFA_AARCH64_negate_ra_state.
3406         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3407
3408 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3409             Jiong Wang  <jiong.wang@arm.com>
3410
3411         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3412         registers.
3413         (aarch64_pseudo_register_name): Likewise.
3414         (aarch64_pseudo_register_type): Likewise.
3415         (aarch64_pseudo_register_reggroup_p): Likewise.
3416         (aarch64_gdbarch_init): Add pauth registers.
3417         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3418         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3419         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3420         (struct gdbarch_tdep): Add regnum for ra_state.
3421
3422 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3423             Jiong Wang  <jiong.wang@arm.com>
3424
3425         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3426
3427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3428             Jiong Wang  <jiong.wang@arm.com>
3429
3430         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3431         function.
3432         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3433         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3434         (aarch64_gdbarch_init): Add puth registers.
3435         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3436         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3437         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3438
3439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3440             Jiong Wang  <jiong.wang@arm.com>
3441
3442         * aarch64-linux-nat.c
3443         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3444         * aarch64-linux-tdep.c
3445         (aarch64_linux_core_read_description): Likewise.
3446         (aarch64_linux_get_hwcap): New function.
3447         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3448         (aarch64_linux_get_hwcap): New declaration.
3449
3450 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3451             Jiong Wang  <jiong.wang@arm.com>
3452
3453         * aarch64-linux-nat.c
3454         (aarch64_linux_nat_target::read_description): Add pauth param.
3455         * aarch64-linux-tdep.c
3456         (aarch64_linux_core_read_description): Likewise.
3457         * aarch64-tdep.c (struct target_desc): Add in pauth.
3458         (aarch64_read_description): Add pauth param.
3459         (aarch64_gdbarch_init): Likewise.
3460         * aarch64-tdep.h (aarch64_read_description): Likewise.
3461         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3462         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3463         * features/Makefile: Add new files.
3464         * features/aarch64-pauth.c: New file.
3465         * features/aarch64-pauth.xml: New file.
3466
3467 2019-03-20  Tom Tromey  <tromey@adacore.com>
3468
3469         * infrun.c (handle_inferior_event): Rename from
3470         handle_inferior_event_1.  Create a scoped_value_mark.
3471         (handle_inferior_event): Remove.
3472
3473 2019-03-19  Tom Tromey  <tromey@adacore.com>
3474
3475         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3476         * infrun.h (print_stop_event): Add "displays" parameter.
3477         * infrun.c (print_stop_event): Add "displays" parameter.
3478
3479 2019-03-19  Pedro Alves  <palves@redhat.com>
3480
3481         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3482         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3483         to -1.  Fix TABs vs spaces.
3484         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3485         * tui/tui-out.h (tui_ui_out) Add intro comments.
3486         <m_line, m_start_of_line>: In-class initialize, and add describing
3487         comment.
3488
3489 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3490
3491         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3492         variable names.
3493         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3494
3495 2019-03-18  Pedro Alves  <palves@redhat.com>
3496             Eli Zaretskii <eliz@gnu.org>
3497
3498         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3499         m_line and m_start_of_line.
3500
3501 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3502
3503         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3504         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3505         it returns a newline.  This fixes a regression in TU mode, whereby
3506         the next line is output on the same screen line as the user input.
3507
3508 2019-03-18  Tom Tromey  <tromey@adacore.com>
3509
3510         * minsyms.c (minimal_symbol_reader::install): Remove call to
3511         obstack_blank.
3512
3513 2019-03-18  Pedro Alves  <palves@redhat.com>
3514
3515         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3516         New globals.
3517         (apply_style): New, factored out from ...
3518         (apply_ansi_escape): ... this.  Handle reverse video mode.
3519         (tui_set_reverse_mode): New function.
3520         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3521         * tui/tui-winsource.c (tui_show_source_line): Use
3522         tui_set_reverse_mode instead of setting A_STANDOUT.
3523         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3524         New setter methods.
3525
3526 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3527
3528         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3529         Handle tabs.
3530
3531 2019-03-18  Tom Tromey  <tromey@adacore.com>
3532
3533         * ada-lang.c (empty_array): Add "high" parameter.
3534         (ada_evaluate_subexp): Update.
3535
3536 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3537
3538         * unittests/string_view-selftests.c: Define
3539         _initialize_string_view_selftests unconditionally.
3540
3541 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3542
3543         PR gdb/24350
3544         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3545
3546 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3547
3548         PR gdb/24351
3549         * windows-nat.c (display_selector): Fix format specifiers.
3550
3551 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3552
3553         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3554         tui_refill_source_window instead of tui_refresh_win, to update the
3555         current execution line.  This fixes redisplay of the current line
3556         when stepping through the code with "next" or "step".
3557
3558 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3559
3560         * source-cache.c (source_cache::get_source_lines): Call
3561         find_source_lines to initialize s->nlines.  This fixes vertical
3562         scrolling of TUI source window when the DOWN arrow is pressed.
3563
3564 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3565
3566         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3567         linux-thread-db.c (_initialize_thread_db): Likewise.
3568
3569 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3570
3571         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3572         wclrtoeol in tui_show_source_line".  This reverts changes made in
3573         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3574
3575 2019-03-15  Tom Tromey  <tom@tromey.com>
3576
3577         * symtab.h (struct minimal_symbol): Derive from
3578         general_symbol_info.
3579         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3580         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3581         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3582         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3583         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3584         (MSYMBOL_SEARCH_NAME): Update.
3585         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3586         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3587         * minsyms.c (minimal_symbol_reader::record_full): Update.
3588
3589 2019-03-15  Tom Tromey  <tom@tromey.com>
3590
3591         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3592
3593 2019-03-15  Tom Tromey  <tom@tromey.com>
3594
3595         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3596         unique_xmalloc_ptr.
3597         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3598         Update.
3599         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3600         (build_minimal_symbol_hash_tables)
3601         (minimal_symbol_reader::install): Update.
3602
3603 2019-03-15  Tom Tromey  <tom@tromey.com>
3604
3605         * symtab.c (create_demangled_names_hash): Update.
3606         (symbol_set_names): Update.
3607         * objfiles.h (struct objfile_per_bfd_storage)
3608         <demangled_names_hash>: Now an htab_up.
3609         * objfiles.c (objfile_per_bfd_storage): Simplify.
3610
3611 2019-03-15  Tom Tromey  <tom@tromey.com>
3612
3613         * objfiles.h (struct objfile_per_bfd_storage): Declare
3614         destructor.
3615         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3616         New.
3617         (get_objfile_bfd_data): Use new.  Don't initialize
3618         language_of_main.
3619         (free_objfile_per_bfd_storage): Remove.
3620         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3621
3622 2019-03-15  Tom Tromey  <tom@tromey.com>
3623
3624         * symfile.c (reread_symbols): Update.
3625         * objfiles.c (objfile::objfile): Update.
3626         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3627         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3628         comment.
3629         (minimal_symbol_reader::install): Update.
3630         (terminate_minimal_symbol_table): Remove.
3631         * jit.c (jit_object_close_impl): Update.
3632
3633 2019-03-15  Tom Tromey  <tom@tromey.com>
3634
3635         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3636         initializations.
3637
3638 2019-03-15  Tom Tromey  <tom@tromey.com>
3639
3640         * objfiles.h (struct objfile_per_bfd_storage)
3641         <demangled_hash_languages>: Now a bitset.
3642         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3643         (lookup_minimal_symbol): Update.
3644
3645 2019-03-15  Tom Tromey  <tom@tromey.com>
3646
3647         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3648         Don't return the symbol.
3649         * coffread.c (record_minimal_symbol): Use record_full.
3650
3651 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3652
3653         The MS-Windows port of ncurses fails to switch to a color pair if
3654         one or both of the colors are the implicit default colors.  This
3655         change records the default colors when TUI is initialized, and
3656         then specifies them explicitly when a color pair uses the default
3657         colors.  This allows color styling in TUI mode on MS-Windows.
3658
3659         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3660         ncurses_norm_attr.
3661         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3662         colors in ncurses_norm_attr.
3663         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3664         "none", replace it with the default color recorded in
3665         ncurses_norm_attr.
3666
3667 2019-03-14  Tom Tromey  <tromey@adacore.com>
3668
3669         * source-cache.h (class source_cache) <get_source_lines>: Return
3670         std::string.
3671         * source-cache.c (source_cache::extract_lines): Handle case where
3672         first_pos==npos.  Return std::string.
3673         (source_cache::get_source_lines): Update.
3674
3675 2019-03-14  Tom Tromey  <tromey@adacore.com>
3676
3677         * NEWS: Add item for "style sources" commands.
3678         * source-cache.c (source_cache::get_source_lines): Check
3679         source_styling.
3680         * cli/cli-style.c (source_styling): New global.
3681         (_initialize_cli_style): Add "style sources" commands.
3682         (show_style_sources): New function.
3683         * cli/cli-style.h (source_styling): Declare.
3684
3685 2019-03-14  Pedro Alves  <palves@redhat.com>
3686             Tom Tromey  <tromey@adacore.com>
3687
3688         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3689         * tui/tui-winsource.c (tui_refill_source_window): New function,
3690         from...
3691         (tui_horizontal_source_scroll): ... here.  Move some logic.
3692         * cli/cli-style.c (set_style_enabled): Notify new observable.
3693         * tui/tui-hooks.c (tui_redisplay_source): New function.
3694         (tui_attach_detach_observers): Attach or detach
3695         tui_redisplay_source.
3696         * observable.h (source_styling_changed): New observable.
3697         * observable.c: Define source_styling_changed observable.
3698
3699 2019-03-13  Tom Tromey  <tromey@adacore.com>
3700
3701         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3702         (i386_gnu_nat_target::store_registers): Update.
3703         * target-debug.h (target_debug_print_std_string): New macro.
3704         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3705         * windows-tdep.c (display_one_tib): Update.
3706         * tui/tui-stack.c (tui_make_status_line): Update.
3707         * top.c (print_inferior_quit_action): Update.
3708         * thread.c (thr_try_catch_cmd): Update.
3709         (add_thread_with_info): Update.
3710         (thread_target_id_str): Update.
3711         (thr_try_catch_cmd): Update.
3712         (thread_command): Update.
3713         (thread_find_command): Update.
3714         * record-btrace.c (record_btrace_target::info_record)
3715         (record_btrace_resume_thread, record_btrace_target::resume)
3716         (record_btrace_cancel_resume, record_btrace_step_thread)
3717         (record_btrace_target::wait, record_btrace_target::wait)
3718         (record_btrace_target::wait, record_btrace_target::stop): Update.
3719         * progspace.c (print_program_space): Update.
3720         * process-stratum-target.c
3721         (process_stratum_target::thread_address_space): Update.
3722         * linux-fork.c (linux_fork_mourn_inferior)
3723         (detach_checkpoint_command, info_checkpoints_command)
3724         (linux_fork_context): Update.
3725         (linux_fork_detach): Update.
3726         (class scoped_switch_fork_info): Update.
3727         (delete_checkpoint_command): Update.
3728         * infrun.c (follow_fork_inferior): Update.
3729         (follow_fork_inferior): Update.
3730         (proceed_after_vfork_done): Update.
3731         (handle_vfork_child_exec_or_exit): Update.
3732         (follow_exec): Update.
3733         (displaced_step_prepare_throw): Update.
3734         (displaced_step_restore): Update.
3735         (start_step_over): Update.
3736         (resume_1): Update.
3737         (clear_proceed_status_thread): Update.
3738         (proceed): Update.
3739         (print_target_wait_results): Update.
3740         (do_target_wait): Update.
3741         (context_switch): Update.
3742         (stop_all_threads): Update.
3743         (restart_threads): Update.
3744         (finish_step_over): Update.
3745         (handle_signal_stop): Update.
3746         (switch_back_to_stepped_thread): Update.
3747         (keep_going_pass_signal): Update.
3748         (print_exited_reason): Update.
3749         (normal_stop): Update.
3750         * inferior.c (inferior_pid_to_str): Change return type.
3751         (print_selected_inferior): Update.
3752         (add_inferior): Update.
3753         (detach_inferior): Update.
3754         * dummy-frame.c (fprint_dummy_frames): Update.
3755         * dcache.c (dcache_info_1): Update.
3756         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3757         (btrace_fetch, btrace_clear): Update.
3758         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3759         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3760         type.
3761         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3762         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3763         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3764         * gdbarch.c, gdbarch.h: Rebuild.
3765         * gdbarch.sh (core_pid_to_str): Change return type.
3766         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3767         return type.
3768         (windows_nat_target::pid_to_str): Change return type.
3769         (windows_delete_thread): Update.
3770         (windows_nat_target::attach): Update.
3771         (windows_nat_target::files_info): Update.
3772         * target-delegates.c: Rebuild.
3773         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3774         return type.
3775         (sol_thread_target::pid_to_str): Change return type.
3776         * remote.c (class remote_target) <pid_to_str>: Change return
3777         type.
3778         (remote_target::pid_to_str): Change return type.
3779         (extended_remote_target::attach, remote_target::remote_stop_ns)
3780         (remote_target::remote_notif_remove_queued_reply)
3781         (remote_target::push_stop_reply, remote_target::disable_btrace):
3782         Update.
3783         (extended_remote_target::attach): Update.
3784         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3785         type.
3786         (gdbsim_target::pid_to_str): Change return type.
3787         * ravenscar-thread.c (struct ravenscar_thread_target)
3788         <pid_to_str>: Change return type.
3789         (ravenscar_thread_target::pid_to_str): Change return type.
3790         * procfs.c (class procfs_target) <pid_to_str>: Change return
3791         type.
3792         (procfs_target::pid_to_str): Change return type.
3793         (procfs_target::attach): Update.
3794         (procfs_target::detach): Update.
3795         (procfs_target::fetch_registers): Update.
3796         (procfs_target::store_registers): Update.
3797         (procfs_target::wait): Update.
3798         (procfs_target::files_info): Update.
3799         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3800         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3801         return type.
3802         (nto_procfs_target::pid_to_str): Change return type.
3803         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3804         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3805         return type.
3806         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3807         (exit_lwp): Update.
3808         (attach_proc_task_lwp_callback, get_detach_signal)
3809         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3810         (linux_nat_target::resume, wait_lwp, stop_callback)
3811         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3812         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3813         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3814         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3815         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3816         type.
3817         (inf_ptrace_target::attach): Update.
3818         (inf_ptrace_target::files_info): Update.
3819         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3820         type.
3821         (go32_nat_target::pid_to_str): Change return type.
3822         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3823         (gnu_nat_target::wait): Update.
3824         (gnu_nat_target::wait): Update.
3825         (gnu_nat_target::resume): Update.
3826         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3827         (fbsd_nat_target::wait): Update.
3828         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3829         type.
3830         (darwin_nat_target::attach): Update.
3831         * corelow.c (class core_target) <pid_to_str>: Change return type.
3832         (core_target::pid_to_str): Change return type.
3833         * target.c (normal_pid_to_str): Change return type.
3834         (default_pid_to_str): Likewise.
3835         (target_pid_to_str): Change return type.
3836         (target_translate_tls_address): Update.
3837         (target_announce_detach): Update.
3838         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3839         return type.
3840         (bsd_uthread_target::pid_to_str): Change return type.
3841         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3842         type.
3843         (bsd_kvm_target::pid_to_str): Change return type.
3844         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3845         return type.
3846         (aix_thread_target::pid_to_str): Change return type.
3847         * target.h (struct target_ops) <pid_to_str>: Change return type.
3848         (target_pid_to_str, normal_pid_to_str): Likewise.
3849         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3850         type.
3851         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3852         type.
3853         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3854         return type.
3855         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3856         type.
3857         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3858         type.
3859         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3860         return type.
3861
3862 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3863
3864         * NEWS: Mention that the new default MI version is 3.  Mention
3865         changes to the output of commands and events that deal with
3866         multi-location breakpoints.
3867         * breakpoint.c: Include "mi/mi-out.h".
3868         (print_one_breakpoint): Change output syntax if using MI version
3869         >= 3.
3870         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3871         New.
3872         (mi_multi_location_breakpoint_output_fixed): New.
3873         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3874         (mi_cmd_fix_multi_location_breakpoint_output): New.
3875         (mi_multi_location_breakpoint_output_fixed): New.
3876         * mi/mi-cmds.c (mi_cmds): Register command
3877         -fix-multi-location-breakpoint-output.
3878         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3879         interpreter "mi".
3880
3881 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3882
3883         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3884         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3885         instantiate mi_ui_out based on interpreter name.
3886         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3887         * mi/mi-main.c (mi_load_progress): Likewise.
3888
3889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3890
3891         * NEWS: Combine separate "New targets" sections for 8.3.
3892
3893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3894
3895         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3896         (ppcfbsd_init_abi): Install gdbarch
3897         "fetch_tls_load_module_address" and "get_thread_local_address"
3898         methods.
3899
3900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3901
3902         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3903         (riscv_fbsd_init_abi): Install gdbarch
3904         "fetch_tls_load_module_address" and "get_thread_local_address"
3905         methods.
3906
3907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3908
3909         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3910         (i386fbsd_init_abi): Install gdbarch
3911         "fetch_tls_load_module_address" and "get_thread_local_address"
3912         methods.
3913
3914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3915
3916         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3917         (amd64fbsd_init_abi): Install gdbarch
3918         "fetch_tls_load_module_address" and "get_thread_local_address"
3919         methods.
3920
3921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3922
3923         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3924         (struct fbsd_pspace_data): New type.
3925         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3926         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3927         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3928         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3929         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3930
3931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3932
3933         * gdbtypes.c (lookup_struct_elt): New function.
3934         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3935         * gdbtypes.h (struct struct_elt): New type.
3936         (lookup_struct_elt): New prototype.
3937
3938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3939
3940         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3941         remove disabled code block.
3942
3943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3944
3945         * gdbarch.sh (get_thread_local_address): New method.
3946         * gdbarch.h, gdbarch.c: Regenerate.
3947         * target.c (target_translate_tls_address): Use
3948         gdbarch_get_thread_local_address if present instead of
3949         target::get_thread_local_address.
3950
3951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3952
3953         * target.h (target::get_thread_local_address): Update comment.
3954
3955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3956
3957         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3958         objfile->separate_debug_objfile_backlink if not NULL.
3959
3960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3961
3962         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3963         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3964         (amd64bsd_store_inferior_registers): Likewise.
3965         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3966         Enable segment base registers.
3967         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3968         PT_GETFSBASE and PT_GETGSBASE.
3969         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3970         PT_SETGSBASE.
3971         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3972         segment base registers.
3973         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3974
3975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3976
3977         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3978         Update calls to i386_target_description to add 'segments'
3979         parameter.
3980         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3981         add segment base registers.
3982         * arch/i386.c (i386_create_target_description): Add 'segments'
3983         parameter to enable segment base registers.
3984         * arch/i386.h (i386_create_target_description): Likewise.
3985         * features/i386/32bit-segments.xml: New file.
3986         * features/i386/32bit-segments.c: Generate.
3987         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3988         call to i386_target_description to add 'segments' parameter.
3989         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3990         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3991         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3992         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3993         if feature is present.
3994         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3995         Add 'segments' parameter to call to i386_target_description.
3996         (i386_target_description): Add 'segments' parameter to enable
3997         segment base registers.
3998         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3999         to call to i386_target_description.
4000         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4001         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4002         Define I386_NUM_REGS.
4003         (i386_target_description): Add 'segments' parameter to enable
4004         segment base registers.
4005
4006 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4007
4008         PR/24325
4009         * source-cache.c: #undef open and close, to avoid unresolved
4010         externals during linking.
4011
4012 2019-03-12  Tom Tromey  <tromey@adacore.com>
4013
4014         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4015         const.  Add initializers.
4016         (_initialize_remote): Don't initialize ptid globals.
4017
4018 2019-03-12  Pedro Alves  <palves@redhat.com>
4019
4020         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4021
4022 2019-03-12  Pedro Alves  <palves@redhat.com>
4023
4024         * cp-name-parser.y (main): Remove unused 'len' variable.
4025
4026 2019-03-12  Tom Tromey  <tromey@adacore.com>
4027
4028         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4029         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4030
4031 2019-03-12  Tom Tromey  <tromey@adacore.com>
4032
4033         * linux-nat.c (iterate_over_lwps): Update.
4034         (stop_callback): Remove parameter.
4035         (stop_wait_callback, detach_callback, resume_set_callback)
4036         (select_singlestep_lwp_callback, set_ignore_sigint)
4037         (status_callback, resumed_callback, resume_clear_callback)
4038         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4039         data parameter.
4040         (linux_nat_target::detach, linux_nat_target::resume)
4041         (linux_stop_and_wait_all_lwps, select_event_lwp)
4042         (linux_nat_filter_event, linux_nat_wait_1)
4043         (linux_nat_target::kill, linux_nat_target::stop)
4044         (linux_nat_target::stop): Update.
4045         (linux_nat_resume_callback): Change type.
4046         (resume_stopped_resumed_lwps, count_events_callback)
4047         (select_event_lwp_callback): Likewise.
4048         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4049         * arm-linux-nat.c (struct update_registers_data): Remove.
4050         (update_registers_callback): Change type.
4051         (arm_linux_insert_hw_breakpoint1): Update.
4052         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4053         parameter.
4054         (x86_linux_dr_set_addr): Update.
4055         (x86_linux_dr_set_control): Update.
4056         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4057         (iterate_over_lwps): Use gdb::function_view.
4058         * nat/aarch64-linux-hw-point.c (struct
4059         aarch64_dr_update_callback_param): Remove.
4060         (debug_reg_change_callback): Change type.
4061         (aarch64_notify_debug_reg_change): Update.
4062         * s390-linux-nat.c (s390_refresh_per_info): Update.
4063
4064 2019-03-11  Tom Tromey  <tromey@adacore.com>
4065
4066         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4067         redundant assignment to "this_cu".
4068
4069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4070
4071         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4072
4073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4074
4075         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4076         from...
4077         (rank_one_type): ... this.
4078
4079 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4080
4081         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4082         from...
4083         (rank_one_type): ... this.
4084
4085 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4086
4087         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4088         from...
4089         (rank_one_type): ... this.
4090
4091 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4092
4093         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4094         from...
4095         (rank_one_type): ... this.
4096
4097 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4098
4099         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4100         from...
4101         (rank_one_type): ... this.
4102
4103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4104
4105         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4106         from...
4107         (rank_one_type): ... this.
4108
4109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4110
4111         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4112         from...
4113         (rank_one_type): ... this.
4114
4115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4116
4117         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4118         from...
4119         (rank_one_type): ... this.
4120
4121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4122
4123         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4124         from...
4125         (rank_one_type): ... this.
4126
4127 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4128
4129         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4130         from...
4131         (rank_one_type): ... this.
4132
4133 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4134
4135         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4136         from...
4137         (rank_one_type): ... this.
4138
4139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4140
4141         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4142         from...
4143         (rank_one_type): ... this.
4144
4145 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4146
4147         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4148         inferior-events' shows the example events.
4149
4150 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4151
4152         Support styling on native MS-Windows console
4153
4154         PR/24315
4155         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4156         on MS-Windows if $TERM is not defined.
4157
4158         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4159
4160         * posix-hdep.c (gdb_console_fputs):
4161         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4162         functions.
4163         * ui-file.h (gdb_console_fputs): Add prototype.
4164
4165         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4166         back to fputs only if the former returns zero.
4167
4168 2019-03-07  Tom Tromey  <tom@tromey.com>
4169
4170         * symmisc.c (print_symbol_bcache_statistics): Update.
4171         (print_objfile_statistics): Update.
4172         * symfile.c (allocate_symtab): Update.
4173         * stabsread.c: Don't include bcache.h.
4174         * psymtab.h (struct psymbol_bcache): Don't declare.
4175         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4176         (psymbol_bcache_init, psymbol_bcache_free)
4177         (psymbol_bcache_get_bcache): Don't declare.
4178         * psymtab.c (struct psymbol_bcache): Remove.
4179         (psymtab_storage::psymtab_storage): Update.
4180         (psymtab_storage::~psymtab_storage): Update.
4181         (psymbol_bcache_init, psymbol_bcache_free)
4182         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4183         (add_psymbol_to_bcache): Update.
4184         (allocate_psymtab): Update.
4185         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4186         macro_cache>: No longer pointers.
4187         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4188         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4189         * macrotab.c (macro_bcache): Update.
4190         * macroexp.c: Don't include bcache.h.
4191         * gdbtypes.c (check_types_worklist): Update.
4192         (types_deeply_equal): Remove TRY/CATCH.  Update.
4193         * elfread.c (elf_symtab_read): Update.
4194         * dwarf2read.c: Don't include bcache.h.
4195         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4196         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4197         (print_bcache_statistics, bcache_memory_used): Don't declare.
4198         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4199         methods.  Rename all data members.
4200         * bcache.c (struct bcache): Move to bcache.h.
4201         (bcache::expand_hash_table): Rename from expand_hash_table.
4202         (bcache): Remove.
4203         (bcache::insert): Rename from bcache_full.
4204         (bcache::compare): Rename from bcache_compare.
4205         (bcache_xmalloc): Remove.
4206         (bcache::~bcache): Rename from bcache_xfree.
4207         (bcache::print_statistics): Rename from print_bcache_statistics.
4208         (bcache::memory_used): Rename from bcache_memory_used.
4209
4210 2019-03-07  Pedro Alves  <palves@redhat.com>
4211
4212         * infrun.c (normal_stop): Also check for
4213         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4214
4215 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * f-lang.c (value_from_host_double): Moved to...
4218         * value.c (value_from_host_double): ...here.
4219         * value.h (value_from_host_double): Declare.
4220         * guile/scm-math.c (vlscm_convert_typed_number): Use
4221         value_from_host_double.
4222         (vlscm_convert_number): Likewise.
4223         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4224         * python/py-value.c (convert_value_from_python): Likewise.
4225
4226 2019-03-06  Tom Tromey  <tom@tromey.com>
4227
4228         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4229
4230 2019-03-06  Tom Tromey  <tom@tromey.com>
4231
4232         * utils.h (free_current_contents): Don't declare.
4233         * utils.c (free_current_contents): Remove.
4234
4235 2019-03-06  Tom Tromey  <tom@tromey.com>
4236
4237         * top.c (quit_force): Update.
4238         * main.c (captured_command_loop): Update.
4239         * common/new-op.c (operator new): Update.
4240         * common/common-exceptions.c (struct catcher)
4241         <save_cleanup_chain>: Remove member.
4242         (exceptions_state_mc_init): Update.
4243         (exception_try_scope_entry): Return nullptr.
4244         (exception_try_scope_exit, exception_rethrow)
4245         (throw_exception_sjlj, throw_exception_cxx): Update.
4246         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4247         (all_cleanups, do_cleanups, discard_cleanups)
4248         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4249         (restore_cleanups, restore_final_cleanups): Don't declare.
4250         (do_final_cleanups): Remove parameter.
4251         * common/cleanups.c (cleanup_chain, make_cleanup)
4252         (make_cleanup_dtor, all_cleanups, do_cleanups)
4253         (discard_my_cleanups, discard_cleanups)
4254         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4255         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4256         (null_cleanup): Remove.
4257         (do_final_cleanups): Remove parameter.
4258
4259 2019-03-06  Tom Tromey  <tom@tromey.com>
4260
4261         * remote.c (remote_target::remote_parse_stop_reply): Use
4262         unique_xmalloc_ptr.
4263
4264 2019-03-06  Tom Tromey  <tom@tromey.com>
4265
4266         * stabsread.c (struct stabs_field_info): Rename from field_info.
4267         <list, fnlist>: Add initializers.
4268         <obstack>: New member.
4269         (read_member_functions, read_struct_fields, read_baseclasses):
4270         Allocate on obstack.  Don't use cleanups.
4271         (read_one_struct_field, read_member_functions, read_struct_fields)
4272         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4273         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4274         (read_struct_type): Update.
4275
4276 2019-03-06  Tom Tromey  <tom@tromey.com>
4277
4278         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4279         * common/filestuff.h (make_cleanup_close): Don't declare.
4280         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4281         Remove.
4282
4283 2019-03-06  Tom Tromey  <tom@tromey.com>
4284
4285         * solib-aix.c: Use make_scope_exit.
4286
4287 2019-03-06  Tom Tromey  <tom@tromey.com>
4288
4289         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4290         Use make_scope_exit.
4291
4292 2019-03-06  Tom Tromey  <tom@tromey.com>
4293
4294         * solib-svr4.c (disable_probes_interface): Remove parameter.
4295         (svr4_handle_solib_event): Use make_scope_exit.
4296
4297 2019-03-06  Tom Tromey  <tom@tromey.com>
4298
4299         * remote.c (struct stop_reply_deleter): Remove.
4300         (stop_reply_up): Update.
4301         (struct stop_reply): Derive from notif_event.  Don't typedef.
4302         <regcache>: Now a std::vector.
4303         (stop_reply_xfree): Remove.
4304         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4305         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4306         (remote_target::discard_pending_stop_replies): Use delete.
4307         (remote_target::remote_parse_stop_reply): Update.
4308         (remote_target::process_stop_reply): Update.
4309         * remote-notif.h (struct notif_event): Add virtual destructor.
4310         Remove "dtr" member.
4311         (struct notif_client) <alloc_event>: Return a unique_ptr.
4312         (notif_event_xfree): Don't declare.
4313         (notif_event_up): New typedef.
4314         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4315         (notif_event_xfree, do_notif_event_xfree): Remove.
4316         (remote_notif_state_xfree): Update.
4317
4318 2019-03-06  Tom Tromey  <tom@tromey.com>
4319
4320         * infrun.c (displaced_step_clear_cleanup): Now a
4321         forward_scope_exit type.
4322         (displaced_step_prepare_throw): Update.
4323         (displaced_step_fixup): Update.
4324
4325 2019-03-06  Tom Tromey  <tom@tromey.com>
4326
4327         * inferior.h (class inferior): Update comment.
4328         * gdbthread.h (class thread_info): Update comment.
4329
4330 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4331             Tom Tromey  <tom@tromey.com>
4332
4333         * stabsread.h (struct stab_section_list): Remove.
4334         (coffstab_build_psymtabs): Update.
4335         * dbxread.c (symbuf_sections): Now a std::vector.
4336         (sect_idx): New global.
4337         (fill_symbuf): Update.
4338         (coffstab_build_psymtabs): Change type of stabsects parameter.
4339         Update.
4340         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4341         std::vector.
4342         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4343         (coff_locate_sections): Update.
4344         (coff_symfile_read): Remove cleanups.  Update.
4345         (init_stringtab): Add storage parameter.
4346         (free_stringtab, free_stringtab_cleanup): Remove.
4347         (init_lineno): Add storage parameter.
4348         (free_linetab, free_linetab_cleanup): Remove.
4349
4350 2019-03-06  Pedro Alves  <palves@redhat.com>
4351
4352         * linux-fork.c (fork_info::clobber_regs): Delete.
4353         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4354         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4355         comment.  Adjust.
4356         (scoped_switch_fork_info::scoped_switch_fork_info)
4357         (checkpoint_command, linux_fork_context): Adjust
4358         fork_save_infrun_state calls.
4359
4360 2019-03-06  Pedro Alves  <palves@redhat.com>
4361
4362         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4363         (inf_has_multiple_threads): Return 'bool' and rewrite using
4364         inferior_info::threads().
4365
4366 2019-03-06  Pedro Alves  <palves@redhat.com>
4367
4368         * linux-fork.c: Include <list>.
4369         (fork_list): Now a std::list instance.
4370         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4371         (forks_exist_p, find_last_fork): Adjust.
4372         (new_fork): Delete.
4373         (one_fork_p): New.
4374         (add_fork): Adjust.
4375         (free_fork): Delete, folded into fork_info::~fork_info().
4376         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4377         Adjust.
4378         (init_fork_list): Delete.
4379         (linux_fork_killall, linux_fork_mourn_inferior)
4380         (linux_fork_detach, info_checkpoints_command): Adjust.
4381         (_initialize_linux_fork): No longer call init_fork_list.
4382
4383 2019-03-06  Pedro Alves  <palves@redhat.com>
4384
4385         * linux-fork.c (new_fork): New, split out of ...
4386         (add_fork): ... this.  Return void.  Move "first fork" special
4387         case from here, to ...
4388         (checkpoint_command): ... here.
4389         * linux-linux.h (add_fork): Return void.
4390
4391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4394
4395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4396             Chris January  <chris.january@arm.com>
4397             David Lecomber  <david.lecomber@arm.com>
4398
4399         * f-exp.y: New token, UNOP_INTRINSIC.
4400         (exp): New pattern using UNOP_INTRINSIC token.
4401         (f77_keywords): Add 'abs' keyword.
4402         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4403         (value_from_host_double): New function.
4404         (evaluate_subexp_f): Support UNOP_ABS.
4405
4406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4407
4408         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4409         types.
4410
4411 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4414         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4415         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4416
4417 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4420
4421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4422             Chris January  <chris.january@arm.com>
4423
4424         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4425         * f-exp.y: Define 'KIND' token.
4426         (exp): New pattern for KIND expressions.
4427         (ptype): Handle types with a kind extension.
4428         (direct_abs_decl): Extend to spot kind extensions.
4429         (f77_keywords): Add 'kind' to the list.
4430         (push_kind_type): New function.
4431         (convert_to_kind_type): New function.
4432         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4433         * parse.c (operator_length_standard): Likewise.
4434         * parser-defs.h (enum type_pieces): Add tp_kind.
4435         * std-operator.def: Add UNOP_KIND.
4436
4437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * f-exp.y (f_parse): Set yydebug.
4440
4441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * f-lang.c (evaluate_subexp_f): New function.
4444         (exp_descriptor_f): New global.
4445         (f_language_defn): Use exp_descriptor_f instead of
4446         exp_descriptor_standard.
4447
4448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * f-exp.y (struct token): Add comments.
4451         (dot_ops): Remove uppercase versions and the end marker.
4452         (f77_keywords): Likewise.
4453         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4454         entries in the dot_ops array are case insensitive, and use
4455         strncasecmp to compare strings.  Also some whitespace cleanup in
4456         this area.  Similar for the f77_keywords array, except entries in
4457         this list might be case sensitive.
4458
4459 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * f-exp.y (struct f77_boolean_val): Add comments.
4462         (boolean_values): Remove uppercase versions, and end marker.
4463         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4464         and use strncasecmp to achieve case insensitivity.  Additionally,
4465         perform whitespace cleanup around this code.
4466
4467 2019-03-06  Tom Tromey  <tromey@adacore.com>
4468
4469         * remote-sim.c (gdbsim_target_open): Use result of
4470         gdb_argv::release.
4471
4472 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4473         Dirk Schubert  <dirk.schubert@arm.com>
4474         Chris January  <chris.january@arm.com>
4475
4476         * eval.c (evaluate_subexp_standard): Call Fortran argument
4477         wrapping logic.
4478         * f-lang.c (struct value): A value which can be passed into a
4479         Fortran function call.
4480         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4481         where appropriate.
4482         (struct type): Value ready for a Fortran function call.
4483         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4484         is needed.
4485         * f-lang.h (fortran_argument_convert): Declaration.
4486         (fortran_preserve_arg_pointer): Declaration.
4487         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4488
4489 2019-03-05  Tom Tromey  <tromey@adacore.com>
4490
4491         * python/py-prettyprint.c (print_string_repr): Remove #if.
4492         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4493
4494 2019-03-05  Tom Tromey  <tromey@adacore.com>
4495
4496         * target.c (the_dummy_target): Move later.  Change type to
4497         "dummy_target".
4498         (initialize_targets): Don't initialize the_dummy_target.
4499
4500 2019-03-05  Tom Tromey  <tromey@adacore.com>
4501
4502         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4503         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4504
4505 2019-03-05  Tom Tromey  <tromey@adacore.com>
4506
4507         * windows-nat.c (windows_nat_target::attach)
4508         (windows_nat_target::detach): Don't call gdb_flush.
4509         * valprint.c (generic_val_print, val_print, val_print_string):
4510         Don't call gdb_flush.
4511         * utils.c (defaulted_query): Don't call gdb_flush.
4512         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4513         * target.c (target_announce_detach): Don't call gdb_flush.
4514         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4515         * remote.c (extended_remote_target::attach): Don't call
4516         gdb_flush.
4517         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4518         * printcmd.c (do_examine): Don't call gdb_flush.
4519         (info_display_command): Don't call gdb_flush.
4520         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4521         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4522         * memattr.c (info_mem_command): Don't call gdb_flush.
4523         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4524         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4525         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4526         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4527         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4528         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4529         (gnu_nat_target::detach): Don't call gdb_flush.
4530         * f-valprint.c (f_val_print): Don't call gdb_flush.
4531         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4532         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4533         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4534         gdb_flush.
4535         * c-valprint.c (c_val_print): Don't call gdb_flush.
4536         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4537
4538 2019-03-05  Tom Tromey  <tromey@adacore.com>
4539
4540         * varobj.c (update_dynamic_varobj_children): Update.
4541         (install_default_visualizer): Use reset, not release.
4542         * value.c (set_internalvar): Update.
4543         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4544         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4545         ATTRIBUTE_UNUSED_RESULT.
4546
4547 2019-03-05  Tom Tromey  <tromey@adacore.com>
4548
4549         * remote.c (class scoped_remote_fd) <release>: Add
4550         ATTRIBUTE_UNUSED_RESULT.
4551
4552 2019-03-05  Tom Tromey  <tromey@adacore.com>
4553
4554         * macroexp.c (struct macro_buffer) <release>: Add
4555         ATTRIBUTE_UNUSED_RESULT.
4556
4557 2019-03-05  Tom Tromey  <tromey@adacore.com>
4558
4559         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4560         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4561         ATTRIBUTE_UNUSED_RESULT.
4562
4563 2019-03-05  Tom Tromey  <tromey@adacore.com>
4564
4565         * common/scoped_fd.h (class scoped_fd) <release>: Add
4566         ATTRIBUTE_UNUSED_RESULT.
4567
4568 2019-03-05  Tom Tromey  <tromey@adacore.com>
4569
4570         * parser-defs.h (struct parser_state) <release>: Add
4571         ATTRIBUTE_UNUSED_RESULT.
4572
4573 2019-03-05  Tom Tromey  <tromey@adacore.com>
4574
4575         * utils.h (class gdb_argv) <release>: Add
4576         ATTRIBUTE_UNUSED_RESULT.
4577         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4578
4579 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4580
4581         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4582         for-loop range, to avoid compiler warnings.
4583
4584         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4585         avoid compiler warnings about unused variables.
4586
4587         * NEWS: Mention end of support for native debugging on MS-Windows
4588         before XP.
4589
4590         PR gdb/24292
4591         * common/netstuff.c:
4592         * gdbserver/gdbreplay.c
4593         * gdbserver/remote-utils.c:
4594         * ser-tcp.c:
4595         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4596         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4597         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4598         'getaddrinfo' and 'freeaddrinfo' were not available before
4599         Windows XP, and mingw.org's MinGW headers by default define
4600         _WIN32_WINNT to 0x500.
4601
4602 2019-03-01  Gary Benson <gbenson@redhat.com>
4603
4604         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4605
4606 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4607             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4608
4609         PR gdb/8527
4610         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4611         set_sigint_trap, clear_sigint_trap.
4612
4613 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4614
4615         * target.c (target_detach): Clear the regcache and the
4616         frame cache.
4617
4618 2019-02-27  Pedro Alves  <palves@redhat.com>
4619
4620         * utils.c (set_screen_size): When we cap the height/width sizes,
4621         tweak the corresponding command variable to show "unlimited":
4622
4623 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4624             Pedro Alves  <palves@redhat.com>
4625
4626         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4627         before calling rl_set_screen_size.
4628
4629 2019-02-27  Tom Tromey  <tromey@adacore.com>
4630
4631         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4632         define.
4633         * python/py-value.c: Remove Python 2.4 workaround.
4634         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4635         workaround.
4636         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4637         Python 2.4 workaround.
4638         * python/python-internal.h: Remove Python 2.4 comment.
4639         (Py_ssize_t): Don't define.
4640         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4641         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4642         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4643         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4644         * python/python.c (do_start_initialization): Remove Python 2.4
4645         workaround.
4646         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4647         (print_children): Remove Python 2.4 workaround.
4648         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4649         workaround.
4650         (CHARBUFFERPROC_NAME): Remove.
4651         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4652         Python 2.4 workaround.
4653
4654 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4655
4656         * NEWS: Note minimum Python version.
4657
4658 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4659
4660         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4661         code from these functions.  Remove corresponding ifdefs.  Use
4662         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4663         Remove gotos and target of gotos.
4664         (infpy_search_memory): Likewise.
4665
4666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4667
4668         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4669         (hppa_gdbarch_init): Don't register deleted functions with
4670         gdbarch.
4671
4672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4675         (h8300_unwind_sp): Delete.
4676         (h8300_dummy_id): Delete.
4677         (h8300_gdbarch_init): Don't register deleted functions with
4678         gdbarch.
4679
4680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4683         (ft32_unwind_pc): Delete.
4684         (ft32_unwind_sp): Delete.
4685         (ft32_gdbarch_init): Don't register deleted functions with
4686         gdbarch.
4687
4688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4691         (frv_unwind_pc): Delete.
4692         (frv_unwind_sp): Delete.
4693         (frv_gdbarch_init): Don't register deleted functions with
4694         gdbarch.
4695
4696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4699         (riscv_unwind_pc): Delete.
4700         (riscv_unwind_sp): Delete.
4701         (riscv_gdbarch_init): Don't register deleted functions with
4702         gdbarch.
4703
4704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4705
4706         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4707         (csky_unwind_pc): Delete.
4708         (csky_unwind_sp): Delete.
4709         (csky_gdbarch_init): Don't register deleted functions with
4710         gdbarch.
4711
4712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4715         (cris_unwind_pc): Delete.
4716         (cris_unwind_sp): Delete.
4717         (cris_gdbarch_init): Don't register deleted functions with
4718         gdbarch.
4719
4720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4723         (bfin_unwind_pc): Delete.
4724         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4725
4726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4729         (arm_unwind_pc): Delete.
4730         (arm_unwind_sp): Delete.
4731         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4732
4733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4736         (arc_unwind_pc): Delete.
4737         (arc_unwind_sp): Delete.
4738         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4739
4740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4743         (alpha_unwind_pc): Delete.
4744         (alpha_gdbarch_init): Don't register deleted functions with
4745         gdbarch.
4746
4747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4750         (aarch64_unwind_pc): Delete.
4751         (aarch64_unwind_sp): Delete.
4752         (aarch64_gdbarch_init): Don't register deleted functions with
4753         gdbarch.
4754
4755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * gdbtypes.c (type_align): Don't consider static members when
4758         computing structure alignment.
4759
4760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4761
4762         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4763         return 0 for other types.
4764         * arch-utils.c (default_type_align): Always return 0.
4765         * gdbarch.h: Regenerate.
4766         * gdbarch.sh (type_align): Extend comment.
4767         * gdbtypes.c (type_align): Add additional comments, always call
4768         gdbarch_type_align before applying the default rules.
4769         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4770         generic code will then apply a suitable default.
4771         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4772         types, return 0 for other types.
4773
4774 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4775
4776         * NEWS: Create a new section for the next release branch.
4777         Rename the section of the current branch, now that it has
4778         been cut.
4779
4780 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4781
4782         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4783         * version.in: Bump version to 8.3.50.DATE-git.
4784
4785 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4786
4787         * aix-thread.c (ptid_cmp): Remove unused variable.
4788         (get_signaled_thread): Likewise.
4789         (store_regs_user_thread): Likewise.
4790         (store_regs_kernel_thread): Likewise.
4791         (fetch_regs_kernel_thread): Remove shadowed variable.
4792
4793 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * features/riscv/32bit-cpu.xml: Add register numbers.
4796         * features/riscv/32bit-fpu.c: Regenerate.
4797         * features/riscv/32bit-fpu.xml: Add register numbers.
4798         * features/riscv/64bit-cpu.xml: Add register numbers.
4799         * features/riscv/64bit-fpu.c: Regenerate.
4800         * features/riscv/64bit-fpu.xml: Add register numbers.
4801
4802 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4803
4804         * NEWS: Mention two argument form of gdb.Value constructor.
4805         * python/py-value.c (convert_buffer_and_type_to_value): New
4806         function.
4807         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4808         Add support for handling an optional second argument.  Call
4809         convert_buffer_and_type_to_value as appropriate.
4810         * python/python-internal.h (Py_buffer_deleter): New struct.
4811         (Py_buffer_up): New typedef.
4812
4813 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4814
4815         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4816         instead of releasing ownership.
4817
4818 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4819
4820         * dwarf2read.c (open_and_init_dwp_file): Call
4821         elf_numsections instead of bfd_count_sections to initialize
4822         dwp_file->num_sections.
4823
4824 2019-02-25  Tom Tromey  <tromey@adacore.com>
4825
4826         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4827
4828 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4829
4830         * gcore.in: Add '--readnever' option when invoking GDB.
4831
4832 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4833
4834         * MAINTAINERS: Update my email address.
4835
4836 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4837
4838         * build-id.c (build_id_to_debug_bfd_1): New function.
4839         (build_id_to_debug_bfd): Look for separate debug file in
4840         sysroot.
4841
4842 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * gdbarch.sh: Update the copyright year range that is placed into
4845         generated files.
4846
4847 2019-02-22  Keith Seitz  <keiths@redhat.com>
4848
4849         PR symtab/23853
4850         * linespec.c (create_sals_line_offset): Search for the default
4851         symtab's filename instead of its fullname.
4852
4853 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4854
4855         * NEWS: Update style defaults.
4856
4857 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4858
4859         * main.c (captured_main_1): Disable styling in batch mode.
4860
4861 2019-02-20  Tom Tromey  <tom@tromey.com>
4862
4863         * symtab.c (symtab_symbol_info): Fix typos.
4864
4865 2019-02-20  Tom Tromey  <tromey@adacore.com>
4866
4867         * findcmd.c (_initialize_mem_search): Use upper case for
4868         metasyntactic variables.
4869
4870 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4871
4872         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4873         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4874
4875 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4876
4877         * top.h (source_file_name): Change to std::string.
4878         * top.c (source_file_name): Likewise.
4879         (command_line_input): Adjust.
4880         * cli/cli-script.c (script_from_file): Adjust.
4881
4882 2019-02-19  Tom Tromey  <tromey@adacore.com>
4883
4884         * ravenscar-thread.c
4885         (ravenscar_thread_target::update_thread_list): Don't call
4886         ada_build_task_list.
4887         * ada-lang.h (ada_build_task_list): Don't declare.
4888         * ada-tasks.c (struct ada_tasks_inferior_data)
4889         <task_list_valid_p>: Now bool.
4890         (read_known_tasks, ada_task_list_changed)
4891         (ada_tasks_invalidate_inferior_data): Update.
4892         (read_known_tasks_array): Return bool.
4893         (read_known_tasks_list): Likewise.
4894         (read_known_tasks): Return void.
4895         (ada_build_task_list): Now static.
4896
4897 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4900         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4901
4902 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4903
4904         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4905         variant for ada_tasks_pspace_data_handle and
4906         ada_tasks_inferior_data_handle.
4907         (ada_tasks_pspace_data_cleanup): New function.
4908         (ada_tasks_inferior_data_cleanup): New function.
4909
4910 2019-02-17  Tom Tromey  <tom@tromey.com>
4911
4912         * macrotab.h (macro_source_fullname): Return a std::string.
4913         * macrotab.c (macro_include, check_for_redefinition)
4914         (macro_undef, macro_lookup_definition, foreach_macro)
4915         (foreach_macro_in_scope): Update.
4916         (macro_source_fullname): Return a std::string.
4917         * macrocmd.c (show_pp_source_pos): Update.
4918
4919 2019-02-17  Tom Tromey  <tom@tromey.com>
4920
4921         * macrocmd.c (show_pp_source_pos): Style the file names.
4922
4923 2019-02-17  Tom Tromey  <tom@tromey.com>
4924
4925         PR tui/24197:
4926         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4927
4928 2019-02-17  Tom Tromey  <tom@tromey.com>
4929
4930         * ada-lang.c (user_select_syms): Use filtered printing.
4931         * utils.c (wrap_style): New global.
4932         (desired_style): Remove.
4933         (emit_style_escape): Add stream parameter.
4934         (set_output_style, reset_terminal_style, prompt_for_continue):
4935         Update.
4936         (flush_wrap_buffer): Only flush gdb_stdout.
4937         (wrap_here): Set wrap_style.
4938         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4939         treat escape sequences as a character.  Change when wrap buffer is
4940         flushed.
4941         (fputs_styled): Do not set the output style when the default is
4942         requested.
4943         * ui-style.h (struct ui_file_style) <is_default>: New method.
4944         * source.c (print_source_lines_base): Emit escape sequences in one
4945         piece.
4946
4947 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4948
4949         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4950         integers and enumeration types.
4951
4952 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4953
4954         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4955         instead of lookup_symbol_in_language
4956         (do_exact_match): New function.
4957         (ada_get_symbol_name_matcher): Return do_exact_match when
4958         doing a verbatim match.
4959
4960 2019-02-15  Tom Tromey  <tromey@adacore.com>
4961
4962         * ravenscar-thread.c (ravenscar_thread_target::resume)
4963         (ravenscar_thread_target::wait): Special case wildcard requests.
4964
4965 2019-02-15  Tom Tromey  <tromey@adacore.com>
4966
4967         * ravenscar-thread.c (base_ptid): Remove.
4968         (struct ravenscar_thread_target) <close>: New method.
4969         <m_base_ptid>: New member.
4970         <update_inferior_ptid, active_task, task_is_currently_active,
4971         runtime_initialized>: Declare methods.
4972         <ravenscar_thread_target>: Add constructor.
4973         (ravenscar_thread_target::task_is_currently_active)
4974         (ravenscar_thread_target::update_inferior_ptid)
4975         (ravenscar_runtime_initialized): Rename.  Now methods.
4976         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4977         (ravenscar_thread_target::update_thread_list): Update.
4978         (ravenscar_thread_target::active_task): Now method.
4979         (ravenscar_thread_target::store_registers)
4980         (ravenscar_thread_target::prepare_to_store)
4981         (ravenscar_thread_target::prepare_to_store)
4982         (ravenscar_thread_target::mourn_inferior): Update.
4983         (ravenscar_inferior_created): Use "new" to create target.
4984         (ravenscar_thread_target::get_ada_task_ptid): Update.
4985         (_initialize_ravenscar): Don't initialize base_ptid.
4986         (ravenscar_ops): Remove global.
4987
4988 2019-02-15  Tom Tromey  <tromey@adacore.com>
4989
4990         * target.h (push_target): Declare new overload.
4991         * target.c (push_target): New overload, taking an rvalue reference.
4992         * remote.c (remote_target::open_1): Use push_target overload.
4993         * corelow.c (core_target_open): Use push_target overload.
4994
4995 2019-02-15  Tom Tromey  <tromey@adacore.com>
4996
4997         * ravenscar-thread.c (is_ravenscar_task)
4998         (ravenscar_task_is_currently_active): Return bool.
4999         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5000         (_initialize_ravenscar): Remove "(void)".
5001         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5002         Return bool.
5003
5004 2019-02-15  Tom Tromey  <tromey@adacore.com>
5005
5006         * ravenscar-thread.c (ravenscar_runtime_initializer)
5007         (has_ravenscar_runtime, get_running_thread_id)
5008         (ravenscar_thread_target::resume): Fix indentation.
5009
5010 2019-02-15  Tom Tromey  <tromey@adacore.com>
5011
5012         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5013         from ravenscar_arch_ops.
5014         (sparc_ravenscar_ops::fetch_registers)
5015         (sparc_ravenscar_ops::store_registers): Now methods.
5016         (sparc_ravenscar_prepare_to_store): Remove.
5017         (sparc_ravenscar_ops): Redefine.
5018         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5019         methods and destructor.  Remove members.
5020         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5021         (ravenscar_thread_target::store_registers)
5022         (ravenscar_thread_target::prepare_to_store): Update.
5023         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5024         Remove.
5025         (struct ppc_ravenscar_powerpc_ops): Derive from
5026         ravenscar_arch_ops.
5027         (ppc_ravenscar_powerpc_ops::fetch_registers)
5028         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5029         (ppc_ravenscar_powerpc_ops): Redefine.
5030         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5031         (ppc_ravenscar_e500_ops::fetch_registers)
5032         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5033         (ppc_ravenscar_e500_ops): Redefine.
5034         * aarch64-ravenscar-thread.c
5035         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5036         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5037         (aarch64_ravenscar_fetch_registers)
5038         (aarch64_ravenscar_store_registers): Now methods.
5039         (aarch64_ravenscar_ops): Redefine.
5040
5041 2019-02-15  Tom Tromey  <tromey@adacore.com>
5042
5043         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5044         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5045         (ravenscar_thread_target::stopped_by_watchpoint)
5046         (ravenscar_thread_target::stopped_data_address)
5047         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5048
5049 2019-02-15  Tom Tromey  <tromey@adacore.com>
5050
5051         * ravenscar-thread.c: Fix some typos.
5052
5053 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5054             Tom Tromey  <tromey@adacore.com>
5055
5056         * ada-lang.c (ada_exception_sal): Change addr_string to a
5057         std::string.
5058         (create_ada_exception_catchpoint): Update.
5059
5060 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5061             Tom Tromey  <tromey@adacore.com>
5062
5063         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5064         (bp_location_ops): Remove.
5065         (base_breakpoint_allocate_location): Update.
5066         (free_bp_location): Update.
5067         * ada-lang.c (class ada_catchpoint_location)
5068         <ada_catchpoint_location>: Remove ops parameter.
5069         (ada_catchpoint_location_dtor): Remove.
5070         (ada_catchpoint_location_ops): Remove.
5071         (allocate_location_exception): Update.
5072         * breakpoint.h (struct bp_location_ops): Remove.
5073         (class bp_location) <bp_location>: Remove bp_location_ops
5074         parameter.
5075         <~bp_location>: Add destructor.
5076         <ops>: Remove.
5077
5078 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5079             Pedro Alves  <palves@redhat.com>
5080
5081         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5082         'PATH_MAX'.
5083
5084 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5085             Samuel Thibault  <samuel.thibault@gnu.org>
5086             Thomas Schwinge  <thomas@codesourcery.com>
5087
5088         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5089         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5090
5091 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5092
5093         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5094         (check_empty): Use "const char *".
5095
5096         * gnu-nat.c (gnu_nat_target::detach): Instead of
5097         'detach_inferior (pid)' call
5098         'detach_inferior (find_inferior_pid (pid))'.
5099
5100         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5101         'nat/fork-inferior.o'.
5102         * gnu-nat.c: #include "nat/fork-inferior.h".
5103
5104         * gnu-nat.c (gnu_nat_target::detach): Instead of
5105         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5106         * gnu-nat.h: #include "inf-child.h".
5107         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5108         'i386_gnu_nat_target::fetch_registers'.
5109         (gnu_store_registers): Rename/move to
5110         'i386_gnu_nat_target::store_registers'.
5111
5112         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5113         * gnu-nat.h (mach_thread_info): New function.
5114         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5115
5116         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5117
5118 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5119
5120         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5121
5122 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5123
5124         * windows-nat.c (windows_add_thread): Add new parameter
5125         "main_thread_p" with default value set to false.  Update
5126         function documentation as well as all callers.
5127         (windows_delete_thread): Likewise.
5128         (fake_create_process): Update call to windows_add_thread.
5129         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5130         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5131         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5132         call to windows_delete_thread.
5133
5134 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5135
5136         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5137
5138 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5139
5140         * symfile.c (find_separate_debug_file): Use canonical path of
5141         sysroot with child_path instead of gdb_sysroot if it is valid.
5142
5143 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5144
5145         * symfile.c (find_separate_debug_file): Use child_path to
5146         determine if an object file is under a sysroot.
5147
5148 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5149
5150         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5151         unittests/child-path-selftests.c.
5152         * common/pathstuff.c (child_path): New function.
5153         * common/pathstuff.h (child_path): New prototype.
5154         * unittests/child-path-selftests.c: New file.
5155
5156 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5157
5158         * symfile.c (find_separate_debug_file): Look for separate debug
5159         files in debug directories under the sysroot.
5160
5161 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5162
5163         * symtab.h (struct minimal_symbol data_p): New const method.
5164         (struct minimal_symbol text_p): Likewise.
5165         * symtab.c (output_source_filename): Use file name style
5166         to print file name.
5167         (print_symbol_info): Likewise.
5168         (print_msymbol_info): Use address style to print addresses.
5169         Use function name style to print executable text symbols.
5170         (expand_symtab_containing_pc): Use data_p.
5171         (find_pc_sect_compunit_symtab): Likewise.
5172
5173 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5174
5175         * breakpoint.c (describe_other_breakpoints): Use address style
5176         to print addresses.
5177         (say_where): Likewise.
5178
5179 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5180
5181         * ada-typeprint.c (print_func_type): Print function name
5182         style to print function name.
5183         * c-typeprint.c (c_print_type_1): Likewise.
5184
5185 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5186
5187         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5188         for execve.
5189
5190 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5191
5192         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5193         type_stack.
5194
5195 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5196
5197         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5198         TYPE_CODE_REF types.
5199
5200 2019-02-08  Jim Wilson  <jimw@sifive.com>
5201
5202         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5203         (riscv_linux_fregset): New.
5204         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5205
5206 2019-02-07  Tom Tromey  <tom@tromey.com>
5207
5208         * thread.c (thread_cancel_execution_command): Update.
5209         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5210         methods.
5211         (struct thread_fsm_ops): Remove.
5212         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5213         (thread_fsm_should_stop, thread_fsm_return_value)
5214         (thread_fsm_set_finished, thread_fsm_finished_p)
5215         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5216         Don't declare.
5217         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5218         * infrun.c (clear_proceed_status_thread)
5219         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5220         (print_stop_event): Update.
5221         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5222         Add constructor.
5223         (step_command_fsm_ops): Remove.
5224         (new_step_command_fsm): Remove.
5225         (step_1): Update.
5226         (step_command_fsm::should_stop): Rename from
5227         step_command_fsm_should_stop.
5228         (step_command_fsm::clean_up): Rename from
5229         step_command_fsm_clean_up.
5230         (step_command_fsm::do_async_reply_reason): Rename from
5231         step_command_fsm_async_reply_reason.
5232         (struct until_next_fsm): Inherit from thread_fsm.  Add
5233         constructor.
5234         (until_next_fsm_ops): Remove.
5235         (new_until_next_fsm): Remove.
5236         (until_next_fsm::should_stop): Rename from
5237         until_next_fsm_should_stop.
5238         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5239         (until_next_fsm::do_async_reply_reason): Rename from
5240         until_next_fsm_async_reply_reason.
5241         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5242         constructor.  Change type of breakpoint.
5243         (finish_command_fsm_ops): Remove.
5244         (new_finish_command_fsm): Remove.
5245         (finish_command_fsm::should_stop): Rename from
5246         finish_command_fsm_should_stop.
5247         (finish_command_fsm::clean_up): Rename from
5248         finish_command_fsm_clean_up.
5249         (finish_command_fsm::return_value): Rename from
5250         finish_command_fsm_return_value.
5251         (finish_command_fsm::do_async_reply_reason): Rename from
5252         finish_command_fsm_async_reply_reason.
5253         (finish_command): Update.
5254         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5255         Add constructor.
5256         (call_thread_fsm_ops): Remove.
5257         (call_thread_fsm::call_thread_fsm): Rename from
5258         new_call_thread_fsm.
5259         (call_thread_fsm::should_stop): Rename from
5260         call_thread_fsm_should_stop.
5261         (call_thread_fsm::should_notify_stop): Rename from
5262         call_thread_fsm_should_notify_stop.
5263         (run_inferior_call, call_function_by_hand_dummy): Update.
5264         * cli/cli-interp.c (should_print_stop_to_console): Update.
5265         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5266         Add constructor.  Change type of location_breakpoint,
5267         caller_breakpoint.
5268         (until_break_fsm_ops): Remove.
5269         (new_until_break_fsm): Remove.
5270         (until_break_fsm::should_stop): Rename from
5271         until_break_fsm_should_stop.
5272         (until_break_fsm::clean_up): Rename from
5273         until_break_fsm_clean_up.
5274         (until_break_fsm::do_async_reply_reason): Rename from
5275         until_break_fsm_async_reply_reason.
5276         (until_break_command): Update.
5277         * thread-fsm.c: Remove.
5278         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5279
5280 2019-02-07  Tom Tromey  <tom@tromey.com>
5281
5282         * yy-remap.h: Add include guard.
5283         * xtensa-tdep.h: Add include guard.
5284         * xcoffread.h: Rename include guard.
5285         * varobj-iter.h: Add include guard.
5286         * tui/tui.h: Rename include guard.
5287         * tui/tui-winsource.h: Rename include guard.
5288         * tui/tui-wingeneral.h: Rename include guard.
5289         * tui/tui-windata.h: Rename include guard.
5290         * tui/tui-win.h: Rename include guard.
5291         * tui/tui-stack.h: Rename include guard.
5292         * tui/tui-source.h: Rename include guard.
5293         * tui/tui-regs.h: Rename include guard.
5294         * tui/tui-out.h: Rename include guard.
5295         * tui/tui-layout.h: Rename include guard.
5296         * tui/tui-io.h: Rename include guard.
5297         * tui/tui-hooks.h: Rename include guard.
5298         * tui/tui-file.h: Rename include guard.
5299         * tui/tui-disasm.h: Rename include guard.
5300         * tui/tui-data.h: Rename include guard.
5301         * tui/tui-command.h: Rename include guard.
5302         * tic6x-tdep.h: Add include guard.
5303         * target/waitstatus.h: Rename include guard.
5304         * target/wait.h: Rename include guard.
5305         * target/target.h: Rename include guard.
5306         * target/resume.h: Rename include guard.
5307         * target-float.h: Rename include guard.
5308         * stabsread.h: Add include guard.
5309         * rs6000-tdep.h: Add include guard.
5310         * riscv-fbsd-tdep.h: Add include guard.
5311         * regformats/regdef.h: Rename include guard.
5312         * record.h: Rename include guard.
5313         * python/python.h: Rename include guard.
5314         * python/python-internal.h: Rename include guard.
5315         * python/py-stopevent.h: Rename include guard.
5316         * python/py-ref.h: Rename include guard.
5317         * python/py-record.h: Rename include guard.
5318         * python/py-record-full.h: Rename include guard.
5319         * python/py-record-btrace.h: Rename include guard.
5320         * python/py-instruction.h: Rename include guard.
5321         * python/py-events.h: Rename include guard.
5322         * python/py-event.h: Rename include guard.
5323         * procfs.h: Add include guard.
5324         * proc-utils.h: Add include guard.
5325         * p-lang.h: Add include guard.
5326         * or1k-tdep.h: Rename include guard.
5327         * observable.h: Rename include guard.
5328         * nto-tdep.h: Rename include guard.
5329         * nat/x86-linux.h: Rename include guard.
5330         * nat/x86-linux-dregs.h: Rename include guard.
5331         * nat/x86-gcc-cpuid.h: Add include guard.
5332         * nat/x86-dregs.h: Rename include guard.
5333         * nat/x86-cpuid.h: Rename include guard.
5334         * nat/ppc-linux.h: Rename include guard.
5335         * nat/mips-linux-watch.h: Rename include guard.
5336         * nat/linux-waitpid.h: Rename include guard.
5337         * nat/linux-ptrace.h: Rename include guard.
5338         * nat/linux-procfs.h: Rename include guard.
5339         * nat/linux-osdata.h: Rename include guard.
5340         * nat/linux-nat.h: Rename include guard.
5341         * nat/linux-namespaces.h: Rename include guard.
5342         * nat/linux-btrace.h: Rename include guard.
5343         * nat/glibc_thread_db.h: Rename include guard.
5344         * nat/gdb_thread_db.h: Rename include guard.
5345         * nat/gdb_ptrace.h: Rename include guard.
5346         * nat/fork-inferior.h: Rename include guard.
5347         * nat/amd64-linux-siginfo.h: Rename include guard.
5348         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5349         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5350         * nat/aarch64-linux.h: Rename include guard.
5351         * nat/aarch64-linux-hw-point.h: Rename include guard.
5352         * mn10300-tdep.h: Add include guard.
5353         * mips-linux-tdep.h: Add include guard.
5354         * mi/mi-parse.h: Rename include guard.
5355         * mi/mi-out.h: Rename include guard.
5356         * mi/mi-main.h: Rename include guard.
5357         * mi/mi-interp.h: Rename include guard.
5358         * mi/mi-getopt.h: Rename include guard.
5359         * mi/mi-console.h: Rename include guard.
5360         * mi/mi-common.h: Rename include guard.
5361         * mi/mi-cmds.h: Rename include guard.
5362         * mi/mi-cmd-break.h: Rename include guard.
5363         * m2-lang.h: Add include guard.
5364         * location.h: Rename include guard.
5365         * linux-record.h: Rename include guard.
5366         * linux-nat.h: Add include guard.
5367         * linux-fork.h: Add include guard.
5368         * i386-darwin-tdep.h: Rename include guard.
5369         * hppa-linux-offsets.h: Add include guard.
5370         * guile/guile.h: Rename include guard.
5371         * guile/guile-internal.h: Rename include guard.
5372         * gnu-nat.h: Rename include guard.
5373         * gdb-stabs.h: Rename include guard.
5374         * frv-tdep.h: Add include guard.
5375         * f-lang.h: Add include guard.
5376         * event-loop.h: Add include guard.
5377         * darwin-nat.h: Rename include guard.
5378         * cp-abi.h: Rename include guard.
5379         * config/sparc/nm-sol2.h: Rename include guard.
5380         * config/nm-nto.h: Rename include guard.
5381         * config/nm-linux.h: Add include guard.
5382         * config/i386/nm-i386gnu.h: Rename include guard.
5383         * config/djgpp/nl_types.h: Rename include guard.
5384         * config/djgpp/langinfo.h: Rename include guard.
5385         * compile/gcc-cp-plugin.h: Add include guard.
5386         * compile/gcc-c-plugin.h: Add include guard.
5387         * compile/compile.h: Rename include guard.
5388         * compile/compile-object-run.h: Rename include guard.
5389         * compile/compile-object-load.h: Rename include guard.
5390         * compile/compile-internal.h: Rename include guard.
5391         * compile/compile-cplus.h: Rename include guard.
5392         * compile/compile-c.h: Rename include guard.
5393         * common/xml-utils.h: Rename include guard.
5394         * common/x86-xstate.h: Rename include guard.
5395         * common/version.h: Rename include guard.
5396         * common/vec.h: Rename include guard.
5397         * common/tdesc.h: Rename include guard.
5398         * common/selftest.h: Rename include guard.
5399         * common/scoped_restore.h: Rename include guard.
5400         * common/scoped_mmap.h: Rename include guard.
5401         * common/scoped_fd.h: Rename include guard.
5402         * common/safe-iterator.h: Rename include guard.
5403         * common/run-time-clock.h: Rename include guard.
5404         * common/refcounted-object.h: Rename include guard.
5405         * common/queue.h: Rename include guard.
5406         * common/ptid.h: Rename include guard.
5407         * common/print-utils.h: Rename include guard.
5408         * common/preprocessor.h: Rename include guard.
5409         * common/pathstuff.h: Rename include guard.
5410         * common/observable.h: Rename include guard.
5411         * common/netstuff.h: Rename include guard.
5412         * common/job-control.h: Rename include guard.
5413         * common/host-defs.h: Rename include guard.
5414         * common/gdb_wait.h: Rename include guard.
5415         * common/gdb_vecs.h: Rename include guard.
5416         * common/gdb_unlinker.h: Rename include guard.
5417         * common/gdb_unique_ptr.h: Rename include guard.
5418         * common/gdb_tilde_expand.h: Rename include guard.
5419         * common/gdb_sys_time.h: Rename include guard.
5420         * common/gdb_string_view.h: Rename include guard.
5421         * common/gdb_splay_tree.h: Rename include guard.
5422         * common/gdb_setjmp.h: Rename include guard.
5423         * common/gdb_ref_ptr.h: Rename include guard.
5424         * common/gdb_optional.h: Rename include guard.
5425         * common/gdb_locale.h: Rename include guard.
5426         * common/gdb_assert.h: Rename include guard.
5427         * common/filtered-iterator.h: Rename include guard.
5428         * common/filestuff.h: Rename include guard.
5429         * common/fileio.h: Rename include guard.
5430         * common/environ.h: Rename include guard.
5431         * common/common-utils.h: Rename include guard.
5432         * common/common-types.h: Rename include guard.
5433         * common/common-regcache.h: Rename include guard.
5434         * common/common-inferior.h: Rename include guard.
5435         * common/common-gdbthread.h: Rename include guard.
5436         * common/common-exceptions.h: Rename include guard.
5437         * common/common-defs.h: Rename include guard.
5438         * common/common-debug.h: Rename include guard.
5439         * common/cleanups.h: Rename include guard.
5440         * common/buffer.h: Rename include guard.
5441         * common/btrace-common.h: Rename include guard.
5442         * common/break-common.h: Rename include guard.
5443         * cli/cli-utils.h: Rename include guard.
5444         * cli/cli-style.h: Rename include guard.
5445         * cli/cli-setshow.h: Rename include guard.
5446         * cli/cli-script.h: Rename include guard.
5447         * cli/cli-interp.h: Rename include guard.
5448         * cli/cli-decode.h: Rename include guard.
5449         * cli/cli-cmds.h: Rename include guard.
5450         * charset-list.h: Add include guard.
5451         * buildsym-legacy.h: Rename include guard.
5452         * bfin-tdep.h: Add include guard.
5453         * ax.h: Rename include guard.
5454         * arm-linux-tdep.h: Add include guard.
5455         * arm-fbsd-tdep.h: Add include guard.
5456         * arch/xtensa.h: Rename include guard.
5457         * arch/tic6x.h: Add include guard.
5458         * arch/i386.h: Add include guard.
5459         * arch/arm.h: Rename include guard.
5460         * arch/arm-linux.h: Rename include guard.
5461         * arch/arm-get-next-pcs.h: Rename include guard.
5462         * arch/amd64.h: Add include guard.
5463         * arch/aarch64-insn.h: Rename include guard.
5464         * arch-utils.h: Rename include guard.
5465         * annotate.h: Add include guard.
5466         * amd64-darwin-tdep.h: Rename include guard.
5467         * aarch64-linux-tdep.h: Add include guard.
5468         * aarch64-fbsd-tdep.h: Add include guard.
5469         * aarch32-linux-nat.h: Add include guard.
5470
5471 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5472
5473         * macrotab.c (macro_define_internal): New function that
5474         factorizes macro_define_object_internal and macro_define_function
5475         code.
5476         (macro_define_object_internal): Use macro_define_internal.
5477         (macro_define_function): Likewise.
5478
5479 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5480
5481         * macrocmd.c (extract_identifier): Return
5482         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5483         callers.
5484
5485 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5486
5487         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5488
5489 2019-02-05  Tom Tromey  <tom@tromey.com>
5490
5491         * target.c (target_stack::unpush): Move assertion earlier.
5492
5493 2019-01-30  Tom Tromey  <tom@tromey.com>
5494
5495         PR python/23615:
5496         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5497         (gdbpy_parse_and_eval): Likewise.
5498         * python/python-internal.h (gdbpy_allow_threads): New class.
5499
5500 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5501
5502         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5503         (aarch64_fbsd_fpregmap): Move earlier.
5504         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5505         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5506         instead of individual calls to trad_frame_set_reg_addr.
5507         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5508         earlier.
5509         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5510         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5511         instead of individual calls to trad_frame_set_reg_addr.
5512
5513 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5514
5515         * CONTRIBUTE: Replace contribution list with wiki link.
5516
5517 2019-01-25  Tom Tromey  <tom@tromey.com>
5518
5519         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5520
5521 2019-01-25  Tom Tromey  <tom@tromey.com>
5522
5523         * xtensa-linux-nat.c: Fix common/ includes.
5524         * xml-support.h: Fix common/ includes.
5525         * xml-support.c: Fix common/ includes.
5526         * x86-linux-nat.c: Fix common/ includes.
5527         * windows-nat.c: Fix common/ includes.
5528         * varobj.h: Fix common/ includes.
5529         * varobj.c: Fix common/ includes.
5530         * value.c: Fix common/ includes.
5531         * valops.c: Fix common/ includes.
5532         * utils.c: Fix common/ includes.
5533         * unittests/xml-utils-selftests.c: Fix common/ includes.
5534         * unittests/utils-selftests.c: Fix common/ includes.
5535         * unittests/unpack-selftests.c: Fix common/ includes.
5536         * unittests/tracepoint-selftests.c: Fix common/ includes.
5537         * unittests/style-selftests.c: Fix common/ includes.
5538         * unittests/string_view-selftests.c: Fix common/ includes.
5539         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5540         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5541         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5542         * unittests/rsp-low-selftests.c: Fix common/ includes.
5543         * unittests/parse-connection-spec-selftests.c: Fix common/
5544         includes.
5545         * unittests/optional-selftests.c: Fix common/ includes.
5546         * unittests/offset-type-selftests.c: Fix common/ includes.
5547         * unittests/observable-selftests.c: Fix common/ includes.
5548         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5549         * unittests/memrange-selftests.c: Fix common/ includes.
5550         * unittests/memory-map-selftests.c: Fix common/ includes.
5551         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5552         * unittests/function-view-selftests.c: Fix common/ includes.
5553         * unittests/environ-selftests.c: Fix common/ includes.
5554         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5555         * unittests/common-utils-selftests.c: Fix common/ includes.
5556         * unittests/cli-utils-selftests.c: Fix common/ includes.
5557         * unittests/array-view-selftests.c: Fix common/ includes.
5558         * ui-file.c: Fix common/ includes.
5559         * tui/tui-io.c: Fix common/ includes.
5560         * tracepoint.h: Fix common/ includes.
5561         * tracepoint.c: Fix common/ includes.
5562         * tracefile-tfile.c: Fix common/ includes.
5563         * top.h: Fix common/ includes.
5564         * top.c: Fix common/ includes.
5565         * thread.c: Fix common/ includes.
5566         * target/waitstatus.h: Fix common/ includes.
5567         * target/waitstatus.c: Fix common/ includes.
5568         * target.h: Fix common/ includes.
5569         * target.c: Fix common/ includes.
5570         * target-memory.c: Fix common/ includes.
5571         * target-descriptions.c: Fix common/ includes.
5572         * symtab.h: Fix common/ includes.
5573         * symfile.c: Fix common/ includes.
5574         * stap-probe.c: Fix common/ includes.
5575         * spu-linux-nat.c: Fix common/ includes.
5576         * sparc-nat.c: Fix common/ includes.
5577         * source.c: Fix common/ includes.
5578         * solib.c: Fix common/ includes.
5579         * solib-target.c: Fix common/ includes.
5580         * ser-unix.c: Fix common/ includes.
5581         * ser-tcp.c: Fix common/ includes.
5582         * ser-pipe.c: Fix common/ includes.
5583         * ser-base.c: Fix common/ includes.
5584         * selftest-arch.c: Fix common/ includes.
5585         * s12z-tdep.c: Fix common/ includes.
5586         * rust-exp.y: Fix common/ includes.
5587         * rs6000-aix-tdep.c: Fix common/ includes.
5588         * riscv-tdep.c: Fix common/ includes.
5589         * remote.c: Fix common/ includes.
5590         * remote-notif.h: Fix common/ includes.
5591         * remote-fileio.h: Fix common/ includes.
5592         * remote-fileio.c: Fix common/ includes.
5593         * regcache.h: Fix common/ includes.
5594         * regcache.c: Fix common/ includes.
5595         * record-btrace.c: Fix common/ includes.
5596         * python/python.c: Fix common/ includes.
5597         * python/py-type.c: Fix common/ includes.
5598         * python/py-inferior.c: Fix common/ includes.
5599         * progspace.h: Fix common/ includes.
5600         * producer.c: Fix common/ includes.
5601         * procfs.c: Fix common/ includes.
5602         * proc-api.c: Fix common/ includes.
5603         * printcmd.c: Fix common/ includes.
5604         * ppc-linux-nat.c: Fix common/ includes.
5605         * parser-defs.h: Fix common/ includes.
5606         * osdata.c: Fix common/ includes.
5607         * obsd-nat.c: Fix common/ includes.
5608         * nat/x86-linux.c: Fix common/ includes.
5609         * nat/x86-linux-dregs.c: Fix common/ includes.
5610         * nat/x86-dregs.h: Fix common/ includes.
5611         * nat/x86-dregs.c: Fix common/ includes.
5612         * nat/ppc-linux.c: Fix common/ includes.
5613         * nat/mips-linux-watch.h: Fix common/ includes.
5614         * nat/mips-linux-watch.c: Fix common/ includes.
5615         * nat/linux-waitpid.c: Fix common/ includes.
5616         * nat/linux-ptrace.h: Fix common/ includes.
5617         * nat/linux-ptrace.c: Fix common/ includes.
5618         * nat/linux-procfs.c: Fix common/ includes.
5619         * nat/linux-personality.c: Fix common/ includes.
5620         * nat/linux-osdata.c: Fix common/ includes.
5621         * nat/linux-namespaces.c: Fix common/ includes.
5622         * nat/linux-btrace.h: Fix common/ includes.
5623         * nat/linux-btrace.c: Fix common/ includes.
5624         * nat/fork-inferior.c: Fix common/ includes.
5625         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5626         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5627         * nat/aarch64-linux.c: Fix common/ includes.
5628         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5629         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5630         * namespace.h: Fix common/ includes.
5631         * mips-linux-tdep.c: Fix common/ includes.
5632         * minsyms.c: Fix common/ includes.
5633         * mi/mi-parse.h: Fix common/ includes.
5634         * mi/mi-main.c: Fix common/ includes.
5635         * mi/mi-cmd-env.c: Fix common/ includes.
5636         * memrange.h: Fix common/ includes.
5637         * memattr.c: Fix common/ includes.
5638         * maint.h: Fix common/ includes.
5639         * maint.c: Fix common/ includes.
5640         * main.c: Fix common/ includes.
5641         * machoread.c: Fix common/ includes.
5642         * location.c: Fix common/ includes.
5643         * linux-thread-db.c: Fix common/ includes.
5644         * linux-nat.c: Fix common/ includes.
5645         * linux-fork.c: Fix common/ includes.
5646         * inline-frame.c: Fix common/ includes.
5647         * infrun.c: Fix common/ includes.
5648         * inflow.c: Fix common/ includes.
5649         * inferior.h: Fix common/ includes.
5650         * inferior.c: Fix common/ includes.
5651         * infcmd.c: Fix common/ includes.
5652         * inf-ptrace.c: Fix common/ includes.
5653         * inf-child.c: Fix common/ includes.
5654         * ia64-linux-nat.c: Fix common/ includes.
5655         * i387-tdep.c: Fix common/ includes.
5656         * i386-tdep.c: Fix common/ includes.
5657         * i386-linux-tdep.c: Fix common/ includes.
5658         * i386-linux-nat.c: Fix common/ includes.
5659         * i386-go32-tdep.c: Fix common/ includes.
5660         * i386-fbsd-tdep.c: Fix common/ includes.
5661         * i386-fbsd-nat.c: Fix common/ includes.
5662         * guile/scm-type.c: Fix common/ includes.
5663         * guile/guile.c: Fix common/ includes.
5664         * go32-nat.c: Fix common/ includes.
5665         * gnu-nat.c: Fix common/ includes.
5666         * gdbthread.h: Fix common/ includes.
5667         * gdbarch-selftests.c: Fix common/ includes.
5668         * gdb_usleep.c: Fix common/ includes.
5669         * gdb_select.h: Fix common/ includes.
5670         * gdb_bfd.c: Fix common/ includes.
5671         * gcore.c: Fix common/ includes.
5672         * fork-child.c: Fix common/ includes.
5673         * findvar.c: Fix common/ includes.
5674         * fbsd-nat.c: Fix common/ includes.
5675         * event-top.c: Fix common/ includes.
5676         * event-loop.c: Fix common/ includes.
5677         * dwarf2read.c: Fix common/ includes.
5678         * dwarf2loc.c: Fix common/ includes.
5679         * dwarf2-frame.c: Fix common/ includes.
5680         * dwarf-index-cache.c: Fix common/ includes.
5681         * dtrace-probe.c: Fix common/ includes.
5682         * disasm-selftests.c: Fix common/ includes.
5683         * defs.h: Fix common/ includes.
5684         * csky-tdep.c: Fix common/ includes.
5685         * cp-valprint.c: Fix common/ includes.
5686         * cp-support.h: Fix common/ includes.
5687         * cp-support.c: Fix common/ includes.
5688         * corelow.c: Fix common/ includes.
5689         * completer.h: Fix common/ includes.
5690         * completer.c: Fix common/ includes.
5691         * compile/compile.c: Fix common/ includes.
5692         * compile/compile-loc2c.c: Fix common/ includes.
5693         * compile/compile-cplus-types.c: Fix common/ includes.
5694         * compile/compile-cplus-symbols.c: Fix common/ includes.
5695         * command.h: Fix common/ includes.
5696         * cli/cli-dump.c: Fix common/ includes.
5697         * cli/cli-cmds.c: Fix common/ includes.
5698         * charset.c: Fix common/ includes.
5699         * build-id.c: Fix common/ includes.
5700         * btrace.h: Fix common/ includes.
5701         * btrace.c: Fix common/ includes.
5702         * breakpoint.h: Fix common/ includes.
5703         * breakpoint.c: Fix common/ includes.
5704         * ax.h:
5705         (enum agent_op): Fix common/ includes.
5706         * ax-general.c (struct aop_map): Fix common/ includes.
5707         * ax-gdb.c: Fix common/ includes.
5708         * auxv.c: Fix common/ includes.
5709         * auto-load.c: Fix common/ includes.
5710         * arm-tdep.c: Fix common/ includes.
5711         * arch/riscv.c: Fix common/ includes.
5712         * arch/ppc-linux-common.c: Fix common/ includes.
5713         * arch/i386.c: Fix common/ includes.
5714         * arch/arm.c: Fix common/ includes.
5715         * arch/arm-linux.c: Fix common/ includes.
5716         * arch/arm-get-next-pcs.c: Fix common/ includes.
5717         * arch/amd64.c: Fix common/ includes.
5718         * arch/aarch64.c: Fix common/ includes.
5719         * arch/aarch64-insn.c: Fix common/ includes.
5720         * arch-utils.c: Fix common/ includes.
5721         * amd64-windows-tdep.c: Fix common/ includes.
5722         * amd64-tdep.c: Fix common/ includes.
5723         * amd64-sol2-tdep.c: Fix common/ includes.
5724         * amd64-obsd-tdep.c: Fix common/ includes.
5725         * amd64-nbsd-tdep.c: Fix common/ includes.
5726         * amd64-linux-tdep.c: Fix common/ includes.
5727         * amd64-linux-nat.c: Fix common/ includes.
5728         * amd64-fbsd-tdep.c: Fix common/ includes.
5729         * amd64-fbsd-nat.c: Fix common/ includes.
5730         * amd64-dicos-tdep.c: Fix common/ includes.
5731         * amd64-darwin-tdep.c: Fix common/ includes.
5732         * agent.c: Fix common/ includes.
5733         * ada-lang.h: Fix common/ includes.
5734         * ada-lang.c: Fix common/ includes.
5735         * aarch64-tdep.c: Fix common/ includes.
5736
5737 2019-01-25  Tom Tromey  <tom@tromey.com>
5738
5739         * common/create-version.sh: Use common/version.h.
5740
5741 2019-01-24  Pedro Alves  <palves@redhat.com>
5742
5743         * infrun.c (signal_stop, signal_print, signal_program)
5744         (signal_catch, signal_pass): Now arrays instead of pointers.
5745         (update_signals_program_target, do_target_resume)
5746         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5747         * linux-nat.c (linux_nat_target::pass_signals)
5748         (linux_nat_target::create_inferior, linux_nat_target::attach):
5749         Adjust.
5750         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5751         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5752         * procfs.c (procfs_target::pass_signals): Adjust.
5753         * record-full.c (record_full_target::resume): Adjust.
5754         * remote.c (remote_target::pass_signals)
5755         (remote_target::program_signals): Adjust.
5756         * target-debug.h (target_debug_print_signals): Now takes a
5757         gdb::array_view as parameter.  Adjust.
5758         * target.h (target_ops) <pass_signals, program_signals>: Replace
5759         pointer and length parameters with gdb::array_view.
5760         (target_pass_signals, target_program_signals): Likewise.
5761         * target-delegates.c: Regenerate.
5762
5763 2019-01-24  Pedro Alves  <palves@redhat.com>
5764
5765         * common/forward-scope-exit.h
5766         (forward_scope_exit::forward_scope_exit): Pass arguments to
5767         m_bind_function directly, instead of creating a std::bind and
5768         copying that.
5769
5770 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5771
5772         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5773         for static members.
5774         (pass_in_v_vfp_candidate): Likewise.
5775
5776 2019-01-23  Tom Tromey  <tom@tromey.com>
5777             Pedro Alves  <palves@redhat.com>
5778
5779         * regcache.c (class regcache_invalidator): Remove.
5780         (regcache::raw_write): Use make_scope_exit.
5781
5782 2019-01-23  Tom Tromey  <tom@tromey.com>
5783
5784         * ui-out.h (class ui_out_emit_type): Update comment.
5785
5786 2019-01-23  Tom Tromey  <tom@tromey.com>
5787
5788         * infrun.c (fetch_inferior_event): Update comment.
5789
5790 2019-01-23  Tom Tromey  <tom@tromey.com>
5791             Pedro Alves  <palves@redhat.com>
5792
5793         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5794         parameter.
5795         (fetch_inferior_event): Use SCOPE_EXIT.
5796
5797
5798 2019-01-23  Tom Tromey  <tom@tromey.com>
5799             Pedro Alves  <palves@redhat.com>
5800
5801         * infrun.c (disable_thread_events): Delete.
5802         (stop_all_threads): Use SCOPE_EXIT.
5803
5804 2019-01-23  Tom Tromey  <tom@tromey.com>
5805             Pedro Alves  <palves@redhat.com>
5806
5807         * symfile.c: Include forward-scope-exit.h.
5808         (clear_symtab_users_cleanup): Replace forward declaration with
5809         a FORWARD_SCOPE_EXIT.
5810         (syms_from_objfile_1): Use the forward_scope_exit and
5811         gdb::optional instead of cleanup_function.
5812         (reread_symbols): Use the forward_scope_exit instead of
5813         cleanup_function.
5814         (clear_symtab_users_cleanup): Remove function.
5815
5816 2019-01-23  Tom Tromey  <tom@tromey.com>
5817             Pedro Alves  <palves@redhat.com>
5818
5819         * linux-nat.c: Include scope-exit.h.
5820         (cleanup_target_stop): Remove.
5821         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5822         SCOPE_EXIT.
5823
5824 2019-01-23  Tom Tromey  <tom@tromey.com>
5825             Pedro Alves  <palves@redhat.com>
5826
5827         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5828         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5829
5830 2019-01-23  Tom Tromey  <tom@tromey.com>
5831             Andrew Burgess  <andrew.burgess@embecosm.com>
5832             Pedro Alves  <palves@redhat.com>
5833
5834         * infrun.c (fetch_inferior_event): Use scope_exit.
5835         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5836         * top.c (execute_command): Use scope_exit.
5837         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5838         * utils.c (do_bpstat_clear_actions_cleanup)
5839         (make_bpstat_clear_actions_cleanup): Remove.
5840
5841 2019-01-23  Tom Tromey  <tom@tromey.com>
5842             Pedro Alves  <palves@redhat.com>
5843
5844         * infrun.c: Include "common/scope-exit.h"
5845         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5846         (wait_for_inferior): Use SCOPE_EXIT.
5847         (fetch_inferior_event): Use scope_exit.
5848
5849 2019-01-23  Tom Tromey  <tom@tromey.com>
5850             Pedro Alves  <palves@redhat.com>
5851
5852         * breakpoint.c (create_breakpoint): Remove cleanup.
5853
5854 2019-01-23  Tom Tromey  <tom@tromey.com>
5855             Andrew Burgess  <andrew.burgess@embecosm.com>
5856             Pedro Alves  <palves@redhat.com>
5857
5858 2019-01-23  Pedro Alves  <palves@redhat.com>
5859
5860         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5861
5862 2019-01-23  Pedro Alves  <palves@redhat.com>
5863             Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * gdbthread.h: Include "common/forward-scope-exit.h".
5866         (scoped_finish_thread_state): Redefine custom class in terms of
5867         forward_scope_exit.
5868
5869 2019-01-23  Pedro Alves  <palves@redhat.com>
5870             Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * common/forward-scope-exit.h: New file.
5873
5874 2019-01-23  Pedro Alves  <palves@redhat.com>
5875             Andrew Burgess  <andrew.burgess@embecosm.com>
5876             Tom Tromey  <tom@tromey.com>
5877
5878         * common/scope-exit.h: New file.
5879
5880 2019-01-23  Pedro Alves  <palves@redhat.com>
5881
5882         * common/preprocessor.h (ESC): Rename to ...
5883         (ESC_PARENS): ... this.
5884         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5885         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5886
5887 2019-01-23  Tom Tromey  <tom@tromey.com>
5888
5889         * language.h (class scoped_switch_to_sym_language_if_auto):
5890         Initialize m_lang in both cases.
5891
5892 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5893
5894         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5895         with XCNEW.
5896
5897 2019-01-22  Tom Tromey  <tom@tromey.com>
5898
5899         * corelow.c: Do not include sys/file.h.
5900
5901 2019-01-22  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-wingeneral.h: Include gdb_curses.h.
5904
5905 2019-01-22  Tom Tromey  <tom@tromey.com>
5906
5907         * source-cache.h (class source_cache) <get_source_lines,
5908         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5909
5910 2019-01-22  Tom Tromey  <tom@tromey.com>
5911
5912         * remote-fileio.h (struct remote_target): Declare.
5913
5914 2019-01-22  Tom Tromey  <tom@tromey.com>
5915
5916         * python/py-arch.c: Do not include py-ref.h.
5917         * python/py-bpevent.c: Do not include py-ref.h.
5918         * python/py-cmd.c: Do not include py-ref.h.
5919         * python/py-continueevent.c: Do not include py-ref.h.
5920         * python/py-event.h: Do not include py-ref.h.
5921         * python/py-evtregistry.c: Do not include py-ref.h.
5922         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5923         * python/py-frame.c: Do not include py-ref.h.
5924         * python/py-framefilter.c: Do not include py-ref.h.
5925         * python/py-function.c: Do not include py-ref.h.
5926         * python/py-infevents.c: Do not include py-ref.h.
5927         * python/py-linetable.c: Do not include py-ref.h.
5928         * python/py-objfile.c: Do not include py-ref.h.
5929         * python/py-param.c: Do not include py-ref.h.
5930         * python/py-prettyprint.c: Do not include py-ref.h.
5931         * python/py-progspace.c: Do not include py-ref.h.
5932         * python/py-symbol.c: Do not include py-ref.h.
5933         * python/py-symtab.c: Do not include py-ref.h.
5934         * python/py-type.c: Do not include py-ref.h.
5935         * python/py-unwind.c: Do not include py-ref.h.
5936         * python/py-utils.c: Do not include py-ref.h.
5937         * python/py-value.c: Do not include py-ref.h.
5938         * python/py-varobj.c: Do not include py-ref.h.
5939         * python/py-xmethods.c: Do not include py-ref.h.
5940         * python/python.c: Do not include py-ref.h.
5941         * varobj.c: Do not include py-ref.h.
5942
5943 2019-01-22  Tom Tromey  <tom@tromey.com>
5944
5945         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5946         keyword for bcache.
5947
5948 2019-01-22  Tom Tromey  <tom@tromey.com>
5949
5950         * compile/compile-cplus-types.c: Remove a comment by #include.
5951
5952 2019-01-22  Tom Tromey  <tom@tromey.com>
5953
5954         * compile/gcc-c-plugin.h: Include compile-internal.h.
5955
5956 2019-01-22  Tom Tromey  <tom@tromey.com>
5957
5958         * stabsread.c (EXTERN): Do not define.
5959         (symnum, next_symbol_text_func, processing_gcc_compilation)
5960         (within_function, global_sym_chain, global_stabs)
5961         (previous_stab_code, this_object_header_files)
5962         (n_this_object_header_files)
5963         (n_allocated_this_object_header_files): Define.
5964         * stabsread.h (EXTERN): Never define.  Use "extern".
5965
5966 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5967
5968         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5969         history_value.
5970
5971 2019-01-21  Tom Tromey  <tom@tromey.com>
5972
5973         * ui-out.c: Fix includes.
5974         * tui/tui-source.c: Fix includes.
5975         * target.c: Fix includes.
5976         * remote.c: Fix includes.
5977         * regcache.c: Fix includes.
5978         * python/py-block.c: Fix includes.
5979         * printcmd.c: Fix includes.
5980         * or1k-tdep.c: Fix includes.
5981         * mi/mi-main.c: Fix includes.
5982         * m32r-tdep.c: Fix includes.
5983         * csky-tdep.c: Fix includes.
5984         * compile/compile-cplus-types.c: Fix includes.
5985         * cli/cli-interp.c: Fix includes.
5986
5987 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5988
5989         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5990         for padding.
5991
5992 2019-01-16  Tom Tromey  <tom@tromey.com>
5993
5994         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5995         earlier.
5996         (struct objfile) <msymbols_range>: Move from top level.
5997         <msymbols>: New method.
5998         (class objfile_msymbols): Remove.
5999         * symtab.c (default_collect_symbol_completion_matches_break_on):
6000         Update.
6001         * symmisc.c (dump_msymbols): Update.
6002         * stabsread.c (scan_file_globals): Update.
6003         * objc-lang.c (info_selectors_command, info_classes_command)
6004         (find_methods): Update.
6005         * minsyms.c (find_solib_trampoline_target): Update.
6006         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6007         * coffread.c (coff_symfile_read): Update.
6008         * ada-lang.c (ada_lookup_simple_minsym)
6009         (ada_collect_symbol_completion_matches): Update.
6010
6011 2019-01-16  Tom Tromey  <tom@tromey.com>
6012
6013         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6014         type.  Remove no-argument constructor.
6015         <iterator::operator++>: Simplify.
6016         <begin>: Update.
6017         <end>: Use minimal_symbol_count.
6018
6019 2019-01-16  Tom Tromey  <tom@tromey.com>
6020
6021         * objfiles.h (struct objfile) <psymtabs>: New method.
6022         (class objfile_psymtabs): Remove.
6023         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6024         typedef.
6025         <range>: New method.
6026         (require_partial_symbols): Change return type.
6027         * psymtab.c (require_partial_symbols)
6028         (psym_expand_symtabs_matching): Update.
6029         * mdebugread.c (parse_partial_symbols): Update.
6030         * dbxread.c (dbx_end_psymtab): Update.
6031
6032 2019-01-15  Tom Tromey  <tom@tromey.com>
6033
6034         * symtab.c (lookup_objfile_from_block)
6035         (lookup_symbol_in_objfile_symtabs)
6036         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6037         (find_line_symtab, info_sources_command)
6038         (default_collect_symbol_completion_matches_break_on)
6039         (make_source_files_completion_list): Update.
6040         * symmisc.c (print_objfile_statistics, dump_objfile)
6041         (maintenance_print_symbols, maintenance_info_symtabs)
6042         (maintenance_check_symtabs, maintenance_info_line_tables):
6043         Update.
6044         * source.c (select_source_symtab)
6045         (forget_cached_source_info_for_objfile): Update.
6046         * objfiles.h (class objfile_compunits): Remove.
6047         (struct objfile) <compunits_range>: New typedef.
6048         (compunits): New method.
6049         * objfiles.c (objfile_relocate1): Update.
6050         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6051         * maint.c (count_symtabs_and_blocks): Update.
6052         * linespec.c (iterate_over_all_matching_symtabs): Update.
6053         * cp-support.c (add_symbol_overload_list_qualified): Update.
6054         * coffread.c (coff_symtab_read): Update.
6055         * ada-lang.c (add_nonlocal_symbols)
6056         (ada_collect_symbol_completion_matches)
6057         (ada_add_global_exceptions): Update.
6058
6059 2019-01-15  Tom Tromey  <tom@tromey.com>
6060
6061         * progspace.h (program_space) <objfiles_safe_range>: New
6062         typedef.
6063         <objfiles_safe>: New method.
6064         * objfiles.h (class all_objfiles_safe): Remove.
6065         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6066         * jit.c (jit_inferior_exit_hook): Update.
6067
6068 2019-01-17  Tom Tromey  <tom@tromey.com>
6069
6070         * progspace.h (program_space) <objfiles_range>: New typedef.
6071         <objfiles>: New method.
6072         <objfiles_head>: Rename from objfiles.
6073         (object_files): Update.
6074         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6075         * guile/scm-pretty-print.c
6076         (ppscm_find_pretty_printer_from_objfiles): Update.
6077         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6078         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6079         Update.
6080         * python/py-progspace.c (pspy_get_objfiles): Update.
6081         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6082         Update.
6083         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6084         (objfpy_lookup_objfile_by_build_id): Update.
6085         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6086         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6087         Update.
6088         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6089         (expand_symtab_containing_pc, lookup_objfile_from_block)
6090         (lookup_static_symbol, basic_lookup_transparent_type)
6091         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6092         (find_line_symtab, info_sources_command)
6093         (default_collect_symbol_completion_matches_break_on)
6094         (make_source_files_completion_list, find_main_name): Update.
6095         * symmisc.c (print_symbol_bcache_statistics)
6096         (print_objfile_statistics, maintenance_print_symbols)
6097         (maintenance_print_msymbols, maintenance_print_objfiles)
6098         (maintenance_info_symtabs, maintenance_check_symtabs)
6099         (maintenance_expand_symtabs, maintenance_info_line_tables):
6100         Update.
6101         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6102         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6103         (map_overlay_command, unmap_overlay_command)
6104         (simple_overlay_update, expand_symtabs_matching)
6105         (map_symbol_filenames): Update.
6106         * symfile-debug.c (set_debug_symfile): Update.
6107         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6108         Update.
6109         * source.c (select_source_symtab, forget_cached_source_info):
6110         Update.
6111         * solib.c (solib_read_symbols): Update.
6112         * solib-spu.c (append_ocl_sos): Update.
6113         * psymtab.c (maintenance_print_psymbols)
6114         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6115         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6116         * printcmd.c (info_symbol_command): Update.
6117         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6118         Update.
6119         * objfiles.h (class all_objfiles): Remove.
6120         * objfiles.c (have_partial_symbols, have_full_symbols)
6121         (have_minimal_symbols, qsort_cmp, update_section_map)
6122         (shared_objfile_contains_address_p)
6123         (default_iterate_over_objfiles_in_search_order): Update.
6124         * objc-lang.c (info_selectors_command, info_classes_command)
6125         (find_methods): Update.
6126         * minsyms.c (find_solib_trampoline_target): Update.
6127         * maint.c (maintenance_info_sections)
6128         (maintenance_translate_address, count_symtabs_and_blocks):
6129         Update.
6130         * main.c (captured_main_1): Update.
6131         * linux-thread-db.c (try_thread_db_load_from_pdir)
6132         (has_libpthread): Update.
6133         * linespec.c (iterate_over_all_matching_symtabs)
6134         (search_minsyms_for_name): Update.
6135         * jit.c (jit_find_objf_with_entry_addr): Update.
6136         * hppa-tdep.c (find_unwind_entry)
6137         (hppa_lookup_stub_minimal_symbol): Update.
6138         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6139         Update.
6140         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6141         (elf_gnu_ifunc_resolve_by_got): Update.
6142         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6143         * dwarf-index-write.c (save_gdb_index_command): Update.
6144         * cp-support.c (add_symbol_overload_list_qualified): Update.
6145         * breakpoint.c (create_overlay_event_breakpoint)
6146         (create_longjmp_master_breakpoint)
6147         (create_std_terminate_master_breakpoint)
6148         (create_exception_master_breakpoint): Update.
6149         * blockframe.c (find_pc_partial_function): Update.
6150         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6151         (ada_collect_symbol_completion_matches)
6152         (ada_add_global_exceptions): Update.
6153
6154 2019-01-17  Tom Tromey  <tom@tromey.com>
6155
6156         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6157         declare VEC.
6158         (solib_target_parse_libraries): Change return type.
6159         (library_list_start_segment, library_list_start_section)
6160         (library_list_end_library, library_list_start_library); Update.
6161         (solib_target_free_library_list): Remove.
6162         (solib_target_parse_libraries): Remove cleanup.  Change return
6163         type.
6164         (solib_target_current_sos): Update.
6165
6166 2019-01-17  Tom Tromey  <tromey@bapiya>
6167
6168         * valprint.c: Replace "the the" with "the".
6169         * symtab.c: Replace "the the" with "the".
6170         * solib.c: Replace "the the" with "the".
6171         * solib-dsbt.c: Replace "the the" with "the".
6172         * linespec.c: Replace "the the" with "the".
6173         * dwarf2loc.h: Replace "the the" with "the".
6174         * amd64-windows-tdep.c: Replace "the the" with "the".
6175         * aarch64-tdep.c: Replace "the the" with "the".
6176
6177 2019-01-16  Keith Seitz  <keiths@redhat.com>
6178
6179         PR gdb/23773
6180         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6181         <builder>: Rename to ..
6182         <m_builder>: ... this and make private.
6183         (dwarf2_cu::get_builder): New method.  Change all users of
6184         `builder' to use this method.
6185         (dwarf2_start_symtab): Move to ...
6186         (dwarf2_cu::start_symtab): ... here.  Update all callers
6187         (setup_type_unit_groups): Move to ...
6188         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6189         callers.
6190         (dwarf2_cu::reset_builder): New method.
6191         (process_full_compunit, process_full_type_unit): Use
6192         dwarf2_cu::reset_builder.
6193         (follow_die_offset): Record the ancestor CU if it is different
6194         from the followed DIE's CU.
6195         (follow_die_sig_1): Likewise.
6196
6197 2019-01-15  Tom Tromey  <tom@tromey.com>
6198
6199         * remote.c (class remote_state) <buf>: Now a char_vector.
6200         <buf_size>: Remove.
6201         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6202         parameter.
6203         (remote_target::getpkt_or_notif_sane_1)
6204         (remote_target::getpkt_sane)
6205         (remote_target::getpkt_or_notif_sane): Likewise.
6206         (class remote_target) <putpkt>: New overload.
6207         (remote_target::read_frame): Change type of "buf_p".  Remove
6208         sizeof_p parameter.
6209         (packet_ok): New overload.
6210         (packet_check_result): New overload.
6211         Update all uses.
6212
6213 2019-01-14  Tom Tromey  <tom@tromey.com>
6214
6215         * remote-notif.c (handle_notification, remote_notif_ack)
6216         (remote_notif_parse): Make "buf" const.
6217         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6218         const.
6219         (remote_notif_parse, remote_notif_ack, handle_notification):
6220         Likewise.
6221         * remote.c (remote_notif_stop_parse): Make "buf" const.
6222         (remote_target::remote_parse_stop_reply): Make "buf" const.
6223         (remote_notif_stop_ack): Make "buf" const.
6224
6225 2019-01-14  Tom Tromey  <tom@tromey.com>
6226
6227         * remote.c (remote_console_output): Make parameter const.
6228
6229 2019-01-14  Tom Tromey  <tom@tromey.com>
6230
6231         * target-debug.h (target_debug_print_signals): Constify.
6232         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6233         * procfs.c (procfs_target::pass_signals): Update.
6234         * linux-nat.c (linux_nat_target::pass_signals): Update.
6235         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6236         * target-delegates.c: Rebuild.
6237         * remote.c (remote_target::program_signals): Update.
6238         (remote_target::pass_signals): Update.
6239         * target.c (target_pass_signals): Constify argument.
6240         (target_program_signals): Likewise.
6241         * target.h (struct target_ops) <pass_signals, program_signals>:
6242         Constify argument.
6243         (target_pass_signals, target_program_signals): Constify argument.
6244
6245 2019-01-14  Tom Tromey  <tom@tromey.com>
6246
6247         PR tui/28819:
6248         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6249
6250 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6251
6252         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6253         field.
6254         * rs6000-tdep.c: Include reggroups.h.
6255         (IS_V_ALIAS_PSEUDOREG): Define.
6256         (rs6000_register_name): Return names for the "vX" aliases.
6257         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6258         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6259         aliases.  Call default_register_reggroup_p for all other
6260         pseudo-registers.
6261         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6262         New functions.
6263         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6264         Handle "vX" aliases.
6265         (v_alias_pseudo_register_collect): New function.
6266         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6267         (rs6000_gdbarch_init): Initialize "vX" aliases as
6268         pseudo-registers.  Restore registration of
6269         rs6000_pseudo_register_reggroup_p with
6270         set_tdesc_pseudo_register_reggroup_p.
6271
6272 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6273
6274         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6275         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6276         set_gdbarch_num_pseudo_regs.
6277
6278 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6279
6280         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6281         Remove arg prefixname, add do_set and do_show.
6282         Add member functions set_list and show_list.
6283         * cli/cli-style.c (class cli_style_option): Update accordingly.
6284         (style_set_list): Move to file scope.
6285         (style_show_list): Likewise.
6286         (set_style): Call help_list.
6287         (show_style): Call cmd_show_list.
6288         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6289         Update to use the new macro.
6290
6291 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6292
6293         * ada-lang.c (_initialize_ada_language): Expand the help text
6294         for the "catch exception" command.
6295
6296 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6297
6298         * symtab.c (matching_obj_sections): Initialize obj,
6299         declare it closer to its usage.
6300
6301 2019-01-10  Tom Tromey  <tom@tromey.com>
6302
6303         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6304         (basic_inf_threads_range): Remove.
6305         (inf_threads_range, inf_non_exited_threads_range)
6306         (safe_inf_threads_range): Use next_adapter.
6307
6308 2019-01-10  Keith Seitz  <keiths@redhat.com>
6309
6310         PR gdb/23712
6311         PR symtab/23010
6312         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6313         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6314
6315 2019-01-10  Keith Seitz  <keiths@redhat.com>
6316
6317         PR gdb/23712
6318         PR symtab/23010
6319         * dictionary.c (pending_to_vector): Remove.
6320         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6321         Remove _1 suffix, replacing functions of the same name.  Update
6322         all callers.
6323         (dict_create_hashed, dict_create_hashed_expandable)
6324         (dict_create_linear, dict_create_linear_expandable, dict_free)
6325         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6326         Make functions static.
6327
6328 2019-01-10  Keith Seitz  <keiths@redhat.com>
6329
6330         PR gdb/23712
6331         PR symtab/23010
6332         * dictionary.h (struct dictionary): Replace declaration with
6333         multidictionary.
6334         (dict_create_hashed, dict_create_hashed_expandable)
6335         (dict_create_linear, dict_create_linear_expandable)
6336         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6337         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6338         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6339         taking multidictionary argument.
6340         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6341         * block.h (struct block) <dict>: Change to multidictionary
6342         and rename `multidict'.
6343         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6344         symmisc.c: Update all dictionary references to multidictionary.
6345
6346 2019-01-10  Keith Seitz  <keiths@redhat.com>
6347
6348         PR gdb/23712
6349         PR symtab/23010
6350         * dictionary.c: Include unordered_map.
6351         (pending_to_vector): New function.
6352         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6353         Rewrite the non-"_1" functions to take vector instead
6354         of linked list.
6355         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6356         "new" _1 versions of the same name.
6357         (multidictionary): Define.
6358         (std::hash<enum language): New definition.
6359         (collate_pending_symbols_by_language, mdict_create_hashed)
6360         (mdict_create_hashed_expandable, mdict_create_linear)
6361         (mdict_create_linear_expandable, mdict_free)
6362         (find_language_dictionary, create_new_language_dictionary)
6363         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6364         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6365         (mdict_size, mdict_empty): New functions.
6366         * dictionary.h (mdict_iterator): Define.
6367
6368 2019-01-10  Pedro Alves  <palves@redhat.com>
6369
6370         * breakpoint.c (read_uploaded_action)
6371         (create_tracepoint_from_upload): Adjust to use
6372         gdb::unique_xmalloc_ptr.
6373         * ctf.c (ctf_write_uploaded_tp):
6374         (SET_ARRAY_FIELD): Use emplace_back.
6375         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6376         * tracefile-tfile.c (tfile_write_uploaded_tp):
6377         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6378         gdb::unique_xmalloc_ptr.
6379         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6380         at_string, cond_string, cmd_strings>: Replace char pointers
6381         with gdb::unique_xmalloc_ptr.
6382
6383 2019-01-10  Pedro Alves  <palves@redhat.com>
6384
6385         * solib-target.c (library_list_start_library): Don't xstrdup name.
6386
6387 2019-01-10  Pedro Alves  <palves@redhat.com>
6388
6389         * mdebugread.c (parse_partial_symbols): Use
6390         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6391
6392 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6393
6394         * linux-fork.c (scoped_switch_fork_info)
6395         <~scoped_switch_fork_info>: Fix incorrect variable name.
6396
6397 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * linux-fork.c (scoped_switch_fork_info)
6400         <scoped_switch_fork_info>: Make explicit.
6401         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6402
6403 2019-01-10  Tom Tromey  <tom@tromey.com>
6404
6405         * objfiles.h (objfile::reset_psymtabs): Update.
6406         * objfiles.c (objfile::objfile): Update.
6407         * psymtab.h (psymtab_storage::obstack): Update.
6408         (psymtab_storage::m_obstack): Use gdb::optional.
6409         (class psymtab_storage): Update comment.  Remove objfile
6410         parameter.
6411         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6412
6413 2019-01-10  Tom Tromey  <tom@tromey.com>
6414
6415         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6416         <free_psymtabs>: Now private.
6417         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6418         (allocate_psymtab): Use new method.
6419
6420 2019-01-10  Tom Tromey  <tom@tromey.com>
6421
6422         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6423         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6424         * mdebugread.c (parse_partial_symbols): Use
6425         allocate_dependencies.
6426         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6427         allocate_dependencies.
6428         (process_psymtab_comp_unit_reader)
6429         (build_type_psymtab_dependencies): Likewise.
6430         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6431
6432 2019-01-10  Tom Tromey  <tom@tromey.com>
6433
6434         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6435         PSYMBOL_SET_LANGUAGE.
6436         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6437
6438 2019-01-10  Tom Tromey  <tom@tromey.com>
6439
6440         * psymtab.h (psymtab_storage::obstack): New method.
6441         <m_obstack>: Rename from obstack; now private.
6442         * psymtab.c (psymtab_storage): Update.
6443         * dwarf2read.c (create_addrmap_from_index)
6444         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6445         Update.
6446
6447 2019-01-10  Tom Tromey  <tom@tromey.com>
6448
6449         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6450         * objfiles.h (objfile::reset_psymtabs): New method.
6451
6452 2019-01-10  Tom Tromey  <tom@tromey.com>
6453
6454         * symmisc.c (print_symbol_bcache_statistics): Update.
6455         (print_objfile_statistics): Update.
6456         * symfile.c (reread_symbols): Update.
6457         * psymtab.h (class psymtab_storage): New.
6458         * psymtab.c (psymtab_storage): New constructor.
6459         (~psymtab_storage): New destructor.
6460         (require_partial_symbols): Update.
6461         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6462         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6463         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6464         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6465         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6466         (start_psymtab_common, end_psymtab_common)
6467         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6468         (allocate_psymtab): Update.
6469         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6470         Update.
6471         (dump_psymtab_addrmap, maintenance_print_psymbols)
6472         (maintenance_check_psymtabs): Update.
6473         (class objfile_psymtabs): Move to objfiles.h.
6474         * psympriv.h (discard_psymtab): Now inline.
6475         (psymtab_discarder::psymtab_discarder): Update.
6476         (psymtab_discarder::~psymtab_discarder): Update.
6477         (ALL_OBJFILE_PSYMTABS): Rewrite.
6478         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6479         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6480         Remove fields.
6481         <partial_symtabs>: New field.
6482         (class objfile_psymtabs): Move from psymtab.h.  Update.
6483         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6484         psymbol_cache.
6485         (objfile::~objfile): Don't destroy psymbol_cache.
6486         * mdebugread.c (parse_partial_symbols): Update.
6487         * dwarf2read.c (create_addrmap_from_index)
6488         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6489         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6490         (add_partial_subprogram, dwarf2_ranges_read): Update.
6491         * dwarf-index-write.c (write_address_map)
6492         (write_one_signatured_type, recursively_write_psymbols)
6493         (class debug_names, class debug_names, write_psymtabs_to_index):
6494         Update.
6495
6496 2019-01-10  Tom Tromey  <tom@tromey.com>
6497
6498         * symtab.h (SYMBOL_SET_NAMES): Update.
6499         (symbol_set_names): Update.
6500         (MSYMBOL_SET_NAMES): Update.
6501         * symtab.c (symbol_set_names): Change argument to be an
6502         objfile_per_bfd_storage.
6503         * psymtab.c (add_psymbol_to_bcache): Update.
6504         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6505
6506 2019-01-10  Tom Tromey  <tom@tromey.com>
6507
6508         * symtab.c (create_demangled_names_hash): Change argument to be an
6509         objfile_per_bfd_storage.
6510         (symbol_set_names): Update.
6511
6512 2019-01-10  Tom Tromey  <tom@tromey.com>
6513
6514         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6515         init_psymbol_list.
6516         * psymtab.c (init_psymbol_list): Do nothing if already called.
6517         * psympriv.h (init_psymbol_list): Add comment.
6518         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6519         init_psymbol_list.
6520         * dbxread.c (dbx_symfile_read): Unconditionally call
6521         init_psymbol_list.
6522
6523 2019-01-10  Tom Tromey  <tom@tromey.com>
6524
6525         * xcoffread.c (scan_xcoff_symtab): Update.
6526         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6527         "where".
6528         * mdebugread.c (parse_partial_symbols)
6529         (handle_psymbol_enumerators): Update.
6530         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6531         * dbxread.c (read_dbx_symtab): Update.
6532         * psympriv.h (psymbol_placement): New enum.
6533         (add_psymbol_to_list): Update.
6534
6535 2019-01-10  Tom Tromey  <tom@tromey.com>
6536
6537         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6538         static_psymbols parameters.
6539         (scan_xcoff_symtab): Update.
6540         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6541         static_psymbols parameters.
6542         * psympriv.h (start_psymtab_common): Update.
6543         * mdebugread.c (parse_partial_symbols): Update.
6544         * dwarf2read.c (create_partial_symtab): Update.
6545         * dbxread.c (read_dbx_symtab): Update.
6546         (start_psymtab): Remove global_psymbols and static_psymbols
6547         parameters.
6548
6549 2019-01-10  Tom Tromey  <tom@tromey.com>
6550
6551         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6552         * psymtab.c (allocate_psymtab): Add comment.
6553         * psympriv.h (allocate_psymtab): Add comment.
6554         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6555         initializations.
6556         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6557
6558 2019-01-10  Tom Tromey  <tom@tromey.com>
6559
6560         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6561         Don't declare.
6562         * mipsread.c: Include mdebugread.h.
6563         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6564         Declare.
6565         * elfread.c: Include mdebugread.h.
6566
6567 2019-01-09  Tom Tromey  <tom@tromey.com>
6568
6569         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6570         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6571         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6572         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6573         (psym_lookup_symbol, psym_find_last_source_symtab)
6574         (psym_forget_cached_source_info, psym_print_stats)
6575         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6576         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6577         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6578         (psym_find_compunit_symtab_by_address)
6579         (maintenance_print_psymbols, maintenance_info_psymtabs)
6580         (maintenance_check_psymtabs): Use ranged for.
6581         * psymtab.h (class objfile_psymtabs): New.
6582         (require_partial_symbols): Return objfile_psymtabs.
6583         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6584
6585 2019-01-09  Tom Tromey  <tom@tromey.com>
6586
6587         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6588         (find_pc_mapped_section, list_overlays_command)
6589         (map_overlay_command, unmap_overlay_command)
6590         (simple_overlay_update): Use all_objfiles.
6591         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6592         * printcmd.c (info_symbol_command): Use all_objfiles.
6593         * objfiles.h (ALL_OBJSECTIONS): Remove.
6594         * maint.c (maintenance_translate_address): Use all_objfiles.
6595         * gcore.c (gcore_create_callback): Use all_objfiles.
6596         (objfile_find_memory_regions): Likewise.
6597
6598 2019-01-09  Tom Tromey  <tom@tromey.com>
6599
6600         * symtab.c (find_line_symtab, info_sources_command)
6601         (make_source_files_completion_list): Use objfile_compunits.
6602         * source.c (select_source_symtab): Use objfile_compunits.
6603         * objfiles.h (struct objfile): Update comment.
6604         (ALL_OBJFILES): Remove.
6605         (ALL_FILETABS): Remove.
6606         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6607         objfile_compunits.
6608
6609 2019-01-09  Tom Tromey  <tom@tromey.com>
6610
6611         * symmisc.c (print_objfile_statistics, dump_objfile)
6612         (maintenance_print_symbols): Use compunit_filetabs.
6613         * source.c (forget_cached_source_info_for_objfile): Use
6614         compunit_filetabs.
6615         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6616         (ALL_FILETABS): Use compunit_filetabs.
6617         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6618         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6619
6620 2019-01-09  Tom Tromey  <tom@tromey.com>
6621
6622         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6623         (compunit_filetabs): New.
6624         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6625         compunit_filetabs.
6626         (info_sources_command, make_source_files_completion_list): Remove
6627         declaration.
6628         * symmisc.c (print_objfile_statistics, dump_objfile)
6629         (maintenance_print_symbols): Remove declaration.
6630         (maintenance_info_symtabs): Use compunit_filetabs.
6631         (maintenance_info_line_tables): Likewise.
6632         * source.c (select_source_symtab): Change local variable name.
6633         (forget_cached_source_info_for_objfile): Remove declaration.
6634         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6635         * objfiles.c (objfile_relocate1): Remove declaration.
6636         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6637         declaration.
6638         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6639         * coffread.c (coff_symtab_read): Remove declaration.
6640         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6641         compunit_filetabs.
6642
6643 2019-01-09  Tom Tromey  <tom@tromey.com>
6644
6645         * symtab.c (lookup_objfile_from_block)
6646         (find_pc_sect_compunit_symtab, search_symbols)
6647         (default_collect_symbol_completion_matches_break_on): Use
6648         objfile_compunits.
6649         * objfiles.h (ALL_COMPUNITS): Remove.
6650         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6651         * cp-support.c (add_symbol_overload_list_qualified): Use
6652         objfile_compunits.
6653         * ada-lang.c (ada_collect_symbol_completion_matches)
6654         (ada_add_global_exceptions): Use objfile_compunits.
6655
6656 2019-01-09  Tom Tromey  <tom@tromey.com>
6657
6658         * source.c (select_source_symtab)
6659         (forget_cached_source_info_for_objfile): Remove declaration.
6660         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6661         declaration.
6662         * maint.c (count_symtabs_and_blocks): Remove declaration.
6663         * cp-support.c (add_symbol_overload_list_qualified): Remove
6664         declaration.
6665         * coffread.c (coff_symtab_read): Remove declaration.
6666         * symtab.c (lookup_symbol_in_objfile_symtabs)
6667         (basic_lookup_transparent_type_1): Use objfile_compunits.
6668         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6669         (info_sources_command, search_symbols)
6670         (default_collect_symbol_completion_matches_break_on)
6671         (make_source_files_completion_list): Remove declaration.
6672         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6673         (ada_collect_symbol_completion_matches)
6674         (ada_add_global_exceptions): Remove declaration.
6675         * linespec.c (iterate_over_all_matching_symtabs): Use
6676         objfile_compunits.
6677         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6678         (class objfile_compunits): New.
6679         (ALL_COMPUNITS): Use objfile_compunits.
6680         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6681         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6682         objfile_compunits.
6683         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6684
6685 2019-01-09  Tom Tromey  <tom@tromey.com>
6686
6687         * symtab.c (search_symbols)
6688         (default_collect_symbol_completion_matches_break_on): Use
6689         objfile_msymbols.
6690         * ada-lang.c (ada_lookup_simple_minsym)
6691         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6692         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6693         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6694         objfile_msymbols.
6695         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6696         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6697         * objc-lang.c (find_methods): Use objfile_msymbols.
6698         (info_selectors_command, info_classes_command): Likewise.
6699         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6700         * objfiles.h (class objfile_msymbols): New.
6701         (ALL_OBJFILE_MSYMBOLS): Remove.
6702         (ALL_MSYMBOLS): Remove.
6703
6704 2019-01-09  Tom Tromey  <tom@tromey.com>
6705
6706         * common/next-iterator.h (next_adapter): Add Iterator template
6707         parameter.
6708         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6709         (class all_objfiles_safe): New.
6710         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6711         * objfiles.c (put_objfile_before): Update comment.
6712         (add_separate_debug_objfile): Likewise.
6713         (free_all_objfiles): Use all_objfiles_safe.
6714         (objfile_purge_solibs): Likewise.
6715
6716 2019-01-09  Tom Tromey  <tom@tromey.com>
6717
6718         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6719         (expand_symtab_containing_pc, lookup_static_symbol)
6720         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6721         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6722         all_objfiles.
6723         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6724         * breakpoint.c (create_overlay_event_breakpoint)
6725         (create_longjmp_master_breakpoint)
6726         (create_std_terminate_master_breakpoint)
6727         (create_exception_master_breakpoint): Use all_objfiles.
6728         * linux-thread-db.c (try_thread_db_load_from_pdir)
6729         (has_libpthread): Use all_objfiles.
6730         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6731         * linespec.c (iterate_over_all_matching_symtabs)
6732         (search_minsyms_for_name): Use all_objfiles.
6733         * maint.c (maintenance_info_sections): Use all_objfiles.
6734         * main.c (captured_main_1): Use all_objfiles.
6735         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6736         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6737         * guile/scm-pretty-print.c
6738         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6739         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6740         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6741         (maintenance_print_msymbols): Use all_objfiles.
6742         * source.c (select_source_symtab): Use all_objfiles.
6743         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6744         * symfile.c (remove_symbol_file_command)
6745         (expand_symtabs_matching, map_symbol_filenames): Use
6746         all_objfiles.
6747         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6748         all_objfiles.
6749         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6750         * objc-lang.c (find_methods): Use all_objfiles.
6751         * objfiles.c (have_partial_symbols, have_full_symbols)
6752         (have_minimal_symbols, qsort_cmp)
6753         (default_iterate_over_objfiles_in_search_order): Use
6754         all_objfiles.
6755         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6756         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6757         (maintenance_check_psymtabs): Use all_objfiles.
6758         (ALL_PSYMTABS): Remove.
6759         * compile/compile-object-run.c (do_module_cleanup): Use
6760         all_objfiles.
6761         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6762         * cp-support.c (add_symbol_overload_list_qualified): Use
6763         all_objfiles.
6764         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6765         Use all_objfiles.
6766         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6767         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6768         all_objfiles.
6769         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6770         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6771         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6772         Uses all_objfiles.
6773         * solib.c (solib_read_symbols): Use all_objfiles
6774
6775 2019-01-09  Tom Tromey  <tom@tromey.com>
6776
6777         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6778         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6779         all_objfiles.
6780         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6781         * symmisc.c (print_symbol_bcache_statistics)
6782         (print_objfile_statistics, maintenance_print_objfiles)
6783         (maintenance_info_symtabs, maintenance_check_symtabs)
6784         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6785         all_objfiles.
6786         * source.c (forget_cached_source_info): Use all_objfiles.
6787         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6788         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6789         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6790         * objfiles.c (update_section_map): Use all_objfiles.
6791         (shared_objfile_contains_address_p): Likewise.
6792         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6793         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6794
6795 2019-01-09  Tom Tromey  <tom@tromey.com>
6796
6797         * common/next-iterator.h: New file.
6798         * objfiles.h (class all_objfiles): New.
6799         (struct objfile_iterator): New.
6800
6801 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6802
6803         * NEWS: Move the description of the changed "frame", "select-frame",
6804          and "info frame" commands to the Changed commands section.
6805
6806 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6807
6808         * gdbtypes.c (check_stub_method_group): Remove handling of old
6809         mangling schemes.
6810         * linespec.c (find_methods): Likewise.
6811         * stabsread.c (read_member_functions): Likewise.
6812         * valops.c (search_struct_method): Likewise.
6813         (value_struct_elt_for_reference): Likewise.
6814         * NEWS: Mention this change.
6815
6816 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6819         print_source_lines.
6820         * source.c (print_source_lines_base): Update line number check.
6821         (print_source_lines): New function.
6822         (source_lines_range::source_lines_range): New function.
6823         * source.h (class source_lines_range): New class.
6824         (print_source_lines): New declaration.
6825
6826 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6827
6828         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6829
6830 2019-01-08  Tom Tromey  <tom@tromey.com>
6831             Simon Marchi  <simon.marchi@ericsson.com>
6832
6833         PR gdb/24060
6834         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6835         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6836         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6837         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6838         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6839         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6840
6841 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6842
6843         * source.c (select_source_symtab): Move header comment to
6844         declaration in source.h.
6845         (forget_cached_source_info_for_objfile): Likewise.
6846         (forget_cached_source_info): Likewise.
6847         (identify_source_line): Likewise.
6848         * source.h (identify_source_line): Move declaration from symtab.h
6849         and add comment from source.c
6850         (print_source_lines): Likewise.
6851         (forget_cached_source_info_for_objfile): Likewise.
6852         (forget_cached_source_info): Likewise.
6853         (select_source_symtab): Likewise.
6854         (enum print_source_lines_flag): Move definition from symtab.h.
6855         * symtab.h (identify_source_line): Move declaration to source.h.
6856         (print_source_lines): Likewise.
6857         (forget_cached_source_info_for_objfile): Likewise.
6858         (forget_cached_source_info): Likewise.
6859         (select_source_symtab): Likewise.
6860         (enum print_source_lines_flag): Move definition to source.h.
6861         * tui/tui-hooks.c: Add 'source.h' include.
6862
6863 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * source.c (print_source_lines_base): Handle requests to print
6866         reverse line number sequences, and guard against empty lines
6867         string.
6868
6869 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * source.c (print_source_lines_base): Fix skip of '\r' if next
6872         character is '\n'.
6873
6874 2019-01-06  Tom Tromey  <tom@tromey.com>
6875
6876         * c-exp.y (struct c_parse_state) <macro_original_text,
6877         expansion_obstack>: New member.
6878         (macro_original_text, expansion_obstack): Remove globals.
6879         (scan_macro_expansion, scanning_macro_expansion)
6880         (finished_macro_expansion): Update.
6881         (scan_macro_cleanup): Remove.
6882         (yylex, c_parse): Update.
6883
6884 2019-01-06  Tom Tromey  <tom@tromey.com>
6885
6886         * c-exp.y (struct c_parse_state) <strings>: New member.
6887         (operator_stoken): Update.
6888
6889 2019-01-06  Tom Tromey  <tom@tromey.com>
6890
6891         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6892         (union type_stack_elt) <typelist_val>: Now a pointer to
6893         std::vector.
6894         (type_stack_cleanup): Don't declare.
6895         (push_typelist): Update.
6896         * parse.c (pop_typelist): Return a std::vector.
6897         (push_typelist): Take a std::vector.
6898         (follow_types): Update.  Do not free args.
6899         (type_stack_cleanup): Remove.
6900         * c-exp.y (struct c_parse_state): New.
6901         (cpstate): New global.
6902         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6903         (nonempty_typelist): Update.
6904         (func_mod): Create a new vector.
6905         (c_parse): Create a c_parse_state.
6906         (check_parameter_typelist): Do not delete params.
6907         (function_method): Update.  Do not delete type_list.
6908
6909 2019-01-06  Tom Tromey  <tom@tromey.com>
6910
6911         PR gdb/28155:
6912         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6913         check_typedef.
6914         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6915         (print_return_value): Likewise.
6916
6917 2019-01-05  Tom Tromey  <tom@tromey.com>
6918
6919         * contrib/cleanup_check.py: Remove.
6920         * contrib/gcc-with-excheck: Remove.
6921         * contrib/exsummary.py: Remove.
6922         * contrib/excheck.py: Remove.
6923
6924 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6925
6926         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6927         NULL. Initialize tpprev to NULL instead of assigning it
6928         to NULL on the next statement.
6929         * windows-nat.c (windows_delete_thread): Remove check for
6930         main_thread_id before printing thread exit notifications.
6931         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6932         Remove thread ID check against main_thread_id.
6933         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6934         windows_delete_thread.
6935         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6936
6937 2019-01-04  Tom Tromey  <tom@tromey.com>
6938
6939         * compile/compile.c (_initialize_compile): Use upper case for
6940         metasyntactic variables.
6941         * symmisc.c (_initialize_symmisc): Use upper case for
6942         metasyntactic variables.
6943         * psymtab.c (_initialize_psymtab): Use upper case for
6944         metasyntactic variables.
6945         * demangle.c (demangle_command): Use upper case for metasyntactic
6946         variables.
6947         (_initialize_demangler): Likewise.
6948         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6949         variables.
6950
6951 2019-01-03  Tom Tromey  <tom@tromey.com>
6952
6953         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6954
6955 2019-01-03  Tom Tromey  <tom@tromey.com>
6956
6957         * python/py-symtab.c (salpy_str): Update.
6958         (struct salpy_sal_object) <symtab>: Now a PyObject.
6959         (salpy_dealloc): Update.
6960         (del_objfile_sal): Use gdbpy_ref.
6961
6962 2019-01-03  Tom Tromey  <tom@tromey.com>
6963
6964         * python/py-type.c (convert_field): Use new_reference.  Return
6965         gdbpy_ref.
6966         (make_fielditem): Return gdbpy_ref.
6967         (typy_fields): Update.
6968         (typy_getitem): Update.
6969         (field_name): Return gdbpy_ref.  Use new_reference.
6970         (typy_iterator_iternext): Update.
6971
6972 2019-01-03  Tom Tromey  <tom@tromey.com>
6973
6974         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6975
6976 2019-01-03  Tom Tromey  <tom@tromey.com>
6977
6978         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6979         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6980         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6981         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6982         (pspy_set_type_printers): Likewise.
6983         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6984         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6985         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6986         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6987         (objfpy_set_type_printers): Likewise.
6988
6989 2019-01-03  Tom Tromey  <tom@tromey.com>
6990
6991         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6992         (gdbpy_print_stack): Use gdbpy_err_fetch.
6993         * python/python-internal.h (class gdbpy_err_fetch): New class.
6994         (class gdbpy_enter) <m_error_type, m_error_value,
6995         m_error_traceback>: Remove.
6996         <m_error>: New member.
6997         (gdbpy_exception_to_string): Don't declare.
6998         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6999         * python/py-value.c (convert_value_from_python): Use
7000         gdbpy_err_fetch.
7001         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7002         gdbpy_exception_to_string.
7003         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7004         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7005         gdbpy_err_fetch.
7006
7007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * linux-nat.c (delete_lwp_cleanup): Delete.
7010         (struct lwp_deleter): New struct.
7011         (lwp_info_up): New typedef.
7012         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7013         lwp_info_up.
7014
7015 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * linux-fork.c (class scoped_switch_fork_info): New class.
7018         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7019
7020 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * valops.c (find_overload_match): Remove use of null_cleanup, and
7023         calls to do_cleanups.
7024
7025 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * compile/compile-cplus-types.c
7028         (compile_cplus_instance::decl_name): Handle changes to
7029         cp_func_name.
7030         * cp-support.c (cp_func_name): Update header comment, update
7031         return type.
7032         * cp-support.h (cp_func_name): Update return type in declaration.
7033         * valops.c (find_overload_match): Move temp_func local to top
7034         level of function and change its type.  Use temp_func to hold and
7035         delete temporary string obtained from cp_func_name.
7036
7037 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7040         gdb::char_vector, remove cleanup, and update uses of `msg`.
7041
7042 2019-01-03  Jim Wilson  <jimw@sifive.com>
7043
7044         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7045
7046 2019-01-02  Tom Tromey  <tom@tromey.com>
7047
7048         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7049         (tdesc_parse_xml): Remove cleanups.
7050         * target-descriptions.h (make_cleanup_free_target_description):
7051         Don't declare.
7052         (target_desc_deleter): New struct.
7053         (target_desc_up): New typedef.
7054         * target-descriptions.c (target_desc_deleter::operator()): Rename
7055         from free_target_description.
7056         (make_cleanup_free_target_description): Remove.
7057
7058 2019-01-02  Tom Tromey  <tom@tromey.com>
7059
7060         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7061         constructor, destructor.
7062         (linespec_parser): Remove typedef.
7063         (~linespec_parser): Rename from linespec_parser_delete.
7064         (linespec_lex_to_end, linespec_complete_label)
7065         (linespec_complete): Update.
7066         (decode_line_full): Remove cleanups.
7067         (decode_line_1): Update.
7068
7069 2019-01-02  Tom Tromey  <tom@tromey.com>
7070
7071         * python/python-internal.h (inferior_to_inferior_object): Change
7072         return type.
7073         * python/py-exitedevent.c (create_exited_event_object): Update.
7074         * python/py-inferior.c (inferior_to_inferior_object): Return
7075         gdbpy_ref.
7076         (python_new_inferior, python_inferior_deleted)
7077         (thread_to_thread_object, delete_thread_object)
7078         (build_inferior_list, gdbpy_selected_inferior): Update.
7079         * python/py-infthread.c (create_thread_object): Update.  Also fail
7080         if inferior_to_inferior_object fails.
7081
7082 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7083
7084         * inferior.h (class inferior) <displaced_step_state>: New field.
7085         * infrun.h (struct displaced_step_state): Move here from
7086         infrun.c.  Initialize fields, add constructor.
7087         <inf>: Remove field.
7088         <reset>: New method.
7089         * infrun.c (struct displaced_step_inferior_state): Move to
7090         infrun.h.
7091         (displaced_step_inferior_states): Remove.
7092         (get_displaced_stepping_state): Adust.
7093         (displaced_step_in_progress_any_inferior): Adjust.
7094         (displaced_step_in_progress_thread): Adjust.
7095         (displaced_step_in_progress): Adjust.
7096         (add_displaced_stepping_state): Remove.
7097         (get_displaced_step_closure_by_addr): Adjust.
7098         (remove_displaced_stepping_state): Remove.
7099         (infrun_inferior_exit): Call displaced_step_state.reset.
7100         (use_displaced_stepping): Don't check for NULL.
7101         (displaced_step_prepare_throw): Call
7102         get_displaced_stepping_state.
7103         (displaced_step_fixup): Don't check for NULL.
7104         (prepare_for_detach): Don't check for NULL.
7105
7106 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107
7108         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7109          in case of call that did not complete.
7110
7111 2019-01-02  Andrey Utkin  <autkin@undo.io>
7112
7113         * symfile.c (find_separate_debug_file): Fix search of debug files for
7114         remote debuggee.
7115
7116 2019-01-02  Tom Tromey  <tom@tromey.com>
7117
7118         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7119         indentation.
7120         * python/py-frame.c (frapy_older): Remove cast.
7121         (frapy_newer): Likewise.
7122         * python/py-breakpoint.c (local_setattro): Remove cast.
7123         * python/py-arch.c (archpy_name): Remove local variable.
7124         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7125
7126 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7127
7128         * unittests/basic_string_view/element_access/char/empty.cc:
7129         Fix year range in copyright header.
7130
7131 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7134         Delete.
7135         <operator==>: Update with for removed field.
7136         <hash>: Likewise.
7137         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7138         <isa_features>: ...this.
7139         <abi_features>: New field.
7140         (riscv_isa_flen): Update comment.
7141         (riscv_abi_xlen): New declaration.
7142         (riscv_abi_flen): New declaration.
7143         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7144         isa_features.
7145         (riscv_abi_xlen): New function.
7146         (riscv_isa_flen): Update to get answer from isa_features.
7147         (riscv_abi_flen): New function.
7148         (riscv_has_fp_abi): Update to get answer from abi_features.
7149         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7150         xlen and flen.
7151         (riscv_call_info) <xlen, flen>: Update comment.
7152         (riscv_call_arg_struct): Remove invalid assertions
7153         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7154         is removed.
7155         (riscv_gdbarch_init): Gather isa features and abi features
7156         separately, ensure both match on the gdbarch when reusing an old
7157         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7158         a target with 64-bit float hardware.
7159
7160 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7161
7162         * source.c (search_command_helper): Stop reverse search
7163         when line 1 has been searched.
7164
7165 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7166
7167         * record-full.c (record_full_base_target::close): Rewrite
7168         record_full_core_buf_list free logic.
7169
7170 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7171
7172         * break-catch-syscall.c (print_one_catch_syscall): xfree
7173         the last text.
7174
7175 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7176
7177         * top.c (print_gdb_version): Update Copyright year in version
7178         message.
7179
7180 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7181
7182         Update copyright year range in all GDB files.
7183
7184 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7185
7186         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7187
7188 For older changes see ChangeLog-2018.
7189 \f
7190 Local Variables:
7191 mode: change-log
7192 left-margin: 8
7193 fill-column: 74
7194 version-control: never
7195 coding: utf-8
7196 End:
7197