gdb/ChangeLog

   1 2019-05-02  Tom Tromey  <tromey@adacore.com>
   2
   3         * valarith.c (_initialize_valarith): Remove.
   4
   5 2019-05-01  Tom Tromey  <tromey@adacore.com>
   6
   7         * ada-lang.c (ada_value_primitive_field): Treat more fields as
   8         bitfields.
   9
  10 2019-05-01  Tom Tromey  <tromey@adacore.com>
  11
  12         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  13         for big-endian copies.
  14
  15 2019-04-30  Ali Tamur  <tamur@google.com>
  16         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  17         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  18         (read_3_bytes): New function.
  19
  20 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  21
  22         * windows-nat.c (main_thread_id): Delete.
  23         (handle_output_debug_string): Replace main_thread_id by
  24         current_event.dwThreadId.
  25         (fake_create_process): Likewise.
  26         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  27         Do not set main_thread_id.
  28         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  29         current_event.dwThreadId.
  30         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  31
  32 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  33
  34         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  35         Use current_event.dwThreadId instead of main_thread_id.
  36
  37 2019-04-30  Tom Tromey  <tromey@adacore.com>
  38
  39         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  40         (create_excep_cond_exprs): Iterate over program spaces.
  41         (ada_exception_catchpoint_cond_string): Examine all minimal
  42         symbols for exception types.
  43
  44 2019-04-30  Tom Tromey  <tromey@adacore.com>
  45
  46         PR c++/24470:
  47         * dwarf2read.c (process_structure_scope): Handle case where type
  48         has template parameters but no symbol was created.
  49
  50 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  51             Chris January  <chris.january@arm.com>
  52
  53         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  54         qualifier.
  55         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  56
  57 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * f-typeprint.c (f_print_type): Update rules for printing
  60         whitespace.
  61         (f_type_print_varspec_suffix): Likewise.
  62
  63 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  64             Chris January  <chris.january@arm.com>
  65
  66         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  67         function arguments.
  68
  69 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * f-lang.c (build_fortran_types): Change name of void type to
  72         lower case.
  73         * f-typeprint.c (f_type_print_base): Print the name of the void
  74         type, rather than a fixed string.
  75         * f-valprint.c (f_decorations): Use lower case void string.
  76
  77 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  78             Chris January  <chris.january@arm.com>
  79
  80         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  81         types for Fortran.
  82
  83 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  84             Chris January  <chris.january@arm.com>
  85             David Lecomber  <david.lecomber@arm.com>
  86
  87         * f-exp.y (BINOP_INTRINSIC): New token.
  88         (exp): New parser rule handling BINOP_INTRINSIC.
  89         (f77_keywords): Add new builtin procedures.
  90         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  91         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  92         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  93         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  94         (print_unop_subexp_f): New function.
  95         (print_binop_subexp_f): New function.
  96         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  97         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  98         (dump_subexp_body_f): Likewise.
  99         (operator_check_f): Likewise.
 100         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 101         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 102
 103 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 104
 105         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 106         UNOP_KIND.
 107         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 108         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 109         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 110         (operator_length_f): New fuction.
 111         (print_subexp_f): New function.
 112         (op_name_f): New function.
 113         (dump_subexp_body_f): New function.
 114         (operator_check_f): New function.
 115         (exp_descriptor_f): Replace standard expression handling functions
 116         with new functions.
 117         * gdb/fortran-operator.def: New file.
 118         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 119         * gdb/std-operator.def: Remove UNOP_KIND.
 120
 121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * std-operator.def: Remove unbalanced, stray double quote
 124         character.
 125
 126 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 127             Chris January  <chris.january@arm.com>
 128             Daniel Everett  <daniel.everett@arm.com>
 129             Nick Forrington  <nick.forrington@arm.com>
 130             Richard Bunt  <richard.bunt@arm.com>
 131
 132         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 133         of depth when printing anonymous structs or unions.
 134         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 135         Don't print either the top-level value, or the children if the
 136         max-depth is exceeded.
 137         (ppscm_print_children): When printing the key of a map, allow one
 138         extra level of depth.
 139         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 140         print either the top-level value, or the children if the max-depth
 141         is exceeded.
 142         (print_children): When printing the key of a map, allow one extra
 143         level of depth.
 144         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 145         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 146         (user_print_options): Initialise max_depth field.
 147         (val_print_scalar_or_string_type_p): New function.
 148         (val_print): Check to see if the max depth has been reached.
 149         (val_print_check_max_depth): Define new function.
 150         (show_print_max_depth): New function.
 151         (_initialize_valprint): Add 'print max-depth' option.
 152         * valprint.h (struct value_print_options) <max_depth>: New field.
 153         (val_print_check_max_depth): Declare new function.
 154         * NEWS: Document new feature.
 155
 156 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 157
 158         * ada-lang.c (ada_language_defn): Initialise new field.
 159         * c-lang.c (c_is_string_type_p): New function.
 160         (c_language_defn): Initialise new field.
 161         (cplus_language_defn): Initialise new field.
 162         (asm_language_defn): Initialise new field.
 163         (minimal_language_defn): Initialise new field.
 164         * c-lang.h (c_is_string_type_p): Declare new function.
 165         * d-lang.c (d_language_defn): Initialise new field.
 166         * f-lang.c (f_is_string_type_p): New function.
 167         (f_language_defn): Initialise new field.
 168         * go-lang.c (go_is_string_type_p): New function.
 169         (go_language_defn): Initialise new field.
 170         * language.c (default_is_string_type_p): New function.
 171         (unknown_language_defn): Initialise new field.
 172         (auto_language_defn): Initialise new field.
 173         * language.h (struct language_defn) <la_is_string_type_p>: New
 174         member variable.
 175         (default_is_string_type_p): Declare new function.
 176         * m2-lang.c (m2_language_defn): Initialise new field.
 177         * objc-lang.c (objc_language_defn): Initialise new field.
 178         * opencl-lang.c (opencl_language_defn): Initialise new field.
 179         * p-lang.c (pascal_is_string_type_p): New function.
 180         (pascal_language_defn): Initialise new field.
 181         * rust-lang.c (rust_is_string_type_p): New function.
 182         (rust_language_defn): Initialise new field.
 183
 184 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 185
 186         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 187         New field.
 188         * ada-lang.c (ada_language_defn): Initialise new field.
 189         * c-lang.c (c_language_defn): Likewise.
 190         (cplus_language_defn): Likewise.
 191         (asm_language_defn): Likewise.
 192         (minimal_language_defn): Likewise.
 193         * d-lang.c (d_language_defn): Likewise.
 194         * f-lang.c (f_language_defn): Likewise.
 195         * go-lang.c (go_language_defn): Likewise.
 196         * language.c (unknown_language_defn): Likewise.
 197         (auto_language_defn): Likewise.
 198         * m2-lang.c (m2_language_defn): Likewise.
 199         * objc-lang.c (objc_language_defn): Likewise.
 200         * opencl-lang.c (opencl_language_defn): Likewise.
 201         * p-lang.c (pascal_language_defn): Likewise.
 202         * rust-lang.c (rust_language_defn): Likewise.
 203
 204 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * ada-lang.c (ada_is_character_type): Change return type to bool.
 207         (ada_is_string_type): Likewise.
 208         * ada-lang.h (ada_is_character_type): Update declaration
 209         (ada_is_string_type): Likewise.
 210
 211 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 212
 213         Support style in 'frame|thread apply'
 214
 215         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 216         * record.c (record_start, record_stop): Update callers of
 217         execute_command_to_string with false.
 218         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 219         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 220         methods.
 221         (class string_file): New constructor with term_out parameter.
 222         Override methods term_out and can_emit_style_escape.  New member
 223         term_out.
 224         (class stdio_file): Override can_emit_style_escape.
 225         (class tee_file): Override term_out and can_emit_style_escape.
 226         * utils.h (can_emit_style_escape): Remove.
 227         * utils.c (can_emit_style_escape): Likewise.
 228         Update all callers of can_emit_style_escape (SOMESTREAM) to
 229         SOMESTREAM->can_emit_style_escape.
 230         * source-cache.c (source_cache::get_source_lines): Likewise.
 231         * stack.c (frame_apply_command_count): Call execute_command_to_string
 232         passing the term_out characteristic of the current gdb_stdout.
 233         * thread.c (thr_try_catch_cmd): Likewise.
 234         * top.c (execute_command_to_string): pass term_out parameter
 235         to construct the string_file for the command output.
 236         * ui-file.c (term_cli_styling): New function (most code moved
 237         from utils.c can_emit_style_escape).
 238         (string_file::string_file, string_file::can_emit_style_escape,
 239         stdio_file::can_emit_style_escape, tee_file::term_out,
 240         tee_file::can_emit_style_escape): New functions.
 241
 242 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 243
 244         * NEWS: Mention the new set|show may-call-functions.
 245         * infcall.c (may_call_functions_p): New variable.
 246         (show_may_call_functions_p): New function.
 247         (call_function_by_hand_dummy): Throws an error if not
 248         may-call-functions.
 249         (_initialize_infcall): Call add_setshow_boolean_cmd for
 250         may-call-functions.
 251
 252 2019-04-25  Keith Seitz  <keiths@redhat.com>
 253
 254         PR c++/24367
 255         * cp-support.c (inspect_type): Don't attempt substitutions
 256         of symbol with the same name.
 257
 258 2019-04-25  Tom Tromey  <tromey@adacore.com>
 259
 260         PR gdb/24475:
 261         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 262         static.
 263
 264 2019-04-25  Tom Tromey  <tromey@adacore.com>
 265
 266         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 267         rvalue reference.
 268         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 269         (gdb_xml_parser::parse): Use std::move.
 270         * python/python-internal.h (gdbpy_convert_exception): Take a const
 271         reference.
 272         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 273         std::move.
 274         * python/py-utils.c (gdbpy_convert_exception): Take a const
 275         reference.
 276         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 277         Use std::move.
 278         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 279         Use std::move.
 280         * mi/mi-main.c (mi_print_exception): Take a const reference.
 281         * main.c (handle_command_errors): Take a const reference.
 282         * linespec.c (parse_linespec): Use std::move.
 283         * infcall.c (run_inferior_call): Use std::move.
 284         (call_function_by_hand_dummy): Use std::move.
 285         * exec.c (try_open_exec_file): Use std::move.
 286         * exceptions.h (exception_print, exception_fprintf)
 287         (exception_print_same): Update.
 288         * exceptions.c (print_exception, exception_print)
 289         (exception_fprintf, exception_print_same): Change parameters to
 290         const reference.
 291         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 292         * common/new-op.c: Use std::move.
 293         * common/common-exceptions.h (struct gdb_exception): Add move
 294         constructor.
 295         (struct gdb_exception_error, struct gdb_exception_quit, struct
 296         gdb_quit_bad_alloc): Change constructor to move constructor.
 297         (throw_exception): Change parameter to rvalue reference.
 298         * common/common-exceptions.c (throw_exception): Take rvalue
 299         reference.
 300         * cli/cli-interp.c (safe_execute_command): Use std::move.
 301         * breakpoint.c (insert_bp_location, location_to_sals): Use
 302         std::move.
 303
 304 2019-04-25  Tom Tromey  <tromey@adacore.com>
 305
 306         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 307         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 308         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 309         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 310         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 311         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 312         guile/scm-value.c: Use unpack.
 313         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 314         gdbscm_gdb_exception.
 315         (gdbscm_throw_gdb_exception): Likewise.
 316         (struct gdbscm_gdb_exception): New.
 317         (unpack): New function.
 318         (gdbscm_wrap): Use unpack.
 319
 320 2019-04-25  Tom Tromey  <tromey@adacore.com>
 321
 322         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 323         (gdb_rl_callback_handler): Use std::move.
 324         * common/common-exceptions.h (struct gdb_exception): Add move
 325         assignment operator.
 326         (throw_exception_sjlj): Change "exception" to const reference.
 327         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 328         (throw_exception_sjlj): Change "exception" to const reference.
 329
 330 2019-04-25  Tom Tromey  <tromey@adacore.com>
 331
 332         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 333         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 334         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 335         Update.
 336         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 337         Update.
 338         * mi/mi-interp.c (mi_interp::exec): Update.
 339         * linespec.c (parse_linespec): Update.
 340         * infcall.c (run_inferior_call): Update.
 341         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 342         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 343         (gdbscm_lookup_global_symbol): Update.
 344         * guile/scm-param.c (gdbscm_parameter_value): Update.
 345         * guile/scm-frame.c (gdbscm_frame_read_register)
 346         (gdbscm_frame_read_var): Update.
 347         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 348         * exec.c (try_open_exec_file): Update.
 349         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 350         (gdb_rl_callback_handler): Update.
 351         * common/common-exceptions.h (exception_none): Don't declare.
 352         * common/common-exceptions.c (exception_none): Don't define.
 353         (struct catcher) <exception>: Update.
 354         * cli/cli-interp.c (safe_execute_command): Update.
 355         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 356
 357 2019-04-25  Ali Tamur  <tamur@google.com>
 358
 359         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 360         (read_attribute_value): Likewise.
 361         (dwarf2_read_addr_index): Update comment.
 362         (read_str_index): Add DW_FORM_strx.
 363         (dwarf2_string_attr): Likewise.
 364         (dwarf2_const_value_attr): Likewise.
 365         (dump_die_shallow): Likewise.
 366         (dwarf2_fetch_constant_bytes): Likewise.
 367         (skip_form_bytes): Likewise.
 368         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 369
 370 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 371
 372         PR corefiles/11608
 373         PR corefiles/18187
 374         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 375         OFFSET.  Verify if current mapping contains an ELF header.
 376         (linux_find_memory_regions_full): Adjust call to
 377         dump_mapping_p.
 378
 379 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 380             Kang Li <kanglictf@gmail.com>
 381
 382         PR gdb/21600
 383
 384         * dwarf2-frame.c (read_initial_length): Be consistent about using
 385         unsigned representation of length.
 386         (decode_frame_entry_1): Likewise.  Check for wraparound of
 387         end pointer as well as buffer overflow.
 388
 389 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 390
 391         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 392         "vq".
 393
 394 2019-04-24  Tom Tromey  <tromey@adacore.com>
 395
 396         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 397
 398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * s12z-tdep.c (s12z_unwind_pc): Delete.
 401         (s12z_unwind_sp): Delete.
 402         (s12z_gdbarch_init): Don't register deleted functions with
 403         gdbarch.
 404
 405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * rl78-tdep.c (rl78_unwind_sp): Delete.
 408         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 409
 410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 413         (xstormy16_unwind_pc): Delete.
 414         (xstormy16_dummy_id): Delete.
 415         (xstormy16_gdbarch_init): Don't register deleted functions with
 416         gdbarch.
 417
 418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * vax-tdep.c (vax_unwind_pc): Delete.
 421         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 422
 423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * v850-tdep.c (v850_unwind_sp): Delete.
 426         (v850_unwind_pc): Delete.
 427         (v850_dummy_id): Delete.
 428         (v850_gdbarch_init): Don't register deleted functions with
 429         gdbarch.
 430
 431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 434         (tilegx_unwind_pc): Delete.
 435         (tilegx_unwind_dummy_id): Delete.
 436         (tilegx_gdbarch_init): Don't register deleted functions with
 437         gdbarch.
 438
 439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 442         (tic6x_dummy_id): Delete.
 443         (tic6x_gdbarch_init): Don't register deleted functions with
 444         gdbarch.
 445
 446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * sparc-tdep.c (sparc_unwind_pc): Delete.
 449         (sparc32_gdbarch_init): Don't register deleted function with
 450         gdbarch.
 451
 452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * sh-tdep.c (sh_unwind_sp): Delete.
 455         (sh_unwind_pc): Delete.
 456         (sh_dummy_id): Delete.
 457         (sh_gdbarch_init): Don't register deleted functions with
 458         gdbarch.
 459
 460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * score-tdep.c (score_unwind_sp): Delete.
 463         (score_unwind_pc): Delete.
 464         (score_dummy_id): Delete.
 465         (score_gdbarch_init): Don't register deleted functions with
 466         gdbarch.
 467
 468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 469
 470         * rx-tdep.c (rx_unwind_pc): Delete.
 471         (rx_unwind_sp): Delete.
 472         (rx_dummy_id): Delete.
 473         (rx_gdbarch_init): Don't register deleted functions with
 474         gdbarch.  Update comment.
 475
 476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 479         (rs6000_dummy_id): Delete.
 480         (rs6000_gdbarch_init): Don't register deleted functions with
 481         gdbarch.
 482
 483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * or1k-tdep.c (or1k_dummy_id): Delete.
 486         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * nios2-tdep.c (nios2_dummy_id): Delete.
 491         (nios2_unwind_sp): Delete.
 492         (nios2_gdbarch_init): Don't register deleted functions with
 493         gdbarch.
 494
 495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * nds32-tdep.c (nds32_dummy_id): Delete.
 498         (nds32_unwind_pc): Delete.
 499         (nds32_unwind_sp): Delete.
 500         (nds32_gdbarch_init): Don't register deleted functions with
 501         gdbarch.
 502
 503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * msp430-tdep.c (msp430_unwind_pc): Delete.
 506         (msp430_unwind_sp): Delete.
 507         (msp430_dummy_id): Delete.
 508         (msp430_gdbarch_init): Don't register deleted functions with
 509         gdbarch.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * moxie-tdep.c (moxie_unwind_sp): Delete.
 514         (moxie_unwind_pc): Delete.
 515         (moxie_dummy_id): Delete.
 516         (moxie_gdbarch_init): Don't register deleted functions with
 517         gdbarch.
 518
 519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 522         (mn10300_unwind_pc): Delete.
 523         (mn10300_unwind_sp): Delete.
 524         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 525         mn10300_unwind_sp.
 526         (mn10300_frame_unwind_init): Don't register deleted functions with
 527         gdbarch.
 528
 529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * mep-tdep.c (mep_unwind_pc): Delete.
 532         (mep_unwind_sp): Delete.
 533         (mep_dummy_id): Delete.
 534         (mep_gdbarch_init): Don't register deleted functions with
 535         gdbarch.
 536
 537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 540         (m68hc11_unwind_sp): Delete.
 541         (m68hc11_gdbarch_init): Don't register deleted functions with
 542         gdbarch.
 543
 544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * m32r-tdep.c (m32r_unwind_sp): Delete.
 547         (m32r_unwind_pc): Delete.
 548         (m32r_dummy_id): Delete.
 549         (m32r_gdbarch_init): Don't register deleted functions with
 550         gdbarch.
 551
 552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * m32c-tdep.c (m32c_unwind_pc): Delete.
 555         (m32c_unwind_sp): Delete.
 556         (m32c_dummy_id): Delete.
 557         (m32c_gdbarch_init): Don't register deleted functions with
 558         gdbarch.
 559
 560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 563         (lm32_unwind_pc): Delete.
 564         (lm32_dummy_id): Delete.
 565         (lm32_gdbarch_init): Don't register deleted functions with
 566         gdbarch.
 567
 568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 571         (iq2000_unwind_pc): Delete.
 572         (iq2000_dummy_id): Delete.
 573         (iq2000_gdbarch_init): Don't register deleted functions with
 574         gdbarch.
 575
 576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * nds32-tdep.c (nds32_type_align): Delete.
 579         (nds32_push_dummy_call): Use type_align instead.
 580
 581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * arm-tdep.c (arm_type_align): Only handle vector override case.
 584         (arm_push_dummy_call): Use type_align.
 585         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 586
 587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 590         case.
 591         (pass_on_stack): Use type_align.
 592         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 593         function.
 594
 595 2019-04-23  Tom Tromey  <tromey@adacore.com>
 596
 597         * dwarf2read.c (line_header::file_name_at): Remove unused
 598         overload.
 599
 600 2019-04-23  Tom de Vries  <tdevries@suse.de>
 601
 602         PR gdb/24438
 603         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 604         invocation.
 605
 606
 607 2019-03-27  Ali Tamur  <tamur@google.com>
 608
 609         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 610         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 611         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 612         (dwarf_expr_context::get_addr_index): Likewise
 613         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 614         (symbol_needs_eval_context::get_addr_index): Likewise
 615         (disassemble_dwarf_expression): Add DW_OP_addrx
 616         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 617         (read_cutu_die_from_dwo): Update comment
 618         (skip_one_die): Add DW_FORM_addrx
 619         (read_attribute_value): Likewise
 620         (var_decode_location): Add DW_OP_addrx
 621         (dwarf2_const_value_attr): Add DW_FORM_addrx
 622         (dump_die_shallow): Likewise
 623         (dwarf2_fetch_constant_bytes): Likewise
 624         (decode_locdesc): Add DW_OP_addrx
 625         (skip_form_bytes): Add DW_FORM_addrx
 626
 627 2019-04-22  Ali Tamur  <tamur@google.com>
 628
 629         * MAINTAINERS (Write After Approval): Add self.
 630
 631 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 632
 633         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 634         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 635         (open_symbol_file_object): Likewise.
 636         (svr4_default_sos): Add info parameter.
 637         (svr4_read_so_list): Likewise.
 638         (svr4_current_sos_direct): Adjust functions calls to pass down
 639         info.
 640         (svr4_current_sos_1): Add info parameter.
 641         (svr4_current_sos): Call get_svr4_info, pass info down to
 642         svr4_current_sos_1.
 643         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 644         get_svr4_info.
 645         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 646         get_svr4_info.
 647         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 648         to get_svr4_info.
 649         (probes_table_remove_objfile_probes): Likewise.
 650         (register_solib_event_probe): Add info parameter.
 651         (solist_update_incremental): Pass info parameter down to
 652         svr4_read_so_list.
 653         (disable_probes_interface): Add info parameter.
 654         (svr4_handle_solib_event): Pass current_program_space to
 655         get_svr4_info.  Adjust disable_probes_interface cleanup.
 656         (svr4_create_probe_breakpoints): Add info parameter, pass it
 657         down to register_solib_event_probe.
 658         (svr4_create_solib_event_breakpoints): Add info parameter,
 659         pass it down to svr4_create_probe_breakpoints.
 660         (enable_break): Pass info down to
 661         svr4_create_solib_event_breakpoints.
 662         (svr4_solib_create_inferior_hook): Pass current_program_space to
 663         get_svr4_info.
 664         (svr4_clear_solib): Likewise.
 665
 666 2019-04-22  Pedro Alves  <palves@redhat.com>
 667
 668         * solib-svr4.c (svr4_free_objfile_observer): New.
 669         (probe_and_action::objfile): New field.
 670         (probes_table_htab_remove_objfile_probes)
 671         (probes_table_remove_objfile_probes): New functions.
 672         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 673         in the new probe_and_action.  Don't store the probe in 'lookup'.
 674         (svr4_create_probe_breakpoints): Pass objfile to
 675         register_solib_event_probe.
 676         (_initialize_svr4_solib): Register a free_objfile observer.
 677
 678 2019-04-19  Tom Tromey  <tom@tromey.com>
 679
 680         * common/queue.h: Remove.
 681
 682 2019-04-19  Tom Tromey  <tom@tromey.com>
 683
 684         * event-loop.c: Don't include "common/queue.h".
 685
 686 2019-04-19  Tom Tromey  <tom@tromey.com>
 687
 688         * remote.c (remote_target): Use delete.
 689         * remote-notif.h: Include <list>, not "common/queue.h".
 690         (notif_client_p): Remove typedef.
 691         (remote_notif_state): Add constructor, destructor, initializer.
 692         <notif_queue>: Now a std::list.
 693         (remote_notif_state_xfree): Don't declare.
 694         * remote-notif.c (remote_notif_process, handle_notification)
 695         (remote_notif_state_allocate): Update.
 696         (~remote_notif_state): Rename from remote_notif_state_xfree.
 697
 698 2019-04-19  Tom Tromey  <tom@tromey.com>
 699
 700         * symfile.c (reread_symbols): Update.
 701         * objfiles.c (objfile_register_static_link)
 702         (objfile_lookup_static_link): Update
 703         (~objfile) Don't delete static_links.
 704         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 705
 706 2019-04-19  Tom Tromey  <tom@tromey.com>
 707
 708         * type-stack.h (struct type_stack) <insert>: Constify string.
 709         * type-stack.c (type_stack::insert): Constify string.
 710         * gdbtypes.h (lookup_template_type): Update.
 711         (address_space_name_to_int): Update.
 712         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 713         const.
 714         (lookup_template_type): Make name const.
 715         * c-exp.y: Update rules.
 716         (lex_one_token, classify_name, classify_inner_name)
 717         (c_print_token): Update.
 718         * p-exp.y: Update rules.
 719         (yylex): Update.
 720         * f-exp.y: Update rules.
 721         (yylex): Update.
 722         * d-exp.y: Update rules.
 723         (lex_one_token, classify_name, classify_inner_name): Update.
 724         * parse.c (write_dollar_variable, copy_name): Return std::string.
 725         * parser-defs.h (copy_name): Change return type.
 726         * m2-exp.y: Update rules.
 727         (yylex): Update.
 728         * go-exp.y (lex_one_token): Update.
 729         Update rules.
 730         (classify_unsafe_function, classify_packaged_name)
 731         (classify_name, yylex): Update.
 732
 733 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 734
 735         * configure.ac: add --enable-source-highlight switch.
 736         * configure: Regenerate.
 737         * top.c (print_gdb_version): plumb --enable-source-highlight
 738         status to "show configuration".
 739
 740 2019-04-19  Tom Tromey  <tromey@adacore.com>
 741
 742         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 743         Check ADA_TYPE_P.
 744         (empty_record, ada_template_to_fixed_record_type_1)
 745         (template_to_static_fixed_type)
 746         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 747         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 748         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 749         macros.
 750
 751 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 752
 753         PR symtab/24423:
 754         * source.c (print_source_lines_base): Advance "iter" when a
 755         control character is seen.
 756
 757 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 758
 759         * inferior.h (struct infcall_suspend_state_deleter):
 760         Catch exception in destructor to avoid crash.
 761
 762 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 763
 764         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 765         close to the add_com "shell".
 766
 767 2019-04-18  Tom Tromey  <tromey@adacore.com>
 768
 769         * process-stratum-target.h (class process_stratum_target)
 770         <stratum>: Add "final".
 771
 772 2019-04-17  Tom Tromey  <tromey@adacore.com>
 773
 774         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 775         against nullptr before use.
 776
 777 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 778
 779         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 780
 781 2019-04-17  Jim Wilson  <jimw@sifive.com>
 782             Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 785         code read might fail, assume 4-byte breakpoint in that case.
 786
 787 2019-04-15  Leszek Swirski  <leszeks@google.com>
 788
 789         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 790         rather than a hand-rolled POD check when checking for forced MEMORY
 791         classification.
 792
 793 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 794
 795         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 796         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 797         function.
 798         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 799         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 800         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 801         declaration.
 802
 803 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 804
 805         * aarch64-linux-nat.c
 806         (aarch64_linux_nat_target::thread_architecture): Add override.
 807         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 808         each VQ.
 809
 810 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 811
 812         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 813
 814 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 815
 816         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 817         target types of size 96-bits, add some additional comments, and
 818         check that the builtin type we found was the correct size.
 819
 820 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 821
 822         * utils.c (prompt_for_continue): Don't restore the styling at the
 823         end, as applied_style has the wrong value.  This fixes styling in
 824         long lists of file names that are interrupted by the "Continue?"
 825         prompt.
 826
 827 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 830         * c-lang.c (c_language_defn): Likewise.
 831         (cplus_language_defn): Likewise.
 832         (asm_language_defn): Likewise.
 833         (minimal_language_defn): Likewise.
 834         * d-lang.c (d_language_defn): Likewise.
 835         * f-lang.c (f_language_defn): Likewise.
 836         * go-lang.c (go_language_defn): Likewise.
 837         * language.c (unknown_language_defn): Likewise.
 838         (auto_language_defn): Likewise.
 839         * language.h (struct language_defn): Remove la_magic field.
 840         (LANG_MAGIC): Delete.
 841         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 842         * objc-lang.c (objc_language_defn): Likewise.
 843         * opencl-lang.c (opencl_language_defn): Likewise.
 844         * p-lang.c (pascal_language_defn): Likewise.
 845         * rust-lang.c (rust_language_defn): Likewise.
 846
 847 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * riscv-tdep.c (riscv_type_align): New function.
 850         (riscv_type_alignment): Delete.
 851         (riscv_arg_location): Use 'type_align'.
 852         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 853
 854 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * gdbtypes.c (type_align): A struct with no non-static fields also
 857         has alignment of 1.
 858
 859 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 862         component to 0.
 863         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 864         member.
 865         (riscv_struct_info::analyse): New implementation using new
 866         analyse_inner member function.
 867         (riscv_struct_info::field_offset): New member function.
 868         (riscv_struct_info::m_offsets): New member variable.
 869         (riscv_struct_info::analyse_inner): New private member function,
 870         takes the old implementation of riscv_struct_info::analyse but
 871         extended to track field offsets.
 872         (riscv_call_arg_struct): Update the struct folding special cases
 873         to handle cases where empty C++ structs, which are non-zero
 874         length, are found.
 875         (riscv_arg_location): Initialise the length of each location, a
 876         non-zero length now indicates the location is in use.
 877         (riscv_push_dummy_call): Allow for the first location having a
 878         non-zero offset when setting up arguments.
 879         (riscv_return_value): Likewise, but for return values.
 880
 881 2019-04-11  Tom Tromey  <tromey@adacore.com>
 882
 883         * utils.c (internal_vproblem): Make "msg" const.
 884
 885 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 886
 887         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 888         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 889         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 890         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 891
 892 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 893
 894         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 895         function.
 896         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 897         of amd64_collect_native_gregset.
 898         (amd64_linux_nat_target::store_registers): Likewise.
 899
 900 2019-04-10  Tom Tromey  <tom@tromey.com>
 901
 902         * symtab.c (lookup_global_symbol_from_objfile)
 903         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 904         * objfiles.h (class separate_debug_iterator): New.
 905         (class separate_debug_range): New.
 906         (struct objfile) <separate_debug_objfiles>: New method.
 907         (objfile_separate_debug_iterate): Don't declare.
 908         * objfiles.c (separate_debug_iterator::operator++): Rename from
 909         objfile_separate_debug_iterate.
 910         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 911         iterator.
 912         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 913         iterator.
 914
 915 2019-04-10  Tom Tromey  <tom@tromey.com>
 916
 917         * symfile.c (reread_symbols): Remove old comment.
 918         * objfiles.c (free_all_objfiles): Fix a typo.
 919
 920 2019-04-10  Tom Tromey  <tom@tromey.com>
 921
 922         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 923         * minsyms.c (lookup_minimal_symbol): Use foreach.
 924         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 925         (lookup_minimal_symbol_solib_trampoline): Likewise.
 926         * symfile.c (reread_symbols): Use foreach.
 927
 928 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 929             Tom Tromey  <tromey@adacore.com>
 930
 931         PR rust/24414:
 932         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 933         (rust_lex_int_test): Change "value" to be LONGEST.
 934         (rust_lex_tests): Add test for long integer literal.
 935
 936 2019-04-09  Tom Tromey  <tromey@adacore.com>
 937
 938         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 939         to bool.
 940         (extended_remote_target::attach): Update.
 941         (remote_target::remote_notice_new_inferior): Update.
 942         (remote_target::add_current_inferior_and_thread): Update.
 943         * inferior.c (exit_inferior_1): Use "false".
 944         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 945
 946 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 947
 948         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 949         the "start" command.
 950
 951 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 952
 953         * python/py-inferior.c (infpy_thread_from_thread_handle):
 954         Adjust comments to reflect renaming of thread_from_thread_handle
 955         to thread_from_handle.  Adjust keywords.  Fix type error message.
 956         (inferior_object_methods): Add thread_from_handle.  Retain
 957         thread_from_thread_handle, but mark it as deprecated.
 958
 959 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 960
 961         * gdbthread.h (find_thread_by_handle): Revise declaration.
 962         * thread.c (find_thread_by_handle): Likewise.  Adjust
 963         implementation too.
 964         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 965         support for buffer objects as handles.
 966
 967 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 968
 969         * python/py-infthread.c (thpy_thread_handle): New function.
 970         (thread_object_methods): Register thpy_thread_handle.
 971
 972 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 973
 974         * gdbthread.h (thread_to_thread_handle): Declare.
 975         * thread.c (gdbtypes.h): Include.
 976         (thread_to_thread_handle): New function.
 977
 978         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 979         (target_thread_info_to_thread_handle): Declare.
 980         * target.c (target_thread_info_to_thread_handle): New function.
 981         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 982         * target-delegates.c: Regenerate.
 983
 984         * linux-thread-db.c (class thread_db_target): Add method
 985         thread_info_to_thread_handle.
 986         (thread_db_target::thread_info_to_thread_handle): Define.
 987         * remote.c (class remote_target): Add new method
 988         thread_info_to_thread_handle.
 989         (remote_target::thread_info_to_thread_handle): Define.
 990
 991 2019-04-08  Pedro Alves  <palves@redhat.com>
 992
 993         * common/common-exceptions.c (throw_exception): Don't create
 994         named object to throw; throw directly.
 995         (throw_it): Likewise.  Don't initialize gdb_exception::message
 996         here, with new; pass FMT and AP to the ctor instead.
 997         * common/common-exceptions.h: Include <string>.
 998         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 999         const char *, va_list)): New ctor.  Use std::make_shared.
1000         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1001         errors)): Delete.
1002         (gdb_exception_error::gdb_exception_error(enum errors, const char
1003         *, va_list)): New.
1004         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1005         Add assertion.
1006         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1007         errors)): Delete.
1008         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1009         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1010         Add assertion.
1011
1012 2019-04-08  Tom Tromey  <tom@tromey.com>
1013
1014         * valops.c (value_rtti_indirect_type): Replace throw_exception
1015         with throw.
1016         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1017         with throw.
1018         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1019         throw.
1020         * target.c (target_translate_tls_address): Replace throw_exception
1021         with throw.
1022         * stack.c (frame_apply_command_count): Replace throw_exception
1023         with throw.
1024         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1025         throw.
1026         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1027         with throw.
1028         * rs6000-tdep.c (rs6000_frame_cache)
1029         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1030         * remote.c: Replace throw_exception with throw.
1031         * record-full.c (record_full_message, record_full_wait_1)
1032         (record_full_restore): Replace throw_exception with throw.
1033         * record-btrace.c:
1034         (get_thread_current_frame_id, record_btrace_start_replaying)
1035         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1036         (cmd_record_btrace_start): Replace throw_exception with throw.
1037         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1038         throw.
1039         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1040         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1041         * linespec.c:
1042         (find_linespec_symbols): Replace throw_exception with throw.
1043         * infrun.c (displaced_step_prepare, resume): Replace
1044         throw_exception with throw.
1045         * infcmd.c (post_create_inferior): Replace throw_exception with
1046         throw.
1047         * inf-loop.c (inferior_event_handler): Replace throw_exception
1048         with throw.
1049         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1050         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1051         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1052         (get_prev_frame_always, get_frame_pc_if_available)
1053         (get_frame_address_in_block_if_available, get_frame_language):
1054         Replace throw_exception with throw.
1055         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1056         throw_exception with throw.
1057         * eval.c (fetch_subexp_value, evaluate_var_value)
1058         (evaluate_funcall, evaluate_subexp_standard): Replace
1059         throw_exception with throw.
1060         * dwarf2loc.c (call_site_find_chain)
1061         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1062         Replace throw_exception with throw.
1063         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1064         with throw.
1065         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1066         throw.
1067         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1068         * completer.c (complete_line_internal): Replace throw_exception
1069         with throw.
1070         * compile/compile-object-run.c (compile_object_run): Replace
1071         throw_exception with throw.
1072         * cli/cli-script.c (process_next_line): Replace throw_exception
1073         with throw.
1074         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1075         (btrace_enable, btrace_maint_update_pt_packets): Replace
1076         throw_exception with throw.
1077         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1078         throw_exception with throw.
1079         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1080         throw_exception with throw.
1081         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1082         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1083         * aarch64-tdep.c (aarch64_make_prologue_cache)
1084         (aarch64_make_stub_cache): Replace throw_exception with throw.
1085
1086 2019-04-08  Tom Tromey  <tom@tromey.com>
1087
1088         * common/common-exceptions.c (throw_exception): Rename from
1089         throw_exception_cxx.  Remove old copy.  Make argument const.
1090         (throw_it): Create and throw exception objects directly.
1091         * common/common-exceptions.h (throw_exception): Make argument
1092         const.
1093         (struct gdb_exception_error): Add constructor.
1094         (struct gdb_exception_quit): Add constructor.
1095
1096 2019-04-08  Tom Tromey  <tom@tromey.com>
1097
1098         * common/common-exceptions.h (exception_rethrow): Don't declare.
1099         (TRY_SJLJ): Update comment.
1100         (TRY, CATCH, END_CATCH): Remove.
1101         * common/common-exceptions.c (exception_rethrow): Remove.
1102
1103 2019-04-08  Tom Tromey  <tom@tromey.com>
1104
1105         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1106         Remove.
1107         (gdb_exception_error): Rename from
1108         gdb_exception_RETURN_MASK_ERROR.
1109         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1110         (gdb_quit_bad_alloc): Update.
1111         * aarch64-tdep.c: Update.
1112         * ada-lang.c: Update.
1113         * ada-typeprint.c: Update.
1114         * ada-valprint.c: Update.
1115         * amd64-tdep.c: Update.
1116         * arch-utils.c: Update.
1117         * break-catch-throw.c: Update.
1118         * breakpoint.c: Update.
1119         * btrace.c: Update.
1120         * c-varobj.c: Update.
1121         * cli/cli-cmds.c: Update.
1122         * cli/cli-interp.c: Update.
1123         * cli/cli-script.c: Update.
1124         * common/common-exceptions.c: Update.
1125         * common/new-op.c: Update.
1126         * common/selftest.c: Update.
1127         * compile/compile-c-symbols.c: Update.
1128         * compile/compile-cplus-symbols.c: Update.
1129         * compile/compile-object-load.c: Update.
1130         * compile/compile-object-run.c: Update.
1131         * completer.c: Update.
1132         * corelow.c: Update.
1133         * cp-abi.c: Update.
1134         * cp-support.c: Update.
1135         * cp-valprint.c: Update.
1136         * darwin-nat.c: Update.
1137         * disasm-selftests.c: Update.
1138         * dtrace-probe.c: Update.
1139         * dwarf-index-cache.c: Update.
1140         * dwarf-index-write.c: Update.
1141         * dwarf2-frame-tailcall.c: Update.
1142         * dwarf2-frame.c: Update.
1143         * dwarf2loc.c: Update.
1144         * dwarf2read.c: Update.
1145         * eval.c: Update.
1146         * event-loop.c: Update.
1147         * event-top.c: Update.
1148         * exec.c: Update.
1149         * f-valprint.c: Update.
1150         * fbsd-tdep.c: Update.
1151         * frame-unwind.c: Update.
1152         * frame.c: Update.
1153         * gdbtypes.c: Update.
1154         * gnu-v3-abi.c: Update.
1155         * guile/guile-internal.h: Update.
1156         * guile/scm-block.c: Update.
1157         * guile/scm-breakpoint.c: Update.
1158         * guile/scm-cmd.c: Update.
1159         * guile/scm-disasm.c: Update.
1160         * guile/scm-frame.c: Update.
1161         * guile/scm-lazy-string.c: Update.
1162         * guile/scm-math.c: Update.
1163         * guile/scm-param.c: Update.
1164         * guile/scm-ports.c: Update.
1165         * guile/scm-pretty-print.c: Update.
1166         * guile/scm-symbol.c: Update.
1167         * guile/scm-symtab.c: Update.
1168         * guile/scm-type.c: Update.
1169         * guile/scm-value.c: Update.
1170         * i386-linux-tdep.c: Update.
1171         * i386-tdep.c: Update.
1172         * inf-loop.c: Update.
1173         * infcall.c: Update.
1174         * infcmd.c: Update.
1175         * infrun.c: Update.
1176         * jit.c: Update.
1177         * language.c: Update.
1178         * linespec.c: Update.
1179         * linux-fork.c: Update.
1180         * linux-nat.c: Update.
1181         * linux-tdep.c: Update.
1182         * linux-thread-db.c: Update.
1183         * main.c: Update.
1184         * mi/mi-cmd-break.c: Update.
1185         * mi/mi-cmd-stack.c: Update.
1186         * mi/mi-interp.c: Update.
1187         * mi/mi-main.c: Update.
1188         * objc-lang.c: Update.
1189         * p-valprint.c: Update.
1190         * parse.c: Update.
1191         * ppc-linux-tdep.c: Update.
1192         * printcmd.c: Update.
1193         * python/py-arch.c: Update.
1194         * python/py-breakpoint.c: Update.
1195         * python/py-cmd.c: Update.
1196         * python/py-finishbreakpoint.c: Update.
1197         * python/py-frame.c: Update.
1198         * python/py-framefilter.c: Update.
1199         * python/py-gdb-readline.c: Update.
1200         * python/py-inferior.c: Update.
1201         * python/py-infthread.c: Update.
1202         * python/py-lazy-string.c: Update.
1203         * python/py-linetable.c: Update.
1204         * python/py-objfile.c: Update.
1205         * python/py-param.c: Update.
1206         * python/py-prettyprint.c: Update.
1207         * python/py-progspace.c: Update.
1208         * python/py-record-btrace.c: Update.
1209         * python/py-record.c: Update.
1210         * python/py-symbol.c: Update.
1211         * python/py-type.c: Update.
1212         * python/py-unwind.c: Update.
1213         * python/py-utils.c: Update.
1214         * python/py-value.c: Update.
1215         * python/python.c: Update.
1216         * record-btrace.c: Update.
1217         * record-full.c: Update.
1218         * remote-fileio.c: Update.
1219         * remote.c: Update.
1220         * riscv-tdep.c: Update.
1221         * rs6000-aix-tdep.c: Update.
1222         * rs6000-tdep.c: Update.
1223         * rust-exp.y: Update.
1224         * rust-lang.c: Update.
1225         * s390-tdep.c: Update.
1226         * selftest-arch.c: Update.
1227         * solib-dsbt.c: Update.
1228         * solib-frv.c: Update.
1229         * solib-spu.c: Update.
1230         * solib-svr4.c: Update.
1231         * solib.c: Update.
1232         * sparc64-linux-tdep.c: Update.
1233         * stack.c: Update.
1234         * symfile-mem.c: Update.
1235         * symmisc.c: Update.
1236         * target.c: Update.
1237         * thread.c: Update.
1238         * top.c: Update.
1239         * tracefile-tfile.c: Update.
1240         * tui/tui.c: Update.
1241         * typeprint.c: Update.
1242         * unittests/cli-utils-selftests.c: Update.
1243         * unittests/parse-connection-spec-selftests.c: Update.
1244         * valops.c: Update.
1245         * valprint.c: Update.
1246         * value.c: Update.
1247         * varobj.c: Update.
1248         * windows-nat.c: Update.
1249         * x86-linux-nat.c: Update.
1250         * xml-support.c: Update.
1251
1252 2019-04-08  Tom Tromey  <tom@tromey.com>
1253
1254         * xml-support.c: Use C++ exception handling.
1255         * x86-linux-nat.c: Use C++ exception handling.
1256         * windows-nat.c: Use C++ exception handling.
1257         * varobj.c: Use C++ exception handling.
1258         * value.c: Use C++ exception handling.
1259         * valprint.c: Use C++ exception handling.
1260         * valops.c: Use C++ exception handling.
1261         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1262         handling.
1263         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1264         * typeprint.c: Use C++ exception handling.
1265         * tui/tui.c: Use C++ exception handling.
1266         * tracefile-tfile.c: Use C++ exception handling.
1267         * top.c: Use C++ exception handling.
1268         * thread.c: Use C++ exception handling.
1269         * target.c: Use C++ exception handling.
1270         * symmisc.c: Use C++ exception handling.
1271         * symfile-mem.c: Use C++ exception handling.
1272         * stack.c: Use C++ exception handling.
1273         * sparc64-linux-tdep.c: Use C++ exception handling.
1274         * solib.c: Use C++ exception handling.
1275         * solib-svr4.c: Use C++ exception handling.
1276         * solib-spu.c: Use C++ exception handling.
1277         * solib-frv.c: Use C++ exception handling.
1278         * solib-dsbt.c: Use C++ exception handling.
1279         * selftest-arch.c: Use C++ exception handling.
1280         * s390-tdep.c: Use C++ exception handling.
1281         * rust-lang.c: Use C++ exception handling.
1282         * rust-exp.y: Use C++ exception handling.
1283         * rs6000-tdep.c: Use C++ exception handling.
1284         * rs6000-aix-tdep.c: Use C++ exception handling.
1285         * riscv-tdep.c: Use C++ exception handling.
1286         * remote.c: Use C++ exception handling.
1287         * remote-fileio.c: Use C++ exception handling.
1288         * record-full.c: Use C++ exception handling.
1289         * record-btrace.c: Use C++ exception handling.
1290         * python/python.c: Use C++ exception handling.
1291         * python/py-value.c: Use C++ exception handling.
1292         * python/py-utils.c: Use C++ exception handling.
1293         * python/py-unwind.c: Use C++ exception handling.
1294         * python/py-type.c: Use C++ exception handling.
1295         * python/py-symbol.c: Use C++ exception handling.
1296         * python/py-record.c: Use C++ exception handling.
1297         * python/py-record-btrace.c: Use C++ exception handling.
1298         * python/py-progspace.c: Use C++ exception handling.
1299         * python/py-prettyprint.c: Use C++ exception handling.
1300         * python/py-param.c: Use C++ exception handling.
1301         * python/py-objfile.c: Use C++ exception handling.
1302         * python/py-linetable.c: Use C++ exception handling.
1303         * python/py-lazy-string.c: Use C++ exception handling.
1304         * python/py-infthread.c: Use C++ exception handling.
1305         * python/py-inferior.c: Use C++ exception handling.
1306         * python/py-gdb-readline.c: Use C++ exception handling.
1307         * python/py-framefilter.c: Use C++ exception handling.
1308         * python/py-frame.c: Use C++ exception handling.
1309         * python/py-finishbreakpoint.c: Use C++ exception handling.
1310         * python/py-cmd.c: Use C++ exception handling.
1311         * python/py-breakpoint.c: Use C++ exception handling.
1312         * python/py-arch.c: Use C++ exception handling.
1313         * printcmd.c: Use C++ exception handling.
1314         * ppc-linux-tdep.c: Use C++ exception handling.
1315         * parse.c: Use C++ exception handling.
1316         * p-valprint.c: Use C++ exception handling.
1317         * objc-lang.c: Use C++ exception handling.
1318         * mi/mi-main.c: Use C++ exception handling.
1319         * mi/mi-interp.c: Use C++ exception handling.
1320         * mi/mi-cmd-stack.c: Use C++ exception handling.
1321         * mi/mi-cmd-break.c: Use C++ exception handling.
1322         * main.c: Use C++ exception handling.
1323         * linux-thread-db.c: Use C++ exception handling.
1324         * linux-tdep.c: Use C++ exception handling.
1325         * linux-nat.c: Use C++ exception handling.
1326         * linux-fork.c: Use C++ exception handling.
1327         * linespec.c: Use C++ exception handling.
1328         * language.c: Use C++ exception handling.
1329         * jit.c: Use C++ exception handling.
1330         * infrun.c: Use C++ exception handling.
1331         * infcmd.c: Use C++ exception handling.
1332         * infcall.c: Use C++ exception handling.
1333         * inf-loop.c: Use C++ exception handling.
1334         * i386-tdep.c: Use C++ exception handling.
1335         * i386-linux-tdep.c: Use C++ exception handling.
1336         * guile/scm-value.c: Use C++ exception handling.
1337         * guile/scm-type.c: Use C++ exception handling.
1338         * guile/scm-symtab.c: Use C++ exception handling.
1339         * guile/scm-symbol.c: Use C++ exception handling.
1340         * guile/scm-pretty-print.c: Use C++ exception handling.
1341         * guile/scm-ports.c: Use C++ exception handling.
1342         * guile/scm-param.c: Use C++ exception handling.
1343         * guile/scm-math.c: Use C++ exception handling.
1344         * guile/scm-lazy-string.c: Use C++ exception handling.
1345         * guile/scm-frame.c: Use C++ exception handling.
1346         * guile/scm-disasm.c: Use C++ exception handling.
1347         * guile/scm-cmd.c: Use C++ exception handling.
1348         * guile/scm-breakpoint.c: Use C++ exception handling.
1349         * guile/scm-block.c: Use C++ exception handling.
1350         * guile/guile-internal.h: Use C++ exception handling.
1351         * gnu-v3-abi.c: Use C++ exception handling.
1352         * gdbtypes.c: Use C++ exception handling.
1353         * frame.c: Use C++ exception handling.
1354         * frame-unwind.c: Use C++ exception handling.
1355         * fbsd-tdep.c: Use C++ exception handling.
1356         * f-valprint.c: Use C++ exception handling.
1357         * exec.c: Use C++ exception handling.
1358         * event-top.c: Use C++ exception handling.
1359         * event-loop.c: Use C++ exception handling.
1360         * eval.c: Use C++ exception handling.
1361         * dwarf2read.c: Use C++ exception handling.
1362         * dwarf2loc.c: Use C++ exception handling.
1363         * dwarf2-frame.c: Use C++ exception handling.
1364         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1365         * dwarf-index-write.c: Use C++ exception handling.
1366         * dwarf-index-cache.c: Use C++ exception handling.
1367         * dtrace-probe.c: Use C++ exception handling.
1368         * disasm-selftests.c: Use C++ exception handling.
1369         * darwin-nat.c: Use C++ exception handling.
1370         * cp-valprint.c: Use C++ exception handling.
1371         * cp-support.c: Use C++ exception handling.
1372         * cp-abi.c: Use C++ exception handling.
1373         * corelow.c: Use C++ exception handling.
1374         * completer.c: Use C++ exception handling.
1375         * compile/compile-object-run.c: Use C++ exception handling.
1376         * compile/compile-object-load.c: Use C++ exception handling.
1377         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1378         * compile/compile-c-symbols.c: Use C++ exception handling.
1379         * common/selftest.c: Use C++ exception handling.
1380         * common/new-op.c: Use C++ exception handling.
1381         * cli/cli-script.c: Use C++ exception handling.
1382         * cli/cli-interp.c: Use C++ exception handling.
1383         * cli/cli-cmds.c: Use C++ exception handling.
1384         * c-varobj.c: Use C++ exception handling.
1385         * btrace.c: Use C++ exception handling.
1386         * breakpoint.c: Use C++ exception handling.
1387         * break-catch-throw.c: Use C++ exception handling.
1388         * arch-utils.c: Use C++ exception handling.
1389         * amd64-tdep.c: Use C++ exception handling.
1390         * ada-valprint.c: Use C++ exception handling.
1391         * ada-typeprint.c: Use C++ exception handling.
1392         * ada-lang.c: Use C++ exception handling.
1393         * aarch64-tdep.c: Use C++ exception handling.
1394
1395 2019-04-08  Tom Tromey  <tom@tromey.com>
1396
1397         * xml-support.c (gdb_xml_parser::parse): Update.
1398         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1399         * value.c (show_convenience): Update.
1400         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1401         (test_parse_flags_qcs): Update.
1402         * thread.c (thr_try_catch_cmd): Update.
1403         * target.c (target_translate_tls_address): Update.
1404         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1405         (info_frame_command_core, frame_apply_command_count): Update.
1406         * rust-exp.y (rust_lex_exception_test): Update.
1407         * riscv-tdep.c (riscv_print_one_register_info): Update.
1408         * remote.c (remote_target::enable_btrace): Update.
1409         * record-btrace.c (record_btrace_enable_warn): Update.
1410         * python/py-utils.c (gdbpy_convert_exception): Update.
1411         * printcmd.c (do_one_display, print_variable_and_value): Update.
1412         * mi/mi-main.c (mi_print_exception): Update.
1413         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1414         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1415         * linux-nat.c (linux_nat_target::attach): Update.
1416         * linux-fork.c (class scoped_switch_fork_info): Update.
1417         * infrun.c (displaced_step_prepare): Update.
1418         * infcall.c (call_function_by_hand_dummy): Update.
1419         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1420         * gnu-v3-abi.c (print_one_vtable): Update.
1421         * frame.c (get_prev_frame_always): Update.
1422         * f-valprint.c (info_common_command_for_block): Update.
1423         * exec.c (try_open_exec_file): Update.
1424         * exceptions.c (print_exception, exception_print)
1425         (exception_fprintf, exception_print_same): Update.
1426         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1427         * dwarf-index-cache.c (index_cache::store)
1428         (index_cache::lookup_gdb_index): Update.
1429         * darwin-nat.c (maybe_cache_shell): Update.
1430         * cp-valprint.c (cp_print_value_fields): Update.
1431         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1432         (gcc_cplus_symbol_address): Update.
1433         * compile/compile-c-symbols.c (gcc_convert_symbol)
1434         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1435         * common/selftest.c: Update.
1436         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1437         a std::string.
1438         (exception_try_scope_entry, exception_try_scope_exit): Don't
1439         declare.
1440         (struct exception_try_scope): Remove.
1441         (TRY): Don't use exception_try_scope.
1442         (struct gdb_exception): Add constructor, operator=.
1443         <what>: New method.
1444         (struct gdb_exception_RETURN_MASK_ALL)
1445         (struct gdb_exception_RETURN_MASK_ERROR)
1446         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1447         (struct gdb_quit_bad_alloc): Update.
1448         * common/common-exceptions.c (exception_none): Change
1449         initializer.
1450         (struct catcher) <state, exception>: Initialize inline.
1451         <prev>: Remove member.
1452         (current_catcher): Remove.
1453         (catchers): New global.
1454         (exceptions_state_mc_init): Simplify.
1455         (catcher_pop): Remove.
1456         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1457         (try_scope_depth, exception_try_scope_entry)
1458         (exception_try_scope_exit): Remove.
1459         (throw_exception_sjlj): Update.
1460         (exception_messages, exception_messages_size): Remove.
1461         (throw_it): Simplify.
1462         (gdb_exception_sliced_copy): Remove.
1463         (throw_exception_cxx): Update.
1464         * cli/cli-script.c (script_from_file): Update.
1465         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1466         Update.
1467         * ada-valprint.c (ada_val_print): Update.
1468         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1469         (create_excep_cond_exprs): Update.
1470
1471 2019-04-08  Tom Tromey  <tom@tromey.com>
1472
1473         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1474         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1475         (TRY, CATCH, END_CATCH): Remove some definitions.
1476         * common/common-exceptions.c: Don't use GDB_XCPT.
1477         (catcher_list_size): Remove.
1478         (throw_exception, throw_it): Simplify.
1479
1480 2019-04-05  Tom Tromey  <tom@tromey.com>
1481
1482         Revert the header-sorting patch.
1483         * ft32-tdep.c: Revert.
1484         * frv-tdep.c: Revert.
1485         * frv-linux-tdep.c: Revert.
1486         * frame.c: Revert.
1487         * frame-unwind.c: Revert.
1488         * frame-base.c: Revert.
1489         * fork-child.c: Revert.
1490         * findvar.c: Revert.
1491         * findcmd.c: Revert.
1492         * filesystem.c: Revert.
1493         * filename-seen-cache.h: Revert.
1494         * filename-seen-cache.c: Revert.
1495         * fbsd-tdep.c: Revert.
1496         * fbsd-nat.h: Revert.
1497         * fbsd-nat.c: Revert.
1498         * f-valprint.c: Revert.
1499         * f-typeprint.c: Revert.
1500         * f-lang.c: Revert.
1501         * extension.h: Revert.
1502         * extension.c: Revert.
1503         * extension-priv.h: Revert.
1504         * expprint.c: Revert.
1505         * exec.h: Revert.
1506         * exec.c: Revert.
1507         * exceptions.c: Revert.
1508         * event-top.c: Revert.
1509         * event-loop.c: Revert.
1510         * eval.c: Revert.
1511         * elfread.c: Revert.
1512         * dwarf2read.h: Revert.
1513         * dwarf2read.c: Revert.
1514         * dwarf2loc.c: Revert.
1515         * dwarf2expr.h: Revert.
1516         * dwarf2expr.c: Revert.
1517         * dwarf2-frame.c: Revert.
1518         * dwarf2-frame-tailcall.c: Revert.
1519         * dwarf-index-write.h: Revert.
1520         * dwarf-index-write.c: Revert.
1521         * dwarf-index-common.c: Revert.
1522         * dwarf-index-cache.h: Revert.
1523         * dwarf-index-cache.c: Revert.
1524         * dummy-frame.c: Revert.
1525         * dtrace-probe.c: Revert.
1526         * disasm.h: Revert.
1527         * disasm.c: Revert.
1528         * disasm-selftests.c: Revert.
1529         * dictionary.c: Revert.
1530         * dicos-tdep.c: Revert.
1531         * demangle.c: Revert.
1532         * dcache.h: Revert.
1533         * dcache.c: Revert.
1534         * darwin-nat.h: Revert.
1535         * darwin-nat.c: Revert.
1536         * darwin-nat-info.c: Revert.
1537         * d-valprint.c: Revert.
1538         * d-namespace.c: Revert.
1539         * d-lang.c: Revert.
1540         * ctf.c: Revert.
1541         * csky-tdep.c: Revert.
1542         * csky-linux-tdep.c: Revert.
1543         * cris-tdep.c: Revert.
1544         * cris-linux-tdep.c: Revert.
1545         * cp-valprint.c: Revert.
1546         * cp-support.c: Revert.
1547         * cp-namespace.c: Revert.
1548         * cp-abi.c: Revert.
1549         * corelow.c: Revert.
1550         * corefile.c: Revert.
1551         * continuations.c: Revert.
1552         * completer.h: Revert.
1553         * completer.c: Revert.
1554         * complaints.c: Revert.
1555         * coffread.c: Revert.
1556         * coff-pe-read.c: Revert.
1557         * cli-out.h: Revert.
1558         * cli-out.c: Revert.
1559         * charset.c: Revert.
1560         * c-varobj.c: Revert.
1561         * c-valprint.c: Revert.
1562         * c-typeprint.c: Revert.
1563         * c-lang.c: Revert.
1564         * buildsym.c: Revert.
1565         * buildsym-legacy.c: Revert.
1566         * build-id.h: Revert.
1567         * build-id.c: Revert.
1568         * btrace.c: Revert.
1569         * bsd-uthread.c: Revert.
1570         * breakpoint.h: Revert.
1571         * breakpoint.c: Revert.
1572         * break-catch-throw.c: Revert.
1573         * break-catch-syscall.c: Revert.
1574         * break-catch-sig.c: Revert.
1575         * blockframe.c: Revert.
1576         * block.c: Revert.
1577         * bfin-tdep.c: Revert.
1578         * bfin-linux-tdep.c: Revert.
1579         * bfd-target.c: Revert.
1580         * bcache.c: Revert.
1581         * ax-general.c: Revert.
1582         * ax-gdb.h: Revert.
1583         * ax-gdb.c: Revert.
1584         * avr-tdep.c: Revert.
1585         * auxv.c: Revert.
1586         * auto-load.c: Revert.
1587         * arm-wince-tdep.c: Revert.
1588         * arm-tdep.c: Revert.
1589         * arm-symbian-tdep.c: Revert.
1590         * arm-pikeos-tdep.c: Revert.
1591         * arm-obsd-tdep.c: Revert.
1592         * arm-nbsd-tdep.c: Revert.
1593         * arm-nbsd-nat.c: Revert.
1594         * arm-linux-tdep.c: Revert.
1595         * arm-linux-nat.c: Revert.
1596         * arm-fbsd-tdep.c: Revert.
1597         * arm-fbsd-nat.c: Revert.
1598         * arm-bsd-tdep.c: Revert.
1599         * arch-utils.c: Revert.
1600         * arc-tdep.c: Revert.
1601         * arc-newlib-tdep.c: Revert.
1602         * annotate.h: Revert.
1603         * annotate.c: Revert.
1604         * amd64-windows-tdep.c: Revert.
1605         * amd64-windows-nat.c: Revert.
1606         * amd64-tdep.c: Revert.
1607         * amd64-sol2-tdep.c: Revert.
1608         * amd64-obsd-tdep.c: Revert.
1609         * amd64-obsd-nat.c: Revert.
1610         * amd64-nbsd-tdep.c: Revert.
1611         * amd64-nbsd-nat.c: Revert.
1612         * amd64-nat.c: Revert.
1613         * amd64-linux-tdep.c: Revert.
1614         * amd64-linux-nat.c: Revert.
1615         * amd64-fbsd-tdep.c: Revert.
1616         * amd64-fbsd-nat.c: Revert.
1617         * amd64-dicos-tdep.c: Revert.
1618         * amd64-darwin-tdep.c: Revert.
1619         * amd64-bsd-nat.c: Revert.
1620         * alpha-tdep.c: Revert.
1621         * alpha-obsd-tdep.c: Revert.
1622         * alpha-nbsd-tdep.c: Revert.
1623         * alpha-mdebug-tdep.c: Revert.
1624         * alpha-linux-tdep.c: Revert.
1625         * alpha-linux-nat.c: Revert.
1626         * alpha-bsd-tdep.c: Revert.
1627         * alpha-bsd-nat.c: Revert.
1628         * aix-thread.c: Revert.
1629         * agent.c: Revert.
1630         * addrmap.c: Revert.
1631         * ada-varobj.c: Revert.
1632         * ada-valprint.c: Revert.
1633         * ada-typeprint.c: Revert.
1634         * ada-tasks.c: Revert.
1635         * ada-lang.c: Revert.
1636         * aarch64-tdep.c: Revert.
1637         * aarch64-ravenscar-thread.c: Revert.
1638         * aarch64-newlib-tdep.c: Revert.
1639         * aarch64-linux-tdep.c: Revert.
1640         * aarch64-linux-nat.c: Revert.
1641         * aarch64-fbsd-tdep.c: Revert.
1642         * aarch64-fbsd-nat.c: Revert.
1643         * aarch32-linux-nat.c: Revert.
1644
1645 2019-04-05  Tom Tromey  <tom@tromey.com>
1646
1647         * ft32-tdep.c: Sort headers.
1648         * frv-tdep.c: Sort headers.
1649         * frv-linux-tdep.c: Sort headers.
1650         * frame.c: Sort headers.
1651         * frame-unwind.c: Sort headers.
1652         * frame-base.c: Sort headers.
1653         * fork-child.c: Sort headers.
1654         * findvar.c: Sort headers.
1655         * findcmd.c: Sort headers.
1656         * filesystem.c: Sort headers.
1657         * filename-seen-cache.h: Sort headers.
1658         * filename-seen-cache.c: Sort headers.
1659         * fbsd-tdep.c: Sort headers.
1660         * fbsd-nat.h: Sort headers.
1661         * fbsd-nat.c: Sort headers.
1662         * f-valprint.c: Sort headers.
1663         * f-typeprint.c: Sort headers.
1664         * f-lang.c: Sort headers.
1665         * extension.h: Sort headers.
1666         * extension.c: Sort headers.
1667         * extension-priv.h: Sort headers.
1668         * expprint.c: Sort headers.
1669         * exec.h: Sort headers.
1670         * exec.c: Sort headers.
1671         * exceptions.c: Sort headers.
1672         * event-top.c: Sort headers.
1673         * event-loop.c: Sort headers.
1674         * eval.c: Sort headers.
1675         * elfread.c: Sort headers.
1676         * dwarf2read.h: Sort headers.
1677         * dwarf2read.c: Sort headers.
1678         * dwarf2loc.c: Sort headers.
1679         * dwarf2expr.h: Sort headers.
1680         * dwarf2expr.c: Sort headers.
1681         * dwarf2-frame.c: Sort headers.
1682         * dwarf2-frame-tailcall.c: Sort headers.
1683         * dwarf-index-write.h: Sort headers.
1684         * dwarf-index-write.c: Sort headers.
1685         * dwarf-index-common.c: Sort headers.
1686         * dwarf-index-cache.h: Sort headers.
1687         * dwarf-index-cache.c: Sort headers.
1688         * dummy-frame.c: Sort headers.
1689         * dtrace-probe.c: Sort headers.
1690         * disasm.h: Sort headers.
1691         * disasm.c: Sort headers.
1692         * disasm-selftests.c: Sort headers.
1693         * dictionary.c: Sort headers.
1694         * dicos-tdep.c: Sort headers.
1695         * demangle.c: Sort headers.
1696         * dcache.h: Sort headers.
1697         * dcache.c: Sort headers.
1698         * darwin-nat.h: Sort headers.
1699         * darwin-nat.c: Sort headers.
1700         * darwin-nat-info.c: Sort headers.
1701         * d-valprint.c: Sort headers.
1702         * d-namespace.c: Sort headers.
1703         * d-lang.c: Sort headers.
1704         * ctf.c: Sort headers.
1705         * csky-tdep.c: Sort headers.
1706         * csky-linux-tdep.c: Sort headers.
1707         * cris-tdep.c: Sort headers.
1708         * cris-linux-tdep.c: Sort headers.
1709         * cp-valprint.c: Sort headers.
1710         * cp-support.c: Sort headers.
1711         * cp-namespace.c: Sort headers.
1712         * cp-abi.c: Sort headers.
1713         * corelow.c: Sort headers.
1714         * corefile.c: Sort headers.
1715         * continuations.c: Sort headers.
1716         * completer.h: Sort headers.
1717         * completer.c: Sort headers.
1718         * complaints.c: Sort headers.
1719         * coffread.c: Sort headers.
1720         * coff-pe-read.c: Sort headers.
1721         * cli-out.h: Sort headers.
1722         * cli-out.c: Sort headers.
1723         * charset.c: Sort headers.
1724         * c-varobj.c: Sort headers.
1725         * c-valprint.c: Sort headers.
1726         * c-typeprint.c: Sort headers.
1727         * c-lang.c: Sort headers.
1728         * buildsym.c: Sort headers.
1729         * buildsym-legacy.c: Sort headers.
1730         * build-id.h: Sort headers.
1731         * build-id.c: Sort headers.
1732         * btrace.c: Sort headers.
1733         * bsd-uthread.c: Sort headers.
1734         * breakpoint.h: Sort headers.
1735         * breakpoint.c: Sort headers.
1736         * break-catch-throw.c: Sort headers.
1737         * break-catch-syscall.c: Sort headers.
1738         * break-catch-sig.c: Sort headers.
1739         * blockframe.c: Sort headers.
1740         * block.c: Sort headers.
1741         * bfin-tdep.c: Sort headers.
1742         * bfin-linux-tdep.c: Sort headers.
1743         * bfd-target.c: Sort headers.
1744         * bcache.c: Sort headers.
1745         * ax-general.c: Sort headers.
1746         * ax-gdb.h: Sort headers.
1747         * ax-gdb.c: Sort headers.
1748         * avr-tdep.c: Sort headers.
1749         * auxv.c: Sort headers.
1750         * auto-load.c: Sort headers.
1751         * arm-wince-tdep.c: Sort headers.
1752         * arm-tdep.c: Sort headers.
1753         * arm-symbian-tdep.c: Sort headers.
1754         * arm-pikeos-tdep.c: Sort headers.
1755         * arm-obsd-tdep.c: Sort headers.
1756         * arm-nbsd-tdep.c: Sort headers.
1757         * arm-nbsd-nat.c: Sort headers.
1758         * arm-linux-tdep.c: Sort headers.
1759         * arm-linux-nat.c: Sort headers.
1760         * arm-fbsd-tdep.c: Sort headers.
1761         * arm-fbsd-nat.c: Sort headers.
1762         * arm-bsd-tdep.c: Sort headers.
1763         * arch-utils.c: Sort headers.
1764         * arc-tdep.c: Sort headers.
1765         * arc-newlib-tdep.c: Sort headers.
1766         * annotate.h: Sort headers.
1767         * annotate.c: Sort headers.
1768         * amd64-windows-tdep.c: Sort headers.
1769         * amd64-windows-nat.c: Sort headers.
1770         * amd64-tdep.c: Sort headers.
1771         * amd64-sol2-tdep.c: Sort headers.
1772         * amd64-obsd-tdep.c: Sort headers.
1773         * amd64-obsd-nat.c: Sort headers.
1774         * amd64-nbsd-tdep.c: Sort headers.
1775         * amd64-nbsd-nat.c: Sort headers.
1776         * amd64-nat.c: Sort headers.
1777         * amd64-linux-tdep.c: Sort headers.
1778         * amd64-linux-nat.c: Sort headers.
1779         * amd64-fbsd-tdep.c: Sort headers.
1780         * amd64-fbsd-nat.c: Sort headers.
1781         * amd64-dicos-tdep.c: Sort headers.
1782         * amd64-darwin-tdep.c: Sort headers.
1783         * amd64-bsd-nat.c: Sort headers.
1784         * alpha-tdep.c: Sort headers.
1785         * alpha-obsd-tdep.c: Sort headers.
1786         * alpha-nbsd-tdep.c: Sort headers.
1787         * alpha-mdebug-tdep.c: Sort headers.
1788         * alpha-linux-tdep.c: Sort headers.
1789         * alpha-linux-nat.c: Sort headers.
1790         * alpha-bsd-tdep.c: Sort headers.
1791         * alpha-bsd-nat.c: Sort headers.
1792         * aix-thread.c: Sort headers.
1793         * agent.c: Sort headers.
1794         * addrmap.c: Sort headers.
1795         * ada-varobj.c: Sort headers.
1796         * ada-valprint.c: Sort headers.
1797         * ada-typeprint.c: Sort headers.
1798         * ada-tasks.c: Sort headers.
1799         * ada-lang.c: Sort headers.
1800         * aarch64-tdep.c: Sort headers.
1801         * aarch64-ravenscar-thread.c: Sort headers.
1802         * aarch64-newlib-tdep.c: Sort headers.
1803         * aarch64-linux-tdep.c: Sort headers.
1804         * aarch64-linux-nat.c: Sort headers.
1805         * aarch64-fbsd-tdep.c: Sort headers.
1806         * aarch64-fbsd-nat.c: Sort headers.
1807         * aarch32-linux-nat.c: Sort headers.
1808
1809 2019-04-04  Tom Tromey  <tom@tromey.com>
1810
1811         * varobj.c (varobj_create): Update.
1812         * rust-exp.y (struct rust_parser) <update_innermost_block,
1813         lookup_symbol>: New methods.
1814         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1815         Rename.
1816         (rust_parser::rust_lookup_type)
1817         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1818         * printcmd.c (display_command, do_one_display): Update.
1819         * parser-defs.h (struct parser_state) <parser_state>: Add
1820         "tracker" parameter.
1821         (block_tracker): New member.
1822         (class innermost_block_tracker) <innermost_block_tracker>: Add
1823         "types" parameter.
1824         <reset>: Remove method.
1825         (innermost_block): Don't declare.
1826         (null_post_parser): Update.
1827         * parse.c (innermost_block): Remove global.
1828         (write_dollar_variable): Update.
1829         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1830         Remove "tracker_types" parameter.
1831         (parse_expression): Add "tracker" parameter.
1832         (parse_expression_for_completion): Update.
1833         (null_post_parser): Add "tracker" parameter.
1834         * p-exp.y: Update rules.
1835         * m2-exp.y: Update rules.
1836         * language.h (struct language_defn) <la_post_parser>: Add
1837         "tracker" parameter.
1838         * go-exp.y: Update rules.
1839         * f-exp.y: Update rules.
1840         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1841         parameter.
1842         * d-exp.y: Update rules.
1843         * c-exp.y: Update rules.
1844         * breakpoint.c (set_breakpoint_condition): Create an
1845         innermost_block_tracker.
1846         (watch_command_1): Likewise.
1847         * ada-lang.c (resolve): Add "tracker" parameter.
1848         (resolve_subexp): Likewise.
1849         * ada-exp.y (write_var_from_sym): Update.
1850
1851 2019-04-04  Tom Tromey  <tom@tromey.com>
1852
1853         * type-stack.h: New file.
1854         * type-stack.c: New file.
1855         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1856         type-stack.h.
1857         (insert_into_type_stack, insert_type, push_type, push_type_int)
1858         (insert_type_address_space, pop_type, pop_type_int)
1859         (pop_typelist, pop_type_stack, append_type_stack)
1860         (push_type_stack, get_type_stack, push_typelist)
1861         (follow_type_instance_flags, follow_types): Don't declare.
1862         * parse.c (type_stack): Remove global.
1863         (parse_exp_in_context): Update.
1864         (insert_into_type_stack, insert_type, push_type, push_type_int)
1865         (insert_type_address_space, pop_type, pop_type_int)
1866         (pop_typelist, pop_type_stack, append_type_stack)
1867         (push_type_stack, get_type_stack, push_typelist)
1868         (follow_type_instance_flags, follow_types): Remove (moved to
1869         type-stack.c).
1870         * f-exp.y (type_stack): New global.
1871         Update rules.
1872         (push_kind_type, f_parse): Update.
1873         * d-exp.y (type_stack): New global.
1874         Update rules.
1875         (d_parse): Update.
1876         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1877         Update rules.
1878         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1879         (HFILES_NO_SRCDIR): Add type-stack.h.
1880
1881 2019-04-04  Tom Tromey  <tom@tromey.com>
1882
1883         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1884         (rust_parser::convert_ast_to_expression, rust_parse)
1885         (rust_lex_test_completion, rust_lex_tests): Update.
1886         * parser-defs.h (struct expr_completion_state): New.
1887         (struct parser_state) <parser_state>: Add completion parameter.
1888         <mark_struct_expression, mark_completion_tag>: New methods.
1889         <parse_completion, m_completion_state>: New members.
1890         (prefixify_expression, null_post_parser): Update.
1891         (mark_struct_expression, mark_completion_tag): Don't declare.
1892         * parse.c (parse_completion, expout_last_struct)
1893         (expout_tag_completion_type, expout_completion_name): Remove
1894         globals.
1895         (parser_state::mark_struct_expression)
1896         (parser_state::mark_completion_tag): Now methods.
1897         (prefixify_expression): Add last_struct parameter.
1898         (prefixify_subexp): Likewise.
1899         (parse_exp_1): Update.
1900         (parse_exp_in_context): Add cstate parameter.  Update.
1901         (parse_expression_for_completion): Create an
1902         expr_completion_state.
1903         (null_post_parser): Add "completion" parameter.
1904         * p-exp.y: Update rules.
1905         (yylex): Update.
1906         * language.h (struct language_defn) <la_post_parser>: Add
1907         "completing" parameter.
1908         * go-exp.y: Update rules.
1909         (lex_one_token): Update.
1910         * expression.h (parse_completion): Don't declare.
1911         * d-exp.y: Update rules.
1912         (lex_one_token): Update rules.
1913         * c-exp.y: Update rules.
1914         (lex_one_token): Update.
1915         * ada-lang.c (resolve): Add "parse_completion" parameter.
1916         (resolve_subexp): Likewise.
1917         (ada_resolve_function): Likewise.
1918
1919 2019-04-04  Tom Tromey  <tom@tromey.com>
1920
1921         * parser-defs.h (struct parser_state) <start_arglist,
1922         end_arglist>: New methods.
1923         <arglist_len, m_funcall_chain>: New members.
1924         (arglist_len, start_arglist, end_arglist): Don't declare.
1925         * parse.c (arglist_len, funcall_chain): Remove global.
1926         (start_arglist, end_arglist): Remove functions.
1927         (parse_exp_in_context): Update.
1928         * p-exp.y: Update rules.
1929         * m2-exp.y: Update rules.
1930         * go-exp.y: Update rules.
1931         * f-exp.y: Update rules.
1932         * d-exp.y: Update rules.
1933         * c-exp.y: Update rules.
1934
1935 2019-04-04  Tom Tromey  <tom@tromey.com>
1936
1937         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1938         lex_operator, push_back>: New methods.
1939         Update all rules.
1940         (rust_parser::lex_hex, lex_escape): Rename and update.
1941         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1942         (rust_parser::lex_operator): Rename and update.
1943         (rust_parser::lex_number, rustyylex, rustyyerror)
1944         (rust_lex_test_init, rust_lex_test_sequence)
1945         (rust_lex_test_push_back, rust_lex_tests): Update.
1946         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1947         parameter.
1948         <lexptr, prev_lexptr>: New members.
1949         (lexptr, prev_lexptr): Don't declare.
1950         * parse.c (lexptr, prev_lexptr): Remove globals.
1951         (parse_exp_in_context): Update.
1952         * p-exp.y (yylex, yyerror): Update.
1953         * m2-exp.y (parse_number, yylex, yyerror): Update.
1954         * go-exp.y (lex_one_token, yyerror): Update.
1955         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1956         * d-exp.y (lex_one_token, yyerror): Update.
1957         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1958         (lex_one_token, yyerror): Update.
1959         * ada-lex.l (YY_INPUT): Update.
1960         (rewind_to_char): Update.
1961         * ada-exp.y (yyerror): Update.
1962
1963 2019-04-04  Tom Tromey  <tom@tromey.com>
1964
1965         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1966         * parser-defs.h (struct parser_state) <parser_state>: Add new
1967         parameter.
1968         <comma_terminates>: New member.
1969         (comma_terminates): Don't declare global.
1970         * parse.c (comma_terminates): Remove global.
1971         (parse_exp_in_context): Update.
1972         * p-exp.y (yylex): Update.
1973         * m2-exp.y (yylex): Update.
1974         * go-exp.y (lex_one_token): Update.
1975         * f-exp.y (yylex): Update.
1976         * d-exp.y (lex_one_token): Update.
1977         * c-exp.y (lex_one_token): Update.
1978         * ada-lex.l: Update.
1979
1980 2019-04-04  Tom Tromey  <tom@tromey.com>
1981
1982         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1983         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1984         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1985         * parser-defs.h (paren_depth): Don't declare.
1986         * parse.c (paren_depth): Remove global.
1987         (parse_exp_in_context): Update.
1988         * p-exp.y (paren_depth): New global.
1989         (pascal_parse): Initialize it.
1990         * m2-exp.y (paren_depth): New global.
1991         (m2_parse): Initialize it.
1992         * go-exp.y (paren_depth): New global.
1993         (go_parse): Initialize it.
1994         * f-exp.y (paren_depth): New global.
1995         (f_parse): Initialize it.
1996         * d-exp.y (paren_depth): New global.
1997         (d_parse): Initialize it.
1998         * c-exp.y (paren_depth): New global.
1999         (c_parse): Initialize it.
2000         * ada-lex.l (paren_depth): New global.
2001         (lexer_init): Initialize it.
2002
2003 2019-04-04  Tom Tromey  <tom@tromey.com>
2004
2005         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2006         (rust_parser::convert_ast_to_type)
2007         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2008         * parser-defs.h (struct parser_state) <parser_state>: Add
2009         parameters.  Initialize new members.
2010         <expression_context_block, expression_context_pc>: New members.
2011         * parse.c (expression_context_block, expression_context_pc):
2012         Remove globals.
2013         (parse_exp_in_context): Update.
2014         * p-exp.y: Update all rules.
2015         (yylex): Update.
2016         * m2-exp.y: Update all rules.
2017         (yylex): Update.
2018         * go-exp.y (yylex): Update.
2019         * f-exp.y (yylex): Update.
2020         * d-exp.y: Update all rules.
2021         (yylex): Update.
2022         * c-exp.y: Update all rules.
2023         (lex_one_token, classify_name, yylex, c_parse): Update.
2024         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2025
2026 2019-04-04  Tom Tromey  <tom@tromey.com>
2027
2028         * gdbarch.h, gdbarch.c: Rebuild.
2029         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2030         * stap-probe.h:
2031         (struct stap_parse_info): Replace "parser_state" with
2032         "expr_builder".
2033         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2034         (parser_state): New class.
2035         * parse.c (expr_builder): Rename.
2036         (expr_builder::release): Rename.
2037         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2038         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2039         (write_exp_elt_longcst, write_exp_elt_floatcst)
2040         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2041         (write_exp_string_vector, write_exp_bitstring)
2042         (write_exp_msymbol, mark_struct_expression)
2043         (write_dollar_variable)
2044         (insert_type_address_space, increase_expout_size): Replace
2045         "parser_state" with "expr_builder".
2046         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2047         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2048         "parser_state" with "expr_builder".
2049
2050 2019-04-04  Tom Tromey  <tom@tromey.com>
2051
2052         * rust-exp.y: Replace "parse_language" with method call.
2053         * p-exp.y:
2054         (yylex): Replace "parse_language" with method call.
2055         * m2-exp.y:
2056         (yylex): Replace "parse_language" with method call.
2057         * go-exp.y (classify_name): Replace "parse_language" with method
2058         call.
2059         * f-exp.y (yylex): Replace "parse_language" with method call.
2060         * d-exp.y (lex_one_token): Replace "parse_language" with method
2061         call.
2062         * c-exp.y:
2063         (lex_one_token, classify_name, yylex): Replace "parse_language"
2064         with method call.
2065         * ada-exp.y (find_primitive_type, type_char)
2066         (type_system_address): Replace "parse_language" with method call.
2067
2068 2019-04-04  Tom Tromey  <tom@tromey.com>
2069
2070         * rust-exp.y: Replace "parse_gdbarch" with method call.
2071         * parse.c (write_dollar_variable, insert_type_address_space):
2072         Replace "parse_gdbarch" with method call.
2073         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2074         call.
2075         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2076         call.
2077         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2078         "parse_gdbarch" with method call.
2079         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2080         with method call.
2081         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2082         "parse_gdbarch" with method call.
2083         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2084         "parse_gdbarch" with method call.
2085         * c-exp.y (parse_type, parse_number, classify_name): Replace
2086         "parse_gdbarch" with method call.
2087         * ada-lex.l: Replace "parse_gdbarch" with method call.
2088         * ada-exp.y (parse_type, find_primitive_type, type_char)
2089         (type_system_address): Replace "parse_gdbarch" with method call.
2090
2091 2019-04-04  Tom Tromey  <tom@tromey.com>
2092
2093         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2094         * stap-probe.c (stap_parse_argument): Update.
2095         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2096         initial_size parameter.
2097         * rust-exp.y (rust_lex_tests): Update.
2098         * parse.c (parser_state): Update.
2099         (parse_exp_in_context): Update.
2100         * parser-defs.h (struct parser_state) <parser_state>: Remove
2101         "initial_size" parameter.
2102
2103 2019-04-04  Tom Tromey  <tom@tromey.com>
2104
2105         * parser-defs.h (increase_expout_size): Don't declare.
2106         * parse.c (increase_expout_size): Now static.
2107
2108 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2109
2110         * gnu-nat.c (gnu_nat_target::wait): Fix
2111         target_waitstatus_to_string call.
2112
2113 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2114
2115         * eval.c (evaluate_subexp_standard): Handle internal functions
2116         during Fortran function call handling.
2117
2118 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * NEWS: Mention new internal functions.
2121         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2122         (read_base_type): Use dwarf2_init_complex_target_type.
2123         * value.c (creal_internal_fn): New function.
2124         (cimag_internal_fn): New function.
2125         (_initialize_values): Register new internal functions.
2126
2127 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2128
2129         * infrun.c (stop_all_threads): If debug_infrun, always
2130         trace the wait status after wait_one, using
2131         target_waitstatus_to_string and target_pid_to_str.
2132         (handle_inferior_event): Replace various trace of
2133         wait status kind by a single trace.
2134         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2135         wait status kind image by target_waitstatus_to_string.
2136         * target/waitstatus.c (target_waitstatus_to_string): Fix
2137         obsolete comment.
2138
2139 2019-04-01  Tom Tromey  <tromey@adacore.com>
2140
2141         PR symtab/23331:
2142         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2143
2144 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2145             Pedro Alves  <palves@redhat.com>
2146
2147         * top.c (quit_force): Call 'finalize_values'.
2148         * value.c (finalize_values): New function.
2149         * value.h (finalize_values): Declare.
2150
2151 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2152
2153         * NEWS: Announce $_gdb_major and $_gdb_minor.
2154
2155         * top.c (init_gdb_version_vars): New function.
2156         (gdb_init): Call init_gdb_version_vars.
2157
2158 2019-03-29  Tom Tromey  <tromey@adacore.com>
2159
2160         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2161         help text.  Remove dead code.
2162
2163 2019-03-29  Keith Seitz  <keiths@redhat.com>
2164
2165         From Siddhesh Poyarekar:
2166         * f-lang.h (f77_get_upperbound): Return LONGEST.
2167         (f77_get_lowerbound): Likewise.
2168         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2169         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2170         print them.
2171         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2172         plongest to format print it.
2173         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2174         (f77_get_upperbound): Likewise.
2175         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2176         LOWER_BOUND to LONGEST.
2177         (f77_create_arrayprint_offset_tbl): Likewise.
2178
2179 2019-03-29  Keith Seitz  <keiths@redhat.com>
2180
2181         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2182         %s/pulongest for TYPE_LENGTH instead of %d in format
2183         strings.
2184         * ada-typerint.c (ada_print_type): Likewise.
2185         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2186         * compile/compile-c-support.c (generate_register_struct): Likewise.
2187         * gdbtypes.c (recursive_dump_type): Likewise.
2188         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2189         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2190         instead of %d in format strings.
2191         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2192         to std::min to ULONGEST.
2193         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2194         instead of %d in format strings.
2195         * tracepoint.c (info_scope_command): Likewise.
2196         * typeprint.c (print_offset_data::update)
2197         (print_offset_data::finish): Likewise.
2198         * xtensa-tdep.c (xtensa_store_return_value)
2199         (xtensa_push_dummy_call): Likewise.
2200
2201 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2202
2203         * windows-nat.c (display_selector): Fixed format specifications
2204         for 64-bit Cygwin.
2205
2206 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2207
2208         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2209
2210 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2211
2212         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2213         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2214         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2215         (nios2_linux_init_abi): Install it.
2216
2217 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2218
2219         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2220
2221 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2222
2223         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2224
2225 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2226             Tom Tromey  <tromey@adacore.com>
2227
2228         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2229
2230 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2231
2232         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2233         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2234         method to compute the bounds of range types. Also print "[evaluated]"
2235         if the bounds' values come from a dynamic evaluation.
2236
2237 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2240         whitespace when pretty printing is on.
2241
2242 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2243
2244         * ppc-linux-nat.c: Add include.
2245
2246 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2247
2248         * NEWS: Mention AArch64 Pointer Authentication.
2249
2250 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2251
2252         * arm-linux-nat.c: Add include.
2253
2254 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2255
2256         * source-cache.c (source_cache::get_source_lines): Re-read
2257         fullname after calling open_source_file.
2258
2259 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2260
2261         * NEWS: Mention TLS support for FreeBSD.
2262
2263 2019-03-25  Tom Tromey  <tromey@adacore.com>
2264
2265         * minsyms.c (BUNCH_SIZE): Update comment.
2266         (~minimal_symbol_reader): Remove old comment.
2267         (compact_minimal_symbols): Update comment.
2268         (minimal_symbol_reader::install): Remove old comment.  Update
2269         other comments.
2270
2271 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * s390-linux-nat.c: Add include.
2274
2275 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2276
2277         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2278         Call linux_get_hwcap.
2279         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2280         Likewise.
2281         (aarch64_linux_get_hwcap): Remove function.
2282         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2283         declaration.
2284         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2285         linux_get_hwcap.
2286         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2287         * linux-tdep.c (linux_get_hwcap): Add function.
2288         (linux_get_hwcap2): Likewise.
2289         * linux-tdep.h (linux_get_hwcap): Add declaration.
2290         (linux_get_hwcap2): Likewise.
2291         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2292         (ppc_linux_get_hwcap2): Likewise.
2293         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2294         linux_get_hwcap.
2295         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2296         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2297         (ppc_linux_nat_target::read_description): Likewise.
2298         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2299         * s390-linux-nat.c: Likewise.
2300         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2301
2302 2019-03-24  Tom Tromey  <tom@tromey.com>
2303
2304         * ada-lang.c (standard_lookup): Simplify initialization.
2305         (ada_lookup_symbol_nonlocal): Simplify return.
2306         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2307         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2308         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2309         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2310         initialization.
2311         * solib.c (solib_global_lookup): Simplify.
2312         * symtab.c (null_block_symbol): Remove.
2313         (symbol_cache_lookup): Simplify returns.
2314         (lookup_language_this): Simplify returns.
2315         (lookup_symbol_aux): Simplify return.
2316         (lookup_local_symbol): Simplify returns.
2317         (lookup_global_symbol_from_objfile): Simplify return.
2318         (lookup_symbol_in_objfile_symtabs)
2319         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2320         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2321         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2322         * cp-namespace.c (cp_lookup_bare_symbol)
2323         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2324         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2325         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2326         (cp_lookup_symbol_via_imports): Simplify initialization.
2327         (find_symbol_in_baseclass): Likewise.
2328         * symtab.h (null_block_symbol): Remove.
2329         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2330         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2331         (d_lookup_symbol_module): Likewise.
2332         (find_symbol_in_baseclass): Simplify initialization.
2333
2334 2019-03-24  Tom Tromey  <tom@tromey.com>
2335
2336         * expression.h: Don't include symtab.h.
2337         (struct block): Forward declare.
2338
2339 2019-03-24  Tom Tromey  <tom@tromey.com>
2340
2341         * c-exp.y (typebase): Remove casts.
2342         * gdbtypes.c (lookup_unsigned_typename, )
2343         (lookup_signed_typename): Remove cast.
2344         * eval.c (parse_to_comma_and_eval): Remove cast.
2345         * parse.c (write_dollar_variable): Remove cast.
2346         * block.h (struct block) <superblock>: Now const.
2347         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2348         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2349         (map_block): Make "block" const.
2350         * symfile.h (struct quick_symbol_functions)
2351         <map_matching_symbols>: Constify block argument to "callback".
2352         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2353         const.
2354         (find_pc_sect_compunit_symtab): Make "b" const.
2355         (find_symbol_at_address): Likewise.
2356         (search_symbols): Likewise.
2357         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2358         (dw2_debug_names_lookup_symbol): Likewise.
2359         (dw2_map_matching_symbols): Update.
2360         * p-valprint.c (pascal_val_print): Remove "block".
2361         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2362         (aux_add_nonlocal_symbols): Make "block" const.
2363         (resolve_subexp): Remove cast.
2364         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2365         const.
2366         (iterate_over_file_blocks): Likewise.
2367         * f-exp.y (%union) <bval>: Remove.
2368         * coffread.c (patch_opaque_types): Make "b" const.
2369         * spu-tdep.c (spu_catch_start): Make "block" const.
2370         * c-valprint.c (print_unpacked_pointer): Remove "block".
2371         * symmisc.c (dump_symtab_1): Make "b" const.
2372         (block_depth): Make "block" const.
2373         * d-exp.y (%union) <bval>: Remove.
2374         * cp-support.h (cp_lookup_rtti_type): Update.
2375         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2376         * psymtab.c (psym_lookup_symbol): Make "block" const.
2377         (maintenance_check_psymtabs): Make "b" const.
2378         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2379         (enumerate_locals, enumerate_args): Update.
2380         * python/py-symtab.c (stpy_global_block): Make "block" const.
2381         (stpy_static_block): Likewise.
2382         * inline-frame.c (block_starting_point_at): Make "new_block"
2383         const.
2384         * block.c (find_block_in_blockvector): Make return type const.
2385         (blockvector_for_pc_sect): Make "b" const.
2386         (find_block_in_blockvector): Make "b" const.
2387
2388 2019-03-23  Tom Tromey  <tom@tromey.com>
2389
2390         * varobj.c (varobj_create): Update.
2391         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2392         * printcmd.c (display_command, do_one_display): Don't reset
2393         innermost_block.
2394         * parser-defs.h (enum innermost_block_tracker_type): Move to
2395         expression.h.
2396         (innermost_block): Update comment.
2397         * parse.c (parse_exp_1): Add tracker_types parameter.
2398         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2399         tracker_types parameter.  Reset innermost_block.
2400         (parse_exp_in_context): Remove.
2401         (parse_expression_for_completion): Update.
2402         * objfiles.c (~objfile): Don't reset expression_context_block or
2403         innermost_block.
2404         * expression.h (enum innermost_block_tracker_type): Move from
2405         parser-defs.h.
2406         (parse_exp_1): Add tracker_types parameter.
2407         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2408         reset innermost_block.
2409
2410 2019-03-23  Tom Tromey  <tom@tromey.com>
2411
2412         * objfiles.h: Include bcache.h.
2413
2414 2019-03-23  Tom Tromey  <tom@tromey.com>
2415
2416         * linespec.c (get_current_search_block): Use
2417         scoped_restore_current_language.
2418         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2419
2420 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2421             Jiong Wang  <jiong.wang@arm.com>
2422
2423         * aarch64-linux-tdep.c
2424         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2425         section.
2426         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2427
2428 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2429             Jiong Wang  <jiong.wang@arm.com>
2430
2431         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2432         instructions.
2433         (aarch64_analyze_prologue_test): Add PACIASP test.
2434         (aarch64_prologue_prev_register): Unmask PC value.
2435
2436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2437             Jiong Wang  <jiong.wang@arm.com>
2438
2439         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2440         (aarch64_dwarf2_prev_register): Unmask PC value.
2441         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2442         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2443         DW_CFA_AARCH64_negate_ra_state.
2444         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2445
2446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2447             Jiong Wang  <jiong.wang@arm.com>
2448
2449         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2450         registers.
2451         (aarch64_pseudo_register_name): Likewise.
2452         (aarch64_pseudo_register_type): Likewise.
2453         (aarch64_pseudo_register_reggroup_p): Likewise.
2454         (aarch64_gdbarch_init): Add pauth registers.
2455         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2456         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2457         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2458         (struct gdbarch_tdep): Add regnum for ra_state.
2459
2460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2461             Jiong Wang  <jiong.wang@arm.com>
2462
2463         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2464
2465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2466             Jiong Wang  <jiong.wang@arm.com>
2467
2468         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2469         function.
2470         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2471         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2472         (aarch64_gdbarch_init): Add puth registers.
2473         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2474         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2475         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2476
2477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2478             Jiong Wang  <jiong.wang@arm.com>
2479
2480         * aarch64-linux-nat.c
2481         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2482         * aarch64-linux-tdep.c
2483         (aarch64_linux_core_read_description): Likewise.
2484         (aarch64_linux_get_hwcap): New function.
2485         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2486         (aarch64_linux_get_hwcap): New declaration.
2487
2488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2489             Jiong Wang  <jiong.wang@arm.com>
2490
2491         * aarch64-linux-nat.c
2492         (aarch64_linux_nat_target::read_description): Add pauth param.
2493         * aarch64-linux-tdep.c
2494         (aarch64_linux_core_read_description): Likewise.
2495         * aarch64-tdep.c (struct target_desc): Add in pauth.
2496         (aarch64_read_description): Add pauth param.
2497         (aarch64_gdbarch_init): Likewise.
2498         * aarch64-tdep.h (aarch64_read_description): Likewise.
2499         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2500         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2501         * features/Makefile: Add new files.
2502         * features/aarch64-pauth.c: New file.
2503         * features/aarch64-pauth.xml: New file.
2504
2505 2019-03-20  Tom Tromey  <tromey@adacore.com>
2506
2507         * infrun.c (handle_inferior_event): Rename from
2508         handle_inferior_event_1.  Create a scoped_value_mark.
2509         (handle_inferior_event): Remove.
2510
2511 2019-03-19  Tom Tromey  <tromey@adacore.com>
2512
2513         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2514         * infrun.h (print_stop_event): Add "displays" parameter.
2515         * infrun.c (print_stop_event): Add "displays" parameter.
2516
2517 2019-03-19  Pedro Alves  <palves@redhat.com>
2518
2519         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2520         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2521         to -1.  Fix TABs vs spaces.
2522         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2523         * tui/tui-out.h (tui_ui_out) Add intro comments.
2524         <m_line, m_start_of_line>: In-class initialize, and add describing
2525         comment.
2526
2527 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2530         variable names.
2531         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2532
2533 2019-03-18  Pedro Alves  <palves@redhat.com>
2534             Eli Zaretskii <eliz@gnu.org>
2535
2536         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2537         m_line and m_start_of_line.
2538
2539 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2540
2541         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2542         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2543         it returns a newline.  This fixes a regression in TU mode, whereby
2544         the next line is output on the same screen line as the user input.
2545
2546 2019-03-18  Tom Tromey  <tromey@adacore.com>
2547
2548         * minsyms.c (minimal_symbol_reader::install): Remove call to
2549         obstack_blank.
2550
2551 2019-03-18  Pedro Alves  <palves@redhat.com>
2552
2553         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2554         New globals.
2555         (apply_style): New, factored out from ...
2556         (apply_ansi_escape): ... this.  Handle reverse video mode.
2557         (tui_set_reverse_mode): New function.
2558         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2559         * tui/tui-winsource.c (tui_show_source_line): Use
2560         tui_set_reverse_mode instead of setting A_STANDOUT.
2561         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2562         New setter methods.
2563
2564 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2565
2566         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2567         Handle tabs.
2568
2569 2019-03-18  Tom Tromey  <tromey@adacore.com>
2570
2571         * ada-lang.c (empty_array): Add "high" parameter.
2572         (ada_evaluate_subexp): Update.
2573
2574 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2575
2576         * unittests/string_view-selftests.c: Define
2577         _initialize_string_view_selftests unconditionally.
2578
2579 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2580
2581         PR gdb/24350
2582         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2583
2584 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2585
2586         PR gdb/24351
2587         * windows-nat.c (display_selector): Fix format specifiers.
2588
2589 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2590
2591         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2592         tui_refill_source_window instead of tui_refresh_win, to update the
2593         current execution line.  This fixes redisplay of the current line
2594         when stepping through the code with "next" or "step".
2595
2596 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2597
2598         * source-cache.c (source_cache::get_source_lines): Call
2599         find_source_lines to initialize s->nlines.  This fixes vertical
2600         scrolling of TUI source window when the DOWN arrow is pressed.
2601
2602 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2603
2604         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2605         linux-thread-db.c (_initialize_thread_db): Likewise.
2606
2607 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2608
2609         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2610         wclrtoeol in tui_show_source_line".  This reverts changes made in
2611         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2612
2613 2019-03-15  Tom Tromey  <tom@tromey.com>
2614
2615         * symtab.h (struct minimal_symbol): Derive from
2616         general_symbol_info.
2617         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2618         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2619         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2620         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2621         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2622         (MSYMBOL_SEARCH_NAME): Update.
2623         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2624         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2625         * minsyms.c (minimal_symbol_reader::record_full): Update.
2626
2627 2019-03-15  Tom Tromey  <tom@tromey.com>
2628
2629         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2630
2631 2019-03-15  Tom Tromey  <tom@tromey.com>
2632
2633         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2634         unique_xmalloc_ptr.
2635         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2636         Update.
2637         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2638         (build_minimal_symbol_hash_tables)
2639         (minimal_symbol_reader::install): Update.
2640
2641 2019-03-15  Tom Tromey  <tom@tromey.com>
2642
2643         * symtab.c (create_demangled_names_hash): Update.
2644         (symbol_set_names): Update.
2645         * objfiles.h (struct objfile_per_bfd_storage)
2646         <demangled_names_hash>: Now an htab_up.
2647         * objfiles.c (objfile_per_bfd_storage): Simplify.
2648
2649 2019-03-15  Tom Tromey  <tom@tromey.com>
2650
2651         * objfiles.h (struct objfile_per_bfd_storage): Declare
2652         destructor.
2653         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2654         New.
2655         (get_objfile_bfd_data): Use new.  Don't initialize
2656         language_of_main.
2657         (free_objfile_per_bfd_storage): Remove.
2658         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2659
2660 2019-03-15  Tom Tromey  <tom@tromey.com>
2661
2662         * symfile.c (reread_symbols): Update.
2663         * objfiles.c (objfile::objfile): Update.
2664         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2665         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2666         comment.
2667         (minimal_symbol_reader::install): Update.
2668         (terminate_minimal_symbol_table): Remove.
2669         * jit.c (jit_object_close_impl): Update.
2670
2671 2019-03-15  Tom Tromey  <tom@tromey.com>
2672
2673         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2674         initializations.
2675
2676 2019-03-15  Tom Tromey  <tom@tromey.com>
2677
2678         * objfiles.h (struct objfile_per_bfd_storage)
2679         <demangled_hash_languages>: Now a bitset.
2680         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2681         (lookup_minimal_symbol): Update.
2682
2683 2019-03-15  Tom Tromey  <tom@tromey.com>
2684
2685         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2686         Don't return the symbol.
2687         * coffread.c (record_minimal_symbol): Use record_full.
2688
2689 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2690
2691         The MS-Windows port of ncurses fails to switch to a color pair if
2692         one or both of the colors are the implicit default colors.  This
2693         change records the default colors when TUI is initialized, and
2694         then specifies them explicitly when a color pair uses the default
2695         colors.  This allows color styling in TUI mode on MS-Windows.
2696
2697         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2698         ncurses_norm_attr.
2699         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2700         colors in ncurses_norm_attr.
2701         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2702         "none", replace it with the default color recorded in
2703         ncurses_norm_attr.
2704
2705 2019-03-14  Tom Tromey  <tromey@adacore.com>
2706
2707         * source-cache.h (class source_cache) <get_source_lines>: Return
2708         std::string.
2709         * source-cache.c (source_cache::extract_lines): Handle case where
2710         first_pos==npos.  Return std::string.
2711         (source_cache::get_source_lines): Update.
2712
2713 2019-03-14  Tom Tromey  <tromey@adacore.com>
2714
2715         * NEWS: Add item for "style sources" commands.
2716         * source-cache.c (source_cache::get_source_lines): Check
2717         source_styling.
2718         * cli/cli-style.c (source_styling): New global.
2719         (_initialize_cli_style): Add "style sources" commands.
2720         (show_style_sources): New function.
2721         * cli/cli-style.h (source_styling): Declare.
2722
2723 2019-03-14  Pedro Alves  <palves@redhat.com>
2724             Tom Tromey  <tromey@adacore.com>
2725
2726         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2727         * tui/tui-winsource.c (tui_refill_source_window): New function,
2728         from...
2729         (tui_horizontal_source_scroll): ... here.  Move some logic.
2730         * cli/cli-style.c (set_style_enabled): Notify new observable.
2731         * tui/tui-hooks.c (tui_redisplay_source): New function.
2732         (tui_attach_detach_observers): Attach or detach
2733         tui_redisplay_source.
2734         * observable.h (source_styling_changed): New observable.
2735         * observable.c: Define source_styling_changed observable.
2736
2737 2019-03-13  Tom Tromey  <tromey@adacore.com>
2738
2739         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2740         (i386_gnu_nat_target::store_registers): Update.
2741         * target-debug.h (target_debug_print_std_string): New macro.
2742         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2743         * windows-tdep.c (display_one_tib): Update.
2744         * tui/tui-stack.c (tui_make_status_line): Update.
2745         * top.c (print_inferior_quit_action): Update.
2746         * thread.c (thr_try_catch_cmd): Update.
2747         (add_thread_with_info): Update.
2748         (thread_target_id_str): Update.
2749         (thr_try_catch_cmd): Update.
2750         (thread_command): Update.
2751         (thread_find_command): Update.
2752         * record-btrace.c (record_btrace_target::info_record)
2753         (record_btrace_resume_thread, record_btrace_target::resume)
2754         (record_btrace_cancel_resume, record_btrace_step_thread)
2755         (record_btrace_target::wait, record_btrace_target::wait)
2756         (record_btrace_target::wait, record_btrace_target::stop): Update.
2757         * progspace.c (print_program_space): Update.
2758         * process-stratum-target.c
2759         (process_stratum_target::thread_address_space): Update.
2760         * linux-fork.c (linux_fork_mourn_inferior)
2761         (detach_checkpoint_command, info_checkpoints_command)
2762         (linux_fork_context): Update.
2763         (linux_fork_detach): Update.
2764         (class scoped_switch_fork_info): Update.
2765         (delete_checkpoint_command): Update.
2766         * infrun.c (follow_fork_inferior): Update.
2767         (follow_fork_inferior): Update.
2768         (proceed_after_vfork_done): Update.
2769         (handle_vfork_child_exec_or_exit): Update.
2770         (follow_exec): Update.
2771         (displaced_step_prepare_throw): Update.
2772         (displaced_step_restore): Update.
2773         (start_step_over): Update.
2774         (resume_1): Update.
2775         (clear_proceed_status_thread): Update.
2776         (proceed): Update.
2777         (print_target_wait_results): Update.
2778         (do_target_wait): Update.
2779         (context_switch): Update.
2780         (stop_all_threads): Update.
2781         (restart_threads): Update.
2782         (finish_step_over): Update.
2783         (handle_signal_stop): Update.
2784         (switch_back_to_stepped_thread): Update.
2785         (keep_going_pass_signal): Update.
2786         (print_exited_reason): Update.
2787         (normal_stop): Update.
2788         * inferior.c (inferior_pid_to_str): Change return type.
2789         (print_selected_inferior): Update.
2790         (add_inferior): Update.
2791         (detach_inferior): Update.
2792         * dummy-frame.c (fprint_dummy_frames): Update.
2793         * dcache.c (dcache_info_1): Update.
2794         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2795         (btrace_fetch, btrace_clear): Update.
2796         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2797         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2798         type.
2799         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2800         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2801         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2802         * gdbarch.c, gdbarch.h: Rebuild.
2803         * gdbarch.sh (core_pid_to_str): Change return type.
2804         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2805         return type.
2806         (windows_nat_target::pid_to_str): Change return type.
2807         (windows_delete_thread): Update.
2808         (windows_nat_target::attach): Update.
2809         (windows_nat_target::files_info): Update.
2810         * target-delegates.c: Rebuild.
2811         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2812         return type.
2813         (sol_thread_target::pid_to_str): Change return type.
2814         * remote.c (class remote_target) <pid_to_str>: Change return
2815         type.
2816         (remote_target::pid_to_str): Change return type.
2817         (extended_remote_target::attach, remote_target::remote_stop_ns)
2818         (remote_target::remote_notif_remove_queued_reply)
2819         (remote_target::push_stop_reply, remote_target::disable_btrace):
2820         Update.
2821         (extended_remote_target::attach): Update.
2822         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2823         type.
2824         (gdbsim_target::pid_to_str): Change return type.
2825         * ravenscar-thread.c (struct ravenscar_thread_target)
2826         <pid_to_str>: Change return type.
2827         (ravenscar_thread_target::pid_to_str): Change return type.
2828         * procfs.c (class procfs_target) <pid_to_str>: Change return
2829         type.
2830         (procfs_target::pid_to_str): Change return type.
2831         (procfs_target::attach): Update.
2832         (procfs_target::detach): Update.
2833         (procfs_target::fetch_registers): Update.
2834         (procfs_target::store_registers): Update.
2835         (procfs_target::wait): Update.
2836         (procfs_target::files_info): Update.
2837         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2838         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2839         return type.
2840         (nto_procfs_target::pid_to_str): Change return type.
2841         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2842         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2843         return type.
2844         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2845         (exit_lwp): Update.
2846         (attach_proc_task_lwp_callback, get_detach_signal)
2847         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2848         (linux_nat_target::resume, wait_lwp, stop_callback)
2849         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2850         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2851         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2852         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2853         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2854         type.
2855         (inf_ptrace_target::attach): Update.
2856         (inf_ptrace_target::files_info): Update.
2857         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2858         type.
2859         (go32_nat_target::pid_to_str): Change return type.
2860         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2861         (gnu_nat_target::wait): Update.
2862         (gnu_nat_target::wait): Update.
2863         (gnu_nat_target::resume): Update.
2864         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2865         (fbsd_nat_target::wait): Update.
2866         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2867         type.
2868         (darwin_nat_target::attach): Update.
2869         * corelow.c (class core_target) <pid_to_str>: Change return type.
2870         (core_target::pid_to_str): Change return type.
2871         * target.c (normal_pid_to_str): Change return type.
2872         (default_pid_to_str): Likewise.
2873         (target_pid_to_str): Change return type.
2874         (target_translate_tls_address): Update.
2875         (target_announce_detach): Update.
2876         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2877         return type.
2878         (bsd_uthread_target::pid_to_str): Change return type.
2879         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2880         type.
2881         (bsd_kvm_target::pid_to_str): Change return type.
2882         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2883         return type.
2884         (aix_thread_target::pid_to_str): Change return type.
2885         * target.h (struct target_ops) <pid_to_str>: Change return type.
2886         (target_pid_to_str, normal_pid_to_str): Likewise.
2887         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2888         type.
2889         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2890         type.
2891         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2892         return type.
2893         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2894         type.
2895         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2896         type.
2897         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2898         return type.
2899
2900 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2901
2902         * NEWS: Mention that the new default MI version is 3.  Mention
2903         changes to the output of commands and events that deal with
2904         multi-location breakpoints.
2905         * breakpoint.c: Include "mi/mi-out.h".
2906         (print_one_breakpoint): Change output syntax if using MI version
2907         >= 3.
2908         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2909         New.
2910         (mi_multi_location_breakpoint_output_fixed): New.
2911         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2912         (mi_cmd_fix_multi_location_breakpoint_output): New.
2913         (mi_multi_location_breakpoint_output_fixed): New.
2914         * mi/mi-cmds.c (mi_cmds): Register command
2915         -fix-multi-location-breakpoint-output.
2916         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2917         interpreter "mi".
2918
2919 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2920
2921         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2922         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2923         instantiate mi_ui_out based on interpreter name.
2924         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2925         * mi/mi-main.c (mi_load_progress): Likewise.
2926
2927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2928
2929         * NEWS: Combine separate "New targets" sections for 8.3.
2930
2931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2932
2933         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2934         (ppcfbsd_init_abi): Install gdbarch
2935         "fetch_tls_load_module_address" and "get_thread_local_address"
2936         methods.
2937
2938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2939
2940         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2941         (riscv_fbsd_init_abi): Install gdbarch
2942         "fetch_tls_load_module_address" and "get_thread_local_address"
2943         methods.
2944
2945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2946
2947         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2948         (i386fbsd_init_abi): Install gdbarch
2949         "fetch_tls_load_module_address" and "get_thread_local_address"
2950         methods.
2951
2952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2953
2954         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2955         (amd64fbsd_init_abi): Install gdbarch
2956         "fetch_tls_load_module_address" and "get_thread_local_address"
2957         methods.
2958
2959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2960
2961         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2962         (struct fbsd_pspace_data): New type.
2963         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2964         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2965         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2966         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2967         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2968
2969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2970
2971         * gdbtypes.c (lookup_struct_elt): New function.
2972         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2973         * gdbtypes.h (struct struct_elt): New type.
2974         (lookup_struct_elt): New prototype.
2975
2976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2977
2978         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2979         remove disabled code block.
2980
2981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2982
2983         * gdbarch.sh (get_thread_local_address): New method.
2984         * gdbarch.h, gdbarch.c: Regenerate.
2985         * target.c (target_translate_tls_address): Use
2986         gdbarch_get_thread_local_address if present instead of
2987         target::get_thread_local_address.
2988
2989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2990
2991         * target.h (target::get_thread_local_address): Update comment.
2992
2993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2994
2995         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2996         objfile->separate_debug_objfile_backlink if not NULL.
2997
2998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2999
3000         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3001         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3002         (amd64bsd_store_inferior_registers): Likewise.
3003         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3004         Enable segment base registers.
3005         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3006         PT_GETFSBASE and PT_GETGSBASE.
3007         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3008         PT_SETGSBASE.
3009         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3010         segment base registers.
3011         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3012
3013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3014
3015         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3016         Update calls to i386_target_description to add 'segments'
3017         parameter.
3018         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3019         add segment base registers.
3020         * arch/i386.c (i386_create_target_description): Add 'segments'
3021         parameter to enable segment base registers.
3022         * arch/i386.h (i386_create_target_description): Likewise.
3023         * features/i386/32bit-segments.xml: New file.
3024         * features/i386/32bit-segments.c: Generate.
3025         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3026         call to i386_target_description to add 'segments' parameter.
3027         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3028         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3029         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3030         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3031         if feature is present.
3032         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3033         Add 'segments' parameter to call to i386_target_description.
3034         (i386_target_description): Add 'segments' parameter to enable
3035         segment base registers.
3036         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3037         to call to i386_target_description.
3038         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3039         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3040         Define I386_NUM_REGS.
3041         (i386_target_description): Add 'segments' parameter to enable
3042         segment base registers.
3043
3044 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3045
3046         PR/24325
3047         * source-cache.c: #undef open and close, to avoid unresolved
3048         externals during linking.
3049
3050 2019-03-12  Tom Tromey  <tromey@adacore.com>
3051
3052         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3053         const.  Add initializers.
3054         (_initialize_remote): Don't initialize ptid globals.
3055
3056 2019-03-12  Pedro Alves  <palves@redhat.com>
3057
3058         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3059
3060 2019-03-12  Pedro Alves  <palves@redhat.com>
3061
3062         * cp-name-parser.y (main): Remove unused 'len' variable.
3063
3064 2019-03-12  Tom Tromey  <tromey@adacore.com>
3065
3066         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3067         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3068
3069 2019-03-12  Tom Tromey  <tromey@adacore.com>
3070
3071         * linux-nat.c (iterate_over_lwps): Update.
3072         (stop_callback): Remove parameter.
3073         (stop_wait_callback, detach_callback, resume_set_callback)
3074         (select_singlestep_lwp_callback, set_ignore_sigint)
3075         (status_callback, resumed_callback, resume_clear_callback)
3076         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3077         data parameter.
3078         (linux_nat_target::detach, linux_nat_target::resume)
3079         (linux_stop_and_wait_all_lwps, select_event_lwp)
3080         (linux_nat_filter_event, linux_nat_wait_1)
3081         (linux_nat_target::kill, linux_nat_target::stop)
3082         (linux_nat_target::stop): Update.
3083         (linux_nat_resume_callback): Change type.
3084         (resume_stopped_resumed_lwps, count_events_callback)
3085         (select_event_lwp_callback): Likewise.
3086         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3087         * arm-linux-nat.c (struct update_registers_data): Remove.
3088         (update_registers_callback): Change type.
3089         (arm_linux_insert_hw_breakpoint1): Update.
3090         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3091         parameter.
3092         (x86_linux_dr_set_addr): Update.
3093         (x86_linux_dr_set_control): Update.
3094         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3095         (iterate_over_lwps): Use gdb::function_view.
3096         * nat/aarch64-linux-hw-point.c (struct
3097         aarch64_dr_update_callback_param): Remove.
3098         (debug_reg_change_callback): Change type.
3099         (aarch64_notify_debug_reg_change): Update.
3100         * s390-linux-nat.c (s390_refresh_per_info): Update.
3101
3102 2019-03-11  Tom Tromey  <tromey@adacore.com>
3103
3104         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3105         redundant assignment to "this_cu".
3106
3107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3108
3109         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3110
3111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3112
3113         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3114         from...
3115         (rank_one_type): ... this.
3116
3117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3118
3119         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3120         from...
3121         (rank_one_type): ... this.
3122
3123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3124
3125         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3126         from...
3127         (rank_one_type): ... this.
3128
3129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3130
3131         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3132         from...
3133         (rank_one_type): ... this.
3134
3135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3136
3137         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3138         from...
3139         (rank_one_type): ... this.
3140
3141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3142
3143         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3144         from...
3145         (rank_one_type): ... this.
3146
3147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3148
3149         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3150         from...
3151         (rank_one_type): ... this.
3152
3153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3154
3155         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3156         from...
3157         (rank_one_type): ... this.
3158
3159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3160
3161         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3162         from...
3163         (rank_one_type): ... this.
3164
3165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3166
3167         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3168         from...
3169         (rank_one_type): ... this.
3170
3171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3174         from...
3175         (rank_one_type): ... this.
3176
3177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3178
3179         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3180         from...
3181         (rank_one_type): ... this.
3182
3183 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3184
3185         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3186         inferior-events' shows the example events.
3187
3188 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3189
3190         Support styling on native MS-Windows console
3191
3192         PR/24315
3193         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3194         on MS-Windows if $TERM is not defined.
3195
3196         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3197
3198         * posix-hdep.c (gdb_console_fputs):
3199         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3200         functions.
3201         * ui-file.h (gdb_console_fputs): Add prototype.
3202
3203         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3204         back to fputs only if the former returns zero.
3205
3206 2019-03-07  Tom Tromey  <tom@tromey.com>
3207
3208         * symmisc.c (print_symbol_bcache_statistics): Update.
3209         (print_objfile_statistics): Update.
3210         * symfile.c (allocate_symtab): Update.
3211         * stabsread.c: Don't include bcache.h.
3212         * psymtab.h (struct psymbol_bcache): Don't declare.
3213         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3214         (psymbol_bcache_init, psymbol_bcache_free)
3215         (psymbol_bcache_get_bcache): Don't declare.
3216         * psymtab.c (struct psymbol_bcache): Remove.
3217         (psymtab_storage::psymtab_storage): Update.
3218         (psymtab_storage::~psymtab_storage): Update.
3219         (psymbol_bcache_init, psymbol_bcache_free)
3220         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3221         (add_psymbol_to_bcache): Update.
3222         (allocate_psymtab): Update.
3223         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3224         macro_cache>: No longer pointers.
3225         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3226         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3227         * macrotab.c (macro_bcache): Update.
3228         * macroexp.c: Don't include bcache.h.
3229         * gdbtypes.c (check_types_worklist): Update.
3230         (types_deeply_equal): Remove TRY/CATCH.  Update.
3231         * elfread.c (elf_symtab_read): Update.
3232         * dwarf2read.c: Don't include bcache.h.
3233         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3234         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3235         (print_bcache_statistics, bcache_memory_used): Don't declare.
3236         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3237         methods.  Rename all data members.
3238         * bcache.c (struct bcache): Move to bcache.h.
3239         (bcache::expand_hash_table): Rename from expand_hash_table.
3240         (bcache): Remove.
3241         (bcache::insert): Rename from bcache_full.
3242         (bcache::compare): Rename from bcache_compare.
3243         (bcache_xmalloc): Remove.
3244         (bcache::~bcache): Rename from bcache_xfree.
3245         (bcache::print_statistics): Rename from print_bcache_statistics.
3246         (bcache::memory_used): Rename from bcache_memory_used.
3247
3248 2019-03-07  Pedro Alves  <palves@redhat.com>
3249
3250         * infrun.c (normal_stop): Also check for
3251         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3252
3253 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * f-lang.c (value_from_host_double): Moved to...
3256         * value.c (value_from_host_double): ...here.
3257         * value.h (value_from_host_double): Declare.
3258         * guile/scm-math.c (vlscm_convert_typed_number): Use
3259         value_from_host_double.
3260         (vlscm_convert_number): Likewise.
3261         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3262         * python/py-value.c (convert_value_from_python): Likewise.
3263
3264 2019-03-06  Tom Tromey  <tom@tromey.com>
3265
3266         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3267
3268 2019-03-06  Tom Tromey  <tom@tromey.com>
3269
3270         * utils.h (free_current_contents): Don't declare.
3271         * utils.c (free_current_contents): Remove.
3272
3273 2019-03-06  Tom Tromey  <tom@tromey.com>
3274
3275         * top.c (quit_force): Update.
3276         * main.c (captured_command_loop): Update.
3277         * common/new-op.c (operator new): Update.
3278         * common/common-exceptions.c (struct catcher)
3279         <save_cleanup_chain>: Remove member.
3280         (exceptions_state_mc_init): Update.
3281         (exception_try_scope_entry): Return nullptr.
3282         (exception_try_scope_exit, exception_rethrow)
3283         (throw_exception_sjlj, throw_exception_cxx): Update.
3284         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3285         (all_cleanups, do_cleanups, discard_cleanups)
3286         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3287         (restore_cleanups, restore_final_cleanups): Don't declare.
3288         (do_final_cleanups): Remove parameter.
3289         * common/cleanups.c (cleanup_chain, make_cleanup)
3290         (make_cleanup_dtor, all_cleanups, do_cleanups)
3291         (discard_my_cleanups, discard_cleanups)
3292         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3293         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3294         (null_cleanup): Remove.
3295         (do_final_cleanups): Remove parameter.
3296
3297 2019-03-06  Tom Tromey  <tom@tromey.com>
3298
3299         * remote.c (remote_target::remote_parse_stop_reply): Use
3300         unique_xmalloc_ptr.
3301
3302 2019-03-06  Tom Tromey  <tom@tromey.com>
3303
3304         * stabsread.c (struct stabs_field_info): Rename from field_info.
3305         <list, fnlist>: Add initializers.
3306         <obstack>: New member.
3307         (read_member_functions, read_struct_fields, read_baseclasses):
3308         Allocate on obstack.  Don't use cleanups.
3309         (read_one_struct_field, read_member_functions, read_struct_fields)
3310         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3311         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3312         (read_struct_type): Update.
3313
3314 2019-03-06  Tom Tromey  <tom@tromey.com>
3315
3316         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3317         * common/filestuff.h (make_cleanup_close): Don't declare.
3318         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3319         Remove.
3320
3321 2019-03-06  Tom Tromey  <tom@tromey.com>
3322
3323         * solib-aix.c: Use make_scope_exit.
3324
3325 2019-03-06  Tom Tromey  <tom@tromey.com>
3326
3327         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3328         Use make_scope_exit.
3329
3330 2019-03-06  Tom Tromey  <tom@tromey.com>
3331
3332         * solib-svr4.c (disable_probes_interface): Remove parameter.
3333         (svr4_handle_solib_event): Use make_scope_exit.
3334
3335 2019-03-06  Tom Tromey  <tom@tromey.com>
3336
3337         * remote.c (struct stop_reply_deleter): Remove.
3338         (stop_reply_up): Update.
3339         (struct stop_reply): Derive from notif_event.  Don't typedef.
3340         <regcache>: Now a std::vector.
3341         (stop_reply_xfree): Remove.
3342         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3343         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3344         (remote_target::discard_pending_stop_replies): Use delete.
3345         (remote_target::remote_parse_stop_reply): Update.
3346         (remote_target::process_stop_reply): Update.
3347         * remote-notif.h (struct notif_event): Add virtual destructor.
3348         Remove "dtr" member.
3349         (struct notif_client) <alloc_event>: Return a unique_ptr.
3350         (notif_event_xfree): Don't declare.
3351         (notif_event_up): New typedef.
3352         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3353         (notif_event_xfree, do_notif_event_xfree): Remove.
3354         (remote_notif_state_xfree): Update.
3355
3356 2019-03-06  Tom Tromey  <tom@tromey.com>
3357
3358         * infrun.c (displaced_step_clear_cleanup): Now a
3359         forward_scope_exit type.
3360         (displaced_step_prepare_throw): Update.
3361         (displaced_step_fixup): Update.
3362
3363 2019-03-06  Tom Tromey  <tom@tromey.com>
3364
3365         * inferior.h (class inferior): Update comment.
3366         * gdbthread.h (class thread_info): Update comment.
3367
3368 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3369             Tom Tromey  <tom@tromey.com>
3370
3371         * stabsread.h (struct stab_section_list): Remove.
3372         (coffstab_build_psymtabs): Update.
3373         * dbxread.c (symbuf_sections): Now a std::vector.
3374         (sect_idx): New global.
3375         (fill_symbuf): Update.
3376         (coffstab_build_psymtabs): Change type of stabsects parameter.
3377         Update.
3378         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3379         std::vector.
3380         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3381         (coff_locate_sections): Update.
3382         (coff_symfile_read): Remove cleanups.  Update.
3383         (init_stringtab): Add storage parameter.
3384         (free_stringtab, free_stringtab_cleanup): Remove.
3385         (init_lineno): Add storage parameter.
3386         (free_linetab, free_linetab_cleanup): Remove.
3387
3388 2019-03-06  Pedro Alves  <palves@redhat.com>
3389
3390         * linux-fork.c (fork_info::clobber_regs): Delete.
3391         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3392         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3393         comment.  Adjust.
3394         (scoped_switch_fork_info::scoped_switch_fork_info)
3395         (checkpoint_command, linux_fork_context): Adjust
3396         fork_save_infrun_state calls.
3397
3398 2019-03-06  Pedro Alves  <palves@redhat.com>
3399
3400         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3401         (inf_has_multiple_threads): Return 'bool' and rewrite using
3402         inferior_info::threads().
3403
3404 2019-03-06  Pedro Alves  <palves@redhat.com>
3405
3406         * linux-fork.c: Include <list>.
3407         (fork_list): Now a std::list instance.
3408         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3409         (forks_exist_p, find_last_fork): Adjust.
3410         (new_fork): Delete.
3411         (one_fork_p): New.
3412         (add_fork): Adjust.
3413         (free_fork): Delete, folded into fork_info::~fork_info().
3414         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3415         Adjust.
3416         (init_fork_list): Delete.
3417         (linux_fork_killall, linux_fork_mourn_inferior)
3418         (linux_fork_detach, info_checkpoints_command): Adjust.
3419         (_initialize_linux_fork): No longer call init_fork_list.
3420
3421 2019-03-06  Pedro Alves  <palves@redhat.com>
3422
3423         * linux-fork.c (new_fork): New, split out of ...
3424         (add_fork): ... this.  Return void.  Move "first fork" special
3425         case from here, to ...
3426         (checkpoint_command): ... here.
3427         * linux-linux.h (add_fork): Return void.
3428
3429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3432
3433 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3434             Chris January  <chris.january@arm.com>
3435             David Lecomber  <david.lecomber@arm.com>
3436
3437         * f-exp.y: New token, UNOP_INTRINSIC.
3438         (exp): New pattern using UNOP_INTRINSIC token.
3439         (f77_keywords): Add 'abs' keyword.
3440         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3441         (value_from_host_double): New function.
3442         (evaluate_subexp_f): Support UNOP_ABS.
3443
3444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3447         types.
3448
3449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3450
3451         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3452         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3453         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3454
3455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3458
3459 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3460             Chris January  <chris.january@arm.com>
3461
3462         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3463         * f-exp.y: Define 'KIND' token.
3464         (exp): New pattern for KIND expressions.
3465         (ptype): Handle types with a kind extension.
3466         (direct_abs_decl): Extend to spot kind extensions.
3467         (f77_keywords): Add 'kind' to the list.
3468         (push_kind_type): New function.
3469         (convert_to_kind_type): New function.
3470         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3471         * parse.c (operator_length_standard): Likewise.
3472         * parser-defs.h (enum type_pieces): Add tp_kind.
3473         * std-operator.def: Add UNOP_KIND.
3474
3475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * f-exp.y (f_parse): Set yydebug.
3478
3479 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * f-lang.c (evaluate_subexp_f): New function.
3482         (exp_descriptor_f): New global.
3483         (f_language_defn): Use exp_descriptor_f instead of
3484         exp_descriptor_standard.
3485
3486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3487
3488         * f-exp.y (struct token): Add comments.
3489         (dot_ops): Remove uppercase versions and the end marker.
3490         (f77_keywords): Likewise.
3491         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3492         entries in the dot_ops array are case insensitive, and use
3493         strncasecmp to compare strings.  Also some whitespace cleanup in
3494         this area.  Similar for the f77_keywords array, except entries in
3495         this list might be case sensitive.
3496
3497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * f-exp.y (struct f77_boolean_val): Add comments.
3500         (boolean_values): Remove uppercase versions, and end marker.
3501         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3502         and use strncasecmp to achieve case insensitivity.  Additionally,
3503         perform whitespace cleanup around this code.
3504
3505 2019-03-06  Tom Tromey  <tromey@adacore.com>
3506
3507         * remote-sim.c (gdbsim_target_open): Use result of
3508         gdb_argv::release.
3509
3510 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3511         Dirk Schubert  <dirk.schubert@arm.com>
3512         Chris January  <chris.january@arm.com>
3513
3514         * eval.c (evaluate_subexp_standard): Call Fortran argument
3515         wrapping logic.
3516         * f-lang.c (struct value): A value which can be passed into a
3517         Fortran function call.
3518         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3519         where appropriate.
3520         (struct type): Value ready for a Fortran function call.
3521         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3522         is needed.
3523         * f-lang.h (fortran_argument_convert): Declaration.
3524         (fortran_preserve_arg_pointer): Declaration.
3525         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3526
3527 2019-03-05  Tom Tromey  <tromey@adacore.com>
3528
3529         * python/py-prettyprint.c (print_string_repr): Remove #if.
3530         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3531
3532 2019-03-05  Tom Tromey  <tromey@adacore.com>
3533
3534         * target.c (the_dummy_target): Move later.  Change type to
3535         "dummy_target".
3536         (initialize_targets): Don't initialize the_dummy_target.
3537
3538 2019-03-05  Tom Tromey  <tromey@adacore.com>
3539
3540         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3541         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3542
3543 2019-03-05  Tom Tromey  <tromey@adacore.com>
3544
3545         * windows-nat.c (windows_nat_target::attach)
3546         (windows_nat_target::detach): Don't call gdb_flush.
3547         * valprint.c (generic_val_print, val_print, val_print_string):
3548         Don't call gdb_flush.
3549         * utils.c (defaulted_query): Don't call gdb_flush.
3550         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3551         * target.c (target_announce_detach): Don't call gdb_flush.
3552         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3553         * remote.c (extended_remote_target::attach): Don't call
3554         gdb_flush.
3555         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3556         * printcmd.c (do_examine): Don't call gdb_flush.
3557         (info_display_command): Don't call gdb_flush.
3558         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3559         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3560         * memattr.c (info_mem_command): Don't call gdb_flush.
3561         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3562         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3563         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3564         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3565         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3566         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3567         (gnu_nat_target::detach): Don't call gdb_flush.
3568         * f-valprint.c (f_val_print): Don't call gdb_flush.
3569         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3570         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3571         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3572         gdb_flush.
3573         * c-valprint.c (c_val_print): Don't call gdb_flush.
3574         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3575
3576 2019-03-05  Tom Tromey  <tromey@adacore.com>
3577
3578         * varobj.c (update_dynamic_varobj_children): Update.
3579         (install_default_visualizer): Use reset, not release.
3580         * value.c (set_internalvar): Update.
3581         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3582         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3583         ATTRIBUTE_UNUSED_RESULT.
3584
3585 2019-03-05  Tom Tromey  <tromey@adacore.com>
3586
3587         * remote.c (class scoped_remote_fd) <release>: Add
3588         ATTRIBUTE_UNUSED_RESULT.
3589
3590 2019-03-05  Tom Tromey  <tromey@adacore.com>
3591
3592         * macroexp.c (struct macro_buffer) <release>: Add
3593         ATTRIBUTE_UNUSED_RESULT.
3594
3595 2019-03-05  Tom Tromey  <tromey@adacore.com>
3596
3597         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3598         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3599         ATTRIBUTE_UNUSED_RESULT.
3600
3601 2019-03-05  Tom Tromey  <tromey@adacore.com>
3602
3603         * common/scoped_fd.h (class scoped_fd) <release>: Add
3604         ATTRIBUTE_UNUSED_RESULT.
3605
3606 2019-03-05  Tom Tromey  <tromey@adacore.com>
3607
3608         * parser-defs.h (struct parser_state) <release>: Add
3609         ATTRIBUTE_UNUSED_RESULT.
3610
3611 2019-03-05  Tom Tromey  <tromey@adacore.com>
3612
3613         * utils.h (class gdb_argv) <release>: Add
3614         ATTRIBUTE_UNUSED_RESULT.
3615         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3616
3617 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3618
3619         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3620         for-loop range, to avoid compiler warnings.
3621
3622         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3623         avoid compiler warnings about unused variables.
3624
3625         * NEWS: Mention end of support for native debugging on MS-Windows
3626         before XP.
3627
3628         PR gdb/24292
3629         * common/netstuff.c:
3630         * gdbserver/gdbreplay.c
3631         * gdbserver/remote-utils.c:
3632         * ser-tcp.c:
3633         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3634         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3635         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3636         'getaddrinfo' and 'freeaddrinfo' were not available before
3637         Windows XP, and mingw.org's MinGW headers by default define
3638         _WIN32_WINNT to 0x500.
3639
3640 2019-03-01  Gary Benson <gbenson@redhat.com>
3641
3642         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3643
3644 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3645             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3646
3647         PR gdb/8527
3648         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3649         set_sigint_trap, clear_sigint_trap.
3650
3651 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3652
3653         * target.c (target_detach): Clear the regcache and the
3654         frame cache.
3655
3656 2019-02-27  Pedro Alves  <palves@redhat.com>
3657
3658         * utils.c (set_screen_size): When we cap the height/width sizes,
3659         tweak the corresponding command variable to show "unlimited":
3660
3661 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3662             Pedro Alves  <palves@redhat.com>
3663
3664         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3665         before calling rl_set_screen_size.
3666
3667 2019-02-27  Tom Tromey  <tromey@adacore.com>
3668
3669         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3670         define.
3671         * python/py-value.c: Remove Python 2.4 workaround.
3672         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3673         workaround.
3674         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3675         Python 2.4 workaround.
3676         * python/python-internal.h: Remove Python 2.4 comment.
3677         (Py_ssize_t): Don't define.
3678         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3679         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3680         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3681         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3682         * python/python.c (do_start_initialization): Remove Python 2.4
3683         workaround.
3684         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3685         (print_children): Remove Python 2.4 workaround.
3686         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3687         workaround.
3688         (CHARBUFFERPROC_NAME): Remove.
3689         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3690         Python 2.4 workaround.
3691
3692 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3693
3694         * NEWS: Note minimum Python version.
3695
3696 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3697
3698         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3699         code from these functions.  Remove corresponding ifdefs.  Use
3700         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3701         Remove gotos and target of gotos.
3702         (infpy_search_memory): Likewise.
3703
3704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3707         (hppa_gdbarch_init): Don't register deleted functions with
3708         gdbarch.
3709
3710 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3713         (h8300_unwind_sp): Delete.
3714         (h8300_dummy_id): Delete.
3715         (h8300_gdbarch_init): Don't register deleted functions with
3716         gdbarch.
3717
3718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3721         (ft32_unwind_pc): Delete.
3722         (ft32_unwind_sp): Delete.
3723         (ft32_gdbarch_init): Don't register deleted functions with
3724         gdbarch.
3725
3726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3729         (frv_unwind_pc): Delete.
3730         (frv_unwind_sp): Delete.
3731         (frv_gdbarch_init): Don't register deleted functions with
3732         gdbarch.
3733
3734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3737         (riscv_unwind_pc): Delete.
3738         (riscv_unwind_sp): Delete.
3739         (riscv_gdbarch_init): Don't register deleted functions with
3740         gdbarch.
3741
3742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3745         (csky_unwind_pc): Delete.
3746         (csky_unwind_sp): Delete.
3747         (csky_gdbarch_init): Don't register deleted functions with
3748         gdbarch.
3749
3750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3753         (cris_unwind_pc): Delete.
3754         (cris_unwind_sp): Delete.
3755         (cris_gdbarch_init): Don't register deleted functions with
3756         gdbarch.
3757
3758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3761         (bfin_unwind_pc): Delete.
3762         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3763
3764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3767         (arm_unwind_pc): Delete.
3768         (arm_unwind_sp): Delete.
3769         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3770
3771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3774         (arc_unwind_pc): Delete.
3775         (arc_unwind_sp): Delete.
3776         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3777
3778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3781         (alpha_unwind_pc): Delete.
3782         (alpha_gdbarch_init): Don't register deleted functions with
3783         gdbarch.
3784
3785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3786
3787         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3788         (aarch64_unwind_pc): Delete.
3789         (aarch64_unwind_sp): Delete.
3790         (aarch64_gdbarch_init): Don't register deleted functions with
3791         gdbarch.
3792
3793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * gdbtypes.c (type_align): Don't consider static members when
3796         computing structure alignment.
3797
3798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3801         return 0 for other types.
3802         * arch-utils.c (default_type_align): Always return 0.
3803         * gdbarch.h: Regenerate.
3804         * gdbarch.sh (type_align): Extend comment.
3805         * gdbtypes.c (type_align): Add additional comments, always call
3806         gdbarch_type_align before applying the default rules.
3807         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3808         generic code will then apply a suitable default.
3809         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3810         types, return 0 for other types.
3811
3812 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3813
3814         * NEWS: Create a new section for the next release branch.
3815         Rename the section of the current branch, now that it has
3816         been cut.
3817
3818 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3819
3820         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3821         * version.in: Bump version to 8.3.50.DATE-git.
3822
3823 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3824
3825         * aix-thread.c (ptid_cmp): Remove unused variable.
3826         (get_signaled_thread): Likewise.
3827         (store_regs_user_thread): Likewise.
3828         (store_regs_kernel_thread): Likewise.
3829         (fetch_regs_kernel_thread): Remove shadowed variable.
3830
3831 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * features/riscv/32bit-cpu.xml: Add register numbers.
3834         * features/riscv/32bit-fpu.c: Regenerate.
3835         * features/riscv/32bit-fpu.xml: Add register numbers.
3836         * features/riscv/64bit-cpu.xml: Add register numbers.
3837         * features/riscv/64bit-fpu.c: Regenerate.
3838         * features/riscv/64bit-fpu.xml: Add register numbers.
3839
3840 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3841
3842         * NEWS: Mention two argument form of gdb.Value constructor.
3843         * python/py-value.c (convert_buffer_and_type_to_value): New
3844         function.
3845         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3846         Add support for handling an optional second argument.  Call
3847         convert_buffer_and_type_to_value as appropriate.
3848         * python/python-internal.h (Py_buffer_deleter): New struct.
3849         (Py_buffer_up): New typedef.
3850
3851 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3852
3853         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3854         instead of releasing ownership.
3855
3856 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3857
3858         * dwarf2read.c (open_and_init_dwp_file): Call
3859         elf_numsections instead of bfd_count_sections to initialize
3860         dwp_file->num_sections.
3861
3862 2019-02-25  Tom Tromey  <tromey@adacore.com>
3863
3864         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3865
3866 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3867
3868         * gcore.in: Add '--readnever' option when invoking GDB.
3869
3870 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3871
3872         * MAINTAINERS: Update my email address.
3873
3874 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3875
3876         * build-id.c (build_id_to_debug_bfd_1): New function.
3877         (build_id_to_debug_bfd): Look for separate debug file in
3878         sysroot.
3879
3880 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * gdbarch.sh: Update the copyright year range that is placed into
3883         generated files.
3884
3885 2019-02-22  Keith Seitz  <keiths@redhat.com>
3886
3887         PR symtab/23853
3888         * linespec.c (create_sals_line_offset): Search for the default
3889         symtab's filename instead of its fullname.
3890
3891 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3892
3893         * NEWS: Update style defaults.
3894
3895 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3896
3897         * main.c (captured_main_1): Disable styling in batch mode.
3898
3899 2019-02-20  Tom Tromey  <tom@tromey.com>
3900
3901         * symtab.c (symtab_symbol_info): Fix typos.
3902
3903 2019-02-20  Tom Tromey  <tromey@adacore.com>
3904
3905         * findcmd.c (_initialize_mem_search): Use upper case for
3906         metasyntactic variables.
3907
3908 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3909
3910         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3911         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3912
3913 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         * top.h (source_file_name): Change to std::string.
3916         * top.c (source_file_name): Likewise.
3917         (command_line_input): Adjust.
3918         * cli/cli-script.c (script_from_file): Adjust.
3919
3920 2019-02-19  Tom Tromey  <tromey@adacore.com>
3921
3922         * ravenscar-thread.c
3923         (ravenscar_thread_target::update_thread_list): Don't call
3924         ada_build_task_list.
3925         * ada-lang.h (ada_build_task_list): Don't declare.
3926         * ada-tasks.c (struct ada_tasks_inferior_data)
3927         <task_list_valid_p>: Now bool.
3928         (read_known_tasks, ada_task_list_changed)
3929         (ada_tasks_invalidate_inferior_data): Update.
3930         (read_known_tasks_array): Return bool.
3931         (read_known_tasks_list): Likewise.
3932         (read_known_tasks): Return void.
3933         (ada_build_task_list): Now static.
3934
3935 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3938         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3939
3940 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3941
3942         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3943         variant for ada_tasks_pspace_data_handle and
3944         ada_tasks_inferior_data_handle.
3945         (ada_tasks_pspace_data_cleanup): New function.
3946         (ada_tasks_inferior_data_cleanup): New function.
3947
3948 2019-02-17  Tom Tromey  <tom@tromey.com>
3949
3950         * macrotab.h (macro_source_fullname): Return a std::string.
3951         * macrotab.c (macro_include, check_for_redefinition)
3952         (macro_undef, macro_lookup_definition, foreach_macro)
3953         (foreach_macro_in_scope): Update.
3954         (macro_source_fullname): Return a std::string.
3955         * macrocmd.c (show_pp_source_pos): Update.
3956
3957 2019-02-17  Tom Tromey  <tom@tromey.com>
3958
3959         * macrocmd.c (show_pp_source_pos): Style the file names.
3960
3961 2019-02-17  Tom Tromey  <tom@tromey.com>
3962
3963         PR tui/24197:
3964         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3965
3966 2019-02-17  Tom Tromey  <tom@tromey.com>
3967
3968         * ada-lang.c (user_select_syms): Use filtered printing.
3969         * utils.c (wrap_style): New global.
3970         (desired_style): Remove.
3971         (emit_style_escape): Add stream parameter.
3972         (set_output_style, reset_terminal_style, prompt_for_continue):
3973         Update.
3974         (flush_wrap_buffer): Only flush gdb_stdout.
3975         (wrap_here): Set wrap_style.
3976         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3977         treat escape sequences as a character.  Change when wrap buffer is
3978         flushed.
3979         (fputs_styled): Do not set the output style when the default is
3980         requested.
3981         * ui-style.h (struct ui_file_style) <is_default>: New method.
3982         * source.c (print_source_lines_base): Emit escape sequences in one
3983         piece.
3984
3985 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3986
3987         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3988         integers and enumeration types.
3989
3990 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3991
3992         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3993         instead of lookup_symbol_in_language
3994         (do_exact_match): New function.
3995         (ada_get_symbol_name_matcher): Return do_exact_match when
3996         doing a verbatim match.
3997
3998 2019-02-15  Tom Tromey  <tromey@adacore.com>
3999
4000         * ravenscar-thread.c (ravenscar_thread_target::resume)
4001         (ravenscar_thread_target::wait): Special case wildcard requests.
4002
4003 2019-02-15  Tom Tromey  <tromey@adacore.com>
4004
4005         * ravenscar-thread.c (base_ptid): Remove.
4006         (struct ravenscar_thread_target) <close>: New method.
4007         <m_base_ptid>: New member.
4008         <update_inferior_ptid, active_task, task_is_currently_active,
4009         runtime_initialized>: Declare methods.
4010         <ravenscar_thread_target>: Add constructor.
4011         (ravenscar_thread_target::task_is_currently_active)
4012         (ravenscar_thread_target::update_inferior_ptid)
4013         (ravenscar_runtime_initialized): Rename.  Now methods.
4014         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4015         (ravenscar_thread_target::update_thread_list): Update.
4016         (ravenscar_thread_target::active_task): Now method.
4017         (ravenscar_thread_target::store_registers)
4018         (ravenscar_thread_target::prepare_to_store)
4019         (ravenscar_thread_target::prepare_to_store)
4020         (ravenscar_thread_target::mourn_inferior): Update.
4021         (ravenscar_inferior_created): Use "new" to create target.
4022         (ravenscar_thread_target::get_ada_task_ptid): Update.
4023         (_initialize_ravenscar): Don't initialize base_ptid.
4024         (ravenscar_ops): Remove global.
4025
4026 2019-02-15  Tom Tromey  <tromey@adacore.com>
4027
4028         * target.h (push_target): Declare new overload.
4029         * target.c (push_target): New overload, taking an rvalue reference.
4030         * remote.c (remote_target::open_1): Use push_target overload.
4031         * corelow.c (core_target_open): Use push_target overload.
4032
4033 2019-02-15  Tom Tromey  <tromey@adacore.com>
4034
4035         * ravenscar-thread.c (is_ravenscar_task)
4036         (ravenscar_task_is_currently_active): Return bool.
4037         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4038         (_initialize_ravenscar): Remove "(void)".
4039         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4040         Return bool.
4041
4042 2019-02-15  Tom Tromey  <tromey@adacore.com>
4043
4044         * ravenscar-thread.c (ravenscar_runtime_initializer)
4045         (has_ravenscar_runtime, get_running_thread_id)
4046         (ravenscar_thread_target::resume): Fix indentation.
4047
4048 2019-02-15  Tom Tromey  <tromey@adacore.com>
4049
4050         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4051         from ravenscar_arch_ops.
4052         (sparc_ravenscar_ops::fetch_registers)
4053         (sparc_ravenscar_ops::store_registers): Now methods.
4054         (sparc_ravenscar_prepare_to_store): Remove.
4055         (sparc_ravenscar_ops): Redefine.
4056         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4057         methods and destructor.  Remove members.
4058         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4059         (ravenscar_thread_target::store_registers)
4060         (ravenscar_thread_target::prepare_to_store): Update.
4061         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4062         Remove.
4063         (struct ppc_ravenscar_powerpc_ops): Derive from
4064         ravenscar_arch_ops.
4065         (ppc_ravenscar_powerpc_ops::fetch_registers)
4066         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4067         (ppc_ravenscar_powerpc_ops): Redefine.
4068         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4069         (ppc_ravenscar_e500_ops::fetch_registers)
4070         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4071         (ppc_ravenscar_e500_ops): Redefine.
4072         * aarch64-ravenscar-thread.c
4073         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4074         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4075         (aarch64_ravenscar_fetch_registers)
4076         (aarch64_ravenscar_store_registers): Now methods.
4077         (aarch64_ravenscar_ops): Redefine.
4078
4079 2019-02-15  Tom Tromey  <tromey@adacore.com>
4080
4081         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4082         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4083         (ravenscar_thread_target::stopped_by_watchpoint)
4084         (ravenscar_thread_target::stopped_data_address)
4085         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4086
4087 2019-02-15  Tom Tromey  <tromey@adacore.com>
4088
4089         * ravenscar-thread.c: Fix some typos.
4090
4091 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4092             Tom Tromey  <tromey@adacore.com>
4093
4094         * ada-lang.c (ada_exception_sal): Change addr_string to a
4095         std::string.
4096         (create_ada_exception_catchpoint): Update.
4097
4098 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4099             Tom Tromey  <tromey@adacore.com>
4100
4101         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4102         (bp_location_ops): Remove.
4103         (base_breakpoint_allocate_location): Update.
4104         (free_bp_location): Update.
4105         * ada-lang.c (class ada_catchpoint_location)
4106         <ada_catchpoint_location>: Remove ops parameter.
4107         (ada_catchpoint_location_dtor): Remove.
4108         (ada_catchpoint_location_ops): Remove.
4109         (allocate_location_exception): Update.
4110         * breakpoint.h (struct bp_location_ops): Remove.
4111         (class bp_location) <bp_location>: Remove bp_location_ops
4112         parameter.
4113         <~bp_location>: Add destructor.
4114         <ops>: Remove.
4115
4116 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4117             Pedro Alves  <palves@redhat.com>
4118
4119         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4120         'PATH_MAX'.
4121
4122 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4123             Samuel Thibault  <samuel.thibault@gnu.org>
4124             Thomas Schwinge  <thomas@codesourcery.com>
4125
4126         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4127         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4128
4129 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4130
4131         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4132         (check_empty): Use "const char *".
4133
4134         * gnu-nat.c (gnu_nat_target::detach): Instead of
4135         'detach_inferior (pid)' call
4136         'detach_inferior (find_inferior_pid (pid))'.
4137
4138         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4139         'nat/fork-inferior.o'.
4140         * gnu-nat.c: #include "nat/fork-inferior.h".
4141
4142         * gnu-nat.c (gnu_nat_target::detach): Instead of
4143         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4144         * gnu-nat.h: #include "inf-child.h".
4145         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4146         'i386_gnu_nat_target::fetch_registers'.
4147         (gnu_store_registers): Rename/move to
4148         'i386_gnu_nat_target::store_registers'.
4149
4150         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4151         * gnu-nat.h (mach_thread_info): New function.
4152         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4153
4154         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4155
4156 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4157
4158         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4159
4160 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4161
4162         * windows-nat.c (windows_add_thread): Add new parameter
4163         "main_thread_p" with default value set to false.  Update
4164         function documentation as well as all callers.
4165         (windows_delete_thread): Likewise.
4166         (fake_create_process): Update call to windows_add_thread.
4167         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4168         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4169         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4170         call to windows_delete_thread.
4171
4172 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4173
4174         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4175
4176 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4177
4178         * symfile.c (find_separate_debug_file): Use canonical path of
4179         sysroot with child_path instead of gdb_sysroot if it is valid.
4180
4181 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4182
4183         * symfile.c (find_separate_debug_file): Use child_path to
4184         determine if an object file is under a sysroot.
4185
4186 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4187
4188         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4189         unittests/child-path-selftests.c.
4190         * common/pathstuff.c (child_path): New function.
4191         * common/pathstuff.h (child_path): New prototype.
4192         * unittests/child-path-selftests.c: New file.
4193
4194 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4195
4196         * symfile.c (find_separate_debug_file): Look for separate debug
4197         files in debug directories under the sysroot.
4198
4199 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4200
4201         * symtab.h (struct minimal_symbol data_p): New const method.
4202         (struct minimal_symbol text_p): Likewise.
4203         * symtab.c (output_source_filename): Use file name style
4204         to print file name.
4205         (print_symbol_info): Likewise.
4206         (print_msymbol_info): Use address style to print addresses.
4207         Use function name style to print executable text symbols.
4208         (expand_symtab_containing_pc): Use data_p.
4209         (find_pc_sect_compunit_symtab): Likewise.
4210
4211 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4212
4213         * breakpoint.c (describe_other_breakpoints): Use address style
4214         to print addresses.
4215         (say_where): Likewise.
4216
4217 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4218
4219         * ada-typeprint.c (print_func_type): Print function name
4220         style to print function name.
4221         * c-typeprint.c (c_print_type_1): Likewise.
4222
4223 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4224
4225         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4226         for execve.
4227
4228 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4229
4230         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4231         type_stack.
4232
4233 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4234
4235         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4236         TYPE_CODE_REF types.
4237
4238 2019-02-08  Jim Wilson  <jimw@sifive.com>
4239
4240         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4241         (riscv_linux_fregset): New.
4242         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4243
4244 2019-02-07  Tom Tromey  <tom@tromey.com>
4245
4246         * thread.c (thread_cancel_execution_command): Update.
4247         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4248         methods.
4249         (struct thread_fsm_ops): Remove.
4250         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4251         (thread_fsm_should_stop, thread_fsm_return_value)
4252         (thread_fsm_set_finished, thread_fsm_finished_p)
4253         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4254         Don't declare.
4255         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4256         * infrun.c (clear_proceed_status_thread)
4257         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4258         (print_stop_event): Update.
4259         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4260         Add constructor.
4261         (step_command_fsm_ops): Remove.
4262         (new_step_command_fsm): Remove.
4263         (step_1): Update.
4264         (step_command_fsm::should_stop): Rename from
4265         step_command_fsm_should_stop.
4266         (step_command_fsm::clean_up): Rename from
4267         step_command_fsm_clean_up.
4268         (step_command_fsm::do_async_reply_reason): Rename from
4269         step_command_fsm_async_reply_reason.
4270         (struct until_next_fsm): Inherit from thread_fsm.  Add
4271         constructor.
4272         (until_next_fsm_ops): Remove.
4273         (new_until_next_fsm): Remove.
4274         (until_next_fsm::should_stop): Rename from
4275         until_next_fsm_should_stop.
4276         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4277         (until_next_fsm::do_async_reply_reason): Rename from
4278         until_next_fsm_async_reply_reason.
4279         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4280         constructor.  Change type of breakpoint.
4281         (finish_command_fsm_ops): Remove.
4282         (new_finish_command_fsm): Remove.
4283         (finish_command_fsm::should_stop): Rename from
4284         finish_command_fsm_should_stop.
4285         (finish_command_fsm::clean_up): Rename from
4286         finish_command_fsm_clean_up.
4287         (finish_command_fsm::return_value): Rename from
4288         finish_command_fsm_return_value.
4289         (finish_command_fsm::do_async_reply_reason): Rename from
4290         finish_command_fsm_async_reply_reason.
4291         (finish_command): Update.
4292         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4293         Add constructor.
4294         (call_thread_fsm_ops): Remove.
4295         (call_thread_fsm::call_thread_fsm): Rename from
4296         new_call_thread_fsm.
4297         (call_thread_fsm::should_stop): Rename from
4298         call_thread_fsm_should_stop.
4299         (call_thread_fsm::should_notify_stop): Rename from
4300         call_thread_fsm_should_notify_stop.
4301         (run_inferior_call, call_function_by_hand_dummy): Update.
4302         * cli/cli-interp.c (should_print_stop_to_console): Update.
4303         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4304         Add constructor.  Change type of location_breakpoint,
4305         caller_breakpoint.
4306         (until_break_fsm_ops): Remove.
4307         (new_until_break_fsm): Remove.
4308         (until_break_fsm::should_stop): Rename from
4309         until_break_fsm_should_stop.
4310         (until_break_fsm::clean_up): Rename from
4311         until_break_fsm_clean_up.
4312         (until_break_fsm::do_async_reply_reason): Rename from
4313         until_break_fsm_async_reply_reason.
4314         (until_break_command): Update.
4315         * thread-fsm.c: Remove.
4316         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4317
4318 2019-02-07  Tom Tromey  <tom@tromey.com>
4319
4320         * yy-remap.h: Add include guard.
4321         * xtensa-tdep.h: Add include guard.
4322         * xcoffread.h: Rename include guard.
4323         * varobj-iter.h: Add include guard.
4324         * tui/tui.h: Rename include guard.
4325         * tui/tui-winsource.h: Rename include guard.
4326         * tui/tui-wingeneral.h: Rename include guard.
4327         * tui/tui-windata.h: Rename include guard.
4328         * tui/tui-win.h: Rename include guard.
4329         * tui/tui-stack.h: Rename include guard.
4330         * tui/tui-source.h: Rename include guard.
4331         * tui/tui-regs.h: Rename include guard.
4332         * tui/tui-out.h: Rename include guard.
4333         * tui/tui-layout.h: Rename include guard.
4334         * tui/tui-io.h: Rename include guard.
4335         * tui/tui-hooks.h: Rename include guard.
4336         * tui/tui-file.h: Rename include guard.
4337         * tui/tui-disasm.h: Rename include guard.
4338         * tui/tui-data.h: Rename include guard.
4339         * tui/tui-command.h: Rename include guard.
4340         * tic6x-tdep.h: Add include guard.
4341         * target/waitstatus.h: Rename include guard.
4342         * target/wait.h: Rename include guard.
4343         * target/target.h: Rename include guard.
4344         * target/resume.h: Rename include guard.
4345         * target-float.h: Rename include guard.
4346         * stabsread.h: Add include guard.
4347         * rs6000-tdep.h: Add include guard.
4348         * riscv-fbsd-tdep.h: Add include guard.
4349         * regformats/regdef.h: Rename include guard.
4350         * record.h: Rename include guard.
4351         * python/python.h: Rename include guard.
4352         * python/python-internal.h: Rename include guard.
4353         * python/py-stopevent.h: Rename include guard.
4354         * python/py-ref.h: Rename include guard.
4355         * python/py-record.h: Rename include guard.
4356         * python/py-record-full.h: Rename include guard.
4357         * python/py-record-btrace.h: Rename include guard.
4358         * python/py-instruction.h: Rename include guard.
4359         * python/py-events.h: Rename include guard.
4360         * python/py-event.h: Rename include guard.
4361         * procfs.h: Add include guard.
4362         * proc-utils.h: Add include guard.
4363         * p-lang.h: Add include guard.
4364         * or1k-tdep.h: Rename include guard.
4365         * observable.h: Rename include guard.
4366         * nto-tdep.h: Rename include guard.
4367         * nat/x86-linux.h: Rename include guard.
4368         * nat/x86-linux-dregs.h: Rename include guard.
4369         * nat/x86-gcc-cpuid.h: Add include guard.
4370         * nat/x86-dregs.h: Rename include guard.
4371         * nat/x86-cpuid.h: Rename include guard.
4372         * nat/ppc-linux.h: Rename include guard.
4373         * nat/mips-linux-watch.h: Rename include guard.
4374         * nat/linux-waitpid.h: Rename include guard.
4375         * nat/linux-ptrace.h: Rename include guard.
4376         * nat/linux-procfs.h: Rename include guard.
4377         * nat/linux-osdata.h: Rename include guard.
4378         * nat/linux-nat.h: Rename include guard.
4379         * nat/linux-namespaces.h: Rename include guard.
4380         * nat/linux-btrace.h: Rename include guard.
4381         * nat/glibc_thread_db.h: Rename include guard.
4382         * nat/gdb_thread_db.h: Rename include guard.
4383         * nat/gdb_ptrace.h: Rename include guard.
4384         * nat/fork-inferior.h: Rename include guard.
4385         * nat/amd64-linux-siginfo.h: Rename include guard.
4386         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4387         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4388         * nat/aarch64-linux.h: Rename include guard.
4389         * nat/aarch64-linux-hw-point.h: Rename include guard.
4390         * mn10300-tdep.h: Add include guard.
4391         * mips-linux-tdep.h: Add include guard.
4392         * mi/mi-parse.h: Rename include guard.
4393         * mi/mi-out.h: Rename include guard.
4394         * mi/mi-main.h: Rename include guard.
4395         * mi/mi-interp.h: Rename include guard.
4396         * mi/mi-getopt.h: Rename include guard.
4397         * mi/mi-console.h: Rename include guard.
4398         * mi/mi-common.h: Rename include guard.
4399         * mi/mi-cmds.h: Rename include guard.
4400         * mi/mi-cmd-break.h: Rename include guard.
4401         * m2-lang.h: Add include guard.
4402         * location.h: Rename include guard.
4403         * linux-record.h: Rename include guard.
4404         * linux-nat.h: Add include guard.
4405         * linux-fork.h: Add include guard.
4406         * i386-darwin-tdep.h: Rename include guard.
4407         * hppa-linux-offsets.h: Add include guard.
4408         * guile/guile.h: Rename include guard.
4409         * guile/guile-internal.h: Rename include guard.
4410         * gnu-nat.h: Rename include guard.
4411         * gdb-stabs.h: Rename include guard.
4412         * frv-tdep.h: Add include guard.
4413         * f-lang.h: Add include guard.
4414         * event-loop.h: Add include guard.
4415         * darwin-nat.h: Rename include guard.
4416         * cp-abi.h: Rename include guard.
4417         * config/sparc/nm-sol2.h: Rename include guard.
4418         * config/nm-nto.h: Rename include guard.
4419         * config/nm-linux.h: Add include guard.
4420         * config/i386/nm-i386gnu.h: Rename include guard.
4421         * config/djgpp/nl_types.h: Rename include guard.
4422         * config/djgpp/langinfo.h: Rename include guard.
4423         * compile/gcc-cp-plugin.h: Add include guard.
4424         * compile/gcc-c-plugin.h: Add include guard.
4425         * compile/compile.h: Rename include guard.
4426         * compile/compile-object-run.h: Rename include guard.
4427         * compile/compile-object-load.h: Rename include guard.
4428         * compile/compile-internal.h: Rename include guard.
4429         * compile/compile-cplus.h: Rename include guard.
4430         * compile/compile-c.h: Rename include guard.
4431         * common/xml-utils.h: Rename include guard.
4432         * common/x86-xstate.h: Rename include guard.
4433         * common/version.h: Rename include guard.
4434         * common/vec.h: Rename include guard.
4435         * common/tdesc.h: Rename include guard.
4436         * common/selftest.h: Rename include guard.
4437         * common/scoped_restore.h: Rename include guard.
4438         * common/scoped_mmap.h: Rename include guard.
4439         * common/scoped_fd.h: Rename include guard.
4440         * common/safe-iterator.h: Rename include guard.
4441         * common/run-time-clock.h: Rename include guard.
4442         * common/refcounted-object.h: Rename include guard.
4443         * common/queue.h: Rename include guard.
4444         * common/ptid.h: Rename include guard.
4445         * common/print-utils.h: Rename include guard.
4446         * common/preprocessor.h: Rename include guard.
4447         * common/pathstuff.h: Rename include guard.
4448         * common/observable.h: Rename include guard.
4449         * common/netstuff.h: Rename include guard.
4450         * common/job-control.h: Rename include guard.
4451         * common/host-defs.h: Rename include guard.
4452         * common/gdb_wait.h: Rename include guard.
4453         * common/gdb_vecs.h: Rename include guard.
4454         * common/gdb_unlinker.h: Rename include guard.
4455         * common/gdb_unique_ptr.h: Rename include guard.
4456         * common/gdb_tilde_expand.h: Rename include guard.
4457         * common/gdb_sys_time.h: Rename include guard.
4458         * common/gdb_string_view.h: Rename include guard.
4459         * common/gdb_splay_tree.h: Rename include guard.
4460         * common/gdb_setjmp.h: Rename include guard.
4461         * common/gdb_ref_ptr.h: Rename include guard.
4462         * common/gdb_optional.h: Rename include guard.
4463         * common/gdb_locale.h: Rename include guard.
4464         * common/gdb_assert.h: Rename include guard.
4465         * common/filtered-iterator.h: Rename include guard.
4466         * common/filestuff.h: Rename include guard.
4467         * common/fileio.h: Rename include guard.
4468         * common/environ.h: Rename include guard.
4469         * common/common-utils.h: Rename include guard.
4470         * common/common-types.h: Rename include guard.
4471         * common/common-regcache.h: Rename include guard.
4472         * common/common-inferior.h: Rename include guard.
4473         * common/common-gdbthread.h: Rename include guard.
4474         * common/common-exceptions.h: Rename include guard.
4475         * common/common-defs.h: Rename include guard.
4476         * common/common-debug.h: Rename include guard.
4477         * common/cleanups.h: Rename include guard.
4478         * common/buffer.h: Rename include guard.
4479         * common/btrace-common.h: Rename include guard.
4480         * common/break-common.h: Rename include guard.
4481         * cli/cli-utils.h: Rename include guard.
4482         * cli/cli-style.h: Rename include guard.
4483         * cli/cli-setshow.h: Rename include guard.
4484         * cli/cli-script.h: Rename include guard.
4485         * cli/cli-interp.h: Rename include guard.
4486         * cli/cli-decode.h: Rename include guard.
4487         * cli/cli-cmds.h: Rename include guard.
4488         * charset-list.h: Add include guard.
4489         * buildsym-legacy.h: Rename include guard.
4490         * bfin-tdep.h: Add include guard.
4491         * ax.h: Rename include guard.
4492         * arm-linux-tdep.h: Add include guard.
4493         * arm-fbsd-tdep.h: Add include guard.
4494         * arch/xtensa.h: Rename include guard.
4495         * arch/tic6x.h: Add include guard.
4496         * arch/i386.h: Add include guard.
4497         * arch/arm.h: Rename include guard.
4498         * arch/arm-linux.h: Rename include guard.
4499         * arch/arm-get-next-pcs.h: Rename include guard.
4500         * arch/amd64.h: Add include guard.
4501         * arch/aarch64-insn.h: Rename include guard.
4502         * arch-utils.h: Rename include guard.
4503         * annotate.h: Add include guard.
4504         * amd64-darwin-tdep.h: Rename include guard.
4505         * aarch64-linux-tdep.h: Add include guard.
4506         * aarch64-fbsd-tdep.h: Add include guard.
4507         * aarch32-linux-nat.h: Add include guard.
4508
4509 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4510
4511         * macrotab.c (macro_define_internal): New function that
4512         factorizes macro_define_object_internal and macro_define_function
4513         code.
4514         (macro_define_object_internal): Use macro_define_internal.
4515         (macro_define_function): Likewise.
4516
4517 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4518
4519         * macrocmd.c (extract_identifier): Return
4520         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4521         callers.
4522
4523 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4524
4525         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4526
4527 2019-02-05  Tom Tromey  <tom@tromey.com>
4528
4529         * target.c (target_stack::unpush): Move assertion earlier.
4530
4531 2019-01-30  Tom Tromey  <tom@tromey.com>
4532
4533         PR python/23615:
4534         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4535         (gdbpy_parse_and_eval): Likewise.
4536         * python/python-internal.h (gdbpy_allow_threads): New class.
4537
4538 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4539
4540         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4541         (aarch64_fbsd_fpregmap): Move earlier.
4542         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4543         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4544         instead of individual calls to trad_frame_set_reg_addr.
4545         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4546         earlier.
4547         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4548         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4549         instead of individual calls to trad_frame_set_reg_addr.
4550
4551 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4552
4553         * CONTRIBUTE: Replace contribution list with wiki link.
4554
4555 2019-01-25  Tom Tromey  <tom@tromey.com>
4556
4557         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4558
4559 2019-01-25  Tom Tromey  <tom@tromey.com>
4560
4561         * xtensa-linux-nat.c: Fix common/ includes.
4562         * xml-support.h: Fix common/ includes.
4563         * xml-support.c: Fix common/ includes.
4564         * x86-linux-nat.c: Fix common/ includes.
4565         * windows-nat.c: Fix common/ includes.
4566         * varobj.h: Fix common/ includes.
4567         * varobj.c: Fix common/ includes.
4568         * value.c: Fix common/ includes.
4569         * valops.c: Fix common/ includes.
4570         * utils.c: Fix common/ includes.
4571         * unittests/xml-utils-selftests.c: Fix common/ includes.
4572         * unittests/utils-selftests.c: Fix common/ includes.
4573         * unittests/unpack-selftests.c: Fix common/ includes.
4574         * unittests/tracepoint-selftests.c: Fix common/ includes.
4575         * unittests/style-selftests.c: Fix common/ includes.
4576         * unittests/string_view-selftests.c: Fix common/ includes.
4577         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4578         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4579         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4580         * unittests/rsp-low-selftests.c: Fix common/ includes.
4581         * unittests/parse-connection-spec-selftests.c: Fix common/
4582         includes.
4583         * unittests/optional-selftests.c: Fix common/ includes.
4584         * unittests/offset-type-selftests.c: Fix common/ includes.
4585         * unittests/observable-selftests.c: Fix common/ includes.
4586         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4587         * unittests/memrange-selftests.c: Fix common/ includes.
4588         * unittests/memory-map-selftests.c: Fix common/ includes.
4589         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4590         * unittests/function-view-selftests.c: Fix common/ includes.
4591         * unittests/environ-selftests.c: Fix common/ includes.
4592         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4593         * unittests/common-utils-selftests.c: Fix common/ includes.
4594         * unittests/cli-utils-selftests.c: Fix common/ includes.
4595         * unittests/array-view-selftests.c: Fix common/ includes.
4596         * ui-file.c: Fix common/ includes.
4597         * tui/tui-io.c: Fix common/ includes.
4598         * tracepoint.h: Fix common/ includes.
4599         * tracepoint.c: Fix common/ includes.
4600         * tracefile-tfile.c: Fix common/ includes.
4601         * top.h: Fix common/ includes.
4602         * top.c: Fix common/ includes.
4603         * thread.c: Fix common/ includes.
4604         * target/waitstatus.h: Fix common/ includes.
4605         * target/waitstatus.c: Fix common/ includes.
4606         * target.h: Fix common/ includes.
4607         * target.c: Fix common/ includes.
4608         * target-memory.c: Fix common/ includes.
4609         * target-descriptions.c: Fix common/ includes.
4610         * symtab.h: Fix common/ includes.
4611         * symfile.c: Fix common/ includes.
4612         * stap-probe.c: Fix common/ includes.
4613         * spu-linux-nat.c: Fix common/ includes.
4614         * sparc-nat.c: Fix common/ includes.
4615         * source.c: Fix common/ includes.
4616         * solib.c: Fix common/ includes.
4617         * solib-target.c: Fix common/ includes.
4618         * ser-unix.c: Fix common/ includes.
4619         * ser-tcp.c: Fix common/ includes.
4620         * ser-pipe.c: Fix common/ includes.
4621         * ser-base.c: Fix common/ includes.
4622         * selftest-arch.c: Fix common/ includes.
4623         * s12z-tdep.c: Fix common/ includes.
4624         * rust-exp.y: Fix common/ includes.
4625         * rs6000-aix-tdep.c: Fix common/ includes.
4626         * riscv-tdep.c: Fix common/ includes.
4627         * remote.c: Fix common/ includes.
4628         * remote-notif.h: Fix common/ includes.
4629         * remote-fileio.h: Fix common/ includes.
4630         * remote-fileio.c: Fix common/ includes.
4631         * regcache.h: Fix common/ includes.
4632         * regcache.c: Fix common/ includes.
4633         * record-btrace.c: Fix common/ includes.
4634         * python/python.c: Fix common/ includes.
4635         * python/py-type.c: Fix common/ includes.
4636         * python/py-inferior.c: Fix common/ includes.
4637         * progspace.h: Fix common/ includes.
4638         * producer.c: Fix common/ includes.
4639         * procfs.c: Fix common/ includes.
4640         * proc-api.c: Fix common/ includes.
4641         * printcmd.c: Fix common/ includes.
4642         * ppc-linux-nat.c: Fix common/ includes.
4643         * parser-defs.h: Fix common/ includes.
4644         * osdata.c: Fix common/ includes.
4645         * obsd-nat.c: Fix common/ includes.
4646         * nat/x86-linux.c: Fix common/ includes.
4647         * nat/x86-linux-dregs.c: Fix common/ includes.
4648         * nat/x86-dregs.h: Fix common/ includes.
4649         * nat/x86-dregs.c: Fix common/ includes.
4650         * nat/ppc-linux.c: Fix common/ includes.
4651         * nat/mips-linux-watch.h: Fix common/ includes.
4652         * nat/mips-linux-watch.c: Fix common/ includes.
4653         * nat/linux-waitpid.c: Fix common/ includes.
4654         * nat/linux-ptrace.h: Fix common/ includes.
4655         * nat/linux-ptrace.c: Fix common/ includes.
4656         * nat/linux-procfs.c: Fix common/ includes.
4657         * nat/linux-personality.c: Fix common/ includes.
4658         * nat/linux-osdata.c: Fix common/ includes.
4659         * nat/linux-namespaces.c: Fix common/ includes.
4660         * nat/linux-btrace.h: Fix common/ includes.
4661         * nat/linux-btrace.c: Fix common/ includes.
4662         * nat/fork-inferior.c: Fix common/ includes.
4663         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4664         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4665         * nat/aarch64-linux.c: Fix common/ includes.
4666         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4667         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4668         * namespace.h: Fix common/ includes.
4669         * mips-linux-tdep.c: Fix common/ includes.
4670         * minsyms.c: Fix common/ includes.
4671         * mi/mi-parse.h: Fix common/ includes.
4672         * mi/mi-main.c: Fix common/ includes.
4673         * mi/mi-cmd-env.c: Fix common/ includes.
4674         * memrange.h: Fix common/ includes.
4675         * memattr.c: Fix common/ includes.
4676         * maint.h: Fix common/ includes.
4677         * maint.c: Fix common/ includes.
4678         * main.c: Fix common/ includes.
4679         * machoread.c: Fix common/ includes.
4680         * location.c: Fix common/ includes.
4681         * linux-thread-db.c: Fix common/ includes.
4682         * linux-nat.c: Fix common/ includes.
4683         * linux-fork.c: Fix common/ includes.
4684         * inline-frame.c: Fix common/ includes.
4685         * infrun.c: Fix common/ includes.
4686         * inflow.c: Fix common/ includes.
4687         * inferior.h: Fix common/ includes.
4688         * inferior.c: Fix common/ includes.
4689         * infcmd.c: Fix common/ includes.
4690         * inf-ptrace.c: Fix common/ includes.
4691         * inf-child.c: Fix common/ includes.
4692         * ia64-linux-nat.c: Fix common/ includes.
4693         * i387-tdep.c: Fix common/ includes.
4694         * i386-tdep.c: Fix common/ includes.
4695         * i386-linux-tdep.c: Fix common/ includes.
4696         * i386-linux-nat.c: Fix common/ includes.
4697         * i386-go32-tdep.c: Fix common/ includes.
4698         * i386-fbsd-tdep.c: Fix common/ includes.
4699         * i386-fbsd-nat.c: Fix common/ includes.
4700         * guile/scm-type.c: Fix common/ includes.
4701         * guile/guile.c: Fix common/ includes.
4702         * go32-nat.c: Fix common/ includes.
4703         * gnu-nat.c: Fix common/ includes.
4704         * gdbthread.h: Fix common/ includes.
4705         * gdbarch-selftests.c: Fix common/ includes.
4706         * gdb_usleep.c: Fix common/ includes.
4707         * gdb_select.h: Fix common/ includes.
4708         * gdb_bfd.c: Fix common/ includes.
4709         * gcore.c: Fix common/ includes.
4710         * fork-child.c: Fix common/ includes.
4711         * findvar.c: Fix common/ includes.
4712         * fbsd-nat.c: Fix common/ includes.
4713         * event-top.c: Fix common/ includes.
4714         * event-loop.c: Fix common/ includes.
4715         * dwarf2read.c: Fix common/ includes.
4716         * dwarf2loc.c: Fix common/ includes.
4717         * dwarf2-frame.c: Fix common/ includes.
4718         * dwarf-index-cache.c: Fix common/ includes.
4719         * dtrace-probe.c: Fix common/ includes.
4720         * disasm-selftests.c: Fix common/ includes.
4721         * defs.h: Fix common/ includes.
4722         * csky-tdep.c: Fix common/ includes.
4723         * cp-valprint.c: Fix common/ includes.
4724         * cp-support.h: Fix common/ includes.
4725         * cp-support.c: Fix common/ includes.
4726         * corelow.c: Fix common/ includes.
4727         * completer.h: Fix common/ includes.
4728         * completer.c: Fix common/ includes.
4729         * compile/compile.c: Fix common/ includes.
4730         * compile/compile-loc2c.c: Fix common/ includes.
4731         * compile/compile-cplus-types.c: Fix common/ includes.
4732         * compile/compile-cplus-symbols.c: Fix common/ includes.
4733         * command.h: Fix common/ includes.
4734         * cli/cli-dump.c: Fix common/ includes.
4735         * cli/cli-cmds.c: Fix common/ includes.
4736         * charset.c: Fix common/ includes.
4737         * build-id.c: Fix common/ includes.
4738         * btrace.h: Fix common/ includes.
4739         * btrace.c: Fix common/ includes.
4740         * breakpoint.h: Fix common/ includes.
4741         * breakpoint.c: Fix common/ includes.
4742         * ax.h:
4743         (enum agent_op): Fix common/ includes.
4744         * ax-general.c (struct aop_map): Fix common/ includes.
4745         * ax-gdb.c: Fix common/ includes.
4746         * auxv.c: Fix common/ includes.
4747         * auto-load.c: Fix common/ includes.
4748         * arm-tdep.c: Fix common/ includes.
4749         * arch/riscv.c: Fix common/ includes.
4750         * arch/ppc-linux-common.c: Fix common/ includes.
4751         * arch/i386.c: Fix common/ includes.
4752         * arch/arm.c: Fix common/ includes.
4753         * arch/arm-linux.c: Fix common/ includes.
4754         * arch/arm-get-next-pcs.c: Fix common/ includes.
4755         * arch/amd64.c: Fix common/ includes.
4756         * arch/aarch64.c: Fix common/ includes.
4757         * arch/aarch64-insn.c: Fix common/ includes.
4758         * arch-utils.c: Fix common/ includes.
4759         * amd64-windows-tdep.c: Fix common/ includes.
4760         * amd64-tdep.c: Fix common/ includes.
4761         * amd64-sol2-tdep.c: Fix common/ includes.
4762         * amd64-obsd-tdep.c: Fix common/ includes.
4763         * amd64-nbsd-tdep.c: Fix common/ includes.
4764         * amd64-linux-tdep.c: Fix common/ includes.
4765         * amd64-linux-nat.c: Fix common/ includes.
4766         * amd64-fbsd-tdep.c: Fix common/ includes.
4767         * amd64-fbsd-nat.c: Fix common/ includes.
4768         * amd64-dicos-tdep.c: Fix common/ includes.
4769         * amd64-darwin-tdep.c: Fix common/ includes.
4770         * agent.c: Fix common/ includes.
4771         * ada-lang.h: Fix common/ includes.
4772         * ada-lang.c: Fix common/ includes.
4773         * aarch64-tdep.c: Fix common/ includes.
4774
4775 2019-01-25  Tom Tromey  <tom@tromey.com>
4776
4777         * common/create-version.sh: Use common/version.h.
4778
4779 2019-01-24  Pedro Alves  <palves@redhat.com>
4780
4781         * infrun.c (signal_stop, signal_print, signal_program)
4782         (signal_catch, signal_pass): Now arrays instead of pointers.
4783         (update_signals_program_target, do_target_resume)
4784         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4785         * linux-nat.c (linux_nat_target::pass_signals)
4786         (linux_nat_target::create_inferior, linux_nat_target::attach):
4787         Adjust.
4788         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4789         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4790         * procfs.c (procfs_target::pass_signals): Adjust.
4791         * record-full.c (record_full_target::resume): Adjust.
4792         * remote.c (remote_target::pass_signals)
4793         (remote_target::program_signals): Adjust.
4794         * target-debug.h (target_debug_print_signals): Now takes a
4795         gdb::array_view as parameter.  Adjust.
4796         * target.h (target_ops) <pass_signals, program_signals>: Replace
4797         pointer and length parameters with gdb::array_view.
4798         (target_pass_signals, target_program_signals): Likewise.
4799         * target-delegates.c: Regenerate.
4800
4801 2019-01-24  Pedro Alves  <palves@redhat.com>
4802
4803         * common/forward-scope-exit.h
4804         (forward_scope_exit::forward_scope_exit): Pass arguments to
4805         m_bind_function directly, instead of creating a std::bind and
4806         copying that.
4807
4808 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4809
4810         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4811         for static members.
4812         (pass_in_v_vfp_candidate): Likewise.
4813
4814 2019-01-23  Tom Tromey  <tom@tromey.com>
4815             Pedro Alves  <palves@redhat.com>
4816
4817         * regcache.c (class regcache_invalidator): Remove.
4818         (regcache::raw_write): Use make_scope_exit.
4819
4820 2019-01-23  Tom Tromey  <tom@tromey.com>
4821
4822         * ui-out.h (class ui_out_emit_type): Update comment.
4823
4824 2019-01-23  Tom Tromey  <tom@tromey.com>
4825
4826         * infrun.c (fetch_inferior_event): Update comment.
4827
4828 2019-01-23  Tom Tromey  <tom@tromey.com>
4829             Pedro Alves  <palves@redhat.com>
4830
4831         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4832         parameter.
4833         (fetch_inferior_event): Use SCOPE_EXIT.
4834
4835
4836 2019-01-23  Tom Tromey  <tom@tromey.com>
4837             Pedro Alves  <palves@redhat.com>
4838
4839         * infrun.c (disable_thread_events): Delete.
4840         (stop_all_threads): Use SCOPE_EXIT.
4841
4842 2019-01-23  Tom Tromey  <tom@tromey.com>
4843             Pedro Alves  <palves@redhat.com>
4844
4845         * symfile.c: Include forward-scope-exit.h.
4846         (clear_symtab_users_cleanup): Replace forward declaration with
4847         a FORWARD_SCOPE_EXIT.
4848         (syms_from_objfile_1): Use the forward_scope_exit and
4849         gdb::optional instead of cleanup_function.
4850         (reread_symbols): Use the forward_scope_exit instead of
4851         cleanup_function.
4852         (clear_symtab_users_cleanup): Remove function.
4853
4854 2019-01-23  Tom Tromey  <tom@tromey.com>
4855             Pedro Alves  <palves@redhat.com>
4856
4857         * linux-nat.c: Include scope-exit.h.
4858         (cleanup_target_stop): Remove.
4859         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4860         SCOPE_EXIT.
4861
4862 2019-01-23  Tom Tromey  <tom@tromey.com>
4863             Pedro Alves  <palves@redhat.com>
4864
4865         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4866         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4867
4868 2019-01-23  Tom Tromey  <tom@tromey.com>
4869             Andrew Burgess  <andrew.burgess@embecosm.com>
4870             Pedro Alves  <palves@redhat.com>
4871
4872         * infrun.c (fetch_inferior_event): Use scope_exit.
4873         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4874         * top.c (execute_command): Use scope_exit.
4875         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4876         * utils.c (do_bpstat_clear_actions_cleanup)
4877         (make_bpstat_clear_actions_cleanup): Remove.
4878
4879 2019-01-23  Tom Tromey  <tom@tromey.com>
4880             Pedro Alves  <palves@redhat.com>
4881
4882         * infrun.c: Include "common/scope-exit.h"
4883         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4884         (wait_for_inferior): Use SCOPE_EXIT.
4885         (fetch_inferior_event): Use scope_exit.
4886
4887 2019-01-23  Tom Tromey  <tom@tromey.com>
4888             Pedro Alves  <palves@redhat.com>
4889
4890         * breakpoint.c (create_breakpoint): Remove cleanup.
4891
4892 2019-01-23  Tom Tromey  <tom@tromey.com>
4893             Andrew Burgess  <andrew.burgess@embecosm.com>
4894             Pedro Alves  <palves@redhat.com>
4895
4896 2019-01-23  Pedro Alves  <palves@redhat.com>
4897
4898         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4899
4900 2019-01-23  Pedro Alves  <palves@redhat.com>
4901             Andrew Burgess  <andrew.burgess@embecosm.com>
4902
4903         * gdbthread.h: Include "common/forward-scope-exit.h".
4904         (scoped_finish_thread_state): Redefine custom class in terms of
4905         forward_scope_exit.
4906
4907 2019-01-23  Pedro Alves  <palves@redhat.com>
4908             Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * common/forward-scope-exit.h: New file.
4911
4912 2019-01-23  Pedro Alves  <palves@redhat.com>
4913             Andrew Burgess  <andrew.burgess@embecosm.com>
4914             Tom Tromey  <tom@tromey.com>
4915
4916         * common/scope-exit.h: New file.
4917
4918 2019-01-23  Pedro Alves  <palves@redhat.com>
4919
4920         * common/preprocessor.h (ESC): Rename to ...
4921         (ESC_PARENS): ... this.
4922         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4923         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4924
4925 2019-01-23  Tom Tromey  <tom@tromey.com>
4926
4927         * language.h (class scoped_switch_to_sym_language_if_auto):
4928         Initialize m_lang in both cases.
4929
4930 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4933         with XCNEW.
4934
4935 2019-01-22  Tom Tromey  <tom@tromey.com>
4936
4937         * corelow.c: Do not include sys/file.h.
4938
4939 2019-01-22  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-wingeneral.h: Include gdb_curses.h.
4942
4943 2019-01-22  Tom Tromey  <tom@tromey.com>
4944
4945         * source-cache.h (class source_cache) <get_source_lines,
4946         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4947
4948 2019-01-22  Tom Tromey  <tom@tromey.com>
4949
4950         * remote-fileio.h (struct remote_target): Declare.
4951
4952 2019-01-22  Tom Tromey  <tom@tromey.com>
4953
4954         * python/py-arch.c: Do not include py-ref.h.
4955         * python/py-bpevent.c: Do not include py-ref.h.
4956         * python/py-cmd.c: Do not include py-ref.h.
4957         * python/py-continueevent.c: Do not include py-ref.h.
4958         * python/py-event.h: Do not include py-ref.h.
4959         * python/py-evtregistry.c: Do not include py-ref.h.
4960         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4961         * python/py-frame.c: Do not include py-ref.h.
4962         * python/py-framefilter.c: Do not include py-ref.h.
4963         * python/py-function.c: Do not include py-ref.h.
4964         * python/py-infevents.c: Do not include py-ref.h.
4965         * python/py-linetable.c: Do not include py-ref.h.
4966         * python/py-objfile.c: Do not include py-ref.h.
4967         * python/py-param.c: Do not include py-ref.h.
4968         * python/py-prettyprint.c: Do not include py-ref.h.
4969         * python/py-progspace.c: Do not include py-ref.h.
4970         * python/py-symbol.c: Do not include py-ref.h.
4971         * python/py-symtab.c: Do not include py-ref.h.
4972         * python/py-type.c: Do not include py-ref.h.
4973         * python/py-unwind.c: Do not include py-ref.h.
4974         * python/py-utils.c: Do not include py-ref.h.
4975         * python/py-value.c: Do not include py-ref.h.
4976         * python/py-varobj.c: Do not include py-ref.h.
4977         * python/py-xmethods.c: Do not include py-ref.h.
4978         * python/python.c: Do not include py-ref.h.
4979         * varobj.c: Do not include py-ref.h.
4980
4981 2019-01-22  Tom Tromey  <tom@tromey.com>
4982
4983         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4984         keyword for bcache.
4985
4986 2019-01-22  Tom Tromey  <tom@tromey.com>
4987
4988         * compile/compile-cplus-types.c: Remove a comment by #include.
4989
4990 2019-01-22  Tom Tromey  <tom@tromey.com>
4991
4992         * compile/gcc-c-plugin.h: Include compile-internal.h.
4993
4994 2019-01-22  Tom Tromey  <tom@tromey.com>
4995
4996         * stabsread.c (EXTERN): Do not define.
4997         (symnum, next_symbol_text_func, processing_gcc_compilation)
4998         (within_function, global_sym_chain, global_stabs)
4999         (previous_stab_code, this_object_header_files)
5000         (n_this_object_header_files)
5001         (n_allocated_this_object_header_files): Define.
5002         * stabsread.h (EXTERN): Never define.  Use "extern".
5003
5004 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5005
5006         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5007         history_value.
5008
5009 2019-01-21  Tom Tromey  <tom@tromey.com>
5010
5011         * ui-out.c: Fix includes.
5012         * tui/tui-source.c: Fix includes.
5013         * target.c: Fix includes.
5014         * remote.c: Fix includes.
5015         * regcache.c: Fix includes.
5016         * python/py-block.c: Fix includes.
5017         * printcmd.c: Fix includes.
5018         * or1k-tdep.c: Fix includes.
5019         * mi/mi-main.c: Fix includes.
5020         * m32r-tdep.c: Fix includes.
5021         * csky-tdep.c: Fix includes.
5022         * compile/compile-cplus-types.c: Fix includes.
5023         * cli/cli-interp.c: Fix includes.
5024
5025 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5026
5027         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5028         for padding.
5029
5030 2019-01-16  Tom Tromey  <tom@tromey.com>
5031
5032         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5033         earlier.
5034         (struct objfile) <msymbols_range>: Move from top level.
5035         <msymbols>: New method.
5036         (class objfile_msymbols): Remove.
5037         * symtab.c (default_collect_symbol_completion_matches_break_on):
5038         Update.
5039         * symmisc.c (dump_msymbols): Update.
5040         * stabsread.c (scan_file_globals): Update.
5041         * objc-lang.c (info_selectors_command, info_classes_command)
5042         (find_methods): Update.
5043         * minsyms.c (find_solib_trampoline_target): Update.
5044         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5045         * coffread.c (coff_symfile_read): Update.
5046         * ada-lang.c (ada_lookup_simple_minsym)
5047         (ada_collect_symbol_completion_matches): Update.
5048
5049 2019-01-16  Tom Tromey  <tom@tromey.com>
5050
5051         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5052         type.  Remove no-argument constructor.
5053         <iterator::operator++>: Simplify.
5054         <begin>: Update.
5055         <end>: Use minimal_symbol_count.
5056
5057 2019-01-16  Tom Tromey  <tom@tromey.com>
5058
5059         * objfiles.h (struct objfile) <psymtabs>: New method.
5060         (class objfile_psymtabs): Remove.
5061         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5062         typedef.
5063         <range>: New method.
5064         (require_partial_symbols): Change return type.
5065         * psymtab.c (require_partial_symbols)
5066         (psym_expand_symtabs_matching): Update.
5067         * mdebugread.c (parse_partial_symbols): Update.
5068         * dbxread.c (dbx_end_psymtab): Update.
5069
5070 2019-01-15  Tom Tromey  <tom@tromey.com>
5071
5072         * symtab.c (lookup_objfile_from_block)
5073         (lookup_symbol_in_objfile_symtabs)
5074         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5075         (find_line_symtab, info_sources_command)
5076         (default_collect_symbol_completion_matches_break_on)
5077         (make_source_files_completion_list): Update.
5078         * symmisc.c (print_objfile_statistics, dump_objfile)
5079         (maintenance_print_symbols, maintenance_info_symtabs)
5080         (maintenance_check_symtabs, maintenance_info_line_tables):
5081         Update.
5082         * source.c (select_source_symtab)
5083         (forget_cached_source_info_for_objfile): Update.
5084         * objfiles.h (class objfile_compunits): Remove.
5085         (struct objfile) <compunits_range>: New typedef.
5086         (compunits): New method.
5087         * objfiles.c (objfile_relocate1): Update.
5088         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5089         * maint.c (count_symtabs_and_blocks): Update.
5090         * linespec.c (iterate_over_all_matching_symtabs): Update.
5091         * cp-support.c (add_symbol_overload_list_qualified): Update.
5092         * coffread.c (coff_symtab_read): Update.
5093         * ada-lang.c (add_nonlocal_symbols)
5094         (ada_collect_symbol_completion_matches)
5095         (ada_add_global_exceptions): Update.
5096
5097 2019-01-15  Tom Tromey  <tom@tromey.com>
5098
5099         * progspace.h (program_space) <objfiles_safe_range>: New
5100         typedef.
5101         <objfiles_safe>: New method.
5102         * objfiles.h (class all_objfiles_safe): Remove.
5103         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5104         * jit.c (jit_inferior_exit_hook): Update.
5105
5106 2019-01-17  Tom Tromey  <tom@tromey.com>
5107
5108         * progspace.h (program_space) <objfiles_range>: New typedef.
5109         <objfiles>: New method.
5110         <objfiles_head>: Rename from objfiles.
5111         (object_files): Update.
5112         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5113         * guile/scm-pretty-print.c
5114         (ppscm_find_pretty_printer_from_objfiles): Update.
5115         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5116         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5117         Update.
5118         * python/py-progspace.c (pspy_get_objfiles): Update.
5119         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5120         Update.
5121         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5122         (objfpy_lookup_objfile_by_build_id): Update.
5123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5124         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5125         Update.
5126         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5127         (expand_symtab_containing_pc, lookup_objfile_from_block)
5128         (lookup_static_symbol, basic_lookup_transparent_type)
5129         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5130         (find_line_symtab, info_sources_command)
5131         (default_collect_symbol_completion_matches_break_on)
5132         (make_source_files_completion_list, find_main_name): Update.
5133         * symmisc.c (print_symbol_bcache_statistics)
5134         (print_objfile_statistics, maintenance_print_symbols)
5135         (maintenance_print_msymbols, maintenance_print_objfiles)
5136         (maintenance_info_symtabs, maintenance_check_symtabs)
5137         (maintenance_expand_symtabs, maintenance_info_line_tables):
5138         Update.
5139         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5140         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5141         (map_overlay_command, unmap_overlay_command)
5142         (simple_overlay_update, expand_symtabs_matching)
5143         (map_symbol_filenames): Update.
5144         * symfile-debug.c (set_debug_symfile): Update.
5145         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5146         Update.
5147         * source.c (select_source_symtab, forget_cached_source_info):
5148         Update.
5149         * solib.c (solib_read_symbols): Update.
5150         * solib-spu.c (append_ocl_sos): Update.
5151         * psymtab.c (maintenance_print_psymbols)
5152         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5153         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5154         * printcmd.c (info_symbol_command): Update.
5155         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5156         Update.
5157         * objfiles.h (class all_objfiles): Remove.
5158         * objfiles.c (have_partial_symbols, have_full_symbols)
5159         (have_minimal_symbols, qsort_cmp, update_section_map)
5160         (shared_objfile_contains_address_p)
5161         (default_iterate_over_objfiles_in_search_order): Update.
5162         * objc-lang.c (info_selectors_command, info_classes_command)
5163         (find_methods): Update.
5164         * minsyms.c (find_solib_trampoline_target): Update.
5165         * maint.c (maintenance_info_sections)
5166         (maintenance_translate_address, count_symtabs_and_blocks):
5167         Update.
5168         * main.c (captured_main_1): Update.
5169         * linux-thread-db.c (try_thread_db_load_from_pdir)
5170         (has_libpthread): Update.
5171         * linespec.c (iterate_over_all_matching_symtabs)
5172         (search_minsyms_for_name): Update.
5173         * jit.c (jit_find_objf_with_entry_addr): Update.
5174         * hppa-tdep.c (find_unwind_entry)
5175         (hppa_lookup_stub_minimal_symbol): Update.
5176         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5177         Update.
5178         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5179         (elf_gnu_ifunc_resolve_by_got): Update.
5180         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5181         * dwarf-index-write.c (save_gdb_index_command): Update.
5182         * cp-support.c (add_symbol_overload_list_qualified): Update.
5183         * breakpoint.c (create_overlay_event_breakpoint)
5184         (create_longjmp_master_breakpoint)
5185         (create_std_terminate_master_breakpoint)
5186         (create_exception_master_breakpoint): Update.
5187         * blockframe.c (find_pc_partial_function): Update.
5188         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5189         (ada_collect_symbol_completion_matches)
5190         (ada_add_global_exceptions): Update.
5191
5192 2019-01-17  Tom Tromey  <tom@tromey.com>
5193
5194         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5195         declare VEC.
5196         (solib_target_parse_libraries): Change return type.
5197         (library_list_start_segment, library_list_start_section)
5198         (library_list_end_library, library_list_start_library); Update.
5199         (solib_target_free_library_list): Remove.
5200         (solib_target_parse_libraries): Remove cleanup.  Change return
5201         type.
5202         (solib_target_current_sos): Update.
5203
5204 2019-01-17  Tom Tromey  <tromey@bapiya>
5205
5206         * valprint.c: Replace "the the" with "the".
5207         * symtab.c: Replace "the the" with "the".
5208         * solib.c: Replace "the the" with "the".
5209         * solib-dsbt.c: Replace "the the" with "the".
5210         * linespec.c: Replace "the the" with "the".
5211         * dwarf2loc.h: Replace "the the" with "the".
5212         * amd64-windows-tdep.c: Replace "the the" with "the".
5213         * aarch64-tdep.c: Replace "the the" with "the".
5214
5215 2019-01-16  Keith Seitz  <keiths@redhat.com>
5216
5217         PR gdb/23773
5218         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5219         <builder>: Rename to ..
5220         <m_builder>: ... this and make private.
5221         (dwarf2_cu::get_builder): New method.  Change all users of
5222         `builder' to use this method.
5223         (dwarf2_start_symtab): Move to ...
5224         (dwarf2_cu::start_symtab): ... here.  Update all callers
5225         (setup_type_unit_groups): Move to ...
5226         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5227         callers.
5228         (dwarf2_cu::reset_builder): New method.
5229         (process_full_compunit, process_full_type_unit): Use
5230         dwarf2_cu::reset_builder.
5231         (follow_die_offset): Record the ancestor CU if it is different
5232         from the followed DIE's CU.
5233         (follow_die_sig_1): Likewise.
5234
5235 2019-01-15  Tom Tromey  <tom@tromey.com>
5236
5237         * remote.c (class remote_state) <buf>: Now a char_vector.
5238         <buf_size>: Remove.
5239         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5240         parameter.
5241         (remote_target::getpkt_or_notif_sane_1)
5242         (remote_target::getpkt_sane)
5243         (remote_target::getpkt_or_notif_sane): Likewise.
5244         (class remote_target) <putpkt>: New overload.
5245         (remote_target::read_frame): Change type of "buf_p".  Remove
5246         sizeof_p parameter.
5247         (packet_ok): New overload.
5248         (packet_check_result): New overload.
5249         Update all uses.
5250
5251 2019-01-14  Tom Tromey  <tom@tromey.com>
5252
5253         * remote-notif.c (handle_notification, remote_notif_ack)
5254         (remote_notif_parse): Make "buf" const.
5255         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5256         const.
5257         (remote_notif_parse, remote_notif_ack, handle_notification):
5258         Likewise.
5259         * remote.c (remote_notif_stop_parse): Make "buf" const.
5260         (remote_target::remote_parse_stop_reply): Make "buf" const.
5261         (remote_notif_stop_ack): Make "buf" const.
5262
5263 2019-01-14  Tom Tromey  <tom@tromey.com>
5264
5265         * remote.c (remote_console_output): Make parameter const.
5266
5267 2019-01-14  Tom Tromey  <tom@tromey.com>
5268
5269         * target-debug.h (target_debug_print_signals): Constify.
5270         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5271         * procfs.c (procfs_target::pass_signals): Update.
5272         * linux-nat.c (linux_nat_target::pass_signals): Update.
5273         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5274         * target-delegates.c: Rebuild.
5275         * remote.c (remote_target::program_signals): Update.
5276         (remote_target::pass_signals): Update.
5277         * target.c (target_pass_signals): Constify argument.
5278         (target_program_signals): Likewise.
5279         * target.h (struct target_ops) <pass_signals, program_signals>:
5280         Constify argument.
5281         (target_pass_signals, target_program_signals): Constify argument.
5282
5283 2019-01-14  Tom Tromey  <tom@tromey.com>
5284
5285         PR tui/28819:
5286         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5287
5288 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5289
5290         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5291         field.
5292         * rs6000-tdep.c: Include reggroups.h.
5293         (IS_V_ALIAS_PSEUDOREG): Define.
5294         (rs6000_register_name): Return names for the "vX" aliases.
5295         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5296         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5297         aliases.  Call default_register_reggroup_p for all other
5298         pseudo-registers.
5299         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5300         New functions.
5301         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5302         Handle "vX" aliases.
5303         (v_alias_pseudo_register_collect): New function.
5304         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5305         (rs6000_gdbarch_init): Initialize "vX" aliases as
5306         pseudo-registers.  Restore registration of
5307         rs6000_pseudo_register_reggroup_p with
5308         set_tdesc_pseudo_register_reggroup_p.
5309
5310 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5311
5312         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5313         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5314         set_gdbarch_num_pseudo_regs.
5315
5316 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5317
5318         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5319         Remove arg prefixname, add do_set and do_show.
5320         Add member functions set_list and show_list.
5321         * cli/cli-style.c (class cli_style_option): Update accordingly.
5322         (style_set_list): Move to file scope.
5323         (style_show_list): Likewise.
5324         (set_style): Call help_list.
5325         (show_style): Call cmd_show_list.
5326         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5327         Update to use the new macro.
5328
5329 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5330
5331         * ada-lang.c (_initialize_ada_language): Expand the help text
5332         for the "catch exception" command.
5333
5334 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5335
5336         * symtab.c (matching_obj_sections): Initialize obj,
5337         declare it closer to its usage.
5338
5339 2019-01-10  Tom Tromey  <tom@tromey.com>
5340
5341         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5342         (basic_inf_threads_range): Remove.
5343         (inf_threads_range, inf_non_exited_threads_range)
5344         (safe_inf_threads_range): Use next_adapter.
5345
5346 2019-01-10  Keith Seitz  <keiths@redhat.com>
5347
5348         PR gdb/23712
5349         PR symtab/23010
5350         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5351         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5352
5353 2019-01-10  Keith Seitz  <keiths@redhat.com>
5354
5355         PR gdb/23712
5356         PR symtab/23010
5357         * dictionary.c (pending_to_vector): Remove.
5358         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5359         Remove _1 suffix, replacing functions of the same name.  Update
5360         all callers.
5361         (dict_create_hashed, dict_create_hashed_expandable)
5362         (dict_create_linear, dict_create_linear_expandable, dict_free)
5363         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5364         Make functions static.
5365
5366 2019-01-10  Keith Seitz  <keiths@redhat.com>
5367
5368         PR gdb/23712
5369         PR symtab/23010
5370         * dictionary.h (struct dictionary): Replace declaration with
5371         multidictionary.
5372         (dict_create_hashed, dict_create_hashed_expandable)
5373         (dict_create_linear, dict_create_linear_expandable)
5374         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5375         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5376         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5377         taking multidictionary argument.
5378         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5379         * block.h (struct block) <dict>: Change to multidictionary
5380         and rename `multidict'.
5381         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5382         symmisc.c: Update all dictionary references to multidictionary.
5383
5384 2019-01-10  Keith Seitz  <keiths@redhat.com>
5385
5386         PR gdb/23712
5387         PR symtab/23010
5388         * dictionary.c: Include unordered_map.
5389         (pending_to_vector): New function.
5390         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5391         Rewrite the non-"_1" functions to take vector instead
5392         of linked list.
5393         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5394         "new" _1 versions of the same name.
5395         (multidictionary): Define.
5396         (std::hash<enum language): New definition.
5397         (collate_pending_symbols_by_language, mdict_create_hashed)
5398         (mdict_create_hashed_expandable, mdict_create_linear)
5399         (mdict_create_linear_expandable, mdict_free)
5400         (find_language_dictionary, create_new_language_dictionary)
5401         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5402         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5403         (mdict_size, mdict_empty): New functions.
5404         * dictionary.h (mdict_iterator): Define.
5405
5406 2019-01-10  Pedro Alves  <palves@redhat.com>
5407
5408         * breakpoint.c (read_uploaded_action)
5409         (create_tracepoint_from_upload): Adjust to use
5410         gdb::unique_xmalloc_ptr.
5411         * ctf.c (ctf_write_uploaded_tp):
5412         (SET_ARRAY_FIELD): Use emplace_back.
5413         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5414         * tracefile-tfile.c (tfile_write_uploaded_tp):
5415         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5416         gdb::unique_xmalloc_ptr.
5417         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5418         at_string, cond_string, cmd_strings>: Replace char pointers
5419         with gdb::unique_xmalloc_ptr.
5420
5421 2019-01-10  Pedro Alves  <palves@redhat.com>
5422
5423         * solib-target.c (library_list_start_library): Don't xstrdup name.
5424
5425 2019-01-10  Pedro Alves  <palves@redhat.com>
5426
5427         * mdebugread.c (parse_partial_symbols): Use
5428         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5429
5430 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * linux-fork.c (scoped_switch_fork_info)
5433         <~scoped_switch_fork_info>: Fix incorrect variable name.
5434
5435 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5436
5437         * linux-fork.c (scoped_switch_fork_info)
5438         <scoped_switch_fork_info>: Make explicit.
5439         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5440
5441 2019-01-10  Tom Tromey  <tom@tromey.com>
5442
5443         * objfiles.h (objfile::reset_psymtabs): Update.
5444         * objfiles.c (objfile::objfile): Update.
5445         * psymtab.h (psymtab_storage::obstack): Update.
5446         (psymtab_storage::m_obstack): Use gdb::optional.
5447         (class psymtab_storage): Update comment.  Remove objfile
5448         parameter.
5449         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5450
5451 2019-01-10  Tom Tromey  <tom@tromey.com>
5452
5453         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5454         <free_psymtabs>: Now private.
5455         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5456         (allocate_psymtab): Use new method.
5457
5458 2019-01-10  Tom Tromey  <tom@tromey.com>
5459
5460         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5461         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5462         * mdebugread.c (parse_partial_symbols): Use
5463         allocate_dependencies.
5464         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5465         allocate_dependencies.
5466         (process_psymtab_comp_unit_reader)
5467         (build_type_psymtab_dependencies): Likewise.
5468         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5469
5470 2019-01-10  Tom Tromey  <tom@tromey.com>
5471
5472         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5473         PSYMBOL_SET_LANGUAGE.
5474         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5475
5476 2019-01-10  Tom Tromey  <tom@tromey.com>
5477
5478         * psymtab.h (psymtab_storage::obstack): New method.
5479         <m_obstack>: Rename from obstack; now private.
5480         * psymtab.c (psymtab_storage): Update.
5481         * dwarf2read.c (create_addrmap_from_index)
5482         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5483         Update.
5484
5485 2019-01-10  Tom Tromey  <tom@tromey.com>
5486
5487         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5488         * objfiles.h (objfile::reset_psymtabs): New method.
5489
5490 2019-01-10  Tom Tromey  <tom@tromey.com>
5491
5492         * symmisc.c (print_symbol_bcache_statistics): Update.
5493         (print_objfile_statistics): Update.
5494         * symfile.c (reread_symbols): Update.
5495         * psymtab.h (class psymtab_storage): New.
5496         * psymtab.c (psymtab_storage): New constructor.
5497         (~psymtab_storage): New destructor.
5498         (require_partial_symbols): Update.
5499         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5500         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5501         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5502         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5503         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5504         (start_psymtab_common, end_psymtab_common)
5505         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5506         (allocate_psymtab): Update.
5507         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5508         Update.
5509         (dump_psymtab_addrmap, maintenance_print_psymbols)
5510         (maintenance_check_psymtabs): Update.
5511         (class objfile_psymtabs): Move to objfiles.h.
5512         * psympriv.h (discard_psymtab): Now inline.
5513         (psymtab_discarder::psymtab_discarder): Update.
5514         (psymtab_discarder::~psymtab_discarder): Update.
5515         (ALL_OBJFILE_PSYMTABS): Rewrite.
5516         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5517         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5518         Remove fields.
5519         <partial_symtabs>: New field.
5520         (class objfile_psymtabs): Move from psymtab.h.  Update.
5521         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5522         psymbol_cache.
5523         (objfile::~objfile): Don't destroy psymbol_cache.
5524         * mdebugread.c (parse_partial_symbols): Update.
5525         * dwarf2read.c (create_addrmap_from_index)
5526         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5527         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5528         (add_partial_subprogram, dwarf2_ranges_read): Update.
5529         * dwarf-index-write.c (write_address_map)
5530         (write_one_signatured_type, recursively_write_psymbols)
5531         (class debug_names, class debug_names, write_psymtabs_to_index):
5532         Update.
5533
5534 2019-01-10  Tom Tromey  <tom@tromey.com>
5535
5536         * symtab.h (SYMBOL_SET_NAMES): Update.
5537         (symbol_set_names): Update.
5538         (MSYMBOL_SET_NAMES): Update.
5539         * symtab.c (symbol_set_names): Change argument to be an
5540         objfile_per_bfd_storage.
5541         * psymtab.c (add_psymbol_to_bcache): Update.
5542         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5543
5544 2019-01-10  Tom Tromey  <tom@tromey.com>
5545
5546         * symtab.c (create_demangled_names_hash): Change argument to be an
5547         objfile_per_bfd_storage.
5548         (symbol_set_names): Update.
5549
5550 2019-01-10  Tom Tromey  <tom@tromey.com>
5551
5552         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5553         init_psymbol_list.
5554         * psymtab.c (init_psymbol_list): Do nothing if already called.
5555         * psympriv.h (init_psymbol_list): Add comment.
5556         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5557         init_psymbol_list.
5558         * dbxread.c (dbx_symfile_read): Unconditionally call
5559         init_psymbol_list.
5560
5561 2019-01-10  Tom Tromey  <tom@tromey.com>
5562
5563         * xcoffread.c (scan_xcoff_symtab): Update.
5564         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5565         "where".
5566         * mdebugread.c (parse_partial_symbols)
5567         (handle_psymbol_enumerators): Update.
5568         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5569         * dbxread.c (read_dbx_symtab): Update.
5570         * psympriv.h (psymbol_placement): New enum.
5571         (add_psymbol_to_list): Update.
5572
5573 2019-01-10  Tom Tromey  <tom@tromey.com>
5574
5575         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5576         static_psymbols parameters.
5577         (scan_xcoff_symtab): Update.
5578         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5579         static_psymbols parameters.
5580         * psympriv.h (start_psymtab_common): Update.
5581         * mdebugread.c (parse_partial_symbols): Update.
5582         * dwarf2read.c (create_partial_symtab): Update.
5583         * dbxread.c (read_dbx_symtab): Update.
5584         (start_psymtab): Remove global_psymbols and static_psymbols
5585         parameters.
5586
5587 2019-01-10  Tom Tromey  <tom@tromey.com>
5588
5589         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5590         * psymtab.c (allocate_psymtab): Add comment.
5591         * psympriv.h (allocate_psymtab): Add comment.
5592         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5593         initializations.
5594         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5595
5596 2019-01-10  Tom Tromey  <tom@tromey.com>
5597
5598         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5599         Don't declare.
5600         * mipsread.c: Include mdebugread.h.
5601         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5602         Declare.
5603         * elfread.c: Include mdebugread.h.
5604
5605 2019-01-09  Tom Tromey  <tom@tromey.com>
5606
5607         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5608         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5609         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5610         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5611         (psym_lookup_symbol, psym_find_last_source_symtab)
5612         (psym_forget_cached_source_info, psym_print_stats)
5613         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5614         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5615         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5616         (psym_find_compunit_symtab_by_address)
5617         (maintenance_print_psymbols, maintenance_info_psymtabs)
5618         (maintenance_check_psymtabs): Use ranged for.
5619         * psymtab.h (class objfile_psymtabs): New.
5620         (require_partial_symbols): Return objfile_psymtabs.
5621         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5622
5623 2019-01-09  Tom Tromey  <tom@tromey.com>
5624
5625         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5626         (find_pc_mapped_section, list_overlays_command)
5627         (map_overlay_command, unmap_overlay_command)
5628         (simple_overlay_update): Use all_objfiles.
5629         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5630         * printcmd.c (info_symbol_command): Use all_objfiles.
5631         * objfiles.h (ALL_OBJSECTIONS): Remove.
5632         * maint.c (maintenance_translate_address): Use all_objfiles.
5633         * gcore.c (gcore_create_callback): Use all_objfiles.
5634         (objfile_find_memory_regions): Likewise.
5635
5636 2019-01-09  Tom Tromey  <tom@tromey.com>
5637
5638         * symtab.c (find_line_symtab, info_sources_command)
5639         (make_source_files_completion_list): Use objfile_compunits.
5640         * source.c (select_source_symtab): Use objfile_compunits.
5641         * objfiles.h (struct objfile): Update comment.
5642         (ALL_OBJFILES): Remove.
5643         (ALL_FILETABS): Remove.
5644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5645         objfile_compunits.
5646
5647 2019-01-09  Tom Tromey  <tom@tromey.com>
5648
5649         * symmisc.c (print_objfile_statistics, dump_objfile)
5650         (maintenance_print_symbols): Use compunit_filetabs.
5651         * source.c (forget_cached_source_info_for_objfile): Use
5652         compunit_filetabs.
5653         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5654         (ALL_FILETABS): Use compunit_filetabs.
5655         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5656         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5657
5658 2019-01-09  Tom Tromey  <tom@tromey.com>
5659
5660         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5661         (compunit_filetabs): New.
5662         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5663         compunit_filetabs.
5664         (info_sources_command, make_source_files_completion_list): Remove
5665         declaration.
5666         * symmisc.c (print_objfile_statistics, dump_objfile)
5667         (maintenance_print_symbols): Remove declaration.
5668         (maintenance_info_symtabs): Use compunit_filetabs.
5669         (maintenance_info_line_tables): Likewise.
5670         * source.c (select_source_symtab): Change local variable name.
5671         (forget_cached_source_info_for_objfile): Remove declaration.
5672         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5673         * objfiles.c (objfile_relocate1): Remove declaration.
5674         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5675         declaration.
5676         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5677         * coffread.c (coff_symtab_read): Remove declaration.
5678         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5679         compunit_filetabs.
5680
5681 2019-01-09  Tom Tromey  <tom@tromey.com>
5682
5683         * symtab.c (lookup_objfile_from_block)
5684         (find_pc_sect_compunit_symtab, search_symbols)
5685         (default_collect_symbol_completion_matches_break_on): Use
5686         objfile_compunits.
5687         * objfiles.h (ALL_COMPUNITS): Remove.
5688         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5689         * cp-support.c (add_symbol_overload_list_qualified): Use
5690         objfile_compunits.
5691         * ada-lang.c (ada_collect_symbol_completion_matches)
5692         (ada_add_global_exceptions): Use objfile_compunits.
5693
5694 2019-01-09  Tom Tromey  <tom@tromey.com>
5695
5696         * source.c (select_source_symtab)
5697         (forget_cached_source_info_for_objfile): Remove declaration.
5698         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5699         declaration.
5700         * maint.c (count_symtabs_and_blocks): Remove declaration.
5701         * cp-support.c (add_symbol_overload_list_qualified): Remove
5702         declaration.
5703         * coffread.c (coff_symtab_read): Remove declaration.
5704         * symtab.c (lookup_symbol_in_objfile_symtabs)
5705         (basic_lookup_transparent_type_1): Use objfile_compunits.
5706         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5707         (info_sources_command, search_symbols)
5708         (default_collect_symbol_completion_matches_break_on)
5709         (make_source_files_completion_list): Remove declaration.
5710         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5711         (ada_collect_symbol_completion_matches)
5712         (ada_add_global_exceptions): Remove declaration.
5713         * linespec.c (iterate_over_all_matching_symtabs): Use
5714         objfile_compunits.
5715         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5716         (class objfile_compunits): New.
5717         (ALL_COMPUNITS): Use objfile_compunits.
5718         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5719         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5720         objfile_compunits.
5721         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5722
5723 2019-01-09  Tom Tromey  <tom@tromey.com>
5724
5725         * symtab.c (search_symbols)
5726         (default_collect_symbol_completion_matches_break_on): Use
5727         objfile_msymbols.
5728         * ada-lang.c (ada_lookup_simple_minsym)
5729         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5730         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5731         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5732         objfile_msymbols.
5733         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5734         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5735         * objc-lang.c (find_methods): Use objfile_msymbols.
5736         (info_selectors_command, info_classes_command): Likewise.
5737         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5738         * objfiles.h (class objfile_msymbols): New.
5739         (ALL_OBJFILE_MSYMBOLS): Remove.
5740         (ALL_MSYMBOLS): Remove.
5741
5742 2019-01-09  Tom Tromey  <tom@tromey.com>
5743
5744         * common/next-iterator.h (next_adapter): Add Iterator template
5745         parameter.
5746         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5747         (class all_objfiles_safe): New.
5748         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5749         * objfiles.c (put_objfile_before): Update comment.
5750         (add_separate_debug_objfile): Likewise.
5751         (free_all_objfiles): Use all_objfiles_safe.
5752         (objfile_purge_solibs): Likewise.
5753
5754 2019-01-09  Tom Tromey  <tom@tromey.com>
5755
5756         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5757         (expand_symtab_containing_pc, lookup_static_symbol)
5758         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5759         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5760         all_objfiles.
5761         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5762         * breakpoint.c (create_overlay_event_breakpoint)
5763         (create_longjmp_master_breakpoint)
5764         (create_std_terminate_master_breakpoint)
5765         (create_exception_master_breakpoint): Use all_objfiles.
5766         * linux-thread-db.c (try_thread_db_load_from_pdir)
5767         (has_libpthread): Use all_objfiles.
5768         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5769         * linespec.c (iterate_over_all_matching_symtabs)
5770         (search_minsyms_for_name): Use all_objfiles.
5771         * maint.c (maintenance_info_sections): Use all_objfiles.
5772         * main.c (captured_main_1): Use all_objfiles.
5773         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5774         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5775         * guile/scm-pretty-print.c
5776         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5777         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5778         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5779         (maintenance_print_msymbols): Use all_objfiles.
5780         * source.c (select_source_symtab): Use all_objfiles.
5781         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5782         * symfile.c (remove_symbol_file_command)
5783         (expand_symtabs_matching, map_symbol_filenames): Use
5784         all_objfiles.
5785         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5786         all_objfiles.
5787         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5788         * objc-lang.c (find_methods): Use all_objfiles.
5789         * objfiles.c (have_partial_symbols, have_full_symbols)
5790         (have_minimal_symbols, qsort_cmp)
5791         (default_iterate_over_objfiles_in_search_order): Use
5792         all_objfiles.
5793         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5794         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5795         (maintenance_check_psymtabs): Use all_objfiles.
5796         (ALL_PSYMTABS): Remove.
5797         * compile/compile-object-run.c (do_module_cleanup): Use
5798         all_objfiles.
5799         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5800         * cp-support.c (add_symbol_overload_list_qualified): Use
5801         all_objfiles.
5802         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5803         Use all_objfiles.
5804         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5805         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5806         all_objfiles.
5807         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5808         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5809         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5810         Uses all_objfiles.
5811         * solib.c (solib_read_symbols): Use all_objfiles
5812
5813 2019-01-09  Tom Tromey  <tom@tromey.com>
5814
5815         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5816         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5817         all_objfiles.
5818         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5819         * symmisc.c (print_symbol_bcache_statistics)
5820         (print_objfile_statistics, maintenance_print_objfiles)
5821         (maintenance_info_symtabs, maintenance_check_symtabs)
5822         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5823         all_objfiles.
5824         * source.c (forget_cached_source_info): Use all_objfiles.
5825         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5826         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5827         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5828         * objfiles.c (update_section_map): Use all_objfiles.
5829         (shared_objfile_contains_address_p): Likewise.
5830         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5831         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5832
5833 2019-01-09  Tom Tromey  <tom@tromey.com>
5834
5835         * common/next-iterator.h: New file.
5836         * objfiles.h (class all_objfiles): New.
5837         (struct objfile_iterator): New.
5838
5839 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5840
5841         * NEWS: Move the description of the changed "frame", "select-frame",
5842          and "info frame" commands to the Changed commands section.
5843
5844 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5845
5846         * gdbtypes.c (check_stub_method_group): Remove handling of old
5847         mangling schemes.
5848         * linespec.c (find_methods): Likewise.
5849         * stabsread.c (read_member_functions): Likewise.
5850         * valops.c (search_struct_method): Likewise.
5851         (value_struct_elt_for_reference): Likewise.
5852         * NEWS: Mention this change.
5853
5854 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5855
5856         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5857         print_source_lines.
5858         * source.c (print_source_lines_base): Update line number check.
5859         (print_source_lines): New function.
5860         (source_lines_range::source_lines_range): New function.
5861         * source.h (class source_lines_range): New class.
5862         (print_source_lines): New declaration.
5863
5864 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5865
5866         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5867
5868 2019-01-08  Tom Tromey  <tom@tromey.com>
5869             Simon Marchi  <simon.marchi@ericsson.com>
5870
5871         PR gdb/24060
5872         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5873         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5874         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5875         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5876         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5877         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5878
5879 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * source.c (select_source_symtab): Move header comment to
5882         declaration in source.h.
5883         (forget_cached_source_info_for_objfile): Likewise.
5884         (forget_cached_source_info): Likewise.
5885         (identify_source_line): Likewise.
5886         * source.h (identify_source_line): Move declaration from symtab.h
5887         and add comment from source.c
5888         (print_source_lines): Likewise.
5889         (forget_cached_source_info_for_objfile): Likewise.
5890         (forget_cached_source_info): Likewise.
5891         (select_source_symtab): Likewise.
5892         (enum print_source_lines_flag): Move definition from symtab.h.
5893         * symtab.h (identify_source_line): Move declaration to source.h.
5894         (print_source_lines): Likewise.
5895         (forget_cached_source_info_for_objfile): Likewise.
5896         (forget_cached_source_info): Likewise.
5897         (select_source_symtab): Likewise.
5898         (enum print_source_lines_flag): Move definition to source.h.
5899         * tui/tui-hooks.c: Add 'source.h' include.
5900
5901 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5902
5903         * source.c (print_source_lines_base): Handle requests to print
5904         reverse line number sequences, and guard against empty lines
5905         string.
5906
5907 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * source.c (print_source_lines_base): Fix skip of '\r' if next
5910         character is '\n'.
5911
5912 2019-01-06  Tom Tromey  <tom@tromey.com>
5913
5914         * c-exp.y (struct c_parse_state) <macro_original_text,
5915         expansion_obstack>: New member.
5916         (macro_original_text, expansion_obstack): Remove globals.
5917         (scan_macro_expansion, scanning_macro_expansion)
5918         (finished_macro_expansion): Update.
5919         (scan_macro_cleanup): Remove.
5920         (yylex, c_parse): Update.
5921
5922 2019-01-06  Tom Tromey  <tom@tromey.com>
5923
5924         * c-exp.y (struct c_parse_state) <strings>: New member.
5925         (operator_stoken): Update.
5926
5927 2019-01-06  Tom Tromey  <tom@tromey.com>
5928
5929         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5930         (union type_stack_elt) <typelist_val>: Now a pointer to
5931         std::vector.
5932         (type_stack_cleanup): Don't declare.
5933         (push_typelist): Update.
5934         * parse.c (pop_typelist): Return a std::vector.
5935         (push_typelist): Take a std::vector.
5936         (follow_types): Update.  Do not free args.
5937         (type_stack_cleanup): Remove.
5938         * c-exp.y (struct c_parse_state): New.
5939         (cpstate): New global.
5940         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5941         (nonempty_typelist): Update.
5942         (func_mod): Create a new vector.
5943         (c_parse): Create a c_parse_state.
5944         (check_parameter_typelist): Do not delete params.
5945         (function_method): Update.  Do not delete type_list.
5946
5947 2019-01-06  Tom Tromey  <tom@tromey.com>
5948
5949         PR gdb/28155:
5950         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5951         check_typedef.
5952         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5953         (print_return_value): Likewise.
5954
5955 2019-01-05  Tom Tromey  <tom@tromey.com>
5956
5957         * contrib/cleanup_check.py: Remove.
5958         * contrib/gcc-with-excheck: Remove.
5959         * contrib/exsummary.py: Remove.
5960         * contrib/excheck.py: Remove.
5961
5962 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5963
5964         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5965         NULL. Initialize tpprev to NULL instead of assigning it
5966         to NULL on the next statement.
5967         * windows-nat.c (windows_delete_thread): Remove check for
5968         main_thread_id before printing thread exit notifications.
5969         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5970         Remove thread ID check against main_thread_id.
5971         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5972         windows_delete_thread.
5973         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5974
5975 2019-01-04  Tom Tromey  <tom@tromey.com>
5976
5977         * compile/compile.c (_initialize_compile): Use upper case for
5978         metasyntactic variables.
5979         * symmisc.c (_initialize_symmisc): Use upper case for
5980         metasyntactic variables.
5981         * psymtab.c (_initialize_psymtab): Use upper case for
5982         metasyntactic variables.
5983         * demangle.c (demangle_command): Use upper case for metasyntactic
5984         variables.
5985         (_initialize_demangler): Likewise.
5986         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5987         variables.
5988
5989 2019-01-03  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5992
5993 2019-01-03  Tom Tromey  <tom@tromey.com>
5994
5995         * python/py-symtab.c (salpy_str): Update.
5996         (struct salpy_sal_object) <symtab>: Now a PyObject.
5997         (salpy_dealloc): Update.
5998         (del_objfile_sal): Use gdbpy_ref.
5999
6000 2019-01-03  Tom Tromey  <tom@tromey.com>
6001
6002         * python/py-type.c (convert_field): Use new_reference.  Return
6003         gdbpy_ref.
6004         (make_fielditem): Return gdbpy_ref.
6005         (typy_fields): Update.
6006         (typy_getitem): Update.
6007         (field_name): Return gdbpy_ref.  Use new_reference.
6008         (typy_iterator_iternext): Update.
6009
6010 2019-01-03  Tom Tromey  <tom@tromey.com>
6011
6012         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6013
6014 2019-01-03  Tom Tromey  <tom@tromey.com>
6015
6016         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6017         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6018         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6019         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6020         (pspy_set_type_printers): Likewise.
6021         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6022         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6023         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6024         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6025         (objfpy_set_type_printers): Likewise.
6026
6027 2019-01-03  Tom Tromey  <tom@tromey.com>
6028
6029         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6030         (gdbpy_print_stack): Use gdbpy_err_fetch.
6031         * python/python-internal.h (class gdbpy_err_fetch): New class.
6032         (class gdbpy_enter) <m_error_type, m_error_value,
6033         m_error_traceback>: Remove.
6034         <m_error>: New member.
6035         (gdbpy_exception_to_string): Don't declare.
6036         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6037         * python/py-value.c (convert_value_from_python): Use
6038         gdbpy_err_fetch.
6039         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6040         gdbpy_exception_to_string.
6041         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6042         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6043         gdbpy_err_fetch.
6044
6045 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * linux-nat.c (delete_lwp_cleanup): Delete.
6048         (struct lwp_deleter): New struct.
6049         (lwp_info_up): New typedef.
6050         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6051         lwp_info_up.
6052
6053 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * linux-fork.c (class scoped_switch_fork_info): New class.
6056         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6057
6058 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * valops.c (find_overload_match): Remove use of null_cleanup, and
6061         calls to do_cleanups.
6062
6063 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * compile/compile-cplus-types.c
6066         (compile_cplus_instance::decl_name): Handle changes to
6067         cp_func_name.
6068         * cp-support.c (cp_func_name): Update header comment, update
6069         return type.
6070         * cp-support.h (cp_func_name): Update return type in declaration.
6071         * valops.c (find_overload_match): Move temp_func local to top
6072         level of function and change its type.  Use temp_func to hold and
6073         delete temporary string obtained from cp_func_name.
6074
6075 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6078         gdb::char_vector, remove cleanup, and update uses of `msg`.
6079
6080 2019-01-03  Jim Wilson  <jimw@sifive.com>
6081
6082         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6083
6084 2019-01-02  Tom Tromey  <tom@tromey.com>
6085
6086         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6087         (tdesc_parse_xml): Remove cleanups.
6088         * target-descriptions.h (make_cleanup_free_target_description):
6089         Don't declare.
6090         (target_desc_deleter): New struct.
6091         (target_desc_up): New typedef.
6092         * target-descriptions.c (target_desc_deleter::operator()): Rename
6093         from free_target_description.
6094         (make_cleanup_free_target_description): Remove.
6095
6096 2019-01-02  Tom Tromey  <tom@tromey.com>
6097
6098         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6099         constructor, destructor.
6100         (linespec_parser): Remove typedef.
6101         (~linespec_parser): Rename from linespec_parser_delete.
6102         (linespec_lex_to_end, linespec_complete_label)
6103         (linespec_complete): Update.
6104         (decode_line_full): Remove cleanups.
6105         (decode_line_1): Update.
6106
6107 2019-01-02  Tom Tromey  <tom@tromey.com>
6108
6109         * python/python-internal.h (inferior_to_inferior_object): Change
6110         return type.
6111         * python/py-exitedevent.c (create_exited_event_object): Update.
6112         * python/py-inferior.c (inferior_to_inferior_object): Return
6113         gdbpy_ref.
6114         (python_new_inferior, python_inferior_deleted)
6115         (thread_to_thread_object, delete_thread_object)
6116         (build_inferior_list, gdbpy_selected_inferior): Update.
6117         * python/py-infthread.c (create_thread_object): Update.  Also fail
6118         if inferior_to_inferior_object fails.
6119
6120 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6121
6122         * inferior.h (class inferior) <displaced_step_state>: New field.
6123         * infrun.h (struct displaced_step_state): Move here from
6124         infrun.c.  Initialize fields, add constructor.
6125         <inf>: Remove field.
6126         <reset>: New method.
6127         * infrun.c (struct displaced_step_inferior_state): Move to
6128         infrun.h.
6129         (displaced_step_inferior_states): Remove.
6130         (get_displaced_stepping_state): Adust.
6131         (displaced_step_in_progress_any_inferior): Adjust.
6132         (displaced_step_in_progress_thread): Adjust.
6133         (displaced_step_in_progress): Adjust.
6134         (add_displaced_stepping_state): Remove.
6135         (get_displaced_step_closure_by_addr): Adjust.
6136         (remove_displaced_stepping_state): Remove.
6137         (infrun_inferior_exit): Call displaced_step_state.reset.
6138         (use_displaced_stepping): Don't check for NULL.
6139         (displaced_step_prepare_throw): Call
6140         get_displaced_stepping_state.
6141         (displaced_step_fixup): Don't check for NULL.
6142         (prepare_for_detach): Don't check for NULL.
6143
6144 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6147          in case of call that did not complete.
6148
6149 2019-01-02  Andrey Utkin  <autkin@undo.io>
6150
6151         * symfile.c (find_separate_debug_file): Fix search of debug files for
6152         remote debuggee.
6153
6154 2019-01-02  Tom Tromey  <tom@tromey.com>
6155
6156         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6157         indentation.
6158         * python/py-frame.c (frapy_older): Remove cast.
6159         (frapy_newer): Likewise.
6160         * python/py-breakpoint.c (local_setattro): Remove cast.
6161         * python/py-arch.c (archpy_name): Remove local variable.
6162         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6163
6164 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6165
6166         * unittests/basic_string_view/element_access/char/empty.cc:
6167         Fix year range in copyright header.
6168
6169 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6172         Delete.
6173         <operator==>: Update with for removed field.
6174         <hash>: Likewise.
6175         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6176         <isa_features>: ...this.
6177         <abi_features>: New field.
6178         (riscv_isa_flen): Update comment.
6179         (riscv_abi_xlen): New declaration.
6180         (riscv_abi_flen): New declaration.
6181         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6182         isa_features.
6183         (riscv_abi_xlen): New function.
6184         (riscv_isa_flen): Update to get answer from isa_features.
6185         (riscv_abi_flen): New function.
6186         (riscv_has_fp_abi): Update to get answer from abi_features.
6187         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6188         xlen and flen.
6189         (riscv_call_info) <xlen, flen>: Update comment.
6190         (riscv_call_arg_struct): Remove invalid assertions
6191         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6192         is removed.
6193         (riscv_gdbarch_init): Gather isa features and abi features
6194         separately, ensure both match on the gdbarch when reusing an old
6195         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6196         a target with 64-bit float hardware.
6197
6198 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6199
6200         * source.c (search_command_helper): Stop reverse search
6201         when line 1 has been searched.
6202
6203 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6204
6205         * record-full.c (record_full_base_target::close): Rewrite
6206         record_full_core_buf_list free logic.
6207
6208 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6209
6210         * break-catch-syscall.c (print_one_catch_syscall): xfree
6211         the last text.
6212
6213 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6214
6215         * top.c (print_gdb_version): Update Copyright year in version
6216         message.
6217
6218 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6219
6220         Update copyright year range in all GDB files.
6221
6222 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6223
6224         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6225
6226 For older changes see ChangeLog-2018.
6227 \f
6228 Local Variables:
6229 mode: change-log
6230 left-margin: 8
6231 fill-column: 74
6232 version-control: never
6233 coding: utf-8
6234 End:
6235