gdb/ChangeLog

   1 2019-06-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
   4         EVAL_AVOID_SIDE_EFFECTS specially.
   5
   6 2019-06-19  Tom Tromey  <tromey@adacore.com>
   7
   8         * source-cache.c (highlighter): New global.
   9         (source_cache::get_source_lines): Create a highlighter on demand.
  10
  11 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * defs.h (deprecated_interactive_hook): Delete declaration.
  14         * interps.c (clear_interpreter_hooks): Remove use of
  15         deprecated_interactive_hook.
  16         * top.c (deprecated_interactive_hook): Delete definition.
  17         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  18
  19 2019-06-18  Tom de Vries  <tdevries@suse.de>
  20
  21         PR gdb/24515
  22         * dwarf2read.h (abstract_to_concrete): Change type from
  23         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  24         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  25         * dwarf2read.c (read_variable): Update.
  26         (dwarf2_fetch_die_loc_sect_off): Update.
  27
  28 2019-06-17  Tom de Vries  <tdevries@suse.de>
  29
  30         PR gdb/24617
  31         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  32         accessing parent[parent_len - 1].
  33
  34 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  35
  36         PR gdb/24364
  37         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  38         call dtrace_process_dof with NULL dof.
  39
  40 2019-06-16  Tom de Vries  <tdevries@suse.de>
  41
  42         PR gdb/24445
  43         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  44
  45 2019-06-16  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  48         (make_all_visible): Use address of member.
  49
  50 2019-06-16  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  53         (tui_free_window, free_content, free_content_elements): Remove
  54         unnecessary cast.
  55         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  56         cast.
  57         * tui/tui-regs.c (tui_show_register_group)
  58         (tui_display_registers_from, tui_display_reg_element_at_line):
  59         Remove unnecessary cast.
  60
  61 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         * linux-nat.c (normal_mask): Delete.
  64         (_initialize_linux_nat): Don't initialise normal_mask.
  65
  66 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  67
  68         PR gdb/24445
  69         * dwarf-index-write.h (write_psymtabs_to_index): Add
  70         dwz_basename parameter.
  71         * dwarf-index-write.c (write_gdbindex): Move file writing to
  72         write_gdbindex_1.  Change return type void.
  73         (assert_file_size): Move up, remove filename parameter.
  74         (write_gdbindex_1): New function.
  75         (write_debug_names): Change return type to void, call
  76         assert_file_size.
  77         (struct index_wip_file): New struct.
  78         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  79         file logic to index_wip_file.  Write index for dwz file if
  80         needed.
  81         (save_gdb_index_command): Pass basename of dwz file, if present.
  82         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  83         build-id of dwz file, if present.
  84         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  85         (dwarf2_get_dwz_file): Likewise.
  86         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  87         (dwarf2_get_dwz_file): Likewise.
  88
  89 2019-06-16  Tom Tromey  <tom@tromey.com>
  90
  91         * coffread.c (process_coff_symbol): Use xstrdup.
  92         * value.c (create_internalvar): Use xstrdup.
  93
  94 2019-06-16  Tom Tromey  <tom@tromey.com>
  95
  96         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  97         * breakpoint.c (stopin_command, stopat_command)
  98         (until_break_command, decode_location_default): Remove unnecessary
  99         cast.
 100         * utils.c (subset_compare): Remove unnecessary cast.
 101         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 102         cast.
 103         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 104         cast.
 105         * infcmd.c (path_command): Remove unnecessary cast.
 106         * coffread.c (decode_type): Remove unnecessary cast.
 107         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 108         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 109         * tui/tui-stack.c (tui_show_locator_content)
 110         (tui_show_frame_info): Remove unnecessary cast.
 111         * tui/tui-win.c (tui_scroll_forward_command)
 112         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 113         (parse_scrolling_args): Remove unnecessary cast.
 114         * tui/tui-data.c (init_win_info, tui_del_window)
 115         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 116         (free_content_elements): Remove unnecessary cast.
 117         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 118         unnecessary cast.
 119         * tui/tui-source.c (tui_set_source_content)
 120         (tui_vertical_source_scroll): Remove unnecessary cast.
 121         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 122         cast.
 123         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 124         * tui/tui-regs.c (tui_display_registers_from)
 125         (tui_display_register): Remove unnecessary cast.
 126         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 127         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 128         (make_visible): Remove unnecessary cast.
 129         * tui/tui-winsource.c (tui_erase_source_content)
 130         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 131         unnecessary cast.
 132         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 133         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 134         * stabsread.c (read_type, read_array_type, read_range_type):
 135         Remove unnecessary cast.
 136         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 137         (parse_symbol, parse_type, upgrade_type, parse_external)
 138         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 139         unnecessary cast.
 140         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 141
 142 2019-06-16  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-data.c (tui_alloc_generic_win_info)
 145         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 146         checks.
 147
 148 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 149             Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * f-typeprint.c (f_print_type): Don't return early for not
 152         associated or not allocated types.
 153         (f_type_print_varspec_suffix): Add print_rank parameter and print
 154         ranks of array types in case they dangling.
 155         (f_type_print_base): Add print_rank parameter.
 156
 157 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * NEWS: Mention new MI commands.
 160         * break-catch-throw.c (enum exception_event_kind): Move to
 161         breakpoint.h.
 162         (print_mention_exception_catchpoint): Output text as a single
 163         message.
 164         (catch_exception_command_1): Rename to...
 165         (catch_exception_event): ...this, make non-static, update header
 166         command, and change some parameter types.
 167         (catch_catch_command): Update for changes to
 168         catch_exception_command_1.
 169         (catch_throw_command): Likewise.
 170         (catch_rethrow_command): Likewise.
 171         * breakpoint.c (enum exception_event_kind): Delete.
 172         * breakpoint.h (enum exception_event_kind): Moved here from
 173         break-catch-throw.c.
 174         (catch_exception_event): Declare.
 175         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 176         (mi_cmd_catch_throw): New function.
 177         (mi_cmd_catch_rethrow): New function.
 178         (mi_cmd_catch_catch): New function.
 179         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 180         'catch-catch' entries.
 181         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 182         (mi_cmd_catch_rethrow): Declare.
 183         (mi_cmd_catch_catch): Declare.
 184
 185 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * annotate.c (annotate_source_line): Change return type to void,
 188         update implementation to match.
 189         * annotate.h (annotate_source_line): Change return type to void,
 190         update header comment.
 191         * stack.c (print_frame_info): Don't change what frame information
 192         is printed based on whether annotations are on or not.
 193
 194 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 197         (annotate_source): Make static.
 198         (annotate_source_line): Moved from source.c and renamed from
 199         identify_source_line.  Update the return type.
 200         * annotate.h (annotate_source): Delete declaration.
 201         (annotate_source_line): Declaration moved from source.h, and
 202         renamed from identify_source_line.  Return type updated.
 203         * source.c (identify_source_line): Moved to annotate.c and renamed
 204         to annotate_source_line.
 205         (info_line_command): Remove check of annotation_level.
 206         * source.h (identify_source_line): Move declaration to annotate.h
 207         and rename to annotate_source_line.
 208         * stack.c: Add 'annotate.h' include.
 209         (print_frame_info): Remove check of annotation_level before
 210         calling annotate_source_line.
 211
 212 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * source-cache.c (source_cache::get_plain_source_lines): Use
 215         open_source_file_with_line_charpos instead of just
 216         open_source_file, remove call to find_source_lines.
 217         (source_cache::get_source_lines): Likewise.
 218         * source.c (find_source_lines): Make static.
 219         (get_filename_and_charpos): Renamed into...
 220         (open_source_file_with_line_charpos): ..this along with changes to
 221         return a scoped_fd, and some other minor clean ups.
 222         (identify_source_line): Use open_source_file_with_line_charpos.
 223         (search_command_helper): Use open_source_file_with_line_charpos
 224         instead of just open_source_file, remove call to
 225         find_source_lines.
 226         * source.h (open_source_file_with_line_charpos): Declare new
 227         function.
 228         (find_source_lines): Delete declaration.
 229
 230 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * source.c (get_filename_and_charpos): Remove fullname
 233         parameter.
 234         (identify_source_line): Update call to get_filename_and_charpos.
 235
 236 2019-06-14  Tom Tromey  <tromey@adacore.com>
 237
 238         PR gdb/24502:
 239         * ui-style.h (skip_ansi_escape): Update comment.
 240         * ui-file.h (class no_terminal_escape_file): New class.
 241         * ui-file.c (no_terminal_escape_file::write)
 242         (no_terminal_escape_file::puts): New methods.
 243         * cli/cli-logging.c (handle_redirections): Use
 244         no_terminal_escape_file.
 245
 246 2019-06-14  Tom Tromey  <tromey@adacore.com>
 247
 248         * NEWS: Move convenience variable news above Python news.
 249
 250 2019-06-14  Tom Tromey  <tom@tromey.com>
 251
 252         * gnulib: Move directory to top-level.
 253         * configure.ac: Don't configure gnulib.
 254         * configure: Rebuild.
 255         * common/common-defs.h: Use new path to gnulib.
 256         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 257         (GNULIB_H): Remove.
 258         (INCGNU): Look in new gnulib location.
 259         (HFILES_NO_SRCDIR): Remove gnulib files.
 260         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 261         (generated_files): Remove GNULIB_H.
 262         ($(LIBGNU), all-lib): Remove targets.
 263         (distclean): Don't mention GNULIB_BUILDDIR.
 264         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 265
 266 2019-06-14  Tom Tromey  <tromey@adacore.com>
 267
 268         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 269         Warn if symbol file does not provide any symbols.
 270
 271 2019-06-14  Tom Tromey  <tromey@adacore.com>
 272
 273         * source.c (find_and_open_source): Respect basenames_may_differ.
 274
 275 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * annotate.c (annotate_breakpoints_invalid): Make use of
 278         scoped_restore_terminal_state.
 279         (annotate_frames_invalid): Likewise.
 280
 281 2019-06-14  Tom Tromey  <tromey@adacore.com>
 282
 283         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 284         allow assignment to an internalvar.
 285
 286 2019-06-14  Tom Tromey  <tromey@adacore.com>
 287
 288         * ada-lex.l: Allow "_" in attribute names.
 289
 290 2019-06-14  Tom Tromey  <tromey@adacore.com>
 291
 292         PR gdb/24653:
 293         * regcache.c (registers_changed): Don't call alloca.
 294         * top.c (execute_command): Don't call alloca.
 295
 296 2019-06-13  Pedro Alves  <palves@redhat.com>
 297
 298         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 299         'expression'.  When parsing an expression, error out if there's
 300         junk after "unlimited".
 301         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 302         (do_set_command): Adjust calls to is_unlimited_literal.
 303
 304 2019-06-13  Pedro Alves  <palves@redhat.com>
 305
 306         * compile/compile.c (make_compile_options_def_group): Add braces
 307         around array_view initializer.
 308         * thread.c (make_thread_apply_all_options_def_group)
 309         (make_thread_apply_all_options_def_group): Likewise.
 310
 311 2019-06-13  Pedro Alves  <palves@redhat.com>
 312
 313         * NEWS (New commands): Mention "maint test-options
 314         require-delimiter", "maint test-options unknown-is-error", "maint
 315         test-options unknown-is-operand" and "maint show
 316         test-options-completion-result".
 317         (New command options, command completion): New section.
 318         (Completion improvements): New section.
 319         Mention that you can abbreviate "unlimited".
 320
 321 2019-06-13  Pedro Alves  <palves@redhat.com>
 322
 323         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 324         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 325         * unittests/cli-utils-selftests.c (test_parse_flags)
 326         (test_parse_flags_qcs): Delete.
 327         (test_cli_utils): Don't call deleted functions.
 328
 329 2019-06-13  Pedro Alves  <palves@redhat.com>
 330
 331         * thread.c: Include "cli/cli-option.h".
 332         (tp_array_compar_ascending): Global.
 333         (tp_array_compar): Delete function.
 334         (tp_array_compar_ascending, tp_array_compar_descending): New
 335         functions.
 336         (ascending_option_def, qcs_flag_option_def)
 337         (thr_qcs_flags_option_defs)
 338         (make_thread_apply_all_options_def_group)
 339         (make_thread_apply_options_def_group): New.
 340         (thread_apply_all_command): Use gdb::option::process_options.
 341         (thread_apply_command_completer)
 342         (thread_apply_all_command_completer): New.
 343         (thread_apply_command): Use gdb::option::process_options.
 344         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 345         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 346         to generate help text of "thread apply".  Adjust "taas"'s help.
 347         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 348         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 349
 350 2019-06-13  Pedro Alves  <palves@redhat.com>
 351
 352         * thread.c (thread_apply_command): Check for invalid TID with
 353         isdigit instead of !isalpha.
 354
 355 2019-06-13  Pedro Alves  <palves@redhat.com>
 356
 357         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 358         (validate_flags_qcs): New.
 359         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 360         (validate_flags_qcs): Declare.
 361         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 362         (make_frame_apply_options_def_group): New.
 363         (frame_apply_command_count): Process options with
 364         gdb::option::process_options.
 365         (frame_apply_completer): New.
 366         (frame_apply_level_completer, frame_apply_all_completer)
 367         (frame_apply_completer): New.
 368         (_initialize_stack): Update help of "frame apply", "frame apply
 369         level", "frame apply all" and "faas" to mention supported options
 370         and install command completers.
 371         * stack.h (frame_apply_all_completer): Declare.
 372         * thread.c: Include "stack.h".
 373         (tfaas_command): Add "--".
 374         (_initialize_thread): Update help "tfaas" to mention supported
 375         options and install command completer.
 376
 377 2019-06-13  Pedro Alves  <palves@redhat.com>
 378
 379         * completer.c (complete_nested_command_line): New.
 380         (gdb_completion_word_break_characters_throw): Add assertion.
 381         * completer.h (complete_nested_command_line): Declare.
 382
 383 2019-06-13  Pedro Alves  <palves@redhat.com>
 384
 385         * stack.c (parse_backtrace_qualifiers): New.
 386         (backtrace_command): Use it.
 387         (backtrace_command_completer): Complete on qualifiers.
 388
 389 2019-06-13  Pedro Alves  <palves@redhat.com>
 390
 391         * frame.c: Include "cli/cli-option.h.
 392         (user_set_backtrace_options): New.
 393         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 394         Delete.
 395         (get_prev_frame): Adjust.
 396         (boolean_option_def, uinteger_option_def)
 397         (set_backtrace_option_defs): New.
 398         (_initialize_frame): Adjust and use
 399         gdb::option::add_setshow_cmds_for_options to install "set
 400         backtrace past-main" and "set backtrace past-entry".
 401         * frame.h: Include "cli/cli-option.h".
 402         (struct frame_print_options): Forward declare.
 403         (print_frame_arguments_all, print_frame_arguments_scalars)
 404         (print_frame_arguments_none): Declare.
 405         (print_entry_values): Delete declaration.
 406         (struct frame_print_options, user_frame_print_options): New.
 407         (struct set_backtrace_options): New.
 408         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 409         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 410         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 411         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 412         (list_args_or_locals): Add frame_print_options parameter.
 413         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 414         * python/py-framefilter.c (enumerate_args): Pass down
 415         USER_FRAME_PRINT_OPTIONS.
 416         * stack.c: Include "cli/cli-option.h".
 417         (print_frame_arguments_all, print_frame_arguments_scalars)
 418         (print_frame_arguments_none): Declare.
 419         (print_raw_frame_arguments, print_entry_values): Delete.
 420         (user_frame_print_options): New.
 421         (boolean_option_def, enum_option_def, frame_print_option_defs):
 422         New.
 423         (struct backtrace_cmd_options): New.
 424         (bt_flag_option_def): New.
 425         (backtrace_command_option_defs): New.
 426         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 427         (print_frame_arg, read_frame_arg, print_frame_args)
 428         (print_frame_info, print_frame): Add frame_print_options parameter
 429         and use it.
 430         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 431         (backtrace_command_1): Add frame_print_options and
 432         backtrace_cmd_options parameters and use them.
 433         (make_backtrace_options_def_group): New.
 434         (backtrace_command): Process command options with
 435         gdb::option::process_options.
 436         (backtrace_command_completer): New.
 437         (_initialize_stack): Extend "backtrace"'s help to mention
 438         supported options.  Install completer for "backtrace".
 439         Install some settings commands with add_setshow_cmds_for_options.
 440
 441 2019-06-13  Pedro Alves  <palves@redhat.com>
 442
 443         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 444         and that "set/show print raw frame-arguments" are now deprecated.
 445
 446         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 447         command.
 448         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 449         * stack.c (_initialize_stack): Install "set/show print
 450         raw-frame-arguments", and deprecate "set/show print raw
 451         frame-arguments".
 452         * valprint.c (_initialize_valprint): Deprecate "set/show print
 453         raw".
 454
 455 2019-06-13  Pedro Alves  <palves@redhat.com>
 456
 457         * compile/compile.c (struct compile_options): New.
 458         (compile_flag_option_def, compile_command_option_defs)
 459         (make_compile_options_def_group): New.
 460         (compile_file_command): Handle options with
 461         gdb::option::process_options.
 462         (compile_file_command_completer): New function.
 463         (compile_code_command): Handle options with
 464         gdb::option::process_options.
 465         (compile_code_command_completer): New function.
 466         (_initialize_compiler): Install completers for "compile code" and
 467         "compile file".  Mention available options in "compile code" and
 468         "compile code"'s help.
 469         * completer.c (advance_to_completion_word): New, factored out from
 470         ...
 471         (advance_to_expression_complete_word_point): ... this.
 472         (advance_to_filename_complete_word_point): New.
 473         * completer.h (advance_to_filename_complete_word_point): New
 474         declaration.
 475
 476 2019-06-13  Pedro Alves  <palves@redhat.com>
 477
 478         * compile/compile.c: Include "cli/cli-option.h".
 479         (compile_print_value): Scope data pointer is now a
 480         value_print_options pointer; adjust.
 481         (compile_print_command): Process options.  Scope data pointer is
 482         now a value_print_options pointer; adjust.
 483         (_initialize_compile): Update "compile print"'s help to include
 484         supported options.  Install a completer for "compile print".
 485         * cp-valprint.c (show_vtblprint, show_objectprint)
 486         (show_static_field_print): Delete.
 487         (_initialize_cp_valprint): Don't install "set print
 488         static-members", "set print vtbl", "set print object" here.
 489         * printcmd.c: Include "cli/cli-option.h" and
 490         "common/gdb_optional.h".
 491         (print_command_parse_format): Rework to fill in a
 492         value_print_options instead of a format_data.
 493         (print_value): Change parameter type from format_data pointer to
 494         value_print_options reference.  Adjust.
 495         (print_command_1): Process options.  Adjust to pass down a
 496         value_print_options.
 497         (print_command_completer): New.
 498         (_initialize_printcmd): Install print_command_completer as
 499         handle_brkchars completer for the "print" command.  Update
 500         "print"'s help to include supported options.
 501         * valprint.c: Include "cli/cli-option.h".
 502         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 503         here from cp-valprint.c.
 504         (boolean_option_def, uinteger_option_def)
 505         (value_print_option_defs, make_value_print_options_def_group):
 506         New.  Use gdb::option::add_setshow_cmds_for_options to install
 507         "set print elements", "set print null-stop", "set print repeats",
 508         "set print pretty", "set print union", "set print array", "set
 509         print address", "set print symbol", "set print array-indexes".
 510         * valprint.h: Include <string> and "cli/cli-option.h".
 511         (make_value_print_options_def_group): Declare.
 512         (print_value): Change parameter type from format_data pointer to
 513         value_print_options reference.
 514         (print_command_completer): Declare.
 515
 516 2019-06-13  Pedro Alves  <palves@redhat.com>
 517
 518         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 519         (COMMON_SFILES): Add maint-test-settings.c.
 520         * cli/cli-decode.c (boolean_enums): New global, factored out from
 521         ...
 522         (add_setshow_boolean_cmd): ... here.
 523         * cli/cli-decode.h (boolean_enums): Declare.
 524         * cli/cli-option.c: New file.
 525         * cli/cli-option.h: New file.
 526         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 527         factored out from ...
 528         (parse_cli_boolean_value(const char *)): ... this.
 529         (is_unlimited_literal): Change parameter type to pointer to
 530         pointer.  Adjust and advance ARG pointer.
 531         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 532         (parse_cli_var_enum): New, factored out from ...
 533         (do_set_command): ... this.  Adjust.
 534         * cli/cli-setshow.h (parse_cli_boolean_value)
 535         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 536         (parse_cli_var_enum): Declare.
 537         * cli/cli-utils.c: Include "cli/cli-option.h".
 538         (get_ulongest): New.
 539         * cli/cli-utils.h (get_ulongest): Declare.
 540         (check_for_argument): New overloads.
 541         * maint-test-options.c: New file.
 542
 543 2019-06-13  Pedro Alves  <palves@redhat.com>
 544
 545         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 546         parse a range if "-" is at the end of the string.
 547
 548 2019-06-13  Pedro Alves  <palves@redhat.com>
 549
 550         * cli/cli-setshow.c (parse_auto_binary_operation)
 551         (parse_cli_boolean_value): Don't allow "o".
 552
 553 2019-06-13  Pedro Alves  <palves@redhat.com>
 554
 555         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 556         * NEWS: Mention maint test-settings KIND.
 557         * maint-test-settings.c: New file.
 558
 559 2019-06-13  Pedro Alves  <palves@redhat.com>
 560
 561         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 562         completer.
 563         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 564         "set" completers.
 565
 566 2019-06-13  Pedro Alves  <palves@redhat.com>
 567
 568         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 569         after item.
 570
 571 2019-06-13  Pedro Alves  <palves@redhat.com>
 572
 573         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 574
 575 2019-06-13  Pedro Alves <palves@redhat.com>
 576
 577         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 578         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 579         call.
 580         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 581         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 582         calls.
 583         (check_for_argument): Skip spaces after argument.
 584
 585 2019-06-13  Pedro Alves  <palves@redhat.com>
 586
 587         * thread.c (thread_apply_command): Adjust TID parsing.
 588         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 589         detected before end of string.
 590         (tid_is_in_list): Error out if LIST is invalid.
 591
 592 2019-06-13  Pedro Alves  <palves@redhat.com>
 593
 594         * completer.c (complete_line_internal_1): Rewind completion word
 595         point.
 596         (completion_tracker::advance_custom_word_point_by): Change
 597         parameter type to int.
 598         * completer.h (completion_tracker::advance_custom_word_point_by):
 599         Likewise.
 600
 601 2019-06-13  Pedro Alves  <palves@redhat.com>
 602
 603         * completer.c (advance_to_completion_word): Handle delimiters.
 604
 605 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 606
 607         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 608
 609 2019-06-11  Tom Tromey  <tom@tromey.com>
 610
 611         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 612         (xmalloc_failed): Move to alloc.c.
 613         * alloc.c: New file.
 614         * Makefile.in (COMMON_SFILES): Add alloc.c.
 615
 616 2019-06-11  Tom Tromey  <tom@tromey.com>
 617
 618         * nat/linux-waitpid.c: Don't include server.h.
 619         (linux_debug): Remove.
 620         (my_waitpid): Update.
 621
 622 2019-06-11  Tom Tromey  <tromey@adacore.com>
 623
 624         * infcall.c (_initialize_infcall): Remove trailing newline from
 625         help.
 626         * user-regs.c (_initialize_user_regs): Remove trailing newline
 627         from help.
 628         * typeprint.c (_initialize_typeprint): Remove trailing newline
 629         from help.
 630         * reverse.c (_initialize_reverse): Remove trailing newlines from
 631         help.
 632         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 633         from help.
 634         * language.c (add_set_language_command): Remove trailing newline
 635         from help.
 636         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 637         help.
 638         * disasm.c (_initialize_disasm): Remove trailing newline from
 639         help.
 640         * top.c (init_main): Remove trailing newline from help.
 641         * interps.c (_initialize_interpreter): Remove trailing newline
 642         from help.
 643         * btrace.c (_initialize_btrace): Remove trailing newlines from
 644         help.
 645         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 646         from help.
 647         * python/python.c (_initialize_python): Remove trailing newline
 648         from help.
 649         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 650         help.
 651         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 652         from help.  Reformat some text.
 653         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 654         from help.
 655         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 656         newline from help.
 657
 658 2019-06-11  Tom Tromey  <tromey@adacore.com>
 659
 660         * darwin-nat.c (darwin_decode_exception_message)
 661         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 662
 663 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * valops.c (value_slice): Check for not allocated or not
 666         associated values.
 667
 668 2019-06-10  Tom de Vries  <tdevries@suse.de>
 669
 670         PR gdb/24618
 671         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 672         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 673         invalid.
 674
 675 2019-06-10  Tom de Vries  <tdevries@suse.de>
 676
 677         PR gdb/24611
 678         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 679         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 680
 681 2019-06-10  Tom de Vries  <tdevries@suse.de>
 682
 683         PR symtab/24545
 684         * symtab.c (struct demangled_name_entry): Add language field.
 685         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 686         static minimal symbol".  Set and use language field.
 687
 688 2019-06-10  Tom Tromey  <tromey@adacore.com>
 689
 690         * ada-lang.c (_initialize_ada_language): Update help text.
 691
 692 2019-06-10  Tom Tromey  <tromey@adacore.com>
 693
 694         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 695         with a newline.
 696         * guile/guile.c (handle_boot_error): Don't end warning with a
 697         newline.
 698         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 699         warning with a newline.
 700         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 701         newline.
 702         (s12z_frame_cache): Likewise.
 703         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 704         a newline.
 705         * solib-svr4.c (disable_probes_interface): Don't end warning with
 706         a newline.
 707         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 708         newline.
 709         * python/python.c (do_finish_initialization): Don't end warning
 710         with a newline.
 711
 712 2019-06-10  Tom Tromey  <tom@tromey.com>
 713
 714         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 715         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 716         gdbpy_enter.
 717
 718 2019-06-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 721         data.
 722         (elf_new_init): Don't call stabsread_new_init.
 723         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 724         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 725         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 726
 727 2019-06-10  Tom de Vries  <tdevries@suse.de>
 728
 729         PR symtab/16264
 730         PR symtab/24517
 731         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 732
 733 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 734
 735         * source.c (find_and_open_source): Also rewrite relative file
 736         names.
 737
 738 2019-04-26  Amos Bird  <amosbird@gmail.com>
 739
 740         * annotate.c (annotate_thread_exited): Add "thread-exited"
 741         annotation.
 742
 743 2019-06-06  Tom Tromey  <tromey@adacore.com>
 744
 745         * maint.h (class scoped_command_stats): Use
 746         DISABLE_COPY_AND_ASSIGN.
 747         <print_time>: New method.
 748         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 749         print_time.
 750         (scoped_command_stats::print_time): New method.
 751
 752 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 755         instructions of lengths 6 or 8 bytes.
 756
 757 2019-06-04  Pedro Alves  <palves@redhat.com>
 758
 759         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 760
 761         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 762         * breakpoint.c (condition_completer): Likewise.
 763         * cli/cli-dump.c (scan_expression): Likewise.
 764         * common/filestuff.c (mkdir_recursive): Likewise.
 765         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 766         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 767         (gdb_abspath): Likewise.
 768         * compile/compile-cplus-types.c
 769         (compile_cplus_instance::decl_name): Likewise.
 770         * completer.c (complete_explicit_location):
 771         (signal_completer, reg_or_group_completer_1): Likewise.
 772         * cp-support.c (cp_remove_params_if_any): Likewise.
 773         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 774         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 775         * infcmd.c (strip_bg_char): Likewise.
 776         * linespec.c (copy_token_string): Likewise.
 777         * mi/mi-main.c (output_cores): Likewise.
 778         * psymtab.c (psymtab_search_name):
 779         * symfile.c (test_set_ext_lang_command): Likewise.
 780         * target.c (target_fileio_read_stralloc): Likewise.
 781         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 782         * value.c (complete_internalvar): Likewise.
 783
 784 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 785
 786         Add objfile property to gdb.Type.
 787         * NEWS: Mention Python API addition.
 788         * python/py-type.c (typy_get_objfile): New method.
 789
 790 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * NEWS: Mention the new set|show style [title|highlight].
 793         Mention changes to "show style", "help" and "apropos".
 794
 795 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 796
 797         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 798         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 799         instead of print_help_for_command.
 800         (print_doc_of_command): New function.
 801         (help_list): Add 'apropos -v word' suggestion.
 802         (print_help_for_command): Style the command name using title style.
 803         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 804         (_initialize_cli_cmds): Describe -v in apropos_command help.
 805
 806 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 807
 808         * cli/cli-style.h (cli_style_option): Add name in constructor,
 809         add m_name class member, add constructor with intensity,
 810         add name class function.
 811         (cli_style_option::add_setshow_commands): Remove name argument.
 812         (highlight_style, title_style): New styles.
 813         * cli/cli-style.c (do_show): New function that shows a style
 814         characteristic styling the style name with itself.
 815         (set_style_name): New function.
 816         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 817         Update all callers according to the changes in cli/cli-style.h.
 818         * utils.h (fputs_highlighted): New function.
 819         * utils.c (fputs_highlighted): Likewise.
 820
 821 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 822
 823         * NEWS: Mention new pipe command and new convenience variables.
 824
 825 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 826
 827         * cli/cli-cmds.c (pipe_command): New function.
 828         (_initialize_cli_cmds): Call add_com for pipe_command.
 829         Define | as an alias for pipe.
 830         (exit_status_set_internal_vars): New function.
 831         (shell_escape): Call exit_status_set_internal_vars.
 832         cli/cli-decode.c (find_command_name_length): Recognize | as
 833         a single character command.
 834
 835 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 838         top.c (execute_command_to_ui_file): New function, mostly a copy
 839         of execute_command_to_string.
 840         (execute_command_to_string): Implement by calling
 841         execute_command_to_ui_file.
 842
 843 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 844
 845         * top.h (saved_command_line): Remove declaration.
 846         * top.c (previous_saved_command_line, previous_repeat_arguments):
 847         New variables.
 848         (saved_command_line): Make static, define together with other
 849         'repeat variables'.
 850         (dont_repeat): Clear repeat_arguments.
 851         (repeat_previous, get_saved_command_line, save_command_line):
 852         New functions.
 853         (gdb_init): Initialize saved_command_line
 854         and previous_saved_command_line.
 855         * main.c (captured_main_1): Remove saved_command_line initialization.
 856         * event-top.c (handle_line_of_input): Update to use
 857         the new 'repeat' related functions instead of direct access to
 858         saved_command_line.
 859         * command.h (repeat_previous, get_saved_command_line,
 860         save_command_line): New declarations.
 861         (dont_repeat): Add comment.
 862
 863 2019-05-30  Tom Tromey  <tromey@adacore.com>
 864
 865         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 866         Fix comment.
 867         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 868
 869 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 870
 871         PR cli/24587
 872         * completer.c (complete): Initialize variable word.
 873
 874 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 875
 876         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 877         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 878         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 879         'body' is NULL to the outter 'if', protecting the '!is_define'
 880         situation as well.
 881
 882 2019-05-29  Tom Tromey  <tromey@adacore.com>
 883
 884         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 885         (dwarf_unknown): New function.
 886         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 887         (dwarf_type_encoding_name): Use dwarf_unknown.
 888
 889 2019-05-29  Tom Tromey  <tromey@adacore.com>
 890
 891         PR c++/20020:
 892         * cp-valprint.c (cp_print_value_fields): Call
 893         cp_print_static_field inside "try".
 894
 895 2019-05-29  Tom Tromey  <tromey@adacore.com>
 896
 897         * inflow.c (struct terminal_info): Add default operator=.
 898         * configure: Rebuild.
 899         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 900         -Wdeprecated-copy-dtor, -Wredundant-move.
 901
 902 2019-05-29  Tom Tromey  <tromey@adacore.com>
 903
 904         * NEWS: Add entry.
 905         * infcmd.c (print_return_value_1): Handle finish_print
 906         option.
 907         (show_print_finish): New function.
 908         (_initialize_infcmd): Add "set/show print finish" commands.
 909         * valprint.c (user_print_options): Initialize new member.
 910         * valprint.h (struct value_print_options) <finish_print>: New
 911         member.
 912
 913 2019-05-28  Tom Tromey  <tromey@adacore.com>
 914
 915         * ada-lang.c (ada_remove_Xbn_suffix)
 916         (find_old_style_renaming_symbol)
 917         (parse_old_style_renaming): Remove.
 918         (ada_find_renaming_symbol): Don't call
 919         find_old_style_renaming_symbol.
 920         (ada_is_renaming_symbol): Rename from
 921         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 922         bool.  Now static.
 923         (ada_read_var_value): Update and simplify.
 924         * ada-exp.y (write_var_or_type): Remove old code.
 925
 926 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 927
 928         * event-top.c: Remove include comment.
 929         * inflow.c (class scoped_ignore_sigttou): Move from here...
 930         * inflow.h (class scoped_ignore_sigttou): ...to here.
 931         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 932         * top.c:  Remove include comment.
 933
 934 2019-05-27  Tom Tromey  <tom@tromey.com>
 935
 936         * NEWS: Fix typo.
 937
 938 2019-05-22  Tom Tromey  <tromey@adacore.com>
 939
 940         * target.c (target_follow_exec): Constify parameter.
 941         * target-delegates.c: Rebuild.
 942         * remote.c (remote_target::follow_exec): Constify parameter.
 943         * infrun.c (follow_exec): Constify parameter.
 944         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 945         (target_follow_exec): Likewise.
 946
 947 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 950         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 951
 952 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 953
 954         * NEWS: Add debugredirect and testsuite sections.
 955
 956 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 957
 958         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 959         target descriptions using exclusively floating point register name
 960         aliases.
 961
 962 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         PR gdb/18644:
 965         * f-lang.c (build_fortran_types): Handle the case where
 966         gdbarch_floatformat_for_type returns a nullptr.
 967
 968 2019-05-21  Tom de Vries  <tdevries@suse.de>
 969
 970         PR cli/24587
 971         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 972
 973 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         PR gdb/18644:
 976         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 977         16-byte floats.
 978         * i386-tdep.c (i386_floatformat_for_type): Use
 979         floatformats_ia64_quad for the 16-byte floating point component
 980         within a fortran 32-byte complex number.
 981
 982 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 985         delete default constructor.
 986         (find_partial_die): Update to return const struct.
 987         (partial_die_parent_scope): Move variable declaration into scope
 988         of its use and change its type to auto.
 989         (guess_partial_die_structure_name): Likewise.
 990         (partial_die_info::fixup): Likewise.
 991
 992 2019-05-17  Tom Tromey  <tromey@adacore.com>
 993
 994         * source.c (find_and_open_source): Remove cast.
 995
 996 2019-05-17  Tom Tromey  <tromey@adacore.com>
 997
 998         * annotate.c (annotate_source): Make "filename" const.
 999         * annotate.h (annotate_source): Use const.
1000
1001 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1002
1003         * disasm.c (set_disassembler_options): Send errors to stderr.
1004
1005 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1006
1007         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1008         (cli_interp_base::set_logging): Check debug_redirect.
1009         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1010         * cli/cli-logging.c (debug_redirect): Add static variable.
1011         (pop_output_files): Add default param.
1012         (handle_redirections): Print debug setting.
1013         (show_logging_command): Likewise.
1014         (_initialize_cli_logging): Add debugredirect command.
1015         * interps.c (current_interp_set_logging): Add debug_redirect
1016         parameter.
1017         * interps.h (set_logging): Add debug_redirect parameter.
1018         (current_interp_set_logging): Likewise.
1019         * mi/mi-common.h: Likewise.
1020         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1021
1022 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1023             Tom Tromey  <tromey@adacore.com>
1024
1025         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1026         directly.
1027         * cli/cli-interp.h (make_logging_output): Remove declaration.
1028         * cli/cli-logging.c (make_logging_output): Remove function.
1029         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1030         directly.
1031         * ui-file.c (tee_file::tee_file): Remove bools.
1032         (tee_file::~tee_file): Remove deletes.
1033         * ui-file.h (tee_file): Remove bools.
1034
1035 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1036
1037         * mi/mi-cmds.h (mi_cmd_complete): New function.
1038         * mi/mi-main.c (mi_cmd_complete): Likewise.
1039         * mi/mi-cmds.c: Define new MI command -complete.
1040         * NEWS: Mention new -complete command.
1041
1042 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1043
1044         * completer.h (complete): New function.
1045         * completer.c (complete): Likewise.
1046         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1047         function defined in completer.h.
1048
1049 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1050
1051         * MAINTAINERS (Write After Approval): Add myself.
1052
1053 2019-05-17  Tom de Vries  <tdevries@suse.de>
1054
1055         PR gdb/24094
1056         * dwarf2read.c (struct cu_partial_die_info): New struct.
1057         (find_partial_die): Return cu_partial_die_info.
1058         (partial_die_parent_scope, guess_partial_die_structure_name)
1059         (partial_die_info::fixup): Handle new return type of find_partial_die.
1060
1061 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1062
1063         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1064         "std::string", simplifying the algorithm.
1065
1066 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1067
1068         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1069         (stap_static_probe_ops::get_probes): Likewise.
1070
1071 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1072
1073         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1074         '-')" and "else if".
1075         (stap_parse_single_operand): Join checks for
1076         "gdbarch_stap_parse_special_token_p" and
1077         "gdbarch_stap_parse_special_token" in the same "if" statement.
1078         Invert check when verifying for operation on register
1079         displacement.
1080
1081 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1082
1083         * stap-probe.c (stap_get_opcode): Update comment.
1084         (stap_get_expected_argument_type): Likewise.
1085         (handle_stap_probe): Likewise.
1086
1087 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1088
1089         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1090         return type to 'bool'.  Adjust comment.  Use 'bool' when
1091         appropriate.
1092         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1093         * stap-probe.c (stap_parse_argument_1): Likewise.
1094         (stap_is_operator): Likewise.
1095         (stap_is_generic_prefix): Likewise.
1096         (stap_is_register_prefix): Likewise.
1097         (stap_is_register_indirection_prefix): Likewise.
1098         (stap_is_integer_prefix): Likewise.
1099         (stap_generic_check_suffix): Likewise.
1100         (stap_check_integer_suffix): Likewise.
1101         (stap_check_register_suffix): Likewise.
1102         (stap_check_register_indirection_suffix): Likewise.
1103         (stap_parse_register_operand): Likewise.
1104         (stap_parse_single_operand): Likewise.
1105         (stap_parse_argument_1): Likewise.
1106         (stap_probe::get_argument_count): Likewise.
1107         (stap_is_operator): Likewise.
1108
1109 2019-05-16  Tom Tromey  <tromey@adacore.com>
1110
1111         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1112         keyword to foreach.
1113
1114 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1115
1116         * linux-thread-db.c (try_thread_db_load_1): Change return type
1117         to bool.
1118         (try_thread_db_load): Likewise.
1119         (try_thread_db_load_from_pdir_1): Likewise.
1120         (try_thread_db_load_from_pdir): Likewise.
1121         (try_thread_db_load_from_sdir): Likewise.
1122         (try_thread_db_load_from_dir): Likewise.
1123         (thread_db_load_search): Likewise.
1124         (has_libpthread): Likewise.
1125         (thread_db_load): Likewise.
1126
1127 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1128
1129         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1130         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1131         NULL, and complain/return if that's the case.
1132
1133 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1134
1135         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1136         (advance, posn, abstract_read_memory): New functions.
1137         [struct mem_read_abstraction]: New struct.
1138         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1139
1140 2019-05-14  Tom Tromey  <tromey@adacore.com>
1141
1142         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1143         value is not lval_memory.
1144
1145 2019-05-14  Tom Tromey  <tromey@adacore.com>
1146
1147         * solib.c (info_sharedlibrary_command): Style the file name.
1148
1149 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1150
1151         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1152         (aarch64_vnv_type): Likewise.
1153         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1154         * common/tdesc.c: Likewise.
1155         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1156         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1157         * features/aarch64-fpu.xml: Add ieee half view.
1158         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1159         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1160         * gdbtypes.h (struct builtin_type): Likewise.
1161         (struct objfile_type): Likewise.
1162
1163 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1164
1165         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1166         typo.
1167         * location.h (string_to_event_location): Likewise.
1168
1169 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1170
1171         GDB 8.3 released.
1172
1173 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1174
1175         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1176         New variable declaration.
1177         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1178         New variable.
1179         (print_one_breakpoint): Use ui_out::test_flags and new global
1180         variable to compute use_fixed_output.
1181         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1182         Remove.
1183         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1184         (mi_multi_location_breakpoint_output_fixed): Remove.
1185         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1186         new variable.
1187         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1188         fix_multi_location_breakpoint_output flag if version >= 3.
1189         * ui-out.h (enum ui_out_flag)
1190         <fix_multi_location_breakpoint_output>: New enumerator.
1191
1192 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1193
1194         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1195
1196 2019-05-10  Tom Tromey  <tromey@adacore.com>
1197
1198         * ada-lang.c (catch_ada_completer): New function.
1199         (_initialize_ada_language): Use it.
1200
1201 2019-05-10  Tom Tromey  <tromey@adacore.com>
1202
1203         * thread.c (print_thread_info): Make "requested_threads" const.
1204         * gdbthread.h (print_thread_info): Make "requested_threads"
1205         const.
1206         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1207         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1208
1209 2019-05-08  Tom Tromey  <tom@tromey.com>
1210
1211         * gdbtypes.c (objfile_type_data): Change type.
1212         (objfile_type, _initialize_gdbtypes): Update.
1213
1214 2019-05-08  Tom Tromey  <tom@tromey.com>
1215
1216         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1217         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1218         (_initialize_dwarf2_frame): Update.
1219
1220 2019-05-08  Tom Tromey  <tom@tromey.com>
1221
1222         * objc-lang.c (objc_objfile_data): Change type.
1223         (find_methods): Update.
1224         (_initialize_objc_lang): Remove.
1225
1226 2019-05-08  Tom Tromey  <tom@tromey.com>
1227
1228         * stabsread.c (rs6000_builtin_type_data): Change type.
1229         (rs6000_builtin_type, _initialize_stabsread): Update.
1230
1231 2019-05-08  Tom Tromey  <tom@tromey.com>
1232
1233         * mips-tdep.c (mips_pdr_data): Remove.
1234         (_initialize_mips_tdep): Update.
1235
1236 2019-05-08  Tom Tromey  <tom@tromey.com>
1237
1238         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1239         (hppa_init_objfile_priv_data, read_unwind_info)
1240         (find_unwind_entry, _initialize_hppa_tdep): Update.
1241
1242 2019-05-08  Tom Tromey  <tom@tromey.com>
1243
1244         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1245         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1246         on obstack.
1247         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1248
1249 2019-05-08  Tom Tromey  <tom@tromey.com>
1250
1251         * mdebugread.c (basic_type_data): Change type.
1252         (basic_type, _initialize_mdebugread): Update.
1253
1254 2019-05-08  Tom Tromey  <tom@tromey.com>
1255
1256         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1257
1258 2019-05-08  Tom Tromey  <tom@tromey.com>
1259
1260         * nto-tdep.c (nto_inferior_data_reg): Change type.
1261         (nto_inferior_data): Update.
1262         (nto_inferior_data_cleanup, nto_new_inferior_data)
1263         (_initialize_nto_tdep): Remove.
1264         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1265
1266 2019-05-08  Tom Tromey  <tom@tromey.com>
1267
1268         * ada-lang.c (struct ada_inferior_data): Add initializers.
1269         (ada_inferior_data): Change type.
1270         (ada_inferior_data_cleanup): Remove.
1271         (get_ada_inferior_data, ada_inferior_exit)
1272         (struct ada_pspace_data): Add initializers, destructor.
1273         (ada_pspace_data_handle): Change type.
1274         (get_ada_pspace_data): Update.
1275         (ada_pspace_data_cleanup): Remove.
1276
1277 2019-05-08  Tom Tromey  <tom@tromey.com>
1278
1279         * coffread.c (struct coff_symfile_info): Add initializers.
1280         (coff_objfile_data_key): Move lower.  Change type.
1281         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1282         Update.
1283         (coff_free_info): Remove.
1284
1285 2019-05-08  Tom Tromey  <tom@tromey.com>
1286
1287         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1288         (fbsd_pspace_data_handle): Move lower.  Change type.
1289         (get_fbsd_pspace_data): Update.
1290         (fbsd_pspace_data_cleanup): Remove.
1291         (_initialize_fbsd_tdep): Update.
1292
1293 2019-05-08  Tom Tromey  <tom@tromey.com>
1294
1295         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1296         (get_ada_tasks_pspace_data): Update.
1297         (ada_tasks_pspace_data_cleanup): Remove.
1298         (_initialize_tasks): Update.
1299         (ada_tasks_inferior_data_handle): Change type.
1300         (get_ada_tasks_inferior_data): Update.
1301         (ada_tasks_inferior_data_cleanup): Remove.
1302         (struct ada_tasks_pspace_data): Add initializers.
1303
1304 2019-05-08  Tom Tromey  <tom@tromey.com>
1305
1306         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1307         * symfile-debug.c (debug_sym_get_probes): Change type.
1308         * stap-probe.c (handle_stap_probe):
1309         (stap_static_probe_ops::get_probes): Change type.
1310         * probe.h (class static_probe_ops) <get_probes>: Change type.
1311         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1312         (parse_probes_in_pspace): Update.
1313         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1314         Update.
1315         (any_static_probe_ops::get_probes): Change type.
1316         * elfread.c (elfread_data): New typedef.
1317         (probe_key): Change type.
1318         (elf_get_probes): Likewise.  Update.
1319         (probe_key_free): Remove.
1320         (_initialize_elfread): Update.
1321         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1322         Change type.
1323         (dtrace_process_dof_probe, dtrace_process_dof)
1324         (dtrace_static_probe_ops::get_probe): Change type.
1325
1326 2019-05-08  Tom Tromey  <tom@tromey.com>
1327
1328         * xcoffread.c (struct xcoff_symfile_info): Rename from
1329         coff_symfile_info.  Add initializers.
1330         (xcoff_objfile_data_key): Move lower.  Change type.
1331         (XCOFF_DATA): Rewrite.
1332         (xcoff_free_info): Remove.
1333         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1334         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1335         (xcoff_initial_scan): Update.
1336
1337 2019-05-08  Tom Tromey  <tom@tromey.com>
1338
1339         * solib-svr4.c (struct svr4_info): Add initializers and
1340         destructor.
1341         <probes_table>: Now an htab_up.
1342         (solib_svr4_pspace_data): Change type.
1343         (free_probes_table): Simplify.
1344         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1345         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1346         (probes_table_remove_objfile_probes, register_solib_event_probe)
1347         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1348         (_initialize_svr4_solib): Update.
1349
1350 2019-05-08  Tom Tromey  <tom@tromey.com>
1351
1352         * remote.c (remote_pspace_data): Change type.
1353         (remote_pspace_data_cleanup): Remove.
1354         (get_remote_exec_file, set_pspace_remote_exec_file)
1355         (_initialize_remote): Update.
1356
1357 2019-05-08  Tom Tromey  <tom@tromey.com>
1358
1359         * breakpoint.c (breakpoint_objfile_key): Change type.
1360         (get_breakpoint_objfile_data): Update.
1361         (free_breakpoint_objfile_data): Remove.
1362         (_initialize_breakpoint): Update.
1363
1364 2019-05-08  Tom Tromey  <tom@tromey.com>
1365
1366         * linux-tdep.c (struct linux_info): Add initializers.
1367         (linux_inferior_data): Move.  Change type.
1368         (invalidate_linux_cache_inf): Update.
1369         (linux_inferior_data_cleanup): Remove.
1370         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1371
1372 2019-05-08  Tom Tromey  <tom@tromey.com>
1373
1374         * auxv.c (auxv_inferior_data): Move.  Change type.
1375         (auxv_inferior_data_cleanup): Remove.
1376         (invalidate_auxv_cache_inf): Rewrite.
1377         (get_auxv_inferior_data, _initialize_auxv): Update.
1378
1379 2019-05-08  Tom Tromey  <tom@tromey.com>
1380
1381         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1382         (symfile_debug_objfile_data_key): Change type.
1383         (symfile_debug_installed, debug_qf_has_symbols)
1384         (debug_qf_find_last_source_symtab)
1385         (debug_qf_forget_cached_source_info)
1386         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1387         (debug_qf_print_stats, debug_qf_dump)
1388         (debug_qf_expand_symtabs_for_function)
1389         (debug_qf_expand_all_symtabs)
1390         (debug_qf_expand_symtabs_with_fullname)
1391         (debug_qf_map_matching_symbols)
1392         (debug_qf_expand_symtabs_matching)
1393         (debug_qf_find_pc_sect_compunit_symtab)
1394         (debug_qf_map_symbol_filenames)
1395         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1396         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1397         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1398         (debug_sym_read_linetable, debug_sym_relocate): Update.
1399         (symfile_debug_free_objfile): Remove.
1400         (install_symfile_debug_logging, _initialize_symfile_debug):
1401         Update.
1402
1403 2019-05-08  Tom Tromey  <tom@tromey.com>
1404
1405         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1406         allocate_on_obstack.
1407         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1408         (get_dwarf2_per_objfile): Update.
1409         (set_dwarf2_per_objfile): Remove.
1410         (dwarf2_has_info, dwarf2_get_section_info): Update.
1411         (dwarf2_free_objfile): Remove.
1412         (_initialize_dwarf2_read): Update.
1413
1414 2019-05-08  Tom Tromey  <tom@tromey.com>
1415
1416         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1417         initializers.
1418         <unsupported_script_warning_printed,
1419         script_not_found_warning_printed>: Now bool.
1420         (auto_load_pspace_data): Change type.
1421         (~auto_load_pspace_info): Rename from
1422         auto_load_pspace_data_cleanup.
1423         (get_auto_load_pspace_data, init_loaded_scripts_info)
1424         (clear_section_scripts, maybe_print_unsupported_script_warning)
1425         (maybe_print_script_not_found_warning, _initialize_auto_load):
1426         Update.
1427
1428 2019-05-08  Tom Tromey  <tom@tromey.com>
1429
1430         * objfiles.c (objfile_pspace_info): Add destructor and
1431         initializers.
1432         (objfiles_pspace_data): Change type.
1433         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1434         (get_objfile_pspace_data): Update.
1435         (objfiles_bfd_data): Change type.
1436         (get_objfile_bfd_data): Update.
1437         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1438
1439 2019-05-08  Tom Tromey  <tom@tromey.com>
1440
1441         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1442         Change type.
1443         (get_catch_syscall_inferior_data): Update.
1444         (catch_syscall_inferior_data_cleanup): Remove.
1445         (_initialize_break_catch_syscall): Update.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * inflow.c (struct terminal_info): Add destructor and
1450         initializers.
1451         (inflow_inferior_data): Change type.
1452         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1453         (get_inflow_inferior_data, inflow_inferior_exit)
1454         (swap_terminal_info, _initialize_inflow): Update.
1455
1456 2019-05-08  Tom Tromey  <tom@tromey.com>
1457
1458         * target-dcache.c (target_dcache_cleanup): Remove.
1459         (target_dcache_aspace_key): Change type.
1460         (target_dcache_init_p, target_dcache_invalidate)
1461         (target_dcache_get, target_dcache_get_or_init)
1462         (_initialize_target_dcache): Update.
1463         * dcache.h (struct dcache_deleter): New.
1464
1465 2019-05-08  Tom Tromey  <tom@tromey.com>
1466
1467         * symtab.c (struct symbol_cache): Add destructor and
1468         initializers.
1469         (symbol_cache_key): Move.  Change type.
1470         (make_symbol_cache, free_symbol_cache): Remove.
1471         (get_symbol_cache): Update.
1472         (symbol_cache_cleanup): Remove.
1473         (ALL_PSPACES, symbol_cache_flush)
1474         (maintenance_print_symbol_cache)
1475         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1476         Update.
1477
1478 2019-05-08  Tom Tromey  <tom@tromey.com>
1479
1480         * symtab.c (struct main_info): Add destructor and initializers.
1481         (main_progspace_key): Move.  Change type.
1482         (get_main_info): Update.
1483         (main_info_cleanup): Remove.
1484         (_initialize_symtab): Update.
1485
1486 2019-05-08  Tom Tromey  <tom@tromey.com>
1487
1488         * registry.h (DECLARE_REGISTRY): Define the _key class.
1489
1490 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * NEWS: Merge two 'New commands' sections.
1493
1494 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1495
1496         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1497         parameter and use Ada language definition instead.
1498         (ada_val_print_ptr): Remove unused language parameter.
1499         (ada_val_print_num): Remove language parameter and use Ada language
1500         definition instead.
1501         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1502         parameter.
1503         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1504         parameter and use Ada language definition instead.
1505         (ada_val_print_1): Update all ada_val_print_xxx calls.
1506         Remove language parameter.
1507         (ada_val_print): Update ada_val_print_1 call.
1508
1509 2019-05-08  Tom Tromey  <tromey@adacore.com>
1510
1511         * remote.c (remote_hw_watchpoint_limit)
1512         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1513         Now static.
1514
1515 2019-05-08  Tom Tromey  <tromey@adacore.com>
1516
1517         * maint.c (_initialize_maint_cmds): Move initialization code to
1518         remote.c.
1519         (watchdog, show_watchdog): Move to remote.c.
1520         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1521         "watchdog" static.
1522         (_initialize_remote): Move initialization code from maint.c.
1523         * defs.h (watchdog): Don't declare.
1524
1525 2019-05-08  Tom Tromey  <tromey@adacore.com>
1526
1527         * tui/tui-interp.c: Include main.h.
1528         * interps.c: Include main.h.
1529         * main.h (interpreter_p): Declare.
1530         * defs.h (interpreter_p): Don't declare.
1531
1532 2019-05-08  Tom Tromey  <tromey@adacore.com>
1533
1534         * dwarf2loc.c: Include dwarf2read.h.
1535         * defs.h (read_unsigned_leb128): Don't declare.
1536         * dwarf2read.h (read_unsigned_leb128): Declare.
1537
1538 2019-05-08  Tom Tromey  <tromey@adacore.com>
1539
1540         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1541         method.
1542
1543 2019-05-08  Tom Tromey  <tromey@adacore.com>
1544
1545         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1546         when no wrap column is set.
1547
1548 2019-05-08  Tom Tromey  <tromey@adacore.com>
1549
1550         * c-lang.c (c_get_string): Handle non-C-style arrays.
1551
1552 2019-05-08  Tom Tromey  <tromey@adacore.com>
1553
1554         * typeprint.c (print_offset_data::update): Print the bit offset,
1555         not the number of bits remaining.
1556
1557 2019-05-08  Tom Tromey  <tromey@adacore.com>
1558
1559         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1560         padding at end of comment.
1561
1562 2019-05-08  Tom Tromey  <tromey@adacore.com>
1563
1564         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1565         Compare main types.
1566
1567 2019-05-06  Tom Tromey  <tom@tromey.com>
1568
1569         * common/scoped_mmap.c: Include common-defs.h.
1570         * common/scoped_mmap.h: Don't include config.h.
1571
1572 2019-05-04  Tom Tromey  <tom@tromey.com>
1573
1574         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1575         (struct aarch64_call_info): Add initializers.
1576         <si>: Now a std::vector.
1577         (pass_on_stack, aarch64_push_dummy_call): Update.
1578
1579 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1580             Tom Tromey  <tom@tromey.com>
1581
1582         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1583         (ppc_threads): Now a std::vector.  Now static.
1584         (hwdebug_find_thread_points_by_tid)
1585         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1586         Update.
1587
1588 2019-05-04  Tom Tromey  <tom@tromey.com>
1589
1590         * arc-tdep.c (arc_tdesc_init): Return bool.
1591
1592 2019-05-04  Tom Tromey  <tom@tromey.com>
1593
1594         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1595         Use gdb_assert_not_reached.
1596
1597 2019-05-04  Tom Tromey  <tom@tromey.com>
1598
1599         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1600         "false".
1601
1602 2019-05-04  Tom Tromey  <tom@tromey.com>
1603
1604         * arc-tdep.c (arc_tdesc_init): Use bool.
1605
1606 2019-05-04  Tom Tromey  <tom@tromey.com>
1607
1608         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1609
1610 2019-05-04  Tom Tromey  <tom@tromey.com>
1611
1612         * cli/cli-cmds.c (valid_command_p): Return bool.
1613
1614 2019-05-04  Tom Tromey  <tom@tromey.com>
1615
1616         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1617         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1618
1619 2019-05-04  Raul Tambre  <raul@tambre.ee>
1620
1621         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1622         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1623         operator for comparison.
1624
1625 2019-05-04  Tom Tromey  <tom@tromey.com>
1626
1627         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1628         (lookup_partial_symbol, print_partial_symbols)
1629         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1630         (psymbol_compare): Update.
1631         (add_psymbol_to_bcache): Clear the entire psymbol.
1632         (maintenance_check_psymtabs): Update.
1633         * psympriv.h (struct partial_symbol): Don't derive from
1634         general_symbol_info.
1635         <obj_section, unrelocated_address, address,
1636         set_unrelocated_address>: Update.
1637         <ginfo>: New member.
1638         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1639         (debug_names::write_psymbols): Update.
1640
1641 2019-05-04  Tom de Vries  <tdevries@suse.de>
1642
1643         * contrib/cc-with-tweaks.sh: Support -n arg.
1644
1645 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1646
1647         * corelow.c (core_target::detach): Ensure frame cache and
1648         register caches are cleared.
1649         inferior.c (exit_inferior_1): Likewise.
1650
1651 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1652             Tom Tromey  <tom@tromey.com>
1653
1654         * dictionary.c (collate_pending_symbols_by_language): Remove
1655         "struct" from foreach.
1656         * symtab.c (lookup_global_symbol_from_objfile)
1657         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1658         foreach.
1659         * ser-tcp.c (net_open): Remove "struct" from foreach.
1660         * objfiles.c (objfile_relocate, objfile_rebase)
1661         (objfile_has_symbols): Remove "struct" from foreach.
1662         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1663         from foreach.
1664         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1665         foreach.
1666         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1667         "struct" from foreach.
1668         * ada-lang.c (create_excep_cond_exprs)
1669         (ada_exception_catchpoint_cond_string): Remove "struct" from
1670         foreach.
1671
1672 2019-05-03  Tom Tromey  <tromey@adacore.com>
1673
1674         * ada-exp.y (convert_char_literal): Check suffix of each
1675         enumerator.
1676
1677 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1678
1679         PR ada/21406:
1680         * ada-exp.y (yywrap): Don't define.
1681         * ada-lex.l (%option): Add noyywrap
1682         (yywrap): Remove.
1683
1684 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1685
1686         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1687         _WIN32_WINNT to the XP level, unless already defined to a higher
1688         level.
1689
1690         * unittests/parse-connection-spec-selftests.c:
1691         * ser-tcp.c:
1692         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1693         override.
1694
1695         * symfile.c (find_separate_debug_file): Remove colon from the
1696         drive spec of DOS/Windows file names of the target, so that the
1697         file name produced from DEBUGDIR and the target's directory will
1698         be valid on DOS/Windows systems.
1699
1700 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1701
1702         * rust-lang.c (val_print_struct): Handle printing structures
1703         containing strings.
1704
1705 2019-05-02  Tom Tromey  <tromey@adacore.com>
1706
1707         * valarith.c (_initialize_valarith): Remove.
1708
1709 2019-05-01  Tom Tromey  <tromey@adacore.com>
1710
1711         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1712         bitfields.
1713
1714 2019-05-01  Tom Tromey  <tromey@adacore.com>
1715
1716         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1717         for big-endian copies.
1718
1719 2019-04-30  Ali Tamur  <tamur@google.com>
1720         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1721         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1722         (read_3_bytes): New function.
1723
1724 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1725
1726         * windows-nat.c (main_thread_id): Delete.
1727         (handle_output_debug_string): Replace main_thread_id by
1728         current_event.dwThreadId.
1729         (fake_create_process): Likewise.
1730         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1731         Do not set main_thread_id.
1732         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1733         current_event.dwThreadId.
1734         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1735
1736 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1737
1738         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1739         Use current_event.dwThreadId instead of main_thread_id.
1740
1741 2019-04-30  Tom Tromey  <tromey@adacore.com>
1742
1743         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1744         (create_excep_cond_exprs): Iterate over program spaces.
1745         (ada_exception_catchpoint_cond_string): Examine all minimal
1746         symbols for exception types.
1747
1748 2019-04-30  Tom Tromey  <tromey@adacore.com>
1749
1750         PR c++/24470:
1751         * dwarf2read.c (process_structure_scope): Handle case where type
1752         has template parameters but no symbol was created.
1753
1754 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1755             Chris January  <chris.january@arm.com>
1756
1757         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1758         qualifier.
1759         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1760
1761 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * f-typeprint.c (f_print_type): Update rules for printing
1764         whitespace.
1765         (f_type_print_varspec_suffix): Likewise.
1766
1767 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1768             Chris January  <chris.january@arm.com>
1769
1770         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1771         function arguments.
1772
1773 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * f-lang.c (build_fortran_types): Change name of void type to
1776         lower case.
1777         * f-typeprint.c (f_type_print_base): Print the name of the void
1778         type, rather than a fixed string.
1779         * f-valprint.c (f_decorations): Use lower case void string.
1780
1781 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1782             Chris January  <chris.january@arm.com>
1783
1784         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1785         types for Fortran.
1786
1787 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1788             Chris January  <chris.january@arm.com>
1789             David Lecomber  <david.lecomber@arm.com>
1790
1791         * f-exp.y (BINOP_INTRINSIC): New token.
1792         (exp): New parser rule handling BINOP_INTRINSIC.
1793         (f77_keywords): Add new builtin procedures.
1794         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1795         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1796         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1797         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1798         (print_unop_subexp_f): New function.
1799         (print_binop_subexp_f): New function.
1800         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1801         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1802         (dump_subexp_body_f): Likewise.
1803         (operator_check_f): Likewise.
1804         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1805         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1806
1807 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1810         UNOP_KIND.
1811         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1812         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1813         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1814         (operator_length_f): New fuction.
1815         (print_subexp_f): New function.
1816         (op_name_f): New function.
1817         (dump_subexp_body_f): New function.
1818         (operator_check_f): New function.
1819         (exp_descriptor_f): Replace standard expression handling functions
1820         with new functions.
1821         * gdb/fortran-operator.def: New file.
1822         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1823         * gdb/std-operator.def: Remove UNOP_KIND.
1824
1825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * std-operator.def: Remove unbalanced, stray double quote
1828         character.
1829
1830 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1831             Chris January  <chris.january@arm.com>
1832             Daniel Everett  <daniel.everett@arm.com>
1833             Nick Forrington  <nick.forrington@arm.com>
1834             Richard Bunt  <richard.bunt@arm.com>
1835
1836         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1837         of depth when printing anonymous structs or unions.
1838         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1839         Don't print either the top-level value, or the children if the
1840         max-depth is exceeded.
1841         (ppscm_print_children): When printing the key of a map, allow one
1842         extra level of depth.
1843         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1844         print either the top-level value, or the children if the max-depth
1845         is exceeded.
1846         (print_children): When printing the key of a map, allow one extra
1847         level of depth.
1848         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1849         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1850         (user_print_options): Initialise max_depth field.
1851         (val_print_scalar_or_string_type_p): New function.
1852         (val_print): Check to see if the max depth has been reached.
1853         (val_print_check_max_depth): Define new function.
1854         (show_print_max_depth): New function.
1855         (_initialize_valprint): Add 'print max-depth' option.
1856         * valprint.h (struct value_print_options) <max_depth>: New field.
1857         (val_print_check_max_depth): Declare new function.
1858         * NEWS: Document new feature.
1859
1860 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * ada-lang.c (ada_language_defn): Initialise new field.
1863         * c-lang.c (c_is_string_type_p): New function.
1864         (c_language_defn): Initialise new field.
1865         (cplus_language_defn): Initialise new field.
1866         (asm_language_defn): Initialise new field.
1867         (minimal_language_defn): Initialise new field.
1868         * c-lang.h (c_is_string_type_p): Declare new function.
1869         * d-lang.c (d_language_defn): Initialise new field.
1870         * f-lang.c (f_is_string_type_p): New function.
1871         (f_language_defn): Initialise new field.
1872         * go-lang.c (go_is_string_type_p): New function.
1873         (go_language_defn): Initialise new field.
1874         * language.c (default_is_string_type_p): New function.
1875         (unknown_language_defn): Initialise new field.
1876         (auto_language_defn): Initialise new field.
1877         * language.h (struct language_defn) <la_is_string_type_p>: New
1878         member variable.
1879         (default_is_string_type_p): Declare new function.
1880         * m2-lang.c (m2_language_defn): Initialise new field.
1881         * objc-lang.c (objc_language_defn): Initialise new field.
1882         * opencl-lang.c (opencl_language_defn): Initialise new field.
1883         * p-lang.c (pascal_is_string_type_p): New function.
1884         (pascal_language_defn): Initialise new field.
1885         * rust-lang.c (rust_is_string_type_p): New function.
1886         (rust_language_defn): Initialise new field.
1887
1888 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1891         New field.
1892         * ada-lang.c (ada_language_defn): Initialise new field.
1893         * c-lang.c (c_language_defn): Likewise.
1894         (cplus_language_defn): Likewise.
1895         (asm_language_defn): Likewise.
1896         (minimal_language_defn): Likewise.
1897         * d-lang.c (d_language_defn): Likewise.
1898         * f-lang.c (f_language_defn): Likewise.
1899         * go-lang.c (go_language_defn): Likewise.
1900         * language.c (unknown_language_defn): Likewise.
1901         (auto_language_defn): Likewise.
1902         * m2-lang.c (m2_language_defn): Likewise.
1903         * objc-lang.c (objc_language_defn): Likewise.
1904         * opencl-lang.c (opencl_language_defn): Likewise.
1905         * p-lang.c (pascal_language_defn): Likewise.
1906         * rust-lang.c (rust_language_defn): Likewise.
1907
1908 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * ada-lang.c (ada_is_character_type): Change return type to bool.
1911         (ada_is_string_type): Likewise.
1912         * ada-lang.h (ada_is_character_type): Update declaration
1913         (ada_is_string_type): Likewise.
1914
1915 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1916
1917         Support style in 'frame|thread apply'
1918
1919         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1920         * record.c (record_start, record_stop): Update callers of
1921         execute_command_to_string with false.
1922         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1923         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1924         methods.
1925         (class string_file): New constructor with term_out parameter.
1926         Override methods term_out and can_emit_style_escape.  New member
1927         term_out.
1928         (class stdio_file): Override can_emit_style_escape.
1929         (class tee_file): Override term_out and can_emit_style_escape.
1930         * utils.h (can_emit_style_escape): Remove.
1931         * utils.c (can_emit_style_escape): Likewise.
1932         Update all callers of can_emit_style_escape (SOMESTREAM) to
1933         SOMESTREAM->can_emit_style_escape.
1934         * source-cache.c (source_cache::get_source_lines): Likewise.
1935         * stack.c (frame_apply_command_count): Call execute_command_to_string
1936         passing the term_out characteristic of the current gdb_stdout.
1937         * thread.c (thr_try_catch_cmd): Likewise.
1938         * top.c (execute_command_to_string): pass term_out parameter
1939         to construct the string_file for the command output.
1940         * ui-file.c (term_cli_styling): New function (most code moved
1941         from utils.c can_emit_style_escape).
1942         (string_file::string_file, string_file::can_emit_style_escape,
1943         stdio_file::can_emit_style_escape, tee_file::term_out,
1944         tee_file::can_emit_style_escape): New functions.
1945
1946 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1947
1948         * NEWS: Mention the new set|show may-call-functions.
1949         * infcall.c (may_call_functions_p): New variable.
1950         (show_may_call_functions_p): New function.
1951         (call_function_by_hand_dummy): Throws an error if not
1952         may-call-functions.
1953         (_initialize_infcall): Call add_setshow_boolean_cmd for
1954         may-call-functions.
1955
1956 2019-04-25  Keith Seitz  <keiths@redhat.com>
1957
1958         PR c++/24367
1959         * cp-support.c (inspect_type): Don't attempt substitutions
1960         of symbol with the same name.
1961
1962 2019-04-25  Tom Tromey  <tromey@adacore.com>
1963
1964         PR gdb/24475:
1965         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1966         static.
1967
1968 2019-04-25  Tom Tromey  <tromey@adacore.com>
1969
1970         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1971         rvalue reference.
1972         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1973         (gdb_xml_parser::parse): Use std::move.
1974         * python/python-internal.h (gdbpy_convert_exception): Take a const
1975         reference.
1976         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1977         std::move.
1978         * python/py-utils.c (gdbpy_convert_exception): Take a const
1979         reference.
1980         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1981         Use std::move.
1982         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1983         Use std::move.
1984         * mi/mi-main.c (mi_print_exception): Take a const reference.
1985         * main.c (handle_command_errors): Take a const reference.
1986         * linespec.c (parse_linespec): Use std::move.
1987         * infcall.c (run_inferior_call): Use std::move.
1988         (call_function_by_hand_dummy): Use std::move.
1989         * exec.c (try_open_exec_file): Use std::move.
1990         * exceptions.h (exception_print, exception_fprintf)
1991         (exception_print_same): Update.
1992         * exceptions.c (print_exception, exception_print)
1993         (exception_fprintf, exception_print_same): Change parameters to
1994         const reference.
1995         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1996         * common/new-op.c: Use std::move.
1997         * common/common-exceptions.h (struct gdb_exception): Add move
1998         constructor.
1999         (struct gdb_exception_error, struct gdb_exception_quit, struct
2000         gdb_quit_bad_alloc): Change constructor to move constructor.
2001         (throw_exception): Change parameter to rvalue reference.
2002         * common/common-exceptions.c (throw_exception): Take rvalue
2003         reference.
2004         * cli/cli-interp.c (safe_execute_command): Use std::move.
2005         * breakpoint.c (insert_bp_location, location_to_sals): Use
2006         std::move.
2007
2008 2019-04-25  Tom Tromey  <tromey@adacore.com>
2009
2010         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2011         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2012         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2013         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2014         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2015         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2016         guile/scm-value.c: Use unpack.
2017         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2018         gdbscm_gdb_exception.
2019         (gdbscm_throw_gdb_exception): Likewise.
2020         (struct gdbscm_gdb_exception): New.
2021         (unpack): New function.
2022         (gdbscm_wrap): Use unpack.
2023
2024 2019-04-25  Tom Tromey  <tromey@adacore.com>
2025
2026         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2027         (gdb_rl_callback_handler): Use std::move.
2028         * common/common-exceptions.h (struct gdb_exception): Add move
2029         assignment operator.
2030         (throw_exception_sjlj): Change "exception" to const reference.
2031         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2032         (throw_exception_sjlj): Change "exception" to const reference.
2033
2034 2019-04-25  Tom Tromey  <tromey@adacore.com>
2035
2036         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2037         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2038         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2039         Update.
2040         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2041         Update.
2042         * mi/mi-interp.c (mi_interp::exec): Update.
2043         * linespec.c (parse_linespec): Update.
2044         * infcall.c (run_inferior_call): Update.
2045         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2046         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2047         (gdbscm_lookup_global_symbol): Update.
2048         * guile/scm-param.c (gdbscm_parameter_value): Update.
2049         * guile/scm-frame.c (gdbscm_frame_read_register)
2050         (gdbscm_frame_read_var): Update.
2051         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2052         * exec.c (try_open_exec_file): Update.
2053         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2054         (gdb_rl_callback_handler): Update.
2055         * common/common-exceptions.h (exception_none): Don't declare.
2056         * common/common-exceptions.c (exception_none): Don't define.
2057         (struct catcher) <exception>: Update.
2058         * cli/cli-interp.c (safe_execute_command): Update.
2059         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2060
2061 2019-04-25  Ali Tamur  <tamur@google.com>
2062
2063         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2064         (read_attribute_value): Likewise.
2065         (dwarf2_read_addr_index): Update comment.
2066         (read_str_index): Add DW_FORM_strx.
2067         (dwarf2_string_attr): Likewise.
2068         (dwarf2_const_value_attr): Likewise.
2069         (dump_die_shallow): Likewise.
2070         (dwarf2_fetch_constant_bytes): Likewise.
2071         (skip_form_bytes): Likewise.
2072         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2073
2074 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2075
2076         PR corefiles/11608
2077         PR corefiles/18187
2078         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2079         OFFSET.  Verify if current mapping contains an ELF header.
2080         (linux_find_memory_regions_full): Adjust call to
2081         dump_mapping_p.
2082
2083 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2084             Kang Li <kanglictf@gmail.com>
2085
2086         PR gdb/21600
2087
2088         * dwarf2-frame.c (read_initial_length): Be consistent about using
2089         unsigned representation of length.
2090         (decode_frame_entry_1): Likewise.  Check for wraparound of
2091         end pointer as well as buffer overflow.
2092
2093 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2094
2095         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2096         "vq".
2097
2098 2019-04-24  Tom Tromey  <tromey@adacore.com>
2099
2100         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2101
2102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         * s12z-tdep.c (s12z_unwind_pc): Delete.
2105         (s12z_unwind_sp): Delete.
2106         (s12z_gdbarch_init): Don't register deleted functions with
2107         gdbarch.
2108
2109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * rl78-tdep.c (rl78_unwind_sp): Delete.
2112         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2113
2114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2115
2116         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2117         (xstormy16_unwind_pc): Delete.
2118         (xstormy16_dummy_id): Delete.
2119         (xstormy16_gdbarch_init): Don't register deleted functions with
2120         gdbarch.
2121
2122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * vax-tdep.c (vax_unwind_pc): Delete.
2125         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2126
2127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * v850-tdep.c (v850_unwind_sp): Delete.
2130         (v850_unwind_pc): Delete.
2131         (v850_dummy_id): Delete.
2132         (v850_gdbarch_init): Don't register deleted functions with
2133         gdbarch.
2134
2135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2136
2137         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2138         (tilegx_unwind_pc): Delete.
2139         (tilegx_unwind_dummy_id): Delete.
2140         (tilegx_gdbarch_init): Don't register deleted functions with
2141         gdbarch.
2142
2143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2146         (tic6x_dummy_id): Delete.
2147         (tic6x_gdbarch_init): Don't register deleted functions with
2148         gdbarch.
2149
2150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * sparc-tdep.c (sparc_unwind_pc): Delete.
2153         (sparc32_gdbarch_init): Don't register deleted function with
2154         gdbarch.
2155
2156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * sh-tdep.c (sh_unwind_sp): Delete.
2159         (sh_unwind_pc): Delete.
2160         (sh_dummy_id): Delete.
2161         (sh_gdbarch_init): Don't register deleted functions with
2162         gdbarch.
2163
2164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * score-tdep.c (score_unwind_sp): Delete.
2167         (score_unwind_pc): Delete.
2168         (score_dummy_id): Delete.
2169         (score_gdbarch_init): Don't register deleted functions with
2170         gdbarch.
2171
2172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * rx-tdep.c (rx_unwind_pc): Delete.
2175         (rx_unwind_sp): Delete.
2176         (rx_dummy_id): Delete.
2177         (rx_gdbarch_init): Don't register deleted functions with
2178         gdbarch.  Update comment.
2179
2180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2183         (rs6000_dummy_id): Delete.
2184         (rs6000_gdbarch_init): Don't register deleted functions with
2185         gdbarch.
2186
2187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * or1k-tdep.c (or1k_dummy_id): Delete.
2190         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2191
2192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * nios2-tdep.c (nios2_dummy_id): Delete.
2195         (nios2_unwind_sp): Delete.
2196         (nios2_gdbarch_init): Don't register deleted functions with
2197         gdbarch.
2198
2199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * nds32-tdep.c (nds32_dummy_id): Delete.
2202         (nds32_unwind_pc): Delete.
2203         (nds32_unwind_sp): Delete.
2204         (nds32_gdbarch_init): Don't register deleted functions with
2205         gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * msp430-tdep.c (msp430_unwind_pc): Delete.
2210         (msp430_unwind_sp): Delete.
2211         (msp430_dummy_id): Delete.
2212         (msp430_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * moxie-tdep.c (moxie_unwind_sp): Delete.
2218         (moxie_unwind_pc): Delete.
2219         (moxie_dummy_id): Delete.
2220         (moxie_gdbarch_init): Don't register deleted functions with
2221         gdbarch.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2226         (mn10300_unwind_pc): Delete.
2227         (mn10300_unwind_sp): Delete.
2228         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2229         mn10300_unwind_sp.
2230         (mn10300_frame_unwind_init): Don't register deleted functions with
2231         gdbarch.
2232
2233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * mep-tdep.c (mep_unwind_pc): Delete.
2236         (mep_unwind_sp): Delete.
2237         (mep_dummy_id): Delete.
2238         (mep_gdbarch_init): Don't register deleted functions with
2239         gdbarch.
2240
2241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2244         (m68hc11_unwind_sp): Delete.
2245         (m68hc11_gdbarch_init): Don't register deleted functions with
2246         gdbarch.
2247
2248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * m32r-tdep.c (m32r_unwind_sp): Delete.
2251         (m32r_unwind_pc): Delete.
2252         (m32r_dummy_id): Delete.
2253         (m32r_gdbarch_init): Don't register deleted functions with
2254         gdbarch.
2255
2256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * m32c-tdep.c (m32c_unwind_pc): Delete.
2259         (m32c_unwind_sp): Delete.
2260         (m32c_dummy_id): Delete.
2261         (m32c_gdbarch_init): Don't register deleted functions with
2262         gdbarch.
2263
2264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2267         (lm32_unwind_pc): Delete.
2268         (lm32_dummy_id): Delete.
2269         (lm32_gdbarch_init): Don't register deleted functions with
2270         gdbarch.
2271
2272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2275         (iq2000_unwind_pc): Delete.
2276         (iq2000_dummy_id): Delete.
2277         (iq2000_gdbarch_init): Don't register deleted functions with
2278         gdbarch.
2279
2280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * nds32-tdep.c (nds32_type_align): Delete.
2283         (nds32_push_dummy_call): Use type_align instead.
2284
2285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * arm-tdep.c (arm_type_align): Only handle vector override case.
2288         (arm_push_dummy_call): Use type_align.
2289         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2290
2291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2294         case.
2295         (pass_on_stack): Use type_align.
2296         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2297         function.
2298
2299 2019-04-23  Tom Tromey  <tromey@adacore.com>
2300
2301         * dwarf2read.c (line_header::file_name_at): Remove unused
2302         overload.
2303
2304 2019-04-23  Tom de Vries  <tdevries@suse.de>
2305
2306         PR gdb/24438
2307         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2308         invocation.
2309
2310
2311 2019-03-27  Ali Tamur  <tamur@google.com>
2312
2313         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2314         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2315         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2316         (dwarf_expr_context::get_addr_index): Likewise
2317         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2318         (symbol_needs_eval_context::get_addr_index): Likewise
2319         (disassemble_dwarf_expression): Add DW_OP_addrx
2320         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2321         (read_cutu_die_from_dwo): Update comment
2322         (skip_one_die): Add DW_FORM_addrx
2323         (read_attribute_value): Likewise
2324         (var_decode_location): Add DW_OP_addrx
2325         (dwarf2_const_value_attr): Add DW_FORM_addrx
2326         (dump_die_shallow): Likewise
2327         (dwarf2_fetch_constant_bytes): Likewise
2328         (decode_locdesc): Add DW_OP_addrx
2329         (skip_form_bytes): Add DW_FORM_addrx
2330
2331 2019-04-22  Ali Tamur  <tamur@google.com>
2332
2333         * MAINTAINERS (Write After Approval): Add self.
2334
2335 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2336
2337         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2338         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2339         (open_symbol_file_object): Likewise.
2340         (svr4_default_sos): Add info parameter.
2341         (svr4_read_so_list): Likewise.
2342         (svr4_current_sos_direct): Adjust functions calls to pass down
2343         info.
2344         (svr4_current_sos_1): Add info parameter.
2345         (svr4_current_sos): Call get_svr4_info, pass info down to
2346         svr4_current_sos_1.
2347         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2348         get_svr4_info.
2349         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2350         get_svr4_info.
2351         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2352         to get_svr4_info.
2353         (probes_table_remove_objfile_probes): Likewise.
2354         (register_solib_event_probe): Add info parameter.
2355         (solist_update_incremental): Pass info parameter down to
2356         svr4_read_so_list.
2357         (disable_probes_interface): Add info parameter.
2358         (svr4_handle_solib_event): Pass current_program_space to
2359         get_svr4_info.  Adjust disable_probes_interface cleanup.
2360         (svr4_create_probe_breakpoints): Add info parameter, pass it
2361         down to register_solib_event_probe.
2362         (svr4_create_solib_event_breakpoints): Add info parameter,
2363         pass it down to svr4_create_probe_breakpoints.
2364         (enable_break): Pass info down to
2365         svr4_create_solib_event_breakpoints.
2366         (svr4_solib_create_inferior_hook): Pass current_program_space to
2367         get_svr4_info.
2368         (svr4_clear_solib): Likewise.
2369
2370 2019-04-22  Pedro Alves  <palves@redhat.com>
2371
2372         * solib-svr4.c (svr4_free_objfile_observer): New.
2373         (probe_and_action::objfile): New field.
2374         (probes_table_htab_remove_objfile_probes)
2375         (probes_table_remove_objfile_probes): New functions.
2376         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2377         in the new probe_and_action.  Don't store the probe in 'lookup'.
2378         (svr4_create_probe_breakpoints): Pass objfile to
2379         register_solib_event_probe.
2380         (_initialize_svr4_solib): Register a free_objfile observer.
2381
2382 2019-04-19  Tom Tromey  <tom@tromey.com>
2383
2384         * common/queue.h: Remove.
2385
2386 2019-04-19  Tom Tromey  <tom@tromey.com>
2387
2388         * event-loop.c: Don't include "common/queue.h".
2389
2390 2019-04-19  Tom Tromey  <tom@tromey.com>
2391
2392         * remote.c (remote_target): Use delete.
2393         * remote-notif.h: Include <list>, not "common/queue.h".
2394         (notif_client_p): Remove typedef.
2395         (remote_notif_state): Add constructor, destructor, initializer.
2396         <notif_queue>: Now a std::list.
2397         (remote_notif_state_xfree): Don't declare.
2398         * remote-notif.c (remote_notif_process, handle_notification)
2399         (remote_notif_state_allocate): Update.
2400         (~remote_notif_state): Rename from remote_notif_state_xfree.
2401
2402 2019-04-19  Tom Tromey  <tom@tromey.com>
2403
2404         * symfile.c (reread_symbols): Update.
2405         * objfiles.c (objfile_register_static_link)
2406         (objfile_lookup_static_link): Update
2407         (~objfile) Don't delete static_links.
2408         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2409
2410 2019-04-19  Tom Tromey  <tom@tromey.com>
2411
2412         * type-stack.h (struct type_stack) <insert>: Constify string.
2413         * type-stack.c (type_stack::insert): Constify string.
2414         * gdbtypes.h (lookup_template_type): Update.
2415         (address_space_name_to_int): Update.
2416         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2417         const.
2418         (lookup_template_type): Make name const.
2419         * c-exp.y: Update rules.
2420         (lex_one_token, classify_name, classify_inner_name)
2421         (c_print_token): Update.
2422         * p-exp.y: Update rules.
2423         (yylex): Update.
2424         * f-exp.y: Update rules.
2425         (yylex): Update.
2426         * d-exp.y: Update rules.
2427         (lex_one_token, classify_name, classify_inner_name): Update.
2428         * parse.c (write_dollar_variable, copy_name): Return std::string.
2429         * parser-defs.h (copy_name): Change return type.
2430         * m2-exp.y: Update rules.
2431         (yylex): Update.
2432         * go-exp.y (lex_one_token): Update.
2433         Update rules.
2434         (classify_unsafe_function, classify_packaged_name)
2435         (classify_name, yylex): Update.
2436
2437 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2438
2439         * configure.ac: add --enable-source-highlight switch.
2440         * configure: Regenerate.
2441         * top.c (print_gdb_version): plumb --enable-source-highlight
2442         status to "show configuration".
2443
2444 2019-04-19  Tom Tromey  <tromey@adacore.com>
2445
2446         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2447         Check ADA_TYPE_P.
2448         (empty_record, ada_template_to_fixed_record_type_1)
2449         (template_to_static_fixed_type)
2450         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2451         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2452         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2453         macros.
2454
2455 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2456
2457         PR symtab/24423:
2458         * source.c (print_source_lines_base): Advance "iter" when a
2459         control character is seen.
2460
2461 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2462
2463         * inferior.h (struct infcall_suspend_state_deleter):
2464         Catch exception in destructor to avoid crash.
2465
2466 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2467
2468         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2469         close to the add_com "shell".
2470
2471 2019-04-18  Tom Tromey  <tromey@adacore.com>
2472
2473         * process-stratum-target.h (class process_stratum_target)
2474         <stratum>: Add "final".
2475
2476 2019-04-17  Tom Tromey  <tromey@adacore.com>
2477
2478         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2479         against nullptr before use.
2480
2481 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2482
2483         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2484
2485 2019-04-17  Jim Wilson  <jimw@sifive.com>
2486             Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2489         code read might fail, assume 4-byte breakpoint in that case.
2490
2491 2019-04-15  Leszek Swirski  <leszeks@google.com>
2492
2493         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2494         rather than a hand-rolled POD check when checking for forced MEMORY
2495         classification.
2496
2497 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2498
2499         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2500         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2501         function.
2502         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2503         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2504         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2505         declaration.
2506
2507 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2508
2509         * aarch64-linux-nat.c
2510         (aarch64_linux_nat_target::thread_architecture): Add override.
2511         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2512         each VQ.
2513
2514 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2515
2516         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2517
2518 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2521         target types of size 96-bits, add some additional comments, and
2522         check that the builtin type we found was the correct size.
2523
2524 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2525
2526         * utils.c (prompt_for_continue): Don't restore the styling at the
2527         end, as applied_style has the wrong value.  This fixes styling in
2528         long lists of file names that are interrupted by the "Continue?"
2529         prompt.
2530
2531 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2534         * c-lang.c (c_language_defn): Likewise.
2535         (cplus_language_defn): Likewise.
2536         (asm_language_defn): Likewise.
2537         (minimal_language_defn): Likewise.
2538         * d-lang.c (d_language_defn): Likewise.
2539         * f-lang.c (f_language_defn): Likewise.
2540         * go-lang.c (go_language_defn): Likewise.
2541         * language.c (unknown_language_defn): Likewise.
2542         (auto_language_defn): Likewise.
2543         * language.h (struct language_defn): Remove la_magic field.
2544         (LANG_MAGIC): Delete.
2545         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2546         * objc-lang.c (objc_language_defn): Likewise.
2547         * opencl-lang.c (opencl_language_defn): Likewise.
2548         * p-lang.c (pascal_language_defn): Likewise.
2549         * rust-lang.c (rust_language_defn): Likewise.
2550
2551 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * riscv-tdep.c (riscv_type_align): New function.
2554         (riscv_type_alignment): Delete.
2555         (riscv_arg_location): Use 'type_align'.
2556         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2557
2558 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * gdbtypes.c (type_align): A struct with no non-static fields also
2561         has alignment of 1.
2562
2563 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2566         component to 0.
2567         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2568         member.
2569         (riscv_struct_info::analyse): New implementation using new
2570         analyse_inner member function.
2571         (riscv_struct_info::field_offset): New member function.
2572         (riscv_struct_info::m_offsets): New member variable.
2573         (riscv_struct_info::analyse_inner): New private member function,
2574         takes the old implementation of riscv_struct_info::analyse but
2575         extended to track field offsets.
2576         (riscv_call_arg_struct): Update the struct folding special cases
2577         to handle cases where empty C++ structs, which are non-zero
2578         length, are found.
2579         (riscv_arg_location): Initialise the length of each location, a
2580         non-zero length now indicates the location is in use.
2581         (riscv_push_dummy_call): Allow for the first location having a
2582         non-zero offset when setting up arguments.
2583         (riscv_return_value): Likewise, but for return values.
2584
2585 2019-04-11  Tom Tromey  <tromey@adacore.com>
2586
2587         * utils.c (internal_vproblem): Make "msg" const.
2588
2589 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2592         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2593         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2594         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2595
2596 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2597
2598         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2599         function.
2600         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2601         of amd64_collect_native_gregset.
2602         (amd64_linux_nat_target::store_registers): Likewise.
2603
2604 2019-04-10  Tom Tromey  <tom@tromey.com>
2605
2606         * symtab.c (lookup_global_symbol_from_objfile)
2607         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2608         * objfiles.h (class separate_debug_iterator): New.
2609         (class separate_debug_range): New.
2610         (struct objfile) <separate_debug_objfiles>: New method.
2611         (objfile_separate_debug_iterate): Don't declare.
2612         * objfiles.c (separate_debug_iterator::operator++): Rename from
2613         objfile_separate_debug_iterate.
2614         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2615         iterator.
2616         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2617         iterator.
2618
2619 2019-04-10  Tom Tromey  <tom@tromey.com>
2620
2621         * symfile.c (reread_symbols): Remove old comment.
2622         * objfiles.c (free_all_objfiles): Fix a typo.
2623
2624 2019-04-10  Tom Tromey  <tom@tromey.com>
2625
2626         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2627         * minsyms.c (lookup_minimal_symbol): Use foreach.
2628         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2629         (lookup_minimal_symbol_solib_trampoline): Likewise.
2630         * symfile.c (reread_symbols): Use foreach.
2631
2632 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2633             Tom Tromey  <tromey@adacore.com>
2634
2635         PR rust/24414:
2636         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2637         (rust_lex_int_test): Change "value" to be LONGEST.
2638         (rust_lex_tests): Add test for long integer literal.
2639
2640 2019-04-09  Tom Tromey  <tromey@adacore.com>
2641
2642         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2643         to bool.
2644         (extended_remote_target::attach): Update.
2645         (remote_target::remote_notice_new_inferior): Update.
2646         (remote_target::add_current_inferior_and_thread): Update.
2647         * inferior.c (exit_inferior_1): Use "false".
2648         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2649
2650 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2651
2652         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2653         the "start" command.
2654
2655 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2656
2657         * python/py-inferior.c (infpy_thread_from_thread_handle):
2658         Adjust comments to reflect renaming of thread_from_thread_handle
2659         to thread_from_handle.  Adjust keywords.  Fix type error message.
2660         (inferior_object_methods): Add thread_from_handle.  Retain
2661         thread_from_thread_handle, but mark it as deprecated.
2662
2663 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2664
2665         * gdbthread.h (find_thread_by_handle): Revise declaration.
2666         * thread.c (find_thread_by_handle): Likewise.  Adjust
2667         implementation too.
2668         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2669         support for buffer objects as handles.
2670
2671 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2672
2673         * python/py-infthread.c (thpy_thread_handle): New function.
2674         (thread_object_methods): Register thpy_thread_handle.
2675
2676 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2677
2678         * gdbthread.h (thread_to_thread_handle): Declare.
2679         * thread.c (gdbtypes.h): Include.
2680         (thread_to_thread_handle): New function.
2681
2682         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2683         (target_thread_info_to_thread_handle): Declare.
2684         * target.c (target_thread_info_to_thread_handle): New function.
2685         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2686         * target-delegates.c: Regenerate.
2687
2688         * linux-thread-db.c (class thread_db_target): Add method
2689         thread_info_to_thread_handle.
2690         (thread_db_target::thread_info_to_thread_handle): Define.
2691         * remote.c (class remote_target): Add new method
2692         thread_info_to_thread_handle.
2693         (remote_target::thread_info_to_thread_handle): Define.
2694
2695 2019-04-08  Pedro Alves  <palves@redhat.com>
2696
2697         * common/common-exceptions.c (throw_exception): Don't create
2698         named object to throw; throw directly.
2699         (throw_it): Likewise.  Don't initialize gdb_exception::message
2700         here, with new; pass FMT and AP to the ctor instead.
2701         * common/common-exceptions.h: Include <string>.
2702         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2703         const char *, va_list)): New ctor.  Use std::make_shared.
2704         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2705         errors)): Delete.
2706         (gdb_exception_error::gdb_exception_error(enum errors, const char
2707         *, va_list)): New.
2708         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2709         Add assertion.
2710         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2711         errors)): Delete.
2712         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2713         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2714         Add assertion.
2715
2716 2019-04-08  Tom Tromey  <tom@tromey.com>
2717
2718         * valops.c (value_rtti_indirect_type): Replace throw_exception
2719         with throw.
2720         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2721         with throw.
2722         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2723         throw.
2724         * target.c (target_translate_tls_address): Replace throw_exception
2725         with throw.
2726         * stack.c (frame_apply_command_count): Replace throw_exception
2727         with throw.
2728         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2729         throw.
2730         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2731         with throw.
2732         * rs6000-tdep.c (rs6000_frame_cache)
2733         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2734         * remote.c: Replace throw_exception with throw.
2735         * record-full.c (record_full_message, record_full_wait_1)
2736         (record_full_restore): Replace throw_exception with throw.
2737         * record-btrace.c:
2738         (get_thread_current_frame_id, record_btrace_start_replaying)
2739         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2740         (cmd_record_btrace_start): Replace throw_exception with throw.
2741         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2742         throw.
2743         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2744         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2745         * linespec.c:
2746         (find_linespec_symbols): Replace throw_exception with throw.
2747         * infrun.c (displaced_step_prepare, resume): Replace
2748         throw_exception with throw.
2749         * infcmd.c (post_create_inferior): Replace throw_exception with
2750         throw.
2751         * inf-loop.c (inferior_event_handler): Replace throw_exception
2752         with throw.
2753         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2754         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2755         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2756         (get_prev_frame_always, get_frame_pc_if_available)
2757         (get_frame_address_in_block_if_available, get_frame_language):
2758         Replace throw_exception with throw.
2759         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2760         throw_exception with throw.
2761         * eval.c (fetch_subexp_value, evaluate_var_value)
2762         (evaluate_funcall, evaluate_subexp_standard): Replace
2763         throw_exception with throw.
2764         * dwarf2loc.c (call_site_find_chain)
2765         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2766         Replace throw_exception with throw.
2767         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2768         with throw.
2769         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2770         throw.
2771         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2772         * completer.c (complete_line_internal): Replace throw_exception
2773         with throw.
2774         * compile/compile-object-run.c (compile_object_run): Replace
2775         throw_exception with throw.
2776         * cli/cli-script.c (process_next_line): Replace throw_exception
2777         with throw.
2778         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2779         (btrace_enable, btrace_maint_update_pt_packets): Replace
2780         throw_exception with throw.
2781         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2782         throw_exception with throw.
2783         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2784         throw_exception with throw.
2785         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2786         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2787         * aarch64-tdep.c (aarch64_make_prologue_cache)
2788         (aarch64_make_stub_cache): Replace throw_exception with throw.
2789
2790 2019-04-08  Tom Tromey  <tom@tromey.com>
2791
2792         * common/common-exceptions.c (throw_exception): Rename from
2793         throw_exception_cxx.  Remove old copy.  Make argument const.
2794         (throw_it): Create and throw exception objects directly.
2795         * common/common-exceptions.h (throw_exception): Make argument
2796         const.
2797         (struct gdb_exception_error): Add constructor.
2798         (struct gdb_exception_quit): Add constructor.
2799
2800 2019-04-08  Tom Tromey  <tom@tromey.com>
2801
2802         * common/common-exceptions.h (exception_rethrow): Don't declare.
2803         (TRY_SJLJ): Update comment.
2804         (TRY, CATCH, END_CATCH): Remove.
2805         * common/common-exceptions.c (exception_rethrow): Remove.
2806
2807 2019-04-08  Tom Tromey  <tom@tromey.com>
2808
2809         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2810         Remove.
2811         (gdb_exception_error): Rename from
2812         gdb_exception_RETURN_MASK_ERROR.
2813         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2814         (gdb_quit_bad_alloc): Update.
2815         * aarch64-tdep.c: Update.
2816         * ada-lang.c: Update.
2817         * ada-typeprint.c: Update.
2818         * ada-valprint.c: Update.
2819         * amd64-tdep.c: Update.
2820         * arch-utils.c: Update.
2821         * break-catch-throw.c: Update.
2822         * breakpoint.c: Update.
2823         * btrace.c: Update.
2824         * c-varobj.c: Update.
2825         * cli/cli-cmds.c: Update.
2826         * cli/cli-interp.c: Update.
2827         * cli/cli-script.c: Update.
2828         * common/common-exceptions.c: Update.
2829         * common/new-op.c: Update.
2830         * common/selftest.c: Update.
2831         * compile/compile-c-symbols.c: Update.
2832         * compile/compile-cplus-symbols.c: Update.
2833         * compile/compile-object-load.c: Update.
2834         * compile/compile-object-run.c: Update.
2835         * completer.c: Update.
2836         * corelow.c: Update.
2837         * cp-abi.c: Update.
2838         * cp-support.c: Update.
2839         * cp-valprint.c: Update.
2840         * darwin-nat.c: Update.
2841         * disasm-selftests.c: Update.
2842         * dtrace-probe.c: Update.
2843         * dwarf-index-cache.c: Update.
2844         * dwarf-index-write.c: Update.
2845         * dwarf2-frame-tailcall.c: Update.
2846         * dwarf2-frame.c: Update.
2847         * dwarf2loc.c: Update.
2848         * dwarf2read.c: Update.
2849         * eval.c: Update.
2850         * event-loop.c: Update.
2851         * event-top.c: Update.
2852         * exec.c: Update.
2853         * f-valprint.c: Update.
2854         * fbsd-tdep.c: Update.
2855         * frame-unwind.c: Update.
2856         * frame.c: Update.
2857         * gdbtypes.c: Update.
2858         * gnu-v3-abi.c: Update.
2859         * guile/guile-internal.h: Update.
2860         * guile/scm-block.c: Update.
2861         * guile/scm-breakpoint.c: Update.
2862         * guile/scm-cmd.c: Update.
2863         * guile/scm-disasm.c: Update.
2864         * guile/scm-frame.c: Update.
2865         * guile/scm-lazy-string.c: Update.
2866         * guile/scm-math.c: Update.
2867         * guile/scm-param.c: Update.
2868         * guile/scm-ports.c: Update.
2869         * guile/scm-pretty-print.c: Update.
2870         * guile/scm-symbol.c: Update.
2871         * guile/scm-symtab.c: Update.
2872         * guile/scm-type.c: Update.
2873         * guile/scm-value.c: Update.
2874         * i386-linux-tdep.c: Update.
2875         * i386-tdep.c: Update.
2876         * inf-loop.c: Update.
2877         * infcall.c: Update.
2878         * infcmd.c: Update.
2879         * infrun.c: Update.
2880         * jit.c: Update.
2881         * language.c: Update.
2882         * linespec.c: Update.
2883         * linux-fork.c: Update.
2884         * linux-nat.c: Update.
2885         * linux-tdep.c: Update.
2886         * linux-thread-db.c: Update.
2887         * main.c: Update.
2888         * mi/mi-cmd-break.c: Update.
2889         * mi/mi-cmd-stack.c: Update.
2890         * mi/mi-interp.c: Update.
2891         * mi/mi-main.c: Update.
2892         * objc-lang.c: Update.
2893         * p-valprint.c: Update.
2894         * parse.c: Update.
2895         * ppc-linux-tdep.c: Update.
2896         * printcmd.c: Update.
2897         * python/py-arch.c: Update.
2898         * python/py-breakpoint.c: Update.
2899         * python/py-cmd.c: Update.
2900         * python/py-finishbreakpoint.c: Update.
2901         * python/py-frame.c: Update.
2902         * python/py-framefilter.c: Update.
2903         * python/py-gdb-readline.c: Update.
2904         * python/py-inferior.c: Update.
2905         * python/py-infthread.c: Update.
2906         * python/py-lazy-string.c: Update.
2907         * python/py-linetable.c: Update.
2908         * python/py-objfile.c: Update.
2909         * python/py-param.c: Update.
2910         * python/py-prettyprint.c: Update.
2911         * python/py-progspace.c: Update.
2912         * python/py-record-btrace.c: Update.
2913         * python/py-record.c: Update.
2914         * python/py-symbol.c: Update.
2915         * python/py-type.c: Update.
2916         * python/py-unwind.c: Update.
2917         * python/py-utils.c: Update.
2918         * python/py-value.c: Update.
2919         * python/python.c: Update.
2920         * record-btrace.c: Update.
2921         * record-full.c: Update.
2922         * remote-fileio.c: Update.
2923         * remote.c: Update.
2924         * riscv-tdep.c: Update.
2925         * rs6000-aix-tdep.c: Update.
2926         * rs6000-tdep.c: Update.
2927         * rust-exp.y: Update.
2928         * rust-lang.c: Update.
2929         * s390-tdep.c: Update.
2930         * selftest-arch.c: Update.
2931         * solib-dsbt.c: Update.
2932         * solib-frv.c: Update.
2933         * solib-spu.c: Update.
2934         * solib-svr4.c: Update.
2935         * solib.c: Update.
2936         * sparc64-linux-tdep.c: Update.
2937         * stack.c: Update.
2938         * symfile-mem.c: Update.
2939         * symmisc.c: Update.
2940         * target.c: Update.
2941         * thread.c: Update.
2942         * top.c: Update.
2943         * tracefile-tfile.c: Update.
2944         * tui/tui.c: Update.
2945         * typeprint.c: Update.
2946         * unittests/cli-utils-selftests.c: Update.
2947         * unittests/parse-connection-spec-selftests.c: Update.
2948         * valops.c: Update.
2949         * valprint.c: Update.
2950         * value.c: Update.
2951         * varobj.c: Update.
2952         * windows-nat.c: Update.
2953         * x86-linux-nat.c: Update.
2954         * xml-support.c: Update.
2955
2956 2019-04-08  Tom Tromey  <tom@tromey.com>
2957
2958         * xml-support.c: Use C++ exception handling.
2959         * x86-linux-nat.c: Use C++ exception handling.
2960         * windows-nat.c: Use C++ exception handling.
2961         * varobj.c: Use C++ exception handling.
2962         * value.c: Use C++ exception handling.
2963         * valprint.c: Use C++ exception handling.
2964         * valops.c: Use C++ exception handling.
2965         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2966         handling.
2967         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2968         * typeprint.c: Use C++ exception handling.
2969         * tui/tui.c: Use C++ exception handling.
2970         * tracefile-tfile.c: Use C++ exception handling.
2971         * top.c: Use C++ exception handling.
2972         * thread.c: Use C++ exception handling.
2973         * target.c: Use C++ exception handling.
2974         * symmisc.c: Use C++ exception handling.
2975         * symfile-mem.c: Use C++ exception handling.
2976         * stack.c: Use C++ exception handling.
2977         * sparc64-linux-tdep.c: Use C++ exception handling.
2978         * solib.c: Use C++ exception handling.
2979         * solib-svr4.c: Use C++ exception handling.
2980         * solib-spu.c: Use C++ exception handling.
2981         * solib-frv.c: Use C++ exception handling.
2982         * solib-dsbt.c: Use C++ exception handling.
2983         * selftest-arch.c: Use C++ exception handling.
2984         * s390-tdep.c: Use C++ exception handling.
2985         * rust-lang.c: Use C++ exception handling.
2986         * rust-exp.y: Use C++ exception handling.
2987         * rs6000-tdep.c: Use C++ exception handling.
2988         * rs6000-aix-tdep.c: Use C++ exception handling.
2989         * riscv-tdep.c: Use C++ exception handling.
2990         * remote.c: Use C++ exception handling.
2991         * remote-fileio.c: Use C++ exception handling.
2992         * record-full.c: Use C++ exception handling.
2993         * record-btrace.c: Use C++ exception handling.
2994         * python/python.c: Use C++ exception handling.
2995         * python/py-value.c: Use C++ exception handling.
2996         * python/py-utils.c: Use C++ exception handling.
2997         * python/py-unwind.c: Use C++ exception handling.
2998         * python/py-type.c: Use C++ exception handling.
2999         * python/py-symbol.c: Use C++ exception handling.
3000         * python/py-record.c: Use C++ exception handling.
3001         * python/py-record-btrace.c: Use C++ exception handling.
3002         * python/py-progspace.c: Use C++ exception handling.
3003         * python/py-prettyprint.c: Use C++ exception handling.
3004         * python/py-param.c: Use C++ exception handling.
3005         * python/py-objfile.c: Use C++ exception handling.
3006         * python/py-linetable.c: Use C++ exception handling.
3007         * python/py-lazy-string.c: Use C++ exception handling.
3008         * python/py-infthread.c: Use C++ exception handling.
3009         * python/py-inferior.c: Use C++ exception handling.
3010         * python/py-gdb-readline.c: Use C++ exception handling.
3011         * python/py-framefilter.c: Use C++ exception handling.
3012         * python/py-frame.c: Use C++ exception handling.
3013         * python/py-finishbreakpoint.c: Use C++ exception handling.
3014         * python/py-cmd.c: Use C++ exception handling.
3015         * python/py-breakpoint.c: Use C++ exception handling.
3016         * python/py-arch.c: Use C++ exception handling.
3017         * printcmd.c: Use C++ exception handling.
3018         * ppc-linux-tdep.c: Use C++ exception handling.
3019         * parse.c: Use C++ exception handling.
3020         * p-valprint.c: Use C++ exception handling.
3021         * objc-lang.c: Use C++ exception handling.
3022         * mi/mi-main.c: Use C++ exception handling.
3023         * mi/mi-interp.c: Use C++ exception handling.
3024         * mi/mi-cmd-stack.c: Use C++ exception handling.
3025         * mi/mi-cmd-break.c: Use C++ exception handling.
3026         * main.c: Use C++ exception handling.
3027         * linux-thread-db.c: Use C++ exception handling.
3028         * linux-tdep.c: Use C++ exception handling.
3029         * linux-nat.c: Use C++ exception handling.
3030         * linux-fork.c: Use C++ exception handling.
3031         * linespec.c: Use C++ exception handling.
3032         * language.c: Use C++ exception handling.
3033         * jit.c: Use C++ exception handling.
3034         * infrun.c: Use C++ exception handling.
3035         * infcmd.c: Use C++ exception handling.
3036         * infcall.c: Use C++ exception handling.
3037         * inf-loop.c: Use C++ exception handling.
3038         * i386-tdep.c: Use C++ exception handling.
3039         * i386-linux-tdep.c: Use C++ exception handling.
3040         * guile/scm-value.c: Use C++ exception handling.
3041         * guile/scm-type.c: Use C++ exception handling.
3042         * guile/scm-symtab.c: Use C++ exception handling.
3043         * guile/scm-symbol.c: Use C++ exception handling.
3044         * guile/scm-pretty-print.c: Use C++ exception handling.
3045         * guile/scm-ports.c: Use C++ exception handling.
3046         * guile/scm-param.c: Use C++ exception handling.
3047         * guile/scm-math.c: Use C++ exception handling.
3048         * guile/scm-lazy-string.c: Use C++ exception handling.
3049         * guile/scm-frame.c: Use C++ exception handling.
3050         * guile/scm-disasm.c: Use C++ exception handling.
3051         * guile/scm-cmd.c: Use C++ exception handling.
3052         * guile/scm-breakpoint.c: Use C++ exception handling.
3053         * guile/scm-block.c: Use C++ exception handling.
3054         * guile/guile-internal.h: Use C++ exception handling.
3055         * gnu-v3-abi.c: Use C++ exception handling.
3056         * gdbtypes.c: Use C++ exception handling.
3057         * frame.c: Use C++ exception handling.
3058         * frame-unwind.c: Use C++ exception handling.
3059         * fbsd-tdep.c: Use C++ exception handling.
3060         * f-valprint.c: Use C++ exception handling.
3061         * exec.c: Use C++ exception handling.
3062         * event-top.c: Use C++ exception handling.
3063         * event-loop.c: Use C++ exception handling.
3064         * eval.c: Use C++ exception handling.
3065         * dwarf2read.c: Use C++ exception handling.
3066         * dwarf2loc.c: Use C++ exception handling.
3067         * dwarf2-frame.c: Use C++ exception handling.
3068         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3069         * dwarf-index-write.c: Use C++ exception handling.
3070         * dwarf-index-cache.c: Use C++ exception handling.
3071         * dtrace-probe.c: Use C++ exception handling.
3072         * disasm-selftests.c: Use C++ exception handling.
3073         * darwin-nat.c: Use C++ exception handling.
3074         * cp-valprint.c: Use C++ exception handling.
3075         * cp-support.c: Use C++ exception handling.
3076         * cp-abi.c: Use C++ exception handling.
3077         * corelow.c: Use C++ exception handling.
3078         * completer.c: Use C++ exception handling.
3079         * compile/compile-object-run.c: Use C++ exception handling.
3080         * compile/compile-object-load.c: Use C++ exception handling.
3081         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3082         * compile/compile-c-symbols.c: Use C++ exception handling.
3083         * common/selftest.c: Use C++ exception handling.
3084         * common/new-op.c: Use C++ exception handling.
3085         * cli/cli-script.c: Use C++ exception handling.
3086         * cli/cli-interp.c: Use C++ exception handling.
3087         * cli/cli-cmds.c: Use C++ exception handling.
3088         * c-varobj.c: Use C++ exception handling.
3089         * btrace.c: Use C++ exception handling.
3090         * breakpoint.c: Use C++ exception handling.
3091         * break-catch-throw.c: Use C++ exception handling.
3092         * arch-utils.c: Use C++ exception handling.
3093         * amd64-tdep.c: Use C++ exception handling.
3094         * ada-valprint.c: Use C++ exception handling.
3095         * ada-typeprint.c: Use C++ exception handling.
3096         * ada-lang.c: Use C++ exception handling.
3097         * aarch64-tdep.c: Use C++ exception handling.
3098
3099 2019-04-08  Tom Tromey  <tom@tromey.com>
3100
3101         * xml-support.c (gdb_xml_parser::parse): Update.
3102         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3103         * value.c (show_convenience): Update.
3104         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3105         (test_parse_flags_qcs): Update.
3106         * thread.c (thr_try_catch_cmd): Update.
3107         * target.c (target_translate_tls_address): Update.
3108         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3109         (info_frame_command_core, frame_apply_command_count): Update.
3110         * rust-exp.y (rust_lex_exception_test): Update.
3111         * riscv-tdep.c (riscv_print_one_register_info): Update.
3112         * remote.c (remote_target::enable_btrace): Update.
3113         * record-btrace.c (record_btrace_enable_warn): Update.
3114         * python/py-utils.c (gdbpy_convert_exception): Update.
3115         * printcmd.c (do_one_display, print_variable_and_value): Update.
3116         * mi/mi-main.c (mi_print_exception): Update.
3117         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3118         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3119         * linux-nat.c (linux_nat_target::attach): Update.
3120         * linux-fork.c (class scoped_switch_fork_info): Update.
3121         * infrun.c (displaced_step_prepare): Update.
3122         * infcall.c (call_function_by_hand_dummy): Update.
3123         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3124         * gnu-v3-abi.c (print_one_vtable): Update.
3125         * frame.c (get_prev_frame_always): Update.
3126         * f-valprint.c (info_common_command_for_block): Update.
3127         * exec.c (try_open_exec_file): Update.
3128         * exceptions.c (print_exception, exception_print)
3129         (exception_fprintf, exception_print_same): Update.
3130         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3131         * dwarf-index-cache.c (index_cache::store)
3132         (index_cache::lookup_gdb_index): Update.
3133         * darwin-nat.c (maybe_cache_shell): Update.
3134         * cp-valprint.c (cp_print_value_fields): Update.
3135         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3136         (gcc_cplus_symbol_address): Update.
3137         * compile/compile-c-symbols.c (gcc_convert_symbol)
3138         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3139         * common/selftest.c: Update.
3140         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3141         a std::string.
3142         (exception_try_scope_entry, exception_try_scope_exit): Don't
3143         declare.
3144         (struct exception_try_scope): Remove.
3145         (TRY): Don't use exception_try_scope.
3146         (struct gdb_exception): Add constructor, operator=.
3147         <what>: New method.
3148         (struct gdb_exception_RETURN_MASK_ALL)
3149         (struct gdb_exception_RETURN_MASK_ERROR)
3150         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3151         (struct gdb_quit_bad_alloc): Update.
3152         * common/common-exceptions.c (exception_none): Change
3153         initializer.
3154         (struct catcher) <state, exception>: Initialize inline.
3155         <prev>: Remove member.
3156         (current_catcher): Remove.
3157         (catchers): New global.
3158         (exceptions_state_mc_init): Simplify.
3159         (catcher_pop): Remove.
3160         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3161         (try_scope_depth, exception_try_scope_entry)
3162         (exception_try_scope_exit): Remove.
3163         (throw_exception_sjlj): Update.
3164         (exception_messages, exception_messages_size): Remove.
3165         (throw_it): Simplify.
3166         (gdb_exception_sliced_copy): Remove.
3167         (throw_exception_cxx): Update.
3168         * cli/cli-script.c (script_from_file): Update.
3169         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3170         Update.
3171         * ada-valprint.c (ada_val_print): Update.
3172         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3173         (create_excep_cond_exprs): Update.
3174
3175 2019-04-08  Tom Tromey  <tom@tromey.com>
3176
3177         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3178         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3179         (TRY, CATCH, END_CATCH): Remove some definitions.
3180         * common/common-exceptions.c: Don't use GDB_XCPT.
3181         (catcher_list_size): Remove.
3182         (throw_exception, throw_it): Simplify.
3183
3184 2019-04-05  Tom Tromey  <tom@tromey.com>
3185
3186         Revert the header-sorting patch.
3187         * ft32-tdep.c: Revert.
3188         * frv-tdep.c: Revert.
3189         * frv-linux-tdep.c: Revert.
3190         * frame.c: Revert.
3191         * frame-unwind.c: Revert.
3192         * frame-base.c: Revert.
3193         * fork-child.c: Revert.
3194         * findvar.c: Revert.
3195         * findcmd.c: Revert.
3196         * filesystem.c: Revert.
3197         * filename-seen-cache.h: Revert.
3198         * filename-seen-cache.c: Revert.
3199         * fbsd-tdep.c: Revert.
3200         * fbsd-nat.h: Revert.
3201         * fbsd-nat.c: Revert.
3202         * f-valprint.c: Revert.
3203         * f-typeprint.c: Revert.
3204         * f-lang.c: Revert.
3205         * extension.h: Revert.
3206         * extension.c: Revert.
3207         * extension-priv.h: Revert.
3208         * expprint.c: Revert.
3209         * exec.h: Revert.
3210         * exec.c: Revert.
3211         * exceptions.c: Revert.
3212         * event-top.c: Revert.
3213         * event-loop.c: Revert.
3214         * eval.c: Revert.
3215         * elfread.c: Revert.
3216         * dwarf2read.h: Revert.
3217         * dwarf2read.c: Revert.
3218         * dwarf2loc.c: Revert.
3219         * dwarf2expr.h: Revert.
3220         * dwarf2expr.c: Revert.
3221         * dwarf2-frame.c: Revert.
3222         * dwarf2-frame-tailcall.c: Revert.
3223         * dwarf-index-write.h: Revert.
3224         * dwarf-index-write.c: Revert.
3225         * dwarf-index-common.c: Revert.
3226         * dwarf-index-cache.h: Revert.
3227         * dwarf-index-cache.c: Revert.
3228         * dummy-frame.c: Revert.
3229         * dtrace-probe.c: Revert.
3230         * disasm.h: Revert.
3231         * disasm.c: Revert.
3232         * disasm-selftests.c: Revert.
3233         * dictionary.c: Revert.
3234         * dicos-tdep.c: Revert.
3235         * demangle.c: Revert.
3236         * dcache.h: Revert.
3237         * dcache.c: Revert.
3238         * darwin-nat.h: Revert.
3239         * darwin-nat.c: Revert.
3240         * darwin-nat-info.c: Revert.
3241         * d-valprint.c: Revert.
3242         * d-namespace.c: Revert.
3243         * d-lang.c: Revert.
3244         * ctf.c: Revert.
3245         * csky-tdep.c: Revert.
3246         * csky-linux-tdep.c: Revert.
3247         * cris-tdep.c: Revert.
3248         * cris-linux-tdep.c: Revert.
3249         * cp-valprint.c: Revert.
3250         * cp-support.c: Revert.
3251         * cp-namespace.c: Revert.
3252         * cp-abi.c: Revert.
3253         * corelow.c: Revert.
3254         * corefile.c: Revert.
3255         * continuations.c: Revert.
3256         * completer.h: Revert.
3257         * completer.c: Revert.
3258         * complaints.c: Revert.
3259         * coffread.c: Revert.
3260         * coff-pe-read.c: Revert.
3261         * cli-out.h: Revert.
3262         * cli-out.c: Revert.
3263         * charset.c: Revert.
3264         * c-varobj.c: Revert.
3265         * c-valprint.c: Revert.
3266         * c-typeprint.c: Revert.
3267         * c-lang.c: Revert.
3268         * buildsym.c: Revert.
3269         * buildsym-legacy.c: Revert.
3270         * build-id.h: Revert.
3271         * build-id.c: Revert.
3272         * btrace.c: Revert.
3273         * bsd-uthread.c: Revert.
3274         * breakpoint.h: Revert.
3275         * breakpoint.c: Revert.
3276         * break-catch-throw.c: Revert.
3277         * break-catch-syscall.c: Revert.
3278         * break-catch-sig.c: Revert.
3279         * blockframe.c: Revert.
3280         * block.c: Revert.
3281         * bfin-tdep.c: Revert.
3282         * bfin-linux-tdep.c: Revert.
3283         * bfd-target.c: Revert.
3284         * bcache.c: Revert.
3285         * ax-general.c: Revert.
3286         * ax-gdb.h: Revert.
3287         * ax-gdb.c: Revert.
3288         * avr-tdep.c: Revert.
3289         * auxv.c: Revert.
3290         * auto-load.c: Revert.
3291         * arm-wince-tdep.c: Revert.
3292         * arm-tdep.c: Revert.
3293         * arm-symbian-tdep.c: Revert.
3294         * arm-pikeos-tdep.c: Revert.
3295         * arm-obsd-tdep.c: Revert.
3296         * arm-nbsd-tdep.c: Revert.
3297         * arm-nbsd-nat.c: Revert.
3298         * arm-linux-tdep.c: Revert.
3299         * arm-linux-nat.c: Revert.
3300         * arm-fbsd-tdep.c: Revert.
3301         * arm-fbsd-nat.c: Revert.
3302         * arm-bsd-tdep.c: Revert.
3303         * arch-utils.c: Revert.
3304         * arc-tdep.c: Revert.
3305         * arc-newlib-tdep.c: Revert.
3306         * annotate.h: Revert.
3307         * annotate.c: Revert.
3308         * amd64-windows-tdep.c: Revert.
3309         * amd64-windows-nat.c: Revert.
3310         * amd64-tdep.c: Revert.
3311         * amd64-sol2-tdep.c: Revert.
3312         * amd64-obsd-tdep.c: Revert.
3313         * amd64-obsd-nat.c: Revert.
3314         * amd64-nbsd-tdep.c: Revert.
3315         * amd64-nbsd-nat.c: Revert.
3316         * amd64-nat.c: Revert.
3317         * amd64-linux-tdep.c: Revert.
3318         * amd64-linux-nat.c: Revert.
3319         * amd64-fbsd-tdep.c: Revert.
3320         * amd64-fbsd-nat.c: Revert.
3321         * amd64-dicos-tdep.c: Revert.
3322         * amd64-darwin-tdep.c: Revert.
3323         * amd64-bsd-nat.c: Revert.
3324         * alpha-tdep.c: Revert.
3325         * alpha-obsd-tdep.c: Revert.
3326         * alpha-nbsd-tdep.c: Revert.
3327         * alpha-mdebug-tdep.c: Revert.
3328         * alpha-linux-tdep.c: Revert.
3329         * alpha-linux-nat.c: Revert.
3330         * alpha-bsd-tdep.c: Revert.
3331         * alpha-bsd-nat.c: Revert.
3332         * aix-thread.c: Revert.
3333         * agent.c: Revert.
3334         * addrmap.c: Revert.
3335         * ada-varobj.c: Revert.
3336         * ada-valprint.c: Revert.
3337         * ada-typeprint.c: Revert.
3338         * ada-tasks.c: Revert.
3339         * ada-lang.c: Revert.
3340         * aarch64-tdep.c: Revert.
3341         * aarch64-ravenscar-thread.c: Revert.
3342         * aarch64-newlib-tdep.c: Revert.
3343         * aarch64-linux-tdep.c: Revert.
3344         * aarch64-linux-nat.c: Revert.
3345         * aarch64-fbsd-tdep.c: Revert.
3346         * aarch64-fbsd-nat.c: Revert.
3347         * aarch32-linux-nat.c: Revert.
3348
3349 2019-04-05  Tom Tromey  <tom@tromey.com>
3350
3351         * ft32-tdep.c: Sort headers.
3352         * frv-tdep.c: Sort headers.
3353         * frv-linux-tdep.c: Sort headers.
3354         * frame.c: Sort headers.
3355         * frame-unwind.c: Sort headers.
3356         * frame-base.c: Sort headers.
3357         * fork-child.c: Sort headers.
3358         * findvar.c: Sort headers.
3359         * findcmd.c: Sort headers.
3360         * filesystem.c: Sort headers.
3361         * filename-seen-cache.h: Sort headers.
3362         * filename-seen-cache.c: Sort headers.
3363         * fbsd-tdep.c: Sort headers.
3364         * fbsd-nat.h: Sort headers.
3365         * fbsd-nat.c: Sort headers.
3366         * f-valprint.c: Sort headers.
3367         * f-typeprint.c: Sort headers.
3368         * f-lang.c: Sort headers.
3369         * extension.h: Sort headers.
3370         * extension.c: Sort headers.
3371         * extension-priv.h: Sort headers.
3372         * expprint.c: Sort headers.
3373         * exec.h: Sort headers.
3374         * exec.c: Sort headers.
3375         * exceptions.c: Sort headers.
3376         * event-top.c: Sort headers.
3377         * event-loop.c: Sort headers.
3378         * eval.c: Sort headers.
3379         * elfread.c: Sort headers.
3380         * dwarf2read.h: Sort headers.
3381         * dwarf2read.c: Sort headers.
3382         * dwarf2loc.c: Sort headers.
3383         * dwarf2expr.h: Sort headers.
3384         * dwarf2expr.c: Sort headers.
3385         * dwarf2-frame.c: Sort headers.
3386         * dwarf2-frame-tailcall.c: Sort headers.
3387         * dwarf-index-write.h: Sort headers.
3388         * dwarf-index-write.c: Sort headers.
3389         * dwarf-index-common.c: Sort headers.
3390         * dwarf-index-cache.h: Sort headers.
3391         * dwarf-index-cache.c: Sort headers.
3392         * dummy-frame.c: Sort headers.
3393         * dtrace-probe.c: Sort headers.
3394         * disasm.h: Sort headers.
3395         * disasm.c: Sort headers.
3396         * disasm-selftests.c: Sort headers.
3397         * dictionary.c: Sort headers.
3398         * dicos-tdep.c: Sort headers.
3399         * demangle.c: Sort headers.
3400         * dcache.h: Sort headers.
3401         * dcache.c: Sort headers.
3402         * darwin-nat.h: Sort headers.
3403         * darwin-nat.c: Sort headers.
3404         * darwin-nat-info.c: Sort headers.
3405         * d-valprint.c: Sort headers.
3406         * d-namespace.c: Sort headers.
3407         * d-lang.c: Sort headers.
3408         * ctf.c: Sort headers.
3409         * csky-tdep.c: Sort headers.
3410         * csky-linux-tdep.c: Sort headers.
3411         * cris-tdep.c: Sort headers.
3412         * cris-linux-tdep.c: Sort headers.
3413         * cp-valprint.c: Sort headers.
3414         * cp-support.c: Sort headers.
3415         * cp-namespace.c: Sort headers.
3416         * cp-abi.c: Sort headers.
3417         * corelow.c: Sort headers.
3418         * corefile.c: Sort headers.
3419         * continuations.c: Sort headers.
3420         * completer.h: Sort headers.
3421         * completer.c: Sort headers.
3422         * complaints.c: Sort headers.
3423         * coffread.c: Sort headers.
3424         * coff-pe-read.c: Sort headers.
3425         * cli-out.h: Sort headers.
3426         * cli-out.c: Sort headers.
3427         * charset.c: Sort headers.
3428         * c-varobj.c: Sort headers.
3429         * c-valprint.c: Sort headers.
3430         * c-typeprint.c: Sort headers.
3431         * c-lang.c: Sort headers.
3432         * buildsym.c: Sort headers.
3433         * buildsym-legacy.c: Sort headers.
3434         * build-id.h: Sort headers.
3435         * build-id.c: Sort headers.
3436         * btrace.c: Sort headers.
3437         * bsd-uthread.c: Sort headers.
3438         * breakpoint.h: Sort headers.
3439         * breakpoint.c: Sort headers.
3440         * break-catch-throw.c: Sort headers.
3441         * break-catch-syscall.c: Sort headers.
3442         * break-catch-sig.c: Sort headers.
3443         * blockframe.c: Sort headers.
3444         * block.c: Sort headers.
3445         * bfin-tdep.c: Sort headers.
3446         * bfin-linux-tdep.c: Sort headers.
3447         * bfd-target.c: Sort headers.
3448         * bcache.c: Sort headers.
3449         * ax-general.c: Sort headers.
3450         * ax-gdb.h: Sort headers.
3451         * ax-gdb.c: Sort headers.
3452         * avr-tdep.c: Sort headers.
3453         * auxv.c: Sort headers.
3454         * auto-load.c: Sort headers.
3455         * arm-wince-tdep.c: Sort headers.
3456         * arm-tdep.c: Sort headers.
3457         * arm-symbian-tdep.c: Sort headers.
3458         * arm-pikeos-tdep.c: Sort headers.
3459         * arm-obsd-tdep.c: Sort headers.
3460         * arm-nbsd-tdep.c: Sort headers.
3461         * arm-nbsd-nat.c: Sort headers.
3462         * arm-linux-tdep.c: Sort headers.
3463         * arm-linux-nat.c: Sort headers.
3464         * arm-fbsd-tdep.c: Sort headers.
3465         * arm-fbsd-nat.c: Sort headers.
3466         * arm-bsd-tdep.c: Sort headers.
3467         * arch-utils.c: Sort headers.
3468         * arc-tdep.c: Sort headers.
3469         * arc-newlib-tdep.c: Sort headers.
3470         * annotate.h: Sort headers.
3471         * annotate.c: Sort headers.
3472         * amd64-windows-tdep.c: Sort headers.
3473         * amd64-windows-nat.c: Sort headers.
3474         * amd64-tdep.c: Sort headers.
3475         * amd64-sol2-tdep.c: Sort headers.
3476         * amd64-obsd-tdep.c: Sort headers.
3477         * amd64-obsd-nat.c: Sort headers.
3478         * amd64-nbsd-tdep.c: Sort headers.
3479         * amd64-nbsd-nat.c: Sort headers.
3480         * amd64-nat.c: Sort headers.
3481         * amd64-linux-tdep.c: Sort headers.
3482         * amd64-linux-nat.c: Sort headers.
3483         * amd64-fbsd-tdep.c: Sort headers.
3484         * amd64-fbsd-nat.c: Sort headers.
3485         * amd64-dicos-tdep.c: Sort headers.
3486         * amd64-darwin-tdep.c: Sort headers.
3487         * amd64-bsd-nat.c: Sort headers.
3488         * alpha-tdep.c: Sort headers.
3489         * alpha-obsd-tdep.c: Sort headers.
3490         * alpha-nbsd-tdep.c: Sort headers.
3491         * alpha-mdebug-tdep.c: Sort headers.
3492         * alpha-linux-tdep.c: Sort headers.
3493         * alpha-linux-nat.c: Sort headers.
3494         * alpha-bsd-tdep.c: Sort headers.
3495         * alpha-bsd-nat.c: Sort headers.
3496         * aix-thread.c: Sort headers.
3497         * agent.c: Sort headers.
3498         * addrmap.c: Sort headers.
3499         * ada-varobj.c: Sort headers.
3500         * ada-valprint.c: Sort headers.
3501         * ada-typeprint.c: Sort headers.
3502         * ada-tasks.c: Sort headers.
3503         * ada-lang.c: Sort headers.
3504         * aarch64-tdep.c: Sort headers.
3505         * aarch64-ravenscar-thread.c: Sort headers.
3506         * aarch64-newlib-tdep.c: Sort headers.
3507         * aarch64-linux-tdep.c: Sort headers.
3508         * aarch64-linux-nat.c: Sort headers.
3509         * aarch64-fbsd-tdep.c: Sort headers.
3510         * aarch64-fbsd-nat.c: Sort headers.
3511         * aarch32-linux-nat.c: Sort headers.
3512
3513 2019-04-04  Tom Tromey  <tom@tromey.com>
3514
3515         * varobj.c (varobj_create): Update.
3516         * rust-exp.y (struct rust_parser) <update_innermost_block,
3517         lookup_symbol>: New methods.
3518         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3519         Rename.
3520         (rust_parser::rust_lookup_type)
3521         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3522         * printcmd.c (display_command, do_one_display): Update.
3523         * parser-defs.h (struct parser_state) <parser_state>: Add
3524         "tracker" parameter.
3525         (block_tracker): New member.
3526         (class innermost_block_tracker) <innermost_block_tracker>: Add
3527         "types" parameter.
3528         <reset>: Remove method.
3529         (innermost_block): Don't declare.
3530         (null_post_parser): Update.
3531         * parse.c (innermost_block): Remove global.
3532         (write_dollar_variable): Update.
3533         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3534         Remove "tracker_types" parameter.
3535         (parse_expression): Add "tracker" parameter.
3536         (parse_expression_for_completion): Update.
3537         (null_post_parser): Add "tracker" parameter.
3538         * p-exp.y: Update rules.
3539         * m2-exp.y: Update rules.
3540         * language.h (struct language_defn) <la_post_parser>: Add
3541         "tracker" parameter.
3542         * go-exp.y: Update rules.
3543         * f-exp.y: Update rules.
3544         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3545         parameter.
3546         * d-exp.y: Update rules.
3547         * c-exp.y: Update rules.
3548         * breakpoint.c (set_breakpoint_condition): Create an
3549         innermost_block_tracker.
3550         (watch_command_1): Likewise.
3551         * ada-lang.c (resolve): Add "tracker" parameter.
3552         (resolve_subexp): Likewise.
3553         * ada-exp.y (write_var_from_sym): Update.
3554
3555 2019-04-04  Tom Tromey  <tom@tromey.com>
3556
3557         * type-stack.h: New file.
3558         * type-stack.c: New file.
3559         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3560         type-stack.h.
3561         (insert_into_type_stack, insert_type, push_type, push_type_int)
3562         (insert_type_address_space, pop_type, pop_type_int)
3563         (pop_typelist, pop_type_stack, append_type_stack)
3564         (push_type_stack, get_type_stack, push_typelist)
3565         (follow_type_instance_flags, follow_types): Don't declare.
3566         * parse.c (type_stack): Remove global.
3567         (parse_exp_in_context): Update.
3568         (insert_into_type_stack, insert_type, push_type, push_type_int)
3569         (insert_type_address_space, pop_type, pop_type_int)
3570         (pop_typelist, pop_type_stack, append_type_stack)
3571         (push_type_stack, get_type_stack, push_typelist)
3572         (follow_type_instance_flags, follow_types): Remove (moved to
3573         type-stack.c).
3574         * f-exp.y (type_stack): New global.
3575         Update rules.
3576         (push_kind_type, f_parse): Update.
3577         * d-exp.y (type_stack): New global.
3578         Update rules.
3579         (d_parse): Update.
3580         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3581         Update rules.
3582         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3583         (HFILES_NO_SRCDIR): Add type-stack.h.
3584
3585 2019-04-04  Tom Tromey  <tom@tromey.com>
3586
3587         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3588         (rust_parser::convert_ast_to_expression, rust_parse)
3589         (rust_lex_test_completion, rust_lex_tests): Update.
3590         * parser-defs.h (struct expr_completion_state): New.
3591         (struct parser_state) <parser_state>: Add completion parameter.
3592         <mark_struct_expression, mark_completion_tag>: New methods.
3593         <parse_completion, m_completion_state>: New members.
3594         (prefixify_expression, null_post_parser): Update.
3595         (mark_struct_expression, mark_completion_tag): Don't declare.
3596         * parse.c (parse_completion, expout_last_struct)
3597         (expout_tag_completion_type, expout_completion_name): Remove
3598         globals.
3599         (parser_state::mark_struct_expression)
3600         (parser_state::mark_completion_tag): Now methods.
3601         (prefixify_expression): Add last_struct parameter.
3602         (prefixify_subexp): Likewise.
3603         (parse_exp_1): Update.
3604         (parse_exp_in_context): Add cstate parameter.  Update.
3605         (parse_expression_for_completion): Create an
3606         expr_completion_state.
3607         (null_post_parser): Add "completion" parameter.
3608         * p-exp.y: Update rules.
3609         (yylex): Update.
3610         * language.h (struct language_defn) <la_post_parser>: Add
3611         "completing" parameter.
3612         * go-exp.y: Update rules.
3613         (lex_one_token): Update.
3614         * expression.h (parse_completion): Don't declare.
3615         * d-exp.y: Update rules.
3616         (lex_one_token): Update rules.
3617         * c-exp.y: Update rules.
3618         (lex_one_token): Update.
3619         * ada-lang.c (resolve): Add "parse_completion" parameter.
3620         (resolve_subexp): Likewise.
3621         (ada_resolve_function): Likewise.
3622
3623 2019-04-04  Tom Tromey  <tom@tromey.com>
3624
3625         * parser-defs.h (struct parser_state) <start_arglist,
3626         end_arglist>: New methods.
3627         <arglist_len, m_funcall_chain>: New members.
3628         (arglist_len, start_arglist, end_arglist): Don't declare.
3629         * parse.c (arglist_len, funcall_chain): Remove global.
3630         (start_arglist, end_arglist): Remove functions.
3631         (parse_exp_in_context): Update.
3632         * p-exp.y: Update rules.
3633         * m2-exp.y: Update rules.
3634         * go-exp.y: Update rules.
3635         * f-exp.y: Update rules.
3636         * d-exp.y: Update rules.
3637         * c-exp.y: Update rules.
3638
3639 2019-04-04  Tom Tromey  <tom@tromey.com>
3640
3641         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3642         lex_operator, push_back>: New methods.
3643         Update all rules.
3644         (rust_parser::lex_hex, lex_escape): Rename and update.
3645         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3646         (rust_parser::lex_operator): Rename and update.
3647         (rust_parser::lex_number, rustyylex, rustyyerror)
3648         (rust_lex_test_init, rust_lex_test_sequence)
3649         (rust_lex_test_push_back, rust_lex_tests): Update.
3650         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3651         parameter.
3652         <lexptr, prev_lexptr>: New members.
3653         (lexptr, prev_lexptr): Don't declare.
3654         * parse.c (lexptr, prev_lexptr): Remove globals.
3655         (parse_exp_in_context): Update.
3656         * p-exp.y (yylex, yyerror): Update.
3657         * m2-exp.y (parse_number, yylex, yyerror): Update.
3658         * go-exp.y (lex_one_token, yyerror): Update.
3659         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3660         * d-exp.y (lex_one_token, yyerror): Update.
3661         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3662         (lex_one_token, yyerror): Update.
3663         * ada-lex.l (YY_INPUT): Update.
3664         (rewind_to_char): Update.
3665         * ada-exp.y (yyerror): Update.
3666
3667 2019-04-04  Tom Tromey  <tom@tromey.com>
3668
3669         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3670         * parser-defs.h (struct parser_state) <parser_state>: Add new
3671         parameter.
3672         <comma_terminates>: New member.
3673         (comma_terminates): Don't declare global.
3674         * parse.c (comma_terminates): Remove global.
3675         (parse_exp_in_context): Update.
3676         * p-exp.y (yylex): Update.
3677         * m2-exp.y (yylex): Update.
3678         * go-exp.y (lex_one_token): Update.
3679         * f-exp.y (yylex): Update.
3680         * d-exp.y (lex_one_token): Update.
3681         * c-exp.y (lex_one_token): Update.
3682         * ada-lex.l: Update.
3683
3684 2019-04-04  Tom Tromey  <tom@tromey.com>
3685
3686         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3687         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3688         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3689         * parser-defs.h (paren_depth): Don't declare.
3690         * parse.c (paren_depth): Remove global.
3691         (parse_exp_in_context): Update.
3692         * p-exp.y (paren_depth): New global.
3693         (pascal_parse): Initialize it.
3694         * m2-exp.y (paren_depth): New global.
3695         (m2_parse): Initialize it.
3696         * go-exp.y (paren_depth): New global.
3697         (go_parse): Initialize it.
3698         * f-exp.y (paren_depth): New global.
3699         (f_parse): Initialize it.
3700         * d-exp.y (paren_depth): New global.
3701         (d_parse): Initialize it.
3702         * c-exp.y (paren_depth): New global.
3703         (c_parse): Initialize it.
3704         * ada-lex.l (paren_depth): New global.
3705         (lexer_init): Initialize it.
3706
3707 2019-04-04  Tom Tromey  <tom@tromey.com>
3708
3709         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3710         (rust_parser::convert_ast_to_type)
3711         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3712         * parser-defs.h (struct parser_state) <parser_state>: Add
3713         parameters.  Initialize new members.
3714         <expression_context_block, expression_context_pc>: New members.
3715         * parse.c (expression_context_block, expression_context_pc):
3716         Remove globals.
3717         (parse_exp_in_context): Update.
3718         * p-exp.y: Update all rules.
3719         (yylex): Update.
3720         * m2-exp.y: Update all rules.
3721         (yylex): Update.
3722         * go-exp.y (yylex): Update.
3723         * f-exp.y (yylex): Update.
3724         * d-exp.y: Update all rules.
3725         (yylex): Update.
3726         * c-exp.y: Update all rules.
3727         (lex_one_token, classify_name, yylex, c_parse): Update.
3728         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3729
3730 2019-04-04  Tom Tromey  <tom@tromey.com>
3731
3732         * gdbarch.h, gdbarch.c: Rebuild.
3733         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3734         * stap-probe.h:
3735         (struct stap_parse_info): Replace "parser_state" with
3736         "expr_builder".
3737         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3738         (parser_state): New class.
3739         * parse.c (expr_builder): Rename.
3740         (expr_builder::release): Rename.
3741         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3742         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3743         (write_exp_elt_longcst, write_exp_elt_floatcst)
3744         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3745         (write_exp_string_vector, write_exp_bitstring)
3746         (write_exp_msymbol, mark_struct_expression)
3747         (write_dollar_variable)
3748         (insert_type_address_space, increase_expout_size): Replace
3749         "parser_state" with "expr_builder".
3750         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3751         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3752         "parser_state" with "expr_builder".
3753
3754 2019-04-04  Tom Tromey  <tom@tromey.com>
3755
3756         * rust-exp.y: Replace "parse_language" with method call.
3757         * p-exp.y:
3758         (yylex): Replace "parse_language" with method call.
3759         * m2-exp.y:
3760         (yylex): Replace "parse_language" with method call.
3761         * go-exp.y (classify_name): Replace "parse_language" with method
3762         call.
3763         * f-exp.y (yylex): Replace "parse_language" with method call.
3764         * d-exp.y (lex_one_token): Replace "parse_language" with method
3765         call.
3766         * c-exp.y:
3767         (lex_one_token, classify_name, yylex): Replace "parse_language"
3768         with method call.
3769         * ada-exp.y (find_primitive_type, type_char)
3770         (type_system_address): Replace "parse_language" with method call.
3771
3772 2019-04-04  Tom Tromey  <tom@tromey.com>
3773
3774         * rust-exp.y: Replace "parse_gdbarch" with method call.
3775         * parse.c (write_dollar_variable, insert_type_address_space):
3776         Replace "parse_gdbarch" with method call.
3777         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3778         call.
3779         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3780         call.
3781         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3782         "parse_gdbarch" with method call.
3783         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3784         with method call.
3785         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3786         "parse_gdbarch" with method call.
3787         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3788         "parse_gdbarch" with method call.
3789         * c-exp.y (parse_type, parse_number, classify_name): Replace
3790         "parse_gdbarch" with method call.
3791         * ada-lex.l: Replace "parse_gdbarch" with method call.
3792         * ada-exp.y (parse_type, find_primitive_type, type_char)
3793         (type_system_address): Replace "parse_gdbarch" with method call.
3794
3795 2019-04-04  Tom Tromey  <tom@tromey.com>
3796
3797         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3798         * stap-probe.c (stap_parse_argument): Update.
3799         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3800         initial_size parameter.
3801         * rust-exp.y (rust_lex_tests): Update.
3802         * parse.c (parser_state): Update.
3803         (parse_exp_in_context): Update.
3804         * parser-defs.h (struct parser_state) <parser_state>: Remove
3805         "initial_size" parameter.
3806
3807 2019-04-04  Tom Tromey  <tom@tromey.com>
3808
3809         * parser-defs.h (increase_expout_size): Don't declare.
3810         * parse.c (increase_expout_size): Now static.
3811
3812 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3813
3814         * gnu-nat.c (gnu_nat_target::wait): Fix
3815         target_waitstatus_to_string call.
3816
3817 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * eval.c (evaluate_subexp_standard): Handle internal functions
3820         during Fortran function call handling.
3821
3822 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * NEWS: Mention new internal functions.
3825         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3826         (read_base_type): Use dwarf2_init_complex_target_type.
3827         * value.c (creal_internal_fn): New function.
3828         (cimag_internal_fn): New function.
3829         (_initialize_values): Register new internal functions.
3830
3831 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3832
3833         * infrun.c (stop_all_threads): If debug_infrun, always
3834         trace the wait status after wait_one, using
3835         target_waitstatus_to_string and target_pid_to_str.
3836         (handle_inferior_event): Replace various trace of
3837         wait status kind by a single trace.
3838         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3839         wait status kind image by target_waitstatus_to_string.
3840         * target/waitstatus.c (target_waitstatus_to_string): Fix
3841         obsolete comment.
3842
3843 2019-04-01  Tom Tromey  <tromey@adacore.com>
3844
3845         PR symtab/23331:
3846         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3847
3848 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3849             Pedro Alves  <palves@redhat.com>
3850
3851         * top.c (quit_force): Call 'finalize_values'.
3852         * value.c (finalize_values): New function.
3853         * value.h (finalize_values): Declare.
3854
3855 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3856
3857         * NEWS: Announce $_gdb_major and $_gdb_minor.
3858
3859         * top.c (init_gdb_version_vars): New function.
3860         (gdb_init): Call init_gdb_version_vars.
3861
3862 2019-03-29  Tom Tromey  <tromey@adacore.com>
3863
3864         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3865         help text.  Remove dead code.
3866
3867 2019-03-29  Keith Seitz  <keiths@redhat.com>
3868
3869         From Siddhesh Poyarekar:
3870         * f-lang.h (f77_get_upperbound): Return LONGEST.
3871         (f77_get_lowerbound): Likewise.
3872         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3873         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3874         print them.
3875         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3876         plongest to format print it.
3877         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3878         (f77_get_upperbound): Likewise.
3879         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3880         LOWER_BOUND to LONGEST.
3881         (f77_create_arrayprint_offset_tbl): Likewise.
3882
3883 2019-03-29  Keith Seitz  <keiths@redhat.com>
3884
3885         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3886         %s/pulongest for TYPE_LENGTH instead of %d in format
3887         strings.
3888         * ada-typerint.c (ada_print_type): Likewise.
3889         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3890         * compile/compile-c-support.c (generate_register_struct): Likewise.
3891         * gdbtypes.c (recursive_dump_type): Likewise.
3892         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3893         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3894         instead of %d in format strings.
3895         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3896         to std::min to ULONGEST.
3897         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3898         instead of %d in format strings.
3899         * tracepoint.c (info_scope_command): Likewise.
3900         * typeprint.c (print_offset_data::update)
3901         (print_offset_data::finish): Likewise.
3902         * xtensa-tdep.c (xtensa_store_return_value)
3903         (xtensa_push_dummy_call): Likewise.
3904
3905 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3906
3907         * windows-nat.c (display_selector): Fixed format specifications
3908         for 64-bit Cygwin.
3909
3910 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3911
3912         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3913
3914 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3915
3916         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3917         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3918         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3919         (nios2_linux_init_abi): Install it.
3920
3921 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3922
3923         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3924
3925 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3926
3927         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3928
3929 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3930             Tom Tromey  <tromey@adacore.com>
3931
3932         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3933
3934 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3935
3936         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3937         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3938         method to compute the bounds of range types. Also print "[evaluated]"
3939         if the bounds' values come from a dynamic evaluation.
3940
3941 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3944         whitespace when pretty printing is on.
3945
3946 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3947
3948         * ppc-linux-nat.c: Add include.
3949
3950 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3951
3952         * NEWS: Mention AArch64 Pointer Authentication.
3953
3954 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3955
3956         * arm-linux-nat.c: Add include.
3957
3958 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3959
3960         * source-cache.c (source_cache::get_source_lines): Re-read
3961         fullname after calling open_source_file.
3962
3963 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3964
3965         * NEWS: Mention TLS support for FreeBSD.
3966
3967 2019-03-25  Tom Tromey  <tromey@adacore.com>
3968
3969         * minsyms.c (BUNCH_SIZE): Update comment.
3970         (~minimal_symbol_reader): Remove old comment.
3971         (compact_minimal_symbols): Update comment.
3972         (minimal_symbol_reader::install): Remove old comment.  Update
3973         other comments.
3974
3975 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3976
3977         * s390-linux-nat.c: Add include.
3978
3979 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3980
3981         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3982         Call linux_get_hwcap.
3983         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3984         Likewise.
3985         (aarch64_linux_get_hwcap): Remove function.
3986         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3987         declaration.
3988         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3989         linux_get_hwcap.
3990         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3991         * linux-tdep.c (linux_get_hwcap): Add function.
3992         (linux_get_hwcap2): Likewise.
3993         * linux-tdep.h (linux_get_hwcap): Add declaration.
3994         (linux_get_hwcap2): Likewise.
3995         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3996         (ppc_linux_get_hwcap2): Likewise.
3997         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3998         linux_get_hwcap.
3999         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4000         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4001         (ppc_linux_nat_target::read_description): Likewise.
4002         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4003         * s390-linux-nat.c: Likewise.
4004         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4005
4006 2019-03-24  Tom Tromey  <tom@tromey.com>
4007
4008         * ada-lang.c (standard_lookup): Simplify initialization.
4009         (ada_lookup_symbol_nonlocal): Simplify return.
4010         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4011         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4012         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4013         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4014         initialization.
4015         * solib.c (solib_global_lookup): Simplify.
4016         * symtab.c (null_block_symbol): Remove.
4017         (symbol_cache_lookup): Simplify returns.
4018         (lookup_language_this): Simplify returns.
4019         (lookup_symbol_aux): Simplify return.
4020         (lookup_local_symbol): Simplify returns.
4021         (lookup_global_symbol_from_objfile): Simplify return.
4022         (lookup_symbol_in_objfile_symtabs)
4023         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4024         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4025         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4026         * cp-namespace.c (cp_lookup_bare_symbol)
4027         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4028         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4029         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4030         (cp_lookup_symbol_via_imports): Simplify initialization.
4031         (find_symbol_in_baseclass): Likewise.
4032         * symtab.h (null_block_symbol): Remove.
4033         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4034         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4035         (d_lookup_symbol_module): Likewise.
4036         (find_symbol_in_baseclass): Simplify initialization.
4037
4038 2019-03-24  Tom Tromey  <tom@tromey.com>
4039
4040         * expression.h: Don't include symtab.h.
4041         (struct block): Forward declare.
4042
4043 2019-03-24  Tom Tromey  <tom@tromey.com>
4044
4045         * c-exp.y (typebase): Remove casts.
4046         * gdbtypes.c (lookup_unsigned_typename, )
4047         (lookup_signed_typename): Remove cast.
4048         * eval.c (parse_to_comma_and_eval): Remove cast.
4049         * parse.c (write_dollar_variable): Remove cast.
4050         * block.h (struct block) <superblock>: Now const.
4051         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4052         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4053         (map_block): Make "block" const.
4054         * symfile.h (struct quick_symbol_functions)
4055         <map_matching_symbols>: Constify block argument to "callback".
4056         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4057         const.
4058         (find_pc_sect_compunit_symtab): Make "b" const.
4059         (find_symbol_at_address): Likewise.
4060         (search_symbols): Likewise.
4061         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4062         (dw2_debug_names_lookup_symbol): Likewise.
4063         (dw2_map_matching_symbols): Update.
4064         * p-valprint.c (pascal_val_print): Remove "block".
4065         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4066         (aux_add_nonlocal_symbols): Make "block" const.
4067         (resolve_subexp): Remove cast.
4068         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4069         const.
4070         (iterate_over_file_blocks): Likewise.
4071         * f-exp.y (%union) <bval>: Remove.
4072         * coffread.c (patch_opaque_types): Make "b" const.
4073         * spu-tdep.c (spu_catch_start): Make "block" const.
4074         * c-valprint.c (print_unpacked_pointer): Remove "block".
4075         * symmisc.c (dump_symtab_1): Make "b" const.
4076         (block_depth): Make "block" const.
4077         * d-exp.y (%union) <bval>: Remove.
4078         * cp-support.h (cp_lookup_rtti_type): Update.
4079         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4080         * psymtab.c (psym_lookup_symbol): Make "block" const.
4081         (maintenance_check_psymtabs): Make "b" const.
4082         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4083         (enumerate_locals, enumerate_args): Update.
4084         * python/py-symtab.c (stpy_global_block): Make "block" const.
4085         (stpy_static_block): Likewise.
4086         * inline-frame.c (block_starting_point_at): Make "new_block"
4087         const.
4088         * block.c (find_block_in_blockvector): Make return type const.
4089         (blockvector_for_pc_sect): Make "b" const.
4090         (find_block_in_blockvector): Make "b" const.
4091
4092 2019-03-23  Tom Tromey  <tom@tromey.com>
4093
4094         * varobj.c (varobj_create): Update.
4095         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4096         * printcmd.c (display_command, do_one_display): Don't reset
4097         innermost_block.
4098         * parser-defs.h (enum innermost_block_tracker_type): Move to
4099         expression.h.
4100         (innermost_block): Update comment.
4101         * parse.c (parse_exp_1): Add tracker_types parameter.
4102         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4103         tracker_types parameter.  Reset innermost_block.
4104         (parse_exp_in_context): Remove.
4105         (parse_expression_for_completion): Update.
4106         * objfiles.c (~objfile): Don't reset expression_context_block or
4107         innermost_block.
4108         * expression.h (enum innermost_block_tracker_type): Move from
4109         parser-defs.h.
4110         (parse_exp_1): Add tracker_types parameter.
4111         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4112         reset innermost_block.
4113
4114 2019-03-23  Tom Tromey  <tom@tromey.com>
4115
4116         * objfiles.h: Include bcache.h.
4117
4118 2019-03-23  Tom Tromey  <tom@tromey.com>
4119
4120         * linespec.c (get_current_search_block): Use
4121         scoped_restore_current_language.
4122         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4123
4124 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4125             Jiong Wang  <jiong.wang@arm.com>
4126
4127         * aarch64-linux-tdep.c
4128         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4129         section.
4130         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4131
4132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4133             Jiong Wang  <jiong.wang@arm.com>
4134
4135         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4136         instructions.
4137         (aarch64_analyze_prologue_test): Add PACIASP test.
4138         (aarch64_prologue_prev_register): Unmask PC value.
4139
4140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4141             Jiong Wang  <jiong.wang@arm.com>
4142
4143         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4144         (aarch64_dwarf2_prev_register): Unmask PC value.
4145         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4146         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4147         DW_CFA_AARCH64_negate_ra_state.
4148         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4149
4150 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4151             Jiong Wang  <jiong.wang@arm.com>
4152
4153         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4154         registers.
4155         (aarch64_pseudo_register_name): Likewise.
4156         (aarch64_pseudo_register_type): Likewise.
4157         (aarch64_pseudo_register_reggroup_p): Likewise.
4158         (aarch64_gdbarch_init): Add pauth registers.
4159         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4160         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4161         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4162         (struct gdbarch_tdep): Add regnum for ra_state.
4163
4164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4165             Jiong Wang  <jiong.wang@arm.com>
4166
4167         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4168
4169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4170             Jiong Wang  <jiong.wang@arm.com>
4171
4172         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4173         function.
4174         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4175         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4176         (aarch64_gdbarch_init): Add puth registers.
4177         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4178         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4179         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4180
4181 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4182             Jiong Wang  <jiong.wang@arm.com>
4183
4184         * aarch64-linux-nat.c
4185         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4186         * aarch64-linux-tdep.c
4187         (aarch64_linux_core_read_description): Likewise.
4188         (aarch64_linux_get_hwcap): New function.
4189         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4190         (aarch64_linux_get_hwcap): New declaration.
4191
4192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4193             Jiong Wang  <jiong.wang@arm.com>
4194
4195         * aarch64-linux-nat.c
4196         (aarch64_linux_nat_target::read_description): Add pauth param.
4197         * aarch64-linux-tdep.c
4198         (aarch64_linux_core_read_description): Likewise.
4199         * aarch64-tdep.c (struct target_desc): Add in pauth.
4200         (aarch64_read_description): Add pauth param.
4201         (aarch64_gdbarch_init): Likewise.
4202         * aarch64-tdep.h (aarch64_read_description): Likewise.
4203         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4204         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4205         * features/Makefile: Add new files.
4206         * features/aarch64-pauth.c: New file.
4207         * features/aarch64-pauth.xml: New file.
4208
4209 2019-03-20  Tom Tromey  <tromey@adacore.com>
4210
4211         * infrun.c (handle_inferior_event): Rename from
4212         handle_inferior_event_1.  Create a scoped_value_mark.
4213         (handle_inferior_event): Remove.
4214
4215 2019-03-19  Tom Tromey  <tromey@adacore.com>
4216
4217         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4218         * infrun.h (print_stop_event): Add "displays" parameter.
4219         * infrun.c (print_stop_event): Add "displays" parameter.
4220
4221 2019-03-19  Pedro Alves  <palves@redhat.com>
4222
4223         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4224         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4225         to -1.  Fix TABs vs spaces.
4226         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4227         * tui/tui-out.h (tui_ui_out) Add intro comments.
4228         <m_line, m_start_of_line>: In-class initialize, and add describing
4229         comment.
4230
4231 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4232
4233         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4234         variable names.
4235         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4236
4237 2019-03-18  Pedro Alves  <palves@redhat.com>
4238             Eli Zaretskii <eliz@gnu.org>
4239
4240         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4241         m_line and m_start_of_line.
4242
4243 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4244
4245         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4246         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4247         it returns a newline.  This fixes a regression in TU mode, whereby
4248         the next line is output on the same screen line as the user input.
4249
4250 2019-03-18  Tom Tromey  <tromey@adacore.com>
4251
4252         * minsyms.c (minimal_symbol_reader::install): Remove call to
4253         obstack_blank.
4254
4255 2019-03-18  Pedro Alves  <palves@redhat.com>
4256
4257         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4258         New globals.
4259         (apply_style): New, factored out from ...
4260         (apply_ansi_escape): ... this.  Handle reverse video mode.
4261         (tui_set_reverse_mode): New function.
4262         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4263         * tui/tui-winsource.c (tui_show_source_line): Use
4264         tui_set_reverse_mode instead of setting A_STANDOUT.
4265         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4266         New setter methods.
4267
4268 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4269
4270         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4271         Handle tabs.
4272
4273 2019-03-18  Tom Tromey  <tromey@adacore.com>
4274
4275         * ada-lang.c (empty_array): Add "high" parameter.
4276         (ada_evaluate_subexp): Update.
4277
4278 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4279
4280         * unittests/string_view-selftests.c: Define
4281         _initialize_string_view_selftests unconditionally.
4282
4283 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4284
4285         PR gdb/24350
4286         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4287
4288 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4289
4290         PR gdb/24351
4291         * windows-nat.c (display_selector): Fix format specifiers.
4292
4293 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4294
4295         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4296         tui_refill_source_window instead of tui_refresh_win, to update the
4297         current execution line.  This fixes redisplay of the current line
4298         when stepping through the code with "next" or "step".
4299
4300 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4301
4302         * source-cache.c (source_cache::get_source_lines): Call
4303         find_source_lines to initialize s->nlines.  This fixes vertical
4304         scrolling of TUI source window when the DOWN arrow is pressed.
4305
4306 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4309         linux-thread-db.c (_initialize_thread_db): Likewise.
4310
4311 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4312
4313         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4314         wclrtoeol in tui_show_source_line".  This reverts changes made in
4315         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4316
4317 2019-03-15  Tom Tromey  <tom@tromey.com>
4318
4319         * symtab.h (struct minimal_symbol): Derive from
4320         general_symbol_info.
4321         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4322         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4323         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4324         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4325         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4326         (MSYMBOL_SEARCH_NAME): Update.
4327         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4328         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4329         * minsyms.c (minimal_symbol_reader::record_full): Update.
4330
4331 2019-03-15  Tom Tromey  <tom@tromey.com>
4332
4333         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4334
4335 2019-03-15  Tom Tromey  <tom@tromey.com>
4336
4337         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4338         unique_xmalloc_ptr.
4339         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4340         Update.
4341         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4342         (build_minimal_symbol_hash_tables)
4343         (minimal_symbol_reader::install): Update.
4344
4345 2019-03-15  Tom Tromey  <tom@tromey.com>
4346
4347         * symtab.c (create_demangled_names_hash): Update.
4348         (symbol_set_names): Update.
4349         * objfiles.h (struct objfile_per_bfd_storage)
4350         <demangled_names_hash>: Now an htab_up.
4351         * objfiles.c (objfile_per_bfd_storage): Simplify.
4352
4353 2019-03-15  Tom Tromey  <tom@tromey.com>
4354
4355         * objfiles.h (struct objfile_per_bfd_storage): Declare
4356         destructor.
4357         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4358         New.
4359         (get_objfile_bfd_data): Use new.  Don't initialize
4360         language_of_main.
4361         (free_objfile_per_bfd_storage): Remove.
4362         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4363
4364 2019-03-15  Tom Tromey  <tom@tromey.com>
4365
4366         * symfile.c (reread_symbols): Update.
4367         * objfiles.c (objfile::objfile): Update.
4368         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4369         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4370         comment.
4371         (minimal_symbol_reader::install): Update.
4372         (terminate_minimal_symbol_table): Remove.
4373         * jit.c (jit_object_close_impl): Update.
4374
4375 2019-03-15  Tom Tromey  <tom@tromey.com>
4376
4377         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4378         initializations.
4379
4380 2019-03-15  Tom Tromey  <tom@tromey.com>
4381
4382         * objfiles.h (struct objfile_per_bfd_storage)
4383         <demangled_hash_languages>: Now a bitset.
4384         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4385         (lookup_minimal_symbol): Update.
4386
4387 2019-03-15  Tom Tromey  <tom@tromey.com>
4388
4389         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4390         Don't return the symbol.
4391         * coffread.c (record_minimal_symbol): Use record_full.
4392
4393 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4394
4395         The MS-Windows port of ncurses fails to switch to a color pair if
4396         one or both of the colors are the implicit default colors.  This
4397         change records the default colors when TUI is initialized, and
4398         then specifies them explicitly when a color pair uses the default
4399         colors.  This allows color styling in TUI mode on MS-Windows.
4400
4401         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4402         ncurses_norm_attr.
4403         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4404         colors in ncurses_norm_attr.
4405         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4406         "none", replace it with the default color recorded in
4407         ncurses_norm_attr.
4408
4409 2019-03-14  Tom Tromey  <tromey@adacore.com>
4410
4411         * source-cache.h (class source_cache) <get_source_lines>: Return
4412         std::string.
4413         * source-cache.c (source_cache::extract_lines): Handle case where
4414         first_pos==npos.  Return std::string.
4415         (source_cache::get_source_lines): Update.
4416
4417 2019-03-14  Tom Tromey  <tromey@adacore.com>
4418
4419         * NEWS: Add item for "style sources" commands.
4420         * source-cache.c (source_cache::get_source_lines): Check
4421         source_styling.
4422         * cli/cli-style.c (source_styling): New global.
4423         (_initialize_cli_style): Add "style sources" commands.
4424         (show_style_sources): New function.
4425         * cli/cli-style.h (source_styling): Declare.
4426
4427 2019-03-14  Pedro Alves  <palves@redhat.com>
4428             Tom Tromey  <tromey@adacore.com>
4429
4430         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4431         * tui/tui-winsource.c (tui_refill_source_window): New function,
4432         from...
4433         (tui_horizontal_source_scroll): ... here.  Move some logic.
4434         * cli/cli-style.c (set_style_enabled): Notify new observable.
4435         * tui/tui-hooks.c (tui_redisplay_source): New function.
4436         (tui_attach_detach_observers): Attach or detach
4437         tui_redisplay_source.
4438         * observable.h (source_styling_changed): New observable.
4439         * observable.c: Define source_styling_changed observable.
4440
4441 2019-03-13  Tom Tromey  <tromey@adacore.com>
4442
4443         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4444         (i386_gnu_nat_target::store_registers): Update.
4445         * target-debug.h (target_debug_print_std_string): New macro.
4446         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4447         * windows-tdep.c (display_one_tib): Update.
4448         * tui/tui-stack.c (tui_make_status_line): Update.
4449         * top.c (print_inferior_quit_action): Update.
4450         * thread.c (thr_try_catch_cmd): Update.
4451         (add_thread_with_info): Update.
4452         (thread_target_id_str): Update.
4453         (thr_try_catch_cmd): Update.
4454         (thread_command): Update.
4455         (thread_find_command): Update.
4456         * record-btrace.c (record_btrace_target::info_record)
4457         (record_btrace_resume_thread, record_btrace_target::resume)
4458         (record_btrace_cancel_resume, record_btrace_step_thread)
4459         (record_btrace_target::wait, record_btrace_target::wait)
4460         (record_btrace_target::wait, record_btrace_target::stop): Update.
4461         * progspace.c (print_program_space): Update.
4462         * process-stratum-target.c
4463         (process_stratum_target::thread_address_space): Update.
4464         * linux-fork.c (linux_fork_mourn_inferior)
4465         (detach_checkpoint_command, info_checkpoints_command)
4466         (linux_fork_context): Update.
4467         (linux_fork_detach): Update.
4468         (class scoped_switch_fork_info): Update.
4469         (delete_checkpoint_command): Update.
4470         * infrun.c (follow_fork_inferior): Update.
4471         (follow_fork_inferior): Update.
4472         (proceed_after_vfork_done): Update.
4473         (handle_vfork_child_exec_or_exit): Update.
4474         (follow_exec): Update.
4475         (displaced_step_prepare_throw): Update.
4476         (displaced_step_restore): Update.
4477         (start_step_over): Update.
4478         (resume_1): Update.
4479         (clear_proceed_status_thread): Update.
4480         (proceed): Update.
4481         (print_target_wait_results): Update.
4482         (do_target_wait): Update.
4483         (context_switch): Update.
4484         (stop_all_threads): Update.
4485         (restart_threads): Update.
4486         (finish_step_over): Update.
4487         (handle_signal_stop): Update.
4488         (switch_back_to_stepped_thread): Update.
4489         (keep_going_pass_signal): Update.
4490         (print_exited_reason): Update.
4491         (normal_stop): Update.
4492         * inferior.c (inferior_pid_to_str): Change return type.
4493         (print_selected_inferior): Update.
4494         (add_inferior): Update.
4495         (detach_inferior): Update.
4496         * dummy-frame.c (fprint_dummy_frames): Update.
4497         * dcache.c (dcache_info_1): Update.
4498         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4499         (btrace_fetch, btrace_clear): Update.
4500         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4501         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4502         type.
4503         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4504         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4505         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4506         * gdbarch.c, gdbarch.h: Rebuild.
4507         * gdbarch.sh (core_pid_to_str): Change return type.
4508         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4509         return type.
4510         (windows_nat_target::pid_to_str): Change return type.
4511         (windows_delete_thread): Update.
4512         (windows_nat_target::attach): Update.
4513         (windows_nat_target::files_info): Update.
4514         * target-delegates.c: Rebuild.
4515         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4516         return type.
4517         (sol_thread_target::pid_to_str): Change return type.
4518         * remote.c (class remote_target) <pid_to_str>: Change return
4519         type.
4520         (remote_target::pid_to_str): Change return type.
4521         (extended_remote_target::attach, remote_target::remote_stop_ns)
4522         (remote_target::remote_notif_remove_queued_reply)
4523         (remote_target::push_stop_reply, remote_target::disable_btrace):
4524         Update.
4525         (extended_remote_target::attach): Update.
4526         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4527         type.
4528         (gdbsim_target::pid_to_str): Change return type.
4529         * ravenscar-thread.c (struct ravenscar_thread_target)
4530         <pid_to_str>: Change return type.
4531         (ravenscar_thread_target::pid_to_str): Change return type.
4532         * procfs.c (class procfs_target) <pid_to_str>: Change return
4533         type.
4534         (procfs_target::pid_to_str): Change return type.
4535         (procfs_target::attach): Update.
4536         (procfs_target::detach): Update.
4537         (procfs_target::fetch_registers): Update.
4538         (procfs_target::store_registers): Update.
4539         (procfs_target::wait): Update.
4540         (procfs_target::files_info): Update.
4541         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4542         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4543         return type.
4544         (nto_procfs_target::pid_to_str): Change return type.
4545         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4546         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4547         return type.
4548         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4549         (exit_lwp): Update.
4550         (attach_proc_task_lwp_callback, get_detach_signal)
4551         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4552         (linux_nat_target::resume, wait_lwp, stop_callback)
4553         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4554         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4555         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4556         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4557         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4558         type.
4559         (inf_ptrace_target::attach): Update.
4560         (inf_ptrace_target::files_info): Update.
4561         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4562         type.
4563         (go32_nat_target::pid_to_str): Change return type.
4564         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4565         (gnu_nat_target::wait): Update.
4566         (gnu_nat_target::wait): Update.
4567         (gnu_nat_target::resume): Update.
4568         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4569         (fbsd_nat_target::wait): Update.
4570         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4571         type.
4572         (darwin_nat_target::attach): Update.
4573         * corelow.c (class core_target) <pid_to_str>: Change return type.
4574         (core_target::pid_to_str): Change return type.
4575         * target.c (normal_pid_to_str): Change return type.
4576         (default_pid_to_str): Likewise.
4577         (target_pid_to_str): Change return type.
4578         (target_translate_tls_address): Update.
4579         (target_announce_detach): Update.
4580         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4581         return type.
4582         (bsd_uthread_target::pid_to_str): Change return type.
4583         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4584         type.
4585         (bsd_kvm_target::pid_to_str): Change return type.
4586         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4587         return type.
4588         (aix_thread_target::pid_to_str): Change return type.
4589         * target.h (struct target_ops) <pid_to_str>: Change return type.
4590         (target_pid_to_str, normal_pid_to_str): Likewise.
4591         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4592         type.
4593         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4594         type.
4595         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4596         return type.
4597         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4598         type.
4599         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4600         type.
4601         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4602         return type.
4603
4604 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4605
4606         * NEWS: Mention that the new default MI version is 3.  Mention
4607         changes to the output of commands and events that deal with
4608         multi-location breakpoints.
4609         * breakpoint.c: Include "mi/mi-out.h".
4610         (print_one_breakpoint): Change output syntax if using MI version
4611         >= 3.
4612         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4613         New.
4614         (mi_multi_location_breakpoint_output_fixed): New.
4615         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4616         (mi_cmd_fix_multi_location_breakpoint_output): New.
4617         (mi_multi_location_breakpoint_output_fixed): New.
4618         * mi/mi-cmds.c (mi_cmds): Register command
4619         -fix-multi-location-breakpoint-output.
4620         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4621         interpreter "mi".
4622
4623 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4624
4625         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4626         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4627         instantiate mi_ui_out based on interpreter name.
4628         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4629         * mi/mi-main.c (mi_load_progress): Likewise.
4630
4631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4632
4633         * NEWS: Combine separate "New targets" sections for 8.3.
4634
4635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4636
4637         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4638         (ppcfbsd_init_abi): Install gdbarch
4639         "fetch_tls_load_module_address" and "get_thread_local_address"
4640         methods.
4641
4642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4643
4644         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4645         (riscv_fbsd_init_abi): Install gdbarch
4646         "fetch_tls_load_module_address" and "get_thread_local_address"
4647         methods.
4648
4649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4650
4651         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4652         (i386fbsd_init_abi): Install gdbarch
4653         "fetch_tls_load_module_address" and "get_thread_local_address"
4654         methods.
4655
4656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4657
4658         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4659         (amd64fbsd_init_abi): Install gdbarch
4660         "fetch_tls_load_module_address" and "get_thread_local_address"
4661         methods.
4662
4663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4664
4665         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4666         (struct fbsd_pspace_data): New type.
4667         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4668         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4669         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4670         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4671         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4672
4673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4674
4675         * gdbtypes.c (lookup_struct_elt): New function.
4676         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4677         * gdbtypes.h (struct struct_elt): New type.
4678         (lookup_struct_elt): New prototype.
4679
4680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4681
4682         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4683         remove disabled code block.
4684
4685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4686
4687         * gdbarch.sh (get_thread_local_address): New method.
4688         * gdbarch.h, gdbarch.c: Regenerate.
4689         * target.c (target_translate_tls_address): Use
4690         gdbarch_get_thread_local_address if present instead of
4691         target::get_thread_local_address.
4692
4693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4694
4695         * target.h (target::get_thread_local_address): Update comment.
4696
4697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4698
4699         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4700         objfile->separate_debug_objfile_backlink if not NULL.
4701
4702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4703
4704         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4705         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4706         (amd64bsd_store_inferior_registers): Likewise.
4707         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4708         Enable segment base registers.
4709         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4710         PT_GETFSBASE and PT_GETGSBASE.
4711         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4712         PT_SETGSBASE.
4713         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4714         segment base registers.
4715         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4716
4717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4718
4719         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4720         Update calls to i386_target_description to add 'segments'
4721         parameter.
4722         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4723         add segment base registers.
4724         * arch/i386.c (i386_create_target_description): Add 'segments'
4725         parameter to enable segment base registers.
4726         * arch/i386.h (i386_create_target_description): Likewise.
4727         * features/i386/32bit-segments.xml: New file.
4728         * features/i386/32bit-segments.c: Generate.
4729         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4730         call to i386_target_description to add 'segments' parameter.
4731         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4732         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4733         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4734         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4735         if feature is present.
4736         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4737         Add 'segments' parameter to call to i386_target_description.
4738         (i386_target_description): Add 'segments' parameter to enable
4739         segment base registers.
4740         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4741         to call to i386_target_description.
4742         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4743         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4744         Define I386_NUM_REGS.
4745         (i386_target_description): Add 'segments' parameter to enable
4746         segment base registers.
4747
4748 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4749
4750         PR/24325
4751         * source-cache.c: #undef open and close, to avoid unresolved
4752         externals during linking.
4753
4754 2019-03-12  Tom Tromey  <tromey@adacore.com>
4755
4756         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4757         const.  Add initializers.
4758         (_initialize_remote): Don't initialize ptid globals.
4759
4760 2019-03-12  Pedro Alves  <palves@redhat.com>
4761
4762         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4763
4764 2019-03-12  Pedro Alves  <palves@redhat.com>
4765
4766         * cp-name-parser.y (main): Remove unused 'len' variable.
4767
4768 2019-03-12  Tom Tromey  <tromey@adacore.com>
4769
4770         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4771         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4772
4773 2019-03-12  Tom Tromey  <tromey@adacore.com>
4774
4775         * linux-nat.c (iterate_over_lwps): Update.
4776         (stop_callback): Remove parameter.
4777         (stop_wait_callback, detach_callback, resume_set_callback)
4778         (select_singlestep_lwp_callback, set_ignore_sigint)
4779         (status_callback, resumed_callback, resume_clear_callback)
4780         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4781         data parameter.
4782         (linux_nat_target::detach, linux_nat_target::resume)
4783         (linux_stop_and_wait_all_lwps, select_event_lwp)
4784         (linux_nat_filter_event, linux_nat_wait_1)
4785         (linux_nat_target::kill, linux_nat_target::stop)
4786         (linux_nat_target::stop): Update.
4787         (linux_nat_resume_callback): Change type.
4788         (resume_stopped_resumed_lwps, count_events_callback)
4789         (select_event_lwp_callback): Likewise.
4790         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4791         * arm-linux-nat.c (struct update_registers_data): Remove.
4792         (update_registers_callback): Change type.
4793         (arm_linux_insert_hw_breakpoint1): Update.
4794         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4795         parameter.
4796         (x86_linux_dr_set_addr): Update.
4797         (x86_linux_dr_set_control): Update.
4798         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4799         (iterate_over_lwps): Use gdb::function_view.
4800         * nat/aarch64-linux-hw-point.c (struct
4801         aarch64_dr_update_callback_param): Remove.
4802         (debug_reg_change_callback): Change type.
4803         (aarch64_notify_debug_reg_change): Update.
4804         * s390-linux-nat.c (s390_refresh_per_info): Update.
4805
4806 2019-03-11  Tom Tromey  <tromey@adacore.com>
4807
4808         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4809         redundant assignment to "this_cu".
4810
4811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4812
4813         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4814
4815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4816
4817         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4818         from...
4819         (rank_one_type): ... this.
4820
4821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4822
4823         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4824         from...
4825         (rank_one_type): ... this.
4826
4827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4828
4829         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4830         from...
4831         (rank_one_type): ... this.
4832
4833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4834
4835         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4836         from...
4837         (rank_one_type): ... this.
4838
4839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4840
4841         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4842         from...
4843         (rank_one_type): ... this.
4844
4845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4846
4847         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4848         from...
4849         (rank_one_type): ... this.
4850
4851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4852
4853         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4854         from...
4855         (rank_one_type): ... this.
4856
4857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4858
4859         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4860         from...
4861         (rank_one_type): ... this.
4862
4863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4864
4865         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4866         from...
4867         (rank_one_type): ... this.
4868
4869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4870
4871         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4872         from...
4873         (rank_one_type): ... this.
4874
4875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4876
4877         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4878         from...
4879         (rank_one_type): ... this.
4880
4881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4882
4883         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4884         from...
4885         (rank_one_type): ... this.
4886
4887 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4888
4889         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4890         inferior-events' shows the example events.
4891
4892 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4893
4894         Support styling on native MS-Windows console
4895
4896         PR/24315
4897         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4898         on MS-Windows if $TERM is not defined.
4899
4900         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4901
4902         * posix-hdep.c (gdb_console_fputs):
4903         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4904         functions.
4905         * ui-file.h (gdb_console_fputs): Add prototype.
4906
4907         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4908         back to fputs only if the former returns zero.
4909
4910 2019-03-07  Tom Tromey  <tom@tromey.com>
4911
4912         * symmisc.c (print_symbol_bcache_statistics): Update.
4913         (print_objfile_statistics): Update.
4914         * symfile.c (allocate_symtab): Update.
4915         * stabsread.c: Don't include bcache.h.
4916         * psymtab.h (struct psymbol_bcache): Don't declare.
4917         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4918         (psymbol_bcache_init, psymbol_bcache_free)
4919         (psymbol_bcache_get_bcache): Don't declare.
4920         * psymtab.c (struct psymbol_bcache): Remove.
4921         (psymtab_storage::psymtab_storage): Update.
4922         (psymtab_storage::~psymtab_storage): Update.
4923         (psymbol_bcache_init, psymbol_bcache_free)
4924         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4925         (add_psymbol_to_bcache): Update.
4926         (allocate_psymtab): Update.
4927         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4928         macro_cache>: No longer pointers.
4929         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4930         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4931         * macrotab.c (macro_bcache): Update.
4932         * macroexp.c: Don't include bcache.h.
4933         * gdbtypes.c (check_types_worklist): Update.
4934         (types_deeply_equal): Remove TRY/CATCH.  Update.
4935         * elfread.c (elf_symtab_read): Update.
4936         * dwarf2read.c: Don't include bcache.h.
4937         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4938         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4939         (print_bcache_statistics, bcache_memory_used): Don't declare.
4940         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4941         methods.  Rename all data members.
4942         * bcache.c (struct bcache): Move to bcache.h.
4943         (bcache::expand_hash_table): Rename from expand_hash_table.
4944         (bcache): Remove.
4945         (bcache::insert): Rename from bcache_full.
4946         (bcache::compare): Rename from bcache_compare.
4947         (bcache_xmalloc): Remove.
4948         (bcache::~bcache): Rename from bcache_xfree.
4949         (bcache::print_statistics): Rename from print_bcache_statistics.
4950         (bcache::memory_used): Rename from bcache_memory_used.
4951
4952 2019-03-07  Pedro Alves  <palves@redhat.com>
4953
4954         * infrun.c (normal_stop): Also check for
4955         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4956
4957 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * f-lang.c (value_from_host_double): Moved to...
4960         * value.c (value_from_host_double): ...here.
4961         * value.h (value_from_host_double): Declare.
4962         * guile/scm-math.c (vlscm_convert_typed_number): Use
4963         value_from_host_double.
4964         (vlscm_convert_number): Likewise.
4965         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4966         * python/py-value.c (convert_value_from_python): Likewise.
4967
4968 2019-03-06  Tom Tromey  <tom@tromey.com>
4969
4970         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4971
4972 2019-03-06  Tom Tromey  <tom@tromey.com>
4973
4974         * utils.h (free_current_contents): Don't declare.
4975         * utils.c (free_current_contents): Remove.
4976
4977 2019-03-06  Tom Tromey  <tom@tromey.com>
4978
4979         * top.c (quit_force): Update.
4980         * main.c (captured_command_loop): Update.
4981         * common/new-op.c (operator new): Update.
4982         * common/common-exceptions.c (struct catcher)
4983         <save_cleanup_chain>: Remove member.
4984         (exceptions_state_mc_init): Update.
4985         (exception_try_scope_entry): Return nullptr.
4986         (exception_try_scope_exit, exception_rethrow)
4987         (throw_exception_sjlj, throw_exception_cxx): Update.
4988         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4989         (all_cleanups, do_cleanups, discard_cleanups)
4990         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4991         (restore_cleanups, restore_final_cleanups): Don't declare.
4992         (do_final_cleanups): Remove parameter.
4993         * common/cleanups.c (cleanup_chain, make_cleanup)
4994         (make_cleanup_dtor, all_cleanups, do_cleanups)
4995         (discard_my_cleanups, discard_cleanups)
4996         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4997         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4998         (null_cleanup): Remove.
4999         (do_final_cleanups): Remove parameter.
5000
5001 2019-03-06  Tom Tromey  <tom@tromey.com>
5002
5003         * remote.c (remote_target::remote_parse_stop_reply): Use
5004         unique_xmalloc_ptr.
5005
5006 2019-03-06  Tom Tromey  <tom@tromey.com>
5007
5008         * stabsread.c (struct stabs_field_info): Rename from field_info.
5009         <list, fnlist>: Add initializers.
5010         <obstack>: New member.
5011         (read_member_functions, read_struct_fields, read_baseclasses):
5012         Allocate on obstack.  Don't use cleanups.
5013         (read_one_struct_field, read_member_functions, read_struct_fields)
5014         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5015         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5016         (read_struct_type): Update.
5017
5018 2019-03-06  Tom Tromey  <tom@tromey.com>
5019
5020         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5021         * common/filestuff.h (make_cleanup_close): Don't declare.
5022         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5023         Remove.
5024
5025 2019-03-06  Tom Tromey  <tom@tromey.com>
5026
5027         * solib-aix.c: Use make_scope_exit.
5028
5029 2019-03-06  Tom Tromey  <tom@tromey.com>
5030
5031         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5032         Use make_scope_exit.
5033
5034 2019-03-06  Tom Tromey  <tom@tromey.com>
5035
5036         * solib-svr4.c (disable_probes_interface): Remove parameter.
5037         (svr4_handle_solib_event): Use make_scope_exit.
5038
5039 2019-03-06  Tom Tromey  <tom@tromey.com>
5040
5041         * remote.c (struct stop_reply_deleter): Remove.
5042         (stop_reply_up): Update.
5043         (struct stop_reply): Derive from notif_event.  Don't typedef.
5044         <regcache>: Now a std::vector.
5045         (stop_reply_xfree): Remove.
5046         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5047         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5048         (remote_target::discard_pending_stop_replies): Use delete.
5049         (remote_target::remote_parse_stop_reply): Update.
5050         (remote_target::process_stop_reply): Update.
5051         * remote-notif.h (struct notif_event): Add virtual destructor.
5052         Remove "dtr" member.
5053         (struct notif_client) <alloc_event>: Return a unique_ptr.
5054         (notif_event_xfree): Don't declare.
5055         (notif_event_up): New typedef.
5056         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5057         (notif_event_xfree, do_notif_event_xfree): Remove.
5058         (remote_notif_state_xfree): Update.
5059
5060 2019-03-06  Tom Tromey  <tom@tromey.com>
5061
5062         * infrun.c (displaced_step_clear_cleanup): Now a
5063         forward_scope_exit type.
5064         (displaced_step_prepare_throw): Update.
5065         (displaced_step_fixup): Update.
5066
5067 2019-03-06  Tom Tromey  <tom@tromey.com>
5068
5069         * inferior.h (class inferior): Update comment.
5070         * gdbthread.h (class thread_info): Update comment.
5071
5072 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5073             Tom Tromey  <tom@tromey.com>
5074
5075         * stabsread.h (struct stab_section_list): Remove.
5076         (coffstab_build_psymtabs): Update.
5077         * dbxread.c (symbuf_sections): Now a std::vector.
5078         (sect_idx): New global.
5079         (fill_symbuf): Update.
5080         (coffstab_build_psymtabs): Change type of stabsects parameter.
5081         Update.
5082         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5083         std::vector.
5084         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5085         (coff_locate_sections): Update.
5086         (coff_symfile_read): Remove cleanups.  Update.
5087         (init_stringtab): Add storage parameter.
5088         (free_stringtab, free_stringtab_cleanup): Remove.
5089         (init_lineno): Add storage parameter.
5090         (free_linetab, free_linetab_cleanup): Remove.
5091
5092 2019-03-06  Pedro Alves  <palves@redhat.com>
5093
5094         * linux-fork.c (fork_info::clobber_regs): Delete.
5095         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5096         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5097         comment.  Adjust.
5098         (scoped_switch_fork_info::scoped_switch_fork_info)
5099         (checkpoint_command, linux_fork_context): Adjust
5100         fork_save_infrun_state calls.
5101
5102 2019-03-06  Pedro Alves  <palves@redhat.com>
5103
5104         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5105         (inf_has_multiple_threads): Return 'bool' and rewrite using
5106         inferior_info::threads().
5107
5108 2019-03-06  Pedro Alves  <palves@redhat.com>
5109
5110         * linux-fork.c: Include <list>.
5111         (fork_list): Now a std::list instance.
5112         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5113         (forks_exist_p, find_last_fork): Adjust.
5114         (new_fork): Delete.
5115         (one_fork_p): New.
5116         (add_fork): Adjust.
5117         (free_fork): Delete, folded into fork_info::~fork_info().
5118         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5119         Adjust.
5120         (init_fork_list): Delete.
5121         (linux_fork_killall, linux_fork_mourn_inferior)
5122         (linux_fork_detach, info_checkpoints_command): Adjust.
5123         (_initialize_linux_fork): No longer call init_fork_list.
5124
5125 2019-03-06  Pedro Alves  <palves@redhat.com>
5126
5127         * linux-fork.c (new_fork): New, split out of ...
5128         (add_fork): ... this.  Return void.  Move "first fork" special
5129         case from here, to ...
5130         (checkpoint_command): ... here.
5131         * linux-linux.h (add_fork): Return void.
5132
5133 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5136
5137 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5138             Chris January  <chris.january@arm.com>
5139             David Lecomber  <david.lecomber@arm.com>
5140
5141         * f-exp.y: New token, UNOP_INTRINSIC.
5142         (exp): New pattern using UNOP_INTRINSIC token.
5143         (f77_keywords): Add 'abs' keyword.
5144         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5145         (value_from_host_double): New function.
5146         (evaluate_subexp_f): Support UNOP_ABS.
5147
5148 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5151         types.
5152
5153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5154
5155         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5156         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5157         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5158
5159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5162
5163 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5164             Chris January  <chris.january@arm.com>
5165
5166         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5167         * f-exp.y: Define 'KIND' token.
5168         (exp): New pattern for KIND expressions.
5169         (ptype): Handle types with a kind extension.
5170         (direct_abs_decl): Extend to spot kind extensions.
5171         (f77_keywords): Add 'kind' to the list.
5172         (push_kind_type): New function.
5173         (convert_to_kind_type): New function.
5174         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5175         * parse.c (operator_length_standard): Likewise.
5176         * parser-defs.h (enum type_pieces): Add tp_kind.
5177         * std-operator.def: Add UNOP_KIND.
5178
5179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * f-exp.y (f_parse): Set yydebug.
5182
5183 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * f-lang.c (evaluate_subexp_f): New function.
5186         (exp_descriptor_f): New global.
5187         (f_language_defn): Use exp_descriptor_f instead of
5188         exp_descriptor_standard.
5189
5190 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5191
5192         * f-exp.y (struct token): Add comments.
5193         (dot_ops): Remove uppercase versions and the end marker.
5194         (f77_keywords): Likewise.
5195         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5196         entries in the dot_ops array are case insensitive, and use
5197         strncasecmp to compare strings.  Also some whitespace cleanup in
5198         this area.  Similar for the f77_keywords array, except entries in
5199         this list might be case sensitive.
5200
5201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * f-exp.y (struct f77_boolean_val): Add comments.
5204         (boolean_values): Remove uppercase versions, and end marker.
5205         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5206         and use strncasecmp to achieve case insensitivity.  Additionally,
5207         perform whitespace cleanup around this code.
5208
5209 2019-03-06  Tom Tromey  <tromey@adacore.com>
5210
5211         * remote-sim.c (gdbsim_target_open): Use result of
5212         gdb_argv::release.
5213
5214 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5215         Dirk Schubert  <dirk.schubert@arm.com>
5216         Chris January  <chris.january@arm.com>
5217
5218         * eval.c (evaluate_subexp_standard): Call Fortran argument
5219         wrapping logic.
5220         * f-lang.c (struct value): A value which can be passed into a
5221         Fortran function call.
5222         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5223         where appropriate.
5224         (struct type): Value ready for a Fortran function call.
5225         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5226         is needed.
5227         * f-lang.h (fortran_argument_convert): Declaration.
5228         (fortran_preserve_arg_pointer): Declaration.
5229         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5230
5231 2019-03-05  Tom Tromey  <tromey@adacore.com>
5232
5233         * python/py-prettyprint.c (print_string_repr): Remove #if.
5234         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5235
5236 2019-03-05  Tom Tromey  <tromey@adacore.com>
5237
5238         * target.c (the_dummy_target): Move later.  Change type to
5239         "dummy_target".
5240         (initialize_targets): Don't initialize the_dummy_target.
5241
5242 2019-03-05  Tom Tromey  <tromey@adacore.com>
5243
5244         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5245         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5246
5247 2019-03-05  Tom Tromey  <tromey@adacore.com>
5248
5249         * windows-nat.c (windows_nat_target::attach)
5250         (windows_nat_target::detach): Don't call gdb_flush.
5251         * valprint.c (generic_val_print, val_print, val_print_string):
5252         Don't call gdb_flush.
5253         * utils.c (defaulted_query): Don't call gdb_flush.
5254         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5255         * target.c (target_announce_detach): Don't call gdb_flush.
5256         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5257         * remote.c (extended_remote_target::attach): Don't call
5258         gdb_flush.
5259         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5260         * printcmd.c (do_examine): Don't call gdb_flush.
5261         (info_display_command): Don't call gdb_flush.
5262         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5263         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5264         * memattr.c (info_mem_command): Don't call gdb_flush.
5265         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5266         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5267         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5268         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5269         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5270         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5271         (gnu_nat_target::detach): Don't call gdb_flush.
5272         * f-valprint.c (f_val_print): Don't call gdb_flush.
5273         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5274         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5275         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5276         gdb_flush.
5277         * c-valprint.c (c_val_print): Don't call gdb_flush.
5278         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5279
5280 2019-03-05  Tom Tromey  <tromey@adacore.com>
5281
5282         * varobj.c (update_dynamic_varobj_children): Update.
5283         (install_default_visualizer): Use reset, not release.
5284         * value.c (set_internalvar): Update.
5285         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5286         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5287         ATTRIBUTE_UNUSED_RESULT.
5288
5289 2019-03-05  Tom Tromey  <tromey@adacore.com>
5290
5291         * remote.c (class scoped_remote_fd) <release>: Add
5292         ATTRIBUTE_UNUSED_RESULT.
5293
5294 2019-03-05  Tom Tromey  <tromey@adacore.com>
5295
5296         * macroexp.c (struct macro_buffer) <release>: Add
5297         ATTRIBUTE_UNUSED_RESULT.
5298
5299 2019-03-05  Tom Tromey  <tromey@adacore.com>
5300
5301         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5302         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5303         ATTRIBUTE_UNUSED_RESULT.
5304
5305 2019-03-05  Tom Tromey  <tromey@adacore.com>
5306
5307         * common/scoped_fd.h (class scoped_fd) <release>: Add
5308         ATTRIBUTE_UNUSED_RESULT.
5309
5310 2019-03-05  Tom Tromey  <tromey@adacore.com>
5311
5312         * parser-defs.h (struct parser_state) <release>: Add
5313         ATTRIBUTE_UNUSED_RESULT.
5314
5315 2019-03-05  Tom Tromey  <tromey@adacore.com>
5316
5317         * utils.h (class gdb_argv) <release>: Add
5318         ATTRIBUTE_UNUSED_RESULT.
5319         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5320
5321 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5322
5323         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5324         for-loop range, to avoid compiler warnings.
5325
5326         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5327         avoid compiler warnings about unused variables.
5328
5329         * NEWS: Mention end of support for native debugging on MS-Windows
5330         before XP.
5331
5332         PR gdb/24292
5333         * common/netstuff.c:
5334         * gdbserver/gdbreplay.c
5335         * gdbserver/remote-utils.c:
5336         * ser-tcp.c:
5337         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5338         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5339         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5340         'getaddrinfo' and 'freeaddrinfo' were not available before
5341         Windows XP, and mingw.org's MinGW headers by default define
5342         _WIN32_WINNT to 0x500.
5343
5344 2019-03-01  Gary Benson <gbenson@redhat.com>
5345
5346         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5347
5348 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5349             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5350
5351         PR gdb/8527
5352         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5353         set_sigint_trap, clear_sigint_trap.
5354
5355 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5356
5357         * target.c (target_detach): Clear the regcache and the
5358         frame cache.
5359
5360 2019-02-27  Pedro Alves  <palves@redhat.com>
5361
5362         * utils.c (set_screen_size): When we cap the height/width sizes,
5363         tweak the corresponding command variable to show "unlimited":
5364
5365 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5366             Pedro Alves  <palves@redhat.com>
5367
5368         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5369         before calling rl_set_screen_size.
5370
5371 2019-02-27  Tom Tromey  <tromey@adacore.com>
5372
5373         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5374         define.
5375         * python/py-value.c: Remove Python 2.4 workaround.
5376         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5377         workaround.
5378         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5379         Python 2.4 workaround.
5380         * python/python-internal.h: Remove Python 2.4 comment.
5381         (Py_ssize_t): Don't define.
5382         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5383         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5384         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5385         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5386         * python/python.c (do_start_initialization): Remove Python 2.4
5387         workaround.
5388         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5389         (print_children): Remove Python 2.4 workaround.
5390         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5391         workaround.
5392         (CHARBUFFERPROC_NAME): Remove.
5393         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5394         Python 2.4 workaround.
5395
5396 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5397
5398         * NEWS: Note minimum Python version.
5399
5400 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5401
5402         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5403         code from these functions.  Remove corresponding ifdefs.  Use
5404         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5405         Remove gotos and target of gotos.
5406         (infpy_search_memory): Likewise.
5407
5408 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5411         (hppa_gdbarch_init): Don't register deleted functions with
5412         gdbarch.
5413
5414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5417         (h8300_unwind_sp): Delete.
5418         (h8300_dummy_id): Delete.
5419         (h8300_gdbarch_init): Don't register deleted functions with
5420         gdbarch.
5421
5422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5423
5424         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5425         (ft32_unwind_pc): Delete.
5426         (ft32_unwind_sp): Delete.
5427         (ft32_gdbarch_init): Don't register deleted functions with
5428         gdbarch.
5429
5430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5433         (frv_unwind_pc): Delete.
5434         (frv_unwind_sp): Delete.
5435         (frv_gdbarch_init): Don't register deleted functions with
5436         gdbarch.
5437
5438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5439
5440         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5441         (riscv_unwind_pc): Delete.
5442         (riscv_unwind_sp): Delete.
5443         (riscv_gdbarch_init): Don't register deleted functions with
5444         gdbarch.
5445
5446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5447
5448         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5449         (csky_unwind_pc): Delete.
5450         (csky_unwind_sp): Delete.
5451         (csky_gdbarch_init): Don't register deleted functions with
5452         gdbarch.
5453
5454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5455
5456         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5457         (cris_unwind_pc): Delete.
5458         (cris_unwind_sp): Delete.
5459         (cris_gdbarch_init): Don't register deleted functions with
5460         gdbarch.
5461
5462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5465         (bfin_unwind_pc): Delete.
5466         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5467
5468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5471         (arm_unwind_pc): Delete.
5472         (arm_unwind_sp): Delete.
5473         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5474
5475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5476
5477         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5478         (arc_unwind_pc): Delete.
5479         (arc_unwind_sp): Delete.
5480         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5481
5482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5485         (alpha_unwind_pc): Delete.
5486         (alpha_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5492         (aarch64_unwind_pc): Delete.
5493         (aarch64_unwind_sp): Delete.
5494         (aarch64_gdbarch_init): Don't register deleted functions with
5495         gdbarch.
5496
5497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * gdbtypes.c (type_align): Don't consider static members when
5500         computing structure alignment.
5501
5502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5503
5504         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5505         return 0 for other types.
5506         * arch-utils.c (default_type_align): Always return 0.
5507         * gdbarch.h: Regenerate.
5508         * gdbarch.sh (type_align): Extend comment.
5509         * gdbtypes.c (type_align): Add additional comments, always call
5510         gdbarch_type_align before applying the default rules.
5511         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5512         generic code will then apply a suitable default.
5513         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5514         types, return 0 for other types.
5515
5516 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5517
5518         * NEWS: Create a new section for the next release branch.
5519         Rename the section of the current branch, now that it has
5520         been cut.
5521
5522 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5523
5524         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5525         * version.in: Bump version to 8.3.50.DATE-git.
5526
5527 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5528
5529         * aix-thread.c (ptid_cmp): Remove unused variable.
5530         (get_signaled_thread): Likewise.
5531         (store_regs_user_thread): Likewise.
5532         (store_regs_kernel_thread): Likewise.
5533         (fetch_regs_kernel_thread): Remove shadowed variable.
5534
5535 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * features/riscv/32bit-cpu.xml: Add register numbers.
5538         * features/riscv/32bit-fpu.c: Regenerate.
5539         * features/riscv/32bit-fpu.xml: Add register numbers.
5540         * features/riscv/64bit-cpu.xml: Add register numbers.
5541         * features/riscv/64bit-fpu.c: Regenerate.
5542         * features/riscv/64bit-fpu.xml: Add register numbers.
5543
5544 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5545
5546         * NEWS: Mention two argument form of gdb.Value constructor.
5547         * python/py-value.c (convert_buffer_and_type_to_value): New
5548         function.
5549         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5550         Add support for handling an optional second argument.  Call
5551         convert_buffer_and_type_to_value as appropriate.
5552         * python/python-internal.h (Py_buffer_deleter): New struct.
5553         (Py_buffer_up): New typedef.
5554
5555 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5556
5557         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5558         instead of releasing ownership.
5559
5560 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5561
5562         * dwarf2read.c (open_and_init_dwp_file): Call
5563         elf_numsections instead of bfd_count_sections to initialize
5564         dwp_file->num_sections.
5565
5566 2019-02-25  Tom Tromey  <tromey@adacore.com>
5567
5568         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5569
5570 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5571
5572         * gcore.in: Add '--readnever' option when invoking GDB.
5573
5574 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5575
5576         * MAINTAINERS: Update my email address.
5577
5578 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5579
5580         * build-id.c (build_id_to_debug_bfd_1): New function.
5581         (build_id_to_debug_bfd): Look for separate debug file in
5582         sysroot.
5583
5584 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5585
5586         * gdbarch.sh: Update the copyright year range that is placed into
5587         generated files.
5588
5589 2019-02-22  Keith Seitz  <keiths@redhat.com>
5590
5591         PR symtab/23853
5592         * linespec.c (create_sals_line_offset): Search for the default
5593         symtab's filename instead of its fullname.
5594
5595 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5596
5597         * NEWS: Update style defaults.
5598
5599 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5600
5601         * main.c (captured_main_1): Disable styling in batch mode.
5602
5603 2019-02-20  Tom Tromey  <tom@tromey.com>
5604
5605         * symtab.c (symtab_symbol_info): Fix typos.
5606
5607 2019-02-20  Tom Tromey  <tromey@adacore.com>
5608
5609         * findcmd.c (_initialize_mem_search): Use upper case for
5610         metasyntactic variables.
5611
5612 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5613
5614         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5615         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5616
5617 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5618
5619         * top.h (source_file_name): Change to std::string.
5620         * top.c (source_file_name): Likewise.
5621         (command_line_input): Adjust.
5622         * cli/cli-script.c (script_from_file): Adjust.
5623
5624 2019-02-19  Tom Tromey  <tromey@adacore.com>
5625
5626         * ravenscar-thread.c
5627         (ravenscar_thread_target::update_thread_list): Don't call
5628         ada_build_task_list.
5629         * ada-lang.h (ada_build_task_list): Don't declare.
5630         * ada-tasks.c (struct ada_tasks_inferior_data)
5631         <task_list_valid_p>: Now bool.
5632         (read_known_tasks, ada_task_list_changed)
5633         (ada_tasks_invalidate_inferior_data): Update.
5634         (read_known_tasks_array): Return bool.
5635         (read_known_tasks_list): Likewise.
5636         (read_known_tasks): Return void.
5637         (ada_build_task_list): Now static.
5638
5639 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5640
5641         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5642         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5643
5644 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5645
5646         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5647         variant for ada_tasks_pspace_data_handle and
5648         ada_tasks_inferior_data_handle.
5649         (ada_tasks_pspace_data_cleanup): New function.
5650         (ada_tasks_inferior_data_cleanup): New function.
5651
5652 2019-02-17  Tom Tromey  <tom@tromey.com>
5653
5654         * macrotab.h (macro_source_fullname): Return a std::string.
5655         * macrotab.c (macro_include, check_for_redefinition)
5656         (macro_undef, macro_lookup_definition, foreach_macro)
5657         (foreach_macro_in_scope): Update.
5658         (macro_source_fullname): Return a std::string.
5659         * macrocmd.c (show_pp_source_pos): Update.
5660
5661 2019-02-17  Tom Tromey  <tom@tromey.com>
5662
5663         * macrocmd.c (show_pp_source_pos): Style the file names.
5664
5665 2019-02-17  Tom Tromey  <tom@tromey.com>
5666
5667         PR tui/24197:
5668         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5669
5670 2019-02-17  Tom Tromey  <tom@tromey.com>
5671
5672         * ada-lang.c (user_select_syms): Use filtered printing.
5673         * utils.c (wrap_style): New global.
5674         (desired_style): Remove.
5675         (emit_style_escape): Add stream parameter.
5676         (set_output_style, reset_terminal_style, prompt_for_continue):
5677         Update.
5678         (flush_wrap_buffer): Only flush gdb_stdout.
5679         (wrap_here): Set wrap_style.
5680         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5681         treat escape sequences as a character.  Change when wrap buffer is
5682         flushed.
5683         (fputs_styled): Do not set the output style when the default is
5684         requested.
5685         * ui-style.h (struct ui_file_style) <is_default>: New method.
5686         * source.c (print_source_lines_base): Emit escape sequences in one
5687         piece.
5688
5689 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5690
5691         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5692         integers and enumeration types.
5693
5694 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5695
5696         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5697         instead of lookup_symbol_in_language
5698         (do_exact_match): New function.
5699         (ada_get_symbol_name_matcher): Return do_exact_match when
5700         doing a verbatim match.
5701
5702 2019-02-15  Tom Tromey  <tromey@adacore.com>
5703
5704         * ravenscar-thread.c (ravenscar_thread_target::resume)
5705         (ravenscar_thread_target::wait): Special case wildcard requests.
5706
5707 2019-02-15  Tom Tromey  <tromey@adacore.com>
5708
5709         * ravenscar-thread.c (base_ptid): Remove.
5710         (struct ravenscar_thread_target) <close>: New method.
5711         <m_base_ptid>: New member.
5712         <update_inferior_ptid, active_task, task_is_currently_active,
5713         runtime_initialized>: Declare methods.
5714         <ravenscar_thread_target>: Add constructor.
5715         (ravenscar_thread_target::task_is_currently_active)
5716         (ravenscar_thread_target::update_inferior_ptid)
5717         (ravenscar_runtime_initialized): Rename.  Now methods.
5718         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5719         (ravenscar_thread_target::update_thread_list): Update.
5720         (ravenscar_thread_target::active_task): Now method.
5721         (ravenscar_thread_target::store_registers)
5722         (ravenscar_thread_target::prepare_to_store)
5723         (ravenscar_thread_target::prepare_to_store)
5724         (ravenscar_thread_target::mourn_inferior): Update.
5725         (ravenscar_inferior_created): Use "new" to create target.
5726         (ravenscar_thread_target::get_ada_task_ptid): Update.
5727         (_initialize_ravenscar): Don't initialize base_ptid.
5728         (ravenscar_ops): Remove global.
5729
5730 2019-02-15  Tom Tromey  <tromey@adacore.com>
5731
5732         * target.h (push_target): Declare new overload.
5733         * target.c (push_target): New overload, taking an rvalue reference.
5734         * remote.c (remote_target::open_1): Use push_target overload.
5735         * corelow.c (core_target_open): Use push_target overload.
5736
5737 2019-02-15  Tom Tromey  <tromey@adacore.com>
5738
5739         * ravenscar-thread.c (is_ravenscar_task)
5740         (ravenscar_task_is_currently_active): Return bool.
5741         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5742         (_initialize_ravenscar): Remove "(void)".
5743         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5744         Return bool.
5745
5746 2019-02-15  Tom Tromey  <tromey@adacore.com>
5747
5748         * ravenscar-thread.c (ravenscar_runtime_initializer)
5749         (has_ravenscar_runtime, get_running_thread_id)
5750         (ravenscar_thread_target::resume): Fix indentation.
5751
5752 2019-02-15  Tom Tromey  <tromey@adacore.com>
5753
5754         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5755         from ravenscar_arch_ops.
5756         (sparc_ravenscar_ops::fetch_registers)
5757         (sparc_ravenscar_ops::store_registers): Now methods.
5758         (sparc_ravenscar_prepare_to_store): Remove.
5759         (sparc_ravenscar_ops): Redefine.
5760         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5761         methods and destructor.  Remove members.
5762         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5763         (ravenscar_thread_target::store_registers)
5764         (ravenscar_thread_target::prepare_to_store): Update.
5765         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5766         Remove.
5767         (struct ppc_ravenscar_powerpc_ops): Derive from
5768         ravenscar_arch_ops.
5769         (ppc_ravenscar_powerpc_ops::fetch_registers)
5770         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5771         (ppc_ravenscar_powerpc_ops): Redefine.
5772         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5773         (ppc_ravenscar_e500_ops::fetch_registers)
5774         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5775         (ppc_ravenscar_e500_ops): Redefine.
5776         * aarch64-ravenscar-thread.c
5777         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5778         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5779         (aarch64_ravenscar_fetch_registers)
5780         (aarch64_ravenscar_store_registers): Now methods.
5781         (aarch64_ravenscar_ops): Redefine.
5782
5783 2019-02-15  Tom Tromey  <tromey@adacore.com>
5784
5785         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5786         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5787         (ravenscar_thread_target::stopped_by_watchpoint)
5788         (ravenscar_thread_target::stopped_data_address)
5789         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5790
5791 2019-02-15  Tom Tromey  <tromey@adacore.com>
5792
5793         * ravenscar-thread.c: Fix some typos.
5794
5795 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5796             Tom Tromey  <tromey@adacore.com>
5797
5798         * ada-lang.c (ada_exception_sal): Change addr_string to a
5799         std::string.
5800         (create_ada_exception_catchpoint): Update.
5801
5802 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5803             Tom Tromey  <tromey@adacore.com>
5804
5805         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5806         (bp_location_ops): Remove.
5807         (base_breakpoint_allocate_location): Update.
5808         (free_bp_location): Update.
5809         * ada-lang.c (class ada_catchpoint_location)
5810         <ada_catchpoint_location>: Remove ops parameter.
5811         (ada_catchpoint_location_dtor): Remove.
5812         (ada_catchpoint_location_ops): Remove.
5813         (allocate_location_exception): Update.
5814         * breakpoint.h (struct bp_location_ops): Remove.
5815         (class bp_location) <bp_location>: Remove bp_location_ops
5816         parameter.
5817         <~bp_location>: Add destructor.
5818         <ops>: Remove.
5819
5820 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5821             Pedro Alves  <palves@redhat.com>
5822
5823         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5824         'PATH_MAX'.
5825
5826 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5827             Samuel Thibault  <samuel.thibault@gnu.org>
5828             Thomas Schwinge  <thomas@codesourcery.com>
5829
5830         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5831         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5832
5833 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5834
5835         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5836         (check_empty): Use "const char *".
5837
5838         * gnu-nat.c (gnu_nat_target::detach): Instead of
5839         'detach_inferior (pid)' call
5840         'detach_inferior (find_inferior_pid (pid))'.
5841
5842         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5843         'nat/fork-inferior.o'.
5844         * gnu-nat.c: #include "nat/fork-inferior.h".
5845
5846         * gnu-nat.c (gnu_nat_target::detach): Instead of
5847         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5848         * gnu-nat.h: #include "inf-child.h".
5849         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5850         'i386_gnu_nat_target::fetch_registers'.
5851         (gnu_store_registers): Rename/move to
5852         'i386_gnu_nat_target::store_registers'.
5853
5854         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5855         * gnu-nat.h (mach_thread_info): New function.
5856         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5857
5858         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5859
5860 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5861
5862         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5863
5864 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5865
5866         * windows-nat.c (windows_add_thread): Add new parameter
5867         "main_thread_p" with default value set to false.  Update
5868         function documentation as well as all callers.
5869         (windows_delete_thread): Likewise.
5870         (fake_create_process): Update call to windows_add_thread.
5871         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5872         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5873         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5874         call to windows_delete_thread.
5875
5876 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5877
5878         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5879
5880 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5881
5882         * symfile.c (find_separate_debug_file): Use canonical path of
5883         sysroot with child_path instead of gdb_sysroot if it is valid.
5884
5885 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5886
5887         * symfile.c (find_separate_debug_file): Use child_path to
5888         determine if an object file is under a sysroot.
5889
5890 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5891
5892         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5893         unittests/child-path-selftests.c.
5894         * common/pathstuff.c (child_path): New function.
5895         * common/pathstuff.h (child_path): New prototype.
5896         * unittests/child-path-selftests.c: New file.
5897
5898 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5899
5900         * symfile.c (find_separate_debug_file): Look for separate debug
5901         files in debug directories under the sysroot.
5902
5903 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5904
5905         * symtab.h (struct minimal_symbol data_p): New const method.
5906         (struct minimal_symbol text_p): Likewise.
5907         * symtab.c (output_source_filename): Use file name style
5908         to print file name.
5909         (print_symbol_info): Likewise.
5910         (print_msymbol_info): Use address style to print addresses.
5911         Use function name style to print executable text symbols.
5912         (expand_symtab_containing_pc): Use data_p.
5913         (find_pc_sect_compunit_symtab): Likewise.
5914
5915 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5916
5917         * breakpoint.c (describe_other_breakpoints): Use address style
5918         to print addresses.
5919         (say_where): Likewise.
5920
5921 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5922
5923         * ada-typeprint.c (print_func_type): Print function name
5924         style to print function name.
5925         * c-typeprint.c (c_print_type_1): Likewise.
5926
5927 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5928
5929         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5930         for execve.
5931
5932 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5933
5934         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5935         type_stack.
5936
5937 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5938
5939         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5940         TYPE_CODE_REF types.
5941
5942 2019-02-08  Jim Wilson  <jimw@sifive.com>
5943
5944         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5945         (riscv_linux_fregset): New.
5946         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5947
5948 2019-02-07  Tom Tromey  <tom@tromey.com>
5949
5950         * thread.c (thread_cancel_execution_command): Update.
5951         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5952         methods.
5953         (struct thread_fsm_ops): Remove.
5954         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5955         (thread_fsm_should_stop, thread_fsm_return_value)
5956         (thread_fsm_set_finished, thread_fsm_finished_p)
5957         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5958         Don't declare.
5959         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5960         * infrun.c (clear_proceed_status_thread)
5961         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5962         (print_stop_event): Update.
5963         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5964         Add constructor.
5965         (step_command_fsm_ops): Remove.
5966         (new_step_command_fsm): Remove.
5967         (step_1): Update.
5968         (step_command_fsm::should_stop): Rename from
5969         step_command_fsm_should_stop.
5970         (step_command_fsm::clean_up): Rename from
5971         step_command_fsm_clean_up.
5972         (step_command_fsm::do_async_reply_reason): Rename from
5973         step_command_fsm_async_reply_reason.
5974         (struct until_next_fsm): Inherit from thread_fsm.  Add
5975         constructor.
5976         (until_next_fsm_ops): Remove.
5977         (new_until_next_fsm): Remove.
5978         (until_next_fsm::should_stop): Rename from
5979         until_next_fsm_should_stop.
5980         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5981         (until_next_fsm::do_async_reply_reason): Rename from
5982         until_next_fsm_async_reply_reason.
5983         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5984         constructor.  Change type of breakpoint.
5985         (finish_command_fsm_ops): Remove.
5986         (new_finish_command_fsm): Remove.
5987         (finish_command_fsm::should_stop): Rename from
5988         finish_command_fsm_should_stop.
5989         (finish_command_fsm::clean_up): Rename from
5990         finish_command_fsm_clean_up.
5991         (finish_command_fsm::return_value): Rename from
5992         finish_command_fsm_return_value.
5993         (finish_command_fsm::do_async_reply_reason): Rename from
5994         finish_command_fsm_async_reply_reason.
5995         (finish_command): Update.
5996         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5997         Add constructor.
5998         (call_thread_fsm_ops): Remove.
5999         (call_thread_fsm::call_thread_fsm): Rename from
6000         new_call_thread_fsm.
6001         (call_thread_fsm::should_stop): Rename from
6002         call_thread_fsm_should_stop.
6003         (call_thread_fsm::should_notify_stop): Rename from
6004         call_thread_fsm_should_notify_stop.
6005         (run_inferior_call, call_function_by_hand_dummy): Update.
6006         * cli/cli-interp.c (should_print_stop_to_console): Update.
6007         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6008         Add constructor.  Change type of location_breakpoint,
6009         caller_breakpoint.
6010         (until_break_fsm_ops): Remove.
6011         (new_until_break_fsm): Remove.
6012         (until_break_fsm::should_stop): Rename from
6013         until_break_fsm_should_stop.
6014         (until_break_fsm::clean_up): Rename from
6015         until_break_fsm_clean_up.
6016         (until_break_fsm::do_async_reply_reason): Rename from
6017         until_break_fsm_async_reply_reason.
6018         (until_break_command): Update.
6019         * thread-fsm.c: Remove.
6020         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6021
6022 2019-02-07  Tom Tromey  <tom@tromey.com>
6023
6024         * yy-remap.h: Add include guard.
6025         * xtensa-tdep.h: Add include guard.
6026         * xcoffread.h: Rename include guard.
6027         * varobj-iter.h: Add include guard.
6028         * tui/tui.h: Rename include guard.
6029         * tui/tui-winsource.h: Rename include guard.
6030         * tui/tui-wingeneral.h: Rename include guard.
6031         * tui/tui-windata.h: Rename include guard.
6032         * tui/tui-win.h: Rename include guard.
6033         * tui/tui-stack.h: Rename include guard.
6034         * tui/tui-source.h: Rename include guard.
6035         * tui/tui-regs.h: Rename include guard.
6036         * tui/tui-out.h: Rename include guard.
6037         * tui/tui-layout.h: Rename include guard.
6038         * tui/tui-io.h: Rename include guard.
6039         * tui/tui-hooks.h: Rename include guard.
6040         * tui/tui-file.h: Rename include guard.
6041         * tui/tui-disasm.h: Rename include guard.
6042         * tui/tui-data.h: Rename include guard.
6043         * tui/tui-command.h: Rename include guard.
6044         * tic6x-tdep.h: Add include guard.
6045         * target/waitstatus.h: Rename include guard.
6046         * target/wait.h: Rename include guard.
6047         * target/target.h: Rename include guard.
6048         * target/resume.h: Rename include guard.
6049         * target-float.h: Rename include guard.
6050         * stabsread.h: Add include guard.
6051         * rs6000-tdep.h: Add include guard.
6052         * riscv-fbsd-tdep.h: Add include guard.
6053         * regformats/regdef.h: Rename include guard.
6054         * record.h: Rename include guard.
6055         * python/python.h: Rename include guard.
6056         * python/python-internal.h: Rename include guard.
6057         * python/py-stopevent.h: Rename include guard.
6058         * python/py-ref.h: Rename include guard.
6059         * python/py-record.h: Rename include guard.
6060         * python/py-record-full.h: Rename include guard.
6061         * python/py-record-btrace.h: Rename include guard.
6062         * python/py-instruction.h: Rename include guard.
6063         * python/py-events.h: Rename include guard.
6064         * python/py-event.h: Rename include guard.
6065         * procfs.h: Add include guard.
6066         * proc-utils.h: Add include guard.
6067         * p-lang.h: Add include guard.
6068         * or1k-tdep.h: Rename include guard.
6069         * observable.h: Rename include guard.
6070         * nto-tdep.h: Rename include guard.
6071         * nat/x86-linux.h: Rename include guard.
6072         * nat/x86-linux-dregs.h: Rename include guard.
6073         * nat/x86-gcc-cpuid.h: Add include guard.
6074         * nat/x86-dregs.h: Rename include guard.
6075         * nat/x86-cpuid.h: Rename include guard.
6076         * nat/ppc-linux.h: Rename include guard.
6077         * nat/mips-linux-watch.h: Rename include guard.
6078         * nat/linux-waitpid.h: Rename include guard.
6079         * nat/linux-ptrace.h: Rename include guard.
6080         * nat/linux-procfs.h: Rename include guard.
6081         * nat/linux-osdata.h: Rename include guard.
6082         * nat/linux-nat.h: Rename include guard.
6083         * nat/linux-namespaces.h: Rename include guard.
6084         * nat/linux-btrace.h: Rename include guard.
6085         * nat/glibc_thread_db.h: Rename include guard.
6086         * nat/gdb_thread_db.h: Rename include guard.
6087         * nat/gdb_ptrace.h: Rename include guard.
6088         * nat/fork-inferior.h: Rename include guard.
6089         * nat/amd64-linux-siginfo.h: Rename include guard.
6090         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6091         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6092         * nat/aarch64-linux.h: Rename include guard.
6093         * nat/aarch64-linux-hw-point.h: Rename include guard.
6094         * mn10300-tdep.h: Add include guard.
6095         * mips-linux-tdep.h: Add include guard.
6096         * mi/mi-parse.h: Rename include guard.
6097         * mi/mi-out.h: Rename include guard.
6098         * mi/mi-main.h: Rename include guard.
6099         * mi/mi-interp.h: Rename include guard.
6100         * mi/mi-getopt.h: Rename include guard.
6101         * mi/mi-console.h: Rename include guard.
6102         * mi/mi-common.h: Rename include guard.
6103         * mi/mi-cmds.h: Rename include guard.
6104         * mi/mi-cmd-break.h: Rename include guard.
6105         * m2-lang.h: Add include guard.
6106         * location.h: Rename include guard.
6107         * linux-record.h: Rename include guard.
6108         * linux-nat.h: Add include guard.
6109         * linux-fork.h: Add include guard.
6110         * i386-darwin-tdep.h: Rename include guard.
6111         * hppa-linux-offsets.h: Add include guard.
6112         * guile/guile.h: Rename include guard.
6113         * guile/guile-internal.h: Rename include guard.
6114         * gnu-nat.h: Rename include guard.
6115         * gdb-stabs.h: Rename include guard.
6116         * frv-tdep.h: Add include guard.
6117         * f-lang.h: Add include guard.
6118         * event-loop.h: Add include guard.
6119         * darwin-nat.h: Rename include guard.
6120         * cp-abi.h: Rename include guard.
6121         * config/sparc/nm-sol2.h: Rename include guard.
6122         * config/nm-nto.h: Rename include guard.
6123         * config/nm-linux.h: Add include guard.
6124         * config/i386/nm-i386gnu.h: Rename include guard.
6125         * config/djgpp/nl_types.h: Rename include guard.
6126         * config/djgpp/langinfo.h: Rename include guard.
6127         * compile/gcc-cp-plugin.h: Add include guard.
6128         * compile/gcc-c-plugin.h: Add include guard.
6129         * compile/compile.h: Rename include guard.
6130         * compile/compile-object-run.h: Rename include guard.
6131         * compile/compile-object-load.h: Rename include guard.
6132         * compile/compile-internal.h: Rename include guard.
6133         * compile/compile-cplus.h: Rename include guard.
6134         * compile/compile-c.h: Rename include guard.
6135         * common/xml-utils.h: Rename include guard.
6136         * common/x86-xstate.h: Rename include guard.
6137         * common/version.h: Rename include guard.
6138         * common/vec.h: Rename include guard.
6139         * common/tdesc.h: Rename include guard.
6140         * common/selftest.h: Rename include guard.
6141         * common/scoped_restore.h: Rename include guard.
6142         * common/scoped_mmap.h: Rename include guard.
6143         * common/scoped_fd.h: Rename include guard.
6144         * common/safe-iterator.h: Rename include guard.
6145         * common/run-time-clock.h: Rename include guard.
6146         * common/refcounted-object.h: Rename include guard.
6147         * common/queue.h: Rename include guard.
6148         * common/ptid.h: Rename include guard.
6149         * common/print-utils.h: Rename include guard.
6150         * common/preprocessor.h: Rename include guard.
6151         * common/pathstuff.h: Rename include guard.
6152         * common/observable.h: Rename include guard.
6153         * common/netstuff.h: Rename include guard.
6154         * common/job-control.h: Rename include guard.
6155         * common/host-defs.h: Rename include guard.
6156         * common/gdb_wait.h: Rename include guard.
6157         * common/gdb_vecs.h: Rename include guard.
6158         * common/gdb_unlinker.h: Rename include guard.
6159         * common/gdb_unique_ptr.h: Rename include guard.
6160         * common/gdb_tilde_expand.h: Rename include guard.
6161         * common/gdb_sys_time.h: Rename include guard.
6162         * common/gdb_string_view.h: Rename include guard.
6163         * common/gdb_splay_tree.h: Rename include guard.
6164         * common/gdb_setjmp.h: Rename include guard.
6165         * common/gdb_ref_ptr.h: Rename include guard.
6166         * common/gdb_optional.h: Rename include guard.
6167         * common/gdb_locale.h: Rename include guard.
6168         * common/gdb_assert.h: Rename include guard.
6169         * common/filtered-iterator.h: Rename include guard.
6170         * common/filestuff.h: Rename include guard.
6171         * common/fileio.h: Rename include guard.
6172         * common/environ.h: Rename include guard.
6173         * common/common-utils.h: Rename include guard.
6174         * common/common-types.h: Rename include guard.
6175         * common/common-regcache.h: Rename include guard.
6176         * common/common-inferior.h: Rename include guard.
6177         * common/common-gdbthread.h: Rename include guard.
6178         * common/common-exceptions.h: Rename include guard.
6179         * common/common-defs.h: Rename include guard.
6180         * common/common-debug.h: Rename include guard.
6181         * common/cleanups.h: Rename include guard.
6182         * common/buffer.h: Rename include guard.
6183         * common/btrace-common.h: Rename include guard.
6184         * common/break-common.h: Rename include guard.
6185         * cli/cli-utils.h: Rename include guard.
6186         * cli/cli-style.h: Rename include guard.
6187         * cli/cli-setshow.h: Rename include guard.
6188         * cli/cli-script.h: Rename include guard.
6189         * cli/cli-interp.h: Rename include guard.
6190         * cli/cli-decode.h: Rename include guard.
6191         * cli/cli-cmds.h: Rename include guard.
6192         * charset-list.h: Add include guard.
6193         * buildsym-legacy.h: Rename include guard.
6194         * bfin-tdep.h: Add include guard.
6195         * ax.h: Rename include guard.
6196         * arm-linux-tdep.h: Add include guard.
6197         * arm-fbsd-tdep.h: Add include guard.
6198         * arch/xtensa.h: Rename include guard.
6199         * arch/tic6x.h: Add include guard.
6200         * arch/i386.h: Add include guard.
6201         * arch/arm.h: Rename include guard.
6202         * arch/arm-linux.h: Rename include guard.
6203         * arch/arm-get-next-pcs.h: Rename include guard.
6204         * arch/amd64.h: Add include guard.
6205         * arch/aarch64-insn.h: Rename include guard.
6206         * arch-utils.h: Rename include guard.
6207         * annotate.h: Add include guard.
6208         * amd64-darwin-tdep.h: Rename include guard.
6209         * aarch64-linux-tdep.h: Add include guard.
6210         * aarch64-fbsd-tdep.h: Add include guard.
6211         * aarch32-linux-nat.h: Add include guard.
6212
6213 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6214
6215         * macrotab.c (macro_define_internal): New function that
6216         factorizes macro_define_object_internal and macro_define_function
6217         code.
6218         (macro_define_object_internal): Use macro_define_internal.
6219         (macro_define_function): Likewise.
6220
6221 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6222
6223         * macrocmd.c (extract_identifier): Return
6224         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6225         callers.
6226
6227 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6228
6229         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6230
6231 2019-02-05  Tom Tromey  <tom@tromey.com>
6232
6233         * target.c (target_stack::unpush): Move assertion earlier.
6234
6235 2019-01-30  Tom Tromey  <tom@tromey.com>
6236
6237         PR python/23615:
6238         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6239         (gdbpy_parse_and_eval): Likewise.
6240         * python/python-internal.h (gdbpy_allow_threads): New class.
6241
6242 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6243
6244         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6245         (aarch64_fbsd_fpregmap): Move earlier.
6246         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6247         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6248         instead of individual calls to trad_frame_set_reg_addr.
6249         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6250         earlier.
6251         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6252         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6253         instead of individual calls to trad_frame_set_reg_addr.
6254
6255 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6256
6257         * CONTRIBUTE: Replace contribution list with wiki link.
6258
6259 2019-01-25  Tom Tromey  <tom@tromey.com>
6260
6261         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6262
6263 2019-01-25  Tom Tromey  <tom@tromey.com>
6264
6265         * xtensa-linux-nat.c: Fix common/ includes.
6266         * xml-support.h: Fix common/ includes.
6267         * xml-support.c: Fix common/ includes.
6268         * x86-linux-nat.c: Fix common/ includes.
6269         * windows-nat.c: Fix common/ includes.
6270         * varobj.h: Fix common/ includes.
6271         * varobj.c: Fix common/ includes.
6272         * value.c: Fix common/ includes.
6273         * valops.c: Fix common/ includes.
6274         * utils.c: Fix common/ includes.
6275         * unittests/xml-utils-selftests.c: Fix common/ includes.
6276         * unittests/utils-selftests.c: Fix common/ includes.
6277         * unittests/unpack-selftests.c: Fix common/ includes.
6278         * unittests/tracepoint-selftests.c: Fix common/ includes.
6279         * unittests/style-selftests.c: Fix common/ includes.
6280         * unittests/string_view-selftests.c: Fix common/ includes.
6281         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6282         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6283         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6284         * unittests/rsp-low-selftests.c: Fix common/ includes.
6285         * unittests/parse-connection-spec-selftests.c: Fix common/
6286         includes.
6287         * unittests/optional-selftests.c: Fix common/ includes.
6288         * unittests/offset-type-selftests.c: Fix common/ includes.
6289         * unittests/observable-selftests.c: Fix common/ includes.
6290         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6291         * unittests/memrange-selftests.c: Fix common/ includes.
6292         * unittests/memory-map-selftests.c: Fix common/ includes.
6293         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6294         * unittests/function-view-selftests.c: Fix common/ includes.
6295         * unittests/environ-selftests.c: Fix common/ includes.
6296         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6297         * unittests/common-utils-selftests.c: Fix common/ includes.
6298         * unittests/cli-utils-selftests.c: Fix common/ includes.
6299         * unittests/array-view-selftests.c: Fix common/ includes.
6300         * ui-file.c: Fix common/ includes.
6301         * tui/tui-io.c: Fix common/ includes.
6302         * tracepoint.h: Fix common/ includes.
6303         * tracepoint.c: Fix common/ includes.
6304         * tracefile-tfile.c: Fix common/ includes.
6305         * top.h: Fix common/ includes.
6306         * top.c: Fix common/ includes.
6307         * thread.c: Fix common/ includes.
6308         * target/waitstatus.h: Fix common/ includes.
6309         * target/waitstatus.c: Fix common/ includes.
6310         * target.h: Fix common/ includes.
6311         * target.c: Fix common/ includes.
6312         * target-memory.c: Fix common/ includes.
6313         * target-descriptions.c: Fix common/ includes.
6314         * symtab.h: Fix common/ includes.
6315         * symfile.c: Fix common/ includes.
6316         * stap-probe.c: Fix common/ includes.
6317         * spu-linux-nat.c: Fix common/ includes.
6318         * sparc-nat.c: Fix common/ includes.
6319         * source.c: Fix common/ includes.
6320         * solib.c: Fix common/ includes.
6321         * solib-target.c: Fix common/ includes.
6322         * ser-unix.c: Fix common/ includes.
6323         * ser-tcp.c: Fix common/ includes.
6324         * ser-pipe.c: Fix common/ includes.
6325         * ser-base.c: Fix common/ includes.
6326         * selftest-arch.c: Fix common/ includes.
6327         * s12z-tdep.c: Fix common/ includes.
6328         * rust-exp.y: Fix common/ includes.
6329         * rs6000-aix-tdep.c: Fix common/ includes.
6330         * riscv-tdep.c: Fix common/ includes.
6331         * remote.c: Fix common/ includes.
6332         * remote-notif.h: Fix common/ includes.
6333         * remote-fileio.h: Fix common/ includes.
6334         * remote-fileio.c: Fix common/ includes.
6335         * regcache.h: Fix common/ includes.
6336         * regcache.c: Fix common/ includes.
6337         * record-btrace.c: Fix common/ includes.
6338         * python/python.c: Fix common/ includes.
6339         * python/py-type.c: Fix common/ includes.
6340         * python/py-inferior.c: Fix common/ includes.
6341         * progspace.h: Fix common/ includes.
6342         * producer.c: Fix common/ includes.
6343         * procfs.c: Fix common/ includes.
6344         * proc-api.c: Fix common/ includes.
6345         * printcmd.c: Fix common/ includes.
6346         * ppc-linux-nat.c: Fix common/ includes.
6347         * parser-defs.h: Fix common/ includes.
6348         * osdata.c: Fix common/ includes.
6349         * obsd-nat.c: Fix common/ includes.
6350         * nat/x86-linux.c: Fix common/ includes.
6351         * nat/x86-linux-dregs.c: Fix common/ includes.
6352         * nat/x86-dregs.h: Fix common/ includes.
6353         * nat/x86-dregs.c: Fix common/ includes.
6354         * nat/ppc-linux.c: Fix common/ includes.
6355         * nat/mips-linux-watch.h: Fix common/ includes.
6356         * nat/mips-linux-watch.c: Fix common/ includes.
6357         * nat/linux-waitpid.c: Fix common/ includes.
6358         * nat/linux-ptrace.h: Fix common/ includes.
6359         * nat/linux-ptrace.c: Fix common/ includes.
6360         * nat/linux-procfs.c: Fix common/ includes.
6361         * nat/linux-personality.c: Fix common/ includes.
6362         * nat/linux-osdata.c: Fix common/ includes.
6363         * nat/linux-namespaces.c: Fix common/ includes.
6364         * nat/linux-btrace.h: Fix common/ includes.
6365         * nat/linux-btrace.c: Fix common/ includes.
6366         * nat/fork-inferior.c: Fix common/ includes.
6367         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6368         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6369         * nat/aarch64-linux.c: Fix common/ includes.
6370         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6371         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6372         * namespace.h: Fix common/ includes.
6373         * mips-linux-tdep.c: Fix common/ includes.
6374         * minsyms.c: Fix common/ includes.
6375         * mi/mi-parse.h: Fix common/ includes.
6376         * mi/mi-main.c: Fix common/ includes.
6377         * mi/mi-cmd-env.c: Fix common/ includes.
6378         * memrange.h: Fix common/ includes.
6379         * memattr.c: Fix common/ includes.
6380         * maint.h: Fix common/ includes.
6381         * maint.c: Fix common/ includes.
6382         * main.c: Fix common/ includes.
6383         * machoread.c: Fix common/ includes.
6384         * location.c: Fix common/ includes.
6385         * linux-thread-db.c: Fix common/ includes.
6386         * linux-nat.c: Fix common/ includes.
6387         * linux-fork.c: Fix common/ includes.
6388         * inline-frame.c: Fix common/ includes.
6389         * infrun.c: Fix common/ includes.
6390         * inflow.c: Fix common/ includes.
6391         * inferior.h: Fix common/ includes.
6392         * inferior.c: Fix common/ includes.
6393         * infcmd.c: Fix common/ includes.
6394         * inf-ptrace.c: Fix common/ includes.
6395         * inf-child.c: Fix common/ includes.
6396         * ia64-linux-nat.c: Fix common/ includes.
6397         * i387-tdep.c: Fix common/ includes.
6398         * i386-tdep.c: Fix common/ includes.
6399         * i386-linux-tdep.c: Fix common/ includes.
6400         * i386-linux-nat.c: Fix common/ includes.
6401         * i386-go32-tdep.c: Fix common/ includes.
6402         * i386-fbsd-tdep.c: Fix common/ includes.
6403         * i386-fbsd-nat.c: Fix common/ includes.
6404         * guile/scm-type.c: Fix common/ includes.
6405         * guile/guile.c: Fix common/ includes.
6406         * go32-nat.c: Fix common/ includes.
6407         * gnu-nat.c: Fix common/ includes.
6408         * gdbthread.h: Fix common/ includes.
6409         * gdbarch-selftests.c: Fix common/ includes.
6410         * gdb_usleep.c: Fix common/ includes.
6411         * gdb_select.h: Fix common/ includes.
6412         * gdb_bfd.c: Fix common/ includes.
6413         * gcore.c: Fix common/ includes.
6414         * fork-child.c: Fix common/ includes.
6415         * findvar.c: Fix common/ includes.
6416         * fbsd-nat.c: Fix common/ includes.
6417         * event-top.c: Fix common/ includes.
6418         * event-loop.c: Fix common/ includes.
6419         * dwarf2read.c: Fix common/ includes.
6420         * dwarf2loc.c: Fix common/ includes.
6421         * dwarf2-frame.c: Fix common/ includes.
6422         * dwarf-index-cache.c: Fix common/ includes.
6423         * dtrace-probe.c: Fix common/ includes.
6424         * disasm-selftests.c: Fix common/ includes.
6425         * defs.h: Fix common/ includes.
6426         * csky-tdep.c: Fix common/ includes.
6427         * cp-valprint.c: Fix common/ includes.
6428         * cp-support.h: Fix common/ includes.
6429         * cp-support.c: Fix common/ includes.
6430         * corelow.c: Fix common/ includes.
6431         * completer.h: Fix common/ includes.
6432         * completer.c: Fix common/ includes.
6433         * compile/compile.c: Fix common/ includes.
6434         * compile/compile-loc2c.c: Fix common/ includes.
6435         * compile/compile-cplus-types.c: Fix common/ includes.
6436         * compile/compile-cplus-symbols.c: Fix common/ includes.
6437         * command.h: Fix common/ includes.
6438         * cli/cli-dump.c: Fix common/ includes.
6439         * cli/cli-cmds.c: Fix common/ includes.
6440         * charset.c: Fix common/ includes.
6441         * build-id.c: Fix common/ includes.
6442         * btrace.h: Fix common/ includes.
6443         * btrace.c: Fix common/ includes.
6444         * breakpoint.h: Fix common/ includes.
6445         * breakpoint.c: Fix common/ includes.
6446         * ax.h:
6447         (enum agent_op): Fix common/ includes.
6448         * ax-general.c (struct aop_map): Fix common/ includes.
6449         * ax-gdb.c: Fix common/ includes.
6450         * auxv.c: Fix common/ includes.
6451         * auto-load.c: Fix common/ includes.
6452         * arm-tdep.c: Fix common/ includes.
6453         * arch/riscv.c: Fix common/ includes.
6454         * arch/ppc-linux-common.c: Fix common/ includes.
6455         * arch/i386.c: Fix common/ includes.
6456         * arch/arm.c: Fix common/ includes.
6457         * arch/arm-linux.c: Fix common/ includes.
6458         * arch/arm-get-next-pcs.c: Fix common/ includes.
6459         * arch/amd64.c: Fix common/ includes.
6460         * arch/aarch64.c: Fix common/ includes.
6461         * arch/aarch64-insn.c: Fix common/ includes.
6462         * arch-utils.c: Fix common/ includes.
6463         * amd64-windows-tdep.c: Fix common/ includes.
6464         * amd64-tdep.c: Fix common/ includes.
6465         * amd64-sol2-tdep.c: Fix common/ includes.
6466         * amd64-obsd-tdep.c: Fix common/ includes.
6467         * amd64-nbsd-tdep.c: Fix common/ includes.
6468         * amd64-linux-tdep.c: Fix common/ includes.
6469         * amd64-linux-nat.c: Fix common/ includes.
6470         * amd64-fbsd-tdep.c: Fix common/ includes.
6471         * amd64-fbsd-nat.c: Fix common/ includes.
6472         * amd64-dicos-tdep.c: Fix common/ includes.
6473         * amd64-darwin-tdep.c: Fix common/ includes.
6474         * agent.c: Fix common/ includes.
6475         * ada-lang.h: Fix common/ includes.
6476         * ada-lang.c: Fix common/ includes.
6477         * aarch64-tdep.c: Fix common/ includes.
6478
6479 2019-01-25  Tom Tromey  <tom@tromey.com>
6480
6481         * common/create-version.sh: Use common/version.h.
6482
6483 2019-01-24  Pedro Alves  <palves@redhat.com>
6484
6485         * infrun.c (signal_stop, signal_print, signal_program)
6486         (signal_catch, signal_pass): Now arrays instead of pointers.
6487         (update_signals_program_target, do_target_resume)
6488         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6489         * linux-nat.c (linux_nat_target::pass_signals)
6490         (linux_nat_target::create_inferior, linux_nat_target::attach):
6491         Adjust.
6492         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6493         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6494         * procfs.c (procfs_target::pass_signals): Adjust.
6495         * record-full.c (record_full_target::resume): Adjust.
6496         * remote.c (remote_target::pass_signals)
6497         (remote_target::program_signals): Adjust.
6498         * target-debug.h (target_debug_print_signals): Now takes a
6499         gdb::array_view as parameter.  Adjust.
6500         * target.h (target_ops) <pass_signals, program_signals>: Replace
6501         pointer and length parameters with gdb::array_view.
6502         (target_pass_signals, target_program_signals): Likewise.
6503         * target-delegates.c: Regenerate.
6504
6505 2019-01-24  Pedro Alves  <palves@redhat.com>
6506
6507         * common/forward-scope-exit.h
6508         (forward_scope_exit::forward_scope_exit): Pass arguments to
6509         m_bind_function directly, instead of creating a std::bind and
6510         copying that.
6511
6512 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6513
6514         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6515         for static members.
6516         (pass_in_v_vfp_candidate): Likewise.
6517
6518 2019-01-23  Tom Tromey  <tom@tromey.com>
6519             Pedro Alves  <palves@redhat.com>
6520
6521         * regcache.c (class regcache_invalidator): Remove.
6522         (regcache::raw_write): Use make_scope_exit.
6523
6524 2019-01-23  Tom Tromey  <tom@tromey.com>
6525
6526         * ui-out.h (class ui_out_emit_type): Update comment.
6527
6528 2019-01-23  Tom Tromey  <tom@tromey.com>
6529
6530         * infrun.c (fetch_inferior_event): Update comment.
6531
6532 2019-01-23  Tom Tromey  <tom@tromey.com>
6533             Pedro Alves  <palves@redhat.com>
6534
6535         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6536         parameter.
6537         (fetch_inferior_event): Use SCOPE_EXIT.
6538
6539
6540 2019-01-23  Tom Tromey  <tom@tromey.com>
6541             Pedro Alves  <palves@redhat.com>
6542
6543         * infrun.c (disable_thread_events): Delete.
6544         (stop_all_threads): Use SCOPE_EXIT.
6545
6546 2019-01-23  Tom Tromey  <tom@tromey.com>
6547             Pedro Alves  <palves@redhat.com>
6548
6549         * symfile.c: Include forward-scope-exit.h.
6550         (clear_symtab_users_cleanup): Replace forward declaration with
6551         a FORWARD_SCOPE_EXIT.
6552         (syms_from_objfile_1): Use the forward_scope_exit and
6553         gdb::optional instead of cleanup_function.
6554         (reread_symbols): Use the forward_scope_exit instead of
6555         cleanup_function.
6556         (clear_symtab_users_cleanup): Remove function.
6557
6558 2019-01-23  Tom Tromey  <tom@tromey.com>
6559             Pedro Alves  <palves@redhat.com>
6560
6561         * linux-nat.c: Include scope-exit.h.
6562         (cleanup_target_stop): Remove.
6563         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6564         SCOPE_EXIT.
6565
6566 2019-01-23  Tom Tromey  <tom@tromey.com>
6567             Pedro Alves  <palves@redhat.com>
6568
6569         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6570         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6571
6572 2019-01-23  Tom Tromey  <tom@tromey.com>
6573             Andrew Burgess  <andrew.burgess@embecosm.com>
6574             Pedro Alves  <palves@redhat.com>
6575
6576         * infrun.c (fetch_inferior_event): Use scope_exit.
6577         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6578         * top.c (execute_command): Use scope_exit.
6579         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6580         * utils.c (do_bpstat_clear_actions_cleanup)
6581         (make_bpstat_clear_actions_cleanup): Remove.
6582
6583 2019-01-23  Tom Tromey  <tom@tromey.com>
6584             Pedro Alves  <palves@redhat.com>
6585
6586         * infrun.c: Include "common/scope-exit.h"
6587         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6588         (wait_for_inferior): Use SCOPE_EXIT.
6589         (fetch_inferior_event): Use scope_exit.
6590
6591 2019-01-23  Tom Tromey  <tom@tromey.com>
6592             Pedro Alves  <palves@redhat.com>
6593
6594         * breakpoint.c (create_breakpoint): Remove cleanup.
6595
6596 2019-01-23  Tom Tromey  <tom@tromey.com>
6597             Andrew Burgess  <andrew.burgess@embecosm.com>
6598             Pedro Alves  <palves@redhat.com>
6599
6600 2019-01-23  Pedro Alves  <palves@redhat.com>
6601
6602         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6603
6604 2019-01-23  Pedro Alves  <palves@redhat.com>
6605             Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * gdbthread.h: Include "common/forward-scope-exit.h".
6608         (scoped_finish_thread_state): Redefine custom class in terms of
6609         forward_scope_exit.
6610
6611 2019-01-23  Pedro Alves  <palves@redhat.com>
6612             Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * common/forward-scope-exit.h: New file.
6615
6616 2019-01-23  Pedro Alves  <palves@redhat.com>
6617             Andrew Burgess  <andrew.burgess@embecosm.com>
6618             Tom Tromey  <tom@tromey.com>
6619
6620         * common/scope-exit.h: New file.
6621
6622 2019-01-23  Pedro Alves  <palves@redhat.com>
6623
6624         * common/preprocessor.h (ESC): Rename to ...
6625         (ESC_PARENS): ... this.
6626         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6627         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6628
6629 2019-01-23  Tom Tromey  <tom@tromey.com>
6630
6631         * language.h (class scoped_switch_to_sym_language_if_auto):
6632         Initialize m_lang in both cases.
6633
6634 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6635
6636         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6637         with XCNEW.
6638
6639 2019-01-22  Tom Tromey  <tom@tromey.com>
6640
6641         * corelow.c: Do not include sys/file.h.
6642
6643 2019-01-22  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-wingeneral.h: Include gdb_curses.h.
6646
6647 2019-01-22  Tom Tromey  <tom@tromey.com>
6648
6649         * source-cache.h (class source_cache) <get_source_lines,
6650         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6651
6652 2019-01-22  Tom Tromey  <tom@tromey.com>
6653
6654         * remote-fileio.h (struct remote_target): Declare.
6655
6656 2019-01-22  Tom Tromey  <tom@tromey.com>
6657
6658         * python/py-arch.c: Do not include py-ref.h.
6659         * python/py-bpevent.c: Do not include py-ref.h.
6660         * python/py-cmd.c: Do not include py-ref.h.
6661         * python/py-continueevent.c: Do not include py-ref.h.
6662         * python/py-event.h: Do not include py-ref.h.
6663         * python/py-evtregistry.c: Do not include py-ref.h.
6664         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6665         * python/py-frame.c: Do not include py-ref.h.
6666         * python/py-framefilter.c: Do not include py-ref.h.
6667         * python/py-function.c: Do not include py-ref.h.
6668         * python/py-infevents.c: Do not include py-ref.h.
6669         * python/py-linetable.c: Do not include py-ref.h.
6670         * python/py-objfile.c: Do not include py-ref.h.
6671         * python/py-param.c: Do not include py-ref.h.
6672         * python/py-prettyprint.c: Do not include py-ref.h.
6673         * python/py-progspace.c: Do not include py-ref.h.
6674         * python/py-symbol.c: Do not include py-ref.h.
6675         * python/py-symtab.c: Do not include py-ref.h.
6676         * python/py-type.c: Do not include py-ref.h.
6677         * python/py-unwind.c: Do not include py-ref.h.
6678         * python/py-utils.c: Do not include py-ref.h.
6679         * python/py-value.c: Do not include py-ref.h.
6680         * python/py-varobj.c: Do not include py-ref.h.
6681         * python/py-xmethods.c: Do not include py-ref.h.
6682         * python/python.c: Do not include py-ref.h.
6683         * varobj.c: Do not include py-ref.h.
6684
6685 2019-01-22  Tom Tromey  <tom@tromey.com>
6686
6687         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6688         keyword for bcache.
6689
6690 2019-01-22  Tom Tromey  <tom@tromey.com>
6691
6692         * compile/compile-cplus-types.c: Remove a comment by #include.
6693
6694 2019-01-22  Tom Tromey  <tom@tromey.com>
6695
6696         * compile/gcc-c-plugin.h: Include compile-internal.h.
6697
6698 2019-01-22  Tom Tromey  <tom@tromey.com>
6699
6700         * stabsread.c (EXTERN): Do not define.
6701         (symnum, next_symbol_text_func, processing_gcc_compilation)
6702         (within_function, global_sym_chain, global_stabs)
6703         (previous_stab_code, this_object_header_files)
6704         (n_this_object_header_files)
6705         (n_allocated_this_object_header_files): Define.
6706         * stabsread.h (EXTERN): Never define.  Use "extern".
6707
6708 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6709
6710         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6711         history_value.
6712
6713 2019-01-21  Tom Tromey  <tom@tromey.com>
6714
6715         * ui-out.c: Fix includes.
6716         * tui/tui-source.c: Fix includes.
6717         * target.c: Fix includes.
6718         * remote.c: Fix includes.
6719         * regcache.c: Fix includes.
6720         * python/py-block.c: Fix includes.
6721         * printcmd.c: Fix includes.
6722         * or1k-tdep.c: Fix includes.
6723         * mi/mi-main.c: Fix includes.
6724         * m32r-tdep.c: Fix includes.
6725         * csky-tdep.c: Fix includes.
6726         * compile/compile-cplus-types.c: Fix includes.
6727         * cli/cli-interp.c: Fix includes.
6728
6729 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6730
6731         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6732         for padding.
6733
6734 2019-01-16  Tom Tromey  <tom@tromey.com>
6735
6736         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6737         earlier.
6738         (struct objfile) <msymbols_range>: Move from top level.
6739         <msymbols>: New method.
6740         (class objfile_msymbols): Remove.
6741         * symtab.c (default_collect_symbol_completion_matches_break_on):
6742         Update.
6743         * symmisc.c (dump_msymbols): Update.
6744         * stabsread.c (scan_file_globals): Update.
6745         * objc-lang.c (info_selectors_command, info_classes_command)
6746         (find_methods): Update.
6747         * minsyms.c (find_solib_trampoline_target): Update.
6748         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6749         * coffread.c (coff_symfile_read): Update.
6750         * ada-lang.c (ada_lookup_simple_minsym)
6751         (ada_collect_symbol_completion_matches): Update.
6752
6753 2019-01-16  Tom Tromey  <tom@tromey.com>
6754
6755         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6756         type.  Remove no-argument constructor.
6757         <iterator::operator++>: Simplify.
6758         <begin>: Update.
6759         <end>: Use minimal_symbol_count.
6760
6761 2019-01-16  Tom Tromey  <tom@tromey.com>
6762
6763         * objfiles.h (struct objfile) <psymtabs>: New method.
6764         (class objfile_psymtabs): Remove.
6765         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6766         typedef.
6767         <range>: New method.
6768         (require_partial_symbols): Change return type.
6769         * psymtab.c (require_partial_symbols)
6770         (psym_expand_symtabs_matching): Update.
6771         * mdebugread.c (parse_partial_symbols): Update.
6772         * dbxread.c (dbx_end_psymtab): Update.
6773
6774 2019-01-15  Tom Tromey  <tom@tromey.com>
6775
6776         * symtab.c (lookup_objfile_from_block)
6777         (lookup_symbol_in_objfile_symtabs)
6778         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6779         (find_line_symtab, info_sources_command)
6780         (default_collect_symbol_completion_matches_break_on)
6781         (make_source_files_completion_list): Update.
6782         * symmisc.c (print_objfile_statistics, dump_objfile)
6783         (maintenance_print_symbols, maintenance_info_symtabs)
6784         (maintenance_check_symtabs, maintenance_info_line_tables):
6785         Update.
6786         * source.c (select_source_symtab)
6787         (forget_cached_source_info_for_objfile): Update.
6788         * objfiles.h (class objfile_compunits): Remove.
6789         (struct objfile) <compunits_range>: New typedef.
6790         (compunits): New method.
6791         * objfiles.c (objfile_relocate1): Update.
6792         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6793         * maint.c (count_symtabs_and_blocks): Update.
6794         * linespec.c (iterate_over_all_matching_symtabs): Update.
6795         * cp-support.c (add_symbol_overload_list_qualified): Update.
6796         * coffread.c (coff_symtab_read): Update.
6797         * ada-lang.c (add_nonlocal_symbols)
6798         (ada_collect_symbol_completion_matches)
6799         (ada_add_global_exceptions): Update.
6800
6801 2019-01-15  Tom Tromey  <tom@tromey.com>
6802
6803         * progspace.h (program_space) <objfiles_safe_range>: New
6804         typedef.
6805         <objfiles_safe>: New method.
6806         * objfiles.h (class all_objfiles_safe): Remove.
6807         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6808         * jit.c (jit_inferior_exit_hook): Update.
6809
6810 2019-01-17  Tom Tromey  <tom@tromey.com>
6811
6812         * progspace.h (program_space) <objfiles_range>: New typedef.
6813         <objfiles>: New method.
6814         <objfiles_head>: Rename from objfiles.
6815         (object_files): Update.
6816         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6817         * guile/scm-pretty-print.c
6818         (ppscm_find_pretty_printer_from_objfiles): Update.
6819         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6820         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6821         Update.
6822         * python/py-progspace.c (pspy_get_objfiles): Update.
6823         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6824         Update.
6825         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6826         (objfpy_lookup_objfile_by_build_id): Update.
6827         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6828         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6829         Update.
6830         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6831         (expand_symtab_containing_pc, lookup_objfile_from_block)
6832         (lookup_static_symbol, basic_lookup_transparent_type)
6833         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6834         (find_line_symtab, info_sources_command)
6835         (default_collect_symbol_completion_matches_break_on)
6836         (make_source_files_completion_list, find_main_name): Update.
6837         * symmisc.c (print_symbol_bcache_statistics)
6838         (print_objfile_statistics, maintenance_print_symbols)
6839         (maintenance_print_msymbols, maintenance_print_objfiles)
6840         (maintenance_info_symtabs, maintenance_check_symtabs)
6841         (maintenance_expand_symtabs, maintenance_info_line_tables):
6842         Update.
6843         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6844         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6845         (map_overlay_command, unmap_overlay_command)
6846         (simple_overlay_update, expand_symtabs_matching)
6847         (map_symbol_filenames): Update.
6848         * symfile-debug.c (set_debug_symfile): Update.
6849         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6850         Update.
6851         * source.c (select_source_symtab, forget_cached_source_info):
6852         Update.
6853         * solib.c (solib_read_symbols): Update.
6854         * solib-spu.c (append_ocl_sos): Update.
6855         * psymtab.c (maintenance_print_psymbols)
6856         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6857         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6858         * printcmd.c (info_symbol_command): Update.
6859         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6860         Update.
6861         * objfiles.h (class all_objfiles): Remove.
6862         * objfiles.c (have_partial_symbols, have_full_symbols)
6863         (have_minimal_symbols, qsort_cmp, update_section_map)
6864         (shared_objfile_contains_address_p)
6865         (default_iterate_over_objfiles_in_search_order): Update.
6866         * objc-lang.c (info_selectors_command, info_classes_command)
6867         (find_methods): Update.
6868         * minsyms.c (find_solib_trampoline_target): Update.
6869         * maint.c (maintenance_info_sections)
6870         (maintenance_translate_address, count_symtabs_and_blocks):
6871         Update.
6872         * main.c (captured_main_1): Update.
6873         * linux-thread-db.c (try_thread_db_load_from_pdir)
6874         (has_libpthread): Update.
6875         * linespec.c (iterate_over_all_matching_symtabs)
6876         (search_minsyms_for_name): Update.
6877         * jit.c (jit_find_objf_with_entry_addr): Update.
6878         * hppa-tdep.c (find_unwind_entry)
6879         (hppa_lookup_stub_minimal_symbol): Update.
6880         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6881         Update.
6882         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6883         (elf_gnu_ifunc_resolve_by_got): Update.
6884         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6885         * dwarf-index-write.c (save_gdb_index_command): Update.
6886         * cp-support.c (add_symbol_overload_list_qualified): Update.
6887         * breakpoint.c (create_overlay_event_breakpoint)
6888         (create_longjmp_master_breakpoint)
6889         (create_std_terminate_master_breakpoint)
6890         (create_exception_master_breakpoint): Update.
6891         * blockframe.c (find_pc_partial_function): Update.
6892         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6893         (ada_collect_symbol_completion_matches)
6894         (ada_add_global_exceptions): Update.
6895
6896 2019-01-17  Tom Tromey  <tom@tromey.com>
6897
6898         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6899         declare VEC.
6900         (solib_target_parse_libraries): Change return type.
6901         (library_list_start_segment, library_list_start_section)
6902         (library_list_end_library, library_list_start_library); Update.
6903         (solib_target_free_library_list): Remove.
6904         (solib_target_parse_libraries): Remove cleanup.  Change return
6905         type.
6906         (solib_target_current_sos): Update.
6907
6908 2019-01-17  Tom Tromey  <tromey@bapiya>
6909
6910         * valprint.c: Replace "the the" with "the".
6911         * symtab.c: Replace "the the" with "the".
6912         * solib.c: Replace "the the" with "the".
6913         * solib-dsbt.c: Replace "the the" with "the".
6914         * linespec.c: Replace "the the" with "the".
6915         * dwarf2loc.h: Replace "the the" with "the".
6916         * amd64-windows-tdep.c: Replace "the the" with "the".
6917         * aarch64-tdep.c: Replace "the the" with "the".
6918
6919 2019-01-16  Keith Seitz  <keiths@redhat.com>
6920
6921         PR gdb/23773
6922         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6923         <builder>: Rename to ..
6924         <m_builder>: ... this and make private.
6925         (dwarf2_cu::get_builder): New method.  Change all users of
6926         `builder' to use this method.
6927         (dwarf2_start_symtab): Move to ...
6928         (dwarf2_cu::start_symtab): ... here.  Update all callers
6929         (setup_type_unit_groups): Move to ...
6930         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6931         callers.
6932         (dwarf2_cu::reset_builder): New method.
6933         (process_full_compunit, process_full_type_unit): Use
6934         dwarf2_cu::reset_builder.
6935         (follow_die_offset): Record the ancestor CU if it is different
6936         from the followed DIE's CU.
6937         (follow_die_sig_1): Likewise.
6938
6939 2019-01-15  Tom Tromey  <tom@tromey.com>
6940
6941         * remote.c (class remote_state) <buf>: Now a char_vector.
6942         <buf_size>: Remove.
6943         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6944         parameter.
6945         (remote_target::getpkt_or_notif_sane_1)
6946         (remote_target::getpkt_sane)
6947         (remote_target::getpkt_or_notif_sane): Likewise.
6948         (class remote_target) <putpkt>: New overload.
6949         (remote_target::read_frame): Change type of "buf_p".  Remove
6950         sizeof_p parameter.
6951         (packet_ok): New overload.
6952         (packet_check_result): New overload.
6953         Update all uses.
6954
6955 2019-01-14  Tom Tromey  <tom@tromey.com>
6956
6957         * remote-notif.c (handle_notification, remote_notif_ack)
6958         (remote_notif_parse): Make "buf" const.
6959         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6960         const.
6961         (remote_notif_parse, remote_notif_ack, handle_notification):
6962         Likewise.
6963         * remote.c (remote_notif_stop_parse): Make "buf" const.
6964         (remote_target::remote_parse_stop_reply): Make "buf" const.
6965         (remote_notif_stop_ack): Make "buf" const.
6966
6967 2019-01-14  Tom Tromey  <tom@tromey.com>
6968
6969         * remote.c (remote_console_output): Make parameter const.
6970
6971 2019-01-14  Tom Tromey  <tom@tromey.com>
6972
6973         * target-debug.h (target_debug_print_signals): Constify.
6974         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6975         * procfs.c (procfs_target::pass_signals): Update.
6976         * linux-nat.c (linux_nat_target::pass_signals): Update.
6977         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6978         * target-delegates.c: Rebuild.
6979         * remote.c (remote_target::program_signals): Update.
6980         (remote_target::pass_signals): Update.
6981         * target.c (target_pass_signals): Constify argument.
6982         (target_program_signals): Likewise.
6983         * target.h (struct target_ops) <pass_signals, program_signals>:
6984         Constify argument.
6985         (target_pass_signals, target_program_signals): Constify argument.
6986
6987 2019-01-14  Tom Tromey  <tom@tromey.com>
6988
6989         PR tui/28819:
6990         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6991
6992 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6993
6994         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6995         field.
6996         * rs6000-tdep.c: Include reggroups.h.
6997         (IS_V_ALIAS_PSEUDOREG): Define.
6998         (rs6000_register_name): Return names for the "vX" aliases.
6999         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7000         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7001         aliases.  Call default_register_reggroup_p for all other
7002         pseudo-registers.
7003         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7004         New functions.
7005         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7006         Handle "vX" aliases.
7007         (v_alias_pseudo_register_collect): New function.
7008         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7009         (rs6000_gdbarch_init): Initialize "vX" aliases as
7010         pseudo-registers.  Restore registration of
7011         rs6000_pseudo_register_reggroup_p with
7012         set_tdesc_pseudo_register_reggroup_p.
7013
7014 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7015
7016         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7017         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7018         set_gdbarch_num_pseudo_regs.
7019
7020 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7021
7022         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7023         Remove arg prefixname, add do_set and do_show.
7024         Add member functions set_list and show_list.
7025         * cli/cli-style.c (class cli_style_option): Update accordingly.
7026         (style_set_list): Move to file scope.
7027         (style_show_list): Likewise.
7028         (set_style): Call help_list.
7029         (show_style): Call cmd_show_list.
7030         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7031         Update to use the new macro.
7032
7033 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7034
7035         * ada-lang.c (_initialize_ada_language): Expand the help text
7036         for the "catch exception" command.
7037
7038 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7039
7040         * symtab.c (matching_obj_sections): Initialize obj,
7041         declare it closer to its usage.
7042
7043 2019-01-10  Tom Tromey  <tom@tromey.com>
7044
7045         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7046         (basic_inf_threads_range): Remove.
7047         (inf_threads_range, inf_non_exited_threads_range)
7048         (safe_inf_threads_range): Use next_adapter.
7049
7050 2019-01-10  Keith Seitz  <keiths@redhat.com>
7051
7052         PR gdb/23712
7053         PR symtab/23010
7054         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7055         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7056
7057 2019-01-10  Keith Seitz  <keiths@redhat.com>
7058
7059         PR gdb/23712
7060         PR symtab/23010
7061         * dictionary.c (pending_to_vector): Remove.
7062         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7063         Remove _1 suffix, replacing functions of the same name.  Update
7064         all callers.
7065         (dict_create_hashed, dict_create_hashed_expandable)
7066         (dict_create_linear, dict_create_linear_expandable, dict_free)
7067         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7068         Make functions static.
7069
7070 2019-01-10  Keith Seitz  <keiths@redhat.com>
7071
7072         PR gdb/23712
7073         PR symtab/23010
7074         * dictionary.h (struct dictionary): Replace declaration with
7075         multidictionary.
7076         (dict_create_hashed, dict_create_hashed_expandable)
7077         (dict_create_linear, dict_create_linear_expandable)
7078         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7079         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7080         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7081         taking multidictionary argument.
7082         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7083         * block.h (struct block) <dict>: Change to multidictionary
7084         and rename `multidict'.
7085         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7086         symmisc.c: Update all dictionary references to multidictionary.
7087
7088 2019-01-10  Keith Seitz  <keiths@redhat.com>
7089
7090         PR gdb/23712
7091         PR symtab/23010
7092         * dictionary.c: Include unordered_map.
7093         (pending_to_vector): New function.
7094         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7095         Rewrite the non-"_1" functions to take vector instead
7096         of linked list.
7097         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7098         "new" _1 versions of the same name.
7099         (multidictionary): Define.
7100         (std::hash<enum language): New definition.
7101         (collate_pending_symbols_by_language, mdict_create_hashed)
7102         (mdict_create_hashed_expandable, mdict_create_linear)
7103         (mdict_create_linear_expandable, mdict_free)
7104         (find_language_dictionary, create_new_language_dictionary)
7105         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7106         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7107         (mdict_size, mdict_empty): New functions.
7108         * dictionary.h (mdict_iterator): Define.
7109
7110 2019-01-10  Pedro Alves  <palves@redhat.com>
7111
7112         * breakpoint.c (read_uploaded_action)
7113         (create_tracepoint_from_upload): Adjust to use
7114         gdb::unique_xmalloc_ptr.
7115         * ctf.c (ctf_write_uploaded_tp):
7116         (SET_ARRAY_FIELD): Use emplace_back.
7117         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7118         * tracefile-tfile.c (tfile_write_uploaded_tp):
7119         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7120         gdb::unique_xmalloc_ptr.
7121         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7122         at_string, cond_string, cmd_strings>: Replace char pointers
7123         with gdb::unique_xmalloc_ptr.
7124
7125 2019-01-10  Pedro Alves  <palves@redhat.com>
7126
7127         * solib-target.c (library_list_start_library): Don't xstrdup name.
7128
7129 2019-01-10  Pedro Alves  <palves@redhat.com>
7130
7131         * mdebugread.c (parse_partial_symbols): Use
7132         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7133
7134 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * linux-fork.c (scoped_switch_fork_info)
7137         <~scoped_switch_fork_info>: Fix incorrect variable name.
7138
7139 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7140
7141         * linux-fork.c (scoped_switch_fork_info)
7142         <scoped_switch_fork_info>: Make explicit.
7143         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7144
7145 2019-01-10  Tom Tromey  <tom@tromey.com>
7146
7147         * objfiles.h (objfile::reset_psymtabs): Update.
7148         * objfiles.c (objfile::objfile): Update.
7149         * psymtab.h (psymtab_storage::obstack): Update.
7150         (psymtab_storage::m_obstack): Use gdb::optional.
7151         (class psymtab_storage): Update comment.  Remove objfile
7152         parameter.
7153         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7154
7155 2019-01-10  Tom Tromey  <tom@tromey.com>
7156
7157         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7158         <free_psymtabs>: Now private.
7159         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7160         (allocate_psymtab): Use new method.
7161
7162 2019-01-10  Tom Tromey  <tom@tromey.com>
7163
7164         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7165         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7166         * mdebugread.c (parse_partial_symbols): Use
7167         allocate_dependencies.
7168         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7169         allocate_dependencies.
7170         (process_psymtab_comp_unit_reader)
7171         (build_type_psymtab_dependencies): Likewise.
7172         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7173
7174 2019-01-10  Tom Tromey  <tom@tromey.com>
7175
7176         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7177         PSYMBOL_SET_LANGUAGE.
7178         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7179
7180 2019-01-10  Tom Tromey  <tom@tromey.com>
7181
7182         * psymtab.h (psymtab_storage::obstack): New method.
7183         <m_obstack>: Rename from obstack; now private.
7184         * psymtab.c (psymtab_storage): Update.
7185         * dwarf2read.c (create_addrmap_from_index)
7186         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7187         Update.
7188
7189 2019-01-10  Tom Tromey  <tom@tromey.com>
7190
7191         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7192         * objfiles.h (objfile::reset_psymtabs): New method.
7193
7194 2019-01-10  Tom Tromey  <tom@tromey.com>
7195
7196         * symmisc.c (print_symbol_bcache_statistics): Update.
7197         (print_objfile_statistics): Update.
7198         * symfile.c (reread_symbols): Update.
7199         * psymtab.h (class psymtab_storage): New.
7200         * psymtab.c (psymtab_storage): New constructor.
7201         (~psymtab_storage): New destructor.
7202         (require_partial_symbols): Update.
7203         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7204         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7205         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7206         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7207         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7208         (start_psymtab_common, end_psymtab_common)
7209         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7210         (allocate_psymtab): Update.
7211         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7212         Update.
7213         (dump_psymtab_addrmap, maintenance_print_psymbols)
7214         (maintenance_check_psymtabs): Update.
7215         (class objfile_psymtabs): Move to objfiles.h.
7216         * psympriv.h (discard_psymtab): Now inline.
7217         (psymtab_discarder::psymtab_discarder): Update.
7218         (psymtab_discarder::~psymtab_discarder): Update.
7219         (ALL_OBJFILE_PSYMTABS): Rewrite.
7220         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7221         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7222         Remove fields.
7223         <partial_symtabs>: New field.
7224         (class objfile_psymtabs): Move from psymtab.h.  Update.
7225         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7226         psymbol_cache.
7227         (objfile::~objfile): Don't destroy psymbol_cache.
7228         * mdebugread.c (parse_partial_symbols): Update.
7229         * dwarf2read.c (create_addrmap_from_index)
7230         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7231         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7232         (add_partial_subprogram, dwarf2_ranges_read): Update.
7233         * dwarf-index-write.c (write_address_map)
7234         (write_one_signatured_type, recursively_write_psymbols)
7235         (class debug_names, class debug_names, write_psymtabs_to_index):
7236         Update.
7237
7238 2019-01-10  Tom Tromey  <tom@tromey.com>
7239
7240         * symtab.h (SYMBOL_SET_NAMES): Update.
7241         (symbol_set_names): Update.
7242         (MSYMBOL_SET_NAMES): Update.
7243         * symtab.c (symbol_set_names): Change argument to be an
7244         objfile_per_bfd_storage.
7245         * psymtab.c (add_psymbol_to_bcache): Update.
7246         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7247
7248 2019-01-10  Tom Tromey  <tom@tromey.com>
7249
7250         * symtab.c (create_demangled_names_hash): Change argument to be an
7251         objfile_per_bfd_storage.
7252         (symbol_set_names): Update.
7253
7254 2019-01-10  Tom Tromey  <tom@tromey.com>
7255
7256         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7257         init_psymbol_list.
7258         * psymtab.c (init_psymbol_list): Do nothing if already called.
7259         * psympriv.h (init_psymbol_list): Add comment.
7260         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7261         init_psymbol_list.
7262         * dbxread.c (dbx_symfile_read): Unconditionally call
7263         init_psymbol_list.
7264
7265 2019-01-10  Tom Tromey  <tom@tromey.com>
7266
7267         * xcoffread.c (scan_xcoff_symtab): Update.
7268         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7269         "where".
7270         * mdebugread.c (parse_partial_symbols)
7271         (handle_psymbol_enumerators): Update.
7272         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7273         * dbxread.c (read_dbx_symtab): Update.
7274         * psympriv.h (psymbol_placement): New enum.
7275         (add_psymbol_to_list): Update.
7276
7277 2019-01-10  Tom Tromey  <tom@tromey.com>
7278
7279         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7280         static_psymbols parameters.
7281         (scan_xcoff_symtab): Update.
7282         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7283         static_psymbols parameters.
7284         * psympriv.h (start_psymtab_common): Update.
7285         * mdebugread.c (parse_partial_symbols): Update.
7286         * dwarf2read.c (create_partial_symtab): Update.
7287         * dbxread.c (read_dbx_symtab): Update.
7288         (start_psymtab): Remove global_psymbols and static_psymbols
7289         parameters.
7290
7291 2019-01-10  Tom Tromey  <tom@tromey.com>
7292
7293         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7294         * psymtab.c (allocate_psymtab): Add comment.
7295         * psympriv.h (allocate_psymtab): Add comment.
7296         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7297         initializations.
7298         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7299
7300 2019-01-10  Tom Tromey  <tom@tromey.com>
7301
7302         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7303         Don't declare.
7304         * mipsread.c: Include mdebugread.h.
7305         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7306         Declare.
7307         * elfread.c: Include mdebugread.h.
7308
7309 2019-01-09  Tom Tromey  <tom@tromey.com>
7310
7311         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7312         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7313         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7314         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7315         (psym_lookup_symbol, psym_find_last_source_symtab)
7316         (psym_forget_cached_source_info, psym_print_stats)
7317         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7318         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7319         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7320         (psym_find_compunit_symtab_by_address)
7321         (maintenance_print_psymbols, maintenance_info_psymtabs)
7322         (maintenance_check_psymtabs): Use ranged for.
7323         * psymtab.h (class objfile_psymtabs): New.
7324         (require_partial_symbols): Return objfile_psymtabs.
7325         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7326
7327 2019-01-09  Tom Tromey  <tom@tromey.com>
7328
7329         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7330         (find_pc_mapped_section, list_overlays_command)
7331         (map_overlay_command, unmap_overlay_command)
7332         (simple_overlay_update): Use all_objfiles.
7333         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7334         * printcmd.c (info_symbol_command): Use all_objfiles.
7335         * objfiles.h (ALL_OBJSECTIONS): Remove.
7336         * maint.c (maintenance_translate_address): Use all_objfiles.
7337         * gcore.c (gcore_create_callback): Use all_objfiles.
7338         (objfile_find_memory_regions): Likewise.
7339
7340 2019-01-09  Tom Tromey  <tom@tromey.com>
7341
7342         * symtab.c (find_line_symtab, info_sources_command)
7343         (make_source_files_completion_list): Use objfile_compunits.
7344         * source.c (select_source_symtab): Use objfile_compunits.
7345         * objfiles.h (struct objfile): Update comment.
7346         (ALL_OBJFILES): Remove.
7347         (ALL_FILETABS): Remove.
7348         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7349         objfile_compunits.
7350
7351 2019-01-09  Tom Tromey  <tom@tromey.com>
7352
7353         * symmisc.c (print_objfile_statistics, dump_objfile)
7354         (maintenance_print_symbols): Use compunit_filetabs.
7355         * source.c (forget_cached_source_info_for_objfile): Use
7356         compunit_filetabs.
7357         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7358         (ALL_FILETABS): Use compunit_filetabs.
7359         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7360         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7361
7362 2019-01-09  Tom Tromey  <tom@tromey.com>
7363
7364         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7365         (compunit_filetabs): New.
7366         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7367         compunit_filetabs.
7368         (info_sources_command, make_source_files_completion_list): Remove
7369         declaration.
7370         * symmisc.c (print_objfile_statistics, dump_objfile)
7371         (maintenance_print_symbols): Remove declaration.
7372         (maintenance_info_symtabs): Use compunit_filetabs.
7373         (maintenance_info_line_tables): Likewise.
7374         * source.c (select_source_symtab): Change local variable name.
7375         (forget_cached_source_info_for_objfile): Remove declaration.
7376         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7377         * objfiles.c (objfile_relocate1): Remove declaration.
7378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7379         declaration.
7380         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7381         * coffread.c (coff_symtab_read): Remove declaration.
7382         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7383         compunit_filetabs.
7384
7385 2019-01-09  Tom Tromey  <tom@tromey.com>
7386
7387         * symtab.c (lookup_objfile_from_block)
7388         (find_pc_sect_compunit_symtab, search_symbols)
7389         (default_collect_symbol_completion_matches_break_on): Use
7390         objfile_compunits.
7391         * objfiles.h (ALL_COMPUNITS): Remove.
7392         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7393         * cp-support.c (add_symbol_overload_list_qualified): Use
7394         objfile_compunits.
7395         * ada-lang.c (ada_collect_symbol_completion_matches)
7396         (ada_add_global_exceptions): Use objfile_compunits.
7397
7398 2019-01-09  Tom Tromey  <tom@tromey.com>
7399
7400         * source.c (select_source_symtab)
7401         (forget_cached_source_info_for_objfile): Remove declaration.
7402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7403         declaration.
7404         * maint.c (count_symtabs_and_blocks): Remove declaration.
7405         * cp-support.c (add_symbol_overload_list_qualified): Remove
7406         declaration.
7407         * coffread.c (coff_symtab_read): Remove declaration.
7408         * symtab.c (lookup_symbol_in_objfile_symtabs)
7409         (basic_lookup_transparent_type_1): Use objfile_compunits.
7410         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7411         (info_sources_command, search_symbols)
7412         (default_collect_symbol_completion_matches_break_on)
7413         (make_source_files_completion_list): Remove declaration.
7414         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7415         (ada_collect_symbol_completion_matches)
7416         (ada_add_global_exceptions): Remove declaration.
7417         * linespec.c (iterate_over_all_matching_symtabs): Use
7418         objfile_compunits.
7419         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7420         (class objfile_compunits): New.
7421         (ALL_COMPUNITS): Use objfile_compunits.
7422         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7423         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7424         objfile_compunits.
7425         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7426
7427 2019-01-09  Tom Tromey  <tom@tromey.com>
7428
7429         * symtab.c (search_symbols)
7430         (default_collect_symbol_completion_matches_break_on): Use
7431         objfile_msymbols.
7432         * ada-lang.c (ada_lookup_simple_minsym)
7433         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7434         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7435         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7436         objfile_msymbols.
7437         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7438         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7439         * objc-lang.c (find_methods): Use objfile_msymbols.
7440         (info_selectors_command, info_classes_command): Likewise.
7441         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7442         * objfiles.h (class objfile_msymbols): New.
7443         (ALL_OBJFILE_MSYMBOLS): Remove.
7444         (ALL_MSYMBOLS): Remove.
7445
7446 2019-01-09  Tom Tromey  <tom@tromey.com>
7447
7448         * common/next-iterator.h (next_adapter): Add Iterator template
7449         parameter.
7450         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7451         (class all_objfiles_safe): New.
7452         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7453         * objfiles.c (put_objfile_before): Update comment.
7454         (add_separate_debug_objfile): Likewise.
7455         (free_all_objfiles): Use all_objfiles_safe.
7456         (objfile_purge_solibs): Likewise.
7457
7458 2019-01-09  Tom Tromey  <tom@tromey.com>
7459
7460         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7461         (expand_symtab_containing_pc, lookup_static_symbol)
7462         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7463         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7464         all_objfiles.
7465         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7466         * breakpoint.c (create_overlay_event_breakpoint)
7467         (create_longjmp_master_breakpoint)
7468         (create_std_terminate_master_breakpoint)
7469         (create_exception_master_breakpoint): Use all_objfiles.
7470         * linux-thread-db.c (try_thread_db_load_from_pdir)
7471         (has_libpthread): Use all_objfiles.
7472         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7473         * linespec.c (iterate_over_all_matching_symtabs)
7474         (search_minsyms_for_name): Use all_objfiles.
7475         * maint.c (maintenance_info_sections): Use all_objfiles.
7476         * main.c (captured_main_1): Use all_objfiles.
7477         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7478         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7479         * guile/scm-pretty-print.c
7480         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7481         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7482         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7483         (maintenance_print_msymbols): Use all_objfiles.
7484         * source.c (select_source_symtab): Use all_objfiles.
7485         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7486         * symfile.c (remove_symbol_file_command)
7487         (expand_symtabs_matching, map_symbol_filenames): Use
7488         all_objfiles.
7489         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7490         all_objfiles.
7491         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7492         * objc-lang.c (find_methods): Use all_objfiles.
7493         * objfiles.c (have_partial_symbols, have_full_symbols)
7494         (have_minimal_symbols, qsort_cmp)
7495         (default_iterate_over_objfiles_in_search_order): Use
7496         all_objfiles.
7497         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7498         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7499         (maintenance_check_psymtabs): Use all_objfiles.
7500         (ALL_PSYMTABS): Remove.
7501         * compile/compile-object-run.c (do_module_cleanup): Use
7502         all_objfiles.
7503         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7504         * cp-support.c (add_symbol_overload_list_qualified): Use
7505         all_objfiles.
7506         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7507         Use all_objfiles.
7508         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7509         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7510         all_objfiles.
7511         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7512         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7513         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7514         Uses all_objfiles.
7515         * solib.c (solib_read_symbols): Use all_objfiles
7516
7517 2019-01-09  Tom Tromey  <tom@tromey.com>
7518
7519         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7520         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7521         all_objfiles.
7522         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7523         * symmisc.c (print_symbol_bcache_statistics)
7524         (print_objfile_statistics, maintenance_print_objfiles)
7525         (maintenance_info_symtabs, maintenance_check_symtabs)
7526         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7527         all_objfiles.
7528         * source.c (forget_cached_source_info): Use all_objfiles.
7529         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7530         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7531         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7532         * objfiles.c (update_section_map): Use all_objfiles.
7533         (shared_objfile_contains_address_p): Likewise.
7534         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7535         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7536
7537 2019-01-09  Tom Tromey  <tom@tromey.com>
7538
7539         * common/next-iterator.h: New file.
7540         * objfiles.h (class all_objfiles): New.
7541         (struct objfile_iterator): New.
7542
7543 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7544
7545         * NEWS: Move the description of the changed "frame", "select-frame",
7546          and "info frame" commands to the Changed commands section.
7547
7548 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7549
7550         * gdbtypes.c (check_stub_method_group): Remove handling of old
7551         mangling schemes.
7552         * linespec.c (find_methods): Likewise.
7553         * stabsread.c (read_member_functions): Likewise.
7554         * valops.c (search_struct_method): Likewise.
7555         (value_struct_elt_for_reference): Likewise.
7556         * NEWS: Mention this change.
7557
7558 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7561         print_source_lines.
7562         * source.c (print_source_lines_base): Update line number check.
7563         (print_source_lines): New function.
7564         (source_lines_range::source_lines_range): New function.
7565         * source.h (class source_lines_range): New class.
7566         (print_source_lines): New declaration.
7567
7568 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7569
7570         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7571
7572 2019-01-08  Tom Tromey  <tom@tromey.com>
7573             Simon Marchi  <simon.marchi@ericsson.com>
7574
7575         PR gdb/24060
7576         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7577         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7578         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7579         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7580         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7581         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7582
7583 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * source.c (select_source_symtab): Move header comment to
7586         declaration in source.h.
7587         (forget_cached_source_info_for_objfile): Likewise.
7588         (forget_cached_source_info): Likewise.
7589         (identify_source_line): Likewise.
7590         * source.h (identify_source_line): Move declaration from symtab.h
7591         and add comment from source.c
7592         (print_source_lines): Likewise.
7593         (forget_cached_source_info_for_objfile): Likewise.
7594         (forget_cached_source_info): Likewise.
7595         (select_source_symtab): Likewise.
7596         (enum print_source_lines_flag): Move definition from symtab.h.
7597         * symtab.h (identify_source_line): Move declaration to source.h.
7598         (print_source_lines): Likewise.
7599         (forget_cached_source_info_for_objfile): Likewise.
7600         (forget_cached_source_info): Likewise.
7601         (select_source_symtab): Likewise.
7602         (enum print_source_lines_flag): Move definition to source.h.
7603         * tui/tui-hooks.c: Add 'source.h' include.
7604
7605 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         * source.c (print_source_lines_base): Handle requests to print
7608         reverse line number sequences, and guard against empty lines
7609         string.
7610
7611 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * source.c (print_source_lines_base): Fix skip of '\r' if next
7614         character is '\n'.
7615
7616 2019-01-06  Tom Tromey  <tom@tromey.com>
7617
7618         * c-exp.y (struct c_parse_state) <macro_original_text,
7619         expansion_obstack>: New member.
7620         (macro_original_text, expansion_obstack): Remove globals.
7621         (scan_macro_expansion, scanning_macro_expansion)
7622         (finished_macro_expansion): Update.
7623         (scan_macro_cleanup): Remove.
7624         (yylex, c_parse): Update.
7625
7626 2019-01-06  Tom Tromey  <tom@tromey.com>
7627
7628         * c-exp.y (struct c_parse_state) <strings>: New member.
7629         (operator_stoken): Update.
7630
7631 2019-01-06  Tom Tromey  <tom@tromey.com>
7632
7633         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7634         (union type_stack_elt) <typelist_val>: Now a pointer to
7635         std::vector.
7636         (type_stack_cleanup): Don't declare.
7637         (push_typelist): Update.
7638         * parse.c (pop_typelist): Return a std::vector.
7639         (push_typelist): Take a std::vector.
7640         (follow_types): Update.  Do not free args.
7641         (type_stack_cleanup): Remove.
7642         * c-exp.y (struct c_parse_state): New.
7643         (cpstate): New global.
7644         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7645         (nonempty_typelist): Update.
7646         (func_mod): Create a new vector.
7647         (c_parse): Create a c_parse_state.
7648         (check_parameter_typelist): Do not delete params.
7649         (function_method): Update.  Do not delete type_list.
7650
7651 2019-01-06  Tom Tromey  <tom@tromey.com>
7652
7653         PR gdb/28155:
7654         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7655         check_typedef.
7656         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7657         (print_return_value): Likewise.
7658
7659 2019-01-05  Tom Tromey  <tom@tromey.com>
7660
7661         * contrib/cleanup_check.py: Remove.
7662         * contrib/gcc-with-excheck: Remove.
7663         * contrib/exsummary.py: Remove.
7664         * contrib/excheck.py: Remove.
7665
7666 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7667
7668         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7669         NULL. Initialize tpprev to NULL instead of assigning it
7670         to NULL on the next statement.
7671         * windows-nat.c (windows_delete_thread): Remove check for
7672         main_thread_id before printing thread exit notifications.
7673         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7674         Remove thread ID check against main_thread_id.
7675         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7676         windows_delete_thread.
7677         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7678
7679 2019-01-04  Tom Tromey  <tom@tromey.com>
7680
7681         * compile/compile.c (_initialize_compile): Use upper case for
7682         metasyntactic variables.
7683         * symmisc.c (_initialize_symmisc): Use upper case for
7684         metasyntactic variables.
7685         * psymtab.c (_initialize_psymtab): Use upper case for
7686         metasyntactic variables.
7687         * demangle.c (demangle_command): Use upper case for metasyntactic
7688         variables.
7689         (_initialize_demangler): Likewise.
7690         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7691         variables.
7692
7693 2019-01-03  Tom Tromey  <tom@tromey.com>
7694
7695         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7696
7697 2019-01-03  Tom Tromey  <tom@tromey.com>
7698
7699         * python/py-symtab.c (salpy_str): Update.
7700         (struct salpy_sal_object) <symtab>: Now a PyObject.
7701         (salpy_dealloc): Update.
7702         (del_objfile_sal): Use gdbpy_ref.
7703
7704 2019-01-03  Tom Tromey  <tom@tromey.com>
7705
7706         * python/py-type.c (convert_field): Use new_reference.  Return
7707         gdbpy_ref.
7708         (make_fielditem): Return gdbpy_ref.
7709         (typy_fields): Update.
7710         (typy_getitem): Update.
7711         (field_name): Return gdbpy_ref.  Use new_reference.
7712         (typy_iterator_iternext): Update.
7713
7714 2019-01-03  Tom Tromey  <tom@tromey.com>
7715
7716         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7717
7718 2019-01-03  Tom Tromey  <tom@tromey.com>
7719
7720         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7721         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7722         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7723         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7724         (pspy_set_type_printers): Likewise.
7725         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7726         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7727         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7728         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7729         (objfpy_set_type_printers): Likewise.
7730
7731 2019-01-03  Tom Tromey  <tom@tromey.com>
7732
7733         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7734         (gdbpy_print_stack): Use gdbpy_err_fetch.
7735         * python/python-internal.h (class gdbpy_err_fetch): New class.
7736         (class gdbpy_enter) <m_error_type, m_error_value,
7737         m_error_traceback>: Remove.
7738         <m_error>: New member.
7739         (gdbpy_exception_to_string): Don't declare.
7740         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7741         * python/py-value.c (convert_value_from_python): Use
7742         gdbpy_err_fetch.
7743         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7744         gdbpy_exception_to_string.
7745         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7746         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7747         gdbpy_err_fetch.
7748
7749 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * linux-nat.c (delete_lwp_cleanup): Delete.
7752         (struct lwp_deleter): New struct.
7753         (lwp_info_up): New typedef.
7754         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7755         lwp_info_up.
7756
7757 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7758
7759         * linux-fork.c (class scoped_switch_fork_info): New class.
7760         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7761
7762 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * valops.c (find_overload_match): Remove use of null_cleanup, and
7765         calls to do_cleanups.
7766
7767 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * compile/compile-cplus-types.c
7770         (compile_cplus_instance::decl_name): Handle changes to
7771         cp_func_name.
7772         * cp-support.c (cp_func_name): Update header comment, update
7773         return type.
7774         * cp-support.h (cp_func_name): Update return type in declaration.
7775         * valops.c (find_overload_match): Move temp_func local to top
7776         level of function and change its type.  Use temp_func to hold and
7777         delete temporary string obtained from cp_func_name.
7778
7779 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7782         gdb::char_vector, remove cleanup, and update uses of `msg`.
7783
7784 2019-01-03  Jim Wilson  <jimw@sifive.com>
7785
7786         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7787
7788 2019-01-02  Tom Tromey  <tom@tromey.com>
7789
7790         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7791         (tdesc_parse_xml): Remove cleanups.
7792         * target-descriptions.h (make_cleanup_free_target_description):
7793         Don't declare.
7794         (target_desc_deleter): New struct.
7795         (target_desc_up): New typedef.
7796         * target-descriptions.c (target_desc_deleter::operator()): Rename
7797         from free_target_description.
7798         (make_cleanup_free_target_description): Remove.
7799
7800 2019-01-02  Tom Tromey  <tom@tromey.com>
7801
7802         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7803         constructor, destructor.
7804         (linespec_parser): Remove typedef.
7805         (~linespec_parser): Rename from linespec_parser_delete.
7806         (linespec_lex_to_end, linespec_complete_label)
7807         (linespec_complete): Update.
7808         (decode_line_full): Remove cleanups.
7809         (decode_line_1): Update.
7810
7811 2019-01-02  Tom Tromey  <tom@tromey.com>
7812
7813         * python/python-internal.h (inferior_to_inferior_object): Change
7814         return type.
7815         * python/py-exitedevent.c (create_exited_event_object): Update.
7816         * python/py-inferior.c (inferior_to_inferior_object): Return
7817         gdbpy_ref.
7818         (python_new_inferior, python_inferior_deleted)
7819         (thread_to_thread_object, delete_thread_object)
7820         (build_inferior_list, gdbpy_selected_inferior): Update.
7821         * python/py-infthread.c (create_thread_object): Update.  Also fail
7822         if inferior_to_inferior_object fails.
7823
7824 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7825
7826         * inferior.h (class inferior) <displaced_step_state>: New field.
7827         * infrun.h (struct displaced_step_state): Move here from
7828         infrun.c.  Initialize fields, add constructor.
7829         <inf>: Remove field.
7830         <reset>: New method.
7831         * infrun.c (struct displaced_step_inferior_state): Move to
7832         infrun.h.
7833         (displaced_step_inferior_states): Remove.
7834         (get_displaced_stepping_state): Adust.
7835         (displaced_step_in_progress_any_inferior): Adjust.
7836         (displaced_step_in_progress_thread): Adjust.
7837         (displaced_step_in_progress): Adjust.
7838         (add_displaced_stepping_state): Remove.
7839         (get_displaced_step_closure_by_addr): Adjust.
7840         (remove_displaced_stepping_state): Remove.
7841         (infrun_inferior_exit): Call displaced_step_state.reset.
7842         (use_displaced_stepping): Don't check for NULL.
7843         (displaced_step_prepare_throw): Call
7844         get_displaced_stepping_state.
7845         (displaced_step_fixup): Don't check for NULL.
7846         (prepare_for_detach): Don't check for NULL.
7847
7848 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7849
7850         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7851          in case of call that did not complete.
7852
7853 2019-01-02  Andrey Utkin  <autkin@undo.io>
7854
7855         * symfile.c (find_separate_debug_file): Fix search of debug files for
7856         remote debuggee.
7857
7858 2019-01-02  Tom Tromey  <tom@tromey.com>
7859
7860         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7861         indentation.
7862         * python/py-frame.c (frapy_older): Remove cast.
7863         (frapy_newer): Likewise.
7864         * python/py-breakpoint.c (local_setattro): Remove cast.
7865         * python/py-arch.c (archpy_name): Remove local variable.
7866         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7867
7868 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7869
7870         * unittests/basic_string_view/element_access/char/empty.cc:
7871         Fix year range in copyright header.
7872
7873 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7876         Delete.
7877         <operator==>: Update with for removed field.
7878         <hash>: Likewise.
7879         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7880         <isa_features>: ...this.
7881         <abi_features>: New field.
7882         (riscv_isa_flen): Update comment.
7883         (riscv_abi_xlen): New declaration.
7884         (riscv_abi_flen): New declaration.
7885         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7886         isa_features.
7887         (riscv_abi_xlen): New function.
7888         (riscv_isa_flen): Update to get answer from isa_features.
7889         (riscv_abi_flen): New function.
7890         (riscv_has_fp_abi): Update to get answer from abi_features.
7891         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7892         xlen and flen.
7893         (riscv_call_info) <xlen, flen>: Update comment.
7894         (riscv_call_arg_struct): Remove invalid assertions
7895         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7896         is removed.
7897         (riscv_gdbarch_init): Gather isa features and abi features
7898         separately, ensure both match on the gdbarch when reusing an old
7899         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7900         a target with 64-bit float hardware.
7901
7902 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7903
7904         * source.c (search_command_helper): Stop reverse search
7905         when line 1 has been searched.
7906
7907 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7908
7909         * record-full.c (record_full_base_target::close): Rewrite
7910         record_full_core_buf_list free logic.
7911
7912 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7913
7914         * break-catch-syscall.c (print_one_catch_syscall): xfree
7915         the last text.
7916
7917 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7918
7919         * top.c (print_gdb_version): Update Copyright year in version
7920         message.
7921
7922 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7923
7924         Update copyright year range in all GDB files.
7925
7926 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7927
7928         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7929
7930 For older changes see ChangeLog-2018.
7931 \f
7932 Local Variables:
7933 mode: change-log
7934 left-margin: 8
7935 fill-column: 74
7936 version-control: never
7937 coding: utf-8
7938 End:
7939