gdb/ChangeLog

   1 2019-10-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
   4
   5 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
   6
   7         * gdbtypes.c (overload_debug): Move comment to header.
   8         * gdbtypes.h (overload_debug): Declare.
   9         * valops.c: Remove declaration of overload_debug, instead
  10         include gdbtypes.h.
  11
  12 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * language.c (show_language_command): Pass lang_frame_mismatch_warn
  15         through _().
  16         (lang_frame_mismatch_warn): Make const, mark with N_(), and
  17         move comment...
  18         * language.h (lang_frame_mismatch_warn): ... here. Also add
  19         declaration.
  20         * top.c (lang_frame_mismatch_warn): Remove declaration.
  21         (check_frame_language_change): Pass lang_frame_mismatch_warn
  22         through _().
  23
  24 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * c-lang.h (vtbl_ptr_name): Declare.
  27         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
  28         it from the header.
  29         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
  30
  31 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
  34         gdb_static_assert.
  35
  36 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  37
  38         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
  39         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
  40         * ctfread.c: New file.
  41         * ctfread.h: New file.
  42         * elfread.c: Include ctfread.h.
  43         (struct elfinfo text_p): New member ctfsect.
  44         (elf_locate_sections): Mark CTF section.
  45         (elf_symfile_read): Call elfctf_build_psymtabs.
  46         * Makefile.in (LIBCTF): Add.
  47         (CLIBS): Use it.
  48         (CDEPS): Likewise.
  49         (DIST): Add ctfread.c.
  50
  51 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * ctfread.c (struct nextfield): Renamed to ...
  54         (struct ctf_nextfield): ... this.
  55         (struct field_info): Renamed to ...
  56         (strut ctf_field_info): ... this.
  57         (attach_fields_to_type): Update for renamed structures.
  58         (ctf_add_member_cb): Likewise.
  59         (ctf_add_enum_member_cb): Likewise.
  60         (process_struct_members): Likewise.
  61         (process_enum_type): Likewise.
  62
  63 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  64
  65         * tracectf.h: Rename, was ctf.h.
  66         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
  67         * tracefile.c: Likewise.
  68         * tracepoint.c: Remove unused include ctf.h.
  69         * mi/mi-main.c: Likewise.
  70         * Makefile.in Replace ctf.c with tracectf.c.
  71
  72 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
  73
  74         * version.in: Change version number to "9.0.50.DATE-git".
  75
  76 2019-10-03  Tom Tromey  <tom@tromey.com>
  77
  78         PR rust/24976:
  79         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
  80
  81 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
  84         cp_search_name_hash.
  85         * NEWS: Add entry about nested function support.
  86
  87 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
  88             Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
  91         for nested static variables when searchin VAR_DOMAIN.
  92         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
  93         global scope, update comment.
  94         (add_partial_subprogram): Call add_partial_subprogram recursively
  95         for nested subroutines when processinng Fortran.
  96         (load_partial_dies): Process the child entities of a subprogram
  97         when processing Fortran.
  98         (partial_die_parent_scope): Handle building scope
  99         for Fortran nested functions.
 100         (process_die): Record that nested functions have a scope.
 101         (new_symbol): Always record Fortran subprograms on the global
 102         symbol list.
 103         (determine_prefix): How to build the prefix for Fortran
 104         subprograms.
 105
 106 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 107
 108         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 109         have just sent the thread a SIGSTOP and are waiting for it to
 110         arrive.
 111
 112 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * btrace.c (btrace_add_pc): Remove whitespace before the template
 115         parameter in 'std::vector <...>'.
 116         (parse_xml_btrace_block): Likewise.
 117         (btrace_maint_decode_pt): Likewise.
 118         (btrace_maint_update_packets): Likewise.
 119         (btrace_maint_print_packets): Likewise.
 120         * btrace.h (struct btrace_maint_info): Likewise.
 121         * dwarf2read.c (struct type_unit_group): Likewise.
 122         (build_type_psymtabs_reader): Likewise.
 123         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 124         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 125         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 126
 127 2019-10-03  Tom de Vries  <tdevries@suse.de>
 128
 129         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 130         the first line of the help text for set/show style metadata.
 131
 132 2019-10-02  Tom Tromey  <tromey@adacore.com>
 133
 134         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 135         * gdbsupport/common-inferior.c: New file.
 136         * infcmd.c (startup_with_shell): Don't define.
 137         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 138         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 139         * inferior.h (startup_with_shell): Don't declare.
 140
 141 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 142
 143         * gdbsupport/gdb_assert.h: Include errors.h.
 144         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 145
 146 2019-10-02  Tom Tromey  <tromey@adacore.com>
 147
 148         * NEWS: Add $_ada_exception entry.
 149         * ada-lang.c (struct ada_catchpoint): Add constructor.
 150         <m_kind>: New member.
 151         (allocate_location_exception, re_set_exception): Remove
 152         "ex" parameter.
 153         (should_stop_exception): Compute $_ada_exception.
 154         (check_status_exception, print_it_exception)
 155         (print_one_exception, print_mention_exception): Remove
 156         "ex" parameter.
 157         (allocate_location_catch_exception, re_set_catch_exception)
 158         (check_status_exception, print_it_catch_exception)
 159         (print_one_catch_exception, print_mention_catch_exception)
 160         (print_recreate_catch_exception)
 161         (allocate_location_catch_exception_unhandled)
 162         (re_set_catch_exception_unhandled)
 163         (check_status_exception, print_it_catch_exception_unhandled)
 164         (print_one_catch_exception_unhandled)
 165         (print_mention_catch_exception_unhandled)
 166         (print_recreate_catch_exception_unhandled)
 167         (allocate_location_catch_assert, re_set_catch_assert)
 168         (check_status_assert, print_it_catch_assert)
 169         (print_one_catch_assert, print_mention_catch_assert)
 170         (print_recreate_catch_assert)
 171         (allocate_location_catch_handlers, re_set_catch_handlers)
 172         (check_status_handlers, print_it_catch_handlers)
 173         (print_one_catch_handlers, print_mention_catch_handlers)
 174         (print_recreate_catch_handlers): Remove.
 175         (create_ada_exception_catchpoint): Update.
 176         (initialize_ada_catchpoint_ops): Update.
 177
 178 2019-10-02  Tom Tromey  <tromey@adacore.com>
 179
 180         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 181         (create_excep_cond_exprs): Simplify exception string computation.
 182         (ada_exception_catchpoint_cond_string): Likewise.
 183
 184 2019-10-02  Tom Tromey  <tromey@adacore.com>
 185
 186         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 187         * ada-lang.c (lesseq_defined_than): Handle
 188         LOC_STATIC.
 189         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 190         parameter.
 191         (dwarf2_has_info): Likewise.
 192         (new_symbol): Set maybe_copied on symbol when
 193         appropriate.
 194         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 195         parameter.
 196         <can_copy>: New member.
 197         * elfread.c (record_minimal_symbol): Set maybe_copied
 198         on symbol when appropriate.
 199         (elf_symfile_read): Update call to dwarf2_has_info.
 200         * minsyms.c (lookup_minimal_symbol_linkage): New
 201         function.
 202         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 203         * symtab.c (get_symbol_address, get_msymbol_address):
 204         New functions.
 205         * symtab.h (get_symbol_address, get_msymbol_address):
 206         Declare.
 207         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 208         maybe_copied.
 209         (struct symbol, struct minimal_symbol) <maybe_copied>:
 210         New member.
 211
 212 2019-10-02  Tom Tromey  <tromey@adacore.com>
 213
 214         * source.c (struct current_source_location): New.
 215         (current_source_key): New global.
 216         (current_source_symtab, current_source_line)
 217         (current_source_pspace): Remove.
 218         (get_source_location): New function.
 219         (get_current_source_symtab_and_line)
 220         (set_default_source_symtab_and_line)
 221         (set_current_source_symtab_and_line)
 222         (clear_current_source_symtab_and_line, select_source_symtab)
 223         (info_source_command, print_source_lines_base)
 224         (info_line_command, search_command_helper, _initialize_source):
 225         Update.
 226
 227 2019-10-02  Tom Tromey  <tromey@adacore.com>
 228
 229         * source.c (select_source_symtab): Don't call
 230         decode_line_with_current_source.
 231
 232 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * symtab.c (lookup_global_symbol): Search global block.
 235
 236 2019-10-02  Tom Tromey  <tromey@adacore.com>
 237
 238         * coffread.c (process_coff_symbol): Update.
 239         * dwarf2read.c (var_decode_location, new_symbol): Update.
 240         * mdebugread.c (parse_symbol): Update.
 241         * objfiles.c (relocate_one_symbol): Update.
 242         * stabsread.c (define_symbol, fix_common_block)
 243         (scan_file_globals): Update.
 244         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 245         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 246         * xcoffread.c (process_xcoff_symbol): Update.
 247
 248 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 249
 250         * MAINTAINERS: Update my email address.
 251
 252 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 253
 254         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 255         std::vector.
 256         (build_type_psymtabs_reader): Update for std::vector.
 257         (build_type_psymtab_dependencies): Likewise.
 258         * dwarf2read.h: Remove use of DEF_VEC_P.
 259         (typedef sig_type_ptr): Delete.
 260
 261 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 262
 263         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 264         to std::vector.
 265         (btrace_maint_decode_pt): Likewise, and move allocation of the
 266         vector outside of the loop.
 267         (btrace_maint_update_packets): Update to handle change from VEC to
 268         std::vector.
 269         (btrace_maint_print_packets): Likewise.
 270         (maint_info_btrace_cmd): Likewise.
 271         * btrace.h: Remove use of DEF_VEC_O.
 272         (typedef btrace_pt_packet_s): Delete.
 273         (struct btrace_maint_info) <packets>: Change fromm VEC to
 274         std::vector.
 275         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 276
 277 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 280         make accesses into the vector constant references.
 281         (btrace_add_pc): Update for std::vector.
 282         (btrace_stitch_bts): Likewise.
 283         (parse_xml_btrace_block): Likewise.
 284         (btrace_maint_update_packets): Likewise.
 285         (btrace_maint_print_packets): Likewise.
 286         (maint_info_btrace_cmd): Likewise.
 287         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 288         std::vector.
 289         (btrace_data::empty): Likewise.
 290         (btrace_data_append): Likewise.
 291         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 292         (typedef btrace_block_s): Delete.
 293         (struct btrace_block): Add constructor.
 294         (struct btrace_data_bts) <blocks>: Change to std::vector.
 295         * nat/linux-btrace.c (perf_event_read_bts): Update for
 296         std::vector.
 297         (linux_read_bts): Likewise.
 298
 299 2019-10-01  Tom Tromey  <tom@tromey.com>
 300
 301         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 302
 303 2019-10-01  Tom Tromey  <tom@tromey.com>
 304
 305         * stack.c (print_frame, info_frame_command_core): Use
 306         styled_string.
 307         * linux-thread-db.c (try_thread_db_load_1)
 308         (try_thread_db_load_from_pdir_1): Use styled_string.
 309         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 310         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 311         (maybe_print_unsupported_script_warning)
 312         (maybe_print_script_not_found_warning): Use styled_string.
 313         * ada-lang.c (user_select_syms): Use styled_string.
 314
 315 2019-10-01  Tom Tromey  <tom@tromey.com>
 316
 317         * p-lang.c (pascal_printstr): Use metadata style.
 318         * value.c (show_convenience): Use metadata style.
 319         * valprint.c (valprint_check_validity, val_print_optimized_out)
 320         (val_print_not_saved, val_print_unavailable)
 321         (val_print_invalid_address, generic_val_print, val_print)
 322         (value_check_printable, val_print_array_elements): Use metadata
 323         style.
 324         * ui-out.h (class ui_out) <field_fmt>: New overload.
 325         <do_field_fmt>: Add style parameter.
 326         * ui-out.c (ui_out::field_fmt): New overload.
 327         * typeprint.c (type_print_unknown_return_type)
 328         (val_print_not_allocated, val_print_not_associated): Use metadata
 329         style.
 330         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 331         parameter.
 332         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 333         * tracepoint.c (tvariables_info_1): Use metadata style.
 334         * stack.c (print_frame_arg, print_frame_info, print_frame)
 335         (info_frame_command_core): Use metadata style.
 336         * skip.c (info_skip_command): Use metadata style.
 337         * rust-lang.c (rust_print_enum): Use metadata style.
 338         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 339         metadata style.
 340         * python/py-framefilter.c (py_print_single_arg): Use metadata
 341         style.
 342         * printcmd.c (do_one_display, print_variable_and_value): Use
 343         metadata style.
 344         * p-valprint.c (pascal_val_print)
 345         (pascal_object_print_value_fields): Use metadata style.
 346         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 347         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 348         parameter.
 349         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 350         * m2-valprint.c (m2_print_long_set): Use metadata style.
 351         * m2-typeprint.c (m2_print_type): Use metadata style.
 352         * infcmd.c (print_return_value_1): Use metadata style.
 353         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 354         * f-valprint.c (info_common_command_for_block): Use metadata
 355         style.
 356         * f-typeprint.c (f_type_print_base): Use metadata style.
 357         * expprint.c (print_subexp_standard): Use metadata style.
 358         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 359         * cli/cli-style.h (class cli_style_option): Add constructor.
 360         (metadata_style): Declare.
 361         * cli/cli-style.c (metadata_style): New global.
 362         (_initialize_cli_style): Register metadata style.
 363         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 364         parameter.
 365         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 366         * c-typeprint.c (c_type_print_base_struct_union)
 367         (c_type_print_base_1): Use metadata style.
 368         * breakpoint.c (watchpoint_value_print)
 369         (print_one_breakpoint_location): Use metadata style.
 370         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 371         style.
 372         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 373         style.
 374         * ada-valprint.c (val_print_packed_array_elements, printstr)
 375         (print_field_values, ada_val_print_ref, ada_val_print): Use
 376         metadata style.
 377         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 378         style.
 379         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 380         style.
 381         * ada-lang.c (user_select_syms): Use metadata style.
 382
 383 2019-10-01  Tom Tromey  <tom@tromey.com>
 384
 385         * cli/cli-cmds.c (pwd_command): Style output.
 386
 387 2019-10-01  Pedro Alves  <palves@redhat.com>
 388             Tom Tromey  <tom@tromey.com>
 389
 390         * symtab.c (print_symbol_info): Use %ps.
 391         (print_msymbol_info): Use %ps.
 392         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 393         * printcmd.c (print_variable_and_value): Use %ps.
 394         * macrocmd.c (show_pp_source_pos): Use %ps.
 395         * infrun.c (print_exited_reason): Use ui_out::message.
 396         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 397         (describe_other_breakpoints): Use ui_out::message and new
 398         formats.
 399         (say_where): Use new formats.
 400         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 401         and new formats.
 402
 403 2019-10-01  Pedro Alves  <palves@redhat.com>
 404             Tom Tromey  <tom@tromey.com>
 405
 406         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 407         (test_gdb_formats): New function.
 408         (run_tests): Call it.
 409         (test_format_specifier): Update.
 410         * utils.h (fputs_filtered): Update comment.
 411         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 412         (fputs_styled_unfiltered): Declare.
 413         * utils.c (fputs_styled_unfiltered): New function.
 414         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 415         (vfprintf_filtered): Update.
 416         (vfprintf_unfiltered, vprintf_filtered): Update.
 417         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 418         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 419         disallow_ui_out_field>: New constants.
 420         (enum class field_kind): New.
 421         (struct base_field_s, struct signed_field_s): New.
 422         (signed_field): New function.
 423         (struct string_field_s): New.
 424         (string_field): New function.
 425         (struct styled_string_s): New.
 426         (styled_string): New function.
 427         (class ui_out) <message>: Add comment.
 428         <vmessage, call_do_message>: New methods.
 429         <do_message>: Add style parameter.
 430         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 431         methods.
 432         (ui_out::message): Rewrite.
 433         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 434         parameter.
 435         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 436         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 437         gdb_extensions parameter.
 438         (class format_piece): Add parameter to constructor.
 439         (n_int_args): New field.
 440         * gdbsupport/format.c (format_pieces::format_pieces): Add
 441         gdb_extensions parameter.  Handle '*'.
 442         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 443         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 444         vfprintf_styled_no_gdbfmt.
 445         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 446         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 447         unfiltered output.
 448         * ui-style.h (struct ui_file_style) <ptr>: New method.
 449
 450 2019-10-01  Tom Tromey  <tom@tromey.com>
 451
 452         * unittests/format_pieces-selftests.c: Update.  Add final format.
 453         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 454         empty literal pieces.
 455
 456 2019-10-01  Tom Tromey  <tom@tromey.com>
 457
 458         * ui-out.h (enum class ui_out_style_kind): Remove.
 459         (class ui_out) <field_string, field_stsream, do_field_string>:
 460         Change type of "style".
 461         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 462         (ui_out::field_string): Update.
 463         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 464         of "style".
 465         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 466         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 467         * stack.c (print_frame_arg, print_frame_info, print_frame):
 468         Update.
 469         * source.c (print_source_lines_base): Update.
 470         * solib.c (info_sharedlibrary_command): Update.
 471         * skip.c (info_skip_command): Update.
 472         * record-btrace.c (btrace_call_history_src_line)
 473         (btrace_call_history): Update.
 474         * python/py-framefilter.c (py_print_frame): Update.
 475         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 476         "style".
 477         * mi/mi-out.c (mi_ui_out::do_table_header)
 478         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 479         (mi_ui_out::do_field_string): Update.
 480         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 481         Update.
 482         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 483         "style".
 484         * cli-out.c (cli_ui_out::do_table_header)
 485         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 486         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 487         (cli_ui_out::do_field_fmt): Update.
 488         * breakpoint.c (print_breakpoint_location): Update.
 489         (update_static_tracepoint): Update.
 490
 491 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 492
 493         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 494         conversion of gdb_datadir.
 495         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 496         remove not needed c_str ().
 497
 498 2019-09-30  Ali Tamur <tamur@google.com>
 499
 500         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 501         (dwarf2_string_attr): Likewise.
 502
 503 2019-09-30  Ali Tamur <tamur@google.com>
 504
 505         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 506         (process_full_type_unit): Likewise.
 507         (dump_die_shallow): Likewise.
 508         (cu_debug_loc_section): Likewise.
 509
 510 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 511
 512         * minsyms.c (compare_minimal_symbols): Rename to...
 513         (minimal_symbol_is_less_than): ...this, and adjust to STL
 514         conventions (return bool, take arguments as references)
 515         (minimal_symbol_reader::install): Call std::sort instead
 516         of qsort.
 517
 518 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 519
 520         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 521         hash and why.
 522         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 523         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 524
 525 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 526
 527         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 528         * psympriv.h (add_psymbol_to_list): Move comment here and update
 529         it.
 530
 531 2019-09-29  Tom de Vries  <tdevries@suse.de>
 532
 533         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 534         Use $tmpdir/$(basename "$output_file").dwz instead of
 535         "${output_file}.dwz".
 536
 537 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 538
 539         PR gdb/25045
 540         * hppa-linux-nat.c: Include gdbarch.h.
 541
 542 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 543
 544         * blockframe.c (find_pc_partial_function): Change return type to bool.
 545         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 546         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 547         (stub_gnu_ifunc_resolve_name): Likewise.
 548         * symtab.c (compare_filenames_for_search): Likewise.
 549         (compare_glob_filenames_for_search): Likewise.
 550         (matching_obj_sections): Likewise.
 551         (symbol_matches_domain): Likewise.
 552         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 553         (find_line_pc): Change return type to bool.
 554         (find_line_pc_range): Likewise.
 555         (producer_is_realview): Likewise.
 556         * symtab.h (symbol_matches_domain): Likewise.
 557         (find_pc_partial_function): Likewise.
 558         (find_pc_line_pc_range): Likewise.
 559         (in_gnu_ifunc_stub): Likewise.
 560         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 561         (find_line_pc): Likewise.
 562         (find_line_pc_range): Likewise.
 563         (matching_obj_sections): Likewise.
 564         (find_line_symtab): Change out parameter to bool.
 565         (producer_is_realview): Change return type to bool.
 566         (compare_filenames_for_search): Likewise.
 567         (compare_glob_filenames_for_search): Likewise.
 568
 569 2019-09-26  Tom Tromey  <tom@tromey.com>
 570
 571         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 572         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 573         * gdb_usleep.h: Remove.
 574         * gdb_usleep.c: Remove.
 575         * utils.c: Don't include gdb_usleep.h.
 576
 577 2019-09-26  Tom Tromey  <tromey@adacore.com>
 578
 579         * python/py-type.c (type_to_type_object): Call check_typedef
 580         for stub types.
 581
 582 2019-09-26  Tom Tromey  <tom@tromey.com>
 583
 584         * utils.h (initialize_utils): Don't declare.
 585         * top.c (gdb_init): Don't call initialize_utils.
 586         * utils.c (initialize_utils): Remove.  Move contents...
 587         (_initialize_utils): ... here.
 588
 589 2019-09-25  Tom Tromey  <tom@tromey.com>
 590
 591         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 592         * utils.h (make_hex_string): Don't declare.
 593         * utils.c (make_hex_string): Remove.
 594
 595 2019-09-24  Tom de Vries  <tdevries@suse.de>
 596
 597         PR gdb/23815
 598         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 599         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 600
 601 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 602
 603         * NEWS: Mention new simulator port for PRU.
 604
 605 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 606
 607         * ada-exp.y (write_object_remaining): Update.
 608         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 609         and eliminate the static buffer.
 610         (ada_decode_symbol): Update.
 611         (ada_la_decode): Update.
 612         (ada_sniff_from_mangled_name): Update.
 613         (is_valid_name_for_wild_match): Update.
 614         (ada_lookup_name_info::matches): Update and simplify.
 615         (name_matches_regex): Update.
 616         (ada_add_global_exceptions): Update.
 617         * ada-lang.h (ada_decode): Update signature.
 618         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 619         * dwarf-index-write.c (debug_names::insert): Update.
 620
 621 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 622
 623         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 624         formatting.
 625
 626 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 627
 628         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 629         Change "nonzero" to "true" in documentation.
 630
 631 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 632
 633         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 634         (_initialize_darwin_solib): Don't set
 635         darwin_so_ops.lookup_lib_global_symbol.
 636         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 637         set_gdbarch_iterate_over_objfiles_in_search_order.
 638         (elf_lookup_lib_symbol): Rename to...
 639         (svr4_iterate_over_objfiles_in_search_order): this, and update
 640         to iterate semantics.
 641         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 642         * solib.c (solib_global_lookup): Remove.
 643         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 644         (solib_global_lookup): Remove.
 645         * symtab.c (lookup_global_or_static_symbol): Remove call to
 646         solib_global_lookup.
 647
 648 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 649
 650         * NEWS: Move entries about default MI version now being
 651         version 3, and about the GDB/MI fix for multi-location
 652         breakpoints to the "since GDB 8.3" section.
 653
 654 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 655
 656         GDB 8.3.1 released.
 657
 658 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 659
 660         * NEWS: Mention that Cell/B.E. debugging support was removed.
 661         * MAINTAINERS: Remove spu target.
 662
 663         * config/djgpp/fnchange.lst: Remove entries for removed files.
 664
 665         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 666         spu-multiarch.o, and spu-tdep.o.
 667         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 668         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 669         spu-multiarch.c, and spu-tdep.c.
 670         * spu-linux-nat.c: Remove file.
 671         * spu-multiarch.c: Remove file.
 672         * spu-tdep.c: Remove file.
 673         * spu-tdep.h: Remove file.
 674         * solib-spu.c: Remove file.
 675         * solib-spu.h: Remove file.
 676
 677         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 678         * configure.nat (spu-linux): Remove.
 679         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 680         solib-multiarch.o from gdb_target_obs.
 681         (spu*-*-*): Remove.
 682
 683         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 684         feature flag.
 685         (ppc_linux_no_features): Update.
 686         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 687         Cell/B.E. support.
 688         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 689         (tdesc_powerpc_cell64l): Likewise.
 690         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 691         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 692         Cell/B.E. support.
 693         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 694         Do not include "features/rs6000/powerpc-cell32l.c" or
 695         "features/rs6000/powerpc-cell64l.c".
 696         (ppc_linux_spu_section): Remove.
 697         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 698         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 699         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 700         (ppc_linux_spe_context_lookup): Remove.
 701         (ppc_linux_spe_context_inferior_created): Remove.
 702         (ppc_linux_spe_context_solib_loaded): Remove.
 703         (ppc_linux_spe_context_solib_unloaded): Remove.
 704         (ppc_linux_spe_context): Remove.
 705         (struct ppu2spu_cache): Remove.
 706         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 707         (struct ppu2spu_data): Remove.
 708         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 709         ppu2spu_unwind): Remove.
 710         (ppc_linux_init_abi): Remove Cell/B.E. support.
 711         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 712
 713         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 714         (rs6000/powerpc-cell64l-expedite): Likewise
 715         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 716         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 717         rs6000/powerpc-cell64l.xml.
 718         * features/rs6000/powerpc-cell32l.xml: Remove.
 719         * features/rs6000/powerpc-cell64l.xml: Likewise.
 720         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 721         * features/rs6000/powerpc-cell64l.c: Likewise.
 722         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 723         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 724         * regformats/reg-spu.dat: Remove.
 725
 726         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 727         * corelow.c (struct spuid_list): Remove.
 728         (add_to_spuid_list): Remove.
 729         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 730         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 731         (remote_protocol_features): Remove associated entries.
 732         (_initialize_remote): No longer initialize them.
 733         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 734         * linux-nat.c (SPUFS_MAGIC): Remove.
 735         (linux_proc_xfer_spu): Remove.
 736         (spu_enumerate_spu_ids): Remove.
 737         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 738         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 739         (linux_make_corefile_notes): No longer call it.
 740
 741         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 742         (cooked_write_test): Likewise.
 743
 744 2019-09-20  Tom Tromey  <tom@tromey.com>
 745
 746         * NEWS: Mention case-sensitivity of TUI commands.
 747         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 748         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 749         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 750
 751 2019-09-20  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-source.c (tui_source_window::set_contents): Use
 754         make_unique_xstrdup.
 755         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 756         make_unique_xstrdup.
 757
 758 2019-09-20  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-data.c: Remove separator comments.
 761         * tui/tui-layout.c: Remove separator comments.
 762         * tui/tui-win.c: Remove separator comments.
 763         * tui/tui-wingeneral.c: Remove separator comments.
 764
 765 2019-09-20  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui.h (strcat_to_buf): Don't declare.
 768         * tui/tui.c (strcat_to_buf): Remove.
 769
 770 2019-09-20  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 773         from "fullname".
 774         * tui/tui-source.c (tui_source_window::set_contents)
 775         (tui_source_window::location_matches_p)
 776         (tui_source_window::maybe_update): Update.
 777
 778 2019-09-20  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 781         Update.
 782         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 783         prefix.
 784         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 785         (tui_data_window::line_from_reg_element_no)
 786         (tui_data_window::first_reg_element_no_inline)
 787         (tui_data_window::show_registers)
 788         (tui_data_window::show_register_group)
 789         (tui_data_window::display_registers_from)
 790         (tui_data_window::display_registers_from_line)
 791         (tui_data_window::first_data_item_displayed)
 792         (tui_data_window::delete_data_content_windows)
 793         (tui_data_window::erase_data_content)
 794         (tui_data_window::do_scroll_vertical)
 795         (tui_data_window::refresh_window)
 796         (tui_data_window::check_register_values): Update.
 797
 798 2019-09-20  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 801         (struct tui_locator_window) <full_name, proc_name>: Now
 802         std::string.
 803         * tui/tui-stack.c (tui_locator_window::make_status_line)
 804         (tui_locator_window::set_locator_fullname)
 805         (tui_locator_window::set_locator_info): Update.
 806         * tui/tui-source.c (tui_source_window::set_contents)
 807         (tui_source_window::showing_source_p): Update.
 808
 809 2019-09-20  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 812         Don't call tui_locator_win_info_ptr.
 813
 814 2019-09-20  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 817
 818 2019-09-20  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 821         height for locator.
 822         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 823         * tui/tui-layout.c (show_source_disasm_command, show_data)
 824         (show_source_or_disasm_and_command): Use 1 as height for locator.
 825
 826 2019-09-20  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui.c (tui_enable): Update.
 829         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 830         Update.
 831         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 832         Update.
 833         * tui/tui-data.c (win_resized): Now bool.
 834         (tui_win_resized): Return bool.
 835         (tui_set_win_resized_to): Accept a bool.
 836
 837 2019-09-20  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 840         Change type of "refresh_values_only".
 841         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 842         type of "refresh_values_only".
 843
 844 2019-09-20  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 847         std::string.
 848         (tui_disassemble): Add "pos" parameter.
 849         (tui_disasm_window::set_contents): Simplify.
 850
 851 2019-09-20  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.h (struct tui_source_window_base)
 854         <show_source_content>: Now private.
 855         * tui/tui-winsource.c
 856         (tui_source_window_base::show_source_content): Don't handle empty
 857         content case.
 858
 859 2019-09-20  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-layout.c (show_source_disasm_command)
 862         (show_source_or_disasm_and_command): Don't call
 863         show_source_content.
 864
 865 2019-09-20  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 868         Declare.
 869         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 870         from tui_make_status_line.
 871         (tui_locator_window::rerender): Update.
 872
 873 2019-09-20  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 876         (tui_locator_window::rerender): Update.
 877
 878 2019-09-20  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-winsource.h (struct tui_source_window_base)
 881         <~tui_source_window_base>: Don't declare.
 882         <fullname>: Remove.
 883         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 884         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 885         member.
 886         * tui/tui-source.c (tui_source_window::set_contents): Update.
 887         (tui_source_window::location_matches_p)
 888         (tui_source_window::maybe_update): Update.
 889
 890 2019-09-20  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-winsource.h (~tui_source_element): Remove.
 893         (tui_source_element): Update.
 894         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 895         * tui/tui-winsource.c (tui_show_source_line): Update.
 896         * tui/tui-source.c (tui_source_window::set_contents): Update.
 897         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 898
 899 2019-09-20  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 902         declare.
 903         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 904         tui_clear_source_windows_detail.
 905         * tui/tui-winsource.h (struct tui_source_window_base)
 906         <clear_detail>: Don't declare.
 907         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 908         Remove.
 909         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 910
 911 2019-09-20  Tom Tromey  <tromey@adacore.com>
 912
 913         PR ada/24919:
 914         * block.c (contained_in): Fix final return value.
 915
 916 2019-09-20  Alan Modra  <amodra@gmail.com>
 917
 918         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 919         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 920         (read_indirect_string_from_dwz): Use bfd accessor.
 921         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 922         * machoread.c (macho_symfile_read_all_oso): Likewise.
 923         * solib.c (solib_bfd_open): Likewise.
 924
 925 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 926
 927         * eval.c: Move declaration of overload_resolution to...
 928         * value.h: ...here.
 929
 930 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 931
 932         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 933         * arm-linux-tdep.c: Likewise.
 934         * arm-nbsd-nat.c: Likewise.
 935         * arm-tdep.h: Declare arm_apcs_32.
 936         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 937
 938 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 939
 940         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 941         * dwarf2read.h: Declare dwarf_always_disassemble.
 942
 943 2019-09-19  Tom de Vries  <tdevries@suse.de>
 944
 945         PR gdb/25009
 946         * source-cache.c (source_cache::ensure): Catch exception thrown during
 947         construction of the highlighter.
 948
 949 2019-09-18  Alan Modra  <amodra@gmail.com>
 950
 951         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 952         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 953         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 954         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 955         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 956         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 957         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 958         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 959         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 960         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 961         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 962         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 963         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 964         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 965         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 966         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 967         * mi/mi-interp.c: Update throughout for bfd section macro and
 968         function changes.
 969         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 970         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 971
 972 2019-09-18  Tom Tromey  <tom@tromey.com>
 973
 974         * NEWS: Add entry.
 975         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 976         call rl_initialize.
 977         (tui_enable): Do not call rl_initialize.
 978
 979 2019-09-18  Christian Groessler  <chris@groessler.org>
 980
 981         * alpha-linux-nat.c: Include gdbarch.h.
 982
 983 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 984
 985         * ui-file.c: Include cli/cli-style.h.
 986         (term_cli_styling): Remove cli_styling declaration.
 987
 988 2019-09-18  Alan Modra  <amodra@gmail.com>
 989
 990         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 991         to bfd_asymbol_section.
 992
 993 2019-09-18  Alan Modra  <amodra@gmail.com>
 994
 995         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 996         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 997         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 998
 999 2019-09-18  Alan Modra  <amodra@gmail.com>
1000
1001         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1002         * spu-linux-nat.c (spu_bfd_open): Likewise.
1003
1004 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1007         to bool to match definition in dwarf2read.c.
1008
1009 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1010
1011         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1012         (print_signatures): Likewise.
1013         (trust_pad_over_xvs): Likewise.
1014         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1015         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1016         * arm-linux-nat.c (arm_apcs_32): Likewise.
1017         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1018         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1019         * arm-tdep.c (arm_debug): Likewise.
1020         (arm_apcs_32): Likewise.
1021         * auto-load.c (debug_auto_load): Likewise.
1022         (auto_load_gdb_scripts): Likewise.
1023         (global_auto_load): Likewise.
1024         (auto_load_local_gdbinit): Likewise.
1025         (auto_load_local_gdbinit_loaded): Likewise.
1026         * auto-load.h (global_auto_load): Likewise.
1027         (auto_load_local_gdbinit): Likewise.
1028         (auto_load_local_gdbinit_loaded): Likewise.
1029         * breakpoint.c (disconnected_dprintf): Likewise.
1030         (breakpoint_proceeded): Likewise.
1031         (automatic_hardware_breakpoints): Likewise.
1032         (always_inserted_mode): Likewise.
1033         (target_exact_watchpoints): Likewise.
1034         (_initialize_breakpoint): Update.
1035         * breakpoint.h (target_exact_watchpoints): Change to bool.
1036         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1037         * cli/cli-cmds.c (trace_commands): Likewise.
1038         * cli/cli-cmds.h (trace_commands): Likewise.
1039         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1040         to bool*.
1041         * cli/cli-logging.c (logging_overwrite): Change to bool.
1042         (logging_redirect): Likewise.
1043         (debug_redirect): Likewise.
1044         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1045         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1046         to bool.
1047         <boolean_option_def>: Update.
1048         (struct flag_option_def): Change default type of Context to bool
1049         from int.
1050         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1051         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1052         (get_setshow_command_value_string): Likewise.
1053         * cli/cli-style.c (cli_styling): Change to bool.
1054         (source_styling): Likewise.
1055         * cli/cli-style.h (source_styling): Likewise.
1056         (cli_styling): Likewise.
1057         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1058         to bool.
1059         * command.h (var_types): Update comment.
1060         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1061         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1062         bool.
1063         (debug_compile_cplus_scopes): Likewise.
1064         * compile/compile-internal.h (compile_debug): Likewise.
1065         * compile/compile.c (compile_debug): Likewise.
1066         (struct compile_options) <raw>: Likewise.
1067         * cp-support.c (catch_demangler_crashes): Likewise.
1068         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1069         (usr_cmd_cris_dwarf2_cfi): Likewise.
1070         * csky-tdep.c (csky_debug): Likewise.
1071         * darwin-nat.c (enable_mach_exceptions): Likewise.
1072         * dcache.c (dcache_enabled_p): Likewise.
1073         * defs.h (info_verbose): Likewise.
1074         * demangle.c (demangle): Likewise.
1075         (asm_demangle): Likewise.
1076         * dwarf-index-cache.c (debug_index_cache): Likewise.
1077         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1078         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1079         * dwarf2read.c (check_physname): Likewise.
1080         (use_deprecated_index_sections): Likewise.
1081         (dwarf_always_disassemble): Likewise.
1082         * eval.c (overload_resolution): Likewise.
1083         * event-top.c (set_editing_cmd_var): Likewise.
1084         (exec_done_display_p): Likewise.
1085         * event-top.h (set_editing_cmd_var): Likewise.
1086         (exec_done_display_p): Likewise.
1087         * exec.c (write_files): Likewise.
1088         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1089         (debug_fbsd_nat): Likewise.
1090         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1091         Likewise.
1092         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1093         <backtrace_past_entry> Likewise.
1094         * gdb-demangle.h (demangle): Likewise.
1095         (asm_demangle): Likewise.
1096         * gdb_bfd.c (bfd_sharing): Likewise.
1097         * gdbcore.h (write_files): Likewise.
1098         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1099         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1100         * gdbthread.h (print_thread_events): Likewise.
1101         * gdbtypes.c (opaque_type_resolution): Likewise.
1102         (strict_type_checking): Likewise.
1103         * gnu-nat.c (gnu_debug_flag): Likewise.
1104         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1105         * guile/scm-param.c (pascm_variable): Add boolval.
1106         (add_setshow_generic): Update.
1107         (pascm_param_value): Update.
1108         (pascm_set_param_value_x): Update.
1109         * hppa-tdep.c (hppa_debug): Change to bool..
1110         * infcall.c (may_call_functions_p): Likewise.
1111         (coerce_float_to_double_p): Likewise.
1112         (unwind_on_signal_p): Likewise.
1113         (unwind_on_terminating_exception_p): Likewise.
1114         * infcmd.c (startup_with_shell): Likewise.
1115         * inferior.c (print_inferior_events): Likewise.
1116         * inferior.h (startup_with_shell): Likewise.
1117         (print_inferior_events): Likewise.
1118         * infrun.c (step_stop_if_no_debug): Likewise.
1119         (detach_fork): Likewise.
1120         (debug_displaced): Likewise.
1121         (disable_randomization): Likewise.
1122         (non_stop): Likewise.
1123         (non_stop_1): Likewise.
1124         (observer_mode): Likewise.
1125         (observer_mode_1): Likewise.
1126         (set_observer_mode): Update.
1127         (sched_multi): Change to bool.
1128         * infrun.h (debug_displaced): Likewise.
1129         (sched_multi): Likewise.
1130         (step_stop_if_no_debug): Likewise.
1131         (non_stop): Likewise.
1132         (disable_randomization): Likewise.
1133         * linux-tdep.c (use_coredump_filter): Likewise.
1134         (dump_excluded_mappings): Likewise.
1135         * linux-thread-db.c (auto_load_thread_db): Likewise.
1136         (check_thread_db_on_load): Likewise.
1137         * main.c (captured_main_1): Update.
1138         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1139         xx2_opt, boolean_opt>: Change to bool.
1140         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1141         * maint.c (maintenance_profile_p): Likewise.
1142         (per_command_time): Likewise.
1143         (per_command_space): Likewise.
1144         (per_command_symtab): Likewise.
1145         * memattr.c (inaccessible_by_default): Likewise.
1146         * mi/mi-main.c (mi_async): Likewise.
1147         (mi_async_1): Likewise.
1148         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1149         * nat/fork-inferior.h (startup_with_shell): Likewise.
1150         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1151         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1152         * nios2-tdep.c (nios2_debug): Likewise.
1153         * or1k-tdep.c (or1k_debug): Likewise.
1154         * parse.c (parser_debug): Likewise.
1155         * parser-defs.h (parser_debug): Likewise.
1156         * printcmd.c (print_symbol_filename): Likewise.
1157         * proc-api.c (procfs_trace): Likewise.
1158         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1159         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1160         (set_parameter_value): Update.
1161         (add_setshow_generic): Update.
1162         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1163         to bool*.
1164         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1165         int*.
1166         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1167         * record-btrace.c (record_btrace_target::store_registers): Update.
1168         * record-full.c (record_full_memory_query): Change to bool.
1169         (record_full_stop_at_limit): Likewise.
1170         * record-full.h (record_full_memory_query): Likewise.
1171         * remote-notif.c (notif_debug): Likewise.
1172         * remote-notif.h (notif_debug): Likewise.
1173         * remote.c (use_range_stepping): Likewise.
1174         (interrupt_on_connect): Likewise.
1175         (remote_break): Likewise.
1176         * ser-tcp.c (tcp_auto_retry): Likewise.
1177         * ser-unix.c (serial_hwflow): Likewise.
1178         * skip.c (debug_skip): Likewise.
1179         * solib-aix.c (solib_aix_debug): Likewise.
1180         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1181         (spu_auto_flush_cache_p): Likewise.
1182         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1183         Likewise.
1184         (struct info_print_options) <quiet>: Likewise.
1185         * symfile-debug.c (debug_symfile): Likewise.
1186         * symfile.c (auto_solib_add): Likewise.
1187         (separate_debug_file_debug): Likewise.
1188         * symfile.h (auto_solib_add): Likewise.
1189         (separate_debug_file_debug): Likewise.
1190         * symtab.c (basenames_may_differ): Likewise.
1191         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1192         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1193         (struct info_types_options) <quiet>: Likewise.
1194         * symtab.h (demangle): Likewise.
1195         (basenames_may_differ): Likewise.
1196         * target-dcache.c (stack_cache_enabled_1): Likewise.
1197         (code_cache_enabled_1): Likewise.
1198         * target.c (trust_readonly): Likewise.
1199         (may_write_registers): Likewise.
1200         (may_write_memory): Likewise.
1201         (may_insert_breakpoints): Likewise.
1202         (may_insert_tracepoints): Likewise.
1203         (may_insert_fast_tracepoints): Likewise.
1204         (may_stop): Likewise.
1205         (auto_connect_native_target): Likewise.
1206         (target_stop_and_wait): Update.
1207         (target_async_permitted): Change to bool.
1208         (target_async_permitted_1): Likewise.
1209         (may_write_registers_1): Likewise.
1210         (may_write_memory_1): Likewise.
1211         (may_insert_breakpoints_1): Likewise.
1212         (may_insert_tracepoints_1): Likewise.
1213         (may_insert_fast_tracepoints_1): Likewise.
1214         (may_stop_1): Likewise.
1215         * target.h (target_async_permitted): Likewise.
1216         (may_write_registers): Likewise.
1217         (may_write_memory): Likewise.
1218         (may_insert_breakpoints): Likewise.
1219         (may_insert_tracepoints): Likewise.
1220         (may_insert_fast_tracepoints): Likewise.
1221         (may_stop): Likewise.
1222         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1223         (make_thread_apply_all_options_def_group): Change argument from int*
1224         to bool*.
1225         (thread_apply_all_command): Update.
1226         (print_thread_events): Change to bool.
1227         * top.c (confirm): Likewise.
1228         (command_editing_p): Likewise.
1229         (history_expansion_p): Likewise.
1230         (write_history_p): Likewise.
1231         (info_verbose): Likewise.
1232         * top.h (confirm): Likewise.
1233         (history_expansion_p): Likewise.
1234         * tracepoint.c (disconnected_tracing): Likewise.
1235         (circular_trace_buffer): Likewise.
1236         * typeprint.c (print_methods): Likewise.
1237         (print_typedefs): Likewise.
1238         * utils.c (debug_timestamp): Likewise.
1239         (sevenbit_strings): Likewise.
1240         (pagination_enabled): Likewise.
1241         * utils.h (sevenbit_strings): Likewise.
1242         (pagination_enabled): Likewise.
1243         * valops.c (overload_resolution): Likewise.
1244         * valprint.h (struct value_print_options) <prettyformat_arrays,
1245         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1246         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1247         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1248         Likewise.
1249         * windows-nat.c (new_console): Likewise.
1250         (cygwin_exceptions): Likewise.
1251         (new_group): Likewise.
1252         (debug_exec): Likewise.
1253         (debug_events): Likewise.
1254         (debug_memory): Likewise.
1255         (debug_exceptions): Likewise.
1256         (useshell): Likewise.
1257         * windows-tdep.c (maint_display_all_tib): Likewise.
1258         * xml-support.c (debug_xml): Likewise.
1259
1260 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1261
1262         * source.c (prepare_path_for_appending): New function.
1263         (openp): Make use of new function.
1264         (find_and_open_source): Search for the compilation directory and
1265         source file as a relative path beneath the directory search path.
1266
1267 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * source-cache.c (source_cache::get_line_charpos): Catch
1270         exceptions and return false, this matches the behaviour documented
1271         in the header file.
1272
1273 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1274
1275         * ada-tasks.c (info_task): Remove quoting of the task's name.
1276
1277 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1278
1279         * symfile.c (auto_solib_add): Replace comment with a reference
1280         to the header file.
1281
1282 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1283
1284         * NEWS: Mention that gdb can now be compiled with Python 3
1285         on Windows.
1286
1287 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * maint.c (maint_print_section_data::maint_print_section_data):
1290         Force use of 'float log10 (float)' by casting the argument to
1291         float.
1292
1293 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * maint.c: Add 'cmath' include.
1296         (struct maint_print_section_data): New structure.
1297         (print_section_index): New function.
1298         (print_bfd_section_info): Add header comment, small whitespace
1299         cleanup, and update to call new print_section_index function.
1300         (print_objfile_section_info): Likewise.
1301         (maint_obj_section_from_bfd_section): New function.
1302         (print_bfd_section_info_maybe_relocated): New function.
1303         (maintenance_info_sections): Add header comment, always use
1304         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1305
1306 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1309         inner scope, add check that the objfile has psymtabs before
1310         checking psymtabs_addrmap.
1311         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1312
1313 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * NEWS: Announce that Ada task names are now shown at more places,
1316         and between quotes (except in info task output).
1317         * gdb/ada-tasks.c (task_to_str): New function.
1318         (display_current_task_id): Call task_to_str.
1319         (task_command_1): Likewise.
1320         (print_ada_task_info): In non-mi mode, Properly align headers and data
1321         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1322
1323 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1324
1325         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1326         prstatus.pr_lwp.pr_info instead of making it up.
1327
1328 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1329
1330         * auto-load.c (auto_load_expand_dir_vars): Update.
1331         * defs.h (gdb_datadir): Change to std::string.
1332         (python_libdir): Likewise.
1333         (relocate_gdb_directory): Change return type to std::string.
1334         * guile/guile.c (gdbscm_data_directory): Update.
1335         (initialize_scheme_side): Update.
1336         * jit.c (jit_reader_dir): Change to std::string.
1337         (jit_reader_load_command): Update.
1338         * main.c (gdb_datadir): Change to std::string.
1339         (python_libdir): Likewise.
1340         (set_gdb_data_directory): Update.
1341         (relocate_path): Change to return std::string.
1342         (relocate_gdb_directory): Change to return std::string.
1343         (relocate_gdbinit_path_maybe_in_datadir): Update.
1344         (captured_main_1): Update.
1345         * python/python.c (do_start_initialization): Update.
1346         * top.c (show_gdb_datadir): Update.
1347         * xml-syscall.c (xml_init_syscalls_info): Update.
1348         (init_syscalls_info): Update.
1349
1350 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1351
1352         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1353         out of get_init_files.
1354         (get_init_files): Update.
1355
1356 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1357
1358         * main.c (get_init_files): Change to use std::string.
1359         (captured_main_1): Update.
1360         (print_gdb_help): Update.
1361
1362 2019-09-11  Ali Tamur  <tamur@google.com>
1363
1364         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1365         implementation.
1366
1367 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1368
1369         * dbxread.c (read_dbx_symtab): Update.
1370         * dwarf2read.c (load_partial_dies): Update.
1371         * mdebugread.c (parse_partial_symbols): Update.
1372         (handle_psymbol_enumerators): Update.
1373         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1374         * psymtab.c (add_psymbol_to_bcache): Likewise.
1375         (add_psymbol_to_list): Likewise.
1376         * symtab.c (symbol_set_names): Likewise.
1377         * symtab.h (symbol_set_names): Likewise.
1378         * xcoffread.c (scan_xcoff_symtab): Update.
1379
1380 2019-09-11  Tom Tromey  <tom@tromey.com>
1381
1382         * symfile-mem.c (symbol_file_add_from_memory): Use
1383         bfd_set_filename.
1384         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1385         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1386
1387 2019-09-10  Tom Tromey  <tromey@adacore.com>
1388
1389         * dwarf-index-write.c (write_psymbols): Extend error message.
1390         (debug_names::insert): Add Ada code.
1391         (debug_names::write_psymbols): Remove Ada check.
1392         (debug_names) <m_string_obstack>: New member.
1393         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1394         (gdb_index_symbol_name_matcher::matches): Remove.
1395         (mapped_index_base::find_name_components_bounds): Add "lang"
1396         parameter.
1397         (mapped_index_base::build_name_components): Also split names
1398         according to Ada syntax.
1399         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1400         type of "match_callback".
1401         (check_match, check_find_bounds_finds)
1402         (dw2_expand_symtabs_matching): Update.
1403         (dw2_debug_names_iterator): Add new constructor.
1404         (dw2_debug_names_map_matching_symbols): New function.
1405         (dw2_debug_names_expand_symtabs_matching): Update.
1406         (dwarf2_debug_names_functions): Use
1407         dw2_debug_names_map_matching_symbols.
1408
1409 2019-09-10  Tom Tromey  <tromey@adacore.com>
1410
1411         * dwarf2read.c (dw2_get_file_names_reader): Add the
1412         CU's file name to the results.
1413
1414 2019-09-10  Tom Tromey  <tromey@adacore.com>
1415
1416         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1417         map_matching_symbols.  Update.
1418         * dwarf2read.c (dw2_map_matching_symbols): Update.
1419         * psymtab.c (match_partial_symbol): Change type; update.
1420         (psym_map_matching_symbols): Likewise.
1421         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1422         type; update.
1423         * symfile.h (struct quick_symbol_functions)
1424         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1425         Remove "match".
1426
1427 2019-09-10  Tom Tromey  <tromey@adacore.com>
1428
1429         * psymtab.c (map_block): Remove.
1430         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1431         * symtab.c (iterate_over_symbols_terminated): New function.
1432         * symtab.c (iterate_over_symbols_terminated): Declare.
1433
1434 2019-09-10  Tom Tromey  <tromey@adacore.com>
1435
1436         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1437         * language.h (struct language_defn) <la_iterate_over_symbols>:
1438         Return bool.
1439         * symtab.c (iterate_over_symbols): Return bool.
1440         * symtab.h (iterate_over_symbols): Return bool.
1441
1442 2019-09-10  Tom Tromey  <tromey@adacore.com>
1443
1444         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1445         (add_nonlocal_symbols): Update.
1446         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1447         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1448         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1449         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1450         Change type of "callback".  Remove "data".
1451
1452
1453 2019-09-09  Ali Tamur  <tamur@google.com>
1454
1455         * dwarf2read.c (comp_unit_head): Update comment.
1456         (dwarf2_dwo_name): New function declaration.
1457         (dwarf_unit_type_name): New function declaration.
1458         (read_comp_unit_head): Add support for new compilation units,
1459         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1460         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1461         (currently named as "signature") in their header. Also clarify error
1462         messages.
1463         (lookup_dwo_id): New function. Returns the dwo id of the given
1464         compile unit.
1465         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1466         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1467         functions.
1468         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1469         (dwarf2_dwo_name): Get the dwo name if present.
1470         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1471         purposes.
1472
1473 2019-09-09  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1476
1477 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1478
1479         * python/python.c (do_start_initialization): Make progname_copy static,
1480         to avoid a leak report.
1481
1482 2019-09-08  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1485
1486 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1489         Change type to gdb::optional<block_enum>.
1490         (dw2_symtab_iter_init): Change block_index parameter type
1491         to gdb::optional<block_enum>.
1492         (dw2_lookup_symbol): Change block_index parameter
1493         type to block_enum.c
1494         (dw2_debug_names_lookup_symbol): Likewise.
1495         * psymtab.c (psym_lookup_symbol): Likewise.
1496         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1497         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1498         Likewise.
1499
1500 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1501
1502         * defs.h (relocate_gdb_directory): Change int to bool in
1503         signature and rename flag to relocatable.
1504         * main.c (relocate_path): Likewise.
1505         (relocate_gdb_directory): Likewise.
1506
1507 2019-09-06  Alan Modra  <amodra@gmail.com>
1508
1509         * coffread.c (coff_symfile_read): Constify filename variable.
1510         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1511         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1512         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1513         * solib.c (reload_shared_libraries_1): Likewise.
1514         * symfile.c (reread_symbols): Likewise.
1515         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1516         * solib-darwin.c (darwin_bfd_open): Likewise.
1517         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1518
1519 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1522         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1523
1524 2019-09-03  Tom Tromey  <tromey@adacore.com>
1525
1526         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1527         types.
1528         (has_negatives): Unbias a range type bound.
1529         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1530         * gdbtypes.c (operator==): Handle new field.
1531         (create_range_type): Add "bias" parameter.
1532         (create_static_range_type, resolve_dynamic_range): Update.
1533         * gdbtypes.h (struct range_bounds) <bias>: New member.
1534         (create_range_type): Add bias parameter.
1535         * printcmd.c (print_scalar_formatted): Unbias range types.
1536         * value.c (unpack_long): Unbias range types.
1537         (pack_long): Bias range types.
1538
1539 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1540
1541         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1542         probe arguments.
1543
1544 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1545
1546         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1547         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1548         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1549         (compile_probe_arg): Likewise.
1550         * probe.h (get_argument_count): Likewise.
1551         * solib-svr4.c (solib_event_probe_action): Likewise.
1552         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1553
1554 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1555
1556         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1557         code to here...
1558         (svr4_create_solib_event_breakpoints): ...from here.
1559
1560 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1561
1562         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1563         suffix from warning message.
1564
1565 2019-08-30  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-winsource.h (struct tui_source_window_base)
1568         <refresh_all>: Don't declare.
1569         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1570         Remove.
1571         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1572         tui_show_locator_content.
1573         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1574         declare.
1575         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1576         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1577         declare.
1578
1579 2019-08-30  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1582
1583 2019-08-30  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1586         Remove unnecessary forward declarations.
1587
1588 2019-08-30  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1591         rerender.
1592         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1593         tui_show_locator_content.
1594
1595 2019-08-30  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1598         (tui_locator_window::rerender): Rewrite using body of previous
1599         tui_show_locator_content.
1600
1601 2019-08-30  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1604         set_locator_fullname>: New methods.
1605         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1606         Rename from tui_set_locator_fullname.
1607         (tui_locator_window::set_locator_info): Rename from
1608         tui_set_locator_info.  Return bool.
1609         (tui_update_locator_fullname, tui_show_frame_info): Update.
1610
1611 2019-08-30  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1614
1615 2019-08-30  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1618         call touchwin.
1619
1620 2019-08-30  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-wingeneral.c (box_win): Assume win_info and
1623         win_info->handle cannot be NULL.
1624
1625 2019-08-30  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1628         refresh_window>: Declare.
1629         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1630         resize.
1631         (tui_data_item_window::rerender): Rename from
1632         tui_display_register.
1633         (tui_data_item_window::refresh_window): New method.
1634         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1635         no-op.
1636
1637 2019-08-30  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1640         regs_column_count, current_group>: Move later.  Now private.
1641         <get_current_group>: New method.
1642         * tui/tui-regs.c (tui_reg_command): Update.
1643         * tui/tui-layout.c (tui_set_layout): Update.
1644
1645 2019-08-30  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1648         (tui_data_window::rerender): Don't call
1649         check_and_display_highlight_if_needed.
1650         (tui_data_window::refresh_all): Remove call to
1651         erase_data_content.
1652
1653 2019-08-30  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1656         (tui_data_window::display_registers_from)
1657         (tui_data_window::display_reg_element_at_line)
1658         (tui_data_window::display_registers_from_line): Remove checks of
1659         "empty".
1660
1661 2019-08-30  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1664         Don't declare.
1665         * tui/tui-regs.c (tui_data_window::show_registers): Call
1666         rerender.
1667         (tui_data_window::rerender): Rename from display_all_data.
1668         (tui_data_window::rerender): Remove old implementation.
1669
1670 2019-08-30  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1673         text.
1674         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1675
1676 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1677             Sergio Durigan Junior  <sergiodj@redhat.com>
1678
1679         PR win32/24284
1680         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1681
1682 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1685         when searching for types.
1686
1687 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1688
1689         * f-lang.c (f_language_defn): Use f_print_typedef.
1690         * f-lang.h (f_print_typedef): Declare.
1691         * f-typeprint.c (f_print_typedef): Define.
1692
1693 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1694
1695         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1696
1697 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1698
1699         * cli/cli-utils.c (info_print_options_defs): Delete.
1700         (make_info_print_options_def_group): Delete.
1701         (extract_info_print_options): Delete.
1702         (info_print_command_completer): Delete.
1703         (info_print_args_help): Add extra parameter, and optionally
1704         include text about -n flag.
1705         * cli/cli-utils.h (struct info_print_options): Delete.
1706         (extract_info_print_options): Delete declaration.
1707         (info_print_command_completer): Delete declaration.
1708         (info_print_args_help): Add extra parameter, extend header
1709         comment.
1710         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1711         search_symbols.
1712         * stack.c (struct info_print_options): New type.
1713         (info_print_options_defs): New file scoped variable.
1714         (make_info_print_options_def_group): New static function.
1715         (info_print_command_completer): New static function.
1716         (info_locals_command): Update to use new local functions.
1717         (info_args_command): Likewise.
1718         (_initialize_stack): Add extra parameter to calls to
1719         info_print_args_help.
1720         * symtab.c (search_symbols): Add extra parameter, use this to
1721         possibly excluse non-debug symbols.
1722         (symtab_symbol_info): Add extra parameter, which is passed on to
1723         search_symbols.
1724         (struct info_print_options): New type.
1725         (info_print_options_defs): New file scoped variable.
1726         (make_info_print_options_def_group): New static function.
1727         (info_print_command_completer): New static function.
1728         (info_variables_command): Update to use local functions, and pass
1729         extra parameter through to symtab_symbol_info.
1730         (info_functions_command): Likewise.
1731         (info_types_command): Pass additional argument through to
1732         symtab_symbol_info.
1733         (rbreak_command): Pass extra argument to search_symbols.
1734         (_initialize_symtab): Add extra arguments for calls to
1735         info_print_args_help, and update help text for 'info variables',
1736         'whereis', and 'info functions' commands.
1737         * symtab.h (search_symbols): Add extra argument to declaration.
1738         * NEWS: Mention new flags.
1739
1740 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1741
1742         * symtab.c (lookup_static_symbol): Call the new function (and move
1743         it down to be next to lookup_global_symbol).
1744         (struct global_sym_lookup_data): Add block_enum member and rename to...
1745         (struct global_or_static_sym_lookup_data): ...this.
1746         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1747         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1748         (lookup_symbol_global_or_static_iterator_cb): ...this.
1749         (lookup_global_or_static_symbol): New function.
1750         (lookup_global_symbol): Call new function.
1751
1752 2019-08-26  Tom de Vries  <tdevries@suse.de>
1753
1754         PR c++/24852
1755         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1756         when pc_probe.prob == NULL.
1757
1758 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1759
1760         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1761         variable symbol_linkage to symbol_linkage_.
1762
1763 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1764
1765         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1766         represent whether the symbol is static, dynamic, or we don't
1767         know.
1768
1769 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1770
1771         * gdb/rx-tdep.c (rx_register_names): New.
1772         (rx_register_name): Delete.
1773         (rx_psw_type): Delete.
1774         (rx_fpsw_type): Delete.
1775         (rx_register_type): Delete.
1776         (rx_gdbarch_init): Convert target-descriptions.
1777         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1778         * gdb/features/Makefile: Add rx.xml.
1779         * gdb/features/rx.xml: New.
1780         * gdb/features/rx.c: Generated.
1781         * gdb/NEWS: Mention target description support.
1782
1783 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1784
1785         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1786         *slot_ptr.
1787
1788 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1789
1790         * configure.ac: Don't check for 'dlfcn.h' (moved to
1791         gdbsupport/common.m4).
1792         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1793         'gdbsupport/'.
1794         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1795         * compile/compile-c-support.c: Include
1796         'gdbsupport/gdb-dlfcn.h'.
1797         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1798         * gdb-dlfcn.c: Move to...
1799         * gdbsupport/gdb-dlfcn.c: ... here.
1800         * gdb-dlfcn.h: Move to...
1801         * gdbsupport/gdb-dlfcn.h: ... here.
1802
1803 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1804
1805         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1806         the offset field signed.
1807
1808 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1809
1810         * python/lib/gdb/__init__.py (_execute_file): New function.
1811         * python/python.c (python_run_simple_file): Call gdb._execute_file
1812         on Windows.
1813
1814 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1817         all uses as this was never set to anything but a zero value.
1818
1819 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1820
1821         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1822
1823 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * tui/tui-data.h (tui_gen_win_info): Add an =default
1826         move constructor, required by some GCC versions.
1827
1828 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1829
1830         * go32-nat.c (go32_sysinfo): Add hygon_p.
1831
1832 2019-08-20  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1835         line_from_reg_element_no, first_reg_element_no_inline,
1836         display_all_data, delete_data_content_windows,
1837         erase_data_content>: Now private.
1838
1839 2019-08-20  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1842         (tui_unhighlight_win, tui_highlight_win)
1843         (tui_win_info::make_window): Update.
1844         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1845
1846 2019-08-20  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1849         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1850         (MAX_PID_WIDTH): Move to tui-stack.c.
1851         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1852         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1853         (MAX_PID_WIDTH): Move from tui-data.h.
1854
1855 2019-08-20  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1858         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1859         (box_win): Update.
1860         (tui_gen_win_info::make_window): Rename from tui_make_window.
1861         (tui_win_info::make_window): New method.
1862         (tui_gen_win_info::make_visible): Update.
1863         * tui/tui-source.c (tui_source_window::set_contents): Update.
1864         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1865         (tui_data_window::display_registers_from): Update.
1866         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1867         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1868         Declare.
1869         <can_box>: Remove.
1870         <title>: Remove.
1871         (struct tui_win_info) <make_window>: Declare.
1872         <can_box>: Now virtual.
1873         <title>: New member.
1874         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1875         * tui/tui-command.c (tui_cmd_window::resize): Update.
1876
1877 2019-08-20  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1880         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1881         (tui_data_window::check_register_values): Update.
1882
1883 2019-08-20  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-regs.h (struct tui_data_window): Use
1886         DISABLE_COPY_AND_ASSIGN.
1887         <regs_content>: Change type, removing unique_ptr.
1888         <tui_data_window>: Add move constructor.
1889         * tui/tui-regs.c (tui_data_window::show_registers)
1890         (tui_data_window::show_register_group)
1891         (tui_data_window::display_registers_from)
1892         (tui_data_window::display_registers_from)
1893         (tui_data_window::first_data_item_displayed)
1894         (tui_data_window::delete_data_content_windows)
1895         (tui_data_window::rerender, tui_data_window::refresh_window)
1896         (tui_data_window::check_register_values): Update.
1897
1898 2019-08-20  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1901         show_register_group>: Declare.
1902         (tui_show_register_group): Don't declare.
1903         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1904         tui_show_registers.
1905         (tui_data_window::show_register_group): Rename from
1906         tui_show_register_group.
1907         (tui_data_window::check_register_values, tui_reg_command):
1908         Update.
1909         * tui/tui-layout.c (tui_set_layout): Update.
1910
1911 2019-08-20  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1914         Declare.
1915         (tui_check_register_values): Don't declare.
1916         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1917         from tui_check_register_values.
1918         * tui/tui-hooks.c (tui_register_changed): Update.
1919
1920 2019-08-20  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-regs.c (tui_reg_layout): Move later.
1923         (tui_show_registers): Don't enable TUI mode or change layout.
1924
1925 2019-08-20  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-regs.h (struct tui_data_item_window)
1928         <~tui_data_item_window>: Remove.
1929         <content>: Now a unique_xmalloc_ptr.
1930         * tui/tui-regs.c (tui_register_format): Return a
1931         unique_xmalloc_ptr.
1932         (tui_get_register): Update.
1933         (~tui_data_item_window): Remove.
1934         (tui_data_window::display_registers_from, tui_display_register):
1935         Update.
1936         * tui/tui-io.h (tui_expand_tabs): Update.
1937         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1938         Remove "col" parameter.
1939
1940 2019-08-20  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1943         field.
1944         * tui/tui-regs.c (~tui_data_item_window): Update.
1945
1946 2019-08-20  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1949         earlier.
1950
1951 2019-08-20  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1954
1955 2019-08-20  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-source.h (struct tui_source_window): Update.
1958         * tui/tui-regs.c (tui_show_registers): Update.
1959         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1960         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1961         (NO_REGS_STRING): Remove defines.
1962
1963 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1964
1965         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1966         unnecessary thread walk if remote doesn't support the packet.
1967
1968 2019-08-19  Tom Tromey  <tromey@adacore.com>
1969
1970         * python/py-value.c (value_has_field): Fix indentation.
1971
1972 2019-08-19  Tom Tromey  <tromey@adacore.com>
1973
1974         * printcmd.c (do_one_display, info_display_command): Update.
1975         * block.h (contained_in): Return bool.  Add allow_nested
1976         parameter.
1977         * block.c (contained_in): Return bool.  Add allow_nested
1978         parameter.
1979
1980 2019-08-19  Tom Tromey  <tom@tromey.com>
1981
1982         * configure: Rebuild.
1983         * configure.ac: Disallow the combination of -static-libstdc++ and
1984         source highlight.
1985         * source-cache.c (get_language_name): Handle rust.
1986         (source_cache::get_source_lines): Ignore highlighting exceptions.
1987
1988 2019-08-16  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1991         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1992         (struct tui_source_window_base) <make_visible, refresh_window,
1993         resize>: Remove methods.
1994         <execution_info>: Remove field.
1995         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1996         (tui_show_source_line, tui_source_window_base)
1997         (~tui_source_window_base): Update.
1998         (tui_source_window_base::resize)
1999         (tui_source_window_base::make_visible)
2000         (tui_source_window_base::refresh_window): Remove.
2001         (tui_source_window_base::update_exec_info): Update.
2002         * tui/tui-source.c (tui_source_window::set_contents): Update.
2003         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2004
2005 2019-08-16  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2008         deprecated_query_hook.
2009
2010 2019-08-16  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2013         (tui_update_source_windows_with_line): Update.
2014         * tui/tui-source.h (struct tui_source_window)
2015         <show_symtab_source>: Declare.
2016         (tui_show_symtab_source): Don't declare.
2017         * tui/tui-source.c (tui_show_symtab_source): Rename from
2018         tui_show_symtab_source.
2019
2020 2019-08-16  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-winsource.h (struct tui_source_window_base)
2023         <set_contents>: Declare.
2024         * tui/tui-winsource.c
2025         (tui_source_window_base::update_source_window_as_is): Update.
2026         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2027         Declare.
2028         (tui_set_source_content): Don't declare.
2029         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2030         tui_set_source_content.
2031         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2032         Declare.
2033         (tui_set_disassem_content): Don't declare.
2034         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2035         tui_set_disassem_content.
2036
2037 2019-08-16  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-winsource.h (struct tui_source_window_base)
2040         <update_breakpoint_info>: Declare.
2041         (tui_update_breakpoint_info): Don't declare.
2042         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2043         (tui_update_all_breakpoint_info): Update.
2044         (tui_source_window_base::update_breakpoint_info): Rename from
2045         tui_update_breakpoint_info.
2046         (tui_source_window_base::update_exec_info): Update.
2047
2048 2019-08-16  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.h (struct tui_source_window_base)
2051         <update_source_window>: Declare.
2052         (tui_update_source_window): Don't declare.
2053         * tui/tui-winsource.c
2054         (tui_source_window_base::update_source_window): Rename from
2055         tui_update_source_window.
2056         (tui_source_window_base::rerender): Update.
2057         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2058         * tui/tui-disasm.c (tui_show_disassem)
2059         (tui_show_disassem_and_update_source)
2060         (tui_disasm_window::maybe_update): Update.
2061
2062 2019-08-16  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-winsource.h (struct tui_source_window_base)
2065         <update_source_window_as_is>: Declare.
2066         (tui_update_source_window_as_is): Don't declare.
2067         * tui/tui-winsource.c (tui_update_source_window): Update
2068         (tui_source_window_base::update_source_window_as_is): Rename from
2069         tui_update_source_window_as_is.
2070         (tui_source_window_base::refill): Update.
2071         * tui/tui-source.c (tui_show_symtab_source): Update.
2072         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2073         Update.
2074
2075 2019-08-16  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.h (tui_update_source_window)
2078         (tui_update_source_window_as_is): Remove "noerror" parameter.
2079         * tui/tui-winsource.c (tui_update_source_window)
2080         (tui_update_source_window_as_is): Remove "noerror" parameter.
2081         (tui_update_source_windows_with_addr)
2082         (tui_update_source_windows_with_line)
2083         (tui_source_window_base::rerender)
2084         (tui_source_window_base::refill): Update.
2085         * tui/tui-source.h (tui_set_source_content)
2086         (tui_show_symtab_source): Remove "noerror" parameter.
2087         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2088         parameter.
2089         (tui_show_symtab_source): Likewise.
2090         (tui_source_window::maybe_update): Update.
2091         * tui/tui-disasm.c (tui_show_disassem)
2092         (tui_show_disassem_and_update_source)
2093         (tui_disasm_window::do_scroll_vertical)
2094         (tui_disasm_window::maybe_update): Update.
2095
2096 2019-08-16  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui.c (tui_is_window_visible): Update.
2099         * tui/tui-wingeneral.c (tui_make_window)
2100         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2101         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2102         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2103         (tui_set_win_height_command, parse_scrolling_args): Update.
2104         * tui/tui-source.c (tui_source_window::style_changed): Update.
2105         * tui/tui-regs.c (tui_show_registers)
2106         (tui_data_window::first_data_item_displayed)
2107         (tui_data_window::delete_data_content_windows)
2108         (tui_check_register_values, tui_reg_command): Update.
2109         * tui/tui-disasm.c (tui_show_disassem): Update.
2110         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2111         method.
2112         <is_visible>: Remove field.
2113         * tui/tui-data.c (tui_next_win, tui_prev_win)
2114         (tui_delete_invisible_windows): Update.
2115
2116 2019-08-16  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.h (struct tui_source_window_base)
2119         <m_has_locator>: Remove.
2120         * tui/tui-layout.c (show_source_disasm_command, show_data)
2121         (show_source_or_disasm_and_command): Update.
2122
2123 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2124
2125         * NEWS (Other MI changes): New subsection.
2126         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2127         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2128         * arch-utils.c (default_get_pc_address_flags): New function.
2129         * arch-utils.h (default_get_pc_address_flags): New declaration.
2130         * gdbarch.sh: Add get_pc_address_flags.
2131         * gdbarch.c: Regenerate.
2132         * gdbarch.h: Likewise.
2133         * stack.c (print_pc): New function.
2134         (print_frame_info) (print_frame): Call print_pc.
2135
2136 2019-08-16  Tom de Vries  <tdevries@suse.de>
2137
2138         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2139         print_objfile_section_info.
2140
2141 2019-08-15  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2144         calling update_cmdwin_start_line.
2145         * tui/tui-winsource.h (struct tui_source_window_base)
2146         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2147         <rerender>: Declare.
2148         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2149         Call rerender.
2150         (tui_source_window_base::set_new_height): Remove.
2151         (tui_source_window_base::rerender): Rename from
2152         do_make_visible_with_new_height.
2153         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2154         resize method.
2155         (tui_win_info::make_invisible_and_set_new_height)
2156         (tui_win_info::make_visible_with_new_height): Remove.
2157         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2158         Declare.
2159         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2160         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2161         do_make_visible_with_new_height>: Don't declare.
2162         <rerender>: Declare.
2163         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2164         set_new_height.
2165         (tui_data_window::do_make_visible_with_new_height): Remove.
2166         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2167         call tui_show_locator_content.
2168         (tui_gen_win_info::resize): Call rerender.
2169         (show_source_or_disasm_and_command): Don't call
2170         tui_show_locator_content.
2171         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2172         method.
2173         (struct tui_win_info) <rerender>: Declare.
2174         <set_new_height, make_invisible_and_set_new_height,
2175         make_visible_with_new_height>: Don't declare.
2176         * tui/tui-data.c (tui_win_list::rerender): New method.
2177         * tui/tui-command.h (struct tui_cmd_window)
2178         <do_make_visible_with_new_height>: Don't declare.
2179         * tui/tui-command.c
2180         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2181
2182 2019-08-15  Tom Tromey  <tromey@adacore.com>
2183
2184         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2185         * ada-lang.c (ada_enum_name): Likewise.
2186
2187 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2188
2189         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2190         leading underscore.
2191         (GdbOutputErrorFile): Likewise.
2192         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2193         accordingly.
2194         (execute_unwinders): Rename to have a leading underscore.
2195         (auto_load_packages): Likewise.
2196         (global scope): Adjust call to auto_load_packages accordingly.
2197         (GdbSetPythonDirectory): Likewise.
2198         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2199         instead of execute_unwinders.
2200
2201 2019-08-15  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2204         (show_data): Don't change window visibility.
2205         (tui_gen_win_info::resize): Remove special case for command
2206         window.  Use wresize, when available.
2207         (show_source_or_disasm_and_command): Don't change window
2208         visibility.
2209         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2210         <make_visible>: New method.
2211         * tui/tui-command.c (tui_cmd_window::resize): New method.
2212
2213 2019-08-15  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2216         (struct tui_source_windows): New.
2217         * tui/tui-winsource.c (tui_display_main): Update.
2218         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2219         (new_height_ok, parse_scrolling_args): Update.
2220         * tui/tui-layout.c (show_layout, show_data): Update.
2221         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2222         (tui_add_to_source_windows): Don't declare.
2223         * tui/tui-data.c (source_windows, tui_source_windows)
2224         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2225
2226 2019-08-15  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2229         Rename from reset.
2230         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2231         * tui/tui-layout.c (show_source_disasm_command, show_data):
2232         Update.
2233         (tui_gen_win_info::resize): Rename.
2234         (show_source_or_disasm_and_command): Update.
2235         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2236         reset.
2237
2238 2019-08-15  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2241         * tui/tui-interp.c (tui_interp::init): Don't call
2242         tui_initialize_static_data.
2243         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2244
2245 2019-08-15  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2248         examine tui_win_list.
2249
2250 2019-08-15  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2253         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2254         tui_clear_source_content.
2255         (tui_clear_source_content): Remove.
2256         (tui_source_window_base::do_erase_source_content): Hoist call to
2257         content.clear().
2258         * tui/tui-stack.c (tui_show_frame_info): Don't call
2259         tui_clear_source_content.
2260
2261 2019-08-15  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-winsource.h (struct tui_source_window_base)
2264         <do_erase_source_content>: New method.
2265         <erase_source_content>: New method.
2266         (tui_erase_source_content): Don't declare.
2267         * tui/tui-winsource.c (tui_clear_source_content): Update.
2268         (tui_source_window_base::do_erase_source_content): Rename from
2269         tui_erase_source_content.
2270         (tui_source_window_base::show_source_content): Update.
2271         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2272         * tui/tui-source.h (struct tui_source_window)
2273         <erase_source_content>: New method.
2274         * tui/tui-disasm.h (struct tui_disasm_window)
2275         <erase_source_content>: New method.
2276
2277 2019-08-15  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2280         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2281         constructor.
2282         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2283         * tui/tui-source.c (tui_set_source_content): Update.
2284         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2285
2286 2019-08-15  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2289         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2290         tui-source.c.
2291         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2292         Declare.
2293         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2294         method.
2295         (tui_source_window::maybe_update): Update.
2296
2297 2019-08-15  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2300         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2301         tui-disasm.c.
2302         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2303         Declare.
2304         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2305         method.
2306         (tui_disasm_window::maybe_update): Update.
2307
2308 2019-08-15  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-winsource.h (struct tui_source_window_base)
2311         <maybe_update>: Declare.
2312         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2313         method.
2314         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2315         Declare.
2316         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2317         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2318         Declare.
2319         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2320
2321 2019-08-15  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2324
2325 2019-08-15  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-wingeneral.c: Include tui-stack.h.
2328         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2329         (struct tui_locator_window): Move from tui-data.h.
2330         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2331         (tui_initialize_static_data): Move from tui-data.c.
2332         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2333         (struct tui_locator_window): Move to tui-stack.c.
2334         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2335         (tui_initialize_static_data): Move to tui-stack.c.
2336
2337 2019-08-15  Tom Tromey  <tom@tromey.com>
2338
2339         * tui/tui-layout.c (show_source_disasm_command)
2340         (show_source_or_disasm_and_command): Use make_visible method, not
2341         tui_make_window.
2342         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2343         Remove.
2344
2345 2019-08-15  Tom Tromey  <tom@tromey.com>
2346
2347         * tui/tui-wingeneral.h (tui_make_window): Update.
2348         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2349         parameter.
2350         (tui_gen_win_info::make_visible): Update.
2351         * tui/tui-regs.c (tui_data_window::display_registers_from):
2352         Update.
2353         * tui/tui-layout.c (show_source_disasm_command)
2354         (show_source_or_disasm_and_command): Update.
2355         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2356         (enum tui_box): Remove.
2357         (struct tui_win_info) <can_box>: New method.
2358         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2359         method.
2360
2361 2019-08-15  Tom de Vries  <tdevries@suse.de>
2362
2363         * linux-nat-trad.c: Include gdbarch.h.
2364
2365 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2366
2367         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2368         register sizes.
2369
2370 2019-08-14  Tom Tromey  <tromey@adacore.com>
2371
2372         * darwin-nat.c: Include gdbarch.h.
2373         * darwin-nat-info.c: Include gdbarch.h.
2374
2375 2019-08-13  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2378         Remove.
2379         * tui/tui-data.c (tui_initialize_static_data): Update.
2380
2381 2019-08-13  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-winsource.h (struct tui_exec_info_window)
2384         <~tui_exec_info_window, maybe_allocate_content, get_content,
2385         m_content>: Remove.
2386         (struct tui_source_window_base) <set_exec_info_content,
2387         show_exec_info_content>: Don't declare.
2388         * tui/tui-winsource.c
2389         (tui_exec_info_window::maybe_allocate_content): Remove.
2390         (tui_source_window_base::update_exec_info): Rename from
2391         set_exec_info_content.
2392         (tui_source_window_base::show_exec_info_content)
2393         (tui_source_window_base::update_exec_info): Remove.
2394
2395 2019-08-13  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2398         declare.
2399         * tui/tui-winsource.c (tui_update_source_window_as_is)
2400         (tui_update_source_windows_with_addr, tui_erase_source_content):
2401         Update.
2402         (tui_clear_exec_info_content): Remove.
2403
2404 2019-08-13  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2407         declare.
2408         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2409         call tui_erase_exec_info_content.
2410         (tui_clear_exec_info_content): Rename from
2411         tui_erase_exec_info_content.
2412         (tui_clear_exec_info_content): Delete.
2413
2414 2019-08-13  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-winsource.h (struct tui_source_window_base)
2417         <show_exec_info_content>: Declare.
2418         (tui_show_exec_info_content): Don't declare.
2419         * tui/tui-winsource.c
2420         (tui_source_window_base::show_exec_info_content): Rename from
2421         tui_show_exec_info_content.
2422         (tui_source_window_base::update_exec_info): Update.
2423
2424 2019-08-13  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2427         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2428         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2429         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2430         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2431         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2432         ... here.
2433
2434 2019-08-13  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui-winsource.h (struct tui_source_window_base)
2437         <update_exec_info>: Declare.
2438         (tui_update_exec_info): Don't declare.
2439         * tui/tui-winsource.c (tui_update_source_window_as_is)
2440         (tui_source_window_base::refresh_all)
2441         (tui_update_all_breakpoint_info): Update.
2442         (tui_source_window_base::update_exec_info): Rename from
2443         tui_update_exec_info.
2444         * tui/tui-stack.c (tui_show_frame_info): Update.
2445
2446 2019-08-13  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-winsource.h (struct tui_source_window_base)
2449         <set_exec_info_content>: Declare.
2450         (tui_set_exec_info_content): Don't declare.
2451         * tui/tui-winsource.c
2452         (tui_source_window_base::set_exec_info_content): Rename from
2453         tui_set_exec_info_content.
2454         (tui_update_exec_info): Update.
2455
2456 2019-08-13  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-winsource.h (struct tui_source_window_base)
2459         <show_source_content>: Declare.
2460         (tui_show_source_content): Don't declare.
2461         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2462         (tui_source_window_base::show_source_content): Rename from
2463         tui_show_source_content.
2464         (tui_source_window_base::refresh_all): Update.
2465         * tui/tui-layout.c (show_source_disasm_command)
2466         (show_source_or_disasm_and_command): Update.
2467
2468 2019-08-13  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-winsource.c (tui_erase_source_content)
2471         (tui_show_source_content, tui_source_window_base::refresh_all):
2472         Update.
2473         * tui/tui-wingeneral.h
2474         (tui_check_and_display_highlight_if_needed): Don't declare.
2475         * tui/tui-wingeneral.c
2476         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2477         check_and_display_highlight_if_needed.
2478         * tui/tui-win.c (tui_rehighlight_all)
2479         (tui_win_info::make_visible_with_new_height): Update.
2480         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2481         (tui_data_window::erase_data_content)
2482         (tui_data_window::display_all_data): Update.
2483         * tui/tui-data.h (struct tui_win_info)
2484         <check_and_display_highlight_if_needed>: Declare.
2485
2486 2019-08-13  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-win.c (tui_resize_all): Call
2489         tui_delete_invisible_windows.
2490         * tui/tui-layout.c (show_layout): Call
2491         tui_delete_invisible_windows.
2492         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2493         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2494
2495 2019-08-13  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2498         tui_add_win_to_layout.
2499
2500 2019-08-13  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2503         * tui/tui-layout.c (tui_default_win_height): Now static.
2504
2505 2019-08-13  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2508         single switch.
2509         (show_source_disasm_command, show_source_or_disasm_and_command):
2510         Don't check current layout.
2511
2512 2019-08-13  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-wingeneral.c (make_all_visible): Remove.
2515         (tui_make_all_invisible): Simplify.
2516         * tui/tui-layout.c (tui_make_all_invisible): Move from
2517         tui-wingeneral.c; simplify.
2518         (show_layout): Hoist call to tui_make_all_invisible.
2519         (show_data): Don't call tui_make_all_invisible.
2520
2521 2019-08-13  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2524         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2525
2526 2019-08-13  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2529         tui-data.c.
2530         (show_source_disasm_command, show_data)
2531         (show_source_or_disasm_and_command): Don't use
2532         tui_set_current_layout_to.
2533         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2534         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2535         tui-layout.c.
2536         (tui_set_current_layout_to): Remove.
2537
2538 2019-08-13  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-layout.c (tui_set_layout): Update.
2541         * tui/tui-data.h (struct tui_layout_def): Remove.
2542         (tui_layout_def): Don't declare.
2543         * tui/tui-data.c (layout_def): Remove.
2544         (tui_layout_def): Remove.
2545
2546 2019-08-13  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-winsource.h (struct tui_source_window_base)
2549         <clear_detail>: No longer "override".
2550         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2551         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2552         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2553         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2554         Remove.
2555         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2556
2557 2019-08-13  Tom Tromey  <tromey@adacore.com>
2558
2559         * tracepoint.c: Don't include readline.h or history.h.
2560
2561 2019-08-12  Tom Tromey  <tom@tromey.com>
2562
2563         * configure: Rebuild.
2564         * configure.ac: Check for readline 7.
2565         * NEWS: Mention readline 7 requirement.
2566         * README: Update.
2567
2568 2019-08-12  Tom Tromey  <tom@tromey.com>
2569
2570         * mingw-hdep.c (gdb_select): Remove readline hack.
2571
2572 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2573
2574         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2575         when the function fails.
2576
2577 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2578
2579         * s390-tdep.c (s390_type_align): New function.
2580         (s390_gdbarch_init): Set it as type_align gdbarch method.
2581
2582 2019-08-09  Tom de Vries  <tdevries@suse.de>
2583
2584         PR gdb/24591
2585         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2586         pc_low with relocation offset.
2587
2588 2019-08-07  Tom Tromey  <tromey@adacore.com>
2589
2590         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2591         (print_frame_args): Update.
2592         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2593         Update.
2594         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2595         * frame.h (struct frame_arg): Add initializers.
2596         <error>: Now a unique_xmalloc_ptr.
2597
2598 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2599
2600         * NEWS: Expand the Pointer Authentication entry.
2601         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2602         (aarch64_frame_unmask_lr): ... to this.
2603         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2604         Call aarch64_frame_unmask_lr.
2605         * frame.c (struct frame_info): Add "masked" variable.
2606         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2607         (fprint_frame): Check for masked pc.
2608         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2609         declarations.
2610         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2611         * stack.c (print_frame): Check for masked pc.
2612
2613 2019-08-06  Tom Tromey  <tom@tromey.com>
2614
2615         * stabsread.c (patch_block_stabs, read_one_struct_field)
2616         (read_enum_type): Use obstack_strndup.
2617         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2618         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2619         * dwarf2read.c (guess_full_die_structure_name)
2620         (anonymous_struct_prefix): Use obstack_strndup.
2621         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2622         * c-exp.y (yylex): Use obstack_strndup.
2623         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2624         (write_var_or_type): Use obstack_strndup.
2625
2626 2019-08-06  Tom Tromey  <tom@tromey.com>
2627
2628         * symfile.c (reread_symbols): Use obstack_strdup.
2629         * stabsread.c (read_type): Use obstack_strdup.
2630         * gdb_obstack.h (obstack_strdup): New overload.
2631         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2632         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2633         (dwarf2_canonicalize_name): Use obstack_strdup.
2634         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2635         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2636         Use obstack_strdup.
2637
2638 2019-08-06  Tom Tromey  <tom@tromey.com>
2639
2640         * gdb_obstack.h (obstack_strdup): Define.
2641         * gdb_obstack.c (obstack_strdup): Don't define.
2642
2643 2019-08-06  Tom Tromey  <tom@tromey.com>
2644
2645         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2646         obstack_strdup.
2647         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2648         obstack_strdup.
2649         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2650         * stabsread.c (common_block_start): Use obstack_strdup.
2651         * objfiles.c (set_objfile_main_name, objfile): Use
2652         obstack_strdup.
2653         * namespace.c (add_using_directive): Use obstack_strdup.
2654         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2655         * jit.c (finalize_symtab): Use obstack_strdup.
2656         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2657         (guess_partial_die_structure_name, partial_die_info::fixup)
2658         (dwarf2_name): Use obstack_strdup.
2659         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2660         obstack_strdup.
2661         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2662         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2663         obstack_strdup.
2664         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2665
2666 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2667
2668         * unittests/help-doc-selftests.c: New file.
2669         * Makefile.in: Add the new file.
2670
2671 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2672
2673         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2674         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2675         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2676         the trailing '.' is not output, and the first character is uppercased.
2677         (print_help_for_command): Update call to print_doc_line.
2678         (print_doc_of_command): Likewise.
2679         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2680         * cli/cli-option.c (append_indented_doc): Do not append newline.
2681         (build_help_option): Append newline after first appended_indented_doc
2682         only if a second call is done.
2683         (build_help): Append 2 new lines before each option, except the first
2684         one.
2685         * compile/compile.c (_initialize_compile): Add new lines after
2686         %OPTIONS%, when not at the end of the help.
2687         Change help doc or code
2688         producing the help doc to respect the invariants.
2689         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2690         Also removed the new line after 'Options:', as all other commands
2691         do not put an empty line between 'Options:' and the first option.
2692         * printcmd.c (_initialize_printcmd): Likewise.
2693         * stack.c (_initialize_stack): Likewise.
2694         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2695         incorrectly telling COMMAND is optional.
2696         * ada-lang.c (_initialize_ada_language): Change help doc or code
2697         producing the help doc to respect the invariants.
2698         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2699         * breakpoint.c (_initialize_breakpoint): Likewise.
2700         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2701         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2702         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2703         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2704         _initialize_cli_style): Likewise.
2705         * corelow.c (core_target_info): Likewise.
2706         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2707         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2708         * filesystem.c (_initialize_filesystem): Likewise.
2709         * frame.c (_initialize_frame): Likewise.
2710         * gnu-nat.c (add_task_commands): Likewise.
2711         * infcall.c (_initialize_infcall): Likewise.
2712         * infcmd.c (_initialize_infcmd): Likewise.
2713         * interps.c (_initialize_interpreter): Likewise.
2714         * language.c (_initialize_language): Likewise.
2715         * linux-fork.c (_initialize_linux_fork): Likewise.
2716         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2717         * maint.c (_initialize_maint_cmds): Likewise.
2718         * memattr.c (_initialize_mem): Likewise.
2719         * printcmd.c (_initialize_printcmd): Likewise.
2720         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2721         _RegEx): Likewise.
2722         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2723         * record-btrace.c (_initialize_record_btrace): Likewise.
2724         * record-full.c (_initialize_record_full): Likewise.
2725         * record.c (_initialize_record): Likewise.
2726         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2727         * regcache.c (_initialize_regcache): Likewise.
2728         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2729         _initialize_remote): Likewise.
2730         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2731         * serial.c (_initialize_serial): Likewise.
2732         * skip.c (_initialize_step_skip): Likewise.
2733         * source.c (_initialize_source): Likewise.
2734         * stack.c (_initialize_stack): Likewise.
2735         * symfile.c (_initialize_symfile): Likewise.
2736         * symtab.c (_initialize_symtab): Likewise.
2737         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2738         * top.c (init_main): Likewise.
2739         * tracefile-tfile.c (tfile_target_info): Likewise.
2740         * tracepoint.c (_initialize_tracepoint): Likewise.
2741         * tui/tui-win.c (_initialize_tui_win): Likewise.
2742         * utils.c (add_internal_problem_command): Likewise.
2743         * valprint.c (value_print_option_defs): Likewise.
2744
2745 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2746
2747         PR build/24886
2748         * configure.ac: Drop enable-libmcheck support.
2749         * configure, config.in: Rebuild.
2750         * libmcheck.m4: Remove.
2751         * acinclude.m4: Don't include it.
2752         * Makefile.in: Don't distribute it.
2753         * top.c (print_gdb_configuration): Don't mention it.
2754
2755 2019-08-06  Tom Tromey  <tom@tromey.com>
2756
2757         * utils.c (set_output_style): Sometimes pass stream to
2758         emit_style_escape.
2759         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2760         * record-btrace.c (btrace_insn_history): Update.
2761         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2762         method.
2763         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2764         Update initializers.
2765         <m_uiout>: New field.
2766         <m_di>: Move lower.
2767         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2768         Remove "uiout" parameter.
2769         (dump_insns): Update.
2770         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2771         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2772
2773 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2774
2775         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2776         (error_in_psymtab_expansion): Likewise.
2777         (lookup_symbol_via_quick_fns): Likewise.
2778         (basic_lookup_transparent_type_quick): Likewise.
2779         (basic_lookup_transparent_type_1): Likewise.
2780
2781 2019-08-06  Tom Tromey  <tromey@adacore.com>
2782
2783         * source.c (last_source_error): Now bool.
2784         (print_source_lines_base): Make "noprint" bool.  Only open
2785         source file when last_source_visited changes.
2786
2787 2019-08-06  Tom Tromey  <tromey@adacore.com>
2788
2789         * annotate.c (annotate_source_line): Use g_source_cache.
2790         * source-cache.c (source_cache::get_plain_source_lines): Change
2791         parameters.  Populate m_offset_cache.
2792         (source_cache::ensure): New method.
2793         (source_cache::get_line_charpos): New method.
2794         (extract_lines): Move lower.  Change parameters.
2795         (source_cache::get_source_lines): Move lower.
2796         * source-cache.h (class source_cache): Update comment.
2797         <get_line_charpos>: New method.
2798         <get_source_lines>: Update comment.
2799         <clear>: Clear m_offset_cache.
2800         <get_plain_source_lines>: Change parameters.
2801         <ensure>: New method
2802         <m_offset_cache>: New member.
2803         * source.c (forget_cached_source_info_for_objfile): Update.
2804         (info_source_command): Use g_source_cache.
2805         (find_source_lines, open_source_file_with_line_charpos): Remove.
2806         (print_source_lines_base, search_command_helper): Use g_source_cache.
2807         * source.h (open_source_file_with_line_charpos): Don't declare.
2808         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2809         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2810         Use g_source_cache.
2811
2812 2019-08-06  Tom Tromey  <tromey@adacore.com>
2813
2814         * source-cache.c (source_cache::get_plain_source_lines):
2815         Remove "first_line" and "last_line" parameters.
2816         (source_cache::get_source_lines): Cache plain text.
2817         * source-cache.h (class source_cache)
2818         <get_plain_source_lines>: Update.
2819
2820 2019-08-06  Tom Tromey  <tromey@adacore.com>
2821
2822         * source-cache.c (extract_lines): No longer a method.
2823         Changed type of parameter.  Include final newline.
2824         (selftests::extract_lines_test): New function.
2825         (_initialize_source_cache): Likewise.
2826         * source-cache.h (class source_cache)
2827         <extract_lines>: Don't declare.
2828
2829 2019-08-06  Tom Tromey  <tromey@adacore.com>
2830
2831         * breakpoint.c (init_breakpoint_sal): Update.
2832         (breakpoint): Update.
2833         * breakpoint.h (struct breakpoint) <filter>: Now a
2834         unique_xmalloc_ptr.
2835
2836 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2837
2838         * NEWS: Mention dictionary access on blocks.
2839         * python/py-block.c (blpy_getitem): New function.
2840         (block_object_as_mapping): New struct.
2841         (block_object_type): Use new struct for tp_as_mapping field.
2842
2843 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2844
2845         * objfiles.h (objfile): Add a comment describing partial symbols.
2846
2847 2019-08-05  Tom Tromey  <tromey@adacore.com>
2848
2849         * compile/compile.c (_initialize_compile): Use _(), not N_().
2850         * thread.c (_initialize_thread): Use _(), not N_().
2851         * stack.c (_initialize_stack): Use _(), not N_().
2852         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2853
2854 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2855
2856         * dwarf2read.c (struct dw2_symtab_iterator):
2857         <want_specific_block>: Remove.
2858         <block_index>: Change type to gdb::optional.
2859         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2860         change type of BLOCK_INDEX parameter to gdb::optional.
2861         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2862         (dw2_lookup_symbol): Don't pass argument for
2863         WANT_SPECIFIC_BLOCK.
2864         (dw2_expand_symtabs_for_function): Don't pass argument for
2865         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2866         (class dw2_debug_names_iterator)
2867         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2868         parameter, change BLOCK_INDEX type to gdb::optional.
2869         <m_want_specific_block>: Remove.
2870         <m_block_index>: Change type to gdb::optional.
2871         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2872         gdb::optional.  Re-write in function of gdb::optional.
2873         (dw2_debug_names_lookup_symbol): Don't pass argument for
2874         WANT_SPECIFIC_BLOCK.
2875         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2876         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2877         BLOCK_INDEX.
2878
2879 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2880
2881         * NEWS: Mention changes to "info sources" command.
2882
2883 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2884
2885         * symtab.c (filename_partial_match_opts): New struct type.
2886         (struct output_source_filename_data): New members
2887         regexp, c_regexp, partial_match.
2888         (output_source_filename): Use new members to decide to print file.
2889         (info_sources_option_defs): New variable.
2890         (make_info_sources_options_def_group, print_info_sources_header,
2891         info_sources_command_completer):
2892         New functions.
2893         (info_sources_command): Read new optional arguments.
2894         (_initialize_symtab): Update info sources help.
2895
2896 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2897
2898         * ada-lang.c (exception_support_info_v0): Renamed from...
2899         (default_exception_support_info): ... this.  Create new
2900         definition for v1.
2901         (ada_has_this_exception_support): Look up catch_handlers_sym.
2902         (ada_exception_support_info_sniffer): Try v0 after default.
2903
2904 2019-08-01  Tom Tromey  <tromey@adacore.com>
2905
2906         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2907         gdbarch.h.
2908
2909 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2910
2911         * s12z-tdep.c: Fix include path for s12z-opc.h.
2912
2913 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * NEWS: Require GNU make 3.82.
2916
2917 2019-07-16  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2920         declare.
2921
2922 2019-07-30  Tom Tromey  <tromey@adacore.com>
2923
2924         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2925
2926 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2927
2928         * printcmd.c (print_address_symbolic): Print negative offsets.
2929         (build_address_symbolic): Force signed arithmetic when computing
2930         offset.
2931
2932 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2933
2934         PR/24474: Add a function to lookup static variables.
2935         * NEWS: Mention this new function.
2936         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2937         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2938         * python/python.c (python_GdbMethods): Add new function.
2939
2940 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2941
2942         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2943         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2944         (objfpy_lookup_static_symbol): New function.
2945         (objfile_object_methods): Add new functions.
2946
2947 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2948
2949         * NEWS: Mention 'set|show print frame-info'.  Mention new
2950         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2951         backtrace argument.  Mention that python frame filtering code
2952         is now consistent with what 'backtrace' command prints.
2953
2954 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2955
2956         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2957         comments.
2958         (print_frame_info_auto, print_frame_info_source_line,
2959         print_frame_info_location, print_frame_info_source_and_location,
2960         print_frame_info_location_and_address, print_frame_info_short_location):
2961         New declarations.
2962         (struct frame_print_options): New member print_frame_info.
2963         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2964         * stack.h (get_user_print_what_frame_info): New declaration.
2965         (frame_show_address): New declaration.
2966         * stack.c (print_frame_arguments_choices): New value 'presence'.
2967         (print_frame_info_auto, print_frame_info_source_line,
2968         print_frame_info_location, print_frame_info_source_and_location,
2969         print_frame_info_location_and_address, print_frame_info_short_location,
2970         print_frame_info_choices, print_frame_info_print_what): New definitions.
2971         (print_frame_args): Only print dots for args if print frame-arguments
2972         is 'presence'.
2973         (frame_print_option_defs): New element for "frame-info".
2974         (get_user_print_what_frame_info): New function.
2975         (frame_show_address): Make non static.  Move comment to stack.h.
2976         (print_frame_info_to_print_what): New function.
2977         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2978         to decide what to print.
2979         (backtrace_command_1): Handle the new print_frame_arguments_presence
2980         value.
2981         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2982         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2983         (py_print_frame): In non-mi mode, use LOCATION as default for
2984         print_what, similarly to frame information printed directly by
2985         backtrace command. Handle frame-info user option in non MI mode.
2986
2987 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2988
2989         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2990         Add case for debugging 32-bit target on 64-bit host.  Revise
2991         comment.
2992
2993 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2994
2995         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2996         instead of find_function_entry_range_from_pc.
2997
2998 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2999
3000         * stack.c (find_frame_funname): Remove code which preferred
3001         minsym over symtab sym in "certain pathological cases".
3002
3003         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3004         parameter.  Change type of "do_demangle" to bool.
3005         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3006         Pass suitable "prefer_sym_over_minsym" flag to
3007         build_address_symbolic().  Don't output "+" for negative offsets.
3008         * printcmd.c (print_address_symbolic): Update invocation of
3009         build_address_symbolic to include a "prefer_sym_over_minsym"
3010         flag.
3011         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3012         Restrict cases in which use of minimal symbol is preferred to that
3013         of a found symbol.  Update comments.
3014
3015         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3016         for entry pc when entry pc is out of range for that FDE.
3017
3018 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3019
3020         PR gdb/24839:
3021         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3022         type.
3023
3024 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3025
3026         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3027         this function's Python signature.
3028
3029
3030 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3031
3032         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3033         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3034         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3035         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3036         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3037
3038
3039 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3040
3041         * h8300-tdep.c (h8300_register_name_common): New.
3042         h8300_register_name): Use h8300_register_name_common.
3043         (h8300s_register_name): Likewise.
3044         (h8300sx_register_name): Likewise.
3045         (h8300h_register_nam): New.
3046         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3047
3048
3049 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3050
3051         * arm-tdep.c (arm_skip_cmse_entry): New function.
3052         (arm_is_sgstubs_section): New function.
3053         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3054
3055 2019-07-22  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3058         Don't self-assign.
3059
3060 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3063         type_print.
3064
3065 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3068         so that GDB doesn't match any msymbols when searching in the
3069         TYPES_DOMAIN.
3070         (print_symbol_info): Print using typedef_print or type_print based
3071         on the type of the symbol.  Add updated FIXME comment moved from...
3072         (_initialize_symtab): ... move and update FIXME comment to above.
3073
3074 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3075
3076         * NEWS: Mention adding -q option to "info types".
3077         * symtab.c (struct info_types_options): New struct.
3078         (info_types_options_defs): New variable.
3079         (make_info_types_options_def_group): New function.
3080         (info_types_command): Use gdb::option framework to parse options.
3081         (info_types_command_completer): New function.
3082         (_initialize_symtab): Extend the help text on "info types" and
3083         register command completer.
3084
3085 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3086
3087         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3088         (lookup_symbol_in_objfile): Change int to block_enum and add a
3089         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3090
3091 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3092
3093         * MAINTAINERS (Write After Approval): Add self.
3094
3095 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3098         instruction to the dummy code region.
3099
3100 2019-07-19  Tom Tromey  <tromey@adacore.com>
3101
3102         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3103         (ARGSUSED, PARAMS, __func__): Remove rules.
3104
3105 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3106
3107         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3108         * features/arm/arm-with-iwmmxt.c: Remove.
3109         * features/arm/arm-with-iwmmxt.xml: Remove.
3110         * features/arm/arm-with-m-fpa-layout.c: Remove.
3111         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3112         * features/arm/arm-with-m-vfp-d16.c: Remove.
3113         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3114         * features/arm/arm-with-m.c: Remove.
3115         * features/arm/arm-with-m.xml: Remove.
3116         * features/arm/arm-with-neon.c: Remove.
3117         * features/arm/arm-with-neon.xml: Remove.
3118         * features/arm/arm-with-vfpv2.c: Remove.
3119         * features/arm/arm-with-vfpv2.xml: Remove.
3120         * features/arm/arm-with-vfpv3.c: Remove.
3121         * features/arm/arm-with-vfpv3.xml: Remove.
3122
3123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3124
3125         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3126
3127 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3128
3129         * arch/aarch32.c (aarch32_create_target_description): Create
3130         target descriptions using features.
3131         * arch/arm.c (arm_create_target_description)
3132         (arm_create_mprofile_target_description): Likewise.
3133         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3134
3135 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3136
3137         * Makefile.in: Add new files.
3138         * aarch32-tdep.c: New file.
3139         * aarch32-tdep.h: New file.
3140         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3141         Call aarch32_read_description.
3142         * arch/aarch32.c: New file.
3143         * arch/aarch32.h: New file.
3144         * arch/arm.c (arm_create_target_description)
3145         (arm_create_mprofile_target_description): New function.
3146         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3147         (arm_create_target_description)
3148         (arm_create_mprofile_target_description): New declaration.
3149         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3150         read_description functions.
3151         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3152         Likewise.
3153         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3154         * arm-tdep.c (tdesc_arm_list): New variable.
3155         (arm_register_g_packet_guesses): Call create description functions.
3156         (arm_read_description) (arm_read_mprofile_description): New
3157         function.
3158         * arm-tdep.h (arm_read_description)
3159         (arm_read_mprofile_description): Add declaration.
3160         * configure.tgt: Add new files.
3161
3162 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3163
3164         * top.c (new_ui_command): Open specified terminal just once.
3165
3166 2019-07-18  Tom Tromey  <tromey@adacore.com>
3167
3168         * symtab.c (main_name): Constify return type.
3169         * symfile.c (set_initial_language): Update.
3170         * symtab.h (main_name): Constify return type.
3171
3172 2019-07-17  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-winsource.c (tui_update_source_window)
3175         (tui_update_source_window_as_is)
3176         (tui_update_source_windows_with_line): Remove return.
3177         * tui/tui-disasm.c (tui_show_disassem)
3178         (tui_show_disassem_and_update_source): Remove return.
3179         * tui/tui.c (tui_reset): Remove return.
3180         * tui/tui-wingeneral.c
3181         (tui_check_and_display_highlight_if_needed): Remove return.
3182
3183 2019-07-17  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3186
3187 2019-07-17  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-winsource.h (struct tui_exec_info_window)
3190         (struct tui_source_window_base): Move from tui-data.h.
3191         * tui/tui-winsource.c: Move many method definitions from
3192         elsewhere.  Remove "structuring" comments.
3193         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3194         (tui_source_window_base::refresh_window): Move to
3195         tui-winsource.c.
3196         * tui/tui-win.c (tui_source_window_base::refresh_all)
3197         (tui_source_window_base::update_tab_width)
3198         (tui_source_window_base::set_new_height)
3199         (tui_source_window_base::do_make_visible_with_new_height): Move to
3200         tui-winsource.c.
3201         * tui/tui-source.h: Update.
3202         * tui/tui-source.c (tui_source_window_base::reset): Move to
3203         tui-winsource.c.
3204         * tui/tui-disasm.h: Update.
3205         * tui/tui-data.h (struct tui_exec_info_window): Move to
3206         tui-winsource.h.
3207         (struct tui_source_window_base): Likewise.
3208         * tui/tui-data.c (tui_source_window_base::clear_detail)
3209         (tui_source_window_base, ~tui_source_window_base): Move to
3210         tui-winsource.c.
3211
3212 2019-07-17  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-win.c (tui_resize_all)
3215         (tui_source_window_base::update_tab_width)
3216         (tui_adjust_win_heights): Update.
3217         (tui_win_info::make_invisible_and_set_new_height): Rename from
3218         make_invisible_and_set_new_height.
3219         * tui/tui-data.h (struct tui_win_info)
3220         <make_invisible_and_set_new_height>: New method.
3221
3222 2019-07-17  Tom Tromey  <tom@tromey.com>
3223
3224         * tui/tui.c: Update.
3225         * tui/tui-source.h (struct tui_source_window): Move from
3226         tui-data.h.
3227         * tui/tui-layout.c: Update.
3228         * tui/tui-disasm.c: Update.
3229         * tui/tui-data.h (struct tui_source_window): Move to
3230         tui-source.h.
3231
3232 2019-07-17  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3235         tui-data.h.
3236         * tui/tui-data.h (struct tui_disasm_window): Move to
3237         tui-disasm.h.
3238
3239 2019-07-17  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-regs.h (struct tui_data_item_window): Move from
3242         tui-data.h.
3243         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3244         * tui/tui-data.h (struct tui_data_item_window): Move to
3245         tui-regs.h.
3246         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3247
3248 2019-07-17  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui.c: Update.
3251         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3252         (tui_cmd_window::max_height): Move to tui-command.c.
3253         * tui/tui-layout.c: Update.
3254         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3255         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3256         tui-command.c.
3257         * tui/tui-command.h (struct tui_cmd_window): Move from
3258         tui-data.h.
3259         * tui/tui-command.c: Remove "structuring" comments.
3260         (tui_cmd_window::clear_detail)
3261         (tui_cmd_window::do_make_visible_with_new_height)
3262         (tui_cmd_window::max_height): Move from elsewhere.
3263
3264 2019-07-17  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3267         Now static.
3268         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3269         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3270
3271 2019-07-17  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui.c: Update.
3274         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3275         tui-regs.c.
3276         * tui/tui-windata.h: Remove file.
3277         * tui/tui-windata.c: Remove file.
3278         * tui/tui-win.c (tui_data_window::set_new_height)
3279         (tui_data_window::do_make_visible_with_new_height): Move to
3280         tui-regs.c.
3281         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3282         * tui/tui-regs.c: Remove "structuring" comments.
3283         (tui_data_window::first_data_item_displayed)
3284         (tui_data_window::delete_data_content_windows)
3285         (tui_data_window::erase_data_content)
3286         (tui_data_window::display_all_data)
3287         (tui_data_window::refresh_all)
3288         (tui_data_window::do_scroll_vertical)
3289         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3290         (tui_data_window::do_make_visible_with_new_height)
3291         (tui_data_window::refresh_window): Move from elsewhere.
3292         (_initialize_tui_regs): Move to end of file.
3293         * tui/tui-layout.c: Update.
3294         * tui/tui-hooks.c: Update.
3295         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3296         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3297         tui-regs.c.
3298         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3299
3300 2019-07-17  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3303         seen.
3304
3305 2019-07-17  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-win.c (tui_source_window_base::set_new_height)
3308         (tui_source_window_base::do_make_visible_with_new_height): Use
3309         m_has_locator field directly.
3310         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3311         method.
3312         (struct tui_source_window_base) <has_locator>: Likewise.
3313
3314 2019-07-17  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3317         Don't declare.
3318         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3319         Remove.
3320         * tui/tui-win.c (tui_source_window_base::set_new_height)
3321         (tui_source_window_base::set_new_height)
3322         (make_invisible_and_set_new_height)
3323         (tui_source_window_base::do_make_visible_with_new_height)
3324         (tui_source_window_base::do_make_visible_with_new_height):
3325         Update.
3326         * tui/tui-layout.c (show_source_disasm_command, show_data)
3327         (show_source_or_disasm_and_command): Update.
3328         * tui/tui-layout.c (show_layout): Update.
3329
3330 2019-07-17  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-layout.c (make_data_window): Remove.
3333         (show_data): Unify creation and re-initialization cases.
3334
3335 2019-07-17  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-layout.c (make_source_window, make_disasm_window):
3338         Remove.
3339         (show_data): Unify creation and re-initialization cases.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-layout.c (make_command_window): Remove.
3344         (show_source_disasm_command, show_source_or_disasm_and_command):
3345         Unify creation and re-initialization cases.
3346
3347 2019-07-17  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3350         creation and re-initialization cases.
3351
3352 2019-07-17  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-regs.c (tui_get_register): Return void.
3355
3356 2019-07-17  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3359         Simplify.
3360
3361 2019-07-17  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3364         resetting.
3365
3366 2019-07-17  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3369         * tui/tui-regs.c (tui_reg_layout): New function.
3370         (tui_show_registers, tui_reg_command): Use it.
3371         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3372         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3373         parameters.
3374         (tui_layout_command): Remove.
3375
3376 2019-07-17  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-layout.h (tui/tui-layout): Return void.
3379         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3380
3381 2019-07-17  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-layout.c (show_source_disasm_command, show_data):
3384         Update.
3385         (reset_locator): Remove.
3386         (show_source_or_disasm_and_command): Update.
3387
3388 2019-07-17  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-source.c (tui_source_window_base::reset): Remove
3391         win_type parameter.
3392         * tui/tui-layout.c (make_command_window, make_source_window)
3393         (make_disasm_window, make_data_window)
3394         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3395         (reset_locator, show_source_or_disasm_and_command): Update.
3396         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3397         win_type parameter.
3398         (struct tui_source_window_base) <reset>: Likewise.
3399
3400 2019-07-17  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-layout.c (show_source_disasm_command): Use
3403         reset_locator.
3404         (reset_locator): New function.
3405         (init_and_make_win): Remove.
3406         (show_source_or_disasm_and_command): Use reset_locator.
3407
3408 2019-07-17  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3411         condition.
3412         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3413         Remove condition.
3414         * tui/tui-source.c (tui_source_window_base::reset): New method.
3415         * tui/tui-layout.c (make_command_window): Don't call
3416         init_and_make_win.
3417         (make_source_window, make_disasm_window): Don't call
3418         make_source_or_disasm_window.
3419         (make_data_window): Don't call init_and_make_win.  Change calling
3420         convention.
3421         (show_source_disasm_command, show_data): Simplify.
3422         (make_source_or_disasm_window): Remove.
3423         (show_source_or_disasm_and_command): Simplify.
3424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3425         (struct tui_source_window_base) <reset>: Likewise.
3426         <execution_info>: Remove initializer.
3427         * tui/tui-data.c (tui_source_window_base): Initialize
3428         execution_info.
3429
3430 2019-07-17  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3433         variable.
3434
3435 2019-07-17  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui.c (tui_rl_other_window): Update.
3438         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3439         superclass method first.  Always iterate over regs_content.
3440         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3441         method.
3442         * tui/tui-win.c (tui_set_focus_command): Update.
3443
3444 2019-07-17  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-win.c (tui_set_focus_command): Rename from
3447         tui_set_focus.  Call tui_enable.
3448         (tui_set_focus_command): Remove.
3449
3450 2019-07-17  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3453         refresh_window.
3454         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3455         touchwin.
3456         (tui_data_window::refresh_window): Call refresh_window on data
3457         items.  Always call superclass refresh_window.
3458         (tui_win_info::refresh): Remove.
3459         (tui_source_window_base::refresh_window): Update.
3460         (tui_refresh_all): Update.
3461         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3462         refresh_window.
3463         (show_source_or_disasm_and_command): Likewise.
3464         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3465         (struct tui_source_window_base) <refresh>: Likewise.
3466
3467 2019-07-17  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-winsource.c (tui_clear_source_content)
3470         (tui_show_source_content): Update.
3471         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3472         whether content is empty.
3473         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3474         Remove.
3475
3476 2019-07-17  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3479         window's contents.
3480         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3481         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3482
3483 2019-07-17  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3486         (struct tui_data_item_window): Update.
3487
3488 2019-07-17  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3491         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3492         defines.
3493
3494 2019-07-17  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-winsource.h (tui_erase_source_content)
3497         (tui_clear_source_content): Remove "display_prompt" parameter.
3498         * tui/tui-winsource.c (tui_update_source_window_as_is)
3499         (tui_update_source_windows_with_addr): Update.
3500         (tui_clear_source_content): Remove "display_prompt" parameter.
3501         (tui_erase_source_content): Likewise.  Simplify.
3502         (tui_show_source_content): Update.
3503         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3504         * tui/tui-stack.c (tui_show_frame_info): Update.
3505         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3506         Remove defines.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3511         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3512         parameter.
3513         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3514         parameter.
3515
3516 2019-07-17  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-winsource.c (tui_clear_source_content)
3519         (tui_show_source_content, tui_show_exec_info_content)
3520         (tui_clear_exec_info_content): Update.
3521         * tui/tui-stack.c (tui_show_locator_content): Update.
3522         (tui_show_frame_info): Update.
3523         * tui/tui-source.h (tui_source_window): Don't declare.
3524         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3525         from tui_source_is_displayed.
3526         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3527         Remove field.
3528         (struct tui_source_window_base) <content_in_use>: New field.  Now
3529         bool.
3530         (struct tui_source_window) <showing_source_p>: New method.
3531         (TUI_SRC_WIN): Change cast.
3532         * tui/tui-data.c (tui_initialize_static_data): Update.
3533
3534 2019-07-17  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3537         location_matches_p.
3538         * tui/tui-source.c (tui_source_window::location_matches_p): New
3539         method.
3540         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3541         method.
3542         * tui/tui-data.h (struct tui_source_window_base)
3543         <location_matches_p>: New method.
3544         (struct tui_source_window, struct tui_disasm_window)
3545         <location_matches_p>: Likewise.
3546
3547 2019-07-17  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-win.c (tui_set_win_height_command): Rename from
3550         tui_set_win_height.
3551         (tui_set_win_height_command): Remove.
3552
3553 2019-07-17  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-source.c (tui_source_window): New constructor.  Add
3556         observer.
3557         (~tui_source_window): New destructor.
3558         (tui_source_window::style_changed): New method.
3559         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3560         (tui_attach_detach_observers): Update.
3561         * tui/tui-data.h (struct tui_source_window): Make constructor not
3562         inline.  Add destructor.
3563         (struct tui_source_window) <style_changed>: New method.
3564         <m_observable>: New member.
3565
3566 2019-07-17  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3569         * tui/tui-win.c (tui_resize_all): Fix typo.
3570
3571 2019-07-17  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3574         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3575         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3576         * tui/tui-win.c (window_name_completer): Use foreach.
3577         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3578         (update_tab_width): Likewise.
3579         * tui/tui-layout.c (show_layout): Update.
3580         * tui/tui-data.h (class tui_window_iterator): New.
3581         (struct all_tui_windows): New.
3582         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3583
3584 2019-07-17  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3587         parameter.  Don't reference globals.
3588         (tui_reg_command): Update.
3589
3590 2019-07-17  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-regs.c (tui_show_registers): Simplify.
3593
3594 2019-07-17  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-regs.c (tui_show_registers): Update.
3597         (tui_show_register_group): Add win_info parameter.
3598
3599 2019-07-17  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3602         Rename from tui_display_reg_element_at_line.
3603         (tui_data_window::display_registers_from_line): Update.
3604         * tui/tui-data.h (struct tui_data_window)
3605         <display_reg_element_at_line>: New method.
3606
3607 2019-07-17  Tom Tromey  <tom@tromey.com>
3608
3609         * tui/tui-regs.h (tui_display_registers_from)
3610         (tui_display_registers_from_line): Don't declare.
3611         * tui/tui-windata.c (tui_data_window::display_all_data)
3612         (tui_data_window::refresh_all)
3613         (tui_data_window::do_scroll_vertical): Update.
3614         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3615         from tui_display_registers_from.
3616         (tui_display_reg_element_at_line): Update.
3617         (tui_data_window::display_registers_from_line): Rename from
3618         tui_display_registers_from_line.
3619         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3620         display_registers_from_line>: New methods.
3621
3622 2019-07-17  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3625         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3626         from tui_erase_data_content.
3627         (tui_data_window::display_all_data)
3628         (tui_data_window::refresh_all)
3629         (tui_data_window::do_scroll_vertical): Update.
3630         * tui/tui-regs.c (tui_show_registers): Update.
3631         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3632         New method.
3633
3634 2019-07-17  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3637         declare.
3638         * tui/tui-windata.c
3639         (tui_data_window::delete_data_content_windows): Rename from
3640         tui_delete_data_content_windows.
3641         (tui_data_window::display_all_data)
3642         (tui_data_window::do_scroll_vertical): Update.
3643         * tui/tui-data.h (struct tui_data_window)
3644         <delete_data_content_windows>: New method.
3645
3646 2019-07-17  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3649         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3650
3651 2019-07-17  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3654         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3655         from tui_display_all_data.
3656         * tui/tui-win.c
3657         (tui_data_window::do_make_visible_with_new_height): Update.
3658         * tui/tui-regs.c (tui_show_registers): Update.
3659         * tui/tui-layout.c (tui_set_layout): Update.
3660         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3661         method.
3662
3663 2019-07-17  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3666         * tui/tui-windata.c (tui_display_data_from): Remove.
3667         (tui_data_window::refresh_all): Update.
3668
3669 2019-07-17  Tom Tromey  <tom@tromey.com>
3670
3671         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3672         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3673         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3674         tui_display_registers_from_line.
3675         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3676         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3677         "force_display" parameter.
3678
3679 2019-07-17  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3682         declare.
3683         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3684         Rename from tui_first_reg_element_no_inline.
3685         (tui_display_reg_element_at_line)
3686         (tui_display_registers_from_line): Update.
3687         * tui/tui-data.h (struct tui_data_window)
3688         <first_reg_element_no_inline>: New method.
3689
3690 2019-07-17  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-windata.c (tui_display_data_from)
3693         (tui_data_window::do_scroll_vertical): Update.
3694         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3695         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3696         Rename from tui_line_from_reg_element_no.
3697         (tui_display_registers_from_line): Update.
3698         * tui/tui-data.h (struct tui_data_window)
3699         <line_from_reg_element_no>: New method.
3700
3701 2019-07-17  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3704         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3705         tui_last_regs_line_no.
3706         (tui_display_reg_element_at_line)
3707         (tui_display_registers_from_line): Update.
3708         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3709         method.
3710
3711 2019-07-17  Tom Tromey  <tom@tromey.com>
3712
3713         PR tui/24722:
3714         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3715         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3716         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3717         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3718         (tui_update_breakpoint_info): Likewise.
3719         * tui/tui-hooks.c (tui_event_create_breakpoint)
3720         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3721         Update.
3722
3723 2019-07-17  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3726
3727 2019-07-17  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-winsource.c (tui_update_source_window_as_is)
3730         (tui_update_source_windows_with_addr): Update.
3731         * tui/tui-source.h (tui_set_source_content)
3732         (tui_show_symtab_source): Add "win_info" parameter.
3733         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3734         parameter.
3735         (tui_show_symtab_source): Likewise.
3736
3737 2019-07-17  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-wingeneral.c
3740         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3741
3742 2019-07-17  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3745         (struct tui_cmd_window) <can_scroll>: New method.
3746         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3747         method.
3748
3749 2019-07-17  Tom Tromey  <tromey@adacore.com>
3750
3751         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3752         do_field_signed>: Rename.  Change type of "value".
3753         * ui-out.c (ui_out::field_signed): Rename from field_int.
3754         Change type of "value".
3755         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3756         type of "value".
3757         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3758         do_field_int.  Change type of "value".
3759         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3760         do_field_int.  Change type of "value".
3761         * tracepoint.c (trace_status_mi, tfind_1)
3762         (print_one_static_tracepoint_marker): Update.
3763         * thread.c (print_thread_info_1, print_selected_thread_frame):
3764         Update.
3765         * stack.c (print_frame, print_frame_info): Update.
3766         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3767         Update.
3768         * source.c (print_source_lines_base): Update.
3769         * skip.c (info_skip_command): Update.
3770         * record-btrace.c (btrace_ui_out_decode_error)
3771         (btrace_call_history_src_line): Update.
3772         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3773         Update.
3774         * progspace.c (print_program_space): Update.
3775         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3776         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3777         do_field_int.  Change type of "value".
3778         * mi/mi-out.c (mi_ui_out::do_table_begin)
3779         (mi_ui_out::do_table_header): Update.
3780         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3781         type of "value".
3782         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3783         (mi_cmd_data_list_changed_registers, output_register)
3784         (mi_cmd_data_read_memory, mi_load_progress)
3785         (mi_cmd_trace_frame_collected): Update.
3786         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3787         Update.
3788         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3789         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3790         (mi_cmd_var_list_children, varobj_update_one): Update.
3791         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3792         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3794         * inferior.c (print_inferior): Update.
3795         * gdb_bfd.c (print_one_bfd): Update.
3796         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3797         Update.
3798         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3799         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3800         do_field_int.  Change type of "value".
3801         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3802         do_field_int.  Change type of "value".
3803         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3804         (print_one_breakpoint_location, print_it_catch_fork)
3805         (print_one_catch_fork, print_it_catch_vfork)
3806         (print_one_catch_vfork, print_it_catch_solib)
3807         (print_it_catch_exec, print_it_ranged_breakpoint)
3808         (print_mention_watchpoint, print_mention_masked_watchpoint)
3809         (bkpt_print_it, update_static_tracepoint): Update.
3810         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3811         * break-catch-syscall.c (print_it_catch_syscall): Update.
3812         * ada-tasks.c (print_ada_task_info): Update.
3813         * ada-lang.c (print_it_exception, print_mention_exception):
3814         Update.
3815
3816 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         PR breakpoints/24541
3819         * gdbarch.c: Regenerate.
3820         * gdbarch.h: Regenerate.
3821         * gdbarch.sh: Adjust return type and parameter types for
3822         'stap_adjust_register'.
3823         (i386_stap_adjust_register): Adjust signature and return new
3824         register name.
3825         * stap-probe.c (stap_parse_register_operand): Adjust use of
3826         'gdbarch_stap_adjust_register'.
3827
3828 2019-07-17  Tom Tromey  <tromey@adacore.com>
3829
3830         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3831         declare VEC.
3832         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3833         std::vector.
3834         (struct s390_process_info): Add initializers.
3835         (s390_add_process): Use new.
3836         (s390_linux_nat_target::low_forget_process): Use delete.
3837         (s390_linux_nat_target::low_new_fork)
3838         (s390_linux_nat_target::stopped_by_watchpoint)
3839         (s390_linux_nat_target::low_prepare_to_resume)
3840         (s390_linux_nat_target::insert_watchpoint)
3841         (s390_linux_nat_target::insert_hw_breakpoint)
3842         (s390_linux_nat_target::remove_watchpoint)
3843         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3844
3845 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3846
3847         * aarch64-fbsd-nat.c: Include regcache.h.
3848         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3849         argument.
3850         (aarch64_fbsd_nat_target::fetch_registers)
3851         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3852         variable.
3853         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3854
3855 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3856
3857         * fbsd-nat.c: Include gdbarch.h.
3858
3859 2019-07-15  Tom Tromey  <tromey@adacore.com>
3860
3861         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3862
3863 2019-07-15  Tom Tromey  <tromey@adacore.com>
3864
3865         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3866         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3867         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3868         * cli-out.c (cli_ui_out::do_field_int): New method.
3869         * ui-out.c (ui_out::field_unsigned): New method.
3870         * symfile.c (generic_load): Use field_unsigned.
3871         (print_transfer_performance): Likewise.
3872         * record-btrace.c (ui_out_field_uint): Remove.
3873         (btrace_call_history_insn_range, btrace_call_history): Use
3874         field_unsigned.
3875         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3876         field_unsigned.
3877         * ui-out.h (class ui_out) <field_unsigned>: New method.
3878         <do_field_unsigned>: Likewise.
3879
3880 2019-07-15  Tom Tromey  <tromey@adacore.com>
3881
3882         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3883         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3884         * target.c (flash_erase_command): Use field_string.
3885         * infrun.c (print_signal_received_reason): Use field_string.
3886         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3887         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3888         field_string.
3889         * ada-tasks.c (print_ada_task_info): Use field_string.
3890
3891 2019-07-15  Tom Tromey  <tromey@adacore.com>
3892
3893         * target.c (flash_erase_command): Use field_core_addr.
3894         * symfile.c (generic_load): Use field_core_addr.
3895         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3896         Use field_core_addr.
3897         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3898         field_core_addr.
3899
3900 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3903         value if its desired type is smaller than a CORE_ADDR and signed.
3904
3905 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3908         of changes to field names, and use new is_reference field to
3909         decide if a property is a reference or not.
3910         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3911         field.
3912         (struct dwarf2_property_baton): Update header comment, rename
3913         'referenced_type' to 'property_type' and update comments.
3914         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3915         default property type, store in property baton, update to take
3916         accound of renamed field.
3917         (read_func_scope): Update call to attr_to_dynamic_prop.
3918         (read_array_type): Likewise.
3919         (dwarf2_per_cu_addr_sized_int_type): New function.
3920         (read_subrange_index_type): Move type finding code to
3921         dwarf2_per_cu_addr_sized_int_type.
3922         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3923         (dwarf2_per_cu_addr_type): New function.
3924         (set_die_type): Update calls to attr_to_dynamic_prop.
3925
3926 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * dwarf2read.c (read_subrange_index_type): New function.
3929         (read_subrange_type): Move code into new function and call it.
3930         * gdbtypes.c (create_range_type): Add some asserts.
3931
3932 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3933
3934         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3935         update return statements.
3936         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3937         declaration, and update comment to match.
3938         * gdbtypes.c (resolve_dynamic_array): Update call to
3939         dwarf2_evaluate_property to match new return type.
3940
3941 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * valarith.c (value_subscripted_rvalue): Change lowerbound
3944         parameter type from int to LONGEST.
3945         * value.h (value_subscripted_rvalue): Likewise in declaration.
3946
3947 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * cli/cli-utils.c (info_print_command_completer): New function.
3950         * cli/cli-utils.h: Add 'completer.h' include, and forward
3951         declaration for 'struct cmd_list_element'.
3952         (info_print_command_completer): Declare.
3953         * stack.c (_initialize_stack): Add completer for 'info locals' and
3954         'info args'.
3955         * symtab.c (_initialize_symtab): Add completer for 'info
3956         variables' and 'info functions'.
3957         * NEWS: Mention completion for additional info commands.
3958
3959 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * cli/cli-utils.c (extract_info_print_args): Delete.
3962         (extract_arg_maybe_quoted): Delete.
3963         (info_print_options_defs): New variable.
3964         (make_info_print_options_def_group): New function.
3965         (extract_info_print_options): Define new function.
3966         * cli/cli-utils.h (extract_info_print_args): Delete.
3967         (struct info_print_options): New structure.
3968         (extract_info_print_options): Declare new function.
3969         * stack.c (info_locals_command): Update to use new
3970         extract_info_print_options, also add a header comment.
3971         (info_args_command): Likewise.
3972         * symtab.c (info_variables_command): Likewise.
3973         (info_functions_command): Likewise.
3974
3975 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3978         to extract string arguments.
3979         * common/common-utils.c (extract_string_maybe_quoted): New function.
3980         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3981
3982 2019-07-11  Tom Tromey  <tromey@adacore.com>
3983
3984         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3985         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3986         * top.h (gdbinit): Don't declare.
3987         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3988         into...
3989         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3990         * top.c (gdb_init): Don't call init_cli_cmds.
3991         (gdbinit): Remove.
3992         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3993
3994 2019-07-11  Tom Tromey  <tromey@adacore.com>
3995
3996         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3997         after it has been moved.
3998
3999 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4000
4001         * valops.c (value_must_coerce_to_target): Change return type to
4002         bool.
4003         * value.h (value_must_coerce_to_target): Likewise.
4004
4005 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4006
4007         * breakpoint.c (is_hardware_watchpoint): Remove
4008         forward-declaration.
4009         (is_masked_watchpoint): Change return type to bool.
4010         (is_tracepoint): Likewise.
4011         (is_breakpoint): Likewise.
4012         (is_hardware_watchpoint): Likewise.
4013         (is_watchpoint): Likewise.
4014         (is_no_memory_software_watchpoint): Likewise.
4015         (is_catchpoint): Likewise.
4016         (breakpoint_1): Make FILTER parameter's return type bool.
4017         is_masked_watchpoint): Change return type to bool.
4018         (save_breakpoints): Make FILTER parameter's return type bool.
4019         * breakpoint.h (is_breakpoint): Change return type to bool.
4020         (is_watchpoint): Likewise.
4021         (is_catchpoint): Likewise.
4022         (is_tracepoint): Likewise.
4023
4024 2019-07-10  Tom Tromey  <tom@tromey.com>
4025
4026         * defs.h: Don't include gdbarch.h.
4027         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4028         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4029         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4030         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4031         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4032         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4033         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4034         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4035         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4036         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4037         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4038         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4039         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4040         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4041         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4042         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4043         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4044         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4045         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4046         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4047         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4048         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4049         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4050         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4051         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4052         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4053         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4054
4055 2019-07-10  Tom Tromey  <tromey@adacore.com>
4056
4057         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4058         * breakpoint.c (init_ada_exception_breakpoint): Register as
4059         bp_catchpoint.
4060         (print_one_breakpoint_location, print_one_breakpoint): Use
4061         is_ada_exception_catchpoint.
4062         * ada-lang.c (class ada_catchpoint_location): Pass
4063         bp_loc_software_breakpoint to bp_location constructor.
4064         (is_ada_exception_catchpoint): New function.
4065
4066 2019-07-10  Tom Tromey  <tromey@adacore.com>
4067
4068         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4069         VEC.
4070         (struct arm_exidx_entry): New method operator<.
4071         (struct arm_exidx_data) <section_maps>: Change type.
4072         (arm_exidx_data_free): Remove.
4073         (arm_exidx_data_key): Change type.  Move lower.
4074         (arm_exidx_new_objfile): Update.
4075         (arm_compare_exidx_entries): Remove.
4076         (arm_find_exidx_entry, _initialize_arm_tdep)
4077
4078 2019-07-10  Tom Tromey  <tromey@adacore.com>
4079
4080         * solib-spu.c (ocl_program_data_key): Change type.
4081         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4082         Update.
4083
4084 2019-07-10  Tom Tromey  <tromey@adacore.com>
4085
4086         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4087         (struct solib_aix_inferior_data) <library_list>: Change type.
4088         (solib_aix_inferior_data_handle): Change type.
4089         (get_solib_aix_inferior_data): Update.
4090         (solib_aix_free_library_list): Remove.
4091         (library_list_start_library): Update.
4092         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4093         return type.
4094         (solib_aix_get_library_list)
4095         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4096         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4097
4098 2019-07-10  Tom Tromey  <tromey@adacore.com>
4099
4100         * solib-dsbt.c (struct dsbt_info): Add initializers.
4101         (solib_dsbt_pspace_data): Change type.
4102         (dsbt_pspace_data_cleanup): Remove.
4103         (get_dsbt_info, _initialize_dsbt_solib): Update.
4104
4105 2019-07-10  Tom Tromey  <tromey@adacore.com>
4106
4107         * spu-tdep.c (spu_overlay_data): Change type.
4108         (spu_get_overlay_table, spu_overlay_new_objfile)
4109         (_initialize_spu_tdep): Update.
4110
4111 2019-07-10  Tom Tromey  <tromey@adacore.com>
4112
4113         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4114         destructor.
4115         (dbx_objfile_data_key): Change type and declare later.
4116         (DBX_SYMFILE_INFO): Rewrite.
4117         * dbxread.c (dbx_objfile_data_key): Change type.
4118         (dbx_symfile_init): Update.
4119         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4120         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4121         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4122
4123 2019-07-10  Tom Tromey  <tromey@adacore.com>
4124
4125         * jit.c (jit_program_space_key): Change type.  Move lower.
4126         (get_jit_program_space_data): Update.
4127         (jit_program_space_data_cleanup): Remove.
4128         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4129         Update.
4130         (struct jit_program_space_data): Add initializers.
4131
4132 2019-07-10  Tom Tromey  <tromey@adacore.com>
4133
4134         * solib-darwin.c (struct darwin_info): Add initializers.
4135         (solib_darwin_pspace_data): Change type.
4136         (darwin_pspace_data_cleanup): Remove.
4137         (get_darwin_info, _initialize_darwin_solib): Update.
4138
4139 2019-07-10  Tom Tromey  <tromey@adacore.com>
4140
4141         * remote-sim.c (struct sim_inferior_data): Add initializers,
4142         constructor, and destructor.
4143         (sim_inferior_data_key): Change type.  Move lower.
4144         (check_for_duplicate_sim_descriptor): Update.
4145         (get_sim_inferior_data): Use new.  Update.
4146         (~sim_inferior_data_cleanup): Rename from
4147         sim_inferior_data_cleanup.  Simplify.
4148         (gdbsim_close_inferior, simulator_command)
4149         (sim_command_completer, _initialize_remote_sim): Update.
4150         (next_pid, INITIAL_PID): Move earlier.
4151
4152 2019-07-10  Tom Tromey  <tromey@adacore.com>
4153
4154         * python/python-internal.h (create_thread_object): Return
4155         gdbpy_ref.
4156         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4157         * python/py-inferior.c (struct threadlist_entry): Add
4158         constructor.
4159         <thread_obj>: Now a gdbpy_ref.
4160         (thread_to_thread_object): Update.
4161         (add_thread_object): Use new.
4162         (delete_thread_object): Use delete.
4163         (infpy_threads): Update.
4164         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4165         GIL.
4166
4167 2019-07-10  Tom Tromey  <tromey@adacore.com>
4168
4169         * valops.c (value_cast): Specialize error message for Ada.
4170
4171 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4172
4173         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4174
4175 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4176
4177         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4178         bpstat_should_step): Return bool, adjust comments.
4179         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4180         bpstat_should_step): Likewise.
4181
4182 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4183
4184         * features/Makefile: Use feature target descriptions for Arm.
4185         * features/arm/arm-core.c: Generate new file.
4186         * features/arm/arm-fpa.c: Likewise.
4187         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4188         * features/arm/arm-m-profile.c: Likewise.
4189         * features/arm/arm-vfpv2.c: Likewise.
4190         * features/arm/arm-vfpv3.c: Likewise.
4191         * features/arm/xscale-iwmmxt.c: Likewise.
4192         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4193
4194 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4195
4196         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4197         ptrace earlier.
4198
4199 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * features/aarch64-pauth.c: Regenerate.
4202
4203 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4204
4205         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4206         bool.
4207         (bpstat_what): Use false instead of 0.
4208
4209 2019-07-09  Pedro Alves  <palves@redhat.com>
4210
4211         * break-catch-throw.c (is_exception_catchpoint): New.
4212         * breakpoint.c (print_one_breakpoint_location): New parameter
4213         'raw_loc'.  Handle it.  Use
4214         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4215         looking at the breakpoint's type.
4216         (print_one_breakpoint): If handling "maint info breakpoints", also
4217         print locations of exception catchpoints.
4218         * breakpoint.h (is_exception_catchpoint): Declare.
4219
4220 2019-07-09  Pedro Alves  <palves@redhat.com>
4221
4222         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4223         "addr" field.
4224         (allocate_location_exception_catchpoint): New.
4225         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4226         (initialize_throw_catchpoint_ops): Install
4227         allocate_location_exception_catchpoint as allocate_location
4228         method.
4229         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4230         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4231         bp_loc_other.
4232         (breakpoint_address_is_meaningful): Delete.
4233         (bl_address_is_meaningful): New.
4234         (breakpoint_locations_match): Adjust comment.
4235         (bp_location_from_bp_type): New, factored out of...
4236         (bp_location::bp_location(breakpoint *)): ... this.
4237         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4238         factored out of...
4239         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4240         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4241         breakpoint_address_is_meaningful.
4242         (bp_locations_compare): Adjust comment.
4243         (update_global_location_list): Use bl_address_is_meaningful
4244         instead of breakpoint_address_is_meaningful.
4245         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4246         explicit.
4247         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4248         * python/py-breakpoint.c (bppy_get_location): No longer check
4249         whether location is null.
4250
4251 2019-07-09  Pedro Alves  <palves@redhat.com>
4252
4253         PR c++/15468
4254         * breakpoint.c (print_one_breakpoint_location): Remove
4255         single-location assert.
4256
4257 2019-07-09  Tom Tromey  <tom@tromey.com>
4258
4259         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4260         * configure: Rebuild.
4261         * configure.ac: Change common to gdbsupport.
4262         * gdbsupport: Rename from common.
4263         * acinclude.m4: Change common to gdbsupport.
4264         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4265         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4266         gdbsupport.
4267         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4268         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4269         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4270         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4271         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4272         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4273         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4274         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4275         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4276         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4277         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4278         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4279         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4280         coff-pe-read.c, command.h, compile/compile-c-support.c,
4281         compile/compile-c.h, compile/compile-cplus-symbols.c,
4282         compile/compile-cplus-types.c, compile/compile-cplus.h,
4283         compile/compile-loc2c.c, compile/compile.c, completer.c,
4284         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4285         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4286         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4287         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4288         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4289         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4290         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4291         features/aarch64-core.c, features/aarch64-fpu.c,
4292         features/aarch64-pauth.c, features/aarch64-sve.c,
4293         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4294         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4295         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4296         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4297         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4298         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4299         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4300         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4301         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4302         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4303         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4304         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4305         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4306         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4307         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4308         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4309         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4310         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4311         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4312         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4313         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4314         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4315         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4316         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4317         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4318         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4319         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4320         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4321         minsyms.c, mips-linux-tdep.c, namespace.h,
4322         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4323         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4324         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4325         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4326         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4327         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4328         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4329         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4330         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4331         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4332         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4333         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4334         procfs.c, producer.c, progspace.h, psymtab.h,
4335         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4336         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4337         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4338         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4339         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4340         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4341         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4342         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4343         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4344         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4345         target-memory.c, target.c, target.h, target/waitstatus.c,
4346         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4347         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4348         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4349         unittests/array-view-selftests.c,
4350         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4351         unittests/common-utils-selftests.c,
4352         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4353         unittests/format_pieces-selftests.c,
4354         unittests/function-view-selftests.c,
4355         unittests/lookup_name_info-selftests.c,
4356         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4357         unittests/mkdir-recursive-selftests.c,
4358         unittests/observable-selftests.c,
4359         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4360         unittests/parse-connection-spec-selftests.c,
4361         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4362         unittests/scoped_fd-selftests.c,
4363         unittests/scoped_mmap-selftests.c,
4364         unittests/scoped_restore-selftests.c,
4365         unittests/string_view-selftests.c, unittests/style-selftests.c,
4366         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4367         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4368         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4369         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4370         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4371         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4372
4373 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4376         bool value.
4377         (decode_digits_ordinary): Set explicit_line field in sal.
4378         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4379         symtab_and_line that was set on an explicit line number in
4380         assembler code.  Do always update the recorded symtab and line if
4381         we do skip the prologue.
4382
4383 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * breakpoint.c (set_breakpoint_location_function): Remove
4386         explicit_loc parameter.
4387         (momentary_breakpoint_from_master): Update call to
4388         set_breakpoint_location_function.
4389         (add_location_to_breakpoint): Likewise.
4390
4391 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4394         required features based on default bfd type when no specific bfd
4395         is present.
4396
4397 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4398
4399         * NEWS: Mention that GDB printf and eval commands can now print
4400         C-style and Ada-style convenience var strings without
4401         calling the inferior.
4402         * printcmd.c (printf_c_string): Locally print GDB internal var
4403         instead of transiting via the inferior.
4404         (printf_wide_c_string): Likewise.
4405
4406 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4407
4408         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4409
4410 2019-07-04  Tom Tromey  <tom@tromey.com>
4411
4412         PR tui/24724:
4413         * tui/tui-winsource.c (tui_clear_source_content): Update.
4414         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4415         (tui_update_breakpoint_info): Update.
4416         (tui_set_exec_info_content): Update.
4417         * tui/tui-source.c (tui_set_source_content_nil): Update.
4418         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4419         has_break.
4420         * tui/tui-data.h (enum tui_bp_flag): New.
4421         (tui_bp_flags): New enum flags type.
4422         (struct tui_source_element) <break_mode>: Change type.  Rename
4423         from has_break.
4424         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4425         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4426         constants.
4427         * tui/tui-winsource.h: Fix comment.
4428
4429 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4430
4431         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4432         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4433         (store_fpregs_to_thread)
4434         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4435         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4436         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4437         (IWMMXT_REGS_SIZE): Add define.
4438         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4439         (fetch_vfp_regs, store_vfp_regs)
4440         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4441         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4442
4443 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4444
4445         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4446         defines.
4447         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4448         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4449         (ARM_INT_REGISTER_SIZE): ...to this.
4450         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4451         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4452         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4453         (arm_linux_collect_gregset, supply_nwfpe_register)
4454         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4455         defines.
4456         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4457         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4458         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4459         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4460         (arm_return_in_memory, arm_store_return_value)
4461         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4462         (arm_record_ld_st_multiple): Likewise.
4463         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4464         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4465
4466 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4467
4468         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4469         AARCH64_DISPLACED_MODIFIED_INSNS.
4470         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4471         (aarch64_displaced_step_copy_insn): Likewise.
4472         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4473         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4474         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4475         ARM_DISPLACED_MODIFIED_INSNS.
4476         * arm-tdep.c (arm_gdbarch_init): Likewise.
4477         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4478         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4479         (struct arm_displaced_step_closure): Use
4480         ARM_DISPLACED_MODIFIED_INSNS.
4481
4482 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4483
4484         * features/Makefile: Remove unused xml files.
4485         * features/aarch64.xml: Remove.
4486         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4487         * features/i386/amd64-avx-avx512.xml: Remove.
4488         * features/i386/amd64-avx-linux.xml: Remove.
4489         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4490         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4491         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4492         * features/i386/amd64-avx-mpx.xml: Remove.
4493         * features/i386/amd64-avx.xml: Remove.
4494         * features/i386/amd64-linux.xml: Remove.
4495         * features/i386/amd64-mpx-linux.xml: Remove.
4496         * features/i386/amd64-mpx.xml: Remove.
4497         * features/i386/amd64.xml: Remove.
4498         * features/i386/i386-avx-avx512-linux.xml: Remove.
4499         * features/i386/i386-avx-avx512.xml: Remove.
4500         * features/i386/i386-avx-linux.xml: Remove.
4501         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4502         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4503         * features/i386/i386-avx-mpx-linux.xml: Remove.
4504         * features/i386/i386-avx-mpx.xml: Remove.
4505         * features/i386/i386-avx.xml: Remove.
4506         * features/i386/i386-linux.xml: Remove.
4507         * features/i386/i386-mmx-linux.xml: Remove.
4508         * features/i386/i386-mmx.xml: Remove.
4509         * features/i386/i386-mpx-linux.xml: Remove.
4510         * features/i386/i386-mpx.xml: Remove.
4511         * features/i386/i386.xml: Remove.
4512         * features/i386/x32-avx-avx512-linux.xml: Remove.
4513         * features/i386/x32-avx-linux.xml: Remove.
4514         * features/i386/x32-linux.xml: Remove.
4515
4516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4517
4518         * regformats/aarch64.dat: Remove.
4519         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4520         * regformats/i386/amd64-avx-linux.dat: Remove.
4521         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4522         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4523         * regformats/i386/amd64-linux.dat: Remove.
4524         * regformats/i386/amd64-mpx-linux.dat: Remove.
4525         * regformats/i386/amd64.dat: Remove.
4526         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4527         * regformats/i386/i386-avx-linux.dat: Remove.
4528         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4529         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4530         * regformats/i386/i386-linux.dat: Remove.
4531         * regformats/i386/i386-mmx-linux.dat: Remove.
4532         * regformats/i386/i386-mpx-linux.dat: Remove.
4533         * regformats/i386/i386.dat: Remove.
4534         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4535         * regformats/i386/x32-avx-linux.dat: Remove.
4536         * regformats/i386/x32-linux.dat: Remove.
4537
4538 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4539
4540         * aarch64-tdep.c: Remove xml self tests.
4541         * amd64-linux-tdep.c: Likewise.
4542         * amd64-tdep.c: Likewise.
4543         * i386-linux-tdep.c: Likewise.
4544         * i386-tdep.c: Likewise.
4545
4546 2019-07-03  Pedro Alves  <palves@redhat.com>
4547
4548         PR cli/24732
4549         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4550         (pipe_cmd_option_defs): New.
4551         (make_pipe_cmd_options_def_group): New.
4552         (pipe_command): Use gdb::option::process_options.
4553         (pipe_command_completer): New function.
4554         (_initialize_cli_cmds): Install completer for "pipe" command.
4555
4556 2019-07-03  Pedro Alves  <palves@redhat.com>
4557
4558         * cli/cli-option.c (union option_value) <string>: New field.
4559         (struct option_def_and_value): Add ctor, move ctor, dtor and
4560         use DISABLE_COPY_AND_ASSIGN.
4561         (option_def_and_value::clear_value): New.
4562         (parse_option, save_option_value_in_ctx, get_val_type_str)
4563         (add_setshow_cmds_for_options): Handle var_string.
4564         * cli-option.h (union option_def::var_address) <string>: New
4565         field.
4566         (struct string_option_def): New.
4567         * maint-test-options.c (struct test_options_opts): Add default
4568         ctor and use DISABLE_COPY_AND_ASSIGN.
4569         <string_opt>: New field.
4570         (test_options_opts::~test_options_opts): New.
4571         (test_options_opts::dump): Also dump "-string".
4572         (test_options_option_defs): Install "string.
4573
4574 2019-07-03  Pedro Alves  <palves@redhat.com>
4575
4576         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4577         option_value with a null enumeration.
4578         (complete_options): Save the option values in the context.
4579         (save_option_value_in_ctx): New, factored out from ...
4580         (process_options): ... here.
4581         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4582         of the function.
4583         * maint-test-options.c (test_options_opts::dump): New, factored
4584         out from ...
4585         (maintenance_test_options_command_mode): ... here.
4586         (maintenance_test_options_command_completion_result): Delete.
4587         (maintenance_test_options_command_completion_text): Update
4588         comment.
4589         (maintenance_show_test_options_completion_result): Change
4590         prototype.  Just print
4591         maintenance_test_options_command_completion_text.
4592         (save_completion_result): New.
4593         (maintenance_test_options_completer_mode): Pass options context to
4594         complete_options, and then save a dump.
4595         (_initialize_maint_test_options): Use add_cmd to install "maint
4596         show test-options-completion-result".
4597
4598 2019-07-03  Pedro Alves  <palves@redhat.com>
4599
4600         * NEWS (New commands): Mention "with" and "maint with".
4601         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4602         (with_command, with_command_completer): New.
4603         (pipe_command): Adjust to new repeat_previous
4604         interface.
4605         (_initialize_cli_cmds): Install the "with" command and its "w"
4606         alias.
4607         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4608         declarations.
4609         * cli/cli-setshow.c (parse_cli_var_uinteger)
4610         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4611         argument strings for all var_types.
4612         (get_setshow_command_value_string): New, factored out from ...
4613         (do_show_command): ... this.
4614         * cli/cli-setshow.h: Include <string>.
4615         (get_setshow_command_value_string): Declare.
4616         * command.h (repeat_previous): Now returns const char *.  Adjust
4617         comment.
4618         * maint.c: Include "cli/cli-cmds.h".
4619         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4620         (_initialize_maint_cmds): Register the "maintenance with" command.
4621         * top.c (repeat_previous): Move bits from pipe_command here:
4622         Return the saved command line, if any; error out if there's no
4623         command to relaunch.
4624
4625 2019-07-03  Pedro Alves  <palves@redhat.com>
4626
4627         * NEWS (New commands): Mention "maint set/show test-settings"
4628         instead of "maint test-settings".
4629         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4630         (maintenance_test_settings_set_list): Rename to ...
4631         (maintenance_set_test_settings_list): ... this.
4632         (maintenance_test_settings_show_list): Rename to  ...
4633         (maintenance_show_test_settings_list): ... this.
4634         (maintenance_test_settings_cmd): Delete.
4635         (maintenance_test_settings_set_cmd): ...
4636         (maintenance_set_test_settings_cmd): ... this.
4637         (maintenance_test_settings_show_cmd): ...
4638         (maintenance_show_test_settings_cmd): ... this.
4639         (maintenance_test_settings_show_value_cmd):
4640         (maintenance_show_test_settings_value_cmd): ... this.
4641         (_initialize_maint_test_settings): No longer install the "maint
4642         test-settings" prefix command.  Rename "maint test-settings set"
4643         to "maint set test-settings", and "maint test-settings show" to
4644         "maint show test-settings".  Adjust all subcommands.
4645
4646 2019-07-03  Pedro Alves  <palves@redhat.com>
4647
4648         * maint-test-settings.c: Fix file's intro comment.  Replace all
4649         references to "test-options" with references to "test-settings",
4650         in comments.
4651
4652 2019-07-03  Pedro Alves  <palves@redhat.com>
4653
4654         * maint-test-settings.c (maintenance_test_settings_xxx)
4655         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4656         New.
4657         (maintenance_test_settings_enums): Use them.
4658         (maintenance_test_settings_enum): Default to
4659         maintenance_test_settings_xxx.
4660         (_initialize_maint_test_settings): Initialize
4661         MAINTENANCE_TEST_SETTINGS_FILENAME.
4662
4663 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4664
4665         * breakpoint.h (remove_breakpoints_inf): Change return type to
4666         void, move function documentation here.
4667         * breakpoint.c (remove_breakpoints_inf): Change return type to
4668         void, move function documentation to header.
4669
4670 2019-07-02  Pedro Alves  <palves@redhat.com>
4671
4672         * NEWS (Completion improvements): Mention "info threads".
4673         * thread.c (struct info_threads_opts, info_threads_option_defs)
4674         (make_info_threads_options_def_group): New.
4675         (info_threads_command): Use gdb::option::process_options.
4676         (info_threads_command_completer): New.
4677         (_initialize_thread): Use gdb::option::build_help to build the
4678         help text for "info threads".
4679
4680 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4681
4682         * defs.h (generic_load): Move from here...
4683         * symfile.h (generic_load): ... to here.  Rename name parameter
4684         to args.
4685         * symfile.c (generic_load): Add comment.
4686
4687 2019-07-01  Tom Tromey  <tromey@adacore.com>
4688
4689         * dwarf2read.c
4690         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4691         declaration of without_params.  Fix formatting.
4692
4693 2019-07-01  Tom Tromey  <tromey@adacore.com>
4694
4695         * ada-exp.y (find_primitive_type): Update.
4696         * ada-lang.h (ada_lookup_symbol): Update.
4697         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4698         parameter.
4699         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4700
4701 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4702
4703         PR breakpoints/24541
4704         * gdbarch.c: Regenerate.
4705         * gdbarch.h: Regenerate.
4706         * gdbarch.sh: Add 'stap_adjust_register'.
4707         * i386-tdep.c: Include '<unordered_set>'.
4708         (i386_stap_adjust_register): New function.
4709         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4710         * stap-probe.c (stap_parse_register_operand): Call
4711         'gdbarch_stap_adjust_register'.
4712
4713 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4714
4715         PR python/24742
4716         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4717         * python/python.c (do_start_initialization): Use 'xmalloc'
4718         instead of 'PyMem_Malloc'.
4719
4720 2019-06-28  Tom Tromey  <tromey@adacore.com>
4721
4722         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4723         for Ada.
4724
4725 2019-06-27  Tom Tromey  <tromey@adacore.com>
4726
4727         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4728         objfile_key.
4729         (arm_find_mapping_symbol, arm_record_special_symbol)
4730         (_initialize_arm_tdep): Update.
4731         (arm_objfile_data_free): Remove.
4732
4733 2019-06-27  Tom Tromey  <tromey@adacore.com>
4734
4735         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4736         to cp_print_static_field.
4737
4738 2019-06-26  Tom Tromey  <tromey@adacore.com>
4739
4740         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4741         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4742         declare.
4743
4744 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4745
4746         * features/aarch64-core.c (create_feature_aarch64_core):
4747         Regenerate.
4748         * features/aarch64-core.xml: Add cpsr flags.
4749
4750 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4751
4752         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4753         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4754
4755 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4756
4757         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4758         field.
4759         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4760         use.
4761         (arm_record_special_symbol): Don't insert new symbol in sorted
4762         position, push it at the end.
4763
4764 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4765
4766         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4767         (arm_mapping_symbol_s): Remove.
4768         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4769         (arm_mapping_symbol_vec): New typedef.
4770         (struct arm_per_objfile): Add constructor.
4771         <section_maps>: Change type to
4772         std::unique_ptr<arm_mapping_symbol_vec[]>.
4773         (arm_compare_mapping_symbols): Remove.
4774         (arm_find_mapping_symbol): Adjust to section_maps type change.
4775         (arm_objfile_data_free): Call delete on arm_per_objfile.
4776         (arm_record_special_symbol): Adjust to section_maps type change.
4777         Allocate arm_per_objfile with new.
4778
4779 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4780
4781         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4782         with the command prefix.
4783
4784 2019-06-25  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4787         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4788
4789 2019-06-25  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4792         type.
4793         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4794         protected.
4795
4796 2019-06-25  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-winsource.c
4799         (tui_source_window_base::set_is_exec_point_at): Add check against
4800         LOA_ADDRESS.
4801
4802 2019-06-25  Tom Tromey  <tom@tromey.com>
4803
4804         * tui/tui-source.c (tui_set_source_content): Don't check before
4805         xfree.
4806         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4807
4808 2019-06-25  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-winsource.h (tui_update_source_window_as_is)
4811         (tui_alloc_source_buffer, tui_line_is_displayed)
4812         (tui_addr_is_displayed): Change type of win_info.
4813         * tui/tui-winsource.c (tui_update_source_window_as_is)
4814         (tui_clear_source_content, tui_show_source_line)
4815         (tui_show_source_content, tui_source_window_base::refill)
4816         (tui_source_window_base::set_is_exec_point_at)
4817         (tui_source_window_base::set_is_exec_point_at)
4818         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4819         (tui_alloc_source_buffer, tui_line_is_displayed)
4820         (tui_addr_is_displayed): Change type of win_info.  Update.
4821         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4822         (tui_source_window_base::do_make_visible_with_new_height):
4823         Update.
4824         * tui/tui-source.c (tui_set_source_content)
4825         (tui_set_source_content_nil)
4826         (tui_source_window::do_scroll_vertical): Update.
4827         * tui/tui-layout.c (show_layout): Update.
4828         * tui/tui-disasm.c (tui_set_disassem_content)
4829         (tui_disasm_window::do_scroll_vertical): Update.
4830         * tui/tui-data.h (tui_win_content): Remove.
4831         (struct tui_gen_win_info) <content, content_size>: Remove.
4832         (struct tui_source_element): Add initializers and destructor.
4833         (union tui_which_element, struct tui_win_element): Remove.
4834         (struct tui_source_window_base) <content>: New field.
4835         (struct tui_data_window): Remove destructor.
4836         (tui_alloc_content, tui_free_win_content)
4837         (tui_free_all_source_wins_content): Don't declare.
4838         * tui/tui-data.c (tui_initialize_static_data): Update.
4839         (init_content_element, tui_alloc_content): Remove.
4840         (~tui_gen_win_info): Update.
4841         (~tui_data_window, tui_free_all_source_wins_content)
4842         (tui_free_win_content, free_content, free_content_elements):
4843         Remove.
4844
4845 2019-06-25  Tom Tromey  <tom@tromey.com>
4846
4847         * tui/tui-winsource.h (tui_clear_source_content)
4848         (tui_erase_source_content, tui_show_source_content): Change type
4849         of win_info.
4850         * tui/tui-winsource.c (tui_clear_source_content)
4851         (tui_erase_source_content, tui_show_source_content): Change type
4852         of win_info.
4853         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4854         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4855         win_info.
4856         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4857         win_info.
4858         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4859
4860 2019-06-25  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-winsource.c (tui_clear_source_content)
4863         (tui_source_window_base::set_is_exec_point_at): Update.
4864         * tui/tui-source.c (tui_set_source_content_nil): Update.
4865         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4866         a bool.
4867         * tui/tui-data.c (init_content_element): Update.
4868
4869 2019-06-25  Tom Tromey  <tom@tromey.com>
4870
4871         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4872         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4873         * tui/tui-layout.c (init_and_make_win): Update.
4874         * tui/tui.h (enum tui_win_type): Update.
4875         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4876         tui_win_is_auxillary.
4877         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4878         tui_win_is_auxillary.
4879
4880 2019-06-25  Tom Tromey  <tom@tromey.com>
4881
4882         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4883         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4884         (tui_delete_data_content_windows, tui_display_all_data)
4885         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4886         Update.
4887         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4888         * tui/tui-regs.c (tui_last_regs_line_no)
4889         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4890         (tui_show_registers): Update.
4891         (tui_show_register_group): Return void.  Update.
4892         (tui_display_registers_from, tui_display_reg_element_at_line)
4893         (tui_display_registers_from_line, tui_check_register_values):
4894         Update.
4895         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4896         member.
4897         (struct tui_data_window) <regs_content>: Now a std::vector.
4898         <regs_content_count>: Remove.
4899         (tui_add_content_elements, tui_free_data_content): Don't declare.
4900         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4901         (init_content_element): Remove DATA_WIN case.  Add assert.
4902         (tui_add_content_elements): Remove.
4903         (tui_data_window): Update.
4904         (tui_free_data_content): Remove.
4905         (free_content_elements): Remove DATA_WIN case.
4906
4907 2019-06-25  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-data.c (tui_data_item_window): Update.
4910         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4911         * tui/tui-windata.c (tui_display_all_data)
4912         (tui_display_data_from_line): Update.
4913         (tui_check_data_values): Remove.
4914         * tui/tui-regs.c (tui_show_register_group)
4915         (tui_display_reg_element_at_line): Update.
4916         * tui/tui-hooks.c (tui_register_changed)
4917         (tui_refresh_frame_and_register_information): Call
4918         tui_check_register_values.
4919         * tui/tui-data.h (struct tui_data_window) <data_content,
4920         data_content_count, data_type>: Remove.
4921         (enum tui_data_type): Remove.
4922
4923         * tui/tui-data.c (tui_data_window::clear_detail)
4924         (~tui_data_window): Update.
4925
4926 2019-06-25  Tom Tromey  <tom@tromey.com>
4927
4928         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4929         declare.
4930         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4931         Rename from tui_first_data_item_displayed.  Update.
4932         (tui_data_window::refresh_all)
4933         (tui_data_window::do_scroll_vertical): Update.
4934         * tui/tui-data.h (struct tui_data_window)
4935         <first_data_item_displayed>: Declare new method.
4936
4937 2019-06-25  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4940         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4941         contents...
4942         (tui_initialize_static_data): ...here.
4943
4944 2019-06-25  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4947         (tui_display_registers_from, tui_check_register_values): Update.
4948         (tui_display_register): Remove win_info parameter; update.
4949         (tui_get_register): Change type of parameters.
4950         * tui/tui-data.h (struct tui_data_element): Remove.
4951         (union tui_which_element) <data>: Remove.
4952         <data_window>: Change type.
4953         (struct tui_data_item_window): New.
4954         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4955         case.  Add assert.
4956         (~tui_data_item_window): New destructor.
4957         (free_content_elements): Remove DATA_ITEM_WIN case.
4958
4959 2019-06-25  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4962         Remove.
4963
4964 2019-06-25  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-data.h (struct tui_command_element): Remove.
4967         (union tui_which_element) <command>: Remove.
4968         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4969         assert.
4970         (free_content_elements): Remove CMD_WIN case.
4971
4972 2019-06-25  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-layout.c (tui_set_layout): Update.
4975         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4976         * tui/tui-data.c (layout_def): Update.
4977
4978 2019-06-25  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4981         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4982         (tui_source_window_base::set_new_height): Update.
4983         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4984         Update.
4985         (tui_set_locator_fullname, tui_set_locator_info)
4986         (tui_show_frame_info): Update.
4987         * tui/tui-source.c (tui_set_source_content)
4988         (tui_source_is_displayed): Update.
4989         * tui/tui-layout.c (show_source_disasm_command, show_data)
4990         (show_source_or_disasm_and_command): Update.
4991         * tui/tui-disasm.c (tui_set_disassem_content)
4992         (tui_get_begin_asm_address): Update.
4993         * tui/tui-data.h (struct tui_locator_element): Remove.
4994         (union tui_which_element) <locator>: Remove.
4995         (struct tui_locator_window): New.
4996         (tui_locator_win_info_ptr): Change return type.
4997         * tui/tui-data.c (_locator): Change type.
4998         (tui_locator_win_info_ptr): Change return type.
4999         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5000         (tui_alloc_content): Add assert.
5001
5002 2019-06-25  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-winsource.c
5005         (tui_exec_info_window::maybe_allocate_content): New method.
5006         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5007         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5008         (make_source_or_disasm_window): Add cast.
5009         * tui/tui-data.h (union tui_which_element) <simple_string>:
5010         Remove.
5011         (struct tui_source_info): New.
5012         (struct tui_source_window_base) <execution_info>: Change type.
5013         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5014         case, and add assert.
5015         (tui_alloc_content): Add assert.
5016
5017 2019-06-25  Tom Tromey  <tom@tromey.com>
5018
5019         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5020         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5021         * tui/tui-data.c (tui_alloc_win_info): Remove.
5022
5023 2019-06-25  Tom Tromey  <tom@tromey.com>
5024
5025         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5026         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5027         can_highlight.
5028
5029 2019-06-25  Tom Tromey  <tom@tromey.com>
5030
5031         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5032         make_visible_with_new_height method.
5033         (tui_win_info::make_visible_with_new_height): New method.
5034         (tui_source_window_base::do_make_visible_with_new_height)
5035         (tui_data_window::do_make_visible_with_new_height)
5036         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5037         (make_visible_with_new_height): Remove.
5038         (tui_resize_all, tui_adjust_win_heights): Use
5039         make_visible_with_new_height method.
5040         * tui/tui-data.h (struct tui_win_info)
5041         <do_make_visible_with_new_height, make_visible_with_new_height>:
5042         New methods.
5043         (struct tui_source_window_base, struct tui_data_window)
5044         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5045         methods.
5046
5047 2019-06-25  Tom Tromey  <tom@tromey.com>
5048
5049         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5050         method.
5051         (update_tab_width): Call update_tab_width method.
5052         * tui/tui-data.h (struct tui_win_info)
5053         (struct tui_source_window_base) <update_tab_width>: New methods.
5054
5055 2019-06-25  Tom Tromey  <tom@tromey.com>
5056
5057         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5058         parameter.
5059         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5060         parameter.
5061         (tui_gen_win_info::make_visible): Update.
5062         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5063         parameter.
5064         * tui/tui-data.h (enum tui_box): New enum.
5065         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5066
5067 2019-06-25  Tom Tromey  <tom@tromey.com>
5068
5069         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5070         init_and_make_win for EXEC_INFO_WIN.
5071         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5072         longer inline.
5073         (struct tui_win_info) <~tui_win_info>: Inline.
5074         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5075         Don't declare.
5076         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5077         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5078         Remove.
5079         (tui_initialize_static_data): Update.
5080         (~tui_gen_win_info): Handle more cleanup here.
5081         (~tui_source_window_base): Delete "execution_info".
5082         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5083
5084 2019-06-25  Tom Tromey  <tom@tromey.com>
5085
5086         * tui/tui-layout.c (make_command_window): Don't set
5087         can_highlight.
5088         (show_source_disasm_command): Call the reset method.
5089         (show_data): Don't set can_highlight.  Call the reset method.
5090         (tui_gen_win_info::reset): Rename from init_gen_win_info
5091         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5092         (show_source_or_disasm_and_command): Call the reset method.
5093         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5094         (struct tui_cmd_window): Set can_highlight.
5095
5096 2019-06-25  Tom Tromey  <tom@tromey.com>
5097
5098         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5099         from make_visible.
5100         (tui_make_visible, tui_make_invisible): Rewrite.
5101         (tui_win_info::make_visible): Remove.
5102         (tui_source_window_base::make_visible): Update.
5103         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5104         method.  Moved from...
5105         (struct tui_win_info) <make_visible>: ...here.
5106
5107 2019-06-25  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-winsource.c
5110         (tui_source_window_base::do_scroll_horizontal): Remove direction
5111         parameter.
5112         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5113         direction parameter.
5114         * tui/tui-win.c (tui_win_info::forward_scroll)
5115         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5116         (tui_win_info::right_scroll): Update.
5117         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5118         direction parameter.
5119         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5120         direction parameter.
5121         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5122         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5123         Remove direction parameter.
5124         (struct tui_source_window_base, struct tui_source_window)
5125         (struct tui_disasm_window, struct tui_data_window)
5126         (struct tui_cmd_window): Update.
5127
5128 2019-06-25  Tom Tromey  <tom@tromey.com>
5129
5130         * tui/tui-winsource.h (tui_set_exec_info_content)
5131         (tui_show_exec_info_content, tui_erase_exec_info_content)
5132         (tui_clear_exec_info_content, tui_update_exec_info): Change
5133         argument to tui_source_window_base.
5134         * tui/tui-winsource.c (tui_set_exec_info_content)
5135         (tui_show_exec_info_content, tui_erase_exec_info_content)
5136         (tui_clear_exec_info_content, tui_update_exec_info): Change
5137         argument to tui_source_window_base.
5138
5139 2019-06-25  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5142         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5143
5144 2019-06-25  Tom Tromey  <tom@tromey.com>
5145
5146         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5147         check.
5148
5149 2019-06-25  Tom Tromey  <tom@tromey.com>
5150
5151         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5152         type to void.
5153         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5154         type to void.
5155         * tui/tui-source.c (tui_set_source_content): Update.
5156         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5157
5158 2019-06-25  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-win.c (window_name_completer, tui_set_focus)
5161         (tui_all_windows_info): Use name method.
5162         * tui/tui-data.h (struct tui_gen_win_info)
5163         (struct tui_source_window, struct tui_disasm_window)
5164         (struct tui_data_window, struct tui_cmd_window) <name>: New
5165         method.
5166         (tui_win_name): Don't declare.
5167         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5168         (tui_win_name): Remove.
5169
5170 2019-06-25  Tom Tromey  <tom@tromey.com>
5171
5172         * tui/tui-winsource.h (tui_update_source_window)
5173         (tui_update_source_window_as_is): Change parameter type.
5174         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5175         to be a tui_source_window_base.
5176         (tui_update_source_window_as_is): Likewise.
5177         * tui/tui-win.c (make_visible_with_new_height): Update.
5178
5179 2019-06-25  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui-winsource.c (tui_erase_source_content)
5182         (tui_show_source_content, tui_show_exec_info_content)
5183         (tui_erase_exec_info_content): Use refresh_window method.
5184         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5185         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5186         from tui_refresh_win.
5187         (tui_data_window::refresh_window): New method.
5188         (tui_win_info::refresh, tui_source_window_base::refresh)
5189         (tui_refresh_all): Use refresh_window method.
5190         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5191         method.
5192         * tui/tui-regs.c (tui_display_register): Call refresh_window
5193         method.
5194         * tui/tui-layout.c (show_source_disasm_command)
5195         (show_source_or_disasm_and_command): Call refresh_window method.
5196         * tui/tui-data.h (struct tui_gen_win_info)
5197         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5198         New method.
5199
5200 2019-06-25  Tom Tromey  <tom@tromey.com>
5201
5202         * tui/tui.c (tui_rl_other_window, tui_enable)
5203         (tui_is_window_visible, tui_get_command_dimension): Update.
5204         * tui/tui-winsource.c (tui_update_source_window_as_is)
5205         (tui_clear_source_content, tui_erase_source_content)
5206         (tui_show_source_line, tui_source_window_base::refill)
5207         (tui_source_window_base::do_scroll_horizontal)
5208         (tui_source_window_base::set_is_exec_point_at)
5209         (tui_update_breakpoint_info, tui_set_exec_info_content)
5210         (tui_alloc_source_buffer, tui_line_is_displayed)
5211         (tui_addr_is_displayed): Update.
5212         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5213         (tui_check_and_display_highlight_if_needed)
5214         (tui_win_info::make_visible, tui_win_info::refresh)
5215         (tui_refresh_all): Update.
5216         * tui/tui-windata.c (tui_first_data_item_displayed)
5217         (tui_delete_data_content_windows, tui_erase_data_content)
5218         (tui_display_all_data, tui_data_window::refresh_all)
5219         (tui_check_data_values): Update.
5220         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5221         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5222         (tui_win_info::backward_scroll, tui_refresh_all_win)
5223         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5224         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5225         (tui_source_window_base::set_new_height)
5226         (tui_data_window::set_new_height)
5227         (make_invisible_and_set_new_height)
5228         (make_visible_with_new_height, new_height_ok)
5229         (parse_scrolling_args): Update.
5230         * tui/tui-stack.c (tui_show_frame_info): Update.
5231         * tui/tui-source.c (tui_set_source_content)
5232         (tui_set_source_content_nil, tui_source_is_displayed)
5233         (tui_source_window::do_scroll_vertical): Update.
5234         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5235         (tui_display_registers_from, tui_display_reg_element_at_line)
5236         (tui_check_register_values, tui_reg_command): Update.
5237         * tui/tui-layout.c (tui_default_win_height)
5238         (show_source_disasm_command, show_data, init_and_make_win)
5239         (show_source_or_disasm_and_command): Update.
5240         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5241         (tui_redisplay_readline, tui_mld_flush)
5242         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5243         (tui_getc): Update.
5244         * tui/tui-disasm.c (tui_set_disassem_content)
5245         (tui_disasm_window::do_scroll_vertical): Update.
5246         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5247         Now virtual.
5248         (struct tui_win_info): Derive from tui_gen_win_info.
5249         <~tui_win_info>: Mark as override.
5250         <generic>: Remove member.
5251         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5252         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5253         (~tui_data_window, ~tui_win_info)
5254         (tui_free_all_source_wins_content): Update.
5255         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5256
5257 2019-06-25  Tom Tromey  <tom@tromey.com>
5258
5259         * tui/tui-layout.c (init_and_make_win): Use new.
5260         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5261         destructor, initializers.
5262         (tui_alloc_generic_win_info): Don't declare.
5263         * tui/tui-data.c (_locator): Add argument to constructor.
5264         (source_win, disasm_win): New globals.
5265         (exec_info): Remove.
5266         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5267         Update.
5268         (tui_alloc_generic_win_info): Remove.
5269         (init_content_element): Use new.
5270         (tui_win_info::tui_win_info): Update.
5271         (free_content_elements) <case DATA_WIN>: Use delete.
5272
5273 2019-06-25  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5276         * tui/tui-windata.c (tui_first_data_item_displayed)
5277         (tui_delete_data_content_windows): Update.
5278         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5279         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5280         (tui_display_registers_from, tui_check_register_values): Update.
5281         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5282         pointer.
5283         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5284         window.
5285         (tui_free_data_content): Update.
5286         (free_content_elements) <case DATA_WIN>: Free the window.
5287
5288 2019-06-25  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5291         Update.
5292         * tui/tui-layout.c (make_command_window)
5293         (show_source_disasm_command, show_data, init_and_make_win)
5294         (show_source_or_disasm_and_command): Update.
5295         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5296         method.
5297         <can_highight, is_highlighted>: Now bool.
5298         (tui_set_win_highlight): Don't declare.
5299         * tui/tui-data.c (tui_set_win_highlight): Remove.
5300
5301 2019-06-25  Tom Tromey  <tom@tromey.com>
5302
5303         * tui/tui-wingeneral.c (make_visible): Remove check of window
5304         type.
5305
5306 2019-06-25  Tom Tromey  <tom@tromey.com>
5307
5308         * tui/tui-win.c (tui_win_info::max_height)
5309         (tui_cmd_window::max_height): New methods.
5310         (new_height_ok): Call max_height.
5311         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5312         <max_height>: New method.
5313
5314 2019-06-25  Tom Tromey  <tom@tromey.com>
5315
5316         * tui/tui-win.c (tui_source_window_base::set_new_height)
5317         (tui_data_window::set_new_height): New methods.
5318         (make_invisible_and_set_new_height): Call set_new_height method.
5319         * tui/tui-data.h (struct tui_win_info)
5320         (struct tui_source_window_base, struct tui_data_window)
5321         <set_new_height>: New method.
5322
5323 2019-06-25  Tom Tromey  <tom@tromey.com>
5324
5325         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5326         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5327         tui_refresh_data_win.
5328         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5329         method.
5330         (tui_refresh_all_win): Call the refresh_all method.
5331         (tui_set_focus): Likewise.
5332         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5333         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5334         Likewise.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-winsource.h (tui_refill_source_window)
5339         (tui_set_is_exec_point_at): Don't declare.
5340         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5341         (tui_source_window_base::refill): Rename from
5342         tui_refill_source_window.
5343         (tui_source_window_base::do_scroll_horizontal): Update.
5344         (tui_source_window_base::set_is_exec_point_at): Rename from
5345         tui_set_is_exec_point_at.
5346         (tui_update_all_breakpoint_info): Update.
5347         * tui/tui-stack.c (tui_show_frame_info): Update.
5348         * tui/tui-layout.c (show_data): Add cast.
5349         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5350         * tui/tui-data.h (struct tui_source_window_base) <refill,
5351         set_is_exec_point_at>: New methods.
5352         (tui_source_windows, tui_add_to_source_windows): Update types.
5353         (tui_add_to_source_windows): Remove redundant declaration.
5354         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5355         (tui_source_windows): Change return type.
5356         (tui_clear_source_windows_detail): Update.
5357         (tui_add_to_source_windows): Change type of parameter.
5358         (tui_free_all_source_wins_content): Update.
5359
5360 2019-06-25  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-wingeneral.c (tui_win_info::refresh)
5363         (tui_source_window_base::refresh): New methods.
5364         (tui_refresh_all): Call the refresh method.
5365         * tui/tui-data.h (struct tui_win_info)
5366         (struct tui_source_window_base) <refresh>: New method.
5367
5368 2019-06-25  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui.h (tui_is_window_visible): Return bool.
5371         * tui/tui.c (tui_is_window_visible): Return bool.
5372         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5373         (tui_make_visible, tui_make_invisible)
5374         (tui_win_info::make_visible)
5375         (tui_source_window_base::make_visible, make_all_visible)
5376         (tui_make_all_visible, tui_make_all_invisible): Update.
5377         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5378         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5379         bool.
5380         (struct tui_win_info, struct tui_source_window_base)
5381         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5382         * tui/tui-data.c (tui_init_generic_part): Update.
5383
5384 2019-06-25  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5387         (tui_source_window_base::make_visible): New methods.
5388         (make_all_visible): Make method call.
5389         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5390         (struct tui_source_window_base, struct tui_cmd_window): Override
5391         make_visible.
5392         (tui_win_is_source_type): Don't declare.
5393         * tui/tui-data.c (tui_win_is_source_type): Remove.
5394
5395 2019-06-25  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5398         NULL check.
5399
5400 2019-06-25  Tom Tromey  <tom@tromey.com>
5401
5402         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5403         Inline constructor.  Add initializers for members.
5404         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5405         constructors; now inline in class.
5406
5407 2019-06-25  Tom Tromey  <tom@tromey.com>
5408
5409         * tui/tui-regs.c (tui_show_registers): Update.
5410         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5411         bool.
5412         * tui/tui-data.c (tui_data_window::clear_detail)
5413         (tui_data_window): Update.
5414
5415 2019-06-25  Tom Tromey  <tom@tromey.com>
5416
5417         * tui/tui-windata.c (tui_display_all_data)
5418         (tui_display_data_from_line, tui_display_data_from)
5419         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5420         Update.
5421         * tui/tui-regs.c (tui_last_regs_line_no)
5422         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5423         (tui_show_registers, tui_show_register_group)
5424         (tui_display_registers_from, tui_display_reg_element_at_line)
5425         (tui_display_registers_from_line, tui_check_register_values)
5426         (tui_reg_next, tui_reg_prev): Update.
5427         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5428         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5429         tui_data_window.
5430         (struct tui_win_info) <detail>: Remove.  Add new fields from
5431         tui_data_info.
5432         (TUI_DATA_WIN): Add cast.
5433         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5434         (~tui_data_window): Simplify.
5435
5436 2019-06-25  Tom Tromey  <tom@tromey.com>
5437
5438         * tui/tui-layout.c (show_source_disasm_command)
5439         (show_source_or_disasm_and_command): Update.
5440         * tui/tui-io.c (update_cmdwin_start_line)
5441         (tui_redisplay_readline): Update.
5442         * tui/tui-data.h (struct tui_command_info): Remove.
5443         (struct tui_win_info) <detail>: Remove command_info member.
5444         (struct tui_data_window) <start_line>: New member, from
5445         tui_command_info.
5446         (TUI_CMD_WIN): Add casts.
5447
5448 2019-06-25  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-winsource.c (tui_update_source_window)
5451         (tui_refill_source_window)
5452         (tui_source_window_base::do_scroll_horizontal)
5453         (tui_update_breakpoint_info, tui_set_exec_info_content)
5454         (tui_show_exec_info_content, tui_erase_exec_info_content)
5455         (tui_clear_exec_info_content): Update.
5456         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5457         Update.
5458         * tui/tui-win.c (make_invisible_and_set_new_height)
5459         (make_visible_with_new_height): Update.
5460         * tui/tui-source.c (tui_set_source_content)
5461         (tui_show_symtab_source): Update.
5462         * tui/tui-layout.c (extract_display_start_addr)
5463         (show_source_disasm_command, show_data)
5464         (make_source_or_disasm_window)
5465         (show_source_or_disasm_and_command): Update.
5466         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5467         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5468         "gdbarch".
5469         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5470         to tui_source_window_base.
5471         (struct tui_win_info) <detail>: Remove source_info member.
5472         (struct tui_source_window_base) <has_locator>: Inline.
5473         Move contents from tui_source_info; rename has_locator member to
5474         m_has_locator.
5475         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5476         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5477         header file.
5478         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5479         Simplify.
5480         (tui_free_all_source_wins_content): Cast to
5481         tui_source_window_base.
5482
5483 2019-06-25  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-win.c (make_invisible_and_set_new_height)
5486         (make_visible_with_new_height): Call has_locator method.
5487         * tui/tui-layout.c (show_source_disasm_command, show_data)
5488         (show_source_or_disasm_and_command): Update for bool change.
5489         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5490         (tui_win_info) <has_locator>: New method.
5491         (struct tui_source_window_base) <has_locator>: New method.
5492         (tui_win_has_locator): Don't declare.
5493         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5494         from tui_win_has_locator.
5495         (tui_source_window_base): Use false, not FALSE.
5496
5497 2019-06-25  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5500         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5501         clear_detail method directly.
5502         (tui_clear_win_detail): Remove.
5503
5504 2019-06-25  Tom Tromey  <tom@tromey.com>
5505
5506         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5507         "this", not TUI_DISASM_WIN.
5508
5509 2019-06-25  Tom Tromey  <tom@tromey.com>
5510
5511         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5512         declare.
5513         * tui/tui-winsource.c
5514         (tui_source_window_base::do_scroll_horizontal): Rename from
5515         tui_horizontal_source_scroll.
5516         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5517         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5518         from tui_vertical_data_scroll.
5519         * tui/tui-win.h (tui_scroll): Don't declare.
5520         * tui/tui-win.c (tui_win_info::forward_scroll)
5521         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5522         (tui_win_info::right_scroll): Rename and update.
5523         (tui_scroll_forward_command, tui_scroll_backward_command)
5524         (tui_scroll_left_command, tui_scroll_right_command): Update.
5525         (tui_scroll): Remove.
5526         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5527         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5528         from tui_vertical_source_scroll.
5529         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5530         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5531         from tui_vertical_disassem_scroll.
5532         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5533         do_scroll_horizontal>: New methods.
5534         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5535         Likewise.
5536         (struct tui_source_window_base): Add do_scroll_horizontal.
5537         (struct tui_source_window, struct tui_disasm_window): Add
5538         do_scroll_vertical.
5539         (struct tui_data_window, struct tui_cmd_window): Add
5540         do_scroll_horizontal and do_scroll_vertical.
5541         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5542
5543 2019-06-25  Tom Tromey  <tom@tromey.com>
5544
5545         * tui/tui-data.h (struct tui_source_window_base): New struct.
5546         (struct tui_source_window): Derive from tui_source_window_base.
5547         (struct tui_disasm_window): New struct.
5548         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5549         from tui_source_window::clear_detail.
5550         (tui_source_window_base): Rename from tui_source_window.
5551         (~tui_source_window_base): Rename from ~tui_source_window.
5552         (tui_alloc_win_info): Create a tui_disasm_window.
5553
5554 2019-06-25  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-data.h (struct tui_source_window)
5557         (struct tui_data_window): Declare destructors.
5558         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5559         destructors.
5560         (tui_win_info): Simplify.
5561
5562 2019-06-25  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-winsource.c (tui_display_main)
5565         (tui_update_source_windows_with_addr)
5566         (tui_update_all_breakpoint_info): Update.
5567         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5568         (new_height_ok, parse_scrolling_args): Update.
5569         * tui/tui-stack.c (tui_show_frame_info): Update.
5570         * tui/tui-data.h (struct tui_list): Remove.
5571         (tui_source_windows): Return a reference to a std::vector.
5572         * tui/tui-data.c (source_windows): Now a std::vector.
5573         (tui_source_windows): Change return type.
5574         (tui_clear_source_windows): Rewrite.
5575         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5576         (tui_free_all_source_wins_content): Rewrite.
5577
5578 2019-06-25  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5581         (struct tui_data_window, struct tui_cmd_window): Declare
5582         clear_detail method.
5583         * tui/tui-data.c (tui_source_window::clear_detail)
5584         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5585         methods.
5586         (tui_clear_win_detail): Simplify.
5587
5588 2019-06-25  Tom Tromey  <tom@tromey.com>
5589
5590         * tui/tui-layout.c (make_source_window, make_disasm_window)
5591         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5592         Return the new window.
5593         (show_source_disasm_command, show_data)
5594         (show_source_or_disasm_and_command): Update.
5595
5596 2019-06-25  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5599         parameter.  Return the new window.
5600         (show_source_disasm_command): Update and remove NULL check.
5601         (show_source_or_disasm_and_command): Update.
5602
5603 2019-06-25  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5606
5607 2019-06-25  Tom Tromey  <tom@tromey.com>
5608
5609         * tui/tui-data.h (struct tui_win_info): Make constructor
5610         protected.  Make destructor virtual.  Add initializers.
5611         (tui_source_window, tui_data_window, tui_cmd_window): New
5612         classes.
5613         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5614         constructor.  Add "type" parameter.
5615         (tui_source_window, tui_data_window, tui_cmd_window): New
5616         constructors.
5617         (tui_alloc_win_info): Instantiate the appropriate subclass.
5618
5619 2019-06-25  Tom Tromey  <tom@tromey.com>
5620
5621         * tui/tui-win.c (tui_resize_all): Use delete.
5622         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5623         destructor.
5624         (tui_free_window): Don't declare.
5625         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5626         Update.
5627
5628 2019-06-25  Tom Tromey  <tom@tromey.com>
5629
5630         * tui/tui-data.h (struct tui_win_info): Add constructor.
5631         * tui/tui-data.c (tui_alloc_win_info): Use new.
5632         (tui_free_window): Use delete.
5633
5634 2019-06-22  Tom Tromey  <tom@tromey.com>
5635
5636         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5637         declare.
5638         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5639
5640 2019-06-22  Tom Tromey  <tom@tromey.com>
5641
5642         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5643         declare.
5644         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5645
5646 2019-06-22  Tom de Vries  <tdevries@suse.de>
5647
5648         * dwarf2read.c (create_addrmap_from_aranges)
5649         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5650         instead of '%zu'.
5651
5652 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5653
5654         * dwarf2read.h (dwarf2_section_info_def): Remove.
5655         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5656         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5657         std::vector<dwarf2_section_info>.
5658         (struct dwo_file) <~dwo_file>: Remove.
5659         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5660         types field.
5661         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5662         (dwarf2_read_debug_names): Likewise.
5663         (create_debug_types_hash_table): Change parameter type to
5664         array_view, adjust code accordingly.
5665         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5666         (partial_die_info::fixup): Likewise.
5667         (determine_prefix): Likewise.
5668         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5669
5670 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5671
5672         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5673         gdb_bfd_ref_ptr.
5674         <~dwo_file>: Remove call to gdb_bfd_unref.
5675         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5676         gdb_bfd_ref_ptr::get.
5677
5678 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5679
5680         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5681         type to htab_up.
5682         * dwarf2read.c (struct dwo_file): Initialize fields.
5683         <~dwo_file>: New.
5684         (free_dwo_file): Remove, move content to ~dwo_file.
5685         (struct dwo_file_deleter): Remove.
5686         (dwo_file_up>: Remove custom deleter.
5687         (free_dwo_files): Remove.
5688         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5689         dwo_files.
5690         (process_skeletonless_type_units): Call unique_ptr::get.
5691         (allocate_dwo_file_hash_table): Add deleter to created hash
5692         table.  Change return type to htab_up.
5693         (lookup_dwo_file_slot): Don't memset dwo_file, call
5694         unique_ptr::get.
5695         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5696         (create_dwo_unit_in_dwp_v2): Likewise.
5697         (open_and_init_dwo_file): Likewise.
5698         (free_dwo_file_from_slot): Remove.
5699
5700 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5701
5702         * dwarf2read.h (struct dwarf2_section_info) <readin,
5703         is_virtual>: Change type to bool.
5704         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5705         true instead of 1.
5706
5707 2019-06-19  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui-data.h (tui_init_content_element): Don't declare.
5710
5711 2019-06-19  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-data.h (tui_init_win_info): Don't declare.
5714
5715 2019-06-19  Tom de Vries  <tdevries@suse.de>
5716
5717         * dwarf2read.h (abstract_to_concrete): Change type to
5718         std::unordered_map<sect_offset, std::vector<sect_offset>,
5719         gdb::hash_enum<sect_offset>>.
5720
5721 2019-06-19  Tom Tromey  <tromey@adacore.com>
5722
5723         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5724         EVAL_AVOID_SIDE_EFFECTS specially.
5725
5726 2019-06-19  Tom Tromey  <tromey@adacore.com>
5727
5728         * source-cache.c (highlighter): New global.
5729         (source_cache::get_source_lines): Create a highlighter on demand.
5730
5731 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * defs.h (deprecated_interactive_hook): Delete declaration.
5734         * interps.c (clear_interpreter_hooks): Remove use of
5735         deprecated_interactive_hook.
5736         * top.c (deprecated_interactive_hook): Delete definition.
5737         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5738
5739 2019-06-18  Tom de Vries  <tdevries@suse.de>
5740
5741         PR gdb/24515
5742         * dwarf2read.h (abstract_to_concrete): Change type from
5743         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5744         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5745         * dwarf2read.c (read_variable): Update.
5746         (dwarf2_fetch_die_loc_sect_off): Update.
5747
5748 2019-06-17  Tom de Vries  <tdevries@suse.de>
5749
5750         PR gdb/24617
5751         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5752         accessing parent[parent_len - 1].
5753
5754 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5755
5756         PR gdb/24364
5757         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5758         call dtrace_process_dof with NULL dof.
5759
5760 2019-06-16  Tom de Vries  <tdevries@suse.de>
5761
5762         PR gdb/24445
5763         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5764
5765 2019-06-16  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5768         (make_all_visible): Use address of member.
5769
5770 2019-06-16  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5773         (tui_free_window, free_content, free_content_elements): Remove
5774         unnecessary cast.
5775         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5776         cast.
5777         * tui/tui-regs.c (tui_show_register_group)
5778         (tui_display_registers_from, tui_display_reg_element_at_line):
5779         Remove unnecessary cast.
5780
5781 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5782
5783         * linux-nat.c (normal_mask): Delete.
5784         (_initialize_linux_nat): Don't initialise normal_mask.
5785
5786 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5787
5788         PR gdb/24445
5789         * dwarf-index-write.h (write_psymtabs_to_index): Add
5790         dwz_basename parameter.
5791         * dwarf-index-write.c (write_gdbindex): Move file writing to
5792         write_gdbindex_1.  Change return type void.
5793         (assert_file_size): Move up, remove filename parameter.
5794         (write_gdbindex_1): New function.
5795         (write_debug_names): Change return type to void, call
5796         assert_file_size.
5797         (struct index_wip_file): New struct.
5798         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5799         file logic to index_wip_file.  Write index for dwz file if
5800         needed.
5801         (save_gdb_index_command): Pass basename of dwz file, if present.
5802         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5803         build-id of dwz file, if present.
5804         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5805         (dwarf2_get_dwz_file): Likewise.
5806         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5807         (dwarf2_get_dwz_file): Likewise.
5808
5809 2019-06-16  Tom Tromey  <tom@tromey.com>
5810
5811         * coffread.c (process_coff_symbol): Use xstrdup.
5812         * value.c (create_internalvar): Use xstrdup.
5813
5814 2019-06-16  Tom Tromey  <tom@tromey.com>
5815
5816         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5817         * breakpoint.c (stopin_command, stopat_command)
5818         (until_break_command, decode_location_default): Remove unnecessary
5819         cast.
5820         * utils.c (subset_compare): Remove unnecessary cast.
5821         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5822         cast.
5823         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5824         cast.
5825         * infcmd.c (path_command): Remove unnecessary cast.
5826         * coffread.c (decode_type): Remove unnecessary cast.
5827         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5828         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5829         * tui/tui-stack.c (tui_show_locator_content)
5830         (tui_show_frame_info): Remove unnecessary cast.
5831         * tui/tui-win.c (tui_scroll_forward_command)
5832         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5833         (parse_scrolling_args): Remove unnecessary cast.
5834         * tui/tui-data.c (init_win_info, tui_del_window)
5835         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5836         (free_content_elements): Remove unnecessary cast.
5837         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5838         unnecessary cast.
5839         * tui/tui-source.c (tui_set_source_content)
5840         (tui_vertical_source_scroll): Remove unnecessary cast.
5841         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5842         cast.
5843         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5844         * tui/tui-regs.c (tui_display_registers_from)
5845         (tui_display_register): Remove unnecessary cast.
5846         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5847         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5848         (make_visible): Remove unnecessary cast.
5849         * tui/tui-winsource.c (tui_erase_source_content)
5850         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5851         unnecessary cast.
5852         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5853         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5854         * stabsread.c (read_type, read_array_type, read_range_type):
5855         Remove unnecessary cast.
5856         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5857         (parse_symbol, parse_type, upgrade_type, parse_external)
5858         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5859         unnecessary cast.
5860         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5861
5862 2019-06-16  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-data.c (tui_alloc_generic_win_info)
5865         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5866         checks.
5867
5868 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5869             Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * f-typeprint.c (f_print_type): Don't return early for not
5872         associated or not allocated types.
5873         (f_type_print_varspec_suffix): Add print_rank parameter and print
5874         ranks of array types in case they dangling.
5875         (f_type_print_base): Add print_rank parameter.
5876
5877 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5878
5879         * NEWS: Mention new MI commands.
5880         * break-catch-throw.c (enum exception_event_kind): Move to
5881         breakpoint.h.
5882         (print_mention_exception_catchpoint): Output text as a single
5883         message.
5884         (catch_exception_command_1): Rename to...
5885         (catch_exception_event): ...this, make non-static, update header
5886         command, and change some parameter types.
5887         (catch_catch_command): Update for changes to
5888         catch_exception_command_1.
5889         (catch_throw_command): Likewise.
5890         (catch_rethrow_command): Likewise.
5891         * breakpoint.c (enum exception_event_kind): Delete.
5892         * breakpoint.h (enum exception_event_kind): Moved here from
5893         break-catch-throw.c.
5894         (catch_exception_event): Declare.
5895         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5896         (mi_cmd_catch_throw): New function.
5897         (mi_cmd_catch_rethrow): New function.
5898         (mi_cmd_catch_catch): New function.
5899         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5900         'catch-catch' entries.
5901         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5902         (mi_cmd_catch_rethrow): Declare.
5903         (mi_cmd_catch_catch): Declare.
5904
5905 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * annotate.c (annotate_source_line): Change return type to void,
5908         update implementation to match.
5909         * annotate.h (annotate_source_line): Change return type to void,
5910         update header comment.
5911         * stack.c (print_frame_info): Don't change what frame information
5912         is printed based on whether annotations are on or not.
5913
5914 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5917         (annotate_source): Make static.
5918         (annotate_source_line): Moved from source.c and renamed from
5919         identify_source_line.  Update the return type.
5920         * annotate.h (annotate_source): Delete declaration.
5921         (annotate_source_line): Declaration moved from source.h, and
5922         renamed from identify_source_line.  Return type updated.
5923         * source.c (identify_source_line): Moved to annotate.c and renamed
5924         to annotate_source_line.
5925         (info_line_command): Remove check of annotation_level.
5926         * source.h (identify_source_line): Move declaration to annotate.h
5927         and rename to annotate_source_line.
5928         * stack.c: Add 'annotate.h' include.
5929         (print_frame_info): Remove check of annotation_level before
5930         calling annotate_source_line.
5931
5932 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * source-cache.c (source_cache::get_plain_source_lines): Use
5935         open_source_file_with_line_charpos instead of just
5936         open_source_file, remove call to find_source_lines.
5937         (source_cache::get_source_lines): Likewise.
5938         * source.c (find_source_lines): Make static.
5939         (get_filename_and_charpos): Renamed into...
5940         (open_source_file_with_line_charpos): ..this along with changes to
5941         return a scoped_fd, and some other minor clean ups.
5942         (identify_source_line): Use open_source_file_with_line_charpos.
5943         (search_command_helper): Use open_source_file_with_line_charpos
5944         instead of just open_source_file, remove call to
5945         find_source_lines.
5946         * source.h (open_source_file_with_line_charpos): Declare new
5947         function.
5948         (find_source_lines): Delete declaration.
5949
5950 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * source.c (get_filename_and_charpos): Remove fullname
5953         parameter.
5954         (identify_source_line): Update call to get_filename_and_charpos.
5955
5956 2019-06-14  Tom Tromey  <tromey@adacore.com>
5957
5958         PR gdb/24502:
5959         * ui-style.h (skip_ansi_escape): Update comment.
5960         * ui-file.h (class no_terminal_escape_file): New class.
5961         * ui-file.c (no_terminal_escape_file::write)
5962         (no_terminal_escape_file::puts): New methods.
5963         * cli/cli-logging.c (handle_redirections): Use
5964         no_terminal_escape_file.
5965
5966 2019-06-14  Tom Tromey  <tromey@adacore.com>
5967
5968         * NEWS: Move convenience variable news above Python news.
5969
5970 2019-06-14  Tom Tromey  <tom@tromey.com>
5971
5972         * gnulib: Move directory to top-level.
5973         * configure.ac: Don't configure gnulib.
5974         * configure: Rebuild.
5975         * common/common-defs.h: Use new path to gnulib.
5976         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5977         (GNULIB_H): Remove.
5978         (INCGNU): Look in new gnulib location.
5979         (HFILES_NO_SRCDIR): Remove gnulib files.
5980         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5981         (generated_files): Remove GNULIB_H.
5982         ($(LIBGNU), all-lib): Remove targets.
5983         (distclean): Don't mention GNULIB_BUILDDIR.
5984         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5985
5986 2019-06-14  Tom Tromey  <tromey@adacore.com>
5987
5988         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5989         Warn if symbol file does not provide any symbols.
5990
5991 2019-06-14  Tom Tromey  <tromey@adacore.com>
5992
5993         * source.c (find_and_open_source): Respect basenames_may_differ.
5994
5995 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5996
5997         * annotate.c (annotate_breakpoints_invalid): Make use of
5998         scoped_restore_terminal_state.
5999         (annotate_frames_invalid): Likewise.
6000
6001 2019-06-14  Tom Tromey  <tromey@adacore.com>
6002
6003         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6004         allow assignment to an internalvar.
6005
6006 2019-06-14  Tom Tromey  <tromey@adacore.com>
6007
6008         * ada-lex.l: Allow "_" in attribute names.
6009
6010 2019-06-14  Tom Tromey  <tromey@adacore.com>
6011
6012         PR gdb/24653:
6013         * regcache.c (registers_changed): Don't call alloca.
6014         * top.c (execute_command): Don't call alloca.
6015
6016 2019-06-13  Pedro Alves  <palves@redhat.com>
6017
6018         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6019         'expression'.  When parsing an expression, error out if there's
6020         junk after "unlimited".
6021         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6022         (do_set_command): Adjust calls to is_unlimited_literal.
6023
6024 2019-06-13  Pedro Alves  <palves@redhat.com>
6025
6026         * compile/compile.c (make_compile_options_def_group): Add braces
6027         around array_view initializer.
6028         * thread.c (make_thread_apply_all_options_def_group)
6029         (make_thread_apply_all_options_def_group): Likewise.
6030
6031 2019-06-13  Pedro Alves  <palves@redhat.com>
6032
6033         * NEWS (New commands): Mention "maint test-options
6034         require-delimiter", "maint test-options unknown-is-error", "maint
6035         test-options unknown-is-operand" and "maint show
6036         test-options-completion-result".
6037         (New command options, command completion): New section.
6038         (Completion improvements): New section.
6039         Mention that you can abbreviate "unlimited".
6040
6041 2019-06-13  Pedro Alves  <palves@redhat.com>
6042
6043         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6044         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6045         * unittests/cli-utils-selftests.c (test_parse_flags)
6046         (test_parse_flags_qcs): Delete.
6047         (test_cli_utils): Don't call deleted functions.
6048
6049 2019-06-13  Pedro Alves  <palves@redhat.com>
6050
6051         * thread.c: Include "cli/cli-option.h".
6052         (tp_array_compar_ascending): Global.
6053         (tp_array_compar): Delete function.
6054         (tp_array_compar_ascending, tp_array_compar_descending): New
6055         functions.
6056         (ascending_option_def, qcs_flag_option_def)
6057         (thr_qcs_flags_option_defs)
6058         (make_thread_apply_all_options_def_group)
6059         (make_thread_apply_options_def_group): New.
6060         (thread_apply_all_command): Use gdb::option::process_options.
6061         (thread_apply_command_completer)
6062         (thread_apply_all_command_completer): New.
6063         (thread_apply_command): Use gdb::option::process_options.
6064         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6065         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6066         to generate help text of "thread apply".  Adjust "taas"'s help.
6067         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6068         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6069
6070 2019-06-13  Pedro Alves  <palves@redhat.com>
6071
6072         * thread.c (thread_apply_command): Check for invalid TID with
6073         isdigit instead of !isalpha.
6074
6075 2019-06-13  Pedro Alves  <palves@redhat.com>
6076
6077         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6078         (validate_flags_qcs): New.
6079         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6080         (validate_flags_qcs): Declare.
6081         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6082         (make_frame_apply_options_def_group): New.
6083         (frame_apply_command_count): Process options with
6084         gdb::option::process_options.
6085         (frame_apply_completer): New.
6086         (frame_apply_level_completer, frame_apply_all_completer)
6087         (frame_apply_completer): New.
6088         (_initialize_stack): Update help of "frame apply", "frame apply
6089         level", "frame apply all" and "faas" to mention supported options
6090         and install command completers.
6091         * stack.h (frame_apply_all_completer): Declare.
6092         * thread.c: Include "stack.h".
6093         (tfaas_command): Add "--".
6094         (_initialize_thread): Update help "tfaas" to mention supported
6095         options and install command completer.
6096
6097 2019-06-13  Pedro Alves  <palves@redhat.com>
6098
6099         * completer.c (complete_nested_command_line): New.
6100         (gdb_completion_word_break_characters_throw): Add assertion.
6101         * completer.h (complete_nested_command_line): Declare.
6102
6103 2019-06-13  Pedro Alves  <palves@redhat.com>
6104
6105         * stack.c (parse_backtrace_qualifiers): New.
6106         (backtrace_command): Use it.
6107         (backtrace_command_completer): Complete on qualifiers.
6108
6109 2019-06-13  Pedro Alves  <palves@redhat.com>
6110
6111         * frame.c: Include "cli/cli-option.h.
6112         (user_set_backtrace_options): New.
6113         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6114         Delete.
6115         (get_prev_frame): Adjust.
6116         (boolean_option_def, uinteger_option_def)
6117         (set_backtrace_option_defs): New.
6118         (_initialize_frame): Adjust and use
6119         gdb::option::add_setshow_cmds_for_options to install "set
6120         backtrace past-main" and "set backtrace past-entry".
6121         * frame.h: Include "cli/cli-option.h".
6122         (struct frame_print_options): Forward declare.
6123         (print_frame_arguments_all, print_frame_arguments_scalars)
6124         (print_frame_arguments_none): Declare.
6125         (print_entry_values): Delete declaration.
6126         (struct frame_print_options, user_frame_print_options): New.
6127         (struct set_backtrace_options): New.
6128         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6129         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6130         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6131         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6132         (list_args_or_locals): Add frame_print_options parameter.
6133         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6134         * python/py-framefilter.c (enumerate_args): Pass down
6135         USER_FRAME_PRINT_OPTIONS.
6136         * stack.c: Include "cli/cli-option.h".
6137         (print_frame_arguments_all, print_frame_arguments_scalars)
6138         (print_frame_arguments_none): Declare.
6139         (print_raw_frame_arguments, print_entry_values): Delete.
6140         (user_frame_print_options): New.
6141         (boolean_option_def, enum_option_def, frame_print_option_defs):
6142         New.
6143         (struct backtrace_cmd_options): New.
6144         (bt_flag_option_def): New.
6145         (backtrace_command_option_defs): New.
6146         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6147         (print_frame_arg, read_frame_arg, print_frame_args)
6148         (print_frame_info, print_frame): Add frame_print_options parameter
6149         and use it.
6150         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6151         (backtrace_command_1): Add frame_print_options and
6152         backtrace_cmd_options parameters and use them.
6153         (make_backtrace_options_def_group): New.
6154         (backtrace_command): Process command options with
6155         gdb::option::process_options.
6156         (backtrace_command_completer): New.
6157         (_initialize_stack): Extend "backtrace"'s help to mention
6158         supported options.  Install completer for "backtrace".
6159         Install some settings commands with add_setshow_cmds_for_options.
6160
6161 2019-06-13  Pedro Alves  <palves@redhat.com>
6162
6163         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6164         and that "set/show print raw frame-arguments" are now deprecated.
6165
6166         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6167         command.
6168         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6169         * stack.c (_initialize_stack): Install "set/show print
6170         raw-frame-arguments", and deprecate "set/show print raw
6171         frame-arguments".
6172         * valprint.c (_initialize_valprint): Deprecate "set/show print
6173         raw".
6174
6175 2019-06-13  Pedro Alves  <palves@redhat.com>
6176
6177         * compile/compile.c (struct compile_options): New.
6178         (compile_flag_option_def, compile_command_option_defs)
6179         (make_compile_options_def_group): New.
6180         (compile_file_command): Handle options with
6181         gdb::option::process_options.
6182         (compile_file_command_completer): New function.
6183         (compile_code_command): Handle options with
6184         gdb::option::process_options.
6185         (compile_code_command_completer): New function.
6186         (_initialize_compiler): Install completers for "compile code" and
6187         "compile file".  Mention available options in "compile code" and
6188         "compile code"'s help.
6189         * completer.c (advance_to_completion_word): New, factored out from
6190         ...
6191         (advance_to_expression_complete_word_point): ... this.
6192         (advance_to_filename_complete_word_point): New.
6193         * completer.h (advance_to_filename_complete_word_point): New
6194         declaration.
6195
6196 2019-06-13  Pedro Alves  <palves@redhat.com>
6197
6198         * compile/compile.c: Include "cli/cli-option.h".
6199         (compile_print_value): Scope data pointer is now a
6200         value_print_options pointer; adjust.
6201         (compile_print_command): Process options.  Scope data pointer is
6202         now a value_print_options pointer; adjust.
6203         (_initialize_compile): Update "compile print"'s help to include
6204         supported options.  Install a completer for "compile print".
6205         * cp-valprint.c (show_vtblprint, show_objectprint)
6206         (show_static_field_print): Delete.
6207         (_initialize_cp_valprint): Don't install "set print
6208         static-members", "set print vtbl", "set print object" here.
6209         * printcmd.c: Include "cli/cli-option.h" and
6210         "common/gdb_optional.h".
6211         (print_command_parse_format): Rework to fill in a
6212         value_print_options instead of a format_data.
6213         (print_value): Change parameter type from format_data pointer to
6214         value_print_options reference.  Adjust.
6215         (print_command_1): Process options.  Adjust to pass down a
6216         value_print_options.
6217         (print_command_completer): New.
6218         (_initialize_printcmd): Install print_command_completer as
6219         handle_brkchars completer for the "print" command.  Update
6220         "print"'s help to include supported options.
6221         * valprint.c: Include "cli/cli-option.h".
6222         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6223         here from cp-valprint.c.
6224         (boolean_option_def, uinteger_option_def)
6225         (value_print_option_defs, make_value_print_options_def_group):
6226         New.  Use gdb::option::add_setshow_cmds_for_options to install
6227         "set print elements", "set print null-stop", "set print repeats",
6228         "set print pretty", "set print union", "set print array", "set
6229         print address", "set print symbol", "set print array-indexes".
6230         * valprint.h: Include <string> and "cli/cli-option.h".
6231         (make_value_print_options_def_group): Declare.
6232         (print_value): Change parameter type from format_data pointer to
6233         value_print_options reference.
6234         (print_command_completer): Declare.
6235
6236 2019-06-13  Pedro Alves  <palves@redhat.com>
6237
6238         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6239         (COMMON_SFILES): Add maint-test-settings.c.
6240         * cli/cli-decode.c (boolean_enums): New global, factored out from
6241         ...
6242         (add_setshow_boolean_cmd): ... here.
6243         * cli/cli-decode.h (boolean_enums): Declare.
6244         * cli/cli-option.c: New file.
6245         * cli/cli-option.h: New file.
6246         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6247         factored out from ...
6248         (parse_cli_boolean_value(const char *)): ... this.
6249         (is_unlimited_literal): Change parameter type to pointer to
6250         pointer.  Adjust and advance ARG pointer.
6251         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6252         (parse_cli_var_enum): New, factored out from ...
6253         (do_set_command): ... this.  Adjust.
6254         * cli/cli-setshow.h (parse_cli_boolean_value)
6255         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6256         (parse_cli_var_enum): Declare.
6257         * cli/cli-utils.c: Include "cli/cli-option.h".
6258         (get_ulongest): New.
6259         * cli/cli-utils.h (get_ulongest): Declare.
6260         (check_for_argument): New overloads.
6261         * maint-test-options.c: New file.
6262
6263 2019-06-13  Pedro Alves  <palves@redhat.com>
6264
6265         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6266         parse a range if "-" is at the end of the string.
6267
6268 2019-06-13  Pedro Alves  <palves@redhat.com>
6269
6270         * cli/cli-setshow.c (parse_auto_binary_operation)
6271         (parse_cli_boolean_value): Don't allow "o".
6272
6273 2019-06-13  Pedro Alves  <palves@redhat.com>
6274
6275         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6276         * NEWS: Mention maint test-settings KIND.
6277         * maint-test-settings.c: New file.
6278
6279 2019-06-13  Pedro Alves  <palves@redhat.com>
6280
6281         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6282         completer.
6283         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6284         "set" completers.
6285
6286 2019-06-13  Pedro Alves  <palves@redhat.com>
6287
6288         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6289         after item.
6290
6291 2019-06-13  Pedro Alves  <palves@redhat.com>
6292
6293         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6294
6295 2019-06-13  Pedro Alves <palves@redhat.com>
6296
6297         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6298         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6299         call.
6300         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6301         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6302         calls.
6303         (check_for_argument): Skip spaces after argument.
6304
6305 2019-06-13  Pedro Alves  <palves@redhat.com>
6306
6307         * thread.c (thread_apply_command): Adjust TID parsing.
6308         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6309         detected before end of string.
6310         (tid_is_in_list): Error out if LIST is invalid.
6311
6312 2019-06-13  Pedro Alves  <palves@redhat.com>
6313
6314         * completer.c (complete_line_internal_1): Rewind completion word
6315         point.
6316         (completion_tracker::advance_custom_word_point_by): Change
6317         parameter type to int.
6318         * completer.h (completion_tracker::advance_custom_word_point_by):
6319         Likewise.
6320
6321 2019-06-13  Pedro Alves  <palves@redhat.com>
6322
6323         * completer.c (advance_to_completion_word): Handle delimiters.
6324
6325 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6326
6327         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6328
6329 2019-06-11  Tom Tromey  <tom@tromey.com>
6330
6331         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6332         (xmalloc_failed): Move to alloc.c.
6333         * alloc.c: New file.
6334         * Makefile.in (COMMON_SFILES): Add alloc.c.
6335
6336 2019-06-11  Tom Tromey  <tom@tromey.com>
6337
6338         * nat/linux-waitpid.c: Don't include server.h.
6339         (linux_debug): Remove.
6340         (my_waitpid): Update.
6341
6342 2019-06-11  Tom Tromey  <tromey@adacore.com>
6343
6344         * infcall.c (_initialize_infcall): Remove trailing newline from
6345         help.
6346         * user-regs.c (_initialize_user_regs): Remove trailing newline
6347         from help.
6348         * typeprint.c (_initialize_typeprint): Remove trailing newline
6349         from help.
6350         * reverse.c (_initialize_reverse): Remove trailing newlines from
6351         help.
6352         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6353         from help.
6354         * language.c (add_set_language_command): Remove trailing newline
6355         from help.
6356         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6357         help.
6358         * disasm.c (_initialize_disasm): Remove trailing newline from
6359         help.
6360         * top.c (init_main): Remove trailing newline from help.
6361         * interps.c (_initialize_interpreter): Remove trailing newline
6362         from help.
6363         * btrace.c (_initialize_btrace): Remove trailing newlines from
6364         help.
6365         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6366         from help.
6367         * python/python.c (_initialize_python): Remove trailing newline
6368         from help.
6369         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6370         help.
6371         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6372         from help.  Reformat some text.
6373         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6374         from help.
6375         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6376         newline from help.
6377
6378 2019-06-11  Tom Tromey  <tromey@adacore.com>
6379
6380         * darwin-nat.c (darwin_decode_exception_message)
6381         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6382
6383 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * valops.c (value_slice): Check for not allocated or not
6386         associated values.
6387
6388 2019-06-10  Tom de Vries  <tdevries@suse.de>
6389
6390         PR gdb/24618
6391         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6392         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6393         invalid.
6394
6395 2019-06-10  Tom de Vries  <tdevries@suse.de>
6396
6397         PR gdb/24611
6398         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6399         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6400
6401 2019-06-10  Tom de Vries  <tdevries@suse.de>
6402
6403         PR symtab/24545
6404         * symtab.c (struct demangled_name_entry): Add language field.
6405         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6406         static minimal symbol".  Set and use language field.
6407
6408 2019-06-10  Tom Tromey  <tromey@adacore.com>
6409
6410         * ada-lang.c (_initialize_ada_language): Update help text.
6411
6412 2019-06-10  Tom Tromey  <tromey@adacore.com>
6413
6414         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6415         with a newline.
6416         * guile/guile.c (handle_boot_error): Don't end warning with a
6417         newline.
6418         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6419         warning with a newline.
6420         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6421         newline.
6422         (s12z_frame_cache): Likewise.
6423         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6424         a newline.
6425         * solib-svr4.c (disable_probes_interface): Don't end warning with
6426         a newline.
6427         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6428         newline.
6429         * python/python.c (do_finish_initialization): Don't end warning
6430         with a newline.
6431
6432 2019-06-10  Tom Tromey  <tom@tromey.com>
6433
6434         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6435         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6436         gdbpy_enter.
6437
6438 2019-06-10  Tom Tromey  <tromey@adacore.com>
6439
6440         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6441         data.
6442         (elf_new_init): Don't call stabsread_new_init.
6443         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6444         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6445         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6446
6447 2019-06-10  Tom de Vries  <tdevries@suse.de>
6448
6449         PR symtab/16264
6450         PR symtab/24517
6451         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6452
6453 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6454
6455         * source.c (find_and_open_source): Also rewrite relative file
6456         names.
6457
6458 2019-04-26  Amos Bird  <amosbird@gmail.com>
6459
6460         * annotate.c (annotate_thread_exited): Add "thread-exited"
6461         annotation.
6462
6463 2019-06-06  Tom Tromey  <tromey@adacore.com>
6464
6465         * maint.h (class scoped_command_stats): Use
6466         DISABLE_COPY_AND_ASSIGN.
6467         <print_time>: New method.
6468         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6469         print_time.
6470         (scoped_command_stats::print_time): New method.
6471
6472 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6475         instructions of lengths 6 or 8 bytes.
6476
6477 2019-06-04  Pedro Alves  <palves@redhat.com>
6478
6479         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6480
6481         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6482         * breakpoint.c (condition_completer): Likewise.
6483         * cli/cli-dump.c (scan_expression): Likewise.
6484         * common/filestuff.c (mkdir_recursive): Likewise.
6485         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6486         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6487         (gdb_abspath): Likewise.
6488         * compile/compile-cplus-types.c
6489         (compile_cplus_instance::decl_name): Likewise.
6490         * completer.c (complete_explicit_location):
6491         (signal_completer, reg_or_group_completer_1): Likewise.
6492         * cp-support.c (cp_remove_params_if_any): Likewise.
6493         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6494         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6495         * infcmd.c (strip_bg_char): Likewise.
6496         * linespec.c (copy_token_string): Likewise.
6497         * mi/mi-main.c (output_cores): Likewise.
6498         * psymtab.c (psymtab_search_name):
6499         * symfile.c (test_set_ext_lang_command): Likewise.
6500         * target.c (target_fileio_read_stralloc): Likewise.
6501         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6502         * value.c (complete_internalvar): Likewise.
6503
6504 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6505
6506         Add objfile property to gdb.Type.
6507         * NEWS: Mention Python API addition.
6508         * python/py-type.c (typy_get_objfile): New method.
6509
6510 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6511
6512         * NEWS: Mention the new set|show style [title|highlight].
6513         Mention changes to "show style", "help" and "apropos".
6514
6515 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6516
6517         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6518         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6519         instead of print_help_for_command.
6520         (print_doc_of_command): New function.
6521         (help_list): Add 'apropos -v word' suggestion.
6522         (print_help_for_command): Style the command name using title style.
6523         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6524         (_initialize_cli_cmds): Describe -v in apropos_command help.
6525
6526 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6527
6528         * cli/cli-style.h (cli_style_option): Add name in constructor,
6529         add m_name class member, add constructor with intensity,
6530         add name class function.
6531         (cli_style_option::add_setshow_commands): Remove name argument.
6532         (highlight_style, title_style): New styles.
6533         * cli/cli-style.c (do_show): New function that shows a style
6534         characteristic styling the style name with itself.
6535         (set_style_name): New function.
6536         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6537         Update all callers according to the changes in cli/cli-style.h.
6538         * utils.h (fputs_highlighted): New function.
6539         * utils.c (fputs_highlighted): Likewise.
6540
6541 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6542
6543         * NEWS: Mention new pipe command and new convenience variables.
6544
6545 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6546
6547         * cli/cli-cmds.c (pipe_command): New function.
6548         (_initialize_cli_cmds): Call add_com for pipe_command.
6549         Define | as an alias for pipe.
6550         (exit_status_set_internal_vars): New function.
6551         (shell_escape): Call exit_status_set_internal_vars.
6552         cli/cli-decode.c (find_command_name_length): Recognize | as
6553         a single character command.
6554
6555 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6556
6557         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6558         top.c (execute_command_to_ui_file): New function, mostly a copy
6559         of execute_command_to_string.
6560         (execute_command_to_string): Implement by calling
6561         execute_command_to_ui_file.
6562
6563 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6564
6565         * top.h (saved_command_line): Remove declaration.
6566         * top.c (previous_saved_command_line, previous_repeat_arguments):
6567         New variables.
6568         (saved_command_line): Make static, define together with other
6569         'repeat variables'.
6570         (dont_repeat): Clear repeat_arguments.
6571         (repeat_previous, get_saved_command_line, save_command_line):
6572         New functions.
6573         (gdb_init): Initialize saved_command_line
6574         and previous_saved_command_line.
6575         * main.c (captured_main_1): Remove saved_command_line initialization.
6576         * event-top.c (handle_line_of_input): Update to use
6577         the new 'repeat' related functions instead of direct access to
6578         saved_command_line.
6579         * command.h (repeat_previous, get_saved_command_line,
6580         save_command_line): New declarations.
6581         (dont_repeat): Add comment.
6582
6583 2019-05-30  Tom Tromey  <tromey@adacore.com>
6584
6585         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6586         Fix comment.
6587         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6588
6589 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6590
6591         PR cli/24587
6592         * completer.c (complete): Initialize variable word.
6593
6594 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6595
6596         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6597         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6598         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6599         'body' is NULL to the outter 'if', protecting the '!is_define'
6600         situation as well.
6601
6602 2019-05-29  Tom Tromey  <tromey@adacore.com>
6603
6604         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6605         (dwarf_unknown): New function.
6606         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6607         (dwarf_type_encoding_name): Use dwarf_unknown.
6608
6609 2019-05-29  Tom Tromey  <tromey@adacore.com>
6610
6611         PR c++/20020:
6612         * cp-valprint.c (cp_print_value_fields): Call
6613         cp_print_static_field inside "try".
6614
6615 2019-05-29  Tom Tromey  <tromey@adacore.com>
6616
6617         * inflow.c (struct terminal_info): Add default operator=.
6618         * configure: Rebuild.
6619         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6620         -Wdeprecated-copy-dtor, -Wredundant-move.
6621
6622 2019-05-29  Tom Tromey  <tromey@adacore.com>
6623
6624         * NEWS: Add entry.
6625         * infcmd.c (print_return_value_1): Handle finish_print
6626         option.
6627         (show_print_finish): New function.
6628         (_initialize_infcmd): Add "set/show print finish" commands.
6629         * valprint.c (user_print_options): Initialize new member.
6630         * valprint.h (struct value_print_options) <finish_print>: New
6631         member.
6632
6633 2019-05-28  Tom Tromey  <tromey@adacore.com>
6634
6635         * ada-lang.c (ada_remove_Xbn_suffix)
6636         (find_old_style_renaming_symbol)
6637         (parse_old_style_renaming): Remove.
6638         (ada_find_renaming_symbol): Don't call
6639         find_old_style_renaming_symbol.
6640         (ada_is_renaming_symbol): Rename from
6641         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6642         bool.  Now static.
6643         (ada_read_var_value): Update and simplify.
6644         * ada-exp.y (write_var_or_type): Remove old code.
6645
6646 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6647
6648         * event-top.c: Remove include comment.
6649         * inflow.c (class scoped_ignore_sigttou): Move from here...
6650         * inflow.h (class scoped_ignore_sigttou): ...to here.
6651         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6652         * top.c:  Remove include comment.
6653
6654 2019-05-27  Tom Tromey  <tom@tromey.com>
6655
6656         * NEWS: Fix typo.
6657
6658 2019-05-22  Tom Tromey  <tromey@adacore.com>
6659
6660         * target.c (target_follow_exec): Constify parameter.
6661         * target-delegates.c: Rebuild.
6662         * remote.c (remote_target::follow_exec): Constify parameter.
6663         * infrun.c (follow_exec): Constify parameter.
6664         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6665         (target_follow_exec): Likewise.
6666
6667 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6668
6669         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6670         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6671
6672 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6673
6674         * NEWS: Add debugredirect and testsuite sections.
6675
6676 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6677
6678         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6679         target descriptions using exclusively floating point register name
6680         aliases.
6681
6682 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         PR gdb/18644:
6685         * f-lang.c (build_fortran_types): Handle the case where
6686         gdbarch_floatformat_for_type returns a nullptr.
6687
6688 2019-05-21  Tom de Vries  <tdevries@suse.de>
6689
6690         PR cli/24587
6691         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6692
6693 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         PR gdb/18644:
6696         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6697         16-byte floats.
6698         * i386-tdep.c (i386_floatformat_for_type): Use
6699         floatformats_ia64_quad for the 16-byte floating point component
6700         within a fortran 32-byte complex number.
6701
6702 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6705         delete default constructor.
6706         (find_partial_die): Update to return const struct.
6707         (partial_die_parent_scope): Move variable declaration into scope
6708         of its use and change its type to auto.
6709         (guess_partial_die_structure_name): Likewise.
6710         (partial_die_info::fixup): Likewise.
6711
6712 2019-05-17  Tom Tromey  <tromey@adacore.com>
6713
6714         * source.c (find_and_open_source): Remove cast.
6715
6716 2019-05-17  Tom Tromey  <tromey@adacore.com>
6717
6718         * annotate.c (annotate_source): Make "filename" const.
6719         * annotate.h (annotate_source): Use const.
6720
6721 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6722
6723         * disasm.c (set_disassembler_options): Send errors to stderr.
6724
6725 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6728         (cli_interp_base::set_logging): Check debug_redirect.
6729         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6730         * cli/cli-logging.c (debug_redirect): Add static variable.
6731         (pop_output_files): Add default param.
6732         (handle_redirections): Print debug setting.
6733         (show_logging_command): Likewise.
6734         (_initialize_cli_logging): Add debugredirect command.
6735         * interps.c (current_interp_set_logging): Add debug_redirect
6736         parameter.
6737         * interps.h (set_logging): Add debug_redirect parameter.
6738         (current_interp_set_logging): Likewise.
6739         * mi/mi-common.h: Likewise.
6740         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6741
6742 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6743             Tom Tromey  <tromey@adacore.com>
6744
6745         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6746         directly.
6747         * cli/cli-interp.h (make_logging_output): Remove declaration.
6748         * cli/cli-logging.c (make_logging_output): Remove function.
6749         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6750         directly.
6751         * ui-file.c (tee_file::tee_file): Remove bools.
6752         (tee_file::~tee_file): Remove deletes.
6753         * ui-file.h (tee_file): Remove bools.
6754
6755 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6756
6757         * mi/mi-cmds.h (mi_cmd_complete): New function.
6758         * mi/mi-main.c (mi_cmd_complete): Likewise.
6759         * mi/mi-cmds.c: Define new MI command -complete.
6760         * NEWS: Mention new -complete command.
6761
6762 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6763
6764         * completer.h (complete): New function.
6765         * completer.c (complete): Likewise.
6766         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6767         function defined in completer.h.
6768
6769 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6770
6771         * MAINTAINERS (Write After Approval): Add myself.
6772
6773 2019-05-17  Tom de Vries  <tdevries@suse.de>
6774
6775         PR gdb/24094
6776         * dwarf2read.c (struct cu_partial_die_info): New struct.
6777         (find_partial_die): Return cu_partial_die_info.
6778         (partial_die_parent_scope, guess_partial_die_structure_name)
6779         (partial_die_info::fixup): Handle new return type of find_partial_die.
6780
6781 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6782
6783         PR breakpoints/24541
6784         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6785         "std::string", simplifying the algorithm.
6786
6787 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6788
6789         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6790         (stap_static_probe_ops::get_probes): Likewise.
6791
6792 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6793
6794         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6795         '-')" and "else if".
6796         (stap_parse_single_operand): Join checks for
6797         "gdbarch_stap_parse_special_token_p" and
6798         "gdbarch_stap_parse_special_token" in the same "if" statement.
6799         Invert check when verifying for operation on register
6800         displacement.
6801
6802 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6803
6804         * stap-probe.c (stap_get_opcode): Update comment.
6805         (stap_get_expected_argument_type): Likewise.
6806         (handle_stap_probe): Likewise.
6807
6808 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6809
6810         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6811         return type to 'bool'.  Adjust comment.  Use 'bool' when
6812         appropriate.
6813         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6814         * stap-probe.c (stap_parse_argument_1): Likewise.
6815         (stap_is_operator): Likewise.
6816         (stap_is_generic_prefix): Likewise.
6817         (stap_is_register_prefix): Likewise.
6818         (stap_is_register_indirection_prefix): Likewise.
6819         (stap_is_integer_prefix): Likewise.
6820         (stap_generic_check_suffix): Likewise.
6821         (stap_check_integer_suffix): Likewise.
6822         (stap_check_register_suffix): Likewise.
6823         (stap_check_register_indirection_suffix): Likewise.
6824         (stap_parse_register_operand): Likewise.
6825         (stap_parse_single_operand): Likewise.
6826         (stap_parse_argument_1): Likewise.
6827         (stap_probe::get_argument_count): Likewise.
6828         (stap_is_operator): Likewise.
6829
6830 2019-05-16  Tom Tromey  <tromey@adacore.com>
6831
6832         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6833         keyword to foreach.
6834
6835 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6836
6837         * linux-thread-db.c (try_thread_db_load_1): Change return type
6838         to bool.
6839         (try_thread_db_load): Likewise.
6840         (try_thread_db_load_from_pdir_1): Likewise.
6841         (try_thread_db_load_from_pdir): Likewise.
6842         (try_thread_db_load_from_sdir): Likewise.
6843         (try_thread_db_load_from_dir): Likewise.
6844         (thread_db_load_search): Likewise.
6845         (has_libpthread): Likewise.
6846         (thread_db_load): Likewise.
6847
6848 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6849
6850         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6851         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6852         NULL, and complain/return if that's the case.
6853
6854 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6855
6856         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6857         (advance, posn, abstract_read_memory): New functions.
6858         [struct mem_read_abstraction]: New struct.
6859         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6860
6861 2019-05-14  Tom Tromey  <tromey@adacore.com>
6862
6863         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6864         value is not lval_memory.
6865
6866 2019-05-14  Tom Tromey  <tromey@adacore.com>
6867
6868         * solib.c (info_sharedlibrary_command): Style the file name.
6869
6870 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6871
6872         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6873         (aarch64_vnv_type): Likewise.
6874         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6875         * common/tdesc.c: Likewise.
6876         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6877         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6878         * features/aarch64-fpu.xml: Add ieee half view.
6879         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6880         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6881         * gdbtypes.h (struct builtin_type): Likewise.
6882         (struct objfile_type): Likewise.
6883
6884 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6885
6886         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6887         typo.
6888         * location.h (string_to_event_location): Likewise.
6889
6890 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6891
6892         GDB 8.3 released.
6893
6894 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6895
6896         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6897         New variable declaration.
6898         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6899         New variable.
6900         (print_one_breakpoint): Use ui_out::test_flags and new global
6901         variable to compute use_fixed_output.
6902         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6903         Remove.
6904         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6905         (mi_multi_location_breakpoint_output_fixed): Remove.
6906         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6907         new variable.
6908         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6909         fix_multi_location_breakpoint_output flag if version >= 3.
6910         * ui-out.h (enum ui_out_flag)
6911         <fix_multi_location_breakpoint_output>: New enumerator.
6912
6913 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6914
6915         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6916
6917 2019-05-10  Tom Tromey  <tromey@adacore.com>
6918
6919         * ada-lang.c (catch_ada_completer): New function.
6920         (_initialize_ada_language): Use it.
6921
6922 2019-05-10  Tom Tromey  <tromey@adacore.com>
6923
6924         * thread.c (print_thread_info): Make "requested_threads" const.
6925         * gdbthread.h (print_thread_info): Make "requested_threads"
6926         const.
6927         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6928         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6929
6930 2019-05-08  Tom Tromey  <tom@tromey.com>
6931
6932         * gdbtypes.c (objfile_type_data): Change type.
6933         (objfile_type, _initialize_gdbtypes): Update.
6934
6935 2019-05-08  Tom Tromey  <tom@tromey.com>
6936
6937         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6938         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6939         (_initialize_dwarf2_frame): Update.
6940
6941 2019-05-08  Tom Tromey  <tom@tromey.com>
6942
6943         * objc-lang.c (objc_objfile_data): Change type.
6944         (find_methods): Update.
6945         (_initialize_objc_lang): Remove.
6946
6947 2019-05-08  Tom Tromey  <tom@tromey.com>
6948
6949         * stabsread.c (rs6000_builtin_type_data): Change type.
6950         (rs6000_builtin_type, _initialize_stabsread): Update.
6951
6952 2019-05-08  Tom Tromey  <tom@tromey.com>
6953
6954         * mips-tdep.c (mips_pdr_data): Remove.
6955         (_initialize_mips_tdep): Update.
6956
6957 2019-05-08  Tom Tromey  <tom@tromey.com>
6958
6959         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6960         (hppa_init_objfile_priv_data, read_unwind_info)
6961         (find_unwind_entry, _initialize_hppa_tdep): Update.
6962
6963 2019-05-08  Tom Tromey  <tom@tromey.com>
6964
6965         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6966         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6967         on obstack.
6968         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6969
6970 2019-05-08  Tom Tromey  <tom@tromey.com>
6971
6972         * mdebugread.c (basic_type_data): Change type.
6973         (basic_type, _initialize_mdebugread): Update.
6974
6975 2019-05-08  Tom Tromey  <tom@tromey.com>
6976
6977         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6978
6979 2019-05-08  Tom Tromey  <tom@tromey.com>
6980
6981         * nto-tdep.c (nto_inferior_data_reg): Change type.
6982         (nto_inferior_data): Update.
6983         (nto_inferior_data_cleanup, nto_new_inferior_data)
6984         (_initialize_nto_tdep): Remove.
6985         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6986
6987 2019-05-08  Tom Tromey  <tom@tromey.com>
6988
6989         * ada-lang.c (struct ada_inferior_data): Add initializers.
6990         (ada_inferior_data): Change type.
6991         (ada_inferior_data_cleanup): Remove.
6992         (get_ada_inferior_data, ada_inferior_exit)
6993         (struct ada_pspace_data): Add initializers, destructor.
6994         (ada_pspace_data_handle): Change type.
6995         (get_ada_pspace_data): Update.
6996         (ada_pspace_data_cleanup): Remove.
6997
6998 2019-05-08  Tom Tromey  <tom@tromey.com>
6999
7000         * coffread.c (struct coff_symfile_info): Add initializers.
7001         (coff_objfile_data_key): Move lower.  Change type.
7002         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7003         Update.
7004         (coff_free_info): Remove.
7005
7006 2019-05-08  Tom Tromey  <tom@tromey.com>
7007
7008         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7009         (fbsd_pspace_data_handle): Move lower.  Change type.
7010         (get_fbsd_pspace_data): Update.
7011         (fbsd_pspace_data_cleanup): Remove.
7012         (_initialize_fbsd_tdep): Update.
7013
7014 2019-05-08  Tom Tromey  <tom@tromey.com>
7015
7016         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7017         (get_ada_tasks_pspace_data): Update.
7018         (ada_tasks_pspace_data_cleanup): Remove.
7019         (_initialize_tasks): Update.
7020         (ada_tasks_inferior_data_handle): Change type.
7021         (get_ada_tasks_inferior_data): Update.
7022         (ada_tasks_inferior_data_cleanup): Remove.
7023         (struct ada_tasks_pspace_data): Add initializers.
7024
7025 2019-05-08  Tom Tromey  <tom@tromey.com>
7026
7027         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7028         * symfile-debug.c (debug_sym_get_probes): Change type.
7029         * stap-probe.c (handle_stap_probe):
7030         (stap_static_probe_ops::get_probes): Change type.
7031         * probe.h (class static_probe_ops) <get_probes>: Change type.
7032         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7033         (parse_probes_in_pspace): Update.
7034         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7035         Update.
7036         (any_static_probe_ops::get_probes): Change type.
7037         * elfread.c (elfread_data): New typedef.
7038         (probe_key): Change type.
7039         (elf_get_probes): Likewise.  Update.
7040         (probe_key_free): Remove.
7041         (_initialize_elfread): Update.
7042         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7043         Change type.
7044         (dtrace_process_dof_probe, dtrace_process_dof)
7045         (dtrace_static_probe_ops::get_probe): Change type.
7046
7047 2019-05-08  Tom Tromey  <tom@tromey.com>
7048
7049         * xcoffread.c (struct xcoff_symfile_info): Rename from
7050         coff_symfile_info.  Add initializers.
7051         (xcoff_objfile_data_key): Move lower.  Change type.
7052         (XCOFF_DATA): Rewrite.
7053         (xcoff_free_info): Remove.
7054         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7055         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7056         (xcoff_initial_scan): Update.
7057
7058 2019-05-08  Tom Tromey  <tom@tromey.com>
7059
7060         * solib-svr4.c (struct svr4_info): Add initializers and
7061         destructor.
7062         <probes_table>: Now an htab_up.
7063         (solib_svr4_pspace_data): Change type.
7064         (free_probes_table): Simplify.
7065         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7066         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7067         (probes_table_remove_objfile_probes, register_solib_event_probe)
7068         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7069         (_initialize_svr4_solib): Update.
7070
7071 2019-05-08  Tom Tromey  <tom@tromey.com>
7072
7073         * remote.c (remote_pspace_data): Change type.
7074         (remote_pspace_data_cleanup): Remove.
7075         (get_remote_exec_file, set_pspace_remote_exec_file)
7076         (_initialize_remote): Update.
7077
7078 2019-05-08  Tom Tromey  <tom@tromey.com>
7079
7080         * breakpoint.c (breakpoint_objfile_key): Change type.
7081         (get_breakpoint_objfile_data): Update.
7082         (free_breakpoint_objfile_data): Remove.
7083         (_initialize_breakpoint): Update.
7084
7085 2019-05-08  Tom Tromey  <tom@tromey.com>
7086
7087         * linux-tdep.c (struct linux_info): Add initializers.
7088         (linux_inferior_data): Move.  Change type.
7089         (invalidate_linux_cache_inf): Update.
7090         (linux_inferior_data_cleanup): Remove.
7091         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7092
7093 2019-05-08  Tom Tromey  <tom@tromey.com>
7094
7095         * auxv.c (auxv_inferior_data): Move.  Change type.
7096         (auxv_inferior_data_cleanup): Remove.
7097         (invalidate_auxv_cache_inf): Rewrite.
7098         (get_auxv_inferior_data, _initialize_auxv): Update.
7099
7100 2019-05-08  Tom Tromey  <tom@tromey.com>
7101
7102         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7103         (symfile_debug_objfile_data_key): Change type.
7104         (symfile_debug_installed, debug_qf_has_symbols)
7105         (debug_qf_find_last_source_symtab)
7106         (debug_qf_forget_cached_source_info)
7107         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7108         (debug_qf_print_stats, debug_qf_dump)
7109         (debug_qf_expand_symtabs_for_function)
7110         (debug_qf_expand_all_symtabs)
7111         (debug_qf_expand_symtabs_with_fullname)
7112         (debug_qf_map_matching_symbols)
7113         (debug_qf_expand_symtabs_matching)
7114         (debug_qf_find_pc_sect_compunit_symtab)
7115         (debug_qf_map_symbol_filenames)
7116         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7117         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7118         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7119         (debug_sym_read_linetable, debug_sym_relocate): Update.
7120         (symfile_debug_free_objfile): Remove.
7121         (install_symfile_debug_logging, _initialize_symfile_debug):
7122         Update.
7123
7124 2019-05-08  Tom Tromey  <tom@tromey.com>
7125
7126         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7127         allocate_on_obstack.
7128         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7129         (get_dwarf2_per_objfile): Update.
7130         (set_dwarf2_per_objfile): Remove.
7131         (dwarf2_has_info, dwarf2_get_section_info): Update.
7132         (dwarf2_free_objfile): Remove.
7133         (_initialize_dwarf2_read): Update.
7134
7135 2019-05-08  Tom Tromey  <tom@tromey.com>
7136
7137         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7138         initializers.
7139         <unsupported_script_warning_printed,
7140         script_not_found_warning_printed>: Now bool.
7141         (auto_load_pspace_data): Change type.
7142         (~auto_load_pspace_info): Rename from
7143         auto_load_pspace_data_cleanup.
7144         (get_auto_load_pspace_data, init_loaded_scripts_info)
7145         (clear_section_scripts, maybe_print_unsupported_script_warning)
7146         (maybe_print_script_not_found_warning, _initialize_auto_load):
7147         Update.
7148
7149 2019-05-08  Tom Tromey  <tom@tromey.com>
7150
7151         * objfiles.c (objfile_pspace_info): Add destructor and
7152         initializers.
7153         (objfiles_pspace_data): Change type.
7154         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7155         (get_objfile_pspace_data): Update.
7156         (objfiles_bfd_data): Change type.
7157         (get_objfile_bfd_data): Update.
7158         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7159
7160 2019-05-08  Tom Tromey  <tom@tromey.com>
7161
7162         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7163         Change type.
7164         (get_catch_syscall_inferior_data): Update.
7165         (catch_syscall_inferior_data_cleanup): Remove.
7166         (_initialize_break_catch_syscall): Update.
7167
7168 2019-05-08  Tom Tromey  <tom@tromey.com>
7169
7170         * inflow.c (struct terminal_info): Add destructor and
7171         initializers.
7172         (inflow_inferior_data): Change type.
7173         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7174         (get_inflow_inferior_data, inflow_inferior_exit)
7175         (swap_terminal_info, _initialize_inflow): Update.
7176
7177 2019-05-08  Tom Tromey  <tom@tromey.com>
7178
7179         * target-dcache.c (target_dcache_cleanup): Remove.
7180         (target_dcache_aspace_key): Change type.
7181         (target_dcache_init_p, target_dcache_invalidate)
7182         (target_dcache_get, target_dcache_get_or_init)
7183         (_initialize_target_dcache): Update.
7184         * dcache.h (struct dcache_deleter): New.
7185
7186 2019-05-08  Tom Tromey  <tom@tromey.com>
7187
7188         * symtab.c (struct symbol_cache): Add destructor and
7189         initializers.
7190         (symbol_cache_key): Move.  Change type.
7191         (make_symbol_cache, free_symbol_cache): Remove.
7192         (get_symbol_cache): Update.
7193         (symbol_cache_cleanup): Remove.
7194         (ALL_PSPACES, symbol_cache_flush)
7195         (maintenance_print_symbol_cache)
7196         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7197         Update.
7198
7199 2019-05-08  Tom Tromey  <tom@tromey.com>
7200
7201         * symtab.c (struct main_info): Add destructor and initializers.
7202         (main_progspace_key): Move.  Change type.
7203         (get_main_info): Update.
7204         (main_info_cleanup): Remove.
7205         (_initialize_symtab): Update.
7206
7207 2019-05-08  Tom Tromey  <tom@tromey.com>
7208
7209         * registry.h (DECLARE_REGISTRY): Define the _key class.
7210
7211 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * NEWS: Merge two 'New commands' sections.
7214
7215 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7216
7217         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7218         parameter and use Ada language definition instead.
7219         (ada_val_print_ptr): Remove unused language parameter.
7220         (ada_val_print_num): Remove language parameter and use Ada language
7221         definition instead.
7222         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7223         parameter.
7224         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7225         parameter and use Ada language definition instead.
7226         (ada_val_print_1): Update all ada_val_print_xxx calls.
7227         Remove language parameter.
7228         (ada_val_print): Update ada_val_print_1 call.
7229
7230 2019-05-08  Tom Tromey  <tromey@adacore.com>
7231
7232         * remote.c (remote_hw_watchpoint_limit)
7233         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7234         Now static.
7235
7236 2019-05-08  Tom Tromey  <tromey@adacore.com>
7237
7238         * maint.c (_initialize_maint_cmds): Move initialization code to
7239         remote.c.
7240         (watchdog, show_watchdog): Move to remote.c.
7241         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7242         "watchdog" static.
7243         (_initialize_remote): Move initialization code from maint.c.
7244         * defs.h (watchdog): Don't declare.
7245
7246 2019-05-08  Tom Tromey  <tromey@adacore.com>
7247
7248         * tui/tui-interp.c: Include main.h.
7249         * interps.c: Include main.h.
7250         * main.h (interpreter_p): Declare.
7251         * defs.h (interpreter_p): Don't declare.
7252
7253 2019-05-08  Tom Tromey  <tromey@adacore.com>
7254
7255         * dwarf2loc.c: Include dwarf2read.h.
7256         * defs.h (read_unsigned_leb128): Don't declare.
7257         * dwarf2read.h (read_unsigned_leb128): Declare.
7258
7259 2019-05-08  Tom Tromey  <tromey@adacore.com>
7260
7261         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7262         method.
7263
7264 2019-05-08  Tom Tromey  <tromey@adacore.com>
7265
7266         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7267         when no wrap column is set.
7268
7269 2019-05-08  Tom Tromey  <tromey@adacore.com>
7270
7271         * c-lang.c (c_get_string): Handle non-C-style arrays.
7272
7273 2019-05-08  Tom Tromey  <tromey@adacore.com>
7274
7275         * typeprint.c (print_offset_data::update): Print the bit offset,
7276         not the number of bits remaining.
7277
7278 2019-05-08  Tom Tromey  <tromey@adacore.com>
7279
7280         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7281         padding at end of comment.
7282
7283 2019-05-08  Tom Tromey  <tromey@adacore.com>
7284
7285         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7286         Compare main types.
7287
7288 2019-05-06  Tom Tromey  <tom@tromey.com>
7289
7290         * common/scoped_mmap.c: Include common-defs.h.
7291         * common/scoped_mmap.h: Don't include config.h.
7292
7293 2019-05-04  Tom Tromey  <tom@tromey.com>
7294
7295         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7296         (struct aarch64_call_info): Add initializers.
7297         <si>: Now a std::vector.
7298         (pass_on_stack, aarch64_push_dummy_call): Update.
7299
7300 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7301             Tom Tromey  <tom@tromey.com>
7302
7303         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7304         (ppc_threads): Now a std::vector.  Now static.
7305         (hwdebug_find_thread_points_by_tid)
7306         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7307         Update.
7308
7309 2019-05-04  Tom Tromey  <tom@tromey.com>
7310
7311         * arc-tdep.c (arc_tdesc_init): Return bool.
7312
7313 2019-05-04  Tom Tromey  <tom@tromey.com>
7314
7315         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7316         Use gdb_assert_not_reached.
7317
7318 2019-05-04  Tom Tromey  <tom@tromey.com>
7319
7320         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7321         "false".
7322
7323 2019-05-04  Tom Tromey  <tom@tromey.com>
7324
7325         * arc-tdep.c (arc_tdesc_init): Use bool.
7326
7327 2019-05-04  Tom Tromey  <tom@tromey.com>
7328
7329         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7330
7331 2019-05-04  Tom Tromey  <tom@tromey.com>
7332
7333         * cli/cli-cmds.c (valid_command_p): Return bool.
7334
7335 2019-05-04  Tom Tromey  <tom@tromey.com>
7336
7337         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7338         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7339
7340 2019-05-04  Raul Tambre  <raul@tambre.ee>
7341
7342         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7343         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7344         operator for comparison.
7345
7346 2019-05-04  Tom Tromey  <tom@tromey.com>
7347
7348         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7349         (lookup_partial_symbol, print_partial_symbols)
7350         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7351         (psymbol_compare): Update.
7352         (add_psymbol_to_bcache): Clear the entire psymbol.
7353         (maintenance_check_psymtabs): Update.
7354         * psympriv.h (struct partial_symbol): Don't derive from
7355         general_symbol_info.
7356         <obj_section, unrelocated_address, address,
7357         set_unrelocated_address>: Update.
7358         <ginfo>: New member.
7359         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7360         (debug_names::write_psymbols): Update.
7361
7362 2019-05-04  Tom de Vries  <tdevries@suse.de>
7363
7364         * contrib/cc-with-tweaks.sh: Support -n arg.
7365
7366 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7367
7368         * corelow.c (core_target::detach): Ensure frame cache and
7369         register caches are cleared.
7370         inferior.c (exit_inferior_1): Likewise.
7371
7372 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7373             Tom Tromey  <tom@tromey.com>
7374
7375         * dictionary.c (collate_pending_symbols_by_language): Remove
7376         "struct" from foreach.
7377         * symtab.c (lookup_global_symbol_from_objfile)
7378         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7379         foreach.
7380         * ser-tcp.c (net_open): Remove "struct" from foreach.
7381         * objfiles.c (objfile_relocate, objfile_rebase)
7382         (objfile_has_symbols): Remove "struct" from foreach.
7383         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7384         from foreach.
7385         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7386         foreach.
7387         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7388         "struct" from foreach.
7389         * ada-lang.c (create_excep_cond_exprs)
7390         (ada_exception_catchpoint_cond_string): Remove "struct" from
7391         foreach.
7392
7393 2019-05-03  Tom Tromey  <tromey@adacore.com>
7394
7395         * ada-exp.y (convert_char_literal): Check suffix of each
7396         enumerator.
7397
7398 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7399
7400         PR ada/21406:
7401         * ada-exp.y (yywrap): Don't define.
7402         * ada-lex.l (%option): Add noyywrap
7403         (yywrap): Remove.
7404
7405 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7406
7407         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7408         _WIN32_WINNT to the XP level, unless already defined to a higher
7409         level.
7410
7411         * unittests/parse-connection-spec-selftests.c:
7412         * ser-tcp.c:
7413         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7414         override.
7415
7416         * symfile.c (find_separate_debug_file): Remove colon from the
7417         drive spec of DOS/Windows file names of the target, so that the
7418         file name produced from DEBUGDIR and the target's directory will
7419         be valid on DOS/Windows systems.
7420
7421 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7422
7423         * rust-lang.c (val_print_struct): Handle printing structures
7424         containing strings.
7425
7426 2019-05-02  Tom Tromey  <tromey@adacore.com>
7427
7428         * valarith.c (_initialize_valarith): Remove.
7429
7430 2019-05-01  Tom Tromey  <tromey@adacore.com>
7431
7432         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7433         bitfields.
7434
7435 2019-05-01  Tom Tromey  <tromey@adacore.com>
7436
7437         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7438         for big-endian copies.
7439
7440 2019-04-30  Ali Tamur  <tamur@google.com>
7441         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7442         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7443         (read_3_bytes): New function.
7444
7445 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7446
7447         * windows-nat.c (main_thread_id): Delete.
7448         (handle_output_debug_string): Replace main_thread_id by
7449         current_event.dwThreadId.
7450         (fake_create_process): Likewise.
7451         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7452         Do not set main_thread_id.
7453         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7454         current_event.dwThreadId.
7455         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7456
7457 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7458
7459         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7460         Use current_event.dwThreadId instead of main_thread_id.
7461
7462 2019-04-30  Tom Tromey  <tromey@adacore.com>
7463
7464         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7465         (create_excep_cond_exprs): Iterate over program spaces.
7466         (ada_exception_catchpoint_cond_string): Examine all minimal
7467         symbols for exception types.
7468
7469 2019-04-30  Tom Tromey  <tromey@adacore.com>
7470
7471         PR c++/24470:
7472         * dwarf2read.c (process_structure_scope): Handle case where type
7473         has template parameters but no symbol was created.
7474
7475 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7476             Chris January  <chris.january@arm.com>
7477
7478         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7479         qualifier.
7480         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7481
7482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * f-typeprint.c (f_print_type): Update rules for printing
7485         whitespace.
7486         (f_type_print_varspec_suffix): Likewise.
7487
7488 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7489             Chris January  <chris.january@arm.com>
7490
7491         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7492         function arguments.
7493
7494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7495
7496         * f-lang.c (build_fortran_types): Change name of void type to
7497         lower case.
7498         * f-typeprint.c (f_type_print_base): Print the name of the void
7499         type, rather than a fixed string.
7500         * f-valprint.c (f_decorations): Use lower case void string.
7501
7502 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7503             Chris January  <chris.january@arm.com>
7504
7505         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7506         types for Fortran.
7507
7508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7509             Chris January  <chris.january@arm.com>
7510             David Lecomber  <david.lecomber@arm.com>
7511
7512         * f-exp.y (BINOP_INTRINSIC): New token.
7513         (exp): New parser rule handling BINOP_INTRINSIC.
7514         (f77_keywords): Add new builtin procedures.
7515         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7516         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7517         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7518         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7519         (print_unop_subexp_f): New function.
7520         (print_binop_subexp_f): New function.
7521         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7522         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7523         (dump_subexp_body_f): Likewise.
7524         (operator_check_f): Likewise.
7525         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7526         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7527
7528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7531         UNOP_KIND.
7532         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7533         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7534         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7535         (operator_length_f): New fuction.
7536         (print_subexp_f): New function.
7537         (op_name_f): New function.
7538         (dump_subexp_body_f): New function.
7539         (operator_check_f): New function.
7540         (exp_descriptor_f): Replace standard expression handling functions
7541         with new functions.
7542         * gdb/fortran-operator.def: New file.
7543         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7544         * gdb/std-operator.def: Remove UNOP_KIND.
7545
7546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * std-operator.def: Remove unbalanced, stray double quote
7549         character.
7550
7551 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7552             Chris January  <chris.january@arm.com>
7553             Daniel Everett  <daniel.everett@arm.com>
7554             Nick Forrington  <nick.forrington@arm.com>
7555             Richard Bunt  <richard.bunt@arm.com>
7556
7557         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7558         of depth when printing anonymous structs or unions.
7559         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7560         Don't print either the top-level value, or the children if the
7561         max-depth is exceeded.
7562         (ppscm_print_children): When printing the key of a map, allow one
7563         extra level of depth.
7564         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7565         print either the top-level value, or the children if the max-depth
7566         is exceeded.
7567         (print_children): When printing the key of a map, allow one extra
7568         level of depth.
7569         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7570         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7571         (user_print_options): Initialise max_depth field.
7572         (val_print_scalar_or_string_type_p): New function.
7573         (val_print): Check to see if the max depth has been reached.
7574         (val_print_check_max_depth): Define new function.
7575         (show_print_max_depth): New function.
7576         (_initialize_valprint): Add 'print max-depth' option.
7577         * valprint.h (struct value_print_options) <max_depth>: New field.
7578         (val_print_check_max_depth): Declare new function.
7579         * NEWS: Document new feature.
7580
7581 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * ada-lang.c (ada_language_defn): Initialise new field.
7584         * c-lang.c (c_is_string_type_p): New function.
7585         (c_language_defn): Initialise new field.
7586         (cplus_language_defn): Initialise new field.
7587         (asm_language_defn): Initialise new field.
7588         (minimal_language_defn): Initialise new field.
7589         * c-lang.h (c_is_string_type_p): Declare new function.
7590         * d-lang.c (d_language_defn): Initialise new field.
7591         * f-lang.c (f_is_string_type_p): New function.
7592         (f_language_defn): Initialise new field.
7593         * go-lang.c (go_is_string_type_p): New function.
7594         (go_language_defn): Initialise new field.
7595         * language.c (default_is_string_type_p): New function.
7596         (unknown_language_defn): Initialise new field.
7597         (auto_language_defn): Initialise new field.
7598         * language.h (struct language_defn) <la_is_string_type_p>: New
7599         member variable.
7600         (default_is_string_type_p): Declare new function.
7601         * m2-lang.c (m2_language_defn): Initialise new field.
7602         * objc-lang.c (objc_language_defn): Initialise new field.
7603         * opencl-lang.c (opencl_language_defn): Initialise new field.
7604         * p-lang.c (pascal_is_string_type_p): New function.
7605         (pascal_language_defn): Initialise new field.
7606         * rust-lang.c (rust_is_string_type_p): New function.
7607         (rust_language_defn): Initialise new field.
7608
7609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7612         New field.
7613         * ada-lang.c (ada_language_defn): Initialise new field.
7614         * c-lang.c (c_language_defn): Likewise.
7615         (cplus_language_defn): Likewise.
7616         (asm_language_defn): Likewise.
7617         (minimal_language_defn): Likewise.
7618         * d-lang.c (d_language_defn): Likewise.
7619         * f-lang.c (f_language_defn): Likewise.
7620         * go-lang.c (go_language_defn): Likewise.
7621         * language.c (unknown_language_defn): Likewise.
7622         (auto_language_defn): Likewise.
7623         * m2-lang.c (m2_language_defn): Likewise.
7624         * objc-lang.c (objc_language_defn): Likewise.
7625         * opencl-lang.c (opencl_language_defn): Likewise.
7626         * p-lang.c (pascal_language_defn): Likewise.
7627         * rust-lang.c (rust_language_defn): Likewise.
7628
7629 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7630
7631         * ada-lang.c (ada_is_character_type): Change return type to bool.
7632         (ada_is_string_type): Likewise.
7633         * ada-lang.h (ada_is_character_type): Update declaration
7634         (ada_is_string_type): Likewise.
7635
7636 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7637
7638         Support style in 'frame|thread apply'
7639
7640         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7641         * record.c (record_start, record_stop): Update callers of
7642         execute_command_to_string with false.
7643         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7644         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7645         methods.
7646         (class string_file): New constructor with term_out parameter.
7647         Override methods term_out and can_emit_style_escape.  New member
7648         term_out.
7649         (class stdio_file): Override can_emit_style_escape.
7650         (class tee_file): Override term_out and can_emit_style_escape.
7651         * utils.h (can_emit_style_escape): Remove.
7652         * utils.c (can_emit_style_escape): Likewise.
7653         Update all callers of can_emit_style_escape (SOMESTREAM) to
7654         SOMESTREAM->can_emit_style_escape.
7655         * source-cache.c (source_cache::get_source_lines): Likewise.
7656         * stack.c (frame_apply_command_count): Call execute_command_to_string
7657         passing the term_out characteristic of the current gdb_stdout.
7658         * thread.c (thr_try_catch_cmd): Likewise.
7659         * top.c (execute_command_to_string): pass term_out parameter
7660         to construct the string_file for the command output.
7661         * ui-file.c (term_cli_styling): New function (most code moved
7662         from utils.c can_emit_style_escape).
7663         (string_file::string_file, string_file::can_emit_style_escape,
7664         stdio_file::can_emit_style_escape, tee_file::term_out,
7665         tee_file::can_emit_style_escape): New functions.
7666
7667 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7668
7669         * NEWS: Mention the new set|show may-call-functions.
7670         * infcall.c (may_call_functions_p): New variable.
7671         (show_may_call_functions_p): New function.
7672         (call_function_by_hand_dummy): Throws an error if not
7673         may-call-functions.
7674         (_initialize_infcall): Call add_setshow_boolean_cmd for
7675         may-call-functions.
7676
7677 2019-04-25  Keith Seitz  <keiths@redhat.com>
7678
7679         PR c++/24367
7680         * cp-support.c (inspect_type): Don't attempt substitutions
7681         of symbol with the same name.
7682
7683 2019-04-25  Tom Tromey  <tromey@adacore.com>
7684
7685         PR gdb/24475:
7686         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7687         static.
7688
7689 2019-04-25  Tom Tromey  <tromey@adacore.com>
7690
7691         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7692         rvalue reference.
7693         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7694         (gdb_xml_parser::parse): Use std::move.
7695         * python/python-internal.h (gdbpy_convert_exception): Take a const
7696         reference.
7697         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7698         std::move.
7699         * python/py-utils.c (gdbpy_convert_exception): Take a const
7700         reference.
7701         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7702         Use std::move.
7703         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7704         Use std::move.
7705         * mi/mi-main.c (mi_print_exception): Take a const reference.
7706         * main.c (handle_command_errors): Take a const reference.
7707         * linespec.c (parse_linespec): Use std::move.
7708         * infcall.c (run_inferior_call): Use std::move.
7709         (call_function_by_hand_dummy): Use std::move.
7710         * exec.c (try_open_exec_file): Use std::move.
7711         * exceptions.h (exception_print, exception_fprintf)
7712         (exception_print_same): Update.
7713         * exceptions.c (print_exception, exception_print)
7714         (exception_fprintf, exception_print_same): Change parameters to
7715         const reference.
7716         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7717         * common/new-op.c: Use std::move.
7718         * common/common-exceptions.h (struct gdb_exception): Add move
7719         constructor.
7720         (struct gdb_exception_error, struct gdb_exception_quit, struct
7721         gdb_quit_bad_alloc): Change constructor to move constructor.
7722         (throw_exception): Change parameter to rvalue reference.
7723         * common/common-exceptions.c (throw_exception): Take rvalue
7724         reference.
7725         * cli/cli-interp.c (safe_execute_command): Use std::move.
7726         * breakpoint.c (insert_bp_location, location_to_sals): Use
7727         std::move.
7728
7729 2019-04-25  Tom Tromey  <tromey@adacore.com>
7730
7731         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7732         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7733         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7734         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7735         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7736         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7737         guile/scm-value.c: Use unpack.
7738         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7739         gdbscm_gdb_exception.
7740         (gdbscm_throw_gdb_exception): Likewise.
7741         (struct gdbscm_gdb_exception): New.
7742         (unpack): New function.
7743         (gdbscm_wrap): Use unpack.
7744
7745 2019-04-25  Tom Tromey  <tromey@adacore.com>
7746
7747         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7748         (gdb_rl_callback_handler): Use std::move.
7749         * common/common-exceptions.h (struct gdb_exception): Add move
7750         assignment operator.
7751         (throw_exception_sjlj): Change "exception" to const reference.
7752         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7753         (throw_exception_sjlj): Change "exception" to const reference.
7754
7755 2019-04-25  Tom Tromey  <tromey@adacore.com>
7756
7757         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7758         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7759         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7760         Update.
7761         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7762         Update.
7763         * mi/mi-interp.c (mi_interp::exec): Update.
7764         * linespec.c (parse_linespec): Update.
7765         * infcall.c (run_inferior_call): Update.
7766         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7767         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7768         (gdbscm_lookup_global_symbol): Update.
7769         * guile/scm-param.c (gdbscm_parameter_value): Update.
7770         * guile/scm-frame.c (gdbscm_frame_read_register)
7771         (gdbscm_frame_read_var): Update.
7772         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7773         * exec.c (try_open_exec_file): Update.
7774         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7775         (gdb_rl_callback_handler): Update.
7776         * common/common-exceptions.h (exception_none): Don't declare.
7777         * common/common-exceptions.c (exception_none): Don't define.
7778         (struct catcher) <exception>: Update.
7779         * cli/cli-interp.c (safe_execute_command): Update.
7780         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7781
7782 2019-04-25  Ali Tamur  <tamur@google.com>
7783
7784         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7785         (read_attribute_value): Likewise.
7786         (dwarf2_read_addr_index): Update comment.
7787         (read_str_index): Add DW_FORM_strx.
7788         (dwarf2_string_attr): Likewise.
7789         (dwarf2_const_value_attr): Likewise.
7790         (dump_die_shallow): Likewise.
7791         (dwarf2_fetch_constant_bytes): Likewise.
7792         (skip_form_bytes): Likewise.
7793         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7794
7795 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7796
7797         PR corefiles/11608
7798         PR corefiles/18187
7799         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7800         OFFSET.  Verify if current mapping contains an ELF header.
7801         (linux_find_memory_regions_full): Adjust call to
7802         dump_mapping_p.
7803
7804 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7805             Kang Li <kanglictf@gmail.com>
7806
7807         PR gdb/21600
7808
7809         * dwarf2-frame.c (read_initial_length): Be consistent about using
7810         unsigned representation of length.
7811         (decode_frame_entry_1): Likewise.  Check for wraparound of
7812         end pointer as well as buffer overflow.
7813
7814 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7815
7816         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7817         "vq".
7818
7819 2019-04-24  Tom Tromey  <tromey@adacore.com>
7820
7821         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7822
7823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * s12z-tdep.c (s12z_unwind_pc): Delete.
7826         (s12z_unwind_sp): Delete.
7827         (s12z_gdbarch_init): Don't register deleted functions with
7828         gdbarch.
7829
7830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * rl78-tdep.c (rl78_unwind_sp): Delete.
7833         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7834
7835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7838         (xstormy16_unwind_pc): Delete.
7839         (xstormy16_dummy_id): Delete.
7840         (xstormy16_gdbarch_init): Don't register deleted functions with
7841         gdbarch.
7842
7843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * vax-tdep.c (vax_unwind_pc): Delete.
7846         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7847
7848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * v850-tdep.c (v850_unwind_sp): Delete.
7851         (v850_unwind_pc): Delete.
7852         (v850_dummy_id): Delete.
7853         (v850_gdbarch_init): Don't register deleted functions with
7854         gdbarch.
7855
7856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7859         (tilegx_unwind_pc): Delete.
7860         (tilegx_unwind_dummy_id): Delete.
7861         (tilegx_gdbarch_init): Don't register deleted functions with
7862         gdbarch.
7863
7864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7865
7866         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7867         (tic6x_dummy_id): Delete.
7868         (tic6x_gdbarch_init): Don't register deleted functions with
7869         gdbarch.
7870
7871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * sparc-tdep.c (sparc_unwind_pc): Delete.
7874         (sparc32_gdbarch_init): Don't register deleted function with
7875         gdbarch.
7876
7877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7878
7879         * sh-tdep.c (sh_unwind_sp): Delete.
7880         (sh_unwind_pc): Delete.
7881         (sh_dummy_id): Delete.
7882         (sh_gdbarch_init): Don't register deleted functions with
7883         gdbarch.
7884
7885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7886
7887         * score-tdep.c (score_unwind_sp): Delete.
7888         (score_unwind_pc): Delete.
7889         (score_dummy_id): Delete.
7890         (score_gdbarch_init): Don't register deleted functions with
7891         gdbarch.
7892
7893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * rx-tdep.c (rx_unwind_pc): Delete.
7896         (rx_unwind_sp): Delete.
7897         (rx_dummy_id): Delete.
7898         (rx_gdbarch_init): Don't register deleted functions with
7899         gdbarch.  Update comment.
7900
7901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7902
7903         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7904         (rs6000_dummy_id): Delete.
7905         (rs6000_gdbarch_init): Don't register deleted functions with
7906         gdbarch.
7907
7908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7909
7910         * or1k-tdep.c (or1k_dummy_id): Delete.
7911         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7912
7913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * nios2-tdep.c (nios2_dummy_id): Delete.
7916         (nios2_unwind_sp): Delete.
7917         (nios2_gdbarch_init): Don't register deleted functions with
7918         gdbarch.
7919
7920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7921
7922         * nds32-tdep.c (nds32_dummy_id): Delete.
7923         (nds32_unwind_pc): Delete.
7924         (nds32_unwind_sp): Delete.
7925         (nds32_gdbarch_init): Don't register deleted functions with
7926         gdbarch.
7927
7928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * msp430-tdep.c (msp430_unwind_pc): Delete.
7931         (msp430_unwind_sp): Delete.
7932         (msp430_dummy_id): Delete.
7933         (msp430_gdbarch_init): Don't register deleted functions with
7934         gdbarch.
7935
7936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7937
7938         * moxie-tdep.c (moxie_unwind_sp): Delete.
7939         (moxie_unwind_pc): Delete.
7940         (moxie_dummy_id): Delete.
7941         (moxie_gdbarch_init): Don't register deleted functions with
7942         gdbarch.
7943
7944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7945
7946         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7947         (mn10300_unwind_pc): Delete.
7948         (mn10300_unwind_sp): Delete.
7949         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7950         mn10300_unwind_sp.
7951         (mn10300_frame_unwind_init): Don't register deleted functions with
7952         gdbarch.
7953
7954 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * mep-tdep.c (mep_unwind_pc): Delete.
7957         (mep_unwind_sp): Delete.
7958         (mep_dummy_id): Delete.
7959         (mep_gdbarch_init): Don't register deleted functions with
7960         gdbarch.
7961
7962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7963
7964         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7965         (m68hc11_unwind_sp): Delete.
7966         (m68hc11_gdbarch_init): Don't register deleted functions with
7967         gdbarch.
7968
7969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7970
7971         * m32r-tdep.c (m32r_unwind_sp): Delete.
7972         (m32r_unwind_pc): Delete.
7973         (m32r_dummy_id): Delete.
7974         (m32r_gdbarch_init): Don't register deleted functions with
7975         gdbarch.
7976
7977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7978
7979         * m32c-tdep.c (m32c_unwind_pc): Delete.
7980         (m32c_unwind_sp): Delete.
7981         (m32c_dummy_id): Delete.
7982         (m32c_gdbarch_init): Don't register deleted functions with
7983         gdbarch.
7984
7985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7986
7987         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7988         (lm32_unwind_pc): Delete.
7989         (lm32_dummy_id): Delete.
7990         (lm32_gdbarch_init): Don't register deleted functions with
7991         gdbarch.
7992
7993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7994
7995         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7996         (iq2000_unwind_pc): Delete.
7997         (iq2000_dummy_id): Delete.
7998         (iq2000_gdbarch_init): Don't register deleted functions with
7999         gdbarch.
8000
8001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8002
8003         * nds32-tdep.c (nds32_type_align): Delete.
8004         (nds32_push_dummy_call): Use type_align instead.
8005
8006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * arm-tdep.c (arm_type_align): Only handle vector override case.
8009         (arm_push_dummy_call): Use type_align.
8010         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8011
8012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8015         case.
8016         (pass_on_stack): Use type_align.
8017         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8018         function.
8019
8020 2019-04-23  Tom Tromey  <tromey@adacore.com>
8021
8022         * dwarf2read.c (line_header::file_name_at): Remove unused
8023         overload.
8024
8025 2019-04-23  Tom de Vries  <tdevries@suse.de>
8026
8027         PR gdb/24438
8028         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8029         invocation.
8030
8031
8032 2019-03-27  Ali Tamur  <tamur@google.com>
8033
8034         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8035         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8036         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8037         (dwarf_expr_context::get_addr_index): Likewise
8038         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8039         (symbol_needs_eval_context::get_addr_index): Likewise
8040         (disassemble_dwarf_expression): Add DW_OP_addrx
8041         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8042         (read_cutu_die_from_dwo): Update comment
8043         (skip_one_die): Add DW_FORM_addrx
8044         (read_attribute_value): Likewise
8045         (var_decode_location): Add DW_OP_addrx
8046         (dwarf2_const_value_attr): Add DW_FORM_addrx
8047         (dump_die_shallow): Likewise
8048         (dwarf2_fetch_constant_bytes): Likewise
8049         (decode_locdesc): Add DW_OP_addrx
8050         (skip_form_bytes): Add DW_FORM_addrx
8051
8052 2019-04-22  Ali Tamur  <tamur@google.com>
8053
8054         * MAINTAINERS (Write After Approval): Add self.
8055
8056 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8057
8058         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8059         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8060         (open_symbol_file_object): Likewise.
8061         (svr4_default_sos): Add info parameter.
8062         (svr4_read_so_list): Likewise.
8063         (svr4_current_sos_direct): Adjust functions calls to pass down
8064         info.
8065         (svr4_current_sos_1): Add info parameter.
8066         (svr4_current_sos): Call get_svr4_info, pass info down to
8067         svr4_current_sos_1.
8068         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8069         get_svr4_info.
8070         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8071         get_svr4_info.
8072         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8073         to get_svr4_info.
8074         (probes_table_remove_objfile_probes): Likewise.
8075         (register_solib_event_probe): Add info parameter.
8076         (solist_update_incremental): Pass info parameter down to
8077         svr4_read_so_list.
8078         (disable_probes_interface): Add info parameter.
8079         (svr4_handle_solib_event): Pass current_program_space to
8080         get_svr4_info.  Adjust disable_probes_interface cleanup.
8081         (svr4_create_probe_breakpoints): Add info parameter, pass it
8082         down to register_solib_event_probe.
8083         (svr4_create_solib_event_breakpoints): Add info parameter,
8084         pass it down to svr4_create_probe_breakpoints.
8085         (enable_break): Pass info down to
8086         svr4_create_solib_event_breakpoints.
8087         (svr4_solib_create_inferior_hook): Pass current_program_space to
8088         get_svr4_info.
8089         (svr4_clear_solib): Likewise.
8090
8091 2019-04-22  Pedro Alves  <palves@redhat.com>
8092
8093         * solib-svr4.c (svr4_free_objfile_observer): New.
8094         (probe_and_action::objfile): New field.
8095         (probes_table_htab_remove_objfile_probes)
8096         (probes_table_remove_objfile_probes): New functions.
8097         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8098         in the new probe_and_action.  Don't store the probe in 'lookup'.
8099         (svr4_create_probe_breakpoints): Pass objfile to
8100         register_solib_event_probe.
8101         (_initialize_svr4_solib): Register a free_objfile observer.
8102
8103 2019-04-19  Tom Tromey  <tom@tromey.com>
8104
8105         * common/queue.h: Remove.
8106
8107 2019-04-19  Tom Tromey  <tom@tromey.com>
8108
8109         * event-loop.c: Don't include "common/queue.h".
8110
8111 2019-04-19  Tom Tromey  <tom@tromey.com>
8112
8113         * remote.c (remote_target): Use delete.
8114         * remote-notif.h: Include <list>, not "common/queue.h".
8115         (notif_client_p): Remove typedef.
8116         (remote_notif_state): Add constructor, destructor, initializer.
8117         <notif_queue>: Now a std::list.
8118         (remote_notif_state_xfree): Don't declare.
8119         * remote-notif.c (remote_notif_process, handle_notification)
8120         (remote_notif_state_allocate): Update.
8121         (~remote_notif_state): Rename from remote_notif_state_xfree.
8122
8123 2019-04-19  Tom Tromey  <tom@tromey.com>
8124
8125         * symfile.c (reread_symbols): Update.
8126         * objfiles.c (objfile_register_static_link)
8127         (objfile_lookup_static_link): Update
8128         (~objfile) Don't delete static_links.
8129         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8130
8131 2019-04-19  Tom Tromey  <tom@tromey.com>
8132
8133         * type-stack.h (struct type_stack) <insert>: Constify string.
8134         * type-stack.c (type_stack::insert): Constify string.
8135         * gdbtypes.h (lookup_template_type): Update.
8136         (address_space_name_to_int): Update.
8137         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8138         const.
8139         (lookup_template_type): Make name const.
8140         * c-exp.y: Update rules.
8141         (lex_one_token, classify_name, classify_inner_name)
8142         (c_print_token): Update.
8143         * p-exp.y: Update rules.
8144         (yylex): Update.
8145         * f-exp.y: Update rules.
8146         (yylex): Update.
8147         * d-exp.y: Update rules.
8148         (lex_one_token, classify_name, classify_inner_name): Update.
8149         * parse.c (write_dollar_variable, copy_name): Return std::string.
8150         * parser-defs.h (copy_name): Change return type.
8151         * m2-exp.y: Update rules.
8152         (yylex): Update.
8153         * go-exp.y (lex_one_token): Update.
8154         Update rules.
8155         (classify_unsafe_function, classify_packaged_name)
8156         (classify_name, yylex): Update.
8157
8158 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8159
8160         * configure.ac: add --enable-source-highlight switch.
8161         * configure: Regenerate.
8162         * top.c (print_gdb_version): plumb --enable-source-highlight
8163         status to "show configuration".
8164
8165 2019-04-19  Tom Tromey  <tromey@adacore.com>
8166
8167         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8168         Check ADA_TYPE_P.
8169         (empty_record, ada_template_to_fixed_record_type_1)
8170         (template_to_static_fixed_type)
8171         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8172         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8173         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8174         macros.
8175
8176 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8177
8178         PR symtab/24423:
8179         * source.c (print_source_lines_base): Advance "iter" when a
8180         control character is seen.
8181
8182 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8183
8184         * inferior.h (struct infcall_suspend_state_deleter):
8185         Catch exception in destructor to avoid crash.
8186
8187 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8188
8189         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8190         close to the add_com "shell".
8191
8192 2019-04-18  Tom Tromey  <tromey@adacore.com>
8193
8194         * process-stratum-target.h (class process_stratum_target)
8195         <stratum>: Add "final".
8196
8197 2019-04-17  Tom Tromey  <tromey@adacore.com>
8198
8199         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8200         against nullptr before use.
8201
8202 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8203
8204         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8205
8206 2019-04-17  Jim Wilson  <jimw@sifive.com>
8207             Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8210         code read might fail, assume 4-byte breakpoint in that case.
8211
8212 2019-04-15  Leszek Swirski  <leszeks@google.com>
8213
8214         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8215         rather than a hand-rolled POD check when checking for forced MEMORY
8216         classification.
8217
8218 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8219
8220         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8221         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8222         function.
8223         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8224         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8225         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8226         declaration.
8227
8228 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8229
8230         * aarch64-linux-nat.c
8231         (aarch64_linux_nat_target::thread_architecture): Add override.
8232         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8233         each VQ.
8234
8235 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8236
8237         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8238
8239 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8242         target types of size 96-bits, add some additional comments, and
8243         check that the builtin type we found was the correct size.
8244
8245 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8246
8247         * utils.c (prompt_for_continue): Don't restore the styling at the
8248         end, as applied_style has the wrong value.  This fixes styling in
8249         long lists of file names that are interrupted by the "Continue?"
8250         prompt.
8251
8252 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8253
8254         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8255         * c-lang.c (c_language_defn): Likewise.
8256         (cplus_language_defn): Likewise.
8257         (asm_language_defn): Likewise.
8258         (minimal_language_defn): Likewise.
8259         * d-lang.c (d_language_defn): Likewise.
8260         * f-lang.c (f_language_defn): Likewise.
8261         * go-lang.c (go_language_defn): Likewise.
8262         * language.c (unknown_language_defn): Likewise.
8263         (auto_language_defn): Likewise.
8264         * language.h (struct language_defn): Remove la_magic field.
8265         (LANG_MAGIC): Delete.
8266         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8267         * objc-lang.c (objc_language_defn): Likewise.
8268         * opencl-lang.c (opencl_language_defn): Likewise.
8269         * p-lang.c (pascal_language_defn): Likewise.
8270         * rust-lang.c (rust_language_defn): Likewise.
8271
8272 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8273
8274         * riscv-tdep.c (riscv_type_align): New function.
8275         (riscv_type_alignment): Delete.
8276         (riscv_arg_location): Use 'type_align'.
8277         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8278
8279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * gdbtypes.c (type_align): A struct with no non-static fields also
8282         has alignment of 1.
8283
8284 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8287         component to 0.
8288         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8289         member.
8290         (riscv_struct_info::analyse): New implementation using new
8291         analyse_inner member function.
8292         (riscv_struct_info::field_offset): New member function.
8293         (riscv_struct_info::m_offsets): New member variable.
8294         (riscv_struct_info::analyse_inner): New private member function,
8295         takes the old implementation of riscv_struct_info::analyse but
8296         extended to track field offsets.
8297         (riscv_call_arg_struct): Update the struct folding special cases
8298         to handle cases where empty C++ structs, which are non-zero
8299         length, are found.
8300         (riscv_arg_location): Initialise the length of each location, a
8301         non-zero length now indicates the location is in use.
8302         (riscv_push_dummy_call): Allow for the first location having a
8303         non-zero offset when setting up arguments.
8304         (riscv_return_value): Likewise, but for return values.
8305
8306 2019-04-11  Tom Tromey  <tromey@adacore.com>
8307
8308         * utils.c (internal_vproblem): Make "msg" const.
8309
8310 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8311
8312         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8313         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8314         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8315         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8316
8317 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8318
8319         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8320         function.
8321         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8322         of amd64_collect_native_gregset.
8323         (amd64_linux_nat_target::store_registers): Likewise.
8324
8325 2019-04-10  Tom Tromey  <tom@tromey.com>
8326
8327         * symtab.c (lookup_global_symbol_from_objfile)
8328         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8329         * objfiles.h (class separate_debug_iterator): New.
8330         (class separate_debug_range): New.
8331         (struct objfile) <separate_debug_objfiles>: New method.
8332         (objfile_separate_debug_iterate): Don't declare.
8333         * objfiles.c (separate_debug_iterator::operator++): Rename from
8334         objfile_separate_debug_iterate.
8335         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8336         iterator.
8337         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8338         iterator.
8339
8340 2019-04-10  Tom Tromey  <tom@tromey.com>
8341
8342         * symfile.c (reread_symbols): Remove old comment.
8343         * objfiles.c (free_all_objfiles): Fix a typo.
8344
8345 2019-04-10  Tom Tromey  <tom@tromey.com>
8346
8347         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8348         * minsyms.c (lookup_minimal_symbol): Use foreach.
8349         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8350         (lookup_minimal_symbol_solib_trampoline): Likewise.
8351         * symfile.c (reread_symbols): Use foreach.
8352
8353 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8354             Tom Tromey  <tromey@adacore.com>
8355
8356         PR rust/24414:
8357         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8358         (rust_lex_int_test): Change "value" to be LONGEST.
8359         (rust_lex_tests): Add test for long integer literal.
8360
8361 2019-04-09  Tom Tromey  <tromey@adacore.com>
8362
8363         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8364         to bool.
8365         (extended_remote_target::attach): Update.
8366         (remote_target::remote_notice_new_inferior): Update.
8367         (remote_target::add_current_inferior_and_thread): Update.
8368         * inferior.c (exit_inferior_1): Use "false".
8369         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8370
8371 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8372
8373         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8374         the "start" command.
8375
8376 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8377
8378         * python/py-inferior.c (infpy_thread_from_thread_handle):
8379         Adjust comments to reflect renaming of thread_from_thread_handle
8380         to thread_from_handle.  Adjust keywords.  Fix type error message.
8381         (inferior_object_methods): Add thread_from_handle.  Retain
8382         thread_from_thread_handle, but mark it as deprecated.
8383
8384 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8385
8386         * gdbthread.h (find_thread_by_handle): Revise declaration.
8387         * thread.c (find_thread_by_handle): Likewise.  Adjust
8388         implementation too.
8389         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8390         support for buffer objects as handles.
8391
8392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8393
8394         * python/py-infthread.c (thpy_thread_handle): New function.
8395         (thread_object_methods): Register thpy_thread_handle.
8396
8397 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8398
8399         * gdbthread.h (thread_to_thread_handle): Declare.
8400         * thread.c (gdbtypes.h): Include.
8401         (thread_to_thread_handle): New function.
8402
8403         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8404         (target_thread_info_to_thread_handle): Declare.
8405         * target.c (target_thread_info_to_thread_handle): New function.
8406         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8407         * target-delegates.c: Regenerate.
8408
8409         * linux-thread-db.c (class thread_db_target): Add method
8410         thread_info_to_thread_handle.
8411         (thread_db_target::thread_info_to_thread_handle): Define.
8412         * remote.c (class remote_target): Add new method
8413         thread_info_to_thread_handle.
8414         (remote_target::thread_info_to_thread_handle): Define.
8415
8416 2019-04-08  Pedro Alves  <palves@redhat.com>
8417
8418         * common/common-exceptions.c (throw_exception): Don't create
8419         named object to throw; throw directly.
8420         (throw_it): Likewise.  Don't initialize gdb_exception::message
8421         here, with new; pass FMT and AP to the ctor instead.
8422         * common/common-exceptions.h: Include <string>.
8423         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8424         const char *, va_list)): New ctor.  Use std::make_shared.
8425         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8426         errors)): Delete.
8427         (gdb_exception_error::gdb_exception_error(enum errors, const char
8428         *, va_list)): New.
8429         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8430         Add assertion.
8431         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8432         errors)): Delete.
8433         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8434         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8435         Add assertion.
8436
8437 2019-04-08  Tom Tromey  <tom@tromey.com>
8438
8439         * valops.c (value_rtti_indirect_type): Replace throw_exception
8440         with throw.
8441         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8442         with throw.
8443         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8444         throw.
8445         * target.c (target_translate_tls_address): Replace throw_exception
8446         with throw.
8447         * stack.c (frame_apply_command_count): Replace throw_exception
8448         with throw.
8449         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8450         throw.
8451         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8452         with throw.
8453         * rs6000-tdep.c (rs6000_frame_cache)
8454         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8455         * remote.c: Replace throw_exception with throw.
8456         * record-full.c (record_full_message, record_full_wait_1)
8457         (record_full_restore): Replace throw_exception with throw.
8458         * record-btrace.c:
8459         (get_thread_current_frame_id, record_btrace_start_replaying)
8460         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8461         (cmd_record_btrace_start): Replace throw_exception with throw.
8462         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8463         throw.
8464         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8465         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8466         * linespec.c:
8467         (find_linespec_symbols): Replace throw_exception with throw.
8468         * infrun.c (displaced_step_prepare, resume): Replace
8469         throw_exception with throw.
8470         * infcmd.c (post_create_inferior): Replace throw_exception with
8471         throw.
8472         * inf-loop.c (inferior_event_handler): Replace throw_exception
8473         with throw.
8474         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8475         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8476         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8477         (get_prev_frame_always, get_frame_pc_if_available)
8478         (get_frame_address_in_block_if_available, get_frame_language):
8479         Replace throw_exception with throw.
8480         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8481         throw_exception with throw.
8482         * eval.c (fetch_subexp_value, evaluate_var_value)
8483         (evaluate_funcall, evaluate_subexp_standard): Replace
8484         throw_exception with throw.
8485         * dwarf2loc.c (call_site_find_chain)
8486         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8487         Replace throw_exception with throw.
8488         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8489         with throw.
8490         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8491         throw.
8492         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8493         * completer.c (complete_line_internal): Replace throw_exception
8494         with throw.
8495         * compile/compile-object-run.c (compile_object_run): Replace
8496         throw_exception with throw.
8497         * cli/cli-script.c (process_next_line): Replace throw_exception
8498         with throw.
8499         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8500         (btrace_enable, btrace_maint_update_pt_packets): Replace
8501         throw_exception with throw.
8502         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8503         throw_exception with throw.
8504         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8505         throw_exception with throw.
8506         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8507         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8508         * aarch64-tdep.c (aarch64_make_prologue_cache)
8509         (aarch64_make_stub_cache): Replace throw_exception with throw.
8510
8511 2019-04-08  Tom Tromey  <tom@tromey.com>
8512
8513         * common/common-exceptions.c (throw_exception): Rename from
8514         throw_exception_cxx.  Remove old copy.  Make argument const.
8515         (throw_it): Create and throw exception objects directly.
8516         * common/common-exceptions.h (throw_exception): Make argument
8517         const.
8518         (struct gdb_exception_error): Add constructor.
8519         (struct gdb_exception_quit): Add constructor.
8520
8521 2019-04-08  Tom Tromey  <tom@tromey.com>
8522
8523         * common/common-exceptions.h (exception_rethrow): Don't declare.
8524         (TRY_SJLJ): Update comment.
8525         (TRY, CATCH, END_CATCH): Remove.
8526         * common/common-exceptions.c (exception_rethrow): Remove.
8527
8528 2019-04-08  Tom Tromey  <tom@tromey.com>
8529
8530         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8531         Remove.
8532         (gdb_exception_error): Rename from
8533         gdb_exception_RETURN_MASK_ERROR.
8534         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8535         (gdb_quit_bad_alloc): Update.
8536         * aarch64-tdep.c: Update.
8537         * ada-lang.c: Update.
8538         * ada-typeprint.c: Update.
8539         * ada-valprint.c: Update.
8540         * amd64-tdep.c: Update.
8541         * arch-utils.c: Update.
8542         * break-catch-throw.c: Update.
8543         * breakpoint.c: Update.
8544         * btrace.c: Update.
8545         * c-varobj.c: Update.
8546         * cli/cli-cmds.c: Update.
8547         * cli/cli-interp.c: Update.
8548         * cli/cli-script.c: Update.
8549         * common/common-exceptions.c: Update.
8550         * common/new-op.c: Update.
8551         * common/selftest.c: Update.
8552         * compile/compile-c-symbols.c: Update.
8553         * compile/compile-cplus-symbols.c: Update.
8554         * compile/compile-object-load.c: Update.
8555         * compile/compile-object-run.c: Update.
8556         * completer.c: Update.
8557         * corelow.c: Update.
8558         * cp-abi.c: Update.
8559         * cp-support.c: Update.
8560         * cp-valprint.c: Update.
8561         * darwin-nat.c: Update.
8562         * disasm-selftests.c: Update.
8563         * dtrace-probe.c: Update.
8564         * dwarf-index-cache.c: Update.
8565         * dwarf-index-write.c: Update.
8566         * dwarf2-frame-tailcall.c: Update.
8567         * dwarf2-frame.c: Update.
8568         * dwarf2loc.c: Update.
8569         * dwarf2read.c: Update.
8570         * eval.c: Update.
8571         * event-loop.c: Update.
8572         * event-top.c: Update.
8573         * exec.c: Update.
8574         * f-valprint.c: Update.
8575         * fbsd-tdep.c: Update.
8576         * frame-unwind.c: Update.
8577         * frame.c: Update.
8578         * gdbtypes.c: Update.
8579         * gnu-v3-abi.c: Update.
8580         * guile/guile-internal.h: Update.
8581         * guile/scm-block.c: Update.
8582         * guile/scm-breakpoint.c: Update.
8583         * guile/scm-cmd.c: Update.
8584         * guile/scm-disasm.c: Update.
8585         * guile/scm-frame.c: Update.
8586         * guile/scm-lazy-string.c: Update.
8587         * guile/scm-math.c: Update.
8588         * guile/scm-param.c: Update.
8589         * guile/scm-ports.c: Update.
8590         * guile/scm-pretty-print.c: Update.
8591         * guile/scm-symbol.c: Update.
8592         * guile/scm-symtab.c: Update.
8593         * guile/scm-type.c: Update.
8594         * guile/scm-value.c: Update.
8595         * i386-linux-tdep.c: Update.
8596         * i386-tdep.c: Update.
8597         * inf-loop.c: Update.
8598         * infcall.c: Update.
8599         * infcmd.c: Update.
8600         * infrun.c: Update.
8601         * jit.c: Update.
8602         * language.c: Update.
8603         * linespec.c: Update.
8604         * linux-fork.c: Update.
8605         * linux-nat.c: Update.
8606         * linux-tdep.c: Update.
8607         * linux-thread-db.c: Update.
8608         * main.c: Update.
8609         * mi/mi-cmd-break.c: Update.
8610         * mi/mi-cmd-stack.c: Update.
8611         * mi/mi-interp.c: Update.
8612         * mi/mi-main.c: Update.
8613         * objc-lang.c: Update.
8614         * p-valprint.c: Update.
8615         * parse.c: Update.
8616         * ppc-linux-tdep.c: Update.
8617         * printcmd.c: Update.
8618         * python/py-arch.c: Update.
8619         * python/py-breakpoint.c: Update.
8620         * python/py-cmd.c: Update.
8621         * python/py-finishbreakpoint.c: Update.
8622         * python/py-frame.c: Update.
8623         * python/py-framefilter.c: Update.
8624         * python/py-gdb-readline.c: Update.
8625         * python/py-inferior.c: Update.
8626         * python/py-infthread.c: Update.
8627         * python/py-lazy-string.c: Update.
8628         * python/py-linetable.c: Update.
8629         * python/py-objfile.c: Update.
8630         * python/py-param.c: Update.
8631         * python/py-prettyprint.c: Update.
8632         * python/py-progspace.c: Update.
8633         * python/py-record-btrace.c: Update.
8634         * python/py-record.c: Update.
8635         * python/py-symbol.c: Update.
8636         * python/py-type.c: Update.
8637         * python/py-unwind.c: Update.
8638         * python/py-utils.c: Update.
8639         * python/py-value.c: Update.
8640         * python/python.c: Update.
8641         * record-btrace.c: Update.
8642         * record-full.c: Update.
8643         * remote-fileio.c: Update.
8644         * remote.c: Update.
8645         * riscv-tdep.c: Update.
8646         * rs6000-aix-tdep.c: Update.
8647         * rs6000-tdep.c: Update.
8648         * rust-exp.y: Update.
8649         * rust-lang.c: Update.
8650         * s390-tdep.c: Update.
8651         * selftest-arch.c: Update.
8652         * solib-dsbt.c: Update.
8653         * solib-frv.c: Update.
8654         * solib-spu.c: Update.
8655         * solib-svr4.c: Update.
8656         * solib.c: Update.
8657         * sparc64-linux-tdep.c: Update.
8658         * stack.c: Update.
8659         * symfile-mem.c: Update.
8660         * symmisc.c: Update.
8661         * target.c: Update.
8662         * thread.c: Update.
8663         * top.c: Update.
8664         * tracefile-tfile.c: Update.
8665         * tui/tui.c: Update.
8666         * typeprint.c: Update.
8667         * unittests/cli-utils-selftests.c: Update.
8668         * unittests/parse-connection-spec-selftests.c: Update.
8669         * valops.c: Update.
8670         * valprint.c: Update.
8671         * value.c: Update.
8672         * varobj.c: Update.
8673         * windows-nat.c: Update.
8674         * x86-linux-nat.c: Update.
8675         * xml-support.c: Update.
8676
8677 2019-04-08  Tom Tromey  <tom@tromey.com>
8678
8679         * xml-support.c: Use C++ exception handling.
8680         * x86-linux-nat.c: Use C++ exception handling.
8681         * windows-nat.c: Use C++ exception handling.
8682         * varobj.c: Use C++ exception handling.
8683         * value.c: Use C++ exception handling.
8684         * valprint.c: Use C++ exception handling.
8685         * valops.c: Use C++ exception handling.
8686         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8687         handling.
8688         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8689         * typeprint.c: Use C++ exception handling.
8690         * tui/tui.c: Use C++ exception handling.
8691         * tracefile-tfile.c: Use C++ exception handling.
8692         * top.c: Use C++ exception handling.
8693         * thread.c: Use C++ exception handling.
8694         * target.c: Use C++ exception handling.
8695         * symmisc.c: Use C++ exception handling.
8696         * symfile-mem.c: Use C++ exception handling.
8697         * stack.c: Use C++ exception handling.
8698         * sparc64-linux-tdep.c: Use C++ exception handling.
8699         * solib.c: Use C++ exception handling.
8700         * solib-svr4.c: Use C++ exception handling.
8701         * solib-spu.c: Use C++ exception handling.
8702         * solib-frv.c: Use C++ exception handling.
8703         * solib-dsbt.c: Use C++ exception handling.
8704         * selftest-arch.c: Use C++ exception handling.
8705         * s390-tdep.c: Use C++ exception handling.
8706         * rust-lang.c: Use C++ exception handling.
8707         * rust-exp.y: Use C++ exception handling.
8708         * rs6000-tdep.c: Use C++ exception handling.
8709         * rs6000-aix-tdep.c: Use C++ exception handling.
8710         * riscv-tdep.c: Use C++ exception handling.
8711         * remote.c: Use C++ exception handling.
8712         * remote-fileio.c: Use C++ exception handling.
8713         * record-full.c: Use C++ exception handling.
8714         * record-btrace.c: Use C++ exception handling.
8715         * python/python.c: Use C++ exception handling.
8716         * python/py-value.c: Use C++ exception handling.
8717         * python/py-utils.c: Use C++ exception handling.
8718         * python/py-unwind.c: Use C++ exception handling.
8719         * python/py-type.c: Use C++ exception handling.
8720         * python/py-symbol.c: Use C++ exception handling.
8721         * python/py-record.c: Use C++ exception handling.
8722         * python/py-record-btrace.c: Use C++ exception handling.
8723         * python/py-progspace.c: Use C++ exception handling.
8724         * python/py-prettyprint.c: Use C++ exception handling.
8725         * python/py-param.c: Use C++ exception handling.
8726         * python/py-objfile.c: Use C++ exception handling.
8727         * python/py-linetable.c: Use C++ exception handling.
8728         * python/py-lazy-string.c: Use C++ exception handling.
8729         * python/py-infthread.c: Use C++ exception handling.
8730         * python/py-inferior.c: Use C++ exception handling.
8731         * python/py-gdb-readline.c: Use C++ exception handling.
8732         * python/py-framefilter.c: Use C++ exception handling.
8733         * python/py-frame.c: Use C++ exception handling.
8734         * python/py-finishbreakpoint.c: Use C++ exception handling.
8735         * python/py-cmd.c: Use C++ exception handling.
8736         * python/py-breakpoint.c: Use C++ exception handling.
8737         * python/py-arch.c: Use C++ exception handling.
8738         * printcmd.c: Use C++ exception handling.
8739         * ppc-linux-tdep.c: Use C++ exception handling.
8740         * parse.c: Use C++ exception handling.
8741         * p-valprint.c: Use C++ exception handling.
8742         * objc-lang.c: Use C++ exception handling.
8743         * mi/mi-main.c: Use C++ exception handling.
8744         * mi/mi-interp.c: Use C++ exception handling.
8745         * mi/mi-cmd-stack.c: Use C++ exception handling.
8746         * mi/mi-cmd-break.c: Use C++ exception handling.
8747         * main.c: Use C++ exception handling.
8748         * linux-thread-db.c: Use C++ exception handling.
8749         * linux-tdep.c: Use C++ exception handling.
8750         * linux-nat.c: Use C++ exception handling.
8751         * linux-fork.c: Use C++ exception handling.
8752         * linespec.c: Use C++ exception handling.
8753         * language.c: Use C++ exception handling.
8754         * jit.c: Use C++ exception handling.
8755         * infrun.c: Use C++ exception handling.
8756         * infcmd.c: Use C++ exception handling.
8757         * infcall.c: Use C++ exception handling.
8758         * inf-loop.c: Use C++ exception handling.
8759         * i386-tdep.c: Use C++ exception handling.
8760         * i386-linux-tdep.c: Use C++ exception handling.
8761         * guile/scm-value.c: Use C++ exception handling.
8762         * guile/scm-type.c: Use C++ exception handling.
8763         * guile/scm-symtab.c: Use C++ exception handling.
8764         * guile/scm-symbol.c: Use C++ exception handling.
8765         * guile/scm-pretty-print.c: Use C++ exception handling.
8766         * guile/scm-ports.c: Use C++ exception handling.
8767         * guile/scm-param.c: Use C++ exception handling.
8768         * guile/scm-math.c: Use C++ exception handling.
8769         * guile/scm-lazy-string.c: Use C++ exception handling.
8770         * guile/scm-frame.c: Use C++ exception handling.
8771         * guile/scm-disasm.c: Use C++ exception handling.
8772         * guile/scm-cmd.c: Use C++ exception handling.
8773         * guile/scm-breakpoint.c: Use C++ exception handling.
8774         * guile/scm-block.c: Use C++ exception handling.
8775         * guile/guile-internal.h: Use C++ exception handling.
8776         * gnu-v3-abi.c: Use C++ exception handling.
8777         * gdbtypes.c: Use C++ exception handling.
8778         * frame.c: Use C++ exception handling.
8779         * frame-unwind.c: Use C++ exception handling.
8780         * fbsd-tdep.c: Use C++ exception handling.
8781         * f-valprint.c: Use C++ exception handling.
8782         * exec.c: Use C++ exception handling.
8783         * event-top.c: Use C++ exception handling.
8784         * event-loop.c: Use C++ exception handling.
8785         * eval.c: Use C++ exception handling.
8786         * dwarf2read.c: Use C++ exception handling.
8787         * dwarf2loc.c: Use C++ exception handling.
8788         * dwarf2-frame.c: Use C++ exception handling.
8789         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8790         * dwarf-index-write.c: Use C++ exception handling.
8791         * dwarf-index-cache.c: Use C++ exception handling.
8792         * dtrace-probe.c: Use C++ exception handling.
8793         * disasm-selftests.c: Use C++ exception handling.
8794         * darwin-nat.c: Use C++ exception handling.
8795         * cp-valprint.c: Use C++ exception handling.
8796         * cp-support.c: Use C++ exception handling.
8797         * cp-abi.c: Use C++ exception handling.
8798         * corelow.c: Use C++ exception handling.
8799         * completer.c: Use C++ exception handling.
8800         * compile/compile-object-run.c: Use C++ exception handling.
8801         * compile/compile-object-load.c: Use C++ exception handling.
8802         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8803         * compile/compile-c-symbols.c: Use C++ exception handling.
8804         * common/selftest.c: Use C++ exception handling.
8805         * common/new-op.c: Use C++ exception handling.
8806         * cli/cli-script.c: Use C++ exception handling.
8807         * cli/cli-interp.c: Use C++ exception handling.
8808         * cli/cli-cmds.c: Use C++ exception handling.
8809         * c-varobj.c: Use C++ exception handling.
8810         * btrace.c: Use C++ exception handling.
8811         * breakpoint.c: Use C++ exception handling.
8812         * break-catch-throw.c: Use C++ exception handling.
8813         * arch-utils.c: Use C++ exception handling.
8814         * amd64-tdep.c: Use C++ exception handling.
8815         * ada-valprint.c: Use C++ exception handling.
8816         * ada-typeprint.c: Use C++ exception handling.
8817         * ada-lang.c: Use C++ exception handling.
8818         * aarch64-tdep.c: Use C++ exception handling.
8819
8820 2019-04-08  Tom Tromey  <tom@tromey.com>
8821
8822         * xml-support.c (gdb_xml_parser::parse): Update.
8823         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8824         * value.c (show_convenience): Update.
8825         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8826         (test_parse_flags_qcs): Update.
8827         * thread.c (thr_try_catch_cmd): Update.
8828         * target.c (target_translate_tls_address): Update.
8829         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8830         (info_frame_command_core, frame_apply_command_count): Update.
8831         * rust-exp.y (rust_lex_exception_test): Update.
8832         * riscv-tdep.c (riscv_print_one_register_info): Update.
8833         * remote.c (remote_target::enable_btrace): Update.
8834         * record-btrace.c (record_btrace_enable_warn): Update.
8835         * python/py-utils.c (gdbpy_convert_exception): Update.
8836         * printcmd.c (do_one_display, print_variable_and_value): Update.
8837         * mi/mi-main.c (mi_print_exception): Update.
8838         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8839         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8840         * linux-nat.c (linux_nat_target::attach): Update.
8841         * linux-fork.c (class scoped_switch_fork_info): Update.
8842         * infrun.c (displaced_step_prepare): Update.
8843         * infcall.c (call_function_by_hand_dummy): Update.
8844         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8845         * gnu-v3-abi.c (print_one_vtable): Update.
8846         * frame.c (get_prev_frame_always): Update.
8847         * f-valprint.c (info_common_command_for_block): Update.
8848         * exec.c (try_open_exec_file): Update.
8849         * exceptions.c (print_exception, exception_print)
8850         (exception_fprintf, exception_print_same): Update.
8851         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8852         * dwarf-index-cache.c (index_cache::store)
8853         (index_cache::lookup_gdb_index): Update.
8854         * darwin-nat.c (maybe_cache_shell): Update.
8855         * cp-valprint.c (cp_print_value_fields): Update.
8856         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8857         (gcc_cplus_symbol_address): Update.
8858         * compile/compile-c-symbols.c (gcc_convert_symbol)
8859         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8860         * common/selftest.c: Update.
8861         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8862         a std::string.
8863         (exception_try_scope_entry, exception_try_scope_exit): Don't
8864         declare.
8865         (struct exception_try_scope): Remove.
8866         (TRY): Don't use exception_try_scope.
8867         (struct gdb_exception): Add constructor, operator=.
8868         <what>: New method.
8869         (struct gdb_exception_RETURN_MASK_ALL)
8870         (struct gdb_exception_RETURN_MASK_ERROR)
8871         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8872         (struct gdb_quit_bad_alloc): Update.
8873         * common/common-exceptions.c (exception_none): Change
8874         initializer.
8875         (struct catcher) <state, exception>: Initialize inline.
8876         <prev>: Remove member.
8877         (current_catcher): Remove.
8878         (catchers): New global.
8879         (exceptions_state_mc_init): Simplify.
8880         (catcher_pop): Remove.
8881         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8882         (try_scope_depth, exception_try_scope_entry)
8883         (exception_try_scope_exit): Remove.
8884         (throw_exception_sjlj): Update.
8885         (exception_messages, exception_messages_size): Remove.
8886         (throw_it): Simplify.
8887         (gdb_exception_sliced_copy): Remove.
8888         (throw_exception_cxx): Update.
8889         * cli/cli-script.c (script_from_file): Update.
8890         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8891         Update.
8892         * ada-valprint.c (ada_val_print): Update.
8893         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8894         (create_excep_cond_exprs): Update.
8895
8896 2019-04-08  Tom Tromey  <tom@tromey.com>
8897
8898         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8899         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8900         (TRY, CATCH, END_CATCH): Remove some definitions.
8901         * common/common-exceptions.c: Don't use GDB_XCPT.
8902         (catcher_list_size): Remove.
8903         (throw_exception, throw_it): Simplify.
8904
8905 2019-04-05  Tom Tromey  <tom@tromey.com>
8906
8907         Revert the header-sorting patch.
8908         * ft32-tdep.c: Revert.
8909         * frv-tdep.c: Revert.
8910         * frv-linux-tdep.c: Revert.
8911         * frame.c: Revert.
8912         * frame-unwind.c: Revert.
8913         * frame-base.c: Revert.
8914         * fork-child.c: Revert.
8915         * findvar.c: Revert.
8916         * findcmd.c: Revert.
8917         * filesystem.c: Revert.
8918         * filename-seen-cache.h: Revert.
8919         * filename-seen-cache.c: Revert.
8920         * fbsd-tdep.c: Revert.
8921         * fbsd-nat.h: Revert.
8922         * fbsd-nat.c: Revert.
8923         * f-valprint.c: Revert.
8924         * f-typeprint.c: Revert.
8925         * f-lang.c: Revert.
8926         * extension.h: Revert.
8927         * extension.c: Revert.
8928         * extension-priv.h: Revert.
8929         * expprint.c: Revert.
8930         * exec.h: Revert.
8931         * exec.c: Revert.
8932         * exceptions.c: Revert.
8933         * event-top.c: Revert.
8934         * event-loop.c: Revert.
8935         * eval.c: Revert.
8936         * elfread.c: Revert.
8937         * dwarf2read.h: Revert.
8938         * dwarf2read.c: Revert.
8939         * dwarf2loc.c: Revert.
8940         * dwarf2expr.h: Revert.
8941         * dwarf2expr.c: Revert.
8942         * dwarf2-frame.c: Revert.
8943         * dwarf2-frame-tailcall.c: Revert.
8944         * dwarf-index-write.h: Revert.
8945         * dwarf-index-write.c: Revert.
8946         * dwarf-index-common.c: Revert.
8947         * dwarf-index-cache.h: Revert.
8948         * dwarf-index-cache.c: Revert.
8949         * dummy-frame.c: Revert.
8950         * dtrace-probe.c: Revert.
8951         * disasm.h: Revert.
8952         * disasm.c: Revert.
8953         * disasm-selftests.c: Revert.
8954         * dictionary.c: Revert.
8955         * dicos-tdep.c: Revert.
8956         * demangle.c: Revert.
8957         * dcache.h: Revert.
8958         * dcache.c: Revert.
8959         * darwin-nat.h: Revert.
8960         * darwin-nat.c: Revert.
8961         * darwin-nat-info.c: Revert.
8962         * d-valprint.c: Revert.
8963         * d-namespace.c: Revert.
8964         * d-lang.c: Revert.
8965         * ctf.c: Revert.
8966         * csky-tdep.c: Revert.
8967         * csky-linux-tdep.c: Revert.
8968         * cris-tdep.c: Revert.
8969         * cris-linux-tdep.c: Revert.
8970         * cp-valprint.c: Revert.
8971         * cp-support.c: Revert.
8972         * cp-namespace.c: Revert.
8973         * cp-abi.c: Revert.
8974         * corelow.c: Revert.
8975         * corefile.c: Revert.
8976         * continuations.c: Revert.
8977         * completer.h: Revert.
8978         * completer.c: Revert.
8979         * complaints.c: Revert.
8980         * coffread.c: Revert.
8981         * coff-pe-read.c: Revert.
8982         * cli-out.h: Revert.
8983         * cli-out.c: Revert.
8984         * charset.c: Revert.
8985         * c-varobj.c: Revert.
8986         * c-valprint.c: Revert.
8987         * c-typeprint.c: Revert.
8988         * c-lang.c: Revert.
8989         * buildsym.c: Revert.
8990         * buildsym-legacy.c: Revert.
8991         * build-id.h: Revert.
8992         * build-id.c: Revert.
8993         * btrace.c: Revert.
8994         * bsd-uthread.c: Revert.
8995         * breakpoint.h: Revert.
8996         * breakpoint.c: Revert.
8997         * break-catch-throw.c: Revert.
8998         * break-catch-syscall.c: Revert.
8999         * break-catch-sig.c: Revert.
9000         * blockframe.c: Revert.
9001         * block.c: Revert.
9002         * bfin-tdep.c: Revert.
9003         * bfin-linux-tdep.c: Revert.
9004         * bfd-target.c: Revert.
9005         * bcache.c: Revert.
9006         * ax-general.c: Revert.
9007         * ax-gdb.h: Revert.
9008         * ax-gdb.c: Revert.
9009         * avr-tdep.c: Revert.
9010         * auxv.c: Revert.
9011         * auto-load.c: Revert.
9012         * arm-wince-tdep.c: Revert.
9013         * arm-tdep.c: Revert.
9014         * arm-symbian-tdep.c: Revert.
9015         * arm-pikeos-tdep.c: Revert.
9016         * arm-obsd-tdep.c: Revert.
9017         * arm-nbsd-tdep.c: Revert.
9018         * arm-nbsd-nat.c: Revert.
9019         * arm-linux-tdep.c: Revert.
9020         * arm-linux-nat.c: Revert.
9021         * arm-fbsd-tdep.c: Revert.
9022         * arm-fbsd-nat.c: Revert.
9023         * arm-bsd-tdep.c: Revert.
9024         * arch-utils.c: Revert.
9025         * arc-tdep.c: Revert.
9026         * arc-newlib-tdep.c: Revert.
9027         * annotate.h: Revert.
9028         * annotate.c: Revert.
9029         * amd64-windows-tdep.c: Revert.
9030         * amd64-windows-nat.c: Revert.
9031         * amd64-tdep.c: Revert.
9032         * amd64-sol2-tdep.c: Revert.
9033         * amd64-obsd-tdep.c: Revert.
9034         * amd64-obsd-nat.c: Revert.
9035         * amd64-nbsd-tdep.c: Revert.
9036         * amd64-nbsd-nat.c: Revert.
9037         * amd64-nat.c: Revert.
9038         * amd64-linux-tdep.c: Revert.
9039         * amd64-linux-nat.c: Revert.
9040         * amd64-fbsd-tdep.c: Revert.
9041         * amd64-fbsd-nat.c: Revert.
9042         * amd64-dicos-tdep.c: Revert.
9043         * amd64-darwin-tdep.c: Revert.
9044         * amd64-bsd-nat.c: Revert.
9045         * alpha-tdep.c: Revert.
9046         * alpha-obsd-tdep.c: Revert.
9047         * alpha-nbsd-tdep.c: Revert.
9048         * alpha-mdebug-tdep.c: Revert.
9049         * alpha-linux-tdep.c: Revert.
9050         * alpha-linux-nat.c: Revert.
9051         * alpha-bsd-tdep.c: Revert.
9052         * alpha-bsd-nat.c: Revert.
9053         * aix-thread.c: Revert.
9054         * agent.c: Revert.
9055         * addrmap.c: Revert.
9056         * ada-varobj.c: Revert.
9057         * ada-valprint.c: Revert.
9058         * ada-typeprint.c: Revert.
9059         * ada-tasks.c: Revert.
9060         * ada-lang.c: Revert.
9061         * aarch64-tdep.c: Revert.
9062         * aarch64-ravenscar-thread.c: Revert.
9063         * aarch64-newlib-tdep.c: Revert.
9064         * aarch64-linux-tdep.c: Revert.
9065         * aarch64-linux-nat.c: Revert.
9066         * aarch64-fbsd-tdep.c: Revert.
9067         * aarch64-fbsd-nat.c: Revert.
9068         * aarch32-linux-nat.c: Revert.
9069
9070 2019-04-05  Tom Tromey  <tom@tromey.com>
9071
9072         * ft32-tdep.c: Sort headers.
9073         * frv-tdep.c: Sort headers.
9074         * frv-linux-tdep.c: Sort headers.
9075         * frame.c: Sort headers.
9076         * frame-unwind.c: Sort headers.
9077         * frame-base.c: Sort headers.
9078         * fork-child.c: Sort headers.
9079         * findvar.c: Sort headers.
9080         * findcmd.c: Sort headers.
9081         * filesystem.c: Sort headers.
9082         * filename-seen-cache.h: Sort headers.
9083         * filename-seen-cache.c: Sort headers.
9084         * fbsd-tdep.c: Sort headers.
9085         * fbsd-nat.h: Sort headers.
9086         * fbsd-nat.c: Sort headers.
9087         * f-valprint.c: Sort headers.
9088         * f-typeprint.c: Sort headers.
9089         * f-lang.c: Sort headers.
9090         * extension.h: Sort headers.
9091         * extension.c: Sort headers.
9092         * extension-priv.h: Sort headers.
9093         * expprint.c: Sort headers.
9094         * exec.h: Sort headers.
9095         * exec.c: Sort headers.
9096         * exceptions.c: Sort headers.
9097         * event-top.c: Sort headers.
9098         * event-loop.c: Sort headers.
9099         * eval.c: Sort headers.
9100         * elfread.c: Sort headers.
9101         * dwarf2read.h: Sort headers.
9102         * dwarf2read.c: Sort headers.
9103         * dwarf2loc.c: Sort headers.
9104         * dwarf2expr.h: Sort headers.
9105         * dwarf2expr.c: Sort headers.
9106         * dwarf2-frame.c: Sort headers.
9107         * dwarf2-frame-tailcall.c: Sort headers.
9108         * dwarf-index-write.h: Sort headers.
9109         * dwarf-index-write.c: Sort headers.
9110         * dwarf-index-common.c: Sort headers.
9111         * dwarf-index-cache.h: Sort headers.
9112         * dwarf-index-cache.c: Sort headers.
9113         * dummy-frame.c: Sort headers.
9114         * dtrace-probe.c: Sort headers.
9115         * disasm.h: Sort headers.
9116         * disasm.c: Sort headers.
9117         * disasm-selftests.c: Sort headers.
9118         * dictionary.c: Sort headers.
9119         * dicos-tdep.c: Sort headers.
9120         * demangle.c: Sort headers.
9121         * dcache.h: Sort headers.
9122         * dcache.c: Sort headers.
9123         * darwin-nat.h: Sort headers.
9124         * darwin-nat.c: Sort headers.
9125         * darwin-nat-info.c: Sort headers.
9126         * d-valprint.c: Sort headers.
9127         * d-namespace.c: Sort headers.
9128         * d-lang.c: Sort headers.
9129         * ctf.c: Sort headers.
9130         * csky-tdep.c: Sort headers.
9131         * csky-linux-tdep.c: Sort headers.
9132         * cris-tdep.c: Sort headers.
9133         * cris-linux-tdep.c: Sort headers.
9134         * cp-valprint.c: Sort headers.
9135         * cp-support.c: Sort headers.
9136         * cp-namespace.c: Sort headers.
9137         * cp-abi.c: Sort headers.
9138         * corelow.c: Sort headers.
9139         * corefile.c: Sort headers.
9140         * continuations.c: Sort headers.
9141         * completer.h: Sort headers.
9142         * completer.c: Sort headers.
9143         * complaints.c: Sort headers.
9144         * coffread.c: Sort headers.
9145         * coff-pe-read.c: Sort headers.
9146         * cli-out.h: Sort headers.
9147         * cli-out.c: Sort headers.
9148         * charset.c: Sort headers.
9149         * c-varobj.c: Sort headers.
9150         * c-valprint.c: Sort headers.
9151         * c-typeprint.c: Sort headers.
9152         * c-lang.c: Sort headers.
9153         * buildsym.c: Sort headers.
9154         * buildsym-legacy.c: Sort headers.
9155         * build-id.h: Sort headers.
9156         * build-id.c: Sort headers.
9157         * btrace.c: Sort headers.
9158         * bsd-uthread.c: Sort headers.
9159         * breakpoint.h: Sort headers.
9160         * breakpoint.c: Sort headers.
9161         * break-catch-throw.c: Sort headers.
9162         * break-catch-syscall.c: Sort headers.
9163         * break-catch-sig.c: Sort headers.
9164         * blockframe.c: Sort headers.
9165         * block.c: Sort headers.
9166         * bfin-tdep.c: Sort headers.
9167         * bfin-linux-tdep.c: Sort headers.
9168         * bfd-target.c: Sort headers.
9169         * bcache.c: Sort headers.
9170         * ax-general.c: Sort headers.
9171         * ax-gdb.h: Sort headers.
9172         * ax-gdb.c: Sort headers.
9173         * avr-tdep.c: Sort headers.
9174         * auxv.c: Sort headers.
9175         * auto-load.c: Sort headers.
9176         * arm-wince-tdep.c: Sort headers.
9177         * arm-tdep.c: Sort headers.
9178         * arm-symbian-tdep.c: Sort headers.
9179         * arm-pikeos-tdep.c: Sort headers.
9180         * arm-obsd-tdep.c: Sort headers.
9181         * arm-nbsd-tdep.c: Sort headers.
9182         * arm-nbsd-nat.c: Sort headers.
9183         * arm-linux-tdep.c: Sort headers.
9184         * arm-linux-nat.c: Sort headers.
9185         * arm-fbsd-tdep.c: Sort headers.
9186         * arm-fbsd-nat.c: Sort headers.
9187         * arm-bsd-tdep.c: Sort headers.
9188         * arch-utils.c: Sort headers.
9189         * arc-tdep.c: Sort headers.
9190         * arc-newlib-tdep.c: Sort headers.
9191         * annotate.h: Sort headers.
9192         * annotate.c: Sort headers.
9193         * amd64-windows-tdep.c: Sort headers.
9194         * amd64-windows-nat.c: Sort headers.
9195         * amd64-tdep.c: Sort headers.
9196         * amd64-sol2-tdep.c: Sort headers.
9197         * amd64-obsd-tdep.c: Sort headers.
9198         * amd64-obsd-nat.c: Sort headers.
9199         * amd64-nbsd-tdep.c: Sort headers.
9200         * amd64-nbsd-nat.c: Sort headers.
9201         * amd64-nat.c: Sort headers.
9202         * amd64-linux-tdep.c: Sort headers.
9203         * amd64-linux-nat.c: Sort headers.
9204         * amd64-fbsd-tdep.c: Sort headers.
9205         * amd64-fbsd-nat.c: Sort headers.
9206         * amd64-dicos-tdep.c: Sort headers.
9207         * amd64-darwin-tdep.c: Sort headers.
9208         * amd64-bsd-nat.c: Sort headers.
9209         * alpha-tdep.c: Sort headers.
9210         * alpha-obsd-tdep.c: Sort headers.
9211         * alpha-nbsd-tdep.c: Sort headers.
9212         * alpha-mdebug-tdep.c: Sort headers.
9213         * alpha-linux-tdep.c: Sort headers.
9214         * alpha-linux-nat.c: Sort headers.
9215         * alpha-bsd-tdep.c: Sort headers.
9216         * alpha-bsd-nat.c: Sort headers.
9217         * aix-thread.c: Sort headers.
9218         * agent.c: Sort headers.
9219         * addrmap.c: Sort headers.
9220         * ada-varobj.c: Sort headers.
9221         * ada-valprint.c: Sort headers.
9222         * ada-typeprint.c: Sort headers.
9223         * ada-tasks.c: Sort headers.
9224         * ada-lang.c: Sort headers.
9225         * aarch64-tdep.c: Sort headers.
9226         * aarch64-ravenscar-thread.c: Sort headers.
9227         * aarch64-newlib-tdep.c: Sort headers.
9228         * aarch64-linux-tdep.c: Sort headers.
9229         * aarch64-linux-nat.c: Sort headers.
9230         * aarch64-fbsd-tdep.c: Sort headers.
9231         * aarch64-fbsd-nat.c: Sort headers.
9232         * aarch32-linux-nat.c: Sort headers.
9233
9234 2019-04-04  Tom Tromey  <tom@tromey.com>
9235
9236         * varobj.c (varobj_create): Update.
9237         * rust-exp.y (struct rust_parser) <update_innermost_block,
9238         lookup_symbol>: New methods.
9239         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9240         Rename.
9241         (rust_parser::rust_lookup_type)
9242         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9243         * printcmd.c (display_command, do_one_display): Update.
9244         * parser-defs.h (struct parser_state) <parser_state>: Add
9245         "tracker" parameter.
9246         (block_tracker): New member.
9247         (class innermost_block_tracker) <innermost_block_tracker>: Add
9248         "types" parameter.
9249         <reset>: Remove method.
9250         (innermost_block): Don't declare.
9251         (null_post_parser): Update.
9252         * parse.c (innermost_block): Remove global.
9253         (write_dollar_variable): Update.
9254         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9255         Remove "tracker_types" parameter.
9256         (parse_expression): Add "tracker" parameter.
9257         (parse_expression_for_completion): Update.
9258         (null_post_parser): Add "tracker" parameter.
9259         * p-exp.y: Update rules.
9260         * m2-exp.y: Update rules.
9261         * language.h (struct language_defn) <la_post_parser>: Add
9262         "tracker" parameter.
9263         * go-exp.y: Update rules.
9264         * f-exp.y: Update rules.
9265         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9266         parameter.
9267         * d-exp.y: Update rules.
9268         * c-exp.y: Update rules.
9269         * breakpoint.c (set_breakpoint_condition): Create an
9270         innermost_block_tracker.
9271         (watch_command_1): Likewise.
9272         * ada-lang.c (resolve): Add "tracker" parameter.
9273         (resolve_subexp): Likewise.
9274         * ada-exp.y (write_var_from_sym): Update.
9275
9276 2019-04-04  Tom Tromey  <tom@tromey.com>
9277
9278         * type-stack.h: New file.
9279         * type-stack.c: New file.
9280         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9281         type-stack.h.
9282         (insert_into_type_stack, insert_type, push_type, push_type_int)
9283         (insert_type_address_space, pop_type, pop_type_int)
9284         (pop_typelist, pop_type_stack, append_type_stack)
9285         (push_type_stack, get_type_stack, push_typelist)
9286         (follow_type_instance_flags, follow_types): Don't declare.
9287         * parse.c (type_stack): Remove global.
9288         (parse_exp_in_context): Update.
9289         (insert_into_type_stack, insert_type, push_type, push_type_int)
9290         (insert_type_address_space, pop_type, pop_type_int)
9291         (pop_typelist, pop_type_stack, append_type_stack)
9292         (push_type_stack, get_type_stack, push_typelist)
9293         (follow_type_instance_flags, follow_types): Remove (moved to
9294         type-stack.c).
9295         * f-exp.y (type_stack): New global.
9296         Update rules.
9297         (push_kind_type, f_parse): Update.
9298         * d-exp.y (type_stack): New global.
9299         Update rules.
9300         (d_parse): Update.
9301         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9302         Update rules.
9303         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9304         (HFILES_NO_SRCDIR): Add type-stack.h.
9305
9306 2019-04-04  Tom Tromey  <tom@tromey.com>
9307
9308         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9309         (rust_parser::convert_ast_to_expression, rust_parse)
9310         (rust_lex_test_completion, rust_lex_tests): Update.
9311         * parser-defs.h (struct expr_completion_state): New.
9312         (struct parser_state) <parser_state>: Add completion parameter.
9313         <mark_struct_expression, mark_completion_tag>: New methods.
9314         <parse_completion, m_completion_state>: New members.
9315         (prefixify_expression, null_post_parser): Update.
9316         (mark_struct_expression, mark_completion_tag): Don't declare.
9317         * parse.c (parse_completion, expout_last_struct)
9318         (expout_tag_completion_type, expout_completion_name): Remove
9319         globals.
9320         (parser_state::mark_struct_expression)
9321         (parser_state::mark_completion_tag): Now methods.
9322         (prefixify_expression): Add last_struct parameter.
9323         (prefixify_subexp): Likewise.
9324         (parse_exp_1): Update.
9325         (parse_exp_in_context): Add cstate parameter.  Update.
9326         (parse_expression_for_completion): Create an
9327         expr_completion_state.
9328         (null_post_parser): Add "completion" parameter.
9329         * p-exp.y: Update rules.
9330         (yylex): Update.
9331         * language.h (struct language_defn) <la_post_parser>: Add
9332         "completing" parameter.
9333         * go-exp.y: Update rules.
9334         (lex_one_token): Update.
9335         * expression.h (parse_completion): Don't declare.
9336         * d-exp.y: Update rules.
9337         (lex_one_token): Update rules.
9338         * c-exp.y: Update rules.
9339         (lex_one_token): Update.
9340         * ada-lang.c (resolve): Add "parse_completion" parameter.
9341         (resolve_subexp): Likewise.
9342         (ada_resolve_function): Likewise.
9343
9344 2019-04-04  Tom Tromey  <tom@tromey.com>
9345
9346         * parser-defs.h (struct parser_state) <start_arglist,
9347         end_arglist>: New methods.
9348         <arglist_len, m_funcall_chain>: New members.
9349         (arglist_len, start_arglist, end_arglist): Don't declare.
9350         * parse.c (arglist_len, funcall_chain): Remove global.
9351         (start_arglist, end_arglist): Remove functions.
9352         (parse_exp_in_context): Update.
9353         * p-exp.y: Update rules.
9354         * m2-exp.y: Update rules.
9355         * go-exp.y: Update rules.
9356         * f-exp.y: Update rules.
9357         * d-exp.y: Update rules.
9358         * c-exp.y: Update rules.
9359
9360 2019-04-04  Tom Tromey  <tom@tromey.com>
9361
9362         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9363         lex_operator, push_back>: New methods.
9364         Update all rules.
9365         (rust_parser::lex_hex, lex_escape): Rename and update.
9366         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9367         (rust_parser::lex_operator): Rename and update.
9368         (rust_parser::lex_number, rustyylex, rustyyerror)
9369         (rust_lex_test_init, rust_lex_test_sequence)
9370         (rust_lex_test_push_back, rust_lex_tests): Update.
9371         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9372         parameter.
9373         <lexptr, prev_lexptr>: New members.
9374         (lexptr, prev_lexptr): Don't declare.
9375         * parse.c (lexptr, prev_lexptr): Remove globals.
9376         (parse_exp_in_context): Update.
9377         * p-exp.y (yylex, yyerror): Update.
9378         * m2-exp.y (parse_number, yylex, yyerror): Update.
9379         * go-exp.y (lex_one_token, yyerror): Update.
9380         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9381         * d-exp.y (lex_one_token, yyerror): Update.
9382         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9383         (lex_one_token, yyerror): Update.
9384         * ada-lex.l (YY_INPUT): Update.
9385         (rewind_to_char): Update.
9386         * ada-exp.y (yyerror): Update.
9387
9388 2019-04-04  Tom Tromey  <tom@tromey.com>
9389
9390         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9391         * parser-defs.h (struct parser_state) <parser_state>: Add new
9392         parameter.
9393         <comma_terminates>: New member.
9394         (comma_terminates): Don't declare global.
9395         * parse.c (comma_terminates): Remove global.
9396         (parse_exp_in_context): Update.
9397         * p-exp.y (yylex): Update.
9398         * m2-exp.y (yylex): Update.
9399         * go-exp.y (lex_one_token): Update.
9400         * f-exp.y (yylex): Update.
9401         * d-exp.y (lex_one_token): Update.
9402         * c-exp.y (lex_one_token): Update.
9403         * ada-lex.l: Update.
9404
9405 2019-04-04  Tom Tromey  <tom@tromey.com>
9406
9407         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9408         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9409         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9410         * parser-defs.h (paren_depth): Don't declare.
9411         * parse.c (paren_depth): Remove global.
9412         (parse_exp_in_context): Update.
9413         * p-exp.y (paren_depth): New global.
9414         (pascal_parse): Initialize it.
9415         * m2-exp.y (paren_depth): New global.
9416         (m2_parse): Initialize it.
9417         * go-exp.y (paren_depth): New global.
9418         (go_parse): Initialize it.
9419         * f-exp.y (paren_depth): New global.
9420         (f_parse): Initialize it.
9421         * d-exp.y (paren_depth): New global.
9422         (d_parse): Initialize it.
9423         * c-exp.y (paren_depth): New global.
9424         (c_parse): Initialize it.
9425         * ada-lex.l (paren_depth): New global.
9426         (lexer_init): Initialize it.
9427
9428 2019-04-04  Tom Tromey  <tom@tromey.com>
9429
9430         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9431         (rust_parser::convert_ast_to_type)
9432         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9433         * parser-defs.h (struct parser_state) <parser_state>: Add
9434         parameters.  Initialize new members.
9435         <expression_context_block, expression_context_pc>: New members.
9436         * parse.c (expression_context_block, expression_context_pc):
9437         Remove globals.
9438         (parse_exp_in_context): Update.
9439         * p-exp.y: Update all rules.
9440         (yylex): Update.
9441         * m2-exp.y: Update all rules.
9442         (yylex): Update.
9443         * go-exp.y (yylex): Update.
9444         * f-exp.y (yylex): Update.
9445         * d-exp.y: Update all rules.
9446         (yylex): Update.
9447         * c-exp.y: Update all rules.
9448         (lex_one_token, classify_name, yylex, c_parse): Update.
9449         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9450
9451 2019-04-04  Tom Tromey  <tom@tromey.com>
9452
9453         * gdbarch.h, gdbarch.c: Rebuild.
9454         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9455         * stap-probe.h:
9456         (struct stap_parse_info): Replace "parser_state" with
9457         "expr_builder".
9458         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9459         (parser_state): New class.
9460         * parse.c (expr_builder): Rename.
9461         (expr_builder::release): Rename.
9462         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9463         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9464         (write_exp_elt_longcst, write_exp_elt_floatcst)
9465         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9466         (write_exp_string_vector, write_exp_bitstring)
9467         (write_exp_msymbol, mark_struct_expression)
9468         (write_dollar_variable)
9469         (insert_type_address_space, increase_expout_size): Replace
9470         "parser_state" with "expr_builder".
9471         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9472         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9473         "parser_state" with "expr_builder".
9474
9475 2019-04-04  Tom Tromey  <tom@tromey.com>
9476
9477         * rust-exp.y: Replace "parse_language" with method call.
9478         * p-exp.y:
9479         (yylex): Replace "parse_language" with method call.
9480         * m2-exp.y:
9481         (yylex): Replace "parse_language" with method call.
9482         * go-exp.y (classify_name): Replace "parse_language" with method
9483         call.
9484         * f-exp.y (yylex): Replace "parse_language" with method call.
9485         * d-exp.y (lex_one_token): Replace "parse_language" with method
9486         call.
9487         * c-exp.y:
9488         (lex_one_token, classify_name, yylex): Replace "parse_language"
9489         with method call.
9490         * ada-exp.y (find_primitive_type, type_char)
9491         (type_system_address): Replace "parse_language" with method call.
9492
9493 2019-04-04  Tom Tromey  <tom@tromey.com>
9494
9495         * rust-exp.y: Replace "parse_gdbarch" with method call.
9496         * parse.c (write_dollar_variable, insert_type_address_space):
9497         Replace "parse_gdbarch" with method call.
9498         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9499         call.
9500         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9501         call.
9502         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9503         "parse_gdbarch" with method call.
9504         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9505         with method call.
9506         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9507         "parse_gdbarch" with method call.
9508         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9509         "parse_gdbarch" with method call.
9510         * c-exp.y (parse_type, parse_number, classify_name): Replace
9511         "parse_gdbarch" with method call.
9512         * ada-lex.l: Replace "parse_gdbarch" with method call.
9513         * ada-exp.y (parse_type, find_primitive_type, type_char)
9514         (type_system_address): Replace "parse_gdbarch" with method call.
9515
9516 2019-04-04  Tom Tromey  <tom@tromey.com>
9517
9518         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9519         * stap-probe.c (stap_parse_argument): Update.
9520         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9521         initial_size parameter.
9522         * rust-exp.y (rust_lex_tests): Update.
9523         * parse.c (parser_state): Update.
9524         (parse_exp_in_context): Update.
9525         * parser-defs.h (struct parser_state) <parser_state>: Remove
9526         "initial_size" parameter.
9527
9528 2019-04-04  Tom Tromey  <tom@tromey.com>
9529
9530         * parser-defs.h (increase_expout_size): Don't declare.
9531         * parse.c (increase_expout_size): Now static.
9532
9533 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9534
9535         * gnu-nat.c (gnu_nat_target::wait): Fix
9536         target_waitstatus_to_string call.
9537
9538 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * eval.c (evaluate_subexp_standard): Handle internal functions
9541         during Fortran function call handling.
9542
9543 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9544
9545         * NEWS: Mention new internal functions.
9546         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9547         (read_base_type): Use dwarf2_init_complex_target_type.
9548         * value.c (creal_internal_fn): New function.
9549         (cimag_internal_fn): New function.
9550         (_initialize_values): Register new internal functions.
9551
9552 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9553
9554         * infrun.c (stop_all_threads): If debug_infrun, always
9555         trace the wait status after wait_one, using
9556         target_waitstatus_to_string and target_pid_to_str.
9557         (handle_inferior_event): Replace various trace of
9558         wait status kind by a single trace.
9559         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9560         wait status kind image by target_waitstatus_to_string.
9561         * target/waitstatus.c (target_waitstatus_to_string): Fix
9562         obsolete comment.
9563
9564 2019-04-01  Tom Tromey  <tromey@adacore.com>
9565
9566         PR symtab/23331:
9567         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9568
9569 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9570             Pedro Alves  <palves@redhat.com>
9571
9572         * top.c (quit_force): Call 'finalize_values'.
9573         * value.c (finalize_values): New function.
9574         * value.h (finalize_values): Declare.
9575
9576 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9577
9578         * NEWS: Announce $_gdb_major and $_gdb_minor.
9579
9580         * top.c (init_gdb_version_vars): New function.
9581         (gdb_init): Call init_gdb_version_vars.
9582
9583 2019-03-29  Tom Tromey  <tromey@adacore.com>
9584
9585         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9586         help text.  Remove dead code.
9587
9588 2019-03-29  Keith Seitz  <keiths@redhat.com>
9589
9590         From Siddhesh Poyarekar:
9591         * f-lang.h (f77_get_upperbound): Return LONGEST.
9592         (f77_get_lowerbound): Likewise.
9593         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9594         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9595         print them.
9596         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9597         plongest to format print it.
9598         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9599         (f77_get_upperbound): Likewise.
9600         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9601         LOWER_BOUND to LONGEST.
9602         (f77_create_arrayprint_offset_tbl): Likewise.
9603
9604 2019-03-29  Keith Seitz  <keiths@redhat.com>
9605
9606         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9607         %s/pulongest for TYPE_LENGTH instead of %d in format
9608         strings.
9609         * ada-typerint.c (ada_print_type): Likewise.
9610         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9611         * compile/compile-c-support.c (generate_register_struct): Likewise.
9612         * gdbtypes.c (recursive_dump_type): Likewise.
9613         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9614         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9615         instead of %d in format strings.
9616         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9617         to std::min to ULONGEST.
9618         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9619         instead of %d in format strings.
9620         * tracepoint.c (info_scope_command): Likewise.
9621         * typeprint.c (print_offset_data::update)
9622         (print_offset_data::finish): Likewise.
9623         * xtensa-tdep.c (xtensa_store_return_value)
9624         (xtensa_push_dummy_call): Likewise.
9625
9626 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9627
9628         * windows-nat.c (display_selector): Fixed format specifications
9629         for 64-bit Cygwin.
9630
9631 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9632
9633         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9634
9635 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9636
9637         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9638         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9639         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9640         (nios2_linux_init_abi): Install it.
9641
9642 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9643
9644         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9645
9646 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9647
9648         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9649
9650 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9651             Tom Tromey  <tromey@adacore.com>
9652
9653         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9654
9655 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9656
9657         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9658         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9659         method to compute the bounds of range types. Also print "[evaluated]"
9660         if the bounds' values come from a dynamic evaluation.
9661
9662 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9665         whitespace when pretty printing is on.
9666
9667 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9668
9669         * ppc-linux-nat.c: Add include.
9670
9671 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9672
9673         * NEWS: Mention AArch64 Pointer Authentication.
9674
9675 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9676
9677         * arm-linux-nat.c: Add include.
9678
9679 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9680
9681         * source-cache.c (source_cache::get_source_lines): Re-read
9682         fullname after calling open_source_file.
9683
9684 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9685
9686         * NEWS: Mention TLS support for FreeBSD.
9687
9688 2019-03-25  Tom Tromey  <tromey@adacore.com>
9689
9690         * minsyms.c (BUNCH_SIZE): Update comment.
9691         (~minimal_symbol_reader): Remove old comment.
9692         (compact_minimal_symbols): Update comment.
9693         (minimal_symbol_reader::install): Remove old comment.  Update
9694         other comments.
9695
9696 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9697
9698         * s390-linux-nat.c: Add include.
9699
9700 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9701
9702         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9703         Call linux_get_hwcap.
9704         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9705         Likewise.
9706         (aarch64_linux_get_hwcap): Remove function.
9707         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9708         declaration.
9709         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9710         linux_get_hwcap.
9711         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9712         * linux-tdep.c (linux_get_hwcap): Add function.
9713         (linux_get_hwcap2): Likewise.
9714         * linux-tdep.h (linux_get_hwcap): Add declaration.
9715         (linux_get_hwcap2): Likewise.
9716         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9717         (ppc_linux_get_hwcap2): Likewise.
9718         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9719         linux_get_hwcap.
9720         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9721         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9722         (ppc_linux_nat_target::read_description): Likewise.
9723         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9724         * s390-linux-nat.c: Likewise.
9725         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9726
9727 2019-03-24  Tom Tromey  <tom@tromey.com>
9728
9729         * ada-lang.c (standard_lookup): Simplify initialization.
9730         (ada_lookup_symbol_nonlocal): Simplify return.
9731         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9732         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9733         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9734         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9735         initialization.
9736         * solib.c (solib_global_lookup): Simplify.
9737         * symtab.c (null_block_symbol): Remove.
9738         (symbol_cache_lookup): Simplify returns.
9739         (lookup_language_this): Simplify returns.
9740         (lookup_symbol_aux): Simplify return.
9741         (lookup_local_symbol): Simplify returns.
9742         (lookup_global_symbol_from_objfile): Simplify return.
9743         (lookup_symbol_in_objfile_symtabs)
9744         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9745         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9746         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9747         * cp-namespace.c (cp_lookup_bare_symbol)
9748         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9749         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9750         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9751         (cp_lookup_symbol_via_imports): Simplify initialization.
9752         (find_symbol_in_baseclass): Likewise.
9753         * symtab.h (null_block_symbol): Remove.
9754         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9755         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9756         (d_lookup_symbol_module): Likewise.
9757         (find_symbol_in_baseclass): Simplify initialization.
9758
9759 2019-03-24  Tom Tromey  <tom@tromey.com>
9760
9761         * expression.h: Don't include symtab.h.
9762         (struct block): Forward declare.
9763
9764 2019-03-24  Tom Tromey  <tom@tromey.com>
9765
9766         * c-exp.y (typebase): Remove casts.
9767         * gdbtypes.c (lookup_unsigned_typename, )
9768         (lookup_signed_typename): Remove cast.
9769         * eval.c (parse_to_comma_and_eval): Remove cast.
9770         * parse.c (write_dollar_variable): Remove cast.
9771         * block.h (struct block) <superblock>: Now const.
9772         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9773         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9774         (map_block): Make "block" const.
9775         * symfile.h (struct quick_symbol_functions)
9776         <map_matching_symbols>: Constify block argument to "callback".
9777         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9778         const.
9779         (find_pc_sect_compunit_symtab): Make "b" const.
9780         (find_symbol_at_address): Likewise.
9781         (search_symbols): Likewise.
9782         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9783         (dw2_debug_names_lookup_symbol): Likewise.
9784         (dw2_map_matching_symbols): Update.
9785         * p-valprint.c (pascal_val_print): Remove "block".
9786         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9787         (aux_add_nonlocal_symbols): Make "block" const.
9788         (resolve_subexp): Remove cast.
9789         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9790         const.
9791         (iterate_over_file_blocks): Likewise.
9792         * f-exp.y (%union) <bval>: Remove.
9793         * coffread.c (patch_opaque_types): Make "b" const.
9794         * spu-tdep.c (spu_catch_start): Make "block" const.
9795         * c-valprint.c (print_unpacked_pointer): Remove "block".
9796         * symmisc.c (dump_symtab_1): Make "b" const.
9797         (block_depth): Make "block" const.
9798         * d-exp.y (%union) <bval>: Remove.
9799         * cp-support.h (cp_lookup_rtti_type): Update.
9800         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9801         * psymtab.c (psym_lookup_symbol): Make "block" const.
9802         (maintenance_check_psymtabs): Make "b" const.
9803         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9804         (enumerate_locals, enumerate_args): Update.
9805         * python/py-symtab.c (stpy_global_block): Make "block" const.
9806         (stpy_static_block): Likewise.
9807         * inline-frame.c (block_starting_point_at): Make "new_block"
9808         const.
9809         * block.c (find_block_in_blockvector): Make return type const.
9810         (blockvector_for_pc_sect): Make "b" const.
9811         (find_block_in_blockvector): Make "b" const.
9812
9813 2019-03-23  Tom Tromey  <tom@tromey.com>
9814
9815         * varobj.c (varobj_create): Update.
9816         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9817         * printcmd.c (display_command, do_one_display): Don't reset
9818         innermost_block.
9819         * parser-defs.h (enum innermost_block_tracker_type): Move to
9820         expression.h.
9821         (innermost_block): Update comment.
9822         * parse.c (parse_exp_1): Add tracker_types parameter.
9823         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9824         tracker_types parameter.  Reset innermost_block.
9825         (parse_exp_in_context): Remove.
9826         (parse_expression_for_completion): Update.
9827         * objfiles.c (~objfile): Don't reset expression_context_block or
9828         innermost_block.
9829         * expression.h (enum innermost_block_tracker_type): Move from
9830         parser-defs.h.
9831         (parse_exp_1): Add tracker_types parameter.
9832         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9833         reset innermost_block.
9834
9835 2019-03-23  Tom Tromey  <tom@tromey.com>
9836
9837         * objfiles.h: Include bcache.h.
9838
9839 2019-03-23  Tom Tromey  <tom@tromey.com>
9840
9841         * linespec.c (get_current_search_block): Use
9842         scoped_restore_current_language.
9843         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9844
9845 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9846             Jiong Wang  <jiong.wang@arm.com>
9847
9848         * aarch64-linux-tdep.c
9849         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9850         section.
9851         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9852
9853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9854             Jiong Wang  <jiong.wang@arm.com>
9855
9856         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9857         instructions.
9858         (aarch64_analyze_prologue_test): Add PACIASP test.
9859         (aarch64_prologue_prev_register): Unmask PC value.
9860
9861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9862             Jiong Wang  <jiong.wang@arm.com>
9863
9864         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9865         (aarch64_dwarf2_prev_register): Unmask PC value.
9866         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9867         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9868         DW_CFA_AARCH64_negate_ra_state.
9869         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9870
9871 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9872             Jiong Wang  <jiong.wang@arm.com>
9873
9874         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9875         registers.
9876         (aarch64_pseudo_register_name): Likewise.
9877         (aarch64_pseudo_register_type): Likewise.
9878         (aarch64_pseudo_register_reggroup_p): Likewise.
9879         (aarch64_gdbarch_init): Add pauth registers.
9880         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9881         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9882         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9883         (struct gdbarch_tdep): Add regnum for ra_state.
9884
9885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9886             Jiong Wang  <jiong.wang@arm.com>
9887
9888         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9889
9890 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9891             Jiong Wang  <jiong.wang@arm.com>
9892
9893         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9894         function.
9895         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9896         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9897         (aarch64_gdbarch_init): Add puth registers.
9898         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9899         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9900         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9901
9902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9903             Jiong Wang  <jiong.wang@arm.com>
9904
9905         * aarch64-linux-nat.c
9906         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9907         * aarch64-linux-tdep.c
9908         (aarch64_linux_core_read_description): Likewise.
9909         (aarch64_linux_get_hwcap): New function.
9910         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9911         (aarch64_linux_get_hwcap): New declaration.
9912
9913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9914             Jiong Wang  <jiong.wang@arm.com>
9915
9916         * aarch64-linux-nat.c
9917         (aarch64_linux_nat_target::read_description): Add pauth param.
9918         * aarch64-linux-tdep.c
9919         (aarch64_linux_core_read_description): Likewise.
9920         * aarch64-tdep.c (struct target_desc): Add in pauth.
9921         (aarch64_read_description): Add pauth param.
9922         (aarch64_gdbarch_init): Likewise.
9923         * aarch64-tdep.h (aarch64_read_description): Likewise.
9924         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9925         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9926         * features/Makefile: Add new files.
9927         * features/aarch64-pauth.c: New file.
9928         * features/aarch64-pauth.xml: New file.
9929
9930 2019-03-20  Tom Tromey  <tromey@adacore.com>
9931
9932         * infrun.c (handle_inferior_event): Rename from
9933         handle_inferior_event_1.  Create a scoped_value_mark.
9934         (handle_inferior_event): Remove.
9935
9936 2019-03-19  Tom Tromey  <tromey@adacore.com>
9937
9938         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9939         * infrun.h (print_stop_event): Add "displays" parameter.
9940         * infrun.c (print_stop_event): Add "displays" parameter.
9941
9942 2019-03-19  Pedro Alves  <palves@redhat.com>
9943
9944         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9945         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9946         to -1.  Fix TABs vs spaces.
9947         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9948         * tui/tui-out.h (tui_ui_out) Add intro comments.
9949         <m_line, m_start_of_line>: In-class initialize, and add describing
9950         comment.
9951
9952 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9953
9954         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9955         variable names.
9956         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9957
9958 2019-03-18  Pedro Alves  <palves@redhat.com>
9959             Eli Zaretskii <eliz@gnu.org>
9960
9961         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9962         m_line and m_start_of_line.
9963
9964 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9965
9966         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9967         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9968         it returns a newline.  This fixes a regression in TU mode, whereby
9969         the next line is output on the same screen line as the user input.
9970
9971 2019-03-18  Tom Tromey  <tromey@adacore.com>
9972
9973         * minsyms.c (minimal_symbol_reader::install): Remove call to
9974         obstack_blank.
9975
9976 2019-03-18  Pedro Alves  <palves@redhat.com>
9977
9978         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9979         New globals.
9980         (apply_style): New, factored out from ...
9981         (apply_ansi_escape): ... this.  Handle reverse video mode.
9982         (tui_set_reverse_mode): New function.
9983         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9984         * tui/tui-winsource.c (tui_show_source_line): Use
9985         tui_set_reverse_mode instead of setting A_STANDOUT.
9986         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9987         New setter methods.
9988
9989 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9990
9991         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9992         Handle tabs.
9993
9994 2019-03-18  Tom Tromey  <tromey@adacore.com>
9995
9996         * ada-lang.c (empty_array): Add "high" parameter.
9997         (ada_evaluate_subexp): Update.
9998
9999 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10000
10001         * unittests/string_view-selftests.c: Define
10002         _initialize_string_view_selftests unconditionally.
10003
10004 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10005
10006         PR gdb/24350
10007         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10008
10009 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10010
10011         PR gdb/24351
10012         * windows-nat.c (display_selector): Fix format specifiers.
10013
10014 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10015
10016         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10017         tui_refill_source_window instead of tui_refresh_win, to update the
10018         current execution line.  This fixes redisplay of the current line
10019         when stepping through the code with "next" or "step".
10020
10021 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10022
10023         * source-cache.c (source_cache::get_source_lines): Call
10024         find_source_lines to initialize s->nlines.  This fixes vertical
10025         scrolling of TUI source window when the DOWN arrow is pressed.
10026
10027 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10028
10029         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10030         linux-thread-db.c (_initialize_thread_db): Likewise.
10031
10032 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10033
10034         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10035         wclrtoeol in tui_show_source_line".  This reverts changes made in
10036         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10037
10038 2019-03-15  Tom Tromey  <tom@tromey.com>
10039
10040         * symtab.h (struct minimal_symbol): Derive from
10041         general_symbol_info.
10042         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10043         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10044         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10045         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10046         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10047         (MSYMBOL_SEARCH_NAME): Update.
10048         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10049         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10050         * minsyms.c (minimal_symbol_reader::record_full): Update.
10051
10052 2019-03-15  Tom Tromey  <tom@tromey.com>
10053
10054         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10055
10056 2019-03-15  Tom Tromey  <tom@tromey.com>
10057
10058         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10059         unique_xmalloc_ptr.
10060         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10061         Update.
10062         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10063         (build_minimal_symbol_hash_tables)
10064         (minimal_symbol_reader::install): Update.
10065
10066 2019-03-15  Tom Tromey  <tom@tromey.com>
10067
10068         * symtab.c (create_demangled_names_hash): Update.
10069         (symbol_set_names): Update.
10070         * objfiles.h (struct objfile_per_bfd_storage)
10071         <demangled_names_hash>: Now an htab_up.
10072         * objfiles.c (objfile_per_bfd_storage): Simplify.
10073
10074 2019-03-15  Tom Tromey  <tom@tromey.com>
10075
10076         * objfiles.h (struct objfile_per_bfd_storage): Declare
10077         destructor.
10078         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10079         New.
10080         (get_objfile_bfd_data): Use new.  Don't initialize
10081         language_of_main.
10082         (free_objfile_per_bfd_storage): Remove.
10083         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10084
10085 2019-03-15  Tom Tromey  <tom@tromey.com>
10086
10087         * symfile.c (reread_symbols): Update.
10088         * objfiles.c (objfile::objfile): Update.
10089         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10090         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10091         comment.
10092         (minimal_symbol_reader::install): Update.
10093         (terminate_minimal_symbol_table): Remove.
10094         * jit.c (jit_object_close_impl): Update.
10095
10096 2019-03-15  Tom Tromey  <tom@tromey.com>
10097
10098         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10099         initializations.
10100
10101 2019-03-15  Tom Tromey  <tom@tromey.com>
10102
10103         * objfiles.h (struct objfile_per_bfd_storage)
10104         <demangled_hash_languages>: Now a bitset.
10105         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10106         (lookup_minimal_symbol): Update.
10107
10108 2019-03-15  Tom Tromey  <tom@tromey.com>
10109
10110         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10111         Don't return the symbol.
10112         * coffread.c (record_minimal_symbol): Use record_full.
10113
10114 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10115
10116         The MS-Windows port of ncurses fails to switch to a color pair if
10117         one or both of the colors are the implicit default colors.  This
10118         change records the default colors when TUI is initialized, and
10119         then specifies them explicitly when a color pair uses the default
10120         colors.  This allows color styling in TUI mode on MS-Windows.
10121
10122         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10123         ncurses_norm_attr.
10124         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10125         colors in ncurses_norm_attr.
10126         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10127         "none", replace it with the default color recorded in
10128         ncurses_norm_attr.
10129
10130 2019-03-14  Tom Tromey  <tromey@adacore.com>
10131
10132         * source-cache.h (class source_cache) <get_source_lines>: Return
10133         std::string.
10134         * source-cache.c (source_cache::extract_lines): Handle case where
10135         first_pos==npos.  Return std::string.
10136         (source_cache::get_source_lines): Update.
10137
10138 2019-03-14  Tom Tromey  <tromey@adacore.com>
10139
10140         * NEWS: Add item for "style sources" commands.
10141         * source-cache.c (source_cache::get_source_lines): Check
10142         source_styling.
10143         * cli/cli-style.c (source_styling): New global.
10144         (_initialize_cli_style): Add "style sources" commands.
10145         (show_style_sources): New function.
10146         * cli/cli-style.h (source_styling): Declare.
10147
10148 2019-03-14  Pedro Alves  <palves@redhat.com>
10149             Tom Tromey  <tromey@adacore.com>
10150
10151         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10152         * tui/tui-winsource.c (tui_refill_source_window): New function,
10153         from...
10154         (tui_horizontal_source_scroll): ... here.  Move some logic.
10155         * cli/cli-style.c (set_style_enabled): Notify new observable.
10156         * tui/tui-hooks.c (tui_redisplay_source): New function.
10157         (tui_attach_detach_observers): Attach or detach
10158         tui_redisplay_source.
10159         * observable.h (source_styling_changed): New observable.
10160         * observable.c: Define source_styling_changed observable.
10161
10162 2019-03-13  Tom Tromey  <tromey@adacore.com>
10163
10164         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10165         (i386_gnu_nat_target::store_registers): Update.
10166         * target-debug.h (target_debug_print_std_string): New macro.
10167         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10168         * windows-tdep.c (display_one_tib): Update.
10169         * tui/tui-stack.c (tui_make_status_line): Update.
10170         * top.c (print_inferior_quit_action): Update.
10171         * thread.c (thr_try_catch_cmd): Update.
10172         (add_thread_with_info): Update.
10173         (thread_target_id_str): Update.
10174         (thr_try_catch_cmd): Update.
10175         (thread_command): Update.
10176         (thread_find_command): Update.
10177         * record-btrace.c (record_btrace_target::info_record)
10178         (record_btrace_resume_thread, record_btrace_target::resume)
10179         (record_btrace_cancel_resume, record_btrace_step_thread)
10180         (record_btrace_target::wait, record_btrace_target::wait)
10181         (record_btrace_target::wait, record_btrace_target::stop): Update.
10182         * progspace.c (print_program_space): Update.
10183         * process-stratum-target.c
10184         (process_stratum_target::thread_address_space): Update.
10185         * linux-fork.c (linux_fork_mourn_inferior)
10186         (detach_checkpoint_command, info_checkpoints_command)
10187         (linux_fork_context): Update.
10188         (linux_fork_detach): Update.
10189         (class scoped_switch_fork_info): Update.
10190         (delete_checkpoint_command): Update.
10191         * infrun.c (follow_fork_inferior): Update.
10192         (follow_fork_inferior): Update.
10193         (proceed_after_vfork_done): Update.
10194         (handle_vfork_child_exec_or_exit): Update.
10195         (follow_exec): Update.
10196         (displaced_step_prepare_throw): Update.
10197         (displaced_step_restore): Update.
10198         (start_step_over): Update.
10199         (resume_1): Update.
10200         (clear_proceed_status_thread): Update.
10201         (proceed): Update.
10202         (print_target_wait_results): Update.
10203         (do_target_wait): Update.
10204         (context_switch): Update.
10205         (stop_all_threads): Update.
10206         (restart_threads): Update.
10207         (finish_step_over): Update.
10208         (handle_signal_stop): Update.
10209         (switch_back_to_stepped_thread): Update.
10210         (keep_going_pass_signal): Update.
10211         (print_exited_reason): Update.
10212         (normal_stop): Update.
10213         * inferior.c (inferior_pid_to_str): Change return type.
10214         (print_selected_inferior): Update.
10215         (add_inferior): Update.
10216         (detach_inferior): Update.
10217         * dummy-frame.c (fprint_dummy_frames): Update.
10218         * dcache.c (dcache_info_1): Update.
10219         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10220         (btrace_fetch, btrace_clear): Update.
10221         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10222         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10223         type.
10224         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10225         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10226         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10227         * gdbarch.c, gdbarch.h: Rebuild.
10228         * gdbarch.sh (core_pid_to_str): Change return type.
10229         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10230         return type.
10231         (windows_nat_target::pid_to_str): Change return type.
10232         (windows_delete_thread): Update.
10233         (windows_nat_target::attach): Update.
10234         (windows_nat_target::files_info): Update.
10235         * target-delegates.c: Rebuild.
10236         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10237         return type.
10238         (sol_thread_target::pid_to_str): Change return type.
10239         * remote.c (class remote_target) <pid_to_str>: Change return
10240         type.
10241         (remote_target::pid_to_str): Change return type.
10242         (extended_remote_target::attach, remote_target::remote_stop_ns)
10243         (remote_target::remote_notif_remove_queued_reply)
10244         (remote_target::push_stop_reply, remote_target::disable_btrace):
10245         Update.
10246         (extended_remote_target::attach): Update.
10247         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10248         type.
10249         (gdbsim_target::pid_to_str): Change return type.
10250         * ravenscar-thread.c (struct ravenscar_thread_target)
10251         <pid_to_str>: Change return type.
10252         (ravenscar_thread_target::pid_to_str): Change return type.
10253         * procfs.c (class procfs_target) <pid_to_str>: Change return
10254         type.
10255         (procfs_target::pid_to_str): Change return type.
10256         (procfs_target::attach): Update.
10257         (procfs_target::detach): Update.
10258         (procfs_target::fetch_registers): Update.
10259         (procfs_target::store_registers): Update.
10260         (procfs_target::wait): Update.
10261         (procfs_target::files_info): Update.
10262         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10263         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10264         return type.
10265         (nto_procfs_target::pid_to_str): Change return type.
10266         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10267         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10268         return type.
10269         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10270         (exit_lwp): Update.
10271         (attach_proc_task_lwp_callback, get_detach_signal)
10272         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10273         (linux_nat_target::resume, wait_lwp, stop_callback)
10274         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10275         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10276         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10277         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10278         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10279         type.
10280         (inf_ptrace_target::attach): Update.
10281         (inf_ptrace_target::files_info): Update.
10282         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10283         type.
10284         (go32_nat_target::pid_to_str): Change return type.
10285         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10286         (gnu_nat_target::wait): Update.
10287         (gnu_nat_target::wait): Update.
10288         (gnu_nat_target::resume): Update.
10289         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10290         (fbsd_nat_target::wait): Update.
10291         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10292         type.
10293         (darwin_nat_target::attach): Update.
10294         * corelow.c (class core_target) <pid_to_str>: Change return type.
10295         (core_target::pid_to_str): Change return type.
10296         * target.c (normal_pid_to_str): Change return type.
10297         (default_pid_to_str): Likewise.
10298         (target_pid_to_str): Change return type.
10299         (target_translate_tls_address): Update.
10300         (target_announce_detach): Update.
10301         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10302         return type.
10303         (bsd_uthread_target::pid_to_str): Change return type.
10304         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10305         type.
10306         (bsd_kvm_target::pid_to_str): Change return type.
10307         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10308         return type.
10309         (aix_thread_target::pid_to_str): Change return type.
10310         * target.h (struct target_ops) <pid_to_str>: Change return type.
10311         (target_pid_to_str, normal_pid_to_str): Likewise.
10312         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10313         type.
10314         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10315         type.
10316         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10317         return type.
10318         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10319         type.
10320         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10321         type.
10322         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10323         return type.
10324
10325 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10326
10327         * NEWS: Mention that the new default MI version is 3.  Mention
10328         changes to the output of commands and events that deal with
10329         multi-location breakpoints.
10330         * breakpoint.c: Include "mi/mi-out.h".
10331         (print_one_breakpoint): Change output syntax if using MI version
10332         >= 3.
10333         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10334         New.
10335         (mi_multi_location_breakpoint_output_fixed): New.
10336         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10337         (mi_cmd_fix_multi_location_breakpoint_output): New.
10338         (mi_multi_location_breakpoint_output_fixed): New.
10339         * mi/mi-cmds.c (mi_cmds): Register command
10340         -fix-multi-location-breakpoint-output.
10341         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10342         interpreter "mi".
10343
10344 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10345
10346         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10347         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10348         instantiate mi_ui_out based on interpreter name.
10349         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10350         * mi/mi-main.c (mi_load_progress): Likewise.
10351
10352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10353
10354         * NEWS: Combine separate "New targets" sections for 8.3.
10355
10356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10357
10358         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10359         (ppcfbsd_init_abi): Install gdbarch
10360         "fetch_tls_load_module_address" and "get_thread_local_address"
10361         methods.
10362
10363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10364
10365         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10366         (riscv_fbsd_init_abi): Install gdbarch
10367         "fetch_tls_load_module_address" and "get_thread_local_address"
10368         methods.
10369
10370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10371
10372         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10373         (i386fbsd_init_abi): Install gdbarch
10374         "fetch_tls_load_module_address" and "get_thread_local_address"
10375         methods.
10376
10377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10378
10379         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10380         (amd64fbsd_init_abi): Install gdbarch
10381         "fetch_tls_load_module_address" and "get_thread_local_address"
10382         methods.
10383
10384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10385
10386         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10387         (struct fbsd_pspace_data): New type.
10388         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10389         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10390         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10391         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10392         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10393
10394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10395
10396         * gdbtypes.c (lookup_struct_elt): New function.
10397         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10398         * gdbtypes.h (struct struct_elt): New type.
10399         (lookup_struct_elt): New prototype.
10400
10401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10402
10403         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10404         remove disabled code block.
10405
10406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10407
10408         * gdbarch.sh (get_thread_local_address): New method.
10409         * gdbarch.h, gdbarch.c: Regenerate.
10410         * target.c (target_translate_tls_address): Use
10411         gdbarch_get_thread_local_address if present instead of
10412         target::get_thread_local_address.
10413
10414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10415
10416         * target.h (target::get_thread_local_address): Update comment.
10417
10418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10419
10420         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10421         objfile->separate_debug_objfile_backlink if not NULL.
10422
10423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10424
10425         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10426         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10427         (amd64bsd_store_inferior_registers): Likewise.
10428         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10429         Enable segment base registers.
10430         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10431         PT_GETFSBASE and PT_GETGSBASE.
10432         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10433         PT_SETGSBASE.
10434         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10435         segment base registers.
10436         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10437
10438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10439
10440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10441         Update calls to i386_target_description to add 'segments'
10442         parameter.
10443         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10444         add segment base registers.
10445         * arch/i386.c (i386_create_target_description): Add 'segments'
10446         parameter to enable segment base registers.
10447         * arch/i386.h (i386_create_target_description): Likewise.
10448         * features/i386/32bit-segments.xml: New file.
10449         * features/i386/32bit-segments.c: Generate.
10450         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10451         call to i386_target_description to add 'segments' parameter.
10452         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10453         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10454         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10455         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10456         if feature is present.
10457         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10458         Add 'segments' parameter to call to i386_target_description.
10459         (i386_target_description): Add 'segments' parameter to enable
10460         segment base registers.
10461         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10462         to call to i386_target_description.
10463         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10464         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10465         Define I386_NUM_REGS.
10466         (i386_target_description): Add 'segments' parameter to enable
10467         segment base registers.
10468
10469 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10470
10471         PR/24325
10472         * source-cache.c: #undef open and close, to avoid unresolved
10473         externals during linking.
10474
10475 2019-03-12  Tom Tromey  <tromey@adacore.com>
10476
10477         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10478         const.  Add initializers.
10479         (_initialize_remote): Don't initialize ptid globals.
10480
10481 2019-03-12  Pedro Alves  <palves@redhat.com>
10482
10483         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10484
10485 2019-03-12  Pedro Alves  <palves@redhat.com>
10486
10487         * cp-name-parser.y (main): Remove unused 'len' variable.
10488
10489 2019-03-12  Tom Tromey  <tromey@adacore.com>
10490
10491         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10492         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10493
10494 2019-03-12  Tom Tromey  <tromey@adacore.com>
10495
10496         * linux-nat.c (iterate_over_lwps): Update.
10497         (stop_callback): Remove parameter.
10498         (stop_wait_callback, detach_callback, resume_set_callback)
10499         (select_singlestep_lwp_callback, set_ignore_sigint)
10500         (status_callback, resumed_callback, resume_clear_callback)
10501         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10502         data parameter.
10503         (linux_nat_target::detach, linux_nat_target::resume)
10504         (linux_stop_and_wait_all_lwps, select_event_lwp)
10505         (linux_nat_filter_event, linux_nat_wait_1)
10506         (linux_nat_target::kill, linux_nat_target::stop)
10507         (linux_nat_target::stop): Update.
10508         (linux_nat_resume_callback): Change type.
10509         (resume_stopped_resumed_lwps, count_events_callback)
10510         (select_event_lwp_callback): Likewise.
10511         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10512         * arm-linux-nat.c (struct update_registers_data): Remove.
10513         (update_registers_callback): Change type.
10514         (arm_linux_insert_hw_breakpoint1): Update.
10515         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10516         parameter.
10517         (x86_linux_dr_set_addr): Update.
10518         (x86_linux_dr_set_control): Update.
10519         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10520         (iterate_over_lwps): Use gdb::function_view.
10521         * nat/aarch64-linux-hw-point.c (struct
10522         aarch64_dr_update_callback_param): Remove.
10523         (debug_reg_change_callback): Change type.
10524         (aarch64_notify_debug_reg_change): Update.
10525         * s390-linux-nat.c (s390_refresh_per_info): Update.
10526
10527 2019-03-11  Tom Tromey  <tromey@adacore.com>
10528
10529         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10530         redundant assignment to "this_cu".
10531
10532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10533
10534         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10535
10536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10537
10538         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10539         from...
10540         (rank_one_type): ... this.
10541
10542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10543
10544         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10545         from...
10546         (rank_one_type): ... this.
10547
10548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10549
10550         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10551         from...
10552         (rank_one_type): ... this.
10553
10554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10555
10556         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10557         from...
10558         (rank_one_type): ... this.
10559
10560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10561
10562         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10563         from...
10564         (rank_one_type): ... this.
10565
10566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10567
10568         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10569         from...
10570         (rank_one_type): ... this.
10571
10572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10573
10574         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10575         from...
10576         (rank_one_type): ... this.
10577
10578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10579
10580         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10581         from...
10582         (rank_one_type): ... this.
10583
10584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10585
10586         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10587         from...
10588         (rank_one_type): ... this.
10589
10590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10591
10592         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10593         from...
10594         (rank_one_type): ... this.
10595
10596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10597
10598         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10599         from...
10600         (rank_one_type): ... this.
10601
10602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10603
10604         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10605         from...
10606         (rank_one_type): ... this.
10607
10608 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10609
10610         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10611         inferior-events' shows the example events.
10612
10613 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10614
10615         Support styling on native MS-Windows console
10616
10617         PR/24315
10618         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10619         on MS-Windows if $TERM is not defined.
10620
10621         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10622
10623         * posix-hdep.c (gdb_console_fputs):
10624         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10625         functions.
10626         * ui-file.h (gdb_console_fputs): Add prototype.
10627
10628         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10629         back to fputs only if the former returns zero.
10630
10631 2019-03-07  Tom Tromey  <tom@tromey.com>
10632
10633         * symmisc.c (print_symbol_bcache_statistics): Update.
10634         (print_objfile_statistics): Update.
10635         * symfile.c (allocate_symtab): Update.
10636         * stabsread.c: Don't include bcache.h.
10637         * psymtab.h (struct psymbol_bcache): Don't declare.
10638         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10639         (psymbol_bcache_init, psymbol_bcache_free)
10640         (psymbol_bcache_get_bcache): Don't declare.
10641         * psymtab.c (struct psymbol_bcache): Remove.
10642         (psymtab_storage::psymtab_storage): Update.
10643         (psymtab_storage::~psymtab_storage): Update.
10644         (psymbol_bcache_init, psymbol_bcache_free)
10645         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10646         (add_psymbol_to_bcache): Update.
10647         (allocate_psymtab): Update.
10648         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10649         macro_cache>: No longer pointers.
10650         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10651         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10652         * macrotab.c (macro_bcache): Update.
10653         * macroexp.c: Don't include bcache.h.
10654         * gdbtypes.c (check_types_worklist): Update.
10655         (types_deeply_equal): Remove TRY/CATCH.  Update.
10656         * elfread.c (elf_symtab_read): Update.
10657         * dwarf2read.c: Don't include bcache.h.
10658         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10659         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10660         (print_bcache_statistics, bcache_memory_used): Don't declare.
10661         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10662         methods.  Rename all data members.
10663         * bcache.c (struct bcache): Move to bcache.h.
10664         (bcache::expand_hash_table): Rename from expand_hash_table.
10665         (bcache): Remove.
10666         (bcache::insert): Rename from bcache_full.
10667         (bcache::compare): Rename from bcache_compare.
10668         (bcache_xmalloc): Remove.
10669         (bcache::~bcache): Rename from bcache_xfree.
10670         (bcache::print_statistics): Rename from print_bcache_statistics.
10671         (bcache::memory_used): Rename from bcache_memory_used.
10672
10673 2019-03-07  Pedro Alves  <palves@redhat.com>
10674
10675         * infrun.c (normal_stop): Also check for
10676         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10677
10678 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10679
10680         * f-lang.c (value_from_host_double): Moved to...
10681         * value.c (value_from_host_double): ...here.
10682         * value.h (value_from_host_double): Declare.
10683         * guile/scm-math.c (vlscm_convert_typed_number): Use
10684         value_from_host_double.
10685         (vlscm_convert_number): Likewise.
10686         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10687         * python/py-value.c (convert_value_from_python): Likewise.
10688
10689 2019-03-06  Tom Tromey  <tom@tromey.com>
10690
10691         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10692
10693 2019-03-06  Tom Tromey  <tom@tromey.com>
10694
10695         * utils.h (free_current_contents): Don't declare.
10696         * utils.c (free_current_contents): Remove.
10697
10698 2019-03-06  Tom Tromey  <tom@tromey.com>
10699
10700         * top.c (quit_force): Update.
10701         * main.c (captured_command_loop): Update.
10702         * common/new-op.c (operator new): Update.
10703         * common/common-exceptions.c (struct catcher)
10704         <save_cleanup_chain>: Remove member.
10705         (exceptions_state_mc_init): Update.
10706         (exception_try_scope_entry): Return nullptr.
10707         (exception_try_scope_exit, exception_rethrow)
10708         (throw_exception_sjlj, throw_exception_cxx): Update.
10709         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10710         (all_cleanups, do_cleanups, discard_cleanups)
10711         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10712         (restore_cleanups, restore_final_cleanups): Don't declare.
10713         (do_final_cleanups): Remove parameter.
10714         * common/cleanups.c (cleanup_chain, make_cleanup)
10715         (make_cleanup_dtor, all_cleanups, do_cleanups)
10716         (discard_my_cleanups, discard_cleanups)
10717         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10718         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10719         (null_cleanup): Remove.
10720         (do_final_cleanups): Remove parameter.
10721
10722 2019-03-06  Tom Tromey  <tom@tromey.com>
10723
10724         * remote.c (remote_target::remote_parse_stop_reply): Use
10725         unique_xmalloc_ptr.
10726
10727 2019-03-06  Tom Tromey  <tom@tromey.com>
10728
10729         * stabsread.c (struct stabs_field_info): Rename from field_info.
10730         <list, fnlist>: Add initializers.
10731         <obstack>: New member.
10732         (read_member_functions, read_struct_fields, read_baseclasses):
10733         Allocate on obstack.  Don't use cleanups.
10734         (read_one_struct_field, read_member_functions, read_struct_fields)
10735         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10736         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10737         (read_struct_type): Update.
10738
10739 2019-03-06  Tom Tromey  <tom@tromey.com>
10740
10741         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10742         * common/filestuff.h (make_cleanup_close): Don't declare.
10743         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10744         Remove.
10745
10746 2019-03-06  Tom Tromey  <tom@tromey.com>
10747
10748         * solib-aix.c: Use make_scope_exit.
10749
10750 2019-03-06  Tom Tromey  <tom@tromey.com>
10751
10752         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10753         Use make_scope_exit.
10754
10755 2019-03-06  Tom Tromey  <tom@tromey.com>
10756
10757         * solib-svr4.c (disable_probes_interface): Remove parameter.
10758         (svr4_handle_solib_event): Use make_scope_exit.
10759
10760 2019-03-06  Tom Tromey  <tom@tromey.com>
10761
10762         * remote.c (struct stop_reply_deleter): Remove.
10763         (stop_reply_up): Update.
10764         (struct stop_reply): Derive from notif_event.  Don't typedef.
10765         <regcache>: Now a std::vector.
10766         (stop_reply_xfree): Remove.
10767         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10768         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10769         (remote_target::discard_pending_stop_replies): Use delete.
10770         (remote_target::remote_parse_stop_reply): Update.
10771         (remote_target::process_stop_reply): Update.
10772         * remote-notif.h (struct notif_event): Add virtual destructor.
10773         Remove "dtr" member.
10774         (struct notif_client) <alloc_event>: Return a unique_ptr.
10775         (notif_event_xfree): Don't declare.
10776         (notif_event_up): New typedef.
10777         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10778         (notif_event_xfree, do_notif_event_xfree): Remove.
10779         (remote_notif_state_xfree): Update.
10780
10781 2019-03-06  Tom Tromey  <tom@tromey.com>
10782
10783         * infrun.c (displaced_step_clear_cleanup): Now a
10784         forward_scope_exit type.
10785         (displaced_step_prepare_throw): Update.
10786         (displaced_step_fixup): Update.
10787
10788 2019-03-06  Tom Tromey  <tom@tromey.com>
10789
10790         * inferior.h (class inferior): Update comment.
10791         * gdbthread.h (class thread_info): Update comment.
10792
10793 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10794             Tom Tromey  <tom@tromey.com>
10795
10796         * stabsread.h (struct stab_section_list): Remove.
10797         (coffstab_build_psymtabs): Update.
10798         * dbxread.c (symbuf_sections): Now a std::vector.
10799         (sect_idx): New global.
10800         (fill_symbuf): Update.
10801         (coffstab_build_psymtabs): Change type of stabsects parameter.
10802         Update.
10803         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10804         std::vector.
10805         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10806         (coff_locate_sections): Update.
10807         (coff_symfile_read): Remove cleanups.  Update.
10808         (init_stringtab): Add storage parameter.
10809         (free_stringtab, free_stringtab_cleanup): Remove.
10810         (init_lineno): Add storage parameter.
10811         (free_linetab, free_linetab_cleanup): Remove.
10812
10813 2019-03-06  Pedro Alves  <palves@redhat.com>
10814
10815         * linux-fork.c (fork_info::clobber_regs): Delete.
10816         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10817         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10818         comment.  Adjust.
10819         (scoped_switch_fork_info::scoped_switch_fork_info)
10820         (checkpoint_command, linux_fork_context): Adjust
10821         fork_save_infrun_state calls.
10822
10823 2019-03-06  Pedro Alves  <palves@redhat.com>
10824
10825         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10826         (inf_has_multiple_threads): Return 'bool' and rewrite using
10827         inferior_info::threads().
10828
10829 2019-03-06  Pedro Alves  <palves@redhat.com>
10830
10831         * linux-fork.c: Include <list>.
10832         (fork_list): Now a std::list instance.
10833         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10834         (forks_exist_p, find_last_fork): Adjust.
10835         (new_fork): Delete.
10836         (one_fork_p): New.
10837         (add_fork): Adjust.
10838         (free_fork): Delete, folded into fork_info::~fork_info().
10839         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10840         Adjust.
10841         (init_fork_list): Delete.
10842         (linux_fork_killall, linux_fork_mourn_inferior)
10843         (linux_fork_detach, info_checkpoints_command): Adjust.
10844         (_initialize_linux_fork): No longer call init_fork_list.
10845
10846 2019-03-06  Pedro Alves  <palves@redhat.com>
10847
10848         * linux-fork.c (new_fork): New, split out of ...
10849         (add_fork): ... this.  Return void.  Move "first fork" special
10850         case from here, to ...
10851         (checkpoint_command): ... here.
10852         * linux-linux.h (add_fork): Return void.
10853
10854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10855
10856         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10857
10858 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10859             Chris January  <chris.january@arm.com>
10860             David Lecomber  <david.lecomber@arm.com>
10861
10862         * f-exp.y: New token, UNOP_INTRINSIC.
10863         (exp): New pattern using UNOP_INTRINSIC token.
10864         (f77_keywords): Add 'abs' keyword.
10865         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10866         (value_from_host_double): New function.
10867         (evaluate_subexp_f): Support UNOP_ABS.
10868
10869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10870
10871         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10872         types.
10873
10874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10875
10876         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10877         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10878         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10879
10880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10883
10884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10885             Chris January  <chris.january@arm.com>
10886
10887         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10888         * f-exp.y: Define 'KIND' token.
10889         (exp): New pattern for KIND expressions.
10890         (ptype): Handle types with a kind extension.
10891         (direct_abs_decl): Extend to spot kind extensions.
10892         (f77_keywords): Add 'kind' to the list.
10893         (push_kind_type): New function.
10894         (convert_to_kind_type): New function.
10895         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10896         * parse.c (operator_length_standard): Likewise.
10897         * parser-defs.h (enum type_pieces): Add tp_kind.
10898         * std-operator.def: Add UNOP_KIND.
10899
10900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10901
10902         * f-exp.y (f_parse): Set yydebug.
10903
10904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * f-lang.c (evaluate_subexp_f): New function.
10907         (exp_descriptor_f): New global.
10908         (f_language_defn): Use exp_descriptor_f instead of
10909         exp_descriptor_standard.
10910
10911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10912
10913         * f-exp.y (struct token): Add comments.
10914         (dot_ops): Remove uppercase versions and the end marker.
10915         (f77_keywords): Likewise.
10916         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10917         entries in the dot_ops array are case insensitive, and use
10918         strncasecmp to compare strings.  Also some whitespace cleanup in
10919         this area.  Similar for the f77_keywords array, except entries in
10920         this list might be case sensitive.
10921
10922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10923
10924         * f-exp.y (struct f77_boolean_val): Add comments.
10925         (boolean_values): Remove uppercase versions, and end marker.
10926         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10927         and use strncasecmp to achieve case insensitivity.  Additionally,
10928         perform whitespace cleanup around this code.
10929
10930 2019-03-06  Tom Tromey  <tromey@adacore.com>
10931
10932         * remote-sim.c (gdbsim_target_open): Use result of
10933         gdb_argv::release.
10934
10935 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10936         Dirk Schubert  <dirk.schubert@arm.com>
10937         Chris January  <chris.january@arm.com>
10938
10939         * eval.c (evaluate_subexp_standard): Call Fortran argument
10940         wrapping logic.
10941         * f-lang.c (struct value): A value which can be passed into a
10942         Fortran function call.
10943         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10944         where appropriate.
10945         (struct type): Value ready for a Fortran function call.
10946         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10947         is needed.
10948         * f-lang.h (fortran_argument_convert): Declaration.
10949         (fortran_preserve_arg_pointer): Declaration.
10950         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10951
10952 2019-03-05  Tom Tromey  <tromey@adacore.com>
10953
10954         * python/py-prettyprint.c (print_string_repr): Remove #if.
10955         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10956
10957 2019-03-05  Tom Tromey  <tromey@adacore.com>
10958
10959         * target.c (the_dummy_target): Move later.  Change type to
10960         "dummy_target".
10961         (initialize_targets): Don't initialize the_dummy_target.
10962
10963 2019-03-05  Tom Tromey  <tromey@adacore.com>
10964
10965         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10966         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10967
10968 2019-03-05  Tom Tromey  <tromey@adacore.com>
10969
10970         * windows-nat.c (windows_nat_target::attach)
10971         (windows_nat_target::detach): Don't call gdb_flush.
10972         * valprint.c (generic_val_print, val_print, val_print_string):
10973         Don't call gdb_flush.
10974         * utils.c (defaulted_query): Don't call gdb_flush.
10975         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10976         * target.c (target_announce_detach): Don't call gdb_flush.
10977         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10978         * remote.c (extended_remote_target::attach): Don't call
10979         gdb_flush.
10980         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10981         * printcmd.c (do_examine): Don't call gdb_flush.
10982         (info_display_command): Don't call gdb_flush.
10983         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10984         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10985         * memattr.c (info_mem_command): Don't call gdb_flush.
10986         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10987         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10988         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10989         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10990         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10991         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10992         (gnu_nat_target::detach): Don't call gdb_flush.
10993         * f-valprint.c (f_val_print): Don't call gdb_flush.
10994         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10995         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10996         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10997         gdb_flush.
10998         * c-valprint.c (c_val_print): Don't call gdb_flush.
10999         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11000
11001 2019-03-05  Tom Tromey  <tromey@adacore.com>
11002
11003         * varobj.c (update_dynamic_varobj_children): Update.
11004         (install_default_visualizer): Use reset, not release.
11005         * value.c (set_internalvar): Update.
11006         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11007         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11008         ATTRIBUTE_UNUSED_RESULT.
11009
11010 2019-03-05  Tom Tromey  <tromey@adacore.com>
11011
11012         * remote.c (class scoped_remote_fd) <release>: Add
11013         ATTRIBUTE_UNUSED_RESULT.
11014
11015 2019-03-05  Tom Tromey  <tromey@adacore.com>
11016
11017         * macroexp.c (struct macro_buffer) <release>: Add
11018         ATTRIBUTE_UNUSED_RESULT.
11019
11020 2019-03-05  Tom Tromey  <tromey@adacore.com>
11021
11022         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11023         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11024         ATTRIBUTE_UNUSED_RESULT.
11025
11026 2019-03-05  Tom Tromey  <tromey@adacore.com>
11027
11028         * common/scoped_fd.h (class scoped_fd) <release>: Add
11029         ATTRIBUTE_UNUSED_RESULT.
11030
11031 2019-03-05  Tom Tromey  <tromey@adacore.com>
11032
11033         * parser-defs.h (struct parser_state) <release>: Add
11034         ATTRIBUTE_UNUSED_RESULT.
11035
11036 2019-03-05  Tom Tromey  <tromey@adacore.com>
11037
11038         * utils.h (class gdb_argv) <release>: Add
11039         ATTRIBUTE_UNUSED_RESULT.
11040         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11041
11042 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11043
11044         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11045         for-loop range, to avoid compiler warnings.
11046
11047         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11048         avoid compiler warnings about unused variables.
11049
11050         * NEWS: Mention end of support for native debugging on MS-Windows
11051         before XP.
11052
11053         PR gdb/24292
11054         * common/netstuff.c:
11055         * gdbserver/gdbreplay.c
11056         * gdbserver/remote-utils.c:
11057         * ser-tcp.c:
11058         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11059         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11060         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11061         'getaddrinfo' and 'freeaddrinfo' were not available before
11062         Windows XP, and mingw.org's MinGW headers by default define
11063         _WIN32_WINNT to 0x500.
11064
11065 2019-03-01  Gary Benson <gbenson@redhat.com>
11066
11067         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11068
11069 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11070             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11071
11072         PR gdb/8527
11073         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11074         set_sigint_trap, clear_sigint_trap.
11075
11076 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11077
11078         * target.c (target_detach): Clear the regcache and the
11079         frame cache.
11080
11081 2019-02-27  Pedro Alves  <palves@redhat.com>
11082
11083         * utils.c (set_screen_size): When we cap the height/width sizes,
11084         tweak the corresponding command variable to show "unlimited":
11085
11086 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11087             Pedro Alves  <palves@redhat.com>
11088
11089         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11090         before calling rl_set_screen_size.
11091
11092 2019-02-27  Tom Tromey  <tromey@adacore.com>
11093
11094         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11095         define.
11096         * python/py-value.c: Remove Python 2.4 workaround.
11097         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11098         workaround.
11099         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11100         Python 2.4 workaround.
11101         * python/python-internal.h: Remove Python 2.4 comment.
11102         (Py_ssize_t): Don't define.
11103         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11104         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11105         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11106         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11107         * python/python.c (do_start_initialization): Remove Python 2.4
11108         workaround.
11109         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11110         (print_children): Remove Python 2.4 workaround.
11111         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11112         workaround.
11113         (CHARBUFFERPROC_NAME): Remove.
11114         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11115         Python 2.4 workaround.
11116
11117 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11118
11119         * NEWS: Note minimum Python version.
11120
11121 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11122
11123         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11124         code from these functions.  Remove corresponding ifdefs.  Use
11125         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11126         Remove gotos and target of gotos.
11127         (infpy_search_memory): Likewise.
11128
11129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11130
11131         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11132         (hppa_gdbarch_init): Don't register deleted functions with
11133         gdbarch.
11134
11135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11136
11137         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11138         (h8300_unwind_sp): Delete.
11139         (h8300_dummy_id): Delete.
11140         (h8300_gdbarch_init): Don't register deleted functions with
11141         gdbarch.
11142
11143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11144
11145         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11146         (ft32_unwind_pc): Delete.
11147         (ft32_unwind_sp): Delete.
11148         (ft32_gdbarch_init): Don't register deleted functions with
11149         gdbarch.
11150
11151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11152
11153         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11154         (frv_unwind_pc): Delete.
11155         (frv_unwind_sp): Delete.
11156         (frv_gdbarch_init): Don't register deleted functions with
11157         gdbarch.
11158
11159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11160
11161         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11162         (riscv_unwind_pc): Delete.
11163         (riscv_unwind_sp): Delete.
11164         (riscv_gdbarch_init): Don't register deleted functions with
11165         gdbarch.
11166
11167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11170         (csky_unwind_pc): Delete.
11171         (csky_unwind_sp): Delete.
11172         (csky_gdbarch_init): Don't register deleted functions with
11173         gdbarch.
11174
11175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11176
11177         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11178         (cris_unwind_pc): Delete.
11179         (cris_unwind_sp): Delete.
11180         (cris_gdbarch_init): Don't register deleted functions with
11181         gdbarch.
11182
11183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11186         (bfin_unwind_pc): Delete.
11187         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11188
11189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11190
11191         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11192         (arm_unwind_pc): Delete.
11193         (arm_unwind_sp): Delete.
11194         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11195
11196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11197
11198         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11199         (arc_unwind_pc): Delete.
11200         (arc_unwind_sp): Delete.
11201         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11202
11203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11206         (alpha_unwind_pc): Delete.
11207         (alpha_gdbarch_init): Don't register deleted functions with
11208         gdbarch.
11209
11210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11211
11212         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11213         (aarch64_unwind_pc): Delete.
11214         (aarch64_unwind_sp): Delete.
11215         (aarch64_gdbarch_init): Don't register deleted functions with
11216         gdbarch.
11217
11218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * gdbtypes.c (type_align): Don't consider static members when
11221         computing structure alignment.
11222
11223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11224
11225         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11226         return 0 for other types.
11227         * arch-utils.c (default_type_align): Always return 0.
11228         * gdbarch.h: Regenerate.
11229         * gdbarch.sh (type_align): Extend comment.
11230         * gdbtypes.c (type_align): Add additional comments, always call
11231         gdbarch_type_align before applying the default rules.
11232         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11233         generic code will then apply a suitable default.
11234         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11235         types, return 0 for other types.
11236
11237 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11238
11239         * NEWS: Create a new section for the next release branch.
11240         Rename the section of the current branch, now that it has
11241         been cut.
11242
11243 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11244
11245         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11246         * version.in: Bump version to 8.3.50.DATE-git.
11247
11248 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11249
11250         * aix-thread.c (ptid_cmp): Remove unused variable.
11251         (get_signaled_thread): Likewise.
11252         (store_regs_user_thread): Likewise.
11253         (store_regs_kernel_thread): Likewise.
11254         (fetch_regs_kernel_thread): Remove shadowed variable.
11255
11256 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11257
11258         * features/riscv/32bit-cpu.xml: Add register numbers.
11259         * features/riscv/32bit-fpu.c: Regenerate.
11260         * features/riscv/32bit-fpu.xml: Add register numbers.
11261         * features/riscv/64bit-cpu.xml: Add register numbers.
11262         * features/riscv/64bit-fpu.c: Regenerate.
11263         * features/riscv/64bit-fpu.xml: Add register numbers.
11264
11265 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11266
11267         * NEWS: Mention two argument form of gdb.Value constructor.
11268         * python/py-value.c (convert_buffer_and_type_to_value): New
11269         function.
11270         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11271         Add support for handling an optional second argument.  Call
11272         convert_buffer_and_type_to_value as appropriate.
11273         * python/python-internal.h (Py_buffer_deleter): New struct.
11274         (Py_buffer_up): New typedef.
11275
11276 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11277
11278         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11279         instead of releasing ownership.
11280
11281 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11282
11283         * dwarf2read.c (open_and_init_dwp_file): Call
11284         elf_numsections instead of bfd_count_sections to initialize
11285         dwp_file->num_sections.
11286
11287 2019-02-25  Tom Tromey  <tromey@adacore.com>
11288
11289         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11290
11291 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11292
11293         * gcore.in: Add '--readnever' option when invoking GDB.
11294
11295 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11296
11297         * MAINTAINERS: Update my email address.
11298
11299 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11300
11301         * build-id.c (build_id_to_debug_bfd_1): New function.
11302         (build_id_to_debug_bfd): Look for separate debug file in
11303         sysroot.
11304
11305 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11306
11307         * gdbarch.sh: Update the copyright year range that is placed into
11308         generated files.
11309
11310 2019-02-22  Keith Seitz  <keiths@redhat.com>
11311
11312         PR symtab/23853
11313         * linespec.c (create_sals_line_offset): Search for the default
11314         symtab's filename instead of its fullname.
11315
11316 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11317
11318         * NEWS: Update style defaults.
11319
11320 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11321
11322         * main.c (captured_main_1): Disable styling in batch mode.
11323
11324 2019-02-20  Tom Tromey  <tom@tromey.com>
11325
11326         * symtab.c (symtab_symbol_info): Fix typos.
11327
11328 2019-02-20  Tom Tromey  <tromey@adacore.com>
11329
11330         * findcmd.c (_initialize_mem_search): Use upper case for
11331         metasyntactic variables.
11332
11333 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11334
11335         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11336         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11337
11338 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11339
11340         * top.h (source_file_name): Change to std::string.
11341         * top.c (source_file_name): Likewise.
11342         (command_line_input): Adjust.
11343         * cli/cli-script.c (script_from_file): Adjust.
11344
11345 2019-02-19  Tom Tromey  <tromey@adacore.com>
11346
11347         * ravenscar-thread.c
11348         (ravenscar_thread_target::update_thread_list): Don't call
11349         ada_build_task_list.
11350         * ada-lang.h (ada_build_task_list): Don't declare.
11351         * ada-tasks.c (struct ada_tasks_inferior_data)
11352         <task_list_valid_p>: Now bool.
11353         (read_known_tasks, ada_task_list_changed)
11354         (ada_tasks_invalidate_inferior_data): Update.
11355         (read_known_tasks_array): Return bool.
11356         (read_known_tasks_list): Likewise.
11357         (read_known_tasks): Return void.
11358         (ada_build_task_list): Now static.
11359
11360 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11361
11362         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11363         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11364
11365 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11366
11367         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11368         variant for ada_tasks_pspace_data_handle and
11369         ada_tasks_inferior_data_handle.
11370         (ada_tasks_pspace_data_cleanup): New function.
11371         (ada_tasks_inferior_data_cleanup): New function.
11372
11373 2019-02-17  Tom Tromey  <tom@tromey.com>
11374
11375         * macrotab.h (macro_source_fullname): Return a std::string.
11376         * macrotab.c (macro_include, check_for_redefinition)
11377         (macro_undef, macro_lookup_definition, foreach_macro)
11378         (foreach_macro_in_scope): Update.
11379         (macro_source_fullname): Return a std::string.
11380         * macrocmd.c (show_pp_source_pos): Update.
11381
11382 2019-02-17  Tom Tromey  <tom@tromey.com>
11383
11384         * macrocmd.c (show_pp_source_pos): Style the file names.
11385
11386 2019-02-17  Tom Tromey  <tom@tromey.com>
11387
11388         PR tui/24197:
11389         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11390
11391 2019-02-17  Tom Tromey  <tom@tromey.com>
11392
11393         * ada-lang.c (user_select_syms): Use filtered printing.
11394         * utils.c (wrap_style): New global.
11395         (desired_style): Remove.
11396         (emit_style_escape): Add stream parameter.
11397         (set_output_style, reset_terminal_style, prompt_for_continue):
11398         Update.
11399         (flush_wrap_buffer): Only flush gdb_stdout.
11400         (wrap_here): Set wrap_style.
11401         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11402         treat escape sequences as a character.  Change when wrap buffer is
11403         flushed.
11404         (fputs_styled): Do not set the output style when the default is
11405         requested.
11406         * ui-style.h (struct ui_file_style) <is_default>: New method.
11407         * source.c (print_source_lines_base): Emit escape sequences in one
11408         piece.
11409
11410 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11411
11412         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11413         integers and enumeration types.
11414
11415 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11416
11417         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11418         instead of lookup_symbol_in_language
11419         (do_exact_match): New function.
11420         (ada_get_symbol_name_matcher): Return do_exact_match when
11421         doing a verbatim match.
11422
11423 2019-02-15  Tom Tromey  <tromey@adacore.com>
11424
11425         * ravenscar-thread.c (ravenscar_thread_target::resume)
11426         (ravenscar_thread_target::wait): Special case wildcard requests.
11427
11428 2019-02-15  Tom Tromey  <tromey@adacore.com>
11429
11430         * ravenscar-thread.c (base_ptid): Remove.
11431         (struct ravenscar_thread_target) <close>: New method.
11432         <m_base_ptid>: New member.
11433         <update_inferior_ptid, active_task, task_is_currently_active,
11434         runtime_initialized>: Declare methods.
11435         <ravenscar_thread_target>: Add constructor.
11436         (ravenscar_thread_target::task_is_currently_active)
11437         (ravenscar_thread_target::update_inferior_ptid)
11438         (ravenscar_runtime_initialized): Rename.  Now methods.
11439         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11440         (ravenscar_thread_target::update_thread_list): Update.
11441         (ravenscar_thread_target::active_task): Now method.
11442         (ravenscar_thread_target::store_registers)
11443         (ravenscar_thread_target::prepare_to_store)
11444         (ravenscar_thread_target::prepare_to_store)
11445         (ravenscar_thread_target::mourn_inferior): Update.
11446         (ravenscar_inferior_created): Use "new" to create target.
11447         (ravenscar_thread_target::get_ada_task_ptid): Update.
11448         (_initialize_ravenscar): Don't initialize base_ptid.
11449         (ravenscar_ops): Remove global.
11450
11451 2019-02-15  Tom Tromey  <tromey@adacore.com>
11452
11453         * target.h (push_target): Declare new overload.
11454         * target.c (push_target): New overload, taking an rvalue reference.
11455         * remote.c (remote_target::open_1): Use push_target overload.
11456         * corelow.c (core_target_open): Use push_target overload.
11457
11458 2019-02-15  Tom Tromey  <tromey@adacore.com>
11459
11460         * ravenscar-thread.c (is_ravenscar_task)
11461         (ravenscar_task_is_currently_active): Return bool.
11462         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11463         (_initialize_ravenscar): Remove "(void)".
11464         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11465         Return bool.
11466
11467 2019-02-15  Tom Tromey  <tromey@adacore.com>
11468
11469         * ravenscar-thread.c (ravenscar_runtime_initializer)
11470         (has_ravenscar_runtime, get_running_thread_id)
11471         (ravenscar_thread_target::resume): Fix indentation.
11472
11473 2019-02-15  Tom Tromey  <tromey@adacore.com>
11474
11475         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11476         from ravenscar_arch_ops.
11477         (sparc_ravenscar_ops::fetch_registers)
11478         (sparc_ravenscar_ops::store_registers): Now methods.
11479         (sparc_ravenscar_prepare_to_store): Remove.
11480         (sparc_ravenscar_ops): Redefine.
11481         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11482         methods and destructor.  Remove members.
11483         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11484         (ravenscar_thread_target::store_registers)
11485         (ravenscar_thread_target::prepare_to_store): Update.
11486         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11487         Remove.
11488         (struct ppc_ravenscar_powerpc_ops): Derive from
11489         ravenscar_arch_ops.
11490         (ppc_ravenscar_powerpc_ops::fetch_registers)
11491         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11492         (ppc_ravenscar_powerpc_ops): Redefine.
11493         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11494         (ppc_ravenscar_e500_ops::fetch_registers)
11495         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11496         (ppc_ravenscar_e500_ops): Redefine.
11497         * aarch64-ravenscar-thread.c
11498         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11499         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11500         (aarch64_ravenscar_fetch_registers)
11501         (aarch64_ravenscar_store_registers): Now methods.
11502         (aarch64_ravenscar_ops): Redefine.
11503
11504 2019-02-15  Tom Tromey  <tromey@adacore.com>
11505
11506         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11507         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11508         (ravenscar_thread_target::stopped_by_watchpoint)
11509         (ravenscar_thread_target::stopped_data_address)
11510         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11511
11512 2019-02-15  Tom Tromey  <tromey@adacore.com>
11513
11514         * ravenscar-thread.c: Fix some typos.
11515
11516 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11517             Tom Tromey  <tromey@adacore.com>
11518
11519         * ada-lang.c (ada_exception_sal): Change addr_string to a
11520         std::string.
11521         (create_ada_exception_catchpoint): Update.
11522
11523 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11524             Tom Tromey  <tromey@adacore.com>
11525
11526         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11527         (bp_location_ops): Remove.
11528         (base_breakpoint_allocate_location): Update.
11529         (free_bp_location): Update.
11530         * ada-lang.c (class ada_catchpoint_location)
11531         <ada_catchpoint_location>: Remove ops parameter.
11532         (ada_catchpoint_location_dtor): Remove.
11533         (ada_catchpoint_location_ops): Remove.
11534         (allocate_location_exception): Update.
11535         * breakpoint.h (struct bp_location_ops): Remove.
11536         (class bp_location) <bp_location>: Remove bp_location_ops
11537         parameter.
11538         <~bp_location>: Add destructor.
11539         <ops>: Remove.
11540
11541 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11542             Pedro Alves  <palves@redhat.com>
11543
11544         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11545         'PATH_MAX'.
11546
11547 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11548             Samuel Thibault  <samuel.thibault@gnu.org>
11549             Thomas Schwinge  <thomas@codesourcery.com>
11550
11551         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11552         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11553
11554 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11555
11556         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11557         (check_empty): Use "const char *".
11558
11559         * gnu-nat.c (gnu_nat_target::detach): Instead of
11560         'detach_inferior (pid)' call
11561         'detach_inferior (find_inferior_pid (pid))'.
11562
11563         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11564         'nat/fork-inferior.o'.
11565         * gnu-nat.c: #include "nat/fork-inferior.h".
11566
11567         * gnu-nat.c (gnu_nat_target::detach): Instead of
11568         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11569         * gnu-nat.h: #include "inf-child.h".
11570         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11571         'i386_gnu_nat_target::fetch_registers'.
11572         (gnu_store_registers): Rename/move to
11573         'i386_gnu_nat_target::store_registers'.
11574
11575         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11576         * gnu-nat.h (mach_thread_info): New function.
11577         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11578
11579         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11580
11581 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11582
11583         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11584
11585 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11586
11587         * windows-nat.c (windows_add_thread): Add new parameter
11588         "main_thread_p" with default value set to false.  Update
11589         function documentation as well as all callers.
11590         (windows_delete_thread): Likewise.
11591         (fake_create_process): Update call to windows_add_thread.
11592         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11593         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11594         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11595         call to windows_delete_thread.
11596
11597 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11598
11599         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11600
11601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11602
11603         * symfile.c (find_separate_debug_file): Use canonical path of
11604         sysroot with child_path instead of gdb_sysroot if it is valid.
11605
11606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11607
11608         * symfile.c (find_separate_debug_file): Use child_path to
11609         determine if an object file is under a sysroot.
11610
11611 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11612
11613         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11614         unittests/child-path-selftests.c.
11615         * common/pathstuff.c (child_path): New function.
11616         * common/pathstuff.h (child_path): New prototype.
11617         * unittests/child-path-selftests.c: New file.
11618
11619 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11620
11621         * symfile.c (find_separate_debug_file): Look for separate debug
11622         files in debug directories under the sysroot.
11623
11624 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11625
11626         * symtab.h (struct minimal_symbol data_p): New const method.
11627         (struct minimal_symbol text_p): Likewise.
11628         * symtab.c (output_source_filename): Use file name style
11629         to print file name.
11630         (print_symbol_info): Likewise.
11631         (print_msymbol_info): Use address style to print addresses.
11632         Use function name style to print executable text symbols.
11633         (expand_symtab_containing_pc): Use data_p.
11634         (find_pc_sect_compunit_symtab): Likewise.
11635
11636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11637
11638         * breakpoint.c (describe_other_breakpoints): Use address style
11639         to print addresses.
11640         (say_where): Likewise.
11641
11642 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11643
11644         * ada-typeprint.c (print_func_type): Print function name
11645         style to print function name.
11646         * c-typeprint.c (c_print_type_1): Likewise.
11647
11648 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11649
11650         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11651         for execve.
11652
11653 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11654
11655         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11656         type_stack.
11657
11658 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11659
11660         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11661         TYPE_CODE_REF types.
11662
11663 2019-02-08  Jim Wilson  <jimw@sifive.com>
11664
11665         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11666         (riscv_linux_fregset): New.
11667         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11668
11669 2019-02-07  Tom Tromey  <tom@tromey.com>
11670
11671         * thread.c (thread_cancel_execution_command): Update.
11672         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11673         methods.
11674         (struct thread_fsm_ops): Remove.
11675         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11676         (thread_fsm_should_stop, thread_fsm_return_value)
11677         (thread_fsm_set_finished, thread_fsm_finished_p)
11678         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11679         Don't declare.
11680         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11681         * infrun.c (clear_proceed_status_thread)
11682         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11683         (print_stop_event): Update.
11684         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11685         Add constructor.
11686         (step_command_fsm_ops): Remove.
11687         (new_step_command_fsm): Remove.
11688         (step_1): Update.
11689         (step_command_fsm::should_stop): Rename from
11690         step_command_fsm_should_stop.
11691         (step_command_fsm::clean_up): Rename from
11692         step_command_fsm_clean_up.
11693         (step_command_fsm::do_async_reply_reason): Rename from
11694         step_command_fsm_async_reply_reason.
11695         (struct until_next_fsm): Inherit from thread_fsm.  Add
11696         constructor.
11697         (until_next_fsm_ops): Remove.
11698         (new_until_next_fsm): Remove.
11699         (until_next_fsm::should_stop): Rename from
11700         until_next_fsm_should_stop.
11701         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11702         (until_next_fsm::do_async_reply_reason): Rename from
11703         until_next_fsm_async_reply_reason.
11704         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11705         constructor.  Change type of breakpoint.
11706         (finish_command_fsm_ops): Remove.
11707         (new_finish_command_fsm): Remove.
11708         (finish_command_fsm::should_stop): Rename from
11709         finish_command_fsm_should_stop.
11710         (finish_command_fsm::clean_up): Rename from
11711         finish_command_fsm_clean_up.
11712         (finish_command_fsm::return_value): Rename from
11713         finish_command_fsm_return_value.
11714         (finish_command_fsm::do_async_reply_reason): Rename from
11715         finish_command_fsm_async_reply_reason.
11716         (finish_command): Update.
11717         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11718         Add constructor.
11719         (call_thread_fsm_ops): Remove.
11720         (call_thread_fsm::call_thread_fsm): Rename from
11721         new_call_thread_fsm.
11722         (call_thread_fsm::should_stop): Rename from
11723         call_thread_fsm_should_stop.
11724         (call_thread_fsm::should_notify_stop): Rename from
11725         call_thread_fsm_should_notify_stop.
11726         (run_inferior_call, call_function_by_hand_dummy): Update.
11727         * cli/cli-interp.c (should_print_stop_to_console): Update.
11728         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11729         Add constructor.  Change type of location_breakpoint,
11730         caller_breakpoint.
11731         (until_break_fsm_ops): Remove.
11732         (new_until_break_fsm): Remove.
11733         (until_break_fsm::should_stop): Rename from
11734         until_break_fsm_should_stop.
11735         (until_break_fsm::clean_up): Rename from
11736         until_break_fsm_clean_up.
11737         (until_break_fsm::do_async_reply_reason): Rename from
11738         until_break_fsm_async_reply_reason.
11739         (until_break_command): Update.
11740         * thread-fsm.c: Remove.
11741         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11742
11743 2019-02-07  Tom Tromey  <tom@tromey.com>
11744
11745         * yy-remap.h: Add include guard.
11746         * xtensa-tdep.h: Add include guard.
11747         * xcoffread.h: Rename include guard.
11748         * varobj-iter.h: Add include guard.
11749         * tui/tui.h: Rename include guard.
11750         * tui/tui-winsource.h: Rename include guard.
11751         * tui/tui-wingeneral.h: Rename include guard.
11752         * tui/tui-windata.h: Rename include guard.
11753         * tui/tui-win.h: Rename include guard.
11754         * tui/tui-stack.h: Rename include guard.
11755         * tui/tui-source.h: Rename include guard.
11756         * tui/tui-regs.h: Rename include guard.
11757         * tui/tui-out.h: Rename include guard.
11758         * tui/tui-layout.h: Rename include guard.
11759         * tui/tui-io.h: Rename include guard.
11760         * tui/tui-hooks.h: Rename include guard.
11761         * tui/tui-file.h: Rename include guard.
11762         * tui/tui-disasm.h: Rename include guard.
11763         * tui/tui-data.h: Rename include guard.
11764         * tui/tui-command.h: Rename include guard.
11765         * tic6x-tdep.h: Add include guard.
11766         * target/waitstatus.h: Rename include guard.
11767         * target/wait.h: Rename include guard.
11768         * target/target.h: Rename include guard.
11769         * target/resume.h: Rename include guard.
11770         * target-float.h: Rename include guard.
11771         * stabsread.h: Add include guard.
11772         * rs6000-tdep.h: Add include guard.
11773         * riscv-fbsd-tdep.h: Add include guard.
11774         * regformats/regdef.h: Rename include guard.
11775         * record.h: Rename include guard.
11776         * python/python.h: Rename include guard.
11777         * python/python-internal.h: Rename include guard.
11778         * python/py-stopevent.h: Rename include guard.
11779         * python/py-ref.h: Rename include guard.
11780         * python/py-record.h: Rename include guard.
11781         * python/py-record-full.h: Rename include guard.
11782         * python/py-record-btrace.h: Rename include guard.
11783         * python/py-instruction.h: Rename include guard.
11784         * python/py-events.h: Rename include guard.
11785         * python/py-event.h: Rename include guard.
11786         * procfs.h: Add include guard.
11787         * proc-utils.h: Add include guard.
11788         * p-lang.h: Add include guard.
11789         * or1k-tdep.h: Rename include guard.
11790         * observable.h: Rename include guard.
11791         * nto-tdep.h: Rename include guard.
11792         * nat/x86-linux.h: Rename include guard.
11793         * nat/x86-linux-dregs.h: Rename include guard.
11794         * nat/x86-gcc-cpuid.h: Add include guard.
11795         * nat/x86-dregs.h: Rename include guard.
11796         * nat/x86-cpuid.h: Rename include guard.
11797         * nat/ppc-linux.h: Rename include guard.
11798         * nat/mips-linux-watch.h: Rename include guard.
11799         * nat/linux-waitpid.h: Rename include guard.
11800         * nat/linux-ptrace.h: Rename include guard.
11801         * nat/linux-procfs.h: Rename include guard.
11802         * nat/linux-osdata.h: Rename include guard.
11803         * nat/linux-nat.h: Rename include guard.
11804         * nat/linux-namespaces.h: Rename include guard.
11805         * nat/linux-btrace.h: Rename include guard.
11806         * nat/glibc_thread_db.h: Rename include guard.
11807         * nat/gdb_thread_db.h: Rename include guard.
11808         * nat/gdb_ptrace.h: Rename include guard.
11809         * nat/fork-inferior.h: Rename include guard.
11810         * nat/amd64-linux-siginfo.h: Rename include guard.
11811         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11812         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11813         * nat/aarch64-linux.h: Rename include guard.
11814         * nat/aarch64-linux-hw-point.h: Rename include guard.
11815         * mn10300-tdep.h: Add include guard.
11816         * mips-linux-tdep.h: Add include guard.
11817         * mi/mi-parse.h: Rename include guard.
11818         * mi/mi-out.h: Rename include guard.
11819         * mi/mi-main.h: Rename include guard.
11820         * mi/mi-interp.h: Rename include guard.
11821         * mi/mi-getopt.h: Rename include guard.
11822         * mi/mi-console.h: Rename include guard.
11823         * mi/mi-common.h: Rename include guard.
11824         * mi/mi-cmds.h: Rename include guard.
11825         * mi/mi-cmd-break.h: Rename include guard.
11826         * m2-lang.h: Add include guard.
11827         * location.h: Rename include guard.
11828         * linux-record.h: Rename include guard.
11829         * linux-nat.h: Add include guard.
11830         * linux-fork.h: Add include guard.
11831         * i386-darwin-tdep.h: Rename include guard.
11832         * hppa-linux-offsets.h: Add include guard.
11833         * guile/guile.h: Rename include guard.
11834         * guile/guile-internal.h: Rename include guard.
11835         * gnu-nat.h: Rename include guard.
11836         * gdb-stabs.h: Rename include guard.
11837         * frv-tdep.h: Add include guard.
11838         * f-lang.h: Add include guard.
11839         * event-loop.h: Add include guard.
11840         * darwin-nat.h: Rename include guard.
11841         * cp-abi.h: Rename include guard.
11842         * config/sparc/nm-sol2.h: Rename include guard.
11843         * config/nm-nto.h: Rename include guard.
11844         * config/nm-linux.h: Add include guard.
11845         * config/i386/nm-i386gnu.h: Rename include guard.
11846         * config/djgpp/nl_types.h: Rename include guard.
11847         * config/djgpp/langinfo.h: Rename include guard.
11848         * compile/gcc-cp-plugin.h: Add include guard.
11849         * compile/gcc-c-plugin.h: Add include guard.
11850         * compile/compile.h: Rename include guard.
11851         * compile/compile-object-run.h: Rename include guard.
11852         * compile/compile-object-load.h: Rename include guard.
11853         * compile/compile-internal.h: Rename include guard.
11854         * compile/compile-cplus.h: Rename include guard.
11855         * compile/compile-c.h: Rename include guard.
11856         * common/xml-utils.h: Rename include guard.
11857         * common/x86-xstate.h: Rename include guard.
11858         * common/version.h: Rename include guard.
11859         * common/vec.h: Rename include guard.
11860         * common/tdesc.h: Rename include guard.
11861         * common/selftest.h: Rename include guard.
11862         * common/scoped_restore.h: Rename include guard.
11863         * common/scoped_mmap.h: Rename include guard.
11864         * common/scoped_fd.h: Rename include guard.
11865         * common/safe-iterator.h: Rename include guard.
11866         * common/run-time-clock.h: Rename include guard.
11867         * common/refcounted-object.h: Rename include guard.
11868         * common/queue.h: Rename include guard.
11869         * common/ptid.h: Rename include guard.
11870         * common/print-utils.h: Rename include guard.
11871         * common/preprocessor.h: Rename include guard.
11872         * common/pathstuff.h: Rename include guard.
11873         * common/observable.h: Rename include guard.
11874         * common/netstuff.h: Rename include guard.
11875         * common/job-control.h: Rename include guard.
11876         * common/host-defs.h: Rename include guard.
11877         * common/gdb_wait.h: Rename include guard.
11878         * common/gdb_vecs.h: Rename include guard.
11879         * common/gdb_unlinker.h: Rename include guard.
11880         * common/gdb_unique_ptr.h: Rename include guard.
11881         * common/gdb_tilde_expand.h: Rename include guard.
11882         * common/gdb_sys_time.h: Rename include guard.
11883         * common/gdb_string_view.h: Rename include guard.
11884         * common/gdb_splay_tree.h: Rename include guard.
11885         * common/gdb_setjmp.h: Rename include guard.
11886         * common/gdb_ref_ptr.h: Rename include guard.
11887         * common/gdb_optional.h: Rename include guard.
11888         * common/gdb_locale.h: Rename include guard.
11889         * common/gdb_assert.h: Rename include guard.
11890         * common/filtered-iterator.h: Rename include guard.
11891         * common/filestuff.h: Rename include guard.
11892         * common/fileio.h: Rename include guard.
11893         * common/environ.h: Rename include guard.
11894         * common/common-utils.h: Rename include guard.
11895         * common/common-types.h: Rename include guard.
11896         * common/common-regcache.h: Rename include guard.
11897         * common/common-inferior.h: Rename include guard.
11898         * common/common-gdbthread.h: Rename include guard.
11899         * common/common-exceptions.h: Rename include guard.
11900         * common/common-defs.h: Rename include guard.
11901         * common/common-debug.h: Rename include guard.
11902         * common/cleanups.h: Rename include guard.
11903         * common/buffer.h: Rename include guard.
11904         * common/btrace-common.h: Rename include guard.
11905         * common/break-common.h: Rename include guard.
11906         * cli/cli-utils.h: Rename include guard.
11907         * cli/cli-style.h: Rename include guard.
11908         * cli/cli-setshow.h: Rename include guard.
11909         * cli/cli-script.h: Rename include guard.
11910         * cli/cli-interp.h: Rename include guard.
11911         * cli/cli-decode.h: Rename include guard.
11912         * cli/cli-cmds.h: Rename include guard.
11913         * charset-list.h: Add include guard.
11914         * buildsym-legacy.h: Rename include guard.
11915         * bfin-tdep.h: Add include guard.
11916         * ax.h: Rename include guard.
11917         * arm-linux-tdep.h: Add include guard.
11918         * arm-fbsd-tdep.h: Add include guard.
11919         * arch/xtensa.h: Rename include guard.
11920         * arch/tic6x.h: Add include guard.
11921         * arch/i386.h: Add include guard.
11922         * arch/arm.h: Rename include guard.
11923         * arch/arm-linux.h: Rename include guard.
11924         * arch/arm-get-next-pcs.h: Rename include guard.
11925         * arch/amd64.h: Add include guard.
11926         * arch/aarch64-insn.h: Rename include guard.
11927         * arch-utils.h: Rename include guard.
11928         * annotate.h: Add include guard.
11929         * amd64-darwin-tdep.h: Rename include guard.
11930         * aarch64-linux-tdep.h: Add include guard.
11931         * aarch64-fbsd-tdep.h: Add include guard.
11932         * aarch32-linux-nat.h: Add include guard.
11933
11934 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11935
11936         * macrotab.c (macro_define_internal): New function that
11937         factorizes macro_define_object_internal and macro_define_function
11938         code.
11939         (macro_define_object_internal): Use macro_define_internal.
11940         (macro_define_function): Likewise.
11941
11942 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11943
11944         * macrocmd.c (extract_identifier): Return
11945         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11946         callers.
11947
11948 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11949
11950         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11951
11952 2019-02-05  Tom Tromey  <tom@tromey.com>
11953
11954         * target.c (target_stack::unpush): Move assertion earlier.
11955
11956 2019-01-30  Tom Tromey  <tom@tromey.com>
11957
11958         PR python/23615:
11959         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11960         (gdbpy_parse_and_eval): Likewise.
11961         * python/python-internal.h (gdbpy_allow_threads): New class.
11962
11963 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11964
11965         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11966         (aarch64_fbsd_fpregmap): Move earlier.
11967         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11968         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11969         instead of individual calls to trad_frame_set_reg_addr.
11970         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11971         earlier.
11972         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11973         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11974         instead of individual calls to trad_frame_set_reg_addr.
11975
11976 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11977
11978         * CONTRIBUTE: Replace contribution list with wiki link.
11979
11980 2019-01-25  Tom Tromey  <tom@tromey.com>
11981
11982         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11983
11984 2019-01-25  Tom Tromey  <tom@tromey.com>
11985
11986         * xtensa-linux-nat.c: Fix common/ includes.
11987         * xml-support.h: Fix common/ includes.
11988         * xml-support.c: Fix common/ includes.
11989         * x86-linux-nat.c: Fix common/ includes.
11990         * windows-nat.c: Fix common/ includes.
11991         * varobj.h: Fix common/ includes.
11992         * varobj.c: Fix common/ includes.
11993         * value.c: Fix common/ includes.
11994         * valops.c: Fix common/ includes.
11995         * utils.c: Fix common/ includes.
11996         * unittests/xml-utils-selftests.c: Fix common/ includes.
11997         * unittests/utils-selftests.c: Fix common/ includes.
11998         * unittests/unpack-selftests.c: Fix common/ includes.
11999         * unittests/tracepoint-selftests.c: Fix common/ includes.
12000         * unittests/style-selftests.c: Fix common/ includes.
12001         * unittests/string_view-selftests.c: Fix common/ includes.
12002         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12003         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12004         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12005         * unittests/rsp-low-selftests.c: Fix common/ includes.
12006         * unittests/parse-connection-spec-selftests.c: Fix common/
12007         includes.
12008         * unittests/optional-selftests.c: Fix common/ includes.
12009         * unittests/offset-type-selftests.c: Fix common/ includes.
12010         * unittests/observable-selftests.c: Fix common/ includes.
12011         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12012         * unittests/memrange-selftests.c: Fix common/ includes.
12013         * unittests/memory-map-selftests.c: Fix common/ includes.
12014         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12015         * unittests/function-view-selftests.c: Fix common/ includes.
12016         * unittests/environ-selftests.c: Fix common/ includes.
12017         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12018         * unittests/common-utils-selftests.c: Fix common/ includes.
12019         * unittests/cli-utils-selftests.c: Fix common/ includes.
12020         * unittests/array-view-selftests.c: Fix common/ includes.
12021         * ui-file.c: Fix common/ includes.
12022         * tui/tui-io.c: Fix common/ includes.
12023         * tracepoint.h: Fix common/ includes.
12024         * tracepoint.c: Fix common/ includes.
12025         * tracefile-tfile.c: Fix common/ includes.
12026         * top.h: Fix common/ includes.
12027         * top.c: Fix common/ includes.
12028         * thread.c: Fix common/ includes.
12029         * target/waitstatus.h: Fix common/ includes.
12030         * target/waitstatus.c: Fix common/ includes.
12031         * target.h: Fix common/ includes.
12032         * target.c: Fix common/ includes.
12033         * target-memory.c: Fix common/ includes.
12034         * target-descriptions.c: Fix common/ includes.
12035         * symtab.h: Fix common/ includes.
12036         * symfile.c: Fix common/ includes.
12037         * stap-probe.c: Fix common/ includes.
12038         * spu-linux-nat.c: Fix common/ includes.
12039         * sparc-nat.c: Fix common/ includes.
12040         * source.c: Fix common/ includes.
12041         * solib.c: Fix common/ includes.
12042         * solib-target.c: Fix common/ includes.
12043         * ser-unix.c: Fix common/ includes.
12044         * ser-tcp.c: Fix common/ includes.
12045         * ser-pipe.c: Fix common/ includes.
12046         * ser-base.c: Fix common/ includes.
12047         * selftest-arch.c: Fix common/ includes.
12048         * s12z-tdep.c: Fix common/ includes.
12049         * rust-exp.y: Fix common/ includes.
12050         * rs6000-aix-tdep.c: Fix common/ includes.
12051         * riscv-tdep.c: Fix common/ includes.
12052         * remote.c: Fix common/ includes.
12053         * remote-notif.h: Fix common/ includes.
12054         * remote-fileio.h: Fix common/ includes.
12055         * remote-fileio.c: Fix common/ includes.
12056         * regcache.h: Fix common/ includes.
12057         * regcache.c: Fix common/ includes.
12058         * record-btrace.c: Fix common/ includes.
12059         * python/python.c: Fix common/ includes.
12060         * python/py-type.c: Fix common/ includes.
12061         * python/py-inferior.c: Fix common/ includes.
12062         * progspace.h: Fix common/ includes.
12063         * producer.c: Fix common/ includes.
12064         * procfs.c: Fix common/ includes.
12065         * proc-api.c: Fix common/ includes.
12066         * printcmd.c: Fix common/ includes.
12067         * ppc-linux-nat.c: Fix common/ includes.
12068         * parser-defs.h: Fix common/ includes.
12069         * osdata.c: Fix common/ includes.
12070         * obsd-nat.c: Fix common/ includes.
12071         * nat/x86-linux.c: Fix common/ includes.
12072         * nat/x86-linux-dregs.c: Fix common/ includes.
12073         * nat/x86-dregs.h: Fix common/ includes.
12074         * nat/x86-dregs.c: Fix common/ includes.
12075         * nat/ppc-linux.c: Fix common/ includes.
12076         * nat/mips-linux-watch.h: Fix common/ includes.
12077         * nat/mips-linux-watch.c: Fix common/ includes.
12078         * nat/linux-waitpid.c: Fix common/ includes.
12079         * nat/linux-ptrace.h: Fix common/ includes.
12080         * nat/linux-ptrace.c: Fix common/ includes.
12081         * nat/linux-procfs.c: Fix common/ includes.
12082         * nat/linux-personality.c: Fix common/ includes.
12083         * nat/linux-osdata.c: Fix common/ includes.
12084         * nat/linux-namespaces.c: Fix common/ includes.
12085         * nat/linux-btrace.h: Fix common/ includes.
12086         * nat/linux-btrace.c: Fix common/ includes.
12087         * nat/fork-inferior.c: Fix common/ includes.
12088         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12089         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12090         * nat/aarch64-linux.c: Fix common/ includes.
12091         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12092         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12093         * namespace.h: Fix common/ includes.
12094         * mips-linux-tdep.c: Fix common/ includes.
12095         * minsyms.c: Fix common/ includes.
12096         * mi/mi-parse.h: Fix common/ includes.
12097         * mi/mi-main.c: Fix common/ includes.
12098         * mi/mi-cmd-env.c: Fix common/ includes.
12099         * memrange.h: Fix common/ includes.
12100         * memattr.c: Fix common/ includes.
12101         * maint.h: Fix common/ includes.
12102         * maint.c: Fix common/ includes.
12103         * main.c: Fix common/ includes.
12104         * machoread.c: Fix common/ includes.
12105         * location.c: Fix common/ includes.
12106         * linux-thread-db.c: Fix common/ includes.
12107         * linux-nat.c: Fix common/ includes.
12108         * linux-fork.c: Fix common/ includes.
12109         * inline-frame.c: Fix common/ includes.
12110         * infrun.c: Fix common/ includes.
12111         * inflow.c: Fix common/ includes.
12112         * inferior.h: Fix common/ includes.
12113         * inferior.c: Fix common/ includes.
12114         * infcmd.c: Fix common/ includes.
12115         * inf-ptrace.c: Fix common/ includes.
12116         * inf-child.c: Fix common/ includes.
12117         * ia64-linux-nat.c: Fix common/ includes.
12118         * i387-tdep.c: Fix common/ includes.
12119         * i386-tdep.c: Fix common/ includes.
12120         * i386-linux-tdep.c: Fix common/ includes.
12121         * i386-linux-nat.c: Fix common/ includes.
12122         * i386-go32-tdep.c: Fix common/ includes.
12123         * i386-fbsd-tdep.c: Fix common/ includes.
12124         * i386-fbsd-nat.c: Fix common/ includes.
12125         * guile/scm-type.c: Fix common/ includes.
12126         * guile/guile.c: Fix common/ includes.
12127         * go32-nat.c: Fix common/ includes.
12128         * gnu-nat.c: Fix common/ includes.
12129         * gdbthread.h: Fix common/ includes.
12130         * gdbarch-selftests.c: Fix common/ includes.
12131         * gdb_usleep.c: Fix common/ includes.
12132         * gdb_select.h: Fix common/ includes.
12133         * gdb_bfd.c: Fix common/ includes.
12134         * gcore.c: Fix common/ includes.
12135         * fork-child.c: Fix common/ includes.
12136         * findvar.c: Fix common/ includes.
12137         * fbsd-nat.c: Fix common/ includes.
12138         * event-top.c: Fix common/ includes.
12139         * event-loop.c: Fix common/ includes.
12140         * dwarf2read.c: Fix common/ includes.
12141         * dwarf2loc.c: Fix common/ includes.
12142         * dwarf2-frame.c: Fix common/ includes.
12143         * dwarf-index-cache.c: Fix common/ includes.
12144         * dtrace-probe.c: Fix common/ includes.
12145         * disasm-selftests.c: Fix common/ includes.
12146         * defs.h: Fix common/ includes.
12147         * csky-tdep.c: Fix common/ includes.
12148         * cp-valprint.c: Fix common/ includes.
12149         * cp-support.h: Fix common/ includes.
12150         * cp-support.c: Fix common/ includes.
12151         * corelow.c: Fix common/ includes.
12152         * completer.h: Fix common/ includes.
12153         * completer.c: Fix common/ includes.
12154         * compile/compile.c: Fix common/ includes.
12155         * compile/compile-loc2c.c: Fix common/ includes.
12156         * compile/compile-cplus-types.c: Fix common/ includes.
12157         * compile/compile-cplus-symbols.c: Fix common/ includes.
12158         * command.h: Fix common/ includes.
12159         * cli/cli-dump.c: Fix common/ includes.
12160         * cli/cli-cmds.c: Fix common/ includes.
12161         * charset.c: Fix common/ includes.
12162         * build-id.c: Fix common/ includes.
12163         * btrace.h: Fix common/ includes.
12164         * btrace.c: Fix common/ includes.
12165         * breakpoint.h: Fix common/ includes.
12166         * breakpoint.c: Fix common/ includes.
12167         * ax.h:
12168         (enum agent_op): Fix common/ includes.
12169         * ax-general.c (struct aop_map): Fix common/ includes.
12170         * ax-gdb.c: Fix common/ includes.
12171         * auxv.c: Fix common/ includes.
12172         * auto-load.c: Fix common/ includes.
12173         * arm-tdep.c: Fix common/ includes.
12174         * arch/riscv.c: Fix common/ includes.
12175         * arch/ppc-linux-common.c: Fix common/ includes.
12176         * arch/i386.c: Fix common/ includes.
12177         * arch/arm.c: Fix common/ includes.
12178         * arch/arm-linux.c: Fix common/ includes.
12179         * arch/arm-get-next-pcs.c: Fix common/ includes.
12180         * arch/amd64.c: Fix common/ includes.
12181         * arch/aarch64.c: Fix common/ includes.
12182         * arch/aarch64-insn.c: Fix common/ includes.
12183         * arch-utils.c: Fix common/ includes.
12184         * amd64-windows-tdep.c: Fix common/ includes.
12185         * amd64-tdep.c: Fix common/ includes.
12186         * amd64-sol2-tdep.c: Fix common/ includes.
12187         * amd64-obsd-tdep.c: Fix common/ includes.
12188         * amd64-nbsd-tdep.c: Fix common/ includes.
12189         * amd64-linux-tdep.c: Fix common/ includes.
12190         * amd64-linux-nat.c: Fix common/ includes.
12191         * amd64-fbsd-tdep.c: Fix common/ includes.
12192         * amd64-fbsd-nat.c: Fix common/ includes.
12193         * amd64-dicos-tdep.c: Fix common/ includes.
12194         * amd64-darwin-tdep.c: Fix common/ includes.
12195         * agent.c: Fix common/ includes.
12196         * ada-lang.h: Fix common/ includes.
12197         * ada-lang.c: Fix common/ includes.
12198         * aarch64-tdep.c: Fix common/ includes.
12199
12200 2019-01-25  Tom Tromey  <tom@tromey.com>
12201
12202         * common/create-version.sh: Use common/version.h.
12203
12204 2019-01-24  Pedro Alves  <palves@redhat.com>
12205
12206         * infrun.c (signal_stop, signal_print, signal_program)
12207         (signal_catch, signal_pass): Now arrays instead of pointers.
12208         (update_signals_program_target, do_target_resume)
12209         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12210         * linux-nat.c (linux_nat_target::pass_signals)
12211         (linux_nat_target::create_inferior, linux_nat_target::attach):
12212         Adjust.
12213         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12214         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12215         * procfs.c (procfs_target::pass_signals): Adjust.
12216         * record-full.c (record_full_target::resume): Adjust.
12217         * remote.c (remote_target::pass_signals)
12218         (remote_target::program_signals): Adjust.
12219         * target-debug.h (target_debug_print_signals): Now takes a
12220         gdb::array_view as parameter.  Adjust.
12221         * target.h (target_ops) <pass_signals, program_signals>: Replace
12222         pointer and length parameters with gdb::array_view.
12223         (target_pass_signals, target_program_signals): Likewise.
12224         * target-delegates.c: Regenerate.
12225
12226 2019-01-24  Pedro Alves  <palves@redhat.com>
12227
12228         * common/forward-scope-exit.h
12229         (forward_scope_exit::forward_scope_exit): Pass arguments to
12230         m_bind_function directly, instead of creating a std::bind and
12231         copying that.
12232
12233 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12234
12235         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12236         for static members.
12237         (pass_in_v_vfp_candidate): Likewise.
12238
12239 2019-01-23  Tom Tromey  <tom@tromey.com>
12240             Pedro Alves  <palves@redhat.com>
12241
12242         * regcache.c (class regcache_invalidator): Remove.
12243         (regcache::raw_write): Use make_scope_exit.
12244
12245 2019-01-23  Tom Tromey  <tom@tromey.com>
12246
12247         * ui-out.h (class ui_out_emit_type): Update comment.
12248
12249 2019-01-23  Tom Tromey  <tom@tromey.com>
12250
12251         * infrun.c (fetch_inferior_event): Update comment.
12252
12253 2019-01-23  Tom Tromey  <tom@tromey.com>
12254             Pedro Alves  <palves@redhat.com>
12255
12256         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12257         parameter.
12258         (fetch_inferior_event): Use SCOPE_EXIT.
12259
12260
12261 2019-01-23  Tom Tromey  <tom@tromey.com>
12262             Pedro Alves  <palves@redhat.com>
12263
12264         * infrun.c (disable_thread_events): Delete.
12265         (stop_all_threads): Use SCOPE_EXIT.
12266
12267 2019-01-23  Tom Tromey  <tom@tromey.com>
12268             Pedro Alves  <palves@redhat.com>
12269
12270         * symfile.c: Include forward-scope-exit.h.
12271         (clear_symtab_users_cleanup): Replace forward declaration with
12272         a FORWARD_SCOPE_EXIT.
12273         (syms_from_objfile_1): Use the forward_scope_exit and
12274         gdb::optional instead of cleanup_function.
12275         (reread_symbols): Use the forward_scope_exit instead of
12276         cleanup_function.
12277         (clear_symtab_users_cleanup): Remove function.
12278
12279 2019-01-23  Tom Tromey  <tom@tromey.com>
12280             Pedro Alves  <palves@redhat.com>
12281
12282         * linux-nat.c: Include scope-exit.h.
12283         (cleanup_target_stop): Remove.
12284         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12285         SCOPE_EXIT.
12286
12287 2019-01-23  Tom Tromey  <tom@tromey.com>
12288             Pedro Alves  <palves@redhat.com>
12289
12290         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12291         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12292
12293 2019-01-23  Tom Tromey  <tom@tromey.com>
12294             Andrew Burgess  <andrew.burgess@embecosm.com>
12295             Pedro Alves  <palves@redhat.com>
12296
12297         * infrun.c (fetch_inferior_event): Use scope_exit.
12298         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12299         * top.c (execute_command): Use scope_exit.
12300         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12301         * utils.c (do_bpstat_clear_actions_cleanup)
12302         (make_bpstat_clear_actions_cleanup): Remove.
12303
12304 2019-01-23  Tom Tromey  <tom@tromey.com>
12305             Pedro Alves  <palves@redhat.com>
12306
12307         * infrun.c: Include "common/scope-exit.h"
12308         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12309         (wait_for_inferior): Use SCOPE_EXIT.
12310         (fetch_inferior_event): Use scope_exit.
12311
12312 2019-01-23  Tom Tromey  <tom@tromey.com>
12313             Pedro Alves  <palves@redhat.com>
12314
12315         * breakpoint.c (create_breakpoint): Remove cleanup.
12316
12317 2019-01-23  Tom Tromey  <tom@tromey.com>
12318             Andrew Burgess  <andrew.burgess@embecosm.com>
12319             Pedro Alves  <palves@redhat.com>
12320
12321 2019-01-23  Pedro Alves  <palves@redhat.com>
12322
12323         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12324
12325 2019-01-23  Pedro Alves  <palves@redhat.com>
12326             Andrew Burgess  <andrew.burgess@embecosm.com>
12327
12328         * gdbthread.h: Include "common/forward-scope-exit.h".
12329         (scoped_finish_thread_state): Redefine custom class in terms of
12330         forward_scope_exit.
12331
12332 2019-01-23  Pedro Alves  <palves@redhat.com>
12333             Andrew Burgess  <andrew.burgess@embecosm.com>
12334
12335         * common/forward-scope-exit.h: New file.
12336
12337 2019-01-23  Pedro Alves  <palves@redhat.com>
12338             Andrew Burgess  <andrew.burgess@embecosm.com>
12339             Tom Tromey  <tom@tromey.com>
12340
12341         * common/scope-exit.h: New file.
12342
12343 2019-01-23  Pedro Alves  <palves@redhat.com>
12344
12345         * common/preprocessor.h (ESC): Rename to ...
12346         (ESC_PARENS): ... this.
12347         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12348         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12349
12350 2019-01-23  Tom Tromey  <tom@tromey.com>
12351
12352         * language.h (class scoped_switch_to_sym_language_if_auto):
12353         Initialize m_lang in both cases.
12354
12355 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12356
12357         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12358         with XCNEW.
12359
12360 2019-01-22  Tom Tromey  <tom@tromey.com>
12361
12362         * corelow.c: Do not include sys/file.h.
12363
12364 2019-01-22  Tom Tromey  <tom@tromey.com>
12365
12366         * tui/tui-wingeneral.h: Include gdb_curses.h.
12367
12368 2019-01-22  Tom Tromey  <tom@tromey.com>
12369
12370         * source-cache.h (class source_cache) <get_source_lines,
12371         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12372
12373 2019-01-22  Tom Tromey  <tom@tromey.com>
12374
12375         * remote-fileio.h (struct remote_target): Declare.
12376
12377 2019-01-22  Tom Tromey  <tom@tromey.com>
12378
12379         * python/py-arch.c: Do not include py-ref.h.
12380         * python/py-bpevent.c: Do not include py-ref.h.
12381         * python/py-cmd.c: Do not include py-ref.h.
12382         * python/py-continueevent.c: Do not include py-ref.h.
12383         * python/py-event.h: Do not include py-ref.h.
12384         * python/py-evtregistry.c: Do not include py-ref.h.
12385         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12386         * python/py-frame.c: Do not include py-ref.h.
12387         * python/py-framefilter.c: Do not include py-ref.h.
12388         * python/py-function.c: Do not include py-ref.h.
12389         * python/py-infevents.c: Do not include py-ref.h.
12390         * python/py-linetable.c: Do not include py-ref.h.
12391         * python/py-objfile.c: Do not include py-ref.h.
12392         * python/py-param.c: Do not include py-ref.h.
12393         * python/py-prettyprint.c: Do not include py-ref.h.
12394         * python/py-progspace.c: Do not include py-ref.h.
12395         * python/py-symbol.c: Do not include py-ref.h.
12396         * python/py-symtab.c: Do not include py-ref.h.
12397         * python/py-type.c: Do not include py-ref.h.
12398         * python/py-unwind.c: Do not include py-ref.h.
12399         * python/py-utils.c: Do not include py-ref.h.
12400         * python/py-value.c: Do not include py-ref.h.
12401         * python/py-varobj.c: Do not include py-ref.h.
12402         * python/py-xmethods.c: Do not include py-ref.h.
12403         * python/python.c: Do not include py-ref.h.
12404         * varobj.c: Do not include py-ref.h.
12405
12406 2019-01-22  Tom Tromey  <tom@tromey.com>
12407
12408         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12409         keyword for bcache.
12410
12411 2019-01-22  Tom Tromey  <tom@tromey.com>
12412
12413         * compile/compile-cplus-types.c: Remove a comment by #include.
12414
12415 2019-01-22  Tom Tromey  <tom@tromey.com>
12416
12417         * compile/gcc-c-plugin.h: Include compile-internal.h.
12418
12419 2019-01-22  Tom Tromey  <tom@tromey.com>
12420
12421         * stabsread.c (EXTERN): Do not define.
12422         (symnum, next_symbol_text_func, processing_gcc_compilation)
12423         (within_function, global_sym_chain, global_stabs)
12424         (previous_stab_code, this_object_header_files)
12425         (n_this_object_header_files)
12426         (n_allocated_this_object_header_files): Define.
12427         * stabsread.h (EXTERN): Never define.  Use "extern".
12428
12429 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12430
12431         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12432         history_value.
12433
12434 2019-01-21  Tom Tromey  <tom@tromey.com>
12435
12436         * ui-out.c: Fix includes.
12437         * tui/tui-source.c: Fix includes.
12438         * target.c: Fix includes.
12439         * remote.c: Fix includes.
12440         * regcache.c: Fix includes.
12441         * python/py-block.c: Fix includes.
12442         * printcmd.c: Fix includes.
12443         * or1k-tdep.c: Fix includes.
12444         * mi/mi-main.c: Fix includes.
12445         * m32r-tdep.c: Fix includes.
12446         * csky-tdep.c: Fix includes.
12447         * compile/compile-cplus-types.c: Fix includes.
12448         * cli/cli-interp.c: Fix includes.
12449
12450 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12451
12452         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12453         for padding.
12454
12455 2019-01-16  Tom Tromey  <tom@tromey.com>
12456
12457         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12458         earlier.
12459         (struct objfile) <msymbols_range>: Move from top level.
12460         <msymbols>: New method.
12461         (class objfile_msymbols): Remove.
12462         * symtab.c (default_collect_symbol_completion_matches_break_on):
12463         Update.
12464         * symmisc.c (dump_msymbols): Update.
12465         * stabsread.c (scan_file_globals): Update.
12466         * objc-lang.c (info_selectors_command, info_classes_command)
12467         (find_methods): Update.
12468         * minsyms.c (find_solib_trampoline_target): Update.
12469         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12470         * coffread.c (coff_symfile_read): Update.
12471         * ada-lang.c (ada_lookup_simple_minsym)
12472         (ada_collect_symbol_completion_matches): Update.
12473
12474 2019-01-16  Tom Tromey  <tom@tromey.com>
12475
12476         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12477         type.  Remove no-argument constructor.
12478         <iterator::operator++>: Simplify.
12479         <begin>: Update.
12480         <end>: Use minimal_symbol_count.
12481
12482 2019-01-16  Tom Tromey  <tom@tromey.com>
12483
12484         * objfiles.h (struct objfile) <psymtabs>: New method.
12485         (class objfile_psymtabs): Remove.
12486         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12487         typedef.
12488         <range>: New method.
12489         (require_partial_symbols): Change return type.
12490         * psymtab.c (require_partial_symbols)
12491         (psym_expand_symtabs_matching): Update.
12492         * mdebugread.c (parse_partial_symbols): Update.
12493         * dbxread.c (dbx_end_psymtab): Update.
12494
12495 2019-01-15  Tom Tromey  <tom@tromey.com>
12496
12497         * symtab.c (lookup_objfile_from_block)
12498         (lookup_symbol_in_objfile_symtabs)
12499         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12500         (find_line_symtab, info_sources_command)
12501         (default_collect_symbol_completion_matches_break_on)
12502         (make_source_files_completion_list): Update.
12503         * symmisc.c (print_objfile_statistics, dump_objfile)
12504         (maintenance_print_symbols, maintenance_info_symtabs)
12505         (maintenance_check_symtabs, maintenance_info_line_tables):
12506         Update.
12507         * source.c (select_source_symtab)
12508         (forget_cached_source_info_for_objfile): Update.
12509         * objfiles.h (class objfile_compunits): Remove.
12510         (struct objfile) <compunits_range>: New typedef.
12511         (compunits): New method.
12512         * objfiles.c (objfile_relocate1): Update.
12513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12514         * maint.c (count_symtabs_and_blocks): Update.
12515         * linespec.c (iterate_over_all_matching_symtabs): Update.
12516         * cp-support.c (add_symbol_overload_list_qualified): Update.
12517         * coffread.c (coff_symtab_read): Update.
12518         * ada-lang.c (add_nonlocal_symbols)
12519         (ada_collect_symbol_completion_matches)
12520         (ada_add_global_exceptions): Update.
12521
12522 2019-01-15  Tom Tromey  <tom@tromey.com>
12523
12524         * progspace.h (program_space) <objfiles_safe_range>: New
12525         typedef.
12526         <objfiles_safe>: New method.
12527         * objfiles.h (class all_objfiles_safe): Remove.
12528         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12529         * jit.c (jit_inferior_exit_hook): Update.
12530
12531 2019-01-17  Tom Tromey  <tom@tromey.com>
12532
12533         * progspace.h (program_space) <objfiles_range>: New typedef.
12534         <objfiles>: New method.
12535         <objfiles_head>: Rename from objfiles.
12536         (object_files): Update.
12537         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12538         * guile/scm-pretty-print.c
12539         (ppscm_find_pretty_printer_from_objfiles): Update.
12540         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12541         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12542         Update.
12543         * python/py-progspace.c (pspy_get_objfiles): Update.
12544         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12545         Update.
12546         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12547         (objfpy_lookup_objfile_by_build_id): Update.
12548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12549         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12550         Update.
12551         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12552         (expand_symtab_containing_pc, lookup_objfile_from_block)
12553         (lookup_static_symbol, basic_lookup_transparent_type)
12554         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12555         (find_line_symtab, info_sources_command)
12556         (default_collect_symbol_completion_matches_break_on)
12557         (make_source_files_completion_list, find_main_name): Update.
12558         * symmisc.c (print_symbol_bcache_statistics)
12559         (print_objfile_statistics, maintenance_print_symbols)
12560         (maintenance_print_msymbols, maintenance_print_objfiles)
12561         (maintenance_info_symtabs, maintenance_check_symtabs)
12562         (maintenance_expand_symtabs, maintenance_info_line_tables):
12563         Update.
12564         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12565         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12566         (map_overlay_command, unmap_overlay_command)
12567         (simple_overlay_update, expand_symtabs_matching)
12568         (map_symbol_filenames): Update.
12569         * symfile-debug.c (set_debug_symfile): Update.
12570         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12571         Update.
12572         * source.c (select_source_symtab, forget_cached_source_info):
12573         Update.
12574         * solib.c (solib_read_symbols): Update.
12575         * solib-spu.c (append_ocl_sos): Update.
12576         * psymtab.c (maintenance_print_psymbols)
12577         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12578         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12579         * printcmd.c (info_symbol_command): Update.
12580         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12581         Update.
12582         * objfiles.h (class all_objfiles): Remove.
12583         * objfiles.c (have_partial_symbols, have_full_symbols)
12584         (have_minimal_symbols, qsort_cmp, update_section_map)
12585         (shared_objfile_contains_address_p)
12586         (default_iterate_over_objfiles_in_search_order): Update.
12587         * objc-lang.c (info_selectors_command, info_classes_command)
12588         (find_methods): Update.
12589         * minsyms.c (find_solib_trampoline_target): Update.
12590         * maint.c (maintenance_info_sections)
12591         (maintenance_translate_address, count_symtabs_and_blocks):
12592         Update.
12593         * main.c (captured_main_1): Update.
12594         * linux-thread-db.c (try_thread_db_load_from_pdir)
12595         (has_libpthread): Update.
12596         * linespec.c (iterate_over_all_matching_symtabs)
12597         (search_minsyms_for_name): Update.
12598         * jit.c (jit_find_objf_with_entry_addr): Update.
12599         * hppa-tdep.c (find_unwind_entry)
12600         (hppa_lookup_stub_minimal_symbol): Update.
12601         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12602         Update.
12603         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12604         (elf_gnu_ifunc_resolve_by_got): Update.
12605         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12606         * dwarf-index-write.c (save_gdb_index_command): Update.
12607         * cp-support.c (add_symbol_overload_list_qualified): Update.
12608         * breakpoint.c (create_overlay_event_breakpoint)
12609         (create_longjmp_master_breakpoint)
12610         (create_std_terminate_master_breakpoint)
12611         (create_exception_master_breakpoint): Update.
12612         * blockframe.c (find_pc_partial_function): Update.
12613         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12614         (ada_collect_symbol_completion_matches)
12615         (ada_add_global_exceptions): Update.
12616
12617 2019-01-17  Tom Tromey  <tom@tromey.com>
12618
12619         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12620         declare VEC.
12621         (solib_target_parse_libraries): Change return type.
12622         (library_list_start_segment, library_list_start_section)
12623         (library_list_end_library, library_list_start_library); Update.
12624         (solib_target_free_library_list): Remove.
12625         (solib_target_parse_libraries): Remove cleanup.  Change return
12626         type.
12627         (solib_target_current_sos): Update.
12628
12629 2019-01-17  Tom Tromey  <tromey@bapiya>
12630
12631         * valprint.c: Replace "the the" with "the".
12632         * symtab.c: Replace "the the" with "the".
12633         * solib.c: Replace "the the" with "the".
12634         * solib-dsbt.c: Replace "the the" with "the".
12635         * linespec.c: Replace "the the" with "the".
12636         * dwarf2loc.h: Replace "the the" with "the".
12637         * amd64-windows-tdep.c: Replace "the the" with "the".
12638         * aarch64-tdep.c: Replace "the the" with "the".
12639
12640 2019-01-16  Keith Seitz  <keiths@redhat.com>
12641
12642         PR gdb/23773
12643         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12644         <builder>: Rename to ..
12645         <m_builder>: ... this and make private.
12646         (dwarf2_cu::get_builder): New method.  Change all users of
12647         `builder' to use this method.
12648         (dwarf2_start_symtab): Move to ...
12649         (dwarf2_cu::start_symtab): ... here.  Update all callers
12650         (setup_type_unit_groups): Move to ...
12651         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12652         callers.
12653         (dwarf2_cu::reset_builder): New method.
12654         (process_full_compunit, process_full_type_unit): Use
12655         dwarf2_cu::reset_builder.
12656         (follow_die_offset): Record the ancestor CU if it is different
12657         from the followed DIE's CU.
12658         (follow_die_sig_1): Likewise.
12659
12660 2019-01-15  Tom Tromey  <tom@tromey.com>
12661
12662         * remote.c (class remote_state) <buf>: Now a char_vector.
12663         <buf_size>: Remove.
12664         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12665         parameter.
12666         (remote_target::getpkt_or_notif_sane_1)
12667         (remote_target::getpkt_sane)
12668         (remote_target::getpkt_or_notif_sane): Likewise.
12669         (class remote_target) <putpkt>: New overload.
12670         (remote_target::read_frame): Change type of "buf_p".  Remove
12671         sizeof_p parameter.
12672         (packet_ok): New overload.
12673         (packet_check_result): New overload.
12674         Update all uses.
12675
12676 2019-01-14  Tom Tromey  <tom@tromey.com>
12677
12678         * remote-notif.c (handle_notification, remote_notif_ack)
12679         (remote_notif_parse): Make "buf" const.
12680         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12681         const.
12682         (remote_notif_parse, remote_notif_ack, handle_notification):
12683         Likewise.
12684         * remote.c (remote_notif_stop_parse): Make "buf" const.
12685         (remote_target::remote_parse_stop_reply): Make "buf" const.
12686         (remote_notif_stop_ack): Make "buf" const.
12687
12688 2019-01-14  Tom Tromey  <tom@tromey.com>
12689
12690         * remote.c (remote_console_output): Make parameter const.
12691
12692 2019-01-14  Tom Tromey  <tom@tromey.com>
12693
12694         * target-debug.h (target_debug_print_signals): Constify.
12695         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12696         * procfs.c (procfs_target::pass_signals): Update.
12697         * linux-nat.c (linux_nat_target::pass_signals): Update.
12698         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12699         * target-delegates.c: Rebuild.
12700         * remote.c (remote_target::program_signals): Update.
12701         (remote_target::pass_signals): Update.
12702         * target.c (target_pass_signals): Constify argument.
12703         (target_program_signals): Likewise.
12704         * target.h (struct target_ops) <pass_signals, program_signals>:
12705         Constify argument.
12706         (target_pass_signals, target_program_signals): Constify argument.
12707
12708 2019-01-14  Tom Tromey  <tom@tromey.com>
12709
12710         PR tui/28819:
12711         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12712
12713 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12714
12715         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12716         field.
12717         * rs6000-tdep.c: Include reggroups.h.
12718         (IS_V_ALIAS_PSEUDOREG): Define.
12719         (rs6000_register_name): Return names for the "vX" aliases.
12720         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12721         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12722         aliases.  Call default_register_reggroup_p for all other
12723         pseudo-registers.
12724         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12725         New functions.
12726         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12727         Handle "vX" aliases.
12728         (v_alias_pseudo_register_collect): New function.
12729         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12730         (rs6000_gdbarch_init): Initialize "vX" aliases as
12731         pseudo-registers.  Restore registration of
12732         rs6000_pseudo_register_reggroup_p with
12733         set_tdesc_pseudo_register_reggroup_p.
12734
12735 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12736
12737         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12738         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12739         set_gdbarch_num_pseudo_regs.
12740
12741 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12742
12743         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12744         Remove arg prefixname, add do_set and do_show.
12745         Add member functions set_list and show_list.
12746         * cli/cli-style.c (class cli_style_option): Update accordingly.
12747         (style_set_list): Move to file scope.
12748         (style_show_list): Likewise.
12749         (set_style): Call help_list.
12750         (show_style): Call cmd_show_list.
12751         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12752         Update to use the new macro.
12753
12754 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12755
12756         * ada-lang.c (_initialize_ada_language): Expand the help text
12757         for the "catch exception" command.
12758
12759 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12760
12761         * symtab.c (matching_obj_sections): Initialize obj,
12762         declare it closer to its usage.
12763
12764 2019-01-10  Tom Tromey  <tom@tromey.com>
12765
12766         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12767         (basic_inf_threads_range): Remove.
12768         (inf_threads_range, inf_non_exited_threads_range)
12769         (safe_inf_threads_range): Use next_adapter.
12770
12771 2019-01-10  Keith Seitz  <keiths@redhat.com>
12772
12773         PR gdb/23712
12774         PR symtab/23010
12775         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12776         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12777
12778 2019-01-10  Keith Seitz  <keiths@redhat.com>
12779
12780         PR gdb/23712
12781         PR symtab/23010
12782         * dictionary.c (pending_to_vector): Remove.
12783         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12784         Remove _1 suffix, replacing functions of the same name.  Update
12785         all callers.
12786         (dict_create_hashed, dict_create_hashed_expandable)
12787         (dict_create_linear, dict_create_linear_expandable, dict_free)
12788         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12789         Make functions static.
12790
12791 2019-01-10  Keith Seitz  <keiths@redhat.com>
12792
12793         PR gdb/23712
12794         PR symtab/23010
12795         * dictionary.h (struct dictionary): Replace declaration with
12796         multidictionary.
12797         (dict_create_hashed, dict_create_hashed_expandable)
12798         (dict_create_linear, dict_create_linear_expandable)
12799         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12800         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12801         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12802         taking multidictionary argument.
12803         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12804         * block.h (struct block) <dict>: Change to multidictionary
12805         and rename `multidict'.
12806         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12807         symmisc.c: Update all dictionary references to multidictionary.
12808
12809 2019-01-10  Keith Seitz  <keiths@redhat.com>
12810
12811         PR gdb/23712
12812         PR symtab/23010
12813         * dictionary.c: Include unordered_map.
12814         (pending_to_vector): New function.
12815         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12816         Rewrite the non-"_1" functions to take vector instead
12817         of linked list.
12818         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12819         "new" _1 versions of the same name.
12820         (multidictionary): Define.
12821         (std::hash<enum language): New definition.
12822         (collate_pending_symbols_by_language, mdict_create_hashed)
12823         (mdict_create_hashed_expandable, mdict_create_linear)
12824         (mdict_create_linear_expandable, mdict_free)
12825         (find_language_dictionary, create_new_language_dictionary)
12826         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12827         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12828         (mdict_size, mdict_empty): New functions.
12829         * dictionary.h (mdict_iterator): Define.
12830
12831 2019-01-10  Pedro Alves  <palves@redhat.com>
12832
12833         * breakpoint.c (read_uploaded_action)
12834         (create_tracepoint_from_upload): Adjust to use
12835         gdb::unique_xmalloc_ptr.
12836         * ctf.c (ctf_write_uploaded_tp):
12837         (SET_ARRAY_FIELD): Use emplace_back.
12838         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12839         * tracefile-tfile.c (tfile_write_uploaded_tp):
12840         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12841         gdb::unique_xmalloc_ptr.
12842         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12843         at_string, cond_string, cmd_strings>: Replace char pointers
12844         with gdb::unique_xmalloc_ptr.
12845
12846 2019-01-10  Pedro Alves  <palves@redhat.com>
12847
12848         * solib-target.c (library_list_start_library): Don't xstrdup name.
12849
12850 2019-01-10  Pedro Alves  <palves@redhat.com>
12851
12852         * mdebugread.c (parse_partial_symbols): Use
12853         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12854
12855 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12856
12857         * linux-fork.c (scoped_switch_fork_info)
12858         <~scoped_switch_fork_info>: Fix incorrect variable name.
12859
12860 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12861
12862         * linux-fork.c (scoped_switch_fork_info)
12863         <scoped_switch_fork_info>: Make explicit.
12864         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12865
12866 2019-01-10  Tom Tromey  <tom@tromey.com>
12867
12868         * objfiles.h (objfile::reset_psymtabs): Update.
12869         * objfiles.c (objfile::objfile): Update.
12870         * psymtab.h (psymtab_storage::obstack): Update.
12871         (psymtab_storage::m_obstack): Use gdb::optional.
12872         (class psymtab_storage): Update comment.  Remove objfile
12873         parameter.
12874         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12875
12876 2019-01-10  Tom Tromey  <tom@tromey.com>
12877
12878         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12879         <free_psymtabs>: Now private.
12880         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12881         (allocate_psymtab): Use new method.
12882
12883 2019-01-10  Tom Tromey  <tom@tromey.com>
12884
12885         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12886         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12887         * mdebugread.c (parse_partial_symbols): Use
12888         allocate_dependencies.
12889         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12890         allocate_dependencies.
12891         (process_psymtab_comp_unit_reader)
12892         (build_type_psymtab_dependencies): Likewise.
12893         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12894
12895 2019-01-10  Tom Tromey  <tom@tromey.com>
12896
12897         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12898         PSYMBOL_SET_LANGUAGE.
12899         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12900
12901 2019-01-10  Tom Tromey  <tom@tromey.com>
12902
12903         * psymtab.h (psymtab_storage::obstack): New method.
12904         <m_obstack>: Rename from obstack; now private.
12905         * psymtab.c (psymtab_storage): Update.
12906         * dwarf2read.c (create_addrmap_from_index)
12907         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12908         Update.
12909
12910 2019-01-10  Tom Tromey  <tom@tromey.com>
12911
12912         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12913         * objfiles.h (objfile::reset_psymtabs): New method.
12914
12915 2019-01-10  Tom Tromey  <tom@tromey.com>
12916
12917         * symmisc.c (print_symbol_bcache_statistics): Update.
12918         (print_objfile_statistics): Update.
12919         * symfile.c (reread_symbols): Update.
12920         * psymtab.h (class psymtab_storage): New.
12921         * psymtab.c (psymtab_storage): New constructor.
12922         (~psymtab_storage): New destructor.
12923         (require_partial_symbols): Update.
12924         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12925         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12926         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12927         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12928         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12929         (start_psymtab_common, end_psymtab_common)
12930         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12931         (allocate_psymtab): Update.
12932         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12933         Update.
12934         (dump_psymtab_addrmap, maintenance_print_psymbols)
12935         (maintenance_check_psymtabs): Update.
12936         (class objfile_psymtabs): Move to objfiles.h.
12937         * psympriv.h (discard_psymtab): Now inline.
12938         (psymtab_discarder::psymtab_discarder): Update.
12939         (psymtab_discarder::~psymtab_discarder): Update.
12940         (ALL_OBJFILE_PSYMTABS): Rewrite.
12941         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12942         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12943         Remove fields.
12944         <partial_symtabs>: New field.
12945         (class objfile_psymtabs): Move from psymtab.h.  Update.
12946         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12947         psymbol_cache.
12948         (objfile::~objfile): Don't destroy psymbol_cache.
12949         * mdebugread.c (parse_partial_symbols): Update.
12950         * dwarf2read.c (create_addrmap_from_index)
12951         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12952         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12953         (add_partial_subprogram, dwarf2_ranges_read): Update.
12954         * dwarf-index-write.c (write_address_map)
12955         (write_one_signatured_type, recursively_write_psymbols)
12956         (class debug_names, class debug_names, write_psymtabs_to_index):
12957         Update.
12958
12959 2019-01-10  Tom Tromey  <tom@tromey.com>
12960
12961         * symtab.h (SYMBOL_SET_NAMES): Update.
12962         (symbol_set_names): Update.
12963         (MSYMBOL_SET_NAMES): Update.
12964         * symtab.c (symbol_set_names): Change argument to be an
12965         objfile_per_bfd_storage.
12966         * psymtab.c (add_psymbol_to_bcache): Update.
12967         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12968
12969 2019-01-10  Tom Tromey  <tom@tromey.com>
12970
12971         * symtab.c (create_demangled_names_hash): Change argument to be an
12972         objfile_per_bfd_storage.
12973         (symbol_set_names): Update.
12974
12975 2019-01-10  Tom Tromey  <tom@tromey.com>
12976
12977         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12978         init_psymbol_list.
12979         * psymtab.c (init_psymbol_list): Do nothing if already called.
12980         * psympriv.h (init_psymbol_list): Add comment.
12981         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12982         init_psymbol_list.
12983         * dbxread.c (dbx_symfile_read): Unconditionally call
12984         init_psymbol_list.
12985
12986 2019-01-10  Tom Tromey  <tom@tromey.com>
12987
12988         * xcoffread.c (scan_xcoff_symtab): Update.
12989         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12990         "where".
12991         * mdebugread.c (parse_partial_symbols)
12992         (handle_psymbol_enumerators): Update.
12993         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12994         * dbxread.c (read_dbx_symtab): Update.
12995         * psympriv.h (psymbol_placement): New enum.
12996         (add_psymbol_to_list): Update.
12997
12998 2019-01-10  Tom Tromey  <tom@tromey.com>
12999
13000         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13001         static_psymbols parameters.
13002         (scan_xcoff_symtab): Update.
13003         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13004         static_psymbols parameters.
13005         * psympriv.h (start_psymtab_common): Update.
13006         * mdebugread.c (parse_partial_symbols): Update.
13007         * dwarf2read.c (create_partial_symtab): Update.
13008         * dbxread.c (read_dbx_symtab): Update.
13009         (start_psymtab): Remove global_psymbols and static_psymbols
13010         parameters.
13011
13012 2019-01-10  Tom Tromey  <tom@tromey.com>
13013
13014         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13015         * psymtab.c (allocate_psymtab): Add comment.
13016         * psympriv.h (allocate_psymtab): Add comment.
13017         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13018         initializations.
13019         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13020
13021 2019-01-10  Tom Tromey  <tom@tromey.com>
13022
13023         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13024         Don't declare.
13025         * mipsread.c: Include mdebugread.h.
13026         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13027         Declare.
13028         * elfread.c: Include mdebugread.h.
13029
13030 2019-01-09  Tom Tromey  <tom@tromey.com>
13031
13032         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13033         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13034         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13035         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13036         (psym_lookup_symbol, psym_find_last_source_symtab)
13037         (psym_forget_cached_source_info, psym_print_stats)
13038         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13039         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13040         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13041         (psym_find_compunit_symtab_by_address)
13042         (maintenance_print_psymbols, maintenance_info_psymtabs)
13043         (maintenance_check_psymtabs): Use ranged for.
13044         * psymtab.h (class objfile_psymtabs): New.
13045         (require_partial_symbols): Return objfile_psymtabs.
13046         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13047
13048 2019-01-09  Tom Tromey  <tom@tromey.com>
13049
13050         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13051         (find_pc_mapped_section, list_overlays_command)
13052         (map_overlay_command, unmap_overlay_command)
13053         (simple_overlay_update): Use all_objfiles.
13054         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13055         * printcmd.c (info_symbol_command): Use all_objfiles.
13056         * objfiles.h (ALL_OBJSECTIONS): Remove.
13057         * maint.c (maintenance_translate_address): Use all_objfiles.
13058         * gcore.c (gcore_create_callback): Use all_objfiles.
13059         (objfile_find_memory_regions): Likewise.
13060
13061 2019-01-09  Tom Tromey  <tom@tromey.com>
13062
13063         * symtab.c (find_line_symtab, info_sources_command)
13064         (make_source_files_completion_list): Use objfile_compunits.
13065         * source.c (select_source_symtab): Use objfile_compunits.
13066         * objfiles.h (struct objfile): Update comment.
13067         (ALL_OBJFILES): Remove.
13068         (ALL_FILETABS): Remove.
13069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13070         objfile_compunits.
13071
13072 2019-01-09  Tom Tromey  <tom@tromey.com>
13073
13074         * symmisc.c (print_objfile_statistics, dump_objfile)
13075         (maintenance_print_symbols): Use compunit_filetabs.
13076         * source.c (forget_cached_source_info_for_objfile): Use
13077         compunit_filetabs.
13078         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13079         (ALL_FILETABS): Use compunit_filetabs.
13080         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13081         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13082
13083 2019-01-09  Tom Tromey  <tom@tromey.com>
13084
13085         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13086         (compunit_filetabs): New.
13087         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13088         compunit_filetabs.
13089         (info_sources_command, make_source_files_completion_list): Remove
13090         declaration.
13091         * symmisc.c (print_objfile_statistics, dump_objfile)
13092         (maintenance_print_symbols): Remove declaration.
13093         (maintenance_info_symtabs): Use compunit_filetabs.
13094         (maintenance_info_line_tables): Likewise.
13095         * source.c (select_source_symtab): Change local variable name.
13096         (forget_cached_source_info_for_objfile): Remove declaration.
13097         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13098         * objfiles.c (objfile_relocate1): Remove declaration.
13099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13100         declaration.
13101         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13102         * coffread.c (coff_symtab_read): Remove declaration.
13103         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13104         compunit_filetabs.
13105
13106 2019-01-09  Tom Tromey  <tom@tromey.com>
13107
13108         * symtab.c (lookup_objfile_from_block)
13109         (find_pc_sect_compunit_symtab, search_symbols)
13110         (default_collect_symbol_completion_matches_break_on): Use
13111         objfile_compunits.
13112         * objfiles.h (ALL_COMPUNITS): Remove.
13113         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13114         * cp-support.c (add_symbol_overload_list_qualified): Use
13115         objfile_compunits.
13116         * ada-lang.c (ada_collect_symbol_completion_matches)
13117         (ada_add_global_exceptions): Use objfile_compunits.
13118
13119 2019-01-09  Tom Tromey  <tom@tromey.com>
13120
13121         * source.c (select_source_symtab)
13122         (forget_cached_source_info_for_objfile): Remove declaration.
13123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13124         declaration.
13125         * maint.c (count_symtabs_and_blocks): Remove declaration.
13126         * cp-support.c (add_symbol_overload_list_qualified): Remove
13127         declaration.
13128         * coffread.c (coff_symtab_read): Remove declaration.
13129         * symtab.c (lookup_symbol_in_objfile_symtabs)
13130         (basic_lookup_transparent_type_1): Use objfile_compunits.
13131         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13132         (info_sources_command, search_symbols)
13133         (default_collect_symbol_completion_matches_break_on)
13134         (make_source_files_completion_list): Remove declaration.
13135         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13136         (ada_collect_symbol_completion_matches)
13137         (ada_add_global_exceptions): Remove declaration.
13138         * linespec.c (iterate_over_all_matching_symtabs): Use
13139         objfile_compunits.
13140         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13141         (class objfile_compunits): New.
13142         (ALL_COMPUNITS): Use objfile_compunits.
13143         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13144         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13145         objfile_compunits.
13146         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13147
13148 2019-01-09  Tom Tromey  <tom@tromey.com>
13149
13150         * symtab.c (search_symbols)
13151         (default_collect_symbol_completion_matches_break_on): Use
13152         objfile_msymbols.
13153         * ada-lang.c (ada_lookup_simple_minsym)
13154         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13155         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13156         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13157         objfile_msymbols.
13158         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13159         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13160         * objc-lang.c (find_methods): Use objfile_msymbols.
13161         (info_selectors_command, info_classes_command): Likewise.
13162         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13163         * objfiles.h (class objfile_msymbols): New.
13164         (ALL_OBJFILE_MSYMBOLS): Remove.
13165         (ALL_MSYMBOLS): Remove.
13166
13167 2019-01-09  Tom Tromey  <tom@tromey.com>
13168
13169         * common/next-iterator.h (next_adapter): Add Iterator template
13170         parameter.
13171         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13172         (class all_objfiles_safe): New.
13173         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13174         * objfiles.c (put_objfile_before): Update comment.
13175         (add_separate_debug_objfile): Likewise.
13176         (free_all_objfiles): Use all_objfiles_safe.
13177         (objfile_purge_solibs): Likewise.
13178
13179 2019-01-09  Tom Tromey  <tom@tromey.com>
13180
13181         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13182         (expand_symtab_containing_pc, lookup_static_symbol)
13183         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13184         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13185         all_objfiles.
13186         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13187         * breakpoint.c (create_overlay_event_breakpoint)
13188         (create_longjmp_master_breakpoint)
13189         (create_std_terminate_master_breakpoint)
13190         (create_exception_master_breakpoint): Use all_objfiles.
13191         * linux-thread-db.c (try_thread_db_load_from_pdir)
13192         (has_libpthread): Use all_objfiles.
13193         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13194         * linespec.c (iterate_over_all_matching_symtabs)
13195         (search_minsyms_for_name): Use all_objfiles.
13196         * maint.c (maintenance_info_sections): Use all_objfiles.
13197         * main.c (captured_main_1): Use all_objfiles.
13198         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13199         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13200         * guile/scm-pretty-print.c
13201         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13202         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13203         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13204         (maintenance_print_msymbols): Use all_objfiles.
13205         * source.c (select_source_symtab): Use all_objfiles.
13206         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13207         * symfile.c (remove_symbol_file_command)
13208         (expand_symtabs_matching, map_symbol_filenames): Use
13209         all_objfiles.
13210         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13211         all_objfiles.
13212         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13213         * objc-lang.c (find_methods): Use all_objfiles.
13214         * objfiles.c (have_partial_symbols, have_full_symbols)
13215         (have_minimal_symbols, qsort_cmp)
13216         (default_iterate_over_objfiles_in_search_order): Use
13217         all_objfiles.
13218         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13219         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13220         (maintenance_check_psymtabs): Use all_objfiles.
13221         (ALL_PSYMTABS): Remove.
13222         * compile/compile-object-run.c (do_module_cleanup): Use
13223         all_objfiles.
13224         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13225         * cp-support.c (add_symbol_overload_list_qualified): Use
13226         all_objfiles.
13227         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13228         Use all_objfiles.
13229         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13230         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13231         all_objfiles.
13232         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13233         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13234         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13235         Uses all_objfiles.
13236         * solib.c (solib_read_symbols): Use all_objfiles
13237
13238 2019-01-09  Tom Tromey  <tom@tromey.com>
13239
13240         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13241         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13242         all_objfiles.
13243         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13244         * symmisc.c (print_symbol_bcache_statistics)
13245         (print_objfile_statistics, maintenance_print_objfiles)
13246         (maintenance_info_symtabs, maintenance_check_symtabs)
13247         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13248         all_objfiles.
13249         * source.c (forget_cached_source_info): Use all_objfiles.
13250         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13251         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13252         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13253         * objfiles.c (update_section_map): Use all_objfiles.
13254         (shared_objfile_contains_address_p): Likewise.
13255         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13256         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13257
13258 2019-01-09  Tom Tromey  <tom@tromey.com>
13259
13260         * common/next-iterator.h: New file.
13261         * objfiles.h (class all_objfiles): New.
13262         (struct objfile_iterator): New.
13263
13264 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13265
13266         * NEWS: Move the description of the changed "frame", "select-frame",
13267          and "info frame" commands to the Changed commands section.
13268
13269 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13270
13271         * gdbtypes.c (check_stub_method_group): Remove handling of old
13272         mangling schemes.
13273         * linespec.c (find_methods): Likewise.
13274         * stabsread.c (read_member_functions): Likewise.
13275         * valops.c (search_struct_method): Likewise.
13276         (value_struct_elt_for_reference): Likewise.
13277         * NEWS: Mention this change.
13278
13279 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13280
13281         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13282         print_source_lines.
13283         * source.c (print_source_lines_base): Update line number check.
13284         (print_source_lines): New function.
13285         (source_lines_range::source_lines_range): New function.
13286         * source.h (class source_lines_range): New class.
13287         (print_source_lines): New declaration.
13288
13289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13290
13291         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13292
13293 2019-01-08  Tom Tromey  <tom@tromey.com>
13294             Simon Marchi  <simon.marchi@ericsson.com>
13295
13296         PR gdb/24060
13297         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13298         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13299         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13300         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13301         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13302         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13303
13304 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13305
13306         * source.c (select_source_symtab): Move header comment to
13307         declaration in source.h.
13308         (forget_cached_source_info_for_objfile): Likewise.
13309         (forget_cached_source_info): Likewise.
13310         (identify_source_line): Likewise.
13311         * source.h (identify_source_line): Move declaration from symtab.h
13312         and add comment from source.c
13313         (print_source_lines): Likewise.
13314         (forget_cached_source_info_for_objfile): Likewise.
13315         (forget_cached_source_info): Likewise.
13316         (select_source_symtab): Likewise.
13317         (enum print_source_lines_flag): Move definition from symtab.h.
13318         * symtab.h (identify_source_line): Move declaration to source.h.
13319         (print_source_lines): Likewise.
13320         (forget_cached_source_info_for_objfile): Likewise.
13321         (forget_cached_source_info): Likewise.
13322         (select_source_symtab): Likewise.
13323         (enum print_source_lines_flag): Move definition to source.h.
13324         * tui/tui-hooks.c: Add 'source.h' include.
13325
13326 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13327
13328         * source.c (print_source_lines_base): Handle requests to print
13329         reverse line number sequences, and guard against empty lines
13330         string.
13331
13332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13333
13334         * source.c (print_source_lines_base): Fix skip of '\r' if next
13335         character is '\n'.
13336
13337 2019-01-06  Tom Tromey  <tom@tromey.com>
13338
13339         * c-exp.y (struct c_parse_state) <macro_original_text,
13340         expansion_obstack>: New member.
13341         (macro_original_text, expansion_obstack): Remove globals.
13342         (scan_macro_expansion, scanning_macro_expansion)
13343         (finished_macro_expansion): Update.
13344         (scan_macro_cleanup): Remove.
13345         (yylex, c_parse): Update.
13346
13347 2019-01-06  Tom Tromey  <tom@tromey.com>
13348
13349         * c-exp.y (struct c_parse_state) <strings>: New member.
13350         (operator_stoken): Update.
13351
13352 2019-01-06  Tom Tromey  <tom@tromey.com>
13353
13354         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13355         (union type_stack_elt) <typelist_val>: Now a pointer to
13356         std::vector.
13357         (type_stack_cleanup): Don't declare.
13358         (push_typelist): Update.
13359         * parse.c (pop_typelist): Return a std::vector.
13360         (push_typelist): Take a std::vector.
13361         (follow_types): Update.  Do not free args.
13362         (type_stack_cleanup): Remove.
13363         * c-exp.y (struct c_parse_state): New.
13364         (cpstate): New global.
13365         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13366         (nonempty_typelist): Update.
13367         (func_mod): Create a new vector.
13368         (c_parse): Create a c_parse_state.
13369         (check_parameter_typelist): Do not delete params.
13370         (function_method): Update.  Do not delete type_list.
13371
13372 2019-01-06  Tom Tromey  <tom@tromey.com>
13373
13374         PR gdb/28155:
13375         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13376         check_typedef.
13377         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13378         (print_return_value): Likewise.
13379
13380 2019-01-05  Tom Tromey  <tom@tromey.com>
13381
13382         * contrib/cleanup_check.py: Remove.
13383         * contrib/gcc-with-excheck: Remove.
13384         * contrib/exsummary.py: Remove.
13385         * contrib/excheck.py: Remove.
13386
13387 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13388
13389         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13390         NULL. Initialize tpprev to NULL instead of assigning it
13391         to NULL on the next statement.
13392         * windows-nat.c (windows_delete_thread): Remove check for
13393         main_thread_id before printing thread exit notifications.
13394         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13395         Remove thread ID check against main_thread_id.
13396         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13397         windows_delete_thread.
13398         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13399
13400 2019-01-04  Tom Tromey  <tom@tromey.com>
13401
13402         * compile/compile.c (_initialize_compile): Use upper case for
13403         metasyntactic variables.
13404         * symmisc.c (_initialize_symmisc): Use upper case for
13405         metasyntactic variables.
13406         * psymtab.c (_initialize_psymtab): Use upper case for
13407         metasyntactic variables.
13408         * demangle.c (demangle_command): Use upper case for metasyntactic
13409         variables.
13410         (_initialize_demangler): Likewise.
13411         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13412         variables.
13413
13414 2019-01-03  Tom Tromey  <tom@tromey.com>
13415
13416         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13417
13418 2019-01-03  Tom Tromey  <tom@tromey.com>
13419
13420         * python/py-symtab.c (salpy_str): Update.
13421         (struct salpy_sal_object) <symtab>: Now a PyObject.
13422         (salpy_dealloc): Update.
13423         (del_objfile_sal): Use gdbpy_ref.
13424
13425 2019-01-03  Tom Tromey  <tom@tromey.com>
13426
13427         * python/py-type.c (convert_field): Use new_reference.  Return
13428         gdbpy_ref.
13429         (make_fielditem): Return gdbpy_ref.
13430         (typy_fields): Update.
13431         (typy_getitem): Update.
13432         (field_name): Return gdbpy_ref.  Use new_reference.
13433         (typy_iterator_iternext): Update.
13434
13435 2019-01-03  Tom Tromey  <tom@tromey.com>
13436
13437         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13438
13439 2019-01-03  Tom Tromey  <tom@tromey.com>
13440
13441         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13442         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13443         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13444         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13445         (pspy_set_type_printers): Likewise.
13446         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13447         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13448         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13449         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13450         (objfpy_set_type_printers): Likewise.
13451
13452 2019-01-03  Tom Tromey  <tom@tromey.com>
13453
13454         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13455         (gdbpy_print_stack): Use gdbpy_err_fetch.
13456         * python/python-internal.h (class gdbpy_err_fetch): New class.
13457         (class gdbpy_enter) <m_error_type, m_error_value,
13458         m_error_traceback>: Remove.
13459         <m_error>: New member.
13460         (gdbpy_exception_to_string): Don't declare.
13461         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13462         * python/py-value.c (convert_value_from_python): Use
13463         gdbpy_err_fetch.
13464         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13465         gdbpy_exception_to_string.
13466         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13467         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13468         gdbpy_err_fetch.
13469
13470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13471
13472         * linux-nat.c (delete_lwp_cleanup): Delete.
13473         (struct lwp_deleter): New struct.
13474         (lwp_info_up): New typedef.
13475         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13476         lwp_info_up.
13477
13478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13479
13480         * linux-fork.c (class scoped_switch_fork_info): New class.
13481         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13482
13483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13484
13485         * valops.c (find_overload_match): Remove use of null_cleanup, and
13486         calls to do_cleanups.
13487
13488 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13489
13490         * compile/compile-cplus-types.c
13491         (compile_cplus_instance::decl_name): Handle changes to
13492         cp_func_name.
13493         * cp-support.c (cp_func_name): Update header comment, update
13494         return type.
13495         * cp-support.h (cp_func_name): Update return type in declaration.
13496         * valops.c (find_overload_match): Move temp_func local to top
13497         level of function and change its type.  Use temp_func to hold and
13498         delete temporary string obtained from cp_func_name.
13499
13500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13501
13502         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13503         gdb::char_vector, remove cleanup, and update uses of `msg`.
13504
13505 2019-01-03  Jim Wilson  <jimw@sifive.com>
13506
13507         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13508
13509 2019-01-02  Tom Tromey  <tom@tromey.com>
13510
13511         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13512         (tdesc_parse_xml): Remove cleanups.
13513         * target-descriptions.h (make_cleanup_free_target_description):
13514         Don't declare.
13515         (target_desc_deleter): New struct.
13516         (target_desc_up): New typedef.
13517         * target-descriptions.c (target_desc_deleter::operator()): Rename
13518         from free_target_description.
13519         (make_cleanup_free_target_description): Remove.
13520
13521 2019-01-02  Tom Tromey  <tom@tromey.com>
13522
13523         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13524         constructor, destructor.
13525         (linespec_parser): Remove typedef.
13526         (~linespec_parser): Rename from linespec_parser_delete.
13527         (linespec_lex_to_end, linespec_complete_label)
13528         (linespec_complete): Update.
13529         (decode_line_full): Remove cleanups.
13530         (decode_line_1): Update.
13531
13532 2019-01-02  Tom Tromey  <tom@tromey.com>
13533
13534         * python/python-internal.h (inferior_to_inferior_object): Change
13535         return type.
13536         * python/py-exitedevent.c (create_exited_event_object): Update.
13537         * python/py-inferior.c (inferior_to_inferior_object): Return
13538         gdbpy_ref.
13539         (python_new_inferior, python_inferior_deleted)
13540         (thread_to_thread_object, delete_thread_object)
13541         (build_inferior_list, gdbpy_selected_inferior): Update.
13542         * python/py-infthread.c (create_thread_object): Update.  Also fail
13543         if inferior_to_inferior_object fails.
13544
13545 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13546
13547         * inferior.h (class inferior) <displaced_step_state>: New field.
13548         * infrun.h (struct displaced_step_state): Move here from
13549         infrun.c.  Initialize fields, add constructor.
13550         <inf>: Remove field.
13551         <reset>: New method.
13552         * infrun.c (struct displaced_step_inferior_state): Move to
13553         infrun.h.
13554         (displaced_step_inferior_states): Remove.
13555         (get_displaced_stepping_state): Adust.
13556         (displaced_step_in_progress_any_inferior): Adjust.
13557         (displaced_step_in_progress_thread): Adjust.
13558         (displaced_step_in_progress): Adjust.
13559         (add_displaced_stepping_state): Remove.
13560         (get_displaced_step_closure_by_addr): Adjust.
13561         (remove_displaced_stepping_state): Remove.
13562         (infrun_inferior_exit): Call displaced_step_state.reset.
13563         (use_displaced_stepping): Don't check for NULL.
13564         (displaced_step_prepare_throw): Call
13565         get_displaced_stepping_state.
13566         (displaced_step_fixup): Don't check for NULL.
13567         (prepare_for_detach): Don't check for NULL.
13568
13569 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13570
13571         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13572          in case of call that did not complete.
13573
13574 2019-01-02  Andrey Utkin  <autkin@undo.io>
13575
13576         * symfile.c (find_separate_debug_file): Fix search of debug files for
13577         remote debuggee.
13578
13579 2019-01-02  Tom Tromey  <tom@tromey.com>
13580
13581         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13582         indentation.
13583         * python/py-frame.c (frapy_older): Remove cast.
13584         (frapy_newer): Likewise.
13585         * python/py-breakpoint.c (local_setattro): Remove cast.
13586         * python/py-arch.c (archpy_name): Remove local variable.
13587         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13588
13589 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13590
13591         * unittests/basic_string_view/element_access/char/empty.cc:
13592         Fix year range in copyright header.
13593
13594 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13595
13596         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13597         Delete.
13598         <operator==>: Update with for removed field.
13599         <hash>: Likewise.
13600         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13601         <isa_features>: ...this.
13602         <abi_features>: New field.
13603         (riscv_isa_flen): Update comment.
13604         (riscv_abi_xlen): New declaration.
13605         (riscv_abi_flen): New declaration.
13606         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13607         isa_features.
13608         (riscv_abi_xlen): New function.
13609         (riscv_isa_flen): Update to get answer from isa_features.
13610         (riscv_abi_flen): New function.
13611         (riscv_has_fp_abi): Update to get answer from abi_features.
13612         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13613         xlen and flen.
13614         (riscv_call_info) <xlen, flen>: Update comment.
13615         (riscv_call_arg_struct): Remove invalid assertions
13616         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13617         is removed.
13618         (riscv_gdbarch_init): Gather isa features and abi features
13619         separately, ensure both match on the gdbarch when reusing an old
13620         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13621         a target with 64-bit float hardware.
13622
13623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13624
13625         * source.c (search_command_helper): Stop reverse search
13626         when line 1 has been searched.
13627
13628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13629
13630         * record-full.c (record_full_base_target::close): Rewrite
13631         record_full_core_buf_list free logic.
13632
13633 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13634
13635         * break-catch-syscall.c (print_one_catch_syscall): xfree
13636         the last text.
13637
13638 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13639
13640         * top.c (print_gdb_version): Update Copyright year in version
13641         message.
13642
13643 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13644
13645         Update copyright year range in all GDB files.
13646
13647 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13648
13649         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13650
13651 For older changes see ChangeLog-2018.
13652 \f
13653 Local Variables:
13654 mode: change-log
13655 left-margin: 8
13656 fill-column: 74
13657 version-control: never
13658 coding: utf-8
13659 End:
13660