gdb/ChangeLog

   1 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
   4         * arm-linux-tdep.c: Likewise.
   5         * arm-nbsd-nat.c: Likewise.
   6         * arm-tdep.h: Declare arm_apcs_32.
   7         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
   8
   9 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  10
  11         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
  12         * dwarf2read.h: Declare dwarf_always_disassemble.
  13
  14 2019-09-19  Tom de Vries  <tdevries@suse.de>
  15
  16         PR gdb/25009
  17         * source-cache.c (source_cache::ensure): Catch exception thrown during
  18         construction of the highlighter.
  19
  20 2019-09-18  Alan Modra  <amodra@gmail.com>
  21
  22         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
  23         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
  24         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
  25         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
  26         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
  27         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
  28         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
  29         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
  30         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
  31         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
  32         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
  33         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
  34         * solib-spu.c, * solib-svr4.c, * solib-target.c,
  35         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
  36         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
  37         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
  38         * mi/mi-interp.c: Update throughout for bfd section macro and
  39         function changes.
  40         * gcore (gcore_create_callback): Use bfd_set_section_lma.
  41         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
  42
  43 2019-09-18  Tom Tromey  <tom@tromey.com>
  44
  45         * NEWS: Add entry.
  46         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
  47         call rl_initialize.
  48         (tui_enable): Do not call rl_initialize.
  49
  50 2019-09-18  Christian Groessler  <chris@groessler.org>
  51
  52         * alpha-linux-nat.c: Include gdbarch.h.
  53
  54 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
  55
  56         * ui-file.c: Include cli/cli-style.h.
  57         (term_cli_styling): Remove cli_styling declaration.
  58
  59 2019-09-18  Alan Modra  <amodra@gmail.com>
  60
  61         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
  62         to bfd_asymbol_section.
  63
  64 2019-09-18  Alan Modra  <amodra@gmail.com>
  65
  66         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
  67         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
  68         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
  69
  70 2019-09-18  Alan Modra  <amodra@gmail.com>
  71
  72         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
  73         * spu-linux-nat.c (spu_bfd_open): Likewise.
  74
  75 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
  78         to bool to match definition in dwarf2read.c.
  79
  80 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
  81
  82         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
  83         (print_signatures): Likewise.
  84         (trust_pad_over_xvs): Likewise.
  85         * arch/aarch64-insn.c (aarch64_debug): Likewise.
  86         * arch/aarch64-insn.h (aarch64_debug): Likewise.
  87         * arm-linux-nat.c (arm_apcs_32): Likewise.
  88         * arm-linux-tdep.c (arm_apcs_32): Likewise.
  89         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
  90         * arm-tdep.c (arm_debug): Likewise.
  91         (arm_apcs_32): Likewise.
  92         * auto-load.c (debug_auto_load): Likewise.
  93         (auto_load_gdb_scripts): Likewise.
  94         (global_auto_load): Likewise.
  95         (auto_load_local_gdbinit): Likewise.
  96         (auto_load_local_gdbinit_loaded): Likewise.
  97         * auto-load.h (global_auto_load): Likewise.
  98         (auto_load_local_gdbinit): Likewise.
  99         (auto_load_local_gdbinit_loaded): Likewise.
 100         * breakpoint.c (disconnected_dprintf): Likewise.
 101         (breakpoint_proceeded): Likewise.
 102         (automatic_hardware_breakpoints): Likewise.
 103         (always_inserted_mode): Likewise.
 104         (target_exact_watchpoints): Likewise.
 105         (_initialize_breakpoint): Update.
 106         * breakpoint.h (target_exact_watchpoints): Change to bool.
 107         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 108         * cli/cli-cmds.c (trace_commands): Likewise.
 109         * cli/cli-cmds.h (trace_commands): Likewise.
 110         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 111         to bool*.
 112         * cli/cli-logging.c (logging_overwrite): Change to bool.
 113         (logging_redirect): Likewise.
 114         (debug_redirect): Likewise.
 115         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 116         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 117         to bool.
 118         <boolean_option_def>: Update.
 119         (struct flag_option_def): Change default type of Context to bool
 120         from int.
 121         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 122         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 123         (get_setshow_command_value_string): Likewise.
 124         * cli/cli-style.c (cli_styling): Change to bool.
 125         (source_styling): Likewise.
 126         * cli/cli-style.h (source_styling): Likewise.
 127         (cli_styling): Likewise.
 128         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 129         to bool.
 130         * command.h (var_types): Update comment.
 131         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 132         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 133         bool.
 134         (debug_compile_cplus_scopes): Likewise.
 135         * compile/compile-internal.h (compile_debug): Likewise.
 136         * compile/compile.c (compile_debug): Likewise.
 137         (struct compile_options) <raw>: Likewise.
 138         * cp-support.c (catch_demangler_crashes): Likewise.
 139         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 140         (usr_cmd_cris_dwarf2_cfi): Likewise.
 141         * csky-tdep.c (csky_debug): Likewise.
 142         * darwin-nat.c (enable_mach_exceptions): Likewise.
 143         * dcache.c (dcache_enabled_p): Likewise.
 144         * defs.h (info_verbose): Likewise.
 145         * demangle.c (demangle): Likewise.
 146         (asm_demangle): Likewise.
 147         * dwarf-index-cache.c (debug_index_cache): Likewise.
 148         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 149         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 150         * dwarf2read.c (check_physname): Likewise.
 151         (use_deprecated_index_sections): Likewise.
 152         (dwarf_always_disassemble): Likewise.
 153         * eval.c (overload_resolution): Likewise.
 154         * event-top.c (set_editing_cmd_var): Likewise.
 155         (exec_done_display_p): Likewise.
 156         * event-top.h (set_editing_cmd_var): Likewise.
 157         (exec_done_display_p): Likewise.
 158         * exec.c (write_files): Likewise.
 159         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 160         (debug_fbsd_nat): Likewise.
 161         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 162         Likewise.
 163         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 164         <backtrace_past_entry> Likewise.
 165         * gdb-demangle.h (demangle): Likewise.
 166         (asm_demangle): Likewise.
 167         * gdb_bfd.c (bfd_sharing): Likewise.
 168         * gdbcore.h (write_files): Likewise.
 169         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 170         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 171         * gdbthread.h (print_thread_events): Likewise.
 172         * gdbtypes.c (opaque_type_resolution): Likewise.
 173         (strict_type_checking): Likewise.
 174         * gnu-nat.c (gnu_debug_flag): Likewise.
 175         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 176         * guile/scm-param.c (pascm_variable): Add boolval.
 177         (add_setshow_generic): Update.
 178         (pascm_param_value): Update.
 179         (pascm_set_param_value_x): Update.
 180         * hppa-tdep.c (hppa_debug): Change to bool..
 181         * infcall.c (may_call_functions_p): Likewise.
 182         (coerce_float_to_double_p): Likewise.
 183         (unwind_on_signal_p): Likewise.
 184         (unwind_on_terminating_exception_p): Likewise.
 185         * infcmd.c (startup_with_shell): Likewise.
 186         * inferior.c (print_inferior_events): Likewise.
 187         * inferior.h (startup_with_shell): Likewise.
 188         (print_inferior_events): Likewise.
 189         * infrun.c (step_stop_if_no_debug): Likewise.
 190         (detach_fork): Likewise.
 191         (debug_displaced): Likewise.
 192         (disable_randomization): Likewise.
 193         (non_stop): Likewise.
 194         (non_stop_1): Likewise.
 195         (observer_mode): Likewise.
 196         (observer_mode_1): Likewise.
 197         (set_observer_mode): Update.
 198         (sched_multi): Change to bool.
 199         * infrun.h (debug_displaced): Likewise.
 200         (sched_multi): Likewise.
 201         (step_stop_if_no_debug): Likewise.
 202         (non_stop): Likewise.
 203         (disable_randomization): Likewise.
 204         * linux-tdep.c (use_coredump_filter): Likewise.
 205         (dump_excluded_mappings): Likewise.
 206         * linux-thread-db.c (auto_load_thread_db): Likewise.
 207         (check_thread_db_on_load): Likewise.
 208         * main.c (captured_main_1): Update.
 209         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 210         xx2_opt, boolean_opt>: Change to bool.
 211         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 212         * maint.c (maintenance_profile_p): Likewise.
 213         (per_command_time): Likewise.
 214         (per_command_space): Likewise.
 215         (per_command_symtab): Likewise.
 216         * memattr.c (inaccessible_by_default): Likewise.
 217         * mi/mi-main.c (mi_async): Likewise.
 218         (mi_async_1): Likewise.
 219         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 220         * nat/fork-inferior.h (startup_with_shell): Likewise.
 221         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 222         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 223         * nios2-tdep.c (nios2_debug): Likewise.
 224         * or1k-tdep.c (or1k_debug): Likewise.
 225         * parse.c (parser_debug): Likewise.
 226         * parser-defs.h (parser_debug): Likewise.
 227         * printcmd.c (print_symbol_filename): Likewise.
 228         * proc-api.c (procfs_trace): Likewise.
 229         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 230         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 231         (set_parameter_value): Update.
 232         (add_setshow_generic): Update.
 233         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 234         to bool*.
 235         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 236         int*.
 237         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 238         * record-btrace.c (record_btrace_target::store_registers): Update.
 239         * record-full.c (record_full_memory_query): Change to bool.
 240         (record_full_stop_at_limit): Likewise.
 241         * record-full.h (record_full_memory_query): Likewise.
 242         * remote-notif.c (notif_debug): Likewise.
 243         * remote-notif.h (notif_debug): Likewise.
 244         * remote.c (use_range_stepping): Likewise.
 245         (interrupt_on_connect): Likewise.
 246         (remote_break): Likewise.
 247         * ser-tcp.c (tcp_auto_retry): Likewise.
 248         * ser-unix.c (serial_hwflow): Likewise.
 249         * skip.c (debug_skip): Likewise.
 250         * solib-aix.c (solib_aix_debug): Likewise.
 251         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 252         (spu_auto_flush_cache_p): Likewise.
 253         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 254         Likewise.
 255         (struct info_print_options) <quiet>: Likewise.
 256         * symfile-debug.c (debug_symfile): Likewise.
 257         * symfile.c (auto_solib_add): Likewise.
 258         (separate_debug_file_debug): Likewise.
 259         * symfile.h (auto_solib_add): Likewise.
 260         (separate_debug_file_debug): Likewise.
 261         * symtab.c (basenames_may_differ): Likewise.
 262         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 263         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 264         (struct info_types_options) <quiet>: Likewise.
 265         * symtab.h (demangle): Likewise.
 266         (basenames_may_differ): Likewise.
 267         * target-dcache.c (stack_cache_enabled_1): Likewise.
 268         (code_cache_enabled_1): Likewise.
 269         * target.c (trust_readonly): Likewise.
 270         (may_write_registers): Likewise.
 271         (may_write_memory): Likewise.
 272         (may_insert_breakpoints): Likewise.
 273         (may_insert_tracepoints): Likewise.
 274         (may_insert_fast_tracepoints): Likewise.
 275         (may_stop): Likewise.
 276         (auto_connect_native_target): Likewise.
 277         (target_stop_and_wait): Update.
 278         (target_async_permitted): Change to bool.
 279         (target_async_permitted_1): Likewise.
 280         (may_write_registers_1): Likewise.
 281         (may_write_memory_1): Likewise.
 282         (may_insert_breakpoints_1): Likewise.
 283         (may_insert_tracepoints_1): Likewise.
 284         (may_insert_fast_tracepoints_1): Likewise.
 285         (may_stop_1): Likewise.
 286         * target.h (target_async_permitted): Likewise.
 287         (may_write_registers): Likewise.
 288         (may_write_memory): Likewise.
 289         (may_insert_breakpoints): Likewise.
 290         (may_insert_tracepoints): Likewise.
 291         (may_insert_fast_tracepoints): Likewise.
 292         (may_stop): Likewise.
 293         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 294         (make_thread_apply_all_options_def_group): Change argument from int*
 295         to bool*.
 296         (thread_apply_all_command): Update.
 297         (print_thread_events): Change to bool.
 298         * top.c (confirm): Likewise.
 299         (command_editing_p): Likewise.
 300         (history_expansion_p): Likewise.
 301         (write_history_p): Likewise.
 302         (info_verbose): Likewise.
 303         * top.h (confirm): Likewise.
 304         (history_expansion_p): Likewise.
 305         * tracepoint.c (disconnected_tracing): Likewise.
 306         (circular_trace_buffer): Likewise.
 307         * typeprint.c (print_methods): Likewise.
 308         (print_typedefs): Likewise.
 309         * utils.c (debug_timestamp): Likewise.
 310         (sevenbit_strings): Likewise.
 311         (pagination_enabled): Likewise.
 312         * utils.h (sevenbit_strings): Likewise.
 313         (pagination_enabled): Likewise.
 314         * valops.c (overload_resolution): Likewise.
 315         * valprint.h (struct value_print_options) <prettyformat_arrays,
 316         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 317         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 318         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 319         Likewise.
 320         * windows-nat.c (new_console): Likewise.
 321         (cygwin_exceptions): Likewise.
 322         (new_group): Likewise.
 323         (debug_exec): Likewise.
 324         (debug_events): Likewise.
 325         (debug_memory): Likewise.
 326         (debug_exceptions): Likewise.
 327         (useshell): Likewise.
 328         * windows-tdep.c (maint_display_all_tib): Likewise.
 329         * xml-support.c (debug_xml): Likewise.
 330
 331 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 332
 333         * source.c (prepare_path_for_appending): New function.
 334         (openp): Make use of new function.
 335         (find_and_open_source): Search for the compilation directory and
 336         source file as a relative path beneath the directory search path.
 337
 338 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 339
 340         * source-cache.c (source_cache::get_line_charpos): Catch
 341         exceptions and return false, this matches the behaviour documented
 342         in the header file.
 343
 344 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 345
 346         * ada-tasks.c (info_task): Remove quoting of the task's name.
 347
 348 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 349
 350         * symfile.c (auto_solib_add): Replace comment with a reference
 351         to the header file.
 352
 353 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 354
 355         * NEWS: Mention that gdb can now be compiled with Python 3
 356         on Windows.
 357
 358 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * maint.c (maint_print_section_data::maint_print_section_data):
 361         Force use of 'float log10 (float)' by casting the argument to
 362         float.
 363
 364 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * maint.c: Add 'cmath' include.
 367         (struct maint_print_section_data): New structure.
 368         (print_section_index): New function.
 369         (print_bfd_section_info): Add header comment, small whitespace
 370         cleanup, and update to call new print_section_index function.
 371         (print_objfile_section_info): Likewise.
 372         (maint_obj_section_from_bfd_section): New function.
 373         (print_bfd_section_info_maybe_relocated): New function.
 374         (maintenance_info_sections): Add header comment, always use
 375         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 376
 377 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 380         inner scope, add check that the objfile has psymtabs before
 381         checking psymtabs_addrmap.
 382         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 383
 384 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 385
 386         * NEWS: Announce that Ada task names are now shown at more places,
 387         and between quotes (except in info task output).
 388         * gdb/ada-tasks.c (task_to_str): New function.
 389         (display_current_task_id): Call task_to_str.
 390         (task_command_1): Likewise.
 391         (print_ada_task_info): In non-mi mode, Properly align headers and data
 392         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 393
 394 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 395
 396         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 397         prstatus.pr_lwp.pr_info instead of making it up.
 398
 399 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 400
 401         * auto-load.c (auto_load_expand_dir_vars): Update.
 402         * defs.h (gdb_datadir): Change to std::string.
 403         (python_libdir): Likewise.
 404         (relocate_gdb_directory): Change return type to std::string.
 405         * guile/guile.c (gdbscm_data_directory): Update.
 406         (initialize_scheme_side): Update.
 407         * jit.c (jit_reader_dir): Change to std::string.
 408         (jit_reader_load_command): Update.
 409         * main.c (gdb_datadir): Change to std::string.
 410         (python_libdir): Likewise.
 411         (set_gdb_data_directory): Update.
 412         (relocate_path): Change to return std::string.
 413         (relocate_gdb_directory): Change to return std::string.
 414         (relocate_gdbinit_path_maybe_in_datadir): Update.
 415         (captured_main_1): Update.
 416         * python/python.c (do_start_initialization): Update.
 417         * top.c (show_gdb_datadir): Update.
 418         * xml-syscall.c (xml_init_syscalls_info): Update.
 419         (init_syscalls_info): Update.
 420
 421 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 424         out of get_init_files.
 425         (get_init_files): Update.
 426
 427 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 428
 429         * main.c (get_init_files): Change to use std::string.
 430         (captured_main_1): Update.
 431         (print_gdb_help): Update.
 432
 433 2019-09-11  Ali Tamur  <tamur@google.com>
 434
 435         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 436         implementation.
 437
 438 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 439
 440         * dbxread.c (read_dbx_symtab): Update.
 441         * dwarf2read.c (load_partial_dies): Update.
 442         * mdebugread.c (parse_partial_symbols): Update.
 443         (handle_psymbol_enumerators): Update.
 444         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 445         * psymtab.c (add_psymbol_to_bcache): Likewise.
 446         (add_psymbol_to_list): Likewise.
 447         * symtab.c (symbol_set_names): Likewise.
 448         * symtab.h (symbol_set_names): Likewise.
 449         * xcoffread.c (scan_xcoff_symtab): Update.
 450
 451 2019-09-11  Tom Tromey  <tom@tromey.com>
 452
 453         * symfile-mem.c (symbol_file_add_from_memory): Use
 454         bfd_set_filename.
 455         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 456         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 457
 458 2019-09-10  Tom Tromey  <tromey@adacore.com>
 459
 460         * dwarf-index-write.c (write_psymbols): Extend error message.
 461         (debug_names::insert): Add Ada code.
 462         (debug_names::write_psymbols): Remove Ada check.
 463         (debug_names) <m_string_obstack>: New member.
 464         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 465         (gdb_index_symbol_name_matcher::matches): Remove.
 466         (mapped_index_base::find_name_components_bounds): Add "lang"
 467         parameter.
 468         (mapped_index_base::build_name_components): Also split names
 469         according to Ada syntax.
 470         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 471         type of "match_callback".
 472         (check_match, check_find_bounds_finds)
 473         (dw2_expand_symtabs_matching): Update.
 474         (dw2_debug_names_iterator): Add new constructor.
 475         (dw2_debug_names_map_matching_symbols): New function.
 476         (dw2_debug_names_expand_symtabs_matching): Update.
 477         (dwarf2_debug_names_functions): Use
 478         dw2_debug_names_map_matching_symbols.
 479
 480 2019-09-10  Tom Tromey  <tromey@adacore.com>
 481
 482         * dwarf2read.c (dw2_get_file_names_reader): Add the
 483         CU's file name to the results.
 484
 485 2019-09-10  Tom Tromey  <tromey@adacore.com>
 486
 487         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 488         map_matching_symbols.  Update.
 489         * dwarf2read.c (dw2_map_matching_symbols): Update.
 490         * psymtab.c (match_partial_symbol): Change type; update.
 491         (psym_map_matching_symbols): Likewise.
 492         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 493         type; update.
 494         * symfile.h (struct quick_symbol_functions)
 495         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 496         Remove "match".
 497
 498 2019-09-10  Tom Tromey  <tromey@adacore.com>
 499
 500         * psymtab.c (map_block): Remove.
 501         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 502         * symtab.c (iterate_over_symbols_terminated): New function.
 503         * symtab.c (iterate_over_symbols_terminated): Declare.
 504
 505 2019-09-10  Tom Tromey  <tromey@adacore.com>
 506
 507         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 508         * language.h (struct language_defn) <la_iterate_over_symbols>:
 509         Return bool.
 510         * symtab.c (iterate_over_symbols): Return bool.
 511         * symtab.h (iterate_over_symbols): Return bool.
 512
 513 2019-09-10  Tom Tromey  <tromey@adacore.com>
 514
 515         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 516         (add_nonlocal_symbols): Update.
 517         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 518         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 519         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 520         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 521         Change type of "callback".  Remove "data".
 522
 523
 524 2019-09-09  Ali Tamur  <tamur@google.com>
 525
 526         * dwarf2read.c (comp_unit_head): Update comment.
 527         (dwarf2_dwo_name): New function declaration.
 528         (dwarf_unit_type_name): New function declaration.
 529         (read_comp_unit_head): Add support for new compilation units,
 530         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 531         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 532         (currently named as "signature") in their header. Also clarify error
 533         messages.
 534         (lookup_dwo_id): New function. Returns the dwo id of the given
 535         compile unit.
 536         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 537         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 538         functions.
 539         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 540         (dwarf2_dwo_name): Get the dwo name if present.
 541         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 542         purposes.
 543
 544 2019-09-09  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 547
 548 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 549
 550         * python/python.c (do_start_initialization): Make progname_copy static,
 551         to avoid a leak report.
 552
 553 2019-09-08  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 556
 557 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 558
 559         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 560         Change type to gdb::optional<block_enum>.
 561         (dw2_symtab_iter_init): Change block_index parameter type
 562         to gdb::optional<block_enum>.
 563         (dw2_lookup_symbol): Change block_index parameter
 564         type to block_enum.c
 565         (dw2_debug_names_lookup_symbol): Likewise.
 566         * psymtab.c (psym_lookup_symbol): Likewise.
 567         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 568         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 569         Likewise.
 570
 571 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * defs.h (relocate_gdb_directory): Change int to bool in
 574         signature and rename flag to relocatable.
 575         * main.c (relocate_path): Likewise.
 576         (relocate_gdb_directory): Likewise.
 577
 578 2019-09-06  Alan Modra  <amodra@gmail.com>
 579
 580         * coffread.c (coff_symfile_read): Constify filename variable.
 581         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 582         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 583         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 584         * solib.c (reload_shared_libraries_1): Likewise.
 585         * symfile.c (reread_symbols): Likewise.
 586         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 587         * solib-darwin.c (darwin_bfd_open): Likewise.
 588         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 589
 590 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 593         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 594
 595 2019-09-03  Tom Tromey  <tromey@adacore.com>
 596
 597         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 598         types.
 599         (has_negatives): Unbias a range type bound.
 600         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 601         * gdbtypes.c (operator==): Handle new field.
 602         (create_range_type): Add "bias" parameter.
 603         (create_static_range_type, resolve_dynamic_range): Update.
 604         * gdbtypes.h (struct range_bounds) <bias>: New member.
 605         (create_range_type): Add bias parameter.
 606         * printcmd.c (print_scalar_formatted): Unbias range types.
 607         * value.c (unpack_long): Unbias range types.
 608         (pack_long): Bias range types.
 609
 610 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 611
 612         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 613         probe arguments.
 614
 615 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 616
 617         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 618         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 619         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 620         (compile_probe_arg): Likewise.
 621         * probe.h (get_argument_count): Likewise.
 622         * solib-svr4.c (solib_event_probe_action): Likewise.
 623         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 624
 625 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 626
 627         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 628         code to here...
 629         (svr4_create_solib_event_breakpoints): ...from here.
 630
 631 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 632
 633         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 634         suffix from warning message.
 635
 636 2019-08-30  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (struct tui_source_window_base)
 639         <refresh_all>: Don't declare.
 640         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 641         Remove.
 642         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 643         tui_show_locator_content.
 644         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 645         declare.
 646         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 647         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 648         declare.
 649
 650 2019-08-30  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 653
 654 2019-08-30  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 657         Remove unnecessary forward declarations.
 658
 659 2019-08-30  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 662         rerender.
 663         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 664         tui_show_locator_content.
 665
 666 2019-08-30  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 669         (tui_locator_window::rerender): Rewrite using body of previous
 670         tui_show_locator_content.
 671
 672 2019-08-30  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 675         set_locator_fullname>: New methods.
 676         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 677         Rename from tui_set_locator_fullname.
 678         (tui_locator_window::set_locator_info): Rename from
 679         tui_set_locator_info.  Return bool.
 680         (tui_update_locator_fullname, tui_show_frame_info): Update.
 681
 682 2019-08-30  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 685
 686 2019-08-30  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 689         call touchwin.
 690
 691 2019-08-30  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-wingeneral.c (box_win): Assume win_info and
 694         win_info->handle cannot be NULL.
 695
 696 2019-08-30  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 699         refresh_window>: Declare.
 700         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 701         resize.
 702         (tui_data_item_window::rerender): Rename from
 703         tui_display_register.
 704         (tui_data_item_window::refresh_window): New method.
 705         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 706         no-op.
 707
 708 2019-08-30  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 711         regs_column_count, current_group>: Move later.  Now private.
 712         <get_current_group>: New method.
 713         * tui/tui-regs.c (tui_reg_command): Update.
 714         * tui/tui-layout.c (tui_set_layout): Update.
 715
 716 2019-08-30  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 719         (tui_data_window::rerender): Don't call
 720         check_and_display_highlight_if_needed.
 721         (tui_data_window::refresh_all): Remove call to
 722         erase_data_content.
 723
 724 2019-08-30  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 727         (tui_data_window::display_registers_from)
 728         (tui_data_window::display_reg_element_at_line)
 729         (tui_data_window::display_registers_from_line): Remove checks of
 730         "empty".
 731
 732 2019-08-30  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 735         Don't declare.
 736         * tui/tui-regs.c (tui_data_window::show_registers): Call
 737         rerender.
 738         (tui_data_window::rerender): Rename from display_all_data.
 739         (tui_data_window::rerender): Remove old implementation.
 740
 741 2019-08-30  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 744         text.
 745         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 746
 747 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 748             Sergio Durigan Junior  <sergiodj@redhat.com>
 749
 750         PR win32/24284
 751         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 752
 753 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 756         when searching for types.
 757
 758 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * f-lang.c (f_language_defn): Use f_print_typedef.
 761         * f-lang.h (f_print_typedef): Declare.
 762         * f-typeprint.c (f_print_typedef): Define.
 763
 764 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 765
 766         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 767
 768 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 769
 770         * cli/cli-utils.c (info_print_options_defs): Delete.
 771         (make_info_print_options_def_group): Delete.
 772         (extract_info_print_options): Delete.
 773         (info_print_command_completer): Delete.
 774         (info_print_args_help): Add extra parameter, and optionally
 775         include text about -n flag.
 776         * cli/cli-utils.h (struct info_print_options): Delete.
 777         (extract_info_print_options): Delete declaration.
 778         (info_print_command_completer): Delete declaration.
 779         (info_print_args_help): Add extra parameter, extend header
 780         comment.
 781         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 782         search_symbols.
 783         * stack.c (struct info_print_options): New type.
 784         (info_print_options_defs): New file scoped variable.
 785         (make_info_print_options_def_group): New static function.
 786         (info_print_command_completer): New static function.
 787         (info_locals_command): Update to use new local functions.
 788         (info_args_command): Likewise.
 789         (_initialize_stack): Add extra parameter to calls to
 790         info_print_args_help.
 791         * symtab.c (search_symbols): Add extra parameter, use this to
 792         possibly excluse non-debug symbols.
 793         (symtab_symbol_info): Add extra parameter, which is passed on to
 794         search_symbols.
 795         (struct info_print_options): New type.
 796         (info_print_options_defs): New file scoped variable.
 797         (make_info_print_options_def_group): New static function.
 798         (info_print_command_completer): New static function.
 799         (info_variables_command): Update to use local functions, and pass
 800         extra parameter through to symtab_symbol_info.
 801         (info_functions_command): Likewise.
 802         (info_types_command): Pass additional argument through to
 803         symtab_symbol_info.
 804         (rbreak_command): Pass extra argument to search_symbols.
 805         (_initialize_symtab): Add extra arguments for calls to
 806         info_print_args_help, and update help text for 'info variables',
 807         'whereis', and 'info functions' commands.
 808         * symtab.h (search_symbols): Add extra argument to declaration.
 809         * NEWS: Mention new flags.
 810
 811 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 812
 813         * symtab.c (lookup_static_symbol): Call the new function (and move
 814         it down to be next to lookup_global_symbol).
 815         (struct global_sym_lookup_data): Add block_enum member and rename to...
 816         (struct global_or_static_sym_lookup_data): ...this.
 817         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 818         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 819         (lookup_symbol_global_or_static_iterator_cb): ...this.
 820         (lookup_global_or_static_symbol): New function.
 821         (lookup_global_symbol): Call new function.
 822
 823 2019-08-26  Tom de Vries  <tdevries@suse.de>
 824
 825         PR c++/24852
 826         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 827         when pc_probe.prob == NULL.
 828
 829 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 830
 831         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 832         variable symbol_linkage to symbol_linkage_.
 833
 834 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 835
 836         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 837         represent whether the symbol is static, dynamic, or we don't
 838         know.
 839
 840 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 841
 842         * gdb/rx-tdep.c (rx_register_names): New.
 843         (rx_register_name): Delete.
 844         (rx_psw_type): Delete.
 845         (rx_fpsw_type): Delete.
 846         (rx_register_type): Delete.
 847         (rx_gdbarch_init): Convert target-descriptions.
 848         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 849         * gdb/features/Makefile: Add rx.xml.
 850         * gdb/features/rx.xml: New.
 851         * gdb/features/rx.c: Generated.
 852         * gdb/NEWS: Mention target description support.
 853
 854 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 857         *slot_ptr.
 858
 859 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 860
 861         * configure.ac: Don't check for 'dlfcn.h' (moved to
 862         gdbsupport/common.m4).
 863         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 864         'gdbsupport/'.
 865         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 866         * compile/compile-c-support.c: Include
 867         'gdbsupport/gdb-dlfcn.h'.
 868         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 869         * gdb-dlfcn.c: Move to...
 870         * gdbsupport/gdb-dlfcn.c: ... here.
 871         * gdb-dlfcn.h: Move to...
 872         * gdbsupport/gdb-dlfcn.h: ... here.
 873
 874 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 875
 876         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 877         the offset field signed.
 878
 879 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 880
 881         * python/lib/gdb/__init__.py (_execute_file): New function.
 882         * python/python.c (python_run_simple_file): Call gdb._execute_file
 883         on Windows.
 884
 885 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 888         all uses as this was never set to anything but a zero value.
 889
 890 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 891
 892         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 893
 894 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 895
 896         * tui/tui-data.h (tui_gen_win_info): Add an =default
 897         move constructor, required by some GCC versions.
 898
 899 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 900
 901         * go32-nat.c (go32_sysinfo): Add hygon_p.
 902
 903 2019-08-20  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 906         line_from_reg_element_no, first_reg_element_no_inline,
 907         display_all_data, delete_data_content_windows,
 908         erase_data_content>: Now private.
 909
 910 2019-08-20  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 913         (tui_unhighlight_win, tui_highlight_win)
 914         (tui_win_info::make_window): Update.
 915         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 916
 917 2019-08-20  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 920         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 921         (MAX_PID_WIDTH): Move to tui-stack.c.
 922         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 923         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 924         (MAX_PID_WIDTH): Move from tui-data.h.
 925
 926 2019-08-20  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 929         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 930         (box_win): Update.
 931         (tui_gen_win_info::make_window): Rename from tui_make_window.
 932         (tui_win_info::make_window): New method.
 933         (tui_gen_win_info::make_visible): Update.
 934         * tui/tui-source.c (tui_source_window::set_contents): Update.
 935         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 936         (tui_data_window::display_registers_from): Update.
 937         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 938         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 939         Declare.
 940         <can_box>: Remove.
 941         <title>: Remove.
 942         (struct tui_win_info) <make_window>: Declare.
 943         <can_box>: Now virtual.
 944         <title>: New member.
 945         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 946         * tui/tui-command.c (tui_cmd_window::resize): Update.
 947
 948 2019-08-20  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 951         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 952         (tui_data_window::check_register_values): Update.
 953
 954 2019-08-20  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-regs.h (struct tui_data_window): Use
 957         DISABLE_COPY_AND_ASSIGN.
 958         <regs_content>: Change type, removing unique_ptr.
 959         <tui_data_window>: Add move constructor.
 960         * tui/tui-regs.c (tui_data_window::show_registers)
 961         (tui_data_window::show_register_group)
 962         (tui_data_window::display_registers_from)
 963         (tui_data_window::display_registers_from)
 964         (tui_data_window::first_data_item_displayed)
 965         (tui_data_window::delete_data_content_windows)
 966         (tui_data_window::rerender, tui_data_window::refresh_window)
 967         (tui_data_window::check_register_values): Update.
 968
 969 2019-08-20  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 972         show_register_group>: Declare.
 973         (tui_show_register_group): Don't declare.
 974         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 975         tui_show_registers.
 976         (tui_data_window::show_register_group): Rename from
 977         tui_show_register_group.
 978         (tui_data_window::check_register_values, tui_reg_command):
 979         Update.
 980         * tui/tui-layout.c (tui_set_layout): Update.
 981
 982 2019-08-20  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 985         Declare.
 986         (tui_check_register_values): Don't declare.
 987         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 988         from tui_check_register_values.
 989         * tui/tui-hooks.c (tui_register_changed): Update.
 990
 991 2019-08-20  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-regs.c (tui_reg_layout): Move later.
 994         (tui_show_registers): Don't enable TUI mode or change layout.
 995
 996 2019-08-20  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-regs.h (struct tui_data_item_window)
 999         <~tui_data_item_window>: Remove.
1000         <content>: Now a unique_xmalloc_ptr.
1001         * tui/tui-regs.c (tui_register_format): Return a
1002         unique_xmalloc_ptr.
1003         (tui_get_register): Update.
1004         (~tui_data_item_window): Remove.
1005         (tui_data_window::display_registers_from, tui_display_register):
1006         Update.
1007         * tui/tui-io.h (tui_expand_tabs): Update.
1008         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1009         Remove "col" parameter.
1010
1011 2019-08-20  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1014         field.
1015         * tui/tui-regs.c (~tui_data_item_window): Update.
1016
1017 2019-08-20  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1020         earlier.
1021
1022 2019-08-20  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1025
1026 2019-08-20  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-source.h (struct tui_source_window): Update.
1029         * tui/tui-regs.c (tui_show_registers): Update.
1030         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1031         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1032         (NO_REGS_STRING): Remove defines.
1033
1034 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1035
1036         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1037         unnecessary thread walk if remote doesn't support the packet.
1038
1039 2019-08-19  Tom Tromey  <tromey@adacore.com>
1040
1041         * python/py-value.c (value_has_field): Fix indentation.
1042
1043 2019-08-19  Tom Tromey  <tromey@adacore.com>
1044
1045         * printcmd.c (do_one_display, info_display_command): Update.
1046         * block.h (contained_in): Return bool.  Add allow_nested
1047         parameter.
1048         * block.c (contained_in): Return bool.  Add allow_nested
1049         parameter.
1050
1051 2019-08-19  Tom Tromey  <tom@tromey.com>
1052
1053         * configure: Rebuild.
1054         * configure.ac: Disallow the combination of -static-libstdc++ and
1055         source highlight.
1056         * source-cache.c (get_language_name): Handle rust.
1057         (source_cache::get_source_lines): Ignore highlighting exceptions.
1058
1059 2019-08-16  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1062         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1063         (struct tui_source_window_base) <make_visible, refresh_window,
1064         resize>: Remove methods.
1065         <execution_info>: Remove field.
1066         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1067         (tui_show_source_line, tui_source_window_base)
1068         (~tui_source_window_base): Update.
1069         (tui_source_window_base::resize)
1070         (tui_source_window_base::make_visible)
1071         (tui_source_window_base::refresh_window): Remove.
1072         (tui_source_window_base::update_exec_info): Update.
1073         * tui/tui-source.c (tui_source_window::set_contents): Update.
1074         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1075
1076 2019-08-16  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1079         deprecated_query_hook.
1080
1081 2019-08-16  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1084         (tui_update_source_windows_with_line): Update.
1085         * tui/tui-source.h (struct tui_source_window)
1086         <show_symtab_source>: Declare.
1087         (tui_show_symtab_source): Don't declare.
1088         * tui/tui-source.c (tui_show_symtab_source): Rename from
1089         tui_show_symtab_source.
1090
1091 2019-08-16  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-winsource.h (struct tui_source_window_base)
1094         <set_contents>: Declare.
1095         * tui/tui-winsource.c
1096         (tui_source_window_base::update_source_window_as_is): Update.
1097         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1098         Declare.
1099         (tui_set_source_content): Don't declare.
1100         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1101         tui_set_source_content.
1102         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1103         Declare.
1104         (tui_set_disassem_content): Don't declare.
1105         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1106         tui_set_disassem_content.
1107
1108 2019-08-16  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-winsource.h (struct tui_source_window_base)
1111         <update_breakpoint_info>: Declare.
1112         (tui_update_breakpoint_info): Don't declare.
1113         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1114         (tui_update_all_breakpoint_info): Update.
1115         (tui_source_window_base::update_breakpoint_info): Rename from
1116         tui_update_breakpoint_info.
1117         (tui_source_window_base::update_exec_info): Update.
1118
1119 2019-08-16  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-winsource.h (struct tui_source_window_base)
1122         <update_source_window>: Declare.
1123         (tui_update_source_window): Don't declare.
1124         * tui/tui-winsource.c
1125         (tui_source_window_base::update_source_window): Rename from
1126         tui_update_source_window.
1127         (tui_source_window_base::rerender): Update.
1128         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1129         * tui/tui-disasm.c (tui_show_disassem)
1130         (tui_show_disassem_and_update_source)
1131         (tui_disasm_window::maybe_update): Update.
1132
1133 2019-08-16  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-winsource.h (struct tui_source_window_base)
1136         <update_source_window_as_is>: Declare.
1137         (tui_update_source_window_as_is): Don't declare.
1138         * tui/tui-winsource.c (tui_update_source_window): Update
1139         (tui_source_window_base::update_source_window_as_is): Rename from
1140         tui_update_source_window_as_is.
1141         (tui_source_window_base::refill): Update.
1142         * tui/tui-source.c (tui_show_symtab_source): Update.
1143         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1144         Update.
1145
1146 2019-08-16  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.h (tui_update_source_window)
1149         (tui_update_source_window_as_is): Remove "noerror" parameter.
1150         * tui/tui-winsource.c (tui_update_source_window)
1151         (tui_update_source_window_as_is): Remove "noerror" parameter.
1152         (tui_update_source_windows_with_addr)
1153         (tui_update_source_windows_with_line)
1154         (tui_source_window_base::rerender)
1155         (tui_source_window_base::refill): Update.
1156         * tui/tui-source.h (tui_set_source_content)
1157         (tui_show_symtab_source): Remove "noerror" parameter.
1158         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1159         parameter.
1160         (tui_show_symtab_source): Likewise.
1161         (tui_source_window::maybe_update): Update.
1162         * tui/tui-disasm.c (tui_show_disassem)
1163         (tui_show_disassem_and_update_source)
1164         (tui_disasm_window::do_scroll_vertical)
1165         (tui_disasm_window::maybe_update): Update.
1166
1167 2019-08-16  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui.c (tui_is_window_visible): Update.
1170         * tui/tui-wingeneral.c (tui_make_window)
1171         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1172         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1173         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1174         (tui_set_win_height_command, parse_scrolling_args): Update.
1175         * tui/tui-source.c (tui_source_window::style_changed): Update.
1176         * tui/tui-regs.c (tui_show_registers)
1177         (tui_data_window::first_data_item_displayed)
1178         (tui_data_window::delete_data_content_windows)
1179         (tui_check_register_values, tui_reg_command): Update.
1180         * tui/tui-disasm.c (tui_show_disassem): Update.
1181         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1182         method.
1183         <is_visible>: Remove field.
1184         * tui/tui-data.c (tui_next_win, tui_prev_win)
1185         (tui_delete_invisible_windows): Update.
1186
1187 2019-08-16  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-winsource.h (struct tui_source_window_base)
1190         <m_has_locator>: Remove.
1191         * tui/tui-layout.c (show_source_disasm_command, show_data)
1192         (show_source_or_disasm_and_command): Update.
1193
1194 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1195
1196         * NEWS (Other MI changes): New subsection.
1197         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1198         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1199         * arch-utils.c (default_get_pc_address_flags): New function.
1200         * arch-utils.h (default_get_pc_address_flags): New declaration.
1201         * gdbarch.sh: Add get_pc_address_flags.
1202         * gdbarch.c: Regenerate.
1203         * gdbarch.h: Likewise.
1204         * stack.c (print_pc): New function.
1205         (print_frame_info) (print_frame): Call print_pc.
1206
1207 2019-08-16  Tom de Vries  <tdevries@suse.de>
1208
1209         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1210         print_objfile_section_info.
1211
1212 2019-08-15  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1215         calling update_cmdwin_start_line.
1216         * tui/tui-winsource.h (struct tui_source_window_base)
1217         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1218         <rerender>: Declare.
1219         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1220         Call rerender.
1221         (tui_source_window_base::set_new_height): Remove.
1222         (tui_source_window_base::rerender): Rename from
1223         do_make_visible_with_new_height.
1224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1225         resize method.
1226         (tui_win_info::make_invisible_and_set_new_height)
1227         (tui_win_info::make_visible_with_new_height): Remove.
1228         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1229         Declare.
1230         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1231         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1232         do_make_visible_with_new_height>: Don't declare.
1233         <rerender>: Declare.
1234         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1235         set_new_height.
1236         (tui_data_window::do_make_visible_with_new_height): Remove.
1237         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1238         call tui_show_locator_content.
1239         (tui_gen_win_info::resize): Call rerender.
1240         (show_source_or_disasm_and_command): Don't call
1241         tui_show_locator_content.
1242         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1243         method.
1244         (struct tui_win_info) <rerender>: Declare.
1245         <set_new_height, make_invisible_and_set_new_height,
1246         make_visible_with_new_height>: Don't declare.
1247         * tui/tui-data.c (tui_win_list::rerender): New method.
1248         * tui/tui-command.h (struct tui_cmd_window)
1249         <do_make_visible_with_new_height>: Don't declare.
1250         * tui/tui-command.c
1251         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1252
1253 2019-08-15  Tom Tromey  <tromey@adacore.com>
1254
1255         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1256         * ada-lang.c (ada_enum_name): Likewise.
1257
1258 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1259
1260         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1261         leading underscore.
1262         (GdbOutputErrorFile): Likewise.
1263         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1264         accordingly.
1265         (execute_unwinders): Rename to have a leading underscore.
1266         (auto_load_packages): Likewise.
1267         (global scope): Adjust call to auto_load_packages accordingly.
1268         (GdbSetPythonDirectory): Likewise.
1269         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1270         instead of execute_unwinders.
1271
1272 2019-08-15  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1275         (show_data): Don't change window visibility.
1276         (tui_gen_win_info::resize): Remove special case for command
1277         window.  Use wresize, when available.
1278         (show_source_or_disasm_and_command): Don't change window
1279         visibility.
1280         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1281         <make_visible>: New method.
1282         * tui/tui-command.c (tui_cmd_window::resize): New method.
1283
1284 2019-08-15  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1287         (struct tui_source_windows): New.
1288         * tui/tui-winsource.c (tui_display_main): Update.
1289         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1290         (new_height_ok, parse_scrolling_args): Update.
1291         * tui/tui-layout.c (show_layout, show_data): Update.
1292         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1293         (tui_add_to_source_windows): Don't declare.
1294         * tui/tui-data.c (source_windows, tui_source_windows)
1295         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1296
1297 2019-08-15  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1300         Rename from reset.
1301         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1302         * tui/tui-layout.c (show_source_disasm_command, show_data):
1303         Update.
1304         (tui_gen_win_info::resize): Rename.
1305         (show_source_or_disasm_and_command): Update.
1306         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1307         reset.
1308
1309 2019-08-15  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1312         * tui/tui-interp.c (tui_interp::init): Don't call
1313         tui_initialize_static_data.
1314         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1315
1316 2019-08-15  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1319         examine tui_win_list.
1320
1321 2019-08-15  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1324         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1325         tui_clear_source_content.
1326         (tui_clear_source_content): Remove.
1327         (tui_source_window_base::do_erase_source_content): Hoist call to
1328         content.clear().
1329         * tui/tui-stack.c (tui_show_frame_info): Don't call
1330         tui_clear_source_content.
1331
1332 2019-08-15  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-winsource.h (struct tui_source_window_base)
1335         <do_erase_source_content>: New method.
1336         <erase_source_content>: New method.
1337         (tui_erase_source_content): Don't declare.
1338         * tui/tui-winsource.c (tui_clear_source_content): Update.
1339         (tui_source_window_base::do_erase_source_content): Rename from
1340         tui_erase_source_content.
1341         (tui_source_window_base::show_source_content): Update.
1342         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1343         * tui/tui-source.h (struct tui_source_window)
1344         <erase_source_content>: New method.
1345         * tui/tui-disasm.h (struct tui_disasm_window)
1346         <erase_source_content>: New method.
1347
1348 2019-08-15  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1351         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1352         constructor.
1353         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1354         * tui/tui-source.c (tui_set_source_content): Update.
1355         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1356
1357 2019-08-15  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1360         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1361         tui-source.c.
1362         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1363         Declare.
1364         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1365         method.
1366         (tui_source_window::maybe_update): Update.
1367
1368 2019-08-15  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1371         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1372         tui-disasm.c.
1373         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1374         Declare.
1375         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1376         method.
1377         (tui_disasm_window::maybe_update): Update.
1378
1379 2019-08-15  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-winsource.h (struct tui_source_window_base)
1382         <maybe_update>: Declare.
1383         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1384         method.
1385         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1386         Declare.
1387         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1388         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1389         Declare.
1390         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1391
1392 2019-08-15  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1395
1396 2019-08-15  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-wingeneral.c: Include tui-stack.h.
1399         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1400         (struct tui_locator_window): Move from tui-data.h.
1401         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1402         (tui_initialize_static_data): Move from tui-data.c.
1403         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1404         (struct tui_locator_window): Move to tui-stack.c.
1405         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1406         (tui_initialize_static_data): Move to tui-stack.c.
1407
1408 2019-08-15  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-layout.c (show_source_disasm_command)
1411         (show_source_or_disasm_and_command): Use make_visible method, not
1412         tui_make_window.
1413         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1414         Remove.
1415
1416 2019-08-15  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-wingeneral.h (tui_make_window): Update.
1419         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1420         parameter.
1421         (tui_gen_win_info::make_visible): Update.
1422         * tui/tui-regs.c (tui_data_window::display_registers_from):
1423         Update.
1424         * tui/tui-layout.c (show_source_disasm_command)
1425         (show_source_or_disasm_and_command): Update.
1426         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1427         (enum tui_box): Remove.
1428         (struct tui_win_info) <can_box>: New method.
1429         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1430         method.
1431
1432 2019-08-15  Tom de Vries  <tdevries@suse.de>
1433
1434         * linux-nat-trad.c: Include gdbarch.h.
1435
1436 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1437
1438         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1439         register sizes.
1440
1441 2019-08-14  Tom Tromey  <tromey@adacore.com>
1442
1443         * darwin-nat.c: Include gdbarch.h.
1444         * darwin-nat-info.c: Include gdbarch.h.
1445
1446 2019-08-13  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1449         Remove.
1450         * tui/tui-data.c (tui_initialize_static_data): Update.
1451
1452 2019-08-13  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-winsource.h (struct tui_exec_info_window)
1455         <~tui_exec_info_window, maybe_allocate_content, get_content,
1456         m_content>: Remove.
1457         (struct tui_source_window_base) <set_exec_info_content,
1458         show_exec_info_content>: Don't declare.
1459         * tui/tui-winsource.c
1460         (tui_exec_info_window::maybe_allocate_content): Remove.
1461         (tui_source_window_base::update_exec_info): Rename from
1462         set_exec_info_content.
1463         (tui_source_window_base::show_exec_info_content)
1464         (tui_source_window_base::update_exec_info): Remove.
1465
1466 2019-08-13  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1469         declare.
1470         * tui/tui-winsource.c (tui_update_source_window_as_is)
1471         (tui_update_source_windows_with_addr, tui_erase_source_content):
1472         Update.
1473         (tui_clear_exec_info_content): Remove.
1474
1475 2019-08-13  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1478         declare.
1479         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1480         call tui_erase_exec_info_content.
1481         (tui_clear_exec_info_content): Rename from
1482         tui_erase_exec_info_content.
1483         (tui_clear_exec_info_content): Delete.
1484
1485 2019-08-13  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-winsource.h (struct tui_source_window_base)
1488         <show_exec_info_content>: Declare.
1489         (tui_show_exec_info_content): Don't declare.
1490         * tui/tui-winsource.c
1491         (tui_source_window_base::show_exec_info_content): Rename from
1492         tui_show_exec_info_content.
1493         (tui_source_window_base::update_exec_info): Update.
1494
1495 2019-08-13  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1498         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1499         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1500         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1501         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1502         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1503         ... here.
1504
1505 2019-08-13  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.h (struct tui_source_window_base)
1508         <update_exec_info>: Declare.
1509         (tui_update_exec_info): Don't declare.
1510         * tui/tui-winsource.c (tui_update_source_window_as_is)
1511         (tui_source_window_base::refresh_all)
1512         (tui_update_all_breakpoint_info): Update.
1513         (tui_source_window_base::update_exec_info): Rename from
1514         tui_update_exec_info.
1515         * tui/tui-stack.c (tui_show_frame_info): Update.
1516
1517 2019-08-13  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.h (struct tui_source_window_base)
1520         <set_exec_info_content>: Declare.
1521         (tui_set_exec_info_content): Don't declare.
1522         * tui/tui-winsource.c
1523         (tui_source_window_base::set_exec_info_content): Rename from
1524         tui_set_exec_info_content.
1525         (tui_update_exec_info): Update.
1526
1527 2019-08-13  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-winsource.h (struct tui_source_window_base)
1530         <show_source_content>: Declare.
1531         (tui_show_source_content): Don't declare.
1532         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1533         (tui_source_window_base::show_source_content): Rename from
1534         tui_show_source_content.
1535         (tui_source_window_base::refresh_all): Update.
1536         * tui/tui-layout.c (show_source_disasm_command)
1537         (show_source_or_disasm_and_command): Update.
1538
1539 2019-08-13  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-winsource.c (tui_erase_source_content)
1542         (tui_show_source_content, tui_source_window_base::refresh_all):
1543         Update.
1544         * tui/tui-wingeneral.h
1545         (tui_check_and_display_highlight_if_needed): Don't declare.
1546         * tui/tui-wingeneral.c
1547         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1548         check_and_display_highlight_if_needed.
1549         * tui/tui-win.c (tui_rehighlight_all)
1550         (tui_win_info::make_visible_with_new_height): Update.
1551         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1552         (tui_data_window::erase_data_content)
1553         (tui_data_window::display_all_data): Update.
1554         * tui/tui-data.h (struct tui_win_info)
1555         <check_and_display_highlight_if_needed>: Declare.
1556
1557 2019-08-13  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-win.c (tui_resize_all): Call
1560         tui_delete_invisible_windows.
1561         * tui/tui-layout.c (show_layout): Call
1562         tui_delete_invisible_windows.
1563         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1564         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1565
1566 2019-08-13  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1569         tui_add_win_to_layout.
1570
1571 2019-08-13  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1574         * tui/tui-layout.c (tui_default_win_height): Now static.
1575
1576 2019-08-13  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1579         single switch.
1580         (show_source_disasm_command, show_source_or_disasm_and_command):
1581         Don't check current layout.
1582
1583 2019-08-13  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-wingeneral.c (make_all_visible): Remove.
1586         (tui_make_all_invisible): Simplify.
1587         * tui/tui-layout.c (tui_make_all_invisible): Move from
1588         tui-wingeneral.c; simplify.
1589         (show_layout): Hoist call to tui_make_all_invisible.
1590         (show_data): Don't call tui_make_all_invisible.
1591
1592 2019-08-13  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1595         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1596
1597 2019-08-13  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1600         tui-data.c.
1601         (show_source_disasm_command, show_data)
1602         (show_source_or_disasm_and_command): Don't use
1603         tui_set_current_layout_to.
1604         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1605         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1606         tui-layout.c.
1607         (tui_set_current_layout_to): Remove.
1608
1609 2019-08-13  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-layout.c (tui_set_layout): Update.
1612         * tui/tui-data.h (struct tui_layout_def): Remove.
1613         (tui_layout_def): Don't declare.
1614         * tui/tui-data.c (layout_def): Remove.
1615         (tui_layout_def): Remove.
1616
1617 2019-08-13  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-winsource.h (struct tui_source_window_base)
1620         <clear_detail>: No longer "override".
1621         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1622         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1623         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1624         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1625         Remove.
1626         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1627
1628 2019-08-13  Tom Tromey  <tromey@adacore.com>
1629
1630         * tracepoint.c: Don't include readline.h or history.h.
1631
1632 2019-08-12  Tom Tromey  <tom@tromey.com>
1633
1634         * configure: Rebuild.
1635         * configure.ac: Check for readline 7.
1636         * NEWS: Mention readline 7 requirement.
1637         * README: Update.
1638
1639 2019-08-12  Tom Tromey  <tom@tromey.com>
1640
1641         * mingw-hdep.c (gdb_select): Remove readline hack.
1642
1643 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1644
1645         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1646         when the function fails.
1647
1648 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1649
1650         * s390-tdep.c (s390_type_align): New function.
1651         (s390_gdbarch_init): Set it as type_align gdbarch method.
1652
1653 2019-08-09  Tom de Vries  <tdevries@suse.de>
1654
1655         PR gdb/24591
1656         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1657         pc_low with relocation offset.
1658
1659 2019-08-07  Tom Tromey  <tromey@adacore.com>
1660
1661         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1662         (print_frame_args): Update.
1663         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1664         Update.
1665         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1666         * frame.h (struct frame_arg): Add initializers.
1667         <error>: Now a unique_xmalloc_ptr.
1668
1669 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1670
1671         * NEWS: Expand the Pointer Authentication entry.
1672         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1673         (aarch64_frame_unmask_lr): ... to this.
1674         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1675         Call aarch64_frame_unmask_lr.
1676         * frame.c (struct frame_info): Add "masked" variable.
1677         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1678         (fprint_frame): Check for masked pc.
1679         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1680         declarations.
1681         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1682         * stack.c (print_frame): Check for masked pc.
1683
1684 2019-08-06  Tom Tromey  <tom@tromey.com>
1685
1686         * stabsread.c (patch_block_stabs, read_one_struct_field)
1687         (read_enum_type): Use obstack_strndup.
1688         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1689         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1690         * dwarf2read.c (guess_full_die_structure_name)
1691         (anonymous_struct_prefix): Use obstack_strndup.
1692         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1693         * c-exp.y (yylex): Use obstack_strndup.
1694         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1695         (write_var_or_type): Use obstack_strndup.
1696
1697 2019-08-06  Tom Tromey  <tom@tromey.com>
1698
1699         * symfile.c (reread_symbols): Use obstack_strdup.
1700         * stabsread.c (read_type): Use obstack_strdup.
1701         * gdb_obstack.h (obstack_strdup): New overload.
1702         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1703         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1704         (dwarf2_canonicalize_name): Use obstack_strdup.
1705         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1706         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1707         Use obstack_strdup.
1708
1709 2019-08-06  Tom Tromey  <tom@tromey.com>
1710
1711         * gdb_obstack.h (obstack_strdup): Define.
1712         * gdb_obstack.c (obstack_strdup): Don't define.
1713
1714 2019-08-06  Tom Tromey  <tom@tromey.com>
1715
1716         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1717         obstack_strdup.
1718         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1719         obstack_strdup.
1720         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1721         * stabsread.c (common_block_start): Use obstack_strdup.
1722         * objfiles.c (set_objfile_main_name, objfile): Use
1723         obstack_strdup.
1724         * namespace.c (add_using_directive): Use obstack_strdup.
1725         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1726         * jit.c (finalize_symtab): Use obstack_strdup.
1727         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1728         (guess_partial_die_structure_name, partial_die_info::fixup)
1729         (dwarf2_name): Use obstack_strdup.
1730         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1731         obstack_strdup.
1732         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1733         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1734         obstack_strdup.
1735         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1736
1737 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1738
1739         * unittests/help-doc-selftests.c: New file.
1740         * Makefile.in: Add the new file.
1741
1742 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1743
1744         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1745         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1746         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1747         the trailing '.' is not output, and the first character is uppercased.
1748         (print_help_for_command): Update call to print_doc_line.
1749         (print_doc_of_command): Likewise.
1750         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1751         * cli/cli-option.c (append_indented_doc): Do not append newline.
1752         (build_help_option): Append newline after first appended_indented_doc
1753         only if a second call is done.
1754         (build_help): Append 2 new lines before each option, except the first
1755         one.
1756         * compile/compile.c (_initialize_compile): Add new lines after
1757         %OPTIONS%, when not at the end of the help.
1758         Change help doc or code
1759         producing the help doc to respect the invariants.
1760         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1761         Also removed the new line after 'Options:', as all other commands
1762         do not put an empty line between 'Options:' and the first option.
1763         * printcmd.c (_initialize_printcmd): Likewise.
1764         * stack.c (_initialize_stack): Likewise.
1765         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1766         incorrectly telling COMMAND is optional.
1767         * ada-lang.c (_initialize_ada_language): Change help doc or code
1768         producing the help doc to respect the invariants.
1769         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1770         * breakpoint.c (_initialize_breakpoint): Likewise.
1771         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1772         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1773         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1774         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1775         _initialize_cli_style): Likewise.
1776         * corelow.c (core_target_info): Likewise.
1777         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1778         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1779         * filesystem.c (_initialize_filesystem): Likewise.
1780         * frame.c (_initialize_frame): Likewise.
1781         * gnu-nat.c (add_task_commands): Likewise.
1782         * infcall.c (_initialize_infcall): Likewise.
1783         * infcmd.c (_initialize_infcmd): Likewise.
1784         * interps.c (_initialize_interpreter): Likewise.
1785         * language.c (_initialize_language): Likewise.
1786         * linux-fork.c (_initialize_linux_fork): Likewise.
1787         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1788         * maint.c (_initialize_maint_cmds): Likewise.
1789         * memattr.c (_initialize_mem): Likewise.
1790         * printcmd.c (_initialize_printcmd): Likewise.
1791         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1792         _RegEx): Likewise.
1793         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1794         * record-btrace.c (_initialize_record_btrace): Likewise.
1795         * record-full.c (_initialize_record_full): Likewise.
1796         * record.c (_initialize_record): Likewise.
1797         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1798         * regcache.c (_initialize_regcache): Likewise.
1799         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1800         _initialize_remote): Likewise.
1801         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1802         * serial.c (_initialize_serial): Likewise.
1803         * skip.c (_initialize_step_skip): Likewise.
1804         * source.c (_initialize_source): Likewise.
1805         * stack.c (_initialize_stack): Likewise.
1806         * symfile.c (_initialize_symfile): Likewise.
1807         * symtab.c (_initialize_symtab): Likewise.
1808         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1809         * top.c (init_main): Likewise.
1810         * tracefile-tfile.c (tfile_target_info): Likewise.
1811         * tracepoint.c (_initialize_tracepoint): Likewise.
1812         * tui/tui-win.c (_initialize_tui_win): Likewise.
1813         * utils.c (add_internal_problem_command): Likewise.
1814         * valprint.c (value_print_option_defs): Likewise.
1815
1816 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1817
1818         PR build/24886
1819         * configure.ac: Drop enable-libmcheck support.
1820         * configure, config.in: Rebuild.
1821         * libmcheck.m4: Remove.
1822         * acinclude.m4: Don't include it.
1823         * Makefile.in: Don't distribute it.
1824         * top.c (print_gdb_configuration): Don't mention it.
1825
1826 2019-08-06  Tom Tromey  <tom@tromey.com>
1827
1828         * utils.c (set_output_style): Sometimes pass stream to
1829         emit_style_escape.
1830         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1831         * record-btrace.c (btrace_insn_history): Update.
1832         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1833         method.
1834         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1835         Update initializers.
1836         <m_uiout>: New field.
1837         <m_di>: Move lower.
1838         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1839         Remove "uiout" parameter.
1840         (dump_insns): Update.
1841         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1842         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1843
1844 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1845
1846         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1847         (error_in_psymtab_expansion): Likewise.
1848         (lookup_symbol_via_quick_fns): Likewise.
1849         (basic_lookup_transparent_type_quick): Likewise.
1850         (basic_lookup_transparent_type_1): Likewise.
1851
1852 2019-08-06  Tom Tromey  <tromey@adacore.com>
1853
1854         * source.c (last_source_error): Now bool.
1855         (print_source_lines_base): Make "noprint" bool.  Only open
1856         source file when last_source_visited changes.
1857
1858 2019-08-06  Tom Tromey  <tromey@adacore.com>
1859
1860         * annotate.c (annotate_source_line): Use g_source_cache.
1861         * source-cache.c (source_cache::get_plain_source_lines): Change
1862         parameters.  Populate m_offset_cache.
1863         (source_cache::ensure): New method.
1864         (source_cache::get_line_charpos): New method.
1865         (extract_lines): Move lower.  Change parameters.
1866         (source_cache::get_source_lines): Move lower.
1867         * source-cache.h (class source_cache): Update comment.
1868         <get_line_charpos>: New method.
1869         <get_source_lines>: Update comment.
1870         <clear>: Clear m_offset_cache.
1871         <get_plain_source_lines>: Change parameters.
1872         <ensure>: New method
1873         <m_offset_cache>: New member.
1874         * source.c (forget_cached_source_info_for_objfile): Update.
1875         (info_source_command): Use g_source_cache.
1876         (find_source_lines, open_source_file_with_line_charpos): Remove.
1877         (print_source_lines_base, search_command_helper): Use g_source_cache.
1878         * source.h (open_source_file_with_line_charpos): Don't declare.
1879         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1880         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1881         Use g_source_cache.
1882
1883 2019-08-06  Tom Tromey  <tromey@adacore.com>
1884
1885         * source-cache.c (source_cache::get_plain_source_lines):
1886         Remove "first_line" and "last_line" parameters.
1887         (source_cache::get_source_lines): Cache plain text.
1888         * source-cache.h (class source_cache)
1889         <get_plain_source_lines>: Update.
1890
1891 2019-08-06  Tom Tromey  <tromey@adacore.com>
1892
1893         * source-cache.c (extract_lines): No longer a method.
1894         Changed type of parameter.  Include final newline.
1895         (selftests::extract_lines_test): New function.
1896         (_initialize_source_cache): Likewise.
1897         * source-cache.h (class source_cache)
1898         <extract_lines>: Don't declare.
1899
1900 2019-08-06  Tom Tromey  <tromey@adacore.com>
1901
1902         * breakpoint.c (init_breakpoint_sal): Update.
1903         (breakpoint): Update.
1904         * breakpoint.h (struct breakpoint) <filter>: Now a
1905         unique_xmalloc_ptr.
1906
1907 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1908
1909         * NEWS: Mention dictionary access on blocks.
1910         * python/py-block.c (blpy_getitem): New function.
1911         (block_object_as_mapping): New struct.
1912         (block_object_type): Use new struct for tp_as_mapping field.
1913
1914 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1915
1916         * objfiles.h (objfile): Add a comment describing partial symbols.
1917
1918 2019-08-05  Tom Tromey  <tromey@adacore.com>
1919
1920         * compile/compile.c (_initialize_compile): Use _(), not N_().
1921         * thread.c (_initialize_thread): Use _(), not N_().
1922         * stack.c (_initialize_stack): Use _(), not N_().
1923         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1924
1925 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1926
1927         * dwarf2read.c (struct dw2_symtab_iterator):
1928         <want_specific_block>: Remove.
1929         <block_index>: Change type to gdb::optional.
1930         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1931         change type of BLOCK_INDEX parameter to gdb::optional.
1932         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1933         (dw2_lookup_symbol): Don't pass argument for
1934         WANT_SPECIFIC_BLOCK.
1935         (dw2_expand_symtabs_for_function): Don't pass argument for
1936         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1937         (class dw2_debug_names_iterator)
1938         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1939         parameter, change BLOCK_INDEX type to gdb::optional.
1940         <m_want_specific_block>: Remove.
1941         <m_block_index>: Change type to gdb::optional.
1942         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1943         gdb::optional.  Re-write in function of gdb::optional.
1944         (dw2_debug_names_lookup_symbol): Don't pass argument for
1945         WANT_SPECIFIC_BLOCK.
1946         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1947         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1948         BLOCK_INDEX.
1949
1950 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1951
1952         * NEWS: Mention changes to "info sources" command.
1953
1954 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1955
1956         * symtab.c (filename_partial_match_opts): New struct type.
1957         (struct output_source_filename_data): New members
1958         regexp, c_regexp, partial_match.
1959         (output_source_filename): Use new members to decide to print file.
1960         (info_sources_option_defs): New variable.
1961         (make_info_sources_options_def_group, print_info_sources_header,
1962         info_sources_command_completer):
1963         New functions.
1964         (info_sources_command): Read new optional arguments.
1965         (_initialize_symtab): Update info sources help.
1966
1967 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1968
1969         * ada-lang.c (exception_support_info_v0): Renamed from...
1970         (default_exception_support_info): ... this.  Create new
1971         definition for v1.
1972         (ada_has_this_exception_support): Look up catch_handlers_sym.
1973         (ada_exception_support_info_sniffer): Try v0 after default.
1974
1975 2019-08-01  Tom Tromey  <tromey@adacore.com>
1976
1977         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1978         gdbarch.h.
1979
1980 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1981
1982         * s12z-tdep.c: Fix include path for s12z-opc.h.
1983
1984 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1985
1986         * NEWS: Require GNU make 3.82.
1987
1988 2019-07-16  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1991         declare.
1992
1993 2019-07-30  Tom Tromey  <tromey@adacore.com>
1994
1995         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1996
1997 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1998
1999         * printcmd.c (print_address_symbolic): Print negative offsets.
2000         (build_address_symbolic): Force signed arithmetic when computing
2001         offset.
2002
2003 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2004
2005         PR/24474: Add a function to lookup static variables.
2006         * NEWS: Mention this new function.
2007         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2008         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2009         * python/python.c (python_GdbMethods): Add new function.
2010
2011 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2012
2013         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2014         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2015         (objfpy_lookup_static_symbol): New function.
2016         (objfile_object_methods): Add new functions.
2017
2018 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2019
2020         * NEWS: Mention 'set|show print frame-info'.  Mention new
2021         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2022         backtrace argument.  Mention that python frame filtering code
2023         is now consistent with what 'backtrace' command prints.
2024
2025 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2026
2027         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2028         comments.
2029         (print_frame_info_auto, print_frame_info_source_line,
2030         print_frame_info_location, print_frame_info_source_and_location,
2031         print_frame_info_location_and_address, print_frame_info_short_location):
2032         New declarations.
2033         (struct frame_print_options): New member print_frame_info.
2034         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2035         * stack.h (get_user_print_what_frame_info): New declaration.
2036         (frame_show_address): New declaration.
2037         * stack.c (print_frame_arguments_choices): New value 'presence'.
2038         (print_frame_info_auto, print_frame_info_source_line,
2039         print_frame_info_location, print_frame_info_source_and_location,
2040         print_frame_info_location_and_address, print_frame_info_short_location,
2041         print_frame_info_choices, print_frame_info_print_what): New definitions.
2042         (print_frame_args): Only print dots for args if print frame-arguments
2043         is 'presence'.
2044         (frame_print_option_defs): New element for "frame-info".
2045         (get_user_print_what_frame_info): New function.
2046         (frame_show_address): Make non static.  Move comment to stack.h.
2047         (print_frame_info_to_print_what): New function.
2048         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2049         to decide what to print.
2050         (backtrace_command_1): Handle the new print_frame_arguments_presence
2051         value.
2052         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2053         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2054         (py_print_frame): In non-mi mode, use LOCATION as default for
2055         print_what, similarly to frame information printed directly by
2056         backtrace command. Handle frame-info user option in non MI mode.
2057
2058 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2059
2060         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2061         Add case for debugging 32-bit target on 64-bit host.  Revise
2062         comment.
2063
2064 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2065
2066         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2067         instead of find_function_entry_range_from_pc.
2068
2069 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2070
2071         * stack.c (find_frame_funname): Remove code which preferred
2072         minsym over symtab sym in "certain pathological cases".
2073
2074         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2075         parameter.  Change type of "do_demangle" to bool.
2076         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2077         Pass suitable "prefer_sym_over_minsym" flag to
2078         build_address_symbolic().  Don't output "+" for negative offsets.
2079         * printcmd.c (print_address_symbolic): Update invocation of
2080         build_address_symbolic to include a "prefer_sym_over_minsym"
2081         flag.
2082         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2083         Restrict cases in which use of minimal symbol is preferred to that
2084         of a found symbol.  Update comments.
2085
2086         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2087         for entry pc when entry pc is out of range for that FDE.
2088
2089 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2090
2091         PR gdb/24839:
2092         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2093         type.
2094
2095 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2096
2097         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2098         this function's Python signature.
2099
2100
2101 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2102
2103         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2104         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2105         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2106         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2107         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2108
2109
2110 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2111
2112         * h8300-tdep.c (h8300_register_name_common): New.
2113         h8300_register_name): Use h8300_register_name_common.
2114         (h8300s_register_name): Likewise.
2115         (h8300sx_register_name): Likewise.
2116         (h8300h_register_nam): New.
2117         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2118
2119
2120 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2121
2122         * arm-tdep.c (arm_skip_cmse_entry): New function.
2123         (arm_is_sgstubs_section): New function.
2124         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2125
2126 2019-07-22  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2129         Don't self-assign.
2130
2131 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2134         type_print.
2135
2136 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2139         so that GDB doesn't match any msymbols when searching in the
2140         TYPES_DOMAIN.
2141         (print_symbol_info): Print using typedef_print or type_print based
2142         on the type of the symbol.  Add updated FIXME comment moved from...
2143         (_initialize_symtab): ... move and update FIXME comment to above.
2144
2145 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * NEWS: Mention adding -q option to "info types".
2148         * symtab.c (struct info_types_options): New struct.
2149         (info_types_options_defs): New variable.
2150         (make_info_types_options_def_group): New function.
2151         (info_types_command): Use gdb::option framework to parse options.
2152         (info_types_command_completer): New function.
2153         (_initialize_symtab): Extend the help text on "info types" and
2154         register command completer.
2155
2156 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2157
2158         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2159         (lookup_symbol_in_objfile): Change int to block_enum and add a
2160         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2161
2162 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2163
2164         * MAINTAINERS (Write After Approval): Add self.
2165
2166 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2169         instruction to the dummy code region.
2170
2171 2019-07-19  Tom Tromey  <tromey@adacore.com>
2172
2173         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2174         (ARGSUSED, PARAMS, __func__): Remove rules.
2175
2176 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2177
2178         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2179         * features/arm/arm-with-iwmmxt.c: Remove.
2180         * features/arm/arm-with-iwmmxt.xml: Remove.
2181         * features/arm/arm-with-m-fpa-layout.c: Remove.
2182         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2183         * features/arm/arm-with-m-vfp-d16.c: Remove.
2184         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2185         * features/arm/arm-with-m.c: Remove.
2186         * features/arm/arm-with-m.xml: Remove.
2187         * features/arm/arm-with-neon.c: Remove.
2188         * features/arm/arm-with-neon.xml: Remove.
2189         * features/arm/arm-with-vfpv2.c: Remove.
2190         * features/arm/arm-with-vfpv2.xml: Remove.
2191         * features/arm/arm-with-vfpv3.c: Remove.
2192         * features/arm/arm-with-vfpv3.xml: Remove.
2193
2194 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2197
2198 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2199
2200         * arch/aarch32.c (aarch32_create_target_description): Create
2201         target descriptions using features.
2202         * arch/arm.c (arm_create_target_description)
2203         (arm_create_mprofile_target_description): Likewise.
2204         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2205
2206 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2207
2208         * Makefile.in: Add new files.
2209         * aarch32-tdep.c: New file.
2210         * aarch32-tdep.h: New file.
2211         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2212         Call aarch32_read_description.
2213         * arch/aarch32.c: New file.
2214         * arch/aarch32.h: New file.
2215         * arch/arm.c (arm_create_target_description)
2216         (arm_create_mprofile_target_description): New function.
2217         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2218         (arm_create_target_description)
2219         (arm_create_mprofile_target_description): New declaration.
2220         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2221         read_description functions.
2222         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2223         Likewise.
2224         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2225         * arm-tdep.c (tdesc_arm_list): New variable.
2226         (arm_register_g_packet_guesses): Call create description functions.
2227         (arm_read_description) (arm_read_mprofile_description): New
2228         function.
2229         * arm-tdep.h (arm_read_description)
2230         (arm_read_mprofile_description): Add declaration.
2231         * configure.tgt: Add new files.
2232
2233 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2234
2235         * top.c (new_ui_command): Open specified terminal just once.
2236
2237 2019-07-18  Tom Tromey  <tromey@adacore.com>
2238
2239         * symtab.c (main_name): Constify return type.
2240         * symfile.c (set_initial_language): Update.
2241         * symtab.h (main_name): Constify return type.
2242
2243 2019-07-17  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-winsource.c (tui_update_source_window)
2246         (tui_update_source_window_as_is)
2247         (tui_update_source_windows_with_line): Remove return.
2248         * tui/tui-disasm.c (tui_show_disassem)
2249         (tui_show_disassem_and_update_source): Remove return.
2250         * tui/tui.c (tui_reset): Remove return.
2251         * tui/tui-wingeneral.c
2252         (tui_check_and_display_highlight_if_needed): Remove return.
2253
2254 2019-07-17  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2257
2258 2019-07-17  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-winsource.h (struct tui_exec_info_window)
2261         (struct tui_source_window_base): Move from tui-data.h.
2262         * tui/tui-winsource.c: Move many method definitions from
2263         elsewhere.  Remove "structuring" comments.
2264         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2265         (tui_source_window_base::refresh_window): Move to
2266         tui-winsource.c.
2267         * tui/tui-win.c (tui_source_window_base::refresh_all)
2268         (tui_source_window_base::update_tab_width)
2269         (tui_source_window_base::set_new_height)
2270         (tui_source_window_base::do_make_visible_with_new_height): Move to
2271         tui-winsource.c.
2272         * tui/tui-source.h: Update.
2273         * tui/tui-source.c (tui_source_window_base::reset): Move to
2274         tui-winsource.c.
2275         * tui/tui-disasm.h: Update.
2276         * tui/tui-data.h (struct tui_exec_info_window): Move to
2277         tui-winsource.h.
2278         (struct tui_source_window_base): Likewise.
2279         * tui/tui-data.c (tui_source_window_base::clear_detail)
2280         (tui_source_window_base, ~tui_source_window_base): Move to
2281         tui-winsource.c.
2282
2283 2019-07-17  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-win.c (tui_resize_all)
2286         (tui_source_window_base::update_tab_width)
2287         (tui_adjust_win_heights): Update.
2288         (tui_win_info::make_invisible_and_set_new_height): Rename from
2289         make_invisible_and_set_new_height.
2290         * tui/tui-data.h (struct tui_win_info)
2291         <make_invisible_and_set_new_height>: New method.
2292
2293 2019-07-17  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui.c: Update.
2296         * tui/tui-source.h (struct tui_source_window): Move from
2297         tui-data.h.
2298         * tui/tui-layout.c: Update.
2299         * tui/tui-disasm.c: Update.
2300         * tui/tui-data.h (struct tui_source_window): Move to
2301         tui-source.h.
2302
2303 2019-07-17  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2306         tui-data.h.
2307         * tui/tui-data.h (struct tui_disasm_window): Move to
2308         tui-disasm.h.
2309
2310 2019-07-17  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-regs.h (struct tui_data_item_window): Move from
2313         tui-data.h.
2314         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2315         * tui/tui-data.h (struct tui_data_item_window): Move to
2316         tui-regs.h.
2317         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2318
2319 2019-07-17  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui.c: Update.
2322         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2323         (tui_cmd_window::max_height): Move to tui-command.c.
2324         * tui/tui-layout.c: Update.
2325         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2326         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2327         tui-command.c.
2328         * tui/tui-command.h (struct tui_cmd_window): Move from
2329         tui-data.h.
2330         * tui/tui-command.c: Remove "structuring" comments.
2331         (tui_cmd_window::clear_detail)
2332         (tui_cmd_window::do_make_visible_with_new_height)
2333         (tui_cmd_window::max_height): Move from elsewhere.
2334
2335 2019-07-17  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2338         Now static.
2339         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2340         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2341
2342 2019-07-17  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui.c: Update.
2345         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2346         tui-regs.c.
2347         * tui/tui-windata.h: Remove file.
2348         * tui/tui-windata.c: Remove file.
2349         * tui/tui-win.c (tui_data_window::set_new_height)
2350         (tui_data_window::do_make_visible_with_new_height): Move to
2351         tui-regs.c.
2352         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2353         * tui/tui-regs.c: Remove "structuring" comments.
2354         (tui_data_window::first_data_item_displayed)
2355         (tui_data_window::delete_data_content_windows)
2356         (tui_data_window::erase_data_content)
2357         (tui_data_window::display_all_data)
2358         (tui_data_window::refresh_all)
2359         (tui_data_window::do_scroll_vertical)
2360         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2361         (tui_data_window::do_make_visible_with_new_height)
2362         (tui_data_window::refresh_window): Move from elsewhere.
2363         (_initialize_tui_regs): Move to end of file.
2364         * tui/tui-layout.c: Update.
2365         * tui/tui-hooks.c: Update.
2366         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2367         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2368         tui-regs.c.
2369         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2370
2371 2019-07-17  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2374         seen.
2375
2376 2019-07-17  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-win.c (tui_source_window_base::set_new_height)
2379         (tui_source_window_base::do_make_visible_with_new_height): Use
2380         m_has_locator field directly.
2381         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2382         method.
2383         (struct tui_source_window_base) <has_locator>: Likewise.
2384
2385 2019-07-17  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2388         Don't declare.
2389         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2390         Remove.
2391         * tui/tui-win.c (tui_source_window_base::set_new_height)
2392         (tui_source_window_base::set_new_height)
2393         (make_invisible_and_set_new_height)
2394         (tui_source_window_base::do_make_visible_with_new_height)
2395         (tui_source_window_base::do_make_visible_with_new_height):
2396         Update.
2397         * tui/tui-layout.c (show_source_disasm_command, show_data)
2398         (show_source_or_disasm_and_command): Update.
2399         * tui/tui-layout.c (show_layout): Update.
2400
2401 2019-07-17  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-layout.c (make_data_window): Remove.
2404         (show_data): Unify creation and re-initialization cases.
2405
2406 2019-07-17  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-layout.c (make_source_window, make_disasm_window):
2409         Remove.
2410         (show_data): Unify creation and re-initialization cases.
2411
2412 2019-07-17  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-layout.c (make_command_window): Remove.
2415         (show_source_disasm_command, show_source_or_disasm_and_command):
2416         Unify creation and re-initialization cases.
2417
2418 2019-07-17  Tom Tromey  <tom@tromey.com>
2419
2420         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2421         creation and re-initialization cases.
2422
2423 2019-07-17  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-regs.c (tui_get_register): Return void.
2426
2427 2019-07-17  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2430         Simplify.
2431
2432 2019-07-17  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2435         resetting.
2436
2437 2019-07-17  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2440         * tui/tui-regs.c (tui_reg_layout): New function.
2441         (tui_show_registers, tui_reg_command): Use it.
2442         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2443         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2444         parameters.
2445         (tui_layout_command): Remove.
2446
2447 2019-07-17  Tom Tromey  <tom@tromey.com>
2448
2449         * tui/tui-layout.h (tui/tui-layout): Return void.
2450         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2451
2452 2019-07-17  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-layout.c (show_source_disasm_command, show_data):
2455         Update.
2456         (reset_locator): Remove.
2457         (show_source_or_disasm_and_command): Update.
2458
2459 2019-07-17  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-source.c (tui_source_window_base::reset): Remove
2462         win_type parameter.
2463         * tui/tui-layout.c (make_command_window, make_source_window)
2464         (make_disasm_window, make_data_window)
2465         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2466         (reset_locator, show_source_or_disasm_and_command): Update.
2467         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2468         win_type parameter.
2469         (struct tui_source_window_base) <reset>: Likewise.
2470
2471 2019-07-17  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-layout.c (show_source_disasm_command): Use
2474         reset_locator.
2475         (reset_locator): New function.
2476         (init_and_make_win): Remove.
2477         (show_source_or_disasm_and_command): Use reset_locator.
2478
2479 2019-07-17  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2482         condition.
2483         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2484         Remove condition.
2485         * tui/tui-source.c (tui_source_window_base::reset): New method.
2486         * tui/tui-layout.c (make_command_window): Don't call
2487         init_and_make_win.
2488         (make_source_window, make_disasm_window): Don't call
2489         make_source_or_disasm_window.
2490         (make_data_window): Don't call init_and_make_win.  Change calling
2491         convention.
2492         (show_source_disasm_command, show_data): Simplify.
2493         (make_source_or_disasm_window): Remove.
2494         (show_source_or_disasm_and_command): Simplify.
2495         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2496         (struct tui_source_window_base) <reset>: Likewise.
2497         <execution_info>: Remove initializer.
2498         * tui/tui-data.c (tui_source_window_base): Initialize
2499         execution_info.
2500
2501 2019-07-17  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2504         variable.
2505
2506 2019-07-17  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui.c (tui_rl_other_window): Update.
2509         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2510         superclass method first.  Always iterate over regs_content.
2511         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2512         method.
2513         * tui/tui-win.c (tui_set_focus_command): Update.
2514
2515 2019-07-17  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-win.c (tui_set_focus_command): Rename from
2518         tui_set_focus.  Call tui_enable.
2519         (tui_set_focus_command): Remove.
2520
2521 2019-07-17  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2524         refresh_window.
2525         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2526         touchwin.
2527         (tui_data_window::refresh_window): Call refresh_window on data
2528         items.  Always call superclass refresh_window.
2529         (tui_win_info::refresh): Remove.
2530         (tui_source_window_base::refresh_window): Update.
2531         (tui_refresh_all): Update.
2532         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2533         refresh_window.
2534         (show_source_or_disasm_and_command): Likewise.
2535         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2536         (struct tui_source_window_base) <refresh>: Likewise.
2537
2538 2019-07-17  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-winsource.c (tui_clear_source_content)
2541         (tui_show_source_content): Update.
2542         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2543         whether content is empty.
2544         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2545         Remove.
2546
2547 2019-07-17  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2550         window's contents.
2551         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2552         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2553
2554 2019-07-17  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2557         (struct tui_data_item_window): Update.
2558
2559 2019-07-17  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2562         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2563         defines.
2564
2565 2019-07-17  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-winsource.h (tui_erase_source_content)
2568         (tui_clear_source_content): Remove "display_prompt" parameter.
2569         * tui/tui-winsource.c (tui_update_source_window_as_is)
2570         (tui_update_source_windows_with_addr): Update.
2571         (tui_clear_source_content): Remove "display_prompt" parameter.
2572         (tui_erase_source_content): Likewise.  Simplify.
2573         (tui_show_source_content): Update.
2574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2575         * tui/tui-stack.c (tui_show_frame_info): Update.
2576         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2577         Remove defines.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2582         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2583         parameter.
2584         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2585         parameter.
2586
2587 2019-07-17  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-winsource.c (tui_clear_source_content)
2590         (tui_show_source_content, tui_show_exec_info_content)
2591         (tui_clear_exec_info_content): Update.
2592         * tui/tui-stack.c (tui_show_locator_content): Update.
2593         (tui_show_frame_info): Update.
2594         * tui/tui-source.h (tui_source_window): Don't declare.
2595         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2596         from tui_source_is_displayed.
2597         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2598         Remove field.
2599         (struct tui_source_window_base) <content_in_use>: New field.  Now
2600         bool.
2601         (struct tui_source_window) <showing_source_p>: New method.
2602         (TUI_SRC_WIN): Change cast.
2603         * tui/tui-data.c (tui_initialize_static_data): Update.
2604
2605 2019-07-17  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2608         location_matches_p.
2609         * tui/tui-source.c (tui_source_window::location_matches_p): New
2610         method.
2611         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2612         method.
2613         * tui/tui-data.h (struct tui_source_window_base)
2614         <location_matches_p>: New method.
2615         (struct tui_source_window, struct tui_disasm_window)
2616         <location_matches_p>: Likewise.
2617
2618 2019-07-17  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-win.c (tui_set_win_height_command): Rename from
2621         tui_set_win_height.
2622         (tui_set_win_height_command): Remove.
2623
2624 2019-07-17  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-source.c (tui_source_window): New constructor.  Add
2627         observer.
2628         (~tui_source_window): New destructor.
2629         (tui_source_window::style_changed): New method.
2630         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2631         (tui_attach_detach_observers): Update.
2632         * tui/tui-data.h (struct tui_source_window): Make constructor not
2633         inline.  Add destructor.
2634         (struct tui_source_window) <style_changed>: New method.
2635         <m_observable>: New member.
2636
2637 2019-07-17  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2640         * tui/tui-win.c (tui_resize_all): Fix typo.
2641
2642 2019-07-17  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2645         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2646         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2647         * tui/tui-win.c (window_name_completer): Use foreach.
2648         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2649         (update_tab_width): Likewise.
2650         * tui/tui-layout.c (show_layout): Update.
2651         * tui/tui-data.h (class tui_window_iterator): New.
2652         (struct all_tui_windows): New.
2653         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2654
2655 2019-07-17  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2658         parameter.  Don't reference globals.
2659         (tui_reg_command): Update.
2660
2661 2019-07-17  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-regs.c (tui_show_registers): Simplify.
2664
2665 2019-07-17  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-regs.c (tui_show_registers): Update.
2668         (tui_show_register_group): Add win_info parameter.
2669
2670 2019-07-17  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2673         Rename from tui_display_reg_element_at_line.
2674         (tui_data_window::display_registers_from_line): Update.
2675         * tui/tui-data.h (struct tui_data_window)
2676         <display_reg_element_at_line>: New method.
2677
2678 2019-07-17  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-regs.h (tui_display_registers_from)
2681         (tui_display_registers_from_line): Don't declare.
2682         * tui/tui-windata.c (tui_data_window::display_all_data)
2683         (tui_data_window::refresh_all)
2684         (tui_data_window::do_scroll_vertical): Update.
2685         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2686         from tui_display_registers_from.
2687         (tui_display_reg_element_at_line): Update.
2688         (tui_data_window::display_registers_from_line): Rename from
2689         tui_display_registers_from_line.
2690         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2691         display_registers_from_line>: New methods.
2692
2693 2019-07-17  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2696         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2697         from tui_erase_data_content.
2698         (tui_data_window::display_all_data)
2699         (tui_data_window::refresh_all)
2700         (tui_data_window::do_scroll_vertical): Update.
2701         * tui/tui-regs.c (tui_show_registers): Update.
2702         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2703         New method.
2704
2705 2019-07-17  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2708         declare.
2709         * tui/tui-windata.c
2710         (tui_data_window::delete_data_content_windows): Rename from
2711         tui_delete_data_content_windows.
2712         (tui_data_window::display_all_data)
2713         (tui_data_window::do_scroll_vertical): Update.
2714         * tui/tui-data.h (struct tui_data_window)
2715         <delete_data_content_windows>: New method.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2720         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2721
2722 2019-07-17  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2725         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2726         from tui_display_all_data.
2727         * tui/tui-win.c
2728         (tui_data_window::do_make_visible_with_new_height): Update.
2729         * tui/tui-regs.c (tui_show_registers): Update.
2730         * tui/tui-layout.c (tui_set_layout): Update.
2731         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2732         method.
2733
2734 2019-07-17  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2737         * tui/tui-windata.c (tui_display_data_from): Remove.
2738         (tui_data_window::refresh_all): Update.
2739
2740 2019-07-17  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2743         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2744         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2745         tui_display_registers_from_line.
2746         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2747         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2748         "force_display" parameter.
2749
2750 2019-07-17  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2753         declare.
2754         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2755         Rename from tui_first_reg_element_no_inline.
2756         (tui_display_reg_element_at_line)
2757         (tui_display_registers_from_line): Update.
2758         * tui/tui-data.h (struct tui_data_window)
2759         <first_reg_element_no_inline>: New method.
2760
2761 2019-07-17  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-windata.c (tui_display_data_from)
2764         (tui_data_window::do_scroll_vertical): Update.
2765         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2766         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2767         Rename from tui_line_from_reg_element_no.
2768         (tui_display_registers_from_line): Update.
2769         * tui/tui-data.h (struct tui_data_window)
2770         <line_from_reg_element_no>: New method.
2771
2772 2019-07-17  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2775         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2776         tui_last_regs_line_no.
2777         (tui_display_reg_element_at_line)
2778         (tui_display_registers_from_line): Update.
2779         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2780         method.
2781
2782 2019-07-17  Tom Tromey  <tom@tromey.com>
2783
2784         PR tui/24722:
2785         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2786         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2787         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2788         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2789         (tui_update_breakpoint_info): Likewise.
2790         * tui/tui-hooks.c (tui_event_create_breakpoint)
2791         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2792         Update.
2793
2794 2019-07-17  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2797
2798 2019-07-17  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-winsource.c (tui_update_source_window_as_is)
2801         (tui_update_source_windows_with_addr): Update.
2802         * tui/tui-source.h (tui_set_source_content)
2803         (tui_show_symtab_source): Add "win_info" parameter.
2804         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2805         parameter.
2806         (tui_show_symtab_source): Likewise.
2807
2808 2019-07-17  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-wingeneral.c
2811         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2812
2813 2019-07-17  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2816         (struct tui_cmd_window) <can_scroll>: New method.
2817         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2818         method.
2819
2820 2019-07-17  Tom Tromey  <tromey@adacore.com>
2821
2822         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2823         do_field_signed>: Rename.  Change type of "value".
2824         * ui-out.c (ui_out::field_signed): Rename from field_int.
2825         Change type of "value".
2826         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2827         type of "value".
2828         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2829         do_field_int.  Change type of "value".
2830         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2831         do_field_int.  Change type of "value".
2832         * tracepoint.c (trace_status_mi, tfind_1)
2833         (print_one_static_tracepoint_marker): Update.
2834         * thread.c (print_thread_info_1, print_selected_thread_frame):
2835         Update.
2836         * stack.c (print_frame, print_frame_info): Update.
2837         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2838         Update.
2839         * source.c (print_source_lines_base): Update.
2840         * skip.c (info_skip_command): Update.
2841         * record-btrace.c (btrace_ui_out_decode_error)
2842         (btrace_call_history_src_line): Update.
2843         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2844         Update.
2845         * progspace.c (print_program_space): Update.
2846         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2847         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2848         do_field_int.  Change type of "value".
2849         * mi/mi-out.c (mi_ui_out::do_table_begin)
2850         (mi_ui_out::do_table_header): Update.
2851         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2852         type of "value".
2853         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2854         (mi_cmd_data_list_changed_registers, output_register)
2855         (mi_cmd_data_read_memory, mi_load_progress)
2856         (mi_cmd_trace_frame_collected): Update.
2857         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2858         Update.
2859         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2860         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2861         (mi_cmd_var_list_children, varobj_update_one): Update.
2862         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2863         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2865         * inferior.c (print_inferior): Update.
2866         * gdb_bfd.c (print_one_bfd): Update.
2867         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2868         Update.
2869         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2870         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2871         do_field_int.  Change type of "value".
2872         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2873         do_field_int.  Change type of "value".
2874         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2875         (print_one_breakpoint_location, print_it_catch_fork)
2876         (print_one_catch_fork, print_it_catch_vfork)
2877         (print_one_catch_vfork, print_it_catch_solib)
2878         (print_it_catch_exec, print_it_ranged_breakpoint)
2879         (print_mention_watchpoint, print_mention_masked_watchpoint)
2880         (bkpt_print_it, update_static_tracepoint): Update.
2881         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2882         * break-catch-syscall.c (print_it_catch_syscall): Update.
2883         * ada-tasks.c (print_ada_task_info): Update.
2884         * ada-lang.c (print_it_exception, print_mention_exception):
2885         Update.
2886
2887 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         PR breakpoints/24541
2890         * gdbarch.c: Regenerate.
2891         * gdbarch.h: Regenerate.
2892         * gdbarch.sh: Adjust return type and parameter types for
2893         'stap_adjust_register'.
2894         (i386_stap_adjust_register): Adjust signature and return new
2895         register name.
2896         * stap-probe.c (stap_parse_register_operand): Adjust use of
2897         'gdbarch_stap_adjust_register'.
2898
2899 2019-07-17  Tom Tromey  <tromey@adacore.com>
2900
2901         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2902         declare VEC.
2903         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2904         std::vector.
2905         (struct s390_process_info): Add initializers.
2906         (s390_add_process): Use new.
2907         (s390_linux_nat_target::low_forget_process): Use delete.
2908         (s390_linux_nat_target::low_new_fork)
2909         (s390_linux_nat_target::stopped_by_watchpoint)
2910         (s390_linux_nat_target::low_prepare_to_resume)
2911         (s390_linux_nat_target::insert_watchpoint)
2912         (s390_linux_nat_target::insert_hw_breakpoint)
2913         (s390_linux_nat_target::remove_watchpoint)
2914         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2915
2916 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2917
2918         * aarch64-fbsd-nat.c: Include regcache.h.
2919         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2920         argument.
2921         (aarch64_fbsd_nat_target::fetch_registers)
2922         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2923         variable.
2924         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2925
2926 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2927
2928         * fbsd-nat.c: Include gdbarch.h.
2929
2930 2019-07-15  Tom Tromey  <tromey@adacore.com>
2931
2932         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2933
2934 2019-07-15  Tom Tromey  <tromey@adacore.com>
2935
2936         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2937         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2938         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2939         * cli-out.c (cli_ui_out::do_field_int): New method.
2940         * ui-out.c (ui_out::field_unsigned): New method.
2941         * symfile.c (generic_load): Use field_unsigned.
2942         (print_transfer_performance): Likewise.
2943         * record-btrace.c (ui_out_field_uint): Remove.
2944         (btrace_call_history_insn_range, btrace_call_history): Use
2945         field_unsigned.
2946         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2947         field_unsigned.
2948         * ui-out.h (class ui_out) <field_unsigned>: New method.
2949         <do_field_unsigned>: Likewise.
2950
2951 2019-07-15  Tom Tromey  <tromey@adacore.com>
2952
2953         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2954         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2955         * target.c (flash_erase_command): Use field_string.
2956         * infrun.c (print_signal_received_reason): Use field_string.
2957         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2958         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2959         field_string.
2960         * ada-tasks.c (print_ada_task_info): Use field_string.
2961
2962 2019-07-15  Tom Tromey  <tromey@adacore.com>
2963
2964         * target.c (flash_erase_command): Use field_core_addr.
2965         * symfile.c (generic_load): Use field_core_addr.
2966         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2967         Use field_core_addr.
2968         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2969         field_core_addr.
2970
2971 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2972
2973         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2974         value if its desired type is smaller than a CORE_ADDR and signed.
2975
2976 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2979         of changes to field names, and use new is_reference field to
2980         decide if a property is a reference or not.
2981         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2982         field.
2983         (struct dwarf2_property_baton): Update header comment, rename
2984         'referenced_type' to 'property_type' and update comments.
2985         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2986         default property type, store in property baton, update to take
2987         accound of renamed field.
2988         (read_func_scope): Update call to attr_to_dynamic_prop.
2989         (read_array_type): Likewise.
2990         (dwarf2_per_cu_addr_sized_int_type): New function.
2991         (read_subrange_index_type): Move type finding code to
2992         dwarf2_per_cu_addr_sized_int_type.
2993         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2994         (dwarf2_per_cu_addr_type): New function.
2995         (set_die_type): Update calls to attr_to_dynamic_prop.
2996
2997 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * dwarf2read.c (read_subrange_index_type): New function.
3000         (read_subrange_type): Move code into new function and call it.
3001         * gdbtypes.c (create_range_type): Add some asserts.
3002
3003 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3006         update return statements.
3007         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3008         declaration, and update comment to match.
3009         * gdbtypes.c (resolve_dynamic_array): Update call to
3010         dwarf2_evaluate_property to match new return type.
3011
3012 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * valarith.c (value_subscripted_rvalue): Change lowerbound
3015         parameter type from int to LONGEST.
3016         * value.h (value_subscripted_rvalue): Likewise in declaration.
3017
3018 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * cli/cli-utils.c (info_print_command_completer): New function.
3021         * cli/cli-utils.h: Add 'completer.h' include, and forward
3022         declaration for 'struct cmd_list_element'.
3023         (info_print_command_completer): Declare.
3024         * stack.c (_initialize_stack): Add completer for 'info locals' and
3025         'info args'.
3026         * symtab.c (_initialize_symtab): Add completer for 'info
3027         variables' and 'info functions'.
3028         * NEWS: Mention completion for additional info commands.
3029
3030 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * cli/cli-utils.c (extract_info_print_args): Delete.
3033         (extract_arg_maybe_quoted): Delete.
3034         (info_print_options_defs): New variable.
3035         (make_info_print_options_def_group): New function.
3036         (extract_info_print_options): Define new function.
3037         * cli/cli-utils.h (extract_info_print_args): Delete.
3038         (struct info_print_options): New structure.
3039         (extract_info_print_options): Declare new function.
3040         * stack.c (info_locals_command): Update to use new
3041         extract_info_print_options, also add a header comment.
3042         (info_args_command): Likewise.
3043         * symtab.c (info_variables_command): Likewise.
3044         (info_functions_command): Likewise.
3045
3046 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3049         to extract string arguments.
3050         * common/common-utils.c (extract_string_maybe_quoted): New function.
3051         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3052
3053 2019-07-11  Tom Tromey  <tromey@adacore.com>
3054
3055         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3056         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3057         * top.h (gdbinit): Don't declare.
3058         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3059         into...
3060         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3061         * top.c (gdb_init): Don't call init_cli_cmds.
3062         (gdbinit): Remove.
3063         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3064
3065 2019-07-11  Tom Tromey  <tromey@adacore.com>
3066
3067         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3068         after it has been moved.
3069
3070 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3071
3072         * valops.c (value_must_coerce_to_target): Change return type to
3073         bool.
3074         * value.h (value_must_coerce_to_target): Likewise.
3075
3076 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * breakpoint.c (is_hardware_watchpoint): Remove
3079         forward-declaration.
3080         (is_masked_watchpoint): Change return type to bool.
3081         (is_tracepoint): Likewise.
3082         (is_breakpoint): Likewise.
3083         (is_hardware_watchpoint): Likewise.
3084         (is_watchpoint): Likewise.
3085         (is_no_memory_software_watchpoint): Likewise.
3086         (is_catchpoint): Likewise.
3087         (breakpoint_1): Make FILTER parameter's return type bool.
3088         is_masked_watchpoint): Change return type to bool.
3089         (save_breakpoints): Make FILTER parameter's return type bool.
3090         * breakpoint.h (is_breakpoint): Change return type to bool.
3091         (is_watchpoint): Likewise.
3092         (is_catchpoint): Likewise.
3093         (is_tracepoint): Likewise.
3094
3095 2019-07-10  Tom Tromey  <tom@tromey.com>
3096
3097         * defs.h: Don't include gdbarch.h.
3098         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3099         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3100         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3101         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3102         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3103         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3104         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3105         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3106         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3107         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3108         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3109         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3110         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3111         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3112         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3113         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3114         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3115         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3116         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3117         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3118         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3119         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3120         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3121         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3122         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3123         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3124         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3125
3126 2019-07-10  Tom Tromey  <tromey@adacore.com>
3127
3128         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3129         * breakpoint.c (init_ada_exception_breakpoint): Register as
3130         bp_catchpoint.
3131         (print_one_breakpoint_location, print_one_breakpoint): Use
3132         is_ada_exception_catchpoint.
3133         * ada-lang.c (class ada_catchpoint_location): Pass
3134         bp_loc_software_breakpoint to bp_location constructor.
3135         (is_ada_exception_catchpoint): New function.
3136
3137 2019-07-10  Tom Tromey  <tromey@adacore.com>
3138
3139         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3140         VEC.
3141         (struct arm_exidx_entry): New method operator<.
3142         (struct arm_exidx_data) <section_maps>: Change type.
3143         (arm_exidx_data_free): Remove.
3144         (arm_exidx_data_key): Change type.  Move lower.
3145         (arm_exidx_new_objfile): Update.
3146         (arm_compare_exidx_entries): Remove.
3147         (arm_find_exidx_entry, _initialize_arm_tdep)
3148
3149 2019-07-10  Tom Tromey  <tromey@adacore.com>
3150
3151         * solib-spu.c (ocl_program_data_key): Change type.
3152         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3153         Update.
3154
3155 2019-07-10  Tom Tromey  <tromey@adacore.com>
3156
3157         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3158         (struct solib_aix_inferior_data) <library_list>: Change type.
3159         (solib_aix_inferior_data_handle): Change type.
3160         (get_solib_aix_inferior_data): Update.
3161         (solib_aix_free_library_list): Remove.
3162         (library_list_start_library): Update.
3163         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3164         return type.
3165         (solib_aix_get_library_list)
3166         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3167         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3168
3169 2019-07-10  Tom Tromey  <tromey@adacore.com>
3170
3171         * solib-dsbt.c (struct dsbt_info): Add initializers.
3172         (solib_dsbt_pspace_data): Change type.
3173         (dsbt_pspace_data_cleanup): Remove.
3174         (get_dsbt_info, _initialize_dsbt_solib): Update.
3175
3176 2019-07-10  Tom Tromey  <tromey@adacore.com>
3177
3178         * spu-tdep.c (spu_overlay_data): Change type.
3179         (spu_get_overlay_table, spu_overlay_new_objfile)
3180         (_initialize_spu_tdep): Update.
3181
3182 2019-07-10  Tom Tromey  <tromey@adacore.com>
3183
3184         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3185         destructor.
3186         (dbx_objfile_data_key): Change type and declare later.
3187         (DBX_SYMFILE_INFO): Rewrite.
3188         * dbxread.c (dbx_objfile_data_key): Change type.
3189         (dbx_symfile_init): Update.
3190         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3191         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3192         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3193
3194 2019-07-10  Tom Tromey  <tromey@adacore.com>
3195
3196         * jit.c (jit_program_space_key): Change type.  Move lower.
3197         (get_jit_program_space_data): Update.
3198         (jit_program_space_data_cleanup): Remove.
3199         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3200         Update.
3201         (struct jit_program_space_data): Add initializers.
3202
3203 2019-07-10  Tom Tromey  <tromey@adacore.com>
3204
3205         * solib-darwin.c (struct darwin_info): Add initializers.
3206         (solib_darwin_pspace_data): Change type.
3207         (darwin_pspace_data_cleanup): Remove.
3208         (get_darwin_info, _initialize_darwin_solib): Update.
3209
3210 2019-07-10  Tom Tromey  <tromey@adacore.com>
3211
3212         * remote-sim.c (struct sim_inferior_data): Add initializers,
3213         constructor, and destructor.
3214         (sim_inferior_data_key): Change type.  Move lower.
3215         (check_for_duplicate_sim_descriptor): Update.
3216         (get_sim_inferior_data): Use new.  Update.
3217         (~sim_inferior_data_cleanup): Rename from
3218         sim_inferior_data_cleanup.  Simplify.
3219         (gdbsim_close_inferior, simulator_command)
3220         (sim_command_completer, _initialize_remote_sim): Update.
3221         (next_pid, INITIAL_PID): Move earlier.
3222
3223 2019-07-10  Tom Tromey  <tromey@adacore.com>
3224
3225         * python/python-internal.h (create_thread_object): Return
3226         gdbpy_ref.
3227         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3228         * python/py-inferior.c (struct threadlist_entry): Add
3229         constructor.
3230         <thread_obj>: Now a gdbpy_ref.
3231         (thread_to_thread_object): Update.
3232         (add_thread_object): Use new.
3233         (delete_thread_object): Use delete.
3234         (infpy_threads): Update.
3235         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3236         GIL.
3237
3238 2019-07-10  Tom Tromey  <tromey@adacore.com>
3239
3240         * valops.c (value_cast): Specialize error message for Ada.
3241
3242 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3243
3244         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3245
3246 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3247
3248         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3249         bpstat_should_step): Return bool, adjust comments.
3250         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3251         bpstat_should_step): Likewise.
3252
3253 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3254
3255         * features/Makefile: Use feature target descriptions for Arm.
3256         * features/arm/arm-core.c: Generate new file.
3257         * features/arm/arm-fpa.c: Likewise.
3258         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3259         * features/arm/arm-m-profile.c: Likewise.
3260         * features/arm/arm-vfpv2.c: Likewise.
3261         * features/arm/arm-vfpv3.c: Likewise.
3262         * features/arm/xscale-iwmmxt.c: Likewise.
3263         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3264
3265 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3268         ptrace earlier.
3269
3270 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3271
3272         * features/aarch64-pauth.c: Regenerate.
3273
3274 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3275
3276         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3277         bool.
3278         (bpstat_what): Use false instead of 0.
3279
3280 2019-07-09  Pedro Alves  <palves@redhat.com>
3281
3282         * break-catch-throw.c (is_exception_catchpoint): New.
3283         * breakpoint.c (print_one_breakpoint_location): New parameter
3284         'raw_loc'.  Handle it.  Use
3285         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3286         looking at the breakpoint's type.
3287         (print_one_breakpoint): If handling "maint info breakpoints", also
3288         print locations of exception catchpoints.
3289         * breakpoint.h (is_exception_catchpoint): Declare.
3290
3291 2019-07-09  Pedro Alves  <palves@redhat.com>
3292
3293         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3294         "addr" field.
3295         (allocate_location_exception_catchpoint): New.
3296         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3297         (initialize_throw_catchpoint_ops): Install
3298         allocate_location_exception_catchpoint as allocate_location
3299         method.
3300         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3301         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3302         bp_loc_other.
3303         (breakpoint_address_is_meaningful): Delete.
3304         (bl_address_is_meaningful): New.
3305         (breakpoint_locations_match): Adjust comment.
3306         (bp_location_from_bp_type): New, factored out of...
3307         (bp_location::bp_location(breakpoint *)): ... this.
3308         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3309         factored out of...
3310         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3311         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3312         breakpoint_address_is_meaningful.
3313         (bp_locations_compare): Adjust comment.
3314         (update_global_location_list): Use bl_address_is_meaningful
3315         instead of breakpoint_address_is_meaningful.
3316         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3317         explicit.
3318         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3319         * python/py-breakpoint.c (bppy_get_location): No longer check
3320         whether location is null.
3321
3322 2019-07-09  Pedro Alves  <palves@redhat.com>
3323
3324         PR c++/15468
3325         * breakpoint.c (print_one_breakpoint_location): Remove
3326         single-location assert.
3327
3328 2019-07-09  Tom Tromey  <tom@tromey.com>
3329
3330         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3331         * configure: Rebuild.
3332         * configure.ac: Change common to gdbsupport.
3333         * gdbsupport: Rename from common.
3334         * acinclude.m4: Change common to gdbsupport.
3335         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3336         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3337         gdbsupport.
3338         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3339         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3340         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3341         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3342         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3343         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3344         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3345         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3346         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3347         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3348         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3349         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3350         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3351         coff-pe-read.c, command.h, compile/compile-c-support.c,
3352         compile/compile-c.h, compile/compile-cplus-symbols.c,
3353         compile/compile-cplus-types.c, compile/compile-cplus.h,
3354         compile/compile-loc2c.c, compile/compile.c, completer.c,
3355         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3356         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3357         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3358         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3359         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3360         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3361         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3362         features/aarch64-core.c, features/aarch64-fpu.c,
3363         features/aarch64-pauth.c, features/aarch64-sve.c,
3364         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3365         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3366         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3367         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3368         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3369         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3370         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3371         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3372         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3373         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3374         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3375         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3376         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3377         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3378         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3379         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3380         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3381         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3382         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3383         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3384         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3385         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3386         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3387         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3388         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3389         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3390         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3391         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3392         minsyms.c, mips-linux-tdep.c, namespace.h,
3393         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3394         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3395         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3396         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3397         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3398         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3399         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3400         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3401         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3402         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3403         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3404         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3405         procfs.c, producer.c, progspace.h, psymtab.h,
3406         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3407         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3408         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3409         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3410         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3411         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3412         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3413         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3414         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3415         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3416         target-memory.c, target.c, target.h, target/waitstatus.c,
3417         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3418         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3419         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3420         unittests/array-view-selftests.c,
3421         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3422         unittests/common-utils-selftests.c,
3423         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3424         unittests/format_pieces-selftests.c,
3425         unittests/function-view-selftests.c,
3426         unittests/lookup_name_info-selftests.c,
3427         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3428         unittests/mkdir-recursive-selftests.c,
3429         unittests/observable-selftests.c,
3430         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3431         unittests/parse-connection-spec-selftests.c,
3432         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3433         unittests/scoped_fd-selftests.c,
3434         unittests/scoped_mmap-selftests.c,
3435         unittests/scoped_restore-selftests.c,
3436         unittests/string_view-selftests.c, unittests/style-selftests.c,
3437         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3438         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3439         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3440         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3441         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3442         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3443
3444 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3447         bool value.
3448         (decode_digits_ordinary): Set explicit_line field in sal.
3449         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3450         symtab_and_line that was set on an explicit line number in
3451         assembler code.  Do always update the recorded symtab and line if
3452         we do skip the prologue.
3453
3454 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * breakpoint.c (set_breakpoint_location_function): Remove
3457         explicit_loc parameter.
3458         (momentary_breakpoint_from_master): Update call to
3459         set_breakpoint_location_function.
3460         (add_location_to_breakpoint): Likewise.
3461
3462 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3465         required features based on default bfd type when no specific bfd
3466         is present.
3467
3468 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3469
3470         * NEWS: Mention that GDB printf and eval commands can now print
3471         C-style and Ada-style convenience var strings without
3472         calling the inferior.
3473         * printcmd.c (printf_c_string): Locally print GDB internal var
3474         instead of transiting via the inferior.
3475         (printf_wide_c_string): Likewise.
3476
3477 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3478
3479         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3480
3481 2019-07-04  Tom Tromey  <tom@tromey.com>
3482
3483         PR tui/24724:
3484         * tui/tui-winsource.c (tui_clear_source_content): Update.
3485         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3486         (tui_update_breakpoint_info): Update.
3487         (tui_set_exec_info_content): Update.
3488         * tui/tui-source.c (tui_set_source_content_nil): Update.
3489         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3490         has_break.
3491         * tui/tui-data.h (enum tui_bp_flag): New.
3492         (tui_bp_flags): New enum flags type.
3493         (struct tui_source_element) <break_mode>: Change type.  Rename
3494         from has_break.
3495         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3496         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3497         constants.
3498         * tui/tui-winsource.h: Fix comment.
3499
3500 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3501
3502         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3503         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3504         (store_fpregs_to_thread)
3505         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3506         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3507         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3508         (IWMMXT_REGS_SIZE): Add define.
3509         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3510         (fetch_vfp_regs, store_vfp_regs)
3511         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3512         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3513
3514 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3517         defines.
3518         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3519         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3520         (ARM_INT_REGISTER_SIZE): ...to this.
3521         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3522         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3523         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3524         (arm_linux_collect_gregset, supply_nwfpe_register)
3525         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3526         defines.
3527         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3528         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3529         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3530         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3531         (arm_return_in_memory, arm_store_return_value)
3532         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3533         (arm_record_ld_st_multiple): Likewise.
3534         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3535         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3536
3537 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3538
3539         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3540         AARCH64_DISPLACED_MODIFIED_INSNS.
3541         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3542         (aarch64_displaced_step_copy_insn): Likewise.
3543         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3544         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3545         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3546         ARM_DISPLACED_MODIFIED_INSNS.
3547         * arm-tdep.c (arm_gdbarch_init): Likewise.
3548         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3549         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3550         (struct arm_displaced_step_closure): Use
3551         ARM_DISPLACED_MODIFIED_INSNS.
3552
3553 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3554
3555         * features/Makefile: Remove unused xml files.
3556         * features/aarch64.xml: Remove.
3557         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3558         * features/i386/amd64-avx-avx512.xml: Remove.
3559         * features/i386/amd64-avx-linux.xml: Remove.
3560         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3561         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3562         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3563         * features/i386/amd64-avx-mpx.xml: Remove.
3564         * features/i386/amd64-avx.xml: Remove.
3565         * features/i386/amd64-linux.xml: Remove.
3566         * features/i386/amd64-mpx-linux.xml: Remove.
3567         * features/i386/amd64-mpx.xml: Remove.
3568         * features/i386/amd64.xml: Remove.
3569         * features/i386/i386-avx-avx512-linux.xml: Remove.
3570         * features/i386/i386-avx-avx512.xml: Remove.
3571         * features/i386/i386-avx-linux.xml: Remove.
3572         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3573         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3574         * features/i386/i386-avx-mpx-linux.xml: Remove.
3575         * features/i386/i386-avx-mpx.xml: Remove.
3576         * features/i386/i386-avx.xml: Remove.
3577         * features/i386/i386-linux.xml: Remove.
3578         * features/i386/i386-mmx-linux.xml: Remove.
3579         * features/i386/i386-mmx.xml: Remove.
3580         * features/i386/i386-mpx-linux.xml: Remove.
3581         * features/i386/i386-mpx.xml: Remove.
3582         * features/i386/i386.xml: Remove.
3583         * features/i386/x32-avx-avx512-linux.xml: Remove.
3584         * features/i386/x32-avx-linux.xml: Remove.
3585         * features/i386/x32-linux.xml: Remove.
3586
3587 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3588
3589         * regformats/aarch64.dat: Remove.
3590         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3591         * regformats/i386/amd64-avx-linux.dat: Remove.
3592         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3593         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3594         * regformats/i386/amd64-linux.dat: Remove.
3595         * regformats/i386/amd64-mpx-linux.dat: Remove.
3596         * regformats/i386/amd64.dat: Remove.
3597         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3598         * regformats/i386/i386-avx-linux.dat: Remove.
3599         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3600         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3601         * regformats/i386/i386-linux.dat: Remove.
3602         * regformats/i386/i386-mmx-linux.dat: Remove.
3603         * regformats/i386/i386-mpx-linux.dat: Remove.
3604         * regformats/i386/i386.dat: Remove.
3605         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3606         * regformats/i386/x32-avx-linux.dat: Remove.
3607         * regformats/i386/x32-linux.dat: Remove.
3608
3609 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3610
3611         * aarch64-tdep.c: Remove xml self tests.
3612         * amd64-linux-tdep.c: Likewise.
3613         * amd64-tdep.c: Likewise.
3614         * i386-linux-tdep.c: Likewise.
3615         * i386-tdep.c: Likewise.
3616
3617 2019-07-03  Pedro Alves  <palves@redhat.com>
3618
3619         PR cli/24732
3620         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3621         (pipe_cmd_option_defs): New.
3622         (make_pipe_cmd_options_def_group): New.
3623         (pipe_command): Use gdb::option::process_options.
3624         (pipe_command_completer): New function.
3625         (_initialize_cli_cmds): Install completer for "pipe" command.
3626
3627 2019-07-03  Pedro Alves  <palves@redhat.com>
3628
3629         * cli/cli-option.c (union option_value) <string>: New field.
3630         (struct option_def_and_value): Add ctor, move ctor, dtor and
3631         use DISABLE_COPY_AND_ASSIGN.
3632         (option_def_and_value::clear_value): New.
3633         (parse_option, save_option_value_in_ctx, get_val_type_str)
3634         (add_setshow_cmds_for_options): Handle var_string.
3635         * cli-option.h (union option_def::var_address) <string>: New
3636         field.
3637         (struct string_option_def): New.
3638         * maint-test-options.c (struct test_options_opts): Add default
3639         ctor and use DISABLE_COPY_AND_ASSIGN.
3640         <string_opt>: New field.
3641         (test_options_opts::~test_options_opts): New.
3642         (test_options_opts::dump): Also dump "-string".
3643         (test_options_option_defs): Install "string.
3644
3645 2019-07-03  Pedro Alves  <palves@redhat.com>
3646
3647         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3648         option_value with a null enumeration.
3649         (complete_options): Save the option values in the context.
3650         (save_option_value_in_ctx): New, factored out from ...
3651         (process_options): ... here.
3652         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3653         of the function.
3654         * maint-test-options.c (test_options_opts::dump): New, factored
3655         out from ...
3656         (maintenance_test_options_command_mode): ... here.
3657         (maintenance_test_options_command_completion_result): Delete.
3658         (maintenance_test_options_command_completion_text): Update
3659         comment.
3660         (maintenance_show_test_options_completion_result): Change
3661         prototype.  Just print
3662         maintenance_test_options_command_completion_text.
3663         (save_completion_result): New.
3664         (maintenance_test_options_completer_mode): Pass options context to
3665         complete_options, and then save a dump.
3666         (_initialize_maint_test_options): Use add_cmd to install "maint
3667         show test-options-completion-result".
3668
3669 2019-07-03  Pedro Alves  <palves@redhat.com>
3670
3671         * NEWS (New commands): Mention "with" and "maint with".
3672         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3673         (with_command, with_command_completer): New.
3674         (pipe_command): Adjust to new repeat_previous
3675         interface.
3676         (_initialize_cli_cmds): Install the "with" command and its "w"
3677         alias.
3678         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3679         declarations.
3680         * cli/cli-setshow.c (parse_cli_var_uinteger)
3681         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3682         argument strings for all var_types.
3683         (get_setshow_command_value_string): New, factored out from ...
3684         (do_show_command): ... this.
3685         * cli/cli-setshow.h: Include <string>.
3686         (get_setshow_command_value_string): Declare.
3687         * command.h (repeat_previous): Now returns const char *.  Adjust
3688         comment.
3689         * maint.c: Include "cli/cli-cmds.h".
3690         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3691         (_initialize_maint_cmds): Register the "maintenance with" command.
3692         * top.c (repeat_previous): Move bits from pipe_command here:
3693         Return the saved command line, if any; error out if there's no
3694         command to relaunch.
3695
3696 2019-07-03  Pedro Alves  <palves@redhat.com>
3697
3698         * NEWS (New commands): Mention "maint set/show test-settings"
3699         instead of "maint test-settings".
3700         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3701         (maintenance_test_settings_set_list): Rename to ...
3702         (maintenance_set_test_settings_list): ... this.
3703         (maintenance_test_settings_show_list): Rename to  ...
3704         (maintenance_show_test_settings_list): ... this.
3705         (maintenance_test_settings_cmd): Delete.
3706         (maintenance_test_settings_set_cmd): ...
3707         (maintenance_set_test_settings_cmd): ... this.
3708         (maintenance_test_settings_show_cmd): ...
3709         (maintenance_show_test_settings_cmd): ... this.
3710         (maintenance_test_settings_show_value_cmd):
3711         (maintenance_show_test_settings_value_cmd): ... this.
3712         (_initialize_maint_test_settings): No longer install the "maint
3713         test-settings" prefix command.  Rename "maint test-settings set"
3714         to "maint set test-settings", and "maint test-settings show" to
3715         "maint show test-settings".  Adjust all subcommands.
3716
3717 2019-07-03  Pedro Alves  <palves@redhat.com>
3718
3719         * maint-test-settings.c: Fix file's intro comment.  Replace all
3720         references to "test-options" with references to "test-settings",
3721         in comments.
3722
3723 2019-07-03  Pedro Alves  <palves@redhat.com>
3724
3725         * maint-test-settings.c (maintenance_test_settings_xxx)
3726         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3727         New.
3728         (maintenance_test_settings_enums): Use them.
3729         (maintenance_test_settings_enum): Default to
3730         maintenance_test_settings_xxx.
3731         (_initialize_maint_test_settings): Initialize
3732         MAINTENANCE_TEST_SETTINGS_FILENAME.
3733
3734 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3735
3736         * breakpoint.h (remove_breakpoints_inf): Change return type to
3737         void, move function documentation here.
3738         * breakpoint.c (remove_breakpoints_inf): Change return type to
3739         void, move function documentation to header.
3740
3741 2019-07-02  Pedro Alves  <palves@redhat.com>
3742
3743         * NEWS (Completion improvements): Mention "info threads".
3744         * thread.c (struct info_threads_opts, info_threads_option_defs)
3745         (make_info_threads_options_def_group): New.
3746         (info_threads_command): Use gdb::option::process_options.
3747         (info_threads_command_completer): New.
3748         (_initialize_thread): Use gdb::option::build_help to build the
3749         help text for "info threads".
3750
3751 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3752
3753         * defs.h (generic_load): Move from here...
3754         * symfile.h (generic_load): ... to here.  Rename name parameter
3755         to args.
3756         * symfile.c (generic_load): Add comment.
3757
3758 2019-07-01  Tom Tromey  <tromey@adacore.com>
3759
3760         * dwarf2read.c
3761         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3762         declaration of without_params.  Fix formatting.
3763
3764 2019-07-01  Tom Tromey  <tromey@adacore.com>
3765
3766         * ada-exp.y (find_primitive_type): Update.
3767         * ada-lang.h (ada_lookup_symbol): Update.
3768         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3769         parameter.
3770         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3771
3772 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3773
3774         PR breakpoints/24541
3775         * gdbarch.c: Regenerate.
3776         * gdbarch.h: Regenerate.
3777         * gdbarch.sh: Add 'stap_adjust_register'.
3778         * i386-tdep.c: Include '<unordered_set>'.
3779         (i386_stap_adjust_register): New function.
3780         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3781         * stap-probe.c (stap_parse_register_operand): Call
3782         'gdbarch_stap_adjust_register'.
3783
3784 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3785
3786         PR python/24742
3787         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3788         * python/python.c (do_start_initialization): Use 'xmalloc'
3789         instead of 'PyMem_Malloc'.
3790
3791 2019-06-28  Tom Tromey  <tromey@adacore.com>
3792
3793         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3794         for Ada.
3795
3796 2019-06-27  Tom Tromey  <tromey@adacore.com>
3797
3798         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3799         objfile_key.
3800         (arm_find_mapping_symbol, arm_record_special_symbol)
3801         (_initialize_arm_tdep): Update.
3802         (arm_objfile_data_free): Remove.
3803
3804 2019-06-27  Tom Tromey  <tromey@adacore.com>
3805
3806         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3807         to cp_print_static_field.
3808
3809 2019-06-26  Tom Tromey  <tromey@adacore.com>
3810
3811         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3812         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3813         declare.
3814
3815 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3816
3817         * features/aarch64-core.c (create_feature_aarch64_core):
3818         Regenerate.
3819         * features/aarch64-core.xml: Add cpsr flags.
3820
3821 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3822
3823         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3824         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3825
3826 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3827
3828         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3829         field.
3830         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3831         use.
3832         (arm_record_special_symbol): Don't insert new symbol in sorted
3833         position, push it at the end.
3834
3835 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3836
3837         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3838         (arm_mapping_symbol_s): Remove.
3839         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3840         (arm_mapping_symbol_vec): New typedef.
3841         (struct arm_per_objfile): Add constructor.
3842         <section_maps>: Change type to
3843         std::unique_ptr<arm_mapping_symbol_vec[]>.
3844         (arm_compare_mapping_symbols): Remove.
3845         (arm_find_mapping_symbol): Adjust to section_maps type change.
3846         (arm_objfile_data_free): Call delete on arm_per_objfile.
3847         (arm_record_special_symbol): Adjust to section_maps type change.
3848         Allocate arm_per_objfile with new.
3849
3850 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3851
3852         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3853         with the command prefix.
3854
3855 2019-06-25  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3858         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3863         type.
3864         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3865         protected.
3866
3867 2019-06-25  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-winsource.c
3870         (tui_source_window_base::set_is_exec_point_at): Add check against
3871         LOA_ADDRESS.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-source.c (tui_set_source_content): Don't check before
3876         xfree.
3877         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3878
3879 2019-06-25  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-winsource.h (tui_update_source_window_as_is)
3882         (tui_alloc_source_buffer, tui_line_is_displayed)
3883         (tui_addr_is_displayed): Change type of win_info.
3884         * tui/tui-winsource.c (tui_update_source_window_as_is)
3885         (tui_clear_source_content, tui_show_source_line)
3886         (tui_show_source_content, tui_source_window_base::refill)
3887         (tui_source_window_base::set_is_exec_point_at)
3888         (tui_source_window_base::set_is_exec_point_at)
3889         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3890         (tui_alloc_source_buffer, tui_line_is_displayed)
3891         (tui_addr_is_displayed): Change type of win_info.  Update.
3892         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3893         (tui_source_window_base::do_make_visible_with_new_height):
3894         Update.
3895         * tui/tui-source.c (tui_set_source_content)
3896         (tui_set_source_content_nil)
3897         (tui_source_window::do_scroll_vertical): Update.
3898         * tui/tui-layout.c (show_layout): Update.
3899         * tui/tui-disasm.c (tui_set_disassem_content)
3900         (tui_disasm_window::do_scroll_vertical): Update.
3901         * tui/tui-data.h (tui_win_content): Remove.
3902         (struct tui_gen_win_info) <content, content_size>: Remove.
3903         (struct tui_source_element): Add initializers and destructor.
3904         (union tui_which_element, struct tui_win_element): Remove.
3905         (struct tui_source_window_base) <content>: New field.
3906         (struct tui_data_window): Remove destructor.
3907         (tui_alloc_content, tui_free_win_content)
3908         (tui_free_all_source_wins_content): Don't declare.
3909         * tui/tui-data.c (tui_initialize_static_data): Update.
3910         (init_content_element, tui_alloc_content): Remove.
3911         (~tui_gen_win_info): Update.
3912         (~tui_data_window, tui_free_all_source_wins_content)
3913         (tui_free_win_content, free_content, free_content_elements):
3914         Remove.
3915
3916 2019-06-25  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-winsource.h (tui_clear_source_content)
3919         (tui_erase_source_content, tui_show_source_content): Change type
3920         of win_info.
3921         * tui/tui-winsource.c (tui_clear_source_content)
3922         (tui_erase_source_content, tui_show_source_content): Change type
3923         of win_info.
3924         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3925         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3926         win_info.
3927         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3928         win_info.
3929         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3930
3931 2019-06-25  Tom Tromey  <tom@tromey.com>
3932
3933         * tui/tui-winsource.c (tui_clear_source_content)
3934         (tui_source_window_base::set_is_exec_point_at): Update.
3935         * tui/tui-source.c (tui_set_source_content_nil): Update.
3936         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3937         a bool.
3938         * tui/tui-data.c (init_content_element): Update.
3939
3940 2019-06-25  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3943         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3944         * tui/tui-layout.c (init_and_make_win): Update.
3945         * tui/tui.h (enum tui_win_type): Update.
3946         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3947         tui_win_is_auxillary.
3948         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3949         tui_win_is_auxillary.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3954         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3955         (tui_delete_data_content_windows, tui_display_all_data)
3956         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3957         Update.
3958         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3959         * tui/tui-regs.c (tui_last_regs_line_no)
3960         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3961         (tui_show_registers): Update.
3962         (tui_show_register_group): Return void.  Update.
3963         (tui_display_registers_from, tui_display_reg_element_at_line)
3964         (tui_display_registers_from_line, tui_check_register_values):
3965         Update.
3966         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3967         member.
3968         (struct tui_data_window) <regs_content>: Now a std::vector.
3969         <regs_content_count>: Remove.
3970         (tui_add_content_elements, tui_free_data_content): Don't declare.
3971         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3972         (init_content_element): Remove DATA_WIN case.  Add assert.
3973         (tui_add_content_elements): Remove.
3974         (tui_data_window): Update.
3975         (tui_free_data_content): Remove.
3976         (free_content_elements): Remove DATA_WIN case.
3977
3978 2019-06-25  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-data.c (tui_data_item_window): Update.
3981         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3982         * tui/tui-windata.c (tui_display_all_data)
3983         (tui_display_data_from_line): Update.
3984         (tui_check_data_values): Remove.
3985         * tui/tui-regs.c (tui_show_register_group)
3986         (tui_display_reg_element_at_line): Update.
3987         * tui/tui-hooks.c (tui_register_changed)
3988         (tui_refresh_frame_and_register_information): Call
3989         tui_check_register_values.
3990         * tui/tui-data.h (struct tui_data_window) <data_content,
3991         data_content_count, data_type>: Remove.
3992         (enum tui_data_type): Remove.
3993
3994         * tui/tui-data.c (tui_data_window::clear_detail)
3995         (~tui_data_window): Update.
3996
3997 2019-06-25  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4000         declare.
4001         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4002         Rename from tui_first_data_item_displayed.  Update.
4003         (tui_data_window::refresh_all)
4004         (tui_data_window::do_scroll_vertical): Update.
4005         * tui/tui-data.h (struct tui_data_window)
4006         <first_data_item_displayed>: Declare new method.
4007
4008 2019-06-25  Tom Tromey  <tom@tromey.com>
4009
4010         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4011         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4012         contents...
4013         (tui_initialize_static_data): ...here.
4014
4015 2019-06-25  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4018         (tui_display_registers_from, tui_check_register_values): Update.
4019         (tui_display_register): Remove win_info parameter; update.
4020         (tui_get_register): Change type of parameters.
4021         * tui/tui-data.h (struct tui_data_element): Remove.
4022         (union tui_which_element) <data>: Remove.
4023         <data_window>: Change type.
4024         (struct tui_data_item_window): New.
4025         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4026         case.  Add assert.
4027         (~tui_data_item_window): New destructor.
4028         (free_content_elements): Remove DATA_ITEM_WIN case.
4029
4030 2019-06-25  Tom Tromey  <tom@tromey.com>
4031
4032         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4033         Remove.
4034
4035 2019-06-25  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-data.h (struct tui_command_element): Remove.
4038         (union tui_which_element) <command>: Remove.
4039         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4040         assert.
4041         (free_content_elements): Remove CMD_WIN case.
4042
4043 2019-06-25  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-layout.c (tui_set_layout): Update.
4046         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4047         * tui/tui-data.c (layout_def): Update.
4048
4049 2019-06-25  Tom Tromey  <tom@tromey.com>
4050
4051         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4052         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4053         (tui_source_window_base::set_new_height): Update.
4054         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4055         Update.
4056         (tui_set_locator_fullname, tui_set_locator_info)
4057         (tui_show_frame_info): Update.
4058         * tui/tui-source.c (tui_set_source_content)
4059         (tui_source_is_displayed): Update.
4060         * tui/tui-layout.c (show_source_disasm_command, show_data)
4061         (show_source_or_disasm_and_command): Update.
4062         * tui/tui-disasm.c (tui_set_disassem_content)
4063         (tui_get_begin_asm_address): Update.
4064         * tui/tui-data.h (struct tui_locator_element): Remove.
4065         (union tui_which_element) <locator>: Remove.
4066         (struct tui_locator_window): New.
4067         (tui_locator_win_info_ptr): Change return type.
4068         * tui/tui-data.c (_locator): Change type.
4069         (tui_locator_win_info_ptr): Change return type.
4070         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4071         (tui_alloc_content): Add assert.
4072
4073 2019-06-25  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-winsource.c
4076         (tui_exec_info_window::maybe_allocate_content): New method.
4077         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4078         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4079         (make_source_or_disasm_window): Add cast.
4080         * tui/tui-data.h (union tui_which_element) <simple_string>:
4081         Remove.
4082         (struct tui_source_info): New.
4083         (struct tui_source_window_base) <execution_info>: Change type.
4084         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4085         case, and add assert.
4086         (tui_alloc_content): Add assert.
4087
4088 2019-06-25  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4091         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4092         * tui/tui-data.c (tui_alloc_win_info): Remove.
4093
4094 2019-06-25  Tom Tromey  <tom@tromey.com>
4095
4096         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4097         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4098         can_highlight.
4099
4100 2019-06-25  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4103         make_visible_with_new_height method.
4104         (tui_win_info::make_visible_with_new_height): New method.
4105         (tui_source_window_base::do_make_visible_with_new_height)
4106         (tui_data_window::do_make_visible_with_new_height)
4107         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4108         (make_visible_with_new_height): Remove.
4109         (tui_resize_all, tui_adjust_win_heights): Use
4110         make_visible_with_new_height method.
4111         * tui/tui-data.h (struct tui_win_info)
4112         <do_make_visible_with_new_height, make_visible_with_new_height>:
4113         New methods.
4114         (struct tui_source_window_base, struct tui_data_window)
4115         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4116         methods.
4117
4118 2019-06-25  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4121         method.
4122         (update_tab_width): Call update_tab_width method.
4123         * tui/tui-data.h (struct tui_win_info)
4124         (struct tui_source_window_base) <update_tab_width>: New methods.
4125
4126 2019-06-25  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4129         parameter.
4130         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4131         parameter.
4132         (tui_gen_win_info::make_visible): Update.
4133         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4134         parameter.
4135         * tui/tui-data.h (enum tui_box): New enum.
4136         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4137
4138 2019-06-25  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4141         init_and_make_win for EXEC_INFO_WIN.
4142         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4143         longer inline.
4144         (struct tui_win_info) <~tui_win_info>: Inline.
4145         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4146         Don't declare.
4147         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4148         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4149         Remove.
4150         (tui_initialize_static_data): Update.
4151         (~tui_gen_win_info): Handle more cleanup here.
4152         (~tui_source_window_base): Delete "execution_info".
4153         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4154
4155 2019-06-25  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-layout.c (make_command_window): Don't set
4158         can_highlight.
4159         (show_source_disasm_command): Call the reset method.
4160         (show_data): Don't set can_highlight.  Call the reset method.
4161         (tui_gen_win_info::reset): Rename from init_gen_win_info
4162         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4163         (show_source_or_disasm_and_command): Call the reset method.
4164         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4165         (struct tui_cmd_window): Set can_highlight.
4166
4167 2019-06-25  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4170         from make_visible.
4171         (tui_make_visible, tui_make_invisible): Rewrite.
4172         (tui_win_info::make_visible): Remove.
4173         (tui_source_window_base::make_visible): Update.
4174         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4175         method.  Moved from...
4176         (struct tui_win_info) <make_visible>: ...here.
4177
4178 2019-06-25  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-winsource.c
4181         (tui_source_window_base::do_scroll_horizontal): Remove direction
4182         parameter.
4183         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4184         direction parameter.
4185         * tui/tui-win.c (tui_win_info::forward_scroll)
4186         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4187         (tui_win_info::right_scroll): Update.
4188         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4189         direction parameter.
4190         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4191         direction parameter.
4192         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4193         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4194         Remove direction parameter.
4195         (struct tui_source_window_base, struct tui_source_window)
4196         (struct tui_disasm_window, struct tui_data_window)
4197         (struct tui_cmd_window): Update.
4198
4199 2019-06-25  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-winsource.h (tui_set_exec_info_content)
4202         (tui_show_exec_info_content, tui_erase_exec_info_content)
4203         (tui_clear_exec_info_content, tui_update_exec_info): Change
4204         argument to tui_source_window_base.
4205         * tui/tui-winsource.c (tui_set_exec_info_content)
4206         (tui_show_exec_info_content, tui_erase_exec_info_content)
4207         (tui_clear_exec_info_content, tui_update_exec_info): Change
4208         argument to tui_source_window_base.
4209
4210 2019-06-25  Tom Tromey  <tom@tromey.com>
4211
4212         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4213         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4214
4215 2019-06-25  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4218         check.
4219
4220 2019-06-25  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4223         type to void.
4224         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4225         type to void.
4226         * tui/tui-source.c (tui_set_source_content): Update.
4227         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4228
4229 2019-06-25  Tom Tromey  <tom@tromey.com>
4230
4231         * tui/tui-win.c (window_name_completer, tui_set_focus)
4232         (tui_all_windows_info): Use name method.
4233         * tui/tui-data.h (struct tui_gen_win_info)
4234         (struct tui_source_window, struct tui_disasm_window)
4235         (struct tui_data_window, struct tui_cmd_window) <name>: New
4236         method.
4237         (tui_win_name): Don't declare.
4238         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4239         (tui_win_name): Remove.
4240
4241 2019-06-25  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-winsource.h (tui_update_source_window)
4244         (tui_update_source_window_as_is): Change parameter type.
4245         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4246         to be a tui_source_window_base.
4247         (tui_update_source_window_as_is): Likewise.
4248         * tui/tui-win.c (make_visible_with_new_height): Update.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-winsource.c (tui_erase_source_content)
4253         (tui_show_source_content, tui_show_exec_info_content)
4254         (tui_erase_exec_info_content): Use refresh_window method.
4255         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4256         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4257         from tui_refresh_win.
4258         (tui_data_window::refresh_window): New method.
4259         (tui_win_info::refresh, tui_source_window_base::refresh)
4260         (tui_refresh_all): Use refresh_window method.
4261         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4262         method.
4263         * tui/tui-regs.c (tui_display_register): Call refresh_window
4264         method.
4265         * tui/tui-layout.c (show_source_disasm_command)
4266         (show_source_or_disasm_and_command): Call refresh_window method.
4267         * tui/tui-data.h (struct tui_gen_win_info)
4268         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4269         New method.
4270
4271 2019-06-25  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui.c (tui_rl_other_window, tui_enable)
4274         (tui_is_window_visible, tui_get_command_dimension): Update.
4275         * tui/tui-winsource.c (tui_update_source_window_as_is)
4276         (tui_clear_source_content, tui_erase_source_content)
4277         (tui_show_source_line, tui_source_window_base::refill)
4278         (tui_source_window_base::do_scroll_horizontal)
4279         (tui_source_window_base::set_is_exec_point_at)
4280         (tui_update_breakpoint_info, tui_set_exec_info_content)
4281         (tui_alloc_source_buffer, tui_line_is_displayed)
4282         (tui_addr_is_displayed): Update.
4283         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4284         (tui_check_and_display_highlight_if_needed)
4285         (tui_win_info::make_visible, tui_win_info::refresh)
4286         (tui_refresh_all): Update.
4287         * tui/tui-windata.c (tui_first_data_item_displayed)
4288         (tui_delete_data_content_windows, tui_erase_data_content)
4289         (tui_display_all_data, tui_data_window::refresh_all)
4290         (tui_check_data_values): Update.
4291         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4292         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4293         (tui_win_info::backward_scroll, tui_refresh_all_win)
4294         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4295         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4296         (tui_source_window_base::set_new_height)
4297         (tui_data_window::set_new_height)
4298         (make_invisible_and_set_new_height)
4299         (make_visible_with_new_height, new_height_ok)
4300         (parse_scrolling_args): Update.
4301         * tui/tui-stack.c (tui_show_frame_info): Update.
4302         * tui/tui-source.c (tui_set_source_content)
4303         (tui_set_source_content_nil, tui_source_is_displayed)
4304         (tui_source_window::do_scroll_vertical): Update.
4305         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4306         (tui_display_registers_from, tui_display_reg_element_at_line)
4307         (tui_check_register_values, tui_reg_command): Update.
4308         * tui/tui-layout.c (tui_default_win_height)
4309         (show_source_disasm_command, show_data, init_and_make_win)
4310         (show_source_or_disasm_and_command): Update.
4311         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4312         (tui_redisplay_readline, tui_mld_flush)
4313         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4314         (tui_getc): Update.
4315         * tui/tui-disasm.c (tui_set_disassem_content)
4316         (tui_disasm_window::do_scroll_vertical): Update.
4317         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4318         Now virtual.
4319         (struct tui_win_info): Derive from tui_gen_win_info.
4320         <~tui_win_info>: Mark as override.
4321         <generic>: Remove member.
4322         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4323         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4324         (~tui_data_window, ~tui_win_info)
4325         (tui_free_all_source_wins_content): Update.
4326         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4327
4328 2019-06-25  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-layout.c (init_and_make_win): Use new.
4331         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4332         destructor, initializers.
4333         (tui_alloc_generic_win_info): Don't declare.
4334         * tui/tui-data.c (_locator): Add argument to constructor.
4335         (source_win, disasm_win): New globals.
4336         (exec_info): Remove.
4337         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4338         Update.
4339         (tui_alloc_generic_win_info): Remove.
4340         (init_content_element): Use new.
4341         (tui_win_info::tui_win_info): Update.
4342         (free_content_elements) <case DATA_WIN>: Use delete.
4343
4344 2019-06-25  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4347         * tui/tui-windata.c (tui_first_data_item_displayed)
4348         (tui_delete_data_content_windows): Update.
4349         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4350         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4351         (tui_display_registers_from, tui_check_register_values): Update.
4352         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4353         pointer.
4354         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4355         window.
4356         (tui_free_data_content): Update.
4357         (free_content_elements) <case DATA_WIN>: Free the window.
4358
4359 2019-06-25  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4362         Update.
4363         * tui/tui-layout.c (make_command_window)
4364         (show_source_disasm_command, show_data, init_and_make_win)
4365         (show_source_or_disasm_and_command): Update.
4366         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4367         method.
4368         <can_highight, is_highlighted>: Now bool.
4369         (tui_set_win_highlight): Don't declare.
4370         * tui/tui-data.c (tui_set_win_highlight): Remove.
4371
4372 2019-06-25  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-wingeneral.c (make_visible): Remove check of window
4375         type.
4376
4377 2019-06-25  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-win.c (tui_win_info::max_height)
4380         (tui_cmd_window::max_height): New methods.
4381         (new_height_ok): Call max_height.
4382         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4383         <max_height>: New method.
4384
4385 2019-06-25  Tom Tromey  <tom@tromey.com>
4386
4387         * tui/tui-win.c (tui_source_window_base::set_new_height)
4388         (tui_data_window::set_new_height): New methods.
4389         (make_invisible_and_set_new_height): Call set_new_height method.
4390         * tui/tui-data.h (struct tui_win_info)
4391         (struct tui_source_window_base, struct tui_data_window)
4392         <set_new_height>: New method.
4393
4394 2019-06-25  Tom Tromey  <tom@tromey.com>
4395
4396         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4397         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4398         tui_refresh_data_win.
4399         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4400         method.
4401         (tui_refresh_all_win): Call the refresh_all method.
4402         (tui_set_focus): Likewise.
4403         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4404         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4405         Likewise.
4406
4407 2019-06-25  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-winsource.h (tui_refill_source_window)
4410         (tui_set_is_exec_point_at): Don't declare.
4411         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4412         (tui_source_window_base::refill): Rename from
4413         tui_refill_source_window.
4414         (tui_source_window_base::do_scroll_horizontal): Update.
4415         (tui_source_window_base::set_is_exec_point_at): Rename from
4416         tui_set_is_exec_point_at.
4417         (tui_update_all_breakpoint_info): Update.
4418         * tui/tui-stack.c (tui_show_frame_info): Update.
4419         * tui/tui-layout.c (show_data): Add cast.
4420         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4421         * tui/tui-data.h (struct tui_source_window_base) <refill,
4422         set_is_exec_point_at>: New methods.
4423         (tui_source_windows, tui_add_to_source_windows): Update types.
4424         (tui_add_to_source_windows): Remove redundant declaration.
4425         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4426         (tui_source_windows): Change return type.
4427         (tui_clear_source_windows_detail): Update.
4428         (tui_add_to_source_windows): Change type of parameter.
4429         (tui_free_all_source_wins_content): Update.
4430
4431 2019-06-25  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-wingeneral.c (tui_win_info::refresh)
4434         (tui_source_window_base::refresh): New methods.
4435         (tui_refresh_all): Call the refresh method.
4436         * tui/tui-data.h (struct tui_win_info)
4437         (struct tui_source_window_base) <refresh>: New method.
4438
4439 2019-06-25  Tom Tromey  <tom@tromey.com>
4440
4441         * tui/tui.h (tui_is_window_visible): Return bool.
4442         * tui/tui.c (tui_is_window_visible): Return bool.
4443         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4444         (tui_make_visible, tui_make_invisible)
4445         (tui_win_info::make_visible)
4446         (tui_source_window_base::make_visible, make_all_visible)
4447         (tui_make_all_visible, tui_make_all_invisible): Update.
4448         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4449         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4450         bool.
4451         (struct tui_win_info, struct tui_source_window_base)
4452         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4453         * tui/tui-data.c (tui_init_generic_part): Update.
4454
4455 2019-06-25  Tom Tromey  <tom@tromey.com>
4456
4457         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4458         (tui_source_window_base::make_visible): New methods.
4459         (make_all_visible): Make method call.
4460         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4461         (struct tui_source_window_base, struct tui_cmd_window): Override
4462         make_visible.
4463         (tui_win_is_source_type): Don't declare.
4464         * tui/tui-data.c (tui_win_is_source_type): Remove.
4465
4466 2019-06-25  Tom Tromey  <tom@tromey.com>
4467
4468         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4469         NULL check.
4470
4471 2019-06-25  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4474         Inline constructor.  Add initializers for members.
4475         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4476         constructors; now inline in class.
4477
4478 2019-06-25  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-regs.c (tui_show_registers): Update.
4481         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4482         bool.
4483         * tui/tui-data.c (tui_data_window::clear_detail)
4484         (tui_data_window): Update.
4485
4486 2019-06-25  Tom Tromey  <tom@tromey.com>
4487
4488         * tui/tui-windata.c (tui_display_all_data)
4489         (tui_display_data_from_line, tui_display_data_from)
4490         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4491         Update.
4492         * tui/tui-regs.c (tui_last_regs_line_no)
4493         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4494         (tui_show_registers, tui_show_register_group)
4495         (tui_display_registers_from, tui_display_reg_element_at_line)
4496         (tui_display_registers_from_line, tui_check_register_values)
4497         (tui_reg_next, tui_reg_prev): Update.
4498         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4499         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4500         tui_data_window.
4501         (struct tui_win_info) <detail>: Remove.  Add new fields from
4502         tui_data_info.
4503         (TUI_DATA_WIN): Add cast.
4504         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4505         (~tui_data_window): Simplify.
4506
4507 2019-06-25  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-layout.c (show_source_disasm_command)
4510         (show_source_or_disasm_and_command): Update.
4511         * tui/tui-io.c (update_cmdwin_start_line)
4512         (tui_redisplay_readline): Update.
4513         * tui/tui-data.h (struct tui_command_info): Remove.
4514         (struct tui_win_info) <detail>: Remove command_info member.
4515         (struct tui_data_window) <start_line>: New member, from
4516         tui_command_info.
4517         (TUI_CMD_WIN): Add casts.
4518
4519 2019-06-25  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-winsource.c (tui_update_source_window)
4522         (tui_refill_source_window)
4523         (tui_source_window_base::do_scroll_horizontal)
4524         (tui_update_breakpoint_info, tui_set_exec_info_content)
4525         (tui_show_exec_info_content, tui_erase_exec_info_content)
4526         (tui_clear_exec_info_content): Update.
4527         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4528         Update.
4529         * tui/tui-win.c (make_invisible_and_set_new_height)
4530         (make_visible_with_new_height): Update.
4531         * tui/tui-source.c (tui_set_source_content)
4532         (tui_show_symtab_source): Update.
4533         * tui/tui-layout.c (extract_display_start_addr)
4534         (show_source_disasm_command, show_data)
4535         (make_source_or_disasm_window)
4536         (show_source_or_disasm_and_command): Update.
4537         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4538         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4539         "gdbarch".
4540         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4541         to tui_source_window_base.
4542         (struct tui_win_info) <detail>: Remove source_info member.
4543         (struct tui_source_window_base) <has_locator>: Inline.
4544         Move contents from tui_source_info; rename has_locator member to
4545         m_has_locator.
4546         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4547         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4548         header file.
4549         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4550         Simplify.
4551         (tui_free_all_source_wins_content): Cast to
4552         tui_source_window_base.
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-win.c (make_invisible_and_set_new_height)
4557         (make_visible_with_new_height): Call has_locator method.
4558         * tui/tui-layout.c (show_source_disasm_command, show_data)
4559         (show_source_or_disasm_and_command): Update for bool change.
4560         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4561         (tui_win_info) <has_locator>: New method.
4562         (struct tui_source_window_base) <has_locator>: New method.
4563         (tui_win_has_locator): Don't declare.
4564         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4565         from tui_win_has_locator.
4566         (tui_source_window_base): Use false, not FALSE.
4567
4568 2019-06-25  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4571         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4572         clear_detail method directly.
4573         (tui_clear_win_detail): Remove.
4574
4575 2019-06-25  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4578         "this", not TUI_DISASM_WIN.
4579
4580 2019-06-25  Tom Tromey  <tom@tromey.com>
4581
4582         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4583         declare.
4584         * tui/tui-winsource.c
4585         (tui_source_window_base::do_scroll_horizontal): Rename from
4586         tui_horizontal_source_scroll.
4587         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4588         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4589         from tui_vertical_data_scroll.
4590         * tui/tui-win.h (tui_scroll): Don't declare.
4591         * tui/tui-win.c (tui_win_info::forward_scroll)
4592         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4593         (tui_win_info::right_scroll): Rename and update.
4594         (tui_scroll_forward_command, tui_scroll_backward_command)
4595         (tui_scroll_left_command, tui_scroll_right_command): Update.
4596         (tui_scroll): Remove.
4597         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4598         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4599         from tui_vertical_source_scroll.
4600         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4601         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4602         from tui_vertical_disassem_scroll.
4603         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4604         do_scroll_horizontal>: New methods.
4605         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4606         Likewise.
4607         (struct tui_source_window_base): Add do_scroll_horizontal.
4608         (struct tui_source_window, struct tui_disasm_window): Add
4609         do_scroll_vertical.
4610         (struct tui_data_window, struct tui_cmd_window): Add
4611         do_scroll_horizontal and do_scroll_vertical.
4612         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4613
4614 2019-06-25  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-data.h (struct tui_source_window_base): New struct.
4617         (struct tui_source_window): Derive from tui_source_window_base.
4618         (struct tui_disasm_window): New struct.
4619         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4620         from tui_source_window::clear_detail.
4621         (tui_source_window_base): Rename from tui_source_window.
4622         (~tui_source_window_base): Rename from ~tui_source_window.
4623         (tui_alloc_win_info): Create a tui_disasm_window.
4624
4625 2019-06-25  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-data.h (struct tui_source_window)
4628         (struct tui_data_window): Declare destructors.
4629         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4630         destructors.
4631         (tui_win_info): Simplify.
4632
4633 2019-06-25  Tom Tromey  <tom@tromey.com>
4634
4635         * tui/tui-winsource.c (tui_display_main)
4636         (tui_update_source_windows_with_addr)
4637         (tui_update_all_breakpoint_info): Update.
4638         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4639         (new_height_ok, parse_scrolling_args): Update.
4640         * tui/tui-stack.c (tui_show_frame_info): Update.
4641         * tui/tui-data.h (struct tui_list): Remove.
4642         (tui_source_windows): Return a reference to a std::vector.
4643         * tui/tui-data.c (source_windows): Now a std::vector.
4644         (tui_source_windows): Change return type.
4645         (tui_clear_source_windows): Rewrite.
4646         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4647         (tui_free_all_source_wins_content): Rewrite.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4652         (struct tui_data_window, struct tui_cmd_window): Declare
4653         clear_detail method.
4654         * tui/tui-data.c (tui_source_window::clear_detail)
4655         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4656         methods.
4657         (tui_clear_win_detail): Simplify.
4658
4659 2019-06-25  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-layout.c (make_source_window, make_disasm_window)
4662         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4663         Return the new window.
4664         (show_source_disasm_command, show_data)
4665         (show_source_or_disasm_and_command): Update.
4666
4667 2019-06-25  Tom Tromey  <tom@tromey.com>
4668
4669         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4670         parameter.  Return the new window.
4671         (show_source_disasm_command): Update and remove NULL check.
4672         (show_source_or_disasm_and_command): Update.
4673
4674 2019-06-25  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4677
4678 2019-06-25  Tom Tromey  <tom@tromey.com>
4679
4680         * tui/tui-data.h (struct tui_win_info): Make constructor
4681         protected.  Make destructor virtual.  Add initializers.
4682         (tui_source_window, tui_data_window, tui_cmd_window): New
4683         classes.
4684         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4685         constructor.  Add "type" parameter.
4686         (tui_source_window, tui_data_window, tui_cmd_window): New
4687         constructors.
4688         (tui_alloc_win_info): Instantiate the appropriate subclass.
4689
4690 2019-06-25  Tom Tromey  <tom@tromey.com>
4691
4692         * tui/tui-win.c (tui_resize_all): Use delete.
4693         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4694         destructor.
4695         (tui_free_window): Don't declare.
4696         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4697         Update.
4698
4699 2019-06-25  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-data.h (struct tui_win_info): Add constructor.
4702         * tui/tui-data.c (tui_alloc_win_info): Use new.
4703         (tui_free_window): Use delete.
4704
4705 2019-06-22  Tom Tromey  <tom@tromey.com>
4706
4707         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4708         declare.
4709         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4710
4711 2019-06-22  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4714         declare.
4715         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4716
4717 2019-06-22  Tom de Vries  <tdevries@suse.de>
4718
4719         * dwarf2read.c (create_addrmap_from_aranges)
4720         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4721         instead of '%zu'.
4722
4723 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4724
4725         * dwarf2read.h (dwarf2_section_info_def): Remove.
4726         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4727         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4728         std::vector<dwarf2_section_info>.
4729         (struct dwo_file) <~dwo_file>: Remove.
4730         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4731         types field.
4732         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4733         (dwarf2_read_debug_names): Likewise.
4734         (create_debug_types_hash_table): Change parameter type to
4735         array_view, adjust code accordingly.
4736         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4737         (partial_die_info::fixup): Likewise.
4738         (determine_prefix): Likewise.
4739         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4740
4741 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4742
4743         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4744         gdb_bfd_ref_ptr.
4745         <~dwo_file>: Remove call to gdb_bfd_unref.
4746         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4747         gdb_bfd_ref_ptr::get.
4748
4749 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4750
4751         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4752         type to htab_up.
4753         * dwarf2read.c (struct dwo_file): Initialize fields.
4754         <~dwo_file>: New.
4755         (free_dwo_file): Remove, move content to ~dwo_file.
4756         (struct dwo_file_deleter): Remove.
4757         (dwo_file_up>: Remove custom deleter.
4758         (free_dwo_files): Remove.
4759         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4760         dwo_files.
4761         (process_skeletonless_type_units): Call unique_ptr::get.
4762         (allocate_dwo_file_hash_table): Add deleter to created hash
4763         table.  Change return type to htab_up.
4764         (lookup_dwo_file_slot): Don't memset dwo_file, call
4765         unique_ptr::get.
4766         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4767         (create_dwo_unit_in_dwp_v2): Likewise.
4768         (open_and_init_dwo_file): Likewise.
4769         (free_dwo_file_from_slot): Remove.
4770
4771 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4772
4773         * dwarf2read.h (struct dwarf2_section_info) <readin,
4774         is_virtual>: Change type to bool.
4775         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4776         true instead of 1.
4777
4778 2019-06-19  Tom Tromey  <tom@tromey.com>
4779
4780         * tui/tui-data.h (tui_init_content_element): Don't declare.
4781
4782 2019-06-19  Tom Tromey  <tom@tromey.com>
4783
4784         * tui/tui-data.h (tui_init_win_info): Don't declare.
4785
4786 2019-06-19  Tom de Vries  <tdevries@suse.de>
4787
4788         * dwarf2read.h (abstract_to_concrete): Change type to
4789         std::unordered_map<sect_offset, std::vector<sect_offset>,
4790         gdb::hash_enum<sect_offset>>.
4791
4792 2019-06-19  Tom Tromey  <tromey@adacore.com>
4793
4794         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4795         EVAL_AVOID_SIDE_EFFECTS specially.
4796
4797 2019-06-19  Tom Tromey  <tromey@adacore.com>
4798
4799         * source-cache.c (highlighter): New global.
4800         (source_cache::get_source_lines): Create a highlighter on demand.
4801
4802 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * defs.h (deprecated_interactive_hook): Delete declaration.
4805         * interps.c (clear_interpreter_hooks): Remove use of
4806         deprecated_interactive_hook.
4807         * top.c (deprecated_interactive_hook): Delete definition.
4808         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4809
4810 2019-06-18  Tom de Vries  <tdevries@suse.de>
4811
4812         PR gdb/24515
4813         * dwarf2read.h (abstract_to_concrete): Change type from
4814         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4815         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4816         * dwarf2read.c (read_variable): Update.
4817         (dwarf2_fetch_die_loc_sect_off): Update.
4818
4819 2019-06-17  Tom de Vries  <tdevries@suse.de>
4820
4821         PR gdb/24617
4822         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4823         accessing parent[parent_len - 1].
4824
4825 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4826
4827         PR gdb/24364
4828         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4829         call dtrace_process_dof with NULL dof.
4830
4831 2019-06-16  Tom de Vries  <tdevries@suse.de>
4832
4833         PR gdb/24445
4834         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4835
4836 2019-06-16  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4839         (make_all_visible): Use address of member.
4840
4841 2019-06-16  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4844         (tui_free_window, free_content, free_content_elements): Remove
4845         unnecessary cast.
4846         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4847         cast.
4848         * tui/tui-regs.c (tui_show_register_group)
4849         (tui_display_registers_from, tui_display_reg_element_at_line):
4850         Remove unnecessary cast.
4851
4852 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * linux-nat.c (normal_mask): Delete.
4855         (_initialize_linux_nat): Don't initialise normal_mask.
4856
4857 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4858
4859         PR gdb/24445
4860         * dwarf-index-write.h (write_psymtabs_to_index): Add
4861         dwz_basename parameter.
4862         * dwarf-index-write.c (write_gdbindex): Move file writing to
4863         write_gdbindex_1.  Change return type void.
4864         (assert_file_size): Move up, remove filename parameter.
4865         (write_gdbindex_1): New function.
4866         (write_debug_names): Change return type to void, call
4867         assert_file_size.
4868         (struct index_wip_file): New struct.
4869         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4870         file logic to index_wip_file.  Write index for dwz file if
4871         needed.
4872         (save_gdb_index_command): Pass basename of dwz file, if present.
4873         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4874         build-id of dwz file, if present.
4875         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4876         (dwarf2_get_dwz_file): Likewise.
4877         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4878         (dwarf2_get_dwz_file): Likewise.
4879
4880 2019-06-16  Tom Tromey  <tom@tromey.com>
4881
4882         * coffread.c (process_coff_symbol): Use xstrdup.
4883         * value.c (create_internalvar): Use xstrdup.
4884
4885 2019-06-16  Tom Tromey  <tom@tromey.com>
4886
4887         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4888         * breakpoint.c (stopin_command, stopat_command)
4889         (until_break_command, decode_location_default): Remove unnecessary
4890         cast.
4891         * utils.c (subset_compare): Remove unnecessary cast.
4892         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4893         cast.
4894         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4895         cast.
4896         * infcmd.c (path_command): Remove unnecessary cast.
4897         * coffread.c (decode_type): Remove unnecessary cast.
4898         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4899         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4900         * tui/tui-stack.c (tui_show_locator_content)
4901         (tui_show_frame_info): Remove unnecessary cast.
4902         * tui/tui-win.c (tui_scroll_forward_command)
4903         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4904         (parse_scrolling_args): Remove unnecessary cast.
4905         * tui/tui-data.c (init_win_info, tui_del_window)
4906         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4907         (free_content_elements): Remove unnecessary cast.
4908         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4909         unnecessary cast.
4910         * tui/tui-source.c (tui_set_source_content)
4911         (tui_vertical_source_scroll): Remove unnecessary cast.
4912         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4913         cast.
4914         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4915         * tui/tui-regs.c (tui_display_registers_from)
4916         (tui_display_register): Remove unnecessary cast.
4917         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4918         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4919         (make_visible): Remove unnecessary cast.
4920         * tui/tui-winsource.c (tui_erase_source_content)
4921         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4922         unnecessary cast.
4923         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4924         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4925         * stabsread.c (read_type, read_array_type, read_range_type):
4926         Remove unnecessary cast.
4927         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4928         (parse_symbol, parse_type, upgrade_type, parse_external)
4929         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4930         unnecessary cast.
4931         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4932
4933 2019-06-16  Tom Tromey  <tom@tromey.com>
4934
4935         * tui/tui-data.c (tui_alloc_generic_win_info)
4936         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4937         checks.
4938
4939 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4940             Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * f-typeprint.c (f_print_type): Don't return early for not
4943         associated or not allocated types.
4944         (f_type_print_varspec_suffix): Add print_rank parameter and print
4945         ranks of array types in case they dangling.
4946         (f_type_print_base): Add print_rank parameter.
4947
4948 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4949
4950         * NEWS: Mention new MI commands.
4951         * break-catch-throw.c (enum exception_event_kind): Move to
4952         breakpoint.h.
4953         (print_mention_exception_catchpoint): Output text as a single
4954         message.
4955         (catch_exception_command_1): Rename to...
4956         (catch_exception_event): ...this, make non-static, update header
4957         command, and change some parameter types.
4958         (catch_catch_command): Update for changes to
4959         catch_exception_command_1.
4960         (catch_throw_command): Likewise.
4961         (catch_rethrow_command): Likewise.
4962         * breakpoint.c (enum exception_event_kind): Delete.
4963         * breakpoint.h (enum exception_event_kind): Moved here from
4964         break-catch-throw.c.
4965         (catch_exception_event): Declare.
4966         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4967         (mi_cmd_catch_throw): New function.
4968         (mi_cmd_catch_rethrow): New function.
4969         (mi_cmd_catch_catch): New function.
4970         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4971         'catch-catch' entries.
4972         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4973         (mi_cmd_catch_rethrow): Declare.
4974         (mi_cmd_catch_catch): Declare.
4975
4976 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * annotate.c (annotate_source_line): Change return type to void,
4979         update implementation to match.
4980         * annotate.h (annotate_source_line): Change return type to void,
4981         update header comment.
4982         * stack.c (print_frame_info): Don't change what frame information
4983         is printed based on whether annotations are on or not.
4984
4985 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4988         (annotate_source): Make static.
4989         (annotate_source_line): Moved from source.c and renamed from
4990         identify_source_line.  Update the return type.
4991         * annotate.h (annotate_source): Delete declaration.
4992         (annotate_source_line): Declaration moved from source.h, and
4993         renamed from identify_source_line.  Return type updated.
4994         * source.c (identify_source_line): Moved to annotate.c and renamed
4995         to annotate_source_line.
4996         (info_line_command): Remove check of annotation_level.
4997         * source.h (identify_source_line): Move declaration to annotate.h
4998         and rename to annotate_source_line.
4999         * stack.c: Add 'annotate.h' include.
5000         (print_frame_info): Remove check of annotation_level before
5001         calling annotate_source_line.
5002
5003 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * source-cache.c (source_cache::get_plain_source_lines): Use
5006         open_source_file_with_line_charpos instead of just
5007         open_source_file, remove call to find_source_lines.
5008         (source_cache::get_source_lines): Likewise.
5009         * source.c (find_source_lines): Make static.
5010         (get_filename_and_charpos): Renamed into...
5011         (open_source_file_with_line_charpos): ..this along with changes to
5012         return a scoped_fd, and some other minor clean ups.
5013         (identify_source_line): Use open_source_file_with_line_charpos.
5014         (search_command_helper): Use open_source_file_with_line_charpos
5015         instead of just open_source_file, remove call to
5016         find_source_lines.
5017         * source.h (open_source_file_with_line_charpos): Declare new
5018         function.
5019         (find_source_lines): Delete declaration.
5020
5021 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * source.c (get_filename_and_charpos): Remove fullname
5024         parameter.
5025         (identify_source_line): Update call to get_filename_and_charpos.
5026
5027 2019-06-14  Tom Tromey  <tromey@adacore.com>
5028
5029         PR gdb/24502:
5030         * ui-style.h (skip_ansi_escape): Update comment.
5031         * ui-file.h (class no_terminal_escape_file): New class.
5032         * ui-file.c (no_terminal_escape_file::write)
5033         (no_terminal_escape_file::puts): New methods.
5034         * cli/cli-logging.c (handle_redirections): Use
5035         no_terminal_escape_file.
5036
5037 2019-06-14  Tom Tromey  <tromey@adacore.com>
5038
5039         * NEWS: Move convenience variable news above Python news.
5040
5041 2019-06-14  Tom Tromey  <tom@tromey.com>
5042
5043         * gnulib: Move directory to top-level.
5044         * configure.ac: Don't configure gnulib.
5045         * configure: Rebuild.
5046         * common/common-defs.h: Use new path to gnulib.
5047         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5048         (GNULIB_H): Remove.
5049         (INCGNU): Look in new gnulib location.
5050         (HFILES_NO_SRCDIR): Remove gnulib files.
5051         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5052         (generated_files): Remove GNULIB_H.
5053         ($(LIBGNU), all-lib): Remove targets.
5054         (distclean): Don't mention GNULIB_BUILDDIR.
5055         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5056
5057 2019-06-14  Tom Tromey  <tromey@adacore.com>
5058
5059         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5060         Warn if symbol file does not provide any symbols.
5061
5062 2019-06-14  Tom Tromey  <tromey@adacore.com>
5063
5064         * source.c (find_and_open_source): Respect basenames_may_differ.
5065
5066 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * annotate.c (annotate_breakpoints_invalid): Make use of
5069         scoped_restore_terminal_state.
5070         (annotate_frames_invalid): Likewise.
5071
5072 2019-06-14  Tom Tromey  <tromey@adacore.com>
5073
5074         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5075         allow assignment to an internalvar.
5076
5077 2019-06-14  Tom Tromey  <tromey@adacore.com>
5078
5079         * ada-lex.l: Allow "_" in attribute names.
5080
5081 2019-06-14  Tom Tromey  <tromey@adacore.com>
5082
5083         PR gdb/24653:
5084         * regcache.c (registers_changed): Don't call alloca.
5085         * top.c (execute_command): Don't call alloca.
5086
5087 2019-06-13  Pedro Alves  <palves@redhat.com>
5088
5089         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5090         'expression'.  When parsing an expression, error out if there's
5091         junk after "unlimited".
5092         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5093         (do_set_command): Adjust calls to is_unlimited_literal.
5094
5095 2019-06-13  Pedro Alves  <palves@redhat.com>
5096
5097         * compile/compile.c (make_compile_options_def_group): Add braces
5098         around array_view initializer.
5099         * thread.c (make_thread_apply_all_options_def_group)
5100         (make_thread_apply_all_options_def_group): Likewise.
5101
5102 2019-06-13  Pedro Alves  <palves@redhat.com>
5103
5104         * NEWS (New commands): Mention "maint test-options
5105         require-delimiter", "maint test-options unknown-is-error", "maint
5106         test-options unknown-is-operand" and "maint show
5107         test-options-completion-result".
5108         (New command options, command completion): New section.
5109         (Completion improvements): New section.
5110         Mention that you can abbreviate "unlimited".
5111
5112 2019-06-13  Pedro Alves  <palves@redhat.com>
5113
5114         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5115         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5116         * unittests/cli-utils-selftests.c (test_parse_flags)
5117         (test_parse_flags_qcs): Delete.
5118         (test_cli_utils): Don't call deleted functions.
5119
5120 2019-06-13  Pedro Alves  <palves@redhat.com>
5121
5122         * thread.c: Include "cli/cli-option.h".
5123         (tp_array_compar_ascending): Global.
5124         (tp_array_compar): Delete function.
5125         (tp_array_compar_ascending, tp_array_compar_descending): New
5126         functions.
5127         (ascending_option_def, qcs_flag_option_def)
5128         (thr_qcs_flags_option_defs)
5129         (make_thread_apply_all_options_def_group)
5130         (make_thread_apply_options_def_group): New.
5131         (thread_apply_all_command): Use gdb::option::process_options.
5132         (thread_apply_command_completer)
5133         (thread_apply_all_command_completer): New.
5134         (thread_apply_command): Use gdb::option::process_options.
5135         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5136         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5137         to generate help text of "thread apply".  Adjust "taas"'s help.
5138         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5139         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5140
5141 2019-06-13  Pedro Alves  <palves@redhat.com>
5142
5143         * thread.c (thread_apply_command): Check for invalid TID with
5144         isdigit instead of !isalpha.
5145
5146 2019-06-13  Pedro Alves  <palves@redhat.com>
5147
5148         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5149         (validate_flags_qcs): New.
5150         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5151         (validate_flags_qcs): Declare.
5152         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5153         (make_frame_apply_options_def_group): New.
5154         (frame_apply_command_count): Process options with
5155         gdb::option::process_options.
5156         (frame_apply_completer): New.
5157         (frame_apply_level_completer, frame_apply_all_completer)
5158         (frame_apply_completer): New.
5159         (_initialize_stack): Update help of "frame apply", "frame apply
5160         level", "frame apply all" and "faas" to mention supported options
5161         and install command completers.
5162         * stack.h (frame_apply_all_completer): Declare.
5163         * thread.c: Include "stack.h".
5164         (tfaas_command): Add "--".
5165         (_initialize_thread): Update help "tfaas" to mention supported
5166         options and install command completer.
5167
5168 2019-06-13  Pedro Alves  <palves@redhat.com>
5169
5170         * completer.c (complete_nested_command_line): New.
5171         (gdb_completion_word_break_characters_throw): Add assertion.
5172         * completer.h (complete_nested_command_line): Declare.
5173
5174 2019-06-13  Pedro Alves  <palves@redhat.com>
5175
5176         * stack.c (parse_backtrace_qualifiers): New.
5177         (backtrace_command): Use it.
5178         (backtrace_command_completer): Complete on qualifiers.
5179
5180 2019-06-13  Pedro Alves  <palves@redhat.com>
5181
5182         * frame.c: Include "cli/cli-option.h.
5183         (user_set_backtrace_options): New.
5184         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5185         Delete.
5186         (get_prev_frame): Adjust.
5187         (boolean_option_def, uinteger_option_def)
5188         (set_backtrace_option_defs): New.
5189         (_initialize_frame): Adjust and use
5190         gdb::option::add_setshow_cmds_for_options to install "set
5191         backtrace past-main" and "set backtrace past-entry".
5192         * frame.h: Include "cli/cli-option.h".
5193         (struct frame_print_options): Forward declare.
5194         (print_frame_arguments_all, print_frame_arguments_scalars)
5195         (print_frame_arguments_none): Declare.
5196         (print_entry_values): Delete declaration.
5197         (struct frame_print_options, user_frame_print_options): New.
5198         (struct set_backtrace_options): New.
5199         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5200         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5201         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5202         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5203         (list_args_or_locals): Add frame_print_options parameter.
5204         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5205         * python/py-framefilter.c (enumerate_args): Pass down
5206         USER_FRAME_PRINT_OPTIONS.
5207         * stack.c: Include "cli/cli-option.h".
5208         (print_frame_arguments_all, print_frame_arguments_scalars)
5209         (print_frame_arguments_none): Declare.
5210         (print_raw_frame_arguments, print_entry_values): Delete.
5211         (user_frame_print_options): New.
5212         (boolean_option_def, enum_option_def, frame_print_option_defs):
5213         New.
5214         (struct backtrace_cmd_options): New.
5215         (bt_flag_option_def): New.
5216         (backtrace_command_option_defs): New.
5217         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5218         (print_frame_arg, read_frame_arg, print_frame_args)
5219         (print_frame_info, print_frame): Add frame_print_options parameter
5220         and use it.
5221         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5222         (backtrace_command_1): Add frame_print_options and
5223         backtrace_cmd_options parameters and use them.
5224         (make_backtrace_options_def_group): New.
5225         (backtrace_command): Process command options with
5226         gdb::option::process_options.
5227         (backtrace_command_completer): New.
5228         (_initialize_stack): Extend "backtrace"'s help to mention
5229         supported options.  Install completer for "backtrace".
5230         Install some settings commands with add_setshow_cmds_for_options.
5231
5232 2019-06-13  Pedro Alves  <palves@redhat.com>
5233
5234         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5235         and that "set/show print raw frame-arguments" are now deprecated.
5236
5237         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5238         command.
5239         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5240         * stack.c (_initialize_stack): Install "set/show print
5241         raw-frame-arguments", and deprecate "set/show print raw
5242         frame-arguments".
5243         * valprint.c (_initialize_valprint): Deprecate "set/show print
5244         raw".
5245
5246 2019-06-13  Pedro Alves  <palves@redhat.com>
5247
5248         * compile/compile.c (struct compile_options): New.
5249         (compile_flag_option_def, compile_command_option_defs)
5250         (make_compile_options_def_group): New.
5251         (compile_file_command): Handle options with
5252         gdb::option::process_options.
5253         (compile_file_command_completer): New function.
5254         (compile_code_command): Handle options with
5255         gdb::option::process_options.
5256         (compile_code_command_completer): New function.
5257         (_initialize_compiler): Install completers for "compile code" and
5258         "compile file".  Mention available options in "compile code" and
5259         "compile code"'s help.
5260         * completer.c (advance_to_completion_word): New, factored out from
5261         ...
5262         (advance_to_expression_complete_word_point): ... this.
5263         (advance_to_filename_complete_word_point): New.
5264         * completer.h (advance_to_filename_complete_word_point): New
5265         declaration.
5266
5267 2019-06-13  Pedro Alves  <palves@redhat.com>
5268
5269         * compile/compile.c: Include "cli/cli-option.h".
5270         (compile_print_value): Scope data pointer is now a
5271         value_print_options pointer; adjust.
5272         (compile_print_command): Process options.  Scope data pointer is
5273         now a value_print_options pointer; adjust.
5274         (_initialize_compile): Update "compile print"'s help to include
5275         supported options.  Install a completer for "compile print".
5276         * cp-valprint.c (show_vtblprint, show_objectprint)
5277         (show_static_field_print): Delete.
5278         (_initialize_cp_valprint): Don't install "set print
5279         static-members", "set print vtbl", "set print object" here.
5280         * printcmd.c: Include "cli/cli-option.h" and
5281         "common/gdb_optional.h".
5282         (print_command_parse_format): Rework to fill in a
5283         value_print_options instead of a format_data.
5284         (print_value): Change parameter type from format_data pointer to
5285         value_print_options reference.  Adjust.
5286         (print_command_1): Process options.  Adjust to pass down a
5287         value_print_options.
5288         (print_command_completer): New.
5289         (_initialize_printcmd): Install print_command_completer as
5290         handle_brkchars completer for the "print" command.  Update
5291         "print"'s help to include supported options.
5292         * valprint.c: Include "cli/cli-option.h".
5293         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5294         here from cp-valprint.c.
5295         (boolean_option_def, uinteger_option_def)
5296         (value_print_option_defs, make_value_print_options_def_group):
5297         New.  Use gdb::option::add_setshow_cmds_for_options to install
5298         "set print elements", "set print null-stop", "set print repeats",
5299         "set print pretty", "set print union", "set print array", "set
5300         print address", "set print symbol", "set print array-indexes".
5301         * valprint.h: Include <string> and "cli/cli-option.h".
5302         (make_value_print_options_def_group): Declare.
5303         (print_value): Change parameter type from format_data pointer to
5304         value_print_options reference.
5305         (print_command_completer): Declare.
5306
5307 2019-06-13  Pedro Alves  <palves@redhat.com>
5308
5309         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5310         (COMMON_SFILES): Add maint-test-settings.c.
5311         * cli/cli-decode.c (boolean_enums): New global, factored out from
5312         ...
5313         (add_setshow_boolean_cmd): ... here.
5314         * cli/cli-decode.h (boolean_enums): Declare.
5315         * cli/cli-option.c: New file.
5316         * cli/cli-option.h: New file.
5317         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5318         factored out from ...
5319         (parse_cli_boolean_value(const char *)): ... this.
5320         (is_unlimited_literal): Change parameter type to pointer to
5321         pointer.  Adjust and advance ARG pointer.
5322         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5323         (parse_cli_var_enum): New, factored out from ...
5324         (do_set_command): ... this.  Adjust.
5325         * cli/cli-setshow.h (parse_cli_boolean_value)
5326         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5327         (parse_cli_var_enum): Declare.
5328         * cli/cli-utils.c: Include "cli/cli-option.h".
5329         (get_ulongest): New.
5330         * cli/cli-utils.h (get_ulongest): Declare.
5331         (check_for_argument): New overloads.
5332         * maint-test-options.c: New file.
5333
5334 2019-06-13  Pedro Alves  <palves@redhat.com>
5335
5336         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5337         parse a range if "-" is at the end of the string.
5338
5339 2019-06-13  Pedro Alves  <palves@redhat.com>
5340
5341         * cli/cli-setshow.c (parse_auto_binary_operation)
5342         (parse_cli_boolean_value): Don't allow "o".
5343
5344 2019-06-13  Pedro Alves  <palves@redhat.com>
5345
5346         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5347         * NEWS: Mention maint test-settings KIND.
5348         * maint-test-settings.c: New file.
5349
5350 2019-06-13  Pedro Alves  <palves@redhat.com>
5351
5352         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5353         completer.
5354         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5355         "set" completers.
5356
5357 2019-06-13  Pedro Alves  <palves@redhat.com>
5358
5359         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5360         after item.
5361
5362 2019-06-13  Pedro Alves  <palves@redhat.com>
5363
5364         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5365
5366 2019-06-13  Pedro Alves <palves@redhat.com>
5367
5368         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5369         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5370         call.
5371         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5372         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5373         calls.
5374         (check_for_argument): Skip spaces after argument.
5375
5376 2019-06-13  Pedro Alves  <palves@redhat.com>
5377
5378         * thread.c (thread_apply_command): Adjust TID parsing.
5379         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5380         detected before end of string.
5381         (tid_is_in_list): Error out if LIST is invalid.
5382
5383 2019-06-13  Pedro Alves  <palves@redhat.com>
5384
5385         * completer.c (complete_line_internal_1): Rewind completion word
5386         point.
5387         (completion_tracker::advance_custom_word_point_by): Change
5388         parameter type to int.
5389         * completer.h (completion_tracker::advance_custom_word_point_by):
5390         Likewise.
5391
5392 2019-06-13  Pedro Alves  <palves@redhat.com>
5393
5394         * completer.c (advance_to_completion_word): Handle delimiters.
5395
5396 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5397
5398         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5399
5400 2019-06-11  Tom Tromey  <tom@tromey.com>
5401
5402         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5403         (xmalloc_failed): Move to alloc.c.
5404         * alloc.c: New file.
5405         * Makefile.in (COMMON_SFILES): Add alloc.c.
5406
5407 2019-06-11  Tom Tromey  <tom@tromey.com>
5408
5409         * nat/linux-waitpid.c: Don't include server.h.
5410         (linux_debug): Remove.
5411         (my_waitpid): Update.
5412
5413 2019-06-11  Tom Tromey  <tromey@adacore.com>
5414
5415         * infcall.c (_initialize_infcall): Remove trailing newline from
5416         help.
5417         * user-regs.c (_initialize_user_regs): Remove trailing newline
5418         from help.
5419         * typeprint.c (_initialize_typeprint): Remove trailing newline
5420         from help.
5421         * reverse.c (_initialize_reverse): Remove trailing newlines from
5422         help.
5423         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5424         from help.
5425         * language.c (add_set_language_command): Remove trailing newline
5426         from help.
5427         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5428         help.
5429         * disasm.c (_initialize_disasm): Remove trailing newline from
5430         help.
5431         * top.c (init_main): Remove trailing newline from help.
5432         * interps.c (_initialize_interpreter): Remove trailing newline
5433         from help.
5434         * btrace.c (_initialize_btrace): Remove trailing newlines from
5435         help.
5436         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5437         from help.
5438         * python/python.c (_initialize_python): Remove trailing newline
5439         from help.
5440         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5441         help.
5442         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5443         from help.  Reformat some text.
5444         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5445         from help.
5446         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5447         newline from help.
5448
5449 2019-06-11  Tom Tromey  <tromey@adacore.com>
5450
5451         * darwin-nat.c (darwin_decode_exception_message)
5452         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5453
5454 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5455
5456         * valops.c (value_slice): Check for not allocated or not
5457         associated values.
5458
5459 2019-06-10  Tom de Vries  <tdevries@suse.de>
5460
5461         PR gdb/24618
5462         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5463         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5464         invalid.
5465
5466 2019-06-10  Tom de Vries  <tdevries@suse.de>
5467
5468         PR gdb/24611
5469         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5470         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5471
5472 2019-06-10  Tom de Vries  <tdevries@suse.de>
5473
5474         PR symtab/24545
5475         * symtab.c (struct demangled_name_entry): Add language field.
5476         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5477         static minimal symbol".  Set and use language field.
5478
5479 2019-06-10  Tom Tromey  <tromey@adacore.com>
5480
5481         * ada-lang.c (_initialize_ada_language): Update help text.
5482
5483 2019-06-10  Tom Tromey  <tromey@adacore.com>
5484
5485         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5486         with a newline.
5487         * guile/guile.c (handle_boot_error): Don't end warning with a
5488         newline.
5489         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5490         warning with a newline.
5491         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5492         newline.
5493         (s12z_frame_cache): Likewise.
5494         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5495         a newline.
5496         * solib-svr4.c (disable_probes_interface): Don't end warning with
5497         a newline.
5498         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5499         newline.
5500         * python/python.c (do_finish_initialization): Don't end warning
5501         with a newline.
5502
5503 2019-06-10  Tom Tromey  <tom@tromey.com>
5504
5505         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5506         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5507         gdbpy_enter.
5508
5509 2019-06-10  Tom Tromey  <tromey@adacore.com>
5510
5511         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5512         data.
5513         (elf_new_init): Don't call stabsread_new_init.
5514         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5515         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5516         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5517
5518 2019-06-10  Tom de Vries  <tdevries@suse.de>
5519
5520         PR symtab/16264
5521         PR symtab/24517
5522         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5523
5524 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5525
5526         * source.c (find_and_open_source): Also rewrite relative file
5527         names.
5528
5529 2019-04-26  Amos Bird  <amosbird@gmail.com>
5530
5531         * annotate.c (annotate_thread_exited): Add "thread-exited"
5532         annotation.
5533
5534 2019-06-06  Tom Tromey  <tromey@adacore.com>
5535
5536         * maint.h (class scoped_command_stats): Use
5537         DISABLE_COPY_AND_ASSIGN.
5538         <print_time>: New method.
5539         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5540         print_time.
5541         (scoped_command_stats::print_time): New method.
5542
5543 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5546         instructions of lengths 6 or 8 bytes.
5547
5548 2019-06-04  Pedro Alves  <palves@redhat.com>
5549
5550         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5551
5552         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5553         * breakpoint.c (condition_completer): Likewise.
5554         * cli/cli-dump.c (scan_expression): Likewise.
5555         * common/filestuff.c (mkdir_recursive): Likewise.
5556         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5557         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5558         (gdb_abspath): Likewise.
5559         * compile/compile-cplus-types.c
5560         (compile_cplus_instance::decl_name): Likewise.
5561         * completer.c (complete_explicit_location):
5562         (signal_completer, reg_or_group_completer_1): Likewise.
5563         * cp-support.c (cp_remove_params_if_any): Likewise.
5564         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5565         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5566         * infcmd.c (strip_bg_char): Likewise.
5567         * linespec.c (copy_token_string): Likewise.
5568         * mi/mi-main.c (output_cores): Likewise.
5569         * psymtab.c (psymtab_search_name):
5570         * symfile.c (test_set_ext_lang_command): Likewise.
5571         * target.c (target_fileio_read_stralloc): Likewise.
5572         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5573         * value.c (complete_internalvar): Likewise.
5574
5575 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5576
5577         Add objfile property to gdb.Type.
5578         * NEWS: Mention Python API addition.
5579         * python/py-type.c (typy_get_objfile): New method.
5580
5581 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5582
5583         * NEWS: Mention the new set|show style [title|highlight].
5584         Mention changes to "show style", "help" and "apropos".
5585
5586 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5587
5588         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5589         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5590         instead of print_help_for_command.
5591         (print_doc_of_command): New function.
5592         (help_list): Add 'apropos -v word' suggestion.
5593         (print_help_for_command): Style the command name using title style.
5594         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5595         (_initialize_cli_cmds): Describe -v in apropos_command help.
5596
5597 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5598
5599         * cli/cli-style.h (cli_style_option): Add name in constructor,
5600         add m_name class member, add constructor with intensity,
5601         add name class function.
5602         (cli_style_option::add_setshow_commands): Remove name argument.
5603         (highlight_style, title_style): New styles.
5604         * cli/cli-style.c (do_show): New function that shows a style
5605         characteristic styling the style name with itself.
5606         (set_style_name): New function.
5607         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5608         Update all callers according to the changes in cli/cli-style.h.
5609         * utils.h (fputs_highlighted): New function.
5610         * utils.c (fputs_highlighted): Likewise.
5611
5612 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5613
5614         * NEWS: Mention new pipe command and new convenience variables.
5615
5616 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5617
5618         * cli/cli-cmds.c (pipe_command): New function.
5619         (_initialize_cli_cmds): Call add_com for pipe_command.
5620         Define | as an alias for pipe.
5621         (exit_status_set_internal_vars): New function.
5622         (shell_escape): Call exit_status_set_internal_vars.
5623         cli/cli-decode.c (find_command_name_length): Recognize | as
5624         a single character command.
5625
5626 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5629         top.c (execute_command_to_ui_file): New function, mostly a copy
5630         of execute_command_to_string.
5631         (execute_command_to_string): Implement by calling
5632         execute_command_to_ui_file.
5633
5634 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5635
5636         * top.h (saved_command_line): Remove declaration.
5637         * top.c (previous_saved_command_line, previous_repeat_arguments):
5638         New variables.
5639         (saved_command_line): Make static, define together with other
5640         'repeat variables'.
5641         (dont_repeat): Clear repeat_arguments.
5642         (repeat_previous, get_saved_command_line, save_command_line):
5643         New functions.
5644         (gdb_init): Initialize saved_command_line
5645         and previous_saved_command_line.
5646         * main.c (captured_main_1): Remove saved_command_line initialization.
5647         * event-top.c (handle_line_of_input): Update to use
5648         the new 'repeat' related functions instead of direct access to
5649         saved_command_line.
5650         * command.h (repeat_previous, get_saved_command_line,
5651         save_command_line): New declarations.
5652         (dont_repeat): Add comment.
5653
5654 2019-05-30  Tom Tromey  <tromey@adacore.com>
5655
5656         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5657         Fix comment.
5658         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5659
5660 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5661
5662         PR cli/24587
5663         * completer.c (complete): Initialize variable word.
5664
5665 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5666
5667         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5668         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5669         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5670         'body' is NULL to the outter 'if', protecting the '!is_define'
5671         situation as well.
5672
5673 2019-05-29  Tom Tromey  <tromey@adacore.com>
5674
5675         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5676         (dwarf_unknown): New function.
5677         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5678         (dwarf_type_encoding_name): Use dwarf_unknown.
5679
5680 2019-05-29  Tom Tromey  <tromey@adacore.com>
5681
5682         PR c++/20020:
5683         * cp-valprint.c (cp_print_value_fields): Call
5684         cp_print_static_field inside "try".
5685
5686 2019-05-29  Tom Tromey  <tromey@adacore.com>
5687
5688         * inflow.c (struct terminal_info): Add default operator=.
5689         * configure: Rebuild.
5690         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5691         -Wdeprecated-copy-dtor, -Wredundant-move.
5692
5693 2019-05-29  Tom Tromey  <tromey@adacore.com>
5694
5695         * NEWS: Add entry.
5696         * infcmd.c (print_return_value_1): Handle finish_print
5697         option.
5698         (show_print_finish): New function.
5699         (_initialize_infcmd): Add "set/show print finish" commands.
5700         * valprint.c (user_print_options): Initialize new member.
5701         * valprint.h (struct value_print_options) <finish_print>: New
5702         member.
5703
5704 2019-05-28  Tom Tromey  <tromey@adacore.com>
5705
5706         * ada-lang.c (ada_remove_Xbn_suffix)
5707         (find_old_style_renaming_symbol)
5708         (parse_old_style_renaming): Remove.
5709         (ada_find_renaming_symbol): Don't call
5710         find_old_style_renaming_symbol.
5711         (ada_is_renaming_symbol): Rename from
5712         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5713         bool.  Now static.
5714         (ada_read_var_value): Update and simplify.
5715         * ada-exp.y (write_var_or_type): Remove old code.
5716
5717 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5718
5719         * event-top.c: Remove include comment.
5720         * inflow.c (class scoped_ignore_sigttou): Move from here...
5721         * inflow.h (class scoped_ignore_sigttou): ...to here.
5722         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5723         * top.c:  Remove include comment.
5724
5725 2019-05-27  Tom Tromey  <tom@tromey.com>
5726
5727         * NEWS: Fix typo.
5728
5729 2019-05-22  Tom Tromey  <tromey@adacore.com>
5730
5731         * target.c (target_follow_exec): Constify parameter.
5732         * target-delegates.c: Rebuild.
5733         * remote.c (remote_target::follow_exec): Constify parameter.
5734         * infrun.c (follow_exec): Constify parameter.
5735         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5736         (target_follow_exec): Likewise.
5737
5738 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5739
5740         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5741         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5742
5743 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * NEWS: Add debugredirect and testsuite sections.
5746
5747 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5748
5749         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5750         target descriptions using exclusively floating point register name
5751         aliases.
5752
5753 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5754
5755         PR gdb/18644:
5756         * f-lang.c (build_fortran_types): Handle the case where
5757         gdbarch_floatformat_for_type returns a nullptr.
5758
5759 2019-05-21  Tom de Vries  <tdevries@suse.de>
5760
5761         PR cli/24587
5762         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5763
5764 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5765
5766         PR gdb/18644:
5767         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5768         16-byte floats.
5769         * i386-tdep.c (i386_floatformat_for_type): Use
5770         floatformats_ia64_quad for the 16-byte floating point component
5771         within a fortran 32-byte complex number.
5772
5773 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5774
5775         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5776         delete default constructor.
5777         (find_partial_die): Update to return const struct.
5778         (partial_die_parent_scope): Move variable declaration into scope
5779         of its use and change its type to auto.
5780         (guess_partial_die_structure_name): Likewise.
5781         (partial_die_info::fixup): Likewise.
5782
5783 2019-05-17  Tom Tromey  <tromey@adacore.com>
5784
5785         * source.c (find_and_open_source): Remove cast.
5786
5787 2019-05-17  Tom Tromey  <tromey@adacore.com>
5788
5789         * annotate.c (annotate_source): Make "filename" const.
5790         * annotate.h (annotate_source): Use const.
5791
5792 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5793
5794         * disasm.c (set_disassembler_options): Send errors to stderr.
5795
5796 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5797
5798         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5799         (cli_interp_base::set_logging): Check debug_redirect.
5800         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5801         * cli/cli-logging.c (debug_redirect): Add static variable.
5802         (pop_output_files): Add default param.
5803         (handle_redirections): Print debug setting.
5804         (show_logging_command): Likewise.
5805         (_initialize_cli_logging): Add debugredirect command.
5806         * interps.c (current_interp_set_logging): Add debug_redirect
5807         parameter.
5808         * interps.h (set_logging): Add debug_redirect parameter.
5809         (current_interp_set_logging): Likewise.
5810         * mi/mi-common.h: Likewise.
5811         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5812
5813 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5814             Tom Tromey  <tromey@adacore.com>
5815
5816         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5817         directly.
5818         * cli/cli-interp.h (make_logging_output): Remove declaration.
5819         * cli/cli-logging.c (make_logging_output): Remove function.
5820         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5821         directly.
5822         * ui-file.c (tee_file::tee_file): Remove bools.
5823         (tee_file::~tee_file): Remove deletes.
5824         * ui-file.h (tee_file): Remove bools.
5825
5826 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5827
5828         * mi/mi-cmds.h (mi_cmd_complete): New function.
5829         * mi/mi-main.c (mi_cmd_complete): Likewise.
5830         * mi/mi-cmds.c: Define new MI command -complete.
5831         * NEWS: Mention new -complete command.
5832
5833 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5834
5835         * completer.h (complete): New function.
5836         * completer.c (complete): Likewise.
5837         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5838         function defined in completer.h.
5839
5840 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5841
5842         * MAINTAINERS (Write After Approval): Add myself.
5843
5844 2019-05-17  Tom de Vries  <tdevries@suse.de>
5845
5846         PR gdb/24094
5847         * dwarf2read.c (struct cu_partial_die_info): New struct.
5848         (find_partial_die): Return cu_partial_die_info.
5849         (partial_die_parent_scope, guess_partial_die_structure_name)
5850         (partial_die_info::fixup): Handle new return type of find_partial_die.
5851
5852 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5853
5854         PR breakpoints/24541
5855         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5856         "std::string", simplifying the algorithm.
5857
5858 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5859
5860         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5861         (stap_static_probe_ops::get_probes): Likewise.
5862
5863 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5864
5865         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5866         '-')" and "else if".
5867         (stap_parse_single_operand): Join checks for
5868         "gdbarch_stap_parse_special_token_p" and
5869         "gdbarch_stap_parse_special_token" in the same "if" statement.
5870         Invert check when verifying for operation on register
5871         displacement.
5872
5873 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5874
5875         * stap-probe.c (stap_get_opcode): Update comment.
5876         (stap_get_expected_argument_type): Likewise.
5877         (handle_stap_probe): Likewise.
5878
5879 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5880
5881         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5882         return type to 'bool'.  Adjust comment.  Use 'bool' when
5883         appropriate.
5884         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5885         * stap-probe.c (stap_parse_argument_1): Likewise.
5886         (stap_is_operator): Likewise.
5887         (stap_is_generic_prefix): Likewise.
5888         (stap_is_register_prefix): Likewise.
5889         (stap_is_register_indirection_prefix): Likewise.
5890         (stap_is_integer_prefix): Likewise.
5891         (stap_generic_check_suffix): Likewise.
5892         (stap_check_integer_suffix): Likewise.
5893         (stap_check_register_suffix): Likewise.
5894         (stap_check_register_indirection_suffix): Likewise.
5895         (stap_parse_register_operand): Likewise.
5896         (stap_parse_single_operand): Likewise.
5897         (stap_parse_argument_1): Likewise.
5898         (stap_probe::get_argument_count): Likewise.
5899         (stap_is_operator): Likewise.
5900
5901 2019-05-16  Tom Tromey  <tromey@adacore.com>
5902
5903         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5904         keyword to foreach.
5905
5906 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5907
5908         * linux-thread-db.c (try_thread_db_load_1): Change return type
5909         to bool.
5910         (try_thread_db_load): Likewise.
5911         (try_thread_db_load_from_pdir_1): Likewise.
5912         (try_thread_db_load_from_pdir): Likewise.
5913         (try_thread_db_load_from_sdir): Likewise.
5914         (try_thread_db_load_from_dir): Likewise.
5915         (thread_db_load_search): Likewise.
5916         (has_libpthread): Likewise.
5917         (thread_db_load): Likewise.
5918
5919 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5920
5921         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5922         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5923         NULL, and complain/return if that's the case.
5924
5925 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5926
5927         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5928         (advance, posn, abstract_read_memory): New functions.
5929         [struct mem_read_abstraction]: New struct.
5930         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5931
5932 2019-05-14  Tom Tromey  <tromey@adacore.com>
5933
5934         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5935         value is not lval_memory.
5936
5937 2019-05-14  Tom Tromey  <tromey@adacore.com>
5938
5939         * solib.c (info_sharedlibrary_command): Style the file name.
5940
5941 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5942
5943         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5944         (aarch64_vnv_type): Likewise.
5945         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5946         * common/tdesc.c: Likewise.
5947         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5948         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5949         * features/aarch64-fpu.xml: Add ieee half view.
5950         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5951         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5952         * gdbtypes.h (struct builtin_type): Likewise.
5953         (struct objfile_type): Likewise.
5954
5955 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5956
5957         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5958         typo.
5959         * location.h (string_to_event_location): Likewise.
5960
5961 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5962
5963         GDB 8.3 released.
5964
5965 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5966
5967         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5968         New variable declaration.
5969         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5970         New variable.
5971         (print_one_breakpoint): Use ui_out::test_flags and new global
5972         variable to compute use_fixed_output.
5973         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5974         Remove.
5975         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5976         (mi_multi_location_breakpoint_output_fixed): Remove.
5977         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5978         new variable.
5979         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5980         fix_multi_location_breakpoint_output flag if version >= 3.
5981         * ui-out.h (enum ui_out_flag)
5982         <fix_multi_location_breakpoint_output>: New enumerator.
5983
5984 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5985
5986         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5987
5988 2019-05-10  Tom Tromey  <tromey@adacore.com>
5989
5990         * ada-lang.c (catch_ada_completer): New function.
5991         (_initialize_ada_language): Use it.
5992
5993 2019-05-10  Tom Tromey  <tromey@adacore.com>
5994
5995         * thread.c (print_thread_info): Make "requested_threads" const.
5996         * gdbthread.h (print_thread_info): Make "requested_threads"
5997         const.
5998         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5999         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6000
6001 2019-05-08  Tom Tromey  <tom@tromey.com>
6002
6003         * gdbtypes.c (objfile_type_data): Change type.
6004         (objfile_type, _initialize_gdbtypes): Update.
6005
6006 2019-05-08  Tom Tromey  <tom@tromey.com>
6007
6008         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6009         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6010         (_initialize_dwarf2_frame): Update.
6011
6012 2019-05-08  Tom Tromey  <tom@tromey.com>
6013
6014         * objc-lang.c (objc_objfile_data): Change type.
6015         (find_methods): Update.
6016         (_initialize_objc_lang): Remove.
6017
6018 2019-05-08  Tom Tromey  <tom@tromey.com>
6019
6020         * stabsread.c (rs6000_builtin_type_data): Change type.
6021         (rs6000_builtin_type, _initialize_stabsread): Update.
6022
6023 2019-05-08  Tom Tromey  <tom@tromey.com>
6024
6025         * mips-tdep.c (mips_pdr_data): Remove.
6026         (_initialize_mips_tdep): Update.
6027
6028 2019-05-08  Tom Tromey  <tom@tromey.com>
6029
6030         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6031         (hppa_init_objfile_priv_data, read_unwind_info)
6032         (find_unwind_entry, _initialize_hppa_tdep): Update.
6033
6034 2019-05-08  Tom Tromey  <tom@tromey.com>
6035
6036         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6037         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6038         on obstack.
6039         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6040
6041 2019-05-08  Tom Tromey  <tom@tromey.com>
6042
6043         * mdebugread.c (basic_type_data): Change type.
6044         (basic_type, _initialize_mdebugread): Update.
6045
6046 2019-05-08  Tom Tromey  <tom@tromey.com>
6047
6048         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6049
6050 2019-05-08  Tom Tromey  <tom@tromey.com>
6051
6052         * nto-tdep.c (nto_inferior_data_reg): Change type.
6053         (nto_inferior_data): Update.
6054         (nto_inferior_data_cleanup, nto_new_inferior_data)
6055         (_initialize_nto_tdep): Remove.
6056         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6057
6058 2019-05-08  Tom Tromey  <tom@tromey.com>
6059
6060         * ada-lang.c (struct ada_inferior_data): Add initializers.
6061         (ada_inferior_data): Change type.
6062         (ada_inferior_data_cleanup): Remove.
6063         (get_ada_inferior_data, ada_inferior_exit)
6064         (struct ada_pspace_data): Add initializers, destructor.
6065         (ada_pspace_data_handle): Change type.
6066         (get_ada_pspace_data): Update.
6067         (ada_pspace_data_cleanup): Remove.
6068
6069 2019-05-08  Tom Tromey  <tom@tromey.com>
6070
6071         * coffread.c (struct coff_symfile_info): Add initializers.
6072         (coff_objfile_data_key): Move lower.  Change type.
6073         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6074         Update.
6075         (coff_free_info): Remove.
6076
6077 2019-05-08  Tom Tromey  <tom@tromey.com>
6078
6079         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6080         (fbsd_pspace_data_handle): Move lower.  Change type.
6081         (get_fbsd_pspace_data): Update.
6082         (fbsd_pspace_data_cleanup): Remove.
6083         (_initialize_fbsd_tdep): Update.
6084
6085 2019-05-08  Tom Tromey  <tom@tromey.com>
6086
6087         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6088         (get_ada_tasks_pspace_data): Update.
6089         (ada_tasks_pspace_data_cleanup): Remove.
6090         (_initialize_tasks): Update.
6091         (ada_tasks_inferior_data_handle): Change type.
6092         (get_ada_tasks_inferior_data): Update.
6093         (ada_tasks_inferior_data_cleanup): Remove.
6094         (struct ada_tasks_pspace_data): Add initializers.
6095
6096 2019-05-08  Tom Tromey  <tom@tromey.com>
6097
6098         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6099         * symfile-debug.c (debug_sym_get_probes): Change type.
6100         * stap-probe.c (handle_stap_probe):
6101         (stap_static_probe_ops::get_probes): Change type.
6102         * probe.h (class static_probe_ops) <get_probes>: Change type.
6103         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6104         (parse_probes_in_pspace): Update.
6105         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6106         Update.
6107         (any_static_probe_ops::get_probes): Change type.
6108         * elfread.c (elfread_data): New typedef.
6109         (probe_key): Change type.
6110         (elf_get_probes): Likewise.  Update.
6111         (probe_key_free): Remove.
6112         (_initialize_elfread): Update.
6113         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6114         Change type.
6115         (dtrace_process_dof_probe, dtrace_process_dof)
6116         (dtrace_static_probe_ops::get_probe): Change type.
6117
6118 2019-05-08  Tom Tromey  <tom@tromey.com>
6119
6120         * xcoffread.c (struct xcoff_symfile_info): Rename from
6121         coff_symfile_info.  Add initializers.
6122         (xcoff_objfile_data_key): Move lower.  Change type.
6123         (XCOFF_DATA): Rewrite.
6124         (xcoff_free_info): Remove.
6125         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6126         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6127         (xcoff_initial_scan): Update.
6128
6129 2019-05-08  Tom Tromey  <tom@tromey.com>
6130
6131         * solib-svr4.c (struct svr4_info): Add initializers and
6132         destructor.
6133         <probes_table>: Now an htab_up.
6134         (solib_svr4_pspace_data): Change type.
6135         (free_probes_table): Simplify.
6136         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6137         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6138         (probes_table_remove_objfile_probes, register_solib_event_probe)
6139         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6140         (_initialize_svr4_solib): Update.
6141
6142 2019-05-08  Tom Tromey  <tom@tromey.com>
6143
6144         * remote.c (remote_pspace_data): Change type.
6145         (remote_pspace_data_cleanup): Remove.
6146         (get_remote_exec_file, set_pspace_remote_exec_file)
6147         (_initialize_remote): Update.
6148
6149 2019-05-08  Tom Tromey  <tom@tromey.com>
6150
6151         * breakpoint.c (breakpoint_objfile_key): Change type.
6152         (get_breakpoint_objfile_data): Update.
6153         (free_breakpoint_objfile_data): Remove.
6154         (_initialize_breakpoint): Update.
6155
6156 2019-05-08  Tom Tromey  <tom@tromey.com>
6157
6158         * linux-tdep.c (struct linux_info): Add initializers.
6159         (linux_inferior_data): Move.  Change type.
6160         (invalidate_linux_cache_inf): Update.
6161         (linux_inferior_data_cleanup): Remove.
6162         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6163
6164 2019-05-08  Tom Tromey  <tom@tromey.com>
6165
6166         * auxv.c (auxv_inferior_data): Move.  Change type.
6167         (auxv_inferior_data_cleanup): Remove.
6168         (invalidate_auxv_cache_inf): Rewrite.
6169         (get_auxv_inferior_data, _initialize_auxv): Update.
6170
6171 2019-05-08  Tom Tromey  <tom@tromey.com>
6172
6173         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6174         (symfile_debug_objfile_data_key): Change type.
6175         (symfile_debug_installed, debug_qf_has_symbols)
6176         (debug_qf_find_last_source_symtab)
6177         (debug_qf_forget_cached_source_info)
6178         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6179         (debug_qf_print_stats, debug_qf_dump)
6180         (debug_qf_expand_symtabs_for_function)
6181         (debug_qf_expand_all_symtabs)
6182         (debug_qf_expand_symtabs_with_fullname)
6183         (debug_qf_map_matching_symbols)
6184         (debug_qf_expand_symtabs_matching)
6185         (debug_qf_find_pc_sect_compunit_symtab)
6186         (debug_qf_map_symbol_filenames)
6187         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6188         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6189         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6190         (debug_sym_read_linetable, debug_sym_relocate): Update.
6191         (symfile_debug_free_objfile): Remove.
6192         (install_symfile_debug_logging, _initialize_symfile_debug):
6193         Update.
6194
6195 2019-05-08  Tom Tromey  <tom@tromey.com>
6196
6197         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6198         allocate_on_obstack.
6199         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6200         (get_dwarf2_per_objfile): Update.
6201         (set_dwarf2_per_objfile): Remove.
6202         (dwarf2_has_info, dwarf2_get_section_info): Update.
6203         (dwarf2_free_objfile): Remove.
6204         (_initialize_dwarf2_read): Update.
6205
6206 2019-05-08  Tom Tromey  <tom@tromey.com>
6207
6208         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6209         initializers.
6210         <unsupported_script_warning_printed,
6211         script_not_found_warning_printed>: Now bool.
6212         (auto_load_pspace_data): Change type.
6213         (~auto_load_pspace_info): Rename from
6214         auto_load_pspace_data_cleanup.
6215         (get_auto_load_pspace_data, init_loaded_scripts_info)
6216         (clear_section_scripts, maybe_print_unsupported_script_warning)
6217         (maybe_print_script_not_found_warning, _initialize_auto_load):
6218         Update.
6219
6220 2019-05-08  Tom Tromey  <tom@tromey.com>
6221
6222         * objfiles.c (objfile_pspace_info): Add destructor and
6223         initializers.
6224         (objfiles_pspace_data): Change type.
6225         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6226         (get_objfile_pspace_data): Update.
6227         (objfiles_bfd_data): Change type.
6228         (get_objfile_bfd_data): Update.
6229         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6230
6231 2019-05-08  Tom Tromey  <tom@tromey.com>
6232
6233         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6234         Change type.
6235         (get_catch_syscall_inferior_data): Update.
6236         (catch_syscall_inferior_data_cleanup): Remove.
6237         (_initialize_break_catch_syscall): Update.
6238
6239 2019-05-08  Tom Tromey  <tom@tromey.com>
6240
6241         * inflow.c (struct terminal_info): Add destructor and
6242         initializers.
6243         (inflow_inferior_data): Change type.
6244         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6245         (get_inflow_inferior_data, inflow_inferior_exit)
6246         (swap_terminal_info, _initialize_inflow): Update.
6247
6248 2019-05-08  Tom Tromey  <tom@tromey.com>
6249
6250         * target-dcache.c (target_dcache_cleanup): Remove.
6251         (target_dcache_aspace_key): Change type.
6252         (target_dcache_init_p, target_dcache_invalidate)
6253         (target_dcache_get, target_dcache_get_or_init)
6254         (_initialize_target_dcache): Update.
6255         * dcache.h (struct dcache_deleter): New.
6256
6257 2019-05-08  Tom Tromey  <tom@tromey.com>
6258
6259         * symtab.c (struct symbol_cache): Add destructor and
6260         initializers.
6261         (symbol_cache_key): Move.  Change type.
6262         (make_symbol_cache, free_symbol_cache): Remove.
6263         (get_symbol_cache): Update.
6264         (symbol_cache_cleanup): Remove.
6265         (ALL_PSPACES, symbol_cache_flush)
6266         (maintenance_print_symbol_cache)
6267         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6268         Update.
6269
6270 2019-05-08  Tom Tromey  <tom@tromey.com>
6271
6272         * symtab.c (struct main_info): Add destructor and initializers.
6273         (main_progspace_key): Move.  Change type.
6274         (get_main_info): Update.
6275         (main_info_cleanup): Remove.
6276         (_initialize_symtab): Update.
6277
6278 2019-05-08  Tom Tromey  <tom@tromey.com>
6279
6280         * registry.h (DECLARE_REGISTRY): Define the _key class.
6281
6282 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * NEWS: Merge two 'New commands' sections.
6285
6286 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6287
6288         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6289         parameter and use Ada language definition instead.
6290         (ada_val_print_ptr): Remove unused language parameter.
6291         (ada_val_print_num): Remove language parameter and use Ada language
6292         definition instead.
6293         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6294         parameter.
6295         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6296         parameter and use Ada language definition instead.
6297         (ada_val_print_1): Update all ada_val_print_xxx calls.
6298         Remove language parameter.
6299         (ada_val_print): Update ada_val_print_1 call.
6300
6301 2019-05-08  Tom Tromey  <tromey@adacore.com>
6302
6303         * remote.c (remote_hw_watchpoint_limit)
6304         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6305         Now static.
6306
6307 2019-05-08  Tom Tromey  <tromey@adacore.com>
6308
6309         * maint.c (_initialize_maint_cmds): Move initialization code to
6310         remote.c.
6311         (watchdog, show_watchdog): Move to remote.c.
6312         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6313         "watchdog" static.
6314         (_initialize_remote): Move initialization code from maint.c.
6315         * defs.h (watchdog): Don't declare.
6316
6317 2019-05-08  Tom Tromey  <tromey@adacore.com>
6318
6319         * tui/tui-interp.c: Include main.h.
6320         * interps.c: Include main.h.
6321         * main.h (interpreter_p): Declare.
6322         * defs.h (interpreter_p): Don't declare.
6323
6324 2019-05-08  Tom Tromey  <tromey@adacore.com>
6325
6326         * dwarf2loc.c: Include dwarf2read.h.
6327         * defs.h (read_unsigned_leb128): Don't declare.
6328         * dwarf2read.h (read_unsigned_leb128): Declare.
6329
6330 2019-05-08  Tom Tromey  <tromey@adacore.com>
6331
6332         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6333         method.
6334
6335 2019-05-08  Tom Tromey  <tromey@adacore.com>
6336
6337         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6338         when no wrap column is set.
6339
6340 2019-05-08  Tom Tromey  <tromey@adacore.com>
6341
6342         * c-lang.c (c_get_string): Handle non-C-style arrays.
6343
6344 2019-05-08  Tom Tromey  <tromey@adacore.com>
6345
6346         * typeprint.c (print_offset_data::update): Print the bit offset,
6347         not the number of bits remaining.
6348
6349 2019-05-08  Tom Tromey  <tromey@adacore.com>
6350
6351         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6352         padding at end of comment.
6353
6354 2019-05-08  Tom Tromey  <tromey@adacore.com>
6355
6356         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6357         Compare main types.
6358
6359 2019-05-06  Tom Tromey  <tom@tromey.com>
6360
6361         * common/scoped_mmap.c: Include common-defs.h.
6362         * common/scoped_mmap.h: Don't include config.h.
6363
6364 2019-05-04  Tom Tromey  <tom@tromey.com>
6365
6366         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6367         (struct aarch64_call_info): Add initializers.
6368         <si>: Now a std::vector.
6369         (pass_on_stack, aarch64_push_dummy_call): Update.
6370
6371 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6372             Tom Tromey  <tom@tromey.com>
6373
6374         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6375         (ppc_threads): Now a std::vector.  Now static.
6376         (hwdebug_find_thread_points_by_tid)
6377         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6378         Update.
6379
6380 2019-05-04  Tom Tromey  <tom@tromey.com>
6381
6382         * arc-tdep.c (arc_tdesc_init): Return bool.
6383
6384 2019-05-04  Tom Tromey  <tom@tromey.com>
6385
6386         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6387         Use gdb_assert_not_reached.
6388
6389 2019-05-04  Tom Tromey  <tom@tromey.com>
6390
6391         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6392         "false".
6393
6394 2019-05-04  Tom Tromey  <tom@tromey.com>
6395
6396         * arc-tdep.c (arc_tdesc_init): Use bool.
6397
6398 2019-05-04  Tom Tromey  <tom@tromey.com>
6399
6400         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6401
6402 2019-05-04  Tom Tromey  <tom@tromey.com>
6403
6404         * cli/cli-cmds.c (valid_command_p): Return bool.
6405
6406 2019-05-04  Tom Tromey  <tom@tromey.com>
6407
6408         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6409         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6410
6411 2019-05-04  Raul Tambre  <raul@tambre.ee>
6412
6413         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6414         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6415         operator for comparison.
6416
6417 2019-05-04  Tom Tromey  <tom@tromey.com>
6418
6419         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6420         (lookup_partial_symbol, print_partial_symbols)
6421         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6422         (psymbol_compare): Update.
6423         (add_psymbol_to_bcache): Clear the entire psymbol.
6424         (maintenance_check_psymtabs): Update.
6425         * psympriv.h (struct partial_symbol): Don't derive from
6426         general_symbol_info.
6427         <obj_section, unrelocated_address, address,
6428         set_unrelocated_address>: Update.
6429         <ginfo>: New member.
6430         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6431         (debug_names::write_psymbols): Update.
6432
6433 2019-05-04  Tom de Vries  <tdevries@suse.de>
6434
6435         * contrib/cc-with-tweaks.sh: Support -n arg.
6436
6437 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6438
6439         * corelow.c (core_target::detach): Ensure frame cache and
6440         register caches are cleared.
6441         inferior.c (exit_inferior_1): Likewise.
6442
6443 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6444             Tom Tromey  <tom@tromey.com>
6445
6446         * dictionary.c (collate_pending_symbols_by_language): Remove
6447         "struct" from foreach.
6448         * symtab.c (lookup_global_symbol_from_objfile)
6449         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6450         foreach.
6451         * ser-tcp.c (net_open): Remove "struct" from foreach.
6452         * objfiles.c (objfile_relocate, objfile_rebase)
6453         (objfile_has_symbols): Remove "struct" from foreach.
6454         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6455         from foreach.
6456         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6457         foreach.
6458         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6459         "struct" from foreach.
6460         * ada-lang.c (create_excep_cond_exprs)
6461         (ada_exception_catchpoint_cond_string): Remove "struct" from
6462         foreach.
6463
6464 2019-05-03  Tom Tromey  <tromey@adacore.com>
6465
6466         * ada-exp.y (convert_char_literal): Check suffix of each
6467         enumerator.
6468
6469 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6470
6471         PR ada/21406:
6472         * ada-exp.y (yywrap): Don't define.
6473         * ada-lex.l (%option): Add noyywrap
6474         (yywrap): Remove.
6475
6476 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6477
6478         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6479         _WIN32_WINNT to the XP level, unless already defined to a higher
6480         level.
6481
6482         * unittests/parse-connection-spec-selftests.c:
6483         * ser-tcp.c:
6484         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6485         override.
6486
6487         * symfile.c (find_separate_debug_file): Remove colon from the
6488         drive spec of DOS/Windows file names of the target, so that the
6489         file name produced from DEBUGDIR and the target's directory will
6490         be valid on DOS/Windows systems.
6491
6492 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * rust-lang.c (val_print_struct): Handle printing structures
6495         containing strings.
6496
6497 2019-05-02  Tom Tromey  <tromey@adacore.com>
6498
6499         * valarith.c (_initialize_valarith): Remove.
6500
6501 2019-05-01  Tom Tromey  <tromey@adacore.com>
6502
6503         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6504         bitfields.
6505
6506 2019-05-01  Tom Tromey  <tromey@adacore.com>
6507
6508         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6509         for big-endian copies.
6510
6511 2019-04-30  Ali Tamur  <tamur@google.com>
6512         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6513         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6514         (read_3_bytes): New function.
6515
6516 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6517
6518         * windows-nat.c (main_thread_id): Delete.
6519         (handle_output_debug_string): Replace main_thread_id by
6520         current_event.dwThreadId.
6521         (fake_create_process): Likewise.
6522         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6523         Do not set main_thread_id.
6524         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6525         current_event.dwThreadId.
6526         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6527
6528 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6529
6530         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6531         Use current_event.dwThreadId instead of main_thread_id.
6532
6533 2019-04-30  Tom Tromey  <tromey@adacore.com>
6534
6535         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6536         (create_excep_cond_exprs): Iterate over program spaces.
6537         (ada_exception_catchpoint_cond_string): Examine all minimal
6538         symbols for exception types.
6539
6540 2019-04-30  Tom Tromey  <tromey@adacore.com>
6541
6542         PR c++/24470:
6543         * dwarf2read.c (process_structure_scope): Handle case where type
6544         has template parameters but no symbol was created.
6545
6546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6547             Chris January  <chris.january@arm.com>
6548
6549         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6550         qualifier.
6551         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6552
6553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * f-typeprint.c (f_print_type): Update rules for printing
6556         whitespace.
6557         (f_type_print_varspec_suffix): Likewise.
6558
6559 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6560             Chris January  <chris.january@arm.com>
6561
6562         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6563         function arguments.
6564
6565 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6566
6567         * f-lang.c (build_fortran_types): Change name of void type to
6568         lower case.
6569         * f-typeprint.c (f_type_print_base): Print the name of the void
6570         type, rather than a fixed string.
6571         * f-valprint.c (f_decorations): Use lower case void string.
6572
6573 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6574             Chris January  <chris.january@arm.com>
6575
6576         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6577         types for Fortran.
6578
6579 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6580             Chris January  <chris.january@arm.com>
6581             David Lecomber  <david.lecomber@arm.com>
6582
6583         * f-exp.y (BINOP_INTRINSIC): New token.
6584         (exp): New parser rule handling BINOP_INTRINSIC.
6585         (f77_keywords): Add new builtin procedures.
6586         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6587         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6588         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6589         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6590         (print_unop_subexp_f): New function.
6591         (print_binop_subexp_f): New function.
6592         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6593         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6594         (dump_subexp_body_f): Likewise.
6595         (operator_check_f): Likewise.
6596         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6597         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6598
6599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6600
6601         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6602         UNOP_KIND.
6603         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6604         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6605         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6606         (operator_length_f): New fuction.
6607         (print_subexp_f): New function.
6608         (op_name_f): New function.
6609         (dump_subexp_body_f): New function.
6610         (operator_check_f): New function.
6611         (exp_descriptor_f): Replace standard expression handling functions
6612         with new functions.
6613         * gdb/fortran-operator.def: New file.
6614         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6615         * gdb/std-operator.def: Remove UNOP_KIND.
6616
6617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * std-operator.def: Remove unbalanced, stray double quote
6620         character.
6621
6622 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6623             Chris January  <chris.january@arm.com>
6624             Daniel Everett  <daniel.everett@arm.com>
6625             Nick Forrington  <nick.forrington@arm.com>
6626             Richard Bunt  <richard.bunt@arm.com>
6627
6628         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6629         of depth when printing anonymous structs or unions.
6630         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6631         Don't print either the top-level value, or the children if the
6632         max-depth is exceeded.
6633         (ppscm_print_children): When printing the key of a map, allow one
6634         extra level of depth.
6635         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6636         print either the top-level value, or the children if the max-depth
6637         is exceeded.
6638         (print_children): When printing the key of a map, allow one extra
6639         level of depth.
6640         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6641         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6642         (user_print_options): Initialise max_depth field.
6643         (val_print_scalar_or_string_type_p): New function.
6644         (val_print): Check to see if the max depth has been reached.
6645         (val_print_check_max_depth): Define new function.
6646         (show_print_max_depth): New function.
6647         (_initialize_valprint): Add 'print max-depth' option.
6648         * valprint.h (struct value_print_options) <max_depth>: New field.
6649         (val_print_check_max_depth): Declare new function.
6650         * NEWS: Document new feature.
6651
6652 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6653
6654         * ada-lang.c (ada_language_defn): Initialise new field.
6655         * c-lang.c (c_is_string_type_p): New function.
6656         (c_language_defn): Initialise new field.
6657         (cplus_language_defn): Initialise new field.
6658         (asm_language_defn): Initialise new field.
6659         (minimal_language_defn): Initialise new field.
6660         * c-lang.h (c_is_string_type_p): Declare new function.
6661         * d-lang.c (d_language_defn): Initialise new field.
6662         * f-lang.c (f_is_string_type_p): New function.
6663         (f_language_defn): Initialise new field.
6664         * go-lang.c (go_is_string_type_p): New function.
6665         (go_language_defn): Initialise new field.
6666         * language.c (default_is_string_type_p): New function.
6667         (unknown_language_defn): Initialise new field.
6668         (auto_language_defn): Initialise new field.
6669         * language.h (struct language_defn) <la_is_string_type_p>: New
6670         member variable.
6671         (default_is_string_type_p): Declare new function.
6672         * m2-lang.c (m2_language_defn): Initialise new field.
6673         * objc-lang.c (objc_language_defn): Initialise new field.
6674         * opencl-lang.c (opencl_language_defn): Initialise new field.
6675         * p-lang.c (pascal_is_string_type_p): New function.
6676         (pascal_language_defn): Initialise new field.
6677         * rust-lang.c (rust_is_string_type_p): New function.
6678         (rust_language_defn): Initialise new field.
6679
6680 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6683         New field.
6684         * ada-lang.c (ada_language_defn): Initialise new field.
6685         * c-lang.c (c_language_defn): Likewise.
6686         (cplus_language_defn): Likewise.
6687         (asm_language_defn): Likewise.
6688         (minimal_language_defn): Likewise.
6689         * d-lang.c (d_language_defn): Likewise.
6690         * f-lang.c (f_language_defn): Likewise.
6691         * go-lang.c (go_language_defn): Likewise.
6692         * language.c (unknown_language_defn): Likewise.
6693         (auto_language_defn): Likewise.
6694         * m2-lang.c (m2_language_defn): Likewise.
6695         * objc-lang.c (objc_language_defn): Likewise.
6696         * opencl-lang.c (opencl_language_defn): Likewise.
6697         * p-lang.c (pascal_language_defn): Likewise.
6698         * rust-lang.c (rust_language_defn): Likewise.
6699
6700 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * ada-lang.c (ada_is_character_type): Change return type to bool.
6703         (ada_is_string_type): Likewise.
6704         * ada-lang.h (ada_is_character_type): Update declaration
6705         (ada_is_string_type): Likewise.
6706
6707 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6708
6709         Support style in 'frame|thread apply'
6710
6711         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6712         * record.c (record_start, record_stop): Update callers of
6713         execute_command_to_string with false.
6714         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6715         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6716         methods.
6717         (class string_file): New constructor with term_out parameter.
6718         Override methods term_out and can_emit_style_escape.  New member
6719         term_out.
6720         (class stdio_file): Override can_emit_style_escape.
6721         (class tee_file): Override term_out and can_emit_style_escape.
6722         * utils.h (can_emit_style_escape): Remove.
6723         * utils.c (can_emit_style_escape): Likewise.
6724         Update all callers of can_emit_style_escape (SOMESTREAM) to
6725         SOMESTREAM->can_emit_style_escape.
6726         * source-cache.c (source_cache::get_source_lines): Likewise.
6727         * stack.c (frame_apply_command_count): Call execute_command_to_string
6728         passing the term_out characteristic of the current gdb_stdout.
6729         * thread.c (thr_try_catch_cmd): Likewise.
6730         * top.c (execute_command_to_string): pass term_out parameter
6731         to construct the string_file for the command output.
6732         * ui-file.c (term_cli_styling): New function (most code moved
6733         from utils.c can_emit_style_escape).
6734         (string_file::string_file, string_file::can_emit_style_escape,
6735         stdio_file::can_emit_style_escape, tee_file::term_out,
6736         tee_file::can_emit_style_escape): New functions.
6737
6738 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6739
6740         * NEWS: Mention the new set|show may-call-functions.
6741         * infcall.c (may_call_functions_p): New variable.
6742         (show_may_call_functions_p): New function.
6743         (call_function_by_hand_dummy): Throws an error if not
6744         may-call-functions.
6745         (_initialize_infcall): Call add_setshow_boolean_cmd for
6746         may-call-functions.
6747
6748 2019-04-25  Keith Seitz  <keiths@redhat.com>
6749
6750         PR c++/24367
6751         * cp-support.c (inspect_type): Don't attempt substitutions
6752         of symbol with the same name.
6753
6754 2019-04-25  Tom Tromey  <tromey@adacore.com>
6755
6756         PR gdb/24475:
6757         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6758         static.
6759
6760 2019-04-25  Tom Tromey  <tromey@adacore.com>
6761
6762         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6763         rvalue reference.
6764         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6765         (gdb_xml_parser::parse): Use std::move.
6766         * python/python-internal.h (gdbpy_convert_exception): Take a const
6767         reference.
6768         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6769         std::move.
6770         * python/py-utils.c (gdbpy_convert_exception): Take a const
6771         reference.
6772         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6773         Use std::move.
6774         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6775         Use std::move.
6776         * mi/mi-main.c (mi_print_exception): Take a const reference.
6777         * main.c (handle_command_errors): Take a const reference.
6778         * linespec.c (parse_linespec): Use std::move.
6779         * infcall.c (run_inferior_call): Use std::move.
6780         (call_function_by_hand_dummy): Use std::move.
6781         * exec.c (try_open_exec_file): Use std::move.
6782         * exceptions.h (exception_print, exception_fprintf)
6783         (exception_print_same): Update.
6784         * exceptions.c (print_exception, exception_print)
6785         (exception_fprintf, exception_print_same): Change parameters to
6786         const reference.
6787         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6788         * common/new-op.c: Use std::move.
6789         * common/common-exceptions.h (struct gdb_exception): Add move
6790         constructor.
6791         (struct gdb_exception_error, struct gdb_exception_quit, struct
6792         gdb_quit_bad_alloc): Change constructor to move constructor.
6793         (throw_exception): Change parameter to rvalue reference.
6794         * common/common-exceptions.c (throw_exception): Take rvalue
6795         reference.
6796         * cli/cli-interp.c (safe_execute_command): Use std::move.
6797         * breakpoint.c (insert_bp_location, location_to_sals): Use
6798         std::move.
6799
6800 2019-04-25  Tom Tromey  <tromey@adacore.com>
6801
6802         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6803         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6804         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6805         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6806         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6807         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6808         guile/scm-value.c: Use unpack.
6809         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6810         gdbscm_gdb_exception.
6811         (gdbscm_throw_gdb_exception): Likewise.
6812         (struct gdbscm_gdb_exception): New.
6813         (unpack): New function.
6814         (gdbscm_wrap): Use unpack.
6815
6816 2019-04-25  Tom Tromey  <tromey@adacore.com>
6817
6818         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6819         (gdb_rl_callback_handler): Use std::move.
6820         * common/common-exceptions.h (struct gdb_exception): Add move
6821         assignment operator.
6822         (throw_exception_sjlj): Change "exception" to const reference.
6823         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6824         (throw_exception_sjlj): Change "exception" to const reference.
6825
6826 2019-04-25  Tom Tromey  <tromey@adacore.com>
6827
6828         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6829         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6830         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6831         Update.
6832         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6833         Update.
6834         * mi/mi-interp.c (mi_interp::exec): Update.
6835         * linespec.c (parse_linespec): Update.
6836         * infcall.c (run_inferior_call): Update.
6837         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6838         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6839         (gdbscm_lookup_global_symbol): Update.
6840         * guile/scm-param.c (gdbscm_parameter_value): Update.
6841         * guile/scm-frame.c (gdbscm_frame_read_register)
6842         (gdbscm_frame_read_var): Update.
6843         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6844         * exec.c (try_open_exec_file): Update.
6845         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6846         (gdb_rl_callback_handler): Update.
6847         * common/common-exceptions.h (exception_none): Don't declare.
6848         * common/common-exceptions.c (exception_none): Don't define.
6849         (struct catcher) <exception>: Update.
6850         * cli/cli-interp.c (safe_execute_command): Update.
6851         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6852
6853 2019-04-25  Ali Tamur  <tamur@google.com>
6854
6855         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6856         (read_attribute_value): Likewise.
6857         (dwarf2_read_addr_index): Update comment.
6858         (read_str_index): Add DW_FORM_strx.
6859         (dwarf2_string_attr): Likewise.
6860         (dwarf2_const_value_attr): Likewise.
6861         (dump_die_shallow): Likewise.
6862         (dwarf2_fetch_constant_bytes): Likewise.
6863         (skip_form_bytes): Likewise.
6864         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6865
6866 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6867
6868         PR corefiles/11608
6869         PR corefiles/18187
6870         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6871         OFFSET.  Verify if current mapping contains an ELF header.
6872         (linux_find_memory_regions_full): Adjust call to
6873         dump_mapping_p.
6874
6875 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6876             Kang Li <kanglictf@gmail.com>
6877
6878         PR gdb/21600
6879
6880         * dwarf2-frame.c (read_initial_length): Be consistent about using
6881         unsigned representation of length.
6882         (decode_frame_entry_1): Likewise.  Check for wraparound of
6883         end pointer as well as buffer overflow.
6884
6885 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6886
6887         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6888         "vq".
6889
6890 2019-04-24  Tom Tromey  <tromey@adacore.com>
6891
6892         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6893
6894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * s12z-tdep.c (s12z_unwind_pc): Delete.
6897         (s12z_unwind_sp): Delete.
6898         (s12z_gdbarch_init): Don't register deleted functions with
6899         gdbarch.
6900
6901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6902
6903         * rl78-tdep.c (rl78_unwind_sp): Delete.
6904         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6905
6906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6909         (xstormy16_unwind_pc): Delete.
6910         (xstormy16_dummy_id): Delete.
6911         (xstormy16_gdbarch_init): Don't register deleted functions with
6912         gdbarch.
6913
6914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6915
6916         * vax-tdep.c (vax_unwind_pc): Delete.
6917         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6918
6919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6920
6921         * v850-tdep.c (v850_unwind_sp): Delete.
6922         (v850_unwind_pc): Delete.
6923         (v850_dummy_id): Delete.
6924         (v850_gdbarch_init): Don't register deleted functions with
6925         gdbarch.
6926
6927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6928
6929         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6930         (tilegx_unwind_pc): Delete.
6931         (tilegx_unwind_dummy_id): Delete.
6932         (tilegx_gdbarch_init): Don't register deleted functions with
6933         gdbarch.
6934
6935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6938         (tic6x_dummy_id): Delete.
6939         (tic6x_gdbarch_init): Don't register deleted functions with
6940         gdbarch.
6941
6942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * sparc-tdep.c (sparc_unwind_pc): Delete.
6945         (sparc32_gdbarch_init): Don't register deleted function with
6946         gdbarch.
6947
6948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * sh-tdep.c (sh_unwind_sp): Delete.
6951         (sh_unwind_pc): Delete.
6952         (sh_dummy_id): Delete.
6953         (sh_gdbarch_init): Don't register deleted functions with
6954         gdbarch.
6955
6956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6957
6958         * score-tdep.c (score_unwind_sp): Delete.
6959         (score_unwind_pc): Delete.
6960         (score_dummy_id): Delete.
6961         (score_gdbarch_init): Don't register deleted functions with
6962         gdbarch.
6963
6964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * rx-tdep.c (rx_unwind_pc): Delete.
6967         (rx_unwind_sp): Delete.
6968         (rx_dummy_id): Delete.
6969         (rx_gdbarch_init): Don't register deleted functions with
6970         gdbarch.  Update comment.
6971
6972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6975         (rs6000_dummy_id): Delete.
6976         (rs6000_gdbarch_init): Don't register deleted functions with
6977         gdbarch.
6978
6979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6980
6981         * or1k-tdep.c (or1k_dummy_id): Delete.
6982         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6983
6984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * nios2-tdep.c (nios2_dummy_id): Delete.
6987         (nios2_unwind_sp): Delete.
6988         (nios2_gdbarch_init): Don't register deleted functions with
6989         gdbarch.
6990
6991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6992
6993         * nds32-tdep.c (nds32_dummy_id): Delete.
6994         (nds32_unwind_pc): Delete.
6995         (nds32_unwind_sp): Delete.
6996         (nds32_gdbarch_init): Don't register deleted functions with
6997         gdbarch.
6998
6999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * msp430-tdep.c (msp430_unwind_pc): Delete.
7002         (msp430_unwind_sp): Delete.
7003         (msp430_dummy_id): Delete.
7004         (msp430_gdbarch_init): Don't register deleted functions with
7005         gdbarch.
7006
7007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * moxie-tdep.c (moxie_unwind_sp): Delete.
7010         (moxie_unwind_pc): Delete.
7011         (moxie_dummy_id): Delete.
7012         (moxie_gdbarch_init): Don't register deleted functions with
7013         gdbarch.
7014
7015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7018         (mn10300_unwind_pc): Delete.
7019         (mn10300_unwind_sp): Delete.
7020         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7021         mn10300_unwind_sp.
7022         (mn10300_frame_unwind_init): Don't register deleted functions with
7023         gdbarch.
7024
7025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * mep-tdep.c (mep_unwind_pc): Delete.
7028         (mep_unwind_sp): Delete.
7029         (mep_dummy_id): Delete.
7030         (mep_gdbarch_init): Don't register deleted functions with
7031         gdbarch.
7032
7033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7034
7035         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7036         (m68hc11_unwind_sp): Delete.
7037         (m68hc11_gdbarch_init): Don't register deleted functions with
7038         gdbarch.
7039
7040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7041
7042         * m32r-tdep.c (m32r_unwind_sp): Delete.
7043         (m32r_unwind_pc): Delete.
7044         (m32r_dummy_id): Delete.
7045         (m32r_gdbarch_init): Don't register deleted functions with
7046         gdbarch.
7047
7048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * m32c-tdep.c (m32c_unwind_pc): Delete.
7051         (m32c_unwind_sp): Delete.
7052         (m32c_dummy_id): Delete.
7053         (m32c_gdbarch_init): Don't register deleted functions with
7054         gdbarch.
7055
7056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7059         (lm32_unwind_pc): Delete.
7060         (lm32_dummy_id): Delete.
7061         (lm32_gdbarch_init): Don't register deleted functions with
7062         gdbarch.
7063
7064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7067         (iq2000_unwind_pc): Delete.
7068         (iq2000_dummy_id): Delete.
7069         (iq2000_gdbarch_init): Don't register deleted functions with
7070         gdbarch.
7071
7072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * nds32-tdep.c (nds32_type_align): Delete.
7075         (nds32_push_dummy_call): Use type_align instead.
7076
7077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * arm-tdep.c (arm_type_align): Only handle vector override case.
7080         (arm_push_dummy_call): Use type_align.
7081         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7082
7083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7084
7085         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7086         case.
7087         (pass_on_stack): Use type_align.
7088         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7089         function.
7090
7091 2019-04-23  Tom Tromey  <tromey@adacore.com>
7092
7093         * dwarf2read.c (line_header::file_name_at): Remove unused
7094         overload.
7095
7096 2019-04-23  Tom de Vries  <tdevries@suse.de>
7097
7098         PR gdb/24438
7099         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7100         invocation.
7101
7102
7103 2019-03-27  Ali Tamur  <tamur@google.com>
7104
7105         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7106         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7107         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7108         (dwarf_expr_context::get_addr_index): Likewise
7109         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7110         (symbol_needs_eval_context::get_addr_index): Likewise
7111         (disassemble_dwarf_expression): Add DW_OP_addrx
7112         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7113         (read_cutu_die_from_dwo): Update comment
7114         (skip_one_die): Add DW_FORM_addrx
7115         (read_attribute_value): Likewise
7116         (var_decode_location): Add DW_OP_addrx
7117         (dwarf2_const_value_attr): Add DW_FORM_addrx
7118         (dump_die_shallow): Likewise
7119         (dwarf2_fetch_constant_bytes): Likewise
7120         (decode_locdesc): Add DW_OP_addrx
7121         (skip_form_bytes): Add DW_FORM_addrx
7122
7123 2019-04-22  Ali Tamur  <tamur@google.com>
7124
7125         * MAINTAINERS (Write After Approval): Add self.
7126
7127 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7128
7129         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7130         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7131         (open_symbol_file_object): Likewise.
7132         (svr4_default_sos): Add info parameter.
7133         (svr4_read_so_list): Likewise.
7134         (svr4_current_sos_direct): Adjust functions calls to pass down
7135         info.
7136         (svr4_current_sos_1): Add info parameter.
7137         (svr4_current_sos): Call get_svr4_info, pass info down to
7138         svr4_current_sos_1.
7139         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7140         get_svr4_info.
7141         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7142         get_svr4_info.
7143         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7144         to get_svr4_info.
7145         (probes_table_remove_objfile_probes): Likewise.
7146         (register_solib_event_probe): Add info parameter.
7147         (solist_update_incremental): Pass info parameter down to
7148         svr4_read_so_list.
7149         (disable_probes_interface): Add info parameter.
7150         (svr4_handle_solib_event): Pass current_program_space to
7151         get_svr4_info.  Adjust disable_probes_interface cleanup.
7152         (svr4_create_probe_breakpoints): Add info parameter, pass it
7153         down to register_solib_event_probe.
7154         (svr4_create_solib_event_breakpoints): Add info parameter,
7155         pass it down to svr4_create_probe_breakpoints.
7156         (enable_break): Pass info down to
7157         svr4_create_solib_event_breakpoints.
7158         (svr4_solib_create_inferior_hook): Pass current_program_space to
7159         get_svr4_info.
7160         (svr4_clear_solib): Likewise.
7161
7162 2019-04-22  Pedro Alves  <palves@redhat.com>
7163
7164         * solib-svr4.c (svr4_free_objfile_observer): New.
7165         (probe_and_action::objfile): New field.
7166         (probes_table_htab_remove_objfile_probes)
7167         (probes_table_remove_objfile_probes): New functions.
7168         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7169         in the new probe_and_action.  Don't store the probe in 'lookup'.
7170         (svr4_create_probe_breakpoints): Pass objfile to
7171         register_solib_event_probe.
7172         (_initialize_svr4_solib): Register a free_objfile observer.
7173
7174 2019-04-19  Tom Tromey  <tom@tromey.com>
7175
7176         * common/queue.h: Remove.
7177
7178 2019-04-19  Tom Tromey  <tom@tromey.com>
7179
7180         * event-loop.c: Don't include "common/queue.h".
7181
7182 2019-04-19  Tom Tromey  <tom@tromey.com>
7183
7184         * remote.c (remote_target): Use delete.
7185         * remote-notif.h: Include <list>, not "common/queue.h".
7186         (notif_client_p): Remove typedef.
7187         (remote_notif_state): Add constructor, destructor, initializer.
7188         <notif_queue>: Now a std::list.
7189         (remote_notif_state_xfree): Don't declare.
7190         * remote-notif.c (remote_notif_process, handle_notification)
7191         (remote_notif_state_allocate): Update.
7192         (~remote_notif_state): Rename from remote_notif_state_xfree.
7193
7194 2019-04-19  Tom Tromey  <tom@tromey.com>
7195
7196         * symfile.c (reread_symbols): Update.
7197         * objfiles.c (objfile_register_static_link)
7198         (objfile_lookup_static_link): Update
7199         (~objfile) Don't delete static_links.
7200         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7201
7202 2019-04-19  Tom Tromey  <tom@tromey.com>
7203
7204         * type-stack.h (struct type_stack) <insert>: Constify string.
7205         * type-stack.c (type_stack::insert): Constify string.
7206         * gdbtypes.h (lookup_template_type): Update.
7207         (address_space_name_to_int): Update.
7208         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7209         const.
7210         (lookup_template_type): Make name const.
7211         * c-exp.y: Update rules.
7212         (lex_one_token, classify_name, classify_inner_name)
7213         (c_print_token): Update.
7214         * p-exp.y: Update rules.
7215         (yylex): Update.
7216         * f-exp.y: Update rules.
7217         (yylex): Update.
7218         * d-exp.y: Update rules.
7219         (lex_one_token, classify_name, classify_inner_name): Update.
7220         * parse.c (write_dollar_variable, copy_name): Return std::string.
7221         * parser-defs.h (copy_name): Change return type.
7222         * m2-exp.y: Update rules.
7223         (yylex): Update.
7224         * go-exp.y (lex_one_token): Update.
7225         Update rules.
7226         (classify_unsafe_function, classify_packaged_name)
7227         (classify_name, yylex): Update.
7228
7229 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7230
7231         * configure.ac: add --enable-source-highlight switch.
7232         * configure: Regenerate.
7233         * top.c (print_gdb_version): plumb --enable-source-highlight
7234         status to "show configuration".
7235
7236 2019-04-19  Tom Tromey  <tromey@adacore.com>
7237
7238         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7239         Check ADA_TYPE_P.
7240         (empty_record, ada_template_to_fixed_record_type_1)
7241         (template_to_static_fixed_type)
7242         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7243         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7244         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7245         macros.
7246
7247 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7248
7249         PR symtab/24423:
7250         * source.c (print_source_lines_base): Advance "iter" when a
7251         control character is seen.
7252
7253 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7254
7255         * inferior.h (struct infcall_suspend_state_deleter):
7256         Catch exception in destructor to avoid crash.
7257
7258 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7259
7260         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7261         close to the add_com "shell".
7262
7263 2019-04-18  Tom Tromey  <tromey@adacore.com>
7264
7265         * process-stratum-target.h (class process_stratum_target)
7266         <stratum>: Add "final".
7267
7268 2019-04-17  Tom Tromey  <tromey@adacore.com>
7269
7270         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7271         against nullptr before use.
7272
7273 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7274
7275         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7276
7277 2019-04-17  Jim Wilson  <jimw@sifive.com>
7278             Andrew Burgess  <andrew.burgess@embecosm.com>
7279
7280         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7281         code read might fail, assume 4-byte breakpoint in that case.
7282
7283 2019-04-15  Leszek Swirski  <leszeks@google.com>
7284
7285         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7286         rather than a hand-rolled POD check when checking for forced MEMORY
7287         classification.
7288
7289 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7290
7291         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7292         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7293         function.
7294         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7295         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7296         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7297         declaration.
7298
7299 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7300
7301         * aarch64-linux-nat.c
7302         (aarch64_linux_nat_target::thread_architecture): Add override.
7303         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7304         each VQ.
7305
7306 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7307
7308         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7309
7310 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7313         target types of size 96-bits, add some additional comments, and
7314         check that the builtin type we found was the correct size.
7315
7316 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7317
7318         * utils.c (prompt_for_continue): Don't restore the styling at the
7319         end, as applied_style has the wrong value.  This fixes styling in
7320         long lists of file names that are interrupted by the "Continue?"
7321         prompt.
7322
7323 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7326         * c-lang.c (c_language_defn): Likewise.
7327         (cplus_language_defn): Likewise.
7328         (asm_language_defn): Likewise.
7329         (minimal_language_defn): Likewise.
7330         * d-lang.c (d_language_defn): Likewise.
7331         * f-lang.c (f_language_defn): Likewise.
7332         * go-lang.c (go_language_defn): Likewise.
7333         * language.c (unknown_language_defn): Likewise.
7334         (auto_language_defn): Likewise.
7335         * language.h (struct language_defn): Remove la_magic field.
7336         (LANG_MAGIC): Delete.
7337         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7338         * objc-lang.c (objc_language_defn): Likewise.
7339         * opencl-lang.c (opencl_language_defn): Likewise.
7340         * p-lang.c (pascal_language_defn): Likewise.
7341         * rust-lang.c (rust_language_defn): Likewise.
7342
7343 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7344
7345         * riscv-tdep.c (riscv_type_align): New function.
7346         (riscv_type_alignment): Delete.
7347         (riscv_arg_location): Use 'type_align'.
7348         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7349
7350 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * gdbtypes.c (type_align): A struct with no non-static fields also
7353         has alignment of 1.
7354
7355 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7358         component to 0.
7359         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7360         member.
7361         (riscv_struct_info::analyse): New implementation using new
7362         analyse_inner member function.
7363         (riscv_struct_info::field_offset): New member function.
7364         (riscv_struct_info::m_offsets): New member variable.
7365         (riscv_struct_info::analyse_inner): New private member function,
7366         takes the old implementation of riscv_struct_info::analyse but
7367         extended to track field offsets.
7368         (riscv_call_arg_struct): Update the struct folding special cases
7369         to handle cases where empty C++ structs, which are non-zero
7370         length, are found.
7371         (riscv_arg_location): Initialise the length of each location, a
7372         non-zero length now indicates the location is in use.
7373         (riscv_push_dummy_call): Allow for the first location having a
7374         non-zero offset when setting up arguments.
7375         (riscv_return_value): Likewise, but for return values.
7376
7377 2019-04-11  Tom Tromey  <tromey@adacore.com>
7378
7379         * utils.c (internal_vproblem): Make "msg" const.
7380
7381 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7382
7383         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7384         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7385         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7386         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7387
7388 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7389
7390         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7391         function.
7392         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7393         of amd64_collect_native_gregset.
7394         (amd64_linux_nat_target::store_registers): Likewise.
7395
7396 2019-04-10  Tom Tromey  <tom@tromey.com>
7397
7398         * symtab.c (lookup_global_symbol_from_objfile)
7399         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7400         * objfiles.h (class separate_debug_iterator): New.
7401         (class separate_debug_range): New.
7402         (struct objfile) <separate_debug_objfiles>: New method.
7403         (objfile_separate_debug_iterate): Don't declare.
7404         * objfiles.c (separate_debug_iterator::operator++): Rename from
7405         objfile_separate_debug_iterate.
7406         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7407         iterator.
7408         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7409         iterator.
7410
7411 2019-04-10  Tom Tromey  <tom@tromey.com>
7412
7413         * symfile.c (reread_symbols): Remove old comment.
7414         * objfiles.c (free_all_objfiles): Fix a typo.
7415
7416 2019-04-10  Tom Tromey  <tom@tromey.com>
7417
7418         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7419         * minsyms.c (lookup_minimal_symbol): Use foreach.
7420         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7421         (lookup_minimal_symbol_solib_trampoline): Likewise.
7422         * symfile.c (reread_symbols): Use foreach.
7423
7424 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7425             Tom Tromey  <tromey@adacore.com>
7426
7427         PR rust/24414:
7428         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7429         (rust_lex_int_test): Change "value" to be LONGEST.
7430         (rust_lex_tests): Add test for long integer literal.
7431
7432 2019-04-09  Tom Tromey  <tromey@adacore.com>
7433
7434         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7435         to bool.
7436         (extended_remote_target::attach): Update.
7437         (remote_target::remote_notice_new_inferior): Update.
7438         (remote_target::add_current_inferior_and_thread): Update.
7439         * inferior.c (exit_inferior_1): Use "false".
7440         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7441
7442 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7443
7444         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7445         the "start" command.
7446
7447 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7448
7449         * python/py-inferior.c (infpy_thread_from_thread_handle):
7450         Adjust comments to reflect renaming of thread_from_thread_handle
7451         to thread_from_handle.  Adjust keywords.  Fix type error message.
7452         (inferior_object_methods): Add thread_from_handle.  Retain
7453         thread_from_thread_handle, but mark it as deprecated.
7454
7455 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7456
7457         * gdbthread.h (find_thread_by_handle): Revise declaration.
7458         * thread.c (find_thread_by_handle): Likewise.  Adjust
7459         implementation too.
7460         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7461         support for buffer objects as handles.
7462
7463 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7464
7465         * python/py-infthread.c (thpy_thread_handle): New function.
7466         (thread_object_methods): Register thpy_thread_handle.
7467
7468 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7469
7470         * gdbthread.h (thread_to_thread_handle): Declare.
7471         * thread.c (gdbtypes.h): Include.
7472         (thread_to_thread_handle): New function.
7473
7474         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7475         (target_thread_info_to_thread_handle): Declare.
7476         * target.c (target_thread_info_to_thread_handle): New function.
7477         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7478         * target-delegates.c: Regenerate.
7479
7480         * linux-thread-db.c (class thread_db_target): Add method
7481         thread_info_to_thread_handle.
7482         (thread_db_target::thread_info_to_thread_handle): Define.
7483         * remote.c (class remote_target): Add new method
7484         thread_info_to_thread_handle.
7485         (remote_target::thread_info_to_thread_handle): Define.
7486
7487 2019-04-08  Pedro Alves  <palves@redhat.com>
7488
7489         * common/common-exceptions.c (throw_exception): Don't create
7490         named object to throw; throw directly.
7491         (throw_it): Likewise.  Don't initialize gdb_exception::message
7492         here, with new; pass FMT and AP to the ctor instead.
7493         * common/common-exceptions.h: Include <string>.
7494         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7495         const char *, va_list)): New ctor.  Use std::make_shared.
7496         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7497         errors)): Delete.
7498         (gdb_exception_error::gdb_exception_error(enum errors, const char
7499         *, va_list)): New.
7500         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7501         Add assertion.
7502         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7503         errors)): Delete.
7504         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7505         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7506         Add assertion.
7507
7508 2019-04-08  Tom Tromey  <tom@tromey.com>
7509
7510         * valops.c (value_rtti_indirect_type): Replace throw_exception
7511         with throw.
7512         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7513         with throw.
7514         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7515         throw.
7516         * target.c (target_translate_tls_address): Replace throw_exception
7517         with throw.
7518         * stack.c (frame_apply_command_count): Replace throw_exception
7519         with throw.
7520         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7521         throw.
7522         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7523         with throw.
7524         * rs6000-tdep.c (rs6000_frame_cache)
7525         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7526         * remote.c: Replace throw_exception with throw.
7527         * record-full.c (record_full_message, record_full_wait_1)
7528         (record_full_restore): Replace throw_exception with throw.
7529         * record-btrace.c:
7530         (get_thread_current_frame_id, record_btrace_start_replaying)
7531         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7532         (cmd_record_btrace_start): Replace throw_exception with throw.
7533         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7534         throw.
7535         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7536         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7537         * linespec.c:
7538         (find_linespec_symbols): Replace throw_exception with throw.
7539         * infrun.c (displaced_step_prepare, resume): Replace
7540         throw_exception with throw.
7541         * infcmd.c (post_create_inferior): Replace throw_exception with
7542         throw.
7543         * inf-loop.c (inferior_event_handler): Replace throw_exception
7544         with throw.
7545         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7546         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7547         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7548         (get_prev_frame_always, get_frame_pc_if_available)
7549         (get_frame_address_in_block_if_available, get_frame_language):
7550         Replace throw_exception with throw.
7551         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7552         throw_exception with throw.
7553         * eval.c (fetch_subexp_value, evaluate_var_value)
7554         (evaluate_funcall, evaluate_subexp_standard): Replace
7555         throw_exception with throw.
7556         * dwarf2loc.c (call_site_find_chain)
7557         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7558         Replace throw_exception with throw.
7559         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7560         with throw.
7561         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7562         throw.
7563         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7564         * completer.c (complete_line_internal): Replace throw_exception
7565         with throw.
7566         * compile/compile-object-run.c (compile_object_run): Replace
7567         throw_exception with throw.
7568         * cli/cli-script.c (process_next_line): Replace throw_exception
7569         with throw.
7570         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7571         (btrace_enable, btrace_maint_update_pt_packets): Replace
7572         throw_exception with throw.
7573         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7574         throw_exception with throw.
7575         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7576         throw_exception with throw.
7577         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7578         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7579         * aarch64-tdep.c (aarch64_make_prologue_cache)
7580         (aarch64_make_stub_cache): Replace throw_exception with throw.
7581
7582 2019-04-08  Tom Tromey  <tom@tromey.com>
7583
7584         * common/common-exceptions.c (throw_exception): Rename from
7585         throw_exception_cxx.  Remove old copy.  Make argument const.
7586         (throw_it): Create and throw exception objects directly.
7587         * common/common-exceptions.h (throw_exception): Make argument
7588         const.
7589         (struct gdb_exception_error): Add constructor.
7590         (struct gdb_exception_quit): Add constructor.
7591
7592 2019-04-08  Tom Tromey  <tom@tromey.com>
7593
7594         * common/common-exceptions.h (exception_rethrow): Don't declare.
7595         (TRY_SJLJ): Update comment.
7596         (TRY, CATCH, END_CATCH): Remove.
7597         * common/common-exceptions.c (exception_rethrow): Remove.
7598
7599 2019-04-08  Tom Tromey  <tom@tromey.com>
7600
7601         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7602         Remove.
7603         (gdb_exception_error): Rename from
7604         gdb_exception_RETURN_MASK_ERROR.
7605         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7606         (gdb_quit_bad_alloc): Update.
7607         * aarch64-tdep.c: Update.
7608         * ada-lang.c: Update.
7609         * ada-typeprint.c: Update.
7610         * ada-valprint.c: Update.
7611         * amd64-tdep.c: Update.
7612         * arch-utils.c: Update.
7613         * break-catch-throw.c: Update.
7614         * breakpoint.c: Update.
7615         * btrace.c: Update.
7616         * c-varobj.c: Update.
7617         * cli/cli-cmds.c: Update.
7618         * cli/cli-interp.c: Update.
7619         * cli/cli-script.c: Update.
7620         * common/common-exceptions.c: Update.
7621         * common/new-op.c: Update.
7622         * common/selftest.c: Update.
7623         * compile/compile-c-symbols.c: Update.
7624         * compile/compile-cplus-symbols.c: Update.
7625         * compile/compile-object-load.c: Update.
7626         * compile/compile-object-run.c: Update.
7627         * completer.c: Update.
7628         * corelow.c: Update.
7629         * cp-abi.c: Update.
7630         * cp-support.c: Update.
7631         * cp-valprint.c: Update.
7632         * darwin-nat.c: Update.
7633         * disasm-selftests.c: Update.
7634         * dtrace-probe.c: Update.
7635         * dwarf-index-cache.c: Update.
7636         * dwarf-index-write.c: Update.
7637         * dwarf2-frame-tailcall.c: Update.
7638         * dwarf2-frame.c: Update.
7639         * dwarf2loc.c: Update.
7640         * dwarf2read.c: Update.
7641         * eval.c: Update.
7642         * event-loop.c: Update.
7643         * event-top.c: Update.
7644         * exec.c: Update.
7645         * f-valprint.c: Update.
7646         * fbsd-tdep.c: Update.
7647         * frame-unwind.c: Update.
7648         * frame.c: Update.
7649         * gdbtypes.c: Update.
7650         * gnu-v3-abi.c: Update.
7651         * guile/guile-internal.h: Update.
7652         * guile/scm-block.c: Update.
7653         * guile/scm-breakpoint.c: Update.
7654         * guile/scm-cmd.c: Update.
7655         * guile/scm-disasm.c: Update.
7656         * guile/scm-frame.c: Update.
7657         * guile/scm-lazy-string.c: Update.
7658         * guile/scm-math.c: Update.
7659         * guile/scm-param.c: Update.
7660         * guile/scm-ports.c: Update.
7661         * guile/scm-pretty-print.c: Update.
7662         * guile/scm-symbol.c: Update.
7663         * guile/scm-symtab.c: Update.
7664         * guile/scm-type.c: Update.
7665         * guile/scm-value.c: Update.
7666         * i386-linux-tdep.c: Update.
7667         * i386-tdep.c: Update.
7668         * inf-loop.c: Update.
7669         * infcall.c: Update.
7670         * infcmd.c: Update.
7671         * infrun.c: Update.
7672         * jit.c: Update.
7673         * language.c: Update.
7674         * linespec.c: Update.
7675         * linux-fork.c: Update.
7676         * linux-nat.c: Update.
7677         * linux-tdep.c: Update.
7678         * linux-thread-db.c: Update.
7679         * main.c: Update.
7680         * mi/mi-cmd-break.c: Update.
7681         * mi/mi-cmd-stack.c: Update.
7682         * mi/mi-interp.c: Update.
7683         * mi/mi-main.c: Update.
7684         * objc-lang.c: Update.
7685         * p-valprint.c: Update.
7686         * parse.c: Update.
7687         * ppc-linux-tdep.c: Update.
7688         * printcmd.c: Update.
7689         * python/py-arch.c: Update.
7690         * python/py-breakpoint.c: Update.
7691         * python/py-cmd.c: Update.
7692         * python/py-finishbreakpoint.c: Update.
7693         * python/py-frame.c: Update.
7694         * python/py-framefilter.c: Update.
7695         * python/py-gdb-readline.c: Update.
7696         * python/py-inferior.c: Update.
7697         * python/py-infthread.c: Update.
7698         * python/py-lazy-string.c: Update.
7699         * python/py-linetable.c: Update.
7700         * python/py-objfile.c: Update.
7701         * python/py-param.c: Update.
7702         * python/py-prettyprint.c: Update.
7703         * python/py-progspace.c: Update.
7704         * python/py-record-btrace.c: Update.
7705         * python/py-record.c: Update.
7706         * python/py-symbol.c: Update.
7707         * python/py-type.c: Update.
7708         * python/py-unwind.c: Update.
7709         * python/py-utils.c: Update.
7710         * python/py-value.c: Update.
7711         * python/python.c: Update.
7712         * record-btrace.c: Update.
7713         * record-full.c: Update.
7714         * remote-fileio.c: Update.
7715         * remote.c: Update.
7716         * riscv-tdep.c: Update.
7717         * rs6000-aix-tdep.c: Update.
7718         * rs6000-tdep.c: Update.
7719         * rust-exp.y: Update.
7720         * rust-lang.c: Update.
7721         * s390-tdep.c: Update.
7722         * selftest-arch.c: Update.
7723         * solib-dsbt.c: Update.
7724         * solib-frv.c: Update.
7725         * solib-spu.c: Update.
7726         * solib-svr4.c: Update.
7727         * solib.c: Update.
7728         * sparc64-linux-tdep.c: Update.
7729         * stack.c: Update.
7730         * symfile-mem.c: Update.
7731         * symmisc.c: Update.
7732         * target.c: Update.
7733         * thread.c: Update.
7734         * top.c: Update.
7735         * tracefile-tfile.c: Update.
7736         * tui/tui.c: Update.
7737         * typeprint.c: Update.
7738         * unittests/cli-utils-selftests.c: Update.
7739         * unittests/parse-connection-spec-selftests.c: Update.
7740         * valops.c: Update.
7741         * valprint.c: Update.
7742         * value.c: Update.
7743         * varobj.c: Update.
7744         * windows-nat.c: Update.
7745         * x86-linux-nat.c: Update.
7746         * xml-support.c: Update.
7747
7748 2019-04-08  Tom Tromey  <tom@tromey.com>
7749
7750         * xml-support.c: Use C++ exception handling.
7751         * x86-linux-nat.c: Use C++ exception handling.
7752         * windows-nat.c: Use C++ exception handling.
7753         * varobj.c: Use C++ exception handling.
7754         * value.c: Use C++ exception handling.
7755         * valprint.c: Use C++ exception handling.
7756         * valops.c: Use C++ exception handling.
7757         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7758         handling.
7759         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7760         * typeprint.c: Use C++ exception handling.
7761         * tui/tui.c: Use C++ exception handling.
7762         * tracefile-tfile.c: Use C++ exception handling.
7763         * top.c: Use C++ exception handling.
7764         * thread.c: Use C++ exception handling.
7765         * target.c: Use C++ exception handling.
7766         * symmisc.c: Use C++ exception handling.
7767         * symfile-mem.c: Use C++ exception handling.
7768         * stack.c: Use C++ exception handling.
7769         * sparc64-linux-tdep.c: Use C++ exception handling.
7770         * solib.c: Use C++ exception handling.
7771         * solib-svr4.c: Use C++ exception handling.
7772         * solib-spu.c: Use C++ exception handling.
7773         * solib-frv.c: Use C++ exception handling.
7774         * solib-dsbt.c: Use C++ exception handling.
7775         * selftest-arch.c: Use C++ exception handling.
7776         * s390-tdep.c: Use C++ exception handling.
7777         * rust-lang.c: Use C++ exception handling.
7778         * rust-exp.y: Use C++ exception handling.
7779         * rs6000-tdep.c: Use C++ exception handling.
7780         * rs6000-aix-tdep.c: Use C++ exception handling.
7781         * riscv-tdep.c: Use C++ exception handling.
7782         * remote.c: Use C++ exception handling.
7783         * remote-fileio.c: Use C++ exception handling.
7784         * record-full.c: Use C++ exception handling.
7785         * record-btrace.c: Use C++ exception handling.
7786         * python/python.c: Use C++ exception handling.
7787         * python/py-value.c: Use C++ exception handling.
7788         * python/py-utils.c: Use C++ exception handling.
7789         * python/py-unwind.c: Use C++ exception handling.
7790         * python/py-type.c: Use C++ exception handling.
7791         * python/py-symbol.c: Use C++ exception handling.
7792         * python/py-record.c: Use C++ exception handling.
7793         * python/py-record-btrace.c: Use C++ exception handling.
7794         * python/py-progspace.c: Use C++ exception handling.
7795         * python/py-prettyprint.c: Use C++ exception handling.
7796         * python/py-param.c: Use C++ exception handling.
7797         * python/py-objfile.c: Use C++ exception handling.
7798         * python/py-linetable.c: Use C++ exception handling.
7799         * python/py-lazy-string.c: Use C++ exception handling.
7800         * python/py-infthread.c: Use C++ exception handling.
7801         * python/py-inferior.c: Use C++ exception handling.
7802         * python/py-gdb-readline.c: Use C++ exception handling.
7803         * python/py-framefilter.c: Use C++ exception handling.
7804         * python/py-frame.c: Use C++ exception handling.
7805         * python/py-finishbreakpoint.c: Use C++ exception handling.
7806         * python/py-cmd.c: Use C++ exception handling.
7807         * python/py-breakpoint.c: Use C++ exception handling.
7808         * python/py-arch.c: Use C++ exception handling.
7809         * printcmd.c: Use C++ exception handling.
7810         * ppc-linux-tdep.c: Use C++ exception handling.
7811         * parse.c: Use C++ exception handling.
7812         * p-valprint.c: Use C++ exception handling.
7813         * objc-lang.c: Use C++ exception handling.
7814         * mi/mi-main.c: Use C++ exception handling.
7815         * mi/mi-interp.c: Use C++ exception handling.
7816         * mi/mi-cmd-stack.c: Use C++ exception handling.
7817         * mi/mi-cmd-break.c: Use C++ exception handling.
7818         * main.c: Use C++ exception handling.
7819         * linux-thread-db.c: Use C++ exception handling.
7820         * linux-tdep.c: Use C++ exception handling.
7821         * linux-nat.c: Use C++ exception handling.
7822         * linux-fork.c: Use C++ exception handling.
7823         * linespec.c: Use C++ exception handling.
7824         * language.c: Use C++ exception handling.
7825         * jit.c: Use C++ exception handling.
7826         * infrun.c: Use C++ exception handling.
7827         * infcmd.c: Use C++ exception handling.
7828         * infcall.c: Use C++ exception handling.
7829         * inf-loop.c: Use C++ exception handling.
7830         * i386-tdep.c: Use C++ exception handling.
7831         * i386-linux-tdep.c: Use C++ exception handling.
7832         * guile/scm-value.c: Use C++ exception handling.
7833         * guile/scm-type.c: Use C++ exception handling.
7834         * guile/scm-symtab.c: Use C++ exception handling.
7835         * guile/scm-symbol.c: Use C++ exception handling.
7836         * guile/scm-pretty-print.c: Use C++ exception handling.
7837         * guile/scm-ports.c: Use C++ exception handling.
7838         * guile/scm-param.c: Use C++ exception handling.
7839         * guile/scm-math.c: Use C++ exception handling.
7840         * guile/scm-lazy-string.c: Use C++ exception handling.
7841         * guile/scm-frame.c: Use C++ exception handling.
7842         * guile/scm-disasm.c: Use C++ exception handling.
7843         * guile/scm-cmd.c: Use C++ exception handling.
7844         * guile/scm-breakpoint.c: Use C++ exception handling.
7845         * guile/scm-block.c: Use C++ exception handling.
7846         * guile/guile-internal.h: Use C++ exception handling.
7847         * gnu-v3-abi.c: Use C++ exception handling.
7848         * gdbtypes.c: Use C++ exception handling.
7849         * frame.c: Use C++ exception handling.
7850         * frame-unwind.c: Use C++ exception handling.
7851         * fbsd-tdep.c: Use C++ exception handling.
7852         * f-valprint.c: Use C++ exception handling.
7853         * exec.c: Use C++ exception handling.
7854         * event-top.c: Use C++ exception handling.
7855         * event-loop.c: Use C++ exception handling.
7856         * eval.c: Use C++ exception handling.
7857         * dwarf2read.c: Use C++ exception handling.
7858         * dwarf2loc.c: Use C++ exception handling.
7859         * dwarf2-frame.c: Use C++ exception handling.
7860         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7861         * dwarf-index-write.c: Use C++ exception handling.
7862         * dwarf-index-cache.c: Use C++ exception handling.
7863         * dtrace-probe.c: Use C++ exception handling.
7864         * disasm-selftests.c: Use C++ exception handling.
7865         * darwin-nat.c: Use C++ exception handling.
7866         * cp-valprint.c: Use C++ exception handling.
7867         * cp-support.c: Use C++ exception handling.
7868         * cp-abi.c: Use C++ exception handling.
7869         * corelow.c: Use C++ exception handling.
7870         * completer.c: Use C++ exception handling.
7871         * compile/compile-object-run.c: Use C++ exception handling.
7872         * compile/compile-object-load.c: Use C++ exception handling.
7873         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7874         * compile/compile-c-symbols.c: Use C++ exception handling.
7875         * common/selftest.c: Use C++ exception handling.
7876         * common/new-op.c: Use C++ exception handling.
7877         * cli/cli-script.c: Use C++ exception handling.
7878         * cli/cli-interp.c: Use C++ exception handling.
7879         * cli/cli-cmds.c: Use C++ exception handling.
7880         * c-varobj.c: Use C++ exception handling.
7881         * btrace.c: Use C++ exception handling.
7882         * breakpoint.c: Use C++ exception handling.
7883         * break-catch-throw.c: Use C++ exception handling.
7884         * arch-utils.c: Use C++ exception handling.
7885         * amd64-tdep.c: Use C++ exception handling.
7886         * ada-valprint.c: Use C++ exception handling.
7887         * ada-typeprint.c: Use C++ exception handling.
7888         * ada-lang.c: Use C++ exception handling.
7889         * aarch64-tdep.c: Use C++ exception handling.
7890
7891 2019-04-08  Tom Tromey  <tom@tromey.com>
7892
7893         * xml-support.c (gdb_xml_parser::parse): Update.
7894         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7895         * value.c (show_convenience): Update.
7896         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7897         (test_parse_flags_qcs): Update.
7898         * thread.c (thr_try_catch_cmd): Update.
7899         * target.c (target_translate_tls_address): Update.
7900         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7901         (info_frame_command_core, frame_apply_command_count): Update.
7902         * rust-exp.y (rust_lex_exception_test): Update.
7903         * riscv-tdep.c (riscv_print_one_register_info): Update.
7904         * remote.c (remote_target::enable_btrace): Update.
7905         * record-btrace.c (record_btrace_enable_warn): Update.
7906         * python/py-utils.c (gdbpy_convert_exception): Update.
7907         * printcmd.c (do_one_display, print_variable_and_value): Update.
7908         * mi/mi-main.c (mi_print_exception): Update.
7909         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7910         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7911         * linux-nat.c (linux_nat_target::attach): Update.
7912         * linux-fork.c (class scoped_switch_fork_info): Update.
7913         * infrun.c (displaced_step_prepare): Update.
7914         * infcall.c (call_function_by_hand_dummy): Update.
7915         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7916         * gnu-v3-abi.c (print_one_vtable): Update.
7917         * frame.c (get_prev_frame_always): Update.
7918         * f-valprint.c (info_common_command_for_block): Update.
7919         * exec.c (try_open_exec_file): Update.
7920         * exceptions.c (print_exception, exception_print)
7921         (exception_fprintf, exception_print_same): Update.
7922         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7923         * dwarf-index-cache.c (index_cache::store)
7924         (index_cache::lookup_gdb_index): Update.
7925         * darwin-nat.c (maybe_cache_shell): Update.
7926         * cp-valprint.c (cp_print_value_fields): Update.
7927         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7928         (gcc_cplus_symbol_address): Update.
7929         * compile/compile-c-symbols.c (gcc_convert_symbol)
7930         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7931         * common/selftest.c: Update.
7932         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7933         a std::string.
7934         (exception_try_scope_entry, exception_try_scope_exit): Don't
7935         declare.
7936         (struct exception_try_scope): Remove.
7937         (TRY): Don't use exception_try_scope.
7938         (struct gdb_exception): Add constructor, operator=.
7939         <what>: New method.
7940         (struct gdb_exception_RETURN_MASK_ALL)
7941         (struct gdb_exception_RETURN_MASK_ERROR)
7942         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7943         (struct gdb_quit_bad_alloc): Update.
7944         * common/common-exceptions.c (exception_none): Change
7945         initializer.
7946         (struct catcher) <state, exception>: Initialize inline.
7947         <prev>: Remove member.
7948         (current_catcher): Remove.
7949         (catchers): New global.
7950         (exceptions_state_mc_init): Simplify.
7951         (catcher_pop): Remove.
7952         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7953         (try_scope_depth, exception_try_scope_entry)
7954         (exception_try_scope_exit): Remove.
7955         (throw_exception_sjlj): Update.
7956         (exception_messages, exception_messages_size): Remove.
7957         (throw_it): Simplify.
7958         (gdb_exception_sliced_copy): Remove.
7959         (throw_exception_cxx): Update.
7960         * cli/cli-script.c (script_from_file): Update.
7961         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7962         Update.
7963         * ada-valprint.c (ada_val_print): Update.
7964         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7965         (create_excep_cond_exprs): Update.
7966
7967 2019-04-08  Tom Tromey  <tom@tromey.com>
7968
7969         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7970         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7971         (TRY, CATCH, END_CATCH): Remove some definitions.
7972         * common/common-exceptions.c: Don't use GDB_XCPT.
7973         (catcher_list_size): Remove.
7974         (throw_exception, throw_it): Simplify.
7975
7976 2019-04-05  Tom Tromey  <tom@tromey.com>
7977
7978         Revert the header-sorting patch.
7979         * ft32-tdep.c: Revert.
7980         * frv-tdep.c: Revert.
7981         * frv-linux-tdep.c: Revert.
7982         * frame.c: Revert.
7983         * frame-unwind.c: Revert.
7984         * frame-base.c: Revert.
7985         * fork-child.c: Revert.
7986         * findvar.c: Revert.
7987         * findcmd.c: Revert.
7988         * filesystem.c: Revert.
7989         * filename-seen-cache.h: Revert.
7990         * filename-seen-cache.c: Revert.
7991         * fbsd-tdep.c: Revert.
7992         * fbsd-nat.h: Revert.
7993         * fbsd-nat.c: Revert.
7994         * f-valprint.c: Revert.
7995         * f-typeprint.c: Revert.
7996         * f-lang.c: Revert.
7997         * extension.h: Revert.
7998         * extension.c: Revert.
7999         * extension-priv.h: Revert.
8000         * expprint.c: Revert.
8001         * exec.h: Revert.
8002         * exec.c: Revert.
8003         * exceptions.c: Revert.
8004         * event-top.c: Revert.
8005         * event-loop.c: Revert.
8006         * eval.c: Revert.
8007         * elfread.c: Revert.
8008         * dwarf2read.h: Revert.
8009         * dwarf2read.c: Revert.
8010         * dwarf2loc.c: Revert.
8011         * dwarf2expr.h: Revert.
8012         * dwarf2expr.c: Revert.
8013         * dwarf2-frame.c: Revert.
8014         * dwarf2-frame-tailcall.c: Revert.
8015         * dwarf-index-write.h: Revert.
8016         * dwarf-index-write.c: Revert.
8017         * dwarf-index-common.c: Revert.
8018         * dwarf-index-cache.h: Revert.
8019         * dwarf-index-cache.c: Revert.
8020         * dummy-frame.c: Revert.
8021         * dtrace-probe.c: Revert.
8022         * disasm.h: Revert.
8023         * disasm.c: Revert.
8024         * disasm-selftests.c: Revert.
8025         * dictionary.c: Revert.
8026         * dicos-tdep.c: Revert.
8027         * demangle.c: Revert.
8028         * dcache.h: Revert.
8029         * dcache.c: Revert.
8030         * darwin-nat.h: Revert.
8031         * darwin-nat.c: Revert.
8032         * darwin-nat-info.c: Revert.
8033         * d-valprint.c: Revert.
8034         * d-namespace.c: Revert.
8035         * d-lang.c: Revert.
8036         * ctf.c: Revert.
8037         * csky-tdep.c: Revert.
8038         * csky-linux-tdep.c: Revert.
8039         * cris-tdep.c: Revert.
8040         * cris-linux-tdep.c: Revert.
8041         * cp-valprint.c: Revert.
8042         * cp-support.c: Revert.
8043         * cp-namespace.c: Revert.
8044         * cp-abi.c: Revert.
8045         * corelow.c: Revert.
8046         * corefile.c: Revert.
8047         * continuations.c: Revert.
8048         * completer.h: Revert.
8049         * completer.c: Revert.
8050         * complaints.c: Revert.
8051         * coffread.c: Revert.
8052         * coff-pe-read.c: Revert.
8053         * cli-out.h: Revert.
8054         * cli-out.c: Revert.
8055         * charset.c: Revert.
8056         * c-varobj.c: Revert.
8057         * c-valprint.c: Revert.
8058         * c-typeprint.c: Revert.
8059         * c-lang.c: Revert.
8060         * buildsym.c: Revert.
8061         * buildsym-legacy.c: Revert.
8062         * build-id.h: Revert.
8063         * build-id.c: Revert.
8064         * btrace.c: Revert.
8065         * bsd-uthread.c: Revert.
8066         * breakpoint.h: Revert.
8067         * breakpoint.c: Revert.
8068         * break-catch-throw.c: Revert.
8069         * break-catch-syscall.c: Revert.
8070         * break-catch-sig.c: Revert.
8071         * blockframe.c: Revert.
8072         * block.c: Revert.
8073         * bfin-tdep.c: Revert.
8074         * bfin-linux-tdep.c: Revert.
8075         * bfd-target.c: Revert.
8076         * bcache.c: Revert.
8077         * ax-general.c: Revert.
8078         * ax-gdb.h: Revert.
8079         * ax-gdb.c: Revert.
8080         * avr-tdep.c: Revert.
8081         * auxv.c: Revert.
8082         * auto-load.c: Revert.
8083         * arm-wince-tdep.c: Revert.
8084         * arm-tdep.c: Revert.
8085         * arm-symbian-tdep.c: Revert.
8086         * arm-pikeos-tdep.c: Revert.
8087         * arm-obsd-tdep.c: Revert.
8088         * arm-nbsd-tdep.c: Revert.
8089         * arm-nbsd-nat.c: Revert.
8090         * arm-linux-tdep.c: Revert.
8091         * arm-linux-nat.c: Revert.
8092         * arm-fbsd-tdep.c: Revert.
8093         * arm-fbsd-nat.c: Revert.
8094         * arm-bsd-tdep.c: Revert.
8095         * arch-utils.c: Revert.
8096         * arc-tdep.c: Revert.
8097         * arc-newlib-tdep.c: Revert.
8098         * annotate.h: Revert.
8099         * annotate.c: Revert.
8100         * amd64-windows-tdep.c: Revert.
8101         * amd64-windows-nat.c: Revert.
8102         * amd64-tdep.c: Revert.
8103         * amd64-sol2-tdep.c: Revert.
8104         * amd64-obsd-tdep.c: Revert.
8105         * amd64-obsd-nat.c: Revert.
8106         * amd64-nbsd-tdep.c: Revert.
8107         * amd64-nbsd-nat.c: Revert.
8108         * amd64-nat.c: Revert.
8109         * amd64-linux-tdep.c: Revert.
8110         * amd64-linux-nat.c: Revert.
8111         * amd64-fbsd-tdep.c: Revert.
8112         * amd64-fbsd-nat.c: Revert.
8113         * amd64-dicos-tdep.c: Revert.
8114         * amd64-darwin-tdep.c: Revert.
8115         * amd64-bsd-nat.c: Revert.
8116         * alpha-tdep.c: Revert.
8117         * alpha-obsd-tdep.c: Revert.
8118         * alpha-nbsd-tdep.c: Revert.
8119         * alpha-mdebug-tdep.c: Revert.
8120         * alpha-linux-tdep.c: Revert.
8121         * alpha-linux-nat.c: Revert.
8122         * alpha-bsd-tdep.c: Revert.
8123         * alpha-bsd-nat.c: Revert.
8124         * aix-thread.c: Revert.
8125         * agent.c: Revert.
8126         * addrmap.c: Revert.
8127         * ada-varobj.c: Revert.
8128         * ada-valprint.c: Revert.
8129         * ada-typeprint.c: Revert.
8130         * ada-tasks.c: Revert.
8131         * ada-lang.c: Revert.
8132         * aarch64-tdep.c: Revert.
8133         * aarch64-ravenscar-thread.c: Revert.
8134         * aarch64-newlib-tdep.c: Revert.
8135         * aarch64-linux-tdep.c: Revert.
8136         * aarch64-linux-nat.c: Revert.
8137         * aarch64-fbsd-tdep.c: Revert.
8138         * aarch64-fbsd-nat.c: Revert.
8139         * aarch32-linux-nat.c: Revert.
8140
8141 2019-04-05  Tom Tromey  <tom@tromey.com>
8142
8143         * ft32-tdep.c: Sort headers.
8144         * frv-tdep.c: Sort headers.
8145         * frv-linux-tdep.c: Sort headers.
8146         * frame.c: Sort headers.
8147         * frame-unwind.c: Sort headers.
8148         * frame-base.c: Sort headers.
8149         * fork-child.c: Sort headers.
8150         * findvar.c: Sort headers.
8151         * findcmd.c: Sort headers.
8152         * filesystem.c: Sort headers.
8153         * filename-seen-cache.h: Sort headers.
8154         * filename-seen-cache.c: Sort headers.
8155         * fbsd-tdep.c: Sort headers.
8156         * fbsd-nat.h: Sort headers.
8157         * fbsd-nat.c: Sort headers.
8158         * f-valprint.c: Sort headers.
8159         * f-typeprint.c: Sort headers.
8160         * f-lang.c: Sort headers.
8161         * extension.h: Sort headers.
8162         * extension.c: Sort headers.
8163         * extension-priv.h: Sort headers.
8164         * expprint.c: Sort headers.
8165         * exec.h: Sort headers.
8166         * exec.c: Sort headers.
8167         * exceptions.c: Sort headers.
8168         * event-top.c: Sort headers.
8169         * event-loop.c: Sort headers.
8170         * eval.c: Sort headers.
8171         * elfread.c: Sort headers.
8172         * dwarf2read.h: Sort headers.
8173         * dwarf2read.c: Sort headers.
8174         * dwarf2loc.c: Sort headers.
8175         * dwarf2expr.h: Sort headers.
8176         * dwarf2expr.c: Sort headers.
8177         * dwarf2-frame.c: Sort headers.
8178         * dwarf2-frame-tailcall.c: Sort headers.
8179         * dwarf-index-write.h: Sort headers.
8180         * dwarf-index-write.c: Sort headers.
8181         * dwarf-index-common.c: Sort headers.
8182         * dwarf-index-cache.h: Sort headers.
8183         * dwarf-index-cache.c: Sort headers.
8184         * dummy-frame.c: Sort headers.
8185         * dtrace-probe.c: Sort headers.
8186         * disasm.h: Sort headers.
8187         * disasm.c: Sort headers.
8188         * disasm-selftests.c: Sort headers.
8189         * dictionary.c: Sort headers.
8190         * dicos-tdep.c: Sort headers.
8191         * demangle.c: Sort headers.
8192         * dcache.h: Sort headers.
8193         * dcache.c: Sort headers.
8194         * darwin-nat.h: Sort headers.
8195         * darwin-nat.c: Sort headers.
8196         * darwin-nat-info.c: Sort headers.
8197         * d-valprint.c: Sort headers.
8198         * d-namespace.c: Sort headers.
8199         * d-lang.c: Sort headers.
8200         * ctf.c: Sort headers.
8201         * csky-tdep.c: Sort headers.
8202         * csky-linux-tdep.c: Sort headers.
8203         * cris-tdep.c: Sort headers.
8204         * cris-linux-tdep.c: Sort headers.
8205         * cp-valprint.c: Sort headers.
8206         * cp-support.c: Sort headers.
8207         * cp-namespace.c: Sort headers.
8208         * cp-abi.c: Sort headers.
8209         * corelow.c: Sort headers.
8210         * corefile.c: Sort headers.
8211         * continuations.c: Sort headers.
8212         * completer.h: Sort headers.
8213         * completer.c: Sort headers.
8214         * complaints.c: Sort headers.
8215         * coffread.c: Sort headers.
8216         * coff-pe-read.c: Sort headers.
8217         * cli-out.h: Sort headers.
8218         * cli-out.c: Sort headers.
8219         * charset.c: Sort headers.
8220         * c-varobj.c: Sort headers.
8221         * c-valprint.c: Sort headers.
8222         * c-typeprint.c: Sort headers.
8223         * c-lang.c: Sort headers.
8224         * buildsym.c: Sort headers.
8225         * buildsym-legacy.c: Sort headers.
8226         * build-id.h: Sort headers.
8227         * build-id.c: Sort headers.
8228         * btrace.c: Sort headers.
8229         * bsd-uthread.c: Sort headers.
8230         * breakpoint.h: Sort headers.
8231         * breakpoint.c: Sort headers.
8232         * break-catch-throw.c: Sort headers.
8233         * break-catch-syscall.c: Sort headers.
8234         * break-catch-sig.c: Sort headers.
8235         * blockframe.c: Sort headers.
8236         * block.c: Sort headers.
8237         * bfin-tdep.c: Sort headers.
8238         * bfin-linux-tdep.c: Sort headers.
8239         * bfd-target.c: Sort headers.
8240         * bcache.c: Sort headers.
8241         * ax-general.c: Sort headers.
8242         * ax-gdb.h: Sort headers.
8243         * ax-gdb.c: Sort headers.
8244         * avr-tdep.c: Sort headers.
8245         * auxv.c: Sort headers.
8246         * auto-load.c: Sort headers.
8247         * arm-wince-tdep.c: Sort headers.
8248         * arm-tdep.c: Sort headers.
8249         * arm-symbian-tdep.c: Sort headers.
8250         * arm-pikeos-tdep.c: Sort headers.
8251         * arm-obsd-tdep.c: Sort headers.
8252         * arm-nbsd-tdep.c: Sort headers.
8253         * arm-nbsd-nat.c: Sort headers.
8254         * arm-linux-tdep.c: Sort headers.
8255         * arm-linux-nat.c: Sort headers.
8256         * arm-fbsd-tdep.c: Sort headers.
8257         * arm-fbsd-nat.c: Sort headers.
8258         * arm-bsd-tdep.c: Sort headers.
8259         * arch-utils.c: Sort headers.
8260         * arc-tdep.c: Sort headers.
8261         * arc-newlib-tdep.c: Sort headers.
8262         * annotate.h: Sort headers.
8263         * annotate.c: Sort headers.
8264         * amd64-windows-tdep.c: Sort headers.
8265         * amd64-windows-nat.c: Sort headers.
8266         * amd64-tdep.c: Sort headers.
8267         * amd64-sol2-tdep.c: Sort headers.
8268         * amd64-obsd-tdep.c: Sort headers.
8269         * amd64-obsd-nat.c: Sort headers.
8270         * amd64-nbsd-tdep.c: Sort headers.
8271         * amd64-nbsd-nat.c: Sort headers.
8272         * amd64-nat.c: Sort headers.
8273         * amd64-linux-tdep.c: Sort headers.
8274         * amd64-linux-nat.c: Sort headers.
8275         * amd64-fbsd-tdep.c: Sort headers.
8276         * amd64-fbsd-nat.c: Sort headers.
8277         * amd64-dicos-tdep.c: Sort headers.
8278         * amd64-darwin-tdep.c: Sort headers.
8279         * amd64-bsd-nat.c: Sort headers.
8280         * alpha-tdep.c: Sort headers.
8281         * alpha-obsd-tdep.c: Sort headers.
8282         * alpha-nbsd-tdep.c: Sort headers.
8283         * alpha-mdebug-tdep.c: Sort headers.
8284         * alpha-linux-tdep.c: Sort headers.
8285         * alpha-linux-nat.c: Sort headers.
8286         * alpha-bsd-tdep.c: Sort headers.
8287         * alpha-bsd-nat.c: Sort headers.
8288         * aix-thread.c: Sort headers.
8289         * agent.c: Sort headers.
8290         * addrmap.c: Sort headers.
8291         * ada-varobj.c: Sort headers.
8292         * ada-valprint.c: Sort headers.
8293         * ada-typeprint.c: Sort headers.
8294         * ada-tasks.c: Sort headers.
8295         * ada-lang.c: Sort headers.
8296         * aarch64-tdep.c: Sort headers.
8297         * aarch64-ravenscar-thread.c: Sort headers.
8298         * aarch64-newlib-tdep.c: Sort headers.
8299         * aarch64-linux-tdep.c: Sort headers.
8300         * aarch64-linux-nat.c: Sort headers.
8301         * aarch64-fbsd-tdep.c: Sort headers.
8302         * aarch64-fbsd-nat.c: Sort headers.
8303         * aarch32-linux-nat.c: Sort headers.
8304
8305 2019-04-04  Tom Tromey  <tom@tromey.com>
8306
8307         * varobj.c (varobj_create): Update.
8308         * rust-exp.y (struct rust_parser) <update_innermost_block,
8309         lookup_symbol>: New methods.
8310         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8311         Rename.
8312         (rust_parser::rust_lookup_type)
8313         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8314         * printcmd.c (display_command, do_one_display): Update.
8315         * parser-defs.h (struct parser_state) <parser_state>: Add
8316         "tracker" parameter.
8317         (block_tracker): New member.
8318         (class innermost_block_tracker) <innermost_block_tracker>: Add
8319         "types" parameter.
8320         <reset>: Remove method.
8321         (innermost_block): Don't declare.
8322         (null_post_parser): Update.
8323         * parse.c (innermost_block): Remove global.
8324         (write_dollar_variable): Update.
8325         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8326         Remove "tracker_types" parameter.
8327         (parse_expression): Add "tracker" parameter.
8328         (parse_expression_for_completion): Update.
8329         (null_post_parser): Add "tracker" parameter.
8330         * p-exp.y: Update rules.
8331         * m2-exp.y: Update rules.
8332         * language.h (struct language_defn) <la_post_parser>: Add
8333         "tracker" parameter.
8334         * go-exp.y: Update rules.
8335         * f-exp.y: Update rules.
8336         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8337         parameter.
8338         * d-exp.y: Update rules.
8339         * c-exp.y: Update rules.
8340         * breakpoint.c (set_breakpoint_condition): Create an
8341         innermost_block_tracker.
8342         (watch_command_1): Likewise.
8343         * ada-lang.c (resolve): Add "tracker" parameter.
8344         (resolve_subexp): Likewise.
8345         * ada-exp.y (write_var_from_sym): Update.
8346
8347 2019-04-04  Tom Tromey  <tom@tromey.com>
8348
8349         * type-stack.h: New file.
8350         * type-stack.c: New file.
8351         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8352         type-stack.h.
8353         (insert_into_type_stack, insert_type, push_type, push_type_int)
8354         (insert_type_address_space, pop_type, pop_type_int)
8355         (pop_typelist, pop_type_stack, append_type_stack)
8356         (push_type_stack, get_type_stack, push_typelist)
8357         (follow_type_instance_flags, follow_types): Don't declare.
8358         * parse.c (type_stack): Remove global.
8359         (parse_exp_in_context): Update.
8360         (insert_into_type_stack, insert_type, push_type, push_type_int)
8361         (insert_type_address_space, pop_type, pop_type_int)
8362         (pop_typelist, pop_type_stack, append_type_stack)
8363         (push_type_stack, get_type_stack, push_typelist)
8364         (follow_type_instance_flags, follow_types): Remove (moved to
8365         type-stack.c).
8366         * f-exp.y (type_stack): New global.
8367         Update rules.
8368         (push_kind_type, f_parse): Update.
8369         * d-exp.y (type_stack): New global.
8370         Update rules.
8371         (d_parse): Update.
8372         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8373         Update rules.
8374         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8375         (HFILES_NO_SRCDIR): Add type-stack.h.
8376
8377 2019-04-04  Tom Tromey  <tom@tromey.com>
8378
8379         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8380         (rust_parser::convert_ast_to_expression, rust_parse)
8381         (rust_lex_test_completion, rust_lex_tests): Update.
8382         * parser-defs.h (struct expr_completion_state): New.
8383         (struct parser_state) <parser_state>: Add completion parameter.
8384         <mark_struct_expression, mark_completion_tag>: New methods.
8385         <parse_completion, m_completion_state>: New members.
8386         (prefixify_expression, null_post_parser): Update.
8387         (mark_struct_expression, mark_completion_tag): Don't declare.
8388         * parse.c (parse_completion, expout_last_struct)
8389         (expout_tag_completion_type, expout_completion_name): Remove
8390         globals.
8391         (parser_state::mark_struct_expression)
8392         (parser_state::mark_completion_tag): Now methods.
8393         (prefixify_expression): Add last_struct parameter.
8394         (prefixify_subexp): Likewise.
8395         (parse_exp_1): Update.
8396         (parse_exp_in_context): Add cstate parameter.  Update.
8397         (parse_expression_for_completion): Create an
8398         expr_completion_state.
8399         (null_post_parser): Add "completion" parameter.
8400         * p-exp.y: Update rules.
8401         (yylex): Update.
8402         * language.h (struct language_defn) <la_post_parser>: Add
8403         "completing" parameter.
8404         * go-exp.y: Update rules.
8405         (lex_one_token): Update.
8406         * expression.h (parse_completion): Don't declare.
8407         * d-exp.y: Update rules.
8408         (lex_one_token): Update rules.
8409         * c-exp.y: Update rules.
8410         (lex_one_token): Update.
8411         * ada-lang.c (resolve): Add "parse_completion" parameter.
8412         (resolve_subexp): Likewise.
8413         (ada_resolve_function): Likewise.
8414
8415 2019-04-04  Tom Tromey  <tom@tromey.com>
8416
8417         * parser-defs.h (struct parser_state) <start_arglist,
8418         end_arglist>: New methods.
8419         <arglist_len, m_funcall_chain>: New members.
8420         (arglist_len, start_arglist, end_arglist): Don't declare.
8421         * parse.c (arglist_len, funcall_chain): Remove global.
8422         (start_arglist, end_arglist): Remove functions.
8423         (parse_exp_in_context): Update.
8424         * p-exp.y: Update rules.
8425         * m2-exp.y: Update rules.
8426         * go-exp.y: Update rules.
8427         * f-exp.y: Update rules.
8428         * d-exp.y: Update rules.
8429         * c-exp.y: Update rules.
8430
8431 2019-04-04  Tom Tromey  <tom@tromey.com>
8432
8433         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8434         lex_operator, push_back>: New methods.
8435         Update all rules.
8436         (rust_parser::lex_hex, lex_escape): Rename and update.
8437         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8438         (rust_parser::lex_operator): Rename and update.
8439         (rust_parser::lex_number, rustyylex, rustyyerror)
8440         (rust_lex_test_init, rust_lex_test_sequence)
8441         (rust_lex_test_push_back, rust_lex_tests): Update.
8442         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8443         parameter.
8444         <lexptr, prev_lexptr>: New members.
8445         (lexptr, prev_lexptr): Don't declare.
8446         * parse.c (lexptr, prev_lexptr): Remove globals.
8447         (parse_exp_in_context): Update.
8448         * p-exp.y (yylex, yyerror): Update.
8449         * m2-exp.y (parse_number, yylex, yyerror): Update.
8450         * go-exp.y (lex_one_token, yyerror): Update.
8451         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8452         * d-exp.y (lex_one_token, yyerror): Update.
8453         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8454         (lex_one_token, yyerror): Update.
8455         * ada-lex.l (YY_INPUT): Update.
8456         (rewind_to_char): Update.
8457         * ada-exp.y (yyerror): Update.
8458
8459 2019-04-04  Tom Tromey  <tom@tromey.com>
8460
8461         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8462         * parser-defs.h (struct parser_state) <parser_state>: Add new
8463         parameter.
8464         <comma_terminates>: New member.
8465         (comma_terminates): Don't declare global.
8466         * parse.c (comma_terminates): Remove global.
8467         (parse_exp_in_context): Update.
8468         * p-exp.y (yylex): Update.
8469         * m2-exp.y (yylex): Update.
8470         * go-exp.y (lex_one_token): Update.
8471         * f-exp.y (yylex): Update.
8472         * d-exp.y (lex_one_token): Update.
8473         * c-exp.y (lex_one_token): Update.
8474         * ada-lex.l: Update.
8475
8476 2019-04-04  Tom Tromey  <tom@tromey.com>
8477
8478         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8479         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8480         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8481         * parser-defs.h (paren_depth): Don't declare.
8482         * parse.c (paren_depth): Remove global.
8483         (parse_exp_in_context): Update.
8484         * p-exp.y (paren_depth): New global.
8485         (pascal_parse): Initialize it.
8486         * m2-exp.y (paren_depth): New global.
8487         (m2_parse): Initialize it.
8488         * go-exp.y (paren_depth): New global.
8489         (go_parse): Initialize it.
8490         * f-exp.y (paren_depth): New global.
8491         (f_parse): Initialize it.
8492         * d-exp.y (paren_depth): New global.
8493         (d_parse): Initialize it.
8494         * c-exp.y (paren_depth): New global.
8495         (c_parse): Initialize it.
8496         * ada-lex.l (paren_depth): New global.
8497         (lexer_init): Initialize it.
8498
8499 2019-04-04  Tom Tromey  <tom@tromey.com>
8500
8501         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8502         (rust_parser::convert_ast_to_type)
8503         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8504         * parser-defs.h (struct parser_state) <parser_state>: Add
8505         parameters.  Initialize new members.
8506         <expression_context_block, expression_context_pc>: New members.
8507         * parse.c (expression_context_block, expression_context_pc):
8508         Remove globals.
8509         (parse_exp_in_context): Update.
8510         * p-exp.y: Update all rules.
8511         (yylex): Update.
8512         * m2-exp.y: Update all rules.
8513         (yylex): Update.
8514         * go-exp.y (yylex): Update.
8515         * f-exp.y (yylex): Update.
8516         * d-exp.y: Update all rules.
8517         (yylex): Update.
8518         * c-exp.y: Update all rules.
8519         (lex_one_token, classify_name, yylex, c_parse): Update.
8520         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8521
8522 2019-04-04  Tom Tromey  <tom@tromey.com>
8523
8524         * gdbarch.h, gdbarch.c: Rebuild.
8525         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8526         * stap-probe.h:
8527         (struct stap_parse_info): Replace "parser_state" with
8528         "expr_builder".
8529         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8530         (parser_state): New class.
8531         * parse.c (expr_builder): Rename.
8532         (expr_builder::release): Rename.
8533         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8534         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8535         (write_exp_elt_longcst, write_exp_elt_floatcst)
8536         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8537         (write_exp_string_vector, write_exp_bitstring)
8538         (write_exp_msymbol, mark_struct_expression)
8539         (write_dollar_variable)
8540         (insert_type_address_space, increase_expout_size): Replace
8541         "parser_state" with "expr_builder".
8542         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8543         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8544         "parser_state" with "expr_builder".
8545
8546 2019-04-04  Tom Tromey  <tom@tromey.com>
8547
8548         * rust-exp.y: Replace "parse_language" with method call.
8549         * p-exp.y:
8550         (yylex): Replace "parse_language" with method call.
8551         * m2-exp.y:
8552         (yylex): Replace "parse_language" with method call.
8553         * go-exp.y (classify_name): Replace "parse_language" with method
8554         call.
8555         * f-exp.y (yylex): Replace "parse_language" with method call.
8556         * d-exp.y (lex_one_token): Replace "parse_language" with method
8557         call.
8558         * c-exp.y:
8559         (lex_one_token, classify_name, yylex): Replace "parse_language"
8560         with method call.
8561         * ada-exp.y (find_primitive_type, type_char)
8562         (type_system_address): Replace "parse_language" with method call.
8563
8564 2019-04-04  Tom Tromey  <tom@tromey.com>
8565
8566         * rust-exp.y: Replace "parse_gdbarch" with method call.
8567         * parse.c (write_dollar_variable, insert_type_address_space):
8568         Replace "parse_gdbarch" with method call.
8569         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8570         call.
8571         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8572         call.
8573         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8574         "parse_gdbarch" with method call.
8575         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8576         with method call.
8577         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8578         "parse_gdbarch" with method call.
8579         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8580         "parse_gdbarch" with method call.
8581         * c-exp.y (parse_type, parse_number, classify_name): Replace
8582         "parse_gdbarch" with method call.
8583         * ada-lex.l: Replace "parse_gdbarch" with method call.
8584         * ada-exp.y (parse_type, find_primitive_type, type_char)
8585         (type_system_address): Replace "parse_gdbarch" with method call.
8586
8587 2019-04-04  Tom Tromey  <tom@tromey.com>
8588
8589         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8590         * stap-probe.c (stap_parse_argument): Update.
8591         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8592         initial_size parameter.
8593         * rust-exp.y (rust_lex_tests): Update.
8594         * parse.c (parser_state): Update.
8595         (parse_exp_in_context): Update.
8596         * parser-defs.h (struct parser_state) <parser_state>: Remove
8597         "initial_size" parameter.
8598
8599 2019-04-04  Tom Tromey  <tom@tromey.com>
8600
8601         * parser-defs.h (increase_expout_size): Don't declare.
8602         * parse.c (increase_expout_size): Now static.
8603
8604 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8605
8606         * gnu-nat.c (gnu_nat_target::wait): Fix
8607         target_waitstatus_to_string call.
8608
8609 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * eval.c (evaluate_subexp_standard): Handle internal functions
8612         during Fortran function call handling.
8613
8614 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8615
8616         * NEWS: Mention new internal functions.
8617         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8618         (read_base_type): Use dwarf2_init_complex_target_type.
8619         * value.c (creal_internal_fn): New function.
8620         (cimag_internal_fn): New function.
8621         (_initialize_values): Register new internal functions.
8622
8623 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8624
8625         * infrun.c (stop_all_threads): If debug_infrun, always
8626         trace the wait status after wait_one, using
8627         target_waitstatus_to_string and target_pid_to_str.
8628         (handle_inferior_event): Replace various trace of
8629         wait status kind by a single trace.
8630         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8631         wait status kind image by target_waitstatus_to_string.
8632         * target/waitstatus.c (target_waitstatus_to_string): Fix
8633         obsolete comment.
8634
8635 2019-04-01  Tom Tromey  <tromey@adacore.com>
8636
8637         PR symtab/23331:
8638         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8639
8640 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8641             Pedro Alves  <palves@redhat.com>
8642
8643         * top.c (quit_force): Call 'finalize_values'.
8644         * value.c (finalize_values): New function.
8645         * value.h (finalize_values): Declare.
8646
8647 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8648
8649         * NEWS: Announce $_gdb_major and $_gdb_minor.
8650
8651         * top.c (init_gdb_version_vars): New function.
8652         (gdb_init): Call init_gdb_version_vars.
8653
8654 2019-03-29  Tom Tromey  <tromey@adacore.com>
8655
8656         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8657         help text.  Remove dead code.
8658
8659 2019-03-29  Keith Seitz  <keiths@redhat.com>
8660
8661         From Siddhesh Poyarekar:
8662         * f-lang.h (f77_get_upperbound): Return LONGEST.
8663         (f77_get_lowerbound): Likewise.
8664         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8665         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8666         print them.
8667         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8668         plongest to format print it.
8669         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8670         (f77_get_upperbound): Likewise.
8671         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8672         LOWER_BOUND to LONGEST.
8673         (f77_create_arrayprint_offset_tbl): Likewise.
8674
8675 2019-03-29  Keith Seitz  <keiths@redhat.com>
8676
8677         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8678         %s/pulongest for TYPE_LENGTH instead of %d in format
8679         strings.
8680         * ada-typerint.c (ada_print_type): Likewise.
8681         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8682         * compile/compile-c-support.c (generate_register_struct): Likewise.
8683         * gdbtypes.c (recursive_dump_type): Likewise.
8684         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8685         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8686         instead of %d in format strings.
8687         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8688         to std::min to ULONGEST.
8689         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8690         instead of %d in format strings.
8691         * tracepoint.c (info_scope_command): Likewise.
8692         * typeprint.c (print_offset_data::update)
8693         (print_offset_data::finish): Likewise.
8694         * xtensa-tdep.c (xtensa_store_return_value)
8695         (xtensa_push_dummy_call): Likewise.
8696
8697 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8698
8699         * windows-nat.c (display_selector): Fixed format specifications
8700         for 64-bit Cygwin.
8701
8702 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8705
8706 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8707
8708         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8709         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8710         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8711         (nios2_linux_init_abi): Install it.
8712
8713 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8714
8715         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8716
8717 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8718
8719         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8720
8721 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8722             Tom Tromey  <tromey@adacore.com>
8723
8724         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8725
8726 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8727
8728         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8729         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8730         method to compute the bounds of range types. Also print "[evaluated]"
8731         if the bounds' values come from a dynamic evaluation.
8732
8733 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8736         whitespace when pretty printing is on.
8737
8738 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8739
8740         * ppc-linux-nat.c: Add include.
8741
8742 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8743
8744         * NEWS: Mention AArch64 Pointer Authentication.
8745
8746 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8747
8748         * arm-linux-nat.c: Add include.
8749
8750 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8751
8752         * source-cache.c (source_cache::get_source_lines): Re-read
8753         fullname after calling open_source_file.
8754
8755 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8756
8757         * NEWS: Mention TLS support for FreeBSD.
8758
8759 2019-03-25  Tom Tromey  <tromey@adacore.com>
8760
8761         * minsyms.c (BUNCH_SIZE): Update comment.
8762         (~minimal_symbol_reader): Remove old comment.
8763         (compact_minimal_symbols): Update comment.
8764         (minimal_symbol_reader::install): Remove old comment.  Update
8765         other comments.
8766
8767 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8768
8769         * s390-linux-nat.c: Add include.
8770
8771 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8772
8773         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8774         Call linux_get_hwcap.
8775         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8776         Likewise.
8777         (aarch64_linux_get_hwcap): Remove function.
8778         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8779         declaration.
8780         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8781         linux_get_hwcap.
8782         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8783         * linux-tdep.c (linux_get_hwcap): Add function.
8784         (linux_get_hwcap2): Likewise.
8785         * linux-tdep.h (linux_get_hwcap): Add declaration.
8786         (linux_get_hwcap2): Likewise.
8787         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8788         (ppc_linux_get_hwcap2): Likewise.
8789         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8790         linux_get_hwcap.
8791         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8792         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8793         (ppc_linux_nat_target::read_description): Likewise.
8794         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8795         * s390-linux-nat.c: Likewise.
8796         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8797
8798 2019-03-24  Tom Tromey  <tom@tromey.com>
8799
8800         * ada-lang.c (standard_lookup): Simplify initialization.
8801         (ada_lookup_symbol_nonlocal): Simplify return.
8802         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8803         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8804         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8805         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8806         initialization.
8807         * solib.c (solib_global_lookup): Simplify.
8808         * symtab.c (null_block_symbol): Remove.
8809         (symbol_cache_lookup): Simplify returns.
8810         (lookup_language_this): Simplify returns.
8811         (lookup_symbol_aux): Simplify return.
8812         (lookup_local_symbol): Simplify returns.
8813         (lookup_global_symbol_from_objfile): Simplify return.
8814         (lookup_symbol_in_objfile_symtabs)
8815         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8816         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8817         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8818         * cp-namespace.c (cp_lookup_bare_symbol)
8819         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8820         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8821         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8822         (cp_lookup_symbol_via_imports): Simplify initialization.
8823         (find_symbol_in_baseclass): Likewise.
8824         * symtab.h (null_block_symbol): Remove.
8825         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8826         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8827         (d_lookup_symbol_module): Likewise.
8828         (find_symbol_in_baseclass): Simplify initialization.
8829
8830 2019-03-24  Tom Tromey  <tom@tromey.com>
8831
8832         * expression.h: Don't include symtab.h.
8833         (struct block): Forward declare.
8834
8835 2019-03-24  Tom Tromey  <tom@tromey.com>
8836
8837         * c-exp.y (typebase): Remove casts.
8838         * gdbtypes.c (lookup_unsigned_typename, )
8839         (lookup_signed_typename): Remove cast.
8840         * eval.c (parse_to_comma_and_eval): Remove cast.
8841         * parse.c (write_dollar_variable): Remove cast.
8842         * block.h (struct block) <superblock>: Now const.
8843         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8844         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8845         (map_block): Make "block" const.
8846         * symfile.h (struct quick_symbol_functions)
8847         <map_matching_symbols>: Constify block argument to "callback".
8848         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8849         const.
8850         (find_pc_sect_compunit_symtab): Make "b" const.
8851         (find_symbol_at_address): Likewise.
8852         (search_symbols): Likewise.
8853         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8854         (dw2_debug_names_lookup_symbol): Likewise.
8855         (dw2_map_matching_symbols): Update.
8856         * p-valprint.c (pascal_val_print): Remove "block".
8857         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8858         (aux_add_nonlocal_symbols): Make "block" const.
8859         (resolve_subexp): Remove cast.
8860         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8861         const.
8862         (iterate_over_file_blocks): Likewise.
8863         * f-exp.y (%union) <bval>: Remove.
8864         * coffread.c (patch_opaque_types): Make "b" const.
8865         * spu-tdep.c (spu_catch_start): Make "block" const.
8866         * c-valprint.c (print_unpacked_pointer): Remove "block".
8867         * symmisc.c (dump_symtab_1): Make "b" const.
8868         (block_depth): Make "block" const.
8869         * d-exp.y (%union) <bval>: Remove.
8870         * cp-support.h (cp_lookup_rtti_type): Update.
8871         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8872         * psymtab.c (psym_lookup_symbol): Make "block" const.
8873         (maintenance_check_psymtabs): Make "b" const.
8874         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8875         (enumerate_locals, enumerate_args): Update.
8876         * python/py-symtab.c (stpy_global_block): Make "block" const.
8877         (stpy_static_block): Likewise.
8878         * inline-frame.c (block_starting_point_at): Make "new_block"
8879         const.
8880         * block.c (find_block_in_blockvector): Make return type const.
8881         (blockvector_for_pc_sect): Make "b" const.
8882         (find_block_in_blockvector): Make "b" const.
8883
8884 2019-03-23  Tom Tromey  <tom@tromey.com>
8885
8886         * varobj.c (varobj_create): Update.
8887         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8888         * printcmd.c (display_command, do_one_display): Don't reset
8889         innermost_block.
8890         * parser-defs.h (enum innermost_block_tracker_type): Move to
8891         expression.h.
8892         (innermost_block): Update comment.
8893         * parse.c (parse_exp_1): Add tracker_types parameter.
8894         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8895         tracker_types parameter.  Reset innermost_block.
8896         (parse_exp_in_context): Remove.
8897         (parse_expression_for_completion): Update.
8898         * objfiles.c (~objfile): Don't reset expression_context_block or
8899         innermost_block.
8900         * expression.h (enum innermost_block_tracker_type): Move from
8901         parser-defs.h.
8902         (parse_exp_1): Add tracker_types parameter.
8903         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8904         reset innermost_block.
8905
8906 2019-03-23  Tom Tromey  <tom@tromey.com>
8907
8908         * objfiles.h: Include bcache.h.
8909
8910 2019-03-23  Tom Tromey  <tom@tromey.com>
8911
8912         * linespec.c (get_current_search_block): Use
8913         scoped_restore_current_language.
8914         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8915
8916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8917             Jiong Wang  <jiong.wang@arm.com>
8918
8919         * aarch64-linux-tdep.c
8920         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8921         section.
8922         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8923
8924 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8925             Jiong Wang  <jiong.wang@arm.com>
8926
8927         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8928         instructions.
8929         (aarch64_analyze_prologue_test): Add PACIASP test.
8930         (aarch64_prologue_prev_register): Unmask PC value.
8931
8932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8933             Jiong Wang  <jiong.wang@arm.com>
8934
8935         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8936         (aarch64_dwarf2_prev_register): Unmask PC value.
8937         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8938         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8939         DW_CFA_AARCH64_negate_ra_state.
8940         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8941
8942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8943             Jiong Wang  <jiong.wang@arm.com>
8944
8945         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8946         registers.
8947         (aarch64_pseudo_register_name): Likewise.
8948         (aarch64_pseudo_register_type): Likewise.
8949         (aarch64_pseudo_register_reggroup_p): Likewise.
8950         (aarch64_gdbarch_init): Add pauth registers.
8951         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8952         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8953         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8954         (struct gdbarch_tdep): Add regnum for ra_state.
8955
8956 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8957             Jiong Wang  <jiong.wang@arm.com>
8958
8959         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8960
8961 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8962             Jiong Wang  <jiong.wang@arm.com>
8963
8964         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8965         function.
8966         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8967         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8968         (aarch64_gdbarch_init): Add puth registers.
8969         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8970         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8971         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8972
8973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8974             Jiong Wang  <jiong.wang@arm.com>
8975
8976         * aarch64-linux-nat.c
8977         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8978         * aarch64-linux-tdep.c
8979         (aarch64_linux_core_read_description): Likewise.
8980         (aarch64_linux_get_hwcap): New function.
8981         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8982         (aarch64_linux_get_hwcap): New declaration.
8983
8984 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8985             Jiong Wang  <jiong.wang@arm.com>
8986
8987         * aarch64-linux-nat.c
8988         (aarch64_linux_nat_target::read_description): Add pauth param.
8989         * aarch64-linux-tdep.c
8990         (aarch64_linux_core_read_description): Likewise.
8991         * aarch64-tdep.c (struct target_desc): Add in pauth.
8992         (aarch64_read_description): Add pauth param.
8993         (aarch64_gdbarch_init): Likewise.
8994         * aarch64-tdep.h (aarch64_read_description): Likewise.
8995         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8996         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8997         * features/Makefile: Add new files.
8998         * features/aarch64-pauth.c: New file.
8999         * features/aarch64-pauth.xml: New file.
9000
9001 2019-03-20  Tom Tromey  <tromey@adacore.com>
9002
9003         * infrun.c (handle_inferior_event): Rename from
9004         handle_inferior_event_1.  Create a scoped_value_mark.
9005         (handle_inferior_event): Remove.
9006
9007 2019-03-19  Tom Tromey  <tromey@adacore.com>
9008
9009         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9010         * infrun.h (print_stop_event): Add "displays" parameter.
9011         * infrun.c (print_stop_event): Add "displays" parameter.
9012
9013 2019-03-19  Pedro Alves  <palves@redhat.com>
9014
9015         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9016         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9017         to -1.  Fix TABs vs spaces.
9018         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9019         * tui/tui-out.h (tui_ui_out) Add intro comments.
9020         <m_line, m_start_of_line>: In-class initialize, and add describing
9021         comment.
9022
9023 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9024
9025         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9026         variable names.
9027         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9028
9029 2019-03-18  Pedro Alves  <palves@redhat.com>
9030             Eli Zaretskii <eliz@gnu.org>
9031
9032         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9033         m_line and m_start_of_line.
9034
9035 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9036
9037         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9038         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9039         it returns a newline.  This fixes a regression in TU mode, whereby
9040         the next line is output on the same screen line as the user input.
9041
9042 2019-03-18  Tom Tromey  <tromey@adacore.com>
9043
9044         * minsyms.c (minimal_symbol_reader::install): Remove call to
9045         obstack_blank.
9046
9047 2019-03-18  Pedro Alves  <palves@redhat.com>
9048
9049         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9050         New globals.
9051         (apply_style): New, factored out from ...
9052         (apply_ansi_escape): ... this.  Handle reverse video mode.
9053         (tui_set_reverse_mode): New function.
9054         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9055         * tui/tui-winsource.c (tui_show_source_line): Use
9056         tui_set_reverse_mode instead of setting A_STANDOUT.
9057         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9058         New setter methods.
9059
9060 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9061
9062         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9063         Handle tabs.
9064
9065 2019-03-18  Tom Tromey  <tromey@adacore.com>
9066
9067         * ada-lang.c (empty_array): Add "high" parameter.
9068         (ada_evaluate_subexp): Update.
9069
9070 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9071
9072         * unittests/string_view-selftests.c: Define
9073         _initialize_string_view_selftests unconditionally.
9074
9075 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9076
9077         PR gdb/24350
9078         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9079
9080 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9081
9082         PR gdb/24351
9083         * windows-nat.c (display_selector): Fix format specifiers.
9084
9085 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9086
9087         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9088         tui_refill_source_window instead of tui_refresh_win, to update the
9089         current execution line.  This fixes redisplay of the current line
9090         when stepping through the code with "next" or "step".
9091
9092 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9093
9094         * source-cache.c (source_cache::get_source_lines): Call
9095         find_source_lines to initialize s->nlines.  This fixes vertical
9096         scrolling of TUI source window when the DOWN arrow is pressed.
9097
9098 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9099
9100         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9101         linux-thread-db.c (_initialize_thread_db): Likewise.
9102
9103 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9104
9105         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9106         wclrtoeol in tui_show_source_line".  This reverts changes made in
9107         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9108
9109 2019-03-15  Tom Tromey  <tom@tromey.com>
9110
9111         * symtab.h (struct minimal_symbol): Derive from
9112         general_symbol_info.
9113         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9114         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9115         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9116         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9117         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9118         (MSYMBOL_SEARCH_NAME): Update.
9119         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9120         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9121         * minsyms.c (minimal_symbol_reader::record_full): Update.
9122
9123 2019-03-15  Tom Tromey  <tom@tromey.com>
9124
9125         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9126
9127 2019-03-15  Tom Tromey  <tom@tromey.com>
9128
9129         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9130         unique_xmalloc_ptr.
9131         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9132         Update.
9133         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9134         (build_minimal_symbol_hash_tables)
9135         (minimal_symbol_reader::install): Update.
9136
9137 2019-03-15  Tom Tromey  <tom@tromey.com>
9138
9139         * symtab.c (create_demangled_names_hash): Update.
9140         (symbol_set_names): Update.
9141         * objfiles.h (struct objfile_per_bfd_storage)
9142         <demangled_names_hash>: Now an htab_up.
9143         * objfiles.c (objfile_per_bfd_storage): Simplify.
9144
9145 2019-03-15  Tom Tromey  <tom@tromey.com>
9146
9147         * objfiles.h (struct objfile_per_bfd_storage): Declare
9148         destructor.
9149         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9150         New.
9151         (get_objfile_bfd_data): Use new.  Don't initialize
9152         language_of_main.
9153         (free_objfile_per_bfd_storage): Remove.
9154         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9155
9156 2019-03-15  Tom Tromey  <tom@tromey.com>
9157
9158         * symfile.c (reread_symbols): Update.
9159         * objfiles.c (objfile::objfile): Update.
9160         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9161         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9162         comment.
9163         (minimal_symbol_reader::install): Update.
9164         (terminate_minimal_symbol_table): Remove.
9165         * jit.c (jit_object_close_impl): Update.
9166
9167 2019-03-15  Tom Tromey  <tom@tromey.com>
9168
9169         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9170         initializations.
9171
9172 2019-03-15  Tom Tromey  <tom@tromey.com>
9173
9174         * objfiles.h (struct objfile_per_bfd_storage)
9175         <demangled_hash_languages>: Now a bitset.
9176         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9177         (lookup_minimal_symbol): Update.
9178
9179 2019-03-15  Tom Tromey  <tom@tromey.com>
9180
9181         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9182         Don't return the symbol.
9183         * coffread.c (record_minimal_symbol): Use record_full.
9184
9185 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9186
9187         The MS-Windows port of ncurses fails to switch to a color pair if
9188         one or both of the colors are the implicit default colors.  This
9189         change records the default colors when TUI is initialized, and
9190         then specifies them explicitly when a color pair uses the default
9191         colors.  This allows color styling in TUI mode on MS-Windows.
9192
9193         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9194         ncurses_norm_attr.
9195         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9196         colors in ncurses_norm_attr.
9197         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9198         "none", replace it with the default color recorded in
9199         ncurses_norm_attr.
9200
9201 2019-03-14  Tom Tromey  <tromey@adacore.com>
9202
9203         * source-cache.h (class source_cache) <get_source_lines>: Return
9204         std::string.
9205         * source-cache.c (source_cache::extract_lines): Handle case where
9206         first_pos==npos.  Return std::string.
9207         (source_cache::get_source_lines): Update.
9208
9209 2019-03-14  Tom Tromey  <tromey@adacore.com>
9210
9211         * NEWS: Add item for "style sources" commands.
9212         * source-cache.c (source_cache::get_source_lines): Check
9213         source_styling.
9214         * cli/cli-style.c (source_styling): New global.
9215         (_initialize_cli_style): Add "style sources" commands.
9216         (show_style_sources): New function.
9217         * cli/cli-style.h (source_styling): Declare.
9218
9219 2019-03-14  Pedro Alves  <palves@redhat.com>
9220             Tom Tromey  <tromey@adacore.com>
9221
9222         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9223         * tui/tui-winsource.c (tui_refill_source_window): New function,
9224         from...
9225         (tui_horizontal_source_scroll): ... here.  Move some logic.
9226         * cli/cli-style.c (set_style_enabled): Notify new observable.
9227         * tui/tui-hooks.c (tui_redisplay_source): New function.
9228         (tui_attach_detach_observers): Attach or detach
9229         tui_redisplay_source.
9230         * observable.h (source_styling_changed): New observable.
9231         * observable.c: Define source_styling_changed observable.
9232
9233 2019-03-13  Tom Tromey  <tromey@adacore.com>
9234
9235         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9236         (i386_gnu_nat_target::store_registers): Update.
9237         * target-debug.h (target_debug_print_std_string): New macro.
9238         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9239         * windows-tdep.c (display_one_tib): Update.
9240         * tui/tui-stack.c (tui_make_status_line): Update.
9241         * top.c (print_inferior_quit_action): Update.
9242         * thread.c (thr_try_catch_cmd): Update.
9243         (add_thread_with_info): Update.
9244         (thread_target_id_str): Update.
9245         (thr_try_catch_cmd): Update.
9246         (thread_command): Update.
9247         (thread_find_command): Update.
9248         * record-btrace.c (record_btrace_target::info_record)
9249         (record_btrace_resume_thread, record_btrace_target::resume)
9250         (record_btrace_cancel_resume, record_btrace_step_thread)
9251         (record_btrace_target::wait, record_btrace_target::wait)
9252         (record_btrace_target::wait, record_btrace_target::stop): Update.
9253         * progspace.c (print_program_space): Update.
9254         * process-stratum-target.c
9255         (process_stratum_target::thread_address_space): Update.
9256         * linux-fork.c (linux_fork_mourn_inferior)
9257         (detach_checkpoint_command, info_checkpoints_command)
9258         (linux_fork_context): Update.
9259         (linux_fork_detach): Update.
9260         (class scoped_switch_fork_info): Update.
9261         (delete_checkpoint_command): Update.
9262         * infrun.c (follow_fork_inferior): Update.
9263         (follow_fork_inferior): Update.
9264         (proceed_after_vfork_done): Update.
9265         (handle_vfork_child_exec_or_exit): Update.
9266         (follow_exec): Update.
9267         (displaced_step_prepare_throw): Update.
9268         (displaced_step_restore): Update.
9269         (start_step_over): Update.
9270         (resume_1): Update.
9271         (clear_proceed_status_thread): Update.
9272         (proceed): Update.
9273         (print_target_wait_results): Update.
9274         (do_target_wait): Update.
9275         (context_switch): Update.
9276         (stop_all_threads): Update.
9277         (restart_threads): Update.
9278         (finish_step_over): Update.
9279         (handle_signal_stop): Update.
9280         (switch_back_to_stepped_thread): Update.
9281         (keep_going_pass_signal): Update.
9282         (print_exited_reason): Update.
9283         (normal_stop): Update.
9284         * inferior.c (inferior_pid_to_str): Change return type.
9285         (print_selected_inferior): Update.
9286         (add_inferior): Update.
9287         (detach_inferior): Update.
9288         * dummy-frame.c (fprint_dummy_frames): Update.
9289         * dcache.c (dcache_info_1): Update.
9290         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9291         (btrace_fetch, btrace_clear): Update.
9292         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9293         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9294         type.
9295         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9296         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9297         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9298         * gdbarch.c, gdbarch.h: Rebuild.
9299         * gdbarch.sh (core_pid_to_str): Change return type.
9300         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9301         return type.
9302         (windows_nat_target::pid_to_str): Change return type.
9303         (windows_delete_thread): Update.
9304         (windows_nat_target::attach): Update.
9305         (windows_nat_target::files_info): Update.
9306         * target-delegates.c: Rebuild.
9307         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9308         return type.
9309         (sol_thread_target::pid_to_str): Change return type.
9310         * remote.c (class remote_target) <pid_to_str>: Change return
9311         type.
9312         (remote_target::pid_to_str): Change return type.
9313         (extended_remote_target::attach, remote_target::remote_stop_ns)
9314         (remote_target::remote_notif_remove_queued_reply)
9315         (remote_target::push_stop_reply, remote_target::disable_btrace):
9316         Update.
9317         (extended_remote_target::attach): Update.
9318         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9319         type.
9320         (gdbsim_target::pid_to_str): Change return type.
9321         * ravenscar-thread.c (struct ravenscar_thread_target)
9322         <pid_to_str>: Change return type.
9323         (ravenscar_thread_target::pid_to_str): Change return type.
9324         * procfs.c (class procfs_target) <pid_to_str>: Change return
9325         type.
9326         (procfs_target::pid_to_str): Change return type.
9327         (procfs_target::attach): Update.
9328         (procfs_target::detach): Update.
9329         (procfs_target::fetch_registers): Update.
9330         (procfs_target::store_registers): Update.
9331         (procfs_target::wait): Update.
9332         (procfs_target::files_info): Update.
9333         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9334         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9335         return type.
9336         (nto_procfs_target::pid_to_str): Change return type.
9337         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9338         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9339         return type.
9340         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9341         (exit_lwp): Update.
9342         (attach_proc_task_lwp_callback, get_detach_signal)
9343         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9344         (linux_nat_target::resume, wait_lwp, stop_callback)
9345         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9346         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9347         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9348         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9349         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9350         type.
9351         (inf_ptrace_target::attach): Update.
9352         (inf_ptrace_target::files_info): Update.
9353         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9354         type.
9355         (go32_nat_target::pid_to_str): Change return type.
9356         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9357         (gnu_nat_target::wait): Update.
9358         (gnu_nat_target::wait): Update.
9359         (gnu_nat_target::resume): Update.
9360         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9361         (fbsd_nat_target::wait): Update.
9362         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9363         type.
9364         (darwin_nat_target::attach): Update.
9365         * corelow.c (class core_target) <pid_to_str>: Change return type.
9366         (core_target::pid_to_str): Change return type.
9367         * target.c (normal_pid_to_str): Change return type.
9368         (default_pid_to_str): Likewise.
9369         (target_pid_to_str): Change return type.
9370         (target_translate_tls_address): Update.
9371         (target_announce_detach): Update.
9372         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9373         return type.
9374         (bsd_uthread_target::pid_to_str): Change return type.
9375         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9376         type.
9377         (bsd_kvm_target::pid_to_str): Change return type.
9378         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9379         return type.
9380         (aix_thread_target::pid_to_str): Change return type.
9381         * target.h (struct target_ops) <pid_to_str>: Change return type.
9382         (target_pid_to_str, normal_pid_to_str): Likewise.
9383         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9384         type.
9385         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9386         type.
9387         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9388         return type.
9389         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9390         type.
9391         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9392         type.
9393         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9394         return type.
9395
9396 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9397
9398         * NEWS: Mention that the new default MI version is 3.  Mention
9399         changes to the output of commands and events that deal with
9400         multi-location breakpoints.
9401         * breakpoint.c: Include "mi/mi-out.h".
9402         (print_one_breakpoint): Change output syntax if using MI version
9403         >= 3.
9404         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9405         New.
9406         (mi_multi_location_breakpoint_output_fixed): New.
9407         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9408         (mi_cmd_fix_multi_location_breakpoint_output): New.
9409         (mi_multi_location_breakpoint_output_fixed): New.
9410         * mi/mi-cmds.c (mi_cmds): Register command
9411         -fix-multi-location-breakpoint-output.
9412         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9413         interpreter "mi".
9414
9415 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9416
9417         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9418         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9419         instantiate mi_ui_out based on interpreter name.
9420         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9421         * mi/mi-main.c (mi_load_progress): Likewise.
9422
9423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9424
9425         * NEWS: Combine separate "New targets" sections for 8.3.
9426
9427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9428
9429         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9430         (ppcfbsd_init_abi): Install gdbarch
9431         "fetch_tls_load_module_address" and "get_thread_local_address"
9432         methods.
9433
9434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9435
9436         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9437         (riscv_fbsd_init_abi): Install gdbarch
9438         "fetch_tls_load_module_address" and "get_thread_local_address"
9439         methods.
9440
9441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9442
9443         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9444         (i386fbsd_init_abi): Install gdbarch
9445         "fetch_tls_load_module_address" and "get_thread_local_address"
9446         methods.
9447
9448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9449
9450         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9451         (amd64fbsd_init_abi): Install gdbarch
9452         "fetch_tls_load_module_address" and "get_thread_local_address"
9453         methods.
9454
9455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9456
9457         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9458         (struct fbsd_pspace_data): New type.
9459         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9460         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9461         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9462         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9463         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9464
9465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9466
9467         * gdbtypes.c (lookup_struct_elt): New function.
9468         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9469         * gdbtypes.h (struct struct_elt): New type.
9470         (lookup_struct_elt): New prototype.
9471
9472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9473
9474         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9475         remove disabled code block.
9476
9477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9478
9479         * gdbarch.sh (get_thread_local_address): New method.
9480         * gdbarch.h, gdbarch.c: Regenerate.
9481         * target.c (target_translate_tls_address): Use
9482         gdbarch_get_thread_local_address if present instead of
9483         target::get_thread_local_address.
9484
9485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9486
9487         * target.h (target::get_thread_local_address): Update comment.
9488
9489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9490
9491         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9492         objfile->separate_debug_objfile_backlink if not NULL.
9493
9494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9495
9496         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9497         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9498         (amd64bsd_store_inferior_registers): Likewise.
9499         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9500         Enable segment base registers.
9501         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9502         PT_GETFSBASE and PT_GETGSBASE.
9503         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9504         PT_SETGSBASE.
9505         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9506         segment base registers.
9507         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9508
9509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9510
9511         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9512         Update calls to i386_target_description to add 'segments'
9513         parameter.
9514         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9515         add segment base registers.
9516         * arch/i386.c (i386_create_target_description): Add 'segments'
9517         parameter to enable segment base registers.
9518         * arch/i386.h (i386_create_target_description): Likewise.
9519         * features/i386/32bit-segments.xml: New file.
9520         * features/i386/32bit-segments.c: Generate.
9521         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9522         call to i386_target_description to add 'segments' parameter.
9523         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9524         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9525         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9526         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9527         if feature is present.
9528         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9529         Add 'segments' parameter to call to i386_target_description.
9530         (i386_target_description): Add 'segments' parameter to enable
9531         segment base registers.
9532         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9533         to call to i386_target_description.
9534         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9535         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9536         Define I386_NUM_REGS.
9537         (i386_target_description): Add 'segments' parameter to enable
9538         segment base registers.
9539
9540 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9541
9542         PR/24325
9543         * source-cache.c: #undef open and close, to avoid unresolved
9544         externals during linking.
9545
9546 2019-03-12  Tom Tromey  <tromey@adacore.com>
9547
9548         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9549         const.  Add initializers.
9550         (_initialize_remote): Don't initialize ptid globals.
9551
9552 2019-03-12  Pedro Alves  <palves@redhat.com>
9553
9554         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9555
9556 2019-03-12  Pedro Alves  <palves@redhat.com>
9557
9558         * cp-name-parser.y (main): Remove unused 'len' variable.
9559
9560 2019-03-12  Tom Tromey  <tromey@adacore.com>
9561
9562         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9563         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9564
9565 2019-03-12  Tom Tromey  <tromey@adacore.com>
9566
9567         * linux-nat.c (iterate_over_lwps): Update.
9568         (stop_callback): Remove parameter.
9569         (stop_wait_callback, detach_callback, resume_set_callback)
9570         (select_singlestep_lwp_callback, set_ignore_sigint)
9571         (status_callback, resumed_callback, resume_clear_callback)
9572         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9573         data parameter.
9574         (linux_nat_target::detach, linux_nat_target::resume)
9575         (linux_stop_and_wait_all_lwps, select_event_lwp)
9576         (linux_nat_filter_event, linux_nat_wait_1)
9577         (linux_nat_target::kill, linux_nat_target::stop)
9578         (linux_nat_target::stop): Update.
9579         (linux_nat_resume_callback): Change type.
9580         (resume_stopped_resumed_lwps, count_events_callback)
9581         (select_event_lwp_callback): Likewise.
9582         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9583         * arm-linux-nat.c (struct update_registers_data): Remove.
9584         (update_registers_callback): Change type.
9585         (arm_linux_insert_hw_breakpoint1): Update.
9586         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9587         parameter.
9588         (x86_linux_dr_set_addr): Update.
9589         (x86_linux_dr_set_control): Update.
9590         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9591         (iterate_over_lwps): Use gdb::function_view.
9592         * nat/aarch64-linux-hw-point.c (struct
9593         aarch64_dr_update_callback_param): Remove.
9594         (debug_reg_change_callback): Change type.
9595         (aarch64_notify_debug_reg_change): Update.
9596         * s390-linux-nat.c (s390_refresh_per_info): Update.
9597
9598 2019-03-11  Tom Tromey  <tromey@adacore.com>
9599
9600         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9601         redundant assignment to "this_cu".
9602
9603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9604
9605         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9606
9607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9608
9609         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9610         from...
9611         (rank_one_type): ... this.
9612
9613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9614
9615         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9616         from...
9617         (rank_one_type): ... this.
9618
9619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9620
9621         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9622         from...
9623         (rank_one_type): ... this.
9624
9625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9626
9627         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9628         from...
9629         (rank_one_type): ... this.
9630
9631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9632
9633         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9634         from...
9635         (rank_one_type): ... this.
9636
9637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9638
9639         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9640         from...
9641         (rank_one_type): ... this.
9642
9643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9644
9645         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9646         from...
9647         (rank_one_type): ... this.
9648
9649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9650
9651         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9652         from...
9653         (rank_one_type): ... this.
9654
9655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9656
9657         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9658         from...
9659         (rank_one_type): ... this.
9660
9661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9662
9663         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9664         from...
9665         (rank_one_type): ... this.
9666
9667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9668
9669         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9670         from...
9671         (rank_one_type): ... this.
9672
9673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9674
9675         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9676         from...
9677         (rank_one_type): ... this.
9678
9679 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9680
9681         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9682         inferior-events' shows the example events.
9683
9684 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9685
9686         Support styling on native MS-Windows console
9687
9688         PR/24315
9689         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9690         on MS-Windows if $TERM is not defined.
9691
9692         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9693
9694         * posix-hdep.c (gdb_console_fputs):
9695         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9696         functions.
9697         * ui-file.h (gdb_console_fputs): Add prototype.
9698
9699         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9700         back to fputs only if the former returns zero.
9701
9702 2019-03-07  Tom Tromey  <tom@tromey.com>
9703
9704         * symmisc.c (print_symbol_bcache_statistics): Update.
9705         (print_objfile_statistics): Update.
9706         * symfile.c (allocate_symtab): Update.
9707         * stabsread.c: Don't include bcache.h.
9708         * psymtab.h (struct psymbol_bcache): Don't declare.
9709         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9710         (psymbol_bcache_init, psymbol_bcache_free)
9711         (psymbol_bcache_get_bcache): Don't declare.
9712         * psymtab.c (struct psymbol_bcache): Remove.
9713         (psymtab_storage::psymtab_storage): Update.
9714         (psymtab_storage::~psymtab_storage): Update.
9715         (psymbol_bcache_init, psymbol_bcache_free)
9716         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9717         (add_psymbol_to_bcache): Update.
9718         (allocate_psymtab): Update.
9719         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9720         macro_cache>: No longer pointers.
9721         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9722         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9723         * macrotab.c (macro_bcache): Update.
9724         * macroexp.c: Don't include bcache.h.
9725         * gdbtypes.c (check_types_worklist): Update.
9726         (types_deeply_equal): Remove TRY/CATCH.  Update.
9727         * elfread.c (elf_symtab_read): Update.
9728         * dwarf2read.c: Don't include bcache.h.
9729         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9730         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9731         (print_bcache_statistics, bcache_memory_used): Don't declare.
9732         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9733         methods.  Rename all data members.
9734         * bcache.c (struct bcache): Move to bcache.h.
9735         (bcache::expand_hash_table): Rename from expand_hash_table.
9736         (bcache): Remove.
9737         (bcache::insert): Rename from bcache_full.
9738         (bcache::compare): Rename from bcache_compare.
9739         (bcache_xmalloc): Remove.
9740         (bcache::~bcache): Rename from bcache_xfree.
9741         (bcache::print_statistics): Rename from print_bcache_statistics.
9742         (bcache::memory_used): Rename from bcache_memory_used.
9743
9744 2019-03-07  Pedro Alves  <palves@redhat.com>
9745
9746         * infrun.c (normal_stop): Also check for
9747         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9748
9749 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9750
9751         * f-lang.c (value_from_host_double): Moved to...
9752         * value.c (value_from_host_double): ...here.
9753         * value.h (value_from_host_double): Declare.
9754         * guile/scm-math.c (vlscm_convert_typed_number): Use
9755         value_from_host_double.
9756         (vlscm_convert_number): Likewise.
9757         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9758         * python/py-value.c (convert_value_from_python): Likewise.
9759
9760 2019-03-06  Tom Tromey  <tom@tromey.com>
9761
9762         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9763
9764 2019-03-06  Tom Tromey  <tom@tromey.com>
9765
9766         * utils.h (free_current_contents): Don't declare.
9767         * utils.c (free_current_contents): Remove.
9768
9769 2019-03-06  Tom Tromey  <tom@tromey.com>
9770
9771         * top.c (quit_force): Update.
9772         * main.c (captured_command_loop): Update.
9773         * common/new-op.c (operator new): Update.
9774         * common/common-exceptions.c (struct catcher)
9775         <save_cleanup_chain>: Remove member.
9776         (exceptions_state_mc_init): Update.
9777         (exception_try_scope_entry): Return nullptr.
9778         (exception_try_scope_exit, exception_rethrow)
9779         (throw_exception_sjlj, throw_exception_cxx): Update.
9780         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9781         (all_cleanups, do_cleanups, discard_cleanups)
9782         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9783         (restore_cleanups, restore_final_cleanups): Don't declare.
9784         (do_final_cleanups): Remove parameter.
9785         * common/cleanups.c (cleanup_chain, make_cleanup)
9786         (make_cleanup_dtor, all_cleanups, do_cleanups)
9787         (discard_my_cleanups, discard_cleanups)
9788         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9789         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9790         (null_cleanup): Remove.
9791         (do_final_cleanups): Remove parameter.
9792
9793 2019-03-06  Tom Tromey  <tom@tromey.com>
9794
9795         * remote.c (remote_target::remote_parse_stop_reply): Use
9796         unique_xmalloc_ptr.
9797
9798 2019-03-06  Tom Tromey  <tom@tromey.com>
9799
9800         * stabsread.c (struct stabs_field_info): Rename from field_info.
9801         <list, fnlist>: Add initializers.
9802         <obstack>: New member.
9803         (read_member_functions, read_struct_fields, read_baseclasses):
9804         Allocate on obstack.  Don't use cleanups.
9805         (read_one_struct_field, read_member_functions, read_struct_fields)
9806         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9807         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9808         (read_struct_type): Update.
9809
9810 2019-03-06  Tom Tromey  <tom@tromey.com>
9811
9812         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9813         * common/filestuff.h (make_cleanup_close): Don't declare.
9814         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9815         Remove.
9816
9817 2019-03-06  Tom Tromey  <tom@tromey.com>
9818
9819         * solib-aix.c: Use make_scope_exit.
9820
9821 2019-03-06  Tom Tromey  <tom@tromey.com>
9822
9823         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9824         Use make_scope_exit.
9825
9826 2019-03-06  Tom Tromey  <tom@tromey.com>
9827
9828         * solib-svr4.c (disable_probes_interface): Remove parameter.
9829         (svr4_handle_solib_event): Use make_scope_exit.
9830
9831 2019-03-06  Tom Tromey  <tom@tromey.com>
9832
9833         * remote.c (struct stop_reply_deleter): Remove.
9834         (stop_reply_up): Update.
9835         (struct stop_reply): Derive from notif_event.  Don't typedef.
9836         <regcache>: Now a std::vector.
9837         (stop_reply_xfree): Remove.
9838         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9839         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9840         (remote_target::discard_pending_stop_replies): Use delete.
9841         (remote_target::remote_parse_stop_reply): Update.
9842         (remote_target::process_stop_reply): Update.
9843         * remote-notif.h (struct notif_event): Add virtual destructor.
9844         Remove "dtr" member.
9845         (struct notif_client) <alloc_event>: Return a unique_ptr.
9846         (notif_event_xfree): Don't declare.
9847         (notif_event_up): New typedef.
9848         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9849         (notif_event_xfree, do_notif_event_xfree): Remove.
9850         (remote_notif_state_xfree): Update.
9851
9852 2019-03-06  Tom Tromey  <tom@tromey.com>
9853
9854         * infrun.c (displaced_step_clear_cleanup): Now a
9855         forward_scope_exit type.
9856         (displaced_step_prepare_throw): Update.
9857         (displaced_step_fixup): Update.
9858
9859 2019-03-06  Tom Tromey  <tom@tromey.com>
9860
9861         * inferior.h (class inferior): Update comment.
9862         * gdbthread.h (class thread_info): Update comment.
9863
9864 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9865             Tom Tromey  <tom@tromey.com>
9866
9867         * stabsread.h (struct stab_section_list): Remove.
9868         (coffstab_build_psymtabs): Update.
9869         * dbxread.c (symbuf_sections): Now a std::vector.
9870         (sect_idx): New global.
9871         (fill_symbuf): Update.
9872         (coffstab_build_psymtabs): Change type of stabsects parameter.
9873         Update.
9874         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9875         std::vector.
9876         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9877         (coff_locate_sections): Update.
9878         (coff_symfile_read): Remove cleanups.  Update.
9879         (init_stringtab): Add storage parameter.
9880         (free_stringtab, free_stringtab_cleanup): Remove.
9881         (init_lineno): Add storage parameter.
9882         (free_linetab, free_linetab_cleanup): Remove.
9883
9884 2019-03-06  Pedro Alves  <palves@redhat.com>
9885
9886         * linux-fork.c (fork_info::clobber_regs): Delete.
9887         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9888         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9889         comment.  Adjust.
9890         (scoped_switch_fork_info::scoped_switch_fork_info)
9891         (checkpoint_command, linux_fork_context): Adjust
9892         fork_save_infrun_state calls.
9893
9894 2019-03-06  Pedro Alves  <palves@redhat.com>
9895
9896         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9897         (inf_has_multiple_threads): Return 'bool' and rewrite using
9898         inferior_info::threads().
9899
9900 2019-03-06  Pedro Alves  <palves@redhat.com>
9901
9902         * linux-fork.c: Include <list>.
9903         (fork_list): Now a std::list instance.
9904         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9905         (forks_exist_p, find_last_fork): Adjust.
9906         (new_fork): Delete.
9907         (one_fork_p): New.
9908         (add_fork): Adjust.
9909         (free_fork): Delete, folded into fork_info::~fork_info().
9910         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9911         Adjust.
9912         (init_fork_list): Delete.
9913         (linux_fork_killall, linux_fork_mourn_inferior)
9914         (linux_fork_detach, info_checkpoints_command): Adjust.
9915         (_initialize_linux_fork): No longer call init_fork_list.
9916
9917 2019-03-06  Pedro Alves  <palves@redhat.com>
9918
9919         * linux-fork.c (new_fork): New, split out of ...
9920         (add_fork): ... this.  Return void.  Move "first fork" special
9921         case from here, to ...
9922         (checkpoint_command): ... here.
9923         * linux-linux.h (add_fork): Return void.
9924
9925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9928
9929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9930             Chris January  <chris.january@arm.com>
9931             David Lecomber  <david.lecomber@arm.com>
9932
9933         * f-exp.y: New token, UNOP_INTRINSIC.
9934         (exp): New pattern using UNOP_INTRINSIC token.
9935         (f77_keywords): Add 'abs' keyword.
9936         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9937         (value_from_host_double): New function.
9938         (evaluate_subexp_f): Support UNOP_ABS.
9939
9940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9941
9942         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9943         types.
9944
9945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9946
9947         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9948         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9949         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9950
9951 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9952
9953         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9954
9955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9956             Chris January  <chris.january@arm.com>
9957
9958         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9959         * f-exp.y: Define 'KIND' token.
9960         (exp): New pattern for KIND expressions.
9961         (ptype): Handle types with a kind extension.
9962         (direct_abs_decl): Extend to spot kind extensions.
9963         (f77_keywords): Add 'kind' to the list.
9964         (push_kind_type): New function.
9965         (convert_to_kind_type): New function.
9966         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9967         * parse.c (operator_length_standard): Likewise.
9968         * parser-defs.h (enum type_pieces): Add tp_kind.
9969         * std-operator.def: Add UNOP_KIND.
9970
9971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9972
9973         * f-exp.y (f_parse): Set yydebug.
9974
9975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9976
9977         * f-lang.c (evaluate_subexp_f): New function.
9978         (exp_descriptor_f): New global.
9979         (f_language_defn): Use exp_descriptor_f instead of
9980         exp_descriptor_standard.
9981
9982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9983
9984         * f-exp.y (struct token): Add comments.
9985         (dot_ops): Remove uppercase versions and the end marker.
9986         (f77_keywords): Likewise.
9987         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9988         entries in the dot_ops array are case insensitive, and use
9989         strncasecmp to compare strings.  Also some whitespace cleanup in
9990         this area.  Similar for the f77_keywords array, except entries in
9991         this list might be case sensitive.
9992
9993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9994
9995         * f-exp.y (struct f77_boolean_val): Add comments.
9996         (boolean_values): Remove uppercase versions, and end marker.
9997         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9998         and use strncasecmp to achieve case insensitivity.  Additionally,
9999         perform whitespace cleanup around this code.
10000
10001 2019-03-06  Tom Tromey  <tromey@adacore.com>
10002
10003         * remote-sim.c (gdbsim_target_open): Use result of
10004         gdb_argv::release.
10005
10006 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10007         Dirk Schubert  <dirk.schubert@arm.com>
10008         Chris January  <chris.january@arm.com>
10009
10010         * eval.c (evaluate_subexp_standard): Call Fortran argument
10011         wrapping logic.
10012         * f-lang.c (struct value): A value which can be passed into a
10013         Fortran function call.
10014         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10015         where appropriate.
10016         (struct type): Value ready for a Fortran function call.
10017         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10018         is needed.
10019         * f-lang.h (fortran_argument_convert): Declaration.
10020         (fortran_preserve_arg_pointer): Declaration.
10021         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10022
10023 2019-03-05  Tom Tromey  <tromey@adacore.com>
10024
10025         * python/py-prettyprint.c (print_string_repr): Remove #if.
10026         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10027
10028 2019-03-05  Tom Tromey  <tromey@adacore.com>
10029
10030         * target.c (the_dummy_target): Move later.  Change type to
10031         "dummy_target".
10032         (initialize_targets): Don't initialize the_dummy_target.
10033
10034 2019-03-05  Tom Tromey  <tromey@adacore.com>
10035
10036         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10037         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10038
10039 2019-03-05  Tom Tromey  <tromey@adacore.com>
10040
10041         * windows-nat.c (windows_nat_target::attach)
10042         (windows_nat_target::detach): Don't call gdb_flush.
10043         * valprint.c (generic_val_print, val_print, val_print_string):
10044         Don't call gdb_flush.
10045         * utils.c (defaulted_query): Don't call gdb_flush.
10046         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10047         * target.c (target_announce_detach): Don't call gdb_flush.
10048         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10049         * remote.c (extended_remote_target::attach): Don't call
10050         gdb_flush.
10051         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10052         * printcmd.c (do_examine): Don't call gdb_flush.
10053         (info_display_command): Don't call gdb_flush.
10054         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10055         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10056         * memattr.c (info_mem_command): Don't call gdb_flush.
10057         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10058         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10059         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10060         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10061         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10062         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10063         (gnu_nat_target::detach): Don't call gdb_flush.
10064         * f-valprint.c (f_val_print): Don't call gdb_flush.
10065         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10066         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10067         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10068         gdb_flush.
10069         * c-valprint.c (c_val_print): Don't call gdb_flush.
10070         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10071
10072 2019-03-05  Tom Tromey  <tromey@adacore.com>
10073
10074         * varobj.c (update_dynamic_varobj_children): Update.
10075         (install_default_visualizer): Use reset, not release.
10076         * value.c (set_internalvar): Update.
10077         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10078         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10079         ATTRIBUTE_UNUSED_RESULT.
10080
10081 2019-03-05  Tom Tromey  <tromey@adacore.com>
10082
10083         * remote.c (class scoped_remote_fd) <release>: Add
10084         ATTRIBUTE_UNUSED_RESULT.
10085
10086 2019-03-05  Tom Tromey  <tromey@adacore.com>
10087
10088         * macroexp.c (struct macro_buffer) <release>: Add
10089         ATTRIBUTE_UNUSED_RESULT.
10090
10091 2019-03-05  Tom Tromey  <tromey@adacore.com>
10092
10093         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10094         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10095         ATTRIBUTE_UNUSED_RESULT.
10096
10097 2019-03-05  Tom Tromey  <tromey@adacore.com>
10098
10099         * common/scoped_fd.h (class scoped_fd) <release>: Add
10100         ATTRIBUTE_UNUSED_RESULT.
10101
10102 2019-03-05  Tom Tromey  <tromey@adacore.com>
10103
10104         * parser-defs.h (struct parser_state) <release>: Add
10105         ATTRIBUTE_UNUSED_RESULT.
10106
10107 2019-03-05  Tom Tromey  <tromey@adacore.com>
10108
10109         * utils.h (class gdb_argv) <release>: Add
10110         ATTRIBUTE_UNUSED_RESULT.
10111         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10112
10113 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10114
10115         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10116         for-loop range, to avoid compiler warnings.
10117
10118         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10119         avoid compiler warnings about unused variables.
10120
10121         * NEWS: Mention end of support for native debugging on MS-Windows
10122         before XP.
10123
10124         PR gdb/24292
10125         * common/netstuff.c:
10126         * gdbserver/gdbreplay.c
10127         * gdbserver/remote-utils.c:
10128         * ser-tcp.c:
10129         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10130         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10131         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10132         'getaddrinfo' and 'freeaddrinfo' were not available before
10133         Windows XP, and mingw.org's MinGW headers by default define
10134         _WIN32_WINNT to 0x500.
10135
10136 2019-03-01  Gary Benson <gbenson@redhat.com>
10137
10138         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10139
10140 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10141             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10142
10143         PR gdb/8527
10144         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10145         set_sigint_trap, clear_sigint_trap.
10146
10147 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10148
10149         * target.c (target_detach): Clear the regcache and the
10150         frame cache.
10151
10152 2019-02-27  Pedro Alves  <palves@redhat.com>
10153
10154         * utils.c (set_screen_size): When we cap the height/width sizes,
10155         tweak the corresponding command variable to show "unlimited":
10156
10157 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10158             Pedro Alves  <palves@redhat.com>
10159
10160         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10161         before calling rl_set_screen_size.
10162
10163 2019-02-27  Tom Tromey  <tromey@adacore.com>
10164
10165         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10166         define.
10167         * python/py-value.c: Remove Python 2.4 workaround.
10168         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10169         workaround.
10170         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10171         Python 2.4 workaround.
10172         * python/python-internal.h: Remove Python 2.4 comment.
10173         (Py_ssize_t): Don't define.
10174         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10175         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10176         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10177         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10178         * python/python.c (do_start_initialization): Remove Python 2.4
10179         workaround.
10180         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10181         (print_children): Remove Python 2.4 workaround.
10182         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10183         workaround.
10184         (CHARBUFFERPROC_NAME): Remove.
10185         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10186         Python 2.4 workaround.
10187
10188 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10189
10190         * NEWS: Note minimum Python version.
10191
10192 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10193
10194         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10195         code from these functions.  Remove corresponding ifdefs.  Use
10196         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10197         Remove gotos and target of gotos.
10198         (infpy_search_memory): Likewise.
10199
10200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10201
10202         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10203         (hppa_gdbarch_init): Don't register deleted functions with
10204         gdbarch.
10205
10206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10207
10208         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10209         (h8300_unwind_sp): Delete.
10210         (h8300_dummy_id): Delete.
10211         (h8300_gdbarch_init): Don't register deleted functions with
10212         gdbarch.
10213
10214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10215
10216         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10217         (ft32_unwind_pc): Delete.
10218         (ft32_unwind_sp): Delete.
10219         (ft32_gdbarch_init): Don't register deleted functions with
10220         gdbarch.
10221
10222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10223
10224         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10225         (frv_unwind_pc): Delete.
10226         (frv_unwind_sp): Delete.
10227         (frv_gdbarch_init): Don't register deleted functions with
10228         gdbarch.
10229
10230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10233         (riscv_unwind_pc): Delete.
10234         (riscv_unwind_sp): Delete.
10235         (riscv_gdbarch_init): Don't register deleted functions with
10236         gdbarch.
10237
10238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10239
10240         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10241         (csky_unwind_pc): Delete.
10242         (csky_unwind_sp): Delete.
10243         (csky_gdbarch_init): Don't register deleted functions with
10244         gdbarch.
10245
10246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10249         (cris_unwind_pc): Delete.
10250         (cris_unwind_sp): Delete.
10251         (cris_gdbarch_init): Don't register deleted functions with
10252         gdbarch.
10253
10254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10255
10256         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10257         (bfin_unwind_pc): Delete.
10258         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10259
10260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10261
10262         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10263         (arm_unwind_pc): Delete.
10264         (arm_unwind_sp): Delete.
10265         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10266
10267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10268
10269         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10270         (arc_unwind_pc): Delete.
10271         (arc_unwind_sp): Delete.
10272         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10273
10274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10275
10276         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10277         (alpha_unwind_pc): Delete.
10278         (alpha_gdbarch_init): Don't register deleted functions with
10279         gdbarch.
10280
10281 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10282
10283         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10284         (aarch64_unwind_pc): Delete.
10285         (aarch64_unwind_sp): Delete.
10286         (aarch64_gdbarch_init): Don't register deleted functions with
10287         gdbarch.
10288
10289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10290
10291         * gdbtypes.c (type_align): Don't consider static members when
10292         computing structure alignment.
10293
10294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10295
10296         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10297         return 0 for other types.
10298         * arch-utils.c (default_type_align): Always return 0.
10299         * gdbarch.h: Regenerate.
10300         * gdbarch.sh (type_align): Extend comment.
10301         * gdbtypes.c (type_align): Add additional comments, always call
10302         gdbarch_type_align before applying the default rules.
10303         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10304         generic code will then apply a suitable default.
10305         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10306         types, return 0 for other types.
10307
10308 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10309
10310         * NEWS: Create a new section for the next release branch.
10311         Rename the section of the current branch, now that it has
10312         been cut.
10313
10314 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10315
10316         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10317         * version.in: Bump version to 8.3.50.DATE-git.
10318
10319 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10320
10321         * aix-thread.c (ptid_cmp): Remove unused variable.
10322         (get_signaled_thread): Likewise.
10323         (store_regs_user_thread): Likewise.
10324         (store_regs_kernel_thread): Likewise.
10325         (fetch_regs_kernel_thread): Remove shadowed variable.
10326
10327 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10328
10329         * features/riscv/32bit-cpu.xml: Add register numbers.
10330         * features/riscv/32bit-fpu.c: Regenerate.
10331         * features/riscv/32bit-fpu.xml: Add register numbers.
10332         * features/riscv/64bit-cpu.xml: Add register numbers.
10333         * features/riscv/64bit-fpu.c: Regenerate.
10334         * features/riscv/64bit-fpu.xml: Add register numbers.
10335
10336 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10337
10338         * NEWS: Mention two argument form of gdb.Value constructor.
10339         * python/py-value.c (convert_buffer_and_type_to_value): New
10340         function.
10341         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10342         Add support for handling an optional second argument.  Call
10343         convert_buffer_and_type_to_value as appropriate.
10344         * python/python-internal.h (Py_buffer_deleter): New struct.
10345         (Py_buffer_up): New typedef.
10346
10347 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10348
10349         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10350         instead of releasing ownership.
10351
10352 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10353
10354         * dwarf2read.c (open_and_init_dwp_file): Call
10355         elf_numsections instead of bfd_count_sections to initialize
10356         dwp_file->num_sections.
10357
10358 2019-02-25  Tom Tromey  <tromey@adacore.com>
10359
10360         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10361
10362 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10363
10364         * gcore.in: Add '--readnever' option when invoking GDB.
10365
10366 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10367
10368         * MAINTAINERS: Update my email address.
10369
10370 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10371
10372         * build-id.c (build_id_to_debug_bfd_1): New function.
10373         (build_id_to_debug_bfd): Look for separate debug file in
10374         sysroot.
10375
10376 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * gdbarch.sh: Update the copyright year range that is placed into
10379         generated files.
10380
10381 2019-02-22  Keith Seitz  <keiths@redhat.com>
10382
10383         PR symtab/23853
10384         * linespec.c (create_sals_line_offset): Search for the default
10385         symtab's filename instead of its fullname.
10386
10387 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10388
10389         * NEWS: Update style defaults.
10390
10391 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10392
10393         * main.c (captured_main_1): Disable styling in batch mode.
10394
10395 2019-02-20  Tom Tromey  <tom@tromey.com>
10396
10397         * symtab.c (symtab_symbol_info): Fix typos.
10398
10399 2019-02-20  Tom Tromey  <tromey@adacore.com>
10400
10401         * findcmd.c (_initialize_mem_search): Use upper case for
10402         metasyntactic variables.
10403
10404 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10405
10406         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10407         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10408
10409 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10410
10411         * top.h (source_file_name): Change to std::string.
10412         * top.c (source_file_name): Likewise.
10413         (command_line_input): Adjust.
10414         * cli/cli-script.c (script_from_file): Adjust.
10415
10416 2019-02-19  Tom Tromey  <tromey@adacore.com>
10417
10418         * ravenscar-thread.c
10419         (ravenscar_thread_target::update_thread_list): Don't call
10420         ada_build_task_list.
10421         * ada-lang.h (ada_build_task_list): Don't declare.
10422         * ada-tasks.c (struct ada_tasks_inferior_data)
10423         <task_list_valid_p>: Now bool.
10424         (read_known_tasks, ada_task_list_changed)
10425         (ada_tasks_invalidate_inferior_data): Update.
10426         (read_known_tasks_array): Return bool.
10427         (read_known_tasks_list): Likewise.
10428         (read_known_tasks): Return void.
10429         (ada_build_task_list): Now static.
10430
10431 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10432
10433         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10434         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10435
10436 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10437
10438         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10439         variant for ada_tasks_pspace_data_handle and
10440         ada_tasks_inferior_data_handle.
10441         (ada_tasks_pspace_data_cleanup): New function.
10442         (ada_tasks_inferior_data_cleanup): New function.
10443
10444 2019-02-17  Tom Tromey  <tom@tromey.com>
10445
10446         * macrotab.h (macro_source_fullname): Return a std::string.
10447         * macrotab.c (macro_include, check_for_redefinition)
10448         (macro_undef, macro_lookup_definition, foreach_macro)
10449         (foreach_macro_in_scope): Update.
10450         (macro_source_fullname): Return a std::string.
10451         * macrocmd.c (show_pp_source_pos): Update.
10452
10453 2019-02-17  Tom Tromey  <tom@tromey.com>
10454
10455         * macrocmd.c (show_pp_source_pos): Style the file names.
10456
10457 2019-02-17  Tom Tromey  <tom@tromey.com>
10458
10459         PR tui/24197:
10460         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10461
10462 2019-02-17  Tom Tromey  <tom@tromey.com>
10463
10464         * ada-lang.c (user_select_syms): Use filtered printing.
10465         * utils.c (wrap_style): New global.
10466         (desired_style): Remove.
10467         (emit_style_escape): Add stream parameter.
10468         (set_output_style, reset_terminal_style, prompt_for_continue):
10469         Update.
10470         (flush_wrap_buffer): Only flush gdb_stdout.
10471         (wrap_here): Set wrap_style.
10472         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10473         treat escape sequences as a character.  Change when wrap buffer is
10474         flushed.
10475         (fputs_styled): Do not set the output style when the default is
10476         requested.
10477         * ui-style.h (struct ui_file_style) <is_default>: New method.
10478         * source.c (print_source_lines_base): Emit escape sequences in one
10479         piece.
10480
10481 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10482
10483         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10484         integers and enumeration types.
10485
10486 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10487
10488         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10489         instead of lookup_symbol_in_language
10490         (do_exact_match): New function.
10491         (ada_get_symbol_name_matcher): Return do_exact_match when
10492         doing a verbatim match.
10493
10494 2019-02-15  Tom Tromey  <tromey@adacore.com>
10495
10496         * ravenscar-thread.c (ravenscar_thread_target::resume)
10497         (ravenscar_thread_target::wait): Special case wildcard requests.
10498
10499 2019-02-15  Tom Tromey  <tromey@adacore.com>
10500
10501         * ravenscar-thread.c (base_ptid): Remove.
10502         (struct ravenscar_thread_target) <close>: New method.
10503         <m_base_ptid>: New member.
10504         <update_inferior_ptid, active_task, task_is_currently_active,
10505         runtime_initialized>: Declare methods.
10506         <ravenscar_thread_target>: Add constructor.
10507         (ravenscar_thread_target::task_is_currently_active)
10508         (ravenscar_thread_target::update_inferior_ptid)
10509         (ravenscar_runtime_initialized): Rename.  Now methods.
10510         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10511         (ravenscar_thread_target::update_thread_list): Update.
10512         (ravenscar_thread_target::active_task): Now method.
10513         (ravenscar_thread_target::store_registers)
10514         (ravenscar_thread_target::prepare_to_store)
10515         (ravenscar_thread_target::prepare_to_store)
10516         (ravenscar_thread_target::mourn_inferior): Update.
10517         (ravenscar_inferior_created): Use "new" to create target.
10518         (ravenscar_thread_target::get_ada_task_ptid): Update.
10519         (_initialize_ravenscar): Don't initialize base_ptid.
10520         (ravenscar_ops): Remove global.
10521
10522 2019-02-15  Tom Tromey  <tromey@adacore.com>
10523
10524         * target.h (push_target): Declare new overload.
10525         * target.c (push_target): New overload, taking an rvalue reference.
10526         * remote.c (remote_target::open_1): Use push_target overload.
10527         * corelow.c (core_target_open): Use push_target overload.
10528
10529 2019-02-15  Tom Tromey  <tromey@adacore.com>
10530
10531         * ravenscar-thread.c (is_ravenscar_task)
10532         (ravenscar_task_is_currently_active): Return bool.
10533         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10534         (_initialize_ravenscar): Remove "(void)".
10535         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10536         Return bool.
10537
10538 2019-02-15  Tom Tromey  <tromey@adacore.com>
10539
10540         * ravenscar-thread.c (ravenscar_runtime_initializer)
10541         (has_ravenscar_runtime, get_running_thread_id)
10542         (ravenscar_thread_target::resume): Fix indentation.
10543
10544 2019-02-15  Tom Tromey  <tromey@adacore.com>
10545
10546         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10547         from ravenscar_arch_ops.
10548         (sparc_ravenscar_ops::fetch_registers)
10549         (sparc_ravenscar_ops::store_registers): Now methods.
10550         (sparc_ravenscar_prepare_to_store): Remove.
10551         (sparc_ravenscar_ops): Redefine.
10552         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10553         methods and destructor.  Remove members.
10554         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10555         (ravenscar_thread_target::store_registers)
10556         (ravenscar_thread_target::prepare_to_store): Update.
10557         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10558         Remove.
10559         (struct ppc_ravenscar_powerpc_ops): Derive from
10560         ravenscar_arch_ops.
10561         (ppc_ravenscar_powerpc_ops::fetch_registers)
10562         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10563         (ppc_ravenscar_powerpc_ops): Redefine.
10564         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10565         (ppc_ravenscar_e500_ops::fetch_registers)
10566         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10567         (ppc_ravenscar_e500_ops): Redefine.
10568         * aarch64-ravenscar-thread.c
10569         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10570         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10571         (aarch64_ravenscar_fetch_registers)
10572         (aarch64_ravenscar_store_registers): Now methods.
10573         (aarch64_ravenscar_ops): Redefine.
10574
10575 2019-02-15  Tom Tromey  <tromey@adacore.com>
10576
10577         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10578         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10579         (ravenscar_thread_target::stopped_by_watchpoint)
10580         (ravenscar_thread_target::stopped_data_address)
10581         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10582
10583 2019-02-15  Tom Tromey  <tromey@adacore.com>
10584
10585         * ravenscar-thread.c: Fix some typos.
10586
10587 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10588             Tom Tromey  <tromey@adacore.com>
10589
10590         * ada-lang.c (ada_exception_sal): Change addr_string to a
10591         std::string.
10592         (create_ada_exception_catchpoint): Update.
10593
10594 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10595             Tom Tromey  <tromey@adacore.com>
10596
10597         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10598         (bp_location_ops): Remove.
10599         (base_breakpoint_allocate_location): Update.
10600         (free_bp_location): Update.
10601         * ada-lang.c (class ada_catchpoint_location)
10602         <ada_catchpoint_location>: Remove ops parameter.
10603         (ada_catchpoint_location_dtor): Remove.
10604         (ada_catchpoint_location_ops): Remove.
10605         (allocate_location_exception): Update.
10606         * breakpoint.h (struct bp_location_ops): Remove.
10607         (class bp_location) <bp_location>: Remove bp_location_ops
10608         parameter.
10609         <~bp_location>: Add destructor.
10610         <ops>: Remove.
10611
10612 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10613             Pedro Alves  <palves@redhat.com>
10614
10615         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10616         'PATH_MAX'.
10617
10618 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10619             Samuel Thibault  <samuel.thibault@gnu.org>
10620             Thomas Schwinge  <thomas@codesourcery.com>
10621
10622         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10623         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10624
10625 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10626
10627         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10628         (check_empty): Use "const char *".
10629
10630         * gnu-nat.c (gnu_nat_target::detach): Instead of
10631         'detach_inferior (pid)' call
10632         'detach_inferior (find_inferior_pid (pid))'.
10633
10634         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10635         'nat/fork-inferior.o'.
10636         * gnu-nat.c: #include "nat/fork-inferior.h".
10637
10638         * gnu-nat.c (gnu_nat_target::detach): Instead of
10639         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10640         * gnu-nat.h: #include "inf-child.h".
10641         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10642         'i386_gnu_nat_target::fetch_registers'.
10643         (gnu_store_registers): Rename/move to
10644         'i386_gnu_nat_target::store_registers'.
10645
10646         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10647         * gnu-nat.h (mach_thread_info): New function.
10648         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10649
10650         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10651
10652 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10653
10654         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10655
10656 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10657
10658         * windows-nat.c (windows_add_thread): Add new parameter
10659         "main_thread_p" with default value set to false.  Update
10660         function documentation as well as all callers.
10661         (windows_delete_thread): Likewise.
10662         (fake_create_process): Update call to windows_add_thread.
10663         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10664         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10665         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10666         call to windows_delete_thread.
10667
10668 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10669
10670         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10671
10672 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10673
10674         * symfile.c (find_separate_debug_file): Use canonical path of
10675         sysroot with child_path instead of gdb_sysroot if it is valid.
10676
10677 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10678
10679         * symfile.c (find_separate_debug_file): Use child_path to
10680         determine if an object file is under a sysroot.
10681
10682 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10683
10684         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10685         unittests/child-path-selftests.c.
10686         * common/pathstuff.c (child_path): New function.
10687         * common/pathstuff.h (child_path): New prototype.
10688         * unittests/child-path-selftests.c: New file.
10689
10690 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10691
10692         * symfile.c (find_separate_debug_file): Look for separate debug
10693         files in debug directories under the sysroot.
10694
10695 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10696
10697         * symtab.h (struct minimal_symbol data_p): New const method.
10698         (struct minimal_symbol text_p): Likewise.
10699         * symtab.c (output_source_filename): Use file name style
10700         to print file name.
10701         (print_symbol_info): Likewise.
10702         (print_msymbol_info): Use address style to print addresses.
10703         Use function name style to print executable text symbols.
10704         (expand_symtab_containing_pc): Use data_p.
10705         (find_pc_sect_compunit_symtab): Likewise.
10706
10707 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10708
10709         * breakpoint.c (describe_other_breakpoints): Use address style
10710         to print addresses.
10711         (say_where): Likewise.
10712
10713 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10714
10715         * ada-typeprint.c (print_func_type): Print function name
10716         style to print function name.
10717         * c-typeprint.c (c_print_type_1): Likewise.
10718
10719 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10720
10721         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10722         for execve.
10723
10724 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10725
10726         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10727         type_stack.
10728
10729 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10730
10731         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10732         TYPE_CODE_REF types.
10733
10734 2019-02-08  Jim Wilson  <jimw@sifive.com>
10735
10736         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10737         (riscv_linux_fregset): New.
10738         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10739
10740 2019-02-07  Tom Tromey  <tom@tromey.com>
10741
10742         * thread.c (thread_cancel_execution_command): Update.
10743         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10744         methods.
10745         (struct thread_fsm_ops): Remove.
10746         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10747         (thread_fsm_should_stop, thread_fsm_return_value)
10748         (thread_fsm_set_finished, thread_fsm_finished_p)
10749         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10750         Don't declare.
10751         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10752         * infrun.c (clear_proceed_status_thread)
10753         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10754         (print_stop_event): Update.
10755         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10756         Add constructor.
10757         (step_command_fsm_ops): Remove.
10758         (new_step_command_fsm): Remove.
10759         (step_1): Update.
10760         (step_command_fsm::should_stop): Rename from
10761         step_command_fsm_should_stop.
10762         (step_command_fsm::clean_up): Rename from
10763         step_command_fsm_clean_up.
10764         (step_command_fsm::do_async_reply_reason): Rename from
10765         step_command_fsm_async_reply_reason.
10766         (struct until_next_fsm): Inherit from thread_fsm.  Add
10767         constructor.
10768         (until_next_fsm_ops): Remove.
10769         (new_until_next_fsm): Remove.
10770         (until_next_fsm::should_stop): Rename from
10771         until_next_fsm_should_stop.
10772         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10773         (until_next_fsm::do_async_reply_reason): Rename from
10774         until_next_fsm_async_reply_reason.
10775         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10776         constructor.  Change type of breakpoint.
10777         (finish_command_fsm_ops): Remove.
10778         (new_finish_command_fsm): Remove.
10779         (finish_command_fsm::should_stop): Rename from
10780         finish_command_fsm_should_stop.
10781         (finish_command_fsm::clean_up): Rename from
10782         finish_command_fsm_clean_up.
10783         (finish_command_fsm::return_value): Rename from
10784         finish_command_fsm_return_value.
10785         (finish_command_fsm::do_async_reply_reason): Rename from
10786         finish_command_fsm_async_reply_reason.
10787         (finish_command): Update.
10788         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10789         Add constructor.
10790         (call_thread_fsm_ops): Remove.
10791         (call_thread_fsm::call_thread_fsm): Rename from
10792         new_call_thread_fsm.
10793         (call_thread_fsm::should_stop): Rename from
10794         call_thread_fsm_should_stop.
10795         (call_thread_fsm::should_notify_stop): Rename from
10796         call_thread_fsm_should_notify_stop.
10797         (run_inferior_call, call_function_by_hand_dummy): Update.
10798         * cli/cli-interp.c (should_print_stop_to_console): Update.
10799         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10800         Add constructor.  Change type of location_breakpoint,
10801         caller_breakpoint.
10802         (until_break_fsm_ops): Remove.
10803         (new_until_break_fsm): Remove.
10804         (until_break_fsm::should_stop): Rename from
10805         until_break_fsm_should_stop.
10806         (until_break_fsm::clean_up): Rename from
10807         until_break_fsm_clean_up.
10808         (until_break_fsm::do_async_reply_reason): Rename from
10809         until_break_fsm_async_reply_reason.
10810         (until_break_command): Update.
10811         * thread-fsm.c: Remove.
10812         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10813
10814 2019-02-07  Tom Tromey  <tom@tromey.com>
10815
10816         * yy-remap.h: Add include guard.
10817         * xtensa-tdep.h: Add include guard.
10818         * xcoffread.h: Rename include guard.
10819         * varobj-iter.h: Add include guard.
10820         * tui/tui.h: Rename include guard.
10821         * tui/tui-winsource.h: Rename include guard.
10822         * tui/tui-wingeneral.h: Rename include guard.
10823         * tui/tui-windata.h: Rename include guard.
10824         * tui/tui-win.h: Rename include guard.
10825         * tui/tui-stack.h: Rename include guard.
10826         * tui/tui-source.h: Rename include guard.
10827         * tui/tui-regs.h: Rename include guard.
10828         * tui/tui-out.h: Rename include guard.
10829         * tui/tui-layout.h: Rename include guard.
10830         * tui/tui-io.h: Rename include guard.
10831         * tui/tui-hooks.h: Rename include guard.
10832         * tui/tui-file.h: Rename include guard.
10833         * tui/tui-disasm.h: Rename include guard.
10834         * tui/tui-data.h: Rename include guard.
10835         * tui/tui-command.h: Rename include guard.
10836         * tic6x-tdep.h: Add include guard.
10837         * target/waitstatus.h: Rename include guard.
10838         * target/wait.h: Rename include guard.
10839         * target/target.h: Rename include guard.
10840         * target/resume.h: Rename include guard.
10841         * target-float.h: Rename include guard.
10842         * stabsread.h: Add include guard.
10843         * rs6000-tdep.h: Add include guard.
10844         * riscv-fbsd-tdep.h: Add include guard.
10845         * regformats/regdef.h: Rename include guard.
10846         * record.h: Rename include guard.
10847         * python/python.h: Rename include guard.
10848         * python/python-internal.h: Rename include guard.
10849         * python/py-stopevent.h: Rename include guard.
10850         * python/py-ref.h: Rename include guard.
10851         * python/py-record.h: Rename include guard.
10852         * python/py-record-full.h: Rename include guard.
10853         * python/py-record-btrace.h: Rename include guard.
10854         * python/py-instruction.h: Rename include guard.
10855         * python/py-events.h: Rename include guard.
10856         * python/py-event.h: Rename include guard.
10857         * procfs.h: Add include guard.
10858         * proc-utils.h: Add include guard.
10859         * p-lang.h: Add include guard.
10860         * or1k-tdep.h: Rename include guard.
10861         * observable.h: Rename include guard.
10862         * nto-tdep.h: Rename include guard.
10863         * nat/x86-linux.h: Rename include guard.
10864         * nat/x86-linux-dregs.h: Rename include guard.
10865         * nat/x86-gcc-cpuid.h: Add include guard.
10866         * nat/x86-dregs.h: Rename include guard.
10867         * nat/x86-cpuid.h: Rename include guard.
10868         * nat/ppc-linux.h: Rename include guard.
10869         * nat/mips-linux-watch.h: Rename include guard.
10870         * nat/linux-waitpid.h: Rename include guard.
10871         * nat/linux-ptrace.h: Rename include guard.
10872         * nat/linux-procfs.h: Rename include guard.
10873         * nat/linux-osdata.h: Rename include guard.
10874         * nat/linux-nat.h: Rename include guard.
10875         * nat/linux-namespaces.h: Rename include guard.
10876         * nat/linux-btrace.h: Rename include guard.
10877         * nat/glibc_thread_db.h: Rename include guard.
10878         * nat/gdb_thread_db.h: Rename include guard.
10879         * nat/gdb_ptrace.h: Rename include guard.
10880         * nat/fork-inferior.h: Rename include guard.
10881         * nat/amd64-linux-siginfo.h: Rename include guard.
10882         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10883         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10884         * nat/aarch64-linux.h: Rename include guard.
10885         * nat/aarch64-linux-hw-point.h: Rename include guard.
10886         * mn10300-tdep.h: Add include guard.
10887         * mips-linux-tdep.h: Add include guard.
10888         * mi/mi-parse.h: Rename include guard.
10889         * mi/mi-out.h: Rename include guard.
10890         * mi/mi-main.h: Rename include guard.
10891         * mi/mi-interp.h: Rename include guard.
10892         * mi/mi-getopt.h: Rename include guard.
10893         * mi/mi-console.h: Rename include guard.
10894         * mi/mi-common.h: Rename include guard.
10895         * mi/mi-cmds.h: Rename include guard.
10896         * mi/mi-cmd-break.h: Rename include guard.
10897         * m2-lang.h: Add include guard.
10898         * location.h: Rename include guard.
10899         * linux-record.h: Rename include guard.
10900         * linux-nat.h: Add include guard.
10901         * linux-fork.h: Add include guard.
10902         * i386-darwin-tdep.h: Rename include guard.
10903         * hppa-linux-offsets.h: Add include guard.
10904         * guile/guile.h: Rename include guard.
10905         * guile/guile-internal.h: Rename include guard.
10906         * gnu-nat.h: Rename include guard.
10907         * gdb-stabs.h: Rename include guard.
10908         * frv-tdep.h: Add include guard.
10909         * f-lang.h: Add include guard.
10910         * event-loop.h: Add include guard.
10911         * darwin-nat.h: Rename include guard.
10912         * cp-abi.h: Rename include guard.
10913         * config/sparc/nm-sol2.h: Rename include guard.
10914         * config/nm-nto.h: Rename include guard.
10915         * config/nm-linux.h: Add include guard.
10916         * config/i386/nm-i386gnu.h: Rename include guard.
10917         * config/djgpp/nl_types.h: Rename include guard.
10918         * config/djgpp/langinfo.h: Rename include guard.
10919         * compile/gcc-cp-plugin.h: Add include guard.
10920         * compile/gcc-c-plugin.h: Add include guard.
10921         * compile/compile.h: Rename include guard.
10922         * compile/compile-object-run.h: Rename include guard.
10923         * compile/compile-object-load.h: Rename include guard.
10924         * compile/compile-internal.h: Rename include guard.
10925         * compile/compile-cplus.h: Rename include guard.
10926         * compile/compile-c.h: Rename include guard.
10927         * common/xml-utils.h: Rename include guard.
10928         * common/x86-xstate.h: Rename include guard.
10929         * common/version.h: Rename include guard.
10930         * common/vec.h: Rename include guard.
10931         * common/tdesc.h: Rename include guard.
10932         * common/selftest.h: Rename include guard.
10933         * common/scoped_restore.h: Rename include guard.
10934         * common/scoped_mmap.h: Rename include guard.
10935         * common/scoped_fd.h: Rename include guard.
10936         * common/safe-iterator.h: Rename include guard.
10937         * common/run-time-clock.h: Rename include guard.
10938         * common/refcounted-object.h: Rename include guard.
10939         * common/queue.h: Rename include guard.
10940         * common/ptid.h: Rename include guard.
10941         * common/print-utils.h: Rename include guard.
10942         * common/preprocessor.h: Rename include guard.
10943         * common/pathstuff.h: Rename include guard.
10944         * common/observable.h: Rename include guard.
10945         * common/netstuff.h: Rename include guard.
10946         * common/job-control.h: Rename include guard.
10947         * common/host-defs.h: Rename include guard.
10948         * common/gdb_wait.h: Rename include guard.
10949         * common/gdb_vecs.h: Rename include guard.
10950         * common/gdb_unlinker.h: Rename include guard.
10951         * common/gdb_unique_ptr.h: Rename include guard.
10952         * common/gdb_tilde_expand.h: Rename include guard.
10953         * common/gdb_sys_time.h: Rename include guard.
10954         * common/gdb_string_view.h: Rename include guard.
10955         * common/gdb_splay_tree.h: Rename include guard.
10956         * common/gdb_setjmp.h: Rename include guard.
10957         * common/gdb_ref_ptr.h: Rename include guard.
10958         * common/gdb_optional.h: Rename include guard.
10959         * common/gdb_locale.h: Rename include guard.
10960         * common/gdb_assert.h: Rename include guard.
10961         * common/filtered-iterator.h: Rename include guard.
10962         * common/filestuff.h: Rename include guard.
10963         * common/fileio.h: Rename include guard.
10964         * common/environ.h: Rename include guard.
10965         * common/common-utils.h: Rename include guard.
10966         * common/common-types.h: Rename include guard.
10967         * common/common-regcache.h: Rename include guard.
10968         * common/common-inferior.h: Rename include guard.
10969         * common/common-gdbthread.h: Rename include guard.
10970         * common/common-exceptions.h: Rename include guard.
10971         * common/common-defs.h: Rename include guard.
10972         * common/common-debug.h: Rename include guard.
10973         * common/cleanups.h: Rename include guard.
10974         * common/buffer.h: Rename include guard.
10975         * common/btrace-common.h: Rename include guard.
10976         * common/break-common.h: Rename include guard.
10977         * cli/cli-utils.h: Rename include guard.
10978         * cli/cli-style.h: Rename include guard.
10979         * cli/cli-setshow.h: Rename include guard.
10980         * cli/cli-script.h: Rename include guard.
10981         * cli/cli-interp.h: Rename include guard.
10982         * cli/cli-decode.h: Rename include guard.
10983         * cli/cli-cmds.h: Rename include guard.
10984         * charset-list.h: Add include guard.
10985         * buildsym-legacy.h: Rename include guard.
10986         * bfin-tdep.h: Add include guard.
10987         * ax.h: Rename include guard.
10988         * arm-linux-tdep.h: Add include guard.
10989         * arm-fbsd-tdep.h: Add include guard.
10990         * arch/xtensa.h: Rename include guard.
10991         * arch/tic6x.h: Add include guard.
10992         * arch/i386.h: Add include guard.
10993         * arch/arm.h: Rename include guard.
10994         * arch/arm-linux.h: Rename include guard.
10995         * arch/arm-get-next-pcs.h: Rename include guard.
10996         * arch/amd64.h: Add include guard.
10997         * arch/aarch64-insn.h: Rename include guard.
10998         * arch-utils.h: Rename include guard.
10999         * annotate.h: Add include guard.
11000         * amd64-darwin-tdep.h: Rename include guard.
11001         * aarch64-linux-tdep.h: Add include guard.
11002         * aarch64-fbsd-tdep.h: Add include guard.
11003         * aarch32-linux-nat.h: Add include guard.
11004
11005 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11006
11007         * macrotab.c (macro_define_internal): New function that
11008         factorizes macro_define_object_internal and macro_define_function
11009         code.
11010         (macro_define_object_internal): Use macro_define_internal.
11011         (macro_define_function): Likewise.
11012
11013 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11014
11015         * macrocmd.c (extract_identifier): Return
11016         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11017         callers.
11018
11019 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11020
11021         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11022
11023 2019-02-05  Tom Tromey  <tom@tromey.com>
11024
11025         * target.c (target_stack::unpush): Move assertion earlier.
11026
11027 2019-01-30  Tom Tromey  <tom@tromey.com>
11028
11029         PR python/23615:
11030         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11031         (gdbpy_parse_and_eval): Likewise.
11032         * python/python-internal.h (gdbpy_allow_threads): New class.
11033
11034 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11035
11036         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11037         (aarch64_fbsd_fpregmap): Move earlier.
11038         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11039         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11040         instead of individual calls to trad_frame_set_reg_addr.
11041         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11042         earlier.
11043         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11044         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11045         instead of individual calls to trad_frame_set_reg_addr.
11046
11047 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11048
11049         * CONTRIBUTE: Replace contribution list with wiki link.
11050
11051 2019-01-25  Tom Tromey  <tom@tromey.com>
11052
11053         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11054
11055 2019-01-25  Tom Tromey  <tom@tromey.com>
11056
11057         * xtensa-linux-nat.c: Fix common/ includes.
11058         * xml-support.h: Fix common/ includes.
11059         * xml-support.c: Fix common/ includes.
11060         * x86-linux-nat.c: Fix common/ includes.
11061         * windows-nat.c: Fix common/ includes.
11062         * varobj.h: Fix common/ includes.
11063         * varobj.c: Fix common/ includes.
11064         * value.c: Fix common/ includes.
11065         * valops.c: Fix common/ includes.
11066         * utils.c: Fix common/ includes.
11067         * unittests/xml-utils-selftests.c: Fix common/ includes.
11068         * unittests/utils-selftests.c: Fix common/ includes.
11069         * unittests/unpack-selftests.c: Fix common/ includes.
11070         * unittests/tracepoint-selftests.c: Fix common/ includes.
11071         * unittests/style-selftests.c: Fix common/ includes.
11072         * unittests/string_view-selftests.c: Fix common/ includes.
11073         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11074         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11075         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11076         * unittests/rsp-low-selftests.c: Fix common/ includes.
11077         * unittests/parse-connection-spec-selftests.c: Fix common/
11078         includes.
11079         * unittests/optional-selftests.c: Fix common/ includes.
11080         * unittests/offset-type-selftests.c: Fix common/ includes.
11081         * unittests/observable-selftests.c: Fix common/ includes.
11082         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11083         * unittests/memrange-selftests.c: Fix common/ includes.
11084         * unittests/memory-map-selftests.c: Fix common/ includes.
11085         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11086         * unittests/function-view-selftests.c: Fix common/ includes.
11087         * unittests/environ-selftests.c: Fix common/ includes.
11088         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11089         * unittests/common-utils-selftests.c: Fix common/ includes.
11090         * unittests/cli-utils-selftests.c: Fix common/ includes.
11091         * unittests/array-view-selftests.c: Fix common/ includes.
11092         * ui-file.c: Fix common/ includes.
11093         * tui/tui-io.c: Fix common/ includes.
11094         * tracepoint.h: Fix common/ includes.
11095         * tracepoint.c: Fix common/ includes.
11096         * tracefile-tfile.c: Fix common/ includes.
11097         * top.h: Fix common/ includes.
11098         * top.c: Fix common/ includes.
11099         * thread.c: Fix common/ includes.
11100         * target/waitstatus.h: Fix common/ includes.
11101         * target/waitstatus.c: Fix common/ includes.
11102         * target.h: Fix common/ includes.
11103         * target.c: Fix common/ includes.
11104         * target-memory.c: Fix common/ includes.
11105         * target-descriptions.c: Fix common/ includes.
11106         * symtab.h: Fix common/ includes.
11107         * symfile.c: Fix common/ includes.
11108         * stap-probe.c: Fix common/ includes.
11109         * spu-linux-nat.c: Fix common/ includes.
11110         * sparc-nat.c: Fix common/ includes.
11111         * source.c: Fix common/ includes.
11112         * solib.c: Fix common/ includes.
11113         * solib-target.c: Fix common/ includes.
11114         * ser-unix.c: Fix common/ includes.
11115         * ser-tcp.c: Fix common/ includes.
11116         * ser-pipe.c: Fix common/ includes.
11117         * ser-base.c: Fix common/ includes.
11118         * selftest-arch.c: Fix common/ includes.
11119         * s12z-tdep.c: Fix common/ includes.
11120         * rust-exp.y: Fix common/ includes.
11121         * rs6000-aix-tdep.c: Fix common/ includes.
11122         * riscv-tdep.c: Fix common/ includes.
11123         * remote.c: Fix common/ includes.
11124         * remote-notif.h: Fix common/ includes.
11125         * remote-fileio.h: Fix common/ includes.
11126         * remote-fileio.c: Fix common/ includes.
11127         * regcache.h: Fix common/ includes.
11128         * regcache.c: Fix common/ includes.
11129         * record-btrace.c: Fix common/ includes.
11130         * python/python.c: Fix common/ includes.
11131         * python/py-type.c: Fix common/ includes.
11132         * python/py-inferior.c: Fix common/ includes.
11133         * progspace.h: Fix common/ includes.
11134         * producer.c: Fix common/ includes.
11135         * procfs.c: Fix common/ includes.
11136         * proc-api.c: Fix common/ includes.
11137         * printcmd.c: Fix common/ includes.
11138         * ppc-linux-nat.c: Fix common/ includes.
11139         * parser-defs.h: Fix common/ includes.
11140         * osdata.c: Fix common/ includes.
11141         * obsd-nat.c: Fix common/ includes.
11142         * nat/x86-linux.c: Fix common/ includes.
11143         * nat/x86-linux-dregs.c: Fix common/ includes.
11144         * nat/x86-dregs.h: Fix common/ includes.
11145         * nat/x86-dregs.c: Fix common/ includes.
11146         * nat/ppc-linux.c: Fix common/ includes.
11147         * nat/mips-linux-watch.h: Fix common/ includes.
11148         * nat/mips-linux-watch.c: Fix common/ includes.
11149         * nat/linux-waitpid.c: Fix common/ includes.
11150         * nat/linux-ptrace.h: Fix common/ includes.
11151         * nat/linux-ptrace.c: Fix common/ includes.
11152         * nat/linux-procfs.c: Fix common/ includes.
11153         * nat/linux-personality.c: Fix common/ includes.
11154         * nat/linux-osdata.c: Fix common/ includes.
11155         * nat/linux-namespaces.c: Fix common/ includes.
11156         * nat/linux-btrace.h: Fix common/ includes.
11157         * nat/linux-btrace.c: Fix common/ includes.
11158         * nat/fork-inferior.c: Fix common/ includes.
11159         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11160         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11161         * nat/aarch64-linux.c: Fix common/ includes.
11162         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11163         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11164         * namespace.h: Fix common/ includes.
11165         * mips-linux-tdep.c: Fix common/ includes.
11166         * minsyms.c: Fix common/ includes.
11167         * mi/mi-parse.h: Fix common/ includes.
11168         * mi/mi-main.c: Fix common/ includes.
11169         * mi/mi-cmd-env.c: Fix common/ includes.
11170         * memrange.h: Fix common/ includes.
11171         * memattr.c: Fix common/ includes.
11172         * maint.h: Fix common/ includes.
11173         * maint.c: Fix common/ includes.
11174         * main.c: Fix common/ includes.
11175         * machoread.c: Fix common/ includes.
11176         * location.c: Fix common/ includes.
11177         * linux-thread-db.c: Fix common/ includes.
11178         * linux-nat.c: Fix common/ includes.
11179         * linux-fork.c: Fix common/ includes.
11180         * inline-frame.c: Fix common/ includes.
11181         * infrun.c: Fix common/ includes.
11182         * inflow.c: Fix common/ includes.
11183         * inferior.h: Fix common/ includes.
11184         * inferior.c: Fix common/ includes.
11185         * infcmd.c: Fix common/ includes.
11186         * inf-ptrace.c: Fix common/ includes.
11187         * inf-child.c: Fix common/ includes.
11188         * ia64-linux-nat.c: Fix common/ includes.
11189         * i387-tdep.c: Fix common/ includes.
11190         * i386-tdep.c: Fix common/ includes.
11191         * i386-linux-tdep.c: Fix common/ includes.
11192         * i386-linux-nat.c: Fix common/ includes.
11193         * i386-go32-tdep.c: Fix common/ includes.
11194         * i386-fbsd-tdep.c: Fix common/ includes.
11195         * i386-fbsd-nat.c: Fix common/ includes.
11196         * guile/scm-type.c: Fix common/ includes.
11197         * guile/guile.c: Fix common/ includes.
11198         * go32-nat.c: Fix common/ includes.
11199         * gnu-nat.c: Fix common/ includes.
11200         * gdbthread.h: Fix common/ includes.
11201         * gdbarch-selftests.c: Fix common/ includes.
11202         * gdb_usleep.c: Fix common/ includes.
11203         * gdb_select.h: Fix common/ includes.
11204         * gdb_bfd.c: Fix common/ includes.
11205         * gcore.c: Fix common/ includes.
11206         * fork-child.c: Fix common/ includes.
11207         * findvar.c: Fix common/ includes.
11208         * fbsd-nat.c: Fix common/ includes.
11209         * event-top.c: Fix common/ includes.
11210         * event-loop.c: Fix common/ includes.
11211         * dwarf2read.c: Fix common/ includes.
11212         * dwarf2loc.c: Fix common/ includes.
11213         * dwarf2-frame.c: Fix common/ includes.
11214         * dwarf-index-cache.c: Fix common/ includes.
11215         * dtrace-probe.c: Fix common/ includes.
11216         * disasm-selftests.c: Fix common/ includes.
11217         * defs.h: Fix common/ includes.
11218         * csky-tdep.c: Fix common/ includes.
11219         * cp-valprint.c: Fix common/ includes.
11220         * cp-support.h: Fix common/ includes.
11221         * cp-support.c: Fix common/ includes.
11222         * corelow.c: Fix common/ includes.
11223         * completer.h: Fix common/ includes.
11224         * completer.c: Fix common/ includes.
11225         * compile/compile.c: Fix common/ includes.
11226         * compile/compile-loc2c.c: Fix common/ includes.
11227         * compile/compile-cplus-types.c: Fix common/ includes.
11228         * compile/compile-cplus-symbols.c: Fix common/ includes.
11229         * command.h: Fix common/ includes.
11230         * cli/cli-dump.c: Fix common/ includes.
11231         * cli/cli-cmds.c: Fix common/ includes.
11232         * charset.c: Fix common/ includes.
11233         * build-id.c: Fix common/ includes.
11234         * btrace.h: Fix common/ includes.
11235         * btrace.c: Fix common/ includes.
11236         * breakpoint.h: Fix common/ includes.
11237         * breakpoint.c: Fix common/ includes.
11238         * ax.h:
11239         (enum agent_op): Fix common/ includes.
11240         * ax-general.c (struct aop_map): Fix common/ includes.
11241         * ax-gdb.c: Fix common/ includes.
11242         * auxv.c: Fix common/ includes.
11243         * auto-load.c: Fix common/ includes.
11244         * arm-tdep.c: Fix common/ includes.
11245         * arch/riscv.c: Fix common/ includes.
11246         * arch/ppc-linux-common.c: Fix common/ includes.
11247         * arch/i386.c: Fix common/ includes.
11248         * arch/arm.c: Fix common/ includes.
11249         * arch/arm-linux.c: Fix common/ includes.
11250         * arch/arm-get-next-pcs.c: Fix common/ includes.
11251         * arch/amd64.c: Fix common/ includes.
11252         * arch/aarch64.c: Fix common/ includes.
11253         * arch/aarch64-insn.c: Fix common/ includes.
11254         * arch-utils.c: Fix common/ includes.
11255         * amd64-windows-tdep.c: Fix common/ includes.
11256         * amd64-tdep.c: Fix common/ includes.
11257         * amd64-sol2-tdep.c: Fix common/ includes.
11258         * amd64-obsd-tdep.c: Fix common/ includes.
11259         * amd64-nbsd-tdep.c: Fix common/ includes.
11260         * amd64-linux-tdep.c: Fix common/ includes.
11261         * amd64-linux-nat.c: Fix common/ includes.
11262         * amd64-fbsd-tdep.c: Fix common/ includes.
11263         * amd64-fbsd-nat.c: Fix common/ includes.
11264         * amd64-dicos-tdep.c: Fix common/ includes.
11265         * amd64-darwin-tdep.c: Fix common/ includes.
11266         * agent.c: Fix common/ includes.
11267         * ada-lang.h: Fix common/ includes.
11268         * ada-lang.c: Fix common/ includes.
11269         * aarch64-tdep.c: Fix common/ includes.
11270
11271 2019-01-25  Tom Tromey  <tom@tromey.com>
11272
11273         * common/create-version.sh: Use common/version.h.
11274
11275 2019-01-24  Pedro Alves  <palves@redhat.com>
11276
11277         * infrun.c (signal_stop, signal_print, signal_program)
11278         (signal_catch, signal_pass): Now arrays instead of pointers.
11279         (update_signals_program_target, do_target_resume)
11280         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11281         * linux-nat.c (linux_nat_target::pass_signals)
11282         (linux_nat_target::create_inferior, linux_nat_target::attach):
11283         Adjust.
11284         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11285         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11286         * procfs.c (procfs_target::pass_signals): Adjust.
11287         * record-full.c (record_full_target::resume): Adjust.
11288         * remote.c (remote_target::pass_signals)
11289         (remote_target::program_signals): Adjust.
11290         * target-debug.h (target_debug_print_signals): Now takes a
11291         gdb::array_view as parameter.  Adjust.
11292         * target.h (target_ops) <pass_signals, program_signals>: Replace
11293         pointer and length parameters with gdb::array_view.
11294         (target_pass_signals, target_program_signals): Likewise.
11295         * target-delegates.c: Regenerate.
11296
11297 2019-01-24  Pedro Alves  <palves@redhat.com>
11298
11299         * common/forward-scope-exit.h
11300         (forward_scope_exit::forward_scope_exit): Pass arguments to
11301         m_bind_function directly, instead of creating a std::bind and
11302         copying that.
11303
11304 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11305
11306         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11307         for static members.
11308         (pass_in_v_vfp_candidate): Likewise.
11309
11310 2019-01-23  Tom Tromey  <tom@tromey.com>
11311             Pedro Alves  <palves@redhat.com>
11312
11313         * regcache.c (class regcache_invalidator): Remove.
11314         (regcache::raw_write): Use make_scope_exit.
11315
11316 2019-01-23  Tom Tromey  <tom@tromey.com>
11317
11318         * ui-out.h (class ui_out_emit_type): Update comment.
11319
11320 2019-01-23  Tom Tromey  <tom@tromey.com>
11321
11322         * infrun.c (fetch_inferior_event): Update comment.
11323
11324 2019-01-23  Tom Tromey  <tom@tromey.com>
11325             Pedro Alves  <palves@redhat.com>
11326
11327         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11328         parameter.
11329         (fetch_inferior_event): Use SCOPE_EXIT.
11330
11331
11332 2019-01-23  Tom Tromey  <tom@tromey.com>
11333             Pedro Alves  <palves@redhat.com>
11334
11335         * infrun.c (disable_thread_events): Delete.
11336         (stop_all_threads): Use SCOPE_EXIT.
11337
11338 2019-01-23  Tom Tromey  <tom@tromey.com>
11339             Pedro Alves  <palves@redhat.com>
11340
11341         * symfile.c: Include forward-scope-exit.h.
11342         (clear_symtab_users_cleanup): Replace forward declaration with
11343         a FORWARD_SCOPE_EXIT.
11344         (syms_from_objfile_1): Use the forward_scope_exit and
11345         gdb::optional instead of cleanup_function.
11346         (reread_symbols): Use the forward_scope_exit instead of
11347         cleanup_function.
11348         (clear_symtab_users_cleanup): Remove function.
11349
11350 2019-01-23  Tom Tromey  <tom@tromey.com>
11351             Pedro Alves  <palves@redhat.com>
11352
11353         * linux-nat.c: Include scope-exit.h.
11354         (cleanup_target_stop): Remove.
11355         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11356         SCOPE_EXIT.
11357
11358 2019-01-23  Tom Tromey  <tom@tromey.com>
11359             Pedro Alves  <palves@redhat.com>
11360
11361         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11362         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11363
11364 2019-01-23  Tom Tromey  <tom@tromey.com>
11365             Andrew Burgess  <andrew.burgess@embecosm.com>
11366             Pedro Alves  <palves@redhat.com>
11367
11368         * infrun.c (fetch_inferior_event): Use scope_exit.
11369         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11370         * top.c (execute_command): Use scope_exit.
11371         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11372         * utils.c (do_bpstat_clear_actions_cleanup)
11373         (make_bpstat_clear_actions_cleanup): Remove.
11374
11375 2019-01-23  Tom Tromey  <tom@tromey.com>
11376             Pedro Alves  <palves@redhat.com>
11377
11378         * infrun.c: Include "common/scope-exit.h"
11379         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11380         (wait_for_inferior): Use SCOPE_EXIT.
11381         (fetch_inferior_event): Use scope_exit.
11382
11383 2019-01-23  Tom Tromey  <tom@tromey.com>
11384             Pedro Alves  <palves@redhat.com>
11385
11386         * breakpoint.c (create_breakpoint): Remove cleanup.
11387
11388 2019-01-23  Tom Tromey  <tom@tromey.com>
11389             Andrew Burgess  <andrew.burgess@embecosm.com>
11390             Pedro Alves  <palves@redhat.com>
11391
11392 2019-01-23  Pedro Alves  <palves@redhat.com>
11393
11394         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11395
11396 2019-01-23  Pedro Alves  <palves@redhat.com>
11397             Andrew Burgess  <andrew.burgess@embecosm.com>
11398
11399         * gdbthread.h: Include "common/forward-scope-exit.h".
11400         (scoped_finish_thread_state): Redefine custom class in terms of
11401         forward_scope_exit.
11402
11403 2019-01-23  Pedro Alves  <palves@redhat.com>
11404             Andrew Burgess  <andrew.burgess@embecosm.com>
11405
11406         * common/forward-scope-exit.h: New file.
11407
11408 2019-01-23  Pedro Alves  <palves@redhat.com>
11409             Andrew Burgess  <andrew.burgess@embecosm.com>
11410             Tom Tromey  <tom@tromey.com>
11411
11412         * common/scope-exit.h: New file.
11413
11414 2019-01-23  Pedro Alves  <palves@redhat.com>
11415
11416         * common/preprocessor.h (ESC): Rename to ...
11417         (ESC_PARENS): ... this.
11418         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11419         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11420
11421 2019-01-23  Tom Tromey  <tom@tromey.com>
11422
11423         * language.h (class scoped_switch_to_sym_language_if_auto):
11424         Initialize m_lang in both cases.
11425
11426 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11427
11428         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11429         with XCNEW.
11430
11431 2019-01-22  Tom Tromey  <tom@tromey.com>
11432
11433         * corelow.c: Do not include sys/file.h.
11434
11435 2019-01-22  Tom Tromey  <tom@tromey.com>
11436
11437         * tui/tui-wingeneral.h: Include gdb_curses.h.
11438
11439 2019-01-22  Tom Tromey  <tom@tromey.com>
11440
11441         * source-cache.h (class source_cache) <get_source_lines,
11442         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11443
11444 2019-01-22  Tom Tromey  <tom@tromey.com>
11445
11446         * remote-fileio.h (struct remote_target): Declare.
11447
11448 2019-01-22  Tom Tromey  <tom@tromey.com>
11449
11450         * python/py-arch.c: Do not include py-ref.h.
11451         * python/py-bpevent.c: Do not include py-ref.h.
11452         * python/py-cmd.c: Do not include py-ref.h.
11453         * python/py-continueevent.c: Do not include py-ref.h.
11454         * python/py-event.h: Do not include py-ref.h.
11455         * python/py-evtregistry.c: Do not include py-ref.h.
11456         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11457         * python/py-frame.c: Do not include py-ref.h.
11458         * python/py-framefilter.c: Do not include py-ref.h.
11459         * python/py-function.c: Do not include py-ref.h.
11460         * python/py-infevents.c: Do not include py-ref.h.
11461         * python/py-linetable.c: Do not include py-ref.h.
11462         * python/py-objfile.c: Do not include py-ref.h.
11463         * python/py-param.c: Do not include py-ref.h.
11464         * python/py-prettyprint.c: Do not include py-ref.h.
11465         * python/py-progspace.c: Do not include py-ref.h.
11466         * python/py-symbol.c: Do not include py-ref.h.
11467         * python/py-symtab.c: Do not include py-ref.h.
11468         * python/py-type.c: Do not include py-ref.h.
11469         * python/py-unwind.c: Do not include py-ref.h.
11470         * python/py-utils.c: Do not include py-ref.h.
11471         * python/py-value.c: Do not include py-ref.h.
11472         * python/py-varobj.c: Do not include py-ref.h.
11473         * python/py-xmethods.c: Do not include py-ref.h.
11474         * python/python.c: Do not include py-ref.h.
11475         * varobj.c: Do not include py-ref.h.
11476
11477 2019-01-22  Tom Tromey  <tom@tromey.com>
11478
11479         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11480         keyword for bcache.
11481
11482 2019-01-22  Tom Tromey  <tom@tromey.com>
11483
11484         * compile/compile-cplus-types.c: Remove a comment by #include.
11485
11486 2019-01-22  Tom Tromey  <tom@tromey.com>
11487
11488         * compile/gcc-c-plugin.h: Include compile-internal.h.
11489
11490 2019-01-22  Tom Tromey  <tom@tromey.com>
11491
11492         * stabsread.c (EXTERN): Do not define.
11493         (symnum, next_symbol_text_func, processing_gcc_compilation)
11494         (within_function, global_sym_chain, global_stabs)
11495         (previous_stab_code, this_object_header_files)
11496         (n_this_object_header_files)
11497         (n_allocated_this_object_header_files): Define.
11498         * stabsread.h (EXTERN): Never define.  Use "extern".
11499
11500 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11501
11502         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11503         history_value.
11504
11505 2019-01-21  Tom Tromey  <tom@tromey.com>
11506
11507         * ui-out.c: Fix includes.
11508         * tui/tui-source.c: Fix includes.
11509         * target.c: Fix includes.
11510         * remote.c: Fix includes.
11511         * regcache.c: Fix includes.
11512         * python/py-block.c: Fix includes.
11513         * printcmd.c: Fix includes.
11514         * or1k-tdep.c: Fix includes.
11515         * mi/mi-main.c: Fix includes.
11516         * m32r-tdep.c: Fix includes.
11517         * csky-tdep.c: Fix includes.
11518         * compile/compile-cplus-types.c: Fix includes.
11519         * cli/cli-interp.c: Fix includes.
11520
11521 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11522
11523         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11524         for padding.
11525
11526 2019-01-16  Tom Tromey  <tom@tromey.com>
11527
11528         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11529         earlier.
11530         (struct objfile) <msymbols_range>: Move from top level.
11531         <msymbols>: New method.
11532         (class objfile_msymbols): Remove.
11533         * symtab.c (default_collect_symbol_completion_matches_break_on):
11534         Update.
11535         * symmisc.c (dump_msymbols): Update.
11536         * stabsread.c (scan_file_globals): Update.
11537         * objc-lang.c (info_selectors_command, info_classes_command)
11538         (find_methods): Update.
11539         * minsyms.c (find_solib_trampoline_target): Update.
11540         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11541         * coffread.c (coff_symfile_read): Update.
11542         * ada-lang.c (ada_lookup_simple_minsym)
11543         (ada_collect_symbol_completion_matches): Update.
11544
11545 2019-01-16  Tom Tromey  <tom@tromey.com>
11546
11547         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11548         type.  Remove no-argument constructor.
11549         <iterator::operator++>: Simplify.
11550         <begin>: Update.
11551         <end>: Use minimal_symbol_count.
11552
11553 2019-01-16  Tom Tromey  <tom@tromey.com>
11554
11555         * objfiles.h (struct objfile) <psymtabs>: New method.
11556         (class objfile_psymtabs): Remove.
11557         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11558         typedef.
11559         <range>: New method.
11560         (require_partial_symbols): Change return type.
11561         * psymtab.c (require_partial_symbols)
11562         (psym_expand_symtabs_matching): Update.
11563         * mdebugread.c (parse_partial_symbols): Update.
11564         * dbxread.c (dbx_end_psymtab): Update.
11565
11566 2019-01-15  Tom Tromey  <tom@tromey.com>
11567
11568         * symtab.c (lookup_objfile_from_block)
11569         (lookup_symbol_in_objfile_symtabs)
11570         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11571         (find_line_symtab, info_sources_command)
11572         (default_collect_symbol_completion_matches_break_on)
11573         (make_source_files_completion_list): Update.
11574         * symmisc.c (print_objfile_statistics, dump_objfile)
11575         (maintenance_print_symbols, maintenance_info_symtabs)
11576         (maintenance_check_symtabs, maintenance_info_line_tables):
11577         Update.
11578         * source.c (select_source_symtab)
11579         (forget_cached_source_info_for_objfile): Update.
11580         * objfiles.h (class objfile_compunits): Remove.
11581         (struct objfile) <compunits_range>: New typedef.
11582         (compunits): New method.
11583         * objfiles.c (objfile_relocate1): Update.
11584         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11585         * maint.c (count_symtabs_and_blocks): Update.
11586         * linespec.c (iterate_over_all_matching_symtabs): Update.
11587         * cp-support.c (add_symbol_overload_list_qualified): Update.
11588         * coffread.c (coff_symtab_read): Update.
11589         * ada-lang.c (add_nonlocal_symbols)
11590         (ada_collect_symbol_completion_matches)
11591         (ada_add_global_exceptions): Update.
11592
11593 2019-01-15  Tom Tromey  <tom@tromey.com>
11594
11595         * progspace.h (program_space) <objfiles_safe_range>: New
11596         typedef.
11597         <objfiles_safe>: New method.
11598         * objfiles.h (class all_objfiles_safe): Remove.
11599         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11600         * jit.c (jit_inferior_exit_hook): Update.
11601
11602 2019-01-17  Tom Tromey  <tom@tromey.com>
11603
11604         * progspace.h (program_space) <objfiles_range>: New typedef.
11605         <objfiles>: New method.
11606         <objfiles_head>: Rename from objfiles.
11607         (object_files): Update.
11608         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11609         * guile/scm-pretty-print.c
11610         (ppscm_find_pretty_printer_from_objfiles): Update.
11611         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11612         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11613         Update.
11614         * python/py-progspace.c (pspy_get_objfiles): Update.
11615         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11616         Update.
11617         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11618         (objfpy_lookup_objfile_by_build_id): Update.
11619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11621         Update.
11622         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11623         (expand_symtab_containing_pc, lookup_objfile_from_block)
11624         (lookup_static_symbol, basic_lookup_transparent_type)
11625         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11626         (find_line_symtab, info_sources_command)
11627         (default_collect_symbol_completion_matches_break_on)
11628         (make_source_files_completion_list, find_main_name): Update.
11629         * symmisc.c (print_symbol_bcache_statistics)
11630         (print_objfile_statistics, maintenance_print_symbols)
11631         (maintenance_print_msymbols, maintenance_print_objfiles)
11632         (maintenance_info_symtabs, maintenance_check_symtabs)
11633         (maintenance_expand_symtabs, maintenance_info_line_tables):
11634         Update.
11635         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11636         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11637         (map_overlay_command, unmap_overlay_command)
11638         (simple_overlay_update, expand_symtabs_matching)
11639         (map_symbol_filenames): Update.
11640         * symfile-debug.c (set_debug_symfile): Update.
11641         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11642         Update.
11643         * source.c (select_source_symtab, forget_cached_source_info):
11644         Update.
11645         * solib.c (solib_read_symbols): Update.
11646         * solib-spu.c (append_ocl_sos): Update.
11647         * psymtab.c (maintenance_print_psymbols)
11648         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11649         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11650         * printcmd.c (info_symbol_command): Update.
11651         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11652         Update.
11653         * objfiles.h (class all_objfiles): Remove.
11654         * objfiles.c (have_partial_symbols, have_full_symbols)
11655         (have_minimal_symbols, qsort_cmp, update_section_map)
11656         (shared_objfile_contains_address_p)
11657         (default_iterate_over_objfiles_in_search_order): Update.
11658         * objc-lang.c (info_selectors_command, info_classes_command)
11659         (find_methods): Update.
11660         * minsyms.c (find_solib_trampoline_target): Update.
11661         * maint.c (maintenance_info_sections)
11662         (maintenance_translate_address, count_symtabs_and_blocks):
11663         Update.
11664         * main.c (captured_main_1): Update.
11665         * linux-thread-db.c (try_thread_db_load_from_pdir)
11666         (has_libpthread): Update.
11667         * linespec.c (iterate_over_all_matching_symtabs)
11668         (search_minsyms_for_name): Update.
11669         * jit.c (jit_find_objf_with_entry_addr): Update.
11670         * hppa-tdep.c (find_unwind_entry)
11671         (hppa_lookup_stub_minimal_symbol): Update.
11672         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11673         Update.
11674         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11675         (elf_gnu_ifunc_resolve_by_got): Update.
11676         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11677         * dwarf-index-write.c (save_gdb_index_command): Update.
11678         * cp-support.c (add_symbol_overload_list_qualified): Update.
11679         * breakpoint.c (create_overlay_event_breakpoint)
11680         (create_longjmp_master_breakpoint)
11681         (create_std_terminate_master_breakpoint)
11682         (create_exception_master_breakpoint): Update.
11683         * blockframe.c (find_pc_partial_function): Update.
11684         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11685         (ada_collect_symbol_completion_matches)
11686         (ada_add_global_exceptions): Update.
11687
11688 2019-01-17  Tom Tromey  <tom@tromey.com>
11689
11690         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11691         declare VEC.
11692         (solib_target_parse_libraries): Change return type.
11693         (library_list_start_segment, library_list_start_section)
11694         (library_list_end_library, library_list_start_library); Update.
11695         (solib_target_free_library_list): Remove.
11696         (solib_target_parse_libraries): Remove cleanup.  Change return
11697         type.
11698         (solib_target_current_sos): Update.
11699
11700 2019-01-17  Tom Tromey  <tromey@bapiya>
11701
11702         * valprint.c: Replace "the the" with "the".
11703         * symtab.c: Replace "the the" with "the".
11704         * solib.c: Replace "the the" with "the".
11705         * solib-dsbt.c: Replace "the the" with "the".
11706         * linespec.c: Replace "the the" with "the".
11707         * dwarf2loc.h: Replace "the the" with "the".
11708         * amd64-windows-tdep.c: Replace "the the" with "the".
11709         * aarch64-tdep.c: Replace "the the" with "the".
11710
11711 2019-01-16  Keith Seitz  <keiths@redhat.com>
11712
11713         PR gdb/23773
11714         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11715         <builder>: Rename to ..
11716         <m_builder>: ... this and make private.
11717         (dwarf2_cu::get_builder): New method.  Change all users of
11718         `builder' to use this method.
11719         (dwarf2_start_symtab): Move to ...
11720         (dwarf2_cu::start_symtab): ... here.  Update all callers
11721         (setup_type_unit_groups): Move to ...
11722         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11723         callers.
11724         (dwarf2_cu::reset_builder): New method.
11725         (process_full_compunit, process_full_type_unit): Use
11726         dwarf2_cu::reset_builder.
11727         (follow_die_offset): Record the ancestor CU if it is different
11728         from the followed DIE's CU.
11729         (follow_die_sig_1): Likewise.
11730
11731 2019-01-15  Tom Tromey  <tom@tromey.com>
11732
11733         * remote.c (class remote_state) <buf>: Now a char_vector.
11734         <buf_size>: Remove.
11735         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11736         parameter.
11737         (remote_target::getpkt_or_notif_sane_1)
11738         (remote_target::getpkt_sane)
11739         (remote_target::getpkt_or_notif_sane): Likewise.
11740         (class remote_target) <putpkt>: New overload.
11741         (remote_target::read_frame): Change type of "buf_p".  Remove
11742         sizeof_p parameter.
11743         (packet_ok): New overload.
11744         (packet_check_result): New overload.
11745         Update all uses.
11746
11747 2019-01-14  Tom Tromey  <tom@tromey.com>
11748
11749         * remote-notif.c (handle_notification, remote_notif_ack)
11750         (remote_notif_parse): Make "buf" const.
11751         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11752         const.
11753         (remote_notif_parse, remote_notif_ack, handle_notification):
11754         Likewise.
11755         * remote.c (remote_notif_stop_parse): Make "buf" const.
11756         (remote_target::remote_parse_stop_reply): Make "buf" const.
11757         (remote_notif_stop_ack): Make "buf" const.
11758
11759 2019-01-14  Tom Tromey  <tom@tromey.com>
11760
11761         * remote.c (remote_console_output): Make parameter const.
11762
11763 2019-01-14  Tom Tromey  <tom@tromey.com>
11764
11765         * target-debug.h (target_debug_print_signals): Constify.
11766         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11767         * procfs.c (procfs_target::pass_signals): Update.
11768         * linux-nat.c (linux_nat_target::pass_signals): Update.
11769         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11770         * target-delegates.c: Rebuild.
11771         * remote.c (remote_target::program_signals): Update.
11772         (remote_target::pass_signals): Update.
11773         * target.c (target_pass_signals): Constify argument.
11774         (target_program_signals): Likewise.
11775         * target.h (struct target_ops) <pass_signals, program_signals>:
11776         Constify argument.
11777         (target_pass_signals, target_program_signals): Constify argument.
11778
11779 2019-01-14  Tom Tromey  <tom@tromey.com>
11780
11781         PR tui/28819:
11782         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11783
11784 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11785
11786         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11787         field.
11788         * rs6000-tdep.c: Include reggroups.h.
11789         (IS_V_ALIAS_PSEUDOREG): Define.
11790         (rs6000_register_name): Return names for the "vX" aliases.
11791         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11792         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11793         aliases.  Call default_register_reggroup_p for all other
11794         pseudo-registers.
11795         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11796         New functions.
11797         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11798         Handle "vX" aliases.
11799         (v_alias_pseudo_register_collect): New function.
11800         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11801         (rs6000_gdbarch_init): Initialize "vX" aliases as
11802         pseudo-registers.  Restore registration of
11803         rs6000_pseudo_register_reggroup_p with
11804         set_tdesc_pseudo_register_reggroup_p.
11805
11806 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11807
11808         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11809         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11810         set_gdbarch_num_pseudo_regs.
11811
11812 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11813
11814         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11815         Remove arg prefixname, add do_set and do_show.
11816         Add member functions set_list and show_list.
11817         * cli/cli-style.c (class cli_style_option): Update accordingly.
11818         (style_set_list): Move to file scope.
11819         (style_show_list): Likewise.
11820         (set_style): Call help_list.
11821         (show_style): Call cmd_show_list.
11822         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11823         Update to use the new macro.
11824
11825 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11826
11827         * ada-lang.c (_initialize_ada_language): Expand the help text
11828         for the "catch exception" command.
11829
11830 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11831
11832         * symtab.c (matching_obj_sections): Initialize obj,
11833         declare it closer to its usage.
11834
11835 2019-01-10  Tom Tromey  <tom@tromey.com>
11836
11837         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11838         (basic_inf_threads_range): Remove.
11839         (inf_threads_range, inf_non_exited_threads_range)
11840         (safe_inf_threads_range): Use next_adapter.
11841
11842 2019-01-10  Keith Seitz  <keiths@redhat.com>
11843
11844         PR gdb/23712
11845         PR symtab/23010
11846         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11847         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11848
11849 2019-01-10  Keith Seitz  <keiths@redhat.com>
11850
11851         PR gdb/23712
11852         PR symtab/23010
11853         * dictionary.c (pending_to_vector): Remove.
11854         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11855         Remove _1 suffix, replacing functions of the same name.  Update
11856         all callers.
11857         (dict_create_hashed, dict_create_hashed_expandable)
11858         (dict_create_linear, dict_create_linear_expandable, dict_free)
11859         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11860         Make functions static.
11861
11862 2019-01-10  Keith Seitz  <keiths@redhat.com>
11863
11864         PR gdb/23712
11865         PR symtab/23010
11866         * dictionary.h (struct dictionary): Replace declaration with
11867         multidictionary.
11868         (dict_create_hashed, dict_create_hashed_expandable)
11869         (dict_create_linear, dict_create_linear_expandable)
11870         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11871         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11872         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11873         taking multidictionary argument.
11874         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11875         * block.h (struct block) <dict>: Change to multidictionary
11876         and rename `multidict'.
11877         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11878         symmisc.c: Update all dictionary references to multidictionary.
11879
11880 2019-01-10  Keith Seitz  <keiths@redhat.com>
11881
11882         PR gdb/23712
11883         PR symtab/23010
11884         * dictionary.c: Include unordered_map.
11885         (pending_to_vector): New function.
11886         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11887         Rewrite the non-"_1" functions to take vector instead
11888         of linked list.
11889         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11890         "new" _1 versions of the same name.
11891         (multidictionary): Define.
11892         (std::hash<enum language): New definition.
11893         (collate_pending_symbols_by_language, mdict_create_hashed)
11894         (mdict_create_hashed_expandable, mdict_create_linear)
11895         (mdict_create_linear_expandable, mdict_free)
11896         (find_language_dictionary, create_new_language_dictionary)
11897         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11898         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11899         (mdict_size, mdict_empty): New functions.
11900         * dictionary.h (mdict_iterator): Define.
11901
11902 2019-01-10  Pedro Alves  <palves@redhat.com>
11903
11904         * breakpoint.c (read_uploaded_action)
11905         (create_tracepoint_from_upload): Adjust to use
11906         gdb::unique_xmalloc_ptr.
11907         * ctf.c (ctf_write_uploaded_tp):
11908         (SET_ARRAY_FIELD): Use emplace_back.
11909         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11910         * tracefile-tfile.c (tfile_write_uploaded_tp):
11911         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11912         gdb::unique_xmalloc_ptr.
11913         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11914         at_string, cond_string, cmd_strings>: Replace char pointers
11915         with gdb::unique_xmalloc_ptr.
11916
11917 2019-01-10  Pedro Alves  <palves@redhat.com>
11918
11919         * solib-target.c (library_list_start_library): Don't xstrdup name.
11920
11921 2019-01-10  Pedro Alves  <palves@redhat.com>
11922
11923         * mdebugread.c (parse_partial_symbols): Use
11924         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11925
11926 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11927
11928         * linux-fork.c (scoped_switch_fork_info)
11929         <~scoped_switch_fork_info>: Fix incorrect variable name.
11930
11931 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11932
11933         * linux-fork.c (scoped_switch_fork_info)
11934         <scoped_switch_fork_info>: Make explicit.
11935         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11936
11937 2019-01-10  Tom Tromey  <tom@tromey.com>
11938
11939         * objfiles.h (objfile::reset_psymtabs): Update.
11940         * objfiles.c (objfile::objfile): Update.
11941         * psymtab.h (psymtab_storage::obstack): Update.
11942         (psymtab_storage::m_obstack): Use gdb::optional.
11943         (class psymtab_storage): Update comment.  Remove objfile
11944         parameter.
11945         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11946
11947 2019-01-10  Tom Tromey  <tom@tromey.com>
11948
11949         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11950         <free_psymtabs>: Now private.
11951         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11952         (allocate_psymtab): Use new method.
11953
11954 2019-01-10  Tom Tromey  <tom@tromey.com>
11955
11956         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11957         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11958         * mdebugread.c (parse_partial_symbols): Use
11959         allocate_dependencies.
11960         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11961         allocate_dependencies.
11962         (process_psymtab_comp_unit_reader)
11963         (build_type_psymtab_dependencies): Likewise.
11964         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11965
11966 2019-01-10  Tom Tromey  <tom@tromey.com>
11967
11968         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11969         PSYMBOL_SET_LANGUAGE.
11970         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11971
11972 2019-01-10  Tom Tromey  <tom@tromey.com>
11973
11974         * psymtab.h (psymtab_storage::obstack): New method.
11975         <m_obstack>: Rename from obstack; now private.
11976         * psymtab.c (psymtab_storage): Update.
11977         * dwarf2read.c (create_addrmap_from_index)
11978         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11979         Update.
11980
11981 2019-01-10  Tom Tromey  <tom@tromey.com>
11982
11983         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11984         * objfiles.h (objfile::reset_psymtabs): New method.
11985
11986 2019-01-10  Tom Tromey  <tom@tromey.com>
11987
11988         * symmisc.c (print_symbol_bcache_statistics): Update.
11989         (print_objfile_statistics): Update.
11990         * symfile.c (reread_symbols): Update.
11991         * psymtab.h (class psymtab_storage): New.
11992         * psymtab.c (psymtab_storage): New constructor.
11993         (~psymtab_storage): New destructor.
11994         (require_partial_symbols): Update.
11995         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11996         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11997         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11998         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11999         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12000         (start_psymtab_common, end_psymtab_common)
12001         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12002         (allocate_psymtab): Update.
12003         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12004         Update.
12005         (dump_psymtab_addrmap, maintenance_print_psymbols)
12006         (maintenance_check_psymtabs): Update.
12007         (class objfile_psymtabs): Move to objfiles.h.
12008         * psympriv.h (discard_psymtab): Now inline.
12009         (psymtab_discarder::psymtab_discarder): Update.
12010         (psymtab_discarder::~psymtab_discarder): Update.
12011         (ALL_OBJFILE_PSYMTABS): Rewrite.
12012         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12013         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12014         Remove fields.
12015         <partial_symtabs>: New field.
12016         (class objfile_psymtabs): Move from psymtab.h.  Update.
12017         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12018         psymbol_cache.
12019         (objfile::~objfile): Don't destroy psymbol_cache.
12020         * mdebugread.c (parse_partial_symbols): Update.
12021         * dwarf2read.c (create_addrmap_from_index)
12022         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12023         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12024         (add_partial_subprogram, dwarf2_ranges_read): Update.
12025         * dwarf-index-write.c (write_address_map)
12026         (write_one_signatured_type, recursively_write_psymbols)
12027         (class debug_names, class debug_names, write_psymtabs_to_index):
12028         Update.
12029
12030 2019-01-10  Tom Tromey  <tom@tromey.com>
12031
12032         * symtab.h (SYMBOL_SET_NAMES): Update.
12033         (symbol_set_names): Update.
12034         (MSYMBOL_SET_NAMES): Update.
12035         * symtab.c (symbol_set_names): Change argument to be an
12036         objfile_per_bfd_storage.
12037         * psymtab.c (add_psymbol_to_bcache): Update.
12038         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12039
12040 2019-01-10  Tom Tromey  <tom@tromey.com>
12041
12042         * symtab.c (create_demangled_names_hash): Change argument to be an
12043         objfile_per_bfd_storage.
12044         (symbol_set_names): Update.
12045
12046 2019-01-10  Tom Tromey  <tom@tromey.com>
12047
12048         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12049         init_psymbol_list.
12050         * psymtab.c (init_psymbol_list): Do nothing if already called.
12051         * psympriv.h (init_psymbol_list): Add comment.
12052         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12053         init_psymbol_list.
12054         * dbxread.c (dbx_symfile_read): Unconditionally call
12055         init_psymbol_list.
12056
12057 2019-01-10  Tom Tromey  <tom@tromey.com>
12058
12059         * xcoffread.c (scan_xcoff_symtab): Update.
12060         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12061         "where".
12062         * mdebugread.c (parse_partial_symbols)
12063         (handle_psymbol_enumerators): Update.
12064         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12065         * dbxread.c (read_dbx_symtab): Update.
12066         * psympriv.h (psymbol_placement): New enum.
12067         (add_psymbol_to_list): Update.
12068
12069 2019-01-10  Tom Tromey  <tom@tromey.com>
12070
12071         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12072         static_psymbols parameters.
12073         (scan_xcoff_symtab): Update.
12074         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12075         static_psymbols parameters.
12076         * psympriv.h (start_psymtab_common): Update.
12077         * mdebugread.c (parse_partial_symbols): Update.
12078         * dwarf2read.c (create_partial_symtab): Update.
12079         * dbxread.c (read_dbx_symtab): Update.
12080         (start_psymtab): Remove global_psymbols and static_psymbols
12081         parameters.
12082
12083 2019-01-10  Tom Tromey  <tom@tromey.com>
12084
12085         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12086         * psymtab.c (allocate_psymtab): Add comment.
12087         * psympriv.h (allocate_psymtab): Add comment.
12088         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12089         initializations.
12090         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12091
12092 2019-01-10  Tom Tromey  <tom@tromey.com>
12093
12094         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12095         Don't declare.
12096         * mipsread.c: Include mdebugread.h.
12097         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12098         Declare.
12099         * elfread.c: Include mdebugread.h.
12100
12101 2019-01-09  Tom Tromey  <tom@tromey.com>
12102
12103         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12104         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12105         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12106         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12107         (psym_lookup_symbol, psym_find_last_source_symtab)
12108         (psym_forget_cached_source_info, psym_print_stats)
12109         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12110         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12111         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12112         (psym_find_compunit_symtab_by_address)
12113         (maintenance_print_psymbols, maintenance_info_psymtabs)
12114         (maintenance_check_psymtabs): Use ranged for.
12115         * psymtab.h (class objfile_psymtabs): New.
12116         (require_partial_symbols): Return objfile_psymtabs.
12117         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12118
12119 2019-01-09  Tom Tromey  <tom@tromey.com>
12120
12121         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12122         (find_pc_mapped_section, list_overlays_command)
12123         (map_overlay_command, unmap_overlay_command)
12124         (simple_overlay_update): Use all_objfiles.
12125         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12126         * printcmd.c (info_symbol_command): Use all_objfiles.
12127         * objfiles.h (ALL_OBJSECTIONS): Remove.
12128         * maint.c (maintenance_translate_address): Use all_objfiles.
12129         * gcore.c (gcore_create_callback): Use all_objfiles.
12130         (objfile_find_memory_regions): Likewise.
12131
12132 2019-01-09  Tom Tromey  <tom@tromey.com>
12133
12134         * symtab.c (find_line_symtab, info_sources_command)
12135         (make_source_files_completion_list): Use objfile_compunits.
12136         * source.c (select_source_symtab): Use objfile_compunits.
12137         * objfiles.h (struct objfile): Update comment.
12138         (ALL_OBJFILES): Remove.
12139         (ALL_FILETABS): Remove.
12140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12141         objfile_compunits.
12142
12143 2019-01-09  Tom Tromey  <tom@tromey.com>
12144
12145         * symmisc.c (print_objfile_statistics, dump_objfile)
12146         (maintenance_print_symbols): Use compunit_filetabs.
12147         * source.c (forget_cached_source_info_for_objfile): Use
12148         compunit_filetabs.
12149         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12150         (ALL_FILETABS): Use compunit_filetabs.
12151         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12152         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12153
12154 2019-01-09  Tom Tromey  <tom@tromey.com>
12155
12156         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12157         (compunit_filetabs): New.
12158         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12159         compunit_filetabs.
12160         (info_sources_command, make_source_files_completion_list): Remove
12161         declaration.
12162         * symmisc.c (print_objfile_statistics, dump_objfile)
12163         (maintenance_print_symbols): Remove declaration.
12164         (maintenance_info_symtabs): Use compunit_filetabs.
12165         (maintenance_info_line_tables): Likewise.
12166         * source.c (select_source_symtab): Change local variable name.
12167         (forget_cached_source_info_for_objfile): Remove declaration.
12168         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12169         * objfiles.c (objfile_relocate1): Remove declaration.
12170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12171         declaration.
12172         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12173         * coffread.c (coff_symtab_read): Remove declaration.
12174         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12175         compunit_filetabs.
12176
12177 2019-01-09  Tom Tromey  <tom@tromey.com>
12178
12179         * symtab.c (lookup_objfile_from_block)
12180         (find_pc_sect_compunit_symtab, search_symbols)
12181         (default_collect_symbol_completion_matches_break_on): Use
12182         objfile_compunits.
12183         * objfiles.h (ALL_COMPUNITS): Remove.
12184         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12185         * cp-support.c (add_symbol_overload_list_qualified): Use
12186         objfile_compunits.
12187         * ada-lang.c (ada_collect_symbol_completion_matches)
12188         (ada_add_global_exceptions): Use objfile_compunits.
12189
12190 2019-01-09  Tom Tromey  <tom@tromey.com>
12191
12192         * source.c (select_source_symtab)
12193         (forget_cached_source_info_for_objfile): Remove declaration.
12194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12195         declaration.
12196         * maint.c (count_symtabs_and_blocks): Remove declaration.
12197         * cp-support.c (add_symbol_overload_list_qualified): Remove
12198         declaration.
12199         * coffread.c (coff_symtab_read): Remove declaration.
12200         * symtab.c (lookup_symbol_in_objfile_symtabs)
12201         (basic_lookup_transparent_type_1): Use objfile_compunits.
12202         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12203         (info_sources_command, search_symbols)
12204         (default_collect_symbol_completion_matches_break_on)
12205         (make_source_files_completion_list): Remove declaration.
12206         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12207         (ada_collect_symbol_completion_matches)
12208         (ada_add_global_exceptions): Remove declaration.
12209         * linespec.c (iterate_over_all_matching_symtabs): Use
12210         objfile_compunits.
12211         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12212         (class objfile_compunits): New.
12213         (ALL_COMPUNITS): Use objfile_compunits.
12214         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12215         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12216         objfile_compunits.
12217         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12218
12219 2019-01-09  Tom Tromey  <tom@tromey.com>
12220
12221         * symtab.c (search_symbols)
12222         (default_collect_symbol_completion_matches_break_on): Use
12223         objfile_msymbols.
12224         * ada-lang.c (ada_lookup_simple_minsym)
12225         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12226         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12227         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12228         objfile_msymbols.
12229         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12230         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12231         * objc-lang.c (find_methods): Use objfile_msymbols.
12232         (info_selectors_command, info_classes_command): Likewise.
12233         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12234         * objfiles.h (class objfile_msymbols): New.
12235         (ALL_OBJFILE_MSYMBOLS): Remove.
12236         (ALL_MSYMBOLS): Remove.
12237
12238 2019-01-09  Tom Tromey  <tom@tromey.com>
12239
12240         * common/next-iterator.h (next_adapter): Add Iterator template
12241         parameter.
12242         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12243         (class all_objfiles_safe): New.
12244         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12245         * objfiles.c (put_objfile_before): Update comment.
12246         (add_separate_debug_objfile): Likewise.
12247         (free_all_objfiles): Use all_objfiles_safe.
12248         (objfile_purge_solibs): Likewise.
12249
12250 2019-01-09  Tom Tromey  <tom@tromey.com>
12251
12252         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12253         (expand_symtab_containing_pc, lookup_static_symbol)
12254         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12255         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12256         all_objfiles.
12257         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12258         * breakpoint.c (create_overlay_event_breakpoint)
12259         (create_longjmp_master_breakpoint)
12260         (create_std_terminate_master_breakpoint)
12261         (create_exception_master_breakpoint): Use all_objfiles.
12262         * linux-thread-db.c (try_thread_db_load_from_pdir)
12263         (has_libpthread): Use all_objfiles.
12264         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12265         * linespec.c (iterate_over_all_matching_symtabs)
12266         (search_minsyms_for_name): Use all_objfiles.
12267         * maint.c (maintenance_info_sections): Use all_objfiles.
12268         * main.c (captured_main_1): Use all_objfiles.
12269         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12270         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12271         * guile/scm-pretty-print.c
12272         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12273         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12274         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12275         (maintenance_print_msymbols): Use all_objfiles.
12276         * source.c (select_source_symtab): Use all_objfiles.
12277         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12278         * symfile.c (remove_symbol_file_command)
12279         (expand_symtabs_matching, map_symbol_filenames): Use
12280         all_objfiles.
12281         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12282         all_objfiles.
12283         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12284         * objc-lang.c (find_methods): Use all_objfiles.
12285         * objfiles.c (have_partial_symbols, have_full_symbols)
12286         (have_minimal_symbols, qsort_cmp)
12287         (default_iterate_over_objfiles_in_search_order): Use
12288         all_objfiles.
12289         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12290         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12291         (maintenance_check_psymtabs): Use all_objfiles.
12292         (ALL_PSYMTABS): Remove.
12293         * compile/compile-object-run.c (do_module_cleanup): Use
12294         all_objfiles.
12295         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12296         * cp-support.c (add_symbol_overload_list_qualified): Use
12297         all_objfiles.
12298         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12299         Use all_objfiles.
12300         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12301         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12302         all_objfiles.
12303         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12304         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12305         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12306         Uses all_objfiles.
12307         * solib.c (solib_read_symbols): Use all_objfiles
12308
12309 2019-01-09  Tom Tromey  <tom@tromey.com>
12310
12311         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12312         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12313         all_objfiles.
12314         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12315         * symmisc.c (print_symbol_bcache_statistics)
12316         (print_objfile_statistics, maintenance_print_objfiles)
12317         (maintenance_info_symtabs, maintenance_check_symtabs)
12318         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12319         all_objfiles.
12320         * source.c (forget_cached_source_info): Use all_objfiles.
12321         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12322         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12323         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12324         * objfiles.c (update_section_map): Use all_objfiles.
12325         (shared_objfile_contains_address_p): Likewise.
12326         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12327         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12328
12329 2019-01-09  Tom Tromey  <tom@tromey.com>
12330
12331         * common/next-iterator.h: New file.
12332         * objfiles.h (class all_objfiles): New.
12333         (struct objfile_iterator): New.
12334
12335 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12336
12337         * NEWS: Move the description of the changed "frame", "select-frame",
12338          and "info frame" commands to the Changed commands section.
12339
12340 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12341
12342         * gdbtypes.c (check_stub_method_group): Remove handling of old
12343         mangling schemes.
12344         * linespec.c (find_methods): Likewise.
12345         * stabsread.c (read_member_functions): Likewise.
12346         * valops.c (search_struct_method): Likewise.
12347         (value_struct_elt_for_reference): Likewise.
12348         * NEWS: Mention this change.
12349
12350 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12351
12352         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12353         print_source_lines.
12354         * source.c (print_source_lines_base): Update line number check.
12355         (print_source_lines): New function.
12356         (source_lines_range::source_lines_range): New function.
12357         * source.h (class source_lines_range): New class.
12358         (print_source_lines): New declaration.
12359
12360 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12361
12362         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12363
12364 2019-01-08  Tom Tromey  <tom@tromey.com>
12365             Simon Marchi  <simon.marchi@ericsson.com>
12366
12367         PR gdb/24060
12368         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12369         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12370         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12371         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12372         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12373         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12374
12375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12376
12377         * source.c (select_source_symtab): Move header comment to
12378         declaration in source.h.
12379         (forget_cached_source_info_for_objfile): Likewise.
12380         (forget_cached_source_info): Likewise.
12381         (identify_source_line): Likewise.
12382         * source.h (identify_source_line): Move declaration from symtab.h
12383         and add comment from source.c
12384         (print_source_lines): Likewise.
12385         (forget_cached_source_info_for_objfile): Likewise.
12386         (forget_cached_source_info): Likewise.
12387         (select_source_symtab): Likewise.
12388         (enum print_source_lines_flag): Move definition from symtab.h.
12389         * symtab.h (identify_source_line): Move declaration to source.h.
12390         (print_source_lines): Likewise.
12391         (forget_cached_source_info_for_objfile): Likewise.
12392         (forget_cached_source_info): Likewise.
12393         (select_source_symtab): Likewise.
12394         (enum print_source_lines_flag): Move definition to source.h.
12395         * tui/tui-hooks.c: Add 'source.h' include.
12396
12397 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12398
12399         * source.c (print_source_lines_base): Handle requests to print
12400         reverse line number sequences, and guard against empty lines
12401         string.
12402
12403 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12404
12405         * source.c (print_source_lines_base): Fix skip of '\r' if next
12406         character is '\n'.
12407
12408 2019-01-06  Tom Tromey  <tom@tromey.com>
12409
12410         * c-exp.y (struct c_parse_state) <macro_original_text,
12411         expansion_obstack>: New member.
12412         (macro_original_text, expansion_obstack): Remove globals.
12413         (scan_macro_expansion, scanning_macro_expansion)
12414         (finished_macro_expansion): Update.
12415         (scan_macro_cleanup): Remove.
12416         (yylex, c_parse): Update.
12417
12418 2019-01-06  Tom Tromey  <tom@tromey.com>
12419
12420         * c-exp.y (struct c_parse_state) <strings>: New member.
12421         (operator_stoken): Update.
12422
12423 2019-01-06  Tom Tromey  <tom@tromey.com>
12424
12425         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12426         (union type_stack_elt) <typelist_val>: Now a pointer to
12427         std::vector.
12428         (type_stack_cleanup): Don't declare.
12429         (push_typelist): Update.
12430         * parse.c (pop_typelist): Return a std::vector.
12431         (push_typelist): Take a std::vector.
12432         (follow_types): Update.  Do not free args.
12433         (type_stack_cleanup): Remove.
12434         * c-exp.y (struct c_parse_state): New.
12435         (cpstate): New global.
12436         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12437         (nonempty_typelist): Update.
12438         (func_mod): Create a new vector.
12439         (c_parse): Create a c_parse_state.
12440         (check_parameter_typelist): Do not delete params.
12441         (function_method): Update.  Do not delete type_list.
12442
12443 2019-01-06  Tom Tromey  <tom@tromey.com>
12444
12445         PR gdb/28155:
12446         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12447         check_typedef.
12448         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12449         (print_return_value): Likewise.
12450
12451 2019-01-05  Tom Tromey  <tom@tromey.com>
12452
12453         * contrib/cleanup_check.py: Remove.
12454         * contrib/gcc-with-excheck: Remove.
12455         * contrib/exsummary.py: Remove.
12456         * contrib/excheck.py: Remove.
12457
12458 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12459
12460         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12461         NULL. Initialize tpprev to NULL instead of assigning it
12462         to NULL on the next statement.
12463         * windows-nat.c (windows_delete_thread): Remove check for
12464         main_thread_id before printing thread exit notifications.
12465         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12466         Remove thread ID check against main_thread_id.
12467         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12468         windows_delete_thread.
12469         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12470
12471 2019-01-04  Tom Tromey  <tom@tromey.com>
12472
12473         * compile/compile.c (_initialize_compile): Use upper case for
12474         metasyntactic variables.
12475         * symmisc.c (_initialize_symmisc): Use upper case for
12476         metasyntactic variables.
12477         * psymtab.c (_initialize_psymtab): Use upper case for
12478         metasyntactic variables.
12479         * demangle.c (demangle_command): Use upper case for metasyntactic
12480         variables.
12481         (_initialize_demangler): Likewise.
12482         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12483         variables.
12484
12485 2019-01-03  Tom Tromey  <tom@tromey.com>
12486
12487         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12488
12489 2019-01-03  Tom Tromey  <tom@tromey.com>
12490
12491         * python/py-symtab.c (salpy_str): Update.
12492         (struct salpy_sal_object) <symtab>: Now a PyObject.
12493         (salpy_dealloc): Update.
12494         (del_objfile_sal): Use gdbpy_ref.
12495
12496 2019-01-03  Tom Tromey  <tom@tromey.com>
12497
12498         * python/py-type.c (convert_field): Use new_reference.  Return
12499         gdbpy_ref.
12500         (make_fielditem): Return gdbpy_ref.
12501         (typy_fields): Update.
12502         (typy_getitem): Update.
12503         (field_name): Return gdbpy_ref.  Use new_reference.
12504         (typy_iterator_iternext): Update.
12505
12506 2019-01-03  Tom Tromey  <tom@tromey.com>
12507
12508         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12509
12510 2019-01-03  Tom Tromey  <tom@tromey.com>
12511
12512         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12513         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12514         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12515         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12516         (pspy_set_type_printers): Likewise.
12517         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12518         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12519         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12520         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12521         (objfpy_set_type_printers): Likewise.
12522
12523 2019-01-03  Tom Tromey  <tom@tromey.com>
12524
12525         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12526         (gdbpy_print_stack): Use gdbpy_err_fetch.
12527         * python/python-internal.h (class gdbpy_err_fetch): New class.
12528         (class gdbpy_enter) <m_error_type, m_error_value,
12529         m_error_traceback>: Remove.
12530         <m_error>: New member.
12531         (gdbpy_exception_to_string): Don't declare.
12532         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12533         * python/py-value.c (convert_value_from_python): Use
12534         gdbpy_err_fetch.
12535         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12536         gdbpy_exception_to_string.
12537         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12538         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12539         gdbpy_err_fetch.
12540
12541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12542
12543         * linux-nat.c (delete_lwp_cleanup): Delete.
12544         (struct lwp_deleter): New struct.
12545         (lwp_info_up): New typedef.
12546         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12547         lwp_info_up.
12548
12549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12550
12551         * linux-fork.c (class scoped_switch_fork_info): New class.
12552         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12553
12554 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12555
12556         * valops.c (find_overload_match): Remove use of null_cleanup, and
12557         calls to do_cleanups.
12558
12559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12560
12561         * compile/compile-cplus-types.c
12562         (compile_cplus_instance::decl_name): Handle changes to
12563         cp_func_name.
12564         * cp-support.c (cp_func_name): Update header comment, update
12565         return type.
12566         * cp-support.h (cp_func_name): Update return type in declaration.
12567         * valops.c (find_overload_match): Move temp_func local to top
12568         level of function and change its type.  Use temp_func to hold and
12569         delete temporary string obtained from cp_func_name.
12570
12571 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12572
12573         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12574         gdb::char_vector, remove cleanup, and update uses of `msg`.
12575
12576 2019-01-03  Jim Wilson  <jimw@sifive.com>
12577
12578         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12579
12580 2019-01-02  Tom Tromey  <tom@tromey.com>
12581
12582         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12583         (tdesc_parse_xml): Remove cleanups.
12584         * target-descriptions.h (make_cleanup_free_target_description):
12585         Don't declare.
12586         (target_desc_deleter): New struct.
12587         (target_desc_up): New typedef.
12588         * target-descriptions.c (target_desc_deleter::operator()): Rename
12589         from free_target_description.
12590         (make_cleanup_free_target_description): Remove.
12591
12592 2019-01-02  Tom Tromey  <tom@tromey.com>
12593
12594         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12595         constructor, destructor.
12596         (linespec_parser): Remove typedef.
12597         (~linespec_parser): Rename from linespec_parser_delete.
12598         (linespec_lex_to_end, linespec_complete_label)
12599         (linespec_complete): Update.
12600         (decode_line_full): Remove cleanups.
12601         (decode_line_1): Update.
12602
12603 2019-01-02  Tom Tromey  <tom@tromey.com>
12604
12605         * python/python-internal.h (inferior_to_inferior_object): Change
12606         return type.
12607         * python/py-exitedevent.c (create_exited_event_object): Update.
12608         * python/py-inferior.c (inferior_to_inferior_object): Return
12609         gdbpy_ref.
12610         (python_new_inferior, python_inferior_deleted)
12611         (thread_to_thread_object, delete_thread_object)
12612         (build_inferior_list, gdbpy_selected_inferior): Update.
12613         * python/py-infthread.c (create_thread_object): Update.  Also fail
12614         if inferior_to_inferior_object fails.
12615
12616 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12617
12618         * inferior.h (class inferior) <displaced_step_state>: New field.
12619         * infrun.h (struct displaced_step_state): Move here from
12620         infrun.c.  Initialize fields, add constructor.
12621         <inf>: Remove field.
12622         <reset>: New method.
12623         * infrun.c (struct displaced_step_inferior_state): Move to
12624         infrun.h.
12625         (displaced_step_inferior_states): Remove.
12626         (get_displaced_stepping_state): Adust.
12627         (displaced_step_in_progress_any_inferior): Adjust.
12628         (displaced_step_in_progress_thread): Adjust.
12629         (displaced_step_in_progress): Adjust.
12630         (add_displaced_stepping_state): Remove.
12631         (get_displaced_step_closure_by_addr): Adjust.
12632         (remove_displaced_stepping_state): Remove.
12633         (infrun_inferior_exit): Call displaced_step_state.reset.
12634         (use_displaced_stepping): Don't check for NULL.
12635         (displaced_step_prepare_throw): Call
12636         get_displaced_stepping_state.
12637         (displaced_step_fixup): Don't check for NULL.
12638         (prepare_for_detach): Don't check for NULL.
12639
12640 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12641
12642         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12643          in case of call that did not complete.
12644
12645 2019-01-02  Andrey Utkin  <autkin@undo.io>
12646
12647         * symfile.c (find_separate_debug_file): Fix search of debug files for
12648         remote debuggee.
12649
12650 2019-01-02  Tom Tromey  <tom@tromey.com>
12651
12652         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12653         indentation.
12654         * python/py-frame.c (frapy_older): Remove cast.
12655         (frapy_newer): Likewise.
12656         * python/py-breakpoint.c (local_setattro): Remove cast.
12657         * python/py-arch.c (archpy_name): Remove local variable.
12658         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12659
12660 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12661
12662         * unittests/basic_string_view/element_access/char/empty.cc:
12663         Fix year range in copyright header.
12664
12665 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12666
12667         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12668         Delete.
12669         <operator==>: Update with for removed field.
12670         <hash>: Likewise.
12671         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12672         <isa_features>: ...this.
12673         <abi_features>: New field.
12674         (riscv_isa_flen): Update comment.
12675         (riscv_abi_xlen): New declaration.
12676         (riscv_abi_flen): New declaration.
12677         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12678         isa_features.
12679         (riscv_abi_xlen): New function.
12680         (riscv_isa_flen): Update to get answer from isa_features.
12681         (riscv_abi_flen): New function.
12682         (riscv_has_fp_abi): Update to get answer from abi_features.
12683         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12684         xlen and flen.
12685         (riscv_call_info) <xlen, flen>: Update comment.
12686         (riscv_call_arg_struct): Remove invalid assertions
12687         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12688         is removed.
12689         (riscv_gdbarch_init): Gather isa features and abi features
12690         separately, ensure both match on the gdbarch when reusing an old
12691         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12692         a target with 64-bit float hardware.
12693
12694 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12695
12696         * source.c (search_command_helper): Stop reverse search
12697         when line 1 has been searched.
12698
12699 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12700
12701         * record-full.c (record_full_base_target::close): Rewrite
12702         record_full_core_buf_list free logic.
12703
12704 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12705
12706         * break-catch-syscall.c (print_one_catch_syscall): xfree
12707         the last text.
12708
12709 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12710
12711         * top.c (print_gdb_version): Update Copyright year in version
12712         message.
12713
12714 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12715
12716         Update copyright year range in all GDB files.
12717
12718 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12719
12720         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12721
12722 For older changes see ChangeLog-2018.
12723 \f
12724 Local Variables:
12725 mode: change-log
12726 left-margin: 8
12727 fill-column: 74
12728 version-control: never
12729 coding: utf-8
12730 End:
12731