gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_source_window_base::set_new_height)
   4         (tui_data_window::set_new_height): New methods.
   5         (make_invisible_and_set_new_height): Call set_new_height method.
   6         * tui/tui-data.h (struct tui_win_info)
   7         (struct tui_source_window_base, struct tui_data_window)
   8         <set_new_height>: New method.
   9
  10 2019-06-25  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
  13         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
  14         tui_refresh_data_win.
  15         * tui/tui-win.c (tui_source_window_base::refresh_all): New
  16         method.
  17         (tui_refresh_all_win): Call the refresh_all method.
  18         (tui_set_focus): Likewise.
  19         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
  20         (struct tui_source_window_base, struct tui_data_window) <refresh>:
  21         Likewise.
  22
  23 2019-06-25  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-winsource.h (tui_refill_source_window)
  26         (tui_set_is_exec_point_at): Don't declare.
  27         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  28         (tui_source_window_base::refill): Rename from
  29         tui_refill_source_window.
  30         (tui_source_window_base::do_scroll_horizontal): Update.
  31         (tui_source_window_base::set_is_exec_point_at): Rename from
  32         tui_set_is_exec_point_at.
  33         (tui_update_all_breakpoint_info): Update.
  34         * tui/tui-stack.c (tui_show_frame_info): Update.
  35         * tui/tui-layout.c (show_data): Add cast.
  36         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  37         * tui/tui-data.h (struct tui_source_window_base) <refill,
  38         set_is_exec_point_at>: New methods.
  39         (tui_source_windows, tui_add_to_source_windows): Update types.
  40         (tui_add_to_source_windows): Remove redundant declaration.
  41         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  42         (tui_source_windows): Change return type.
  43         (tui_clear_source_windows_detail): Update.
  44         (tui_add_to_source_windows): Change type of parameter.
  45         (tui_free_all_source_wins_content): Update.
  46
  47 2019-06-25  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-wingeneral.c (tui_win_info::refresh)
  50         (tui_source_window_base::refresh): New methods.
  51         (tui_refresh_all): Call the refresh method.
  52         * tui/tui-data.h (struct tui_win_info)
  53         (struct tui_source_window_base) <refresh>: New method.
  54
  55 2019-06-25  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui.h (tui_is_window_visible): Return bool.
  58         * tui/tui.c (tui_is_window_visible): Return bool.
  59         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  60         (tui_make_visible, tui_make_invisible)
  61         (tui_win_info::make_visible)
  62         (tui_source_window_base::make_visible, make_all_visible)
  63         (tui_make_all_visible, tui_make_all_invisible): Update.
  64         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  65         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  66         bool.
  67         (struct tui_win_info, struct tui_source_window_base)
  68         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  69         * tui/tui-data.c (tui_init_generic_part): Update.
  70
  71 2019-06-25  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  74         (tui_source_window_base::make_visible): New methods.
  75         (make_all_visible): Make method call.
  76         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  77         (struct tui_source_window_base, struct tui_cmd_window): Override
  78         make_visible.
  79         (tui_win_is_source_type): Don't declare.
  80         * tui/tui-data.c (tui_win_is_source_type): Remove.
  81
  82 2019-06-25  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  85         NULL check.
  86
  87 2019-06-25  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
  90         Inline constructor.  Add initializers for members.
  91         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
  92         constructors; now inline in class.
  93
  94 2019-06-25  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-regs.c (tui_show_registers): Update.
  97         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  98         bool.
  99         * tui/tui-data.c (tui_data_window::clear_detail)
 100         (tui_data_window): Update.
 101
 102 2019-06-25  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-windata.c (tui_display_all_data)
 105         (tui_display_data_from_line, tui_display_data_from)
 106         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 107         Update.
 108         * tui/tui-regs.c (tui_last_regs_line_no)
 109         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 110         (tui_show_registers, tui_show_register_group)
 111         (tui_display_registers_from, tui_display_reg_element_at_line)
 112         (tui_display_registers_from_line, tui_check_register_values)
 113         (tui_reg_next, tui_reg_prev): Update.
 114         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 115         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 116         tui_data_window.
 117         (struct tui_win_info) <detail>: Remove.  Add new fields from
 118         tui_data_info.
 119         (TUI_DATA_WIN): Add cast.
 120         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 121         (~tui_data_window): Simplify.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-layout.c (show_source_disasm_command)
 126         (show_source_or_disasm_and_command): Update.
 127         * tui/tui-io.c (update_cmdwin_start_line)
 128         (tui_redisplay_readline): Update.
 129         * tui/tui-data.h (struct tui_command_info): Remove.
 130         (struct tui_win_info) <detail>: Remove command_info member.
 131         (struct tui_data_window) <start_line>: New member, from
 132         tui_command_info.
 133         (TUI_CMD_WIN): Add casts.
 134
 135 2019-06-25  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-winsource.c (tui_update_source_window)
 138         (tui_refill_source_window)
 139         (tui_source_window_base::do_scroll_horizontal)
 140         (tui_update_breakpoint_info, tui_set_exec_info_content)
 141         (tui_show_exec_info_content, tui_erase_exec_info_content)
 142         (tui_clear_exec_info_content): Update.
 143         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 144         Update.
 145         * tui/tui-win.c (make_invisible_and_set_new_height)
 146         (make_visible_with_new_height): Update.
 147         * tui/tui-source.c (tui_set_source_content)
 148         (tui_show_symtab_source): Update.
 149         * tui/tui-layout.c (extract_display_start_addr)
 150         (show_source_disasm_command, show_data)
 151         (make_source_or_disasm_window)
 152         (show_source_or_disasm_and_command): Update.
 153         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 154         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 155         "gdbarch".
 156         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 157         to tui_source_window_base.
 158         (struct tui_win_info) <detail>: Remove source_info member.
 159         (struct tui_source_window_base) <has_locator>: Inline.
 160         Move contents from tui_source_info; rename has_locator member to
 161         m_has_locator.
 162         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 163         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 164         header file.
 165         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 166         Simplify.
 167         (tui_free_all_source_wins_content): Cast to
 168         tui_source_window_base.
 169
 170 2019-06-25  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-win.c (make_invisible_and_set_new_height)
 173         (make_visible_with_new_height): Call has_locator method.
 174         * tui/tui-layout.c (show_source_disasm_command, show_data)
 175         (show_source_or_disasm_and_command): Update for bool change.
 176         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 177         (tui_win_info) <has_locator>: New method.
 178         (struct tui_source_window_base) <has_locator>: New method.
 179         (tui_win_has_locator): Don't declare.
 180         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 181         from tui_win_has_locator.
 182         (tui_source_window_base): Use false, not FALSE.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 187         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 188         clear_detail method directly.
 189         (tui_clear_win_detail): Remove.
 190
 191 2019-06-25  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 194         "this", not TUI_DISASM_WIN.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 199         declare.
 200         * tui/tui-winsource.c
 201         (tui_source_window_base::do_scroll_horizontal): Rename from
 202         tui_horizontal_source_scroll.
 203         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 204         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 205         from tui_vertical_data_scroll.
 206         * tui/tui-win.h (tui_scroll): Don't declare.
 207         * tui/tui-win.c (tui_win_info::forward_scroll)
 208         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 209         (tui_win_info::right_scroll): Rename and update.
 210         (tui_scroll_forward_command, tui_scroll_backward_command)
 211         (tui_scroll_left_command, tui_scroll_right_command): Update.
 212         (tui_scroll): Remove.
 213         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 214         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 215         from tui_vertical_source_scroll.
 216         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 217         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 218         from tui_vertical_disassem_scroll.
 219         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 220         do_scroll_horizontal>: New methods.
 221         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 222         Likewise.
 223         (struct tui_source_window_base): Add do_scroll_horizontal.
 224         (struct tui_source_window, struct tui_disasm_window): Add
 225         do_scroll_vertical.
 226         (struct tui_data_window, struct tui_cmd_window): Add
 227         do_scroll_horizontal and do_scroll_vertical.
 228         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 229
 230 2019-06-25  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-data.h (struct tui_source_window_base): New struct.
 233         (struct tui_source_window): Derive from tui_source_window_base.
 234         (struct tui_disasm_window): New struct.
 235         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 236         from tui_source_window::clear_detail.
 237         (tui_source_window_base): Rename from tui_source_window.
 238         (~tui_source_window_base): Rename from ~tui_source_window.
 239         (tui_alloc_win_info): Create a tui_disasm_window.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-data.h (struct tui_source_window)
 244         (struct tui_data_window): Declare destructors.
 245         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 246         destructors.
 247         (tui_win_info): Simplify.
 248
 249 2019-06-25  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-winsource.c (tui_display_main)
 252         (tui_update_source_windows_with_addr)
 253         (tui_update_all_breakpoint_info): Update.
 254         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 255         (new_height_ok, parse_scrolling_args): Update.
 256         * tui/tui-stack.c (tui_show_frame_info): Update.
 257         * tui/tui-data.h (struct tui_list): Remove.
 258         (tui_source_windows): Return a reference to a std::vector.
 259         * tui/tui-data.c (source_windows): Now a std::vector.
 260         (tui_source_windows): Change return type.
 261         (tui_clear_source_windows): Rewrite.
 262         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 263         (tui_free_all_source_wins_content): Rewrite.
 264
 265 2019-06-25  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 268         (struct tui_data_window, struct tui_cmd_window): Declare
 269         clear_detail method.
 270         * tui/tui-data.c (tui_source_window::clear_detail)
 271         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 272         methods.
 273         (tui_clear_win_detail): Simplify.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-layout.c (make_source_window, make_disasm_window)
 278         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 279         Return the new window.
 280         (show_source_disasm_command, show_data)
 281         (show_source_or_disasm_and_command): Update.
 282
 283 2019-06-25  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 286         parameter.  Return the new window.
 287         (show_source_disasm_command): Update and remove NULL check.
 288         (show_source_or_disasm_and_command): Update.
 289
 290 2019-06-25  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 293
 294 2019-06-25  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-data.h (struct tui_win_info): Make constructor
 297         protected.  Make destructor virtual.  Add initializers.
 298         (tui_source_window, tui_data_window, tui_cmd_window): New
 299         classes.
 300         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 301         constructor.  Add "type" parameter.
 302         (tui_source_window, tui_data_window, tui_cmd_window): New
 303         constructors.
 304         (tui_alloc_win_info): Instantiate the appropriate subclass.
 305
 306 2019-06-25  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-win.c (tui_resize_all): Use delete.
 309         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 310         destructor.
 311         (tui_free_window): Don't declare.
 312         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 313         Update.
 314
 315 2019-06-25  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-data.h (struct tui_win_info): Add constructor.
 318         * tui/tui-data.c (tui_alloc_win_info): Use new.
 319         (tui_free_window): Use delete.
 320
 321 2019-06-22  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 324         declare.
 325         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 326
 327 2019-06-22  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 330         declare.
 331         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 332
 333 2019-06-22  Tom de Vries  <tdevries@suse.de>
 334
 335         * dwarf2read.c (create_addrmap_from_aranges)
 336         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 337         instead of '%zu'.
 338
 339 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 340
 341         * dwarf2read.h (dwarf2_section_info_def): Remove.
 342         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 343         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 344         std::vector<dwarf2_section_info>.
 345         (struct dwo_file) <~dwo_file>: Remove.
 346         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 347         types field.
 348         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 349         (dwarf2_read_debug_names): Likewise.
 350         (create_debug_types_hash_table): Change parameter type to
 351         array_view, adjust code accordingly.
 352         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 353         (partial_die_info::fixup): Likewise.
 354         (determine_prefix): Likewise.
 355         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 356
 357 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 358
 359         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 360         gdb_bfd_ref_ptr.
 361         <~dwo_file>: Remove call to gdb_bfd_unref.
 362         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 363         gdb_bfd_ref_ptr::get.
 364
 365 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 366
 367         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 368         type to htab_up.
 369         * dwarf2read.c (struct dwo_file): Initialize fields.
 370         <~dwo_file>: New.
 371         (free_dwo_file): Remove, move content to ~dwo_file.
 372         (struct dwo_file_deleter): Remove.
 373         (dwo_file_up>: Remove custom deleter.
 374         (free_dwo_files): Remove.
 375         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 376         dwo_files.
 377         (process_skeletonless_type_units): Call unique_ptr::get.
 378         (allocate_dwo_file_hash_table): Add deleter to created hash
 379         table.  Change return type to htab_up.
 380         (lookup_dwo_file_slot): Don't memset dwo_file, call
 381         unique_ptr::get.
 382         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 383         (create_dwo_unit_in_dwp_v2): Likewise.
 384         (open_and_init_dwo_file): Likewise.
 385         (free_dwo_file_from_slot): Remove.
 386
 387 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 388
 389         * dwarf2read.h (struct dwarf2_section_info) <readin,
 390         is_virtual>: Change type to bool.
 391         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 392         true instead of 1.
 393
 394 2019-06-19  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-data.h (tui_init_content_element): Don't declare.
 397
 398 2019-06-19  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-data.h (tui_init_win_info): Don't declare.
 401
 402 2019-06-19  Tom de Vries  <tdevries@suse.de>
 403
 404         * dwarf2read.h (abstract_to_concrete): Change type to
 405         std::unordered_map<sect_offset, std::vector<sect_offset>,
 406         gdb::hash_enum<sect_offset>>.
 407
 408 2019-06-19  Tom Tromey  <tromey@adacore.com>
 409
 410         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 411         EVAL_AVOID_SIDE_EFFECTS specially.
 412
 413 2019-06-19  Tom Tromey  <tromey@adacore.com>
 414
 415         * source-cache.c (highlighter): New global.
 416         (source_cache::get_source_lines): Create a highlighter on demand.
 417
 418 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * defs.h (deprecated_interactive_hook): Delete declaration.
 421         * interps.c (clear_interpreter_hooks): Remove use of
 422         deprecated_interactive_hook.
 423         * top.c (deprecated_interactive_hook): Delete definition.
 424         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 425
 426 2019-06-18  Tom de Vries  <tdevries@suse.de>
 427
 428         PR gdb/24515
 429         * dwarf2read.h (abstract_to_concrete): Change type from
 430         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 431         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 432         * dwarf2read.c (read_variable): Update.
 433         (dwarf2_fetch_die_loc_sect_off): Update.
 434
 435 2019-06-17  Tom de Vries  <tdevries@suse.de>
 436
 437         PR gdb/24617
 438         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 439         accessing parent[parent_len - 1].
 440
 441 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 442
 443         PR gdb/24364
 444         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 445         call dtrace_process_dof with NULL dof.
 446
 447 2019-06-16  Tom de Vries  <tdevries@suse.de>
 448
 449         PR gdb/24445
 450         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 451
 452 2019-06-16  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 455         (make_all_visible): Use address of member.
 456
 457 2019-06-16  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 460         (tui_free_window, free_content, free_content_elements): Remove
 461         unnecessary cast.
 462         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 463         cast.
 464         * tui/tui-regs.c (tui_show_register_group)
 465         (tui_display_registers_from, tui_display_reg_element_at_line):
 466         Remove unnecessary cast.
 467
 468 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 469
 470         * linux-nat.c (normal_mask): Delete.
 471         (_initialize_linux_nat): Don't initialise normal_mask.
 472
 473 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 474
 475         PR gdb/24445
 476         * dwarf-index-write.h (write_psymtabs_to_index): Add
 477         dwz_basename parameter.
 478         * dwarf-index-write.c (write_gdbindex): Move file writing to
 479         write_gdbindex_1.  Change return type void.
 480         (assert_file_size): Move up, remove filename parameter.
 481         (write_gdbindex_1): New function.
 482         (write_debug_names): Change return type to void, call
 483         assert_file_size.
 484         (struct index_wip_file): New struct.
 485         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 486         file logic to index_wip_file.  Write index for dwz file if
 487         needed.
 488         (save_gdb_index_command): Pass basename of dwz file, if present.
 489         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 490         build-id of dwz file, if present.
 491         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 492         (dwarf2_get_dwz_file): Likewise.
 493         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 494         (dwarf2_get_dwz_file): Likewise.
 495
 496 2019-06-16  Tom Tromey  <tom@tromey.com>
 497
 498         * coffread.c (process_coff_symbol): Use xstrdup.
 499         * value.c (create_internalvar): Use xstrdup.
 500
 501 2019-06-16  Tom Tromey  <tom@tromey.com>
 502
 503         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 504         * breakpoint.c (stopin_command, stopat_command)
 505         (until_break_command, decode_location_default): Remove unnecessary
 506         cast.
 507         * utils.c (subset_compare): Remove unnecessary cast.
 508         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 509         cast.
 510         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 511         cast.
 512         * infcmd.c (path_command): Remove unnecessary cast.
 513         * coffread.c (decode_type): Remove unnecessary cast.
 514         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 515         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 516         * tui/tui-stack.c (tui_show_locator_content)
 517         (tui_show_frame_info): Remove unnecessary cast.
 518         * tui/tui-win.c (tui_scroll_forward_command)
 519         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 520         (parse_scrolling_args): Remove unnecessary cast.
 521         * tui/tui-data.c (init_win_info, tui_del_window)
 522         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 523         (free_content_elements): Remove unnecessary cast.
 524         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 525         unnecessary cast.
 526         * tui/tui-source.c (tui_set_source_content)
 527         (tui_vertical_source_scroll): Remove unnecessary cast.
 528         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 529         cast.
 530         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 531         * tui/tui-regs.c (tui_display_registers_from)
 532         (tui_display_register): Remove unnecessary cast.
 533         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 534         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 535         (make_visible): Remove unnecessary cast.
 536         * tui/tui-winsource.c (tui_erase_source_content)
 537         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 538         unnecessary cast.
 539         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 540         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 541         * stabsread.c (read_type, read_array_type, read_range_type):
 542         Remove unnecessary cast.
 543         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 544         (parse_symbol, parse_type, upgrade_type, parse_external)
 545         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 546         unnecessary cast.
 547         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 548
 549 2019-06-16  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-data.c (tui_alloc_generic_win_info)
 552         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 553         checks.
 554
 555 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 556             Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * f-typeprint.c (f_print_type): Don't return early for not
 559         associated or not allocated types.
 560         (f_type_print_varspec_suffix): Add print_rank parameter and print
 561         ranks of array types in case they dangling.
 562         (f_type_print_base): Add print_rank parameter.
 563
 564 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 565
 566         * NEWS: Mention new MI commands.
 567         * break-catch-throw.c (enum exception_event_kind): Move to
 568         breakpoint.h.
 569         (print_mention_exception_catchpoint): Output text as a single
 570         message.
 571         (catch_exception_command_1): Rename to...
 572         (catch_exception_event): ...this, make non-static, update header
 573         command, and change some parameter types.
 574         (catch_catch_command): Update for changes to
 575         catch_exception_command_1.
 576         (catch_throw_command): Likewise.
 577         (catch_rethrow_command): Likewise.
 578         * breakpoint.c (enum exception_event_kind): Delete.
 579         * breakpoint.h (enum exception_event_kind): Moved here from
 580         break-catch-throw.c.
 581         (catch_exception_event): Declare.
 582         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 583         (mi_cmd_catch_throw): New function.
 584         (mi_cmd_catch_rethrow): New function.
 585         (mi_cmd_catch_catch): New function.
 586         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 587         'catch-catch' entries.
 588         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 589         (mi_cmd_catch_rethrow): Declare.
 590         (mi_cmd_catch_catch): Declare.
 591
 592 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * annotate.c (annotate_source_line): Change return type to void,
 595         update implementation to match.
 596         * annotate.h (annotate_source_line): Change return type to void,
 597         update header comment.
 598         * stack.c (print_frame_info): Don't change what frame information
 599         is printed based on whether annotations are on or not.
 600
 601 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 604         (annotate_source): Make static.
 605         (annotate_source_line): Moved from source.c and renamed from
 606         identify_source_line.  Update the return type.
 607         * annotate.h (annotate_source): Delete declaration.
 608         (annotate_source_line): Declaration moved from source.h, and
 609         renamed from identify_source_line.  Return type updated.
 610         * source.c (identify_source_line): Moved to annotate.c and renamed
 611         to annotate_source_line.
 612         (info_line_command): Remove check of annotation_level.
 613         * source.h (identify_source_line): Move declaration to annotate.h
 614         and rename to annotate_source_line.
 615         * stack.c: Add 'annotate.h' include.
 616         (print_frame_info): Remove check of annotation_level before
 617         calling annotate_source_line.
 618
 619 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * source-cache.c (source_cache::get_plain_source_lines): Use
 622         open_source_file_with_line_charpos instead of just
 623         open_source_file, remove call to find_source_lines.
 624         (source_cache::get_source_lines): Likewise.
 625         * source.c (find_source_lines): Make static.
 626         (get_filename_and_charpos): Renamed into...
 627         (open_source_file_with_line_charpos): ..this along with changes to
 628         return a scoped_fd, and some other minor clean ups.
 629         (identify_source_line): Use open_source_file_with_line_charpos.
 630         (search_command_helper): Use open_source_file_with_line_charpos
 631         instead of just open_source_file, remove call to
 632         find_source_lines.
 633         * source.h (open_source_file_with_line_charpos): Declare new
 634         function.
 635         (find_source_lines): Delete declaration.
 636
 637 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * source.c (get_filename_and_charpos): Remove fullname
 640         parameter.
 641         (identify_source_line): Update call to get_filename_and_charpos.
 642
 643 2019-06-14  Tom Tromey  <tromey@adacore.com>
 644
 645         PR gdb/24502:
 646         * ui-style.h (skip_ansi_escape): Update comment.
 647         * ui-file.h (class no_terminal_escape_file): New class.
 648         * ui-file.c (no_terminal_escape_file::write)
 649         (no_terminal_escape_file::puts): New methods.
 650         * cli/cli-logging.c (handle_redirections): Use
 651         no_terminal_escape_file.
 652
 653 2019-06-14  Tom Tromey  <tromey@adacore.com>
 654
 655         * NEWS: Move convenience variable news above Python news.
 656
 657 2019-06-14  Tom Tromey  <tom@tromey.com>
 658
 659         * gnulib: Move directory to top-level.
 660         * configure.ac: Don't configure gnulib.
 661         * configure: Rebuild.
 662         * common/common-defs.h: Use new path to gnulib.
 663         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 664         (GNULIB_H): Remove.
 665         (INCGNU): Look in new gnulib location.
 666         (HFILES_NO_SRCDIR): Remove gnulib files.
 667         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 668         (generated_files): Remove GNULIB_H.
 669         ($(LIBGNU), all-lib): Remove targets.
 670         (distclean): Don't mention GNULIB_BUILDDIR.
 671         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 672
 673 2019-06-14  Tom Tromey  <tromey@adacore.com>
 674
 675         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 676         Warn if symbol file does not provide any symbols.
 677
 678 2019-06-14  Tom Tromey  <tromey@adacore.com>
 679
 680         * source.c (find_and_open_source): Respect basenames_may_differ.
 681
 682 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * annotate.c (annotate_breakpoints_invalid): Make use of
 685         scoped_restore_terminal_state.
 686         (annotate_frames_invalid): Likewise.
 687
 688 2019-06-14  Tom Tromey  <tromey@adacore.com>
 689
 690         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 691         allow assignment to an internalvar.
 692
 693 2019-06-14  Tom Tromey  <tromey@adacore.com>
 694
 695         * ada-lex.l: Allow "_" in attribute names.
 696
 697 2019-06-14  Tom Tromey  <tromey@adacore.com>
 698
 699         PR gdb/24653:
 700         * regcache.c (registers_changed): Don't call alloca.
 701         * top.c (execute_command): Don't call alloca.
 702
 703 2019-06-13  Pedro Alves  <palves@redhat.com>
 704
 705         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 706         'expression'.  When parsing an expression, error out if there's
 707         junk after "unlimited".
 708         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 709         (do_set_command): Adjust calls to is_unlimited_literal.
 710
 711 2019-06-13  Pedro Alves  <palves@redhat.com>
 712
 713         * compile/compile.c (make_compile_options_def_group): Add braces
 714         around array_view initializer.
 715         * thread.c (make_thread_apply_all_options_def_group)
 716         (make_thread_apply_all_options_def_group): Likewise.
 717
 718 2019-06-13  Pedro Alves  <palves@redhat.com>
 719
 720         * NEWS (New commands): Mention "maint test-options
 721         require-delimiter", "maint test-options unknown-is-error", "maint
 722         test-options unknown-is-operand" and "maint show
 723         test-options-completion-result".
 724         (New command options, command completion): New section.
 725         (Completion improvements): New section.
 726         Mention that you can abbreviate "unlimited".
 727
 728 2019-06-13  Pedro Alves  <palves@redhat.com>
 729
 730         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 731         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 732         * unittests/cli-utils-selftests.c (test_parse_flags)
 733         (test_parse_flags_qcs): Delete.
 734         (test_cli_utils): Don't call deleted functions.
 735
 736 2019-06-13  Pedro Alves  <palves@redhat.com>
 737
 738         * thread.c: Include "cli/cli-option.h".
 739         (tp_array_compar_ascending): Global.
 740         (tp_array_compar): Delete function.
 741         (tp_array_compar_ascending, tp_array_compar_descending): New
 742         functions.
 743         (ascending_option_def, qcs_flag_option_def)
 744         (thr_qcs_flags_option_defs)
 745         (make_thread_apply_all_options_def_group)
 746         (make_thread_apply_options_def_group): New.
 747         (thread_apply_all_command): Use gdb::option::process_options.
 748         (thread_apply_command_completer)
 749         (thread_apply_all_command_completer): New.
 750         (thread_apply_command): Use gdb::option::process_options.
 751         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 752         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 753         to generate help text of "thread apply".  Adjust "taas"'s help.
 754         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 755         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 756
 757 2019-06-13  Pedro Alves  <palves@redhat.com>
 758
 759         * thread.c (thread_apply_command): Check for invalid TID with
 760         isdigit instead of !isalpha.
 761
 762 2019-06-13  Pedro Alves  <palves@redhat.com>
 763
 764         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 765         (validate_flags_qcs): New.
 766         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 767         (validate_flags_qcs): Declare.
 768         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 769         (make_frame_apply_options_def_group): New.
 770         (frame_apply_command_count): Process options with
 771         gdb::option::process_options.
 772         (frame_apply_completer): New.
 773         (frame_apply_level_completer, frame_apply_all_completer)
 774         (frame_apply_completer): New.
 775         (_initialize_stack): Update help of "frame apply", "frame apply
 776         level", "frame apply all" and "faas" to mention supported options
 777         and install command completers.
 778         * stack.h (frame_apply_all_completer): Declare.
 779         * thread.c: Include "stack.h".
 780         (tfaas_command): Add "--".
 781         (_initialize_thread): Update help "tfaas" to mention supported
 782         options and install command completer.
 783
 784 2019-06-13  Pedro Alves  <palves@redhat.com>
 785
 786         * completer.c (complete_nested_command_line): New.
 787         (gdb_completion_word_break_characters_throw): Add assertion.
 788         * completer.h (complete_nested_command_line): Declare.
 789
 790 2019-06-13  Pedro Alves  <palves@redhat.com>
 791
 792         * stack.c (parse_backtrace_qualifiers): New.
 793         (backtrace_command): Use it.
 794         (backtrace_command_completer): Complete on qualifiers.
 795
 796 2019-06-13  Pedro Alves  <palves@redhat.com>
 797
 798         * frame.c: Include "cli/cli-option.h.
 799         (user_set_backtrace_options): New.
 800         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 801         Delete.
 802         (get_prev_frame): Adjust.
 803         (boolean_option_def, uinteger_option_def)
 804         (set_backtrace_option_defs): New.
 805         (_initialize_frame): Adjust and use
 806         gdb::option::add_setshow_cmds_for_options to install "set
 807         backtrace past-main" and "set backtrace past-entry".
 808         * frame.h: Include "cli/cli-option.h".
 809         (struct frame_print_options): Forward declare.
 810         (print_frame_arguments_all, print_frame_arguments_scalars)
 811         (print_frame_arguments_none): Declare.
 812         (print_entry_values): Delete declaration.
 813         (struct frame_print_options, user_frame_print_options): New.
 814         (struct set_backtrace_options): New.
 815         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 816         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 817         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 818         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 819         (list_args_or_locals): Add frame_print_options parameter.
 820         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 821         * python/py-framefilter.c (enumerate_args): Pass down
 822         USER_FRAME_PRINT_OPTIONS.
 823         * stack.c: Include "cli/cli-option.h".
 824         (print_frame_arguments_all, print_frame_arguments_scalars)
 825         (print_frame_arguments_none): Declare.
 826         (print_raw_frame_arguments, print_entry_values): Delete.
 827         (user_frame_print_options): New.
 828         (boolean_option_def, enum_option_def, frame_print_option_defs):
 829         New.
 830         (struct backtrace_cmd_options): New.
 831         (bt_flag_option_def): New.
 832         (backtrace_command_option_defs): New.
 833         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 834         (print_frame_arg, read_frame_arg, print_frame_args)
 835         (print_frame_info, print_frame): Add frame_print_options parameter
 836         and use it.
 837         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 838         (backtrace_command_1): Add frame_print_options and
 839         backtrace_cmd_options parameters and use them.
 840         (make_backtrace_options_def_group): New.
 841         (backtrace_command): Process command options with
 842         gdb::option::process_options.
 843         (backtrace_command_completer): New.
 844         (_initialize_stack): Extend "backtrace"'s help to mention
 845         supported options.  Install completer for "backtrace".
 846         Install some settings commands with add_setshow_cmds_for_options.
 847
 848 2019-06-13  Pedro Alves  <palves@redhat.com>
 849
 850         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 851         and that "set/show print raw frame-arguments" are now deprecated.
 852
 853         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 854         command.
 855         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 856         * stack.c (_initialize_stack): Install "set/show print
 857         raw-frame-arguments", and deprecate "set/show print raw
 858         frame-arguments".
 859         * valprint.c (_initialize_valprint): Deprecate "set/show print
 860         raw".
 861
 862 2019-06-13  Pedro Alves  <palves@redhat.com>
 863
 864         * compile/compile.c (struct compile_options): New.
 865         (compile_flag_option_def, compile_command_option_defs)
 866         (make_compile_options_def_group): New.
 867         (compile_file_command): Handle options with
 868         gdb::option::process_options.
 869         (compile_file_command_completer): New function.
 870         (compile_code_command): Handle options with
 871         gdb::option::process_options.
 872         (compile_code_command_completer): New function.
 873         (_initialize_compiler): Install completers for "compile code" and
 874         "compile file".  Mention available options in "compile code" and
 875         "compile code"'s help.
 876         * completer.c (advance_to_completion_word): New, factored out from
 877         ...
 878         (advance_to_expression_complete_word_point): ... this.
 879         (advance_to_filename_complete_word_point): New.
 880         * completer.h (advance_to_filename_complete_word_point): New
 881         declaration.
 882
 883 2019-06-13  Pedro Alves  <palves@redhat.com>
 884
 885         * compile/compile.c: Include "cli/cli-option.h".
 886         (compile_print_value): Scope data pointer is now a
 887         value_print_options pointer; adjust.
 888         (compile_print_command): Process options.  Scope data pointer is
 889         now a value_print_options pointer; adjust.
 890         (_initialize_compile): Update "compile print"'s help to include
 891         supported options.  Install a completer for "compile print".
 892         * cp-valprint.c (show_vtblprint, show_objectprint)
 893         (show_static_field_print): Delete.
 894         (_initialize_cp_valprint): Don't install "set print
 895         static-members", "set print vtbl", "set print object" here.
 896         * printcmd.c: Include "cli/cli-option.h" and
 897         "common/gdb_optional.h".
 898         (print_command_parse_format): Rework to fill in a
 899         value_print_options instead of a format_data.
 900         (print_value): Change parameter type from format_data pointer to
 901         value_print_options reference.  Adjust.
 902         (print_command_1): Process options.  Adjust to pass down a
 903         value_print_options.
 904         (print_command_completer): New.
 905         (_initialize_printcmd): Install print_command_completer as
 906         handle_brkchars completer for the "print" command.  Update
 907         "print"'s help to include supported options.
 908         * valprint.c: Include "cli/cli-option.h".
 909         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 910         here from cp-valprint.c.
 911         (boolean_option_def, uinteger_option_def)
 912         (value_print_option_defs, make_value_print_options_def_group):
 913         New.  Use gdb::option::add_setshow_cmds_for_options to install
 914         "set print elements", "set print null-stop", "set print repeats",
 915         "set print pretty", "set print union", "set print array", "set
 916         print address", "set print symbol", "set print array-indexes".
 917         * valprint.h: Include <string> and "cli/cli-option.h".
 918         (make_value_print_options_def_group): Declare.
 919         (print_value): Change parameter type from format_data pointer to
 920         value_print_options reference.
 921         (print_command_completer): Declare.
 922
 923 2019-06-13  Pedro Alves  <palves@redhat.com>
 924
 925         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 926         (COMMON_SFILES): Add maint-test-settings.c.
 927         * cli/cli-decode.c (boolean_enums): New global, factored out from
 928         ...
 929         (add_setshow_boolean_cmd): ... here.
 930         * cli/cli-decode.h (boolean_enums): Declare.
 931         * cli/cli-option.c: New file.
 932         * cli/cli-option.h: New file.
 933         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 934         factored out from ...
 935         (parse_cli_boolean_value(const char *)): ... this.
 936         (is_unlimited_literal): Change parameter type to pointer to
 937         pointer.  Adjust and advance ARG pointer.
 938         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 939         (parse_cli_var_enum): New, factored out from ...
 940         (do_set_command): ... this.  Adjust.
 941         * cli/cli-setshow.h (parse_cli_boolean_value)
 942         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 943         (parse_cli_var_enum): Declare.
 944         * cli/cli-utils.c: Include "cli/cli-option.h".
 945         (get_ulongest): New.
 946         * cli/cli-utils.h (get_ulongest): Declare.
 947         (check_for_argument): New overloads.
 948         * maint-test-options.c: New file.
 949
 950 2019-06-13  Pedro Alves  <palves@redhat.com>
 951
 952         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 953         parse a range if "-" is at the end of the string.
 954
 955 2019-06-13  Pedro Alves  <palves@redhat.com>
 956
 957         * cli/cli-setshow.c (parse_auto_binary_operation)
 958         (parse_cli_boolean_value): Don't allow "o".
 959
 960 2019-06-13  Pedro Alves  <palves@redhat.com>
 961
 962         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 963         * NEWS: Mention maint test-settings KIND.
 964         * maint-test-settings.c: New file.
 965
 966 2019-06-13  Pedro Alves  <palves@redhat.com>
 967
 968         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 969         completer.
 970         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 971         "set" completers.
 972
 973 2019-06-13  Pedro Alves  <palves@redhat.com>
 974
 975         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 976         after item.
 977
 978 2019-06-13  Pedro Alves  <palves@redhat.com>
 979
 980         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 981
 982 2019-06-13  Pedro Alves <palves@redhat.com>
 983
 984         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 985         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 986         call.
 987         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 988         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 989         calls.
 990         (check_for_argument): Skip spaces after argument.
 991
 992 2019-06-13  Pedro Alves  <palves@redhat.com>
 993
 994         * thread.c (thread_apply_command): Adjust TID parsing.
 995         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 996         detected before end of string.
 997         (tid_is_in_list): Error out if LIST is invalid.
 998
 999 2019-06-13  Pedro Alves  <palves@redhat.com>
1000
1001         * completer.c (complete_line_internal_1): Rewind completion word
1002         point.
1003         (completion_tracker::advance_custom_word_point_by): Change
1004         parameter type to int.
1005         * completer.h (completion_tracker::advance_custom_word_point_by):
1006         Likewise.
1007
1008 2019-06-13  Pedro Alves  <palves@redhat.com>
1009
1010         * completer.c (advance_to_completion_word): Handle delimiters.
1011
1012 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1013
1014         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1015
1016 2019-06-11  Tom Tromey  <tom@tromey.com>
1017
1018         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1019         (xmalloc_failed): Move to alloc.c.
1020         * alloc.c: New file.
1021         * Makefile.in (COMMON_SFILES): Add alloc.c.
1022
1023 2019-06-11  Tom Tromey  <tom@tromey.com>
1024
1025         * nat/linux-waitpid.c: Don't include server.h.
1026         (linux_debug): Remove.
1027         (my_waitpid): Update.
1028
1029 2019-06-11  Tom Tromey  <tromey@adacore.com>
1030
1031         * infcall.c (_initialize_infcall): Remove trailing newline from
1032         help.
1033         * user-regs.c (_initialize_user_regs): Remove trailing newline
1034         from help.
1035         * typeprint.c (_initialize_typeprint): Remove trailing newline
1036         from help.
1037         * reverse.c (_initialize_reverse): Remove trailing newlines from
1038         help.
1039         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1040         from help.
1041         * language.c (add_set_language_command): Remove trailing newline
1042         from help.
1043         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1044         help.
1045         * disasm.c (_initialize_disasm): Remove trailing newline from
1046         help.
1047         * top.c (init_main): Remove trailing newline from help.
1048         * interps.c (_initialize_interpreter): Remove trailing newline
1049         from help.
1050         * btrace.c (_initialize_btrace): Remove trailing newlines from
1051         help.
1052         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1053         from help.
1054         * python/python.c (_initialize_python): Remove trailing newline
1055         from help.
1056         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1057         help.
1058         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1059         from help.  Reformat some text.
1060         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1061         from help.
1062         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1063         newline from help.
1064
1065 2019-06-11  Tom Tromey  <tromey@adacore.com>
1066
1067         * darwin-nat.c (darwin_decode_exception_message)
1068         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1069
1070 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * valops.c (value_slice): Check for not allocated or not
1073         associated values.
1074
1075 2019-06-10  Tom de Vries  <tdevries@suse.de>
1076
1077         PR gdb/24618
1078         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1079         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1080         invalid.
1081
1082 2019-06-10  Tom de Vries  <tdevries@suse.de>
1083
1084         PR gdb/24611
1085         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1086         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1087
1088 2019-06-10  Tom de Vries  <tdevries@suse.de>
1089
1090         PR symtab/24545
1091         * symtab.c (struct demangled_name_entry): Add language field.
1092         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1093         static minimal symbol".  Set and use language field.
1094
1095 2019-06-10  Tom Tromey  <tromey@adacore.com>
1096
1097         * ada-lang.c (_initialize_ada_language): Update help text.
1098
1099 2019-06-10  Tom Tromey  <tromey@adacore.com>
1100
1101         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1102         with a newline.
1103         * guile/guile.c (handle_boot_error): Don't end warning with a
1104         newline.
1105         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1106         warning with a newline.
1107         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1108         newline.
1109         (s12z_frame_cache): Likewise.
1110         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1111         a newline.
1112         * solib-svr4.c (disable_probes_interface): Don't end warning with
1113         a newline.
1114         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1115         newline.
1116         * python/python.c (do_finish_initialization): Don't end warning
1117         with a newline.
1118
1119 2019-06-10  Tom Tromey  <tom@tromey.com>
1120
1121         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1122         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1123         gdbpy_enter.
1124
1125 2019-06-10  Tom Tromey  <tromey@adacore.com>
1126
1127         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1128         data.
1129         (elf_new_init): Don't call stabsread_new_init.
1130         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1131         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1132         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1133
1134 2019-06-10  Tom de Vries  <tdevries@suse.de>
1135
1136         PR symtab/16264
1137         PR symtab/24517
1138         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1139
1140 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1141
1142         * source.c (find_and_open_source): Also rewrite relative file
1143         names.
1144
1145 2019-04-26  Amos Bird  <amosbird@gmail.com>
1146
1147         * annotate.c (annotate_thread_exited): Add "thread-exited"
1148         annotation.
1149
1150 2019-06-06  Tom Tromey  <tromey@adacore.com>
1151
1152         * maint.h (class scoped_command_stats): Use
1153         DISABLE_COPY_AND_ASSIGN.
1154         <print_time>: New method.
1155         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1156         print_time.
1157         (scoped_command_stats::print_time): New method.
1158
1159 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1162         instructions of lengths 6 or 8 bytes.
1163
1164 2019-06-04  Pedro Alves  <palves@redhat.com>
1165
1166         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1167
1168         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1169         * breakpoint.c (condition_completer): Likewise.
1170         * cli/cli-dump.c (scan_expression): Likewise.
1171         * common/filestuff.c (mkdir_recursive): Likewise.
1172         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1173         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1174         (gdb_abspath): Likewise.
1175         * compile/compile-cplus-types.c
1176         (compile_cplus_instance::decl_name): Likewise.
1177         * completer.c (complete_explicit_location):
1178         (signal_completer, reg_or_group_completer_1): Likewise.
1179         * cp-support.c (cp_remove_params_if_any): Likewise.
1180         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1181         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1182         * infcmd.c (strip_bg_char): Likewise.
1183         * linespec.c (copy_token_string): Likewise.
1184         * mi/mi-main.c (output_cores): Likewise.
1185         * psymtab.c (psymtab_search_name):
1186         * symfile.c (test_set_ext_lang_command): Likewise.
1187         * target.c (target_fileio_read_stralloc): Likewise.
1188         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1189         * value.c (complete_internalvar): Likewise.
1190
1191 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1192
1193         Add objfile property to gdb.Type.
1194         * NEWS: Mention Python API addition.
1195         * python/py-type.c (typy_get_objfile): New method.
1196
1197 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1198
1199         * NEWS: Mention the new set|show style [title|highlight].
1200         Mention changes to "show style", "help" and "apropos".
1201
1202 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1203
1204         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1205         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1206         instead of print_help_for_command.
1207         (print_doc_of_command): New function.
1208         (help_list): Add 'apropos -v word' suggestion.
1209         (print_help_for_command): Style the command name using title style.
1210         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1211         (_initialize_cli_cmds): Describe -v in apropos_command help.
1212
1213 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * cli/cli-style.h (cli_style_option): Add name in constructor,
1216         add m_name class member, add constructor with intensity,
1217         add name class function.
1218         (cli_style_option::add_setshow_commands): Remove name argument.
1219         (highlight_style, title_style): New styles.
1220         * cli/cli-style.c (do_show): New function that shows a style
1221         characteristic styling the style name with itself.
1222         (set_style_name): New function.
1223         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1224         Update all callers according to the changes in cli/cli-style.h.
1225         * utils.h (fputs_highlighted): New function.
1226         * utils.c (fputs_highlighted): Likewise.
1227
1228 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * NEWS: Mention new pipe command and new convenience variables.
1231
1232 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1233
1234         * cli/cli-cmds.c (pipe_command): New function.
1235         (_initialize_cli_cmds): Call add_com for pipe_command.
1236         Define | as an alias for pipe.
1237         (exit_status_set_internal_vars): New function.
1238         (shell_escape): Call exit_status_set_internal_vars.
1239         cli/cli-decode.c (find_command_name_length): Recognize | as
1240         a single character command.
1241
1242 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1245         top.c (execute_command_to_ui_file): New function, mostly a copy
1246         of execute_command_to_string.
1247         (execute_command_to_string): Implement by calling
1248         execute_command_to_ui_file.
1249
1250 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1251
1252         * top.h (saved_command_line): Remove declaration.
1253         * top.c (previous_saved_command_line, previous_repeat_arguments):
1254         New variables.
1255         (saved_command_line): Make static, define together with other
1256         'repeat variables'.
1257         (dont_repeat): Clear repeat_arguments.
1258         (repeat_previous, get_saved_command_line, save_command_line):
1259         New functions.
1260         (gdb_init): Initialize saved_command_line
1261         and previous_saved_command_line.
1262         * main.c (captured_main_1): Remove saved_command_line initialization.
1263         * event-top.c (handle_line_of_input): Update to use
1264         the new 'repeat' related functions instead of direct access to
1265         saved_command_line.
1266         * command.h (repeat_previous, get_saved_command_line,
1267         save_command_line): New declarations.
1268         (dont_repeat): Add comment.
1269
1270 2019-05-30  Tom Tromey  <tromey@adacore.com>
1271
1272         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1273         Fix comment.
1274         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1275
1276 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1277
1278         PR cli/24587
1279         * completer.c (complete): Initialize variable word.
1280
1281 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1282
1283         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1284         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1285         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1286         'body' is NULL to the outter 'if', protecting the '!is_define'
1287         situation as well.
1288
1289 2019-05-29  Tom Tromey  <tromey@adacore.com>
1290
1291         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1292         (dwarf_unknown): New function.
1293         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1294         (dwarf_type_encoding_name): Use dwarf_unknown.
1295
1296 2019-05-29  Tom Tromey  <tromey@adacore.com>
1297
1298         PR c++/20020:
1299         * cp-valprint.c (cp_print_value_fields): Call
1300         cp_print_static_field inside "try".
1301
1302 2019-05-29  Tom Tromey  <tromey@adacore.com>
1303
1304         * inflow.c (struct terminal_info): Add default operator=.
1305         * configure: Rebuild.
1306         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1307         -Wdeprecated-copy-dtor, -Wredundant-move.
1308
1309 2019-05-29  Tom Tromey  <tromey@adacore.com>
1310
1311         * NEWS: Add entry.
1312         * infcmd.c (print_return_value_1): Handle finish_print
1313         option.
1314         (show_print_finish): New function.
1315         (_initialize_infcmd): Add "set/show print finish" commands.
1316         * valprint.c (user_print_options): Initialize new member.
1317         * valprint.h (struct value_print_options) <finish_print>: New
1318         member.
1319
1320 2019-05-28  Tom Tromey  <tromey@adacore.com>
1321
1322         * ada-lang.c (ada_remove_Xbn_suffix)
1323         (find_old_style_renaming_symbol)
1324         (parse_old_style_renaming): Remove.
1325         (ada_find_renaming_symbol): Don't call
1326         find_old_style_renaming_symbol.
1327         (ada_is_renaming_symbol): Rename from
1328         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1329         bool.  Now static.
1330         (ada_read_var_value): Update and simplify.
1331         * ada-exp.y (write_var_or_type): Remove old code.
1332
1333 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1334
1335         * event-top.c: Remove include comment.
1336         * inflow.c (class scoped_ignore_sigttou): Move from here...
1337         * inflow.h (class scoped_ignore_sigttou): ...to here.
1338         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1339         * top.c:  Remove include comment.
1340
1341 2019-05-27  Tom Tromey  <tom@tromey.com>
1342
1343         * NEWS: Fix typo.
1344
1345 2019-05-22  Tom Tromey  <tromey@adacore.com>
1346
1347         * target.c (target_follow_exec): Constify parameter.
1348         * target-delegates.c: Rebuild.
1349         * remote.c (remote_target::follow_exec): Constify parameter.
1350         * infrun.c (follow_exec): Constify parameter.
1351         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1352         (target_follow_exec): Likewise.
1353
1354 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1355
1356         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1357         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1358
1359 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * NEWS: Add debugredirect and testsuite sections.
1362
1363 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1364
1365         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1366         target descriptions using exclusively floating point register name
1367         aliases.
1368
1369 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         PR gdb/18644:
1372         * f-lang.c (build_fortran_types): Handle the case where
1373         gdbarch_floatformat_for_type returns a nullptr.
1374
1375 2019-05-21  Tom de Vries  <tdevries@suse.de>
1376
1377         PR cli/24587
1378         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1379
1380 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         PR gdb/18644:
1383         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1384         16-byte floats.
1385         * i386-tdep.c (i386_floatformat_for_type): Use
1386         floatformats_ia64_quad for the 16-byte floating point component
1387         within a fortran 32-byte complex number.
1388
1389 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1392         delete default constructor.
1393         (find_partial_die): Update to return const struct.
1394         (partial_die_parent_scope): Move variable declaration into scope
1395         of its use and change its type to auto.
1396         (guess_partial_die_structure_name): Likewise.
1397         (partial_die_info::fixup): Likewise.
1398
1399 2019-05-17  Tom Tromey  <tromey@adacore.com>
1400
1401         * source.c (find_and_open_source): Remove cast.
1402
1403 2019-05-17  Tom Tromey  <tromey@adacore.com>
1404
1405         * annotate.c (annotate_source): Make "filename" const.
1406         * annotate.h (annotate_source): Use const.
1407
1408 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1409
1410         * disasm.c (set_disassembler_options): Send errors to stderr.
1411
1412 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1415         (cli_interp_base::set_logging): Check debug_redirect.
1416         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1417         * cli/cli-logging.c (debug_redirect): Add static variable.
1418         (pop_output_files): Add default param.
1419         (handle_redirections): Print debug setting.
1420         (show_logging_command): Likewise.
1421         (_initialize_cli_logging): Add debugredirect command.
1422         * interps.c (current_interp_set_logging): Add debug_redirect
1423         parameter.
1424         * interps.h (set_logging): Add debug_redirect parameter.
1425         (current_interp_set_logging): Likewise.
1426         * mi/mi-common.h: Likewise.
1427         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1428
1429 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1430             Tom Tromey  <tromey@adacore.com>
1431
1432         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1433         directly.
1434         * cli/cli-interp.h (make_logging_output): Remove declaration.
1435         * cli/cli-logging.c (make_logging_output): Remove function.
1436         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1437         directly.
1438         * ui-file.c (tee_file::tee_file): Remove bools.
1439         (tee_file::~tee_file): Remove deletes.
1440         * ui-file.h (tee_file): Remove bools.
1441
1442 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1443
1444         * mi/mi-cmds.h (mi_cmd_complete): New function.
1445         * mi/mi-main.c (mi_cmd_complete): Likewise.
1446         * mi/mi-cmds.c: Define new MI command -complete.
1447         * NEWS: Mention new -complete command.
1448
1449 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1450
1451         * completer.h (complete): New function.
1452         * completer.c (complete): Likewise.
1453         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1454         function defined in completer.h.
1455
1456 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1457
1458         * MAINTAINERS (Write After Approval): Add myself.
1459
1460 2019-05-17  Tom de Vries  <tdevries@suse.de>
1461
1462         PR gdb/24094
1463         * dwarf2read.c (struct cu_partial_die_info): New struct.
1464         (find_partial_die): Return cu_partial_die_info.
1465         (partial_die_parent_scope, guess_partial_die_structure_name)
1466         (partial_die_info::fixup): Handle new return type of find_partial_die.
1467
1468 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1469
1470         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1471         "std::string", simplifying the algorithm.
1472
1473 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1474
1475         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1476         (stap_static_probe_ops::get_probes): Likewise.
1477
1478 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1479
1480         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1481         '-')" and "else if".
1482         (stap_parse_single_operand): Join checks for
1483         "gdbarch_stap_parse_special_token_p" and
1484         "gdbarch_stap_parse_special_token" in the same "if" statement.
1485         Invert check when verifying for operation on register
1486         displacement.
1487
1488 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1489
1490         * stap-probe.c (stap_get_opcode): Update comment.
1491         (stap_get_expected_argument_type): Likewise.
1492         (handle_stap_probe): Likewise.
1493
1494 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1495
1496         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1497         return type to 'bool'.  Adjust comment.  Use 'bool' when
1498         appropriate.
1499         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1500         * stap-probe.c (stap_parse_argument_1): Likewise.
1501         (stap_is_operator): Likewise.
1502         (stap_is_generic_prefix): Likewise.
1503         (stap_is_register_prefix): Likewise.
1504         (stap_is_register_indirection_prefix): Likewise.
1505         (stap_is_integer_prefix): Likewise.
1506         (stap_generic_check_suffix): Likewise.
1507         (stap_check_integer_suffix): Likewise.
1508         (stap_check_register_suffix): Likewise.
1509         (stap_check_register_indirection_suffix): Likewise.
1510         (stap_parse_register_operand): Likewise.
1511         (stap_parse_single_operand): Likewise.
1512         (stap_parse_argument_1): Likewise.
1513         (stap_probe::get_argument_count): Likewise.
1514         (stap_is_operator): Likewise.
1515
1516 2019-05-16  Tom Tromey  <tromey@adacore.com>
1517
1518         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1519         keyword to foreach.
1520
1521 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1522
1523         * linux-thread-db.c (try_thread_db_load_1): Change return type
1524         to bool.
1525         (try_thread_db_load): Likewise.
1526         (try_thread_db_load_from_pdir_1): Likewise.
1527         (try_thread_db_load_from_pdir): Likewise.
1528         (try_thread_db_load_from_sdir): Likewise.
1529         (try_thread_db_load_from_dir): Likewise.
1530         (thread_db_load_search): Likewise.
1531         (has_libpthread): Likewise.
1532         (thread_db_load): Likewise.
1533
1534 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1535
1536         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1537         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1538         NULL, and complain/return if that's the case.
1539
1540 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1541
1542         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1543         (advance, posn, abstract_read_memory): New functions.
1544         [struct mem_read_abstraction]: New struct.
1545         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1546
1547 2019-05-14  Tom Tromey  <tromey@adacore.com>
1548
1549         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1550         value is not lval_memory.
1551
1552 2019-05-14  Tom Tromey  <tromey@adacore.com>
1553
1554         * solib.c (info_sharedlibrary_command): Style the file name.
1555
1556 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1559         (aarch64_vnv_type): Likewise.
1560         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1561         * common/tdesc.c: Likewise.
1562         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1563         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1564         * features/aarch64-fpu.xml: Add ieee half view.
1565         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1566         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1567         * gdbtypes.h (struct builtin_type): Likewise.
1568         (struct objfile_type): Likewise.
1569
1570 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1571
1572         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1573         typo.
1574         * location.h (string_to_event_location): Likewise.
1575
1576 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1577
1578         GDB 8.3 released.
1579
1580 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1581
1582         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1583         New variable declaration.
1584         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1585         New variable.
1586         (print_one_breakpoint): Use ui_out::test_flags and new global
1587         variable to compute use_fixed_output.
1588         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1589         Remove.
1590         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1591         (mi_multi_location_breakpoint_output_fixed): Remove.
1592         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1593         new variable.
1594         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1595         fix_multi_location_breakpoint_output flag if version >= 3.
1596         * ui-out.h (enum ui_out_flag)
1597         <fix_multi_location_breakpoint_output>: New enumerator.
1598
1599 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1600
1601         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1602
1603 2019-05-10  Tom Tromey  <tromey@adacore.com>
1604
1605         * ada-lang.c (catch_ada_completer): New function.
1606         (_initialize_ada_language): Use it.
1607
1608 2019-05-10  Tom Tromey  <tromey@adacore.com>
1609
1610         * thread.c (print_thread_info): Make "requested_threads" const.
1611         * gdbthread.h (print_thread_info): Make "requested_threads"
1612         const.
1613         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1614         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1615
1616 2019-05-08  Tom Tromey  <tom@tromey.com>
1617
1618         * gdbtypes.c (objfile_type_data): Change type.
1619         (objfile_type, _initialize_gdbtypes): Update.
1620
1621 2019-05-08  Tom Tromey  <tom@tromey.com>
1622
1623         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1624         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1625         (_initialize_dwarf2_frame): Update.
1626
1627 2019-05-08  Tom Tromey  <tom@tromey.com>
1628
1629         * objc-lang.c (objc_objfile_data): Change type.
1630         (find_methods): Update.
1631         (_initialize_objc_lang): Remove.
1632
1633 2019-05-08  Tom Tromey  <tom@tromey.com>
1634
1635         * stabsread.c (rs6000_builtin_type_data): Change type.
1636         (rs6000_builtin_type, _initialize_stabsread): Update.
1637
1638 2019-05-08  Tom Tromey  <tom@tromey.com>
1639
1640         * mips-tdep.c (mips_pdr_data): Remove.
1641         (_initialize_mips_tdep): Update.
1642
1643 2019-05-08  Tom Tromey  <tom@tromey.com>
1644
1645         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1646         (hppa_init_objfile_priv_data, read_unwind_info)
1647         (find_unwind_entry, _initialize_hppa_tdep): Update.
1648
1649 2019-05-08  Tom Tromey  <tom@tromey.com>
1650
1651         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1652         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1653         on obstack.
1654         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1655
1656 2019-05-08  Tom Tromey  <tom@tromey.com>
1657
1658         * mdebugread.c (basic_type_data): Change type.
1659         (basic_type, _initialize_mdebugread): Update.
1660
1661 2019-05-08  Tom Tromey  <tom@tromey.com>
1662
1663         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1664
1665 2019-05-08  Tom Tromey  <tom@tromey.com>
1666
1667         * nto-tdep.c (nto_inferior_data_reg): Change type.
1668         (nto_inferior_data): Update.
1669         (nto_inferior_data_cleanup, nto_new_inferior_data)
1670         (_initialize_nto_tdep): Remove.
1671         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1672
1673 2019-05-08  Tom Tromey  <tom@tromey.com>
1674
1675         * ada-lang.c (struct ada_inferior_data): Add initializers.
1676         (ada_inferior_data): Change type.
1677         (ada_inferior_data_cleanup): Remove.
1678         (get_ada_inferior_data, ada_inferior_exit)
1679         (struct ada_pspace_data): Add initializers, destructor.
1680         (ada_pspace_data_handle): Change type.
1681         (get_ada_pspace_data): Update.
1682         (ada_pspace_data_cleanup): Remove.
1683
1684 2019-05-08  Tom Tromey  <tom@tromey.com>
1685
1686         * coffread.c (struct coff_symfile_info): Add initializers.
1687         (coff_objfile_data_key): Move lower.  Change type.
1688         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1689         Update.
1690         (coff_free_info): Remove.
1691
1692 2019-05-08  Tom Tromey  <tom@tromey.com>
1693
1694         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1695         (fbsd_pspace_data_handle): Move lower.  Change type.
1696         (get_fbsd_pspace_data): Update.
1697         (fbsd_pspace_data_cleanup): Remove.
1698         (_initialize_fbsd_tdep): Update.
1699
1700 2019-05-08  Tom Tromey  <tom@tromey.com>
1701
1702         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1703         (get_ada_tasks_pspace_data): Update.
1704         (ada_tasks_pspace_data_cleanup): Remove.
1705         (_initialize_tasks): Update.
1706         (ada_tasks_inferior_data_handle): Change type.
1707         (get_ada_tasks_inferior_data): Update.
1708         (ada_tasks_inferior_data_cleanup): Remove.
1709         (struct ada_tasks_pspace_data): Add initializers.
1710
1711 2019-05-08  Tom Tromey  <tom@tromey.com>
1712
1713         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1714         * symfile-debug.c (debug_sym_get_probes): Change type.
1715         * stap-probe.c (handle_stap_probe):
1716         (stap_static_probe_ops::get_probes): Change type.
1717         * probe.h (class static_probe_ops) <get_probes>: Change type.
1718         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1719         (parse_probes_in_pspace): Update.
1720         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1721         Update.
1722         (any_static_probe_ops::get_probes): Change type.
1723         * elfread.c (elfread_data): New typedef.
1724         (probe_key): Change type.
1725         (elf_get_probes): Likewise.  Update.
1726         (probe_key_free): Remove.
1727         (_initialize_elfread): Update.
1728         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1729         Change type.
1730         (dtrace_process_dof_probe, dtrace_process_dof)
1731         (dtrace_static_probe_ops::get_probe): Change type.
1732
1733 2019-05-08  Tom Tromey  <tom@tromey.com>
1734
1735         * xcoffread.c (struct xcoff_symfile_info): Rename from
1736         coff_symfile_info.  Add initializers.
1737         (xcoff_objfile_data_key): Move lower.  Change type.
1738         (XCOFF_DATA): Rewrite.
1739         (xcoff_free_info): Remove.
1740         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1741         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1742         (xcoff_initial_scan): Update.
1743
1744 2019-05-08  Tom Tromey  <tom@tromey.com>
1745
1746         * solib-svr4.c (struct svr4_info): Add initializers and
1747         destructor.
1748         <probes_table>: Now an htab_up.
1749         (solib_svr4_pspace_data): Change type.
1750         (free_probes_table): Simplify.
1751         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1752         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1753         (probes_table_remove_objfile_probes, register_solib_event_probe)
1754         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1755         (_initialize_svr4_solib): Update.
1756
1757 2019-05-08  Tom Tromey  <tom@tromey.com>
1758
1759         * remote.c (remote_pspace_data): Change type.
1760         (remote_pspace_data_cleanup): Remove.
1761         (get_remote_exec_file, set_pspace_remote_exec_file)
1762         (_initialize_remote): Update.
1763
1764 2019-05-08  Tom Tromey  <tom@tromey.com>
1765
1766         * breakpoint.c (breakpoint_objfile_key): Change type.
1767         (get_breakpoint_objfile_data): Update.
1768         (free_breakpoint_objfile_data): Remove.
1769         (_initialize_breakpoint): Update.
1770
1771 2019-05-08  Tom Tromey  <tom@tromey.com>
1772
1773         * linux-tdep.c (struct linux_info): Add initializers.
1774         (linux_inferior_data): Move.  Change type.
1775         (invalidate_linux_cache_inf): Update.
1776         (linux_inferior_data_cleanup): Remove.
1777         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1778
1779 2019-05-08  Tom Tromey  <tom@tromey.com>
1780
1781         * auxv.c (auxv_inferior_data): Move.  Change type.
1782         (auxv_inferior_data_cleanup): Remove.
1783         (invalidate_auxv_cache_inf): Rewrite.
1784         (get_auxv_inferior_data, _initialize_auxv): Update.
1785
1786 2019-05-08  Tom Tromey  <tom@tromey.com>
1787
1788         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1789         (symfile_debug_objfile_data_key): Change type.
1790         (symfile_debug_installed, debug_qf_has_symbols)
1791         (debug_qf_find_last_source_symtab)
1792         (debug_qf_forget_cached_source_info)
1793         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1794         (debug_qf_print_stats, debug_qf_dump)
1795         (debug_qf_expand_symtabs_for_function)
1796         (debug_qf_expand_all_symtabs)
1797         (debug_qf_expand_symtabs_with_fullname)
1798         (debug_qf_map_matching_symbols)
1799         (debug_qf_expand_symtabs_matching)
1800         (debug_qf_find_pc_sect_compunit_symtab)
1801         (debug_qf_map_symbol_filenames)
1802         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1803         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1804         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1805         (debug_sym_read_linetable, debug_sym_relocate): Update.
1806         (symfile_debug_free_objfile): Remove.
1807         (install_symfile_debug_logging, _initialize_symfile_debug):
1808         Update.
1809
1810 2019-05-08  Tom Tromey  <tom@tromey.com>
1811
1812         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1813         allocate_on_obstack.
1814         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1815         (get_dwarf2_per_objfile): Update.
1816         (set_dwarf2_per_objfile): Remove.
1817         (dwarf2_has_info, dwarf2_get_section_info): Update.
1818         (dwarf2_free_objfile): Remove.
1819         (_initialize_dwarf2_read): Update.
1820
1821 2019-05-08  Tom Tromey  <tom@tromey.com>
1822
1823         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1824         initializers.
1825         <unsupported_script_warning_printed,
1826         script_not_found_warning_printed>: Now bool.
1827         (auto_load_pspace_data): Change type.
1828         (~auto_load_pspace_info): Rename from
1829         auto_load_pspace_data_cleanup.
1830         (get_auto_load_pspace_data, init_loaded_scripts_info)
1831         (clear_section_scripts, maybe_print_unsupported_script_warning)
1832         (maybe_print_script_not_found_warning, _initialize_auto_load):
1833         Update.
1834
1835 2019-05-08  Tom Tromey  <tom@tromey.com>
1836
1837         * objfiles.c (objfile_pspace_info): Add destructor and
1838         initializers.
1839         (objfiles_pspace_data): Change type.
1840         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1841         (get_objfile_pspace_data): Update.
1842         (objfiles_bfd_data): Change type.
1843         (get_objfile_bfd_data): Update.
1844         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1845
1846 2019-05-08  Tom Tromey  <tom@tromey.com>
1847
1848         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1849         Change type.
1850         (get_catch_syscall_inferior_data): Update.
1851         (catch_syscall_inferior_data_cleanup): Remove.
1852         (_initialize_break_catch_syscall): Update.
1853
1854 2019-05-08  Tom Tromey  <tom@tromey.com>
1855
1856         * inflow.c (struct terminal_info): Add destructor and
1857         initializers.
1858         (inflow_inferior_data): Change type.
1859         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1860         (get_inflow_inferior_data, inflow_inferior_exit)
1861         (swap_terminal_info, _initialize_inflow): Update.
1862
1863 2019-05-08  Tom Tromey  <tom@tromey.com>
1864
1865         * target-dcache.c (target_dcache_cleanup): Remove.
1866         (target_dcache_aspace_key): Change type.
1867         (target_dcache_init_p, target_dcache_invalidate)
1868         (target_dcache_get, target_dcache_get_or_init)
1869         (_initialize_target_dcache): Update.
1870         * dcache.h (struct dcache_deleter): New.
1871
1872 2019-05-08  Tom Tromey  <tom@tromey.com>
1873
1874         * symtab.c (struct symbol_cache): Add destructor and
1875         initializers.
1876         (symbol_cache_key): Move.  Change type.
1877         (make_symbol_cache, free_symbol_cache): Remove.
1878         (get_symbol_cache): Update.
1879         (symbol_cache_cleanup): Remove.
1880         (ALL_PSPACES, symbol_cache_flush)
1881         (maintenance_print_symbol_cache)
1882         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1883         Update.
1884
1885 2019-05-08  Tom Tromey  <tom@tromey.com>
1886
1887         * symtab.c (struct main_info): Add destructor and initializers.
1888         (main_progspace_key): Move.  Change type.
1889         (get_main_info): Update.
1890         (main_info_cleanup): Remove.
1891         (_initialize_symtab): Update.
1892
1893 2019-05-08  Tom Tromey  <tom@tromey.com>
1894
1895         * registry.h (DECLARE_REGISTRY): Define the _key class.
1896
1897 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * NEWS: Merge two 'New commands' sections.
1900
1901 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1902
1903         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1904         parameter and use Ada language definition instead.
1905         (ada_val_print_ptr): Remove unused language parameter.
1906         (ada_val_print_num): Remove language parameter and use Ada language
1907         definition instead.
1908         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1909         parameter.
1910         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1911         parameter and use Ada language definition instead.
1912         (ada_val_print_1): Update all ada_val_print_xxx calls.
1913         Remove language parameter.
1914         (ada_val_print): Update ada_val_print_1 call.
1915
1916 2019-05-08  Tom Tromey  <tromey@adacore.com>
1917
1918         * remote.c (remote_hw_watchpoint_limit)
1919         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1920         Now static.
1921
1922 2019-05-08  Tom Tromey  <tromey@adacore.com>
1923
1924         * maint.c (_initialize_maint_cmds): Move initialization code to
1925         remote.c.
1926         (watchdog, show_watchdog): Move to remote.c.
1927         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1928         "watchdog" static.
1929         (_initialize_remote): Move initialization code from maint.c.
1930         * defs.h (watchdog): Don't declare.
1931
1932 2019-05-08  Tom Tromey  <tromey@adacore.com>
1933
1934         * tui/tui-interp.c: Include main.h.
1935         * interps.c: Include main.h.
1936         * main.h (interpreter_p): Declare.
1937         * defs.h (interpreter_p): Don't declare.
1938
1939 2019-05-08  Tom Tromey  <tromey@adacore.com>
1940
1941         * dwarf2loc.c: Include dwarf2read.h.
1942         * defs.h (read_unsigned_leb128): Don't declare.
1943         * dwarf2read.h (read_unsigned_leb128): Declare.
1944
1945 2019-05-08  Tom Tromey  <tromey@adacore.com>
1946
1947         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1948         method.
1949
1950 2019-05-08  Tom Tromey  <tromey@adacore.com>
1951
1952         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1953         when no wrap column is set.
1954
1955 2019-05-08  Tom Tromey  <tromey@adacore.com>
1956
1957         * c-lang.c (c_get_string): Handle non-C-style arrays.
1958
1959 2019-05-08  Tom Tromey  <tromey@adacore.com>
1960
1961         * typeprint.c (print_offset_data::update): Print the bit offset,
1962         not the number of bits remaining.
1963
1964 2019-05-08  Tom Tromey  <tromey@adacore.com>
1965
1966         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1967         padding at end of comment.
1968
1969 2019-05-08  Tom Tromey  <tromey@adacore.com>
1970
1971         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1972         Compare main types.
1973
1974 2019-05-06  Tom Tromey  <tom@tromey.com>
1975
1976         * common/scoped_mmap.c: Include common-defs.h.
1977         * common/scoped_mmap.h: Don't include config.h.
1978
1979 2019-05-04  Tom Tromey  <tom@tromey.com>
1980
1981         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1982         (struct aarch64_call_info): Add initializers.
1983         <si>: Now a std::vector.
1984         (pass_on_stack, aarch64_push_dummy_call): Update.
1985
1986 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1987             Tom Tromey  <tom@tromey.com>
1988
1989         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1990         (ppc_threads): Now a std::vector.  Now static.
1991         (hwdebug_find_thread_points_by_tid)
1992         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1993         Update.
1994
1995 2019-05-04  Tom Tromey  <tom@tromey.com>
1996
1997         * arc-tdep.c (arc_tdesc_init): Return bool.
1998
1999 2019-05-04  Tom Tromey  <tom@tromey.com>
2000
2001         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2002         Use gdb_assert_not_reached.
2003
2004 2019-05-04  Tom Tromey  <tom@tromey.com>
2005
2006         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2007         "false".
2008
2009 2019-05-04  Tom Tromey  <tom@tromey.com>
2010
2011         * arc-tdep.c (arc_tdesc_init): Use bool.
2012
2013 2019-05-04  Tom Tromey  <tom@tromey.com>
2014
2015         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2016
2017 2019-05-04  Tom Tromey  <tom@tromey.com>
2018
2019         * cli/cli-cmds.c (valid_command_p): Return bool.
2020
2021 2019-05-04  Tom Tromey  <tom@tromey.com>
2022
2023         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2024         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2025
2026 2019-05-04  Raul Tambre  <raul@tambre.ee>
2027
2028         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2029         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2030         operator for comparison.
2031
2032 2019-05-04  Tom Tromey  <tom@tromey.com>
2033
2034         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2035         (lookup_partial_symbol, print_partial_symbols)
2036         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2037         (psymbol_compare): Update.
2038         (add_psymbol_to_bcache): Clear the entire psymbol.
2039         (maintenance_check_psymtabs): Update.
2040         * psympriv.h (struct partial_symbol): Don't derive from
2041         general_symbol_info.
2042         <obj_section, unrelocated_address, address,
2043         set_unrelocated_address>: Update.
2044         <ginfo>: New member.
2045         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2046         (debug_names::write_psymbols): Update.
2047
2048 2019-05-04  Tom de Vries  <tdevries@suse.de>
2049
2050         * contrib/cc-with-tweaks.sh: Support -n arg.
2051
2052 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2053
2054         * corelow.c (core_target::detach): Ensure frame cache and
2055         register caches are cleared.
2056         inferior.c (exit_inferior_1): Likewise.
2057
2058 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2059             Tom Tromey  <tom@tromey.com>
2060
2061         * dictionary.c (collate_pending_symbols_by_language): Remove
2062         "struct" from foreach.
2063         * symtab.c (lookup_global_symbol_from_objfile)
2064         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2065         foreach.
2066         * ser-tcp.c (net_open): Remove "struct" from foreach.
2067         * objfiles.c (objfile_relocate, objfile_rebase)
2068         (objfile_has_symbols): Remove "struct" from foreach.
2069         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2070         from foreach.
2071         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2072         foreach.
2073         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2074         "struct" from foreach.
2075         * ada-lang.c (create_excep_cond_exprs)
2076         (ada_exception_catchpoint_cond_string): Remove "struct" from
2077         foreach.
2078
2079 2019-05-03  Tom Tromey  <tromey@adacore.com>
2080
2081         * ada-exp.y (convert_char_literal): Check suffix of each
2082         enumerator.
2083
2084 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2085
2086         PR ada/21406:
2087         * ada-exp.y (yywrap): Don't define.
2088         * ada-lex.l (%option): Add noyywrap
2089         (yywrap): Remove.
2090
2091 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2092
2093         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2094         _WIN32_WINNT to the XP level, unless already defined to a higher
2095         level.
2096
2097         * unittests/parse-connection-spec-selftests.c:
2098         * ser-tcp.c:
2099         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2100         override.
2101
2102         * symfile.c (find_separate_debug_file): Remove colon from the
2103         drive spec of DOS/Windows file names of the target, so that the
2104         file name produced from DEBUGDIR and the target's directory will
2105         be valid on DOS/Windows systems.
2106
2107 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         * rust-lang.c (val_print_struct): Handle printing structures
2110         containing strings.
2111
2112 2019-05-02  Tom Tromey  <tromey@adacore.com>
2113
2114         * valarith.c (_initialize_valarith): Remove.
2115
2116 2019-05-01  Tom Tromey  <tromey@adacore.com>
2117
2118         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2119         bitfields.
2120
2121 2019-05-01  Tom Tromey  <tromey@adacore.com>
2122
2123         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2124         for big-endian copies.
2125
2126 2019-04-30  Ali Tamur  <tamur@google.com>
2127         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2128         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2129         (read_3_bytes): New function.
2130
2131 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2132
2133         * windows-nat.c (main_thread_id): Delete.
2134         (handle_output_debug_string): Replace main_thread_id by
2135         current_event.dwThreadId.
2136         (fake_create_process): Likewise.
2137         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2138         Do not set main_thread_id.
2139         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2140         current_event.dwThreadId.
2141         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2142
2143 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2144
2145         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2146         Use current_event.dwThreadId instead of main_thread_id.
2147
2148 2019-04-30  Tom Tromey  <tromey@adacore.com>
2149
2150         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2151         (create_excep_cond_exprs): Iterate over program spaces.
2152         (ada_exception_catchpoint_cond_string): Examine all minimal
2153         symbols for exception types.
2154
2155 2019-04-30  Tom Tromey  <tromey@adacore.com>
2156
2157         PR c++/24470:
2158         * dwarf2read.c (process_structure_scope): Handle case where type
2159         has template parameters but no symbol was created.
2160
2161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2162             Chris January  <chris.january@arm.com>
2163
2164         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2165         qualifier.
2166         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2167
2168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * f-typeprint.c (f_print_type): Update rules for printing
2171         whitespace.
2172         (f_type_print_varspec_suffix): Likewise.
2173
2174 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2175             Chris January  <chris.january@arm.com>
2176
2177         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2178         function arguments.
2179
2180 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * f-lang.c (build_fortran_types): Change name of void type to
2183         lower case.
2184         * f-typeprint.c (f_type_print_base): Print the name of the void
2185         type, rather than a fixed string.
2186         * f-valprint.c (f_decorations): Use lower case void string.
2187
2188 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2189             Chris January  <chris.january@arm.com>
2190
2191         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2192         types for Fortran.
2193
2194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2195             Chris January  <chris.january@arm.com>
2196             David Lecomber  <david.lecomber@arm.com>
2197
2198         * f-exp.y (BINOP_INTRINSIC): New token.
2199         (exp): New parser rule handling BINOP_INTRINSIC.
2200         (f77_keywords): Add new builtin procedures.
2201         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2202         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2203         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2204         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2205         (print_unop_subexp_f): New function.
2206         (print_binop_subexp_f): New function.
2207         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2208         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2209         (dump_subexp_body_f): Likewise.
2210         (operator_check_f): Likewise.
2211         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2212         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2213
2214 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2217         UNOP_KIND.
2218         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2219         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2220         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2221         (operator_length_f): New fuction.
2222         (print_subexp_f): New function.
2223         (op_name_f): New function.
2224         (dump_subexp_body_f): New function.
2225         (operator_check_f): New function.
2226         (exp_descriptor_f): Replace standard expression handling functions
2227         with new functions.
2228         * gdb/fortran-operator.def: New file.
2229         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2230         * gdb/std-operator.def: Remove UNOP_KIND.
2231
2232 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * std-operator.def: Remove unbalanced, stray double quote
2235         character.
2236
2237 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2238             Chris January  <chris.january@arm.com>
2239             Daniel Everett  <daniel.everett@arm.com>
2240             Nick Forrington  <nick.forrington@arm.com>
2241             Richard Bunt  <richard.bunt@arm.com>
2242
2243         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2244         of depth when printing anonymous structs or unions.
2245         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2246         Don't print either the top-level value, or the children if the
2247         max-depth is exceeded.
2248         (ppscm_print_children): When printing the key of a map, allow one
2249         extra level of depth.
2250         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2251         print either the top-level value, or the children if the max-depth
2252         is exceeded.
2253         (print_children): When printing the key of a map, allow one extra
2254         level of depth.
2255         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2256         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2257         (user_print_options): Initialise max_depth field.
2258         (val_print_scalar_or_string_type_p): New function.
2259         (val_print): Check to see if the max depth has been reached.
2260         (val_print_check_max_depth): Define new function.
2261         (show_print_max_depth): New function.
2262         (_initialize_valprint): Add 'print max-depth' option.
2263         * valprint.h (struct value_print_options) <max_depth>: New field.
2264         (val_print_check_max_depth): Declare new function.
2265         * NEWS: Document new feature.
2266
2267 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * ada-lang.c (ada_language_defn): Initialise new field.
2270         * c-lang.c (c_is_string_type_p): New function.
2271         (c_language_defn): Initialise new field.
2272         (cplus_language_defn): Initialise new field.
2273         (asm_language_defn): Initialise new field.
2274         (minimal_language_defn): Initialise new field.
2275         * c-lang.h (c_is_string_type_p): Declare new function.
2276         * d-lang.c (d_language_defn): Initialise new field.
2277         * f-lang.c (f_is_string_type_p): New function.
2278         (f_language_defn): Initialise new field.
2279         * go-lang.c (go_is_string_type_p): New function.
2280         (go_language_defn): Initialise new field.
2281         * language.c (default_is_string_type_p): New function.
2282         (unknown_language_defn): Initialise new field.
2283         (auto_language_defn): Initialise new field.
2284         * language.h (struct language_defn) <la_is_string_type_p>: New
2285         member variable.
2286         (default_is_string_type_p): Declare new function.
2287         * m2-lang.c (m2_language_defn): Initialise new field.
2288         * objc-lang.c (objc_language_defn): Initialise new field.
2289         * opencl-lang.c (opencl_language_defn): Initialise new field.
2290         * p-lang.c (pascal_is_string_type_p): New function.
2291         (pascal_language_defn): Initialise new field.
2292         * rust-lang.c (rust_is_string_type_p): New function.
2293         (rust_language_defn): Initialise new field.
2294
2295 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2298         New field.
2299         * ada-lang.c (ada_language_defn): Initialise new field.
2300         * c-lang.c (c_language_defn): Likewise.
2301         (cplus_language_defn): Likewise.
2302         (asm_language_defn): Likewise.
2303         (minimal_language_defn): Likewise.
2304         * d-lang.c (d_language_defn): Likewise.
2305         * f-lang.c (f_language_defn): Likewise.
2306         * go-lang.c (go_language_defn): Likewise.
2307         * language.c (unknown_language_defn): Likewise.
2308         (auto_language_defn): Likewise.
2309         * m2-lang.c (m2_language_defn): Likewise.
2310         * objc-lang.c (objc_language_defn): Likewise.
2311         * opencl-lang.c (opencl_language_defn): Likewise.
2312         * p-lang.c (pascal_language_defn): Likewise.
2313         * rust-lang.c (rust_language_defn): Likewise.
2314
2315 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * ada-lang.c (ada_is_character_type): Change return type to bool.
2318         (ada_is_string_type): Likewise.
2319         * ada-lang.h (ada_is_character_type): Update declaration
2320         (ada_is_string_type): Likewise.
2321
2322 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         Support style in 'frame|thread apply'
2325
2326         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2327         * record.c (record_start, record_stop): Update callers of
2328         execute_command_to_string with false.
2329         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2330         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2331         methods.
2332         (class string_file): New constructor with term_out parameter.
2333         Override methods term_out and can_emit_style_escape.  New member
2334         term_out.
2335         (class stdio_file): Override can_emit_style_escape.
2336         (class tee_file): Override term_out and can_emit_style_escape.
2337         * utils.h (can_emit_style_escape): Remove.
2338         * utils.c (can_emit_style_escape): Likewise.
2339         Update all callers of can_emit_style_escape (SOMESTREAM) to
2340         SOMESTREAM->can_emit_style_escape.
2341         * source-cache.c (source_cache::get_source_lines): Likewise.
2342         * stack.c (frame_apply_command_count): Call execute_command_to_string
2343         passing the term_out characteristic of the current gdb_stdout.
2344         * thread.c (thr_try_catch_cmd): Likewise.
2345         * top.c (execute_command_to_string): pass term_out parameter
2346         to construct the string_file for the command output.
2347         * ui-file.c (term_cli_styling): New function (most code moved
2348         from utils.c can_emit_style_escape).
2349         (string_file::string_file, string_file::can_emit_style_escape,
2350         stdio_file::can_emit_style_escape, tee_file::term_out,
2351         tee_file::can_emit_style_escape): New functions.
2352
2353 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * NEWS: Mention the new set|show may-call-functions.
2356         * infcall.c (may_call_functions_p): New variable.
2357         (show_may_call_functions_p): New function.
2358         (call_function_by_hand_dummy): Throws an error if not
2359         may-call-functions.
2360         (_initialize_infcall): Call add_setshow_boolean_cmd for
2361         may-call-functions.
2362
2363 2019-04-25  Keith Seitz  <keiths@redhat.com>
2364
2365         PR c++/24367
2366         * cp-support.c (inspect_type): Don't attempt substitutions
2367         of symbol with the same name.
2368
2369 2019-04-25  Tom Tromey  <tromey@adacore.com>
2370
2371         PR gdb/24475:
2372         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2373         static.
2374
2375 2019-04-25  Tom Tromey  <tromey@adacore.com>
2376
2377         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2378         rvalue reference.
2379         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2380         (gdb_xml_parser::parse): Use std::move.
2381         * python/python-internal.h (gdbpy_convert_exception): Take a const
2382         reference.
2383         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2384         std::move.
2385         * python/py-utils.c (gdbpy_convert_exception): Take a const
2386         reference.
2387         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2388         Use std::move.
2389         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2390         Use std::move.
2391         * mi/mi-main.c (mi_print_exception): Take a const reference.
2392         * main.c (handle_command_errors): Take a const reference.
2393         * linespec.c (parse_linespec): Use std::move.
2394         * infcall.c (run_inferior_call): Use std::move.
2395         (call_function_by_hand_dummy): Use std::move.
2396         * exec.c (try_open_exec_file): Use std::move.
2397         * exceptions.h (exception_print, exception_fprintf)
2398         (exception_print_same): Update.
2399         * exceptions.c (print_exception, exception_print)
2400         (exception_fprintf, exception_print_same): Change parameters to
2401         const reference.
2402         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2403         * common/new-op.c: Use std::move.
2404         * common/common-exceptions.h (struct gdb_exception): Add move
2405         constructor.
2406         (struct gdb_exception_error, struct gdb_exception_quit, struct
2407         gdb_quit_bad_alloc): Change constructor to move constructor.
2408         (throw_exception): Change parameter to rvalue reference.
2409         * common/common-exceptions.c (throw_exception): Take rvalue
2410         reference.
2411         * cli/cli-interp.c (safe_execute_command): Use std::move.
2412         * breakpoint.c (insert_bp_location, location_to_sals): Use
2413         std::move.
2414
2415 2019-04-25  Tom Tromey  <tromey@adacore.com>
2416
2417         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2418         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2419         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2420         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2421         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2422         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2423         guile/scm-value.c: Use unpack.
2424         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2425         gdbscm_gdb_exception.
2426         (gdbscm_throw_gdb_exception): Likewise.
2427         (struct gdbscm_gdb_exception): New.
2428         (unpack): New function.
2429         (gdbscm_wrap): Use unpack.
2430
2431 2019-04-25  Tom Tromey  <tromey@adacore.com>
2432
2433         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2434         (gdb_rl_callback_handler): Use std::move.
2435         * common/common-exceptions.h (struct gdb_exception): Add move
2436         assignment operator.
2437         (throw_exception_sjlj): Change "exception" to const reference.
2438         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2439         (throw_exception_sjlj): Change "exception" to const reference.
2440
2441 2019-04-25  Tom Tromey  <tromey@adacore.com>
2442
2443         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2444         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2445         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2446         Update.
2447         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2448         Update.
2449         * mi/mi-interp.c (mi_interp::exec): Update.
2450         * linespec.c (parse_linespec): Update.
2451         * infcall.c (run_inferior_call): Update.
2452         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2453         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2454         (gdbscm_lookup_global_symbol): Update.
2455         * guile/scm-param.c (gdbscm_parameter_value): Update.
2456         * guile/scm-frame.c (gdbscm_frame_read_register)
2457         (gdbscm_frame_read_var): Update.
2458         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2459         * exec.c (try_open_exec_file): Update.
2460         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2461         (gdb_rl_callback_handler): Update.
2462         * common/common-exceptions.h (exception_none): Don't declare.
2463         * common/common-exceptions.c (exception_none): Don't define.
2464         (struct catcher) <exception>: Update.
2465         * cli/cli-interp.c (safe_execute_command): Update.
2466         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2467
2468 2019-04-25  Ali Tamur  <tamur@google.com>
2469
2470         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2471         (read_attribute_value): Likewise.
2472         (dwarf2_read_addr_index): Update comment.
2473         (read_str_index): Add DW_FORM_strx.
2474         (dwarf2_string_attr): Likewise.
2475         (dwarf2_const_value_attr): Likewise.
2476         (dump_die_shallow): Likewise.
2477         (dwarf2_fetch_constant_bytes): Likewise.
2478         (skip_form_bytes): Likewise.
2479         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2480
2481 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2482
2483         PR corefiles/11608
2484         PR corefiles/18187
2485         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2486         OFFSET.  Verify if current mapping contains an ELF header.
2487         (linux_find_memory_regions_full): Adjust call to
2488         dump_mapping_p.
2489
2490 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2491             Kang Li <kanglictf@gmail.com>
2492
2493         PR gdb/21600
2494
2495         * dwarf2-frame.c (read_initial_length): Be consistent about using
2496         unsigned representation of length.
2497         (decode_frame_entry_1): Likewise.  Check for wraparound of
2498         end pointer as well as buffer overflow.
2499
2500 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2501
2502         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2503         "vq".
2504
2505 2019-04-24  Tom Tromey  <tromey@adacore.com>
2506
2507         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2508
2509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * s12z-tdep.c (s12z_unwind_pc): Delete.
2512         (s12z_unwind_sp): Delete.
2513         (s12z_gdbarch_init): Don't register deleted functions with
2514         gdbarch.
2515
2516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         * rl78-tdep.c (rl78_unwind_sp): Delete.
2519         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2520
2521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2524         (xstormy16_unwind_pc): Delete.
2525         (xstormy16_dummy_id): Delete.
2526         (xstormy16_gdbarch_init): Don't register deleted functions with
2527         gdbarch.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * vax-tdep.c (vax_unwind_pc): Delete.
2532         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2533
2534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * v850-tdep.c (v850_unwind_sp): Delete.
2537         (v850_unwind_pc): Delete.
2538         (v850_dummy_id): Delete.
2539         (v850_gdbarch_init): Don't register deleted functions with
2540         gdbarch.
2541
2542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2545         (tilegx_unwind_pc): Delete.
2546         (tilegx_unwind_dummy_id): Delete.
2547         (tilegx_gdbarch_init): Don't register deleted functions with
2548         gdbarch.
2549
2550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2553         (tic6x_dummy_id): Delete.
2554         (tic6x_gdbarch_init): Don't register deleted functions with
2555         gdbarch.
2556
2557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * sparc-tdep.c (sparc_unwind_pc): Delete.
2560         (sparc32_gdbarch_init): Don't register deleted function with
2561         gdbarch.
2562
2563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * sh-tdep.c (sh_unwind_sp): Delete.
2566         (sh_unwind_pc): Delete.
2567         (sh_dummy_id): Delete.
2568         (sh_gdbarch_init): Don't register deleted functions with
2569         gdbarch.
2570
2571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * score-tdep.c (score_unwind_sp): Delete.
2574         (score_unwind_pc): Delete.
2575         (score_dummy_id): Delete.
2576         (score_gdbarch_init): Don't register deleted functions with
2577         gdbarch.
2578
2579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * rx-tdep.c (rx_unwind_pc): Delete.
2582         (rx_unwind_sp): Delete.
2583         (rx_dummy_id): Delete.
2584         (rx_gdbarch_init): Don't register deleted functions with
2585         gdbarch.  Update comment.
2586
2587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2590         (rs6000_dummy_id): Delete.
2591         (rs6000_gdbarch_init): Don't register deleted functions with
2592         gdbarch.
2593
2594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2595
2596         * or1k-tdep.c (or1k_dummy_id): Delete.
2597         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2598
2599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * nios2-tdep.c (nios2_dummy_id): Delete.
2602         (nios2_unwind_sp): Delete.
2603         (nios2_gdbarch_init): Don't register deleted functions with
2604         gdbarch.
2605
2606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * nds32-tdep.c (nds32_dummy_id): Delete.
2609         (nds32_unwind_pc): Delete.
2610         (nds32_unwind_sp): Delete.
2611         (nds32_gdbarch_init): Don't register deleted functions with
2612         gdbarch.
2613
2614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * msp430-tdep.c (msp430_unwind_pc): Delete.
2617         (msp430_unwind_sp): Delete.
2618         (msp430_dummy_id): Delete.
2619         (msp430_gdbarch_init): Don't register deleted functions with
2620         gdbarch.
2621
2622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2623
2624         * moxie-tdep.c (moxie_unwind_sp): Delete.
2625         (moxie_unwind_pc): Delete.
2626         (moxie_dummy_id): Delete.
2627         (moxie_gdbarch_init): Don't register deleted functions with
2628         gdbarch.
2629
2630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2633         (mn10300_unwind_pc): Delete.
2634         (mn10300_unwind_sp): Delete.
2635         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2636         mn10300_unwind_sp.
2637         (mn10300_frame_unwind_init): Don't register deleted functions with
2638         gdbarch.
2639
2640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * mep-tdep.c (mep_unwind_pc): Delete.
2643         (mep_unwind_sp): Delete.
2644         (mep_dummy_id): Delete.
2645         (mep_gdbarch_init): Don't register deleted functions with
2646         gdbarch.
2647
2648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2651         (m68hc11_unwind_sp): Delete.
2652         (m68hc11_gdbarch_init): Don't register deleted functions with
2653         gdbarch.
2654
2655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * m32r-tdep.c (m32r_unwind_sp): Delete.
2658         (m32r_unwind_pc): Delete.
2659         (m32r_dummy_id): Delete.
2660         (m32r_gdbarch_init): Don't register deleted functions with
2661         gdbarch.
2662
2663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * m32c-tdep.c (m32c_unwind_pc): Delete.
2666         (m32c_unwind_sp): Delete.
2667         (m32c_dummy_id): Delete.
2668         (m32c_gdbarch_init): Don't register deleted functions with
2669         gdbarch.
2670
2671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2672
2673         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2674         (lm32_unwind_pc): Delete.
2675         (lm32_dummy_id): Delete.
2676         (lm32_gdbarch_init): Don't register deleted functions with
2677         gdbarch.
2678
2679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2682         (iq2000_unwind_pc): Delete.
2683         (iq2000_dummy_id): Delete.
2684         (iq2000_gdbarch_init): Don't register deleted functions with
2685         gdbarch.
2686
2687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * nds32-tdep.c (nds32_type_align): Delete.
2690         (nds32_push_dummy_call): Use type_align instead.
2691
2692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * arm-tdep.c (arm_type_align): Only handle vector override case.
2695         (arm_push_dummy_call): Use type_align.
2696         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2697
2698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2701         case.
2702         (pass_on_stack): Use type_align.
2703         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2704         function.
2705
2706 2019-04-23  Tom Tromey  <tromey@adacore.com>
2707
2708         * dwarf2read.c (line_header::file_name_at): Remove unused
2709         overload.
2710
2711 2019-04-23  Tom de Vries  <tdevries@suse.de>
2712
2713         PR gdb/24438
2714         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2715         invocation.
2716
2717
2718 2019-03-27  Ali Tamur  <tamur@google.com>
2719
2720         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2721         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2722         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2723         (dwarf_expr_context::get_addr_index): Likewise
2724         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2725         (symbol_needs_eval_context::get_addr_index): Likewise
2726         (disassemble_dwarf_expression): Add DW_OP_addrx
2727         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2728         (read_cutu_die_from_dwo): Update comment
2729         (skip_one_die): Add DW_FORM_addrx
2730         (read_attribute_value): Likewise
2731         (var_decode_location): Add DW_OP_addrx
2732         (dwarf2_const_value_attr): Add DW_FORM_addrx
2733         (dump_die_shallow): Likewise
2734         (dwarf2_fetch_constant_bytes): Likewise
2735         (decode_locdesc): Add DW_OP_addrx
2736         (skip_form_bytes): Add DW_FORM_addrx
2737
2738 2019-04-22  Ali Tamur  <tamur@google.com>
2739
2740         * MAINTAINERS (Write After Approval): Add self.
2741
2742 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2743
2744         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2745         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2746         (open_symbol_file_object): Likewise.
2747         (svr4_default_sos): Add info parameter.
2748         (svr4_read_so_list): Likewise.
2749         (svr4_current_sos_direct): Adjust functions calls to pass down
2750         info.
2751         (svr4_current_sos_1): Add info parameter.
2752         (svr4_current_sos): Call get_svr4_info, pass info down to
2753         svr4_current_sos_1.
2754         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2755         get_svr4_info.
2756         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2757         get_svr4_info.
2758         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2759         to get_svr4_info.
2760         (probes_table_remove_objfile_probes): Likewise.
2761         (register_solib_event_probe): Add info parameter.
2762         (solist_update_incremental): Pass info parameter down to
2763         svr4_read_so_list.
2764         (disable_probes_interface): Add info parameter.
2765         (svr4_handle_solib_event): Pass current_program_space to
2766         get_svr4_info.  Adjust disable_probes_interface cleanup.
2767         (svr4_create_probe_breakpoints): Add info parameter, pass it
2768         down to register_solib_event_probe.
2769         (svr4_create_solib_event_breakpoints): Add info parameter,
2770         pass it down to svr4_create_probe_breakpoints.
2771         (enable_break): Pass info down to
2772         svr4_create_solib_event_breakpoints.
2773         (svr4_solib_create_inferior_hook): Pass current_program_space to
2774         get_svr4_info.
2775         (svr4_clear_solib): Likewise.
2776
2777 2019-04-22  Pedro Alves  <palves@redhat.com>
2778
2779         * solib-svr4.c (svr4_free_objfile_observer): New.
2780         (probe_and_action::objfile): New field.
2781         (probes_table_htab_remove_objfile_probes)
2782         (probes_table_remove_objfile_probes): New functions.
2783         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2784         in the new probe_and_action.  Don't store the probe in 'lookup'.
2785         (svr4_create_probe_breakpoints): Pass objfile to
2786         register_solib_event_probe.
2787         (_initialize_svr4_solib): Register a free_objfile observer.
2788
2789 2019-04-19  Tom Tromey  <tom@tromey.com>
2790
2791         * common/queue.h: Remove.
2792
2793 2019-04-19  Tom Tromey  <tom@tromey.com>
2794
2795         * event-loop.c: Don't include "common/queue.h".
2796
2797 2019-04-19  Tom Tromey  <tom@tromey.com>
2798
2799         * remote.c (remote_target): Use delete.
2800         * remote-notif.h: Include <list>, not "common/queue.h".
2801         (notif_client_p): Remove typedef.
2802         (remote_notif_state): Add constructor, destructor, initializer.
2803         <notif_queue>: Now a std::list.
2804         (remote_notif_state_xfree): Don't declare.
2805         * remote-notif.c (remote_notif_process, handle_notification)
2806         (remote_notif_state_allocate): Update.
2807         (~remote_notif_state): Rename from remote_notif_state_xfree.
2808
2809 2019-04-19  Tom Tromey  <tom@tromey.com>
2810
2811         * symfile.c (reread_symbols): Update.
2812         * objfiles.c (objfile_register_static_link)
2813         (objfile_lookup_static_link): Update
2814         (~objfile) Don't delete static_links.
2815         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2816
2817 2019-04-19  Tom Tromey  <tom@tromey.com>
2818
2819         * type-stack.h (struct type_stack) <insert>: Constify string.
2820         * type-stack.c (type_stack::insert): Constify string.
2821         * gdbtypes.h (lookup_template_type): Update.
2822         (address_space_name_to_int): Update.
2823         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2824         const.
2825         (lookup_template_type): Make name const.
2826         * c-exp.y: Update rules.
2827         (lex_one_token, classify_name, classify_inner_name)
2828         (c_print_token): Update.
2829         * p-exp.y: Update rules.
2830         (yylex): Update.
2831         * f-exp.y: Update rules.
2832         (yylex): Update.
2833         * d-exp.y: Update rules.
2834         (lex_one_token, classify_name, classify_inner_name): Update.
2835         * parse.c (write_dollar_variable, copy_name): Return std::string.
2836         * parser-defs.h (copy_name): Change return type.
2837         * m2-exp.y: Update rules.
2838         (yylex): Update.
2839         * go-exp.y (lex_one_token): Update.
2840         Update rules.
2841         (classify_unsafe_function, classify_packaged_name)
2842         (classify_name, yylex): Update.
2843
2844 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2845
2846         * configure.ac: add --enable-source-highlight switch.
2847         * configure: Regenerate.
2848         * top.c (print_gdb_version): plumb --enable-source-highlight
2849         status to "show configuration".
2850
2851 2019-04-19  Tom Tromey  <tromey@adacore.com>
2852
2853         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2854         Check ADA_TYPE_P.
2855         (empty_record, ada_template_to_fixed_record_type_1)
2856         (template_to_static_fixed_type)
2857         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2858         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2859         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2860         macros.
2861
2862 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2863
2864         PR symtab/24423:
2865         * source.c (print_source_lines_base): Advance "iter" when a
2866         control character is seen.
2867
2868 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2869
2870         * inferior.h (struct infcall_suspend_state_deleter):
2871         Catch exception in destructor to avoid crash.
2872
2873 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2874
2875         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2876         close to the add_com "shell".
2877
2878 2019-04-18  Tom Tromey  <tromey@adacore.com>
2879
2880         * process-stratum-target.h (class process_stratum_target)
2881         <stratum>: Add "final".
2882
2883 2019-04-17  Tom Tromey  <tromey@adacore.com>
2884
2885         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2886         against nullptr before use.
2887
2888 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2891
2892 2019-04-17  Jim Wilson  <jimw@sifive.com>
2893             Andrew Burgess  <andrew.burgess@embecosm.com>
2894
2895         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2896         code read might fail, assume 4-byte breakpoint in that case.
2897
2898 2019-04-15  Leszek Swirski  <leszeks@google.com>
2899
2900         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2901         rather than a hand-rolled POD check when checking for forced MEMORY
2902         classification.
2903
2904 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2905
2906         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2907         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2908         function.
2909         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2910         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2911         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2912         declaration.
2913
2914 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2915
2916         * aarch64-linux-nat.c
2917         (aarch64_linux_nat_target::thread_architecture): Add override.
2918         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2919         each VQ.
2920
2921 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2922
2923         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2924
2925 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2926
2927         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2928         target types of size 96-bits, add some additional comments, and
2929         check that the builtin type we found was the correct size.
2930
2931 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2932
2933         * utils.c (prompt_for_continue): Don't restore the styling at the
2934         end, as applied_style has the wrong value.  This fixes styling in
2935         long lists of file names that are interrupted by the "Continue?"
2936         prompt.
2937
2938 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2941         * c-lang.c (c_language_defn): Likewise.
2942         (cplus_language_defn): Likewise.
2943         (asm_language_defn): Likewise.
2944         (minimal_language_defn): Likewise.
2945         * d-lang.c (d_language_defn): Likewise.
2946         * f-lang.c (f_language_defn): Likewise.
2947         * go-lang.c (go_language_defn): Likewise.
2948         * language.c (unknown_language_defn): Likewise.
2949         (auto_language_defn): Likewise.
2950         * language.h (struct language_defn): Remove la_magic field.
2951         (LANG_MAGIC): Delete.
2952         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2953         * objc-lang.c (objc_language_defn): Likewise.
2954         * opencl-lang.c (opencl_language_defn): Likewise.
2955         * p-lang.c (pascal_language_defn): Likewise.
2956         * rust-lang.c (rust_language_defn): Likewise.
2957
2958 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2959
2960         * riscv-tdep.c (riscv_type_align): New function.
2961         (riscv_type_alignment): Delete.
2962         (riscv_arg_location): Use 'type_align'.
2963         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2964
2965 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * gdbtypes.c (type_align): A struct with no non-static fields also
2968         has alignment of 1.
2969
2970 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2973         component to 0.
2974         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2975         member.
2976         (riscv_struct_info::analyse): New implementation using new
2977         analyse_inner member function.
2978         (riscv_struct_info::field_offset): New member function.
2979         (riscv_struct_info::m_offsets): New member variable.
2980         (riscv_struct_info::analyse_inner): New private member function,
2981         takes the old implementation of riscv_struct_info::analyse but
2982         extended to track field offsets.
2983         (riscv_call_arg_struct): Update the struct folding special cases
2984         to handle cases where empty C++ structs, which are non-zero
2985         length, are found.
2986         (riscv_arg_location): Initialise the length of each location, a
2987         non-zero length now indicates the location is in use.
2988         (riscv_push_dummy_call): Allow for the first location having a
2989         non-zero offset when setting up arguments.
2990         (riscv_return_value): Likewise, but for return values.
2991
2992 2019-04-11  Tom Tromey  <tromey@adacore.com>
2993
2994         * utils.c (internal_vproblem): Make "msg" const.
2995
2996 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2999         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3000         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3001         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3002
3003 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3004
3005         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3006         function.
3007         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3008         of amd64_collect_native_gregset.
3009         (amd64_linux_nat_target::store_registers): Likewise.
3010
3011 2019-04-10  Tom Tromey  <tom@tromey.com>
3012
3013         * symtab.c (lookup_global_symbol_from_objfile)
3014         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3015         * objfiles.h (class separate_debug_iterator): New.
3016         (class separate_debug_range): New.
3017         (struct objfile) <separate_debug_objfiles>: New method.
3018         (objfile_separate_debug_iterate): Don't declare.
3019         * objfiles.c (separate_debug_iterator::operator++): Rename from
3020         objfile_separate_debug_iterate.
3021         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3022         iterator.
3023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3024         iterator.
3025
3026 2019-04-10  Tom Tromey  <tom@tromey.com>
3027
3028         * symfile.c (reread_symbols): Remove old comment.
3029         * objfiles.c (free_all_objfiles): Fix a typo.
3030
3031 2019-04-10  Tom Tromey  <tom@tromey.com>
3032
3033         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3034         * minsyms.c (lookup_minimal_symbol): Use foreach.
3035         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3036         (lookup_minimal_symbol_solib_trampoline): Likewise.
3037         * symfile.c (reread_symbols): Use foreach.
3038
3039 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3040             Tom Tromey  <tromey@adacore.com>
3041
3042         PR rust/24414:
3043         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3044         (rust_lex_int_test): Change "value" to be LONGEST.
3045         (rust_lex_tests): Add test for long integer literal.
3046
3047 2019-04-09  Tom Tromey  <tromey@adacore.com>
3048
3049         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3050         to bool.
3051         (extended_remote_target::attach): Update.
3052         (remote_target::remote_notice_new_inferior): Update.
3053         (remote_target::add_current_inferior_and_thread): Update.
3054         * inferior.c (exit_inferior_1): Use "false".
3055         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3056
3057 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3058
3059         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3060         the "start" command.
3061
3062 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3063
3064         * python/py-inferior.c (infpy_thread_from_thread_handle):
3065         Adjust comments to reflect renaming of thread_from_thread_handle
3066         to thread_from_handle.  Adjust keywords.  Fix type error message.
3067         (inferior_object_methods): Add thread_from_handle.  Retain
3068         thread_from_thread_handle, but mark it as deprecated.
3069
3070 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3071
3072         * gdbthread.h (find_thread_by_handle): Revise declaration.
3073         * thread.c (find_thread_by_handle): Likewise.  Adjust
3074         implementation too.
3075         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3076         support for buffer objects as handles.
3077
3078 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3079
3080         * python/py-infthread.c (thpy_thread_handle): New function.
3081         (thread_object_methods): Register thpy_thread_handle.
3082
3083 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3084
3085         * gdbthread.h (thread_to_thread_handle): Declare.
3086         * thread.c (gdbtypes.h): Include.
3087         (thread_to_thread_handle): New function.
3088
3089         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3090         (target_thread_info_to_thread_handle): Declare.
3091         * target.c (target_thread_info_to_thread_handle): New function.
3092         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3093         * target-delegates.c: Regenerate.
3094
3095         * linux-thread-db.c (class thread_db_target): Add method
3096         thread_info_to_thread_handle.
3097         (thread_db_target::thread_info_to_thread_handle): Define.
3098         * remote.c (class remote_target): Add new method
3099         thread_info_to_thread_handle.
3100         (remote_target::thread_info_to_thread_handle): Define.
3101
3102 2019-04-08  Pedro Alves  <palves@redhat.com>
3103
3104         * common/common-exceptions.c (throw_exception): Don't create
3105         named object to throw; throw directly.
3106         (throw_it): Likewise.  Don't initialize gdb_exception::message
3107         here, with new; pass FMT and AP to the ctor instead.
3108         * common/common-exceptions.h: Include <string>.
3109         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3110         const char *, va_list)): New ctor.  Use std::make_shared.
3111         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3112         errors)): Delete.
3113         (gdb_exception_error::gdb_exception_error(enum errors, const char
3114         *, va_list)): New.
3115         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3116         Add assertion.
3117         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3118         errors)): Delete.
3119         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3120         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3121         Add assertion.
3122
3123 2019-04-08  Tom Tromey  <tom@tromey.com>
3124
3125         * valops.c (value_rtti_indirect_type): Replace throw_exception
3126         with throw.
3127         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3128         with throw.
3129         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3130         throw.
3131         * target.c (target_translate_tls_address): Replace throw_exception
3132         with throw.
3133         * stack.c (frame_apply_command_count): Replace throw_exception
3134         with throw.
3135         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3136         throw.
3137         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3138         with throw.
3139         * rs6000-tdep.c (rs6000_frame_cache)
3140         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3141         * remote.c: Replace throw_exception with throw.
3142         * record-full.c (record_full_message, record_full_wait_1)
3143         (record_full_restore): Replace throw_exception with throw.
3144         * record-btrace.c:
3145         (get_thread_current_frame_id, record_btrace_start_replaying)
3146         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3147         (cmd_record_btrace_start): Replace throw_exception with throw.
3148         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3149         throw.
3150         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3151         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3152         * linespec.c:
3153         (find_linespec_symbols): Replace throw_exception with throw.
3154         * infrun.c (displaced_step_prepare, resume): Replace
3155         throw_exception with throw.
3156         * infcmd.c (post_create_inferior): Replace throw_exception with
3157         throw.
3158         * inf-loop.c (inferior_event_handler): Replace throw_exception
3159         with throw.
3160         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3161         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3162         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3163         (get_prev_frame_always, get_frame_pc_if_available)
3164         (get_frame_address_in_block_if_available, get_frame_language):
3165         Replace throw_exception with throw.
3166         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3167         throw_exception with throw.
3168         * eval.c (fetch_subexp_value, evaluate_var_value)
3169         (evaluate_funcall, evaluate_subexp_standard): Replace
3170         throw_exception with throw.
3171         * dwarf2loc.c (call_site_find_chain)
3172         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3173         Replace throw_exception with throw.
3174         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3175         with throw.
3176         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3177         throw.
3178         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3179         * completer.c (complete_line_internal): Replace throw_exception
3180         with throw.
3181         * compile/compile-object-run.c (compile_object_run): Replace
3182         throw_exception with throw.
3183         * cli/cli-script.c (process_next_line): Replace throw_exception
3184         with throw.
3185         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3186         (btrace_enable, btrace_maint_update_pt_packets): Replace
3187         throw_exception with throw.
3188         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3189         throw_exception with throw.
3190         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3191         throw_exception with throw.
3192         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3193         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3194         * aarch64-tdep.c (aarch64_make_prologue_cache)
3195         (aarch64_make_stub_cache): Replace throw_exception with throw.
3196
3197 2019-04-08  Tom Tromey  <tom@tromey.com>
3198
3199         * common/common-exceptions.c (throw_exception): Rename from
3200         throw_exception_cxx.  Remove old copy.  Make argument const.
3201         (throw_it): Create and throw exception objects directly.
3202         * common/common-exceptions.h (throw_exception): Make argument
3203         const.
3204         (struct gdb_exception_error): Add constructor.
3205         (struct gdb_exception_quit): Add constructor.
3206
3207 2019-04-08  Tom Tromey  <tom@tromey.com>
3208
3209         * common/common-exceptions.h (exception_rethrow): Don't declare.
3210         (TRY_SJLJ): Update comment.
3211         (TRY, CATCH, END_CATCH): Remove.
3212         * common/common-exceptions.c (exception_rethrow): Remove.
3213
3214 2019-04-08  Tom Tromey  <tom@tromey.com>
3215
3216         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3217         Remove.
3218         (gdb_exception_error): Rename from
3219         gdb_exception_RETURN_MASK_ERROR.
3220         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3221         (gdb_quit_bad_alloc): Update.
3222         * aarch64-tdep.c: Update.
3223         * ada-lang.c: Update.
3224         * ada-typeprint.c: Update.
3225         * ada-valprint.c: Update.
3226         * amd64-tdep.c: Update.
3227         * arch-utils.c: Update.
3228         * break-catch-throw.c: Update.
3229         * breakpoint.c: Update.
3230         * btrace.c: Update.
3231         * c-varobj.c: Update.
3232         * cli/cli-cmds.c: Update.
3233         * cli/cli-interp.c: Update.
3234         * cli/cli-script.c: Update.
3235         * common/common-exceptions.c: Update.
3236         * common/new-op.c: Update.
3237         * common/selftest.c: Update.
3238         * compile/compile-c-symbols.c: Update.
3239         * compile/compile-cplus-symbols.c: Update.
3240         * compile/compile-object-load.c: Update.
3241         * compile/compile-object-run.c: Update.
3242         * completer.c: Update.
3243         * corelow.c: Update.
3244         * cp-abi.c: Update.
3245         * cp-support.c: Update.
3246         * cp-valprint.c: Update.
3247         * darwin-nat.c: Update.
3248         * disasm-selftests.c: Update.
3249         * dtrace-probe.c: Update.
3250         * dwarf-index-cache.c: Update.
3251         * dwarf-index-write.c: Update.
3252         * dwarf2-frame-tailcall.c: Update.
3253         * dwarf2-frame.c: Update.
3254         * dwarf2loc.c: Update.
3255         * dwarf2read.c: Update.
3256         * eval.c: Update.
3257         * event-loop.c: Update.
3258         * event-top.c: Update.
3259         * exec.c: Update.
3260         * f-valprint.c: Update.
3261         * fbsd-tdep.c: Update.
3262         * frame-unwind.c: Update.
3263         * frame.c: Update.
3264         * gdbtypes.c: Update.
3265         * gnu-v3-abi.c: Update.
3266         * guile/guile-internal.h: Update.
3267         * guile/scm-block.c: Update.
3268         * guile/scm-breakpoint.c: Update.
3269         * guile/scm-cmd.c: Update.
3270         * guile/scm-disasm.c: Update.
3271         * guile/scm-frame.c: Update.
3272         * guile/scm-lazy-string.c: Update.
3273         * guile/scm-math.c: Update.
3274         * guile/scm-param.c: Update.
3275         * guile/scm-ports.c: Update.
3276         * guile/scm-pretty-print.c: Update.
3277         * guile/scm-symbol.c: Update.
3278         * guile/scm-symtab.c: Update.
3279         * guile/scm-type.c: Update.
3280         * guile/scm-value.c: Update.
3281         * i386-linux-tdep.c: Update.
3282         * i386-tdep.c: Update.
3283         * inf-loop.c: Update.
3284         * infcall.c: Update.
3285         * infcmd.c: Update.
3286         * infrun.c: Update.
3287         * jit.c: Update.
3288         * language.c: Update.
3289         * linespec.c: Update.
3290         * linux-fork.c: Update.
3291         * linux-nat.c: Update.
3292         * linux-tdep.c: Update.
3293         * linux-thread-db.c: Update.
3294         * main.c: Update.
3295         * mi/mi-cmd-break.c: Update.
3296         * mi/mi-cmd-stack.c: Update.
3297         * mi/mi-interp.c: Update.
3298         * mi/mi-main.c: Update.
3299         * objc-lang.c: Update.
3300         * p-valprint.c: Update.
3301         * parse.c: Update.
3302         * ppc-linux-tdep.c: Update.
3303         * printcmd.c: Update.
3304         * python/py-arch.c: Update.
3305         * python/py-breakpoint.c: Update.
3306         * python/py-cmd.c: Update.
3307         * python/py-finishbreakpoint.c: Update.
3308         * python/py-frame.c: Update.
3309         * python/py-framefilter.c: Update.
3310         * python/py-gdb-readline.c: Update.
3311         * python/py-inferior.c: Update.
3312         * python/py-infthread.c: Update.
3313         * python/py-lazy-string.c: Update.
3314         * python/py-linetable.c: Update.
3315         * python/py-objfile.c: Update.
3316         * python/py-param.c: Update.
3317         * python/py-prettyprint.c: Update.
3318         * python/py-progspace.c: Update.
3319         * python/py-record-btrace.c: Update.
3320         * python/py-record.c: Update.
3321         * python/py-symbol.c: Update.
3322         * python/py-type.c: Update.
3323         * python/py-unwind.c: Update.
3324         * python/py-utils.c: Update.
3325         * python/py-value.c: Update.
3326         * python/python.c: Update.
3327         * record-btrace.c: Update.
3328         * record-full.c: Update.
3329         * remote-fileio.c: Update.
3330         * remote.c: Update.
3331         * riscv-tdep.c: Update.
3332         * rs6000-aix-tdep.c: Update.
3333         * rs6000-tdep.c: Update.
3334         * rust-exp.y: Update.
3335         * rust-lang.c: Update.
3336         * s390-tdep.c: Update.
3337         * selftest-arch.c: Update.
3338         * solib-dsbt.c: Update.
3339         * solib-frv.c: Update.
3340         * solib-spu.c: Update.
3341         * solib-svr4.c: Update.
3342         * solib.c: Update.
3343         * sparc64-linux-tdep.c: Update.
3344         * stack.c: Update.
3345         * symfile-mem.c: Update.
3346         * symmisc.c: Update.
3347         * target.c: Update.
3348         * thread.c: Update.
3349         * top.c: Update.
3350         * tracefile-tfile.c: Update.
3351         * tui/tui.c: Update.
3352         * typeprint.c: Update.
3353         * unittests/cli-utils-selftests.c: Update.
3354         * unittests/parse-connection-spec-selftests.c: Update.
3355         * valops.c: Update.
3356         * valprint.c: Update.
3357         * value.c: Update.
3358         * varobj.c: Update.
3359         * windows-nat.c: Update.
3360         * x86-linux-nat.c: Update.
3361         * xml-support.c: Update.
3362
3363 2019-04-08  Tom Tromey  <tom@tromey.com>
3364
3365         * xml-support.c: Use C++ exception handling.
3366         * x86-linux-nat.c: Use C++ exception handling.
3367         * windows-nat.c: Use C++ exception handling.
3368         * varobj.c: Use C++ exception handling.
3369         * value.c: Use C++ exception handling.
3370         * valprint.c: Use C++ exception handling.
3371         * valops.c: Use C++ exception handling.
3372         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3373         handling.
3374         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3375         * typeprint.c: Use C++ exception handling.
3376         * tui/tui.c: Use C++ exception handling.
3377         * tracefile-tfile.c: Use C++ exception handling.
3378         * top.c: Use C++ exception handling.
3379         * thread.c: Use C++ exception handling.
3380         * target.c: Use C++ exception handling.
3381         * symmisc.c: Use C++ exception handling.
3382         * symfile-mem.c: Use C++ exception handling.
3383         * stack.c: Use C++ exception handling.
3384         * sparc64-linux-tdep.c: Use C++ exception handling.
3385         * solib.c: Use C++ exception handling.
3386         * solib-svr4.c: Use C++ exception handling.
3387         * solib-spu.c: Use C++ exception handling.
3388         * solib-frv.c: Use C++ exception handling.
3389         * solib-dsbt.c: Use C++ exception handling.
3390         * selftest-arch.c: Use C++ exception handling.
3391         * s390-tdep.c: Use C++ exception handling.
3392         * rust-lang.c: Use C++ exception handling.
3393         * rust-exp.y: Use C++ exception handling.
3394         * rs6000-tdep.c: Use C++ exception handling.
3395         * rs6000-aix-tdep.c: Use C++ exception handling.
3396         * riscv-tdep.c: Use C++ exception handling.
3397         * remote.c: Use C++ exception handling.
3398         * remote-fileio.c: Use C++ exception handling.
3399         * record-full.c: Use C++ exception handling.
3400         * record-btrace.c: Use C++ exception handling.
3401         * python/python.c: Use C++ exception handling.
3402         * python/py-value.c: Use C++ exception handling.
3403         * python/py-utils.c: Use C++ exception handling.
3404         * python/py-unwind.c: Use C++ exception handling.
3405         * python/py-type.c: Use C++ exception handling.
3406         * python/py-symbol.c: Use C++ exception handling.
3407         * python/py-record.c: Use C++ exception handling.
3408         * python/py-record-btrace.c: Use C++ exception handling.
3409         * python/py-progspace.c: Use C++ exception handling.
3410         * python/py-prettyprint.c: Use C++ exception handling.
3411         * python/py-param.c: Use C++ exception handling.
3412         * python/py-objfile.c: Use C++ exception handling.
3413         * python/py-linetable.c: Use C++ exception handling.
3414         * python/py-lazy-string.c: Use C++ exception handling.
3415         * python/py-infthread.c: Use C++ exception handling.
3416         * python/py-inferior.c: Use C++ exception handling.
3417         * python/py-gdb-readline.c: Use C++ exception handling.
3418         * python/py-framefilter.c: Use C++ exception handling.
3419         * python/py-frame.c: Use C++ exception handling.
3420         * python/py-finishbreakpoint.c: Use C++ exception handling.
3421         * python/py-cmd.c: Use C++ exception handling.
3422         * python/py-breakpoint.c: Use C++ exception handling.
3423         * python/py-arch.c: Use C++ exception handling.
3424         * printcmd.c: Use C++ exception handling.
3425         * ppc-linux-tdep.c: Use C++ exception handling.
3426         * parse.c: Use C++ exception handling.
3427         * p-valprint.c: Use C++ exception handling.
3428         * objc-lang.c: Use C++ exception handling.
3429         * mi/mi-main.c: Use C++ exception handling.
3430         * mi/mi-interp.c: Use C++ exception handling.
3431         * mi/mi-cmd-stack.c: Use C++ exception handling.
3432         * mi/mi-cmd-break.c: Use C++ exception handling.
3433         * main.c: Use C++ exception handling.
3434         * linux-thread-db.c: Use C++ exception handling.
3435         * linux-tdep.c: Use C++ exception handling.
3436         * linux-nat.c: Use C++ exception handling.
3437         * linux-fork.c: Use C++ exception handling.
3438         * linespec.c: Use C++ exception handling.
3439         * language.c: Use C++ exception handling.
3440         * jit.c: Use C++ exception handling.
3441         * infrun.c: Use C++ exception handling.
3442         * infcmd.c: Use C++ exception handling.
3443         * infcall.c: Use C++ exception handling.
3444         * inf-loop.c: Use C++ exception handling.
3445         * i386-tdep.c: Use C++ exception handling.
3446         * i386-linux-tdep.c: Use C++ exception handling.
3447         * guile/scm-value.c: Use C++ exception handling.
3448         * guile/scm-type.c: Use C++ exception handling.
3449         * guile/scm-symtab.c: Use C++ exception handling.
3450         * guile/scm-symbol.c: Use C++ exception handling.
3451         * guile/scm-pretty-print.c: Use C++ exception handling.
3452         * guile/scm-ports.c: Use C++ exception handling.
3453         * guile/scm-param.c: Use C++ exception handling.
3454         * guile/scm-math.c: Use C++ exception handling.
3455         * guile/scm-lazy-string.c: Use C++ exception handling.
3456         * guile/scm-frame.c: Use C++ exception handling.
3457         * guile/scm-disasm.c: Use C++ exception handling.
3458         * guile/scm-cmd.c: Use C++ exception handling.
3459         * guile/scm-breakpoint.c: Use C++ exception handling.
3460         * guile/scm-block.c: Use C++ exception handling.
3461         * guile/guile-internal.h: Use C++ exception handling.
3462         * gnu-v3-abi.c: Use C++ exception handling.
3463         * gdbtypes.c: Use C++ exception handling.
3464         * frame.c: Use C++ exception handling.
3465         * frame-unwind.c: Use C++ exception handling.
3466         * fbsd-tdep.c: Use C++ exception handling.
3467         * f-valprint.c: Use C++ exception handling.
3468         * exec.c: Use C++ exception handling.
3469         * event-top.c: Use C++ exception handling.
3470         * event-loop.c: Use C++ exception handling.
3471         * eval.c: Use C++ exception handling.
3472         * dwarf2read.c: Use C++ exception handling.
3473         * dwarf2loc.c: Use C++ exception handling.
3474         * dwarf2-frame.c: Use C++ exception handling.
3475         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3476         * dwarf-index-write.c: Use C++ exception handling.
3477         * dwarf-index-cache.c: Use C++ exception handling.
3478         * dtrace-probe.c: Use C++ exception handling.
3479         * disasm-selftests.c: Use C++ exception handling.
3480         * darwin-nat.c: Use C++ exception handling.
3481         * cp-valprint.c: Use C++ exception handling.
3482         * cp-support.c: Use C++ exception handling.
3483         * cp-abi.c: Use C++ exception handling.
3484         * corelow.c: Use C++ exception handling.
3485         * completer.c: Use C++ exception handling.
3486         * compile/compile-object-run.c: Use C++ exception handling.
3487         * compile/compile-object-load.c: Use C++ exception handling.
3488         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3489         * compile/compile-c-symbols.c: Use C++ exception handling.
3490         * common/selftest.c: Use C++ exception handling.
3491         * common/new-op.c: Use C++ exception handling.
3492         * cli/cli-script.c: Use C++ exception handling.
3493         * cli/cli-interp.c: Use C++ exception handling.
3494         * cli/cli-cmds.c: Use C++ exception handling.
3495         * c-varobj.c: Use C++ exception handling.
3496         * btrace.c: Use C++ exception handling.
3497         * breakpoint.c: Use C++ exception handling.
3498         * break-catch-throw.c: Use C++ exception handling.
3499         * arch-utils.c: Use C++ exception handling.
3500         * amd64-tdep.c: Use C++ exception handling.
3501         * ada-valprint.c: Use C++ exception handling.
3502         * ada-typeprint.c: Use C++ exception handling.
3503         * ada-lang.c: Use C++ exception handling.
3504         * aarch64-tdep.c: Use C++ exception handling.
3505
3506 2019-04-08  Tom Tromey  <tom@tromey.com>
3507
3508         * xml-support.c (gdb_xml_parser::parse): Update.
3509         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3510         * value.c (show_convenience): Update.
3511         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3512         (test_parse_flags_qcs): Update.
3513         * thread.c (thr_try_catch_cmd): Update.
3514         * target.c (target_translate_tls_address): Update.
3515         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3516         (info_frame_command_core, frame_apply_command_count): Update.
3517         * rust-exp.y (rust_lex_exception_test): Update.
3518         * riscv-tdep.c (riscv_print_one_register_info): Update.
3519         * remote.c (remote_target::enable_btrace): Update.
3520         * record-btrace.c (record_btrace_enable_warn): Update.
3521         * python/py-utils.c (gdbpy_convert_exception): Update.
3522         * printcmd.c (do_one_display, print_variable_and_value): Update.
3523         * mi/mi-main.c (mi_print_exception): Update.
3524         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3525         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3526         * linux-nat.c (linux_nat_target::attach): Update.
3527         * linux-fork.c (class scoped_switch_fork_info): Update.
3528         * infrun.c (displaced_step_prepare): Update.
3529         * infcall.c (call_function_by_hand_dummy): Update.
3530         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3531         * gnu-v3-abi.c (print_one_vtable): Update.
3532         * frame.c (get_prev_frame_always): Update.
3533         * f-valprint.c (info_common_command_for_block): Update.
3534         * exec.c (try_open_exec_file): Update.
3535         * exceptions.c (print_exception, exception_print)
3536         (exception_fprintf, exception_print_same): Update.
3537         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3538         * dwarf-index-cache.c (index_cache::store)
3539         (index_cache::lookup_gdb_index): Update.
3540         * darwin-nat.c (maybe_cache_shell): Update.
3541         * cp-valprint.c (cp_print_value_fields): Update.
3542         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3543         (gcc_cplus_symbol_address): Update.
3544         * compile/compile-c-symbols.c (gcc_convert_symbol)
3545         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3546         * common/selftest.c: Update.
3547         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3548         a std::string.
3549         (exception_try_scope_entry, exception_try_scope_exit): Don't
3550         declare.
3551         (struct exception_try_scope): Remove.
3552         (TRY): Don't use exception_try_scope.
3553         (struct gdb_exception): Add constructor, operator=.
3554         <what>: New method.
3555         (struct gdb_exception_RETURN_MASK_ALL)
3556         (struct gdb_exception_RETURN_MASK_ERROR)
3557         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3558         (struct gdb_quit_bad_alloc): Update.
3559         * common/common-exceptions.c (exception_none): Change
3560         initializer.
3561         (struct catcher) <state, exception>: Initialize inline.
3562         <prev>: Remove member.
3563         (current_catcher): Remove.
3564         (catchers): New global.
3565         (exceptions_state_mc_init): Simplify.
3566         (catcher_pop): Remove.
3567         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3568         (try_scope_depth, exception_try_scope_entry)
3569         (exception_try_scope_exit): Remove.
3570         (throw_exception_sjlj): Update.
3571         (exception_messages, exception_messages_size): Remove.
3572         (throw_it): Simplify.
3573         (gdb_exception_sliced_copy): Remove.
3574         (throw_exception_cxx): Update.
3575         * cli/cli-script.c (script_from_file): Update.
3576         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3577         Update.
3578         * ada-valprint.c (ada_val_print): Update.
3579         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3580         (create_excep_cond_exprs): Update.
3581
3582 2019-04-08  Tom Tromey  <tom@tromey.com>
3583
3584         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3585         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3586         (TRY, CATCH, END_CATCH): Remove some definitions.
3587         * common/common-exceptions.c: Don't use GDB_XCPT.
3588         (catcher_list_size): Remove.
3589         (throw_exception, throw_it): Simplify.
3590
3591 2019-04-05  Tom Tromey  <tom@tromey.com>
3592
3593         Revert the header-sorting patch.
3594         * ft32-tdep.c: Revert.
3595         * frv-tdep.c: Revert.
3596         * frv-linux-tdep.c: Revert.
3597         * frame.c: Revert.
3598         * frame-unwind.c: Revert.
3599         * frame-base.c: Revert.
3600         * fork-child.c: Revert.
3601         * findvar.c: Revert.
3602         * findcmd.c: Revert.
3603         * filesystem.c: Revert.
3604         * filename-seen-cache.h: Revert.
3605         * filename-seen-cache.c: Revert.
3606         * fbsd-tdep.c: Revert.
3607         * fbsd-nat.h: Revert.
3608         * fbsd-nat.c: Revert.
3609         * f-valprint.c: Revert.
3610         * f-typeprint.c: Revert.
3611         * f-lang.c: Revert.
3612         * extension.h: Revert.
3613         * extension.c: Revert.
3614         * extension-priv.h: Revert.
3615         * expprint.c: Revert.
3616         * exec.h: Revert.
3617         * exec.c: Revert.
3618         * exceptions.c: Revert.
3619         * event-top.c: Revert.
3620         * event-loop.c: Revert.
3621         * eval.c: Revert.
3622         * elfread.c: Revert.
3623         * dwarf2read.h: Revert.
3624         * dwarf2read.c: Revert.
3625         * dwarf2loc.c: Revert.
3626         * dwarf2expr.h: Revert.
3627         * dwarf2expr.c: Revert.
3628         * dwarf2-frame.c: Revert.
3629         * dwarf2-frame-tailcall.c: Revert.
3630         * dwarf-index-write.h: Revert.
3631         * dwarf-index-write.c: Revert.
3632         * dwarf-index-common.c: Revert.
3633         * dwarf-index-cache.h: Revert.
3634         * dwarf-index-cache.c: Revert.
3635         * dummy-frame.c: Revert.
3636         * dtrace-probe.c: Revert.
3637         * disasm.h: Revert.
3638         * disasm.c: Revert.
3639         * disasm-selftests.c: Revert.
3640         * dictionary.c: Revert.
3641         * dicos-tdep.c: Revert.
3642         * demangle.c: Revert.
3643         * dcache.h: Revert.
3644         * dcache.c: Revert.
3645         * darwin-nat.h: Revert.
3646         * darwin-nat.c: Revert.
3647         * darwin-nat-info.c: Revert.
3648         * d-valprint.c: Revert.
3649         * d-namespace.c: Revert.
3650         * d-lang.c: Revert.
3651         * ctf.c: Revert.
3652         * csky-tdep.c: Revert.
3653         * csky-linux-tdep.c: Revert.
3654         * cris-tdep.c: Revert.
3655         * cris-linux-tdep.c: Revert.
3656         * cp-valprint.c: Revert.
3657         * cp-support.c: Revert.
3658         * cp-namespace.c: Revert.
3659         * cp-abi.c: Revert.
3660         * corelow.c: Revert.
3661         * corefile.c: Revert.
3662         * continuations.c: Revert.
3663         * completer.h: Revert.
3664         * completer.c: Revert.
3665         * complaints.c: Revert.
3666         * coffread.c: Revert.
3667         * coff-pe-read.c: Revert.
3668         * cli-out.h: Revert.
3669         * cli-out.c: Revert.
3670         * charset.c: Revert.
3671         * c-varobj.c: Revert.
3672         * c-valprint.c: Revert.
3673         * c-typeprint.c: Revert.
3674         * c-lang.c: Revert.
3675         * buildsym.c: Revert.
3676         * buildsym-legacy.c: Revert.
3677         * build-id.h: Revert.
3678         * build-id.c: Revert.
3679         * btrace.c: Revert.
3680         * bsd-uthread.c: Revert.
3681         * breakpoint.h: Revert.
3682         * breakpoint.c: Revert.
3683         * break-catch-throw.c: Revert.
3684         * break-catch-syscall.c: Revert.
3685         * break-catch-sig.c: Revert.
3686         * blockframe.c: Revert.
3687         * block.c: Revert.
3688         * bfin-tdep.c: Revert.
3689         * bfin-linux-tdep.c: Revert.
3690         * bfd-target.c: Revert.
3691         * bcache.c: Revert.
3692         * ax-general.c: Revert.
3693         * ax-gdb.h: Revert.
3694         * ax-gdb.c: Revert.
3695         * avr-tdep.c: Revert.
3696         * auxv.c: Revert.
3697         * auto-load.c: Revert.
3698         * arm-wince-tdep.c: Revert.
3699         * arm-tdep.c: Revert.
3700         * arm-symbian-tdep.c: Revert.
3701         * arm-pikeos-tdep.c: Revert.
3702         * arm-obsd-tdep.c: Revert.
3703         * arm-nbsd-tdep.c: Revert.
3704         * arm-nbsd-nat.c: Revert.
3705         * arm-linux-tdep.c: Revert.
3706         * arm-linux-nat.c: Revert.
3707         * arm-fbsd-tdep.c: Revert.
3708         * arm-fbsd-nat.c: Revert.
3709         * arm-bsd-tdep.c: Revert.
3710         * arch-utils.c: Revert.
3711         * arc-tdep.c: Revert.
3712         * arc-newlib-tdep.c: Revert.
3713         * annotate.h: Revert.
3714         * annotate.c: Revert.
3715         * amd64-windows-tdep.c: Revert.
3716         * amd64-windows-nat.c: Revert.
3717         * amd64-tdep.c: Revert.
3718         * amd64-sol2-tdep.c: Revert.
3719         * amd64-obsd-tdep.c: Revert.
3720         * amd64-obsd-nat.c: Revert.
3721         * amd64-nbsd-tdep.c: Revert.
3722         * amd64-nbsd-nat.c: Revert.
3723         * amd64-nat.c: Revert.
3724         * amd64-linux-tdep.c: Revert.
3725         * amd64-linux-nat.c: Revert.
3726         * amd64-fbsd-tdep.c: Revert.
3727         * amd64-fbsd-nat.c: Revert.
3728         * amd64-dicos-tdep.c: Revert.
3729         * amd64-darwin-tdep.c: Revert.
3730         * amd64-bsd-nat.c: Revert.
3731         * alpha-tdep.c: Revert.
3732         * alpha-obsd-tdep.c: Revert.
3733         * alpha-nbsd-tdep.c: Revert.
3734         * alpha-mdebug-tdep.c: Revert.
3735         * alpha-linux-tdep.c: Revert.
3736         * alpha-linux-nat.c: Revert.
3737         * alpha-bsd-tdep.c: Revert.
3738         * alpha-bsd-nat.c: Revert.
3739         * aix-thread.c: Revert.
3740         * agent.c: Revert.
3741         * addrmap.c: Revert.
3742         * ada-varobj.c: Revert.
3743         * ada-valprint.c: Revert.
3744         * ada-typeprint.c: Revert.
3745         * ada-tasks.c: Revert.
3746         * ada-lang.c: Revert.
3747         * aarch64-tdep.c: Revert.
3748         * aarch64-ravenscar-thread.c: Revert.
3749         * aarch64-newlib-tdep.c: Revert.
3750         * aarch64-linux-tdep.c: Revert.
3751         * aarch64-linux-nat.c: Revert.
3752         * aarch64-fbsd-tdep.c: Revert.
3753         * aarch64-fbsd-nat.c: Revert.
3754         * aarch32-linux-nat.c: Revert.
3755
3756 2019-04-05  Tom Tromey  <tom@tromey.com>
3757
3758         * ft32-tdep.c: Sort headers.
3759         * frv-tdep.c: Sort headers.
3760         * frv-linux-tdep.c: Sort headers.
3761         * frame.c: Sort headers.
3762         * frame-unwind.c: Sort headers.
3763         * frame-base.c: Sort headers.
3764         * fork-child.c: Sort headers.
3765         * findvar.c: Sort headers.
3766         * findcmd.c: Sort headers.
3767         * filesystem.c: Sort headers.
3768         * filename-seen-cache.h: Sort headers.
3769         * filename-seen-cache.c: Sort headers.
3770         * fbsd-tdep.c: Sort headers.
3771         * fbsd-nat.h: Sort headers.
3772         * fbsd-nat.c: Sort headers.
3773         * f-valprint.c: Sort headers.
3774         * f-typeprint.c: Sort headers.
3775         * f-lang.c: Sort headers.
3776         * extension.h: Sort headers.
3777         * extension.c: Sort headers.
3778         * extension-priv.h: Sort headers.
3779         * expprint.c: Sort headers.
3780         * exec.h: Sort headers.
3781         * exec.c: Sort headers.
3782         * exceptions.c: Sort headers.
3783         * event-top.c: Sort headers.
3784         * event-loop.c: Sort headers.
3785         * eval.c: Sort headers.
3786         * elfread.c: Sort headers.
3787         * dwarf2read.h: Sort headers.
3788         * dwarf2read.c: Sort headers.
3789         * dwarf2loc.c: Sort headers.
3790         * dwarf2expr.h: Sort headers.
3791         * dwarf2expr.c: Sort headers.
3792         * dwarf2-frame.c: Sort headers.
3793         * dwarf2-frame-tailcall.c: Sort headers.
3794         * dwarf-index-write.h: Sort headers.
3795         * dwarf-index-write.c: Sort headers.
3796         * dwarf-index-common.c: Sort headers.
3797         * dwarf-index-cache.h: Sort headers.
3798         * dwarf-index-cache.c: Sort headers.
3799         * dummy-frame.c: Sort headers.
3800         * dtrace-probe.c: Sort headers.
3801         * disasm.h: Sort headers.
3802         * disasm.c: Sort headers.
3803         * disasm-selftests.c: Sort headers.
3804         * dictionary.c: Sort headers.
3805         * dicos-tdep.c: Sort headers.
3806         * demangle.c: Sort headers.
3807         * dcache.h: Sort headers.
3808         * dcache.c: Sort headers.
3809         * darwin-nat.h: Sort headers.
3810         * darwin-nat.c: Sort headers.
3811         * darwin-nat-info.c: Sort headers.
3812         * d-valprint.c: Sort headers.
3813         * d-namespace.c: Sort headers.
3814         * d-lang.c: Sort headers.
3815         * ctf.c: Sort headers.
3816         * csky-tdep.c: Sort headers.
3817         * csky-linux-tdep.c: Sort headers.
3818         * cris-tdep.c: Sort headers.
3819         * cris-linux-tdep.c: Sort headers.
3820         * cp-valprint.c: Sort headers.
3821         * cp-support.c: Sort headers.
3822         * cp-namespace.c: Sort headers.
3823         * cp-abi.c: Sort headers.
3824         * corelow.c: Sort headers.
3825         * corefile.c: Sort headers.
3826         * continuations.c: Sort headers.
3827         * completer.h: Sort headers.
3828         * completer.c: Sort headers.
3829         * complaints.c: Sort headers.
3830         * coffread.c: Sort headers.
3831         * coff-pe-read.c: Sort headers.
3832         * cli-out.h: Sort headers.
3833         * cli-out.c: Sort headers.
3834         * charset.c: Sort headers.
3835         * c-varobj.c: Sort headers.
3836         * c-valprint.c: Sort headers.
3837         * c-typeprint.c: Sort headers.
3838         * c-lang.c: Sort headers.
3839         * buildsym.c: Sort headers.
3840         * buildsym-legacy.c: Sort headers.
3841         * build-id.h: Sort headers.
3842         * build-id.c: Sort headers.
3843         * btrace.c: Sort headers.
3844         * bsd-uthread.c: Sort headers.
3845         * breakpoint.h: Sort headers.
3846         * breakpoint.c: Sort headers.
3847         * break-catch-throw.c: Sort headers.
3848         * break-catch-syscall.c: Sort headers.
3849         * break-catch-sig.c: Sort headers.
3850         * blockframe.c: Sort headers.
3851         * block.c: Sort headers.
3852         * bfin-tdep.c: Sort headers.
3853         * bfin-linux-tdep.c: Sort headers.
3854         * bfd-target.c: Sort headers.
3855         * bcache.c: Sort headers.
3856         * ax-general.c: Sort headers.
3857         * ax-gdb.h: Sort headers.
3858         * ax-gdb.c: Sort headers.
3859         * avr-tdep.c: Sort headers.
3860         * auxv.c: Sort headers.
3861         * auto-load.c: Sort headers.
3862         * arm-wince-tdep.c: Sort headers.
3863         * arm-tdep.c: Sort headers.
3864         * arm-symbian-tdep.c: Sort headers.
3865         * arm-pikeos-tdep.c: Sort headers.
3866         * arm-obsd-tdep.c: Sort headers.
3867         * arm-nbsd-tdep.c: Sort headers.
3868         * arm-nbsd-nat.c: Sort headers.
3869         * arm-linux-tdep.c: Sort headers.
3870         * arm-linux-nat.c: Sort headers.
3871         * arm-fbsd-tdep.c: Sort headers.
3872         * arm-fbsd-nat.c: Sort headers.
3873         * arm-bsd-tdep.c: Sort headers.
3874         * arch-utils.c: Sort headers.
3875         * arc-tdep.c: Sort headers.
3876         * arc-newlib-tdep.c: Sort headers.
3877         * annotate.h: Sort headers.
3878         * annotate.c: Sort headers.
3879         * amd64-windows-tdep.c: Sort headers.
3880         * amd64-windows-nat.c: Sort headers.
3881         * amd64-tdep.c: Sort headers.
3882         * amd64-sol2-tdep.c: Sort headers.
3883         * amd64-obsd-tdep.c: Sort headers.
3884         * amd64-obsd-nat.c: Sort headers.
3885         * amd64-nbsd-tdep.c: Sort headers.
3886         * amd64-nbsd-nat.c: Sort headers.
3887         * amd64-nat.c: Sort headers.
3888         * amd64-linux-tdep.c: Sort headers.
3889         * amd64-linux-nat.c: Sort headers.
3890         * amd64-fbsd-tdep.c: Sort headers.
3891         * amd64-fbsd-nat.c: Sort headers.
3892         * amd64-dicos-tdep.c: Sort headers.
3893         * amd64-darwin-tdep.c: Sort headers.
3894         * amd64-bsd-nat.c: Sort headers.
3895         * alpha-tdep.c: Sort headers.
3896         * alpha-obsd-tdep.c: Sort headers.
3897         * alpha-nbsd-tdep.c: Sort headers.
3898         * alpha-mdebug-tdep.c: Sort headers.
3899         * alpha-linux-tdep.c: Sort headers.
3900         * alpha-linux-nat.c: Sort headers.
3901         * alpha-bsd-tdep.c: Sort headers.
3902         * alpha-bsd-nat.c: Sort headers.
3903         * aix-thread.c: Sort headers.
3904         * agent.c: Sort headers.
3905         * addrmap.c: Sort headers.
3906         * ada-varobj.c: Sort headers.
3907         * ada-valprint.c: Sort headers.
3908         * ada-typeprint.c: Sort headers.
3909         * ada-tasks.c: Sort headers.
3910         * ada-lang.c: Sort headers.
3911         * aarch64-tdep.c: Sort headers.
3912         * aarch64-ravenscar-thread.c: Sort headers.
3913         * aarch64-newlib-tdep.c: Sort headers.
3914         * aarch64-linux-tdep.c: Sort headers.
3915         * aarch64-linux-nat.c: Sort headers.
3916         * aarch64-fbsd-tdep.c: Sort headers.
3917         * aarch64-fbsd-nat.c: Sort headers.
3918         * aarch32-linux-nat.c: Sort headers.
3919
3920 2019-04-04  Tom Tromey  <tom@tromey.com>
3921
3922         * varobj.c (varobj_create): Update.
3923         * rust-exp.y (struct rust_parser) <update_innermost_block,
3924         lookup_symbol>: New methods.
3925         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3926         Rename.
3927         (rust_parser::rust_lookup_type)
3928         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3929         * printcmd.c (display_command, do_one_display): Update.
3930         * parser-defs.h (struct parser_state) <parser_state>: Add
3931         "tracker" parameter.
3932         (block_tracker): New member.
3933         (class innermost_block_tracker) <innermost_block_tracker>: Add
3934         "types" parameter.
3935         <reset>: Remove method.
3936         (innermost_block): Don't declare.
3937         (null_post_parser): Update.
3938         * parse.c (innermost_block): Remove global.
3939         (write_dollar_variable): Update.
3940         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3941         Remove "tracker_types" parameter.
3942         (parse_expression): Add "tracker" parameter.
3943         (parse_expression_for_completion): Update.
3944         (null_post_parser): Add "tracker" parameter.
3945         * p-exp.y: Update rules.
3946         * m2-exp.y: Update rules.
3947         * language.h (struct language_defn) <la_post_parser>: Add
3948         "tracker" parameter.
3949         * go-exp.y: Update rules.
3950         * f-exp.y: Update rules.
3951         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3952         parameter.
3953         * d-exp.y: Update rules.
3954         * c-exp.y: Update rules.
3955         * breakpoint.c (set_breakpoint_condition): Create an
3956         innermost_block_tracker.
3957         (watch_command_1): Likewise.
3958         * ada-lang.c (resolve): Add "tracker" parameter.
3959         (resolve_subexp): Likewise.
3960         * ada-exp.y (write_var_from_sym): Update.
3961
3962 2019-04-04  Tom Tromey  <tom@tromey.com>
3963
3964         * type-stack.h: New file.
3965         * type-stack.c: New file.
3966         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3967         type-stack.h.
3968         (insert_into_type_stack, insert_type, push_type, push_type_int)
3969         (insert_type_address_space, pop_type, pop_type_int)
3970         (pop_typelist, pop_type_stack, append_type_stack)
3971         (push_type_stack, get_type_stack, push_typelist)
3972         (follow_type_instance_flags, follow_types): Don't declare.
3973         * parse.c (type_stack): Remove global.
3974         (parse_exp_in_context): Update.
3975         (insert_into_type_stack, insert_type, push_type, push_type_int)
3976         (insert_type_address_space, pop_type, pop_type_int)
3977         (pop_typelist, pop_type_stack, append_type_stack)
3978         (push_type_stack, get_type_stack, push_typelist)
3979         (follow_type_instance_flags, follow_types): Remove (moved to
3980         type-stack.c).
3981         * f-exp.y (type_stack): New global.
3982         Update rules.
3983         (push_kind_type, f_parse): Update.
3984         * d-exp.y (type_stack): New global.
3985         Update rules.
3986         (d_parse): Update.
3987         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3988         Update rules.
3989         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3990         (HFILES_NO_SRCDIR): Add type-stack.h.
3991
3992 2019-04-04  Tom Tromey  <tom@tromey.com>
3993
3994         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3995         (rust_parser::convert_ast_to_expression, rust_parse)
3996         (rust_lex_test_completion, rust_lex_tests): Update.
3997         * parser-defs.h (struct expr_completion_state): New.
3998         (struct parser_state) <parser_state>: Add completion parameter.
3999         <mark_struct_expression, mark_completion_tag>: New methods.
4000         <parse_completion, m_completion_state>: New members.
4001         (prefixify_expression, null_post_parser): Update.
4002         (mark_struct_expression, mark_completion_tag): Don't declare.
4003         * parse.c (parse_completion, expout_last_struct)
4004         (expout_tag_completion_type, expout_completion_name): Remove
4005         globals.
4006         (parser_state::mark_struct_expression)
4007         (parser_state::mark_completion_tag): Now methods.
4008         (prefixify_expression): Add last_struct parameter.
4009         (prefixify_subexp): Likewise.
4010         (parse_exp_1): Update.
4011         (parse_exp_in_context): Add cstate parameter.  Update.
4012         (parse_expression_for_completion): Create an
4013         expr_completion_state.
4014         (null_post_parser): Add "completion" parameter.
4015         * p-exp.y: Update rules.
4016         (yylex): Update.
4017         * language.h (struct language_defn) <la_post_parser>: Add
4018         "completing" parameter.
4019         * go-exp.y: Update rules.
4020         (lex_one_token): Update.
4021         * expression.h (parse_completion): Don't declare.
4022         * d-exp.y: Update rules.
4023         (lex_one_token): Update rules.
4024         * c-exp.y: Update rules.
4025         (lex_one_token): Update.
4026         * ada-lang.c (resolve): Add "parse_completion" parameter.
4027         (resolve_subexp): Likewise.
4028         (ada_resolve_function): Likewise.
4029
4030 2019-04-04  Tom Tromey  <tom@tromey.com>
4031
4032         * parser-defs.h (struct parser_state) <start_arglist,
4033         end_arglist>: New methods.
4034         <arglist_len, m_funcall_chain>: New members.
4035         (arglist_len, start_arglist, end_arglist): Don't declare.
4036         * parse.c (arglist_len, funcall_chain): Remove global.
4037         (start_arglist, end_arglist): Remove functions.
4038         (parse_exp_in_context): Update.
4039         * p-exp.y: Update rules.
4040         * m2-exp.y: Update rules.
4041         * go-exp.y: Update rules.
4042         * f-exp.y: Update rules.
4043         * d-exp.y: Update rules.
4044         * c-exp.y: Update rules.
4045
4046 2019-04-04  Tom Tromey  <tom@tromey.com>
4047
4048         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4049         lex_operator, push_back>: New methods.
4050         Update all rules.
4051         (rust_parser::lex_hex, lex_escape): Rename and update.
4052         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4053         (rust_parser::lex_operator): Rename and update.
4054         (rust_parser::lex_number, rustyylex, rustyyerror)
4055         (rust_lex_test_init, rust_lex_test_sequence)
4056         (rust_lex_test_push_back, rust_lex_tests): Update.
4057         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4058         parameter.
4059         <lexptr, prev_lexptr>: New members.
4060         (lexptr, prev_lexptr): Don't declare.
4061         * parse.c (lexptr, prev_lexptr): Remove globals.
4062         (parse_exp_in_context): Update.
4063         * p-exp.y (yylex, yyerror): Update.
4064         * m2-exp.y (parse_number, yylex, yyerror): Update.
4065         * go-exp.y (lex_one_token, yyerror): Update.
4066         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4067         * d-exp.y (lex_one_token, yyerror): Update.
4068         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4069         (lex_one_token, yyerror): Update.
4070         * ada-lex.l (YY_INPUT): Update.
4071         (rewind_to_char): Update.
4072         * ada-exp.y (yyerror): Update.
4073
4074 2019-04-04  Tom Tromey  <tom@tromey.com>
4075
4076         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4077         * parser-defs.h (struct parser_state) <parser_state>: Add new
4078         parameter.
4079         <comma_terminates>: New member.
4080         (comma_terminates): Don't declare global.
4081         * parse.c (comma_terminates): Remove global.
4082         (parse_exp_in_context): Update.
4083         * p-exp.y (yylex): Update.
4084         * m2-exp.y (yylex): Update.
4085         * go-exp.y (lex_one_token): Update.
4086         * f-exp.y (yylex): Update.
4087         * d-exp.y (lex_one_token): Update.
4088         * c-exp.y (lex_one_token): Update.
4089         * ada-lex.l: Update.
4090
4091 2019-04-04  Tom Tromey  <tom@tromey.com>
4092
4093         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4094         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4095         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4096         * parser-defs.h (paren_depth): Don't declare.
4097         * parse.c (paren_depth): Remove global.
4098         (parse_exp_in_context): Update.
4099         * p-exp.y (paren_depth): New global.
4100         (pascal_parse): Initialize it.
4101         * m2-exp.y (paren_depth): New global.
4102         (m2_parse): Initialize it.
4103         * go-exp.y (paren_depth): New global.
4104         (go_parse): Initialize it.
4105         * f-exp.y (paren_depth): New global.
4106         (f_parse): Initialize it.
4107         * d-exp.y (paren_depth): New global.
4108         (d_parse): Initialize it.
4109         * c-exp.y (paren_depth): New global.
4110         (c_parse): Initialize it.
4111         * ada-lex.l (paren_depth): New global.
4112         (lexer_init): Initialize it.
4113
4114 2019-04-04  Tom Tromey  <tom@tromey.com>
4115
4116         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4117         (rust_parser::convert_ast_to_type)
4118         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4119         * parser-defs.h (struct parser_state) <parser_state>: Add
4120         parameters.  Initialize new members.
4121         <expression_context_block, expression_context_pc>: New members.
4122         * parse.c (expression_context_block, expression_context_pc):
4123         Remove globals.
4124         (parse_exp_in_context): Update.
4125         * p-exp.y: Update all rules.
4126         (yylex): Update.
4127         * m2-exp.y: Update all rules.
4128         (yylex): Update.
4129         * go-exp.y (yylex): Update.
4130         * f-exp.y (yylex): Update.
4131         * d-exp.y: Update all rules.
4132         (yylex): Update.
4133         * c-exp.y: Update all rules.
4134         (lex_one_token, classify_name, yylex, c_parse): Update.
4135         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4136
4137 2019-04-04  Tom Tromey  <tom@tromey.com>
4138
4139         * gdbarch.h, gdbarch.c: Rebuild.
4140         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4141         * stap-probe.h:
4142         (struct stap_parse_info): Replace "parser_state" with
4143         "expr_builder".
4144         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4145         (parser_state): New class.
4146         * parse.c (expr_builder): Rename.
4147         (expr_builder::release): Rename.
4148         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4149         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4150         (write_exp_elt_longcst, write_exp_elt_floatcst)
4151         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4152         (write_exp_string_vector, write_exp_bitstring)
4153         (write_exp_msymbol, mark_struct_expression)
4154         (write_dollar_variable)
4155         (insert_type_address_space, increase_expout_size): Replace
4156         "parser_state" with "expr_builder".
4157         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4158         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4159         "parser_state" with "expr_builder".
4160
4161 2019-04-04  Tom Tromey  <tom@tromey.com>
4162
4163         * rust-exp.y: Replace "parse_language" with method call.
4164         * p-exp.y:
4165         (yylex): Replace "parse_language" with method call.
4166         * m2-exp.y:
4167         (yylex): Replace "parse_language" with method call.
4168         * go-exp.y (classify_name): Replace "parse_language" with method
4169         call.
4170         * f-exp.y (yylex): Replace "parse_language" with method call.
4171         * d-exp.y (lex_one_token): Replace "parse_language" with method
4172         call.
4173         * c-exp.y:
4174         (lex_one_token, classify_name, yylex): Replace "parse_language"
4175         with method call.
4176         * ada-exp.y (find_primitive_type, type_char)
4177         (type_system_address): Replace "parse_language" with method call.
4178
4179 2019-04-04  Tom Tromey  <tom@tromey.com>
4180
4181         * rust-exp.y: Replace "parse_gdbarch" with method call.
4182         * parse.c (write_dollar_variable, insert_type_address_space):
4183         Replace "parse_gdbarch" with method call.
4184         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4185         call.
4186         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4187         call.
4188         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4189         "parse_gdbarch" with method call.
4190         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4191         with method call.
4192         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4193         "parse_gdbarch" with method call.
4194         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4195         "parse_gdbarch" with method call.
4196         * c-exp.y (parse_type, parse_number, classify_name): Replace
4197         "parse_gdbarch" with method call.
4198         * ada-lex.l: Replace "parse_gdbarch" with method call.
4199         * ada-exp.y (parse_type, find_primitive_type, type_char)
4200         (type_system_address): Replace "parse_gdbarch" with method call.
4201
4202 2019-04-04  Tom Tromey  <tom@tromey.com>
4203
4204         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4205         * stap-probe.c (stap_parse_argument): Update.
4206         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4207         initial_size parameter.
4208         * rust-exp.y (rust_lex_tests): Update.
4209         * parse.c (parser_state): Update.
4210         (parse_exp_in_context): Update.
4211         * parser-defs.h (struct parser_state) <parser_state>: Remove
4212         "initial_size" parameter.
4213
4214 2019-04-04  Tom Tromey  <tom@tromey.com>
4215
4216         * parser-defs.h (increase_expout_size): Don't declare.
4217         * parse.c (increase_expout_size): Now static.
4218
4219 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4220
4221         * gnu-nat.c (gnu_nat_target::wait): Fix
4222         target_waitstatus_to_string call.
4223
4224 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * eval.c (evaluate_subexp_standard): Handle internal functions
4227         during Fortran function call handling.
4228
4229 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * NEWS: Mention new internal functions.
4232         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4233         (read_base_type): Use dwarf2_init_complex_target_type.
4234         * value.c (creal_internal_fn): New function.
4235         (cimag_internal_fn): New function.
4236         (_initialize_values): Register new internal functions.
4237
4238 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4239
4240         * infrun.c (stop_all_threads): If debug_infrun, always
4241         trace the wait status after wait_one, using
4242         target_waitstatus_to_string and target_pid_to_str.
4243         (handle_inferior_event): Replace various trace of
4244         wait status kind by a single trace.
4245         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4246         wait status kind image by target_waitstatus_to_string.
4247         * target/waitstatus.c (target_waitstatus_to_string): Fix
4248         obsolete comment.
4249
4250 2019-04-01  Tom Tromey  <tromey@adacore.com>
4251
4252         PR symtab/23331:
4253         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4254
4255 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4256             Pedro Alves  <palves@redhat.com>
4257
4258         * top.c (quit_force): Call 'finalize_values'.
4259         * value.c (finalize_values): New function.
4260         * value.h (finalize_values): Declare.
4261
4262 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4263
4264         * NEWS: Announce $_gdb_major and $_gdb_minor.
4265
4266         * top.c (init_gdb_version_vars): New function.
4267         (gdb_init): Call init_gdb_version_vars.
4268
4269 2019-03-29  Tom Tromey  <tromey@adacore.com>
4270
4271         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4272         help text.  Remove dead code.
4273
4274 2019-03-29  Keith Seitz  <keiths@redhat.com>
4275
4276         From Siddhesh Poyarekar:
4277         * f-lang.h (f77_get_upperbound): Return LONGEST.
4278         (f77_get_lowerbound): Likewise.
4279         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4280         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4281         print them.
4282         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4283         plongest to format print it.
4284         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4285         (f77_get_upperbound): Likewise.
4286         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4287         LOWER_BOUND to LONGEST.
4288         (f77_create_arrayprint_offset_tbl): Likewise.
4289
4290 2019-03-29  Keith Seitz  <keiths@redhat.com>
4291
4292         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4293         %s/pulongest for TYPE_LENGTH instead of %d in format
4294         strings.
4295         * ada-typerint.c (ada_print_type): Likewise.
4296         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4297         * compile/compile-c-support.c (generate_register_struct): Likewise.
4298         * gdbtypes.c (recursive_dump_type): Likewise.
4299         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4300         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4301         instead of %d in format strings.
4302         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4303         to std::min to ULONGEST.
4304         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4305         instead of %d in format strings.
4306         * tracepoint.c (info_scope_command): Likewise.
4307         * typeprint.c (print_offset_data::update)
4308         (print_offset_data::finish): Likewise.
4309         * xtensa-tdep.c (xtensa_store_return_value)
4310         (xtensa_push_dummy_call): Likewise.
4311
4312 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4313
4314         * windows-nat.c (display_selector): Fixed format specifications
4315         for 64-bit Cygwin.
4316
4317 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4318
4319         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4320
4321 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4322
4323         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4324         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4325         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4326         (nios2_linux_init_abi): Install it.
4327
4328 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4329
4330         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4331
4332 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4333
4334         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4335
4336 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4337             Tom Tromey  <tromey@adacore.com>
4338
4339         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4340
4341 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4342
4343         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4344         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4345         method to compute the bounds of range types. Also print "[evaluated]"
4346         if the bounds' values come from a dynamic evaluation.
4347
4348 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4351         whitespace when pretty printing is on.
4352
4353 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4354
4355         * ppc-linux-nat.c: Add include.
4356
4357 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4358
4359         * NEWS: Mention AArch64 Pointer Authentication.
4360
4361 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * arm-linux-nat.c: Add include.
4364
4365 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4366
4367         * source-cache.c (source_cache::get_source_lines): Re-read
4368         fullname after calling open_source_file.
4369
4370 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4371
4372         * NEWS: Mention TLS support for FreeBSD.
4373
4374 2019-03-25  Tom Tromey  <tromey@adacore.com>
4375
4376         * minsyms.c (BUNCH_SIZE): Update comment.
4377         (~minimal_symbol_reader): Remove old comment.
4378         (compact_minimal_symbols): Update comment.
4379         (minimal_symbol_reader::install): Remove old comment.  Update
4380         other comments.
4381
4382 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4383
4384         * s390-linux-nat.c: Add include.
4385
4386 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4387
4388         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4389         Call linux_get_hwcap.
4390         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4391         Likewise.
4392         (aarch64_linux_get_hwcap): Remove function.
4393         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4394         declaration.
4395         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4396         linux_get_hwcap.
4397         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4398         * linux-tdep.c (linux_get_hwcap): Add function.
4399         (linux_get_hwcap2): Likewise.
4400         * linux-tdep.h (linux_get_hwcap): Add declaration.
4401         (linux_get_hwcap2): Likewise.
4402         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4403         (ppc_linux_get_hwcap2): Likewise.
4404         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4405         linux_get_hwcap.
4406         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4407         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4408         (ppc_linux_nat_target::read_description): Likewise.
4409         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4410         * s390-linux-nat.c: Likewise.
4411         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4412
4413 2019-03-24  Tom Tromey  <tom@tromey.com>
4414
4415         * ada-lang.c (standard_lookup): Simplify initialization.
4416         (ada_lookup_symbol_nonlocal): Simplify return.
4417         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4418         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4419         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4420         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4421         initialization.
4422         * solib.c (solib_global_lookup): Simplify.
4423         * symtab.c (null_block_symbol): Remove.
4424         (symbol_cache_lookup): Simplify returns.
4425         (lookup_language_this): Simplify returns.
4426         (lookup_symbol_aux): Simplify return.
4427         (lookup_local_symbol): Simplify returns.
4428         (lookup_global_symbol_from_objfile): Simplify return.
4429         (lookup_symbol_in_objfile_symtabs)
4430         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4431         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4432         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4433         * cp-namespace.c (cp_lookup_bare_symbol)
4434         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4435         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4436         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4437         (cp_lookup_symbol_via_imports): Simplify initialization.
4438         (find_symbol_in_baseclass): Likewise.
4439         * symtab.h (null_block_symbol): Remove.
4440         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4441         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4442         (d_lookup_symbol_module): Likewise.
4443         (find_symbol_in_baseclass): Simplify initialization.
4444
4445 2019-03-24  Tom Tromey  <tom@tromey.com>
4446
4447         * expression.h: Don't include symtab.h.
4448         (struct block): Forward declare.
4449
4450 2019-03-24  Tom Tromey  <tom@tromey.com>
4451
4452         * c-exp.y (typebase): Remove casts.
4453         * gdbtypes.c (lookup_unsigned_typename, )
4454         (lookup_signed_typename): Remove cast.
4455         * eval.c (parse_to_comma_and_eval): Remove cast.
4456         * parse.c (write_dollar_variable): Remove cast.
4457         * block.h (struct block) <superblock>: Now const.
4458         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4459         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4460         (map_block): Make "block" const.
4461         * symfile.h (struct quick_symbol_functions)
4462         <map_matching_symbols>: Constify block argument to "callback".
4463         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4464         const.
4465         (find_pc_sect_compunit_symtab): Make "b" const.
4466         (find_symbol_at_address): Likewise.
4467         (search_symbols): Likewise.
4468         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4469         (dw2_debug_names_lookup_symbol): Likewise.
4470         (dw2_map_matching_symbols): Update.
4471         * p-valprint.c (pascal_val_print): Remove "block".
4472         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4473         (aux_add_nonlocal_symbols): Make "block" const.
4474         (resolve_subexp): Remove cast.
4475         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4476         const.
4477         (iterate_over_file_blocks): Likewise.
4478         * f-exp.y (%union) <bval>: Remove.
4479         * coffread.c (patch_opaque_types): Make "b" const.
4480         * spu-tdep.c (spu_catch_start): Make "block" const.
4481         * c-valprint.c (print_unpacked_pointer): Remove "block".
4482         * symmisc.c (dump_symtab_1): Make "b" const.
4483         (block_depth): Make "block" const.
4484         * d-exp.y (%union) <bval>: Remove.
4485         * cp-support.h (cp_lookup_rtti_type): Update.
4486         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4487         * psymtab.c (psym_lookup_symbol): Make "block" const.
4488         (maintenance_check_psymtabs): Make "b" const.
4489         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4490         (enumerate_locals, enumerate_args): Update.
4491         * python/py-symtab.c (stpy_global_block): Make "block" const.
4492         (stpy_static_block): Likewise.
4493         * inline-frame.c (block_starting_point_at): Make "new_block"
4494         const.
4495         * block.c (find_block_in_blockvector): Make return type const.
4496         (blockvector_for_pc_sect): Make "b" const.
4497         (find_block_in_blockvector): Make "b" const.
4498
4499 2019-03-23  Tom Tromey  <tom@tromey.com>
4500
4501         * varobj.c (varobj_create): Update.
4502         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4503         * printcmd.c (display_command, do_one_display): Don't reset
4504         innermost_block.
4505         * parser-defs.h (enum innermost_block_tracker_type): Move to
4506         expression.h.
4507         (innermost_block): Update comment.
4508         * parse.c (parse_exp_1): Add tracker_types parameter.
4509         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4510         tracker_types parameter.  Reset innermost_block.
4511         (parse_exp_in_context): Remove.
4512         (parse_expression_for_completion): Update.
4513         * objfiles.c (~objfile): Don't reset expression_context_block or
4514         innermost_block.
4515         * expression.h (enum innermost_block_tracker_type): Move from
4516         parser-defs.h.
4517         (parse_exp_1): Add tracker_types parameter.
4518         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4519         reset innermost_block.
4520
4521 2019-03-23  Tom Tromey  <tom@tromey.com>
4522
4523         * objfiles.h: Include bcache.h.
4524
4525 2019-03-23  Tom Tromey  <tom@tromey.com>
4526
4527         * linespec.c (get_current_search_block): Use
4528         scoped_restore_current_language.
4529         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4530
4531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4532             Jiong Wang  <jiong.wang@arm.com>
4533
4534         * aarch64-linux-tdep.c
4535         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4536         section.
4537         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4538
4539 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4540             Jiong Wang  <jiong.wang@arm.com>
4541
4542         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4543         instructions.
4544         (aarch64_analyze_prologue_test): Add PACIASP test.
4545         (aarch64_prologue_prev_register): Unmask PC value.
4546
4547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4548             Jiong Wang  <jiong.wang@arm.com>
4549
4550         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4551         (aarch64_dwarf2_prev_register): Unmask PC value.
4552         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4553         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4554         DW_CFA_AARCH64_negate_ra_state.
4555         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4556
4557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4558             Jiong Wang  <jiong.wang@arm.com>
4559
4560         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4561         registers.
4562         (aarch64_pseudo_register_name): Likewise.
4563         (aarch64_pseudo_register_type): Likewise.
4564         (aarch64_pseudo_register_reggroup_p): Likewise.
4565         (aarch64_gdbarch_init): Add pauth registers.
4566         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4567         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4568         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4569         (struct gdbarch_tdep): Add regnum for ra_state.
4570
4571 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4572             Jiong Wang  <jiong.wang@arm.com>
4573
4574         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4575
4576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4577             Jiong Wang  <jiong.wang@arm.com>
4578
4579         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4580         function.
4581         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4582         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4583         (aarch64_gdbarch_init): Add puth registers.
4584         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4585         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4586         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4587
4588 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4589             Jiong Wang  <jiong.wang@arm.com>
4590
4591         * aarch64-linux-nat.c
4592         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4593         * aarch64-linux-tdep.c
4594         (aarch64_linux_core_read_description): Likewise.
4595         (aarch64_linux_get_hwcap): New function.
4596         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4597         (aarch64_linux_get_hwcap): New declaration.
4598
4599 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4600             Jiong Wang  <jiong.wang@arm.com>
4601
4602         * aarch64-linux-nat.c
4603         (aarch64_linux_nat_target::read_description): Add pauth param.
4604         * aarch64-linux-tdep.c
4605         (aarch64_linux_core_read_description): Likewise.
4606         * aarch64-tdep.c (struct target_desc): Add in pauth.
4607         (aarch64_read_description): Add pauth param.
4608         (aarch64_gdbarch_init): Likewise.
4609         * aarch64-tdep.h (aarch64_read_description): Likewise.
4610         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4611         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4612         * features/Makefile: Add new files.
4613         * features/aarch64-pauth.c: New file.
4614         * features/aarch64-pauth.xml: New file.
4615
4616 2019-03-20  Tom Tromey  <tromey@adacore.com>
4617
4618         * infrun.c (handle_inferior_event): Rename from
4619         handle_inferior_event_1.  Create a scoped_value_mark.
4620         (handle_inferior_event): Remove.
4621
4622 2019-03-19  Tom Tromey  <tromey@adacore.com>
4623
4624         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4625         * infrun.h (print_stop_event): Add "displays" parameter.
4626         * infrun.c (print_stop_event): Add "displays" parameter.
4627
4628 2019-03-19  Pedro Alves  <palves@redhat.com>
4629
4630         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4631         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4632         to -1.  Fix TABs vs spaces.
4633         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4634         * tui/tui-out.h (tui_ui_out) Add intro comments.
4635         <m_line, m_start_of_line>: In-class initialize, and add describing
4636         comment.
4637
4638 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4639
4640         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4641         variable names.
4642         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4643
4644 2019-03-18  Pedro Alves  <palves@redhat.com>
4645             Eli Zaretskii <eliz@gnu.org>
4646
4647         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4648         m_line and m_start_of_line.
4649
4650 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4651
4652         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4653         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4654         it returns a newline.  This fixes a regression in TU mode, whereby
4655         the next line is output on the same screen line as the user input.
4656
4657 2019-03-18  Tom Tromey  <tromey@adacore.com>
4658
4659         * minsyms.c (minimal_symbol_reader::install): Remove call to
4660         obstack_blank.
4661
4662 2019-03-18  Pedro Alves  <palves@redhat.com>
4663
4664         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4665         New globals.
4666         (apply_style): New, factored out from ...
4667         (apply_ansi_escape): ... this.  Handle reverse video mode.
4668         (tui_set_reverse_mode): New function.
4669         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4670         * tui/tui-winsource.c (tui_show_source_line): Use
4671         tui_set_reverse_mode instead of setting A_STANDOUT.
4672         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4673         New setter methods.
4674
4675 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4676
4677         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4678         Handle tabs.
4679
4680 2019-03-18  Tom Tromey  <tromey@adacore.com>
4681
4682         * ada-lang.c (empty_array): Add "high" parameter.
4683         (ada_evaluate_subexp): Update.
4684
4685 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4686
4687         * unittests/string_view-selftests.c: Define
4688         _initialize_string_view_selftests unconditionally.
4689
4690 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4691
4692         PR gdb/24350
4693         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4694
4695 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4696
4697         PR gdb/24351
4698         * windows-nat.c (display_selector): Fix format specifiers.
4699
4700 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4701
4702         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4703         tui_refill_source_window instead of tui_refresh_win, to update the
4704         current execution line.  This fixes redisplay of the current line
4705         when stepping through the code with "next" or "step".
4706
4707 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4708
4709         * source-cache.c (source_cache::get_source_lines): Call
4710         find_source_lines to initialize s->nlines.  This fixes vertical
4711         scrolling of TUI source window when the DOWN arrow is pressed.
4712
4713 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4714
4715         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4716         linux-thread-db.c (_initialize_thread_db): Likewise.
4717
4718 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4719
4720         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4721         wclrtoeol in tui_show_source_line".  This reverts changes made in
4722         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4723
4724 2019-03-15  Tom Tromey  <tom@tromey.com>
4725
4726         * symtab.h (struct minimal_symbol): Derive from
4727         general_symbol_info.
4728         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4729         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4730         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4731         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4732         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4733         (MSYMBOL_SEARCH_NAME): Update.
4734         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4735         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4736         * minsyms.c (minimal_symbol_reader::record_full): Update.
4737
4738 2019-03-15  Tom Tromey  <tom@tromey.com>
4739
4740         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4741
4742 2019-03-15  Tom Tromey  <tom@tromey.com>
4743
4744         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4745         unique_xmalloc_ptr.
4746         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4747         Update.
4748         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4749         (build_minimal_symbol_hash_tables)
4750         (minimal_symbol_reader::install): Update.
4751
4752 2019-03-15  Tom Tromey  <tom@tromey.com>
4753
4754         * symtab.c (create_demangled_names_hash): Update.
4755         (symbol_set_names): Update.
4756         * objfiles.h (struct objfile_per_bfd_storage)
4757         <demangled_names_hash>: Now an htab_up.
4758         * objfiles.c (objfile_per_bfd_storage): Simplify.
4759
4760 2019-03-15  Tom Tromey  <tom@tromey.com>
4761
4762         * objfiles.h (struct objfile_per_bfd_storage): Declare
4763         destructor.
4764         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4765         New.
4766         (get_objfile_bfd_data): Use new.  Don't initialize
4767         language_of_main.
4768         (free_objfile_per_bfd_storage): Remove.
4769         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4770
4771 2019-03-15  Tom Tromey  <tom@tromey.com>
4772
4773         * symfile.c (reread_symbols): Update.
4774         * objfiles.c (objfile::objfile): Update.
4775         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4777         comment.
4778         (minimal_symbol_reader::install): Update.
4779         (terminate_minimal_symbol_table): Remove.
4780         * jit.c (jit_object_close_impl): Update.
4781
4782 2019-03-15  Tom Tromey  <tom@tromey.com>
4783
4784         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4785         initializations.
4786
4787 2019-03-15  Tom Tromey  <tom@tromey.com>
4788
4789         * objfiles.h (struct objfile_per_bfd_storage)
4790         <demangled_hash_languages>: Now a bitset.
4791         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4792         (lookup_minimal_symbol): Update.
4793
4794 2019-03-15  Tom Tromey  <tom@tromey.com>
4795
4796         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4797         Don't return the symbol.
4798         * coffread.c (record_minimal_symbol): Use record_full.
4799
4800 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4801
4802         The MS-Windows port of ncurses fails to switch to a color pair if
4803         one or both of the colors are the implicit default colors.  This
4804         change records the default colors when TUI is initialized, and
4805         then specifies them explicitly when a color pair uses the default
4806         colors.  This allows color styling in TUI mode on MS-Windows.
4807
4808         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4809         ncurses_norm_attr.
4810         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4811         colors in ncurses_norm_attr.
4812         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4813         "none", replace it with the default color recorded in
4814         ncurses_norm_attr.
4815
4816 2019-03-14  Tom Tromey  <tromey@adacore.com>
4817
4818         * source-cache.h (class source_cache) <get_source_lines>: Return
4819         std::string.
4820         * source-cache.c (source_cache::extract_lines): Handle case where
4821         first_pos==npos.  Return std::string.
4822         (source_cache::get_source_lines): Update.
4823
4824 2019-03-14  Tom Tromey  <tromey@adacore.com>
4825
4826         * NEWS: Add item for "style sources" commands.
4827         * source-cache.c (source_cache::get_source_lines): Check
4828         source_styling.
4829         * cli/cli-style.c (source_styling): New global.
4830         (_initialize_cli_style): Add "style sources" commands.
4831         (show_style_sources): New function.
4832         * cli/cli-style.h (source_styling): Declare.
4833
4834 2019-03-14  Pedro Alves  <palves@redhat.com>
4835             Tom Tromey  <tromey@adacore.com>
4836
4837         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4838         * tui/tui-winsource.c (tui_refill_source_window): New function,
4839         from...
4840         (tui_horizontal_source_scroll): ... here.  Move some logic.
4841         * cli/cli-style.c (set_style_enabled): Notify new observable.
4842         * tui/tui-hooks.c (tui_redisplay_source): New function.
4843         (tui_attach_detach_observers): Attach or detach
4844         tui_redisplay_source.
4845         * observable.h (source_styling_changed): New observable.
4846         * observable.c: Define source_styling_changed observable.
4847
4848 2019-03-13  Tom Tromey  <tromey@adacore.com>
4849
4850         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4851         (i386_gnu_nat_target::store_registers): Update.
4852         * target-debug.h (target_debug_print_std_string): New macro.
4853         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4854         * windows-tdep.c (display_one_tib): Update.
4855         * tui/tui-stack.c (tui_make_status_line): Update.
4856         * top.c (print_inferior_quit_action): Update.
4857         * thread.c (thr_try_catch_cmd): Update.
4858         (add_thread_with_info): Update.
4859         (thread_target_id_str): Update.
4860         (thr_try_catch_cmd): Update.
4861         (thread_command): Update.
4862         (thread_find_command): Update.
4863         * record-btrace.c (record_btrace_target::info_record)
4864         (record_btrace_resume_thread, record_btrace_target::resume)
4865         (record_btrace_cancel_resume, record_btrace_step_thread)
4866         (record_btrace_target::wait, record_btrace_target::wait)
4867         (record_btrace_target::wait, record_btrace_target::stop): Update.
4868         * progspace.c (print_program_space): Update.
4869         * process-stratum-target.c
4870         (process_stratum_target::thread_address_space): Update.
4871         * linux-fork.c (linux_fork_mourn_inferior)
4872         (detach_checkpoint_command, info_checkpoints_command)
4873         (linux_fork_context): Update.
4874         (linux_fork_detach): Update.
4875         (class scoped_switch_fork_info): Update.
4876         (delete_checkpoint_command): Update.
4877         * infrun.c (follow_fork_inferior): Update.
4878         (follow_fork_inferior): Update.
4879         (proceed_after_vfork_done): Update.
4880         (handle_vfork_child_exec_or_exit): Update.
4881         (follow_exec): Update.
4882         (displaced_step_prepare_throw): Update.
4883         (displaced_step_restore): Update.
4884         (start_step_over): Update.
4885         (resume_1): Update.
4886         (clear_proceed_status_thread): Update.
4887         (proceed): Update.
4888         (print_target_wait_results): Update.
4889         (do_target_wait): Update.
4890         (context_switch): Update.
4891         (stop_all_threads): Update.
4892         (restart_threads): Update.
4893         (finish_step_over): Update.
4894         (handle_signal_stop): Update.
4895         (switch_back_to_stepped_thread): Update.
4896         (keep_going_pass_signal): Update.
4897         (print_exited_reason): Update.
4898         (normal_stop): Update.
4899         * inferior.c (inferior_pid_to_str): Change return type.
4900         (print_selected_inferior): Update.
4901         (add_inferior): Update.
4902         (detach_inferior): Update.
4903         * dummy-frame.c (fprint_dummy_frames): Update.
4904         * dcache.c (dcache_info_1): Update.
4905         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4906         (btrace_fetch, btrace_clear): Update.
4907         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4908         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4909         type.
4910         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4911         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4912         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4913         * gdbarch.c, gdbarch.h: Rebuild.
4914         * gdbarch.sh (core_pid_to_str): Change return type.
4915         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4916         return type.
4917         (windows_nat_target::pid_to_str): Change return type.
4918         (windows_delete_thread): Update.
4919         (windows_nat_target::attach): Update.
4920         (windows_nat_target::files_info): Update.
4921         * target-delegates.c: Rebuild.
4922         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4923         return type.
4924         (sol_thread_target::pid_to_str): Change return type.
4925         * remote.c (class remote_target) <pid_to_str>: Change return
4926         type.
4927         (remote_target::pid_to_str): Change return type.
4928         (extended_remote_target::attach, remote_target::remote_stop_ns)
4929         (remote_target::remote_notif_remove_queued_reply)
4930         (remote_target::push_stop_reply, remote_target::disable_btrace):
4931         Update.
4932         (extended_remote_target::attach): Update.
4933         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4934         type.
4935         (gdbsim_target::pid_to_str): Change return type.
4936         * ravenscar-thread.c (struct ravenscar_thread_target)
4937         <pid_to_str>: Change return type.
4938         (ravenscar_thread_target::pid_to_str): Change return type.
4939         * procfs.c (class procfs_target) <pid_to_str>: Change return
4940         type.
4941         (procfs_target::pid_to_str): Change return type.
4942         (procfs_target::attach): Update.
4943         (procfs_target::detach): Update.
4944         (procfs_target::fetch_registers): Update.
4945         (procfs_target::store_registers): Update.
4946         (procfs_target::wait): Update.
4947         (procfs_target::files_info): Update.
4948         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4949         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4950         return type.
4951         (nto_procfs_target::pid_to_str): Change return type.
4952         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4953         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4954         return type.
4955         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4956         (exit_lwp): Update.
4957         (attach_proc_task_lwp_callback, get_detach_signal)
4958         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4959         (linux_nat_target::resume, wait_lwp, stop_callback)
4960         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4961         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4962         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4963         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4964         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4965         type.
4966         (inf_ptrace_target::attach): Update.
4967         (inf_ptrace_target::files_info): Update.
4968         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4969         type.
4970         (go32_nat_target::pid_to_str): Change return type.
4971         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4972         (gnu_nat_target::wait): Update.
4973         (gnu_nat_target::wait): Update.
4974         (gnu_nat_target::resume): Update.
4975         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4976         (fbsd_nat_target::wait): Update.
4977         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4978         type.
4979         (darwin_nat_target::attach): Update.
4980         * corelow.c (class core_target) <pid_to_str>: Change return type.
4981         (core_target::pid_to_str): Change return type.
4982         * target.c (normal_pid_to_str): Change return type.
4983         (default_pid_to_str): Likewise.
4984         (target_pid_to_str): Change return type.
4985         (target_translate_tls_address): Update.
4986         (target_announce_detach): Update.
4987         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4988         return type.
4989         (bsd_uthread_target::pid_to_str): Change return type.
4990         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4991         type.
4992         (bsd_kvm_target::pid_to_str): Change return type.
4993         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4994         return type.
4995         (aix_thread_target::pid_to_str): Change return type.
4996         * target.h (struct target_ops) <pid_to_str>: Change return type.
4997         (target_pid_to_str, normal_pid_to_str): Likewise.
4998         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4999         type.
5000         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5001         type.
5002         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5003         return type.
5004         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5005         type.
5006         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5007         type.
5008         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5009         return type.
5010
5011 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5012
5013         * NEWS: Mention that the new default MI version is 3.  Mention
5014         changes to the output of commands and events that deal with
5015         multi-location breakpoints.
5016         * breakpoint.c: Include "mi/mi-out.h".
5017         (print_one_breakpoint): Change output syntax if using MI version
5018         >= 3.
5019         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5020         New.
5021         (mi_multi_location_breakpoint_output_fixed): New.
5022         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5023         (mi_cmd_fix_multi_location_breakpoint_output): New.
5024         (mi_multi_location_breakpoint_output_fixed): New.
5025         * mi/mi-cmds.c (mi_cmds): Register command
5026         -fix-multi-location-breakpoint-output.
5027         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5028         interpreter "mi".
5029
5030 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5031
5032         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5033         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5034         instantiate mi_ui_out based on interpreter name.
5035         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5036         * mi/mi-main.c (mi_load_progress): Likewise.
5037
5038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5039
5040         * NEWS: Combine separate "New targets" sections for 8.3.
5041
5042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5043
5044         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5045         (ppcfbsd_init_abi): Install gdbarch
5046         "fetch_tls_load_module_address" and "get_thread_local_address"
5047         methods.
5048
5049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5050
5051         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5052         (riscv_fbsd_init_abi): Install gdbarch
5053         "fetch_tls_load_module_address" and "get_thread_local_address"
5054         methods.
5055
5056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5057
5058         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5059         (i386fbsd_init_abi): Install gdbarch
5060         "fetch_tls_load_module_address" and "get_thread_local_address"
5061         methods.
5062
5063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5064
5065         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5066         (amd64fbsd_init_abi): Install gdbarch
5067         "fetch_tls_load_module_address" and "get_thread_local_address"
5068         methods.
5069
5070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5071
5072         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5073         (struct fbsd_pspace_data): New type.
5074         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5075         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5076         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5077         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5078         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5079
5080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5081
5082         * gdbtypes.c (lookup_struct_elt): New function.
5083         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5084         * gdbtypes.h (struct struct_elt): New type.
5085         (lookup_struct_elt): New prototype.
5086
5087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5088
5089         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5090         remove disabled code block.
5091
5092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5093
5094         * gdbarch.sh (get_thread_local_address): New method.
5095         * gdbarch.h, gdbarch.c: Regenerate.
5096         * target.c (target_translate_tls_address): Use
5097         gdbarch_get_thread_local_address if present instead of
5098         target::get_thread_local_address.
5099
5100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5101
5102         * target.h (target::get_thread_local_address): Update comment.
5103
5104 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5105
5106         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5107         objfile->separate_debug_objfile_backlink if not NULL.
5108
5109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5110
5111         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5112         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5113         (amd64bsd_store_inferior_registers): Likewise.
5114         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5115         Enable segment base registers.
5116         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5117         PT_GETFSBASE and PT_GETGSBASE.
5118         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5119         PT_SETGSBASE.
5120         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5121         segment base registers.
5122         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5123
5124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5125
5126         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5127         Update calls to i386_target_description to add 'segments'
5128         parameter.
5129         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5130         add segment base registers.
5131         * arch/i386.c (i386_create_target_description): Add 'segments'
5132         parameter to enable segment base registers.
5133         * arch/i386.h (i386_create_target_description): Likewise.
5134         * features/i386/32bit-segments.xml: New file.
5135         * features/i386/32bit-segments.c: Generate.
5136         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5137         call to i386_target_description to add 'segments' parameter.
5138         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5139         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5140         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5141         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5142         if feature is present.
5143         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5144         Add 'segments' parameter to call to i386_target_description.
5145         (i386_target_description): Add 'segments' parameter to enable
5146         segment base registers.
5147         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5148         to call to i386_target_description.
5149         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5150         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5151         Define I386_NUM_REGS.
5152         (i386_target_description): Add 'segments' parameter to enable
5153         segment base registers.
5154
5155 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5156
5157         PR/24325
5158         * source-cache.c: #undef open and close, to avoid unresolved
5159         externals during linking.
5160
5161 2019-03-12  Tom Tromey  <tromey@adacore.com>
5162
5163         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5164         const.  Add initializers.
5165         (_initialize_remote): Don't initialize ptid globals.
5166
5167 2019-03-12  Pedro Alves  <palves@redhat.com>
5168
5169         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5170
5171 2019-03-12  Pedro Alves  <palves@redhat.com>
5172
5173         * cp-name-parser.y (main): Remove unused 'len' variable.
5174
5175 2019-03-12  Tom Tromey  <tromey@adacore.com>
5176
5177         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5178         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5179
5180 2019-03-12  Tom Tromey  <tromey@adacore.com>
5181
5182         * linux-nat.c (iterate_over_lwps): Update.
5183         (stop_callback): Remove parameter.
5184         (stop_wait_callback, detach_callback, resume_set_callback)
5185         (select_singlestep_lwp_callback, set_ignore_sigint)
5186         (status_callback, resumed_callback, resume_clear_callback)
5187         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5188         data parameter.
5189         (linux_nat_target::detach, linux_nat_target::resume)
5190         (linux_stop_and_wait_all_lwps, select_event_lwp)
5191         (linux_nat_filter_event, linux_nat_wait_1)
5192         (linux_nat_target::kill, linux_nat_target::stop)
5193         (linux_nat_target::stop): Update.
5194         (linux_nat_resume_callback): Change type.
5195         (resume_stopped_resumed_lwps, count_events_callback)
5196         (select_event_lwp_callback): Likewise.
5197         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5198         * arm-linux-nat.c (struct update_registers_data): Remove.
5199         (update_registers_callback): Change type.
5200         (arm_linux_insert_hw_breakpoint1): Update.
5201         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5202         parameter.
5203         (x86_linux_dr_set_addr): Update.
5204         (x86_linux_dr_set_control): Update.
5205         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5206         (iterate_over_lwps): Use gdb::function_view.
5207         * nat/aarch64-linux-hw-point.c (struct
5208         aarch64_dr_update_callback_param): Remove.
5209         (debug_reg_change_callback): Change type.
5210         (aarch64_notify_debug_reg_change): Update.
5211         * s390-linux-nat.c (s390_refresh_per_info): Update.
5212
5213 2019-03-11  Tom Tromey  <tromey@adacore.com>
5214
5215         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5216         redundant assignment to "this_cu".
5217
5218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5219
5220         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5221
5222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5223
5224         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5225         from...
5226         (rank_one_type): ... this.
5227
5228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5229
5230         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5231         from...
5232         (rank_one_type): ... this.
5233
5234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5235
5236         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5237         from...
5238         (rank_one_type): ... this.
5239
5240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5241
5242         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5243         from...
5244         (rank_one_type): ... this.
5245
5246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5247
5248         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5249         from...
5250         (rank_one_type): ... this.
5251
5252 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5253
5254         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5255         from...
5256         (rank_one_type): ... this.
5257
5258 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5259
5260         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5261         from...
5262         (rank_one_type): ... this.
5263
5264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5265
5266         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5267         from...
5268         (rank_one_type): ... this.
5269
5270 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5271
5272         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5273         from...
5274         (rank_one_type): ... this.
5275
5276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5277
5278         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5279         from...
5280         (rank_one_type): ... this.
5281
5282 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5283
5284         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5285         from...
5286         (rank_one_type): ... this.
5287
5288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5289
5290         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5291         from...
5292         (rank_one_type): ... this.
5293
5294 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5295
5296         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5297         inferior-events' shows the example events.
5298
5299 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5300
5301         Support styling on native MS-Windows console
5302
5303         PR/24315
5304         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5305         on MS-Windows if $TERM is not defined.
5306
5307         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5308
5309         * posix-hdep.c (gdb_console_fputs):
5310         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5311         functions.
5312         * ui-file.h (gdb_console_fputs): Add prototype.
5313
5314         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5315         back to fputs only if the former returns zero.
5316
5317 2019-03-07  Tom Tromey  <tom@tromey.com>
5318
5319         * symmisc.c (print_symbol_bcache_statistics): Update.
5320         (print_objfile_statistics): Update.
5321         * symfile.c (allocate_symtab): Update.
5322         * stabsread.c: Don't include bcache.h.
5323         * psymtab.h (struct psymbol_bcache): Don't declare.
5324         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5325         (psymbol_bcache_init, psymbol_bcache_free)
5326         (psymbol_bcache_get_bcache): Don't declare.
5327         * psymtab.c (struct psymbol_bcache): Remove.
5328         (psymtab_storage::psymtab_storage): Update.
5329         (psymtab_storage::~psymtab_storage): Update.
5330         (psymbol_bcache_init, psymbol_bcache_free)
5331         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5332         (add_psymbol_to_bcache): Update.
5333         (allocate_psymtab): Update.
5334         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5335         macro_cache>: No longer pointers.
5336         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5337         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5338         * macrotab.c (macro_bcache): Update.
5339         * macroexp.c: Don't include bcache.h.
5340         * gdbtypes.c (check_types_worklist): Update.
5341         (types_deeply_equal): Remove TRY/CATCH.  Update.
5342         * elfread.c (elf_symtab_read): Update.
5343         * dwarf2read.c: Don't include bcache.h.
5344         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5345         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5346         (print_bcache_statistics, bcache_memory_used): Don't declare.
5347         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5348         methods.  Rename all data members.
5349         * bcache.c (struct bcache): Move to bcache.h.
5350         (bcache::expand_hash_table): Rename from expand_hash_table.
5351         (bcache): Remove.
5352         (bcache::insert): Rename from bcache_full.
5353         (bcache::compare): Rename from bcache_compare.
5354         (bcache_xmalloc): Remove.
5355         (bcache::~bcache): Rename from bcache_xfree.
5356         (bcache::print_statistics): Rename from print_bcache_statistics.
5357         (bcache::memory_used): Rename from bcache_memory_used.
5358
5359 2019-03-07  Pedro Alves  <palves@redhat.com>
5360
5361         * infrun.c (normal_stop): Also check for
5362         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5363
5364 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * f-lang.c (value_from_host_double): Moved to...
5367         * value.c (value_from_host_double): ...here.
5368         * value.h (value_from_host_double): Declare.
5369         * guile/scm-math.c (vlscm_convert_typed_number): Use
5370         value_from_host_double.
5371         (vlscm_convert_number): Likewise.
5372         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5373         * python/py-value.c (convert_value_from_python): Likewise.
5374
5375 2019-03-06  Tom Tromey  <tom@tromey.com>
5376
5377         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5378
5379 2019-03-06  Tom Tromey  <tom@tromey.com>
5380
5381         * utils.h (free_current_contents): Don't declare.
5382         * utils.c (free_current_contents): Remove.
5383
5384 2019-03-06  Tom Tromey  <tom@tromey.com>
5385
5386         * top.c (quit_force): Update.
5387         * main.c (captured_command_loop): Update.
5388         * common/new-op.c (operator new): Update.
5389         * common/common-exceptions.c (struct catcher)
5390         <save_cleanup_chain>: Remove member.
5391         (exceptions_state_mc_init): Update.
5392         (exception_try_scope_entry): Return nullptr.
5393         (exception_try_scope_exit, exception_rethrow)
5394         (throw_exception_sjlj, throw_exception_cxx): Update.
5395         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5396         (all_cleanups, do_cleanups, discard_cleanups)
5397         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5398         (restore_cleanups, restore_final_cleanups): Don't declare.
5399         (do_final_cleanups): Remove parameter.
5400         * common/cleanups.c (cleanup_chain, make_cleanup)
5401         (make_cleanup_dtor, all_cleanups, do_cleanups)
5402         (discard_my_cleanups, discard_cleanups)
5403         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5404         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5405         (null_cleanup): Remove.
5406         (do_final_cleanups): Remove parameter.
5407
5408 2019-03-06  Tom Tromey  <tom@tromey.com>
5409
5410         * remote.c (remote_target::remote_parse_stop_reply): Use
5411         unique_xmalloc_ptr.
5412
5413 2019-03-06  Tom Tromey  <tom@tromey.com>
5414
5415         * stabsread.c (struct stabs_field_info): Rename from field_info.
5416         <list, fnlist>: Add initializers.
5417         <obstack>: New member.
5418         (read_member_functions, read_struct_fields, read_baseclasses):
5419         Allocate on obstack.  Don't use cleanups.
5420         (read_one_struct_field, read_member_functions, read_struct_fields)
5421         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5422         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5423         (read_struct_type): Update.
5424
5425 2019-03-06  Tom Tromey  <tom@tromey.com>
5426
5427         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5428         * common/filestuff.h (make_cleanup_close): Don't declare.
5429         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5430         Remove.
5431
5432 2019-03-06  Tom Tromey  <tom@tromey.com>
5433
5434         * solib-aix.c: Use make_scope_exit.
5435
5436 2019-03-06  Tom Tromey  <tom@tromey.com>
5437
5438         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5439         Use make_scope_exit.
5440
5441 2019-03-06  Tom Tromey  <tom@tromey.com>
5442
5443         * solib-svr4.c (disable_probes_interface): Remove parameter.
5444         (svr4_handle_solib_event): Use make_scope_exit.
5445
5446 2019-03-06  Tom Tromey  <tom@tromey.com>
5447
5448         * remote.c (struct stop_reply_deleter): Remove.
5449         (stop_reply_up): Update.
5450         (struct stop_reply): Derive from notif_event.  Don't typedef.
5451         <regcache>: Now a std::vector.
5452         (stop_reply_xfree): Remove.
5453         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5454         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5455         (remote_target::discard_pending_stop_replies): Use delete.
5456         (remote_target::remote_parse_stop_reply): Update.
5457         (remote_target::process_stop_reply): Update.
5458         * remote-notif.h (struct notif_event): Add virtual destructor.
5459         Remove "dtr" member.
5460         (struct notif_client) <alloc_event>: Return a unique_ptr.
5461         (notif_event_xfree): Don't declare.
5462         (notif_event_up): New typedef.
5463         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5464         (notif_event_xfree, do_notif_event_xfree): Remove.
5465         (remote_notif_state_xfree): Update.
5466
5467 2019-03-06  Tom Tromey  <tom@tromey.com>
5468
5469         * infrun.c (displaced_step_clear_cleanup): Now a
5470         forward_scope_exit type.
5471         (displaced_step_prepare_throw): Update.
5472         (displaced_step_fixup): Update.
5473
5474 2019-03-06  Tom Tromey  <tom@tromey.com>
5475
5476         * inferior.h (class inferior): Update comment.
5477         * gdbthread.h (class thread_info): Update comment.
5478
5479 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5480             Tom Tromey  <tom@tromey.com>
5481
5482         * stabsread.h (struct stab_section_list): Remove.
5483         (coffstab_build_psymtabs): Update.
5484         * dbxread.c (symbuf_sections): Now a std::vector.
5485         (sect_idx): New global.
5486         (fill_symbuf): Update.
5487         (coffstab_build_psymtabs): Change type of stabsects parameter.
5488         Update.
5489         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5490         std::vector.
5491         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5492         (coff_locate_sections): Update.
5493         (coff_symfile_read): Remove cleanups.  Update.
5494         (init_stringtab): Add storage parameter.
5495         (free_stringtab, free_stringtab_cleanup): Remove.
5496         (init_lineno): Add storage parameter.
5497         (free_linetab, free_linetab_cleanup): Remove.
5498
5499 2019-03-06  Pedro Alves  <palves@redhat.com>
5500
5501         * linux-fork.c (fork_info::clobber_regs): Delete.
5502         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5503         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5504         comment.  Adjust.
5505         (scoped_switch_fork_info::scoped_switch_fork_info)
5506         (checkpoint_command, linux_fork_context): Adjust
5507         fork_save_infrun_state calls.
5508
5509 2019-03-06  Pedro Alves  <palves@redhat.com>
5510
5511         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5512         (inf_has_multiple_threads): Return 'bool' and rewrite using
5513         inferior_info::threads().
5514
5515 2019-03-06  Pedro Alves  <palves@redhat.com>
5516
5517         * linux-fork.c: Include <list>.
5518         (fork_list): Now a std::list instance.
5519         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5520         (forks_exist_p, find_last_fork): Adjust.
5521         (new_fork): Delete.
5522         (one_fork_p): New.
5523         (add_fork): Adjust.
5524         (free_fork): Delete, folded into fork_info::~fork_info().
5525         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5526         Adjust.
5527         (init_fork_list): Delete.
5528         (linux_fork_killall, linux_fork_mourn_inferior)
5529         (linux_fork_detach, info_checkpoints_command): Adjust.
5530         (_initialize_linux_fork): No longer call init_fork_list.
5531
5532 2019-03-06  Pedro Alves  <palves@redhat.com>
5533
5534         * linux-fork.c (new_fork): New, split out of ...
5535         (add_fork): ... this.  Return void.  Move "first fork" special
5536         case from here, to ...
5537         (checkpoint_command): ... here.
5538         * linux-linux.h (add_fork): Return void.
5539
5540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5543
5544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5545             Chris January  <chris.january@arm.com>
5546             David Lecomber  <david.lecomber@arm.com>
5547
5548         * f-exp.y: New token, UNOP_INTRINSIC.
5549         (exp): New pattern using UNOP_INTRINSIC token.
5550         (f77_keywords): Add 'abs' keyword.
5551         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5552         (value_from_host_double): New function.
5553         (evaluate_subexp_f): Support UNOP_ABS.
5554
5555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5558         types.
5559
5560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5561
5562         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5563         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5564         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5565
5566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5569
5570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5571             Chris January  <chris.january@arm.com>
5572
5573         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5574         * f-exp.y: Define 'KIND' token.
5575         (exp): New pattern for KIND expressions.
5576         (ptype): Handle types with a kind extension.
5577         (direct_abs_decl): Extend to spot kind extensions.
5578         (f77_keywords): Add 'kind' to the list.
5579         (push_kind_type): New function.
5580         (convert_to_kind_type): New function.
5581         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5582         * parse.c (operator_length_standard): Likewise.
5583         * parser-defs.h (enum type_pieces): Add tp_kind.
5584         * std-operator.def: Add UNOP_KIND.
5585
5586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * f-exp.y (f_parse): Set yydebug.
5589
5590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5591
5592         * f-lang.c (evaluate_subexp_f): New function.
5593         (exp_descriptor_f): New global.
5594         (f_language_defn): Use exp_descriptor_f instead of
5595         exp_descriptor_standard.
5596
5597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * f-exp.y (struct token): Add comments.
5600         (dot_ops): Remove uppercase versions and the end marker.
5601         (f77_keywords): Likewise.
5602         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5603         entries in the dot_ops array are case insensitive, and use
5604         strncasecmp to compare strings.  Also some whitespace cleanup in
5605         this area.  Similar for the f77_keywords array, except entries in
5606         this list might be case sensitive.
5607
5608 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * f-exp.y (struct f77_boolean_val): Add comments.
5611         (boolean_values): Remove uppercase versions, and end marker.
5612         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5613         and use strncasecmp to achieve case insensitivity.  Additionally,
5614         perform whitespace cleanup around this code.
5615
5616 2019-03-06  Tom Tromey  <tromey@adacore.com>
5617
5618         * remote-sim.c (gdbsim_target_open): Use result of
5619         gdb_argv::release.
5620
5621 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5622         Dirk Schubert  <dirk.schubert@arm.com>
5623         Chris January  <chris.january@arm.com>
5624
5625         * eval.c (evaluate_subexp_standard): Call Fortran argument
5626         wrapping logic.
5627         * f-lang.c (struct value): A value which can be passed into a
5628         Fortran function call.
5629         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5630         where appropriate.
5631         (struct type): Value ready for a Fortran function call.
5632         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5633         is needed.
5634         * f-lang.h (fortran_argument_convert): Declaration.
5635         (fortran_preserve_arg_pointer): Declaration.
5636         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5637
5638 2019-03-05  Tom Tromey  <tromey@adacore.com>
5639
5640         * python/py-prettyprint.c (print_string_repr): Remove #if.
5641         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5642
5643 2019-03-05  Tom Tromey  <tromey@adacore.com>
5644
5645         * target.c (the_dummy_target): Move later.  Change type to
5646         "dummy_target".
5647         (initialize_targets): Don't initialize the_dummy_target.
5648
5649 2019-03-05  Tom Tromey  <tromey@adacore.com>
5650
5651         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5652         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5653
5654 2019-03-05  Tom Tromey  <tromey@adacore.com>
5655
5656         * windows-nat.c (windows_nat_target::attach)
5657         (windows_nat_target::detach): Don't call gdb_flush.
5658         * valprint.c (generic_val_print, val_print, val_print_string):
5659         Don't call gdb_flush.
5660         * utils.c (defaulted_query): Don't call gdb_flush.
5661         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5662         * target.c (target_announce_detach): Don't call gdb_flush.
5663         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5664         * remote.c (extended_remote_target::attach): Don't call
5665         gdb_flush.
5666         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5667         * printcmd.c (do_examine): Don't call gdb_flush.
5668         (info_display_command): Don't call gdb_flush.
5669         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5670         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5671         * memattr.c (info_mem_command): Don't call gdb_flush.
5672         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5673         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5674         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5675         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5676         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5677         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5678         (gnu_nat_target::detach): Don't call gdb_flush.
5679         * f-valprint.c (f_val_print): Don't call gdb_flush.
5680         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5681         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5682         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5683         gdb_flush.
5684         * c-valprint.c (c_val_print): Don't call gdb_flush.
5685         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5686
5687 2019-03-05  Tom Tromey  <tromey@adacore.com>
5688
5689         * varobj.c (update_dynamic_varobj_children): Update.
5690         (install_default_visualizer): Use reset, not release.
5691         * value.c (set_internalvar): Update.
5692         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5693         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5694         ATTRIBUTE_UNUSED_RESULT.
5695
5696 2019-03-05  Tom Tromey  <tromey@adacore.com>
5697
5698         * remote.c (class scoped_remote_fd) <release>: Add
5699         ATTRIBUTE_UNUSED_RESULT.
5700
5701 2019-03-05  Tom Tromey  <tromey@adacore.com>
5702
5703         * macroexp.c (struct macro_buffer) <release>: Add
5704         ATTRIBUTE_UNUSED_RESULT.
5705
5706 2019-03-05  Tom Tromey  <tromey@adacore.com>
5707
5708         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5709         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5710         ATTRIBUTE_UNUSED_RESULT.
5711
5712 2019-03-05  Tom Tromey  <tromey@adacore.com>
5713
5714         * common/scoped_fd.h (class scoped_fd) <release>: Add
5715         ATTRIBUTE_UNUSED_RESULT.
5716
5717 2019-03-05  Tom Tromey  <tromey@adacore.com>
5718
5719         * parser-defs.h (struct parser_state) <release>: Add
5720         ATTRIBUTE_UNUSED_RESULT.
5721
5722 2019-03-05  Tom Tromey  <tromey@adacore.com>
5723
5724         * utils.h (class gdb_argv) <release>: Add
5725         ATTRIBUTE_UNUSED_RESULT.
5726         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5727
5728 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5729
5730         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5731         for-loop range, to avoid compiler warnings.
5732
5733         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5734         avoid compiler warnings about unused variables.
5735
5736         * NEWS: Mention end of support for native debugging on MS-Windows
5737         before XP.
5738
5739         PR gdb/24292
5740         * common/netstuff.c:
5741         * gdbserver/gdbreplay.c
5742         * gdbserver/remote-utils.c:
5743         * ser-tcp.c:
5744         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5745         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5746         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5747         'getaddrinfo' and 'freeaddrinfo' were not available before
5748         Windows XP, and mingw.org's MinGW headers by default define
5749         _WIN32_WINNT to 0x500.
5750
5751 2019-03-01  Gary Benson <gbenson@redhat.com>
5752
5753         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5754
5755 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5756             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5757
5758         PR gdb/8527
5759         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5760         set_sigint_trap, clear_sigint_trap.
5761
5762 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5763
5764         * target.c (target_detach): Clear the regcache and the
5765         frame cache.
5766
5767 2019-02-27  Pedro Alves  <palves@redhat.com>
5768
5769         * utils.c (set_screen_size): When we cap the height/width sizes,
5770         tweak the corresponding command variable to show "unlimited":
5771
5772 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5773             Pedro Alves  <palves@redhat.com>
5774
5775         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5776         before calling rl_set_screen_size.
5777
5778 2019-02-27  Tom Tromey  <tromey@adacore.com>
5779
5780         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5781         define.
5782         * python/py-value.c: Remove Python 2.4 workaround.
5783         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5784         workaround.
5785         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5786         Python 2.4 workaround.
5787         * python/python-internal.h: Remove Python 2.4 comment.
5788         (Py_ssize_t): Don't define.
5789         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5790         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5791         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5792         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5793         * python/python.c (do_start_initialization): Remove Python 2.4
5794         workaround.
5795         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5796         (print_children): Remove Python 2.4 workaround.
5797         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5798         workaround.
5799         (CHARBUFFERPROC_NAME): Remove.
5800         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5801         Python 2.4 workaround.
5802
5803 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5804
5805         * NEWS: Note minimum Python version.
5806
5807 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5808
5809         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5810         code from these functions.  Remove corresponding ifdefs.  Use
5811         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5812         Remove gotos and target of gotos.
5813         (infpy_search_memory): Likewise.
5814
5815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5818         (hppa_gdbarch_init): Don't register deleted functions with
5819         gdbarch.
5820
5821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5822
5823         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5824         (h8300_unwind_sp): Delete.
5825         (h8300_dummy_id): Delete.
5826         (h8300_gdbarch_init): Don't register deleted functions with
5827         gdbarch.
5828
5829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5830
5831         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5832         (ft32_unwind_pc): Delete.
5833         (ft32_unwind_sp): Delete.
5834         (ft32_gdbarch_init): Don't register deleted functions with
5835         gdbarch.
5836
5837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5840         (frv_unwind_pc): Delete.
5841         (frv_unwind_sp): Delete.
5842         (frv_gdbarch_init): Don't register deleted functions with
5843         gdbarch.
5844
5845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5848         (riscv_unwind_pc): Delete.
5849         (riscv_unwind_sp): Delete.
5850         (riscv_gdbarch_init): Don't register deleted functions with
5851         gdbarch.
5852
5853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5856         (csky_unwind_pc): Delete.
5857         (csky_unwind_sp): Delete.
5858         (csky_gdbarch_init): Don't register deleted functions with
5859         gdbarch.
5860
5861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5864         (cris_unwind_pc): Delete.
5865         (cris_unwind_sp): Delete.
5866         (cris_gdbarch_init): Don't register deleted functions with
5867         gdbarch.
5868
5869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5872         (bfin_unwind_pc): Delete.
5873         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5874
5875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5878         (arm_unwind_pc): Delete.
5879         (arm_unwind_sp): Delete.
5880         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5881
5882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5885         (arc_unwind_pc): Delete.
5886         (arc_unwind_sp): Delete.
5887         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5888
5889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5892         (alpha_unwind_pc): Delete.
5893         (alpha_gdbarch_init): Don't register deleted functions with
5894         gdbarch.
5895
5896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5899         (aarch64_unwind_pc): Delete.
5900         (aarch64_unwind_sp): Delete.
5901         (aarch64_gdbarch_init): Don't register deleted functions with
5902         gdbarch.
5903
5904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5905
5906         * gdbtypes.c (type_align): Don't consider static members when
5907         computing structure alignment.
5908
5909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5912         return 0 for other types.
5913         * arch-utils.c (default_type_align): Always return 0.
5914         * gdbarch.h: Regenerate.
5915         * gdbarch.sh (type_align): Extend comment.
5916         * gdbtypes.c (type_align): Add additional comments, always call
5917         gdbarch_type_align before applying the default rules.
5918         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5919         generic code will then apply a suitable default.
5920         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5921         types, return 0 for other types.
5922
5923 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5924
5925         * NEWS: Create a new section for the next release branch.
5926         Rename the section of the current branch, now that it has
5927         been cut.
5928
5929 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5930
5931         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5932         * version.in: Bump version to 8.3.50.DATE-git.
5933
5934 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5935
5936         * aix-thread.c (ptid_cmp): Remove unused variable.
5937         (get_signaled_thread): Likewise.
5938         (store_regs_user_thread): Likewise.
5939         (store_regs_kernel_thread): Likewise.
5940         (fetch_regs_kernel_thread): Remove shadowed variable.
5941
5942 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * features/riscv/32bit-cpu.xml: Add register numbers.
5945         * features/riscv/32bit-fpu.c: Regenerate.
5946         * features/riscv/32bit-fpu.xml: Add register numbers.
5947         * features/riscv/64bit-cpu.xml: Add register numbers.
5948         * features/riscv/64bit-fpu.c: Regenerate.
5949         * features/riscv/64bit-fpu.xml: Add register numbers.
5950
5951 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5952
5953         * NEWS: Mention two argument form of gdb.Value constructor.
5954         * python/py-value.c (convert_buffer_and_type_to_value): New
5955         function.
5956         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5957         Add support for handling an optional second argument.  Call
5958         convert_buffer_and_type_to_value as appropriate.
5959         * python/python-internal.h (Py_buffer_deleter): New struct.
5960         (Py_buffer_up): New typedef.
5961
5962 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5963
5964         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5965         instead of releasing ownership.
5966
5967 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5968
5969         * dwarf2read.c (open_and_init_dwp_file): Call
5970         elf_numsections instead of bfd_count_sections to initialize
5971         dwp_file->num_sections.
5972
5973 2019-02-25  Tom Tromey  <tromey@adacore.com>
5974
5975         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5976
5977 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5978
5979         * gcore.in: Add '--readnever' option when invoking GDB.
5980
5981 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5982
5983         * MAINTAINERS: Update my email address.
5984
5985 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5986
5987         * build-id.c (build_id_to_debug_bfd_1): New function.
5988         (build_id_to_debug_bfd): Look for separate debug file in
5989         sysroot.
5990
5991 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * gdbarch.sh: Update the copyright year range that is placed into
5994         generated files.
5995
5996 2019-02-22  Keith Seitz  <keiths@redhat.com>
5997
5998         PR symtab/23853
5999         * linespec.c (create_sals_line_offset): Search for the default
6000         symtab's filename instead of its fullname.
6001
6002 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6003
6004         * NEWS: Update style defaults.
6005
6006 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * main.c (captured_main_1): Disable styling in batch mode.
6009
6010 2019-02-20  Tom Tromey  <tom@tromey.com>
6011
6012         * symtab.c (symtab_symbol_info): Fix typos.
6013
6014 2019-02-20  Tom Tromey  <tromey@adacore.com>
6015
6016         * findcmd.c (_initialize_mem_search): Use upper case for
6017         metasyntactic variables.
6018
6019 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6020
6021         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6022         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6023
6024 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6025
6026         * top.h (source_file_name): Change to std::string.
6027         * top.c (source_file_name): Likewise.
6028         (command_line_input): Adjust.
6029         * cli/cli-script.c (script_from_file): Adjust.
6030
6031 2019-02-19  Tom Tromey  <tromey@adacore.com>
6032
6033         * ravenscar-thread.c
6034         (ravenscar_thread_target::update_thread_list): Don't call
6035         ada_build_task_list.
6036         * ada-lang.h (ada_build_task_list): Don't declare.
6037         * ada-tasks.c (struct ada_tasks_inferior_data)
6038         <task_list_valid_p>: Now bool.
6039         (read_known_tasks, ada_task_list_changed)
6040         (ada_tasks_invalidate_inferior_data): Update.
6041         (read_known_tasks_array): Return bool.
6042         (read_known_tasks_list): Likewise.
6043         (read_known_tasks): Return void.
6044         (ada_build_task_list): Now static.
6045
6046 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6049         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6050
6051 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6052
6053         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6054         variant for ada_tasks_pspace_data_handle and
6055         ada_tasks_inferior_data_handle.
6056         (ada_tasks_pspace_data_cleanup): New function.
6057         (ada_tasks_inferior_data_cleanup): New function.
6058
6059 2019-02-17  Tom Tromey  <tom@tromey.com>
6060
6061         * macrotab.h (macro_source_fullname): Return a std::string.
6062         * macrotab.c (macro_include, check_for_redefinition)
6063         (macro_undef, macro_lookup_definition, foreach_macro)
6064         (foreach_macro_in_scope): Update.
6065         (macro_source_fullname): Return a std::string.
6066         * macrocmd.c (show_pp_source_pos): Update.
6067
6068 2019-02-17  Tom Tromey  <tom@tromey.com>
6069
6070         * macrocmd.c (show_pp_source_pos): Style the file names.
6071
6072 2019-02-17  Tom Tromey  <tom@tromey.com>
6073
6074         PR tui/24197:
6075         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6076
6077 2019-02-17  Tom Tromey  <tom@tromey.com>
6078
6079         * ada-lang.c (user_select_syms): Use filtered printing.
6080         * utils.c (wrap_style): New global.
6081         (desired_style): Remove.
6082         (emit_style_escape): Add stream parameter.
6083         (set_output_style, reset_terminal_style, prompt_for_continue):
6084         Update.
6085         (flush_wrap_buffer): Only flush gdb_stdout.
6086         (wrap_here): Set wrap_style.
6087         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6088         treat escape sequences as a character.  Change when wrap buffer is
6089         flushed.
6090         (fputs_styled): Do not set the output style when the default is
6091         requested.
6092         * ui-style.h (struct ui_file_style) <is_default>: New method.
6093         * source.c (print_source_lines_base): Emit escape sequences in one
6094         piece.
6095
6096 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6097
6098         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6099         integers and enumeration types.
6100
6101 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6102
6103         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6104         instead of lookup_symbol_in_language
6105         (do_exact_match): New function.
6106         (ada_get_symbol_name_matcher): Return do_exact_match when
6107         doing a verbatim match.
6108
6109 2019-02-15  Tom Tromey  <tromey@adacore.com>
6110
6111         * ravenscar-thread.c (ravenscar_thread_target::resume)
6112         (ravenscar_thread_target::wait): Special case wildcard requests.
6113
6114 2019-02-15  Tom Tromey  <tromey@adacore.com>
6115
6116         * ravenscar-thread.c (base_ptid): Remove.
6117         (struct ravenscar_thread_target) <close>: New method.
6118         <m_base_ptid>: New member.
6119         <update_inferior_ptid, active_task, task_is_currently_active,
6120         runtime_initialized>: Declare methods.
6121         <ravenscar_thread_target>: Add constructor.
6122         (ravenscar_thread_target::task_is_currently_active)
6123         (ravenscar_thread_target::update_inferior_ptid)
6124         (ravenscar_runtime_initialized): Rename.  Now methods.
6125         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6126         (ravenscar_thread_target::update_thread_list): Update.
6127         (ravenscar_thread_target::active_task): Now method.
6128         (ravenscar_thread_target::store_registers)
6129         (ravenscar_thread_target::prepare_to_store)
6130         (ravenscar_thread_target::prepare_to_store)
6131         (ravenscar_thread_target::mourn_inferior): Update.
6132         (ravenscar_inferior_created): Use "new" to create target.
6133         (ravenscar_thread_target::get_ada_task_ptid): Update.
6134         (_initialize_ravenscar): Don't initialize base_ptid.
6135         (ravenscar_ops): Remove global.
6136
6137 2019-02-15  Tom Tromey  <tromey@adacore.com>
6138
6139         * target.h (push_target): Declare new overload.
6140         * target.c (push_target): New overload, taking an rvalue reference.
6141         * remote.c (remote_target::open_1): Use push_target overload.
6142         * corelow.c (core_target_open): Use push_target overload.
6143
6144 2019-02-15  Tom Tromey  <tromey@adacore.com>
6145
6146         * ravenscar-thread.c (is_ravenscar_task)
6147         (ravenscar_task_is_currently_active): Return bool.
6148         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6149         (_initialize_ravenscar): Remove "(void)".
6150         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6151         Return bool.
6152
6153 2019-02-15  Tom Tromey  <tromey@adacore.com>
6154
6155         * ravenscar-thread.c (ravenscar_runtime_initializer)
6156         (has_ravenscar_runtime, get_running_thread_id)
6157         (ravenscar_thread_target::resume): Fix indentation.
6158
6159 2019-02-15  Tom Tromey  <tromey@adacore.com>
6160
6161         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6162         from ravenscar_arch_ops.
6163         (sparc_ravenscar_ops::fetch_registers)
6164         (sparc_ravenscar_ops::store_registers): Now methods.
6165         (sparc_ravenscar_prepare_to_store): Remove.
6166         (sparc_ravenscar_ops): Redefine.
6167         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6168         methods and destructor.  Remove members.
6169         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6170         (ravenscar_thread_target::store_registers)
6171         (ravenscar_thread_target::prepare_to_store): Update.
6172         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6173         Remove.
6174         (struct ppc_ravenscar_powerpc_ops): Derive from
6175         ravenscar_arch_ops.
6176         (ppc_ravenscar_powerpc_ops::fetch_registers)
6177         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6178         (ppc_ravenscar_powerpc_ops): Redefine.
6179         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6180         (ppc_ravenscar_e500_ops::fetch_registers)
6181         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6182         (ppc_ravenscar_e500_ops): Redefine.
6183         * aarch64-ravenscar-thread.c
6184         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6185         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6186         (aarch64_ravenscar_fetch_registers)
6187         (aarch64_ravenscar_store_registers): Now methods.
6188         (aarch64_ravenscar_ops): Redefine.
6189
6190 2019-02-15  Tom Tromey  <tromey@adacore.com>
6191
6192         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6193         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6194         (ravenscar_thread_target::stopped_by_watchpoint)
6195         (ravenscar_thread_target::stopped_data_address)
6196         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6197
6198 2019-02-15  Tom Tromey  <tromey@adacore.com>
6199
6200         * ravenscar-thread.c: Fix some typos.
6201
6202 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6203             Tom Tromey  <tromey@adacore.com>
6204
6205         * ada-lang.c (ada_exception_sal): Change addr_string to a
6206         std::string.
6207         (create_ada_exception_catchpoint): Update.
6208
6209 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6210             Tom Tromey  <tromey@adacore.com>
6211
6212         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6213         (bp_location_ops): Remove.
6214         (base_breakpoint_allocate_location): Update.
6215         (free_bp_location): Update.
6216         * ada-lang.c (class ada_catchpoint_location)
6217         <ada_catchpoint_location>: Remove ops parameter.
6218         (ada_catchpoint_location_dtor): Remove.
6219         (ada_catchpoint_location_ops): Remove.
6220         (allocate_location_exception): Update.
6221         * breakpoint.h (struct bp_location_ops): Remove.
6222         (class bp_location) <bp_location>: Remove bp_location_ops
6223         parameter.
6224         <~bp_location>: Add destructor.
6225         <ops>: Remove.
6226
6227 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6228             Pedro Alves  <palves@redhat.com>
6229
6230         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6231         'PATH_MAX'.
6232
6233 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6234             Samuel Thibault  <samuel.thibault@gnu.org>
6235             Thomas Schwinge  <thomas@codesourcery.com>
6236
6237         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6238         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6239
6240 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6241
6242         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6243         (check_empty): Use "const char *".
6244
6245         * gnu-nat.c (gnu_nat_target::detach): Instead of
6246         'detach_inferior (pid)' call
6247         'detach_inferior (find_inferior_pid (pid))'.
6248
6249         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6250         'nat/fork-inferior.o'.
6251         * gnu-nat.c: #include "nat/fork-inferior.h".
6252
6253         * gnu-nat.c (gnu_nat_target::detach): Instead of
6254         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6255         * gnu-nat.h: #include "inf-child.h".
6256         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6257         'i386_gnu_nat_target::fetch_registers'.
6258         (gnu_store_registers): Rename/move to
6259         'i386_gnu_nat_target::store_registers'.
6260
6261         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6262         * gnu-nat.h (mach_thread_info): New function.
6263         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6264
6265         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6266
6267 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6268
6269         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6270
6271 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6272
6273         * windows-nat.c (windows_add_thread): Add new parameter
6274         "main_thread_p" with default value set to false.  Update
6275         function documentation as well as all callers.
6276         (windows_delete_thread): Likewise.
6277         (fake_create_process): Update call to windows_add_thread.
6278         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6279         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6280         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6281         call to windows_delete_thread.
6282
6283 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6284
6285         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6286
6287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6288
6289         * symfile.c (find_separate_debug_file): Use canonical path of
6290         sysroot with child_path instead of gdb_sysroot if it is valid.
6291
6292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6293
6294         * symfile.c (find_separate_debug_file): Use child_path to
6295         determine if an object file is under a sysroot.
6296
6297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6298
6299         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6300         unittests/child-path-selftests.c.
6301         * common/pathstuff.c (child_path): New function.
6302         * common/pathstuff.h (child_path): New prototype.
6303         * unittests/child-path-selftests.c: New file.
6304
6305 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6306
6307         * symfile.c (find_separate_debug_file): Look for separate debug
6308         files in debug directories under the sysroot.
6309
6310 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6311
6312         * symtab.h (struct minimal_symbol data_p): New const method.
6313         (struct minimal_symbol text_p): Likewise.
6314         * symtab.c (output_source_filename): Use file name style
6315         to print file name.
6316         (print_symbol_info): Likewise.
6317         (print_msymbol_info): Use address style to print addresses.
6318         Use function name style to print executable text symbols.
6319         (expand_symtab_containing_pc): Use data_p.
6320         (find_pc_sect_compunit_symtab): Likewise.
6321
6322 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6323
6324         * breakpoint.c (describe_other_breakpoints): Use address style
6325         to print addresses.
6326         (say_where): Likewise.
6327
6328 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6329
6330         * ada-typeprint.c (print_func_type): Print function name
6331         style to print function name.
6332         * c-typeprint.c (c_print_type_1): Likewise.
6333
6334 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6335
6336         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6337         for execve.
6338
6339 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6340
6341         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6342         type_stack.
6343
6344 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6345
6346         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6347         TYPE_CODE_REF types.
6348
6349 2019-02-08  Jim Wilson  <jimw@sifive.com>
6350
6351         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6352         (riscv_linux_fregset): New.
6353         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6354
6355 2019-02-07  Tom Tromey  <tom@tromey.com>
6356
6357         * thread.c (thread_cancel_execution_command): Update.
6358         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6359         methods.
6360         (struct thread_fsm_ops): Remove.
6361         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6362         (thread_fsm_should_stop, thread_fsm_return_value)
6363         (thread_fsm_set_finished, thread_fsm_finished_p)
6364         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6365         Don't declare.
6366         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6367         * infrun.c (clear_proceed_status_thread)
6368         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6369         (print_stop_event): Update.
6370         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6371         Add constructor.
6372         (step_command_fsm_ops): Remove.
6373         (new_step_command_fsm): Remove.
6374         (step_1): Update.
6375         (step_command_fsm::should_stop): Rename from
6376         step_command_fsm_should_stop.
6377         (step_command_fsm::clean_up): Rename from
6378         step_command_fsm_clean_up.
6379         (step_command_fsm::do_async_reply_reason): Rename from
6380         step_command_fsm_async_reply_reason.
6381         (struct until_next_fsm): Inherit from thread_fsm.  Add
6382         constructor.
6383         (until_next_fsm_ops): Remove.
6384         (new_until_next_fsm): Remove.
6385         (until_next_fsm::should_stop): Rename from
6386         until_next_fsm_should_stop.
6387         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6388         (until_next_fsm::do_async_reply_reason): Rename from
6389         until_next_fsm_async_reply_reason.
6390         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6391         constructor.  Change type of breakpoint.
6392         (finish_command_fsm_ops): Remove.
6393         (new_finish_command_fsm): Remove.
6394         (finish_command_fsm::should_stop): Rename from
6395         finish_command_fsm_should_stop.
6396         (finish_command_fsm::clean_up): Rename from
6397         finish_command_fsm_clean_up.
6398         (finish_command_fsm::return_value): Rename from
6399         finish_command_fsm_return_value.
6400         (finish_command_fsm::do_async_reply_reason): Rename from
6401         finish_command_fsm_async_reply_reason.
6402         (finish_command): Update.
6403         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6404         Add constructor.
6405         (call_thread_fsm_ops): Remove.
6406         (call_thread_fsm::call_thread_fsm): Rename from
6407         new_call_thread_fsm.
6408         (call_thread_fsm::should_stop): Rename from
6409         call_thread_fsm_should_stop.
6410         (call_thread_fsm::should_notify_stop): Rename from
6411         call_thread_fsm_should_notify_stop.
6412         (run_inferior_call, call_function_by_hand_dummy): Update.
6413         * cli/cli-interp.c (should_print_stop_to_console): Update.
6414         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6415         Add constructor.  Change type of location_breakpoint,
6416         caller_breakpoint.
6417         (until_break_fsm_ops): Remove.
6418         (new_until_break_fsm): Remove.
6419         (until_break_fsm::should_stop): Rename from
6420         until_break_fsm_should_stop.
6421         (until_break_fsm::clean_up): Rename from
6422         until_break_fsm_clean_up.
6423         (until_break_fsm::do_async_reply_reason): Rename from
6424         until_break_fsm_async_reply_reason.
6425         (until_break_command): Update.
6426         * thread-fsm.c: Remove.
6427         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6428
6429 2019-02-07  Tom Tromey  <tom@tromey.com>
6430
6431         * yy-remap.h: Add include guard.
6432         * xtensa-tdep.h: Add include guard.
6433         * xcoffread.h: Rename include guard.
6434         * varobj-iter.h: Add include guard.
6435         * tui/tui.h: Rename include guard.
6436         * tui/tui-winsource.h: Rename include guard.
6437         * tui/tui-wingeneral.h: Rename include guard.
6438         * tui/tui-windata.h: Rename include guard.
6439         * tui/tui-win.h: Rename include guard.
6440         * tui/tui-stack.h: Rename include guard.
6441         * tui/tui-source.h: Rename include guard.
6442         * tui/tui-regs.h: Rename include guard.
6443         * tui/tui-out.h: Rename include guard.
6444         * tui/tui-layout.h: Rename include guard.
6445         * tui/tui-io.h: Rename include guard.
6446         * tui/tui-hooks.h: Rename include guard.
6447         * tui/tui-file.h: Rename include guard.
6448         * tui/tui-disasm.h: Rename include guard.
6449         * tui/tui-data.h: Rename include guard.
6450         * tui/tui-command.h: Rename include guard.
6451         * tic6x-tdep.h: Add include guard.
6452         * target/waitstatus.h: Rename include guard.
6453         * target/wait.h: Rename include guard.
6454         * target/target.h: Rename include guard.
6455         * target/resume.h: Rename include guard.
6456         * target-float.h: Rename include guard.
6457         * stabsread.h: Add include guard.
6458         * rs6000-tdep.h: Add include guard.
6459         * riscv-fbsd-tdep.h: Add include guard.
6460         * regformats/regdef.h: Rename include guard.
6461         * record.h: Rename include guard.
6462         * python/python.h: Rename include guard.
6463         * python/python-internal.h: Rename include guard.
6464         * python/py-stopevent.h: Rename include guard.
6465         * python/py-ref.h: Rename include guard.
6466         * python/py-record.h: Rename include guard.
6467         * python/py-record-full.h: Rename include guard.
6468         * python/py-record-btrace.h: Rename include guard.
6469         * python/py-instruction.h: Rename include guard.
6470         * python/py-events.h: Rename include guard.
6471         * python/py-event.h: Rename include guard.
6472         * procfs.h: Add include guard.
6473         * proc-utils.h: Add include guard.
6474         * p-lang.h: Add include guard.
6475         * or1k-tdep.h: Rename include guard.
6476         * observable.h: Rename include guard.
6477         * nto-tdep.h: Rename include guard.
6478         * nat/x86-linux.h: Rename include guard.
6479         * nat/x86-linux-dregs.h: Rename include guard.
6480         * nat/x86-gcc-cpuid.h: Add include guard.
6481         * nat/x86-dregs.h: Rename include guard.
6482         * nat/x86-cpuid.h: Rename include guard.
6483         * nat/ppc-linux.h: Rename include guard.
6484         * nat/mips-linux-watch.h: Rename include guard.
6485         * nat/linux-waitpid.h: Rename include guard.
6486         * nat/linux-ptrace.h: Rename include guard.
6487         * nat/linux-procfs.h: Rename include guard.
6488         * nat/linux-osdata.h: Rename include guard.
6489         * nat/linux-nat.h: Rename include guard.
6490         * nat/linux-namespaces.h: Rename include guard.
6491         * nat/linux-btrace.h: Rename include guard.
6492         * nat/glibc_thread_db.h: Rename include guard.
6493         * nat/gdb_thread_db.h: Rename include guard.
6494         * nat/gdb_ptrace.h: Rename include guard.
6495         * nat/fork-inferior.h: Rename include guard.
6496         * nat/amd64-linux-siginfo.h: Rename include guard.
6497         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6498         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6499         * nat/aarch64-linux.h: Rename include guard.
6500         * nat/aarch64-linux-hw-point.h: Rename include guard.
6501         * mn10300-tdep.h: Add include guard.
6502         * mips-linux-tdep.h: Add include guard.
6503         * mi/mi-parse.h: Rename include guard.
6504         * mi/mi-out.h: Rename include guard.
6505         * mi/mi-main.h: Rename include guard.
6506         * mi/mi-interp.h: Rename include guard.
6507         * mi/mi-getopt.h: Rename include guard.
6508         * mi/mi-console.h: Rename include guard.
6509         * mi/mi-common.h: Rename include guard.
6510         * mi/mi-cmds.h: Rename include guard.
6511         * mi/mi-cmd-break.h: Rename include guard.
6512         * m2-lang.h: Add include guard.
6513         * location.h: Rename include guard.
6514         * linux-record.h: Rename include guard.
6515         * linux-nat.h: Add include guard.
6516         * linux-fork.h: Add include guard.
6517         * i386-darwin-tdep.h: Rename include guard.
6518         * hppa-linux-offsets.h: Add include guard.
6519         * guile/guile.h: Rename include guard.
6520         * guile/guile-internal.h: Rename include guard.
6521         * gnu-nat.h: Rename include guard.
6522         * gdb-stabs.h: Rename include guard.
6523         * frv-tdep.h: Add include guard.
6524         * f-lang.h: Add include guard.
6525         * event-loop.h: Add include guard.
6526         * darwin-nat.h: Rename include guard.
6527         * cp-abi.h: Rename include guard.
6528         * config/sparc/nm-sol2.h: Rename include guard.
6529         * config/nm-nto.h: Rename include guard.
6530         * config/nm-linux.h: Add include guard.
6531         * config/i386/nm-i386gnu.h: Rename include guard.
6532         * config/djgpp/nl_types.h: Rename include guard.
6533         * config/djgpp/langinfo.h: Rename include guard.
6534         * compile/gcc-cp-plugin.h: Add include guard.
6535         * compile/gcc-c-plugin.h: Add include guard.
6536         * compile/compile.h: Rename include guard.
6537         * compile/compile-object-run.h: Rename include guard.
6538         * compile/compile-object-load.h: Rename include guard.
6539         * compile/compile-internal.h: Rename include guard.
6540         * compile/compile-cplus.h: Rename include guard.
6541         * compile/compile-c.h: Rename include guard.
6542         * common/xml-utils.h: Rename include guard.
6543         * common/x86-xstate.h: Rename include guard.
6544         * common/version.h: Rename include guard.
6545         * common/vec.h: Rename include guard.
6546         * common/tdesc.h: Rename include guard.
6547         * common/selftest.h: Rename include guard.
6548         * common/scoped_restore.h: Rename include guard.
6549         * common/scoped_mmap.h: Rename include guard.
6550         * common/scoped_fd.h: Rename include guard.
6551         * common/safe-iterator.h: Rename include guard.
6552         * common/run-time-clock.h: Rename include guard.
6553         * common/refcounted-object.h: Rename include guard.
6554         * common/queue.h: Rename include guard.
6555         * common/ptid.h: Rename include guard.
6556         * common/print-utils.h: Rename include guard.
6557         * common/preprocessor.h: Rename include guard.
6558         * common/pathstuff.h: Rename include guard.
6559         * common/observable.h: Rename include guard.
6560         * common/netstuff.h: Rename include guard.
6561         * common/job-control.h: Rename include guard.
6562         * common/host-defs.h: Rename include guard.
6563         * common/gdb_wait.h: Rename include guard.
6564         * common/gdb_vecs.h: Rename include guard.
6565         * common/gdb_unlinker.h: Rename include guard.
6566         * common/gdb_unique_ptr.h: Rename include guard.
6567         * common/gdb_tilde_expand.h: Rename include guard.
6568         * common/gdb_sys_time.h: Rename include guard.
6569         * common/gdb_string_view.h: Rename include guard.
6570         * common/gdb_splay_tree.h: Rename include guard.
6571         * common/gdb_setjmp.h: Rename include guard.
6572         * common/gdb_ref_ptr.h: Rename include guard.
6573         * common/gdb_optional.h: Rename include guard.
6574         * common/gdb_locale.h: Rename include guard.
6575         * common/gdb_assert.h: Rename include guard.
6576         * common/filtered-iterator.h: Rename include guard.
6577         * common/filestuff.h: Rename include guard.
6578         * common/fileio.h: Rename include guard.
6579         * common/environ.h: Rename include guard.
6580         * common/common-utils.h: Rename include guard.
6581         * common/common-types.h: Rename include guard.
6582         * common/common-regcache.h: Rename include guard.
6583         * common/common-inferior.h: Rename include guard.
6584         * common/common-gdbthread.h: Rename include guard.
6585         * common/common-exceptions.h: Rename include guard.
6586         * common/common-defs.h: Rename include guard.
6587         * common/common-debug.h: Rename include guard.
6588         * common/cleanups.h: Rename include guard.
6589         * common/buffer.h: Rename include guard.
6590         * common/btrace-common.h: Rename include guard.
6591         * common/break-common.h: Rename include guard.
6592         * cli/cli-utils.h: Rename include guard.
6593         * cli/cli-style.h: Rename include guard.
6594         * cli/cli-setshow.h: Rename include guard.
6595         * cli/cli-script.h: Rename include guard.
6596         * cli/cli-interp.h: Rename include guard.
6597         * cli/cli-decode.h: Rename include guard.
6598         * cli/cli-cmds.h: Rename include guard.
6599         * charset-list.h: Add include guard.
6600         * buildsym-legacy.h: Rename include guard.
6601         * bfin-tdep.h: Add include guard.
6602         * ax.h: Rename include guard.
6603         * arm-linux-tdep.h: Add include guard.
6604         * arm-fbsd-tdep.h: Add include guard.
6605         * arch/xtensa.h: Rename include guard.
6606         * arch/tic6x.h: Add include guard.
6607         * arch/i386.h: Add include guard.
6608         * arch/arm.h: Rename include guard.
6609         * arch/arm-linux.h: Rename include guard.
6610         * arch/arm-get-next-pcs.h: Rename include guard.
6611         * arch/amd64.h: Add include guard.
6612         * arch/aarch64-insn.h: Rename include guard.
6613         * arch-utils.h: Rename include guard.
6614         * annotate.h: Add include guard.
6615         * amd64-darwin-tdep.h: Rename include guard.
6616         * aarch64-linux-tdep.h: Add include guard.
6617         * aarch64-fbsd-tdep.h: Add include guard.
6618         * aarch32-linux-nat.h: Add include guard.
6619
6620 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6621
6622         * macrotab.c (macro_define_internal): New function that
6623         factorizes macro_define_object_internal and macro_define_function
6624         code.
6625         (macro_define_object_internal): Use macro_define_internal.
6626         (macro_define_function): Likewise.
6627
6628 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6629
6630         * macrocmd.c (extract_identifier): Return
6631         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6632         callers.
6633
6634 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6635
6636         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6637
6638 2019-02-05  Tom Tromey  <tom@tromey.com>
6639
6640         * target.c (target_stack::unpush): Move assertion earlier.
6641
6642 2019-01-30  Tom Tromey  <tom@tromey.com>
6643
6644         PR python/23615:
6645         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6646         (gdbpy_parse_and_eval): Likewise.
6647         * python/python-internal.h (gdbpy_allow_threads): New class.
6648
6649 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6650
6651         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6652         (aarch64_fbsd_fpregmap): Move earlier.
6653         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6654         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6655         instead of individual calls to trad_frame_set_reg_addr.
6656         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6657         earlier.
6658         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6659         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6660         instead of individual calls to trad_frame_set_reg_addr.
6661
6662 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6663
6664         * CONTRIBUTE: Replace contribution list with wiki link.
6665
6666 2019-01-25  Tom Tromey  <tom@tromey.com>
6667
6668         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6669
6670 2019-01-25  Tom Tromey  <tom@tromey.com>
6671
6672         * xtensa-linux-nat.c: Fix common/ includes.
6673         * xml-support.h: Fix common/ includes.
6674         * xml-support.c: Fix common/ includes.
6675         * x86-linux-nat.c: Fix common/ includes.
6676         * windows-nat.c: Fix common/ includes.
6677         * varobj.h: Fix common/ includes.
6678         * varobj.c: Fix common/ includes.
6679         * value.c: Fix common/ includes.
6680         * valops.c: Fix common/ includes.
6681         * utils.c: Fix common/ includes.
6682         * unittests/xml-utils-selftests.c: Fix common/ includes.
6683         * unittests/utils-selftests.c: Fix common/ includes.
6684         * unittests/unpack-selftests.c: Fix common/ includes.
6685         * unittests/tracepoint-selftests.c: Fix common/ includes.
6686         * unittests/style-selftests.c: Fix common/ includes.
6687         * unittests/string_view-selftests.c: Fix common/ includes.
6688         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6689         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6690         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6691         * unittests/rsp-low-selftests.c: Fix common/ includes.
6692         * unittests/parse-connection-spec-selftests.c: Fix common/
6693         includes.
6694         * unittests/optional-selftests.c: Fix common/ includes.
6695         * unittests/offset-type-selftests.c: Fix common/ includes.
6696         * unittests/observable-selftests.c: Fix common/ includes.
6697         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6698         * unittests/memrange-selftests.c: Fix common/ includes.
6699         * unittests/memory-map-selftests.c: Fix common/ includes.
6700         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6701         * unittests/function-view-selftests.c: Fix common/ includes.
6702         * unittests/environ-selftests.c: Fix common/ includes.
6703         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6704         * unittests/common-utils-selftests.c: Fix common/ includes.
6705         * unittests/cli-utils-selftests.c: Fix common/ includes.
6706         * unittests/array-view-selftests.c: Fix common/ includes.
6707         * ui-file.c: Fix common/ includes.
6708         * tui/tui-io.c: Fix common/ includes.
6709         * tracepoint.h: Fix common/ includes.
6710         * tracepoint.c: Fix common/ includes.
6711         * tracefile-tfile.c: Fix common/ includes.
6712         * top.h: Fix common/ includes.
6713         * top.c: Fix common/ includes.
6714         * thread.c: Fix common/ includes.
6715         * target/waitstatus.h: Fix common/ includes.
6716         * target/waitstatus.c: Fix common/ includes.
6717         * target.h: Fix common/ includes.
6718         * target.c: Fix common/ includes.
6719         * target-memory.c: Fix common/ includes.
6720         * target-descriptions.c: Fix common/ includes.
6721         * symtab.h: Fix common/ includes.
6722         * symfile.c: Fix common/ includes.
6723         * stap-probe.c: Fix common/ includes.
6724         * spu-linux-nat.c: Fix common/ includes.
6725         * sparc-nat.c: Fix common/ includes.
6726         * source.c: Fix common/ includes.
6727         * solib.c: Fix common/ includes.
6728         * solib-target.c: Fix common/ includes.
6729         * ser-unix.c: Fix common/ includes.
6730         * ser-tcp.c: Fix common/ includes.
6731         * ser-pipe.c: Fix common/ includes.
6732         * ser-base.c: Fix common/ includes.
6733         * selftest-arch.c: Fix common/ includes.
6734         * s12z-tdep.c: Fix common/ includes.
6735         * rust-exp.y: Fix common/ includes.
6736         * rs6000-aix-tdep.c: Fix common/ includes.
6737         * riscv-tdep.c: Fix common/ includes.
6738         * remote.c: Fix common/ includes.
6739         * remote-notif.h: Fix common/ includes.
6740         * remote-fileio.h: Fix common/ includes.
6741         * remote-fileio.c: Fix common/ includes.
6742         * regcache.h: Fix common/ includes.
6743         * regcache.c: Fix common/ includes.
6744         * record-btrace.c: Fix common/ includes.
6745         * python/python.c: Fix common/ includes.
6746         * python/py-type.c: Fix common/ includes.
6747         * python/py-inferior.c: Fix common/ includes.
6748         * progspace.h: Fix common/ includes.
6749         * producer.c: Fix common/ includes.
6750         * procfs.c: Fix common/ includes.
6751         * proc-api.c: Fix common/ includes.
6752         * printcmd.c: Fix common/ includes.
6753         * ppc-linux-nat.c: Fix common/ includes.
6754         * parser-defs.h: Fix common/ includes.
6755         * osdata.c: Fix common/ includes.
6756         * obsd-nat.c: Fix common/ includes.
6757         * nat/x86-linux.c: Fix common/ includes.
6758         * nat/x86-linux-dregs.c: Fix common/ includes.
6759         * nat/x86-dregs.h: Fix common/ includes.
6760         * nat/x86-dregs.c: Fix common/ includes.
6761         * nat/ppc-linux.c: Fix common/ includes.
6762         * nat/mips-linux-watch.h: Fix common/ includes.
6763         * nat/mips-linux-watch.c: Fix common/ includes.
6764         * nat/linux-waitpid.c: Fix common/ includes.
6765         * nat/linux-ptrace.h: Fix common/ includes.
6766         * nat/linux-ptrace.c: Fix common/ includes.
6767         * nat/linux-procfs.c: Fix common/ includes.
6768         * nat/linux-personality.c: Fix common/ includes.
6769         * nat/linux-osdata.c: Fix common/ includes.
6770         * nat/linux-namespaces.c: Fix common/ includes.
6771         * nat/linux-btrace.h: Fix common/ includes.
6772         * nat/linux-btrace.c: Fix common/ includes.
6773         * nat/fork-inferior.c: Fix common/ includes.
6774         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6775         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6776         * nat/aarch64-linux.c: Fix common/ includes.
6777         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6778         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6779         * namespace.h: Fix common/ includes.
6780         * mips-linux-tdep.c: Fix common/ includes.
6781         * minsyms.c: Fix common/ includes.
6782         * mi/mi-parse.h: Fix common/ includes.
6783         * mi/mi-main.c: Fix common/ includes.
6784         * mi/mi-cmd-env.c: Fix common/ includes.
6785         * memrange.h: Fix common/ includes.
6786         * memattr.c: Fix common/ includes.
6787         * maint.h: Fix common/ includes.
6788         * maint.c: Fix common/ includes.
6789         * main.c: Fix common/ includes.
6790         * machoread.c: Fix common/ includes.
6791         * location.c: Fix common/ includes.
6792         * linux-thread-db.c: Fix common/ includes.
6793         * linux-nat.c: Fix common/ includes.
6794         * linux-fork.c: Fix common/ includes.
6795         * inline-frame.c: Fix common/ includes.
6796         * infrun.c: Fix common/ includes.
6797         * inflow.c: Fix common/ includes.
6798         * inferior.h: Fix common/ includes.
6799         * inferior.c: Fix common/ includes.
6800         * infcmd.c: Fix common/ includes.
6801         * inf-ptrace.c: Fix common/ includes.
6802         * inf-child.c: Fix common/ includes.
6803         * ia64-linux-nat.c: Fix common/ includes.
6804         * i387-tdep.c: Fix common/ includes.
6805         * i386-tdep.c: Fix common/ includes.
6806         * i386-linux-tdep.c: Fix common/ includes.
6807         * i386-linux-nat.c: Fix common/ includes.
6808         * i386-go32-tdep.c: Fix common/ includes.
6809         * i386-fbsd-tdep.c: Fix common/ includes.
6810         * i386-fbsd-nat.c: Fix common/ includes.
6811         * guile/scm-type.c: Fix common/ includes.
6812         * guile/guile.c: Fix common/ includes.
6813         * go32-nat.c: Fix common/ includes.
6814         * gnu-nat.c: Fix common/ includes.
6815         * gdbthread.h: Fix common/ includes.
6816         * gdbarch-selftests.c: Fix common/ includes.
6817         * gdb_usleep.c: Fix common/ includes.
6818         * gdb_select.h: Fix common/ includes.
6819         * gdb_bfd.c: Fix common/ includes.
6820         * gcore.c: Fix common/ includes.
6821         * fork-child.c: Fix common/ includes.
6822         * findvar.c: Fix common/ includes.
6823         * fbsd-nat.c: Fix common/ includes.
6824         * event-top.c: Fix common/ includes.
6825         * event-loop.c: Fix common/ includes.
6826         * dwarf2read.c: Fix common/ includes.
6827         * dwarf2loc.c: Fix common/ includes.
6828         * dwarf2-frame.c: Fix common/ includes.
6829         * dwarf-index-cache.c: Fix common/ includes.
6830         * dtrace-probe.c: Fix common/ includes.
6831         * disasm-selftests.c: Fix common/ includes.
6832         * defs.h: Fix common/ includes.
6833         * csky-tdep.c: Fix common/ includes.
6834         * cp-valprint.c: Fix common/ includes.
6835         * cp-support.h: Fix common/ includes.
6836         * cp-support.c: Fix common/ includes.
6837         * corelow.c: Fix common/ includes.
6838         * completer.h: Fix common/ includes.
6839         * completer.c: Fix common/ includes.
6840         * compile/compile.c: Fix common/ includes.
6841         * compile/compile-loc2c.c: Fix common/ includes.
6842         * compile/compile-cplus-types.c: Fix common/ includes.
6843         * compile/compile-cplus-symbols.c: Fix common/ includes.
6844         * command.h: Fix common/ includes.
6845         * cli/cli-dump.c: Fix common/ includes.
6846         * cli/cli-cmds.c: Fix common/ includes.
6847         * charset.c: Fix common/ includes.
6848         * build-id.c: Fix common/ includes.
6849         * btrace.h: Fix common/ includes.
6850         * btrace.c: Fix common/ includes.
6851         * breakpoint.h: Fix common/ includes.
6852         * breakpoint.c: Fix common/ includes.
6853         * ax.h:
6854         (enum agent_op): Fix common/ includes.
6855         * ax-general.c (struct aop_map): Fix common/ includes.
6856         * ax-gdb.c: Fix common/ includes.
6857         * auxv.c: Fix common/ includes.
6858         * auto-load.c: Fix common/ includes.
6859         * arm-tdep.c: Fix common/ includes.
6860         * arch/riscv.c: Fix common/ includes.
6861         * arch/ppc-linux-common.c: Fix common/ includes.
6862         * arch/i386.c: Fix common/ includes.
6863         * arch/arm.c: Fix common/ includes.
6864         * arch/arm-linux.c: Fix common/ includes.
6865         * arch/arm-get-next-pcs.c: Fix common/ includes.
6866         * arch/amd64.c: Fix common/ includes.
6867         * arch/aarch64.c: Fix common/ includes.
6868         * arch/aarch64-insn.c: Fix common/ includes.
6869         * arch-utils.c: Fix common/ includes.
6870         * amd64-windows-tdep.c: Fix common/ includes.
6871         * amd64-tdep.c: Fix common/ includes.
6872         * amd64-sol2-tdep.c: Fix common/ includes.
6873         * amd64-obsd-tdep.c: Fix common/ includes.
6874         * amd64-nbsd-tdep.c: Fix common/ includes.
6875         * amd64-linux-tdep.c: Fix common/ includes.
6876         * amd64-linux-nat.c: Fix common/ includes.
6877         * amd64-fbsd-tdep.c: Fix common/ includes.
6878         * amd64-fbsd-nat.c: Fix common/ includes.
6879         * amd64-dicos-tdep.c: Fix common/ includes.
6880         * amd64-darwin-tdep.c: Fix common/ includes.
6881         * agent.c: Fix common/ includes.
6882         * ada-lang.h: Fix common/ includes.
6883         * ada-lang.c: Fix common/ includes.
6884         * aarch64-tdep.c: Fix common/ includes.
6885
6886 2019-01-25  Tom Tromey  <tom@tromey.com>
6887
6888         * common/create-version.sh: Use common/version.h.
6889
6890 2019-01-24  Pedro Alves  <palves@redhat.com>
6891
6892         * infrun.c (signal_stop, signal_print, signal_program)
6893         (signal_catch, signal_pass): Now arrays instead of pointers.
6894         (update_signals_program_target, do_target_resume)
6895         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6896         * linux-nat.c (linux_nat_target::pass_signals)
6897         (linux_nat_target::create_inferior, linux_nat_target::attach):
6898         Adjust.
6899         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6900         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6901         * procfs.c (procfs_target::pass_signals): Adjust.
6902         * record-full.c (record_full_target::resume): Adjust.
6903         * remote.c (remote_target::pass_signals)
6904         (remote_target::program_signals): Adjust.
6905         * target-debug.h (target_debug_print_signals): Now takes a
6906         gdb::array_view as parameter.  Adjust.
6907         * target.h (target_ops) <pass_signals, program_signals>: Replace
6908         pointer and length parameters with gdb::array_view.
6909         (target_pass_signals, target_program_signals): Likewise.
6910         * target-delegates.c: Regenerate.
6911
6912 2019-01-24  Pedro Alves  <palves@redhat.com>
6913
6914         * common/forward-scope-exit.h
6915         (forward_scope_exit::forward_scope_exit): Pass arguments to
6916         m_bind_function directly, instead of creating a std::bind and
6917         copying that.
6918
6919 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6920
6921         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6922         for static members.
6923         (pass_in_v_vfp_candidate): Likewise.
6924
6925 2019-01-23  Tom Tromey  <tom@tromey.com>
6926             Pedro Alves  <palves@redhat.com>
6927
6928         * regcache.c (class regcache_invalidator): Remove.
6929         (regcache::raw_write): Use make_scope_exit.
6930
6931 2019-01-23  Tom Tromey  <tom@tromey.com>
6932
6933         * ui-out.h (class ui_out_emit_type): Update comment.
6934
6935 2019-01-23  Tom Tromey  <tom@tromey.com>
6936
6937         * infrun.c (fetch_inferior_event): Update comment.
6938
6939 2019-01-23  Tom Tromey  <tom@tromey.com>
6940             Pedro Alves  <palves@redhat.com>
6941
6942         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6943         parameter.
6944         (fetch_inferior_event): Use SCOPE_EXIT.
6945
6946
6947 2019-01-23  Tom Tromey  <tom@tromey.com>
6948             Pedro Alves  <palves@redhat.com>
6949
6950         * infrun.c (disable_thread_events): Delete.
6951         (stop_all_threads): Use SCOPE_EXIT.
6952
6953 2019-01-23  Tom Tromey  <tom@tromey.com>
6954             Pedro Alves  <palves@redhat.com>
6955
6956         * symfile.c: Include forward-scope-exit.h.
6957         (clear_symtab_users_cleanup): Replace forward declaration with
6958         a FORWARD_SCOPE_EXIT.
6959         (syms_from_objfile_1): Use the forward_scope_exit and
6960         gdb::optional instead of cleanup_function.
6961         (reread_symbols): Use the forward_scope_exit instead of
6962         cleanup_function.
6963         (clear_symtab_users_cleanup): Remove function.
6964
6965 2019-01-23  Tom Tromey  <tom@tromey.com>
6966             Pedro Alves  <palves@redhat.com>
6967
6968         * linux-nat.c: Include scope-exit.h.
6969         (cleanup_target_stop): Remove.
6970         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6971         SCOPE_EXIT.
6972
6973 2019-01-23  Tom Tromey  <tom@tromey.com>
6974             Pedro Alves  <palves@redhat.com>
6975
6976         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6977         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6978
6979 2019-01-23  Tom Tromey  <tom@tromey.com>
6980             Andrew Burgess  <andrew.burgess@embecosm.com>
6981             Pedro Alves  <palves@redhat.com>
6982
6983         * infrun.c (fetch_inferior_event): Use scope_exit.
6984         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6985         * top.c (execute_command): Use scope_exit.
6986         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6987         * utils.c (do_bpstat_clear_actions_cleanup)
6988         (make_bpstat_clear_actions_cleanup): Remove.
6989
6990 2019-01-23  Tom Tromey  <tom@tromey.com>
6991             Pedro Alves  <palves@redhat.com>
6992
6993         * infrun.c: Include "common/scope-exit.h"
6994         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6995         (wait_for_inferior): Use SCOPE_EXIT.
6996         (fetch_inferior_event): Use scope_exit.
6997
6998 2019-01-23  Tom Tromey  <tom@tromey.com>
6999             Pedro Alves  <palves@redhat.com>
7000
7001         * breakpoint.c (create_breakpoint): Remove cleanup.
7002
7003 2019-01-23  Tom Tromey  <tom@tromey.com>
7004             Andrew Burgess  <andrew.burgess@embecosm.com>
7005             Pedro Alves  <palves@redhat.com>
7006
7007 2019-01-23  Pedro Alves  <palves@redhat.com>
7008
7009         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7010
7011 2019-01-23  Pedro Alves  <palves@redhat.com>
7012             Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * gdbthread.h: Include "common/forward-scope-exit.h".
7015         (scoped_finish_thread_state): Redefine custom class in terms of
7016         forward_scope_exit.
7017
7018 2019-01-23  Pedro Alves  <palves@redhat.com>
7019             Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * common/forward-scope-exit.h: New file.
7022
7023 2019-01-23  Pedro Alves  <palves@redhat.com>
7024             Andrew Burgess  <andrew.burgess@embecosm.com>
7025             Tom Tromey  <tom@tromey.com>
7026
7027         * common/scope-exit.h: New file.
7028
7029 2019-01-23  Pedro Alves  <palves@redhat.com>
7030
7031         * common/preprocessor.h (ESC): Rename to ...
7032         (ESC_PARENS): ... this.
7033         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7034         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7035
7036 2019-01-23  Tom Tromey  <tom@tromey.com>
7037
7038         * language.h (class scoped_switch_to_sym_language_if_auto):
7039         Initialize m_lang in both cases.
7040
7041 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7042
7043         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7044         with XCNEW.
7045
7046 2019-01-22  Tom Tromey  <tom@tromey.com>
7047
7048         * corelow.c: Do not include sys/file.h.
7049
7050 2019-01-22  Tom Tromey  <tom@tromey.com>
7051
7052         * tui/tui-wingeneral.h: Include gdb_curses.h.
7053
7054 2019-01-22  Tom Tromey  <tom@tromey.com>
7055
7056         * source-cache.h (class source_cache) <get_source_lines,
7057         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7058
7059 2019-01-22  Tom Tromey  <tom@tromey.com>
7060
7061         * remote-fileio.h (struct remote_target): Declare.
7062
7063 2019-01-22  Tom Tromey  <tom@tromey.com>
7064
7065         * python/py-arch.c: Do not include py-ref.h.
7066         * python/py-bpevent.c: Do not include py-ref.h.
7067         * python/py-cmd.c: Do not include py-ref.h.
7068         * python/py-continueevent.c: Do not include py-ref.h.
7069         * python/py-event.h: Do not include py-ref.h.
7070         * python/py-evtregistry.c: Do not include py-ref.h.
7071         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7072         * python/py-frame.c: Do not include py-ref.h.
7073         * python/py-framefilter.c: Do not include py-ref.h.
7074         * python/py-function.c: Do not include py-ref.h.
7075         * python/py-infevents.c: Do not include py-ref.h.
7076         * python/py-linetable.c: Do not include py-ref.h.
7077         * python/py-objfile.c: Do not include py-ref.h.
7078         * python/py-param.c: Do not include py-ref.h.
7079         * python/py-prettyprint.c: Do not include py-ref.h.
7080         * python/py-progspace.c: Do not include py-ref.h.
7081         * python/py-symbol.c: Do not include py-ref.h.
7082         * python/py-symtab.c: Do not include py-ref.h.
7083         * python/py-type.c: Do not include py-ref.h.
7084         * python/py-unwind.c: Do not include py-ref.h.
7085         * python/py-utils.c: Do not include py-ref.h.
7086         * python/py-value.c: Do not include py-ref.h.
7087         * python/py-varobj.c: Do not include py-ref.h.
7088         * python/py-xmethods.c: Do not include py-ref.h.
7089         * python/python.c: Do not include py-ref.h.
7090         * varobj.c: Do not include py-ref.h.
7091
7092 2019-01-22  Tom Tromey  <tom@tromey.com>
7093
7094         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7095         keyword for bcache.
7096
7097 2019-01-22  Tom Tromey  <tom@tromey.com>
7098
7099         * compile/compile-cplus-types.c: Remove a comment by #include.
7100
7101 2019-01-22  Tom Tromey  <tom@tromey.com>
7102
7103         * compile/gcc-c-plugin.h: Include compile-internal.h.
7104
7105 2019-01-22  Tom Tromey  <tom@tromey.com>
7106
7107         * stabsread.c (EXTERN): Do not define.
7108         (symnum, next_symbol_text_func, processing_gcc_compilation)
7109         (within_function, global_sym_chain, global_stabs)
7110         (previous_stab_code, this_object_header_files)
7111         (n_this_object_header_files)
7112         (n_allocated_this_object_header_files): Define.
7113         * stabsread.h (EXTERN): Never define.  Use "extern".
7114
7115 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7116
7117         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7118         history_value.
7119
7120 2019-01-21  Tom Tromey  <tom@tromey.com>
7121
7122         * ui-out.c: Fix includes.
7123         * tui/tui-source.c: Fix includes.
7124         * target.c: Fix includes.
7125         * remote.c: Fix includes.
7126         * regcache.c: Fix includes.
7127         * python/py-block.c: Fix includes.
7128         * printcmd.c: Fix includes.
7129         * or1k-tdep.c: Fix includes.
7130         * mi/mi-main.c: Fix includes.
7131         * m32r-tdep.c: Fix includes.
7132         * csky-tdep.c: Fix includes.
7133         * compile/compile-cplus-types.c: Fix includes.
7134         * cli/cli-interp.c: Fix includes.
7135
7136 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7137
7138         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7139         for padding.
7140
7141 2019-01-16  Tom Tromey  <tom@tromey.com>
7142
7143         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7144         earlier.
7145         (struct objfile) <msymbols_range>: Move from top level.
7146         <msymbols>: New method.
7147         (class objfile_msymbols): Remove.
7148         * symtab.c (default_collect_symbol_completion_matches_break_on):
7149         Update.
7150         * symmisc.c (dump_msymbols): Update.
7151         * stabsread.c (scan_file_globals): Update.
7152         * objc-lang.c (info_selectors_command, info_classes_command)
7153         (find_methods): Update.
7154         * minsyms.c (find_solib_trampoline_target): Update.
7155         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7156         * coffread.c (coff_symfile_read): Update.
7157         * ada-lang.c (ada_lookup_simple_minsym)
7158         (ada_collect_symbol_completion_matches): Update.
7159
7160 2019-01-16  Tom Tromey  <tom@tromey.com>
7161
7162         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7163         type.  Remove no-argument constructor.
7164         <iterator::operator++>: Simplify.
7165         <begin>: Update.
7166         <end>: Use minimal_symbol_count.
7167
7168 2019-01-16  Tom Tromey  <tom@tromey.com>
7169
7170         * objfiles.h (struct objfile) <psymtabs>: New method.
7171         (class objfile_psymtabs): Remove.
7172         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7173         typedef.
7174         <range>: New method.
7175         (require_partial_symbols): Change return type.
7176         * psymtab.c (require_partial_symbols)
7177         (psym_expand_symtabs_matching): Update.
7178         * mdebugread.c (parse_partial_symbols): Update.
7179         * dbxread.c (dbx_end_psymtab): Update.
7180
7181 2019-01-15  Tom Tromey  <tom@tromey.com>
7182
7183         * symtab.c (lookup_objfile_from_block)
7184         (lookup_symbol_in_objfile_symtabs)
7185         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7186         (find_line_symtab, info_sources_command)
7187         (default_collect_symbol_completion_matches_break_on)
7188         (make_source_files_completion_list): Update.
7189         * symmisc.c (print_objfile_statistics, dump_objfile)
7190         (maintenance_print_symbols, maintenance_info_symtabs)
7191         (maintenance_check_symtabs, maintenance_info_line_tables):
7192         Update.
7193         * source.c (select_source_symtab)
7194         (forget_cached_source_info_for_objfile): Update.
7195         * objfiles.h (class objfile_compunits): Remove.
7196         (struct objfile) <compunits_range>: New typedef.
7197         (compunits): New method.
7198         * objfiles.c (objfile_relocate1): Update.
7199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7200         * maint.c (count_symtabs_and_blocks): Update.
7201         * linespec.c (iterate_over_all_matching_symtabs): Update.
7202         * cp-support.c (add_symbol_overload_list_qualified): Update.
7203         * coffread.c (coff_symtab_read): Update.
7204         * ada-lang.c (add_nonlocal_symbols)
7205         (ada_collect_symbol_completion_matches)
7206         (ada_add_global_exceptions): Update.
7207
7208 2019-01-15  Tom Tromey  <tom@tromey.com>
7209
7210         * progspace.h (program_space) <objfiles_safe_range>: New
7211         typedef.
7212         <objfiles_safe>: New method.
7213         * objfiles.h (class all_objfiles_safe): Remove.
7214         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7215         * jit.c (jit_inferior_exit_hook): Update.
7216
7217 2019-01-17  Tom Tromey  <tom@tromey.com>
7218
7219         * progspace.h (program_space) <objfiles_range>: New typedef.
7220         <objfiles>: New method.
7221         <objfiles_head>: Rename from objfiles.
7222         (object_files): Update.
7223         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7224         * guile/scm-pretty-print.c
7225         (ppscm_find_pretty_printer_from_objfiles): Update.
7226         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7227         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7228         Update.
7229         * python/py-progspace.c (pspy_get_objfiles): Update.
7230         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7231         Update.
7232         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7233         (objfpy_lookup_objfile_by_build_id): Update.
7234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7235         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7236         Update.
7237         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7238         (expand_symtab_containing_pc, lookup_objfile_from_block)
7239         (lookup_static_symbol, basic_lookup_transparent_type)
7240         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7241         (find_line_symtab, info_sources_command)
7242         (default_collect_symbol_completion_matches_break_on)
7243         (make_source_files_completion_list, find_main_name): Update.
7244         * symmisc.c (print_symbol_bcache_statistics)
7245         (print_objfile_statistics, maintenance_print_symbols)
7246         (maintenance_print_msymbols, maintenance_print_objfiles)
7247         (maintenance_info_symtabs, maintenance_check_symtabs)
7248         (maintenance_expand_symtabs, maintenance_info_line_tables):
7249         Update.
7250         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7251         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7252         (map_overlay_command, unmap_overlay_command)
7253         (simple_overlay_update, expand_symtabs_matching)
7254         (map_symbol_filenames): Update.
7255         * symfile-debug.c (set_debug_symfile): Update.
7256         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7257         Update.
7258         * source.c (select_source_symtab, forget_cached_source_info):
7259         Update.
7260         * solib.c (solib_read_symbols): Update.
7261         * solib-spu.c (append_ocl_sos): Update.
7262         * psymtab.c (maintenance_print_psymbols)
7263         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7264         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7265         * printcmd.c (info_symbol_command): Update.
7266         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7267         Update.
7268         * objfiles.h (class all_objfiles): Remove.
7269         * objfiles.c (have_partial_symbols, have_full_symbols)
7270         (have_minimal_symbols, qsort_cmp, update_section_map)
7271         (shared_objfile_contains_address_p)
7272         (default_iterate_over_objfiles_in_search_order): Update.
7273         * objc-lang.c (info_selectors_command, info_classes_command)
7274         (find_methods): Update.
7275         * minsyms.c (find_solib_trampoline_target): Update.
7276         * maint.c (maintenance_info_sections)
7277         (maintenance_translate_address, count_symtabs_and_blocks):
7278         Update.
7279         * main.c (captured_main_1): Update.
7280         * linux-thread-db.c (try_thread_db_load_from_pdir)
7281         (has_libpthread): Update.
7282         * linespec.c (iterate_over_all_matching_symtabs)
7283         (search_minsyms_for_name): Update.
7284         * jit.c (jit_find_objf_with_entry_addr): Update.
7285         * hppa-tdep.c (find_unwind_entry)
7286         (hppa_lookup_stub_minimal_symbol): Update.
7287         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7288         Update.
7289         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7290         (elf_gnu_ifunc_resolve_by_got): Update.
7291         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7292         * dwarf-index-write.c (save_gdb_index_command): Update.
7293         * cp-support.c (add_symbol_overload_list_qualified): Update.
7294         * breakpoint.c (create_overlay_event_breakpoint)
7295         (create_longjmp_master_breakpoint)
7296         (create_std_terminate_master_breakpoint)
7297         (create_exception_master_breakpoint): Update.
7298         * blockframe.c (find_pc_partial_function): Update.
7299         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7300         (ada_collect_symbol_completion_matches)
7301         (ada_add_global_exceptions): Update.
7302
7303 2019-01-17  Tom Tromey  <tom@tromey.com>
7304
7305         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7306         declare VEC.
7307         (solib_target_parse_libraries): Change return type.
7308         (library_list_start_segment, library_list_start_section)
7309         (library_list_end_library, library_list_start_library); Update.
7310         (solib_target_free_library_list): Remove.
7311         (solib_target_parse_libraries): Remove cleanup.  Change return
7312         type.
7313         (solib_target_current_sos): Update.
7314
7315 2019-01-17  Tom Tromey  <tromey@bapiya>
7316
7317         * valprint.c: Replace "the the" with "the".
7318         * symtab.c: Replace "the the" with "the".
7319         * solib.c: Replace "the the" with "the".
7320         * solib-dsbt.c: Replace "the the" with "the".
7321         * linespec.c: Replace "the the" with "the".
7322         * dwarf2loc.h: Replace "the the" with "the".
7323         * amd64-windows-tdep.c: Replace "the the" with "the".
7324         * aarch64-tdep.c: Replace "the the" with "the".
7325
7326 2019-01-16  Keith Seitz  <keiths@redhat.com>
7327
7328         PR gdb/23773
7329         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7330         <builder>: Rename to ..
7331         <m_builder>: ... this and make private.
7332         (dwarf2_cu::get_builder): New method.  Change all users of
7333         `builder' to use this method.
7334         (dwarf2_start_symtab): Move to ...
7335         (dwarf2_cu::start_symtab): ... here.  Update all callers
7336         (setup_type_unit_groups): Move to ...
7337         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7338         callers.
7339         (dwarf2_cu::reset_builder): New method.
7340         (process_full_compunit, process_full_type_unit): Use
7341         dwarf2_cu::reset_builder.
7342         (follow_die_offset): Record the ancestor CU if it is different
7343         from the followed DIE's CU.
7344         (follow_die_sig_1): Likewise.
7345
7346 2019-01-15  Tom Tromey  <tom@tromey.com>
7347
7348         * remote.c (class remote_state) <buf>: Now a char_vector.
7349         <buf_size>: Remove.
7350         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7351         parameter.
7352         (remote_target::getpkt_or_notif_sane_1)
7353         (remote_target::getpkt_sane)
7354         (remote_target::getpkt_or_notif_sane): Likewise.
7355         (class remote_target) <putpkt>: New overload.
7356         (remote_target::read_frame): Change type of "buf_p".  Remove
7357         sizeof_p parameter.
7358         (packet_ok): New overload.
7359         (packet_check_result): New overload.
7360         Update all uses.
7361
7362 2019-01-14  Tom Tromey  <tom@tromey.com>
7363
7364         * remote-notif.c (handle_notification, remote_notif_ack)
7365         (remote_notif_parse): Make "buf" const.
7366         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7367         const.
7368         (remote_notif_parse, remote_notif_ack, handle_notification):
7369         Likewise.
7370         * remote.c (remote_notif_stop_parse): Make "buf" const.
7371         (remote_target::remote_parse_stop_reply): Make "buf" const.
7372         (remote_notif_stop_ack): Make "buf" const.
7373
7374 2019-01-14  Tom Tromey  <tom@tromey.com>
7375
7376         * remote.c (remote_console_output): Make parameter const.
7377
7378 2019-01-14  Tom Tromey  <tom@tromey.com>
7379
7380         * target-debug.h (target_debug_print_signals): Constify.
7381         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7382         * procfs.c (procfs_target::pass_signals): Update.
7383         * linux-nat.c (linux_nat_target::pass_signals): Update.
7384         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7385         * target-delegates.c: Rebuild.
7386         * remote.c (remote_target::program_signals): Update.
7387         (remote_target::pass_signals): Update.
7388         * target.c (target_pass_signals): Constify argument.
7389         (target_program_signals): Likewise.
7390         * target.h (struct target_ops) <pass_signals, program_signals>:
7391         Constify argument.
7392         (target_pass_signals, target_program_signals): Constify argument.
7393
7394 2019-01-14  Tom Tromey  <tom@tromey.com>
7395
7396         PR tui/28819:
7397         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7398
7399 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7400
7401         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7402         field.
7403         * rs6000-tdep.c: Include reggroups.h.
7404         (IS_V_ALIAS_PSEUDOREG): Define.
7405         (rs6000_register_name): Return names for the "vX" aliases.
7406         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7407         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7408         aliases.  Call default_register_reggroup_p for all other
7409         pseudo-registers.
7410         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7411         New functions.
7412         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7413         Handle "vX" aliases.
7414         (v_alias_pseudo_register_collect): New function.
7415         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7416         (rs6000_gdbarch_init): Initialize "vX" aliases as
7417         pseudo-registers.  Restore registration of
7418         rs6000_pseudo_register_reggroup_p with
7419         set_tdesc_pseudo_register_reggroup_p.
7420
7421 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7422
7423         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7424         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7425         set_gdbarch_num_pseudo_regs.
7426
7427 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7428
7429         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7430         Remove arg prefixname, add do_set and do_show.
7431         Add member functions set_list and show_list.
7432         * cli/cli-style.c (class cli_style_option): Update accordingly.
7433         (style_set_list): Move to file scope.
7434         (style_show_list): Likewise.
7435         (set_style): Call help_list.
7436         (show_style): Call cmd_show_list.
7437         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7438         Update to use the new macro.
7439
7440 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7441
7442         * ada-lang.c (_initialize_ada_language): Expand the help text
7443         for the "catch exception" command.
7444
7445 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7446
7447         * symtab.c (matching_obj_sections): Initialize obj,
7448         declare it closer to its usage.
7449
7450 2019-01-10  Tom Tromey  <tom@tromey.com>
7451
7452         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7453         (basic_inf_threads_range): Remove.
7454         (inf_threads_range, inf_non_exited_threads_range)
7455         (safe_inf_threads_range): Use next_adapter.
7456
7457 2019-01-10  Keith Seitz  <keiths@redhat.com>
7458
7459         PR gdb/23712
7460         PR symtab/23010
7461         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7462         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7463
7464 2019-01-10  Keith Seitz  <keiths@redhat.com>
7465
7466         PR gdb/23712
7467         PR symtab/23010
7468         * dictionary.c (pending_to_vector): Remove.
7469         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7470         Remove _1 suffix, replacing functions of the same name.  Update
7471         all callers.
7472         (dict_create_hashed, dict_create_hashed_expandable)
7473         (dict_create_linear, dict_create_linear_expandable, dict_free)
7474         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7475         Make functions static.
7476
7477 2019-01-10  Keith Seitz  <keiths@redhat.com>
7478
7479         PR gdb/23712
7480         PR symtab/23010
7481         * dictionary.h (struct dictionary): Replace declaration with
7482         multidictionary.
7483         (dict_create_hashed, dict_create_hashed_expandable)
7484         (dict_create_linear, dict_create_linear_expandable)
7485         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7486         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7487         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7488         taking multidictionary argument.
7489         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7490         * block.h (struct block) <dict>: Change to multidictionary
7491         and rename `multidict'.
7492         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7493         symmisc.c: Update all dictionary references to multidictionary.
7494
7495 2019-01-10  Keith Seitz  <keiths@redhat.com>
7496
7497         PR gdb/23712
7498         PR symtab/23010
7499         * dictionary.c: Include unordered_map.
7500         (pending_to_vector): New function.
7501         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7502         Rewrite the non-"_1" functions to take vector instead
7503         of linked list.
7504         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7505         "new" _1 versions of the same name.
7506         (multidictionary): Define.
7507         (std::hash<enum language): New definition.
7508         (collate_pending_symbols_by_language, mdict_create_hashed)
7509         (mdict_create_hashed_expandable, mdict_create_linear)
7510         (mdict_create_linear_expandable, mdict_free)
7511         (find_language_dictionary, create_new_language_dictionary)
7512         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7513         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7514         (mdict_size, mdict_empty): New functions.
7515         * dictionary.h (mdict_iterator): Define.
7516
7517 2019-01-10  Pedro Alves  <palves@redhat.com>
7518
7519         * breakpoint.c (read_uploaded_action)
7520         (create_tracepoint_from_upload): Adjust to use
7521         gdb::unique_xmalloc_ptr.
7522         * ctf.c (ctf_write_uploaded_tp):
7523         (SET_ARRAY_FIELD): Use emplace_back.
7524         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7525         * tracefile-tfile.c (tfile_write_uploaded_tp):
7526         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7527         gdb::unique_xmalloc_ptr.
7528         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7529         at_string, cond_string, cmd_strings>: Replace char pointers
7530         with gdb::unique_xmalloc_ptr.
7531
7532 2019-01-10  Pedro Alves  <palves@redhat.com>
7533
7534         * solib-target.c (library_list_start_library): Don't xstrdup name.
7535
7536 2019-01-10  Pedro Alves  <palves@redhat.com>
7537
7538         * mdebugread.c (parse_partial_symbols): Use
7539         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7540
7541 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7542
7543         * linux-fork.c (scoped_switch_fork_info)
7544         <~scoped_switch_fork_info>: Fix incorrect variable name.
7545
7546 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * linux-fork.c (scoped_switch_fork_info)
7549         <scoped_switch_fork_info>: Make explicit.
7550         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7551
7552 2019-01-10  Tom Tromey  <tom@tromey.com>
7553
7554         * objfiles.h (objfile::reset_psymtabs): Update.
7555         * objfiles.c (objfile::objfile): Update.
7556         * psymtab.h (psymtab_storage::obstack): Update.
7557         (psymtab_storage::m_obstack): Use gdb::optional.
7558         (class psymtab_storage): Update comment.  Remove objfile
7559         parameter.
7560         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7561
7562 2019-01-10  Tom Tromey  <tom@tromey.com>
7563
7564         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7565         <free_psymtabs>: Now private.
7566         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7567         (allocate_psymtab): Use new method.
7568
7569 2019-01-10  Tom Tromey  <tom@tromey.com>
7570
7571         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7572         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7573         * mdebugread.c (parse_partial_symbols): Use
7574         allocate_dependencies.
7575         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7576         allocate_dependencies.
7577         (process_psymtab_comp_unit_reader)
7578         (build_type_psymtab_dependencies): Likewise.
7579         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7580
7581 2019-01-10  Tom Tromey  <tom@tromey.com>
7582
7583         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7584         PSYMBOL_SET_LANGUAGE.
7585         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7586
7587 2019-01-10  Tom Tromey  <tom@tromey.com>
7588
7589         * psymtab.h (psymtab_storage::obstack): New method.
7590         <m_obstack>: Rename from obstack; now private.
7591         * psymtab.c (psymtab_storage): Update.
7592         * dwarf2read.c (create_addrmap_from_index)
7593         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7594         Update.
7595
7596 2019-01-10  Tom Tromey  <tom@tromey.com>
7597
7598         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7599         * objfiles.h (objfile::reset_psymtabs): New method.
7600
7601 2019-01-10  Tom Tromey  <tom@tromey.com>
7602
7603         * symmisc.c (print_symbol_bcache_statistics): Update.
7604         (print_objfile_statistics): Update.
7605         * symfile.c (reread_symbols): Update.
7606         * psymtab.h (class psymtab_storage): New.
7607         * psymtab.c (psymtab_storage): New constructor.
7608         (~psymtab_storage): New destructor.
7609         (require_partial_symbols): Update.
7610         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7611         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7612         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7613         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7614         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7615         (start_psymtab_common, end_psymtab_common)
7616         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7617         (allocate_psymtab): Update.
7618         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7619         Update.
7620         (dump_psymtab_addrmap, maintenance_print_psymbols)
7621         (maintenance_check_psymtabs): Update.
7622         (class objfile_psymtabs): Move to objfiles.h.
7623         * psympriv.h (discard_psymtab): Now inline.
7624         (psymtab_discarder::psymtab_discarder): Update.
7625         (psymtab_discarder::~psymtab_discarder): Update.
7626         (ALL_OBJFILE_PSYMTABS): Rewrite.
7627         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7628         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7629         Remove fields.
7630         <partial_symtabs>: New field.
7631         (class objfile_psymtabs): Move from psymtab.h.  Update.
7632         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7633         psymbol_cache.
7634         (objfile::~objfile): Don't destroy psymbol_cache.
7635         * mdebugread.c (parse_partial_symbols): Update.
7636         * dwarf2read.c (create_addrmap_from_index)
7637         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7638         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7639         (add_partial_subprogram, dwarf2_ranges_read): Update.
7640         * dwarf-index-write.c (write_address_map)
7641         (write_one_signatured_type, recursively_write_psymbols)
7642         (class debug_names, class debug_names, write_psymtabs_to_index):
7643         Update.
7644
7645 2019-01-10  Tom Tromey  <tom@tromey.com>
7646
7647         * symtab.h (SYMBOL_SET_NAMES): Update.
7648         (symbol_set_names): Update.
7649         (MSYMBOL_SET_NAMES): Update.
7650         * symtab.c (symbol_set_names): Change argument to be an
7651         objfile_per_bfd_storage.
7652         * psymtab.c (add_psymbol_to_bcache): Update.
7653         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7654
7655 2019-01-10  Tom Tromey  <tom@tromey.com>
7656
7657         * symtab.c (create_demangled_names_hash): Change argument to be an
7658         objfile_per_bfd_storage.
7659         (symbol_set_names): Update.
7660
7661 2019-01-10  Tom Tromey  <tom@tromey.com>
7662
7663         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7664         init_psymbol_list.
7665         * psymtab.c (init_psymbol_list): Do nothing if already called.
7666         * psympriv.h (init_psymbol_list): Add comment.
7667         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7668         init_psymbol_list.
7669         * dbxread.c (dbx_symfile_read): Unconditionally call
7670         init_psymbol_list.
7671
7672 2019-01-10  Tom Tromey  <tom@tromey.com>
7673
7674         * xcoffread.c (scan_xcoff_symtab): Update.
7675         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7676         "where".
7677         * mdebugread.c (parse_partial_symbols)
7678         (handle_psymbol_enumerators): Update.
7679         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7680         * dbxread.c (read_dbx_symtab): Update.
7681         * psympriv.h (psymbol_placement): New enum.
7682         (add_psymbol_to_list): Update.
7683
7684 2019-01-10  Tom Tromey  <tom@tromey.com>
7685
7686         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7687         static_psymbols parameters.
7688         (scan_xcoff_symtab): Update.
7689         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7690         static_psymbols parameters.
7691         * psympriv.h (start_psymtab_common): Update.
7692         * mdebugread.c (parse_partial_symbols): Update.
7693         * dwarf2read.c (create_partial_symtab): Update.
7694         * dbxread.c (read_dbx_symtab): Update.
7695         (start_psymtab): Remove global_psymbols and static_psymbols
7696         parameters.
7697
7698 2019-01-10  Tom Tromey  <tom@tromey.com>
7699
7700         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7701         * psymtab.c (allocate_psymtab): Add comment.
7702         * psympriv.h (allocate_psymtab): Add comment.
7703         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7704         initializations.
7705         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7706
7707 2019-01-10  Tom Tromey  <tom@tromey.com>
7708
7709         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7710         Don't declare.
7711         * mipsread.c: Include mdebugread.h.
7712         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7713         Declare.
7714         * elfread.c: Include mdebugread.h.
7715
7716 2019-01-09  Tom Tromey  <tom@tromey.com>
7717
7718         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7719         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7720         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7721         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7722         (psym_lookup_symbol, psym_find_last_source_symtab)
7723         (psym_forget_cached_source_info, psym_print_stats)
7724         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7725         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7726         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7727         (psym_find_compunit_symtab_by_address)
7728         (maintenance_print_psymbols, maintenance_info_psymtabs)
7729         (maintenance_check_psymtabs): Use ranged for.
7730         * psymtab.h (class objfile_psymtabs): New.
7731         (require_partial_symbols): Return objfile_psymtabs.
7732         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7733
7734 2019-01-09  Tom Tromey  <tom@tromey.com>
7735
7736         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7737         (find_pc_mapped_section, list_overlays_command)
7738         (map_overlay_command, unmap_overlay_command)
7739         (simple_overlay_update): Use all_objfiles.
7740         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7741         * printcmd.c (info_symbol_command): Use all_objfiles.
7742         * objfiles.h (ALL_OBJSECTIONS): Remove.
7743         * maint.c (maintenance_translate_address): Use all_objfiles.
7744         * gcore.c (gcore_create_callback): Use all_objfiles.
7745         (objfile_find_memory_regions): Likewise.
7746
7747 2019-01-09  Tom Tromey  <tom@tromey.com>
7748
7749         * symtab.c (find_line_symtab, info_sources_command)
7750         (make_source_files_completion_list): Use objfile_compunits.
7751         * source.c (select_source_symtab): Use objfile_compunits.
7752         * objfiles.h (struct objfile): Update comment.
7753         (ALL_OBJFILES): Remove.
7754         (ALL_FILETABS): Remove.
7755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7756         objfile_compunits.
7757
7758 2019-01-09  Tom Tromey  <tom@tromey.com>
7759
7760         * symmisc.c (print_objfile_statistics, dump_objfile)
7761         (maintenance_print_symbols): Use compunit_filetabs.
7762         * source.c (forget_cached_source_info_for_objfile): Use
7763         compunit_filetabs.
7764         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7765         (ALL_FILETABS): Use compunit_filetabs.
7766         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7767         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7768
7769 2019-01-09  Tom Tromey  <tom@tromey.com>
7770
7771         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7772         (compunit_filetabs): New.
7773         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7774         compunit_filetabs.
7775         (info_sources_command, make_source_files_completion_list): Remove
7776         declaration.
7777         * symmisc.c (print_objfile_statistics, dump_objfile)
7778         (maintenance_print_symbols): Remove declaration.
7779         (maintenance_info_symtabs): Use compunit_filetabs.
7780         (maintenance_info_line_tables): Likewise.
7781         * source.c (select_source_symtab): Change local variable name.
7782         (forget_cached_source_info_for_objfile): Remove declaration.
7783         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7784         * objfiles.c (objfile_relocate1): Remove declaration.
7785         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7786         declaration.
7787         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7788         * coffread.c (coff_symtab_read): Remove declaration.
7789         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7790         compunit_filetabs.
7791
7792 2019-01-09  Tom Tromey  <tom@tromey.com>
7793
7794         * symtab.c (lookup_objfile_from_block)
7795         (find_pc_sect_compunit_symtab, search_symbols)
7796         (default_collect_symbol_completion_matches_break_on): Use
7797         objfile_compunits.
7798         * objfiles.h (ALL_COMPUNITS): Remove.
7799         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7800         * cp-support.c (add_symbol_overload_list_qualified): Use
7801         objfile_compunits.
7802         * ada-lang.c (ada_collect_symbol_completion_matches)
7803         (ada_add_global_exceptions): Use objfile_compunits.
7804
7805 2019-01-09  Tom Tromey  <tom@tromey.com>
7806
7807         * source.c (select_source_symtab)
7808         (forget_cached_source_info_for_objfile): Remove declaration.
7809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7810         declaration.
7811         * maint.c (count_symtabs_and_blocks): Remove declaration.
7812         * cp-support.c (add_symbol_overload_list_qualified): Remove
7813         declaration.
7814         * coffread.c (coff_symtab_read): Remove declaration.
7815         * symtab.c (lookup_symbol_in_objfile_symtabs)
7816         (basic_lookup_transparent_type_1): Use objfile_compunits.
7817         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7818         (info_sources_command, search_symbols)
7819         (default_collect_symbol_completion_matches_break_on)
7820         (make_source_files_completion_list): Remove declaration.
7821         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7822         (ada_collect_symbol_completion_matches)
7823         (ada_add_global_exceptions): Remove declaration.
7824         * linespec.c (iterate_over_all_matching_symtabs): Use
7825         objfile_compunits.
7826         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7827         (class objfile_compunits): New.
7828         (ALL_COMPUNITS): Use objfile_compunits.
7829         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7830         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7831         objfile_compunits.
7832         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7833
7834 2019-01-09  Tom Tromey  <tom@tromey.com>
7835
7836         * symtab.c (search_symbols)
7837         (default_collect_symbol_completion_matches_break_on): Use
7838         objfile_msymbols.
7839         * ada-lang.c (ada_lookup_simple_minsym)
7840         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7841         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7842         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7843         objfile_msymbols.
7844         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7845         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7846         * objc-lang.c (find_methods): Use objfile_msymbols.
7847         (info_selectors_command, info_classes_command): Likewise.
7848         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7849         * objfiles.h (class objfile_msymbols): New.
7850         (ALL_OBJFILE_MSYMBOLS): Remove.
7851         (ALL_MSYMBOLS): Remove.
7852
7853 2019-01-09  Tom Tromey  <tom@tromey.com>
7854
7855         * common/next-iterator.h (next_adapter): Add Iterator template
7856         parameter.
7857         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7858         (class all_objfiles_safe): New.
7859         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7860         * objfiles.c (put_objfile_before): Update comment.
7861         (add_separate_debug_objfile): Likewise.
7862         (free_all_objfiles): Use all_objfiles_safe.
7863         (objfile_purge_solibs): Likewise.
7864
7865 2019-01-09  Tom Tromey  <tom@tromey.com>
7866
7867         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7868         (expand_symtab_containing_pc, lookup_static_symbol)
7869         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7870         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7871         all_objfiles.
7872         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7873         * breakpoint.c (create_overlay_event_breakpoint)
7874         (create_longjmp_master_breakpoint)
7875         (create_std_terminate_master_breakpoint)
7876         (create_exception_master_breakpoint): Use all_objfiles.
7877         * linux-thread-db.c (try_thread_db_load_from_pdir)
7878         (has_libpthread): Use all_objfiles.
7879         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7880         * linespec.c (iterate_over_all_matching_symtabs)
7881         (search_minsyms_for_name): Use all_objfiles.
7882         * maint.c (maintenance_info_sections): Use all_objfiles.
7883         * main.c (captured_main_1): Use all_objfiles.
7884         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7885         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7886         * guile/scm-pretty-print.c
7887         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7888         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7889         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7890         (maintenance_print_msymbols): Use all_objfiles.
7891         * source.c (select_source_symtab): Use all_objfiles.
7892         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7893         * symfile.c (remove_symbol_file_command)
7894         (expand_symtabs_matching, map_symbol_filenames): Use
7895         all_objfiles.
7896         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7897         all_objfiles.
7898         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7899         * objc-lang.c (find_methods): Use all_objfiles.
7900         * objfiles.c (have_partial_symbols, have_full_symbols)
7901         (have_minimal_symbols, qsort_cmp)
7902         (default_iterate_over_objfiles_in_search_order): Use
7903         all_objfiles.
7904         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7905         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7906         (maintenance_check_psymtabs): Use all_objfiles.
7907         (ALL_PSYMTABS): Remove.
7908         * compile/compile-object-run.c (do_module_cleanup): Use
7909         all_objfiles.
7910         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7911         * cp-support.c (add_symbol_overload_list_qualified): Use
7912         all_objfiles.
7913         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7914         Use all_objfiles.
7915         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7917         all_objfiles.
7918         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7919         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7920         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7921         Uses all_objfiles.
7922         * solib.c (solib_read_symbols): Use all_objfiles
7923
7924 2019-01-09  Tom Tromey  <tom@tromey.com>
7925
7926         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7927         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7928         all_objfiles.
7929         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7930         * symmisc.c (print_symbol_bcache_statistics)
7931         (print_objfile_statistics, maintenance_print_objfiles)
7932         (maintenance_info_symtabs, maintenance_check_symtabs)
7933         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7934         all_objfiles.
7935         * source.c (forget_cached_source_info): Use all_objfiles.
7936         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7937         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7938         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7939         * objfiles.c (update_section_map): Use all_objfiles.
7940         (shared_objfile_contains_address_p): Likewise.
7941         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7942         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7943
7944 2019-01-09  Tom Tromey  <tom@tromey.com>
7945
7946         * common/next-iterator.h: New file.
7947         * objfiles.h (class all_objfiles): New.
7948         (struct objfile_iterator): New.
7949
7950 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7951
7952         * NEWS: Move the description of the changed "frame", "select-frame",
7953          and "info frame" commands to the Changed commands section.
7954
7955 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7956
7957         * gdbtypes.c (check_stub_method_group): Remove handling of old
7958         mangling schemes.
7959         * linespec.c (find_methods): Likewise.
7960         * stabsread.c (read_member_functions): Likewise.
7961         * valops.c (search_struct_method): Likewise.
7962         (value_struct_elt_for_reference): Likewise.
7963         * NEWS: Mention this change.
7964
7965 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7966
7967         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7968         print_source_lines.
7969         * source.c (print_source_lines_base): Update line number check.
7970         (print_source_lines): New function.
7971         (source_lines_range::source_lines_range): New function.
7972         * source.h (class source_lines_range): New class.
7973         (print_source_lines): New declaration.
7974
7975 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7976
7977         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7978
7979 2019-01-08  Tom Tromey  <tom@tromey.com>
7980             Simon Marchi  <simon.marchi@ericsson.com>
7981
7982         PR gdb/24060
7983         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7984         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7985         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7986         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7987         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7988         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7989
7990 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * source.c (select_source_symtab): Move header comment to
7993         declaration in source.h.
7994         (forget_cached_source_info_for_objfile): Likewise.
7995         (forget_cached_source_info): Likewise.
7996         (identify_source_line): Likewise.
7997         * source.h (identify_source_line): Move declaration from symtab.h
7998         and add comment from source.c
7999         (print_source_lines): Likewise.
8000         (forget_cached_source_info_for_objfile): Likewise.
8001         (forget_cached_source_info): Likewise.
8002         (select_source_symtab): Likewise.
8003         (enum print_source_lines_flag): Move definition from symtab.h.
8004         * symtab.h (identify_source_line): Move declaration to source.h.
8005         (print_source_lines): Likewise.
8006         (forget_cached_source_info_for_objfile): Likewise.
8007         (forget_cached_source_info): Likewise.
8008         (select_source_symtab): Likewise.
8009         (enum print_source_lines_flag): Move definition to source.h.
8010         * tui/tui-hooks.c: Add 'source.h' include.
8011
8012 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * source.c (print_source_lines_base): Handle requests to print
8015         reverse line number sequences, and guard against empty lines
8016         string.
8017
8018 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8019
8020         * source.c (print_source_lines_base): Fix skip of '\r' if next
8021         character is '\n'.
8022
8023 2019-01-06  Tom Tromey  <tom@tromey.com>
8024
8025         * c-exp.y (struct c_parse_state) <macro_original_text,
8026         expansion_obstack>: New member.
8027         (macro_original_text, expansion_obstack): Remove globals.
8028         (scan_macro_expansion, scanning_macro_expansion)
8029         (finished_macro_expansion): Update.
8030         (scan_macro_cleanup): Remove.
8031         (yylex, c_parse): Update.
8032
8033 2019-01-06  Tom Tromey  <tom@tromey.com>
8034
8035         * c-exp.y (struct c_parse_state) <strings>: New member.
8036         (operator_stoken): Update.
8037
8038 2019-01-06  Tom Tromey  <tom@tromey.com>
8039
8040         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8041         (union type_stack_elt) <typelist_val>: Now a pointer to
8042         std::vector.
8043         (type_stack_cleanup): Don't declare.
8044         (push_typelist): Update.
8045         * parse.c (pop_typelist): Return a std::vector.
8046         (push_typelist): Take a std::vector.
8047         (follow_types): Update.  Do not free args.
8048         (type_stack_cleanup): Remove.
8049         * c-exp.y (struct c_parse_state): New.
8050         (cpstate): New global.
8051         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8052         (nonempty_typelist): Update.
8053         (func_mod): Create a new vector.
8054         (c_parse): Create a c_parse_state.
8055         (check_parameter_typelist): Do not delete params.
8056         (function_method): Update.  Do not delete type_list.
8057
8058 2019-01-06  Tom Tromey  <tom@tromey.com>
8059
8060         PR gdb/28155:
8061         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8062         check_typedef.
8063         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8064         (print_return_value): Likewise.
8065
8066 2019-01-05  Tom Tromey  <tom@tromey.com>
8067
8068         * contrib/cleanup_check.py: Remove.
8069         * contrib/gcc-with-excheck: Remove.
8070         * contrib/exsummary.py: Remove.
8071         * contrib/excheck.py: Remove.
8072
8073 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8074
8075         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8076         NULL. Initialize tpprev to NULL instead of assigning it
8077         to NULL on the next statement.
8078         * windows-nat.c (windows_delete_thread): Remove check for
8079         main_thread_id before printing thread exit notifications.
8080         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8081         Remove thread ID check against main_thread_id.
8082         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8083         windows_delete_thread.
8084         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8085
8086 2019-01-04  Tom Tromey  <tom@tromey.com>
8087
8088         * compile/compile.c (_initialize_compile): Use upper case for
8089         metasyntactic variables.
8090         * symmisc.c (_initialize_symmisc): Use upper case for
8091         metasyntactic variables.
8092         * psymtab.c (_initialize_psymtab): Use upper case for
8093         metasyntactic variables.
8094         * demangle.c (demangle_command): Use upper case for metasyntactic
8095         variables.
8096         (_initialize_demangler): Likewise.
8097         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8098         variables.
8099
8100 2019-01-03  Tom Tromey  <tom@tromey.com>
8101
8102         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8103
8104 2019-01-03  Tom Tromey  <tom@tromey.com>
8105
8106         * python/py-symtab.c (salpy_str): Update.
8107         (struct salpy_sal_object) <symtab>: Now a PyObject.
8108         (salpy_dealloc): Update.
8109         (del_objfile_sal): Use gdbpy_ref.
8110
8111 2019-01-03  Tom Tromey  <tom@tromey.com>
8112
8113         * python/py-type.c (convert_field): Use new_reference.  Return
8114         gdbpy_ref.
8115         (make_fielditem): Return gdbpy_ref.
8116         (typy_fields): Update.
8117         (typy_getitem): Update.
8118         (field_name): Return gdbpy_ref.  Use new_reference.
8119         (typy_iterator_iternext): Update.
8120
8121 2019-01-03  Tom Tromey  <tom@tromey.com>
8122
8123         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8124
8125 2019-01-03  Tom Tromey  <tom@tromey.com>
8126
8127         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8128         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8129         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8130         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8131         (pspy_set_type_printers): Likewise.
8132         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8133         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8134         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8135         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8136         (objfpy_set_type_printers): Likewise.
8137
8138 2019-01-03  Tom Tromey  <tom@tromey.com>
8139
8140         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8141         (gdbpy_print_stack): Use gdbpy_err_fetch.
8142         * python/python-internal.h (class gdbpy_err_fetch): New class.
8143         (class gdbpy_enter) <m_error_type, m_error_value,
8144         m_error_traceback>: Remove.
8145         <m_error>: New member.
8146         (gdbpy_exception_to_string): Don't declare.
8147         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8148         * python/py-value.c (convert_value_from_python): Use
8149         gdbpy_err_fetch.
8150         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8151         gdbpy_exception_to_string.
8152         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8153         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8154         gdbpy_err_fetch.
8155
8156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * linux-nat.c (delete_lwp_cleanup): Delete.
8159         (struct lwp_deleter): New struct.
8160         (lwp_info_up): New typedef.
8161         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8162         lwp_info_up.
8163
8164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * linux-fork.c (class scoped_switch_fork_info): New class.
8167         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8168
8169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8170
8171         * valops.c (find_overload_match): Remove use of null_cleanup, and
8172         calls to do_cleanups.
8173
8174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * compile/compile-cplus-types.c
8177         (compile_cplus_instance::decl_name): Handle changes to
8178         cp_func_name.
8179         * cp-support.c (cp_func_name): Update header comment, update
8180         return type.
8181         * cp-support.h (cp_func_name): Update return type in declaration.
8182         * valops.c (find_overload_match): Move temp_func local to top
8183         level of function and change its type.  Use temp_func to hold and
8184         delete temporary string obtained from cp_func_name.
8185
8186 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8189         gdb::char_vector, remove cleanup, and update uses of `msg`.
8190
8191 2019-01-03  Jim Wilson  <jimw@sifive.com>
8192
8193         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8194
8195 2019-01-02  Tom Tromey  <tom@tromey.com>
8196
8197         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8198         (tdesc_parse_xml): Remove cleanups.
8199         * target-descriptions.h (make_cleanup_free_target_description):
8200         Don't declare.
8201         (target_desc_deleter): New struct.
8202         (target_desc_up): New typedef.
8203         * target-descriptions.c (target_desc_deleter::operator()): Rename
8204         from free_target_description.
8205         (make_cleanup_free_target_description): Remove.
8206
8207 2019-01-02  Tom Tromey  <tom@tromey.com>
8208
8209         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8210         constructor, destructor.
8211         (linespec_parser): Remove typedef.
8212         (~linespec_parser): Rename from linespec_parser_delete.
8213         (linespec_lex_to_end, linespec_complete_label)
8214         (linespec_complete): Update.
8215         (decode_line_full): Remove cleanups.
8216         (decode_line_1): Update.
8217
8218 2019-01-02  Tom Tromey  <tom@tromey.com>
8219
8220         * python/python-internal.h (inferior_to_inferior_object): Change
8221         return type.
8222         * python/py-exitedevent.c (create_exited_event_object): Update.
8223         * python/py-inferior.c (inferior_to_inferior_object): Return
8224         gdbpy_ref.
8225         (python_new_inferior, python_inferior_deleted)
8226         (thread_to_thread_object, delete_thread_object)
8227         (build_inferior_list, gdbpy_selected_inferior): Update.
8228         * python/py-infthread.c (create_thread_object): Update.  Also fail
8229         if inferior_to_inferior_object fails.
8230
8231 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8232
8233         * inferior.h (class inferior) <displaced_step_state>: New field.
8234         * infrun.h (struct displaced_step_state): Move here from
8235         infrun.c.  Initialize fields, add constructor.
8236         <inf>: Remove field.
8237         <reset>: New method.
8238         * infrun.c (struct displaced_step_inferior_state): Move to
8239         infrun.h.
8240         (displaced_step_inferior_states): Remove.
8241         (get_displaced_stepping_state): Adust.
8242         (displaced_step_in_progress_any_inferior): Adjust.
8243         (displaced_step_in_progress_thread): Adjust.
8244         (displaced_step_in_progress): Adjust.
8245         (add_displaced_stepping_state): Remove.
8246         (get_displaced_step_closure_by_addr): Adjust.
8247         (remove_displaced_stepping_state): Remove.
8248         (infrun_inferior_exit): Call displaced_step_state.reset.
8249         (use_displaced_stepping): Don't check for NULL.
8250         (displaced_step_prepare_throw): Call
8251         get_displaced_stepping_state.
8252         (displaced_step_fixup): Don't check for NULL.
8253         (prepare_for_detach): Don't check for NULL.
8254
8255 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8256
8257         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8258          in case of call that did not complete.
8259
8260 2019-01-02  Andrey Utkin  <autkin@undo.io>
8261
8262         * symfile.c (find_separate_debug_file): Fix search of debug files for
8263         remote debuggee.
8264
8265 2019-01-02  Tom Tromey  <tom@tromey.com>
8266
8267         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8268         indentation.
8269         * python/py-frame.c (frapy_older): Remove cast.
8270         (frapy_newer): Likewise.
8271         * python/py-breakpoint.c (local_setattro): Remove cast.
8272         * python/py-arch.c (archpy_name): Remove local variable.
8273         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8274
8275 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8276
8277         * unittests/basic_string_view/element_access/char/empty.cc:
8278         Fix year range in copyright header.
8279
8280 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8281
8282         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8283         Delete.
8284         <operator==>: Update with for removed field.
8285         <hash>: Likewise.
8286         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8287         <isa_features>: ...this.
8288         <abi_features>: New field.
8289         (riscv_isa_flen): Update comment.
8290         (riscv_abi_xlen): New declaration.
8291         (riscv_abi_flen): New declaration.
8292         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8293         isa_features.
8294         (riscv_abi_xlen): New function.
8295         (riscv_isa_flen): Update to get answer from isa_features.
8296         (riscv_abi_flen): New function.
8297         (riscv_has_fp_abi): Update to get answer from abi_features.
8298         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8299         xlen and flen.
8300         (riscv_call_info) <xlen, flen>: Update comment.
8301         (riscv_call_arg_struct): Remove invalid assertions
8302         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8303         is removed.
8304         (riscv_gdbarch_init): Gather isa features and abi features
8305         separately, ensure both match on the gdbarch when reusing an old
8306         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8307         a target with 64-bit float hardware.
8308
8309 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8310
8311         * source.c (search_command_helper): Stop reverse search
8312         when line 1 has been searched.
8313
8314 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8315
8316         * record-full.c (record_full_base_target::close): Rewrite
8317         record_full_core_buf_list free logic.
8318
8319 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8320
8321         * break-catch-syscall.c (print_one_catch_syscall): xfree
8322         the last text.
8323
8324 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8325
8326         * top.c (print_gdb_version): Update Copyright year in version
8327         message.
8328
8329 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8330
8331         Update copyright year range in all GDB files.
8332
8333 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8334
8335         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8336
8337 For older changes see ChangeLog-2018.
8338 \f
8339 Local Variables:
8340 mode: change-log
8341 left-margin: 8
8342 fill-column: 74
8343 version-control: never
8344 coding: utf-8
8345 End:
8346